Buildbot fix for wx port.
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
2
3         Build script fix for buildbot.
4
5         * wx/build-wxwebkit:
6
7 2007-12-20  Eric Seidel  <eric@webkit.org>
8
9         Reviewed by mjs.
10
11         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
12
13 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
14
15         Reviewed by Steve.
16
17         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
18         WebKit.
19
20         - Drosera and Safari need to use the same ProgIDs in order for
21         CoCreateInstance to work properly.  The most robust way to do this is
22         for WebKit to dynamically publish those ProgIDs.
23
24         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
25         (DebuggerClient::createWebViewWithRequest):
26         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
27         statics.
28         (Drosera::initUI):
29         (Drosera::attach):
30         (Drosera::attemptToCreateServerConnection):
31         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
32         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
33         make use of the published ProgIDs.
34         (ServerConnection::attemptToCreateServerConnection):
35
36 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
37
38         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
39         - Build bot and leak fix.
40
41         * DumpRenderTree/LayoutTestController.cpp:
42         (pathToLocalResourceCallback):
43
44 2007-12-19  David Kilzer  <ddkilzer@apple.com>
45
46         Make svn-apply/svn-unapply work with patches from git-format-patch.
47
48         Reviewed by Darin.
49
50         * Scripts/svn-apply:
51         (patch): If 'Index:' can't be found in the text passed in, print it
52         out with a warning and return early.
53         * Scripts/svn-unapply:
54         (patch): Ditto.
55
56 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
57
58         Reviewed by Alp Toker.
59
60         Build related fixes.
61
62         * wx/build-wxwebkit:
63         - Check to make sure the user is running a supported wx port
64         - More robust checks for Cygwin
65         - Only run install-unix-extras on Mac, it's not the right solution
66           for Linux distros.
67         - Remove outdated Linux instructions after successful build
68         - Clean Bakefile-generated files during a clean operation
69
70 2007-12-18  Darin Adler  <darin@apple.com>
71
72         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
73
74 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
75
76         Add script to run Drosera as part of the nightly.
77         
78         Reviewed by Kevin M.
79
80         * Scripts/run-drosera.cmd: Added.
81
82 2007-12-18  Darin Adler  <darin@apple.com>
83
84         * Scripts/do-webcore-rename: Remove a stray K.
85
86 2007-12-18  Darin Adler  <darin@apple.com>
87
88         * Scripts/do-webcore-rename: Plan more renaming.
89
90 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
91
92         Reviewed by Alp Toker.
93
94         http://bugs.webkit.org/show_bug.cgi?id=16042
95         [GTK] Eliminate webkit_init()
96
97         Moving webkit initialization to WebView class init.
98
99         * DumpRenderTree/gtk/DumpRenderTree.cpp:
100         (main):
101         * GtkLauncher/main.c:
102         (main):
103
104 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
105
106         Reviewed by Alp Toker.
107
108         http://bugs.webkit.org/show_bug.cgi?id=13542
109         gdklauncher doesnt change URL in adress GTKEntry.
110
111         * GtkLauncher/main.c:
112         (load_commit_cb): added
113         (title_change_cb):
114         (create_browser):
115
116 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
117
118         Reviewed by Adam Roben.
119
120         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
121
122         * FindSafari/FindSafari.cpp:
123         (_tmain):
124
125 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
126
127         Reviewed by Adam Roben.
128
129         http://bugs.webkit.org/show_bug.cgi?id=16315
130         FindSafari needs a path-only option.
131
132         * FindSafari/FindSafari.cpp:
133         (_tmain):
134
135 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
136
137         Reviewed by Darin.
138
139         http://bugs.webkit.org/show_bug.cgi?id=16462
140         REGRESSION: access keys broken on Windows
141
142         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
143         if Alt is pressed.
144
145 2007-12-15  Sam Weinig  <sam@webkit.org>
146
147         Reviewed by Mark Rowe.
148
149         Fix urlSuitableForTestResult to correctly identify wstring::npos as
150         the case when wstring.find doesn't find anything.
151
152         * DumpRenderTree/win/DumpRenderTree.cpp:
153         (urlSuitableForTestResult):
154
155 2007-12-15  Alp Toker  <alp@atoker.com>
156
157         GTK+ DRT build fix for GLib < 2.14.
158
159         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
160         (LayoutTestController::setWaitToDump):
161
162 2007-12-05  Mark Rowe  <mrowe@apple.com>
163
164         Reviewed by Alp Toker.
165
166         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
167         many layout tests from hanging while waiting on user responses to dialogs.
168
169         * DumpRenderTree/gtk/DumpRenderTree.cpp:
170         (invalidateAnyPreviousWaitToDumpWatchdog):
171         (webViewScriptAlert):
172         (webViewScriptPrompt):
173         (webViewScriptConfirm):
174         (main):
175         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
176         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
177         (waitToDumpWatchdogFired):
178         (LayoutTestController::setWaitToDump):
179
180 2007-12-05  Mark Rowe  <mrowe@apple.com>
181
182         Reviewed by Alp Toker.
183
184         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
185
186         * DumpRenderTree/gtk/DumpRenderTree.cpp:
187         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
188         (dump):
189         (runTest):
190         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
191         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
192         work queue is empty.
193         (webViewWindowObjectCleared): Set up window.layoutTestController.
194         (webViewConsoleMessage): Match the console message format expected by the layout test results.
195         (main): Hook up the new signals.
196         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
197         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
198         dumping multiple times.
199         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
200         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
201
202 2007-12-14  Anders Carlsson  <andersca@apple.com>
203
204         Reviewed by Brady.
205
206         Assert that a web frame that's loading a resource always has either a data source or 
207         a provisional data source.
208         
209         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
210         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
211
212 2007-12-14  Darin Adler  <darin@apple.com>
213
214         - fix mistake causing nearly all tests to fail on Windows
215
216         * DumpRenderTree/win/UIDelegate.cpp:
217         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
218         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
219
220         * DumpRenderTree/mac/UIDelegate.mm:
221         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
222         than passing the entire message.
223
224 2007-12-14  Darin Adler  <darin@apple.com>
225
226         - fix Tiger build
227
228         * DumpRenderTree/mac/UIDelegate.mm:
229         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
230         new-to-Leopard methods.
231
232 2007-12-14  Darin Adler  <darin@apple.com>
233
234         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
235         since it now triggers unwanted icon loading. We only had it because we implemented "all"
236         delegate methods here.
237
238 2007-12-14  Anders Carlsson  <andersca@apple.com>
239
240         Reviewed by Darin and Geoff.
241
242         <rdar://problem/5619295> 
243         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
244         
245         Add property getting methods to the plug-in.
246         
247         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
248         (pluginInvoke):
249
250 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
251
252         Reviewed by Darin.
253
254         - Layout test fix for mac. When dumped to the console local file paths
255         now only show the name of the resource not the whole path.  This is to
256         make the results machine and OS independent.
257
258         * DumpRenderTree/mac/UIDelegate.mm:
259         (-[UIDelegate webView:addMessageToConsole:]):
260
261 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
262
263         Reviewed by Adam.
264
265         - Layout tests fix.  We need a way to remove machine-dependent
266         information from paths in layout test results. The UIDelegate now does
267         this.
268
269         * DumpRenderTree/DumpRenderTree.h:
270         * DumpRenderTree/win/DumpRenderTree.cpp:
271         (urlSuitableForTestResult):
272         * DumpRenderTree/win/DumpRenderTreeWin.h:
273         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
274         * DumpRenderTree/win/UIDelegate.cpp:
275         (UIDelegate::webViewAddMessageToConsole):
276
277 2007-12-13  Alp Toker  <alp@atoker.com>
278
279         Build fix for DRT breakage introduced in r28690.
280
281         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
282         (LayoutTestController::pathToLocalResource):
283
284 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
285
286         Reviewed by Alice and Sam.
287
288         - <rdar://5621435> Need a way to specify local resources (being loaded
289         from HTTP tests) on Windows.
290         - Implemented pathToLocalResource which exposes the functionality of
291         converting a given unix path to the correct location on Windows.
292
293         * DumpRenderTree/LayoutTestController.cpp:
294         (pathToLocalResourceCallback):
295         (LayoutTestController::staticFunctions):
296         * DumpRenderTree/LayoutTestController.h:
297         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
298         (LayoutTestController::pathToLocalResource):
299         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
300         (LayoutTestController::pathToLocalResource):
301
302 2007-12-12  Anders Carlsson  <andersca@apple.com>
303
304         Reviewed by Sam.
305
306         <rdar://problem/5132003>
307         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
308
309         * DumpRenderTree/win/DumpRenderTree.cpp:
310         (main):
311         Set the resource load delegate.
312         
313         * DumpRenderTree/win/DumpRenderTree.vcproj:
314         
315         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
316         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
317
318 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
319
320         Reviewed by Adam Roben.
321
322         Fix conversion from double to LPARAM in dispatchMessage().
323
324         * DumpRenderTree/win/EventSender.cpp:
325         (dispatchMessageCallback):
326
327 2007-12-11  Dan Bernstein  <mitz@apple.com>
328
329         Reviewed by Mark Rowe and Sam Weinig too!
330
331         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
332           fonts DumpRenderTree registers.
333
334         * DumpRenderTree/win/DumpRenderTree.cpp:
335         (initialize):
336
337 2007-12-11  Brady Eidson  <beidson@apple.com>
338
339         Reviewed by Anders
340
341         Make DumpRenderTree on mac use its own path for Databases testing
342
343         * DumpRenderTree/mac/DumpRenderTree.mm:
344         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
345           for future DRT-only use, then use it to construct the Databases path and set that default
346
347 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
348
349         Reviewed by Darin.
350
351         <rdar://problem/5535636>
352         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
353
354         http://bugs.webkit.org/show_bug.cgi?id=13916
355         JavaScript detects Tab as a character input on a textfield validation
356
357         * DumpRenderTree/mac/EventSendingController.mm:
358         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
359         Dispatch a keyup to better match what happens when a key is physically pressed.
360
361         * DumpRenderTree/win/EventSender.cpp:
362         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
363         returning from keyDown().
364         (getConstantCallback): Fixed a couple copy/paste mistakes.
365
366 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
367
368         Reviewed by Oliver.
369
370         - <rdar://5599845> Drosera: Does not show loal files in the file list
371         on the left side.
372
373         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
374         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
375         so the open source community can build.
376
377 2007-12-10  Brady Eidson  <beidson@apple.com>
378
379         Rubberstamped by Sam Weinig
380
381         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
382
383         * DumpRenderTree/mac/UIDelegate.mm:
384         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
385         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
386
387 2007-12-08  Oliver Hunt  <oliver@apple.com>
388
389         Reviewed by Sam W.
390
391         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
392         
393         Fixes <rdar://problem/5620249> Must disable SVG animation
394         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
395         
396         In order to allow finer grained control over the set of SVG features
397         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
398         distinct flags:
399         ENABLE_SVG_ANIMATION
400         ENABLE_SVG_FILTERS
401         ENABLE_SVG_FONTS
402         ENABLE_SVG_AS_IMAGE
403         ENABLE_SVG_USE
404         
405         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
406         
407         Script handles all the new build flags, and allows --svg-experimental
408         to automatically enable all features.
409
410         * Scripts/build-webkit:
411
412 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
413
414         Fix version parsing.
415
416         Rubber-stamped by Oliver.
417
418         * Drosera/win/Drosera.vcproj/auto-version.sh:
419
420 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
421
422         Build modifications for Drosera.
423
424         Reviewed by Adam.
425
426         * Drosera/DroseraWin.make: Added.
427         * Drosera/win/Drosera.vcproj/Drosera.rc:
428         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
429         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
430         * Drosera/win/Drosera.vcproj/VERSION: Added.
431         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
432
433 2007-12-06  Adam Roben  <aroben@apple.com>
434
435         Explicitly turn on the Mac font ascent hack on Windows
436
437         This keeps our font metrics matching those from Mac.
438
439         Reviewed by Hyatt.
440
441         * DumpRenderTree/win/DumpRenderTree.cpp:
442         (main):
443
444 2007-12-06  Anders Carlsson  <andersca@apple.com>
445
446         Rename main.c to main.cpp here too.
447         
448         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
449
450 2007-12-06  Sam Weinig  <sam@webkit.org>
451
452         Rubber stamped by Geoff.
453
454         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
455
456 2007-12-06  Darin Adler  <darin@apple.com>
457
458         * Scripts/do-webcore-rename: Some more renaming plans.
459
460 2007-12-06  Anders Carlsson  <andersca@apple.com>
461
462         Restore implementation of testGetIntIdentifier that was accidentally
463         removed somehow (possibly when I made PluginObject be a cpp file).
464         
465         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
466         (pluginInvoke):
467
468 2007-12-05  Anders Carlsson  <andersca@apple.com>
469
470         Make the entry points extern "C".
471         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
472         
473 2007-12-05  Anders Carlsson  <andersca@apple.com>
474
475         C++ warning fixes.
476         
477         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
478         (NPP_New):
479         (NPP_Destroy):
480         (NPP_SetWindow):
481         (NPP_NewStream):
482         (NPP_HandleEvent):
483         (NPP_URLNotify):
484         (NPP_GetValue):
485
486 2007-12-05  Anders Carlsson  <andersca@apple.com>
487
488         Add the .cpp files to the TestNetscapePlugIn target.
489
490         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
491
492 2007-12-05  Anders Carlsson  <andersca@apple.com>
493
494         Reviewed by Geoff.
495         
496         Rename the TestNetscapePlugIn .c files to be .cpp.
497
498         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
499         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
500         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
501         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
502         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
503         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
504         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
505         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
506
507 2007-12-05  Adam Roben  <aroben@apple.com>
508
509         Fix case of keypresses from the Windows implementation of eventSender.keyDown
510
511         This fixes several regression tests.
512
513         Reviewed by Alice.
514
515         * DumpRenderTree/win/EventSender.cpp:
516         (keyDownCallback): Virtual keycodes for ASCII characters are always
517         uppercase, so we need to check the case of the original character
518         passed in to eventSender.keyDown.
519
520 2007-12-05  Adam Roben  <aroben@apple.com>
521
522         Learn from Tim's mistakes
523
524         * DumpRenderTree/win/DumpRenderTree.cpp:
525         (runTest): Reset the authorAndUserStylesEnabled preference for each
526         test.
527
528 2007-12-05  Alp Toker  <alp@atoker.com>
529
530         Reviewed by Mark Rowe.
531
532         Initialize GTK+ and WebKit so the tests can run.
533
534         Reorganize the headers a little.
535
536         * DumpRenderTree/gtk/DumpRenderTree.cpp:
537         (main):
538
539 2007-12-04  Anders Carlsson  <andersca@apple.com>
540
541         Remove IWebScriptScope include.
542         
543         * Drosera/win/DebuggerDocumentPlatform.cpp:
544
545 2007-12-04  Sam Weinig  <sam@webkit.org>
546
547         Rubber stamped by Mark Rowe.
548
549         Define CF as platform for mac and revert r28409
550
551         * DumpRenderTree/DumpRenderTree.h:
552         * DumpRenderTree/mac/DumpRenderTreeMac.h:
553
554 2007-12-04  Sam Weinig  <sam@webkit.org>
555
556         Define CF as platform for windows.
557
558         Reviewed by Adam Roben.
559
560         * DumpRenderTree/win/DumpRenderTreeWin.h:
561
562 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
563
564         Reviewed by Adam and Darin.
565
566         - Removed a needless BSTR cleanup.
567
568         * Drosera/win/DebuggerDocumentPlatform.cpp:
569         (DebuggerDocument::getPlatformCurrentFunctionStack):
570
571 2007-11-27  Adam Roben  <aroben@apple.com>
572
573         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
574
575         Reviewed by Maciej.
576
577         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
578         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
579
580 2007-12-04  Alp Toker  <alp@atoker.com>
581
582         Prospective Win DRT build fix.
583
584         * DumpRenderTree/DumpRenderTree.h:
585
586 2007-12-04  Alp Toker  <alp@atoker.com>
587
588         Fix a clobbered copyright header.
589
590         * DumpRenderTree/gtk/DumpRenderTree.cpp:
591
592 2007-12-04  Xan Lopez  <xan@gnome.org>
593
594         Reviewed by Alp Toker.
595
596         http://bugs.webkit.org/show_bug.cgi?id=15561
597         GTK port needs DumpRenderTree implementation
598
599         Start work on the GTK+ DRT.
600
601         This does not work yet, and there are a few lingering style issues
602         (nothing major) but this patch has been stuck in the bug tracker for
603         too long already.
604
605         * DumpRenderTree/DumpRenderTree.h:
606         * DumpRenderTree/gtk: Added.
607         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
608         (autocorrectURL):
609         (shouldLogFrameLoadDelegates):
610         (dumpFrameScrollPosition):
611         (displayWebView):
612         (appendString):
613         (dumpFramesAsText):
614         (dumpRenderTreeAsText):
615         (dump):
616         (runTest):
617         (main):
618         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
619         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
620         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
621         (GCController::collect):
622         (GCController::collectOnAlternateThread):
623         (GCController::getJSObjectCount):
624         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
625         (LayoutTestController::~LayoutTestController):
626         (LayoutTestController::addDisallowedURL):
627         (LayoutTestController::clearBackForwardList):
628         (LayoutTestController::copyDecodedHostName):
629         (LayoutTestController::copyEncodedHostName):
630         (LayoutTestController::display):
631         (LayoutTestController::keepWebHistory):
632         (LayoutTestController::notifyDone):
633         (LayoutTestController::queueBackNavigation):
634         (LayoutTestController::queueForwardNavigation):
635         (LayoutTestController::queueLoad):
636         (LayoutTestController::queueReload):
637         (LayoutTestController::queueScript):
638         (LayoutTestController::setAcceptsEditing):
639         (LayoutTestController::setCustomPolicyDelegate):
640         (LayoutTestController::setMainFrameIsFirstResponder):
641         (LayoutTestController::setTabKeyCyclesThroughElements):
642         (LayoutTestController::setUseDashboardCompatibilityMode):
643         (LayoutTestController::setUserStyleSheetEnabled):
644         (LayoutTestController::setUserStyleSheetLocation):
645         (LayoutTestController::setWindowIsKey):
646         (LayoutTestController::setWaitToDump):
647         (LayoutTestController::windowCount):
648         (LayoutTestController::setPrivateBrowsingEnabled):
649         (LayoutTestController::setAuthorAndUserStylesEnabled):
650         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
651         (JSStringCopyUTF8CString):
652         (LoadItem::invoke):
653         (ReloadItem::invoke):
654         (ScriptItem::invoke):
655         (BackForwardItem::invoke):
656
657 2007-12-03  Sam Weinig  <sam@webkit.org>
658
659         Move JavaScriptCore thread testing code to pthread specific directory
660         and remove the dependance on CoreFoundation by using WTF::HashSet.
661
662         Reviewed by Geoff and Oliver.
663
664         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
665         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
666         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
667         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
668         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
669         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
670         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
671         * DumpRenderTree/pthreads: Added.
672         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
673         (javaScriptThreads):
674         (runJavaScriptThread):
675         (startJavaScriptThreads):
676         (stopJavaScriptThreads):
677
678 2007-12-03  Andrew Bonventre  <andybons@google.com>
679
680         Reviewed by Darin Adler.
681
682         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
683         Symbol lookup menu broken in debugger view
684
685         * Drosera/debugger.js: Fixed javascript error where document property
686         should have been used instead of contentDocument in switchFunction that
687         was breaking the select symbol dropdown menu.  This is because
688         window.frames will return a Window object and not a frame object like
689         the author was originally expecting.
690
691 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
692
693         Reviewed by Adam.
694
695         - <rdar://5618942> Drosera: Console window does not process everything
696         correctly.
697         - <rdar://5619005> Drosera: could be sped up by moving the 
698         WebScriptScope stuff into the WebScriptCallFrame.
699         - Now the console can correctly process objects and does not receive
700         notifications from JavaScriptCore about the JavaScript in Drosera's
701         own process.
702
703         * Drosera/win/DebuggerDocumentPlatform.cpp:
704         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
705         (DebuggerDocument::platformValueForScopeVariableNamed):
706
707 2007-12-03  Stephanie  <slewis@apple.com>
708
709         Reviewed by Darin.
710
711         Check to see if we are building a debug root
712
713         * Scripts/check-for-global-initializers: 
714
715 2007-12-03  Dan Bernstein  <mitz@apple.com>
716
717         Reviewed by Darin Adler.
718
719         - added a testGetIntIdentifier() method to TestNetscapePlugIn
720
721         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
722         (pluginInvoke):
723
724 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
725
726         Reviewed by Oliver.
727
728         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
729         in a more fine-grained manner than eventSender.keyDown().
730
731         * DumpRenderTree/win/EventSender.cpp:
732         (getConstantCallback):
733         (dispatchMessageCallback):
734
735 2007-12-02  Darin Adler  <darin@apple.com>
736
737         * Scripts/do-webcore-rename: More planned renaming.
738
739 2007-12-02  Sam Weinig  <sam@webkit.org>
740
741         Rubber stamped by Anders.
742
743         Use [NSURL absoluteString] instead of [NSURL description] in order to get
744         more uniform results cross platform.
745
746         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
747         (-[NSURL _drt_descriptionSuitableForTestResult]):
748
749 2007-12-02  Sam Weinig  <sam@webkit.org>
750
751         Rubber stamped by Niko.
752
753         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
754
755         * DumpRenderTree/win/DumpRenderTree.cpp:
756         * DumpRenderTree/win/DumpRenderTree.vcproj:
757         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
758         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
759         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
760         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
761
762 2007-12-01  Alp Toker  <alp@atoker.com>
763
764         Reviewed by Adam Roben.
765
766         Make use of the newly introduced webkit.h convenience header.
767
768         * GtkLauncher/main.c:
769
770 2007-12-01  Adam Treat  <treat@kde.org>
771
772         Reviewed by Simon.
773
774         * Check to see if the directory exists and exit if not.
775
776         * DumpRenderTree/qt/main.cpp:
777         (main):
778
779 2007-12-01  Adam Treat  <treat@kde.org>
780
781         Reviewed by Simon.
782
783         * Don't hide symbols when in Debug mode
784         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
785
786
787         * DumpRenderTree/qt/main.cpp:
788         (messageHandler):
789
790 2007-11-30  Alp Toker  <alp@atoker.com>
791
792         Reviewed by Adam Roben.
793
794         http://bugs.webkit.org/show_bug.cgi?id=15691
795         [GTK] Public API does not follow GTK+ conventions
796
797         Refactor the WebKit/GTK+ public API. Changes:
798           WebKitPage -> WebKitWebView
799           WebKitFrame -> WebKitWebFrame
800
801         Public API source and header names have been updated to mirror the API
802         changes.
803
804         The API is now kept in WebKit/gtk/WebView to match other ports in the
805         same class such as Mac and Win.
806
807         * GtkLauncher/main.c:
808         (activate_uri_entry_cb):
809         (link_hover_cb):
810         (title_change_cb):
811         (progress_change_cb):
812         (go_back_cb):
813         (go_forward_cb):
814         (create_browser):
815         (main):
816
817 2007-11-30  Adam Roben  <aroben@apple.com>
818
819         Hopefully the final build fix
820
821         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
822         pull in WTF's assertion/logging functions.
823
824 2007-11-30  Adam Roben  <aroben@apple.com>
825
826         Another build fix
827
828         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
829         WebKit.lib.
830
831 2007-11-30  Adam Roben  <aroben@apple.com>
832
833         Debug build fix
834
835         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
836         configuration.
837         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
838         projects.
839         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
840         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
841         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
842
843 2007-11-30  Sam Weinig  <sam@webkit.org>
844
845         Reviewed by Adam Roben.
846
847         Fix drawSelectionRect to actually draw the selection rect.
848
849         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
850         (drawSelectionRect):
851
852 2007-11-30  Darin Adler  <darin@apple.com>
853
854         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
855
856 2007-11-30  Darin Adler  <darin@apple.com>
857
858         * Scripts/do-webcore-rename: Get ready for some future renaming.
859
860 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
861
862         Reviewed by Adam.
863
864         - Removed some unnecessary functions and changed an unused return type. 
865
866         * Drosera/win/DebuggerClient.cpp:
867         (registerConsoleClass):
868         * Drosera/win/DebuggerClient.h:
869         * Drosera/win/Drosera.cpp:
870         (registerDroseraClass):
871
872 2007-11-28  Alp Toker  <alp@atoker.com>
873
874         Reviewed by Timothy Hatcher.
875
876         http://bugs.webkit.org/show_bug.cgi?id=16174
877         [GTK] Use "URI" not "URL" in public API
878
879         Replace use of the term "URL" with "URI" in public headers,
880         documentation and some internal code to match GLib/GTK+ convention.
881
882         This is now mentioned in the API guidelines:
883           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
884
885         * GtkLauncher/main.c:
886         (activate_uri_entry_cb):
887         (title_change_cb):
888         (create_toolbar):
889         (main):
890
891 2007-11-29  Anders Carlsson  <andersca@apple.com>
892
893         Reviewed by Sam.
894
895         <rdar://problem/5230478>
896         FrameLoadDelegate callbacks are not dumped in DRT.
897         
898         * DumpRenderTree/win/DumpRenderTree.cpp:
899         (shouldLogFrameLoadDelegates):
900         (runTest):
901         (main):
902         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
903         (BSTRtoString):
904         (descriptionSuitableForTestResult):
905         (FrameLoadDelegate::QueryInterface):
906         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
907         (FrameLoadDelegate::didFailProvisionalLoadWithError):
908         (FrameLoadDelegate::didCommitLoadForFrame):
909         (FrameLoadDelegate::didFinishLoadForFrame):
910         (FrameLoadDelegate::willCloseFrame):
911         (FrameLoadDelegate::didClearWindowObject):
912         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
913         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
914         * DumpRenderTree/win/FrameLoaderDelegate.h:
915         (FrameLoadDelegate::windowScriptObjectAvailable):
916         (FrameLoadDelegate::didFirstLayoutInFrame):
917
918 2007-11-29  Sam Weinig  <sam@webkit.org>
919
920         Reviewed by Anders.
921
922         Add database quota UIDelegates methods to DRT UIDelegate.
923
924         * DumpRenderTree/mac/UIDelegate.mm:
925         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
926         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
927
928 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
929
930         Reviewed by Sam.
931
932         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
933         dying and vice versa.
934         - This fix will allow Drosera and Safari to reconnect if either of them
935         closes correctly, but does not fix the case where one of them dies
936         silently.
937
938         * Drosera/win/ServerConnection.cpp:
939         (ServerConnection::attemptToCreateServerConnection): Added a safety
940         check, because it's possilbe to try to connect to a server that's dying.
941         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
942         the server has died.
943         * Drosera/win/ServerConnection.h: Added the new function and removed
944         an unnecessary member.
945
946 2007-11-29  Anders Carlsson  <andersca@apple.com>
947
948         * DumpRenderTree/win/DumpRenderTree.vcproj:
949         Add shlwapi.lib to all configurations.
950
951 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
952
953         - Build fix.  Added additional includes for VS Express to the Release
954         project.
955
956         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
957
958 2007-11-29  Anders Carlsson  <andersca@apple.com>
959
960         Reviewed by Adam.
961
962         <rdar://problem/5132005>
963         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
964         
965         * DumpRenderTree/win/DumpRenderTree.vcproj:
966         Add shlwapi.lib
967         
968         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
969         (LayoutTestController::setUserStyleSheetEnabled):
970         Implement this.
971         
972         (appendComponentToPath):
973         New method which wraps the Win32 API PathAppend.
974         
975         (followShortcuts):
976         New method which checks if a file points to a shortcut and
977         follows the shortcut.
978         
979         (resolveCygwinPath):
980         New method that takes a cygwin unix-style path and returns the Win32 path.
981         
982         (cfStringRefToWString):
983         
984         (LayoutTestController::setUserStyleSheetLocation):
985         Implement this.
986
987 2007-11-29  Alice Liu  <alice.liu@apple.com>
988
989         Reviewed by Adam.
990
991         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
992
993         * DumpRenderTree/win/EventSender.cpp:
994         (keyDownCallback):
995         uppercase letters were being sent as lowercase letters without the shift key down.
996
997 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
998
999         - Windows build fix. VS express needs some love.
1000
1001         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1002
1003 2007-11-28  Darin Adler  <darin@apple.com>
1004
1005         Reviewed by Adam Roben.
1006
1007         * DumpRenderTree/mac/EventSendingController.mm:
1008         (-[EventSendingController keyDown:withModifiers:]):
1009         Send capital letters through as lowercase letters with the shift key down
1010         rather than sending them as if they were highly unusual "capital letter keys".
1011
1012         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
1013         where you need to update results and more tests are failing than before.
1014
1015 2007-11-28  Anders Carlsson  <andersca@apple.com>
1016
1017         Reviewed by Darin.
1018
1019         <rdar://problem/5132001>
1020         contextClick is not implemented in DRT on Windows.
1021         
1022         * DumpRenderTree/win/EventSender.cpp:
1023         (contextClickCallback):
1024         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
1025         by a WM_RBUTTONUP message.
1026         
1027         * DumpRenderTree/win/UIDelegate.cpp:
1028         (UIDelegate::hasCustomMenuImplementation):
1029         (UIDelegate::trackCustomPopupMenu):
1030         * DumpRenderTree/win/UIDelegate.h:
1031         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
1032         menu from being shown (and causing the DRT to hang).
1033
1034 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
1035
1036         Reviewed by Darin.
1037
1038         Fix DumpRenderTree ObjC bug comparing strings.
1039
1040         * DumpRenderTree/mac/ObjCController.m:
1041         (-[ObjCController identityIsEqual::]): Compare strings with string
1042         equality instead of identiy equality.
1043
1044 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1045
1046         Reviewed by Sam.
1047
1048         Reset the authorAndUserStylesEnabled preference
1049         back to YES for each test. Fixes the broken tests.
1050
1051         * DumpRenderTree/mac/DumpRenderTree.mm:
1052         (resetWebViewToConsistentStateBeforeTesting):
1053
1054 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
1055
1056         Reviewed by Adam.
1057
1058         - Drosera now displays the console window, although it cannot currently
1059         process JavaScript.
1060
1061         * Drosera/win/DebuggerClient.cpp: Shows the console window.
1062         (registerConsoleClass): Implemented.
1063         (consoleWndProc): Implemented.
1064         (DebuggerClient::onSize): Implemented.
1065         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
1066         new window.
1067         * Drosera/win/DebuggerClient.h: Added needed method and members for 
1068         creating and maintaining a new window.
1069         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
1070         lines of code to more appropriate places.
1071         (Drosera::handleCommand):
1072         (Drosera::initUI):
1073         (Drosera::onSize):
1074         (Drosera::attach):
1075
1076 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1077
1078         Reviewed by Dave Hyatt.
1079
1080         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
1081         
1082         Add support for disabling author and user styles for testing.
1083
1084         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1085         * DumpRenderTree/LayoutTestController.cpp:
1086         (setAuthorAndUserStylesEnabledCallback):
1087         (LayoutTestController::staticFunctions):
1088         * DumpRenderTree/LayoutTestController.h:
1089         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1090         (LayoutTestController::setAuthorAndUserStylesEnabled):
1091         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1092         (LayoutTestController::setAuthorAndUserStylesEnabled):
1093
1094 2007-11-26  Dan Bernstein  <mitz@apple.com>
1095
1096         - Tiger build fix.
1097
1098         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1099
1100 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
1101
1102         Reviewed by Maciej.
1103
1104         - Implemented displaying variables for Drosera on Win.
1105
1106         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
1107         that retrieve variables to not hold onto the return value since it's
1108         not returned.  Also changed to use the new signatures of the retrieval
1109         functions.
1110         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1111         (DebuggerDocument::platformValueForScopeVariableNamed):
1112         * Drosera/win/Drosera.cpp: Removed a needless TODO.
1113         (droseraWndProc):
1114
1115 2007-11-26  Sam Weinig  <sam@webkit.org>
1116
1117         Cleanup names of painting and repainting functions.
1118
1119         Reviewed by Adam Roben.
1120
1121         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1122         (drawSelectionRect): was drawSelectionRectIntoContext.
1123         (dumpWebViewAsPixelsAndCompareWithExpected):
1124         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1125         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1126         (paintWebView): was drawWebViewIntoContext.
1127         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
1128
1129 2007-11-26  Sam Weinig  <sam@webkit.org>
1130
1131         Reviewed by Dan Bernstein.
1132
1133         - Leopard build fix
1134
1135         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1136
1137 2007-11-26  Sam Weinig  <sam@webkit.org>
1138
1139         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
1140         Use shared PixelDumpSupport for Mac DRT
1141
1142         Reviewed by Adam Roben.
1143
1144         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1145         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
1146         * DumpRenderTree/cg/ImageDiffCG.cpp:
1147         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1148         (drawSelectionRectIntoContext):
1149         (dumpWebViewAsPixelsAndCompareWithExpected):
1150         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1151         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1152         * DumpRenderTree/mac/DumpRenderTree.mm:
1153         (dump):
1154         * DumpRenderTree/mac/ImageDiff.m: Removed.
1155         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
1156         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
1157         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
1158         (setDefaultColorProfileToRGB):
1159         (getBitmapContextFromWebView):
1160         (drawWebViewIntoContext):
1161         (repaintWithVerticalSweep):
1162         (repaintWithHorizontalSweep):
1163         (getSelectionRect):
1164         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
1165
1166 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
1167
1168         Bug 16052: prepare-ChangeLog doesn't report deleted files
1169         <http://bugs.webkit.org/show_bug.cgi?id=16052>
1170
1171         Reviewed by Sam.
1172
1173         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
1174
1175 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
1176
1177         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
1178         <http://bugs.webkit.org/show_bug.cgi?id=15864>
1179
1180         Reviewed by Adam.
1181
1182         Roll functionality of merge-changelog into resolve-ChangeLogs
1183         script.  The script now checks for ChangeLog.rej and
1184         ChangeLog.orig files first.  If it finds them, it uses the
1185         ChangeLog.rej file as a patch (in old contextual diff format) to
1186         apply with --fuzz=3.
1187
1188         * Scripts/merge-changelog: Removed.
1189         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
1190
1191 2007-11-25  Sam Weinig  <sam@webkit.org>
1192
1193         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
1194
1195         Reviewed by Mark Rowe.
1196
1197         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1198         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1199         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1200         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
1201         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
1202
1203 2007-11-25  Sam Weinig  <sam@webkit.org>
1204
1205         Convert DumpRenderTree to ues .xcconfig files.
1206
1207         Reviewed by Mark Rowe.
1208
1209         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1210         * DumpRenderTree/mac/Configurations: Added.
1211         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
1212         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
1213         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
1214
1215 2007-11-25  Sam Weinig  <sam@webkit.org>
1216
1217         Add ForwardingHeaders to wtf for DumpRenderTree.
1218
1219         Reviewed by Mark Rowe.
1220
1221         * DumpRenderTree/DumpRenderTree.h:
1222         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1223         * DumpRenderTree/ForwardingHeaders: Added.
1224         * DumpRenderTree/ForwardingHeaders/wtf: Added.
1225         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
1226         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
1227         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
1228         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
1229         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
1230         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
1231         * DumpRenderTree/LayoutTestController.cpp:
1232         * DumpRenderTree/WorkQueue.cpp:
1233         * DumpRenderTree/mac/DumpRenderTree.mm:
1234         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1235         * DumpRenderTree/mac/JavaScriptThreading.cpp:
1236         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1237         * DumpRenderTree/mac/ObjCController.m:
1238         * DumpRenderTree/mac/UIDelegate.mm:
1239         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1240
1241 2007-11-25  Adam Roben  <aroben@apple.com>
1242
1243         Fix some test failures caused by r28019
1244
1245         Now that stdout is in binary mode, we need to always use printf
1246         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
1247         the output.
1248
1249         Reviewed by Sam.
1250
1251         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
1252         printf.
1253         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1254         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1255         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1256         (UIDelegate::webViewAddMessageToConsole):
1257
1258 2007-11-25  Adam Roben  <aroben@apple.com>
1259
1260         Set the font smoothing preference in DRT
1261
1262         This makes the pixel results on Windows closer to the Mac results.
1263
1264         Reviewed by Mitz.
1265
1266         * DumpRenderTree/win/DumpRenderTree.cpp:
1267         (initializePreferences):
1268
1269 2007-11-25  Adam Roben  <aroben@apple.com>
1270
1271         Port ImageDiff to CG and C++
1272
1273         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
1274         <rdar://5071708>
1275
1276         Reviewed by Sam.
1277
1278         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
1279         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
1280         (main):
1281         (createImageFromStdin):
1282         (compareImages):
1283         (getDifferenceBitmap):
1284         (computePercentageDifferent):
1285         * DumpRenderTree/win/ImageDiff.vcproj: Added.
1286
1287 2007-11-25  Adam Roben  <aroben@apple.com>
1288
1289         Fix image diff link generation on Windows
1290
1291         Reviewed by Sam.
1292
1293         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
1294         to toURL.
1295
1296 2007-11-25  Adam Roben  <aroben@apple.com>
1297
1298         Implement pixel dumping in Windows DRT
1299
1300         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
1301         <rdar://5071708>
1302
1303         Reviewed by Sam.
1304
1305         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
1306         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
1307         Content-Length header.
1308         (getMD5HashStringForBitmap):
1309         (dumpWebViewAsPixelsAndCompareWithExpected):
1310         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
1311         * DumpRenderTree/win/DumpRenderTree.cpp:
1312         (dump): Do a pixel dump if requested.
1313         (main): Parse pixel test options.
1314         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
1315         the cg/ subdirectory to the include path.
1316         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
1317         available in a header or import library, so we have to go through this
1318         LoadLibrary/GetProcAddress dance to use them.
1319         (cryptDLL):
1320         (init):
1321         (update):
1322         (final):
1323         (MD5_Init):
1324         (MD5_Update):
1325         (MD5_Final):
1326         * DumpRenderTree/win/MD5.h: Added.
1327         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
1328         moved up to the top level to share it with Mac eventually.
1329         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
1330         (getBitmapContextFromWebView): Forces the WebView to paint using a
1331         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
1332
1333 2007-11-25  Adam Roben  <aroben@apple.com>
1334
1335         Clean up Windows DRT's option parsing a little bit
1336
1337         Reviewed by Sam.
1338
1339         * DumpRenderTree/win/DumpRenderTree.cpp:
1340         (main): Put non-option arguments into a Vector.
1341
1342 2007-11-25  Adam Roben  <aroben@apple.com>
1343
1344         Make Windows DRT stop changing LF into CRLF
1345
1346         Reviewed by Sam.
1347
1348         * DumpRenderTree/win/DumpRenderTree.cpp:
1349         (main): Put stdout in binary mode.
1350         * Scripts/run-webkit-tests: Remove the CRLF hack.
1351
1352 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
1353
1354         Removed empty directory.
1355
1356         * Scripts/resources: Removed.
1357
1358 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
1359
1360         Fix bisect-builds to work with recent WebKit nightly builds.
1361
1362         Reviewed by Dan.
1363
1364         * Scripts/bisect-builds: Check for the 
1365         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
1366         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
1367         to WebKit.app/Contents/Resources.
1368
1369 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
1370
1371         Reviewed by Maciej.
1372
1373         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
1374         not closed (affects digg.com)
1375
1376         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
1377         one after finishing with a test to avoid having its delayed onload handler firing when
1378         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
1379         but it helps somewhat.
1380
1381 2007-11-22  Mark Rowe  <mrowe@apple.com>
1382
1383         Reviewed by Alp Toker.
1384
1385         Fix build-webkit to propagate make's exit status if it fails.
1386
1387         * Scripts/webkitdirs.pm:
1388
1389 2007-11-22  Dan Bernstein  <mitz@apple.com>
1390
1391         Reviewed by Mark Rowe.
1392
1393         - fix crash when running pixel tests
1394
1395         * DumpRenderTree/mac/DumpRenderTree.mm:
1396         (dumpRenderTree): Parse the command line options before setting up the
1397         environment so that we know if we need to set up the pixel dump
1398         machinery.
1399
1400 2007-11-21  Eric Seidel  <eric@webkit.org>
1401
1402         Speculative build fix for Tiger.
1403
1404         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
1405
1406 2007-11-21  Eric Seidel  <eric@webkit.org>
1407
1408         Reviewed by Tim Hatcher.
1409
1410         Break out more of DumpRenderTree.mm into individual files
1411
1412         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1413         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
1414         (checkedMalloc):
1415         (checkedRealloc):
1416         (makeLargeMallocFailSilently):
1417         * DumpRenderTree/mac/CheckedMalloc.h: Added.
1418         * DumpRenderTree/mac/DumpRenderTree.mm:
1419         (crashHandler):
1420         (dump):
1421         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1422         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
1423         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1424         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1425         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1426         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
1427         (javaScriptThreads):
1428         (runJavaScriptThread):
1429         (startJavaScriptThreads):
1430         (stopJavaScriptThreads):
1431         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
1432         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
1433         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
1434         (restoreColorSpace):
1435         (setDefaultColorProfileToRGB):
1436         (initializeColorSpaceAndScreeBufferForPixelTests):
1437         (md5HashStringForBitmap):
1438         (dumpWebViewAsPixelsAndCompareWithExpected):
1439
1440 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
1441
1442         Move install-unix-extras to wx directory as it seems only to be used by that 
1443         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
1444         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
1445         have install-unix-extras install into WebKitLibraries as per
1446         convention.
1447         
1448         Reviewed by Mark Rowe.
1449
1450         * Scripts/install-unix-extras: Removed.
1451         * wx/build-wxwebkit:
1452         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
1453
1454 2007-11-21  Eric Seidel  <eric@webkit.org>
1455
1456         Reviewed by Adam.
1457
1458         More refactoring for greater code readability
1459
1460         * DumpRenderTree/mac/DumpRenderTree.mm:
1461         (initializeGlobalsFromCommandLineOptions):
1462         (initializeColorSpaceAndScreeBufferForPixelTests):
1463         (addTestPluginsToPluginSearchPath):
1464         (useLongRunningServerMode):
1465         (runTestingServerLoop):
1466         (prepareConsistentTestingEnvironment):
1467         (dumpRenderTree):
1468         (main):
1469         (dumpFramesAsText):
1470         (dumpBackForwardListForWebView):
1471         (sizeWebViewForCurrentTest):
1472         (methodNameStringForFailedTest):
1473         (dumpBackForwardListForAllWindows):
1474         (dumpWebViewAsPixelsAndCompareWithExpected):
1475         (invalidateAnyPreviousWaitToDumpWatchdog):
1476         (dump):
1477         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1478         * DumpRenderTree/mac/UIDelegate.mm:
1479         (-[UIDelegate webView:createWebViewWithRequest:]):
1480
1481 2007-11-21  Eric Seidel  <eric@webkit.org>
1482
1483         Reviewed by Tim Hatcher.
1484
1485         Abstract more of DRT into static methods
1486
1487         * DumpRenderTree/mac/DumpRenderTree.mm:
1488         (setDefaultsToConsistentValuesForTesting):
1489         (setupSignalHandlers):
1490         (allocateGlobalControllers):
1491         (releaseAndZero):
1492         (releaseGlobalControllers):
1493         (dumpRenderTree):
1494         (shouldLogFrameLoadDelegates):
1495         (createCFURLFromPathOrURL):
1496         (resetWebViewToConsistentStateBeforeTesting):
1497         (runTest):
1498
1499 2007-11-21  Eric Seidel  <eric@webkit.org>
1500
1501         Reviewed by Tim Hatcher.
1502
1503         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
1504
1505         * DumpRenderTree/DumpRenderTree.h:
1506         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1507         * DumpRenderTree/mac/DumpRenderTree.mm:
1508         (dumpRenderTree):
1509         (dump):
1510         (runTest):
1511         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
1512         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
1513         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
1514         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
1515         (-[DumpRenderTreePasteboard declareType:owner:]):
1516         (+[LocalPasteboard alloc]):
1517         (-[LocalPasteboard init]):
1518         (-[LocalPasteboard dealloc]):
1519         (-[LocalPasteboard name]):
1520         (-[LocalPasteboard releaseGlobally]):
1521         (-[LocalPasteboard declareTypes:owner:]):
1522         (-[LocalPasteboard addTypes:owner:]):
1523         (-[LocalPasteboard changeCount]):
1524         (-[LocalPasteboard types]):
1525         (-[LocalPasteboard availableTypeFromArray:]):
1526         (-[LocalPasteboard setData:forType:]):
1527         (-[LocalPasteboard dataForType:]):
1528         (-[LocalPasteboard setPropertyList:forType:]):
1529         (-[LocalPasteboard setString:forType:]):
1530         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
1531         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
1532         (+[DumpRenderTreeWindow allWindows]):
1533         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1534         (-[DumpRenderTreeWindow dealloc]):
1535         (-[DumpRenderTreeWindow isKeyWindow]):
1536         (-[DumpRenderTreeWindow keyDown:]):
1537
1538 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
1539
1540         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
1541         it indiscriminately copies any headers inside JavaScriptCore,
1542         which includes Tiger ICU headers. 
1543
1544         * wx/build-wxwebkit:
1545         Don't run WebCore/move-js-headers.sh any longer.
1546
1547 2007-11-20  Adam Treat  <treat@kde.org>
1548
1549         Reviewed by David Kilzer.
1550
1551         * Prepend git branch name to $baseProductDir
1552
1553         * Scripts/VCSUtils.pm:
1554         * Scripts/webkitdirs.pm:
1555
1556 2007-11-20  Mark Rowe  <mrowe@apple.com>
1557
1558         Reviewed by Simon Hausmann.
1559
1560         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
1561         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
1562         Have it trigger a "make distclean" rather than "make clean" to ensure that the
1563         built product and generated Makefile's are removed.
1564
1565 2007-11-19  Alp Toker  <alp@atoker.com>
1566
1567         Reviewed by Mark Rowe.
1568
1569         http://bugs.webkit.org/show_bug.cgi?id=16040
1570         [GTK] GtkLauncher should be written in C
1571
1572         Port GtkLauncher to plain C.
1573
1574         Use a more conventional GTK+ coding style.
1575
1576         Use a toolbar instead of menus.
1577
1578         Various signature fixes and cleanups.
1579
1580         Add a license header. Assume all previous modifications were copyright
1581         assigned to Apple Inc. by default.
1582
1583         * GtkLauncher/GtkLauncher.pro:
1584         * GtkLauncher/main.c: Added.
1585         (activate_url_entry_cb):
1586         (update_title):
1587         (link_hover_cb):
1588         (title_change_cb):
1589         (progress_change_cb):
1590         (destroy_cb):
1591         (go_back_cb):
1592         (go_forward_cb):
1593         (create_browser):
1594         (create_statusbar):
1595         (create_toolbar):
1596         (create_window):
1597         (main):
1598         * GtkLauncher/main.cpp: Removed.
1599
1600 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
1601
1602         Build script fixes to ensure they do the right thing for the 
1603         wx port, and update build-wxwebkit to reflect the way the
1604         build scripts now work.
1605
1606         Reviewed by Adam.
1607
1608         * Scripts/build-testkjs:
1609         * Scripts/build-webkit:
1610         * Scripts/run-javascriptcore-tests:
1611         * Scripts/webkitdirs.pm:
1612         * wx/build-wxwebkit:
1613
1614 2007-11-18  Eric Seidel  <eric@webkit.org>
1615
1616         Reviewed by Anders.
1617
1618         Make run-javascriptcore-tests report failures on exit (to support git bisect)
1619
1620         * Scripts/run-javascriptcore-tests:
1621
1622 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
1623
1624         Reviewed by Adam Roben.
1625
1626         Make run-webkit-tests work with Windows debug build.
1627
1628         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
1629         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
1630         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
1631         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
1632         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
1633
1634 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
1635
1636         Add wxWebKit sample and build script, and integrate it with 
1637         build-webkit. Also make build-webkit --clean work for all
1638         ports.
1639
1640         Reviewed by Darin Adler.
1641
1642         * Scripts/build-webkit:
1643         * Scripts/webkitdirs.pm:
1644         * wx: Added.
1645         * wx/browser: Added.
1646         * wx/browser/browser.bkl: Added.
1647         * wx/browser/browser.cpp: Added.
1648         * wx/build-wxwebkit: Added.
1649
1650 2007-11-17  Adam Roben  <aroben@apple.com>
1651
1652         Make it easy to run Safari in the debugger on Windows
1653
1654         I've added a new script, debug-safari, which launches Safari in the
1655         debugger. On OS X it just calls gdb-safari.
1656
1657         Reviewed by Mark Rowe.
1658
1659         * FindSafari/FindSafari.cpp:
1660         (_tmain): Added a /debugger flag, which in combination with
1661         /printSafariLauncher will print a script that launches Safari in the
1662         debugger.
1663         * Scripts/debug-safari: Added.
1664         * Scripts/run-safari: Changed to call runSafari().
1665         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
1666         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
1667         first argument along to FindSafari.
1668         * Scripts/webkitdirs.pm:
1669         (sub runSafari): Added.
1670
1671 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
1672
1673         Reviewed by Adam Roben.
1674
1675         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
1676
1677 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
1678
1679         Reviewed by David Kilzer.
1680
1681         The git config command was renamed to repo-config at some point. This
1682         change tries git config and then git repo-config if the first fails.
1683
1684         * Scripts/prepare-ChangeLog:
1685         (gitConfig):
1686
1687 2007-11-16  Dan Bernstein  <mitz@apple.com>
1688
1689         Reviewed by Darin Adler and Sam Weinig.
1690
1691         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
1692
1693         * DumpRenderTree/win/EventSender.cpp:
1694         (keyDownCallback): For characters that cannot be entered on the active
1695         keyboard layout, send a WM_CHAR message with the character along with
1696         a WM_KEYDOWN message with a virtual key code of 255.
1697
1698 2007-11-16  Mark Rowe  <mrowe@apple.com>
1699
1700         Reviewed by Tim Hatcher.
1701
1702         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
1703
1704         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1705         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1706
1707 2007-11-15  Adam Roben  <aroben@apple.com>
1708
1709         Make run-safari actually work on Windows
1710
1711         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
1712         chdir call.
1713
1714 2007-11-14  Adam Roben  <aroben@apple.com>
1715
1716         Updates to Safari launching now that 3.0.4 is released
1717
1718         Reviewed by Sam.
1719
1720         * FindSafari/FindSafari.cpp:
1721         (getWebViewCLSID): Use version-independent ProgID.
1722         * Scripts/run-safari: Use run-webkit-nightly.cmd.
1723
1724 2007-11-14  Anders Carlsson  <andersca@apple.com>
1725
1726         Reviewed by Adam.
1727
1728         <rdar://problem/5309081>
1729         In DRT, "plugin.logDestroy = true" not working on Windows.
1730         
1731         * DumpRenderTree/win/TestNetscapePlugin/main.c:
1732         (NPP_Destroy):
1733
1734 2007-11-14  Eric Seidel  <eric@webkit.org>
1735
1736         Reviewed by Sam.
1737
1738         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
1739
1740 2007-11-14  Anders Carlsson  <andersca@apple.com>
1741
1742         Reviewed by Adam.
1743
1744         <rdar://problem/5141186>
1745         window.layoutTestController.setWindowIsKey is not implemented in DRT.
1746         
1747         Implement setWindowIsKey.
1748         
1749         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1750         (LayoutTestController::setWindowIsKey):
1751
1752 2007-11-13  Sam Weinig  <sam@webkit.org>
1753
1754         Reviewed by Adam Roben.
1755
1756         Fix for <rdar://problem/5382579>
1757         http/tests/security/cross-frame-access-put.html reports large 
1758         negative numbers for screenLeft and screenTop (Mac reports "0")
1759
1760         * DumpRenderTree/win/UIDelegate.cpp:
1761         (UIDelegate::UIDelegate): Initialize the RECT.
1762         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
1763         (UIDelegate::webViewFrame): ditto.
1764         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
1765
1766 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
1767
1768         Reviewed by Adam.
1769
1770         - Make Drosera show source, source URLs, and function stack on Windows,
1771         and some minor fixes.
1772
1773         * Drosera/DebuggerDocument.cpp: Force source to always update display.
1774         (DebuggerDocument::updateFileSource):
1775         * Drosera/debugger.js: Force source to always update display.
1776         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
1777         menu controls.
1778         (DebuggerClient::resume):
1779         (DebuggerClient::pause):
1780         (DebuggerClient::stepInto):
1781         (DebuggerClient::stepOver):
1782         (DebuggerClient::stepOut):
1783         (DebuggerClient::showConsole):
1784         (DebuggerClient::closeCurrentFile):
1785         * Drosera/win/DebuggerClient.h: Ditto.
1786         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
1787         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
1788         removed two bugs.  1) caller could be in a bad state when asked to
1789         assign into it. 2) BSTRs were not created correctly.
1790         (DebuggerDocument::getPlatformCurrentFunctionStack):
1791         * Drosera/win/Drosera.cpp: Hook up the menu controls.
1792         (droseraWndProc):
1793         (handleCommand):
1794         (Drosera::resume):
1795         (Drosera::pause):
1796         (Drosera::stepInto):
1797         (Drosera::stepOver):
1798         (Drosera::stepOut):
1799         (Drosera::showConsole):
1800         (Drosera::closeCurrentFile):
1801         * Drosera/win/Drosera.h: Hook up the menu controls.
1802         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
1803         functions, added a null check, and fixed another bug where caller could
1804         be in a bad state when asked to assign into it.
1805         (ServerConnection::didLoadMainResourceForDataSource):
1806         (ServerConnection::getCallerFrame):
1807         * Drosera/win/ServerConnection.h: Safety first.
1808
1809 2007-11-13  Dan Bernstein  <mitz@apple.com>
1810
1811         Reviewed by Darin Adler.
1812
1813         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
1814           DumpRenderTree --pixel-tests renders each test twice
1815
1816         * DumpRenderTree/mac/DumpRenderTree.mm:
1817         (dumpRenderTree): Removed the --paint option because the painting code
1818         is always exercised as a result of
1819         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
1820         calling -displayIfNeeded.
1821         (dump): Changed to always grab the image from the window since the view
1822         is always displayed.
1823         (runTest):
1824         (displayWebView):
1825         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
1826         because it always paints.
1827
1828 2007-11-12  Antti Koivisto  <antti@apple.com>
1829
1830         Reviewed by Adele.
1831         
1832         Add support for http media tests
1833
1834         * Scripts/run-webkit-tests:
1835
1836 2007-11-12  Sam Weinig  <sam@webkit.org>
1837
1838         Reviewed by Adam Roben.
1839
1840         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
1841
1842         * DumpRenderTree/win/DumpRenderTree.cpp:
1843         (runTest):
1844         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1845         (LayoutTestController::setPrivateBrowsingEnabled):
1846
1847 2007-11-12  Adam Roben  <aroben@apple.com>
1848
1849         * Scripts/update-webkit-localizable-strings: Changed to only scan the
1850         mac and win subdirectories.
1851
1852 2007-11-11  Adam Roben  <aroben@apple.com>
1853
1854         Fix <rdar://5133816> keepWebHistory is not implemented
1855
1856         Fixes fast/history/clicked-link-is-visited.html.
1857
1858         Reviewed by Darin.
1859
1860         * DumpRenderTree/win/DumpRenderTree.cpp:
1861         (runTest): Clear the optionalSharedHistory.
1862         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1863         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
1864
1865 2007-11-10  Sam Weinig  <sam@webkit.org>
1866
1867         Reviewed by Tim Hatcher.
1868
1869         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
1870         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
1871         is turned on)
1872
1873         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
1874
1875         Added test: http/tests/security/cross-frame-access-private-browsing.html
1876
1877         * DumpRenderTree/LayoutTestController.cpp:
1878         (setPrivateBrowsingEnabledCallback):
1879         (LayoutTestController::staticFunctions):
1880         * DumpRenderTree/LayoutTestController.h:
1881         * DumpRenderTree/mac/DumpRenderTree.mm:
1882         (runTest): Default to private browsing disabled.
1883         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1884         (LayoutTestController::setPrivateBrowsingEnabled):
1885         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1886         (LayoutTestController::setPrivateBrowsingEnabled):
1887
1888 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1889
1890         Reviewed by Adam.
1891
1892         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
1893         WebCore's!
1894
1895         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
1896         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
1897         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
1898         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
1899         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
1900         * Drosera/win/Drosera.cpp:
1901         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1902
1903 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1904
1905         Reviewed by Sam.
1906
1907         - Use the new IWebFrame [local] function signature and get the shared
1908         server correctly.
1909
1910         * Drosera/win/DebuggerClient.cpp:
1911         (DebuggerClient::didFinishLoadForFrame):
1912         * Drosera/win/ServerConnection.cpp:
1913         (ServerConnection::attemptToCreateServerConnection):
1914
1915 2007-11-07  Dan Bernstein  <mitz@apple.com>
1916
1917         Reviewed by Darin Adler.
1918
1919         - add an option to run-webkit-tests to ignore pixel test failures where
1920           all pixels differ by no more than a specified threshold
1921
1922         * DumpRenderTree/mac/ImageDiff.m:
1923         (main):
1924         (compareImages):
1925         (computePercentageDifferent):
1926         * Scripts/run-webkit-tests:
1927
1928 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1929
1930         Reviewed by Lars.
1931
1932         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
1933
1934         * DumpRenderTree/qt/DumpRenderTree.cpp:
1935
1936 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1937
1938         Reviewed by Lars.
1939
1940         Reworked the QWebSettings API.
1941         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
1942
1943         * DumpRenderTree/qt/DumpRenderTree.cpp:
1944
1945 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1946
1947         Reviewed by Lars.
1948
1949         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
1950
1951         * DumpRenderTree/qt/jsobjects.cpp:
1952
1953 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1954
1955         Reviewed by Lars Knoll <lars@trolltech.com>.
1956
1957         Add a QWebPage::frameCreated() signal and fix DRT
1958         
1959         The removal of createFrame in QWebPage broke the re-implementation
1960         in DumpRenderTree. Instead emit a frameCreated() signal and
1961         connect to it in DumpRenderTree.
1962         
1963
1964         * DumpRenderTree/qt/DumpRenderTree.cpp:
1965         (WebCore::WebPage::WebPage):
1966         (WebCore::DumpRenderTree::dump):
1967         (WebCore::DumpRenderTree::connectFrame):
1968         * DumpRenderTree/qt/DumpRenderTree.h:
1969
1970 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1971
1972         Reviewed by Lars Knoll <lars@trolltech.com>.
1973
1974         Moved all the event handlers from QWebFrame into QWebPage.
1975         
1976         This cleans up the public API and allows us to remove the
1977         HackWebFrame hack in DumpRenderTree.
1978         
1979
1980         * DumpRenderTree/qt/jsobjects.cpp:
1981         (EventSender::mouseDown):
1982         (EventSender::mouseUp):
1983         (EventSender::mouseMoveTo):
1984
1985 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1986
1987         Reviewed by Mark.
1988
1989         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
1990         to prevent the default implementation from popping up messageboxes.
1991
1992         * DumpRenderTree/qt/DumpRenderTree.cpp:
1993         (WebCore::WebPage::javaScriptConfirm):
1994         (WebCore::WebPage::javaScriptPrompt):
1995
1996 2007-11-06  Eric Seidel  <eric@webkit.org>
1997
1998         * Scripts/build-testkjs: build fix... too many $$
1999
2000 2007-11-06  Eric Seidel  <eric@webkit.org>
2001
2002         Reviewed by Mark Rowe.
2003
2004         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
2005
2006 2007-11-05  Adam Roben  <aroben@apple.com>
2007
2008         Add support on Windows for WEBKIT_TESTFONTS
2009
2010         This environment variable lets you specify where the fonts to be used
2011         by DumpRenderTree reside. The Qt port is already using this, so I'm
2012         just following their lead.
2013
2014         Reviewed by Darin.
2015
2016         * DumpRenderTree/win/DumpRenderTree.cpp:
2017         (exePath): Refactored code out of initialize().
2018         (fontsPath): Returns either $WEBKIT_TESTFONTS or
2019         DumpRenderTree.resources.
2020         (initialize): Use the new fontsPath function.
2021         (main): Use the new exePath function.
2022         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
2023         variable to DRT, like Qt does.
2024
2025 2007-11-05  Mark Rowe  <mrowe@apple.com>
2026
2027         Rubber-stamped by Alp Toker.
2028
2029         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
2030
2031         * GtkLauncher/main.cpp:
2032         (goToURLBarText):
2033         (main):
2034
2035 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
2036
2037         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
2038         <http://bugs.webkit.org/show_bug.cgi?id=15830>
2039
2040         Reviewed by Timothy.
2041
2042         Restrict the range of nightly builds used by the bisect-builds script
2043         based on the version of Safari and the version of Mac OS X being used.
2044
2045         Mac OS X 10.4: Safari 2.0: r11976 or newer
2046         Mac OS X 10.4: Safari 3.0: r19992 or newer
2047
2048         Mac OS X 10.5: Safari 2.0: r19594 or newer
2049         Mac OS X 10.5: Safari 3.0: r25124 or newer
2050
2051         * Scripts/bisect-builds:
2052         (findMacOSXVersion): Added.
2053         (makeNightlyList): Added argument to provide version of Mac OS X.
2054         Restrict range of nightly builds based on Safari and Mac OS X versions.
2055
2056 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
2057
2058         Reviewed by Maciej.
2059
2060         - This patch involves several changes, all of them were noticed that
2061         they were needed by the work being done in WebKit to get Drosera and
2062         WebKit working together on Windows.
2063         - The changes are:
2064         1) Added a debugger console for output messages.
2065         2) Drosera now listens for the WebKit server (before, the server would
2066         have to be running before Drosera was started.)
2067         3) Fixed a bug where the WebView started out as 0x0 pixels.
2068         4) Fixed a bug when there is no scope.
2069         5) Added the HTML, JS, and CSS to the project file to make them easy to
2070         find.
2071         6) Made the ServerConnection functions virtual.
2072
2073         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
2074         for the WebKit server.
2075         (DebuggerClient::DebuggerClient):
2076         (DebuggerClient::~DebuggerClient):
2077         (DebuggerClient::didFinishLoadForFrame):
2078         (DebuggerClient::serverConnected):
2079         (DebuggerClient::attemptToCreateServerConnection):
2080         * Drosera/win/DebuggerClient.h: Ditto.
2081         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
2082         scope.
2083         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2084         (DebuggerDocument::platformValueForScopeVariableNamed):
2085         * Drosera/win/Drosera.cpp:
2086         (_tWinMain): Added a console in debug for output messages.
2087         (Drosera::Drosera): Listen for server.
2088         (Drosera::initUI): The server now Initializes COM.
2089         (Drosera::serverConnected): Part of the listening for the server.
2090         (Drosera::attemptToCreateServerConnection): Ditto.
2091         * Drosera/win/Drosera.h: New interface for listening for the server.
2092         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
2093         files to the VS project.
2094         * Drosera/win/ServerConnection.cpp: Part of listening for the server
2095         connection.
2096         (ServerConnection::ServerConnection):
2097         (ServerConnection::attemptToCreateServerConnection):
2098         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
2099         methods.
2100         (ServerConnection::serverConnected):
2101
2102 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
2103
2104         Reviewed by Maciej.
2105
2106         http://bugs.webkit.org/show_bug.cgi?id=15832
2107         fast/dom/gc-10.html crashes when run alone
2108
2109         Check for !done before using objects that can be already deallocated.
2110
2111         * DumpRenderTree/mac/EditingDelegate.mm:
2112         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2113         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2114         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2115         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2116         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2117         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2118         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2119         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2120         (-[EditingDelegate webViewDidBeginEditing:]):
2121         (-[EditingDelegate webViewDidChange:]):
2122         (-[EditingDelegate webViewDidEndEditing:]):
2123         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2124         (-[EditingDelegate webViewDidChangeSelection:]):
2125         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2126         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2127         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2128         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2129         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2130         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2131         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2132         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2133         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2134         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2135         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2136         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2137         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2138         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2139         (-[FrameLoadDelegate webView:willCloseFrame:]):
2140         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2141         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2142         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2143         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2144         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2145         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2146         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2147         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2148         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2149
2150 2007-11-04  Mark Rowe  <mrowe@apple.com>
2151
2152         Build fix.  Don't use Carbon.h as the prefix header as it triggers
2153         warnings that would otherwise be suppressed due to it being a system header.
2154
2155         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2156
2157 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
2158
2159         Rubber stamped by Adam.
2160         
2161         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
2162
2163         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2164
2165 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2166
2167         Sort files(...); sections of Xcode project files.
2168
2169         Rubber-stamped by Darin.
2170
2171         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
2172         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2173         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2174         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2175
2176 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2177
2178         Script to sort "files(...);" sections in Xcode project.pbxproj files.
2179
2180         Reviewed by Darin.
2181
2182         * Scripts/sort-Xcode-project-file: Added.
2183
2184 2007-11-02  Darin Adler  <darin@apple.com>
2185
2186         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
2187
2188 2007-11-02  Darin Adler  <darin@apple.com>
2189
2190         Reviewed by Maciej.
2191
2192         * Scripts/run-sunspider: Pass the "--base" option through.
2193
2194         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
2195         the real script do that. Default configuration to Release to match run-sunspider
2196         so we don't end up building Debug just to compare results.
2197
2198 2007-11-01  Adam Roben  <aroben@apple.com>
2199
2200         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
2201
2202         Reviewed by Sam.
2203
2204         * Scripts/commit-log-editor: Show all the directories beneath the
2205         source root, instead of just the last one.
2206
2207 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
2208
2209         Reviewed by Adam Roben.
2210
2211         Print out an error message when the Windows build fails
2212         and provide guidance on how to find out what went wrong.
2213
2214         * Scripts/build-webkit:
2215         * Scripts/webkitdirs.pm:
2216
2217 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
2218
2219         Rubber-stamped by Adam Roben.
2220
2221         Rolled out r27326 - debug CRT seems to cause no problems after all.
2222
2223         * DumpRenderTree/win/DumpRenderTree.vcproj:
2224
2225 2007-10-31  Adam Roben  <aroben@apple.com>
2226
2227         Switch the Debug configuration to using the non-debug CRT
2228
2229         This matches WebKit.
2230
2231         Reviewed by Steve.
2232
2233         * DumpRenderTree/win/DumpRenderTree.vcproj:
2234
2235 2007-10-31  Antti Koivisto  <antti@apple.com>
2236
2237         Reviewed by bdash.
2238         
2239         Disable media tests when doing leak checking on Tiger.
2240         They crash in QuickTime (rdar://problem/5537157).
2241
2242         * Scripts/run-webkit-tests:
2243
2244 2007-10-29  Antti Koivisto  <antti@apple.com>
2245
2246         Reviewed by Maciej.
2247         
2248         Build media support by default on OSX only.
2249
2250         * Scripts/build-webkit:
2251
2252 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2253
2254         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
2255         get caught by the pre-commit hooks.
2256
2257 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2258
2259         Reviewed by Adam.
2260
2261         - This is a collection of relatively unrelated changes and cleanups
2262         to Drosera to prepare it for interacting with WebKit.  A lot of these
2263         changes are just correcting mistakes, for example removing included
2264         headers that are no longer needed.
2265
2266         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
2267         this will be needed by the DebuggerClient.
2268         (DebuggerDocument::server):
2269         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
2270         * Drosera/win/DebuggerClient.cpp: 
2271         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
2272         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
2273         (DebuggerClient::createWebViewWithRequest): Added comment about its
2274         purpose. 
2275         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
2276         declarations.
2277         (DebuggerClient::webViewLoaded): Moved.
2278         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
2279         file, since this was the only place it was used.
2280         (cfStringToBSTR):
2281         * Drosera/win/Drosera.h: Cleaned up the includes.
2282         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
2283         * Drosera/win/HelperFunctions.h: Removed.
2284
2285 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2286
2287         Reviewed by Adam.
2288
2289         - Small cleanup in the ServerConnection class.
2290
2291         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
2292         and added an include.
2293         (ServerConnection::currentFrame):
2294         (ServerConnection::getCallerFrame):
2295         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
2296         made a pointer into a COMPtr, and cleaned up the includes.
2297
2298 2007-10-29  Timothy Hatcher  <timothy@apple.com>
2299
2300         Reviewed by John Sullivan.
2301         
2302         - Place the Localizable.strings file in mac or win directories
2303           if that location exists.
2304         - Also look for UI_STRING in .c files.
2305
2306         * Scripts/extract-localizable-strings:
2307
2308 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2309
2310         Reviewed by Adam.
2311
2312         - Set the eol-style to native and made all the line endings the same
2313         so that I avoid messy diffs that show eol changes.
2314
2315         * Drosera/win/ServerConnection.cpp:
2316         (ServerConnection::didParseSource):
2317         (ServerConnection::didEnterCallFrame):
2318         (ServerConnection::willExecuteStatement):
2319         (ServerConnection::willLeaveCallFrame):
2320         (ServerConnection::exceptionWasRaised):
2321
2322 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2323
2324         Reviewed by Adam.
2325
2326         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
2327         functionality that could not have existed previously without the new
2328         interfaces.
2329         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
2330         from a BSTR to a JSValueRef.
2331         (DebuggerDocument::platformEvaluateScript): Implemented.
2332         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
2333         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2334         Implemented.
2335         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
2336         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
2337         * Drosera/win/ServerConnection.cpp: Added a helper function.
2338         (ServerConnection::getCallerFrame):
2339         * Drosera/win/ServerConnection.h: Added a helper function.
2340
2341 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2342
2343         updated reviewers for my previous changelog.
2344
2345 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2346         Reviewed by Maciej and Adam and Geoff.
2347
2348         - Minor mac-side improvements including moving a function to a more
2349         appropriate location, fixing a warning, and correctly checking
2350         exceptions.
2351
2352         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
2353         (DebuggerDocument::willExecuteStatement):
2354         (DebuggerDocument::didEnterCallFrame):
2355         (DebuggerDocument::willLeaveCallFrame):
2356         (DebuggerDocument::windowScriptObjectAvailable):
2357         (DebuggerDocument::callFunctionOnObject):
2358         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
2359         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
2360         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
2361         because it doesn't require the ServerConnection at all.
2362         (NSStringCreateWithJSStringRef): Made an argument const.
2363         (JSValueRefCreateWithNSString): Made an argument const.
2364         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
2365         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2366         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
2367         * Drosera/mac/ServerConnection.mm: Ditto.
2368         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2369
2370 2007-10-29  Sam Weinig  <sam@webkit.org>
2371
2372         Reviewed by Adam Roben.
2373
2374         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
2375
2376         * DumpRenderTree/LayoutTestController.cpp:
2377         (LayoutTestController::LayoutTestController):
2378         (getGlobalFlagCallback):
2379         (setGlobalFlagCallback):
2380         (LayoutTestController::getJSClass):
2381         (LayoutTestController::staticValues):
2382         * DumpRenderTree/LayoutTestController.h:
2383         (LayoutTestController::globalFlag):
2384         (LayoutTestController::setGlobalFlag):
2385
2386 2007-10-29  Darin Adler  <darin@apple.com>
2387
2388         Reviewed by Maciej.
2389
2390         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
2391         resolution instead of its default.
2392
2393 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
2394
2395         Fixed showStatus() to print status for successfully resolved conflicts when using git.
2396
2397         Reviewed by Mark Rowe.
2398
2399         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
2400         was successfully resolved, but this would not show any status because the change had
2401         already been cached in the index using "git add".  The solution is to add an optional
2402         second argument to showStatus() which adds the "--cached" switch to the command.
2403
2404         * Scripts/resolve-ChangeLogs:
2405         (showStatus):
2406
2407 2007-10-28  Eric Seidel  <eric@webkit.org>
2408
2409         Reviewed by Maciej and Geoff, in unison.
2410
2411         * Scripts/run-webkit-tests: remove broken --svg option
2412
2413 2007-10-28  Darin Adler  <darin@apple.com>
2414
2415         Reviewed by Adam.
2416
2417         * Scripts/run-sunspider: Default to "Release" configuration rather than
2418         defaulting to the last configuration used as other scripts do. This can
2419         still be overriden on the command line with "--debug" if there's some
2420         reason to do so. Also fix a typo.
2421
2422         * Scripts/sunspider-compare-results: Fix a typo.
2423
2424 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
2425
2426         Reviewed by Adam.
2427
2428         - Implemented the WebScriptDebugListener functions now that the
2429         WebScriptDebugServer exists
2430
2431         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
2432         functions.
2433         (ServerConnection::currentFrame):
2434         (ServerConnection::didLoadMainResourceForDataSource):
2435         (ServerConnection::didParseSource):
2436         (ServerConnection::failedToParseSource):
2437         (ServerConnection::didEnterCallFrame):
2438         (ServerConnection::willExecuteStatement):
2439         (ServerConnection::willLeaveCallFrame):
2440         (ServerConnection::exceptionWasRaised):
2441         * Drosera/win/ServerConnection.h: Removed unused arguments from the
2442         members arguments list.
2443
2444 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
2445
2446         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
2447         <http://bugs.webkit.org/show_bug.cgi?id=15600>
2448
2449         Reviewed by Darin.
2450
2451         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
2452         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
2453         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
2454         file.  Note that it may also be used as a stand-alone script.
2455
2456         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
2457         * Scripts/resolve-ChangeLogs: Added.
2458         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
2459
2460 2007-10-26  Mark Rowe  <mrowe@apple.com>
2461
2462         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
2463         to the Qt port on the assumption that it was an implementation of the cross-platform
2464         LayoutTestController class.  It is not, so it did not need to be changed.
2465
2466         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
2467
2468 2007-10-25  Mark Rowe  <mrowe@apple.com>
2469
2470         Reviewed by Maciej.
2471
2472         Fix builds with code coverage enabled.
2473
2474         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
2475
2476 2007-10-25  Darin Adler  <darin@apple.com>
2477
2478         Reviewed by Mark Rowe.
2479
2480         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
2481         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
2482
2483 2007-10-25  Stephanie  <slewis@apple.com>
2484
2485         build Fix
2486
2487         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2488
2489 2007-10-25  Stephanie  <slewis@apple.com>
2490
2491         Reviewed by Mark Rowe, Adam Roben.
2492
2493         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
2494
2495         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
2496
2497 2007-10-25  Alice Liu  <alice.liu@apple.com>
2498
2499         Reviewed by Adam.
2500
2501         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
2502
2503         Moving destructor into platform-specific files
2504         * DumpRenderTree/LayoutTestController.cpp:
2505         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2506         (LayoutTestController::~LayoutTestController):
2507         * DumpRenderTree/qt/jsobjects.cpp:
2508         (LayoutTestController::~LayoutTestController):
2509
2510         LayoutTestController wasn't being destroyed
2511         * DumpRenderTree/win/DumpRenderTree.cpp:
2512         (runTest):
2513
2514         Added declspec
2515         * DumpRenderTree/win/EditingDelegate.h:
2516
2517         Reset certain values on the webview (or related delegate) that might 
2518         have changed while running a test
2519         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2520         (LayoutTestController::~LayoutTestController):
2521
2522 2007-10-25  Adam Roben  <aroben@apple.com>
2523
2524         Make sunspider-compare-results work with relative paths
2525
2526         Reviewed by Sam.
2527
2528         * Scripts/sunspider-compare-results: Convert arguments to absolute
2529         paths before we chdir.
2530
2531 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
2532
2533         Reviewed by Sam.
2534
2535         - Implemented server calls now the WebScriptDebugServer exists.
2536         - Also removed no longer needed call to initialize CG.
2537
2538         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
2539         automatically now.
2540         (_tWinMain):
2541         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
2542         (ServerConnection::ServerConnection):
2543         (ServerConnection::~ServerConnection):
2544         (ServerConnection::pause):
2545         (ServerConnection::resume):
2546         (ServerConnection::stepInto):
2547         (ServerConnection::applicationTerminating):
2548         (ServerConnection::serverConnectionDidDie):
2549         * Drosera/win/ServerConnection.h: Now uses the COM class.
2550
2551 2007-10-24  George Staikos  <staikos@kde.org>
2552
2553         Unbreak Qt build.
2554
2555         * Scripts/build-webkit:
2556
2557 2007-10-24  Adam Roben  <aroben@apple.com>
2558
2559         Remove now-unnecessary call to InitializeCoreGraphics
2560
2561         WebKit takes care of this now.
2562
2563         Reviewed by Ada.
2564
2565         * DumpRenderTree/win/DumpRenderTree.cpp:
2566         (initialize):
2567
2568 2007-10-24  Adam Roben  <aroben@apple.com>
2569
2570         Use WebTextRenderer in DRT
2571
2572         Reviewed by Ada.
2573
2574         * DumpRenderTree/win/DumpRenderTree.cpp:
2575         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
2576
2577 2007-10-24  Sven Herzberg  <sven@imendio.com>
2578
2579         Reviewed by Mark Rowe.
2580
2581         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
2582         Bug 15614: [GTK] qmake based backends don't build on OS X
2583
2584         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
2585         GTK backend on a Mac
2586         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
2587         isDarwin() to make it reusable in other places (like the workaround-
2588         for-prebuilt-qmake in build-webkit)
2589
2590 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2591
2592         Refurbish update-webkit script.
2593
2594         Reviewed by Adam.
2595
2596         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
2597         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
2598         multi-argument version of system() for flexibility and security.  Check for existence
2599         of Internal directory using -d test instead of -x.
2600
2601 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2602
2603         Minor clean-up of prepare-ChangeLog script.
2604
2605         Reviewed by Adam.
2606
2607         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
2608         of a string.  Use multi-argument versions of open() and system() for flexibility and
2609         security.
2610
2611 2007-10-24  Alice Liu  <alice.liu@apple.com>
2612
2613         Reviewed by Oliver.
2614
2615         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
2616
2617         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
2618         replay the saved events when we're still processing the mousedown that starts the drag
2619         * DumpRenderTree/win/EventSender.cpp:
2620         (doMouseMove):
2621         * DumpRenderTree/win/UIDelegate.cpp:
2622         (UIDelegate::doDragDrop):
2623
2624 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
2625
2626         Reviewed by Sam, Steve and Darin.
2627
2628         - Stubbed out the WebScriptDebugListener functionality in the Server
2629         Connection class to prepare it for receiving those callbacks.
2630         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
2631         and the ServerConnection to not need to be initialized with a server
2632         name, since that is not the way we connect to the WebKit server. 
2633
2634         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
2635         no exception.  Now it only loggs when there is an exception
2636         (DebuggerDocument::willExecuteStatement):
2637         (DebuggerDocument::didEnterCallFrame):
2638         (DebuggerDocument::willLeaveCallFrame):
2639         (DebuggerDocument::windowScriptObjectAvailable):
2640         (DebuggerDocument::callFunctionOnObject):
2641         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
2642         to be instantiated with a server's name.
2643         (DebuggerClient::DebuggerClient):
2644         (DebuggerClient::didFinishLoadForFrame):
2645         * Drosera/win/DebuggerClient.h: Removed unsued variable.
2646         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
2647         a server name.
2648         (Drosera::init):
2649         (Drosera::initServer):
2650         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
2651         instantiated with a server's name.
2652         * Drosera/win/ServerConnection.cpp: 
2653         (ServerConnection::ServerConnection): No longer needs a server name
2654         (ServerConnection::~ServerConnection): Only release the global context
2655         if there is one.
2656         (ServerConnection::serverConnectionDidDie): Stub for
2657         IWebScriptDebugListener
2658         (ServerConnection::QueryInterface): ditto
2659         (ServerConnection::AddRef): ditto
2660         (ServerConnection::Release): ditto
2661         (ServerConnection::didLoadMainResourceForDataSource): ditto
2662         (ServerConnection::didParseSource): ditto
2663         (ServerConnection::failedToParseSource): ditto
2664         (ServerConnection::didEnterCallFrame): ditto
2665         (ServerConnection::willExecuteStatement): ditto
2666         (ServerConnection::willLeaveCallFrame): ditto
2667         (ServerConnection::exceptionWasRaised): ditto
2668         * Drosera/win/ServerConnection.h: Stubbed out the
2669         IWebScriptDebugListener functions, and this class no longer needs to be
2670         instantiated with a server name.
2671
2672 2007-10-24  Lars Knoll  <lars@trolltech.com>
2673
2674         Reviewed by Simon.
2675
2676         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
2677
2678         * DumpRenderTree/qt/jsobjects.h:
2679
2680 2007-10-24  Lars Knoll  <lars@trolltech.com>
2681
2682         Reviewed by Simon.
2683
2684         add another command.
2685
2686         * DumpRenderTree/qt/jsobjects.cpp:
2687         (TextInputController::doCommand):
2688
2689 2007-10-24  Lars Knoll  <lars@trolltech.com>
2690
2691         Reviewed by Simon.
2692
2693         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
2694
2695         * DumpRenderTree/qt/jsobjects.cpp:
2696         (EventSender::keyDown):
2697         * DumpRenderTree/qt/jsobjects.h:
2698
2699 2007-10-24  Lars Knoll  <lars@trolltech.com>
2700
2701         Reviewed by Simon.
2702
2703         implement eventSender.keyDown().
2704
2705         * DumpRenderTree/qt/jsobjects.cpp:
2706         (EventSender::keyDown):
2707
2708 2007-10-24  Lars Knoll  <lars@trolltech.com>
2709
2710         Reviewed by Simon.
2711
2712         some smaller fixes to the editing support in DRT. Makes another few tests pass.
2713
2714         * DumpRenderTree/qt/DumpRenderTree.cpp:
2715         (WebCore::DumpRenderTree::DumpRenderTree):
2716         (WebCore::DumpRenderTree::initJSObjects):
2717         * DumpRenderTree/qt/jsobjects.cpp:
2718         (TextInputController::doCommand):
2719
2720 2007-10-24  Lars Knoll  <lars@trolltech.com>
2721
2722         Reviewed by Simon.
2723
2724         first bit of implementation for the textinputcontroller.
2725
2726         * DumpRenderTree/qt/DumpRenderTree.cpp:
2727         (WebCore::DumpRenderTree::DumpRenderTree):
2728         * DumpRenderTree/qt/DumpRenderTree.h:
2729         * DumpRenderTree/qt/jsobjects.cpp:
2730         (TextInputController::TextInputController):
2731         (TextInputController::doCommand):
2732         * DumpRenderTree/qt/jsobjects.h:
2733
2734 2007-10-24  Lars Knoll  <lars@trolltech.com>
2735
2736         Reviewed by Simon.
2737
2738         make the man webpage believe it has focus, so the editing tests work correctly.
2739
2740         * DumpRenderTree/qt/DumpRenderTree.cpp:
2741         (WebCore::DumpRenderTree::DumpRenderTree):
2742
2743 2007-10-24  Lars Knoll  <lars@trolltech.com>
2744
2745         Reviewed by Simon.
2746
2747         implement layoutTestController.dumpEditingCallbacks() correctly.
2748
2749         * DumpRenderTree/qt/DumpRenderTree.cpp:
2750         (WebCore::DumpRenderTree::DumpRenderTree):
2751         * DumpRenderTree/qt/jsobjects.cpp:
2752         (LayoutTestController::reset):
2753         (LayoutTestController::dumpEditingCallbacks):
2754
2755 2007-10-24  Lars Knoll  <lars@trolltech.com>
2756
2757         Reviewed by Simon.
2758
2759         Implement support for testing editing.
2760
2761         * DumpRenderTree/qt/DumpRenderTree.cpp:
2762         (WebCore::DumpRenderTree::DumpRenderTree):
2763
2764 2007-10-23  Sam Weinig  <sam@webkit.org>
2765
2766         Check for null BSTR that can be passed to the UIDelegate methods
2767         from javascript null and undefined.  Fixes a failing test case on
2768         Windows (fast/dom/Window/alert-undefined.html)
2769
2770         Reviewed by Eric Seidel.
2771
2772         * DumpRenderTree/win/UIDelegate.cpp:
2773         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2774         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2775         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2776         (UIDelegate::webViewAddMessageToConsole):
2777
2778 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2779
2780         Reviewed by Darin.
2781         
2782         Don't print a massive pile of setenvs from tools that automatically build testkjs.
2783
2784         * Scripts/build-testkjs:
2785
2786 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2787
2788         Reviewed by Darin.
2789
2790         - add wrapper that finds the right copy of testkjs
2791         
2792         * Scripts/sunspider-compare-results: Added.
2793
2794 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
2795
2796         Reviewed by Sam.
2797
2798         - After talking with Steve I now see that the WebKit server must be
2799         running for DCOM to create the distributed objects, which makes sense
2800         and currently WebKit only allows one instance to be running at a time
2801         which avoids accidentally connecting to the wrong server
2802         - In light of this I have removed the code for the attach box and
2803         NotificationServer and known server names, since they are all extranious
2804         now.
2805
2806         * Drosera/win/Drosera.cpp: Removed notification classes and known server
2807         names.
2808         (_tWinMain): Uses init instead of initUI.
2809         (droseraWndProc): No longer creats an attach dialog box.
2810         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
2811         it's not manditory to call init before doing COM stuff.
2812         (Drosera::init): calls initUI and will call attach when the
2813         functionality exists. 
2814         (Drosera::initUI): Has changed very little.
2815         (Drosera::attach): Changed the signature to reflect that we no longer
2816         need the dictionary of known server names.
2817         * Drosera/win/Drosera.h: Removed notification classes and known server
2818         names.  Also renamed and moved some functions.
2819         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
2820         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
2821         headers to the resources folder. 
2822         * Drosera/win/resource.h: Removed the Attach box.
2823
2824 2007-10-22  Adam Roben  <aroben@apple.com>
2825
2826         Windows build fix
2827
2828         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
2829
2830 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
2831
2832         - Removed a leak that was fixed.
2833
2834         * Scripts/run-webkit-tests:
2835
2836 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2837
2838         Reviewed by Darin.
2839
2840         - Changed the Client so that the DebuggerDocument now own the
2841         ServerConnection.  This simplifies ownership and cleanup. 
2842
2843         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
2844         ServerConnection.
2845         (DebuggerClient::initWithServerName):
2846         (DebuggerClient::didFinishLoadForFrame):
2847         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
2848         ServerConnection.
2849         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
2850         until after we have a server which we are attached to.
2851         (Drosera::initUI):
2852         (Drosera::attach):
2853         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
2854         out previously.
2855
2856 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2857
2858         Reviewed by Nikolas.
2859
2860         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
2861
2862         * Scripts/run-javascriptcore-tests:
2863
2864 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2865
2866         Reviewed by Nikolas.
2867
2868         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
2869
2870         * Scripts/build-drosera:
2871         * Scripts/build-dumprendertree:
2872         * Scripts/build-testkjs:
2873         * Scripts/build-webkit:
2874         * Scripts/run-javascriptcore-tests:
2875         * Scripts/run-sunspider:
2876         * Scripts/run-webkit-tests:
2877         * Scripts/webkitdirs.pm:
2878
2879 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
2880
2881         Reviewed by Mark Rowe.
2882         
2883         Fix for local database support after r26879
2884         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
2885
2886         * Scripts/build-webkit:
2887
2888 2007-10-22  Holger Freyther  <zecke@selfish.org>
2889
2890         Reviewed by Simon Hausmann <hausmann@kde.org>.
2891
2892         - Do not build testkjs as an application bundle. This is
2893         needed for run-javascriptcore-tests on OSX.
2894         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
2895         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
2896         as we do not have -rpath on OSX.
2897
2898         * DumpRenderTree/qt/DumpRenderTree.pro:
2899         * Scripts/run-webkit-tests:
2900
2901 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2902
2903         Reviewed by aroben.
2904
2905         Fix support for Signed-off-by detection in prepare-ChangeLog
2906         --git-commit. The Signed-off-by tag does not appear in the header
2907         but usually at the end.
2908
2909         * Scripts/prepare-ChangeLog:
2910
2911 2007-10-21  Mark Rowe  <mrowe@apple.com>
2912
2913         Reviewed by Eric.
2914
2915         Fix run-javascriptcore-tests for Gtk.
2916
2917         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
2918
2919 2007-10-20  Eric Seidel  <eric@webkit.org>
2920
2921         Reviewed by aroben.
2922
2923         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
2924
2925 2007-10-20  Eric Seidel  <eric@webkit.org>
2926
2927         Reviewed by darin.
2928         
2929         Add improved argument handling to run-sunspider, including
2930         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
2931         Also re-factor code into subroutines
2932
2933         * Scripts/build-dumprendertree: removed bogus comments
2934         * Scripts/build-testkjs: Added.
2935         * Scripts/run-javascriptcore-tests: use build-testkjs
2936         * Scripts/run-sunspider: improved argument handling, abstraction
2937         * Scripts/run-webkit-tests: improved abstraction
2938
2939 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
2940
2941         Not reviewed, Windows build fix.
2942
2943         * DumpRenderTree/win/EventSender.cpp:
2944         (keyDownCallback):
2945
2946 2007-10-20  Darin Adler  <darin@apple.com>
2947
2948         Reviewed by Tim Hatcher.
2949
2950         - http://bugs.webkit.org/show_bug.cgi?id=15544
2951           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
2952           not rely on Apple-specific key codes
2953
2954         * DumpRenderTree/mac/EventSendingController.mm:
2955         (-[EventSendingController keyDown:withModifiers:]):
2956         Added named key "rightArrow". Later we could have a whole table of these.
2957         Also tweaked modifiers code a little.
2958
2959         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
2960
2961 2007-10-19  Darin Adler  <darin@apple.com>
2962
2963         Reviewed by Eric.
2964
2965         - http://bugs.webkit.org/show_bug.cgi?id=15566
2966           possible fix for leak seen in DumpRenderTree
2967
2968         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
2969         Delete the item if it's not put on the queue, since the caller has
2970         no way of knowing that. Would be better to have the parameter type
2971         be auto_ptr to express the fact that we take ownership.
2972
2973         - unrelated change
2974
2975         * Drosera/mac/main.m: Add missing include.
2976
2977 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2978
2979         Reviewed by Adam.
2980
2981         - This change should be identical but for some reason was not working
2982         on my machine.
2983
2984         * Scripts/prepare-ChangeLog:
2985
2986 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2987
2988         Reviewed by Oliver and Tim.
2989
2990         - Made use of RetainPtr to avoid retain and release issues and moved the
2991         log function to DebuggerDocumentPlatform, which seems to be a more
2992         logical place for it to live.
2993         - Also moved knownServers from the ServerConnection to
2994         DebuggerApplication to match the Windows code and because it makes sense
2995         that a connection knows its own server but not all of them.
2996
2997         * Drosera/mac/DebuggerClient.h: Moved the log function to
2998           DebuggerDocumentPlatform.
2999         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
3000           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
3001           call for the server name up from the ServerConnection class.
3002         (-[DebuggerClient dealloc]):
3003         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
3004           for the server name up from the ServerConnection.
3005         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
3006         (DebuggerDocument::platformPause):
3007         (DebuggerDocument::platformResume):
3008         (DebuggerDocument::platformStepInto):
3009         (DebuggerDocument::platformEvaluateScript):
3010         (DebuggerDocument::getPlatformCurrentFunctionStack):
3011         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3012         (DebuggerDocument::platformValueForScopeVariableNamed):
3013         (DebuggerDocument::platformLog): Log directly from here. No need to call
3014           DebuggerClient.
3015         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
3016           way I see it, a ServerConnection should only know about its connection
3017           and the group of all possible servers should be kept by the
3018           application.
3019         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
3020           currentServerName, it makes sense that the connection should know that
3021           name.
3022         (-[ServerConnection currentServerName]):
3023
3024 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3025
3026         Reviewed by Adam.
3027
3028         - Integrated changes from mac drosera.  Recently I've encapsulated
3029         out the server connection object from the rest of Drosera because
3030         it is very platform dependent right now and RPC is not implemented on
3031         windows.  This functionality, of communicating with the WebKit server
3032         is the next area I will be focusing on in Windows.
3033
3034         - Other changes and cleanup were made to organize the code and add notes
3035         on which parts still need work.  Also some mac code is added and
3036         commented out, to act as pseudocode for the logic of those parts.
3037
3038         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
3039           pointer.
3040         * Drosera/config.h: Added whitespace.
3041         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
3042           these files got moved into Drosera.h/cpp
3043         * Drosera/win/DebuggerApplication.h: Removed.
3044         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
3045           happened here to better match the logic flow of the same code on the 
3046           mac side and to use the new ServerConnection class.
3047         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
3048         (DebuggerClient::initWithServerName): Initializer that will set up the
3049           class to use a ServerConnection object.  This was necessary so I could
3050           create a DebuggerClient without having to initilaize it at
3051           construction.
3052         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
3053           will be the UIDelegate and FrameLoadDelegate.
3054         (DebuggerClient::AddRef): For IUnknown.
3055         (DebuggerClient::Release): For IUnknown.
3056         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
3057           this still needs to set the global context of the server, but
3058           IWebFrame does not have an accessor for the global context yet. 
3059         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
3060           this is a pass through for the same function in the document.
3061         (DebuggerClient::didReceiveTitle): Unimplemented part of
3062           FrameLoadDelegate this would change the title of the window.
3063         (DebuggerClient::createWebViewWithRequest): Part of the
3064           FrameLoadDelegate.  This is about new windows via Window.open() and
3065           how their delegates are set.
3066         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
3067           UIDelegate.  Just a debug function for printing messages.
3068         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
3069           because the Client should be the UIDelegate and FrameLoadDelegate
3070           to match the delegates on mac.
3071         (DebuggerClient::webViewLoaded): Added accessor method.
3072         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
3073           forgotten to add this file before.  This is where the platform
3074           dependent versions of the Documents functions live. Most of these are
3075           unimplemented because some piece of functionality does not exist on
3076           Windows yet.
3077         (DebuggerDocument::platformPause):
3078         (DebuggerDocument::platformResume):
3079         (DebuggerDocument::platformStepInto):
3080         (DebuggerDocument::platformEvaluateScript):
3081         (DebuggerDocument::getPlatformCurrentFunctionStack):
3082         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3083         (DebuggerDocument::platformValueForScopeVariableNamed):
3084         (DebuggerDocument::platformLog):
3085         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
3086           responsibilities becaue they belong in the Client. Also I laid the
3087           groundwork for attaching Drosera to a WebKit process
3088         (attachWndProc): Now if a server is selected the Client becomes it's
3089           delegate.
3090         (Drosera::Drosera): Added the construction of the Client and dictionary
3091           of server names. 
3092         (Drosera::initUI): This is no longer the delegates, the Client is.
3093         (Drosera::webViewLoaded): Now asks the Client instead of holding local
3094           state. 
3095         (Drosera::applicationDidFinishLaunching): Placeholder for needed
3096           notification registration when it's possible to implement.
3097         (Drosera::serverLoaded): Ditto
3098         (Drosera::serverUnloaded): Ditto
3099         (Drosera::attach): Attach Drosera to the WebKit server.
3100         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
3101         (Drosera::getInst): 
3102         (Drosera::setInst):
3103         (Drosera::knownServers):
3104         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
3105           and added the ServerConnection.
3106         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
3107         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
3108           Most of the functions are completely unimlemented because they cannot
3109           connect with the WebKit server, because one does not exist on Windows
3110           yet.
3111         (ServerConnection::initWithServerName): 
3112         (ServerConnection::~ServerConnection):
3113         (ServerConnection::setGlobalContext):
3114         (ServerConnection::pause):
3115         (ServerConnection::resume):
3116         (ServerConnection::stepInto):
3117         (ServerConnection::switchToServerNamed):
3118         (ServerConnection::applicationTerminating):
3119         (ServerConnection::serverConnectionDidDie):
3120         (ServerConnection::currentFrame):
3121         * Drosera/win/ServerConnection.h: Added. Ditto.
3122         (ServerConnection::ServerConnection):
3123
3124 2007-10-19  Alice Liu  <alice.liu@apple.com>
3125
3126         Reviewed by Darin.
3127
3128         Fix for these broken layout tests on Windows:
3129         
3130         fast/forms/focus-selection-input.html
3131         fast/forms/focus-selection-textarea.html
3132         fast/forms/select-accesskey.html
3133         
3134         * DumpRenderTree/win/EventSender.cpp:
3135         (keyDownCallback):
3136         correct the VK code for alt key.
3137         
3138 2007-10-19  Eric Seidel  <eric@webkit.org>
3139
3140         Reviewed by Mark Rowe.
3141         
3142         Make the GtkLauncher code slightly more readable.
3143
3144         * GtkLauncher/main.cpp:
3145         (setupMainMenu): Added.
3146         (setupMainWindowUI): Added.
3147         (main):
3148
3149 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
3150
3151         Rubber stamped by Adam.
3152         
3153         - don't delay-load WebKit in DumpRenderTree.
3154
3155         * DumpRenderTree/win/DumpRenderTree.vcproj:
3156
3157 2007-10-18  Dan Bernstein  <mitz@apple.com>
3158
3159         Reviewed by Adam Roben.
3160
3161         - fix <rdar://problem/5313523>
3162         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
3163
3164         * DumpRenderTree/mac/DumpRenderTree.mm:
3165         (dump): Changed to use _responseMIMEType.
3166
3167 2007-10-17  Adam Roben  <aroben@apple.com>
3168
3169         Make it possible to have Windows-specific tests and results
3170
3171         When searching for tests to run and the Skipped file, we will only
3172         look in platform/win and the cross-platform directory. When looking
3173         for expected results, we will look in platform/win, then
3174         platform/mac-leopard, then platform/mac, then finally the
3175         cross-platform directory.
3176
3177         Reviewed by Sam.
3178
3179         * Scripts/run-webkit-tests:
3180         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
3181         searching in the cross-platform directory.
3182         (sub buildPlatformHierarchy): Removed some unneeded calls to
3183         dirname/basename.
3184
3185 2007-10-17  Adam Roben  <aroben@apple.com>
3186
3187         Add back the call to register WebKit that we had before WebKitInitializer existed
3188
3189         This is needed to ensure that the right WebKit is used when
3190         instantiating COM objects.
3191
3192         Reviewed by Oliver.
3193
3194         * DumpRenderTree/win/debug_internal.vsprops: Define
3195         DEBUG_WEBKIT_HAS_SUFFIX.
3196         * DumpRenderTree/win/DumpRenderTree.cpp:
3197         (initialize):
3198
3199 2007-10-17  Adam Roben  <aroben@apple.com>
3200
3201         Import File::Basename in webkitdirs since we use it
3202
3203         * Scripts/webkitdirs.pm:
3204
3205 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
3206
3207         - Updated the tiger leaks list to make the internal bots green.
3208
3209         * Scripts/run-webkit-tests:
3210
3211 2007-10-17  Adam Roben  <aroben@apple.com>
3212
3213         Build fix for VC++ Express
3214
3215         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
3216         and ole32.lib.
3217
3218 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3219
3220         Reviewed by Sam.
3221
3222         - Minor mac improvements based on observations I made while implementing the
3223         Windows code.
3224
3225         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
3226         then hand it to the Client who will retain it, it should just be the client who
3227         creates and owns the server.
3228         (-[DebuggerApplication attach:]):
3229         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
3230         * Drosera/mac/DebuggerClient.mm: Creates the server.
3231         (-[DebuggerClient initWithServerName:]):
3232         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
3233         can instead forward declare what it needs.
3234
3235 2007-10-16  Darin Adler  <darin@apple.com>
3236
3237         Reviewed by Geoff Garen.
3238
3239         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
3240         want to turn failing tests into platform-specific test results. Also did a
3241         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
3242         would take the type of results into account only some of the time.
3243
3244 2007-10-16  Adam Roben  <aroben@apple.com>
3245
3246         Add a new nightly launcher script for Windows
3247
3248         This new script is for versions of Safari that don't delay-load
3249         WebKit. I had to make FindSafari be able to print out the nightly
3250         launcher script on stdout because Windows shell scripts can't capture
3251         the output from a command into an environment variable.
3252
3253         Reviewed by Steve.
3254
3255         * FindSafari/FindSafari.cpp:
3256         (_tmain): Added /printSafariLauncher option.
3257         * Scripts/run-webkit-nightly.cmd: Added.
3258
3259 2007-10-16  Adam Roben  <aroben@apple.com>
3260
3261         Replace WebKitInitializer with FindSafari
3262
3263         We now rely on setting the PATH environment variable to tell Windows
3264         where to find WebKit and its dependencies (similar to
3265         DYLD_FRAMEWORK_PATH on Mac).
3266
3267         This change also make DumpRenderTree no longer delay-load WebKit.
3268
3269         Reviewed by Sam.
3270
3271         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
3272         FindSafari.
3273         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
3274         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
3275         WebKitInitializer, don't delay-load WebKit.
3276         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
3277         * Scripts/run-webkit-tests: Ditto.
3278         * Scripts/webkitdirs.pm:
3279         (sub setPathForRunningWebKitApp): Added.
3280         * WebKitInitializer/WebKitInitializer.cpp: Removed.
3281         * WebKitInitializer/WebKitInitializer.h: Removed.
3282         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
3283         * WebKitInitializer/debug.vsprops: Removed.
3284         * WebKitInitializer/debug_internal.vsprops: Removed.
3285         * WebKitInitializer/release.vsprops: Removed.
3286
3287 2007-10-16  Adam Roben  <aroben@apple.com>
3288
3289         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
3290
3291         http://bugs.webkit.org/show_bug.cgi?id=15532
3292
3293         FindSafari simply prints the location of an installed Safari.exe on
3294         stdout.
3295
3296         Reviewed by Darin.
3297
3298         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
3299         (getStringValue):
3300         (getWebViewCLSID):
3301         (getInstalledWebKitDirectory):
3302         (_tmain):
3303         * FindSafari/FindSafari.vcproj: Added.
3304         * Scripts/webkitdirs.pm:
3305         (sub installedSafariPath): Added. Calls FindSafari on Windows.
3306
3307 2007-10-16  Adam Roben  <aroben@apple.com>
3308
3309         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
3310
3311         Reviewed by Kevin McCullough.
3312
3313         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
3314         when referring to WebKit.dll.
3315         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
3316         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
3317         * DumpRenderTree/win/release.vsprops: Ditto.
3318         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
3319         never have a _debug suffix on WebKit.dll.
3320         * WebKitInitializer/WebKitInitializer.cpp:
3321         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
3322         specified.
3323         * WebKitInitializer/debug_internal.vsprops: Added
3324         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
3325
3326 2007-10-16  Darin Adler  <darin@apple.com>
3327
3328         Reviewed by Adele.
3329
3330         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
3331         Remove now-unneeded control/alt key hack; the tests have been updated.
3332
3333 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3334
3335         - Updated leaks list because our internal bot upgraded it's version of leopard and 
3336         one of the leaks was fixed between that revision and the bot's previous version of
3337         leopard.
3338
3339         * Scripts/run-webkit-tests:
3340
3341 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
3342
3343         Reviewed by Tim.
3344
3345         - I encapsulated out the server connecton functionality because it is a specific part
3346         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
3347         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
3348         Windows.  So the majority of this patch is moving preexisting functionality.
3349
3350         - Also I removed the prefix header and changed to use config.h because it is more
3351         standard on how we use config.h in windows and it didn't make much sense to keep
3352         the prefix header and the config.h
3353
3354         * Drosera/DebuggerDocument.cpp:
3355         (DebuggerDocument::DebuggerDocument):
3356         * Drosera/DebuggerDocument.h:
3357         * Drosera/config.h:
3358         * Drosera/mac/DebuggerApplication.mm:
3359         (-[DebuggerApplication attach:]):
3360         * Drosera/mac/DebuggerClient.h:
3361         * Drosera/mac/DebuggerClient.mm:
3362         (-[DebuggerClient initWithServerConnection:]):
3363         (-[DebuggerClient dealloc]):
3364         (-[DebuggerClient windowDidLoad]):
3365         (-[DebuggerClient windowWillClose:]):
3366         (-[DebuggerClient webView:didFinishLoadForFrame:]):
3367         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
3368         * Drosera/mac/DebuggerDocumentPlatform.mm:
3369         (DebuggerDocument::platformPause):
3370         (DebuggerDocument::platformResume):
3371         (DebuggerDocument::platformStepInto):
3372         (DebuggerDocument::platformEvaluateScript):
3373         (DebuggerDocument::getPlatformCurrentFunctionStack):
3374         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3375         (DebuggerDocument::platformValueForScopeVariableNamed):
3376         (DebuggerDocument::platformLog):
3377         * Drosera/mac/Drosera.pch: Removed.
3378         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3379         * Drosera/mac/ServerConnection.h: Added.
3380         * Drosera/mac/ServerConnection.mm: Added.
3381         (-[ServerConnection initWithServerName:]):
3382         (-[ServerConnection dealloc]):
3383         (-[ServerConnection setGlobalContext:]):
3384         (-[ServerConnection pause]):
3385         (-[ServerConnection resume]):
3386         (-[ServerConnection stepInto]):
3387         (-[ServerConnection switchToServerNamed:]):
3388         (-[ServerConnection applicationTerminating:]):
3389         (-[ServerConnection serverConnectionDidDie:]):
3390         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3391         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
3392         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
3393         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
3394         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
3395         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
3396         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
3397         (-[ServerConnection currentFrame]):
3398         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
3399         (-[ServerConnection knownServers]):
3400
3401 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
3402
3403         Reviewed by Eric.
3404
3405         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
3406           Script to automatically search nightly builds for regressions (bisect-builds)
3407
3408         * Scripts/bisect-builds: Added.
3409
3410 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
3411
3412         Reviewed by Darin.
3413
3414         - New JavaScript benchmark
3415         http://bugs.webkit.org/show_bug.cgi?id=15515
3416
3417         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
3418         current development or release build of JavaScriptCore.
3419
3420 2007-10-15  Mark Rowe  <mrowe@apple.com>
3421
3422         Reviewed by Sam.
3423
3424         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
3425
3426         * Scripts/webkitdirs.pm:
3427         - Change checkArgv to remove the options from @ARGV to prevent
3428         them from interfering with further option processing.
3429         - Fix logic error in determineIsQt that would prevent it from bailing out early.
3430         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
3431         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
3432         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
3433
3434 2007-10-15  Darin Adler  <darin@apple.com>
3435
3436         Reviewed by Sam.
3437
3438         - added logging of window.prompt and window.confirm
3439
3440         * DumpRenderTree/mac/UIDelegate.mm:
3441         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3442         Implement the recommended delegate rather than the deprecated one.
3443         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
3444         Added.
3445         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
3446         Added.
3447
3448         * DumpRenderTree/win/UIDelegate.h:
3449         * DumpRenderTree/win/UIDelegate.cpp:
3450         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
3451         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
3452         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
3453         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
3454
3455 2007-10-15  Alice Liu  <alice.liu@apple.com>
3456
3457         Reviewed by Sam Weinig.
3458
3459         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
3460
3461         * DumpRenderTree/win/DumpRenderTree.cpp:
3462         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
3463         (main): allocate the global policy delegate for DRT's custom use
3464         * DumpRenderTree/win/DumpRenderTree.vcproj:
3465         Adding files to project
3466         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
3467         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3468         (LayoutTestController::setCustomPolicyDelegate):
3469         set the webview's policy delegate to DRT's custom one if the test requests it.
3470         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
3471         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
3472         (PolicyDelegate::PolicyDelegate):
3473         (PolicyDelegate::QueryInterface):
3474         (PolicyDelegate::AddRef):
3475         (PolicyDelegate::Release):
3476         (PolicyDelegate::decidePolicyForNavigationAction):
3477         * DumpRenderTree/win/PolicyDelegate.h: Added.
3478         (PolicyDelegate::decidePolicyForNewWindowAction):
3479         (PolicyDelegate::decidePolicyForMIMEType):
3480         (PolicyDelegate::unableToImplementPolicyWithError):
3481
3482 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
3483
3484         Reviewed by Mark.
3485
3486         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
3487         when querying for QMAKE_MKSPECS.
3488
3489 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
3490
3491         Reviewed by Adam Roben.
3492         
3493         Fix run-webkit-tests is too greedy calculating platform hierarchy
3494         http://bugs.webkit.org/show_bug.cgi?id=15465
3495         
3496         Fix run-webkit-tests being too greedy in trying to split the platform name up
3497         causing it to try and find tests in every directory above the first "-" in the
3498         path to the LayoutTests
3499
3500         * Scripts/run-webkit-tests:
3501
3502 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
3503
3504         Reviewed by Darin.
3505
3506         http://bugs.webkit.org/show_bug.cgi?id=15006
3507         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
3508         to reduce code duplication.
3509
3510         * Scripts/build-webkit:
3511         * Scripts/webkitdirs.pm:
3512         buildQMakeProject() renamed to buildQMakeQtProject().
3513         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
3514         unused $colorize has been removed.
3515
3516 === Start merge of feature-branch 2007-10-12 ===
3517
3518 2007-10-08  Eric Seidel  <eric@webkit.org>
3519
3520         Reviewed by Mark Rowe.
3521
3522         * Scripts/build-webkit: add --help, remove unused --color
3523
3524 2007-10-07  Eric Seidel  <eric@webkit.org>
3525
3526         Reviewed by darin.
3527
3528         * Drosera/mac/DebuggerDocumentPlatform.mm:
3529         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
3530
3531 2007-10-03  Rob Buis  <buis@kde.org>
3532
3533         Reviewed by Olliej.
3534
3535         Adapt to changed location of Ahem font.
3536
3537         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3538
3539 2007-10-02  Eric Seidel  <eric@webkit.org>
3540
3541         Reviewed by Adam Roben.
3542         
3543         Make pixel tests more useful!
3544         Finally fix the image diff 0.00% mystery problem
3545         Highlight any image differences in the image diff.
3546         Add a link from image diffs back to original test file.
3547
3548         * DumpRenderTree/mac/ImageDiff.m:
3549         (compareImages): highlight any differences
3550         (computePercentageDifferent): round to two decimal places
3551         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
3552
3553 2007-10-02  Eric Seidel  <eric@webkit.org>
3554
3555         Reviewed by Alexey Proskuryakov.
3556
3557         * Scripts/run-webkit-tests: print the % image difference on main results page
3558
3559 2007-10-02  Mark Rowe  <mrowe@apple.com>
3560
3561         Reviewed by Oliver.
3562
3563         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3564
3565         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3566         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3567
3568 2007-10-01  Mark Rowe  <mrowe@apple.com>
3569
3570         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3571
3572 2007-09-25  Eric Seidel  <eric@webkit.org>
3573
3574         Reviewed by Mark Rowe.
3575         
3576         DerivedSources.make was finding "ENABLE_SVG" in the string
3577         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
3578         quite correctly.
3579
3580         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
3581
3582 2007-09-25  Mark Rowe  <mrowe@apple.com>
3583
3584         Rubber-stamped by Eric.
3585
3586         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
3587         This makes it possible to automate nightly builds for the feature-branch.
3588
3589 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
3590
3591         Rubber stamped by Mark.
3592
3593         Enable svg experimental features as default here in feature-branch.
3594
3595         * Scripts/build-webkit:
3596
3597 2007-06-29  Antti Koivisto  <antti@apple.com>
3598
3599         Reviewed by Weinig.
3600         
3601         Add VIDEO flag for timed media features
3602
3603         * Scripts/build-webkit
3604         
3605 === End merge of feature-branch 2007-10-12 ===
3606
3607 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3608
3609         Reviewed by Darin.
3610
3611         - Updated rational for the leaks list to be more clear.
3612
3613         * Scripts/run-webkit-tests:
3614