WebKitTools/ChangeLog

   1 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
   2
   3         Reviewed by Kenneth Rohde Christiansen.
   4
   5         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
   6         https://bugs.webkit.org/show_bug.cgi?id=31775
   7
   8         LayoutTestController::dumpBackForwardList() should work with local URLs
   9         as well as with normal URLs (in http tests for instance).
  10         Currently it does not output the latter properly.
  11
  12         Unskip a bunch of passing http/navigation tests.
  13
  14         * DumpRenderTree/qt/DumpRenderTree.cpp:
  15         (WebCore::dumpHistoryItem):
  16
  17 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
  18
  19         Reviewed by Oliver Hunt.
  20
  21         ARIA: support aria-flowto
  22         https://bugs.webkit.org/show_bug.cgi?id=31762
  23
  24         * DumpRenderTree/AccessibilityUIElement.cpp:
  25         (ariaFlowToElementAtIndexCallback):
  26         (AccessibilityUIElement::getJSClass):
  27         * DumpRenderTree/AccessibilityUIElement.h:
  28         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
  29         (AccessibilityUIElement::ariaFlowToElementAtIndex):
  30         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  31         (AccessibilityUIElement::ariaFlowToElementAtIndex):
  32         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
  33         (AccessibilityUIElement::ariaFlowToElementAtIndex):
  34
  35 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
  36
  37         Reviewed by Kenneth Christiansen.
  38
  39         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
  40         https://bugs.webkit.org/show_bug.cgi?id=31638
  41
  42         Unfreeze WorkQueue after each test execution.
  43
  44         * DumpRenderTree/qt/DumpRenderTree.cpp:
  45         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
  46
  47 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
  48
  49         Reviewed by Adam Barth.
  50
  51         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
  52         for localhost and 127.0.0.1.
  53         https://bugs.webkit.org/show_bug.cgi?id=31783
  54
  55         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
  56
  57         * DumpRenderTree/qt/DumpRenderTree.cpp:
  58         (WebCore::NetworkAccessManager::NetworkAccessManager):
  59         (WebCore::NetworkAccessManager::sslErrorsEncountered):
  60         (WebCore::WebPage::WebPage):
  61         * DumpRenderTree/qt/DumpRenderTree.h:
  62
  63 2009-11-22  Chris Evans  <cevans@chromium.org>
  64
  65         Reviewed by Adam Barth.
  66
  67         Disable access to file:/// directory listings
  68         https://bugs.webkit.org/show_bug.cgi?id=31329
  69
  70         Implemented setAllowUniversalAccessFromFileURLs to support testing of
  71         file URL security.
  72
  73         * DumpRenderTree/LayoutTestController.cpp:
  74         (setAllowUniversalAccessFromFileURLsCallback):
  75         (LayoutTestController::staticFunctions):
  76         * DumpRenderTree/LayoutTestController.h:
  77         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  78         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
  79         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  80         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
  81         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  82         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
  83         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  84         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
  85
  86 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
  87
  88         Reviewed by Kenneth Rohde Christiansen.
  89
  90         [Qt] Fix the timeout of fast/frames/frame-navigation.html
  91         https://bugs.webkit.org/show_bug.cgi?id=31638
  92
  93         The test is timeouting, because it uses the WorkQueue to load a document in one
  94         of the child frames and once the loading is finished, the DRT does not dump the
  95         tree. This is because it waits for the QWebFrame::loadFinished() signal from
  96         the main frame, while it should connect to QWebPage::loadFinished().
  97
  98         * DumpRenderTree/qt/DumpRenderTree.cpp:
  99         (WebCore::DumpRenderTree::DumpRenderTree):
 100
 101 2009-11-21  Eric Seidel  <eric@webkit.org>
 102
 103         Reviewed by Adam Barth.
 104
 105         bugzilla-tool --help spews way too much text
 106         https://bugs.webkit.org/show_bug.cgi?id=31771
 107
 108         * Scripts/bugzilla-tool:
 109          - Remove self.cached_scm initialization hack.
 110         * Scripts/modules/buildbot.py:
 111          - Make default_host accessible to callers.
 112         * Scripts/modules/commands/download.py:
 113          - Phrase help for all commands consistently and remove spurious help text punctuation.
 114         * Scripts/modules/commands/queries.py: Ditto.
 115         * Scripts/modules/commands/queues.py: Ditto.
 116         * Scripts/modules/commands/upload.py: Ditto.
 117         * Scripts/modules/multicommandtool.py:
 118          - Add HelpPrintingOptionParser.format_epilog to replace
 119            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
 120            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
 121          - Make --help only show a list of commands like "svn help" and "git help" do --
 122            previously --help was listing all commands and options.
 123          - Sort list of commands alphabetically.
 124
 125 2009-11-21  Eric Seidel  <eric@webkit.org>
 126
 127         No review.  Fixing a typo from the previous patch for bug 31767.
 128
 129         AbstractQueue.run_bugzilla_tool throws an exception
 130         https://bugs.webkit.org/show_bug.cgi?id=31769
 131
 132         * Scripts/modules/commands/queues.py:
 133
 134 2009-11-21  Eric Seidel  <eric@webkit.org>
 135
 136         Reviewed by Adam Barth.
 137
 138         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
 139         https://bugs.webkit.org/show_bug.cgi?id=31767
 140
 141         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
 142         Since we don't have a good way to test BugzillaTool pieces, I've
 143         left out a test for now.
 144
 145         * Scripts/bugzilla-tool:
 146          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
 147         * Scripts/modules/commands/queues.py:
 148          - Use tool.path() instead of __file__.
 149         * Scripts/modules/multicommandtool.py:
 150          - Add a new path() method to MultiComandTool.
 151         * Scripts/modules/multicommandtool_unittest.py:
 152          - Provide a path() method.  Little point in testing this mock implementation.
 153
 154 2009-11-21  Adam Barth  <abarth@webkit.org>
 155
 156         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
 157         WebKitTools.
 158
 159         * Scripts/modules/commands/download.py:
 160
 161 2009-11-21  Adam Barth  <abarth@webkit.org>
 162
 163         Reviewed by Eric Seidel.
 164
 165         Convert check-style to use LandingSequence
 166         https://bugs.webkit.org/show_bug.cgi?id=31763
 167
 168         Instead of manipulating the working copy by hand, we should use the
 169         LandingSequence in CheckStyle.  This will make this code eaiser to
 170         test.
 171
 172         * Scripts/modules/commands/download.py:
 173
 174 2009-11-20  Adam Barth  <abarth@webkit.org>
 175
 176         Reviewed by Eric Seidel.
 177
 178         Unit test query commands
 179         https://bugs.webkit.org/show_bug.cgi?id=31755
 180
 181         These tests are pretty rough, but hopefully they'll grow.
 182
 183         * Scripts/modules/commands/queries_unittest.py: Added.
 184         * Scripts/modules/mock_bugzillatool.py: Added.
 185         * Scripts/run-webkit-unittests:
 186
 187 2009-11-20  Eric Seidel  <eric@webkit.org>
 188
 189         Reviewed by Adam Barth.
 190
 191         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
 192         https://bugs.webkit.org/show_bug.cgi?id=31758
 193
 194         * Scripts/modules/multicommandtool.py:
 195          - Allow passing of explicit commands to MultiCommandTool.__init__
 196         * Scripts/modules/multicommandtool_unittest.py:
 197          - Use new Command.name naming system.
 198          - Test Command auto-discovery.
 199         * Scripts/modules/workqueue.py:
 200          - bug_id no longer exists, use patch['bug_id'] instead.
 201         * Scripts/modules/workqueue_unittest.py:
 202          - WorkQueues require names now.
 203          - should_proceed_with_work_item must return a patch object.
 204
 205 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
 206
 207         Reviewed by Beth Dakin.
 208
 209         WAI-ARIA: add support for aria-owns
 210         https://bugs.webkit.org/show_bug.cgi?id=31702
 211
 212         * DumpRenderTree/AccessibilityUIElement.cpp:
 213         (ariaOwnsElementAtIndexCallback):
 214         (AccessibilityUIElement::getJSClass):
 215         * DumpRenderTree/AccessibilityUIElement.h:
 216         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 217         (AccessibilityUIElement::ariaOwnsElementAtIndex):
 218         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 219         (AccessibilityUIElement::ariaOwnsElementAtIndex):
 220         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
 221         (AccessibilityUIElement::ariaOwnsElementAtIndex):
 222
 223 2009-11-20  Eric Seidel  <eric@webkit.org>
 224
 225         Reviewed by Adam Barth.
 226
 227         Fix exception thrown when running the commit-queue.
 228
 229         * Scripts/modules/statusbot.py: patch is optional.
 230         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
 231
 232 2009-11-20  Eric Seidel  <eric@webkit.org>
 233
 234         Reviewed by Adam Barth.
 235
 236         Teach the StatusBot how to support more than just the commit-queue
 237         https://bugs.webkit.org/show_bug.cgi?id=31754
 238
 239         * Scripts/modules/workqueue.py: Another typo.
 240
 241 2009-11-20  Eric Seidel  <eric@webkit.org>
 242
 243         Reviewed by Adam Barth.
 244
 245         Teach the StatusBot how to support more than just the commit-queue
 246         https://bugs.webkit.org/show_bug.cgi?id=31754
 247
 248         * Scripts/modules/commands/queues.py: Fix silly typo.
 249
 250 2009-11-20  Eric Seidel  <eric@webkit.org>
 251
 252         Reviewed by Adam Barth.
 253
 254         Teach the StatusBot how to support more than just the commit-queue
 255         https://bugs.webkit.org/show_bug.cgi?id=31754
 256
 257         * CommitQueueStatus/index.yaml:
 258          - Add indices required for the new queries.
 259         * CommitQueueStatus/queue_status.py:
 260          - Add a patch-status page and move update_status to update-status.
 261          - Only display "commit-queue" status records for the commit-queue.
 262          - Add support for a queue_name property on status records.
 263          - Fix _int_from_request to actually work.
 264         * CommitQueueStatus/update_status.html:
 265          - Add support for a queue_name on status records.
 266          - Remove unused list of bug ids.
 267          * Scripts/modules/commands/queues.py
 268           - Make the queues pass the patch instead of the bug_id to StatusBot.
 269         * Scripts/modules/statusbot.py:
 270          - Support passing the queue_name to the status updates.
 271          - Support fetching patch status with patch_status().
 272         * Scripts/modules/workqueue.py:
 273          - Pass the patch to the StatusBot instead of the bug_id.
 274          - Let WorkQueues have a name.
 275
 276 2009-11-20  Adam Barth  <abarth@webkit.org>
 277
 278         Reviewed by Eric Seidel.
 279
 280         Move bugzilla-tool commands into their own file
 281         https://bugs.webkit.org/show_bug.cgi?id=31752
 282
 283         This will let us write unit tests.
 284
 285         * Scripts/bugzilla-tool:
 286         * Scripts/modules/commands/__init__.py: Added.
 287         * Scripts/modules/commands/download.py: Added.
 288         * Scripts/modules/commands/queries.py: Added.
 289         * Scripts/modules/commands/queues.py: Added.
 290         * Scripts/modules/commands/upload.py: Added.
 291         * Scripts/modules/grammar.py: Added.
 292
 293 2009-11-20  Adam Barth  <abarth@webkit.org>
 294
 295         Reviewed by Eric Seidel.
 296
 297         BuildQueue should check if the tree is currently buildable
 298         https://bugs.webkit.org/show_bug.cgi?id=31744
 299
 300         * Scripts/bugzilla-tool:
 301         * Scripts/modules/landingsequence.py:
 302         * Scripts/modules/webkitlandingscripts.py:
 303
 304 2009-11-20  Adam Barth  <abarth@webkit.org>
 305
 306         Reviewed by Eric Seidel.
 307
 308         Move prepare_clean_working_directory into the LandingSequence
 309         https://bugs.webkit.org/show_bug.cgi?id=31743
 310
 311         * Scripts/bugzilla-tool:
 312         * Scripts/modules/landingsequence.py:
 313
 314 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
 315
 316         Reviewed by Kenneth Rohde Christiansen.
 317
 318         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
 319         https://bugs.webkit.org/show_bug.cgi?id=30460
 320
 321         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
 322
 323         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
 324         (pluginInvoke):
 325
 326 2009-11-20  Adam Barth  <abarth@webkit.org>
 327
 328         Reviewed by Eric Seidel.
 329
 330         Pass the port information to the child process
 331         https://bugs.webkit.org/show_bug.cgi?id=31736
 332
 333         We need to do this so the child process knows what to build!
 334
 335         * Scripts/bugzilla-tool:
 336         * Scripts/modules/landingsequence.py:
 337         * Scripts/modules/webkitport.py:
 338         * Scripts/modules/webkitport_unittest.py:
 339
 340 2009-11-20  Adam Barth  <abarth@webkit.org>
 341
 342         Reviewed by Eric Seidel.
 343
 344         Support Qt port in build-queue
 345         https://bugs.webkit.org/show_bug.cgi?id=31733
 346
 347         * Scripts/bugzilla-tool:
 348
 349 2009-11-20  Adam Barth  <abarth@webkit.org>
 350
 351         Reviewed by Eric Seidel.
 352
 353         Implement a build-queue
 354         https://bugs.webkit.org/show_bug.cgi?id=31725
 355
 356         Currently this just builds the first 10 patches in the review queue.
 357         We'll want to do something smarter soon.
 358
 359         * Scripts/bugzilla-tool:
 360
 361 2009-11-20  Adam Barth  <abarth@webkit.org>
 362
 363         Reviewed by Eric Seidel.
 364
 365         Make commit-queue and style-queue show up in help
 366         https://bugs.webkit.org/show_bug.cgi?id=31724
 367
 368         We need to store their names on their class to make these commands
 369         properly register themselves with MultiCommandTool.
 370
 371         * Scripts/bugzilla-tool:
 372
 373 2009-11-20  Adam Barth  <abarth@webkit.org>
 374
 375         Reviewed by Eric Seidel.
 376
 377         Implement bugzilla-tool build-attachment
 378         https://bugs.webkit.org/show_bug.cgi?id=31722
 379
 380         This command builds an attachment from bugzilla.  It leaves the built
 381         patch in the working copy.
 382
 383         * Scripts/bugzilla-tool:
 384         * Scripts/modules/landingsequence.py:
 385         * Scripts/modules/webkitlandingscripts.py:
 386
 387 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
 388
 389         Reviewed by Xan Lopez.
 390
 391         [GTK] DRT release event does not create the state correctly
 392         https://bugs.webkit.org/show_bug.cgi?id=31717
 393
 394         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
 395
 396 2009-11-20  Eric Seidel  <eric@webkit.org>
 397
 398         Reviewed by Adam Barth.
 399
 400         MultiCommandTool should find Command objects automatically instead of with a manual list
 401         https://bugs.webkit.org/show_bug.cgi?id=31710
 402
 403         * Scripts/bugzilla-tool:
 404         * Scripts/modules/multicommandtool.py:
 405          - Use some wild python-fu to crawl all the known subclasses of Command.
 406
 407 2009-11-20  Adam Barth  <abarth@webkit.org>
 408
 409         Unreviewed "build" fix.  Added missing import.
 410
 411         * Scripts/bugzilla-tool:
 412
 413 2009-11-20  Adam Barth  <abarth@webkit.org>
 414
 415         Unreviewed "build" fix.  I failed to update LandingSequence.test
 416         properly.
 417
 418         * Scripts/modules/landingsequence.py:
 419
 420 2009-11-20  Adam Barth  <abarth@webkit.org>
 421
 422         Reviewed by Eric Seidel.
 423
 424         Create LandingSequence as the all-sing, all-dance landing class
 425         https://bugs.webkit.org/show_bug.cgi?id=31709
 426
 427         Client can inherit from this class to carefully control exactly which
 428         steps they wish to have happen in the landing sequence.
 429
 430         * Scripts/bugzilla-tool:
 431         * Scripts/modules/landingsequence.py: Added.
 432         * Scripts/modules/webkitlandingscripts.py: Added.
 433
 434 2009-11-19  Adam Barth  <abarth@webkit.org>
 435
 436         Reviewed by Eric Seidel.
 437
 438         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
 439         https://bugs.webkit.org/show_bug.cgi?id=31707
 440
 441         This is to help when we implement build-attachment.
 442
 443         * Scripts/bugzilla-tool:
 444
 445 2009-11-19  Adam Barth  <abarth@webkit.org>
 446
 447         Reviewed by Eric Seidel.
 448
 449         Support Qt port in bugzilla-tool
 450         https://bugs.webkit.org/show_bug.cgi?id=31701
 451
 452         Now we support building with Qt!
 453
 454         * Scripts/bugzilla-tool:
 455         * Scripts/modules/webkitport.py: Added.
 456         * Scripts/modules/webkitport_unittest.py: Added.
 457         * Scripts/run-webkit-unittests:
 458
 459 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
 460
 461         Reviewed by Adam Barth.
 462
 463         Remove inserting stderr into patch in bugzilla-tool
 464         https://bugs.webkit.org/show_bug.cgi?id=29914
 465
 466         Modify SCM python module's run_command function to avoid return of stderr
 467         by default, so stderr won't be inserted into the patches.
 468         Modify the related unit test.
 469
 470         * Scripts/modules/scm.py:
 471         * Scripts/modules/scm_unittest.py:
 472
 473 2009-11-19  Eric Seidel  <eric@webkit.org>
 474
 475         Reviewed by Adam Barth.
 476
 477         bugzilla-tool needs per-command help
 478         https://bugs.webkit.org/show_bug.cgi?id=31697
 479
 480         Added support for "bugzilla-tool help command-name"
 481         and a unit test to make sure it works.
 482
 483         * Scripts/modules/multicommandtool.py:
 484         * Scripts/modules/multicommandtool_unittest.py:
 485
 486 2009-11-19  Eric Seidel  <eric@webkit.org>
 487
 488         Reviewed by Adam Barth.
 489
 490         Move MultiCommandTool and Command into a separate file and add some basic unit tests
 491         https://bugs.webkit.org/show_bug.cgi?id=31695
 492
 493         * Scripts/bugzilla-tool:
 494         * Scripts/modules/multicommandtool.py: Added.
 495         * Scripts/modules/multicommandtool_unittest.py: Added.
 496         * Scripts/run-webkit-unittests:
 497
 498 2009-11-19  Eric Seidel  <eric@webkit.org>
 499
 500         No review, just adding a FIXME.
 501
 502         Split out command parsing and help printing from BugzillaTool
 503         https://bugs.webkit.org/show_bug.cgi?id=31688
 504
 505         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
 506
 507 2009-11-19  Eric Seidel  <eric@webkit.org>
 508
 509         Reviewed by Adam Barth.
 510
 511         Split out command parsing and help printing from BugzillaTool
 512         https://bugs.webkit.org/show_bug.cgi?id=31688
 513
 514         * Scripts/bugzilla-tool:
 515          - Add new MultiCommandTool class to contain option parsing and help printing logic.
 516          - Rename private methods to use _ pattern.
 517          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
 518          -
 519
 520 2009-11-19  Eric Seidel  <eric@webkit.org>
 521
 522         Reviewed by Adam Barth.
 523
 524         Re-factor help printing to use modern python idioms
 525         https://bugs.webkit.org/show_bug.cgi?id=31685
 526
 527         * Scripts/bugzilla-tool:
 528
 529 2009-11-19  Eric Seidel  <eric@webkit.org>
 530
 531         Reviewed by Darin Adler.
 532
 533         commit-queue empty queue logs twice
 534         https://bugs.webkit.org/show_bug.cgi?id=31679
 535
 536         * Scripts/bugzilla-tool:
 537
 538 2009-11-19  Eric Seidel  <eric@webkit.org>
 539
 540         Reviewed by Darin Adler.
 541
 542         bugzilla-tool's reviewer/committer rejection message should be clearer
 543         https://bugs.webkit.org/show_bug.cgi?id=31126
 544
 545         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
 546
 547         * Scripts/modules/bugzilla.py:
 548
 549 2009-11-19  Eric Z. Ayers  <zundel@google.com>
 550
 551         Reviewed by Pavel Feldman.
 552
 553         Forces a WM_PAINT event on calling layoutTestController.display()
 554         in order to enable the timeline-paint.html test on Windows.
 555         ::UpdateWindow() does not force an event becaue the window is
 556         not visible.
 557
 558         https://bugs.webkit.org/show_bug.cgi?id=31402
 559
 560         * DumpRenderTree/win/DumpRenderTree.cpp:
 561         (displayWebView):
 562
 563 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
 564
 565         No review needed.
 566
 567         Added myself to committers list.
 568
 569         * Scripts/modules/committers.py:
 570
 571 2009-11-19  Adam Barth  <abarth@webkit.org>
 572
 573         Reviewed by Eric Seidel.
 574
 575         Bugzilla-tool command classes should match command names
 576         https://bugs.webkit.org/show_bug.cgi?id=31666
 577
 578         I renamed all the commands except CommitMessageForCurrentDiff because
 579         the new name would conflict with an existing class.
 580
 581         * Scripts/bugzilla-tool:
 582
 583 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
 584
 585         Reviewed by Gustavo Noronha Silva.
 586
 587         Web Inspector: Implement "show inspector" in WebKit GTK
 588         API and enable console tests.
 589
 590         https://bugs.webkit.org/show_bug.cgi?id=31669
 591
 592         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 593         (LayoutTestController::showWebInspector):
 594
 595 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 596
 597         Reviewed by Simon Hausmann.
 598
 599         Minor refactoring + more documentation.
 600
 601         * DumpRenderTree/qt/DumpRenderTree.cpp:
 602         (WebCore::clearHistory):
 603         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
 604
 605 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
 606
 607         Reviewed by Eric Seidel.
 608
 609         Ignore websocket tests when --no-http is specified.
 610         https://bugs.webkit.org/show_bug.cgi?id=31662
 611
 612         * Scripts/run-webkit-tests:
 613
 614 2009-11-18  Adam Barth  <abarth@webkit.org>
 615
 616         Reviewed by Eric Seidel.
 617
 618         Normalize ' and " in bugzilla-tool
 619         https://bugs.webkit.org/show_bug.cgi?id=31655
 620
 621         We decided " is better than ' and we should be consistent.
 622
 623         * Scripts/bugzilla-tool:
 624
 625 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 626
 627         Reviewed by Kenneth Rohde Christiansen.
 628
 629         [Qt] Remove support for Qt v4.3 or older versions
 630         https://bugs.webkit.org/show_bug.cgi?id=29469
 631
 632         * DumpRenderTree/qt/DumpRenderTree.pro:
 633         * DumpRenderTree/qt/ImageDiff.pro:
 634
 635 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
 636
 637         Reviewed by Eric Seidel.
 638
 639         GitTest.test_create_binary_patch fails if /tmp is symlink
 640         https://bugs.webkit.org/show_bug.cgi?id=31536
 641
 642         * Scripts/modules/scm_unittest.py:
 643
 644 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
 645
 646         Reviewed by Darin Adler.
 647
 648         Configuration for Chromium Build Slaves.
 649
 650         https://bugs.webkit.org/show_bug.cgi?id=31442
 651
 652         * BuildSlaveSupport/build.webkit.org-config/config.json:
 653         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 654
 655 2009-11-18  Eric Seidel  <eric@webkit.org>
 656
 657         Reviewed by Darin Adler.
 658
 659         workqueue.py results in totally broken commit-queue UI
 660         https://bugs.webkit.org/show_bug.cgi?id=31645
 661
 662         * Scripts/bugzilla-tool:
 663          - Remove unneeded use of PatchCollection.
 664          - Grab a new copy of the cq'd patches every run of the queue.
 665
 666 2009-11-18  Sam Weinig  <sam@webkit.org>
 667
 668         Reviewed by Anders Carlsson.
 669
 670         Make the Mac Geolocation API async.
 671
 672         Update DRT to use the new async Mac Geolocation API.
 673
 674         * DumpRenderTree/mac/UIDelegate.mm:
 675         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
 676
 677 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 678
 679         Reviewed by Kenneth Rohde Christiansen.
 680
 681         Add and option to toggle HTML5 datalist support to build-webkit
 682         https://bugs.webkit.org/show_bug.cgi?id=31599
 683
 684         * Scripts/build-webkit:
 685
 686 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
 687
 688         Reviewed by Kevin Ollivier.
 689
 690         Enable wx plugin support using the Windows implementation as a base.
 691
 692         https://bugs.webkit.org/show_bug.cgi?id=31636
 693
 694         * wx/build/settings.py:
 695
 696 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 697
 698         Reviewed by Simon Hausmann.
 699
 700         Change the initialization order so that the controllers
 701         will be created before exporting them to the JS DOM window.
 702
 703         * DumpRenderTree/qt/DumpRenderTree.cpp:
 704         (WebCore::DumpRenderTree::DumpRenderTree):
 705
 706 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 707
 708         Reviewed by Simon Hausmann.
 709
 710         Fix a code copy and paste error. m_page should be page.
 711
 712         * DumpRenderTree/qt/DumpRenderTree.cpp:
 713         (WebCore::DumpRenderTree::createWindow):
 714
 715 2009-11-17  Mark Rowe  <mrowe@apple.com>
 716
 717         Reviewed by Alexey Proskuryakov.
 718
 719         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
 720
 721         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
 722         This prevents symlinks from confusing the descendant check.
 723
 724 2009-11-17  Mark Rowe  <mrowe@apple.com>
 725
 726         Reviewed by Alexey Proskuryakov.
 727
 728         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
 729
 730         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
 731         server to be up rather than having run-webkit-tests abort immediately.
 732
 733         * Scripts/run-webkit-tests:
 734
 735 2009-11-17  Eric Seidel  <eric@webkit.org>
 736
 737         Reviewed by Darin Adler.
 738
 739         commit-queue is failing to set reviewer in ChangeLogs
 740         https://bugs.webkit.org/show_bug.cgi?id=31592
 741
 742         * Scripts/bugzilla-tool: Clarify the "applying" log message.
 743         * Scripts/modules/bugzilla.py:
 744          - Add a new _validate_committer_and_reviewer function as a
 745            temporary solution until we can make a real Attachment object
 746            which knows how to fill in its committer/reviewer fields automatically.
 747
 748 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 749
 750         Unreviewed buildbot fix.
 751
 752         Revert part of earlier patch and add comment, as it
 753         was causing timeouts on the buildbot.
 754
 755         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 756         (LayoutTestController::notifyDone):
 757
 758 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 759
 760         Reviewed by Oliver Hunt.
 761
 762         Make the timeout 15 sec as for the other DRT's and make
 763         it print out the same output when a test timeout.
 764
 765         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 766         (LayoutTestController::waitUntilDone):
 767         (LayoutTestController::notifyDone):
 768         (LayoutTestController::timerEvent):
 769
 770 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
 771
 772         Reviewed by Timothy Hatcher.
 773
 774         Fixed typos in comments.
 775
 776         * Scripts/modules/committers.py:
 777
 778 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
 779
 780         Reviewed by Timothy Hatcher.
 781
 782         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
 783         - Updated DRT to show/close inspector for all tests under /inspector
 784         - Introduced LayoutTestController::setTimelineProfilingEnabled and
 785           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
 786         - Removed reload on each inspector test
 787         - Renamed fast/inspector to fast/inspector-support in order not to trigger
 788         inspector for those.
 789         - Reimplemented timeline tests in order to get rid of reload there.
 790         - Moved tests that don't require harness into the fast group.
 791
 792         https://bugs.webkit.org/show_bug.cgi?id=31472
 793
 794         * DumpRenderTree/LayoutTestController.cpp:
 795         (setTimelineProfilingEnabledCallback):
 796         (closeWebInspectorCallback):
 797         (LayoutTestController::staticFunctions):
 798         * DumpRenderTree/LayoutTestController.h:
 799         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 800         (shouldOpenWebInspector):
 801         (runTest):
 802         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 803         (LayoutTestController::setTimelineProfilingEnabled):
 804         * DumpRenderTree/mac/DumpRenderTree.mm:
 805         (shouldOpenWebInspector):
 806         (runTest):
 807         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 808         (LayoutTestController::setTimelineProfilingEnabled):
 809         * DumpRenderTree/win/DumpRenderTree.cpp:
 810         (shouldOpenWebInspector):
 811         (runTest):
 812         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 813         (LayoutTestController::setTimelineProfilingEnabled):
 814
 815 2009-11-17  Oliver Hunt  <oliver@apple.com>
 816
 817         Reviewed by Maciej Stachowiak.
 818
 819         Incorrect use of JavaScriptCore API in DumpRenderTree
 820         https://bugs.webkit.org/show_bug.cgi?id=31577
 821
 822         Return undefined rather than a literal null.
 823
 824         * DumpRenderTree/AccessibilityUIElement.cpp:
 825         (setSelectedTextRangeCallback):
 826         (incrementCallback):
 827         (decrementCallback):
 828         (showMenuCallback):
 829
 830 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
 831
 832         Reviewed by Beth Dakin.
 833
 834         AX: aria-labelledby duplicates some of its WAI-ARIA label
 835         https://bugs.webkit.org/show_bug.cgi?id=31565
 836
 837         * DumpRenderTree/AccessibilityUIElement.cpp:
 838         (titleUIElementCallback):
 839         (getIsValidCallback):
 840         (AccessibilityUIElement::getJSClass):
 841
 842 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 843
 844         Reviewed by Simon Hausmann.
 845
 846         r50942 broke output from created windows. Make the
 847         m_enableTextOutput a member of the DRT and not the
 848         WebPage.
 849
 850         * DumpRenderTree/qt/DumpRenderTree.cpp:
 851         (WebCore::WebPage::WebPage):
 852         (WebCore::WebPage::javaScriptAlert):
 853         (WebCore::WebPage::javaScriptConsoleMessage):
 854         (WebCore::WebPage::javaScriptConfirm):
 855         (WebCore::WebPage::javaScriptPrompt):
 856         (WebCore::WebPage::acceptNavigationRequest):
 857         (WebCore::DumpRenderTree::DumpRenderTree):
 858         (WebCore::DumpRenderTree::open):
 859         (WebCore::DumpRenderTree::createWindow):
 860         * DumpRenderTree/qt/DumpRenderTree.h:
 861         (WebCore::DumpRenderTree::setTextOutputEnabled):
 862         (WebCore::DumpRenderTree::isTextOutputEnabled):
 863         (WebCore::WebPage::shouldInterruptJavaScript):
 864         (WebCore::WebPage::isTextOutputEnabled):
 865         (WebCore::WebPage::setViewGeometry):
 866
 867 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 868
 869         Reviewed by Gustavo Noronha Silva.
 870
 871         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
 872         as the implementation is being used by at least Qt and Gtk+.
 873
 874         Update buildsystems as well.
 875
 876         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
 877         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
 878         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
 879         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
 880         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
 881         * GNUmakefile.am:
 882
 883 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
 884
 885         Reviewed by Alexey Proskuryakov.
 886
 887         Disable wss until all platforms support pyOpenSSL
 888
 889         https://bugs.webkit.org/show_bug.cgi?id=31479
 890
 891         * Scripts/run-webkit-tests:
 892
 893 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
 894
 895         Reviewed by Kenneth Christiansen.
 896
 897         [Qt] Implement load error pages support for Qt's DRT.
 898         https://bugs.webkit.org/show_bug.cgi?id=31509
 899
 900         For now, it will not be a default feature, and layout tests
 901         that want to make use of this have to explicitily call
 902         'handleErrorPages();' for the test source.
 903
 904         Any of the other DumpRenderTree's (mac, win and gtk)
 905         support handling error pages. Qt's will be the first.
 906
 907         * DumpRenderTree/qt/DumpRenderTree.cpp:
 908         (WebCore::WebPage::supportsExtension):
 909         (WebCore::WebPage::extension):
 910         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 911         (LayoutTestController::reset):
 912         * DumpRenderTree/qt/LayoutTestControllerQt.h:
 913         (LayoutTestController::shouldHandleErrorPages):
 914         (LayoutTestController::handleErrorPages):
 915
 916 2009-11-16  Eric Seidel  <eric@webkit.org>
 917
 918         Reviewed by Adam Barth.
 919
 920         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
 921         https://bugs.webkit.org/show_bug.cgi?id=31549
 922
 923         Renamed --commit-queue to --non-interactive in most places
 924         and remove the code in land-patches which is no longer needed.
 925
 926         * Scripts/bugzilla-tool:
 927
 928 2009-11-16  Eric Seidel  <eric@webkit.org>
 929
 930         Reviewed by Adam Barth.
 931
 932         The commit-queue should use land-attachment
 933         https://bugs.webkit.org/show_bug.cgi?id=31548
 934
 935         * Scripts/bugzilla-tool:
 936
 937 2009-11-16  Adam Barth  <abarth@webkit.org>
 938
 939         Reviewed by Eric Seidel.
 940
 941         Convert CommitQueue over to PatchCollection
 942         https://bugs.webkit.org/show_bug.cgi?id=31547
 943
 944         Also fixes a bug in workqueue and adds a test!
 945
 946         * Scripts/bugzilla-tool:
 947         * Scripts/modules/workqueue.py:
 948         * Scripts/modules/workqueue_unittest.py:
 949
 950 2009-11-16  Adam Barth  <abarth@webkit.org>
 951
 952         Reviewed by Eric Seidel.
 953
 954         Move StyleQueue over to using PatchCollection
 955         https://bugs.webkit.org/show_bug.cgi?id=31544
 956
 957         That's what the class it's for.
 958
 959         * Scripts/bugzilla-tool:
 960         * Scripts/modules/patchcollection.py:
 961         * Scripts/modules/patchcollection_unittest.py:
 962
 963 2009-11-16  Eric Seidel  <eric@webkit.org>
 964
 965         Reviewed by Adam Barth.
 966
 967         bugzilla-tool needs a land-attachment command
 968         https://bugs.webkit.org/show_bug.cgi?id=31546
 969
 970         * Scripts/bugzilla-tool:
 971          - Move all the logic into AbstractLandingCommand and
 972            add a new LandAttachment command subclass.
 973          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
 974
 975 2009-11-16  Eric Seidel  <eric@webkit.org>
 976
 977         Reviewed by Adam Barth.
 978
 979         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
 980         https://bugs.webkit.org/show_bug.cgi?id=31543
 981
 982         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
 983
 984         * Scripts/bugzilla-tool:
 985
 986 2009-11-16  Eric Seidel  <eric@webkit.org>
 987
 988         Reviewed by Adam Barth.
 989
 990         Disable the style queue from posting to the commit queue status page.
 991
 992         * Scripts/bugzilla-tool:
 993
 994 2009-11-16  Adam Barth  <abarth@webkit.org>
 995
 996         Reviewed by Eric Seidel.
 997
 998         Implement PatchCollection
 999         https://bugs.webkit.org/show_bug.cgi?id=31541
1000
1001         This class holds a set of patches and lets clients iterate through
1002         them.  Optionally, clients can install a filter.
1003
1004         * Scripts/modules/patchcollection.py: Added.
1005         * Scripts/modules/patchcollection_unittest.py: Added.
1006         * Scripts/run-webkit-unittests:
1007
1008 2009-11-16  Eric Seidel  <eric@webkit.org>
1009
1010         Reviewed by Adam Barth.
1011
1012         bugzilla-tool land-patches will close bugs with patches r=?
1013         https://bugs.webkit.org/show_bug.cgi?id=28230
1014
1015         The commit-queue shouldn't close patches with outstanding reviews on them,
1016         even if many reviewers seem to be against multi-patch bugs.
1017
1018         * Scripts/bugzilla-tool:
1019
1020 2009-11-16  Eric Seidel  <eric@webkit.org>
1021
1022         Reviewed by Adam Barth.
1023
1024         bugzilla-tool check-style should work with attachment ids instead of bug ids
1025         https://bugs.webkit.org/show_bug.cgi?id=31540
1026
1027         * Scripts/bugzilla-tool:
1028
1029 2009-11-16  Eric Seidel  <eric@webkit.org>
1030
1031         Reviewed by Adam Barth.
1032
1033         WorkQueue is the only place that should know about special exit codes
1034         https://bugs.webkit.org/show_bug.cgi?id=31534
1035
1036         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
1037         and add tests for handling exit codes.
1038         I also cleaned up workqueue_unittest.py more.
1039
1040         * Scripts/bugzilla-tool:
1041         * Scripts/modules/workqueue.py:
1042         * Scripts/modules/workqueue_unittest.py:
1043
1044 2009-11-16  Eric Seidel  <eric@webkit.org>
1045
1046         Reviewed by Adam Barth.
1047
1048         Re-factor workqueue_unittest to allow for more than one test.
1049         https://bugs.webkit.org/show_bug.cgi?id=31535
1050
1051         * Scripts/modules/workqueue_unittest.py:
1052
1053 2009-11-16  Eric Seidel  <eric@webkit.org>
1054
1055         Reviewed by Adam Barth.
1056
1057         land-patches needs to be re-factored into smaller chunks
1058         https://bugs.webkit.org/show_bug.cgi?id=31532
1059
1060         * Scripts/bugzilla-tool: fix a couple obvious typos.
1061
1062 2009-11-16  Eric Seidel  <eric@webkit.org>
1063
1064         Reviewed by Adam Barth.
1065
1066         land-patches needs to be re-factored into smaller chunks
1067         https://bugs.webkit.org/show_bug.cgi?id=31532
1068
1069         The next patch will move these methods into WebKitLandingScripts.
1070
1071         * Scripts/bugzilla-tool:
1072          - Split out _land_patch and _close_bug_if_no_active_patches.
1073
1074 2009-11-16  Adam Barth  <abarth@webkit.org>
1075
1076         Reviewed by Eric Seidel.
1077
1078         Fix silly copy-and-paste code.  I am a terrible coder.
1079
1080         * Scripts/modules/bugzilla.py:
1081
1082 2009-11-16  Adam Barth  <abarth@webkit.org>
1083
1084         Reviewed by Eric Seidel.
1085
1086         Implement a StyleQueue
1087         https://bugs.webkit.org/show_bug.cgi?id=31537
1088
1089         The first iteration of the style queue only produces output locally.
1090         There is also a limit of 10 patches because it's not that useful to
1091         iterate through the entire review queue at this point.  We can remove
1092         the limit later.
1093
1094         * Scripts/bugzilla-tool:
1095         * Scripts/modules/bugzilla.py:
1096
1097 2009-11-16  Adam Barth  <abarth@webkit.org>
1098
1099         Reviewed by Eric Seidel.
1100
1101         Unit test WorkQueue
1102         https://bugs.webkit.org/show_bug.cgi?id=31531
1103
1104         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
1105
1106         * Scripts/bugzilla-tool:
1107         * Scripts/modules/statusbot.py:
1108         * Scripts/modules/workqueue.py:
1109         * Scripts/modules/workqueue_unittest.py: Added.
1110         * Scripts/run-webkit-unittests:
1111
1112 2009-11-16  Eric Seidel  <eric@webkit.org>
1113
1114         Reviewed by Adam Barth.
1115
1116         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
1117         https://bugs.webkit.org/show_bug.cgi?id=31530
1118
1119         * Scripts/bugzilla-tool:
1120
1121 2009-11-16  Eric Seidel  <eric@webkit.org>
1122
1123         Reviewed by Adam Barth.
1124
1125         bugzilla-tool needs apply-attachment
1126         https://bugs.webkit.org/show_bug.cgi?id=31528
1127
1128         * Scripts/bugzilla-tool:
1129          - Add ApplyAttachment command.
1130          - Abstract applying code into WebKitApplyingScripts.
1131          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
1132         * Scripts/modules/bugzilla.py:
1133          - Add fetch_attachment and bug_id_for_attachment_id.
1134         * Scripts/modules/bugzilla_unittest.py:
1135          - Add test for new parsing.
1136          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
1137
1138 2009-11-16  Eric Seidel  <eric@webkit.org>
1139
1140         Reviewed by Adam Barth.
1141
1142         Document check-style's use of force_clean.
1143
1144         * Scripts/bugzilla-tool:
1145         * Scripts/modules/scm.py:
1146
1147 2009-11-16  Adam Barth  <abarth@webkit.org>
1148
1149         Reviewed by Eric Seidel.
1150
1151         Move WorkQueue to its own file
1152         https://bugs.webkit.org/show_bug.cgi?id=31529
1153
1154         WorkQueue and WorkQueueDelegate are separate concerns from
1155         bugzilla-tool.  Also added a missing include to logging.py.
1156
1157         * Scripts/bugzilla-tool:
1158         * Scripts/modules/logging.py:
1159         * Scripts/modules/workqueue.py:
1160
1161 2009-11-16  Adam Barth  <abarth@webkit.org>
1162
1163         Reviewed by Eric Seidel.
1164
1165         Move OutputTee to logging.py.
1166
1167         * Scripts/bugzilla-tool:
1168         * Scripts/modules/logging.py:
1169
1170 2009-11-15  Adam Barth  <abarth@webkit.org>
1171
1172         Reviewed by Eric Seidel.
1173
1174         Refactor bugzilla-tool to allow for multiple queues
1175         https://bugs.webkit.org/show_bug.cgi?id=31513
1176
1177         Divide the commit queue class into three class to make creating
1178         additional queues easier.
1179
1180         * Scripts/bugzilla-tool:
1181
1182 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1183
1184         Reviewed by Eric Seidel.
1185
1186         svn-apply may not handle git patches created by bugzilla-tool
1187         https://bugs.webkit.org/show_bug.cgi?id=31457
1188
1189         * Scripts/modules/scm.py:
1190         * Scripts/modules/scm_unittest.py:
1191
1192 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1193
1194         Reviewed by Eric Seidel.
1195
1196         bugzilla-tool should post git binary diff
1197         https://bugs.webkit.org/show_bug.cgi?id=31458
1198
1199         Add --binary option to Git.create_patch.
1200
1201         * Scripts/modules/scm.py:
1202         * Scripts/modules/scm_unittest.py:
1203
1204 2009-11-15  Adam Barth  <abarth@webkit.org>
1205
1206         Reviewed by Darin Adler.
1207
1208         Add bugzilla-tool check-style
1209         https://bugs.webkit.org/show_bug.cgi?id=31515
1210
1211         * Scripts/bugzilla-tool:
1212         * Scripts/modules/bugzilla.py:
1213
1214 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1215
1216         Reviewed by Simon Hausmann.
1217
1218         Make the Qt Linux only --valgrind feature, suppress errors
1219         defined in the SuppressedValgrindErrors file.
1220
1221         * Scripts/run-webkit-tests:
1222
1223 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1224
1225         Reviewed by Simon Hausmann.
1226
1227         Set the locale to C and not to the current one in use on the system.
1228
1229         * DumpRenderTree/qt/DumpRenderTree.cpp:
1230         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1231
1232 2009-11-13  Adam Roben  <aroben@apple.com>
1233
1234         Add support for
1235         http/tests/security/isolatedWorld/didClearWindowObject.html
1236
1237         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
1238         window objects in isolated worlds are cleared
1239
1240         Reviewed by Dave Hyatt.
1241
1242         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
1243
1244         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1245         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1246         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
1247         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
1248         Added. Sets a __worldID property on the global object whose value is
1249         the ID of this world.
1250         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
1251         Respond to this new delegate callback by calling through to one of the
1252         above new methods.
1253         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1254         (worldMap): Added. Returns a HashMap containing all the worlds we've
1255         created.
1256         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
1257         haven't kept track of this world.
1258         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1259         instead of declaring our own.
1260
1261         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
1262
1263         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1264         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
1265         didClearWindowObjectForFrameInStandardWorld.
1266         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
1267         Respond to this new delegate callback by calling through to one of the
1268         below new methods.
1269         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
1270         Added. Sets a __worldID property on the gobal object whose value is
1271         the ID of this world.
1272         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1273         Added. Moved code here from didClearWindowObject.
1274
1275         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
1276         didClearWindowObjectForFrame* functions.
1277
1278         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1279         (worldMap): Added. Returns a HashMap containing all the worlds we've
1280         created.
1281         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
1282         haven't kept track of this world.
1283         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1284         instead of declaring our own.
1285
1286 2009-11-13  Adam Roben  <aroben@apple.com>
1287
1288         Finish replacing worldIDs with world objects
1289
1290         The only remaining use of worldIDs was in a method only used by DRT
1291         for the isolated worlds tests.
1292
1293         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
1294
1295         Reviewed by Mark Rowe.
1296
1297         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1298         (LayoutTestController::evaluateScriptInIsolatedWorld):
1299         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1300         (LayoutTestController::evaluateScriptInIsolatedWorld):
1301         Updated for changes to WebFrame. Now holds the map of worldID -> world
1302         at this level instead of making WebKit do it.
1303
1304 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1305
1306         Reviewed by Simon Hausmann.
1307
1308         [Qt] Ensure the DRT does not output anything until first test is run
1309
1310         * DumpRenderTree/qt/DumpRenderTree.cpp:
1311         * DumpRenderTree/qt/DumpRenderTree.h:
1312
1313 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1314
1315         Reviewed by Tor Arne Vestbø.
1316
1317         Clear the undo stack in before each new test run.
1318
1319         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
1320
1321         * DumpRenderTree/qt/DumpRenderTree.cpp:
1322         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1323
1324 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1325
1326         Reviewed by Kenneth Rohde Christiansen.
1327
1328         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
1329
1330         * DumpRenderTree/qt/DumpRenderTree.cpp:
1331         (WebCore::WebPage::resetSettings):
1332         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1333         (LayoutTestController::overridePreference):
1334
1335 2009-11-13  Eric Seidel  <eric@webkit.org>
1336
1337         Reviewed by Adam Barth.
1338
1339         Update committers.py based on svn records
1340         https://bugs.webkit.org/show_bug.cgi?id=31366
1341
1342         This list was generated using validate-committer-lists from
1343         https://bugs.webkit.org/show_bug.cgi?id=30970
1344         and makes committers.py current for committers who have
1345         committed in the last 3 years.
1346
1347         * Scripts/modules/committers.py:
1348
1349 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
1350
1351         Reviewed by Adam Barth.
1352
1353         The document-open.html test was flaky at times. The test invokes the layout test plugin
1354         which in its destroy stream handler opens a new document. This basically tears down the
1355         stream and the associated plugin instance. The pluginLog function in the layout test
1356         plugin attempts to retrieve the window script object on a torn down plugin instance
1357         which crashed consistently on windows in the debugger. The functions which issue
1358         these logs already have a valid window script object. We now have variants of the pluginLog
1359         function which take in a window script object with and without variable arguments.
1360
1361         https://bugs.webkit.org/show_bug.cgi?id=31067
1362
1363         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1364         (pluginLogWithWindowObject):
1365         (pluginLogWithWindowObjectVariableArgs):
1366         (pluginLog):
1367         (notifyTestCompletion):
1368         (testDocumentOpen):
1369         (testWindowOpen):
1370
1371 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1372
1373         Reviewed by Gustavo Noronha Silva.
1374
1375         https://bugs.webkit.org/show_bug.cgi?id=30997
1376         [Gtk] Implemment AtkDocument
1377
1378         Added testing support.
1379
1380         * DumpRenderTree/AccessibilityUIElement.cpp:
1381         * DumpRenderTree/AccessibilityUIElement.h:
1382         (getDocumentEncodingCallback):
1383         (getDocumentURICallback):
1384         (AccessibilityUIElement::getJSClass):
1385         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1386         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1387         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1388         (AccessibilityUIElement::documentEncoding):
1389         (AccessibilityUIElement::documentURI):
1390
1391 2009-11-12  Adam Roben  <aroben@apple.com>
1392
1393         Replace worldIDs with world objects
1394
1395         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
1396         user scripts/stylesheets and isolated worlds
1397
1398         Reviewed by Sam Weinig.
1399
1400         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1401         (LayoutTestController::addUserScript):
1402         (LayoutTestController::addUserStyleSheet):
1403         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1404         (LayoutTestController::addUserScript):
1405         (LayoutTestController::addUserStyleSheet):
1406         Changed these functions to create a new WebJSWorld each time they're
1407         called and to pass that world to WebKit.
1408
1409 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
1410
1411         Reviewed by Oliver Hunt.
1412
1413         need to implement aria tree roles
1414         https://bugs.webkit.org/show_bug.cgi?id=31284
1415
1416         * DumpRenderTree/AccessibilityUIElement.cpp:
1417         (disclosedRowAtIndexCallback):
1418         (selectedRowAtIndexCallback):
1419         (isEqualCallback):
1420         (isAttributeSettableCallback):
1421         (isActionSupportedCallback):
1422         (disclosedByRowCallback):
1423         (hierarchicalLevelCallback):
1424         (AccessibilityUIElement::getJSClass):
1425         * DumpRenderTree/AccessibilityUIElement.h:
1426         (AccessibilityUIElement::isEqual):
1427         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1428         (AccessibilityUIElement::hierarchicalLevel):
1429         (AccessibilityUIElement::disclosedRowAtIndex):
1430         (AccessibilityUIElement::selectedRowAtIndex):
1431         (AccessibilityUIElement::disclosedByRow):
1432         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1433         (AccessibilityUIElement::getChildAtIndex):
1434         (AccessibilityUIElement::disclosedRowAtIndex):
1435         (AccessibilityUIElement::selectedRowAtIndex):
1436         (AccessibilityUIElement::titleUIElement):
1437         (AccessibilityUIElement::parentElement):
1438         (AccessibilityUIElement::disclosedByRow):
1439         (AccessibilityUIElement::hierarchicalLevel):
1440         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1441         (AccessibilityUIElement::hierarchicalLevel):
1442         (AccessibilityUIElement::disclosedRowAtIndex):
1443         (AccessibilityUIElement::selectedRowAtIndex):
1444         (AccessibilityUIElement::disclosedByRow):
1445
1446 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
1447
1448         Reviewed by Darin Adler.
1449
1450         svn-apply can not handle git binary diffs
1451         https://bugs.webkit.org/show_bug.cgi?id=26830
1452
1453         Support "literal" type git binary diffs.
1454
1455         * Scripts/VCSUtils.pm:
1456         * Scripts/modules/scm_unittest.py:
1457         * Scripts/svn-apply:
1458
1459 2009-11-11  Dmitry Titov  <dimich@chromium.org>
1460
1461         Not reviewed, removing duplicate entry for myself in committers.py.
1462
1463         * Scripts/modules/committers.py:
1464
1465 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
1466
1467         Reviewed by Darin Adler and Mark Rowe.
1468
1469         https://bugs.webkit.org/show_bug.cgi?id=31200
1470         Tests in http/tests/security/mixedContent start to fail when new tests are added
1471
1472         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
1473
1474 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1475
1476         Reviewed by Jan Alonzo.
1477
1478         Create, and display a window for the inspector, for inspector
1479         tests.
1480
1481         Need to also show/hide the inspector window to avoid having
1482         problems with code assuming it is realized
1483         https://bugs.webkit.org/show_bug.cgi?id=31347
1484
1485         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1486         (webInspectorShowWindow):
1487         (webInspectorCloseWindow):
1488         (webInspectorInspectWebView):
1489         (createWebView):
1490
1491 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1492
1493         Unreviewed Qt buildbot fix.
1494
1495         My previous fix was wrong, so revert that change and fix it by
1496         returning when the document of the frame has no document element.
1497         Idea is borrowed from mac and win DRT.
1498
1499         * DumpRenderTree/qt/DumpRenderTree.cpp:
1500         (WebCore::DumpRenderTree::dumpFramesAsText):
1501
1502 2009-11-11  Eric Seidel  <eric@webkit.org>
1503
1504         Reviewed byg Kenneth Rohde Christiansen.
1505
1506         Update Kenneth's committer record to include the email he
1507         uses on lists.webkit.org.
1508
1509         * Scripts/modules/committers.py:
1510
1511 2009-11-11  Eric Seidel  <eric@webkit.org>
1512
1513         Reviewed by Gustavo Noronha Silva.
1514
1515         Several committers use separate email addresses for bugzilla and svn.webkit.org
1516         https://bugs.webkit.org/show_bug.cgi?id=31364
1517
1518         Update records for existing committers to include email addresses
1519         used in svn.webkit.org and lists.webkit.org.
1520         Most committers use the same email address in all 3 places, but some use
1521         separate addresses.  committers.py needs record of each of these addresses.
1522
1523         * Scripts/modules/committers.py:
1524
1525 2009-11-11  Eric Seidel  <eric@webkit.org>
1526
1527         No review, adding second email address for an existing committer.
1528
1529         Add Yong Li's second bugzilla account to his committer record.
1530         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
1531
1532         * Scripts/modules/committers.py:
1533
1534 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1535
1536         Reviewed by Simon Hausmann.
1537
1538         If the frame has no innerText don't append it, and
1539         do not add a newline which breaks some cross platform
1540         results.
1541
1542         * DumpRenderTree/qt/DumpRenderTree.cpp:
1543         (WebCore::DumpRenderTree::dumpFramesAsText):
1544
1545 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1546
1547         Reviewed by Simon Hausmann.
1548
1549         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
1550
1551         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1552         (webkit_test_plugin_new_instance):
1553         (webkit_test_plugin_destroy_instance):
1554         (webkit_test_plugin_destroy_stream):
1555
1556 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1557
1558         Reviewed by Mark Rowe.
1559
1560         Implement the functionality needed by plugins/window-open.html
1561
1562         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1563         (webkit_test_plugin_new_instance):
1564         (webkit_test_plugin_set_window):
1565
1566 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1567
1568         Reviewed by Simon Hausmann.
1569
1570         [Qt] Force -graphicssystem raster and -style windows when running DRT
1571
1572         * DumpRenderTree/qt/main.cpp:
1573         * Scripts/run-webkit-tests:
1574
1575 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1576
1577         Reviewed by Simon Hausmann.
1578
1579         Compute correct library paths for Qt
1580
1581         * Scripts/webkitdirs.pm:
1582
1583 2009-11-10  Mark Rowe  <mrowe@apple.com>
1584
1585         Reviewed by Sam Weinig.
1586
1587         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
1588
1589         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
1590         about the validity of the self-signed certificates used in the regression tests.  We would then add the
1591         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
1592         that had enabled frame load delegate logging this would result in extra log messages being generated,
1593         causing the test to fail.
1594
1595         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
1596         tests.
1597
1598         * DumpRenderTree/mac/DumpRenderTree.mm:
1599         (dumpRenderTree):
1600         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1601         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1602
1603 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1604
1605         Reviewed by Kenneth Rohde Christiansen.
1606
1607         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
1608
1609         * DumpRenderTree/qt/DumpRenderTree.cpp:
1610         (WebCore::DumpRenderTree::DumpRenderTree):
1611
1612 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1613
1614         Reviewed by Jan Alonzo.
1615
1616         [GTK] Remove WebSocket configuration from WebKitWebSettings
1617         https://bugs.webkit.org/show_bug.cgi?id=31244
1618
1619         Follow-up of r50724. Don't set the enable-web-socket property
1620         anymore.
1621
1622         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1623         (resetDefaultsToConsistentValues):
1624
1625 2009-11-10  Oliver Hunt  <oliver@apple.com>
1626
1627         Reviewed by Maciej Stachowiak.
1628
1629         Rename 3D Canvas related classes to use WebGL prefix
1630         https://bugs.webkit.org/show_bug.cgi?id=29095
1631
1632         Checkin new version of do-webcore-rename used to do the WebGL type rename,
1633         and upate webkitdirs script to new method of testing for WebGL.
1634
1635         * Scripts/do-webcore-rename:
1636         * Scripts/webkitdirs.pm:
1637
1638 2009-11-09  Oliver Hunt  <oliver@apple.com>
1639
1640         Reviewed by Geoff Garen.
1641
1642         Make do-webcore-rename work with git.
1643
1644         * Scripts/do-webcore-rename:
1645
1646 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
1647
1648         Adding Kenneth to the reviewers list.
1649
1650         * Scripts/modules/committers.py:
1651
1652 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1653
1654         Reviewed by Jan Alonzo.
1655
1656         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
1657         https://bugs.webkit.org/show_bug.cgi?id=30482
1658
1659         LayoutTestControllerGtk now uses the exposed
1660         Page::tabKeyCyclesThroughElements API
1661
1662         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1663         (LayoutTestController::setTabKeyCyclesThroughElements):
1664
1665 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
1666
1667         Reviewed by Holger Freyther.
1668
1669         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
1670         This helps to pass the test case below. Also replaced hardcoded
1671         code numbers with defined constants.
1672         https://bugs.webkit.org/show_bug.cgi?id=31185
1673
1674         Test: editing/undo/undo-deleteWord.html
1675
1676         * DumpRenderTree/qt/EventSenderQt.cpp:
1677         (EventSender::keyDown):
1678
1679 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
1680
1681         Reviewed by Holger Freyther.
1682
1683         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
1684         https://bugs.webkit.org/show_bug.cgi?id=31164
1685
1686         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
1687
1688         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1689         (LayoutTestController::processWork):
1690
1691 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
1692
1693         Reviewed by Holger Freyther.
1694
1695         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
1696         https://bugs.webkit.org/show_bug.cgi?id=31158
1697
1698         By invoking a script queue'd by queueScript(), 'true' was beeing returned
1699         always, which from WorkQueue prospective means that a load has been started
1700         and the queue processing should stop and wait for the load to finish.
1701         Spinning it off into a loading and a non-loading variants was the solution
1702         adopted by Mac's DRT to work around this problem. The former keeps returning
1703         'true' while the later executes the script synchronously and returns 'false'
1704         making it possible to the WorkQueue to proceed right away.
1705
1706         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1707         (LayoutTestController::processWork):
1708         (LayoutTestController::queueLoadingScript):
1709         (LayoutTestController::queueNonLoadingScript):
1710         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1711         * DumpRenderTree/qt/WorkQueueItem.h:
1712         (LoadingScriptItem::LoadingScriptItem):
1713         (LoadingScriptItem::invoke):
1714         (NonLoadingScriptItem::NonLoadingScriptItem):
1715         (NonLoadingScriptItem::invoke):
1716
1717 2009-11-07  Mark Rowe  <mrowe@apple.com>
1718
1719         Rubber-stamped by Cameron Zwarich.
1720
1721         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
1722
1723         * Scripts/commit-log-editor:
1724
1725 2009-11-07  Mark Rowe  <mrowe@apple.com>
1726
1727         Reviewed by Darin Adler.
1728
1729         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
1730         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
1731
1732         Move logic for determining the name and email address to use in a ChangeLog entry from
1733         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
1734         whether the author of the patch matches committer, and therefore needs access to the
1735         email address that would be used in a ChangeLog entry.
1736
1737         Based on a patch by Pierre d'Herbemont.
1738
1739         * Scripts/VCSUtils.pm:
1740         * Scripts/commit-log-editor:
1741         * Scripts/prepare-ChangeLog:
1742         * Scripts/webkitdirs.pm:
1743
1744 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
1745
1746         Reviewed by Adam Barth.
1747
1748         Added functionality to the layout test plugin to invoke document.open and
1749         window.open with default arguments. The associated webkit bug is
1750         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
1751         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
1752         work in Chromium (V8) if there is no calling javascript context. To achieve this
1753         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
1754         for the window.open test case and in NPP_DestroyStream for the document.open test case.
1755
1756         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1757         (testDocumentOpen):
1758         (testWindowOpen):
1759         (pluginAllocate):
1760         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1761         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1762         (NPP_New):
1763         (NPP_SetWindow):
1764         (NPP_DestroyStream):
1765         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1766         (NPP_New):
1767         (NPP_SetWindow):
1768         (NPP_NewStream):
1769         (NPP_DestroyStream):
1770
1771 2009-11-06  Eric Seidel  <eric@webkit.org>
1772
1773         Reviewed by Adam Barth.
1774
1775         bugzilla-tool crashed with exception
1776         https://bugs.webkit.org/show_bug.cgi?id=31092
1777
1778         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
1779
1780 2009-11-04  Eric Seidel  <eric@webkit.org>
1781
1782         No review, just add a line which got left out of the patch uploaded for commit.
1783
1784         commit-queue is crashing when trying to reject patches after unknown failures
1785         https://bugs.webkit.org/show_bug.cgi?id=31091
1786
1787         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
1788
1789 2009-11-04  Adam Roben  <aroben@apple.com>
1790
1791         Remove bogus else clause in bugzilla-tool
1792
1793         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
1794         create-bug raises exception after entering bug description
1795
1796         Reviewed by David Kilzer.
1797
1798         * Scripts/bugzilla-tool:
1799         (CreateBug): else clauses are only hit if no exception is raised, so
1800         it makes no sense to try to re-raise the exception in an else clause.
1801         The exception will automatically be re-raised if it doesn't match any
1802         of the except clauses, so we don't have to do anything special here at
1803         all to get the desired behavior.
1804
1805 2009-11-04  Eric Seidel  <eric@webkit.org>
1806
1807         Reviewed by David Kilzer.
1808
1809         svn-apply's fixChangeLogPatch function seems broken
1810         https://bugs.webkit.org/show_bug.cgi?id=30683
1811
1812         Update fixChangeLogPatch to be able to handle patches which
1813         don't start at line 1.
1814         Add unit tests for svn-apply to scm_unittest.py.
1815
1816         * Scripts/VCSUtils.pm:
1817         * Scripts/modules/scm_unittest.py:
1818
1819 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
1820
1821         Reviewed by Beth Dakin.
1822
1823         Need to implement ARIA role="combobox"
1824         https://bugs.webkit.org/show_bug.cgi?id=31096
1825
1826         * DumpRenderTree/AccessibilityUIElement.cpp:
1827         (showMenuCallback):
1828         (getIsExpandedCallback):
1829         (AccessibilityUIElement::getJSClass):
1830         * DumpRenderTree/AccessibilityUIElement.h:
1831         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1832         (AccessibilityUIElement::isExpanded):
1833         (AccessibilityUIElement::showMenu):
1834         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1835         (AccessibilityUIElement::isExpanded):
1836         (AccessibilityUIElement::showMenu):
1837         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1838         (AccessibilityUIElement::isSelected):
1839         (AccessibilityUIElement::isExpanded):
1840         (AccessibilityUIElement::showMenu):
1841
1842 2009-11-04  Eric Seidel  <eric@webkit.org>
1843
1844         Reviewed by Adam Barth.
1845
1846         commit-queue is crashing when trying to reject patches after unknown failures
1847         https://bugs.webkit.org/show_bug.cgi?id=31091
1848
1849         * Scripts/bugzilla-tool:
1850          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
1851            so we have to find out what the current patch is by asking bugzilla again.
1852          - Discovered that this code was also leaking file descriptors, so fixed that.
1853
1854 2009-11-04  Adam Roben  <aroben@apple.com>
1855
1856         Make run-webkit-tests work for the Debug_Internal Windows
1857         configuration
1858
1859         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
1860         suffix.
1861
1862         Fixes <http://webkit.org/b/31123>.
1863
1864         Reviewed by Sam Weinig.
1865
1866         * Scripts/run-webkit-tests: Don't add the _debug suffix in
1867         Debug_Internal, either.
1868
1869 2009-11-04  Eric Seidel  <eric@webkit.org>
1870
1871         Reviewed by Adam Barth.
1872
1873         committers.py needs a way to store non-bugzilla email addresses
1874         https://bugs.webkit.org/show_bug.cgi?id=31037
1875
1876         Make Committer and Reviewer constructors take a single email or a list of emails.
1877         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
1878         Expose reviewers(), used by validate-committer-lists on bug 30970.
1879
1880         * Scripts/modules/committers.py:
1881         * Scripts/modules/committers_unittest.py: Added tests for the new code.
1882
1883 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
1884
1885         Reviewed by David Levin.
1886
1887         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
1888         https://bugs.webkit.org/show_bug.cgi?id=27491
1889
1890         The test path determination logic is changed to handle websocket and websocket/ssl cases.
1891         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
1892
1893         Functions to start or stop Web Socket servers are added.
1894
1895         * Scripts/run-webkit-tests:
1896
1897 2009-11-03  Eric Seidel  <eric@webkit.org>
1898
1899         No review, just changing wording of log message.
1900
1901         Change log string to say "failed" instead of "rejected"
1902         when a commit fails due to an out of date checkout.
1903         This makes grepping the commit-queue log for rejected patches easier.
1904
1905         * Scripts/bugzilla-tool:
1906
1907 2009-11-03  Eric Seidel  <eric@webkit.org>
1908
1909         No review, adding commonly known committers missing from the file.
1910
1911         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
1912
1913 2009-11-03  Eric Seidel  <eric@webkit.org>
1914
1915         No review, just sort-order cleanup.
1916
1917         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
1918
1919 2009-11-03  Stephen White  <senorblanco@chromium.org>
1920
1921         (Unreviewed).
1922
1923         Add myself to committers.py.
1924
1925         * Scripts/modules/committers.py:
1926
1927 2009-11-03  Robin Dunn  <robin@alldunn.com>
1928
1929         Reviewed by Kevin Ollviier.
1930
1931         Add packaging scripts for Debian-based Linux distros.
1932
1933         https://bugs.webkit.org/show_bug.cgi?id=31075
1934
1935         * wx/packaging/build-debian-installer.py: Added.
1936         * wx/packaging/debian: Added.
1937
1938 2009-11-03  Dan Bernstein  <mitz@apple.com>
1939
1940         Reviewed by Anders Carlsson and Beth Dakin.
1941
1942         https://bugs.webkit.org/show_bug.cgi?id=31070
1943
1944         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
1945         destroyed, it executes the value of the 'ondestroy' parameter as a
1946         script.
1947
1948         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1949         (pluginAllocate): Initialize onDestroy.
1950         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
1951         onDestroy.
1952         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1953         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
1954         specified.
1955         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
1956
1957 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1958
1959         Reviewed by Xan Lopez.
1960
1961         https://bugs.webkit.org/show_bug.cgi?id=31035
1962         [GTK] some accessibility tests hitting assertion in debug builds
1963
1964         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
1965
1966         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1967         (AccessibilityController::rootElement):
1968
1969 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
1970
1971         Reviewed by Beth Dakin.
1972
1973         Support ARIA "tab" roles
1974         https://bugs.webkit.org/show_bug.cgi?id=30842
1975
1976         * DumpRenderTree/AccessibilityUIElement.cpp:
1977         * DumpRenderTree/AccessibilityUIElement.h:
1978         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1979         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1980         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1981
1982 2009-11-01  Eric Seidel  <eric@webkit.org>
1983
1984         Reviewed by David Levin.
1985
1986         buildbots should use --exit-after-N-failures
1987         https://bugs.webkit.org/show_bug.cgi?id=30809
1988
1989         Make the bots exit after 20 failures to prevent never-ending
1990         test runs where every test spends a minute crashing.
1991
1992         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1993
1994 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1995
1996         Reviewed by Eric Seidel.
1997
1998         Turn on warnings for QtWebKit for gcc
1999         https://bugs.webkit.org/show_bug.cgi?id=30958
2000
2001         * DumpRenderTree/qt/main.cpp:
2002         (crashHandler): Mark function NO_RETURN
2003
2004 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
2005
2006         Adding myself to the committers list.
2007
2008         * Scripts/modules/committers.py:
2009
2010 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
2011
2012         Fix an issue that Adam noticed in DRT.
2013
2014         Reviewed by Darin Adler.
2015
2016         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2017         (AccessibilityUIElement::role):
2018         Get the length of the role text, and create a buffer dynamically.
2019
2020 2009-10-30  Eric Seidel  <eric@webkit.org>
2021
2022         No review, rolling out r50105.
2023         http://trac.webkit.org/changeset/50105
2024
2025         This commit was causing:
2026         https://bugs.webkit.org/show_bug.cgi?id=30869
2027         We'll re-implement the feature a different way.
2028
2029         * Scripts/bugzilla-tool:
2030
2031 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2032
2033         Test for MSAA: Accessibility of headings is not correct
2034
2035         https://bugs.webkit.org/show_bug.cgi?id=30937
2036
2037         Reviewed by Adam Roben.
2038
2039         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2040         (AccessibilityUIElement::role):
2041         Allow the role returned to be a BSTR.
2042         (AccessibilityUIElement::description):
2043         Fix a copy/paste error.
2044
2045 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2046
2047         Test for MSAA: Accessibility of links is wrong
2048
2049         https://bugs.webkit.org/show_bug.cgi?id=30928
2050
2051         Reviewed by Darin Adler.
2052
2053         * DumpRenderTree/AccessibilityUIElement.cpp:
2054         (getAccessibilityValueCallback):
2055         Return the accessibility value.
2056         (AccessibilityUIElement::getJSClass):
2057         Added "accessibilityValue" value.
2058
2059         * DumpRenderTree/AccessibilityUIElement.h:
2060
2061         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2062         (AccessibilityUIElement::accessibilityValue):
2063         Stubbed.
2064
2065         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2066         (AccessibilityUIElement::accessibilityValue):
2067         Stubbed.
2068
2069         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2070         (AccessibilityUIElement::accessibilityValue):
2071         Get the object's value, and return it as a JS string.
2072
2073 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
2074
2075         Fix typo in command name used by wx build system.
2076
2077         * wx/build/build_utils.py:
2078
2079 2009-10-30  Adam Barth  <abarth@webkit.org>
2080
2081         Reviewed by Darin Adler.
2082
2083         Patch v1 is a dumb default name for patches
2084         https://bugs.webkit.org/show_bug.cgi?id=30952
2085
2086         Let's use "Patch" instead.
2087
2088         * Scripts/bugzilla-tool:
2089
2090 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2091
2092         Unreviewed trivial buildfix.
2093
2094         [Qt] Buildfix for r50333.
2095
2096         * DumpRenderTree/qt/DumpRenderTree.pro:
2097
2098 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
2099
2100         Reviewed by Holger Freyther.
2101
2102         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
2103         https://bugs.webkit.org/show_bug.cgi?id=30953
2104
2105         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
2106         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
2107         makes qt DRT to share this implementation (as gtk and mac ports do).
2108
2109         * DumpRenderTree/qt/DumpRenderTree.pro:
2110         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
2111         * DumpRenderTree/qt/WorkQueue.h: Removed.
2112
2113 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2114
2115         Unreviewed potential buildbot fix.
2116
2117         Second try: Reset page history before running each test.
2118
2119         Apparently the QWebHistory::clear() keeps the current page
2120         in history which is not what we want, so we not additionally
2121         sets the history capacity to 0 (forces removing everything)
2122         and then sets it back to its original value.
2123
2124         * DumpRenderTree/qt/DumpRenderTree.cpp:
2125         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2126
2127 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2128
2129         Unreviewed potential buildbot fix.
2130
2131         Reset page history before running each test.
2132
2133         * DumpRenderTree/qt/DumpRenderTree.cpp:
2134         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2135
2136 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
2137
2138         Reviewed by Eric Seidel.
2139
2140         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
2141
2142         Bug 28420 -  Implement HTML5 <ruby> rendering
2143         (https://bugs.webkit.org/show_bug.cgi?id=28420)
2144
2145         No new tests (no functional change).
2146
2147         * Scripts/build-webkit:
2148
2149 2009-10-29  Dan Bernstein  <mitz@apple.com>
2150
2151         Reviewed by Mark Rowe.
2152
2153         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
2154         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
2155         define it.
2156
2157         * Scripts/VCSUtils.pm:
2158         * Scripts/svn-apply:
2159         * Scripts/svn-unapply:
2160
2161 2009-10-29  Xan Lopez  <xlopez@igalia.com>
2162
2163         Reviewed by Gustavo Noronha.
2164
2165         Use the GTK+ main loop instead of rolling our own mini-version of
2166         it.
2167
2168         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2169         (dump):
2170         (runTest):
2171         (webViewLoadFinished):
2172
2173 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2174
2175         Reviewed by Oliver Hunt.
2176
2177         Implement the Qt version of DRT dumpBackForwardList().
2178
2179         * DumpRenderTree/qt/DumpRenderTree.cpp:
2180         (WebCore::dumpHistoryItem):
2181         (WebCore::DumpRenderTree::dumpBackForwardList):
2182
2183 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2184
2185         Reviewed by Adam Roben.
2186
2187         Implement DRT functionality for Qt introduced in
2188         r28690 and r28705.
2189
2190         - Implemented pathToLocalResource which exposes the functionality of
2191         converting a given unix path to the correct location on Windows.
2192         - Implemented a way to remove machine-dependent information from paths
2193         in layout test results.
2194
2195         * DumpRenderTree/qt/DumpRenderTree.cpp:
2196         (WebCore::urlSuitableForTestResult):
2197         (WebCore::WebPage::javaScriptConsoleMessage):
2198         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2199         (LayoutTestController::pathToLocalResource):
2200         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2201
2202 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
2203
2204         Adding myself to the committers list.
2205
2206         * Scripts/modules/committers.py:
2207
2208 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
2209
2210         Adding myself to the committers list.
2211
2212         * Scripts/modules/committers.py:
2213
2214 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2215
2216         Reviewed by Jan Alonzo.
2217
2218         [GTK] API to start inspector for a WebView
2219         https://bugs.webkit.org/show_bug.cgi?id=22551
2220
2221         Use the new inspector API to implement the LayoutTestController
2222         interfaces used to test the inspector.
2223
2224         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2225         (webInspectorInspectWebView):
2226         (createWebView):
2227         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2228         (LayoutTestController::showWebInspector):
2229         (LayoutTestController::closeWebInspector):
2230         (LayoutTestController::evaluateInWebInspector):
2231
2232 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
2233
2234         Reviewed by Eric Seidel.
2235
2236         [Qt] WebFrame::counterValueForElementById must not be exposed
2237         https://bugs.webkit.org/show_bug.cgi?id=30882
2238
2239         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2240         (LayoutTestController::counterValueForElementById):
2241
2242 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2243
2244         Rubberstamped by Oliver Hunt.
2245
2246         Fix the warning:
2247
2248         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
2249         declared with attribute warn_unused_result".
2250
2251         by actually checking the result. In the case it is null, an
2252         error has occoured, so treat it as the other fatal errors.
2253
2254         * DumpRenderTree/qt/DumpRenderTree.cpp:
2255         (WebCore::DumpRenderTree::initializeFonts):
2256
2257 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
2258
2259         Reviewed by Darin Adler.
2260
2261         Provide a way to get counter values with layoutTestContoller
2262         https://bugs.webkit.org/show_bug.cgi?id=30555
2263
2264         Define layoutTestContoller.counterValueForElementById.
2265
2266         * DumpRenderTree/LayoutTestController.cpp:
2267         (counterValueForElementByIdCallback):
2268         (LayoutTestController::staticFunctions):
2269         * DumpRenderTree/LayoutTestController.h:
2270         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2271         (LayoutTestController::counterValueForElementById):
2272
2273 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2274
2275         Rubberstamped by Oliver Hunt.
2276
2277         Change two methods to be internal for DRT use only.
2278
2279         Part of [Qt] Review all new API in Qt 4.6
2280         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
2281
2282         * DumpRenderTree/qt/DumpRenderTree.cpp:
2283         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2284         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2285         (LayoutTestController::whiteListAccessFromOrigin):
2286
2287 2009-10-27  Eric Seidel  <eric@webkit.org>
2288
2289         Reviewed by Adam Barth.
2290
2291         REGRESSION: svn-apply exits(1) when applying a patch with a file add
2292         https://bugs.webkit.org/show_bug.cgi?id=30826
2293
2294         * Scripts/svn-apply:
2295          - Add () around all system() calls.
2296          - Use the correct system() == 0 or die instead of system() or die
2297          - Add descriptive messages to all die statements.
2298
2299 2009-10-27  Steve Block  <steveblock@google.com>
2300
2301         Reviewed by NOBODY.
2302
2303         Adds steveblock@google.com to list of committers.
2304
2305         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
2306
2307 2009-10-27  Eric Seidel  <eric@webkit.org>
2308
2309         Reviewed by Adam Barth.
2310
2311         svn-apply can exit(0) even on patch failure
2312         https://bugs.webkit.org/show_bug.cgi?id=29622
2313
2314         * Scripts/svn-apply:
2315          - Add a bunch of "or die" statements, hopefully catching all
2316            possible cases where failure could still exit(0).
2317
2318 2009-10-27  Eric Seidel  <eric@webkit.org>
2319
2320         Reviewed by Adam Barth.
2321
2322         svn-* scripts should share code through VCSUtils.pm
2323         https://bugs.webkit.org/show_bug.cgi?id=30791
2324
2325         Just moving code into a shared location.
2326
2327         * Scripts/VCSUtils.pm:
2328         * Scripts/prepare-ChangeLog:
2329         * Scripts/resolve-ChangeLogs:
2330         * Scripts/svn-apply:
2331         * Scripts/svn-create-patch:
2332         * Scripts/svn-unapply:
2333         * Scripts/update-webkit:
2334
2335 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
2336
2337         Suppress a huge number of MSVC warnings when building wxWebKit.
2338
2339         * wx/build/settings.py:
2340
2341 2009-10-26  Eric Seidel  <eric@webkit.org>
2342
2343         No review, just adding Mike Belshe to the committers list.
2344
2345         * Scripts/modules/committers.py:
2346
2347 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2348
2349         Reviewed by Darin Adler.
2350
2351         Make .rc files compile on Windows without depending on MFC headers
2352         https://bugs.webkit.org/show_bug.cgi?id=30750
2353
2354         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
2355         windows.h instead of afxres.h because it exists even when MFC is not
2356         installed, and is all that's needed here.
2357
2358         * FindSafari/FindSafari.rc: Ditto
2359
2360 2009-10-24  Eric Seidel  <eric@webkit.org>
2361
2362         Reviewed by Adam Barth.
2363
2364         bugzilla-tool post-diff should know how to mark commit-queue=?
2365         https://bugs.webkit.org/show_bug.cgi?id=29202
2366
2367         * Scripts/bugzilla-tool:
2368          - Add --commit-queue option to post-diff, post-commits and create-bug.
2369         * Scripts/modules/bugzilla.py:
2370          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
2371          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
2372
2373 2009-10-23  Eric Seidel  <eric@webkit.org>
2374
2375         Reviewed by Adam Barth.
2376
2377         bugzilla-tool commit-queue does not notice modifications to committers.py
2378         https://bugs.webkit.org/show_bug.cgi?id=30084
2379
2380         * Scripts/bugzilla-tool:
2381          - Make commit-queue re-exec itself instead of using while(1).
2382          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
2383          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
2384
2385 2009-10-22  Eric Seidel  <eric@webkit.org>
2386
2387         Reviewed by Adam Barth.
2388
2389         commit-queue will get stuck on patches if land-patches terminates unexpectedly
2390         https://bugs.webkit.org/show_bug.cgi?id=30634
2391
2392         * Scripts/bugzilla-tool:
2393          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
2394          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
2395
2396 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
2397
2398         Reviewed by Eric Seidel.
2399
2400         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
2401
2402         https://bugs.webkit.org/show_bug.cgi?id=30763
2403
2404         * pywebsocket/mod_pywebsocket/__init__.py:
2405         * pywebsocket/mod_pywebsocket/dispatch.py:
2406         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
2407         * pywebsocket/mod_pywebsocket/standalone.py:
2408         * pywebsocket/setup.py:
2409         * pywebsocket/test/test_dispatch.py:
2410
2411 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
2412
2413         Reviewed by David Levin.
2414
2415         REGRESSION: 2 failures in run-webkit-unittests
2416         https://bugs.webkit.org/show_bug.cgi?id=30645
2417
2418         * Scripts/modules/cpp_style_unittest.py:
2419         Fixed a few test scenarios which apparently lost some spaces from
2420         text literals.
2421
2422 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
2423
2424         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
2425
2426         * Scripts/webkitdirs.pm:
2427
2428 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
2429
2430         Reviewed by Darin Adler.
2431
2432         Unification of using null device in perl scripts.
2433         https://bugs.webkit.org/show_bug.cgi?id=30572
2434
2435         * Scripts/VCSUtils.pm:
2436         * Scripts/bisect-builds:
2437         * Scripts/resolve-ChangeLogs:
2438         * Scripts/run-iexploder-tests:
2439         * Scripts/run-jsc:
2440         * Scripts/run-mangleme-tests:
2441         * Scripts/run-webkit-tests:
2442         * Scripts/webkitdirs.pm:
2443         Using File::Spec->devnull() instead of hard coded /dev/null.
2444
2445 2009-10-26  Eric Seidel  <eric@webkit.org>
2446
2447         Reviewed by Holger Freyther.
2448
2449         Reviewers are missing from committers.py
2450         https://bugs.webkit.org/show_bug.cgi?id=30733
2451
2452         * Scripts/modules/committers.py:
2453
2454 2009-10-23  Eric Seidel  <eric@webkit.org>
2455
2456         No review, only adding Alice to the list of reviewers.
2457
2458         * Scripts/modules/committers.py:
2459
2460 2009-10-23  Eric Seidel  <eric@webkit.org>
2461
2462         Reviewed by Eric Carlson.
2463
2464         fast/media/mq-transform-02.html failed on Leopard Commit Bot
2465         https://bugs.webkit.org/show_bug.cgi?id=30700
2466
2467         * DumpRenderTree/mac/DumpRenderTree.mm:
2468         (resetDefaultsToConsistentValues): Update QuickTime version check.
2469
2470 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
2471
2472         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get
2473         character measurement APIs that are private on Tiger.
2474
2475         * wx/build/settings.py:
2476
2477 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2478
2479         Reviewed by NOBODY (build fix).
2480         Build fix following bug #30696.
2481
2482         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2483         (LayoutTestController::evaluateScriptInIsolatedWorld):
2484
2485 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2486
2487         Reviewed by Sam Weinig & Geoff Garen.
2488
2489         https://bugs.webkit.org/show_bug.cgi?id=30696
2490         Enable isolated-worlds tests on mac.
2491
2492         Add private interface for DRT to invoke execution in a given world.
2493
2494         * DumpRenderTree/LayoutTestController.cpp:
2495         (evaluateScriptInIsolatedWorldCallback):
2496         (LayoutTestController::staticFunctions):
2497         * DumpRenderTree/LayoutTestController.h:
2498         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2499         (LayoutTestController::evaluateScriptInIsolatedWorld):
2500         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2501         (LayoutTestController::evaluateScriptInIsolatedWorld):
2502
2503 2009-10-21  Eric Seidel  <eric@webkit.org>
2504
2505         Reviewed by Adam Barth.
2506
2507         bugzilla-tool's "patch failed to download an apply" error should give more information
2508         https://bugs.webkit.org/show_bug.cgi?id=30632
2509
2510         * Scripts/modules/scm.py:
2511          - Use the common run_command method instead of custom POpen code.
2512          - Make run_command know how to take pipes as input.
2513         * Scripts/modules/scm_unittest.py:
2514          - Add new tests to cover change.
2515          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
2516
2517 2009-10-21  Kent Tamura  <tkent@chromium.org>
2518
2519         Unreviewed.  Adding myself to the committers list.
2520
2521         * Scripts/modules/committers.py:
2522
2523 2009-10-21  Robin Dunn  <robin@alldunn.com>
2524
2525         Reviewed by Kevin Ollivier.
2526
2527         Update the Windows installer builder to work with Vista / Win 7 and with git.
2528
2529         https://bugs.webkit.org/show_bug.cgi?id=30649
2530
2531         * wx/build/build_utils.py:
2532         * wx/packaging/build-mac-installer.py:
2533         * wx/packaging/build-win-installer.py:
2534         * wx/packaging/wxWebKitInstaller.iss.in:
2535
2536 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2537
2538         Reviewed by Gustavo Noronha.
2539
2540         [GTK] Added conditional code to avoid using
2541         gdk_window_get_root_coords if we do not have a gtk+ release newer
2542         than 2.17.3.
2543         https://bugs.webkit.org/show_bug.cgi?id=30636
2544
2545         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2546
2547 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
2548
2549         Reviewed by Eric Seidel.
2550
2551         [Qt] Added dummy implementation for keepWebHistory()
2552         https://bugs.webkit.org/show_bug.cgi?id=30592
2553
2554         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2555         (LayoutTestController::keepWebHistory):
2556         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2557
2558 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2559
2560         Reviewed by Xan Lopez.
2561
2562         [GTK] Fixed the double click condition, it is not double click if
2563         we move in just in one direction.
2564         https://bugs.webkit.org/show_bug.cgi?id=30636
2565
2566         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2567
2568 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2569
2570         Reviewed by Xan Lopez.
2571
2572         [GTK] Initialize the events completly before emitting them.
2573         https://bugs.webkit.org/show_bug.cgi?id=30633
2574
2575         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2576
2577 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2578
2579         wx build fix. Fix for when linking using --as-needed with gcc.
2580
2581         * wx/browser/wscript:
2582
2583 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2584
2585         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
2586         to support all the features used by CURL backend.
2587
2588         * wx/build/settings.py:
2589         * wx/install-unix-extras:
2590
2591 2009-10-20  Anton Muhin  <antonm@chromium.org>
2592
2593         Reviewed by Adam Barth.
2594
2595         Add {ager,antonm,yurys}@chromium.org into committers.py
2596         https://bugs.webkit.org/show_bug.cgi?id=30560
2597
2598         * Scripts/modules/committers.py:
2599
2600 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2601
2602         Reviewed by Tor Arne Vestbø.
2603
2604         Make the Netscape Test plugin available to the Qt launcher.
2605
2606         * Scripts/run-launcher:
2607
2608 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
2609
2610         Reviewed by David Levin.
2611
2612         Removed WebSocket runtime settings.
2613         https://bugs.webkit.org/show_bug.cgi?id=29896
2614
2615         WebSocket runtime configuration is supported by chromium/v8 only.
2616
2617         * DumpRenderTree/mac/DumpRenderTree.mm:
2618         (resetDefaultsToConsistentValues):
2619         * DumpRenderTree/win/DumpRenderTree.cpp:
2620         (resetDefaultsToConsistentValues):
2621
2622 2009-10-19  Nate Chapin  <japhet@chromium.org>
2623
2624         Reviewed by Adam Barth.
2625
2626         Add testFail() to test plugin so we can test our handling of a
2627         plugin invoke call returning false.
2628
2629         https://bugs.webkit.org/show_bug.cgi?id=30239
2630
2631         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
2632         (pluginInvoke):
2633         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
2634
2635 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
2636
2637         Reviewed by Gustavo Noronha.
2638
2639         Enable DOM pasting when running layout tests.
2640
2641         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2642         (resetDefaultsToConsistentValues):
2643
2644 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2645
2646         Reviewed by Simon Hausmann.
2647
2648         Use the setPreferredContentsSize method instead
2649         of setFixedContentsSize, as the method has been renamed.
2650
2651         * DumpRenderTree/qt/DumpRenderTree.cpp:
2652         (WebCore::DumpRenderTree::open):
2653         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2654         (LayoutTestController::setFixedContentsSize):
2655
2656 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2657
2658         Reviewed by Dan Bernstein.
2659
2660         https://bugs.webkit.org/show_bug.cgi?id=30456
2661         Fixes for new Debug_All Windows build configuration.
2662
2663         * DumpRenderTree/win/DumpRenderTree.cpp:
2664         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
2665         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
2666
2667 2009-10-16  Eric Seidel  <eric@webkit.org>
2668
2669         Reviewed by Adam Barth.
2670
2671         commit-queue status bot should list which buildbot is blocking the queue
2672         https://bugs.webkit.org/show_bug.cgi?id=30452
2673
2674         Add new methods and testing.
2675
2676         * Scripts/bugzilla-tool:
2677         * Scripts/modules/buildbot.py:
2678         * Scripts/modules/buildbot_unittest.py:
2679
2680 2009-10-16  Eric Seidel  <eric@webkit.org>
2681
2682         Reviewed by Adam Barth.
2683
2684         run-webkit-tests fails when CWD is not inside a WebKit checkout
2685         https://bugs.webkit.org/show_bug.cgi?id=30451
2686
2687         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
2688         * Scripts/modules/scm_unittest.py:
2689           - Remove use of original_path (we don't need to restore the CWD).
2690           - Don't use '.' to find the webkit checkout, use __file__ instead.
2691
2692 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2693
2694         Reviewed by Adam Roben.
2695
2696         Add a Debug_All configuration to build entire stack as debug.
2697         Change Debug_Internal to:
2698         - stop using _debug suffix for all WebKit/Safari binaries
2699         - not use _debug as a DLL naming suffix
2700         - use non-debug C runtime lib.
2701
2702         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
2703         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
2704         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
2705         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2706         Add missing debug.vsprops inherited property sheet.
2707         Add Debug_All configuration.
2708         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
2709         * WinLauncher/WinLauncher.vcproj:
2710         Removed extraneous definitions inherited from vsprops.
2711         Add Debug_All configuration.
2712
2713 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
2714
2715         Reviewed by David Levin.
2716
2717         check-webkit-style is wrong about indent checking in namespaces
2718         in header files and a few other things
2719         https://bugs.webkit.org/show_bug.cgi?id=30362
2720
2721         The few other things include:
2722         + check-webkit-style does not require spaces around the equal sign
2723           inside 'if' statements and around binary operators that take
2724           numeric literals.
2725         + check-webkit-style reports false errors for the / operator
2726           when part of a filename in the #include directive.
2727
2728         * Scripts/modules/cpp_style.py:
2729         Improved indentation checking and space checking around
2730         binary operators. While the checks are still not perfect,
2731         they are clearly better than before.
2732         * Scripts/modules/cpp_style_unittest.py:
2733         Added test cases for the newly supported checks and modified old
2734         test cases to match the new guidelines
2735
2736 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
2737
2738         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
2739
2740         * wx/build/settings.py:
2741
2742 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
2743
2744         Reviewed by David Levin.
2745
2746         Add mod_pywebsocket to test Web Sockets.
2747         http://code.google.com/p/pywebsocket/
2748         https://bugs.webkit.org/show_bug.cgi?id=27490
2749
2750         * pywebsocket/COPYING: Added.
2751         * pywebsocket/MANIFEST.in: Added.
2752         * pywebsocket/README: Added.
2753         * pywebsocket/example/echo_client.py: Added.
2754         * pywebsocket/example/echo_wsh.py: Added.
2755         * pywebsocket/mod_pywebsocket/__init__.py: Added.
2756         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
2757         * pywebsocket/mod_pywebsocket/handshake.py: Added.
2758         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
2759         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
2760         * pywebsocket/mod_pywebsocket/standalone.py: Added.
2761         * pywebsocket/mod_pywebsocket/util.py: Added.
2762         * pywebsocket/setup.py: Added.
2763         * pywebsocket/test/config.py: Added.
2764         * pywebsocket/test/mock.py: Added.
2765         * pywebsocket/test/run_all.py: Added.
2766         * pywebsocket/test/test_dispatch.py: Added.
2767         * pywebsocket/test/test_handshake.py: Added.
2768         * pywebsocket/test/test_mock.py: Added.
2769         * pywebsocket/test/test_msgutil.py: Added.
2770         * pywebsocket/test/test_util.py: Added.
2771         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
2772         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
2773         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
2774         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
2775         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
2776         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
2777         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
2778         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
2779
2780 2009-10-15  James Robinson  <jamesr@google.com>
2781
2782         Reviewed by David Levin.
2783
2784         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
2785
2786         https://bugs.webkit.org/show_bug.cgi?id=30426
2787
2788         * Scripts/modules/cpp_style.py:
2789         * Scripts/modules/cpp_style_unittest.py:
2790
2791 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
2792
2793         Reviewed by Adam Roben.
2794
2795         Fixes <http://webkit.org/b/30411>.
2796         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
2797
2798         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
2799         building Chromium.
2800
2801         * Scripts/pdevenv:
2802
2803 2009-10-15  Robin Dunn  <robin@alldunn.com>
2804
2805         Reviewed by Kevin Ollivier.
2806
2807         Add Mac package building scripts for wx.
2808
2809         https://bugs.webkit.org/show_bug.cgi?id=30405
2810
2811         * wx/build/build_utils.py:
2812         * wx/build/settings.py:
2813         * wx/packaging/build-mac-installer.py: Added.
2814
2815 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
2816
2817         Reviewed by Gustavo Noronha.
2818
2819         Enable Web Sockets support when running layout tests.
2820
2821         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2822         (resetDefaultsToConsistentValues):
2823
2824 2009-10-15  Xan Lopez  <xlopez@igalia.com>
2825
2826         Reviewed by Gustavo Noronha.
2827
2828         Need to initialize event.button.button, since in most cases a
2829         button number is not passed as an argument.
2830
2831         * DumpRenderTree/gtk/EventSender.cpp:
2832         (mouseDownCallback):
2833         (mouseUpCallback):
2834
2835 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
2836
2837         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
2838         the OS if none was explicitly set.
2839
2840         * wx/build/settings.py:
2841
2842 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
2843
2844         Reviewed by Timothy Hatcher.
2845
2846         Web Inspector: enable developers extras within inspector layout tests.
2847
2848         https://bugs.webkit.org/show_bug.cgi?id=30014
2849
2850         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2851         (LayoutTestController::showWebInspector):
2852         (LayoutTestController::closeWebInspector):
2853         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2854         (LayoutTestController::showWebInspector):
2855         (LayoutTestController::closeWebInspector):
2856
2857 2009-10-14  José Millán Soto  <jmillan@igalia.com>
2858
2859         Reviewed by Jan Alonzo.
2860
2861         GtkLauncher is using a deprecated signal
2862         https://bugs.webkit.org/show_bug.cgi?id=30364
2863
2864         Modified GtkLauncher to use notify::title signal instead of
2865         deprecated title-changed signal
2866
2867         * GtkLauncher/main.c:
2868         (notify_title_cb):
2869         (create_browser):
2870
2871 2009-10-14  Brady Eidson  <beidson@apple.com>
2872
2873         Reviewed by Sam Weinig.
2874
2875         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
2876         1 - Disables WebHistory
2877         2 - Doesn't make sense in that context anyway.
2878
2879         * DumpRenderTree/win/DumpRenderTree.cpp:
2880         (createWebViewAndOffscreenWindow):
2881
2882 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
2883
2884         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
2885         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
2886
2887         * wx/build/settings.py:
2888         * wx/install-unix-extras:
2889
2890 2009-10-14  Brady Eidson  <beidson@apple.com>
2891
2892         Reviewed by Sam Weinig.
2893
2894         WebKit Win API should provide a delegate interface for global history.
2895         https://bugs.webkit.org/show_bug.cgi?id=29905
2896
2897         * DumpRenderTree/LayoutTestController.cpp:
2898         (LayoutTestController::LayoutTestController):
2899         * DumpRenderTree/LayoutTestController.h:
2900         (LayoutTestController::dumpHistoryDelegateCallbacks):
2901         (LayoutTestController::setDumpHistoryDelegateCallbacks):
2902
2903         * DumpRenderTree/win/DumpRenderTree.cpp:
2904         (shouldLogHistoryDelegates):
2905         (runTest):
2906         (createWebViewAndOffscreenWindow):
2907         (main):
2908         * DumpRenderTree/win/DumpRenderTree.vcproj:
2909
2910         Add the IWebHistoryDelegate to DRT Windows:
2911         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
2912         (wstringFromBSTR):
2913         (HistoryDelegate::HistoryDelegate):
2914         (HistoryDelegate::~HistoryDelegate):
2915         (HistoryDelegate::QueryInterface):
2916         (HistoryDelegate::AddRef):
2917         (HistoryDelegate::Release):
2918         (HistoryDelegate::didNavigateWithNavigationData):
2919         (HistoryDelegate::didPerformClientRedirectFromURL):
2920         (HistoryDelegate::didPerformServerRedirectFromURL):
2921         (HistoryDelegate::updateHistoryTitle):
2922         (HistoryDelegate::populateVisitedLinksForWebView):
2923         * DumpRenderTree/win/HistoryDelegate.h: Added.
2924
2925         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2926         (LayoutTestController::removeAllVisitedLinks):
2927
2928 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
2929
2930         Reviewed by Simon Hausmann.
2931
2932         [Qt] Implement support for setPOSIXLocale on Qt.
2933         https://bugs.webkit.org/show_bug.cgi?id=30268
2934
2935         * DumpRenderTree/qt/DumpRenderTree.cpp:
2936         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2937         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2938         (LayoutTestController::setPOSIXLocale):
2939         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2940
2941 2009-10-13  Stephanie Lewis  <slewis@apple.com>
2942
2943         Unreviewed, adding myself to reviewers list.
2944
2945         * Scripts/modules/committers.py:
2946
2947 2009-10-13  Stephanie Lewis  <slewis@apple.com>
2948
2949         Reviewed by Mark Rowe.
2950
2951         Fix null assignment so root tests work again.
2952
2953         * Scripts/webkitdirs.pm:
2954
2955 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2956
2957         Reviewed by Simon Hausmann.
2958
2959         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
2960         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
2961         This is done in preparation of implementing missing features in DRT.
2962         No functionality changes made yet.
2963
2964         * DumpRenderTree/qt/DumpRenderTree.cpp:
2965         * DumpRenderTree/qt/DumpRenderTree.pro:
2966         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
2967         (EventSender::EventSender):
2968         (EventSender::mouseDown):
2969         (EventSender::mouseUp):
2970         (EventSender::mouseMoveTo):
2971         (EventSender::leapForward):
2972         (EventSender::keyDown):
2973         (EventSender::contextClick):
2974         (EventSender::scheduleAsynchronousClick):
2975         (EventSender::frameUnderMouse):
2976         * DumpRenderTree/qt/EventSenderQt.h: Added.
2977         (EventSender::clearKillRing):
2978         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
2979         (LayoutTestController::LayoutTestController):
2980         (LayoutTestController::reset):
2981         (LayoutTestController::processWork):
2982         (LayoutTestController::maybeDump):
2983         (LayoutTestController::waitUntilDone):
2984         (LayoutTestController::notifyDone):
2985         (LayoutTestController::windowCount):
2986         (LayoutTestController::clearBackForwardList):
2987         (LayoutTestController::dumpEditingCallbacks):
2988         (LayoutTestController::dumpResourceLoadCallbacks):
2989         (LayoutTestController::queueBackNavigation):
2990         (LayoutTestController::queueForwardNavigation):
2991         (LayoutTestController::queueLoad):
2992         (LayoutTestController::queueReload):
2993         (LayoutTestController::queueScript):
2994         (LayoutTestController::provisionalLoad):
2995         (LayoutTestController::timerEvent):
2996         (LayoutTestController::encodeHostName):
2997         (LayoutTestController::decodeHostName):
2998         (LayoutTestController::setJavaScriptProfilingEnabled):
2999         (LayoutTestController::setFixedContentsSize):
3000         (LayoutTestController::setPrivateBrowsingEnabled):
3001         (LayoutTestController::setPopupBlockingEnabled):
3002         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3003         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3004         (LayoutTestController::numberOfActiveAnimations):
3005         (LayoutTestController::disableImageLoading):
3006         (LayoutTestController::dispatchPendingLoadRequests):
3007         (LayoutTestController::setDatabaseQuota):
3008         (LayoutTestController::clearAllDatabases):
3009         (LayoutTestController::whiteListAccessFromOrigin):
3010         (LayoutTestController::waitForPolicyDelegate):
3011         (LayoutTestController::overridePreference):
3012         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
3013         (LayoutTestController::isLoading):
3014         (LayoutTestController::setLoading):
3015         (LayoutTestController::shouldDumpAsText):
3016         (LayoutTestController::shouldDumpBackForwardList):
3017         (LayoutTestController::shouldDumpChildrenAsText):
3018         (LayoutTestController::shouldDumpDatabaseCallbacks):
3019         (LayoutTestController::shouldDumpStatusCallbacks):
3020         (LayoutTestController::shouldWaitUntilDone):
3021         (LayoutTestController::canOpenWindows):
3022         (LayoutTestController::shouldDumpTitleChanges):
3023         (LayoutTestController::waitForPolicy):
3024         (LayoutTestController::dumpAsText):
3025         (LayoutTestController::dumpChildFramesAsText):
3026         (LayoutTestController::dumpDatabaseCallbacks):
3027         (LayoutTestController::dumpStatusCallbacks):
3028         (LayoutTestController::setCanOpenWindows):
3029         (LayoutTestController::dumpBackForwardList):
3030         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3031         (LayoutTestController::display):
3032         (LayoutTestController::dumpTitleChanges):
3033         (LayoutTestController::dumpSelectionRect):
3034         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
3035         (TextInputController::TextInputController):
3036         (TextInputController::doCommand):
3037         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
3038         * DumpRenderTree/qt/WorkQueue.cpp:
3039         * DumpRenderTree/qt/WorkQueue.h:
3040         * DumpRenderTree/qt/WorkQueueItem.h:
3041         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
3042         (findFrameNamed):
3043         (LoadItem::invoke):
3044         (ReloadItem::invoke):
3045         (ScriptItem::invoke):
3046         (BackForwardItem::invoke):
3047         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
3048         * DumpRenderTree/qt/jsobjects.h:
3049
3050 2009-10-13  Dmitry Titov  <dimich@chromium.org>
3051
3052         Not reviewed, adding myself to the list of reviewers.
3053
3054         * Scripts/modules/committers.py:
3055
3056 2009-10-13  Anders Carlsson  <andersca@apple.com>
3057
3058         Reviewed by Sam Weinig.
3059
3060         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
3061
3062         Make the private browsing mode testable by the test plug-in.
3063
3064         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3065         (pluginGetProperty):
3066         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3067         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3068         (NPP_New):
3069         (NPP_SetValue):
3070
3071 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
3072
3073         No review, just adding self to the list of reviewers.
3074
3075         * Scripts/modules/committers.py:
3076
3077 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
3078
3079         Reviewed by Adam Roben.
3080
3081         Web Inspector: Use proper web view in inspector layout
3082         tests for windows.
3083
3084         https://bugs.webkit.org/show_bug.cgi?id=30298
3085
3086         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3087         (LayoutTestController::showWebInspector):
3088         (LayoutTestController::closeWebInspector):
3089         (LayoutTestController::evaluateInWebInspector):
3090
3091 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
3092
3093         Reviewed by Sam Weinig.
3094
3095         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
3096         https://bugs.webkit.org/show_bug.cgi?id=29841
3097
3098         * DumpRenderTree/mac/DumpRenderTree.mm:
3099         (resetDefaultsToConsistentValues):
3100         * DumpRenderTree/win/DumpRenderTree.cpp:
3101         (resetDefaultsToConsistentValues):
3102
3103 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
3104
3105         Reviewed by Dimitri Glazkov.
3106
3107         Chromium Port - Windows
3108         https://bugs.webkit.org/show_bug.cgi?id=29969
3109
3110         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
3111         * Scripts/webkitdirs.pm:
3112
3113 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
3114
3115         Reviewed by Darin Adler.
3116
3117         jsc scripts cleanup and Qt/GTK fix
3118         https://bugs.webkit.org/show_bug.cgi?id=30288
3119
3120         Duplicated jscPath() moved to webkitdirs.pm.
3121         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
3122         Configuration added (release/debug) to path for Qt-port on Windows.
3123
3124         * Scripts/run-javascriptcore-tests:
3125         * Scripts/run-jsc:
3126         * Scripts/run-sunspider:
3127         * Scripts/sunspider-compare-results:
3128         * Scripts/webkitdirs.pm:
3129
3130 2009-10-11  Adam Barth  <abarth@webkit.org>
3131
3132         Unreviewed.  Add Collin to committers.py.
3133
3134         * Scripts/modules/committers.py:
3135
3136 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
3137
3138         wx build fix, add bindings to source/include dirs now that there are sources there.
3139
3140         * wx/build/settings.py:
3141
3142 2009-10-09  Mark Rowe  <mrowe@apple.com>
3143
3144         Reviewed by Brady Eidson.
3145
3146         Enable plug-in halting in DumpRenderTree.
3147
3148         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
3149         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
3150
3151         * DumpRenderTree/mac/DumpRenderTree.mm:
3152         (resetDefaultsToConsistentValues):
3153         * DumpRenderTree/mac/UIDelegate.mm:
3154         (-[UIDelegate webView:shouldHaltPlugin:]):
3155
3156 2009-10-08  Brady Eidson  <beidson@apple.com>
3157
3158         Reviewed by Dan Bernstein.
3159
3160         Ask the History Delegate to populate the visited links hash.
3161         <rdar://problem/7285293> and https://webkit.org/b/29904
3162
3163         Add the ability for LayoutTestController to clear all visited links.
3164         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
3165
3166         * DumpRenderTree/LayoutTestController.cpp:
3167         (LayoutTestController::LayoutTestController):
3168         (removeAllVisitedLinksCallback):
3169         (LayoutTestController::staticFunctions):
3170         * DumpRenderTree/LayoutTestController.h:
3171         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3172         (LayoutTestController::removeAllVisitedLinks):
3173
3174         * DumpRenderTree/mac/HistoryDelegate.mm:
3175         (-[HistoryDelegate populateVisitedLinksForWebView:]):
3176
3177         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3178         (LayoutTestController::removeAllVisitedLinks):
3179         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3180         (LayoutTestController::removeAllVisitedLinks):
3181         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3182         (LayoutTestController::removeAllVisitedLinks):
3183
3184
3185 2009-10-08  Daniel Bates  <dbates@webkit.org>
3186
3187         Reviewed by Adam Roben.
3188
3189         https://bugs.webkit.org/show_bug.cgi?id=30175
3190
3191         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
3192         the OLE drag-and-drop return value like the function it emulates. Currently,
3193         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine
3194         whether the drag-and-drop operation was successful or was cancelled.
3195
3196         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop
3197         return value according to whether the drop operation was successful or not.
3198
3199         * DumpRenderTree/win/EventSender.cpp:
3200         (doMouseUp): Added parameter oleDragAndDropReturnValue.
3201         (replaySavedEvents): Ditto.
3202         * DumpRenderTree/win/EventSender.h:
3203         * DumpRenderTree/win/UIDelegate.cpp:
3204         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
3205
3206 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3207
3208         Reviewed by Xan Lopez.
3209
3210         [GTK] Added support for a parameter setting the button that was
3211         pressed in the mouseDown function.
3212         https://bugs.webkit.org/show_bug.cgi?id=30220
3213
3214         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3215
3216 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3217
3218         Reviewed by Xan Lopez.
3219
3220         [GTK] Added a line to the bottom of the expected result to match
3221         the output of the test.
3222         https://bugs.webkit.org/show_bug.cgi?id=30220
3223
3224         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
3225         expected.txt:
3226
3227 2009-10-08  Adam Roben  <aroben@apple.com>
3228
3229         Use QueryInterface to get IWebInspectorPrivate
3230
3231         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
3232         accessed in a more standard way
3233
3234         Reviewed by John Sullivan and Tim Hatcher.
3235
3236         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3237         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
3238         by calling IWebViewPrivate::inspector, then use QueryInterface to get
3239         to the IWebInspectorPrivate interface.
3240
3241 2009-10-07  Adam Roben  <aroben@apple.com>
3242
3243         Implement DRT support for origin whitelisting
3244
3245         Fixes <http://webkit.org/b/30185>.
3246
3247         Reviewed by Eric Seidel.
3248
3249         * DumpRenderTree/win/DumpRenderTree.cpp:
3250         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
3251         whitelist, to match Mac DRT.
3252         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3253         (LayoutTestController::whiteListAccessFromOrigin): Call through to
3254         IWebViewPrivate::whiteListAccessFromOrigin.
3255
3256 2009-10-07  Brady Eidson  <beidson@apple.com>
3257
3258         Reviewed by Darin Adler.
3259
3260         Send title changes to the global history delegate.
3261         <rdar://problem/7285293> and https://webkit.org/b/29904
3262
3263         * DumpRenderTree/mac/HistoryDelegate.mm:
3264         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
3265
3266 2009-10-07  Adam Barth  <abarth@webkit.org>
3267
3268         Unreviewed.  Remove some folks from committers.py who were listed on
3269         the WebKit Team wiki page but who weren't actually listed as commit+.
3270         At some point, we should coorelate this list with the committers
3271         mailing list.
3272
3273         * Scripts/modules/committers.py:
3274
3275 2009-10-07  Adam Barth  <abarth@webkit.org>
3276
3277         Unreviewed.  Import a bunch of committers from the WebKit Team page on
3278         the wiki into committers.py.
3279
3280         * Scripts/modules/committers.py:
3281
3282 2009-10-07  Adam Barth  <abarth@webkit.org>
3283
3284         Unreviewed.  Added Aaron Boodman to committers.py.
3285
3286         * Scripts/modules/committers.py:
3287
3288 2009-10-07  Evan Martin  <evan@chromium.org>
3289
3290         Reviewed by Darin Adler.
3291
3292         Add API to LayoutTestController for re/setting the system locale.
3293         https://bugs.webkit.org/show_bug.cgi?id=18994
3294
3295         * DumpRenderTree/LayoutTestController.cpp:
3296         (setLocaleCallback):
3297         (LayoutTestController::staticFunctions):
3298         (LayoutTestController::setLocale):
3299         * DumpRenderTree/LayoutTestController.h:
3300
3301 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
3302
3303         Reviewed by Jan Alonzo.
3304
3305         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3306         https://bugs.webkit.org/show_bug.cgi?id=29689
3307
3308         Build fix by adding -lfontconfig for DumpRenderTree.
3309
3310         * GNUmakefile.am:
3311
3312 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3313
3314         Reviewed by Simon Hausmann.
3315
3316         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
3317
3318         * Scripts/run-webkit-tests:
3319
3320 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3321
3322         Reviewed by Gustavo Noronha.
3323
3324         "delete" in EventSender is the backspace key, not the delete one.
3325
3326         * DumpRenderTree/gtk/EventSender.cpp:
3327         (keyDownCallback):
3328
3329 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3330
3331         Reviewed by Gustavo Noronha.
3332
3333         getChildrenWithRange expects as last parameter the end index, not
3334         the length of the range. Correct this and clarify the variable
3335         names to reflect how the code works.
3336
3337         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3338         (AccessibilityUIElement::getChildrenWithRange):
3339         (AccessibilityUIElement::getChildAtIndex):
3340
3341 2009-10-06  Mark Rowe  <mrowe@apple.com>
3342
3343         Reviewed by Simon Fraser.
3344
3345         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
3346
3347         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
3348         the fact we have already changed the working directory to the top of the open source tree.
3349
3350 2009-10-06  Julie Parent  <jparent@chromium.org>
3351
3352         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
3353         rather than my committer email.
3354
3355         * Scripts/modules/committers.py:
3356
3357 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3358
3359         Reviewed by Eric Seidel.
3360
3361         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
3362
3363         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
3364         it after each layout test as it should do, making the DRT dump additional output
3365         for all of the subsequent layout tests.
3366
3367         * DumpRenderTree/qt/jsobjects.cpp:
3368         (LayoutTestController::reset):
3369
3370 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3371
3372         Reviewed by Simon Hausmann.
3373
3374         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
3375         fast/dom/assign-to-window-status.html test, which is passing as a result.
3376
3377         https://bugs.webkit.org/show_bug.cgi?id=30127
3378
3379         * DumpRenderTree/qt/DumpRenderTree.cpp:
3380         (WebCore::DumpRenderTree::DumpRenderTree):
3381         (WebCore::DumpRenderTree::statusBarMessage):
3382         * DumpRenderTree/qt/DumpRenderTree.h:
3383         * DumpRenderTree/qt/jsobjects.h:
3384         (LayoutTestController::shouldDumpStatusCallbacks):
3385         (LayoutTestController::dumpStatusCallbacks):
3386
3387 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3388
3389         Reviewed by Simon Hausmann.
3390
3391         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
3392         ignores the argument indicating which mouse button to trigger.
3393         https://bugs.webkit.org/show_bug.cgi?id=30048
3394
3395         This affects the fast/events/mouse-click-events.html layout test.
3396
3397         * DumpRenderTree/qt/jsobjects.cpp:
3398         (EventSender::mouseDown):
3399         (EventSender::mouseUp):
3400         * DumpRenderTree/qt/jsobjects.h:
3401
3402 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3403
3404         Reviewed by Simon Hausmann.
3405
3406         [Qt] Fix the EventSender::keyDown() implementation
3407         https://bugs.webkit.org/show_bug.cgi?id=30043
3408
3409         It should post both a key press event and a key release event,
3410         just like other ports do.
3411
3412         * DumpRenderTree/qt/jsobjects.cpp:
3413         (EventSender::keyDown):
3414
3415 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
3416
3417         wx build fix. Add jpeg to the list of libs to link against.
3418
3419         * wx/build/settings.py:
3420
3421 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
3422
3423         Reviewed by Simon Hausmann.
3424
3425         [Qt] EventSender::keyDown() cannot send function-key events.
3426         https://bugs.webkit.org/show_bug.cgi?id=30044
3427
3428         This affects the fast/events/keydown-function-keys.html layout test.
3429
3430         * DumpRenderTree/qt/jsobjects.cpp:
3431         (EventSender::keyDown):
3432
3433 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
3434
3435         Added --wx-compiler-prefix waf option to allow building wxWebKit with
3436         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
3437
3438         * wx/build/settings.py:
3439         * wx/build/wxpresets.py:
3440
3441 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
3442
3443         Reviewed by Timothy Hatcher.
3444
3445         Web Inspector: add testing harness for Web Inspector.
3446
3447         https://bugs.webkit.org/show_bug.cgi?id=30010
3448
3449         * DumpRenderTree/LayoutTestController.cpp:
3450         (showWebInspectorCallback):
3451         (closeWebInspectorCallback):
3452         (evaluateInWebInspectorCallback):
3453         (LayoutTestController::staticFunctions):
3454         * DumpRenderTree/LayoutTestController.h:
3455         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3456         (LayoutTestController::showWebInspector):
3457         (LayoutTestController::closeWebInspector):
3458         (LayoutTestController::evaluateInWebInspector):
3459         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3460         (LayoutTestController::showWebInspector):
3461         (LayoutTestController::closeWebInspector):
3462         (LayoutTestController::evaluateInWebInspector):
3463         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3464         (LayoutTestController::showWebInspector):
3465         (LayoutTestController::closeWebInspector):
3466         (LayoutTestController::evaluateInWebInspector):
3467         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3468         (LayoutTestController::showWebInspector):
3469         (LayoutTestController::closeWebInspector):
3470         (LayoutTestController::evaluateInWebInspector):
3471
3472 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3473
3474         Reviewed by Ariyha Hidayat.
3475
3476         Pass arguments to system() as a string instead of array
3477
3478         When passed as an array entries with a space fail to translate
3479         to two arguments to the child process, so instead of manually
3480         splitting all the entries in @buildArgs we pass the whole thing
3481         as a string instead.
3482
3483         * Scripts/webkitdirs.pm:
3484
3485 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
3486
3487         Reviewed by David Levin.
3488
3489         check-webkit-style misses whitespace errors for operators:
3490         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
3491         https://bugs.webkit.org/show_bug.cgi?id=30021
3492
3493         * Scripts/modules/cpp_style.py:
3494         Added the operators mentioned above to the same list as == and !=.
3495
3496 2009-10-02  Julie Parent  <jparent@chromium.org>
3497
3498         Unreviewed.
3499
3500         Adding myself and Ojan Vafai as committers, because we are committers.
3501
3502         * Scripts/modules/committers.py:
3503
3504 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
3505
3506         Reviewed by Adam Roben.
3507
3508         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
3509         this will help the patch merging process when TryBots are used.
3510
3511         * Scripts/svn-create-patch:
3512
3513 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
3514
3515         Reviewed by Simon Hausmann.
3516
3517         [Qt] Implement layoutTestController.overridePreference().
3518         https://bugs.webkit.org/show_bug.cgi?id=29970
3519
3520         * DumpRenderTree/qt/DumpRenderTree.cpp:
3521         (WebCore::WebPage::WebPage):
3522         (WebCore::WebPage::resetSettings):
3523         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3524         * DumpRenderTree/qt/jsobjects.cpp:
3525         (LayoutTestController::reset):
3526         (LayoutTestController::setPrivateBrowsingEnabled):
3527         (LayoutTestController::setPopupBlockingEnabled):
3528         (LayoutTestController::overridePreference):
3529         * DumpRenderTree/qt/jsobjects.h:
3530
3531 2009-10-01  Chris Marrin  <cmarrin@apple.com>
3532
3533         Reviewed by Oliver Hunt.
3534
3535         Turn on ENABLE_3D_CANVAS in TOT
3536         https://bugs.webkit.org/show_bug.cgi?id=29906
3537
3538         * Scripts/build-webkit:
3539
3540 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3541
3542         Rubberstamped by Simon Hausmann.
3543
3544         Enable HTTP tests for Qt
3545
3546         * Scripts/run-webkit-tests:
3547
3548 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
3549
3550         Reviewed by Dimitri Glazkov.
3551
3552         build-webkit --chromium now also works on cygwin.
3553
3554         https://bugs.webkit.org/show_bug.cgi?id=29973
3555
3556         * Scripts/webkitdirs.pm:
3557
3558 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
3559
3560         Reviewed by Simon Hausmann.
3561
3562         [Qt] Don't use TCmalloc in DumpRenderTree
3563         https://bugs.webkit.org/show_bug.cgi?id=27029
3564
3565         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
3566
3567         * DumpRenderTree/qt/DumpRenderTree.pro:
3568
3569 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3570
3571         Reviewed by Simon Hausmann.
3572
3573         [Qt] Implement eventSender.scheduleAsynchronousClick().
3574
3575         https://bugs.webkit.org/show_bug.cgi?id=29931
3576
3577         * DumpRenderTree/qt/jsobjects.cpp:
3578         (EventSender::scheduleAsynchronousClick):
3579         * DumpRenderTree/qt/jsobjects.h:
3580
3581 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3582
3583         Reviewed by Simon Hausmann.
3584
3585         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
3586         fast/events/open-window-from-another-frame.html from the Skipped list.
3587
3588         https://bugs.webkit.org/show_bug.cgi?id=29930
3589
3590         * DumpRenderTree/qt/jsobjects.cpp:
3591         (LayoutTestController::setPopupBlockingEnabled):
3592         * DumpRenderTree/qt/jsobjects.h:
3593
3594 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
3595
3596         Unreviewed.
3597
3598         Added myself to the list of committers.
3599
3600         * Scripts/modules/committers.py:
3601
3602 2009-09-30  Eric Seidel  <eric@webkit.org>
3603
3604         No review, just adding Geoff to the list of reviewers.
3605
3606         * Scripts/modules/committers.py:
3607
3608 2009-09-30  Dan Bernstein  <mitz@apple.com>
3609
3610         Reviewed by Sam Weinig.
3611
3612         Added the WebKit Layout Tests fonts that are referenced in
3613         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
3614
3615         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
3616         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
3617
3618 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3619
3620         Reviewed by David Kilzer.
3621
3622         Make sunspider scripts work on Windows platform.
3623         https://bugs.webkit.org/show_bug.cgi?id=29656
3624
3625         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
3626         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
3627         * Scripts/webkitdirs.pm: currentPerlPath() added.
3628
3629 2009-09-29  Brady Eidson  <beidson@apple.com>
3630
3631         Rubberstamped by Dan Bernstein.
3632
3633         Fix license and some sorting in new files.
3634
3635         * DumpRenderTree/mac/HistoryDelegate.h:
3636         * DumpRenderTree/mac/HistoryDelegate.mm:
3637
3638 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
3639
3640         Reviewed by David Kilzer.
3641
3642         Fixed how error codes are handled.
3643         https://bugs.webkit.org/show_bug.cgi?id=29898
3644
3645         * Scripts/update-webkit:
3646         * Scripts/update-webkit-chromium:
3647
3648 2009-09-29  Brady Eidson  <beidson@apple.com>
3649
3650         Reviewed by John Sullivan.
3651
3652         Updated way-out-of-date sorting throughout the dump methods/flags.
3653
3654         * DumpRenderTree/LayoutTestController.cpp:
3655         (LayoutTestController::LayoutTestController):
3656         (dumpAsPDFCallback):
3657         (dumpAsTextCallback):
3658         (dumpFrameLoadCallbacksCallback):
3659         (dumpResourceLoadCallbacksCallback):
3660         (LayoutTestController::staticFunctions):
3661
3662         * DumpRenderTree/LayoutTestController.h:
3663         (LayoutTestController::dumpAsText):
3664         (LayoutTestController::setDumpAsText):
3665         (LayoutTestController::dumpFrameLoadCallbacks):
3666         (LayoutTestController::setDumpFrameLoadCallbacks):
3667         (LayoutTestController::dumpSelectionRect):
3668         (LayoutTestController::setDumpSelectionRect):
3669         (LayoutTestController::dumpSourceAsWebArchive):
3670         (LayoutTestController::setDumpSourceAsWebArchive):
3671         (LayoutTestController::dumpStatusCallbacks):
3672         (LayoutTestController::setDumpStatusCallbacks):
3673         (LayoutTestController::dumpTitleChanges):
3674         (LayoutTestController::setDumpTitleChanges):
3675         (LayoutTestController::dumpWillCacheResponse):
3676         (LayoutTestController::setDumpWillCacheResponse):
3677
3678 2009-09-29  Brady Eidson  <beidson@apple.com>
3679
3680         Reviewed by John Sullivan.
3681
3682         WebKit Mac API should provide a delegate interface for global history.
3683         <rdar://problem/7042773> and https://webkit.org/b/29904
3684
3685         Adding the dumping of global history delegate callbacks.
3686
3687         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3688
3689         Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
3690         * DumpRenderTree/mac/DumpRenderTree.mm:
3691         (createWebViewAndOffscreenWindow):
3692         (allocateGlobalControllers):
3693