2fb6f593eb147b19a1e6270a3bd8992e0d2f08df
[WebKit-https.git] / WebKitTools / ChangeLog
1 2008-01-19  David Kilzer  <ddkilzer@apple.com>
2
3         <rdar://problem/5695344> check-for-global-initializers script never checks any object files
4
5         Reviewed by Darin.
6
7         We now touch a check-for-global-initializers.timestamp file in
8         the TARGET_TEMP_DIR directory to determine when new object files
9         have been compiled and thus need to be checked.  If the timestamp
10         file doesn't exist, all object files will be checked.
11
12         Previously the modification time of the "executable" (the
13         framework binary, e.g., WebKit.framework/WebKit) was used, but
14         since this was the last file modified at the end of the compile
15         phase, no object files would ever get checked!
16
17         Also added JSCustomSQLTransactionCallback.o to the list of files
18         since it has static initializers in Debug builds of WebCore.
19
20         * Scripts/check-for-global-initializers:
21
22 2008-01-18  Adam Roben  <aroben@apple.com>
23
24         Build fix
25
26         * Scripts/build-webkit:
27
28 2008-01-18  Beth Dakin  <bdakin@apple.com>
29
30         Reviewed by Oliver.
31
32         Update build-webkit to account for foreign-object being disabled by 
33         default.
34
35         * Scripts/build-webkit:
36
37 2008-01-18  Adam Roben  <aroben@apple.com>
38
39         Updated for method renames
40
41         Reviewed by Adele.
42
43         * DumpRenderTree/mac/FrameLoadDelegate.mm:
44         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
45         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
46         (LayoutTestController::setMainFrameIsFirstResponder):
47         (LayoutTestController::setWindowIsKey):
48         * DumpRenderTree/mac/UIDelegate.mm:
49         (-[UIDelegate webViewFocus:]):
50         * DumpRenderTree/win/FrameLoadDelegate.cpp:
51         (FrameLoadDelegate::didCommitLoadForFrame):
52
53 2008-01-18  Alexey Proskuryakov  <ap@webkit.org>
54
55         Reviewed by Adam Roben.
56
57         Fix plugin-related tests in Debug_Internal configuration, which are failing because of CRT version mismatch
58         between DRT and TestNetscapePlugin.
59
60         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Added a Debug_Internal configuration.
61         * DumpRenderTree/DumpRenderTree.sln: Use this configuration.
62
63 2008-01-18  Simon Hausmann  <hausmann@webkit.org>
64
65         Reviewed by Holger.
66
67         Fix fast/dom/Window/window-resize.html
68         
69         In DRT connect the page's geometryChangeRequest signal to a slot that
70         sets the geometry of the view widget.
71         
72
73         * DumpRenderTree/qt/DumpRenderTree.cpp:
74         (WebCore::WebPage::setViewGeometry):
75         (WebCore::WebPage::WebPage):
76
77 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
78
79         Build fix.
80
81         * Drosera/DroseraWin.make:
82
83 2008-01-17  Darin Adler  <darin@apple.com>
84
85         * Scripts/run-webkit-tests: Fixed a bug number.
86
87 2008-01-17  Alexey Proskuryakov  <ap@webkit.org>
88
89         Reviewed by Adam Roben.
90
91         http://bugs.webkit.org/show_bug.cgi?id=16908
92         run-webkit-tests complains about missing FindSafari.exe
93
94         * Scripts/webkitdirs.pm: Append _debug as appropriate.
95
96 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
97
98         Re-add DEBUG_WEBKIT_HAS_SUFFIX.
99         
100         Rubber-stamped by Jon Honeycutt.
101
102         * DumpRenderTree/win/DumpRenderTree.vcproj:
103
104 2008-01-16  Alp Toker  <alp@atoker.com>
105
106         Reviewed by Mark Rowe.
107
108         http://bugs.webkit.org/show_bug.cgi?id=16218
109         [GTK] API: Should this entry point be called go_back rather than go_backward?
110
111         Track back/forward API changes in the tools.
112
113         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
114         (BackForwardItem::invoke):
115         * GtkLauncher/main.c:
116         (go_back_cb):
117
118 2008-01-16  Adam Roben  <aroben@apple.com>
119
120         Windows build fix after r29488
121
122         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
123         Build into a subdirectory of $WebKitOutputDir\bin to match where DRT
124         expects to find the plugin.
125
126 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
127
128         Reviewed by Sam Weinig.
129         
130         Fixed the waitUntilDone watchdog timer -- the old code never added the
131         timer to the run loop, so it didn't do anything.
132
133         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
134         (LayoutTestController::setWaitToDump):
135         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
136         (LayoutTestController::setWaitToDump):
137
138 2008-01-14  Steve Falkenburg  <sfalken@apple.com>
139
140         Use shared vsprops for most vcproj properties.
141         
142         Reviewed by Darin.
143
144         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
145         * DumpRenderTree/win/DumpRenderTree.vcproj:
146         * DumpRenderTree/win/ImageDiff.vcproj:
147         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
148         * FindSafari/FindSafari.vcproj:
149
150 2008-01-14  Stephanie  <slewis@apple.com>
151
152        Reviewed by NOBODY.
153   
154        revert accidental character.
155
156        * Scripts/run-webkit-tests:
157
158 2008-01-14  Stephanie  <slewis@apple.com>
159
160         RS=Oliver
161
162         add Quicktime PPC only leaks to Leopard exclude list. See <rdar://problem/5667132>
163
164         * Scripts/run-webkit-tests:
165
166 2008-01-14  Darin Adler  <darin@apple.com>
167
168         * Scripts/do-webcore-rename: Queue up another rename.
169
170 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
171
172         Reviewed by Darin.
173
174         * Allow to run the tests in reverse order to spot test cases where the result depends on the order
175         the tests were ran.
176         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
177
178         * Scripts/run-webkit-tests:
179
180 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
181
182         Reviewed by Darin.
183
184         * Randomize tests array to spot test cases where the results depends on the order
185         the tests are ran.
186         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
187
188         * Scripts/run-webkit-tests:
189
190 2008-01-14  Darin Adler  <darin@apple.com>
191
192         * Scripts/run-webkit-tests: More ignore list tweaking.
193
194 2008-01-14  Darin Adler  <darin@apple.com>
195
196         * Scripts/run-webkit-tests: Add another leak to the ignore list.
197
198 2008-01-14  Dan Bernstein  <mitz@apple.com>
199
200         Reviewed by Adam Roben.
201
202         - try to fix failure in fast/dom/Window/window-onFocus.html seen on the
203           build bots
204
205         * DumpRenderTree/win/DumpRenderTree.cpp:
206         (resetWebViewToConsistentStateBeforeTesting): Focus the web view.
207
208 2008-01-13  Steve Falkenburg  <sfalken@apple.com>
209
210         Share common files across projects.
211         
212         Unify vsprops files
213         Debug:          common.vsprops, debug.vsprops
214         Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
215         Release:        common.vsprops, release.vsprops
216         
217         Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
218         debug_internal.vsprops will be mostly empty except for file path prefix modifiers.
219
220         Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.
221
222         Reviewed by Adam Roben.
223
224         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
225         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
226         * Drosera/win/Drosera.vcproj/VERSION: Removed.
227         * Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
228         * Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
229         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
230         * Drosera/win/Drosera.vcproj/release.vsprops: Removed.
231         * DumpRenderTree/win/DumpRenderTree.vcproj:
232         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
233         * DumpRenderTree/win/debug.vsprops: Removed.
234         * DumpRenderTree/win/debug_internal.vsprops: Removed.
235         * DumpRenderTree/win/release.vsprops: Removed.
236
237 2008-01-13  Brent Fulgham  <bfulgham@gmail.com>
238
239         Reviewed by Maciej.
240
241         - http://bugs.webkit.org/show_bug.cgi?id=16314
242           Script to launch Drosera
243
244         * Scripts/gdb-drosera: Added.
245         * Scripts/run-drosera: Added.
246         * Scripts/run-drosera-nightly.cmd: Added.
247         * Scripts/webkitdirs.pm: Added runDrosera function.
248
249 2008-01-13  Dan Bernstein  <mitz@apple.com>
250
251         - fix breakage due to last-minute change
252
253         * DumpRenderTree/win/DumpRenderTree.cpp:
254         (runTest): Declare the loop variable.
255
256 2008-01-13  Dan Bernstein  <mitz@apple.com>
257
258         Reviewed by Adam Roben.
259
260         - fix <rdar://problem/5132009> Windows DRT does not support multiple windows
261
262         * DumpRenderTree/win/DumpRenderTree.cpp:
263         (DumpRenderTreeWndProc):
264         (initialize):
265         (dumpBackForwardList):
266         (dumpBackForwardListForAllWindows):
267         (dump):
268         (resetWebViewToConsistentStateBeforeTesting): Factored out of
269         runTest().
270         (runTest):
271         (allWindows): Added. Returns a vector of all open windows.
272         (windowToWebViewMap): Added. Returns a map from open windows to their
273         WebViews.
274         (createWebViewAndOffscreenWindow): Factored out of main() to be
275         reusable for creating extra windows.
276         (main):
277         * DumpRenderTree/win/DumpRenderTreeWin.h:
278         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
279         (LayoutTestController::windowCount): Implemented.
280         * DumpRenderTree/win/UIDelegate.cpp:
281         (UIDelegate::createWebViewWithRequest): Implemented.
282         (UIDelegate::webViewClose): Implemented.
283         * DumpRenderTree/win/UIDelegate.h:
284
285 2008-01-12  Alp Toker  <alp@atoker.com>
286
287         Reviewed by Mark Rowe.
288
289         Hide non-public symbols in GTK+/autotools release builds.
290
291         * GNUmakefile.am:
292
293 2008-01-12  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
294
295         Reviewed by Ap.
296
297         * Make launching of the WebKit httpd work on GNU/Debian/Linux
298         
299         The configuration of Apache2 and installation does not depend on
300         the kernel but on the distribution policy. Make launching of httpd
301         work for Debian derived distributions.
302
303         * Scripts/run-webkit-httpd:
304         * Scripts/run-webkit-tests:
305         * Scripts/webkitdirs.pm:
306
307 2008-01-12  Mark Rowe  <mrowe@apple.com>
308
309         Reviewed by Maciej Stachowiak.
310
311         Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.
312
313         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to
314         match the callers expectations that it can take ownership of the string.
315
316 2008-01-11  Alexey Proskuryakov  <ap@webkit.org>
317
318         Reviewed by Adam Roben.
319
320         <rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing
321
322         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events,
323         as these are only posted because the test window is not a normal visible one, and
324         they confuse drag&drop machinery.
325
326 2008-01-11  Adam Roben  <aroben@apple.com>
327
328         Fix a crash when pathToLocalResource fails and a leak
329
330         Reviewed by Darin.
331
332         * DumpRenderTree/LayoutTestController.cpp:
333         (pathToLocalResourceCallback): Dont leak the JSStringRef, and make
334         sure not to pass null to JSValueMakeString.
335         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
336         (LayoutTestController::pathToLocalResource): Print an error message if
337         the conversion fails so it's clear what happened.
338
339 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
340
341         Reviewed by John Sullivan.
342
343         * DumpRenderTree/mac/GCControllerMac.mm:
344         (GCController::collectOnAlternateThread): Updated for name change.
345
346 2008-01-10  Kevin Ollivier  <kevino@theolliviers.com>
347
348         wx build fix. Don't build dftables any longer since it's now a Perl
349         script.
350
351         * wx/build-wxwebkit:
352
353 2008-01-10  Sam Weinig  <sam@webkit.org>
354
355         Reviewed by Anders Carlsson.
356
357         Make DRT track open windows instead of allocated windows so that
358         we can avoid ASSERTION due to late deallocs out of our control.
359
360         * DumpRenderTree/mac/DumpRenderTree.mm:
361         (dumpBackForwardListForAllWindows):
362         (runTest):
363         * DumpRenderTree/mac/DumpRenderTreeMac.h:
364         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
365         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
366         (+[DumpRenderTreeWindow openWindows]):
367         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
368         (-[DumpRenderTreeWindow close]):
369         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
370         (LayoutTestController::windowCount):
371
372 2008-01-10  Ada Chan  <adachan@apple.com>
373
374         Meta key is not the same as Alt key on windows.
375
376         Reviewed by Darin.
377
378         * DumpRenderTree/win/EventSender.cpp:
379         (keyDownCallback):
380
381 2008-01-09  Kevin McCullough  <kmccullough@apple.com>
382
383         Reviewed by Darin, Sam and Adam.
384
385         -<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
386         link in gmail message displays JavaScript alert falsely complaining
387         about pop-up blocking.
388         - Added the ability to enable the pop-up blocker via the
389         LayoutTestController.
390
391         * DumpRenderTree/LayoutTestController.cpp:
392         (setPopupBlockingEnabledCallback):
393         (LayoutTestController::staticFunctions):
394         * DumpRenderTree/LayoutTestController.h:
395         * DumpRenderTree/mac/DumpRenderTree.mm:
396         (setDefaultsToConsistentValuesForTesting):
397         (resetWebViewToConsistentStateBeforeTesting):
398         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
399         (LayoutTestController::setPopupBlockingEnabled):
400
401 2008-01-10  Lars Knoll  <lars@trolltech.com>
402
403         Reviewed by Simon.
404
405         rename QWebPageHistory to QWebHistory.
406         
407
408         * DumpRenderTree/qt/jsobjects.cpp:
409
410 2008-01-09  Maciej Stachowiak  <mjs@apple.com>
411
412         Reviewed by Darin.
413         
414         - add some more renames, adjust some
415
416         * Scripts/do-webcore-rename:
417
418 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
419
420         Reviewed by Oliver.
421
422         Enable SVG Fonts support by default.
423
424         * Scripts/build-webkit:
425
426 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
427
428         Reviewed by Adam.
429
430         Fixes: http://bugs.webkit.org/show_bug.cgi?id=16244
431         DRT doesn't handle platform specific pixel test results correctly.
432
433         <test>-expected.txt files and <test>-expected.png files may now live
434         in different directories (ie. a cross-platform <test>-expected.txt file
435         and a platform-specific <test>-expected.png file).
436
437         * Scripts/run-webkit-tests:
438
439 2008-01-04  Kevin McCullough  <kmccullough@apple.com>
440
441         Reviewed by Darin.
442
443         - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing
444         DRT did not correctly handle printing the '\0' char.  Now it does.
445
446         * DumpRenderTree/win/DumpRenderTree.cpp:
447         (dumpFramesAsText):
448         (dump):
449
450 2008-01-07  Simon Hausmann  <hausmann@webkit.org>
451
452         Reviewed by Lars.
453
454         Ported of the network backend of the Qt platform to Qt 4.4's new networking API.
455         
456
457         * DumpRenderTree/qt/main.cpp:
458         * DumpRenderTree/qt/testplugin.cpp:
459         * DumpRenderTree/qt/testplugin.h:
460
461 2008-01-05  Mark Rowe  <mrowe@apple.com>
462
463         Reviewed by Alp Toker.
464
465         Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.
466
467         * DumpRenderTree/gtk/DumpRenderTree.cpp:
468         (processWork): Process pending work.
469         (webViewLoadFinished): Schedule processing of pending work.
470         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.
471
472 2008-01-05  Darin Adler  <darin@apple.com>
473
474         * Scripts/do-webcore-rename: Some more renaming plans.
475
476 2008-01-04  Alice Liu  <alice.liu@apple.com>
477
478         Reviewed by Alexey and Darin.
479
480         Adding "home" and "end" to DRT's keydown since
481         DOM key events can't handle keyIdentifiers at this point. 
482
483         * DumpRenderTree/mac/EventSendingController.mm:
484         (-[EventSendingController keyDown:withModifiers:]):
485         * DumpRenderTree/win/EventSender.cpp:
486         (keyDownCallback):
487
488 2008-01-04  Lars Knoll  <lars@trolltech.com>
489
490         Reviewed by Simon.
491
492         fix DRT after the changes to QWebPage.
493         
494         The great thing is that we actually don't have
495         any regressions from the QWebPage change :)
496         
497
498         * DumpRenderTree/qt/DumpRenderTree.cpp:
499         (WebCore::DumpRenderTree::DumpRenderTree):
500
501 2008-01-04  Lars Knoll  <lars@trolltech.com>
502
503         Reviewed by Simon.
504
505         make QWebPage a QObject and get things to compile.
506         
507         Nothing works currently though.
508         
509
510         * DumpRenderTree/qt/DumpRenderTree.cpp:
511         (WebCore::DumpRenderTree::DumpRenderTree):
512
513 2008-01-04  Lars Knoll  <lars@trolltech.com>
514
515         Reviewed by Simon.
516
517         take a QString as identifier in QWebFrame::addToJSWindowObject.
518
519         * DumpRenderTree/qt/DumpRenderTree.cpp:
520         (WebCore::DumpRenderTree::initJSObjects):
521
522 2008-01-04  Alp Toker  <alp@atoker.com>
523
524         GTK+ DRT build fix for breakage introduced in r29149.
525
526         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
527         (LayoutTestController::execCommand):
528
529 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
530
531         Reviewed by Darin.
532
533         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
534
535         Added layoutTestController.execCommand to access editor commands that are not available
536         via document.execCommand.
537
538         * DumpRenderTree/LayoutTestController.cpp:
539         (execCommandCallback):
540         (LayoutTestController::staticFunctions):
541         * DumpRenderTree/LayoutTestController.h:
542         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
543         (LayoutTestController::execCommand):
544         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
545         (LayoutTestController::queueLoad):
546         (LayoutTestController::execCommand):
547
548 2008-01-03  Alice Liu  <alice.liu@apple.com>
549
550         Reviewed by Darin, Mitz.
551
552         fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
553
554         the clickcount should not increase if the last click was at a different location.  it's a new click.
555
556         * DumpRenderTree/mac/DumpRenderTree.mm:
557         (runTest):
558         * DumpRenderTree/mac/EventSendingController.h:
559         * DumpRenderTree/mac/EventSendingController.mm:
560         (-[EventSendingController mouseDown]):
561         (-[EventSendingController mouseUp]):
562
563 2008-01-03  Darin Adler  <darin@apple.com>
564
565         Reviewed by Adam.
566
567         * Scripts/update-webkit: Make this work a little better for the people at Apple
568         who have a directory named Internal.
569
570 2008-01-03  Adam Roben  <aroben@apple.com>
571
572         Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default
573
574         Rubberstamped by Mark.
575
576         * Scripts/update-webkit-auxiliary-libs:
577
578 2008-01-03  Adam Roben  <aroben@apple.com>
579
580         Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
581
582         http://bugs.webkit.org/show_bug.cgi?id=15663
583
584         Added a fuzz factor into the Last-Modified comparison for downloading
585         WebKitAuxiliaryLibrary.zip.
586
587         The zip file is served from a set of mirrors who give Last-Modified
588         times that are off by 1-3 seconds from each other. This was causing
589         the build bots to redownload WebKitAuxiliaryLibrary for every build,
590         which would then cause all of WebCore to rebuild each time.
591
592         Reviewed by Mark.
593
594         * Scripts/update-webkit-auxiliary-libs: Check if the new zip file is
595         at least 30 seconds newer than the old one -- otherwise we assume that
596         the difference in time is due to the mirrors being slightly offset
597         from each other.
598         (sub lastModifiedToUnixTime): Added.
599
600 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
601
602         Windows build fix.
603
604         * DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
605
606 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
607
608         Reviewed by Lars.
609
610         Moved QWebPage::open to QWebFrame::load and added setHtml.
611         
612
613         * DumpRenderTree/qt/DumpRenderTree.cpp:
614         (WebCore::DumpRenderTree::open):
615
616 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
617
618         Reviewed by Lars.
619
620         Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.
621         
622
623         * DumpRenderTree/qt/DumpRenderTree.cpp:
624         (WebCore::DumpRenderTree::DumpRenderTree):
625
626 2008-01-02  Sam Weinig  <sam@webkit.org>
627
628         * Scripts/do-webcore-rename: Yet more renaming ideas.
629
630 2008-01-02  Darin Adler  <darin@apple.com>
631
632         * Scripts/do-webcore-rename: More renaming ideas. (Maciej, please merge yours with mine.)
633
634 2008-01-02  Alice Liu  <alice.liu@apple.com>
635
636         Reviewed by Sam Weinig.
637
638         fixing assertion hit with editing/selection/move-begin-end.html
639
640         * DumpRenderTree/ForwardingHeaders/wtf/ASCIICType.h: Added.
641         * DumpRenderTree/win/DumpRenderTree.vcproj:
642         * DumpRenderTree/win/EventSender.cpp:
643         (keyDownCallback):
644         using isupper will cause an assertion for inputs outside of ascii range. use isASCIIUpper instead.
645
646 2008-01-02  Darin Adler  <darin@apple.com>
647
648         * Scripts/do-webcore-rename: Some more name change plans.
649
650 2008-01-02  Alice Liu  <alice.liu@apple.com>
651
652         Reviewed by Maciej.
653
654         Added handling for page up and page down in EventSender
655
656         * DumpRenderTree/mac/EventSendingController.mm:
657         (-[EventSendingController keyDown:withModifiers:]):
658         * DumpRenderTree/win/EventSender.cpp:
659         (keyDownCallback):
660
661 2008-01-02  Alexey Proskuryakov  <ap@webkit.org>
662
663         Reviewed by Darin.
664
665         Fix fast/events/arrow-keys-on-body.html for real.
666
667         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Pass proper keyData for WM_KEYUP, too.
668
669 2008-01-02  Luca Bruno  <lethalman88@gmail.com>
670
671         Reviewed by Darin.
672
673         http://bugs.webkit.org/show_bug.cgi?id=16674
674         [GTK] run-launcher sets wrong LD_LIBRARY_PATH
675
676         * Scripts/run-launcher:
677
678 2007-12-31  Darin Adler  <darin@apple.com>
679
680         Suggested by Antti.
681
682         * Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until
683         we get it installed on the build bots.
684
685 2007-12-30  Eric Seidel  <eric@webkit.org>
686
687         Reviewed by Sam.
688
689         * Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
690
691 2007-12-29  Darin Adler  <darin@apple.com>
692
693         Reviewed by Oliver.
694
695         - fix http://bugs.webkit.org/show_bug.cgi?id=16663
696           leak bot shows createCStringFromNPVariant result leaking
697
698         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
699         (pluginInvoke): Added a missing free.
700
701 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
702
703         Reviewed by Alp Toker.
704
705         http://bugs.webkit.org/show_bug.cgi?id=16390
706         Use autotools or GNU make as the build system for the GTK port
707
708         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: include glib.h
709         * GNUmakefile.am: Added.
710
711 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
712
713         Reviewed by Oliver.
714
715         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
716
717         * DumpRenderTree/win/EventSender.cpp:
718         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
719         of 1, even though WebKit currently ignores it.
720
721 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
722
723         wx buildbot fix. Update libpng dl script to the latest version.
724
725         * wx/install-unix-extras:
726
727 2007-12-22  Antti Koivisto  <antti@apple.com>
728
729         Fix a typo.
730
731         * Scripts/webkitdirs.pm:
732
733 2007-12-21  Sam Weinig  <sam@webkit.org>
734
735         Reviewed by Mark Rowe.
736
737         - Disable the back/forward cache using the new WebPreferences API
738           instead of through the BackForwardList.  This makes us match what
739           we do on Windows.
740
741         * DumpRenderTree/mac/DumpRenderTree.mm:
742         (createWebViewAndOffscreenWindow):
743         (setDefaultsToConsistentValuesForTesting):
744
745 2007-12-21  Dan Bernstein  <mitz@apple.com>
746
747         Reviewed by Mark Rowe.
748
749         - disable the back/forward cache in Windows DumpRenderTree. It is
750           already disabled in Mac DumpRenderTree.
751
752         * DumpRenderTree/win/DumpRenderTree.cpp:
753         (initializePreferences):
754
755 2007-12-13  Antti Koivisto  <antti@apple.com>
756
757         Reviewed by Darin and Steve.
758         
759         - check for QuickTime SDK on Windows.
760         - build media support on Windows by default
761
762         * Scripts/build-webkit:
763         * Scripts/webkitdirs.pm:
764
765 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
766
767         Build script fix for buildbot.
768
769         * wx/build-wxwebkit:
770
771 2007-12-20  Eric Seidel  <eric@webkit.org>
772
773         Reviewed by mjs.
774
775         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
776
777 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
778
779         Reviewed by Steve.
780
781         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
782         WebKit.
783
784         - Drosera and Safari need to use the same ProgIDs in order for
785         CoCreateInstance to work properly.  The most robust way to do this is
786         for WebKit to dynamically publish those ProgIDs.
787
788         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
789         (DebuggerClient::createWebViewWithRequest):
790         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
791         statics.
792         (Drosera::initUI):
793         (Drosera::attach):
794         (Drosera::attemptToCreateServerConnection):
795         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
796         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
797         make use of the published ProgIDs.
798         (ServerConnection::attemptToCreateServerConnection):
799
800 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
801
802         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
803         - Build bot and leak fix.
804
805         * DumpRenderTree/LayoutTestController.cpp:
806         (pathToLocalResourceCallback):
807
808 2007-12-19  David Kilzer  <ddkilzer@apple.com>
809
810         Make svn-apply/svn-unapply work with patches from git-format-patch.
811
812         Reviewed by Darin.
813
814         * Scripts/svn-apply:
815         (patch): If 'Index:' can't be found in the text passed in, print it
816         out with a warning and return early.
817         * Scripts/svn-unapply:
818         (patch): Ditto.
819
820 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
821
822         Reviewed by Alp Toker.
823
824         Build related fixes.
825
826         * wx/build-wxwebkit:
827         - Check to make sure the user is running a supported wx port
828         - More robust checks for Cygwin
829         - Only run install-unix-extras on Mac, it's not the right solution
830           for Linux distros.
831         - Remove outdated Linux instructions after successful build
832         - Clean Bakefile-generated files during a clean operation
833
834 2007-12-18  Darin Adler  <darin@apple.com>
835
836         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
837
838 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
839
840         Add script to run Drosera as part of the nightly.
841         
842         Reviewed by Kevin M.
843
844         * Scripts/run-drosera.cmd: Added.
845
846 2007-12-18  Darin Adler  <darin@apple.com>
847
848         * Scripts/do-webcore-rename: Remove a stray K.
849
850 2007-12-18  Darin Adler  <darin@apple.com>
851
852         * Scripts/do-webcore-rename: Plan more renaming.
853
854 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
855
856         Reviewed by Alp Toker.
857
858         http://bugs.webkit.org/show_bug.cgi?id=16042
859         [GTK] Eliminate webkit_init()
860
861         Moving webkit initialization to WebView class init.
862
863         * DumpRenderTree/gtk/DumpRenderTree.cpp:
864         (main):
865         * GtkLauncher/main.c:
866         (main):
867
868 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
869
870         Reviewed by Alp Toker.
871
872         http://bugs.webkit.org/show_bug.cgi?id=13542
873         gdklauncher doesnt change URL in adress GTKEntry.
874
875         * GtkLauncher/main.c:
876         (load_commit_cb): added
877         (title_change_cb):
878         (create_browser):
879
880 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
881
882         Reviewed by Adam Roben.
883
884         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
885
886         * FindSafari/FindSafari.cpp:
887         (_tmain):
888
889 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
890
891         Reviewed by Adam Roben.
892
893         http://bugs.webkit.org/show_bug.cgi?id=16315
894         FindSafari needs a path-only option.
895
896         * FindSafari/FindSafari.cpp:
897         (_tmain):
898
899 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
900
901         Reviewed by Darin.
902
903         http://bugs.webkit.org/show_bug.cgi?id=16462
904         REGRESSION: access keys broken on Windows
905
906         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
907         if Alt is pressed.
908
909 2007-12-15  Sam Weinig  <sam@webkit.org>
910
911         Reviewed by Mark Rowe.
912
913         Fix urlSuitableForTestResult to correctly identify wstring::npos as
914         the case when wstring.find doesn't find anything.
915
916         * DumpRenderTree/win/DumpRenderTree.cpp:
917         (urlSuitableForTestResult):
918
919 2007-12-15  Alp Toker  <alp@atoker.com>
920
921         GTK+ DRT build fix for GLib < 2.14.
922
923         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
924         (LayoutTestController::setWaitToDump):
925
926 2007-12-05  Mark Rowe  <mrowe@apple.com>
927
928         Reviewed by Alp Toker.
929
930         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
931         many layout tests from hanging while waiting on user responses to dialogs.
932
933         * DumpRenderTree/gtk/DumpRenderTree.cpp:
934         (invalidateAnyPreviousWaitToDumpWatchdog):
935         (webViewScriptAlert):
936         (webViewScriptPrompt):
937         (webViewScriptConfirm):
938         (main):
939         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
940         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
941         (waitToDumpWatchdogFired):
942         (LayoutTestController::setWaitToDump):
943
944 2007-12-05  Mark Rowe  <mrowe@apple.com>
945
946         Reviewed by Alp Toker.
947
948         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
949
950         * DumpRenderTree/gtk/DumpRenderTree.cpp:
951         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
952         (dump):
953         (runTest):
954         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
955         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
956         work queue is empty.
957         (webViewWindowObjectCleared): Set up window.layoutTestController.
958         (webViewConsoleMessage): Match the console message format expected by the layout test results.
959         (main): Hook up the new signals.
960         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
961         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
962         dumping multiple times.
963         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
964         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
965
966 2007-12-14  Anders Carlsson  <andersca@apple.com>
967
968         Reviewed by Brady.
969
970         Assert that a web frame that's loading a resource always has either a data source or 
971         a provisional data source.
972         
973         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
974         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
975
976 2007-12-14  Darin Adler  <darin@apple.com>
977
978         - fix mistake causing nearly all tests to fail on Windows
979
980         * DumpRenderTree/win/UIDelegate.cpp:
981         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
982         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
983
984         * DumpRenderTree/mac/UIDelegate.mm:
985         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
986         than passing the entire message.
987
988 2007-12-14  Darin Adler  <darin@apple.com>
989
990         - fix Tiger build
991
992         * DumpRenderTree/mac/UIDelegate.mm:
993         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
994         new-to-Leopard methods.
995
996 2007-12-14  Darin Adler  <darin@apple.com>
997
998         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
999         since it now triggers unwanted icon loading. We only had it because we implemented "all"
1000         delegate methods here.
1001
1002 2007-12-14  Anders Carlsson  <andersca@apple.com>
1003
1004         Reviewed by Darin and Geoff.
1005
1006         <rdar://problem/5619295> 
1007         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
1008         
1009         Add property getting methods to the plug-in.
1010         
1011         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1012         (pluginInvoke):
1013
1014 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
1015
1016         Reviewed by Darin.
1017
1018         - Layout test fix for mac. When dumped to the console local file paths
1019         now only show the name of the resource not the whole path.  This is to
1020         make the results machine and OS independent.
1021
1022         * DumpRenderTree/mac/UIDelegate.mm:
1023         (-[UIDelegate webView:addMessageToConsole:]):
1024
1025 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
1026
1027         Reviewed by Adam.
1028
1029         - Layout tests fix.  We need a way to remove machine-dependent
1030         information from paths in layout test results. The UIDelegate now does
1031         this.
1032
1033         * DumpRenderTree/DumpRenderTree.h:
1034         * DumpRenderTree/win/DumpRenderTree.cpp:
1035         (urlSuitableForTestResult):
1036         * DumpRenderTree/win/DumpRenderTreeWin.h:
1037         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1038         * DumpRenderTree/win/UIDelegate.cpp:
1039         (UIDelegate::webViewAddMessageToConsole):
1040
1041 2007-12-13  Alp Toker  <alp@atoker.com>
1042
1043         Build fix for DRT breakage introduced in r28690.
1044
1045         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1046         (LayoutTestController::pathToLocalResource):
1047
1048 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
1049
1050         Reviewed by Alice and Sam.
1051
1052         - <rdar://5621435> Need a way to specify local resources (being loaded
1053         from HTTP tests) on Windows.
1054         - Implemented pathToLocalResource which exposes the functionality of
1055         converting a given unix path to the correct location on Windows.
1056
1057         * DumpRenderTree/LayoutTestController.cpp:
1058         (pathToLocalResourceCallback):
1059         (LayoutTestController::staticFunctions):
1060         * DumpRenderTree/LayoutTestController.h:
1061         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1062         (LayoutTestController::pathToLocalResource):
1063         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1064         (LayoutTestController::pathToLocalResource):
1065
1066 2007-12-12  Anders Carlsson  <andersca@apple.com>
1067
1068         Reviewed by Sam.
1069
1070         <rdar://problem/5132003>
1071         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
1072
1073         * DumpRenderTree/win/DumpRenderTree.cpp:
1074         (main):
1075         Set the resource load delegate.
1076         
1077         * DumpRenderTree/win/DumpRenderTree.vcproj:
1078         
1079         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
1080         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
1081
1082 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
1083
1084         Reviewed by Adam Roben.
1085
1086         Fix conversion from double to LPARAM in dispatchMessage().
1087
1088         * DumpRenderTree/win/EventSender.cpp:
1089         (dispatchMessageCallback):
1090
1091 2007-12-11  Dan Bernstein  <mitz@apple.com>
1092
1093         Reviewed by Mark Rowe and Sam Weinig too!
1094
1095         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
1096           fonts DumpRenderTree registers.
1097
1098         * DumpRenderTree/win/DumpRenderTree.cpp:
1099         (initialize):
1100
1101 2007-12-11  Brady Eidson  <beidson@apple.com>
1102
1103         Reviewed by Anders
1104
1105         Make DumpRenderTree on mac use its own path for Databases testing
1106
1107         * DumpRenderTree/mac/DumpRenderTree.mm:
1108         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
1109           for future DRT-only use, then use it to construct the Databases path and set that default
1110
1111 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
1112
1113         Reviewed by Darin.
1114
1115         <rdar://problem/5535636>
1116         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
1117
1118         http://bugs.webkit.org/show_bug.cgi?id=13916
1119         JavaScript detects Tab as a character input on a textfield validation
1120
1121         * DumpRenderTree/mac/EventSendingController.mm:
1122         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
1123         Dispatch a keyup to better match what happens when a key is physically pressed.
1124
1125         * DumpRenderTree/win/EventSender.cpp:
1126         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
1127         returning from keyDown().
1128         (getConstantCallback): Fixed a couple copy/paste mistakes.
1129
1130 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
1131
1132         Reviewed by Oliver.
1133
1134         - <rdar://5599845> Drosera: Does not show loal files in the file list
1135         on the left side.
1136
1137         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
1138         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
1139         so the open source community can build.
1140
1141 2007-12-10  Brady Eidson  <beidson@apple.com>
1142
1143         Rubberstamped by Sam Weinig
1144
1145         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
1146
1147         * DumpRenderTree/mac/UIDelegate.mm:
1148         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1149         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
1150
1151 2007-12-08  Oliver Hunt  <oliver@apple.com>
1152
1153         Reviewed by Sam W.
1154
1155         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
1156         
1157         Fixes <rdar://problem/5620249> Must disable SVG animation
1158         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
1159         
1160         In order to allow finer grained control over the set of SVG features
1161         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
1162         distinct flags:
1163         ENABLE_SVG_ANIMATION
1164         ENABLE_SVG_FILTERS
1165         ENABLE_SVG_FONTS
1166         ENABLE_SVG_AS_IMAGE
1167         ENABLE_SVG_USE
1168         
1169         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
1170         
1171         Script handles all the new build flags, and allows --svg-experimental
1172         to automatically enable all features.
1173
1174         * Scripts/build-webkit:
1175
1176 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1177
1178         Fix version parsing.
1179
1180         Rubber-stamped by Oliver.
1181
1182         * Drosera/win/Drosera.vcproj/auto-version.sh:
1183
1184 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1185
1186         Build modifications for Drosera.
1187
1188         Reviewed by Adam.
1189
1190         * Drosera/DroseraWin.make: Added.
1191         * Drosera/win/Drosera.vcproj/Drosera.rc:
1192         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1193         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
1194         * Drosera/win/Drosera.vcproj/VERSION: Added.
1195         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
1196
1197 2007-12-06  Adam Roben  <aroben@apple.com>
1198
1199         Explicitly turn on the Mac font ascent hack on Windows
1200
1201         This keeps our font metrics matching those from Mac.
1202
1203         Reviewed by Hyatt.
1204
1205         * DumpRenderTree/win/DumpRenderTree.cpp:
1206         (main):
1207
1208 2007-12-06  Anders Carlsson  <andersca@apple.com>
1209
1210         Rename main.c to main.cpp here too.
1211         
1212         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
1213
1214 2007-12-06  Sam Weinig  <sam@webkit.org>
1215
1216         Rubber stamped by Geoff.
1217
1218         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
1219
1220 2007-12-06  Darin Adler  <darin@apple.com>
1221
1222         * Scripts/do-webcore-rename: Some more renaming plans.
1223
1224 2007-12-06  Anders Carlsson  <andersca@apple.com>
1225
1226         Restore implementation of testGetIntIdentifier that was accidentally
1227         removed somehow (possibly when I made PluginObject be a cpp file).
1228         
1229         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1230         (pluginInvoke):
1231
1232 2007-12-05  Anders Carlsson  <andersca@apple.com>
1233
1234         Make the entry points extern "C".
1235         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1236         
1237 2007-12-05  Anders Carlsson  <andersca@apple.com>
1238
1239         C++ warning fixes.
1240         
1241         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1242         (NPP_New):
1243         (NPP_Destroy):
1244         (NPP_SetWindow):
1245         (NPP_NewStream):
1246         (NPP_HandleEvent):
1247         (NPP_URLNotify):
1248         (NPP_GetValue):
1249
1250 2007-12-05  Anders Carlsson  <andersca@apple.com>
1251
1252         Add the .cpp files to the TestNetscapePlugIn target.
1253
1254         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1255
1256 2007-12-05  Anders Carlsson  <andersca@apple.com>
1257
1258         Reviewed by Geoff.
1259         
1260         Rename the TestNetscapePlugIn .c files to be .cpp.
1261
1262         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1263         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
1264         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
1265         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
1266         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
1267         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
1268         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
1269         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1270
1271 2007-12-05  Adam Roben  <aroben@apple.com>
1272
1273         Fix case of keypresses from the Windows implementation of eventSender.keyDown
1274
1275         This fixes several regression tests.
1276
1277         Reviewed by Alice.
1278
1279         * DumpRenderTree/win/EventSender.cpp:
1280         (keyDownCallback): Virtual keycodes for ASCII characters are always
1281         uppercase, so we need to check the case of the original character
1282         passed in to eventSender.keyDown.
1283
1284 2007-12-05  Adam Roben  <aroben@apple.com>
1285
1286         Learn from Tim's mistakes
1287
1288         * DumpRenderTree/win/DumpRenderTree.cpp:
1289         (runTest): Reset the authorAndUserStylesEnabled preference for each
1290         test.
1291
1292 2007-12-05  Alp Toker  <alp@atoker.com>
1293
1294         Reviewed by Mark Rowe.
1295
1296         Initialize GTK+ and WebKit so the tests can run.
1297
1298         Reorganize the headers a little.
1299
1300         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1301         (main):
1302
1303 2007-12-04  Anders Carlsson  <andersca@apple.com>
1304
1305         Remove IWebScriptScope include.
1306         
1307         * Drosera/win/DebuggerDocumentPlatform.cpp:
1308
1309 2007-12-04  Sam Weinig  <sam@webkit.org>
1310
1311         Rubber stamped by Mark Rowe.
1312
1313         Define CF as platform for mac and revert r28409
1314
1315         * DumpRenderTree/DumpRenderTree.h:
1316         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1317
1318 2007-12-04  Sam Weinig  <sam@webkit.org>
1319
1320         Define CF as platform for windows.
1321
1322         Reviewed by Adam Roben.
1323
1324         * DumpRenderTree/win/DumpRenderTreeWin.h:
1325
1326 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
1327
1328         Reviewed by Adam and Darin.
1329
1330         - Removed a needless BSTR cleanup.
1331
1332         * Drosera/win/DebuggerDocumentPlatform.cpp:
1333         (DebuggerDocument::getPlatformCurrentFunctionStack):
1334
1335 2007-11-27  Adam Roben  <aroben@apple.com>
1336
1337         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
1338
1339         Reviewed by Maciej.
1340
1341         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1342         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
1343
1344 2007-12-04  Alp Toker  <alp@atoker.com>
1345
1346         Prospective Win DRT build fix.
1347
1348         * DumpRenderTree/DumpRenderTree.h:
1349
1350 2007-12-04  Alp Toker  <alp@atoker.com>
1351
1352         Fix a clobbered copyright header.
1353
1354         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1355
1356 2007-12-04  Xan Lopez  <xan@gnome.org>
1357
1358         Reviewed by Alp Toker.
1359
1360         http://bugs.webkit.org/show_bug.cgi?id=15561
1361         GTK port needs DumpRenderTree implementation
1362
1363         Start work on the GTK+ DRT.
1364
1365         This does not work yet, and there are a few lingering style issues
1366         (nothing major) but this patch has been stuck in the bug tracker for
1367         too long already.
1368
1369         * DumpRenderTree/DumpRenderTree.h:
1370         * DumpRenderTree/gtk: Added.
1371         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
1372         (autocorrectURL):
1373         (shouldLogFrameLoadDelegates):
1374         (dumpFrameScrollPosition):
1375         (displayWebView):
1376         (appendString):
1377         (dumpFramesAsText):
1378         (dumpRenderTreeAsText):
1379         (dump):
1380         (runTest):
1381         (main):
1382         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
1383         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
1384         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
1385         (GCController::collect):
1386         (GCController::collectOnAlternateThread):
1387         (GCController::getJSObjectCount):
1388         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
1389         (LayoutTestController::~LayoutTestController):
1390         (LayoutTestController::addDisallowedURL):
1391         (LayoutTestController::clearBackForwardList):
1392         (LayoutTestController::copyDecodedHostName):
1393         (LayoutTestController::copyEncodedHostName):
1394         (LayoutTestController::display):
1395         (LayoutTestController::keepWebHistory):
1396         (LayoutTestController::notifyDone):
1397         (LayoutTestController::queueBackNavigation):
1398         (LayoutTestController::queueForwardNavigation):
1399         (LayoutTestController::queueLoad):
1400         (LayoutTestController::queueReload):
1401         (LayoutTestController::queueScript):
1402         (LayoutTestController::setAcceptsEditing):
1403         (LayoutTestController::setCustomPolicyDelegate):
1404         (LayoutTestController::setMainFrameIsFirstResponder):
1405         (LayoutTestController::setTabKeyCyclesThroughElements):
1406         (LayoutTestController::setUseDashboardCompatibilityMode):
1407         (LayoutTestController::setUserStyleSheetEnabled):
1408         (LayoutTestController::setUserStyleSheetLocation):
1409         (LayoutTestController::setWindowIsKey):
1410         (LayoutTestController::setWaitToDump):
1411         (LayoutTestController::windowCount):
1412         (LayoutTestController::setPrivateBrowsingEnabled):
1413         (LayoutTestController::setAuthorAndUserStylesEnabled):
1414         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
1415         (JSStringCopyUTF8CString):
1416         (LoadItem::invoke):
1417         (ReloadItem::invoke):
1418         (ScriptItem::invoke):
1419         (BackForwardItem::invoke):
1420
1421 2007-12-03  Sam Weinig  <sam@webkit.org>
1422
1423         Move JavaScriptCore thread testing code to pthread specific directory
1424         and remove the dependance on CoreFoundation by using WTF::HashSet.
1425
1426         Reviewed by Geoff and Oliver.
1427
1428         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1429         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
1430         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
1431         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
1432         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
1433         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
1434         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
1435         * DumpRenderTree/pthreads: Added.
1436         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
1437         (javaScriptThreads):
1438         (runJavaScriptThread):
1439         (startJavaScriptThreads):
1440         (stopJavaScriptThreads):
1441
1442 2007-12-03  Andrew Bonventre  <andybons@google.com>
1443
1444         Reviewed by Darin Adler.
1445
1446         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
1447         Symbol lookup menu broken in debugger view
1448
1449         * Drosera/debugger.js: Fixed javascript error where document property
1450         should have been used instead of contentDocument in switchFunction that
1451         was breaking the select symbol dropdown menu.  This is because
1452         window.frames will return a Window object and not a frame object like
1453         the author was originally expecting.
1454
1455 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
1456
1457         Reviewed by Adam.
1458
1459         - <rdar://5618942> Drosera: Console window does not process everything
1460         correctly.
1461         - <rdar://5619005> Drosera: could be sped up by moving the 
1462         WebScriptScope stuff into the WebScriptCallFrame.
1463         - Now the console can correctly process objects and does not receive
1464         notifications from JavaScriptCore about the JavaScript in Drosera's
1465         own process.
1466
1467         * Drosera/win/DebuggerDocumentPlatform.cpp:
1468         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1469         (DebuggerDocument::platformValueForScopeVariableNamed):
1470
1471 2007-12-03  Stephanie  <slewis@apple.com>
1472
1473         Reviewed by Darin.
1474
1475         Check to see if we are building a debug root
1476
1477         * Scripts/check-for-global-initializers: 
1478
1479 2007-12-03  Dan Bernstein  <mitz@apple.com>
1480
1481         Reviewed by Darin Adler.
1482
1483         - added a testGetIntIdentifier() method to TestNetscapePlugIn
1484
1485         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
1486         (pluginInvoke):
1487
1488 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
1489
1490         Reviewed by Oliver.
1491
1492         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
1493         in a more fine-grained manner than eventSender.keyDown().
1494
1495         * DumpRenderTree/win/EventSender.cpp:
1496         (getConstantCallback):
1497         (dispatchMessageCallback):
1498
1499 2007-12-02  Darin Adler  <darin@apple.com>
1500
1501         * Scripts/do-webcore-rename: More planned renaming.
1502
1503 2007-12-02  Sam Weinig  <sam@webkit.org>
1504
1505         Rubber stamped by Anders.
1506
1507         Use [NSURL absoluteString] instead of [NSURL description] in order to get
1508         more uniform results cross platform.
1509
1510         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1511         (-[NSURL _drt_descriptionSuitableForTestResult]):
1512
1513 2007-12-02  Sam Weinig  <sam@webkit.org>
1514
1515         Rubber stamped by Niko.
1516
1517         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
1518
1519         * DumpRenderTree/win/DumpRenderTree.cpp:
1520         * DumpRenderTree/win/DumpRenderTree.vcproj:
1521         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
1522         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
1523         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
1524         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
1525
1526 2007-12-01  Alp Toker  <alp@atoker.com>
1527
1528         Reviewed by Adam Roben.
1529
1530         Make use of the newly introduced webkit.h convenience header.
1531
1532         * GtkLauncher/main.c:
1533
1534 2007-12-01  Adam Treat  <treat@kde.org>
1535
1536         Reviewed by Simon.
1537
1538         * Check to see if the directory exists and exit if not.
1539
1540         * DumpRenderTree/qt/main.cpp:
1541         (main):
1542
1543 2007-12-01  Adam Treat  <treat@kde.org>
1544
1545         Reviewed by Simon.
1546
1547         * Don't hide symbols when in Debug mode
1548         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
1549
1550
1551         * DumpRenderTree/qt/main.cpp:
1552         (messageHandler):
1553
1554 2007-11-30  Alp Toker  <alp@atoker.com>
1555
1556         Reviewed by Adam Roben.
1557
1558         http://bugs.webkit.org/show_bug.cgi?id=15691
1559         [GTK] Public API does not follow GTK+ conventions
1560
1561         Refactor the WebKit/GTK+ public API. Changes:
1562           WebKitPage -> WebKitWebView
1563           WebKitFrame -> WebKitWebFrame
1564
1565         Public API source and header names have been updated to mirror the API
1566         changes.
1567
1568         The API is now kept in WebKit/gtk/WebView to match other ports in the
1569         same class such as Mac and Win.
1570
1571         * GtkLauncher/main.c:
1572         (activate_uri_entry_cb):
1573         (link_hover_cb):
1574         (title_change_cb):
1575         (progress_change_cb):
1576         (go_back_cb):
1577         (go_forward_cb):
1578         (create_browser):
1579         (main):
1580
1581 2007-11-30  Adam Roben  <aroben@apple.com>
1582
1583         Hopefully the final build fix
1584
1585         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
1586         pull in WTF's assertion/logging functions.
1587
1588 2007-11-30  Adam Roben  <aroben@apple.com>
1589
1590         Another build fix
1591
1592         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
1593         WebKit.lib.
1594
1595 2007-11-30  Adam Roben  <aroben@apple.com>
1596
1597         Debug build fix
1598
1599         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
1600         configuration.
1601         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
1602         projects.
1603         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
1604         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
1605         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
1606
1607 2007-11-30  Sam Weinig  <sam@webkit.org>
1608
1609         Reviewed by Adam Roben.
1610
1611         Fix drawSelectionRect to actually draw the selection rect.
1612
1613         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1614         (drawSelectionRect):
1615
1616 2007-11-30  Darin Adler  <darin@apple.com>
1617
1618         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
1619
1620 2007-11-30  Darin Adler  <darin@apple.com>
1621
1622         * Scripts/do-webcore-rename: Get ready for some future renaming.
1623
1624 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1625
1626         Reviewed by Adam.
1627
1628         - Removed some unnecessary functions and changed an unused return type. 
1629
1630         * Drosera/win/DebuggerClient.cpp:
1631         (registerConsoleClass):
1632         * Drosera/win/DebuggerClient.h:
1633         * Drosera/win/Drosera.cpp:
1634         (registerDroseraClass):
1635
1636 2007-11-28  Alp Toker  <alp@atoker.com>
1637
1638         Reviewed by Timothy Hatcher.
1639
1640         http://bugs.webkit.org/show_bug.cgi?id=16174
1641         [GTK] Use "URI" not "URL" in public API
1642
1643         Replace use of the term "URL" with "URI" in public headers,
1644         documentation and some internal code to match GLib/GTK+ convention.
1645
1646         This is now mentioned in the API guidelines:
1647           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
1648
1649         * GtkLauncher/main.c:
1650         (activate_uri_entry_cb):
1651         (title_change_cb):
1652         (create_toolbar):
1653         (main):
1654
1655 2007-11-29  Anders Carlsson  <andersca@apple.com>
1656
1657         Reviewed by Sam.
1658
1659         <rdar://problem/5230478>
1660         FrameLoadDelegate callbacks are not dumped in DRT.
1661         
1662         * DumpRenderTree/win/DumpRenderTree.cpp:
1663         (shouldLogFrameLoadDelegates):
1664         (runTest):
1665         (main):
1666         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
1667         (BSTRtoString):
1668         (descriptionSuitableForTestResult):
1669         (FrameLoadDelegate::QueryInterface):
1670         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
1671         (FrameLoadDelegate::didFailProvisionalLoadWithError):
1672         (FrameLoadDelegate::didCommitLoadForFrame):
1673         (FrameLoadDelegate::didFinishLoadForFrame):
1674         (FrameLoadDelegate::willCloseFrame):
1675         (FrameLoadDelegate::didClearWindowObject):
1676         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
1677         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
1678         * DumpRenderTree/win/FrameLoaderDelegate.h:
1679         (FrameLoadDelegate::windowScriptObjectAvailable):
1680         (FrameLoadDelegate::didFirstLayoutInFrame):
1681
1682 2007-11-29  Sam Weinig  <sam@webkit.org>
1683
1684         Reviewed by Anders.
1685
1686         Add database quota UIDelegates methods to DRT UIDelegate.
1687
1688         * DumpRenderTree/mac/UIDelegate.mm:
1689         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1690         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
1691
1692 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1693
1694         Reviewed by Sam.
1695
1696         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
1697         dying and vice versa.
1698         - This fix will allow Drosera and Safari to reconnect if either of them
1699         closes correctly, but does not fix the case where one of them dies
1700         silently.
1701
1702         * Drosera/win/ServerConnection.cpp:
1703         (ServerConnection::attemptToCreateServerConnection): Added a safety
1704         check, because it's possilbe to try to connect to a server that's dying.
1705         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
1706         the server has died.
1707         * Drosera/win/ServerConnection.h: Added the new function and removed
1708         an unnecessary member.
1709
1710 2007-11-29  Anders Carlsson  <andersca@apple.com>
1711
1712         * DumpRenderTree/win/DumpRenderTree.vcproj:
1713         Add shlwapi.lib to all configurations.
1714
1715 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1716
1717         - Build fix.  Added additional includes for VS Express to the Release
1718         project.
1719
1720         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1721
1722 2007-11-29  Anders Carlsson  <andersca@apple.com>
1723
1724         Reviewed by Adam.
1725
1726         <rdar://problem/5132005>
1727         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
1728         
1729         * DumpRenderTree/win/DumpRenderTree.vcproj:
1730         Add shlwapi.lib
1731         
1732         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1733         (LayoutTestController::setUserStyleSheetEnabled):
1734         Implement this.
1735         
1736         (appendComponentToPath):
1737         New method which wraps the Win32 API PathAppend.
1738         
1739         (followShortcuts):
1740         New method which checks if a file points to a shortcut and
1741         follows the shortcut.
1742         
1743         (resolveCygwinPath):
1744         New method that takes a cygwin unix-style path and returns the Win32 path.
1745         
1746         (cfStringRefToWString):
1747         
1748         (LayoutTestController::setUserStyleSheetLocation):
1749         Implement this.
1750
1751 2007-11-29  Alice Liu  <alice.liu@apple.com>
1752
1753         Reviewed by Adam.
1754
1755         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
1756
1757         * DumpRenderTree/win/EventSender.cpp:
1758         (keyDownCallback):
1759         uppercase letters were being sent as lowercase letters without the shift key down.
1760
1761 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1762
1763         - Windows build fix. VS express needs some love.
1764
1765         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1766
1767 2007-11-28  Darin Adler  <darin@apple.com>
1768
1769         Reviewed by Adam Roben.
1770
1771         * DumpRenderTree/mac/EventSendingController.mm:
1772         (-[EventSendingController keyDown:withModifiers:]):
1773         Send capital letters through as lowercase letters with the shift key down
1774         rather than sending them as if they were highly unusual "capital letter keys".
1775
1776         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
1777         where you need to update results and more tests are failing than before.
1778
1779 2007-11-28  Anders Carlsson  <andersca@apple.com>
1780
1781         Reviewed by Darin.
1782
1783         <rdar://problem/5132001>
1784         contextClick is not implemented in DRT on Windows.
1785         
1786         * DumpRenderTree/win/EventSender.cpp:
1787         (contextClickCallback):
1788         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
1789         by a WM_RBUTTONUP message.
1790         
1791         * DumpRenderTree/win/UIDelegate.cpp:
1792         (UIDelegate::hasCustomMenuImplementation):
1793         (UIDelegate::trackCustomPopupMenu):
1794         * DumpRenderTree/win/UIDelegate.h:
1795         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
1796         menu from being shown (and causing the DRT to hang).
1797
1798 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
1799
1800         Reviewed by Darin.
1801
1802         Fix DumpRenderTree ObjC bug comparing strings.
1803
1804         * DumpRenderTree/mac/ObjCController.m:
1805         (-[ObjCController identityIsEqual::]): Compare strings with string
1806         equality instead of identiy equality.
1807
1808 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1809
1810         Reviewed by Sam.
1811
1812         Reset the authorAndUserStylesEnabled preference
1813         back to YES for each test. Fixes the broken tests.
1814
1815         * DumpRenderTree/mac/DumpRenderTree.mm:
1816         (resetWebViewToConsistentStateBeforeTesting):
1817
1818 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
1819
1820         Reviewed by Adam.
1821
1822         - Drosera now displays the console window, although it cannot currently
1823         process JavaScript.
1824
1825         * Drosera/win/DebuggerClient.cpp: Shows the console window.
1826         (registerConsoleClass): Implemented.
1827         (consoleWndProc): Implemented.
1828         (DebuggerClient::onSize): Implemented.
1829         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
1830         new window.
1831         * Drosera/win/DebuggerClient.h: Added needed method and members for 
1832         creating and maintaining a new window.
1833         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
1834         lines of code to more appropriate places.
1835         (Drosera::handleCommand):
1836         (Drosera::initUI):
1837         (Drosera::onSize):
1838         (Drosera::attach):
1839
1840 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1841
1842         Reviewed by Dave Hyatt.
1843
1844         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
1845         
1846         Add support for disabling author and user styles for testing.
1847
1848         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1849         * DumpRenderTree/LayoutTestController.cpp:
1850         (setAuthorAndUserStylesEnabledCallback):
1851         (LayoutTestController::staticFunctions):
1852         * DumpRenderTree/LayoutTestController.h:
1853         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1854         (LayoutTestController::setAuthorAndUserStylesEnabled):
1855         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1856         (LayoutTestController::setAuthorAndUserStylesEnabled):
1857
1858 2007-11-26  Dan Bernstein  <mitz@apple.com>
1859
1860         - Tiger build fix.
1861
1862         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1863
1864 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
1865
1866         Reviewed by Maciej.
1867
1868         - Implemented displaying variables for Drosera on Win.
1869
1870         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
1871         that retrieve variables to not hold onto the return value since it's
1872         not returned.  Also changed to use the new signatures of the retrieval
1873         functions.
1874         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1875         (DebuggerDocument::platformValueForScopeVariableNamed):
1876         * Drosera/win/Drosera.cpp: Removed a needless TODO.
1877         (droseraWndProc):
1878
1879 2007-11-26  Sam Weinig  <sam@webkit.org>
1880
1881         Cleanup names of painting and repainting functions.
1882
1883         Reviewed by Adam Roben.
1884
1885         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1886         (drawSelectionRect): was drawSelectionRectIntoContext.
1887         (dumpWebViewAsPixelsAndCompareWithExpected):
1888         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1889         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1890         (paintWebView): was drawWebViewIntoContext.
1891         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
1892
1893 2007-11-26  Sam Weinig  <sam@webkit.org>
1894
1895         Reviewed by Dan Bernstein.
1896
1897         - Leopard build fix
1898
1899         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1900
1901 2007-11-26  Sam Weinig  <sam@webkit.org>
1902
1903         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
1904         Use shared PixelDumpSupport for Mac DRT
1905
1906         Reviewed by Adam Roben.
1907
1908         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1909         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
1910         * DumpRenderTree/cg/ImageDiffCG.cpp:
1911         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1912         (drawSelectionRectIntoContext):
1913         (dumpWebViewAsPixelsAndCompareWithExpected):
1914         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1915         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1916         * DumpRenderTree/mac/DumpRenderTree.mm:
1917         (dump):
1918         * DumpRenderTree/mac/ImageDiff.m: Removed.
1919         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
1920         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
1921         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
1922         (setDefaultColorProfileToRGB):
1923         (getBitmapContextFromWebView):
1924         (drawWebViewIntoContext):
1925         (repaintWithVerticalSweep):
1926         (repaintWithHorizontalSweep):
1927         (getSelectionRect):
1928         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
1929
1930 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
1931
1932         Bug 16052: prepare-ChangeLog doesn't report deleted files
1933         <http://bugs.webkit.org/show_bug.cgi?id=16052>
1934
1935         Reviewed by Sam.
1936
1937         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
1938
1939 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
1940
1941         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
1942         <http://bugs.webkit.org/show_bug.cgi?id=15864>
1943
1944         Reviewed by Adam.
1945
1946         Roll functionality of merge-changelog into resolve-ChangeLogs
1947         script.  The script now checks for ChangeLog.rej and
1948         ChangeLog.orig files first.  If it finds them, it uses the
1949         ChangeLog.rej file as a patch (in old contextual diff format) to
1950         apply with --fuzz=3.
1951
1952         * Scripts/merge-changelog: Removed.
1953         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
1954
1955 2007-11-25  Sam Weinig  <sam@webkit.org>
1956
1957         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
1958
1959         Reviewed by Mark Rowe.
1960
1961         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1962         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1963         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1964         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
1965         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
1966
1967 2007-11-25  Sam Weinig  <sam@webkit.org>
1968
1969         Convert DumpRenderTree to ues .xcconfig files.
1970
1971         Reviewed by Mark Rowe.
1972
1973         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1974         * DumpRenderTree/mac/Configurations: Added.
1975         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
1976         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
1977         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
1978
1979 2007-11-25  Sam Weinig  <sam@webkit.org>
1980
1981         Add ForwardingHeaders to wtf for DumpRenderTree.
1982
1983         Reviewed by Mark Rowe.
1984
1985         * DumpRenderTree/DumpRenderTree.h:
1986         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1987         * DumpRenderTree/ForwardingHeaders: Added.
1988         * DumpRenderTree/ForwardingHeaders/wtf: Added.
1989         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
1990         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
1991         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
1992         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
1993         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
1994         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
1995         * DumpRenderTree/LayoutTestController.cpp:
1996         * DumpRenderTree/WorkQueue.cpp:
1997         * DumpRenderTree/mac/DumpRenderTree.mm:
1998         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1999         * DumpRenderTree/mac/JavaScriptThreading.cpp:
2000         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2001         * DumpRenderTree/mac/ObjCController.m:
2002         * DumpRenderTree/mac/UIDelegate.mm:
2003         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2004
2005 2007-11-25  Adam Roben  <aroben@apple.com>
2006
2007         Fix some test failures caused by r28019
2008
2009         Now that stdout is in binary mode, we need to always use printf
2010         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
2011         the output.
2012
2013         Reviewed by Sam.
2014
2015         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
2016         printf.
2017         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2018         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2019         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2020         (UIDelegate::webViewAddMessageToConsole):
2021
2022 2007-11-25  Adam Roben  <aroben@apple.com>
2023
2024         Set the font smoothing preference in DRT
2025
2026         This makes the pixel results on Windows closer to the Mac results.
2027
2028         Reviewed by Mitz.
2029
2030         * DumpRenderTree/win/DumpRenderTree.cpp:
2031         (initializePreferences):
2032
2033 2007-11-25  Adam Roben  <aroben@apple.com>
2034
2035         Port ImageDiff to CG and C++
2036
2037         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
2038         <rdar://5071708>
2039
2040         Reviewed by Sam.
2041
2042         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
2043         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
2044         (main):
2045         (createImageFromStdin):
2046         (compareImages):
2047         (getDifferenceBitmap):
2048         (computePercentageDifferent):
2049         * DumpRenderTree/win/ImageDiff.vcproj: Added.
2050
2051 2007-11-25  Adam Roben  <aroben@apple.com>
2052
2053         Fix image diff link generation on Windows
2054
2055         Reviewed by Sam.
2056
2057         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
2058         to toURL.
2059
2060 2007-11-25  Adam Roben  <aroben@apple.com>
2061
2062         Implement pixel dumping in Windows DRT
2063
2064         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
2065         <rdar://5071708>
2066
2067         Reviewed by Sam.
2068
2069         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
2070         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
2071         Content-Length header.
2072         (getMD5HashStringForBitmap):
2073         (dumpWebViewAsPixelsAndCompareWithExpected):
2074         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
2075         * DumpRenderTree/win/DumpRenderTree.cpp:
2076         (dump): Do a pixel dump if requested.
2077         (main): Parse pixel test options.
2078         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
2079         the cg/ subdirectory to the include path.
2080         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
2081         available in a header or import library, so we have to go through this
2082         LoadLibrary/GetProcAddress dance to use them.
2083         (cryptDLL):
2084         (init):
2085         (update):
2086         (final):
2087         (MD5_Init):
2088         (MD5_Update):
2089         (MD5_Final):
2090         * DumpRenderTree/win/MD5.h: Added.
2091         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
2092         moved up to the top level to share it with Mac eventually.
2093         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
2094         (getBitmapContextFromWebView): Forces the WebView to paint using a
2095         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
2096
2097 2007-11-25  Adam Roben  <aroben@apple.com>
2098
2099         Clean up Windows DRT's option parsing a little bit
2100
2101         Reviewed by Sam.
2102
2103         * DumpRenderTree/win/DumpRenderTree.cpp:
2104         (main): Put non-option arguments into a Vector.
2105
2106 2007-11-25  Adam Roben  <aroben@apple.com>
2107
2108         Make Windows DRT stop changing LF into CRLF
2109
2110         Reviewed by Sam.
2111
2112         * DumpRenderTree/win/DumpRenderTree.cpp:
2113         (main): Put stdout in binary mode.
2114         * Scripts/run-webkit-tests: Remove the CRLF hack.
2115
2116 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
2117
2118         Removed empty directory.
2119
2120         * Scripts/resources: Removed.
2121
2122 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
2123
2124         Fix bisect-builds to work with recent WebKit nightly builds.
2125
2126         Reviewed by Dan.
2127
2128         * Scripts/bisect-builds: Check for the 
2129         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
2130         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
2131         to WebKit.app/Contents/Resources.
2132
2133 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
2134
2135         Reviewed by Maciej.
2136
2137         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
2138         not closed (affects digg.com)
2139
2140         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
2141         one after finishing with a test to avoid having its delayed onload handler firing when
2142         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
2143         but it helps somewhat.
2144
2145 2007-11-22  Mark Rowe  <mrowe@apple.com>
2146
2147         Reviewed by Alp Toker.
2148
2149         Fix build-webkit to propagate make's exit status if it fails.
2150
2151         * Scripts/webkitdirs.pm:
2152
2153 2007-11-22  Dan Bernstein  <mitz@apple.com>
2154
2155         Reviewed by Mark Rowe.
2156
2157         - fix crash when running pixel tests
2158
2159         * DumpRenderTree/mac/DumpRenderTree.mm:
2160         (dumpRenderTree): Parse the command line options before setting up the
2161         environment so that we know if we need to set up the pixel dump
2162         machinery.
2163
2164 2007-11-21  Eric Seidel  <eric@webkit.org>
2165
2166         Speculative build fix for Tiger.
2167
2168         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
2169
2170 2007-11-21  Eric Seidel  <eric@webkit.org>
2171
2172         Reviewed by Tim Hatcher.
2173
2174         Break out more of DumpRenderTree.mm into individual files
2175
2176         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2177         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
2178         (checkedMalloc):
2179         (checkedRealloc):
2180         (makeLargeMallocFailSilently):
2181         * DumpRenderTree/mac/CheckedMalloc.h: Added.
2182         * DumpRenderTree/mac/DumpRenderTree.mm:
2183         (crashHandler):
2184         (dump):
2185         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2186         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2187         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2188         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2189         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2190         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
2191         (javaScriptThreads):
2192         (runJavaScriptThread):
2193         (startJavaScriptThreads):
2194         (stopJavaScriptThreads):
2195         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
2196         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
2197         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
2198         (restoreColorSpace):
2199         (setDefaultColorProfileToRGB):
2200         (initializeColorSpaceAndScreeBufferForPixelTests):
2201         (md5HashStringForBitmap):
2202         (dumpWebViewAsPixelsAndCompareWithExpected):
2203
2204 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
2205
2206         Move install-unix-extras to wx directory as it seems only to be used by that 
2207         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
2208         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
2209         have install-unix-extras install into WebKitLibraries as per
2210         convention.
2211         
2212         Reviewed by Mark Rowe.
2213
2214         * Scripts/install-unix-extras: Removed.
2215         * wx/build-wxwebkit:
2216         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
2217
2218 2007-11-21  Eric Seidel  <eric@webkit.org>
2219
2220         Reviewed by Adam.
2221
2222         More refactoring for greater code readability
2223
2224         * DumpRenderTree/mac/DumpRenderTree.mm:
2225         (initializeGlobalsFromCommandLineOptions):
2226         (initializeColorSpaceAndScreeBufferForPixelTests):
2227         (addTestPluginsToPluginSearchPath):
2228         (useLongRunningServerMode):
2229         (runTestingServerLoop):
2230         (prepareConsistentTestingEnvironment):
2231         (dumpRenderTree):
2232         (main):
2233         (dumpFramesAsText):
2234         (dumpBackForwardListForWebView):
2235         (sizeWebViewForCurrentTest):
2236         (methodNameStringForFailedTest):
2237         (dumpBackForwardListForAllWindows):
2238         (dumpWebViewAsPixelsAndCompareWithExpected):
2239         (invalidateAnyPreviousWaitToDumpWatchdog):
2240         (dump):
2241         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2242         * DumpRenderTree/mac/UIDelegate.mm:
2243         (-[UIDelegate webView:createWebViewWithRequest:]):
2244
2245 2007-11-21  Eric Seidel  <eric@webkit.org>
2246
2247         Reviewed by Tim Hatcher.
2248
2249         Abstract more of DRT into static methods
2250
2251         * DumpRenderTree/mac/DumpRenderTree.mm:
2252         (setDefaultsToConsistentValuesForTesting):
2253         (setupSignalHandlers):
2254         (allocateGlobalControllers):
2255         (releaseAndZero):
2256         (releaseGlobalControllers):
2257         (dumpRenderTree):
2258         (shouldLogFrameLoadDelegates):
2259         (createCFURLFromPathOrURL):
2260         (resetWebViewToConsistentStateBeforeTesting):
2261         (runTest):
2262
2263 2007-11-21  Eric Seidel  <eric@webkit.org>
2264
2265         Reviewed by Tim Hatcher.
2266
2267         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
2268
2269         * DumpRenderTree/DumpRenderTree.h:
2270         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2271         * DumpRenderTree/mac/DumpRenderTree.mm:
2272         (dumpRenderTree):
2273         (dump):
2274         (runTest):
2275         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
2276         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
2277         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
2278         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
2279         (-[DumpRenderTreePasteboard declareType:owner:]):
2280         (+[LocalPasteboard alloc]):
2281         (-[LocalPasteboard init]):
2282         (-[LocalPasteboard dealloc]):
2283         (-[LocalPasteboard name]):
2284         (-[LocalPasteboard releaseGlobally]):
2285         (-[LocalPasteboard declareTypes:owner:]):
2286         (-[LocalPasteboard addTypes:owner:]):
2287         (-[LocalPasteboard changeCount]):
2288         (-[LocalPasteboard types]):
2289         (-[LocalPasteboard availableTypeFromArray:]):
2290         (-[LocalPasteboard setData:forType:]):
2291         (-[LocalPasteboard dataForType:]):
2292         (-[LocalPasteboard setPropertyList:forType:]):
2293         (-[LocalPasteboard setString:forType:]):
2294         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
2295         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
2296         (+[DumpRenderTreeWindow allWindows]):
2297         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
2298         (-[DumpRenderTreeWindow dealloc]):
2299         (-[DumpRenderTreeWindow isKeyWindow]):
2300         (-[DumpRenderTreeWindow keyDown:]):
2301
2302 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
2303
2304         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
2305         it indiscriminately copies any headers inside JavaScriptCore,
2306         which includes Tiger ICU headers. 
2307
2308         * wx/build-wxwebkit:
2309         Don't run WebCore/move-js-headers.sh any longer.
2310
2311 2007-11-20  Adam Treat  <treat@kde.org>
2312
2313         Reviewed by David Kilzer.
2314
2315         * Prepend git branch name to $baseProductDir
2316
2317         * Scripts/VCSUtils.pm:
2318         * Scripts/webkitdirs.pm:
2319
2320 2007-11-20  Mark Rowe  <mrowe@apple.com>
2321
2322         Reviewed by Simon Hausmann.
2323
2324         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
2325         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
2326         Have it trigger a "make distclean" rather than "make clean" to ensure that the
2327         built product and generated Makefile's are removed.
2328
2329 2007-11-19  Alp Toker  <alp@atoker.com>
2330
2331         Reviewed by Mark Rowe.
2332
2333         http://bugs.webkit.org/show_bug.cgi?id=16040
2334         [GTK] GtkLauncher should be written in C
2335
2336         Port GtkLauncher to plain C.
2337
2338         Use a more conventional GTK+ coding style.
2339
2340         Use a toolbar instead of menus.
2341
2342         Various signature fixes and cleanups.
2343
2344         Add a license header. Assume all previous modifications were copyright
2345         assigned to Apple Inc. by default.
2346
2347         * GtkLauncher/GtkLauncher.pro:
2348         * GtkLauncher/main.c: Added.
2349         (activate_url_entry_cb):
2350         (update_title):
2351         (link_hover_cb):
2352         (title_change_cb):
2353         (progress_change_cb):
2354         (destroy_cb):
2355         (go_back_cb):
2356         (go_forward_cb):
2357         (create_browser):
2358         (create_statusbar):
2359         (create_toolbar):
2360         (create_window):
2361         (main):
2362         * GtkLauncher/main.cpp: Removed.
2363
2364 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
2365
2366         Build script fixes to ensure they do the right thing for the 
2367         wx port, and update build-wxwebkit to reflect the way the
2368         build scripts now work.
2369
2370         Reviewed by Adam.
2371
2372         * Scripts/build-testkjs:
2373         * Scripts/build-webkit:
2374         * Scripts/run-javascriptcore-tests:
2375         * Scripts/webkitdirs.pm:
2376         * wx/build-wxwebkit:
2377
2378 2007-11-18  Eric Seidel  <eric@webkit.org>
2379
2380         Reviewed by Anders.
2381
2382         Make run-javascriptcore-tests report failures on exit (to support git bisect)
2383
2384         * Scripts/run-javascriptcore-tests:
2385
2386 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
2387
2388         Reviewed by Adam Roben.
2389
2390         Make run-webkit-tests work with Windows debug build.
2391
2392         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
2393         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
2394         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
2395         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
2396         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
2397
2398 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
2399
2400         Add wxWebKit sample and build script, and integrate it with 
2401         build-webkit. Also make build-webkit --clean work for all
2402         ports.
2403
2404         Reviewed by Darin Adler.
2405
2406         * Scripts/build-webkit:
2407         * Scripts/webkitdirs.pm:
2408         * wx: Added.
2409         * wx/browser: Added.
2410         * wx/browser/browser.bkl: Added.
2411         * wx/browser/browser.cpp: Added.
2412         * wx/build-wxwebkit: Added.
2413
2414 2007-11-17  Adam Roben  <aroben@apple.com>
2415
2416         Make it easy to run Safari in the debugger on Windows
2417
2418         I've added a new script, debug-safari, which launches Safari in the
2419         debugger. On OS X it just calls gdb-safari.
2420
2421         Reviewed by Mark Rowe.
2422
2423         * FindSafari/FindSafari.cpp:
2424         (_tmain): Added a /debugger flag, which in combination with
2425         /printSafariLauncher will print a script that launches Safari in the
2426         debugger.
2427         * Scripts/debug-safari: Added.
2428         * Scripts/run-safari: Changed to call runSafari().
2429         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
2430         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
2431         first argument along to FindSafari.
2432         * Scripts/webkitdirs.pm:
2433         (sub runSafari): Added.
2434
2435 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
2436
2437         Reviewed by Adam Roben.
2438
2439         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
2440
2441 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
2442
2443         Reviewed by David Kilzer.
2444
2445         The git config command was renamed to repo-config at some point. This
2446         change tries git config and then git repo-config if the first fails.
2447
2448         * Scripts/prepare-ChangeLog:
2449         (gitConfig):
2450
2451 2007-11-16  Dan Bernstein  <mitz@apple.com>
2452
2453         Reviewed by Darin Adler and Sam Weinig.
2454
2455         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
2456
2457         * DumpRenderTree/win/EventSender.cpp:
2458         (keyDownCallback): For characters that cannot be entered on the active
2459         keyboard layout, send a WM_CHAR message with the character along with
2460         a WM_KEYDOWN message with a virtual key code of 255.
2461
2462 2007-11-16  Mark Rowe  <mrowe@apple.com>
2463
2464         Reviewed by Tim Hatcher.
2465
2466         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
2467
2468         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2469         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2470
2471 2007-11-15  Adam Roben  <aroben@apple.com>
2472
2473         Make run-safari actually work on Windows
2474
2475         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
2476         chdir call.
2477
2478 2007-11-14  Adam Roben  <aroben@apple.com>
2479
2480         Updates to Safari launching now that 3.0.4 is released
2481
2482         Reviewed by Sam.
2483
2484         * FindSafari/FindSafari.cpp:
2485         (getWebViewCLSID): Use version-independent ProgID.
2486         * Scripts/run-safari: Use run-webkit-nightly.cmd.
2487
2488 2007-11-14  Anders Carlsson  <andersca@apple.com>
2489
2490         Reviewed by Adam.
2491
2492         <rdar://problem/5309081>
2493         In DRT, "plugin.logDestroy = true" not working on Windows.
2494         
2495         * DumpRenderTree/win/TestNetscapePlugin/main.c:
2496         (NPP_Destroy):
2497
2498 2007-11-14  Eric Seidel  <eric@webkit.org>
2499
2500         Reviewed by Sam.
2501
2502         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
2503
2504 2007-11-14  Anders Carlsson  <andersca@apple.com>
2505
2506         Reviewed by Adam.
2507
2508         <rdar://problem/5141186>
2509         window.layoutTestController.setWindowIsKey is not implemented in DRT.
2510         
2511         Implement setWindowIsKey.
2512         
2513         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2514         (LayoutTestController::setWindowIsKey):
2515
2516 2007-11-13  Sam Weinig  <sam@webkit.org>
2517
2518         Reviewed by Adam Roben.
2519
2520         Fix for <rdar://problem/5382579>
2521         http/tests/security/cross-frame-access-put.html reports large 
2522         negative numbers for screenLeft and screenTop (Mac reports "0")
2523
2524         * DumpRenderTree/win/UIDelegate.cpp:
2525         (UIDelegate::UIDelegate): Initialize the RECT.
2526         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
2527         (UIDelegate::webViewFrame): ditto.
2528         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
2529
2530 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
2531
2532         Reviewed by Adam.
2533
2534         - Make Drosera show source, source URLs, and function stack on Windows,
2535         and some minor fixes.
2536
2537         * Drosera/DebuggerDocument.cpp: Force source to always update display.
2538         (DebuggerDocument::updateFileSource):
2539         * Drosera/debugger.js: Force source to always update display.
2540         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
2541         menu controls.
2542         (DebuggerClient::resume):
2543         (DebuggerClient::pause):
2544         (DebuggerClient::stepInto):
2545         (DebuggerClient::stepOver):
2546         (DebuggerClient::stepOut):
2547         (DebuggerClient::showConsole):
2548         (DebuggerClient::closeCurrentFile):
2549         * Drosera/win/DebuggerClient.h: Ditto.
2550         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
2551         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
2552         removed two bugs.  1) caller could be in a bad state when asked to
2553         assign into it. 2) BSTRs were not created correctly.
2554         (DebuggerDocument::getPlatformCurrentFunctionStack):
2555         * Drosera/win/Drosera.cpp: Hook up the menu controls.
2556         (droseraWndProc):
2557         (handleCommand):
2558         (Drosera::resume):
2559         (Drosera::pause):
2560         (Drosera::stepInto):
2561         (Drosera::stepOver):
2562         (Drosera::stepOut):
2563         (Drosera::showConsole):
2564         (Drosera::closeCurrentFile):
2565         * Drosera/win/Drosera.h: Hook up the menu controls.
2566         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
2567         functions, added a null check, and fixed another bug where caller could
2568         be in a bad state when asked to assign into it.
2569         (ServerConnection::didLoadMainResourceForDataSource):
2570         (ServerConnection::getCallerFrame):
2571         * Drosera/win/ServerConnection.h: Safety first.
2572
2573 2007-11-13  Dan Bernstein  <mitz@apple.com>
2574
2575         Reviewed by Darin Adler.
2576
2577         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
2578           DumpRenderTree --pixel-tests renders each test twice
2579
2580         * DumpRenderTree/mac/DumpRenderTree.mm:
2581         (dumpRenderTree): Removed the --paint option because the painting code
2582         is always exercised as a result of
2583         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
2584         calling -displayIfNeeded.
2585         (dump): Changed to always grab the image from the window since the view
2586         is always displayed.
2587         (runTest):
2588         (displayWebView):
2589         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
2590         because it always paints.
2591
2592 2007-11-12  Antti Koivisto  <antti@apple.com>
2593
2594         Reviewed by Adele.
2595         
2596         Add support for http media tests
2597
2598         * Scripts/run-webkit-tests:
2599
2600 2007-11-12  Sam Weinig  <sam@webkit.org>
2601
2602         Reviewed by Adam Roben.
2603
2604         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
2605
2606         * DumpRenderTree/win/DumpRenderTree.cpp:
2607         (runTest):
2608         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2609         (LayoutTestController::setPrivateBrowsingEnabled):
2610
2611 2007-11-12  Adam Roben  <aroben@apple.com>
2612
2613         * Scripts/update-webkit-localizable-strings: Changed to only scan the
2614         mac and win subdirectories.
2615
2616 2007-11-11  Adam Roben  <aroben@apple.com>
2617
2618         Fix <rdar://5133816> keepWebHistory is not implemented
2619
2620         Fixes fast/history/clicked-link-is-visited.html.
2621
2622         Reviewed by Darin.
2623
2624         * DumpRenderTree/win/DumpRenderTree.cpp:
2625         (runTest): Clear the optionalSharedHistory.
2626         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2627         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
2628
2629 2007-11-10  Sam Weinig  <sam@webkit.org>
2630
2631         Reviewed by Tim Hatcher.
2632
2633         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
2634         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
2635         is turned on)
2636
2637         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
2638
2639         Added test: http/tests/security/cross-frame-access-private-browsing.html
2640
2641         * DumpRenderTree/LayoutTestController.cpp:
2642         (setPrivateBrowsingEnabledCallback):
2643         (LayoutTestController::staticFunctions):
2644         * DumpRenderTree/LayoutTestController.h:
2645         * DumpRenderTree/mac/DumpRenderTree.mm:
2646         (runTest): Default to private browsing disabled.
2647         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2648         (LayoutTestController::setPrivateBrowsingEnabled):
2649         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2650         (LayoutTestController::setPrivateBrowsingEnabled):
2651
2652 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2653
2654         Reviewed by Adam.
2655
2656         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
2657         WebCore's!
2658
2659         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
2660         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
2661         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
2662         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
2663         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
2664         * Drosera/win/Drosera.cpp:
2665         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2666
2667 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2668
2669         Reviewed by Sam.
2670
2671         - Use the new IWebFrame [local] function signature and get the shared
2672         server correctly.
2673
2674         * Drosera/win/DebuggerClient.cpp:
2675         (DebuggerClient::didFinishLoadForFrame):
2676         * Drosera/win/ServerConnection.cpp:
2677         (ServerConnection::attemptToCreateServerConnection):
2678
2679 2007-11-07  Dan Bernstein  <mitz@apple.com>
2680
2681         Reviewed by Darin Adler.
2682
2683         - add an option to run-webkit-tests to ignore pixel test failures where
2684           all pixels differ by no more than a specified threshold
2685
2686         * DumpRenderTree/mac/ImageDiff.m:
2687         (main):
2688         (compareImages):
2689         (computePercentageDifferent):
2690         * Scripts/run-webkit-tests:
2691
2692 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2693
2694         Reviewed by Lars.
2695
2696         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
2697
2698         * DumpRenderTree/qt/DumpRenderTree.cpp:
2699
2700 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2701
2702         Reviewed by Lars.
2703
2704         Reworked the QWebSettings API.
2705         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
2706
2707         * DumpRenderTree/qt/DumpRenderTree.cpp:
2708
2709 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2710
2711         Reviewed by Lars.
2712
2713         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
2714
2715         * DumpRenderTree/qt/jsobjects.cpp:
2716
2717 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2718
2719         Reviewed by Lars Knoll <lars@trolltech.com>.
2720
2721         Add a QWebPage::frameCreated() signal and fix DRT
2722         
2723         The removal of createFrame in QWebPage broke the re-implementation
2724         in DumpRenderTree. Instead emit a frameCreated() signal and
2725         connect to it in DumpRenderTree.
2726         
2727
2728         * DumpRenderTree/qt/DumpRenderTree.cpp:
2729         (WebCore::WebPage::WebPage):
2730         (WebCore::DumpRenderTree::dump):
2731         (WebCore::DumpRenderTree::connectFrame):
2732         * DumpRenderTree/qt/DumpRenderTree.h:
2733
2734 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2735
2736         Reviewed by Lars Knoll <lars@trolltech.com>.
2737
2738         Moved all the event handlers from QWebFrame into QWebPage.
2739         
2740         This cleans up the public API and allows us to remove the
2741         HackWebFrame hack in DumpRenderTree.
2742         
2743
2744         * DumpRenderTree/qt/jsobjects.cpp:
2745         (EventSender::mouseDown):
2746         (EventSender::mouseUp):
2747         (EventSender::mouseMoveTo):
2748
2749 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2750
2751         Reviewed by Mark.
2752
2753         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
2754         to prevent the default implementation from popping up messageboxes.
2755
2756         * DumpRenderTree/qt/DumpRenderTree.cpp:
2757         (WebCore::WebPage::javaScriptConfirm):
2758         (WebCore::WebPage::javaScriptPrompt):
2759
2760 2007-11-06  Eric Seidel  <eric@webkit.org>
2761
2762         * Scripts/build-testkjs: build fix... too many $$
2763
2764 2007-11-06  Eric Seidel  <eric@webkit.org>
2765
2766         Reviewed by Mark Rowe.
2767
2768         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
2769
2770 2007-11-05  Adam Roben  <aroben@apple.com>
2771
2772         Add support on Windows for WEBKIT_TESTFONTS
2773
2774         This environment variable lets you specify where the fonts to be used
2775         by DumpRenderTree reside. The Qt port is already using this, so I'm
2776         just following their lead.
2777
2778         Reviewed by Darin.
2779
2780         * DumpRenderTree/win/DumpRenderTree.cpp:
2781         (exePath): Refactored code out of initialize().
2782         (fontsPath): Returns either $WEBKIT_TESTFONTS or
2783         DumpRenderTree.resources.
2784         (initialize): Use the new fontsPath function.
2785         (main): Use the new exePath function.
2786         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
2787         variable to DRT, like Qt does.
2788
2789 2007-11-05  Mark Rowe  <mrowe@apple.com>
2790
2791         Rubber-stamped by Alp Toker.
2792
2793         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
2794
2795         * GtkLauncher/main.cpp:
2796         (goToURLBarText):
2797         (main):
2798
2799 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
2800
2801         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
2802         <http://bugs.webkit.org/show_bug.cgi?id=15830>
2803
2804         Reviewed by Timothy.
2805
2806         Restrict the range of nightly builds used by the bisect-builds script
2807         based on the version of Safari and the version of Mac OS X being used.
2808
2809         Mac OS X 10.4: Safari 2.0: r11976 or newer
2810         Mac OS X 10.4: Safari 3.0: r19992 or newer
2811
2812         Mac OS X 10.5: Safari 2.0: r19594 or newer
2813         Mac OS X 10.5: Safari 3.0: r25124 or newer
2814
2815         * Scripts/bisect-builds:
2816         (findMacOSXVersion): Added.
2817         (makeNightlyList): Added argument to provide version of Mac OS X.
2818         Restrict range of nightly builds based on Safari and Mac OS X versions.
2819
2820 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
2821
2822         Reviewed by Maciej.
2823
2824         - This patch involves several changes, all of them were noticed that
2825         they were needed by the work being done in WebKit to get Drosera and
2826         WebKit working together on Windows.
2827         - The changes are:
2828         1) Added a debugger console for output messages.
2829         2) Drosera now listens for the WebKit server (before, the server would
2830         have to be running before Drosera was started.)
2831         3) Fixed a bug where the WebView started out as 0x0 pixels.
2832         4) Fixed a bug when there is no scope.
2833         5) Added the HTML, JS, and CSS to the project file to make them easy to
2834         find.
2835         6) Made the ServerConnection functions virtual.
2836
2837         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
2838         for the WebKit server.
2839         (DebuggerClient::DebuggerClient):
2840         (DebuggerClient::~DebuggerClient):
2841         (DebuggerClient::didFinishLoadForFrame):
2842         (DebuggerClient::serverConnected):
2843         (DebuggerClient::attemptToCreateServerConnection):
2844         * Drosera/win/DebuggerClient.h: Ditto.
2845         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
2846         scope.
2847         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2848         (DebuggerDocument::platformValueForScopeVariableNamed):
2849         * Drosera/win/Drosera.cpp:
2850         (_tWinMain): Added a console in debug for output messages.
2851         (Drosera::Drosera): Listen for server.
2852         (Drosera::initUI): The server now Initializes COM.
2853         (Drosera::serverConnected): Part of the listening for the server.
2854         (Drosera::attemptToCreateServerConnection): Ditto.
2855         * Drosera/win/Drosera.h: New interface for listening for the server.
2856         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
2857         files to the VS project.
2858         * Drosera/win/ServerConnection.cpp: Part of listening for the server
2859         connection.
2860         (ServerConnection::ServerConnection):
2861         (ServerConnection::attemptToCreateServerConnection):
2862         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
2863         methods.
2864         (ServerConnection::serverConnected):
2865
2866 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
2867
2868         Reviewed by Maciej.
2869
2870         http://bugs.webkit.org/show_bug.cgi?id=15832
2871         fast/dom/gc-10.html crashes when run alone
2872
2873         Check for !done before using objects that can be already deallocated.
2874
2875         * DumpRenderTree/mac/EditingDelegate.mm:
2876         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2877         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2878         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2879         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2880         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2881         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2882         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2883         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2884         (-[EditingDelegate webViewDidBeginEditing:]):
2885         (-[EditingDelegate webViewDidChange:]):
2886         (-[EditingDelegate webViewDidEndEditing:]):
2887         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2888         (-[EditingDelegate webViewDidChangeSelection:]):
2889         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2890         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2891         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2892         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2893         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2894         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2895         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2896         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2897         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2898         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2899         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2900         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2901         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2902         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2903         (-[FrameLoadDelegate webView:willCloseFrame:]):
2904         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2905         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2906         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2907         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2908         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2909         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2910         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2911         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2912         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2913
2914 2007-11-04  Mark Rowe  <mrowe@apple.com>
2915
2916         Build fix.  Don't use Carbon.h as the prefix header as it triggers
2917         warnings that would otherwise be suppressed due to it being a system header.
2918
2919         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2920
2921 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
2922
2923         Rubber stamped by Adam.
2924         
2925         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
2926
2927         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2928
2929 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2930
2931         Sort files(...); sections of Xcode project files.
2932
2933         Rubber-stamped by Darin.
2934
2935         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
2936         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2937         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2938         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2939
2940 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2941
2942         Script to sort "files(...);" sections in Xcode project.pbxproj files.
2943
2944         Reviewed by Darin.
2945
2946         * Scripts/sort-Xcode-project-file: Added.
2947
2948 2007-11-02  Darin Adler  <darin@apple.com>
2949
2950         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
2951
2952 2007-11-02  Darin Adler  <darin@apple.com>
2953
2954         Reviewed by Maciej.
2955
2956         * Scripts/run-sunspider: Pass the "--base" option through.
2957
2958         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
2959         the real script do that. Default configuration to Release to match run-sunspider
2960         so we don't end up building Debug just to compare results.
2961
2962 2007-11-01  Adam Roben  <aroben@apple.com>
2963
2964         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
2965
2966         Reviewed by Sam.
2967
2968         * Scripts/commit-log-editor: Show all the directories beneath the
2969         source root, instead of just the last one.
2970
2971 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
2972
2973         Reviewed by Adam Roben.
2974
2975         Print out an error message when the Windows build fails
2976         and provide guidance on how to find out what went wrong.
2977
2978         * Scripts/build-webkit:
2979         * Scripts/webkitdirs.pm:
2980
2981 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
2982
2983         Rubber-stamped by Adam Roben.
2984
2985         Rolled out r27326 - debug CRT seems to cause no problems after all.
2986
2987         * DumpRenderTree/win/DumpRenderTree.vcproj:
2988
2989 2007-10-31  Adam Roben  <aroben@apple.com>
2990
2991         Switch the Debug configuration to using the non-debug CRT
2992
2993         This matches WebKit.
2994
2995         Reviewed by Steve.
2996
2997         * DumpRenderTree/win/DumpRenderTree.vcproj:
2998
2999 2007-10-31  Antti Koivisto  <antti@apple.com>
3000
3001         Reviewed by bdash.
3002         
3003         Disable media tests when doing leak checking on Tiger.
3004         They crash in QuickTime (rdar://problem/5537157).
3005
3006         * Scripts/run-webkit-tests:
3007
3008 2007-10-29  Antti Koivisto  <antti@apple.com>
3009
3010         Reviewed by Maciej.
3011         
3012         Build media support by default on OSX only.
3013
3014         * Scripts/build-webkit:
3015
3016 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3017
3018         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
3019         get caught by the pre-commit hooks.
3020
3021 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3022
3023         Reviewed by Adam.
3024
3025         - This is a collection of relatively unrelated changes and cleanups
3026         to Drosera to prepare it for interacting with WebKit.  A lot of these
3027         changes are just correcting mistakes, for example removing included
3028         headers that are no longer needed.
3029
3030         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
3031         this will be needed by the DebuggerClient.
3032         (DebuggerDocument::server):
3033         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
3034         * Drosera/win/DebuggerClient.cpp: 
3035         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
3036         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
3037         (DebuggerClient::createWebViewWithRequest): Added comment about its
3038         purpose. 
3039         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
3040         declarations.
3041         (DebuggerClient::webViewLoaded): Moved.
3042         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
3043         file, since this was the only place it was used.
3044         (cfStringToBSTR):
3045         * Drosera/win/Drosera.h: Cleaned up the includes.
3046         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
3047         * Drosera/win/HelperFunctions.h: Removed.
3048
3049 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3050
3051         Reviewed by Adam.
3052
3053         - Small cleanup in the ServerConnection class.
3054
3055         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
3056         and added an include.
3057         (ServerConnection::currentFrame):
3058         (ServerConnection::getCallerFrame):
3059         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
3060         made a pointer into a COMPtr, and cleaned up the includes.
3061
3062 2007-10-29  Timothy Hatcher  <timothy@apple.com>
3063
3064         Reviewed by John Sullivan.
3065         
3066         - Place the Localizable.strings file in mac or win directories
3067           if that location exists.
3068         - Also look for UI_STRING in .c files.
3069
3070         * Scripts/extract-localizable-strings:
3071
3072 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3073
3074         Reviewed by Adam.
3075
3076         - Set the eol-style to native and made all the line endings the same
3077         so that I avoid messy diffs that show eol changes.
3078
3079         * Drosera/win/ServerConnection.cpp:
3080         (ServerConnection::didParseSource):
3081         (ServerConnection::didEnterCallFrame):
3082         (ServerConnection::willExecuteStatement):
3083         (ServerConnection::willLeaveCallFrame):
3084         (ServerConnection::exceptionWasRaised):
3085
3086 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3087
3088         Reviewed by Adam.
3089
3090         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
3091         functionality that could not have existed previously without the new
3092         interfaces.
3093         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
3094         from a BSTR to a JSValueRef.
3095         (DebuggerDocument::platformEvaluateScript): Implemented.
3096         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
3097         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3098         Implemented.
3099         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
3100         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
3101         * Drosera/win/ServerConnection.cpp: Added a helper function.
3102         (ServerConnection::getCallerFrame):
3103         * Drosera/win/ServerConnection.h: Added a helper function.
3104
3105 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
3106
3107         updated reviewers for my previous changelog.
3108
3109 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
3110         Reviewed by Maciej and Adam and Geoff.
3111
3112         - Minor mac-side improvements including moving a function to a more
3113         appropriate location, fixing a warning, and correctly checking
3114         exceptions.
3115
3116         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
3117         (DebuggerDocument::willExecuteStatement):
3118         (DebuggerDocument::didEnterCallFrame):
3119         (DebuggerDocument::willLeaveCallFrame):
3120         (DebuggerDocument::windowScriptObjectAvailable):
3121         (DebuggerDocument::callFunctionOnObject):
3122         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
3123         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
3124         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
3125         because it doesn't require the ServerConnection at all.
3126         (NSStringCreateWithJSStringRef): Made an argument const.
3127         (JSValueRefCreateWithNSString): Made an argument const.
3128         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
3129         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3130         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
3131         * Drosera/mac/ServerConnection.mm: Ditto.
3132         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3133
3134 2007-10-29  Sam Weinig  <sam@webkit.org>
3135
3136         Reviewed by Adam Roben.
3137
3138         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
3139
3140         * DumpRenderTree/LayoutTestController.cpp:
3141         (LayoutTestController::LayoutTestController):
3142         (getGlobalFlagCallback):
3143         (setGlobalFlagCallback):
3144         (LayoutTestController::getJSClass):
3145         (LayoutTestController::staticValues):
3146         * DumpRenderTree/LayoutTestController.h:
3147         (LayoutTestController::globalFlag):
3148         (LayoutTestController::setGlobalFlag):
3149
3150 2007-10-29  Darin Adler  <darin@apple.com>
3151
3152         Reviewed by Maciej.
3153
3154         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
3155         resolution instead of its default.
3156
3157 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
3158
3159         Fixed showStatus() to print status for successfully resolved conflicts when using git.
3160
3161         Reviewed by Mark Rowe.
3162
3163         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
3164         was successfully resolved, but this would not show any status because the change had
3165         already been cached in the index using "git add".  The solution is to add an optional
3166         second argument to showStatus() which adds the "--cached" switch to the command.
3167
3168         * Scripts/resolve-ChangeLogs:
3169         (showStatus):
3170
3171 2007-10-28  Eric Seidel  <eric@webkit.org>
3172
3173         Reviewed by Maciej and Geoff, in unison.
3174
3175         * Scripts/run-webkit-tests: remove broken --svg option
3176
3177 2007-10-28  Darin Adler  <darin@apple.com>
3178
3179         Reviewed by Adam.
3180
3181         * Scripts/run-sunspider: Default to "Release" configuration rather than
3182         defaulting to the last configuration used as other scripts do. This can
3183         still be overriden on the command line with "--debug" if there's some
3184         reason to do so. Also fix a typo.
3185
3186         * Scripts/sunspider-compare-results: Fix a typo.
3187
3188 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
3189
3190         Reviewed by Adam.
3191
3192         - Implemented the WebScriptDebugListener functions now that the
3193         WebScriptDebugServer exists
3194
3195         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
3196         functions.
3197         (ServerConnection::currentFrame):
3198         (ServerConnection::didLoadMainResourceForDataSource):
3199         (ServerConnection::didParseSource):
3200         (ServerConnection::failedToParseSource):
3201         (ServerConnection::didEnterCallFrame):
3202         (ServerConnection::willExecuteStatement):
3203         (ServerConnection::willLeaveCallFrame):
3204         (ServerConnection::exceptionWasRaised):
3205         * Drosera/win/ServerConnection.h: Removed unused arguments from the
3206         members arguments list.
3207
3208 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
3209
3210         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
3211         <http://bugs.webkit.org/show_bug.cgi?id=15600>
3212
3213         Reviewed by Darin.
3214
3215         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
3216         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
3217         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
3218         file.  Note that it may also be used as a stand-alone script.
3219
3220         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
3221         * Scripts/resolve-ChangeLogs: Added.
3222         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
3223
3224 2007-10-26  Mark Rowe  <mrowe@apple.com>
3225
3226         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
3227         to the Qt port on the assumption that it was an implementation of the cross-platform
3228         LayoutTestController class.  It is not, so it did not need to be changed.
3229
3230         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
3231
3232 2007-10-25  Mark Rowe  <mrowe@apple.com>
3233
3234         Reviewed by Maciej.
3235
3236         Fix builds with code coverage enabled.
3237
3238         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
3239
3240 2007-10-25  Darin Adler  <darin@apple.com>
3241
3242         Reviewed by Mark Rowe.
3243
3244         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
3245         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
3246
3247 2007-10-25  Stephanie  <slewis@apple.com>
3248
3249         build Fix
3250
3251         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3252
3253 2007-10-25  Stephanie  <slewis@apple.com>
3254
3255         Reviewed by Mark Rowe, Adam Roben.
3256
3257         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
3258
3259         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
3260
3261 2007-10-25  Alice Liu  <alice.liu@apple.com>
3262
3263         Reviewed by Adam.
3264
3265         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
3266
3267         Moving destructor into platform-specific files
3268         * DumpRenderTree/LayoutTestController.cpp:
3269         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3270         (LayoutTestController::~LayoutTestController):
3271         * DumpRenderTree/qt/jsobjects.cpp:
3272         (LayoutTestController::~LayoutTestController):
3273
3274         LayoutTestController wasn't being destroyed
3275         * DumpRenderTree/win/DumpRenderTree.cpp:
3276         (runTest):
3277
3278         Added declspec
3279         * DumpRenderTree/win/EditingDelegate.h:
3280
3281         Reset certain values on the webview (or related delegate) that might 
3282         have changed while running a test
3283         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3284         (LayoutTestController::~LayoutTestController):
3285
3286 2007-10-25  Adam Roben  <aroben@apple.com>
3287
3288         Make sunspider-compare-results work with relative paths
3289
3290         Reviewed by Sam.
3291
3292         * Scripts/sunspider-compare-results: Convert arguments to absolute
3293         paths before we chdir.
3294
3295 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
3296
3297         Reviewed by Sam.
3298
3299         - Implemented server calls now the WebScriptDebugServer exists.
3300         - Also removed no longer needed call to initialize CG.
3301
3302         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
3303         automatically now.
3304         (_tWinMain):
3305         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
3306         (ServerConnection::ServerConnection):
3307         (ServerConnection::~ServerConnection):
3308         (ServerConnection::pause):
3309         (ServerConnection::resume):
3310         (ServerConnection::stepInto):
3311         (ServerConnection::applicationTerminating):
3312         (ServerConnection::serverConnectionDidDie):
3313         * Drosera/win/ServerConnection.h: Now uses the COM class.
3314
3315 2007-10-24  George Staikos  <staikos@kde.org>
3316
3317         Unbreak Qt build.
3318
3319         * Scripts/build-webkit:
3320
3321 2007-10-24  Adam Roben  <aroben@apple.com>
3322
3323         Remove now-unnecessary call to InitializeCoreGraphics
3324
3325         WebKit takes care of this now.
3326
3327         Reviewed by Ada.
3328
3329         * DumpRenderTree/win/DumpRenderTree.cpp:
3330         (initialize):
3331
3332 2007-10-24  Adam Roben  <aroben@apple.com>
3333
3334         Use WebTextRenderer in DRT
3335
3336         Reviewed by Ada.
3337
3338         * DumpRenderTree/win/DumpRenderTree.cpp:
3339         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
3340
3341 2007-10-24  Sven Herzberg  <sven@imendio.com>
3342
3343         Reviewed by Mark Rowe.
3344
3345         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
3346         Bug 15614: [GTK] qmake based backends don't build on OS X
3347
3348         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
3349         GTK backend on a Mac
3350         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
3351         isDarwin() to make it reusable in other places (like the workaround-
3352         for-prebuilt-qmake in build-webkit)
3353
3354 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
3355
3356         Refurbish update-webkit script.
3357
3358         Reviewed by Adam.
3359
3360         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
3361         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
3362         multi-argument version of system() for flexibility and security.  Check for existence
3363         of Internal directory using -d test instead of -x.
3364
3365 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
3366
3367         Minor clean-up of prepare-ChangeLog script.
3368
3369         Reviewed by Adam.
3370
3371         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
3372         of a string.  Use multi-argument versions of open() and system() for flexibility and
3373         security.
3374
3375 2007-10-24  Alice Liu  <alice.liu@apple.com>
3376
3377         Reviewed by Oliver.
3378
3379         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
3380
3381         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
3382         replay the saved events when we're still processing the mousedown that starts the drag
3383         * DumpRenderTree/win/EventSender.cpp:
3384         (doMouseMove):
3385         * DumpRenderTree/win/UIDelegate.cpp:
3386         (UIDelegate::doDragDrop):
3387
3388 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
3389
3390         Reviewed by Sam, Steve and Darin.
3391
3392         - Stubbed out the WebScriptDebugListener functionality in the Server
3393         Connection class to prepare it for receiving those callbacks.
3394         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
3395         and the ServerConnection to not need to be initialized with a server
3396         name, since that is not the way we connect to the WebKit server. 
3397
3398         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
3399         no exception.  Now it only loggs when there is an exception
3400         (DebuggerDocument::willExecuteStatement):
3401         (DebuggerDocument::didEnterCallFrame):
3402         (DebuggerDocument::willLeaveCallFrame):
3403         (DebuggerDocument::windowScriptObjectAvailable):
3404         (DebuggerDocument::callFunctionOnObject):
3405         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
3406         to be instantiated with a server's name.
3407         (DebuggerClient::DebuggerClient):
3408         (DebuggerClient::didFinishLoadForFrame):
3409         * Drosera/win/DebuggerClient.h: Removed unsued variable.
3410         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
3411         a server name.
3412         (Drosera::init):
3413         (Drosera::initServer):
3414         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
3415         instantiated with a server's name.
3416         * Drosera/win/ServerConnection.cpp: 
3417         (ServerConnection::ServerConnection): No longer needs a server name
3418         (ServerConnection::~ServerConnection): Only release the global context
3419         if there is one.
3420         (ServerConnection::serverConnectionDidDie): Stub for
3421         IWebScriptDebugListener
3422         (ServerConnection::QueryInterface): ditto
3423         (ServerConnection::AddRef): ditto
3424         (ServerConnection::Release): ditto
3425         (ServerConnection::didLoadMainResourceForDataSource): ditto
3426         (ServerConnection::didParseSource): ditto
3427         (ServerConnection::failedToParseSource): ditto
3428         (ServerConnection::didEnterCallFrame): ditto
3429         (ServerConnection::willExecuteStatement): ditto
3430         (ServerConnection::willLeaveCallFrame): ditto
3431         (ServerConnection::exceptionWasRaised): ditto
3432         * Drosera/win/ServerConnection.h: Stubbed out the
3433         IWebScriptDebugListener functions, and this class no longer needs to be
3434         instantiated with a server name.
3435
3436 2007-10-24  Lars Knoll  <lars@trolltech.com>
3437
3438         Reviewed by Simon.
3439
3440         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
3441
3442         * DumpRenderTree/qt/jsobjects.h:
3443
3444 2007-10-24  Lars Knoll  <lars@trolltech.com>
3445
3446         Reviewed by Simon.
3447
3448         add another command.
3449
3450         * DumpRenderTree/qt/jsobjects.cpp:
3451         (TextInputController::doCommand):
3452
3453 2007-10-24  Lars Knoll  <lars@trolltech.com>
3454
3455         Reviewed by Simon.
3456
3457         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
3458
3459         * DumpRenderTree/qt/jsobjects.cpp:
3460         (EventSender::keyDown):
3461         * DumpRenderTree/qt/jsobjects.h:
3462
3463 2007-10-24  Lars Knoll  <lars@trolltech.com>
3464
3465         Reviewed by Simon.
3466
3467         implement eventSender.keyDown().
3468
3469         * DumpRenderTree/qt/jsobjects.cpp:
3470         (EventSender::keyDown):
3471
3472 2007-10-24  Lars Knoll  <lars@trolltech.com>
3473
3474         Reviewed by Simon.
3475
3476         some smaller fixes to the editing support in DRT. Makes another few tests pass.
3477
3478         * DumpRenderTree/qt/DumpRenderTree.cpp:
3479         (WebCore::DumpRenderTree::DumpRenderTree):
3480         (WebCore::DumpRenderTree::initJSObjects):
3481         * DumpRenderTree/qt/jsobjects.cpp:
3482         (TextInputController::doCommand):
3483
3484 2007-10-24  Lars Knoll  <lars@trolltech.com>
3485
3486         Reviewed by Simon.
3487
3488         first bit of implementation for the textinputcontroller.
3489
3490         * DumpRenderTree/qt/DumpRenderTree.cpp:
3491         (WebCore::DumpRenderTree::DumpRenderTree):
3492         * DumpRenderTree/qt/DumpRenderTree.h:
3493         * DumpRenderTree/qt/jsobjects.cpp:
3494         (TextInputController::TextInputController):
3495         (TextInputController::doCommand):
3496         * DumpRenderTree/qt/jsobjects.h:
3497
3498 2007-10-24  Lars Knoll  <lars@trolltech.com>
3499
3500         Reviewed by Simon.
3501
3502         make the man webpage believe it has focus, so the editing tests work correctly.
3503
3504         * DumpRenderTree/qt/DumpRenderTree.cpp:
3505         (WebCore::DumpRenderTree::DumpRenderTree):
3506
3507 2007-10-24  Lars Knoll  <lars@trolltech.com>
3508
3509         Reviewed by Simon.
3510
3511         implement layoutTestController.dumpEditingCallbacks() correctly.
3512
3513         * DumpRenderTree/qt/DumpRenderTree.cpp:
3514         (WebCore::DumpRenderTree::DumpRenderTree):
3515         * DumpRenderTree/qt/jsobjects.cpp:
3516         (LayoutTestController::reset):
3517         (LayoutTestController::dumpEditingCallbacks):
3518
3519 2007-10-24  Lars Knoll  <lars@trolltech.com>
3520
3521         Reviewed by Simon.
3522
3523         Implement support for testing editing.
3524
3525         * DumpRenderTree/qt/DumpRenderTree.cpp:
3526         (WebCore::DumpRenderTree::DumpRenderTree):
3527
3528 2007-10-23  Sam Weinig  <sam@webkit.org>
3529
3530         Check for null BSTR that can be passed to the UIDelegate methods
3531         from javascript null and undefined.  Fixes a failing test case on
3532         Windows (fast/dom/Window/alert-undefined.html)
3533
3534         Reviewed by Eric Seidel.
3535
3536         * DumpRenderTree/win/UIDelegate.cpp:
3537         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3538         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3539         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3540         (UIDelegate::webViewAddMessageToConsole):
3541
3542 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3543
3544         Reviewed by Darin.
3545         
3546         Don't print a massive pile of setenvs from tools that automatically build testkjs.
3547
3548         * Scripts/build-testkjs:
3549
3550 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3551
3552         Reviewed by Darin.
3553
3554         - add wrapper that finds the right copy of testkjs
3555         
3556         * Scripts/sunspider-compare-results: Added.
3557
3558 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
3559
3560         Reviewed by Sam.
3561
3562         - After talking with Steve I now see that the WebKit server must be
3563         running for DCOM to create the distributed objects, which makes sense
3564         and currently WebKit only allows one instance to be running at a time
3565         which avoids accidentally connecting to the wrong server
3566         - In light of this I have removed the code for the attach box and
3567         NotificationServer and known server names, since they are all extranious
3568         now.
3569
3570         * Drosera/win/Drosera.cpp: Removed notification classes and known server
3571         names.
3572         (_tWinMain): Uses init instead of initUI.
3573         (droseraWndProc): No longer creats an attach dialog box.
3574         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
3575         it's not manditory to call init before doing COM stuff.
3576         (Drosera::init): calls initUI and will call attach when the
3577         functionality exists. 
3578         (Drosera::initUI): Has changed very little.
3579         (Drosera::attach): Changed the signature to reflect that we no longer
3580         need the dictionary of known server names.
3581         * Drosera/win/Drosera.h: Removed notification classes and known server
3582         names.  Also renamed and moved some functions.
3583         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
3584         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
3585         headers to the resources folder. 
3586         * Drosera/win/resource.h: Removed the Attach box.
3587
3588 2007-10-22  Adam Roben  <aroben@apple.com>
3589
3590         Windows build fix
3591
3592         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
3593
3594 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
3595
3596         - Removed a leak that was fixed.
3597
3598         * Scripts/run-webkit-tests:
3599
3600 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3601
3602         Reviewed by Darin.
3603
3604         - Changed the Client so that the DebuggerDocument now own the
3605         ServerConnection.  This simplifies ownership and cleanup. 
3606
3607         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
3608         ServerConnection.
3609         (DebuggerClient::initWithServerName):
3610         (DebuggerClient::didFinishLoadForFrame):
3611         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
3612         ServerConnection.
3613         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
3614         until after we have a server which we are attached to.
3615         (Drosera::initUI):
3616         (Drosera::attach):
3617         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
3618         out previously.
3619
3620 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3621
3622         Reviewed by Nikolas.
3623
3624         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
3625
3626         * Scripts/run-javascriptcore-tests:
3627
3628 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3629
3630         Reviewed by Nikolas.
3631
3632         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
3633
3634         * Scripts/build-drosera:
3635         * Scripts/build-dumprendertree:
3636         * Scripts/build-testkjs:
3637         * Scripts/build-webkit:
3638         * Scripts/run-javascriptcore-tests:
3639         * Scripts/run-sunspider:
3640         * Scripts/run-webkit-tests:
3641         * Scripts/webkitdirs.pm:
3642
3643 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
3644
3645         Reviewed by Mark Rowe.
3646         
3647         Fix for local database support after r26879
3648         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
3649
3650         * Scripts/build-webkit:
3651
3652 2007-10-22  Holger Freyther  <zecke@selfish.org>
3653
3654         Reviewed by Simon Hausmann <hausmann@kde.org>.
3655
3656         - Do not build testkjs as an application bundle. This is
3657         needed for run-javascriptcore-tests on OSX.
3658         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
3659         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
3660         as we do not have -rpath on OSX.
3661
3662         * DumpRenderTree/qt/DumpRenderTree.pro:
3663         * Scripts/run-webkit-tests:
3664