2007-11-21 Eric Seidel <eric@webkit.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-11-21  Eric Seidel  <eric@webkit.org>
2
3         Reviewed by Adam.
4
5         More refactoring for greater code readability
6
7         * DumpRenderTree/mac/DumpRenderTree.mm:
8         (initializeGlobalsFromCommandLineOptions):
9         (initializeColorSpaceAndScreeBufferForPixelTests):
10         (addTestPluginsToPluginSearchPath):
11         (useLongRunningServerMode):
12         (runTestingServerLoop):
13         (prepareConsistentTestingEnvironment):
14         (dumpRenderTree):
15         (main):
16         (dumpFramesAsText):
17         (dumpBackForwardListForWebView):
18         (sizeWebViewForCurrentTest):
19         (methodNameStringForFailedTest):
20         (dumpBackForwardListForAllWindows):
21         (dumpWebViewAsPixelsAndCompareWithExpected):
22         (invalidateAnyPreviousWaitToDumpWatchdog):
23         (dump):
24         * DumpRenderTree/mac/DumpRenderTreeMac.h:
25         * DumpRenderTree/mac/UIDelegate.mm:
26         (-[UIDelegate webView:createWebViewWithRequest:]):
27
28 2007-11-21  Eric Seidel  <eric@webkit.org>
29
30         Reviewed by Tim Hatcher.
31
32         Abstract more of DRT into static methods
33
34         * DumpRenderTree/mac/DumpRenderTree.mm:
35         (setDefaultsToConsistentValuesForTesting):
36         (setupSignalHandlers):
37         (allocateGlobalControllers):
38         (releaseAndZero):
39         (releaseGlobalControllers):
40         (dumpRenderTree):
41         (shouldLogFrameLoadDelegates):
42         (createCFURLFromPathOrURL):
43         (resetWebViewToConsistentStateBeforeTesting):
44         (runTest):
45
46 2007-11-21  Eric Seidel  <eric@webkit.org>
47
48         Reviewed by Tim Hatcher.
49
50         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
51
52         * DumpRenderTree/DumpRenderTree.h:
53         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
54         * DumpRenderTree/mac/DumpRenderTree.mm:
55         (dumpRenderTree):
56         (dump):
57         (runTest):
58         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
59         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
60         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
61         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
62         (-[DumpRenderTreePasteboard declareType:owner:]):
63         (+[LocalPasteboard alloc]):
64         (-[LocalPasteboard init]):
65         (-[LocalPasteboard dealloc]):
66         (-[LocalPasteboard name]):
67         (-[LocalPasteboard releaseGlobally]):
68         (-[LocalPasteboard declareTypes:owner:]):
69         (-[LocalPasteboard addTypes:owner:]):
70         (-[LocalPasteboard changeCount]):
71         (-[LocalPasteboard types]):
72         (-[LocalPasteboard availableTypeFromArray:]):
73         (-[LocalPasteboard setData:forType:]):
74         (-[LocalPasteboard dataForType:]):
75         (-[LocalPasteboard setPropertyList:forType:]):
76         (-[LocalPasteboard setString:forType:]):
77         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
78         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
79         (+[DumpRenderTreeWindow allWindows]):
80         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
81         (-[DumpRenderTreeWindow dealloc]):
82         (-[DumpRenderTreeWindow isKeyWindow]):
83         (-[DumpRenderTreeWindow keyDown:]):
84
85 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
86
87         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
88         it indiscriminately copies any headers inside JavaScriptCore,
89         which includes Tiger ICU headers. 
90
91         * wx/build-wxwebkit:
92         Don't run WebCore/move-js-headers.sh any longer.
93
94 2007-11-20  Adam Treat  <treat@kde.org>
95
96         Reviewed by David Kilzer.
97
98         * Prepend git branch name to $baseProductDir
99
100         * Scripts/VCSUtils.pm:
101         * Scripts/webkitdirs.pm:
102
103 2007-11-20  Mark Rowe  <mrowe@apple.com>
104
105         Reviewed by Simon Hausmann.
106
107         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
108         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
109         Have it trigger a "make distclean" rather than "make clean" to ensure that the
110         built product and generated Makefile's are removed.
111
112 2007-11-19  Alp Toker  <alp@atoker.com>
113
114         Reviewed by Mark Rowe.
115
116         http://bugs.webkit.org/show_bug.cgi?id=16040
117         [GTK] GtkLauncher should be written in C
118
119         Port GtkLauncher to plain C.
120
121         Use a more conventional GTK+ coding style.
122
123         Use a toolbar instead of menus.
124
125         Various signature fixes and cleanups.
126
127         Add a license header. Assume all previous modifications were copyright
128         assigned to Apple Inc. by default.
129
130         * GtkLauncher/GtkLauncher.pro:
131         * GtkLauncher/main.c: Added.
132         (activate_url_entry_cb):
133         (update_title):
134         (link_hover_cb):
135         (title_change_cb):
136         (progress_change_cb):
137         (destroy_cb):
138         (go_back_cb):
139         (go_forward_cb):
140         (create_browser):
141         (create_statusbar):
142         (create_toolbar):
143         (create_window):
144         (main):
145         * GtkLauncher/main.cpp: Removed.
146
147 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
148
149         Build script fixes to ensure they do the right thing for the 
150         wx port, and update build-wxwebkit to reflect the way the
151         build scripts now work.
152
153         Reviewed by Adam.
154
155         * Scripts/build-testkjs:
156         * Scripts/build-webkit:
157         * Scripts/run-javascriptcore-tests:
158         * Scripts/webkitdirs.pm:
159         * wx/build-wxwebkit:
160
161 2007-11-18  Eric Seidel  <eric@webkit.org>
162
163         Reviewed by Anders.
164
165         Make run-javascriptcore-tests report failures on exit (to support git bisect)
166
167         * Scripts/run-javascriptcore-tests:
168
169 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
170
171         Reviewed by Adam Roben.
172
173         Make run-webkit-tests work with Windows debug build.
174
175         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
176         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
177         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
178         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
179         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
180
181 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
182
183         Add wxWebKit sample and build script, and integrate it with 
184         build-webkit. Also make build-webkit --clean work for all
185         ports.
186
187         Reviewed by Darin Adler.
188
189         * Scripts/build-webkit:
190         * Scripts/webkitdirs.pm:
191         * wx: Added.
192         * wx/browser: Added.
193         * wx/browser/browser.bkl: Added.
194         * wx/browser/browser.cpp: Added.
195         * wx/build-wxwebkit: Added.
196
197 2007-11-17  Adam Roben  <aroben@apple.com>
198
199         Make it easy to run Safari in the debugger on Windows
200
201         I've added a new script, debug-safari, which launches Safari in the
202         debugger. On OS X it just calls gdb-safari.
203
204         Reviewed by Mark Rowe.
205
206         * FindSafari/FindSafari.cpp:
207         (_tmain): Added a /debugger flag, which in combination with
208         /printSafariLauncher will print a script that launches Safari in the
209         debugger.
210         * Scripts/debug-safari: Added.
211         * Scripts/run-safari: Changed to call runSafari().
212         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
213         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
214         first argument along to FindSafari.
215         * Scripts/webkitdirs.pm:
216         (sub runSafari): Added.
217
218 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
219
220         Reviewed by Adam Roben.
221
222         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
223
224 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
225
226         Reviewed by David Kilzer.
227
228         The git config command was renamed to repo-config at some point. This
229         change tries git config and then git repo-config if the first fails.
230
231         * Scripts/prepare-ChangeLog:
232         (gitConfig):
233
234 2007-11-16  Dan Bernstein  <mitz@apple.com>
235
236         Reviewed by Darin Adler and Sam Weinig.
237
238         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
239
240         * DumpRenderTree/win/EventSender.cpp:
241         (keyDownCallback): For characters that cannot be entered on the active
242         keyboard layout, send a WM_CHAR message with the character along with
243         a WM_KEYDOWN message with a virtual key code of 255.
244
245 2007-11-16  Mark Rowe  <mrowe@apple.com>
246
247         Reviewed by Tim Hatcher.
248
249         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
250
251         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
252         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
253
254 2007-11-15  Adam Roben  <aroben@apple.com>
255
256         Make run-safari actually work on Windows
257
258         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
259         chdir call.
260
261 2007-11-14  Adam Roben  <aroben@apple.com>
262
263         Updates to Safari launching now that 3.0.4 is released
264
265         Reviewed by Sam.
266
267         * FindSafari/FindSafari.cpp:
268         (getWebViewCLSID): Use version-independent ProgID.
269         * Scripts/run-safari: Use run-webkit-nightly.cmd.
270
271 2007-11-14  Anders Carlsson  <andersca@apple.com>
272
273         Reviewed by Adam.
274
275         <rdar://problem/5309081>
276         In DRT, "plugin.logDestroy = true" not working on Windows.
277         
278         * DumpRenderTree/win/TestNetscapePlugin/main.c:
279         (NPP_Destroy):
280
281 2007-11-14  Eric Seidel  <eric@webkit.org>
282
283         Reviewed by Sam.
284
285         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
286
287 2007-11-14  Anders Carlsson  <andersca@apple.com>
288
289         Reviewed by Adam.
290
291         <rdar://problem/5141186>
292         window.layoutTestController.setWindowIsKey is not implemented in DRT.
293         
294         Implement setWindowIsKey.
295         
296         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
297         (LayoutTestController::setWindowIsKey):
298
299 2007-11-13  Sam Weinig  <sam@webkit.org>
300
301         Reviewed by Adam Roben.
302
303         Fix for <rdar://problem/5382579>
304         http/tests/security/cross-frame-access-put.html reports large 
305         negative numbers for screenLeft and screenTop (Mac reports "0")
306
307         * DumpRenderTree/win/UIDelegate.cpp:
308         (UIDelegate::UIDelegate): Initialize the RECT.
309         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
310         (UIDelegate::webViewFrame): ditto.
311         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
312
313 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
314
315         Reviewed by Adam.
316
317         - Make Drosera show source, source URLs, and function stack on Windows,
318         and some minor fixes.
319
320         * Drosera/DebuggerDocument.cpp: Force source to always update display.
321         (DebuggerDocument::updateFileSource):
322         * Drosera/debugger.js: Force source to always update display.
323         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
324         menu controls.
325         (DebuggerClient::resume):
326         (DebuggerClient::pause):
327         (DebuggerClient::stepInto):
328         (DebuggerClient::stepOver):
329         (DebuggerClient::stepOut):
330         (DebuggerClient::showConsole):
331         (DebuggerClient::closeCurrentFile):
332         * Drosera/win/DebuggerClient.h: Ditto.
333         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
334         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
335         removed two bugs.  1) caller could be in a bad state when asked to
336         assign into it. 2) BSTRs were not created correctly.
337         (DebuggerDocument::getPlatformCurrentFunctionStack):
338         * Drosera/win/Drosera.cpp: Hook up the menu controls.
339         (droseraWndProc):
340         (handleCommand):
341         (Drosera::resume):
342         (Drosera::pause):
343         (Drosera::stepInto):
344         (Drosera::stepOver):
345         (Drosera::stepOut):
346         (Drosera::showConsole):
347         (Drosera::closeCurrentFile):
348         * Drosera/win/Drosera.h: Hook up the menu controls.
349         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
350         functions, added a null check, and fixed another bug where caller could
351         be in a bad state when asked to assign into it.
352         (ServerConnection::didLoadMainResourceForDataSource):
353         (ServerConnection::getCallerFrame):
354         * Drosera/win/ServerConnection.h: Safety first.
355
356 2007-11-13  Dan Bernstein  <mitz@apple.com>
357
358         Reviewed by Darin Adler.
359
360         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
361           DumpRenderTree --pixel-tests renders each test twice
362
363         * DumpRenderTree/mac/DumpRenderTree.mm:
364         (dumpRenderTree): Removed the --paint option because the painting code
365         is always exercised as a result of
366         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
367         calling -displayIfNeeded.
368         (dump): Changed to always grab the image from the window since the view
369         is always displayed.
370         (runTest):
371         (displayWebView):
372         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
373         because it always paints.
374
375 2007-11-12  Antti Koivisto  <antti@apple.com>
376
377         Reviewed by Adele.
378         
379         Add support for http media tests
380
381         * Scripts/run-webkit-tests:
382
383 2007-11-12  Sam Weinig  <sam@webkit.org>
384
385         Reviewed by Adam Roben.
386
387         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
388
389         * DumpRenderTree/win/DumpRenderTree.cpp:
390         (runTest):
391         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
392         (LayoutTestController::setPrivateBrowsingEnabled):
393
394 2007-11-12  Adam Roben  <aroben@apple.com>
395
396         * Scripts/update-webkit-localizable-strings: Changed to only scan the
397         mac and win subdirectories.
398
399 2007-11-11  Adam Roben  <aroben@apple.com>
400
401         Fix <rdar://5133816> keepWebHistory is not implemented
402
403         Fixes fast/history/clicked-link-is-visited.html.
404
405         Reviewed by Darin.
406
407         * DumpRenderTree/win/DumpRenderTree.cpp:
408         (runTest): Clear the optionalSharedHistory.
409         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
410         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
411
412 2007-11-10  Sam Weinig  <sam@webkit.org>
413
414         Reviewed by Tim Hatcher.
415
416         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
417         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
418         is turned on)
419
420         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
421
422         Added test: http/tests/security/cross-frame-access-private-browsing.html
423
424         * DumpRenderTree/LayoutTestController.cpp:
425         (setPrivateBrowsingEnabledCallback):
426         (LayoutTestController::staticFunctions):
427         * DumpRenderTree/LayoutTestController.h:
428         * DumpRenderTree/mac/DumpRenderTree.mm:
429         (runTest): Default to private browsing disabled.
430         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
431         (LayoutTestController::setPrivateBrowsingEnabled):
432         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
433         (LayoutTestController::setPrivateBrowsingEnabled):
434
435 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
436
437         Reviewed by Adam.
438
439         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
440         WebCore's!
441
442         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
443         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
444         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
445         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
446         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
447         * Drosera/win/Drosera.cpp:
448         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
449
450 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
451
452         Reviewed by Sam.
453
454         - Use the new IWebFrame [local] function signature and get the shared
455         server correctly.
456
457         * Drosera/win/DebuggerClient.cpp:
458         (DebuggerClient::didFinishLoadForFrame):
459         * Drosera/win/ServerConnection.cpp:
460         (ServerConnection::attemptToCreateServerConnection):
461
462 2007-11-07  Dan Bernstein  <mitz@apple.com>
463
464         Reviewed by Darin Adler.
465
466         - add an option to run-webkit-tests to ignore pixel test failures where
467           all pixels differ by no more than a specified threshold
468
469         * DumpRenderTree/mac/ImageDiff.m:
470         (main):
471         (compareImages):
472         (computePercentageDifferent):
473         * Scripts/run-webkit-tests:
474
475 2007-11-07  Simon Hausmann  <hausmann@kde.org>
476
477         Reviewed by Lars.
478
479         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
480
481         * DumpRenderTree/qt/DumpRenderTree.cpp:
482
483 2007-11-07  Simon Hausmann  <hausmann@kde.org>
484
485         Reviewed by Lars.
486
487         Reworked the QWebSettings API.
488         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
489
490         * DumpRenderTree/qt/DumpRenderTree.cpp:
491
492 2007-11-07  Simon Hausmann  <hausmann@kde.org>
493
494         Reviewed by Lars.
495
496         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
497
498         * DumpRenderTree/qt/jsobjects.cpp:
499
500 2007-11-07  Simon Hausmann  <hausmann@kde.org>
501
502         Reviewed by Lars Knoll <lars@trolltech.com>.
503
504         Add a QWebPage::frameCreated() signal and fix DRT
505         
506         The removal of createFrame in QWebPage broke the re-implementation
507         in DumpRenderTree. Instead emit a frameCreated() signal and
508         connect to it in DumpRenderTree.
509         
510
511         * DumpRenderTree/qt/DumpRenderTree.cpp:
512         (WebCore::WebPage::WebPage):
513         (WebCore::DumpRenderTree::dump):
514         (WebCore::DumpRenderTree::connectFrame):
515         * DumpRenderTree/qt/DumpRenderTree.h:
516
517 2007-11-07  Simon Hausmann  <hausmann@kde.org>
518
519         Reviewed by Lars Knoll <lars@trolltech.com>.
520
521         Moved all the event handlers from QWebFrame into QWebPage.
522         
523         This cleans up the public API and allows us to remove the
524         HackWebFrame hack in DumpRenderTree.
525         
526
527         * DumpRenderTree/qt/jsobjects.cpp:
528         (EventSender::mouseDown):
529         (EventSender::mouseUp):
530         (EventSender::mouseMoveTo):
531
532 2007-11-07  Simon Hausmann  <hausmann@kde.org>
533
534         Reviewed by Mark.
535
536         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
537         to prevent the default implementation from popping up messageboxes.
538
539         * DumpRenderTree/qt/DumpRenderTree.cpp:
540         (WebCore::WebPage::javaScriptConfirm):
541         (WebCore::WebPage::javaScriptPrompt):
542
543 2007-11-06  Eric Seidel  <eric@webkit.org>
544
545         * Scripts/build-testkjs: build fix... too many $$
546
547 2007-11-06  Eric Seidel  <eric@webkit.org>
548
549         Reviewed by Mark Rowe.
550
551         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
552
553 2007-11-05  Adam Roben  <aroben@apple.com>
554
555         Add support on Windows for WEBKIT_TESTFONTS
556
557         This environment variable lets you specify where the fonts to be used
558         by DumpRenderTree reside. The Qt port is already using this, so I'm
559         just following their lead.
560
561         Reviewed by Darin.
562
563         * DumpRenderTree/win/DumpRenderTree.cpp:
564         (exePath): Refactored code out of initialize().
565         (fontsPath): Returns either $WEBKIT_TESTFONTS or
566         DumpRenderTree.resources.
567         (initialize): Use the new fontsPath function.
568         (main): Use the new exePath function.
569         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
570         variable to DRT, like Qt does.
571
572 2007-11-05  Mark Rowe  <mrowe@apple.com>
573
574         Rubber-stamped by Alp Toker.
575
576         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
577
578         * GtkLauncher/main.cpp:
579         (goToURLBarText):
580         (main):
581
582 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
583
584         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
585         <http://bugs.webkit.org/show_bug.cgi?id=15830>
586
587         Reviewed by Timothy.
588
589         Restrict the range of nightly builds used by the bisect-builds script
590         based on the version of Safari and the version of Mac OS X being used.
591
592         Mac OS X 10.4: Safari 2.0: r11976 or newer
593         Mac OS X 10.4: Safari 3.0: r19992 or newer
594
595         Mac OS X 10.5: Safari 2.0: r19594 or newer
596         Mac OS X 10.5: Safari 3.0: r25124 or newer
597
598         * Scripts/bisect-builds:
599         (findMacOSXVersion): Added.
600         (makeNightlyList): Added argument to provide version of Mac OS X.
601         Restrict range of nightly builds based on Safari and Mac OS X versions.
602
603 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
604
605         Reviewed by Maciej.
606
607         - This patch involves several changes, all of them were noticed that
608         they were needed by the work being done in WebKit to get Drosera and
609         WebKit working together on Windows.
610         - The changes are:
611         1) Added a debugger console for output messages.
612         2) Drosera now listens for the WebKit server (before, the server would
613         have to be running before Drosera was started.)
614         3) Fixed a bug where the WebView started out as 0x0 pixels.
615         4) Fixed a bug when there is no scope.
616         5) Added the HTML, JS, and CSS to the project file to make them easy to
617         find.
618         6) Made the ServerConnection functions virtual.
619
620         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
621         for the WebKit server.
622         (DebuggerClient::DebuggerClient):
623         (DebuggerClient::~DebuggerClient):
624         (DebuggerClient::didFinishLoadForFrame):
625         (DebuggerClient::serverConnected):
626         (DebuggerClient::attemptToCreateServerConnection):
627         * Drosera/win/DebuggerClient.h: Ditto.
628         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
629         scope.
630         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
631         (DebuggerDocument::platformValueForScopeVariableNamed):
632         * Drosera/win/Drosera.cpp:
633         (_tWinMain): Added a console in debug for output messages.
634         (Drosera::Drosera): Listen for server.
635         (Drosera::initUI): The server now Initializes COM.
636         (Drosera::serverConnected): Part of the listening for the server.
637         (Drosera::attemptToCreateServerConnection): Ditto.
638         * Drosera/win/Drosera.h: New interface for listening for the server.
639         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
640         files to the VS project.
641         * Drosera/win/ServerConnection.cpp: Part of listening for the server
642         connection.
643         (ServerConnection::ServerConnection):
644         (ServerConnection::attemptToCreateServerConnection):
645         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
646         methods.
647         (ServerConnection::serverConnected):
648
649 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
650
651         Reviewed by Maciej.
652
653         http://bugs.webkit.org/show_bug.cgi?id=15832
654         fast/dom/gc-10.html crashes when run alone
655
656         Check for !done before using objects that can be already deallocated.
657
658         * DumpRenderTree/mac/EditingDelegate.mm:
659         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
660         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
661         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
662         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
663         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
664         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
665         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
666         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
667         (-[EditingDelegate webViewDidBeginEditing:]):
668         (-[EditingDelegate webViewDidChange:]):
669         (-[EditingDelegate webViewDidEndEditing:]):
670         (-[EditingDelegate webViewDidChangeTypingStyle:]):
671         (-[EditingDelegate webViewDidChangeSelection:]):
672         * DumpRenderTree/mac/FrameLoadDelegate.mm:
673         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
674         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
675         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
676         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
677         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
678         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
679         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
680         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
681         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
682         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
683         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
684         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
685         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
686         (-[FrameLoadDelegate webView:willCloseFrame:]):
687         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
688         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
689         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
690         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
691         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
692         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
693         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
694         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
695         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
696
697 2007-11-04  Mark Rowe  <mrowe@apple.com>
698
699         Build fix.  Don't use Carbon.h as the prefix header as it triggers
700         warnings that would otherwise be suppressed due to it being a system header.
701
702         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
703
704 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
705
706         Rubber stamped by Adam.
707         
708         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
709
710         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
711
712 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
713
714         Sort files(...); sections of Xcode project files.
715
716         Rubber-stamped by Darin.
717
718         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
719         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
720         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
721         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
722
723 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
724
725         Script to sort "files(...);" sections in Xcode project.pbxproj files.
726
727         Reviewed by Darin.
728
729         * Scripts/sort-Xcode-project-file: Added.
730
731 2007-11-02  Darin Adler  <darin@apple.com>
732
733         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
734
735 2007-11-02  Darin Adler  <darin@apple.com>
736
737         Reviewed by Maciej.
738
739         * Scripts/run-sunspider: Pass the "--base" option through.
740
741         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
742         the real script do that. Default configuration to Release to match run-sunspider
743         so we don't end up building Debug just to compare results.
744
745 2007-11-01  Adam Roben  <aroben@apple.com>
746
747         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
748
749         Reviewed by Sam.
750
751         * Scripts/commit-log-editor: Show all the directories beneath the
752         source root, instead of just the last one.
753
754 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
755
756         Reviewed by Adam Roben.
757
758         Print out an error message when the Windows build fails
759         and provide guidance on how to find out what went wrong.
760
761         * Scripts/build-webkit:
762         * Scripts/webkitdirs.pm:
763
764 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
765
766         Rubber-stamped by Adam Roben.
767
768         Rolled out r27326 - debug CRT seems to cause no problems after all.
769
770         * DumpRenderTree/win/DumpRenderTree.vcproj:
771
772 2007-10-31  Adam Roben  <aroben@apple.com>
773
774         Switch the Debug configuration to using the non-debug CRT
775
776         This matches WebKit.
777
778         Reviewed by Steve.
779
780         * DumpRenderTree/win/DumpRenderTree.vcproj:
781
782 2007-10-31  Antti Koivisto  <antti@apple.com>
783
784         Reviewed by bdash.
785         
786         Disable media tests when doing leak checking on Tiger.
787         They crash in QuickTime (rdar://problem/5537157).
788
789         * Scripts/run-webkit-tests:
790
791 2007-10-29  Antti Koivisto  <antti@apple.com>
792
793         Reviewed by Maciej.
794         
795         Build media support by default on OSX only.
796
797         * Scripts/build-webkit:
798
799 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
800
801         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
802         get caught by the pre-commit hooks.
803
804 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
805
806         Reviewed by Adam.
807
808         - This is a collection of relatively unrelated changes and cleanups
809         to Drosera to prepare it for interacting with WebKit.  A lot of these
810         changes are just correcting mistakes, for example removing included
811         headers that are no longer needed.
812
813         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
814         this will be needed by the DebuggerClient.
815         (DebuggerDocument::server):
816         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
817         * Drosera/win/DebuggerClient.cpp: 
818         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
819         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
820         (DebuggerClient::createWebViewWithRequest): Added comment about its
821         purpose. 
822         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
823         declarations.
824         (DebuggerClient::webViewLoaded): Moved.
825         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
826         file, since this was the only place it was used.
827         (cfStringToBSTR):
828         * Drosera/win/Drosera.h: Cleaned up the includes.
829         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
830         * Drosera/win/HelperFunctions.h: Removed.
831
832 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
833
834         Reviewed by Adam.
835
836         - Small cleanup in the ServerConnection class.
837
838         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
839         and added an include.
840         (ServerConnection::currentFrame):
841         (ServerConnection::getCallerFrame):
842         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
843         made a pointer into a COMPtr, and cleaned up the includes.
844
845 2007-10-29  Timothy Hatcher  <timothy@apple.com>
846
847         Reviewed by John Sullivan.
848         
849         - Place the Localizable.strings file in mac or win directories
850           if that location exists.
851         - Also look for UI_STRING in .c files.
852
853         * Scripts/extract-localizable-strings:
854
855 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
856
857         Reviewed by Adam.
858
859         - Set the eol-style to native and made all the line endings the same
860         so that I avoid messy diffs that show eol changes.
861
862         * Drosera/win/ServerConnection.cpp:
863         (ServerConnection::didParseSource):
864         (ServerConnection::didEnterCallFrame):
865         (ServerConnection::willExecuteStatement):
866         (ServerConnection::willLeaveCallFrame):
867         (ServerConnection::exceptionWasRaised):
868
869 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
870
871         Reviewed by Adam.
872
873         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
874         functionality that could not have existed previously without the new
875         interfaces.
876         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
877         from a BSTR to a JSValueRef.
878         (DebuggerDocument::platformEvaluateScript): Implemented.
879         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
880         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
881         Implemented.
882         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
883         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
884         * Drosera/win/ServerConnection.cpp: Added a helper function.
885         (ServerConnection::getCallerFrame):
886         * Drosera/win/ServerConnection.h: Added a helper function.
887
888 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
889
890         updated reviewers for my previous changelog.
891
892 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
893         Reviewed by Maciej and Adam and Geoff.
894
895         - Minor mac-side improvements including moving a function to a more
896         appropriate location, fixing a warning, and correctly checking
897         exceptions.
898
899         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
900         (DebuggerDocument::willExecuteStatement):
901         (DebuggerDocument::didEnterCallFrame):
902         (DebuggerDocument::willLeaveCallFrame):
903         (DebuggerDocument::windowScriptObjectAvailable):
904         (DebuggerDocument::callFunctionOnObject):
905         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
906         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
907         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
908         because it doesn't require the ServerConnection at all.
909         (NSStringCreateWithJSStringRef): Made an argument const.
910         (JSValueRefCreateWithNSString): Made an argument const.
911         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
912         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
913         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
914         * Drosera/mac/ServerConnection.mm: Ditto.
915         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
916
917 2007-10-29  Sam Weinig  <sam@webkit.org>
918
919         Reviewed by Adam Roben.
920
921         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
922
923         * DumpRenderTree/LayoutTestController.cpp:
924         (LayoutTestController::LayoutTestController):
925         (getGlobalFlagCallback):
926         (setGlobalFlagCallback):
927         (LayoutTestController::getJSClass):
928         (LayoutTestController::staticValues):
929         * DumpRenderTree/LayoutTestController.h:
930         (LayoutTestController::globalFlag):
931         (LayoutTestController::setGlobalFlag):
932
933 2007-10-29  Darin Adler  <darin@apple.com>
934
935         Reviewed by Maciej.
936
937         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
938         resolution instead of its default.
939
940 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
941
942         Fixed showStatus() to print status for successfully resolved conflicts when using git.
943
944         Reviewed by Mark Rowe.
945
946         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
947         was successfully resolved, but this would not show any status because the change had
948         already been cached in the index using "git add".  The solution is to add an optional
949         second argument to showStatus() which adds the "--cached" switch to the command.
950
951         * Scripts/resolve-ChangeLogs:
952         (showStatus):
953
954 2007-10-28  Eric Seidel  <eric@webkit.org>
955
956         Reviewed by Maciej and Geoff, in unison.
957
958         * Scripts/run-webkit-tests: remove broken --svg option
959
960 2007-10-28  Darin Adler  <darin@apple.com>
961
962         Reviewed by Adam.
963
964         * Scripts/run-sunspider: Default to "Release" configuration rather than
965         defaulting to the last configuration used as other scripts do. This can
966         still be overriden on the command line with "--debug" if there's some
967         reason to do so. Also fix a typo.
968
969         * Scripts/sunspider-compare-results: Fix a typo.
970
971 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
972
973         Reviewed by Adam.
974
975         - Implemented the WebScriptDebugListener functions now that the
976         WebScriptDebugServer exists
977
978         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
979         functions.
980         (ServerConnection::currentFrame):
981         (ServerConnection::didLoadMainResourceForDataSource):
982         (ServerConnection::didParseSource):
983         (ServerConnection::failedToParseSource):
984         (ServerConnection::didEnterCallFrame):
985         (ServerConnection::willExecuteStatement):
986         (ServerConnection::willLeaveCallFrame):
987         (ServerConnection::exceptionWasRaised):
988         * Drosera/win/ServerConnection.h: Removed unused arguments from the
989         members arguments list.
990
991 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
992
993         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
994         <http://bugs.webkit.org/show_bug.cgi?id=15600>
995
996         Reviewed by Darin.
997
998         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
999         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
1000         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
1001         file.  Note that it may also be used as a stand-alone script.
1002
1003         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
1004         * Scripts/resolve-ChangeLogs: Added.
1005         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
1006
1007 2007-10-26  Mark Rowe  <mrowe@apple.com>
1008
1009         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
1010         to the Qt port on the assumption that it was an implementation of the cross-platform
1011         LayoutTestController class.  It is not, so it did not need to be changed.
1012
1013         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
1014
1015 2007-10-25  Mark Rowe  <mrowe@apple.com>
1016
1017         Reviewed by Maciej.
1018
1019         Fix builds with code coverage enabled.
1020
1021         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
1022
1023 2007-10-25  Darin Adler  <darin@apple.com>
1024
1025         Reviewed by Mark Rowe.
1026
1027         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
1028         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
1029
1030 2007-10-25  Stephanie  <slewis@apple.com>
1031
1032         build Fix
1033
1034         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1035
1036 2007-10-25  Stephanie  <slewis@apple.com>
1037
1038         Reviewed by Mark Rowe, Adam Roben.
1039
1040         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
1041
1042         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
1043
1044 2007-10-25  Alice Liu  <alice.liu@apple.com>
1045
1046         Reviewed by Adam.
1047
1048         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
1049
1050         Moving destructor into platform-specific files
1051         * DumpRenderTree/LayoutTestController.cpp:
1052         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1053         (LayoutTestController::~LayoutTestController):
1054         * DumpRenderTree/qt/jsobjects.cpp:
1055         (LayoutTestController::~LayoutTestController):
1056
1057         LayoutTestController wasn't being destroyed
1058         * DumpRenderTree/win/DumpRenderTree.cpp:
1059         (runTest):
1060
1061         Added declspec
1062         * DumpRenderTree/win/EditingDelegate.h:
1063
1064         Reset certain values on the webview (or related delegate) that might 
1065         have changed while running a test
1066         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1067         (LayoutTestController::~LayoutTestController):
1068
1069 2007-10-25  Adam Roben  <aroben@apple.com>
1070
1071         Make sunspider-compare-results work with relative paths
1072
1073         Reviewed by Sam.
1074
1075         * Scripts/sunspider-compare-results: Convert arguments to absolute
1076         paths before we chdir.
1077
1078 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
1079
1080         Reviewed by Sam.
1081
1082         - Implemented server calls now the WebScriptDebugServer exists.
1083         - Also removed no longer needed call to initialize CG.
1084
1085         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
1086         automatically now.
1087         (_tWinMain):
1088         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
1089         (ServerConnection::ServerConnection):
1090         (ServerConnection::~ServerConnection):
1091         (ServerConnection::pause):
1092         (ServerConnection::resume):
1093         (ServerConnection::stepInto):
1094         (ServerConnection::applicationTerminating):
1095         (ServerConnection::serverConnectionDidDie):
1096         * Drosera/win/ServerConnection.h: Now uses the COM class.
1097
1098 2007-10-24  George Staikos  <staikos@kde.org>
1099
1100         Unbreak Qt build.
1101
1102         * Scripts/build-webkit:
1103
1104 2007-10-24  Adam Roben  <aroben@apple.com>
1105
1106         Remove now-unnecessary call to InitializeCoreGraphics
1107
1108         WebKit takes care of this now.
1109
1110         Reviewed by Ada.
1111
1112         * DumpRenderTree/win/DumpRenderTree.cpp:
1113         (initialize):
1114
1115 2007-10-24  Adam Roben  <aroben@apple.com>
1116
1117         Use WebTextRenderer in DRT
1118
1119         Reviewed by Ada.
1120
1121         * DumpRenderTree/win/DumpRenderTree.cpp:
1122         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
1123
1124 2007-10-24  Sven Herzberg  <sven@imendio.com>
1125
1126         Reviewed by Mark Rowe.
1127
1128         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
1129         Bug 15614: [GTK] qmake based backends don't build on OS X
1130
1131         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
1132         GTK backend on a Mac
1133         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
1134         isDarwin() to make it reusable in other places (like the workaround-
1135         for-prebuilt-qmake in build-webkit)
1136
1137 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
1138
1139         Refurbish update-webkit script.
1140
1141         Reviewed by Adam.
1142
1143         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
1144         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
1145         multi-argument version of system() for flexibility and security.  Check for existence
1146         of Internal directory using -d test instead of -x.
1147
1148 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
1149
1150         Minor clean-up of prepare-ChangeLog script.
1151
1152         Reviewed by Adam.
1153
1154         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
1155         of a string.  Use multi-argument versions of open() and system() for flexibility and
1156         security.
1157
1158 2007-10-24  Alice Liu  <alice.liu@apple.com>
1159
1160         Reviewed by Oliver.
1161
1162         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
1163
1164         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
1165         replay the saved events when we're still processing the mousedown that starts the drag
1166         * DumpRenderTree/win/EventSender.cpp:
1167         (doMouseMove):
1168         * DumpRenderTree/win/UIDelegate.cpp:
1169         (UIDelegate::doDragDrop):
1170
1171 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
1172
1173         Reviewed by Sam, Steve and Darin.
1174
1175         - Stubbed out the WebScriptDebugListener functionality in the Server
1176         Connection class to prepare it for receiving those callbacks.
1177         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
1178         and the ServerConnection to not need to be initialized with a server
1179         name, since that is not the way we connect to the WebKit server. 
1180
1181         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
1182         no exception.  Now it only loggs when there is an exception
1183         (DebuggerDocument::willExecuteStatement):
1184         (DebuggerDocument::didEnterCallFrame):
1185         (DebuggerDocument::willLeaveCallFrame):
1186         (DebuggerDocument::windowScriptObjectAvailable):
1187         (DebuggerDocument::callFunctionOnObject):
1188         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
1189         to be instantiated with a server's name.
1190         (DebuggerClient::DebuggerClient):
1191         (DebuggerClient::didFinishLoadForFrame):
1192         * Drosera/win/DebuggerClient.h: Removed unsued variable.
1193         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
1194         a server name.
1195         (Drosera::init):
1196         (Drosera::initServer):
1197         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
1198         instantiated with a server's name.
1199         * Drosera/win/ServerConnection.cpp: 
1200         (ServerConnection::ServerConnection): No longer needs a server name
1201         (ServerConnection::~ServerConnection): Only release the global context
1202         if there is one.
1203         (ServerConnection::serverConnectionDidDie): Stub for
1204         IWebScriptDebugListener
1205         (ServerConnection::QueryInterface): ditto
1206         (ServerConnection::AddRef): ditto
1207         (ServerConnection::Release): ditto
1208         (ServerConnection::didLoadMainResourceForDataSource): ditto
1209         (ServerConnection::didParseSource): ditto
1210         (ServerConnection::failedToParseSource): ditto
1211         (ServerConnection::didEnterCallFrame): ditto
1212         (ServerConnection::willExecuteStatement): ditto
1213         (ServerConnection::willLeaveCallFrame): ditto
1214         (ServerConnection::exceptionWasRaised): ditto
1215         * Drosera/win/ServerConnection.h: Stubbed out the
1216         IWebScriptDebugListener functions, and this class no longer needs to be
1217         instantiated with a server name.
1218
1219 2007-10-24  Lars Knoll  <lars@trolltech.com>
1220
1221         Reviewed by Simon.
1222
1223         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
1224
1225         * DumpRenderTree/qt/jsobjects.h:
1226
1227 2007-10-24  Lars Knoll  <lars@trolltech.com>
1228
1229         Reviewed by Simon.
1230
1231         add another command.
1232
1233         * DumpRenderTree/qt/jsobjects.cpp:
1234         (TextInputController::doCommand):
1235
1236 2007-10-24  Lars Knoll  <lars@trolltech.com>
1237
1238         Reviewed by Simon.
1239
1240         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
1241
1242         * DumpRenderTree/qt/jsobjects.cpp:
1243         (EventSender::keyDown):
1244         * DumpRenderTree/qt/jsobjects.h:
1245
1246 2007-10-24  Lars Knoll  <lars@trolltech.com>
1247
1248         Reviewed by Simon.
1249
1250         implement eventSender.keyDown().
1251
1252         * DumpRenderTree/qt/jsobjects.cpp:
1253         (EventSender::keyDown):
1254
1255 2007-10-24  Lars Knoll  <lars@trolltech.com>
1256
1257         Reviewed by Simon.
1258
1259         some smaller fixes to the editing support in DRT. Makes another few tests pass.
1260
1261         * DumpRenderTree/qt/DumpRenderTree.cpp:
1262         (WebCore::DumpRenderTree::DumpRenderTree):
1263         (WebCore::DumpRenderTree::initJSObjects):
1264         * DumpRenderTree/qt/jsobjects.cpp:
1265         (TextInputController::doCommand):
1266
1267 2007-10-24  Lars Knoll  <lars@trolltech.com>
1268
1269         Reviewed by Simon.
1270
1271         first bit of implementation for the textinputcontroller.
1272
1273         * DumpRenderTree/qt/DumpRenderTree.cpp:
1274         (WebCore::DumpRenderTree::DumpRenderTree):
1275         * DumpRenderTree/qt/DumpRenderTree.h:
1276         * DumpRenderTree/qt/jsobjects.cpp:
1277         (TextInputController::TextInputController):
1278         (TextInputController::doCommand):
1279         * DumpRenderTree/qt/jsobjects.h:
1280
1281 2007-10-24  Lars Knoll  <lars@trolltech.com>
1282
1283         Reviewed by Simon.
1284
1285         make the man webpage believe it has focus, so the editing tests work correctly.
1286
1287         * DumpRenderTree/qt/DumpRenderTree.cpp:
1288         (WebCore::DumpRenderTree::DumpRenderTree):
1289
1290 2007-10-24  Lars Knoll  <lars@trolltech.com>
1291
1292         Reviewed by Simon.
1293
1294         implement layoutTestController.dumpEditingCallbacks() correctly.
1295
1296         * DumpRenderTree/qt/DumpRenderTree.cpp:
1297         (WebCore::DumpRenderTree::DumpRenderTree):
1298         * DumpRenderTree/qt/jsobjects.cpp:
1299         (LayoutTestController::reset):
1300         (LayoutTestController::dumpEditingCallbacks):
1301
1302 2007-10-24  Lars Knoll  <lars@trolltech.com>
1303
1304         Reviewed by Simon.
1305
1306         Implement support for testing editing.
1307
1308         * DumpRenderTree/qt/DumpRenderTree.cpp:
1309         (WebCore::DumpRenderTree::DumpRenderTree):
1310
1311 2007-10-23  Sam Weinig  <sam@webkit.org>
1312
1313         Check for null BSTR that can be passed to the UIDelegate methods
1314         from javascript null and undefined.  Fixes a failing test case on
1315         Windows (fast/dom/Window/alert-undefined.html)
1316
1317         Reviewed by Eric Seidel.
1318
1319         * DumpRenderTree/win/UIDelegate.cpp:
1320         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1321         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1322         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1323         (UIDelegate::webViewAddMessageToConsole):
1324
1325 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
1326
1327         Reviewed by Darin.
1328         
1329         Don't print a massive pile of setenvs from tools that automatically build testkjs.
1330
1331         * Scripts/build-testkjs:
1332
1333 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
1334
1335         Reviewed by Darin.
1336
1337         - add wrapper that finds the right copy of testkjs
1338         
1339         * Scripts/sunspider-compare-results: Added.
1340
1341 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
1342
1343         Reviewed by Sam.
1344
1345         - After talking with Steve I now see that the WebKit server must be
1346         running for DCOM to create the distributed objects, which makes sense
1347         and currently WebKit only allows one instance to be running at a time
1348         which avoids accidentally connecting to the wrong server
1349         - In light of this I have removed the code for the attach box and
1350         NotificationServer and known server names, since they are all extranious
1351         now.
1352
1353         * Drosera/win/Drosera.cpp: Removed notification classes and known server
1354         names.
1355         (_tWinMain): Uses init instead of initUI.
1356         (droseraWndProc): No longer creats an attach dialog box.
1357         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
1358         it's not manditory to call init before doing COM stuff.
1359         (Drosera::init): calls initUI and will call attach when the
1360         functionality exists. 
1361         (Drosera::initUI): Has changed very little.
1362         (Drosera::attach): Changed the signature to reflect that we no longer
1363         need the dictionary of known server names.
1364         * Drosera/win/Drosera.h: Removed notification classes and known server
1365         names.  Also renamed and moved some functions.
1366         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
1367         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
1368         headers to the resources folder. 
1369         * Drosera/win/resource.h: Removed the Attach box.
1370
1371 2007-10-22  Adam Roben  <aroben@apple.com>
1372
1373         Windows build fix
1374
1375         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
1376
1377 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
1378
1379         - Removed a leak that was fixed.
1380
1381         * Scripts/run-webkit-tests:
1382
1383 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1384
1385         Reviewed by Darin.
1386
1387         - Changed the Client so that the DebuggerDocument now own the
1388         ServerConnection.  This simplifies ownership and cleanup. 
1389
1390         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
1391         ServerConnection.
1392         (DebuggerClient::initWithServerName):
1393         (DebuggerClient::didFinishLoadForFrame):
1394         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
1395         ServerConnection.
1396         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
1397         until after we have a server which we are attached to.
1398         (Drosera::initUI):
1399         (Drosera::attach):
1400         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
1401         out previously.
1402
1403 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1404
1405         Reviewed by Nikolas.
1406
1407         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
1408
1409         * Scripts/run-javascriptcore-tests:
1410
1411 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1412
1413         Reviewed by Nikolas.
1414
1415         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
1416
1417         * Scripts/build-drosera:
1418         * Scripts/build-dumprendertree:
1419         * Scripts/build-testkjs:
1420         * Scripts/build-webkit:
1421         * Scripts/run-javascriptcore-tests:
1422         * Scripts/run-sunspider:
1423         * Scripts/run-webkit-tests:
1424         * Scripts/webkitdirs.pm:
1425
1426 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
1427
1428         Reviewed by Mark Rowe.
1429         
1430         Fix for local database support after r26879
1431         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
1432
1433         * Scripts/build-webkit:
1434
1435 2007-10-22  Holger Freyther  <zecke@selfish.org>
1436
1437         Reviewed by Simon Hausmann <hausmann@kde.org>.
1438
1439         - Do not build testkjs as an application bundle. This is
1440         needed for run-javascriptcore-tests on OSX.
1441         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
1442         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
1443         as we do not have -rpath on OSX.
1444
1445         * DumpRenderTree/qt/DumpRenderTree.pro:
1446         * Scripts/run-webkit-tests:
1447
1448 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1449
1450         Reviewed by aroben.
1451
1452         Fix support for Signed-off-by detection in prepare-ChangeLog
1453         --git-commit. The Signed-off-by tag does not appear in the header
1454         but usually at the end.
1455
1456         * Scripts/prepare-ChangeLog:
1457
1458 2007-10-21  Mark Rowe  <mrowe@apple.com>
1459
1460         Reviewed by Eric.
1461
1462         Fix run-javascriptcore-tests for Gtk.
1463
1464         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
1465
1466 2007-10-20  Eric Seidel  <eric@webkit.org>
1467
1468         Reviewed by aroben.
1469
1470         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
1471
1472 2007-10-20  Eric Seidel  <eric@webkit.org>
1473
1474         Reviewed by darin.
1475         
1476         Add improved argument handling to run-sunspider, including
1477         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
1478         Also re-factor code into subroutines
1479
1480         * Scripts/build-dumprendertree: removed bogus comments
1481         * Scripts/build-testkjs: Added.
1482         * Scripts/run-javascriptcore-tests: use build-testkjs
1483         * Scripts/run-sunspider: improved argument handling, abstraction
1484         * Scripts/run-webkit-tests: improved abstraction
1485
1486 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
1487
1488         Not reviewed, Windows build fix.
1489
1490         * DumpRenderTree/win/EventSender.cpp:
1491         (keyDownCallback):
1492
1493 2007-10-20  Darin Adler  <darin@apple.com>
1494
1495         Reviewed by Tim Hatcher.
1496
1497         - http://bugs.webkit.org/show_bug.cgi?id=15544
1498           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
1499           not rely on Apple-specific key codes
1500
1501         * DumpRenderTree/mac/EventSendingController.mm:
1502         (-[EventSendingController keyDown:withModifiers:]):
1503         Added named key "rightArrow". Later we could have a whole table of these.
1504         Also tweaked modifiers code a little.
1505
1506         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
1507
1508 2007-10-19  Darin Adler  <darin@apple.com>
1509
1510         Reviewed by Eric.
1511
1512         - http://bugs.webkit.org/show_bug.cgi?id=15566
1513           possible fix for leak seen in DumpRenderTree
1514
1515         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
1516         Delete the item if it's not put on the queue, since the caller has
1517         no way of knowing that. Would be better to have the parameter type
1518         be auto_ptr to express the fact that we take ownership.
1519
1520         - unrelated change
1521
1522         * Drosera/mac/main.m: Add missing include.
1523
1524 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1525
1526         Reviewed by Adam.
1527
1528         - This change should be identical but for some reason was not working
1529         on my machine.
1530
1531         * Scripts/prepare-ChangeLog:
1532
1533 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1534
1535         Reviewed by Oliver and Tim.
1536
1537         - Made use of RetainPtr to avoid retain and release issues and moved the
1538         log function to DebuggerDocumentPlatform, which seems to be a more
1539         logical place for it to live.
1540         - Also moved knownServers from the ServerConnection to
1541         DebuggerApplication to match the Windows code and because it makes sense
1542         that a connection knows its own server but not all of them.
1543
1544         * Drosera/mac/DebuggerClient.h: Moved the log function to
1545           DebuggerDocumentPlatform.
1546         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
1547           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
1548           call for the server name up from the ServerConnection class.
1549         (-[DebuggerClient dealloc]):
1550         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
1551           for the server name up from the ServerConnection.
1552         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
1553         (DebuggerDocument::platformPause):
1554         (DebuggerDocument::platformResume):
1555         (DebuggerDocument::platformStepInto):
1556         (DebuggerDocument::platformEvaluateScript):
1557         (DebuggerDocument::getPlatformCurrentFunctionStack):
1558         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1559         (DebuggerDocument::platformValueForScopeVariableNamed):
1560         (DebuggerDocument::platformLog): Log directly from here. No need to call
1561           DebuggerClient.
1562         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
1563           way I see it, a ServerConnection should only know about its connection
1564           and the group of all possible servers should be kept by the
1565           application.
1566         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
1567           currentServerName, it makes sense that the connection should know that
1568           name.
1569         (-[ServerConnection currentServerName]):
1570
1571 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1572
1573         Reviewed by Adam.
1574
1575         - Integrated changes from mac drosera.  Recently I've encapsulated
1576         out the server connection object from the rest of Drosera because
1577         it is very platform dependent right now and RPC is not implemented on
1578         windows.  This functionality, of communicating with the WebKit server
1579         is the next area I will be focusing on in Windows.
1580
1581         - Other changes and cleanup were made to organize the code and add notes
1582         on which parts still need work.  Also some mac code is added and
1583         commented out, to act as pseudocode for the logic of those parts.
1584
1585         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
1586           pointer.
1587         * Drosera/config.h: Added whitespace.
1588         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
1589           these files got moved into Drosera.h/cpp
1590         * Drosera/win/DebuggerApplication.h: Removed.
1591         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
1592           happened here to better match the logic flow of the same code on the 
1593           mac side and to use the new ServerConnection class.
1594         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
1595         (DebuggerClient::initWithServerName): Initializer that will set up the
1596           class to use a ServerConnection object.  This was necessary so I could
1597           create a DebuggerClient without having to initilaize it at
1598           construction.
1599         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
1600           will be the UIDelegate and FrameLoadDelegate.
1601         (DebuggerClient::AddRef): For IUnknown.
1602         (DebuggerClient::Release): For IUnknown.
1603         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
1604           this still needs to set the global context of the server, but
1605           IWebFrame does not have an accessor for the global context yet. 
1606         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
1607           this is a pass through for the same function in the document.
1608         (DebuggerClient::didReceiveTitle): Unimplemented part of
1609           FrameLoadDelegate this would change the title of the window.
1610         (DebuggerClient::createWebViewWithRequest): Part of the
1611           FrameLoadDelegate.  This is about new windows via Window.open() and
1612           how their delegates are set.
1613         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
1614           UIDelegate.  Just a debug function for printing messages.
1615         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
1616           because the Client should be the UIDelegate and FrameLoadDelegate
1617           to match the delegates on mac.
1618         (DebuggerClient::webViewLoaded): Added accessor method.
1619         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
1620           forgotten to add this file before.  This is where the platform
1621           dependent versions of the Documents functions live. Most of these are
1622           unimplemented because some piece of functionality does not exist on
1623           Windows yet.
1624         (DebuggerDocument::platformPause):
1625         (DebuggerDocument::platformResume):
1626         (DebuggerDocument::platformStepInto):
1627         (DebuggerDocument::platformEvaluateScript):
1628         (DebuggerDocument::getPlatformCurrentFunctionStack):
1629         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1630         (DebuggerDocument::platformValueForScopeVariableNamed):
1631         (DebuggerDocument::platformLog):
1632         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
1633           responsibilities becaue they belong in the Client. Also I laid the
1634           groundwork for attaching Drosera to a WebKit process
1635         (attachWndProc): Now if a server is selected the Client becomes it's
1636           delegate.
1637         (Drosera::Drosera): Added the construction of the Client and dictionary
1638           of server names. 
1639         (Drosera::initUI): This is no longer the delegates, the Client is.
1640         (Drosera::webViewLoaded): Now asks the Client instead of holding local
1641           state. 
1642         (Drosera::applicationDidFinishLaunching): Placeholder for needed
1643           notification registration when it's possible to implement.
1644         (Drosera::serverLoaded): Ditto
1645         (Drosera::serverUnloaded): Ditto
1646         (Drosera::attach): Attach Drosera to the WebKit server.
1647         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
1648         (Drosera::getInst): 
1649         (Drosera::setInst):
1650         (Drosera::knownServers):
1651         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
1652           and added the ServerConnection.
1653         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
1654         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
1655           Most of the functions are completely unimlemented because they cannot
1656           connect with the WebKit server, because one does not exist on Windows
1657           yet.
1658         (ServerConnection::initWithServerName): 
1659         (ServerConnection::~ServerConnection):
1660         (ServerConnection::setGlobalContext):
1661         (ServerConnection::pause):
1662         (ServerConnection::resume):
1663         (ServerConnection::stepInto):
1664         (ServerConnection::switchToServerNamed):
1665         (ServerConnection::applicationTerminating):
1666         (ServerConnection::serverConnectionDidDie):
1667         (ServerConnection::currentFrame):
1668         * Drosera/win/ServerConnection.h: Added. Ditto.
1669         (ServerConnection::ServerConnection):
1670
1671 2007-10-19  Alice Liu  <alice.liu@apple.com>
1672
1673         Reviewed by Darin.
1674
1675         Fix for these broken layout tests on Windows:
1676         
1677         fast/forms/focus-selection-input.html
1678         fast/forms/focus-selection-textarea.html
1679         fast/forms/select-accesskey.html
1680         
1681         * DumpRenderTree/win/EventSender.cpp:
1682         (keyDownCallback):
1683         correct the VK code for alt key.
1684         
1685 2007-10-19  Eric Seidel  <eric@webkit.org>
1686
1687         Reviewed by Mark Rowe.
1688         
1689         Make the GtkLauncher code slightly more readable.
1690
1691         * GtkLauncher/main.cpp:
1692         (setupMainMenu): Added.
1693         (setupMainWindowUI): Added.
1694         (main):
1695
1696 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
1697
1698         Rubber stamped by Adam.
1699         
1700         - don't delay-load WebKit in DumpRenderTree.
1701
1702         * DumpRenderTree/win/DumpRenderTree.vcproj:
1703
1704 2007-10-18  Dan Bernstein  <mitz@apple.com>
1705
1706         Reviewed by Adam Roben.
1707
1708         - fix <rdar://problem/5313523>
1709         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
1710
1711         * DumpRenderTree/mac/DumpRenderTree.mm:
1712         (dump): Changed to use _responseMIMEType.
1713
1714 2007-10-17  Adam Roben  <aroben@apple.com>
1715
1716         Make it possible to have Windows-specific tests and results
1717
1718         When searching for tests to run and the Skipped file, we will only
1719         look in platform/win and the cross-platform directory. When looking
1720         for expected results, we will look in platform/win, then
1721         platform/mac-leopard, then platform/mac, then finally the
1722         cross-platform directory.
1723
1724         Reviewed by Sam.
1725
1726         * Scripts/run-webkit-tests:
1727         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
1728         searching in the cross-platform directory.
1729         (sub buildPlatformHierarchy): Removed some unneeded calls to
1730         dirname/basename.
1731
1732 2007-10-17  Adam Roben  <aroben@apple.com>
1733
1734         Add back the call to register WebKit that we had before WebKitInitializer existed
1735
1736         This is needed to ensure that the right WebKit is used when
1737         instantiating COM objects.
1738
1739         Reviewed by Oliver.
1740
1741         * DumpRenderTree/win/debug_internal.vsprops: Define
1742         DEBUG_WEBKIT_HAS_SUFFIX.
1743         * DumpRenderTree/win/DumpRenderTree.cpp:
1744         (initialize):
1745
1746 2007-10-17  Adam Roben  <aroben@apple.com>
1747
1748         Import File::Basename in webkitdirs since we use it
1749
1750         * Scripts/webkitdirs.pm:
1751
1752 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
1753
1754         - Updated the tiger leaks list to make the internal bots green.
1755
1756         * Scripts/run-webkit-tests:
1757
1758 2007-10-17  Adam Roben  <aroben@apple.com>
1759
1760         Build fix for VC++ Express
1761
1762         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
1763         and ole32.lib.
1764
1765 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
1766
1767         Reviewed by Sam.
1768
1769         - Minor mac improvements based on observations I made while implementing the
1770         Windows code.
1771
1772         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
1773         then hand it to the Client who will retain it, it should just be the client who
1774         creates and owns the server.
1775         (-[DebuggerApplication attach:]):
1776         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
1777         * Drosera/mac/DebuggerClient.mm: Creates the server.
1778         (-[DebuggerClient initWithServerName:]):
1779         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
1780         can instead forward declare what it needs.
1781
1782 2007-10-16  Darin Adler  <darin@apple.com>
1783
1784         Reviewed by Geoff Garen.
1785
1786         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
1787         want to turn failing tests into platform-specific test results. Also did a
1788         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
1789         would take the type of results into account only some of the time.
1790
1791 2007-10-16  Adam Roben  <aroben@apple.com>
1792
1793         Add a new nightly launcher script for Windows
1794
1795         This new script is for versions of Safari that don't delay-load
1796         WebKit. I had to make FindSafari be able to print out the nightly
1797         launcher script on stdout because Windows shell scripts can't capture
1798         the output from a command into an environment variable.
1799
1800         Reviewed by Steve.
1801
1802         * FindSafari/FindSafari.cpp:
1803         (_tmain): Added /printSafariLauncher option.
1804         * Scripts/run-webkit-nightly.cmd: Added.
1805
1806 2007-10-16  Adam Roben  <aroben@apple.com>
1807
1808         Replace WebKitInitializer with FindSafari
1809
1810         We now rely on setting the PATH environment variable to tell Windows
1811         where to find WebKit and its dependencies (similar to
1812         DYLD_FRAMEWORK_PATH on Mac).
1813
1814         This change also make DumpRenderTree no longer delay-load WebKit.
1815
1816         Reviewed by Sam.
1817
1818         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
1819         FindSafari.
1820         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
1821         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
1822         WebKitInitializer, don't delay-load WebKit.
1823         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
1824         * Scripts/run-webkit-tests: Ditto.
1825         * Scripts/webkitdirs.pm:
1826         (sub setPathForRunningWebKitApp): Added.
1827         * WebKitInitializer/WebKitInitializer.cpp: Removed.
1828         * WebKitInitializer/WebKitInitializer.h: Removed.
1829         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
1830         * WebKitInitializer/debug.vsprops: Removed.
1831         * WebKitInitializer/debug_internal.vsprops: Removed.
1832         * WebKitInitializer/release.vsprops: Removed.
1833
1834 2007-10-16  Adam Roben  <aroben@apple.com>
1835
1836         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
1837
1838         http://bugs.webkit.org/show_bug.cgi?id=15532
1839
1840         FindSafari simply prints the location of an installed Safari.exe on
1841         stdout.
1842
1843         Reviewed by Darin.
1844
1845         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
1846         (getStringValue):
1847         (getWebViewCLSID):
1848         (getInstalledWebKitDirectory):
1849         (_tmain):
1850         * FindSafari/FindSafari.vcproj: Added.
1851         * Scripts/webkitdirs.pm:
1852         (sub installedSafariPath): Added. Calls FindSafari on Windows.
1853
1854 2007-10-16  Adam Roben  <aroben@apple.com>
1855
1856         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
1857
1858         Reviewed by Kevin McCullough.
1859
1860         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
1861         when referring to WebKit.dll.
1862         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
1863         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
1864         * DumpRenderTree/win/release.vsprops: Ditto.
1865         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
1866         never have a _debug suffix on WebKit.dll.
1867         * WebKitInitializer/WebKitInitializer.cpp:
1868         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
1869         specified.
1870         * WebKitInitializer/debug_internal.vsprops: Added
1871         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
1872
1873 2007-10-16  Darin Adler  <darin@apple.com>
1874
1875         Reviewed by Adele.
1876
1877         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
1878         Remove now-unneeded control/alt key hack; the tests have been updated.
1879
1880 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
1881
1882         - Updated leaks list because our internal bot upgraded it's version of leopard and 
1883         one of the leaks was fixed between that revision and the bot's previous version of
1884         leopard.
1885
1886         * Scripts/run-webkit-tests:
1887
1888 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
1889
1890         Reviewed by Tim.
1891
1892         - I encapsulated out the server connecton functionality because it is a specific part
1893         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
1894         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
1895         Windows.  So the majority of this patch is moving preexisting functionality.
1896
1897         - Also I removed the prefix header and changed to use config.h because it is more
1898         standard on how we use config.h in windows and it didn't make much sense to keep
1899         the prefix header and the config.h
1900
1901         * Drosera/DebuggerDocument.cpp:
1902         (DebuggerDocument::DebuggerDocument):
1903         * Drosera/DebuggerDocument.h:
1904         * Drosera/config.h:
1905         * Drosera/mac/DebuggerApplication.mm:
1906         (-[DebuggerApplication attach:]):
1907         * Drosera/mac/DebuggerClient.h:
1908         * Drosera/mac/DebuggerClient.mm:
1909         (-[DebuggerClient initWithServerConnection:]):
1910         (-[DebuggerClient dealloc]):
1911         (-[DebuggerClient windowDidLoad]):
1912         (-[DebuggerClient windowWillClose:]):
1913         (-[DebuggerClient webView:didFinishLoadForFrame:]):
1914         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
1915         * Drosera/mac/DebuggerDocumentPlatform.mm:
1916         (DebuggerDocument::platformPause):
1917         (DebuggerDocument::platformResume):
1918         (DebuggerDocument::platformStepInto):
1919         (DebuggerDocument::platformEvaluateScript):
1920         (DebuggerDocument::getPlatformCurrentFunctionStack):
1921         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1922         (DebuggerDocument::platformValueForScopeVariableNamed):
1923         (DebuggerDocument::platformLog):
1924         * Drosera/mac/Drosera.pch: Removed.
1925         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1926         * Drosera/mac/ServerConnection.h: Added.
1927         * Drosera/mac/ServerConnection.mm: Added.
1928         (-[ServerConnection initWithServerName:]):
1929         (-[ServerConnection dealloc]):
1930         (-[ServerConnection setGlobalContext:]):
1931         (-[ServerConnection pause]):
1932         (-[ServerConnection resume]):
1933         (-[ServerConnection stepInto]):
1934         (-[ServerConnection switchToServerNamed:]):
1935         (-[ServerConnection applicationTerminating:]):
1936         (-[ServerConnection serverConnectionDidDie:]):
1937         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
1938         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
1939         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
1940         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
1941         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
1942         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
1943         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
1944         (-[ServerConnection currentFrame]):
1945         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
1946         (-[ServerConnection knownServers]):
1947
1948 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
1949
1950         Reviewed by Eric.
1951
1952         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
1953           Script to automatically search nightly builds for regressions (bisect-builds)
1954
1955         * Scripts/bisect-builds: Added.
1956
1957 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
1958
1959         Reviewed by Darin.
1960
1961         - New JavaScript benchmark
1962         http://bugs.webkit.org/show_bug.cgi?id=15515
1963
1964         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
1965         current development or release build of JavaScriptCore.
1966
1967 2007-10-15  Mark Rowe  <mrowe@apple.com>
1968
1969         Reviewed by Sam.
1970
1971         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
1972
1973         * Scripts/webkitdirs.pm:
1974         - Change checkArgv to remove the options from @ARGV to prevent
1975         them from interfering with further option processing.
1976         - Fix logic error in determineIsQt that would prevent it from bailing out early.
1977         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
1978         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
1979         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
1980
1981 2007-10-15  Darin Adler  <darin@apple.com>
1982
1983         Reviewed by Sam.
1984
1985         - added logging of window.prompt and window.confirm
1986
1987         * DumpRenderTree/mac/UIDelegate.mm:
1988         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
1989         Implement the recommended delegate rather than the deprecated one.
1990         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
1991         Added.
1992         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
1993         Added.
1994
1995         * DumpRenderTree/win/UIDelegate.h:
1996         * DumpRenderTree/win/UIDelegate.cpp:
1997         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
1998         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
1999         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
2000         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
2001
2002 2007-10-15  Alice Liu  <alice.liu@apple.com>
2003
2004         Reviewed by Sam Weinig.
2005
2006         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
2007
2008         * DumpRenderTree/win/DumpRenderTree.cpp:
2009         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
2010         (main): allocate the global policy delegate for DRT's custom use
2011         * DumpRenderTree/win/DumpRenderTree.vcproj:
2012         Adding files to project
2013         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
2014         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2015         (LayoutTestController::setCustomPolicyDelegate):
2016         set the webview's policy delegate to DRT's custom one if the test requests it.
2017         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
2018         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
2019         (PolicyDelegate::PolicyDelegate):
2020         (PolicyDelegate::QueryInterface):
2021         (PolicyDelegate::AddRef):
2022         (PolicyDelegate::Release):
2023         (PolicyDelegate::decidePolicyForNavigationAction):
2024         * DumpRenderTree/win/PolicyDelegate.h: Added.
2025         (PolicyDelegate::decidePolicyForNewWindowAction):
2026         (PolicyDelegate::decidePolicyForMIMEType):
2027         (PolicyDelegate::unableToImplementPolicyWithError):
2028
2029 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
2030
2031         Reviewed by Mark.
2032
2033         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
2034         when querying for QMAKE_MKSPECS.
2035
2036 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
2037
2038         Reviewed by Adam Roben.
2039         
2040         Fix run-webkit-tests is too greedy calculating platform hierarchy
2041         http://bugs.webkit.org/show_bug.cgi?id=15465
2042         
2043         Fix run-webkit-tests being too greedy in trying to split the platform name up
2044         causing it to try and find tests in every directory above the first "-" in the
2045         path to the LayoutTests
2046
2047         * Scripts/run-webkit-tests:
2048
2049 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
2050
2051         Reviewed by Darin.
2052
2053         http://bugs.webkit.org/show_bug.cgi?id=15006
2054         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
2055         to reduce code duplication.
2056
2057         * Scripts/build-webkit:
2058         * Scripts/webkitdirs.pm:
2059         buildQMakeProject() renamed to buildQMakeQtProject().
2060         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
2061         unused $colorize has been removed.
2062
2063 === Start merge of feature-branch 2007-10-12 ===
2064
2065 2007-10-08  Eric Seidel  <eric@webkit.org>
2066
2067         Reviewed by Mark Rowe.
2068
2069         * Scripts/build-webkit: add --help, remove unused --color
2070
2071 2007-10-07  Eric Seidel  <eric@webkit.org>
2072
2073         Reviewed by darin.
2074
2075         * Drosera/mac/DebuggerDocumentPlatform.mm:
2076         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
2077
2078 2007-10-03  Rob Buis  <buis@kde.org>
2079
2080         Reviewed by Olliej.
2081
2082         Adapt to changed location of Ahem font.
2083
2084         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2085
2086 2007-10-02  Eric Seidel  <eric@webkit.org>
2087
2088         Reviewed by Adam Roben.
2089         
2090         Make pixel tests more useful!
2091         Finally fix the image diff 0.00% mystery problem
2092         Highlight any image differences in the image diff.
2093         Add a link from image diffs back to original test file.
2094
2095         * DumpRenderTree/mac/ImageDiff.m:
2096         (compareImages): highlight any differences
2097         (computePercentageDifferent): round to two decimal places
2098         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
2099
2100 2007-10-02  Eric Seidel  <eric@webkit.org>
2101
2102         Reviewed by Alexey Proskuryakov.
2103
2104         * Scripts/run-webkit-tests: print the % image difference on main results page
2105
2106 2007-10-02  Mark Rowe  <mrowe@apple.com>
2107
2108         Reviewed by Oliver.
2109
2110         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
2111
2112         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
2113         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
2114
2115 2007-10-01  Mark Rowe  <mrowe@apple.com>
2116
2117         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
2118
2119 2007-09-25  Eric Seidel  <eric@webkit.org>
2120
2121         Reviewed by Mark Rowe.
2122         
2123         DerivedSources.make was finding "ENABLE_SVG" in the string
2124         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
2125         quite correctly.
2126
2127         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
2128
2129 2007-09-25  Mark Rowe  <mrowe@apple.com>
2130
2131         Rubber-stamped by Eric.
2132
2133         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
2134         This makes it possible to automate nightly builds for the feature-branch.
2135
2136 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
2137
2138         Rubber stamped by Mark.
2139
2140         Enable svg experimental features as default here in feature-branch.
2141
2142         * Scripts/build-webkit:
2143
2144 2007-06-29  Antti Koivisto  <antti@apple.com>
2145
2146         Reviewed by Weinig.
2147         
2148         Add VIDEO flag for timed media features
2149
2150         * Scripts/build-webkit
2151         
2152 === End merge of feature-branch 2007-10-12 ===
2153
2154 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
2155
2156         Reviewed by Darin.
2157
2158         - Updated rational for the leaks list to be more clear.
2159
2160         * Scripts/run-webkit-tests:
2161
2162 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
2163
2164         Rubber Stamp by Sam.
2165
2166         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
2167         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
2168
2169         * Scripts/run-webkit-tests:
2170
2171 2007-10-10  Simon Hausmann  <hausmann@kde.org>
2172
2173         Reviewed by Lars.
2174
2175         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
2176         includes are needed for INT_MAX, std::auto_ptr and the like.
2177
2178         * DumpRenderTree/qt/main.cpp:
2179
2180 2007-10-09  Lars Knoll  <lars@trolltech.com>
2181
2182         Reviewed by Simon.
2183
2184         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
2185
2186         * DumpRenderTree/qt/jsobjects.cpp:
2187         (LayoutTestController::encodeHostName):
2188         (LayoutTestController::decodeHostName):
2189         * DumpRenderTree/qt/jsobjects.h:
2190
2191 2007-10-09  Lars Knoll  <lars@trolltech.com>
2192
2193         Reviewed by Simon.
2194
2195         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
2196
2197         * DumpRenderTree/qt/DumpRenderTree.cpp:
2198         (WebCore::WebPage::createFrame):
2199         (WebCore::DumpRenderTree::DumpRenderTree):
2200         (WebCore::DumpRenderTree::titleChanged):
2201         * DumpRenderTree/qt/DumpRenderTree.h:
2202         * DumpRenderTree/qt/jsobjects.cpp:
2203         (LayoutTestController::reset):
2204         * DumpRenderTree/qt/jsobjects.h:
2205
2206 2007-10-09  Lars Knoll  <lars@trolltech.com>
2207
2208         Reviewed by Simon.
2209
2210         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
2211
2212         * DumpRenderTree/qt/DumpRenderTree.h:
2213         * DumpRenderTree/qt/jsobjects.cpp:
2214         (LayoutTestController::clearBackForwardList):
2215         * DumpRenderTree/qt/jsobjects.h:
2216
2217 2007-10-09  Lars Knoll  <lars@trolltech.com>
2218
2219         Reviewed by Simon.
2220
2221         make --git-reviewer work again.
2222
2223         * Scripts/prepare-ChangeLog:
2224
2225 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
2226
2227         Rubber stamped by Eric.
2228
2229         Connect to the "hovering-over-link" signal emitted by WebKitPage and
2230         show the current link inside the statusbar.
2231         This shows how to make use of this signal and allows to easily test
2232         http://bugs.webkit.org/show_bug.cgi?id=15299.
2233
2234         * GtkLauncher/main.cpp:
2235         (hoveringOverLink):
2236         (main):
2237
2238 2007-10-05  Lars Knoll  <lars@trolltech.com>
2239
2240         add proper error messages to the FrameLoaderClient.
2241         Implement ChromeClientQt::closeWindowSoon and
2242         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
2243         Some fixes in DRT to make it work correctly with multiple windows.
2244
2245         Reviewed by Maciej.
2246
2247         * DumpRenderTree/qt/DumpRenderTree.cpp:
2248         (WebCore::DumpRenderTree::DumpRenderTree):
2249         (WebCore::DumpRenderTree::createWindow):
2250         (WebCore::DumpRenderTree::windowCount):
2251         * DumpRenderTree/qt/DumpRenderTree.h:
2252         * DumpRenderTree/qt/jsobjects.cpp:
2253         (LayoutTestController::maybeDump):
2254         (LayoutTestController::windowCount):
2255         * DumpRenderTree/qt/jsobjects.h:
2256
2257 2007-10-05  Lars Knoll  <lars@trolltech.com>
2258
2259         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
2260         Add support for layoutTextController.setCanOpenWindows() to DRT
2261         fixing another 2 test cases in fast/dom/Window.
2262
2263         Reviewed by Maciej.
2264
2265         * DumpRenderTree/qt/DumpRenderTree.cpp:
2266         (WebCore::WebPage::WebPage):
2267         (WebCore::WebPage::createWindow):
2268         (WebCore::DumpRenderTree::resetJSObjects):
2269         (WebCore::DumpRenderTree::createWindow):
2270         * DumpRenderTree/qt/DumpRenderTree.h:
2271         * DumpRenderTree/qt/DumpRenderTree.pro:
2272         * DumpRenderTree/qt/jsobjects.cpp:
2273         (LayoutTestController::LayoutTestController):
2274         (LayoutTestController::reset):
2275         * DumpRenderTree/qt/jsobjects.h:
2276         * DumpRenderTree/qt/main.cpp:
2277         * DumpRenderTree/qt/testplugin.cpp: Added.
2278         * DumpRenderTree/qt/testplugin.h: Added.
2279
2280 2007-10-04  Sam Weinig  <sam@webkit.org>
2281
2282         Rubber stamped by Adam.
2283
2284         Remove empty directories.
2285
2286         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
2287         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
2288
2289 2007-10-03  Darin Adler  <darin@apple.com>
2290
2291         Reviewed by Adam.
2292
2293         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
2294         we find the internal libraries in the libraries directory. This
2295         is helpful for Safari team engineers at Apple.
2296
2297 2007-10-03  Adam Roben  <aroben@apple.com>
2298
2299         Update the location of AHEM___.TTF after r25968
2300
2301         Reviewed by Sam.
2302
2303         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2304
2305 2007-10-03  Alp Toker  <alp@atoker.com>
2306
2307         Reviewed by Adam.
2308
2309         http://bugs.webkit.org/show_bug.cgi?id=14726
2310         [gtk] API design. Mapping the WebView delegates to signals.
2311
2312         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
2313
2314         * GtkLauncher/main.cpp:
2315         (goToURLBarText):
2316         (titleChanged):
2317         (progressChanged):
2318         (menuMainBackCallback):
2319         (menuMainForwardCallback):
2320         (main):
2321
2322 2007-10-03  Lars Knoll  <lars@trolltech.com>
2323
2324         Reviewed by Rob.
2325
2326         This fixes --strict mode in run-webkit-tests again after
2327         the platform dependent test results have been moved.
2328
2329         * Scripts/run-webkit-tests:
2330
2331 2007-10-03  Lars Knoll  <lars@trolltech.com>
2332
2333         Reviewed by bdash.
2334
2335         remove the hack in run-webkit-tests that forced text only test
2336         to be taken from the platform independent dir. It was only left
2337         there from early days.
2338         
2339         Remove platform dependent results for tests that are text only nowadays,
2340         and add one platform dependent result for a text only test that requires it.
2341
2342         * Scripts/run-webkit-tests:
2343
2344 2007-10-03  Lars Knoll  <lars@trolltech.com>
2345
2346         Reviewed by olliej.
2347
2348         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
2349
2350         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
2351         (WebCore::WebFrame::WebFrame):
2352         (WebCore::WebPage::WebPage):
2353         (WebCore::WebPage::createFrame):
2354         (WebCore::WebPage::javaScriptAlert):
2355         (WebCore::WebPage::javaScriptConsoleMessage):
2356         (WebCore::DumpRenderTree::DumpRenderTree):
2357         (WebCore::DumpRenderTree::~DumpRenderTree):
2358         (WebCore::DumpRenderTree::open):
2359         (WebCore::DumpRenderTree::readStdin):
2360         (WebCore::DumpRenderTree::resetJSObjects):
2361         (WebCore::DumpRenderTree::initJSObjects):
2362         (WebCore::DumpRenderTree::dumpFramesAsText):
2363         (WebCore::DumpRenderTree::dump):
2364         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
2365         (WebCore::DumpRenderTree::layoutTestController):
2366         (WebCore::DumpRenderTree::eventSender):
2367         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
2368         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
2369         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
2370         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
2371         (HackWebFrame::mousePressEvent):
2372         (HackWebFrame::mouseReleaseEvent):
2373         (HackWebFrame::mouseMoveEvent):
2374         (HackWebFrame::HackWebFrame):
2375         (HackWebFrame::~HackWebFrame):
2376         (LayoutTestController::LayoutTestController):
2377         (LayoutTestController::reset):
2378         (LayoutTestController::maybeDump):
2379         (LayoutTestController::waitUntilDone):
2380         (LayoutTestController::notifyDone):
2381         (LayoutTestController::dumpEditingCallbacks):
2382         (LayoutTestController::queueReload):
2383         (LayoutTestController::provisionalLoad):
2384         (LayoutTestController::timerEvent):
2385         (EventSender::EventSender):
2386         (EventSender::mouseDown):
2387         (EventSender::mouseUp):
2388         (EventSender::mouseMoveTo):
2389         (EventSender::leapForward):
2390         (EventSender::keyDown):
2391         (EventSender::frameUnderMouse):
2392         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
2393         (LayoutTestController::isLoading):
2394         (LayoutTestController::setLoading):
2395         (LayoutTestController::shouldDumpAsText):
2396         (LayoutTestController::shouldDumpChildrenAsText):
2397         (LayoutTestController::shouldWaitUntilDone):
2398         (LayoutTestController::dumpAsText):
2399         (LayoutTestController::dumpChildFramesAsText):
2400         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
2401         (messageHandler):
2402         (crashHandler):
2403         (main):
2404         * Scripts/run-webkit-tests:
2405
2406 2007-10-03  Mark Rowe  <mrowe@apple.com>
2407
2408         Reviewed by Alp Toker.
2409
2410         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
2411         should take precedence over QTDIR when determining which port we are working with.
2412
2413         * Scripts/webkitdirs.pm: 
2414
2415 2007-10-02  Adam Roben  <aroben@apple.com>
2416
2417         Add keychain to the list of default packages to install
2418
2419         Rubberstamped by Sam.
2420
2421         * CygwinDownloader/cygwin-downloader.py:
2422         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
2423
2424 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
2425
2426         Reviewed by Adam.
2427
2428         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
2429         Also makes WebCore regression test case logic work when using git.
2430
2431         * Scripts/prepare-ChangeLog:
2432         (reviewerAndDescriptionForGitCommit): Added.
2433
2434 2007-10-02  Lars Knoll  <lars@trolltech.com>
2435
2436         Reviewed by bdash.
2437
2438         Add API to retrieve the frame name from QWebFrame.
2439         Implement support for DRT::dumpChildrenAsText.
2440
2441         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2442         (WebCore::DumpRenderTree::dumpFramesAsText):
2443         (WebCore::DumpRenderTree::dump):
2444         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2445         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2446         (LayoutTestController::LayoutTestController):
2447         (LayoutTestController::reset):
2448         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
2449
2450 2007-10-02  Lars Knoll  <lars@trolltech.com>
2451
2452         Reviewed by bdash.
2453
2454         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
2455
2456         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2457         (WebCore::DumpRenderTree::readStdin):
2458
2459 2007-10-02  Mark Rowe  <mrowe@apple.com>
2460
2461         Reviewed by Oliver.
2462
2463         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
2464
2465         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
2466         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
2467
2468 2007-10-02  Mark Rowe  <mrowe@apple.com>
2469
2470         Rubber-stamped by Maciej.
2471
2472         Configuration changes from build.webkit.org.  The major change is refactoring to work
2473         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
2474         last few weeks.
2475
2476         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2477         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
2478         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
2479         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
2480         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
2481         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
2482         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
2483         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
2484
2485 2007-10-02  Lars Knoll  <lars@trolltech.com>
2486
2487         Reviewed by Maciej.
2488
2489         Add support for eventSender.mouseMove to DRT.
2490         Fixes fast/css/hover-affects-child.html
2491
2492         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2493         (EventSender::mouseMoveTo):
2494
2495 2007-10-01  Mark Rowe  <mrowe@apple.com>
2496
2497         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
2498
2499 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
2500
2501         Reviewed by Hyatt.
2502
2503         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
2504
2505         * Scripts/svn-apply:
2506         (gitdiff2svndiff): Ignore lines beginning with "new file".
2507         * Scripts/svn-unapply:
2508         (gitdiff2svndiff): Ditto.
2509
2510 2007-09-30  George Staikos  <staikos@kde.org>
2511
2512         Qt build fix (Mac OS X specific)
2513
2514         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
2515
2516 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
2517
2518         Reviewed by Mark.
2519
2520         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
2521         Remove Bakefiles from svn.
2522
2523         * GtkLauncher/Bakefiles.bkgen: Removed.
2524         * GtkLauncher/ENV: Removed.
2525         * GtkLauncher/gdklauncher.bkl: Removed.
2526         * GtkLauncher/mk: Removed.
2527         * Scripts/regenerate-makefiles: Removed.
2528
2529 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
2530
2531         Reviewed by John.
2532
2533         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
2534
2535         * Scripts/run-webkit-tests:
2536
2537 2007-09-26  Adam Roben  <aroben@apple.com>
2538
2539         Make not finding an installed WebKit non-fatal
2540
2541         What really matters is that we are able to load WebKit and its
2542         dependencies, not whether we think we've found an installed WebKit.
2543
2544         Reviewed by Sam.
2545
2546         * WebKitInitializer/WebKitInitializer.cpp:
2547         (getWebViewCLSID): Use new LOG_WARNING macro.
2548         (getInstalledWebKitDirectory): Ditto.
2549         (initializeWebKit): Don't die if we didn't find an installed WebKit,
2550         and use new macros.
2551         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
2552
2553 2007-09-26  Adam Roben  <aroben@apple.com>
2554
2555         Committed this file before saving it
2556
2557         * WebKitInitializer/debug_internal.vsprops:
2558
2559 2007-09-26  Adam Roben  <aroben@apple.com>
2560
2561         Load WebKit and its dependencies manually so they come from DllDirectory
2562
2563         I had to change WebKitInitializer to use malloc/free instead of
2564         new/delete to avoid pulling in WebKit (and its dependencies) early
2565         through use of fastMalloc.
2566
2567         Reviewed by Oliver.
2568
2569         * WebKitInitializer/WebKitInitializer.cpp:
2570         (getStringValue): Changed to use malloc/free.
2571         (getInstalledWebKitDirectory): Ditto.
2572         (initializeWebKit): Call SetDllDirectory first, then load all of
2573         WebKit's dependencies manually, finally followed by WebKit itself.
2574         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
2575         configuration to match our other projects.
2576         * WebKitInitializer/debug_internal.vsprops: Added.
2577
2578 2007-09-25  Adam Roben  <aroben@apple.com>
2579
2580         Actually define DEBUG/NDEBUG so that we load WebKit correctly
2581
2582         Rubberstamped by Sam.
2583
2584         * WebKitInitializer/WebKitInitializer.vcproj:
2585
2586 2007-09-25  Adam Roben  <aroben@apple.com>
2587
2588         Make DumpRenderTree delay-load its dependencies
2589
2590         This lets WebKitInitializer re-route the dependencies to be loaded out
2591         of the Safari installation directory.
2592
2593         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
2594         same thing), since we can't import the kCFAllocatorDefault symbol when
2595         delay-loading CoreFoundation.dll.
2596
2597         Rubberstamped by Sam.
2598
2599         * DumpRenderTree/win/DumpRenderTree.cpp:
2600         (runTest):
2601         (javaScriptThreads):
2602         * DumpRenderTree/win/DumpRenderTree.vcproj:
2603         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2604         (LayoutTestController::setWaitToDump):
2605
2606 2007-09-25  Adam Roben  <aroben@apple.com>
2607
2608         Pull ole32.lib into WebKitInitializer
2609
2610         Rubberstamped by Sam.
2611
2612         * WebKitInitializer/WebKitInitializer.vcproj:
2613
2614 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
2615
2616         Reviewed by Adam.
2617
2618         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
2619           LGPL'ed files contain incorrect FSF address
2620
2621         * Drosera/config.h:
2622
2623 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
2624
2625         Reviewed by Adam.
2626
2627         Make svn-apply and svn-unapply work with git-diff formatted patches.
2628
2629         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
2630         (gitdiff2svndiff): Added.
2631         * Scripts/svn-unapply: Ditto.
2632         (gitdiff2svndiff): Added.
2633
2634 2007-09-25  Adam Roben  <aroben@apple.com>
2635
2636         Pull advapi32.lib into WebKitInitializer
2637
2638         This is needed to get the registry functions we use.
2639
2640         Rubberstamped by Sam.
2641
2642         * WebKitInitializer/WebKitInitializer.vcproj:
2643
2644 2007-09-25  Adam Roben  <aroben@apple.com>
2645
2646         Add python and rsync to cygwin-downloader
2647
2648         Our build slaves need this, and it can't hurt for everyone else to
2649         have it, too.
2650
2651         Reviewed by Sam.
2652
2653         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
2654         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
2655
2656 2007-09-25  Adam Roben  <aroben@apple.com>
2657
2658         Add WebKitInitializer and use it in DumpRenderTree
2659
2660         WebKitInitializer is a static library that has one function,
2661         initializeWebKit(). This registers WebKit and sets up the DLL search
2662         path so that WebKit's dependencies that are installed with Safari can
2663         be found.
2664
2665         Reviewed by Sam.
2666
2667         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
2668         DumpRenderTree depend on it.
2669         * DumpRenderTree/win/DumpRenderTree.cpp:
2670         (initialize): Call initializeWebKit.
2671         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
2672         WebKitInitializer.lib.
2673         * WebKitInitializer/WebKitInitializer.cpp: Added.
2674         (getStringValue):
2675         (getWebViewCLSID):
2676         (getInstalledWebKitDirectory):
2677         (initializeWebKit):
2678         * WebKitInitializer/WebKitInitializer.h: Added.
2679         * WebKitInitializer/WebKitInitializer.vcproj: Added.
2680         * WebKitInitializer/debug.vsprops: Added.
2681         * WebKitInitializer/release.vsprops: Added.
2682
2683 2007-09-25  Adam Roben  <aroben@apple.com>
2684
2685         Make run-webkit-tests respect set-webkit-configuration
2686
2687         Reviewed by Sam.
2688
2689         * Scripts/run-webkit-tests: Initialize $configuration to whatever
2690         set-webkit-configuration was last set to.
2691
2692 2007-09-25  Mark Rowe  <mrowe@apple.com>
2693
2694         Rubber-stamped by Eric.
2695
2696         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
2697         This makes it possible to automate nightly builds for the feature-branch.
2698
2699 2007-09-25  Adam Roben  <aroben@apple.com>
2700
2701         A couple of fixes/enhancements to update-webkit-*-libs
2702
2703         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
2704         to tell update-webkit-support-libraries where it should find the
2705         WebKitSupportLibrary.zip file you downloaded.
2706
2707         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
2708         Windows-style path.
2709
2710         Reviewed by Sam.
2711
2712         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
2713         to $auxiliaryLibsURL and removed an irrelevant comment.
2714         * Scripts/update-webkit-support-libs:
2715
2716 2007-09-25  Adam Treat  <treat@kde.org>
2717
2718         Reviewed by Simon and Lars.
2719
2720         Refactors and cleans up Qt DRT member variable names, member variable
2721         initialization, style fixes and general code cleanup.
2722
2723         Adds queueReload slot to LayoutTestController that some tests require.
2724
2725         Subclasses QWebFrame to make sure that all frames have an associated
2726         LayoutTestController JS window object.
2727
2728         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
2729         aren't dumped twice.
2730
2731         EOF fixes.
2732
2733         Together, this patch fixes some 20+ layout tests in QtWebKit.
2734
2735         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2736         (WebCore::WebFrame::WebFrame):
2737         (WebCore::WebPage::WebPage):
2738         (WebCore::WebPage::createFrame):
2739         (WebCore::DumpRenderTree::DumpRenderTree):
2740         (WebCore::DumpRenderTree::open):
2741         (WebCore::DumpRenderTree::readStdin):
2742         (WebCore::DumpRenderTree::initJSObjects):
2743         (WebCore::DumpRenderTree::dump):
2744         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2745         (WebCore::DumpRenderTree::layoutTestController):
2746         (WebCore::DumpRenderTree::eventSender):
2747         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2748         (LayoutTestController::LayoutTestController):
2749         (LayoutTestController::reset):
2750         (LayoutTestController::maybeDump):
2751         (LayoutTestController::waitUntilDone):
2752         (LayoutTestController::notifyDone):
2753         (LayoutTestController::queueReload):
2754         (LayoutTestController::provisionalLoad):
2755         (EventSender::EventSender):
2756         (EventSender::mouseDown):
2757         (EventSender::mouseUp):
2758         (EventSender::mouseMoveTo):
2759         (EventSender::frameUnderMouse):
2760         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
2761         (LayoutTestController::isLoading):
2762         (LayoutTestController::setLoading):
2763         (LayoutTestController::dumpAsText):
2764         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
2765         (main):
2766
2767 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
2768
2769
2770         - Reverted an accidentally checked in file.
2771
2772         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
2773
2774 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
2775         Reviewed by Sam.
2776
2777         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
2778
2779         * DumpRenderTree/win/DumpRenderTree.vcproj:
2780         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2781
2782 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
2783
2784         Rubber stamped by Adam.
2785
2786         * GdkLauncher: Removed.
2787         * GdkLauncher/Bakefiles.bkgen: Removed.
2788         * GdkLauncher/ENV: Removed.
2789         * GdkLauncher/GdkLauncher.pro: Removed.
2790         * GdkLauncher/gdklauncher.bkl: Removed.
2791         * GdkLauncher/main.cpp: Removed.
2792         * GdkLauncher/mk: Removed.
2793         * GdkLauncher/simple.svg: Removed.
2794         * GdkLauncher/text.html: Removed.
2795         * GtkLauncher: Added.
2796         * GtkLauncher/GdkLauncher.pro: Removed.
2797         * GtkLauncher/GtkLauncher.pro: Added.
2798         * GtkLauncher/main.cpp:
2799         (updateWindowTitle):
2800         (main):
2801         * Scripts/build-webkit:
2802         * Scripts/regenerate-makefiles:
2803         * Scripts/run-javascriptcore-tests:
2804         * Scripts/run-launcher:
2805         * Scripts/run-webkit-tests:
2806         * Scripts/webkitdirs.pm:
2807
2808 2007-09-21  Timothy Hatcher  <timothy@apple.com>
2809
2810         Reviewed by Darin.
2811
2812         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
2813
2814         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
2815         This is tested by plugins/root-object-premature-delete-crash.html.
2816
2817         * DumpRenderTree/mac/ObjCController.m:
2818         (-[ObjCController accessStoredWebScriptObject]):
2819
2820 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
2821
2822         Reviewed by Oliver.
2823
2824         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
2825
2826         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
2827         (FrameLoadDelegate::FrameLoadDelegate):
2828
2829 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
2830
2831         Reviewed by Adam.
2832
2833         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
2834         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
2835
2836         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
2837         Now isQt() and isGdk() use global variables that are only set once.
2838
2839         An array of all the parameters is now given to build-dumprender which includes
2840         the platform on linux.
2841
2842         * Scripts/build-dumprendertree:
2843         * Scripts/run-webkit-tests:
2844         * Scripts/webkitdirs.pm:
2845
2846 2007-09-19  Adam Roben  <aroben@apple.com>
2847
2848         Rubberstamped by Hyatt.
2849
2850         * Spinneret: Removed.
2851
2852 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
2853
2854         Reviewed by David Kilzer.
2855
2856         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
2857
2858 2007-09-18  Sam Weinig  <sam@webkit.org>
2859
2860         Add JSRetainPtr.h #include to fix some builds.
2861
2862         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2863
2864 2007-09-18  Mike Hommey  <glandium@debian.org>
2865
2866         Reviewed by Adam.
2867
2868         * Scripts/prepare-ChangeLog:
2869         - Properly parse GECOS field.
2870         - Use git configuration for user name and email when appropriate.
2871
2872 2007-09-17  Sam Weinig  <sam@webkit.org>
2873
2874         Build fix.
2875
2876         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2877
2878 2007-09-17  Sam Weinig  <sam@webkit.org>
2879
2880         Reviewed by Adam Roben.
2881
2882         Share more code between mac and windows DRT.
2883             - GCController is now shared.
2884             - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
2885
2886         * DumpRenderTree/GCController.cpp:
2887         * DumpRenderTree/win/DumpRenderTree.cpp:
2888         * DumpRenderTree/win/DumpRenderTree.vcproj:
2889         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
2890         (FrameLoadDelegate::FrameLoadDelegate):
2891         (FrameLoadDelegate::~FrameLoadDelegate):
2892         (FrameLoadDelegate::windowScriptObjectAvailable):
2893         * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
2894         * DumpRenderTree/win/GCController.cpp: Removed.
2895         * DumpRenderTree/win/GCController.h: Removed.
2896         * DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp.
2897         (GCController::collect):
2898         (GCController::collectOnAlternateThread):
2899         (GCController::getJSObjectCount):
2900         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
2901         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
2902
2903 2007-09-17  Sam Weinig  <sam@webkit.org>
2904
2905         Reviewed by Adam Roben.
2906
2907         Begin sharing code between mac and windows DRT.
2908             - both now share LayoutTestController.h/cpp and implement platform dependant 
2909               operations in LayoutTestControllerMac/Win.
2910             - DumpRenderTree.h is now shared.
2911             - WorkQueue and WorkQueueItem are also shared.
2912
2913         * DumpRenderTree/DumpRenderTree.h:
2914         * DumpRenderTree/LayoutTestController.cpp:
2915         * DumpRenderTree/win/DumpRenderTree.cpp:
2916         (displayWebView):
2917         (dumpFrameScrollPosition):
2918         (dumpFramesAsText):
2919         (dump):
2920         (runTest):
2921         * DumpRenderTree/win/DumpRenderTree.h: Removed.
2922         * DumpRenderTree/win/DumpRenderTree.vcproj:
2923         * DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
2924         * DumpRenderTree/win/EditingDelegate.cpp:
2925         (EditingDelegate::shouldBeginEditingInDOMRange):
2926         (EditingDelegate::shouldEndEditingInDOMRange):
2927         (EditingDelegate::shouldInsertNode):
2928         (EditingDelegate::shouldInsertText):
2929         (EditingDelegate::shouldDeleteDOMRange):
2930         (EditingDelegate::shouldChangeSelectedDOMRange):
2931         (EditingDelegate::shouldApplyStyle):
2932         (EditingDelegate::shouldChangeTypingStyle):
2933         (EditingDelegate::doPlatformCommand):
2934         (EditingDelegate::webViewDidBeginEditing):
2935         (EditingDelegate::webViewDidChange):
2936         (EditingDelegate::webViewDidEndEditing):
2937         (EditingDelegate::webViewDidChangeTypingStyle):
2938         (EditingDelegate::webViewDidChangeSelection):
2939         * DumpRenderTree/win/LayoutTestController.cpp: Removed.
2940         * DumpRenderTree/win/LayoutTestController.h: Removed.
2941         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Copied from DumpRenderTree/win/LayoutTestController.cpp.
2942         (LayoutTestController::addDisallowedURL):
2943         (LayoutTestController::clearBackForwardList):
2944         (LayoutTestController::copyDecodedHostName):
2945         (LayoutTestController::copyEncodedHostName):
2946         (LayoutTestController::display):
2947         (LayoutTestController::keepWebHistory):
2948         (LayoutTestController::notifyDone):
2949         (LayoutTestController::queueBackNavigation):
2950         (LayoutTestController::queueForwardNavigation):
2951         (jsStringRefToWString):
2952         (LayoutTestController::queueLoad):
2953         (LayoutTestController::queueReload):
2954         (LayoutTestController::queueScript):
2955         (LayoutTestController::setAcceptsEditing):
2956         (LayoutTestController::setCustomPolicyDelegate):
2957         (LayoutTestController::setMainFrameIsFirstResponder):
2958         (LayoutTestController::setTabKeyCyclesThroughElements):
2959         (LayoutTestController::setUseDashboardCompatibilityMode):
2960         (LayoutTestController::setUserStyleSheetEnabled):
2961         (LayoutTestController::setUserStyleSheetLocation):
2962         (LayoutTestController::setWindowIsKey):
2963         (waitUntilDoneWatchdogFired):
2964         (LayoutTestController::setWaitToDump):
2965         (LayoutTestController::windowCount):
2966         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp:
2967         (FrameLoadDelegate::didReceiveTitle):
2968         (FrameLoadDelegate::processWork):
2969         (FrameLoadDelegate::locationChangeDone):
2970         (FrameLoadDelegate::windowScriptObjectAvailable):
2971         * DumpRenderTree/win/WorkQueue.cpp: Removed.
2972         * DumpRenderTree/win/WorkQueue.h: Removed.
2973         * DumpRenderTree/win/WorkQueueItem.cpp: Removed.
2974         * DumpRenderTree/win/WorkQueueItem.h: Removed.
2975         * DumpRenderTree/win/WorkQueueItemWin.cpp: Copied from DumpRenderTree/win/WorkQueueItem.cpp.
2976         (jsStringRefToWString):
2977         (LoadItem::invoke):
2978         (ScriptItem::invoke):
2979
2980 2007-09-17  Sam Weinig  <sam@webkit.org>
2981
2982         Reviewed by Adam Roben.
2983
2984         - Move Windows DumpRenderTree and TestNetscapePlugin to WebCoreTools/DumpRenderTree/win
2985
2986         * DumpRenderTree/DumpRenderTree.sln: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln.
2987         * DumpRenderTree/DumpRenderTree.vcproj: Removed.
2988         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Removed.
2989         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Removed.
2990         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h: Removed.
2991         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Removed.
2992         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Removed.
2993         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed.
2994         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: Removed.
2995         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: Removed.
2996         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: Removed.
2997         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h: Removed.
2998         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp: Removed.
2999         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h: Removed.
3000         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Removed.
3001         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Removed.
3002         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Removed.
3003         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Removed.
3004         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: Removed.
3005         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Removed.
3006         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp: Removed.
3007         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h: Removed.
3008         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: Removed.
3009         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: Removed.
3010         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops: Removed.
3011         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops: Removed.
3012         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops: Removed.
3013         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin: Removed.
3014         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
3015         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
3016         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
3017         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/main.c: Removed.
3018         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/resource.h: Removed.
3019         * DumpRenderTree/win: Added.
3020         * DumpRenderTree/win/DraggingInfo.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h.
3021         * DumpRenderTree/win/DumpRenderTree.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp.
3022         * DumpRenderTree/win/DumpRenderTree.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h.
3023         * DumpRenderTree/win/DumpRenderTree.vcproj: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj.
3024         * DumpRenderTree/win/EditingDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp.
3025         * DumpRenderTree/win/EditingDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h.
3026         * DumpRenderTree/win/EventSender.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp.
3027         * DumpRenderTree/win/EventSender.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h.
3028         * DumpRenderTree/win/GCController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp.
3029         * DumpRenderTree/win/GCController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h.
3030         * DumpRenderTree/win/LayoutTestController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp.
3031         * DumpRenderTree/win/LayoutTestController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h.
3032         * DumpRenderTree/win/TestNetscapePlugin: Copied from DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin.
3033         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3034         * DumpRenderTree/win/UIDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp.
3035         * DumpRenderTree/win/UIDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h.
3036         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp.
3037         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h.
3038         * DumpRenderTree/win/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
3039         * DumpRenderTree/win/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
3040         * DumpRenderTree/win/WorkQueueItem.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp.
3041         * DumpRenderTree/win/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
3042         * DumpRenderTree/win/debug.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops.
3043         * DumpRenderTree/win/debug_internal.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops.
3044         * DumpRenderTree/win/release.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops.
3045         * Scripts/run-webkit-tests: Update to point to the new location of the sln.
3046
3047 2007-09-15  Mark Rowe  <mrowe@apple.com>
3048
3049         Build fix for DumpRenderTree.
3050
3051         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Reinstate -Wno-deprecated-declarations on DumpRenderTree.mm.
3052
3053 2007-09-14  Sam Weinig  <sam@webkit.org>
3054
3055         Rubber stamped by Adam Roben.
3056
3057         Split the WaitUntilDoneDelegate into a UIDelegate and a FrameLoadDelegate.
3058           - The UIDelegate was put into a new file while the FrameLoadDelegate was
3059             kept in the WaitUntilDoneDelegate file for the time being.
3060
3061         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3062         (main):
3063         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
3064         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Added.
3065         (UIDelegate::QueryInterface):
3066         (UIDelegate::AddRef):
3067         (UIDelegate::Release):
3068         (UIDelegate::hasCustomMenuImplementation):
3069         (UIDelegate::setFrame):
3070         (UIDelegate::webViewFrame):
3071         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3072         (UIDelegate::webViewAddMessageToConsole):
3073         (UIDelegate::doDragDrop):
3074         (UIDelegate::webViewGetDlgCode):
3075         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Added.
3076         (UIDelegate::UIDelegate):
3077         (UIDelegate::createWebViewWithRequest):
3078         (UIDelegate::webViewShow):
3079         (UIDelegate::webViewClose):
3080         (UIDelegate::webViewFocus):
3081         (UIDelegate::webViewUnfocus):
3082         (UIDelegate::webViewFirstResponder):
3083         (UIDelegate::makeFirstResponder):
3084         (UIDelegate::setStatusText):
3085         (UIDelegate::webViewStatusText):
3086         (UIDelegate::webViewAreToolbarsVisible):
3087         (UIDelegate::setToolbarsVisible):
3088         (UIDelegate::webViewIsStatusBarVisible):
3089         (UIDelegate::setStatusBarVisible):
3090         (UIDelegate::webViewIsResizable):
3091         (UIDelegate::setResizable):
3092         (UIDelegate::setContentRect):
3093         (UIDelegate::webViewContentRect):
3094         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3095         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3096         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
3097         (UIDelegate::runOpenPanelForFileButtonWithResultListener):
3098         (UIDelegate::mouseDidMoveOverElement):
3099         (UIDelegate::contextMenuItemsForElement):
3100         (UIDelegate::validateUserInterfaceItem):
3101         (UIDelegate::shouldPerformAction):
3102         (UIDelegate::dragDestinationActionMaskForDraggingInfo):
3103         (UIDelegate::willPerformDragDestinationAction):
3104         (UIDelegate::dragSourceActionMaskForPoint):
3105         (UIDelegate::willPerformDragSourceAction):
3106         (UIDelegate::contextMenuItemSelected):
3107         (UIDelegate::trackCustomPopupMenu):
3108         (UIDelegate::measureCustomMenuItem):
3109         (UIDelegate::drawCustomMenuItem):
3110         (UIDelegate::addCustomMenuDrawingData):
3111         (UIDelegate::cleanUpCustomMenuDrawingData):
3112         (UIDelegate::canTakeFocus):
3113         (UIDelegate::takeFocus):
3114         (UIDelegate::registerUndoWithTarget):
3115         (UIDelegate::removeAllActionsWithTarget):
3116         (UIDelegate::setActionTitle):
3117         (UIDelegate::undo):
3118         (UIDelegate::redo):
3119         (UIDelegate::canUndo):
3120         (UIDelegate::canRedo):
3121         (UIDelegate::webViewResizerRect):
3122         (UIDelegate::webViewDrawResizer):
3123         (UIDelegate::webViewScrolled):
3124         (UIDelegate::webViewShouldInterruptJavaScript):
3125         (UIDelegate::webViewReceivedFocus):
3126         (UIDelegate::webViewLostFocus):
3127         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
3128         (FrameLoadDelegate::QueryInterface):
3129         (FrameLoadDelegate::AddRef):
3130         (FrameLoadDelegate::Release):
3131         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
3132         (FrameLoadDelegate::didCommitLoadForFrame):
3133         (FrameLoadDelegate::didReceiveTitle):
3134         (FrameLoadDelegate::processWork):
3135         (processWorkTimer):
3136         (FrameLoadDelegate::locationChangeDone):
3137         (FrameLoadDelegate::didFinishLoadForFrame):
3138         (FrameLoadDelegate::didFailLoadWithError):
3139         (FrameLoadDelegate::windowScriptObjectAvailable):
3140         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h:
3141         (FrameLoadDelegate::FrameLoadDelegate):
3142
3143 2007-09-14  Sam Weinig  <sam@webkit.org>
3144
3145         Reviewed by Kevin McCullough.
3146
3147         Move mac specific globals in to mac/DumpRenderTreeMac.h
3148
3149         * DumpRenderTree/DumpRenderTree.h:
3150         * DumpRenderTree/DumpRenderTree.mm: Removed.
3151         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3152         * DumpRenderTree/mac/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.mm.
3153         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added.
3154
3155 2007-09-14  Brady Eidson  <beidson@apple.com>
3156
3157         Rubberstamped by Weinig
3158
3159         You know, Sam, some of us use case-sensitve filesystems...
3160
3161         * DumpRenderTree/DumpRenderTree.h:
3162         * DumpRenderTree/mac/UIDelegate.mm:
3163
3164 2007-09-14  Sam Weinig  <sam@webkit.org>
3165
3166         Rubber stamped by Adam Roben.
3167
3168         - Move dump state data to LayoutTestContoller and add getter/setters to accommodate.
3169         - Move mac specific DumpRenderTree files to DumpRenderTree/mac
3170
3171         * DumpRenderTree/AppleScriptController.h: Removed.
3172         * DumpRenderTree/AppleScriptController.m: Removed.
3173         * DumpRenderTree/DumpRenderTree.h:
3174         * DumpRenderTree/DumpRenderTree.mm:
3175         (startJavaScriptThreads):
3176         (stopJavaScriptThreads):
3177         (activateAhemFont):
3178         (setDefaultColorProfileToRGB):
3179         (makeLargeMallocFailSilently):
3180         (dumpFrameScrollPosition):
3181         (dumpFramesAsText):
3182         (dump):
3183         (runTest):
3184         (-[DumpRenderTreeWindow isKeyWindow]):
3185         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3186         * DumpRenderTree/DumpRenderTreeDraggingInfo.h: Removed.
3187         * DumpRenderTree/DumpRenderTreeDraggingInfo.m: Removed.
3188         * DumpRenderTree/EditingDelegate.h: Removed.
3189         * DumpRenderTree/EditingDelegate.m: Removed.
3190         * DumpRenderTree/EventSendingController.h: Removed.
3191         * DumpRenderTree/EventSendingController.m: Removed.
3192         * DumpRenderTree/FrameLoadDelegate.h: Removed.
3193         * DumpRenderTree/FrameLoadDelegate.mm: Removed.
3194         * DumpRenderTree/GCController.mm: Removed.
3195         * DumpRenderTree/ImageDiff.m: Removed.
3196         * DumpRenderTree/LayoutTestController.cpp:
3197         (LayoutTestController::LayoutTestController):
3198         (dumpAsTextCallback):
3199         (dumpBackForwardListCallback):
3200         (dumpChildFramesAsTextCallback):
3201         (dumpChildFrameScrollPositionsCallback):
3202         (dumpDOMAsWebArchiveCallback):
3203         (dumpEditingCallbacksCallback):
3204         (dumpFrameLoadCallbacksCallback):
3205         (dumpResourceLoadCallbacksCallback):
3206         (dumpSelectionRectCallback):
3207         (dumpSourceAsWebArchiveCallback):
3208         (dumpTitleChangesCallback):
3209         (repaintSweepHorizontallyCallback):
3210         (setCallCloseOnWebViewsCallback):
3211         (setCanOpenWindowsCallback):
3212         (setCloseRemainingWindowsWhenCompleteCallback):
3213         (testRepaintCallback):
3214         (addFileToPasteboardOnDragCallback):
3215         (waitUntilDoneCallback):
3216         * DumpRenderTree/LayoutTestController.h:
3217         (LayoutTestController::dumpAsText):
3218         (LayoutTestController::setDumpAsText):
3219         (LayoutTestController::dumpBackForwardList):
3220         (LayoutTestController::setDumpBackForwardList):
3221         (LayoutTestController::dumpChildFrameScrollPositions):
3222         (LayoutTestController::setDumpChildFrameScrollPositions):
3223         (LayoutTestController::dumpChildFramesAsText):
3224         (LayoutTestController::setDumpChildFramesAsText):
3225         (LayoutTestController::dumpDOMAsWebArchive):
3226         (LayoutTestController::setDumpDOMAsWebArchive):
3227         (LayoutTestController::dumpSelectionRect):
3228         (LayoutTestController::setDumpSelectionRect):
3229         (LayoutTestController::dumpSourceAsWebArchive):
3230         (LayoutTestController::setDumpSourceAsWebArchive):
3231         (LayoutTestController::dumpTitleChanges):
3232         (LayoutTestController::setDumpTitleChanges):
3233         (LayoutTestController::dumpEditingCallbacks):
3234         (LayoutTestController::setDumpEditingCallbacks):
3235         (LayoutTestController::dumpResourceLoadCallbacks):
3236         (LayoutTestController::setDumpResourceLoadCallbacks):
3237         (LayoutTestController::dumpFrameLoadCallbacks):
3238         (LayoutTestController::setDumpFrameLoadCallbacks):
3239         (LayoutTestController::addFileToPasteboardOnDrag):
3240         (LayoutTestController::setAddFileToPasteboardOnDrag):
3241         (LayoutTestController::callCloseOnWebViews):
3242         (LayoutTestController::setCallCloseOnWebViews):
3243         (LayoutTestController::canOpenWindows):
3244         (LayoutTestController::setCanOpenWindows):
3245         (LayoutTestController::closeRemainingWindowsWhenComplete):
3246         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3247         (LayoutTestController::testRepaint):
3248         (LayoutTestController::setTestRepaint):
3249         (LayoutTestController::testRepaintSweepHorizontally):
3250         (LayoutTestController::setTestRepaintSweepHorizontally):
3251         (LayoutTestController::waitToDump):
3252         (LayoutTestController::windowIsKey):
3253         * DumpRenderTree/LayoutTestControllerMac.mm: Removed.
3254         * DumpRenderTree/NavigationController.h: Removed.
3255         * DumpRenderTree/NavigationController.m: Removed.
3256         * DumpRenderTree/ObjCController.h: Removed.
3257         * DumpRenderTree/ObjCController.m: Removed.
3258         * DumpRenderTree/ObjCPlugin.h: Removed.
3259         * DumpRenderTree/ObjCPlugin.m: Removed.
3260         * DumpRenderTree/ObjCPluginFunction.h: Removed.
3261         * DumpRenderTree/ObjCPluginFunction.m: Removed.
3262         * DumpRenderTree/PolicyDelegate.h: Removed.
3263         * DumpRenderTree/PolicyDelegate.m: Removed.
3264         * DumpRenderTree/ResourceLoadDelegate.h: Removed.
3265         * DumpRenderTree/ResourceLoadDelegate.m: Removed.
3266         * DumpRenderTree/TextInputController.h: Removed.
3267         * DumpRenderTree/TextInputController.m: Removed.
3268         * DumpRenderTree/UIDelegate.h: Removed.
3269         * DumpRenderTree/UIDelegate.mm: Removed.
3270         * DumpRenderTree/WorkQueueItemMac.mm: Removed.
3271         * DumpRenderTree/mac: Added.
3272         * DumpRenderTree/mac/AppleScriptController.h: Copied from DumpRenderTree/AppleScriptController.h.
3273         * DumpRenderTree/mac/AppleScriptController.m: Copied from DumpRenderTree/AppleScriptController.m.
3274         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.h.
3275         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.m.
3276         * DumpRenderTree/mac/EditingDelegate.h: Copied from DumpRenderTree/EditingDelegate.h.
3277         * DumpRenderTree/mac/EditingDelegate.mm: Copied from DumpRenderTree/EditingDelegate.m.
3278         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
3279         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
3280         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
3281         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
3282         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
3283         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
3284         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
3285         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
3286         (-[EditingDelegate webViewDidBeginEditing:]):
3287         (-[EditingDelegate webViewDidChange:]):
3288         (-[EditingDelegate webViewDidEndEditing:]):
3289         (-[EditingDelegate webViewDidChangeTypingStyle:]):
3290         (-[EditingDelegate webViewDidChangeSelection:]):
3291         * DumpRenderTree/mac/EventSendingController.h: Copied from DumpRenderTree/EventSendingController.h.
3292         * DumpRenderTree/mac/EventSendingController.mm: Copied from DumpRenderTree/EventSendingController.m.
3293         * DumpRenderTree/mac/FrameLoadDelegate.h: Copied from DumpRenderTree/FrameLoadDelegate.h.
3294         * DumpRenderTree/mac/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.mm.
3295         (-[FrameLoadDelegate init]):
3296         (-[FrameLoadDelegate dealloc]):
3297         (-[FrameLoadDelegate processWork:]):
3298         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
3299         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3300         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
3301         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3302         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
3303         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
3304         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
3305         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3306         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
3307         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
3308         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
3309         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
3310         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
3311         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
3312         (-[FrameLoadDelegate webView:willCloseFrame:]):
3313         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
3314         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
3315         * DumpRenderTree/mac/GCControllerMac.mm: Copied from DumpRenderTree/GCController.mm.
3316         * DumpRenderTree/mac/ImageDiff.m: Copied from DumpRenderTree/ImageDiff.m.
3317         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Copied from DumpRenderTree/LayoutTestControllerMac.mm.
3318         (LayoutTestController::notifyDone):
3319         (LayoutTestController::setWindowIsKey):
3320         (LayoutTestController::setWaitToDump):
3321         * DumpRenderTree/mac/NavigationController.h: Copied from DumpRenderTree/NavigationController.h.
3322         * DumpRenderTree/mac/NavigationController.m: Copied from DumpRenderTree/NavigationController.m.
3323         * DumpRenderTree/mac/ObjCController.h: Copied from DumpRenderTree/ObjCController.h.
3324         * DumpRenderTree/mac/ObjCController.m: Copied from DumpRenderTree/ObjCController.m.
3325         * DumpRenderTree/mac/ObjCPlugin.h: Copied from DumpRenderTree/ObjCPlugin.h.
3326         * DumpRenderTree/mac/ObjCPlugin.m: Copied from DumpRenderTree/ObjCPlugin.m.
3327         * DumpRenderTree/mac/ObjCPluginFunction.h: Copied from DumpRenderTree/ObjCPluginFunction.h.
3328         * DumpRenderTree/mac/ObjCPluginFunction.m: Copied from DumpRenderTree/ObjCPluginFunction.m.
3329         * DumpRenderTree/mac/PolicyDelegate.h: Copied from DumpRenderTree/PolicyDelegate.h.
3330         * DumpRenderTree/mac/PolicyDelegate.mm: Copied from DumpRenderTree/PolicyDelegate.m.
3331         * DumpRenderTree/mac/ResourceLoadDelegate.h: Copied from DumpRenderTree/ResourceLoadDelegate.h.
3332         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Copied from DumpRenderTree/ResourceLoadDelegate.m.
3333         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3334         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3335         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
3336         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
3337         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
3338         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
3339         * DumpRenderTree/mac/TextInputController.h: Copied from DumpRenderTree/TextInputController.h.
3340         * DumpRenderTree/mac/TextInputController.m: Copied from DumpRenderTree/TextInputController.m.
3341         * DumpRenderTree/mac/UIDelegate.h: Copied from DumpRenderTree/UIDelegate.h.
3342         * DumpRenderTree/mac/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.mm.
3343         (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
3344         (-[UIDelegate webViewFocus:]):
3345         (-[UIDelegate webView:createWebViewWithRequest:]):
3346         (-[UIDelegate webViewClose:]):
3347         * DumpRenderTree/mac/WorkQueueItemMac.mm: Copied from DumpRenderTree/WorkQueueItemMac.mm.
3348
3349 2007-09-14  Kevin McCullough  <kmccullough@apple.com>
3350
3351         Reviewed by Adam.
3352
3353         - Changing Win version of Drosera work with recent changes.
3354
3355         * Drosera/DebuggerDocument.cpp:
3356         * Drosera/DebuggerDocument.h:
3357         * Drosera/mac/DebuggerDocumentPlatform.mm:
3358         (NSStringCreateWithJSStringRef):
3359         (JSValueRefCreateWithNSString):
3360         * Drosera/win/DebuggerClient.cpp:
3361         (DebuggerClient::stepInto):
3362         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3363
3364 2007-09-13  Kevin McCullough  <kmccullough@apple.com>
3365
3366         Reviewed by Tim.
3367
3368         - Moved isPaused into the JS for efficiency and simplicity.
3369
3370         * Drosera/DebuggerDocument.cpp:
3371         (DebuggerDocument::DebuggerDocument):
3372         (DebuggerDocument::pauseCallback):
3373         (DebuggerDocument::resumeCallback):
3374         (DebuggerDocument::isPaused):
3375         (DebuggerDocument::staticFunctions):
3376         * Drosera/DebuggerDocument.h:
3377         * Drosera/console.js:
3378         * Drosera/debugger.js:
3379         * Drosera/mac/DebuggerClient.mm:
3380         (-[DebuggerClient validateUserInterfaceItem:]):
3381
3382 2007-09-13  Sam Weinig  <sam@webkit.org>
3383
3384         Rubber stamped by Darin.
3385
3386         Make DumpRenderTree more cross platform ready.
3387         - Convert GCController to use the JSCore API instead of the WebScriptObject.
3388         - Use CF types instead of NS objects.
3389         - General cleanup.
3390
3391         * DumpRenderTree/DumpRenderTree.h:
3392         * DumpRenderTree/DumpRenderTree.mm:
3393         (dumpRenderTree):
3394         (dump):
3395         (runTest):
3396         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3397         * DumpRenderTree/EditingDelegate.m:
3398         * DumpRenderTree/FrameLoadDelegate.h:
3399         * DumpRenderTree/FrameLoadDelegate.mm:
3400         (-[FrameLoadDelegate init]):
3401         (-[FrameLoadDelegate dealloc]):
3402         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3403         * DumpRenderTree/GCController.cpp: Added.
3404         (GCController::GCController):
3405         (GCController::~GCController):
3406         (collectCallback):
3407         (collectOnAlternateThreadCallback):
3408         (getJSObjectCountCallback):
3409         (GCController::makeWindowObject):
3410         (GCController::getJSClass):
3411         (GCController::staticFunctions):
3412         * DumpRenderTree/GCController.h:
3413         * DumpRenderTree/GCController.mm:
3414         (GCController::collect):
3415         (GCController::collectOnAlternateThread):
3416         (GCController::getJSObjectCount):
3417         * DumpRenderTree/LayoutTestController.cpp:
3418         (LayoutTestController::makeWindowObject):
3419         (LayoutTestController::getJSClass):
3420         * DumpRenderTree/LayoutTestController.h:
3421         * DumpRenderTree/LayoutTestControllerMac.mm:
3422         (LayoutTestController::addDisallowedURL):
3423         (waitUntilDoneWatchdogFired):
3424         (LayoutTestController::waitUntilDone):
3425         * DumpRenderTree/ResourceLoadDelegate.m:
3426         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3427
3428 2007-09-12  Sam Weinig  <sam@webkit.org>
3429
3430         Reviewed by Stephanie.
3431
3432         Fix leaks in mac DumpRenderTree.
3433
3434         * DumpRenderTree/FrameLoadDelegate.mm:
3435         (-[FrameLoadDelegate init]): Initalize in the correct order.
3436         (-[FrameLoadDelegate processWork:]): Delete WorkQueueItem's after dequeueing them.
3437         * DumpRenderTree/LayoutTestController.cpp:
3438         (decodeHostNameCallback): Put return value in a temporary JSRetainPtr to ensure it gets released.
3439         (encodeHostNameCallback): ditto.
3440         * DumpRenderTree/LayoutTestController.h:
3441         * DumpRenderTree/LayoutTestControllerMac.mm:
3442         (LayoutTestController::copyDecodedHostName): Rename function to signal that it follows the Create rule.
3443         (LayoutTestController::copyEncodedHostName): ditto
3444         (LayoutTestController::queueLoad): Use a JSRetainPtr to ensure the url gets released.
3445
3446 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
3447
3448         Reviewed by Geof.
3449
3450         - Updated Leopard leak list to include a leak which appears to be fixed in 9A549 but not the version the bot is on.  This will allow us to get the bot green, but later we should remove it.
3451
3452         * Scripts/run-webkit-tests:
3453
3454 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
3455
3456         Reviewed by Darin.
3457
3458         - Simplified code paths and extracted out functions to increase encapsulation.
3459
3460         * Drosera/DebuggerDocument.cpp:
3461         (DebuggerDocument::breakpointEditorHTMLCallback):
3462         (DebuggerDocument::isPausedCallback):
3463         (DebuggerDocument::pauseCallback):
3464         (DebuggerDocument::resumeCallback):
3465         (DebuggerDocument::stepIntoCallback):
3466         (DebuggerDocument::evaluateScriptCallback):
3467         (DebuggerDocument::currentFunctionStackCallback):
3468         (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
3469         (DebuggerDocument::valueForScopeVariableNamedCallback):
3470         (DebuggerDocument::logCallback):
3471         * Drosera/DebuggerDocument.h:
3472         (DebuggerDocument::getPaused):
3473         * Drosera/mac/DebuggerClient.mm:
3474         (-[DebuggerClient pause:]):
3475         (-[DebuggerClient resume:]):
3476         (-[DebuggerClient stepInto:]):
3477         (-[DebuggerClient stepOver:]):
3478         (-[DebuggerClient stepOut:]):
3479         (-[DebuggerClient showConsole:]):
3480         (-[DebuggerClient closeCurrentFile:]):
3481         (-[DebuggerClient validateUserInterfaceItem:]):
3482         * Drosera/mac/DebuggerDocumentPlatform.mm: Added.
3483         (+[NSString stringOrNilFromWebScriptResult:]):
3484         (DebuggerDocument::platformPause):
3485         (DebuggerDocument::platformResume):
3486         (DebuggerDocument::platformStepInto):
3487         (DebuggerDocument::platformEvaluateScript):
3488         (DebuggerDocument::getPlatformCurrentFunctionStack):
3489         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3490         (DebuggerDocument::platformValueForScopeVariableNamed):
3491         (DebuggerDocument::platformLog):
3492         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3493
3494 2007-09-12  Sam Weinig  <sam@webkit.org>
3495
3496         Build fix for Buildbot.
3497
3498         * DumpRenderTree/DumpRenderTree.mm:
3499         (dump):
3500
3501 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
3502
3503         Reviewed by Geoff.
3504
3505         - Updated the leaks list for leopard to help identify regressions.
3506
3507         * Scripts/run-webkit-tests:
3508
3509 2007-09-12  Sam Weinig  <sam@webkit.org>
3510
3511         Rubber stamped by Darin.
3512
3513         Convert the LayoutTestController to use the JSCore API instead of WebScriptObject.
3514
3515         * DumpRenderTree/DumpRenderTree.h: Re-order variables. 
3516         * DumpRenderTree/DumpRenderTree.m: Removed.
3517         * DumpRenderTree/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.m.
3518         (stopJavaScriptThreads): Fix initialization.
3519         (setDefaultColorProfileToRGB): Add explicit cast from void*.
3520         (dumpRenderTree): Ditto.
3521         (runTest):
3522         Used the WorkQueue from the windows DRT instead of the old NSMutableArray one.
3523
3524         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3525         * DumpRenderTree/FrameLoadDelegate.h: Add LayoutTestController instance variable.
3526         * DumpRenderTree/FrameLoadDelegate.m: Removed.
3527         * DumpRenderTree/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.m.
3528         (-[FrameLoadDelegate init]):
3529         (-[FrameLoadDelegate dealloc]):
3530         (-[FrameLoadDelegate processWork:]):
3531         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
3532         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3533         Convert to use the new JSCore based LayoutTestController and the new WorkQueue.
3534         
3535         * DumpRenderTree/LayoutTestController.cpp: Added.
3536         (LayoutTestController::LayoutTestController):
3537         (LayoutTestController::~LayoutTestController):
3538         (dumpAsTextCallback):
3539         (dumpBackForwardListCallback):
3540         (dumpChildFramesAsTextCallback):
3541         (dumpChildFrameScrollPositionsCallback):
3542         (dumpDOMAsWebArchiveCallback):
3543         (dumpEditingCallbacksCallback):
3544         (dumpFrameLoadCallbacksCallback):
3545         (dumpResourceLoadCallbacksCallback):
3546         (dumpSelectionRectCallback):
3547         (dumpSourceAsWebArchiveCallback):
3548         (dumpTitleChangesCallback):
3549         (repaintSweepHorizontallyCallback):
3550         (setCallCloseOnWebViewsCallback):
3551         (setCanOpenWindowsCallback):
3552         (setCloseRemainingWindowsWhenCompleteCallback):
3553         (testRepaintCallback):
3554         (addFileToPasteboardOnDragCallback):
3555         (addDisallowedURLCallback):