WebKitTools/ChangeLog

   1 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
   2
   3         Reviewed by Eric Seidel.
   4
   5         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
   6
   7         https://bugs.webkit.org/show_bug.cgi?id=30763
   8
   9         * pywebsocket/mod_pywebsocket/__init__.py:
  10         * pywebsocket/mod_pywebsocket/dispatch.py:
  11         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
  12         * pywebsocket/mod_pywebsocket/standalone.py:
  13         * pywebsocket/setup.py:
  14         * pywebsocket/test/test_dispatch.py:
  15
  16 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
  17
  18         Reviewed by David Levin.
  19
  20         REGRESSION: 2 failures in run-webkit-unittests
  21         https://bugs.webkit.org/show_bug.cgi?id=30645
  22
  23         * Scripts/modules/cpp_style_unittest.py:
  24         Fixed a few test scenarios which apparently lost some spaces from
  25         text literals.
  26
  27 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
  28
  29         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
  30
  31         * Scripts/webkitdirs.pm:
  32
  33 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
  34
  35         Reviewed by Darin Adler.
  36
  37         Unification of using null device in perl scripts.
  38         https://bugs.webkit.org/show_bug.cgi?id=30572
  39
  40         * Scripts/VCSUtils.pm:
  41         * Scripts/bisect-builds:
  42         * Scripts/resolve-ChangeLogs:
  43         * Scripts/run-iexploder-tests:
  44         * Scripts/run-jsc:
  45         * Scripts/run-mangleme-tests:
  46         * Scripts/run-webkit-tests:
  47         * Scripts/webkitdirs.pm:
  48         Using File::Spec->devnull() instead of hard coded /dev/null.
  49
  50 2009-10-26  Eric Seidel  <eric@webkit.org>
  51
  52         Reviewed by Holger Freyther.
  53
  54         Reviewers are missing from committers.py
  55         https://bugs.webkit.org/show_bug.cgi?id=30733
  56
  57         * Scripts/modules/committers.py:
  58
  59 2009-10-23  Eric Seidel  <eric@webkit.org>
  60
  61         No review, only adding Alice to the list of reviewers.
  62
  63         * Scripts/modules/committers.py:
  64
  65 2009-10-23  Eric Seidel  <eric@webkit.org>
  66
  67         Reviewed by Eric Carlson.
  68
  69         fast/media/mq-transform-02.html failed on Leopard Commit Bot
  70         https://bugs.webkit.org/show_bug.cgi?id=30700
  71
  72         * DumpRenderTree/mac/DumpRenderTree.mm:
  73         (resetDefaultsToConsistentValues): Update QuickTime version check.
  74
  75 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
  76
  77         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get
  78         character measurement APIs that are private on Tiger.
  79
  80         * wx/build/settings.py:
  81
  82 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
  83
  84         Reviewed by NOBODY (build fix).
  85         Build fix following bug #30696.
  86
  87         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  88         (LayoutTestController::evaluateScriptInIsolatedWorld):
  89
  90 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
  91
  92         Reviewed by Sam Weinig & Geoff Garen.
  93
  94         https://bugs.webkit.org/show_bug.cgi?id=30696
  95         Enable isolated-worlds tests on mac.
  96
  97         Add private interface for DRT to invoke execution in a given world.
  98
  99         * DumpRenderTree/LayoutTestController.cpp:
 100         (evaluateScriptInIsolatedWorldCallback):
 101         (LayoutTestController::staticFunctions):
 102         * DumpRenderTree/LayoutTestController.h:
 103         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 104         (LayoutTestController::evaluateScriptInIsolatedWorld):
 105         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 106         (LayoutTestController::evaluateScriptInIsolatedWorld):
 107
 108 2009-10-21  Eric Seidel  <eric@webkit.org>
 109
 110         Reviewed by Adam Barth.
 111
 112         bugzilla-tool's "patch failed to download an apply" error should give more information
 113         https://bugs.webkit.org/show_bug.cgi?id=30632
 114
 115         * Scripts/modules/scm.py:
 116          - Use the common run_command method instead of custom POpen code.
 117          - Make run_command know how to take pipes as input.
 118         * Scripts/modules/scm_unittest.py:
 119          - Add new tests to cover change.
 120          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
 121
 122 2009-10-21  Kent Tamura  <tkent@chromium.org>
 123
 124         Unreviewed.  Adding myself to the committers list.
 125
 126         * Scripts/modules/committers.py:
 127
 128 2009-10-21  Robin Dunn  <robin@alldunn.com>
 129
 130         Reviewed by Kevin Ollivier.
 131
 132         Update the Windows installer builder to work with Vista / Win 7 and with git.
 133
 134         https://bugs.webkit.org/show_bug.cgi?id=30649
 135
 136         * wx/build/build_utils.py:
 137         * wx/packaging/build-mac-installer.py:
 138         * wx/packaging/build-win-installer.py:
 139         * wx/packaging/wxWebKitInstaller.iss.in:
 140
 141 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
 142
 143         Reviewed by Gustavo Noronha.
 144
 145         [GTK] Added conditional code to avoid using
 146         gdk_window_get_root_coords if we do not have a gtk+ release newer
 147         than 2.17.3.
 148         https://bugs.webkit.org/show_bug.cgi?id=30636
 149
 150         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
 151
 152 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
 153
 154         Reviewed by Eric Seidel.
 155
 156         [Qt] Added dummy implementation for keepWebHistory()
 157         https://bugs.webkit.org/show_bug.cgi?id=30592
 158
 159         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 160         (LayoutTestController::keepWebHistory):
 161         * DumpRenderTree/qt/LayoutTestControllerQt.h:
 162
 163 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
 164
 165         Reviewed by Xan Lopez.
 166
 167         [GTK] Fixed the double click condition, it is not double click if
 168         we move in just in one direction.
 169         https://bugs.webkit.org/show_bug.cgi?id=30636
 170
 171         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
 172
 173 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
 174
 175         Reviewed by Xan Lopez.
 176
 177         [GTK] Initialize the events completly before emitting them.
 178         https://bugs.webkit.org/show_bug.cgi?id=30633
 179
 180         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
 181
 182 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
 183
 184         wx build fix. Fix for when linking using --as-needed with gcc.
 185
 186         * wx/browser/wscript:
 187
 188 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
 189
 190         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
 191         to support all the features used by CURL backend.
 192
 193         * wx/build/settings.py:
 194         * wx/install-unix-extras:
 195
 196 2009-10-20  Anton Muhin  <antonm@chromium.org>
 197
 198         Reviewed by Adam Barth.
 199
 200         Add {ager,antonm,yurys}@chromium.org into committers.py
 201         https://bugs.webkit.org/show_bug.cgi?id=30560
 202
 203         * Scripts/modules/committers.py:
 204
 205 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 206
 207         Reviewed by Tor Arne Vestbø.
 208
 209         Make the Netscape Test plugin available to the Qt launcher.
 210
 211         * Scripts/run-launcher:
 212
 213 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
 214
 215         Reviewed by David Levin.
 216
 217         Removed WebSocket runtime settings.
 218         https://bugs.webkit.org/show_bug.cgi?id=29896
 219
 220         WebSocket runtime configuration is supported by chromium/v8 only.
 221
 222         * DumpRenderTree/mac/DumpRenderTree.mm:
 223         (resetDefaultsToConsistentValues):
 224         * DumpRenderTree/win/DumpRenderTree.cpp:
 225         (resetDefaultsToConsistentValues):
 226
 227 2009-10-19  Nate Chapin  <japhet@chromium.org>
 228
 229         Reviewed by Adam Barth.
 230
 231         Add testFail() to test plugin so we can test our handling of a
 232         plugin invoke call returning false.
 233
 234         https://bugs.webkit.org/show_bug.cgi?id=30239
 235
 236         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
 237         (pluginInvoke):
 238         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
 239
 240 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
 241
 242         Reviewed by Gustavo Noronha.
 243
 244         Enable DOM pasting when running layout tests.
 245
 246         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 247         (resetDefaultsToConsistentValues):
 248
 249 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 250
 251         Reviewed by Simon Hausmann.
 252
 253         Use the setPreferredContentsSize method instead
 254         of setFixedContentsSize, as the method has been renamed.
 255
 256         * DumpRenderTree/qt/DumpRenderTree.cpp:
 257         (WebCore::DumpRenderTree::open):
 258         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 259         (LayoutTestController::setFixedContentsSize):
 260
 261 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
 262
 263         Reviewed by Dan Bernstein.
 264
 265         https://bugs.webkit.org/show_bug.cgi?id=30456
 266         Fixes for new Debug_All Windows build configuration.
 267
 268         * DumpRenderTree/win/DumpRenderTree.cpp:
 269         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
 270         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
 271
 272 2009-10-16  Eric Seidel  <eric@webkit.org>
 273
 274         Reviewed by Adam Barth.
 275
 276         commit-queue status bot should list which buildbot is blocking the queue
 277         https://bugs.webkit.org/show_bug.cgi?id=30452
 278
 279         Add new methods and testing.
 280
 281         * Scripts/bugzilla-tool:
 282         * Scripts/modules/buildbot.py:
 283         * Scripts/modules/buildbot_unittest.py:
 284
 285 2009-10-16  Eric Seidel  <eric@webkit.org>
 286
 287         Reviewed by Adam Barth.
 288
 289         run-webkit-tests fails when CWD is not inside a WebKit checkout
 290         https://bugs.webkit.org/show_bug.cgi?id=30451
 291
 292         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
 293         * Scripts/modules/scm_unittest.py:
 294           - Remove use of original_path (we don't need to restore the CWD).
 295           - Don't use '.' to find the webkit checkout, use __file__ instead.
 296
 297 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
 298
 299         Reviewed by Adam Roben.
 300
 301         Add a Debug_All configuration to build entire stack as debug.
 302         Change Debug_Internal to:
 303         - stop using _debug suffix for all WebKit/Safari binaries
 304         - not use _debug as a DLL naming suffix
 305         - use non-debug C runtime lib.
 306
 307         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
 308         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
 309         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
 310         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
 311         Add missing debug.vsprops inherited property sheet.
 312         Add Debug_All configuration.
 313         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
 314         * WinLauncher/WinLauncher.vcproj:
 315         Removed extraneous definitions inherited from vsprops.
 316         Add Debug_All configuration.
 317
 318 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
 319
 320         Reviewed by David Levin.
 321
 322         check-webkit-style is wrong about indent checking in namespaces
 323         in header files and a few other things
 324         https://bugs.webkit.org/show_bug.cgi?id=30362
 325
 326         The few other things include:
 327         + check-webkit-style does not require spaces around the equal sign
 328           inside 'if' statements and around binary operators that take
 329           numeric literals.
 330         + check-webkit-style reports false errors for the / operator
 331           when part of a filename in the #include directive.
 332
 333         * Scripts/modules/cpp_style.py:
 334         Improved indentation checking and space checking around
 335         binary operators. While the checks are still not perfect,
 336         they are clearly better than before.
 337         * Scripts/modules/cpp_style_unittest.py:
 338         Added test cases for the newly supported checks and modified old
 339         test cases to match the new guidelines
 340
 341 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
 342
 343         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
 344
 345         * wx/build/settings.py:
 346
 347 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
 348
 349         Reviewed by David Levin.
 350
 351         Add mod_pywebsocket to test Web Sockets.
 352         http://code.google.com/p/pywebsocket/
 353         https://bugs.webkit.org/show_bug.cgi?id=27490
 354
 355         * pywebsocket/COPYING: Added.
 356         * pywebsocket/MANIFEST.in: Added.
 357         * pywebsocket/README: Added.
 358         * pywebsocket/example/echo_client.py: Added.
 359         * pywebsocket/example/echo_wsh.py: Added.
 360         * pywebsocket/mod_pywebsocket/__init__.py: Added.
 361         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
 362         * pywebsocket/mod_pywebsocket/handshake.py: Added.
 363         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
 364         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
 365         * pywebsocket/mod_pywebsocket/standalone.py: Added.
 366         * pywebsocket/mod_pywebsocket/util.py: Added.
 367         * pywebsocket/setup.py: Added.
 368         * pywebsocket/test/config.py: Added.
 369         * pywebsocket/test/mock.py: Added.
 370         * pywebsocket/test/run_all.py: Added.
 371         * pywebsocket/test/test_dispatch.py: Added.
 372         * pywebsocket/test/test_handshake.py: Added.
 373         * pywebsocket/test/test_mock.py: Added.
 374         * pywebsocket/test/test_msgutil.py: Added.
 375         * pywebsocket/test/test_util.py: Added.
 376         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
 377         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
 378         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
 379         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
 380         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
 381         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
 382         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
 383         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
 384
 385 2009-10-15  James Robinson  <jamesr@google.com>
 386
 387         Reviewed by David Levin.
 388
 389         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
 390
 391         https://bugs.webkit.org/show_bug.cgi?id=30426
 392
 393         * Scripts/modules/cpp_style.py:
 394         * Scripts/modules/cpp_style_unittest.py:
 395
 396 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
 397
 398         Reviewed by Adam Roben.
 399
 400         Fixes <http://webkit.org/b/30411>.
 401         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
 402
 403         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
 404         building Chromium.
 405
 406         * Scripts/pdevenv:
 407
 408 2009-10-15  Robin Dunn  <robin@alldunn.com>
 409
 410         Reviewed by Kevin Ollivier.
 411
 412         Add Mac package building scripts for wx.
 413
 414         https://bugs.webkit.org/show_bug.cgi?id=30405
 415
 416         * wx/build/build_utils.py:
 417         * wx/build/settings.py:
 418         * wx/packaging/build-mac-installer.py: Added.
 419
 420 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
 421
 422         Reviewed by Gustavo Noronha.
 423
 424         Enable Web Sockets support when running layout tests.
 425
 426         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 427         (resetDefaultsToConsistentValues):
 428
 429 2009-10-15  Xan Lopez  <xlopez@igalia.com>
 430
 431         Reviewed by Gustavo Noronha.
 432
 433         Need to initialize event.button.button, since in most cases a
 434         button number is not passed as an argument.
 435
 436         * DumpRenderTree/gtk/EventSender.cpp:
 437         (mouseDownCallback):
 438         (mouseUpCallback):
 439
 440 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
 441
 442         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
 443         the OS if none was explicitly set.
 444
 445         * wx/build/settings.py:
 446
 447 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
 448
 449         Reviewed by Timothy Hatcher.
 450
 451         Web Inspector: enable developers extras within inspector layout tests.
 452
 453         https://bugs.webkit.org/show_bug.cgi?id=30014
 454
 455         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 456         (LayoutTestController::showWebInspector):
 457         (LayoutTestController::closeWebInspector):
 458         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 459         (LayoutTestController::showWebInspector):
 460         (LayoutTestController::closeWebInspector):
 461
 462 2009-10-14  José Millán Soto  <jmillan@igalia.com>
 463
 464         Reviewed by Jan Alonzo.
 465
 466         GtkLauncher is using a deprecated signal
 467         https://bugs.webkit.org/show_bug.cgi?id=30364
 468
 469         Modified GtkLauncher to use notify::title signal instead of
 470         deprecated title-changed signal
 471
 472         * GtkLauncher/main.c:
 473         (notify_title_cb):
 474         (create_browser):
 475
 476 2009-10-14  Brady Eidson  <beidson@apple.com>
 477
 478         Reviewed by Sam Weinig.
 479
 480         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
 481         1 - Disables WebHistory
 482         2 - Doesn't make sense in that context anyway.
 483
 484         * DumpRenderTree/win/DumpRenderTree.cpp:
 485         (createWebViewAndOffscreenWindow):
 486
 487 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
 488
 489         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
 490         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
 491
 492         * wx/build/settings.py:
 493         * wx/install-unix-extras:
 494
 495 2009-10-14  Brady Eidson  <beidson@apple.com>
 496
 497         Reviewed by Sam Weinig.
 498
 499         WebKit Win API should provide a delegate interface for global history.
 500         https://bugs.webkit.org/show_bug.cgi?id=29905
 501
 502         * DumpRenderTree/LayoutTestController.cpp:
 503         (LayoutTestController::LayoutTestController):
 504         * DumpRenderTree/LayoutTestController.h:
 505         (LayoutTestController::dumpHistoryDelegateCallbacks):
 506         (LayoutTestController::setDumpHistoryDelegateCallbacks):
 507
 508         * DumpRenderTree/win/DumpRenderTree.cpp:
 509         (shouldLogHistoryDelegates):
 510         (runTest):
 511         (createWebViewAndOffscreenWindow):
 512         (main):
 513         * DumpRenderTree/win/DumpRenderTree.vcproj:
 514
 515         Add the IWebHistoryDelegate to DRT Windows:
 516         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
 517         (wstringFromBSTR):
 518         (HistoryDelegate::HistoryDelegate):
 519         (HistoryDelegate::~HistoryDelegate):
 520         (HistoryDelegate::QueryInterface):
 521         (HistoryDelegate::AddRef):
 522         (HistoryDelegate::Release):
 523         (HistoryDelegate::didNavigateWithNavigationData):
 524         (HistoryDelegate::didPerformClientRedirectFromURL):
 525         (HistoryDelegate::didPerformServerRedirectFromURL):
 526         (HistoryDelegate::updateHistoryTitle):
 527         (HistoryDelegate::populateVisitedLinksForWebView):
 528         * DumpRenderTree/win/HistoryDelegate.h: Added.
 529
 530         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 531         (LayoutTestController::removeAllVisitedLinks):
 532
 533 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
 534
 535         Reviewed by Simon Hausmann.
 536
 537         [Qt] Implement support for setPOSIXLocale on Qt.
 538         https://bugs.webkit.org/show_bug.cgi?id=30268
 539
 540         * DumpRenderTree/qt/DumpRenderTree.cpp:
 541         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
 542         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 543         (LayoutTestController::setPOSIXLocale):
 544         * DumpRenderTree/qt/LayoutTestControllerQt.h:
 545
 546 2009-10-13  Stephanie Lewis  <slewis@apple.com>
 547
 548         Unreviewed, adding myself to reviewers list.
 549
 550         * Scripts/modules/committers.py:
 551
 552 2009-10-13  Stephanie Lewis  <slewis@apple.com>
 553
 554         Reviewed by Mark Rowe.
 555
 556         Fix null assignment so root tests work again.
 557
 558         * Scripts/webkitdirs.pm:
 559
 560 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
 561
 562         Reviewed by Simon Hausmann.
 563
 564         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
 565         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
 566         This is done in preparation of implementing missing features in DRT.
 567         No functionality changes made yet.
 568
 569         * DumpRenderTree/qt/DumpRenderTree.cpp:
 570         * DumpRenderTree/qt/DumpRenderTree.pro:
 571         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
 572         (EventSender::EventSender):
 573         (EventSender::mouseDown):
 574         (EventSender::mouseUp):
 575         (EventSender::mouseMoveTo):
 576         (EventSender::leapForward):
 577         (EventSender::keyDown):
 578         (EventSender::contextClick):
 579         (EventSender::scheduleAsynchronousClick):
 580         (EventSender::frameUnderMouse):
 581         * DumpRenderTree/qt/EventSenderQt.h: Added.
 582         (EventSender::clearKillRing):
 583         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
 584         (LayoutTestController::LayoutTestController):
 585         (LayoutTestController::reset):
 586         (LayoutTestController::processWork):
 587         (LayoutTestController::maybeDump):
 588         (LayoutTestController::waitUntilDone):
 589         (LayoutTestController::notifyDone):
 590         (LayoutTestController::windowCount):
 591         (LayoutTestController::clearBackForwardList):
 592         (LayoutTestController::dumpEditingCallbacks):
 593         (LayoutTestController::dumpResourceLoadCallbacks):
 594         (LayoutTestController::queueBackNavigation):
 595         (LayoutTestController::queueForwardNavigation):
 596         (LayoutTestController::queueLoad):
 597         (LayoutTestController::queueReload):
 598         (LayoutTestController::queueScript):
 599         (LayoutTestController::provisionalLoad):
 600         (LayoutTestController::timerEvent):
 601         (LayoutTestController::encodeHostName):
 602         (LayoutTestController::decodeHostName):
 603         (LayoutTestController::setJavaScriptProfilingEnabled):
 604         (LayoutTestController::setFixedContentsSize):
 605         (LayoutTestController::setPrivateBrowsingEnabled):
 606         (LayoutTestController::setPopupBlockingEnabled):
 607         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
 608         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
 609         (LayoutTestController::numberOfActiveAnimations):
 610         (LayoutTestController::disableImageLoading):
 611         (LayoutTestController::dispatchPendingLoadRequests):
 612         (LayoutTestController::setDatabaseQuota):
 613         (LayoutTestController::clearAllDatabases):
 614         (LayoutTestController::whiteListAccessFromOrigin):
 615         (LayoutTestController::waitForPolicyDelegate):
 616         (LayoutTestController::overridePreference):
 617         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
 618         (LayoutTestController::isLoading):
 619         (LayoutTestController::setLoading):
 620         (LayoutTestController::shouldDumpAsText):
 621         (LayoutTestController::shouldDumpBackForwardList):
 622         (LayoutTestController::shouldDumpChildrenAsText):
 623         (LayoutTestController::shouldDumpDatabaseCallbacks):
 624         (LayoutTestController::shouldDumpStatusCallbacks):
 625         (LayoutTestController::shouldWaitUntilDone):
 626         (LayoutTestController::canOpenWindows):
 627         (LayoutTestController::shouldDumpTitleChanges):
 628         (LayoutTestController::waitForPolicy):
 629         (LayoutTestController::dumpAsText):
 630         (LayoutTestController::dumpChildFramesAsText):
 631         (LayoutTestController::dumpDatabaseCallbacks):
 632         (LayoutTestController::dumpStatusCallbacks):
 633         (LayoutTestController::setCanOpenWindows):
 634         (LayoutTestController::dumpBackForwardList):
 635         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
 636         (LayoutTestController::display):
 637         (LayoutTestController::dumpTitleChanges):
 638         (LayoutTestController::dumpSelectionRect):
 639         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
 640         (TextInputController::TextInputController):
 641         (TextInputController::doCommand):
 642         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
 643         * DumpRenderTree/qt/WorkQueue.cpp:
 644         * DumpRenderTree/qt/WorkQueue.h:
 645         * DumpRenderTree/qt/WorkQueueItem.h:
 646         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
 647         (findFrameNamed):
 648         (LoadItem::invoke):
 649         (ReloadItem::invoke):
 650         (ScriptItem::invoke):
 651         (BackForwardItem::invoke):
 652         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
 653         * DumpRenderTree/qt/jsobjects.h:
 654
 655 2009-10-13  Dmitry Titov  <dimich@chromium.org>
 656
 657         Not reviewed, adding myself to the list of reviewers.
 658
 659         * Scripts/modules/committers.py:
 660
 661 2009-10-13  Anders Carlsson  <andersca@apple.com>
 662
 663         Reviewed by Sam Weinig.
 664
 665         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
 666
 667         Make the private browsing mode testable by the test plug-in.
 668
 669         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
 670         (pluginGetProperty):
 671         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
 672         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
 673         (NPP_New):
 674         (NPP_SetValue):
 675
 676 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
 677
 678         No review, just adding self to the list of reviewers.
 679
 680         * Scripts/modules/committers.py:
 681
 682 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
 683
 684         Reviewed by Adam Roben.
 685
 686         Web Inspector: Use proper web view in inspector layout
 687         tests for windows.
 688
 689         https://bugs.webkit.org/show_bug.cgi?id=30298
 690
 691         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 692         (LayoutTestController::showWebInspector):
 693         (LayoutTestController::closeWebInspector):
 694         (LayoutTestController::evaluateInWebInspector):
 695
 696 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
 697
 698         Reviewed by Sam Weinig.
 699
 700         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
 701         https://bugs.webkit.org/show_bug.cgi?id=29841
 702
 703         * DumpRenderTree/mac/DumpRenderTree.mm:
 704         (resetDefaultsToConsistentValues):
 705         * DumpRenderTree/win/DumpRenderTree.cpp:
 706         (resetDefaultsToConsistentValues):
 707
 708 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
 709
 710         Reviewed by Dimitri Glazkov.
 711
 712         Chromium Port - Windows
 713         https://bugs.webkit.org/show_bug.cgi?id=29969
 714
 715         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
 716         * Scripts/webkitdirs.pm:
 717
 718 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
 719
 720         Reviewed by Darin Adler.
 721
 722         jsc scripts cleanup and Qt/GTK fix
 723         https://bugs.webkit.org/show_bug.cgi?id=30288
 724
 725         Duplicated jscPath() moved to webkitdirs.pm.
 726         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
 727         Configuration added (release/debug) to path for Qt-port on Windows.
 728
 729         * Scripts/run-javascriptcore-tests:
 730         * Scripts/run-jsc:
 731         * Scripts/run-sunspider:
 732         * Scripts/sunspider-compare-results:
 733         * Scripts/webkitdirs.pm:
 734
 735 2009-10-11  Adam Barth  <abarth@webkit.org>
 736
 737         Unreviewed.  Add Collin to committers.py.
 738
 739         * Scripts/modules/committers.py:
 740
 741 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
 742
 743         wx build fix, add bindings to source/include dirs now that there are sources there.
 744
 745         * wx/build/settings.py:
 746
 747 2009-10-09  Mark Rowe  <mrowe@apple.com>
 748
 749         Reviewed by Brady Eidson.
 750
 751         Enable plug-in halting in DumpRenderTree.
 752
 753         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
 754         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
 755
 756         * DumpRenderTree/mac/DumpRenderTree.mm:
 757         (resetDefaultsToConsistentValues):
 758         * DumpRenderTree/mac/UIDelegate.mm:
 759         (-[UIDelegate webView:shouldHaltPlugin:]):
 760
 761 2009-10-08  Brady Eidson  <beidson@apple.com>
 762
 763         Reviewed by Dan Bernstein.
 764
 765         Ask the History Delegate to populate the visited links hash.
 766         <rdar://problem/7285293> and https://webkit.org/b/29904
 767
 768         Add the ability for LayoutTestController to clear all visited links.
 769         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
 770
 771         * DumpRenderTree/LayoutTestController.cpp:
 772         (LayoutTestController::LayoutTestController):
 773         (removeAllVisitedLinksCallback):
 774         (LayoutTestController::staticFunctions):
 775         * DumpRenderTree/LayoutTestController.h:
 776         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 777         (LayoutTestController::removeAllVisitedLinks):
 778
 779         * DumpRenderTree/mac/HistoryDelegate.mm:
 780         (-[HistoryDelegate populateVisitedLinksForWebView:]):
 781
 782         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 783         (LayoutTestController::removeAllVisitedLinks):
 784         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 785         (LayoutTestController::removeAllVisitedLinks):
 786         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
 787         (LayoutTestController::removeAllVisitedLinks):
 788
 789
 790 2009-10-08  Daniel Bates  <dbates@webkit.org>
 791
 792         Reviewed by Adam Roben.
 793
 794         https://bugs.webkit.org/show_bug.cgi?id=30175
 795
 796         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
 797         the OLE drag-and-drop return value like the function it emulates. Currently,
 798         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine
 799         whether the drag-and-drop operation was successful or was cancelled.
 800
 801         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop
 802         return value according to whether the drop operation was successful or not.
 803
 804         * DumpRenderTree/win/EventSender.cpp:
 805         (doMouseUp): Added parameter oleDragAndDropReturnValue.
 806         (replaySavedEvents): Ditto.
 807         * DumpRenderTree/win/EventSender.h:
 808         * DumpRenderTree/win/UIDelegate.cpp:
 809         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
 810
 811 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
 812
 813         Reviewed by Xan Lopez.
 814
 815         [GTK] Added support for a parameter setting the button that was
 816         pressed in the mouseDown function.
 817         https://bugs.webkit.org/show_bug.cgi?id=30220
 818
 819         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
 820
 821 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
 822
 823         Reviewed by Xan Lopez.
 824
 825         [GTK] Added a line to the bottom of the expected result to match
 826         the output of the test.
 827         https://bugs.webkit.org/show_bug.cgi?id=30220
 828
 829         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
 830         expected.txt:
 831
 832 2009-10-08  Adam Roben  <aroben@apple.com>
 833
 834         Use QueryInterface to get IWebInspectorPrivate
 835
 836         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
 837         accessed in a more standard way
 838
 839         Reviewed by John Sullivan and Tim Hatcher.
 840
 841         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 842         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
 843         by calling IWebViewPrivate::inspector, then use QueryInterface to get
 844         to the IWebInspectorPrivate interface.
 845
 846 2009-10-07  Adam Roben  <aroben@apple.com>
 847
 848         Implement DRT support for origin whitelisting
 849
 850         Fixes <http://webkit.org/b/30185>.
 851
 852         Reviewed by Eric Seidel.
 853
 854         * DumpRenderTree/win/DumpRenderTree.cpp:
 855         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
 856         whitelist, to match Mac DRT.
 857         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 858         (LayoutTestController::whiteListAccessFromOrigin): Call through to
 859         IWebViewPrivate::whiteListAccessFromOrigin.
 860
 861 2009-10-07  Brady Eidson  <beidson@apple.com>
 862
 863         Reviewed by Darin Adler.
 864
 865         Send title changes to the global history delegate.
 866         <rdar://problem/7285293> and https://webkit.org/b/29904
 867
 868         * DumpRenderTree/mac/HistoryDelegate.mm:
 869         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
 870
 871 2009-10-07  Adam Barth  <abarth@webkit.org>
 872
 873         Unreviewed.  Remove some folks from committers.py who were listed on
 874         the WebKit Team wiki page but who weren't actually listed as commit+.
 875         At some point, we should coorelate this list with the committers
 876         mailing list.
 877
 878         * Scripts/modules/committers.py:
 879
 880 2009-10-07  Adam Barth  <abarth@webkit.org>
 881
 882         Unreviewed.  Import a bunch of committers from the WebKit Team page on
 883         the wiki into committers.py.
 884
 885         * Scripts/modules/committers.py:
 886
 887 2009-10-07  Adam Barth  <abarth@webkit.org>
 888
 889         Unreviewed.  Added Aaron Boodman to committers.py.
 890
 891         * Scripts/modules/committers.py:
 892
 893 2009-10-07  Evan Martin  <evan@chromium.org>
 894
 895         Reviewed by Darin Adler.
 896
 897         Add API to LayoutTestController for re/setting the system locale.
 898         https://bugs.webkit.org/show_bug.cgi?id=18994
 899
 900         * DumpRenderTree/LayoutTestController.cpp:
 901         (setLocaleCallback):
 902         (LayoutTestController::staticFunctions):
 903         (LayoutTestController::setLocale):
 904         * DumpRenderTree/LayoutTestController.h:
 905
 906 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
 907
 908         Reviewed by Jan Alonzo.
 909
 910         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
 911         https://bugs.webkit.org/show_bug.cgi?id=29689
 912
 913         Build fix by adding -lfontconfig for DumpRenderTree.
 914
 915         * GNUmakefile.am:
 916
 917 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
 918
 919         Reviewed by Simon Hausmann.
 920
 921         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
 922
 923         * Scripts/run-webkit-tests:
 924
 925 2009-10-07  Xan Lopez  <xlopez@igalia.com>
 926
 927         Reviewed by Gustavo Noronha.
 928
 929         "delete" in EventSender is the backspace key, not the delete one.
 930
 931         * DumpRenderTree/gtk/EventSender.cpp:
 932         (keyDownCallback):
 933
 934 2009-10-07  Xan Lopez  <xlopez@igalia.com>
 935
 936         Reviewed by Gustavo Noronha.
 937
 938         getChildrenWithRange expects as last parameter the end index, not
 939         the length of the range. Correct this and clarify the variable
 940         names to reflect how the code works.
 941
 942         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 943         (AccessibilityUIElement::getChildrenWithRange):
 944         (AccessibilityUIElement::getChildAtIndex):
 945
 946 2009-10-06  Mark Rowe  <mrowe@apple.com>
 947
 948         Reviewed by Simon Fraser.
 949
 950         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
 951
 952         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
 953         the fact we have already changed the working directory to the top of the open source tree.
 954
 955 2009-10-06  Julie Parent  <jparent@chromium.org>
 956
 957         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
 958         rather than my committer email.
 959
 960         * Scripts/modules/committers.py:
 961
 962 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
 963
 964         Reviewed by Eric Seidel.
 965
 966         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
 967
 968         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
 969         it after each layout test as it should do, making the DRT dump additional output
 970         for all of the subsequent layout tests.
 971
 972         * DumpRenderTree/qt/jsobjects.cpp:
 973         (LayoutTestController::reset):
 974
 975 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
 976
 977         Reviewed by Simon Hausmann.
 978
 979         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
 980         fast/dom/assign-to-window-status.html test, which is passing as a result.
 981
 982         https://bugs.webkit.org/show_bug.cgi?id=30127
 983
 984         * DumpRenderTree/qt/DumpRenderTree.cpp:
 985         (WebCore::DumpRenderTree::DumpRenderTree):
 986         (WebCore::DumpRenderTree::statusBarMessage):
 987         * DumpRenderTree/qt/DumpRenderTree.h:
 988         * DumpRenderTree/qt/jsobjects.h:
 989         (LayoutTestController::shouldDumpStatusCallbacks):
 990         (LayoutTestController::dumpStatusCallbacks):
 991
 992 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
 993
 994         Reviewed by Simon Hausmann.
 995
 996         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
 997         ignores the argument indicating which mouse button to trigger.
 998         https://bugs.webkit.org/show_bug.cgi?id=30048
 999
1000         This affects the fast/events/mouse-click-events.html layout test.
1001
1002         * DumpRenderTree/qt/jsobjects.cpp:
1003         (EventSender::mouseDown):
1004         (EventSender::mouseUp):
1005         * DumpRenderTree/qt/jsobjects.h:
1006
1007 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
1008
1009         Reviewed by Simon Hausmann.
1010
1011         [Qt] Fix the EventSender::keyDown() implementation
1012         https://bugs.webkit.org/show_bug.cgi?id=30043
1013
1014         It should post both a key press event and a key release event,
1015         just like other ports do.
1016
1017         * DumpRenderTree/qt/jsobjects.cpp:
1018         (EventSender::keyDown):
1019
1020 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
1021
1022         wx build fix. Add jpeg to the list of libs to link against.
1023
1024         * wx/build/settings.py:
1025
1026 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
1027
1028         Reviewed by Simon Hausmann.
1029
1030         [Qt] EventSender::keyDown() cannot send function-key events.
1031         https://bugs.webkit.org/show_bug.cgi?id=30044
1032
1033         This affects the fast/events/keydown-function-keys.html layout test.
1034
1035         * DumpRenderTree/qt/jsobjects.cpp:
1036         (EventSender::keyDown):
1037
1038 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
1039
1040         Added --wx-compiler-prefix waf option to allow building wxWebKit with
1041         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
1042
1043         * wx/build/settings.py:
1044         * wx/build/wxpresets.py:
1045
1046 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
1047
1048         Reviewed by Timothy Hatcher.
1049
1050         Web Inspector: add testing harness for Web Inspector.
1051
1052         https://bugs.webkit.org/show_bug.cgi?id=30010
1053
1054         * DumpRenderTree/LayoutTestController.cpp:
1055         (showWebInspectorCallback):
1056         (closeWebInspectorCallback):
1057         (evaluateInWebInspectorCallback):
1058         (LayoutTestController::staticFunctions):
1059         * DumpRenderTree/LayoutTestController.h:
1060         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1061         (LayoutTestController::showWebInspector):
1062         (LayoutTestController::closeWebInspector):
1063         (LayoutTestController::evaluateInWebInspector):
1064         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1065         (LayoutTestController::showWebInspector):
1066         (LayoutTestController::closeWebInspector):
1067         (LayoutTestController::evaluateInWebInspector):
1068         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1069         (LayoutTestController::showWebInspector):
1070         (LayoutTestController::closeWebInspector):
1071         (LayoutTestController::evaluateInWebInspector):
1072         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1073         (LayoutTestController::showWebInspector):
1074         (LayoutTestController::closeWebInspector):
1075         (LayoutTestController::evaluateInWebInspector):
1076
1077 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1078
1079         Reviewed by Ariyha Hidayat.
1080
1081         Pass arguments to system() as a string instead of array
1082
1083         When passed as an array entries with a space fail to translate
1084         to two arguments to the child process, so instead of manually
1085         splitting all the entries in @buildArgs we pass the whole thing
1086         as a string instead.
1087
1088         * Scripts/webkitdirs.pm:
1089
1090 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
1091
1092         Reviewed by David Levin.
1093
1094         check-webkit-style misses whitespace errors for operators:
1095         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
1096         https://bugs.webkit.org/show_bug.cgi?id=30021
1097
1098         * Scripts/modules/cpp_style.py:
1099         Added the operators mentioned above to the same list as == and !=.
1100
1101 2009-10-02  Julie Parent  <jparent@chromium.org>
1102
1103         Unreviewed.
1104
1105         Adding myself and Ojan Vafai as committers, because we are committers.
1106
1107         * Scripts/modules/committers.py:
1108
1109 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
1110
1111         Reviewed by Adam Roben.
1112
1113         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
1114         this will help the patch merging process when TryBots are used.
1115
1116         * Scripts/svn-create-patch:
1117
1118 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
1119
1120         Reviewed by Simon Hausmann.
1121
1122         [Qt] Implement layoutTestController.overridePreference().
1123         https://bugs.webkit.org/show_bug.cgi?id=29970
1124
1125         * DumpRenderTree/qt/DumpRenderTree.cpp:
1126         (WebCore::WebPage::WebPage):
1127         (WebCore::WebPage::resetSettings):
1128         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1129         * DumpRenderTree/qt/jsobjects.cpp:
1130         (LayoutTestController::reset):
1131         (LayoutTestController::setPrivateBrowsingEnabled):
1132         (LayoutTestController::setPopupBlockingEnabled):
1133         (LayoutTestController::overridePreference):
1134         * DumpRenderTree/qt/jsobjects.h:
1135
1136 2009-10-01  Chris Marrin  <cmarrin@apple.com>
1137
1138         Reviewed by Oliver Hunt.
1139
1140         Turn on ENABLE_3D_CANVAS in TOT
1141         https://bugs.webkit.org/show_bug.cgi?id=29906
1142
1143         * Scripts/build-webkit:
1144
1145 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1146
1147         Rubberstamped by Simon Hausmann.
1148
1149         Enable HTTP tests for Qt
1150
1151         * Scripts/run-webkit-tests:
1152
1153 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
1154
1155         Reviewed by Dimitri Glazkov.
1156
1157         build-webkit --chromium now also works on cygwin.
1158
1159         https://bugs.webkit.org/show_bug.cgi?id=29973
1160
1161         * Scripts/webkitdirs.pm:
1162
1163 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
1164
1165         Reviewed by Simon Hausmann.
1166
1167         [Qt] Don't use TCmalloc in DumpRenderTree
1168         https://bugs.webkit.org/show_bug.cgi?id=27029
1169
1170         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
1171
1172         * DumpRenderTree/qt/DumpRenderTree.pro:
1173
1174 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
1175
1176         Reviewed by Simon Hausmann.
1177
1178         [Qt] Implement eventSender.scheduleAsynchronousClick().
1179
1180         https://bugs.webkit.org/show_bug.cgi?id=29931
1181
1182         * DumpRenderTree/qt/jsobjects.cpp:
1183         (EventSender::scheduleAsynchronousClick):
1184         * DumpRenderTree/qt/jsobjects.h:
1185
1186 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
1187
1188         Reviewed by Simon Hausmann.
1189
1190         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
1191         fast/events/open-window-from-another-frame.html from the Skipped list.
1192
1193         https://bugs.webkit.org/show_bug.cgi?id=29930
1194
1195         * DumpRenderTree/qt/jsobjects.cpp:
1196         (LayoutTestController::setPopupBlockingEnabled):
1197         * DumpRenderTree/qt/jsobjects.h:
1198
1199 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
1200
1201         Unreviewed.
1202
1203         Added myself to the list of committers.
1204
1205         * Scripts/modules/committers.py:
1206
1207 2009-09-30  Eric Seidel  <eric@webkit.org>
1208
1209         No review, just adding Geoff to the list of reviewers.
1210
1211         * Scripts/modules/committers.py:
1212
1213 2009-09-30  Dan Bernstein  <mitz@apple.com>
1214
1215         Reviewed by Sam Weinig.
1216
1217         Added the WebKit Layout Tests fonts that are referenced in
1218         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
1219
1220         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
1221         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
1222
1223 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
1224
1225         Reviewed by David Kilzer.
1226
1227         Make sunspider scripts work on Windows platform.
1228         https://bugs.webkit.org/show_bug.cgi?id=29656
1229
1230         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
1231         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
1232         * Scripts/webkitdirs.pm: currentPerlPath() added.
1233
1234 2009-09-29  Brady Eidson  <beidson@apple.com>
1235
1236         Rubberstamped by Dan Bernstein.
1237
1238         Fix license and some sorting in new files.
1239
1240         * DumpRenderTree/mac/HistoryDelegate.h:
1241         * DumpRenderTree/mac/HistoryDelegate.mm:
1242
1243 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
1244
1245         Reviewed by David Kilzer.
1246
1247         Fixed how error codes are handled.
1248         https://bugs.webkit.org/show_bug.cgi?id=29898
1249
1250         * Scripts/update-webkit:
1251         * Scripts/update-webkit-chromium:
1252
1253 2009-09-29  Brady Eidson  <beidson@apple.com>
1254
1255         Reviewed by John Sullivan.
1256
1257         Updated way-out-of-date sorting throughout the dump methods/flags.
1258
1259         * DumpRenderTree/LayoutTestController.cpp:
1260         (LayoutTestController::LayoutTestController):
1261         (dumpAsPDFCallback):
1262         (dumpAsTextCallback):
1263         (dumpFrameLoadCallbacksCallback):
1264         (dumpResourceLoadCallbacksCallback):
1265         (LayoutTestController::staticFunctions):
1266
1267         * DumpRenderTree/LayoutTestController.h:
1268         (LayoutTestController::dumpAsText):
1269         (LayoutTestController::setDumpAsText):
1270         (LayoutTestController::dumpFrameLoadCallbacks):
1271         (LayoutTestController::setDumpFrameLoadCallbacks):
1272         (LayoutTestController::dumpSelectionRect):
1273         (LayoutTestController::setDumpSelectionRect):
1274         (LayoutTestController::dumpSourceAsWebArchive):
1275         (LayoutTestController::setDumpSourceAsWebArchive):
1276         (LayoutTestController::dumpStatusCallbacks):
1277         (LayoutTestController::setDumpStatusCallbacks):
1278         (LayoutTestController::dumpTitleChanges):
1279         (LayoutTestController::setDumpTitleChanges):
1280         (LayoutTestController::dumpWillCacheResponse):
1281         (LayoutTestController::setDumpWillCacheResponse):
1282
1283 2009-09-29  Brady Eidson  <beidson@apple.com>
1284
1285         Reviewed by John Sullivan.
1286
1287         WebKit Mac API should provide a delegate interface for global history.
1288         <rdar://problem/7042773> and https://webkit.org/b/29904
1289
1290         Adding the dumping of global history delegate callbacks.
1291
1292         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1293
1294         Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
1295         * DumpRenderTree/mac/DumpRenderTree.mm:
1296         (createWebViewAndOffscreenWindow):
1297         (allocateGlobalControllers):
1298         (shouldLogFrameLoadDelegates):
1299         (shouldLogHistoryDelegates):
1300         (runTest):
1301
1302         Dump history delegate callbacks:
1303         * DumpRenderTree/mac/HistoryDelegate.h: Added.
1304         * DumpRenderTree/mac/HistoryDelegate.mm: Added.
1305         (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
1306         (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
1307         (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
1308
1309 2009-09-29  Daniel Bates  <dbates@webkit.org>
1310
1311         Reviewed by Adam Roben.
1312
1313         https://bugs.webkit.org/show_bug.cgi?id=28902
1314
1315         Fixes an issue where the drop effect returned by Window Dump Render Tree
1316         was always DROPEFFECT_NONE (since it was hard coded to do so).
1317
1318         This patch corrects this issue by determining the actual drop effect
1319         performed by the corresponding drag-and-drop operation so that we can
1320         return it.
1321
1322         * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
1323         (DraggingInfo::DraggingInfo):
1324         (DraggingInfo::performedDropEffect): Added method.
1325         (DraggingInfo::setPerformedDropEffect): Added method.
1326         * DumpRenderTree/win/EventSender.cpp:
1327         (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
1328         Moved delete draggingInfo to UIDelegate::doDragDrop.
1329         * DumpRenderTree/win/UIDelegate.cpp:
1330         (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
1331
1332 2009-09-29  Dan Bernstein  <mitz@apple.com>
1333
1334         Reviewed by Adam Roben.
1335
1336         Remove copying of unnecessary or nonexistent files from the ImageDiff
1337         post-build event.
1338
1339         * DumpRenderTree/win/ImageDiff.vcproj:
1340
1341 2009-09-29  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
1342
1343         Reviewed by David Kilzer.
1344
1345         [Qt] Make build-webkit script work on Windows
1346         https://bugs.webkit.org/show_bug.cgi?id=29802
1347
1348         * Scripts/run-webkit-tests:
1349         * Scripts/webkitdirs.pm:
1350          - Removed unnecessary -p switch for mkdir on Windows.
1351          - Use canonical path, which uses slashes or backslashes depends on platform.
1352          - isWindows() only test for Windows and not for Cyqwin.
1353
1354 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1355
1356         Reviewed by Simon Hausmann.
1357
1358         Fix time measurement in build-webkit after refactoring done in r48853.
1359
1360         * Scripts/build-webkit:
1361
1362 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1363
1364         Reviewed by Tor Arne Vestbø.
1365
1366         [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.
1367         This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.
1368
1369         * DumpRenderTree/qt/DumpRenderTree.cpp:
1370         (WebCore::WebPage::WebPage):
1371
1372 2009-09-29  Jakub Wieczorek  <faw217@gmail.com>
1373
1374         Reviewed by Simon Hausmann.
1375
1376         [Qt] Implement eventSender.contextClick().
1377         https://bugs.webkit.org/show_bug.cgi?id=29821
1378
1379         * DumpRenderTree/qt/jsobjects.cpp:
1380         (EventSender::contextClick):
1381         * DumpRenderTree/qt/jsobjects.h:
1382
1383 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
1384
1385         Reviewed by Eric Seidel.
1386
1387         Add experimentalWebSocketsEnabled in WebPreferences.
1388         https://bugs.webkit.org/show_bug.cgi?id=28941
1389
1390         * DumpRenderTree/mac/DumpRenderTree.mm:
1391         (resetDefaultsToConsistentValues):
1392         * DumpRenderTree/win/DumpRenderTree.cpp:
1393         (resetDefaultsToConsistentValues):
1394
1395 2009-09-28  Yaar Schnitman  <yaar@chromium.org>
1396
1397         Reviewed by David Kilzer.
1398
1399         Integrated chromium port building into webkit tools update-webkit and
1400         build-webkit.
1401
1402         https://bugs.webkit.org/show_bug.cgi?id=29749
1403
1404         * Scripts/build-webkit: When --chromium is specified, will build
1405           the chromium port (currently only Mac is supported).
1406         * Scripts/update-webkit: When --chromium is specified, delegates to
1407           update-webkit-chromium.
1408         * Scripts/webkitdirs.pm: Added chromium specific defs.
1409         * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch
1410           chromium port's dependencies and update its project files.
1411
1412 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
1413
1414         Unreviewed.
1415
1416         Add myself to list of committers.
1417
1418         * Scripts/modules/committers.py:
1419
1420 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
1421
1422         Reviewed by Darin Adler.
1423
1424         run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
1425         https://bugs.webkit.org/show_bug.cgi?id=29771
1426
1427         * Scripts/run-webkit-tests:
1428
1429 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
1430
1431         Reviewed by Simon Hausmann.
1432
1433         [Qt] Implement layoutTestController.waitForPolicyDelegate.
1434         https://bugs.webkit.org/show_bug.cgi?id=25037
1435
1436         * DumpRenderTree/qt/DumpRenderTree.cpp:
1437         (WebCore::WebPage::acceptNavigationRequest):
1438         * DumpRenderTree/qt/DumpRenderTree.pro:
1439         * DumpRenderTree/qt/jsobjects.cpp:
1440         (LayoutTestController::reset):
1441         (LayoutTestController::notifyDone):
1442         (LayoutTestController::waitForPolicyDelegate):
1443         * DumpRenderTree/qt/jsobjects.h:
1444         (LayoutTestController::waitForPolicy):
1445
1446 2009-09-26  David Kilzer  <ddkilzer@apple.com>
1447
1448         <http://webkit.org/b/29764> mark-bug-fixed: add -o|--open switch
1449
1450         Reviewed by Eric Seidel.
1451
1452         The -o|--open switch uses the open(1) command on Mac OS X to
1453         open the bug URL in the default web browser.  If there are
1454         similar mechanisms on other platforms, they may be added later.
1455
1456         * Scripts/mark-bug-fixed:
1457         (MarkBugFixed.__init__): Added -o|--open switch to list of parse
1458         options.
1459         (MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
1460         code into main() and extracted prompting code into
1461         _prompt_user_for_correctness().
1462         (MarkBugFixed._open_bug_in_web_browser): Added.
1463         (MarkBugFixed._prompt_user_for_correctness): Added.
1464         (MarkBugFixed.main): Added logging code from
1465         _determine_bug_id_and_svn_revision().  Added code to call
1466         _open_bug_in_web_browser() if the switch is set.  Added code to
1467         call _prompt_user_for_correctness() when needed.
1468         * Scripts/modules/bugzilla.py:
1469         (Bugzilla.short_bug_url_for_bug_id): Added.
1470
1471 2009-09-26  David Kilzer  <ddkilzer@apple.com>
1472
1473         svn-unapply and svn-apply don't work when used outside multiple svn working directories
1474
1475         <http://webkit.org/b/29744>
1476         <rdar://problem/7252905>
1477
1478         Reviewed by Eric Seidel.
1479
1480         Some users have a workflow where svn-create-patch, svn-apply and
1481         svn-unapply are used outside of multiple svn working
1482         directories.  Instead of aborting the scripts in these cases,
1483         print a warning and assume that Subversion is being used.
1484
1485         * Scripts/VCSUtils.pm:
1486         (determineVCSRoot): Call warn() instead of die() if both isGit()
1487         and isSVN() initially return false.  Set $VCSUtils::isSVN to 1
1488         to enforce the assumption about Subversion, then return
1489         determineSVNRoot().
1490         * Scripts/svn-apply: Switch to using isGit() and isSVN() from
1491         VCSUtils.pm.  They both already cache their values and checking
1492         here is redundant since determineVCSRoot() is called later.
1493
1494 2009-09-26  Zan Dobersek  <zandobersek@gmail.com>
1495
1496         Reviewed by Gustavo Noronha.
1497
1498         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
1499         https://bugs.webkit.org/show_bug.cgi?id=29689
1500
1501         Load test fonts through FontConfig before each test.
1502         This ensures a more proper rendering of the tests.
1503
1504         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1505         (initializeFonts):
1506         (runTest):
1507         (main):
1508         * DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf.
1509         * GNUmakefile.am:
1510
1511 2009-09-25  David Kilzer  <ddkilzer@apple.com>
1512
1513         <http://webkit.org/b/29718> mark-bug-fixed: add -u|--update-only switch
1514
1515         Reviewed by Eric Seidel.
1516
1517         * Scripts/mark-bug-fixed:
1518         (MarkBugFixed.__init__): Added -u|--update-only switch to list
1519         of parse options.
1520         (MarkBugFixed.main): When -u|--update-only is specified, add a
1521         comment to the bug without marking it Resolved/Fixed.
1522
1523 2009-09-25  Darin Adler  <darin@apple.com>
1524
1525         Reviewed by Geoffrey Garen.
1526
1527         * Scripts/prepare-ChangeLog: Leave files from the script-tests directory
1528         out, just as we do for the resources directory.
1529
1530 2009-09-25  Adam Barth  <abarth@webkit.org>
1531
1532         Unreviewed.  Added Tony to committers.py because he's a
1533         committer now.
1534
1535         * Scripts/modules/committers.py:
1536
1537 2009-09-25  Eric Seidel  <eric@webkit.org>
1538
1539         Reviewed by Simon Fraser.
1540
1541         REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
1542         https://bugs.webkit.org/show_bug.cgi?id=28624
1543
1544         Disable hardware compositing on Leopard for versions of QuickTime 7.6.4 and older.
1545
1546         * DumpRenderTree/mac/DumpRenderTree.mm:
1547         (resetDefaultsToConsistentValues):
1548
1549 2009-09-25  Eric Seidel  <eric@webkit.org>
1550
1551         Reviewed by Adam Barth.
1552
1553         commit-queue should auto-retry patches which fail to commit due to out of date files
1554         https://bugs.webkit.org/show_bug.cgi?id=28316
1555
1556         * Scripts/bugzilla-tool:
1557          - Handle new CheckoutNeedsUpdate exception.
1558         * Scripts/modules/logging_unittest.py:
1559          - Call the ScriptError constructor correctly (this test had regressed).
1560         * Scripts/modules/scm.py:
1561          - Added the ability to define custom error handlers for run_command
1562            and added a commit_error_handler which throws CheckoutNeedsUpdate
1563            instead of ScriptError.
1564          - Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible.
1565         * Scripts/modules/scm_unittest.py:
1566          - Added tests of new error handlers.
1567
1568 2009-09-25  Eric Seidel  <eric@webkit.org>
1569
1570         Reviewed by Adam Barth.
1571
1572         commit-queue should give better feedback when failing a patch
1573         https://bugs.webkit.org/show_bug.cgi?id=29316
1574
1575         * Scripts/bugzilla-tool:
1576          - Update ScriptError uses to the new constructor format.
1577          - Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output
1578            so that we can print to both stdout as well as an output buffer for error reporting.
1579          - Update run_and_throw_if_fail to use teed output so that it can report the "output" as part of ScriptError.
1580          - Use e.message_with_output() when failing a patch (this is the real fix here).
1581            I also removed use of "This patch will require manual commit." as that's not always true.
1582          - Add missing word "bug" from log message.
1583         * Scripts/modules/scm.py:
1584          - Make ScriptError save a bunch more data so that error messages can be nicer.
1585          - Update ScriptError callers.
1586
1587 2009-09-24  John Gregg  <johnnyg@google.com>
1588
1589         Reviewed by Eric Seidel.
1590
1591         Enable switch for notifications (experimental) in Page Settings
1592         https://bugs.webkit.org/show_bug.cgi?id=28930
1593
1594         Now that desktop notifications are controlled by run-time switch,
1595         set that switch to true for DumpRenderTree.
1596
1597         * DumpRenderTree/mac/DumpRenderTree.mm:
1598         (resetDefaultsToConsistentValues):
1599         * DumpRenderTree/win/DumpRenderTree.cpp:
1600         (resetDefaultsToConsistentValues):
1601         * DumpRenderTree/win/UIDelegate.cpp:
1602         (UIDelegate::QueryInterface):
1603
1604 2009-09-24  Kevin Ollivier  <kevino@theolliviers.com>
1605
1606         wx build fix. SnowLeopard fixes for Mac dependencies.
1607
1608         * wx/build/build_utils.py:
1609         * wx/build/settings.py:
1610         * wx/install-unix-extras:
1611
1612 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1613
1614         Reviewed by Oliver Hunt.
1615
1616         Add support for DRT to send mouse wheel events.
1617
1618         https://bugs.webkit.org/show_bug.cgi?id=29348
1619         [Gtk] Scrollwheel on horizontal scrollbars should slide horizontally
1620
1621         * DumpRenderTree/gtk/EventSender.cpp:
1622         (mouseWheelToCallback):
1623
1624 2009-09-17  Eric Seidel  <eric@webkit.org>
1625
1626         Reviewed by David Levin.
1627
1628         commit-queue needs web-based status reporting
1629         https://bugs.webkit.org/show_bug.cgi?id=29307
1630
1631         Add a first-pass web-based status for the commit-queue.
1632         The bot is currently reachable at:
1633         http://webkit-commit-queue.appspot.com/
1634
1635         * CommitQueueStatus/app.yaml: Added.
1636          - Application description file required by App Engine.
1637         * CommitQueueStatus/filters/__init__.py: Added.
1638          - Required by python to treat 'filters' as a module.
1639         * CommitQueueStatus/filters/webkit_extras.py: Added.
1640          - Support for turning 'bug 123' and 'patch 123' into links.
1641            This lets us use plain text strings in our logs yet display nice HTML (help prevent XSS attacks on the page).
1642         * CommitQueueStatus/index.html: Added.
1643         * CommitQueueStatus/index.yaml: Added.
1644          - Some auto-generated file from app engine.
1645         * CommitQueueStatus/queue_status.py: Added.
1646          - The core logic of this bot.  We could eventually split this file out into pieces.
1647         * CommitQueueStatus/stylesheets/main.css: Added.
1648          - Some basic lame-o CSS to make the page look less awful.
1649         * CommitQueueStatus/update_status.html: Added.
1650          - The form that the commit-queue (or a human) can use to update the status.
1651         * Scripts/bugzilla-tool:
1652          - Add some very basic update_status calls.
1653         * Scripts/modules/statusbot.py: Added.
1654          - Knows how to post to the CommitQueueStatus web application.
1655
1656 2009-09-24  David Kilzer  <ddkilzer@apple.com>
1657
1658         <http://webkit.org/b/29712> mark-bug-fixed: add -m|--comment switch
1659
1660         Reviewed by Adam Roben.
1661
1662         * Scripts/mark-bug-fixed:
1663         (MarkBugFixed.__init__): Added -m|--comment switch to list of
1664         parse options.
1665         (MarkBugFixed.main): When specified, prepend comment from
1666         -m|--comment command-line switch to the bug comment.
1667
1668 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1669
1670         Reviewed by Jan Alonzo.
1671
1672         [GTK] DRT must display window instead of just realizing, to enable synthesizing events correctly
1673         https://bugs.webkit.org/show_bug.cgi?id=29693
1674
1675         Show the window, to be able to synthesize events correctly.
1676
1677         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1678         (runTest):
1679         (main):
1680
1681 2009-09-24  Oliver Hunt  <oliver@apple.com>
1682
1683         Reviewed by NOBODY(rollout)
1684
1685         Roll out r48712 as it is incorrect.
1686
1687         * DumpRenderTree/mac/ObjCController.m:
1688         (+[ObjCController isSelectorExcludedFromWebScript:]):
1689         (+[ObjCController webScriptNameForSelector:]):
1690
1691 2009-09-24  Benjamin Poulain  <benjamin.poulain@nokia.com>
1692
1693         Reviewed by Eric Seidel.
1694
1695         https://bugs.webkit.org/show_bug.cgi?id=29005
1696         The indices of RuntimeArray should be enumerated like for a regular array.
1697
1698         * DumpRenderTree/mac/ObjCController.m:
1699         (+[ObjCController isSelectorExcludedFromWebScript:]):
1700         (+[ObjCController webScriptNameForSelector:]):
1701         (-[ObjCController arrayOfString]):
1702
1703 2009-09-23  David Kilzer  <ddkilzer@apple.com>
1704
1705         <http://webkit.org/b/28910> Move bugzilla-tool mark-fixed to standalone mark-bug-fixed tool
1706
1707         Reviewed by Darin Adler.
1708
1709         Also fixed a bug where specifying a revision on the command-line
1710         as 'r12345' would fail.  See <http://webkit.org/b/29699>.
1711
1712         * Scripts/bugzilla-tool: Updated module import statements.
1713         (parse_bug_id): Removed.  Moved to bugzilla.py.
1714         (bug_comment_from_svn_revision): Removed.  Moved to comments.py.
1715         (bug_comment_from_commit_text): Removed.  Moved to comments.py.
1716         (MarkBugFixed): Removed.  Code moved to mark-bug-fixed.
1717         (BugzillaTool.__init__): Removed mark-fixed subcommand.
1718         * Scripts/mark-bug-fixed: Added.
1719         * Scripts/modules/bugzilla.py:
1720         (parse_bug_id): Added.  Moved from bugzilla-tool.
1721         * Scripts/modules/comments.py: Added.
1722         (bug_comment_from_svn_revision): Added.  Moved from bugzilla-tool.
1723         (bug_comment_from_commit_text): Added.  Moved from bugzilla-tool.
1724
1725 2009-09-23  Marshall Culpepper  <mculpepper@appcelerator.com>
1726
1727         Reviewed by Eric Seidel.
1728
1729          jpeg.lib is now libjpeg.lib in DRT Cairo dependencies. return
1730          "false" in non-implemented stub for setAlwaysAcceptCookies.
1731          https://bugs.webkit.org/show_bug.cgi?id=29661
1732
1733         * DumpRenderTree/win/DumpRenderTree.vcproj:
1734         * DumpRenderTree/win/DumpRenderTree.cpp:
1735
1736 2009-09-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1737
1738         Reviewed by Xan Lopez.
1739
1740         [GTK] need to dump number of pending unload handlers
1741         https://bugs.webkit.org/show_bug.cgi?id=29685
1742
1743         Implement dumping of the number of pending unload handlers.
1744
1745         The following tests will pass:
1746
1747           fast/loader/unload-form-about-blank.html
1748           fast/loader/unload-form-post-about-blank.html
1749           fast/loader/unload-form-post.html
1750           fast/loader/unload-form.html
1751           fast/loader/unload-hyperlink.html
1752           fast/loader/unload-javascript-url.html
1753           fast/loader/unload-reload.html
1754           fast/loader/unload-window-location.html
1755
1756         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1757         (getFrameNameSuitableForTestResult):
1758         (webViewLoadFinished):
1759
1760 2009-09-22  Shinichiro Hamaji  <hamaji@chromium.org>
1761
1762         Reviewed by Eric Seidel.
1763
1764         js tests should move into jstests subdirectory instead of resources/
1765         https://bugs.webkit.org/show_bug.cgi?id=25880
1766
1767         Remove support of resources directory.
1768
1769         * Scripts/make-script-test-wrappers:
1770
1771 2009-09-22  Eric Seidel  <eric@webkit.org>
1772
1773         No review, only fixing typo (missing space character).
1774
1775         Fix typo from https://bugs.webkit.org/show_bug.cgi?id=29220
1776
1777         * Scripts/run-webkit-tests:
1778
1779 2009-09-22  Eric Seidel  <eric@webkit.org>
1780
1781         Reviewed by Darin Adler.
1782
1783         run-webkit-tests needs a --repeat-each=N option (AAABBBCCC instead of ABCABCABC)
1784         https://bugs.webkit.org/show_bug.cgi?id=29220
1785
1786         * Scripts/run-webkit-tests:
1787
1788 2009-09-22  Eric Seidel  <eric@webkit.org>
1789
1790         Reviewed by David Kilzer.
1791
1792         svn-apply can't handle single-line binary file additions
1793         https://bugs.webkit.org/show_bug.cgi?id=29100
1794
1795         Fixed the regexp and added a unit test.
1796
1797         * Scripts/modules/scm_unittest.py:
1798         * Scripts/svn-apply:
1799
1800 2009-09-11  Eric Seidel  <eric@webkit.org>
1801
1802         Reviewed by David Kilzer.
1803
1804         post-diff and post-commits should be able to find bug urls in ChangeLogs.
1805         https://bugs.webkit.org/show_bug.cgi?id=29206
1806
1807         * Scripts/bugzilla-tool:
1808          - Share common options by adding a PostDiffAsPatchToBug.posting_options() method.
1809          - Rename --no-comment to --add-log-as-comment and reverse behavior.
1810            Comments tend to just be noise.  I'll eventually remove this argument if no one uses it.
1811          - Split out code into helper functions to try and make execute() more legible.
1812          - Make post-diff find the bug url in the ChangeLogs if not passed as an argument.
1813          - Fallback to bug urls in commit diffs, instead of just in commit messages,
1814            meaning post-commits will now find bug urls in ChangeLogs.
1815
1816 2009-09-21  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
1817
1818         Reviewed by Maciej Stachowiak.
1819
1820         --parse-only parameter wasn't passed to SunSpider/sunspider script.
1821         https://bugs.webkit.org/show_bug.cgi?id=29611
1822
1823         * Scripts/run-sunspider: Missing parameter passing added.
1824
1825 2009-09-20  David Kilzer  <ddkilzer@apple.com>
1826
1827         <http://webkit.org/b/29521> run-webkit-tests: use require instead eval to load DumpRenderTreeSupport module
1828
1829         Reviewed by Mark Rowe.
1830
1831         The require statement is like the use statement, except that it
1832         is run during script execution instead of during the 'BEGIN'
1833         phase.  This makes it possible to change @INC before the require
1834         statement is run.  See 'require' and 'use' in the perlfunc(1)
1835         manpage and 'BEGIN' in perlmod(1) manpage.
1836
1837         * Scripts/run-webkit-tests: Replace eval statement with require
1838         statement.
1839
1840 2009-09-18  Kevin Ollivier  <kevino@theolliviers.com>
1841
1842         wx build fixes. Fix the config name under git and allow users to specify
1843         their own waf install for experimenting with new versions.
1844
1845         * Scripts/webkitdirs.pm:
1846         * wx/build/settings.py:
1847
1848 2009-09-18  Alex Milowski  <alex@milowski.com>
1849
1850         Reviewed by Maciej Stachowiak.
1851
1852         Added checkWebCoreMathMLSupport and hasMathMLSupport to support
1853         checking for whether MathML tests should be run
1854
1855         * Scripts/run-webkit-tests:
1856         * Scripts/webkitdirs.pm:
1857
1858 2009-08-28  Darin Adler  <darin@apple.com>
1859
1860         Reviewed by Mark Rowe.
1861
1862         Break more of run-webkit-tests into separate functions
1863         https://bugs.webkit.org/show_bug.cgi?id=29497
1864
1865         Some small steps toward improving run-webkit-tests. My goal is to
1866         refactor much more of the script into functions. Later we can add
1867         parallel test running to the tool. But better structure may help
1868         even if someone decides to translate this into another scripting
1869         language instead.
1870
1871         * Scripts/run-webkit-tests: Break more pieces of the script into
1872         seprate functions. Added readSkippedFiles, findTestsToRun, and
1873         printResults functions. Removed custom code to skip results.html
1874         and instead just put it into the ignoredFiles hash. Fixed some
1875         indentation. Sorted function declarations, global variables,
1876         and options at the top of the file alphabetically so they're not
1877         in a semi-random order.
1878
1879 2009-09-17  Kevin Ollivier  <kevino@theolliviers.com>
1880
1881         wx build fix, add missing dependency.
1882
1883         * wx/browser/wscript:
1884
1885 2009-09-16  Mark Rowe  <mrowe@apple.com>
1886
1887         Split the SnowLeopard build across a few machines.
1888
1889         * BuildSlaveSupport/build.webkit.org-config/config.json:
1890
1891 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
1892
1893         wx build fix to support monolithic builds on Windows.
1894
1895         * wx/build/wxpresets.py:
1896
1897 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
1898
1899         wx build fix, improve debug support and 2.9 support on MSW.
1900
1901         * wx/build/settings.py:
1902         * wx/build/wxpresets.py:
1903
1904 2009-09-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1905
1906         Blind try at fixing new test failure on Windows.
1907
1908         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1909         (FrameLoadDelegate::didReceiveTitle):
1910
1911 2009-09-15  Alex Milowski  <alex@milowski.com>
1912
1913         Reviewed by Tor Arne Vestbø.
1914
1915         Added mathml toggle
1916
1917         * Scripts/build-webkit:
1918
1919 2009-09-15  Kevin Ollivier  <kevino@theolliviers.com>
1920
1921         wx build fix. Allow waf build to support Python < 2.6.
1922
1923         * wx/build/waf_extensions.py:
1924
1925 2009-09-14  Chris Marrin  <cmarrin@apple.com>
1926
1927         Reviewed by Oliver Hunt.
1928
1929         Add LayoutTests infrastructure to enable and disable webgl tests.
1930         https://bugs.webkit.org/show_bug.cgi?id=29254
1931
1932         * Scripts/run-webkit-tests:
1933         * Scripts/webkitdirs.pm:
1934
1935 2009-09-14  Simon Fraser  <simon.fraser@apple.com>
1936
1937         Reviewed by Darin Adler.
1938
1939         Add --iterations option to run-webkit-tests to repeat the tests N times
1940         https://bugs.webkit.org/show_bug.cgi?id=29263
1941
1942         When run with --iterations N, run-webkit-tests will repeat the tests N times.
1943
1944         * Scripts/run-webkit-tests:
1945
1946 2009-09-14  Brady Eidson  <beidson@apple.com>
1947
1948         Not reviewed, maybe should've been:
1949
1950         Cleaning up more Windows-specific fallout from the fix for:
1951         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
1952
1953         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1954         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):  Correct printf() formatter,
1955           and call the correct method to get the Sender.
1956
1957 2009-09-14  Jon Honeycutt  <jhoneycutt@apple.com>
1958
1959         GTK build fix.
1960
1961         Unreviewed.
1962
1963         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1964         (AccessibilityController::setLogScrollingStartEvents):
1965
1966 2009-09-11  Jon Honeycutt  <jhoneycutt@apple.com>
1967
1968         DRT/test part of
1969         <rdar://problem/7197644> WebKit should broadcast an MSAA event when
1970         jumping to a named anchor
1971
1972         https://bugs.webkit.org/show_bug.cgi?id=28899
1973
1974         Reviewed by Adam Roben.
1975
1976         * DumpRenderTree/AccessibilityController.cpp:
1977         (logScrollingStartEventsCallback):
1978         Turn on logging of scrolling start events.
1979         (AccessibilityController::getJSClass):
1980         Add a "logScrollingStartEvents" to the AccessibilityController's JS
1981         class definition.
1982         (AccessibilityController::resetToConsistentState):
1983         Turn off logging of scrolling start events.
1984
1985         * DumpRenderTree/AccessibilityController.h:
1986         Declare setLogScrollingStartEvents(). Add a member for the scrolling
1987         start event hook.
1988
1989         * DumpRenderTree/mac/AccessibilityControllerMac.cpp:
1990         (AccessibilityController::setLogScrollingStartEvents):
1991         Stubbed.
1992
1993         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1994         (AccessibilityController::AccessibilityController):
1995         Initialize the handle to 0.
1996         (logEventProc):
1997         Renamed from logFocusEventProc; now logs scrolling start events, too.
1998         Removed the assertion that the event is a focus event. Added a switch
1999         to print a message for focus, scrolling start, and other, unknown
2000         events.
2001         (AccessibilityController::setLogFocusEvents):
2002         Changed to use logEventProc.
2003         (AccessibilityController::setLogScrollingStartEvents):
2004         If turning logging off, unhook the scrolling start event hook, and clear
2005         the member holding the handle. If turning on, query for the root
2006         accessible, so that accessibility is enabled for the WebView, and call
2007         SetWinEventHook to setup an event hook using logEventProc as the
2008         callback function.
2009
2010 2009-09-14  Brady Eidson  <beidson@apple.com>
2011
2012         Windows build fix.
2013
2014         * DumpRenderTree/LayoutTestController.cpp:
2015         (setAuthenticationPasswordCallback):
2016         (setAuthenticationUsernameCallback):
2017
2018         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2019         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2020
2021 2009-09-14  Brady Eidson  <beidson@apple.com>
2022
2023         Reviewed by Alexey Proskuryakov.
2024
2025         Safari 4 cannot be used to update firmware on Linksys routers.
2026         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
2027
2028         Add the ability for DRT to handle authentication challenges.
2029
2030         * DumpRenderTree/LayoutTestController.cpp:
2031         (setAuthenticationPasswordCallback):
2032         (setAuthenticationUsernameCallback):
2033         (setHandlesAuthenticationChallengesCallback):
2034         (LayoutTestController::staticFunctions):
2035
2036         * DumpRenderTree/LayoutTestController.h:
2037         (LayoutTestController::handlesAuthenticationChallenges):
2038         (LayoutTestController::setHandlesAuthenticationChallenges):
2039         (LayoutTestController::authenticationUsername):
2040         (LayoutTestController::setAuthenticationUsername):
2041         (LayoutTestController::authenticationPassword):
2042         (LayoutTestController::setAuthenticationPassword):
2043
2044         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2045         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
2046
2047         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2048         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2049         * DumpRenderTree/win/ResourceLoadDelegate.h:
2050
2051 2009-09-12  Mark Rowe  <mrowe@apple.com>
2052
2053         Reviewed by Dan Bernstein.
2054
2055         Test for <rdar://problem/6954546> and <rdar://problem/7090444>.
2056
2057         Add a flag on the test plug-in that asks it to clear the document during the call to NPP_New.
2058         This is the trigger for both <rdar://problem/6954546> and <rdar://problem/7090444>.
2059
2060         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2061         (NPP_New):
2062
2063 2009-09-14  Kevin Ollivier  <kevino@theolliviers.com>
2064
2065         wx build fix for non-wxPython builds and a fix for errors when updating swig.py.
2066
2067         * wx/build/build_utils.py:
2068         * wx/build/settings.py:
2069
2070 2009-09-14  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
2071
2072         Reviewed by Tor Arne Vestbø.
2073
2074         [Qt] Build fix for windows build.
2075
2076         * Scripts/bisect-builds: Add missing paranthesis for tmpdir function.
2077
2078 2009-09-13  Kevin Ollivier  <kevino@theolliviers.com>
2079
2080         Fix typo accidently landed in last commit.
2081
2082         * wx/build/settings.py:
2083
2084 2009-09-13  Kevin Ollivier  <kevino@theolliviers.com>
2085
2086         wx build fix, error out if using the wrong Python.
2087
2088         * wx/build/settings.py:
2089
2090 2009-09-13  Xan Lopez  <xlopez@igalia.com>
2091
2092         Build fix for GTK+ < 2.14.
2093
2094         Do not use gtk_widget_get_window, access the window directly
2095         through the struct.
2096
2097         * DumpRenderTree/gtk/EventSender.cpp:
2098         (contextClickCallback):
2099         (mouseDownCallback):
2100         (mouseUpCallback):
2101         (mouseMoveToCallback):
2102         (keyDownCallback):
2103
2104 2009-09-13  Martin Robinson  <martin.james.robinson@gmail.com>
2105
2106         Reviewed by Xan Lopez and Jan Alonzo.
2107
2108         [GTK] EventSender does not set 'window' property on synthesized GDK events
2109         https://bugs.webkit.org/show_bug.cgi?id=29169
2110
2111         Set the window property on synthesized GDK events in the GTK+ EventSender.
2112
2113         * DumpRenderTree/gtk/EventSender.cpp:
2114         (contextClickCallback):
2115         (mouseDownCallback):
2116         (mouseUpCallback):
2117         (mouseMoveToCallback):
2118         (keyDownCallback):
2119
2120 2009-09-12  Drew Wilson  <atwilson@google.com>
2121
2122         Reviewed by Mark Rowe.
2123
2124         run-webkit-tests has a timeout value that is too low
2125         https://bugs.webkit.org/show_bug.cgi?id=29223
2126
2127         * Scripts/run-webkit-tests:
2128         Changed timeout value to 20 seconds to avoid timing out too early.
2129
2130 2009-09-11  Kevin Ollivier  <kevino@theolliviers.com>
2131
2132         wx build fix. Mark dependencies as mandatory and declare which MSVC versions and
2133         architectures are supported for building wxWebKit.
2134
2135         * wx/build/settings.py:
2136
2137 2009-09-11  Eric Seidel  <eric@webkit.org>
2138
2139         Reviewed by David Levin.
2140
2141         bugzilla-tool rollout threw exception under svn
2142         https://bugs.webkit.org/show_bug.cgi?id=29211
2143
2144         * Scripts/modules/scm.py: add missing return, and convert number arguments to strings.
2145         * Scripts/modules/scm_unittest.py: add testing for this fix.
2146
2147 2009-09-11  Brian Weinstein  <bweinstein@apple.com>
2148
2149         Add myself to the committers list.
2150
2151         * Scripts/modules/committers.py:
2152
2153 2009-09-11  Eric Seidel  <eric@webkit.org>
2154
2155         Reviewed by Adam Barth.
2156
2157         bugzilla-tool land-patches should only fail-fast in --commit-queue mode
2158         https://bugs.webkit.org/show_bug.cgi?id=29201
2159
2160         * Scripts/bugzilla-tool:
2161
2162 2009-09-11  Adam Roben  <aroben@apple.com>
2163
2164         Make commit-log-editor move common prefixes to the top of the log
2165
2166         Fies <http://webkit.org/b/29190> commit-log-editor should move common
2167         prefixes to the top of the commit log
2168
2169         Reviewed by Darin Adler.
2170
2171         * Scripts/commit-log-editor: Find and remove the longest common prefix
2172         ending in a double newline from each ChangeLog entry, then put that
2173         common prefix at the top of the commit log.
2174         (removeLongestCommonPrefixEndingInDoubleNewline): Added. Finds,
2175         removes, and returns the longest common prefix ending in a double
2176         newline from a hash of strings
2177
2178 2009-09-11  Eric Seidel  <eric@webkit.org>
2179
2180         Fix obvious typo in previous commit, no review.
2181
2182         bugzilla-tool should automate rollouts
2183         https://bugs.webkit.org/show_bug.cgi?id=26715
2184
2185         * Scripts/bugzilla-tool: add back missing "scm" argument.
2186
2187 2009-09-11  Eric Seidel  <eric@webkit.org>
2188
2189         Reviewed by Adam Barth.
2190
2191         bugzilla-tool should automate rollouts
2192         https://bugs.webkit.org/show_bug.cgi?id=26715
2193
2194         bugzilla-tool rollout will do the rollout locally and leave the diff for you to verify and commit.
2195         The --complete-rollout option will automatically land and update the bug.
2196         Eventually --complete-rollout will be default, but that will require more testing.
2197
2198         This first pass is good enough for others to try and file bugs about.
2199
2200         * Scripts/bugzilla-tool:
2201          - Move modified_changelogs into scm.py.
2202          - Move svn_revision_from_commit_text logic into scm.py.
2203          - Add RolloutCommit command.
2204         * Scripts/modules/bugzilla.py:
2205          - Add reopen_bug command used by RolloutCommit.
2206         * Scripts/modules/scm.py:
2207          - Add functions to support RolloutCommit.
2208          - Abstract find_uuid into value_from_svn_info so it can be re-used for _repository_url (needed by svn merge).
2209          - Add a str() call so that svn_commit_log can take a numeric argument.
2210          - Remove a bunch of very slow code from last_svn_commit_log and used the built-in 'BASE' alias instead.
2211          - Made dry_run commits return something that svn_revision_from_commit_text can parse.
2212         * Scripts/modules/scm_unittest.py:
2213          - Add read_from_path for easy file reading.
2214          - Put test4 on a new line to make reverts work w/o conflict.
2215          - Add an "svn update" call so that the checkout revision matches the server revision.
2216          - Add tests for svn_revision_from_commit_text.
2217          - Add a simple test for apply_reverse_diff.
2218          - Add a new self.scm member and use it in the new tests (eventually other tests can use it too).
2219          - Add test for svn_commit_log to make sure my 'BASE' change above worked as expected.
2220
2221 2009-09-11  Adam Roben  <aroben@apple.com>
2222
2223         Get user script/stylesheet tests running on Windows
2224
2225         Fixes <http://webkit.org/b/29181> User script/stylesheet tests are
2226         skipped on Windows
2227
2228         Reviewed by John Sullivan.
2229
2230         * DumpRenderTree/win/DumpRenderTree.vcproj: Link all configurations
2231         against comsuppw.lib so we can use _bstr_t.
2232
2233         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Fixed #include
2234         order, added #include of comutil.h for _bstr_t.
2235
2236         (bstrT): Helper function to convert a JSStringRef to a _bstr_t.
2237         (LayoutTestController::addUserScript):
2238         (LayoutTestController::addUserStyleSheet):
2239         Implemented. Implementations were based on those in
2240         LayoutTestControllerMac.mm.
2241
2242 2009-09-10  David Kilzer  <ddkilzer@apple.com>
2243
2244         <http://webkit.org/b/29147> run-webkit-tests:  make -h show help
2245
2246         Reviewed by Mark Rowe.
2247
2248         * Scripts/run-webkit-tests: Updated to make -h switch show help.
2249
2250 2009-09-10  Fumitoshi Ukai  <ukai@chromium.org>
2251
2252         Reviewed by Alexey Proskuryakov.
2253
2254         Add WebCore/websockets directory in wx build system.
2255         https://bugs.webkit.org/show_bug.cgi?id=28038
2256
2257         * wx/build/settings.py:
2258
2259 2009-09-10  Martin Robinson  <martin.james.robinson@gmail.com>
2260
2261         [GTK] EventSender does not properly convert some keyDown strings
2262         https://bugs.webkit.org/show_bug.cgi?id=29119
2263
2264         Add more keyDown string to character code conversions for GTK+ EventSender.
2265
2266         * DumpRenderTree/gtk/EventSender.cpp:
2267         (keyDownCallback):
2268
2269 2009-09-09  Steve Block  <steveblock@google.com>
2270
2271         Reviewed by Maciej Stachowiak.
2272
2273         Geolocation Coordinates::toString() prints bogus values for unspecified properties.
2274         https://bugs.webkit.org/show_bug.cgi?id=29080
2275
2276         * Scripts/make-script-test-wrappers: Modified. Adds asynchronous Geolocation tests to exclusion list.
2277
2278 2009-09-09  Eric Seidel  <eric@webkit.org>
2279
2280         Reviewed by Eric Carlson.
2281
2282         reviewer/committer lookups are backwards
2283         https://bugs.webkit.org/show_bug.cgi?id=29113
2284
2285         I also moved Eric Carlson from the committer list to the reviewer list now that he is one.
2286
2287         * Scripts/modules/bugzilla.py:
2288         * Scripts/modules/committers.py:
2289
2290 2009-09-09  Cameron McCormack  <cam@mcc.id.au>
2291
2292         Reviewed by Eric Seidel.
2293
2294         svn-unapply doesn't revert directories correctly
2295         https://bugs.webkit.org/show_bug.cgi?id=29065
2296
2297         * Scripts/svn-unapply: Make svnStatus consistently return status
2298         lines including a newline.
2299         * Scripts/svn-apply: Keep svnStatus in sync with the one in
2300         svn-unapply, in lieu of moving it to a common file.
2301
2302 2009-09-09  Cameron McCormack  <cam@mcc.id.au>
2303
2304         Reviewed by Eric Seidel.
2305
2306         svn-apply doesn't handle changes to files copied to new directories properly
2307         https://bugs.webkit.org/show_bug.cgi?id=29059
2308
2309         * Scripts/svn-apply: Don't treat "--- revision 0" patches as being
2310         additions if we know that we've just copied a file to this name.
2311
2312 2009-09-09  Eric Seidel  <eric@webkit.org>
2313
2314         Reviewed by David Levin.
2315
2316         commit-queue hangs if a builder has never built
2317         https://bugs.webkit.org/show_bug.cgi?id=29091
2318
2319         * Scripts/modules/buildbot.py:
2320         * Scripts/modules/buildbot_unittest.py:
2321
2322 2009-09-09  Zan Dobersek  <zandobersek@gmail.com>
2323
2324         Reviewed by Gustavo Noronha.
2325
2326         [GTK] DumpRenderTree needs eventSender object and implementation
2327         https://bugs.webkit.org/show_bug.cgi?id=25990
2328
2329         Implements most of the EventSender object's functionality for
2330         the DumpRenderTree tool. Implementation still lacks support
2331         for drag and drop tests and forward leaps.
2332
2333         Based on work by Holger Hans Peter Freyther.
2334
2335         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2336         (runTest): Focus on the view before loading a new test.
2337         (webViewWindowObjectCleared):
2338         * DumpRenderTree/gtk/EventSender.cpp: Added.
2339         (getDragModeCallback):
2340         (setDragModeCallback):
2341         (leapForwardCallback):
2342         (contextClickCallback):
2343         (updateClickCount):
2344         (mouseDownCallback):
2345         (mouseUpCallback):
2346         (mouseMoveToCallback):
2347         (beginDragWithFilesCallback):
2348         (replaySavedEvents):
2349         (keyDownCallback):
2350         (textZoomInCallback):
2351         (textZoomOutCallback):
2352         (zoomPageInCallback):
2353         (zoomPageOutCallback):
2354         (getClass):
2355         (makeEventSender):
2356         * DumpRenderTree/gtk/EventSender.h: Added.
2357         * GNUmakefile.am: Add build rules for EventSender.
2358
2359 2009-09-09  Daniel Bates  <dbates@webkit.org>
2360
2361         Reviewed by Adam Roben.
2362
2363         https://bugs.webkit.org/show_bug.cgi?id=28953
2364
2365         Added pre- and post- build events so that on build failure, the file
2366         buildfailed is written to the directory $(WebKitOutputDir).
2367
2368         * WinLauncher/WinLauncher.vcproj:
2369
2370 2009-09-09  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2371
2372         Unreviewed.
2373
2374         Add myself to list of committers.
2375
2376         * Scripts/modules/committers.py:
2377
2378 2009-09-08  Eric Seidel  <eric@webkit.org>
2379
2380         Reviewed by David Levin.
2381
2382         commit-queue gets stuck if a non-committer sets commit-queue+ or review+
2383         https://bugs.webkit.org/show_bug.cgi?id=28605
2384         https://bugs.webkit.org/show_bug.cgi?id=28916
2385
2386         * Scripts/bugzilla-tool:
2387          - Fix comment and adjust reject_patch_from_commit_queue call to pass "manual commit"
2388            comment now that it's used for rejecting patches for invalid committers too.
2389          - Pass reject_invalid_patches=True for commit-queue calls, normally we just ignore patches with invalid reviewers, the commit-queue rejects them.
2390          - Make the commit queue print patches count instead of bugs count, this also fixes https://bugs.webkit.org/show_bug.cgi?id=28916.
2391         * Scripts/modules/bugzilla.py:
2392          - Make _parse_attachment_element not validate reviewer/committer.
2393          - Share flag parsing code in _parse_attachment_flag.
2394          - Add _validate* methods for validating reviewers and committers and updating bugs when validation fails.
2395          - Add reject_invalid_patches argument so the commit-queue can update bugs on failed validation and other "read only" commands will not.
2396          - Add reject_patch_from_review_queue using a new _set_flag_on_attachment abstraction.
2397         * Scripts/modules/bugzilla_unittest.py:
2398          - Update this test to no longer expect committer/reviewer validation.
2399         * Scripts/modules/committers.py:
2400          - Return None on failed lookups instead of raising Exceptions.
2401         * Scripts/modules/committers_unittest.py:
2402          - Update tests to expect None returns instead of exceptions.
2403
2404 2009-09-09  David Kilzer  <ddkilzer@apple.com>
2405
2406         <http://webkit.org/b/29061> Fix obvious copy-paste error in AccessibilityUIElement::clickPointY()
2407
2408         Reviewed by Mark Rowe.
2409
2410         No change to layout test results.
2411
2412         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2413         (AccessibilityUIElement::clickPointY): Changed to return y value
2414         instead of x value.
2415
2416 2009-09-08  Dimitri Glazkov  <dglazkov@chromium.org>
2417
2418         Reviewed by Mark Rowe.
2419
2420         Reduce dglazkov's boboiness by properly concatenating revision value.
2421
2422         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Used substitution
2423             rather than "+".
2424
2425 2009-09-08  Kevin Ollivier  <kevino@theolliviers.com>
2426
2427         wxWebKit Python extension build fix - get swig.py if it doesn't exist.
2428
2429         * wx/build/build_utils.py:
2430
2431 2009-09-08  Mark Rowe  <mrowe@apple.com>
2432
2433         Fix an incorrect variable name in UpdateChromiumSource.
2434
2435         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2436
2437 2009-09-08  Mark Rowe  <mrowe@apple.com>
2438
2439         Don't check for leaks on the release SnowLeopard builder.
2440
2441         * BuildSlaveSupport/build.webkit.org-config/config.json:
2442
2443 2009-09-08  Mark Rowe  <mrowe@apple.com>
2444
2445         Add a SnowLeopard release builder.
2446
2447         * BuildSlaveSupport/build.webkit.org-config/config.json:
2448
2449 2009-09-08  David Levin  <levin@chromium.org>
2450
2451         Reviewed by Darin Adler.
2452
2453         Remove end of line whitespace check from check-webkit-style.
2454         https://bugs.webkit.org/show_bug.cgi?id=29053
2455
2456         * Scripts/modules/cpp_style.py:
2457
2458 2009-09-08  Cameron McCormack  <cam@mcc.id.au>
2459
2460         Reviewed by Darin Adler.
2461
2462         Fix DumpRenderTree build from clean tree on Tiger
2463         https://bugs.webkit.org/show_bug.cgi?id=28927
2464
2465         * DumpRenderTree/mac/PerlSupport/Makefile: Ensure the
2466         DerivedSources/DumpRenderTree directory exists when
2467         building on Tiger.
2468
2469 2009-09-08  Kevin Ollivier  <kevino@theolliviers.com>
2470
2471         wx build fix after introduction of platform/mock directory.
2472
2473         * wx/build/settings.py:
2474
2475 2009-09-08  Yael Aharon  <yael.aharon@nokia.com>
2476
2477         Unreviewed.
2478
2479         Add myself to list of committers.
2480
2481         * Scripts/modules/committers.py:
2482
2483 2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2484
2485         Unreviewed.
2486
2487         Add myself to list of committers.
2488
2489         * Scripts/modules/committers.py:
2490
2491 2009-09-08  Cameron McCormack  <cam@mcc.id.au>
2492
2493         Reviewed by Darin Adler.
2494
2495         prepare-ChangeLog too chatty on file additions
2496         https://bugs.webkit.org/show_bug.cgi?id=29019
2497
2498         * Scripts/prepare-ChangeLog: Omit description of added properties
2499         on newly added files.
2500
2501 2009-09-08  Steve Block  <steveblock@google.com>
2502
2503         Reviewed by Adam Barth.
2504
2505         Adds a LayoutTestController method to set the permission state for Geolocation.
2506         This is required to use the mock Geolocation service for testing.
2507         https://bugs.webkit.org/show_bug.cgi?id=29027
2508
2509         * DumpRenderTree/LayoutTestController.cpp: Modified.
2510         (setDatabaseQuotaCallback): Modified. Style fix.
2511         (setGeolocationPermissionCallback): Added. Sets the Geolocation permission state.
2512         (LayoutTestController::staticFunctions): Modified. Registers the above function on the LayoutTestController.
2513         * DumpRenderTree/LayoutTestController.h: Modified.
2514         (LayoutTestController::setGeolocationPermission): Added. Sets the Geolocation permission state.
2515         (LayoutTestController::isGeolocationPermissionSet): Added. Returns whether the Geolocation permission has been set.
2516         (LayoutTestController::geolocationPermission): Added. Returns the Geolocation permission state.
2517         * DumpRenderTree/mac/UIDelegate.mm: Modified.
2518         (-[UIDelegate webView:frame:requestGeolocationPermission:securityOrigin:]): Added. Implement chrome method to respond to request for Geolocation permission state. Response is made using above methods to access permission state.
2519
2520 2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2521
2522         Reviewed by Simon Hausmann.
2523
2524         [Qt] QtWebKit single API to enable persistency
2525         https://bugs.webkit.org/show_bug.cgi?id=28682
2526
2527         Use the new enablePersistentStorage API instead
2528         of enabling all persistent features one-by-one.
2529
2530         * DumpRenderTree/qt/DumpRenderTree.cpp:
2531         (WebCore::WebPage::WebPage):
2532         (WebCore::DumpRenderTree::DumpRenderTree):
2533
2534 2009-09-07  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2535
2536         Reviewed by Tor Arne Vestbø.
2537
2538         Refactor --strict switch to --ignore-metrics and correct the
2539         implementation to make the feature usable on all platforms.
2540         https://bugs.webkit.org/show_bug.cgi?id=28907
2541
2542         run-webkit-tests --ignore-metrics strips the font related metrics from
2543         the actual and expected data before comparing them.
2544         In this way the render trees can be checked for obvious differences but
2545         a successful test implies by no means that the layout is actually correct.
2546
2547         * Scripts/run-webkit-tests:
2548
2549 2009-09-07  Steve Block  <steveblock@google.com>
2550
2551         Reviewed by Adam Barth.
2552
2553         Adds a mock Geolocation service. This will be used to provide predictable behavior of the
2554         Geolocation API for use in LayoutTests. Later changes will integrate the the mock
2555         Geolocation service with DumpRenderTree.
2556         https://bugs.webkit.org/show_bug.cgi?id=28264
2557
2558         * DumpRenderTree/LayoutTestController.cpp: Modified.
2559         (setMockGeolocationPositionCallback): Added. Configures the mock Geolocation service.
2560         (setMockGeolocationErrorCallback): Added. Configures the mock Geolocation service.
2561         (LayoutTestController::staticFunctions): Added. Registers the above functions on the LayoutTestController.
2562         * DumpRenderTree/LayoutTestController.h: Modified.
2563         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Modified.
2564         (LayoutTestController::setMockGeolocationPosition): Added. Configures the mock Geolocation service.
2565         (LayoutTestController::setMockGeolocationError): Added. Configures the mock Geolocation service.
2566
2567 2009-09-07  Drew Wilson  <atwilson@google.com>
2568
2569         Reviewed by David Levin.
2570
2571         Enable SHARED_WORKERS by default
2572         https://bugs.webkit.org/show_bug.cgi?id=28959
2573
2574         * Scripts/build-webkit:
2575
2576 2009-09-07  Kevin Ollivier  <kevino@theolliviers.com>
2577
2578         wx build fixes for wx SVN trunk.
2579
2580         * wx/build/settings.py:
2581
2582 2009-09-04  Kevin Ollivier  <kevino@theolliviers.com>
2583
2584         wx build fix. Switch USE_ defines over to the compiler so that they can be
2585         checked by files not including config.h (like WebCorePrefix.h).
2586
2587         * wx/build/settings.py:
2588
2589 2009-09-04  Adam Barth  <abarth@webkit.org>
2590
2591         Unreviewed build fix.
2592
2593         Update declaration of FrameLoadDelegate to reflect that
2594         IWebFrameLoadDelegatePrivate2 inherits from
2595         IWebFrameLoadDelegatePrivate.
2596
2597         * DumpRenderTree/win/FrameLoadDelegate.h:
2598
2599 2009-09-04  Adam Barth  <abarth@webkit.org>
2600
2601         Reviewed by Eric Seidel.
2602
2603         https://bugs.webkit.org/show_bug.cgi?id=24696
2604
2605         Add testing instrumentation for mixed content.
2606
2607         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2608         (-[FrameLoadDelegate webView:]):
2609         (-[FrameLoadDelegate webView:didRunInsecureContent:]):
2610         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2611         (descriptionSuitableForTestResult):
2612         (FrameLoadDelegate::QueryInterface):
2613         (FrameLoadDelegate::didDisplayInsecureContent):
2614         (FrameLoadDelegate::didRunInsecureContent):
2615         * DumpRenderTree/win/FrameLoadDelegate.h:
2616
2617 2009-09-03  Kevin Watters  <kevinwatters@gmail.com>
2618
2619         Reviewed by Kevin Ollivier.
2620
2621         [wx] Frames support
2622         https://bugs.webkit.org/show_bug.cgi?id=19041
2623
2624         * wx/build-wxwebkit:
2625
2626 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2627
2628         <http://webkit.org/b/28880> svn-apply --force doesn't actually work
2629
2630         Reviewed by Eric Seidel.
2631
2632         This fixes "svn-apply --force" and adds unit tests for the
2633         scm.apply_patch() method which uses this script.
2634
2635         * Scripts/svn-apply: Created $globalExitCode variable that
2636         defaults to 0.  Exit with a value of $globalExitCode when the
2637         script is finished.
2638         (applyPatch): Ignore a non-zero $exitCode if $force is true, but
2639         set $globalExitCode to $exitCode so that svn-apply exits with a
2640         non-zero status if any patches did not apply cleanly.  Also
2641         print out the actual patch command if $force was not true.
2642
2643         * Scripts/modules/scm.py:
2644         (scripts_directory): Added.  Extracted from script_path().
2645         (script_path): Extracted scripts_directory().
2646         * Scripts/modules/scm_unittest.py: Import urllib.
2647         (SVNTestRepository.setup): Save the original working directory
2648         in test_object since this represents the WebKit repository from
2649         where the unit tests are run.
2650         (SCMTest): Created new super class to hold utility methods.
2651         (SCMTest._create_patch): Creates a patch file on disk and a
2652         dictionary for use with scm.svn_apply().
2653         (SCMTest._setup_webkittools_scripts_symlink): Sets up a symlink
2654         back to WebKitTools/Scripts in the test repository so that
2655         scm.apply_patch() is able to find the svn-apply script.
2656         (SVNTest): Inherit from SCMTest instead of unittest.TestCase.
2657         (SVNTest.tearDown): Make sure to change directories back to the
2658         original_path before the next test.
2659         (SVNTest.test_apply_svn_patch): New test case for applying an
2660         svn patch with scm.apply_patch().
2661         (SVNTest.test_apply_svn_patch_force): New test case for applying
2662         an svn patch with scm.apply_patch() that conflicts.
2663         (GitTest): Inherit from SCMTest instead of unittest.TestCase.
2664         (GitTest.tearDown): Make sure to change directories back to the
2665         original_path before the next test.
2666         (GitTest.test_apply_git_patch): New test case for applying a git
2667         patch with scm.apply_patch().
2668         (GitTest.test_apply_git_patch_force): New test case for applying
2669         a git patch with scm.apply_patch() that conflicts.
2670
2671 2009-09-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2672
2673         Reviewed by Mark Rowe.
2674
2675         [Qt] Add support for platform-spesific layout-test results
2676
2677         For the Qt port we use the qt-[mac|linux|win] directories and then fall
2678         back to the generic qt directory for both test results and skipped list.
2679
2680         * Scripts/run-webkit-tests:
2681         * Scripts/webkitdirs.pm:
2682
2683 2009-09-02  Laurent Cerveau  <lcerveau@me.com>
2684
2685         Reviewed by David Kilzer.
2686
2687         <http://webkit.org/b/25517> build-webkit script should print build time at end
2688
2689         * Scripts/build-webkit:
2690         Added startTime and endTime variable so that the build time is computed and printed as
2691         part of the build message; display formatting has been separated in a dedicated subroutine.
2692
2693 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2694
2695         <http://webkit.org/b/28881> svn-create-patch should check if the repo path is the same when trying to find the root
2696
2697         Reviewed by Eric Seidel.
2698
2699         * Scripts/VCSUtils.pm:
2700         (determineSvnRoot): Added back check for repository root that
2701         was removed in r46134 when this code lived in svn-create-patch.
2702         It's necessary to check both the repository root and the
2703         repository UUID in case two different working directories are
2704         checked out from the same repository.
2705
2706 2009-09-02  Timothy Hatcher  <timothy@apple.com>
2707
2708         Use new 512x512 icons for nightly builds.
2709
2710         Rubber-stamped by Mark Rowe.
2711
2712         * WebKitLauncher/webkit.icns:
2713
2714 2009-09-02  Kevin Ollivier  <kevino@theolliviers.com>
2715
2716         waf build fix. Remove local variable shadowing global.
2717
2718         * wx/build/settings.py:
2719
2720 2009-09-02  Zan Dobersek  <zandobersek@gmail.com>
2721
2722         Reviewed by David Kilzer.
2723
2724         Calls exitStatus function from the main package where it is also defined.
2725
2726         * Scripts/VCSUtils.pm:
2727
2728 2009-09-02  Kevin Ollivier  <kevino@theolliviers.com>
2729
2730         waf build fixes for Windows/MSVC and Mac/Snow Leopard.
2731
2732         * wx/browser/wscript:
2733         * wx/build/build_utils.py:
2734         * wx/build/settings.py:
2735
2736 2009-08-10  Kevin Ollivier  <kevino@theolliviers.com>
2737
2738         Reviewed by Eric Seidel.
2739
2740         Changes needed for build-webkit to support the waf build system for the wx port.
2741
2742         https://bugs.webkit.org/show_bug.cgi?id=27619
2743
2744         * Scripts/build-webkit:
2745         * Scripts/run-launcher:
2746         * Scripts/webkitdirs.pm:
2747
2748 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2749
2750         <http://webkit.org/b/27168> With Subversion 1.6, update-webkit prompts on conflicts
2751
2752         Reviewed by Eric Seidel.
2753
2754         * Scripts/update-webkit: Added "--accept postpone" to
2755         @svnOptions when running with svn-1.6 or newer.
2756
2757 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2758
2759         Moved svn 1.6 version check into VCSUtils::isSVNVersion16OrNewer()
2760
2761         Reviewed by Eric Seidel.
2762
2763         * Scripts/VCSUtils.pm:
2764         (@EXPORT): Added &isSVNVersion16OrNewer.
2765         (svnVersion): Added.  Internal method that gets the SVN version
2766         and caches it.
2767         (isSVNVersion16OrNewer): Added.  Method that does the SVN 1.6
2768         version check.
2769         * Scripts/prepare-ChangeLog: Switched to use new
2770         isSVNVersion16OrNewer() method.
2771         * Scripts/resolve-ChangeLogs: Ditto.
2772         * Scripts/svn-create-patch: Ditto.
2773
2774 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2775
2776         Clean up VCSUtils.pm
2777
2778         Reviewed by Eric Seidel.
2779
2780         * Scripts/VCSUtils.pm: Added proper package statement.  Fixed
2781         indentation of BEGIN block.  Listed each exported method on a
2782         line by itself.  Added methods to the export list after adding
2783         the package statement.  Sorted module variables.  Moved
2784         definiton of $gitRoot next to other module variables.
2785
2786 2009-09-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2787
2788         Rubber-stamped by Simon Hausmann.
2789
2790         [Qt] Fix layout-test plugins/plugin-javascript-access.html
2791
2792         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2793
2794 2009-09-02  Shinichiro Hamaji  <hamaji@chromium.org>
2795
2796         Reviewed by Eric Seidel.
2797
2798         js tests should move into jstests subdirectory instead of resources/
2799         https://bugs.webkit.org/show_bug.cgi?id=25880
2800
2801         make-script-wrappers supports both resources and script-tests directories.
2802         run-webkit-tests ignores files in script-tests.
2803         Move script tests of animations to check the new script is working.
2804
2805         * Scripts/make-script-test-wrappers:
2806         * Scripts/run-webkit-tests:
2807
2808 2009-09-02  Szabo Carol  <carol.szabo@nokia.com>
2809
2810         Reviewed by David Levin.
2811
2812         check-webkit-style uses python from /usr/bin instead of the PATH
2813         https://bugs.webkit.org/show_bug.cgi?id=28225
2814
2815         * Scripts/bugzilla-tool:
2816         * Scripts/check-webkit-style:
2817         * Scripts/run-webkit-unittests:
2818         * Scripts/update-sources-list.py:
2819           Changed the first line from
2820           #!/usr/bin/python
2821           to
2822           #!/usr/bin/env python
2823           which causes python to be invoked from the path location returned
2824           by "which python" when any of these scripts are launched.
2825           these are currently all the python scripts in WebKitTools/Scripts.
2826
2827 2009-09-01  David Kilzer  <ddkilzer@apple.com>
2828
2829         <http://webkit.org/b/28601> bugzilla-tool post-commits posts commits backwards
2830
2831         Reviewed by Adam Barth.
2832
2833         * Scripts/modules/scm.py:
2834         (Git.commit_ids_from_commitish_arguments): Reverse the list of
2835         commits returned from git-rev-list since we always want to post
2836         the oldest patches first to bugs.webkit.org.
2837         * Scripts/modules/scm_unittest.py:
2838         (run): Added return statement to return the output now that we
2839         want it sometimes.
2840         (SVNTestRepository._setup_test_commits): Added a fourth commit
2841         so the GitTest.test_commitish_order() test has more commits to
2842         work with.
2843         (GitTest.test_commitish_order): Added unit test for change to
2844         Git.commit_ids_from_commitish_arguments() in scm.py.
2845
2846 2009-09-01  David Kilzer  <ddkilzer@apple.com>
2847
2848         <http://webkit.org/b/28877> Implement bugzilla-tool mark-fixed
2849
2850         Reviewed by David Levin.
2851
2852         The mark-fixed subcommand is for those times when you don't use
2853         bugzilla-tool to commit a patch, but you want to use it to close
2854         the bug with a committed-revision message.
2855
2856         * Scripts/bugzilla-tool:
2857         (bug_comment_from_svn_revision): Added.  Extracted from
2858         bug_comment_from_commit_text().
2859         (bug_comment_from_commit_text): Extracted
2860         bug_comment_from_svn_revision() from this method.
2861         (MarkBugFixed.__init__): Added.
2862         (MarkBugFixed._fetch_commit_log): Added.  Retrieves the commit
2863         log from the last commit if no svn revision is specified, else
2864         the commit log for the specified svn revision.
2865         (MarkBugFixed._determine_bug_id_and_svn_revision): Added.
2866         Attempts to determine the bug id and svn revision if one or both
2867         were not defined on the command line.
2868         (MarkBugFixed.execute): Added.  Adds a comment about the
2869         revision that fixed the bug and closes the bug.
2870         (BugzillaTool.__init__): Added mark-fixed subcommand.
2871         * Scripts/modules/bugzilla.py:
2872         (Bugzilla.fetch_title_from_bug): Added.  Returns the title of a
2873         bug given a bug id.
2874         * Scripts/modules/scm.py:
2875         (SCM.strip_r_from_svn_revision): Added.  Utility method to strip
2876         the leading 'r' from an svn revision.
2877         (SCM.svn_commit_log): Added.  Subclasses must override.
2878         (SCM.last_svn_commit_log): Added.  Subclasses must override.
2879         (SVN.svn_commit_log): Added.  Returns svn log for a given
2880         revision.
2881         (SVN.last_svn_commit_log): Added.  Uses svnversion to find the
2882         last commit in an svn working directory and then runs svn log.
2883         (Git.svn_commit_log): Added.  Returns svn log for a given
2884         revision.
2885         (Git.last_svn_commit_log): Added.  Runs git-svn-log with a limit
2886         of one log message.
2887
2888 2009-09-01  David Kilzer  <ddkilzer@apple.com>
2889
2890         <http://webkit.org/b/28880> svn-apply --force doesn't actually work
2891
2892         Reviewed by Brady Eidson.
2893
2894         * Scripts/svn-apply:
2895         (applyPatch): Add "--force" to $options arrayref if $force is
2896         set.
2897
2898 2009-09-01  David Kilzer  <ddkilzer@apple.com>
2899
2900         <http://webkit.org/b/28725> resolve-ChangeLogs: determineVCSRoot() returns incorrect repository root during git filter-branch
2901
2902         Reviewed by Adam Roben.
2903
2904         When git-filter-branch has been invoked to rewrite ChangeLog
2905         files on series of git commits, it changes directories into
2906         .git-rewrite/t before re-running resolve-ChangeLogs.  This
2907         causes determineVCSRoot() in VCSUtils.pm to return
2908         ".git-rewrite/t", which causes that path to be prepended to all
2909         ChangeLog paths, which results in an error like this:
2910
2911             error: pathspec '.git-rewrite/t/ChangeLog' did not match any file(s) known to git.
2912             Died at WebKitTools/Scripts/resolve-ChangeLogs line 376.
2913
2914         The correct way to fix this is not to try to find the repository
2915         root when invoked by git-filter-branch.
2916
2917         * Scripts/resolve-ChangeLogs: If isInGitFilterBranch() is true,
2918         set $relativePath to '.' instead of calling
2919         chdirReturningRelativePath(determineVCSRoot()).
2920         (isInGitFilterBranch): Added.  Checks for the existence of the
2921         MAPPED_PREVIOUS_COMMIT environment variable.
2922
2923 2009-09-01  Xan Lopez  <xlopez@igalia.com>
2924
2925         Reviewed by Gustavo Noronha.
2926
2927         Add support for Fedora distros in the http tests
2928         https://bugs.webkit.org/show_bug.cgi?id=28263
2929
2930         Add detection code for Fedora distribution, and use the proper
2931         httpd conf file when needed.
2932
2933         * Scripts/run-webkit-httpd:
2934         * Scripts/run-webkit-tests:
2935         * Scripts/webkitdirs.pm:
2936
2937 2009-09-01  Jan Michael Alonzo  <jmalonzo@webkit.org>
2938
2939         Reviewed by Eric Seidel.
2940
2941         [Gtk] DRT needs implementation of overridePreference
2942         https://bugs.webkit.org/show_bug.cgi?id=28830
2943
2944         Implement overridePreference.
2945
2946         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2947         (resetDefaultsToConsistentValues):
2948         (setDefaultsToConsistentStateValuesForTesting):
2949         (runTest):
2950         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2951         (toWebSettingKey):
2952         (LayoutTestController::overridePreference):
2953
2954 2009-09-01  Joseph Pecoraro  <joepeck@webkit.org>
2955
2956         <http://webkit.org/b/28623> svn-[un]apply should change directories to the repository root before [un]applying
2957
2958         Reviewed by Eric Seidel.
2959
2960         Jump back and forth between the repository root directory (to apply) and the
2961         directory the script was run from (to find the patch).
2962
2963         * Scripts/svn-apply:
2964         * Scripts/svn-unapply:
2965
2966 2009-08-31  Adam Roben  <aroben@apple.com>
2967
2968         Fall back to a Release version of Safari if a Debug one doesn't exist
2969
2970         <http://webkit.org/b/28849>
2971
2972         Reviewed by Sam Weinig.
2973
2974         * Scripts/webkitdirs.pm:
2975         (safariPath): If the user is working with a Debug build, but there's
2976         no Debug version of Safari present, fall back to using a Release
2977         version of Safari.
2978
2979 2009-08-31  Adam Roben  <aroben@apple.com>
2980
2981         Make safariPath() work for Debug builds of Safari on Windows
2982
2983         <http://webkit.org/b/28849>
2984
2985         Reviewed by Sam Weinig.
2986
2987         * Scripts/webkitdirs.pm:
2988         (safariPath): If the user is working with a Debug build, add the
2989         _debug suffix to Safari.exe.
2990
2991 2009-08-28  Eric Seidel  <eric@webkit.org>
2992
2993         Reviewed by Adam Barth.
2994
2995         commit-queue needs a master process
2996         https://bugs.webkit.org/show_bug.cgi?id=28040
2997
2998         Add a bugzilla-tool commit-queue command
2999         Keeps per-bug logs, but doesn't yet upload them anywhere.
3000
3001         * Scripts/bugzilla-tool: Add LandPatchesFromCommitQueue to handle 'commit-queue'
3002         * Scripts/modules/buildbot.py: remove noisy log message
3003         * Scripts/modules/logging.py: add a 'tee()' call for splitting outputs in python
3004
3005 2009-08-28  Jan Michael Alonzo  <jmalonzo@webkit.org>
3006
3007         Reviewed by Gustavo Noronha.
3008
3009         [GTK] Geolocation needs permission API before being enabled by default
3010
3011         Build the Gtk port with geolocation enabled. This option is only
3012         enabled for the buildbot. The autotools option will be enabled by
3013         default once the permissions API is implemented.
3014
3015         * Scripts/build-webkit:
3016
3017 2009-08-26  Cameron McCormack  <cam@mcc.id.au>
3018
3019         Reviewed by David Kilzer.
3020
3021         Make prepare-ChangeLog notice property changes
3022         https://bugs.webkit.org/show_bug.cgi?id=28675
3023
3024         Make the generated ChangeLog entry include a short description of
3025         property changes if there were such changes.  Also make
3026         prepare-ChangeLog not bail if the only changes are property changes.
3027
3028         * Scripts/prepare-ChangeLog:
3029
3030 2009-08-26  Adam Barth  <abarth@webkit.org>
3031
3032         Reviewed by Oliver Hunt.
3033
3034         Don't let local files access web URLs
3035         https://bugs.webkit.org/show_bug.cgi?id=28480
3036
3037         A bunch of our LayoutTests rely on our old behavior, so we explicitly
3038         grant local files universal access during testing.  Mainly, these tests
3039         involve making XMLHttpRequests for data URLs.
3040
3041         * DumpRenderTree/mac/DumpRenderTree.mm:
3042         (resetDefaultsToConsistentValues):
3043         * DumpRenderTree/qt/DumpRenderTree.cpp:
3044         (WebCore::WebPage::WebPage):
3045         * DumpRenderTree/win/DumpRenderTree.cpp:
3046         (resetDefaultsToConsistentValues):
3047
3048 2009-08-26  John Gregg  <johnnyg@google.com>
3049
3050         Reviewed by David Levin.
3051
3052         Minor style correction and include fix for notifications
3053         https://bugs.webkit.org/show_bug.cgi?id=28745
3054
3055         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3056           change to correct EnumStyle
3057         (DRTDesktopNotificationPresenter::checkNotificationPermission):
3058
3059 2009-08-26  David Levin  <levin@chromium.org>
3060
3061         Reviewed by Alexey Proskuryakov.
3062
3063         XMLHttpRequest.withCredentials=false shouldn't save cookies.
3064         https://bugs.webkit.org/show_bug.cgi?id=28743
3065
3066         Added the support to the layout test controller on OSX and
3067         Windows (for CFNETWORK) to allow for changing the accept cookie
3068         policy.
3069
3070         * DumpRenderTree/LayoutTestController.cpp:
3071         (LayoutTestController::LayoutTestController): Added a bool
3072         to track the state of accepting cookies.
3073         (setAlwaysAcceptCookiesCallback): Standard wrapper method
3074         to go from js to a C++ method.
3075         (LayoutTestController::staticFunctions): Added the
3076         setAlwaysAcceptCookies method to the js layoutTestController.
3077         * DumpRenderTree/LayoutTestController.h:
3078         (LayoutTestController::alwaysAcceptCookies): Returns the value.
3079         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3080         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
3081         * DumpRenderTree/mac/DumpRenderTree.mm:
3082         (resetDefaultsToConsistentValues): Reset the accept cookie to
3083         its default.
3084         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3085         (LayoutTestController::setAlwaysAcceptCookies): Does the work for
3086         OSX to change the cookie accept policy.
3087         * DumpRenderTree/win/DumpRenderTree.cpp:
3088         (setAlwaysAcceptCookies): Method to handle all the calls necessary
3089         to change the accept cookie policy on Windows.
3090         (resetDefaultsToConsistentValues): Reset the accept cookie to
3091         its default.
3092         * DumpRenderTree/win/DumpRenderTreeWin.h:
3093         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3094         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
3095         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3096         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
3097
3098 2009-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
3099
3100         Unreviewed.
3101
3102         Remove accidentally left in clobber option.
3103         https://bugs.webkit.org/show_bug.cgi?id=28400
3104
3105         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed clobber option.
3106
3107 2009-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
3108
3109         Reviewed by Mark Rowe.
3110
3111         Add canary-style Chromium WebKit build slave to the waterfall.
3112         https://bugs.webkit.org/show_bug.cgi?id=28400
3113
3114         * BuildSlaveSupport/build.webkit.org-config/config.json: Added one Chromium/Windows slave
3115         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added support for Chromium slave commands.
3116
3117 2009-08-25  Cameron McCormack  <cam@mcc.id.au>
3118
3119         Reviewed by Darin Adler.
3120
3121         make-script-test-wrappers should be executable
3122         https://bugs.webkit.org/show_bug.cgi?id=28669
3123
3124         Make make-script-test-wrappers and update-sources-list.py both be
3125         executable.
3126
3127         * Scripts/update-sources-list.py:
3128         * Scripts/make-script-test-wrappers:
3129
3130 2009-08-25  Brent Fulgham  <bfulgham@webkit.org>
3131
3132         Build fix
3133
3134         Revise Debug_Cairo targets to point inherit from the
3135         debug_wincairo.vsprops property sheet so that they link
3136         against the proper libraries in Debug build.
3137
3138         * DumpRenderTree/win/DumpRenderTree.vcproj:
3139         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3140         * WinLauncher/WinLauncher.vcproj:
3141
3142 2009-08-25  David Levin  <levin@chromium.org>
3143
3144         Reviewed by Adam Roben.
3145
3146         PLATFORM(CFNETWORK) should be USE(CFNETWORK).
3147         https://bugs.webkit.org/show_bug.cgi?id=28713
3148
3149         * DumpRenderTree/win/DumpRenderTree.cpp:
3150         (main):
3151
3152 2009-08-25  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3153
3154         Reviewed by Ariya Hidayat.
3155
3156         [Qt/Mac] Use CONFIG+=build_all only when building libraries
3157
3158         If no configuration is specified when building WebKit we pass the
3159         debug_and_release option to QMake which results in Makefiles for
3160         both configurations being generated.
3161
3162         Previously we built both of these configurations by default, for
3163         all targets (both the QtWebKit framework/dyldlib and the various
3164         executables such as QtLauncher and tests). This makes sense for
3165         the libraries, which get the _debug suffix and can be loaded on
3166         demand by setting the DYLD_IMAGE_SUFFIX, but for executables we
3167         ended up building the same executable twice.
3168
3169         We now only build one instance of each executable, and since this
3170         is a developer build we build the debug-version. Passing either
3171         --debug or --release to build-webkit will override this, and
3172         even in the default case the release version can still be built
3173         by running 'make release' in the the build directory of each
3174         target.
3175
3176         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3177         * Scripts/webkitdirs.pm:
3178
3179 2009-08-24  Hironori Bono  <hbono@chromium.org>
3180
3181         Reviewed by Adam Barth.
3182
3183         Fix Bug 27827 "[Chromium] Functions Keys don't work in google spreadsheet".
3184         <https://bugs.webkit.org/show_bug.cgi?id=27827>.
3185
3186         Because of the lack of mappings from GDK key-codes to WebKit key-codes,
3187         Chromium cannot send valid key-codes to JavaScript when a user types
3188         function keys. This change just copies the mappings from 'KeyEventGtk.cpp'.
3189
3190         To write layout tests for this issue, added mappings from function-key
3191         names to platform-specific key-codes to EventSendingController objects
3192         so that eventSender.keyDown() can send function-key events without using
3193         platform-specific key codes. (Unfortunately, this eventSender.keyDown() change
3194         is only for Mac. So this change adds this new test to Skipped tests for other
3195         platforms to prevent this change from crashing the build trees.)
3196
3197         * DumpRenderTree/mac/EventSendingController.mm:
3198         (-[EventSendingController keyDown:withModifiers:]):
3199
3200 2009-08-23  Jan Michael Alonzo  <jmalonzo@webkit.org>
3201
3202         Reviewed by Xan Lopez.
3203
3204         [Gtk] API for disabling local file access to web URLs
3205         https://bugs.webkit.org/show_bug.cgi?id=28663
3206
3207         Enable this setting for DRT.
3208
3209         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3210         (resetWebViewToConsistentStateBeforeTesting):
3211
3212 2009-08-22  Adam Barth  <abarth@webkit.org>
3213
3214         Revert 47684.  We're going to do this later once clients have had a
3215         chance to opt into the setting they like.
3216
3217         * DumpRenderTree/mac/DumpRenderTree.mm:
3218         (resetDefaultsToConsistentValues):
3219         * DumpRenderTree/qt/DumpRenderTree.cpp:
3220         (WebCore::WebPage::WebPage):
3221         * DumpRenderTree/win/DumpRenderTree.cpp:
3222         (resetDefaultsToConsistentValues):
3223
3224 2009-08-22  Adam Barth  <abarth@webkit.org>
3225
3226         Reviewed by Eric Seidel.
3227
3228         Don't let local files access web URLs
3229         https://bugs.webkit.org/show_bug.cgi?id=28480
3230
3231         A bunch of our LayoutTests rely on our old behavior, so we explicitly
3232         grant local files universal access during testing.  Mainly, these tests
3233         involve making XMLHttpRequests for data URLs.
3234
3235         * DumpRenderTree/mac/DumpRenderTree.mm:
3236         (resetDefaultsToConsistentValues):
3237         * DumpRenderTree/qt/DumpRenderTree.cpp:
3238         (WebCore::WebPage::WebPage):
3239         * DumpRenderTree/win/DumpRenderTree.cpp:
3240         (resetDefaultsToConsistentValues):
3241
3242 2009-08-22  Mark Rowe  <mrowe@apple.com>
3243
3244         Rubber-stamped by Anders Carlsson.
3245
3246         Bring signed updates to the Mac nightly builds.
3247
3248         * WebKitLauncher/Info.plist:
3249         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
3250         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
3251         (initializeSparkle):
3252         * WebKitLauncher/nightly.webkit.org.public.pem: Added.
3253
3254 2009-08-21  Jan Michael Alonzo  <jmalonzo@webkit.org>
3255
3256         Rubberstamped by Simon Fraser.
3257
3258         Remove GNOME keyring support in build-webkit. This dependency's
3259         already been removed in the Gtk port.
3260
3261         * Scripts/build-webkit:
3262
3263 2009-08-20  Brian Weinstein  <bweinstein@apple.com>
3264
3265         Reviewed by Adam Roben.
3266         Based on original patch by Stephanie Lewis.
3267
3268         Added support of the Windows malloc history format to parse-malloc history, so we can
3269         read and parse it.
3270
3271         * Scripts/parse-malloc-history:
3272
3273 2009-08-20  Chris Fleizach  <cfleizach@apple.com>
3274
3275         Reviewed by Darin Adler.
3276
3277         Enable various "grouping" ARIA roles
3278         https://bugs.webkit.org/show_bug.cgi?id=28486
3279
3280         Expose the ability to retrieve the subrole through accessibility for DRT.
3281
3282         * DumpRenderTree/AccessibilityUIElement.cpp:
3283         * DumpRenderTree/AccessibilityUIElement.h:
3284         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3285         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3286         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3287
3288 2009-08-20  Joseph Pecoraro  <joepeck@webkit.org>
3289
3290         Unreviewed.
3291
3292         Added myself as a committer.
3293
3294         * Scripts/modules/committers.py:
3295
3296 2009-08-20  Xan Lopez  <xlopez@igalia.com>
3297
3298         Reviewed by Gustavo Noronha.
3299
3300         Fix memory leaks.
3301
3302         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3303         (LayoutTestController::whiteListAccessFromOrigin):
3304         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3305         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3306
3307 2009-08-20  Eric Seidel  <eric@webkit.org>
3308
3309         Reviewed by Adam Barth.
3310
3311         bugzilla-tool post-diff can post partial diffs from SVN checkouts.
3312         https://bugs.webkit.org/show_bug.cgi?id=28445
3313
3314         Pass the checkout root as the cwd.  Also wrote a test to ensure this.
3315
3316         * Scripts/modules/scm.py:
3317         * Scripts/modules/scm_unittest.py:
3318
3319 2009-08-20  Mark Rowe  <mrowe@apple.com>
3320
3321         Reviewed by Adele Peterson.
3322
3323         Don't leak the JSStringRef returned by AccessibilityUIElement::attributeValue.
3324
3325         * DumpRenderTree/AccessibilityUIElement.cpp:
3326         (attributeValueCallback):
3327
3328 2009-08-20  Ariya Hidayat  <ariya.hidayat@nokia.com>
3329
3330         Unreviewed, build fix.
3331
3332         [Qt] The template-based qMax() compares two qreals.
3333
3334         * DumpRenderTree/qt/ImageDiff.cpp:
3335         (main):
3336
3337 2009-08-20  David Levin  <levin@chromium.org>
3338
3339         Reviewed by David Kilzer.
3340
3341         bugzilla-tool patch retrieval should handle 302 redirects.
3342         https://bugs.webkit.org/show_bug.cgi?id=28485
3343
3344         * Scripts/modules/scm.py: Pass the --location parameter to curl
3345         so that 302's are followed.
3346
3347 2009-08-20  Aaron Boodman  <aa@chromium.org>
3348
3349         One more speculative build for gtk.
3350
3351         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3352
3353 2009-08-20  Aaron Boodman  <aa@chromium.org>
3354
3355         Speculative build for gtk.
3356
3357         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3358         (LayoutTestController::whiteListAccessFromOrigin):
3359
3360 2009-08-20  Mark Rowe  <mrowe@apple.com>
3361
3362         Ignore some leaks that are known to originate from ImageIO.
3363
3364         * Scripts/run-webkit-tests:
3365
3366 2009-08-20  Aaron Boodman  <aa@chromium.org>
3367
3368         With David Levin.
3369
3370         Speculative build fix for qt.
3371
3372         * DumpRenderTree/qt/jsobjects.cpp:
3373         (LayoutTestController::whiteListAccessFromOrigin):
3374         * DumpRenderTree/qt/jsobjects.h:
3375
3376 2009-08-19  Mark Rowe  <mrowe@apple.com>
3377
3378         Reviewed by Dan Bernstein.
3379
3380         Fix <http://webkit.org/b/28484> Plug-in-related leaks seen on the build bot
3381
3382         Update check-for-global-initializers to accommodate the new uses of RefCountedLeakCounter in WebKit.
3383
3384         * Scripts/check-for-global-initializers:
3385
3386 2009-08-19  Aaron Boodman  <aa@chromium.org>
3387
3388         Reviewed by David Levin.
3389
3390         https://bugs.webkit.org/show_bug.cgi?id=24853: Provide a way for WebKit clients to
3391         specify a more granular policy for cross-origin XHR access.
3392
3393         * DumpRenderTree/LayoutTestController.cpp: Expose whiteListAccessFromOrigin() to layout tests.
3394         (whiteListAccessFromOriginCallback): Ditto.
3395         (LayoutTestController::staticFunctions): Ditto.
3396         * DumpRenderTree/LayoutTestController.h: Ditto.
3397         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Ditto.
3398         (LayoutTestController::whiteListAccessToOrigin): Ditto.
3399         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Ditto.
3400         (LayoutTestController::whiteListAccessFromOrigin): Ditto.
3401         * DumpRenderTree/qt/jsobjects.cpp: Ditto.
3402         (LayoutTestController::whiteListAccessFromOrigin): Ditto.
3403         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Stub out whiteListAccessFromOrigin().
3404         (LayoutTestController::whiteListAccessFromOrigin): Ditto.
3405         * DumpRenderTree/gtk/DumpRenderTree.cpp: Reset origin access lists before each test.
3406         (resetWebViewToConsistentStateBeforeTesting): Ditto.
3407         * DumpRenderTree/mac/DumpRenderTree.mm: Ditto.
3408         (resetWebViewToConsistentStateBeforeTesting): Ditto.
3409         * DumpRenderTree/qt/DumpRenderTree.cpp: Ditto.
3410         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Ditto.
3411
3412 2009-08-19  Mark Rowe  <mrowe@apple.com>
3413
3414         Rubber-stamped by Dan Bernstein.
3415
3416         Ignore some leaks that are known to originate from QTKit.
3417
3418         * Scripts/run-webkit-tests:
3419
3420 2009-08-19  Eric Seidel  <eric@webkit.org>
3421
3422         Reviewed by Adam Barth.
3423
3424         commit-queue/bugzilla-tool can get wedged if git is mid-rebase
3425         https://bugs.webkit.org/show_bug.cgi?id=28436
3426
3427         Make clean_working_directory cancel rebases too (even though that's a bit of a hack).
3428         This code will only ever be run when --force-clean is passed.
3429
3430         I also added a new unit test to make sure this code actually works. :)
3431
3432         * Scripts/modules/scm.py:
3433         * Scripts/modules/scm_unittest.py:
3434
3435 2009-08-19  Eric Seidel  <eric@webkit.org>
3436
3437         Reviewed by David Levin.
3438
3439         WebKit needs a changelogs.py to hold changelog-related code
3440         https://bugs.webkit.org/show_bug.cgi?id=28477
3441
3442         This is moving code and adding tests.  There was only one functional
3443         change (which was removing a trailing newline from the last_entry() result).
3444
3445         * Scripts/bugzilla-tool:
3446         * Scripts/modules/changelogs.py: Added.
3447         * Scripts/modules/changelogs_unittest.py: Added.
3448         * Scripts/run-webkit-unittests:
3449
3450 2009-08-20  Eric Seidel  <eric@webkit.org>
3451
3452         Reviewed by Adam Barth.
3453
3454         bugzilla-tool needs a way to ask build.webkit.org if the bots are passing
3455         https://bugs.webkit.org/show_bug.cgi?id=28222
3456
3457         Basic support for now.  This has been in testing for 24 hours now and worked great!
3458
3459         * Scripts/bugzilla-tool:
3460         * Scripts/modules/buildbot.py: Added.
3461         * Scripts/modules/buildbot_unittest.py: Added.
3462         * Scripts/run-webkit-unittests:
3463
3464 2009-08-19  Jan Michael Alonzo  <jmalonzo@webkit.org>
3465
3466         Reviewed by Gustavo Noronha.
3467
3468         [Gtk] Bump waitToDumpWatchdog interval to 15 seconds to match the
3469         default timeout used by run-webkit-tests. Mac and Win ports were
3470         recently bumped in http://trac.webkit.org/changeset/r47465.
3471
3472         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3473         (LayoutTestController::setWaitToDump):
3474
3475 2009-08-19  David D. Kilzer  <ddkilzer@webkit.org>
3476
3477         DumpRenderTreeSupport.pm: provide pre-generated swig source for Tiger
3478
3479         Reviewed by Mark Rowe.
3480
3481         Provide pre-generated swig source files for Tiger so it may
3482         benefit from the faster run-webkit-tests.
3483
3484         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm:
3485         Generated by swig.
3486         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c: Added.
3487         Generated by swig.
3488         (swig_type_info::SWIG_TypeNameComp):
3489         (swig_type_info::SWIG_TypeEquiv):
3490         (swig_type_info::SWIG_TypeRegisterTL):
3491         (swig_type_info::SWIG_TypeCheck):
3492         (swig_type_info::SWIG_TypeCast):
3493         (swig_type_info::SWIG_TypeDynamicCast):
3494         (swig_type_info::SWIG_TypeName):
3495         (swig_type_info::SWIG_TypePrettyName):
3496         (swig_type_info::SWIG_TypeQueryTL):
3497         (swig_type_info::SWIG_TypeClientDataTL):
3498         (swig_type_info::SWIG_PackData):
3499         (swig_type_info::SWIG_UnpackData):
3500         (swig_type_info::SWIG_PropagateClientDataTL):
3501         (swig_type_info::SWIG_PackVoidPtr):
3502         (swig_type_info::SWIG_UnpackVoidPtr):
3503         (swig_type_info::SWIG_PackDataName):
3504         (swig_type_info::SWIG_UnpackDataName):
3505         * DumpRenderTree/mac/PerlSupport/Makefile: Updated to build on
3506         Tiger using pre-generated files.
3507
3508 2009-08-18  Shinichiro Hamaji  <hamaji@chromium.org>
3509
3510         Reviewed by David Kilzer.
3511
3512         run-webkit-tests hangs when WebCore tries to log too much
3513         https://bugs.webkit.org/show_bug.cgi?id=15743
3514
3515         Read stdout and stderr in parallel.
3516
3517         * Scripts/run-webkit-tests:
3518
3519 2009-08-18  Mark Rowe  <mrowe@apple.com>
3520
3521         Rubber-stamped by Oliver Hunt.
3522
3523         Add a new build configuration that checks for leaks during the layout tests,
3524         and hook a new machine up to it.
3525
3526         * BuildSlaveSupport/build.webkit.org-config/config.json:
3527         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3528
3529 2009-08-18  Aaron Boodman  <aa@chromium.org>
3530
3531         Reviewed by Maciej Stachowiak.
3532
3533         https://bugs.webkit.org/show_bug.cgi?id=28412: Leak of WebCore::XMLHttpRequest object during layout tests.
3534
3535         No new tests: Already covered by existing tests.
3536
3537         * Scripts/check-for-global-initializers: Allow global initialization of WTF::RefCountedLeakCounter for XMLHttpRequest.
3538
3539 2009-08-18  Mark Rowe  <mrowe@apple.com>
3540
3541         Rubber-stamped by Geoff Garen.
3542
3543         Bump waitToDumpWatchdogInterval to 15 seconds to match the time-out used by run-webkit-tests.
3544
3545         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3546         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3547
3548 2009-08-18  Brian Weinstein  <bweinstein@apple.com>
3549
3550         Rubber-stamped by Adam Roben.
3551
3552         Changed use of CComBSTR in exceededDatabaseQuota to BSTRs, and free them,
3553         and removed include to fix building on VC++ Express.
3554
3555         * DumpRenderTree/win/UIDelegate.cpp:
3556         (UIDelegate::exceededDatabaseQuota):
3557
3558 2009-08-18  Brian Weinstein  <bweinstein@apple.com>
3559
3560         Reviewed by Oliver Hunt.
3561
3562         Fix of <https://bugs.webkit.org/show_bug.cgi?id=28326> DRT on Windows doesn't support
3563         LayoutTestController::setQuota or print a callback on UIDelegate::exceededDatabaseQuota.
3564
3565         Implemenent setDatabaseQuota and added a new function to the IWebDatabaseManager interface.
3566         Also added a console output on UIDelegate::exceededDatabaseQuota to match the mac.
3567
3568         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3569         (LayoutTestController::setDatabaseQuota):
3570         * DumpRenderTree/win/UIDelegate.cpp:
3571         (UIDelegate::exceededDatabaseQuota):
3572
3573 2009-08-18  Peter Kasting  <pkasting@google.com>
3574
3575         Reviewed by Eric Seidel.
3576
3577         https://bugs.webkit.org/show_bug.cgi?id=28415
3578         Set svn:eol-style CRLF on all .sln and .vcproj files that don't already
3579         have it.
3580
3581         * record-memory-win/record-memory-win.vcproj:
3582         * WinLauncher/WinLauncher.vcproj:
3583         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3584         * DumpRenderTree/win/ImageDiff.vcproj:
3585         * FindSafari/FindSafari.vcproj:
3586
3587 2009-08-18  Drew Wilson  <atwilson@google.com>
3588
3589         Reviewed by Eric Seidel.
3590
3591         Need to extend DumpRenderTree to expose number of worker threads
3592         https://bugs.webkit.org/show_bug.cgi?id=28292
3593
3594         Added layoutTestController.workerThreadCount, and implementations on various platforms that call into WebKit.
3595
3596         * DumpRenderTree/LayoutTestController.cpp:
3597         (getWorkerThreadCountCallback):
3598         (LayoutTestController::staticValues):
3599         * DumpRenderTree/LayoutTestController.h:
3600         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3601         (LayoutTestController::workerThreadCount):
3602         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3603         (LayoutTestController::workerThreadCount):
3604         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3605         (LayoutTestController::workerThreadCount):
3606         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3607         (LayoutTestController::workerThreadCount):
3608
3609 2009-08-18  Xan Lopez  <xlopez@igalia.com>
3610
3611         Reviewed by Jan Alonzo.
3612
3613         Initialize x and y in the GtkAllocation structure to shut up
3614         valgrind.
3615
3616         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3617         (runTest):
3618
3619 2009-08-17  Shinichiro Hamaji  <hamaji@chromium.org>
3620
3621         Reviewed by Darin Adler.
3622
3623         Some HTMLs are modified by make-script-test-wrappers
3624         https://bugs.webkit.org/show_bug.cgi?id=28213
3625
3626         Add fast/js/const.js and fast/canvas/canvas-2d-imageData-create-nonfinite.js into
3627         the exclude list, modified fast/dom/Geolocation/resources/TEMPLATE.html, and
3628         re-generated wml/* and Geolocation/* .
3629
3630         * Scripts/make-script-test-wrappers:
3631
3632 2009-08-17  Shinichiro Hamaji  <hamaji@chromium.org>
3633
3634         Reviewed by Eric Seidel.
3635
3636         -webkit-box-orient:horizontal doesn't work on <button> tag
3637         https://bugs.webkit.org/show_bug.cgi?id=34445
3638
3639         Make a flexible button's anonymous child flexible and pass the
3640         parent's box-orient to the anonymous child.
3641
3642         Also, added a renderName for anonymous flexible boxes.
3643
3644         * Scripts/make-script-test-wrappers:
3645