27df7d3009bc8f8ed0cb237811877afebacde01f
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-11-27  Adam Barth  <abarth@webkit.org>
2
3         Reviewed by Eric Seidel.
4
5         [bzt] Kill WebKitLandingScripts
6         https://bugs.webkit.org/show_bug.cgi?id=31904
7
8         Step 6: Kill the rest.
9
10         * Scripts/modules/buildsteps.py:
11         * Scripts/modules/commands/download.py:
12         * Scripts/modules/commands/queries.py:
13         * Scripts/modules/commands/upload.py:
14         * Scripts/modules/landingsequence.py:
15         * Scripts/modules/scm.py:
16         * Scripts/modules/webkitlandingscripts.py: Removed.
17
18 2009-11-27  Adam Barth  <abarth@webkit.org>
19
20         Reviewed by Eric Seidel.
21
22         [bzt] Unit test upload commands
23         https://bugs.webkit.org/show_bug.cgi?id=31903
24
25         Adds unit tests for all but two of the upload commands.  The two
26         remaining ones are more difficult.  I'll return to them later.  The
27         goal of these tests is just to run the commands.  We can test more
28         detailed behavior later.
29
30         * Scripts/modules/commands/commandtest.py:
31         * Scripts/modules/commands/upload.py:
32         * Scripts/modules/commands/upload_unittest.py:
33         * Scripts/modules/mock.py: Added.
34         * Scripts/modules/mock_bugzillatool.py:
35
36 2009-11-26  Adam Barth  <abarth@webkit.org>
37
38         Reviewed by Eric Seidel.
39
40         [bzt] Kill WebKitLandingScripts
41         https://bugs.webkit.org/show_bug.cgi?id=31904
42
43         Step 5: Kill run_and_throw_if_fail.
44
45         * Scripts/modules/buildsteps.py:
46         * Scripts/modules/processutils.py: Added.
47         * Scripts/modules/webkitlandingscripts.py:
48
49 2009-11-26  Adam Barth  <abarth@webkit.org>
50
51         Reviewed by Eric Seidel.
52
53         [bzt] Kill WebKitLandingScripts
54         https://bugs.webkit.org/show_bug.cgi?id=31904
55
56         Step 4: Kill run_webkit_script.
57
58         * Scripts/modules/buildsteps.py:
59         * Scripts/modules/commands/download.py:
60         * Scripts/modules/webkitlandingscripts.py:
61
62 2009-11-26  Adam Barth  <abarth@webkit.org>
63
64         Reviewed by Eric Seidel.
65
66         [bzt] Kill WebKitLandingScripts
67         https://bugs.webkit.org/show_bug.cgi?id=31904
68
69         Step 3: Kill build_webkit.
70
71         * Scripts/modules/buildsteps.py:
72         * Scripts/modules/landingsequence.py:
73         * Scripts/modules/webkitlandingscripts.py:
74
75 2009-11-26  Adam Barth  <abarth@webkit.org>
76
77         Reviewed by Eric Seidel.
78
79         [bzt] Kill WebKitLandingScripts
80         https://bugs.webkit.org/show_bug.cgi?id=31904
81
82         Step 2: Kill ensure_builders_are_green.
83
84         * Scripts/modules/buildsteps.py:
85         * Scripts/modules/commands/download.py:
86         * Scripts/modules/landingsequence.py:
87         * Scripts/modules/webkitlandingscripts.py:
88
89 2009-11-26  Adam Barth  <abarth@webkit.org>
90
91         Reviewed by Eric Seidel.
92
93         [bzt] Kill WebKitLandingScripts
94         https://bugs.webkit.org/show_bug.cgi?id=31904
95
96         Step 1: Kill prepare_clean_working_directory and run_webkit_tests.
97
98         * Scripts/bugzilla-tool:
99         * Scripts/modules/buildsteps.py: Added.
100         * Scripts/modules/commands/download.py:
101         * Scripts/modules/landingsequence.py:
102         * Scripts/modules/webkitlandingscripts.py:
103
104 2009-11-26  Zoltan Horvath  <zoltan@webkit.org>
105
106         Reviewed by Adam Barth.
107
108         Remove directory prefixes from linux commands
109
110         SCM unittests can cause errors on some systems if we use absolute reference to
111         the commands, so directory prefixes have been removed.
112
113         * Scripts/modules/scm_unittest.py:
114
115 2009-11-21  Holger Hans Peter Freyther  <zecke@selfish.org>
116
117         Reviewed by Kenneth Rohde Christiansen.
118
119         Link DumpRenderTree to the Qt Ui Tools
120         https://bugs.webkit.org/show_bug.cgi?id=31203
121
122         Implement QWebPage::createPlugin using the Qt Ui Tools
123         to be able to create classes like QProgressBar from within
124         the <object></object> tags This is required for the
125         new automatic test of Qt Plugins.
126
127         * DumpRenderTree/qt/DumpRenderTree.cpp:
128         (WebCore::WebPage::createPlugin):
129         * DumpRenderTree/qt/DumpRenderTree.h:
130         * DumpRenderTree/qt/DumpRenderTree.pro:
131
132 2009-11-25  Yuzo Fujishima  <yuzo@google.com>
133
134         Reviewed by Eric Seidel.
135
136         Update pywebsocket to 0.4.2
137
138         Update pywebsocket to 0.4.2
139         https://bugs.webkit.org/show_bug.cgi?id=31861
140
141         * pywebsocket/example/echo_client.py:
142         * pywebsocket/example/echo_wsh.py:
143         * pywebsocket/mod_pywebsocket/__init__.py:
144         * pywebsocket/mod_pywebsocket/dispatch.py:
145         * pywebsocket/mod_pywebsocket/msgutil.py:
146         * pywebsocket/mod_pywebsocket/standalone.py:
147         * pywebsocket/setup.py:
148         * pywebsocket/test/test_dispatch.py:
149         * pywebsocket/test/test_msgutil.py:
150
151 2009-11-25  Adam Barth  <abarth@webkit.org>
152
153         Reviewed by Eric Seidel.
154
155         Add unit test for mark-fixed
156         https://bugs.webkit.org/show_bug.cgi?id=31896
157
158         * Scripts/modules/commands/commandtest.py: Added.
159         * Scripts/modules/commands/queries_unittest.py:
160         * Scripts/modules/commands/upload_unittest.py: Added.
161         * Scripts/modules/mock_bugzillatool.py:
162         * Scripts/run-webkit-unittests:
163
164 2009-11-25  Adam Barth  <abarth@webkit.org>
165
166         Reviewed by Eric Seidel.
167
168         bugzilla-tool should have a mark-fixed command
169         https://bugs.webkit.org/show_bug.cgi?id=31853
170
171         Pretty simple stuff.
172
173         * Scripts/modules/commands/upload.py:
174
175 2009-11-25  Eric Seidel  <eric@webkit.org>
176
177         Reviewed by Adam Barth.
178
179         'bugzilla-tool help' should only show common commands like how 'git help' does
180         https://bugs.webkit.org/show_bug.cgi?id=31772
181
182         I also took this opportunity to make 'help' a real Command.
183         Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).
184
185         * Scripts/bugzilla-tool:
186          - change should_show_command_help to should_show_in_main_help
187         * Scripts/modules/commands/download.py:
188          - Mark commands as being shown in main help or not.
189          - show_in_main_help = False is not required (default is false),
190            but it seemed to make the commands more self-documenting.
191         * Scripts/modules/commands/queries.py: ditto
192         * Scripts/modules/commands/queues.py: ditto
193         * Scripts/modules/commands/upload.py: ditto
194         * Scripts/modules/multicommandtool.py:
195          - Make Command hold a pointer to tool in self.tool.  Most Command
196            subclasses do not take advantage of this yet, but it was required
197            for HelpCommand to be able to reach the tool from _help_epilog().
198          - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
199          - Move MultiCommandTool._help_epilog to Command._help_epilog
200          - Move "help" logic into HelpCommand.execute()
201          - Change should_show_command_help to should_show_in_main_help and add a default implementation.
202         * Scripts/modules/multicommandtool_unittest.py:
203          - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'
204
205 2009-11-25  Brian Weinstein  <bweinstein@apple.com>
206
207         Reviewed by Dan Bernstein.
208         
209         Patch by Mark Rowe.
210
211         The buildbots are failing on Windows because when they were upgraded
212         to 4.0.4, Apple Application Support was not in their path. Add it to
213         the path to fix the buildots.
214
215         * Scripts/webkitdirs.pm:
216
217 2009-11-25  Csaba Osztrogonác  <ossy@webkit.org>
218
219         Reviewed by David Kilzer.
220
221         run-webkit-tests doesn't accept directories/files with --skipped=only parameter
222         https://bugs.webkit.org/show_bug.cgi?id=31799
223
224         * Scripts/run-webkit-tests: Fixed.
225
226 2009-11-25  Zoltan Horvath  <zoltan@webkit.org>
227
228         Reviewed by Eric Seidel.
229
230         Change run_command to give back stderr by default
231         https://bugs.webkit.org/show_bug.cgi?id=31734
232
233         Change run_command to give back stderr by default.
234         Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
235         Change the related unittest call.
236
237         * Scripts/modules/scm.py:
238         * Scripts/modules/scm_unittest.py:
239
240 2009-11-25  Eric Seidel  <eric@webkit.org>
241
242         Reviewed by Adam Barth.
243
244         Centralize required argument parsing in Command
245         https://bugs.webkit.org/show_bug.cgi?id=31872
246
247         * Scripts/modules/commands/download.py: remove custom required arg message.
248         * Scripts/modules/commands/upload.py: ditto.
249         * Scripts/modules/multicommandtool.py:
250          - Add _parse_required_arguments.
251          - Pass program name off to OptionParser.
252          - Add name() for access to tool name.
253          - Add check_arguments_and_execute and make it return a return code.
254          - Replace a couple uses of + with %.
255         * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
256
257 2009-11-25  Eric Seidel  <eric@webkit.org>
258
259         Reviewed by Adam Barth.
260
261         Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
262         https://bugs.webkit.org/show_bug.cgi?id=31870
263
264         * Scripts/modules/commands/queries_unittest.py: Use the new class.
265         * Scripts/modules/multicommandtool_unittest.py: Ditto.
266         * Scripts/modules/outputcapture.py: Added.
267
268 2009-11-24  Dmitry Titov  <dimich@chromium.org>
269
270         Reviewed by Eric Seidel.
271
272         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
273         https://bugs.webkit.org/show_bug.cgi?id=31444
274
275         * Scripts/build-webkit:
276
277 2009-11-24  Chris Marrin  <cmarrin@apple.com>
278
279         Reviewed by Simon Fraser.
280
281         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
282         https://bugs.webkit.org/show_bug.cgi?id=27314
283         
284         Now the script allows the directories with these tests to be included on all
285         platforms but Mac, where they behave the same as always. For all other platforms
286         the tests need to be excluded using the Skipped files, which is currently done
287         for all platforms (including win since we're not turned on yet)
288
289         * Scripts/webkitdirs.pm:
290
291 2009-11-24  Eric Seidel  <eric@webkit.org>
292
293         Reviewed by Adam Barth.
294
295         queries_unittest.py should test command output
296         https://bugs.webkit.org/show_bug.cgi?id=31845
297
298         * Scripts/modules/commands/queries_unittest.py:
299          - Capture stdout and stderr and compare with expected strings.
300
301 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
302
303         No Review.
304
305         Fix spelling error ("depenedencies").
306
307         * Scripts/build-webkit:
308
309 2009-11-24  Mark Rowe  <mrowe@apple.com>
310
311         Land the configuration that includes the two debug GTK Linux builders.
312
313         * BuildSlaveSupport/build.webkit.org-config/config.json:
314
315 2009-11-24  David Kilzer  <ddkilzer@apple.com>
316
317         <http://webkit.org/b/31840> bisect-builds broke after r50080
318
319         Reviewed by Dan Bernstein.
320
321         * Scripts/bisect-builds:
322         (mountAndRunNightly): Switched back to using backticks to run
323         the hdiutil command since exec() will terminate the existing
324         script, which is not what we want.  Store the output of
325         File::Spec->devnull() in a variable for use in the hdiutil
326         detach commands.
327
328 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
329
330         Reviewed by Kenneth Rohde Christiansen.
331
332         Include "config.h" to meet Coding Style Guidelines
333         https://bugs.webkit.org/show_bug.cgi?id=31792
334
335         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
336         * DumpRenderTree/qt/jsobjects.cpp:
337         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
338
339 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
340
341         Reviewed by Oliver Hunt.
342
343         Implement new required function to pass test we used to pass. This
344         change is required since r51294.
345
346         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
347         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
348
349 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
350
351         Reviewed by Kenneth Rohde Christiansen.
352
353         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
354         https://bugs.webkit.org/show_bug.cgi?id=31775
355
356         LayoutTestController::dumpBackForwardList() should work with local URLs
357         as well as with normal URLs (in http tests for instance).
358         Currently it does not output the latter properly.
359
360         Unskip a bunch of passing http/navigation tests.
361
362         * DumpRenderTree/qt/DumpRenderTree.cpp:
363         (WebCore::dumpHistoryItem):
364
365 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
366
367         Reviewed by Oliver Hunt.
368
369         ARIA: support aria-flowto
370         https://bugs.webkit.org/show_bug.cgi?id=31762
371
372         * DumpRenderTree/AccessibilityUIElement.cpp:
373         (ariaFlowToElementAtIndexCallback):
374         (AccessibilityUIElement::getJSClass):
375         * DumpRenderTree/AccessibilityUIElement.h:
376         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
377         (AccessibilityUIElement::ariaFlowToElementAtIndex):
378         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
379         (AccessibilityUIElement::ariaFlowToElementAtIndex):
380         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
381         (AccessibilityUIElement::ariaFlowToElementAtIndex):
382
383 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
384
385         Reviewed by Kenneth Christiansen.
386
387         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
388         https://bugs.webkit.org/show_bug.cgi?id=31638
389
390         Unfreeze WorkQueue after each test execution.
391
392         * DumpRenderTree/qt/DumpRenderTree.cpp:
393         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
394
395 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
396
397         Reviewed by Adam Barth.
398
399         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
400         for localhost and 127.0.0.1.
401         https://bugs.webkit.org/show_bug.cgi?id=31783
402
403         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
404
405         * DumpRenderTree/qt/DumpRenderTree.cpp:
406         (WebCore::NetworkAccessManager::NetworkAccessManager):
407         (WebCore::NetworkAccessManager::sslErrorsEncountered):
408         (WebCore::WebPage::WebPage):
409         * DumpRenderTree/qt/DumpRenderTree.h:
410
411 2009-11-22  Chris Evans  <cevans@chromium.org>
412
413         Reviewed by Adam Barth.
414
415         Disable access to file:/// directory listings
416         https://bugs.webkit.org/show_bug.cgi?id=31329
417
418         Implemented setAllowUniversalAccessFromFileURLs to support testing of
419         file URL security.
420
421         * DumpRenderTree/LayoutTestController.cpp:
422         (setAllowUniversalAccessFromFileURLsCallback):
423         (LayoutTestController::staticFunctions):
424         * DumpRenderTree/LayoutTestController.h:
425         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
426         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
427         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
428         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
429         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
430         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
431         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
432         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
433
434 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
435
436         Reviewed by Kenneth Rohde Christiansen.
437
438         [Qt] Fix the timeout of fast/frames/frame-navigation.html
439         https://bugs.webkit.org/show_bug.cgi?id=31638
440
441         The test is timeouting, because it uses the WorkQueue to load a document in one
442         of the child frames and once the loading is finished, the DRT does not dump the
443         tree. This is because it waits for the QWebFrame::loadFinished() signal from
444         the main frame, while it should connect to QWebPage::loadFinished().
445
446         * DumpRenderTree/qt/DumpRenderTree.cpp:
447         (WebCore::DumpRenderTree::DumpRenderTree):
448
449 2009-11-21  Eric Seidel  <eric@webkit.org>
450
451         Reviewed by Adam Barth.
452
453         bugzilla-tool --help spews way too much text
454         https://bugs.webkit.org/show_bug.cgi?id=31771
455
456         * Scripts/bugzilla-tool:
457          - Remove self.cached_scm initialization hack.
458         * Scripts/modules/buildbot.py:
459          - Make default_host accessible to callers.
460         * Scripts/modules/commands/download.py:
461          - Phrase help for all commands consistently and remove spurious help text punctuation.
462         * Scripts/modules/commands/queries.py: Ditto.
463         * Scripts/modules/commands/queues.py: Ditto.
464         * Scripts/modules/commands/upload.py: Ditto.
465         * Scripts/modules/multicommandtool.py:
466          - Add HelpPrintingOptionParser.format_epilog to replace
467            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
468            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
469          - Make --help only show a list of commands like "svn help" and "git help" do --
470            previously --help was listing all commands and options.
471          - Sort list of commands alphabetically.
472
473 2009-11-21  Eric Seidel  <eric@webkit.org>
474
475         No review.  Fixing a typo from the previous patch for bug 31767.
476
477         AbstractQueue.run_bugzilla_tool throws an exception
478         https://bugs.webkit.org/show_bug.cgi?id=31769
479
480         * Scripts/modules/commands/queues.py:
481
482 2009-11-21  Eric Seidel  <eric@webkit.org>
483
484         Reviewed by Adam Barth.
485
486         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
487         https://bugs.webkit.org/show_bug.cgi?id=31767
488
489         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
490         Since we don't have a good way to test BugzillaTool pieces, I've
491         left out a test for now.
492
493         * Scripts/bugzilla-tool:
494          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
495         * Scripts/modules/commands/queues.py:
496          - Use tool.path() instead of __file__.
497         * Scripts/modules/multicommandtool.py:
498          - Add a new path() method to MultiComandTool.
499         * Scripts/modules/multicommandtool_unittest.py:
500          - Provide a path() method.  Little point in testing this mock implementation.
501
502 2009-11-21  Adam Barth  <abarth@webkit.org>
503
504         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
505         WebKitTools.
506
507         * Scripts/modules/commands/download.py:
508
509 2009-11-21  Adam Barth  <abarth@webkit.org>
510
511         Reviewed by Eric Seidel.
512
513         Convert check-style to use LandingSequence
514         https://bugs.webkit.org/show_bug.cgi?id=31763
515
516         Instead of manipulating the working copy by hand, we should use the
517         LandingSequence in CheckStyle.  This will make this code eaiser to
518         test.
519
520         * Scripts/modules/commands/download.py:
521
522 2009-11-20  Adam Barth  <abarth@webkit.org>
523
524         Reviewed by Eric Seidel.
525
526         Unit test query commands
527         https://bugs.webkit.org/show_bug.cgi?id=31755
528
529         These tests are pretty rough, but hopefully they'll grow.
530
531         * Scripts/modules/commands/queries_unittest.py: Added.
532         * Scripts/modules/mock_bugzillatool.py: Added.
533         * Scripts/run-webkit-unittests:
534
535 2009-11-20  Eric Seidel  <eric@webkit.org>
536
537         Reviewed by Adam Barth.
538
539         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
540         https://bugs.webkit.org/show_bug.cgi?id=31758
541
542         * Scripts/modules/multicommandtool.py:
543          - Allow passing of explicit commands to MultiCommandTool.__init__
544         * Scripts/modules/multicommandtool_unittest.py:
545          - Use new Command.name naming system.
546          - Test Command auto-discovery.
547         * Scripts/modules/workqueue.py:
548          - bug_id no longer exists, use patch['bug_id'] instead.
549         * Scripts/modules/workqueue_unittest.py:
550          - WorkQueues require names now.
551          - should_proceed_with_work_item must return a patch object.
552
553 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
554
555         Reviewed by Beth Dakin.
556
557         WAI-ARIA: add support for aria-owns
558         https://bugs.webkit.org/show_bug.cgi?id=31702
559
560         * DumpRenderTree/AccessibilityUIElement.cpp:
561         (ariaOwnsElementAtIndexCallback):
562         (AccessibilityUIElement::getJSClass):
563         * DumpRenderTree/AccessibilityUIElement.h:
564         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
565         (AccessibilityUIElement::ariaOwnsElementAtIndex):
566         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
567         (AccessibilityUIElement::ariaOwnsElementAtIndex):
568         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
569         (AccessibilityUIElement::ariaOwnsElementAtIndex):
570
571 2009-11-20  Eric Seidel  <eric@webkit.org>
572
573         Reviewed by Adam Barth.
574
575         Fix exception thrown when running the commit-queue.
576
577         * Scripts/modules/statusbot.py: patch is optional.
578         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
579
580 2009-11-20  Eric Seidel  <eric@webkit.org>
581
582         Reviewed by Adam Barth.
583
584         Teach the StatusBot how to support more than just the commit-queue
585         https://bugs.webkit.org/show_bug.cgi?id=31754
586
587         * Scripts/modules/workqueue.py: Another typo.
588
589 2009-11-20  Eric Seidel  <eric@webkit.org>
590
591         Reviewed by Adam Barth.
592
593         Teach the StatusBot how to support more than just the commit-queue
594         https://bugs.webkit.org/show_bug.cgi?id=31754
595
596         * Scripts/modules/commands/queues.py: Fix silly typo.
597
598 2009-11-20  Eric Seidel  <eric@webkit.org>
599
600         Reviewed by Adam Barth.
601
602         Teach the StatusBot how to support more than just the commit-queue
603         https://bugs.webkit.org/show_bug.cgi?id=31754
604
605         * CommitQueueStatus/index.yaml:
606          - Add indices required for the new queries.
607         * CommitQueueStatus/queue_status.py:
608          - Add a patch-status page and move update_status to update-status.
609          - Only display "commit-queue" status records for the commit-queue.
610          - Add support for a queue_name property on status records.
611          - Fix _int_from_request to actually work.
612         * CommitQueueStatus/update_status.html:
613          - Add support for a queue_name on status records.
614          - Remove unused list of bug ids.
615          * Scripts/modules/commands/queues.py
616           - Make the queues pass the patch instead of the bug_id to StatusBot.
617         * Scripts/modules/statusbot.py:
618          - Support passing the queue_name to the status updates.
619          - Support fetching patch status with patch_status().
620         * Scripts/modules/workqueue.py:
621          - Pass the patch to the StatusBot instead of the bug_id.
622          - Let WorkQueues have a name.
623
624 2009-11-20  Adam Barth  <abarth@webkit.org>
625
626         Reviewed by Eric Seidel.
627
628         Move bugzilla-tool commands into their own file
629         https://bugs.webkit.org/show_bug.cgi?id=31752
630
631         This will let us write unit tests.
632
633         * Scripts/bugzilla-tool:
634         * Scripts/modules/commands/__init__.py: Added.
635         * Scripts/modules/commands/download.py: Added.
636         * Scripts/modules/commands/queries.py: Added.
637         * Scripts/modules/commands/queues.py: Added.
638         * Scripts/modules/commands/upload.py: Added.
639         * Scripts/modules/grammar.py: Added.
640
641 2009-11-20  Adam Barth  <abarth@webkit.org>
642
643         Reviewed by Eric Seidel.
644
645         BuildQueue should check if the tree is currently buildable
646         https://bugs.webkit.org/show_bug.cgi?id=31744
647
648         * Scripts/bugzilla-tool:
649         * Scripts/modules/landingsequence.py:
650         * Scripts/modules/webkitlandingscripts.py:
651
652 2009-11-20  Adam Barth  <abarth@webkit.org>
653
654         Reviewed by Eric Seidel.
655
656         Move prepare_clean_working_directory into the LandingSequence
657         https://bugs.webkit.org/show_bug.cgi?id=31743
658
659         * Scripts/bugzilla-tool:
660         * Scripts/modules/landingsequence.py:
661
662 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
663
664         Reviewed by Kenneth Rohde Christiansen.
665
666         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
667         https://bugs.webkit.org/show_bug.cgi?id=30460
668
669         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
670
671         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
672         (pluginInvoke):
673
674 2009-11-20  Adam Barth  <abarth@webkit.org>
675
676         Reviewed by Eric Seidel.
677
678         Pass the port information to the child process
679         https://bugs.webkit.org/show_bug.cgi?id=31736
680
681         We need to do this so the child process knows what to build!
682
683         * Scripts/bugzilla-tool:
684         * Scripts/modules/landingsequence.py:
685         * Scripts/modules/webkitport.py:
686         * Scripts/modules/webkitport_unittest.py:
687
688 2009-11-20  Adam Barth  <abarth@webkit.org>
689
690         Reviewed by Eric Seidel.
691
692         Support Qt port in build-queue
693         https://bugs.webkit.org/show_bug.cgi?id=31733
694
695         * Scripts/bugzilla-tool:
696
697 2009-11-20  Adam Barth  <abarth@webkit.org>
698
699         Reviewed by Eric Seidel.
700
701         Implement a build-queue
702         https://bugs.webkit.org/show_bug.cgi?id=31725
703
704         Currently this just builds the first 10 patches in the review queue.
705         We'll want to do something smarter soon.
706
707         * Scripts/bugzilla-tool:
708
709 2009-11-20  Adam Barth  <abarth@webkit.org>
710
711         Reviewed by Eric Seidel.
712
713         Make commit-queue and style-queue show up in help
714         https://bugs.webkit.org/show_bug.cgi?id=31724
715
716         We need to store their names on their class to make these commands
717         properly register themselves with MultiCommandTool.
718
719         * Scripts/bugzilla-tool:
720
721 2009-11-20  Adam Barth  <abarth@webkit.org>
722
723         Reviewed by Eric Seidel.
724
725         Implement bugzilla-tool build-attachment
726         https://bugs.webkit.org/show_bug.cgi?id=31722
727
728         This command builds an attachment from bugzilla.  It leaves the built
729         patch in the working copy.
730
731         * Scripts/bugzilla-tool:
732         * Scripts/modules/landingsequence.py:
733         * Scripts/modules/webkitlandingscripts.py:
734
735 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
736
737         Reviewed by Xan Lopez.
738
739         [GTK] DRT release event does not create the state correctly
740         https://bugs.webkit.org/show_bug.cgi?id=31717
741
742         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
743
744 2009-11-20  Eric Seidel  <eric@webkit.org>
745
746         Reviewed by Adam Barth.
747
748         MultiCommandTool should find Command objects automatically instead of with a manual list
749         https://bugs.webkit.org/show_bug.cgi?id=31710
750
751         * Scripts/bugzilla-tool:
752         * Scripts/modules/multicommandtool.py:
753          - Use some wild python-fu to crawl all the known subclasses of Command.
754
755 2009-11-20  Adam Barth  <abarth@webkit.org>
756
757         Unreviewed "build" fix.  Added missing import.
758
759         * Scripts/bugzilla-tool:
760
761 2009-11-20  Adam Barth  <abarth@webkit.org>
762
763         Unreviewed "build" fix.  I failed to update LandingSequence.test
764         properly.
765
766         * Scripts/modules/landingsequence.py:
767
768 2009-11-20  Adam Barth  <abarth@webkit.org>
769
770         Reviewed by Eric Seidel.
771
772         Create LandingSequence as the all-sing, all-dance landing class
773         https://bugs.webkit.org/show_bug.cgi?id=31709
774
775         Client can inherit from this class to carefully control exactly which
776         steps they wish to have happen in the landing sequence.
777
778         * Scripts/bugzilla-tool:
779         * Scripts/modules/landingsequence.py: Added.
780         * Scripts/modules/webkitlandingscripts.py: Added.
781
782 2009-11-19  Adam Barth  <abarth@webkit.org>
783
784         Reviewed by Eric Seidel.
785
786         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
787         https://bugs.webkit.org/show_bug.cgi?id=31707
788
789         This is to help when we implement build-attachment.
790
791         * Scripts/bugzilla-tool:
792
793 2009-11-19  Adam Barth  <abarth@webkit.org>
794
795         Reviewed by Eric Seidel.
796
797         Support Qt port in bugzilla-tool
798         https://bugs.webkit.org/show_bug.cgi?id=31701
799
800         Now we support building with Qt!
801
802         * Scripts/bugzilla-tool:
803         * Scripts/modules/webkitport.py: Added.
804         * Scripts/modules/webkitport_unittest.py: Added.
805         * Scripts/run-webkit-unittests:
806
807 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
808
809         Reviewed by Adam Barth.
810
811         Remove inserting stderr into patch in bugzilla-tool
812         https://bugs.webkit.org/show_bug.cgi?id=29914
813
814         Modify SCM python module's run_command function to avoid return of stderr
815         by default, so stderr won't be inserted into the patches.
816         Modify the related unit test.
817
818         * Scripts/modules/scm.py:
819         * Scripts/modules/scm_unittest.py:
820
821 2009-11-19  Eric Seidel  <eric@webkit.org>
822
823         Reviewed by Adam Barth.
824
825         bugzilla-tool needs per-command help
826         https://bugs.webkit.org/show_bug.cgi?id=31697
827
828         Added support for "bugzilla-tool help command-name"
829         and a unit test to make sure it works.
830
831         * Scripts/modules/multicommandtool.py:
832         * Scripts/modules/multicommandtool_unittest.py:
833
834 2009-11-19  Eric Seidel  <eric@webkit.org>
835
836         Reviewed by Adam Barth.
837
838         Move MultiCommandTool and Command into a separate file and add some basic unit tests
839         https://bugs.webkit.org/show_bug.cgi?id=31695
840
841         * Scripts/bugzilla-tool:
842         * Scripts/modules/multicommandtool.py: Added.
843         * Scripts/modules/multicommandtool_unittest.py: Added.
844         * Scripts/run-webkit-unittests:
845
846 2009-11-19  Eric Seidel  <eric@webkit.org>
847
848         No review, just adding a FIXME.
849
850         Split out command parsing and help printing from BugzillaTool
851         https://bugs.webkit.org/show_bug.cgi?id=31688
852
853         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
854
855 2009-11-19  Eric Seidel  <eric@webkit.org>
856
857         Reviewed by Adam Barth.
858
859         Split out command parsing and help printing from BugzillaTool
860         https://bugs.webkit.org/show_bug.cgi?id=31688
861
862         * Scripts/bugzilla-tool:
863          - Add new MultiCommandTool class to contain option parsing and help printing logic.
864          - Rename private methods to use _ pattern.
865          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
866          - 
867
868 2009-11-19  Eric Seidel  <eric@webkit.org>
869
870         Reviewed by Adam Barth.
871
872         Re-factor help printing to use modern python idioms
873         https://bugs.webkit.org/show_bug.cgi?id=31685
874
875         * Scripts/bugzilla-tool:
876
877 2009-11-19  Eric Seidel  <eric@webkit.org>
878
879         Reviewed by Darin Adler.
880
881         commit-queue empty queue logs twice
882         https://bugs.webkit.org/show_bug.cgi?id=31679
883
884         * Scripts/bugzilla-tool:
885
886 2009-11-19  Eric Seidel  <eric@webkit.org>
887
888         Reviewed by Darin Adler.
889
890         bugzilla-tool's reviewer/committer rejection message should be clearer
891         https://bugs.webkit.org/show_bug.cgi?id=31126
892
893         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
894
895         * Scripts/modules/bugzilla.py:
896
897 2009-11-19  Eric Z. Ayers  <zundel@google.com>
898
899         Reviewed by Pavel Feldman.
900
901         Forces a WM_PAINT event on calling layoutTestController.display()
902         in order to enable the timeline-paint.html test on Windows.
903         ::UpdateWindow() does not force an event becaue the window is 
904         not visible.
905
906         https://bugs.webkit.org/show_bug.cgi?id=31402
907
908         * DumpRenderTree/win/DumpRenderTree.cpp:
909         (displayWebView):
910
911 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
912
913         No review needed.
914
915         Added myself to committers list.
916
917         * Scripts/modules/committers.py:
918
919 2009-11-19  Adam Barth  <abarth@webkit.org>
920
921         Reviewed by Eric Seidel.
922
923         Bugzilla-tool command classes should match command names
924         https://bugs.webkit.org/show_bug.cgi?id=31666
925
926         I renamed all the commands except CommitMessageForCurrentDiff because
927         the new name would conflict with an existing class.
928
929         * Scripts/bugzilla-tool:
930
931 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
932
933         Reviewed by Gustavo Noronha Silva.
934
935         Web Inspector: Implement "show inspector" in WebKit GTK
936         API and enable console tests.
937
938         https://bugs.webkit.org/show_bug.cgi?id=31669
939
940         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
941         (LayoutTestController::showWebInspector):
942
943 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
944
945         Reviewed by Simon Hausmann.
946
947         Minor refactoring + more documentation.
948
949         * DumpRenderTree/qt/DumpRenderTree.cpp:
950         (WebCore::clearHistory):
951         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
952
953 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
954
955         Reviewed by Eric Seidel.
956
957         Ignore websocket tests when --no-http is specified.
958         https://bugs.webkit.org/show_bug.cgi?id=31662
959
960         * Scripts/run-webkit-tests:
961
962 2009-11-18  Adam Barth  <abarth@webkit.org>
963
964         Reviewed by Eric Seidel.
965
966         Normalize ' and " in bugzilla-tool
967         https://bugs.webkit.org/show_bug.cgi?id=31655
968
969         We decided " is better than ' and we should be consistent.
970
971         * Scripts/bugzilla-tool:
972
973 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
974
975         Reviewed by Kenneth Rohde Christiansen.
976
977         [Qt] Remove support for Qt v4.3 or older versions
978         https://bugs.webkit.org/show_bug.cgi?id=29469
979
980         * DumpRenderTree/qt/DumpRenderTree.pro:
981         * DumpRenderTree/qt/ImageDiff.pro:
982
983 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
984
985         Reviewed by Eric Seidel.
986
987         GitTest.test_create_binary_patch fails if /tmp is symlink
988         https://bugs.webkit.org/show_bug.cgi?id=31536
989
990         * Scripts/modules/scm_unittest.py:
991
992 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
993
994         Reviewed by Darin Adler.
995
996         Configuration for Chromium Build Slaves.
997
998         https://bugs.webkit.org/show_bug.cgi?id=31442
999
1000         * BuildSlaveSupport/build.webkit.org-config/config.json:
1001         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1002
1003 2009-11-18  Eric Seidel  <eric@webkit.org>
1004
1005         Reviewed by Darin Adler.
1006
1007         workqueue.py results in totally broken commit-queue UI
1008         https://bugs.webkit.org/show_bug.cgi?id=31645
1009
1010         * Scripts/bugzilla-tool:
1011          - Remove unneeded use of PatchCollection.
1012          - Grab a new copy of the cq'd patches every run of the queue.
1013
1014 2009-11-18  Sam Weinig  <sam@webkit.org>
1015
1016         Reviewed by Anders Carlsson.
1017
1018         Make the Mac Geolocation API async.
1019
1020         Update DRT to use the new async Mac Geolocation API.
1021
1022         * DumpRenderTree/mac/UIDelegate.mm:
1023         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
1024
1025 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1026
1027         Reviewed by Kenneth Rohde Christiansen.
1028
1029         Add and option to toggle HTML5 datalist support to build-webkit
1030         https://bugs.webkit.org/show_bug.cgi?id=31599
1031
1032         * Scripts/build-webkit:
1033
1034 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
1035
1036         Reviewed by Kevin Ollivier.
1037
1038         Enable wx plugin support using the Windows implementation as a base.
1039         
1040         https://bugs.webkit.org/show_bug.cgi?id=31636
1041
1042         * wx/build/settings.py:
1043
1044 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1045
1046         Reviewed by Simon Hausmann.
1047
1048         Change the initialization order so that the controllers
1049         will be created before exporting them to the JS DOM window.
1050
1051         * DumpRenderTree/qt/DumpRenderTree.cpp:
1052         (WebCore::DumpRenderTree::DumpRenderTree):
1053
1054 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1055
1056         Reviewed by Simon Hausmann.
1057
1058         Fix a code copy and paste error. m_page should be page.
1059
1060         * DumpRenderTree/qt/DumpRenderTree.cpp:
1061         (WebCore::DumpRenderTree::createWindow):
1062
1063 2009-11-17  Mark Rowe  <mrowe@apple.com>
1064
1065         Reviewed by Alexey Proskuryakov.
1066
1067         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
1068
1069         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
1070         This prevents symlinks from confusing the descendant check.
1071
1072 2009-11-17  Mark Rowe  <mrowe@apple.com>
1073
1074         Reviewed by Alexey Proskuryakov.
1075
1076         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
1077
1078         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
1079         server to be up rather than having run-webkit-tests abort immediately.
1080
1081         * Scripts/run-webkit-tests:
1082
1083 2009-11-17  Eric Seidel  <eric@webkit.org>
1084
1085         Reviewed by Darin Adler.
1086
1087         commit-queue is failing to set reviewer in ChangeLogs
1088         https://bugs.webkit.org/show_bug.cgi?id=31592
1089
1090         * Scripts/bugzilla-tool: Clarify the "applying" log message.
1091         * Scripts/modules/bugzilla.py:
1092          - Add a new _validate_committer_and_reviewer function as a
1093            temporary solution until we can make a real Attachment object
1094            which knows how to fill in its committer/reviewer fields automatically.
1095
1096 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1097
1098         Unreviewed buildbot fix.
1099
1100         Revert part of earlier patch and add comment, as it
1101         was causing timeouts on the buildbot.
1102
1103         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1104         (LayoutTestController::notifyDone):
1105
1106 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1107
1108         Reviewed by Oliver Hunt.
1109
1110         Make the timeout 15 sec as for the other DRT's and make
1111         it print out the same output when a test timeout.
1112
1113         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1114         (LayoutTestController::waitUntilDone):
1115         (LayoutTestController::notifyDone):
1116         (LayoutTestController::timerEvent):
1117
1118 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
1119
1120         Reviewed by Timothy Hatcher.
1121
1122         Fixed typos in comments.
1123
1124         * Scripts/modules/committers.py:
1125
1126 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
1127
1128         Reviewed by Timothy Hatcher.
1129
1130         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
1131         - Updated DRT to show/close inspector for all tests under /inspector
1132         - Introduced LayoutTestController::setTimelineProfilingEnabled and
1133           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
1134         - Removed reload on each inspector test
1135         - Renamed fast/inspector to fast/inspector-support in order not to trigger
1136         inspector for those.
1137         - Reimplemented timeline tests in order to get rid of reload there.
1138         - Moved tests that don't require harness into the fast group.
1139
1140         https://bugs.webkit.org/show_bug.cgi?id=31472
1141
1142         * DumpRenderTree/LayoutTestController.cpp:
1143         (setTimelineProfilingEnabledCallback):
1144         (closeWebInspectorCallback):
1145         (LayoutTestController::staticFunctions):
1146         * DumpRenderTree/LayoutTestController.h:
1147         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1148         (shouldOpenWebInspector):
1149         (runTest):
1150         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1151         (LayoutTestController::setTimelineProfilingEnabled):
1152         * DumpRenderTree/mac/DumpRenderTree.mm:
1153         (shouldOpenWebInspector):
1154         (runTest):
1155         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1156         (LayoutTestController::setTimelineProfilingEnabled):
1157         * DumpRenderTree/win/DumpRenderTree.cpp:
1158         (shouldOpenWebInspector):
1159         (runTest):
1160         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1161         (LayoutTestController::setTimelineProfilingEnabled):
1162
1163 2009-11-17  Oliver Hunt  <oliver@apple.com>
1164
1165         Reviewed by Maciej Stachowiak.
1166
1167         Incorrect use of JavaScriptCore API in DumpRenderTree
1168         https://bugs.webkit.org/show_bug.cgi?id=31577
1169
1170         Return undefined rather than a literal null.
1171
1172         * DumpRenderTree/AccessibilityUIElement.cpp:
1173         (setSelectedTextRangeCallback):
1174         (incrementCallback):
1175         (decrementCallback):
1176         (showMenuCallback):
1177
1178 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
1179
1180         Reviewed by Beth Dakin.
1181
1182         AX: aria-labelledby duplicates some of its WAI-ARIA label
1183         https://bugs.webkit.org/show_bug.cgi?id=31565
1184
1185         * DumpRenderTree/AccessibilityUIElement.cpp:
1186         (titleUIElementCallback):
1187         (getIsValidCallback):
1188         (AccessibilityUIElement::getJSClass):
1189
1190 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1191
1192         Reviewed by Simon Hausmann.
1193
1194         r50942 broke output from created windows. Make the
1195         m_enableTextOutput a member of the DRT and not the
1196         WebPage.
1197
1198         * DumpRenderTree/qt/DumpRenderTree.cpp:
1199         (WebCore::WebPage::WebPage):
1200         (WebCore::WebPage::javaScriptAlert):
1201         (WebCore::WebPage::javaScriptConsoleMessage):
1202         (WebCore::WebPage::javaScriptConfirm):
1203         (WebCore::WebPage::javaScriptPrompt):
1204         (WebCore::WebPage::acceptNavigationRequest):
1205         (WebCore::DumpRenderTree::DumpRenderTree):
1206         (WebCore::DumpRenderTree::open):
1207         (WebCore::DumpRenderTree::createWindow):
1208         * DumpRenderTree/qt/DumpRenderTree.h:
1209         (WebCore::DumpRenderTree::setTextOutputEnabled):
1210         (WebCore::DumpRenderTree::isTextOutputEnabled):
1211         (WebCore::WebPage::shouldInterruptJavaScript):
1212         (WebCore::WebPage::isTextOutputEnabled):
1213         (WebCore::WebPage::setViewGeometry):
1214
1215 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1216
1217         Reviewed by Gustavo Noronha Silva.
1218
1219         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
1220         as the implementation is being used by at least Qt and Gtk+.
1221
1222         Update buildsystems as well.
1223
1224         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1225         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
1226         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
1227         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
1228         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1229         * GNUmakefile.am:
1230
1231 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
1232
1233         Reviewed by Alexey Proskuryakov.
1234
1235         Disable wss until all platforms support pyOpenSSL
1236
1237         https://bugs.webkit.org/show_bug.cgi?id=31479
1238
1239         * Scripts/run-webkit-tests:
1240
1241 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
1242
1243         Reviewed by Kenneth Christiansen.
1244
1245         [Qt] Implement load error pages support for Qt's DRT.
1246         https://bugs.webkit.org/show_bug.cgi?id=31509
1247
1248         For now, it will not be a default feature, and layout tests
1249         that want to make use of this have to explicitily call
1250         'handleErrorPages();' for the test source.
1251
1252         Any of the other DumpRenderTree's (mac, win and gtk)
1253         support handling error pages. Qt's will be the first.
1254
1255         * DumpRenderTree/qt/DumpRenderTree.cpp:
1256         (WebCore::WebPage::supportsExtension):
1257         (WebCore::WebPage::extension):
1258         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1259         (LayoutTestController::reset):
1260         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1261         (LayoutTestController::shouldHandleErrorPages):
1262         (LayoutTestController::handleErrorPages):
1263
1264 2009-11-16  Eric Seidel  <eric@webkit.org>
1265
1266         Reviewed by Adam Barth.
1267
1268         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
1269         https://bugs.webkit.org/show_bug.cgi?id=31549
1270
1271         Renamed --commit-queue to --non-interactive in most places
1272         and remove the code in land-patches which is no longer needed.
1273
1274         * Scripts/bugzilla-tool:
1275
1276 2009-11-16  Eric Seidel  <eric@webkit.org>
1277
1278         Reviewed by Adam Barth.
1279
1280         The commit-queue should use land-attachment
1281         https://bugs.webkit.org/show_bug.cgi?id=31548
1282
1283         * Scripts/bugzilla-tool:
1284
1285 2009-11-16  Adam Barth  <abarth@webkit.org>
1286
1287         Reviewed by Eric Seidel.
1288
1289         Convert CommitQueue over to PatchCollection
1290         https://bugs.webkit.org/show_bug.cgi?id=31547
1291
1292         Also fixes a bug in workqueue and adds a test!
1293
1294         * Scripts/bugzilla-tool:
1295         * Scripts/modules/workqueue.py:
1296         * Scripts/modules/workqueue_unittest.py:
1297
1298 2009-11-16  Adam Barth  <abarth@webkit.org>
1299
1300         Reviewed by Eric Seidel.
1301
1302         Move StyleQueue over to using PatchCollection
1303         https://bugs.webkit.org/show_bug.cgi?id=31544
1304
1305         That's what the class it's for.
1306
1307         * Scripts/bugzilla-tool:
1308         * Scripts/modules/patchcollection.py:
1309         * Scripts/modules/patchcollection_unittest.py:
1310
1311 2009-11-16  Eric Seidel  <eric@webkit.org>
1312
1313         Reviewed by Adam Barth.
1314
1315         bugzilla-tool needs a land-attachment command
1316         https://bugs.webkit.org/show_bug.cgi?id=31546
1317
1318         * Scripts/bugzilla-tool:
1319          - Move all the logic into AbstractLandingCommand and
1320            add a new LandAttachment command subclass.
1321          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
1322
1323 2009-11-16  Eric Seidel  <eric@webkit.org>
1324
1325         Reviewed by Adam Barth.
1326
1327         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
1328         https://bugs.webkit.org/show_bug.cgi?id=31543
1329
1330         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
1331
1332         * Scripts/bugzilla-tool:
1333
1334 2009-11-16  Eric Seidel  <eric@webkit.org>
1335
1336         Reviewed by Adam Barth.
1337
1338         Disable the style queue from posting to the commit queue status page.
1339
1340         * Scripts/bugzilla-tool:
1341
1342 2009-11-16  Adam Barth  <abarth@webkit.org>
1343
1344         Reviewed by Eric Seidel.
1345
1346         Implement PatchCollection
1347         https://bugs.webkit.org/show_bug.cgi?id=31541
1348
1349         This class holds a set of patches and lets clients iterate through
1350         them.  Optionally, clients can install a filter.
1351
1352         * Scripts/modules/patchcollection.py: Added.
1353         * Scripts/modules/patchcollection_unittest.py: Added.
1354         * Scripts/run-webkit-unittests:
1355
1356 2009-11-16  Eric Seidel  <eric@webkit.org>
1357
1358         Reviewed by Adam Barth.
1359
1360         bugzilla-tool land-patches will close bugs with patches r=?
1361         https://bugs.webkit.org/show_bug.cgi?id=28230
1362
1363         The commit-queue shouldn't close patches with outstanding reviews on them,
1364         even if many reviewers seem to be against multi-patch bugs.
1365
1366         * Scripts/bugzilla-tool:
1367
1368 2009-11-16  Eric Seidel  <eric@webkit.org>
1369
1370         Reviewed by Adam Barth.
1371
1372         bugzilla-tool check-style should work with attachment ids instead of bug ids
1373         https://bugs.webkit.org/show_bug.cgi?id=31540
1374
1375         * Scripts/bugzilla-tool:
1376
1377 2009-11-16  Eric Seidel  <eric@webkit.org>
1378
1379         Reviewed by Adam Barth.
1380
1381         WorkQueue is the only place that should know about special exit codes
1382         https://bugs.webkit.org/show_bug.cgi?id=31534
1383
1384         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
1385         and add tests for handling exit codes.
1386         I also cleaned up workqueue_unittest.py more.
1387
1388         * Scripts/bugzilla-tool:
1389         * Scripts/modules/workqueue.py:
1390         * Scripts/modules/workqueue_unittest.py:
1391
1392 2009-11-16  Eric Seidel  <eric@webkit.org>
1393
1394         Reviewed by Adam Barth.
1395
1396         Re-factor workqueue_unittest to allow for more than one test.
1397         https://bugs.webkit.org/show_bug.cgi?id=31535
1398
1399         * Scripts/modules/workqueue_unittest.py:
1400
1401 2009-11-16  Eric Seidel  <eric@webkit.org>
1402
1403         Reviewed by Adam Barth.
1404
1405         land-patches needs to be re-factored into smaller chunks
1406         https://bugs.webkit.org/show_bug.cgi?id=31532
1407
1408         * Scripts/bugzilla-tool: fix a couple obvious typos.
1409
1410 2009-11-16  Eric Seidel  <eric@webkit.org>
1411
1412         Reviewed by Adam Barth.
1413
1414         land-patches needs to be re-factored into smaller chunks
1415         https://bugs.webkit.org/show_bug.cgi?id=31532
1416
1417         The next patch will move these methods into WebKitLandingScripts.
1418
1419         * Scripts/bugzilla-tool:
1420          - Split out _land_patch and _close_bug_if_no_active_patches.
1421
1422 2009-11-16  Adam Barth  <abarth@webkit.org>
1423
1424         Reviewed by Eric Seidel.
1425
1426         Fix silly copy-and-paste code.  I am a terrible coder.
1427
1428         * Scripts/modules/bugzilla.py:
1429
1430 2009-11-16  Adam Barth  <abarth@webkit.org>
1431
1432         Reviewed by Eric Seidel.
1433
1434         Implement a StyleQueue
1435         https://bugs.webkit.org/show_bug.cgi?id=31537
1436
1437         The first iteration of the style queue only produces output locally.
1438         There is also a limit of 10 patches because it's not that useful to
1439         iterate through the entire review queue at this point.  We can remove
1440         the limit later.
1441
1442         * Scripts/bugzilla-tool:
1443         * Scripts/modules/bugzilla.py:
1444
1445 2009-11-16  Adam Barth  <abarth@webkit.org>
1446
1447         Reviewed by Eric Seidel.
1448
1449         Unit test WorkQueue
1450         https://bugs.webkit.org/show_bug.cgi?id=31531
1451
1452         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
1453
1454         * Scripts/bugzilla-tool:
1455         * Scripts/modules/statusbot.py:
1456         * Scripts/modules/workqueue.py:
1457         * Scripts/modules/workqueue_unittest.py: Added.
1458         * Scripts/run-webkit-unittests:
1459
1460 2009-11-16  Eric Seidel  <eric@webkit.org>
1461
1462         Reviewed by Adam Barth.
1463
1464         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
1465         https://bugs.webkit.org/show_bug.cgi?id=31530
1466
1467         * Scripts/bugzilla-tool:
1468
1469 2009-11-16  Eric Seidel  <eric@webkit.org>
1470
1471         Reviewed by Adam Barth.
1472
1473         bugzilla-tool needs apply-attachment
1474         https://bugs.webkit.org/show_bug.cgi?id=31528
1475
1476         * Scripts/bugzilla-tool:
1477          - Add ApplyAttachment command.
1478          - Abstract applying code into WebKitApplyingScripts.
1479          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
1480         * Scripts/modules/bugzilla.py:
1481          - Add fetch_attachment and bug_id_for_attachment_id.
1482         * Scripts/modules/bugzilla_unittest.py:
1483          - Add test for new parsing.
1484          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
1485
1486 2009-11-16  Eric Seidel  <eric@webkit.org>
1487
1488         Reviewed by Adam Barth.
1489
1490         Document check-style's use of force_clean.
1491
1492         * Scripts/bugzilla-tool:
1493         * Scripts/modules/scm.py:
1494
1495 2009-11-16  Adam Barth  <abarth@webkit.org>
1496
1497         Reviewed by Eric Seidel.
1498
1499         Move WorkQueue to its own file
1500         https://bugs.webkit.org/show_bug.cgi?id=31529
1501
1502         WorkQueue and WorkQueueDelegate are separate concerns from
1503         bugzilla-tool.  Also added a missing include to logging.py.
1504
1505         * Scripts/bugzilla-tool:
1506         * Scripts/modules/logging.py:
1507         * Scripts/modules/workqueue.py:
1508
1509 2009-11-16  Adam Barth  <abarth@webkit.org>
1510
1511         Reviewed by Eric Seidel.
1512
1513         Move OutputTee to logging.py.
1514
1515         * Scripts/bugzilla-tool:
1516         * Scripts/modules/logging.py:
1517
1518 2009-11-15  Adam Barth  <abarth@webkit.org>
1519
1520         Reviewed by Eric Seidel.
1521
1522         Refactor bugzilla-tool to allow for multiple queues
1523         https://bugs.webkit.org/show_bug.cgi?id=31513
1524
1525         Divide the commit queue class into three class to make creating
1526         additional queues easier.
1527
1528         * Scripts/bugzilla-tool:
1529
1530 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1531
1532         Reviewed by Eric Seidel.
1533
1534         svn-apply may not handle git patches created by bugzilla-tool
1535         https://bugs.webkit.org/show_bug.cgi?id=31457
1536
1537         * Scripts/modules/scm.py:
1538         * Scripts/modules/scm_unittest.py:
1539
1540 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1541
1542         Reviewed by Eric Seidel.
1543
1544         bugzilla-tool should post git binary diff
1545         https://bugs.webkit.org/show_bug.cgi?id=31458
1546
1547         Add --binary option to Git.create_patch.
1548
1549         * Scripts/modules/scm.py:
1550         * Scripts/modules/scm_unittest.py:
1551
1552 2009-11-15  Adam Barth  <abarth@webkit.org>
1553
1554         Reviewed by Darin Adler.
1555
1556         Add bugzilla-tool check-style
1557         https://bugs.webkit.org/show_bug.cgi?id=31515
1558
1559         * Scripts/bugzilla-tool:
1560         * Scripts/modules/bugzilla.py:
1561
1562 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1563
1564         Reviewed by Simon Hausmann.
1565
1566         Make the Qt Linux only --valgrind feature, suppress errors
1567         defined in the SuppressedValgrindErrors file.
1568
1569         * Scripts/run-webkit-tests:
1570
1571 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1572
1573         Reviewed by Simon Hausmann.
1574
1575         Set the locale to C and not to the current one in use on the system.
1576
1577         * DumpRenderTree/qt/DumpRenderTree.cpp:
1578         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1579
1580 2009-11-13  Adam Roben  <aroben@apple.com>
1581
1582         Add support for
1583         http/tests/security/isolatedWorld/didClearWindowObject.html
1584
1585         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
1586         window objects in isolated worlds are cleared
1587
1588         Reviewed by Dave Hyatt.
1589
1590         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
1591
1592         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1593         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1594         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
1595         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
1596         Added. Sets a __worldID property on the global object whose value is
1597         the ID of this world.
1598         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
1599         Respond to this new delegate callback by calling through to one of the
1600         above new methods.
1601         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1602         (worldMap): Added. Returns a HashMap containing all the worlds we've
1603         created.
1604         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
1605         haven't kept track of this world.
1606         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1607         instead of declaring our own.
1608
1609         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
1610
1611         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1612         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
1613         didClearWindowObjectForFrameInStandardWorld.
1614         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
1615         Respond to this new delegate callback by calling through to one of the
1616         below new methods.
1617         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
1618         Added. Sets a __worldID property on the gobal object whose value is
1619         the ID of this world.
1620         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1621         Added. Moved code here from didClearWindowObject.
1622
1623         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
1624         didClearWindowObjectForFrame* functions.
1625
1626         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1627         (worldMap): Added. Returns a HashMap containing all the worlds we've
1628         created.
1629         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
1630         haven't kept track of this world.
1631         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1632         instead of declaring our own.
1633
1634 2009-11-13  Adam Roben  <aroben@apple.com>
1635
1636         Finish replacing worldIDs with world objects
1637
1638         The only remaining use of worldIDs was in a method only used by DRT
1639         for the isolated worlds tests.
1640
1641         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
1642
1643         Reviewed by Mark Rowe.
1644
1645         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1646         (LayoutTestController::evaluateScriptInIsolatedWorld):
1647         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1648         (LayoutTestController::evaluateScriptInIsolatedWorld):
1649         Updated for changes to WebFrame. Now holds the map of worldID -> world
1650         at this level instead of making WebKit do it.
1651
1652 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1653
1654         Reviewed by Simon Hausmann.
1655
1656         [Qt] Ensure the DRT does not output anything until first test is run
1657
1658         * DumpRenderTree/qt/DumpRenderTree.cpp:
1659         * DumpRenderTree/qt/DumpRenderTree.h:
1660
1661 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1662
1663         Reviewed by Tor Arne Vestbø.
1664
1665         Clear the undo stack in before each new test run.
1666
1667         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
1668
1669         * DumpRenderTree/qt/DumpRenderTree.cpp:
1670         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1671
1672 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1673
1674         Reviewed by Kenneth Rohde Christiansen.
1675
1676         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
1677
1678         * DumpRenderTree/qt/DumpRenderTree.cpp:
1679         (WebCore::WebPage::resetSettings):
1680         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1681         (LayoutTestController::overridePreference):
1682
1683 2009-11-13  Eric Seidel  <eric@webkit.org>
1684
1685         Reviewed by Adam Barth.
1686
1687         Update committers.py based on svn records
1688         https://bugs.webkit.org/show_bug.cgi?id=31366
1689
1690         This list was generated using validate-committer-lists from
1691         https://bugs.webkit.org/show_bug.cgi?id=30970
1692         and makes committers.py current for committers who have
1693         committed in the last 3 years.
1694
1695         * Scripts/modules/committers.py:
1696
1697 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
1698
1699         Reviewed by Adam Barth.
1700
1701         The document-open.html test was flaky at times. The test invokes the layout test plugin
1702         which in its destroy stream handler opens a new document. This basically tears down the
1703         stream and the associated plugin instance. The pluginLog function in the layout test
1704         plugin attempts to retrieve the window script object on a torn down plugin instance
1705         which crashed consistently on windows in the debugger. The functions which issue
1706         these logs already have a valid window script object. We now have variants of the pluginLog
1707         function which take in a window script object with and without variable arguments. 
1708
1709         https://bugs.webkit.org/show_bug.cgi?id=31067
1710
1711         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1712         (pluginLogWithWindowObject):
1713         (pluginLogWithWindowObjectVariableArgs):
1714         (pluginLog):
1715         (notifyTestCompletion):
1716         (testDocumentOpen):
1717         (testWindowOpen):
1718
1719 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1720
1721         Reviewed by Gustavo Noronha Silva.
1722
1723         https://bugs.webkit.org/show_bug.cgi?id=30997
1724         [Gtk] Implemment AtkDocument
1725
1726         Added testing support.
1727
1728         * DumpRenderTree/AccessibilityUIElement.cpp:
1729         * DumpRenderTree/AccessibilityUIElement.h:
1730         (getDocumentEncodingCallback):
1731         (getDocumentURICallback):
1732         (AccessibilityUIElement::getJSClass):
1733         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1734         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1735         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1736         (AccessibilityUIElement::documentEncoding):
1737         (AccessibilityUIElement::documentURI):
1738
1739 2009-11-12  Adam Roben  <aroben@apple.com>
1740
1741         Replace worldIDs with world objects
1742
1743         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
1744         user scripts/stylesheets and isolated worlds
1745
1746         Reviewed by Sam Weinig.
1747
1748         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1749         (LayoutTestController::addUserScript):
1750         (LayoutTestController::addUserStyleSheet):
1751         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1752         (LayoutTestController::addUserScript):
1753         (LayoutTestController::addUserStyleSheet):
1754         Changed these functions to create a new WebJSWorld each time they're
1755         called and to pass that world to WebKit.
1756
1757 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
1758
1759         Reviewed by Oliver Hunt.
1760
1761         need to implement aria tree roles
1762         https://bugs.webkit.org/show_bug.cgi?id=31284
1763
1764         * DumpRenderTree/AccessibilityUIElement.cpp:
1765         (disclosedRowAtIndexCallback):
1766         (selectedRowAtIndexCallback):
1767         (isEqualCallback):
1768         (isAttributeSettableCallback):
1769         (isActionSupportedCallback):
1770         (disclosedByRowCallback):
1771         (hierarchicalLevelCallback):
1772         (AccessibilityUIElement::getJSClass):
1773         * DumpRenderTree/AccessibilityUIElement.h:
1774         (AccessibilityUIElement::isEqual):
1775         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1776         (AccessibilityUIElement::hierarchicalLevel):
1777         (AccessibilityUIElement::disclosedRowAtIndex):
1778         (AccessibilityUIElement::selectedRowAtIndex):
1779         (AccessibilityUIElement::disclosedByRow):
1780         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1781         (AccessibilityUIElement::getChildAtIndex):
1782         (AccessibilityUIElement::disclosedRowAtIndex):
1783         (AccessibilityUIElement::selectedRowAtIndex):
1784         (AccessibilityUIElement::titleUIElement):
1785         (AccessibilityUIElement::parentElement):
1786         (AccessibilityUIElement::disclosedByRow):
1787         (AccessibilityUIElement::hierarchicalLevel):
1788         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1789         (AccessibilityUIElement::hierarchicalLevel):
1790         (AccessibilityUIElement::disclosedRowAtIndex):
1791         (AccessibilityUIElement::selectedRowAtIndex):
1792         (AccessibilityUIElement::disclosedByRow):
1793
1794 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
1795
1796         Reviewed by Darin Adler.
1797
1798         svn-apply can not handle git binary diffs
1799         https://bugs.webkit.org/show_bug.cgi?id=26830
1800
1801         Support "literal" type git binary diffs.
1802
1803         * Scripts/VCSUtils.pm:
1804         * Scripts/modules/scm_unittest.py:
1805         * Scripts/svn-apply:
1806
1807 2009-11-11  Dmitry Titov  <dimich@chromium.org>
1808
1809         Not reviewed, removing duplicate entry for myself in committers.py.
1810
1811         * Scripts/modules/committers.py:
1812
1813 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
1814
1815         Reviewed by Darin Adler and Mark Rowe.
1816
1817         https://bugs.webkit.org/show_bug.cgi?id=31200
1818         Tests in http/tests/security/mixedContent start to fail when new tests are added
1819
1820         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
1821
1822 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1823
1824         Reviewed by Jan Alonzo.
1825
1826         Create, and display a window for the inspector, for inspector
1827         tests.
1828
1829         Need to also show/hide the inspector window to avoid having
1830         problems with code assuming it is realized
1831         https://bugs.webkit.org/show_bug.cgi?id=31347
1832
1833         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1834         (webInspectorShowWindow):
1835         (webInspectorCloseWindow):
1836         (webInspectorInspectWebView):
1837         (createWebView):
1838
1839 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1840
1841         Unreviewed Qt buildbot fix.
1842
1843         My previous fix was wrong, so revert that change and fix it by
1844         returning when the document of the frame has no document element.
1845         Idea is borrowed from mac and win DRT.
1846
1847         * DumpRenderTree/qt/DumpRenderTree.cpp:
1848         (WebCore::DumpRenderTree::dumpFramesAsText):
1849
1850 2009-11-11  Eric Seidel  <eric@webkit.org>
1851
1852         Reviewed byg Kenneth Rohde Christiansen.
1853
1854         Update Kenneth's committer record to include the email he
1855         uses on lists.webkit.org.
1856
1857         * Scripts/modules/committers.py:
1858
1859 2009-11-11  Eric Seidel  <eric@webkit.org>
1860
1861         Reviewed by Gustavo Noronha Silva.
1862
1863         Several committers use separate email addresses for bugzilla and svn.webkit.org
1864         https://bugs.webkit.org/show_bug.cgi?id=31364
1865
1866         Update records for existing committers to include email addresses
1867         used in svn.webkit.org and lists.webkit.org.
1868         Most committers use the same email address in all 3 places, but some use
1869         separate addresses.  committers.py needs record of each of these addresses.
1870
1871         * Scripts/modules/committers.py:
1872
1873 2009-11-11  Eric Seidel  <eric@webkit.org>
1874
1875         No review, adding second email address for an existing committer.
1876
1877         Add Yong Li's second bugzilla account to his committer record.
1878         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
1879
1880         * Scripts/modules/committers.py:
1881
1882 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1883
1884         Reviewed by Simon Hausmann.
1885
1886         If the frame has no innerText don't append it, and
1887         do not add a newline which breaks some cross platform
1888         results.
1889
1890         * DumpRenderTree/qt/DumpRenderTree.cpp:
1891         (WebCore::DumpRenderTree::dumpFramesAsText):
1892
1893 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1894
1895         Reviewed by Simon Hausmann.
1896
1897         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
1898
1899         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1900         (webkit_test_plugin_new_instance):
1901         (webkit_test_plugin_destroy_instance):
1902         (webkit_test_plugin_destroy_stream):
1903
1904 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1905
1906         Reviewed by Mark Rowe.
1907
1908         Implement the functionality needed by plugins/window-open.html
1909
1910         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1911         (webkit_test_plugin_new_instance):
1912         (webkit_test_plugin_set_window):
1913
1914 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1915
1916         Reviewed by Simon Hausmann.
1917
1918         [Qt] Force -graphicssystem raster and -style windows when running DRT
1919
1920         * DumpRenderTree/qt/main.cpp:
1921         * Scripts/run-webkit-tests:
1922
1923 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1924
1925         Reviewed by Simon Hausmann.
1926
1927         Compute correct library paths for Qt
1928
1929         * Scripts/webkitdirs.pm:
1930
1931 2009-11-10  Mark Rowe  <mrowe@apple.com>
1932
1933         Reviewed by Sam Weinig.
1934
1935         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
1936
1937         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
1938         about the validity of the self-signed certificates used in the regression tests.  We would then add the
1939         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
1940         that had enabled frame load delegate logging this would result in extra log messages being generated,
1941         causing the test to fail.
1942
1943         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
1944         tests.
1945
1946         * DumpRenderTree/mac/DumpRenderTree.mm:
1947         (dumpRenderTree):
1948         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1949         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1950
1951 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1952
1953         Reviewed by Kenneth Rohde Christiansen.
1954
1955         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
1956
1957         * DumpRenderTree/qt/DumpRenderTree.cpp:
1958         (WebCore::DumpRenderTree::DumpRenderTree):
1959
1960 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1961
1962         Reviewed by Jan Alonzo.
1963
1964         [GTK] Remove WebSocket configuration from WebKitWebSettings
1965         https://bugs.webkit.org/show_bug.cgi?id=31244
1966
1967         Follow-up of r50724. Don't set the enable-web-socket property
1968         anymore.
1969
1970         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1971         (resetDefaultsToConsistentValues):
1972
1973 2009-11-10  Oliver Hunt  <oliver@apple.com>
1974
1975         Reviewed by Maciej Stachowiak.
1976
1977         Rename 3D Canvas related classes to use WebGL prefix
1978         https://bugs.webkit.org/show_bug.cgi?id=29095
1979
1980         Checkin new version of do-webcore-rename used to do the WebGL type rename,
1981         and upate webkitdirs script to new method of testing for WebGL.
1982
1983         * Scripts/do-webcore-rename:
1984         * Scripts/webkitdirs.pm:
1985
1986 2009-11-09  Oliver Hunt  <oliver@apple.com>
1987
1988         Reviewed by Geoff Garen.
1989
1990         Make do-webcore-rename work with git.
1991
1992         * Scripts/do-webcore-rename:
1993
1994 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
1995
1996         Adding Kenneth to the reviewers list.
1997
1998         * Scripts/modules/committers.py:
1999
2000 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2001
2002         Reviewed by Jan Alonzo.
2003
2004         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
2005         https://bugs.webkit.org/show_bug.cgi?id=30482
2006
2007         LayoutTestControllerGtk now uses the exposed
2008         Page::tabKeyCyclesThroughElements API
2009
2010         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2011         (LayoutTestController::setTabKeyCyclesThroughElements):
2012
2013 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
2014
2015         Reviewed by Holger Freyther.
2016
2017         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
2018         This helps to pass the test case below. Also replaced hardcoded
2019         code numbers with defined constants.
2020         https://bugs.webkit.org/show_bug.cgi?id=31185
2021         
2022         Test: editing/undo/undo-deleteWord.html
2023
2024         * DumpRenderTree/qt/EventSenderQt.cpp:
2025         (EventSender::keyDown):
2026
2027 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
2028
2029         Reviewed by Holger Freyther.
2030
2031         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
2032         https://bugs.webkit.org/show_bug.cgi?id=31164
2033
2034         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
2035
2036         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2037         (LayoutTestController::processWork):
2038
2039 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
2040
2041         Reviewed by Holger Freyther.
2042
2043         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
2044         https://bugs.webkit.org/show_bug.cgi?id=31158
2045
2046         By invoking a script queue'd by queueScript(), 'true' was beeing returned
2047         always, which from WorkQueue prospective means that a load has been started
2048         and the queue processing should stop and wait for the load to finish.
2049         Spinning it off into a loading and a non-loading variants was the solution
2050         adopted by Mac's DRT to work around this problem. The former keeps returning
2051         'true' while the later executes the script synchronously and returns 'false'
2052         making it possible to the WorkQueue to proceed right away.
2053
2054         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2055         (LayoutTestController::processWork):
2056         (LayoutTestController::queueLoadingScript):
2057         (LayoutTestController::queueNonLoadingScript):
2058         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2059         * DumpRenderTree/qt/WorkQueueItem.h:
2060         (LoadingScriptItem::LoadingScriptItem):
2061         (LoadingScriptItem::invoke):
2062         (NonLoadingScriptItem::NonLoadingScriptItem):
2063         (NonLoadingScriptItem::invoke):
2064
2065 2009-11-07  Mark Rowe  <mrowe@apple.com>
2066
2067         Rubber-stamped by Cameron Zwarich.
2068
2069         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
2070
2071         * Scripts/commit-log-editor:
2072
2073 2009-11-07  Mark Rowe  <mrowe@apple.com>
2074
2075         Reviewed by Darin Adler.
2076
2077         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
2078         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
2079
2080         Move logic for determining the name and email address to use in a ChangeLog entry from
2081         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
2082         whether the author of the patch matches committer, and therefore needs access to the
2083         email address that would be used in a ChangeLog entry.
2084
2085         Based on a patch by Pierre d'Herbemont.
2086
2087         * Scripts/VCSUtils.pm:
2088         * Scripts/commit-log-editor:
2089         * Scripts/prepare-ChangeLog:
2090         * Scripts/webkitdirs.pm:
2091
2092 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
2093
2094         Reviewed by Adam Barth.
2095
2096         Added functionality to the layout test plugin to invoke document.open and
2097         window.open with default arguments. The associated webkit bug is
2098         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
2099         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
2100         work in Chromium (V8) if there is no calling javascript context. To achieve this
2101         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
2102         for the window.open test case and in NPP_DestroyStream for the document.open test case.
2103
2104         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2105         (testDocumentOpen):
2106         (testWindowOpen):
2107         (pluginAllocate):
2108         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2109         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2110         (NPP_New):
2111         (NPP_SetWindow):
2112         (NPP_DestroyStream):
2113         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
2114         (NPP_New):
2115         (NPP_SetWindow):
2116         (NPP_NewStream):
2117         (NPP_DestroyStream):
2118
2119 2009-11-06  Eric Seidel  <eric@webkit.org>
2120
2121         Reviewed by Adam Barth.
2122
2123         bugzilla-tool crashed with exception
2124         https://bugs.webkit.org/show_bug.cgi?id=31092
2125
2126         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
2127
2128 2009-11-04  Eric Seidel  <eric@webkit.org>
2129
2130         No review, just add a line which got left out of the patch uploaded for commit.
2131
2132         commit-queue is crashing when trying to reject patches after unknown failures
2133         https://bugs.webkit.org/show_bug.cgi?id=31091
2134
2135         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
2136
2137 2009-11-04  Adam Roben  <aroben@apple.com>
2138
2139         Remove bogus else clause in bugzilla-tool
2140
2141         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
2142         create-bug raises exception after entering bug description
2143
2144         Reviewed by David Kilzer.
2145
2146         * Scripts/bugzilla-tool:
2147         (CreateBug): else clauses are only hit if no exception is raised, so
2148         it makes no sense to try to re-raise the exception in an else clause.
2149         The exception will automatically be re-raised if it doesn't match any
2150         of the except clauses, so we don't have to do anything special here at
2151         all to get the desired behavior.
2152
2153 2009-11-04  Eric Seidel  <eric@webkit.org>
2154
2155         Reviewed by David Kilzer.
2156
2157         svn-apply's fixChangeLogPatch function seems broken
2158         https://bugs.webkit.org/show_bug.cgi?id=30683
2159
2160         Update fixChangeLogPatch to be able to handle patches which
2161         don't start at line 1.
2162         Add unit tests for svn-apply to scm_unittest.py.
2163
2164         * Scripts/VCSUtils.pm:
2165         * Scripts/modules/scm_unittest.py:
2166
2167 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
2168
2169         Reviewed by Beth Dakin.
2170
2171         Need to implement ARIA role="combobox"
2172         https://bugs.webkit.org/show_bug.cgi?id=31096
2173
2174         * DumpRenderTree/AccessibilityUIElement.cpp:
2175         (showMenuCallback):
2176         (getIsExpandedCallback):
2177         (AccessibilityUIElement::getJSClass):
2178         * DumpRenderTree/AccessibilityUIElement.h:
2179         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2180         (AccessibilityUIElement::isExpanded):
2181         (AccessibilityUIElement::showMenu):
2182         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2183         (AccessibilityUIElement::isExpanded):
2184         (AccessibilityUIElement::showMenu):
2185         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2186         (AccessibilityUIElement::isSelected):
2187         (AccessibilityUIElement::isExpanded):
2188         (AccessibilityUIElement::showMenu):
2189
2190 2009-11-04  Eric Seidel  <eric@webkit.org>
2191
2192         Reviewed by Adam Barth.
2193
2194         commit-queue is crashing when trying to reject patches after unknown failures
2195         https://bugs.webkit.org/show_bug.cgi?id=31091
2196
2197         * Scripts/bugzilla-tool:
2198          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
2199            so we have to find out what the current patch is by asking bugzilla again.
2200          - Discovered that this code was also leaking file descriptors, so fixed that.
2201
2202 2009-11-04  Adam Roben  <aroben@apple.com>
2203
2204         Make run-webkit-tests work for the Debug_Internal Windows
2205         configuration
2206
2207         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
2208         suffix.
2209
2210         Fixes <http://webkit.org/b/31123>.
2211
2212         Reviewed by Sam Weinig.
2213
2214         * Scripts/run-webkit-tests: Don't add the _debug suffix in
2215         Debug_Internal, either.
2216
2217 2009-11-04  Eric Seidel  <eric@webkit.org>
2218
2219         Reviewed by Adam Barth.
2220
2221         committers.py needs a way to store non-bugzilla email addresses
2222         https://bugs.webkit.org/show_bug.cgi?id=31037
2223
2224         Make Committer and Reviewer constructors take a single email or a list of emails.
2225         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
2226         Expose reviewers(), used by validate-committer-lists on bug 30970.
2227
2228         * Scripts/modules/committers.py:
2229         * Scripts/modules/committers_unittest.py: Added tests for the new code.
2230
2231 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
2232
2233         Reviewed by David Levin.
2234
2235         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
2236         https://bugs.webkit.org/show_bug.cgi?id=27491
2237
2238         The test path determination logic is changed to handle websocket and websocket/ssl cases.
2239         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
2240
2241         Functions to start or stop Web Socket servers are added.
2242
2243         * Scripts/run-webkit-tests:
2244
2245 2009-11-03  Eric Seidel  <eric@webkit.org>
2246
2247         No review, just changing wording of log message.
2248
2249         Change log string to say "failed" instead of "rejected"
2250         when a commit fails due to an out of date checkout.
2251         This makes grepping the commit-queue log for rejected patches easier.
2252
2253         * Scripts/bugzilla-tool:
2254
2255 2009-11-03  Eric Seidel  <eric@webkit.org>
2256
2257         No review, adding commonly known committers missing from the file.
2258
2259         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
2260
2261 2009-11-03  Eric Seidel  <eric@webkit.org>
2262
2263         No review, just sort-order cleanup.
2264
2265         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
2266
2267 2009-11-03  Stephen White  <senorblanco@chromium.org>
2268
2269         (Unreviewed).
2270
2271         Add myself to committers.py.
2272
2273         * Scripts/modules/committers.py:
2274
2275 2009-11-03  Robin Dunn  <robin@alldunn.com>
2276
2277         Reviewed by Kevin Ollviier.
2278
2279         Add packaging scripts for Debian-based Linux distros.
2280         
2281         https://bugs.webkit.org/show_bug.cgi?id=31075
2282
2283         * wx/packaging/build-debian-installer.py: Added.
2284         * wx/packaging/debian: Added.
2285
2286 2009-11-03  Dan Bernstein  <mitz@apple.com>
2287
2288         Reviewed by Anders Carlsson and Beth Dakin.
2289
2290         https://bugs.webkit.org/show_bug.cgi?id=31070
2291
2292         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
2293         destroyed, it executes the value of the 'ondestroy' parameter as a
2294         script.
2295
2296         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2297         (pluginAllocate): Initialize onDestroy.
2298         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
2299         onDestroy.
2300         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2301         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
2302         specified.
2303         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
2304
2305 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2306
2307         Reviewed by Xan Lopez.
2308
2309         https://bugs.webkit.org/show_bug.cgi?id=31035
2310         [GTK] some accessibility tests hitting assertion in debug builds
2311
2312         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
2313
2314         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2315         (AccessibilityController::rootElement):
2316
2317 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
2318
2319         Reviewed by Beth Dakin.
2320
2321         Support ARIA "tab" roles
2322         https://bugs.webkit.org/show_bug.cgi?id=30842
2323
2324         * DumpRenderTree/AccessibilityUIElement.cpp:
2325         * DumpRenderTree/AccessibilityUIElement.h:
2326         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2327         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2328         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2329
2330 2009-11-01  Eric Seidel  <eric@webkit.org>
2331
2332         Reviewed by David Levin.
2333
2334         buildbots should use --exit-after-N-failures
2335         https://bugs.webkit.org/show_bug.cgi?id=30809
2336
2337         Make the bots exit after 20 failures to prevent never-ending
2338         test runs where every test spends a minute crashing.
2339
2340         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2341
2342 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2343
2344         Reviewed by Eric Seidel.
2345
2346         Turn on warnings for QtWebKit for gcc
2347         https://bugs.webkit.org/show_bug.cgi?id=30958
2348
2349         * DumpRenderTree/qt/main.cpp: 
2350         (crashHandler): Mark function NO_RETURN
2351
2352 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
2353
2354         Adding myself to the committers list.
2355
2356         * Scripts/modules/committers.py:
2357
2358 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
2359
2360         Fix an issue that Adam noticed in DRT.
2361
2362         Reviewed by Darin Adler.
2363
2364         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2365         (AccessibilityUIElement::role):
2366         Get the length of the role text, and create a buffer dynamically.
2367
2368 2009-10-30  Eric Seidel  <eric@webkit.org>
2369
2370         No review, rolling out r50105.
2371         http://trac.webkit.org/changeset/50105
2372
2373         This commit was causing:
2374         https://bugs.webkit.org/show_bug.cgi?id=30869
2375         We'll re-implement the feature a different way.
2376
2377         * Scripts/bugzilla-tool:
2378
2379 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2380
2381         Test for MSAA: Accessibility of headings is not correct
2382
2383         https://bugs.webkit.org/show_bug.cgi?id=30937
2384
2385         Reviewed by Adam Roben.
2386
2387         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2388         (AccessibilityUIElement::role):
2389         Allow the role returned to be a BSTR.
2390         (AccessibilityUIElement::description):
2391         Fix a copy/paste error.
2392
2393 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2394
2395         Test for MSAA: Accessibility of links is wrong
2396
2397         https://bugs.webkit.org/show_bug.cgi?id=30928
2398
2399         Reviewed by Darin Adler.
2400
2401         * DumpRenderTree/AccessibilityUIElement.cpp:
2402         (getAccessibilityValueCallback):
2403         Return the accessibility value.
2404         (AccessibilityUIElement::getJSClass):
2405         Added "accessibilityValue" value.
2406
2407         * DumpRenderTree/AccessibilityUIElement.h:
2408
2409         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2410         (AccessibilityUIElement::accessibilityValue):
2411         Stubbed.
2412
2413         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2414         (AccessibilityUIElement::accessibilityValue):
2415         Stubbed.
2416
2417         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2418         (AccessibilityUIElement::accessibilityValue):
2419         Get the object's value, and return it as a JS string.
2420
2421 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
2422
2423         Fix typo in command name used by wx build system.
2424
2425         * wx/build/build_utils.py:
2426
2427 2009-10-30  Adam Barth  <abarth@webkit.org>
2428
2429         Reviewed by Darin Adler.
2430
2431         Patch v1 is a dumb default name for patches
2432         https://bugs.webkit.org/show_bug.cgi?id=30952
2433
2434         Let's use "Patch" instead.
2435
2436         * Scripts/bugzilla-tool:
2437
2438 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2439
2440         Unreviewed trivial buildfix.
2441
2442         [Qt] Buildfix for r50333.
2443
2444         * DumpRenderTree/qt/DumpRenderTree.pro:
2445
2446 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
2447
2448         Reviewed by Holger Freyther.
2449
2450         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
2451         https://bugs.webkit.org/show_bug.cgi?id=30953
2452
2453         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
2454         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
2455         makes qt DRT to share this implementation (as gtk and mac ports do).
2456
2457         * DumpRenderTree/qt/DumpRenderTree.pro:
2458         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
2459         * DumpRenderTree/qt/WorkQueue.h: Removed.
2460
2461 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2462
2463         Unreviewed potential buildbot fix.
2464
2465         Second try: Reset page history before running each test.
2466
2467         Apparently the QWebHistory::clear() keeps the current page
2468         in history which is not what we want, so we not additionally
2469         sets the history capacity to 0 (forces removing everything)
2470         and then sets it back to its original value.
2471
2472         * DumpRenderTree/qt/DumpRenderTree.cpp:
2473         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2474
2475 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2476
2477         Unreviewed potential buildbot fix.
2478
2479         Reset page history before running each test.
2480
2481         * DumpRenderTree/qt/DumpRenderTree.cpp:
2482         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2483
2484 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
2485
2486         Reviewed by Eric Seidel.
2487
2488         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
2489
2490         Bug 28420 -  Implement HTML5 <ruby> rendering
2491         (https://bugs.webkit.org/show_bug.cgi?id=28420)
2492
2493         No new tests (no functional change).
2494
2495         * Scripts/build-webkit:
2496
2497 2009-10-29  Dan Bernstein  <mitz@apple.com>
2498
2499         Reviewed by Mark Rowe.
2500
2501         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
2502         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
2503         define it.
2504
2505         * Scripts/VCSUtils.pm:
2506         * Scripts/svn-apply:
2507         * Scripts/svn-unapply:
2508
2509 2009-10-29  Xan Lopez  <xlopez@igalia.com>
2510
2511         Reviewed by Gustavo Noronha.
2512
2513         Use the GTK+ main loop instead of rolling our own mini-version of
2514         it.
2515
2516         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2517         (dump):
2518         (runTest):
2519         (webViewLoadFinished):
2520
2521 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2522
2523         Reviewed by Oliver Hunt.
2524
2525         Implement the Qt version of DRT dumpBackForwardList().
2526
2527         * DumpRenderTree/qt/DumpRenderTree.cpp:
2528         (WebCore::dumpHistoryItem):
2529         (WebCore::DumpRenderTree::dumpBackForwardList):
2530
2531 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2532
2533         Reviewed by Adam Roben.
2534
2535         Implement DRT functionality for Qt introduced in
2536         r28690 and r28705.
2537
2538         - Implemented pathToLocalResource which exposes the functionality of
2539         converting a given unix path to the correct location on Windows.
2540         - Implemented a way to remove machine-dependent information from paths
2541         in layout test results.
2542
2543         * DumpRenderTree/qt/DumpRenderTree.cpp:
2544         (WebCore::urlSuitableForTestResult):
2545         (WebCore::WebPage::javaScriptConsoleMessage):
2546         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2547         (LayoutTestController::pathToLocalResource):
2548         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2549
2550 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
2551
2552         Adding myself to the committers list.
2553
2554         * Scripts/modules/committers.py:
2555
2556 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
2557
2558         Adding myself to the committers list.
2559
2560         * Scripts/modules/committers.py:
2561
2562 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2563
2564         Reviewed by Jan Alonzo.
2565
2566         [GTK] API to start inspector for a WebView
2567         https://bugs.webkit.org/show_bug.cgi?id=22551
2568
2569         Use the new inspector API to implement the LayoutTestController
2570         interfaces used to test the inspector.
2571
2572         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2573         (webInspectorInspectWebView):
2574         (createWebView):
2575         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2576         (LayoutTestController::showWebInspector):
2577         (LayoutTestController::closeWebInspector):
2578         (LayoutTestController::evaluateInWebInspector):
2579
2580 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
2581
2582         Reviewed by Eric Seidel.
2583
2584         [Qt] WebFrame::counterValueForElementById must not be exposed
2585         https://bugs.webkit.org/show_bug.cgi?id=30882
2586
2587         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2588         (LayoutTestController::counterValueForElementById):
2589
2590 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2591
2592         Rubberstamped by Oliver Hunt.
2593
2594         Fix the warning:
2595
2596         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
2597         declared with attribute warn_unused_result".
2598
2599         by actually checking the result. In the case it is null, an
2600         error has occoured, so treat it as the other fatal errors.
2601
2602         * DumpRenderTree/qt/DumpRenderTree.cpp:
2603         (WebCore::DumpRenderTree::initializeFonts):
2604
2605 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
2606
2607         Reviewed by Darin Adler.
2608
2609         Provide a way to get counter values with layoutTestContoller
2610         https://bugs.webkit.org/show_bug.cgi?id=30555
2611
2612         Define layoutTestContoller.counterValueForElementById.
2613
2614         * DumpRenderTree/LayoutTestController.cpp:
2615         (counterValueForElementByIdCallback):
2616         (LayoutTestController::staticFunctions):
2617         * DumpRenderTree/LayoutTestController.h:
2618         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2619         (LayoutTestController::counterValueForElementById):
2620
2621 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2622
2623         Rubberstamped by Oliver Hunt.
2624
2625         Change two methods to be internal for DRT use only.
2626
2627         Part of [Qt] Review all new API in Qt 4.6
2628         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
2629
2630         * DumpRenderTree/qt/DumpRenderTree.cpp:
2631         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2632         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2633         (LayoutTestController::whiteListAccessFromOrigin):
2634
2635 2009-10-27  Eric Seidel  <eric@webkit.org>
2636
2637         Reviewed by Adam Barth.
2638
2639         REGRESSION: svn-apply exits(1) when applying a patch with a file add
2640         https://bugs.webkit.org/show_bug.cgi?id=30826
2641
2642         * Scripts/svn-apply:
2643          - Add () around all system() calls.
2644          - Use the correct system() == 0 or die instead of system() or die
2645          - Add descriptive messages to all die statements.
2646
2647 2009-10-27  Steve Block  <steveblock@google.com>
2648
2649         Reviewed by NOBODY.
2650
2651         Adds steveblock@google.com to list of committers.
2652
2653         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
2654
2655 2009-10-27  Eric Seidel  <eric@webkit.org>
2656
2657         Reviewed by Adam Barth.
2658
2659         svn-apply can exit(0) even on patch failure
2660         https://bugs.webkit.org/show_bug.cgi?id=29622
2661
2662         * Scripts/svn-apply:
2663          - Add a bunch of "or die" statements, hopefully catching all
2664            possible cases where failure could still exit(0).
2665
2666 2009-10-27  Eric Seidel  <eric@webkit.org>
2667
2668         Reviewed by Adam Barth.
2669
2670         svn-* scripts should share code through VCSUtils.pm
2671         https://bugs.webkit.org/show_bug.cgi?id=30791
2672
2673         Just moving code into a shared location.
2674
2675         * Scripts/VCSUtils.pm:
2676         * Scripts/prepare-ChangeLog:
2677         * Scripts/resolve-ChangeLogs:
2678         * Scripts/svn-apply:
2679         * Scripts/svn-create-patch:
2680         * Scripts/svn-unapply:
2681         * Scripts/update-webkit:
2682
2683 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
2684
2685         Suppress a huge number of MSVC warnings when building wxWebKit.
2686
2687         * wx/build/settings.py:
2688
2689 2009-10-26  Eric Seidel  <eric@webkit.org>
2690
2691         No review, just adding Mike Belshe to the committers list.
2692
2693         * Scripts/modules/committers.py:
2694
2695 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2696
2697         Reviewed by Darin Adler.
2698
2699         Make .rc files compile on Windows without depending on MFC headers
2700         https://bugs.webkit.org/show_bug.cgi?id=30750
2701
2702         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
2703         windows.h instead of afxres.h because it exists even when MFC is not 
2704         installed, and is all that's needed here.
2705
2706         * FindSafari/FindSafari.rc: Ditto
2707
2708 2009-10-24  Eric Seidel  <eric@webkit.org>
2709
2710         Reviewed by Adam Barth.
2711
2712         bugzilla-tool post-diff should know how to mark commit-queue=?
2713         https://bugs.webkit.org/show_bug.cgi?id=29202
2714
2715         * Scripts/bugzilla-tool:
2716          - Add --commit-queue option to post-diff, post-commits and create-bug.
2717         * Scripts/modules/bugzilla.py:
2718          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
2719          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
2720
2721 2009-10-23  Eric Seidel  <eric@webkit.org>
2722
2723         Reviewed by Adam Barth.
2724
2725         bugzilla-tool commit-queue does not notice modifications to committers.py
2726         https://bugs.webkit.org/show_bug.cgi?id=30084
2727
2728         * Scripts/bugzilla-tool:
2729          - Make commit-queue re-exec itself instead of using while(1).
2730          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
2731          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
2732
2733 2009-10-22  Eric Seidel  <eric@webkit.org>
2734
2735         Reviewed by Adam Barth.
2736
2737         commit-queue will get stuck on patches if land-patches terminates unexpectedly
2738         https://bugs.webkit.org/show_bug.cgi?id=30634
2739
2740         * Scripts/bugzilla-tool:
2741          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
2742          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
2743
2744 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
2745
2746         Reviewed by Eric Seidel.
2747
2748         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
2749
2750         https://bugs.webkit.org/show_bug.cgi?id=30763
2751
2752         * pywebsocket/mod_pywebsocket/__init__.py:
2753         * pywebsocket/mod_pywebsocket/dispatch.py:
2754         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
2755         * pywebsocket/mod_pywebsocket/standalone.py:
2756         * pywebsocket/setup.py:
2757         * pywebsocket/test/test_dispatch.py:
2758
2759 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
2760
2761         Reviewed by David Levin.
2762
2763         REGRESSION: 2 failures in run-webkit-unittests
2764         https://bugs.webkit.org/show_bug.cgi?id=30645
2765
2766         * Scripts/modules/cpp_style_unittest.py:
2767         Fixed a few test scenarios which apparently lost some spaces from 
2768         text literals.
2769
2770 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
2771
2772         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
2773
2774         * Scripts/webkitdirs.pm:
2775
2776 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
2777
2778         Reviewed by Darin Adler.
2779
2780         Unification of using null device in perl scripts.
2781         https://bugs.webkit.org/show_bug.cgi?id=30572
2782
2783         * Scripts/VCSUtils.pm:
2784         * Scripts/bisect-builds:
2785         * Scripts/resolve-ChangeLogs:
2786         * Scripts/run-iexploder-tests:
2787         * Scripts/run-jsc:
2788         * Scripts/run-mangleme-tests:
2789         * Scripts/run-webkit-tests:
2790         * Scripts/webkitdirs.pm:
2791         Using File::Spec->devnull() instead of hard coded /dev/null.
2792
2793 2009-10-26  Eric Seidel  <eric@webkit.org>
2794
2795         Reviewed by Holger Freyther.
2796
2797         Reviewers are missing from committers.py
2798         https://bugs.webkit.org/show_bug.cgi?id=30733
2799
2800         * Scripts/modules/committers.py:
2801
2802 2009-10-23  Eric Seidel  <eric@webkit.org>
2803
2804         No review, only adding Alice to the list of reviewers.
2805
2806         * Scripts/modules/committers.py:
2807
2808 2009-10-23  Eric Seidel  <eric@webkit.org>
2809
2810         Reviewed by Eric Carlson.
2811
2812         fast/media/mq-transform-02.html failed on Leopard Commit Bot
2813         https://bugs.webkit.org/show_bug.cgi?id=30700
2814
2815         * DumpRenderTree/mac/DumpRenderTree.mm:
2816         (resetDefaultsToConsistentValues): Update QuickTime version check.
2817
2818 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
2819
2820         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
2821         character measurement APIs that are private on Tiger.
2822
2823         * wx/build/settings.py:
2824
2825 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2826
2827         Reviewed by NOBODY (build fix).
2828         Build fix following bug #30696.
2829
2830         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2831         (LayoutTestController::evaluateScriptInIsolatedWorld):
2832
2833 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2834
2835         Reviewed by Sam Weinig & Geoff Garen.
2836
2837         https://bugs.webkit.org/show_bug.cgi?id=30696
2838         Enable isolated-worlds tests on mac.
2839
2840         Add private interface for DRT to invoke execution in a given world.
2841
2842         * DumpRenderTree/LayoutTestController.cpp:
2843         (evaluateScriptInIsolatedWorldCallback):
2844         (LayoutTestController::staticFunctions):
2845         * DumpRenderTree/LayoutTestController.h:
2846         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2847         (LayoutTestController::evaluateScriptInIsolatedWorld):
2848         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2849         (LayoutTestController::evaluateScriptInIsolatedWorld):
2850
2851 2009-10-21  Eric Seidel  <eric@webkit.org>
2852
2853         Reviewed by Adam Barth.
2854
2855         bugzilla-tool's "patch failed to download an apply" error should give more information
2856         https://bugs.webkit.org/show_bug.cgi?id=30632
2857
2858         * Scripts/modules/scm.py:
2859          - Use the common run_command method instead of custom POpen code.
2860          - Make run_command know how to take pipes as input.
2861         * Scripts/modules/scm_unittest.py:
2862          - Add new tests to cover change.
2863          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
2864
2865 2009-10-21  Kent Tamura  <tkent@chromium.org>
2866
2867         Unreviewed.  Adding myself to the committers list.
2868
2869         * Scripts/modules/committers.py:
2870
2871 2009-10-21  Robin Dunn  <robin@alldunn.com>
2872
2873         Reviewed by Kevin Ollivier.
2874
2875         Update the Windows installer builder to work with Vista / Win 7 and with git.
2876         
2877         https://bugs.webkit.org/show_bug.cgi?id=30649
2878
2879         * wx/build/build_utils.py:
2880         * wx/packaging/build-mac-installer.py:
2881         * wx/packaging/build-win-installer.py:
2882         * wx/packaging/wxWebKitInstaller.iss.in:
2883
2884 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2885
2886         Reviewed by Gustavo Noronha.
2887
2888         [GTK] Added conditional code to avoid using
2889         gdk_window_get_root_coords if we do not have a gtk+ release newer
2890         than 2.17.3.
2891         https://bugs.webkit.org/show_bug.cgi?id=30636
2892
2893         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2894
2895 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
2896
2897         Reviewed by Eric Seidel.
2898
2899         [Qt] Added dummy implementation for keepWebHistory()
2900         https://bugs.webkit.org/show_bug.cgi?id=30592
2901
2902         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2903         (LayoutTestController::keepWebHistory):
2904         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2905
2906 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2907
2908         Reviewed by Xan Lopez.
2909
2910         [GTK] Fixed the double click condition, it is not double click if
2911         we move in just in one direction.
2912         https://bugs.webkit.org/show_bug.cgi?id=30636
2913
2914         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2915
2916 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2917
2918         Reviewed by Xan Lopez.
2919
2920         [GTK] Initialize the events completly before emitting them.
2921         https://bugs.webkit.org/show_bug.cgi?id=30633
2922
2923         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2924
2925 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2926
2927         wx build fix. Fix for when linking using --as-needed with gcc.
2928
2929         * wx/browser/wscript:
2930
2931 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2932
2933         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
2934         to support all the features used by CURL backend.
2935         
2936         * wx/build/settings.py:
2937         * wx/install-unix-extras:
2938
2939 2009-10-20  Anton Muhin  <antonm@chromium.org>
2940
2941         Reviewed by Adam Barth.
2942
2943         Add {ager,antonm,yurys}@chromium.org into committers.py
2944         https://bugs.webkit.org/show_bug.cgi?id=30560
2945
2946         * Scripts/modules/committers.py:
2947
2948 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2949
2950         Reviewed by Tor Arne Vestbø.
2951
2952         Make the Netscape Test plugin available to the Qt launcher.
2953
2954         * Scripts/run-launcher:
2955
2956 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
2957
2958         Reviewed by David Levin.
2959
2960         Removed WebSocket runtime settings.
2961         https://bugs.webkit.org/show_bug.cgi?id=29896
2962
2963         WebSocket runtime configuration is supported by chromium/v8 only.
2964
2965         * DumpRenderTree/mac/DumpRenderTree.mm:
2966         (resetDefaultsToConsistentValues):
2967         * DumpRenderTree/win/DumpRenderTree.cpp:
2968         (resetDefaultsToConsistentValues):
2969
2970 2009-10-19  Nate Chapin  <japhet@chromium.org>
2971
2972         Reviewed by Adam Barth.
2973
2974         Add testFail() to test plugin so we can test our handling of a
2975         plugin invoke call returning false.
2976
2977         https://bugs.webkit.org/show_bug.cgi?id=30239
2978
2979         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
2980         (pluginInvoke):
2981         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
2982
2983 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
2984
2985         Reviewed by Gustavo Noronha.
2986
2987         Enable DOM pasting when running layout tests.
2988
2989         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2990         (resetDefaultsToConsistentValues):
2991
2992 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2993
2994         Reviewed by Simon Hausmann.
2995
2996         Use the setPreferredContentsSize method instead
2997         of setFixedContentsSize, as the method has been renamed.
2998
2999         * DumpRenderTree/qt/DumpRenderTree.cpp:
3000         (WebCore::DumpRenderTree::open):
3001         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3002         (LayoutTestController::setFixedContentsSize):
3003
3004 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3005
3006         Reviewed by Dan Bernstein.
3007
3008         https://bugs.webkit.org/show_bug.cgi?id=30456
3009         Fixes for new Debug_All Windows build configuration.
3010
3011         * DumpRenderTree/win/DumpRenderTree.cpp:
3012         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
3013         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
3014
3015 2009-10-16  Eric Seidel  <eric@webkit.org>
3016
3017         Reviewed by Adam Barth.
3018
3019         commit-queue status bot should list which buildbot is blocking the queue
3020         https://bugs.webkit.org/show_bug.cgi?id=30452
3021
3022         Add new methods and testing.
3023
3024         * Scripts/bugzilla-tool:
3025         * Scripts/modules/buildbot.py:
3026         * Scripts/modules/buildbot_unittest.py:
3027
3028 2009-10-16  Eric Seidel  <eric@webkit.org>
3029
3030         Reviewed by Adam Barth.
3031
3032         run-webkit-tests fails when CWD is not inside a WebKit checkout
3033         https://bugs.webkit.org/show_bug.cgi?id=30451
3034
3035         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
3036         * Scripts/modules/scm_unittest.py:
3037           - Remove use of original_path (we don't need to restore the CWD).
3038           - Don't use '.' to find the webkit checkout, use __file__ instead.
3039
3040 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3041
3042         Reviewed by Adam Roben.
3043
3044         Add a Debug_All configuration to build entire stack as debug.
3045         Change Debug_Internal to:
3046         - stop using _debug suffix for all WebKit/Safari binaries
3047         - not use _debug as a DLL naming suffix
3048         - use non-debug C runtime lib.
3049
3050         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
3051         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
3052         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
3053         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3054         Add missing debug.vsprops inherited property sheet.
3055         Add Debug_All configuration.
3056         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
3057         * WinLauncher/WinLauncher.vcproj:
3058         Removed extraneous definitions inherited from vsprops.
3059         Add Debug_All configuration.
3060
3061 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
3062
3063         Reviewed by David Levin.
3064
3065         check-webkit-style is wrong about indent checking in namespaces
3066         in header files and a few other things
3067         https://bugs.webkit.org/show_bug.cgi?id=30362
3068
3069         The few other things include:
3070         + check-webkit-style does not require spaces around the equal sign
3071           inside 'if' statements and around binary operators that take 
3072           numeric literals.
3073         + check-webkit-style reports false errors for the / operator
3074           when part of a filename in the #include directive.
3075
3076         * Scripts/modules/cpp_style.py:
3077         Improved indentation checking and space checking around
3078         binary operators. While the checks are still not perfect,
3079         they are clearly better than before.
3080         * Scripts/modules/cpp_style_unittest.py:
3081         Added test cases for the newly supported checks and modified old
3082         test cases to match the new guidelines
3083
3084 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
3085
3086         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
3087
3088         * wx/build/settings.py:
3089
3090 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
3091
3092         Reviewed by David Levin.
3093
3094         Add mod_pywebsocket to test Web Sockets.
3095         http://code.google.com/p/pywebsocket/
3096         https://bugs.webkit.org/show_bug.cgi?id=27490
3097
3098         * pywebsocket/COPYING: Added.
3099         * pywebsocket/MANIFEST.in: Added.
3100         * pywebsocket/README: Added.
3101         * pywebsocket/example/echo_client.py: Added.
3102         * pywebsocket/example/echo_wsh.py: Added.
3103         * pywebsocket/mod_pywebsocket/__init__.py: Added.
3104         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
3105         * pywebsocket/mod_pywebsocket/handshake.py: Added.
3106         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
3107         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
3108         * pywebsocket/mod_pywebsocket/standalone.py: Added.
3109         * pywebsocket/mod_pywebsocket/util.py: Added.
3110         * pywebsocket/setup.py: Added.
3111         * pywebsocket/test/config.py: Added.
3112         * pywebsocket/test/mock.py: Added.
3113         * pywebsocket/test/run_all.py: Added.
3114         * pywebsocket/test/test_dispatch.py: Added.
3115         * pywebsocket/test/test_handshake.py: Added.
3116         * pywebsocket/test/test_mock.py: Added.
3117         * pywebsocket/test/test_msgutil.py: Added.
3118         * pywebsocket/test/test_util.py: Added.
3119         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
3120         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
3121         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
3122         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
3123         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
3124         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
3125         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
3126         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
3127
3128 2009-10-15  James Robinson  <jamesr@google.com>
3129
3130         Reviewed by David Levin.
3131
3132         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
3133
3134         https://bugs.webkit.org/show_bug.cgi?id=30426
3135
3136         * Scripts/modules/cpp_style.py:
3137         * Scripts/modules/cpp_style_unittest.py:
3138
3139 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
3140
3141         Reviewed by Adam Roben.
3142
3143         Fixes <http://webkit.org/b/30411>.
3144         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
3145         
3146         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
3147         building Chromium.
3148
3149         * Scripts/pdevenv:
3150
3151 2009-10-15  Robin Dunn  <robin@alldunn.com>
3152
3153         Reviewed by Kevin Ollivier.
3154
3155         Add Mac package building scripts for wx.
3156         
3157         https://bugs.webkit.org/show_bug.cgi?id=30405
3158
3159         * wx/build/build_utils.py:
3160         * wx/build/settings.py:
3161         * wx/packaging/build-mac-installer.py: Added.
3162
3163 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
3164
3165         Reviewed by Gustavo Noronha.
3166
3167         Enable Web Sockets support when running layout tests.
3168
3169         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3170         (resetDefaultsToConsistentValues):
3171
3172 2009-10-15  Xan Lopez  <xlopez@igalia.com>
3173
3174         Reviewed by Gustavo Noronha.
3175
3176         Need to initialize event.button.button, since in most cases a
3177         button number is not passed as an argument.
3178
3179         * DumpRenderTree/gtk/EventSender.cpp:
3180         (mouseDownCallback):
3181         (mouseUpCallback):
3182
3183 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
3184
3185         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
3186         the OS if none was explicitly set.
3187
3188         * wx/build/settings.py:
3189
3190 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
3191
3192         Reviewed by Timothy Hatcher.
3193
3194         Web Inspector: enable developers extras within inspector layout tests.
3195
3196         https://bugs.webkit.org/show_bug.cgi?id=30014
3197
3198         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3199         (LayoutTestController::showWebInspector):
3200         (LayoutTestController::closeWebInspector):
3201         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3202         (LayoutTestController::showWebInspector):
3203         (LayoutTestController::closeWebInspector):
3204
3205 2009-10-14  José Millán Soto  <jmillan@igalia.com>
3206
3207         Reviewed by Jan Alonzo.
3208
3209         GtkLauncher is using a deprecated signal
3210         https://bugs.webkit.org/show_bug.cgi?id=30364
3211
3212         Modified GtkLauncher to use notify::title signal instead of
3213         deprecated title-changed signal
3214
3215         * GtkLauncher/main.c:
3216         (notify_title_cb):
3217         (create_browser):
3218
3219 2009-10-14  Brady Eidson  <beidson@apple.com>
3220
3221         Reviewed by Sam Weinig.
3222
3223         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
3224         1 - Disables WebHistory
3225         2 - Doesn't make sense in that context anyway.
3226
3227         * DumpRenderTree/win/DumpRenderTree.cpp:
3228         (createWebViewAndOffscreenWindow):
3229
3230 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
3231
3232         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
3233         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
3234
3235         * wx/build/settings.py:
3236         * wx/install-unix-extras:
3237
3238 2009-10-14  Brady Eidson  <beidson@apple.com>
3239
3240         Reviewed by Sam Weinig.
3241
3242         WebKit Win API should provide a delegate interface for global history.
3243         https://bugs.webkit.org/show_bug.cgi?id=29905
3244
3245         * DumpRenderTree/LayoutTestController.cpp:
3246         (LayoutTestController::LayoutTestController):
3247         * DumpRenderTree/LayoutTestController.h:
3248         (LayoutTestController::dumpHistoryDelegateCallbacks):
3249         (LayoutTestController::setDumpHistoryDelegateCallbacks):
3250                 
3251         * DumpRenderTree/win/DumpRenderTree.cpp:
3252         (shouldLogHistoryDelegates):
3253         (runTest):
3254         (createWebViewAndOffscreenWindow):
3255         (main):
3256         * DumpRenderTree/win/DumpRenderTree.vcproj:
3257         
3258         Add the IWebHistoryDelegate to DRT Windows:
3259         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
3260         (wstringFromBSTR):
3261         (HistoryDelegate::HistoryDelegate):
3262         (HistoryDelegate::~HistoryDelegate):
3263         (HistoryDelegate::QueryInterface):
3264         (HistoryDelegate::AddRef):
3265         (HistoryDelegate::Release):
3266         (HistoryDelegate::didNavigateWithNavigationData):
3267         (HistoryDelegate::didPerformClientRedirectFromURL):
3268         (HistoryDelegate::didPerformServerRedirectFromURL):
3269         (HistoryDelegate::updateHistoryTitle):
3270         (HistoryDelegate::populateVisitedLinksForWebView):
3271         * DumpRenderTree/win/HistoryDelegate.h: Added.
3272
3273         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3274         (LayoutTestController::removeAllVisitedLinks):
3275
3276 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
3277
3278         Reviewed by Simon Hausmann.
3279
3280         [Qt] Implement support for setPOSIXLocale on Qt.
3281         https://bugs.webkit.org/show_bug.cgi?id=30268 
3282  
3283         * DumpRenderTree/qt/DumpRenderTree.cpp:
3284         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3285         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3286         (LayoutTestController::setPOSIXLocale):
3287         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3288
3289 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3290
3291         Unreviewed, adding myself to reviewers list.
3292
3293         * Scripts/modules/committers.py:
3294
3295 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3296
3297         Reviewed by Mark Rowe.
3298
3299         Fix null assignment so root tests work again.
3300
3301         * Scripts/webkitdirs.pm:
3302
3303 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3304
3305         Reviewed by Simon Hausmann.
3306
3307         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
3308         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
3309         This is done in preparation of implementing missing features in DRT.
3310         No functionality changes made yet.
3311
3312         * DumpRenderTree/qt/DumpRenderTree.cpp:
3313         * DumpRenderTree/qt/DumpRenderTree.pro:
3314         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
3315         (EventSender::EventSender):
3316         (EventSender::mouseDown):
3317         (EventSender::mouseUp):
3318         (EventSender::mouseMoveTo):
3319         (EventSender::leapForward):
3320         (EventSender::keyDown):
3321         (EventSender::contextClick):
3322         (EventSender::scheduleAsynchronousClick):
3323         (EventSender::frameUnderMouse):
3324         * DumpRenderTree/qt/EventSenderQt.h: Added.
3325         (EventSender::clearKillRing):
3326         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
3327         (LayoutTestController::LayoutTestController):
3328         (LayoutTestController::reset):
3329         (LayoutTestController::processWork):
3330         (LayoutTestController::maybeDump):
3331         (LayoutTestController::waitUntilDone):
3332         (LayoutTestController::notifyDone):
3333         (LayoutTestController::windowCount):
3334         (LayoutTestController::clearBackForwardList):
3335         (LayoutTestController::dumpEditingCallbacks):
3336         (LayoutTestController::dumpResourceLoadCallbacks):
3337         (LayoutTestController::queueBackNavigation):
3338         (LayoutTestController::queueForwardNavigation):
3339         (LayoutTestController::queueLoad):
3340         (LayoutTestController::queueReload):
3341         (LayoutTestController::queueScript):
3342         (LayoutTestController::provisionalLoad):
3343         (LayoutTestController::timerEvent):
3344         (LayoutTestController::encodeHostName):
3345         (LayoutTestController::decodeHostName):
3346         (LayoutTestController::setJavaScriptProfilingEnabled):
3347         (LayoutTestController::setFixedContentsSize):
3348         (LayoutTestController::setPrivateBrowsingEnabled):
3349         (LayoutTestController::setPopupBlockingEnabled):
3350         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3351         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3352         (LayoutTestController::numberOfActiveAnimations):
3353         (LayoutTestController::disableImageLoading):
3354         (LayoutTestController::dispatchPendingLoadRequests):
3355         (LayoutTestController::setDatabaseQuota):
3356         (LayoutTestController::clearAllDatabases):
3357         (LayoutTestController::whiteListAccessFromOrigin):
3358         (LayoutTestController::waitForPolicyDelegate):
3359         (LayoutTestController::overridePreference):
3360         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
3361         (LayoutTestController::isLoading):
3362         (LayoutTestController::setLoading):
3363         (LayoutTestController::shouldDumpAsText):
3364         (LayoutTestController::shouldDumpBackForwardList):
3365         (LayoutTestController::shouldDumpChildrenAsText):
3366         (LayoutTestController::shouldDumpDatabaseCallbacks):
3367         (LayoutTestController::shouldDumpStatusCallbacks):
3368         (LayoutTestController::shouldWaitUntilDone):
3369         (LayoutTestController::canOpenWindows):
3370         (LayoutTestController::shouldDumpTitleChanges):
3371         (LayoutTestController::waitForPolicy):
3372         (LayoutTestController::dumpAsText):
3373         (LayoutTestController::dumpChildFramesAsText):
3374         (LayoutTestController::dumpDatabaseCallbacks):
3375         (LayoutTestController::dumpStatusCallbacks):
3376         (LayoutTestController::setCanOpenWindows):
3377         (LayoutTestController::dumpBackForwardList):
3378         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3379         (LayoutTestController::display):
3380         (LayoutTestController::dumpTitleChanges):
3381         (LayoutTestController::dumpSelectionRect):
3382         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
3383         (TextInputController::TextInputController):
3384         (TextInputController::doCommand):
3385         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
3386         * DumpRenderTree/qt/WorkQueue.cpp:
3387         * DumpRenderTree/qt/WorkQueue.h:
3388         * DumpRenderTree/qt/WorkQueueItem.h:
3389         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
3390         (findFrameNamed):
3391         (LoadItem::invoke):
3392         (ReloadItem::invoke):
3393         (ScriptItem::invoke):
3394         (BackForwardItem::invoke):
3395         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
3396         * DumpRenderTree/qt/jsobjects.h:
3397
3398 2009-10-13  Dmitry Titov  <dimich@chromium.org>
3399
3400         Not reviewed, adding myself to the list of reviewers.
3401
3402         * Scripts/modules/committers.py:
3403
3404 2009-10-13  Anders Carlsson  <andersca@apple.com>
3405
3406         Reviewed by Sam Weinig.
3407
3408         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
3409
3410         Make the private browsing mode testable by the test plug-in.
3411         
3412         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3413         (pluginGetProperty):
3414         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3415         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3416         (NPP_New):
3417         (NPP_SetValue):
3418
3419 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
3420
3421         No review, just adding self to the list of reviewers.
3422
3423         * Scripts/modules/committers.py:
3424
3425 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
3426
3427         Reviewed by Adam Roben.
3428
3429         Web Inspector: Use proper web view in inspector layout
3430         tests for windows.
3431
3432         https://bugs.webkit.org/show_bug.cgi?id=30298
3433
3434         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3435         (LayoutTestController::showWebInspector):
3436         (LayoutTestController::closeWebInspector):
3437         (LayoutTestController::evaluateInWebInspector):
3438
3439 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
3440
3441         Reviewed by Sam Weinig.
3442
3443         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
3444         https://bugs.webkit.org/show_bug.cgi?id=29841
3445
3446         * DumpRenderTree/mac/DumpRenderTree.mm:
3447         (resetDefaultsToConsistentValues):
3448         * DumpRenderTree/win/DumpRenderTree.cpp:
3449         (resetDefaultsToConsistentValues):
3450
3451 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
3452
3453         Reviewed by Dimitri Glazkov.
3454
3455         Chromium Port - Windows
3456         https://bugs.webkit.org/show_bug.cgi?id=29969
3457
3458         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
3459         * Scripts/webkitdirs.pm:
3460
3461 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
3462
3463         Reviewed by Darin Adler.
3464
3465         jsc scripts cleanup and Qt/GTK fix
3466         https://bugs.webkit.org/show_bug.cgi?id=30288
3467
3468         Duplicated jscPath() moved to webkitdirs.pm.
3469         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
3470         Configuration added (release/debug) to path for Qt-port on Windows.
3471
3472         * Scripts/run-javascriptcore-tests:
3473         * Scripts/run-jsc:
3474         * Scripts/run-sunspider:
3475         * Scripts/sunspider-compare-results:
3476         * Scripts/webkitdirs.pm:
3477
3478 2009-10-11  Adam Barth  <abarth@webkit.org>
3479
3480         Unreviewed.  Add Collin to committers.py.
3481
3482         * Scripts/modules/committers.py:
3483
3484 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
3485
3486         wx build fix, add bindings to source/include dirs now that there are sources there.
3487
3488         * wx/build/settings.py:
3489
3490 2009-10-09  Mark Rowe  <mrowe@apple.com>
3491
3492         Reviewed by Brady Eidson.
3493
3494         Enable plug-in halting in DumpRenderTree.
3495
3496         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
3497         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
3498
3499         * DumpRenderTree/mac/DumpRenderTree.mm:
3500         (resetDefaultsToConsistentValues):
3501         * DumpRenderTree/mac/UIDelegate.mm:
3502         (-[UIDelegate webView:shouldHaltPlugin:]):
3503
3504 2009-10-08  Brady Eidson  <beidson@apple.com>
3505
3506         Reviewed by Dan Bernstein.
3507
3508         Ask the History Delegate to populate the visited links hash.
3509         <rdar://problem/7285293> and https://webkit.org/b/29904
3510
3511         Add the ability for LayoutTestController to clear all visited links.
3512         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
3513
3514         * DumpRenderTree/LayoutTestController.cpp:
3515         (LayoutTestController::LayoutTestController):
3516         (removeAllVisitedLinksCallback):
3517         (LayoutTestController::staticFunctions):
3518         * DumpRenderTree/LayoutTestController.h:
3519         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3520         (LayoutTestController::removeAllVisitedLinks):
3521
3522         * DumpRenderTree/mac/HistoryDelegate.mm:
3523         (-[HistoryDelegate populateVisitedLinksForWebView:]):
3524
3525         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3526         (LayoutTestController::removeAllVisitedLinks):
3527         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3528         (LayoutTestController::removeAllVisitedLinks):
3529         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3530         (LayoutTestController::removeAllVisitedLinks):
3531
3532
3533 2009-10-08  Daniel Bates  <dbates@webkit.org>
3534
3535         Reviewed by Adam Roben.
3536
3537         https://bugs.webkit.org/show_bug.cgi?id=30175
3538         
3539         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
3540         the OLE drag-and-drop return value like the function it emulates. Currently, 
3541         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
3542         whether the drag-and-drop operation was successful or was cancelled.
3543         
3544         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
3545         return value according to whether the drop operation was successful or not.
3546
3547         * DumpRenderTree/win/EventSender.cpp:
3548         (doMouseUp): Added parameter oleDragAndDropReturnValue.
3549         (replaySavedEvents): Ditto.
3550         * DumpRenderTree/win/EventSender.h:
3551         * DumpRenderTree/win/UIDelegate.cpp:
3552         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
3553
3554 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3555
3556         Reviewed by Xan Lopez.
3557
3558         [GTK] Added support for a parameter setting the button that was
3559         pressed in the mouseDown function.
3560         https://bugs.webkit.org/show_bug.cgi?id=30220
3561
3562         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3563
3564 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3565
3566         Reviewed by Xan Lopez.
3567
3568         [GTK] Added a line to the bottom of the expected result to match
3569         the output of the test.
3570         https://bugs.webkit.org/show_bug.cgi?id=30220
3571
3572         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
3573         expected.txt:
3574
3575 2009-10-08  Adam Roben  <aroben@apple.com>
3576
3577         Use QueryInterface to get IWebInspectorPrivate
3578
3579         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
3580         accessed in a more standard way
3581
3582         Reviewed by John Sullivan and Tim Hatcher.
3583
3584         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3585         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
3586         by calling IWebViewPrivate::inspector, then use QueryInterface to get
3587         to the IWebInspectorPrivate interface.
3588
3589 2009-10-07  Adam Roben  <aroben@apple.com>
3590
3591         Implement DRT support for origin whitelisting
3592
3593         Fixes <http://webkit.org/b/30185>.
3594
3595         Reviewed by Eric Seidel.
3596
3597         * DumpRenderTree/win/DumpRenderTree.cpp:
3598         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
3599         whitelist, to match Mac DRT.
3600         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3601         (LayoutTestController::whiteListAccessFromOrigin): Call through to
3602         IWebViewPrivate::whiteListAccessFromOrigin.
3603
3604 2009-10-07  Brady Eidson  <beidson@apple.com>
3605
3606         Reviewed by Darin Adler.
3607
3608         Send title changes to the global history delegate.
3609         <rdar://problem/7285293> and https://webkit.org/b/29904
3610
3611         * DumpRenderTree/mac/HistoryDelegate.mm:
3612         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
3613
3614 2009-10-07  Adam Barth  <abarth@webkit.org>
3615
3616         Unreviewed.  Remove some folks from committers.py who were listed on
3617         the WebKit Team wiki page but who weren't actually listed as commit+.
3618         At some point, we should coorelate this list with the committers
3619         mailing list.
3620
3621         * Scripts/modules/committers.py:
3622
3623 2009-10-07  Adam Barth  <abarth@webkit.org>
3624
3625         Unreviewed.  Import a bunch of committers from the WebKit Team page on
3626         the wiki into committers.py.
3627
3628         * Scripts/modules/committers.py:
3629
3630 2009-10-07  Adam Barth  <abarth@webkit.org>
3631
3632         Unreviewed.  Added Aaron Boodman to committers.py.
3633
3634         * Scripts/modules/committers.py:
3635
3636 2009-10-07  Evan Martin  <evan@chromium.org>
3637
3638         Reviewed by Darin Adler.
3639
3640         Add API to LayoutTestController for re/setting the system locale.
3641         https://bugs.webkit.org/show_bug.cgi?id=18994
3642
3643         * DumpRenderTree/LayoutTestController.cpp:
3644         (setLocaleCallback):
3645         (LayoutTestController::staticFunctions):
3646         (LayoutTestController::setLocale):
3647         * DumpRenderTree/LayoutTestController.h:
3648
3649 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
3650
3651         Reviewed by Jan Alonzo.
3652
3653         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3654         https://bugs.webkit.org/show_bug.cgi?id=29689
3655
3656         Build fix by adding -lfontconfig for DumpRenderTree.
3657
3658         * GNUmakefile.am:
3659
3660 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3661
3662         Reviewed by Simon Hausmann.
3663
3664         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
3665
3666         * Scripts/run-webkit-tests:
3667
3668 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3669
3670         Reviewed by Gustavo Noronha.
3671
3672         "delete" in EventSender is the backspace key, not the delete one.
3673
3674         * DumpRenderTree/gtk/EventSender.cpp:
3675         (keyDownCallback):
3676
3677 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3678
3679         Reviewed by Gustavo Noronha.
3680
3681         getChildrenWithRange expects as last parameter the end index, not
3682         the length of the range. Correct this and clarify the variable
3683         names to reflect how the code works.
3684
3685         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3686         (AccessibilityUIElement::getChildrenWithRange):
3687         (AccessibilityUIElement::getChildAtIndex):
3688
3689 2009-10-06  Mark Rowe  <mrowe@apple.com>
3690
3691      &nbs