WebKitTools/ChangeLog

   1 2009-11-20  Adam Barth  <abarth@webkit.org>
   2
   3         Reviewed by Eric Seidel.
   4
   5         Move bugzilla-tool commands into their own file
   6         https://bugs.webkit.org/show_bug.cgi?id=31752
   7
   8         This will let us write unit tests.
   9
  10         * Scripts/bugzilla-tool:
  11         * Scripts/modules/commands/__init__.py: Added.
  12         * Scripts/modules/commands/download.py: Added.
  13         * Scripts/modules/commands/queries.py: Added.
  14         * Scripts/modules/commands/queues.py: Added.
  15         * Scripts/modules/commands/upload.py: Added.
  16         * Scripts/modules/grammar.py: Added.
  17
  18 2009-11-20  Adam Barth  <abarth@webkit.org>
  19
  20         Reviewed by Eric Seidel.
  21
  22         BuildQueue should check if the tree is currently buildable
  23         https://bugs.webkit.org/show_bug.cgi?id=31744
  24
  25         * Scripts/bugzilla-tool:
  26         * Scripts/modules/landingsequence.py:
  27         * Scripts/modules/webkitlandingscripts.py:
  28
  29 2009-11-20  Adam Barth  <abarth@webkit.org>
  30
  31         Reviewed by Eric Seidel.
  32
  33         Move prepare_clean_working_directory into the LandingSequence
  34         https://bugs.webkit.org/show_bug.cgi?id=31743
  35
  36         * Scripts/bugzilla-tool:
  37         * Scripts/modules/landingsequence.py:
  38
  39 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
  40
  41         Reviewed by Kenneth Rohde Christiansen.
  42
  43         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
  44         https://bugs.webkit.org/show_bug.cgi?id=30460
  45
  46         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
  47
  48         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
  49         (pluginInvoke):
  50
  51 2009-11-20  Adam Barth  <abarth@webkit.org>
  52
  53         Reviewed by Eric Seidel.
  54
  55         Pass the port information to the child process
  56         https://bugs.webkit.org/show_bug.cgi?id=31736
  57
  58         We need to do this so the child process knows what to build!
  59
  60         * Scripts/bugzilla-tool:
  61         * Scripts/modules/landingsequence.py:
  62         * Scripts/modules/webkitport.py:
  63         * Scripts/modules/webkitport_unittest.py:
  64
  65 2009-11-20  Adam Barth  <abarth@webkit.org>
  66
  67         Reviewed by Eric Seidel.
  68
  69         Support Qt port in build-queue
  70         https://bugs.webkit.org/show_bug.cgi?id=31733
  71
  72         * Scripts/bugzilla-tool:
  73
  74 2009-11-20  Adam Barth  <abarth@webkit.org>
  75
  76         Reviewed by Eric Seidel.
  77
  78         Implement a build-queue
  79         https://bugs.webkit.org/show_bug.cgi?id=31725
  80
  81         Currently this just builds the first 10 patches in the review queue.
  82         We'll want to do something smarter soon.
  83
  84         * Scripts/bugzilla-tool:
  85
  86 2009-11-20  Adam Barth  <abarth@webkit.org>
  87
  88         Reviewed by Eric Seidel.
  89
  90         Make commit-queue and style-queue show up in help
  91         https://bugs.webkit.org/show_bug.cgi?id=31724
  92
  93         We need to store their names on their class to make these commands
  94         properly register themselves with MultiCommandTool.
  95
  96         * Scripts/bugzilla-tool:
  97
  98 2009-11-20  Adam Barth  <abarth@webkit.org>
  99
 100         Reviewed by Eric Seidel.
 101
 102         Implement bugzilla-tool build-attachment
 103         https://bugs.webkit.org/show_bug.cgi?id=31722
 104
 105         This command builds an attachment from bugzilla.  It leaves the built
 106         patch in the working copy.
 107
 108         * Scripts/bugzilla-tool:
 109         * Scripts/modules/landingsequence.py:
 110         * Scripts/modules/webkitlandingscripts.py:
 111
 112 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
 113
 114         Reviewed by Xan Lopez.
 115
 116         [GTK] DRT release event does not create the state correctly
 117         https://bugs.webkit.org/show_bug.cgi?id=31717
 118
 119         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
 120
 121 2009-11-20  Eric Seidel  <eric@webkit.org>
 122
 123         Reviewed by Adam Barth.
 124
 125         MultiCommandTool should find Command objects automatically instead of with a manual list
 126         https://bugs.webkit.org/show_bug.cgi?id=31710
 127
 128         * Scripts/bugzilla-tool:
 129         * Scripts/modules/multicommandtool.py:
 130          - Use some wild python-fu to crawl all the known subclasses of Command.
 131
 132 2009-11-20  Adam Barth  <abarth@webkit.org>
 133
 134         Unreviewed "build" fix.  Added missing import.
 135
 136         * Scripts/bugzilla-tool:
 137
 138 2009-11-20  Adam Barth  <abarth@webkit.org>
 139
 140         Unreviewed "build" fix.  I failed to update LandingSequence.test
 141         properly.
 142
 143         * Scripts/modules/landingsequence.py:
 144
 145 2009-11-20  Adam Barth  <abarth@webkit.org>
 146
 147         Reviewed by Eric Seidel.
 148
 149         Create LandingSequence as the all-sing, all-dance landing class
 150         https://bugs.webkit.org/show_bug.cgi?id=31709
 151
 152         Client can inherit from this class to carefully control exactly which
 153         steps they wish to have happen in the landing sequence.
 154
 155         * Scripts/bugzilla-tool:
 156         * Scripts/modules/landingsequence.py: Added.
 157         * Scripts/modules/webkitlandingscripts.py: Added.
 158
 159 2009-11-19  Adam Barth  <abarth@webkit.org>
 160
 161         Reviewed by Eric Seidel.
 162
 163         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
 164         https://bugs.webkit.org/show_bug.cgi?id=31707
 165
 166         This is to help when we implement build-attachment.
 167
 168         * Scripts/bugzilla-tool:
 169
 170 2009-11-19  Adam Barth  <abarth@webkit.org>
 171
 172         Reviewed by Eric Seidel.
 173
 174         Support Qt port in bugzilla-tool
 175         https://bugs.webkit.org/show_bug.cgi?id=31701
 176
 177         Now we support building with Qt!
 178
 179         * Scripts/bugzilla-tool:
 180         * Scripts/modules/webkitport.py: Added.
 181         * Scripts/modules/webkitport_unittest.py: Added.
 182         * Scripts/run-webkit-unittests:
 183
 184 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
 185
 186         Reviewed by Adam Barth.
 187
 188         Remove inserting stderr into patch in bugzilla-tool
 189         https://bugs.webkit.org/show_bug.cgi?id=29914
 190
 191         Modify SCM python module's run_command function to avoid return of stderr
 192         by default, so stderr won't be inserted into the patches.
 193         Modify the related unit test.
 194
 195         * Scripts/modules/scm.py:
 196         * Scripts/modules/scm_unittest.py:
 197
 198 2009-11-19  Eric Seidel  <eric@webkit.org>
 199
 200         Reviewed by Adam Barth.
 201
 202         bugzilla-tool needs per-command help
 203         https://bugs.webkit.org/show_bug.cgi?id=31697
 204
 205         Added support for "bugzilla-tool help command-name"
 206         and a unit test to make sure it works.
 207
 208         * Scripts/modules/multicommandtool.py:
 209         * Scripts/modules/multicommandtool_unittest.py:
 210
 211 2009-11-19  Eric Seidel  <eric@webkit.org>
 212
 213         Reviewed by Adam Barth.
 214
 215         Move MultiCommandTool and Command into a separate file and add some basic unit tests
 216         https://bugs.webkit.org/show_bug.cgi?id=31695
 217
 218         * Scripts/bugzilla-tool:
 219         * Scripts/modules/multicommandtool.py: Added.
 220         * Scripts/modules/multicommandtool_unittest.py: Added.
 221         * Scripts/run-webkit-unittests:
 222
 223 2009-11-19  Eric Seidel  <eric@webkit.org>
 224
 225         No review, just adding a FIXME.
 226
 227         Split out command parsing and help printing from BugzillaTool
 228         https://bugs.webkit.org/show_bug.cgi?id=31688
 229
 230         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
 231
 232 2009-11-19  Eric Seidel  <eric@webkit.org>
 233
 234         Reviewed by Adam Barth.
 235
 236         Split out command parsing and help printing from BugzillaTool
 237         https://bugs.webkit.org/show_bug.cgi?id=31688
 238
 239         * Scripts/bugzilla-tool:
 240          - Add new MultiCommandTool class to contain option parsing and help printing logic.
 241          - Rename private methods to use _ pattern.
 242          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
 243          -
 244
 245 2009-11-19  Eric Seidel  <eric@webkit.org>
 246
 247         Reviewed by Adam Barth.
 248
 249         Re-factor help printing to use modern python idioms
 250         https://bugs.webkit.org/show_bug.cgi?id=31685
 251
 252         * Scripts/bugzilla-tool:
 253
 254 2009-11-19  Eric Seidel  <eric@webkit.org>
 255
 256         Reviewed by Darin Adler.
 257
 258         commit-queue empty queue logs twice
 259         https://bugs.webkit.org/show_bug.cgi?id=31679
 260
 261         * Scripts/bugzilla-tool:
 262
 263 2009-11-19  Eric Seidel  <eric@webkit.org>
 264
 265         Reviewed by Darin Adler.
 266
 267         bugzilla-tool's reviewer/committer rejection message should be clearer
 268         https://bugs.webkit.org/show_bug.cgi?id=31126
 269
 270         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
 271
 272         * Scripts/modules/bugzilla.py:
 273
 274 2009-11-19  Eric Z. Ayers  <zundel@google.com>
 275
 276         Reviewed by Pavel Feldman.
 277
 278         Forces a WM_PAINT event on calling layoutTestController.display()
 279         in order to enable the timeline-paint.html test on Windows.
 280         ::UpdateWindow() does not force an event becaue the window is
 281         not visible.
 282
 283         https://bugs.webkit.org/show_bug.cgi?id=31402
 284
 285         * DumpRenderTree/win/DumpRenderTree.cpp:
 286         (displayWebView):
 287
 288 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
 289
 290         No review needed.
 291
 292         Added myself to committers list.
 293
 294         * Scripts/modules/committers.py:
 295
 296 2009-11-19  Adam Barth  <abarth@webkit.org>
 297
 298         Reviewed by Eric Seidel.
 299
 300         Bugzilla-tool command classes should match command names
 301         https://bugs.webkit.org/show_bug.cgi?id=31666
 302
 303         I renamed all the commands except CommitMessageForCurrentDiff because
 304         the new name would conflict with an existing class.
 305
 306         * Scripts/bugzilla-tool:
 307
 308 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
 309
 310         Reviewed by Gustavo Noronha Silva.
 311
 312         Web Inspector: Implement "show inspector" in WebKit GTK
 313         API and enable console tests.
 314
 315         https://bugs.webkit.org/show_bug.cgi?id=31669
 316
 317         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 318         (LayoutTestController::showWebInspector):
 319
 320 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 321
 322         Reviewed by Simon Hausmann.
 323
 324         Minor refactoring + more documentation.
 325
 326         * DumpRenderTree/qt/DumpRenderTree.cpp:
 327         (WebCore::clearHistory):
 328         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
 329
 330 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
 331
 332         Reviewed by Eric Seidel.
 333
 334         Ignore websocket tests when --no-http is specified.
 335         https://bugs.webkit.org/show_bug.cgi?id=31662
 336
 337         * Scripts/run-webkit-tests:
 338
 339 2009-11-18  Adam Barth  <abarth@webkit.org>
 340
 341         Reviewed by Eric Seidel.
 342
 343         Normalize ' and " in bugzilla-tool
 344         https://bugs.webkit.org/show_bug.cgi?id=31655
 345
 346         We decided " is better than ' and we should be consistent.
 347
 348         * Scripts/bugzilla-tool:
 349
 350 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 351
 352         Reviewed by Kenneth Rohde Christiansen.
 353
 354         [Qt] Remove support for Qt v4.3 or older versions
 355         https://bugs.webkit.org/show_bug.cgi?id=29469
 356
 357         * DumpRenderTree/qt/DumpRenderTree.pro:
 358         * DumpRenderTree/qt/ImageDiff.pro:
 359
 360 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
 361
 362         Reviewed by Eric Seidel.
 363
 364         GitTest.test_create_binary_patch fails if /tmp is symlink
 365         https://bugs.webkit.org/show_bug.cgi?id=31536
 366
 367         * Scripts/modules/scm_unittest.py:
 368
 369 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
 370
 371         Reviewed by Darin Adler.
 372
 373         Configuration for Chromium Build Slaves.
 374
 375         https://bugs.webkit.org/show_bug.cgi?id=31442
 376
 377         * BuildSlaveSupport/build.webkit.org-config/config.json:
 378         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 379
 380 2009-11-18  Eric Seidel  <eric@webkit.org>
 381
 382         Reviewed by Darin Adler.
 383
 384         workqueue.py results in totally broken commit-queue UI
 385         https://bugs.webkit.org/show_bug.cgi?id=31645
 386
 387         * Scripts/bugzilla-tool:
 388          - Remove unneeded use of PatchCollection.
 389          - Grab a new copy of the cq'd patches every run of the queue.
 390
 391 2009-11-18  Sam Weinig  <sam@webkit.org>
 392
 393         Reviewed by Anders Carlsson.
 394
 395         Make the Mac Geolocation API async.
 396
 397         Update DRT to use the new async Mac Geolocation API.
 398
 399         * DumpRenderTree/mac/UIDelegate.mm:
 400         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
 401
 402 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 403
 404         Reviewed by Kenneth Rohde Christiansen.
 405
 406         Add and option to toggle HTML5 datalist support to build-webkit
 407         https://bugs.webkit.org/show_bug.cgi?id=31599
 408
 409         * Scripts/build-webkit:
 410
 411 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
 412
 413         Reviewed by Kevin Ollivier.
 414
 415         Enable wx plugin support using the Windows implementation as a base.
 416
 417         https://bugs.webkit.org/show_bug.cgi?id=31636
 418
 419         * wx/build/settings.py:
 420
 421 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 422
 423         Reviewed by Simon Hausmann.
 424
 425         Change the initialization order so that the controllers
 426         will be created before exporting them to the JS DOM window.
 427
 428         * DumpRenderTree/qt/DumpRenderTree.cpp:
 429         (WebCore::DumpRenderTree::DumpRenderTree):
 430
 431 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 432
 433         Reviewed by Simon Hausmann.
 434
 435         Fix a code copy and paste error. m_page should be page.
 436
 437         * DumpRenderTree/qt/DumpRenderTree.cpp:
 438         (WebCore::DumpRenderTree::createWindow):
 439
 440 2009-11-17  Mark Rowe  <mrowe@apple.com>
 441
 442         Reviewed by Alexey Proskuryakov.
 443
 444         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
 445
 446         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
 447         This prevents symlinks from confusing the descendant check.
 448
 449 2009-11-17  Mark Rowe  <mrowe@apple.com>
 450
 451         Reviewed by Alexey Proskuryakov.
 452
 453         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
 454
 455         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
 456         server to be up rather than having run-webkit-tests abort immediately.
 457
 458         * Scripts/run-webkit-tests:
 459
 460 2009-11-17  Eric Seidel  <eric@webkit.org>
 461
 462         Reviewed by Darin Adler.
 463
 464         commit-queue is failing to set reviewer in ChangeLogs
 465         https://bugs.webkit.org/show_bug.cgi?id=31592
 466
 467         * Scripts/bugzilla-tool: Clarify the "applying" log message.
 468         * Scripts/modules/bugzilla.py:
 469          - Add a new _validate_committer_and_reviewer function as a
 470            temporary solution until we can make a real Attachment object
 471            which knows how to fill in its committer/reviewer fields automatically.
 472
 473 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 474
 475         Unreviewed buildbot fix.
 476
 477         Revert part of earlier patch and add comment, as it
 478         was causing timeouts on the buildbot.
 479
 480         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 481         (LayoutTestController::notifyDone):
 482
 483 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 484
 485         Reviewed by Oliver Hunt.
 486
 487         Make the timeout 15 sec as for the other DRT's and make
 488         it print out the same output when a test timeout.
 489
 490         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 491         (LayoutTestController::waitUntilDone):
 492         (LayoutTestController::notifyDone):
 493         (LayoutTestController::timerEvent):
 494
 495 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
 496
 497         Reviewed by Timothy Hatcher.
 498
 499         Fixed typos in comments.
 500
 501         * Scripts/modules/committers.py:
 502
 503 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
 504
 505         Reviewed by Timothy Hatcher.
 506
 507         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
 508         - Updated DRT to show/close inspector for all tests under /inspector
 509         - Introduced LayoutTestController::setTimelineProfilingEnabled and
 510           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
 511         - Removed reload on each inspector test
 512         - Renamed fast/inspector to fast/inspector-support in order not to trigger
 513         inspector for those.
 514         - Reimplemented timeline tests in order to get rid of reload there.
 515         - Moved tests that don't require harness into the fast group.
 516
 517         https://bugs.webkit.org/show_bug.cgi?id=31472
 518
 519         * DumpRenderTree/LayoutTestController.cpp:
 520         (setTimelineProfilingEnabledCallback):
 521         (closeWebInspectorCallback):
 522         (LayoutTestController::staticFunctions):
 523         * DumpRenderTree/LayoutTestController.h:
 524         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 525         (shouldOpenWebInspector):
 526         (runTest):
 527         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 528         (LayoutTestController::setTimelineProfilingEnabled):
 529         * DumpRenderTree/mac/DumpRenderTree.mm:
 530         (shouldOpenWebInspector):
 531         (runTest):
 532         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 533         (LayoutTestController::setTimelineProfilingEnabled):
 534         * DumpRenderTree/win/DumpRenderTree.cpp:
 535         (shouldOpenWebInspector):
 536         (runTest):
 537         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 538         (LayoutTestController::setTimelineProfilingEnabled):
 539
 540 2009-11-17  Oliver Hunt  <oliver@apple.com>
 541
 542         Reviewed by Maciej Stachowiak.
 543
 544         Incorrect use of JavaScriptCore API in DumpRenderTree
 545         https://bugs.webkit.org/show_bug.cgi?id=31577
 546
 547         Return undefined rather than a literal null.
 548
 549         * DumpRenderTree/AccessibilityUIElement.cpp:
 550         (setSelectedTextRangeCallback):
 551         (incrementCallback):
 552         (decrementCallback):
 553         (showMenuCallback):
 554
 555 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
 556
 557         Reviewed by Beth Dakin.
 558
 559         AX: aria-labelledby duplicates some of its WAI-ARIA label
 560         https://bugs.webkit.org/show_bug.cgi?id=31565
 561
 562         * DumpRenderTree/AccessibilityUIElement.cpp:
 563         (titleUIElementCallback):
 564         (getIsValidCallback):
 565         (AccessibilityUIElement::getJSClass):
 566
 567 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 568
 569         Reviewed by Simon Hausmann.
 570
 571         r50942 broke output from created windows. Make the
 572         m_enableTextOutput a member of the DRT and not the
 573         WebPage.
 574
 575         * DumpRenderTree/qt/DumpRenderTree.cpp:
 576         (WebCore::WebPage::WebPage):
 577         (WebCore::WebPage::javaScriptAlert):
 578         (WebCore::WebPage::javaScriptConsoleMessage):
 579         (WebCore::WebPage::javaScriptConfirm):
 580         (WebCore::WebPage::javaScriptPrompt):
 581         (WebCore::WebPage::acceptNavigationRequest):
 582         (WebCore::DumpRenderTree::DumpRenderTree):
 583         (WebCore::DumpRenderTree::open):
 584         (WebCore::DumpRenderTree::createWindow):
 585         * DumpRenderTree/qt/DumpRenderTree.h:
 586         (WebCore::DumpRenderTree::setTextOutputEnabled):
 587         (WebCore::DumpRenderTree::isTextOutputEnabled):
 588         (WebCore::WebPage::shouldInterruptJavaScript):
 589         (WebCore::WebPage::isTextOutputEnabled):
 590         (WebCore::WebPage::setViewGeometry):
 591
 592 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 593
 594         Reviewed by Gustavo Noronha Silva.
 595
 596         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
 597         as the implementation is being used by at least Qt and Gtk+.
 598
 599         Update buildsystems as well.
 600
 601         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
 602         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
 603         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
 604         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
 605         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
 606         * GNUmakefile.am:
 607
 608 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
 609
 610         Reviewed by Alexey Proskuryakov.
 611
 612         Disable wss until all platforms support pyOpenSSL
 613
 614         https://bugs.webkit.org/show_bug.cgi?id=31479
 615
 616         * Scripts/run-webkit-tests:
 617
 618 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
 619
 620         Reviewed by Kenneth Christiansen.
 621
 622         [Qt] Implement load error pages support for Qt's DRT.
 623         https://bugs.webkit.org/show_bug.cgi?id=31509
 624
 625         For now, it will not be a default feature, and layout tests
 626         that want to make use of this have to explicitily call
 627         'handleErrorPages();' for the test source.
 628
 629         Any of the other DumpRenderTree's (mac, win and gtk)
 630         support handling error pages. Qt's will be the first.
 631
 632         * DumpRenderTree/qt/DumpRenderTree.cpp:
 633         (WebCore::WebPage::supportsExtension):
 634         (WebCore::WebPage::extension):
 635         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 636         (LayoutTestController::reset):
 637         * DumpRenderTree/qt/LayoutTestControllerQt.h:
 638         (LayoutTestController::shouldHandleErrorPages):
 639         (LayoutTestController::handleErrorPages):
 640
 641 2009-11-16  Eric Seidel  <eric@webkit.org>
 642
 643         Reviewed by Adam Barth.
 644
 645         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
 646         https://bugs.webkit.org/show_bug.cgi?id=31549
 647
 648         Renamed --commit-queue to --non-interactive in most places
 649         and remove the code in land-patches which is no longer needed.
 650
 651         * Scripts/bugzilla-tool:
 652
 653 2009-11-16  Eric Seidel  <eric@webkit.org>
 654
 655         Reviewed by Adam Barth.
 656
 657         The commit-queue should use land-attachment
 658         https://bugs.webkit.org/show_bug.cgi?id=31548
 659
 660         * Scripts/bugzilla-tool:
 661
 662 2009-11-16  Adam Barth  <abarth@webkit.org>
 663
 664         Reviewed by Eric Seidel.
 665
 666         Convert CommitQueue over to PatchCollection
 667         https://bugs.webkit.org/show_bug.cgi?id=31547
 668
 669         Also fixes a bug in workqueue and adds a test!
 670
 671         * Scripts/bugzilla-tool:
 672         * Scripts/modules/workqueue.py:
 673         * Scripts/modules/workqueue_unittest.py:
 674
 675 2009-11-16  Adam Barth  <abarth@webkit.org>
 676
 677         Reviewed by Eric Seidel.
 678
 679         Move StyleQueue over to using PatchCollection
 680         https://bugs.webkit.org/show_bug.cgi?id=31544
 681
 682         That's what the class it's for.
 683
 684         * Scripts/bugzilla-tool:
 685         * Scripts/modules/patchcollection.py:
 686         * Scripts/modules/patchcollection_unittest.py:
 687
 688 2009-11-16  Eric Seidel  <eric@webkit.org>
 689
 690         Reviewed by Adam Barth.
 691
 692         bugzilla-tool needs a land-attachment command
 693         https://bugs.webkit.org/show_bug.cgi?id=31546
 694
 695         * Scripts/bugzilla-tool:
 696          - Move all the logic into AbstractLandingCommand and
 697            add a new LandAttachment command subclass.
 698          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
 699
 700 2009-11-16  Eric Seidel  <eric@webkit.org>
 701
 702         Reviewed by Adam Barth.
 703
 704         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
 705         https://bugs.webkit.org/show_bug.cgi?id=31543
 706
 707         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
 708
 709         * Scripts/bugzilla-tool:
 710
 711 2009-11-16  Eric Seidel  <eric@webkit.org>
 712
 713         Reviewed by Adam Barth.
 714
 715         Disable the style queue from posting to the commit queue status page.
 716
 717         * Scripts/bugzilla-tool:
 718
 719 2009-11-16  Adam Barth  <abarth@webkit.org>
 720
 721         Reviewed by Eric Seidel.
 722
 723         Implement PatchCollection
 724         https://bugs.webkit.org/show_bug.cgi?id=31541
 725
 726         This class holds a set of patches and lets clients iterate through
 727         them.  Optionally, clients can install a filter.
 728
 729         * Scripts/modules/patchcollection.py: Added.
 730         * Scripts/modules/patchcollection_unittest.py: Added.
 731         * Scripts/run-webkit-unittests:
 732
 733 2009-11-16  Eric Seidel  <eric@webkit.org>
 734
 735         Reviewed by Adam Barth.
 736
 737         bugzilla-tool land-patches will close bugs with patches r=?
 738         https://bugs.webkit.org/show_bug.cgi?id=28230
 739
 740         The commit-queue shouldn't close patches with outstanding reviews on them,
 741         even if many reviewers seem to be against multi-patch bugs.
 742
 743         * Scripts/bugzilla-tool:
 744
 745 2009-11-16  Eric Seidel  <eric@webkit.org>
 746
 747         Reviewed by Adam Barth.
 748
 749         bugzilla-tool check-style should work with attachment ids instead of bug ids
 750         https://bugs.webkit.org/show_bug.cgi?id=31540
 751
 752         * Scripts/bugzilla-tool:
 753
 754 2009-11-16  Eric Seidel  <eric@webkit.org>
 755
 756         Reviewed by Adam Barth.
 757
 758         WorkQueue is the only place that should know about special exit codes
 759         https://bugs.webkit.org/show_bug.cgi?id=31534
 760
 761         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
 762         and add tests for handling exit codes.
 763         I also cleaned up workqueue_unittest.py more.
 764
 765         * Scripts/bugzilla-tool:
 766         * Scripts/modules/workqueue.py:
 767         * Scripts/modules/workqueue_unittest.py:
 768
 769 2009-11-16  Eric Seidel  <eric@webkit.org>
 770
 771         Reviewed by Adam Barth.
 772
 773         Re-factor workqueue_unittest to allow for more than one test.
 774         https://bugs.webkit.org/show_bug.cgi?id=31535
 775
 776         * Scripts/modules/workqueue_unittest.py:
 777
 778 2009-11-16  Eric Seidel  <eric@webkit.org>
 779
 780         Reviewed by Adam Barth.
 781
 782         land-patches needs to be re-factored into smaller chunks
 783         https://bugs.webkit.org/show_bug.cgi?id=31532
 784
 785         * Scripts/bugzilla-tool: fix a couple obvious typos.
 786
 787 2009-11-16  Eric Seidel  <eric@webkit.org>
 788
 789         Reviewed by Adam Barth.
 790
 791         land-patches needs to be re-factored into smaller chunks
 792         https://bugs.webkit.org/show_bug.cgi?id=31532
 793
 794         The next patch will move these methods into WebKitLandingScripts.
 795
 796         * Scripts/bugzilla-tool:
 797          - Split out _land_patch and _close_bug_if_no_active_patches.
 798
 799 2009-11-16  Adam Barth  <abarth@webkit.org>
 800
 801         Reviewed by Eric Seidel.
 802
 803         Fix silly copy-and-paste code.  I am a terrible coder.
 804
 805         * Scripts/modules/bugzilla.py:
 806
 807 2009-11-16  Adam Barth  <abarth@webkit.org>
 808
 809         Reviewed by Eric Seidel.
 810
 811         Implement a StyleQueue
 812         https://bugs.webkit.org/show_bug.cgi?id=31537
 813
 814         The first iteration of the style queue only produces output locally.
 815         There is also a limit of 10 patches because it's not that useful to
 816         iterate through the entire review queue at this point.  We can remove
 817         the limit later.
 818
 819         * Scripts/bugzilla-tool:
 820         * Scripts/modules/bugzilla.py:
 821
 822 2009-11-16  Adam Barth  <abarth@webkit.org>
 823
 824         Reviewed by Eric Seidel.
 825
 826         Unit test WorkQueue
 827         https://bugs.webkit.org/show_bug.cgi?id=31531
 828
 829         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
 830
 831         * Scripts/bugzilla-tool:
 832         * Scripts/modules/statusbot.py:
 833         * Scripts/modules/workqueue.py:
 834         * Scripts/modules/workqueue_unittest.py: Added.
 835         * Scripts/run-webkit-unittests:
 836
 837 2009-11-16  Eric Seidel  <eric@webkit.org>
 838
 839         Reviewed by Adam Barth.
 840
 841         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
 842         https://bugs.webkit.org/show_bug.cgi?id=31530
 843
 844         * Scripts/bugzilla-tool:
 845
 846 2009-11-16  Eric Seidel  <eric@webkit.org>
 847
 848         Reviewed by Adam Barth.
 849
 850         bugzilla-tool needs apply-attachment
 851         https://bugs.webkit.org/show_bug.cgi?id=31528
 852
 853         * Scripts/bugzilla-tool:
 854          - Add ApplyAttachment command.
 855          - Abstract applying code into WebKitApplyingScripts.
 856          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
 857         * Scripts/modules/bugzilla.py:
 858          - Add fetch_attachment and bug_id_for_attachment_id.
 859         * Scripts/modules/bugzilla_unittest.py:
 860          - Add test for new parsing.
 861          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
 862
 863 2009-11-16  Eric Seidel  <eric@webkit.org>
 864
 865         Reviewed by Adam Barth.
 866
 867         Document check-style's use of force_clean.
 868
 869         * Scripts/bugzilla-tool:
 870         * Scripts/modules/scm.py:
 871
 872 2009-11-16  Adam Barth  <abarth@webkit.org>
 873
 874         Reviewed by Eric Seidel.
 875
 876         Move WorkQueue to its own file
 877         https://bugs.webkit.org/show_bug.cgi?id=31529
 878
 879         WorkQueue and WorkQueueDelegate are separate concerns from
 880         bugzilla-tool.  Also added a missing include to logging.py.
 881
 882         * Scripts/bugzilla-tool:
 883         * Scripts/modules/logging.py:
 884         * Scripts/modules/workqueue.py:
 885
 886 2009-11-16  Adam Barth  <abarth@webkit.org>
 887
 888         Reviewed by Eric Seidel.
 889
 890         Move OutputTee to logging.py.
 891
 892         * Scripts/bugzilla-tool:
 893         * Scripts/modules/logging.py:
 894
 895 2009-11-15  Adam Barth  <abarth@webkit.org>
 896
 897         Reviewed by Eric Seidel.
 898
 899         Refactor bugzilla-tool to allow for multiple queues
 900         https://bugs.webkit.org/show_bug.cgi?id=31513
 901
 902         Divide the commit queue class into three class to make creating
 903         additional queues easier.
 904
 905         * Scripts/bugzilla-tool:
 906
 907 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
 908
 909         Reviewed by Eric Seidel.
 910
 911         svn-apply may not handle git patches created by bugzilla-tool
 912         https://bugs.webkit.org/show_bug.cgi?id=31457
 913
 914         * Scripts/modules/scm.py:
 915         * Scripts/modules/scm_unittest.py:
 916
 917 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
 918
 919         Reviewed by Eric Seidel.
 920
 921         bugzilla-tool should post git binary diff
 922         https://bugs.webkit.org/show_bug.cgi?id=31458
 923
 924         Add --binary option to Git.create_patch.
 925
 926         * Scripts/modules/scm.py:
 927         * Scripts/modules/scm_unittest.py:
 928
 929 2009-11-15  Adam Barth  <abarth@webkit.org>
 930
 931         Reviewed by Darin Adler.
 932
 933         Add bugzilla-tool check-style
 934         https://bugs.webkit.org/show_bug.cgi?id=31515
 935
 936         * Scripts/bugzilla-tool:
 937         * Scripts/modules/bugzilla.py:
 938
 939 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 940
 941         Reviewed by Simon Hausmann.
 942
 943         Make the Qt Linux only --valgrind feature, suppress errors
 944         defined in the SuppressedValgrindErrors file.
 945
 946         * Scripts/run-webkit-tests:
 947
 948 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 949
 950         Reviewed by Simon Hausmann.
 951
 952         Set the locale to C and not to the current one in use on the system.
 953
 954         * DumpRenderTree/qt/DumpRenderTree.cpp:
 955         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
 956
 957 2009-11-13  Adam Roben  <aroben@apple.com>
 958
 959         Add support for
 960         http/tests/security/isolatedWorld/didClearWindowObject.html
 961
 962         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
 963         window objects in isolated worlds are cleared
 964
 965         Reviewed by Dave Hyatt.
 966
 967         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
 968
 969         * DumpRenderTree/mac/FrameLoadDelegate.mm:
 970         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
 971         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
 972         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
 973         Added. Sets a __worldID property on the global object whose value is
 974         the ID of this world.
 975         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
 976         Respond to this new delegate callback by calling through to one of the
 977         above new methods.
 978         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 979         (worldMap): Added. Returns a HashMap containing all the worlds we've
 980         created.
 981         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
 982         haven't kept track of this world.
 983         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
 984         instead of declaring our own.
 985
 986         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
 987
 988         * DumpRenderTree/win/FrameLoadDelegate.cpp:
 989         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
 990         didClearWindowObjectForFrameInStandardWorld.
 991         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
 992         Respond to this new delegate callback by calling through to one of the
 993         below new methods.
 994         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
 995         Added. Sets a __worldID property on the gobal object whose value is
 996         the ID of this world.
 997         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
 998         Added. Moved code here from didClearWindowObject.
 999
1000         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
1001         didClearWindowObjectForFrame* functions.
1002
1003         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1004         (worldMap): Added. Returns a HashMap containing all the worlds we've
1005         created.
1006         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
1007         haven't kept track of this world.
1008         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1009         instead of declaring our own.
1010
1011 2009-11-13  Adam Roben  <aroben@apple.com>
1012
1013         Finish replacing worldIDs with world objects
1014
1015         The only remaining use of worldIDs was in a method only used by DRT
1016         for the isolated worlds tests.
1017
1018         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
1019
1020         Reviewed by Mark Rowe.
1021
1022         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1023         (LayoutTestController::evaluateScriptInIsolatedWorld):
1024         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1025         (LayoutTestController::evaluateScriptInIsolatedWorld):
1026         Updated for changes to WebFrame. Now holds the map of worldID -> world
1027         at this level instead of making WebKit do it.
1028
1029 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1030
1031         Reviewed by Simon Hausmann.
1032
1033         [Qt] Ensure the DRT does not output anything until first test is run
1034
1035         * DumpRenderTree/qt/DumpRenderTree.cpp:
1036         * DumpRenderTree/qt/DumpRenderTree.h:
1037
1038 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1039
1040         Reviewed by Tor Arne Vestbø.
1041
1042         Clear the undo stack in before each new test run.
1043
1044         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
1045
1046         * DumpRenderTree/qt/DumpRenderTree.cpp:
1047         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1048
1049 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1050
1051         Reviewed by Kenneth Rohde Christiansen.
1052
1053         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
1054
1055         * DumpRenderTree/qt/DumpRenderTree.cpp:
1056         (WebCore::WebPage::resetSettings):
1057         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1058         (LayoutTestController::overridePreference):
1059
1060 2009-11-13  Eric Seidel  <eric@webkit.org>
1061
1062         Reviewed by Adam Barth.
1063
1064         Update committers.py based on svn records
1065         https://bugs.webkit.org/show_bug.cgi?id=31366
1066
1067         This list was generated using validate-committer-lists from
1068         https://bugs.webkit.org/show_bug.cgi?id=30970
1069         and makes committers.py current for committers who have
1070         committed in the last 3 years.
1071
1072         * Scripts/modules/committers.py:
1073
1074 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
1075
1076         Reviewed by Adam Barth.
1077
1078         The document-open.html test was flaky at times. The test invokes the layout test plugin
1079         which in its destroy stream handler opens a new document. This basically tears down the
1080         stream and the associated plugin instance. The pluginLog function in the layout test
1081         plugin attempts to retrieve the window script object on a torn down plugin instance
1082         which crashed consistently on windows in the debugger. The functions which issue
1083         these logs already have a valid window script object. We now have variants of the pluginLog
1084         function which take in a window script object with and without variable arguments.
1085
1086         https://bugs.webkit.org/show_bug.cgi?id=31067
1087
1088         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1089         (pluginLogWithWindowObject):
1090         (pluginLogWithWindowObjectVariableArgs):
1091         (pluginLog):
1092         (notifyTestCompletion):
1093         (testDocumentOpen):
1094         (testWindowOpen):
1095
1096 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1097
1098         Reviewed by Gustavo Noronha Silva.
1099
1100         https://bugs.webkit.org/show_bug.cgi?id=30997
1101         [Gtk] Implemment AtkDocument
1102
1103         Added testing support.
1104
1105         * DumpRenderTree/AccessibilityUIElement.cpp:
1106         * DumpRenderTree/AccessibilityUIElement.h:
1107         (getDocumentEncodingCallback):
1108         (getDocumentURICallback):
1109         (AccessibilityUIElement::getJSClass):
1110         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1111         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1112         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1113         (AccessibilityUIElement::documentEncoding):
1114         (AccessibilityUIElement::documentURI):
1115
1116 2009-11-12  Adam Roben  <aroben@apple.com>
1117
1118         Replace worldIDs with world objects
1119
1120         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
1121         user scripts/stylesheets and isolated worlds
1122
1123         Reviewed by Sam Weinig.
1124
1125         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1126         (LayoutTestController::addUserScript):
1127         (LayoutTestController::addUserStyleSheet):
1128         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1129         (LayoutTestController::addUserScript):
1130         (LayoutTestController::addUserStyleSheet):
1131         Changed these functions to create a new WebJSWorld each time they're
1132         called and to pass that world to WebKit.
1133
1134 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
1135
1136         Reviewed by Oliver Hunt.
1137
1138         need to implement aria tree roles
1139         https://bugs.webkit.org/show_bug.cgi?id=31284
1140
1141         * DumpRenderTree/AccessibilityUIElement.cpp:
1142         (disclosedRowAtIndexCallback):
1143         (selectedRowAtIndexCallback):
1144         (isEqualCallback):
1145         (isAttributeSettableCallback):
1146         (isActionSupportedCallback):
1147         (disclosedByRowCallback):
1148         (hierarchicalLevelCallback):
1149         (AccessibilityUIElement::getJSClass):
1150         * DumpRenderTree/AccessibilityUIElement.h:
1151         (AccessibilityUIElement::isEqual):
1152         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1153         (AccessibilityUIElement::hierarchicalLevel):
1154         (AccessibilityUIElement::disclosedRowAtIndex):
1155         (AccessibilityUIElement::selectedRowAtIndex):
1156         (AccessibilityUIElement::disclosedByRow):
1157         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1158         (AccessibilityUIElement::getChildAtIndex):
1159         (AccessibilityUIElement::disclosedRowAtIndex):
1160         (AccessibilityUIElement::selectedRowAtIndex):
1161         (AccessibilityUIElement::titleUIElement):
1162         (AccessibilityUIElement::parentElement):
1163         (AccessibilityUIElement::disclosedByRow):
1164         (AccessibilityUIElement::hierarchicalLevel):
1165         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1166         (AccessibilityUIElement::hierarchicalLevel):
1167         (AccessibilityUIElement::disclosedRowAtIndex):
1168         (AccessibilityUIElement::selectedRowAtIndex):
1169         (AccessibilityUIElement::disclosedByRow):
1170
1171 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
1172
1173         Reviewed by Darin Adler.
1174
1175         svn-apply can not handle git binary diffs
1176         https://bugs.webkit.org/show_bug.cgi?id=26830
1177
1178         Support "literal" type git binary diffs.
1179
1180         * Scripts/VCSUtils.pm:
1181         * Scripts/modules/scm_unittest.py:
1182         * Scripts/svn-apply:
1183
1184 2009-11-11  Dmitry Titov  <dimich@chromium.org>
1185
1186         Not reviewed, removing duplicate entry for myself in committers.py.
1187
1188         * Scripts/modules/committers.py:
1189
1190 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
1191
1192         Reviewed by Darin Adler and Mark Rowe.
1193
1194         https://bugs.webkit.org/show_bug.cgi?id=31200
1195         Tests in http/tests/security/mixedContent start to fail when new tests are added
1196
1197         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
1198
1199 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1200
1201         Reviewed by Jan Alonzo.
1202
1203         Create, and display a window for the inspector, for inspector
1204         tests.
1205
1206         Need to also show/hide the inspector window to avoid having
1207         problems with code assuming it is realized
1208         https://bugs.webkit.org/show_bug.cgi?id=31347
1209
1210         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1211         (webInspectorShowWindow):
1212         (webInspectorCloseWindow):
1213         (webInspectorInspectWebView):
1214         (createWebView):
1215
1216 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1217
1218         Unreviewed Qt buildbot fix.
1219
1220         My previous fix was wrong, so revert that change and fix it by
1221         returning when the document of the frame has no document element.
1222         Idea is borrowed from mac and win DRT.
1223
1224         * DumpRenderTree/qt/DumpRenderTree.cpp:
1225         (WebCore::DumpRenderTree::dumpFramesAsText):
1226
1227 2009-11-11  Eric Seidel  <eric@webkit.org>
1228
1229         Reviewed byg Kenneth Rohde Christiansen.
1230
1231         Update Kenneth's committer record to include the email he
1232         uses on lists.webkit.org.
1233
1234         * Scripts/modules/committers.py:
1235
1236 2009-11-11  Eric Seidel  <eric@webkit.org>
1237
1238         Reviewed by Gustavo Noronha Silva.
1239
1240         Several committers use separate email addresses for bugzilla and svn.webkit.org
1241         https://bugs.webkit.org/show_bug.cgi?id=31364
1242
1243         Update records for existing committers to include email addresses
1244         used in svn.webkit.org and lists.webkit.org.
1245         Most committers use the same email address in all 3 places, but some use
1246         separate addresses.  committers.py needs record of each of these addresses.
1247
1248         * Scripts/modules/committers.py:
1249
1250 2009-11-11  Eric Seidel  <eric@webkit.org>
1251
1252         No review, adding second email address for an existing committer.
1253
1254         Add Yong Li's second bugzilla account to his committer record.
1255         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
1256
1257         * Scripts/modules/committers.py:
1258
1259 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1260
1261         Reviewed by Simon Hausmann.
1262
1263         If the frame has no innerText don't append it, and
1264         do not add a newline which breaks some cross platform
1265         results.
1266
1267         * DumpRenderTree/qt/DumpRenderTree.cpp:
1268         (WebCore::DumpRenderTree::dumpFramesAsText):
1269
1270 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1271
1272         Reviewed by Simon Hausmann.
1273
1274         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
1275
1276         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1277         (webkit_test_plugin_new_instance):
1278         (webkit_test_plugin_destroy_instance):
1279         (webkit_test_plugin_destroy_stream):
1280
1281 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1282
1283         Reviewed by Mark Rowe.
1284
1285         Implement the functionality needed by plugins/window-open.html
1286
1287         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1288         (webkit_test_plugin_new_instance):
1289         (webkit_test_plugin_set_window):
1290
1291 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1292
1293         Reviewed by Simon Hausmann.
1294
1295         [Qt] Force -graphicssystem raster and -style windows when running DRT
1296
1297         * DumpRenderTree/qt/main.cpp:
1298         * Scripts/run-webkit-tests:
1299
1300 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1301
1302         Reviewed by Simon Hausmann.
1303
1304         Compute correct library paths for Qt
1305
1306         * Scripts/webkitdirs.pm:
1307
1308 2009-11-10  Mark Rowe  <mrowe@apple.com>
1309
1310         Reviewed by Sam Weinig.
1311
1312         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
1313
1314         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
1315         about the validity of the self-signed certificates used in the regression tests.  We would then add the
1316         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
1317         that had enabled frame load delegate logging this would result in extra log messages being generated,
1318         causing the test to fail.
1319
1320         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
1321         tests.
1322
1323         * DumpRenderTree/mac/DumpRenderTree.mm:
1324         (dumpRenderTree):
1325         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1326         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1327
1328 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1329
1330         Reviewed by Kenneth Rohde Christiansen.
1331
1332         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
1333
1334         * DumpRenderTree/qt/DumpRenderTree.cpp:
1335         (WebCore::DumpRenderTree::DumpRenderTree):
1336
1337 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1338
1339         Reviewed by Jan Alonzo.
1340
1341         [GTK] Remove WebSocket configuration from WebKitWebSettings
1342         https://bugs.webkit.org/show_bug.cgi?id=31244
1343
1344         Follow-up of r50724. Don't set the enable-web-socket property
1345         anymore.
1346
1347         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1348         (resetDefaultsToConsistentValues):
1349
1350 2009-11-10  Oliver Hunt  <oliver@apple.com>
1351
1352         Reviewed by Maciej Stachowiak.
1353
1354         Rename 3D Canvas related classes to use WebGL prefix
1355         https://bugs.webkit.org/show_bug.cgi?id=29095
1356
1357         Checkin new version of do-webcore-rename used to do the WebGL type rename,
1358         and upate webkitdirs script to new method of testing for WebGL.
1359
1360         * Scripts/do-webcore-rename:
1361         * Scripts/webkitdirs.pm:
1362
1363 2009-11-09  Oliver Hunt  <oliver@apple.com>
1364
1365         Reviewed by Geoff Garen.
1366
1367         Make do-webcore-rename work with git.
1368
1369         * Scripts/do-webcore-rename:
1370
1371 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
1372
1373         Adding Kenneth to the reviewers list.
1374
1375         * Scripts/modules/committers.py:
1376
1377 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1378
1379         Reviewed by Jan Alonzo.
1380
1381         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
1382         https://bugs.webkit.org/show_bug.cgi?id=30482
1383
1384         LayoutTestControllerGtk now uses the exposed
1385         Page::tabKeyCyclesThroughElements API
1386
1387         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1388         (LayoutTestController::setTabKeyCyclesThroughElements):
1389
1390 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
1391
1392         Reviewed by Holger Freyther.
1393
1394         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
1395         This helps to pass the test case below. Also replaced hardcoded
1396         code numbers with defined constants.
1397         https://bugs.webkit.org/show_bug.cgi?id=31185
1398
1399         Test: editing/undo/undo-deleteWord.html
1400
1401         * DumpRenderTree/qt/EventSenderQt.cpp:
1402         (EventSender::keyDown):
1403
1404 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
1405
1406         Reviewed by Holger Freyther.
1407
1408         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
1409         https://bugs.webkit.org/show_bug.cgi?id=31164
1410
1411         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
1412
1413         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1414         (LayoutTestController::processWork):
1415
1416 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
1417
1418         Reviewed by Holger Freyther.
1419
1420         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
1421         https://bugs.webkit.org/show_bug.cgi?id=31158
1422
1423         By invoking a script queue'd by queueScript(), 'true' was beeing returned
1424         always, which from WorkQueue prospective means that a load has been started
1425         and the queue processing should stop and wait for the load to finish.
1426         Spinning it off into a loading and a non-loading variants was the solution
1427         adopted by Mac's DRT to work around this problem. The former keeps returning
1428         'true' while the later executes the script synchronously and returns 'false'
1429         making it possible to the WorkQueue to proceed right away.
1430
1431         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1432         (LayoutTestController::processWork):
1433         (LayoutTestController::queueLoadingScript):
1434         (LayoutTestController::queueNonLoadingScript):
1435         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1436         * DumpRenderTree/qt/WorkQueueItem.h:
1437         (LoadingScriptItem::LoadingScriptItem):
1438         (LoadingScriptItem::invoke):
1439         (NonLoadingScriptItem::NonLoadingScriptItem):
1440         (NonLoadingScriptItem::invoke):
1441
1442 2009-11-07  Mark Rowe  <mrowe@apple.com>
1443
1444         Rubber-stamped by Cameron Zwarich.
1445
1446         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
1447
1448         * Scripts/commit-log-editor:
1449
1450 2009-11-07  Mark Rowe  <mrowe@apple.com>
1451
1452         Reviewed by Darin Adler.
1453
1454         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
1455         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
1456
1457         Move logic for determining the name and email address to use in a ChangeLog entry from
1458         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
1459         whether the author of the patch matches committer, and therefore needs access to the
1460         email address that would be used in a ChangeLog entry.
1461
1462         Based on a patch by Pierre d'Herbemont.
1463
1464         * Scripts/VCSUtils.pm:
1465         * Scripts/commit-log-editor:
1466         * Scripts/prepare-ChangeLog:
1467         * Scripts/webkitdirs.pm:
1468
1469 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
1470
1471         Reviewed by Adam Barth.
1472
1473         Added functionality to the layout test plugin to invoke document.open and
1474         window.open with default arguments. The associated webkit bug is
1475         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
1476         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
1477         work in Chromium (V8) if there is no calling javascript context. To achieve this
1478         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
1479         for the window.open test case and in NPP_DestroyStream for the document.open test case.
1480
1481         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1482         (testDocumentOpen):
1483         (testWindowOpen):
1484         (pluginAllocate):
1485         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1486         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1487         (NPP_New):
1488         (NPP_SetWindow):
1489         (NPP_DestroyStream):
1490         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1491         (NPP_New):
1492         (NPP_SetWindow):
1493         (NPP_NewStream):
1494         (NPP_DestroyStream):
1495
1496 2009-11-06  Eric Seidel  <eric@webkit.org>
1497
1498         Reviewed by Adam Barth.
1499
1500         bugzilla-tool crashed with exception
1501         https://bugs.webkit.org/show_bug.cgi?id=31092
1502
1503         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
1504
1505 2009-11-04  Eric Seidel  <eric@webkit.org>
1506
1507         No review, just add a line which got left out of the patch uploaded for commit.
1508
1509         commit-queue is crashing when trying to reject patches after unknown failures
1510         https://bugs.webkit.org/show_bug.cgi?id=31091
1511
1512         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
1513
1514 2009-11-04  Adam Roben  <aroben@apple.com>
1515
1516         Remove bogus else clause in bugzilla-tool
1517
1518         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
1519         create-bug raises exception after entering bug description
1520
1521         Reviewed by David Kilzer.
1522
1523         * Scripts/bugzilla-tool:
1524         (CreateBug): else clauses are only hit if no exception is raised, so
1525         it makes no sense to try to re-raise the exception in an else clause.
1526         The exception will automatically be re-raised if it doesn't match any
1527         of the except clauses, so we don't have to do anything special here at
1528         all to get the desired behavior.
1529
1530 2009-11-04  Eric Seidel  <eric@webkit.org>
1531
1532         Reviewed by David Kilzer.
1533
1534         svn-apply's fixChangeLogPatch function seems broken
1535         https://bugs.webkit.org/show_bug.cgi?id=30683
1536
1537         Update fixChangeLogPatch to be able to handle patches which
1538         don't start at line 1.
1539         Add unit tests for svn-apply to scm_unittest.py.
1540
1541         * Scripts/VCSUtils.pm:
1542         * Scripts/modules/scm_unittest.py:
1543
1544 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
1545
1546         Reviewed by Beth Dakin.
1547
1548         Need to implement ARIA role="combobox"
1549         https://bugs.webkit.org/show_bug.cgi?id=31096
1550
1551         * DumpRenderTree/AccessibilityUIElement.cpp:
1552         (showMenuCallback):
1553         (getIsExpandedCallback):
1554         (AccessibilityUIElement::getJSClass):
1555         * DumpRenderTree/AccessibilityUIElement.h:
1556         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1557         (AccessibilityUIElement::isExpanded):
1558         (AccessibilityUIElement::showMenu):
1559         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1560         (AccessibilityUIElement::isExpanded):
1561         (AccessibilityUIElement::showMenu):
1562         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1563         (AccessibilityUIElement::isSelected):
1564         (AccessibilityUIElement::isExpanded):
1565         (AccessibilityUIElement::showMenu):
1566
1567 2009-11-04  Eric Seidel  <eric@webkit.org>
1568
1569         Reviewed by Adam Barth.
1570
1571         commit-queue is crashing when trying to reject patches after unknown failures
1572         https://bugs.webkit.org/show_bug.cgi?id=31091
1573
1574         * Scripts/bugzilla-tool:
1575          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
1576            so we have to find out what the current patch is by asking bugzilla again.
1577          - Discovered that this code was also leaking file descriptors, so fixed that.
1578
1579 2009-11-04  Adam Roben  <aroben@apple.com>
1580
1581         Make run-webkit-tests work for the Debug_Internal Windows
1582         configuration
1583
1584         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
1585         suffix.
1586
1587         Fixes <http://webkit.org/b/31123>.
1588
1589         Reviewed by Sam Weinig.
1590
1591         * Scripts/run-webkit-tests: Don't add the _debug suffix in
1592         Debug_Internal, either.
1593
1594 2009-11-04  Eric Seidel  <eric@webkit.org>
1595
1596         Reviewed by Adam Barth.
1597
1598         committers.py needs a way to store non-bugzilla email addresses
1599         https://bugs.webkit.org/show_bug.cgi?id=31037
1600
1601         Make Committer and Reviewer constructors take a single email or a list of emails.
1602         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
1603         Expose reviewers(), used by validate-committer-lists on bug 30970.
1604
1605         * Scripts/modules/committers.py:
1606         * Scripts/modules/committers_unittest.py: Added tests for the new code.
1607
1608 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
1609
1610         Reviewed by David Levin.
1611
1612         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
1613         https://bugs.webkit.org/show_bug.cgi?id=27491
1614
1615         The test path determination logic is changed to handle websocket and websocket/ssl cases.
1616         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
1617
1618         Functions to start or stop Web Socket servers are added.
1619
1620         * Scripts/run-webkit-tests:
1621
1622 2009-11-03  Eric Seidel  <eric@webkit.org>
1623
1624         No review, just changing wording of log message.
1625
1626         Change log string to say "failed" instead of "rejected"
1627         when a commit fails due to an out of date checkout.
1628         This makes grepping the commit-queue log for rejected patches easier.
1629
1630         * Scripts/bugzilla-tool:
1631
1632 2009-11-03  Eric Seidel  <eric@webkit.org>
1633
1634         No review, adding commonly known committers missing from the file.
1635
1636         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
1637
1638 2009-11-03  Eric Seidel  <eric@webkit.org>
1639
1640         No review, just sort-order cleanup.
1641
1642         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
1643
1644 2009-11-03  Stephen White  <senorblanco@chromium.org>
1645
1646         (Unreviewed).
1647
1648         Add myself to committers.py.
1649
1650         * Scripts/modules/committers.py:
1651
1652 2009-11-03  Robin Dunn  <robin@alldunn.com>
1653
1654         Reviewed by Kevin Ollviier.
1655
1656         Add packaging scripts for Debian-based Linux distros.
1657
1658         https://bugs.webkit.org/show_bug.cgi?id=31075
1659
1660         * wx/packaging/build-debian-installer.py: Added.
1661         * wx/packaging/debian: Added.
1662
1663 2009-11-03  Dan Bernstein  <mitz@apple.com>
1664
1665         Reviewed by Anders Carlsson and Beth Dakin.
1666
1667         https://bugs.webkit.org/show_bug.cgi?id=31070
1668
1669         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
1670         destroyed, it executes the value of the 'ondestroy' parameter as a
1671         script.
1672
1673         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1674         (pluginAllocate): Initialize onDestroy.
1675         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
1676         onDestroy.
1677         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1678         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
1679         specified.
1680         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
1681
1682 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1683
1684         Reviewed by Xan Lopez.
1685
1686         https://bugs.webkit.org/show_bug.cgi?id=31035
1687         [GTK] some accessibility tests hitting assertion in debug builds
1688
1689         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
1690
1691         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1692         (AccessibilityController::rootElement):
1693
1694 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
1695
1696         Reviewed by Beth Dakin.
1697
1698         Support ARIA "tab" roles
1699         https://bugs.webkit.org/show_bug.cgi?id=30842
1700
1701         * DumpRenderTree/AccessibilityUIElement.cpp:
1702         * DumpRenderTree/AccessibilityUIElement.h:
1703         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1704         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1705         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1706
1707 2009-11-01  Eric Seidel  <eric@webkit.org>
1708
1709         Reviewed by David Levin.
1710
1711         buildbots should use --exit-after-N-failures
1712         https://bugs.webkit.org/show_bug.cgi?id=30809
1713
1714         Make the bots exit after 20 failures to prevent never-ending
1715         test runs where every test spends a minute crashing.
1716
1717         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1718
1719 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1720
1721         Reviewed by Eric Seidel.
1722
1723         Turn on warnings for QtWebKit for gcc
1724         https://bugs.webkit.org/show_bug.cgi?id=30958
1725
1726         * DumpRenderTree/qt/main.cpp:
1727         (crashHandler): Mark function NO_RETURN
1728
1729 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
1730
1731         Adding myself to the committers list.
1732
1733         * Scripts/modules/committers.py:
1734
1735 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
1736
1737         Fix an issue that Adam noticed in DRT.
1738
1739         Reviewed by Darin Adler.
1740
1741         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1742         (AccessibilityUIElement::role):
1743         Get the length of the role text, and create a buffer dynamically.
1744
1745 2009-10-30  Eric Seidel  <eric@webkit.org>
1746
1747         No review, rolling out r50105.
1748         http://trac.webkit.org/changeset/50105
1749
1750         This commit was causing:
1751         https://bugs.webkit.org/show_bug.cgi?id=30869
1752         We'll re-implement the feature a different way.
1753
1754         * Scripts/bugzilla-tool:
1755
1756 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
1757
1758         Test for MSAA: Accessibility of headings is not correct
1759
1760         https://bugs.webkit.org/show_bug.cgi?id=30937
1761
1762         Reviewed by Adam Roben.
1763
1764         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1765         (AccessibilityUIElement::role):
1766         Allow the role returned to be a BSTR.
1767         (AccessibilityUIElement::description):
1768         Fix a copy/paste error.
1769
1770 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
1771
1772         Test for MSAA: Accessibility of links is wrong
1773
1774         https://bugs.webkit.org/show_bug.cgi?id=30928
1775
1776         Reviewed by Darin Adler.
1777
1778         * DumpRenderTree/AccessibilityUIElement.cpp:
1779         (getAccessibilityValueCallback):
1780         Return the accessibility value.
1781         (AccessibilityUIElement::getJSClass):
1782         Added "accessibilityValue" value.
1783
1784         * DumpRenderTree/AccessibilityUIElement.h:
1785
1786         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1787         (AccessibilityUIElement::accessibilityValue):
1788         Stubbed.
1789
1790         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1791         (AccessibilityUIElement::accessibilityValue):
1792         Stubbed.
1793
1794         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1795         (AccessibilityUIElement::accessibilityValue):
1796         Get the object's value, and return it as a JS string.
1797
1798 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
1799
1800         Fix typo in command name used by wx build system.
1801
1802         * wx/build/build_utils.py:
1803
1804 2009-10-30  Adam Barth  <abarth@webkit.org>
1805
1806         Reviewed by Darin Adler.
1807
1808         Patch v1 is a dumb default name for patches
1809         https://bugs.webkit.org/show_bug.cgi?id=30952
1810
1811         Let's use "Patch" instead.
1812
1813         * Scripts/bugzilla-tool:
1814
1815 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1816
1817         Unreviewed trivial buildfix.
1818
1819         [Qt] Buildfix for r50333.
1820
1821         * DumpRenderTree/qt/DumpRenderTree.pro:
1822
1823 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
1824
1825         Reviewed by Holger Freyther.
1826
1827         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
1828         https://bugs.webkit.org/show_bug.cgi?id=30953
1829
1830         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
1831         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
1832         makes qt DRT to share this implementation (as gtk and mac ports do).
1833
1834         * DumpRenderTree/qt/DumpRenderTree.pro:
1835         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
1836         * DumpRenderTree/qt/WorkQueue.h: Removed.
1837
1838 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1839
1840         Unreviewed potential buildbot fix.
1841
1842         Second try: Reset page history before running each test.
1843
1844         Apparently the QWebHistory::clear() keeps the current page
1845         in history which is not what we want, so we not additionally
1846         sets the history capacity to 0 (forces removing everything)
1847         and then sets it back to its original value.
1848
1849         * DumpRenderTree/qt/DumpRenderTree.cpp:
1850         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1851
1852 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1853
1854         Unreviewed potential buildbot fix.
1855
1856         Reset page history before running each test.
1857
1858         * DumpRenderTree/qt/DumpRenderTree.cpp:
1859         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1860
1861 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
1862
1863         Reviewed by Eric Seidel.
1864
1865         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
1866
1867         Bug 28420 -  Implement HTML5 <ruby> rendering
1868         (https://bugs.webkit.org/show_bug.cgi?id=28420)
1869
1870         No new tests (no functional change).
1871
1872         * Scripts/build-webkit:
1873
1874 2009-10-29  Dan Bernstein  <mitz@apple.com>
1875
1876         Reviewed by Mark Rowe.
1877
1878         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
1879         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
1880         define it.
1881
1882         * Scripts/VCSUtils.pm:
1883         * Scripts/svn-apply:
1884         * Scripts/svn-unapply:
1885
1886 2009-10-29  Xan Lopez  <xlopez@igalia.com>
1887
1888         Reviewed by Gustavo Noronha.
1889
1890         Use the GTK+ main loop instead of rolling our own mini-version of
1891         it.
1892
1893         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1894         (dump):
1895         (runTest):
1896         (webViewLoadFinished):
1897
1898 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1899
1900         Reviewed by Oliver Hunt.
1901
1902         Implement the Qt version of DRT dumpBackForwardList().
1903
1904         * DumpRenderTree/qt/DumpRenderTree.cpp:
1905         (WebCore::dumpHistoryItem):
1906         (WebCore::DumpRenderTree::dumpBackForwardList):
1907
1908 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1909
1910         Reviewed by Adam Roben.
1911
1912         Implement DRT functionality for Qt introduced in
1913         r28690 and r28705.
1914
1915         - Implemented pathToLocalResource which exposes the functionality of
1916         converting a given unix path to the correct location on Windows.
1917         - Implemented a way to remove machine-dependent information from paths
1918         in layout test results.
1919
1920         * DumpRenderTree/qt/DumpRenderTree.cpp:
1921         (WebCore::urlSuitableForTestResult):
1922         (WebCore::WebPage::javaScriptConsoleMessage):
1923         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1924         (LayoutTestController::pathToLocalResource):
1925         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1926
1927 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
1928
1929         Adding myself to the committers list.
1930
1931         * Scripts/modules/committers.py:
1932
1933 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
1934
1935         Adding myself to the committers list.
1936
1937         * Scripts/modules/committers.py:
1938
1939 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1940
1941         Reviewed by Jan Alonzo.
1942
1943         [GTK] API to start inspector for a WebView
1944         https://bugs.webkit.org/show_bug.cgi?id=22551
1945
1946         Use the new inspector API to implement the LayoutTestController
1947         interfaces used to test the inspector.
1948
1949         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1950         (webInspectorInspectWebView):
1951         (createWebView):
1952         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1953         (LayoutTestController::showWebInspector):
1954         (LayoutTestController::closeWebInspector):
1955         (LayoutTestController::evaluateInWebInspector):
1956
1957 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
1958
1959         Reviewed by Eric Seidel.
1960
1961         [Qt] WebFrame::counterValueForElementById must not be exposed
1962         https://bugs.webkit.org/show_bug.cgi?id=30882
1963
1964         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1965         (LayoutTestController::counterValueForElementById):
1966
1967 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1968
1969         Rubberstamped by Oliver Hunt.
1970
1971         Fix the warning:
1972
1973         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
1974         declared with attribute warn_unused_result".
1975
1976         by actually checking the result. In the case it is null, an
1977         error has occoured, so treat it as the other fatal errors.
1978
1979         * DumpRenderTree/qt/DumpRenderTree.cpp:
1980         (WebCore::DumpRenderTree::initializeFonts):
1981
1982 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
1983
1984         Reviewed by Darin Adler.
1985
1986         Provide a way to get counter values with layoutTestContoller
1987         https://bugs.webkit.org/show_bug.cgi?id=30555
1988
1989         Define layoutTestContoller.counterValueForElementById.
1990
1991         * DumpRenderTree/LayoutTestController.cpp:
1992         (counterValueForElementByIdCallback):
1993         (LayoutTestController::staticFunctions):
1994         * DumpRenderTree/LayoutTestController.h:
1995         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1996         (LayoutTestController::counterValueForElementById):
1997
1998 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1999
2000         Rubberstamped by Oliver Hunt.
2001
2002         Change two methods to be internal for DRT use only.
2003
2004         Part of [Qt] Review all new API in Qt 4.6
2005         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
2006
2007         * DumpRenderTree/qt/DumpRenderTree.cpp:
2008         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2009         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2010         (LayoutTestController::whiteListAccessFromOrigin):
2011
2012 2009-10-27  Eric Seidel  <eric@webkit.org>
2013
2014         Reviewed by Adam Barth.
2015
2016         REGRESSION: svn-apply exits(1) when applying a patch with a file add
2017         https://bugs.webkit.org/show_bug.cgi?id=30826
2018
2019         * Scripts/svn-apply:
2020          - Add () around all system() calls.
2021          - Use the correct system() == 0 or die instead of system() or die
2022          - Add descriptive messages to all die statements.
2023
2024 2009-10-27  Steve Block  <steveblock@google.com>
2025
2026         Reviewed by NOBODY.
2027
2028         Adds steveblock@google.com to list of committers.
2029
2030         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
2031
2032 2009-10-27  Eric Seidel  <eric@webkit.org>
2033
2034         Reviewed by Adam Barth.
2035
2036         svn-apply can exit(0) even on patch failure
2037         https://bugs.webkit.org/show_bug.cgi?id=29622
2038
2039         * Scripts/svn-apply:
2040          - Add a bunch of "or die" statements, hopefully catching all
2041            possible cases where failure could still exit(0).
2042
2043 2009-10-27  Eric Seidel  <eric@webkit.org>
2044
2045         Reviewed by Adam Barth.
2046
2047         svn-* scripts should share code through VCSUtils.pm
2048         https://bugs.webkit.org/show_bug.cgi?id=30791
2049
2050         Just moving code into a shared location.
2051
2052         * Scripts/VCSUtils.pm:
2053         * Scripts/prepare-ChangeLog:
2054         * Scripts/resolve-ChangeLogs:
2055         * Scripts/svn-apply:
2056         * Scripts/svn-create-patch:
2057         * Scripts/svn-unapply:
2058         * Scripts/update-webkit:
2059
2060 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
2061
2062         Suppress a huge number of MSVC warnings when building wxWebKit.
2063
2064         * wx/build/settings.py:
2065
2066 2009-10-26  Eric Seidel  <eric@webkit.org>
2067
2068         No review, just adding Mike Belshe to the committers list.
2069
2070         * Scripts/modules/committers.py:
2071
2072 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2073
2074         Reviewed by Darin Adler.
2075
2076         Make .rc files compile on Windows without depending on MFC headers
2077         https://bugs.webkit.org/show_bug.cgi?id=30750
2078
2079         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
2080         windows.h instead of afxres.h because it exists even when MFC is not
2081         installed, and is all that's needed here.
2082
2083         * FindSafari/FindSafari.rc: Ditto
2084
2085 2009-10-24  Eric Seidel  <eric@webkit.org>
2086
2087         Reviewed by Adam Barth.
2088
2089         bugzilla-tool post-diff should know how to mark commit-queue=?
2090         https://bugs.webkit.org/show_bug.cgi?id=29202
2091
2092         * Scripts/bugzilla-tool:
2093          - Add --commit-queue option to post-diff, post-commits and create-bug.
2094         * Scripts/modules/bugzilla.py:
2095          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
2096          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
2097
2098 2009-10-23  Eric Seidel  <eric@webkit.org>
2099
2100         Reviewed by Adam Barth.
2101
2102         bugzilla-tool commit-queue does not notice modifications to committers.py
2103         https://bugs.webkit.org/show_bug.cgi?id=30084
2104
2105         * Scripts/bugzilla-tool:
2106          - Make commit-queue re-exec itself instead of using while(1).
2107          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
2108          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
2109
2110 2009-10-22  Eric Seidel  <eric@webkit.org>
2111
2112         Reviewed by Adam Barth.
2113
2114         commit-queue will get stuck on patches if land-patches terminates unexpectedly
2115         https://bugs.webkit.org/show_bug.cgi?id=30634
2116
2117         * Scripts/bugzilla-tool:
2118          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
2119          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
2120
2121 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
2122
2123         Reviewed by Eric Seidel.
2124
2125         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
2126
2127         https://bugs.webkit.org/show_bug.cgi?id=30763
2128
2129         * pywebsocket/mod_pywebsocket/__init__.py:
2130         * pywebsocket/mod_pywebsocket/dispatch.py:
2131         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
2132         * pywebsocket/mod_pywebsocket/standalone.py:
2133         * pywebsocket/setup.py:
2134         * pywebsocket/test/test_dispatch.py:
2135
2136 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
2137
2138         Reviewed by David Levin.
2139
2140         REGRESSION: 2 failures in run-webkit-unittests
2141         https://bugs.webkit.org/show_bug.cgi?id=30645
2142
2143         * Scripts/modules/cpp_style_unittest.py:
2144         Fixed a few test scenarios which apparently lost some spaces from
2145         text literals.
2146
2147 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
2148
2149         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
2150
2151         * Scripts/webkitdirs.pm:
2152
2153 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
2154
2155         Reviewed by Darin Adler.
2156
2157         Unification of using null device in perl scripts.
2158         https://bugs.webkit.org/show_bug.cgi?id=30572
2159
2160         * Scripts/VCSUtils.pm:
2161         * Scripts/bisect-builds:
2162         * Scripts/resolve-ChangeLogs:
2163         * Scripts/run-iexploder-tests:
2164         * Scripts/run-jsc:
2165         * Scripts/run-mangleme-tests:
2166         * Scripts/run-webkit-tests:
2167         * Scripts/webkitdirs.pm:
2168         Using File::Spec->devnull() instead of hard coded /dev/null.
2169
2170 2009-10-26  Eric Seidel  <eric@webkit.org>
2171
2172         Reviewed by Holger Freyther.
2173
2174         Reviewers are missing from committers.py
2175         https://bugs.webkit.org/show_bug.cgi?id=30733
2176
2177         * Scripts/modules/committers.py:
2178
2179 2009-10-23  Eric Seidel  <eric@webkit.org>
2180
2181         No review, only adding Alice to the list of reviewers.
2182
2183         * Scripts/modules/committers.py:
2184
2185 2009-10-23  Eric Seidel  <eric@webkit.org>
2186
2187         Reviewed by Eric Carlson.
2188
2189         fast/media/mq-transform-02.html failed on Leopard Commit Bot
2190         https://bugs.webkit.org/show_bug.cgi?id=30700
2191
2192         * DumpRenderTree/mac/DumpRenderTree.mm:
2193         (resetDefaultsToConsistentValues): Update QuickTime version check.
2194
2195 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
2196
2197         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get
2198         character measurement APIs that are private on Tiger.
2199
2200         * wx/build/settings.py:
2201
2202 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2203
2204         Reviewed by NOBODY (build fix).
2205         Build fix following bug #30696.
2206
2207         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2208         (LayoutTestController::evaluateScriptInIsolatedWorld):
2209
2210 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2211
2212         Reviewed by Sam Weinig & Geoff Garen.
2213
2214         https://bugs.webkit.org/show_bug.cgi?id=30696
2215         Enable isolated-worlds tests on mac.
2216
2217         Add private interface for DRT to invoke execution in a given world.
2218
2219         * DumpRenderTree/LayoutTestController.cpp:
2220         (evaluateScriptInIsolatedWorldCallback):
2221         (LayoutTestController::staticFunctions):
2222         * DumpRenderTree/LayoutTestController.h:
2223         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2224         (LayoutTestController::evaluateScriptInIsolatedWorld):
2225         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2226         (LayoutTestController::evaluateScriptInIsolatedWorld):
2227
2228 2009-10-21  Eric Seidel  <eric@webkit.org>
2229
2230         Reviewed by Adam Barth.
2231
2232         bugzilla-tool's "patch failed to download an apply" error should give more information
2233         https://bugs.webkit.org/show_bug.cgi?id=30632
2234
2235         * Scripts/modules/scm.py:
2236          - Use the common run_command method instead of custom POpen code.
2237          - Make run_command know how to take pipes as input.
2238         * Scripts/modules/scm_unittest.py:
2239          - Add new tests to cover change.
2240          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
2241
2242 2009-10-21  Kent Tamura  <tkent@chromium.org>
2243
2244         Unreviewed.  Adding myself to the committers list.
2245
2246         * Scripts/modules/committers.py:
2247
2248 2009-10-21  Robin Dunn  <robin@alldunn.com>
2249
2250         Reviewed by Kevin Ollivier.
2251
2252         Update the Windows installer builder to work with Vista / Win 7 and with git.
2253
2254         https://bugs.webkit.org/show_bug.cgi?id=30649
2255
2256         * wx/build/build_utils.py:
2257         * wx/packaging/build-mac-installer.py:
2258         * wx/packaging/build-win-installer.py:
2259         * wx/packaging/wxWebKitInstaller.iss.in:
2260
2261 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2262
2263         Reviewed by Gustavo Noronha.
2264
2265         [GTK] Added conditional code to avoid using
2266         gdk_window_get_root_coords if we do not have a gtk+ release newer
2267         than 2.17.3.
2268         https://bugs.webkit.org/show_bug.cgi?id=30636
2269
2270         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2271
2272 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
2273
2274         Reviewed by Eric Seidel.
2275
2276         [Qt] Added dummy implementation for keepWebHistory()
2277         https://bugs.webkit.org/show_bug.cgi?id=30592
2278
2279         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2280         (LayoutTestController::keepWebHistory):
2281         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2282
2283 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2284
2285         Reviewed by Xan Lopez.
2286
2287         [GTK] Fixed the double click condition, it is not double click if
2288         we move in just in one direction.
2289         https://bugs.webkit.org/show_bug.cgi?id=30636
2290
2291         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2292
2293 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2294
2295         Reviewed by Xan Lopez.
2296
2297         [GTK] Initialize the events completly before emitting them.
2298         https://bugs.webkit.org/show_bug.cgi?id=30633
2299
2300         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2301
2302 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2303
2304         wx build fix. Fix for when linking using --as-needed with gcc.
2305
2306         * wx/browser/wscript:
2307
2308 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2309
2310         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
2311         to support all the features used by CURL backend.
2312
2313         * wx/build/settings.py:
2314         * wx/install-unix-extras:
2315
2316 2009-10-20  Anton Muhin  <antonm@chromium.org>
2317
2318         Reviewed by Adam Barth.
2319
2320         Add {ager,antonm,yurys}@chromium.org into committers.py
2321         https://bugs.webkit.org/show_bug.cgi?id=30560
2322
2323         * Scripts/modules/committers.py:
2324
2325 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2326
2327         Reviewed by Tor Arne Vestbø.
2328
2329         Make the Netscape Test plugin available to the Qt launcher.
2330
2331         * Scripts/run-launcher:
2332
2333 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
2334
2335         Reviewed by David Levin.
2336
2337         Removed WebSocket runtime settings.
2338         https://bugs.webkit.org/show_bug.cgi?id=29896
2339
2340         WebSocket runtime configuration is supported by chromium/v8 only.
2341
2342         * DumpRenderTree/mac/DumpRenderTree.mm:
2343         (resetDefaultsToConsistentValues):
2344         * DumpRenderTree/win/DumpRenderTree.cpp:
2345         (resetDefaultsToConsistentValues):
2346
2347 2009-10-19  Nate Chapin  <japhet@chromium.org>
2348
2349         Reviewed by Adam Barth.
2350
2351         Add testFail() to test plugin so we can test our handling of a
2352         plugin invoke call returning false.
2353
2354         https://bugs.webkit.org/show_bug.cgi?id=30239
2355
2356         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
2357         (pluginInvoke):
2358         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
2359
2360 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
2361
2362         Reviewed by Gustavo Noronha.
2363
2364         Enable DOM pasting when running layout tests.
2365
2366         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2367         (resetDefaultsToConsistentValues):
2368
2369 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2370
2371         Reviewed by Simon Hausmann.
2372
2373         Use the setPreferredContentsSize method instead
2374         of setFixedContentsSize, as the method has been renamed.
2375
2376         * DumpRenderTree/qt/DumpRenderTree.cpp:
2377         (WebCore::DumpRenderTree::open):
2378         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2379         (LayoutTestController::setFixedContentsSize):
2380
2381 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2382
2383         Reviewed by Dan Bernstein.
2384
2385         https://bugs.webkit.org/show_bug.cgi?id=30456
2386         Fixes for new Debug_All Windows build configuration.
2387
2388         * DumpRenderTree/win/DumpRenderTree.cpp:
2389         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
2390         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
2391
2392 2009-10-16  Eric Seidel  <eric@webkit.org>
2393
2394         Reviewed by Adam Barth.
2395
2396         commit-queue status bot should list which buildbot is blocking the queue
2397         https://bugs.webkit.org/show_bug.cgi?id=30452
2398
2399         Add new methods and testing.
2400
2401         * Scripts/bugzilla-tool:
2402         * Scripts/modules/buildbot.py:
2403         * Scripts/modules/buildbot_unittest.py:
2404
2405 2009-10-16  Eric Seidel  <eric@webkit.org>
2406
2407         Reviewed by Adam Barth.
2408
2409         run-webkit-tests fails when CWD is not inside a WebKit checkout
2410         https://bugs.webkit.org/show_bug.cgi?id=30451
2411
2412         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
2413         * Scripts/modules/scm_unittest.py:
2414           - Remove use of original_path (we don't need to restore the CWD).
2415           - Don't use '.' to find the webkit checkout, use __file__ instead.
2416
2417 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2418
2419         Reviewed by Adam Roben.
2420
2421         Add a Debug_All configuration to build entire stack as debug.
2422         Change Debug_Internal to:
2423         - stop using _debug suffix for all WebKit/Safari binaries
2424         - not use _debug as a DLL naming suffix
2425         - use non-debug C runtime lib.
2426
2427         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
2428         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
2429         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
2430         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2431         Add missing debug.vsprops inherited property sheet.
2432         Add Debug_All configuration.
2433         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
2434         * WinLauncher/WinLauncher.vcproj:
2435         Removed extraneous definitions inherited from vsprops.
2436         Add Debug_All configuration.
2437
2438 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
2439
2440         Reviewed by David Levin.
2441
2442         check-webkit-style is wrong about indent checking in namespaces
2443         in header files and a few other things
2444         https://bugs.webkit.org/show_bug.cgi?id=30362
2445
2446         The few other things include:
2447         + check-webkit-style does not require spaces around the equal sign
2448           inside 'if' statements and around binary operators that take
2449           numeric literals.
2450         + check-webkit-style reports false errors for the / operator
2451           when part of a filename in the #include directive.
2452
2453         * Scripts/modules/cpp_style.py:
2454         Improved indentation checking and space checking around
2455         binary operators. While the checks are still not perfect,
2456         they are clearly better than before.
2457         * Scripts/modules/cpp_style_unittest.py:
2458         Added test cases for the newly supported checks and modified old
2459         test cases to match the new guidelines
2460
2461 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
2462
2463         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
2464
2465         * wx/build/settings.py:
2466
2467 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
2468
2469         Reviewed by David Levin.
2470
2471         Add mod_pywebsocket to test Web Sockets.
2472         http://code.google.com/p/pywebsocket/
2473         https://bugs.webkit.org/show_bug.cgi?id=27490
2474
2475         * pywebsocket/COPYING: Added.
2476         * pywebsocket/MANIFEST.in: Added.
2477         * pywebsocket/README: Added.
2478         * pywebsocket/example/echo_client.py: Added.
2479         * pywebsocket/example/echo_wsh.py: Added.
2480         * pywebsocket/mod_pywebsocket/__init__.py: Added.
2481         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
2482         * pywebsocket/mod_pywebsocket/handshake.py: Added.
2483         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
2484         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
2485         * pywebsocket/mod_pywebsocket/standalone.py: Added.
2486         * pywebsocket/mod_pywebsocket/util.py: Added.
2487         * pywebsocket/setup.py: Added.
2488         * pywebsocket/test/config.py: Added.
2489         * pywebsocket/test/mock.py: Added.
2490         * pywebsocket/test/run_all.py: Added.
2491         * pywebsocket/test/test_dispatch.py: Added.
2492         * pywebsocket/test/test_handshake.py: Added.
2493         * pywebsocket/test/test_mock.py: Added.
2494         * pywebsocket/test/test_msgutil.py: Added.
2495         * pywebsocket/test/test_util.py: Added.
2496         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
2497         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
2498         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
2499         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
2500         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
2501         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
2502         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
2503         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
2504
2505 2009-10-15  James Robinson  <jamesr@google.com>
2506
2507         Reviewed by David Levin.
2508
2509         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
2510
2511         https://bugs.webkit.org/show_bug.cgi?id=30426
2512
2513         * Scripts/modules/cpp_style.py:
2514         * Scripts/modules/cpp_style_unittest.py:
2515
2516 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
2517
2518         Reviewed by Adam Roben.
2519
2520         Fixes <http://webkit.org/b/30411>.
2521         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
2522
2523         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
2524         building Chromium.
2525
2526         * Scripts/pdevenv:
2527
2528 2009-10-15  Robin Dunn  <robin@alldunn.com>
2529
2530         Reviewed by Kevin Ollivier.
2531
2532         Add Mac package building scripts for wx.
2533
2534         https://bugs.webkit.org/show_bug.cgi?id=30405
2535
2536         * wx/build/build_utils.py:
2537         * wx/build/settings.py:
2538         * wx/packaging/build-mac-installer.py: Added.
2539
2540 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
2541
2542         Reviewed by Gustavo Noronha.
2543
2544         Enable Web Sockets support when running layout tests.
2545
2546         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2547         (resetDefaultsToConsistentValues):
2548
2549 2009-10-15  Xan Lopez  <xlopez@igalia.com>
2550
2551         Reviewed by Gustavo Noronha.
2552
2553         Need to initialize event.button.button, since in most cases a
2554         button number is not passed as an argument.
2555
2556         * DumpRenderTree/gtk/EventSender.cpp:
2557         (mouseDownCallback):
2558         (mouseUpCallback):
2559
2560 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
2561
2562         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
2563         the OS if none was explicitly set.
2564
2565         * wx/build/settings.py:
2566
2567 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
2568
2569         Reviewed by Timothy Hatcher.
2570
2571         Web Inspector: enable developers extras within inspector layout tests.
2572
2573         https://bugs.webkit.org/show_bug.cgi?id=30014
2574
2575         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2576         (LayoutTestController::showWebInspector):
2577         (LayoutTestController::closeWebInspector):
2578         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2579         (LayoutTestController::showWebInspector):
2580         (LayoutTestController::closeWebInspector):
2581
2582 2009-10-14  José Millán Soto  <jmillan@igalia.com>
2583
2584         Reviewed by Jan Alonzo.
2585
2586         GtkLauncher is using a deprecated signal
2587         https://bugs.webkit.org/show_bug.cgi?id=30364
2588
2589         Modified GtkLauncher to use notify::title signal instead of
2590         deprecated title-changed signal
2591
2592         * GtkLauncher/main.c:
2593         (notify_title_cb):
2594         (create_browser):
2595
2596 2009-10-14  Brady Eidson  <beidson@apple.com>
2597
2598         Reviewed by Sam Weinig.
2599
2600         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
2601         1 - Disables WebHistory
2602         2 - Doesn't make sense in that context anyway.
2603
2604         * DumpRenderTree/win/DumpRenderTree.cpp:
2605         (createWebViewAndOffscreenWindow):
2606
2607 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
2608
2609         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
2610         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
2611
2612         * wx/build/settings.py:
2613         * wx/install-unix-extras:
2614
2615 2009-10-14  Brady Eidson  <beidson@apple.com>
2616
2617         Reviewed by Sam Weinig.
2618
2619         WebKit Win API should provide a delegate interface for global history.
2620         https://bugs.webkit.org/show_bug.cgi?id=29905
2621
2622         * DumpRenderTree/LayoutTestController.cpp:
2623         (LayoutTestController::LayoutTestController):
2624         * DumpRenderTree/LayoutTestController.h:
2625         (LayoutTestController::dumpHistoryDelegateCallbacks):
2626         (LayoutTestController::setDumpHistoryDelegateCallbacks):
2627
2628         * DumpRenderTree/win/DumpRenderTree.cpp:
2629         (shouldLogHistoryDelegates):
2630         (runTest):
2631         (createWebViewAndOffscreenWindow):
2632         (main):
2633         * DumpRenderTree/win/DumpRenderTree.vcproj:
2634
2635         Add the IWebHistoryDelegate to DRT Windows:
2636         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
2637         (wstringFromBSTR):
2638         (HistoryDelegate::HistoryDelegate):
2639         (HistoryDelegate::~HistoryDelegate):
2640         (HistoryDelegate::QueryInterface):
2641         (HistoryDelegate::AddRef):
2642         (HistoryDelegate::Release):
2643         (HistoryDelegate::didNavigateWithNavigationData):
2644         (HistoryDelegate::didPerformClientRedirectFromURL):
2645         (HistoryDelegate::didPerformServerRedirectFromURL):
2646         (HistoryDelegate::updateHistoryTitle):
2647         (HistoryDelegate::populateVisitedLinksForWebView):
2648         * DumpRenderTree/win/HistoryDelegate.h: Added.
2649
2650         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2651         (LayoutTestController::removeAllVisitedLinks):
2652
2653 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
2654
2655         Reviewed by Simon Hausmann.
2656
2657         [Qt] Implement support for setPOSIXLocale on Qt.
2658         https://bugs.webkit.org/show_bug.cgi?id=30268
2659
2660         * DumpRenderTree/qt/DumpRenderTree.cpp:
2661         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2662         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2663         (LayoutTestController::setPOSIXLocale):
2664         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2665
2666 2009-10-13  Stephanie Lewis  <slewis@apple.com>
2667
2668         Unreviewed, adding myself to reviewers list.
2669
2670         * Scripts/modules/committers.py:
2671
2672 2009-10-13  Stephanie Lewis  <slewis@apple.com>
2673
2674         Reviewed by Mark Rowe.
2675
2676         Fix null assignment so root tests work again.
2677
2678         * Scripts/webkitdirs.pm:
2679
2680 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2681
2682         Reviewed by Simon Hausmann.
2683
2684         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
2685         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
2686         This is done in preparation of implementing missing features in DRT.
2687         No functionality changes made yet.
2688
2689         * DumpRenderTree/qt/DumpRenderTree.cpp:
2690         * DumpRenderTree/qt/DumpRenderTree.pro:
2691         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
2692         (EventSender::EventSender):
2693         (EventSender::mouseDown):
2694         (EventSender::mouseUp):
2695         (EventSender::mouseMoveTo):
2696         (EventSender::leapForward):
2697         (EventSender::keyDown):
2698         (EventSender::contextClick):
2699         (EventSender::scheduleAsynchronousClick):
2700         (EventSender::frameUnderMouse):
2701         * DumpRenderTree/qt/EventSenderQt.h: Added.
2702         (EventSender::clearKillRing):
2703         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
2704         (LayoutTestController::LayoutTestController):
2705         (LayoutTestController::reset):
2706         (LayoutTestController::processWork):
2707         (LayoutTestController::maybeDump):
2708         (LayoutTestController::waitUntilDone):
2709         (LayoutTestController::notifyDone):
2710         (LayoutTestController::windowCount):
2711         (LayoutTestController::clearBackForwardList):
2712         (LayoutTestController::dumpEditingCallbacks):
2713         (LayoutTestController::dumpResourceLoadCallbacks):
2714         (LayoutTestController::queueBackNavigation):
2715         (LayoutTestController::queueForwardNavigation):
2716         (LayoutTestController::queueLoad):
2717         (LayoutTestController::queueReload):
2718         (LayoutTestController::queueScript):
2719         (LayoutTestController::provisionalLoad):
2720         (LayoutTestController::timerEvent):
2721         (LayoutTestController::encodeHostName):
2722         (LayoutTestController::decodeHostName):
2723         (LayoutTestController::setJavaScriptProfilingEnabled):
2724         (LayoutTestController::setFixedContentsSize):
2725         (LayoutTestController::setPrivateBrowsingEnabled):
2726         (LayoutTestController::setPopupBlockingEnabled):
2727         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2728         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2729         (LayoutTestController::numberOfActiveAnimations):
2730         (LayoutTestController::disableImageLoading):
2731         (LayoutTestController::dispatchPendingLoadRequests):
2732         (LayoutTestController::setDatabaseQuota):
2733         (LayoutTestController::clearAllDatabases):
2734         (LayoutTestController::whiteListAccessFromOrigin):
2735         (LayoutTestController::waitForPolicyDelegate):
2736         (LayoutTestController::overridePreference):
2737         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
2738         (LayoutTestController::isLoading):
2739         (LayoutTestController::setLoading):
2740         (LayoutTestController::shouldDumpAsText):
2741         (LayoutTestController::shouldDumpBackForwardList):
2742         (LayoutTestController::shouldDumpChildrenAsText):
2743         (LayoutTestController::shouldDumpDatabaseCallbacks):
2744         (LayoutTestController::shouldDumpStatusCallbacks):
2745         (LayoutTestController::shouldWaitUntilDone):
2746         (LayoutTestController::canOpenWindows):
2747         (LayoutTestController::shouldDumpTitleChanges):
2748         (LayoutTestController::waitForPolicy):
2749         (LayoutTestController::dumpAsText):
2750         (LayoutTestController::dumpChildFramesAsText):
2751         (LayoutTestController::dumpDatabaseCallbacks):
2752         (LayoutTestController::dumpStatusCallbacks):
2753         (LayoutTestController::setCanOpenWindows):
2754         (LayoutTestController::dumpBackForwardList):
2755         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
2756         (LayoutTestController::display):
2757         (LayoutTestController::dumpTitleChanges):
2758         (LayoutTestController::dumpSelectionRect):
2759         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
2760         (TextInputController::TextInputController):
2761         (TextInputController::doCommand):
2762         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
2763         * DumpRenderTree/qt/WorkQueue.cpp:
2764         * DumpRenderTree/qt/WorkQueue.h:
2765         * DumpRenderTree/qt/WorkQueueItem.h:
2766         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
2767         (findFrameNamed):
2768         (LoadItem::invoke):
2769         (ReloadItem::invoke):
2770         (ScriptItem::invoke):
2771         (BackForwardItem::invoke):
2772         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
2773         * DumpRenderTree/qt/jsobjects.h:
2774
2775 2009-10-13  Dmitry Titov  <dimich@chromium.org>
2776
2777         Not reviewed, adding myself to the list of reviewers.
2778
2779         * Scripts/modules/committers.py:
2780
2781 2009-10-13  Anders Carlsson  <andersca@apple.com>
2782
2783         Reviewed by Sam Weinig.
2784
2785         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
2786
2787         Make the private browsing mode testable by the test plug-in.
2788
2789         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2790         (pluginGetProperty):
2791         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2792         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2793         (NPP_New):
2794         (NPP_SetValue):
2795
2796 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
2797
2798         No review, just adding self to the list of reviewers.
2799
2800         * Scripts/modules/committers.py:
2801
2802 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
2803
2804         Reviewed by Adam Roben.
2805
2806         Web Inspector: Use proper web view in inspector layout
2807         tests for windows.
2808
2809         https://bugs.webkit.org/show_bug.cgi?id=30298
2810
2811         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2812         (LayoutTestController::showWebInspector):
2813         (LayoutTestController::closeWebInspector):
2814         (LayoutTestController::evaluateInWebInspector):
2815
2816 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
2817
2818         Reviewed by Sam Weinig.
2819
2820         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
2821         https://bugs.webkit.org/show_bug.cgi?id=29841
2822
2823         * DumpRenderTree/mac/DumpRenderTree.mm:
2824         (resetDefaultsToConsistentValues):
2825         * DumpRenderTree/win/DumpRenderTree.cpp:
2826         (resetDefaultsToConsistentValues):
2827
2828 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
2829
2830         Reviewed by Dimitri Glazkov.
2831
2832         Chromium Port - Windows
2833         https://bugs.webkit.org/show_bug.cgi?id=29969
2834
2835         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
2836         * Scripts/webkitdirs.pm:
2837
2838 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
2839
2840         Reviewed by Darin Adler.
2841
2842         jsc scripts cleanup and Qt/GTK fix
2843         https://bugs.webkit.org/show_bug.cgi?id=30288
2844
2845         Duplicated jscPath() moved to webkitdirs.pm.
2846         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
2847         Configuration added (release/debug) to path for Qt-port on Windows.
2848
2849         * Scripts/run-javascriptcore-tests:
2850         * Scripts/run-jsc:
2851         * Scripts/run-sunspider:
2852         * Scripts/sunspider-compare-results:
2853         * Scripts/webkitdirs.pm:
2854
2855 2009-10-11  Adam Barth  <abarth@webkit.org>
2856
2857         Unreviewed.  Add Collin to committers.py.
2858
2859         * Scripts/modules/committers.py:
2860
2861 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
2862
2863         wx build fix, add bindings to source/include dirs now that there are sources there.
2864
2865         * wx/build/settings.py:
2866
2867 2009-10-09  Mark Rowe  <mrowe@apple.com>
2868
2869         Reviewed by Brady Eidson.
2870
2871         Enable plug-in halting in DumpRenderTree.
2872
2873         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
2874         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
2875
2876         * DumpRenderTree/mac/DumpRenderTree.mm:
2877         (resetDefaultsToConsistentValues):
2878         * DumpRenderTree/mac/UIDelegate.mm:
2879         (-[UIDelegate webView:shouldHaltPlugin:]):
2880
2881 2009-10-08  Brady Eidson  <beidson@apple.com>
2882
2883         Reviewed by Dan Bernstein.
2884
2885         Ask the History Delegate to populate the visited links hash.
2886         <rdar://problem/7285293> and https://webkit.org/b/29904
2887
2888         Add the ability for LayoutTestController to clear all visited links.
2889         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
2890
2891         * DumpRenderTree/LayoutTestController.cpp:
2892         (LayoutTestController::LayoutTestController):
2893         (removeAllVisitedLinksCallback):
2894         (LayoutTestController::staticFunctions):
2895         * DumpRenderTree/LayoutTestController.h:
2896         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2897         (LayoutTestController::removeAllVisitedLinks):
2898
2899         * DumpRenderTree/mac/HistoryDelegate.mm:
2900         (-[HistoryDelegate populateVisitedLinksForWebView:]):
2901
2902         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2903         (LayoutTestController::removeAllVisitedLinks):
2904         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2905         (LayoutTestController::removeAllVisitedLinks):
2906         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2907         (LayoutTestController::removeAllVisitedLinks):
2908
2909
2910 2009-10-08  Daniel Bates  <dbates@webkit.org>
2911
2912         Reviewed by Adam Roben.
2913
2914         https://bugs.webkit.org/show_bug.cgi?id=30175
2915
2916         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
2917         the OLE drag-and-drop return value like the function it emulates. Currently,
2918         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine
2919         whether the drag-and-drop operation was successful or was cancelled.
2920
2921         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop
2922         return value according to whether the drop operation was successful or not.
2923
2924         * DumpRenderTree/win/EventSender.cpp:
2925         (doMouseUp): Added parameter oleDragAndDropReturnValue.
2926         (replaySavedEvents): Ditto.
2927         * DumpRenderTree/win/EventSender.h:
2928         * DumpRenderTree/win/UIDelegate.cpp:
2929         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
2930
2931 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
2932
2933         Reviewed by Xan Lopez.
2934
2935         [GTK] Added support for a parameter setting the button that was
2936         pressed in the mouseDown function.
2937         https://bugs.webkit.org/show_bug.cgi?id=30220
2938
2939         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2940
2941 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
2942
2943         Reviewed by Xan Lopez.
2944
2945         [GTK] Added a line to the bottom of the expected result to match
2946         the output of the test.
2947         https://bugs.webkit.org/show_bug.cgi?id=30220
2948
2949         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
2950         expected.txt:
2951
2952 2009-10-08  Adam Roben  <aroben@apple.com>
2953
2954         Use QueryInterface to get IWebInspectorPrivate
2955
2956         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
2957         accessed in a more standard way
2958
2959         Reviewed by John Sullivan and Tim Hatcher.
2960
2961         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2962         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
2963         by calling IWebViewPrivate::inspector, then use QueryInterface to get
2964         to the IWebInspectorPrivate interface.
2965
2966 2009-10-07  Adam Roben  <aroben@apple.com>
2967
2968         Implement DRT support for origin whitelisting
2969
2970         Fixes <http://webkit.org/b/30185>.
2971
2972         Reviewed by Eric Seidel.
2973
2974         * DumpRenderTree/win/DumpRenderTree.cpp:
2975         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
2976         whitelist, to match Mac DRT.
2977         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2978         (LayoutTestController::whiteListAccessFromOrigin): Call through to
2979         IWebViewPrivate::whiteListAccessFromOrigin.
2980
2981 2009-10-07  Brady Eidson  <beidson@apple.com>
2982
2983         Reviewed by Darin Adler.
2984
2985         Send title changes to the global history delegate.
2986         <rdar://problem/7285293> and https://webkit.org/b/29904
2987
2988         * DumpRenderTree/mac/HistoryDelegate.mm:
2989         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
2990
2991 2009-10-07  Adam Barth  <abarth@webkit.org>
2992
2993         Unreviewed.  Remove some folks from committers.py who were listed on
2994         the WebKit Team wiki page but who weren't actually listed as commit+.
2995         At some point, we should coorelate this list with the committers
2996         mailing list.
2997
2998         * Scripts/modules/committers.py:
2999
3000 2009-10-07  Adam Barth  <abarth@webkit.org>
3001
3002         Unreviewed.  Import a bunch of committers from the WebKit Team page on
3003         the wiki into committers.py.
3004
3005         * Scripts/modules/committers.py:
3006
3007 2009-10-07  Adam Barth  <abarth@webkit.org>
3008
3009         Unreviewed.  Added Aaron Boodman to committers.py.
3010
3011         * Scripts/modules/committers.py:
3012
3013 2009-10-07  Evan Martin  <evan@chromium.org>
3014
3015         Reviewed by Darin Adler.
3016
3017         Add API to LayoutTestController for re/setting the system locale.
3018         https://bugs.webkit.org/show_bug.cgi?id=18994
3019
3020         * DumpRenderTree/LayoutTestController.cpp:
3021         (setLocaleCallback):
3022         (LayoutTestController::staticFunctions):
3023         (LayoutTestController::setLocale):
3024         * DumpRenderTree/LayoutTestController.h:
3025
3026 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
3027
3028         Reviewed by Jan Alonzo.
3029
3030         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3031         https://bugs.webkit.org/show_bug.cgi?id=29689
3032
3033         Build fix by adding -lfontconfig for DumpRenderTree.
3034
3035         * GNUmakefile.am:
3036
3037 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3038
3039         Reviewed by Simon Hausmann.
3040
3041         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
3042
3043         * Scripts/run-webkit-tests:
3044
3045 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3046
3047         Reviewed by Gustavo Noronha.
3048
3049         "delete" in EventSender is the backspace key, not the delete one.
3050
3051         * DumpRenderTree/gtk/EventSender.cpp:
3052         (keyDownCallback):
3053
3054 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3055
3056         Reviewed by Gustavo Noronha.
3057
3058         getChildrenWithRange expects as last parameter the end index, not
3059         the length of the range. Correct this and clarify the variable
3060         names to reflect how the code works.
3061
3062         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3063         (AccessibilityUIElement::getChildrenWithRange):
3064         (AccessibilityUIElement::getChildAtIndex):
3065
3066 2009-10-06  Mark Rowe  <mrowe@apple.com>
3067
3068         Reviewed by Simon Fraser.
3069
3070         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
3071
3072         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
3073         the fact we have already changed the working directory to the top of the open source tree.
3074
3075 2009-10-06  Julie Parent  <jparent@chromium.org>
3076
3077         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
3078         rather than my committer email.
3079
3080         * Scripts/modules/committers.py:
3081
3082 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3083
3084         Reviewed by Eric Seidel.
3085
3086         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
3087
3088         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
3089         it after each layout test as it should do, making the DRT dump additional output
3090         for all of the subsequent layout tests.
3091
3092         * DumpRenderTree/qt/jsobjects.cpp:
3093         (LayoutTestController::reset):
3094
3095 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3096
3097         Reviewed by Simon Hausmann.
3098
3099         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
3100         fast/dom/assign-to-window-status.html test, which is passing as a result.
3101
3102         https://bugs.webkit.org/show_bug.cgi?id=30127
3103
3104         * DumpRenderTree/qt/DumpRenderTree.cpp:
3105         (WebCore::DumpRenderTree::DumpRenderTree):
3106         (WebCore::DumpRenderTree::statusBarMessage):
3107         * DumpRenderTree/qt/DumpRenderTree.h:
3108         * DumpRenderTree/qt/jsobjects.h:
3109         (LayoutTestController::shouldDumpStatusCallbacks):
3110         (LayoutTestController::dumpStatusCallbacks):
3111
3112 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3113
3114         Reviewed by Simon Hausmann.
3115
3116         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
3117         ignores the argument indicating which mouse button to trigger.
3118         https://bugs.webkit.org/show_bug.cgi?id=30048
3119
3120         This affects the fast/events/mouse-click-events.html layout test.
3121
3122         * DumpRenderTree/qt/jsobjects.cpp:
3123         (EventSender::mouseDown):
3124         (EventSender::mouseUp):
3125         * DumpRenderTree/qt/jsobjects.h:
3126
3127 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3128
3129         Reviewed by Simon Hausmann.
3130
3131         [Qt] Fix the EventSender::keyDown() implementation
3132         https://bugs.webkit.org/show_bug.cgi?id=30043
3133
3134         It should post both a key press event and a key release event,
3135         just like other ports do.
3136
3137         * DumpRenderTree/qt/jsobjects.cpp:
3138         (EventSender::keyDown):
3139
3140 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
3141
3142         wx build fix. Add jpeg to the list of libs to link against.
3143
3144         * wx/build/settings.py:
3145
3146 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
3147
3148         Reviewed by Simon Hausmann.
3149
3150         [Qt] EventSender::keyDown() cannot send function-key events.
3151         https://bugs.webkit.org/show_bug.cgi?id=30044
3152
3153         This affects the fast/events/keydown-function-keys.html layout test.
3154
3155         * DumpRenderTree/qt/jsobjects.cpp:
3156         (EventSender::keyDown):
3157
3158 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
3159
3160         Added --wx-compiler-prefix waf option to allow building wxWebKit with
3161         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
3162
3163         * wx/build/settings.py:
3164         * wx/build/wxpresets.py:
3165
3166 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
3167
3168         Reviewed by Timothy Hatcher.
3169
3170         Web Inspector: add testing harness for Web Inspector.
3171
3172         https://bugs.webkit.org/show_bug.cgi?id=30010
3173
3174         * DumpRenderTree/LayoutTestController.cpp:
3175         (showWebInspectorCallback):
3176         (closeWebInspectorCallback):
3177         (evaluateInWebInspectorCallback):
3178         (LayoutTestController::staticFunctions):
3179         * DumpRenderTree/LayoutTestController.h:
3180         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3181         (LayoutTestController::showWebInspector):
3182         (LayoutTestController::closeWebInspector):
3183         (LayoutTestController::evaluateInWebInspector):
3184         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3185         (LayoutTestController::showWebInspector):
3186         (LayoutTestController::closeWebInspector):
3187         (LayoutTestController::evaluateInWebInspector):
3188         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3189         (LayoutTestController::showWebInspector):
3190         (LayoutTestController::closeWebInspector):
3191         (LayoutTestController::evaluateInWebInspector):
3192         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3193         (LayoutTestController::showWebInspector):
3194         (LayoutTestController::closeWebInspector):
3195         (LayoutTestController::evaluateInWebInspector):
3196
3197 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3198
3199         Reviewed by Ariyha Hidayat.
3200
3201         Pass arguments to system() as a string instead of array
3202
3203         When passed as an array entries with a space fail to translate
3204         to two arguments to the child process, so instead of manually
3205         splitting all the entries in @buildArgs we pass the whole thing
3206         as a string instead.
3207
3208         * Scripts/webkitdirs.pm:
3209
3210 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
3211
3212         Reviewed by David Levin.
3213
3214         check-webkit-style misses whitespace errors for operators:
3215         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
3216         https://bugs.webkit.org/show_bug.cgi?id=30021
3217
3218         * Scripts/modules/cpp_style.py:
3219         Added the operators mentioned above to the same list as == and !=.
3220
3221 2009-10-02  Julie Parent  <jparent@chromium.org>
3222
3223         Unreviewed.
3224
3225         Adding myself and Ojan Vafai as committers, because we are committers.
3226
3227         * Scripts/modules/committers.py:
3228
3229 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
3230
3231         Reviewed by Adam Roben.
3232
3233         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
3234         this will help the patch merging process when TryBots are used.
3235
3236         * Scripts/svn-create-patch:
3237
3238 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
3239
3240         Reviewed by Simon Hausmann.
3241
3242         [Qt] Implement layoutTestController.overridePreference().
3243         https://bugs.webkit.org/show_bug.cgi?id=29970
3244
3245         * DumpRenderTree/qt/DumpRenderTree.cpp:
3246         (WebCore::WebPage::WebPage):
3247         (WebCore::WebPage::resetSettings):
3248         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3249         * DumpRenderTree/qt/jsobjects.cpp:
3250         (LayoutTestController::reset):
3251         (LayoutTestController::setPrivateBrowsingEnabled):
3252         (LayoutTestController::setPopupBlockingEnabled):
3253         (LayoutTestController::overridePreference):
3254         * DumpRenderTree/qt/jsobjects.h:
3255
3256 2009-10-01  Chris Marrin  <cmarrin@apple.com>
3257
3258         Reviewed by Oliver Hunt.
3259
3260         Turn on ENABLE_3D_CANVAS in TOT
3261         https://bugs.webkit.org/show_bug.cgi?id=29906
3262
3263         * Scripts/build-webkit:
3264
3265 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3266
3267         Rubberstamped by Simon Hausmann.
3268
3269         Enable HTTP tests for Qt
3270
3271         * Scripts/run-webkit-tests:
3272
3273 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
3274
3275         Reviewed by Dimitri Glazkov.
3276
3277         build-webkit --chromium now also works on cygwin.
3278
3279         https://bugs.webkit.org/show_bug.cgi?id=29973
3280
3281         * Scripts/webkitdirs.pm:
3282
3283 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
3284
3285         Reviewed by Simon Hausmann.
3286
3287         [Qt] Don't use TCmalloc in DumpRenderTree
3288         https://bugs.webkit.org/show_bug.cgi?id=27029
3289
3290         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
3291
3292         * DumpRenderTree/qt/DumpRenderTree.pro:
3293
3294 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3295
3296         Reviewed by Simon Hausmann.
3297
3298         [Qt] Implement eventSender.scheduleAsynchronousClick().
3299
3300         https://bugs.webkit.org/show_bug.cgi?id=29931
3301
3302         * DumpRenderTree/qt/jsobjects.cpp:
3303         (EventSender::scheduleAsynchronousClick):
3304         * DumpRenderTree/qt/jsobjects.h:
3305
3306 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3307
3308         Reviewed by Simon Hausmann.
3309
3310         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
3311         fast/events/open-window-from-another-frame.html from the Skipped list.
3312
3313         https://bugs.webkit.org/show_bug.cgi?id=29930
3314
3315         * DumpRenderTree/qt/jsobjects.cpp:
3316         (LayoutTestController::setPopupBlockingEnabled):
3317         * DumpRenderTree/qt/jsobjects.h:
3318
3319 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
3320
3321         Unreviewed.
3322
3323         Added myself to the list of committers.
3324
3325         * Scripts/modules/committers.py:
3326
3327 2009-09-30  Eric Seidel  <eric@webkit.org>
3328
3329         No review, just adding Geoff to the list of reviewers.
3330
3331         * Scripts/modules/committers.py:
3332
3333 2009-09-30  Dan Bernstein  <mitz@apple.com>
3334
3335         Reviewed by Sam Weinig.
3336
3337         Added the WebKit Layout Tests fonts that are referenced in
3338         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
3339
3340         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
3341         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
3342
3343 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3344
3345         Reviewed by David Kilzer.
3346
3347         Make sunspider scripts work on Windows platform.
3348         https://bugs.webkit.org/show_bug.cgi?id=29656
3349
3350         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
3351         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
3352         * Scripts/webkitdirs.pm: currentPerlPath() added.
3353
3354 2009-09-29  Brady Eidson  <beidson@apple.com>
3355
3356         Rubberstamped by Dan Bernstein.
3357
3358         Fix license and some sorting in new files.
3359
3360         * DumpRenderTree/mac/HistoryDelegate.h:
3361         * DumpRenderTree/mac/HistoryDelegate.mm:
3362
3363 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
3364
3365         Reviewed by David Kilzer.
3366
3367         Fixed how error codes are handled.
3368         https://bugs.webkit.org/show_bug.cgi?id=29898
3369
3370         * Scripts/update-webkit:
3371         * Scripts/update-webkit-chromium:
3372
3373 2009-09-29  Brady Eidson  <beidson@apple.com>
3374
3375         Reviewed by John Sullivan.
3376
3377         Updated way-out-of-date sorting throughout the dump methods/flags.
3378
3379         * DumpRenderTree/LayoutTestController.cpp:
3380         (LayoutTestController::LayoutTestController):
3381         (dumpAsPDFCallback):
3382         (dumpAsTextCallback):
3383         (dumpFrameLoadCallbacksCallback):
3384         (dumpResourceLoadCallbacksCallback):
3385         (LayoutTestController::staticFunctions):
3386
3387         * DumpRenderTree/LayoutTestController.h:
3388         (LayoutTestController::dumpAsText):
3389         (LayoutTestController::setDumpAsText):
3390         (LayoutTestController::dumpFrameLoadCallbacks):
3391         (LayoutTestController::setDumpFrameLoadCallbacks):
3392         (LayoutTestController::dumpSelectionRect):
3393         (LayoutTestController::setDumpSelectionRect):
3394         (LayoutTestController::dumpSourceAsWebArchive):
3395         (LayoutTestController::setDumpSourceAsWebArchive):
3396         (LayoutTestController::dumpStatusCallbacks):
3397         (LayoutTestController::setDumpStatusCallbacks):
3398         (LayoutTestController::dumpTitleChanges):
3399         (LayoutTestController::setDumpTitleChanges):
3400         (LayoutTestController::dumpWillCacheResponse):
3401         (LayoutTestController::setDumpWillCacheResponse):
3402
3403 2009-09-29  Brady Eidson  <beidson@apple.com>
3404
3405         Reviewed by John Sullivan.
3406
3407         WebKit Mac API should provide a delegate interface for global history.
3408         <rdar://problem/7042773> and https://webkit.org/b/29904
3409
3410         Adding the dumping of global history delegate callbacks.
3411
3412         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3413
3414         Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
3415         * DumpRenderTree/mac/DumpRenderTree.mm:
3416         (createWebViewAndOffscreenWindow):
3417         (allocateGlobalControllers):
3418         (shouldLogFrameLoadDelegates):
3419         (shouldLogHistoryDelegates):
3420         (runTest):
3421
3422         Dump history delegate callbacks:
3423         * DumpRenderTree/mac/HistoryDelegate.h: Added.
3424         * DumpRenderTree/mac/HistoryDelegate.mm: Added.
3425         (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
3426         (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
3427         (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
3428
3429 2009-09-29  Daniel Bates  <dbates@webkit.org>
3430
3431         Reviewed by Adam Roben.
3432
3433         https://bugs.webkit.org/show_bug.cgi?id=28902
3434
3435         Fixes an issue where the drop effect returned by Window Dump Render Tree
3436         was always DROPEFFECT_NONE (since it was hard coded to do so).
3437
3438         This patch corrects this issue by determining the actual drop effect
3439         performed by the corresponding drag-and-drop operation so that we can
3440         return it.
3441
3442         * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
3443         (DraggingInfo::DraggingInfo):
3444         (DraggingInfo::performedDropEffect): Added method.
3445         (DraggingInfo::setPerformedDropEffect): Added method.
3446         * DumpRenderTree/win/EventSender.cpp:
3447         (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
3448         Moved delete draggingInfo to UIDelegate::doDragDrop.
3449         * DumpRenderTree/win/UIDelegate.cpp:
3450         (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
3451
3452 2009-09-29  Dan Bernstein  <mitz@apple.com>
3453
3454         Reviewed by Adam Roben.
3455
3456         Remove copying of unnecessary or nonexistent files from the ImageDiff
3457         post-build event.
3458
3459         * DumpRenderTree/win/ImageDiff.vcproj:
3460
3461 2009-09-29  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3462
3463         Reviewed by David Kilzer.
3464
3465         [Qt] Make build-webkit script work on Windows
3466         https://bugs.webkit.org/show_bug.cgi?id=29802
3467
3468         * Scripts/run-webkit-tests:
3469         * Scripts/webkitdirs.pm:
3470          - Removed unnecessary -p switch for mkdir on Windows.
3471          - Use canonical path, which uses slashes or backslashes depends on platform.
3472          - isWindows() only test for Windows and not for Cyqwin.
3473
3474 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3475
3476         Reviewed by Simon Hausmann.
3477
3478         Fix time measurement in build-webkit after refactoring done in r48853.
3479
3480         * Scripts/build-webkit:
3481
3482 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3483
3484         Reviewed by Tor Arne Vestbø.
3485
3486         [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.
3487         This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.
3488
3489         * DumpRenderTree/qt/DumpRenderTree.cpp:
3490         (WebCore::WebPage::WebPage):
3491
3492 2009-09-29  Jakub Wieczorek  <faw217@gmail.com>
3493
3494         Reviewed by Simon Hausmann.
3495
3496         [Qt] Implement eventSender.contextClick().
3497         https://bugs.webkit.org/show_bug.cgi?id=29821
3498
3499         * DumpRenderTree/qt/jsobjects.cpp:
3500         (EventSender::contextClick):
3501         * DumpRenderTree/qt/jsobjects.h:
3502
3503 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
3504
3505         Reviewed by Eric Seidel.
3506
3507         Add experimentalWebSocketsEnabled in WebPreferences.
3508         https://bugs.webkit.org/show_bug.cgi?id=28941
3509
3510         * DumpRenderTree/mac/DumpRenderTree.mm:
3511         (resetDefaultsToConsistentValues):
3512         * DumpRenderTree/win/DumpRenderTree.cpp:
3513         (resetDefaultsToConsistentValues):
3514
3515 2009-09-28  Yaar Schnitman  <yaar@chromium.org>
3516
3517         Reviewed by David Kilzer.
3518
3519         Integrated chromium port building into webkit tools update-webkit and
3520         build-webkit.
3521
3522         https://bugs.webkit.org/show_bug.cgi?id=29749
3523
3524         * Scripts/build-webkit: When --chromium is specified, will build
3525           the chromium port (currently only Mac is supported).
3526         * Scripts/update-webkit: When --chromium is specified, delegates to
3527           update-webkit-chromium.
3528         * Scripts/webkitdirs.pm: Added chromium specific defs.
3529         * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch
3530           chromium port's dependencies and update its project files.
3531
3532 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
3533
3534         Unreviewed.
3535
3536         Add myself to list of committers.
3537
3538         * Scripts/modules/committers.py:
3539
3540 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
3541
3542         Reviewed by Darin Adler.
3543
3544         run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
3545         https://bugs.webkit.org/show_bug.cgi?id=29771
3546
3547         * Scripts/run-webkit-tests:
3548
3549 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
3550
3551         Reviewed by Simon Hausmann.
3552
3553         [Qt] Implement layoutTestController.waitForPolicyDelegate.
3554         https://bugs.webkit.org/show_bug.cgi?id=25037
3555
3556         * DumpRenderTree/qt/DumpRenderTree.cpp:
3557         (WebCore::WebPage::acceptNavigationRequest):
3558         * DumpRenderTree/qt/DumpRenderTree.pro:
3559         * DumpRenderTree/qt/jsobjects.cpp:
3560         (LayoutTestController::reset):
3561         (LayoutTestController::notifyDone):
3562         (LayoutTestController::waitForPolicyDelegate):
3563         * DumpRenderTree/qt/jsobjects.h:
3564         (LayoutTestController::waitForPolicy):
3565
3566 2009-09-26  David Kilzer  <ddkilzer@apple.com>
3567
3568         <http://webkit.org/b/29764> mark-bug-fixed: add -o|--open switch
3569
3570         Reviewed by Eric Seidel.
3571
3572         The -o|--open switch uses the open(1) command on Mac OS X to
3573         open the bug URL in the default web browser.  If there are
3574         similar mechanisms on other platforms, they may be added later.
3575
3576         * Scripts/mark-bug-fixed:
3577         (MarkBugFixed.__init__): Added -o|--open switch to list of parse
3578         options.
3579         (MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
3580         code into main() and extracted prompting code into
3581         _prompt_user_for_correctness().
3582         (MarkBugFixed._open_bug_in_web_browser): Added.
3583         (MarkBugFixed._prompt_user_for_correctness): Added.
3584         (MarkBugFixed.main): Added logging code from
3585         _determine_bug_id_and_svn_revision().  Added code to call
3586         _open_bug_in_web_browser() if the switch is set.  Added code to
3587         call _prompt_user_for_correctness() when needed.
3588         * Scripts/modules/bugzilla.py:
3589         (Bugzilla.short_bug_url_for_bug_id): Added.
3590
3591 2009-09-26  David Kilzer  <ddkilzer@apple.com>
3592
3593         svn-unapply and svn-apply don't work when used outside multiple svn working directories
3594
3595         <http://webkit.org/b/29744>
3596         <rdar://problem/7252905>
3597
3598         Reviewed by Eric Seidel.
3599
3600         Some users have a workflow where svn-create-patch, svn-apply and
3601         svn-unapply are used outside of multiple svn working
3602         directories.  Instead of aborting the scripts in these cases,
3603         print a warning and assume that Subversion is being used.
3604
3605         * Scripts/VCSUtils.pm:
3606         (determineVCSRoot): Call warn() instead of die() if both isGit()
3607         and isSVN() initially return false.  Set $VCSUtils::isSVN to 1
3608         to enforce the assumption about Subversion, then return
3609         determineSVNRoot().
3610         * Scripts/svn-apply: Switch to using isGit() and isSVN() from
3611         VCSUtils.pm.  They both already cache their values and checking
3612         here is redundant since determineVCSRoot() is called later.
3613
3614 2009-09-26  Zan Dobersek  <zandobersek@gmail.com>
3615
3616         Reviewed by Gustavo Noronha.
3617
3618         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3619         https://bugs.webkit.org/show_bug.cgi?id=29689
3620
3621         Load test fonts through FontConfig before each test.
3622         This ensures a more proper rendering of the tests.
3623
3624         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3625         (initializeFonts):
3626         (runTest):
3627         (main):
3628         * DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf.
3629         * GNUmakefile.am:
3630
3631 2009-09-25  David Kilzer  <ddkilzer@apple.com>
3632
3633         <http://webkit.org/b/29718> mark-bug-fixed: add -u|--update-only switch
3634
3635         Reviewed by Eric Seidel.
3636
3637         * Scripts/mark-bug-fixed:
3638         (MarkBugFixed.__init__): Added -u|--update-only switch to list
3639         of parse options.
3640         (MarkBugFixed.main): When -u|--update-only is specified, add a
3641         comment to the bug without marking it Resolved/Fixed.
3642
3643 2009-09-25  Darin Adler  <darin@apple.com>
3644
3645         Reviewed by Geoffrey Garen.
3646
3647         * Scripts/prepare-ChangeLog: Leave files from the script-tests directory
3648         out, just as we do for the resources directory.
3649
3650 2009-09-25  Adam Barth  <abarth@webkit.org>
3651
3652         Unreviewed.  Added Tony to committers.py because he's a
3653         committer now.
3654
3655         * Scripts/modules/committers.py:
3656
3657 2009-09-25  Eric Seidel  <eric@webkit.org>
3658
3659         Reviewed by Simon Fraser.
3660
3661         REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
3662         https://bugs.webkit.org/show_bug.cgi?id=28624
3663
3664         Disable hardware compositing on Leopard for versions of QuickTime 7.6.4 and older.
3665
3666         * DumpRenderTree/mac/DumpRenderTree.mm:
3667         (resetDefaultsToConsistentValues):
3668
3669 2009-09-25  Eric Seidel  <eric@webkit.org>
3670
3671         Reviewed by Adam Barth.
3672
3673         commit-queue should auto-retry patches which fail to commit due to out of date files
3674         https://bugs.webkit.org/show_bug.cgi?id=28316
3675
3676         * Scripts/bugzilla-tool:
3677          - Handle new CheckoutNeedsUpdate exception.
3678         * Scripts/modules/logging_unittest.py:
3679          - Call the ScriptError constructor correctly (this test had regressed).
3680         * Scripts/modules/scm.py:
3681          - Added the ability to define custom error handlers for run_command
3682            and added a commit_error_handler which throws CheckoutNeedsUpdate
3683            instead of ScriptError.
3684          - Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible.
3685         * Scripts/modules/scm_unittest.py:
3686          - Added tests of new error handlers.
3687
3688 2009-09-25  Eric Seidel  <eric@webkit.org>
3689
3690         Reviewed by Adam Barth.
3691
3692         commit-queue should give better feedback when failing a patch
3693         https://bugs.webkit.org/show_bug.cgi?id=29316
3694
3695         * Scripts/bugzilla-tool:
3696          - Update ScriptError uses to the new constructor format.
3697          - Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output
3698            so that we can print to both stdout as well as an output buffer for error reporting.