2010-04-01 James Robinson <jamesr@chromium.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-04-01  Adam Barth  <abarth@webkit.org>
2
3         Unreviewed.  Add cmarrin's IRC nickname.
4
5         * Scripts/webkitpy/common/config/committers.py:
6
7 2010-04-01  Adam Barth  <abarth@webkit.org>
8
9         Unreviewed.
10
11         EWS spins hot when unable to build
12         https://bugs.webkit.org/show_bug.cgi?id=36981
13
14         The problem is that the queue engine things we have more work to do,
15         but the bot isn't actually able to do anything.  After this change, we
16         back off the usual amount.
17
18         * Scripts/webkitpy/tool/bot/queueengine.py:
19         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
20         * Scripts/webkitpy/tool/commands/queues.py:
21         * Scripts/webkitpy/tool/commands/sheriffbot.py:
22
23 2010-04-01  Chris Marrin  <cmarrin@apple.com>
24
25         Reviewed by Simon Fraser.
26
27         Added layerTreeAsText function to DRT (for Mac)
28         https://bugs.webkit.org/show_bug.cgi?id=36782
29
30         This is the DRT side. It exposes the call to JavaScript
31         through the LayoutTestController.
32
33         * DumpRenderTree/LayoutTestController.cpp:Platform independent JavaScript shim
34         (layerTreeAsTextCallback):
35         (LayoutTestController::staticFunctions):
36         * DumpRenderTree/LayoutTestController.h:
37         * DumpRenderTree/mac/LayoutTestControllerMac.mm:Mac specific plumbing to WebKit
38         (LayoutTestController::layerTreeAsText):
39         * DumpRenderTree/win/LayoutTestControllerWin.cpp:Windows specific plumbing to WebKit
40         (LayoutTestController::layerTreeAsText):
41
42 2010-04-01  Kevin Ollivier  <kevino@theolliviers.com>
43
44         [wx] Build fix after addition of JavaScriptCore/wtf/text directory.
45
46         * wx/build/settings.py:
47
48 2010-04-01  Jian Li  <jianli@chromium.org>
49
50         Rubber-stamped by David Levin.
51
52         Add myself to the reviewers list.
53
54         * Scripts/webkitpy/common/config/committers.py:
55
56 2010-04-01  Adam Barth  <abarth@webkit.org>
57
58         Unreviewed.
59
60         Turns out the Chromium Windows bots don't have pdevenv installed.
61
62         * Scripts/webkitdirs.pm:
63
64 2010-04-01  Adam Barth  <abarth@webkit.org>
65
66         Reviewed by Dimitri Glazkov.
67
68         Let Chromium Windows build with Visual Studio Express
69         https://bugs.webkit.org/show_bug.cgi?id=36919
70
71         This is horrible, horrible copy/paste code, but that seems to be the
72         way of webkitdirs.pm.  :(
73
74         Someone needs to go through an cleanup this code, but I don't have the
75         heart to do it in this patch.
76
77         * Scripts/webkitdirs.pm:
78
79 2010-04-01  Ilya Tikhonovsky  <loislo@chromium.org>
80
81         Reviewed by Yury Semikhatsky.
82
83         Add myself to the committers list.
84         https://bugs.webkit.org/show_bug.cgi?id=36953
85
86         * Scripts/webkitpy/common/config/committers.py:
87
88 2010-04-01  Eric Seidel  <eric@webkit.org>
89
90         Rubber-stamped by Adam Barth.
91
92         Add Snow Leopard Release bot to the list of "core builders" (builders which stop the commit-queue when they turn red)
93         https://bugs.webkit.org/show_bug.cgi?id=33292
94
95         Just adding the "Build" builder for now.
96         We'll add the "Test" builders when the tests
97         are less flaky.
98
99         * Scripts/webkitpy/common/net/buildbot.py:
100         * Scripts/webkitpy/common/net/buildbot_unittest.py:
101
102 2010-04-01  Yury Semikhatsky  <yurys@chromium.org>
103
104         Reviewed by David Levin.
105
106         Add myself to the reviewers list.
107
108         https://bugs.webkit.org/show_bug.cgi?id=36935
109
110         * Scripts/webkitpy/common/config/committers.py:
111
112 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
113
114         Reviewed by Dave Levin.
115
116         Added Python style checking to check-webkit-style using
117         the third-party pep8 module (via autoinstall).
118
119         https://bugs.webkit.org/show_bug.cgi?id=33639
120
121         * Scripts/webkitpy/style/checker.py:
122           - Added PYTHON to FileType.
123           - Updated ProcessorDispatcher to return a PythonProcessor
124             for *.py files.
125
126         * Scripts/webkitpy/style/checker_unittest.py:
127           - Updated the ProcessorDispatcher unit tests for *.py files.
128
129         * Scripts/webkitpy/style/processors/python.py: Added.
130           - Added PythonProcessor class.
131
132         * Scripts/webkitpy/style/processors/python_unittest.py: Added.
133           - Added PythonProcessor unit tests.
134
135         * Scripts/webkitpy/style/processors/python_unittest_input.py: Added.
136           - Added a sample Python file to test the PythonProcessor.process()
137             code path (since pep8 accepts a file path).
138
139         * Scripts/webkitpy/style/unittests.py:
140           - Updated the style unit test file to import python_unittest.py.
141
142         * Scripts/webkitpy/style_references.py:
143           - Adjusted style references to import pep8.
144
145 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
146
147         Reviewed by Dave Levin.
148
149         Rewrote autoinstall.py to support unzipping *.zip files after
150         download, unzipping and extracting *.tar.gz files after download,
151         and copying installed files to a given destination directory.
152
153         https://bugs.webkit.org/show_bug.cgi?id=35163
154
155         These changes will let us autoinstall pep8.py from the web and put
156         our third-party autoinstalled code in an explicit directory like
157         webkitpy/thirdparty/autoinstalled. These changes should also speed
158         up the execution of autoinstalled *.zip packages slightly since
159         *.pyc files cannot be generated when importing from zipped
160         packages using the current autoinstall.
161
162         * Scripts/test-webkitpy:
163           - Addressed the FIXME to enable auto-install logging once
164             autoinstall was rewritten not to log as verbosely.
165
166         * Scripts/webkitpy/common/net/bugzilla.py:
167           - Updated mechanize import statement.
168
169         * Scripts/webkitpy/common/net/buildbot.py:
170           - Updated mechanize import statement.
171
172         * Scripts/webkitpy/common/net/irc/ircbot.py:
173           - Updated ircbot and irclib import statements.
174
175         * Scripts/webkitpy/common/net/networktransaction.py:
176           - Updated mechanize import statement.
177
178         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
179           - Updated mechanize import statement.
180
181         * Scripts/webkitpy/common/net/statusserver.py:
182           - Updated mechanize import statement.
183
184         * Scripts/webkitpy/common/system/autoinstall.py: Added.
185           - Added AutoInstaller class.
186           - Added sample/testing usage to the __main__ block.
187
188         * Scripts/webkitpy/thirdparty/__init__.py:
189           - Updated the autoinstall lines to use the new autoinstall methods.
190           - Added pep8.py to the list of auto-installed packages.
191           - Added a README file to the target autoinstallation directory
192             so users know that the directory is safe to delete.
193
194         * Scripts/webkitpy/thirdparty/autoinstall.py: Removed.
195           - This is replaced by the rewritten autoinstall
196             webkitpy/common/system/autoinstall.py.
197
198         * Scripts/webkitpy/thirdparty/autoinstalled/__init__.py: Removed.
199           - The target autoinstallation directory is now auto-generated.
200
201 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
202
203         Reviewed by Shinichiro Hamaji.
204
205         Tweak webkitpy's logtesting.LogTesting class to get more mileage out
206         of our unit tests that test log messages.
207
208         https://bugs.webkit.org/show_bug.cgi?id=36886
209
210         This patch adds to the LogTesting class's tearDown() method a line
211         asserting that the array of remaining log messages is empty.  This
212         ensures that no extra log messages are getting logged that the caller
213         might not be aware of or may have forgotten to check for.
214
215         * Scripts/webkitpy/common/system/logtesting.py:
216           - Modified the tearDown() method as described above.
217           - Also modified the assertMessages() method to clear the array
218             of log messages after asserting.
219
220 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
221
222         Reviewed by Adam Barth.
223
224         Added support for a --verbose-logging flag to test-webkitpy.
225
226         https://bugs.webkit.org/show_bug.cgi?id=36429
227
228         Verbose logging is useful for debugging test-webkitpy code that
229         runs before the actual unit tests -- things like autoinstalling and
230         unit-test auto-detection logic.  This is different from verbose
231         logging of the unit tests themselves (which corresponds to the
232         unittest module's --verbose flag).
233
234         * Scripts/test-webkitpy:
235           - In the configure_logging() method--
236             - Added an is_verbose_logging parameter that sets the logging
237               level to logging.DEBUG instead of logging.INFO.
238             - Changed the method to throttle the logging level on the
239               root logger's handler instead of directly on the root logger
240               itself.
241             - Enabled logging of the autoinstall module when the flag is set.
242
243         * Scripts/webkitpy/thirdparty/autoinstalled/__init__.py:
244           - Added a work-around for a bug in Python 2.6's logging module
245             that was discovered while working on this patch.
246
247 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
248
249         Reviewed by Adam Barth.
250
251         Enabled Python's logging module for webkit-patch, and replaced
252         deprecated_logging with Python logging in networktransaction.py.
253         This eliminates some spurious output when running test-webkitpy.
254
255         https://bugs.webkit.org/show_bug.cgi?id=36725
256
257         * Scripts/webkit-patch:
258           - Replaced the configure_logging() function with a call to
259             the new logutils.configure_logging() function.
260
261         * Scripts/webkitpy/common/net/networktransaction.py:
262           - Replaced the use of deprecated_logging with Python logging.
263
264         * Scripts/webkitpy/common/system/logutils.py:
265           - Added _default_handlers() which creates the default logging
266             handler for webkitpy.
267           - Added configure_logging() which configures default logging
268             for webkitpy.
269
270         * Scripts/webkitpy/common/system/logutils_unittest.py:
271           - Added unit tests for logutils.configure_logging().
272
273         * Scripts/webkitpy/style/checker.py:
274           - Refactored check-webkit-style's configure_logging() method
275             to call the new logutils.configure_logging().
276
277         * Scripts/webkitpy/style_references.py:
278           - Updated references as necessary.
279
280 2010-03-31  Eric Seidel  <eric@webkit.org>
281
282         Reviewed by Adam Barth.
283
284         webkit-patch land fails if not run from the root directory
285         https://bugs.webkit.org/show_bug.cgi?id=35822
286
287         The root of the problem was that ChangeLog.__init__ expects a path
288         relative to the current working directory, and SCM expects to
289         return paths relative to the SCM root.  Fix it by converting from
290         SCM-relative to absolute paths in Checkout.modified_changelogs
291
292         * Scripts/webkitpy/common/checkout/api.py:
293         * Scripts/webkitpy/common/checkout/api_unittest.py:
294
295 2010-03-31  Adam Barth  <abarth@webkit.org>
296
297         Reviewed by Eric Seidel.
298
299         Add more tests for webkitpy.common.checkout
300         https://bugs.webkit.org/show_bug.cgi?id=36926
301
302         We don't have a great way of testing checkout, sadly.
303
304         * Scripts/webkitpy/common/checkout/api_unittest.py:
305
306 2010-03-31  Adam Barth  <abarth@webkit.org>
307
308         Reviewed by Eric Seidel.
309
310         REGRESSION: EWS crashes on failure
311         https://bugs.webkit.org/show_bug.cgi?id=36924
312
313         Turns out we need to pass one more argument.  My test is kind of lame,
314         but at least it's there.
315
316         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
317         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
318
319 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
320
321         Unreviewed.
322
323         Fixed typo in WebKitTools/ChangeLog: opsys -> ospath.
324
325 2010-03-31  Adam Barth  <abarth@webkit.org>
326
327         Reviewed by Eric Seidel.
328
329         Make the EWS go faster by being optimistic
330         https://bugs.webkit.org/show_bug.cgi?id=36916
331
332         Have the EWS be optimistic that a patch will correctly build.  This
333         should speed up the common case by not requiring two builds for every
334         patch.
335
336         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
337         * Scripts/webkitpy/tool/commands/queues.py:
338
339 2010-03-31  Adam Barth  <abarth@webkit.org>
340
341         Reviewed by Eric Seidel.
342
343         Add the ability to restart sheriffbot from IRC
344         https://bugs.webkit.org/show_bug.cgi?id=36909
345
346         * Scripts/webkitpy/tool/bot/irc_command.py:
347         * Scripts/webkitpy/tool/bot/queueengine.py:
348         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
349         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
350
351 2010-03-31  Adam Barth  <abarth@webkit.org>
352
353         Reviewed by Eric Seidel.
354
355         Add win-ews to QueueStatusServer
356         https://bugs.webkit.org/show_bug.cgi?id=36876
357
358         The win-ews is still experimental, but it seems to be more or less
359         running.  We should show its results to the people.
360
361         * QueueStatusServer/model/queues.py:
362         * QueueStatusServer/templates/dashboard.html:
363         * QueueStatusServer/templates/statusbubble.html:
364
365 2010-03-30  Victor Wang  <victorw@chromium.org>
366
367         Reviewed by Eric Seidel.
368
369         Update rebaseline tool to check the release image diff binary and
370         fallback to debug if the release version does not exist.
371
372         https://bugs.webkit.org/show_bug.cgi?id=36245
373
374         * Scripts/webkitpy/layout_tests/port/base.py:
375         * Scripts/webkitpy/layout_tests/port/chromium.py:
376         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
377
378 2010-03-31  Eric Seidel  <eric@webkit.org>
379
380         Reviewed by Adam Barth.
381
382         Teach buildbot.py how to parse builder activity from /one_box_per_builder
383         https://bugs.webkit.org/show_bug.cgi?id=36898
384
385         I also removed some obsolete FIXMEs and
386         refactored one_box_per_builder parsing into multiple
387         methods for easier reading.
388
389         * Scripts/webkitpy/common/net/buildbot.py:
390         * Scripts/webkitpy/common/net/buildbot_unittest.py:
391
392 2010-03-31  Dirk Pranke  <dpranke@chromium.org>
393
394         Reviewed by Eric Seidel.
395
396         Fix logging in new-run-webkit-tests so that we don't report IMAGE
397         expected failures as unexpected passes when we run with pixel tests
398         disabled.
399
400         This change splits some of the logic embedded into the TestExpectations
401         classes out into separate pure functions (result_was_expected,
402         remove_image_failures) to make them easier to test. This also adds
403         a parameter to matches_an_expected_result() to indicate whether or
404         not pixel test results should be included in the expectations.
405
406         https://bugs.webkit.org/show_bug.cgi?id=36771
407
408         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
409         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py:
410         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
411
412 2010-03-31  Chris Jerdonek  <cjerdonek@webkit.org>
413
414         Reviewed by Eric Seidel.
415
416         In webkitpy, refactored two calls to os.path.relpath() replacements
417         to use a common method.
418
419         https://bugs.webkit.org/show_bug.cgi?id=36891
420
421         * Scripts/webkitpy/common/net/bugzilla.py:
422           - Replaced the relpath implementation with a call to
423             webkitpy.common.system.ospath.relpath().
424
425         * Scripts/webkitpy/common/system/ospath.py: Added.
426           - Moved the relpath() implementation from style/main.py.
427
428         * Scripts/webkitpy/common/system/ospath_unittest.py: Added.
429           - Moved the relpath() unit tests from style/main_unittest.py.
430
431         * Scripts/webkitpy/style/main.py:
432           - Replaced the relpath implementation with a call to
433             webkitpy.common.system.ospath.relpath().
434
435         * Scripts/webkitpy/style/main_unittest.py:
436           - Moved the relpath unit tests to ospath_unittest.py.
437
438 2010-03-31  Adam Barth  <abarth@webkit.org>
439
440         Reviewed by Eric Seidel.
441
442         Add a Builder.force_build method
443         https://bugs.webkit.org/show_bug.cgi?id=36875
444
445         We plan to eventually use this in SheriffBot to break deadlocks created
446         by flaky tests.
447
448         * Scripts/webkitpy/common/net/buildbot.py:
449
450 2010-03-31  Adam Barth  <abarth@webkit.org>
451
452         Reviewed by Eric Seidel.
453
454         webkit-patch reads wrong bug url from unified diff context
455         https://bugs.webkit.org/show_bug.cgi?id=36477
456
457         Instead of trying to figure out the bug_id from the diff, we should
458         just get the information from the Checkout object, which understands
459         these concepts.
460
461         * Scripts/webkitpy/common/checkout/api.py:
462         * Scripts/webkitpy/common/checkout/commitinfo.py:
463         * Scripts/webkitpy/tool/commands/download.py:
464         * Scripts/webkitpy/tool/commands/upload.py:
465         * Scripts/webkitpy/tool/mocktool.py:
466
467 2010-03-31  Adam Barth  <abarth@webkit.org>
468
469         Reviewed by Eric Seidel.
470
471         webkit-patch commit-queue should land patches optimistically
472         https://bugs.webkit.org/show_bug.cgi?id=34187
473
474         This patch adds an optimistic path to commit-queue and a "fail twice"
475         requirement for rejecting patches.  That means we'll land good patches
476         faster (via the optmistic first run) and we'll reject many fewer
477         patches due to flaky tests.
478
479         * Scripts/webkitpy/tool/commands/queues.py:
480
481 2010-03-31  Diego Gonzalez  <diego.gonzalez@openbossa.org>
482
483         Reviewed by Kenneth Rohde Christiansen.
484
485         [Qt] Custom user agent for user agent switcher
486         https://bugs.webkit.org/show_bug.cgi?id=36757
487
488         * QtLauncher/main.cpp:
489         (LauncherWindow::showUserAgentDialog):
490
491 2010-03-31  Eric Seidel  <eric@webkit.org>
492
493         Reviewed by Adam Barth.
494
495         path to committers.py in commit-queue rejection message is wrong
496         https://bugs.webkit.org/show_bug.cgi?id=36865
497
498         This fix would have only been 3 lines long if we had
499         1. Had access to an SCM object or tool to give us the checkout root
500         2. Been able to depend on Python 2.6
501         Instead I've added a bunch of hack code, but at least now
502         we should never have to update this string again as the location
503         of committers.py is fully dynamically discovered. :p
504
505         * Scripts/webkitpy/common/net/bugzilla.py:
506         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
507
508 2010-03-31  Shinichiro Hamaji  <hamaji@chromium.org>
509
510         Unreviewed test fix for r56809.
511
512         webkit-patch what-broke throws exception
513         https://bugs.webkit.org/show_bug.cgi?id=36852
514
515         * Scripts/webkitpy/common/checkout/api_unittest.py:
516
517 2010-03-30  Chris Jerdonek  <cjerdonek@webkit.org>
518
519         Rubber stamped by Dave Levin.
520
521         Made check-webkit-style less chatty.
522
523         Examples include:
524          - https://bugs.webkit.org/show_bug.cgi?id=36866#c4
525          - https://bugs.webkit.org/show_bug.cgi?id=36472#c9
526
527         * Scripts/webkitpy/style/checker.py:
528           - Changed unrecognized file type log message from info to debug.
529
530 2010-03-30  Kevin Ollivier  <kevino@theolliviers.com>
531
532         [wx] Build fix after new method added.
533
534         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
535         (LayoutTestController::callShouldCloseOnWebView):
536
537 2010-03-30  Eric Seidel  <eric@webkit.org>
538
539         Reviewed by Adam Barth.
540
541         webkit-patch what-broke throws exception
542         https://bugs.webkit.org/show_bug.cgi?id=36852
543
544         * Scripts/webkitpy/common/checkout/api.py: Add missing import StringIO.
545         * Scripts/webkitpy/common/checkout/api_unittest.py: Test the function which previously threw and exception.
546
547 2010-03-30  Alexey Proskuryakov  <ap@apple.com>
548
549         Reviewed by Darin Adler.
550
551         https://bugs.webkit.org/show_bug.cgi?id=36616
552         Dvorak-Qwerty keyboard layout gives unexpected results in javascript keydown
553
554         https://bugs.webkit.org/show_bug.cgi?id=36797
555         For non-Roman layouts, keydown Event.keyCode is always 0
556
557         * DumpRenderTree/mac/EventSendingController.mm:
558         (-[EventSendingController keyDown:withModifiers:withLocation:]): Generate a correct keyCode
559         for keys used in tests (we used to always pass 0 for 'A').
560
561 2010-03-30  Adam Barth  <abarth@webkit.org>
562
563         Reviewed by Eric Seidel.
564
565         Implement win-ews
566         https://bugs.webkit.org/show_bug.cgi?id=36809
567
568         * Scripts/webkitpy/common/config/ports.py:
569         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
570
571 2010-03-30  Chris Jerdonek  <cjerdonek@webkit.org>
572
573         Reviewed by Eric Seidel.
574
575         Adjusted test-webkitpy to delete all orphaned *.pyc files
576         from webkitpy/ prior to importing any modules from webkitpy.
577         This ensures that no import statements in webkitpy falsely
578         succeed because of leftover *.pyc files.
579
580         https://bugs.webkit.org/show_bug.cgi?id=36599
581
582         * Scripts/test-webkitpy:
583           - Added _clean_pyc_files() to delete orphaned *.pyc files
584             from a directory.
585           - Added _clean_webkitpy_with_test() to call and test
586             _clean_pyc_files().
587           - Moved the "import webkitpy.python24.versioning" statement
588             from the top of the module to the init() method -- immediately
589             after the call to _clean_webkitpy_with_test().
590
591 2010-03-30  Fumitoshi Ukai  <ukai@chromium.org>
592
593         Reviewed by Shinichiro Hamaji.
594
595         [Chromium-Win] subprocess.call should be called with stdin=open(os.devnull,'r')
596         https://bugs.webkit.org/show_bug.cgi?id=36811
597
598         subproess.Popen() on Python 2.4/Windows with stdout,stdout, but no stdin will fail, because it uses return value of GetStdHandle(STD_INPUT_HANDLE), but DuplicateHandle requires integer, not the handle.
599         We don't need stdin, so use devnull as stdin.
600         Same as https://bugs.webkit.org/show_bug.cgi?id=36586
601
602         * Scripts/webkitpy/layout_tests/port/chromium_win.py: open os.devnull for stdin
603
604 2010-03-29  Eric Seidel  <eric@webkit.org>
605
606         Unreviewed, build fix only.
607
608         * Scripts/webkitpy/tool/steps/validatereviewer.py: Add missing import.
609
610 2010-03-29  Hayato Ito  <hayato@chromium.org>
611
612         Reviewed by Shinichiro Hamaji.
613
614         Remove '_flymake' suffix from base part of file name so that
615         check-webkit-style uses a correct header guard name when it is called from Emacs's flymake.
616
617         https://bugs.webkit.org/show_bug.cgi?id=36573
618
619         * Scripts/webkitpy/style/processors/cpp.py:
620         * Scripts/webkitpy/style/processors/cpp_unittest.py:
621
622 2010-03-29  Chris Jerdonek  <cjerdonek@webkit.org>
623
624         Reviewed by Eric Seidel.
625
626         Get the following test-webkitpy unit test working again:
627         scm_unittest.SVNTest.test_svn_apply().
628
629         https://bugs.webkit.org/show_bug.cgi?id=36696
630
631         * Scripts/webkitpy/common/checkout/scm_unittest.py:
632           - Add leading spaces to the empty lines of the ChangeLog strings.
633           - Manually set the _reviewer attribute on the Attachment object
634             to get the tests to pass.
635
636 2010-03-29  Martin Robinson  <mrobinson@webkit.org>
637
638         Reviewed by Holger Freyther.
639
640         [GTK] suppress (un)desired launcher output that can make layout test to fail with stderr
641         https://bugs.webkit.org/show_bug.cgi?id=36390
642
643         Suppress debugging messages sent to the GLib logger during DRT runs.
644
645         * DumpRenderTree/gtk/DumpRenderTree.cpp:
646         (logHandler): Added.
647         (main): Use logHandler as the default GLib log message handler.
648
649 2010-03-29  Eric Seidel  <eric@webkit.org>
650
651         Reviewed by Adam Barth.
652
653         sheriff-bot should comment on bugs when builders break
654         https://bugs.webkit.org/show_bug.cgi?id=36786
655
656         * Scripts/webkitpy/tool/commands/sheriffbot.py:
657          - Add a new _post_blame_comment_to_bug and all it from process_work_item
658          - Move commit-queue logic into _post_rollout_patch to make its api match the other _post commands.
659         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
660          - Test the new _post_blame_comment_to_bug call
661
662 2010-03-29  Eric Seidel  <eric@webkit.org>
663
664         Reviewed by Adam Barth.
665
666         sheriff-bot fails to get information about certain builds
667         https://bugs.webkit.org/show_bug.cgi?id=36768
668
669         This seems to be caused by:
670         http://buildbot.net/trac/ticket/753
671         I have no work-around, but for now at least we're logging
672         the error better.  I also added allow_none to our ServerProxy
673         creation in case that fixes things for other versions of python.
674
675         * Scripts/webkitpy/common/net/buildbot.py:
676
677 2010-03-29  Victor Wang  <victorw@chromium.org>
678
679         Reviewed by Adam Barth.
680
681         Add sign in/out link to TestResults appengine
682
683         Add a link to main menu for sign in/out to this appengine.
684         People signed in with admin privilege could perform
685         actions that are only allowed to admins like deleting files.
686
687         https://bugs.webkit.org/show_bug.cgi?id=36767
688
689         * TestResultServer/handlers/menu.py:
690         * TestResultServer/stylesheets/menu.css:
691         (.sign):
692         * TestResultServer/templates/menu.html:
693
694 2010-03-29  Eric Seidel  <eric@webkit.org>
695
696         Reviewed by Adam Barth.
697
698         ValidateReviewer step is draconian and un-tested
699         https://bugs.webkit.org/show_bug.cgi?id=36792
700
701         ValidateReviewer logic was commented out in
702         http://trac.webkit.org/changeset/56744
703         That was a symptom of the fact that validatereviewer.py
704         is too inflexible to be used when real humans are driving webkit-patch.
705         For now we just disable ValidateReviewer when humans are at the keyboard.
706
707         * Scripts/webkitpy/tool/steps/validatereviewer.py:
708          - Only run when in non-interactive mode.
709         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Added.
710          - Test our validation logic to make sure it's sane.
711
712 2010-03-29  Chris Jerdonek  <cjerdonek@webkit.org>
713
714         Reviewed by Shinichiro Hamaji.
715
716         Eliminate explicit slash characters from check-webkit-style's
717         _rel_path() method to make its implementation more platform
718         independent.
719
720         https://bugs.webkit.org/show_bug.cgi?id=36759
721
722         * Scripts/webkitpy/style/main.py:
723           - Changed to use os.sep instead of slash_chars "/\\".  This can
724             be done since os.path.abspath() converts slashes to os.sep.
725
726 2010-03-29  Dirk Pranke  <dpranke@chromium.org>
727
728         Reviewed by Dimitri Glazkov.
729
730         Change new-run-webkit-tests to not use more than four threads by
731         default on the mac port until
732         https://bugs.webkit.org/show_bug.cgi?id=36622 is fixed.
733
734         https://bugs.webkit.org/show_bug.cgi?id=36687
735
736         * Scripts/webkitpy/layout_tests/port/mac.py:
737
738 2010-03-29  Dirk Pranke  <dpranke@chromium.org>
739
740         Reviewed by Dimitri Glazkov.
741
742         Reformat port/mac.py to fit witin 80 columns for PEP-8 compliance.
743
744         https://bugs.webkit.org/show_bug.cgi?id=36691
745
746         * Scripts/webkitpy/layout_tests/port/mac.py:
747
748 2010-03-29  Eric Seidel  <eric@webkit.org>
749
750         Reviewed by Adam Barth.
751
752         new-run-webkit-tests fails java/lc3 on a clean checkout
753         https://bugs.webkit.org/show_bug.cgi?id=36078
754
755         * Scripts/webkitpy/layout_tests/port/mac.py:
756          - Build the java support files in check_build
757          - Unwrap a line which would still fit under 80col
758
759 2010-02-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
760
761         Reviewed by Simon Fraser.
762
763         Add support for Widgets 1.0: View Mode Media Feature
764         https://bugs.webkit.org/show_bug.cgi?id=35446
765
766         Add hooks to the Qt DRT for testing the view mode media feature.
767
768         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
769         (LayoutTestController::setViewModeMediaFeature):
770         * DumpRenderTree/qt/LayoutTestControllerQt.h:
771
772 2010-03-29  Adam Barth  <abarth@webkit.org>
773
774         Unreviewed.  Update expected results for unit tests.
775
776         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
777         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
778
779 2010-03-29  Adam Barth  <abarth@webkit.org>
780
781         Unreviewed.  I think Eric meant svn_revision.
782
783         * Scripts/webkitpy/tool/commands/sheriffbot.py:
784
785 2010-03-26  Eric Seidel  <eric@webkit.org>
786
787         Reviewed by Adam Barth.
788
789         webkit-patch commit-queue should notice if it breaks builders (and roll out its own changes)
790         https://bugs.webkit.org/show_bug.cgi?id=29311
791
792         Now that we have sheriff-bot watching the tree, it can post
793         rollout patches on behalf of the commit queue.
794
795         * Scripts/webkitpy/common/checkout/commitinfo.py: add responsible_parties()
796         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py: test responsible_parties()
797         * Scripts/webkitpy/tool/commands/sheriffbot.py:
798          - Break IRC logic out into _post_irc_warning for easier testing.
799          - Add _post_rollout_patch for posting rollout patches to bugzilla.
800         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
801          - Test _rollout_reason
802         * Scripts/webkitpy/tool/grammar.py:
803          - Fix join_with_separators to not add Adam's "oxford comma" for two item lists.
804         * Scripts/webkitpy/tool/grammar_unittest.py:
805          - Test join_with_separators
806
807 2010-03-29  Adam Barth  <abarth@webkit.org>
808
809         Reviewed by Eric Seidel.
810
811         Sheriffbot should actually run commands
812         https://bugs.webkit.org/show_bug.cgi?id=36776
813
814         Some minor changes to Sheriffbot:
815
816         1) We should actually run commands (by giving control back to the
817         command processing object.
818
819         2) Use URLs instead of just numbers to represent SVN revisions (making
820         it easier to folks in IRC ot followup).
821
822         * Scripts/webkitpy/tool/bot/irc_command.py:
823         * Scripts/webkitpy/tool/bot/queueengine.py:
824         * Scripts/webkitpy/tool/commands/sheriffbot.py:
825
826 2010-03-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
827
828         Reviewed by Antti Koivisto.
829
830         Renaming of frame flattening LayoutTestController method
831         to setFrameFlatteningEnabled(bool)
832
833         * DumpRenderTree/LayoutTestController.cpp:
834         (setFrameFlatteningEnabledCallback):
835         (LayoutTestController::staticFunctions):
836         * DumpRenderTree/LayoutTestController.h:
837         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
838         (LayoutTestController::setFrameFlatteningEnabled):
839         * DumpRenderTree/mac/DumpRenderTree.mm:
840         (resetDefaultsToConsistentValues):
841         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
842         (LayoutTestController::setFrameFlatteningEnabled):
843         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
844         (WebCore::WebPage::resetSettings):
845         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
846         (LayoutTestController::setFrameFlatteningEnabled):
847         * DumpRenderTree/qt/LayoutTestControllerQt.h:
848         * DumpRenderTree/win/DumpRenderTree.cpp:
849         (resetDefaultsToConsistentValues):
850         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
851         (LayoutTestController::setFrameFlatteningEnabled):
852         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
853         (LayoutTestController::setFrameFlatteningEnabled):
854
855 2010-03-28  Gustavo Noronha Silva  <gns@gnome.org>
856
857         No review, rolling out r56679.
858         http://trac.webkit.org/changeset/56679
859         https://bugs.webkit.org/show_bug.cgi?id=36454
860
861         Lots of tests broken.
862
863         * DumpRenderTree/gtk/DumpRenderTree.cpp:
864         (createWebView):
865
866 2010-03-28  Chris Jerdonek  <cjerdonek@webkit.org>
867
868         Unreviewed.
869
870         Fixed typo in deprecated_logging_unittest.py, which is masking
871         sys.stderr while running test-webkitpy.
872
873         See also-- https://bugs.webkit.org/show_bug.cgi?id=36725#c3
874
875         * Scripts/webkitpy/common/system/deprecated_logging_unittest.py:
876
877 2010-03-28  Chris Jerdonek  <cjerdonek@webkit.org>
878
879         Reviewed by Shinichiro Hamaji.
880
881         Renamed check-webkit-style's --debug flag to --verbose to be more
882         in line with other WebKit scripts.  Also renamed the current
883         --verbose flag to --min-confidence to allow the --debug rename.
884
885         https://bugs.webkit.org/show_bug.cgi?id=36521
886
887         We also renamed the internal "verbose" variables to "confidence" or
888         "min_confidence," as appropriate, to avoid confusion with the
889         --verbose flag, and because the new names are more accurate.
890
891         * Scripts/check-webkit-style:
892           - Renamed is_debug to is_verbose.
893
894         * Scripts/webkitpy/style/checker.py:
895           - Renamed _DEFAULT_VERBOSITY to _DEFAULT_CONFIDENCE.
896           - Renamed "verbosity" parameters to "min_confidence" throughout.
897           - Renamed configure_logging()'s is_debug parameter to is_verbose.
898
899         * Scripts/webkitpy/style/checker_unittest.py:
900           - Updated the unit tests as necessary.
901
902         * Scripts/webkitpy/style/error_handlers.py:
903           - Updated the call to StyleCheckerConfiguration.write_style_error().
904
905         * Scripts/webkitpy/style/error_handlers_unittest.py:
906           - Updated the unit tests as necessary.
907
908         * Scripts/webkitpy/style/optparser.py:
909           - Updated the usage string with the new flag names.
910           - Renamed the verbosity parameter to min_confidence throughout.
911           - Renamed the is_debug parameter to is_verbose throughout.
912
913         * Scripts/webkitpy/style/optparser_unittest.py:
914           - Updated the unit tests as necessary.
915
916         * Scripts/webkitpy/style/processors/cpp.py:
917           - Renamed the verbosity parameter to min_confidence throughout.
918
919         * Scripts/webkitpy/style/processors/cpp_unittest.py:
920           - Updated the unit tests as necessary.
921
922 2010-03-28  Chris Jerdonek  <cjerdonek@webkit.org>
923
924         Unreviewed.
925
926         Added back a line that accidentally got deleted in r56690.
927
928         * Scripts/check-webkit-style:
929
930 2010-03-28  Chris Jerdonek  <cjerdonek@webkit.org>
931
932         Reviewed by Shinichiro Hamaji.
933
934         Add to check-webkit-style support for checking directories.
935
936         https://bugs.webkit.org/show_bug.cgi?id=35234
937
938         * Scripts/check-webkit-style:
939           - Replaced the call to check_file() with a call to check_paths().
940
941         * Scripts/webkitpy/style/checker.py:
942           - In the StyleChecker class:
943             - Added a check_paths() method that accepts a list of paths
944               to files and directories.
945             - Added a _check_directory() method that checks the files
946               in a directory.
947
948         * Scripts/webkitpy/style/checker_unittest.py:
949           - Added a StyleCheckerCheckPathsTest to unit-test the new
950             check_paths() method.
951
952         * Scripts/webkitpy/style/optparser.py:
953           - Updated the usage string.
954
955 2010-03-28  Chris Jerdonek  <cjerdonek@webkit.org>
956
957         Reviewed by Shinichiro Hamaji.
958
959         Changed check-webkit-style to convert paths to paths relative to
960         the checkout root when invoking check-webkit-style with path
961         arguments.  Also added warning messages where appropriate.
962
963         https://bugs.webkit.org/show_bug.cgi?id=35498
964
965         Converting paths to paths relative to the checkout root ensures
966         that style checking will behave as expected (since path-specific
967         rules assume input paths are relative to a source root).
968
969         * Scripts/check-webkit-style:
970           - Added debug logging of whether the current directory was found
971             to be in a WebKit checkout.
972           - Added the found_checkout parameter to the call to parser.parse().
973           - Renamed the files variable to paths.
974           - Added a call to change_directory() prior to checking style.
975
976         * Scripts/webkitpy/style/checker.py:
977           - For StyleChecker.check_file():
978             - Updated the docstring.
979             - Added two log messages.
980
981         * Scripts/webkitpy/style/checker_unittest.py:
982           - Updated a call to parser.parse() with the found_checkout parameter.
983
984         * Scripts/webkitpy/style/main.py: Added.
985           - Added a new file so the code in this patch could be unit-tested,
986             as opposed to adding new code to check-webkit-style.
987           - Added the method _rel_path() as a substitute for os.path.relpath(),
988             which is available only in Python 2.6.
989           - Added the method change_directory(), which contains most of the
990             new functionality in this patch.
991
992         * Scripts/webkitpy/style/main_unittest.py: Added.
993           - Added RelPathTest to test main._rel_path().
994           - Added ChangeDirectoryTest to test main.change_directory().
995
996         * Scripts/webkitpy/style/optparser.py:
997           - Updated check-webkit-style's usage string.
998           - For the ArgumentParser.parse() method:
999             - Added a found_checkout parameter.
1000             - Renamed filenames to paths.
1001             - Added logic so that an error is raised if no paths are passed
1002               if found_checkout is False.
1003
1004         * Scripts/webkitpy/style/optparser_unittest.py:
1005           - Updated the ArgumentParser.parse() unit tests to include
1006             coverage for the new found_checkout parameter.
1007
1008         * Scripts/webkitpy/style/unittests.py:
1009           - Added an import statement for main_unittest.
1010
1011         * Scripts/webkitpy/style_references.py:
1012           - Renamed SimpleScm to WebKitCheckout.
1013           - Added a detect_checkout() function to allow returning None
1014             instead of a WebKitCheckout instance if no checkout is found.
1015           - Renamed checkout_root to root_path.
1016
1017 2010-03-27  Sergio Villar Senin  <svillar@igalia.com>
1018
1019         Reviewed by Eric Seidel.
1020
1021         Print didHandleOnloadEventsForFrame in the callback of
1022         onload-event signal comming from frame loader
1023
1024         [GTK] Improve reporting of frame loader callbacks in DRT
1025         https://bugs.webkit.org/show_bug.cgi?id=36454
1026
1027         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1028         (webViewOnloadEvent):
1029         (createWebView): added connection to signal::onload-event and
1030         signal callback
1031
1032 2010-03-27  Sergio Villar Senin  <svillar@igalia.com>
1033
1034         Reviewed by Eric Seidel.
1035
1036         Print didCommitLoadForFrame in the callback of signal::load-committed
1037
1038         [GTK] Improve reporting of frame loader callbacks in DRT
1039         https://bugs.webkit.org/show_bug.cgi?id=36454
1040
1041         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1042         (webViewLoadCommitted):
1043         (createWebView): added connection to sinal::load-committed and
1044         signal callback
1045
1046 2010-03-27  Sergio Villar Senin  <svillar@igalia.com>
1047
1048         Reviewed by Eric Seidel.
1049
1050         Print didStartProvisionalLoadForFrame in the callback of
1051         notify::load-status property change notification
1052
1053         [GTK] Improve reporting of frame loader callbacks in DRT
1054         https://bugs.webkit.org/show_bug.cgi?id=36454
1055
1056         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1057         (webInspectorCloseWindow):
1058         (webInspectorInspectWebView):
1059         (createWebView): added connection to notify::load-status and
1060         signal callback
1061
1062 2010-03-27  Chris Jerdonek  <cjerdonek@webkit.org>
1063
1064         Reviewed by Adam Barth.
1065
1066         In webkitpy/, deleted the /unittests.py files since test-webkitpy
1067         now auto-detects all *_unittest.py files.
1068
1069         https://bugs.webkit.org/show_bug.cgi?id=36712
1070
1071         * Scripts/webkitpy/common/net/irc/unittests.py: Removed.
1072         * Scripts/webkitpy/common/system/unittests.py: Removed.
1073         * Scripts/webkitpy/common/thread/unittests.py: Removed.
1074         * Scripts/webkitpy/common/unittests.py: Removed.
1075         * Scripts/webkitpy/python24/unittests.py: Removed.
1076         * Scripts/webkitpy/style/unittests.py: Removed.
1077         * Scripts/webkitpy/tool/unittests.py: Removed.
1078         * Scripts/webkitpy/unittests.py: Removed.
1079
1080 2010-03-27  Sergio Villar Senin  <svillar@igalia.com>
1081
1082         Reviewed by Eric Seidel.
1083
1084         Add a CR after printing didFinishDocumentLoadForFrame
1085
1086         [GTK] Improve reporting of frame loader callbacks in DRT
1087         https://bugs.webkit.org/show_bug.cgi?id=36454
1088
1089         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1090         (webViewLoadFinished):
1091
1092 2010-03-27  Chris Jerdonek  <cjerdonek@webkit.org>
1093
1094         Rubber-stamped by Adam Barth.
1095
1096         Fixed the name of a unit test file in webkitpy.
1097
1098         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py.
1099         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py: Removed.
1100
1101 2010-03-26  Chris Jerdonek  <cjerdonek@webkit.org>
1102
1103         Reviewed by Adam Barth.
1104
1105         The test-webkitpy script now automatically detects all unit-test
1106         files in webkitpy/.  This lets us eliminate the need to have and
1107         maintain all of the unittests.py files.
1108
1109         https://bugs.webkit.org/show_bug.cgi?id=36591
1110
1111         * Scripts/test-webkitpy:
1112           - Replaced the "from webkitpy.unittests import *" with a call
1113             to webkitpy.test.main.Tester().run_tests().
1114
1115         * Scripts/webkitpy/test/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.
1116           - Required file for the new webkitpy/test/ directory.
1117
1118         * Scripts/webkitpy/test/main.py: Added.
1119           - Added a Tester class that contains the following methods:
1120             - _find_unittest_files() to detect all the unit-test files.
1121             - _modules_from_paths() to convert the paths to the unit-test
1122               files to fully-qualified module names.
1123             - run_tests() which calls the above two methods and then passes
1124               the module names to Python's unittest module.
1125
1126 2010-03-27  Robert Hogan  <robert@webkit.org>
1127
1128         Reviewed by Simon Fraser.
1129
1130         [Qt/Win] Add support to unix and windows NS plugin for executing scripts on setWindow.
1131
1132         https://bugs.webkit.org/show_bug.cgi?id=36701
1133
1134         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1135         (webkit_test_plugin_new_instance): Add onSetWindow.
1136         (webkit_test_plugin_destroy_instance): Add onSetWindow.
1137         (webkit_test_plugin_set_window): Add onSetWindow.
1138         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1139         (NPP_New): Add onSetWindow.
1140         (NPP_Destroy): Add onSetWindow.
1141         (NPP_SetWindow): Add onSetWindow.
1142
1143 2010-03-26  Robert Hogan  <robert@roberthogan.net>
1144
1145         Reviewed by Simon Hausmann.
1146
1147         Allow plugins implemented by the application, such as mimetype 'x-qt-plugin',
1148          when pluginsEnabled is false.
1149
1150         Add support for LayoutTestController.WebKitPluginsEnabled
1151
1152         https://bugs.webkit.org/show_bug.cgi?id=32196
1153
1154         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1155         (resetDefaultsToConsistentValues):
1156         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1157         (copyWebSettingKey):
1158         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1159         (WebCore::WebPage::resetSettings):
1160         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1161         (LayoutTestController::overridePreference):
1162
1163 2010-03-26  Adam Barth  <abarth@webkit.org>
1164
1165         Reviewed by Eric Seidel.
1166
1167         Add some basic IRC commands to sheriffbot
1168         https://bugs.webkit.org/show_bug.cgi?id=36684
1169
1170         Adds support for sheriffbot to respond to a "hi" command and a
1171         "last-green-revision" command.  It's lame that we're rebuilding
1172         MultiCommandTool, but as discussed in person we'll intergrate the two
1173         once we see what the requirements are.
1174
1175         * Scripts/webkitpy/tool/bot/irc_command.py: Added.
1176         * Scripts/webkitpy/tool/bot/queueengine.py:
1177         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1178         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
1179         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Added.
1180         * Scripts/webkitpy/tool/commands/queues.py:
1181         * Scripts/webkitpy/tool/commands/queuestest.py:
1182         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1183         * Scripts/webkitpy/tool/main.py:
1184         * Scripts/webkitpy/tool/mocktool.py:
1185         * Scripts/webkitpy/tool/unittests.py:
1186
1187 2010-03-26  Adam Barth  <abarth@webkit.org>
1188
1189         Unreviewed.  More errors in the IRC module.  I have no idea how to test
1190         ircbot.py, which is too bad.  Hopefully we've abstracted it away enough
1191         that we don't have to touch it very much after this patch.
1192
1193         * Scripts/webkitpy/common/net/irc/ircbot.py:
1194
1195 2010-03-26  Adam Barth  <abarth@webkit.org>
1196
1197         Unreviewed.  Add a missing "_".
1198
1199         * Scripts/webkitpy/common/net/irc/ircproxy.py:
1200         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py: Added.
1201         * Scripts/webkitpy/common/net/irc/unittests.py:
1202
1203 2010-03-26  Adam Barth  <abarth@webkit.org>
1204
1205         Unreviewed.  Fix a the commit queue after my recent change.
1206
1207         * Scripts/webkitpy/tool/bot/queueengine.py:
1208
1209 2010-03-26  Dirk Pranke  <dpranke@chromium.org>
1210
1211         Unreviewed fix.
1212
1213         Fix the return value for port/base.diff_image (changed from 1/0 to
1214         True/False in bug 34826.
1215
1216         * Scripts/webkitpy/layout_tests/port/base.py:
1217
1218 2010-03-26  Dirk Pranke  <dpranke@chromium.org>
1219
1220         Reviewed by Eric Seidel.
1221
1222         Change the Mac port of new-run-webkit-tests to look for a
1223         test_expectations.txt file in addition to the Skipped files, so we
1224         can track pixel failures.
1225
1226         https://bugs.webkit.org/show_bug.cgi?id=36619
1227
1228         * Scripts/webkitpy/layout_tests/port/mac.py:
1229
1230 2010-03-26  Dirk Pranke  <dpranke@chromium.org>
1231
1232         Reviewed by Eric Seidel.
1233
1234         Implement pixel tests (image diff) properly on the Mac port.
1235
1236         This change introduces a new "ServerPocess" class that can be used
1237         to manage processes that the run-webkit-tests harness forks off and
1238         expects to stay up for longer than a single request/response session.
1239         Both DumpRenderTree and ImageDiff use this style of communication,
1240         although the current code forks off a new ImageDiff for each diff
1241         (We need to restructure other parts of the code to be able to do this
1242         safely in a multi-threaded environment).
1243
1244         Also, now that the ServerProcess abstraction exists, we can probably
1245         clean up and simplify some of the thread management logic in
1246         test_shell_thread as well.
1247
1248         https://bugs.webkit.org/show_bug.cgi?id=34826
1249
1250         * Scripts/webkitpy/layout_tests/port/mac.py:
1251         * Scripts/webkitpy/layout_tests/port/server_process.py:
1252         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1253
1254 2010-03-26  Sergio Villar Senin  <svillar@igalia.com>
1255
1256         Reviewed by Eric Seidel.
1257
1258         Print didFinishLoadForFrame outcome in DRT
1259
1260         [GTK] Improve reporting of frame loader callbacks in DRT
1261         https://bugs.webkit.org/show_bug.cgi?id=36454
1262
1263         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1264         (webViewLoadCommitted):
1265
1266 2010-03-26  Eric Seidel  <eric@webkit.org>
1267
1268         Unreviewed test fix.
1269         My change conflicted with one of Adam's causing test-webkitpy to fail.
1270
1271         Move commit_message_for_this_commit from scm to checkout
1272         https://bugs.webkit.org/show_bug.cgi?id=36629
1273
1274         * Scripts/webkitpy/common/checkout/api_unittest.py:
1275          - modified_changelogs is now on Checkout instead of scm.
1276
1277 2010-03-26  Adam Barth  <abarth@webkit.org>
1278
1279         Reviewed by Eric Seidel.
1280
1281         Refactor IRCBot controller logic to allow for commands
1282         https://bugs.webkit.org/show_bug.cgi?id=36676
1283
1284         We need to move the controller logic into the tool package so it can
1285         know about commands.  The changes to queueengine could go in a
1286         different patch, but we're going to need it anyway.
1287
1288         * Scripts/webkitpy/common/config/irc.py: Added.
1289         * Scripts/webkitpy/common/net/irc/ircbot.py:
1290         * Scripts/webkitpy/common/net/irc/ircproxy.py:
1291         * Scripts/webkitpy/tool/bot/queueengine.py:
1292         * Scripts/webkitpy/tool/bot/sheriffircbot.py: Added.
1293         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1294         * Scripts/webkitpy/tool/main.py:
1295         * Scripts/webkitpy/tool/mocktool.py:
1296
1297 2010-03-26  Adam Barth  <abarth@webkit.org>
1298
1299         Rubber stamped by Eric Seidel.
1300
1301         Move the threading code into its own module.  (It has nothing to do with IRC.)
1302
1303         * Scripts/webkitpy/common/net/irc/ircbot.py:
1304         * Scripts/webkitpy/common/net/irc/ircproxy.py:
1305         * Scripts/webkitpy/common/net/irc/messagepump.py: Removed.
1306         * Scripts/webkitpy/common/net/irc/messagepump_unittest.py: Removed.
1307         * Scripts/webkitpy/common/net/irc/threadedmessagequeue.py: Removed.
1308         * Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py: Removed.
1309         * Scripts/webkitpy/common/net/irc/unittests.py:
1310         * Scripts/webkitpy/common/thread: Added.
1311         * Scripts/webkitpy/common/thread/__init__.py: Added.
1312         * Scripts/webkitpy/common/thread/messagepump.py: Copied from Scripts/webkitpy/common/net/irc/messagepump.py.
1313         * Scripts/webkitpy/common/thread/messagepump_unittest.py: Copied from Scripts/webkitpy/common/net/irc/messagepump_unittest.py.
1314         * Scripts/webkitpy/common/thread/threadedmessagequeue.py: Copied from Scripts/webkitpy/common/net/irc/threadedmessagequeue.py.
1315         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py: Copied from Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py.
1316         * Scripts/webkitpy/common/thread/unittests.py: Added.
1317         * Scripts/webkitpy/common/unittests.py:
1318
1319 2010-03-26  Eric Seidel  <eric@webkit.org>
1320
1321         Reviewed by Adam Barth.
1322
1323         Move commit_message_for_this_commit from scm to checkout
1324         https://bugs.webkit.org/show_bug.cgi?id=36629
1325
1326         Finally add some basic unit testing for Checkout.commit_message_for_this_commit
1327
1328         * Scripts/webkitpy/common/checkout/api.py:
1329         * Scripts/webkitpy/common/checkout/api_unittest.py: Added.
1330         * Scripts/webkitpy/common/unittests.py:
1331
1332 2010-03-26  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1333
1334         [Qt] User Agent Switcher on QtLauncher
1335         https://bugs.webkit.org/show_bug.cgi?id=36451
1336
1337         Patch by Diego Gonzalez <diego.gonzalez@openbossa.org> on 2010-03-26
1338         Reviewed by Simon Hausmann.
1339
1340         Make possible to change the QtLauncher user agent via
1341         a predefined list.
1342
1343         * QtLauncher/QtLauncher.pro:
1344         * QtLauncher/QtLauncher.qrc: Added.
1345         * QtLauncher/main.cpp:
1346         (LauncherWindow::showUserAgentDialog):
1347         (LauncherWindow::createChrome):
1348         * QtLauncher/useragentlist.txt: Added.
1349         * QtLauncher/webpage.cpp:
1350         (WebPage::userAgentForUrl):
1351         * QtLauncher/webpage.h:
1352         (WebPage::setUserAgent):
1353
1354 2010-03-26  Victor Wang  <victorw@chromium.org>
1355
1356         Reviewed by Adam Barth.
1357
1358         Host layout test flakiness dashboard in TestResultServer appengine.
1359
1360         Flakiness dashboard is a tool to monitor layout test status and
1361         help layout test regression diagnostics.
1362
1363         https://bugs.webkit.org/show_bug.cgi?id=36195
1364
1365         * TestResultServer/handlers/dashboardhandler.py: Added.
1366          - New handler to handle dashboard request
1367         * TestResultServer/handlers/menu.py:
1368          - Add new dashboard links
1369         * TestResultServer/handlers/testfilehandler.py:
1370          - Request routes refactory
1371         * TestResultServer/index.yaml:
1372         * TestResultServer/main.py:
1373          - Add new dashboard request routes and refactor test result file rountes.
1374         * TestResultServer/model/dashboardfile.py: Added.
1375          - Model to access datastore for dashboard files
1376         * TestResultServer/model/testfile.py:
1377         * TestResultServer/stylesheets/dashboardfile.css: Added.
1378         * TestResultServer/templates/dashboardfilelist.html: Added.
1379         * TestResultServer/templates/showfilelist.html:
1380
1381 2010-03-26  Adam Barth  <abarth@webkit.org>
1382
1383         Reviewed by Eric Seidel.
1384
1385         Remove some evil statics from CommitInfo
1386         https://bugs.webkit.org/show_bug.cgi?id=36637
1387
1388         These methods should really be on checkout.  You can tell because they
1389         know about ChangeLogs and take an SCM as an argument.  :)
1390
1391         * Scripts/webkitpy/common/checkout/api.py:
1392         * Scripts/webkitpy/common/checkout/changelog.py:
1393         * Scripts/webkitpy/common/checkout/commitinfo.py:
1394         * Scripts/webkitpy/tool/commands/queries.py:
1395
1396 2010-03-23  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1397
1398         Reviewed by Simon Hausmann.
1399
1400         Add an option to QtLauncher to enable/disable a QGLWidget as Viewport
1401         of the QGraphicsView when the launcher is running on graphicsview mode.
1402
1403         [Qt] QtLauncher needs an option to Enable/Disable a QGLWidget as Viewport
1404         https://bugs.webkit.org/show_bug.cgi?id=36270
1405
1406         * QtLauncher/QtLauncher.pro:
1407         * QtLauncher/main.cpp:
1408         (LauncherWindow::toggleQGLWidgetViewport):
1409         (LauncherWindow::createChrome):
1410
1411 2010-03-26  Fumitoshi Ukai  <ukai@chromium.org>
1412
1413         Reviewed by Shinichiro Hamaji.
1414
1415         [Chromium-Win] websocket_server.py failed to start
1416         https://bugs.webkit.org/show_bug.cgi?id=36586
1417         
1418         subproess.Popen() on Python 2.4/Windows with stdout,stdout, but no stdin will fail, because it uses return value of GetStdHandle(STD_INPUT_HANDLE), but DuplicateHandle requires integer, not the handle.
1419         We don't need stdin, so use devnull as stdin.
1420
1421         * Scripts/webkitpy/layout_tests/port/websocket_server.py: open os.devnull for stdin
1422
1423 2010-03-26  Kent Tamura  <tkent@chromium.org>
1424
1425         Reviewed by Dimitri Glazkov.
1426
1427         [DRT/Chromium] Add TestNavigationController and TestWebWorker
1428         https://bugs.webkit.org/show_bug.cgi?id=36520
1429
1430         Add LayoutTestController class, which is going to be used by
1431         DumpRenderTree Chromium port. These files are based on:
1432         - src/webkit/tools/test_shell/layout_test_controller.cc
1433         - src/webkit/tools/test_shell/layout_test_controller.h
1434         of Chromium rev.40492.
1435
1436         * DumpRenderTree/chromium/LayoutTestController.cpp: Added.
1437         * DumpRenderTree/chromium/LayoutTestController.h: Added.
1438
1439 2010-03-25  Charlie Reis  <creis@chromium.org>
1440
1441         Reviewed by Adam Barth.
1442
1443         onbeforeunload not called at window close + frame or iframe focused
1444         https://bugs.webkit.org/show_bug.cgi?id=27481
1445
1446         Adds a callShouldCloseOnWebView method to LayoutTestController,
1447         to allow automated testing for bug 27481.
1448
1449         * DumpRenderTree/LayoutTestController.cpp:
1450         (callShouldCloseOnWebViewCallback):
1451         (LayoutTestController::staticFunctions):
1452         * DumpRenderTree/LayoutTestController.h:
1453         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1454         (LayoutTestController::callShouldCloseOnWebView):
1455         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1456         (LayoutTestController::callShouldCloseOnWebView):
1457         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1458         (LayoutTestController::callShouldCloseOnWebView):
1459         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1460         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1461         (LayoutTestController::callShouldCloseOnWebView):
1462
1463 2010-03-25  Eric Seidel  <eric@webkit.org>
1464
1465         Reviewed by Adam Barth.
1466
1467         Add webkit-patch lkgr for finding last known good revision
1468         https://bugs.webkit.org/show_bug.cgi?id=36626
1469
1470         This is rather slow for now because the command
1471         has to compute this information from the buildbot.
1472         A better long-term solution would be to have a server
1473         somewhere store a pre-computed LKGR and then any
1474         script (like webkit-patch) could just fetch it.
1475
1476         * Scripts/webkitpy/common/net/buildbot.py:
1477         * Scripts/webkitpy/tool/commands/queries.py:
1478
1479 2010-03-25  Adam Barth  <abarth@webkit.org>
1480
1481         Reviewed by Eric Seidel.
1482
1483         Move modified_changelogs (and friends) from scm to checkout
1484         https://bugs.webkit.org/show_bug.cgi?id=36636
1485
1486         These functions know about ChangeLogs, which is forbidden knowledge in
1487         scm.py.
1488
1489         * Scripts/webkitpy/common/checkout/api.py:
1490         * Scripts/webkitpy/common/checkout/changelog.py:
1491         * Scripts/webkitpy/common/checkout/scm.py:
1492         * Scripts/webkitpy/tool/mocktool.py:
1493         * Scripts/webkitpy/tool/steps/abstractstep.py:
1494         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1495         * Scripts/webkitpy/tool/steps/revertrevision.py:
1496         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1497         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1498
1499 2010-03-25  Adam Barth  <abarth@webkit.org>
1500
1501         Reviewed by Eric Seidel.
1502
1503         Move apply_patch from scm to checkout
1504         https://bugs.webkit.org/show_bug.cgi?id=36635
1505
1506         SCM shouldn't have any knowledge of WebKit scripts.
1507
1508         * Scripts/webkitpy/common/checkout/api.py:
1509         * Scripts/webkitpy/common/checkout/scm.py:
1510         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1511         * Scripts/webkitpy/tool/mocktool.py:
1512         * Scripts/webkitpy/tool/steps/applypatch.py:
1513
1514 2010-03-25  Eric Seidel  <eric@webkit.org>
1515
1516         Unreviewed build fix to un-break webkit-patch land.
1517         Test-case coming in follow-up commit.
1518
1519         Move commit_message_for_this_commit from scm to checkout
1520         https://bugs.webkit.org/show_bug.cgi?id=36629
1521
1522         * Scripts/webkitpy/common/checkout/api.py: import scm.CommitMessage
1523
1524 2010-03-25  Dan Bernstein  <mitz@apple.com>
1525
1526         Reviewed by Darin Adler.
1527
1528         <rdar://problem/7728903> Support color bitmap fonts
1529
1530         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added ColorBits.ttf
1531         and ColorBits-A.png.
1532         * DumpRenderTree/fonts/ColorBits-A.png: Copied from WebCore/inspector/front-end/Images/successGreenDot.png.
1533         * DumpRenderTree/fonts/ColorBits.ttf: Added.
1534         * DumpRenderTree/mac/DumpRenderTree.mm:
1535         (activateFonts): Activate ColorBits.ttf.
1536
1537 2010-03-25  Mark Rowe  <mrowe@apple.com>
1538
1539         Remove a printf that was causing commit-log-editor to spew the name of the editor
1540         to the terminal many times during a commit.
1541
1542         * Scripts/commit-log-editor:
1543
1544 2010-03-25  Adam Barth  <abarth@webkit.org>
1545
1546         Reviewed by Eric Seidel.
1547
1548         Move commit_message_for_this_commit from scm to checkout
1549         https://bugs.webkit.org/show_bug.cgi?id=36629
1550
1551         This function requires knowledge of ChangeLogs, but scm shouldn't know
1552         about ChangeLogs.
1553
1554         * Scripts/webkitpy/common/checkout/api.py:
1555         * Scripts/webkitpy/common/checkout/scm.py:
1556         * Scripts/webkitpy/tool/commands/upload.py:
1557         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1558         * Scripts/webkitpy/tool/mocktool.py:
1559         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
1560         * Scripts/webkitpy/tool/steps/commit.py:
1561
1562 2010-03-25  Adam Barth  <abarth@webkit.org>
1563
1564         Reviewed by Eric Seidel.
1565
1566         REGRESSION: webkit-patch land can't land "rubber-stamped" patches
1567         https://bugs.webkit.org/show_bug.cgi?id=36582
1568
1569         Allow a "-" in rubber stamped.
1570
1571         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1572
1573 2010-03-25  Adam Barth  <abarth@webkit.org>
1574
1575         Unreviewed.  Fix some copyright lines to remove extraneous comma and
1576         python directive.
1577
1578         * Scripts/webkitpy/tool/bot/patchcollection.py:
1579         * Scripts/webkitpy/tool/bot/patchcollection_unittest.py:
1580         * Scripts/webkitpy/tool/bot/queueengine.py:
1581         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1582         * Scripts/webkitpy/tool/commands/download.py:
1583         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1584         * Scripts/webkitpy/tool/commands/queries.py:
1585         * Scripts/webkitpy/tool/commands/queues.py:
1586         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1587         * Scripts/webkitpy/tool/comments.py:
1588         * Scripts/webkitpy/tool/grammar.py:
1589         * Scripts/webkitpy/tool/multicommandtool.py:
1590         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
1591
1592 2010-03-25  Simon Fraser  <simon.fraser@apple.com>
1593
1594         Reviewed by Darin Adler, Alexey Proskuryakov.
1595
1596         https://bugs.webkit.org/show_bug.cgi?id=36631
1597         Allow the test plugin to run scripts in response to NPP_SetWindow calls
1598         
1599         Hook up the ability for the TestNetscapePlugIn to run JavaScript in
1600         response to NPP_SetWindow.
1601         
1602         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1603         (pluginAllocate):
1604         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1605         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1606         (NPP_New):
1607         (NPP_Destroy):
1608         (NPP_SetWindow):
1609
1610 2010-03-25  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1611
1612         Unreviewed, build fix.
1613
1614         [Qt] Fix QtLauncher guards.
1615
1616         * QtLauncher/main.cpp:
1617         (LauncherWindow::showFPS):
1618         (LauncherWindow::updateFPS):
1619
1620 2010-03-25  Yury Semikhatsky  <yurys@chromium.org>
1621
1622         Reviewed by Pavel Feldman.
1623
1624         Allow running tests with enabled developer extras and closed Web Inspector. Tests that have inspector-enabled/ in their path/url will have developer extras enabled.
1625
1626         https://bugs.webkit.org/show_bug.cgi?id=36610
1627
1628         * DumpRenderTree/LayoutTestController.h:
1629         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1630         (shouldEnableDeveloperExtras):
1631         (runTest):
1632         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1633         (LayoutTestController::setJavaScriptProfilingEnabled):
1634         (LayoutTestController::setDeveloperExtrasEnabled):
1635         (LayoutTestController::showWebInspector):
1636         (LayoutTestController::closeWebInspector):
1637         * DumpRenderTree/mac/DumpRenderTree.mm:
1638         (shouldEnableDeveloperExtras):
1639         (runTest):
1640         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1641         (LayoutTestController::setJavaScriptProfilingEnabled):
1642         (LayoutTestController::setDeveloperExtrasEnabled):
1643         (LayoutTestController::showWebInspector):
1644         (LayoutTestController::closeWebInspector):
1645         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1646         (WebCore::shouldEnableDeveloperExtras):
1647         (WebCore::DumpRenderTree::open):
1648         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1649         (LayoutTestController::closeWebInspector):
1650         (LayoutTestController::setDeveloperExtrasEnabled):
1651         (LayoutTestController::showWebInspector):
1652         (LayoutTestController::setJavaScriptProfilingEnabled):
1653         * DumpRenderTree/win/DumpRenderTree.cpp:
1654         (shouldEnableDeveloperExtras):
1655         (runTest):
1656         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1657         (LayoutTestController::setJavaScriptProfilingEnabled):
1658         (LayoutTestController::setDeveloperExtrasEnabled):
1659         (LayoutTestController::showWebInspector):
1660         (LayoutTestController::closeWebInspector):
1661
1662 2010-03-25  Adam Barth  <abarth@webkit.org>
1663
1664         Rubber stamped by Eric Seidel.
1665
1666         Tweaks to sheriffbot to improve latency by keeping the working copy up
1667         to date even when there's no build break.  Also, officially move
1668         sheriffbot to #webkit.
1669
1670         (Also teach ValidateReviewer to understand rubber stamps.)
1671
1672         * Scripts/webkitpy/common/net/irc/ircbot.py:
1673         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1674         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1675
1676 2010-03-22  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1677
1678         Reviewed by Simon Hausmann.
1679
1680         Not displaying FPS info on the terminal. On S60 and Maemo the
1681         Window title will be used and Status bar will used on desktop.
1682
1683         [Qt] QtLauncher's FPS info should not be displayed on the terminal
1684         https://bugs.webkit.org/show_bug.cgi?id=36244
1685
1686         * QtLauncher/main.cpp:
1687         (LauncherWindow::initializeView):
1688         (LauncherWindow::showFPS):
1689         (LauncherWindow::updateFPS):
1690         * QtLauncher/webview.cpp:
1691         (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
1692         (WebViewGraphicsBased::updateFrameRate):
1693         * QtLauncher/webview.h:
1694         (WebViewGraphicsBased::frameRateMeasurementEnabled):
1695
1696 2010-03-25  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1697
1698         Reviewed by Kenneth Christiansen.
1699
1700         Added missing frame flattening activation on
1701         fast/frames/flattening/frameset-flattening-grid.html;
1702         removed unnecessary CONSOLE MESSAGE from the expected file;
1703         reset the setFrameSetFlatteningEnabled for each test.
1704
1705         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1706         (WebCore::WebPage::resetSettings):
1707
1708 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
1709
1710         Reviewed by Adam Barth.
1711
1712         Moved deprecated_logging unit test import statement from
1713         webkitpy/unittests.py to webkitpy/common/system/unittests.py.
1714
1715         https://bugs.webkit.org/show_bug.cgi?id=36093
1716
1717         This is part of the master bug to reorganize webkitpy.
1718
1719         * Scripts/webkitpy/common/system/unittests.py:
1720         * Scripts/webkitpy/unittests.py:
1721
1722 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
1723
1724         Reviewed by Adam Barth.
1725
1726         Moved webkit_logging.py to common/system/deprecated_logging.py
1727         inside webkitpy.
1728
1729         https://bugs.webkit.org/show_bug.cgi?id=36093
1730
1731         This is part of the master bug to reorganize webkitpy.
1732
1733         * Scripts/validate-committer-lists:
1734         * Scripts/webkitpy/common/checkout/changelog.py:
1735         * Scripts/webkitpy/common/checkout/scm.py:
1736         * Scripts/webkitpy/common/net/bugzilla.py:
1737         * Scripts/webkitpy/common/net/buildbot.py:
1738         * Scripts/webkitpy/common/net/credentials.py:
1739         * Scripts/webkitpy/common/net/irc/ircproxy.py:
1740         * Scripts/webkitpy/common/net/networktransaction.py:
1741         * Scripts/webkitpy/common/net/statusserver.py:
1742         * Scripts/webkitpy/common/system/deprecated_logging.py: Copied from WebKitTools/Scripts/webkitpy/webkit_logging.py.
1743         * Scripts/webkitpy/common/system/deprecated_logging_unittest.py: Copied from WebKitTools/Scripts/webkitpy/webkit_logging_unittest.py.
1744         * Scripts/webkitpy/common/system/executive.py:
1745         * Scripts/webkitpy/tool/bot/queueengine.py:
1746         * Scripts/webkitpy/tool/commands/download.py:
1747         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1748         * Scripts/webkitpy/tool/commands/openbugs.py:
1749         * Scripts/webkitpy/tool/commands/queries.py:
1750         * Scripts/webkitpy/tool/commands/queues.py:
1751         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1752         * Scripts/webkitpy/tool/commands/stepsequence.py:
1753         * Scripts/webkitpy/tool/commands/upload.py:
1754         * Scripts/webkitpy/tool/main.py:
1755         * Scripts/webkitpy/tool/mocktool.py:
1756         * Scripts/webkitpy/tool/multicommandtool.py:
1757         * Scripts/webkitpy/tool/steps/abstractstep.py:
1758         * Scripts/webkitpy/tool/steps/applypatch.py:
1759         * Scripts/webkitpy/tool/steps/build.py:
1760         * Scripts/webkitpy/tool/steps/checkstyle.py:
1761         * Scripts/webkitpy/tool/steps/closebug.py:
1762         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
1763         * Scripts/webkitpy/tool/steps/confirmdiff.py:
1764         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
1765         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
1766         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
1767         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1768         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
1769         * Scripts/webkitpy/tool/steps/runtests.py:
1770         * Scripts/webkitpy/tool/steps/update.py:
1771         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1772         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1773         * Scripts/webkitpy/unittests.py:
1774         * Scripts/webkitpy/webkit_logging.py: Removed.
1775         * Scripts/webkitpy/webkit_logging_unittest.py: Removed.
1776
1777 2010-03-25  Julien Chaffraix  <jchaffraix@webkit.org>
1778
1779         Reviewed by Kenneth Rohde Christiansen.
1780
1781         commit-log-editor can call itself in an infinite loop
1782         https://bugs.webkit.org/show_bug.cgi?id=35291
1783
1784         if $editor ends up being commit-log-editor, the script will exec itself
1785         in an infinite loop.
1786
1787         To avoid this, we now check that the $editor variable is not
1788         commit-log-editor to avoid this case.
1789
1790         * Scripts/commit-log-editor: Added an isCommitLogEditor method and
1791         reworked the $editor setting to add this check.
1792
1793 2010-03-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1794
1795         Reviewed by Kenneth Rohde Christiansen.
1796
1797         Add a Toggle Frame Flattening option to QtLauncher.
1798         It will be enabled by default on Maemo5 and S60 platforms.
1799
1800         [Qt] Add enable/disable Frame Flattening option to QtLauncher
1801         https://bugs.webkit.org/show_bug.cgi?id=36558
1802
1803         * QtLauncher/main.cpp:
1804         (LauncherWindow::applyPrefs):
1805         (LauncherWindow::toggleFrameFlattening):
1806         (LauncherWindow::createChrome):
1807
1808 2010-03-25  Zoltan Horvath  <zoltan@webkit.org>
1809
1810         Reviewed by Eric Seidel.
1811
1812         svn-create-patch prints a warning for large patches
1813         https://bugs.webkit.org/show_bug.cgi?id=32582
1814
1815         svn-create-patch prints a warning message for larger patches than 20k.
1816
1817         * Scripts/svn-create-patch:
1818
1819 2010-03-25  Adam Barth  <abarth@webkit.org>
1820
1821         Unreviewed.  Renamed early_warning_system.py to earlywarningsystem.py.
1822         https://bugs.webkit.org/show_bug.cgi?id=36093
1823
1824         * Scripts/webkitpy/tool/commands/early_warning_system.py: Removed.
1825         * Scripts/webkitpy/tool/commands/early_warning_system_unittest.py: Removed.
1826         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Copied from Scripts/webkitpy/tool/commands/early_warning_system.py.
1827         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Copied from Scripts/webkitpy/tool/commands/early_warning_system_unittest.py.
1828         * Scripts/webkitpy/tool/main.py:
1829         * Scripts/webkitpy/tool/unittests.py:
1830
1831 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
1832
1833         Reviewed by Adam Barth.
1834
1835         In webkitpy, pushed the unit test import statements in
1836         webkitpy/unittests.py into appropriate unittests.py files in the
1837         new root-level packages beneath webkitpy.
1838
1839         https://bugs.webkit.org/show_bug.cgi?id=36093
1840
1841         This is part of the master bug to reorganize webkitpy.
1842
1843         * Scripts/webkitpy/common/system/unittests.py:
1844         * Scripts/webkitpy/common/unittests.py: Added.
1845         * Scripts/webkitpy/python24/unittests.py: Added.
1846         * Scripts/webkitpy/tool/unittests.py: Added.
1847         * Scripts/webkitpy/unittests.py:
1848
1849 2010-03-25  Adam Barth  <abarth@webkit.org>
1850
1851         Unreviewed.  Move WebKitCheckout into the webkitpy.common.checkout
1852         package.
1853         https://bugs.webkit.org/show_bug.cgi?id=36093
1854
1855         * Scripts/webkitpy/common/checkout/api.py: Copied from Scripts/webkitpy/webkitcheckout.py.
1856         * Scripts/webkitpy/tool/main.py:
1857         * Scripts/webkitpy/tool/mocktool.py:
1858         * Scripts/webkitpy/webkitcheckout.py: Removed.
1859
1860 2010-03-25  Adam Barth  <abarth@webkit.org>
1861
1862         Unreviewed.  Move OutputCapture to webkitpy.common.system.
1863         https://bugs.webkit.org/show_bug.cgi?id=36093
1864
1865         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1866         * Scripts/webkitpy/common/net/credentials_unittest.py:
1867         * Scripts/webkitpy/common/system/outputcapture.py: Copied from Scripts/webkitpy/outputcapture.py.
1868         * Scripts/webkitpy/outputcapture.py: Removed.
1869         * Scripts/webkitpy/tool/commands/commandtest.py:
1870         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1871         * Scripts/webkitpy/tool/commands/queuestest.py:
1872         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
1873         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
1874         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1875         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
1876
1877 2010-03-25  Adam Barth  <abarth@webkit.org>
1878
1879         Unreviewed.  Move user.py to webkitpy.common.system.
1880
1881         * Scripts/webkitpy/common/checkout/scm.py:
1882         * Scripts/webkitpy/common/net/bugzilla.py:
1883         * Scripts/webkitpy/common/net/credentials.py:
1884         * Scripts/webkitpy/common/system/user.py: Copied from Scripts/webkitpy/user.py.
1885         * Scripts/webkitpy/common/system/user_unittest.py: Copied from Scripts/webkitpy/user_unittest.py.
1886         * Scripts/webkitpy/tool/commands/upload.py:
1887         * Scripts/webkitpy/tool/main.py:
1888         * Scripts/webkitpy/unittests.py:
1889         * Scripts/webkitpy/user.py: Removed.
1890         * Scripts/webkitpy/user_unittest.py: Removed.
1891
1892 2010-03-25  Adam Barth  <abarth@webkit.org>
1893
1894         Unreviewed.  Move executive.py to webkitpy.common.system.
1895         https://bugs.webkit.org/show_bug.cgi?id=36093
1896
1897         * Scripts/webkitpy/common/checkout/scm.py:
1898         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1899         * Scripts/webkitpy/common/config/ports.py:
1900         * Scripts/webkitpy/common/config/ports_unittest.py:
1901         * Scripts/webkitpy/common/net/credentials.py:
1902         * Scripts/webkitpy/common/net/credentials_unittest.py:
1903         * Scripts/webkitpy/common/system/executive.py: Copied from Scripts/webkitpy/executive.py.
1904         * Scripts/webkitpy/common/system/executive_unittest.py: Copied from Scripts/webkitpy/executive_unittest.py.
1905         * Scripts/webkitpy/executive.py: Removed.
1906         * Scripts/webkitpy/executive_unittest.py: Removed.
1907         * Scripts/webkitpy/layout_tests/port/mac.py:
1908         * Scripts/webkitpy/tool/bot/queueengine.py:
1909         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1910         * Scripts/webkitpy/tool/commands/download.py:
1911         * Scripts/webkitpy/tool/commands/early_warning_system.py:
1912         * Scripts/webkitpy/tool/commands/queues.py:
1913         * Scripts/webkitpy/tool/commands/stepsequence.py:
1914         * Scripts/webkitpy/tool/main.py:
1915         * Scripts/webkitpy/tool/steps/checkstyle.py:
1916         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1917         * Scripts/webkitpy/unittests.py:
1918         * Scripts/webkitpy/webkit_logging_unittest.py:
1919
1920 2010-03-25  Adam Barth  <abarth@webkit.org>
1921
1922         Unreviewed.  Move grammary.py into webkitpy.tool.
1923         https://bugs.webkit.org/show_bug.cgi?id=36093
1924
1925         * Scripts/webkitpy/grammar.py: Removed.
1926         * Scripts/webkitpy/grammar_unittest.py: Removed.
1927         * Scripts/webkitpy/tool/commands/download.py:
1928         * Scripts/webkitpy/tool/commands/queries.py:
1929         * Scripts/webkitpy/tool/commands/queues.py:
1930         * Scripts/webkitpy/tool/commands/upload.py:
1931         * Scripts/webkitpy/tool/grammar.py: Copied from Scripts/webkitpy/grammar.py.
1932         * Scripts/webkitpy/tool/grammar_unittest.py: Copied from Scripts/webkitpy/grammar_unittest.py.
1933         * Scripts/webkitpy/tool/multicommandtool.py:
1934         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
1935         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1936         * Scripts/webkitpy/unittests.py:
1937
1938 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
1939
1940         Reviewed by Adam Barth.
1941
1942         In webkitpy, moved init/ to common/system/.
1943
1944         https://bugs.webkit.org/show_bug.cgi?id=36093
1945
1946         This is part of the master bug to reorganize webkitpy.
1947
1948         * Scripts/webkitpy/common/system: Copied from WebKitTools/Scripts/webkitpy/init.
1949         * Scripts/webkitpy/common/system/logutils.py:
1950         * Scripts/webkitpy/common/system/logutils_unittest.py:
1951         * Scripts/webkitpy/init: Removed.
1952         * Scripts/webkitpy/init/__init__.py: Removed.
1953         * Scripts/webkitpy/init/logtesting.py: Removed.
1954         * Scripts/webkitpy/init/logutils.py: Removed.
1955         * Scripts/webkitpy/init/logutils_unittest.py: Removed.
1956         * Scripts/webkitpy/init/unittests.py: Removed.
1957         * Scripts/webkitpy/python24/versioning_unittest.py:
1958         * Scripts/webkitpy/style_references.py:
1959         * Scripts/webkitpy/unittests.py:
1960
1961 2010-03-25  Adam Barth  <abarth@webkit.org>
1962
1963         Unreviewed.  Move stepsequence to webkitpy.tool.commands.
1964         https://bugs.webkit.org/show_bug.cgi?id=36093
1965
1966         * Scripts/webkitpy/stepsequence.py: Removed.
1967         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
1968         * Scripts/webkitpy/tool/commands/download.py:
1969         * Scripts/webkitpy/tool/commands/queues.py:
1970         * Scripts/webkitpy/tool/commands/stepsequence.py: Copied from Scripts/webkitpy/stepsequence.py.
1971
1972 2010-03-25  Adam Barth  <abarth@webkit.org>
1973
1974         Unreviewed.  Create webkitpy.common.checkout as described in
1975         https://bugs.webkit.org/show_bug.cgi?id=36093
1976
1977         * Scripts/webkitpy/changelogs.py: Removed.
1978         * Scripts/webkitpy/changelogs_unittest.py: Removed.
1979         * Scripts/webkitpy/commitinfo.py: Removed.
1980         * Scripts/webkitpy/commitinfo_unittest.py: Removed.
1981         * Scripts/webkitpy/common/checkout: Added.
1982         * Scripts/webkitpy/common/checkout/__init__.py: Copied from Scripts/webkitpy/common/__init__.py.
1983         * Scripts/webkitpy/common/checkout/changelog.py: Copied from Scripts/webkitpy/changelogs.py.
1984         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Copied from Scripts/webkitpy/changelogs_unittest.py.
1985         * Scripts/webkitpy/common/checkout/commitinfo.py: Copied from Scripts/webkitpy/commitinfo.py.
1986         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py: Copied from Scripts/webkitpy/commitinfo_unittest.py.
1987         * Scripts/webkitpy/common/checkout/diff_parser.py: Copied from Scripts/webkitpy/diff_parser.py.
1988         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py: Copied from Scripts/webkitpy/diff_parser_unittest.py.
1989         * Scripts/webkitpy/common/checkout/scm.py: Copied from Scripts/webkitpy/scm.py.
1990         * Scripts/webkitpy/common/checkout/scm_unittest.py: Copied from Scripts/webkitpy/scm_unittest.py.
1991         * Scripts/webkitpy/common/net/credentials.py:
1992         * Scripts/webkitpy/diff_parser.py: Removed.
1993         * Scripts/webkitpy/diff_parser_unittest.py: Removed.
1994         * Scripts/webkitpy/layout_tests/port/base.py:
1995         * Scripts/webkitpy/scm.py: Removed.
1996         * Scripts/webkitpy/scm_unittest.py: Removed.
1997         * Scripts/webkitpy/stepsequence.py:
1998         * Scripts/webkitpy/style_references.py:
1999         * Scripts/webkitpy/tool/commands/download.py:
2000         * Scripts/webkitpy/tool/commands/queries.py:
2001         * Scripts/webkitpy/tool/comments.py:
2002         * Scripts/webkitpy/tool/main.py:
2003         * Scripts/webkitpy/tool/mocktool.py:
2004         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2005         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2006         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2007         * Scripts/webkitpy/unittests.py:
2008         * Scripts/webkitpy/webkitcheckout.py:
2009
2010 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
2011
2012         Reviewed by Adam Barth.
2013
2014         In webkitpy, moved init/versioning.py to python24/.
2015
2016         https://bugs.webkit.org/show_bug.cgi?id=36093
2017
2018         This is part of the master bug to reorganize webkitpy.
2019
2020         * Scripts/test-webkitpy:
2021         * Scripts/webkit-patch:
2022         * Scripts/webkitpy/init/unittests.py:
2023         * Scripts/webkitpy/init/versioning.py: Removed.
2024         * Scripts/webkitpy/init/versioning_unittest.py: Removed.
2025         * Scripts/webkitpy/python24: Added.
2026         * Scripts/webkitpy/python24/__init__.py: Copied from WebKitTools/Scripts/webkitpy/tool/__init__.py.
2027         * Scripts/webkitpy/python24/versioning.py: Copied from WebKitTools/Scripts/webkitpy/init/versioning.py.
2028         * Scripts/webkitpy/python24/versioning_unittest.py: Copied from WebKitTools/Scripts/webkitpy/init/versioning_unittest.py.
2029         * Scripts/webkitpy/unittests.py:
2030
2031 2010-03-25  Adam Barth  <abarth@webkit.org>
2032
2033         Unreviewed.
2034
2035         Create webkitpy.common.net as described in
2036         https://bugs.webkit.org/show_bug.cgi?id=36093
2037
2038         * Scripts/webkitpy/bugzilla.py: Removed.
2039         * Scripts/webkitpy/bugzilla_unittest.py: Removed.
2040         * Scripts/webkitpy/buildbot.py: Removed.
2041         * Scripts/webkitpy/buildbot_unittest.py: Removed.
2042         * Scripts/webkitpy/commitinfo.py:
2043         * Scripts/webkitpy/common/net: Added.
2044         * Scripts/webkitpy/common/net/__init__.py: Added.
2045         * Scripts/webkitpy/common/net/bugzilla.py: Copied from Scripts/webkitpy/bugzilla.py.
2046         * Scripts/webkitpy/common/net/bugzilla_unittest.py: Copied from Scripts/webkitpy/bugzilla_unittest.py.
2047         * Scripts/webkitpy/common/net/buildbot.py: Copied from Scripts/webkitpy/buildbot.py.
2048         * Scripts/webkitpy/common/net/buildbot_unittest.py: Copied from Scripts/webkitpy/buildbot_unittest.py.
2049         * Scripts/webkitpy/common/net/credentials.py: Copied from Scripts/webkitpy/credentials.py.
2050         * Scripts/webkitpy/common/net/credentials_unittest.py: Copied from Scripts/webkitpy/credentials_unittest.py.
2051         * Scripts/webkitpy/common/net/irc: Copied from Scripts/webkitpy/irc.
2052         * Scripts/webkitpy/common/net/irc/ircbot.py:
2053         * Scripts/webkitpy/common/net/irc/ircproxy.py:
2054         * Scripts/webkitpy/common/net/irc/messagepump_unittest.py:
2055         * Scripts/webkitpy/common/net/irc/threadedmessagequeue_unittest.py:
2056         * Scripts/webkitpy/common/net/irc/unittests.py:
2057         * Scripts/webkitpy/common/net/networktransaction.py: Copied from Scripts/webkitpy/networktransaction.py.
2058         * Scripts/webkitpy/common/net/networktransaction_unittest.py: Copied from Scripts/webkitpy/networktransaction_unittest.py.
2059         * Scripts/webkitpy/common/net/statusserver.py: Copied from Scripts/webkitpy/statusserver.py.
2060         * Scripts/webkitpy/credentials.py: Removed.
2061         * Scripts/webkitpy/credentials_unittest.py: Removed.
2062         * Scripts/webkitpy/irc: Removed.
2063         * Scripts/webkitpy/irc/__init__.py: Removed.
2064         * Scripts/webkitpy/irc/ircbot.py: Removed.
2065         * Scripts/webkitpy/irc/ircproxy.py: Removed.
2066         * Scripts/webkitpy/irc/messagepump.py: Removed.
2067         * Scripts/webkitpy/irc/messagepump_unittest.py: Removed.
2068         * Scripts/webkitpy/irc/threadedmessagequeue.py: Removed.
2069         * Scripts/webkitpy/irc/threadedmessagequeue_unittest.py: Removed.
2070         * Scripts/webkitpy/irc/unittests.py: Removed.
2071         * Scripts/webkitpy/networktransaction.py: Removed.
2072         * Scripts/webkitpy/networktransaction_unittest.py: Removed.
2073         * Scripts/webkitpy/scm_unittest.py:
2074         * Scripts/webkitpy/statusserver.py: Removed.
2075         * Scripts/webkitpy/tool/bot/queueengine.py:
2076         * Scripts/webkitpy/tool/commands/download.py:
2077         * Scripts/webkitpy/tool/commands/queries.py:
2078         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2079         * Scripts/webkitpy/tool/commands/queues.py:
2080         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2081         * Scripts/webkitpy/tool/commands/queuestest.py:
2082         * Scripts/webkitpy/tool/commands/upload.py:
2083         * Scripts/webkitpy/tool/main.py:
2084         * Scripts/webkitpy/tool/mocktool.py:
2085         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
2086         * Scripts/webkitpy/unittests.py:
2087
2088 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
2089
2090         Reviewed by Adam Barth.
2091
2092         In webkitpy, renamed MockBugzillaTool to MockTool.
2093
2094         * Scripts/webkitpy/tool/commands/commandtest.py:
2095         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2096         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2097         * Scripts/webkitpy/tool/commands/queuestest.py:
2098         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2099         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2100         * Scripts/webkitpy/tool/mocktool.py:
2101         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
2102         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2103         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
2104
2105 2010-03-25  Chris Jerdonek  <cjerdonek@webkit.org>
2106
2107         Reviewed by Adam Barth.
2108
2109         In Scripts/webkitpy, moved webkitport.py and committers.py into
2110         common/config/ (also creating common/config/).
2111
2112         https://bugs.webkit.org/show_bug.cgi?id=36093
2113
2114         This is part of the master bug to reorganize webkitpy.
2115
2116         * Scripts/validate-committer-lists:
2117         * Scripts/webkitpy/bugzilla.py:
2118         * Scripts/webkitpy/bugzilla_unittest.py:
2119         * Scripts/webkitpy/changelogs.py:
2120         * Scripts/webkitpy/commitinfo.py:
2121         * Scripts/webkitpy/commitinfo_unittest.py:
2122         * Scripts/webkitpy/committers.py: Removed.
2123         * Scripts/webkitpy/committers_unittest.py: Removed.
2124         * Scripts/webkitpy/common: Added.
2125         * Scripts/webkitpy/common/__init__.py: Copied from WebKitTools/Scripts/webkitpy/style/__init__.py.
2126         * Scripts/webkitpy/common/config: Added.
2127         * Scripts/webkitpy/common/config/__init__.py: Copied from WebKitTools/Scripts/webkitpy/style/__init__.py.
2128         * Scripts/webkitpy/common/config/committers.py: Copied from WebKitTools/Scripts/webkitpy/committers.py.
2129         * Scripts/webkitpy/common/config/committers_unittest.py: Copied from WebKitTools/Scripts/webkitpy/committers_unittest.py.
2130         * Scripts/webkitpy/common/config/ports.py: Copied from WebKitTools/Scripts/webkitpy/webkitport.py.
2131         * Scripts/webkitpy/common/config/ports_unittest.py: Copied from WebKitTools/Scripts/webkitpy/webkitport_unittest.py.
2132         * Scripts/webkitpy/mock_bugzillatool.py:
2133         * Scripts/webkitpy/tool/commands/early_warning_system.py:
2134         * Scripts/webkitpy/tool/commands/queries.py:
2135         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2136         * Scripts/webkitpy/tool/commands/upload.py:
2137         * Scripts/webkitpy/tool/steps/abstractstep.py:
2138         * Scripts/webkitpy/unittests.py:
2139         * Scripts/webkitpy/webkitport.py: Removed.
2140         * Scripts/webkitpy/webkitport_unittest.py: Removed.
2141
2142 2010-03-25  Adam Barth  <abarth@webkit.org>
2143
2144         Unreviewed.  Move mock_bugzillatool.py to tool/mocktool.py.
2145
2146         * Scripts/webkitpy/mock_bugzillatool.py: Removed.
2147         * Scripts/webkitpy/tool/commands/commandtest.py:
2148         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2149         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2150         * Scripts/webkitpy/tool/commands/queuestest.py:
2151         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2152         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2153         * Scripts/webkitpy/tool/mocktool.py: Copied from Scripts/webkitpy/mock_bugzillatool.py.
2154         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
2155         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2156         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
2157
2158 2010-03-24  Adam Barth  <abarth@webkit.org>
2159
2160         Unreviewed.  Move comments.py and multicommandtool.py to their new
2161         home.
2162
2163         * Scripts/webkitpy/comments.py: Removed.
2164         * Scripts/webkitpy/multicommandtool.py: Removed.
2165         * Scripts/webkitpy/multicommandtool_unittest.py: Removed.
2166         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
2167         * Scripts/webkitpy/tool/commands/download.py:
2168         * Scripts/webkitpy/tool/commands/openbugs.py:
2169         * Scripts/webkitpy/tool/commands/queries.py:
2170         * Scripts/webkitpy/tool/commands/queues.py:
2171         * Scripts/webkitpy/tool/commands/upload.py:
2172         * Scripts/webkitpy/tool/comments.py: Copied from Scripts/webkitpy/comments.py.
2173         * Scripts/webkitpy/tool/main.py:
2174         * Scripts/webkitpy/tool/multicommandtool.py: Copied from Scripts/webkitpy/multicommandtool.py.
2175         * Scripts/webkitpy/tool/multicommandtool_unittest.py: Copied from Scripts/webkitpy/multicommandtool_unittest.py.
2176         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
2177         * Scripts/webkitpy/tool/steps/closepatch.py:
2178         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
2179         * Scripts/webkitpy/unittests.py:
2180
2181 2010-03-24  Adam Barth  <abarth@webkit.org>
2182
2183         Unreviewed.  Fixup one import statement I didn't find because the .pyc
2184         masked the error.
2185
2186         * Scripts/webkitpy/stepsequence.py:
2187
2188 2010-03-24  Adam Barth  <abarth@webkit.org>
2189
2190         Unreviewed.  Move queueengine.py to its new home.
2191
2192         * Scripts/webkitpy/queueengine.py: Removed.
2193         * Scripts/webkitpy/queueengine_unittest.py: Removed.
2194         * Scripts/webkitpy/tool/bot/queueengine.py: Copied from Scripts/webkitpy/queueengine.py.
2195         * Scripts/webkitpy/tool/bot/queueengine_unittest.py: Copied from Scripts/webkitpy/queueengine_unittest.py.
2196         * Scripts/webkitpy/tool/commands/early_warning_system.py:
2197         * Scripts/webkitpy/tool/commands/queues.py:
2198         * Scripts/webkitpy/unittests.py:
2199
2200 2010-03-24  Adam Barth  <abarth@webkit.org>
2201
2202         Unreviewed.  Move patchcollection.py to its new home.
2203
2204         * Scripts/webkitpy/patchcollection.py: Removed.
2205         * Scripts/webkitpy/patchcollection_unittest.py: Removed.
2206         * Scripts/webkitpy/tool/bot: Added.
2207         * Scripts/webkitpy/tool/bot/__init__.py: Added.
2208         * Scripts/webkitpy/tool/bot/patchcollection.py: Copied from WebKitTools/Scripts/webkitpy/patchcollection.py.
2209         * Scripts/webkitpy/tool/bot/patchcollection_unittest.py: Copied from WebKitTools/Scripts/webkitpy/patchcollection_unittest.py.
2210         * Scripts/webkitpy/tool/commands/queues.py:
2211         * Scripts/webkitpy/unittests.py:
2212
2213 2010-03-24  Chris Jerdonek  <cjerdonek@webkit.org>
2214
2215         Reviewed by Adam Barth.
2216
2217         In Scripts/webkitpy, moved steps_references.py and the steps
2218         folder into webkitpy/patch.
2219
2220         https://bugs.webkit.org/show_bug.cgi?id=36093
2221
2222         * Scripts/webkitpy/steps: Removed.
2223         * Scripts/webkitpy/steps/__init__.py: Removed.
2224         * Scripts/webkitpy/steps/abstractstep.py: Removed.
2225         * Scripts/webkitpy/steps/applypatch.py: Removed.
2226         * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: Removed.
2227         * Scripts/webkitpy/steps/build.py: Removed.
2228         * Scripts/webkitpy/steps/checkstyle.py: Removed.
2229         * Scripts/webkitpy/steps/cleanworkingdirectory.py: Removed.
2230         * Scripts/webkitpy/steps/cleanworkingdirectorywithlocalcommits.py: Removed.
2231         * Scripts/webkitpy/steps/closebug.py: Removed.
2232         * Scripts/webkitpy/steps/closebugforlanddiff.py: Removed.
2233         * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: Removed.
2234         * Scripts/webkitpy/steps/closepatch.py: Removed.
2235         * Scripts/webkitpy/steps/commit.py: Removed.
2236         * Scripts/webkitpy/steps/confirmdiff.py: Removed.
2237         * Scripts/webkitpy/steps/createbug.py: Removed.
2238         * Scripts/webkitpy/steps/editchangelog.py: Removed.
2239         * Scripts/webkitpy/steps/ensurebuildersaregreen.py: Removed.
2240         * Scripts/webkitpy/steps/ensurelocalcommitifneeded.py: Removed.
2241         * Scripts/webkitpy/steps/metastep.py: Removed.
2242         * Scripts/webkitpy/steps/obsoletepatches.py: Removed.
2243         * Scripts/webkitpy/steps/options.py: Removed.
2244         * Scripts/webkitpy/steps/postdiff.py: Removed.
2245         * Scripts/webkitpy/steps/postdiffforcommit.py: Removed.
2246         * Scripts/webkitpy/steps/postdiffforrevert.py: Removed.
2247         * Scripts/webkitpy/steps/preparechangelog.py: Removed.
2248         * Scripts/webkitpy/steps/preparechangelogforrevert.py: Removed.
2249         * Scripts/webkitpy/steps/promptforbugortitle.py: Removed.
2250         * Scripts/webkitpy/steps/reopenbugafterrollout.py: Removed.
2251         * Scripts/webkitpy/steps/revertrevision.py: Removed.
2252         * Scripts/webkitpy/steps/runtests.py: Removed.
2253         * Scripts/webkitpy/steps/steps_unittest.py: Removed.
2254         * Scripts/webkitpy/steps/update.py: Removed.
2255         * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: Removed.
2256         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: Removed.
2257         * Scripts/webkitpy/steps/validatereviewer.py: Removed.
2258         * Scripts/webkitpy/steps_references.py: Removed.
2259         * Scripts/webkitpy/stepsequence.py:
2260         * Scripts/webkitpy/tool/commands/download.py:
2261         * Scripts/webkitpy/tool/commands/upload.py:
2262         * Scripts/webkitpy/tool/steps: Copied from WebKitTools/Scripts/webkitpy/steps.
2263         * Scripts/webkitpy/tool/steps/__init__.py:
2264         * Scripts/webkitpy/tool/steps/applypatch.py:
2265         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
2266         * Scripts/webkitpy/tool/steps/build.py:
2267         * Scripts/webkitpy/tool/steps/checkstyle.py:
2268         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2269         * Scripts/webkitpy/tool/steps/cleanworkingdirectorywithlocalcommits.py:
2270         * Scripts/webkitpy/tool/steps/closebug.py:
2271         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
2272         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
2273         * Scripts/webkitpy/tool/steps/closepatch.py:
2274         * Scripts/webkitpy/tool/steps/commit.py:
2275         * Scripts/webkitpy/tool/steps/confirmdiff.py:
2276         * Scripts/webkitpy/tool/steps/createbug.py:
2277         * Scripts/webkitpy/tool/steps/editchangelog.py:
2278         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
2279         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
2280         * Scripts/webkitpy/tool/steps/metastep.py:
2281         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
2282         * Scripts/webkitpy/tool/steps/postdiff.py:
2283         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
2284         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
2285         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2286         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2287         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
2288         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
2289         * Scripts/webkitpy/tool/steps/revertrevision.py:
2290         * Scripts/webkitpy/tool/steps/runtests.py:
2291         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2292         * Scripts/webkitpy/tool/steps/update.py:
2293         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittests.py:
2294         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2295         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2296         * Scripts/webkitpy/tool/steps_references.py: Copied from WebKitTools/Scripts/webkitpy/steps_references.py.
2297         * Scripts/webkitpy/unittests.py:
2298
2299 2010-03-24  Eric Seidel  <eric@webkit.org>
2300
2301         Unreviewed, build fix only.
2302
2303         Abstract LayoutTestResults logic for easier reuse
2304         https://bugs.webkit.org/show_bug.cgi?id=36579
2305
2306         * Scripts/webkitpy/buildbot_unittest.py: Add a missing import.
2307
2308 2010-03-24  Adam Barth  <abarth@webkit.org>
2309
2310         Unreviewed.  Fix a stray comma to test landing an patch without review.
2311
2312         * Scripts/webkitpy/commitinfo.py:
2313
2314 2010-03-24  Chris Jerdonek  <cjerdonek@webkit.org>
2315
2316         Reviewed by Adam Barth.
2317
2318         In Scripts/webkitpy, moved commands_references.py and the commands
2319         folder into webkitpy/patch.
2320
2321         https://bugs.webkit.org/show_bug.cgi?id=36483
2322
2323         This is part of master bug 36093 to organize webkitpy.
2324
2325         * Scripts/webkitpy/commands: Removed.
2326         * Scripts/webkitpy/commands/__init__.py: Removed.
2327         * Scripts/webkitpy/commands/abstractsequencedcommand.py: Removed.
2328         * Scripts/webkitpy/commands/commandtest.py: Removed.
2329         * Scripts/webkitpy/commands/download.py: Removed.
2330         * Scripts/webkitpy/commands/download_unittest.py: Removed.
2331         * Scripts/webkitpy/commands/early_warning_system.py: Removed.
2332         * Scripts/webkitpy/commands/early_warning_system_unittest.py: Removed.
2333         * Scripts/webkitpy/commands/openbugs.py: Removed.
2334         * Scripts/webkitpy/commands/openbugs_unittest.py: Removed.
2335         * Scripts/webkitpy/commands/queries.py: Removed.
2336         * Scripts/webkitpy/commands/queries_unittest.py: Removed.
2337         * Scripts/webkitpy/commands/queues.py: Removed.
2338         * Scripts/webkitpy/commands/queues_unittest.py: Removed.
2339         * Scripts/webkitpy/commands/queuestest.py: Removed.
2340         * Scripts/webkitpy/commands/sheriffbot.py: Removed.
2341         * Scripts/webkitpy/commands/sheriffbot_unittest.py: Removed.
2342         * Scripts/webkitpy/commands/upload.py: Removed.
2343         * Scripts/webkitpy/commands/upload_unittest.py: Removed.
2344         * Scripts/webkitpy/commands_references.py: Removed.
2345         * Scripts/webkitpy/tool/commands: Copied from WebKitTools/Scripts/webkitpy/commands.
2346         * Scripts/webkitpy/tool/commands/commandtest.py:
2347         * Scripts/webkitpy/tool/commands/download.py:
2348         * Scripts/webkitpy/tool/commands/download_unittest.py:
2349         * Scripts/webkitpy/tool/commands/early_warning_system.py:
2350         * Scripts/webkitpy/tool/commands/early_warning_system_unittest.py:
2351         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
2352         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2353         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2354         * Scripts/webkitpy/tool/commands/queuestest.py:
2355         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2356         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2357         * Scripts/webkitpy/tool/commands/upload.py:
2358         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2359         * Scripts/webkitpy/tool/commands_references.py: Copied from WebKitTools/Scripts/webkitpy/commands_references.py.
2360         * Scripts/webkitpy/tool/main.py:
2361         * Scripts/webkitpy/unittests.py:
2362
2363 2010-03-24  Adam Barth  <abarth@webkit.org>
2364
2365         Reviewed by Eric Seidel.
2366
2367         Rename webkitpy.patch to webkitpy.tool
2368         https://bugs.webkit.org/show_bug.cgi?id=36580
2369
2370         This is in preparation for the great webkitpy naming cleanup.
2371
2372         * Scripts/webkit-patch:
2373         * Scripts/webkitpy/patch: Removed.
2374         * Scripts/webkitpy/patch/__init__.py: Removed.
2375         * Scripts/webkitpy/patch/patcher.py: Removed.
2376         * Scripts/webkitpy/tool: Copied from WebKitTools/Scripts/webkitpy/patch.
2377         * Scripts/webkitpy/tool/main.py: Copied from WebKitTools/Scripts/webkitpy/patch/patcher.py.
2378         * Scripts/webkitpy/tool/patcher.py: Removed.
2379
2380 2010-03-24  Eric Seidel  <eric@webkit.org>
2381
2382         Reviewed by Adam Barth.
2383
2384         Abstract LayoutTestResults logic for easier reuse
2385         https://bugs.webkit.org/show_bug.cgi?id=36579
2386
2387         * Scripts/webkitpy/buildbot.py:
2388          - Split out logic into new LayoutTestResults class.
2389         * Scripts/webkitpy/buildbot_unittest.py:
2390          - Rename the testing class to match.
2391         * Scripts/webkitpy/commands/queries.py:
2392          - Use the new LayoutTestResults class.
2393
2394 2010-03-24  Eric Seidel  <eric@webkit.org>
2395
2396         Reviewed by Eric Seidel.
2397
2398         Move Bugzilla.prompt_for_component to User.prompt_with_list for re-use
2399         https://bugs.webkit.org/show_bug.cgi?id=36577
2400
2401         * Scripts/webkitpy/bugzilla.py:
2402          - Move prompt_for_component to User
2403         * Scripts/webkitpy/commands/queries.py:
2404          - Add a missing argument_names declaration.
2405         * Scripts/webkitpy/user.py:
2406          - Add prompt_with_list
2407          - Make staticmethods classmethods for easier mocking
2408
2409 2010-03-24  David Kilzer  <ddkilzer@apple.com>
2410
2411         <http://webkit.org/b/36572> commit-log-editor: thinks mergeChangeLogs.pl is a ChangeLog file
2412
2413         Reviewed by Eric Seidel.
2414
2415         Fixes the following error when committing a file with
2416         "ChangeLog" in the name that isn't a ChangeLog (like
2417         mergeChangeLogs.pl from r56471 and r56472):
2418
2419             $ git commit .
2420             Can't open WebKitTools/Scripts/webkitperl/VCSUtils_unittest/mergeChangeLog at commit-log-editor line 132.
2421             error: There was a problem with the editor 'commit-log-editor'.
2422             Please supply the message using either -m or -F option.
2423
2424         * Scripts/commit-log-editor: Added '$' to anchor "ChangeLog" to
2425         the end of the file name when searching for ChangeLog files in a
2426         commit.
2427
2428 2010-03-24  David Kilzer  <ddkilzer@apple.com>
2429
2430         <http://webkit.org/b/36570> resolve-ChangeLogs: fall back to git-merge-file if ChangeLog can't be merged
2431
2432         Reviewed by Eric Seidel.
2433
2434         * Scripts/resolve-ChangeLogs: Switched to exec git-merge-file if
2435         the merge attempt fails.
2436
2437 2010-03-24  Adam Barth  <abarth@webkit.org>
2438
2439         Reviewed by Eric Seidel.
2440
2441         webkit-patch or pre-commit hook should validate reviewer lines before committing
2442         https://bugs.webkit.org/show_bug.cgi?id=26927
2443
2444         Validate that patches have valid reivewers listed in their ChangeLogs
2445         before landing.  For patches without reviewers can be landed if their
2446         ChangeLogs state that they are unreviewed.
2447
2448         * Scripts/webkitpy/changelogs.py:
2449         * Scripts/webkitpy/commands/download.py:
2450         * Scripts/webkitpy/commitinfo.py:
2451         * Scripts/webkitpy/commitinfo_unittest.py:
2452         * Scripts/webkitpy/mock_bugzillatool.py:
2453         * Scripts/webkitpy/steps/__init__.py:
2454         * Scripts/webkitpy/steps/validatereviewer.py: Added.
2455
2456 2010-03-19  Holger Hans Peter Freyther  <zecke@selfish.org>
2457
2458         Reviewed by David Levin.
2459
2460         Undefined names reported by pyflakes in python scripts
2461         https://bugs.webkit.org/show_bug.cgi?id=36403
2462
2463         Attempt to use names that exist or can exist in the lexical
2464         scope instead of not being available at all.
2465
2466         * Scripts/webkitpy/changelogs.py: Use self._content.
2467         * Scripts/webkitpy/layout_tests/port/base.py: Use os.stat
2468         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Use self._port
2469         * Scripts/webkitpy/style/processors/cpp_unittest.py: Use expected_message_re
2470
2471 2010-03-24  David Kilzer  <ddkilzer@apple.com>
2472
2473         <http://webkit.org/b/36560> resolve-ChangeLogs: git-rebase fails when resolve-ChangeLogs can't merge
2474
2475         Reviewed by Eric Seidel.
2476
2477         When resolve-ChangeLogs fails to merge a patch while running as
2478         a git merge driver, it deletes the original file, which causes
2479         an internal failure and stops git mid-merge:
2480
2481             fatal: Failed to execute internal merge
2482
2483         The fix is to use the --force switch with patch so that it will
2484         always attempt to apply the patch.  (The change in
2485         mergeChangeLogs() for the previous commit also fixed this, but
2486         adding --force also prevents any potential user interaction that
2487         patch may want to display.)
2488
2489         * Scripts/VCSUtils.pm:
2490         (mergeChangeLogs): Added --force switch to patch command.  Also
2491         changed to use the exit status from the patch command to
2492         determine the return value for this method.
2493         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl: Added
2494         test to cover this bug.
2495
2496 2010-03-24  David Kilzer  <ddkilzer@apple.com>
2497
2498         <http://webkit.org/b/36560> resolve-ChangeLogs: move mergeChanges() into VCSUtils package
2499
2500         Reviewed by Eric Seidel.
2501
2502         * Scripts/VCSUtils.pm:
2503         (mergeChangeLogs): Copied from mergeChanges() in
2504         resolve-ChangeLogs and renamed.  Added method documentation.
2505         Fixed bug found by new tests where the original file to be
2506         patched was deleted when cleaning up after a traditinal rejected
2507         patch failed to apply.
2508         * Scripts/resolve-ChangeLogs: Switched to using
2509         mergeChangeLogs().
2510         (mergeChanges): Moved to VCSUtils.pm and renamed to
2511         mergeChangeLogs().
2512         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl: Added.
2513
2514 2010-03-24  Eric Seidel  <eric@webkit.org>
2515
2516         Reviewed by Adam Barth.
2517
2518         Add support for qt's unassigned list to webkit-patch assign-to-committer
2519         https://bugs.webkit.org/show_bug.cgi?id=36559
2520
2521         * Scripts/webkitpy/bugzilla.py:
2522          - Move Bugzilla.unassigned_email into Bug and make it a set.
2523         * Scripts/webkitpy/bugzilla_unittest.py:
2524          - Test the new Bug.is_unassigned method
2525         * Scripts/webkitpy/commands/upload.py:
2526          - Use the new Bug.is_unassigned method instead of an explicit ==
2527         * Scripts/webkitpy/mock_bugzillatool.py:
2528          - Bugzilla.unassigned_email no longer needs mocking
2529
2530 2010-03-24  Kent Hansen  <kent.hansen@nokia.com>
2531
2532         Reviewed by Simon Hausmann.
2533
2534         [Qt] Rename QWebSettings::XSSAuditorEnabled to XSSAuditingEnabled
2535         https://bugs.webkit.org/show_bug.cgi?id=36522
2536
2537         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2538         (LayoutTestController::setXSSAuditorEnabled): Use the new name.
2539
2540 2010-03-24  Chris Jerdonek  <cjerdonek@webkit.org>
2541
2542         Reviewed by Shinichiro Hamaji.
2543
2544         Added to check-webkit-style support for a --debug flag.
2545
2546         https://bugs.webkit.org/show_bug.cgi?id=36100
2547
2548         The --debug flag adjusts the logging level to DEBUG and
2549         includes the logger name and level in each log message.
2550
2551         * Scripts/check-webkit-style:
2552           - Changed the code to check for the --debug flag and pass
2553             the result to the configure_logging() method.
2554         * Scripts/webkitpy/style/checker.py:
2555           - Added an is_debug parameter to configure_logging().
2556           - Refactored configure_logging() by adding calls to
2557             the following two methods: _create_log_handlers() and
2558             _create_debug_log_handlers().
2559         * Scripts/webkitpy/style/checker_unittest.py:
2560           - Added unit tests for configure_logging() with is_debug True
2561             by splitting the ConfigureLoggingTest class into
2562             ConfigureLoggingTest and ConfigureLoggingTestBase, and
2563             adding ConfigureLoggingDebugTest.
2564         * Scripts/webkitpy/style/optparser.py:
2565           - Updated the usage string.
2566           - Added an is_debug data attribute to the CommandOptionValues
2567             class.
2568           - Added support for the --debug flag to the ArgumentParser.parse()
2569             method.
2570           - Also added extra error information to the parse() method in
2571             the case of an invalid flag.
2572         * Scripts/webkitpy/style/optparser_unittest.py:
2573           - Updated the unit tests as necessary.
2574           - Also fixed an issue with the CommandOptionValuesTest.test_eq()
2575             unit test.
2576
2577 2010-03-23  Kent Tamura  <tkent@chromium.org>
2578
2579         Reviewed by Dimitri Glazkov.
2580
2581         [DRT/Chromium] Add TestNavigationController and TestWebWorker
2582         https://bugs.webkit.org/show_bug.cgi?id=36489
2583
2584         Add TestNavigationController and TestWebWorker classes, which are
2585         going to be used by DumpRenderTree Chromium port. These files are
2586         based on:
2587         - src/webkit/tools/test_shell/test_navigation_controller.{cc,h}
2588         - src/webkit/tools/test_shell/test_web_worker.h
2589         of Chromium rev.40492.
2590
2591         TestNavigationController has non-style changes.
2592         - Change ContentState type: binary string -> WebHistoryItem
2593         - Remove TestShell dependency by introducing NavigationHost interface.
2594
2595         * DumpRenderTree/chromium/TestNavigationController.cpp: Added.
2596         * DumpRenderTree/chromium/TestNavigationController.h: Added.
2597         * DumpRenderTree/chromium/TestWebWorker.h: Added.
2598
2599 2010-03-23  Eric Seidel  <eric@webkit.org>
2600
2601         Reviewed by Adam Barth.
2602
2603         Add support for revision -> build lookup in buildbot.py and layout test result parsing
2604         https://bugs.webkit.org/show_bug.cgi?id=36474
2605
2606         * Scripts/webkitpy/bugzilla_unittest.py: Added a FIXME about sharing code.
2607         * Scripts/webkitpy/buildbot.py: 
2608          - Add support for looking up builds by revision number.
2609          - Add support for fetching and parsing results.html files from buildbot.
2610          - build_for_revision has an allow_failed_lookups option to work around the fact that
2611            our buildbot's xmlrpc calls return failure on old revision numbers.
2612          - Add parsing support for twisted directory listings.
2613         * Scripts/webkitpy/buildbot_unittest.py:
2614          - Unit test all the new code.
2615         * Scripts/webkitpy/commands/queries.py:
2616          - Add a new results-for command which prints all the results for a given revision (very slow due to slow revision lookup)
2617
2618 2010-03-23  Daniel Bates  <dbates@rim.com>
2619
2620         Reviewed by Adam Roben.
2621
2622         https://bugs.webkit.org/show_bug.cgi?id=36048
2623
2624         Detect if the Windows Platform SDK is missing when building with
2625         Visual C++ Express Edition and inform the user to download it.
2626
2627         * Scripts/webkitdirs.pm:
2628
2629 2010-03-23  Darin Adler  <darin@apple.com>
2630
2631         Tell Subversion about more directories that expect to have .pyc files.
2632
2633         * Scripts/webkitpy: Modified property svn:ignore.
2634         * Scripts/webkitpy/irc: Added property svn:ignore.
2635
2636 2010-03-23  Daniel Bates  <dbates@rim.com>
2637
2638         Reviewed by Adam Barth.
2639
2640         https://bugs.webkit.org/show_bug.cgi?id=36149
2641
2642         Import the GNU readline interface to modify the behavior
2643         of raw_input so as to provide line editing support. In
2644         particular this will prevent "delete" characters from
2645         appearing in the returned value for function raw_input.
2646
2647         * Scripts/webkitpy/user.py:
2648
2649 2010-03-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2650
2651         Reviewed by Kenneth Rohde Christiansen.
2652
2653         [Qt] Remove support for Qt v4.4
2654         https://bugs.webkit.org/show_bug.cgi?id=36389
2655
2656         * DumpRenderTree/qt/main.cpp:
2657         (main):
2658         * QtLauncher/mainwindow.cpp:
2659         (MainWindow::MainWindow):
2660
2661 2010-03-22  Csaba Osztrogon√°c  <ossy@webkit.org>
2662
2663         Reviewed by Adam Barth.
2664
2665         Make build_webkit_command() pass MAKEFLAGS environment variable to make.
2666         https://bugs.webkit.org/show_bug.cgi?id=36440
2667
2668         * Scripts/webkitpy/webkitport.py:
2669         * Scripts/webkitpy/webkitport_unittest.py:
2670
2671 2010-03-22  Dirk Pranke  <dpranke@chromium.org>
2672
2673         Reviewed by Dimitri Glazkov.
2674
2675         Change baseline_path() to point to the upstream locations for the
2676         Chromium ports. Also change the reabselining scripts to use the
2677         correct functions to get the baseline directories, and fix the
2678         script's sys.path to pull in simplejson correctly.
2679
2680         https://bugs.webkit.org/show_bug.cgi?id=36417
2681
2682         * Scripts/rebaseline-chromium-webkit-tests:
2683           - fix sys.path to pick up simplejson properly
2684         * Scripts/webkitpy/layout_tests/port/chromium.py:
2685           - change baseline_path() to use webkit_baseline_path()
2686           - error out correctly if we can't find the chromium base dir
2687         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2688           - call baseline_path(), not chromium_baseline_path()
2689
2690 2010-03-22  Chris Jerdonek  <cjerdonek@webkit.org>
2691
2692         Reviewed by Adam Barth.
2693
2694         Refactored the cpu_count() code in executive.py.
2695
2696         https://bugs.webkit.org/show_bug.cgi?id=36437
2697
2698         * Scripts/webkitpy/executive.py:
2699           - Moved the import of the multiprocessing module to the top
2700             of the file rather than importing from within a function.
2701
2702 2010-03-22 Antonio Gomes <tonikitoo@webkit.org>
2703
2704         Unreviewed.
2705
2706         Rolling out r56183: http://trac.webkit.org/changeset/56183
2707
2708         https://bugs.webkit.org/show_bug.cgi?id=36244
2709
2710         Need to roll out because this patch will be re-worked by the author
2711         and other reviewers agreed on it.
2712
2713 2010-03-22  Chris Jerdonek  <cjerdonek@webkit.org>
2714
2715         Reviewed by Adam Barth.
2716
2717         Created a function for getting a module-specific logging.logger
2718         based on the __file__ value of the module.
2719
2720         https://bugs.webkit.org/show_bug.cgi?id=35821
2721
2722         This function allows us to get the module-specific logger for
2723         a module without having to hard-code the fully-qualified name
2724         of the module in the module itself.  The code can be the same
2725         in every case: "_log = logutils.get_logger(__file__)".
2726
2727         * Scripts/webkitpy/init/logutils.py: Added.
2728           - Added a module with a get_logger() function to return
2729             a module-specific logger based on the module's __file__
2730             variable.
2731
2732         * Scripts/webkitpy/init/logutils_unittest.py: Added.
2733           - Added unit tests for logutils.py.
2734
2735         * Scripts/webkitpy/init/unittests.py:
2736           - Added logutils_unittest to the list of imports.
2737
2738 2010-03-22  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2739
2740         Reviewed by Simon Hausmann.
2741
2742         [Qt] REGRESSION (r56209): fast/media/print-restores-previous-mediatype.htm crashes
2743         https://bugs.webkit.org/show_bug.cgi?id=36386
2744
2745         Fix the regression by implementing a null printer for Qt DRT.
2746
2747         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2748         (WebCore::NullPrinter::NullPaintEngine::begin):
2749         (WebCore::NullPrinter::NullPaintEngine::end):
2750         (WebCore::NullPrinter::NullPaintEngine::type):
2751         (WebCore::NullPrinter::NullPaintEngine::drawPixmap):
2752         (WebCore::NullPrinter::NullPaintEngine::updateState):
2753         (WebCore::NullPrinter::paintEngine):
2754         (WebCore::DumpRenderTree::dryRunPrint):
2755
2756 2010-03-20  Martin Robinson  <mrobinson@webkit.org>
2757
2758         Reviewed by Xan Lopez.
2759
2760         [GTK] eventSender.zoomPageOut() bug?
2761         https://bugs.webkit.org/show_bug.cgi?id=30575
2762
2763         Make zoomPage{In/Out}Callback respect the 1.2f zoom factor that DRT should be using.
2764
2765         * DumpRenderTree/gtk/EventSender.cpp:
2766         (zoomIn): Added.
2767         (zoomOut): Added.
2768         (textZoomInCallback): Use zoomIn helper function.
2769         (textZoomOutCallback): Use zoomOut helper function.
2770         (zoomPageInCallback): Use zoomIn helper function, which respects zoom factor.
2771         (zoomPageOutCallback): Use zoomOut helper function, which respects zoom factor.
2772
2773 2010-03-20  Kevin Ollivier  <kevino@theolliviers.com>
2774
2775         [wx] Build fix after recent database API change.
2776
2777         * wx/browser/browser.cpp:
2778         (MyApp::OnInit):
2779
2780 2010-03-20  Chris Jerdonek  <cjerdonek@webkit.org>
2781
2782         Reviewed by Adam Barth.
2783
2784         Renamed UnitTestLogStream to TestLogStream in webkitpy.
2785
2786         https://bugs.webkit.org/show_bug.cgi?id=36099
2787
2788         TestLogStream is more concise and more consistent with the name of
2789         the module (logtesting rather than logunittesting) and its main
2790         class (LogTesting rather than LogUnitTesting).
2791
2792         * Scripts/webkitpy/init/logtesting.py:
2793           - Renamings.
2794
2795         * Scripts/webkitpy/style/checker_unittest.py:
2796           - Renamings.
2797
2798         * Scripts/webkitpy/style_references.py:
2799           - Renamings.
2800
2801 2010-03-20  Kevin Ollivier  <kevino@theolliviers.com>
2802
2803         [wx] Build fixes for new method in LayoutTestController.
2804
2805         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2806         (LayoutTestController::setSpatialNavigationEnabled):
2807         * wx/build/settings.py:
2808
2809 2010-03-20  Dimitri Glazkov  <dglazkov@chromium.org>
2810
2811         Unreviewed, tool fix.
2812
2813         Remove vestiges of downstream directory names to unbreak rebaselining tool.
2814
2815         * Scripts/webkitpy/layout_tests/port/chromium.py: Changed paths to use WebKit repo.
2816
2817 2010-03-20  Dirk Pranke  <dpranke@chromium.org>
2818
2819         Reviewed by Dimitri Glazkov.
2820
2821         Re-enable the downstream test_expectations overrides file that was
2822         disabled in bug 36396 / r56287.
2823
2824         https://bugs.chromium.org/show_bug.cgi?id=36401
2825
2826         * Scripts/webkitpy/layout_tests/port/chromium.py:
2827
2828 2010-03-19  Dirk Pranke  <dpranke@chromium.org>
2829
2830         Reviewed by Dimitri Glazkov.
2831
2832         Disable the downstream override expectations temporarily to allow
2833         us to test that we've upstreamed everything correctly. Also, stop
2834         looking at the downstream baselines at all (now you will only be
2835         able to update baselines upstream). In theory this should work, but
2836         if we need to we can always add the downstream dirs back in.
2837
2838         https://bugs.webkit.org/show_bug.cgi?id=36396
2839
2840         * Scripts/webkitpy/layout_tests/port/chromium.py:
2841         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2842         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2843         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2844
2845 2010-03-19  Dirk Pranke  <dpranke@chromium.org>
2846
2847         Reviewed by Dimitri Glazkov.
2848
2849         fix typo in chromium test expectations overrides routine
2850         https://bugs.webkit.org/show_bug.cgi?id=36397
2851
2852         * Scripts/webkitpy/layout_tests/port/chromium.py:
2853
2854 2010-03-19  Dirk Pranke  <dpranke@chromium.org>
2855
2856         Reviewed by Dimitri Glazkov.
2857
2858         Flip the Chromium ports to look first for the test expectations
2859         in LayoutTests/platform/chromium and only afterwards look in the
2860         Chromium repo downstream for overrides.
2861
2862         https://bugs.webkit.org/show_bug.cgi?id=36326
2863
2864         * Scripts/webkitpy/layout_tests/port/chromium.py:
2865
2866 2010-03-19  James Hawkins  <jhawkins@chromium.org>
2867
2868         Unreviewed.
2869
2870         Add myself to the committers list.
2871
2872         * Scripts/webkitpy/committers.py:
2873
2874 2010-03-19  Adam Barth  <abarth@webkit.org>
2875
2876         Unreviewed.
2877
2878         Fix SheriffBot exception lock when we can't retrieve the first build
2879         from buildbot.  (I'll ask Eric to review this change after the fact,
2880         but he's at lunch and I want to get the bot unlocked.)
2881
2882         * Scripts/webkitpy/buildbot.py:
2883         * Scripts/webkitpy/buildbot_unittest.py:
2884
2885 2010-03-19  Alexey Proskuryakov  <ap@apple.com>
2886
2887         Reviewed by Darin Adler.
2888
2889         https://bugs.webkit.org/show_bug.cgi?id=36380
2890         websocket/tests/frame-lengths.html times out on Tiger bot
2891
2892         https://bugs.webkit.org/show_bug.cgi?id=35041
2893         websocket/tests/frame-lengths.html / websocket/tests/simple-stress.html fail on Windows bot
2894
2895         Double the timeout (from 15 seconds to 30 seconds). We can increase it more, if necessary -
2896         sampling the DRT process on Mac OS X takes much longer anyway, so it's better to avoid
2897         timing out than to detect it early.
2898
2899         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2900         (LayoutTestController::setWaitToDump):
2901         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2902         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2903         (LayoutTestController::waitUntilDone):
2904         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2905         * Scripts/run-webkit-tests:
2906
2907 2010-03-19  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2908
2909         Unreviewed.
2910
2911         Buildfix for Qt v4.5.
2912
2913         * QtLauncher/main.cpp:
2914         (LauncherWindow::LauncherWindow):
2915         (LauncherWindow::applyZoom):
2916
2917 2010-03-19  Adam Barth  <abarth@webkit.org>
2918
2919         Reviewed by Eric Seidel.
2920
2921         Operational tweaks to SheriffBot
2922         https://bugs.webkit.org/show_bug.cgi?id=36385
2923
2924         These changes aren't pretty, but they're helpful to make SheriffBot
2925         work operationally.  I plan to iterate in these areas, but I wanted to
2926         get this patch landed so I could be running the bot against TOT.
2927
2928         * Scripts/webkitpy/commands/sheriffbot.py:
2929         * Scripts/webkitpy/irc/ircbot.py:
2930         * Scripts/webkitpy/thirdparty/autoinstalled/__init__.py:
2931
2932 2010-03-19  Eric Seidel  <eric@webkit.org>
2933
2934         Reviewed by Adam Barth.
2935
2936         Help sheriff-bot avoid warning about flaky tests (and add more unit testing)
2937         https://bugs.webkit.org/show_bug.cgi?id=36354
2938
2939         * Scripts/webkitpy/buildbot.py:
2940          - Make Build creation easier to Mock and test
2941         * Scripts/webkitpy/buildbot_unittest.py:
2942          - Test finding green to red transitions and suspect revisions
2943         * Scripts/webkitpy/commands/queries.py:
2944          - Make what-broke note when builders have only failed once.
2945
2946 2010-03-19  Dirk Pranke  <dpranke@chromium.org>
2947
2948         Reviewed by Dimitri Glazkov.
2949
2950         Fix the rebaselining tool, which was broken by r36324 when I
2951         added the concept of overridding expectations.
2952
2953         https://bugs.webkit.org/show_bug.cgi?id=36374
2954
2955         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2956
2957 2010-03-19  Adam Barth  <abarth@webkit.org>
2958
2959         Reviewed by Eric Seidel.
2960
2961         Misc bug fixes to make the SheriffBot actually work
2962         https://bugs.webkit.org/show_bug.cgi?id=36355
2963
2964         With these changes, I can actually run the sheriff-bot from start to
2965         finish.
2966
2967         * Scripts/webkitpy/irc/ircproxy.py:
2968         * Scripts/webkitpy/patch/patcher.py:
2969         * Scripts/webkitpy/statusserver.py:
2970
2971 2010-03-19  Adam Barth  <abarth@webkit.org>
2972
2973         Unreviewed.
2974
2975         Actually import the sheriff-bot command so we can run it.  Also, move
2976         the bot to #webkit-test so it doesn't cause a ruckus while we test it.
2977
2978         * Scripts/webkitpy/patch/patcher.py:
2979         * Scripts/webkitpy/irc/ircbot.py:
2980
2981 2010-03-19  Adam Barth  <abarth@webkit.org>
2982
2983         Reviewed by Eric Seidel.
2984
2985         Second cut at SheriffBot
2986         https://bugs.webkit.org/show_bug.cgi?id=36353
2987
2988         This patch should contain a complete SheriffBot that's capable of
2989         saying reasonable things on IRC.  I had to refactor the use of
2990         CommitInfo to make the SheriffBot testable, but I did the minimum
2991         necessary.  We should grow webkitcheckout over time to contain the
2992         knowledge of ChangeLogs from scm.
2993
2994         * Scripts/webkitpy/commands/sheriffbot.py:
2995         * Scripts/webkitpy/commands/sheriffbot_unittest.py:
2996         * Scripts/webkitpy/mock_bugzillatool.py:
2997         * Scripts/webkitpy/patch/patcher.py:
2998         * Scripts/webkitpy/webkitcheckout.py: Added.
2999
3000 2010-03-19  Adam Barth  <abarth@webkit.org>
3001
3002         Unreviewed.
3003
3004         Fix Hyatt's IRC nickname.
3005
3006         * Scripts/webkitpy/committers.py:
3007
3008 2010-03-19  Adam Barth  <abarth@webkit.org>
3009
3010         Unreviewed.
3011
3012         Add IRC nicknames for the non-reviewer committers.
3013
3014         * Scripts/webkitpy/committers.py:
3015
3016 2010-03-19  Adam Barth  <abarth@webkit.org>
3017
3018         Unreviewed.
3019
3020         More reviewer IRC nicknames.
3021
3022         * Scripts/webkitpy/committers.py:
3023
3024 2010-03-19  Adam Barth  <abarth@webkit.org>
3025
3026         Unreviewed.
3027
3028         Add a bunch of IRC nicknames for reviewers.
3029
3030         * Scripts/webkitpy/committers.py:
3031
3032 2010-03-19  Zoltan Horvath  <zoltan@webkit.org>
3033
3034         Reviewed by Oliver Hunt.
3035
3036         Added USE_SYSTEM_MALLOC flag to build-webkit
3037         https://bugs.webkit.org/show_bug.cgi?id=21272
3038
3039         Add system-alloc flag to build-webkit. It makes easy to switch
3040         between system allocator and TCmalloc.
3041
3042         * Scripts/build-webkit:
3043
3044 2010-03-19  Adam Barth  <abarth@webkit.org>
3045
3046         Unreviewed "build" fix.
3047
3048         Of course, I caused a regression in the file that isn't tested.  :(
3049
3050         * Scripts/webkitpy/statusserver.py:
3051
3052 2010-03-19  Eric Seidel  <eric@webkit.org>
3053
3054         Reviewed by Adam Barth.
3055
3056         Add basic "who-broke-it" command and revision -> broken builder association code
3057         https://bugs.webkit.org/show_bug.cgi?id=36352
3058
3059         The "what-broke" command prints builders and what revisions we suspect
3060         broke them.  who-broke-it prints revisions and what builders we suspect
3061         they broke.  The sheriff-bot needs this revision to broken builder mapping
3062         so this change adds it!
3063
3064         * Scripts/webkitpy/buildbot.py:
3065         * Scripts/webkitpy/commands/queries.py:
3066
3067 2010-03-19  Eric Seidel  <eric@webkit.org>
3068
3069         Reviewed by Adam Barth.
3070
3071         Simplify BuildBot core builder code for easier re-use
3072         https://bugs.webkit.org/show_bug.cgi?id=36350
3073
3074         I simply couldn't see anything through all this Yak-hair.
3075
3076         * Scripts/webkitpy/buildbot.py:
3077         * Scripts/webkitpy/commands/queries.py:
3078
3079 2010-03-19  Adam Barth  <abarth@webkit.org>
3080
3081         Reviewed by Eric Seidel.
3082
3083         committers.py should know IRC nicknames
3084         https://bugs.webkit.org/show_bug.cgi?id=36349
3085
3086         I'll add the actual nicknames in another patch.
3087
3088         * Scripts/webkitpy/committers.py:
3089         * Scripts/webkitpy/committers_unittest.py:
3090
3091 2010-03-18  Anders Bakken  <agbakken@gmail.com>
3092
3093         Reviewed by Simon Hausmann.
3094
3095         https://bugs.webkit.org/show_bug.cgi?id=36318
3096
3097         QtLauncher runs as a GuiClient by default in Qt Embedded which will
3098         make it try to connect to an existing GuiServer. This patch makes it
3099         run like a stand-alone app.
3100
3101         * QtLauncher/main.cpp:
3102         (LauncherApplication::LauncherApplication):
3103
3104 2010-03-19  Eric Seidel  <eric@webkit.org>
3105
3106         Reviewed by Adam Barth.
3107
3108         Move find_green_to_red_transition out of "what-broke" onto Builder for easier re-use
3109         https://bugs.webkit.org/show_bug.cgi?id=36345
3110
3111         * Scripts/webkitpy/buildbot.py:
3112         * Scripts/webkitpy/commands/queries.py:
3113
3114 2010-03-19  Adam Barth  <abarth@webkit.org>
3115
3116         Reviewed by Adam Barth.
3117
3118         Actually pass the IRC password to the IRC object
3119         https://bugs.webkit.org/show_bug.cgi?id=36346
3120
3121         I wanted to do this before, but both patches were in flight.  This
3122         patch finally closes the loop and makes the IRCProxy system complete.
3123
3124         * Scripts/webkitpy/patch/patcher.py:
3125
3126 2010-03-18  Adam Barth  <abarth@webkit.org>
3127
3128         Reviewed by Eric Seidel.
3129
3130         Add a StatusServer front end to the SVNRevision table on QueueStatusServer
3131         https://bugs.webkit.org/show_bug.cgi?id=36344
3132
3133         No test because Browser was too hard to mock.  :(  I couldn't figure
3134         out how to make Mock be a dictionary as well as an object.
3135
3136         * Scripts/webkitpy/statusserver.py:
3137
3138 2010-03-18  Eric Seidel  <eric@webkit.org>
3139
3140         Reviewed by Adam Barth.
3141
3142         Split out CommitInfo class and add unit tests
3143         https://bugs.webkit.org/show_bug.cgi?id=36343
3144
3145         Move more logic out of "what-broke" into a shared CommitInfo
3146         class so that it can be used by other commands and unit tested.
3147
3148         * Scripts/webkitpy/commands/queries.py:
3149         * Scripts/webkitpy/commitinfo.py: Added.
3150         * Scripts/webkitpy/commitinfo_unittest.py: Added.
3151         * Scripts/webkitpy/unittests.py:
3152
3153 2010-03-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3154
3155         Reviewed by Kenneth Rohde Christiansen.
3156
3157         [Qt] Fix LayoutTests/http/tests/appcache/max-size.html
3158         https://bugs.webkit.org/show_bug.cgi?id=36207
3159
3160         Implement setAppCacheMaximumSize() for Qt.
3161
3162         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3163         (LayoutTestController::setAppCacheMaximumSize):
3164         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3165
3166 2010-03-18  Adam Barth  <abarth@webkit.org>
3167
3168         Reviewed by Eric Seidel.
3169
3170         QueueStatusServer should be able to log broken bots
3171         https://bugs.webkit.org/show_bug.cgi?id=36341
3172
3173         We need to add a new table to the QueueStatusServer to store persistent
3174         information for the SheriffBot.  The new table will keep track of which
3175         bots each SVN revision broke.
3176
3177         * QueueStatusServer/handlers/__init__.py:
3178         * QueueStatusServer/handlers/svnrevision.py: Added.
3179         * QueueStatusServer/handlers/updatebase.py: Added.
3180         * QueueStatusServer/handlers/updatestatus.py:
3181         * QueueStatusServer/handlers/updatesvnrevision.py: Added.
3182         * QueueStatusServer/index.yaml:
3183         * QueueStatusServer/main.py:
3184         * QueueStatusServer/model/__init__.py:
3185         * QueueStatusServer/model/svnrevision.py: Added.
3186         * QueueStatusServer/templates/updatesvnrevision.html: Added.
3187
3188 2010-03-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3189
3190         Reviewed by Darin Adler.
3191
3192         Add a new method to the Qt LayoutTestController for
3193         changing media type and make the DRT support dry-run printing.
3194
3195         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3196         (WebCore::DumpRenderTree::DumpRenderTree):
3197         (WebCore::DumpRenderTree::dryRunPrint):
3198         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3199         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3200         (LayoutTestController::setMediaType):
3201         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3202
3203 2010-03-18  Dirk Pranke  <dpranke@chromium.org>
3204
3205         Reviewed by Dimitri Glazkov.
3206
3207         Add upstream LayoutTests/platform/chromium* directories to the
3208         baseline search path for new-run-webkit-tests in preparation for
3209         upstreaming all of the Chromium baselines. Note that this does
3210         not actually create the directories themselves, but that's okay.
3211
3212         https://bugs.webkit.org/show_bug.cgi?id=36324
3213
3214         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3215         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3216         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3217
3218 2010-03-18  Alexey Proskuryakov  <ap@apple.com>
3219
3220         Reviewed by Anders Carlsson.
3221
3222         https://bugs.webkit.org/show_bug.cgi?id=36327
3223         Test that a plug-in can override Node methods of its element
3224
3225         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3226         (normalizeOverride):
3227         (pluginInvoke):
3228         Override "normalize", and call back to let a test know that the plug-in was called.
3229
3230 2010-03-17  Dirk Pranke  <dpranke@chromium.org>
3231
3232         Reviewed by Dimitri Glazkov.
3233
3234         Add the concept of an "overrides" file for expectations so that we
3235         can store test_expectations both upstream and downstream for a port
3236         that runs both in webkit.org and in a separate repository (like
3237         Chromium). Also add some unit tests for the expectations module.
3238
3239         https://bugs.webkit.org/show_bug.cgi?id=36249
3240
3241         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3242         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_test.py: Added.
3243         * Scripts/webkitpy/layout_tests/port/base.py:
3244         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3245
3246 2010-03-18  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
3247
3248         Reviewed by Kenneth Rohde Christiansen.
3249
3250         Add an overlay QGraphicsTextItem to QtLauncher so we can display FPS info
3251         on the launcher and not on the terminal anymore.
3252
3253         [Qt] QtLauncher's FPS info should be displayed on an overlay text item
3254         https://bugs.webkit.org/show_bug.cgi?id=36244
3255
3256         * QtLauncher/webview.cpp:
3257         (WebViewGraphicsBased::WebViewGraphicsBased):
3258         (WebViewGraphicsBased::setFrameRateMeasurementEnabled):
3259         (WebViewGraphicsBased::updateFrameRate):
3260         * QtLauncher/webview.h:
3261
3262 2010-03-18  Adam Barth  <abarth@webkit.org>
3263
3264         Reviewed by Eric Seidel.
3265
3266         First cut at SheriffBot
3267         https://bugs.webkit.org/show_bug.cgi?id=36253
3268
3269         This patch contains a first attempt at writing a sheriff bot.
3270         Currently, we're missing the logic that actually finds the SVN revision
3271         numbers to complain about, but once we have that, we'll have the rest
3272         of the infrustructure to ping IRC and to file bugs.
3273
3274         There's a lot to fill in for the SheriffBot, but this patch give us the
3275         framework in which to do it.
3276
3277         This patch required a bit of refactoring of AbstractQueue because
3278         SheriffBot is the first bot that doesn't process patches (it processes
3279         SVN revisions).  Accordingly, I've factored out AbstractPatchQueue to
3280         hold the parts of AbstractQueue that are specific to dealing with
3281         patches.  Some of the choices here might not be obvious yet, but we can
3282         tweak them as our needs become clearer.
3283
3284         * Scripts/webkitpy/commands/queues.py:
3285         * Scripts/webkitpy/commands/queues_unittest.py:
3286         * Scripts/webkitpy/commands/sheriffbot.py: Added.
3287         * Scripts/webkitpy/commands/sheriffbot_unittest.py: Added.
3288         * Scripts/webkitpy/mock_bugzillatool.py:
3289             Added a MockIRC object to the mock tool.
3290         * Scripts/webkitpy/multicommandtool.py:
3291             Added a finalize method so the tool can disconnect from IRC
3292             cleanly instead of just droping the socket.
3293         * Scripts/webkitpy/multicommandtool_unittest.py:
3294         * Scripts/webkitpy/patch/patcher.py:
3295             Added support for talking to IRC.
3296         * Scripts/webkitpy/unittests.py:
3297             We should add a commands/unittests.py file at some point to make
3298             the commands module more self-contained.
3299
3300 2010-03-18  Antti Koivisto  <koivisto@iki.fi>
3301
3302         Reviewed by Kenneth Rohde Christiansen.
3303
3304         https://bugs.webkit.org/show_bug.cgi?id=36102
3305         [Qt] Scaling control API for tiled backing store
3306         
3307         Add animated smooth zooming to Qt launcher when in tiled mode.
3308
3309         * QtLauncher/main.cpp:
3310         (LauncherWindow::LauncherWindow):
3311         (LauncherWindow::zoomAnimationFinished):
3312         (LauncherWindow::applyZoom):
3313         (LauncherWindow::zoomIn):
3314         (LauncherWindow::zoomOut):
3315         * QtLauncher/webview.h:
3316         (WebViewGraphicsBased::graphicsWebView):
3317
3318 2010-03-18  Adam Barth  <abarth@webkit.org>
3319
3320         Reviewed by Eric Seidel.
3321
3322         Support using IRC accounts with a password
3323         https://bugs.webkit.org/show_bug.cgi?id=36287
3324
3325         Add a global option to specify an IRC password so we can use the
3326         sheriffbot account (which needs a password).
3327
3328         * Scripts/webkitpy/irc/ircbot.py:
3329         * Scripts/webkitpy/irc/ircproxy.py:
3330         * Scripts/webkitpy/patch/patcher.py:
3331
3332 2010-03-18  Eric Seidel  <eric@webkit.org>
3333
3334         Just fixing missing parenthesis typo, no review.
3335
3336         * Scripts/webkitpy/commands/queries.py: '%' has higher precedence than 'or', use parentheses.
3337
3338 2010-03-18  Alexey Proskuryakov  <ap@apple.com>
3339
3340         Reviewed by Adam Roben and Anders Carlsson.
3341
3342         https://bugs.webkit.org/show_bug.cgi?id=36210
3343         plugins/resize-from-plugin.html fails on some platforms
3344
3345         Turns out that most platforms don't use "cross-platform" main.cpp. Copied code added for
3346         the test to their versions of the file.
3347
3348         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3349         (webkit_test_plugin_set_window):
3350         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
3351         (NPP_SetWindow):
3352
3353 2010-03-18  Leandro Pereira  <leandro@profusion.mobi>
3354
3355         Reviewed by Kenneth Rohde Christiansen.
3356
3357         Add support to run-launcher to open the EFL example browser.
3358         http://webkit.org/b/36181
3359
3360         * Scripts/webkitdirs.pm:
3361         * Scripts/run-launcher:
3362
3363 2010-03-18  Sergio Villar Senin  <svillar@igalia.com>
3364
3365         Reviewed by Xan Lopez.
3366
3367         [GTK] Failing tests http/tests/misc/image-blocked-src-change.html
3368         & http/tests/misc/image-blocked-src-no-change.html
3369         https://bugs.webkit.org/show_bug.cgi?id=36227
3370
3371         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3372         (webViewConsoleMessage): print only the file name instead of the
3373         whole URI when printing messages with local URI's
3374
3375 2010-03-18  Eric Seidel  <eric@webkit.org>
3376
3377         Reviewed by Adam Barth.
3378
3379         Teach what-broke how to look up reviewer and author Committer objects by name
3380         https://bugs.webkit.org/show_bug.cgi?id=36264
3381
3382         * Scripts/webkitpy/commands/queries.py:
3383          - Add committer_by_name lookups for both reviewer and author
3384          - Improve printing in the cases where lookups fail.
3385         * Scripts/webkitpy/committers.py:
3386          - Add committer_by_name
3387         * Scripts/webkitpy/committers_unittest.py:
3388          - Test committer_by_name
3389
3390 2010-03-17  Adam Barth  <abarth@webkit.org>
3391
3392         Reviewed by Eric Seidel.
3393
3394         create-rollout should actually fill out the description
3395         https://bugs.webkit.org/show_bug.cgi?id=36261
3396
3397         * Scripts/webkitpy/commands/download.py:
3398             The % operator was applied to the wrong string.
3399         * Scripts/webkitpy/commands/download_unittest.py:
3400         * Scripts/webkitpy/commands/upload_unittest.py:
3401         * Scripts/webkitpy/mock_bugzillatool.py:
3402             Add support for seeing what we actually do with create_bug.
3403
3404 2010-03-17  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
3405
3406         Reviewed by Kenneth Rohde Christiansen.
3407
3408         Accelerated Compositing is now default on QtWebKit so the option
3409         in QtLauncher must be true as default.
3410
3411         [Qt] QtLauncher's Accelerated Compositing option must be true as default
3412         https://bugs.webkit.org/show_bug.cgi?id=36234
3413
3414         * QtLauncher/main.cpp:
3415         (LauncherWindow::applyPrefs):
3416         (LauncherWindow::toggleAcceleratedCompositing):
3417         (LauncherApplication::handleUserOptions):
3418
3419 2010-03-17  Adam Barth  <abarth@webkit.org>
3420
3421         Reviewed by Eric Seidel.
3422
3423         Commit queue should ignore (probably red) builders when landing rollouts
3424         https://bugs.webkit.org/show_bug.cgi?id=36169
3425
3426         When landing a rollout, the builders are probably red, so we need to
3427         ignore them in the subprocess too.  Also, we might as well update the
3428         working copy because we haven't validated anything about the current
3429         revision prior to trying to land.
3430
3431         This change is testable, but it requires changing the mock executive to
3432         log its arguments.  That will generate a lot of expectation changes, so
3433         I'd like to do that in a separate patch.
3434
3435         * Scripts/webkitpy/commands/queues.py:
3436
3437 2010-03-17  Chang Shu  <chang.shu@nokia.com>
3438
3439         Reviewed by Laszlo Gombos.
3440
3441         https://bugs.webkit.org/show_bug.cgi?id=36139
3442         [Qt] Clean up cache each time DumpRenderTree starts. This behavior 
3443         matches other platforms, such as mac and gtk.
3444
3445         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3446         (WebCore::DumpRenderTree::DumpRenderTree):
3447
3448 2010-03-17  Adam Barth  <abarth@webkit.org>
3449
3450         Unreviewed.
3451
3452         Turns out this needs to be a string.
3453
3454         * Scripts/webkitpy/bugzilla.py:
3455
3456 2010-03-17  Eric Seidel  <eric@webkit.org>
3457
3458         Reviewed by Adam Barth.
3459
3460         Add more infrastructure for sheriff-bot, including making what-broke more awesome
3461         https://bugs.webkit.org/show_bug.cgi?id=36254
3462
3463         * Scripts/webkitpy/bugzilla.py:
3464          - Made the various URL methods return None when passed None.
3465         * Scripts/webkitpy/bugzilla_unittest.py:
3466          - Test that the url methods work as expected.
3467         * Scripts/webkitpy/buildbot.py:
3468          - Add a static Build.build_url so that its possible to generate a build url without a Build object.
3469          - Give users a URL in _fetch_xmlrpc_build_dictionary error message.
3470         * Scripts/webkitpy/changelogs.py:
3471          - Add a new ChangeLogEntry class to encapsulate entry-parsing logic.
3472          - Add is_path_to_changelog to greatly simplify SCM.modified_changelogs code.
3473          - Make ChangeLog.parse_latest_entry_from_file a public method.
3474         * Scripts/webkitpy/changelogs_unittest.py:
3475          - Add tests for new ChangeLog entry parsing.
3476         * Scripts/webkitpy/commands/queries.py:
3477          - Make "what-broke" not print "ok" builders, only failing ones.
3478          - Print much more information on failing builders, including links and authorship/reviewer information.
3479         * Scripts/webkitpy/commands/queues_unittest.py:
3480          - Use a fake_checkout path since fixing the cwd (as part of fixing scm_unittests.py) was breaking tests.
3481         * Scripts/webkitpy/mock_bugzillatool.py:
3482          - Move MockSCM away from using os.getcwd() as that was fragile (and wrong).
3483         * Scripts/webkitpy/patch/patcher.py:
3484          - Remove code which was broken now that this file has moved.
3485          - Code was also redundant now that SCM.find_checkout_root() exists.
3486         * Scripts/webkitpy/scm.py:
3487          - Greatly simplify modified_changelogs now that I understand list comprehensions.
3488          - Expect ChangeLogEntry objects instead of raw strings.
3489          - Add changed_files_for_revision, committer_email_for_revision and contents_at_revision
3490          - Add commit_with_message argument to all sites since someone half-added it before. :(
3491          - Get rid of copy/paste code using _status_regexp()
3492         * Scripts/webkitpy/scm_unittest.py:
3493          - Fix these tests!
3494          - Add new tests for new scm code.
3495          - Fix spelling of "awsome" to "awesome".
3496
3497 2010-03-17  Daniel Bates  <dbates@rim.com>
3498
3499         Rubber-stamped by David Levin.
3500
3501         Add myself to the list of reviewers.
3502
3503         * Scripts/webkitpy/committers.py:
3504
3505 2010-03-17  Adam Barth  <abarth@webkit.org>
3506
3507         Reviewed by Eric Seidel.
3508
3509         Change post-rollout to create-rollout and have it make a new bug
3510         instead of posting the rollout to the old bug.
3511         https://bugs.webkit.org/show_bug.cgi?id=36250
3512
3513         The new bug blocks the old bug instead of adding more complexity to the
3514         old bug.  One tricky question is whether to create the bug if we're
3515         unable to create a rollout patch.  In this patch, we do create the bug,
3516         but we might revist this question in the future.
3517
3518         * Scripts/webkitpy/bugzilla.py:
3519         * Scripts/webkitpy/commands/download.py:
3520         * Scripts/webkitpy/commands/download_unittest.py:
3521         * Scripts/webkitpy/steps/createbug.py:
3522
3523 2010-03-17  Adam Barth  <abarth@webkit.org>
3524
3525         Reviewed by Eric Seidel.
3526
3527         Add a way for the bots to send messages to IRC
3528         https://bugs.webkit.org/show_bug.cgi?id=36235
3529
3530         We'll use these classes to notify #webkit about bad SVN revisions.
3531         This patch just has some skeleton code for us to play with.
3532
3533         * Scripts/webkitpy/irc/__init__.py: Added.
3534         * Scripts/webkitpy/irc/ircbot.py: Added.
3535             A bot that knows how to talk to IRC.
3536         * Scripts/webkitpy/irc/ircproxy.py: Added.
3537             We need to run the bot on its own thread because the irclib needs
3538             its own mainloop.  This class provides an abstraction of the
3539             threading.
3540         * Scripts/webkitpy/irc/messagepump.py: Added.
3541         * Scripts/webkitpy/irc/messagepump_unittest.py: Added.
3542         * Scripts/webkitpy/irc/threadedmessagequeue.py: Added.
3543             A thread-safe message queue for sending messages from the main
3544             thread to the IRC thread.
3545         * Scripts/webkitpy/irc/threadedmessagequeue_unittest.py: Added.
3546         * Scripts/webkitpy/irc/unittests.py: Added.
3547         * Scripts/webkitpy/thirdparty/autoinstalled/__init__.py:
3548             Autoinstall irclib
3549         * Scripts/webkitpy/unittests.py:
3550
3551 2010-03-17  Victor Wang  <victorw@chromium.org>
3552
3553         Reviewed by Dimitri Glazkov.
3554
3555         Fix image_diff syntax in webkitpy/port/base.py.
3556         The syntax is wrong if diff_filename is specified.
3557
3558         https://bugs.webkit.org/show_bug.cgi?id=36230
3559
3560         * Scripts/webkitpy/layout_tests/port/base.py:
3561
3562 2010-03-16  Diego Gonzalez  <diego.gonzalez@openbossa.org>
3563
3564         Reviewed by Kenneth Christiansen.
3565
3566         Provide to QtLauncher a way to change the ViewportUpdateMode
3567         when it's in graphics based mode.
3568
3569         [Qt] Make QtLaucher able to select the ViewportUpdateMode
3570         https://bugs.webkit.org/show_bug.cgi?id