1b9936d42a1d0ba4354ad23c4b456549ed8f06b5
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-06-17  Tony Chang  <tony@chromium.org>
2
3         Reviewed by Kent Tamura.
4
5         [chromium] cleanup redundant DEPS value and remove buildbot cleanup code
6         https://bugs.webkit.org/show_bug.cgi?id=40615
7
8         * Scripts/update-webkit-chromium: remove directory removal of third_party in old checkouts
9
10 2010-06-17  Ada Chan  <adachan@apple.com>
11
12         Rolling out http://trac.webkit.org/changeset/61297 due to build errors.
13
14         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
15         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Copied from MiniBrowser/mac/WebBundle/WebBundleMain.c.
16         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
17
18 2010-06-17  Darin Adler  <darin@apple.com>
19
20         One more try at fix for Chromium build.
21
22         * DumpRenderTree/chromium/TestShell.cpp:
23         (TestShell::TestShell): Use set again instead of =.
24
25 2010-06-17  Darin Adler  <darin@apple.com>
26
27         Fix Chromium build.
28
29         I didn't realize that neither Chromium nor Qt share the DumpRenderTree
30         code with all the other platforms! Wow, that should be fixed at some point.
31
32         * DumpRenderTree/chromium/TestShell.cpp:
33         (TestShell::TestShell): Changed back to using "new".
34         * DumpRenderTree/chromium/TestShell.h: Changed back to OwnPtr.
35
36 2010-06-17  Simon Hausmann  <simon.hausmann@nokia.com>
37
38         Unreviewed Qt build fix.
39
40         LayoutTestController in the Qt DRT is not using refs :)
41
42         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
43         (WebCore::DumpRenderTree::DumpRenderTree):
44
45 2010-06-17  Darin Adler  <darin@apple.com>
46
47         Reviewed by Sam Weinig.
48
49         Use adoptRef and create functions in more code paths
50         https://bugs.webkit.org/show_bug.cgi?id=40760
51
52         * DumpRenderTree/DumpRenderTree.h: Change gLayoutTestController to a RefPtr.
53
54         * DumpRenderTree/LayoutTestController.cpp:
55         (LayoutTestController::create): Added.
56         * DumpRenderTree/LayoutTestController.h: Declare the create function.
57
58         * DumpRenderTree/chromium/TestShell.cpp:
59         (TestShell::TestShell): Use create instead of new.
60         * DumpRenderTree/chromium/TestShell.h: Use RefPtr instead of OwnPtr.
61
62         * DumpRenderTree/gtk/DumpRenderTree.cpp:
63         (runTest): Use RefPtr and create instead of OwnPtr and new.
64
65         * DumpRenderTree/mac/DumpRenderTree.mm:
66         (runTest): Use RefPtr and create instead of OwnPtr and new.
67
68         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
69         (WebCore::DumpRenderTree::DumpRenderTree): Use create and releaseRef
70         instead of new.
71
72         * DumpRenderTree/win/DumpRenderTree.cpp:
73         (runTest): Use RefPtr and create instead of OwnPtr and new.
74
75         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
76         (runTest): Use RefPtr and create instead of OwnPtr and new.
77         (MyApp::OnInit): Removed unneeded code to delete the layout
78         test controller. This is done during each test.
79
80 2010-06-17  Kent Tamura  <tkent@chromium.org>
81
82         Reviewed by Shinichiro Hamaji.
83
84         [DRT/Chromium] Fix a bug of Windows pixel tests
85         https://bugs.webkit.org/show_bug.cgi?id=40763
86
87         * DumpRenderTree/chromium/TestEventPrinter.cpp:
88         (TestShellPrinter::handleImage):
89
90 2010-06-16  Kent Tamura  <tkent@chromium.org>
91
92         Reviewed by Shinichiro Hamaji.
93
94         [DRT/Chromium] Fix crash on Mac Release
95         https://bugs.webkit.org/show_bug.cgi?id=40759
96
97         * DumpRenderTree/chromium/WebViewHost.cpp:
98         (WebViewHost::paintRect): We should not use m_canvas directly because
99           it is created lazily in canvas().
100
101 2010-06-16  Kevin Ollivier  <kevino@theolliviers.com>
102
103         [wx] Build fix after new method addition.
104
105         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
106         (LayoutTestController::pageProperty):
107
108 2010-06-16  Kent Tamura  <tkent@chromium.org>
109
110         Reviewed by Dimitri Glazkov.
111
112         [DRT/Chromium] Set current working directory for each of tests
113         https://bugs.webkit.org/show_bug.cgi?id=40668
114
115         This change fixes tests with eventSender.beginDragWithFiles().
116
117         * DumpRenderTree/chromium/DumpRenderTree.cpp:
118         (runTest):
119
120 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
121
122         Reviewed by Gustavo Noronha Silva.
123
124         [GTK] r60803 broke media/controls-drag-timebar.html
125         https://bugs.webkit.org/show_bug.cgi?id=40269
126
127         Only queue events while the mouse button is down, if drag mode is enabled. Some
128         tests may disable drag mode, to prevent the queuing of events in this situation.
129
130         * DumpRenderTree/gtk/EventSender.cpp:
131         (sendOrQueueEvent): Only queue events here if dragMode is true.
132
133 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
134
135         Reviewed by Gustavo Noronha Silva.
136
137         [GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
138         https://bugs.webkit.org/show_bug.cgi?id=40600
139
140         * DumpRenderTree/gtk/EventSender.cpp:
141         (prepareMouseButtonEvent): Remove logic adding an offset to GDK_CURRENT_TIME.
142
143 2010-06-16  Adam Barth  <abarth@webkit.org>
144
145         Reviewed by Dimitri Glazkov.
146
147         Add a hidden land-cowboy command to webkit-patch to help land quick
148         build fixes.
149
150         * Scripts/webkitpy/tool/commands/download.py:
151         * Scripts/webkitpy/tool/steps/preparechangelog.py:
152
153 2010-06-16  Adam Roben  <aroben@apple.com>
154
155         Convert console messages to UTF-8 before printing them
156
157         Speculative fix for <http://webkit.org/b/40731> REGRESSION (r61234):
158         http/tests/security/xssAuditor/embed-tag-null-char.html and
159         http/tests/security/xssAuditor/object-embed-tag-null-char.html fail on
160         Windows. (I can't test the fix because Apache is crashing on my
161         computer.)
162
163         Reviewed by Alexey Proskuryakov.
164
165         * DumpRenderTree/win/DumpRenderTree.cpp:
166         (toUTF8): Extracted the code into an overload that takes a wide string
167         and a length, then added an overload that takes a wstring.
168
169         * DumpRenderTree/win/DumpRenderTreeWin.h: Declare the new toUTF8
170         overload.
171
172         * DumpRenderTree/win/UIDelegate.cpp:
173         (UIDelegate::webViewAddMessageToConsole): Use toUTF8 to convert to
174         UTF-8 instead of letting printf convert to the current code page.
175
176 2010-06-16  Drew Wilson  <atwilson@chromium.org>
177
178         Reviewed by Kent Tamura.
179
180         [Chromium] Plumbing for top-level frame names
181         https://bugs.webkit.org/show_bug.cgi?id=40430
182
183         * DumpRenderTree/chromium/WebViewHost.cpp:
184         (WebViewHost::createView):
185         Migrate to new createView() API.
186         * DumpRenderTree/chromium/WebViewHost.h:
187         Remove obsolete createView() methods, add new createView() API that takes a frameName parameter.
188
189 2010-06-16  Diego Gonzalez  <diegohcg@webkit.org>
190
191         Reviewed by Kenneth Rohde Christiansen.
192
193         [Qt] Scroll wheel event support to graphics based DRT
194         https://bugs.webkit.org/show_bug.cgi?id=40577
195
196         * DumpRenderTree/qt/EventSenderQt.cpp:
197         (EventSender::continuousMouseScrollBy):
198         (EventSender::createGraphicsSceneWheelEvent):
199         * DumpRenderTree/qt/EventSenderQt.h:
200
201 2010-06-16  Adam Roben  <aroben@apple.com>
202
203         Remove a stray newline from the Windows version of TestNetscapePlugin
204
205         Reviewed by Alexey Proskuryakov.
206
207         Fixes <http://webkit.org/b/40728>
208         plugins/geturlnotify-during-document-teardown.html fails on Windows
209
210         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
211         (NPP_Destroy): Removed extra newline that the Mac version doesn't
212         have.
213
214 2010-06-16  Adam Roben  <aroben@apple.com>
215
216         Respect LayoutTestController::isPrinting on Windows
217
218         This gets some printing tests closer to passing (like
219         printing/page-rule-in-media-query.html).
220
221         Fixes <http://webkit.org/b/40727>.
222
223         Reviewed by Dan Bernstein.
224
225         * DumpRenderTree/win/DumpRenderTree.cpp:
226         (dump): Pass LayoutTestController::isPrinting to
227         IWebFramePrivate::renderTreeAsExternalRepresentation.
228
229 2010-06-15  Adam Barth  <abarth@webkit.org>
230
231         Reviewed by Eric Seidel.
232
233         Enable HTML5 lexer
234         https://bugs.webkit.org/show_bug.cgi?id=40650
235
236         * DumpRenderTree/mac/DumpRenderTree.mm:
237         (initializeGlobalsFromCommandLineOptions):
238
239 2010-06-10  Yuzo Fujishima  <yuzo@google.com>
240
241         Reviewed by Shinichiro Hamaji.
242
243         Implement render style selection for pages to support CSS3 Paged Media.
244         https://bugs.webkit.org/show_bug.cgi?id=35961
245
246         * DumpRenderTree/LayoutTestController.cpp:
247         (parsePagePropertyParameters):
248         (pagePropertyCallback):
249         (LayoutTestController::staticFunctions):
250         * DumpRenderTree/LayoutTestController.h:
251         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
252         (LayoutTestController::pageProperty):
253         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
254         (LayoutTestController::pageProperty):
255         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
256         (LayoutTestController::pageProperty):
257
258 2010-06-15  Sam Weinig  <sam@webkit.org>
259
260         Reviewed by Anders Carlsson.
261
262         Fix for https://bugs.webkit.org/show_bug.cgi?id=40630
263         WebKit2: Add mechanism to inject code into the WebProcess on startup
264
265         Add initial InjectedBundle support.
266
267         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
268         * MiniBrowser/WebBundle-Info.plist: Added.
269         Add test InjectedBundle to the project.
270
271         * MiniBrowser/mac/AppDelegate.m:
272         (-[BrowserAppDelegate init]):
273         Get the path to the WebBundle from the the main bundle and pass it to the new
274         WKContextCreateWithInjectedBundlePath function.
275
276         * MiniBrowser/mac/BrowserWindowController.m:
277         (_didChangeProgress):
278         Fix the build.  This has been broken for a while.
279
280         * MiniBrowser/mac/WebBundle: Added.
281         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Added.
282         (_didCreatePage):
283         (WKBundleInitialize):
284         Add really basic InjectedBundle.
285
286         * MiniBrowser/win/BrowserView.cpp:
287         (BrowserView::create):
288         Switch from WKContextCreateWithProcessModel to WKContextCreate and remove commented out code.
289
290 2010-06-15  Dumitru Daniliuc  <dumi@chromium.org>
291
292         Reviewed by Darin Adler.
293
294         Adding myself to the reviewers list.
295         https://bugs.webkit.org/show_bug.cgi?id=40693
296
297         * Scripts/webkitpy/common/config/committers.py:
298
299 2010-06-15  Martin Robinson  <mrobinson@igalia.com>
300
301         Reviewed by Xan Lopez.
302
303         Switch to using GIO methods instead of realpath in GtkLauncher to determine
304         the file URI. This should remove warnings about realpath being undefined
305         when compiling with '-ansi'.
306
307         * GtkLauncher/main.c:
308         (filenameToURL): Use GIO instead of realpath to determine file URI.
309
310 2010-06-15  Adam Roben  <aroben@apple.com>
311
312         Remove the redundant set-apple-windows-environment-variables script
313
314         Apparently update-webkit does this for you these days.
315
316         Rubber-stamped by Steve Falkenburg.
317
318         * Scripts/set-apple-windows-environment-variables: Removed.
319
320 2010-06-14  Adam Roben  <aroben@apple.com>
321
322         Add a script to set the WebKitOutputDir and WebKitLibrariesDir
323         environment variables
324
325         Fixes <http://webkit.org/b/40595>.
326
327         Reviewed by Steve Falkenburg.
328
329         * Scripts/set-apple-windows-environment-variables: Added.
330         (to_windows_path): Passes the passed-in path through cygpath to
331         generate a Windows-style path.
332         (main): Sets the WebKitOutputDir and WebKitLibrariesDir environment
333         variables to their defaults, if they aren't already set.
334
335 2010-06-14  Adam Roben  <aroben@apple.com>
336
337         Speed up run-safari/debug-safari on Windows
338
339         Fixes <http://webkit.org/b/40586>.
340
341         Reviewed by Steve Falkenburg.
342
343         * Scripts/webkitdirs.pm:
344         (runSafari): When debugging, set up the environment to run Safari
345         using the built WebKit.dll, then use "devenv /debugexe Safari.exe" to
346         actually launch the debugger. When not debugging, just run WebKit.exe
347         and it will do the rest for us.
348
349 2010-06-15  Diego Gonzalez  <diegohcg@webkit.org>
350
351         Reviewed by Kenneth Rohde Christiansen.
352
353         [Qt] DRT EventSender support to graphics context events
354         https://bugs.webkit.org/show_bug.cgi?id=40324
355
356         * DumpRenderTree/qt/EventSenderQt.cpp:
357         (EventSender::contextClick):
358
359 2010-06-14  Tony Chang  <tony@chromium.org>
360
361         Reviewed by Darin Fisher.
362
363         [chromium] checkout chromium third_party directly
364         https://bugs.webkit.org/show_bug.cgi?id=40556
365
366         * Scripts/update-webkit-chromium: some migration code for the bots
367
368 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
369
370         Chromium build fix.
371
372         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): Chromium uses differently
373         named constants for Windows virtual key codes, replacing VK_DELETE with VKEY_DELETE.
374
375 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
376
377         Reviewed by Darin Adler.
378
379         https://bugs.webkit.org/show_bug.cgi?id=40529
380         eventSender.keyDown("delete") incorrectly sends a backspace on some platforms
381
382         * DumpRenderTree/mac/EventSendingController.mm:
383         (-[EventSendingController keyDown:withModifiers:withLocation:]): We were sending a broken
384         event for "delete" - it had virtual key code from forward delete, and text from backspace.
385         Fixed "delete" to mean forward delete.
386
387         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown):
388         * DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
389         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
390         Mac DRT confusion has propagated to other platforms, fixing those.
391
392 2010-06-14  Martin Robinson  <mrobinson@igalia.com>
393
394         Reviewed by Xan Lopez.
395
396         Small GtkLauncher build fix for some systems.
397
398         * GtkLauncher/main.c: Add <limit.h> include.
399
400 2010-06-14  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
401
402         Reviewed by Laszlo Gombos.
403
404         [Qt] navigator.geolocation support for Qt port
405         https://bugs.webkit.org/show_bug.cgi?id=39724
406
407         Implementation for geolocation cases to DumpRenderTreeQt
408
409         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
410         (WebCore::WebPage::allowGeolocationRequest):
411         * DumpRenderTree/qt/DumpRenderTreeQt.h:
412         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
413         (LayoutTestController::setGeolocationPermission):
414         (LayoutTestController::setMockGeolocationError):
415         (LayoutTestController::setMockGeolocationPosition):
416         * DumpRenderTree/qt/LayoutTestControllerQt.h:
417         (LayoutTestController::isGeolocationPermissionSet):
418         (LayoutTestController::geolocationPermission):
419
420 2010-06-13  Nathan Lawrence  <nlawrence@apple.com>
421
422         Reviewed by Darin Adler.
423
424         Outside of Xcode (make or WebKitTools/Scripts), there doesn't seem to
425         be a way of overwriting the Xcode system path.  Making
426         $WEBKITOUTPUTDIR take precedence over the system default would make
427         this possible.
428
429         * Scripts/webkitdirs.pm:
430
431 2010-06-13  Chris Fleizach  <cfleizach@apple.com>
432
433         Reviewed by Darin Adler.
434
435         AX: link won't return linked element if URL contains #
436         https://bugs.webkit.org/show_bug.cgi?id=40192
437
438         * DumpRenderTree/AccessibilityUIElement.cpp:
439         (linkedUIElementAtIndexCallback):
440         (AccessibilityUIElement::getJSClass):
441         * DumpRenderTree/AccessibilityUIElement.h:
442         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
443         (AccessibilityUIElement::linkedUIElementAtIndex):
444         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
445         (AccessibilityUIElement::linkedUIElementAtIndex):
446         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
447         (AccessibilityUIElement::linkedUIElementAtIndex):
448
449 2010-06-13  Adam Barth  <abarth@webkit.org>
450
451         Reviewed by Darin Adler.
452
453         webkit-patch should add a bug URL to ChangeLogs if they don't have one yet
454         https://bugs.webkit.org/show_bug.cgi?id=39550
455
456         This can cause an extra request to bugs.webkit.org durig upload, but it
457         shouldn't be too bad.  Also, this won't work if you remove the
458         boilerplate created by prepare-ChangeLog.
459
460         * Scripts/webkitpy/common/checkout/changelog.py:
461         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
462         * Scripts/webkitpy/common/net/bugzilla.py:
463         * Scripts/webkitpy/tool/steps/abstractstep.py:
464         * Scripts/webkitpy/tool/steps/preparechangelog.py:
465         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: Added.
466
467 2010-06-08  Robert Hogan  <robert@webkit.org>
468
469         Reviewed by Eric Seidel.
470
471         [Qt] Add support for callShouldCloseOnWebView() to DRT
472         https://bugs.webkit.org/show_bug.cgi?id=40330
473
474         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
475         (LayoutTestController::callShouldCloseOnWebView):
476         * DumpRenderTree/qt/LayoutTestControllerQt.h:
477         (LayoutTestController::setCallCloseOnWebViews):
478
479 2010-06-12  Eric Seidel  <eric@webkit.org>
480
481         Reviewed by Daniel Bates.
482
483         do-webcore-rename should have a --verbose option
484         https://bugs.webkit.org/show_bug.cgi?id=40497
485
486         * Scripts/do-webcore-rename:
487          - Unified how we handle skipping files/directories
488            this will allow us to "black list" certain files and
489            directories when performing renames.
490          - Made do-webcore-rename log what it's skipping when passed --verbose.
491
492 2010-06-12  Darin Adler  <darin@apple.com>
493
494         * Scripts/run-bindings-tests: Fixed a typo in a message.
495
496 2010-06-12  Kent Tamura  <tkent@chromium.org>
497
498         Reviewed by Dimitri Glazkov.
499
500         [Chromium] new-run-webkit-tests --use-drt should work with Chromium checkout
501         https://bugs.webkit.org/show_bug.cgi?id=40402
502
503         _build_path() of each Chromium port check existence of build path
504         of Chromium checkout first, then check existence of build path of
505         WebKit-only checkout.
506
507         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
508         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
509         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
510
511 2010-06-12  Robert Hogan  <robert@webkit.org>
512
513         Reviewed by Kenneth Rohde Christiansen.
514
515         [Qt] Back-forward list dumping is incorrect
516
517         https://bugs.webkit.org/show_bug.cgi?id=36392
518
519         Support dumping child history items in DRT.
520
521         Unskip:
522
523         fast/loader/frame-src-change-added-to-history.html
524         fast/loader/frame-src-change-not-added-to-history.html
525         fast/loader/frame-location-change-not-added-to-history.html
526
527         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
528         (WebCore::dumpHistoryItem):
529
530 2010-06-10  Ojan Vafai  <ojan@chromium.org>
531
532         Reviewed by Eric Seidel.
533
534         upload all patches that lack in-rietveld to rietveld
535         https://bugs.webkit.org/show_bug.cgi?id=40444
536
537         If it's a patch, then we'll try to upload it as long as it
538         doesn't have in-rietveld set. No longer set in-rietveld? since
539         it's not needed.
540
541         * Scripts/webkitpy/common/net/bugzilla.py:
542
543 2010-06-10  Ojan Vafai  <ojan@chromium.org>
544
545         Reviewed by Darin Fisher.
546
547         Fix rietveld upload when message length > 100 characters
548         https://bugs.webkit.org/show_bug.cgi?id=40457
549
550         * Scripts/webkitpy/common/net/rietveld.py:
551
552 2010-06-11  Yael Aharon  <yael.aharon@nokia.com>
553
554         Reviewed by Laszlo Gombos.
555
556         [Qt] There should be a way to enable popups in QtTestBrowser
557         https://bugs.webkit.org/show_bug.cgi?id=40427
558
559         * QtTestBrowser/main.cpp:
560         (LauncherWindow::toggleJavascriptCanOpenWindows):
561         (LauncherWindow::createChrome):
562
563 2010-06-10  Adam Barth  <abarth@webkit.org>
564
565         Reviewed by Daniel Bates.
566
567         Make SheriffBot more chatty
568         https://bugs.webkit.org/show_bug.cgi?id=40463
569
570         People seem to like to talk to SheriffBot, so let's make him chat back.
571
572         * Scripts/webkitpy/thirdparty/__init__.py:
573         * Scripts/webkitpy/tool/bot/irc_command.py:
574         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Added.
575         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
576         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
577
578 2010-06-10  Brian Weinstein  <bweinstein@apple.com>
579
580         Reviewed by Darin Adler.
581
582         Fix the Windows buildbot when WebKitAuxiliaryLibs.zip cannot be found on our server.
583         
584         Robustify update-webkit-auxiliary-libs to be able to handle the case when WebKitAuxiliaryLibs.zip doesn't exist,
585         and allow the script to fall back to an existing file, only failing if there is no fallback file. Also switch to checking
586         WEXITSTATUS on $result instead of just comparing $result to 0.
587
588         * Scripts/update-webkit-auxiliary-libs:
589
590 2010-06-10  Ojan Vafai  <ojan@chromium.org>
591
592         Reviewed by Alexey Proskuryakov.
593
594         don't use Exception.message as it's deprecated in python 2.6+
595         https://bugs.webkit.org/show_bug.cgi?id=40449
596
597         * Scripts/webkitpy/tool/commands/queues.py:
598
599 2010-06-10  Ojan Vafai  <ojan@chromium.org>
600
601         Reviewed by Adam Barth.
602
603         fix handle_script_error in rietveld upload queue and add testing for handle_script_error
604         https://bugs.webkit.org/show_bug.cgi?id=40436
605
606         * Scripts/webkitpy/common/system/outputcapture.py:
607         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
608         * Scripts/webkitpy/tool/commands/queues.py:
609         * Scripts/webkitpy/tool/commands/queues_unittest.py:
610         * Scripts/webkitpy/tool/commands/queuestest.py:
611         * Scripts/webkitpy/tool/mocktool.py:
612
613 2010-06-10  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
614
615         Reviewed by Simon Hausmann.
616
617         [Qt] *All* WebGL layout tests fail!
618         https://bugs.webkit.org/show_bug.cgi?id=40296
619
620         Added test for WebKitWebGLEnabled to
621         LayoutTestController::overridePreference().
622
623         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
624         (LayoutTestController::overridePreference):
625
626 2010-06-10  Diego Gonzalez  <diegohcg@webkit.org>
627
628         Reviewed by Kenneth Rohde Christiansen.
629
630         [Qt] DRT EventSender support to graphics mouse events activation
631         https://bugs.webkit.org/show_bug.cgi?id=40017
632
633         * DumpRenderTree/qt/EventSenderQt.cpp:
634         (EventSender::mouseDown):
635         (EventSender::mouseUp):
636         (EventSender::mouseMoveTo):
637         (EventSender::keyDown):
638         (EventSender::contextClick):
639         (EventSender::sendTouchEvent):
640         (EventSender::sendOrQueueEvent):
641         (EventSender::eventFilter):
642         (EventSender::createGraphicsSceneMouseEvent):
643         (EventSender::sendEvent):
644         * DumpRenderTree/qt/EventSenderQt.h:
645         (EventSender::isGraphicsBased):
646
647 2010-06-09  Adam Barth  <abarth@webkit.org>
648
649         Reviewed by Ojan Vafai.
650
651         webkit-patch upload fails for security bugs because there's no rietveld flag
652         https://bugs.webkit.org/show_bug.cgi?id=40309
653
654         There's probably a more elegant way of seeing whether the form control
655         exists, but this seems to work.
656
657         * Scripts/webkitpy/common/net/bugzilla.py:
658
659 2010-06-09  Ojan Vafai  <ojan@chromium.org>
660
661         Reviewed by Adam Barth.
662
663         make rietveld upload faster and avoid posting to bug on errors
664         https://bugs.webkit.org/show_bug.cgi?id=40389
665
666         Only grab the first item of the upload queue instead of trying
667         to compute the whole list upfront (which is O(n) bugzilla lookups!).
668
669         Also, don't post comments to the bug when uploading fails.
670
671         * Scripts/webkitpy/common/net/bugzilla.py:
672         * Scripts/webkitpy/tool/commands/queues.py:
673         * Scripts/webkitpy/tool/commands/queues_unittest.py:
674         * Scripts/webkitpy/tool/commands/stepsequence.py:
675         * Scripts/webkitpy/tool/mocktool.py:
676
677 2010-06-09  Ojan Vafai  <ojan@chromium.org>
678
679         Reviewed by Adam Barth.
680
681         Rietveld upload queue fails when setting in-rietveld flag
682         https://bugs.webkit.org/show_bug.cgi?id=40371
683
684         Make the comment arguments to set_flag_on_attachment optional
685         and add it to the MockBugzilla.
686
687         * Scripts/webkitpy/common/net/bugzilla.py:
688         * Scripts/webkitpy/tool/bot/queueengine.py:
689         * Scripts/webkitpy/tool/commands/download_unittest.py:
690         * Scripts/webkitpy/tool/commands/queues.py:
691         * Scripts/webkitpy/tool/commands/queues_unittest.py:
692         * Scripts/webkitpy/tool/mocktool.py:
693
694 2010-06-09  Kenneth Russell  <kbr@google.com>
695
696         Reviewed by Dimitri Glazkov.
697
698         Rename FloatArray to Float32Array
699         https://bugs.webkit.org/show_bug.cgi?id=40323
700
701         Used do-webcore-rename to perform renaming. Manually undid
702         incorrect changes to WebCore/bridge/jni/jsc/JNIBridgeJSC.cpp,
703         WebCore/manual-tests/resources/ArrayParameterTestApplet.java and
704         ArrayParameterTestApplet.class. Updated LayoutTests. Built and ran
705         all layout tests on Safari; built Chromium and ran selected WebGL
706         tests.
707
708         * Scripts/do-webcore-rename:
709
710 2010-06-08  Tony Chang  <tony@chromium.org>
711
712         Reviewed by David Levin.
713
714         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
715         https://bugs.webkit.org/show_bug.cgi?id=40285
716
717         * Scripts/webkitdirs.pm:
718         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
719
720 2010-06-03  Roland Steiner  <rolandsteiner@chromium.org>
721
722         Reviewed by Tamura Kent.
723
724         Bug 40052 - [DRT/Chromium] Upstream test_shell_webthemeengine as WebThemeEngineDRT
725         https://bugs.webkit.org/show_bug.cgi?id=40052
726         
727         Add WebThemeEngineDRT and WebThemeControlDRT ported from Chromium rev. 48907
728
729         * DumpRenderTree/DumpRenderTree.gypi:
730         * DumpRenderTree/chromium/TestShellWin.cpp:
731         (platformInit):
732         * DumpRenderTree/chromium/WebThemeControlDRT.cpp: Added.
733         (WebKit::):
734         (WebKit::WebThemeControlDRT::WebThemeControlDRT):
735         (WebKit::WebThemeControlDRT::~WebThemeControlDRT):
736         (WebKit::WebThemeControlDRT::box):
737         (WebKit::WebThemeControlDRT::line):
738         (WebKit::WebThemeControlDRT::triangle):
739         (WebKit::WebThemeControlDRT::roundRect):
740         (WebKit::WebThemeControlDRT::oval):
741         (WebKit::WebThemeControlDRT::circle):
742         (WebKit::WebThemeControlDRT::nestedBoxes):
743         (WebKit::WebThemeControlDRT::markState):
744         (WebKit::WebThemeControlDRT::draw):
745         (WebKit::WebThemeControlDRT::drawTextField):
746         (WebKit::WebThemeControlDRT::drawProgressBar):
747         * DumpRenderTree/chromium/WebThemeControlDRT.h: Added.
748         (WebKit::WebThemeControlDRT::):
749         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp: Added.
750         (WebKit::):
751         (WebKit::WebThemeEngineDRT::paintButton):
752         (WebKit::WebThemeEngineDRT::paintMenuList):
753         (WebKit::WebThemeEngineDRT::paintScrollbarArrow):
754         (WebKit::WebThemeEngineDRT::paintScrollbarThumb):
755         (WebKit::WebThemeEngineDRT::paintScrollbarTrack):
756         (WebKit::WebThemeEngineDRT::paintTextField):
757         (WebKit::WebThemeEngineDRT::paintTrackbar):
758         (WebKit::WebThemeEngineDRT::paintProgressBar):
759         * DumpRenderTree/chromium/WebThemeEngineDRT.h: Added.
760         (WebKit::WebThemeEngineDRT::WebThemeEngineDRT):
761
762 2010-06-08  Sheriff Bot  <webkit.review.bot@gmail.com>
763
764         Unreviewed, rolling out r60878.
765         http://trac.webkit.org/changeset/60878
766         https://bugs.webkit.org/show_bug.cgi?id=40349
767
768         broke linux build (Requested by tony^work on #webkit).
769
770         * Scripts/webkitdirs.pm:
771         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
772
773 2010-06-08  Tony Chang  <tony@chromium.org>
774
775         Reviewed by David Levin.
776
777         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
778         https://bugs.webkit.org/show_bug.cgi?id=40285
779
780         * Scripts/webkitdirs.pm:
781         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
782
783 2010-06-08  Kenneth Russell  <kbr@google.com>
784
785         Unreviewed, build fix.
786
787         Fix build breakage from 38145
788         https://bugs.webkit.org/show_bug.cgi?id=40346
789
790         The fix for bug 38145 broke the Chromium Win build because
791         Microsoft's cmath doesn't define log2. Suggested fix by zmo is to
792         change log2(x) to log(x) / log(2). Built and ran WebGL layout
793         tests in Safari on Mac OS X. Changed download mirrors for
794         python-irclib to working ones.
795
796         * Scripts/webkitpy/thirdparty/__init__.py:
797
798 2010-06-08  Fumitoshi Ukai  <ukai@chromium.org>
799
800         Reviewed by Eric Seidel.
801
802         old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
803         https://bugs.webkit.org/show_bug.cgi?id=39058
804
805         * Scripts/old-run-webkit-tests:
806          use sourceDir() to find ensure-valid-python in checkPythonVersion()
807
808 2010-06-08  Andras Becsi  <abecsi@webkit.org>
809
810         Unreviewed buildfix after r60479.
811
812         [GTK] Move the declaration of getRootCoords higher up to fix the build on GTK
813         versions other than 2.17.3.
814
815         * DumpRenderTree/gtk/EventSender.cpp:
816         (getRootCoords):
817
818 2010-06-07  Martin Robinson  <mrobinson@igalia.com>
819
820         Reviewed by Oliver Hunt.
821
822         [GTK] Mouse movement should not trigger a replay of saved events in the event sender
823         https://bugs.webkit.org/show_bug.cgi?id=40267
824
825         When a mouse button is down, automatically queue mouse motion events and
826         do not play them back until the mouse button is released. This matches the
827         behavior of other ports' EventSenders.
828
829         * DumpRenderTree/gtk/EventSender.cpp:
830         (mouseMoveToCallback): Don't automatically replaySavedEvents for mouse motion.
831         (sendOrQueueEvent): Add a shouldReplaySavedEvents argument defaulting to true.
832
833 2010-06-07  Nikolas Zimmermann  <nzimmermann@rim.com>
834
835         Reviewed by Sam Weinig.
836
837         Add CPP bindings generator
838         https://bugs.webkit.org/show_bug.cgi?id=38279
839
840         Integrate CPP bindings in run-bindings-tests.
841
842         * Scripts/run-bindings-tests:
843
844 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
845
846         Reviewed by Ojan Vafai.
847
848         Rename 'svn_merge_base' -> 'remote_merge_base'. This was left out of r60633.
849         https://bugs.webkit.org/show_bug.cgi?id=40183
850
851         * Scripts/webkitpy/tool/steps/preparechangelog.py:
852
853 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
854
855         Unreviewed.
856
857         Add my new email and IRC nick to committers.py.
858
859         * Scripts/webkitpy/common/config/committers.py:
860
861 2010-06-04  Kinuko Yasuda  <kinuko@chromium.org>
862
863         Unreviewed.
864
865         Revert changes in json_results_generator.py's _get_svn_revision.
866
867         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
868
869 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
870
871         Reviewed by Xan Lopez.
872
873         [GTK] GtkLauncher should support relative file paths
874         https://bugs.webkit.org/show_bug.cgi?id=39944
875
876         Allow GtkLauncher to handle relative file paths passed via command-line arguments.
877
878         * GtkLauncher/main.c:
879         (filename_to_url): Added.
880         (main): Try to resolve arguments as relative file URLs first.
881
882 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
883
884         Reviewed by Xan Lopez.
885
886         [GTK] EventSender should call gtk_main_do_event instead of invoking signal handlers directly
887         https://bugs.webkit.org/show_bug.cgi?id=40182
888
889         Instead of invoking signal handlers directly via g_signal_emit_by_name, call
890         gtk_main_do_event. This will allow us to call gtk_get_current_event() in WebKit
891         without breaking DRT.
892
893         * DumpRenderTree/gtk/EventSender.cpp:
894         (dispatchEvent): Use gtk_main_do_event instead of invoking signal handlers directly.
895         (keyDownCallback): Use dispatchEvent here which now uses gtk_main_do_event.
896
897 2010-06-04  Anders Carlsson  <andersca@apple.com>
898
899         Reviewed by David Hyatt.
900
901         Make the editing/spelling/context-menu-suggestions.html test more robust
902         https://bugs.webkit.org/show_bug.cgi?id=40178
903
904         Change the contextClick method to return an array of strings describing the context menu items.
905
906         * DumpRenderTree/mac/EventSendingController.mm:
907         (+[EventSendingController isSelectorExcludedFromWebScript:]):
908         (+[EventSendingController webScriptNameForSelector:]):
909         (-[EventSendingController contextClick]):
910
911 2010-06-03  Kinuko Yasuda  <kinuko@chromium.org>
912
913         Reviewed by Shinichiro Hamaji.
914
915         Clean up chromium-specific code from json_results_generator.py.
916         https://bugs.webkit.org/show_bug.cgi?id=39665
917
918         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
919         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
920         * Scripts/webkitpy/layout_tests/port/base.py:
921         * Scripts/webkitpy/layout_tests/port/chromium.py:
922
923 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
924
925         Reviewed by Adam Barth.
926
927         Utilize new takeFirst() method where appropriate.
928         https://bugs.webkit.org/show_bug.cgi?id=40089
929
930         * DumpRenderTree/chromium/EventSender.cpp:
931         (EventSender::replaySavedEvents):
932         * DumpRenderTree/chromium/LayoutTestController.cpp:
933         (LayoutTestController::WorkQueue::processWork):
934         (LayoutTestController::WorkQueue::reset):
935
936 2010-06-04  Yael Aharon  <yael.aharon@nokia.com>
937
938         Reviewed by Simon Hausmann.
939
940         [Qt] QtTestLauncher should allow notifications by default.
941         https://bugs.webkit.org/show_bug.cgi?id=40078
942
943         * QtTestBrowser/main.cpp:
944         (NotificationsPermissionController::NotificationsPermissionController):
945         (NotificationsPermissionController::checkPermission):
946         (NotificationsPermissionController::requestPermission):
947         (LauncherWindow::LauncherWindow):
948
949 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
950
951         Reviewed by Adam Barth.
952
953         Detect whether the user's environment can open a browser.
954         https://bugs.webkit.org/show_bug.cgi?id=40136
955
956         Some environments like cygwin silently fail webbrowser.open() causing
957         webkit-patch upload not to display any diff. This detects environments
958         where webbrowser.open() would fail by testing if webbrowser.get()
959         raises an exception.
960
961         * Scripts/webkitpy/common/system/user.py:
962         * Scripts/webkitpy/tool/mocktool.py:
963         * Scripts/webkitpy/tool/steps/confirmdiff.py:
964
965 2010-06-03  Tony Gentilcore  <tonyg@chromium.org>
966
967         Reviewed by David Levin.
968
969         Add dependencies required to link with VS Express 2005.
970         https://bugs.webkit.org/show_bug.cgi?id=40038
971
972         Visual Studio implicitly links against these libs.
973         VC++ Express does not.
974
975         * WebKitAPITest/WebKitAPITestCommon.vsprops:
976         * WinLauncher/WinLauncher.vcproj:
977
978 2010-06-03  Fumitoshi Ukai  <ukai@chromium.org>
979
980         Reviewed by David Levin.
981
982         bad codecs.open in webkitpy/layout_tests/ports/websocket_server.py
983         https://bugs.webkit.org/show_bug.cgi?id=40105
984
985         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
986         - kill pywebsocket process when url is not alive and the process is not
987           terminated, not to leave pywebsocket server running.
988         - fix codecs.open parameters.
989
990 2010-06-03  Fumitoshi Ukai  <ukai@chromium.org>
991
992         Reviewed by Alexey Proskuryakov.
993
994         old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
995         https://bugs.webkit.org/show_bug.cgi?id=39058
996
997         * Scripts/ensure-valid-python:
998           - Perl 5.8 doesn't have File::Temp->newdir().  Use File::Temp->tempdir() instead.
999           - Add --check-only and --help option.
1000           - --check-only option only checks python version and don't try to install Python 2.5.
1001           - Set executable bit.
1002         * Scripts/old-run-webkit-tests:
1003           - Check if it can run the websocket tests by calling ensure-valid-python --check-only.
1004
1005 2010-05-14  Ojan Vafai  <ojan@chromium.org>
1006
1007         Reviewed by Adam Barth.
1008
1009         add a RietveldUploadQueue to upload in-rietveld? patches to rietveld
1010         https://bugs.webkit.org/show_bug.cgi?id=38918
1011
1012         Patches with in-rietveld? get uploaded to rietveld and get marked
1013         in-rietveld+. If the upload fails, they are marked in-rietveld-
1014         and an error is logged to the bug, like the commit-queue.
1015
1016         Also, get rid of --fancy-review and the ability to upload to rietveld
1017         using webkit-patch upload/post.
1018
1019         * Scripts/webkitpy/common/net/bugzilla.py:
1020         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1021         * Scripts/webkitpy/tool/commands/download.py:
1022         * Scripts/webkitpy/tool/commands/download_unittest.py:
1023         * Scripts/webkitpy/tool/commands/queues.py:
1024         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1025         * Scripts/webkitpy/tool/commands/upload.py:
1026         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1027         * Scripts/webkitpy/tool/mocktool.py:
1028         * Scripts/webkitpy/tool/steps/options.py:
1029         * Scripts/webkitpy/tool/steps/postcodereview.py:
1030
1031 2010-05-24  Ojan Vafai  <ojan@chromium.org>
1032
1033         Reviewed by Chris Jerdonek.
1034
1035         many webkit-patch commands fail in a non-svn tracking git checkout
1036         https://bugs.webkit.org/show_bug.cgi?id=38156
1037
1038         If the svn-tracking-branch (trunk) doesn't exist, fallback to the git remote-tracking-branch (master).
1039         If neither exists, then error out. This makes webkit-patch work
1040         for anyone that follows the intructions at http://trac.webkit.org/wiki/UsingGitWithWebKit
1041         to checkout webkit. The fallback to master is for people who don't
1042         do the steps on that page for tracking svn.
1043
1044         * Scripts/webkitpy/common/checkout/scm.py:
1045         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1046
1047 2010-06-03  Mike Fenton  <mifenton@rim.com>
1048
1049         Unreviewed.
1050
1051         Reverse e-mail for myself in committers.py to correspond with bugzilla account.
1052
1053         * Scripts/webkitpy/common/config/committers.py:
1054
1055 2010-06-03  Pavel Feldman  <pfeldman@chromium.org>
1056
1057         Reviewed by Yury Semikhatsky.
1058
1059         Web Inspector: a number of fixes that make InspectorController
1060         happy with null redirects.
1061
1062         https://bugs.webkit.org/show_bug.cgi?id=40109
1063
1064         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1065         (runTest):
1066         * DumpRenderTree/mac/DumpRenderTree.mm:
1067         (runTest):
1068         * DumpRenderTree/win/DumpRenderTree.cpp:
1069         (runTest):
1070
1071 2010-06-02  Tasuku Suzuki  <tasuku.suzuki@nokia.com>
1072
1073         Reviewed by Shinichiro Hamaji.
1074
1075         [Qt] Fix compilation with QT_NO_PROPERTIES
1076         https://bugs.webkit.org/show_bug.cgi?id=38324
1077
1078         * QtTestBrowser/main.cpp:
1079         (LauncherWindow::init):
1080
1081 2010-06-02  Diego Gonzalez  <diegohcg@webkit.org>
1082
1083         Reviewed by Kenneth Rohde Christiansen.
1084
1085         [Qt] Make possible run DRT with QGraphicsWebView
1086         https://bugs.webkit.org/show_bug.cgi?id=40016
1087
1088         Make possible to use a environment variable for switching backend.
1089         Usage: QT_DRT_WEBVIEW_MODE=graphics WebKitTools/Scripts/run-webkit-tests --qt
1090
1091         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1092         (WebCore::WebViewGraphicsBased::WebViewGraphicsBased):
1093         (WebCore::DumpRenderTree::DumpRenderTree):
1094         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1095         (WebCore::DumpRenderTree::setGraphicsBased):
1096         (WebCore::DumpRenderTree::isGraphicsBased):
1097         (WebCore::WebViewGraphicsBased::graphicsView):
1098         (WebCore::WebViewGraphicsBased::setPage):
1099         * Scripts/old-run-webkit-tests:
1100
1101 2010-06-02  Csaba Osztrogon√°c  <ossy@webkit.org>
1102
1103         Reviewed by Eric Seidel.
1104
1105         Slave lost shouldn't be recognized as build failed.
1106         https://bugs.webkit.org/show_bug.cgi?id=39282
1107
1108         * Scripts/webkitpy/common/net/buildbot.py: Treat slave lost as green.
1109         * Scripts/webkitpy/common/net/buildbot_unittest.py: Add unit test for slave lost.
1110
1111 2010-06-01  Yael Aharon  <yael.aharon@nokia.com>
1112
1113         Reviewed by Kenneth Rohde Christiansen.
1114
1115         [Qt] Fix the lifecycle of notification objects
1116         https://bugs.webkit.org/show_bug.cgi?id=40003
1117
1118         Remove the dependency of notifications on QWebPage.
1119
1120         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1121         (WebCore::requestPermissionCallback):
1122         (WebCore::WebPage::WebPage):
1123         (WebCore::DumpRenderTree::requestPermission):
1124         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1125
1126 2010-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1127
1128         Unreviewed, rolling out r60559.
1129         http://trac.webkit.org/changeset/60559
1130         https://bugs.webkit.org/show_bug.cgi?id=40055
1131
1132         It broke python unit test (Requested by Ossy on #webkit).
1133
1134         * Scripts/webkitpy/common/net/buildbot.py:
1135
1136 2010-06-02  Csaba Osztrogon√°c  <ossy@webkit.org>
1137
1138         Reviewed by Eric Seidel.
1139
1140         Slave lost shouldn't be recognized as build failed.
1141         https://bugs.webkit.org/show_bug.cgi?id=39282
1142
1143         * Scripts/webkitpy/common/net/buildbot.py:
1144
1145 2010-06-02  Tony Gentilcore  <tonyg@chromium.org>
1146
1147         Reviewed by Eric Seidel.
1148
1149         Fix crash caused when assigned_to is disabled
1150         https://bugs.webkit.org/show_bug.cgi?id=40039
1151
1152         * Scripts/webkitpy/common/net/bugzilla.py:
1153
1154 2010-06-02  Sterling Swigart  <sswigart@google.com>
1155
1156         Reviewed by David Levin.
1157
1158         Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
1159         https://bugs.webkit.org/show_bug.cgi?id=39906
1160
1161         * Scripts/build-webkit:
1162
1163 2010-06-01  Raine Makelainen  <raine.makelainen@nokia.com>
1164
1165         Reviewed by Simon Hausmann.
1166
1167         Fixed tests to use QWebSettings::JavascriptCanAccessClipboard instead of QWebSettings::JavaScriptCanAccessClipboard.
1168
1169         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1170         (WebCore::WebPage::WebPage):
1171         (WebCore::WebPage::resetSettings):
1172         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1173         (LayoutTestController::setJavaScriptCanAccessClipboard):
1174
1175 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
1176
1177         Reviewed by Mark Rowe.
1178
1179         A nicer Tiger build fix.
1180
1181         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1182         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1183         Enable GCC_OBJC_CALL_CXX_CDTORS via .xcconfig.
1184
1185 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
1186
1187         A real Tiger build fix.
1188
1189         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS
1190         for all configurations, not just debug.
1191
1192 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
1193
1194         Tiger build fix.
1195
1196         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS.
1197
1198 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
1199
1200         Reviewed by Xan Lopez.
1201
1202         [GTK] Get more mouse tests passing
1203         https://bugs.webkit.org/show_bug.cgi?id=39040
1204
1205         Reproduce the logic from the Windows EventSender for mapping
1206         button numbers to GDK button numbers. Move this logic to the
1207         prepareMouseButtonEvent helper.
1208
1209         * DumpRenderTree/gtk/EventSender.cpp:
1210         (prepareMouseButtonEvent): Reproduce Windows logic.
1211         (contextClickCallback): Move mapping logic to prepareMouseButtonEvent.
1212         (mouseDownCallback): Ditto.
1213         (mouseUpCallback): Ditto.
1214
1215 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
1216
1217         Reviewed by Sam Weinig.
1218
1219         https://bugs.webkit.org/show_bug.cgi?id=39434
1220         REGRESSION (r59811): Geolocation callbacks cannot be created
1221
1222         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added MockGeolocationProvider.
1223
1224         * DumpRenderTree/mac/DumpRenderTree.mm:
1225         (createWebViewAndOffscreenWindow): Tell the view to use MockGeolocationProvider. 
1226         (resetWebViewToConsistentStateBeforeTesting): Make sure that mock notifications don't leak
1227         into subsequent tests.
1228
1229         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1230         (LayoutTestController::setMockGeolocationPosition): Changed to use MockGeolocationProvider.
1231         (LayoutTestController::setMockGeolocationError): Ditto.
1232
1233         * DumpRenderTree/mac/MockGeolocationProvider.h: Added.
1234         * DumpRenderTree/mac/MockGeolocationProvider.mm: Added.
1235         (+[MockGeolocationProvider shared]):
1236         (-[MockGeolocationProvider dealloc]):
1237         (-[MockGeolocationProvider setPosition:]):
1238         (-[MockGeolocationProvider setError:]):
1239         (-[MockGeolocationProvider registerWebView:]):
1240         (-[MockGeolocationProvider unregisterWebView:]):
1241         (-[MockGeolocationProvider lastPosition]):
1242         (-[MockGeolocationProvider stopTimer]):
1243         (-[MockGeolocationProvider timerFired]):
1244
1245         * DumpRenderTree/mac/UIDelegate.mm:
1246         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
1247         This delegate method must send a response. I'm not sure what the two-stage check is supposed
1248         to achieve, it seems unnecessary.
1249
1250 2010-05-12  Martin Robinson  <mrobinson@igalia.com>
1251
1252         Reviewed by Xan Lopez.
1253
1254         [GTK] Double clicks cause three button press events
1255         https://bugs.webkit.org/show_bug.cgi?id=38853
1256
1257         WebKit now filters the extra GDK_BUTTON_PRESS before GDK_2BUTTON_PRESS
1258         and GDK_3BUTTON_PRESS via gdk_event_peek(). Since EventSender bypasses
1259         the GDK event queue entirely, we simply do not send the extra event.
1260
1261         * DumpRenderTree/gtk/EventSender.cpp:
1262         (mouseDownCallback): Do not send extra event. Send GDK_3BUTTON_PRESS appropriately.
1263         (dispatchEvent): Properly handle GDK_3BUTTON_PRESS.
1264
1265 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
1266
1267         Not reviewed. Build fix.
1268
1269         Fix GTK+ build caused by a bad merge.
1270
1271         * DumpRenderTree/gtk/EventSender.cpp: 
1272         (prepareMouseButtonEvent): Use the GdkEvent union as a pointer here.
1273
1274 2010-06-01  Martin Robinson  <mrobinson@webkit.org>
1275
1276         Reviewed by Xan Lopez.
1277
1278         [GTK] Double clicks cause three button press events
1279         https://bugs.webkit.org/show_bug.cgi?id=38853
1280
1281         Small EventSender cleanups. Consolidate some common code. Style fixes.
1282
1283         * DumpRenderTree/gtk/EventSender.cpp:
1284         (prepareMouseButtonEvent): Added.
1285         (contextClickCallback): Use prepareMouseButtonEvent.
1286         (mouseDownCallback): Use prepareMouseButtonEvent.
1287         (mouseUpCallback): Use prepareMouseButtonEvent.
1288         (mouseMoveToCallback): Small style fix.
1289
1290 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
1291
1292         Reviewed by Xan Lopez.
1293
1294         [GTK] Double clicks cause three button press events
1295         https://bugs.webkit.org/show_bug.cgi?id=38853
1296
1297         Add rudimentary leapForward support to the GTK+ DRT. leapForward allows a test
1298         to pause for a specified amount of time. It is used in the processing of drag-
1299         -and-drop data as well as to separate distinct mouse double-clicks in some tests.
1300         This patch enables tests that rely on the latter behavior to pass.
1301
1302         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1303         (webViewWindowObjectCleared): Only initialize the EventSender when loading the top frame.
1304         * DumpRenderTree/gtk/EventSender.cpp:
1305         (leapForwardCallback): Add support for adjusting the time offset on leapForward().
1306         (contextClickCallback): Use sendOrQueueEvent.
1307         (updateClickCount): Take the time offset into account when counting clicks.
1308         (mouseDownCallback): Use sendOrQueueEvent.
1309         (getStateFlags): Change down/currentEventButton into buttonCurrentlyDown/lastClickButton.
1310         (mouseUpCallback): Use sendOrQueueEvent.
1311         (mouseMoveToCallback): Ditto.
1312         (mouseWheelToCallback): Ditto.
1313         (sendOrQueueEvent): Added.
1314         (dispatchEvent): Added.
1315         (replaySavedEvents): Pause when an event has a delay and defer to dispatchEvent.
1316         (makeEventSender): Only initialize the EventSender when loading the top frame.
1317         * DumpRenderTree/gtk/EventSender.h: Ditto.
1318
1319 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
1320
1321         Reviewed by Xan Lopez.
1322
1323         [GTK] css1/color_and_background/background_attachment.html fails on the 32-bit debug bot
1324         https://bugs.webkit.org/show_bug.cgi?id=39101
1325
1326         Work around timing issues for render tree dumps by pumping the
1327         main loop before doing the dump. Resize events are asynchronous
1328         in GTK+, so sometimes resize requests are still pending when DRT
1329         dumps the tree.
1330
1331         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1332         (dump): Pump the main loop before dumping the render tree.
1333
1334 2010-05-31  Kent Tamura  <tkent@chromium.org>
1335
1336         Reviewed by Dimitri Glazkov.
1337
1338         [DRT/Chromium] Fix crash of a test after another test with multiple windows
1339         https://bugs.webkit.org/show_bug.cgi?id=39942
1340
1341         If a test opens multiple windows, focuses on non-main window, and
1342         the focused window is closed, TestShell::m_focusedWidget points a
1343         deleted object.
1344
1345         * DumpRenderTree/chromium/TestShell.cpp:
1346         (TestShell::closeWindow): Clear m_focusedWidget.
1347
1348 2010-05-30  Kent Tamura  <tkent@chromium.org>
1349
1350         Reviewed by Dimitri Glazkov.
1351
1352         new-run-webkit-tests: Support DRT on Chromium-win
1353         https://bugs.webkit.org/show_bug.cgi?id=39810
1354
1355         Add --test-shell flag to DRT/Chromium, and it changes DRT so that
1356         it behaves like test_shell about command analysis, printing
1357         format, pixel dumping, and timeout handling.
1358
1359         chromium.py and chromium_win.py supports the --test-shell flag and
1360         DRT/Chromium-win binary names.
1361         
1362         * DumpRenderTree/DumpRenderTree.gypi: Add new files.
1363         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1364         (runTest): Support for test_shell-style command.
1365         (main): Introduce --test-shell.
1366         * DumpRenderTree/chromium/TestEventPrinter.cpp: Added.
1367         * DumpRenderTree/chromium/TestEventPrinter.h: Added.
1368           TestEventPrinter class manages stdio output and image output.
1369           TestEventPrinter.cpp has two implementations; DRTPrinter and
1370           TestShellPrinter.
1371         * DumpRenderTree/chromium/TestShell.cpp:
1372           Some changes for TestEventPrinter.
1373         (TestShell::TestShell):
1374         (TestShell::runFileTest):
1375         (TestShell::testTimedOut):
1376         (TestShell::dump):
1377         (TestShell::dumpImage):
1378         * DumpRenderTree/chromium/TestShell.h:
1379         (TestShell::printer):
1380         (TestShell::layoutTestTimeout):
1381         (TestShell::layoutTestTimeoutForWatchDog):
1382         (TestShell::setLayoutTestTimeout):
1383         * DumpRenderTree/chromium/TestShellWin.cpp:
1384         (watchDogThread): Use TestShell::layoutTestTimeoutForWatchDog().
1385         * Scripts/webkitpy/layout_tests/port/chromium.py:
1386         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1387
1388 2010-05-30  Robert Hogan  <robert@webkit.org>
1389
1390         Reviewed by Kenneth Rohde Christiansen.
1391
1392         [Qt] Enhance Qt DRT implementation to support platform scroll wheel events.
1393
1394         https://bugs.webkit.org/show_bug.cgi?id=36004
1395
1396         * DumpRenderTree/qt/EventSenderQt.cpp:
1397         (EventSender::EventSender): QApplication::setWheelScrollLines(2) in order to match
1398                                     Scrollbar::pixelsPerLineStep() for DRT testing.
1399         (EventSender::mouseScrollBy): Added
1400         (EventSender::continuousMouseScrollBy): Added
1401         * DumpRenderTree/qt/EventSenderQt.h:
1402
1403 2010-05-28  Adam Barth  <abarth@webkit.org>
1404
1405         Reviewed by David Levin.
1406
1407         webkit-patch should support CHANGE_LOG_EDIT_APPLICATION
1408         https://bugs.webkit.org/show_bug.cgi?id=39546
1409
1410         One sublty is that we want to wait for the user to finish editing the
1411         ChangeLog before moving on to the next step.  That means we want to pass
1412         -W to open.  However, if the user is using Xcode to edit the ChangeLog,
1413         we don't want them to have to exit the Xcode application.  For this reason,
1414         we create a new instance of the application with -n.
1415         
1416         Overall, xed seems like a better solution, so we recommend that too.
1417
1418         * Scripts/webkitpy/common/system/user.py:
1419         * Scripts/webkitpy/tool/mocktool.py:
1420         * Scripts/webkitpy/tool/steps/editchangelog.py:
1421
1422 2010-05-21  Dirk Pranke  <dpranke@chromium.org>
1423
1424         Reviewed by Ojan Vafai.
1425
1426         new-run-webkit-tests: fix handling of Ctrl-C to exit even if some
1427         threads are wedged. Also, the script will print the results of the
1428         tests completed when the interrupt occurs.
1429
1430         https://bugs.webkit.org/show_bug.cgi?id=33238
1431
1432         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1433         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1434         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1435         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1436
1437 2010-05-28  Darin Adler  <darin@apple.com>
1438
1439         Ignore more Python messiness.
1440
1441         * Scripts/webkitpy/layout_tests/data/platform/test: Added property svn:ignore.
1442         * Scripts/webkitpy/layout_tests/layout_package: Added property svn:ignore.
1443         * Scripts/webkitpy/layout_tests/test_types: Added property svn:ignore.
1444         * Scripts/webkitpy/test: Added property svn:ignore.
1445         * Scripts/webkitpy/thirdparty/simplejson: Added property svn:ignore.
1446
1447 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
1448
1449         Reviewed by Beth Dakin.
1450
1451         Adding myself as a reviewer.
1452
1453         * Scripts/webkitpy/common/config/committers.py:
1454
1455 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
1456
1457         Build fix. No review.
1458
1459         AX: need to catch NSAccessibilityExceptions in DRT
1460         https://bugs.webkit.org/show_bug.cgi?id=39881
1461
1462         It looks like Tiger doesn't like seeing a NSMakeRange inside a @try.
1463
1464         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1465         (AccessibilityUIElement::rowIndexRange):
1466         (AccessibilityUIElement::columnIndexRange):
1467         (AccessibilityUIElement::selectedTextRange):
1468
1469 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
1470
1471         Reviewed by Darin Adler.
1472
1473         AX: need to catch NSAccessibilityExceptions in DRT
1474         https://bugs.webkit.org/show_bug.cgi?id=39881
1475
1476         Normally, accessibility exceptions are caught in the AX Runtime on the Mac, but 
1477         because DRT is its own AX client, no one is there to catch these otherwise innocuous exceptions.
1478   
1479         So DRT should wrap exception handlers around its AX related calls.
1480
1481         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1482         (attributesOfElement):
1483         (AccessibilityUIElement::getLinkedUIElements):
1484         (AccessibilityUIElement::getDocumentLinks):
1485         (AccessibilityUIElement::getChildren):
1486         (AccessibilityUIElement::getChildrenWithRange):
1487         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1488         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1489         (AccessibilityUIElement::disclosedRowAtIndex):
1490         (AccessibilityUIElement::selectedRowAtIndex):
1491         (AccessibilityUIElement::titleUIElement):
1492         (AccessibilityUIElement::parentElement):
1493         (AccessibilityUIElement::disclosedByRow):
1494         (AccessibilityUIElement::stringAttributeValue):
1495         (AccessibilityUIElement::boolAttributeValue):
1496         (AccessibilityUIElement::isAttributeSettable):
1497         (AccessibilityUIElement::isAttributeSupported):
1498         (AccessibilityUIElement::role):
1499         (AccessibilityUIElement::subrole):
1500         (AccessibilityUIElement::roleDescription):
1501         (AccessibilityUIElement::title):
1502         (AccessibilityUIElement::description):
1503         (AccessibilityUIElement::orientation):
1504         (AccessibilityUIElement::stringValue):
1505         (AccessibilityUIElement::language):
1506         (AccessibilityUIElement::helpText):
1507         (AccessibilityUIElement::x):
1508         (AccessibilityUIElement::y):
1509         (AccessibilityUIElement::width):
1510         (AccessibilityUIElement::height):
1511         (AccessibilityUIElement::clickPointX):
1512         (AccessibilityUIElement::clickPointY):
1513         (AccessibilityUIElement::intValue):
1514         (AccessibilityUIElement::minValue):
1515         (AccessibilityUIElement::maxValue):
1516         (AccessibilityUIElement::valueDescription):
1517         (AccessibilityUIElement::insertionPointLineNumber):
1518         (AccessibilityUIElement::isActionSupported):
1519         (AccessibilityUIElement::isEnabled):
1520         (AccessibilityUIElement::isRequired):
1521         (AccessibilityUIElement::isSelected):
1522         (AccessibilityUIElement::isExpanded):
1523         (AccessibilityUIElement::hierarchicalLevel):
1524         (AccessibilityUIElement::ariaIsGrabbed):
1525         (AccessibilityUIElement::ariaDropEffects):
1526         (AccessibilityUIElement::lineForIndex):
1527         (AccessibilityUIElement::boundsForRange):
1528         (AccessibilityUIElement::stringForRange):
1529         (AccessibilityUIElement::attributesOfColumnHeaders):
1530         (AccessibilityUIElement::attributesOfRowHeaders):
1531         (AccessibilityUIElement::attributesOfColumns):
1532         (AccessibilityUIElement::attributesOfRows):
1533         (AccessibilityUIElement::attributesOfVisibleCells):
1534         (AccessibilityUIElement::attributesOfHeader):
1535         (AccessibilityUIElement::rowCount):
1536         (AccessibilityUIElement::columnCount):
1537         (AccessibilityUIElement::indexInTable):
1538         (AccessibilityUIElement::rowIndexRange):
1539         (AccessibilityUIElement::columnIndexRange):
1540         (AccessibilityUIElement::cellForColumnAndRow):
1541         (AccessibilityUIElement::selectedTextRange):
1542         (AccessibilityUIElement::setSelectedTextRange):
1543         (AccessibilityUIElement::increment):
1544         (AccessibilityUIElement::decrement):
1545         (AccessibilityUIElement::showMenu):
1546         (AccessibilityUIElement::press):
1547         (AccessibilityUIElement::url):
1548         (AccessibilityUIElement::hasPopup):
1549
1550 2010-05-28  Yael Aharon  <yael.aharon@nokia.com>
1551
1552         Reviewed by Laszlo Gombos.
1553
1554         [Qt] Pass all web notification layout tests
1555         https://bugs.webkit.org/show_bug.cgi?id=39146
1556
1557         Mimic Chromium's test_shell security model in Qt's DRT.
1558         It makes a list of origins which were granted permission to display
1559         notifications, and only those origins can display notifications.
1560
1561         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1562         (WebCore::checkPermissionCallback):
1563         (WebCore::requestPermissionCallback):
1564         (WebCore::WebPage::WebPage):
1565         (WebCore::DumpRenderTree::checkPermission):
1566         (WebCore::DumpRenderTree::requestPermission):
1567         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1568         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1569         (LayoutTestController::reset):
1570         (LayoutTestController::grantDesktopNotificationPermission):
1571         (LayoutTestController::checkDesktopNotificationPermission):
1572         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1573
1574 2010-05-27  Philippe Normand  <pnormand@igalia.com>
1575
1576         Reviewed by Shinichiro Hamaji.
1577
1578         check-webkit-style complains about use of NULL in GTK function calls that require sentinels
1579         https://bugs.webkit.org/show_bug.cgi?id=39372
1580
1581         Don't warn about NULL in g_*() calls. Zero can't be used instead
1582         for calls like g_build_filename and g_object_get/set.
1583
1584         * Scripts/webkitpy/style/checkers/cpp.py:
1585         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1586
1587 2010-05-27  Luiz Agostini  <luiz.agostini@openbossa.org>
1588
1589         Reviewed by Kenneth Rohde Christiansen.
1590
1591         [Qt] Platform plugin example
1592         https://bugs.webkit.org/show_bug.cgi?id=39489
1593
1594         Exempting directory WebKit/qt/examples/ from style guide.
1595
1596         * Scripts/webkitpy/style/checker.py:
1597
1598 2010-05-26  Philippe Normand  <pnormand@igalia.com>
1599
1600         Reviewed by David Levin.
1601
1602         [style] Allow usage of NULL in gst_*_many()
1603         https://bugs.webkit.org/show_bug.cgi?id=39740
1604
1605         Don't warn if NULL is used by gst_*_many() functions. Zero can't
1606         be used for the reason explained in Bug 32858.
1607
1608         * Scripts/webkitpy/style/checkers/cpp.py:
1609         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1610
1611 2010-05-27  Adam Barth  <abarth@webkit.org>
1612
1613         Reviewed by Eric Seidel.
1614
1615         Update script to run the normal version of the parser tests.
1616
1617         * Scripts/test-html5-parser:
1618
1619 2010-05-27  Adam Barth  <abarth@webkit.org>
1620
1621         Reviewed by Eric Seidel.
1622
1623         Add HTML5 parser support to run-webkit-tests
1624         https://bugs.webkit.org/show_bug.cgi?id=39815
1625
1626         * Scripts/old-run-webkit-tests:
1627
1628 2010-05-26  Adam Barth  <abarth@webkit.org>
1629
1630         Reviewed by Eric Seidel.
1631
1632         Make HTML5 lexer not ASSERT when resuming partial parses
1633         https://bugs.webkit.org/show_bug.cgi?id=39755
1634
1635         Add webkit-resumer.html to the HTML5 parser test suite.
1636
1637         * Scripts/test-html5-parser:
1638
1639 2010-05-24  Tony Chang  <tony@chromium.org>
1640
1641         Reviewed by Kent Tamura.
1642
1643         [chromium] setup fonts on chromium linux DRT
1644         https://bugs.webkit.org/show_bug.cgi?id=39644
1645
1646         * DumpRenderTree/chromium/TestShellGtk.cpp:
1647         (setupFontconfig):
1648         (platformInit):
1649         * DumpRenderTree/chromium/WebViewHost.cpp:
1650         (WebViewHost::paintRect):  Fix a bug where in release builds, we didn't initialize m_canvas.
1651         * DumpRenderTree/chromium/fonts.conf: Added.
1652
1653 2010-05-24  Dirk Pranke  <dpranke@chromium.org>
1654
1655         Reviewed by Dimitri Glazkov.
1656
1657         Re-commit r58765 - it had been rolled out to see if it was causing
1658         a perf regression (in r59787 and r59789), but that does not seem to
1659         have been the case.
1660
1661         https://bugs.webkit.org/show_bug.cgi?id=39605
1662
1663         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1664         (NotificationPresenter::show):
1665
1666 2010-05-25  Ojan Vafai  <ojan@chromium.org>
1667
1668         Reviewed by Chris Jerdonek.
1669
1670         remove suppression of rietveld logging
1671         https://bugs.webkit.org/show_bug.cgi?id=39693
1672
1673         Now that we only upload to rietveld explicitly, e.g. on the bot
1674         or via webkit-patch post-attachment-to-rietveld, we should print
1675         all the rietveld logging. It was suppressed before to avoid making
1676         webkit-patch upload too noisy.
1677
1678         * Scripts/webkitpy/common/net/rietveld.py:
1679
1680 2010-05-25  Antonio Gomes  <tonikitoo@webkit.org>
1681
1682         Reviewed by Ojan Vafai.
1683
1684         [Qt] Expose the editing behavior setting in DRT to test all editing code paths
1685         https://bugs.webkit.org/show_bug.cgi?id=39680
1686
1687         Implement LayoutTestController::setEditingBehavior in Qt's DRT.
1688
1689         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1690         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1691         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1692         (LayoutTestController::setEditingBehavior):
1693
1694 2010-05-25  Kevin Ollivier  <kevino@theolliviers.com>
1695
1696         [wx] Build fix after API change and addition of WebCore/platform/text/transcoder dir. 
1697
1698         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1699         (LayoutTestController::setEditingBehavior):
1700         * wx/build/settings.py:
1701
1702 2010-05-24  Antonio Gomes  <tonikitoo@webkit.org>
1703
1704         Reviewed by Eric Seidel and Kent Tamura (for the Chromium part).
1705
1706         editingBehavior settings needs to be set back to a reasonable default between tests
1707         https://bugs.webkit.org/show_bug.cgi?id=39433
1708
1709         Similarly to r59861, hard code the default setting during reset for Gtk and Chromium,
1710         so that the serialized version of the setting stays in sync with expectations.
1711
1712         * DumpRenderTree/chromium/TestShell.cpp:
1713         (TestShell::resetWebSettings):
1714         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1715         (resetDefaultsToConsistentValues):
1716
1717 2010-05-24  Eric Seidel  <eric@webkit.org>
1718
1719         Reviewed by Adam Barth.
1720
1721         webkit-patch land calls scm.changed_files 4 times!
1722         https://bugs.webkit.org/show_bug.cgi?id=39584
1723
1724         * Scripts/webkitpy/tool/commands/download_unittest.py:
1725          - Assert that we don't call modified_changelogs too often.
1726         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1727          - Use cached changelogs list instead of calling modified_changelogs directly.
1728         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1729          - ditto.
1730
1731 2010-05-24  Kent Tamura  <tkent@chromium.org>
1732
1733         Reviewed by Dimitri Glazkov.
1734
1735         [DRT/Chromium] Import layout_test_helper for Windows
1736         https://bugs.webkit.org/show_bug.cgi?id=39581
1737
1738         Import Chromium win/layout_test_helper.cc as LayoutTestHelperWin.cpp.
1739         http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/win/layout_test_helper.cc
1740
1741         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Added.
1742
1743 2010-05-24  Kent Tamura  <tkent@chromium.org>
1744
1745         Reviewed by Dimitri Glazkov.
1746
1747         [DRT/Chromium] Reset frame name
1748         https://bugs.webkit.org/show_bug.cgi?id=39586
1749
1750         This change fixes about 70 unexpected results.
1751
1752         * DumpRenderTree/chromium/WebViewHost.cpp:
1753         (WebViewHost::reset):
1754
1755 2010-05-24  Marcus Bulach  <bulach@chromium.org>
1756
1757         Reviewed by Kent Tamura.
1758
1759         [chromium] Adds WebGeolocationServiceMockImpl to remove public dependency on wtf/HashMap.h
1760         https://bugs.webkit.org/show_bug.cgi?id=39587
1761
1762         * DumpRenderTree/chromium/WebViewHost.cpp:
1763         (WebViewHost::geolocationService):
1764
1765 2010-05-24  Robert Hogan  <robert@webkit.org>
1766
1767         Reviewed by Laszlo Gombos.
1768
1769         [Qt] DRT Support for removeOriginAccessWhitelistEntry
1770
1771         Unskips http/tests/xmlhttprequest/origin-whitelisting-removal.html
1772
1773         [Qt] DRT Support for removeOriginAccessWhitelistEntry
1774         https://bugs.webkit.org/show_bug.cgi?id=39565
1775
1776         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1777         (LayoutTestController::removeOriginAccessWhitelistEntry):
1778
1779 2010-05-24  Marcus Bulach  <bulach@google.com>
1780
1781         Reviewed by Ojan Vafai.
1782
1783         _svn_branch_has_extra_commits needs to check for ^HEAD instead of ^head.
1784         https://bugs.webkit.org/show_bug.cgi?id=39603
1785
1786         * Scripts/webkitpy/common/checkout/scm.py:
1787
1788 == Rolled over to ChangeLog-2010-05-24 ==