1a22183b4a4521763e16d79c4ba3df59177e0286
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-12-03  Andrew Bonventre  <andybons@google.com>
2
3         Reviewed by Darin Adler.
4
5         * Drosera/debugger.js: Fixed javascript error where document property
6         should have been used instead of contentDocument in switchFunction that
7         was breaking the select symbol dropdown menu.  This is because
8         window.frames will return a Window object and not a frame object like
9         the author was originally expecting.
10
11 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
12
13         Reviewed by Adam.
14
15         - <rdar://5618942> Drosera: Console window does not process everything
16         correctly.
17         - <rdar://5619005> Drosera: could be sped up by moving the 
18         WebScriptScope stuff into the WebScriptCallFrame.
19         - Now the console can correctly process objects and does not receive
20         notifications from JavaScriptCore about the JavaScript in Drosera's
21         own process.
22
23         * Drosera/win/DebuggerDocumentPlatform.cpp:
24         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
25         (DebuggerDocument::platformValueForScopeVariableNamed):
26
27 2007-12-03  Stephanie  <slewis@apple.com>
28
29         Reviewed by Darin.
30
31         Check to see if we are building a debug root
32
33         * Scripts/check-for-global-initializers: 
34
35 2007-12-03  Dan Bernstein  <mitz@apple.com>
36
37         Reviewed by Darin Adler.
38
39         - added a testGetIntIdentifier() method to TestNetscapePlugIn
40
41         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
42         (pluginInvoke):
43
44 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
45
46         Reviewed by Oliver.
47
48         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
49         in a more fine-grained manner than eventSender.keyDown().
50
51         * DumpRenderTree/win/EventSender.cpp:
52         (getConstantCallback):
53         (dispatchMessageCallback):
54
55 2007-12-02  Darin Adler  <darin@apple.com>
56
57         * Scripts/do-webcore-rename: More planned renaming.
58
59 2007-12-02  Sam Weinig  <sam@webkit.org>
60
61         Rubber stamped by Anders.
62
63         Use [NSURL absoluteString] instead of [NSURL description] in order to get
64         more uniform results cross platform.
65
66         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
67         (-[NSURL _drt_descriptionSuitableForTestResult]):
68
69 2007-12-02  Sam Weinig  <sam@webkit.org>
70
71         Rubber stamped by Niko.
72
73         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
74
75         * DumpRenderTree/win/DumpRenderTree.cpp:
76         * DumpRenderTree/win/DumpRenderTree.vcproj:
77         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
78         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
79         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
80         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
81
82 2007-12-01  Alp Toker  <alp@atoker.com>
83
84         Reviewed by Adam Roben.
85
86         Make use of the newly introduced webkit.h convenience header.
87
88         * GtkLauncher/main.c:
89
90 2007-12-01  Adam Treat  <treat@kde.org>
91
92         Reviewed by Simon.
93
94         * Check to see if the directory exists and exit if not.
95
96         * DumpRenderTree/qt/main.cpp:
97         (main):
98
99 2007-12-01  Adam Treat  <treat@kde.org>
100
101         Reviewed by Simon.
102
103         * Don't hide symbols when in Debug mode
104         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
105
106
107         * DumpRenderTree/qt/main.cpp:
108         (messageHandler):
109
110 2007-11-30  Alp Toker  <alp@atoker.com>
111
112         Reviewed by Adam Roben.
113
114         http://bugs.webkit.org/show_bug.cgi?id=15691
115         [GTK] Public API does not follow GTK+ conventions
116
117         Refactor the WebKit/GTK+ public API. Changes:
118           WebKitPage -> WebKitWebView
119           WebKitFrame -> WebKitWebFrame
120
121         Public API source and header names have been updated to mirror the API
122         changes.
123
124         The API is now kept in WebKit/gtk/WebView to match other ports in the
125         same class such as Mac and Win.
126
127         * GtkLauncher/main.c:
128         (activate_uri_entry_cb):
129         (link_hover_cb):
130         (title_change_cb):
131         (progress_change_cb):
132         (go_back_cb):
133         (go_forward_cb):
134         (create_browser):
135         (main):
136
137 2007-11-30  Adam Roben  <aroben@apple.com>
138
139         Hopefully the final build fix
140
141         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
142         pull in WTF's assertion/logging functions.
143
144 2007-11-30  Adam Roben  <aroben@apple.com>
145
146         Another build fix
147
148         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
149         WebKit.lib.
150
151 2007-11-30  Adam Roben  <aroben@apple.com>
152
153         Debug build fix
154
155         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
156         configuration.
157         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
158         projects.
159         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
160         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
161         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
162
163 2007-11-30  Sam Weinig  <sam@webkit.org>
164
165         Reviewed by Adam Roben.
166
167         Fix drawSelectionRect to actually draw the selection rect.
168
169         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
170         (drawSelectionRect):
171
172 2007-11-30  Darin Adler  <darin@apple.com>
173
174         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
175
176 2007-11-30  Darin Adler  <darin@apple.com>
177
178         * Scripts/do-webcore-rename: Get ready for some future renaming.
179
180 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
181
182         Reviewed by Adam.
183
184         - Removed some unnecessary functions and changed an unused return type. 
185
186         * Drosera/win/DebuggerClient.cpp:
187         (registerConsoleClass):
188         * Drosera/win/DebuggerClient.h:
189         * Drosera/win/Drosera.cpp:
190         (registerDroseraClass):
191
192 2007-11-28  Alp Toker  <alp@atoker.com>
193
194         Reviewed by Timothy Hatcher.
195
196         http://bugs.webkit.org/show_bug.cgi?id=16174
197         [GTK] Use "URI" not "URL" in public API
198
199         Replace use of the term "URL" with "URI" in public headers,
200         documentation and some internal code to match GLib/GTK+ convention.
201
202         This is now mentioned in the API guidelines:
203           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
204
205         * GtkLauncher/main.c:
206         (activate_uri_entry_cb):
207         (title_change_cb):
208         (create_toolbar):
209         (main):
210
211 2007-11-29  Anders Carlsson  <andersca@apple.com>
212
213         Reviewed by Sam.
214
215         <rdar://problem/5230478>
216         FrameLoadDelegate callbacks are not dumped in DRT.
217         
218         * DumpRenderTree/win/DumpRenderTree.cpp:
219         (shouldLogFrameLoadDelegates):
220         (runTest):
221         (main):
222         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
223         (BSTRtoString):
224         (descriptionSuitableForTestResult):
225         (FrameLoadDelegate::QueryInterface):
226         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
227         (FrameLoadDelegate::didFailProvisionalLoadWithError):
228         (FrameLoadDelegate::didCommitLoadForFrame):
229         (FrameLoadDelegate::didFinishLoadForFrame):
230         (FrameLoadDelegate::willCloseFrame):
231         (FrameLoadDelegate::didClearWindowObject):
232         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
233         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
234         * DumpRenderTree/win/FrameLoaderDelegate.h:
235         (FrameLoadDelegate::windowScriptObjectAvailable):
236         (FrameLoadDelegate::didFirstLayoutInFrame):
237
238 2007-11-29  Sam Weinig  <sam@webkit.org>
239
240         Reviewed by Anders.
241
242         Add database quota UIDelegates methods to DRT UIDelegate.
243
244         * DumpRenderTree/mac/UIDelegate.mm:
245         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
246         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
247
248 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
249
250         Reviewed by Sam.
251
252         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
253         dying and vice versa.
254         - This fix will allow Drosera and Safari to reconnect if either of them
255         closes correctly, but does not fix the case where one of them dies
256         silently.
257
258         * Drosera/win/ServerConnection.cpp:
259         (ServerConnection::attemptToCreateServerConnection): Added a safety
260         check, because it's possilbe to try to connect to a server that's dying.
261         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
262         the server has died.
263         * Drosera/win/ServerConnection.h: Added the new function and removed
264         an unnecessary member.
265
266 2007-11-29  Anders Carlsson  <andersca@apple.com>
267
268         * DumpRenderTree/win/DumpRenderTree.vcproj:
269         Add shlwapi.lib to all configurations.
270
271 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
272
273         - Build fix.  Added additional includes for VS Express to the Release
274         project.
275
276         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
277
278 2007-11-29  Anders Carlsson  <andersca@apple.com>
279
280         Reviewed by Adam.
281
282         <rdar://problem/5132005>
283         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
284         
285         * DumpRenderTree/win/DumpRenderTree.vcproj:
286         Add shlwapi.lib
287         
288         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
289         (LayoutTestController::setUserStyleSheetEnabled):
290         Implement this.
291         
292         (appendComponentToPath):
293         New method which wraps the Win32 API PathAppend.
294         
295         (followShortcuts):
296         New method which checks if a file points to a shortcut and
297         follows the shortcut.
298         
299         (resolveCygwinPath):
300         New method that takes a cygwin unix-style path and returns the Win32 path.
301         
302         (cfStringRefToWString):
303         
304         (LayoutTestController::setUserStyleSheetLocation):
305         Implement this.
306
307 2007-11-29  Alice Liu  <alice.liu@apple.com>
308
309         Reviewed by Adam.
310
311         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
312
313         * DumpRenderTree/win/EventSender.cpp:
314         (keyDownCallback):
315         uppercase letters were being sent as lowercase letters without the shift key down.
316
317 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
318
319         - Windows build fix. VS express needs some love.
320
321         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
322
323 2007-11-28  Darin Adler  <darin@apple.com>
324
325         Reviewed by Adam Roben.
326
327         * DumpRenderTree/mac/EventSendingController.mm:
328         (-[EventSendingController keyDown:withModifiers:]):
329         Send capital letters through as lowercase letters with the shift key down
330         rather than sending them as if they were highly unusual "capital letter keys".
331
332         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
333         where you need to update results and more tests are failing than before.
334
335 2007-11-28  Anders Carlsson  <andersca@apple.com>
336
337         Reviewed by Darin.
338
339         <rdar://problem/5132001>
340         contextClick is not implemented in DRT on Windows.
341         
342         * DumpRenderTree/win/EventSender.cpp:
343         (contextClickCallback):
344         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
345         by a WM_RBUTTONUP message.
346         
347         * DumpRenderTree/win/UIDelegate.cpp:
348         (UIDelegate::hasCustomMenuImplementation):
349         (UIDelegate::trackCustomPopupMenu):
350         * DumpRenderTree/win/UIDelegate.h:
351         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
352         menu from being shown (and causing the DRT to hang).
353
354 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
355
356         Reviewed by Darin.
357
358         Fix DumpRenderTree ObjC bug comparing strings.
359
360         * DumpRenderTree/mac/ObjCController.m:
361         (-[ObjCController identityIsEqual::]): Compare strings with string
362         equality instead of identiy equality.
363
364 2007-11-27  Timothy Hatcher  <timothy@apple.com>
365
366         Reviewed by Sam.
367
368         Reset the authorAndUserStylesEnabled preference
369         back to YES for each test. Fixes the broken tests.
370
371         * DumpRenderTree/mac/DumpRenderTree.mm:
372         (resetWebViewToConsistentStateBeforeTesting):
373
374 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
375
376         Reviewed by Adam.
377
378         - Drosera now displays the console window, although it cannot currently
379         process JavaScript.
380
381         * Drosera/win/DebuggerClient.cpp: Shows the console window.
382         (registerConsoleClass): Implemented.
383         (consoleWndProc): Implemented.
384         (DebuggerClient::onSize): Implemented.
385         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
386         new window.
387         * Drosera/win/DebuggerClient.h: Added needed method and members for 
388         creating and maintaining a new window.
389         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
390         lines of code to more appropriate places.
391         (Drosera::handleCommand):
392         (Drosera::initUI):
393         (Drosera::onSize):
394         (Drosera::attach):
395
396 2007-11-27  Timothy Hatcher  <timothy@apple.com>
397
398         Reviewed by Dave Hyatt.
399
400         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
401         
402         Add support for disabling author and user styles for testing.
403
404         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
405         * DumpRenderTree/LayoutTestController.cpp:
406         (setAuthorAndUserStylesEnabledCallback):
407         (LayoutTestController::staticFunctions):
408         * DumpRenderTree/LayoutTestController.h:
409         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
410         (LayoutTestController::setAuthorAndUserStylesEnabled):
411         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
412         (LayoutTestController::setAuthorAndUserStylesEnabled):
413
414 2007-11-26  Dan Bernstein  <mitz@apple.com>
415
416         - Tiger build fix.
417
418         * DumpRenderTree/mac/Configurations/Base.xcconfig:
419
420 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
421
422         Reviewed by Maciej.
423
424         - Implemented displaying variables for Drosera on Win.
425
426         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
427         that retrieve variables to not hold onto the return value since it's
428         not returned.  Also changed to use the new signatures of the retrieval
429         functions.
430         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
431         (DebuggerDocument::platformValueForScopeVariableNamed):
432         * Drosera/win/Drosera.cpp: Removed a needless TODO.
433         (droseraWndProc):
434
435 2007-11-26  Sam Weinig  <sam@webkit.org>
436
437         Cleanup names of painting and repainting functions.
438
439         Reviewed by Adam Roben.
440
441         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
442         (drawSelectionRect): was drawSelectionRectIntoContext.
443         (dumpWebViewAsPixelsAndCompareWithExpected):
444         * DumpRenderTree/cg/PixelDumpSupportCG.h:
445         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
446         (paintWebView): was drawWebViewIntoContext.
447         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
448
449 2007-11-26  Sam Weinig  <sam@webkit.org>
450
451         Reviewed by Dan Bernstein.
452
453         - Leopard build fix
454
455         * DumpRenderTree/mac/Configurations/Base.xcconfig:
456
457 2007-11-26  Sam Weinig  <sam@webkit.org>
458
459         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
460         Use shared PixelDumpSupport for Mac DRT
461
462         Reviewed by Adam Roben.
463
464         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
465         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
466         * DumpRenderTree/cg/ImageDiffCG.cpp:
467         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
468         (drawSelectionRectIntoContext):
469         (dumpWebViewAsPixelsAndCompareWithExpected):
470         * DumpRenderTree/cg/PixelDumpSupportCG.h:
471         * DumpRenderTree/mac/Configurations/Base.xcconfig:
472         * DumpRenderTree/mac/DumpRenderTree.mm:
473         (dump):
474         * DumpRenderTree/mac/ImageDiff.m: Removed.
475         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
476         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
477         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
478         (setDefaultColorProfileToRGB):
479         (getBitmapContextFromWebView):
480         (drawWebViewIntoContext):
481         (repaintWithVerticalSweep):
482         (repaintWithHorizontalSweep):
483         (getSelectionRect):
484         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
485
486 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
487
488         Bug 16052: prepare-ChangeLog doesn't report deleted files
489         <http://bugs.webkit.org/show_bug.cgi?id=16052>
490
491         Reviewed by Sam.
492
493         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
494
495 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
496
497         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
498         <http://bugs.webkit.org/show_bug.cgi?id=15864>
499
500         Reviewed by Adam.
501
502         Roll functionality of merge-changelog into resolve-ChangeLogs
503         script.  The script now checks for ChangeLog.rej and
504         ChangeLog.orig files first.  If it finds them, it uses the
505         ChangeLog.rej file as a patch (in old contextual diff format) to
506         apply with --fuzz=3.
507
508         * Scripts/merge-changelog: Removed.
509         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
510
511 2007-11-25  Sam Weinig  <sam@webkit.org>
512
513         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
514
515         Reviewed by Mark Rowe.
516
517         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
518         * DumpRenderTree/mac/Configurations/Base.xcconfig:
519         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
520         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
521         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
522
523 2007-11-25  Sam Weinig  <sam@webkit.org>
524
525         Convert DumpRenderTree to ues .xcconfig files.
526
527         Reviewed by Mark Rowe.
528
529         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
530         * DumpRenderTree/mac/Configurations: Added.
531         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
532         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
533         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
534
535 2007-11-25  Sam Weinig  <sam@webkit.org>
536
537         Add ForwardingHeaders to wtf for DumpRenderTree.
538
539         Reviewed by Mark Rowe.
540
541         * DumpRenderTree/DumpRenderTree.h:
542         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
543         * DumpRenderTree/ForwardingHeaders: Added.
544         * DumpRenderTree/ForwardingHeaders/wtf: Added.
545         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
546         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
547         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
548         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
549         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
550         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
551         * DumpRenderTree/LayoutTestController.cpp:
552         * DumpRenderTree/WorkQueue.cpp:
553         * DumpRenderTree/mac/DumpRenderTree.mm:
554         * DumpRenderTree/mac/FrameLoadDelegate.mm:
555         * DumpRenderTree/mac/JavaScriptThreading.cpp:
556         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
557         * DumpRenderTree/mac/ObjCController.m:
558         * DumpRenderTree/mac/UIDelegate.mm:
559         * DumpRenderTree/mac/WorkQueueItemMac.mm:
560
561 2007-11-25  Adam Roben  <aroben@apple.com>
562
563         Fix some test failures caused by r28019
564
565         Now that stdout is in binary mode, we need to always use printf
566         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
567         the output.
568
569         Reviewed by Sam.
570
571         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
572         printf.
573         (UIDelegate::runJavaScriptAlertPanelWithMessage):
574         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
575         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
576         (UIDelegate::webViewAddMessageToConsole):
577
578 2007-11-25  Adam Roben  <aroben@apple.com>
579
580         Set the font smoothing preference in DRT
581
582         This makes the pixel results on Windows closer to the Mac results.
583
584         Reviewed by Mitz.
585
586         * DumpRenderTree/win/DumpRenderTree.cpp:
587         (initializePreferences):
588
589 2007-11-25  Adam Roben  <aroben@apple.com>
590
591         Port ImageDiff to CG and C++
592
593         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
594         <rdar://5071708>
595
596         Reviewed by Sam.
597
598         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
599         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
600         (main):
601         (createImageFromStdin):
602         (compareImages):
603         (getDifferenceBitmap):
604         (computePercentageDifferent):
605         * DumpRenderTree/win/ImageDiff.vcproj: Added.
606
607 2007-11-25  Adam Roben  <aroben@apple.com>
608
609         Fix image diff link generation on Windows
610
611         Reviewed by Sam.
612
613         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
614         to toURL.
615
616 2007-11-25  Adam Roben  <aroben@apple.com>
617
618         Implement pixel dumping in Windows DRT
619
620         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
621         <rdar://5071708>
622
623         Reviewed by Sam.
624
625         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
626         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
627         Content-Length header.
628         (getMD5HashStringForBitmap):
629         (dumpWebViewAsPixelsAndCompareWithExpected):
630         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
631         * DumpRenderTree/win/DumpRenderTree.cpp:
632         (dump): Do a pixel dump if requested.
633         (main): Parse pixel test options.
634         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
635         the cg/ subdirectory to the include path.
636         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
637         available in a header or import library, so we have to go through this
638         LoadLibrary/GetProcAddress dance to use them.
639         (cryptDLL):
640         (init):
641         (update):
642         (final):
643         (MD5_Init):
644         (MD5_Update):
645         (MD5_Final):
646         * DumpRenderTree/win/MD5.h: Added.
647         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
648         moved up to the top level to share it with Mac eventually.
649         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
650         (getBitmapContextFromWebView): Forces the WebView to paint using a
651         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
652
653 2007-11-25  Adam Roben  <aroben@apple.com>
654
655         Clean up Windows DRT's option parsing a little bit
656
657         Reviewed by Sam.
658
659         * DumpRenderTree/win/DumpRenderTree.cpp:
660         (main): Put non-option arguments into a Vector.
661
662 2007-11-25  Adam Roben  <aroben@apple.com>
663
664         Make Windows DRT stop changing LF into CRLF
665
666         Reviewed by Sam.
667
668         * DumpRenderTree/win/DumpRenderTree.cpp:
669         (main): Put stdout in binary mode.
670         * Scripts/run-webkit-tests: Remove the CRLF hack.
671
672 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
673
674         Removed empty directory.
675
676         * Scripts/resources: Removed.
677
678 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
679
680         Fix bisect-builds to work with recent WebKit nightly builds.
681
682         Reviewed by Dan.
683
684         * Scripts/bisect-builds: Check for the 
685         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
686         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
687         to WebKit.app/Contents/Resources.
688
689 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
690
691         Reviewed by Maciej.
692
693         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
694         not closed (affects digg.com)
695
696         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
697         one after finishing with a test to avoid having its delayed onload handler firing when
698         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
699         but it helps somewhat.
700
701 2007-11-22  Mark Rowe  <mrowe@apple.com>
702
703         Reviewed by Alp Toker.
704
705         Fix build-webkit to propagate make's exit status if it fails.
706
707         * Scripts/webkitdirs.pm:
708
709 2007-11-22  Dan Bernstein  <mitz@apple.com>
710
711         Reviewed by Mark Rowe.
712
713         - fix crash when running pixel tests
714
715         * DumpRenderTree/mac/DumpRenderTree.mm:
716         (dumpRenderTree): Parse the command line options before setting up the
717         environment so that we know if we need to set up the pixel dump
718         machinery.
719
720 2007-11-21  Eric Seidel  <eric@webkit.org>
721
722         Speculative build fix for Tiger.
723
724         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
725
726 2007-11-21  Eric Seidel  <eric@webkit.org>
727
728         Reviewed by Tim Hatcher.
729
730         Break out more of DumpRenderTree.mm into individual files
731
732         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
733         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
734         (checkedMalloc):
735         (checkedRealloc):
736         (makeLargeMallocFailSilently):
737         * DumpRenderTree/mac/CheckedMalloc.h: Added.
738         * DumpRenderTree/mac/DumpRenderTree.mm:
739         (crashHandler):
740         (dump):
741         * DumpRenderTree/mac/DumpRenderTreeMac.h:
742         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
743         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
744         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
745         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
746         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
747         (javaScriptThreads):
748         (runJavaScriptThread):
749         (startJavaScriptThreads):
750         (stopJavaScriptThreads):
751         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
752         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
753         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
754         (restoreColorSpace):
755         (setDefaultColorProfileToRGB):
756         (initializeColorSpaceAndScreeBufferForPixelTests):
757         (md5HashStringForBitmap):
758         (dumpWebViewAsPixelsAndCompareWithExpected):
759
760 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
761
762         Move install-unix-extras to wx directory as it seems only to be used by that 
763         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
764         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
765         have install-unix-extras install into WebKitLibraries as per
766         convention.
767         
768         Reviewed by Mark Rowe.
769
770         * Scripts/install-unix-extras: Removed.
771         * wx/build-wxwebkit:
772         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
773
774 2007-11-21  Eric Seidel  <eric@webkit.org>
775
776         Reviewed by Adam.
777
778         More refactoring for greater code readability
779
780         * DumpRenderTree/mac/DumpRenderTree.mm:
781         (initializeGlobalsFromCommandLineOptions):
782         (initializeColorSpaceAndScreeBufferForPixelTests):
783         (addTestPluginsToPluginSearchPath):
784         (useLongRunningServerMode):
785         (runTestingServerLoop):
786         (prepareConsistentTestingEnvironment):
787         (dumpRenderTree):
788         (main):
789         (dumpFramesAsText):
790         (dumpBackForwardListForWebView):
791         (sizeWebViewForCurrentTest):
792         (methodNameStringForFailedTest):
793         (dumpBackForwardListForAllWindows):
794         (dumpWebViewAsPixelsAndCompareWithExpected):
795         (invalidateAnyPreviousWaitToDumpWatchdog):
796         (dump):
797         * DumpRenderTree/mac/DumpRenderTreeMac.h:
798         * DumpRenderTree/mac/UIDelegate.mm:
799         (-[UIDelegate webView:createWebViewWithRequest:]):
800
801 2007-11-21  Eric Seidel  <eric@webkit.org>
802
803         Reviewed by Tim Hatcher.
804
805         Abstract more of DRT into static methods
806
807         * DumpRenderTree/mac/DumpRenderTree.mm:
808         (setDefaultsToConsistentValuesForTesting):
809         (setupSignalHandlers):
810         (allocateGlobalControllers):
811         (releaseAndZero):
812         (releaseGlobalControllers):
813         (dumpRenderTree):
814         (shouldLogFrameLoadDelegates):
815         (createCFURLFromPathOrURL):
816         (resetWebViewToConsistentStateBeforeTesting):
817         (runTest):
818
819 2007-11-21  Eric Seidel  <eric@webkit.org>
820
821         Reviewed by Tim Hatcher.
822
823         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
824
825         * DumpRenderTree/DumpRenderTree.h:
826         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
827         * DumpRenderTree/mac/DumpRenderTree.mm:
828         (dumpRenderTree):
829         (dump):
830         (runTest):
831         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
832         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
833         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
834         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
835         (-[DumpRenderTreePasteboard declareType:owner:]):
836         (+[LocalPasteboard alloc]):
837         (-[LocalPasteboard init]):
838         (-[LocalPasteboard dealloc]):
839         (-[LocalPasteboard name]):
840         (-[LocalPasteboard releaseGlobally]):
841         (-[LocalPasteboard declareTypes:owner:]):
842         (-[LocalPasteboard addTypes:owner:]):
843         (-[LocalPasteboard changeCount]):
844         (-[LocalPasteboard types]):
845         (-[LocalPasteboard availableTypeFromArray:]):
846         (-[LocalPasteboard setData:forType:]):
847         (-[LocalPasteboard dataForType:]):
848         (-[LocalPasteboard setPropertyList:forType:]):
849         (-[LocalPasteboard setString:forType:]):
850         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
851         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
852         (+[DumpRenderTreeWindow allWindows]):
853         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
854         (-[DumpRenderTreeWindow dealloc]):
855         (-[DumpRenderTreeWindow isKeyWindow]):
856         (-[DumpRenderTreeWindow keyDown:]):
857
858 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
859
860         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
861         it indiscriminately copies any headers inside JavaScriptCore,
862         which includes Tiger ICU headers. 
863
864         * wx/build-wxwebkit:
865         Don't run WebCore/move-js-headers.sh any longer.
866
867 2007-11-20  Adam Treat  <treat@kde.org>
868
869         Reviewed by David Kilzer.
870
871         * Prepend git branch name to $baseProductDir
872
873         * Scripts/VCSUtils.pm:
874         * Scripts/webkitdirs.pm:
875
876 2007-11-20  Mark Rowe  <mrowe@apple.com>
877
878         Reviewed by Simon Hausmann.
879
880         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
881         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
882         Have it trigger a "make distclean" rather than "make clean" to ensure that the
883         built product and generated Makefile's are removed.
884
885 2007-11-19  Alp Toker  <alp@atoker.com>
886
887         Reviewed by Mark Rowe.
888
889         http://bugs.webkit.org/show_bug.cgi?id=16040
890         [GTK] GtkLauncher should be written in C
891
892         Port GtkLauncher to plain C.
893
894         Use a more conventional GTK+ coding style.
895
896         Use a toolbar instead of menus.
897
898         Various signature fixes and cleanups.
899
900         Add a license header. Assume all previous modifications were copyright
901         assigned to Apple Inc. by default.
902
903         * GtkLauncher/GtkLauncher.pro:
904         * GtkLauncher/main.c: Added.
905         (activate_url_entry_cb):
906         (update_title):
907         (link_hover_cb):
908         (title_change_cb):
909         (progress_change_cb):
910         (destroy_cb):
911         (go_back_cb):
912         (go_forward_cb):
913         (create_browser):
914         (create_statusbar):
915         (create_toolbar):
916         (create_window):
917         (main):
918         * GtkLauncher/main.cpp: Removed.
919
920 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
921
922         Build script fixes to ensure they do the right thing for the 
923         wx port, and update build-wxwebkit to reflect the way the
924         build scripts now work.
925
926         Reviewed by Adam.
927
928         * Scripts/build-testkjs:
929         * Scripts/build-webkit:
930         * Scripts/run-javascriptcore-tests:
931         * Scripts/webkitdirs.pm:
932         * wx/build-wxwebkit:
933
934 2007-11-18  Eric Seidel  <eric@webkit.org>
935
936         Reviewed by Anders.
937
938         Make run-javascriptcore-tests report failures on exit (to support git bisect)
939
940         * Scripts/run-javascriptcore-tests:
941
942 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
943
944         Reviewed by Adam Roben.
945
946         Make run-webkit-tests work with Windows debug build.
947
948         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
949         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
950         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
951         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
952         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
953
954 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
955
956         Add wxWebKit sample and build script, and integrate it with 
957         build-webkit. Also make build-webkit --clean work for all
958         ports.
959
960         Reviewed by Darin Adler.
961
962         * Scripts/build-webkit:
963         * Scripts/webkitdirs.pm:
964         * wx: Added.
965         * wx/browser: Added.
966         * wx/browser/browser.bkl: Added.
967         * wx/browser/browser.cpp: Added.
968         * wx/build-wxwebkit: Added.
969
970 2007-11-17  Adam Roben  <aroben@apple.com>
971
972         Make it easy to run Safari in the debugger on Windows
973
974         I've added a new script, debug-safari, which launches Safari in the
975         debugger. On OS X it just calls gdb-safari.
976
977         Reviewed by Mark Rowe.
978
979         * FindSafari/FindSafari.cpp:
980         (_tmain): Added a /debugger flag, which in combination with
981         /printSafariLauncher will print a script that launches Safari in the
982         debugger.
983         * Scripts/debug-safari: Added.
984         * Scripts/run-safari: Changed to call runSafari().
985         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
986         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
987         first argument along to FindSafari.
988         * Scripts/webkitdirs.pm:
989         (sub runSafari): Added.
990
991 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
992
993         Reviewed by Adam Roben.
994
995         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
996
997 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
998
999         Reviewed by David Kilzer.
1000
1001         The git config command was renamed to repo-config at some point. This
1002         change tries git config and then git repo-config if the first fails.
1003
1004         * Scripts/prepare-ChangeLog:
1005         (gitConfig):
1006
1007 2007-11-16  Dan Bernstein  <mitz@apple.com>
1008
1009         Reviewed by Darin Adler and Sam Weinig.
1010
1011         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
1012
1013         * DumpRenderTree/win/EventSender.cpp:
1014         (keyDownCallback): For characters that cannot be entered on the active
1015         keyboard layout, send a WM_CHAR message with the character along with
1016         a WM_KEYDOWN message with a virtual key code of 255.
1017
1018 2007-11-16  Mark Rowe  <mrowe@apple.com>
1019
1020         Reviewed by Tim Hatcher.
1021
1022         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
1023
1024         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1025         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1026
1027 2007-11-15  Adam Roben  <aroben@apple.com>
1028
1029         Make run-safari actually work on Windows
1030
1031         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
1032         chdir call.
1033
1034 2007-11-14  Adam Roben  <aroben@apple.com>
1035
1036         Updates to Safari launching now that 3.0.4 is released
1037
1038         Reviewed by Sam.
1039
1040         * FindSafari/FindSafari.cpp:
1041         (getWebViewCLSID): Use version-independent ProgID.
1042         * Scripts/run-safari: Use run-webkit-nightly.cmd.
1043
1044 2007-11-14  Anders Carlsson  <andersca@apple.com>
1045
1046         Reviewed by Adam.
1047
1048         <rdar://problem/5309081>
1049         In DRT, "plugin.logDestroy = true" not working on Windows.
1050         
1051         * DumpRenderTree/win/TestNetscapePlugin/main.c:
1052         (NPP_Destroy):
1053
1054 2007-11-14  Eric Seidel  <eric@webkit.org>
1055
1056         Reviewed by Sam.
1057
1058         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
1059
1060 2007-11-14  Anders Carlsson  <andersca@apple.com>
1061
1062         Reviewed by Adam.
1063
1064         <rdar://problem/5141186>
1065         window.layoutTestController.setWindowIsKey is not implemented in DRT.
1066         
1067         Implement setWindowIsKey.
1068         
1069         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1070         (LayoutTestController::setWindowIsKey):
1071
1072 2007-11-13  Sam Weinig  <sam@webkit.org>
1073
1074         Reviewed by Adam Roben.
1075
1076         Fix for <rdar://problem/5382579>
1077         http/tests/security/cross-frame-access-put.html reports large 
1078         negative numbers for screenLeft and screenTop (Mac reports "0")
1079
1080         * DumpRenderTree/win/UIDelegate.cpp:
1081         (UIDelegate::UIDelegate): Initialize the RECT.
1082         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
1083         (UIDelegate::webViewFrame): ditto.
1084         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
1085
1086 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
1087
1088         Reviewed by Adam.
1089
1090         - Make Drosera show source, source URLs, and function stack on Windows,
1091         and some minor fixes.
1092
1093         * Drosera/DebuggerDocument.cpp: Force source to always update display.
1094         (DebuggerDocument::updateFileSource):
1095         * Drosera/debugger.js: Force source to always update display.
1096         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
1097         menu controls.
1098         (DebuggerClient::resume):
1099         (DebuggerClient::pause):
1100         (DebuggerClient::stepInto):
1101         (DebuggerClient::stepOver):
1102         (DebuggerClient::stepOut):
1103         (DebuggerClient::showConsole):
1104         (DebuggerClient::closeCurrentFile):
1105         * Drosera/win/DebuggerClient.h: Ditto.
1106         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
1107         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
1108         removed two bugs.  1) caller could be in a bad state when asked to
1109         assign into it. 2) BSTRs were not created correctly.
1110         (DebuggerDocument::getPlatformCurrentFunctionStack):
1111         * Drosera/win/Drosera.cpp: Hook up the menu controls.
1112         (droseraWndProc):
1113         (handleCommand):
1114         (Drosera::resume):
1115         (Drosera::pause):
1116         (Drosera::stepInto):
1117         (Drosera::stepOver):
1118         (Drosera::stepOut):
1119         (Drosera::showConsole):
1120         (Drosera::closeCurrentFile):
1121         * Drosera/win/Drosera.h: Hook up the menu controls.
1122         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
1123         functions, added a null check, and fixed another bug where caller could
1124         be in a bad state when asked to assign into it.
1125         (ServerConnection::didLoadMainResourceForDataSource):
1126         (ServerConnection::getCallerFrame):
1127         * Drosera/win/ServerConnection.h: Safety first.
1128
1129 2007-11-13  Dan Bernstein  <mitz@apple.com>
1130
1131         Reviewed by Darin Adler.
1132
1133         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
1134           DumpRenderTree --pixel-tests renders each test twice
1135
1136         * DumpRenderTree/mac/DumpRenderTree.mm:
1137         (dumpRenderTree): Removed the --paint option because the painting code
1138         is always exercised as a result of
1139         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
1140         calling -displayIfNeeded.
1141         (dump): Changed to always grab the image from the window since the view
1142         is always displayed.
1143         (runTest):
1144         (displayWebView):
1145         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
1146         because it always paints.
1147
1148 2007-11-12  Antti Koivisto  <antti@apple.com>
1149
1150         Reviewed by Adele.
1151         
1152         Add support for http media tests
1153
1154         * Scripts/run-webkit-tests:
1155
1156 2007-11-12  Sam Weinig  <sam@webkit.org>
1157
1158         Reviewed by Adam Roben.
1159
1160         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
1161
1162         * DumpRenderTree/win/DumpRenderTree.cpp:
1163         (runTest):
1164         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1165         (LayoutTestController::setPrivateBrowsingEnabled):
1166
1167 2007-11-12  Adam Roben  <aroben@apple.com>
1168
1169         * Scripts/update-webkit-localizable-strings: Changed to only scan the
1170         mac and win subdirectories.
1171
1172 2007-11-11  Adam Roben  <aroben@apple.com>
1173
1174         Fix <rdar://5133816> keepWebHistory is not implemented
1175
1176         Fixes fast/history/clicked-link-is-visited.html.
1177
1178         Reviewed by Darin.
1179
1180         * DumpRenderTree/win/DumpRenderTree.cpp:
1181         (runTest): Clear the optionalSharedHistory.
1182         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1183         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
1184
1185 2007-11-10  Sam Weinig  <sam@webkit.org>
1186
1187         Reviewed by Tim Hatcher.
1188
1189         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
1190         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
1191         is turned on)
1192
1193         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
1194
1195         Added test: http/tests/security/cross-frame-access-private-browsing.html
1196
1197         * DumpRenderTree/LayoutTestController.cpp:
1198         (setPrivateBrowsingEnabledCallback):
1199         (LayoutTestController::staticFunctions):
1200         * DumpRenderTree/LayoutTestController.h:
1201         * DumpRenderTree/mac/DumpRenderTree.mm:
1202         (runTest): Default to private browsing disabled.
1203         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1204         (LayoutTestController::setPrivateBrowsingEnabled):
1205         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1206         (LayoutTestController::setPrivateBrowsingEnabled):
1207
1208 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1209
1210         Reviewed by Adam.
1211
1212         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
1213         WebCore's!
1214
1215         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
1216         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
1217         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
1218         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
1219         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
1220         * Drosera/win/Drosera.cpp:
1221         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1222
1223 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1224
1225         Reviewed by Sam.
1226
1227         - Use the new IWebFrame [local] function signature and get the shared
1228         server correctly.
1229
1230         * Drosera/win/DebuggerClient.cpp:
1231         (DebuggerClient::didFinishLoadForFrame):
1232         * Drosera/win/ServerConnection.cpp:
1233         (ServerConnection::attemptToCreateServerConnection):
1234
1235 2007-11-07  Dan Bernstein  <mitz@apple.com>
1236
1237         Reviewed by Darin Adler.
1238
1239         - add an option to run-webkit-tests to ignore pixel test failures where
1240           all pixels differ by no more than a specified threshold
1241
1242         * DumpRenderTree/mac/ImageDiff.m:
1243         (main):
1244         (compareImages):
1245         (computePercentageDifferent):
1246         * Scripts/run-webkit-tests:
1247
1248 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1249
1250         Reviewed by Lars.
1251
1252         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
1253
1254         * DumpRenderTree/qt/DumpRenderTree.cpp:
1255
1256 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1257
1258         Reviewed by Lars.
1259
1260         Reworked the QWebSettings API.
1261         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
1262
1263         * DumpRenderTree/qt/DumpRenderTree.cpp:
1264
1265 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1266
1267         Reviewed by Lars.
1268
1269         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
1270
1271         * DumpRenderTree/qt/jsobjects.cpp:
1272
1273 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1274
1275         Reviewed by Lars Knoll <lars@trolltech.com>.
1276
1277         Add a QWebPage::frameCreated() signal and fix DRT
1278         
1279         The removal of createFrame in QWebPage broke the re-implementation
1280         in DumpRenderTree. Instead emit a frameCreated() signal and
1281         connect to it in DumpRenderTree.
1282         
1283
1284         * DumpRenderTree/qt/DumpRenderTree.cpp:
1285         (WebCore::WebPage::WebPage):
1286         (WebCore::DumpRenderTree::dump):
1287         (WebCore::DumpRenderTree::connectFrame):
1288         * DumpRenderTree/qt/DumpRenderTree.h:
1289
1290 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1291
1292         Reviewed by Lars Knoll <lars@trolltech.com>.
1293
1294         Moved all the event handlers from QWebFrame into QWebPage.
1295         
1296         This cleans up the public API and allows us to remove the
1297         HackWebFrame hack in DumpRenderTree.
1298         
1299
1300         * DumpRenderTree/qt/jsobjects.cpp:
1301         (EventSender::mouseDown):
1302         (EventSender::mouseUp):
1303         (EventSender::mouseMoveTo):
1304
1305 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1306
1307         Reviewed by Mark.
1308
1309         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
1310         to prevent the default implementation from popping up messageboxes.
1311
1312         * DumpRenderTree/qt/DumpRenderTree.cpp:
1313         (WebCore::WebPage::javaScriptConfirm):
1314         (WebCore::WebPage::javaScriptPrompt):
1315
1316 2007-11-06  Eric Seidel  <eric@webkit.org>
1317
1318         * Scripts/build-testkjs: build fix... too many $$
1319
1320 2007-11-06  Eric Seidel  <eric@webkit.org>
1321
1322         Reviewed by Mark Rowe.
1323
1324         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
1325
1326 2007-11-05  Adam Roben  <aroben@apple.com>
1327
1328         Add support on Windows for WEBKIT_TESTFONTS
1329
1330         This environment variable lets you specify where the fonts to be used
1331         by DumpRenderTree reside. The Qt port is already using this, so I'm
1332         just following their lead.
1333
1334         Reviewed by Darin.
1335
1336         * DumpRenderTree/win/DumpRenderTree.cpp:
1337         (exePath): Refactored code out of initialize().
1338         (fontsPath): Returns either $WEBKIT_TESTFONTS or
1339         DumpRenderTree.resources.
1340         (initialize): Use the new fontsPath function.
1341         (main): Use the new exePath function.
1342         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
1343         variable to DRT, like Qt does.
1344
1345 2007-11-05  Mark Rowe  <mrowe@apple.com>
1346
1347         Rubber-stamped by Alp Toker.
1348
1349         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
1350
1351         * GtkLauncher/main.cpp:
1352         (goToURLBarText):
1353         (main):
1354
1355 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
1356
1357         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
1358         <http://bugs.webkit.org/show_bug.cgi?id=15830>
1359
1360         Reviewed by Timothy.
1361
1362         Restrict the range of nightly builds used by the bisect-builds script
1363         based on the version of Safari and the version of Mac OS X being used.
1364
1365         Mac OS X 10.4: Safari 2.0: r11976 or newer
1366         Mac OS X 10.4: Safari 3.0: r19992 or newer
1367
1368         Mac OS X 10.5: Safari 2.0: r19594 or newer
1369         Mac OS X 10.5: Safari 3.0: r25124 or newer
1370
1371         * Scripts/bisect-builds:
1372         (findMacOSXVersion): Added.
1373         (makeNightlyList): Added argument to provide version of Mac OS X.
1374         Restrict range of nightly builds based on Safari and Mac OS X versions.
1375
1376 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
1377
1378         Reviewed by Maciej.
1379
1380         - This patch involves several changes, all of them were noticed that
1381         they were needed by the work being done in WebKit to get Drosera and
1382         WebKit working together on Windows.
1383         - The changes are:
1384         1) Added a debugger console for output messages.
1385         2) Drosera now listens for the WebKit server (before, the server would
1386         have to be running before Drosera was started.)
1387         3) Fixed a bug where the WebView started out as 0x0 pixels.
1388         4) Fixed a bug when there is no scope.
1389         5) Added the HTML, JS, and CSS to the project file to make them easy to
1390         find.
1391         6) Made the ServerConnection functions virtual.
1392
1393         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
1394         for the WebKit server.
1395         (DebuggerClient::DebuggerClient):
1396         (DebuggerClient::~DebuggerClient):
1397         (DebuggerClient::didFinishLoadForFrame):
1398         (DebuggerClient::serverConnected):
1399         (DebuggerClient::attemptToCreateServerConnection):
1400         * Drosera/win/DebuggerClient.h: Ditto.
1401         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
1402         scope.
1403         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1404         (DebuggerDocument::platformValueForScopeVariableNamed):
1405         * Drosera/win/Drosera.cpp:
1406         (_tWinMain): Added a console in debug for output messages.
1407         (Drosera::Drosera): Listen for server.
1408         (Drosera::initUI): The server now Initializes COM.
1409         (Drosera::serverConnected): Part of the listening for the server.
1410         (Drosera::attemptToCreateServerConnection): Ditto.
1411         * Drosera/win/Drosera.h: New interface for listening for the server.
1412         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
1413         files to the VS project.
1414         * Drosera/win/ServerConnection.cpp: Part of listening for the server
1415         connection.
1416         (ServerConnection::ServerConnection):
1417         (ServerConnection::attemptToCreateServerConnection):
1418         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
1419         methods.
1420         (ServerConnection::serverConnected):
1421
1422 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
1423
1424         Reviewed by Maciej.
1425
1426         http://bugs.webkit.org/show_bug.cgi?id=15832
1427         fast/dom/gc-10.html crashes when run alone
1428
1429         Check for !done before using objects that can be already deallocated.
1430
1431         * DumpRenderTree/mac/EditingDelegate.mm:
1432         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
1433         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
1434         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
1435         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
1436         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
1437         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1438         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
1439         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
1440         (-[EditingDelegate webViewDidBeginEditing:]):
1441         (-[EditingDelegate webViewDidChange:]):
1442         (-[EditingDelegate webViewDidEndEditing:]):
1443         (-[EditingDelegate webViewDidChangeTypingStyle:]):
1444         (-[EditingDelegate webViewDidChangeSelection:]):
1445         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1446         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1447         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
1448         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1449         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
1450         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
1451         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
1452         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
1453         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
1454         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
1455         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
1456         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
1457         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
1458         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
1459         (-[FrameLoadDelegate webView:willCloseFrame:]):
1460         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
1461         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
1462         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1463         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1464         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1465         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
1466         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
1467         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
1468         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
1469
1470 2007-11-04  Mark Rowe  <mrowe@apple.com>
1471
1472         Build fix.  Don't use Carbon.h as the prefix header as it triggers
1473         warnings that would otherwise be suppressed due to it being a system header.
1474
1475         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1476
1477 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
1478
1479         Rubber stamped by Adam.
1480         
1481         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
1482
1483         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1484
1485 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1486
1487         Sort files(...); sections of Xcode project files.
1488
1489         Rubber-stamped by Darin.
1490
1491         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
1492         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1493         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1494         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1495
1496 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1497
1498         Script to sort "files(...);" sections in Xcode project.pbxproj files.
1499
1500         Reviewed by Darin.
1501
1502         * Scripts/sort-Xcode-project-file: Added.
1503
1504 2007-11-02  Darin Adler  <darin@apple.com>
1505
1506         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
1507
1508 2007-11-02  Darin Adler  <darin@apple.com>
1509
1510         Reviewed by Maciej.
1511
1512         * Scripts/run-sunspider: Pass the "--base" option through.
1513
1514         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
1515         the real script do that. Default configuration to Release to match run-sunspider
1516         so we don't end up building Debug just to compare results.
1517
1518 2007-11-01  Adam Roben  <aroben@apple.com>
1519
1520         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
1521
1522         Reviewed by Sam.
1523
1524         * Scripts/commit-log-editor: Show all the directories beneath the
1525         source root, instead of just the last one.
1526
1527 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
1528
1529         Reviewed by Adam Roben.
1530
1531         Print out an error message when the Windows build fails
1532         and provide guidance on how to find out what went wrong.
1533
1534         * Scripts/build-webkit:
1535         * Scripts/webkitdirs.pm:
1536
1537 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
1538
1539         Rubber-stamped by Adam Roben.
1540
1541         Rolled out r27326 - debug CRT seems to cause no problems after all.
1542
1543         * DumpRenderTree/win/DumpRenderTree.vcproj:
1544
1545 2007-10-31  Adam Roben  <aroben@apple.com>
1546
1547         Switch the Debug configuration to using the non-debug CRT
1548
1549         This matches WebKit.
1550
1551         Reviewed by Steve.
1552
1553         * DumpRenderTree/win/DumpRenderTree.vcproj:
1554
1555 2007-10-31  Antti Koivisto  <antti@apple.com>
1556
1557         Reviewed by bdash.
1558         
1559         Disable media tests when doing leak checking on Tiger.
1560         They crash in QuickTime (rdar://problem/5537157).
1561
1562         * Scripts/run-webkit-tests:
1563
1564 2007-10-29  Antti Koivisto  <antti@apple.com>
1565
1566         Reviewed by Maciej.
1567         
1568         Build media support by default on OSX only.
1569
1570         * Scripts/build-webkit:
1571
1572 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1573
1574         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
1575         get caught by the pre-commit hooks.
1576
1577 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1578
1579         Reviewed by Adam.
1580
1581         - This is a collection of relatively unrelated changes and cleanups
1582         to Drosera to prepare it for interacting with WebKit.  A lot of these
1583         changes are just correcting mistakes, for example removing included
1584         headers that are no longer needed.
1585
1586         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
1587         this will be needed by the DebuggerClient.
1588         (DebuggerDocument::server):
1589         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
1590         * Drosera/win/DebuggerClient.cpp: 
1591         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
1592         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
1593         (DebuggerClient::createWebViewWithRequest): Added comment about its
1594         purpose. 
1595         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
1596         declarations.
1597         (DebuggerClient::webViewLoaded): Moved.
1598         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
1599         file, since this was the only place it was used.
1600         (cfStringToBSTR):
1601         * Drosera/win/Drosera.h: Cleaned up the includes.
1602         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
1603         * Drosera/win/HelperFunctions.h: Removed.
1604
1605 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1606
1607         Reviewed by Adam.
1608
1609         - Small cleanup in the ServerConnection class.
1610
1611         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
1612         and added an include.
1613         (ServerConnection::currentFrame):
1614         (ServerConnection::getCallerFrame):
1615         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
1616         made a pointer into a COMPtr, and cleaned up the includes.
1617
1618 2007-10-29  Timothy Hatcher  <timothy@apple.com>
1619
1620         Reviewed by John Sullivan.
1621         
1622         - Place the Localizable.strings file in mac or win directories
1623           if that location exists.
1624         - Also look for UI_STRING in .c files.
1625
1626         * Scripts/extract-localizable-strings:
1627
1628 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1629
1630         Reviewed by Adam.
1631
1632         - Set the eol-style to native and made all the line endings the same
1633         so that I avoid messy diffs that show eol changes.
1634
1635         * Drosera/win/ServerConnection.cpp:
1636         (ServerConnection::didParseSource):
1637         (ServerConnection::didEnterCallFrame):
1638         (ServerConnection::willExecuteStatement):
1639         (ServerConnection::willLeaveCallFrame):
1640         (ServerConnection::exceptionWasRaised):
1641
1642 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1643
1644         Reviewed by Adam.
1645
1646         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
1647         functionality that could not have existed previously without the new
1648         interfaces.
1649         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
1650         from a BSTR to a JSValueRef.
1651         (DebuggerDocument::platformEvaluateScript): Implemented.
1652         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
1653         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1654         Implemented.
1655         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
1656         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
1657         * Drosera/win/ServerConnection.cpp: Added a helper function.
1658         (ServerConnection::getCallerFrame):
1659         * Drosera/win/ServerConnection.h: Added a helper function.
1660
1661 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
1662
1663         updated reviewers for my previous changelog.
1664
1665 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
1666         Reviewed by Maciej and Adam and Geoff.
1667
1668         - Minor mac-side improvements including moving a function to a more
1669         appropriate location, fixing a warning, and correctly checking
1670         exceptions.
1671
1672         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
1673         (DebuggerDocument::willExecuteStatement):
1674         (DebuggerDocument::didEnterCallFrame):
1675         (DebuggerDocument::willLeaveCallFrame):
1676         (DebuggerDocument::windowScriptObjectAvailable):
1677         (DebuggerDocument::callFunctionOnObject):
1678         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
1679         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
1680         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
1681         because it doesn't require the ServerConnection at all.
1682         (NSStringCreateWithJSStringRef): Made an argument const.
1683         (JSValueRefCreateWithNSString): Made an argument const.
1684         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
1685         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1686         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
1687         * Drosera/mac/ServerConnection.mm: Ditto.
1688         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
1689
1690 2007-10-29  Sam Weinig  <sam@webkit.org>
1691
1692         Reviewed by Adam Roben.
1693
1694         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
1695
1696         * DumpRenderTree/LayoutTestController.cpp:
1697         (LayoutTestController::LayoutTestController):
1698         (getGlobalFlagCallback):
1699         (setGlobalFlagCallback):
1700         (LayoutTestController::getJSClass):
1701         (LayoutTestController::staticValues):
1702         * DumpRenderTree/LayoutTestController.h:
1703         (LayoutTestController::globalFlag):
1704         (LayoutTestController::setGlobalFlag):
1705
1706 2007-10-29  Darin Adler  <darin@apple.com>
1707
1708         Reviewed by Maciej.
1709
1710         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
1711         resolution instead of its default.
1712
1713 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
1714
1715         Fixed showStatus() to print status for successfully resolved conflicts when using git.
1716
1717         Reviewed by Mark Rowe.
1718
1719         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
1720         was successfully resolved, but this would not show any status because the change had
1721         already been cached in the index using "git add".  The solution is to add an optional
1722         second argument to showStatus() which adds the "--cached" switch to the command.
1723
1724         * Scripts/resolve-ChangeLogs:
1725         (showStatus):
1726
1727 2007-10-28  Eric Seidel  <eric@webkit.org>
1728
1729         Reviewed by Maciej and Geoff, in unison.
1730
1731         * Scripts/run-webkit-tests: remove broken --svg option
1732
1733 2007-10-28  Darin Adler  <darin@apple.com>
1734
1735         Reviewed by Adam.
1736
1737         * Scripts/run-sunspider: Default to "Release" configuration rather than
1738         defaulting to the last configuration used as other scripts do. This can
1739         still be overriden on the command line with "--debug" if there's some
1740         reason to do so. Also fix a typo.
1741
1742         * Scripts/sunspider-compare-results: Fix a typo.
1743
1744 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
1745
1746         Reviewed by Adam.
1747
1748         - Implemented the WebScriptDebugListener functions now that the
1749         WebScriptDebugServer exists
1750
1751         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
1752         functions.
1753         (ServerConnection::currentFrame):
1754         (ServerConnection::didLoadMainResourceForDataSource):
1755         (ServerConnection::didParseSource):
1756         (ServerConnection::failedToParseSource):
1757         (ServerConnection::didEnterCallFrame):
1758         (ServerConnection::willExecuteStatement):
1759         (ServerConnection::willLeaveCallFrame):
1760         (ServerConnection::exceptionWasRaised):
1761         * Drosera/win/ServerConnection.h: Removed unused arguments from the
1762         members arguments list.
1763
1764 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
1765
1766         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
1767         <http://bugs.webkit.org/show_bug.cgi?id=15600>
1768
1769         Reviewed by Darin.
1770
1771         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
1772         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
1773         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
1774         file.  Note that it may also be used as a stand-alone script.
1775
1776         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
1777         * Scripts/resolve-ChangeLogs: Added.
1778         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
1779
1780 2007-10-26  Mark Rowe  <mrowe@apple.com>
1781
1782         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
1783         to the Qt port on the assumption that it was an implementation of the cross-platform
1784         LayoutTestController class.  It is not, so it did not need to be changed.
1785
1786         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
1787
1788 2007-10-25  Mark Rowe  <mrowe@apple.com>
1789
1790         Reviewed by Maciej.
1791
1792         Fix builds with code coverage enabled.
1793
1794         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
1795
1796 2007-10-25  Darin Adler  <darin@apple.com>
1797
1798         Reviewed by Mark Rowe.
1799
1800         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
1801         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
1802
1803 2007-10-25  Stephanie  <slewis@apple.com>
1804
1805         build Fix
1806
1807         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1808
1809 2007-10-25  Stephanie  <slewis@apple.com>
1810
1811         Reviewed by Mark Rowe, Adam Roben.
1812
1813         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
1814
1815         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
1816
1817 2007-10-25  Alice Liu  <alice.liu@apple.com>
1818
1819         Reviewed by Adam.
1820
1821         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
1822
1823         Moving destructor into platform-specific files
1824         * DumpRenderTree/LayoutTestController.cpp:
1825         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1826         (LayoutTestController::~LayoutTestController):
1827         * DumpRenderTree/qt/jsobjects.cpp:
1828         (LayoutTestController::~LayoutTestController):
1829
1830         LayoutTestController wasn't being destroyed
1831         * DumpRenderTree/win/DumpRenderTree.cpp:
1832         (runTest):
1833
1834         Added declspec
1835         * DumpRenderTree/win/EditingDelegate.h:
1836
1837         Reset certain values on the webview (or related delegate) that might 
1838         have changed while running a test
1839         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1840         (LayoutTestController::~LayoutTestController):
1841
1842 2007-10-25  Adam Roben  <aroben@apple.com>
1843
1844         Make sunspider-compare-results work with relative paths
1845
1846         Reviewed by Sam.
1847
1848         * Scripts/sunspider-compare-results: Convert arguments to absolute
1849         paths before we chdir.
1850
1851 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
1852
1853         Reviewed by Sam.
1854
1855         - Implemented server calls now the WebScriptDebugServer exists.
1856         - Also removed no longer needed call to initialize CG.
1857
1858         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
1859         automatically now.
1860         (_tWinMain):
1861         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
1862         (ServerConnection::ServerConnection):
1863         (ServerConnection::~ServerConnection):
1864         (ServerConnection::pause):
1865         (ServerConnection::resume):
1866         (ServerConnection::stepInto):
1867         (ServerConnection::applicationTerminating):
1868         (ServerConnection::serverConnectionDidDie):
1869         * Drosera/win/ServerConnection.h: Now uses the COM class.
1870
1871 2007-10-24  George Staikos  <staikos@kde.org>
1872
1873         Unbreak Qt build.
1874
1875         * Scripts/build-webkit:
1876
1877 2007-10-24  Adam Roben  <aroben@apple.com>
1878
1879         Remove now-unnecessary call to InitializeCoreGraphics
1880
1881         WebKit takes care of this now.
1882
1883         Reviewed by Ada.
1884
1885         * DumpRenderTree/win/DumpRenderTree.cpp:
1886         (initialize):
1887
1888 2007-10-24  Adam Roben  <aroben@apple.com>
1889
1890         Use WebTextRenderer in DRT
1891
1892         Reviewed by Ada.
1893
1894         * DumpRenderTree/win/DumpRenderTree.cpp:
1895         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
1896
1897 2007-10-24  Sven Herzberg  <sven@imendio.com>
1898
1899         Reviewed by Mark Rowe.
1900
1901         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
1902         Bug 15614: [GTK] qmake based backends don't build on OS X
1903
1904         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
1905         GTK backend on a Mac
1906         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
1907         isDarwin() to make it reusable in other places (like the workaround-
1908         for-prebuilt-qmake in build-webkit)
1909
1910 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
1911
1912         Refurbish update-webkit script.
1913
1914         Reviewed by Adam.
1915
1916         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
1917         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
1918         multi-argument version of system() for flexibility and security.  Check for existence
1919         of Internal directory using -d test instead of -x.
1920
1921 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
1922
1923         Minor clean-up of prepare-ChangeLog script.
1924
1925         Reviewed by Adam.
1926
1927         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
1928         of a string.  Use multi-argument versions of open() and system() for flexibility and
1929         security.
1930
1931 2007-10-24  Alice Liu  <alice.liu@apple.com>
1932
1933         Reviewed by Oliver.
1934
1935         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
1936
1937         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
1938         replay the saved events when we're still processing the mousedown that starts the drag
1939         * DumpRenderTree/win/EventSender.cpp:
1940         (doMouseMove):
1941         * DumpRenderTree/win/UIDelegate.cpp:
1942         (UIDelegate::doDragDrop):
1943
1944 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
1945
1946         Reviewed by Sam, Steve and Darin.
1947
1948         - Stubbed out the WebScriptDebugListener functionality in the Server
1949         Connection class to prepare it for receiving those callbacks.
1950         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
1951         and the ServerConnection to not need to be initialized with a server
1952         name, since that is not the way we connect to the WebKit server. 
1953
1954         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
1955         no exception.  Now it only loggs when there is an exception
1956         (DebuggerDocument::willExecuteStatement):
1957         (DebuggerDocument::didEnterCallFrame):
1958         (DebuggerDocument::willLeaveCallFrame):
1959         (DebuggerDocument::windowScriptObjectAvailable):
1960         (DebuggerDocument::callFunctionOnObject):
1961         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
1962         to be instantiated with a server's name.
1963         (DebuggerClient::DebuggerClient):
1964         (DebuggerClient::didFinishLoadForFrame):
1965         * Drosera/win/DebuggerClient.h: Removed unsued variable.
1966         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
1967         a server name.
1968         (Drosera::init):
1969         (Drosera::initServer):
1970         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
1971         instantiated with a server's name.
1972         * Drosera/win/ServerConnection.cpp: 
1973         (ServerConnection::ServerConnection): No longer needs a server name
1974         (ServerConnection::~ServerConnection): Only release the global context
1975         if there is one.
1976         (ServerConnection::serverConnectionDidDie): Stub for
1977         IWebScriptDebugListener
1978         (ServerConnection::QueryInterface): ditto
1979         (ServerConnection::AddRef): ditto
1980         (ServerConnection::Release): ditto
1981         (ServerConnection::didLoadMainResourceForDataSource): ditto
1982         (ServerConnection::didParseSource): ditto
1983         (ServerConnection::failedToParseSource): ditto
1984         (ServerConnection::didEnterCallFrame): ditto
1985         (ServerConnection::willExecuteStatement): ditto
1986         (ServerConnection::willLeaveCallFrame): ditto
1987         (ServerConnection::exceptionWasRaised): ditto
1988         * Drosera/win/ServerConnection.h: Stubbed out the
1989         IWebScriptDebugListener functions, and this class no longer needs to be
1990         instantiated with a server name.
1991
1992 2007-10-24  Lars Knoll  <lars@trolltech.com>
1993
1994         Reviewed by Simon.
1995
1996         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
1997
1998         * DumpRenderTree/qt/jsobjects.h:
1999
2000 2007-10-24  Lars Knoll  <lars@trolltech.com>
2001
2002         Reviewed by Simon.
2003
2004         add another command.
2005
2006         * DumpRenderTree/qt/jsobjects.cpp:
2007         (TextInputController::doCommand):
2008
2009 2007-10-24  Lars Knoll  <lars@trolltech.com>
2010
2011         Reviewed by Simon.
2012
2013         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
2014
2015         * DumpRenderTree/qt/jsobjects.cpp:
2016         (EventSender::keyDown):
2017         * DumpRenderTree/qt/jsobjects.h:
2018
2019 2007-10-24  Lars Knoll  <lars@trolltech.com>
2020
2021         Reviewed by Simon.
2022
2023         implement eventSender.keyDown().
2024
2025         * DumpRenderTree/qt/jsobjects.cpp:
2026         (EventSender::keyDown):
2027
2028 2007-10-24  Lars Knoll  <lars@trolltech.com>
2029
2030         Reviewed by Simon.
2031
2032         some smaller fixes to the editing support in DRT. Makes another few tests pass.
2033
2034         * DumpRenderTree/qt/DumpRenderTree.cpp:
2035         (WebCore::DumpRenderTree::DumpRenderTree):
2036         (WebCore::DumpRenderTree::initJSObjects):
2037         * DumpRenderTree/qt/jsobjects.cpp:
2038         (TextInputController::doCommand):
2039
2040 2007-10-24  Lars Knoll  <lars@trolltech.com>
2041
2042         Reviewed by Simon.
2043
2044         first bit of implementation for the textinputcontroller.
2045
2046         * DumpRenderTree/qt/DumpRenderTree.cpp:
2047         (WebCore::DumpRenderTree::DumpRenderTree):
2048         * DumpRenderTree/qt/DumpRenderTree.h:
2049         * DumpRenderTree/qt/jsobjects.cpp:
2050         (TextInputController::TextInputController):
2051         (TextInputController::doCommand):
2052         * DumpRenderTree/qt/jsobjects.h:
2053
2054 2007-10-24  Lars Knoll  <lars@trolltech.com>
2055
2056         Reviewed by Simon.
2057
2058         make the man webpage believe it has focus, so the editing tests work correctly.
2059
2060         * DumpRenderTree/qt/DumpRenderTree.cpp:
2061         (WebCore::DumpRenderTree::DumpRenderTree):
2062
2063 2007-10-24  Lars Knoll  <lars@trolltech.com>
2064
2065         Reviewed by Simon.
2066
2067         implement layoutTestController.dumpEditingCallbacks() correctly.
2068
2069         * DumpRenderTree/qt/DumpRenderTree.cpp:
2070         (WebCore::DumpRenderTree::DumpRenderTree):
2071         * DumpRenderTree/qt/jsobjects.cpp:
2072         (LayoutTestController::reset):
2073         (LayoutTestController::dumpEditingCallbacks):
2074
2075 2007-10-24  Lars Knoll  <lars@trolltech.com>
2076
2077         Reviewed by Simon.
2078
2079         Implement support for testing editing.
2080
2081         * DumpRenderTree/qt/DumpRenderTree.cpp:
2082         (WebCore::DumpRenderTree::DumpRenderTree):
2083
2084 2007-10-23  Sam Weinig  <sam@webkit.org>
2085
2086         Check for null BSTR that can be passed to the UIDelegate methods
2087         from javascript null and undefined.  Fixes a failing test case on
2088         Windows (fast/dom/Window/alert-undefined.html)
2089
2090         Reviewed by Eric Seidel.
2091
2092         * DumpRenderTree/win/UIDelegate.cpp:
2093         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2094         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2095         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2096         (UIDelegate::webViewAddMessageToConsole):
2097
2098 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2099
2100         Reviewed by Darin.
2101         
2102         Don't print a massive pile of setenvs from tools that automatically build testkjs.
2103
2104         * Scripts/build-testkjs:
2105
2106 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2107
2108         Reviewed by Darin.
2109
2110         - add wrapper that finds the right copy of testkjs
2111         
2112         * Scripts/sunspider-compare-results: Added.
2113
2114 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
2115
2116         Reviewed by Sam.
2117
2118         - After talking with Steve I now see that the WebKit server must be
2119         running for DCOM to create the distributed objects, which makes sense
2120         and currently WebKit only allows one instance to be running at a time
2121         which avoids accidentally connecting to the wrong server
2122         - In light of this I have removed the code for the attach box and
2123         NotificationServer and known server names, since they are all extranious
2124         now.
2125
2126         * Drosera/win/Drosera.cpp: Removed notification classes and known server
2127         names.
2128         (_tWinMain): Uses init instead of initUI.
2129         (droseraWndProc): No longer creats an attach dialog box.
2130         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
2131         it's not manditory to call init before doing COM stuff.
2132         (Drosera::init): calls initUI and will call attach when the
2133         functionality exists. 
2134         (Drosera::initUI): Has changed very little.
2135         (Drosera::attach): Changed the signature to reflect that we no longer
2136         need the dictionary of known server names.
2137         * Drosera/win/Drosera.h: Removed notification classes and known server
2138         names.  Also renamed and moved some functions.
2139         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
2140         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
2141         headers to the resources folder. 
2142         * Drosera/win/resource.h: Removed the Attach box.
2143
2144 2007-10-22  Adam Roben  <aroben@apple.com>
2145
2146         Windows build fix
2147
2148         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
2149
2150 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
2151
2152         - Removed a leak that was fixed.
2153
2154         * Scripts/run-webkit-tests:
2155
2156 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2157
2158         Reviewed by Darin.
2159
2160         - Changed the Client so that the DebuggerDocument now own the
2161         ServerConnection.  This simplifies ownership and cleanup. 
2162
2163         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
2164         ServerConnection.
2165         (DebuggerClient::initWithServerName):
2166         (DebuggerClient::didFinishLoadForFrame):
2167         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
2168         ServerConnection.
2169         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
2170         until after we have a server which we are attached to.
2171         (Drosera::initUI):
2172         (Drosera::attach):
2173         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
2174         out previously.
2175
2176 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2177
2178         Reviewed by Nikolas.
2179
2180         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
2181
2182         * Scripts/run-javascriptcore-tests:
2183
2184 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2185
2186         Reviewed by Nikolas.
2187
2188         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
2189
2190         * Scripts/build-drosera:
2191         * Scripts/build-dumprendertree:
2192         * Scripts/build-testkjs:
2193         * Scripts/build-webkit:
2194         * Scripts/run-javascriptcore-tests:
2195         * Scripts/run-sunspider:
2196         * Scripts/run-webkit-tests:
2197         * Scripts/webkitdirs.pm:
2198
2199 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
2200
2201         Reviewed by Mark Rowe.
2202         
2203         Fix for local database support after r26879
2204         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
2205
2206         * Scripts/build-webkit:
2207
2208 2007-10-22  Holger Freyther  <zecke@selfish.org>
2209
2210         Reviewed by Simon Hausmann <hausmann@kde.org>.
2211
2212         - Do not build testkjs as an application bundle. This is
2213         needed for run-javascriptcore-tests on OSX.
2214         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
2215         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
2216         as we do not have -rpath on OSX.
2217
2218         * DumpRenderTree/qt/DumpRenderTree.pro:
2219         * Scripts/run-webkit-tests:
2220
2221 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2222
2223         Reviewed by aroben.
2224
2225         Fix support for Signed-off-by detection in prepare-ChangeLog
2226         --git-commit. The Signed-off-by tag does not appear in the header
2227         but usually at the end.
2228
2229         * Scripts/prepare-ChangeLog:
2230
2231 2007-10-21  Mark Rowe  <mrowe@apple.com>
2232
2233         Reviewed by Eric.
2234
2235         Fix run-javascriptcore-tests for Gtk.
2236
2237         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
2238
2239 2007-10-20  Eric Seidel  <eric@webkit.org>
2240
2241         Reviewed by aroben.
2242
2243         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
2244
2245 2007-10-20  Eric Seidel  <eric@webkit.org>
2246
2247         Reviewed by darin.
2248         
2249         Add improved argument handling to run-sunspider, including
2250         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
2251         Also re-factor code into subroutines
2252
2253         * Scripts/build-dumprendertree: removed bogus comments
2254         * Scripts/build-testkjs: Added.
2255         * Scripts/run-javascriptcore-tests: use build-testkjs
2256         * Scripts/run-sunspider: improved argument handling, abstraction
2257         * Scripts/run-webkit-tests: improved abstraction
2258
2259 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
2260
2261         Not reviewed, Windows build fix.
2262
2263         * DumpRenderTree/win/EventSender.cpp:
2264         (keyDownCallback):
2265
2266 2007-10-20  Darin Adler  <darin@apple.com>
2267
2268         Reviewed by Tim Hatcher.
2269
2270         - http://bugs.webkit.org/show_bug.cgi?id=15544
2271           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
2272           not rely on Apple-specific key codes
2273
2274         * DumpRenderTree/mac/EventSendingController.mm:
2275         (-[EventSendingController keyDown:withModifiers:]):
2276         Added named key "rightArrow". Later we could have a whole table of these.
2277         Also tweaked modifiers code a little.
2278
2279         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
2280
2281 2007-10-19  Darin Adler  <darin@apple.com>
2282
2283         Reviewed by Eric.
2284
2285         - http://bugs.webkit.org/show_bug.cgi?id=15566
2286           possible fix for leak seen in DumpRenderTree
2287
2288         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
2289         Delete the item if it's not put on the queue, since the caller has
2290         no way of knowing that. Would be better to have the parameter type
2291         be auto_ptr to express the fact that we take ownership.
2292
2293         - unrelated change
2294
2295         * Drosera/mac/main.m: Add missing include.
2296
2297 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2298
2299         Reviewed by Adam.
2300
2301         - This change should be identical but for some reason was not working
2302         on my machine.
2303
2304         * Scripts/prepare-ChangeLog:
2305
2306 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2307
2308         Reviewed by Oliver and Tim.
2309
2310         - Made use of RetainPtr to avoid retain and release issues and moved the
2311         log function to DebuggerDocumentPlatform, which seems to be a more
2312         logical place for it to live.
2313         - Also moved knownServers from the ServerConnection to
2314         DebuggerApplication to match the Windows code and because it makes sense
2315         that a connection knows its own server but not all of them.
2316
2317         * Drosera/mac/DebuggerClient.h: Moved the log function to
2318           DebuggerDocumentPlatform.
2319         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
2320           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
2321           call for the server name up from the ServerConnection class.
2322         (-[DebuggerClient dealloc]):
2323         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
2324           for the server name up from the ServerConnection.
2325         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
2326         (DebuggerDocument::platformPause):
2327         (DebuggerDocument::platformResume):
2328         (DebuggerDocument::platformStepInto):
2329         (DebuggerDocument::platformEvaluateScript):
2330         (DebuggerDocument::getPlatformCurrentFunctionStack):
2331         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2332         (DebuggerDocument::platformValueForScopeVariableNamed):
2333         (DebuggerDocument::platformLog): Log directly from here. No need to call
2334           DebuggerClient.
2335         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
2336           way I see it, a ServerConnection should only know about its connection
2337           and the group of all possible servers should be kept by the
2338           application.
2339         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
2340           currentServerName, it makes sense that the connection should know that
2341           name.
2342         (-[ServerConnection currentServerName]):
2343
2344 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2345
2346         Reviewed by Adam.
2347
2348         - Integrated changes from mac drosera.  Recently I've encapsulated
2349         out the server connection object from the rest of Drosera because
2350         it is very platform dependent right now and RPC is not implemented on
2351         windows.  This functionality, of communicating with the WebKit server
2352         is the next area I will be focusing on in Windows.
2353
2354         - Other changes and cleanup were made to organize the code and add notes
2355         on which parts still need work.  Also some mac code is added and
2356         commented out, to act as pseudocode for the logic of those parts.
2357
2358         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
2359           pointer.
2360         * Drosera/config.h: Added whitespace.
2361         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
2362           these files got moved into Drosera.h/cpp
2363         * Drosera/win/DebuggerApplication.h: Removed.
2364         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
2365           happened here to better match the logic flow of the same code on the 
2366           mac side and to use the new ServerConnection class.
2367         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
2368         (DebuggerClient::initWithServerName): Initializer that will set up the
2369           class to use a ServerConnection object.  This was necessary so I could
2370           create a DebuggerClient without having to initilaize it at
2371           construction.
2372         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
2373           will be the UIDelegate and FrameLoadDelegate.
2374         (DebuggerClient::AddRef): For IUnknown.
2375         (DebuggerClient::Release): For IUnknown.
2376         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
2377           this still needs to set the global context of the server, but
2378           IWebFrame does not have an accessor for the global context yet. 
2379         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
2380           this is a pass through for the same function in the document.
2381         (DebuggerClient::didReceiveTitle): Unimplemented part of
2382           FrameLoadDelegate this would change the title of the window.
2383         (DebuggerClient::createWebViewWithRequest): Part of the
2384           FrameLoadDelegate.  This is about new windows via Window.open() and
2385           how their delegates are set.
2386         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
2387           UIDelegate.  Just a debug function for printing messages.
2388         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
2389           because the Client should be the UIDelegate and FrameLoadDelegate
2390           to match the delegates on mac.
2391         (DebuggerClient::webViewLoaded): Added accessor method.
2392         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
2393           forgotten to add this file before.  This is where the platform
2394           dependent versions of the Documents functions live. Most of these are
2395           unimplemented because some piece of functionality does not exist on
2396           Windows yet.
2397         (DebuggerDocument::platformPause):
2398         (DebuggerDocument::platformResume):
2399         (DebuggerDocument::platformStepInto):
2400         (DebuggerDocument::platformEvaluateScript):
2401         (DebuggerDocument::getPlatformCurrentFunctionStack):
2402         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2403         (DebuggerDocument::platformValueForScopeVariableNamed):
2404         (DebuggerDocument::platformLog):
2405         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
2406           responsibilities becaue they belong in the Client. Also I laid the
2407           groundwork for attaching Drosera to a WebKit process
2408         (attachWndProc): Now if a server is selected the Client becomes it's
2409           delegate.
2410         (Drosera::Drosera): Added the construction of the Client and dictionary
2411           of server names. 
2412         (Drosera::initUI): This is no longer the delegates, the Client is.
2413         (Drosera::webViewLoaded): Now asks the Client instead of holding local
2414           state. 
2415         (Drosera::applicationDidFinishLaunching): Placeholder for needed
2416           notification registration when it's possible to implement.
2417         (Drosera::serverLoaded): Ditto
2418         (Drosera::serverUnloaded): Ditto
2419         (Drosera::attach): Attach Drosera to the WebKit server.
2420         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
2421         (Drosera::getInst): 
2422         (Drosera::setInst):
2423         (Drosera::knownServers):
2424         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
2425           and added the ServerConnection.
2426         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
2427         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
2428           Most of the functions are completely unimlemented because they cannot
2429           connect with the WebKit server, because one does not exist on Windows
2430           yet.
2431         (ServerConnection::initWithServerName): 
2432         (ServerConnection::~ServerConnection):
2433         (ServerConnection::setGlobalContext):
2434         (ServerConnection::pause):
2435         (ServerConnection::resume):
2436         (ServerConnection::stepInto):
2437         (ServerConnection::switchToServerNamed):
2438         (ServerConnection::applicationTerminating):
2439         (ServerConnection::serverConnectionDidDie):
2440         (ServerConnection::currentFrame):
2441         * Drosera/win/ServerConnection.h: Added. Ditto.
2442         (ServerConnection::ServerConnection):
2443
2444 2007-10-19  Alice Liu  <alice.liu@apple.com>
2445
2446         Reviewed by Darin.
2447
2448         Fix for these broken layout tests on Windows:
2449         
2450         fast/forms/focus-selection-input.html
2451         fast/forms/focus-selection-textarea.html
2452         fast/forms/select-accesskey.html
2453         
2454         * DumpRenderTree/win/EventSender.cpp:
2455         (keyDownCallback):
2456         correct the VK code for alt key.
2457         
2458 2007-10-19  Eric Seidel  <eric@webkit.org>
2459
2460         Reviewed by Mark Rowe.
2461         
2462         Make the GtkLauncher code slightly more readable.
2463
2464         * GtkLauncher/main.cpp:
2465         (setupMainMenu): Added.
2466         (setupMainWindowUI): Added.
2467         (main):
2468
2469 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
2470
2471         Rubber stamped by Adam.
2472         
2473         - don't delay-load WebKit in DumpRenderTree.
2474
2475         * DumpRenderTree/win/DumpRenderTree.vcproj:
2476
2477 2007-10-18  Dan Bernstein  <mitz@apple.com>
2478
2479         Reviewed by Adam Roben.
2480
2481         - fix <rdar://problem/5313523>
2482         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
2483
2484         * DumpRenderTree/mac/DumpRenderTree.mm:
2485         (dump): Changed to use _responseMIMEType.
2486
2487 2007-10-17  Adam Roben  <aroben@apple.com>
2488
2489         Make it possible to have Windows-specific tests and results
2490
2491         When searching for tests to run and the Skipped file, we will only
2492         look in platform/win and the cross-platform directory. When looking
2493         for expected results, we will look in platform/win, then
2494         platform/mac-leopard, then platform/mac, then finally the
2495         cross-platform directory.
2496
2497         Reviewed by Sam.
2498
2499         * Scripts/run-webkit-tests:
2500         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
2501         searching in the cross-platform directory.
2502         (sub buildPlatformHierarchy): Removed some unneeded calls to
2503         dirname/basename.
2504
2505 2007-10-17  Adam Roben  <aroben@apple.com>
2506
2507         Add back the call to register WebKit that we had before WebKitInitializer existed
2508
2509         This is needed to ensure that the right WebKit is used when
2510         instantiating COM objects.
2511
2512         Reviewed by Oliver.
2513
2514         * DumpRenderTree/win/debug_internal.vsprops: Define
2515         DEBUG_WEBKIT_HAS_SUFFIX.
2516         * DumpRenderTree/win/DumpRenderTree.cpp:
2517         (initialize):
2518
2519 2007-10-17  Adam Roben  <aroben@apple.com>
2520
2521         Import File::Basename in webkitdirs since we use it
2522
2523         * Scripts/webkitdirs.pm:
2524
2525 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
2526
2527         - Updated the tiger leaks list to make the internal bots green.
2528
2529         * Scripts/run-webkit-tests:
2530
2531 2007-10-17  Adam Roben  <aroben@apple.com>
2532
2533         Build fix for VC++ Express
2534
2535         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
2536         and ole32.lib.
2537
2538 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2539
2540         Reviewed by Sam.
2541
2542         - Minor mac improvements based on observations I made while implementing the
2543         Windows code.
2544
2545         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
2546         then hand it to the Client who will retain it, it should just be the client who
2547         creates and owns the server.
2548         (-[DebuggerApplication attach:]):
2549         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
2550         * Drosera/mac/DebuggerClient.mm: Creates the server.
2551         (-[DebuggerClient initWithServerName:]):
2552         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
2553         can instead forward declare what it needs.
2554
2555 2007-10-16  Darin Adler  <darin@apple.com>
2556
2557         Reviewed by Geoff Garen.
2558
2559         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
2560         want to turn failing tests into platform-specific test results. Also did a
2561         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
2562         would take the type of results into account only some of the time.
2563
2564 2007-10-16  Adam Roben  <aroben@apple.com>
2565
2566         Add a new nightly launcher script for Windows
2567
2568         This new script is for versions of Safari that don't delay-load
2569         WebKit. I had to make FindSafari be able to print out the nightly
2570         launcher script on stdout because Windows shell scripts can't capture
2571         the output from a command into an environment variable.
2572
2573         Reviewed by Steve.
2574
2575         * FindSafari/FindSafari.cpp:
2576         (_tmain): Added /printSafariLauncher option.
2577         * Scripts/run-webkit-nightly.cmd: Added.
2578
2579 2007-10-16  Adam Roben  <aroben@apple.com>
2580
2581         Replace WebKitInitializer with FindSafari
2582
2583         We now rely on setting the PATH environment variable to tell Windows
2584         where to find WebKit and its dependencies (similar to
2585         DYLD_FRAMEWORK_PATH on Mac).
2586
2587         This change also make DumpRenderTree no longer delay-load WebKit.
2588
2589         Reviewed by Sam.
2590
2591         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
2592         FindSafari.
2593         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
2594         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
2595         WebKitInitializer, don't delay-load WebKit.
2596         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
2597         * Scripts/run-webkit-tests: Ditto.
2598         * Scripts/webkitdirs.pm:
2599         (sub setPathForRunningWebKitApp): Added.
2600         * WebKitInitializer/WebKitInitializer.cpp: Removed.
2601         * WebKitInitializer/WebKitInitializer.h: Removed.
2602         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
2603         * WebKitInitializer/debug.vsprops: Removed.
2604         * WebKitInitializer/debug_internal.vsprops: Removed.
2605         * WebKitInitializer/release.vsprops: Removed.
2606
2607 2007-10-16  Adam Roben  <aroben@apple.com>
2608
2609         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
2610
2611         http://bugs.webkit.org/show_bug.cgi?id=15532
2612
2613         FindSafari simply prints the location of an installed Safari.exe on
2614         stdout.
2615
2616         Reviewed by Darin.
2617
2618         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
2619         (getStringValue):
2620         (getWebViewCLSID):
2621         (getInstalledWebKitDirectory):
2622         (_tmain):
2623         * FindSafari/FindSafari.vcproj: Added.
2624         * Scripts/webkitdirs.pm:
2625         (sub installedSafariPath): Added. Calls FindSafari on Windows.
2626
2627 2007-10-16  Adam Roben  <aroben@apple.com>
2628
2629         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
2630
2631         Reviewed by Kevin McCullough.
2632
2633         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
2634         when referring to WebKit.dll.
2635         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
2636         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
2637         * DumpRenderTree/win/release.vsprops: Ditto.
2638         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
2639         never have a _debug suffix on WebKit.dll.
2640         * WebKitInitializer/WebKitInitializer.cpp:
2641         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
2642         specified.
2643         * WebKitInitializer/debug_internal.vsprops: Added
2644         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
2645
2646 2007-10-16  Darin Adler  <darin@apple.com>
2647
2648         Reviewed by Adele.
2649
2650         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
2651         Remove now-unneeded control/alt key hack; the tests have been updated.
2652
2653 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2654
2655         - Updated leaks list because our internal bot upgraded it's version of leopard and 
2656         one of the leaks was fixed between that revision and the bot's previous version of
2657         leopard.
2658
2659         * Scripts/run-webkit-tests:
2660
2661 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
2662
2663         Reviewed by Tim.
2664
2665         - I encapsulated out the server connecton functionality because it is a specific part
2666         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
2667         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
2668         Windows.  So the majority of this patch is moving preexisting functionality.
2669
2670         - Also I removed the prefix header and changed to use config.h because it is more
2671         standard on how we use config.h in windows and it didn't make much sense to keep
2672         the prefix header and the config.h
2673
2674         * Drosera/DebuggerDocument.cpp:
2675         (DebuggerDocument::DebuggerDocument):
2676         * Drosera/DebuggerDocument.h:
2677         * Drosera/config.h:
2678         * Drosera/mac/DebuggerApplication.mm:
2679         (-[DebuggerApplication attach:]):
2680         * Drosera/mac/DebuggerClient.h:
2681         * Drosera/mac/DebuggerClient.mm:
2682         (-[DebuggerClient initWithServerConnection:]):
2683         (-[DebuggerClient dealloc]):
2684         (-[DebuggerClient windowDidLoad]):
2685         (-[DebuggerClient windowWillClose:]):
2686         (-[DebuggerClient webView:didFinishLoadForFrame:]):
2687         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
2688         * Drosera/mac/DebuggerDocumentPlatform.mm:
2689         (DebuggerDocument::platformPause):
2690         (DebuggerDocument::platformResume):
2691         (DebuggerDocument::platformStepInto):
2692         (DebuggerDocument::platformEvaluateScript):
2693         (DebuggerDocument::getPlatformCurrentFunctionStack):
2694         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2695         (DebuggerDocument::platformValueForScopeVariableNamed):
2696         (DebuggerDocument::platformLog):
2697         * Drosera/mac/Drosera.pch: Removed.
2698         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2699         * Drosera/mac/ServerConnection.h: Added.
2700         * Drosera/mac/ServerConnection.mm: Added.
2701         (-[ServerConnection initWithServerName:]):
2702         (-[ServerConnection dealloc]):
2703         (-[ServerConnection setGlobalContext:]):
2704         (-[ServerConnection pause]):
2705         (-[ServerConnection resume]):
2706         (-[ServerConnection stepInto]):
2707         (-[ServerConnection switchToServerNamed:]):
2708         (-[ServerConnection applicationTerminating:]):
2709         (-[ServerConnection serverConnectionDidDie:]):
2710         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2711         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
2712         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
2713         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
2714         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
2715         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
2716         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
2717         (-[ServerConnection currentFrame]):
2718         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
2719         (-[ServerConnection knownServers]):
2720
2721 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
2722
2723         Reviewed by Eric.
2724
2725         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
2726           Script to automatically search nightly builds for regressions (bisect-builds)
2727
2728         * Scripts/bisect-builds: Added.
2729
2730 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
2731
2732         Reviewed by Darin.
2733
2734         - New JavaScript benchmark
2735         http://bugs.webkit.org/show_bug.cgi?id=15515
2736
2737         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
2738         current development or release build of JavaScriptCore.
2739
2740 2007-10-15  Mark Rowe  <mrowe@apple.com>
2741
2742         Reviewed by Sam.
2743
2744         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
2745
2746         * Scripts/webkitdirs.pm:
2747         - Change checkArgv to remove the options from @ARGV to prevent
2748         them from interfering with further option processing.
2749         - Fix logic error in determineIsQt that would prevent it from bailing out early.
2750         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
2751         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
2752         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
2753
2754 2007-10-15  Darin Adler  <darin@apple.com>
2755
2756         Reviewed by Sam.
2757
2758         - added logging of window.prompt and window.confirm
2759
2760         * DumpRenderTree/mac/UIDelegate.mm:
2761         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2762         Implement the recommended delegate rather than the deprecated one.
2763         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
2764         Added.
2765         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2766         Added.
2767
2768         * DumpRenderTree/win/UIDelegate.h:
2769         * DumpRenderTree/win/UIDelegate.cpp:
2770         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
2771         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
2772         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
2773         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
2774
2775 2007-10-15  Alice Liu  <alice.liu@apple.com>
2776
2777         Reviewed by Sam Weinig.
2778
2779         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
2780
2781         * DumpRenderTree/win/DumpRenderTree.cpp:
2782         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
2783         (main): allocate the global policy delegate for DRT's custom use
2784         * DumpRenderTree/win/DumpRenderTree.vcproj:
2785         Adding files to project
2786         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
2787         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2788         (LayoutTestController::setCustomPolicyDelegate):
2789         set the webview's policy delegate to DRT's custom one if the test requests it.
2790         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
2791         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
2792         (PolicyDelegate::PolicyDelegate):
2793         (PolicyDelegate::QueryInterface):
2794         (PolicyDelegate::AddRef):
2795         (PolicyDelegate::Release):
2796         (PolicyDelegate::decidePolicyForNavigationAction):
2797         * DumpRenderTree/win/PolicyDelegate.h: Added.
2798         (PolicyDelegate::decidePolicyForNewWindowAction):
2799         (PolicyDelegate::decidePolicyForMIMEType):
2800         (PolicyDelegate::unableToImplementPolicyWithError):
2801
2802 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
2803
2804         Reviewed by Mark.
2805
2806         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
2807         when querying for QMAKE_MKSPECS.
2808
2809 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
2810
2811         Reviewed by Adam Roben.
2812         
2813         Fix run-webkit-tests is too greedy calculating platform hierarchy
2814         http://bugs.webkit.org/show_bug.cgi?id=15465
2815         
2816         Fix run-webkit-tests being too greedy in trying to split the platform name up
2817         causing it to try and find tests in every directory above the first "-" in the
2818         path to the LayoutTests
2819
2820         * Scripts/run-webkit-tests:
2821
2822 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
2823
2824         Reviewed by Darin.
2825
2826         http://bugs.webkit.org/show_bug.cgi?id=15006
2827         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
2828         to reduce code duplication.
2829
2830         * Scripts/build-webkit:
2831         * Scripts/webkitdirs.pm:
2832         buildQMakeProject() renamed to buildQMakeQtProject().
2833         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
2834         unused $colorize has been removed.
2835
2836 === Start merge of feature-branch 2007-10-12 ===
2837
2838 2007-10-08  Eric Seidel  <eric@webkit.org>
2839
2840         Reviewed by Mark Rowe.
2841
2842         * Scripts/build-webkit: add --help, remove unused --color
2843
2844 2007-10-07  Eric Seidel  <eric@webkit.org>
2845
2846         Reviewed by darin.
2847
2848         * Drosera/mac/DebuggerDocumentPlatform.mm:
2849         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
2850
2851 2007-10-03  Rob Buis  <buis@kde.org>
2852
2853         Reviewed by Olliej.
2854
2855         Adapt to changed location of Ahem font.
2856
2857         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2858
2859 2007-10-02  Eric Seidel  <eric@webkit.org>
2860
2861         Reviewed by Adam Roben.
2862         
2863         Make pixel tests more useful!
2864         Finally fix the image diff 0.00% mystery problem
2865         Highlight any image differences in the image diff.
2866         Add a link from image diffs back to original test file.
2867
2868         * DumpRenderTree/mac/ImageDiff.m:
2869         (compareImages): highlight any differences
2870         (computePercentageDifferent): round to two decimal places
2871         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
2872
2873 2007-10-02  Eric Seidel  <eric@webkit.org>
2874
2875         Reviewed by Alexey Proskuryakov.
2876
2877         * Scripts/run-webkit-tests: print the % image difference on main results page
2878
2879 2007-10-02  Mark Rowe  <mrowe@apple.com>
2880
2881         Reviewed by Oliver.
2882
2883         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
2884
2885         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
2886         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
2887
2888 2007-10-01  Mark Rowe  <mrowe@apple.com>
2889
2890         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
2891
2892 2007-09-25  Eric Seidel  <eric@webkit.org>
2893
2894         Reviewed by Mark Rowe.
2895         
2896         DerivedSources.make was finding "ENABLE_SVG" in the string
2897         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
2898         quite correctly.
2899
2900         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
2901
2902 2007-09-25  Mark Rowe  <mrowe@apple.com>
2903
2904         Rubber-stamped by Eric.
2905
2906         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
2907         This makes it possible to automate nightly builds for the feature-branch.
2908
2909 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
2910
2911         Rubber stamped by Mark.
2912
2913         Enable svg experimental features as default here in feature-branch.
2914
2915         * Scripts/build-webkit:
2916
2917 2007-06-29  Antti Koivisto  <antti@apple.com>
2918
2919         Reviewed by Weinig.
2920         
2921         Add VIDEO flag for timed media features
2922
2923         * Scripts/build-webkit
2924         
2925 === End merge of feature-branch 2007-10-12 ===
2926
2927 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
2928
2929         Reviewed by Darin.
2930
2931         - Updated rational for the leaks list to be more clear.
2932
2933         * Scripts/run-webkit-tests:
2934
2935 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
2936
2937         Rubber Stamp by Sam.
2938
2939         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
2940         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
2941
2942         * Scripts/run-webkit-tests:
2943
2944 2007-10-10  Simon Hausmann  <hausmann@kde.org>
2945
2946         Reviewed by Lars.
2947
2948         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
2949         includes are needed for INT_MAX, std::auto_ptr and the like.
2950
2951         * DumpRenderTree/qt/main.cpp:
2952
2953 2007-10-09  Lars Knoll  <lars@trolltech.com>
2954
2955         Reviewed by Simon.
2956
2957         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
2958
2959         * DumpRenderTree/qt/jsobjects.cpp:
2960         (LayoutTestController::encodeHostName):
2961         (LayoutTestController::decodeHostName):
2962         * DumpRenderTree/qt/jsobjects.h:
2963
2964 2007-10-09  Lars Knoll  <lars@trolltech.com>
2965
2966         Reviewed by Simon.
2967
2968         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
2969
2970         * DumpRenderTree/qt/DumpRenderTree.cpp:
2971         (WebCore::WebPage::createFrame):
2972         (WebCore::DumpRenderTree::DumpRenderTree):
2973         (WebCore::DumpRenderTree::titleChanged):
2974         * DumpRenderTree/qt/DumpRenderTree.h:
2975         * DumpRenderTree/qt/jsobjects.cpp:
2976         (LayoutTestController::reset):
2977         * DumpRenderTree/qt/jsobjects.h:
2978
2979 2007-10-09  Lars Knoll  <lars@trolltech.com>
2980
2981         Reviewed by Simon.
2982
2983         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
2984
2985         * DumpRenderTree/qt/DumpRenderTree.h:
2986         * DumpRenderTree/qt/jsobjects.cpp:
2987         (LayoutTestController::clearBackForwardList):
2988         * DumpRenderTree/qt/jsobjects.h:
2989
2990 2007-10-09  Lars Knoll  <lars@trolltech.com>
2991
2992         Reviewed by Simon.
2993
2994         make --git-reviewer work again.
2995
2996         * Scripts/prepare-ChangeLog:
2997
2998 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
2999
3000         Rubber stamped by Eric.
3001
3002         Connect to the "hovering-over-link" signal emitted by WebKitPage and
3003         show the current link inside the statusbar.
3004         This shows how to make use of this signal and allows to easily test
3005         http://bugs.webkit.org/show_bug.cgi?id=15299.
3006
3007         * GtkLauncher/main.cpp:
3008         (hoveringOverLink):
3009         (main):
3010
3011 2007-10-05  Lars Knoll  <lars@trolltech.com>
3012
3013         add proper error messages to the FrameLoaderClient.
3014         Implement ChromeClientQt::closeWindowSoon and
3015         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
3016         Some fixes in DRT to make it work correctly with multiple windows.
3017
3018         Reviewed by Maciej.
3019
3020         * DumpRenderTree/qt/DumpRenderTree.cpp:
3021         (WebCore::DumpRenderTree::DumpRenderTree):
3022         (WebCore::DumpRenderTree::createWindow):
3023         (WebCore::DumpRenderTree::windowCount):
3024         * DumpRenderTree/qt/DumpRenderTree.h:
3025         * DumpRenderTree/qt/jsobjects.cpp:
3026         (LayoutTestController::maybeDump):
3027         (LayoutTestController::windowCount):
3028         * DumpRenderTree/qt/jsobjects.h:
3029
3030 2007-10-05  Lars Knoll  <lars@trolltech.com>
3031
3032         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
3033         Add support for layoutTextController.setCanOpenWindows() to DRT
3034         fixing another 2 test cases in fast/dom/Window.
3035
3036         Reviewed by Maciej.
3037
3038         * DumpRenderTree/qt/DumpRenderTree.cpp:
3039         (WebCore::WebPage::WebPage):
3040         (WebCore::WebPage::createWindow):
3041         (WebCore::DumpRenderTree::resetJSObjects):
3042         (WebCore::DumpRenderTree::createWindow):
3043         * DumpRenderTree/qt/DumpRenderTree.h:
3044         * DumpRenderTree/qt/DumpRenderTree.pro:
3045         * DumpRenderTree/qt/jsobjects.cpp:
3046         (LayoutTestController::LayoutTestController):
3047         (LayoutTestController::reset):
3048         * DumpRenderTree/qt/jsobjects.h:
3049         * DumpRenderTree/qt/main.cpp:
3050         * DumpRenderTree/qt/testplugin.cpp: Added.
3051         * DumpRenderTree/qt/testplugin.h: Added.
3052
3053 2007-10-04  Sam Weinig  <sam@webkit.org>
3054
3055         Rubber stamped by Adam.
3056
3057         Remove empty directories.
3058
3059         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
3060         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
3061
3062 2007-10-03  Darin Adler  <darin@apple.com>
3063
3064         Reviewed by Adam.
3065
3066         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
3067         we find the internal libraries in the libraries directory. This
3068         is helpful for Safari team engineers at Apple.
3069
3070 2007-10-03  Adam Roben  <aroben@apple.com>
3071
3072         Update the location of AHEM___.TTF after r25968
3073
3074         Reviewed by Sam.
3075
3076         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3077
3078 2007-10-03  Alp Toker  <alp@atoker.com>
3079
3080         Reviewed by Adam.
3081
3082         http://bugs.webkit.org/show_bug.cgi?id=14726
3083         [gtk] API design. Mapping the WebView delegates to signals.
3084
3085         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
3086
3087         * GtkLauncher/main.cpp:
3088         (goToURLBarText):
3089         (titleChanged):
3090         (progressChanged):
3091         (menuMainBackCallback):
3092         (menuMainForwardCallback):
3093         (main):
3094
3095 2007-10-03  Lars Knoll  <lars@trolltech.com>
3096
3097         Reviewed by Rob.
3098
3099         This fixes --strict mode in run-webkit-tests again after
3100         the platform dependent test results have been moved.
3101
3102         * Scripts/run-webkit-tests:
3103
3104 2007-10-03  Lars Knoll  <lars@trolltech.com>
3105
3106         Reviewed by bdash.
3107
3108         remove the hack in run-webkit-tests that forced text only test
3109         to be taken from the platform independent dir. It was only left
3110         there from early days.
3111         
3112         Remove platform dependent results for tests that are text only nowadays,
3113         and add one platform dependent result for a text only test that requires it.
3114
3115         * Scripts/run-webkit-tests:
3116
3117 2007-10-03  Lars Knoll  <lars@trolltech.com>
3118
3119         Reviewed by olliej.
3120
3121         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
3122
3123         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
3124         (WebCore::WebFrame::WebFrame):
3125         (WebCore::WebPage::WebPage):
3126         (WebCore::WebPage::createFrame):
3127         (WebCore::WebPage::javaScriptAlert):
3128         (WebCore::WebPage::javaScriptConsoleMessage):
3129         (WebCore::DumpRenderTree::DumpRenderTree):
3130         (WebCore::DumpRenderTree::~DumpRenderTree):
3131         (WebCore::DumpRenderTree::open):
3132         (WebCore::DumpRenderTree::readStdin):
3133         (WebCore::DumpRenderTree::resetJSObjects):
3134         (WebCore::DumpRenderTree::initJSObjects):
3135         (WebCore::DumpRenderTree::dumpFramesAsText):
3136         (WebCore::DumpRenderTree::dump):
3137         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
3138         (WebCore::DumpRenderTree::layoutTestController):
3139         (WebCore::DumpRenderTree::eventSender):
3140         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
3141         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
3142         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
3143         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
3144         (HackWebFrame::mousePressEvent):
3145         (HackWebFrame::mouseReleaseEvent):
3146         (HackWebFrame::mouseMoveEvent):
3147         (HackWebFrame::HackWebFrame):
3148         (HackWebFrame::~HackWebFrame):
3149         (LayoutTestController::LayoutTestController):
3150         (LayoutTestController::reset):
3151         (LayoutTestController::maybeDump):
3152         (LayoutTestController::waitUntilDone):
3153         (LayoutTestController::notifyDone):
3154         (LayoutTestController::dumpEditingCallbacks):
3155         (LayoutTestController::queueReload):
3156         (LayoutTestController::provisionalLoad):
3157         (LayoutTestController::timerEvent):
3158         (EventSender::EventSender):
3159         (EventSender::mouseDown):
3160         (EventSender::mouseUp):
3161         (EventSender::mouseMoveTo):
3162         (EventSender::leapForward):
3163         (EventSender::keyDown):
3164         (EventSender::frameUnderMouse):
3165         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
3166         (LayoutTestController::isLoading):
3167         (LayoutTestController::setLoading):
3168         (LayoutTestController::shouldDumpAsText):
3169         (LayoutTestController::shouldDumpChildrenAsText):
3170         (LayoutTestController::shouldWaitUntilDone):
3171         (LayoutTestController::dumpAsText):
3172         (LayoutTestController::dumpChildFramesAsText):
3173         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
3174         (messageHandler):
3175         (crashHandler):
3176         (main):
3177         * Scripts/run-webkit-tests:
3178
3179 2007-10-03  Mark Rowe  <mrowe@apple.com>
3180
3181         Reviewed by Alp Toker.
3182
3183         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
3184         should take precedence over QTDIR when determining which port we are working with.
3185
3186         * Scripts/webkitdirs.pm: 
3187
3188 2007-10-02  Adam Roben  <aroben@apple.com>
3189
3190         Add keychain to the list of default packages to install
3191
3192         Rubberstamped by Sam.
3193
3194         * CygwinDownloader/cygwin-downloader.py:
3195         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
3196
3197 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
3198
3199         Reviewed by Adam.
3200
3201         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
3202         Also makes WebCore regression test case logic work when using git.
3203
3204         * Scripts/prepare-ChangeLog:
3205         (reviewerAndDescriptionForGitCommit): Added.
3206
3207 2007-10-02  Lars Knoll  <lars@trolltech.com>
3208
3209         Reviewed by bdash.
3210
3211         Add API to retrieve the frame name from QWebFrame.
3212         Implement support for DRT::dumpChildrenAsText.
3213
3214         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3215         (WebCore::DumpRenderTree::dumpFramesAsText):
3216         (WebCore::DumpRenderTree::dump):
3217         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3218         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3219         (LayoutTestController::LayoutTestController):
3220         (LayoutTestController::reset):
3221         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
3222
3223 2007-10-02  Lars Knoll  <lars@trolltech.com>
3224
3225         Reviewed by bdash.
3226
3227         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
3228
3229         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3230         (WebCore::DumpRenderTree::readStdin):
3231
3232 2007-10-02  Mark Rowe  <mrowe@apple.com>
3233
3234         Reviewed by Oliver.
3235
3236         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3237
3238         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3239         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3240
3241 2007-10-02  Mark Rowe  <mrowe@apple.com>
3242
3243         Rubber-stamped by Maciej.
3244
3245         Configuration changes from build.webkit.org.  The major change is refactoring to work
3246         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
3247         last few weeks.
3248
3249         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3250         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
3251         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
3252         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
3253         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
3254         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
3255         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
3256         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
3257
3258 2007-10-02  Lars Knoll  <lars@trolltech.com>
3259
3260         Reviewed by Maciej.
3261
3262         Add support for eventSender.mouseMove to DRT.
3263         Fixes fast/css/hover-affects-child.html
3264
3265         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3266         (EventSender::mouseMoveTo):
3267
3268 2007-10-01  Mark Rowe  <mrowe@apple.com>
3269
3270         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3271
3272 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
3273
3274         Reviewed by Hyatt.
3275
3276         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
3277
3278         * Scripts/svn-apply:
3279         (gitdiff2svndiff): Ignore lines beginning with "new file".
3280         * Scripts/svn-unapply:
3281         (gitdiff2svndiff): Ditto.
3282
3283 2007-09-30  George Staikos  <staikos@kde.org>
3284
3285         Qt build fix (Mac OS X specific)
3286
3287         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
3288
3289 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
3290
3291         Reviewed by Mark.
3292
3293         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
3294         Remove Bakefiles from svn.
3295
3296         * GtkLauncher/Bakefiles.bkgen: Removed.
3297         * GtkLauncher/ENV: Removed.
3298         * GtkLauncher/gdklauncher.bkl: Removed.
3299         * GtkLauncher/mk: Removed.
3300         * Scripts/regenerate-makefiles: Removed.
3301
3302 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
3303
3304         Reviewed by John.
3305
3306         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
3307
3308         * Scripts/run-webkit-tests:
3309
3310 2007-09-26  Adam Roben  <aroben@apple.com>
3311
3312         Make not finding an installed WebKit non-fatal
3313
3314         What really matters is that we are able to load WebKit and its
3315         dependencies, not whether we think we've found an installed WebKit.
3316
3317         Reviewed by Sam.
3318
3319         * WebKitInitializer/WebKitInitializer.cpp:
3320         (getWebViewCLSID): Use new LOG_WARNING macro.
3321         (getInstalledWebKitDirectory): Ditto.
3322         (initializeWebKit): Don't die if we didn't find an installed WebKit,
3323         and use new macros.
3324         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
3325
3326 2007-09-26  Adam Roben  <aroben@apple.com>
3327
3328         Committed this file before saving it
3329
3330         * WebKitInitializer/debug_internal.vsprops:
3331
3332 2007-09-26  Adam Roben  <aroben@apple.com>
3333
3334         Load WebKit and its dependencies manually so they come from DllDirectory
3335
3336         I had to change WebKitInitializer to use malloc/free instead of
3337         new/delete to avoid pulling in WebKit (and its dependencies) early
3338         through use of fastMalloc.
3339
3340         Reviewed by Oliver.
3341
3342         * WebKitInitializer/WebKitInitializer.cpp:
3343         (getStringValue): Changed to use malloc/free.
3344         (getInstalledWebKitDirectory): Ditto.
3345         (initializeWebKit): Call SetDllDirectory first, then load all of
3346         WebKit's dependencies manually, finally followed by WebKit itself.
3347         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
3348         configuration to match our other projects.
3349         * WebKitInitializer/debug_internal.vsprops: Added.
3350
3351 2007-09-25  Adam Roben  <aroben@apple.com>
3352
3353         Actually define DEBUG/NDEBUG so that we load WebKit correctly
3354
3355         Rubberstamped by Sam.
3356
3357         * WebKitInitializer/WebKitInitializer.vcproj:
3358
3359 2007-09-25  Adam Roben  <aroben@apple.com>
3360
3361         Make DumpRenderTree delay-load its dependencies
3362
3363         This lets WebKitInitializer re-route the dependencies to be loaded out
3364         of the Safari installation directory.
3365
3366         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
3367         same thing), since we can't import the kCFAllocatorDefault symbol when
3368         delay-loading CoreFoundation.dll.
3369
3370         Rubberstamped by Sam.
3371
3372         * DumpRenderTree/win/DumpRenderTree.cpp:
3373         (runTest):
3374         (javaScriptThreads):
3375         * DumpRenderTree/win/DumpRenderTree.vcproj:
3376         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3377         (LayoutTestController::setWaitToDump):
3378
3379 2007-09-25  Adam Roben  <aroben@apple.com>
3380
3381         Pull ole32.lib into WebKitInitializer
3382
3383         Rubberstamped by Sam.
3384
3385         * WebKitInitializer/WebKitInitializer.vcproj:
3386
3387 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
3388
3389         Reviewed by Adam.
3390
3391         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
3392           LGPL'ed files contain incorrect FSF address
3393
3394         * Drosera/config.h:
3395
3396 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
3397
3398         Reviewed by Adam.
3399
3400         Make svn-apply and svn-unapply work with git-diff formatted patches.
3401
3402         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
3403         (gitdiff2svndiff): Added.
3404         * Scripts/svn-unapply: Ditto.
3405         (gitdiff2svndiff): Added.
3406
3407 2007-09-25  Adam Roben  <aroben@apple.com>
3408
3409         Pull advapi32.lib into WebKitInitializer
3410
3411         This is needed to get the registry functions we use.
3412
3413         Rubberstamped by Sam.
3414
3415         * WebKitInitializer/WebKitInitializer.vcproj:
3416
3417 2007-09-25  Adam Roben  <aroben@apple.com>
3418
3419         Add python and rsync to cygwin-downloader
3420
3421         Our build slaves need this, and it can't hurt for everyone else to
3422         have it, too.
3423
3424         Reviewed by Sam.
3425
3426         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
3427         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
3428
3429 2007-09-25  Adam Roben  <aroben@apple.com>
3430
3431         Add WebKitInitializer and use it in DumpRenderTree
3432
3433         WebKitInitializer is a static library that has one function,
3434         initializeWebKit(). This registers WebKit and sets up the DLL search
3435         path so that WebKit's dependencies that are installed with Safari can
3436         be found.
3437
3438         Reviewed by Sam.
3439
3440         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
3441         DumpRenderTree depend on it.
3442         * DumpRenderTree/win/DumpRenderTree.cpp:
3443         (initialize): Call initializeWebKit.
3444         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
3445         WebKitInitializer.lib.
3446         * WebKitInitializer/WebKitInitializer.cpp: Added.
3447         (getStringValue):
3448         (getWebViewCLSID):
3449         (getInstalledWebKitDirectory):
3450         (initializeWebKit):
3451         * WebKitInitializer/WebKitInitializer.h: Added.
3452         * WebKitInitializer/WebKitInitializer.vcproj: Added.
3453         * WebKitInitializer/debug.vsprops: Added.
3454         * WebKitInitializer/release.vsprops: Added.
3455
3456 2007-09-25  Adam Roben  <aroben@apple.com>
3457
3458         Make run-webkit-tests respect set-webkit-configuration
3459
3460         Reviewed by Sam.
3461
3462         * Scripts/run-webkit-tests: Initialize $configuration to whatever
3463         set-webkit-configuration was last set to.
3464
3465 2007-09-25  Mark Rowe  <mrowe@apple.com>
3466
3467         Rubber-stamped by Eric.
3468
3469         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
3470         This makes it possible to automate nightly builds for the feature-branch.
3471
3472 2007-09-25  Adam Roben  <aroben@apple.com>
3473
3474         A couple of fixes/enhancements to update-webkit-*-libs
3475
3476         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
3477         to tell update-webkit-support-libraries where it should find the
3478         WebKitSupportLibrary.zip file you downloaded.
3479
3480         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
3481         Windows-style path.
3482
3483         Reviewed by Sam.
3484
3485         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
3486         to $auxiliaryLibsURL and removed an irrelevant comment.
3487         * Scripts/update-webkit-support-libs:
3488
3489 2007-09-25  Adam Treat  <treat@kde.org>
3490
3491         Reviewed by Simon and Lars.
3492
3493         Refactors and cleans up Qt DRT member variable names, member variable
3494         initialization, style fixes and general code cleanup.
3495
3496         Adds queueReload slot to LayoutTestController that some tests require.
3497
3498         Subclasses QWebFrame to make sure that all frames have an associated
3499         LayoutTestController JS window object.
3500
3501         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
3502         aren't dumped twice.
3503
3504         EOF fixes.
3505
3506         Together, this patch fixes some 20+ layout tests in QtWebKit.
3507
3508         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3509         (WebCore::WebFrame::WebFrame):
3510         (WebCore::WebPage::WebPage):
3511         (WebCore::WebPage::createFrame):
3512         (WebCore::DumpRenderTree::DumpRenderTree):
3513         (WebCore::DumpRenderTree::open):
3514         (WebCore::DumpRenderTree::readStdin):
3515         (WebCore::DumpRenderTree::initJSObjects):
3516         (WebCore::DumpRenderTree::dump):
3517         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3518         (WebCore::DumpRenderTree::layoutTestController):
3519         (WebCore::DumpRenderTree::eventSender):
3520         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3521         (LayoutTestController::LayoutTestController):
3522         (LayoutTestController::reset):
3523         (LayoutTestController::maybeDump):
3524         (LayoutTestController::waitUntilDone):
3525         (LayoutTestController::notifyDone):
3526         (LayoutTestController::queueReload):
3527         (LayoutTestController::provisionalLoad):
3528         (EventSender::EventSender):
3529         (EventSender::mouseDown):
3530         (EventSender::mouseUp):
3531         (EventSender::mouseMoveTo):
3532         (EventSender::frameUnderMouse):
3533         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
3534         (LayoutTestController::isLoading):
3535         (LayoutTestController::setLoading):
3536         (LayoutTestController::dumpAsText):
3537         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
3538         (main):
3539
3540 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
3541
3542
3543         - Reverted an accidentally checked in file.
3544
3545         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
3546
3547 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
3548         Reviewed by Sam.
3549
3550         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
3551
3552         * DumpRenderTree/win/DumpRenderTree.vcproj:
3553         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3554
3555 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
3556
3557         Rubber stamped by Adam.
3558
3559         * GdkLauncher: Removed.
3560         * GdkLauncher/Bakefiles.bkgen: Removed.
3561         * GdkLauncher/ENV: Removed.
3562         * GdkLauncher/GdkLauncher.pro: Removed.
3563         * GdkLauncher/gdklauncher.bkl: Removed.
3564         * GdkLauncher/main.cpp: Removed.
3565         * GdkLauncher/mk: Removed.
3566         * GdkLauncher/simple.svg: Removed.
3567         * GdkLauncher/text.html: Removed.
3568         * GtkLauncher: Added.
3569         * GtkLauncher/GdkLauncher.pro: Removed.
3570         * GtkLauncher/GtkLauncher.pro: Added.
3571         * GtkLauncher/main.cpp:
3572         (updateWindowTitle):
3573         (main):
3574         * Scripts/build-webkit:
3575         * Scripts/regenerate-makefiles:
3576         * Scripts/run-javascriptcore-tests:
3577         * Scripts/run-launcher:
3578         * Scripts/run-webkit-tests:
3579         * Scripts/webkitdirs.pm:
3580
3581 2007-09-21  Timothy Hatcher  <timothy@apple.com>
3582
3583         Reviewed by Darin.
3584
3585         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
3586
3587         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
3588         This is tested by plugins/root-object-premature-delete-crash.html.
3589
3590         * DumpRenderTree/mac/ObjCController.m:
3591         (-[ObjCController accessStoredWebScriptObject]):
3592
3593 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
3594
3595         Reviewed by Oliver.
3596
3597         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
3598
3599         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
3600         (FrameLoadDelegate::FrameLoadDelegate):
3601
3602 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
3603
3604         Reviewed by Adam.
3605
3606         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
3607         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
3608
3609         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
3610         Now isQt() and isGdk() use global variables that are only set once.
3611
3612         An array of all the parameters is now given to build-dumprender which includes
3613         the platform on linux.
3614
3615         * Scripts/build-dumprendertree:
3616         * Scripts/run-webkit-tests:
3617         * Scripts/webkitdirs.pm:
3618
3619 2007-09-19  Adam Roben  <aroben@apple.com>
3620
3621         Rubberstamped by Hyatt.
3622
3623         * Spinneret: Removed.
3624
3625 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
3626
3627         Reviewed by David Kilzer.
3628
3629         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
3630
3631 2007-09-18  Sam Weinig  <sam@webkit.org>
3632
3633         Add JSRetainPtr.h #include to fix some builds.
3634
3635         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3636
3637 2007-09-18  Mike Hommey  <glandium@debian.org>
3638
3639         Reviewed by Adam.
3640
3641         * Scripts/prepare-ChangeLog:
3642         - Properly parse GECOS field.
3643         - Use git configuration for user name and email when appropriate.
3644
3645 2007-09-17  Sam Weinig  <sam@webkit.org>
3646
3647         Build fix.
3648
3649         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3650
3651 2007-09-17  Sam Weinig  <sam@webkit.org>
3652
3653         Reviewed by Adam Roben.
3654
3655         Share more code between mac and windows DRT.
3656             - GCController is now shared.
3657             - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
3658
3659         * DumpRenderTree/GCController.cpp:
3660         * DumpRenderTree/win/DumpRenderTree.cpp:
3661         * DumpRenderTree/win/DumpRenderTree.vcproj:
3662         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
3663         (FrameLoadDelegate::FrameLoadDelegate):
3664         (FrameLoadDelegate::~FrameLoadDelegate):
3665         (FrameLoadDelegate::windowScriptObjectAvailable):
3666         * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
3667         * DumpRenderTree/win/GCController.cpp: Removed.
3668         * DumpRenderTree/win/GCController.h: Removed.
3669         * DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp.
3670         (GCController::collect):
3671         (GCController::collectOnAlternateThread):
3672         (GCController::getJSObjectCount):
3673         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
3674         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
3675
3676 2007-09-17  Sam Weinig  <sam@webkit.org>
3677
3678         Reviewed by Adam Roben.
3679
3680         Begin sharing code between mac and windows DRT.
3681             - both now share LayoutTestController.h/cpp and implement platform dependant 
3682               operations in LayoutTestControllerMac/Win.
3683             - DumpRenderTree.h is now shared.
3684             - WorkQueue and WorkQueueItem are also shared.
3685
3686         * DumpRenderTree/DumpRenderTree.h:
3687         * DumpRenderTree/LayoutTestController.cpp:
3688         * DumpRenderTree/win/DumpRenderTree.cpp:
3689         (displayWebView):
3690         (dumpFrameScrollPosition):
3691         (dumpFramesAsText):
3692         (dump):
3693         (runTest):
3694         * DumpRenderTree/win/DumpRenderTree.h: Removed.
3695         * DumpRenderTree/win/DumpRenderTree.vcproj:
3696         * DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
3697         * DumpRenderTree/win/EditingDelegate.cpp:
3698         (EditingDelegate::shouldBeginEditingInDOMRange):
3699         (EditingDelegate::shouldEndEditingInDOMRange):
3700         (EditingDelegate::shouldInsertNode):
3701         (EditingDelegate::shouldInsertText):
3702         (EditingDelegate::shouldDeleteDOMRange):
3703         (EditingDelegate::shouldChangeSelectedDOMRange):
3704         (EditingDelegate::shouldApplyStyle):
3705         (EditingDelegate::shouldChangeTypingStyle):
3706         (EditingDelegate::doPlatformCommand):
3707         (EditingDelegate::webViewDidBeginEditing):
3708         (EditingDelegate::webViewDidChange):
3709         (EditingDelegate::webViewDidEndEditing):
3710         (EditingDelegate::webViewDidChangeTypingStyle):
3711         (EditingDelegate::webViewDidChangeSelection):
3712         * DumpRenderTree/win/LayoutTestController.cpp: Removed.
3713         * DumpRenderTree/win/LayoutTestController.h: Removed.
3714         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Copied from DumpRenderTree/win/LayoutTestController.cpp.
3715         (LayoutTestController::addDisallowedURL):
3716         (LayoutTestController::clearBackForwardList):
3717         (LayoutTestController::copyDecodedHostName):
3718         (LayoutTestController::copyEncodedHostName):
3719         (LayoutTestController::display):
3720         (LayoutTestController::keepWebHistory):
3721         (LayoutTestController::notifyDone):
3722         (LayoutTestController::queueBackNavigation):
3723         (LayoutTestController::queueForwardNavigation):
3724         (jsStringRefToWString):
3725         (LayoutTestController::queueLoad):
3726         (LayoutTestController::queueReload):
3727         (LayoutTestController::queueScript):
3728         (LayoutTestController::setAcceptsEditing):
3729         (LayoutTestController::setCustomPolicyDelegate):
3730         (LayoutTestController::setMainFrameIsFirstResponder):
3731         (LayoutTestController::setTabKeyCyclesThroughElements):
3732         (LayoutTestController::setUseDashboardCompatibilityMode):
3733         (LayoutTestController::setUserStyleSheetEnabled):
3734         (LayoutTestController::setUserStyleSheetLocation):
3735         (LayoutTestController::setWindowIsKey):
3736         (waitUntilDoneWatchdogFired):
3737         (LayoutTestController::setWaitToDump):
3738         (LayoutTestController::windowCount):
3739         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp:
3740         (FrameLoadDelegate::didReceiveTitle):
3741         (FrameLoadDelegate::processWork):
3742         (FrameLoadDelegate::locationChangeDone):
3743         (FrameLoadDelegate::windowScriptObjectAvailable):
3744         * DumpRenderTree/win/WorkQueue.cpp: Removed.
3745         * DumpRenderTree/win/WorkQueue.h: Removed.
3746         * DumpRenderTree/win/WorkQueueItem.cpp: Removed.
3747         * DumpRenderTree/win/WorkQueueItem.h: Removed.
3748         * DumpRenderTree/win/WorkQueueItemWin.cpp: Copied from DumpRenderTree/win/WorkQueueItem.cpp.
3749         (jsStringRefToWString):
3750         (LoadItem::invoke):
3751         (ScriptItem::invoke):
3752
3753 2007-09-17  Sam Weinig  <sam@webkit.org>
3754
3755         Reviewed by Adam Roben.
3756
3757         - Move Windows DumpRenderTree and TestNetscapePlugin to WebCoreTools/DumpRenderTree/win
3758
3759         * DumpRenderTree/DumpRenderTree.sln: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln.
3760         * DumpRenderTree/DumpRenderTree.vcproj: Removed.
3761         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Removed.
3762         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Removed.
3763         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h: Removed.
3764         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Removed.
3765         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Removed.
3766         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed.
3767         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: Removed.
3768         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: Removed.
3769         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: Removed.
3770         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h: Removed.
3771         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp: Removed.
3772         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h: Removed.
3773         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Removed.
3774         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Removed.
3775         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Removed.
3776         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Removed.
3777         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: Removed.
3778         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Removed.
3779         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp: Removed.
3780         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h: Removed.
3781         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: Removed.
3782         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: Removed.
3783         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops: Removed.
3784         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops: Removed.
3785         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops: Removed.
3786         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin: Removed.
3787         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
3788         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
3789         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
3790         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/main.c: Removed.
3791         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/resource.h: Removed.
3792         * DumpRenderTree/win: Added.
3793         * DumpRenderTree/win/DraggingInfo.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h.
3794         * DumpRenderTree/win/DumpRenderTree.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp.
3795         * DumpRenderTree/win/DumpRenderTree.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h.
3796         * DumpRenderTree/win/DumpRenderTree.vcproj: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj.
3797         * DumpRenderTree/win/EditingDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp.
3798         * DumpRenderTree/win/EditingDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h.
3799         * DumpRenderTree/win/EventSender.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp.
3800         * DumpRenderTree/win/EventSender.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h.
3801         * DumpRenderTree/win/GCController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp.
3802         * DumpRenderTree/win/GCController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h.
3803         * DumpRenderTree/win/LayoutTestController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp.
3804         * DumpRenderTree/win/LayoutTestController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h.
3805         * DumpRenderTree/win/TestNetscapePlugin: Copied from DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin.
3806         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3807         * DumpRenderTree/win/UIDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp.
3808         * DumpRenderTree/win/UIDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h.
3809         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp.
3810         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h.
3811         * DumpRenderTree/win/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
3812         * DumpRenderTree/win/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
3813         * DumpRenderTree/win/WorkQueueItem.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp.
3814         * DumpRenderTree/win/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
3815         * DumpRenderTree/win/debug.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops.
3816         * DumpRenderTree/win/debug_internal.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops.
3817         * DumpRenderTree/win/release.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops.
3818         * Scripts/run-webkit-tests: Update to point to the new location of the sln.
3819
3820 2007-09-15  Mark Rowe  <mrowe@apple.com>
3821
3822         Build fix for DumpRenderTree.
3823
3824         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Reinstate -Wno-deprecated-declarations on DumpRenderTree.mm.
3825
3826 2007-09-14  Sam Weinig  <sam@webkit.org>
3827
3828         Rubber stamped by Adam Roben.
3829
3830         Split the WaitUntilDoneDelegate into a UIDelegate and a FrameLoadDelegate.
3831           - The UIDelegate was put into a new file while the FrameLoadDelegate was
3832             kept in the WaitUntilDoneDelegate file for the time being.
3833
3834         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3835         (main):
3836         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
3837         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Added.
3838         (UIDelegate::QueryInterface):
3839         (UIDelegate::AddRef):
3840         (UIDelegate::Release):
3841         (UIDelegate::hasCustomMenuImplementation):
3842         (UIDelegate::setFrame):
3843         (UIDelegate::webViewFrame):
3844         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3845         (UIDelegate::webViewAddMessageToConsole):
3846         (UIDelegate::doDragDrop):
3847         (UIDelegate::webViewGetDlgCode):
3848         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Added.
3849         (UIDelegate::UIDelegate):
3850         (UIDelegate::createWebViewWithRequest):
3851         (UIDelegate::webViewShow):
3852         (UIDelegate::webViewClose):
3853         (UIDelegate::webViewFocus):
3854         (UIDelegate::webViewUnfocus):
3855         (UIDelegate::webViewFirstResponder):
3856         (UIDelegate::makeFirstResponder):
3857         (UIDelegate::setStatusText):
3858         (UIDelegate::webViewStatusText):
3859         (UIDelegate::webViewAreToolbarsVisible):
3860         (UIDelegate::setToolbarsVisible):
3861         (UIDelegate::webViewIsStatusBarVisible):
3862         (UIDelegate::setStatusBarVisible):
3863         (UIDelegate::webViewIsResizable):
3864         (UIDelegate::setResizable):
3865         (UIDelegate::setContentRect):
3866         (UIDelegate::webViewContentRect):
3867         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3868         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3869         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
3870         (UIDelegate::runOpenPanelForFileButtonWithResultListener):
3871         (UIDelegate::mouseDidMoveOverElement):
3872         (UIDelegate::contextMenuItemsForElement):
3873         (UIDelegate::validateUserInterfaceItem):
3874         (UIDelegate::shouldPerformAction):
3875         (UIDelegate::dragDestinationActionMaskForDraggingInfo):
3876         (UIDelegate::willPerformDragDestinationAction):
3877         (UIDelegate::dragSourceActionMaskForPoint):
3878         (UIDelegate::willPerformDragSourceAction):
3879         (UIDelegate::contextMenuItemSelected):
3880         (UIDelegate::trackCustomPopupMenu):
3881         (UIDelegate::measureCustomMenuItem):
3882         (UIDelegate::drawCustomMenuItem):
3883         (UIDelegate::addCustomMenuDrawingData):
3884         (UIDelegate::cleanUpCustomMenuDrawingData):
3885         (UIDelegate::canTakeFocus):
3886         (UIDelegate::takeFocus):
3887         (UIDelegate::registerUndoWithTarget):
3888         (UIDelegate::removeAllActionsWithTarget):
3889         (UIDelegate::setActionTitle):
3890         (UIDelegate::undo):
3891         (UIDelegate::redo):
3892         (UIDelegate::canUndo):
3893         (UIDelegate::canRedo):
3894         (UIDelegate::webViewResizerRect):
3895         (UIDelegate::webViewDrawResizer):
3896         (UIDelegate::webViewScrolled):
3897         (UIDelegate::webViewShouldInterruptJavaScript):
3898         (UIDelegate::webViewReceivedFocus):
3899         (UIDelegate::webViewLostFocus):
3900         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
3901         (FrameLoadDelegate::QueryInterface):
3902         (FrameLoadDelegate::AddRef):
3903         (FrameLoadDelegate::Release):
3904         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
3905         (FrameLoadDelegate::didCommitLoadForFrame):
3906         (FrameLoadDelegate::didReceiveTitle):
3907         (FrameLoadDelegate::processWork):
3908         (processWorkTimer):
3909         (FrameLoadDelegate::locationChangeDone):
3910         (FrameLoadDelegate::didFinishLoadForFrame):
3911         (FrameLoadDelegate::didFailLoadWithError):
3912         (FrameLoadDelegate::windowScriptObjectAvailable):
3913         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h:
3914         (FrameLoadDelegate::FrameLoadDelegate):
3915
3916 2007-09-14  Sam Weinig  <sam@webkit.org>
3917
3918         Reviewed by Kevin McCullough.
3919
3920         Move mac specific globals in to mac/DumpRenderTreeMac.h
3921
3922         * DumpRenderTree/DumpRenderTree.h:
3923         * DumpRenderTree/DumpRenderTree.mm: Removed.
3924         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3925         * DumpRenderTree/mac/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.mm.
3926         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added.
3927
3928 2007-09-14  Brady Eidson  <beidson@apple.com>
3929
3930         Rubberstamped by Weinig
3931
3932         You know, Sam, some of us use case-sensitve filesystems...
3933
3934         * DumpRenderTree/DumpRenderTree.h:
3935         * DumpRenderTree/mac/UIDelegate.mm:
3936
3937 2007-09-14  Sam Weinig  <sam@webkit.org>
3938
3939         Rubber stamped by Adam Roben.
3940
3941         - Move dump state data to LayoutTestContoller and add getter/setters to accommodate.
3942         - Move mac specific DumpRenderTree files to DumpRenderTree/mac
3943
3944         * DumpRenderTree/AppleScriptController.h: Removed.
3945         * DumpRenderTree/AppleScriptController.m: Removed.
3946         * DumpRenderTree/DumpRenderTree.h:
3947         * DumpRenderTree/DumpRenderTree.mm:
3948         (startJavaScriptThreads):
3949         (stopJavaScriptThreads):
3950         (activateAhemFont):
3951         (setDefaultColorProfileToRGB):
3952         (makeLargeMallocFailSilently):
3953         (dumpFrameScrollPosition):
3954         (dumpFramesAsText):
3955         (dump):
3956         (runTest):
3957         (-[DumpRenderTreeWindow isKeyWindow]):
3958         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3959         * DumpRenderTree/DumpRenderTreeDraggingInfo.h: Removed.
3960         * DumpRenderTree/DumpRenderTreeDraggingInfo.m: Removed.
3961         * DumpRenderTree/EditingDelegate.h: Removed.
3962         * DumpRenderTree/EditingDelegate.m: Removed.
3963         * DumpRenderTree/EventSendingController.h: Removed.
3964         * DumpRenderTree/EventSendingController.m: Removed.
3965         * DumpRenderTree/FrameLoadDelegate.h: Removed.
3966         * DumpRenderTree/FrameLoadDelegate.mm: Removed.
3967         * DumpRenderTree/GCController.mm: Removed.
3968         * DumpRenderTree/ImageDiff.m: Removed.
3969         * DumpRenderTree/LayoutTestController.cpp:
3970         (LayoutTestController::LayoutTestController):
3971         (dumpAsTextCallback):
3972         (dumpBackForwardListCallback):
3973         (dumpChildFramesAsTextCallback):
3974         (dumpChildFrameScrollPositionsCallback):
3975         (dumpDOMAsWebArchiveCallback):
3976         (dumpEditingCallbacksCallback):
3977         (dumpFrameLoadCallbacksCallback):
3978         (dumpResourceLoadCallbacksCallback):
3979         (dumpSelectionRectCallback):
3980         (dumpSourceAsWebArchiveCallback):
3981         (dumpTitleChangesCallback):
3982         (repaintSweepHorizontallyCallback):
3983         (setCallCloseOnWebViewsCallback):
3984         (setCanOpenWindowsCallback):
3985         (setCloseRemainingWindowsWhenCompleteCallback):
3986         (testRepaintCallback):
3987         (addFileToPasteboardOnDragCallback):
3988         (waitUntilDoneCallback):
3989         * DumpRenderTree/LayoutTestController.h:
3990         (LayoutTestController::dumpAsText):
3991         (LayoutTestController::setDumpAsText):
3992         (LayoutTestController::dumpBackForwardList):
3993         (LayoutTestController::setDumpBackForwardList):
3994         (LayoutTestController::dumpChildFrameScrollPositions):
3995         (LayoutTestController::setDumpChildFrameScrollPositions):
3996         (LayoutTestController::dumpChildFramesAsText):
3997         (LayoutTestController::setDumpChildFramesAsText):
3998         (LayoutTestController::dumpDOMAsWebArchive):
3999         (LayoutTestController::setDumpDOMAsWebArchive):
4000         (LayoutTestController::dumpSelectionRect):
4001         (LayoutTestController::setDumpSelectionRect):
4002         (LayoutTestController::dumpSourceAsWebArchive):
4003         (LayoutTestController::setDumpSourceAsWebArchive):
4004         (LayoutTestController::dumpTitleChanges):
4005         (LayoutTestController::setDumpTitleChanges):
4006         (LayoutTestController::dumpEditingCallbacks):
4007         (LayoutTestController::setDumpEditingCallbacks):
4008         (LayoutTestController::dumpResourceLoadCallbacks):
4009         (LayoutTestController::setDumpResourceLoadCallbacks):
4010         (LayoutTestController::dumpFrameLoadCallbacks):
4011         (LayoutTestController::setDumpFrameLoadCallbacks):
4012         (LayoutTestController::addFileToPasteboardOnDrag):
4013         (LayoutTestController::setAddFileToPasteboardOnDrag):
4014         (LayoutTestController::callCloseOnWebViews):
4015         (LayoutTestController::setCallCloseOnWebViews):
4016         (LayoutTestController::canOpenWindows):
4017         (LayoutTestController::setCanOpenWindows):
4018         (LayoutTestController::closeRemainingWindowsWhenComplete):
4019         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
4020         (LayoutTestController::testRepaint):
4021         (LayoutTestController::setTestRepaint):
4022         (LayoutTestController::testRepaintSweepHorizontally):
4023         (LayoutTestController::setTestRepaintSweepHorizontally):
4024         (LayoutTestController::waitToDump):
4025         (LayoutTestController::windowIsKey):
4026         * DumpRenderTree/LayoutTestControllerMac.mm: Removed.
4027         * DumpRenderTree/NavigationController.h: Removed.
4028         * DumpRenderTree/NavigationController.m: Removed.
4029         * DumpRenderTree/ObjCController.h: Removed.
4030         * DumpRenderTree/ObjCController.m: Removed.
4031         * DumpRenderTree/ObjCPlugin.h: Removed.
4032         * DumpRenderTree/ObjCPlugin.m: Removed.
4033         * DumpRenderTree/ObjCPluginFunction.h: Removed.
4034         * DumpRenderTree/ObjCPluginFunction.m: Removed.
4035         * DumpRenderTree/PolicyDelegate.h: Removed.
4036         * DumpRenderTree/PolicyDelegate.m: Removed.
4037         * DumpRenderTree/ResourceLoadDelegate.h: Removed.
4038         * DumpRenderTree/ResourceLoadDelegate.m: Removed.
4039         * DumpRenderTree/TextInputController.h: Removed.
4040         * DumpRenderTree/TextInputController.m: Removed.
4041         * DumpRenderTree/UIDelegate.h: Removed.
4042         * DumpRenderTree/UIDelegate.mm: Removed.
4043         * DumpRenderTree/WorkQueueItemMac.mm: Removed.
4044         * DumpRenderTree/mac: Added.
4045         * DumpRenderTree/mac/AppleScriptController.h: Copied from DumpRenderTree/AppleScriptController.h.
4046         * DumpRenderTree/mac/AppleScriptController.m: Copied from DumpRenderTree/AppleScriptController.m.
4047         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.h.
4048         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.m.
4049         * DumpRenderTree/mac/EditingDelegate.h: Copied from DumpRenderTree/EditingDelegate.h.
4050         * DumpRenderTree/mac/EditingDelegate.mm: Copied from DumpRenderTree/EditingDelegate.m.
4051         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
4052         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
4053         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
4054         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
4055         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
4056         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
4057         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
4058         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
4059         (-[EditingDelegate webViewDidBeginEditing:]):
4060         (-[EditingDelegate webViewDidChange:]):
4061         (-[EditingDelegate webViewDidEndEditing:]):
4062         (-[EditingDelegate webViewDidChangeTypingStyle:]):
4063         (-[EditingDelegate webViewDidChangeSelection:]):
4064         * DumpRenderTree/mac/EventSendingController.h: Copied from DumpRenderTree/EventSendingController.h.
4065         * DumpRenderTree/mac/EventSendingController.mm: Copied from DumpRenderTree/EventSendingController.m.
4066         * DumpRenderTree/mac/FrameLoadDelegate.h: Copied from DumpRenderTree/FrameLoadDelegate.h.
4067         * DumpRenderTree/mac/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.mm.
4068         (-[FrameLoadDelegate init]):
4069         (-[FrameLoadDelegate dealloc]):
4070         (-[FrameLoadDelegate processWork:]):
4071         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
4072         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
4073         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
4074         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
4075         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
4076         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
4077         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
4078         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
4079         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
4080         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
4081         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
4082         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
4083         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
4084         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
4085         (-[FrameLoadDelegate webView:willCloseFrame:]):
4086         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
4087         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
4088         * DumpRenderTree/mac/GCControllerMac.mm: Copied from DumpRenderTree/GCController.mm.
4089         * DumpRenderTree/mac/ImageDiff.m: Copied from DumpRenderTree/ImageDiff.m.
4090         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Copied from DumpRenderTree/LayoutTestControllerMac.mm.
4091         (LayoutTestController::notifyDone):
4092         (LayoutTestController::setWindowIsKey):
4093         (LayoutTestController::setWaitToDump):
4094         * DumpRenderTree/mac/NavigationController.h: Copied from DumpRenderTree/NavigationController.h.
4095         * DumpRenderTree/mac/NavigationController.m: Copied from DumpRenderTree/NavigationController.m.
4096         * DumpRenderTree/mac/ObjCController.h: Copied from DumpRenderTree/ObjCController.h.
4097         * DumpRenderTree/mac/ObjCController.m: Copied from DumpRenderTree/ObjCController.m.
4098         * DumpRenderTree/mac/ObjCPlugin.h: Copied from DumpRenderTree/ObjCPlugin.h.
4099         * DumpRenderTree/mac/ObjCPlugin.m: Copied from DumpRenderTree/ObjCPlugin.m.
4100         * DumpRenderTree/mac/ObjCPluginFunction.h: Copied from DumpRenderTree/ObjCPluginFunction.h.
4101         * DumpRenderTree/mac/ObjCPluginFunction.m: Copied from DumpRenderTree/ObjCPluginFunction.m.
4102         * DumpRenderTree/mac/PolicyDelegate.h: Copied from DumpRenderTree/PolicyDelegate.h.
4103         * DumpRenderTree/mac/PolicyDelegate.mm: Copied from DumpRenderTree/PolicyDelegate.m.
4104         * DumpRenderTree/mac/ResourceLoadDelegate.h: Copied from DumpRenderTree/ResourceLoadDelegate.h.
4105         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Copied from DumpRenderTree/ResourceLoadDelegate.m.
4106         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
4107         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
4108         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
4109         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
4110         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
4111         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
4112         * DumpRenderTree/mac/TextInputController.h: Copied from DumpRenderTree/TextInputController.h.
4113         * DumpRenderTree/mac/TextInputController.m: Copied from DumpRenderTree/TextInputController.m.
4114         * DumpRenderTree/mac/UIDelegate.h: Copied from DumpRenderTree/UIDelegate.h.
4115         * DumpRenderTree/mac/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.mm.
4116         (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
4117         (-[UIDelegate webViewFocus:]):
4118         (-[UIDelegate webView:createWebViewWithRequest:]):
4119         (-[UIDelegate webViewClose:]):
4120         * DumpRenderTree/mac/WorkQueueItemMac.mm: Copied from DumpRenderTree/WorkQueueItemMac.mm.
4121
4122 2007-09-14  Kevin McCullough  <kmccullough@apple.com>
4123
4124         Reviewed by Adam.
4125
4126         - Changing Win version of Drosera work with recent changes.
4127
4128         * Drosera/DebuggerDocument.cpp:
4129         * Drosera/DebuggerDocument.h:
4130         * Drosera/mac/DebuggerDocumentPlatform.mm:
4131         (NSStringCreateWithJSStringRef):
4132         (JSValueRefCreateWithNSString):
4133         * Drosera/win/DebuggerClient.cpp:
4134         (DebuggerClient::stepInto):
4135         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
4136
4137 2007-09-13  Kevin McCullough  <kmccullough@apple.com>
4138
4139         Reviewed by Tim.
4140
4141         - Moved isPaused into the JS for efficiency and simplicity.
4142
4143         * Drosera/DebuggerDocument.cpp:
4144         (DebuggerDocument::DebuggerDocument):
4145         (DebuggerDocument::pauseCallback):
4146         (DebuggerDocument::resumeCallback):
4147         (DebuggerDocument::isPaused):
4148         (DebuggerDocument::staticFunctions):
4149         * Drosera/DebuggerDocument.h:
4150         * Drosera/console.js:
4151         * Drosera/debugger.js:
4152         * Drosera/mac/DebuggerClient.mm:
4153         (-[DebuggerClient validateUserInterfaceItem:]):
4154
4155 2007-09-13  Sam Weinig  <sam@webkit.org>
4156
4157         Rubber stamped by Darin.
4158
4159         Make DumpRenderTree more cross platform ready.
4160         - Convert GCController to use the JSCore API instead of the WebScriptObject.
4161         - Use CF types instead of NS objects.
4162         - General cleanup.
4163
4164         * DumpRenderTree/DumpRenderTree.h:
4165         * DumpRenderTree/DumpRenderTree.mm:
4166         (dumpRenderTree):
4167         (dump):
4168         (runTest):
4169         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4170         * DumpRenderTree/EditingDelegate.m:
4171         * DumpRenderTree/FrameLoadDelegate.h:
4172         * DumpRenderTree/FrameLoadDelegate.mm:
4173         (-[FrameLoadDelegate init]):
4174         (-[FrameLoadDelegate dealloc]):
4175         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
4176         * DumpRenderTree/GCController.cpp: Added.
4177         (GCController::GCController):
4178         (GCController::~GCController):
4179         (collectCallback):
4180         (collectOnAlternateThreadCallback):
4181         (getJSObjectCountCallback):
4182         (GCController::makeWindowObject):
4183         (GCController::getJSClass):
4184         (GCController::staticFunctions):
4185         * DumpRenderTree/GCController.h:
4186         * DumpRenderTree/GCController.mm:
4187         (GCController::collect):
4188         (GCController::collectOnAlternateThread):
4189         (GCController::getJSObjectCount):
4190         * DumpRenderTree/LayoutTestController.cpp:
4191         (LayoutTestController::makeWindowObject):
4192         (LayoutTestController::getJSClass):
4193         * DumpRenderTree/LayoutTestController.h:
4194         * DumpRenderTree/LayoutTestControllerMac.mm:
4195         (LayoutTestController::addDisallowedURL):
4196         (waitUntilDoneWatchdogFired):
4197         (LayoutTestController::waitUntilDone):
4198         * DumpRenderTree/ResourceLoadDelegate.m:
4199         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
4200
4201 2007-09-12  Sam Weinig  <sam@webkit.org>
4202
4203         Reviewed by Stephanie.
4204
4205         Fix leaks in mac DumpRenderTree.
4206
4207         * DumpRenderTree/FrameLoadDelegate.mm:
4208         (-[FrameLoadDelegate init]): Initalize in the correct order.
4209         (-[FrameLoadDelegate processWork:]): Delete WorkQueueItem's after dequeueing them.
4210         * DumpRenderTree/LayoutTestController.cpp:
4211         (decodeHostNameCallback): Put return value in a temporary JSRetainPtr to ensure it gets released.
4212         (encodeHostNameCallback): ditto.
4213         * DumpRenderTree/LayoutTestController.h: