Reviewed by Kevin Ollivier.
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-10-15  Robin Dunn  <robin@alldunn.com>
2
3         Reviewed by Kevin Ollivier.
4
5         Add Mac package building scripts for wx.
6         
7         https://bugs.webkit.org/show_bug.cgi?id=30405
8
9         * wx/build/build_utils.py:
10         * wx/build/settings.py:
11         * wx/packaging/build-mac-installer.py: Added.
12
13 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
14
15         Reviewed by Gustavo Noronha.
16
17         Enable Web Sockets support when running layout tests.
18
19         * DumpRenderTree/gtk/DumpRenderTree.cpp:
20         (resetDefaultsToConsistentValues):
21
22 2009-10-15  Xan Lopez  <xlopez@igalia.com>
23
24         Reviewed by Gustavo Noronha.
25
26         Need to initialize event.button.button, since in most cases a
27         button number is not passed as an argument.
28
29         * DumpRenderTree/gtk/EventSender.cpp:
30         (mouseDownCallback):
31         (mouseUpCallback):
32
33 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
34
35         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
36         the OS if none was explicitly set.
37
38         * wx/build/settings.py:
39
40 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
41
42         Reviewed by Timothy Hatcher.
43
44         Web Inspector: enable developers extras within inspector layout tests.
45
46         https://bugs.webkit.org/show_bug.cgi?id=30014
47
48         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
49         (LayoutTestController::showWebInspector):
50         (LayoutTestController::closeWebInspector):
51         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
52         (LayoutTestController::showWebInspector):
53         (LayoutTestController::closeWebInspector):
54
55 2009-10-14  José Millán Soto  <jmillan@igalia.com>
56
57         Reviewed by Jan Alonzo.
58
59         GtkLauncher is using a deprecated signal
60         https://bugs.webkit.org/show_bug.cgi?id=30364
61
62         Modified GtkLauncher to use notify::title signal instead of
63         deprecated title-changed signal
64
65         * GtkLauncher/main.c:
66         (notify_title_cb):
67         (create_browser):
68
69 2009-10-14  Brady Eidson  <beidson@apple.com>
70
71         Reviewed by Sam Weinig.
72
73         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
74         1 - Disables WebHistory
75         2 - Doesn't make sense in that context anyway.
76
77         * DumpRenderTree/win/DumpRenderTree.cpp:
78         (createWebViewAndOffscreenWindow):
79
80 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
81
82         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
83         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
84
85         * wx/build/settings.py:
86         * wx/install-unix-extras:
87
88 2009-10-14  Brady Eidson  <beidson@apple.com>
89
90         Reviewed by Sam Weinig.
91
92         WebKit Win API should provide a delegate interface for global history.
93         https://bugs.webkit.org/show_bug.cgi?id=29905
94
95         * DumpRenderTree/LayoutTestController.cpp:
96         (LayoutTestController::LayoutTestController):
97         * DumpRenderTree/LayoutTestController.h:
98         (LayoutTestController::dumpHistoryDelegateCallbacks):
99         (LayoutTestController::setDumpHistoryDelegateCallbacks):
100                 
101         * DumpRenderTree/win/DumpRenderTree.cpp:
102         (shouldLogHistoryDelegates):
103         (runTest):
104         (createWebViewAndOffscreenWindow):
105         (main):
106         * DumpRenderTree/win/DumpRenderTree.vcproj:
107         
108         Add the IWebHistoryDelegate to DRT Windows:
109         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
110         (wstringFromBSTR):
111         (HistoryDelegate::HistoryDelegate):
112         (HistoryDelegate::~HistoryDelegate):
113         (HistoryDelegate::QueryInterface):
114         (HistoryDelegate::AddRef):
115         (HistoryDelegate::Release):
116         (HistoryDelegate::didNavigateWithNavigationData):
117         (HistoryDelegate::didPerformClientRedirectFromURL):
118         (HistoryDelegate::didPerformServerRedirectFromURL):
119         (HistoryDelegate::updateHistoryTitle):
120         (HistoryDelegate::populateVisitedLinksForWebView):
121         * DumpRenderTree/win/HistoryDelegate.h: Added.
122
123         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
124         (LayoutTestController::removeAllVisitedLinks):
125
126 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
127
128         Reviewed by Simon Hausmann.
129
130         [Qt] Implement support for setPOSIXLocale on Qt.
131         https://bugs.webkit.org/show_bug.cgi?id=30268 
132  
133         * DumpRenderTree/qt/DumpRenderTree.cpp:
134         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
135         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
136         (LayoutTestController::setPOSIXLocale):
137         * DumpRenderTree/qt/LayoutTestControllerQt.h:
138
139 2009-10-13  Stephanie Lewis  <slewis@apple.com>
140
141         Unreviewed, adding myself to reviewers list.
142
143         * Scripts/modules/committers.py:
144
145 2009-10-13  Stephanie Lewis  <slewis@apple.com>
146
147         Reviewed by Mark Rowe.
148
149         Fix null assignment so root tests work again.
150
151         * Scripts/webkitdirs.pm:
152
153 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
154
155         Reviewed by Simon Hausmann.
156
157         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
158         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
159         This is done in preparation of implementing missing features in DRT.
160         No functionality changes made yet.
161
162         * DumpRenderTree/qt/DumpRenderTree.cpp:
163         * DumpRenderTree/qt/DumpRenderTree.pro:
164         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
165         (EventSender::EventSender):
166         (EventSender::mouseDown):
167         (EventSender::mouseUp):
168         (EventSender::mouseMoveTo):
169         (EventSender::leapForward):
170         (EventSender::keyDown):
171         (EventSender::contextClick):
172         (EventSender::scheduleAsynchronousClick):
173         (EventSender::frameUnderMouse):
174         * DumpRenderTree/qt/EventSenderQt.h: Added.
175         (EventSender::clearKillRing):
176         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
177         (LayoutTestController::LayoutTestController):
178         (LayoutTestController::reset):
179         (LayoutTestController::processWork):
180         (LayoutTestController::maybeDump):
181         (LayoutTestController::waitUntilDone):
182         (LayoutTestController::notifyDone):
183         (LayoutTestController::windowCount):
184         (LayoutTestController::clearBackForwardList):
185         (LayoutTestController::dumpEditingCallbacks):
186         (LayoutTestController::dumpResourceLoadCallbacks):
187         (LayoutTestController::queueBackNavigation):
188         (LayoutTestController::queueForwardNavigation):
189         (LayoutTestController::queueLoad):
190         (LayoutTestController::queueReload):
191         (LayoutTestController::queueScript):
192         (LayoutTestController::provisionalLoad):
193         (LayoutTestController::timerEvent):
194         (LayoutTestController::encodeHostName):
195         (LayoutTestController::decodeHostName):
196         (LayoutTestController::setJavaScriptProfilingEnabled):
197         (LayoutTestController::setFixedContentsSize):
198         (LayoutTestController::setPrivateBrowsingEnabled):
199         (LayoutTestController::setPopupBlockingEnabled):
200         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
201         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
202         (LayoutTestController::numberOfActiveAnimations):
203         (LayoutTestController::disableImageLoading):
204         (LayoutTestController::dispatchPendingLoadRequests):
205         (LayoutTestController::setDatabaseQuota):
206         (LayoutTestController::clearAllDatabases):
207         (LayoutTestController::whiteListAccessFromOrigin):
208         (LayoutTestController::waitForPolicyDelegate):
209         (LayoutTestController::overridePreference):
210         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
211         (LayoutTestController::isLoading):
212         (LayoutTestController::setLoading):
213         (LayoutTestController::shouldDumpAsText):
214         (LayoutTestController::shouldDumpBackForwardList):
215         (LayoutTestController::shouldDumpChildrenAsText):
216         (LayoutTestController::shouldDumpDatabaseCallbacks):
217         (LayoutTestController::shouldDumpStatusCallbacks):
218         (LayoutTestController::shouldWaitUntilDone):
219         (LayoutTestController::canOpenWindows):
220         (LayoutTestController::shouldDumpTitleChanges):
221         (LayoutTestController::waitForPolicy):
222         (LayoutTestController::dumpAsText):
223         (LayoutTestController::dumpChildFramesAsText):
224         (LayoutTestController::dumpDatabaseCallbacks):
225         (LayoutTestController::dumpStatusCallbacks):
226         (LayoutTestController::setCanOpenWindows):
227         (LayoutTestController::dumpBackForwardList):
228         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
229         (LayoutTestController::display):
230         (LayoutTestController::dumpTitleChanges):
231         (LayoutTestController::dumpSelectionRect):
232         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
233         (TextInputController::TextInputController):
234         (TextInputController::doCommand):
235         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
236         * DumpRenderTree/qt/WorkQueue.cpp:
237         * DumpRenderTree/qt/WorkQueue.h:
238         * DumpRenderTree/qt/WorkQueueItem.h:
239         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
240         (findFrameNamed):
241         (LoadItem::invoke):
242         (ReloadItem::invoke):
243         (ScriptItem::invoke):
244         (BackForwardItem::invoke):
245         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
246         * DumpRenderTree/qt/jsobjects.h:
247
248 2009-10-13  Dmitry Titov  <dimich@chromium.org>
249
250         Not reviewed, adding myself to the list of reviewers.
251
252         * Scripts/modules/committers.py:
253
254 2009-10-13  Anders Carlsson  <andersca@apple.com>
255
256         Reviewed by Sam Weinig.
257
258         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
259
260         Make the private browsing mode testable by the test plug-in.
261         
262         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
263         (pluginGetProperty):
264         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
265         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
266         (NPP_New):
267         (NPP_SetValue):
268
269 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
270
271         No review, just adding self to the list of reviewers.
272
273         * Scripts/modules/committers.py:
274
275 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
276
277         Reviewed by Adam Roben.
278
279         Web Inspector: Use proper web view in inspector layout
280         tests for windows.
281
282         https://bugs.webkit.org/show_bug.cgi?id=30298
283
284         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
285         (LayoutTestController::showWebInspector):
286         (LayoutTestController::closeWebInspector):
287         (LayoutTestController::evaluateInWebInspector):
288
289 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
290
291         Reviewed by Sam Weinig.
292
293         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
294         https://bugs.webkit.org/show_bug.cgi?id=29841
295
296         * DumpRenderTree/mac/DumpRenderTree.mm:
297         (resetDefaultsToConsistentValues):
298         * DumpRenderTree/win/DumpRenderTree.cpp:
299         (resetDefaultsToConsistentValues):
300
301 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
302
303         Reviewed by Dimitri Glazkov.
304
305         Chromium Port - Windows
306         https://bugs.webkit.org/show_bug.cgi?id=29969
307
308         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
309         * Scripts/webkitdirs.pm:
310
311 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
312
313         Reviewed by Darin Adler.
314
315         jsc scripts cleanup and Qt/GTK fix
316         https://bugs.webkit.org/show_bug.cgi?id=30288
317
318         Duplicated jscPath() moved to webkitdirs.pm.
319         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
320         Configuration added (release/debug) to path for Qt-port on Windows.
321
322         * Scripts/run-javascriptcore-tests:
323         * Scripts/run-jsc:
324         * Scripts/run-sunspider:
325         * Scripts/sunspider-compare-results:
326         * Scripts/webkitdirs.pm:
327
328 2009-10-11  Adam Barth  <abarth@webkit.org>
329
330         Unreviewed.  Add Collin to committers.py.
331
332         * Scripts/modules/committers.py:
333
334 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
335
336         wx build fix, add bindings to source/include dirs now that there are sources there.
337
338         * wx/build/settings.py:
339
340 2009-10-09  Mark Rowe  <mrowe@apple.com>
341
342         Reviewed by Brady Eidson.
343
344         Enable plug-in halting in DumpRenderTree.
345
346         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
347         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
348
349         * DumpRenderTree/mac/DumpRenderTree.mm:
350         (resetDefaultsToConsistentValues):
351         * DumpRenderTree/mac/UIDelegate.mm:
352         (-[UIDelegate webView:shouldHaltPlugin:]):
353
354 2009-10-08  Brady Eidson  <beidson@apple.com>
355
356         Reviewed by Dan Bernstein.
357
358         Ask the History Delegate to populate the visited links hash.
359         <rdar://problem/7285293> and https://webkit.org/b/29904
360
361         Add the ability for LayoutTestController to clear all visited links.
362         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
363
364         * DumpRenderTree/LayoutTestController.cpp:
365         (LayoutTestController::LayoutTestController):
366         (removeAllVisitedLinksCallback):
367         (LayoutTestController::staticFunctions):
368         * DumpRenderTree/LayoutTestController.h:
369         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
370         (LayoutTestController::removeAllVisitedLinks):
371
372         * DumpRenderTree/mac/HistoryDelegate.mm:
373         (-[HistoryDelegate populateVisitedLinksForWebView:]):
374
375         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
376         (LayoutTestController::removeAllVisitedLinks):
377         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
378         (LayoutTestController::removeAllVisitedLinks):
379         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
380         (LayoutTestController::removeAllVisitedLinks):
381
382
383 2009-10-08  Daniel Bates  <dbates@webkit.org>
384
385         Reviewed by Adam Roben.
386
387         https://bugs.webkit.org/show_bug.cgi?id=30175
388         
389         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
390         the OLE drag-and-drop return value like the function it emulates. Currently, 
391         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
392         whether the drag-and-drop operation was successful or was cancelled.
393         
394         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
395         return value according to whether the drop operation was successful or not.
396
397         * DumpRenderTree/win/EventSender.cpp:
398         (doMouseUp): Added parameter oleDragAndDropReturnValue.
399         (replaySavedEvents): Ditto.
400         * DumpRenderTree/win/EventSender.h:
401         * DumpRenderTree/win/UIDelegate.cpp:
402         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
403
404 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
405
406         Reviewed by Xan Lopez.
407
408         [GTK] Added support for a parameter setting the button that was
409         pressed in the mouseDown function.
410         https://bugs.webkit.org/show_bug.cgi?id=30220
411
412         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
413
414 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
415
416         Reviewed by Xan Lopez.
417
418         [GTK] Added a line to the bottom of the expected result to match
419         the output of the test.
420         https://bugs.webkit.org/show_bug.cgi?id=30220
421
422         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
423         expected.txt:
424
425 2009-10-08  Adam Roben  <aroben@apple.com>
426
427         Use QueryInterface to get IWebInspectorPrivate
428
429         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
430         accessed in a more standard way
431
432         Reviewed by John Sullivan and Tim Hatcher.
433
434         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
435         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
436         by calling IWebViewPrivate::inspector, then use QueryInterface to get
437         to the IWebInspectorPrivate interface.
438
439 2009-10-07  Adam Roben  <aroben@apple.com>
440
441         Implement DRT support for origin whitelisting
442
443         Fixes <http://webkit.org/b/30185>.
444
445         Reviewed by Eric Seidel.
446
447         * DumpRenderTree/win/DumpRenderTree.cpp:
448         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
449         whitelist, to match Mac DRT.
450         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
451         (LayoutTestController::whiteListAccessFromOrigin): Call through to
452         IWebViewPrivate::whiteListAccessFromOrigin.
453
454 2009-10-07  Brady Eidson  <beidson@apple.com>
455
456         Reviewed by Darin Adler.
457
458         Send title changes to the global history delegate.
459         <rdar://problem/7285293> and https://webkit.org/b/29904
460
461         * DumpRenderTree/mac/HistoryDelegate.mm:
462         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
463
464 2009-10-07  Adam Barth  <abarth@webkit.org>
465
466         Unreviewed.  Remove some folks from committers.py who were listed on
467         the WebKit Team wiki page but who weren't actually listed as commit+.
468         At some point, we should coorelate this list with the committers
469         mailing list.
470
471         * Scripts/modules/committers.py:
472
473 2009-10-07  Adam Barth  <abarth@webkit.org>
474
475         Unreviewed.  Import a bunch of committers from the WebKit Team page on
476         the wiki into committers.py.
477
478         * Scripts/modules/committers.py:
479
480 2009-10-07  Adam Barth  <abarth@webkit.org>
481
482         Unreviewed.  Added Aaron Boodman to committers.py.
483
484         * Scripts/modules/committers.py:
485
486 2009-10-07  Evan Martin  <evan@chromium.org>
487
488         Reviewed by Darin Adler.
489
490         Add API to LayoutTestController for re/setting the system locale.
491         https://bugs.webkit.org/show_bug.cgi?id=18994
492
493         * DumpRenderTree/LayoutTestController.cpp:
494         (setLocaleCallback):
495         (LayoutTestController::staticFunctions):
496         (LayoutTestController::setLocale):
497         * DumpRenderTree/LayoutTestController.h:
498
499 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
500
501         Reviewed by Jan Alonzo.
502
503         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
504         https://bugs.webkit.org/show_bug.cgi?id=29689
505
506         Build fix by adding -lfontconfig for DumpRenderTree.
507
508         * GNUmakefile.am:
509
510 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
511
512         Reviewed by Simon Hausmann.
513
514         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
515
516         * Scripts/run-webkit-tests:
517
518 2009-10-07  Xan Lopez  <xlopez@igalia.com>
519
520         Reviewed by Gustavo Noronha.
521
522         "delete" in EventSender is the backspace key, not the delete one.
523
524         * DumpRenderTree/gtk/EventSender.cpp:
525         (keyDownCallback):
526
527 2009-10-07  Xan Lopez  <xlopez@igalia.com>
528
529         Reviewed by Gustavo Noronha.
530
531         getChildrenWithRange expects as last parameter the end index, not
532         the length of the range. Correct this and clarify the variable
533         names to reflect how the code works.
534
535         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
536         (AccessibilityUIElement::getChildrenWithRange):
537         (AccessibilityUIElement::getChildAtIndex):
538
539 2009-10-06  Mark Rowe  <mrowe@apple.com>
540
541         Reviewed by Simon Fraser.
542
543         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
544
545         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
546         the fact we have already changed the working directory to the top of the open source tree.
547
548 2009-10-06  Julie Parent  <jparent@chromium.org>
549
550         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
551         rather than my committer email.
552
553         * Scripts/modules/committers.py:
554
555 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
556
557         Reviewed by Eric Seidel.
558
559         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
560
561         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
562         it after each layout test as it should do, making the DRT dump additional output
563         for all of the subsequent layout tests.
564
565         * DumpRenderTree/qt/jsobjects.cpp:
566         (LayoutTestController::reset):
567
568 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
569
570         Reviewed by Simon Hausmann.
571
572         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
573         fast/dom/assign-to-window-status.html test, which is passing as a result.
574
575         https://bugs.webkit.org/show_bug.cgi?id=30127
576
577         * DumpRenderTree/qt/DumpRenderTree.cpp:
578         (WebCore::DumpRenderTree::DumpRenderTree):
579         (WebCore::DumpRenderTree::statusBarMessage):
580         * DumpRenderTree/qt/DumpRenderTree.h:
581         * DumpRenderTree/qt/jsobjects.h:
582         (LayoutTestController::shouldDumpStatusCallbacks):
583         (LayoutTestController::dumpStatusCallbacks):
584
585 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
586
587         Reviewed by Simon Hausmann.
588
589         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
590         ignores the argument indicating which mouse button to trigger.
591         https://bugs.webkit.org/show_bug.cgi?id=30048
592
593         This affects the fast/events/mouse-click-events.html layout test.
594
595         * DumpRenderTree/qt/jsobjects.cpp:
596         (EventSender::mouseDown):
597         (EventSender::mouseUp):
598         * DumpRenderTree/qt/jsobjects.h:
599
600 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
601
602         Reviewed by Simon Hausmann.
603
604         [Qt] Fix the EventSender::keyDown() implementation
605         https://bugs.webkit.org/show_bug.cgi?id=30043
606
607         It should post both a key press event and a key release event,
608         just like other ports do.
609
610         * DumpRenderTree/qt/jsobjects.cpp:
611         (EventSender::keyDown):
612
613 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
614
615         wx build fix. Add jpeg to the list of libs to link against.
616
617         * wx/build/settings.py:
618
619 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
620
621         Reviewed by Simon Hausmann.
622
623         [Qt] EventSender::keyDown() cannot send function-key events.
624         https://bugs.webkit.org/show_bug.cgi?id=30044
625
626         This affects the fast/events/keydown-function-keys.html layout test.
627
628         * DumpRenderTree/qt/jsobjects.cpp:
629         (EventSender::keyDown):
630
631 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
632
633         Added --wx-compiler-prefix waf option to allow building wxWebKit with
634         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
635
636         * wx/build/settings.py:
637         * wx/build/wxpresets.py:
638
639 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
640
641         Reviewed by Timothy Hatcher.
642
643         Web Inspector: add testing harness for Web Inspector.
644
645         https://bugs.webkit.org/show_bug.cgi?id=30010
646
647         * DumpRenderTree/LayoutTestController.cpp:
648         (showWebInspectorCallback):
649         (closeWebInspectorCallback):
650         (evaluateInWebInspectorCallback):
651         (LayoutTestController::staticFunctions):
652         * DumpRenderTree/LayoutTestController.h:
653         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
654         (LayoutTestController::showWebInspector):
655         (LayoutTestController::closeWebInspector):
656         (LayoutTestController::evaluateInWebInspector):
657         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
658         (LayoutTestController::showWebInspector):
659         (LayoutTestController::closeWebInspector):
660         (LayoutTestController::evaluateInWebInspector):
661         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
662         (LayoutTestController::showWebInspector):
663         (LayoutTestController::closeWebInspector):
664         (LayoutTestController::evaluateInWebInspector):
665         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
666         (LayoutTestController::showWebInspector):
667         (LayoutTestController::closeWebInspector):
668         (LayoutTestController::evaluateInWebInspector):
669
670 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
671
672         Reviewed by Ariyha Hidayat.
673
674         Pass arguments to system() as a string instead of array
675
676         When passed as an array entries with a space fail to translate
677         to two arguments to the child process, so instead of manually
678         splitting all the entries in @buildArgs we pass the whole thing
679         as a string instead.
680
681         * Scripts/webkitdirs.pm:
682
683 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
684
685         Reviewed by David Levin.
686
687         check-webkit-style misses whitespace errors for operators:
688         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
689         https://bugs.webkit.org/show_bug.cgi?id=30021
690
691         * Scripts/modules/cpp_style.py:
692         Added the operators mentioned above to the same list as == and !=.
693
694 2009-10-02  Julie Parent  <jparent@chromium.org>
695
696         Unreviewed.
697
698         Adding myself and Ojan Vafai as committers, because we are committers.
699
700         * Scripts/modules/committers.py:
701
702 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
703
704         Reviewed by Adam Roben.
705
706         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
707         this will help the patch merging process when TryBots are used.
708
709         * Scripts/svn-create-patch:
710
711 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
712
713         Reviewed by Simon Hausmann.
714
715         [Qt] Implement layoutTestController.overridePreference().
716         https://bugs.webkit.org/show_bug.cgi?id=29970
717
718         * DumpRenderTree/qt/DumpRenderTree.cpp:
719         (WebCore::WebPage::WebPage):
720         (WebCore::WebPage::resetSettings):
721         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
722         * DumpRenderTree/qt/jsobjects.cpp:
723         (LayoutTestController::reset):
724         (LayoutTestController::setPrivateBrowsingEnabled):
725         (LayoutTestController::setPopupBlockingEnabled):
726         (LayoutTestController::overridePreference):
727         * DumpRenderTree/qt/jsobjects.h:
728
729 2009-10-01  Chris Marrin  <cmarrin@apple.com>
730
731         Reviewed by Oliver Hunt.
732
733         Turn on ENABLE_3D_CANVAS in TOT
734         https://bugs.webkit.org/show_bug.cgi?id=29906
735
736         * Scripts/build-webkit:
737
738 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
739
740         Rubberstamped by Simon Hausmann.
741
742         Enable HTTP tests for Qt
743
744         * Scripts/run-webkit-tests:
745
746 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
747
748         Reviewed by Dimitri Glazkov.
749
750         build-webkit --chromium now also works on cygwin.
751
752         https://bugs.webkit.org/show_bug.cgi?id=29973
753
754         * Scripts/webkitdirs.pm:
755
756 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
757
758         Reviewed by Simon Hausmann.
759
760         [Qt] Don't use TCmalloc in DumpRenderTree
761         https://bugs.webkit.org/show_bug.cgi?id=27029
762
763         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
764
765         * DumpRenderTree/qt/DumpRenderTree.pro:
766
767 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
768
769         Reviewed by Simon Hausmann.
770
771         [Qt] Implement eventSender.scheduleAsynchronousClick().
772
773         https://bugs.webkit.org/show_bug.cgi?id=29931
774
775         * DumpRenderTree/qt/jsobjects.cpp:
776         (EventSender::scheduleAsynchronousClick):
777         * DumpRenderTree/qt/jsobjects.h:
778
779 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
780
781         Reviewed by Simon Hausmann.
782
783         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
784         fast/events/open-window-from-another-frame.html from the Skipped list.
785
786         https://bugs.webkit.org/show_bug.cgi?id=29930
787
788         * DumpRenderTree/qt/jsobjects.cpp:
789         (LayoutTestController::setPopupBlockingEnabled):
790         * DumpRenderTree/qt/jsobjects.h:
791
792 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
793
794         Unreviewed.
795
796         Added myself to the list of committers.
797
798         * Scripts/modules/committers.py:
799
800 2009-09-30  Eric Seidel  <eric@webkit.org>
801
802         No review, just adding Geoff to the list of reviewers.
803
804         * Scripts/modules/committers.py:
805
806 2009-09-30  Dan Bernstein  <mitz@apple.com>
807
808         Reviewed by Sam Weinig.
809
810         Added the WebKit Layout Tests fonts that are referenced in
811         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
812
813         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
814         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
815
816 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
817
818         Reviewed by David Kilzer.
819
820         Make sunspider scripts work on Windows platform.
821         https://bugs.webkit.org/show_bug.cgi?id=29656
822
823         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
824         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
825         * Scripts/webkitdirs.pm: currentPerlPath() added.
826
827 2009-09-29  Brady Eidson  <beidson@apple.com>
828
829         Rubberstamped by Dan Bernstein.
830
831         Fix license and some sorting in new files.
832
833         * DumpRenderTree/mac/HistoryDelegate.h:
834         * DumpRenderTree/mac/HistoryDelegate.mm:
835
836 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
837
838         Reviewed by David Kilzer.
839
840         Fixed how error codes are handled.
841         https://bugs.webkit.org/show_bug.cgi?id=29898
842
843         * Scripts/update-webkit:
844         * Scripts/update-webkit-chromium:
845
846 2009-09-29  Brady Eidson  <beidson@apple.com>
847
848         Reviewed by John Sullivan.
849
850         Updated way-out-of-date sorting throughout the dump methods/flags.
851
852         * DumpRenderTree/LayoutTestController.cpp:
853         (LayoutTestController::LayoutTestController):
854         (dumpAsPDFCallback):
855         (dumpAsTextCallback):
856         (dumpFrameLoadCallbacksCallback):
857         (dumpResourceLoadCallbacksCallback):
858         (LayoutTestController::staticFunctions):
859
860         * DumpRenderTree/LayoutTestController.h:
861         (LayoutTestController::dumpAsText):
862         (LayoutTestController::setDumpAsText):
863         (LayoutTestController::dumpFrameLoadCallbacks):
864         (LayoutTestController::setDumpFrameLoadCallbacks):
865         (LayoutTestController::dumpSelectionRect):
866         (LayoutTestController::setDumpSelectionRect):
867         (LayoutTestController::dumpSourceAsWebArchive):
868         (LayoutTestController::setDumpSourceAsWebArchive):
869         (LayoutTestController::dumpStatusCallbacks):
870         (LayoutTestController::setDumpStatusCallbacks):
871         (LayoutTestController::dumpTitleChanges):
872         (LayoutTestController::setDumpTitleChanges):
873         (LayoutTestController::dumpWillCacheResponse):
874         (LayoutTestController::setDumpWillCacheResponse):
875
876 2009-09-29  Brady Eidson  <beidson@apple.com>
877
878         Reviewed by John Sullivan.
879
880         WebKit Mac API should provide a delegate interface for global history.
881         <rdar://problem/7042773> and https://webkit.org/b/29904
882
883         Adding the dumping of global history delegate callbacks.
884
885         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
886
887         Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
888         * DumpRenderTree/mac/DumpRenderTree.mm:
889         (createWebViewAndOffscreenWindow):
890         (allocateGlobalControllers):
891         (shouldLogFrameLoadDelegates):
892         (shouldLogHistoryDelegates):
893         (runTest):
894
895         Dump history delegate callbacks:
896         * DumpRenderTree/mac/HistoryDelegate.h: Added.
897         * DumpRenderTree/mac/HistoryDelegate.mm: Added.
898         (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
899         (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
900         (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
901
902 2009-09-29  Daniel Bates  <dbates@webkit.org>
903
904         Reviewed by Adam Roben.
905
906         https://bugs.webkit.org/show_bug.cgi?id=28902
907         
908         Fixes an issue where the drop effect returned by Window Dump Render Tree 
909         was always DROPEFFECT_NONE (since it was hard coded to do so).
910         
911         This patch corrects this issue by determining the actual drop effect 
912         performed by the corresponding drag-and-drop operation so that we can 
913         return it.
914
915         * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
916         (DraggingInfo::DraggingInfo):
917         (DraggingInfo::performedDropEffect): Added method.
918         (DraggingInfo::setPerformedDropEffect): Added method.
919         * DumpRenderTree/win/EventSender.cpp:
920         (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
921         Moved delete draggingInfo to UIDelegate::doDragDrop.
922         * DumpRenderTree/win/UIDelegate.cpp:
923         (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
924
925 2009-09-29  Dan Bernstein  <mitz@apple.com>
926
927         Reviewed by Adam Roben.
928
929         Remove copying of unnecessary or nonexistent files from the ImageDiff
930         post-build event.
931
932         * DumpRenderTree/win/ImageDiff.vcproj:
933
934 2009-09-29  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
935
936         Reviewed by David Kilzer.
937
938         [Qt] Make build-webkit script work on Windows
939         https://bugs.webkit.org/show_bug.cgi?id=29802
940
941         * Scripts/run-webkit-tests:
942         * Scripts/webkitdirs.pm:
943          - Removed unnecessary -p switch for mkdir on Windows.
944          - Use canonical path, which uses slashes or backslashes depends on platform.
945          - isWindows() only test for Windows and not for Cyqwin.
946
947 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
948
949         Reviewed by Simon Hausmann.
950
951         Fix time measurement in build-webkit after refactoring done in r48853.
952
953         * Scripts/build-webkit:
954
955 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
956
957         Reviewed by Tor Arne Vestbø.
958
959         [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.
960         This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.
961
962         * DumpRenderTree/qt/DumpRenderTree.cpp:
963         (WebCore::WebPage::WebPage):
964
965 2009-09-29  Jakub Wieczorek  <faw217@gmail.com>
966
967         Reviewed by Simon Hausmann.
968
969         [Qt] Implement eventSender.contextClick().
970         https://bugs.webkit.org/show_bug.cgi?id=29821
971
972         * DumpRenderTree/qt/jsobjects.cpp:
973         (EventSender::contextClick):
974         * DumpRenderTree/qt/jsobjects.h:
975
976 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
977
978         Reviewed by Eric Seidel.
979
980         Add experimentalWebSocketsEnabled in WebPreferences.
981         https://bugs.webkit.org/show_bug.cgi?id=28941
982
983         * DumpRenderTree/mac/DumpRenderTree.mm:
984         (resetDefaultsToConsistentValues):
985         * DumpRenderTree/win/DumpRenderTree.cpp:
986         (resetDefaultsToConsistentValues):
987
988 2009-09-28  Yaar Schnitman  <yaar@chromium.org>
989
990         Reviewed by David Kilzer.
991
992         Integrated chromium port building into webkit tools update-webkit and
993         build-webkit.
994
995         https://bugs.webkit.org/show_bug.cgi?id=29749
996
997         * Scripts/build-webkit: When --chromium is specified, will build
998           the chromium port (currently only Mac is supported).
999         * Scripts/update-webkit: When --chromium is specified, delegates to
1000           update-webkit-chromium.
1001         * Scripts/webkitdirs.pm: Added chromium specific defs.
1002         * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch
1003           chromium port's dependencies and update its project files.
1004
1005 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
1006
1007         Unreviewed.
1008
1009         Add myself to list of committers.
1010
1011         * Scripts/modules/committers.py:
1012
1013 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
1014
1015         Reviewed by Darin Adler.
1016
1017         run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
1018         https://bugs.webkit.org/show_bug.cgi?id=29771
1019
1020         * Scripts/run-webkit-tests:
1021
1022 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
1023
1024         Reviewed by Simon Hausmann.
1025
1026         [Qt] Implement layoutTestController.waitForPolicyDelegate.
1027         https://bugs.webkit.org/show_bug.cgi?id=25037
1028
1029         * DumpRenderTree/qt/DumpRenderTree.cpp:
1030         (WebCore::WebPage::acceptNavigationRequest):
1031         * DumpRenderTree/qt/DumpRenderTree.pro:
1032         * DumpRenderTree/qt/jsobjects.cpp:
1033         (LayoutTestController::reset):
1034         (LayoutTestController::notifyDone):
1035         (LayoutTestController::waitForPolicyDelegate):
1036         * DumpRenderTree/qt/jsobjects.h:
1037         (LayoutTestController::waitForPolicy):
1038
1039 2009-09-26  David Kilzer  <ddkilzer@apple.com>
1040
1041         <http://webkit.org/b/29764> mark-bug-fixed: add -o|--open switch
1042
1043         Reviewed by Eric Seidel.
1044
1045         The -o|--open switch uses the open(1) command on Mac OS X to
1046         open the bug URL in the default web browser.  If there are
1047         similar mechanisms on other platforms, they may be added later.
1048
1049         * Scripts/mark-bug-fixed:
1050         (MarkBugFixed.__init__): Added -o|--open switch to list of parse
1051         options.
1052         (MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
1053         code into main() and extracted prompting code into
1054         _prompt_user_for_correctness().
1055         (MarkBugFixed._open_bug_in_web_browser): Added.
1056         (MarkBugFixed._prompt_user_for_correctness): Added.
1057         (MarkBugFixed.main): Added logging code from
1058         _determine_bug_id_and_svn_revision().  Added code to call
1059         _open_bug_in_web_browser() if the switch is set.  Added code to
1060         call _prompt_user_for_correctness() when needed.
1061         * Scripts/modules/bugzilla.py:
1062         (Bugzilla.short_bug_url_for_bug_id): Added.
1063
1064 2009-09-26  David Kilzer  <ddkilzer@apple.com>
1065
1066         svn-unapply and svn-apply don't work when used outside multiple svn working directories
1067
1068         <http://webkit.org/b/29744>
1069         <rdar://problem/7252905>
1070
1071         Reviewed by Eric Seidel.
1072
1073         Some users have a workflow where svn-create-patch, svn-apply and
1074         svn-unapply are used outside of multiple svn working
1075         directories.  Instead of aborting the scripts in these cases,
1076         print a warning and assume that Subversion is being used.
1077
1078         * Scripts/VCSUtils.pm:
1079         (determineVCSRoot): Call warn() instead of die() if both isGit()
1080         and isSVN() initially return false.  Set $VCSUtils::isSVN to 1
1081         to enforce the assumption about Subversion, then return
1082         determineSVNRoot().
1083         * Scripts/svn-apply: Switch to using isGit() and isSVN() from
1084         VCSUtils.pm.  They both already cache their values and checking
1085         here is redundant since determineVCSRoot() is called later.
1086
1087 2009-09-26  Zan Dobersek  <zandobersek@gmail.com>
1088
1089         Reviewed by Gustavo Noronha.
1090
1091         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
1092         https://bugs.webkit.org/show_bug.cgi?id=29689
1093
1094         Load test fonts through FontConfig before each test.
1095         This ensures a more proper rendering of the tests.
1096
1097         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1098         (initializeFonts):
1099         (runTest):
1100         (main):
1101         * DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf.
1102         * GNUmakefile.am:
1103
1104 2009-09-25  David Kilzer  <ddkilzer@apple.com>
1105
1106         <http://webkit.org/b/29718> mark-bug-fixed: add -u|--update-only switch
1107
1108         Reviewed by Eric Seidel.
1109
1110         * Scripts/mark-bug-fixed:
1111         (MarkBugFixed.__init__): Added -u|--update-only switch to list
1112         of parse options.
1113         (MarkBugFixed.main): When -u|--update-only is specified, add a
1114         comment to the bug without marking it Resolved/Fixed.
1115
1116 2009-09-25  Darin Adler  <darin@apple.com>
1117
1118         Reviewed by Geoffrey Garen.
1119
1120         * Scripts/prepare-ChangeLog: Leave files from the script-tests directory
1121         out, just as we do for the resources directory.
1122
1123 2009-09-25  Adam Barth  <abarth@webkit.org>
1124
1125         Unreviewed.  Added Tony to committers.py because he's a
1126         committer now.
1127
1128         * Scripts/modules/committers.py:
1129
1130 2009-09-25  Eric Seidel  <eric@webkit.org>
1131
1132         Reviewed by Simon Fraser.
1133
1134         REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
1135         https://bugs.webkit.org/show_bug.cgi?id=28624
1136
1137         Disable hardware compositing on Leopard for versions of QuickTime 7.6.4 and older.
1138
1139         * DumpRenderTree/mac/DumpRenderTree.mm:
1140         (resetDefaultsToConsistentValues):
1141
1142 2009-09-25  Eric Seidel  <eric@webkit.org>
1143
1144         Reviewed by Adam Barth.
1145
1146         commit-queue should auto-retry patches which fail to commit due to out of date files
1147         https://bugs.webkit.org/show_bug.cgi?id=28316
1148
1149         * Scripts/bugzilla-tool:
1150          - Handle new CheckoutNeedsUpdate exception.
1151         * Scripts/modules/logging_unittest.py:
1152          - Call the ScriptError constructor correctly (this test had regressed).
1153         * Scripts/modules/scm.py:
1154          - Added the ability to define custom error handlers for run_command
1155            and added a commit_error_handler which throws CheckoutNeedsUpdate
1156            instead of ScriptError.
1157          - Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible.
1158         * Scripts/modules/scm_unittest.py:
1159          - Added tests of new error handlers.
1160
1161 2009-09-25  Eric Seidel  <eric@webkit.org>
1162
1163         Reviewed by Adam Barth.
1164
1165         commit-queue should give better feedback when failing a patch
1166         https://bugs.webkit.org/show_bug.cgi?id=29316
1167
1168         * Scripts/bugzilla-tool:
1169          - Update ScriptError uses to the new constructor format.
1170          - Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output
1171            so that we can print to both stdout as well as an output buffer for error reporting.
1172          - Update run_and_throw_if_fail to use teed output so that it can report the "output" as part of ScriptError.
1173          - Use e.message_with_output() when failing a patch (this is the real fix here).
1174            I also removed use of "This patch will require manual commit." as that's not always true.
1175          - Add missing word "bug" from log message.
1176         * Scripts/modules/scm.py:
1177          - Make ScriptError save a bunch more data so that error messages can be nicer.
1178          - Update ScriptError callers.
1179
1180 2009-09-24  John Gregg  <johnnyg@google.com>
1181
1182         Reviewed by Eric Seidel.
1183
1184         Enable switch for notifications (experimental) in Page Settings
1185         https://bugs.webkit.org/show_bug.cgi?id=28930
1186
1187         Now that desktop notifications are controlled by run-time switch,
1188         set that switch to true for DumpRenderTree.
1189
1190         * DumpRenderTree/mac/DumpRenderTree.mm:
1191         (resetDefaultsToConsistentValues):
1192         * DumpRenderTree/win/DumpRenderTree.cpp:
1193         (resetDefaultsToConsistentValues):
1194         * DumpRenderTree/win/UIDelegate.cpp:
1195         (UIDelegate::QueryInterface):
1196
1197 2009-09-24  Kevin Ollivier  <kevino@theolliviers.com>
1198
1199         wx build fix. SnowLeopard fixes for Mac dependencies.
1200
1201         * wx/build/build_utils.py:
1202         * wx/build/settings.py:
1203         * wx/install-unix-extras:
1204
1205 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1206
1207         Reviewed by Oliver Hunt.
1208
1209         Add support for DRT to send mouse wheel events.
1210
1211         https://bugs.webkit.org/show_bug.cgi?id=29348
1212         [Gtk] Scrollwheel on horizontal scrollbars should slide horizontally
1213
1214         * DumpRenderTree/gtk/EventSender.cpp:
1215         (mouseWheelToCallback):
1216
1217 2009-09-17  Eric Seidel  <eric@webkit.org>
1218
1219         Reviewed by David Levin.
1220
1221         commit-queue needs web-based status reporting
1222         https://bugs.webkit.org/show_bug.cgi?id=29307
1223
1224         Add a first-pass web-based status for the commit-queue.
1225         The bot is currently reachable at:
1226         http://webkit-commit-queue.appspot.com/
1227
1228         * CommitQueueStatus/app.yaml: Added.
1229          - Application description file required by App Engine.
1230         * CommitQueueStatus/filters/__init__.py: Added.
1231          - Required by python to treat 'filters' as a module.
1232         * CommitQueueStatus/filters/webkit_extras.py: Added.
1233          - Support for turning 'bug 123' and 'patch 123' into links.
1234            This lets us use plain text strings in our logs yet display nice HTML (help prevent XSS attacks on the page).
1235         * CommitQueueStatus/index.html: Added.
1236         * CommitQueueStatus/index.yaml: Added.
1237          - Some auto-generated file from app engine.
1238         * CommitQueueStatus/queue_status.py: Added.
1239          - The core logic of this bot.  We could eventually split this file out into pieces.
1240         * CommitQueueStatus/stylesheets/main.css: Added.
1241          - Some basic lame-o CSS to make the page look less awful.
1242         * CommitQueueStatus/update_status.html: Added.
1243          - The form that the commit-queue (or a human) can use to update the status.
1244         * Scripts/bugzilla-tool:
1245          - Add some very basic update_status calls.
1246         * Scripts/modules/statusbot.py: Added.
1247          - Knows how to post to the CommitQueueStatus web application.
1248
1249 2009-09-24  David Kilzer  <ddkilzer@apple.com>
1250
1251         <http://webkit.org/b/29712> mark-bug-fixed: add -m|--comment switch
1252
1253         Reviewed by Adam Roben.
1254
1255         * Scripts/mark-bug-fixed:
1256         (MarkBugFixed.__init__): Added -m|--comment switch to list of
1257         parse options.
1258         (MarkBugFixed.main): When specified, prepend comment from
1259         -m|--comment command-line switch to the bug comment.
1260
1261 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1262
1263         Reviewed by Jan Alonzo.
1264
1265         [GTK] DRT must display window instead of just realizing, to enable synthesizing events correctly
1266         https://bugs.webkit.org/show_bug.cgi?id=29693
1267
1268         Show the window, to be able to synthesize events correctly.
1269
1270         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1271         (runTest):
1272         (main):
1273
1274 2009-09-24  Oliver Hunt  <oliver@apple.com>
1275
1276         Reviewed by NOBODY(rollout)
1277
1278         Roll out r48712 as it is incorrect.
1279
1280         * DumpRenderTree/mac/ObjCController.m:
1281         (+[ObjCController isSelectorExcludedFromWebScript:]):
1282         (+[ObjCController webScriptNameForSelector:]):
1283
1284 2009-09-24  Benjamin Poulain  <benjamin.poulain@nokia.com>
1285
1286         Reviewed by Eric Seidel.
1287
1288         https://bugs.webkit.org/show_bug.cgi?id=29005
1289         The indices of RuntimeArray should be enumerated like for a regular array.
1290
1291         * DumpRenderTree/mac/ObjCController.m:
1292         (+[ObjCController isSelectorExcludedFromWebScript:]):
1293         (+[ObjCController webScriptNameForSelector:]):
1294         (-[ObjCController arrayOfString]):
1295
1296 2009-09-23  David Kilzer  <ddkilzer@apple.com>
1297
1298         <http://webkit.org/b/28910> Move bugzilla-tool mark-fixed to standalone mark-bug-fixed tool
1299
1300         Reviewed by Darin Adler.
1301
1302         Also fixed a bug where specifying a revision on the command-line
1303         as 'r12345' would fail.  See <http://webkit.org/b/29699>.
1304
1305         * Scripts/bugzilla-tool: Updated module import statements.
1306         (parse_bug_id): Removed.  Moved to bugzilla.py.
1307         (bug_comment_from_svn_revision): Removed.  Moved to comments.py.
1308         (bug_comment_from_commit_text): Removed.  Moved to comments.py.
1309         (MarkBugFixed): Removed.  Code moved to mark-bug-fixed.
1310         (BugzillaTool.__init__): Removed mark-fixed subcommand.
1311         * Scripts/mark-bug-fixed: Added.
1312         * Scripts/modules/bugzilla.py:
1313         (parse_bug_id): Added.  Moved from bugzilla-tool.
1314         * Scripts/modules/comments.py: Added.
1315         (bug_comment_from_svn_revision): Added.  Moved from bugzilla-tool.
1316         (bug_comment_from_commit_text): Added.  Moved from bugzilla-tool.
1317
1318 2009-09-23  Marshall Culpepper  <mculpepper@appcelerator.com>
1319
1320         Reviewed by Eric Seidel.
1321         
1322          jpeg.lib is now libjpeg.lib in DRT Cairo dependencies. return
1323          "false" in non-implemented stub for setAlwaysAcceptCookies.
1324          https://bugs.webkit.org/show_bug.cgi?id=29661
1325
1326         * DumpRenderTree/win/DumpRenderTree.vcproj:
1327         * DumpRenderTree/win/DumpRenderTree.cpp:
1328
1329 2009-09-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1330
1331         Reviewed by Xan Lopez.
1332
1333         [GTK] need to dump number of pending unload handlers
1334         https://bugs.webkit.org/show_bug.cgi?id=29685
1335
1336         Implement dumping of the number of pending unload handlers.
1337
1338         The following tests will pass:
1339
1340           fast/loader/unload-form-about-blank.html
1341           fast/loader/unload-form-post-about-blank.html
1342           fast/loader/unload-form-post.html
1343           fast/loader/unload-form.html
1344           fast/loader/unload-hyperlink.html
1345           fast/loader/unload-javascript-url.html
1346           fast/loader/unload-reload.html
1347           fast/loader/unload-window-location.html
1348
1349         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1350         (getFrameNameSuitableForTestResult):
1351         (webViewLoadFinished):
1352
1353 2009-09-22  Shinichiro Hamaji  <hamaji@chromium.org>
1354
1355         Reviewed by Eric Seidel.
1356
1357         js tests should move into jstests subdirectory instead of resources/
1358         https://bugs.webkit.org/show_bug.cgi?id=25880
1359
1360         Remove support of resources directory.
1361
1362         * Scripts/make-script-test-wrappers:
1363
1364 2009-09-22  Eric Seidel  <eric@webkit.org>
1365
1366         No review, only fixing typo (missing space character).
1367
1368         Fix typo from https://bugs.webkit.org/show_bug.cgi?id=29220
1369
1370         * Scripts/run-webkit-tests:
1371
1372 2009-09-22  Eric Seidel  <eric@webkit.org>
1373
1374         Reviewed by Darin Adler.
1375
1376         run-webkit-tests needs a --repeat-each=N option (AAABBBCCC instead of ABCABCABC)
1377         https://bugs.webkit.org/show_bug.cgi?id=29220
1378
1379         * Scripts/run-webkit-tests:
1380
1381 2009-09-22  Eric Seidel  <eric@webkit.org>
1382
1383         Reviewed by David Kilzer.
1384
1385         svn-apply can't handle single-line binary file additions
1386         https://bugs.webkit.org/show_bug.cgi?id=29100
1387
1388         Fixed the regexp and added a unit test.
1389
1390         * Scripts/modules/scm_unittest.py:
1391         * Scripts/svn-apply:
1392
1393 2009-09-11  Eric Seidel  <eric@webkit.org>
1394
1395         Reviewed by David Kilzer.
1396
1397         post-diff and post-commits should be able to find bug urls in ChangeLogs.
1398         https://bugs.webkit.org/show_bug.cgi?id=29206
1399
1400         * Scripts/bugzilla-tool:
1401          - Share common options by adding a PostDiffAsPatchToBug.posting_options() method.
1402          - Rename --no-comment to --add-log-as-comment and reverse behavior.
1403            Comments tend to just be noise.  I'll eventually remove this argument if no one uses it.
1404          - Split out code into helper functions to try and make execute() more legible.
1405          - Make post-diff find the bug url in the ChangeLogs if not passed as an argument.
1406          - Fallback to bug urls in commit diffs, instead of just in commit messages,
1407            meaning post-commits will now find bug urls in ChangeLogs.
1408
1409 2009-09-21  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
1410
1411         Reviewed by Maciej Stachowiak.
1412
1413         --parse-only parameter wasn't passed to SunSpider/sunspider script.
1414         https://bugs.webkit.org/show_bug.cgi?id=29611
1415
1416         * Scripts/run-sunspider: Missing parameter passing added.
1417
1418 2009-09-20  David Kilzer  <ddkilzer@apple.com>
1419
1420         <http://webkit.org/b/29521> run-webkit-tests: use require instead eval to load DumpRenderTreeSupport module
1421
1422         Reviewed by Mark Rowe.
1423
1424         The require statement is like the use statement, except that it
1425         is run during script execution instead of during the 'BEGIN'
1426         phase.  This makes it possible to change @INC before the require
1427         statement is run.  See 'require' and 'use' in the perlfunc(1)
1428         manpage and 'BEGIN' in perlmod(1) manpage.
1429
1430         * Scripts/run-webkit-tests: Replace eval statement with require
1431         statement.
1432
1433 2009-09-18  Kevin Ollivier  <kevino@theolliviers.com>
1434
1435         wx build fixes. Fix the config name under git and allow users to specify
1436         their own waf install for experimenting with new versions.
1437
1438         * Scripts/webkitdirs.pm:
1439         * wx/build/settings.py:
1440
1441 2009-09-18  Alex Milowski  <alex@milowski.com>
1442
1443         Reviewed by Maciej Stachowiak.
1444
1445         Added checkWebCoreMathMLSupport and hasMathMLSupport to support 
1446         checking for whether MathML tests should be run
1447
1448         * Scripts/run-webkit-tests:
1449         * Scripts/webkitdirs.pm:
1450
1451 2009-08-28  Darin Adler  <darin@apple.com>
1452
1453         Reviewed by Mark Rowe.
1454
1455         Break more of run-webkit-tests into separate functions
1456         https://bugs.webkit.org/show_bug.cgi?id=29497
1457
1458         Some small steps toward improving run-webkit-tests. My goal is to
1459         refactor much more of the script into functions. Later we can add
1460         parallel test running to the tool. But better structure may help
1461         even if someone decides to translate this into another scripting
1462         language instead.
1463
1464         * Scripts/run-webkit-tests: Break more pieces of the script into
1465         seprate functions. Added readSkippedFiles, findTestsToRun, and
1466         printResults functions. Removed custom code to skip results.html
1467         and instead just put it into the ignoredFiles hash. Fixed some
1468         indentation. Sorted function declarations, global variables,
1469         and options at the top of the file alphabetically so they're not
1470         in a semi-random order.
1471
1472 2009-09-17  Kevin Ollivier  <kevino@theolliviers.com>
1473
1474         wx build fix, add missing dependency.
1475
1476         * wx/browser/wscript:
1477
1478 2009-09-16  Mark Rowe  <mrowe@apple.com>
1479
1480         Split the SnowLeopard build across a few machines.
1481
1482         * BuildSlaveSupport/build.webkit.org-config/config.json:
1483
1484 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
1485
1486         wx build fix to support monolithic builds on Windows.
1487
1488         * wx/build/wxpresets.py:
1489
1490 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
1491
1492         wx build fix, improve debug support and 2.9 support on MSW.
1493
1494         * wx/build/settings.py:
1495         * wx/build/wxpresets.py:
1496
1497 2009-09-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1498
1499         Blind try at fixing new test failure on Windows.
1500
1501         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1502         (FrameLoadDelegate::didReceiveTitle):
1503
1504 2009-09-15  Alex Milowski  <alex@milowski.com>
1505
1506         Reviewed by Tor Arne Vestbø.
1507
1508         Added mathml toggle
1509
1510         * Scripts/build-webkit:
1511
1512 2009-09-15  Kevin Ollivier  <kevino@theolliviers.com>
1513
1514         wx build fix. Allow waf build to support Python < 2.6.
1515
1516         * wx/build/waf_extensions.py:
1517
1518 2009-09-14  Chris Marrin  <cmarrin@apple.com>
1519
1520         Reviewed by Oliver Hunt.
1521
1522         Add LayoutTests infrastructure to enable and disable webgl tests.
1523         https://bugs.webkit.org/show_bug.cgi?id=29254
1524
1525         * Scripts/run-webkit-tests:
1526         * Scripts/webkitdirs.pm:
1527
1528 2009-09-14  Simon Fraser  <simon.fraser@apple.com>
1529
1530         Reviewed by Darin Adler.
1531         
1532         Add --iterations option to run-webkit-tests to repeat the tests N times
1533         https://bugs.webkit.org/show_bug.cgi?id=29263
1534
1535         When run with --iterations N, run-webkit-tests will repeat the tests N times.
1536
1537         * Scripts/run-webkit-tests:
1538
1539 2009-09-14  Brady Eidson  <beidson@apple.com>
1540
1541         Not reviewed, maybe should've been:
1542
1543         Cleaning up more Windows-specific fallout from the fix for:
1544         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
1545
1546         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1547         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):  Correct printf() formatter, 
1548           and call the correct method to get the Sender.
1549
1550 2009-09-14  Jon Honeycutt  <jhoneycutt@apple.com>
1551
1552         GTK build fix.
1553
1554         Unreviewed.
1555
1556         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1557         (AccessibilityController::setLogScrollingStartEvents):
1558
1559 2009-09-11  Jon Honeycutt  <jhoneycutt@apple.com>
1560
1561         DRT/test part of
1562         <rdar://problem/7197644> WebKit should broadcast an MSAA event when
1563         jumping to a named anchor
1564
1565         https://bugs.webkit.org/show_bug.cgi?id=28899
1566
1567         Reviewed by Adam Roben.
1568
1569         * DumpRenderTree/AccessibilityController.cpp:
1570         (logScrollingStartEventsCallback):
1571         Turn on logging of scrolling start events.
1572         (AccessibilityController::getJSClass):
1573         Add a "logScrollingStartEvents" to the AccessibilityController's JS
1574         class definition.
1575         (AccessibilityController::resetToConsistentState):
1576         Turn off logging of scrolling start events.
1577
1578         * DumpRenderTree/AccessibilityController.h:
1579         Declare setLogScrollingStartEvents(). Add a member for the scrolling
1580         start event hook.
1581
1582         * DumpRenderTree/mac/AccessibilityControllerMac.cpp:
1583         (AccessibilityController::setLogScrollingStartEvents):
1584         Stubbed.
1585
1586         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1587         (AccessibilityController::AccessibilityController):
1588         Initialize the handle to 0.
1589         (logEventProc):
1590         Renamed from logFocusEventProc; now logs scrolling start events, too.
1591         Removed the assertion that the event is a focus event. Added a switch
1592         to print a message for focus, scrolling start, and other, unknown
1593         events.
1594         (AccessibilityController::setLogFocusEvents):
1595         Changed to use logEventProc.
1596         (AccessibilityController::setLogScrollingStartEvents):
1597         If turning logging off, unhook the scrolling start event hook, and clear
1598         the member holding the handle. If turning on, query for the root
1599         accessible, so that accessibility is enabled for the WebView, and call
1600         SetWinEventHook to setup an event hook using logEventProc as the
1601         callback function.
1602
1603 2009-09-14  Brady Eidson  <beidson@apple.com>
1604
1605         Windows build fix.
1606
1607         * DumpRenderTree/LayoutTestController.cpp:
1608         (setAuthenticationPasswordCallback):
1609         (setAuthenticationUsernameCallback):
1610         
1611         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1612         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1613
1614 2009-09-14  Brady Eidson  <beidson@apple.com>
1615
1616         Reviewed by Alexey Proskuryakov.
1617
1618         Safari 4 cannot be used to update firmware on Linksys routers.
1619         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
1620
1621         Add the ability for DRT to handle authentication challenges.
1622
1623         * DumpRenderTree/LayoutTestController.cpp:
1624         (setAuthenticationPasswordCallback):
1625         (setAuthenticationUsernameCallback):
1626         (setHandlesAuthenticationChallengesCallback):
1627         (LayoutTestController::staticFunctions):
1628
1629         * DumpRenderTree/LayoutTestController.h:
1630         (LayoutTestController::handlesAuthenticationChallenges):
1631         (LayoutTestController::setHandlesAuthenticationChallenges):
1632         (LayoutTestController::authenticationUsername):
1633         (LayoutTestController::setAuthenticationUsername):
1634         (LayoutTestController::authenticationPassword):
1635         (LayoutTestController::setAuthenticationPassword):
1636
1637         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1638         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
1639
1640         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1641         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1642         * DumpRenderTree/win/ResourceLoadDelegate.h:
1643
1644 2009-09-12  Mark Rowe  <mrowe@apple.com>
1645
1646         Reviewed by Dan Bernstein.
1647
1648         Test for <rdar://problem/6954546> and <rdar://problem/7090444>.
1649
1650         Add a flag on the test plug-in that asks it to clear the document during the call to NPP_New.
1651         This is the trigger for both <rdar://problem/6954546> and <rdar://problem/7090444>.
1652
1653         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1654         (NPP_New):
1655
1656 2009-09-14  Kevin Ollivier  <kevino@theolliviers.com>
1657
1658         wx build fix for non-wxPython builds and a fix for errors when updating swig.py.
1659
1660         * wx/build/build_utils.py:
1661         * wx/build/settings.py:
1662
1663 2009-09-14  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
1664
1665         Reviewed by Tor Arne Vestbø.
1666
1667         [Qt] Build fix for windows build.
1668
1669         * Scripts/bisect-builds: Add missing paranthesis for tmpdir function.
1670
1671 2009-09-13  Kevin Ollivier  <kevino@theolliviers.com>
1672
1673         Fix typo accidently landed in last commit.
1674
1675         * wx/build/settings.py:
1676
1677 2009-09-13  Kevin Ollivier  <kevino@theolliviers.com>
1678
1679         wx build fix, error out if using the wrong Python.
1680
1681         * wx/build/settings.py:
1682
1683 2009-09-13  Xan Lopez  <xlopez@igalia.com>
1684
1685         Build fix for GTK+ < 2.14.
1686
1687         Do not use gtk_widget_get_window, access the window directly
1688         through the struct.
1689
1690         * DumpRenderTree/gtk/EventSender.cpp:
1691         (contextClickCallback):
1692         (mouseDownCallback):
1693         (mouseUpCallback):
1694         (mouseMoveToCallback):
1695         (keyDownCallback):
1696
1697 2009-09-13  Martin Robinson  <martin.james.robinson@gmail.com>
1698
1699         Reviewed by Xan Lopez and Jan Alonzo.
1700
1701         [GTK] EventSender does not set 'window' property on synthesized GDK events
1702         https://bugs.webkit.org/show_bug.cgi?id=29169
1703
1704         Set the window property on synthesized GDK events in the GTK+ EventSender.
1705
1706         * DumpRenderTree/gtk/EventSender.cpp:
1707         (contextClickCallback):
1708         (mouseDownCallback):
1709         (mouseUpCallback):
1710         (mouseMoveToCallback):
1711         (keyDownCallback):
1712
1713 2009-09-12  Drew Wilson  <atwilson@google.com>
1714
1715         Reviewed by Mark Rowe.
1716
1717         run-webkit-tests has a timeout value that is too low
1718         https://bugs.webkit.org/show_bug.cgi?id=29223
1719
1720         * Scripts/run-webkit-tests:
1721         Changed timeout value to 20 seconds to avoid timing out too early.
1722
1723 2009-09-11  Kevin Ollivier  <kevino@theolliviers.com>
1724
1725         wx build fix. Mark dependencies as mandatory and declare which MSVC versions and
1726         architectures are supported for building wxWebKit.
1727
1728         * wx/build/settings.py:
1729
1730 2009-09-11  Eric Seidel  <eric@webkit.org>
1731
1732         Reviewed by David Levin.
1733
1734         bugzilla-tool rollout threw exception under svn
1735         https://bugs.webkit.org/show_bug.cgi?id=29211
1736
1737         * Scripts/modules/scm.py: add missing return, and convert number arguments to strings.
1738         * Scripts/modules/scm_unittest.py: add testing for this fix.
1739
1740 2009-09-11  Brian Weinstein  <bweinstein@apple.com>
1741
1742         Add myself to the committers list.
1743
1744         * Scripts/modules/committers.py:
1745
1746 2009-09-11  Eric Seidel  <eric@webkit.org>
1747
1748         Reviewed by Adam Barth.
1749
1750         bugzilla-tool land-patches should only fail-fast in --commit-queue mode
1751         https://bugs.webkit.org/show_bug.cgi?id=29201
1752
1753         * Scripts/bugzilla-tool:
1754
1755 2009-09-11  Adam Roben  <aroben@apple.com>
1756
1757         Make commit-log-editor move common prefixes to the top of the log
1758
1759         Fies <http://webkit.org/b/29190> commit-log-editor should move common
1760         prefixes to the top of the commit log
1761
1762         Reviewed by Darin Adler.
1763
1764         * Scripts/commit-log-editor: Find and remove the longest common prefix
1765         ending in a double newline from each ChangeLog entry, then put that
1766         common prefix at the top of the commit log.
1767         (removeLongestCommonPrefixEndingInDoubleNewline): Added. Finds,
1768         removes, and returns the longest common prefix ending in a double
1769         newline from a hash of strings
1770
1771 2009-09-11  Eric Seidel  <eric@webkit.org>
1772
1773         Fix obvious typo in previous commit, no review.
1774
1775         bugzilla-tool should automate rollouts
1776         https://bugs.webkit.org/show_bug.cgi?id=26715
1777
1778         * Scripts/bugzilla-tool: add back missing "scm" argument.
1779
1780 2009-09-11  Eric Seidel  <eric@webkit.org>
1781
1782         Reviewed by Adam Barth.
1783
1784         bugzilla-tool should automate rollouts
1785         https://bugs.webkit.org/show_bug.cgi?id=26715
1786
1787         bugzilla-tool rollout will do the rollout locally and leave the diff for you to verify and commit.
1788         The --complete-rollout option will automatically land and update the bug.
1789         Eventually --complete-rollout will be default, but that will require more testing.
1790
1791         This first pass is good enough for others to try and file bugs about.
1792
1793         * Scripts/bugzilla-tool:
1794          - Move modified_changelogs into scm.py.
1795          - Move svn_revision_from_commit_text logic into scm.py.
1796          - Add RolloutCommit command.
1797         * Scripts/modules/bugzilla.py:
1798          - Add reopen_bug command used by RolloutCommit.
1799         * Scripts/modules/scm.py:
1800          - Add functions to support RolloutCommit.
1801          - Abstract find_uuid into value_from_svn_info so it can be re-used for _repository_url (needed by svn merge).
1802          - Add a str() call so that svn_commit_log can take a numeric argument.
1803          - Remove a bunch of very slow code from last_svn_commit_log and used the built-in 'BASE' alias instead.
1804          - Made dry_run commits return something that svn_revision_from_commit_text can parse.
1805         * Scripts/modules/scm_unittest.py:
1806          - Add read_from_path for easy file reading.
1807          - Put test4 on a new line to make reverts work w/o conflict.
1808          - Add an "svn update" call so that the checkout revision matches the server revision.
1809          - Add tests for svn_revision_from_commit_text.
1810          - Add a simple test for apply_reverse_diff.
1811          - Add a new self.scm member and use it in the new tests (eventually other tests can use it too).
1812          - Add test for svn_commit_log to make sure my 'BASE' change above worked as expected.
1813
1814 2009-09-11  Adam Roben  <aroben@apple.com>
1815
1816         Get user script/stylesheet tests running on Windows
1817
1818         Fixes <http://webkit.org/b/29181> User script/stylesheet tests are
1819         skipped on Windows
1820
1821         Reviewed by John Sullivan.
1822
1823         * DumpRenderTree/win/DumpRenderTree.vcproj: Link all configurations
1824         against comsuppw.lib so we can use _bstr_t.
1825
1826         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Fixed #include
1827         order, added #include of comutil.h for _bstr_t.
1828
1829         (bstrT): Helper function to convert a JSStringRef to a _bstr_t.
1830         (LayoutTestController::addUserScript):
1831         (LayoutTestController::addUserStyleSheet):
1832         Implemented. Implementations were based on those in
1833         LayoutTestControllerMac.mm.
1834
1835 2009-09-10  David Kilzer  <ddkilzer@apple.com>
1836
1837         <http://webkit.org/b/29147> run-webkit-tests:  make -h show help 
1838
1839         Reviewed by Mark Rowe.
1840
1841         * Scripts/run-webkit-tests: Updated to make -h switch show help.
1842
1843 2009-09-10  Fumitoshi Ukai  <ukai@chromium.org>
1844
1845         Reviewed by Alexey Proskuryakov.
1846
1847         Add WebCore/websockets directory in wx build system.
1848         https://bugs.webkit.org/show_bug.cgi?id=28038
1849
1850         * wx/build/settings.py:
1851
1852 2009-09-10  Martin Robinson  <martin.james.robinson@gmail.com>
1853
1854         [GTK] EventSender does not properly convert some keyDown strings
1855         https://bugs.webkit.org/show_bug.cgi?id=29119
1856
1857         Add more keyDown string to character code conversions for GTK+ EventSender.
1858
1859         * DumpRenderTree/gtk/EventSender.cpp:
1860         (keyDownCallback):
1861
1862 2009-09-09  Steve Block  <steveblock@google.com>
1863
1864         Reviewed by Maciej Stachowiak.
1865
1866         Geolocation Coordinates::toString() prints bogus values for unspecified properties.
1867         https://bugs.webkit.org/show_bug.cgi?id=29080
1868
1869         * Scripts/make-script-test-wrappers: Modified. Adds asynchronous Geolocation tests to exclusion list.
1870
1871 2009-09-09  Eric Seidel  <eric@webkit.org>
1872
1873         Reviewed by Eric Carlson.
1874
1875         reviewer/committer lookups are backwards
1876         https://bugs.webkit.org/show_bug.cgi?id=29113
1877
1878         I also moved Eric Carlson from the committer list to the reviewer list now that he is one.
1879
1880         * Scripts/modules/bugzilla.py:
1881         * Scripts/modules/committers.py:
1882
1883 2009-09-09  Cameron McCormack  <cam@mcc.id.au>
1884
1885         Reviewed by Eric Seidel.
1886
1887         svn-unapply doesn't revert directories correctly
1888         https://bugs.webkit.org/show_bug.cgi?id=29065
1889
1890         * Scripts/svn-unapply: Make svnStatus consistently return status
1891         lines including a newline.
1892         * Scripts/svn-apply: Keep svnStatus in sync with the one in
1893         svn-unapply, in lieu of moving it to a common file.
1894
1895 2009-09-09  Cameron McCormack  <cam@mcc.id.au>
1896
1897         Reviewed by Eric Seidel.
1898
1899         svn-apply doesn't handle changes to files copied to new directories properly
1900         https://bugs.webkit.org/show_bug.cgi?id=29059
1901
1902         * Scripts/svn-apply: Don't treat "--- revision 0" patches as being
1903         additions if we know that we've just copied a file to this name.
1904
1905 2009-09-09  Eric Seidel  <eric@webkit.org>
1906
1907         Reviewed by David Levin.
1908
1909         commit-queue hangs if a builder has never built
1910         https://bugs.webkit.org/show_bug.cgi?id=29091
1911
1912         * Scripts/modules/buildbot.py:
1913         * Scripts/modules/buildbot_unittest.py:
1914
1915 2009-09-09  Zan Dobersek  <zandobersek@gmail.com>
1916
1917         Reviewed by Gustavo Noronha.
1918
1919         [GTK] DumpRenderTree needs eventSender object and implementation
1920         https://bugs.webkit.org/show_bug.cgi?id=25990
1921
1922         Implements most of the EventSender object's functionality for
1923         the DumpRenderTree tool. Implementation still lacks support
1924         for drag and drop tests and forward leaps.
1925
1926         Based on work by Holger Hans Peter Freyther.
1927
1928         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1929         (runTest): Focus on the view before loading a new test.
1930         (webViewWindowObjectCleared):
1931         * DumpRenderTree/gtk/EventSender.cpp: Added.
1932         (getDragModeCallback):
1933         (setDragModeCallback):
1934         (leapForwardCallback):
1935         (contextClickCallback):
1936         (updateClickCount):
1937         (mouseDownCallback):
1938         (mouseUpCallback):
1939         (mouseMoveToCallback):
1940         (beginDragWithFilesCallback):
1941         (replaySavedEvents):
1942         (keyDownCallback):
1943         (textZoomInCallback):
1944         (textZoomOutCallback):
1945         (zoomPageInCallback):
1946         (zoomPageOutCallback):
1947         (getClass):
1948         (makeEventSender):
1949         * DumpRenderTree/gtk/EventSender.h: Added.
1950         * GNUmakefile.am: Add build rules for EventSender.
1951
1952 2009-09-09  Daniel Bates  <dbates@webkit.org>
1953
1954         Reviewed by Adam Roben.
1955         
1956         https://bugs.webkit.org/show_bug.cgi?id=28953
1957
1958         Added pre- and post- build events so that on build failure, the file 
1959         buildfailed is written to the directory $(WebKitOutputDir).
1960
1961         * WinLauncher/WinLauncher.vcproj:
1962
1963 2009-09-09  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1964
1965         Unreviewed.
1966
1967         Add myself to list of committers.
1968
1969         * Scripts/modules/committers.py:
1970
1971 2009-09-08  Eric Seidel  <eric@webkit.org>
1972
1973         Reviewed by David Levin.
1974
1975         commit-queue gets stuck if a non-committer sets commit-queue+ or review+
1976         https://bugs.webkit.org/show_bug.cgi?id=28605
1977         https://bugs.webkit.org/show_bug.cgi?id=28916
1978
1979         * Scripts/bugzilla-tool:
1980          - Fix comment and adjust reject_patch_from_commit_queue call to pass "manual commit"
1981            comment now that it's used for rejecting patches for invalid committers too.
1982          - Pass reject_invalid_patches=True for commit-queue calls, normally we just ignore patches with invalid reviewers, the commit-queue rejects them.
1983          - Make the commit queue print patches count instead of bugs count, this also fixes https://bugs.webkit.org/show_bug.cgi?id=28916.
1984         * Scripts/modules/bugzilla.py:
1985          - Make _parse_attachment_element not validate reviewer/committer.
1986          - Share flag parsing code in _parse_attachment_flag.
1987          - Add _validate* methods for validating reviewers and committers and updating bugs when validation fails.
1988          - Add reject_invalid_patches argument so the commit-queue can update bugs on failed validation and other "read only" commands will not.
1989          - Add reject_patch_from_review_queue using a new _set_flag_on_attachment abstraction.
1990         * Scripts/modules/bugzilla_unittest.py:
1991          - Update this test to no longer expect committer/reviewer validation.
1992         * Scripts/modules/committers.py:
1993          - Return None on failed lookups instead of raising Exceptions.
1994         * Scripts/modules/committers_unittest.py:
1995          - Update tests to expect None returns instead of exceptions.
1996
1997 2009-09-09  David Kilzer  <ddkilzer@apple.com>
1998
1999         <http://webkit.org/b/29061> Fix obvious copy-paste error in AccessibilityUIElement::clickPointY()
2000
2001         Reviewed by Mark Rowe.
2002
2003         No change to layout test results.
2004
2005         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2006         (AccessibilityUIElement::clickPointY): Changed to return y value
2007         instead of x value.
2008
2009 2009-09-08  Dimitri Glazkov  <dglazkov@chromium.org>
2010
2011         Reviewed by Mark Rowe.
2012
2013         Reduce dglazkov's boboiness by properly concatenating revision value.
2014
2015         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Used substitution
2016             rather than "+".
2017
2018 2009-09-08  Kevin Ollivier  <kevino@theolliviers.com>
2019
2020         wxWebKit Python extension build fix - get swig.py if it doesn't exist.
2021
2022         * wx/build/build_utils.py:
2023
2024 2009-09-08  Mark Rowe  <mrowe@apple.com>
2025
2026         Fix an incorrect variable name in UpdateChromiumSource.
2027
2028         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2029
2030 2009-09-08  Mark Rowe  <mrowe@apple.com>
2031
2032         Don't check for leaks on the release SnowLeopard builder.
2033
2034         * BuildSlaveSupport/build.webkit.org-config/config.json:
2035
2036 2009-09-08  Mark Rowe  <mrowe@apple.com>
2037
2038         Add a SnowLeopard release builder.
2039
2040         * BuildSlaveSupport/build.webkit.org-config/config.json:
2041
2042 2009-09-08  David Levin  <levin@chromium.org>
2043
2044         Reviewed by Darin Adler.
2045
2046         Remove end of line whitespace check from check-webkit-style.
2047         https://bugs.webkit.org/show_bug.cgi?id=29053
2048
2049         * Scripts/modules/cpp_style.py:
2050
2051 2009-09-08  Cameron McCormack  <cam@mcc.id.au>
2052
2053         Reviewed by Darin Adler.
2054
2055         Fix DumpRenderTree build from clean tree on Tiger
2056         https://bugs.webkit.org/show_bug.cgi?id=28927
2057
2058         * DumpRenderTree/mac/PerlSupport/Makefile: Ensure the
2059         DerivedSources/DumpRenderTree directory exists when
2060         building on Tiger.
2061
2062 2009-09-08  Kevin Ollivier  <kevino@theolliviers.com>
2063
2064         wx build fix after introduction of platform/mock directory.
2065
2066         * wx/build/settings.py:
2067
2068 2009-09-08  Yael Aharon  <yael.aharon@nokia.com>
2069
2070         Unreviewed.
2071
2072         Add myself to list of committers.
2073
2074         * Scripts/modules/committers.py:
2075
2076 2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2077
2078         Unreviewed.
2079
2080         Add myself to list of committers.
2081
2082         * Scripts/modules/committers.py:
2083
2084 2009-09-08  Cameron McCormack  <cam@mcc.id.au>
2085
2086         Reviewed by Darin Adler.
2087
2088         prepare-ChangeLog too chatty on file additions
2089         https://bugs.webkit.org/show_bug.cgi?id=29019
2090
2091         * Scripts/prepare-ChangeLog: Omit description of added properties
2092         on newly added files.
2093
2094 2009-09-08  Steve Block  <steveblock@google.com>
2095
2096         Reviewed by Adam Barth.
2097
2098         Adds a LayoutTestController method to set the permission state for Geolocation.
2099         This is required to use the mock Geolocation service for testing.
2100         https://bugs.webkit.org/show_bug.cgi?id=29027
2101
2102         * DumpRenderTree/LayoutTestController.cpp: Modified.
2103         (setDatabaseQuotaCallback): Modified. Style fix.
2104         (setGeolocationPermissionCallback): Added. Sets the Geolocation permission state.
2105         (LayoutTestController::staticFunctions): Modified. Registers the above function on the LayoutTestController.
2106         * DumpRenderTree/LayoutTestController.h: Modified.
2107         (LayoutTestController::setGeolocationPermission): Added. Sets the Geolocation permission state.
2108         (LayoutTestController::isGeolocationPermissionSet): Added. Returns whether the Geolocation permission has been set.
2109         (LayoutTestController::geolocationPermission): Added. Returns the Geolocation permission state.
2110         * DumpRenderTree/mac/UIDelegate.mm: Modified.
2111         (-[UIDelegate webView:frame:requestGeolocationPermission:securityOrigin:]): Added. Implement chrome method to respond to request for Geolocation permission state. Response is made using above methods to access permission state.
2112
2113 2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2114
2115         Reviewed by Simon Hausmann.
2116
2117         [Qt] QtWebKit single API to enable persistency
2118         https://bugs.webkit.org/show_bug.cgi?id=28682
2119
2120         Use the new enablePersistentStorage API instead 
2121         of enabling all persistent features one-by-one.
2122
2123         * DumpRenderTree/qt/DumpRenderTree.cpp:
2124         (WebCore::WebPage::WebPage):
2125         (WebCore::DumpRenderTree::DumpRenderTree):
2126
2127 2009-09-07  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2128
2129         Reviewed by Tor Arne Vestbø.
2130
2131         Refactor --strict switch to --ignore-metrics and correct the
2132         implementation to make the feature usable on all platforms.
2133         https://bugs.webkit.org/show_bug.cgi?id=28907
2134
2135         run-webkit-tests --ignore-metrics strips the font related metrics from
2136         the actual and expected data before comparing them.
2137         In this way the render trees can be checked for obvious differences but
2138         a successful test implies by no means that the layout is actually correct.
2139
2140         * Scripts/run-webkit-tests:
2141
2142 2009-09-07  Steve Block  <steveblock@google.com>
2143
2144         Reviewed by Adam Barth.
2145
2146         Adds a mock Geolocation service. This will be used to provide predictable behavior of the
2147         Geolocation API for use in LayoutTests. Later changes will integrate the the mock
2148         Geolocation service with DumpRenderTree.
2149         https://bugs.webkit.org/show_bug.cgi?id=28264
2150
2151         * DumpRenderTree/LayoutTestController.cpp: Modified.
2152         (setMockGeolocationPositionCallback): Added. Configures the mock Geolocation service.
2153         (setMockGeolocationErrorCallback): Added. Configures the mock Geolocation service.
2154         (LayoutTestController::staticFunctions): Added. Registers the above functions on the LayoutTestController.
2155         * DumpRenderTree/LayoutTestController.h: Modified.
2156         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Modified.
2157         (LayoutTestController::setMockGeolocationPosition): Added. Configures the mock Geolocation service.
2158         (LayoutTestController::setMockGeolocationError): Added. Configures the mock Geolocation service.
2159
2160 2009-09-07  Drew Wilson  <atwilson@google.com>
2161
2162         Reviewed by David Levin.
2163
2164         Enable SHARED_WORKERS by default
2165         https://bugs.webkit.org/show_bug.cgi?id=28959
2166
2167         * Scripts/build-webkit:
2168
2169 2009-09-07  Kevin Ollivier  <kevino@theolliviers.com>
2170
2171         wx build fixes for wx SVN trunk.
2172
2173         * wx/build/settings.py:
2174
2175 2009-09-04  Kevin Ollivier  <kevino@theolliviers.com>
2176
2177         wx build fix. Switch USE_ defines over to the compiler so that they can be
2178         checked by files not including config.h (like WebCorePrefix.h).
2179
2180         * wx/build/settings.py:
2181
2182 2009-09-04  Adam Barth  <abarth@webkit.org>
2183
2184         Unreviewed build fix.
2185
2186         Update declaration of FrameLoadDelegate to reflect that
2187         IWebFrameLoadDelegatePrivate2 inherits from
2188         IWebFrameLoadDelegatePrivate.
2189
2190         * DumpRenderTree/win/FrameLoadDelegate.h:
2191
2192 2009-09-04  Adam Barth  <abarth@webkit.org>
2193
2194         Reviewed by Eric Seidel.
2195
2196         https://bugs.webkit.org/show_bug.cgi?id=24696
2197
2198         Add testing instrumentation for mixed content.
2199
2200         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2201         (-[FrameLoadDelegate webView:]):
2202         (-[FrameLoadDelegate webView:didRunInsecureContent:]):
2203         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2204         (descriptionSuitableForTestResult):
2205         (FrameLoadDelegate::QueryInterface):
2206         (FrameLoadDelegate::didDisplayInsecureContent):
2207         (FrameLoadDelegate::didRunInsecureContent):
2208         * DumpRenderTree/win/FrameLoadDelegate.h:
2209
2210 2009-09-03  Kevin Watters  <kevinwatters@gmail.com>
2211
2212         Reviewed by Kevin Ollivier.
2213
2214         [wx] Frames support
2215         https://bugs.webkit.org/show_bug.cgi?id=19041
2216
2217         * wx/build-wxwebkit:
2218
2219 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2220
2221         <http://webkit.org/b/28880> svn-apply --force doesn't actually work
2222
2223         Reviewed by Eric Seidel.
2224
2225         This fixes "svn-apply --force" and adds unit tests for the
2226         scm.apply_patch() method which uses this script.
2227
2228         * Scripts/svn-apply: Created $globalExitCode variable that
2229         defaults to 0.  Exit with a value of $globalExitCode when the
2230         script is finished.
2231         (applyPatch): Ignore a non-zero $exitCode if $force is true, but
2232         set $globalExitCode to $exitCode so that svn-apply exits with a
2233         non-zero status if any patches did not apply cleanly.  Also
2234         print out the actual patch command if $force was not true.
2235
2236         * Scripts/modules/scm.py:
2237         (scripts_directory): Added.  Extracted from script_path().
2238         (script_path): Extracted scripts_directory().
2239         * Scripts/modules/scm_unittest.py: Import urllib.
2240         (SVNTestRepository.setup): Save the original working directory
2241         in test_object since this represents the WebKit repository from
2242         where the unit tests are run.
2243         (SCMTest): Created new super class to hold utility methods.
2244         (SCMTest._create_patch): Creates a patch file on disk and a
2245         dictionary for use with scm.svn_apply().
2246         (SCMTest._setup_webkittools_scripts_symlink): Sets up a symlink
2247         back to WebKitTools/Scripts in the test repository so that
2248         scm.apply_patch() is able to find the svn-apply script.
2249         (SVNTest): Inherit from SCMTest instead of unittest.TestCase.
2250         (SVNTest.tearDown): Make sure to change directories back to the
2251         original_path before the next test.
2252         (SVNTest.test_apply_svn_patch): New test case for applying an
2253         svn patch with scm.apply_patch().
2254         (SVNTest.test_apply_svn_patch_force): New test case for applying
2255         an svn patch with scm.apply_patch() that conflicts.
2256         (GitTest): Inherit from SCMTest instead of unittest.TestCase.
2257         (GitTest.tearDown): Make sure to change directories back to the
2258         original_path before the next test.
2259         (GitTest.test_apply_git_patch): New test case for applying a git
2260         patch with scm.apply_patch().
2261         (GitTest.test_apply_git_patch_force): New test case for applying
2262         a git patch with scm.apply_patch() that conflicts.
2263
2264 2009-09-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2265
2266         Reviewed by Mark Rowe.
2267
2268         [Qt] Add support for platform-spesific layout-test results
2269
2270         For the Qt port we use the qt-[mac|linux|win] directories and then fall
2271         back to the generic qt directory for both test results and skipped list.
2272
2273         * Scripts/run-webkit-tests:
2274         * Scripts/webkitdirs.pm:
2275
2276 2009-09-02  Laurent Cerveau  <lcerveau@me.com>
2277
2278         Reviewed by David Kilzer.
2279
2280         <http://webkit.org/b/25517> build-webkit script should print build time at end
2281
2282         * Scripts/build-webkit:
2283         Added startTime and endTime variable so that the build time is computed and printed as
2284         part of the build message; display formatting has been separated in a dedicated subroutine.
2285
2286 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2287
2288         <http://webkit.org/b/28881> svn-create-patch should check if the repo path is the same when trying to find the root
2289
2290         Reviewed by Eric Seidel.
2291
2292         * Scripts/VCSUtils.pm:
2293         (determineSvnRoot): Added back check for repository root that
2294         was removed in r46134 when this code lived in svn-create-patch.
2295         It's necessary to check both the repository root and the
2296         repository UUID in case two different working directories are
2297         checked out from the same repository.
2298
2299 2009-09-02  Timothy Hatcher  <timothy@apple.com>
2300
2301         Use new 512x512 icons for nightly builds.
2302
2303         Rubber-stamped by Mark Rowe.
2304
2305         * WebKitLauncher/webkit.icns:
2306
2307 2009-09-02  Kevin Ollivier  <kevino@theolliviers.com>
2308
2309         waf build fix. Remove local variable shadowing global.
2310
2311         * wx/build/settings.py:
2312
2313 2009-09-02  Zan Dobersek  <zandobersek@gmail.com>
2314
2315         Reviewed by David Kilzer.
2316
2317         Calls exitStatus function from the main package where it is also defined.
2318
2319         * Scripts/VCSUtils.pm:
2320
2321 2009-09-02  Kevin Ollivier  <kevino@theolliviers.com>
2322
2323         waf build fixes for Windows/MSVC and Mac/Snow Leopard.
2324
2325         * wx/browser/wscript:
2326         * wx/build/build_utils.py:
2327         * wx/build/settings.py:
2328
2329 2009-08-10  Kevin Ollivier  <kevino@theolliviers.com>
2330
2331         Reviewed by Eric Seidel.
2332
2333         Changes needed for build-webkit to support the waf build system for the wx port.
2334         
2335         https://bugs.webkit.org/show_bug.cgi?id=27619
2336
2337         * Scripts/build-webkit:
2338         * Scripts/run-launcher:
2339         * Scripts/webkitdirs.pm:
2340
2341 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2342
2343         <http://webkit.org/b/27168> With Subversion 1.6, update-webkit prompts on conflicts
2344
2345         Reviewed by Eric Seidel.
2346
2347         * Scripts/update-webkit: Added "--accept postpone" to
2348         @svnOptions when running with svn-1.6 or newer.
2349
2350 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2351
2352         Moved svn 1.6 version check into VCSUtils::isSVNVersion16OrNewer()
2353
2354         Reviewed by Eric Seidel.
2355
2356         * Scripts/VCSUtils.pm:
2357         (@EXPORT): Added &isSVNVersion16OrNewer.
2358         (svnVersion): Added.  Internal method that gets the SVN version
2359         and caches it.
2360         (isSVNVersion16OrNewer): Added.  Method that does the SVN 1.6
2361         version check.
2362         * Scripts/prepare-ChangeLog: Switched to use new
2363         isSVNVersion16OrNewer() method.
2364         * Scripts/resolve-ChangeLogs: Ditto.
2365         * Scripts/svn-create-patch: Ditto.
2366
2367 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2368
2369         Clean up VCSUtils.pm
2370
2371         Reviewed by Eric Seidel.
2372
2373         * Scripts/VCSUtils.pm: Added proper package statement.  Fixed
2374         indentation of BEGIN block.  Listed each exported method on a
2375         line by itself.  Added methods to the export list after adding
2376         the package statement.  Sorted module variables.  Moved
2377         definiton of $gitRoot next to other module variables.
2378
2379 2009-09-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2380
2381         Rubber-stamped by Simon Hausmann.
2382
2383         [Qt] Fix layout-test plugins/plugin-javascript-access.html
2384
2385         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2386
2387 2009-09-02  Shinichiro Hamaji  <hamaji@chromium.org>
2388
2389         Reviewed by Eric Seidel.
2390
2391         js tests should move into jstests subdirectory instead of resources/
2392         https://bugs.webkit.org/show_bug.cgi?id=25880
2393
2394         make-script-wrappers supports both resources and script-tests directories.
2395         run-webkit-tests ignores files in script-tests.
2396         Move script tests of animations to check the new script is working.
2397
2398         * Scripts/make-script-test-wrappers:
2399         * Scripts/run-webkit-tests:
2400
2401 2009-09-02  Szabo Carol  <carol.szabo@nokia.com>
2402
2403         Reviewed by David Levin.
2404
2405         check-webkit-style uses python from /usr/bin instead of the PATH
2406         https://bugs.webkit.org/show_bug.cgi?id=28225
2407
2408         * Scripts/bugzilla-tool:
2409         * Scripts/check-webkit-style:
2410         * Scripts/run-webkit-unittests:
2411         * Scripts/update-sources-list.py:
2412           Changed the first line from
2413           #!/usr/bin/python
2414           to
2415           #!/usr/bin/env python
2416           which causes python to be invoked from the path location returned
2417           by "which python" when any of these scripts are launched.
2418           these are currently all the python scripts in WebKitTools/Scripts.
2419
2420 2009-09-01  David Kilzer  <ddkilzer@apple.com>
2421
2422         <http://webkit.org/b/28601> bugzilla-tool post-commits posts commits backwards
2423
2424         Reviewed by Adam Barth.
2425
2426         * Scripts/modules/scm.py:
2427         (Git.commit_ids_from_commitish_arguments): Reverse the list of
2428         commits returned from git-rev-list since we always want to post
2429         the oldest patches first to bugs.webkit.org.
2430         * Scripts/modules/scm_unittest.py:
2431         (run): Added return statement to return the output now that we
2432         want it sometimes.
2433         (SVNTestRepository._setup_test_commits): Added a fourth commit
2434         so the GitTest.test_commitish_order() test has more commits to
2435         work with.
2436         (GitTest.test_commitish_order): Added unit test for change to
2437         Git.commit_ids_from_commitish_arguments() in scm.py.
2438
2439 2009-09-01  David Kilzer  <ddkilzer@apple.com>
2440
2441         <http://webkit.org/b/28877> Implement bugzilla-tool mark-fixed
2442
2443         Reviewed by David Levin.
2444
2445         The mark-fixed subcommand is for those times when you don't use
2446         bugzilla-tool to commit a patch, but you want to use it to close
2447         the bug with a committed-revision message.
2448
2449         * Scripts/bugzilla-tool:
2450         (bug_comment_from_svn_revision): Added.  Extracted from
2451         bug_comment_from_commit_text().
2452         (bug_comment_from_commit_text): Extracted
2453         bug_comment_from_svn_revision() from this method.
2454         (MarkBugFixed.__init__): Added.
2455         (MarkBugFixed._fetch_commit_log): Added.  Retrieves the commit
2456         log from the last commit if no svn revision is specified, else
2457         the commit log for the specified svn revision.
2458         (MarkBugFixed._determine_bug_id_and_svn_revision): Added.
2459         Attempts to determine the bug id and svn revision if one or both
2460         were not defined on the command line.
2461         (MarkBugFixed.execute): Added.  Adds a comment about the
2462         revision that fixed the bug and closes the bug.
2463         (BugzillaTool.__init__): Added mark-fixed subcommand.
2464         * Scripts/modules/bugzilla.py:
2465         (Bugzilla.fetch_title_from_bug): Added.  Returns the title of a
2466         bug given a bug id.
2467         * Scripts/modules/scm.py:
2468         (SCM.strip_r_from_svn_revision): Added.  Utility method to strip
2469         the leading 'r' from an svn revision.
2470         (SCM.svn_commit_log): Added.  Subclasses must override.
2471         (SCM.last_svn_commit_log): Added.  Subclasses must override.
2472         (SVN.svn_commit_log): Added.  Returns svn log for a given
2473         revision.
2474         (SVN.last_svn_commit_log): Added.  Uses svnversion to find the
2475         last commit in an svn working directory and then runs svn log.
2476         (Git.svn_commit_log): Added.  Returns svn log for a given
2477         revision.
2478         (Git.last_svn_commit_log): Added.  Runs git-svn-log with a limit
2479         of one log message.
2480
2481 2009-09-01  David Kilzer  <ddkilzer@apple.com>
2482
2483         <http://webkit.org/b/28880> svn-apply --force doesn't actually work
2484
2485         Reviewed by Brady Eidson.
2486
2487         * Scripts/svn-apply:
2488         (applyPatch): Add "--force" to $options arrayref if $force is
2489         set.
2490
2491 2009-09-01  David Kilzer  <ddkilzer@apple.com>
2492
2493         <http://webkit.org/b/28725> resolve-ChangeLogs: determineVCSRoot() returns incorrect repository root during git filter-branch
2494
2495         Reviewed by Adam Roben.
2496
2497         When git-filter-branch has been invoked to rewrite ChangeLog
2498         files on series of git commits, it changes directories into
2499         .git-rewrite/t before re-running resolve-ChangeLogs.  This
2500         causes determineVCSRoot() in VCSUtils.pm to return
2501         ".git-rewrite/t", which causes that path to be prepended to all
2502         ChangeLog paths, which results in an error like this:
2503
2504             error: pathspec '.git-rewrite/t/ChangeLog' did not match any file(s) known to git.
2505             Died at WebKitTools/Scripts/resolve-ChangeLogs line 376.
2506
2507         The correct way to fix this is not to try to find the repository
2508         root when invoked by git-filter-branch.
2509
2510         * Scripts/resolve-ChangeLogs: If isInGitFilterBranch() is true,
2511         set $relativePath to '.' instead of calling
2512         chdirReturningRelativePath(determineVCSRoot()).
2513         (isInGitFilterBranch): Added.  Checks for the existence of the
2514         MAPPED_PREVIOUS_COMMIT environment variable.
2515
2516 2009-09-01  Xan Lopez  <xlopez@igalia.com>
2517
2518         Reviewed by Gustavo Noronha.
2519
2520         Add support for Fedora distros in the http tests
2521         https://bugs.webkit.org/show_bug.cgi?id=28263
2522
2523         Add detection code for Fedora distribution, and use the proper
2524         httpd conf file when needed.
2525
2526         * Scripts/run-webkit-httpd:
2527         * Scripts/run-webkit-tests:
2528         * Scripts/webkitdirs.pm:
2529
2530 2009-09-01  Jan Michael Alonzo  <jmalonzo@webkit.org>
2531
2532         Reviewed by Eric Seidel.
2533
2534         [Gtk] DRT needs implementation of overridePreference
2535         https://bugs.webkit.org/show_bug.cgi?id=28830
2536
2537         Implement overridePreference.
2538
2539         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2540         (resetDefaultsToConsistentValues):
2541         (setDefaultsToConsistentStateValuesForTesting):
2542         (runTest):
2543         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2544         (toWebSettingKey):
2545         (LayoutTestController::overridePreference):
2546
2547 2009-09-01  Joseph Pecoraro  <joepeck@webkit.org>
2548
2549         <http://webkit.org/b/28623> svn-[un]apply should change directories to the repository root before [un]applying
2550
2551         Reviewed by Eric Seidel.
2552
2553         Jump back and forth between the repository root directory (to apply) and the
2554         directory the script was run from (to find the patch).
2555
2556         * Scripts/svn-apply:
2557         * Scripts/svn-unapply:
2558
2559 2009-08-31  Adam Roben  <aroben@apple.com>
2560
2561         Fall back to a Release version of Safari if a Debug one doesn't exist
2562
2563         <http://webkit.org/b/28849>
2564
2565         Reviewed by Sam Weinig.
2566
2567         * Scripts/webkitdirs.pm:
2568         (safariPath): If the user is working with a Debug build, but there's
2569         no Debug version of Safari present, fall back to using a Release
2570         version of Safari.
2571
2572 2009-08-31  Adam Roben  <aroben@apple.com>
2573
2574         Make safariPath() work for Debug builds of Safari on Windows
2575
2576         <http://webkit.org/b/28849>
2577
2578         Reviewed by Sam Weinig.
2579
2580         * Scripts/webkitdirs.pm:
2581         (safariPath): If the user is working with a Debug build, add the
2582         _debug suffix to Safari.exe.
2583
2584 2009-08-28  Eric Seidel  <eric@webkit.org>
2585
2586         Reviewed by Adam Barth.
2587
2588         commit-queue needs a master process
2589         https://bugs.webkit.org/show_bug.cgi?id=28040
2590
2591         Add a bugzilla-tool commit-queue command
2592         Keeps per-bug logs, but doesn't yet upload them anywhere.
2593
2594         * Scripts/bugzilla-tool: Add LandPatchesFromCommitQueue to handle 'commit-queue'
2595         * Scripts/modules/buildbot.py: remove noisy log message
2596         * Scripts/modules/logging.py: add a 'tee()' call for splitting outputs in python
2597
2598 2009-08-28  Jan Michael Alonzo  <jmalonzo@webkit.org>
2599
2600         Reviewed by Gustavo Noronha.
2601
2602         [GTK] Geolocation needs permission API before being enabled by default
2603
2604         Build the Gtk port with geolocation enabled. This option is only
2605         enabled for the buildbot. The autotools option will be enabled by
2606         default once the permissions API is implemented.
2607
2608         * Scripts/build-webkit:
2609
2610 2009-08-26  Cameron McCormack  <cam@mcc.id.au>
2611
2612         Reviewed by David Kilzer.
2613
2614         Make prepare-ChangeLog notice property changes
2615         https://bugs.webkit.org/show_bug.cgi?id=28675
2616
2617         Make the generated ChangeLog entry include a short description of
2618         property changes if there were such changes.  Also make
2619         prepare-ChangeLog not bail if the only changes are property changes.
2620
2621         * Scripts/prepare-ChangeLog:
2622
2623 2009-08-26  Adam Barth  <abarth@webkit.org>
2624
2625         Reviewed by Oliver Hunt.
2626
2627         Don't let local files access web URLs
2628         https://bugs.webkit.org/show_bug.cgi?id=28480
2629
2630         A bunch of our LayoutTests rely on our old behavior, so we explicitly
2631         grant local files universal access during testing.  Mainly, these tests
2632         involve making XMLHttpRequests for data URLs.
2633
2634         * DumpRenderTree/mac/DumpRenderTree.mm:
2635         (resetDefaultsToConsistentValues):
2636         * DumpRenderTree/qt/DumpRenderTree.cpp:
2637         (WebCore::WebPage::WebPage):
2638         * DumpRenderTree/win/DumpRenderTree.cpp:
2639         (resetDefaultsToConsistentValues):
2640
2641 2009-08-26  John Gregg  <johnnyg@google.com>
2642
2643         Reviewed by David Levin.
2644
2645         Minor style correction and include fix for notifications
2646         https://bugs.webkit.org/show_bug.cgi?id=28745
2647
2648         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2649           change to correct EnumStyle
2650         (DRTDesktopNotificationPresenter::checkNotificationPermission):
2651
2652 2009-08-26  David Levin  <levin@chromium.org>
2653
2654         Reviewed by Alexey Proskuryakov.
2655
2656         XMLHttpRequest.withCredentials=false shouldn't save cookies.
2657         https://bugs.webkit.org/show_bug.cgi?id=28743
2658
2659         Added the support to the layout test controller on OSX and
2660         Windows (for CFNETWORK) to allow for changing the accept cookie
2661         policy.
2662
2663         * DumpRenderTree/LayoutTestController.cpp:
2664         (LayoutTestController::LayoutTestController): Added a bool
2665         to track the state of accepting cookies.
2666         (setAlwaysAcceptCookiesCallback): Standard wrapper method
2667         to go from js to a C++ method.
2668         (LayoutTestController::staticFunctions): Added the
2669         setAlwaysAcceptCookies method to the js layoutTestController.
2670         * DumpRenderTree/LayoutTestController.h:
2671         (LayoutTestController::alwaysAcceptCookies): Returns the value.
2672         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2673         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
2674         * DumpRenderTree/mac/DumpRenderTree.mm:
2675         (resetDefaultsToConsistentValues): Reset the accept cookie to
2676         its default.
2677         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2678         (LayoutTestController::setAlwaysAcceptCookies): Does the work for
2679         OSX to change the cookie accept policy.
2680         * DumpRenderTree/win/DumpRenderTree.cpp:
2681         (setAlwaysAcceptCookies): Method to handle all the calls necessary
2682         to change the accept cookie policy on Windows.
2683         (resetDefaultsToConsistentValues): Reset the accept cookie to
2684         its default.
2685         * DumpRenderTree/win/DumpRenderTreeWin.h:
2686         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2687         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
2688         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2689         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
2690
2691 2009-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2692
2693         Unreviewed.
2694
2695         Remove accidentally left in clobber option.
2696         https://bugs.webkit.org/show_bug.cgi?id=28400
2697
2698         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed clobber option.
2699
2700 2009-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2701
2702         Reviewed by Mark Rowe.
2703
2704         Add canary-style Chromium WebKit build slave to the waterfall.
2705         https://bugs.webkit.org/show_bug.cgi?id=28400
2706
2707         * BuildSlaveSupport/build.webkit.org-config/config.json: Added one Chromium/Windows slave
2708         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added support for Chromium slave commands.
2709
2710 2009-08-25  Cameron McCormack  <cam@mcc.id.au>
2711
2712         Reviewed by Darin Adler.
2713
2714         make-script-test-wrappers should be executable
2715         https://bugs.webkit.org/show_bug.cgi?id=28669
2716
2717         Make make-script-test-wrappers and update-sources-list.py both be
2718         executable.
2719
2720         * Scripts/update-sources-list.py:
2721         * Scripts/make-script-test-wrappers:
2722
2723 2009-08-25  Brent Fulgham  <bfulgham@webkit.org>
2724
2725         Build fix
2726
2727         Revise Debug_Cairo targets to point inherit from the 
2728         debug_wincairo.vsprops property sheet so that they link
2729         against the proper libraries in Debug build.
2730
2731         * DumpRenderTree/win/DumpRenderTree.vcproj:
2732         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2733         * WinLauncher/WinLauncher.vcproj:
2734
2735 2009-08-25  David Levin  <levin@chromium.org>
2736
2737         Reviewed by Adam Roben.
2738
2739         PLATFORM(CFNETWORK) should be USE(CFNETWORK).
2740         https://bugs.webkit.org/show_bug.cgi?id=28713
2741
2742         * DumpRenderTree/win/DumpRenderTree.cpp:
2743         (main):
2744
2745 2009-08-25  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2746
2747         Reviewed by Ariya Hidayat.
2748
2749         [Qt/Mac] Use CONFIG+=build_all only when building libraries
2750
2751         If no configuration is specified when building WebKit we pass the
2752         debug_and_release option to QMake which results in Makefiles for
2753         both configurations being generated.
2754
2755         Previously we built both of these configurations by default, for
2756         all targets (both the QtWebKit framework/dyldlib and the various
2757         executables such as QtLauncher and tests). This makes sense for
2758         the libraries, which get the _debug suffix and can be loaded on
2759         demand by setting the DYLD_IMAGE_SUFFIX, but for executables we
2760         ended up building the same executable twice.
2761
2762         We now only build one instance of each executable, and since this
2763         is a developer build we build the debug-version. Passing either
2764         --debug or --release to build-webkit will override this, and
2765         even in the default case the release version can still be built
2766         by running 'make release' in the the build directory of each
2767         target.
2768
2769         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2770         * Scripts/webkitdirs.pm:
2771
2772 2009-08-24  Hironori Bono  <hbono@chromium.org>
2773
2774         Reviewed by Adam Barth.
2775
2776         Fix Bug 27827 "[Chromium] Functions Keys don't work in google spreadsheet".
2777         <https://bugs.webkit.org/show_bug.cgi?id=27827>.
2778
2779         Because of the lack of mappings from GDK key-codes to WebKit key-codes,
2780         Chromium cannot send valid key-codes to JavaScript when a user types
2781         function keys. This change just copies the mappings from 'KeyEventGtk.cpp'.
2782
2783         To write layout tests for this issue, added mappings from function-key
2784         names to platform-specific key-codes to EventSendingController objects
2785         so that eventSender.keyDown() can send function-key events without using
2786         platform-specific key codes. (Unfortunately, this eventSender.keyDown() change
2787         is only for Mac. So this change adds this new test to Skipped tests for other
2788         platforms to prevent this change from crashing the build trees.)
2789
2790         * DumpRenderTree/mac/EventSendingController.mm:
2791         (-[EventSendingController keyDown:withModifiers:]):
2792
2793 2009-08-23  Jan Michael Alonzo  <jmalonzo@webkit.org>
2794
2795         Reviewed by Xan Lopez.
2796
2797         [Gtk] API for disabling local file access to web URLs
2798         https://bugs.webkit.org/show_bug.cgi?id=28663
2799
2800         Enable this setting for DRT.
2801
2802         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2803         (resetWebViewToConsistentStateBeforeTesting):
2804
2805 2009-08-22  Adam Barth  <abarth@webkit.org>
2806
2807         Revert 47684.  We're going to do this later once clients have had a
2808         chance to opt into the setting they like.
2809
2810         * DumpRenderTree/mac/DumpRenderTree.mm:
2811         (resetDefaultsToConsistentValues):
2812         * DumpRenderTree/qt/DumpRenderTree.cpp:
2813         (WebCore::WebPage::WebPage):
2814         * DumpRenderTree/win/DumpRenderTree.cpp:
2815         (resetDefaultsToConsistentValues):
2816
2817 2009-08-22  Adam Barth  <abarth@webkit.org>
2818
2819         Reviewed by Eric Seidel.
2820
2821         Don't let local files access web URLs
2822         https://bugs.webkit.org/show_bug.cgi?id=28480
2823
2824         A bunch of our LayoutTests rely on our old behavior, so we explicitly
2825         grant local files universal access during testing.  Mainly, these tests
2826         involve making XMLHttpRequests for data URLs.
2827
2828         * DumpRenderTree/mac/DumpRenderTree.mm:
2829         (resetDefaultsToConsistentValues):
2830         * DumpRenderTree/qt/DumpRenderTree.cpp:
2831         (WebCore::WebPage::WebPage):
2832         * DumpRenderTree/win/DumpRenderTree.cpp:
2833         (resetDefaultsToConsistentValues):
2834
2835 2009-08-22  Mark Rowe  <mrowe@apple.com>
2836
2837         Rubber-stamped by Anders Carlsson.
2838
2839         Bring signed updates to the Mac nightly builds.
2840
2841         * WebKitLauncher/Info.plist:
2842         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2843         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
2844         (initializeSparkle):
2845         * WebKitLauncher/nightly.webkit.org.public.pem: Added.
2846
2847 2009-08-21  Jan Michael Alonzo  <jmalonzo@webkit.org>
2848
2849         Rubberstamped by Simon Fraser.
2850
2851         Remove GNOME keyring support in build-webkit. This dependency's
2852         already been removed in the Gtk port.
2853
2854         * Scripts/build-webkit:
2855
2856 2009-08-20  Brian Weinstein  <bweinstein@apple.com>
2857
2858         Reviewed by Adam Roben.
2859         Based on original patch by Stephanie Lewis.
2860
2861         Added support of the Windows malloc history format to parse-malloc history, so we can
2862         read and parse it.
2863
2864         * Scripts/parse-malloc-history:
2865
2866 2009-08-20  Chris Fleizach  <cfleizach@apple.com>
2867
2868         Reviewed by Darin Adler.
2869
2870         Enable various "grouping" ARIA roles
2871         https://bugs.webkit.org/show_bug.cgi?id=28486
2872
2873         Expose the ability to retrieve the subrole through accessibility for DRT.
2874
2875         * DumpRenderTree/AccessibilityUIElement.cpp:
2876         * DumpRenderTree/AccessibilityUIElement.h:
2877         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2878         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2879         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2880
2881 2009-08-20  Joseph Pecoraro  <joepeck@webkit.org>
2882
2883         Unreviewed.
2884
2885         Added myself as a committer.
2886
2887         * Scripts/modules/committers.py:
2888
2889 2009-08-20  Xan Lopez  <xlopez@igalia.com>
2890
2891         Reviewed by Gustavo Noronha.
2892
2893         Fix memory leaks.
2894
2895         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2896         (LayoutTestController::whiteListAccessFromOrigin):
2897         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2898         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2899
2900 2009-08-20  Eric Seidel  <eric@webkit.org>
2901
2902         Reviewed by Adam Barth.
2903
2904         bugzilla-tool post-diff can post partial diffs from SVN checkouts.
2905         https://bugs.webkit.org/show_bug.cgi?id=28445
2906
2907         Pass the checkout root as the cwd.  Also wrote a test to ensure this.
2908
2909         * Scripts/modules/scm.py:
2910         * Scripts/modules/scm_unittest.py:
2911
2912 2009-08-20  Mark Rowe  <mrowe@apple.com>
2913
2914         Reviewed by Adele Peterson.
2915
2916         Don't leak the JSStringRef returned by AccessibilityUIElement::attributeValue.
2917
2918         * DumpRenderTree/AccessibilityUIElement.cpp:
2919         (attributeValueCallback):
2920
2921 2009-08-20  Ariya Hidayat  <ariya.hidayat@nokia.com>
2922
2923         Unreviewed, build fix.
2924
2925         [Qt] The template-based qMax() compares two qreals.
2926
2927         * DumpRenderTree/qt/ImageDiff.cpp:
2928         (main):
2929
2930 2009-08-20  David Levin  <levin@chromium.org>
2931
2932         Reviewed by David Kilzer.
2933
2934         bugzilla-tool patch retrieval should handle 302 redirects.
2935         https://bugs.webkit.org/show_bug.cgi?id=28485
2936
2937         * Scripts/modules/scm.py: Pass the --location parameter to curl
2938         so that 302's are followed.
2939
2940 2009-08-20  Aaron Boodman  <aa@chromium.org>
2941
2942         One more speculative build for gtk.
2943
2944         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2945
2946 2009-08-20  Aaron Boodman  <aa@chromium.org>
2947
2948         Speculative build for gtk.
2949
2950         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2951         (LayoutTestController::whiteListAccessFromOrigin):
2952
2953 2009-08-20  Mark Rowe  <mrowe@apple.com>
2954
2955         Ignore some leaks that are known to originate from ImageIO.
2956
2957         * Scripts/run-webkit-tests:
2958
2959 2009-08-20  Aaron Boodman  <aa@chromium.org>
2960
2961         With David Levin.
2962
2963         Speculative build fix for qt.
2964
2965         * DumpRenderTree/qt/jsobjects.cpp:
2966         (LayoutTestController::whiteListAccessFromOrigin):
2967         * DumpRenderTree/qt/jsobjects.h:
2968
2969 2009-08-19  Mark Rowe  <mrowe@apple.com>
2970
2971         Reviewed by Dan Bernstein.
2972
2973         Fix <http://webkit.org/b/28484> Plug-in-related leaks seen on the build bot
2974
2975         Update check-for-global-initializers to accommodate the new uses of RefCountedLeakCounter in WebKit.
2976
2977         * Scripts/check-for-global-initializers:
2978
2979 2009-08-19  Aaron Boodman  <aa@chromium.org>
2980
2981         Reviewed by David Levin.
2982
2983         https://bugs.webkit.org/show_bug.cgi?id=24853: Provide a way for WebKit clients to
2984         specify a more granular policy for cross-origin XHR access.
2985
2986         * DumpRenderTree/LayoutTestController.cpp: Expose whiteListAccessFromOrigin() to layout tests.
2987         (whiteListAccessFromOriginCallback): Ditto.
2988         (LayoutTestController::staticFunctions): Ditto.
2989         * DumpRenderTree/LayoutTestController.h: Ditto.
2990         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Ditto.
2991         (LayoutTestController::whiteListAccessToOrigin): Ditto.
2992         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Ditto.
2993         (LayoutTestController::whiteListAccessFromOrigin): Ditto.
2994         * DumpRenderTree/qt/jsobjects.cpp: Ditto.
2995         (LayoutTestController::whiteListAccessFromOrigin): Ditto.
2996         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Stub out whiteListAccessFromOrigin().
2997         (LayoutTestController::whiteListAccessFromOrigin): Ditto.
2998         * DumpRenderTree/gtk/DumpRenderTree.cpp: Reset origin access lists before each test.
2999         (resetWebViewToConsistentStateBeforeTesting): Ditto.
3000         * DumpRenderTree/mac/DumpRenderTree.mm: Ditto.
3001         (resetWebViewToConsistentStateBeforeTesting): Ditto.
3002         * DumpRenderTree/qt/DumpRenderTree.cpp: Ditto.
3003         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Ditto.
3004
3005 2009-08-19  Mark Rowe  <mrowe@apple.com>
3006
3007         Rubber-stamped by Dan Bernstein.
3008
3009         Ignore some leaks that are known to originate from QTKit.
3010
3011         * Scripts/run-webkit-tests:
3012
3013 2009-08-19  Eric Seidel  <eric@webkit.org>
3014
3015         Reviewed by Adam Barth.
3016
3017         commit-queue/bugzilla-tool can get wedged if git is mid-rebase
3018         https://bugs.webkit.org/show_bug.cgi?id=28436
3019
3020         Make clean_working_directory cancel rebases too (even though that's a bit of a hack).
3021         This code will only ever be run when --force-clean is passed.
3022
3023         I also added a new unit test to make sure this code actually works. :)
3024
3025         * Scripts/modules/scm.py:
3026         * Scripts/modules/scm_unittest.py:
3027
3028 2009-08-19  Eric Seidel  <eric@webkit.org>
3029
3030         Reviewed by David Levin.
3031
3032         WebKit needs a changelogs.py to hold changelog-related code
3033         https://bugs.webkit.org/show_bug.cgi?id=28477
3034
3035         This is moving code and adding tests.  There was only one functional
3036         change (which was removing a trailing newline from the last_entry() result).
3037
3038         * Scripts/bugzilla-tool:
3039         * Scripts/modules/changelogs.py: Added.
3040         * Scripts/modules/changelogs_unittest.py: Added.
3041         * Scripts/run-webkit-unittests:
3042
3043 2009-08-20  Eric Seidel  <eric@webkit.org>
3044
3045         Reviewed by Adam Barth.
3046
3047         bugzilla-tool needs a way to ask build.webkit.org if the bots are passing
3048         https://bugs.webkit.org/show_bug.cgi?id=28222
3049
3050         Basic support for now.  This has been in testing for 24 hours now and worked great!
3051
3052         * Scripts/bugzilla-tool:
3053         * Scripts/modules/buildbot.py: Added.
3054         * Scripts/modules/buildbot_unittest.py: Added.
3055         * Scripts/run-webkit-unittests:
3056
3057 2009-08-19  Jan Michael Alonzo  <jmalonzo@webkit.org>
3058
3059         Reviewed by Gustavo Noronha.
3060
3061         [Gtk] Bump waitToDumpWatchdog interval to 15 seconds to match the
3062         default timeout used by run-webkit-tests. Mac and Win ports were
3063         recently bumped in http://trac.webkit.org/changeset/r47465.
3064
3065         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3066         (LayoutTestController::setWaitToDump):
3067
3068 2009-08-19  David D. Kilzer  <ddkilzer@webkit.org>
3069
3070         DumpRenderTreeSupport.pm: provide pre-generated swig source for Tiger
3071
3072         Reviewed by Mark Rowe.
3073
3074         Provide pre-generated swig source files for Tiger so it may
3075         benefit from the faster run-webkit-tests.
3076
3077         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm:
3078         Generated by swig.
3079         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c: Added.
3080         Generated by swig.
3081         (swig_type_info::SWIG_TypeNameComp):
3082         (swig_type_info::SWIG_TypeEquiv):
3083         (swig_type_info::SWIG_TypeRegisterTL):
3084         (swig_type_info::SWIG_TypeCheck):
3085         (swig_type_info::SWIG_TypeCast):
3086         (swig_type_info::SWIG_TypeDynamicCast):
3087         (swig_type_info::SWIG_TypeName):
3088         (swig_type_info::SWIG_TypePrettyName):
3089         (swig_type_info::SWIG_TypeQueryTL):
3090         (swig_type_info::SWIG_TypeClientDataTL):
3091         (swig_type_info::SWIG_PackData):
3092         (swig_type_info::SWIG_UnpackData):
3093         (swig_type_info::SWIG_PropagateClientDataTL):
3094         (swig_type_info::SWIG_PackVoidPtr):
3095         (swig_type_info::SWIG_UnpackVoidPtr):
3096         (swig_type_info::SWIG_PackDataName):
3097         (swig_type_info::SWIG_UnpackDataName):
3098         * DumpRenderTree/mac/PerlSupport/Makefile: Updated to build on
3099         Tiger using pre-generated files.
3100
3101 2009-08-18  Shinichiro Hamaji  <hamaji@chromium.org>
3102
3103         Reviewed by David Kilzer.
3104
3105         run-webkit-tests hangs when WebCore tries to log too much
3106         https://bugs.webkit.org/show_bug.cgi?id=15743
3107
3108         Read stdout and stderr in parallel.
3109
3110         * Scripts/run-webkit-tests:
3111
3112 2009-08-18  Mark Rowe  <mrowe@apple.com>
3113
3114         Rubber-stamped by Oliver Hunt.
3115
3116         Add a new build configuration that checks for leaks during the layout tests,
3117         and hook a new machine up to it.
3118
3119         * BuildSlaveSupport/build.webkit.org-config/config.json:
3120         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3121
3122 2009-08-18  Aaron Boodman  <aa@chromium.org>
3123
3124         Reviewed by Maciej Stachowiak.
3125
3126         https://bugs.webkit.org/show_bug.cgi?id=28412: Leak of WebCore::XMLHttpRequest object during layout tests.
3127
3128         No new tests: Already covered by existing tests.
3129
3130         * Scripts/check-for-global-initializers: Allow global initialization of WTF::RefCountedLeakCounter for XMLHttpRequest.
3131
3132 2009-08-18  Mark Rowe  <mrowe@apple.com>
3133
3134         Rubber-stamped by Geoff Garen.
3135
3136         Bump waitToDumpWatchdogInterval to 15 seconds to match the time-out used by run-webkit-tests.
3137
3138         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3139         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3140
3141 2009-08-18  Brian Weinstein  <bweinstein@apple.com>
3142
3143         Rubber-stamped by Adam Roben.
3144
3145         Changed use of CComBSTR in exceededDatabaseQuota to BSTRs, and free them,
3146         and removed include to fix building on VC++ Express.
3147
3148         * DumpRenderTree/win/UIDelegate.cpp:
3149         (UIDelegate::exceededDatabaseQuota):
3150
3151 2009-08-18  Brian Weinstein  <bweinstein@apple.com>
3152
3153         Reviewed by Oliver Hunt.
3154
3155         Fix of <https://bugs.webkit.org/show_bug.cgi?id=28326> DRT on Windows doesn't support 
3156         LayoutTestController::setQuota or print a callback on UIDelegate::exceededDatabaseQuota.
3157         
3158         Implemenent setDatabaseQuota and added a new function to the IWebDatabaseManager interface.
3159         Also added a console output on UIDelegate::exceededDatabaseQuota to match the mac.
3160
3161         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3162         (LayoutTestController::setDatabaseQuota):
3163         * DumpRenderTree/win/UIDelegate.cpp:
3164         (UIDelegate::exceededDatabaseQuota):
3165
3166 2009-08-18  Peter Kasting  <pkasting@google.com>
3167
3168         Reviewed by Eric Seidel.
3169
3170         https://bugs.webkit.org/show_bug.cgi?id=28415
3171         Set svn:eol-style CRLF on all .sln and .vcproj files that don't already
3172         have it.
3173
3174         * record-memory-win/record-memory-win.vcproj:
3175         * WinLauncher/WinLauncher.vcproj:
3176         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3177         * DumpRenderTree/win/ImageDiff.vcproj:
3178         * FindSafari/FindSafari.vcproj:
3179
3180 2009-08-18  Drew Wilson  <atwilson@google.com>
3181
3182         Reviewed by Eric Seidel.
3183
3184         Need to extend DumpRenderTree to expose number of worker threads
3185         https://bugs.webkit.org/show_bug.cgi?id=28292
3186
3187         Added layoutTestController.workerThreadCount, and implementations on various platforms that call into WebKit.
3188
3189         * DumpRenderTree/LayoutTestController.cpp:
3190         (getWorkerThreadCountCallback):
3191         (LayoutTestController::staticValues):
3192         * DumpRenderTree/LayoutTestController.h:
3193         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3194         (LayoutTestController::workerThreadCount):
3195         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3196         (LayoutTestController::workerThreadCount):
3197         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3198         (LayoutTestController::workerThreadCount):
3199         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3200         (LayoutTestController::workerThreadCount):
3201
3202 2009-08-18  Xan Lopez  <xlopez@igalia.com>
3203
3204         Reviewed by Jan Alonzo.
3205
3206         Initialize x and y in the GtkAllocation structure to shut up
3207         valgrind.
3208
3209         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3210         (runTest):
3211
3212 2009-08-17  Shinichiro Hamaji  <hamaji@chromium.org>
3213
3214         Reviewed by Darin Adler.
3215
3216         Some HTMLs are modified by make-script-test-wrappers
3217         https://bugs.webkit.org/show_bug.cgi?id=28213
3218
3219         Add fast/js/const.js and fast/canvas/canvas-2d-imageData-create-nonfinite.js into
3220         the exclude list, modified fast/dom/Geolocation/resources/TEMPLATE.html, and
3221         re-generated wml/* and Geolocation/* .
3222
3223         * Scripts/make-script-test-wrappers:
3224
3225 2009-08-17  Shinichiro Hamaji  <hamaji@chromium.org>
3226
3227         Reviewed by Eric Seidel.
3228
3229         -webkit-box-orient:horizontal doesn't work on <button> tag
3230         https://bugs.webkit.org/show_bug.cgi?id=34445
3231
3232         Make a flexible button's anonymous child flexible and pass the
3233         parent's box-orient to the anonymous child.
3234
3235         Also, added a renderName for anonymous flexible boxes.
3236
3237         * Scripts/make-script-test-wrappers:
3238
3239 2009-08-17  Eric Seidel  <eric@webkit.org>
3240
3241         Reviewed by Darin Adler.
3242
3243         Can no longer --reset-results of a layout test directory
3244         https://bugs.webkit.org/show_bug.cgi?id=28336
3245
3246         --reset-results and --exit-after-n-failures are incompatible.
3247
3248         * Scripts/run-webkit-tests:
3249
3250 2009-08-17  David Kilzer  <ddkilzer@apple.com>
3251
3252         <http://webkit.org/b/26920> bugzilla-tool dumps too much junk the the commit comment from git
3253
3254         Reviewed by Adam Roben.
3255
3256         New commit message:
3257             Committed r12345: <http://trac.webkit.org/changeset/12345>
3258
3259         * Scripts/bugzilla-tool:
3260         (bug_comment_from_commit_text): Print out a compact,
3261         standardized commit message for both git and svn.
3262
3263 2009-08-17  Peter Kasting  <pkasting@google.com>
3264
3265         Reviewed by Steve Falkenburg.
3266
3267         https://bugs.webkit.org/show_bug.cgi?id=27323
3268         Only add Cygwin to the path when it isn't already there.  This avoids
3269         causing problems for people who purposefully have non-Cygwin versions of
3270         executables like svn in front of the Cygwin ones in their paths.
3271
3272         * DumpRenderTree/win/DumpRenderTree.vcproj:
3273         * DumpRenderTree/win/ImageDiff.vcproj:
3274         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3275
3276 2009-08-17  David Kilzer  <ddkilzer@apple.com>
3277
3278         <http://webkit.org/b/28393> check-webkit-style: add check for use of std::max()/std::min() instead of MAX()/MIN()
3279
3280         Reviewed by David Levin.
3281
3282         * Scripts/modules/cpp_style.py:
3283         (_ERROR_CATEGORIES): Added 'runtime/max_min_macros'.
3284         (check_max_min_macros): Added.  Returns level 4 error when MAX()
3285         and MIN() macros are used in header files and C++ source files.
3286         (check_style): Added call to check_max_min_macros().
3287         * Scripts/modules/cpp_style_unittest.py: Added unit tests.
3288         (test_max_macro): Added.
3289         (test_min_macro): Added.
3290
3291 2009-08-13  Mike Fenton  <mike.fenton@torchmobile.com>
3292
3293         Reviewed by Eric Seidel.
3294
3295         Move adjustLineToPixelBoundaries overlapping function to GraphicsContext.cpp
3296         and remove from GraphicsContextCairo.cpp and GraphicsContextQt.cpp.
3297
3298         https://bugs.webkit.org/show_bug.cgi?id=28268
3299
3300         * platform/graphics/GraphicsContext.cpp:
3301         (WebCore::GraphicsContext::adjustLineToPixelBoundaries):
3302         * platform/graphics/GraphicsContext.h:
3303         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3304         * platform/graphics/qt/GraphicsContextQt.cpp:
3305
3306 2009-08-10  Mike Fenton  <mike.fenton@torchmobile.com>
3307
3308         Reviewed by Adam Treat.
3309
3310         Style fixes for DumpRenderTree/qt/jsobjects.cpp based on cpp_style.py and
3311         WebKit style guide.
3312
3313         https://bugs.webkit.org/show_bug.cgi?id=28161
3314
3315         * DumpRenderTree/qt/jsobjects.cpp:
3316         (findFrameNamed):
3317         (LoadItem::invoke):
3318         (LayoutTestController::provisionalLoad):
3319         (LayoutTestController::timerEvent):
3320         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3321         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3322         (LayoutTestController::numberOfActiveAnimations):
3323         (EventSender::keyDown):
3324         (EventSender::frameUnderMouse):
3325         (TextInputController::doCommand):
3326
3327 2009-08-16  David Kilzer  <ddkilzer@apple.com>
3328
3329         <http://webkit.org/b/28370> check-webkit-style: add check for 'using std::foo;' statements
3330
3331         Reviewed by David Levin.
3332
3333         In <http://webkit.org/b/28355#c1>, it was noted that new source
3334         files use 'using namespace std;' instead of individual
3335         'using std::foo;' statements.  This adds a level 4 check for
3336         such statements.
3337
3338         * Scripts/modules/cpp_style.py:
3339         (_ERROR_CATEGORIES): Added 'build/using_std'.
3340         (check_using_std): Added.
3341         (check_style): Added call to check_using_std().
3342         * Scripts/modules/cpp_style_unittest.py:
3343         (WebKitStyleTest.test_using_std): Added unit test.
3344
3345 2009-08-16  David Kilzer  <ddkilzer@apple.com>
3346
3347         Backed out r47343 which was mistakenly committed
3348
3349         * Scripts/bugzilla-tool:
3350         * Scripts/modules/scm.py:
3351
3352 2009-08-16  David Kilzer  <ddkilzer@apple.com>
3353
3354         <http://webkit.org/b/28367> bugzilla.py: replace ScriptError class with BugzillaError class
3355
3356         Reviewed by David Levin.
3357
3358         The ScriptError class doesn't exist in bugzilla.py, so any
3359         errors print error messages about ScriptError instead of the
3360         actual error:
3361
3362             NameError: global name 'ScriptError' is not defined
3363
3364         * Scripts/modules/bugzilla.py:
3365         (BugzillaError): Added class.  Modeled after ScriptError class
3366         in scm.py.
3367         (Bugzilla.authenticate): Changed to use BugzillaError instead of
3368         ScriptError.
3369         (Bugzilla._check_create_bug_response): Ditto.
3370
3371 2009-08-14  Adam Bergkvist  <adam.bergkvist@ericsson.com>
3372
3373         Reviewed by Sam Weinig.
3374
3375         Added EventSource to the build script (default on).
3376         https://bugs.webkit.org/show_bug.cgi?id=14997 
3377
3378         * Scripts/build-webkit:
3379
3380 2009-08-15  Ryosuke Niwa  <rniwa@webkit.org>
3381
3382         Unreviewed.
3383
3384         Add myself to list of committers.
3385
3386         * Scripts/modules/committers.py:
3387
3388 2009-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
3389
3390         Fix layout test failures after r47312.
3391
3392         Reviewed by Cameron Zwarich.
3393
3394         * DumpRenderTree/AccessibilityController.h:
3395         Replaced logFocusEvents() with setLogFocusEvents(), which takes a
3396         boolean argument to turn logging of focus events on or off.
3397         Added a function to reset the AccessibilityController to a consistent
3398         state.
3399
3400         * DumpRenderTree/AccessibilityController.cpp:
3401         (logFocusEventsCallback):
3402         Call setLogFocusEvents() to enable logging.
3403         (AccessibilityController::resetToConsistentState):
3404         Call setLogFocusEvents() to disable logging.
3405
3406         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3407         (AccessibilityController::setLogFocusEvents):
3408         Update stub.
3409
3410         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3411         (AccessibilityController::setLogFocusEvents):
3412         Update stub.
3413
3414         * DumpRenderTree/mac/DumpRenderTree.mm:
3415         (resetWebViewToConsistentStateBeforeTesting):
3416         Call the FrameLoadDelegate's resetToConsistentState method.
3417
3418         * DumpRenderTree/mac/FrameLoadDelegate.h:
3419         Declare the resetToConsistentState method.
3420
3421         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3422         (-[FrameLoadDelegate resetToConsistentState]):
3423         Call the AccessibilityController's resetToConsistentState() function.
3424
3425         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3426         (AccessibilityController::~AccessibilityController):
3427         Turn off focus event logging when the controller is destroyed.
3428         (AccessibilityController::setLogFocusEvents):
3429         If the caller passes false, unhook the focus event, and clear
3430         m_focusEventHook.
3431
3432         * DumpRenderTree/win/DumpRenderTree.cpp:
3433         (resetWebViewToConsistentStateBeforeTesting):
3434         Call the FrameLoadDelegate's resetToConsistentState function.
3435
3436         * DumpRenderTree/win/FrameLoadDelegate.h:
3437         Declare the resetToConsistentState() function.
3438
3439         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3440         (FrameLoadDelegate::resetToConsistentState):
3441         Call the AccessibilityController's resetToConsistentState() function.
3442
3443
3444 2009-08-14  Jon Honeycutt  <jhoneycutt@apple.com>
3445
3446         Add a mechanism for logging MSAA focus events.
3447
3448         Part of <rdar://problem/6218721> No MSAA focus events fired for Webkit
3449         nightly (20866)
3450
3451         https://bugs.webkit.org/show_bug.cgi?id=20866
3452
3453         Reviewed by Oliver Hunt.
3454
3455         * DumpRenderTree/AccessibilityController.cpp:
3456         (logFocusEventsCallback):
3457         Call the AccessibilityController's logFocusEvents() function.
3458         (AccessibilityController::getJSClass):
3459         Add a "logFocusEvents" function to the AccessibilityController's JS
3460         class definition.
3461
3462         * DumpRenderTree/AccessibilityController.h:
3463         On Windows, include windows.h, and add a member variable to hold the
3464         handle to the event hook for focus events. Add a declaration for a
3465         function that enables logging of focus events.
3466
3467         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3468         (AccessibilityController::logFocusEvents):
3469         Stubbed.
3470
3471         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3472         (AccessibilityController::logFocusEvents):
3473         Stubbed.
3474
3475         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3476         (AccessibilityController::AccessibilityController):
3477         (AccessibilityController::~AccessibilityController):
3478         If we hooked the focus event, unhook it.
3479         (logFocusEventProc):
3480         When we receive a focus event, get the accessible object for the event,
3481         and log its name to stdout.
3482         (AccessibilityController::logFocusEvents):
3483         Setup the focus event hook to listen for events in the current process.
3484
3485 2009-08-14  Eric Seidel  <eric@webkit.org>
3486
3487         No review.  Fix 5-space indent to be 4-spaces.
3488
3489         * Scripts/bugzilla-tool:
3490
3491 2009-08-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3492
3493         Reviewed by Simon Hausmann.
3494
3495         [Qt] Public API to configure the storage path for HTML5 localStorage
3496         https://bugs.webkit.org/show_bug.cgi?id=28036
3497
3498         Turn on LocalStorage support for Qt DumpRenderTree since
3499         LocalStorage is now disabled by defult for QtWebkit.
3500
3501         * DumpRenderTree/qt/DumpRenderTree.cpp: 
3502         (WebCore::WebPage::WebPage):
3503
3504 2009-08-14  Xan Lopez  <xlopez@igalia.com>
3505
3506         Reviewed by Jan Alonzo.
3507
3508         Do not unref the main webview, it's owned by its parent
3509         container. Instead destroy the container, which should take care
3510         of everything (not terribly important since we exit right after
3511         that, but still).
3512
3513         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3514         (main):
3515
3516 2009-08-13  Eric Seidel  <eric@webkit.org>
3517
3518         No review, correcting obvious python error seen in the commit queue.
3519
3520         args can be a string or an array.  Assuming args is always an array results in
3521         double-spaced text in error logs.
3522
3523         * Scripts/bugzilla-tool:
3524
3525 2009-08-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3526
3527         Unreviewed build fix. Include stdio.h for using stdout, stderr,
3528         and fprintf.
3529
3530         * DumpRenderTree/LayoutTestController.cpp:
3531
3532 2009-08-13  Shinichiro Hamaji  <hamaji@chromium.org>
3533
3534         Reviewed by Eric Seidel.
3535
3536         rename make-js-test-wrappers to make-script-test-wrappers
3537         https://bugs.webkit.org/show_bug.cgi?id=28212
3538
3539         * Scripts/make-script-test-wrappers: Renamed from WebKitTools/Scripts/make-js-test-wrappers.
3540
3541 2009-08-13  Drew Wilson <atwilson@chromium.org>
3542
3543         Unreviewed.
3544
3545         Add myself to list of committers.
3546
3547         * Scripts/modules/committers.py:
3548
3549 2009-08-13  John Sullivan  <sullivan@apple.com>
3550
3551         Unreviewed.
3552
3553         Add myself to list of committers.
3554
3555         * Scripts/modules/committers.py:
3556
3557 2009-08-13  Eric Seidel  <eric@webkit.org>
3558
3559         Correct spelling error in file name.  No review.
3560
3561         * Scripts/modules/committers_unittest.py: Renamed from WebKitTools/Scripts/modules/commiters_unittest.py.
3562         * Scripts/run-webkit-unittests:
3563
3564 2009-08-13  Eric Seidel  <eric@webkit.org>
3565
3566         Reviewed by Simon Fraser.
3567
3568         REGRESSION(r47175): error running run-webkit-tests
3569         https://bugs.webkit.org/show_bug.cgi?id=28261
3570
3571         Fix "Use of uninitialized value in concatenation (.) or string at
3572         WebKitTools/Scripts/run-webkit-tests line 191." by setting
3573         $testsPerDumpTool to 1000 by default.
3574
3575         * Scripts/run-webkit-tests:
3576
3577 2009-08-13  Nate Chapin  <japhet@chromium.org>
3578
3579         Unreviewed.
3580
3581         Add myself to list of committers.
3582
3583         * Scripts/modules/committers.py:
3584
3585 2009-08-13  Brent Fulgham  <bfulgham@webkit.org>
3586
3587         Unreviewed.
3588
3589         Add 'Brent Fulgham' to the committers list.
3590
3591         * Scripts/modules/committers.py:
3592
3593 2009-08-13  Adam Langley  <agl@chromium.org>
3594
3595         Review not required.
3596
3597         * Scripts/modules/committers.py:
3598           Adding myself to this list because Eric told me to.
3599
3600 2009-08-13  Greg Bolsinga  <bolsinga@apple.com>
3601
3602         Unreviewed.
3603
3604         Add 'Greg Bolsinga' to the committers list.
3605
3606         * Scripts/modules/committers.py:
3607
3608 2009-08-13  Adam Roben  <aroben@apple.com>
3609
3610         Fix off-by-one result comparisons in media tests on Windows Debug
3611         builds
3612
3613         media/video-played.html seems always to time out in Windows Debug
3614         builds. A race condition between media/video-test.js's "hang" timer and
3615         DumpRenderTree's built-in "watchdog" timer was causing results for
3616         media/video-played.html to be printed twice, causing all future media
3617         tests to be compared to the previous test's results.
3618
3619         The fix is to make the watchdog timer got through the same code path
3620         as calling notifyDone manually, so that the results will only get
3621         printed once. A subsequent patch will remove video-test.js's hang
3622         timer entirely, since it is redundant.
3623
3624         Fixes <http://webkit.org/b/28265>.
3625
3626         Reviewed by Mark Rowe.
3627
3628         * DumpRenderTree/LayoutTestController.cpp:
3629         (LayoutTestController::waitToDumpWatchdogTimerFired): Added. Code came
3630         from Gtk/Mac/Win's watchdog timer handlers, but we now call
3631         notifyDone() instead of dump() so that a subsequent call to
3632         notifyDone() won't print the results out again.
3633
3634         * DumpRenderTree/LayoutTestController.h: Added
3635         waitToDumpWatchdogTimerFired.
3636
3637         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3638         (waitToDumpWatchdogFired):
3639         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3640         (waitUntilDoneWatchdogFired):
3641         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3642         (waitUntilDoneWatchdogFired):
3643         Changed to call waitToDumpWatchdogTimerFired.
3644
3645 2009-08-13  Eric Carlson  <eric.carlson@apple.com>
3646
3647         Unreviewed.