WebKitTools/ChangeLog

   1 2009-11-22  Chris Evans  <cevans@chromium.org>
   2
   3         Reviewed by Adam Barth.
   4
   5         Disable access to file:/// directory listings
   6         https://bugs.webkit.org/show_bug.cgi?id=31329
   7
   8         Implemented setAllowUniversalAccessFromFileURLs to support testing of
   9         file URL security.
  10
  11         * DumpRenderTree/LayoutTestController.cpp:
  12         (setAllowUniversalAccessFromFileURLsCallback):
  13         (LayoutTestController::staticFunctions):
  14         * DumpRenderTree/LayoutTestController.h:
  15         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  16         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
  17         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  18         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
  19         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  20         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
  21         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  22         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
  23
  24 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
  25
  26         Reviewed by Kenneth Rohde Christiansen.
  27
  28         [Qt] Fix the timeout of fast/frames/frame-navigation.html
  29         https://bugs.webkit.org/show_bug.cgi?id=31638
  30
  31         The test is timeouting, because it uses the WorkQueue to load a document in one
  32         of the child frames and once the loading is finished, the DRT does not dump the
  33         tree. This is because it waits for the QWebFrame::loadFinished() signal from
  34         the main frame, while it should connect to QWebPage::loadFinished().
  35
  36         * DumpRenderTree/qt/DumpRenderTree.cpp:
  37         (WebCore::DumpRenderTree::DumpRenderTree):
  38
  39 2009-11-21  Eric Seidel  <eric@webkit.org>
  40
  41         Reviewed by Adam Barth.
  42
  43         bugzilla-tool --help spews way too much text
  44         https://bugs.webkit.org/show_bug.cgi?id=31771
  45
  46         * Scripts/bugzilla-tool:
  47          - Remove self.cached_scm initialization hack.
  48         * Scripts/modules/buildbot.py:
  49          - Make default_host accessible to callers.
  50         * Scripts/modules/commands/download.py:
  51          - Phrase help for all commands consistently and remove spurious help text punctuation.
  52         * Scripts/modules/commands/queries.py: Ditto.
  53         * Scripts/modules/commands/queues.py: Ditto.
  54         * Scripts/modules/commands/upload.py: Ditto.
  55         * Scripts/modules/multicommandtool.py:
  56          - Add HelpPrintingOptionParser.format_epilog to replace
  57            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
  58            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
  59          - Make --help only show a list of commands like "svn help" and "git help" do --
  60            previously --help was listing all commands and options.
  61          - Sort list of commands alphabetically.
  62
  63 2009-11-21  Eric Seidel  <eric@webkit.org>
  64
  65         No review.  Fixing a typo from the previous patch for bug 31767.
  66
  67         AbstractQueue.run_bugzilla_tool throws an exception
  68         https://bugs.webkit.org/show_bug.cgi?id=31769
  69
  70         * Scripts/modules/commands/queues.py:
  71
  72 2009-11-21  Eric Seidel  <eric@webkit.org>
  73
  74         Reviewed by Adam Barth.
  75
  76         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
  77         https://bugs.webkit.org/show_bug.cgi?id=31767
  78
  79         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
  80         Since we don't have a good way to test BugzillaTool pieces, I've
  81         left out a test for now.
  82
  83         * Scripts/bugzilla-tool:
  84          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
  85         * Scripts/modules/commands/queues.py:
  86          - Use tool.path() instead of __file__.
  87         * Scripts/modules/multicommandtool.py:
  88          - Add a new path() method to MultiComandTool.
  89         * Scripts/modules/multicommandtool_unittest.py:
  90          - Provide a path() method.  Little point in testing this mock implementation.
  91
  92 2009-11-21  Adam Barth  <abarth@webkit.org>
  93
  94         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
  95         WebKitTools.
  96
  97         * Scripts/modules/commands/download.py:
  98
  99 2009-11-21  Adam Barth  <abarth@webkit.org>
 100
 101         Reviewed by Eric Seidel.
 102
 103         Convert check-style to use LandingSequence
 104         https://bugs.webkit.org/show_bug.cgi?id=31763
 105
 106         Instead of manipulating the working copy by hand, we should use the
 107         LandingSequence in CheckStyle.  This will make this code eaiser to
 108         test.
 109
 110         * Scripts/modules/commands/download.py:
 111
 112 2009-11-20  Adam Barth  <abarth@webkit.org>
 113
 114         Reviewed by Eric Seidel.
 115
 116         Unit test query commands
 117         https://bugs.webkit.org/show_bug.cgi?id=31755
 118
 119         These tests are pretty rough, but hopefully they'll grow.
 120
 121         * Scripts/modules/commands/queries_unittest.py: Added.
 122         * Scripts/modules/mock_bugzillatool.py: Added.
 123         * Scripts/run-webkit-unittests:
 124
 125 2009-11-20  Eric Seidel  <eric@webkit.org>
 126
 127         Reviewed by Adam Barth.
 128
 129         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
 130         https://bugs.webkit.org/show_bug.cgi?id=31758
 131
 132         * Scripts/modules/multicommandtool.py:
 133          - Allow passing of explicit commands to MultiCommandTool.__init__
 134         * Scripts/modules/multicommandtool_unittest.py:
 135          - Use new Command.name naming system.
 136          - Test Command auto-discovery.
 137         * Scripts/modules/workqueue.py:
 138          - bug_id no longer exists, use patch['bug_id'] instead.
 139         * Scripts/modules/workqueue_unittest.py:
 140          - WorkQueues require names now.
 141          - should_proceed_with_work_item must return a patch object.
 142
 143 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
 144
 145         Reviewed by Beth Dakin.
 146
 147         WAI-ARIA: add support for aria-owns
 148         https://bugs.webkit.org/show_bug.cgi?id=31702
 149
 150         * DumpRenderTree/AccessibilityUIElement.cpp:
 151         (ariaOwnsElementAtIndexCallback):
 152         (AccessibilityUIElement::getJSClass):
 153         * DumpRenderTree/AccessibilityUIElement.h:
 154         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 155         (AccessibilityUIElement::ariaOwnsElementAtIndex):
 156         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 157         (AccessibilityUIElement::ariaOwnsElementAtIndex):
 158         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
 159         (AccessibilityUIElement::ariaOwnsElementAtIndex):
 160
 161 2009-11-20  Eric Seidel  <eric@webkit.org>
 162
 163         Reviewed by Adam Barth.
 164
 165         Fix exception thrown when running the commit-queue.
 166
 167         * Scripts/modules/statusbot.py: patch is optional.
 168         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
 169
 170 2009-11-20  Eric Seidel  <eric@webkit.org>
 171
 172         Reviewed by Adam Barth.
 173
 174         Teach the StatusBot how to support more than just the commit-queue
 175         https://bugs.webkit.org/show_bug.cgi?id=31754
 176
 177         * Scripts/modules/workqueue.py: Another typo.
 178
 179 2009-11-20  Eric Seidel  <eric@webkit.org>
 180
 181         Reviewed by Adam Barth.
 182
 183         Teach the StatusBot how to support more than just the commit-queue
 184         https://bugs.webkit.org/show_bug.cgi?id=31754
 185
 186         * Scripts/modules/commands/queues.py: Fix silly typo.
 187
 188 2009-11-20  Eric Seidel  <eric@webkit.org>
 189
 190         Reviewed by Adam Barth.
 191
 192         Teach the StatusBot how to support more than just the commit-queue
 193         https://bugs.webkit.org/show_bug.cgi?id=31754
 194
 195         * CommitQueueStatus/index.yaml:
 196          - Add indices required for the new queries.
 197         * CommitQueueStatus/queue_status.py:
 198          - Add a patch-status page and move update_status to update-status.
 199          - Only display "commit-queue" status records for the commit-queue.
 200          - Add support for a queue_name property on status records.
 201          - Fix _int_from_request to actually work.
 202         * CommitQueueStatus/update_status.html:
 203          - Add support for a queue_name on status records.
 204          - Remove unused list of bug ids.
 205          * Scripts/modules/commands/queues.py
 206           - Make the queues pass the patch instead of the bug_id to StatusBot.
 207         * Scripts/modules/statusbot.py:
 208          - Support passing the queue_name to the status updates.
 209          - Support fetching patch status with patch_status().
 210         * Scripts/modules/workqueue.py:
 211          - Pass the patch to the StatusBot instead of the bug_id.
 212          - Let WorkQueues have a name.
 213
 214 2009-11-20  Adam Barth  <abarth@webkit.org>
 215
 216         Reviewed by Eric Seidel.
 217
 218         Move bugzilla-tool commands into their own file
 219         https://bugs.webkit.org/show_bug.cgi?id=31752
 220
 221         This will let us write unit tests.
 222
 223         * Scripts/bugzilla-tool:
 224         * Scripts/modules/commands/__init__.py: Added.
 225         * Scripts/modules/commands/download.py: Added.
 226         * Scripts/modules/commands/queries.py: Added.
 227         * Scripts/modules/commands/queues.py: Added.
 228         * Scripts/modules/commands/upload.py: Added.
 229         * Scripts/modules/grammar.py: Added.
 230
 231 2009-11-20  Adam Barth  <abarth@webkit.org>
 232
 233         Reviewed by Eric Seidel.
 234
 235         BuildQueue should check if the tree is currently buildable
 236         https://bugs.webkit.org/show_bug.cgi?id=31744
 237
 238         * Scripts/bugzilla-tool:
 239         * Scripts/modules/landingsequence.py:
 240         * Scripts/modules/webkitlandingscripts.py:
 241
 242 2009-11-20  Adam Barth  <abarth@webkit.org>
 243
 244         Reviewed by Eric Seidel.
 245
 246         Move prepare_clean_working_directory into the LandingSequence
 247         https://bugs.webkit.org/show_bug.cgi?id=31743
 248
 249         * Scripts/bugzilla-tool:
 250         * Scripts/modules/landingsequence.py:
 251
 252 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
 253
 254         Reviewed by Kenneth Rohde Christiansen.
 255
 256         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
 257         https://bugs.webkit.org/show_bug.cgi?id=30460
 258
 259         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
 260
 261         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
 262         (pluginInvoke):
 263
 264 2009-11-20  Adam Barth  <abarth@webkit.org>
 265
 266         Reviewed by Eric Seidel.
 267
 268         Pass the port information to the child process
 269         https://bugs.webkit.org/show_bug.cgi?id=31736
 270
 271         We need to do this so the child process knows what to build!
 272
 273         * Scripts/bugzilla-tool:
 274         * Scripts/modules/landingsequence.py:
 275         * Scripts/modules/webkitport.py:
 276         * Scripts/modules/webkitport_unittest.py:
 277
 278 2009-11-20  Adam Barth  <abarth@webkit.org>
 279
 280         Reviewed by Eric Seidel.
 281
 282         Support Qt port in build-queue
 283         https://bugs.webkit.org/show_bug.cgi?id=31733
 284
 285         * Scripts/bugzilla-tool:
 286
 287 2009-11-20  Adam Barth  <abarth@webkit.org>
 288
 289         Reviewed by Eric Seidel.
 290
 291         Implement a build-queue
 292         https://bugs.webkit.org/show_bug.cgi?id=31725
 293
 294         Currently this just builds the first 10 patches in the review queue.
 295         We'll want to do something smarter soon.
 296
 297         * Scripts/bugzilla-tool:
 298
 299 2009-11-20  Adam Barth  <abarth@webkit.org>
 300
 301         Reviewed by Eric Seidel.
 302
 303         Make commit-queue and style-queue show up in help
 304         https://bugs.webkit.org/show_bug.cgi?id=31724
 305
 306         We need to store their names on their class to make these commands
 307         properly register themselves with MultiCommandTool.
 308
 309         * Scripts/bugzilla-tool:
 310
 311 2009-11-20  Adam Barth  <abarth@webkit.org>
 312
 313         Reviewed by Eric Seidel.
 314
 315         Implement bugzilla-tool build-attachment
 316         https://bugs.webkit.org/show_bug.cgi?id=31722
 317
 318         This command builds an attachment from bugzilla.  It leaves the built
 319         patch in the working copy.
 320
 321         * Scripts/bugzilla-tool:
 322         * Scripts/modules/landingsequence.py:
 323         * Scripts/modules/webkitlandingscripts.py:
 324
 325 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
 326
 327         Reviewed by Xan Lopez.
 328
 329         [GTK] DRT release event does not create the state correctly
 330         https://bugs.webkit.org/show_bug.cgi?id=31717
 331
 332         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
 333
 334 2009-11-20  Eric Seidel  <eric@webkit.org>
 335
 336         Reviewed by Adam Barth.
 337
 338         MultiCommandTool should find Command objects automatically instead of with a manual list
 339         https://bugs.webkit.org/show_bug.cgi?id=31710
 340
 341         * Scripts/bugzilla-tool:
 342         * Scripts/modules/multicommandtool.py:
 343          - Use some wild python-fu to crawl all the known subclasses of Command.
 344
 345 2009-11-20  Adam Barth  <abarth@webkit.org>
 346
 347         Unreviewed "build" fix.  Added missing import.
 348
 349         * Scripts/bugzilla-tool:
 350
 351 2009-11-20  Adam Barth  <abarth@webkit.org>
 352
 353         Unreviewed "build" fix.  I failed to update LandingSequence.test
 354         properly.
 355
 356         * Scripts/modules/landingsequence.py:
 357
 358 2009-11-20  Adam Barth  <abarth@webkit.org>
 359
 360         Reviewed by Eric Seidel.
 361
 362         Create LandingSequence as the all-sing, all-dance landing class
 363         https://bugs.webkit.org/show_bug.cgi?id=31709
 364
 365         Client can inherit from this class to carefully control exactly which
 366         steps they wish to have happen in the landing sequence.
 367
 368         * Scripts/bugzilla-tool:
 369         * Scripts/modules/landingsequence.py: Added.
 370         * Scripts/modules/webkitlandingscripts.py: Added.
 371
 372 2009-11-19  Adam Barth  <abarth@webkit.org>
 373
 374         Reviewed by Eric Seidel.
 375
 376         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
 377         https://bugs.webkit.org/show_bug.cgi?id=31707
 378
 379         This is to help when we implement build-attachment.
 380
 381         * Scripts/bugzilla-tool:
 382
 383 2009-11-19  Adam Barth  <abarth@webkit.org>
 384
 385         Reviewed by Eric Seidel.
 386
 387         Support Qt port in bugzilla-tool
 388         https://bugs.webkit.org/show_bug.cgi?id=31701
 389
 390         Now we support building with Qt!
 391
 392         * Scripts/bugzilla-tool:
 393         * Scripts/modules/webkitport.py: Added.
 394         * Scripts/modules/webkitport_unittest.py: Added.
 395         * Scripts/run-webkit-unittests:
 396
 397 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
 398
 399         Reviewed by Adam Barth.
 400
 401         Remove inserting stderr into patch in bugzilla-tool
 402         https://bugs.webkit.org/show_bug.cgi?id=29914
 403
 404         Modify SCM python module's run_command function to avoid return of stderr
 405         by default, so stderr won't be inserted into the patches.
 406         Modify the related unit test.
 407
 408         * Scripts/modules/scm.py:
 409         * Scripts/modules/scm_unittest.py:
 410
 411 2009-11-19  Eric Seidel  <eric@webkit.org>
 412
 413         Reviewed by Adam Barth.
 414
 415         bugzilla-tool needs per-command help
 416         https://bugs.webkit.org/show_bug.cgi?id=31697
 417
 418         Added support for "bugzilla-tool help command-name"
 419         and a unit test to make sure it works.
 420
 421         * Scripts/modules/multicommandtool.py:
 422         * Scripts/modules/multicommandtool_unittest.py:
 423
 424 2009-11-19  Eric Seidel  <eric@webkit.org>
 425
 426         Reviewed by Adam Barth.
 427
 428         Move MultiCommandTool and Command into a separate file and add some basic unit tests
 429         https://bugs.webkit.org/show_bug.cgi?id=31695
 430
 431         * Scripts/bugzilla-tool:
 432         * Scripts/modules/multicommandtool.py: Added.
 433         * Scripts/modules/multicommandtool_unittest.py: Added.
 434         * Scripts/run-webkit-unittests:
 435
 436 2009-11-19  Eric Seidel  <eric@webkit.org>
 437
 438         No review, just adding a FIXME.
 439
 440         Split out command parsing and help printing from BugzillaTool
 441         https://bugs.webkit.org/show_bug.cgi?id=31688
 442
 443         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
 444
 445 2009-11-19  Eric Seidel  <eric@webkit.org>
 446
 447         Reviewed by Adam Barth.
 448
 449         Split out command parsing and help printing from BugzillaTool
 450         https://bugs.webkit.org/show_bug.cgi?id=31688
 451
 452         * Scripts/bugzilla-tool:
 453          - Add new MultiCommandTool class to contain option parsing and help printing logic.
 454          - Rename private methods to use _ pattern.
 455          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
 456          -
 457
 458 2009-11-19  Eric Seidel  <eric@webkit.org>
 459
 460         Reviewed by Adam Barth.
 461
 462         Re-factor help printing to use modern python idioms
 463         https://bugs.webkit.org/show_bug.cgi?id=31685
 464
 465         * Scripts/bugzilla-tool:
 466
 467 2009-11-19  Eric Seidel  <eric@webkit.org>
 468
 469         Reviewed by Darin Adler.
 470
 471         commit-queue empty queue logs twice
 472         https://bugs.webkit.org/show_bug.cgi?id=31679
 473
 474         * Scripts/bugzilla-tool:
 475
 476 2009-11-19  Eric Seidel  <eric@webkit.org>
 477
 478         Reviewed by Darin Adler.
 479
 480         bugzilla-tool's reviewer/committer rejection message should be clearer
 481         https://bugs.webkit.org/show_bug.cgi?id=31126
 482
 483         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
 484
 485         * Scripts/modules/bugzilla.py:
 486
 487 2009-11-19  Eric Z. Ayers  <zundel@google.com>
 488
 489         Reviewed by Pavel Feldman.
 490
 491         Forces a WM_PAINT event on calling layoutTestController.display()
 492         in order to enable the timeline-paint.html test on Windows.
 493         ::UpdateWindow() does not force an event becaue the window is
 494         not visible.
 495
 496         https://bugs.webkit.org/show_bug.cgi?id=31402
 497
 498         * DumpRenderTree/win/DumpRenderTree.cpp:
 499         (displayWebView):
 500
 501 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
 502
 503         No review needed.
 504
 505         Added myself to committers list.
 506
 507         * Scripts/modules/committers.py:
 508
 509 2009-11-19  Adam Barth  <abarth@webkit.org>
 510
 511         Reviewed by Eric Seidel.
 512
 513         Bugzilla-tool command classes should match command names
 514         https://bugs.webkit.org/show_bug.cgi?id=31666
 515
 516         I renamed all the commands except CommitMessageForCurrentDiff because
 517         the new name would conflict with an existing class.
 518
 519         * Scripts/bugzilla-tool:
 520
 521 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
 522
 523         Reviewed by Gustavo Noronha Silva.
 524
 525         Web Inspector: Implement "show inspector" in WebKit GTK
 526         API and enable console tests.
 527
 528         https://bugs.webkit.org/show_bug.cgi?id=31669
 529
 530         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 531         (LayoutTestController::showWebInspector):
 532
 533 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 534
 535         Reviewed by Simon Hausmann.
 536
 537         Minor refactoring + more documentation.
 538
 539         * DumpRenderTree/qt/DumpRenderTree.cpp:
 540         (WebCore::clearHistory):
 541         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
 542
 543 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
 544
 545         Reviewed by Eric Seidel.
 546
 547         Ignore websocket tests when --no-http is specified.
 548         https://bugs.webkit.org/show_bug.cgi?id=31662
 549
 550         * Scripts/run-webkit-tests:
 551
 552 2009-11-18  Adam Barth  <abarth@webkit.org>
 553
 554         Reviewed by Eric Seidel.
 555
 556         Normalize ' and " in bugzilla-tool
 557         https://bugs.webkit.org/show_bug.cgi?id=31655
 558
 559         We decided " is better than ' and we should be consistent.
 560
 561         * Scripts/bugzilla-tool:
 562
 563 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 564
 565         Reviewed by Kenneth Rohde Christiansen.
 566
 567         [Qt] Remove support for Qt v4.3 or older versions
 568         https://bugs.webkit.org/show_bug.cgi?id=29469
 569
 570         * DumpRenderTree/qt/DumpRenderTree.pro:
 571         * DumpRenderTree/qt/ImageDiff.pro:
 572
 573 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
 574
 575         Reviewed by Eric Seidel.
 576
 577         GitTest.test_create_binary_patch fails if /tmp is symlink
 578         https://bugs.webkit.org/show_bug.cgi?id=31536
 579
 580         * Scripts/modules/scm_unittest.py:
 581
 582 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
 583
 584         Reviewed by Darin Adler.
 585
 586         Configuration for Chromium Build Slaves.
 587
 588         https://bugs.webkit.org/show_bug.cgi?id=31442
 589
 590         * BuildSlaveSupport/build.webkit.org-config/config.json:
 591         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 592
 593 2009-11-18  Eric Seidel  <eric@webkit.org>
 594
 595         Reviewed by Darin Adler.
 596
 597         workqueue.py results in totally broken commit-queue UI
 598         https://bugs.webkit.org/show_bug.cgi?id=31645
 599
 600         * Scripts/bugzilla-tool:
 601          - Remove unneeded use of PatchCollection.
 602          - Grab a new copy of the cq'd patches every run of the queue.
 603
 604 2009-11-18  Sam Weinig  <sam@webkit.org>
 605
 606         Reviewed by Anders Carlsson.
 607
 608         Make the Mac Geolocation API async.
 609
 610         Update DRT to use the new async Mac Geolocation API.
 611
 612         * DumpRenderTree/mac/UIDelegate.mm:
 613         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
 614
 615 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 616
 617         Reviewed by Kenneth Rohde Christiansen.
 618
 619         Add and option to toggle HTML5 datalist support to build-webkit
 620         https://bugs.webkit.org/show_bug.cgi?id=31599
 621
 622         * Scripts/build-webkit:
 623
 624 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
 625
 626         Reviewed by Kevin Ollivier.
 627
 628         Enable wx plugin support using the Windows implementation as a base.
 629
 630         https://bugs.webkit.org/show_bug.cgi?id=31636
 631
 632         * wx/build/settings.py:
 633
 634 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 635
 636         Reviewed by Simon Hausmann.
 637
 638         Change the initialization order so that the controllers
 639         will be created before exporting them to the JS DOM window.
 640
 641         * DumpRenderTree/qt/DumpRenderTree.cpp:
 642         (WebCore::DumpRenderTree::DumpRenderTree):
 643
 644 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 645
 646         Reviewed by Simon Hausmann.
 647
 648         Fix a code copy and paste error. m_page should be page.
 649
 650         * DumpRenderTree/qt/DumpRenderTree.cpp:
 651         (WebCore::DumpRenderTree::createWindow):
 652
 653 2009-11-17  Mark Rowe  <mrowe@apple.com>
 654
 655         Reviewed by Alexey Proskuryakov.
 656
 657         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
 658
 659         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
 660         This prevents symlinks from confusing the descendant check.
 661
 662 2009-11-17  Mark Rowe  <mrowe@apple.com>
 663
 664         Reviewed by Alexey Proskuryakov.
 665
 666         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
 667
 668         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
 669         server to be up rather than having run-webkit-tests abort immediately.
 670
 671         * Scripts/run-webkit-tests:
 672
 673 2009-11-17  Eric Seidel  <eric@webkit.org>
 674
 675         Reviewed by Darin Adler.
 676
 677         commit-queue is failing to set reviewer in ChangeLogs
 678         https://bugs.webkit.org/show_bug.cgi?id=31592
 679
 680         * Scripts/bugzilla-tool: Clarify the "applying" log message.
 681         * Scripts/modules/bugzilla.py:
 682          - Add a new _validate_committer_and_reviewer function as a
 683            temporary solution until we can make a real Attachment object
 684            which knows how to fill in its committer/reviewer fields automatically.
 685
 686 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 687
 688         Unreviewed buildbot fix.
 689
 690         Revert part of earlier patch and add comment, as it
 691         was causing timeouts on the buildbot.
 692
 693         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 694         (LayoutTestController::notifyDone):
 695
 696 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 697
 698         Reviewed by Oliver Hunt.
 699
 700         Make the timeout 15 sec as for the other DRT's and make
 701         it print out the same output when a test timeout.
 702
 703         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 704         (LayoutTestController::waitUntilDone):
 705         (LayoutTestController::notifyDone):
 706         (LayoutTestController::timerEvent):
 707
 708 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
 709
 710         Reviewed by Timothy Hatcher.
 711
 712         Fixed typos in comments.
 713
 714         * Scripts/modules/committers.py:
 715
 716 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
 717
 718         Reviewed by Timothy Hatcher.
 719
 720         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
 721         - Updated DRT to show/close inspector for all tests under /inspector
 722         - Introduced LayoutTestController::setTimelineProfilingEnabled and
 723           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
 724         - Removed reload on each inspector test
 725         - Renamed fast/inspector to fast/inspector-support in order not to trigger
 726         inspector for those.
 727         - Reimplemented timeline tests in order to get rid of reload there.
 728         - Moved tests that don't require harness into the fast group.
 729
 730         https://bugs.webkit.org/show_bug.cgi?id=31472
 731
 732         * DumpRenderTree/LayoutTestController.cpp:
 733         (setTimelineProfilingEnabledCallback):
 734         (closeWebInspectorCallback):
 735         (LayoutTestController::staticFunctions):
 736         * DumpRenderTree/LayoutTestController.h:
 737         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 738         (shouldOpenWebInspector):
 739         (runTest):
 740         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 741         (LayoutTestController::setTimelineProfilingEnabled):
 742         * DumpRenderTree/mac/DumpRenderTree.mm:
 743         (shouldOpenWebInspector):
 744         (runTest):
 745         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 746         (LayoutTestController::setTimelineProfilingEnabled):
 747         * DumpRenderTree/win/DumpRenderTree.cpp:
 748         (shouldOpenWebInspector):
 749         (runTest):
 750         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 751         (LayoutTestController::setTimelineProfilingEnabled):
 752
 753 2009-11-17  Oliver Hunt  <oliver@apple.com>
 754
 755         Reviewed by Maciej Stachowiak.
 756
 757         Incorrect use of JavaScriptCore API in DumpRenderTree
 758         https://bugs.webkit.org/show_bug.cgi?id=31577
 759
 760         Return undefined rather than a literal null.
 761
 762         * DumpRenderTree/AccessibilityUIElement.cpp:
 763         (setSelectedTextRangeCallback):
 764         (incrementCallback):
 765         (decrementCallback):
 766         (showMenuCallback):
 767
 768 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
 769
 770         Reviewed by Beth Dakin.
 771
 772         AX: aria-labelledby duplicates some of its WAI-ARIA label
 773         https://bugs.webkit.org/show_bug.cgi?id=31565
 774
 775         * DumpRenderTree/AccessibilityUIElement.cpp:
 776         (titleUIElementCallback):
 777         (getIsValidCallback):
 778         (AccessibilityUIElement::getJSClass):
 779
 780 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 781
 782         Reviewed by Simon Hausmann.
 783
 784         r50942 broke output from created windows. Make the
 785         m_enableTextOutput a member of the DRT and not the
 786         WebPage.
 787
 788         * DumpRenderTree/qt/DumpRenderTree.cpp:
 789         (WebCore::WebPage::WebPage):
 790         (WebCore::WebPage::javaScriptAlert):
 791         (WebCore::WebPage::javaScriptConsoleMessage):
 792         (WebCore::WebPage::javaScriptConfirm):
 793         (WebCore::WebPage::javaScriptPrompt):
 794         (WebCore::WebPage::acceptNavigationRequest):
 795         (WebCore::DumpRenderTree::DumpRenderTree):
 796         (WebCore::DumpRenderTree::open):
 797         (WebCore::DumpRenderTree::createWindow):
 798         * DumpRenderTree/qt/DumpRenderTree.h:
 799         (WebCore::DumpRenderTree::setTextOutputEnabled):
 800         (WebCore::DumpRenderTree::isTextOutputEnabled):
 801         (WebCore::WebPage::shouldInterruptJavaScript):
 802         (WebCore::WebPage::isTextOutputEnabled):
 803         (WebCore::WebPage::setViewGeometry):
 804
 805 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 806
 807         Reviewed by Gustavo Noronha Silva.
 808
 809         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
 810         as the implementation is being used by at least Qt and Gtk+.
 811
 812         Update buildsystems as well.
 813
 814         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
 815         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
 816         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
 817         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
 818         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
 819         * GNUmakefile.am:
 820
 821 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
 822
 823         Reviewed by Alexey Proskuryakov.
 824
 825         Disable wss until all platforms support pyOpenSSL
 826
 827         https://bugs.webkit.org/show_bug.cgi?id=31479
 828
 829         * Scripts/run-webkit-tests:
 830
 831 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
 832
 833         Reviewed by Kenneth Christiansen.
 834
 835         [Qt] Implement load error pages support for Qt's DRT.
 836         https://bugs.webkit.org/show_bug.cgi?id=31509
 837
 838         For now, it will not be a default feature, and layout tests
 839         that want to make use of this have to explicitily call
 840         'handleErrorPages();' for the test source.
 841
 842         Any of the other DumpRenderTree's (mac, win and gtk)
 843         support handling error pages. Qt's will be the first.
 844
 845         * DumpRenderTree/qt/DumpRenderTree.cpp:
 846         (WebCore::WebPage::supportsExtension):
 847         (WebCore::WebPage::extension):
 848         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 849         (LayoutTestController::reset):
 850         * DumpRenderTree/qt/LayoutTestControllerQt.h:
 851         (LayoutTestController::shouldHandleErrorPages):
 852         (LayoutTestController::handleErrorPages):
 853
 854 2009-11-16  Eric Seidel  <eric@webkit.org>
 855
 856         Reviewed by Adam Barth.
 857
 858         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
 859         https://bugs.webkit.org/show_bug.cgi?id=31549
 860
 861         Renamed --commit-queue to --non-interactive in most places
 862         and remove the code in land-patches which is no longer needed.
 863
 864         * Scripts/bugzilla-tool:
 865
 866 2009-11-16  Eric Seidel  <eric@webkit.org>
 867
 868         Reviewed by Adam Barth.
 869
 870         The commit-queue should use land-attachment
 871         https://bugs.webkit.org/show_bug.cgi?id=31548
 872
 873         * Scripts/bugzilla-tool:
 874
 875 2009-11-16  Adam Barth  <abarth@webkit.org>
 876
 877         Reviewed by Eric Seidel.
 878
 879         Convert CommitQueue over to PatchCollection
 880         https://bugs.webkit.org/show_bug.cgi?id=31547
 881
 882         Also fixes a bug in workqueue and adds a test!
 883
 884         * Scripts/bugzilla-tool:
 885         * Scripts/modules/workqueue.py:
 886         * Scripts/modules/workqueue_unittest.py:
 887
 888 2009-11-16  Adam Barth  <abarth@webkit.org>
 889
 890         Reviewed by Eric Seidel.
 891
 892         Move StyleQueue over to using PatchCollection
 893         https://bugs.webkit.org/show_bug.cgi?id=31544
 894
 895         That's what the class it's for.
 896
 897         * Scripts/bugzilla-tool:
 898         * Scripts/modules/patchcollection.py:
 899         * Scripts/modules/patchcollection_unittest.py:
 900
 901 2009-11-16  Eric Seidel  <eric@webkit.org>
 902
 903         Reviewed by Adam Barth.
 904
 905         bugzilla-tool needs a land-attachment command
 906         https://bugs.webkit.org/show_bug.cgi?id=31546
 907
 908         * Scripts/bugzilla-tool:
 909          - Move all the logic into AbstractLandingCommand and
 910            add a new LandAttachment command subclass.
 911          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
 912
 913 2009-11-16  Eric Seidel  <eric@webkit.org>
 914
 915         Reviewed by Adam Barth.
 916
 917         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
 918         https://bugs.webkit.org/show_bug.cgi?id=31543
 919
 920         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
 921
 922         * Scripts/bugzilla-tool:
 923
 924 2009-11-16  Eric Seidel  <eric@webkit.org>
 925
 926         Reviewed by Adam Barth.
 927
 928         Disable the style queue from posting to the commit queue status page.
 929
 930         * Scripts/bugzilla-tool:
 931
 932 2009-11-16  Adam Barth  <abarth@webkit.org>
 933
 934         Reviewed by Eric Seidel.
 935
 936         Implement PatchCollection
 937         https://bugs.webkit.org/show_bug.cgi?id=31541
 938
 939         This class holds a set of patches and lets clients iterate through
 940         them.  Optionally, clients can install a filter.
 941
 942         * Scripts/modules/patchcollection.py: Added.
 943         * Scripts/modules/patchcollection_unittest.py: Added.
 944         * Scripts/run-webkit-unittests:
 945
 946 2009-11-16  Eric Seidel  <eric@webkit.org>
 947
 948         Reviewed by Adam Barth.
 949
 950         bugzilla-tool land-patches will close bugs with patches r=?
 951         https://bugs.webkit.org/show_bug.cgi?id=28230
 952
 953         The commit-queue shouldn't close patches with outstanding reviews on them,
 954         even if many reviewers seem to be against multi-patch bugs.
 955
 956         * Scripts/bugzilla-tool:
 957
 958 2009-11-16  Eric Seidel  <eric@webkit.org>
 959
 960         Reviewed by Adam Barth.
 961
 962         bugzilla-tool check-style should work with attachment ids instead of bug ids
 963         https://bugs.webkit.org/show_bug.cgi?id=31540
 964
 965         * Scripts/bugzilla-tool:
 966
 967 2009-11-16  Eric Seidel  <eric@webkit.org>
 968
 969         Reviewed by Adam Barth.
 970
 971         WorkQueue is the only place that should know about special exit codes
 972         https://bugs.webkit.org/show_bug.cgi?id=31534
 973
 974         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
 975         and add tests for handling exit codes.
 976         I also cleaned up workqueue_unittest.py more.
 977
 978         * Scripts/bugzilla-tool:
 979         * Scripts/modules/workqueue.py:
 980         * Scripts/modules/workqueue_unittest.py:
 981
 982 2009-11-16  Eric Seidel  <eric@webkit.org>
 983
 984         Reviewed by Adam Barth.
 985
 986         Re-factor workqueue_unittest to allow for more than one test.
 987         https://bugs.webkit.org/show_bug.cgi?id=31535
 988
 989         * Scripts/modules/workqueue_unittest.py:
 990
 991 2009-11-16  Eric Seidel  <eric@webkit.org>
 992
 993         Reviewed by Adam Barth.
 994
 995         land-patches needs to be re-factored into smaller chunks
 996         https://bugs.webkit.org/show_bug.cgi?id=31532
 997
 998         * Scripts/bugzilla-tool: fix a couple obvious typos.
 999
1000 2009-11-16  Eric Seidel  <eric@webkit.org>
1001
1002         Reviewed by Adam Barth.
1003
1004         land-patches needs to be re-factored into smaller chunks
1005         https://bugs.webkit.org/show_bug.cgi?id=31532
1006
1007         The next patch will move these methods into WebKitLandingScripts.
1008
1009         * Scripts/bugzilla-tool:
1010          - Split out _land_patch and _close_bug_if_no_active_patches.
1011
1012 2009-11-16  Adam Barth  <abarth@webkit.org>
1013
1014         Reviewed by Eric Seidel.
1015
1016         Fix silly copy-and-paste code.  I am a terrible coder.
1017
1018         * Scripts/modules/bugzilla.py:
1019
1020 2009-11-16  Adam Barth  <abarth@webkit.org>
1021
1022         Reviewed by Eric Seidel.
1023
1024         Implement a StyleQueue
1025         https://bugs.webkit.org/show_bug.cgi?id=31537
1026
1027         The first iteration of the style queue only produces output locally.
1028         There is also a limit of 10 patches because it's not that useful to
1029         iterate through the entire review queue at this point.  We can remove
1030         the limit later.
1031
1032         * Scripts/bugzilla-tool:
1033         * Scripts/modules/bugzilla.py:
1034
1035 2009-11-16  Adam Barth  <abarth@webkit.org>
1036
1037         Reviewed by Eric Seidel.
1038
1039         Unit test WorkQueue
1040         https://bugs.webkit.org/show_bug.cgi?id=31531
1041
1042         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
1043
1044         * Scripts/bugzilla-tool:
1045         * Scripts/modules/statusbot.py:
1046         * Scripts/modules/workqueue.py:
1047         * Scripts/modules/workqueue_unittest.py: Added.
1048         * Scripts/run-webkit-unittests:
1049
1050 2009-11-16  Eric Seidel  <eric@webkit.org>
1051
1052         Reviewed by Adam Barth.
1053
1054         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
1055         https://bugs.webkit.org/show_bug.cgi?id=31530
1056
1057         * Scripts/bugzilla-tool:
1058
1059 2009-11-16  Eric Seidel  <eric@webkit.org>
1060
1061         Reviewed by Adam Barth.
1062
1063         bugzilla-tool needs apply-attachment
1064         https://bugs.webkit.org/show_bug.cgi?id=31528
1065
1066         * Scripts/bugzilla-tool:
1067          - Add ApplyAttachment command.
1068          - Abstract applying code into WebKitApplyingScripts.
1069          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
1070         * Scripts/modules/bugzilla.py:
1071          - Add fetch_attachment and bug_id_for_attachment_id.
1072         * Scripts/modules/bugzilla_unittest.py:
1073          - Add test for new parsing.
1074          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
1075
1076 2009-11-16  Eric Seidel  <eric@webkit.org>
1077
1078         Reviewed by Adam Barth.
1079
1080         Document check-style's use of force_clean.
1081
1082         * Scripts/bugzilla-tool:
1083         * Scripts/modules/scm.py:
1084
1085 2009-11-16  Adam Barth  <abarth@webkit.org>
1086
1087         Reviewed by Eric Seidel.
1088
1089         Move WorkQueue to its own file
1090         https://bugs.webkit.org/show_bug.cgi?id=31529
1091
1092         WorkQueue and WorkQueueDelegate are separate concerns from
1093         bugzilla-tool.  Also added a missing include to logging.py.
1094
1095         * Scripts/bugzilla-tool:
1096         * Scripts/modules/logging.py:
1097         * Scripts/modules/workqueue.py:
1098
1099 2009-11-16  Adam Barth  <abarth@webkit.org>
1100
1101         Reviewed by Eric Seidel.
1102
1103         Move OutputTee to logging.py.
1104
1105         * Scripts/bugzilla-tool:
1106         * Scripts/modules/logging.py:
1107
1108 2009-11-15  Adam Barth  <abarth@webkit.org>
1109
1110         Reviewed by Eric Seidel.
1111
1112         Refactor bugzilla-tool to allow for multiple queues
1113         https://bugs.webkit.org/show_bug.cgi?id=31513
1114
1115         Divide the commit queue class into three class to make creating
1116         additional queues easier.
1117
1118         * Scripts/bugzilla-tool:
1119
1120 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1121
1122         Reviewed by Eric Seidel.
1123
1124         svn-apply may not handle git patches created by bugzilla-tool
1125         https://bugs.webkit.org/show_bug.cgi?id=31457
1126
1127         * Scripts/modules/scm.py:
1128         * Scripts/modules/scm_unittest.py:
1129
1130 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1131
1132         Reviewed by Eric Seidel.
1133
1134         bugzilla-tool should post git binary diff
1135         https://bugs.webkit.org/show_bug.cgi?id=31458
1136
1137         Add --binary option to Git.create_patch.
1138
1139         * Scripts/modules/scm.py:
1140         * Scripts/modules/scm_unittest.py:
1141
1142 2009-11-15  Adam Barth  <abarth@webkit.org>
1143
1144         Reviewed by Darin Adler.
1145
1146         Add bugzilla-tool check-style
1147         https://bugs.webkit.org/show_bug.cgi?id=31515
1148
1149         * Scripts/bugzilla-tool:
1150         * Scripts/modules/bugzilla.py:
1151
1152 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1153
1154         Reviewed by Simon Hausmann.
1155
1156         Make the Qt Linux only --valgrind feature, suppress errors
1157         defined in the SuppressedValgrindErrors file.
1158
1159         * Scripts/run-webkit-tests:
1160
1161 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1162
1163         Reviewed by Simon Hausmann.
1164
1165         Set the locale to C and not to the current one in use on the system.
1166
1167         * DumpRenderTree/qt/DumpRenderTree.cpp:
1168         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1169
1170 2009-11-13  Adam Roben  <aroben@apple.com>
1171
1172         Add support for
1173         http/tests/security/isolatedWorld/didClearWindowObject.html
1174
1175         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
1176         window objects in isolated worlds are cleared
1177
1178         Reviewed by Dave Hyatt.
1179
1180         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
1181
1182         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1183         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1184         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
1185         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
1186         Added. Sets a __worldID property on the global object whose value is
1187         the ID of this world.
1188         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
1189         Respond to this new delegate callback by calling through to one of the
1190         above new methods.
1191         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1192         (worldMap): Added. Returns a HashMap containing all the worlds we've
1193         created.
1194         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
1195         haven't kept track of this world.
1196         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1197         instead of declaring our own.
1198
1199         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
1200
1201         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1202         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
1203         didClearWindowObjectForFrameInStandardWorld.
1204         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
1205         Respond to this new delegate callback by calling through to one of the
1206         below new methods.
1207         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
1208         Added. Sets a __worldID property on the gobal object whose value is
1209         the ID of this world.
1210         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1211         Added. Moved code here from didClearWindowObject.
1212
1213         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
1214         didClearWindowObjectForFrame* functions.
1215
1216         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1217         (worldMap): Added. Returns a HashMap containing all the worlds we've
1218         created.
1219         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
1220         haven't kept track of this world.
1221         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1222         instead of declaring our own.
1223
1224 2009-11-13  Adam Roben  <aroben@apple.com>
1225
1226         Finish replacing worldIDs with world objects
1227
1228         The only remaining use of worldIDs was in a method only used by DRT
1229         for the isolated worlds tests.
1230
1231         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
1232
1233         Reviewed by Mark Rowe.
1234
1235         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1236         (LayoutTestController::evaluateScriptInIsolatedWorld):
1237         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1238         (LayoutTestController::evaluateScriptInIsolatedWorld):
1239         Updated for changes to WebFrame. Now holds the map of worldID -> world
1240         at this level instead of making WebKit do it.
1241
1242 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1243
1244         Reviewed by Simon Hausmann.
1245
1246         [Qt] Ensure the DRT does not output anything until first test is run
1247
1248         * DumpRenderTree/qt/DumpRenderTree.cpp:
1249         * DumpRenderTree/qt/DumpRenderTree.h:
1250
1251 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1252
1253         Reviewed by Tor Arne Vestbø.
1254
1255         Clear the undo stack in before each new test run.
1256
1257         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
1258
1259         * DumpRenderTree/qt/DumpRenderTree.cpp:
1260         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1261
1262 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1263
1264         Reviewed by Kenneth Rohde Christiansen.
1265
1266         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
1267
1268         * DumpRenderTree/qt/DumpRenderTree.cpp:
1269         (WebCore::WebPage::resetSettings):
1270         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1271         (LayoutTestController::overridePreference):
1272
1273 2009-11-13  Eric Seidel  <eric@webkit.org>
1274
1275         Reviewed by Adam Barth.
1276
1277         Update committers.py based on svn records
1278         https://bugs.webkit.org/show_bug.cgi?id=31366
1279
1280         This list was generated using validate-committer-lists from
1281         https://bugs.webkit.org/show_bug.cgi?id=30970
1282         and makes committers.py current for committers who have
1283         committed in the last 3 years.
1284
1285         * Scripts/modules/committers.py:
1286
1287 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
1288
1289         Reviewed by Adam Barth.
1290
1291         The document-open.html test was flaky at times. The test invokes the layout test plugin
1292         which in its destroy stream handler opens a new document. This basically tears down the
1293         stream and the associated plugin instance. The pluginLog function in the layout test
1294         plugin attempts to retrieve the window script object on a torn down plugin instance
1295         which crashed consistently on windows in the debugger. The functions which issue
1296         these logs already have a valid window script object. We now have variants of the pluginLog
1297         function which take in a window script object with and without variable arguments.
1298
1299         https://bugs.webkit.org/show_bug.cgi?id=31067
1300
1301         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1302         (pluginLogWithWindowObject):
1303         (pluginLogWithWindowObjectVariableArgs):
1304         (pluginLog):
1305         (notifyTestCompletion):
1306         (testDocumentOpen):
1307         (testWindowOpen):
1308
1309 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1310
1311         Reviewed by Gustavo Noronha Silva.
1312
1313         https://bugs.webkit.org/show_bug.cgi?id=30997
1314         [Gtk] Implemment AtkDocument
1315
1316         Added testing support.
1317
1318         * DumpRenderTree/AccessibilityUIElement.cpp:
1319         * DumpRenderTree/AccessibilityUIElement.h:
1320         (getDocumentEncodingCallback):
1321         (getDocumentURICallback):
1322         (AccessibilityUIElement::getJSClass):
1323         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1324         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1325         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1326         (AccessibilityUIElement::documentEncoding):
1327         (AccessibilityUIElement::documentURI):
1328
1329 2009-11-12  Adam Roben  <aroben@apple.com>
1330
1331         Replace worldIDs with world objects
1332
1333         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
1334         user scripts/stylesheets and isolated worlds
1335
1336         Reviewed by Sam Weinig.
1337
1338         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1339         (LayoutTestController::addUserScript):
1340         (LayoutTestController::addUserStyleSheet):
1341         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1342         (LayoutTestController::addUserScript):
1343         (LayoutTestController::addUserStyleSheet):
1344         Changed these functions to create a new WebJSWorld each time they're
1345         called and to pass that world to WebKit.
1346
1347 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
1348
1349         Reviewed by Oliver Hunt.
1350
1351         need to implement aria tree roles
1352         https://bugs.webkit.org/show_bug.cgi?id=31284
1353
1354         * DumpRenderTree/AccessibilityUIElement.cpp:
1355         (disclosedRowAtIndexCallback):
1356         (selectedRowAtIndexCallback):
1357         (isEqualCallback):
1358         (isAttributeSettableCallback):
1359         (isActionSupportedCallback):
1360         (disclosedByRowCallback):
1361         (hierarchicalLevelCallback):
1362         (AccessibilityUIElement::getJSClass):
1363         * DumpRenderTree/AccessibilityUIElement.h:
1364         (AccessibilityUIElement::isEqual):
1365         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1366         (AccessibilityUIElement::hierarchicalLevel):
1367         (AccessibilityUIElement::disclosedRowAtIndex):
1368         (AccessibilityUIElement::selectedRowAtIndex):
1369         (AccessibilityUIElement::disclosedByRow):
1370         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1371         (AccessibilityUIElement::getChildAtIndex):
1372         (AccessibilityUIElement::disclosedRowAtIndex):
1373         (AccessibilityUIElement::selectedRowAtIndex):
1374         (AccessibilityUIElement::titleUIElement):
1375         (AccessibilityUIElement::parentElement):
1376         (AccessibilityUIElement::disclosedByRow):
1377         (AccessibilityUIElement::hierarchicalLevel):
1378         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1379         (AccessibilityUIElement::hierarchicalLevel):
1380         (AccessibilityUIElement::disclosedRowAtIndex):
1381         (AccessibilityUIElement::selectedRowAtIndex):
1382         (AccessibilityUIElement::disclosedByRow):
1383
1384 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
1385
1386         Reviewed by Darin Adler.
1387
1388         svn-apply can not handle git binary diffs
1389         https://bugs.webkit.org/show_bug.cgi?id=26830
1390
1391         Support "literal" type git binary diffs.
1392
1393         * Scripts/VCSUtils.pm:
1394         * Scripts/modules/scm_unittest.py:
1395         * Scripts/svn-apply:
1396
1397 2009-11-11  Dmitry Titov  <dimich@chromium.org>
1398
1399         Not reviewed, removing duplicate entry for myself in committers.py.
1400
1401         * Scripts/modules/committers.py:
1402
1403 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
1404
1405         Reviewed by Darin Adler and Mark Rowe.
1406
1407         https://bugs.webkit.org/show_bug.cgi?id=31200
1408         Tests in http/tests/security/mixedContent start to fail when new tests are added
1409
1410         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
1411
1412 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1413
1414         Reviewed by Jan Alonzo.
1415
1416         Create, and display a window for the inspector, for inspector
1417         tests.
1418
1419         Need to also show/hide the inspector window to avoid having
1420         problems with code assuming it is realized
1421         https://bugs.webkit.org/show_bug.cgi?id=31347
1422
1423         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1424         (webInspectorShowWindow):
1425         (webInspectorCloseWindow):
1426         (webInspectorInspectWebView):
1427         (createWebView):
1428
1429 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1430
1431         Unreviewed Qt buildbot fix.
1432
1433         My previous fix was wrong, so revert that change and fix it by
1434         returning when the document of the frame has no document element.
1435         Idea is borrowed from mac and win DRT.
1436
1437         * DumpRenderTree/qt/DumpRenderTree.cpp:
1438         (WebCore::DumpRenderTree::dumpFramesAsText):
1439
1440 2009-11-11  Eric Seidel  <eric@webkit.org>
1441
1442         Reviewed byg Kenneth Rohde Christiansen.
1443
1444         Update Kenneth's committer record to include the email he
1445         uses on lists.webkit.org.
1446
1447         * Scripts/modules/committers.py:
1448
1449 2009-11-11  Eric Seidel  <eric@webkit.org>
1450
1451         Reviewed by Gustavo Noronha Silva.
1452
1453         Several committers use separate email addresses for bugzilla and svn.webkit.org
1454         https://bugs.webkit.org/show_bug.cgi?id=31364
1455
1456         Update records for existing committers to include email addresses
1457         used in svn.webkit.org and lists.webkit.org.
1458         Most committers use the same email address in all 3 places, but some use
1459         separate addresses.  committers.py needs record of each of these addresses.
1460
1461         * Scripts/modules/committers.py:
1462
1463 2009-11-11  Eric Seidel  <eric@webkit.org>
1464
1465         No review, adding second email address for an existing committer.
1466
1467         Add Yong Li's second bugzilla account to his committer record.
1468         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
1469
1470         * Scripts/modules/committers.py:
1471
1472 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1473
1474         Reviewed by Simon Hausmann.
1475
1476         If the frame has no innerText don't append it, and
1477         do not add a newline which breaks some cross platform
1478         results.
1479
1480         * DumpRenderTree/qt/DumpRenderTree.cpp:
1481         (WebCore::DumpRenderTree::dumpFramesAsText):
1482
1483 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1484
1485         Reviewed by Simon Hausmann.
1486
1487         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
1488
1489         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1490         (webkit_test_plugin_new_instance):
1491         (webkit_test_plugin_destroy_instance):
1492         (webkit_test_plugin_destroy_stream):
1493
1494 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1495
1496         Reviewed by Mark Rowe.
1497
1498         Implement the functionality needed by plugins/window-open.html
1499
1500         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1501         (webkit_test_plugin_new_instance):
1502         (webkit_test_plugin_set_window):
1503
1504 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1505
1506         Reviewed by Simon Hausmann.
1507
1508         [Qt] Force -graphicssystem raster and -style windows when running DRT
1509
1510         * DumpRenderTree/qt/main.cpp:
1511         * Scripts/run-webkit-tests:
1512
1513 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1514
1515         Reviewed by Simon Hausmann.
1516
1517         Compute correct library paths for Qt
1518
1519         * Scripts/webkitdirs.pm:
1520
1521 2009-11-10  Mark Rowe  <mrowe@apple.com>
1522
1523         Reviewed by Sam Weinig.
1524
1525         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
1526
1527         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
1528         about the validity of the self-signed certificates used in the regression tests.  We would then add the
1529         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
1530         that had enabled frame load delegate logging this would result in extra log messages being generated,
1531         causing the test to fail.
1532
1533         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
1534         tests.
1535
1536         * DumpRenderTree/mac/DumpRenderTree.mm:
1537         (dumpRenderTree):
1538         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1539         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1540
1541 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1542
1543         Reviewed by Kenneth Rohde Christiansen.
1544
1545         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
1546
1547         * DumpRenderTree/qt/DumpRenderTree.cpp:
1548         (WebCore::DumpRenderTree::DumpRenderTree):
1549
1550 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1551
1552         Reviewed by Jan Alonzo.
1553
1554         [GTK] Remove WebSocket configuration from WebKitWebSettings
1555         https://bugs.webkit.org/show_bug.cgi?id=31244
1556
1557         Follow-up of r50724. Don't set the enable-web-socket property
1558         anymore.
1559
1560         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1561         (resetDefaultsToConsistentValues):
1562
1563 2009-11-10  Oliver Hunt  <oliver@apple.com>
1564
1565         Reviewed by Maciej Stachowiak.
1566
1567         Rename 3D Canvas related classes to use WebGL prefix
1568         https://bugs.webkit.org/show_bug.cgi?id=29095
1569
1570         Checkin new version of do-webcore-rename used to do the WebGL type rename,
1571         and upate webkitdirs script to new method of testing for WebGL.
1572
1573         * Scripts/do-webcore-rename:
1574         * Scripts/webkitdirs.pm:
1575
1576 2009-11-09  Oliver Hunt  <oliver@apple.com>
1577
1578         Reviewed by Geoff Garen.
1579
1580         Make do-webcore-rename work with git.
1581
1582         * Scripts/do-webcore-rename:
1583
1584 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
1585
1586         Adding Kenneth to the reviewers list.
1587
1588         * Scripts/modules/committers.py:
1589
1590 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1591
1592         Reviewed by Jan Alonzo.
1593
1594         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
1595         https://bugs.webkit.org/show_bug.cgi?id=30482
1596
1597         LayoutTestControllerGtk now uses the exposed
1598         Page::tabKeyCyclesThroughElements API
1599
1600         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1601         (LayoutTestController::setTabKeyCyclesThroughElements):
1602
1603 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
1604
1605         Reviewed by Holger Freyther.
1606
1607         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
1608         This helps to pass the test case below. Also replaced hardcoded
1609         code numbers with defined constants.
1610         https://bugs.webkit.org/show_bug.cgi?id=31185
1611
1612         Test: editing/undo/undo-deleteWord.html
1613
1614         * DumpRenderTree/qt/EventSenderQt.cpp:
1615         (EventSender::keyDown):
1616
1617 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
1618
1619         Reviewed by Holger Freyther.
1620
1621         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
1622         https://bugs.webkit.org/show_bug.cgi?id=31164
1623
1624         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
1625
1626         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1627         (LayoutTestController::processWork):
1628
1629 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
1630
1631         Reviewed by Holger Freyther.
1632
1633         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
1634         https://bugs.webkit.org/show_bug.cgi?id=31158
1635
1636         By invoking a script queue'd by queueScript(), 'true' was beeing returned
1637         always, which from WorkQueue prospective means that a load has been started
1638         and the queue processing should stop and wait for the load to finish.
1639         Spinning it off into a loading and a non-loading variants was the solution
1640         adopted by Mac's DRT to work around this problem. The former keeps returning
1641         'true' while the later executes the script synchronously and returns 'false'
1642         making it possible to the WorkQueue to proceed right away.
1643
1644         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1645         (LayoutTestController::processWork):
1646         (LayoutTestController::queueLoadingScript):
1647         (LayoutTestController::queueNonLoadingScript):
1648         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1649         * DumpRenderTree/qt/WorkQueueItem.h:
1650         (LoadingScriptItem::LoadingScriptItem):
1651         (LoadingScriptItem::invoke):
1652         (NonLoadingScriptItem::NonLoadingScriptItem):
1653         (NonLoadingScriptItem::invoke):
1654
1655 2009-11-07  Mark Rowe  <mrowe@apple.com>
1656
1657         Rubber-stamped by Cameron Zwarich.
1658
1659         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
1660
1661         * Scripts/commit-log-editor:
1662
1663 2009-11-07  Mark Rowe  <mrowe@apple.com>
1664
1665         Reviewed by Darin Adler.
1666
1667         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
1668         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
1669
1670         Move logic for determining the name and email address to use in a ChangeLog entry from
1671         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
1672         whether the author of the patch matches committer, and therefore needs access to the
1673         email address that would be used in a ChangeLog entry.
1674
1675         Based on a patch by Pierre d'Herbemont.
1676
1677         * Scripts/VCSUtils.pm:
1678         * Scripts/commit-log-editor:
1679         * Scripts/prepare-ChangeLog:
1680         * Scripts/webkitdirs.pm:
1681
1682 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
1683
1684         Reviewed by Adam Barth.
1685
1686         Added functionality to the layout test plugin to invoke document.open and
1687         window.open with default arguments. The associated webkit bug is
1688         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
1689         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
1690         work in Chromium (V8) if there is no calling javascript context. To achieve this
1691         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
1692         for the window.open test case and in NPP_DestroyStream for the document.open test case.
1693
1694         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1695         (testDocumentOpen):
1696         (testWindowOpen):
1697         (pluginAllocate):
1698         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1699         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1700         (NPP_New):
1701         (NPP_SetWindow):
1702         (NPP_DestroyStream):
1703         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1704         (NPP_New):
1705         (NPP_SetWindow):
1706         (NPP_NewStream):
1707         (NPP_DestroyStream):
1708
1709 2009-11-06  Eric Seidel  <eric@webkit.org>
1710
1711         Reviewed by Adam Barth.
1712
1713         bugzilla-tool crashed with exception
1714         https://bugs.webkit.org/show_bug.cgi?id=31092
1715
1716         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
1717
1718 2009-11-04  Eric Seidel  <eric@webkit.org>
1719
1720         No review, just add a line which got left out of the patch uploaded for commit.
1721
1722         commit-queue is crashing when trying to reject patches after unknown failures
1723         https://bugs.webkit.org/show_bug.cgi?id=31091
1724
1725         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
1726
1727 2009-11-04  Adam Roben  <aroben@apple.com>
1728
1729         Remove bogus else clause in bugzilla-tool
1730
1731         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
1732         create-bug raises exception after entering bug description
1733
1734         Reviewed by David Kilzer.
1735
1736         * Scripts/bugzilla-tool:
1737         (CreateBug): else clauses are only hit if no exception is raised, so
1738         it makes no sense to try to re-raise the exception in an else clause.
1739         The exception will automatically be re-raised if it doesn't match any
1740         of the except clauses, so we don't have to do anything special here at
1741         all to get the desired behavior.
1742
1743 2009-11-04  Eric Seidel  <eric@webkit.org>
1744
1745         Reviewed by David Kilzer.
1746
1747         svn-apply's fixChangeLogPatch function seems broken
1748         https://bugs.webkit.org/show_bug.cgi?id=30683
1749
1750         Update fixChangeLogPatch to be able to handle patches which
1751         don't start at line 1.
1752         Add unit tests for svn-apply to scm_unittest.py.
1753
1754         * Scripts/VCSUtils.pm:
1755         * Scripts/modules/scm_unittest.py:
1756
1757 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
1758
1759         Reviewed by Beth Dakin.
1760
1761         Need to implement ARIA role="combobox"
1762         https://bugs.webkit.org/show_bug.cgi?id=31096
1763
1764         * DumpRenderTree/AccessibilityUIElement.cpp:
1765         (showMenuCallback):
1766         (getIsExpandedCallback):
1767         (AccessibilityUIElement::getJSClass):
1768         * DumpRenderTree/AccessibilityUIElement.h:
1769         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1770         (AccessibilityUIElement::isExpanded):
1771         (AccessibilityUIElement::showMenu):
1772         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1773         (AccessibilityUIElement::isExpanded):
1774         (AccessibilityUIElement::showMenu):
1775         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1776         (AccessibilityUIElement::isSelected):
1777         (AccessibilityUIElement::isExpanded):
1778         (AccessibilityUIElement::showMenu):
1779
1780 2009-11-04  Eric Seidel  <eric@webkit.org>
1781
1782         Reviewed by Adam Barth.
1783
1784         commit-queue is crashing when trying to reject patches after unknown failures
1785         https://bugs.webkit.org/show_bug.cgi?id=31091
1786
1787         * Scripts/bugzilla-tool:
1788          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
1789            so we have to find out what the current patch is by asking bugzilla again.
1790          - Discovered that this code was also leaking file descriptors, so fixed that.
1791
1792 2009-11-04  Adam Roben  <aroben@apple.com>
1793
1794         Make run-webkit-tests work for the Debug_Internal Windows
1795         configuration
1796
1797         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
1798         suffix.
1799
1800         Fixes <http://webkit.org/b/31123>.
1801
1802         Reviewed by Sam Weinig.
1803
1804         * Scripts/run-webkit-tests: Don't add the _debug suffix in
1805         Debug_Internal, either.
1806
1807 2009-11-04  Eric Seidel  <eric@webkit.org>
1808
1809         Reviewed by Adam Barth.
1810
1811         committers.py needs a way to store non-bugzilla email addresses
1812         https://bugs.webkit.org/show_bug.cgi?id=31037
1813
1814         Make Committer and Reviewer constructors take a single email or a list of emails.
1815         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
1816         Expose reviewers(), used by validate-committer-lists on bug 30970.
1817
1818         * Scripts/modules/committers.py:
1819         * Scripts/modules/committers_unittest.py: Added tests for the new code.
1820
1821 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
1822
1823         Reviewed by David Levin.
1824
1825         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
1826         https://bugs.webkit.org/show_bug.cgi?id=27491
1827
1828         The test path determination logic is changed to handle websocket and websocket/ssl cases.
1829         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
1830
1831         Functions to start or stop Web Socket servers are added.
1832
1833         * Scripts/run-webkit-tests:
1834
1835 2009-11-03  Eric Seidel  <eric@webkit.org>
1836
1837         No review, just changing wording of log message.
1838
1839         Change log string to say "failed" instead of "rejected"
1840         when a commit fails due to an out of date checkout.
1841         This makes grepping the commit-queue log for rejected patches easier.
1842
1843         * Scripts/bugzilla-tool:
1844
1845 2009-11-03  Eric Seidel  <eric@webkit.org>
1846
1847         No review, adding commonly known committers missing from the file.
1848
1849         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
1850
1851 2009-11-03  Eric Seidel  <eric@webkit.org>
1852
1853         No review, just sort-order cleanup.
1854
1855         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
1856
1857 2009-11-03  Stephen White  <senorblanco@chromium.org>
1858
1859         (Unreviewed).
1860
1861         Add myself to committers.py.
1862
1863         * Scripts/modules/committers.py:
1864
1865 2009-11-03  Robin Dunn  <robin@alldunn.com>
1866
1867         Reviewed by Kevin Ollviier.
1868
1869         Add packaging scripts for Debian-based Linux distros.
1870
1871         https://bugs.webkit.org/show_bug.cgi?id=31075
1872
1873         * wx/packaging/build-debian-installer.py: Added.
1874         * wx/packaging/debian: Added.
1875
1876 2009-11-03  Dan Bernstein  <mitz@apple.com>
1877
1878         Reviewed by Anders Carlsson and Beth Dakin.
1879
1880         https://bugs.webkit.org/show_bug.cgi?id=31070
1881
1882         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
1883         destroyed, it executes the value of the 'ondestroy' parameter as a
1884         script.
1885
1886         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1887         (pluginAllocate): Initialize onDestroy.
1888         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
1889         onDestroy.
1890         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1891         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
1892         specified.
1893         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
1894
1895 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1896
1897         Reviewed by Xan Lopez.
1898
1899         https://bugs.webkit.org/show_bug.cgi?id=31035
1900         [GTK] some accessibility tests hitting assertion in debug builds
1901
1902         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
1903
1904         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1905         (AccessibilityController::rootElement):
1906
1907 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
1908
1909         Reviewed by Beth Dakin.
1910
1911         Support ARIA "tab" roles
1912         https://bugs.webkit.org/show_bug.cgi?id=30842
1913
1914         * DumpRenderTree/AccessibilityUIElement.cpp:
1915         * DumpRenderTree/AccessibilityUIElement.h:
1916         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1917         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1918         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1919
1920 2009-11-01  Eric Seidel  <eric@webkit.org>
1921
1922         Reviewed by David Levin.
1923
1924         buildbots should use --exit-after-N-failures
1925         https://bugs.webkit.org/show_bug.cgi?id=30809
1926
1927         Make the bots exit after 20 failures to prevent never-ending
1928         test runs where every test spends a minute crashing.
1929
1930         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1931
1932 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1933
1934         Reviewed by Eric Seidel.
1935
1936         Turn on warnings for QtWebKit for gcc
1937         https://bugs.webkit.org/show_bug.cgi?id=30958
1938
1939         * DumpRenderTree/qt/main.cpp:
1940         (crashHandler): Mark function NO_RETURN
1941
1942 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
1943
1944         Adding myself to the committers list.
1945
1946         * Scripts/modules/committers.py:
1947
1948 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
1949
1950         Fix an issue that Adam noticed in DRT.
1951
1952         Reviewed by Darin Adler.
1953
1954         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1955         (AccessibilityUIElement::role):
1956         Get the length of the role text, and create a buffer dynamically.
1957
1958 2009-10-30  Eric Seidel  <eric@webkit.org>
1959
1960         No review, rolling out r50105.
1961         http://trac.webkit.org/changeset/50105
1962
1963         This commit was causing:
1964         https://bugs.webkit.org/show_bug.cgi?id=30869
1965         We'll re-implement the feature a different way.
1966
1967         * Scripts/bugzilla-tool:
1968
1969 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
1970
1971         Test for MSAA: Accessibility of headings is not correct
1972
1973         https://bugs.webkit.org/show_bug.cgi?id=30937
1974
1975         Reviewed by Adam Roben.
1976
1977         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1978         (AccessibilityUIElement::role):
1979         Allow the role returned to be a BSTR.
1980         (AccessibilityUIElement::description):
1981         Fix a copy/paste error.
1982
1983 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
1984
1985         Test for MSAA: Accessibility of links is wrong
1986
1987         https://bugs.webkit.org/show_bug.cgi?id=30928
1988
1989         Reviewed by Darin Adler.
1990
1991         * DumpRenderTree/AccessibilityUIElement.cpp:
1992         (getAccessibilityValueCallback):
1993         Return the accessibility value.
1994         (AccessibilityUIElement::getJSClass):
1995         Added "accessibilityValue" value.
1996
1997         * DumpRenderTree/AccessibilityUIElement.h:
1998
1999         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2000         (AccessibilityUIElement::accessibilityValue):
2001         Stubbed.
2002
2003         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2004         (AccessibilityUIElement::accessibilityValue):
2005         Stubbed.
2006
2007         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2008         (AccessibilityUIElement::accessibilityValue):
2009         Get the object's value, and return it as a JS string.
2010
2011 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
2012
2013         Fix typo in command name used by wx build system.
2014
2015         * wx/build/build_utils.py:
2016
2017 2009-10-30  Adam Barth  <abarth@webkit.org>
2018
2019         Reviewed by Darin Adler.
2020
2021         Patch v1 is a dumb default name for patches
2022         https://bugs.webkit.org/show_bug.cgi?id=30952
2023
2024         Let's use "Patch" instead.
2025
2026         * Scripts/bugzilla-tool:
2027
2028 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2029
2030         Unreviewed trivial buildfix.
2031
2032         [Qt] Buildfix for r50333.
2033
2034         * DumpRenderTree/qt/DumpRenderTree.pro:
2035
2036 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
2037
2038         Reviewed by Holger Freyther.
2039
2040         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
2041         https://bugs.webkit.org/show_bug.cgi?id=30953
2042
2043         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
2044         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
2045         makes qt DRT to share this implementation (as gtk and mac ports do).
2046
2047         * DumpRenderTree/qt/DumpRenderTree.pro:
2048         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
2049         * DumpRenderTree/qt/WorkQueue.h: Removed.
2050
2051 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2052
2053         Unreviewed potential buildbot fix.
2054
2055         Second try: Reset page history before running each test.
2056
2057         Apparently the QWebHistory::clear() keeps the current page
2058         in history which is not what we want, so we not additionally
2059         sets the history capacity to 0 (forces removing everything)
2060         and then sets it back to its original value.
2061
2062         * DumpRenderTree/qt/DumpRenderTree.cpp:
2063         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2064
2065 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2066
2067         Unreviewed potential buildbot fix.
2068
2069         Reset page history before running each test.
2070
2071         * DumpRenderTree/qt/DumpRenderTree.cpp:
2072         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2073
2074 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
2075
2076         Reviewed by Eric Seidel.
2077
2078         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
2079
2080         Bug 28420 -  Implement HTML5 <ruby> rendering
2081         (https://bugs.webkit.org/show_bug.cgi?id=28420)
2082
2083         No new tests (no functional change).
2084
2085         * Scripts/build-webkit:
2086
2087 2009-10-29  Dan Bernstein  <mitz@apple.com>
2088
2089         Reviewed by Mark Rowe.
2090
2091         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
2092         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
2093         define it.
2094
2095         * Scripts/VCSUtils.pm:
2096         * Scripts/svn-apply:
2097         * Scripts/svn-unapply:
2098
2099 2009-10-29  Xan Lopez  <xlopez@igalia.com>
2100
2101         Reviewed by Gustavo Noronha.
2102
2103         Use the GTK+ main loop instead of rolling our own mini-version of
2104         it.
2105
2106         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2107         (dump):
2108         (runTest):
2109         (webViewLoadFinished):
2110
2111 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2112
2113         Reviewed by Oliver Hunt.
2114
2115         Implement the Qt version of DRT dumpBackForwardList().
2116
2117         * DumpRenderTree/qt/DumpRenderTree.cpp:
2118         (WebCore::dumpHistoryItem):
2119         (WebCore::DumpRenderTree::dumpBackForwardList):
2120
2121 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2122
2123         Reviewed by Adam Roben.
2124
2125         Implement DRT functionality for Qt introduced in
2126         r28690 and r28705.
2127
2128         - Implemented pathToLocalResource which exposes the functionality of
2129         converting a given unix path to the correct location on Windows.
2130         - Implemented a way to remove machine-dependent information from paths
2131         in layout test results.
2132
2133         * DumpRenderTree/qt/DumpRenderTree.cpp:
2134         (WebCore::urlSuitableForTestResult):
2135         (WebCore::WebPage::javaScriptConsoleMessage):
2136         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2137         (LayoutTestController::pathToLocalResource):
2138         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2139
2140 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
2141
2142         Adding myself to the committers list.
2143
2144         * Scripts/modules/committers.py:
2145
2146 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
2147
2148         Adding myself to the committers list.
2149
2150         * Scripts/modules/committers.py:
2151
2152 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2153
2154         Reviewed by Jan Alonzo.
2155
2156         [GTK] API to start inspector for a WebView
2157         https://bugs.webkit.org/show_bug.cgi?id=22551
2158
2159         Use the new inspector API to implement the LayoutTestController
2160         interfaces used to test the inspector.
2161
2162         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2163         (webInspectorInspectWebView):
2164         (createWebView):
2165         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2166         (LayoutTestController::showWebInspector):
2167         (LayoutTestController::closeWebInspector):
2168         (LayoutTestController::evaluateInWebInspector):
2169
2170 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
2171
2172         Reviewed by Eric Seidel.
2173
2174         [Qt] WebFrame::counterValueForElementById must not be exposed
2175         https://bugs.webkit.org/show_bug.cgi?id=30882
2176
2177         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2178         (LayoutTestController::counterValueForElementById):
2179
2180 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2181
2182         Rubberstamped by Oliver Hunt.
2183
2184         Fix the warning:
2185
2186         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
2187         declared with attribute warn_unused_result".
2188
2189         by actually checking the result. In the case it is null, an
2190         error has occoured, so treat it as the other fatal errors.
2191
2192         * DumpRenderTree/qt/DumpRenderTree.cpp:
2193         (WebCore::DumpRenderTree::initializeFonts):
2194
2195 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
2196
2197         Reviewed by Darin Adler.
2198
2199         Provide a way to get counter values with layoutTestContoller
2200         https://bugs.webkit.org/show_bug.cgi?id=30555
2201
2202         Define layoutTestContoller.counterValueForElementById.
2203
2204         * DumpRenderTree/LayoutTestController.cpp:
2205         (counterValueForElementByIdCallback):
2206         (LayoutTestController::staticFunctions):
2207         * DumpRenderTree/LayoutTestController.h:
2208         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2209         (LayoutTestController::counterValueForElementById):
2210
2211 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2212
2213         Rubberstamped by Oliver Hunt.
2214
2215         Change two methods to be internal for DRT use only.
2216
2217         Part of [Qt] Review all new API in Qt 4.6
2218         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
2219
2220         * DumpRenderTree/qt/DumpRenderTree.cpp:
2221         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2222         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2223         (LayoutTestController::whiteListAccessFromOrigin):
2224
2225 2009-10-27  Eric Seidel  <eric@webkit.org>
2226
2227         Reviewed by Adam Barth.
2228
2229         REGRESSION: svn-apply exits(1) when applying a patch with a file add
2230         https://bugs.webkit.org/show_bug.cgi?id=30826
2231
2232         * Scripts/svn-apply:
2233          - Add () around all system() calls.
2234          - Use the correct system() == 0 or die instead of system() or die
2235          - Add descriptive messages to all die statements.
2236
2237 2009-10-27  Steve Block  <steveblock@google.com>
2238
2239         Reviewed by NOBODY.
2240
2241         Adds steveblock@google.com to list of committers.
2242
2243         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
2244
2245 2009-10-27  Eric Seidel  <eric@webkit.org>
2246
2247         Reviewed by Adam Barth.
2248
2249         svn-apply can exit(0) even on patch failure
2250         https://bugs.webkit.org/show_bug.cgi?id=29622
2251
2252         * Scripts/svn-apply:
2253          - Add a bunch of "or die" statements, hopefully catching all
2254            possible cases where failure could still exit(0).
2255
2256 2009-10-27  Eric Seidel  <eric@webkit.org>
2257
2258         Reviewed by Adam Barth.
2259
2260         svn-* scripts should share code through VCSUtils.pm
2261         https://bugs.webkit.org/show_bug.cgi?id=30791
2262
2263         Just moving code into a shared location.
2264
2265         * Scripts/VCSUtils.pm:
2266         * Scripts/prepare-ChangeLog:
2267         * Scripts/resolve-ChangeLogs:
2268         * Scripts/svn-apply:
2269         * Scripts/svn-create-patch:
2270         * Scripts/svn-unapply:
2271         * Scripts/update-webkit:
2272
2273 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
2274
2275         Suppress a huge number of MSVC warnings when building wxWebKit.
2276
2277         * wx/build/settings.py:
2278
2279 2009-10-26  Eric Seidel  <eric@webkit.org>
2280
2281         No review, just adding Mike Belshe to the committers list.
2282
2283         * Scripts/modules/committers.py:
2284
2285 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2286
2287         Reviewed by Darin Adler.
2288
2289         Make .rc files compile on Windows without depending on MFC headers
2290         https://bugs.webkit.org/show_bug.cgi?id=30750
2291
2292         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
2293         windows.h instead of afxres.h because it exists even when MFC is not
2294         installed, and is all that's needed here.
2295
2296         * FindSafari/FindSafari.rc: Ditto
2297
2298 2009-10-24  Eric Seidel  <eric@webkit.org>
2299
2300         Reviewed by Adam Barth.
2301
2302         bugzilla-tool post-diff should know how to mark commit-queue=?
2303         https://bugs.webkit.org/show_bug.cgi?id=29202
2304
2305         * Scripts/bugzilla-tool:
2306          - Add --commit-queue option to post-diff, post-commits and create-bug.
2307         * Scripts/modules/bugzilla.py:
2308          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
2309          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
2310
2311 2009-10-23  Eric Seidel  <eric@webkit.org>
2312
2313         Reviewed by Adam Barth.
2314
2315         bugzilla-tool commit-queue does not notice modifications to committers.py
2316         https://bugs.webkit.org/show_bug.cgi?id=30084
2317
2318         * Scripts/bugzilla-tool:
2319          - Make commit-queue re-exec itself instead of using while(1).
2320          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
2321          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
2322
2323 2009-10-22  Eric Seidel  <eric@webkit.org>
2324
2325         Reviewed by Adam Barth.
2326
2327         commit-queue will get stuck on patches if land-patches terminates unexpectedly
2328         https://bugs.webkit.org/show_bug.cgi?id=30634
2329
2330         * Scripts/bugzilla-tool:
2331          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
2332          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
2333
2334 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
2335
2336         Reviewed by Eric Seidel.
2337
2338         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
2339
2340         https://bugs.webkit.org/show_bug.cgi?id=30763
2341
2342         * pywebsocket/mod_pywebsocket/__init__.py:
2343         * pywebsocket/mod_pywebsocket/dispatch.py:
2344         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
2345         * pywebsocket/mod_pywebsocket/standalone.py:
2346         * pywebsocket/setup.py:
2347         * pywebsocket/test/test_dispatch.py:
2348
2349 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
2350
2351         Reviewed by David Levin.
2352
2353         REGRESSION: 2 failures in run-webkit-unittests
2354         https://bugs.webkit.org/show_bug.cgi?id=30645
2355
2356         * Scripts/modules/cpp_style_unittest.py:
2357         Fixed a few test scenarios which apparently lost some spaces from
2358         text literals.
2359
2360 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
2361
2362         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
2363
2364         * Scripts/webkitdirs.pm:
2365
2366 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
2367
2368         Reviewed by Darin Adler.
2369
2370         Unification of using null device in perl scripts.
2371         https://bugs.webkit.org/show_bug.cgi?id=30572
2372
2373         * Scripts/VCSUtils.pm:
2374         * Scripts/bisect-builds:
2375         * Scripts/resolve-ChangeLogs:
2376         * Scripts/run-iexploder-tests:
2377         * Scripts/run-jsc:
2378         * Scripts/run-mangleme-tests:
2379         * Scripts/run-webkit-tests:
2380         * Scripts/webkitdirs.pm:
2381         Using File::Spec->devnull() instead of hard coded /dev/null.
2382
2383 2009-10-26  Eric Seidel  <eric@webkit.org>
2384
2385         Reviewed by Holger Freyther.
2386
2387         Reviewers are missing from committers.py
2388         https://bugs.webkit.org/show_bug.cgi?id=30733
2389
2390         * Scripts/modules/committers.py:
2391
2392 2009-10-23  Eric Seidel  <eric@webkit.org>
2393
2394         No review, only adding Alice to the list of reviewers.
2395
2396         * Scripts/modules/committers.py:
2397
2398 2009-10-23  Eric Seidel  <eric@webkit.org>
2399
2400         Reviewed by Eric Carlson.
2401
2402         fast/media/mq-transform-02.html failed on Leopard Commit Bot
2403         https://bugs.webkit.org/show_bug.cgi?id=30700
2404
2405         * DumpRenderTree/mac/DumpRenderTree.mm:
2406         (resetDefaultsToConsistentValues): Update QuickTime version check.
2407
2408 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
2409
2410         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get
2411         character measurement APIs that are private on Tiger.
2412
2413         * wx/build/settings.py:
2414
2415 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2416
2417         Reviewed by NOBODY (build fix).
2418         Build fix following bug #30696.
2419
2420         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2421         (LayoutTestController::evaluateScriptInIsolatedWorld):
2422
2423 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2424
2425         Reviewed by Sam Weinig & Geoff Garen.
2426
2427         https://bugs.webkit.org/show_bug.cgi?id=30696
2428         Enable isolated-worlds tests on mac.
2429
2430         Add private interface for DRT to invoke execution in a given world.
2431
2432         * DumpRenderTree/LayoutTestController.cpp:
2433         (evaluateScriptInIsolatedWorldCallback):
2434         (LayoutTestController::staticFunctions):
2435         * DumpRenderTree/LayoutTestController.h:
2436         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2437         (LayoutTestController::evaluateScriptInIsolatedWorld):
2438         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2439         (LayoutTestController::evaluateScriptInIsolatedWorld):
2440
2441 2009-10-21  Eric Seidel  <eric@webkit.org>
2442
2443         Reviewed by Adam Barth.
2444
2445         bugzilla-tool's "patch failed to download an apply" error should give more information
2446         https://bugs.webkit.org/show_bug.cgi?id=30632
2447
2448         * Scripts/modules/scm.py:
2449          - Use the common run_command method instead of custom POpen code.
2450          - Make run_command know how to take pipes as input.
2451         * Scripts/modules/scm_unittest.py:
2452          - Add new tests to cover change.
2453          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
2454
2455 2009-10-21  Kent Tamura  <tkent@chromium.org>
2456
2457         Unreviewed.  Adding myself to the committers list.
2458
2459         * Scripts/modules/committers.py:
2460
2461 2009-10-21  Robin Dunn  <robin@alldunn.com>
2462
2463         Reviewed by Kevin Ollivier.
2464
2465         Update the Windows installer builder to work with Vista / Win 7 and with git.
2466
2467         https://bugs.webkit.org/show_bug.cgi?id=30649
2468
2469         * wx/build/build_utils.py:
2470         * wx/packaging/build-mac-installer.py:
2471         * wx/packaging/build-win-installer.py:
2472         * wx/packaging/wxWebKitInstaller.iss.in:
2473
2474 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2475
2476         Reviewed by Gustavo Noronha.
2477
2478         [GTK] Added conditional code to avoid using
2479         gdk_window_get_root_coords if we do not have a gtk+ release newer
2480         than 2.17.3.
2481         https://bugs.webkit.org/show_bug.cgi?id=30636
2482
2483         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2484
2485 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
2486
2487         Reviewed by Eric Seidel.
2488
2489         [Qt] Added dummy implementation for keepWebHistory()
2490         https://bugs.webkit.org/show_bug.cgi?id=30592
2491
2492         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2493         (LayoutTestController::keepWebHistory):
2494         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2495
2496 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2497
2498         Reviewed by Xan Lopez.
2499
2500         [GTK] Fixed the double click condition, it is not double click if
2501         we move in just in one direction.
2502         https://bugs.webkit.org/show_bug.cgi?id=30636
2503
2504         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2505
2506 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2507
2508         Reviewed by Xan Lopez.
2509
2510         [GTK] Initialize the events completly before emitting them.
2511         https://bugs.webkit.org/show_bug.cgi?id=30633
2512
2513         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2514
2515 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2516
2517         wx build fix. Fix for when linking using --as-needed with gcc.
2518
2519         * wx/browser/wscript:
2520
2521 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2522
2523         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
2524         to support all the features used by CURL backend.
2525
2526         * wx/build/settings.py:
2527         * wx/install-unix-extras:
2528
2529 2009-10-20  Anton Muhin  <antonm@chromium.org>
2530
2531         Reviewed by Adam Barth.
2532
2533         Add {ager,antonm,yurys}@chromium.org into committers.py
2534         https://bugs.webkit.org/show_bug.cgi?id=30560
2535
2536         * Scripts/modules/committers.py:
2537
2538 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2539
2540         Reviewed by Tor Arne Vestbø.
2541
2542         Make the Netscape Test plugin available to the Qt launcher.
2543
2544         * Scripts/run-launcher:
2545
2546 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
2547
2548         Reviewed by David Levin.
2549
2550         Removed WebSocket runtime settings.
2551         https://bugs.webkit.org/show_bug.cgi?id=29896
2552
2553         WebSocket runtime configuration is supported by chromium/v8 only.
2554
2555         * DumpRenderTree/mac/DumpRenderTree.mm:
2556         (resetDefaultsToConsistentValues):
2557         * DumpRenderTree/win/DumpRenderTree.cpp:
2558         (resetDefaultsToConsistentValues):
2559
2560 2009-10-19  Nate Chapin  <japhet@chromium.org>
2561
2562         Reviewed by Adam Barth.
2563
2564         Add testFail() to test plugin so we can test our handling of a
2565         plugin invoke call returning false.
2566
2567         https://bugs.webkit.org/show_bug.cgi?id=30239
2568
2569         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
2570         (pluginInvoke):
2571         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
2572
2573 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
2574
2575         Reviewed by Gustavo Noronha.
2576
2577         Enable DOM pasting when running layout tests.
2578
2579         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2580         (resetDefaultsToConsistentValues):
2581
2582 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2583
2584         Reviewed by Simon Hausmann.
2585
2586         Use the setPreferredContentsSize method instead
2587         of setFixedContentsSize, as the method has been renamed.
2588
2589         * DumpRenderTree/qt/DumpRenderTree.cpp:
2590         (WebCore::DumpRenderTree::open):
2591         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2592         (LayoutTestController::setFixedContentsSize):
2593
2594 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2595
2596         Reviewed by Dan Bernstein.
2597
2598         https://bugs.webkit.org/show_bug.cgi?id=30456
2599         Fixes for new Debug_All Windows build configuration.
2600
2601         * DumpRenderTree/win/DumpRenderTree.cpp:
2602         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
2603         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
2604
2605 2009-10-16  Eric Seidel  <eric@webkit.org>
2606
2607         Reviewed by Adam Barth.
2608
2609         commit-queue status bot should list which buildbot is blocking the queue
2610         https://bugs.webkit.org/show_bug.cgi?id=30452
2611
2612         Add new methods and testing.
2613
2614         * Scripts/bugzilla-tool:
2615         * Scripts/modules/buildbot.py:
2616         * Scripts/modules/buildbot_unittest.py:
2617
2618 2009-10-16  Eric Seidel  <eric@webkit.org>
2619
2620         Reviewed by Adam Barth.
2621
2622         run-webkit-tests fails when CWD is not inside a WebKit checkout
2623         https://bugs.webkit.org/show_bug.cgi?id=30451
2624
2625         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
2626         * Scripts/modules/scm_unittest.py:
2627           - Remove use of original_path (we don't need to restore the CWD).
2628           - Don't use '.' to find the webkit checkout, use __file__ instead.
2629
2630 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2631
2632         Reviewed by Adam Roben.
2633
2634         Add a Debug_All configuration to build entire stack as debug.
2635         Change Debug_Internal to:
2636         - stop using _debug suffix for all WebKit/Safari binaries
2637         - not use _debug as a DLL naming suffix
2638         - use non-debug C runtime lib.
2639
2640         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
2641         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
2642         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
2643         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2644         Add missing debug.vsprops inherited property sheet.
2645         Add Debug_All configuration.
2646         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
2647         * WinLauncher/WinLauncher.vcproj:
2648         Removed extraneous definitions inherited from vsprops.
2649         Add Debug_All configuration.
2650
2651 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
2652
2653         Reviewed by David Levin.
2654
2655         check-webkit-style is wrong about indent checking in namespaces
2656         in header files and a few other things
2657         https://bugs.webkit.org/show_bug.cgi?id=30362
2658
2659         The few other things include:
2660         + check-webkit-style does not require spaces around the equal sign
2661           inside 'if' statements and around binary operators that take
2662           numeric literals.
2663         + check-webkit-style reports false errors for the / operator
2664           when part of a filename in the #include directive.
2665
2666         * Scripts/modules/cpp_style.py:
2667         Improved indentation checking and space checking around
2668         binary operators. While the checks are still not perfect,
2669         they are clearly better than before.
2670         * Scripts/modules/cpp_style_unittest.py:
2671         Added test cases for the newly supported checks and modified old
2672         test cases to match the new guidelines
2673
2674 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
2675
2676         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
2677
2678         * wx/build/settings.py:
2679
2680 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
2681
2682         Reviewed by David Levin.
2683
2684         Add mod_pywebsocket to test Web Sockets.
2685         http://code.google.com/p/pywebsocket/
2686         https://bugs.webkit.org/show_bug.cgi?id=27490
2687
2688         * pywebsocket/COPYING: Added.
2689         * pywebsocket/MANIFEST.in: Added.
2690         * pywebsocket/README: Added.
2691         * pywebsocket/example/echo_client.py: Added.
2692         * pywebsocket/example/echo_wsh.py: Added.
2693         * pywebsocket/mod_pywebsocket/__init__.py: Added.
2694         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
2695         * pywebsocket/mod_pywebsocket/handshake.py: Added.
2696         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
2697         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
2698         * pywebsocket/mod_pywebsocket/standalone.py: Added.
2699         * pywebsocket/mod_pywebsocket/util.py: Added.
2700         * pywebsocket/setup.py: Added.
2701         * pywebsocket/test/config.py: Added.
2702         * pywebsocket/test/mock.py: Added.
2703         * pywebsocket/test/run_all.py: Added.
2704         * pywebsocket/test/test_dispatch.py: Added.
2705         * pywebsocket/test/test_handshake.py: Added.
2706         * pywebsocket/test/test_mock.py: Added.
2707         * pywebsocket/test/test_msgutil.py: Added.
2708         * pywebsocket/test/test_util.py: Added.
2709         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
2710         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
2711         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
2712         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
2713         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
2714         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
2715         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
2716         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
2717
2718 2009-10-15  James Robinson  <jamesr@google.com>
2719
2720         Reviewed by David Levin.
2721
2722         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
2723
2724         https://bugs.webkit.org/show_bug.cgi?id=30426
2725
2726         * Scripts/modules/cpp_style.py:
2727         * Scripts/modules/cpp_style_unittest.py:
2728
2729 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
2730
2731         Reviewed by Adam Roben.
2732
2733         Fixes <http://webkit.org/b/30411>.
2734         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
2735
2736         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
2737         building Chromium.
2738
2739         * Scripts/pdevenv:
2740
2741 2009-10-15  Robin Dunn  <robin@alldunn.com>
2742
2743         Reviewed by Kevin Ollivier.
2744
2745         Add Mac package building scripts for wx.
2746
2747         https://bugs.webkit.org/show_bug.cgi?id=30405
2748
2749         * wx/build/build_utils.py:
2750         * wx/build/settings.py:
2751         * wx/packaging/build-mac-installer.py: Added.
2752
2753 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
2754
2755         Reviewed by Gustavo Noronha.
2756
2757         Enable Web Sockets support when running layout tests.
2758
2759         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2760         (resetDefaultsToConsistentValues):
2761
2762 2009-10-15  Xan Lopez  <xlopez@igalia.com>
2763
2764         Reviewed by Gustavo Noronha.
2765
2766         Need to initialize event.button.button, since in most cases a
2767         button number is not passed as an argument.
2768
2769         * DumpRenderTree/gtk/EventSender.cpp:
2770         (mouseDownCallback):
2771         (mouseUpCallback):
2772
2773 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
2774
2775         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
2776         the OS if none was explicitly set.
2777
2778         * wx/build/settings.py:
2779
2780 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
2781
2782         Reviewed by Timothy Hatcher.
2783
2784         Web Inspector: enable developers extras within inspector layout tests.
2785
2786         https://bugs.webkit.org/show_bug.cgi?id=30014
2787
2788         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2789         (LayoutTestController::showWebInspector):
2790         (LayoutTestController::closeWebInspector):
2791         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2792         (LayoutTestController::showWebInspector):
2793         (LayoutTestController::closeWebInspector):
2794
2795 2009-10-14  José Millán Soto  <jmillan@igalia.com>
2796
2797         Reviewed by Jan Alonzo.
2798
2799         GtkLauncher is using a deprecated signal
2800         https://bugs.webkit.org/show_bug.cgi?id=30364
2801
2802         Modified GtkLauncher to use notify::title signal instead of
2803         deprecated title-changed signal
2804
2805         * GtkLauncher/main.c:
2806         (notify_title_cb):
2807         (create_browser):
2808
2809 2009-10-14  Brady Eidson  <beidson@apple.com>
2810
2811         Reviewed by Sam Weinig.
2812
2813         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
2814         1 - Disables WebHistory
2815         2 - Doesn't make sense in that context anyway.
2816
2817         * DumpRenderTree/win/DumpRenderTree.cpp:
2818         (createWebViewAndOffscreenWindow):
2819
2820 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
2821
2822         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
2823         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
2824
2825         * wx/build/settings.py:
2826         * wx/install-unix-extras:
2827
2828 2009-10-14  Brady Eidson  <beidson@apple.com>
2829
2830         Reviewed by Sam Weinig.
2831
2832         WebKit Win API should provide a delegate interface for global history.
2833         https://bugs.webkit.org/show_bug.cgi?id=29905
2834
2835         * DumpRenderTree/LayoutTestController.cpp:
2836         (LayoutTestController::LayoutTestController):
2837         * DumpRenderTree/LayoutTestController.h:
2838         (LayoutTestController::dumpHistoryDelegateCallbacks):
2839         (LayoutTestController::setDumpHistoryDelegateCallbacks):
2840
2841         * DumpRenderTree/win/DumpRenderTree.cpp:
2842         (shouldLogHistoryDelegates):
2843         (runTest):
2844         (createWebViewAndOffscreenWindow):
2845         (main):
2846         * DumpRenderTree/win/DumpRenderTree.vcproj:
2847
2848         Add the IWebHistoryDelegate to DRT Windows:
2849         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
2850         (wstringFromBSTR):
2851         (HistoryDelegate::HistoryDelegate):
2852         (HistoryDelegate::~HistoryDelegate):
2853         (HistoryDelegate::QueryInterface):
2854         (HistoryDelegate::AddRef):
2855         (HistoryDelegate::Release):
2856         (HistoryDelegate::didNavigateWithNavigationData):
2857         (HistoryDelegate::didPerformClientRedirectFromURL):
2858         (HistoryDelegate::didPerformServerRedirectFromURL):
2859         (HistoryDelegate::updateHistoryTitle):
2860         (HistoryDelegate::populateVisitedLinksForWebView):
2861         * DumpRenderTree/win/HistoryDelegate.h: Added.
2862
2863         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2864         (LayoutTestController::removeAllVisitedLinks):
2865
2866 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
2867
2868         Reviewed by Simon Hausmann.
2869
2870         [Qt] Implement support for setPOSIXLocale on Qt.
2871         https://bugs.webkit.org/show_bug.cgi?id=30268
2872
2873         * DumpRenderTree/qt/DumpRenderTree.cpp:
2874         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2875         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2876         (LayoutTestController::setPOSIXLocale):
2877         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2878
2879 2009-10-13  Stephanie Lewis  <slewis@apple.com>
2880
2881         Unreviewed, adding myself to reviewers list.
2882
2883         * Scripts/modules/committers.py:
2884
2885 2009-10-13  Stephanie Lewis  <slewis@apple.com>
2886
2887         Reviewed by Mark Rowe.
2888
2889         Fix null assignment so root tests work again.
2890
2891         * Scripts/webkitdirs.pm:
2892
2893 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2894
2895         Reviewed by Simon Hausmann.
2896
2897         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
2898         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
2899         This is done in preparation of implementing missing features in DRT.
2900         No functionality changes made yet.
2901
2902         * DumpRenderTree/qt/DumpRenderTree.cpp:
2903         * DumpRenderTree/qt/DumpRenderTree.pro:
2904         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
2905         (EventSender::EventSender):
2906         (EventSender::mouseDown):
2907         (EventSender::mouseUp):
2908         (EventSender::mouseMoveTo):
2909         (EventSender::leapForward):
2910         (EventSender::keyDown):
2911         (EventSender::contextClick):
2912         (EventSender::scheduleAsynchronousClick):
2913         (EventSender::frameUnderMouse):
2914         * DumpRenderTree/qt/EventSenderQt.h: Added.
2915         (EventSender::clearKillRing):
2916         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
2917         (LayoutTestController::LayoutTestController):
2918         (LayoutTestController::reset):
2919         (LayoutTestController::processWork):
2920         (LayoutTestController::maybeDump):
2921         (LayoutTestController::waitUntilDone):
2922         (LayoutTestController::notifyDone):
2923         (LayoutTestController::windowCount):
2924         (LayoutTestController::clearBackForwardList):
2925         (LayoutTestController::dumpEditingCallbacks):
2926         (LayoutTestController::dumpResourceLoadCallbacks):
2927         (LayoutTestController::queueBackNavigation):
2928         (LayoutTestController::queueForwardNavigation):
2929         (LayoutTestController::queueLoad):
2930         (LayoutTestController::queueReload):
2931         (LayoutTestController::queueScript):
2932         (LayoutTestController::provisionalLoad):
2933         (LayoutTestController::timerEvent):
2934         (LayoutTestController::encodeHostName):
2935         (LayoutTestController::decodeHostName):
2936         (LayoutTestController::setJavaScriptProfilingEnabled):
2937         (LayoutTestController::setFixedContentsSize):
2938         (LayoutTestController::setPrivateBrowsingEnabled):
2939         (LayoutTestController::setPopupBlockingEnabled):
2940         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2941         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2942         (LayoutTestController::numberOfActiveAnimations):
2943         (LayoutTestController::disableImageLoading):
2944         (LayoutTestController::dispatchPendingLoadRequests):
2945         (LayoutTestController::setDatabaseQuota):
2946         (LayoutTestController::clearAllDatabases):
2947         (LayoutTestController::whiteListAccessFromOrigin):
2948         (LayoutTestController::waitForPolicyDelegate):
2949         (LayoutTestController::overridePreference):
2950         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
2951         (LayoutTestController::isLoading):
2952         (LayoutTestController::setLoading):
2953         (LayoutTestController::shouldDumpAsText):
2954         (LayoutTestController::shouldDumpBackForwardList):
2955         (LayoutTestController::shouldDumpChildrenAsText):
2956         (LayoutTestController::shouldDumpDatabaseCallbacks):
2957         (LayoutTestController::shouldDumpStatusCallbacks):
2958         (LayoutTestController::shouldWaitUntilDone):
2959         (LayoutTestController::canOpenWindows):
2960         (LayoutTestController::shouldDumpTitleChanges):
2961         (LayoutTestController::waitForPolicy):
2962         (LayoutTestController::dumpAsText):
2963         (LayoutTestController::dumpChildFramesAsText):
2964         (LayoutTestController::dumpDatabaseCallbacks):
2965         (LayoutTestController::dumpStatusCallbacks):
2966         (LayoutTestController::setCanOpenWindows):
2967         (LayoutTestController::dumpBackForwardList):
2968         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
2969         (LayoutTestController::display):
2970         (LayoutTestController::dumpTitleChanges):
2971         (LayoutTestController::dumpSelectionRect):
2972         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
2973         (TextInputController::TextInputController):
2974         (TextInputController::doCommand):
2975         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
2976         * DumpRenderTree/qt/WorkQueue.cpp:
2977         * DumpRenderTree/qt/WorkQueue.h:
2978         * DumpRenderTree/qt/WorkQueueItem.h:
2979         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
2980         (findFrameNamed):
2981         (LoadItem::invoke):
2982         (ReloadItem::invoke):
2983         (ScriptItem::invoke):
2984         (BackForwardItem::invoke):
2985         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
2986         * DumpRenderTree/qt/jsobjects.h:
2987
2988 2009-10-13  Dmitry Titov  <dimich@chromium.org>
2989
2990         Not reviewed, adding myself to the list of reviewers.
2991
2992         * Scripts/modules/committers.py:
2993
2994 2009-10-13  Anders Carlsson  <andersca@apple.com>
2995
2996         Reviewed by Sam Weinig.
2997
2998         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
2999
3000         Make the private browsing mode testable by the test plug-in.
3001
3002         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3003         (pluginGetProperty):
3004         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3005         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3006         (NPP_New):
3007         (NPP_SetValue):
3008
3009 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
3010
3011         No review, just adding self to the list of reviewers.
3012
3013         * Scripts/modules/committers.py:
3014
3015 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
3016
3017         Reviewed by Adam Roben.
3018
3019         Web Inspector: Use proper web view in inspector layout
3020         tests for windows.
3021
3022         https://bugs.webkit.org/show_bug.cgi?id=30298
3023
3024         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3025         (LayoutTestController::showWebInspector):
3026         (LayoutTestController::closeWebInspector):
3027         (LayoutTestController::evaluateInWebInspector):
3028
3029 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
3030
3031         Reviewed by Sam Weinig.
3032
3033         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
3034         https://bugs.webkit.org/show_bug.cgi?id=29841
3035
3036         * DumpRenderTree/mac/DumpRenderTree.mm:
3037         (resetDefaultsToConsistentValues):
3038         * DumpRenderTree/win/DumpRenderTree.cpp:
3039         (resetDefaultsToConsistentValues):
3040
3041 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
3042
3043         Reviewed by Dimitri Glazkov.
3044
3045         Chromium Port - Windows
3046         https://bugs.webkit.org/show_bug.cgi?id=29969
3047
3048         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
3049         * Scripts/webkitdirs.pm:
3050
3051 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
3052
3053         Reviewed by Darin Adler.
3054
3055         jsc scripts cleanup and Qt/GTK fix
3056         https://bugs.webkit.org/show_bug.cgi?id=30288
3057
3058         Duplicated jscPath() moved to webkitdirs.pm.
3059         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
3060         Configuration added (release/debug) to path for Qt-port on Windows.
3061
3062         * Scripts/run-javascriptcore-tests:
3063         * Scripts/run-jsc:
3064         * Scripts/run-sunspider:
3065         * Scripts/sunspider-compare-results:
3066         * Scripts/webkitdirs.pm:
3067
3068 2009-10-11  Adam Barth  <abarth@webkit.org>
3069
3070         Unreviewed.  Add Collin to committers.py.
3071
3072         * Scripts/modules/committers.py:
3073
3074 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
3075
3076         wx build fix, add bindings to source/include dirs now that there are sources there.
3077
3078         * wx/build/settings.py:
3079
3080 2009-10-09  Mark Rowe  <mrowe@apple.com>
3081
3082         Reviewed by Brady Eidson.
3083
3084         Enable plug-in halting in DumpRenderTree.
3085
3086         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
3087         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
3088
3089         * DumpRenderTree/mac/DumpRenderTree.mm:
3090         (resetDefaultsToConsistentValues):
3091         * DumpRenderTree/mac/UIDelegate.mm:
3092         (-[UIDelegate webView:shouldHaltPlugin:]):
3093
3094 2009-10-08  Brady Eidson  <beidson@apple.com>
3095
3096         Reviewed by Dan Bernstein.
3097
3098         Ask the History Delegate to populate the visited links hash.
3099         <rdar://problem/7285293> and https://webkit.org/b/29904
3100
3101         Add the ability for LayoutTestController to clear all visited links.
3102         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
3103
3104         * DumpRenderTree/LayoutTestController.cpp:
3105         (LayoutTestController::LayoutTestController):
3106         (removeAllVisitedLinksCallback):
3107         (LayoutTestController::staticFunctions):
3108         * DumpRenderTree/LayoutTestController.h:
3109         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3110         (LayoutTestController::removeAllVisitedLinks):
3111
3112         * DumpRenderTree/mac/HistoryDelegate.mm:
3113         (-[HistoryDelegate populateVisitedLinksForWebView:]):
3114
3115         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3116         (LayoutTestController::removeAllVisitedLinks):
3117         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3118         (LayoutTestController::removeAllVisitedLinks):
3119         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3120         (LayoutTestController::removeAllVisitedLinks):
3121
3122
3123 2009-10-08  Daniel Bates  <dbates@webkit.org>
3124
3125         Reviewed by Adam Roben.
3126
3127         https://bugs.webkit.org/show_bug.cgi?id=30175
3128
3129         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
3130         the OLE drag-and-drop return value like the function it emulates. Currently,
3131         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine
3132         whether the drag-and-drop operation was successful or was cancelled.
3133
3134         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop
3135         return value according to whether the drop operation was successful or not.
3136
3137         * DumpRenderTree/win/EventSender.cpp:
3138         (doMouseUp): Added parameter oleDragAndDropReturnValue.
3139         (replaySavedEvents): Ditto.
3140         * DumpRenderTree/win/EventSender.h:
3141         * DumpRenderTree/win/UIDelegate.cpp:
3142         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
3143
3144 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3145
3146         Reviewed by Xan Lopez.
3147
3148         [GTK] Added support for a parameter setting the button that was
3149         pressed in the mouseDown function.
3150         https://bugs.webkit.org/show_bug.cgi?id=30220
3151
3152         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3153
3154 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3155
3156         Reviewed by Xan Lopez.
3157
3158         [GTK] Added a line to the bottom of the expected result to match
3159         the output of the test.
3160         https://bugs.webkit.org/show_bug.cgi?id=30220
3161
3162         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
3163         expected.txt:
3164
3165 2009-10-08  Adam Roben  <aroben@apple.com>
3166
3167         Use QueryInterface to get IWebInspectorPrivate
3168
3169         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
3170         accessed in a more standard way
3171
3172         Reviewed by John Sullivan and Tim Hatcher.
3173
3174         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3175         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
3176         by calling IWebViewPrivate::inspector, then use QueryInterface to get
3177         to the IWebInspectorPrivate interface.
3178
3179 2009-10-07  Adam Roben  <aroben@apple.com>
3180
3181         Implement DRT support for origin whitelisting
3182
3183         Fixes <http://webkit.org/b/30185>.
3184
3185         Reviewed by Eric Seidel.
3186
3187         * DumpRenderTree/win/DumpRenderTree.cpp:
3188         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
3189         whitelist, to match Mac DRT.
3190         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3191         (LayoutTestController::whiteListAccessFromOrigin): Call through to
3192         IWebViewPrivate::whiteListAccessFromOrigin.
3193
3194 2009-10-07  Brady Eidson  <beidson@apple.com>
3195
3196         Reviewed by Darin Adler.
3197
3198         Send title changes to the global history delegate.
3199         <rdar://problem/7285293> and https://webkit.org/b/29904
3200
3201         * DumpRenderTree/mac/HistoryDelegate.mm:
3202         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
3203
3204 2009-10-07  Adam Barth  <abarth@webkit.org>
3205
3206         Unreviewed.  Remove some folks from committers.py who were listed on
3207         the WebKit Team wiki page but who weren't actually listed as commit+.
3208         At some point, we should coorelate this list with the committers
3209         mailing list.
3210
3211         * Scripts/modules/committers.py:
3212
3213 2009-10-07  Adam Barth  <abarth@webkit.org>
3214
3215         Unreviewed.  Import a bunch of committers from the WebKit Team page on
3216         the wiki into committers.py.
3217
3218         * Scripts/modules/committers.py:
3219
3220 2009-10-07  Adam Barth  <abarth@webkit.org>
3221
3222         Unreviewed.  Added Aaron Boodman to committers.py.
3223
3224         * Scripts/modules/committers.py:
3225
3226 2009-10-07  Evan Martin  <evan@chromium.org>
3227
3228         Reviewed by Darin Adler.
3229
3230         Add API to LayoutTestController for re/setting the system locale.
3231         https://bugs.webkit.org/show_bug.cgi?id=18994
3232
3233         * DumpRenderTree/LayoutTestController.cpp:
3234         (setLocaleCallback):
3235         (LayoutTestController::staticFunctions):
3236         (LayoutTestController::setLocale):
3237         * DumpRenderTree/LayoutTestController.h:
3238
3239 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
3240
3241         Reviewed by Jan Alonzo.
3242
3243         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3244         https://bugs.webkit.org/show_bug.cgi?id=29689
3245
3246         Build fix by adding -lfontconfig for DumpRenderTree.
3247
3248         * GNUmakefile.am:
3249
3250 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3251
3252         Reviewed by Simon Hausmann.
3253
3254         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
3255
3256         * Scripts/run-webkit-tests:
3257
3258 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3259
3260         Reviewed by Gustavo Noronha.
3261
3262         "delete" in EventSender is the backspace key, not the delete one.
3263
3264         * DumpRenderTree/gtk/EventSender.cpp:
3265         (keyDownCallback):
3266
3267 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3268
3269         Reviewed by Gustavo Noronha.
3270
3271         getChildrenWithRange expects as last parameter the end index, not
3272         the length of the range. Correct this and clarify the variable
3273         names to reflect how the code works.
3274
3275         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3276         (AccessibilityUIElement::getChildrenWithRange):
3277         (AccessibilityUIElement::getChildAtIndex):
3278
3279 2009-10-06  Mark Rowe  <mrowe@apple.com>
3280
3281         Reviewed by Simon Fraser.
3282
3283         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
3284
3285         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
3286         the fact we have already changed the working directory to the top of the open source tree.
3287
3288 2009-10-06  Julie Parent  <jparent@chromium.org>
3289
3290         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
3291         rather than my committer email.
3292
3293         * Scripts/modules/committers.py:
3294
3295 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3296
3297         Reviewed by Eric Seidel.
3298
3299         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
3300
3301         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
3302         it after each layout test as it should do, making the DRT dump additional output
3303         for all of the subsequent layout tests.
3304
3305         * DumpRenderTree/qt/jsobjects.cpp:
3306         (LayoutTestController::reset):
3307
3308 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3309
3310         Reviewed by Simon Hausmann.
3311
3312         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
3313         fast/dom/assign-to-window-status.html test, which is passing as a result.
3314
3315         https://bugs.webkit.org/show_bug.cgi?id=30127
3316
3317         * DumpRenderTree/qt/DumpRenderTree.cpp:
3318         (WebCore::DumpRenderTree::DumpRenderTree):
3319         (WebCore::DumpRenderTree::statusBarMessage):
3320         * DumpRenderTree/qt/DumpRenderTree.h:
3321         * DumpRenderTree/qt/jsobjects.h:
3322         (LayoutTestController::shouldDumpStatusCallbacks):
3323         (LayoutTestController::dumpStatusCallbacks):
3324
3325 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3326
3327         Reviewed by Simon Hausmann.
3328
3329         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
3330         ignores the argument indicating which mouse button to trigger.
3331         https://bugs.webkit.org/show_bug.cgi?id=30048
3332
3333         This affects the fast/events/mouse-click-events.html layout test.
3334
3335         * DumpRenderTree/qt/jsobjects.cpp:
3336         (EventSender::mouseDown):
3337         (EventSender::mouseUp):
3338         * DumpRenderTree/qt/jsobjects.h:
3339
3340 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3341
3342         Reviewed by Simon Hausmann.
3343
3344         [Qt] Fix the EventSender::keyDown() implementation
3345         https://bugs.webkit.org/show_bug.cgi?id=30043
3346
3347         It should post both a key press event and a key release event,
3348         just like other ports do.
3349
3350         * DumpRenderTree/qt/jsobjects.cpp:
3351         (EventSender::keyDown):
3352
3353 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
3354
3355         wx build fix. Add jpeg to the list of libs to link against.
3356
3357         * wx/build/settings.py:
3358
3359 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
3360
3361         Reviewed by Simon Hausmann.
3362
3363         [Qt] EventSender::keyDown() cannot send function-key events.
3364         https://bugs.webkit.org/show_bug.cgi?id=30044
3365
3366         This affects the fast/events/keydown-function-keys.html layout test.
3367
3368         * DumpRenderTree/qt/jsobjects.cpp:
3369         (EventSender::keyDown):
3370
3371 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
3372
3373         Added --wx-compiler-prefix waf option to allow building wxWebKit with
3374         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
3375
3376         * wx/build/settings.py:
3377         * wx/build/wxpresets.py:
3378
3379 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
3380
3381         Reviewed by Timothy Hatcher.
3382
3383         Web Inspector: add testing harness for Web Inspector.
3384
3385         https://bugs.webkit.org/show_bug.cgi?id=30010
3386
3387         * DumpRenderTree/LayoutTestController.cpp:
3388         (showWebInspectorCallback):
3389         (closeWebInspectorCallback):
3390         (evaluateInWebInspectorCallback):
3391         (LayoutTestController::staticFunctions):
3392         * DumpRenderTree/LayoutTestController.h:
3393         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3394         (LayoutTestController::showWebInspector):
3395         (LayoutTestController::closeWebInspector):
3396         (LayoutTestController::evaluateInWebInspector):
3397         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3398         (LayoutTestController::showWebInspector):
3399         (LayoutTestController::closeWebInspector):
3400         (LayoutTestController::evaluateInWebInspector):
3401         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3402         (LayoutTestController::showWebInspector):
3403         (LayoutTestController::closeWebInspector):
3404         (LayoutTestController::evaluateInWebInspector):
3405         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3406         (LayoutTestController::showWebInspector):
3407         (LayoutTestController::closeWebInspector):
3408         (LayoutTestController::evaluateInWebInspector):
3409
3410 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3411
3412         Reviewed by Ariyha Hidayat.
3413
3414         Pass arguments to system() as a string instead of array
3415
3416         When passed as an array entries with a space fail to translate
3417         to two arguments to the child process, so instead of manually
3418         splitting all the entries in @buildArgs we pass the whole thing
3419         as a string instead.
3420
3421         * Scripts/webkitdirs.pm:
3422
3423 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
3424
3425         Reviewed by David Levin.
3426
3427         check-webkit-style misses whitespace errors for operators:
3428         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
3429         https://bugs.webkit.org/show_bug.cgi?id=30021
3430
3431         * Scripts/modules/cpp_style.py:
3432         Added the operators mentioned above to the same list as == and !=.
3433
3434 2009-10-02  Julie Parent  <jparent@chromium.org>
3435
3436         Unreviewed.
3437
3438         Adding myself and Ojan Vafai as committers, because we are committers.
3439
3440         * Scripts/modules/committers.py:
3441
3442 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
3443
3444         Reviewed by Adam Roben.
3445
3446         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
3447         this will help the patch merging process when TryBots are used.
3448
3449         * Scripts/svn-create-patch:
3450
3451 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
3452
3453         Reviewed by Simon Hausmann.
3454
3455         [Qt] Implement layoutTestController.overridePreference().
3456         https://bugs.webkit.org/show_bug.cgi?id=29970
3457
3458         * DumpRenderTree/qt/DumpRenderTree.cpp:
3459         (WebCore::WebPage::WebPage):
3460         (WebCore::WebPage::resetSettings):
3461         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3462         * DumpRenderTree/qt/jsobjects.cpp:
3463         (LayoutTestController::reset):
3464         (LayoutTestController::setPrivateBrowsingEnabled):
3465         (LayoutTestController::setPopupBlockingEnabled):
3466         (LayoutTestController::overridePreference):
3467         * DumpRenderTree/qt/jsobjects.h:
3468
3469 2009-10-01  Chris Marrin  <cmarrin@apple.com>
3470
3471         Reviewed by Oliver Hunt.
3472
3473         Turn on ENABLE_3D_CANVAS in TOT
3474         https://bugs.webkit.org/show_bug.cgi?id=29906
3475
3476         * Scripts/build-webkit:
3477
3478 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3479
3480         Rubberstamped by Simon Hausmann.
3481
3482         Enable HTTP tests for Qt
3483
3484         * Scripts/run-webkit-tests:
3485
3486 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
3487
3488         Reviewed by Dimitri Glazkov.
3489
3490         build-webkit --chromium now also works on cygwin.
3491
3492         https://bugs.webkit.org/show_bug.cgi?id=29973
3493
3494         * Scripts/webkitdirs.pm:
3495
3496 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
3497
3498         Reviewed by Simon Hausmann.
3499
3500         [Qt] Don't use TCmalloc in DumpRenderTree
3501         https://bugs.webkit.org/show_bug.cgi?id=27029
3502
3503         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
3504
3505         * DumpRenderTree/qt/DumpRenderTree.pro:
3506
3507 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3508
3509         Reviewed by Simon Hausmann.
3510
3511         [Qt] Implement eventSender.scheduleAsynchronousClick().
3512
3513         https://bugs.webkit.org/show_bug.cgi?id=29931
3514
3515         * DumpRenderTree/qt/jsobjects.cpp:
3516         (EventSender::scheduleAsynchronousClick):
3517         * DumpRenderTree/qt/jsobjects.h:
3518
3519 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3520
3521         Reviewed by Simon Hausmann.
3522
3523         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
3524         fast/events/open-window-from-another-frame.html from the Skipped list.
3525
3526         https://bugs.webkit.org/show_bug.cgi?id=29930
3527
3528         * DumpRenderTree/qt/jsobjects.cpp:
3529         (LayoutTestController::setPopupBlockingEnabled):
3530         * DumpRenderTree/qt/jsobjects.h:
3531
3532 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
3533
3534         Unreviewed.
3535
3536         Added myself to the list of committers.
3537
3538         * Scripts/modules/committers.py:
3539
3540 2009-09-30  Eric Seidel  <eric@webkit.org>
3541
3542         No review, just adding Geoff to the list of reviewers.
3543
3544         * Scripts/modules/committers.py:
3545
3546 2009-09-30  Dan Bernstein  <mitz@apple.com>
3547
3548         Reviewed by Sam Weinig.
3549
3550         Added the WebKit Layout Tests fonts that are referenced in
3551         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
3552
3553         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
3554         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
3555
3556 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3557
3558         Reviewed by David Kilzer.
3559
3560         Make sunspider scripts work on Windows platform.
3561         https://bugs.webkit.org/show_bug.cgi?id=29656
3562
3563         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
3564         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
3565         * Scripts/webkitdirs.pm: currentPerlPath() added.
3566
3567 2009-09-29  Brady Eidson  <beidson@apple.com>
3568
3569         Rubberstamped by Dan Bernstein.
3570
3571         Fix license and some sorting in new files.
3572
3573         * DumpRenderTree/mac/HistoryDelegate.h:
3574         * DumpRenderTree/mac/HistoryDelegate.mm:
3575
3576 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
3577
3578         Reviewed by David Kilzer.
3579
3580         Fixed how error codes are handled.
3581         https://bugs.webkit.org/show_bug.cgi?id=29898
3582
3583         * Scripts/update-webkit:
3584         * Scripts/update-webkit-chromium:
3585
3586 2009-09-29  Brady Eidson  <beidson@apple.com>
3587
3588         Reviewed by John Sullivan.
3589
3590         Updated way-out-of-date sorting throughout the dump methods/flags.
3591
3592         * DumpRenderTree/LayoutTestController.cpp:
3593         (LayoutTestController::LayoutTestController):
3594         (dumpAsPDFCallback):
3595         (dumpAsTextCallback):
3596         (dumpFrameLoadCallbacksCallback):
3597         (dumpResourceLoadCallbacksCallback):
3598         (LayoutTestController::staticFunctions):
3599
3600         * DumpRenderTree/LayoutTestController.h:
3601         (LayoutTestController::dumpAsText):
3602         (LayoutTestController::setDumpAsText):
3603         (LayoutTestController::dumpFrameLoadCallbacks):
3604         (LayoutTestController::setDumpFrameLoadCallbacks):
3605         (LayoutTestController::dumpSelectionRect):
3606         (LayoutTestController::setDumpSelectionRect):
3607         (LayoutTestController::dumpSourceAsWebArchive):
3608         (LayoutTestController::setDumpSourceAsWebArchive):
3609         (LayoutTestController::dumpStatusCallbacks):
3610         (LayoutTestController::setDumpStatusCallbacks):
3611         (LayoutTestController::dumpTitleChanges):
3612         (LayoutTestController::setDumpTitleChanges):
3613         (LayoutTestController::dumpWillCacheResponse):
3614         (LayoutTestController::setDumpWillCacheResponse):
3615
3616 2009-09-29  Brady Eidson  <beidson@apple.com>
3617
3618         Reviewed by John Sullivan.
3619
3620         WebKit Mac API should provide a delegate interface for global history.
3621         <rdar://problem/7042773> and https://webkit.org/b/29904
3622
3623         Adding the dumping of global history delegate callbacks.
3624
3625         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3626
3627         Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
3628         * DumpRenderTree/mac/DumpRenderTree.mm:
3629         (createWebViewAndOffscreenWindow):
3630         (allocateGlobalControllers):
3631         (shouldLogFrameLoadDelegates):
3632         (shouldLogHistoryDelegates):
3633         (runTest):
3634
3635         Dump history delegate callbacks:
3636         * DumpRenderTree/mac/HistoryDelegate.h: Added.
3637         * DumpRenderTree/mac/HistoryDelegate.mm: Added.
3638         (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
3639         (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
3640         (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
3641
3642 2009-09-29  Daniel Bates  <dbates@webkit.org>
3643
3644         Reviewed by Adam Roben.
3645
3646         https://bugs.webkit.org/show_bug.cgi?id=28902
3647
3648         Fixes an issue where the drop effect returned by Window Dump Render Tree
3649         was always DROPEFFECT_NONE (since it was hard coded to do so).
3650
3651         This patch corrects this issue by determining the actual drop effect
3652         performed by the corresponding drag-and-drop operation so that we can
3653         return it.
3654
3655         * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
3656         (DraggingInfo::DraggingInfo):
3657         (DraggingInfo::performedDropEffect): Added method.
3658         (DraggingInfo::setPerformedDropEffect): Added method.
3659         * DumpRenderTree/win/EventSender.cpp:
3660         (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
3661         Moved delete draggingInfo to UIDelegate::doDragDrop.
3662         * DumpRenderTree/win/UIDelegate.cpp:
3663         (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
3664
3665 2009-09-29  Dan Bernstein  <mitz@apple.com>
3666
3667         Reviewed by Adam Roben.
3668
3669         Remove copying of unnecessary or nonexistent files from the ImageDiff
3670         post-build event.
3671
3672         * DumpRenderTree/win/ImageDiff.vcproj:
3673
3674 2009-09-29  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3675
3676         Reviewed by David Kilzer.
3677
3678         [Qt] Make build-webkit script work on Windows
3679         https://bugs.webkit.org/show_bug.cgi?id=29802
3680
3681         * Scripts/run-webkit-tests:
3682         * Scripts/webkitdirs.pm:
3683          - Removed unnecessary -p switch for mkdir on Windows.
3684          - Use canonical path, which uses slashes or backslashes depends on platform.
3685          - isWindows() only test for Windows and not for Cyqwin.
3686
3687 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3688
3689         Reviewed by Simon Hausmann.
3690
3691         Fix&n