13b324975f14540286d76704ff0c037c50744164
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-09-30  Chris Marrin  <cmarrin@apple.com>
2
3         Reviewed by Simon Fraser.
4
5         Make 2D accelerated canvas rendering build on Mac
6         https://bugs.webkit.org/show_bug.cgi?id=46007
7         
8         Added ACCELERATED_2D_CANVAS to build-webkit
9
10         * Scripts/build-webkit:
11
12 2010-09-29  Kenneth Russell  <kbr@google.com>
13
14         Reviewed by Dimitri Glazkov.
15
16         [chromium] Add accelerated compositing support to DumpRenderTree and test_shell
17         https://bugs.webkit.org/show_bug.cgi?id=46849
18
19         Added offscreen code path for WebGraphicsContext3DDefaultImpl which
20         works with the compositor integration in both DumpRenderTree and
21         test_shell, since both pass a non-null WebCanvas* to WebViewImpl::paint
22         and thereby trigger the compositor's readback code path. Added support
23         for --enable-accelerated-compositing to DumpRenderTree.
24
25         Tested in both test_shell and DumpRenderTree on Linux, the latter by
26         modifying a compositing layout test, dumping the pixels and verifying
27         that they matched the output when the compositor was active.
28
29         * DumpRenderTree/chromium/DumpRenderTree.cpp:
30         (main):
31         * DumpRenderTree/chromium/TestShell.cpp:
32         (TestShell::TestShell):
33         (TestShell::resetWebSettings):
34         * DumpRenderTree/chromium/TestShell.h:
35         (TestShell::setAcceleratedCompositingEnabled):
36         * DumpRenderTree/chromium/WebPreferences.cpp:
37         (WebPreferences::reset):
38         (WebPreferences::applyTo):
39         * DumpRenderTree/chromium/WebPreferences.h:
40         * DumpRenderTree/chromium/WebViewHost.cpp:
41         (WebViewHost::scheduleComposite):
42         * DumpRenderTree/chromium/WebViewHost.h:
43
44 2010-09-30  Adam Roben  <aroben@apple.com>
45
46         Ensure that QueueEngine cleans up its log files when its delegate
47         tells it to stop processing work
48
49         Reviewed by Adam Barth.
50
51         Fixes <http://webkit.org/b/46891> <rdar://problem/8496638> Many tests
52         in webkitpy.tool.bot.queueengine_unittest.QueueEngineTest crash on
53         Windows
54
55         * Scripts/webkitpy/tool/bot/queueengine.py:
56         (QueueEngine.run): Stop ourselves normally (including cleaning up log
57         files) when the delegate tells us to stop processing work.
58
59         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
60         (LoggingDelegate.__init__): Moved code here from
61         RaisingDelegate.__init__.
62         (LoggingDelegate.expeced_callbacks): Added the stop_work_queue
63         callback.
64         (LoggingDelegate.stop_work_queue): Moved here from RaisingDelegate.
65         (RaisingDelegate.__init__): Removed code that LoggingDelegate takes
66         care of for us now.
67         (QueueEngineTest.test_trivial): Make sure we got the expected stop
68         message.
69         (QueueEngineTest.test_not_safe_to_proceed): Changed to explicitly
70         remove the callbacks that are related to processing a single work
71         item, rather than removing all callbacks after a certain point, as
72         there are now more callbacks we expect to receive at the end.
73
74 2010-09-30  Adam Roben  <aroben@apple.com>
75
76         Fix path -> URL conversion on Cygwin
77
78         Reviewed by Adam Barth.
79
80         Fixes <http://webkit.org/b/46890> <rdar://problem/8496637> Many tests
81         in webkitpy.layout_tests.run_webkit_tests_unittest assert on Windows
82
83         * Scripts/webkitpy/layout_tests/port/base.py:
84         (Port.filename_to_uri): Treat Cygwin like other UNIX-y platforms by
85         assuming paths already have a leading slash.
86
87 2010-09-30  Adam Roben  <aroben@apple.com>
88
89         Teach WindowGeometryInitializedBeforeSetWindow that NPP_SetWindow can
90         be called more than once
91
92         The NPP_SetWindow call made when the plugin is torn down was confusing
93         us, and was causing us to spew an error into the next test.
94
95         Fixes <http://webkit.org/b/46900> <rdar://problem/8496888> REGRESSION
96         (r68520): plugins/access-after-page-destroyed.html failing on Windows
97
98         Reviewed by Anders Carlsson.
99
100         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
101         (WindowGeometryInitializedBeforeSetWindow::WindowGeometryInitializedBeforeSetWindow):
102         Initialize member.
103         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Bail if
104         this isn't the first time this is called.
105
106 2010-09-30  Eric Seidel  <eric@webkit.org>
107
108         Reviewed by Adam Barth.
109
110         webkit-patch upload warns that I'm using Xcode when I'm not
111         https://bugs.webkit.org/show_bug.cgi?id=46869
112
113         String.find returns -1 when not found, so switched to "in".
114
115         * Scripts/webkitpy/common/system/user.py:
116         * Scripts/webkitpy/common/system/user_unittest.py:
117
118 2010-09-30  Eric Seidel  <eric@webkit.org>
119
120         Reviewed by Adam Barth.
121
122         webkit-patch failure-reason dies if non-trunk commits are in the blame range
123         https://bugs.webkit.org/show_bug.cgi?id=46866
124
125         I also made failure-reason use RegressionWindow in a cleaner way.
126
127         * Scripts/webkitpy/tool/commands/queries.py:
128
129 2010-09-29  Adam Barth  <abarth@webkit.org>
130
131         Reviewed by Eric Seidel.
132
133         webkit-patch find-flaky-tests
134         https://bugs.webkit.org/show_bug.cgi?id=46876
135
136         This command helps us find flaky tests so we can squash them.
137
138         * Scripts/webkitpy/tool/commands/queries.py:
139
140 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
141
142         Fix export to use '?' instead of 'null' for
143         tests with no results.
144         
145         * CSSTestSuiteHarness/harness/harness.js:
146
147 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
148
149         Add a warning when a test requires special steps.
150         Add a Print Preview button for 'paged' tests that
151         brings up the print dialog, allowing the user to 
152         judge paged media tests.
153
154         * CSSTestSuiteHarness/harness/harness.css:
155         * CSSTestSuiteHarness/harness/harness.html:
156         * CSSTestSuiteHarness/harness/harness.js:
157         (TestSuite.prototype.loadTest):
158         (TestSuite.prototype.processFlags):
159
160 2010-09-29  Adam Barth  <abarth@webkit.org>
161
162         Reviewed by Eric Seidel.
163
164         Remove revisions_casuing_failures
165         https://bugs.webkit.org/show_bug.cgi?id=46872
166
167         This function exists only to be unit tested.
168
169         * Scripts/webkitpy/common/net/failuremap.py:
170         * Scripts/webkitpy/common/net/failuremap_unittest.py:
171         * Scripts/webkitpy/tool/mocktool.py:
172
173 2010-09-29  Adam Barth  <abarth@webkit.org>
174
175         Reviewed by Eric Seidel.
176
177         SheriffBot should post the list of failing tests to bugs
178         https://bugs.webkit.org/show_bug.cgi?id=46871
179
180         * Scripts/webkitpy/common/net/buildbot.py:
181         * Scripts/webkitpy/common/net/failuremap.py:
182         * Scripts/webkitpy/common/net/regressionwindow.py:
183         * Scripts/webkitpy/tool/bot/sheriff.py:
184         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
185         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
186         * Scripts/webkitpy/tool/commands/queues_unittest.py:
187         * Scripts/webkitpy/tool/commands/sheriffbot.py:
188         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
189         * Scripts/webkitpy/tool/commands/upload_unittest.py:
190         * Scripts/webkitpy/tool/mocktool.py:
191
192 2010-09-29  Brent Fulgham  <bfulgham@webkit.org>
193
194         Reviewed by Martin Robinson, Eric Seidel, and Mark Rowe.
195
196         [WinCairo] Adds a build slave.
197         https://bugs.webkit.org/show_bug.cgi?id=46360
198
199         * BuildSlaveSupport/build.webkit.org-config/config.json: Add
200         entries for a debug build of the WinCairo port.
201         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add
202         platform flag to configuration for wincairo (like gtk, chromium, etc.)
203         * Scripts/build-webkit: Change 'cairo-win32' labeling to 'wincairo'
204         * Scripts/webkitdirs.pm: Change 'cairo-win32' labeling to 'wincairo'
205
206 2010-09-29  Adam Barth  <abarth@webkit.org>
207
208         Reviewed by Eric Seidel.
209
210         Move more SheriffBot smarts into FailureMap
211         https://bugs.webkit.org/show_bug.cgi?id=46703
212
213         This patch pushes the FailureMap model object further into the
214         SheriffBot machine.  In addition, it moves a couple operations on this
215         object from SheriffBot itself to the model.
216
217         Eventually, FailureMap will be the canonical context object for
218         SheriffBot operations.  FailureMap represents a map of the current
219         failures on the bots that might require remediation.
220
221         * Scripts/webkitpy/common/net/failuremap.py:
222         * Scripts/webkitpy/common/net/regressionwindow.py:
223         * Scripts/webkitpy/tool/commands/queries.py:
224         * Scripts/webkitpy/tool/commands/sheriffbot.py:
225         * Scripts/webkitpy/tool/mocktool.py:
226
227 2010-09-29  Tony Chang  <tony@chromium.org>
228
229         Reviewed by James Robinson.
230
231         [chromium] enable -Werror for DRT and webkit_unit_tests on Linux
232         https://bugs.webkit.org/show_bug.cgi?id=46829
233
234         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
235         (DRTDevToolsClient::DRTDevToolsClient):
236         * DumpRenderTree/chromium/TestShell.cpp:
237         (TestShell::TestShell):
238         * DumpRenderTree/chromium/WebViewHost.cpp:
239         (WebViewHost::postAccessibilityNotification):
240         (WebViewHost::WebViewHost):
241
242 2010-09-29  Chris Fleizach  <cfleizach@apple.com>
243
244         Reviewed by Darin Adler.
245
246         AX: implement CSS3 Speech "speak"
247         https://bugs.webkit.org/show_bug.cgi?id=46827
248
249         * DumpRenderTree/AccessibilityUIElement.cpp:
250         (speakCallback):
251         (AccessibilityUIElement::speak):
252         (AccessibilityUIElement::getJSClass):
253         * DumpRenderTree/AccessibilityUIElement.h:
254         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
255         (AccessibilityUIElement::speak):
256
257 2010-09-29  Mihai Parparita  <mihaip@chromium.org>
258
259         Reviewed by Adam Barth.
260
261         Record bot ID when updating queue status
262         https://bugs.webkit.org/show_bug.cgi?id=46764
263         
264         Since we now have multiple bots handling patches from the commit queue,
265         we need to differentiate status updates from them, so that we can group
266         the queue status page in a less confusing way.
267
268         * QueueStatusServer/handlers/updatestatus.py: Accept bot_id as input
269         * QueueStatusServer/model/queuestatus.py: Add bot_id property
270         * QueueStatusServer/templates/updatestatus.html: Add bot_id input
271         * Scripts/webkitpy/common/net/bugzilla_unittest.py: Extract MockBrowser
272         * Scripts/webkitpy/common/net/statusserver.py: Add bot_id
273         * Scripts/webkitpy/common/net/statusserver_unittest.py: Added.
274         * Scripts/webkitpy/tool/main.py: Add --bot-id
275         * Scripts/webkitpy/tool/mocktool.py: Add MockBrowser
276
277 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
278
279         No review.
280         
281         References always refert to a file in .xht format, even
282         for HTML tests, so fix their loading.
283
284         * CSSTestSuiteHarness/harness/harness.js:
285         (TestSuite.prototype.loadRef):
286
287 2010-09-28  Johnny Ding  <jnd@chromium.org>
288
289         Reviewed by Adam Barth.
290
291         https://bugs.webkit.org/show_bug.cgi?id=41292
292         Add a new parameter to the test plugin to allow specifying a script 
293         and a mouse/keyboard event. The specified script will be evaluated
294         in the browser when the specified event is received by the plugin.
295
296         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
297         (pluginAllocate):
298         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
299         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
300         (NPP_New):
301         (handleEventCarbon):
302         (handleEventCocoa):
303
304 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
305
306         Fix export by adding missing argument.
307
308         * CSSTestSuiteHarness/harness/harness.js:
309         (TestSuite.prototype.showResultsForAllTests):
310
311 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
312
313         [wx] Build fix, add missing import.
314
315         * wx/packaging/build-win-installer.py:
316
317 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
318
319         No review
320         
321         Show which tests have been run by dimming them out in the test list.
322         
323         Adjust some element sizes.
324         
325         * CSSTestSuiteHarness/harness/harness.css:
326         (#test-list > option.untested):
327         (#test-list > option.completed):
328         (#output):
329         (.output-options):
330         * CSSTestSuiteHarness/harness/harness.js:
331         (Test):
332         (TestSuite.prototype.fillTestList):
333         (TestSuite.prototype.updateTestList):
334         (TestSuite.prototype.setSelectedChapter):
335         (TestSuite.prototype.recordResult):
336         (TestSuite.prototype.markTestCompleted):
337         (TestSuite.prototype.testCompletionStateChanged):
338         (TestSuite.prototype.loadTestStatus):
339
340 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
341
342         No review.
343         
344         Implement export of various queries on the test database, sharing
345         code with that which displays results inline.
346
347         * CSSTestSuiteHarness/harness/harness.js:
348         ():
349         (TestSuite.prototype.exportResultsCompletion.var):
350         (TestSuite.prototype.exportResultsCompletion):
351         (TestSuite.prototype.showResultsForCompletedTests):
352         (TestSuite.prototype.exportResultsForCompletedTests):
353         (TestSuite.prototype.showResultsForAllTests):
354         (TestSuite.prototype.exportResultsForAllTests):
355         (TestSuite.prototype.exportResultsForTestsNotRun):
356         (TestSuite.prototype.exportResultsForTestsWithStatus):
357         (TestSuite.prototype.exportResultsForTestsWithMismatchedResults):
358
359 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
360
361         No review.
362
363         Work around uncertainty about the order of database
364         transactions when creating the database, so that we don't
365         try to query the table before it has been created.
366
367         * CSSTestSuiteHarness/harness/harness.js:
368         (TestSuite):
369         (TestSuite.prototype.databaseCreated):
370         (TestSuite.prototype.storeTestResult):
371         (TestSuite.prototype.populateDatabaseFromTestInfoData):
372         (TestSuite.prototype.queryDatabaseForTestsWithStatus):
373         (TestSuite.prototype.queryDatabaseForTestsWithMixedStatus):
374         (TestSuite.prototype.queryDatabaseForCompletedTests):
375         (TestSuite.prototype.queryDatabaseForTestsNotRun):
376
377 2010-09-28  Tony Chang  <tony@chromium.org>
378
379         Reviewed by Eric Seidel.
380
381         add python keyring support to webkit-patch
382         https://bugs.webkit.org/show_bug.cgi?id=41269
383
384         * Scripts/webkitpy/common/net/credentials.py: Add the ability to read passwords using
385             the python keyring module
386         * Scripts/webkitpy/common/net/credentials_unittest.py:
387         * Scripts/webkitpy/common/system/user.py: Allow confirm() to default to no and add testing params.
388         * Scripts/webkitpy/common/system/user_unittest.py:
389         * Scripts/webkitpy/tool/mocktool.py:
390
391 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
392
393         Reviewed by Gustavo Noronha Silva.
394
395         [Cairo] FreeType fonts should obey FontConfig hinting/anti-aliasing settings
396         https://bugs.webkit.org/show_bug.cgi?id=46740
397
398         * DumpRenderTree/gtk/fonts/fonts.conf: Add specialized variants of common
399         fonts which can be used to fully test FontConfig rendering settings.
400
401 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
402
403         Reviewed by Gustavo Noronha Silva.
404
405         [gtk] Fedora has a different path for the liberation fonts
406         https://bugs.webkit.org/show_bug.cgi?id=46709
407
408         When searching for DRT fonts, also look in the path where those fonts
409         are commonly found on Fedora systems.
410
411         * DumpRenderTree/gtk/DumpRenderTree.cpp:
412         (initializeFonts): Include logic for looking for Fedora-style font paths.
413
414 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
415
416         Reviewed by Andreas Kling.
417
418         run-webkit-tests needs an updated list of directories with webgl tests
419         https://bugs.webkit.org/show_bug.cgi?id=46747
420
421         Update the list of directories containing WebGL tests and a unit test
422         which depends on this list.
423
424         * Scripts/old-run-webkit-tests: Update the list of directories.
425         * Scripts/webkitpy/layout_tests/port/webkit.py: Ditto.
426         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Update the expected result.
427
428 2010-09-28  Adam Barth  <abarth@webkit.org>
429
430         Reviewed by Eric Seidel.
431
432         Introduce FailureMap to summaries the failures status of all the bots
433         https://bugs.webkit.org/show_bug.cgi?id=46700
434
435         This patch gives the SheriffBot a handle on the list of failing tests.
436
437         * Scripts/webkitpy/common/net/buildbot.py:
438         * Scripts/webkitpy/common/net/failuremap.py: Added.
439         * Scripts/webkitpy/tool/commands/queries.py:
440         * Scripts/webkitpy/tool/commands/sheriffbot.py:
441         * Scripts/webkitpy/tool/mocktool.py:
442
443 2010-09-28  Adam Roben  <aroben@apple.com>
444
445         Update for the addition of WKPageUIClient::didNotHandleKeyEvent
446
447         Fixes <http://webkit.org/b/46660> <rdar://problem/8483465> Need API to
448         tell a WebKit2 client application that a key event was not handled
449
450         Reviewed by Kenneth Rohde Christiansen and Sam Weinig.
451
452         * MiniBrowser/mac/BrowserWindowController.m:
453         (-[BrowserWindowController awakeFromNib]):
454         * MiniBrowser/win/BrowserView.cpp:
455         (BrowserView::create):
456         * WebKitTestRunner/TestController.cpp:
457         (WTR::createOtherPage):
458         (WTR::TestController::initialize):
459
460 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
461
462         Unreviewed.
463
464         Update the CSSTestSuiteHarness to not scrape the XHTML chapter files
465         for the test order, but instead use information from testinfo.data.
466         
467         * CSSTestSuiteHarness/harness/harness.html:
468         * CSSTestSuiteHarness/harness/harness.js:
469
470 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
471
472         [wx] Build fix, don't try to get the svn revision from the git repo when packaging,
473         it causes the process to hang on the gitorious repo.
474
475         * wx/packaging/build-mac-installer.py:
476         * wx/packaging/build-win-installer.py:
477
478 2010-09-28  Adam Roben  <aroben@apple.com>
479
480         Test that a plugin's HWND is sized/positioned before NPP_SetWindow is
481         called
482
483         Reviewed by Anders Carlsson.
484
485         Test for <http://webkit.org/b/46716> <rdar://problem/8482014>
486         Full-page Adobe Reader does not paint until window is resized
487
488         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
489         (PluginTest::NPP_SetWindow): Added. Just returns NPERR_NO_ERROR at
490         this level.
491
492         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Declared
493         NPP_SetWindow.
494
495         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp: Added.
496         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Checks that
497         the plugin's HWND has a non-zero size and that its size/position
498         matches that specified in the NPWindow.
499
500         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
501         (NPP_SetWindow): Call through to the PluginTest.
502
503         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
504         Added WindowGeometryInitializedBeforeSetWindow.cpp, and let VS reorder
505         the files as it saw fit.
506
507 2010-09-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
508
509         Reviewed by Andreas Kling.
510
511         [Qt] Remove support for Qt 4.5
512         https://bugs.webkit.org/show_bug.cgi?id=46718
513
514         Remove the code for versions of Qt prior to 4.6.
515
516         * DumpRenderTree/qt/EventSenderQt.cpp:
517         (EventSender::addTouchPoint):
518         (EventSender::updateTouchPoint):
519         (EventSender::setTouchModifier):
520         (EventSender::touchStart):
521         (EventSender::touchMove):
522         (EventSender::touchEnd):
523         (EventSender::clearTouchPoints):
524         (EventSender::releaseTouchPoint):
525         (EventSender::sendTouchEvent):
526         * DumpRenderTree/qt/EventSenderQt.h:
527         * DumpRenderTree/qt/TextInputControllerQt.cpp:
528         (TextInputController::setMarkedText):
529         * QtTestBrowser/launcherwindow.cpp:
530         (LauncherWindow::LauncherWindow):
531         (LauncherWindow::initializeView):
532         (LauncherWindow::createChrome):
533         (LauncherWindow::sendTouchEvent):
534         (LauncherWindow::eventFilter):
535         (LauncherWindow::applyZoom):
536         (LauncherWindow::setTouchMocking):
537         * QtTestBrowser/launcherwindow.h:
538         * QtTestBrowser/utils.cpp:
539         (urlFromUserInput):
540         * QtTestBrowser/webview.cpp:
541         (WebViewGraphicsBased::animatedFlip):
542         (WebViewGraphicsBased::animatedYFlip):
543         * QtTestBrowser/webview.h:
544         (WebViewGraphicsBased::setYRotation):
545
546 2010-09-28  İsmail Dönmez  <ismail@namtrac.org>
547
548         Reviewed by Andreas Kling.
549
550         Fix DRT compilation on WinCE. Introduce a WCECOMPAT variable
551         which should point to wcecompat installation. Needs wcecompat
552         library from http://github.com/mauricek/wcecompat .
553
554         * DumpRenderTree/qt/DumpRenderTree.pro:
555         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
556         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
557
558 2010-09-28  Daniel Bates  <dbates@rim.com>
559
560         Rollout changeset 68493 <http://trac.webkit.org/changeset/68493>
561         <https://bugs.webkit.org/show_bug.cgi?id=39136>
562
563         Rollout changeset 68493 because it broke Sheriffbot's rollout feature.
564         In particular, this change caused Sheriffbot to raise an exception when
565         trying to parse the bug id on a bug page. We need to look into this
566         some more.
567
568         * Scripts/webkitpy/common/net/bugzilla.py:
569         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
570         * Scripts/webkitpy/tool/bot/sheriff.py:
571         * Scripts/webkitpy/tool/commands/download.py:
572         * Scripts/webkitpy/tool/commands/queues.py:
573         * Scripts/webkitpy/tool/commands/upload.py:
574         * Scripts/webkitpy/tool/steps/closebug.py:
575         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
576         * Scripts/webkitpy/tool/steps/preparechangelog.py:
577         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
578
579 2010-09-28  Adam Barth  <abarth@webkit.org>
580
581         Reviewed by Eric Seidel.
582
583         Move RegressionWindow further up the dependency chain
584         https://bugs.webkit.org/show_bug.cgi?id=46698
585
586         Baby steps towards pushing this information into bug posts.
587
588         * Scripts/webkitpy/common/net/buildbot.py:
589         * Scripts/webkitpy/common/net/buildbot_unittest.py:
590         * Scripts/webkitpy/common/net/regressionwindow.py:
591         * Scripts/webkitpy/tool/commands/queries.py:
592
593 2010-09-27  Daniel Bates  <dbates@rim.com>
594
595         Reviewed by Adam Barth.
596
597         sheriffbot can't roll out security patches
598         https://bugs.webkit.org/show_bug.cgi?id=39136
599
600         Make SheriffBot determine if it's authorized to view a bug
601         whose change it wants to rollout before it tries to rollout
602         the change.
603
604         Moreover, make both webkit-patch and Sheriffbot provide human-
605         readable error messages when they are not authorized to view
606         a bug and when a bug number is invalid.
607
608         Currently, Sheriffbot does not parse Bugzilla bugs for
609         <bug error="...">, which indicates an error when retrieving
610         a bug. In particular, error="NotPermitted" if a person (or bot)
611         is not authorized to view a bug. For such error="NotPermitted" bugs,
612         Sheriffbot raises an exception when parsing the bug report and
613         this exception does not explicitly indicate Sheriffbot's lack
614         of authorization. Instead, Sheriffbot should explicitly check
615         for the presence <bug error="..."> before operating on a bug
616         and error with a human-readable message if it's not permitted
617         to view it.
618
619         * Scripts/webkitpy/common/net/bugzilla.py: Added BugzillaError class.
620         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
621           - Added unit test test_bug_parsing_for_bugzilla_not_permitted_error().
622           - Added unit test test_bug_parsing_for_bugzilla_not_found_error().
623           - Added unit test test_bug_parsing_for_bugzilla_invalid_bug_id_error().
624         * Scripts/webkitpy/tool/bot/sheriff.py: Modified to catch BugzillaError.
625         * Scripts/webkitpy/tool/commands/download.py: Ditto.
626         * Scripts/webkitpy/tool/commands/queues.py: Ditto.
627         * Scripts/webkitpy/tool/commands/upload.py: Ditto.
628         * Scripts/webkitpy/tool/steps/closebug.py: Ditto.
629         * Scripts/webkitpy/tool/steps/obsoletepatches.py: Ditto.
630         * Scripts/webkitpy/tool/steps/preparechangelog.py: Ditto.
631         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: Ditto.
632
633 2010-09-27  Adam Barth  <abarth@webkit.org>
634
635         Reviewed by Eric Seidel.
636
637         Expose more more failure information from Buildbot to SheriffBot
638         https://bugs.webkit.org/show_bug.cgi?id=46697
639
640         This patch moves the information about what tests failured closer to
641         SheriffBot.  There are still a couple more patches to go before
642         SheriffBot can post this information to bugs, but this is a step in
643         that direction.  Yay for unit tests, which caught some bugs in earlier
644         versions of this patch.
645
646         * Scripts/webkitpy/common/net/buildbot.py:
647         * Scripts/webkitpy/common/net/buildbot_unittest.py:
648         * Scripts/webkitpy/common/net/regressionwindow.py: Added.
649         * Scripts/webkitpy/tool/commands/queries.py:
650
651 2010-09-27  Eric Seidel  <eric@webkit.org>
652
653         Unreviewed.  Fixing 500 error seen in the status server.
654
655         It turns out that a = b = []; b.append(1); then a[0] will be 1!
656         This should have been obvious to me, I guess, but it was not what I was expecting.
657
658         * QueueStatusServer/model/activeworkitems.py:
659
660 2010-09-27  Adam Barth  <abarth@webkit.org>
661
662         Reviewed by Eric Seidel.
663
664         commit-queue should reject patches that fail to land
665         https://bugs.webkit.org/show_bug.cgi?id=46694
666
667         This can happen, for example, if there's no reviewer.  Without this
668         patch, we'll keep retrying the patch.
669
670         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
671         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
672
673 2010-09-27  Simon Fraser  <simon.fraser@apple.com>
674
675         Rubber-stamped by Adele Peterson.
676
677         Add a harness for running the CSS 2.1 test suite.
678         
679         This harness assumes that you've got a local a copy of the suite
680         adjacent to the 'harness' directory.
681         
682         The harness lets you go through the tests in chapter order,
683         denoting pass/fail/skipped for each test.
684         
685         It uses a client-side database to store the results of testing.
686
687         * CSSTestSuiteHarness/harness/harness.css: Added.
688         * CSSTestSuiteHarness/harness/harness.html: Added.
689         * CSSTestSuiteHarness/harness/harness.js: Added.
690
691 2010-09-27  Eric Seidel  <eric@webkit.org>
692
693         Reviewed by Adam Barth.
694
695         Patch locks should expire if a patch is marked for retry
696         https://bugs.webkit.org/show_bug.cgi?id=46682
697
698         This was part Adam's original CommitQueueTask design,
699         but support for it was missing from the server.
700         I added the support, but triggering lock-release based on this
701         special "retry" status feels a bit strange so I added a FIXME.
702
703         I also changed the text in queuestatus.html to say "Lock Acquired"
704         since "Last Activity" isn't really true.  We only update the lock
705         date when the patch is started, not on every status update.
706
707         I also noticed an exception in next-patch, which I fixed by re-writing
708         the unzip logic in activeworkitems.py again.
709
710         * QueueStatusServer/handlers/updatestatus.py:
711         * QueueStatusServer/model/activeworkitems.py:
712         * QueueStatusServer/templates/queuestatus.html:
713
714 2010-09-27  Tony Chang  <tony@chromium.org>
715
716         Reviewed by David Levin.
717
718         [chromium] fix a warning when compiling DRT on 32-bit linux
719         https://bugs.webkit.org/show_bug.cgi?id=46641
720
721         * DumpRenderTree/chromium/TestEventPrinter.cpp:
722         (DRTPrinter::handleImage):
723
724 2010-09-27  Eric Seidel  <eric@webkit.org>
725
726         Reviewed by Adam Barth.
727
728         queue-status should report when the patch was last locked to a queue
729         https://bugs.webkit.org/show_bug.cgi?id=46674
730
731         This isn't necessarily the best way to expose this information
732         but having this accessible via the web interface is very
733         useful until we come up with a nicer way to display this.
734
735         I also cleaned up the code in activeworkitems.py a little
736         to use list comprehensions and to have the code work with
737         pairs instead of two lists at once.  Eventually I think those
738         item/time pairs need to be their own little helper class.
739
740         * QueueStatusServer/handlers/queuestatus.py:
741         * QueueStatusServer/model/activeworkitems.py:
742         * QueueStatusServer/templates/queuestatus.html:
743
744 2010-09-27  Tony Chang  <tony@chromium.org>
745
746         Reviewed by David Levin.
747
748         [chromium] fix detection of missing fonts on DRT
749         https://bugs.webkit.org/show_bug.cgi?id=46651
750
751         * DumpRenderTree/chromium/TestShellGtk.cpp:
752         (setupFontconfig):  Only print an error message if lohit isn't found in both locations.
753
754 2010-09-27  Tony Chang  <tony@chromium.org>
755
756         Reviewed by Dimitri Glazkov.
757
758         add webkit unit tests to the chromium testers
759         https://bugs.webkit.org/show_bug.cgi?id=46669
760
761         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
762         * Scripts/run-chromium-webkit-unit-tests: Fix a bug where we weren't using the right configuration.
763
764 2010-09-27  Kwang Yul Seo  <skyul@company100.net>
765
766         Unreviewed.
767
768         Adding myself to the committers list.
769
770         * Scripts/webkitpy/common/config/committers.py:
771
772 2010-09-27  Mihai Parparita  <mihaip@chromium.org>
773
774         Reviewed by Eric Seidel.
775
776         webkitpy.common.system.user_unittest.UserTest.test_prompt_with_list spams the console
777         https://bugs.webkit.org/show_bug.cgi?id=46634
778         
779         Use OutputCapture to prevent console spam (and also check for expected
780         output).
781
782         * Scripts/webkitpy/common/system/user_unittest.py:
783
784 2010-09-27  Eric Seidel  <eric@webkit.org>
785
786         Reviewed by James Robinson.
787
788         start-commit-queue should abort any rebases in progress
789         https://bugs.webkit.org/show_bug.cgi?id=46640
790
791         webkit-patch commit-queue would do this itself, but this just
792         helps ensure that the commit-queue script is properly updated
793         before we run it (in the case where a previous rebase is in
794         progress the git svn rebase would not work before we run the
795         commit-queue).
796
797         * EWSTools/start-commit-queue.sh:
798
799 2010-09-18  Martin Robinson  <mrobinson@igalia.com>
800
801         Reviewed by Gustavo Noronha Silva.
802
803         [GTK] Clean up the DRT fonts.conf and switch to Liberation
804         https://bugs.webkit.org/show_bug.cgi?id=46038
805
806         Switch to Liberation fonts for GTK+ layout tests. This will make our
807         test results metric-compatible with many Windows/Chromium results. It
808         also simplifies the fonts.conf that we load and prepares the way for
809         fixing many font bugs.
810
811         * DumpRenderTree/gtk/DumpRenderTree.cpp:
812         (initializeFonts): Initialize a known list of fonts instead of loading
813         every font in the WEBKIT_TESTFONTS directory.
814         * DumpRenderTree/gtk/fonts.conf: Removed.
815         * DumpRenderTree/gtk/fonts/AHEM____.TTF: Copied from WebKitTools/DumpRenderTree/qt/fonts/AHEM____.TTF.
816         * DumpRenderTree/gtk/fonts/fonts.conf: Added.
817         * GNUmakefile.am: Modify FONTS_CONF_FILE to be FONTS_CONF_DIR, so that
818         we can load both fonts.conf and AHEM____.TTF from this location.
819         * Scripts/old-run-webkit-tests: Remove the check for WEBKIT_TESTFONTS, since
820         it is no longer used.
821
822 2010-09-26  Mihai Parparita  <mihaip@chromium.org>
823
824         Reviewed by Ojan Vafai.
825
826         new-run-webkit-httpd fails if Perl is not installed
827         https://bugs.webkit.org/show_bug.cgi?id=46602
828         
829         Make Port._read_configuration catch all exceptions, since trying to run
830         perl (because of _webkit_build_directory) when it's not installed throws
831         a WindowsError or OSError, not an IOError (this became an issue after 
832         r68268, since ChromiumPort ends up calling Port.default_configuration in
833         its constructor, which means that we're ending up on this codepath in
834         non-NRWT cases too, e.g. for the Chromium NaCl tests, which use
835         new-run-webkit-httpd).
836
837         * Scripts/webkitpy/layout_tests/port/base.py:
838         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
839
840 2010-09-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
841
842         Reviewed by Antonio Gomes.
843
844         [EFL] Add setting API to set a local storage database path.
845         https://bugs.webkit.org/show_bug.cgi?id=45446
846
847         Add a setting API to set local storage database path.
848
849         * EWebLauncher/main.c:
850         (on_key_down):
851         (browserCreate):
852         (main):
853
854 2010-09-26  Sam Weinig  <sam@webkit.org>
855
856         Reviewed by Anders Carlsson.
857
858         Move shared WebKit2 API (used by both bundle and main API) to WebKit2/Shared/API
859         https://bugs.webkit.org/show_bug.cgi?id=46587
860
861         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
862
863 2010-09-26  Antonio Gomes  <agomes@rim.com>
864
865         Reviewed by Kenneth Rohde Christiansen.
866
867         DRT/Mac nodesFromRect support
868
869         [Mac][DRT] Implement LayoutTestController::nodesFromRect
870         https://bugs.webkit.org/show_bug.cgi?id=46580
871
872         Implements LayoutTestController::nodesFromRect for Mac DRT, and
873         adding stubs for GTK+ and Windows.
874
875         * DumpRenderTree/LayoutTestController.cpp:
876         (nodesFromRectCallback):
877         (LayoutTestController::staticFunctions):
878         * DumpRenderTree/LayoutTestController.h:
879         (LayoutTestController::LayoutTestController::nodesFromRect):
880         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
881         (LayoutTestController::nodesFromRect):
882
883 2010-09-25  Nicolas Weber  <thakis@chromium.org>
884
885         Reviewed by Adam Barth.
886
887         https://bugs.webkit.org/show_bug.cgi?id=46555
888         Fix typo in prepare-ChangeLog's help output.
889
890         * Scripts/prepare-ChangeLog:
891
892 2010-09-24  Sam Weinig  <sam@webkit.org>
893
894         Reviewed by Darin Adler.
895
896         Implement WebKit2 callback equivalent to -[WebUIDelegate mouseDidMoveOverElement:modifierFlags:]
897         <rdar://problem/8359279>
898         https://bugs.webkit.org/show_bug.cgi?id=46546
899
900         * MiniBrowser/mac/BrowserWindowController.m:
901         (mouseDidMoveOverElement):
902         (-[BrowserWindowController awakeFromNib]):
903         * MiniBrowser/win/BrowserView.cpp:
904         (mouseDidMoveOverElement):
905         (BrowserView::create):
906         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
907         (WTR::InjectedBundlePage::InjectedBundlePage):
908         * WebKitTestRunner/TestController.cpp:
909         (WTR::createOtherPage):
910         (WTR::TestController::initialize):
911
912 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
913
914         Reviewed by Adam Barth.
915
916         Allow rebaselines for webkit-patch rebaseline to be chosen
917         https://bugs.webkit.org/show_bug.cgi?id=46407
918         
919         Instead of always rebaselining all failing tests, allow a subset to be
920         chosen.
921
922         * Scripts/webkitpy/common/system/user.py:
923         * Scripts/webkitpy/tool/commands/rebaseline.py:
924
925 2010-09-24  Ryosuke Niwa  <rniwa@webkit.org>
926
927         Reviewed by Tony Chang.
928
929         [chromium] Implement TextInputController::firstRectForCharacterRange
930         https://bugs.webkit.org/show_bug.cgi?id=38100
931
932         Implemented TextInputController::firstRectForCharacterRange for chromium platform.
933         No new tests are added since we need to implement the same feature in chromium side
934         in order to enable any tests that uses this function.
935
936         * DumpRenderTree/chromium/TextInputController.cpp:
937         (TextInputController::firstRectForCharacterRange): Added.
938
939 2010-09-24  Adam Barth  <abarth@webkit.org>
940
941         Reviewed by Eric Seidel.
942
943         commit-queue reports land failures as "PASS"
944         https://bugs.webkit.org/show_bug.cgi?id=46530
945
946         We were ignoring the return value of land instead of passing it back to
947         CommitQueue.  Of course, this was the one case I forgot to test!
948
949         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
950         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
951
952 2010-09-24  Kenichi Ishibashi  <bashi@google.com>
953
954         Reviewed by Eric Seidel.
955
956         new-run-webkit-tests prints out nothing when build-dumprendertree fails
957         https://bugs.webkit.org/show_bug.cgi?id=37563
958
959         Print error message when build-dumprendertree fails.
960
961         * Scripts/webkitpy/layout_tests/port/webkit.py:
962         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
963
964 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
965
966         Reviewed by Tony Chang.
967
968         NRWT doesn't respect config set with set-webkit-configuration
969         https://bugs.webkit.org/show_bug.cgi?id=46278
970         
971         Use Port.default_configuration() instead of hardcoding Release in
972         ChromiumPort configuration initialization, so that we still inherit the
973         configuration set by set-webkit-configuration.
974
975         * Scripts/webkitpy/layout_tests/port/chromium.py:
976         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
977
978 2010-09-24  Chang Shu  <chang.shu@nokia.com>
979
980         Reviewed by Csaba Osztrogonác.
981
982         [Qt] Fix the code to check file existence.
983         https://bugs.webkit.org/show_bug.cgi?id=46465
984
985         * QtTestBrowser/main.cpp:
986         (main):
987
988 2010-09-23  Tony Chang  <tony@chromium.org>
989
990         Unreviewed, rolling out r68232.
991         http://trac.webkit.org/changeset/68232
992
993         Broken NRWT on the canary bots.
994
995         * Scripts/webkitpy/layout_tests/port/chromium.py:
996
997 2010-09-23  Dirk Pranke  <dpranke@chromium.org>
998
999         Unreviewed, build fix.
1000
1001         r68008 broke new-run-webkit-tests in that the chromium ports no
1002         longer respect set-webkit-configuration. The correct fix for this
1003         is being pursued in bug 46278 (along with a bunch of unit tests),
1004         but in the meantime I'm reverting the particular lines that broke
1005         things. This was tested by hand.
1006
1007         * Scripts/webkitpy/layout_tests/port/chromium.py:
1008
1009 2010-09-23  Sam Weinig  <sam@webkit.org>
1010
1011         Reviewed by Anders Carlsson.
1012
1013         WebKit2 API: Need way to know when a frame is removed from the hierarchy
1014         <rdar://problem/8414062>
1015         https://bugs.webkit.org/show_bug.cgi?id=46432
1016
1017         * MiniBrowser/mac/BrowserWindowController.m:
1018         (didRemoveFrameFromHierarchy):
1019         (-[BrowserWindowController awakeFromNib]):
1020         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1021         (WTR::InjectedBundlePage::InjectedBundlePage):
1022         * WebKitTestRunner/TestController.cpp:
1023         (WTR::TestController::initialize):
1024
1025 2010-09-23  Tony Chang  <tony@chromium.org>
1026
1027         Reviewed by Dimitri Glazkov.
1028
1029         [chromium] implement layoutTestController.sampleSVGAnimationForElementAtTime
1030         https://bugs.webkit.org/show_bug.cgi?id=46426
1031
1032         * DumpRenderTree/chromium/LayoutTestController.cpp:
1033         (LayoutTestController::LayoutTestController):
1034         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1035         * DumpRenderTree/chromium/LayoutTestController.h:
1036
1037 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
1038
1039         Reviewed by Nate Chapin.
1040
1041         [GTK] r68199 introduced two test failures
1042         https://bugs.webkit.org/show_bug.cgi?id=46424
1043
1044         Fix a regression handling preference overrides that are attached to boolean properties.
1045
1046         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1047         (LayoutTestController::overridePreference): g_strcasecmp returns 0 when strings match
1048         so we must check for that when converting a string to a boolean.
1049
1050 2010-09-23  Dimitri Glazkov  <dglazkov@chromium.org>
1051
1052         Reviewed by David Levin.
1053
1054         Fix a condition check in ServerProcess, which becomes relevant when reading binary data.
1055         https://bugs.webkit.org/show_bug.cgi?id=46406
1056
1057         This breaks when the method is called with specified size of data (image data), and the
1058         buffer hasn't yet reached this size.
1059
1060         * Scripts/webkitpy/layout_tests/port/server_process.py: Changed to check for values of
1061           index larger than 0.
1062
1063 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
1064
1065         Reviewed by Nate Chapin.
1066
1067         [GTK] Some tests from r68174 fail on the GTK+ bots
1068         https://bugs.webkit.org/show_bug.cgi?id=46396
1069
1070         Simplify LayoutTestController::overridePreference to make it easier for
1071         people unfamiliar with the code to keep the list of preferences up to date.
1072         Add the conversion for enable-hyperlink-auditing.
1073
1074         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1075         (LayoutTestController::overridePreference): Use a simple if-else block to determine
1076         out the property name for overrridePreference. Also simplify the logic for setting
1077         string properties. Add the conversion for enable-hyperlink-auditing.
1078
1079 2010-09-23  Tony Chang  <tony@chromium.org>
1080
1081         Reviewed by David Levin.
1082
1083         [chromium] add caretBrowsingEnabled to WebSettings and DRT
1084         https://bugs.webkit.org/show_bug.cgi?id=46388
1085
1086         * DumpRenderTree/chromium/LayoutTestController.cpp:
1087         (LayoutTestController::overridePreference):
1088         * DumpRenderTree/chromium/WebPreferences.cpp:
1089         (WebPreferences::reset):
1090         (WebPreferences::applyTo):
1091         * DumpRenderTree/chromium/WebPreferences.h:
1092
1093 2010-09-23  Nate Chapin  <japhet@chromium.org>
1094
1095         Reviewed by Darin Fisher.
1096
1097         Allow DRT to toggle hyperlink auditing (i.e., <a ping>).
1098         https://bugs.webkit.org/show_bug.cgi?id=30458
1099
1100         * DumpRenderTree/chromium/LayoutTestController.cpp:
1101         (LayoutTestController::overridePreference):
1102         * DumpRenderTree/chromium/WebPreferences.cpp:
1103         (WebPreferences::reset):
1104         (WebPreferences::applyTo):
1105         * DumpRenderTree/chromium/WebPreferences.h:
1106         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1107         (resetDefaultsToConsistentValues):
1108         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1109         (LayoutTestController::overridePreference):
1110
1111 2010-09-21  Stephen White  <senorblanco@chromium.org>
1112
1113         Reviewed by David Levin.
1114
1115         Implement --enable-accelerated-2d-canvas flag in DumpRenderTree.
1116         https://bugs.webkit.org/show_bug.cgi?id=46208
1117
1118         This flag allows the layout tests to be run with or without accelerated
1119         2D canvas rendering.
1120
1121         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1122         (main):
1123         Declare the new flag string, and check for it on startup.
1124         * DumpRenderTree/chromium/TestShell.cpp:
1125         (TestShell::TestShell):
1126         Add a boolean for the new flag, in order to preserve its value over
1127         preferences reset.
1128         (TestShell::resetWebSettings):
1129         Set the new flag to the stored value on reset.
1130         * DumpRenderTree/chromium/TestShell.h:
1131         (TestShell::setAccelerated2dCanvasEnabled):
1132         Add an accessor for the new flag.
1133         * DumpRenderTree/chromium/WebPreferences.cpp:
1134         (WebPreferences::reset):
1135         Initialize the new flag to false.
1136         (WebPreferences::applyTo):
1137         Copy the flag's value to the WebSettings.
1138         * DumpRenderTree/chromium/WebPreferences.h:
1139         Add the new flag.
1140
1141 2010-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1142
1143         Reviewed by Simon Hausmann.
1144
1145         [Qt] Refactor QtWebKitPlatformPlugin interface
1146
1147         Make it easier to keep source-compability for the
1148         QtWebKitPlatformPlugin interface, and run qmake
1149         on the example (but not build) for convenience. 
1150
1151         https://bugs.webkit.org/show_bug.cgi?id=46345
1152
1153         * Scripts/webkitdirs.pm:
1154
1155 2010-09-23  Adam Barth  <abarth@webkit.org>
1156
1157         Reviewed by Eric Seidel.
1158
1159         Tweak some status messages that Eric thought were confusing
1160         https://bugs.webkit.org/show_bug.cgi?id=46342
1161
1162         * Scripts/webkitpy/tool/commands/queues.py:
1163         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1164
1165 2010-09-22  Adam Barth  <abarth@webkit.org>
1166
1167         Reviewed by Eric Seidel.
1168
1169         Fix comm-queue typo
1170         https://bugs.webkit.org/show_bug.cgi?id=46339
1171
1172         We were missing a "self".  The real problem is that we didn't have an
1173         integration test for the failure case.
1174
1175         * Scripts/webkitpy/tool/commands/queues.py:
1176         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1177
1178 2010-09-22  Adam Barth  <abarth@webkit.org>
1179
1180         Reviewed by Eric Seidel.
1181
1182         commit-queue should log more detailed messages to the QueueStatusServer
1183         https://bugs.webkit.org/show_bug.cgi?id=46333
1184
1185         When I created CommitQueueTask, I removed most of the previous logging.
1186         This patch adds back more detailed logging so folks can see their patch
1187         progress through the queue.
1188
1189         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1190         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1191         * Scripts/webkitpy/tool/commands/queues.py:
1192         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1193
1194 2010-09-22  Mihai Parparita  <mihaip@chromium.org>
1195
1196         Reviewed by Darin Fisher.
1197
1198         [Chromium] User style layout tests don't pass on Chromium
1199         https://bugs.webkit.org/show_bug.cgi?id=46069
1200
1201         Fix a typo in LayoutTestController::addUserStyleSheet that was causing a
1202         crash the Chromium DRT. Pass InjectInExistingDocuments to mimic DRT
1203         behavior from other ports.
1204
1205         * DumpRenderTree/chromium/LayoutTestController.cpp:
1206         (LayoutTestController::addUserStyleSheet):
1207
1208 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
1209
1210         Reviewed by Martin Robinson.
1211
1212         [WinCairo] Part 2: Update WebKitTestRunner and DumpRenderTree Build.
1213         https://bugs.webkit.org/show_bug.cgi?id=46303.
1214
1215         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added.
1216         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Moved
1217         CoreFoundation-specific stuff to new MiniBrowserCoreFoundation
1218         property sheet.
1219         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added.
1220         * MiniBrowser/MiniBrowser.vcproj: Updated configuration to use
1221         appropriate property sheet for the build types.
1222         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Updated the
1223         configuration to use appropriate property sheet for CoreFoundation
1224         and CFLite-style builds.
1225
1226 2010-09-22  Adam Barth  <abarth@webkit.org>
1227
1228         Reviewed by Eric Seidel.
1229
1230         Optimize commit-queue performance for green trees
1231         https://bugs.webkit.org/show_bug.cgi?id=46254
1232
1233         This patch redesigns the controller logic for the commit-queue.  In the
1234         new design, the controller exercises much finer-grained control over
1235         the landing process.  In particular:
1236
1237         - Patches that fail to apply now get rejected almost immediately.
1238         - Patches that fail to build get rejects after two builds (instead of
1239           three builds and one test run).
1240         - Patches that run into a flaky test now get accepted after one build
1241           and two test runs instead of three full build-and-test runs.
1242
1243         The main cost of these optimizations is that we don't find out the tree
1244         has a failing test until the very end of the process, but if the tree
1245         has a busted test, there's not much we can do anyway.  We might as well
1246         burn commit-queue resources spinning optimisticly.
1247
1248         * Scripts/webkitpy/tool/bot/commitqueuetask.py: Added.
1249         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Added.
1250         * Scripts/webkitpy/tool/commands/queues.py:
1251
1252 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
1253
1254         Reviewed by Martin Robinson.
1255
1256         [WinCairo] Update WebKitTestRunner and DumpRenderTree Build.
1257         https://bugs.webkit.org/show_bug.cgi?id=46303.
1258
1259         * DumpRenderTree/win/DumpRenderTree.vcproj: Disable local MD5 sources
1260         for Cairo build. Copy wtf MD5 header to ForwardingHeaders for the
1261         WinCairo build.
1262         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added.
1263         * WebKitTestRunner/win/InjectedBundle.vcproj: Update win new *_Cairo
1264         build targets that use the new InjectedBundleCFLite.vsprops file.
1265
1266 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
1267
1268         Unreviewed, build fix.
1269
1270         Fix bustage of rebaseline-chromium-webkit-tests resulting from
1271         r67974. Really need better unit tests for this tool :(
1272
1273         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1274
1275 2010-09-22  Adam Roben  <aroben@apple.com>
1276
1277         Unbreak test-webkitpy
1278
1279         * Scripts/webkitpy/test/main.py:
1280         (Tester.run_tests): Add a line that mysteriously got deleted.
1281
1282 2010-09-22  Adam Roben  <aroben@apple.com>
1283
1284         Make test-webkitpy test WebKit2's scripts
1285
1286         These scripts can't be in WebKitTools due to limitations of Apple's
1287         build process. But that doesn't mean we can't test them!
1288
1289         Fixes <http://webkit.org/b/46297> test-webkitpy should test code in
1290         WebKit2/Scripts
1291
1292         Reviewed by Adam Barth.
1293
1294         * Scripts/test-webkitpy:
1295         (_clean_packages_with_test): Renamed from _clean_webkitpy_with_test.
1296         Now takes an external_package_paths parameter and cleans both webkitpy
1297         and any external packages.
1298         (init): Added an external_package_paths parameter which we pass along
1299         to _clean_packages_with_test.
1300         (top level): Add WebKit2/Scripts/webkit2 as our only external package
1301         and pass it along to init and Tester.run_tests.
1302
1303         * Scripts/webkitpy/test/main.py:
1304         (Tester.run_tests): Added an optional external_package_paths
1305         parameter. We modify sys.path so that the external packages can be
1306         imported, and search for unittest files inside all external packages
1307         in addition to inside webkitpy.
1308
1309 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
1310
1311         Reviewed by Tony Chang.
1312
1313         new-run-webkit-tests: r68063 broke linux python tests
1314
1315         Add a missing "from __future__ import with_statement" to this
1316         new file; the perils of testing only on the Mac and by review :(
1317
1318         https://bugs.webkit.org/show_bug.cgi?id=46293
1319
1320         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1321
1322 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
1323
1324         Reviewed by Tony Chang.
1325
1326         Add a 'chromium-gpu' set of ports that will test the accelerated
1327         GPU paths. This patch adds:
1328
1329         - support for the '--accelerated-compositing' and
1330           'accelerated-2d-canvas' flags to new-run-webkit-tests (and the
1331           'no-' flags)
1332         - adds a new set of Ports that will look under
1333           platform/chromium-gpu-$OS/ for baselines before looking in the
1334           regular chromium search path
1335         - adds a new test_expectations.txt file in platform/chromium-gpu
1336           that skips all but the tests we actually want to run with
1337           acceleration.
1338
1339         This patch will allow us to run both with and without acceleration
1340         and to change the defaults for both the regular and -gpu options
1341         as the code evolves.
1342
1343         We plan to add both --chromium-$OS and --chromium-gpu-$OS runs to
1344         each test bot.
1345
1346         https://bugs.webkit.org/show_bug.cgi?id=46225
1347
1348         * Scripts/webkitpy/layout_tests/port/chromium.py:
1349         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1350         * Scripts/webkitpy/layout_tests/port/factory.py:
1351         * Scripts/webkitpy/layout_tests/port/webkit.py:
1352
1353 2010-09-22  Jamey Hicks  <jamey.hicks@nokia.com>
1354
1355         Reviewed by Kenneth Rohde Christiansen.
1356
1357         [Qt] Web Inspector: Remote Web Inspector support for QtWebKit
1358         https://bugs.webkit.org/show_bug.cgi?id=43988
1359
1360         Runs a web debug server on port specified by QtTestBrowser
1361         argument -remote-inspector-port. Property
1362         _q_webInspectorServerPort of the QWebPage instance will be set
1363         according to the argument. All pages with that property set will
1364         be remotely inspectable.
1365
1366         URL for remote inspection of first QWebPage is
1367             http://localhost:9222/webkit/inspector/inspector.html?page=1
1368         where 1 is the number of the QWebPage instance.
1369
1370         The base URL yields an index page with links to the individual inspectors:
1371             http://localhost:9222/
1372
1373         * QtTestBrowser/launcherwindow.cpp:
1374         (LauncherWindow::init):
1375         * QtTestBrowser/launcherwindow.h:
1376         * QtTestBrowser/main.cpp:
1377         (LauncherApplication::handleUserOptions):
1378
1379 2010-09-22  Adam Roben  <aroben@apple.com>
1380
1381         Fix webkit-patch failure-reason now that build.webkit.org has been
1382         updated
1383
1384         Fixes <http://webkit.org/b/46273> webkit-patch failure-reason crashes
1385         every time
1386
1387         Reviewed by Eric Seidel.
1388
1389         * Scripts/webkitpy/common/net/buildbot.py:
1390         (BuildBot._file_cell_text): Added. Travels down the firstChild chain
1391         looking for an element that contains text, then returns it.
1392         (BuildBot._parse_twisted_file_row): Use _file_cell_text to get the
1393         text out of the cells. This way it doesn't matter whether the cells
1394         have <b> children (as for cells in directory rows) or not (as for
1395         cells in file rows)
1396         (BuildBot._parse_twisted_directory_listing): Look for rows that have
1397         the "directory" or "file" class, rather than rows with any class,
1398         since header rows now have a class attribute.
1399
1400         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1401         (BuildBotTest._example_directory_listing): Updated to more closely
1402         match the markup that build.webkit.org is producing now.
1403
1404 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
1405
1406         Unreviewed, build fix.
1407
1408         new-run-webkit-tests: fix bug introduced in r68008 where if you
1409         specify --chromium and no --platform, and you're running on
1410         windows, you use the 'chromium-win' port by default instead of the
1411         version-specific port. This breaks the buildbots.
1412
1413         It will be good for this refactoring to settle down so I can
1414         rewrite the logic for default ports and the unit tests to be
1415         clearer (and the testing more comprehensive).
1416
1417         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1418
1419 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
1420
1421         Reviewed by Adam Barth.
1422
1423         Modify the Port interface to take only a series of keyword arguments
1424         in the constructor, and modify Port/factory.get() to accomodate that,
1425         and to accept user=XXX as an argument so we can pass
1426         webkitpy.common.system.user.User objects in.
1427
1428         Then, modify new-run-webkit-tests and rebaseline-chromium-webkit-tests
1429         to use the common routine in webkitpy.common.system.user.open_url()
1430         to display HTML files.
1431
1432         There was a routine in the Port interface to do the same thing,
1433         but I see no need for a port-specific hook for this, since it is
1434         something that will always be executed by the host environment
1435         and displaying web pages has nothing to do with running layout tests.
1436
1437         Note that new-run-webkit-tests used to use test_shell to display
1438         the page; this is potentially useful so that you can actually click
1439         from a result to the broken page; however, since DumpRenderTree
1440         doesn't support this functionality, it will be going away eventually.
1441
1442         https://bugs.webkit.org/show_bug.cgi?id=46128
1443
1444         * Scripts/webkitpy/layout_tests/port/base.py:
1445         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1446         * Scripts/webkitpy/layout_tests/port/chromium.py:
1447         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1448         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1449         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1450         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1451         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1452         * Scripts/webkitpy/layout_tests/port/factory.py:
1453         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1454         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1455         * Scripts/webkitpy/layout_tests/port/gtk.py:
1456         * Scripts/webkitpy/layout_tests/port/mac.py:
1457         * Scripts/webkitpy/layout_tests/port/qt.py:
1458         * Scripts/webkitpy/layout_tests/port/test.py:
1459         * Scripts/webkitpy/layout_tests/port/webkit.py:
1460         * Scripts/webkitpy/layout_tests/port/win.py:
1461         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1462         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1463         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1464
1465 2010-09-21  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
1466
1467         Reviewed by Kenneth Rohde Christiansen.
1468
1469         [EFL] Get fresh theme when running EWebLauncher
1470         https://bugs.webkit.org/show_bug.cgi?id=46210
1471
1472         If user tried to run EWebLauncher outside of the build tree, it would
1473         not find the theme and fallback to the installed one. However, since
1474         EWebLauncher is not installed, we always want to take the theme from
1475         the just compiled source code. If user had never installed WebKit's
1476         EFL port it could even receive a segv since no theme would be found.
1477
1478         Now EWebLauncher does not fallback to the installed theme and CMake
1479         gives as DATA_DIR the directory of the theme it has just built.
1480
1481         * CMakeListsEfl.txt: Pass the build directory as DATA_DIR to
1482         EWebLauncher.
1483         * EWebLauncher/main.c: Use only the theme from build director. Do not
1484         fallback to others as this could hide real bugs.
1485         (quit):
1486         (browserCreate):
1487         (findThemePath):
1488         (main):
1489
1490 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
1491
1492         Unreviewed, build fix.
1493
1494         Don't pass the --test-shell arg to the Chromium Mac port of DRT;
1495         it just confuses it.
1496
1497         https://bugs.webkit.org/show_bug.cgi?id=46230
1498
1499         * Scripts/webkitpy/layout_tests/port/webkit.py:
1500
1501 2010-09-21  Lucas Forschler  <lforschler@apple.com>
1502
1503         Reviewed by Stephanie Lewis.
1504
1505         Make a new buildbot for Leopard Debug Test
1506
1507         * BuildSlaveSupport/build.webkit.org-config/config.json:
1508
1509 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
1510
1511         Unreviewed, build fix.
1512
1513         Fix breakage of Chromium Mac DRT port caused by r67905.
1514
1515         https://bugs.webkit.org/show_bug.cgi?id=46230
1516
1517         * Scripts/webkitpy/layout_tests/port/webkit.py:
1518
1519 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
1520
1521         Unreviewed, build fix.
1522
1523         Add missing import of 'tempfile'.
1524
1525         * Scripts/webkitpy/layout_tests/port/chromium.py:
1526
1527 2010-09-17  Dirk Pranke  <dpranke@chromium.org>
1528
1529         Reviewed by Ojan Vafai.
1530
1531         new-run-webkit-tests: pull the list of tests from the Port, and
1532            make it possible to run with no actual test files in the filesystem.
1533
1534         This set of changes allows us to delete the special
1535         webkitpy/layout_tests/data directory and test the generic code without
1536         touching the filesystem (except to write results). This speeds up
1537         test-webkitpy substantially.
1538
1539         This also cleans up and removes several code paths in the generic
1540         code and fixes some minor bugs, notably in the test_expectations
1541         parsing, which was previously fragile if the tests weren't present.
1542
1543         We also change the way we diff image results to be able to do so
1544         in memory, without relying on files. This slows down chromium
1545         test_shell, which always writes images to files, but should speed
1546         up DRT and ImageDiff-based implementations slightly.
1547
1548         Note that pulling the list of tests to run from the Port will allow
1549         ports to specify what tests to run as an inclusive list; previously
1550         you could only do this as an exclusive list by using a 
1551         test_expectations file or Skipped files; nothing actually uses this
1552         feature yet and it's unclear if it should be used.
1553
1554         Note that there are no functional changes -- apart from now 
1555         always printing out the location of the checksum file when we are
1556         tracing test runs -- and the total number of lines of non-test code
1557         actually drops by two.
1558
1559         There is some more cleanup that can be done in the Port/Driver 
1560         interface and in some handling of filenames, but I'll save that
1561         for another change.
1562
1563         https://bugs.webkit.org/show_bug.cgi?id=45801
1564
1565         * Scripts/webkitpy/layout_tests/data/*: Removed.
1566             - no longer need special mock layout_tests_directory in the
1567               repository.
1568         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1569             - add code to display missing text files, checksums when tracing
1570             - update to not look at the filesystem directly.
1571         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1572             - add more unit tests
1573         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1574             - remove tests_are_present flag
1575             - update with changes in Port interface - no longer access
1576               the filesystem directly, although we still use os.path for
1577               filename manipulation.
1578         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1579             - add more unit tests
1580         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Removed.
1581             - renamed to port/test_files.py
1582         * Scripts/webkitpy/layout_tests/port/base.py:
1583             - change diff_image() to expect actual image data, not filenames
1584             - add expected_checksum(), expected_image(), expected_text() to
1585               return the content of the files so that we don't need a filesystem
1586             - add path_exists(), path_isdir() for filesystem-like access.
1587             - add test_dirs() to keep clobber-test-results from needing to
1588               actually look at a real layout tests dir
1589             - add tests() to return the list of tests to run on the port
1590               (calls port/test_files to do the work).
1591             - add update_baseline() to be able to save new baselines
1592             - add uri_to_test_name() from port/dryrun.py so we can easily check
1593               filename_to_uri()
1594         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1595             - add more unit tests
1596         * Scripts/webkitpy/layout_tests/port/chromium.py:
1597             - change diff_image() to accept image content, not filenames.
1598               This will be slower for test_shell/image_diff, but faster
1599               for DRT/ImageDiff.
1600         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1601             - add more unit tests
1602         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1603             - simplify greatly
1604         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1605             - add more unit tests
1606         * Scripts/webkitpy/layout_tests/port/test.py:
1607             - massive rewrite to use in-script list of tests and expectations
1608         * Scripts/webkitpy/layout_tests/port/test_files.py:
1609             - rename from layout_package/test_files.
1610         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1611             - add unit tests
1612         * Scripts/webkitpy/layout_tests/port/webkit.py:
1613             - update diff_image() to take image contents, not files. Should
1614               make things slightly faster.
1615         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1616             - update with changes to diff_image()
1617         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1618             - update with changes to diff_image()
1619         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1620             - remove tests_are_present from test_expectations
1621             - pull the list of tests from port.tests() instead
1622               of calling test_files.py directly.
1623         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1624             - update unit tests
1625         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1626             - update with changes to 
1627         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1628             - update with change in Port interface
1629         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1630             - update with change in Port interface
1631         * Scripts/webkitpy/style/checkers/test_expectations.py:
1632             - remove the tests_are_present flag
1633
1634 2010-09-21  Anders Carlsson  <andersca@apple.com>
1635
1636         Disable logging.
1637
1638         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1639
1640 2010-09-21  Tony Chang  <tony@chromium.org>
1641
1642         Reviewed by Kent Tamura.
1643
1644         add a script for running webkit_unit_tests
1645         https://bugs.webkit.org/show_bug.cgi?id=46014
1646
1647         * Scripts/run-chromium-webkit-unit-tests: Added.
1648
1649 2010-09-21  Fridrich Strba  <fridrich.strba@bluewin.ch>
1650
1651         Reviewed by Martin Robinson.
1652
1653         Fix linking problems on Windows.
1654         https://bugs.webkit.org/show_bug.cgi?id=45844
1655
1656         * GNUmakefile.am: link the executables with winmm.dll
1657
1658 2010-09-21  Adam Barth  <abarth@webkit.org>
1659
1660         Reviewed by Eric Seidel.
1661
1662         feeder-queue svn updates more often than needed
1663         https://bugs.webkit.org/show_bug.cgi?id=46171
1664
1665         We don't need to poll SVN every time we feed the feeders.  Rather, we
1666         can count on the wrapper shell script to auto-update the queue.
1667
1668         * Scripts/webkitpy/tool/commands/queues.py:
1669         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1670
1671 2010-09-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1672
1673         Reviewed by Andreas Kling.
1674
1675         [Qt] Add robot loader timeout and extra time options.
1676         https://bugs.webkit.org/show_bug.cgi?id=46172
1677
1678         [-robot-timeout <s>]: Load the next page after s seconds if the current
1679         page didn't finish loading.
1680         [-robot-extra-time <s>]: Wait s seconds after the current page finished
1681         loading before loading the next one. This should allow some time for the
1682         page's JavaScript to execute.
1683
1684         * QtTestBrowser/launcherwindow.cpp:
1685         (LauncherWindow::applyPrefs):
1686         * QtTestBrowser/main.cpp:
1687         (LauncherApplication::robotTimeout):
1688         (LauncherApplication::robotExtraTime):
1689         (LauncherApplication::LauncherApplication):
1690         (LauncherApplication::handleUserOptions):
1691         (main):
1692         * QtTestBrowser/urlloader.cpp:
1693         (UrlLoader::UrlLoader):
1694         (UrlLoader::loadNext):
1695         (UrlLoader::loadUrlList):
1696         * QtTestBrowser/urlloader.h:
1697
1698 2010-09-21  Pavel Podivilov  <podivilov@chromium.org>
1699
1700         Unreviewed.
1701
1702         Adding myself to the committers list.
1703
1704         * Scripts/webkitpy/common/config/committers.py:
1705
1706 2010-09-20  Philippe Normand  <pnormand@igalia.com>
1707
1708         Reviewed by Eric Carlson.
1709
1710         [GTK] enhanced context menu for media elements
1711         https://bugs.webkit.org/show_bug.cgi?id=45021
1712
1713         EventSender::contextClick() now returns an array of js
1714         objects. Each object has a title property and a click() method.
1715
1716         * DumpRenderTree/gtk/EventSender.cpp:
1717         (getMenuItemTitleCallback):
1718         (setMenuItemTitleCallback):
1719         (menuItemClickCallback):
1720         (getMenuItemClass):
1721         (contextClickCallback):
1722
1723 2010-09-20  Hayato Ito  <hayato@chromium.org>
1724
1725         Unreviewed.
1726         Adding myself to the committers list.
1727
1728         * Scripts/webkitpy/common/config/committers.py:
1729
1730 2010-09-20  Adam Barth  <abarth@webkit.org>
1731
1732         Reviewed by Eric Seidel.
1733
1734         The tool member variable should be called _tool
1735         https://bugs.webkit.org/show_bug.cgi?id=46160
1736
1737         Created by find-and-replace.
1738
1739         * Scripts/webkitpy/tool/commands/download.py:
1740         * Scripts/webkitpy/tool/commands/openbugs.py:
1741         * Scripts/webkitpy/tool/commands/queries.py:
1742         * Scripts/webkitpy/tool/commands/queues.py:
1743         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1744         * Scripts/webkitpy/tool/commands/rebaseline.py:
1745         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1746         * Scripts/webkitpy/tool/commands/upload.py:
1747         * Scripts/webkitpy/tool/multicommandtool.py:
1748
1749 2010-09-20  Adam Barth  <abarth@webkit.org>
1750
1751         I ran the tests before landing but ignored the fact that they failed.  :(
1752
1753         * Scripts/webkitpy/tool/commands/queues.py:
1754
1755 2010-09-20  Adam Barth  <abarth@webkit.org>
1756
1757         Reviewed by Eric Seidel.
1758
1759         Add a feeder queue that polls bugs.webkit.org for the commit-cluster
1760         https://bugs.webkit.org/show_bug.cgi?id=46141
1761
1762         The feeder-queue polls bugs.webkit.org every 30 seconds and updates the
1763         list of work items on the status server.  The individual commit-cluster
1764         nodes then grab the patches from the server and process them.
1765
1766         * Scripts/webkitpy/tool/bot/feeders.py: Added.
1767         * Scripts/webkitpy/tool/bot/feeders_unittest.py: Added.
1768         * Scripts/webkitpy/tool/commands/queues.py:
1769         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1770         * Scripts/webkitpy/tool/commands/queuestest.py:
1771
1772 2010-09-20  Leandro Pereira  <leandro@profusion.mobi>
1773
1774         Reviewed by Darin Adler.
1775
1776         build-webkit: Add support for CMake build system
1777         https://bugs.webkit.org/show_bug.cgi?id=44979
1778
1779         * Scripts/build-webkit: Add "--efl" command-line option to build the
1780         EFL port of WebKit.
1781         * Scripts/webkitdirs.pm: Define buildCMakeProject() and
1782         buildEflCMakeProject() subroutines.
1783
1784 2010-09-20  Dirk Pranke  <dpranke@chromium.org>
1785
1786         Reviewed by Ojan Vafai.
1787
1788         new-run-webkit-tests: refactor command line args getting passed to DRT
1789
1790         This change cleans up some argument parsing between functions to get
1791         rid of some overlapping data structures. There should be no functional
1792         changes in this patch; it is pure refactoring in preparation for
1793         landing the Chrome GPU port and adding a generic way to pass
1794         args to DRT/TestShell.
1795
1796         https://bugs.webkit.org/show_bug.cgi?id=46135
1797
1798         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1799           - pass the options argument explicitly to the threads and drivers,
1800             also consolidate the passing of options to the driver.
1801           - pass options directly to process_output() to remove a couple
1802             parameters (minor cleanup).
1803         * Scripts/webkitpy/layout_tests/port/base.py:
1804           - pass the options argument to Port.create_driver().
1805         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1806           - update Port.create_driver() test
1807         * Scripts/webkitpy/layout_tests/port/chromium.py:
1808           - pass the options argument to Port.create_driver(), and clean up
1809             building of the cmd line for DRT.
1810         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1811           - pass the options argument to Port.create_driver()
1812         * Scripts/webkitpy/layout_tests/port/test.py:
1813           - pass the options argument to Port.create_driver()
1814         * Scripts/webkitpy/layout_tests/port/webkit.py:
1815           - pass the options argument to Port.create_driver(), and clean up
1816             building of the cmd line for DRT.
1817         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1818           - consolidate args in _get_dump_render_tree_args and rename to
1819             _get_test_args(); move all of the command-line args to the
1820             Port implementations.
1821
1822 2010-09-20  Andrew Wilson  <atwilson@chromium.org>
1823
1824         Revert change which was accidentally committed along with some expectation changes.
1825
1826         * Scripts/webkitpy/layout_tests/port/base.py:
1827
1828 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
1829
1830         Reviewed by Adam Barth.
1831
1832         Add explicit --force-patch flag to webkitpy tools
1833         https://bugs.webkit.org/show_bug.cgi?id=46103
1834         
1835         It wasn't obvious until I read the applypatch.py source code that
1836         --non-interfactive implies passing --force to patch. Add --force-patch
1837         as an alias to the flag, so that this behavior is more discoverable.
1838
1839         * Scripts/webkitpy/tool/steps/applypatch.py:
1840         * Scripts/webkitpy/tool/steps/options.py:
1841
1842 2010-09-20  Eric Seidel  <eric@webkit.org>
1843
1844         Unreviewed, adding a line which got dropped and is trivially correct (and tested).
1845
1846         commit-queue can't land patches
1847         https://bugs.webkit.org/show_bug.cgi?id=46138
1848
1849         Add a line of code I forgot in my last commit.
1850
1851         * Scripts/webkitpy/common/net/bugzilla.py:
1852         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1853
1854 2010-09-20  Adam Barth  <abarth@webkit.org>
1855
1856         Reviewed by Eric Seidel.
1857
1858         The commit-cluster bots still race to lock patch_ids
1859         https://bugs.webkit.org/show_bug.cgi?id=46130
1860
1861         It turns out we need to use a transaction object to make the
1862         read/modify/write lock operation atomic.  From reading the AppEngine
1863         documentation, I think this patch should do what we want.  It's hard to
1864         test locally because the test instance isn't distributed in the same
1865         way the production instance is.
1866
1867         * QueueStatusServer/handlers/nextpatch.py:
1868         * QueueStatusServer/model/activeworkitems.py: Added.
1869
1870 2010-09-20  Andy Estes  <aestes@apple.com>
1871
1872         Reviewed by Adam Barth.
1873
1874         REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
1875         https://bugs.webkit.org/show_bug.cgi?id=40961
1876
1877         Implement WebKitUsePreHTML5ParserQuirks preference.
1878
1879         * DumpRenderTree/mac/DumpRenderTree.mm:
1880         (resetDefaultsToConsistentValues): Reset WebKitUsePreHTML5ParserQuirks
1881         to false after a test finishes.
1882
1883 2010-09-20  Adam Roben  <aroben@apple.com>
1884
1885         Windows build fix
1886
1887         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Put
1888         $(WebKitOutputDir)\include before $(WebKitLibrariesDir)\include so
1889         we'll pick up the most recent versions of the headers.
1890
1891 2010-09-20  Eric Seidel  <eric@webkit.org>
1892
1893         Reviewed by Adam Barth.
1894
1895         commit-queue should check commit-queue+ again just before committing
1896         https://bugs.webkit.org/show_bug.cgi?id=32679
1897
1898         Added a _revalidate_patch check, right before landing.
1899
1900         Since _revalidate_patch passes the patch_id from the work item
1901         back to bugzilla, I had to fix all of the previous queue tests to
1902         use valid attachment ids (that's the majority of this change).
1903
1904         In order to validate that the bug was still open, I had to teach
1905         bugzilla.Bug about open/closed states.
1906
1907         * Scripts/webkitpy/common/net/bugzilla.py:
1908         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1909         * Scripts/webkitpy/tool/commands/queues.py:
1910         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1911         * Scripts/webkitpy/tool/commands/queuestest.py:
1912         * Scripts/webkitpy/tool/mocktool.py:
1913
1914 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
1915
1916         Unreviewed.
1917
1918         Adding myself as a comitter.
1919
1920         * Scripts/webkitpy/common/config/committers.py:
1921
1922 2010-09-20  Adam Barth  <abarth@webkit.org>
1923
1924         Reviewed by Eric Seidel.
1925
1926         Two instances of commit-queue try to process the same patch
1927         https://bugs.webkit.org/show_bug.cgi?id=46113
1928
1929         This patch makes next-patch atomic so that the server won't vend the
1930         same patch twice in the same hour.
1931
1932         * QueueStatusServer/handlers/nextpatch.py:
1933
1934 2010-09-20  Adam Roben  <aroben@apple.com>
1935
1936         Make WebKitTestRunner's wait-to-dump watchdog timer work on Windows
1937
1938         We were previously trying to use a CFRunLoopTimer, but since Windows
1939         doesn't use CFRunLoop on most threads this doesn't work. Now we use a
1940         Windows-style timer on Windows.
1941
1942         I also replaced all uses of "watchdog" with "watchdog timer".
1943
1944         Fixes <http://webkit.org/b/46101> WebKitTestRunner's wait-to-dump
1945         watchdog timer doesn't work on Windows
1946
1947         Reviewed by Anders Carlsson.
1948
1949         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1950         (WTR::InjectedBundlePage::dump): Updated for rename.
1951
1952         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed
1953         platform-specific functions.
1954         (WTR::LayoutTestController::LayoutTestController): Added call to
1955         platformInitialize.
1956         (WTR::LayoutTestController::waitUntilDone): Changed to call
1957         initializeWaitToDumpWatchdogTimerIfNeeded instead of doing the work
1958         right in this function.
1959         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Updated for
1960         rename.
1961
1962         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added new
1963         members needed to support the watchdog timer abstraction. Replaced
1964         some "watchdog"s with "watchdog timer".
1965
1966         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
1967         Added.
1968         (WTR::LayoutTestController::platformInitialize): Does nothing on this
1969         platform.
1970         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Moved here
1971         from LayoutTestController.cpp and changed to use an early return.
1972         (WTR::waitUntilDoneWatchdogTimerFired): Moved here from
1973         LayoutTestController.cpp.
1974         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
1975         Moved code here from LayoutTestController::waitUntilDone and changed
1976         to use an early return.
1977
1978         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
1979         Added.
1980         (WTR::LayoutTestController::platformInitialize): Initialize our
1981         watchdog timer.
1982         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Added.
1983         Kills and clears the watchdog timer.
1984         (WTR::waitToDumpWatchdogTimerFired): Added. Calls through to the
1985         LayoutTestController member function of the same name.
1986         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
1987         Added. Sets up the timer if it isn't already set.
1988
1989         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added
1990         LayoutTestControllerMac.mm.
1991
1992         * WebKitTestRunner/win/InjectedBundle.vcproj: Added
1993         LayoutTestControllerWin.cpp.
1994
1995 2010-09-20  Martin Robinson  <mrobinson@igalia.com>
1996
1997         Reviewed by Daniel Bates.
1998
1999         [GTK] fast/forms/listbox-selection.html fails
2000         https://bugs.webkit.org/show_bug.cgi?id=45942
2001
2002         Use the gdkModifersFromJSValue helper to parse all appropriate modifier
2003         strings in keyDownCallback.
2004
2005         * DumpRenderTree/gtk/EventSender.cpp:
2006         (keyDownCallback): Use the gdkModifersFromJSValue instead of duplicating the 
2007         modifier parsing logic.
2008
2009 2010-09-19  Sam Weinig  <sam@webkit.org>
2010
2011         Reviewed by Anders Carlsson.
2012
2013         WebKit2 decidePolicyForNavigationAction should include mouse button information
2014         <rdar://problem/8413165>
2015         https://bugs.webkit.org/show_bug.cgi?id=46060
2016
2017         * MiniBrowser/mac/BrowserWindowController.m:
2018         (decidePolicyForNavigationAction):
2019         (decidePolicyForNewWindowAction):
2020
2021 2010-09-19  Daniel Bates  <dbates@rim.com>
2022
2023         Reviewed by Martin Robinson.
2024
2025         Add unit tests for diffs that delete or modify a change log entry
2026         or describe changes that are far apart
2027         https://bugs.webkit.org/show_bug.cgi?id=46046
2028
2029         Add additional unit tests to test change log diffs that contain
2030         deletions or changes that are far apart from each other in the
2031         ChangeLog file.
2032
2033         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2034           - Added the following unit tests:
2035           "fixChangeLogPatch: [no change] In-place change."
2036           "fixChangeLogPatch: [no change] Remove first entry."
2037           "fixChangeLogPatch: [no change] Remove entry in the middle."
2038           "fixChangeLogPatch: [no change] Far apart changes (i.e. more than one chunk)."
2039
2040 2010-09-19  Sam Weinig  <sam@webkit.org>
2041
2042         Reviewed by Anders Carlsson.
2043
2044         Replace WKBundleRangeRef with WKBundleRangeHandleRef.
2045         https://bugs.webkit.org/show_bug.cgi?id=46054
2046
2047         The new one acts like WKBundleNodeHandleRef and allows for getting a
2048         wrapper in a specific world for the handle.
2049
2050         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2051         (WTR::propertyValue):
2052         (WTR::propertyValueDouble):
2053         (WTR::propertyValueInt):
2054         (WTR::numericWindowPropertyValue):
2055         (WTR::toStr):
2056         (WTR::InjectedBundlePage::shouldBeginEditing):
2057         (WTR::InjectedBundlePage::shouldEndEditing):
2058         (WTR::InjectedBundlePage::shouldInsertNode):
2059         (WTR::InjectedBundlePage::shouldInsertText):
2060         (WTR::InjectedBundlePage::shouldDeleteRange):
2061         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
2062         (WTR::InjectedBundlePage::shouldApplyStyle):
2063         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2064
2065 2010-09-19  Kent Tamura  <tkent@chromium.org>
2066
2067         Unreviewed. Fix WebGL test regressions by r67809.
2068
2069         * DumpRenderTree/chromium/WebPreferences.cpp:
2070         (WebPreferences::applyTo): Call setExperimentalWebGLEnabled().
2071
2072 2010-09-19  Kent Tamura  <tkent@chromium.org>
2073
2074         Reviewed by Adam Barth.
2075
2076         [DRT/Chromium] Fix a WebSettings handling bug
2077         https://bugs.webkit.org/show_bug.cgi?id=45945
2078
2079         Before this change, Chromium DRT reset WebSettings for every new
2080         window. It was wrong.
2081         If new window is not the first one, we have to apply the same
2082         settings as the first window.  So, we introduce WebPreference to
2083         store the current settings, and apply it to new windows. It's same
2084         as test_shell's behavior.
2085
2086         * DumpRenderTree/DumpRenderTree.gypi:
2087         * DumpRenderTree/chromium/LayoutTestController.cpp:
2088           Use WebPreferences instead of WebSettings.
2089         (LayoutTestController::setUserStyleSheetEnabled):
2090         (LayoutTestController::setUserStyleSheetLocation):
2091         (LayoutTestController::setAuthorAndUserStylesEnabled):
2092         (LayoutTestController::setPopupBlockingEnabled):
2093         (LayoutTestController::disableImageLoading):
2094         (LayoutTestController::setJavaScriptCanAccessClipboard):
2095         (LayoutTestController::setXSSAuditorEnabled):
2096         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
2097         (LayoutTestController::setAllowFileAccessFromFileURLs):
2098         (LayoutTestController::overridePreference):
2099         (LayoutTestController::setEditingBehavior):
2100         * DumpRenderTree/chromium/TestShell.cpp:
2101         (TestShell::resetWebSettings): Use WebPreferences.
2102         (TestShell::runFileTest): ditto.
2103         (TestShell::createNewWindow): Apply existing WebPreferences to a new WebView.
2104         * DumpRenderTree/chromium/TestShell.h:
2105         (TestShell::preferences):
2106         (TestShell::applyPreferences):
2107         * DumpRenderTree/chromium/WebPreferences.cpp: Added.
2108         * DumpRenderTree/chromium/WebPreferences.h: Added.
2109
2110 2010-09-18  Prasad Tammana  <prasadt@chromium.org>
2111
2112         Reviewed by David Levin.
2113
2114         update-webkit --chromium spitting out a spurious error
2115         https://bugs.webkit.org/show_bug.cgi?id=45868
2116
2117         * Scripts/update-webkit-chromium: Use commandExists() function to check for existence of gclient.
2118
2119 2010-09-18  Sam Weinig  <sam@webkit.org>
2120
2121         Reviewed by Dan Bernstein.
2122
2123         Improve/unify the PageLoadClient interfaces
2124         https://bugs.webkit.org/show_bug.cgi?id=46043
2125
2126         * MiniBrowser/mac/BrowserWindowController.m:
2127         (didStartProvisionalLoadForFrame):
2128         (didReceiveServerRedirectForProvisionalLoadForFrame):
2129         (didFailProvisionalLoadWithErrorForFrame):
2130         (didCommitLoadForFrame):
2131         (didFinishDocumentLoadForFrame):
2132         (didFinishLoadForFrame):
2133         (didFailLoadWithErrorForFrame):
2134         (didReceiveTitleForFrame):
2135         (didFirstLayoutForFrame):
2136         (didFirstVisuallyNonEmptyLayoutForFrame):
2137         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2138         (WTR::InjectedBundlePage::InjectedBundlePage):
2139         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2140         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
2141         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2142         (WTR::InjectedBundlePage::didCommitLoadForFrame):
2143         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2144         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
2145         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2146         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
2147         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2148         * WebKitTestRunner/TestController.cpp:
2149         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2150         (WTR::TestController::didFinishLoadForFrame):
2151         * WebKitTestRunner/TestController.h:
2152
2153 2010-09-17  Eric Seidel  <eric@webkit.org>
2154
2155         Unreviewed.  Adding a shell script I use to run the
2156         commit-queue. Now that multiple machines run the cq,
2157         it makes sense to share the script between them.
2158
2159         * EWSTools/start-commit-queue.sh: Added.
2160
2161 2010-09-17  Brian Weinstein  <bweinstein@apple.com>
2162
2163         Reviewed by Jon Honeycutt.
2164
2165         The colors on the new build.webkit.org (after upgrading the master to 0.8.1) are
2166         slightly harder to read, so this reverts the previous background colors for various
2167         states, making it easier to read.
2168
2169         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
2170         (.success):
2171         (.failure):
2172         (.warnings):
2173         (.exception):
2174         (.start,.running,td.building):
2175         (.offline,td.offline):
2176
2177 2010-09-17  Sheriff Bot  <webkit.review.bot@gmail.com>
2178
2179         Unreviewed, rolling out r67692.
2180         http://trac.webkit.org/changeset/67692
2181         https://bugs.webkit.org/show_bug.cgi?id=46011
2182
2183         broke layout test dashboard (Requested by johnny_g on
2184         #webkit).
2185
2186         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2187         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2188         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2189
2190 2010-09-17  Martin Robinson  <mrobinson@igalia.com>
2191
2192         Reviewed by Oliver Hunt.
2193
2194         Style bot complains about cairo forward declaration naming
2195         https://bugs.webkit.org/show_bug.cgi?id=45867
2196
2197         Exclude Cairo forward declarations from indentifiers with underscores checks.
2198
2199         * Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations.
2200         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
2201
2202 2010-09-16  Kinuko Yasuda  <kinuko@chromium.org>
2203
2204         Reviewed by Ojan Vafai.
2205
2206         Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests
2207         https://bugs.webkit.org/show_bug.cgi?id=45408
2208
2209         This change also tries to remove duplicated upload_results_json methods
2210         in run_webkit_tests.py and json_results_generator.py.
2211
2212         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2213         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2214         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2215
2216 2010-09-16  Antonio Gomes  <tonikitoo@webkit.org>
2217
2218         Reviewed by Andreas Kling.
2219
2220         [Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set.
2221
2222         Recently r67554 changed the way different views use the WebPage class: it was previously being shared between
2223         different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's
2224         were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking
2225         all page specific stuff to the UI.
2226
2227         * QtTestBrowser/launcherwindow.cpp:
2228         (LauncherWindow::initializeView):
2229         * QtTestBrowser/mainwindow.cpp:
2230         (MainWindow::MainWindow):
2231         (MainWindow::buildUI):
2232         (MainWindow::setPage):
2233         * QtTestBrowser/mainwindow.h:
2234
2235 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
2236
2237         Reviewed by Andreas Kling.
2238
2239         Make all accesses to m_item (GraphicsWebView) done by WebViewGraphicsBased class happen though graphicsWebView getter method.
2240
2241         This patch is mostly a preparation for another commit, where the ownership of the m_item/GraphicsWebView
2242         object will move to the qgraphicsscene instead of the qgraphicsview.
2243
2244         * QtTestBrowser/webview.cpp:
2245         (WebViewGraphicsBased::setPage):
2246         (WebViewGraphicsBased::setResizesToContents):
2247         (WebViewGraphicsBased::resizeEvent):
2248         (WebViewGraphicsBased::animatedFlip):
2249         * QtTestBrowser/webview.h:
2250         (WebViewGraphicsBased::setItemCacheMode):
2251         (WebViewGraphicsBased::itemCacheMode):
2252
2253 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
2254
2255         Reviewed by Andreas Kling.
2256
2257         Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.
2258
2259         We usually separate methods whose body are larger than a few lines from the class definition.
2260
2261         * QtTestBrowser/webview.h:
2262         (WebViewGraphicsBased::yRotation):
2263         (WebViewGraphicsBased::setYRotation):
2264
2265 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
2266
2267         Reviewed by Andreas Kling.
2268
2269         Make initializeView method of LauncherWindow private.
2270
2271         No one else needs to be able to call it but LauncherWindow.
2272         Also moving the declation of isGraphicsBased method down in the same file, in order
2273         to better group related methods.
2274
2275         * QtTestBrowser/launcherwindow.h:
2276
2277 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
2278
2279         Reviewed by Andreas Kling.
2280
2281         Make the getter 'page' method of MainWindow const.
2282
2283         * QtTestBrowser/mainwindow.cpp:
2284         (MainWindow::page):
2285         * QtTestBrowser/mainwindow.h:
2286
2287 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
2288
2289         Reviewed by Andreas Kling.
2290
2291         Remove useless parameter from MainWindow class' constructor.
2292
2293         The parameter defaults to an empty URL and is not being used by any caller. Apart from that it is also
2294         not referred in the constructor body and does not make much sense.
2295
2296         * QtTestBrowser/mainwindow.cpp:
2297         (MainWindow::MainWindow):
2298         * QtTestBrowser/mainwindow.h:
2299
2300 2010-09-15  Tony Chang  <tony@chromium.org>
2301
2302         Reviewed by Kent Tamura.
2303
2304         [Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
2305         https://bugs.webkit.org/show_bug.cgi?id=42151
2306
2307         * DumpRenderTree/chromium/LayoutTestController.cpp:
2308         (LayoutTestController::LayoutTestController):
2309         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2310         (WorkItemLoadHTMLString::run):
2311         (LayoutTestController::queueLoadHTMLString):
2312         (LayoutTestController::reset):
2313         (LayoutTestController::setDeferMainResourceDataLoad):
2314         * DumpRenderTree/chromium/LayoutTestController.h:
2315         (LayoutTestController::deferMainResourceDataLoad):
2316         * DumpRenderTree/chromium/WebViewHost.cpp:
2317         (WebViewHost::didCreateDataSource):
2318
2319 2010-09-16  Adrienne Walker  <enne@google.com>
2320
2321         Reviewed by Kenneth Russell.
2322
2323         Add script to synchronize WebKit and Khronos WebGL tests
2324         https://bugs.webkit.org/show_bug.cgi?id=42336
2325
2326         * Scripts/update-webgl-conformance-tests: Added.
2327         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Added.
2328         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Added.
2329
2330 2010-09-16  Sam Weinig  <sam@webkit.org>
2331
2332         Reviewed by Anders Carlsson.
2333
2334         Add support for sending synchronous messages from the InjectedBundle to the WKContext
2335         <rdar://problem/8365320>
2336         https://bugs.webkit.org/show_bug.cgi?id=44785
2337
2338         * MiniBrowser/mac/AppDelegate.m:
2339         (didReceiveSynchronousMessageFromInjectedBundle):
2340         (-[BrowserAppDelegate init]):
2341         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2342         (didCreatePage):
2343         * WebKitTestRunner/TestController.cpp:
2344         (WTR::TestController::initialize):
2345
2346 2010-09-16  Leonid Ebril  <leonid.ebril@nokia.com>
2347
2348         Reviewed by Andreas Kling.
2349
2350         [Qt] QtTestBrowser: Disable creation of a new window for screenshot on Symbian platform.
2351         https://bugs.webkit.org/show_bug.cgi?id=45885
2352
2353         Avoid creation of an additional window for screenshot to prevent overlapping with original window.
2354
2355         * QtTestBrowser/launcherwindow.cpp:
2356         (LauncherWindow::screenshot):
2357
2358 2010-09-16  Anders Carlsson  <andersca@apple.com>
2359
2360         Fix clang++ build.
2361
2362         * MiniBrowser/mac/BrowserWindowController.m:
2363         (-[BrowserWindowController zoomIn:]):
2364         (-[BrowserWindowController zoomOut:]):
2365         (-[BrowserWindowController resetZoom:]):
2366         Remove trailing semicolons.
2367
2368 2010-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
2369
2370         Unreviewed, rolling out r67628.
2371         http://trac.webkit.org/changeset/67628
2372         https://bugs.webkit.org/show_bug.cgi?id=45904
2373
2374         broke the build (Requested by eric_carlson on #webkit).
2375
2376         * DumpRenderTree/gtk/EventSender.cpp:
2377         (contextClickCallback):
2378
2379 2010-09-16  Balazs Kelemen  <kbalazs@webkit.org>
2380
2381         Unreviewed.
2382
2383         Adding myself as a comitter.
2384
2385         * Scripts/webkitpy/common/config/committers.py:
2386
2387 2010-09-15  Philippe Normand  <pnormand@igalia.com>
2388
2389         Reviewed by Eric Carlson.
2390
2391         [GTK] enhanced context menu for media elements
2392         https://bugs.webkit.org/show_bug.cgi?id=45021
2393
2394         EventSender::contextClick() now returns an array of js
2395         objects. Each object has a title property and a click() method.
2396
2397         * DumpRenderTree/gtk/EventSender.cpp:
2398         (getMenuItemTitleCallback):
2399         (setMenuItemTitleCallback):
2400         (menuItemClickCallback):
2401         (getMenuItemClass):
2402         (contextClickCallback):
2403
2404 2010-09-14  Philippe Normand  <pnormand@igalia.com>
2405
2406         Reviewed by Eric Carlson and Martin Robinson.
2407
2408         [GTK] eventSender.contextClick() should return the contents of the context menu
2409         https://bugs.webkit.org/show_bug.cgi?id=39102
2410
2411         Make the eventSender use the new private WebKitGtk+ API to
2412         retrieve the context-menu item titles and store them in an array.
2413
2414         * DumpRenderTree/gtk/EventSender.cpp:
2415         (contextClickCallback):
2416
2417 2010-09-16  Eric Uhrhane  <ericu@chromium.org>
2418
2419         Reviewed by Jian Li.
2420
2421         Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
2422         https://bugs.webkit.org/show_bug.cgi?id=45798
2423
2424         * Scripts/build-webkit:
2425
2426 2010-09-16  Robert Hogan  <robert@webkit.org>
2427
2428         Reviewed by Antonio Gomes.
2429
2430         [Qt] Support globalhistory tests
2431         https://bugs.webkit.org/show_bug.cgi?id=45774
2432
2433         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2434         (WebCore::isGlobalHistoryTest):
2435         (WebCore::DumpRenderTree::open):
2436         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2437         (LayoutTestController::reset):
2438         (LayoutTestController::dumpHistoryCallbacks):
2439         (LayoutTestController::removeAllVisitedLinks):
2440         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2441
2442 2010-09-10  Tony Chang  <tony@chromium.org>
2443
2444         Reviewed by Eric Seidel.
2445
2446         deduplicate-tests should be runnable from any WebKit directory
2447         https://bugs.webkit.org/show_bug.cgi?id=44709
2448
2449         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
2450         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2451
2452 2010-09-15  Tony Chang  <tony@chromium.org>
2453
2454         Reviewed by Kent Tamura.
2455
2456         [chromium] sort testing methods in DRT
2457         https://bugs.webkit.org/show_bug.cgi?id=45850
2458
2459         * DumpRenderTree/chromium/EventSender.cpp:
2460         (EventSender::EventSender):
2461         * DumpRenderTree/chromium/LayoutTestController.cpp:
2462         (LayoutTestController::LayoutTestController):
2463         * DumpRenderTree/chromium/TextInputController.cpp:
2464         (TextInputController::TextInputController):
2465
2466 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
2467
2468         Reviewed by Adam Barth.
2469
2470         CQ status shows items out of order
2471         https://bugs.webkit.org/show_bug.cgi?id=45846
2472         
2473         Only group consecutive status items with the same patch ID into the same
2474         group, so that overall item ordering is preserved.
2475         
2476         Also don't indent status items that only have a single item in their
2477         group.
2478
2479         * QueueStatusServer/handlers/queuestatus.py:
2480         * QueueStatusServer/templates/includes/singlequeuestatus.html: Added.
2481         * QueueStatusServer/templates/queuestatus.html:
2482
2483 2010-09-15  Eric Seidel  <eric@webkit.org>
2484
2485         Reviewed by Adam Barth.
2486
2487         Add queue start/stop messages
2488         https://bugs.webkit.org/show_bug.cgi?id=45853
2489
2490         I ended up needing to clean up a bunch of our unit testing
2491         in order to test this new code path nicely.
2492
2493         There are also a few PEP8 changes needed to pass check-webkit-style.
2494
2495         * Scripts/webkitpy/tool/bot/queueengine.py:
2496         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2497         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2498         * Scripts/webkitpy/tool/commands/queues.py:
2499         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2500         * Scripts/webkitpy/tool/commands/queuestest.py:
2501         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2502
2503 2010-09-15  Simon Fraser  <simon.fraser@apple.com>
2504
2505         https://bugs.webkit.org/show_bug.cgi?id=45849
2506         WKURLCreateWithCFURL crashes with null url
2507         
2508         Fix MiniBrowser crash when the url is not parseable.
2509
2510         * MiniBrowser/mac/BrowserWindowController.m:
2511         (-[BrowserWindowController fetch:]):
2512
2513 2010-09-15  Patrick Gansterer  <paroga@paroga.com>
2514
2515         Unreviewed.
2516
2517         Adding myself to the committers list.
2518
2519         * Scripts/webkitpy/common/config/committers.py:
2520
2521 2010-09-14  Eric Seidel  <eric@webkit.org>
2522
2523         Reviewed by Adam Barth.
2524
2525         Make it possible to run more than one commit-queue instance
2526         https://bugs.webkit.org/show_bug.cgi?id=45786
2527
2528         Mostly we need to make sure the two (or more) instances get
2529         different patches to work on.  To do this, I re-worked
2530         the code responsible for getting the next work item to
2531         round trip through the status server.  The status server only
2532         vends patches from the work items list, only if those patches
2533         have not had status reported for them in the last hour.
2534
2535         This is another step towards making all queues go through the
2536         status server, thus making it possible to run more than one
2537         instance of various EWS bots (as requested in bug 44292).
2538
2539         The webkitpy changes are already covered by existing unit tests.
2540         The QueueStatusSever sadly has no testing infrastructure yet. :(
2541
2542         * QueueStatusServer/handlers/nextpatch.py: Added.
2543         * QueueStatusServer/index.yaml:
2544         * QueueStatusServer/main.py:
2545         * Scripts/webkitpy/tool/commands/queues.py:
2546
2547 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
2548
2549         Reviewed by Tony Chang.
2550
2551         NRWT fails with UnicodeDecodeError on editing/selection/mixed-editability-10.html
2552         https://bugs.webkit.org/show_bug.cgi?id=45791
2553
2554         Force filenames to be raw bytes before running difflib.unified_diff.
2555
2556         * Scripts/webkitpy/layout_tests/port/base.py:
2557         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2558
2559 2010-09-15  Simon Hausmann  <simon.hausmann@nokia.com>
2560
2561         Reviewed by Tor Arne Vestbø.
2562
2563         [Qt] QtTestBrowser crashes when enabling QGraphicsView mode after first loading page without it enabled
2564         https://bugs.webkit.org/show_bug.cgi?id=35247
2565
2566         The main issue when changing the views is that the plugins and any other components that
2567         depend on view specific attributes such as the native window id are not teared down.
2568         Even if we had a tear-down procedure, we'd have to re-initialize the plugin after
2569         switching to the new view (QGraphicsWebView). This is a rather uncommon situation, so
2570         we decided to work around this in QtTestBrowser by making toggling between QWebView
2571         and QGraphicsWebView also re-create the page.
2572
2573         * QtTestBrowser/launcherwindow.cpp:
2574         (LauncherWindow::initializeView):
2575         * QtTestBrowser/mainwindow.h:
2576
2577 2010-09-14  Mihai Parparita  <mihaip@chromium.org>
2578
2579         Reviewed by Adam Barth.
2580
2581         Send webkit accessibility notifications to Chromium
2582         https://bugs.webkit.org/show_bug.cgi?id=45156
2583
2584         Move printf inside shouldDumpAccessibilityNotifications check.
2585
2586         * DumpRenderTree/chromium/WebViewHost.cpp:
2587         (WebViewHost::postAccessibilityNotification):
2588
2589 2010-09-14  Tony Chang  <tony@chromium.org>
2590
2591         Reviewed by Kent Tamura.
2592
2593         [chromium] fix http/tests/security/local-user-CSS-from-remote.html
2594         https://bugs.webkit.org/show_bug.cgi?id=45788
2595
2596         * DumpRenderTree/chromium/LayoutTestController.cpp:
2597         (LayoutTestController::setUserStyleSheetLocation): use a base64 url like in Chrome
2598
2599 2010-09-14  Tony Chang  <tony@chromium.org>
2600
2601         Reviewed by Ojan Vafai.
2602
2603         [chromium] Remove WebKit::areLayoutTestImagesOpaque since it's no longer needed
2604         https://bugs.webkit.org/show_bug.cgi?id=45768
2605
2606         * DumpRenderTree/chromium/TestShell.cpp:
2607         (TestShell::dumpImage): new baselines are checked in and Linux will match Windows going forward.
2608
2609 2010-09-14  Kevin Ollivier  <kevino@theolliviers.com>
2610
2611         [wx] Build fix, add newly added directories to the directory list.
2612
2613         * wx/build/settings.py:
2614
2615 2010-09-14  Sam Weinig  <sam@webkit.org>
2616
2617         Reviewed by Anders Carlsson.
2618
2619         Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef.
2620         https://bugs.webkit.org/show_bug.cgi?id=45785
2621
2622         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2623         (WTR::propertyValue):
2624         (WTR::numericWindowPropertyValue):
2625         (WTR::dumpPath):
2626         (WTR::toStr):
2627         (WTR::operator<<):
2628         (WTR::InjectedBundlePage::InjectedBundlePage):
2629         (WTR::InjectedBundlePage::shouldInsertNode):
2630         (WTR::InjectedBundlePage::shouldBeginEditing):
2631         (WTR::InjectedBundlePage::shouldEndEditing):
2632         (WTR::InjectedBundlePage::shouldInsertText):
2633         (WTR::InjectedBundlePage::shouldDeleteRange):
2634         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
2635         (WTR::InjectedBundlePage::shouldApplyStyle):
2636         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2637
2638 2010-09-14  Adam Barth  <abarth@webkit.org>
2639
2640         Fix two typos in commit-queue.  The first is harmless.  The second
2641         causes the queue to reject patches when the build is broken.  :(
2642
2643         * Scripts/webkitpy/tool/commands/queues.py:
2644         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2645
2646 2010-09-14  Chris Guillory   <chris.guillory@google.com>
2647
2648         Reviewed by Chris Fleizach.
2649
2650         Send all accessibility notifications to Chromium.
2651         https://bugs.webkit.org/show_bug.cgi?id=45156
2652
2653         * DumpRenderTree/chromium/WebViewHost.cpp:
2654         (WebViewHost::postAccessibilityNotification):
2655         * DumpRenderTree/chromium/WebViewHost.h:
2656
2657 2010-09-14  Adam Barth  <abarth@webkit.org>
2658
2659         Reviewed by Eric Seidel.
2660
2661         commit-queue is slow during the day
2662         https://bugs.webkit.org/show_bug.cgi?id=45780
2663
2664         Thanks to the new logging, we've noticed that checkout-is-out-of-date
2665         errors in the first pass of landing don't retry the land.  Instead,
2666         they're treated as failures and cause the commit-queue to do two more
2667         builds before really trying to land the patch.  Worse, in the second
2668         build, we can get bitten by a flaky test.
2669
2670         This patch takes a slightly different approach to the commit-queue's
2671         main control logic.  We now use a separate subprocess for building and
2672         testing and for landing.  This means we should very rarely see the
2673         checkout-is-out-of-date error, and when we do see it, we should retry
2674         more quickly.  If my understanding is correct, this should be a big
2675         speed win for the commit-queue.
2676
2677         * Scripts/webkitpy/tool/commands/download.py:
2678         * Scripts/webkitpy/tool/commands/queues.py:
2679         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2680
2681 2010-09-14  Tony Chang  <tony@chromium.org>
2682
2683         Reviewed by Dimitri Glazkov.
2684
2685         [chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme
2686         https://bugs.webkit.org/show_bug.cgi?id=45762
2687
2688         * DumpRenderTree/chromium/LayoutTestController.cpp:
2689         (LayoutTestController::LayoutTestController):
2690         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2691         * DumpRenderTree/chromium/LayoutTestController.h:
2692
2693 2010-09-14  Csaba Osztrogonác  <ossy@webkit.org>
2694
2695         Adding myself as a reviewer.
2696
2697         * Scripts/webkitpy/common/config/committers.py:
2698
2699 2010-09-14  Zoltan Horvath  <zoltan@webkit.org>
2700
2701         Reviewed by Kenneth Rohde Christiansen.
2702
2703         [Qt] Build-webkit shows a warning when WebKitBuild directory is not exist
2704         https://bugs.webkit.org/show_bug.cgi?id=45736
2705
2706         Build-webkit has showed a warning when WebKitBuild didn't exist, add
2707         an additional condition to avoid it.
2708
2709         * Scripts/build-webkit:
2710
2711 2010-09-13  Eric Seidel  <eric@webkit.org>
2712
2713         Reviewed by Adam Barth.
2714
2715         commit-queue should log when it's retrying due to checkout out of date error
2716         https://bugs.webkit.org/show_bug.cgi?id=45725
2717
2718         This will allow us to better track how often we see these errors
2719         and how long it takes the queue to recover from them.
2720
2721         In order to pass the tests, I had to correct an error
2722         from a previous change.  The UnitTestPort should not have
2723         ever been using the base port method as that will read
2724         a file from disk.  If the unit tests haven't passed the contents
2725         it should raise an IOError as though the file doesn't exist.
2726
2727         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2728         * Scripts/webkitpy/tool/commands/queues.py:
2729         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2730
2731 2010-09-13  Mihai Parparita  <mihaip@chromium.org>
2732
2733         Reviewed by Adam Barth.
2734
2735         Upload results when cq patch landing fails
2736         https://bugs.webkit.org/show_bug.cgi?id=45683
2737         
2738         Include script errors when CommitQueue._land fails.
2739
2740         * Scripts/webkitpy/tool/commands/queues.py:
2741
2742 2010-09-13  Chris Fleizach  <cfleizach@apple.com>
2743
2744         Reviewed by David Kilzer.
2745
2746         AX: accessibilityIsIgnored is returning nil when return value expects a BOOL
2747         https://bugs.webkit.org/show_bug.cgi?id=45548
2748
2749         * DumpRenderTree/AccessibilityUIElement.cpp:
2750         (isIgnoredCallback):
2751         (AccessibilityUIElement::getJSClass):
2752         * DumpRenderTree/AccessibilityUIElement.h:
2753         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2754         (AccessibilityUIElement::isIgnored):
2755         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2756         (AccessibilityUIElement::isIgnored):
2757         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2758         (AccessibilityUIElement::isIgnored):
2759
2760 2010-09-13  Csaba Osztrogonác  <ossy@webkit.org>
2761
2762         Reviewed by Andreas Kling.
2763
2764         jscPath() is incorrect in Windows' cmd.exe shell
2765         https://bugs.webkit.org/show_bug.cgi?id=45651
2766
2767         * Scripts/webkitdirs.pm: Add ".exe" suffix to $jscName on Windows.
2768
2769 2010-09-13  Chris Fleizach  <cfleizach@apple.com>
2770
2771         Reviewed by Darin Adler.
2772
2773         REGRESSION (r64816-r64889): Crash in WebCore::AccessibilityRenderObject
2774         https://bugs.webkit.org/show_bug.cgi?id=43807
2775
2776         * DumpRenderTree/AccessibilityUIElement.cpp:
2777         (textMarkerForPointCallback):
2778         (AccessibilityUIElement::textMarkerForPoint):
2779         (AccessibilityUIElement::getJSClass):
2780         * DumpRenderTree/AccessibilityUIElement.h:
2781         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2782         (AccessibilityUIElement::textMarkerForPoint):
2783
2784 2010-09-13  Andreas Kling  <andreas.kling@nokia.com>
2785
2786         Reviewed by Kenneth Rohde Christiansen.
2787
2788         [Qt] build-webkit: Add --v8 option to build against V8
2789
2790         Note that V8 is picked up from QtScript, so this currently requires building
2791         against the experimental qt-script-v8 branch.
2792
2793         * Scripts/build-webkit:
2794
2795 2010-09-13  Hans Wennborg  <hans@chromium.org>
2796
2797         Reviewed by Jeremy Orlow.
2798
2799         Add WebDeviceOrientationClientMock::create() and use it from DRT.
2800         https://bugs.webkit.org/show_bug.cgi?id=45650
2801
2802         Do not use the WebDeviceOrientationClientMock constructor directly,
2803         but use the create() member function.
2804
2805         This should fix the linker errors for the multi-DLL Chromium DRT build.
2806
2807         * DumpRenderTree/chromium/LayoutTestController.cpp:
2808         (LayoutTestController::setMockDeviceOrientation):
2809         (LayoutTestController::deviceOrientationClient):
2810
2811 2010-08-27  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
2812
2813         Reviewed by Antti Koivisto.
2814
2815         Add support for testing the viewport meta tag algorithm,
2816         based on the following draft spec:
2817
2818         http://people.opera.com/rune/TR/ED-css-viewport-20100806/
2819
2820         Add common handling of viewport meta tag based on new Opera spec
2821         https://bugs.webkit.org/show_bug.cgi?id=44201
2822
2823         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2824         (LayoutTestController::dumpConfigurationForViewport):
2825         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2826
2827 2010-09-12  Kent Tamura  <tkent@chromium.org>
2828
2829         Reviewed by Tony Chang.
2830
2831         [DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h
2832         https://bugs.webkit.org/show_bug.cgi?id=45517
2833
2834         Use webkit_support_gfx.h for PNG encoding/decoding instead of png_codec.h
2835
2836         * DumpRenderTree/chromium/ImageDiff.cpp:
2837         (Image::craeteFromStdin):
2838         (Image::createFromFilename):
2839         (diffImages):
2840         * DumpRenderTree/chromium/TestShell.cpp:
2841         (TestShell::dumpImage):
2842
2843 2010-09-10  MORITA Hajime  <morrita@google.com>
2844
2845         Reviewed by Tony Chang.
2846
2847         [Chromium] Implement textInputController.hasSpellingMarker() for Chromium
2848         https://bugs.webkit.org/show_bug.cgi?id=45441
2849
2850         Added TextInputController::hasSpellingMarker().
2851         
2852         * DumpRenderTree/chromium/TextInputController.cpp:
2853         (TextInputController::TextInputController):
2854         (TextInputController::hasSpellingMarker):
2855         * DumpRenderTree/chromium/TextInputController.h:
2856
2857 2010-09-12  Dirk Pranke  <dpranke@chromium.org>
2858
2859         Unreviewed, build fix.
2860
2861         My last change accidentally contained a local change to the
2862         rebaselinig script; webkit-patch land picked it up without telling
2863         me and committed it :(
2864
2865         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2866
2867 2010-09-11  Maciej Stachowiak  <mjs@apple.com>
2868
2869         Reviewed by Anders Carlsson.
2870
2871         Attempt to fix Windows MiniBrowser build (untested)
2872         https://bugs.webkit.org/show_bug.cgi?id=45609
2873
2874         * MiniBrowser/win/BrowserView.cpp:
2875         (runJavaScriptConfirm):
2876         (runJavaScriptPrompt):
2877
2878 2010-09-11  Sam Weinig  <sam@webkit.org>
2879
2880         Reviewed by Maciej Stachowiak.
2881
2882         Fix zoom related tests when testing WebKit2.
2883
2884         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2885         (WTR::EventSendingController::zoomPageIn): Zoom in and zoom out are not the same.
2886
2887 2010-09-11  Sam Weinig  <sam@webkit.org>
2888
2889         Reviewed by Dan Bernstein.
2890
2891         Implement WebKit2 callback equivalent to - [WebUIDelegate webView:setStatusText:]
2892         <rdar://problem/8359252>
2893         https://bugs.webkit.org/show_bug.cgi?id=45605
2894
2895         * MiniBrowser/mac/BrowserWindowController.m:
2896         (setStatusText):
2897         (contentsSizeChanged):
2898         (-[BrowserWindowController awakeFromNib]):
2899         * MiniBrowser/win/BrowserView.cpp:
2900         (runJavaScriptConfirm):
2901         (runJavaScriptPrompt):
2902         (setStatusText):
2903         (contentsSizeChanged):
2904         (BrowserView::create):
2905         * WebKitTestRunner/TestController.cpp:
2906         (WTR::createOtherPage):
2907         (WTR::TestController::initialize):
2908
2909 2010-09-11  Sam Weinig  <sam@webkit.org>
2910
2911         Reviewed by Dan Bernstein.
2912
2913         Add callback mechanism for the getting the source of a frame
2914         <rdar://problem/8364681>
2915         https://bugs.webkit.org/show_bug.cgi?id=45604
2916
2917         Add ability to dump the main frame's source to the console.
2918
2919         * MiniBrowser/mac/BrowserWindowController.h:
2920         * MiniBrowser/mac/BrowserWindowController.m:
2921         (-[BrowserWindowController dumpSourceToConsole:]):
2922         * MiniBrowser/mac/MainMenu.xib:
2923
2924 2010-09-11  Eric Seidel  <eric@webkit.org>
2925
2926         Reviewed by Adam Barth.
2927
2928         Remove unneeded Empty Queue messages
2929         https://bugs.webkit.org/show_bug.cgi?id=45602
2930
2931         We already have a /gc job to delete these.
2932         recentstatus.py is already smart enough to use the
2933         most recent of the workitems last update or the most recent status,
2934         so removing these should not change the _last_status_date() return
2935         value more than a few milliseconds.
2936
2937         These messages just spam the recent status log.
2938
2939         * Scripts/webkitpy/tool/commands/queues.py:
2940
2941 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
2942
2943         Reviewed by Adam Barth.
2944
2945         Fix Python exception when generating synthetic patch IDs
2946         https://bugs.webkit.org/show_bug.cgi?id=45592
2947
2948         Can't concatenate strings and numbers directly.
2949
2950         * QueueStatusServer/handlers/queuestatus.py:
2951
2952 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
2953
2954         Reviewed by Adam Barth.
2955
2956         Group statuses in queue status by patch ID
2957         https://bugs.webkit.org/show_bug.cgi?id=45588
2958
2959         Group statuses by patch ID so that the status page is easier
2960         to scan.
2961
2962         * QueueStatusServer/handlers/queuestatus.py:
2963         * QueueStatusServer/stylesheets/dashboard.css:
2964         (.status-group):
2965         (.status-bug):
2966         (.status-group ul):
2967         (.status-group ul li):
2968         (.status-group ul li:hover):
2969         (.status-cell):
2970         (.status-cell:hover):
2971         (.status-cell.pass):
2972         (.status-cell.fail):
2973         (.status-cell.pending):
2974         (.status-cell.error):
2975         * QueueStatusServer/templates/dashboard.html:
2976         * QueueStatusServer/templates/queuestatus.html:
2977
2978 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
2979
2980         Reviewed by Tony Chang.
2981
2982         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
2983         https://bugs.webkit.org/show_bug.cgi?id=45479
2984
2985         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
2986         implementation in ResourceLoadDelegate in the Mac port).
2987
2988         * DumpRenderTree/chromium/LayoutTestController.cpp:
2989         (LayoutTestController::LayoutTestController):
2990         (LayoutTestController::dumpResourceResponseMIMETypes):
2991         (LayoutTestController::reset):
2992         * DumpRenderTree/chromium/LayoutTestController.h:
2993         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
2994         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
2995         * DumpRenderTree/chromium/TestShell.h:
2996         (TestShell::shouldDumpResourceResponseMIMETypes):
2997         * DumpRenderTree/chromium/WebViewHost.cpp:
2998         (WebViewHost::didReceiveResponse):
2999
3000 2010-09-11  Eric Seidel  <eric@webkit.org>
3001
3002         Reviewed by Adam Barth.
3003
3004         queues.webkit.org should expose /remote_api for data upload/download
3005         https://bugs.webkit.org/show_bug.cgi?id=45559
3006
3007         * QueueStatusServer/app.yaml:
3008          - /remote_api is a standard app-engine service which allows use of
3009            the bulk uploader for data upload/download.  Exposing this
3010            (for admin access only) allows us to use 
3011
3012 2010-09-10  Sam Weinig  <sam@webkit.org>
3013
3014         Reviewed by Dan Bernstein.
3015
3016         Add zoom support to WebKit2 API
3017         <rdar://problem/7660657>
3018         https://bugs.webkit.org/show_bug.cgi?id=45585
3019
3020         - Add zoom options to MiniBrowser that mimic Safari's options using
3021           the new WebKit2 zoom APIs.
3022         - Switch uses of float for the zoom APIs to use double.
3023
3024         * MiniBrowser/mac/BrowserWindowController.h:
3025         * MiniBrowser/mac/BrowserWindowController.m:
3026         (-[BrowserWindowController initWithPageNamespace:]):
3027         (-[BrowserWindowController validateMenuItem:]):
3028         (-[BrowserWindowController validateUserInterfaceItem:]):
3029         (-[BrowserWindowController currentZoomFactor]):
3030         (-[BrowserWindowController setCurrentZoomFactor:]):
3031         (-[BrowserWindowController canZoomIn]):
3032         (-[BrowserWindowController zoomIn:]):
3033         (-[BrowserWindowController canZoomOut]):
3034         (-[BrowserWindowController zoomOut:]):
3035         (-[BrowserWindowController canResetZoom]):
3036         (-[BrowserWindowController resetZoom:]):
3037         (-[BrowserWindowController toggleZoomMode:]):
3038         * MiniBrowser/mac/MainMenu.xib:
3039         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3040         (WTR::EventSendingController::textZoomIn):
3041         (WTR::EventSendingController::textZoomOut):
3042         (WTR::EventSendingController::zoomPageIn):
3043         (WTR::EventSendingController::zoomPageOut):
3044
3045 2010-09-10  Robert Hogan  <robert@webkit.org>
3046
3047         Reviewed by Andreas Kling.
3048
3049         [Qt] Fix crash in DRT in standalone mode
3050
3051         https://bugs.webkit.org/show_bug.cgi?id=45454
3052
3053         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3054         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
3055
3056 2010-09-10  Sam Weinig  <sam@webkit.org>
3057
3058         Reviewed by Darin Adler.
3059
3060         Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
3061         Precursor to <rdar://problem/7660657>
3062         https://bugs.webkit.org/show_bug.cgi?id=45522
3063
3064         Update for changes to the Bundle API to allow separate control of page and text zoom
3065         levels.
3066
3067         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3068         (WTR::EventSendingController::textZoomIn):
3069         (WTR::EventSendingController::textZoomOut):
3070         (WTR::EventSendingController::zoomPageIn):
3071         (WTR::EventSendingController::zoomPageOut):
3072         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3073         (WTR::InjectedBundlePage::reset):
3074
3075 2010-09-10  Yael Aharon  <yael.aharon@nokia.com>
3076
3077         Reviewed by Andreas Kling.
3078
3079         [Qt] Support click event for notifications
3080         https://bugs.webkit.org/show_bug.cgi?id=44836
3081
3082         Add support for simulateDesktopNotificationClick by calling
3083         back to DumpRenderTreeSupportQt.cpp.
3084
3085         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3086         (LayoutTestController::simulateDesktopNotificationClick):
3087         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3088
3089 2010-09-10  Mihai Parparita  <mihaip@chromium.org>
3090
3091         Reviewed by Eric Seidel.
3092
3093         Update queue status when patches fail their first land attempt
3094         https://bugs.webkit.org/show_bug.cgi?id=45583
3095
3096         Add a few more _update_status calls to make it more obvious if a patch is 
3097         being retried because tests failed.
3098
3099         * Scripts/webkitpy/tool/commands/queues.py:
3100
3101 2010-09-10  Balazs Kelemen  <kb@inf.u-szeged.hu>
3102
3103         Reviewed by Andreas Kling.
3104
3105         [Qt] MiniBrowser crashes with multiply windows when closing one of them
3106         https://bugs.webkit.org/show_bug.cgi?id=45536
3107
3108         * MiniBrowser/qt/BrowserView.cpp:
3109         (BrowserView::BrowserView): Reference the context instead of adopting it
3110         because it can be shared across different views.
3111
3112 2010-09-10  Tony Chang  <tony@chromium.org>
3113
3114         Unreviewed, rolling out r67241.
3115         http://trac.webkit.org/changeset/67241
3116         https://bugs.webkit.org/show_bug.cgi?id=44709
3117
3118         Accidentally committed.
3119
3120         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3121         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3122
3123 2010-09-10  Tony Chang  <tony@chromium.org>
3124
3125         Reviewed by Ojan Vafai.
3126
3127         deduplicate-tests should be runnable from any WebKit directory
3128         https://bugs.webkit.org/show_bug.cgi?id=44709
3129
3130         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3131         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3132
3133 2010-09-10  Tony Chang  <tony@chromium.org>
3134
3135         Unreviewed, rolling out r67216.
3136         http://trac.webkit.org/changeset/67216
3137         https://bugs.webkit.org/show_bug.cgi?id=44709
3138
3139         Broke
3140
3141         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3142         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3143
3144 2010-09-10  Tony Chang  <tony@chromium.org>
3145
3146         Reviewed by Ojan Vafai.
3147
3148         deduplicate-tests should be runnable from any WebKit directory
3149         https://bugs.webkit.org/show_bug.cgi?id=44709
3150
3151         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3152         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3153
3154 2010-09-09  Hans Wennborg  <hans@chromium.org>
3155
3156         Reviewed by Jeremy Orlow.
3157
3158         Hook up LayoutTestController.setMockDeviceOrientation() in Chromium DumpRenderTree.
3159         https://bugs.webkit.org/show_bug.cgi?id=45460
3160
3161         This enables DumpRenderTree to run layout tests for DeviceOrientation.
3162
3163         Also declare the LayoutTestController destructor out-of-line.
3164         Otherwise the implicit destructor would cause compiler errors because
3165         of the OwnPtr<WebKit::WebDeviceOrientationClientMock> member.
3166
3167         * DumpRenderTree/chromium/LayoutTestController.cpp:
3168         (LayoutTestController::~LayoutTestController):
3169         (LayoutTestController::setMockDeviceOrientation):
3170         (LayoutTestController::deviceOrientationClient):
3171         * DumpRenderTree/chromium/LayoutTestController.h:
3172         * DumpRenderTree/chromium/WebViewHost.cpp:
3173         (WebViewHost::deviceOrientationClient):
3174         * DumpRenderTree/chromium/WebViewHost.h:
3175
3176 2010-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
3177
3178         Unreviewed, rolling out r67119.
3179         http://trac.webkit.org/changeset/67119
3180         https://bugs.webkit.org/show_bug.cgi?id=45505
3181
3182         Extra newlines in results (Requested by tony^work on #webkit).
3183
3184         * DumpRenderTree/chromium/LayoutTestController.cpp:
3185         (LayoutTestController::LayoutTestController):
3186         (LayoutTestController::reset):
3187         * DumpRenderTree/chromium/LayoutTestController.h:
3188         * DumpRenderTree/chromium/TestShell.h:
3189         * DumpRenderTree/chromium/WebViewHost.cpp:
3190         (printResponseDescription):
3191         (printNodeDescription):
3192         (printRangeDescription):
3193         (WebViewHost::shouldBeginEditing):
3194         (WebViewHost::shouldEndEditing):
3195         (WebViewHost::shouldInsertNode):
3196         (WebViewHost::shouldChangeSelectedRange):
3197         (WebViewHost::shouldDeleteRange):
3198         (WebViewHost::shouldApplyStyle):
3199         (WebViewHost::didBeginEditing):
3200         (WebViewHost::didChangeSelection):
3201         (WebViewHost::didChangeContents):
3202         (WebViewHost::didEndEditing):
3203         (WebViewHost::decidePolicyForNavigation):
3204         (WebViewHost::didCancelClientRedirect):
3205         (WebViewHost::didStartProvisionalLoad):
3206         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
3207         (WebViewHost::didFailProvisionalLoad):
3208         (WebViewHost::didCommitProvisionalLoad):
3209         (WebViewHost::didFinishDocumentLoad):
3210         (WebViewHost::didHandleOnloadEvents):
3211         (WebViewHost::didFailLoad):
3212         (WebViewHost::didFinishLoad):
3213         (WebViewHost::didChangeLocationWithinPage):
3214         (WebViewHost::willSendRequest):
3215         (WebViewHost::didReceiveResponse):
3216         (WebViewHost::didFinishResourceLoad):
3217         (WebViewHost::didFailResourceLoad):
3218         (WebViewHost::didDisplayInsecureContent):
3219         (WebViewHost::didRunInsecureContent):
3220         (WebViewHost::printFrameDescription):
3221
3222 2010-09-09  Michael Saboff  <msaboff@apple.com>
3223
3224         Unreviewed, adding myself to committers list.
3225
3226         * Scripts/webkitpy/common/config/committers.py:
3227
3228 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
3229
3230         Reviewed by Tony Chang.
3231
3232         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
3233         https://bugs.webkit.org/show_bug.cgi?id=45479
3234
3235         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
3236         implementation in ResourceLoadDelegate in the Mac port).
3237
3238         * DumpRenderTree/chromium/LayoutTestController.cpp:
3239         (LayoutTestController::LayoutTestController):
3240         (LayoutTestController::dumpResourceResponseMIMETypes):
3241         (LayoutTestController::reset):
3242         * DumpRenderTree/chromium/LayoutTestController.h:
3243         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
3244         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
3245         * DumpRenderTree/chromium/TestShell.h:
3246         (TestShell::shouldDumpResourceResponseMIMETypes):
3247         * DumpRenderTree/chromium/WebViewHost.cpp:
3248         (WebViewHost::didReceiveResponse):
3249
3250 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
3251
3252         Reviewed by Daniel Bates.
3253
3254         svn-apply tries to delete directories it shouldn't
3255         https://bugs.webkit.org/show_bug.cgi?id=45424
3256
3257         isDirectoryEmptyForRemoval had the wrong check. If an item in the
3258         directory is itself a directory, then the directory is definitely
3259         not empty.
3260
3261         * Scripts/svn-apply:
3262
3263 2010-09-09  Chris Fleizach  <cfleizach@apple.com>
3264
3265         Fixing GTK and windows build failure.
3266
3267         AX: Support AccessibilityTextMarkers in DRT
3268         https://bugs.webkit.org/show_bug.cgi?id=44778
3269
3270         * DumpRenderTree/AccessibilityTextMarker.h:
3271         (AccessibilityTextMarker::platformTextMarker):
3272         (AccessibilityTextMarkerRange::platformTextMarkerRange):
3273         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
3274         (AccessibilityTextMarker::platformTextMarker):
3275         (AccessibilityTextMarkerRange::platformTextMarkerRange):
3276
3277 2010-09-09  Chris Fleizach  <cfleizach@apple.com>
3278
3279         Reviewed by David Kilzer.
3280
3281         AX: Support AccessibilityTextMarkers in DRT
3282         https://bugs.webkit.org/show_bug.cgi?id=44778
3283
3284         Add AccessibilityTextMarker and AccessibilityTextMarkerRange which encapsulate the AXTextMarkers 
3285         that WebCore uses when vending information about its VisiblePositions through AX.
3286
3287         There are a few new methods in AccessibilityUIElement to retrieve and use text markers, and some basic
3288         methods for encapsulating and checking equality.
3289
3290         This will allow future bug fixes in the text marker system to be adequately tested.
3291
3292         * DumpRenderTree/AccessibilityTextMarker.cpp: Added.
3293         (toTextMarker):
3294         (isMarkerEqualCallback):
3295         (markerFinalize):
3296         (AccessibilityTextMarker::makeJSAccessibilityTextMarker):
3297         (AccessibilityTextMarker::getJSClass):
3298         (toTextMarkerRange):
3299         (isMarkerRangeEqualCallback):
3300         (markerRangeFinalize):
3301         (AccessibilityTextMarkerRange::makeJSAccessibilityTextMarkerRange):
3302         (AccessibilityTextMarkerRange::getJSClass):
3303         * DumpRenderTree/AccessibilityTextMarker.h: Added.
3304         (AccessibilityTextMarker::platformTextMarker):
3305         (AccessibilityTextMarkerRange::platformTextMarkerRange):
3306         (AccessibilityTextMarker::AccessibilityTextMarker):
3307         (AccessibilityTextMarker::~AccessibilityTextMarker):
3308         (AccessibilityTextMarker::isEqual):
3309         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
3310         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
3311         (AccessibilityTextMarkerRange::isEqual):
3312         * DumpRenderTree/AccessibilityUIElement.cpp:
3313         (textMarkerRangeForElementCallback):
3314         (textMarkerRangeLengthCallback):
3315         (textMarkerRangeForMarkersCallback):
3316         (startTextMarkerForTextMarkerRangeCallback):
3317         (endTextMarkerForTextMarkerRangeCallback):
3318         (accessibilityElementForTextMarkerCallback):
3319         (AccessibilityUIElement::textMarkerRangeForElement):
3320         (AccessibilityUIElement::textMarkerRangeLength):
3321         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
3322         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
3323         (AccessibilityUIElement::accessibilityElementForTextMarker):
3324         (AccessibilityUIElement::getJSClass):
3325         * DumpRenderTree/AccessibilityUIElement.h:
3326         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3327         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm: Added.
3328         (AccessibilityTextMarker::AccessibilityTextMarker):
3329         (AccessibilityTextMarker::~AccessibilityTextMarker):
3330         (AccessibilityTextMarker::isEqual):
3331         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
3332         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
3333         (AccessibilityTextMarkerRange::isEqual):
3334         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3335         (AccessibilityUIElement::textMarkerRangeForElement):
3336         (AccessibilityUIElement::textMarkerRangeLength):
3337         (AccessibilityUIElement::textMarkerRangeForMarkers):
3338         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
3339         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
3340         (AccessibilityUIElement::accessibilityElementForTextMarker):
3341         * DumpRenderTree/win/DumpRenderTree.vcproj:
3342
3343 2010-08-25  Tony Chang  <tony@chromium.org>
3344
3345         Reviewed by Ojan Vafai.
3346
3347         don't delete duplicates needed because of intermediate results
3348         https://bugs.webkit.org/show_bug.cgi?id=44653
3349
3350         Also, output the full path so we can pipe the output to rm.
3351
3352         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3353         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3354
3355 2010-09-09  Balazs Kelemen  <kb@inf.u-szeged.hu>
3356
3357         Reviewed by Andreas Kling.
3358
3359         [Qt] MiniBrowser does not starts properly
3360         https://bugs.webkit.org/show_bug.cgi?id=45459
3361
3362         Do not try set up the first window by calling newWindow on a
3363         newly created BrowserWindow since it creates a new object.
3364         * MiniBrowser/qt/BrowserWindow.cpp:
3365         (BrowserWindow::BrowserWindow):
3366         * MiniBrowser/qt/main.cpp:
3367         (main):
3368
3369 2010-09-09  Martin Robinson  <mrobinson@igalia.com>
3370
3371         Reviewed by Xan Lopez.
3372
3373         [GTK] Get ImageDiff building on Win32
3374         https://bugs.webkit.org/show_bug.cgi?id=45353
3375
3376         * DumpRenderTree/gtk/ImageDiff.cpp:
3377         (main): Switch from using strtok to g_strsplit.
3378
3379 2010-09-09  Zoltan Horvath  <zoltan@webkit.org>
3380
3381         Reviewed by Andreas Kling.
3382
3383         [Qt] Modify load method of MiniBrowser's BrowserView class
3384         https://bugs.webkit.org/show_bug.cgi?id=45442
3385
3386         Modify load method to take a QString as argument, remove unnecessary QT_VERSION_CHECK.
3387
3388         * MiniBrowser/qt/BrowserView.cpp:
3389         (BrowserView::load):
3390         * MiniBrowser/qt/BrowserView.h:
3391         * MiniBrowser/qt/BrowserWindow.cpp:
3392         (BrowserWindow::load):
3393
3394 2010-09-09  Tony Chang  <tony@chromium.org>
3395
3396         Reviewed by Ojan Vafai.
3397
3398         fix show_results in new-run-webkit-tests
3399         https://bugs.webkit.org/show_bug.cgi?id=45413
3400
3401         * Scripts/webkitpy/layout_tests/port/chromium.py:
3402
3403 2010-09-08  Victor Wang  <victorw@chromium.org>
3404
3405         Reviewed by Ojan Vafai.
3406
3407         [Chromium] Fix test results server to make sure
3408         it does not have corrupted data.
3409
3410         results.json file size coulbe be >1M and we split
3411         the data into multiple data store entries in this
3412         case. This patch fixes the issue that the data may
3413         be corrupted if data store error happens in the middle
3414         of saving multiple entries.
3415
3416         https://bugs.webkit.org/show_bug.cgi?id=45063
3417
3418         * TestResultServer/model/datastorefile.py:
3419
3420 2010-09-08  Peter Varga  <pvarga@inf.u-szeged.hu>
3421
3422         Reviewed by Kenneth Rohde Christiansen.
3423
3424         Fix ignoring return value warning in case of gcc 4.4.4
3425         https://bugs.webkit.org/show_bug.cgi?id=45384
3426
3427         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3428         (testPostURLFile):
3429         If fwrite have written zero byte then the testPostURLFile function
3430         returns with false as tempFile can't be opened.
3431         * DumpRenderTree/qt/ImageDiff.cpp:
3432         (main):
3433         Put fwrite function into an if condition without body to avoid
3434         warning. It is safe because this function writes to the stdout.
3435
3436 2010-09-08  Satish Sampath  <satish@chromium.org>
3437
3438         Unreviewed, adding myself to committers list.
3439
3440         * Scripts/webkitpy/common/config/committers.py:
3441
3442 2010-09-08  Hans Wennborg  <hans@chromium.org>
3443
3444         Unreviewed.
3445
3446         Adding myself as a committer in committers.py.
3447
3448         * Scripts/webkitpy/common/config/committers.py:
3449
3450 2010-09-08  Zoltan Horvath  <zoltan@webkit.org>
3451
3452         Reviewed by Simon Hausmann.
3453
3454         [Qt] Refactor MiniBrowser 
3455         https://bugs.webkit.org/show_bug.cgi?id=45173
3456
3457         Split BrowserWindow into two source files and headers. Remove unnecessary header includes.
3458
3459         * MiniBrowser/qt/BrowserView.cpp: Added.
3460         (createNewPage):
3461         (BrowserView::BrowserView):
3462         (BrowserView::resizeEvent):
3463         (BrowserView::load):
3464         (BrowserView::view):
3465         * MiniBrowser/qt/BrowserView.h: Added.
3466         (BrowserView::~BrowserView):
3467         * MiniBrowser/qt/BrowserWindow.cpp:
3468         * MiniBrowser/qt/BrowserWindow.h:
3469         * MiniBrowser/qt/MiniBrowser.pro:
3470
3471 2010-09-08  Adam Barth  <abarth@webkit.org>
3472
3473         Rubber-stamped by Eric Seidel.
3474
3475         Rename DocLoader to CachedResourceLoader because that's what it does.
3476
3477         * Scripts/do-webcore-rename:
3478
3479 2010-09-07  Kinuko Yasuda  <kinuko@chromium.org>
3480
3481         Reviewed by Ojan Vafai.
3482
3483         Enable incremental results.json generation for non-layout tests.
3484         https://bugs.webkit.org/show_bug.cgi?id=45315
3485
3486         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Enable generate_incremental_results=True by default. (This still keeps to generate results.json.)  Also add a code to upload results json files to the app-engine server.  Need a chromium change to actually start the uploading.
3487
3488         * TestResultServer/model/jsonresults.py: Make sure we save the file with test_type for incremental cases too.
3489
3490
3491 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
3492
3493         Unreviewed, build fix
3494
3495         Missed one test in mac_unittest.py in previous change; for some
3496         reason the method is listed twice. I will fix both for now, but will
3497         figure this out in a later, not-time-sensitive patch.
3498
3499         https://bugs.webkit.org/show_bug.cgi?id=45357
3500
3501         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3502
3503 2010-09-07  Kent Tamura  <tkent@chromium.org>
3504
3505         Reviewed by Tony Chang.
3506
3507         test-webkitpy: Fix load error of
3508         webkitpy/layout_tests/port/factory_unittest.py on Win32 Python
3509         https://bugs.webkit.org/show_bug.cgi?id=45356 Need a short
3510
3511         * Scripts/webkitpy/layout_tests/port/server_process.py:
3512           Avoid to import fcntl on win32. Win32 Python doesn't have fcntl
3513           and we don't use server_process.py on Win32 Python. However
3514           unittest.py tries to load everything in a module.
3515
3516 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
3517
3518         Reviewed by Kent Tamura.
3519
3520         Fix regression introduced in previous change to new-run-webkit-tests
3521         (bug 45090) to not try to run unittests for the Mac implementation
3522         of the Port interface if we aren't running on a Mac.
3523
3524         Also fix the overrides implementation mock in the chromium unittests
3525         to fix the case where there are overrides checked in that cause
3526         problems.
3527
3528         https://bugs.webkit.org/show_bug.cgi?id=45357
3529
3530         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3531         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3532         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3533
3534 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
3535
3536         Reviewed by Ojan Vafai.
3537
3538         new-run-webkit-tests: still more unit tests
3539
3540         Clean up and remove unnecessary code. Biggest notable change is
3541         moving the chromium-specific imagediff code from port/base to
3542         port/chromium.
3543
3544         Add more unit tests for run_webkit_tests.py, port/base.py,
3545         port/factory.py, port/dryrun.py, and
3546         layout_package/dump_render_tree_thread.py
3547
3548         This covers almost all of the generic and test code paths except for
3549         a few error paths involving invalid or port-specific command line
3550         arguments, and the code path for uploading results files to the
3551         buildbots.
3552         
3553         https://bugs.webkit.org/show_bug.cgi?id=45090
3554
3555         * Scripts/webkitpy/layout_tests/data/failures/expected/hang.html: Added.
3556         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
3557         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
3558         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
3559         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
3560         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
3561         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
3562         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
3563         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3564         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Added.
3565         * Scripts/webkitpy/layout_tests/port/base.py:
3566         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3567         * Scripts/webkitpy/layout_tests/port/chromium.py:
3568         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3569         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3570         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3571         * Scripts/webkitpy/layout_tests/port/port_testcase.py: Added.
3572         * Scripts/webkitpy/layout_tests/port/server_process.py:
3573         * Scripts/webkitpy/layout_tests/port/test.py:
3574         * Scripts/webkitpy/layout_tests/port/webkit.py:
3575         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3576         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3577
3578 2010-09-07  Joseph Pecoraro  <joepeck@webkit.org>
3579
3580         Reviewed by Darin Adler.
3581
3582         Provide a way to trigger a <select multiple> onchange event on changes
3583         https://bugs.webkit.org/show_bug.cgi?id=45192
3584
3585         Adds a selector on ObjCController for testing
3586         -[DOMHTMLSelectElement _activateItemAtIndex:allowMultipleSelection:] and
3587         its different uses.
3588
3589         * DumpRenderTree/mac/ObjCController.m:
3590         (+[ObjCController isSelectorExcludedFromWebScript:]):
3591         (+[ObjCController webScriptNameForSelector:]):
3592         (-[ObjCController setSelectElement:selectedIndex:allowingMultiple:]):
3593
3594 2010-09-07  James Robinson  <jamesr@chromium.org>
3595
3596         Rubber-stamped by Dimitri Glazkov.
3597
3598         Move myself from the committer to the reviewer list.
3599
3600         * Scripts/webkitpy/common/config/committers.py:
3601
3602 2010-09-07  Tony Chang  <tony@chromium.org>
3603
3604         Reviewed by Darin Fisher.
3605
3606         [chromium] Make a public flag for how DRT generates bitmaps on Linux
3607         https://bugs.webkit.org/show_bug.cgi?id=45133
3608
3609         * DumpRenderTree/chromium/TestShell.cpp:
3610         (TestShell::dumpImage):
3611
3612 2010-09-07  Kent Tamura  <tkent@chromium.org>
3613
3614         Reviewed by Dimitri Glazkov.
3615
3616         [DRT/Chromium] Implement --check-layout-test-sys-deps
3617         https://bugs.webkit.org/show_bug.cgi?id=45283
3618
3619         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3620         (main): Check --check-layout-test-sys-deps and call checkLayoutTestSystemDependencies().
3621         * DumpRenderTree/chromium/TestShell.h: Declare checkLayoutTestSystemDependencies().
3622         * DumpRenderTree/chromium/TestShellGtk.cpp:
3623         (checkLayoutTestSystemDependencies): Add an empty implementation.
3624         * DumpRenderTree/chromium/TestShellMac.mm:
3625         (checkLayoutTestSystemDependencies): Add an empty implementation.
3626         * DumpRenderTree/chromium/TestShellWin.cpp:
3627         (checkLayoutTestSystemDependencies): Port similar function of test_shell.
3628
3629 2010-09-07  Jessie Berlin  <jberlin@apple.com>
3630
3631         Unreviewed. Mac build fix.
3632
3633         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3634         (didClearWindowObjectForFrame):
3635
3636 2010-09-07  Jessie Berlin  <jberlin@apple.com>
3637
3638         Reviewed by Darin Adler.
3639
3640         Indicate which one of the ScriptWorlds for a Frame the Window Object has been cleared for
3641         https://bugs.webkit.org/show_bug.cgi?id=45217
3642         
3643         Make WebKitTestRunner work with this change.
3644
3645         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3646         (WTR::InjectedBundlePage::didClearWindowForFrame):
3647         Make sure the ScriptWorld here is the normal world, since that is no longer being done in
3648         WebFrameLoaderClient.
3649         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3650
3651 2010-09-07  Philippe Normand  <pnormand@igalia.com>
3652
3653         Unreviewed, build fix.
3654
3655         webkit-patch command to find the ports covering a specific layout test
3656         https://bugs.webkit.org/show_bug.cgi?id=42832
3657
3658         * Scripts/webkitpy/layout_tests/port/chromium.py: Don't assume the
3659         tests are present when building the expectations. This is needed
3660         for the unittests.
3661
3662 2010-09-06  Philippe Normand  <pnormand@igalia.com>
3663
3664         Reviewed by Adam Barth.
3665
3666         webkit-patch command to find the ports covering a specific layout test
3667         https://bugs.webkit.org/show_bug.cgi?id=42832
3668
3669         To use it: webkit-patch skipped-ports some/layout/test.html
3670
3671         * Scripts/webkitpy/layout_tests/port/base.py:
3672         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3673         * Scripts/webkitpy/layout_tests/port/chromium.py:
3674         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3675         * Scripts/webkitpy/layout_tests/port/factory.py:
3676         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3677         * Scripts/webkitpy/layout_tests/port/test.py:
3678         * Scripts/webkitpy/layout_tests/port/webkit.py:
3679         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3680         * Scripts/webkitpy/tool/commands/queries.py:
3681         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3682         * Scripts/webkitpy/tool/main.py:
3683         * Scripts/webkitpy/tool/mocktool.py:
3684
3685 2010-09-07  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3686
3687         Reviewed by Eric Seidel.
3688
3689         [NRWT] Add temp directory to all running drivers.
3690         https://bugs.webkit.org/show_bug.cgi?id=45261
3691
3692         * Scripts/webkitpy/layout_tests/port/webkit.py:
3693
3694 2010-09-06  Dimitri Glazkov  <dglazkov@chromium.org>
3695
3696         Reviewed by Kent Tamura.
3697
3698         [Chromium/DRT] Empty out user stylesheet after each test run.
3699         https://bugs.webkit.org/show_bug.cgi?id=45282
3700
3701         This should significantly cut down on the number of the mysterious flaky tests
3702         whose diffs looked like the page was blown up to a very lage size. This
3703         was indeed the dirty work of platform/mac/fast/loader/user-stylesheet-fast-path.html,
3704         which set the base body font to 100px.
3705
3706         Since the user stylesheet was never reset, _all_ pixel tests that ran after it in
3707         the same thread failed.
3708
3709         * DumpRenderTree/chromium/TestShell.cpp:
3710         (TestShell::resetWebSettings): Set user stylesheet to an empty URL.
3711
3712 2010-09-06  Kent Tamura  <tkent@chromium.org>
3713
3714         Reviewed by Dimitri Glazkov.
3715
3716         [DRT/Chromium] Do not generate pixel results for text/plain resources
3717         https://bugs.webkit.org/show_bug.cgi?id=45253
3718
3719         * DumpRenderTree/chromium/TestShell.cpp:
3720         (TestShell::dump): Clear shouldGeneratePixelResults flag for text/plain.
3721
3722 2010-09-06  Ojan Vafai  <ojan@chromium.org>
3723
3724         Reviewed by Kent Tamura.
3725
3726         print out correct error when a DRT thread dies in NRWT
3727         https://bugs.webkit.org/show_bug.cgi?id=45281
3728
3729         Not sure why, but with the parens, python 2.6.5 on Linux
3730         gives an error that raise takes 5 arguments and 0 were given.
3731         Didn't test other platforms or python versions, but putting it
3732         all on one line fixes it and correctly prints the exception
3733         from the DRT thread.
3734
3735         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3736
3737 2010-09-06  Eric Seidel  <eric@webkit.org>
3738
3739         Unreviewed, just adding some emails from lists.webkit.org.
3740
3741         Update committers.py to include emails from lists.webkit.org
3742         as found by the validate-committer-lists script.
3743
3744         * Scripts/webkitpy/common/config/committers.py:
3745
3746 2010-09-06  Martin Robinson  <mrobinson@igalia.com>
3747
3748         Reviewed by Xan Lopez.
3749
3750         [GTK] Small code cleanup in DumpRenderTreeGtk.cpp
3751         https://bugs.webkit.org/show_bug.cgi?id=45213
3752
3753         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3754         (initializeFonts): Made this function do nothing for non-X11 platforms, so we don't
3755         have to surround the invocation with #ifdefs.
3756         (useLongRunningServerMode): Added.
3757         (runTestingServerLoop): Added.
3758         (initializeGlobalsFromCommandLineOptions): Added.
3759         (runTest): Removed ifdefs.
3760         (main): Use new helper functions.
3761
3762 2010-09-06  Martin Robinson  <mrobinson@igalia.com>
3763
3764         Reviewed by Xan Lopez.
3765
3766         [GTK] EventSender should support modifier keys with mouseDown and mouseUp events
3767         https://bugs.webkit.org/show_bug.cgi?id=45235
3768
3769         Add support for interpreting the modifier key arguments to the mouseDown and mouseUp
3770         methods of the EventSender.
3771
3772         * DumpRenderTree/gtk/EventSender.cpp:
3773         (prepareMouseButtonEvent): Allow passing in a modifier bitmask, which will be OR'd
3774         with the current modifiers.
3775         (contextClickCallback): Always send no modifiers when preparing the mouse event.
3776         (gdkModifersFromJSValue): Added, converts a JSValue array into a GDK modifier bitmask.
3777         (mouseDownCallback): Send in the requested modifiers to prepareMouseButtonEvent.
3778         (mouseUpCallback): Ditto.
3779
3780 2010-09-05  Peter Kasting  <pkasting@google.com>
3781
3782         Reviewed by Adam Barth.
3783
3784         Make Chromium/Mac generate continuous mousewheel events with the same wheelDelta values as Safari/Mac.
3785         https://bugs.webkit.org/show_bug.cgi?id=45155
3786
3787         * DumpRenderTree/chromium/EventSender.cpp: Modify Chromium DRT mousewheel event generation to match new behavior on Mac.
3788         (EventSender::handleMouseWheel):
3789
3790 2010-09-05  Yury Semikhatsky  <yurys@chromium.org>
3791
3792         Reviewed by Joseph Pecoraro.
3793
3794         Web Inspector: remove WebDevToolsAgentClient::forceRepaint which is not used
3795         https://bugs.webkit.org/show_bug.cgi?id=45179
3796
3797         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3798         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3799
3800 2010-09-05  Andreas Kling  <andreas.kling@nokia.com>
3801
3802         Rubber-stamped by Daniel Bates.
3803
3804         Adding myself as reviewer.
3805
3806         * Scripts/webkitpy/common/config/committers.py:
3807
3808 2010-09-04  Daniel Bates  <dbates@rim.com>
3809
3810         Reviewed by Martin Robinson.
3811
3812         Teach svn-apply/unapply about svn:mergeinfo
3813         https://bugs.webkit.org/show_bug.cgi?id=45236
3814
3815         Recognize the svn:mergeinfo property and ignore it for now.
3816
3817         Currently, svn-apply/unapply recognize only '+' and '-'
3818         property changes within a diff. We should add support
3819         to recognize "Merged" and "Reverse-merged" changes as well.
3820         Because svn:mergeinfo is metadata that is used only by SVN
3821         and tends to be error-prone and/or nuisance (*), we will ignore
3822         it for now.
3823         (*) See "Parting Thoughts" of <http://www.collab.net/community/subversion/articles/merge-info.html>.
3824
3825         * Scripts/VCSUtils.pm:
3826           - Modified parseSvnProperty() to recognize "Merged" and
3827             "Reverse-merged" as the start of a property value.
3828         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
3829           - Added the following unit tests:
3830             "simple: add svn:mergeinfo"
3831             "simple: delete svn:mergeinfo"
3832             "simple: modified svn:mergeinfo"
3833         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
3834           - Added the following unit tests:
3835             "simple: add svn:mergeinfo"
3836             "simple: delete svn:mergeinfo"
3837             "simple: modified svn:mergeinfo"
3838             "simple: modified svn:mergeinfo using SVN 1.4 syntax"
3839             "'Merged' change followed by 'Merged' change"
3840             "'Reverse-merged' change followed by 'Reverse-merged' change"
3841         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
3842           - Added the following unit tests:
3843             "'Merged' change"
3844             "'Reverse-merged' change"
3845             "'Reverse-merged' change followed by 'Merge' change"
3846             "'Merged' change followed by 'Merge' change"
3847             "'Reverse-merged' change followed by 'Reverse-merged' change"
3848             "'Reverse-merged' change followed by 'Reverse-merged' change followed by 'Merged' change"
3849
3850 2010-09-04  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3851
3852         Reviewed by Kenneth Rohde Christiansen.
3853
3854         [EFL] Move test browser to WebKitTools directory
3855         https://bugs.webkit.org/show_bug.cgi?id=45212
3856
3857         Follow other ports like QT and GTK which moved the test browser to
3858         WebKitTools directory.
3859
3860         * CMakeListsEfl.txt: Added.
3861         * EWebLauncher/main.c: Added.
3862         (print_history):
3863         (zoom_level_set):
3864         (on_ecore_evas_resize):
3865         (title_set):
3866         (viewport_set):
3867         (on_title_changed):
3868         (on_progress):
3869         (on_load_finished):
3870         (on_toolbars_visible_set):
3871         (on_toolbars_visible_get):
3872         (on_statusbar_visible_set):
3873         (on_statusbar_visible_get):
3874         (on_scrollbars_visible_set):
3875         (on_scrollbars_visible_get):
3876         (on_menubar_visible_set):
3877         (on_menubar_visible_get):
3878         (on_tooltip_text_set):
3879         (on_inputmethod_changed):
3880         (on_viewport_changed):
3881         (on_mouse_down):
3882         (on_focus_out):
3883         (on_focus_in):
3884         (on_resized):
3885         (on_key_down):
3886         (on_browser_del):
3887         (on_closeWindow):
3888         (quit):
3889         (browserCreate):
3890         (browserDestroy):
3891         (closeWindow):
3892         (main_signal_exit):
3893         (findThemePath):
3894         (main):
3895
3896 2010-09-03  Simon Fraser  <simon.fraser@apple.com>
3897
3898         Reviewed by Adam Roben.
3899
3900         Set project dependencies so that they build serially. This fixes
3901         issues when running run-webkit-tests if DRT is not built yet.
3902
3903         * DumpRenderTree/DumpRenderTree.sln:
3904
3905 2010-09-03  Dimitri Glazkov  <dglazkov@chromium.org>
3906
3907         Reviewed by Adam Barth.
3908
3909         Fix reading configuraiton in NWRT to work on Windows.
3910         https://bugs.webkit.org/show_bug.cgi?id=45180
3911
3912         * Scripts/webkitpy/layout_tests/port/base.py: Added 'perl' argument, because Windows doesn't know what to do
3913             with the file otherwise.
3914
3915 2010-09-03  Chris Rogers  <crogers@google.com>
3916
3917         Unreviewed
3918
3919         Add myself to the committers list
3920         https://bugs.webkit.org/show_bug.cgi?id=45189
3921
3922         * Scripts/webkitpy/common/config/committers.py:
3923
3924 2010-09-03  Andrey Kosyakov  <caseq@chromium.org>
3925
3926         Reviewed by Yury Semikhatsky.
3927
3928         http/tests/inspector/console-xhr-logging.html and http/tests/inspector/resource-har-conversion.html are failing on chromium win bot
3929         Changed MIME type for .js to application/x-javascript for consistency with apache used on other platforms.
3930         https://bugs.webkit.org/show_bug.cgi?id=45137
3931
3932         * Scripts/webkitpy/layout_tests/port/lighttpd.conf:
3933
3934 2010-09-03  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3935
3936         Reviewed by Eric Seidel.
3937
3938         Add feature detection support to NRWT.
3939         https://bugs.webkit.org/show_bug.cgi?id=41842
3940
3941         * Scripts/webkitpy/layout_tests/port/base.py:
3942         * Scripts/webkitpy/layout_tests/port/qt.py:
3943         * Scripts/webkitpy/layout_tests/port/webkit.py:
3944         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added.
3945
3946 2010-09-03  Hironori Bono  <hbono@chromium.org>
3947
3948         Reviewed by Kent Tamura.
3949
3950         Adds textInputController.hasSpellingMarker() to avoid using pixel tests for spellchecking tests
3951         and implements it for Mac.
3952         https://bugs.webkit.org/show_bug.cgi?id=41832
3953
3954         * DumpRenderTree/mac/TextInputController.m: Added [TextInputController hasSpellingMarker:length:]
3955         and bind it so we can call it from JavaScript.
3956         (+[TextInputController isSelectorExcludedFromWebScript:]):
3957         (+[TextInputController webScriptNameForSelector:]):
3958         (-[TextInputController hasSpellingMarker:length:]):
3959
3960 2010-09-02  Eric Seidel  <eric@webkit.org>
3961
3962         Reviewed by Adam Barth.
3963
3964         Add a unit test for commit-queue retries
3965         https://bugs.webkit.org/show_bug.cgi?id=45162
3966
3967         I think commit-queue retries are not correctly avoiding
3968         build and test on retries.  So I started testing the code.
3969         Unfortunately this test did not find the bug.  But now
3970         that we have the test we might as well keep it.
3971         I also fixed a broken import in validate-committer-lists.
3972
3973         * Scripts/validate-committer-lists:
3974         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3975
3976 2010-09-02  Kent Tamura  <tkent@chromium.org>
3977
3978         Reviewed by Dimitri Glazkov.
3979
3980         [DRT/Chromium] Remove dependency to base/task.h and base/timer.h
3981         https://bugs.webkit.org/show_bug.cgi?id=45091
3982
3983         Task.{cpp,h} introduces a simpler version of Chromium
3984         base/task.h. It doesn't have TupleN and Method.
3985
3986         * DumpRenderTree/DumpRenderTree.gypi:
3987          Add Task.cpp and Task.h
3988         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3989         (DRTDevToolsAgent::DRTDevToolsAgent):
3990         (DRTDevToolsAgent::reset):
3991         (DRTDevToolsAgent::asyncCall):
3992         (DRTDevToolsAgent::frontendLoaded):
3993         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3994         (DRTDevToolsAgent::taskList): Added to use MethodTask<T>.
3995         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
3996         (DRTDevToolsClient::DRTDevToolsClient):
3997         (DRTDevToolsClient::~DRTDevToolsClient):
3998         (DRTDevToolsClient::reset):
3999         (DRTDevToolsClient::asyncCall):
4000         * DumpRenderTree/chromium/DRTDevToolsClient.h:
4001         (DRTDevToolsClient::taskList): Added to use MethodTask<T>.
4002         * DumpRenderTree/chromium/EventSender.cpp:
4003         (EventSender::EventSender):
4004         (EventSender::reset):
4005         (EventSender::scheduleAsynchronousClick):
4006         * DumpRenderTree/chromium/EventSender.h:
4007         (EventSender::taskList): Added to use MethodTask<T>.
4008         * DumpRenderTree/chromium/LayoutTestController.cpp:
4009         (LayoutTestController::LayoutTestController):
4010         (LayoutTestController::WorkQueue::processWorkSoon):
4011         (LayoutTestController::waitUntilDone):
4012         (LayoutTestController::notifyDone):
4013         (LayoutTestController::reset):
4014         * DumpRenderTree/chromium/LayoutTestController.h:
4015         (LayoutTestController::taskList): Added to use MethodTask<T>.
4016         (LayoutTestController::WorkQueue::taskList): Added to use MethodTask<T>.
4017         * DumpRenderTree/chromium/NotificationPresenter.cpp:
4018         (deferredDisplayDispatch):
4019         (NotificationPresenter::show):
4020         * DumpRenderTree/chromium/Task.cpp: Added.
4021         * DumpRenderTree/chromium/Task.h: Added.
4022
4023 2010-09-02  Steve Block  <steveblock@google.com>
4024
4025         Reviewed by Adam Barth.
4026
4027         Hook up LayoutTestController.setMockDeviceOrientation() on Mac.
4028         https://bugs.webkit.org/show_bug.cgi?id=43181
4029
4030         * DumpRenderTree/mac/DumpRenderTree.mm:
4031         (createWebViewAndOffscreenWindow):
4032         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4033         (LayoutTestController::setMockDeviceOrientation):
4034
4035 2010-08-31  Adam Roben  <aroben@apple.com>
4036
4037         Fix flashiness when resizing the browser window on Windows
4038
4039         Reviewed by Sam Weinig.
4040
4041         * MiniBrowser/win/BrowserWindow.cpp:
4042         (BrowserWindow::wndProc): Override WM_ERASEBKGND so Windows won't
4043         periodically fill the window with white.
4044
4045 2010-09-02  Peter Kasting  <pkasting@google.com>
4046
4047         Reviewed by Dimitri Glazkov.
4048
4049         Implement [continuous]MouseScrollBy() on Chromium, and partly on GTK.
4050         https://bugs.webkit.org/show_bug.cgi?id=45073
4051
4052         * DumpRenderTree/chromium/EventSender.cpp:
4053         (EventSender::EventSender):
4054         (EventSender::mouseScrollBy):
4055         (EventSender::continuousMouseScrollBy):
4056         (EventSender::sendCurrentTouchEvent):
4057         (EventSender::handleMouseWheel):
4058         * DumpRenderTree/chromium/EventSender.h:
4059         * DumpRenderTree/gtk/EventSender.cpp:
4060         (mouseScrollByCallback):
4061         (continuousMouseScrollByCallback):
4062
4063 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
4064
4065         Reviewed by Tony Chang.
4066
4067         Land a patched version of r66542 - change TestRunner to have an
4068         separate cleanup method and fix the ordering of cleanup between
4069         TestRunner and the printing module, and then wrap everything in a
4070         try/finally block to ensure reliable cleanup without needing to
4071         rely on stuff happening in the destructor of the TestRunner.
4072
4073         Also refactor run_webkit_tests.run() to be much smaller and cleaner
4074         by creating a bunch of helper methods and moving more stuff into
4075         the TestRunner class.
4076
4077         This fixes the crash at the end of the linux test run of
4078         new-run-webkit-tests (and undoes the rollout in 66547).
4079
4080         https://bugs.webkit.org/show_bug.cgi?id=44902
4081
4082         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Added.
4083         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Added.
4084         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Added.
4085         * Scripts/webkitpy/layout_tests/data/passes/error.html: Added.
4086         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
4087         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
4088         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
4089         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
4090         * Scripts/webkitpy/layout_tests/port/base.py:
4091         * Scripts/webkitpy/layout_tests/port/test.py:
4092         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4093         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4094
4095 2010-09-01  Mark Rowe  <mrowe@apple.com>
4096
4097         Reviewed by Adam Roben.
4098
4099         Fix TestNetscapePlugIn to compile without access to QuickDraw private headers.
4100
4101         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4102
4103 2010-09-01  Brian Weinstein  <bweinstein@apple.com>
4104
4105         Reviewed by Adam Roben.
4106
4107         Have kill-old-processes kill debug and release variants of WebKit2WebWebProcess
4108         and WebKitTestRunner.
4109
4110         * BuildSlaveSupport/win/kill-old-processes:
4111
4112 2010-09-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
4113
4114         Reviewed by Antonio Gomes.
4115
4116         [Qt] Remove obsolete include path from DumpRenderTree.pro
4117
4118         * DumpRenderTree/qt/DumpRenderTree.pro:
4119
4120 2010-09-01  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
4121
4122         Reviewed by Laszlo Gombos.
4123
4124         [Qt] QWebPage::allowGeolocationRequest should be async API
4125         https://bugs.webkit.org/show_bug.cgi?id=41364
4126
4127         Implements new async API for geolocation permission similar to
4128         Notification. WebPage maintains list of geolocation permission request
4129         QtWebkit and set's when LayoutTestController gets the access from test JS
4130
4131         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4132         (WebCore::WebPage::WebPage):
4133         (WebCore::WebPage::resetSettings):
4134         (WebCore::WebPage::requestPermission):
4135         (WebCore::WebPage::cancelPermission):
4136         (WebCore::WebPage::permissionSet):
4137         (WebCore::DumpRenderTree::DumpRenderTree):
4138         (WebCore::DumpRenderTree::processLine):
4139         (WebCore::DumpRenderTree::geolocationPermissionSet):
4140         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4141         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4142         (LayoutTestController::reset):
4143         (LayoutTestController::setGeolocationPermission):
4144         (LayoutTestController::setGeolocationPermissionCommon):
4145         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4146
4147 2010-09-01  Andras Becsi  <abecsi@webkit.org>
4148
4149         Reviewed by Antti Koivisto.
4150
4151         [Qt] Auto-generate WebKit2 forwarding headers
4152         https://bugs.webkit.org/show_bug.cgi?id=44692
4153
4154         * MiniBrowser/qt/BrowserWindow.h: use source style includes
4155         * MiniBrowser/qt/MiniBrowser.pro: add missing include paths
4156         * Scripts/enumerate-included-framework-headers: Removed.
4157
4158 2010-08-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
4159
4160         Reviewed by Adam Barth.
4161
4162         Allow Ctrl+C inside Bugzilla::fetch_bug_dictionary
4163         https://bugs.webkit.org/show_bug.cgi?id=44789
4164
4165         * Scripts/webkitpy/common/net/bugzilla.py:
4166
4167 2010-08-31  Leandro Pereira  <leandro@profusion.mobi>
4168
4169         Reviewed by Adam Barth.
4170
4171         ews: Add support for EFL-EWS
4172         https://bugs.webkit.org/show_bug.cgi?id=44982
4173
4174         * QueueStatusServer/model/queues.py: Add "efl-ews" to queues list.
4175         * Scripts/webkitpy/common/config/ports.py: Define a EflPort class
4176         and add it to the ports dict.
4177         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Define a
4178         EflEWS class.
4179         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py: Add
4180         a test case for the EFL EWS.
4181
4182 2010-08-31  Alexey Proskuryakov  <ap@apple.com>
4183
4184         Reviewed by Sam Weinig.
4185
4186         https://bugs.webkit.org/show_bug.cgi?id=42195
4187         <rdar://problem/8186761> WebKitTestRunner needs to support layoutTestController.setXSSAuditorEnabled
4188
4189         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
4190         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::setXSSAuditorEnabled):
4191         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
4192         Added setXSSAuditorEnabled, calling through to an WKBundle private method. Calling this method
4193         makes WebProcess use a different value for this preference than UIProcess thinks it uses.
4194
4195         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
4196         Reset xssAuditorEnabled. Even though the value doesn't change, this calls through to WebProcess,
4197         which forgets its override.
4198
4199 2010-08-31  Sam Weinig  <sam@webkit.org>
4200
4201         Reviewed by Gavin Barraclough.
4202
4203         WebKitTestRunner needs layoutTestController.addUserStyleSheet
4204         https://bugs.webkit.org/show_bug.cgi?id=42680
4205
4206         WebKitTestRunner needs layoutTestController.addUserScript
4207         https://bugs.webkit.org/show_bug.cgi?id=42681
4208
4209         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
4210         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4211         (WTR::InjectedBundle::beginTesting):
4212         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
4213         (WTR::LayoutTestController::addUserScript):
4214         (WTR::LayoutTestController::addUserStyleSheet):
4215         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
4216
4217 2010-08-31  Dirk Pranke  <dpranke@chromium.org>
4218
4219         Unreviewed, rolling out r66542.
4220         http://trac.webkit.org/changeset/66542
4221         https://bugs.webkit.org/show_bug.cgi?id=44902
4222
4223         r66542 - the weird logging dependencies in Python stuck again ...
4224
4225         * Scripts/webkitpy/layout_tests/data/failures/expected/exception.html: Removed.
4226         * Scripts/webkitpy/layout_tests/data/failures/expected/keyboard.html: Removed.
4227         * Scripts/webkitpy/layout_tests/data/passes/error-expected.txt: Removed.
4228         * Scripts/webkitpy/layout_tests/data/passes/error.html: Removed.
4229