2009-11-27 Adam Barth <abarth@webkit.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-11-27  Adam Barth  <abarth@webkit.org>
2
3         Unreviewed "build" fix found while writing unit tests.
4
5         * Scripts/modules/commands/download.py:
6
7 2009-11-27  Adam Barth  <abarth@webkit.org>
8
9         Reviewed by Eric Seidel.
10
11         [bzt] Kill WebKitLandingScripts
12         https://bugs.webkit.org/show_bug.cgi?id=31904
13
14         Step 6: Kill the rest.
15
16         * Scripts/modules/buildsteps.py:
17         * Scripts/modules/commands/download.py:
18         * Scripts/modules/commands/queries.py:
19         * Scripts/modules/commands/upload.py:
20         * Scripts/modules/landingsequence.py:
21         * Scripts/modules/scm.py:
22         * Scripts/modules/webkitlandingscripts.py: Removed.
23
24 2009-11-27  Adam Barth  <abarth@webkit.org>
25
26         Reviewed by Eric Seidel.
27
28         [bzt] Unit test upload commands
29         https://bugs.webkit.org/show_bug.cgi?id=31903
30
31         Adds unit tests for all but two of the upload commands.  The two
32         remaining ones are more difficult.  I'll return to them later.  The
33         goal of these tests is just to run the commands.  We can test more
34         detailed behavior later.
35
36         * Scripts/modules/commands/commandtest.py:
37         * Scripts/modules/commands/upload.py:
38         * Scripts/modules/commands/upload_unittest.py:
39         * Scripts/modules/mock.py: Added.
40         * Scripts/modules/mock_bugzillatool.py:
41
42 2009-11-26  Adam Barth  <abarth@webkit.org>
43
44         Reviewed by Eric Seidel.
45
46         [bzt] Kill WebKitLandingScripts
47         https://bugs.webkit.org/show_bug.cgi?id=31904
48
49         Step 5: Kill run_and_throw_if_fail.
50
51         * Scripts/modules/buildsteps.py:
52         * Scripts/modules/processutils.py: Added.
53         * Scripts/modules/webkitlandingscripts.py:
54
55 2009-11-26  Adam Barth  <abarth@webkit.org>
56
57         Reviewed by Eric Seidel.
58
59         [bzt] Kill WebKitLandingScripts
60         https://bugs.webkit.org/show_bug.cgi?id=31904
61
62         Step 4: Kill run_webkit_script.
63
64         * Scripts/modules/buildsteps.py:
65         * Scripts/modules/commands/download.py:
66         * Scripts/modules/webkitlandingscripts.py:
67
68 2009-11-26  Adam Barth  <abarth@webkit.org>
69
70         Reviewed by Eric Seidel.
71
72         [bzt] Kill WebKitLandingScripts
73         https://bugs.webkit.org/show_bug.cgi?id=31904
74
75         Step 3: Kill build_webkit.
76
77         * Scripts/modules/buildsteps.py:
78         * Scripts/modules/landingsequence.py:
79         * Scripts/modules/webkitlandingscripts.py:
80
81 2009-11-26  Adam Barth  <abarth@webkit.org>
82
83         Reviewed by Eric Seidel.
84
85         [bzt] Kill WebKitLandingScripts
86         https://bugs.webkit.org/show_bug.cgi?id=31904
87
88         Step 2: Kill ensure_builders_are_green.
89
90         * Scripts/modules/buildsteps.py:
91         * Scripts/modules/commands/download.py:
92         * Scripts/modules/landingsequence.py:
93         * Scripts/modules/webkitlandingscripts.py:
94
95 2009-11-26  Adam Barth  <abarth@webkit.org>
96
97         Reviewed by Eric Seidel.
98
99         [bzt] Kill WebKitLandingScripts
100         https://bugs.webkit.org/show_bug.cgi?id=31904
101
102         Step 1: Kill prepare_clean_working_directory and run_webkit_tests.
103
104         * Scripts/bugzilla-tool:
105         * Scripts/modules/buildsteps.py: Added.
106         * Scripts/modules/commands/download.py:
107         * Scripts/modules/landingsequence.py:
108         * Scripts/modules/webkitlandingscripts.py:
109
110 2009-11-26  Zoltan Horvath  <zoltan@webkit.org>
111
112         Reviewed by Adam Barth.
113
114         Remove directory prefixes from linux commands
115
116         SCM unittests can cause errors on some systems if we use absolute reference to
117         the commands, so directory prefixes have been removed.
118
119         * Scripts/modules/scm_unittest.py:
120
121 2009-11-21  Holger Hans Peter Freyther  <zecke@selfish.org>
122
123         Reviewed by Kenneth Rohde Christiansen.
124
125         Link DumpRenderTree to the Qt Ui Tools
126         https://bugs.webkit.org/show_bug.cgi?id=31203
127
128         Implement QWebPage::createPlugin using the Qt Ui Tools
129         to be able to create classes like QProgressBar from within
130         the <object></object> tags This is required for the
131         new automatic test of Qt Plugins.
132
133         * DumpRenderTree/qt/DumpRenderTree.cpp:
134         (WebCore::WebPage::createPlugin):
135         * DumpRenderTree/qt/DumpRenderTree.h:
136         * DumpRenderTree/qt/DumpRenderTree.pro:
137
138 2009-11-25  Yuzo Fujishima  <yuzo@google.com>
139
140         Reviewed by Eric Seidel.
141
142         Update pywebsocket to 0.4.2
143
144         Update pywebsocket to 0.4.2
145         https://bugs.webkit.org/show_bug.cgi?id=31861
146
147         * pywebsocket/example/echo_client.py:
148         * pywebsocket/example/echo_wsh.py:
149         * pywebsocket/mod_pywebsocket/__init__.py:
150         * pywebsocket/mod_pywebsocket/dispatch.py:
151         * pywebsocket/mod_pywebsocket/msgutil.py:
152         * pywebsocket/mod_pywebsocket/standalone.py:
153         * pywebsocket/setup.py:
154         * pywebsocket/test/test_dispatch.py:
155         * pywebsocket/test/test_msgutil.py:
156
157 2009-11-25  Adam Barth  <abarth@webkit.org>
158
159         Reviewed by Eric Seidel.
160
161         Add unit test for mark-fixed
162         https://bugs.webkit.org/show_bug.cgi?id=31896
163
164         * Scripts/modules/commands/commandtest.py: Added.
165         * Scripts/modules/commands/queries_unittest.py:
166         * Scripts/modules/commands/upload_unittest.py: Added.
167         * Scripts/modules/mock_bugzillatool.py:
168         * Scripts/run-webkit-unittests:
169
170 2009-11-25  Adam Barth  <abarth@webkit.org>
171
172         Reviewed by Eric Seidel.
173
174         bugzilla-tool should have a mark-fixed command
175         https://bugs.webkit.org/show_bug.cgi?id=31853
176
177         Pretty simple stuff.
178
179         * Scripts/modules/commands/upload.py:
180
181 2009-11-25  Eric Seidel  <eric@webkit.org>
182
183         Reviewed by Adam Barth.
184
185         'bugzilla-tool help' should only show common commands like how 'git help' does
186         https://bugs.webkit.org/show_bug.cgi?id=31772
187
188         I also took this opportunity to make 'help' a real Command.
189         Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).
190
191         * Scripts/bugzilla-tool:
192          - change should_show_command_help to should_show_in_main_help
193         * Scripts/modules/commands/download.py:
194          - Mark commands as being shown in main help or not.
195          - show_in_main_help = False is not required (default is false),
196            but it seemed to make the commands more self-documenting.
197         * Scripts/modules/commands/queries.py: ditto
198         * Scripts/modules/commands/queues.py: ditto
199         * Scripts/modules/commands/upload.py: ditto
200         * Scripts/modules/multicommandtool.py:
201          - Make Command hold a pointer to tool in self.tool.  Most Command
202            subclasses do not take advantage of this yet, but it was required
203            for HelpCommand to be able to reach the tool from _help_epilog().
204          - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
205          - Move MultiCommandTool._help_epilog to Command._help_epilog
206          - Move "help" logic into HelpCommand.execute()
207          - Change should_show_command_help to should_show_in_main_help and add a default implementation.
208         * Scripts/modules/multicommandtool_unittest.py:
209          - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'
210
211 2009-11-25  Brian Weinstein  <bweinstein@apple.com>
212
213         Reviewed by Dan Bernstein.
214         
215         Patch by Mark Rowe.
216
217         The buildbots are failing on Windows because when they were upgraded
218         to 4.0.4, Apple Application Support was not in their path. Add it to
219         the path to fix the buildots.
220
221         * Scripts/webkitdirs.pm:
222
223 2009-11-25  Csaba Osztrogonác  <ossy@webkit.org>
224
225         Reviewed by David Kilzer.
226
227         run-webkit-tests doesn't accept directories/files with --skipped=only parameter
228         https://bugs.webkit.org/show_bug.cgi?id=31799
229
230         * Scripts/run-webkit-tests: Fixed.
231
232 2009-11-25  Zoltan Horvath  <zoltan@webkit.org>
233
234         Reviewed by Eric Seidel.
235
236         Change run_command to give back stderr by default
237         https://bugs.webkit.org/show_bug.cgi?id=31734
238
239         Change run_command to give back stderr by default.
240         Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
241         Change the related unittest call.
242
243         * Scripts/modules/scm.py:
244         * Scripts/modules/scm_unittest.py:
245
246 2009-11-25  Eric Seidel  <eric@webkit.org>
247
248         Reviewed by Adam Barth.
249
250         Centralize required argument parsing in Command
251         https://bugs.webkit.org/show_bug.cgi?id=31872
252
253         * Scripts/modules/commands/download.py: remove custom required arg message.
254         * Scripts/modules/commands/upload.py: ditto.
255         * Scripts/modules/multicommandtool.py:
256          - Add _parse_required_arguments.
257          - Pass program name off to OptionParser.
258          - Add name() for access to tool name.
259          - Add check_arguments_and_execute and make it return a return code.
260          - Replace a couple uses of + with %.
261         * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
262
263 2009-11-25  Eric Seidel  <eric@webkit.org>
264
265         Reviewed by Adam Barth.
266
267         Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
268         https://bugs.webkit.org/show_bug.cgi?id=31870
269
270         * Scripts/modules/commands/queries_unittest.py: Use the new class.
271         * Scripts/modules/multicommandtool_unittest.py: Ditto.
272         * Scripts/modules/outputcapture.py: Added.
273
274 2009-11-24  Dmitry Titov  <dimich@chromium.org>
275
276         Reviewed by Eric Seidel.
277
278         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
279         https://bugs.webkit.org/show_bug.cgi?id=31444
280
281         * Scripts/build-webkit:
282
283 2009-11-24  Chris Marrin  <cmarrin@apple.com>
284
285         Reviewed by Simon Fraser.
286
287         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
288         https://bugs.webkit.org/show_bug.cgi?id=27314
289         
290         Now the script allows the directories with these tests to be included on all
291         platforms but Mac, where they behave the same as always. For all other platforms
292         the tests need to be excluded using the Skipped files, which is currently done
293         for all platforms (including win since we're not turned on yet)
294
295         * Scripts/webkitdirs.pm:
296
297 2009-11-24  Eric Seidel  <eric@webkit.org>
298
299         Reviewed by Adam Barth.
300
301         queries_unittest.py should test command output
302         https://bugs.webkit.org/show_bug.cgi?id=31845
303
304         * Scripts/modules/commands/queries_unittest.py:
305          - Capture stdout and stderr and compare with expected strings.
306
307 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
308
309         No Review.
310
311         Fix spelling error ("depenedencies").
312
313         * Scripts/build-webkit:
314
315 2009-11-24  Mark Rowe  <mrowe@apple.com>
316
317         Land the configuration that includes the two debug GTK Linux builders.
318
319         * BuildSlaveSupport/build.webkit.org-config/config.json:
320
321 2009-11-24  David Kilzer  <ddkilzer@apple.com>
322
323         <http://webkit.org/b/31840> bisect-builds broke after r50080
324
325         Reviewed by Dan Bernstein.
326
327         * Scripts/bisect-builds:
328         (mountAndRunNightly): Switched back to using backticks to run
329         the hdiutil command since exec() will terminate the existing
330         script, which is not what we want.  Store the output of
331         File::Spec->devnull() in a variable for use in the hdiutil
332         detach commands.
333
334 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
335
336         Reviewed by Kenneth Rohde Christiansen.
337
338         Include "config.h" to meet Coding Style Guidelines
339         https://bugs.webkit.org/show_bug.cgi?id=31792
340
341         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
342         * DumpRenderTree/qt/jsobjects.cpp:
343         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
344
345 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
346
347         Reviewed by Oliver Hunt.
348
349         Implement new required function to pass test we used to pass. This
350         change is required since r51294.
351
352         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
353         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
354
355 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
356
357         Reviewed by Kenneth Rohde Christiansen.
358
359         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
360         https://bugs.webkit.org/show_bug.cgi?id=31775
361
362         LayoutTestController::dumpBackForwardList() should work with local URLs
363         as well as with normal URLs (in http tests for instance).
364         Currently it does not output the latter properly.
365
366         Unskip a bunch of passing http/navigation tests.
367
368         * DumpRenderTree/qt/DumpRenderTree.cpp:
369         (WebCore::dumpHistoryItem):
370
371 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
372
373         Reviewed by Oliver Hunt.
374
375         ARIA: support aria-flowto
376         https://bugs.webkit.org/show_bug.cgi?id=31762
377
378         * DumpRenderTree/AccessibilityUIElement.cpp:
379         (ariaFlowToElementAtIndexCallback):
380         (AccessibilityUIElement::getJSClass):
381         * DumpRenderTree/AccessibilityUIElement.h:
382         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
383         (AccessibilityUIElement::ariaFlowToElementAtIndex):
384         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
385         (AccessibilityUIElement::ariaFlowToElementAtIndex):
386         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
387         (AccessibilityUIElement::ariaFlowToElementAtIndex):
388
389 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
390
391         Reviewed by Kenneth Christiansen.
392
393         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
394         https://bugs.webkit.org/show_bug.cgi?id=31638
395
396         Unfreeze WorkQueue after each test execution.
397
398         * DumpRenderTree/qt/DumpRenderTree.cpp:
399         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
400
401 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
402
403         Reviewed by Adam Barth.
404
405         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
406         for localhost and 127.0.0.1.
407         https://bugs.webkit.org/show_bug.cgi?id=31783
408
409         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
410
411         * DumpRenderTree/qt/DumpRenderTree.cpp:
412         (WebCore::NetworkAccessManager::NetworkAccessManager):
413         (WebCore::NetworkAccessManager::sslErrorsEncountered):
414         (WebCore::WebPage::WebPage):
415         * DumpRenderTree/qt/DumpRenderTree.h:
416
417 2009-11-22  Chris Evans  <cevans@chromium.org>
418
419         Reviewed by Adam Barth.
420
421         Disable access to file:/// directory listings
422         https://bugs.webkit.org/show_bug.cgi?id=31329
423
424         Implemented setAllowUniversalAccessFromFileURLs to support testing of
425         file URL security.
426
427         * DumpRenderTree/LayoutTestController.cpp:
428         (setAllowUniversalAccessFromFileURLsCallback):
429         (LayoutTestController::staticFunctions):
430         * DumpRenderTree/LayoutTestController.h:
431         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
432         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
433         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
434         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
435         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
436         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
437         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
438         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
439
440 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
441
442         Reviewed by Kenneth Rohde Christiansen.
443
444         [Qt] Fix the timeout of fast/frames/frame-navigation.html
445         https://bugs.webkit.org/show_bug.cgi?id=31638
446
447         The test is timeouting, because it uses the WorkQueue to load a document in one
448         of the child frames and once the loading is finished, the DRT does not dump the
449         tree. This is because it waits for the QWebFrame::loadFinished() signal from
450         the main frame, while it should connect to QWebPage::loadFinished().
451
452         * DumpRenderTree/qt/DumpRenderTree.cpp:
453         (WebCore::DumpRenderTree::DumpRenderTree):
454
455 2009-11-21  Eric Seidel  <eric@webkit.org>
456
457         Reviewed by Adam Barth.
458
459         bugzilla-tool --help spews way too much text
460         https://bugs.webkit.org/show_bug.cgi?id=31771
461
462         * Scripts/bugzilla-tool:
463          - Remove self.cached_scm initialization hack.
464         * Scripts/modules/buildbot.py:
465          - Make default_host accessible to callers.
466         * Scripts/modules/commands/download.py:
467          - Phrase help for all commands consistently and remove spurious help text punctuation.
468         * Scripts/modules/commands/queries.py: Ditto.
469         * Scripts/modules/commands/queues.py: Ditto.
470         * Scripts/modules/commands/upload.py: Ditto.
471         * Scripts/modules/multicommandtool.py:
472          - Add HelpPrintingOptionParser.format_epilog to replace
473            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
474            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
475          - Make --help only show a list of commands like "svn help" and "git help" do --
476            previously --help was listing all commands and options.
477          - Sort list of commands alphabetically.
478
479 2009-11-21  Eric Seidel  <eric@webkit.org>
480
481         No review.  Fixing a typo from the previous patch for bug 31767.
482
483         AbstractQueue.run_bugzilla_tool throws an exception
484         https://bugs.webkit.org/show_bug.cgi?id=31769
485
486         * Scripts/modules/commands/queues.py:
487
488 2009-11-21  Eric Seidel  <eric@webkit.org>
489
490         Reviewed by Adam Barth.
491
492         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
493         https://bugs.webkit.org/show_bug.cgi?id=31767
494
495         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
496         Since we don't have a good way to test BugzillaTool pieces, I've
497         left out a test for now.
498
499         * Scripts/bugzilla-tool:
500          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
501         * Scripts/modules/commands/queues.py:
502          - Use tool.path() instead of __file__.
503         * Scripts/modules/multicommandtool.py:
504          - Add a new path() method to MultiComandTool.
505         * Scripts/modules/multicommandtool_unittest.py:
506          - Provide a path() method.  Little point in testing this mock implementation.
507
508 2009-11-21  Adam Barth  <abarth@webkit.org>
509
510         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
511         WebKitTools.
512
513         * Scripts/modules/commands/download.py:
514
515 2009-11-21  Adam Barth  <abarth@webkit.org>
516
517         Reviewed by Eric Seidel.
518
519         Convert check-style to use LandingSequence
520         https://bugs.webkit.org/show_bug.cgi?id=31763
521
522         Instead of manipulating the working copy by hand, we should use the
523         LandingSequence in CheckStyle.  This will make this code eaiser to
524         test.
525
526         * Scripts/modules/commands/download.py:
527
528 2009-11-20  Adam Barth  <abarth@webkit.org>
529
530         Reviewed by Eric Seidel.
531
532         Unit test query commands
533         https://bugs.webkit.org/show_bug.cgi?id=31755
534
535         These tests are pretty rough, but hopefully they'll grow.
536
537         * Scripts/modules/commands/queries_unittest.py: Added.
538         * Scripts/modules/mock_bugzillatool.py: Added.
539         * Scripts/run-webkit-unittests:
540
541 2009-11-20  Eric Seidel  <eric@webkit.org>
542
543         Reviewed by Adam Barth.
544
545         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
546         https://bugs.webkit.org/show_bug.cgi?id=31758
547
548         * Scripts/modules/multicommandtool.py:
549          - Allow passing of explicit commands to MultiCommandTool.__init__
550         * Scripts/modules/multicommandtool_unittest.py:
551          - Use new Command.name naming system.
552          - Test Command auto-discovery.
553         * Scripts/modules/workqueue.py:
554          - bug_id no longer exists, use patch['bug_id'] instead.
555         * Scripts/modules/workqueue_unittest.py:
556          - WorkQueues require names now.
557          - should_proceed_with_work_item must return a patch object.
558
559 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
560
561         Reviewed by Beth Dakin.
562
563         WAI-ARIA: add support for aria-owns
564         https://bugs.webkit.org/show_bug.cgi?id=31702
565
566         * DumpRenderTree/AccessibilityUIElement.cpp:
567         (ariaOwnsElementAtIndexCallback):
568         (AccessibilityUIElement::getJSClass):
569         * DumpRenderTree/AccessibilityUIElement.h:
570         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
571         (AccessibilityUIElement::ariaOwnsElementAtIndex):
572         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
573         (AccessibilityUIElement::ariaOwnsElementAtIndex):
574         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
575         (AccessibilityUIElement::ariaOwnsElementAtIndex):
576
577 2009-11-20  Eric Seidel  <eric@webkit.org>
578
579         Reviewed by Adam Barth.
580
581         Fix exception thrown when running the commit-queue.
582
583         * Scripts/modules/statusbot.py: patch is optional.
584         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
585
586 2009-11-20  Eric Seidel  <eric@webkit.org>
587
588         Reviewed by Adam Barth.
589
590         Teach the StatusBot how to support more than just the commit-queue
591         https://bugs.webkit.org/show_bug.cgi?id=31754
592
593         * Scripts/modules/workqueue.py: Another typo.
594
595 2009-11-20  Eric Seidel  <eric@webkit.org>
596
597         Reviewed by Adam Barth.
598
599         Teach the StatusBot how to support more than just the commit-queue
600         https://bugs.webkit.org/show_bug.cgi?id=31754
601
602         * Scripts/modules/commands/queues.py: Fix silly typo.
603
604 2009-11-20  Eric Seidel  <eric@webkit.org>
605
606         Reviewed by Adam Barth.
607
608         Teach the StatusBot how to support more than just the commit-queue
609         https://bugs.webkit.org/show_bug.cgi?id=31754
610
611         * CommitQueueStatus/index.yaml:
612          - Add indices required for the new queries.
613         * CommitQueueStatus/queue_status.py:
614          - Add a patch-status page and move update_status to update-status.
615          - Only display "commit-queue" status records for the commit-queue.
616          - Add support for a queue_name property on status records.
617          - Fix _int_from_request to actually work.
618         * CommitQueueStatus/update_status.html:
619          - Add support for a queue_name on status records.
620          - Remove unused list of bug ids.
621          * Scripts/modules/commands/queues.py
622           - Make the queues pass the patch instead of the bug_id to StatusBot.
623         * Scripts/modules/statusbot.py:
624          - Support passing the queue_name to the status updates.
625          - Support fetching patch status with patch_status().
626         * Scripts/modules/workqueue.py:
627          - Pass the patch to the StatusBot instead of the bug_id.
628          - Let WorkQueues have a name.
629
630 2009-11-20  Adam Barth  <abarth@webkit.org>
631
632         Reviewed by Eric Seidel.
633
634         Move bugzilla-tool commands into their own file
635         https://bugs.webkit.org/show_bug.cgi?id=31752
636
637         This will let us write unit tests.
638
639         * Scripts/bugzilla-tool:
640         * Scripts/modules/commands/__init__.py: Added.
641         * Scripts/modules/commands/download.py: Added.
642         * Scripts/modules/commands/queries.py: Added.
643         * Scripts/modules/commands/queues.py: Added.
644         * Scripts/modules/commands/upload.py: Added.
645         * Scripts/modules/grammar.py: Added.
646
647 2009-11-20  Adam Barth  <abarth@webkit.org>
648
649         Reviewed by Eric Seidel.
650
651         BuildQueue should check if the tree is currently buildable
652         https://bugs.webkit.org/show_bug.cgi?id=31744
653
654         * Scripts/bugzilla-tool:
655         * Scripts/modules/landingsequence.py:
656         * Scripts/modules/webkitlandingscripts.py:
657
658 2009-11-20  Adam Barth  <abarth@webkit.org>
659
660         Reviewed by Eric Seidel.
661
662         Move prepare_clean_working_directory into the LandingSequence
663         https://bugs.webkit.org/show_bug.cgi?id=31743
664
665         * Scripts/bugzilla-tool:
666         * Scripts/modules/landingsequence.py:
667
668 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
669
670         Reviewed by Kenneth Rohde Christiansen.
671
672         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
673         https://bugs.webkit.org/show_bug.cgi?id=30460
674
675         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
676
677         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
678         (pluginInvoke):
679
680 2009-11-20  Adam Barth  <abarth@webkit.org>
681
682         Reviewed by Eric Seidel.
683
684         Pass the port information to the child process
685         https://bugs.webkit.org/show_bug.cgi?id=31736
686
687         We need to do this so the child process knows what to build!
688
689         * Scripts/bugzilla-tool:
690         * Scripts/modules/landingsequence.py:
691         * Scripts/modules/webkitport.py:
692         * Scripts/modules/webkitport_unittest.py:
693
694 2009-11-20  Adam Barth  <abarth@webkit.org>
695
696         Reviewed by Eric Seidel.
697
698         Support Qt port in build-queue
699         https://bugs.webkit.org/show_bug.cgi?id=31733
700
701         * Scripts/bugzilla-tool:
702
703 2009-11-20  Adam Barth  <abarth@webkit.org>
704
705         Reviewed by Eric Seidel.
706
707         Implement a build-queue
708         https://bugs.webkit.org/show_bug.cgi?id=31725
709
710         Currently this just builds the first 10 patches in the review queue.
711         We'll want to do something smarter soon.
712
713         * Scripts/bugzilla-tool:
714
715 2009-11-20  Adam Barth  <abarth@webkit.org>
716
717         Reviewed by Eric Seidel.
718
719         Make commit-queue and style-queue show up in help
720         https://bugs.webkit.org/show_bug.cgi?id=31724
721
722         We need to store their names on their class to make these commands
723         properly register themselves with MultiCommandTool.
724
725         * Scripts/bugzilla-tool:
726
727 2009-11-20  Adam Barth  <abarth@webkit.org>
728
729         Reviewed by Eric Seidel.
730
731         Implement bugzilla-tool build-attachment
732         https://bugs.webkit.org/show_bug.cgi?id=31722
733
734         This command builds an attachment from bugzilla.  It leaves the built
735         patch in the working copy.
736
737         * Scripts/bugzilla-tool:
738         * Scripts/modules/landingsequence.py:
739         * Scripts/modules/webkitlandingscripts.py:
740
741 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
742
743         Reviewed by Xan Lopez.
744
745         [GTK] DRT release event does not create the state correctly
746         https://bugs.webkit.org/show_bug.cgi?id=31717
747
748         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
749
750 2009-11-20  Eric Seidel  <eric@webkit.org>
751
752         Reviewed by Adam Barth.
753
754         MultiCommandTool should find Command objects automatically instead of with a manual list
755         https://bugs.webkit.org/show_bug.cgi?id=31710
756
757         * Scripts/bugzilla-tool:
758         * Scripts/modules/multicommandtool.py:
759          - Use some wild python-fu to crawl all the known subclasses of Command.
760
761 2009-11-20  Adam Barth  <abarth@webkit.org>
762
763         Unreviewed "build" fix.  Added missing import.
764
765         * Scripts/bugzilla-tool:
766
767 2009-11-20  Adam Barth  <abarth@webkit.org>
768
769         Unreviewed "build" fix.  I failed to update LandingSequence.test
770         properly.
771
772         * Scripts/modules/landingsequence.py:
773
774 2009-11-20  Adam Barth  <abarth@webkit.org>
775
776         Reviewed by Eric Seidel.
777
778         Create LandingSequence as the all-sing, all-dance landing class
779         https://bugs.webkit.org/show_bug.cgi?id=31709
780
781         Client can inherit from this class to carefully control exactly which
782         steps they wish to have happen in the landing sequence.
783
784         * Scripts/bugzilla-tool:
785         * Scripts/modules/landingsequence.py: Added.
786         * Scripts/modules/webkitlandingscripts.py: Added.
787
788 2009-11-19  Adam Barth  <abarth@webkit.org>
789
790         Reviewed by Eric Seidel.
791
792         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
793         https://bugs.webkit.org/show_bug.cgi?id=31707
794
795         This is to help when we implement build-attachment.
796
797         * Scripts/bugzilla-tool:
798
799 2009-11-19  Adam Barth  <abarth@webkit.org>
800
801         Reviewed by Eric Seidel.
802
803         Support Qt port in bugzilla-tool
804         https://bugs.webkit.org/show_bug.cgi?id=31701
805
806         Now we support building with Qt!
807
808         * Scripts/bugzilla-tool:
809         * Scripts/modules/webkitport.py: Added.
810         * Scripts/modules/webkitport_unittest.py: Added.
811         * Scripts/run-webkit-unittests:
812
813 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
814
815         Reviewed by Adam Barth.
816
817         Remove inserting stderr into patch in bugzilla-tool
818         https://bugs.webkit.org/show_bug.cgi?id=29914
819
820         Modify SCM python module's run_command function to avoid return of stderr
821         by default, so stderr won't be inserted into the patches.
822         Modify the related unit test.
823
824         * Scripts/modules/scm.py:
825         * Scripts/modules/scm_unittest.py:
826
827 2009-11-19  Eric Seidel  <eric@webkit.org>
828
829         Reviewed by Adam Barth.
830
831         bugzilla-tool needs per-command help
832         https://bugs.webkit.org/show_bug.cgi?id=31697
833
834         Added support for "bugzilla-tool help command-name"
835         and a unit test to make sure it works.
836
837         * Scripts/modules/multicommandtool.py:
838         * Scripts/modules/multicommandtool_unittest.py:
839
840 2009-11-19  Eric Seidel  <eric@webkit.org>
841
842         Reviewed by Adam Barth.
843
844         Move MultiCommandTool and Command into a separate file and add some basic unit tests
845         https://bugs.webkit.org/show_bug.cgi?id=31695
846
847         * Scripts/bugzilla-tool:
848         * Scripts/modules/multicommandtool.py: Added.
849         * Scripts/modules/multicommandtool_unittest.py: Added.
850         * Scripts/run-webkit-unittests:
851
852 2009-11-19  Eric Seidel  <eric@webkit.org>
853
854         No review, just adding a FIXME.
855
856         Split out command parsing and help printing from BugzillaTool
857         https://bugs.webkit.org/show_bug.cgi?id=31688
858
859         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
860
861 2009-11-19  Eric Seidel  <eric@webkit.org>
862
863         Reviewed by Adam Barth.
864
865         Split out command parsing and help printing from BugzillaTool
866         https://bugs.webkit.org/show_bug.cgi?id=31688
867
868         * Scripts/bugzilla-tool:
869          - Add new MultiCommandTool class to contain option parsing and help printing logic.
870          - Rename private methods to use _ pattern.
871          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
872          - 
873
874 2009-11-19  Eric Seidel  <eric@webkit.org>
875
876         Reviewed by Adam Barth.
877
878         Re-factor help printing to use modern python idioms
879         https://bugs.webkit.org/show_bug.cgi?id=31685
880
881         * Scripts/bugzilla-tool:
882
883 2009-11-19  Eric Seidel  <eric@webkit.org>
884
885         Reviewed by Darin Adler.
886
887         commit-queue empty queue logs twice
888         https://bugs.webkit.org/show_bug.cgi?id=31679
889
890         * Scripts/bugzilla-tool:
891
892 2009-11-19  Eric Seidel  <eric@webkit.org>
893
894         Reviewed by Darin Adler.
895
896         bugzilla-tool's reviewer/committer rejection message should be clearer
897         https://bugs.webkit.org/show_bug.cgi?id=31126
898
899         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
900
901         * Scripts/modules/bugzilla.py:
902
903 2009-11-19  Eric Z. Ayers  <zundel@google.com>
904
905         Reviewed by Pavel Feldman.
906
907         Forces a WM_PAINT event on calling layoutTestController.display()
908         in order to enable the timeline-paint.html test on Windows.
909         ::UpdateWindow() does not force an event becaue the window is 
910         not visible.
911
912         https://bugs.webkit.org/show_bug.cgi?id=31402
913
914         * DumpRenderTree/win/DumpRenderTree.cpp:
915         (displayWebView):
916
917 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
918
919         No review needed.
920
921         Added myself to committers list.
922
923         * Scripts/modules/committers.py:
924
925 2009-11-19  Adam Barth  <abarth@webkit.org>
926
927         Reviewed by Eric Seidel.
928
929         Bugzilla-tool command classes should match command names
930         https://bugs.webkit.org/show_bug.cgi?id=31666
931
932         I renamed all the commands except CommitMessageForCurrentDiff because
933         the new name would conflict with an existing class.
934
935         * Scripts/bugzilla-tool:
936
937 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
938
939         Reviewed by Gustavo Noronha Silva.
940
941         Web Inspector: Implement "show inspector" in WebKit GTK
942         API and enable console tests.
943
944         https://bugs.webkit.org/show_bug.cgi?id=31669
945
946         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
947         (LayoutTestController::showWebInspector):
948
949 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
950
951         Reviewed by Simon Hausmann.
952
953         Minor refactoring + more documentation.
954
955         * DumpRenderTree/qt/DumpRenderTree.cpp:
956         (WebCore::clearHistory):
957         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
958
959 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
960
961         Reviewed by Eric Seidel.
962
963         Ignore websocket tests when --no-http is specified.
964         https://bugs.webkit.org/show_bug.cgi?id=31662
965
966         * Scripts/run-webkit-tests:
967
968 2009-11-18  Adam Barth  <abarth@webkit.org>
969
970         Reviewed by Eric Seidel.
971
972         Normalize ' and " in bugzilla-tool
973         https://bugs.webkit.org/show_bug.cgi?id=31655
974
975         We decided " is better than ' and we should be consistent.
976
977         * Scripts/bugzilla-tool:
978
979 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
980
981         Reviewed by Kenneth Rohde Christiansen.
982
983         [Qt] Remove support for Qt v4.3 or older versions
984         https://bugs.webkit.org/show_bug.cgi?id=29469
985
986         * DumpRenderTree/qt/DumpRenderTree.pro:
987         * DumpRenderTree/qt/ImageDiff.pro:
988
989 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
990
991         Reviewed by Eric Seidel.
992
993         GitTest.test_create_binary_patch fails if /tmp is symlink
994         https://bugs.webkit.org/show_bug.cgi?id=31536
995
996         * Scripts/modules/scm_unittest.py:
997
998 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
999
1000         Reviewed by Darin Adler.
1001
1002         Configuration for Chromium Build Slaves.
1003
1004         https://bugs.webkit.org/show_bug.cgi?id=31442
1005
1006         * BuildSlaveSupport/build.webkit.org-config/config.json:
1007         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1008
1009 2009-11-18  Eric Seidel  <eric@webkit.org>
1010
1011         Reviewed by Darin Adler.
1012
1013         workqueue.py results in totally broken commit-queue UI
1014         https://bugs.webkit.org/show_bug.cgi?id=31645
1015
1016         * Scripts/bugzilla-tool:
1017          - Remove unneeded use of PatchCollection.
1018          - Grab a new copy of the cq'd patches every run of the queue.
1019
1020 2009-11-18  Sam Weinig  <sam@webkit.org>
1021
1022         Reviewed by Anders Carlsson.
1023
1024         Make the Mac Geolocation API async.
1025
1026         Update DRT to use the new async Mac Geolocation API.
1027
1028         * DumpRenderTree/mac/UIDelegate.mm:
1029         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
1030
1031 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1032
1033         Reviewed by Kenneth Rohde Christiansen.
1034
1035         Add and option to toggle HTML5 datalist support to build-webkit
1036         https://bugs.webkit.org/show_bug.cgi?id=31599
1037
1038         * Scripts/build-webkit:
1039
1040 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
1041
1042         Reviewed by Kevin Ollivier.
1043
1044         Enable wx plugin support using the Windows implementation as a base.
1045         
1046         https://bugs.webkit.org/show_bug.cgi?id=31636
1047
1048         * wx/build/settings.py:
1049
1050 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1051
1052         Reviewed by Simon Hausmann.
1053
1054         Change the initialization order so that the controllers
1055         will be created before exporting them to the JS DOM window.
1056
1057         * DumpRenderTree/qt/DumpRenderTree.cpp:
1058         (WebCore::DumpRenderTree::DumpRenderTree):
1059
1060 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1061
1062         Reviewed by Simon Hausmann.
1063
1064         Fix a code copy and paste error. m_page should be page.
1065
1066         * DumpRenderTree/qt/DumpRenderTree.cpp:
1067         (WebCore::DumpRenderTree::createWindow):
1068
1069 2009-11-17  Mark Rowe  <mrowe@apple.com>
1070
1071         Reviewed by Alexey Proskuryakov.
1072
1073         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
1074
1075         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
1076         This prevents symlinks from confusing the descendant check.
1077
1078 2009-11-17  Mark Rowe  <mrowe@apple.com>
1079
1080         Reviewed by Alexey Proskuryakov.
1081
1082         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
1083
1084         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
1085         server to be up rather than having run-webkit-tests abort immediately.
1086
1087         * Scripts/run-webkit-tests:
1088
1089 2009-11-17  Eric Seidel  <eric@webkit.org>
1090
1091         Reviewed by Darin Adler.
1092
1093         commit-queue is failing to set reviewer in ChangeLogs
1094         https://bugs.webkit.org/show_bug.cgi?id=31592
1095
1096         * Scripts/bugzilla-tool: Clarify the "applying" log message.
1097         * Scripts/modules/bugzilla.py:
1098          - Add a new _validate_committer_and_reviewer function as a
1099            temporary solution until we can make a real Attachment object
1100            which knows how to fill in its committer/reviewer fields automatically.
1101
1102 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1103
1104         Unreviewed buildbot fix.
1105
1106         Revert part of earlier patch and add comment, as it
1107         was causing timeouts on the buildbot.
1108
1109         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1110         (LayoutTestController::notifyDone):
1111
1112 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1113
1114         Reviewed by Oliver Hunt.
1115
1116         Make the timeout 15 sec as for the other DRT's and make
1117         it print out the same output when a test timeout.
1118
1119         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1120         (LayoutTestController::waitUntilDone):
1121         (LayoutTestController::notifyDone):
1122         (LayoutTestController::timerEvent):
1123
1124 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
1125
1126         Reviewed by Timothy Hatcher.
1127
1128         Fixed typos in comments.
1129
1130         * Scripts/modules/committers.py:
1131
1132 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
1133
1134         Reviewed by Timothy Hatcher.
1135
1136         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
1137         - Updated DRT to show/close inspector for all tests under /inspector
1138         - Introduced LayoutTestController::setTimelineProfilingEnabled and
1139           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
1140         - Removed reload on each inspector test
1141         - Renamed fast/inspector to fast/inspector-support in order not to trigger
1142         inspector for those.
1143         - Reimplemented timeline tests in order to get rid of reload there.
1144         - Moved tests that don't require harness into the fast group.
1145
1146         https://bugs.webkit.org/show_bug.cgi?id=31472
1147
1148         * DumpRenderTree/LayoutTestController.cpp:
1149         (setTimelineProfilingEnabledCallback):
1150         (closeWebInspectorCallback):
1151         (LayoutTestController::staticFunctions):
1152         * DumpRenderTree/LayoutTestController.h:
1153         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1154         (shouldOpenWebInspector):
1155         (runTest):
1156         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1157         (LayoutTestController::setTimelineProfilingEnabled):
1158         * DumpRenderTree/mac/DumpRenderTree.mm:
1159         (shouldOpenWebInspector):
1160         (runTest):
1161         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1162         (LayoutTestController::setTimelineProfilingEnabled):
1163         * DumpRenderTree/win/DumpRenderTree.cpp:
1164         (shouldOpenWebInspector):
1165         (runTest):
1166         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1167         (LayoutTestController::setTimelineProfilingEnabled):
1168
1169 2009-11-17  Oliver Hunt  <oliver@apple.com>
1170
1171         Reviewed by Maciej Stachowiak.
1172
1173         Incorrect use of JavaScriptCore API in DumpRenderTree
1174         https://bugs.webkit.org/show_bug.cgi?id=31577
1175
1176         Return undefined rather than a literal null.
1177
1178         * DumpRenderTree/AccessibilityUIElement.cpp:
1179         (setSelectedTextRangeCallback):
1180         (incrementCallback):
1181         (decrementCallback):
1182         (showMenuCallback):
1183
1184 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
1185
1186         Reviewed by Beth Dakin.
1187
1188         AX: aria-labelledby duplicates some of its WAI-ARIA label
1189         https://bugs.webkit.org/show_bug.cgi?id=31565
1190
1191         * DumpRenderTree/AccessibilityUIElement.cpp:
1192         (titleUIElementCallback):
1193         (getIsValidCallback):
1194         (AccessibilityUIElement::getJSClass):
1195
1196 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1197
1198         Reviewed by Simon Hausmann.
1199
1200         r50942 broke output from created windows. Make the
1201         m_enableTextOutput a member of the DRT and not the
1202         WebPage.
1203
1204         * DumpRenderTree/qt/DumpRenderTree.cpp:
1205         (WebCore::WebPage::WebPage):
1206         (WebCore::WebPage::javaScriptAlert):
1207         (WebCore::WebPage::javaScriptConsoleMessage):
1208         (WebCore::WebPage::javaScriptConfirm):
1209         (WebCore::WebPage::javaScriptPrompt):
1210         (WebCore::WebPage::acceptNavigationRequest):
1211         (WebCore::DumpRenderTree::DumpRenderTree):
1212         (WebCore::DumpRenderTree::open):
1213         (WebCore::DumpRenderTree::createWindow):
1214         * DumpRenderTree/qt/DumpRenderTree.h:
1215         (WebCore::DumpRenderTree::setTextOutputEnabled):
1216         (WebCore::DumpRenderTree::isTextOutputEnabled):
1217         (WebCore::WebPage::shouldInterruptJavaScript):
1218         (WebCore::WebPage::isTextOutputEnabled):
1219         (WebCore::WebPage::setViewGeometry):
1220
1221 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1222
1223         Reviewed by Gustavo Noronha Silva.
1224
1225         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
1226         as the implementation is being used by at least Qt and Gtk+.
1227
1228         Update buildsystems as well.
1229
1230         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1231         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
1232         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
1233         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
1234         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1235         * GNUmakefile.am:
1236
1237 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
1238
1239         Reviewed by Alexey Proskuryakov.
1240
1241         Disable wss until all platforms support pyOpenSSL
1242
1243         https://bugs.webkit.org/show_bug.cgi?id=31479
1244
1245         * Scripts/run-webkit-tests:
1246
1247 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
1248
1249         Reviewed by Kenneth Christiansen.
1250
1251         [Qt] Implement load error pages support for Qt's DRT.
1252         https://bugs.webkit.org/show_bug.cgi?id=31509
1253
1254         For now, it will not be a default feature, and layout tests
1255         that want to make use of this have to explicitily call
1256         'handleErrorPages();' for the test source.
1257
1258         Any of the other DumpRenderTree's (mac, win and gtk)
1259         support handling error pages. Qt's will be the first.
1260
1261         * DumpRenderTree/qt/DumpRenderTree.cpp:
1262         (WebCore::WebPage::supportsExtension):
1263         (WebCore::WebPage::extension):
1264         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1265         (LayoutTestController::reset):
1266         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1267         (LayoutTestController::shouldHandleErrorPages):
1268         (LayoutTestController::handleErrorPages):
1269
1270 2009-11-16  Eric Seidel  <eric@webkit.org>
1271
1272         Reviewed by Adam Barth.
1273
1274         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
1275         https://bugs.webkit.org/show_bug.cgi?id=31549
1276
1277         Renamed --commit-queue to --non-interactive in most places
1278         and remove the code in land-patches which is no longer needed.
1279
1280         * Scripts/bugzilla-tool:
1281
1282 2009-11-16  Eric Seidel  <eric@webkit.org>
1283
1284         Reviewed by Adam Barth.
1285
1286         The commit-queue should use land-attachment
1287         https://bugs.webkit.org/show_bug.cgi?id=31548
1288
1289         * Scripts/bugzilla-tool:
1290
1291 2009-11-16  Adam Barth  <abarth@webkit.org>
1292
1293         Reviewed by Eric Seidel.
1294
1295         Convert CommitQueue over to PatchCollection
1296         https://bugs.webkit.org/show_bug.cgi?id=31547
1297
1298         Also fixes a bug in workqueue and adds a test!
1299
1300         * Scripts/bugzilla-tool:
1301         * Scripts/modules/workqueue.py:
1302         * Scripts/modules/workqueue_unittest.py:
1303
1304 2009-11-16  Adam Barth  <abarth@webkit.org>
1305
1306         Reviewed by Eric Seidel.
1307
1308         Move StyleQueue over to using PatchCollection
1309         https://bugs.webkit.org/show_bug.cgi?id=31544
1310
1311         That's what the class it's for.
1312
1313         * Scripts/bugzilla-tool:
1314         * Scripts/modules/patchcollection.py:
1315         * Scripts/modules/patchcollection_unittest.py:
1316
1317 2009-11-16  Eric Seidel  <eric@webkit.org>
1318
1319         Reviewed by Adam Barth.
1320
1321         bugzilla-tool needs a land-attachment command
1322         https://bugs.webkit.org/show_bug.cgi?id=31546
1323
1324         * Scripts/bugzilla-tool:
1325          - Move all the logic into AbstractLandingCommand and
1326            add a new LandAttachment command subclass.
1327          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
1328
1329 2009-11-16  Eric Seidel  <eric@webkit.org>
1330
1331         Reviewed by Adam Barth.
1332
1333         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
1334         https://bugs.webkit.org/show_bug.cgi?id=31543
1335
1336         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
1337
1338         * Scripts/bugzilla-tool:
1339
1340 2009-11-16  Eric Seidel  <eric@webkit.org>
1341
1342         Reviewed by Adam Barth.
1343
1344         Disable the style queue from posting to the commit queue status page.
1345
1346         * Scripts/bugzilla-tool:
1347
1348 2009-11-16  Adam Barth  <abarth@webkit.org>
1349
1350         Reviewed by Eric Seidel.
1351
1352         Implement PatchCollection
1353         https://bugs.webkit.org/show_bug.cgi?id=31541
1354
1355         This class holds a set of patches and lets clients iterate through
1356         them.  Optionally, clients can install a filter.
1357
1358         * Scripts/modules/patchcollection.py: Added.
1359         * Scripts/modules/patchcollection_unittest.py: Added.
1360         * Scripts/run-webkit-unittests:
1361
1362 2009-11-16  Eric Seidel  <eric@webkit.org>
1363
1364         Reviewed by Adam Barth.
1365
1366         bugzilla-tool land-patches will close bugs with patches r=?
1367         https://bugs.webkit.org/show_bug.cgi?id=28230
1368
1369         The commit-queue shouldn't close patches with outstanding reviews on them,
1370         even if many reviewers seem to be against multi-patch bugs.
1371
1372         * Scripts/bugzilla-tool:
1373
1374 2009-11-16  Eric Seidel  <eric@webkit.org>
1375
1376         Reviewed by Adam Barth.
1377
1378         bugzilla-tool check-style should work with attachment ids instead of bug ids
1379         https://bugs.webkit.org/show_bug.cgi?id=31540
1380
1381         * Scripts/bugzilla-tool:
1382
1383 2009-11-16  Eric Seidel  <eric@webkit.org>
1384
1385         Reviewed by Adam Barth.
1386
1387         WorkQueue is the only place that should know about special exit codes
1388         https://bugs.webkit.org/show_bug.cgi?id=31534
1389
1390         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
1391         and add tests for handling exit codes.
1392         I also cleaned up workqueue_unittest.py more.
1393
1394         * Scripts/bugzilla-tool:
1395         * Scripts/modules/workqueue.py:
1396         * Scripts/modules/workqueue_unittest.py:
1397
1398 2009-11-16  Eric Seidel  <eric@webkit.org>
1399
1400         Reviewed by Adam Barth.
1401
1402         Re-factor workqueue_unittest to allow for more than one test.
1403         https://bugs.webkit.org/show_bug.cgi?id=31535
1404
1405         * Scripts/modules/workqueue_unittest.py:
1406
1407 2009-11-16  Eric Seidel  <eric@webkit.org>
1408
1409         Reviewed by Adam Barth.
1410
1411         land-patches needs to be re-factored into smaller chunks
1412         https://bugs.webkit.org/show_bug.cgi?id=31532
1413
1414         * Scripts/bugzilla-tool: fix a couple obvious typos.
1415
1416 2009-11-16  Eric Seidel  <eric@webkit.org>
1417
1418         Reviewed by Adam Barth.
1419
1420         land-patches needs to be re-factored into smaller chunks
1421         https://bugs.webkit.org/show_bug.cgi?id=31532
1422
1423         The next patch will move these methods into WebKitLandingScripts.
1424
1425         * Scripts/bugzilla-tool:
1426          - Split out _land_patch and _close_bug_if_no_active_patches.
1427
1428 2009-11-16  Adam Barth  <abarth@webkit.org>
1429
1430         Reviewed by Eric Seidel.
1431
1432         Fix silly copy-and-paste code.  I am a terrible coder.
1433
1434         * Scripts/modules/bugzilla.py:
1435
1436 2009-11-16  Adam Barth  <abarth@webkit.org>
1437
1438         Reviewed by Eric Seidel.
1439
1440         Implement a StyleQueue
1441         https://bugs.webkit.org/show_bug.cgi?id=31537
1442
1443         The first iteration of the style queue only produces output locally.
1444         There is also a limit of 10 patches because it's not that useful to
1445         iterate through the entire review queue at this point.  We can remove
1446         the limit later.
1447
1448         * Scripts/bugzilla-tool:
1449         * Scripts/modules/bugzilla.py:
1450
1451 2009-11-16  Adam Barth  <abarth@webkit.org>
1452
1453         Reviewed by Eric Seidel.
1454
1455         Unit test WorkQueue
1456         https://bugs.webkit.org/show_bug.cgi?id=31531
1457
1458         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
1459
1460         * Scripts/bugzilla-tool:
1461         * Scripts/modules/statusbot.py:
1462         * Scripts/modules/workqueue.py:
1463         * Scripts/modules/workqueue_unittest.py: Added.
1464         * Scripts/run-webkit-unittests:
1465
1466 2009-11-16  Eric Seidel  <eric@webkit.org>
1467
1468         Reviewed by Adam Barth.
1469
1470         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
1471         https://bugs.webkit.org/show_bug.cgi?id=31530
1472
1473         * Scripts/bugzilla-tool:
1474
1475 2009-11-16  Eric Seidel  <eric@webkit.org>
1476
1477         Reviewed by Adam Barth.
1478
1479         bugzilla-tool needs apply-attachment
1480         https://bugs.webkit.org/show_bug.cgi?id=31528
1481
1482         * Scripts/bugzilla-tool:
1483          - Add ApplyAttachment command.
1484          - Abstract applying code into WebKitApplyingScripts.
1485          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
1486         * Scripts/modules/bugzilla.py:
1487          - Add fetch_attachment and bug_id_for_attachment_id.
1488         * Scripts/modules/bugzilla_unittest.py:
1489          - Add test for new parsing.
1490          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
1491
1492 2009-11-16  Eric Seidel  <eric@webkit.org>
1493
1494         Reviewed by Adam Barth.
1495
1496         Document check-style's use of force_clean.
1497
1498         * Scripts/bugzilla-tool:
1499         * Scripts/modules/scm.py:
1500
1501 2009-11-16  Adam Barth  <abarth@webkit.org>
1502
1503         Reviewed by Eric Seidel.
1504
1505         Move WorkQueue to its own file
1506         https://bugs.webkit.org/show_bug.cgi?id=31529
1507
1508         WorkQueue and WorkQueueDelegate are separate concerns from
1509         bugzilla-tool.  Also added a missing include to logging.py.
1510
1511         * Scripts/bugzilla-tool:
1512         * Scripts/modules/logging.py:
1513         * Scripts/modules/workqueue.py:
1514
1515 2009-11-16  Adam Barth  <abarth@webkit.org>
1516
1517         Reviewed by Eric Seidel.
1518
1519         Move OutputTee to logging.py.
1520
1521         * Scripts/bugzilla-tool:
1522         * Scripts/modules/logging.py:
1523
1524 2009-11-15  Adam Barth  <abarth@webkit.org>
1525
1526         Reviewed by Eric Seidel.
1527
1528         Refactor bugzilla-tool to allow for multiple queues
1529         https://bugs.webkit.org/show_bug.cgi?id=31513
1530
1531         Divide the commit queue class into three class to make creating
1532         additional queues easier.
1533
1534         * Scripts/bugzilla-tool:
1535
1536 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1537
1538         Reviewed by Eric Seidel.
1539
1540         svn-apply may not handle git patches created by bugzilla-tool
1541         https://bugs.webkit.org/show_bug.cgi?id=31457
1542
1543         * Scripts/modules/scm.py:
1544         * Scripts/modules/scm_unittest.py:
1545
1546 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1547
1548         Reviewed by Eric Seidel.
1549
1550         bugzilla-tool should post git binary diff
1551         https://bugs.webkit.org/show_bug.cgi?id=31458
1552
1553         Add --binary option to Git.create_patch.
1554
1555         * Scripts/modules/scm.py:
1556         * Scripts/modules/scm_unittest.py:
1557
1558 2009-11-15  Adam Barth  <abarth@webkit.org>
1559
1560         Reviewed by Darin Adler.
1561
1562         Add bugzilla-tool check-style
1563         https://bugs.webkit.org/show_bug.cgi?id=31515
1564
1565         * Scripts/bugzilla-tool:
1566         * Scripts/modules/bugzilla.py:
1567
1568 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1569
1570         Reviewed by Simon Hausmann.
1571
1572         Make the Qt Linux only --valgrind feature, suppress errors
1573         defined in the SuppressedValgrindErrors file.
1574
1575         * Scripts/run-webkit-tests:
1576
1577 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1578
1579         Reviewed by Simon Hausmann.
1580
1581         Set the locale to C and not to the current one in use on the system.
1582
1583         * DumpRenderTree/qt/DumpRenderTree.cpp:
1584         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1585
1586 2009-11-13  Adam Roben  <aroben@apple.com>
1587
1588         Add support for
1589         http/tests/security/isolatedWorld/didClearWindowObject.html
1590
1591         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
1592         window objects in isolated worlds are cleared
1593
1594         Reviewed by Dave Hyatt.
1595
1596         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
1597
1598         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1599         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1600         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
1601         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
1602         Added. Sets a __worldID property on the global object whose value is
1603         the ID of this world.
1604         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
1605         Respond to this new delegate callback by calling through to one of the
1606         above new methods.
1607         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1608         (worldMap): Added. Returns a HashMap containing all the worlds we've
1609         created.
1610         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
1611         haven't kept track of this world.
1612         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1613         instead of declaring our own.
1614
1615         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
1616
1617         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1618         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
1619         didClearWindowObjectForFrameInStandardWorld.
1620         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
1621         Respond to this new delegate callback by calling through to one of the
1622         below new methods.
1623         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
1624         Added. Sets a __worldID property on the gobal object whose value is
1625         the ID of this world.
1626         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1627         Added. Moved code here from didClearWindowObject.
1628
1629         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
1630         didClearWindowObjectForFrame* functions.
1631
1632         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1633         (worldMap): Added. Returns a HashMap containing all the worlds we've
1634         created.
1635         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
1636         haven't kept track of this world.
1637         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1638         instead of declaring our own.
1639
1640 2009-11-13  Adam Roben  <aroben@apple.com>
1641
1642         Finish replacing worldIDs with world objects
1643
1644         The only remaining use of worldIDs was in a method only used by DRT
1645         for the isolated worlds tests.
1646
1647         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
1648
1649         Reviewed by Mark Rowe.
1650
1651         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1652         (LayoutTestController::evaluateScriptInIsolatedWorld):
1653         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1654         (LayoutTestController::evaluateScriptInIsolatedWorld):
1655         Updated for changes to WebFrame. Now holds the map of worldID -> world
1656         at this level instead of making WebKit do it.
1657
1658 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1659
1660         Reviewed by Simon Hausmann.
1661
1662         [Qt] Ensure the DRT does not output anything until first test is run
1663
1664         * DumpRenderTree/qt/DumpRenderTree.cpp:
1665         * DumpRenderTree/qt/DumpRenderTree.h:
1666
1667 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1668
1669         Reviewed by Tor Arne Vestbø.
1670
1671         Clear the undo stack in before each new test run.
1672
1673         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
1674
1675         * DumpRenderTree/qt/DumpRenderTree.cpp:
1676         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1677
1678 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1679
1680         Reviewed by Kenneth Rohde Christiansen.
1681
1682         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
1683
1684         * DumpRenderTree/qt/DumpRenderTree.cpp:
1685         (WebCore::WebPage::resetSettings):
1686         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1687         (LayoutTestController::overridePreference):
1688
1689 2009-11-13  Eric Seidel  <eric@webkit.org>
1690
1691         Reviewed by Adam Barth.
1692
1693         Update committers.py based on svn records
1694         https://bugs.webkit.org/show_bug.cgi?id=31366
1695
1696         This list was generated using validate-committer-lists from
1697         https://bugs.webkit.org/show_bug.cgi?id=30970
1698         and makes committers.py current for committers who have
1699         committed in the last 3 years.
1700
1701         * Scripts/modules/committers.py:
1702
1703 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
1704
1705         Reviewed by Adam Barth.
1706
1707         The document-open.html test was flaky at times. The test invokes the layout test plugin
1708         which in its destroy stream handler opens a new document. This basically tears down the
1709         stream and the associated plugin instance. The pluginLog function in the layout test
1710         plugin attempts to retrieve the window script object on a torn down plugin instance
1711         which crashed consistently on windows in the debugger. The functions which issue
1712         these logs already have a valid window script object. We now have variants of the pluginLog
1713         function which take in a window script object with and without variable arguments. 
1714
1715         https://bugs.webkit.org/show_bug.cgi?id=31067
1716
1717         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1718         (pluginLogWithWindowObject):
1719         (pluginLogWithWindowObjectVariableArgs):
1720         (pluginLog):
1721         (notifyTestCompletion):
1722         (testDocumentOpen):
1723         (testWindowOpen):
1724
1725 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1726
1727         Reviewed by Gustavo Noronha Silva.
1728
1729         https://bugs.webkit.org/show_bug.cgi?id=30997
1730         [Gtk] Implemment AtkDocument
1731
1732         Added testing support.
1733
1734         * DumpRenderTree/AccessibilityUIElement.cpp:
1735         * DumpRenderTree/AccessibilityUIElement.h:
1736         (getDocumentEncodingCallback):
1737         (getDocumentURICallback):
1738         (AccessibilityUIElement::getJSClass):
1739         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1740         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1741         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1742         (AccessibilityUIElement::documentEncoding):
1743         (AccessibilityUIElement::documentURI):
1744
1745 2009-11-12  Adam Roben  <aroben@apple.com>
1746
1747         Replace worldIDs with world objects
1748
1749         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
1750         user scripts/stylesheets and isolated worlds
1751
1752         Reviewed by Sam Weinig.
1753
1754         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1755         (LayoutTestController::addUserScript):
1756         (LayoutTestController::addUserStyleSheet):
1757         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1758         (LayoutTestController::addUserScript):
1759         (LayoutTestController::addUserStyleSheet):
1760         Changed these functions to create a new WebJSWorld each time they're
1761         called and to pass that world to WebKit.
1762
1763 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
1764
1765         Reviewed by Oliver Hunt.
1766
1767         need to implement aria tree roles
1768         https://bugs.webkit.org/show_bug.cgi?id=31284
1769
1770         * DumpRenderTree/AccessibilityUIElement.cpp:
1771         (disclosedRowAtIndexCallback):
1772         (selectedRowAtIndexCallback):
1773         (isEqualCallback):
1774         (isAttributeSettableCallback):
1775         (isActionSupportedCallback):
1776         (disclosedByRowCallback):
1777         (hierarchicalLevelCallback):
1778         (AccessibilityUIElement::getJSClass):
1779         * DumpRenderTree/AccessibilityUIElement.h:
1780         (AccessibilityUIElement::isEqual):
1781         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1782         (AccessibilityUIElement::hierarchicalLevel):
1783         (AccessibilityUIElement::disclosedRowAtIndex):
1784         (AccessibilityUIElement::selectedRowAtIndex):
1785         (AccessibilityUIElement::disclosedByRow):
1786         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1787         (AccessibilityUIElement::getChildAtIndex):
1788         (AccessibilityUIElement::disclosedRowAtIndex):
1789         (AccessibilityUIElement::selectedRowAtIndex):
1790         (AccessibilityUIElement::titleUIElement):
1791         (AccessibilityUIElement::parentElement):
1792         (AccessibilityUIElement::disclosedByRow):
1793         (AccessibilityUIElement::hierarchicalLevel):
1794         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1795         (AccessibilityUIElement::hierarchicalLevel):
1796         (AccessibilityUIElement::disclosedRowAtIndex):
1797         (AccessibilityUIElement::selectedRowAtIndex):
1798         (AccessibilityUIElement::disclosedByRow):
1799
1800 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
1801
1802         Reviewed by Darin Adler.
1803
1804         svn-apply can not handle git binary diffs
1805         https://bugs.webkit.org/show_bug.cgi?id=26830
1806
1807         Support "literal" type git binary diffs.
1808
1809         * Scripts/VCSUtils.pm:
1810         * Scripts/modules/scm_unittest.py:
1811         * Scripts/svn-apply:
1812
1813 2009-11-11  Dmitry Titov  <dimich@chromium.org>
1814
1815         Not reviewed, removing duplicate entry for myself in committers.py.
1816
1817         * Scripts/modules/committers.py:
1818
1819 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
1820
1821         Reviewed by Darin Adler and Mark Rowe.
1822
1823         https://bugs.webkit.org/show_bug.cgi?id=31200
1824         Tests in http/tests/security/mixedContent start to fail when new tests are added
1825
1826         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
1827
1828 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1829
1830         Reviewed by Jan Alonzo.
1831
1832         Create, and display a window for the inspector, for inspector
1833         tests.
1834
1835         Need to also show/hide the inspector window to avoid having
1836         problems with code assuming it is realized
1837         https://bugs.webkit.org/show_bug.cgi?id=31347
1838
1839         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1840         (webInspectorShowWindow):
1841         (webInspectorCloseWindow):
1842         (webInspectorInspectWebView):
1843         (createWebView):
1844
1845 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1846
1847         Unreviewed Qt buildbot fix.
1848
1849         My previous fix was wrong, so revert that change and fix it by
1850         returning when the document of the frame has no document element.
1851         Idea is borrowed from mac and win DRT.
1852
1853         * DumpRenderTree/qt/DumpRenderTree.cpp:
1854         (WebCore::DumpRenderTree::dumpFramesAsText):
1855
1856 2009-11-11  Eric Seidel  <eric@webkit.org>
1857
1858         Reviewed byg Kenneth Rohde Christiansen.
1859
1860         Update Kenneth's committer record to include the email he
1861         uses on lists.webkit.org.
1862
1863         * Scripts/modules/committers.py:
1864
1865 2009-11-11  Eric Seidel  <eric@webkit.org>
1866
1867         Reviewed by Gustavo Noronha Silva.
1868
1869         Several committers use separate email addresses for bugzilla and svn.webkit.org
1870         https://bugs.webkit.org/show_bug.cgi?id=31364
1871
1872         Update records for existing committers to include email addresses
1873         used in svn.webkit.org and lists.webkit.org.
1874         Most committers use the same email address in all 3 places, but some use
1875         separate addresses.  committers.py needs record of each of these addresses.
1876
1877         * Scripts/modules/committers.py:
1878
1879 2009-11-11  Eric Seidel  <eric@webkit.org>
1880
1881         No review, adding second email address for an existing committer.
1882
1883         Add Yong Li's second bugzilla account to his committer record.
1884         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
1885
1886         * Scripts/modules/committers.py:
1887
1888 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1889
1890         Reviewed by Simon Hausmann.
1891
1892         If the frame has no innerText don't append it, and
1893         do not add a newline which breaks some cross platform
1894         results.
1895
1896         * DumpRenderTree/qt/DumpRenderTree.cpp:
1897         (WebCore::DumpRenderTree::dumpFramesAsText):
1898
1899 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1900
1901         Reviewed by Simon Hausmann.
1902
1903         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
1904
1905         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1906         (webkit_test_plugin_new_instance):
1907         (webkit_test_plugin_destroy_instance):
1908         (webkit_test_plugin_destroy_stream):
1909
1910 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1911
1912         Reviewed by Mark Rowe.
1913
1914         Implement the functionality needed by plugins/window-open.html
1915
1916         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1917         (webkit_test_plugin_new_instance):
1918         (webkit_test_plugin_set_window):
1919
1920 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1921
1922         Reviewed by Simon Hausmann.
1923
1924         [Qt] Force -graphicssystem raster and -style windows when running DRT
1925
1926         * DumpRenderTree/qt/main.cpp:
1927         * Scripts/run-webkit-tests:
1928
1929 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1930
1931         Reviewed by Simon Hausmann.
1932
1933         Compute correct library paths for Qt
1934
1935         * Scripts/webkitdirs.pm:
1936
1937 2009-11-10  Mark Rowe  <mrowe@apple.com>
1938
1939         Reviewed by Sam Weinig.
1940
1941         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
1942
1943         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
1944         about the validity of the self-signed certificates used in the regression tests.  We would then add the
1945         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
1946         that had enabled frame load delegate logging this would result in extra log messages being generated,
1947         causing the test to fail.
1948
1949         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
1950         tests.
1951
1952         * DumpRenderTree/mac/DumpRenderTree.mm:
1953         (dumpRenderTree):
1954         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1955         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1956
1957 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1958
1959         Reviewed by Kenneth Rohde Christiansen.
1960
1961         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
1962
1963         * DumpRenderTree/qt/DumpRenderTree.cpp:
1964         (WebCore::DumpRenderTree::DumpRenderTree):
1965
1966 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1967
1968         Reviewed by Jan Alonzo.
1969
1970         [GTK] Remove WebSocket configuration from WebKitWebSettings
1971         https://bugs.webkit.org/show_bug.cgi?id=31244
1972
1973         Follow-up of r50724. Don't set the enable-web-socket property
1974         anymore.
1975
1976         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1977         (resetDefaultsToConsistentValues):
1978
1979 2009-11-10  Oliver Hunt  <oliver@apple.com>
1980
1981         Reviewed by Maciej Stachowiak.
1982
1983         Rename 3D Canvas related classes to use WebGL prefix
1984         https://bugs.webkit.org/show_bug.cgi?id=29095
1985
1986         Checkin new version of do-webcore-rename used to do the WebGL type rename,
1987         and upate webkitdirs script to new method of testing for WebGL.
1988
1989         * Scripts/do-webcore-rename:
1990         * Scripts/webkitdirs.pm:
1991
1992 2009-11-09  Oliver Hunt  <oliver@apple.com>
1993
1994         Reviewed by Geoff Garen.
1995
1996         Make do-webcore-rename work with git.
1997
1998         * Scripts/do-webcore-rename:
1999
2000 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2001
2002         Adding Kenneth to the reviewers list.
2003
2004         * Scripts/modules/committers.py:
2005
2006 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2007
2008         Reviewed by Jan Alonzo.
2009
2010         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
2011         https://bugs.webkit.org/show_bug.cgi?id=30482
2012
2013         LayoutTestControllerGtk now uses the exposed
2014         Page::tabKeyCyclesThroughElements API
2015
2016         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2017         (LayoutTestController::setTabKeyCyclesThroughElements):
2018
2019 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
2020
2021         Reviewed by Holger Freyther.
2022
2023         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
2024         This helps to pass the test case below. Also replaced hardcoded
2025         code numbers with defined constants.
2026         https://bugs.webkit.org/show_bug.cgi?id=31185
2027         
2028         Test: editing/undo/undo-deleteWord.html
2029
2030         * DumpRenderTree/qt/EventSenderQt.cpp:
2031         (EventSender::keyDown):
2032
2033 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
2034
2035         Reviewed by Holger Freyther.
2036
2037         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
2038         https://bugs.webkit.org/show_bug.cgi?id=31164
2039
2040         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
2041
2042         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2043         (LayoutTestController::processWork):
2044
2045 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
2046
2047         Reviewed by Holger Freyther.
2048
2049         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
2050         https://bugs.webkit.org/show_bug.cgi?id=31158
2051
2052         By invoking a script queue'd by queueScript(), 'true' was beeing returned
2053         always, which from WorkQueue prospective means that a load has been started
2054         and the queue processing should stop and wait for the load to finish.
2055         Spinning it off into a loading and a non-loading variants was the solution
2056         adopted by Mac's DRT to work around this problem. The former keeps returning
2057         'true' while the later executes the script synchronously and returns 'false'
2058         making it possible to the WorkQueue to proceed right away.
2059
2060         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2061         (LayoutTestController::processWork):
2062         (LayoutTestController::queueLoadingScript):
2063         (LayoutTestController::queueNonLoadingScript):
2064         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2065         * DumpRenderTree/qt/WorkQueueItem.h:
2066         (LoadingScriptItem::LoadingScriptItem):
2067         (LoadingScriptItem::invoke):
2068         (NonLoadingScriptItem::NonLoadingScriptItem):
2069         (NonLoadingScriptItem::invoke):
2070
2071 2009-11-07  Mark Rowe  <mrowe@apple.com>
2072
2073         Rubber-stamped by Cameron Zwarich.
2074
2075         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
2076
2077         * Scripts/commit-log-editor:
2078
2079 2009-11-07  Mark Rowe  <mrowe@apple.com>
2080
2081         Reviewed by Darin Adler.
2082
2083         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
2084         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
2085
2086         Move logic for determining the name and email address to use in a ChangeLog entry from
2087         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
2088         whether the author of the patch matches committer, and therefore needs access to the
2089         email address that would be used in a ChangeLog entry.
2090
2091         Based on a patch by Pierre d'Herbemont.
2092
2093         * Scripts/VCSUtils.pm:
2094         * Scripts/commit-log-editor:
2095         * Scripts/prepare-ChangeLog:
2096         * Scripts/webkitdirs.pm:
2097
2098 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
2099
2100         Reviewed by Adam Barth.
2101
2102         Added functionality to the layout test plugin to invoke document.open and
2103         window.open with default arguments. The associated webkit bug is
2104         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
2105         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
2106         work in Chromium (V8) if there is no calling javascript context. To achieve this
2107         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
2108         for the window.open test case and in NPP_DestroyStream for the document.open test case.
2109
2110         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2111         (testDocumentOpen):
2112         (testWindowOpen):
2113         (pluginAllocate):
2114         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2115         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2116         (NPP_New):
2117         (NPP_SetWindow):
2118         (NPP_DestroyStream):
2119         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
2120         (NPP_New):
2121         (NPP_SetWindow):
2122         (NPP_NewStream):
2123         (NPP_DestroyStream):
2124
2125 2009-11-06  Eric Seidel  <eric@webkit.org>
2126
2127         Reviewed by Adam Barth.
2128
2129         bugzilla-tool crashed with exception
2130         https://bugs.webkit.org/show_bug.cgi?id=31092
2131
2132         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
2133
2134 2009-11-04  Eric Seidel  <eric@webkit.org>
2135
2136         No review, just add a line which got left out of the patch uploaded for commit.
2137
2138         commit-queue is crashing when trying to reject patches after unknown failures
2139         https://bugs.webkit.org/show_bug.cgi?id=31091
2140
2141         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
2142
2143 2009-11-04  Adam Roben  <aroben@apple.com>
2144
2145         Remove bogus else clause in bugzilla-tool
2146
2147         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
2148         create-bug raises exception after entering bug description
2149
2150         Reviewed by David Kilzer.
2151
2152         * Scripts/bugzilla-tool:
2153         (CreateBug): else clauses are only hit if no exception is raised, so
2154         it makes no sense to try to re-raise the exception in an else clause.
2155         The exception will automatically be re-raised if it doesn't match any
2156         of the except clauses, so we don't have to do anything special here at
2157         all to get the desired behavior.
2158
2159 2009-11-04  Eric Seidel  <eric@webkit.org>
2160
2161         Reviewed by David Kilzer.
2162
2163         svn-apply's fixChangeLogPatch function seems broken
2164         https://bugs.webkit.org/show_bug.cgi?id=30683
2165
2166         Update fixChangeLogPatch to be able to handle patches which
2167         don't start at line 1.
2168         Add unit tests for svn-apply to scm_unittest.py.
2169
2170         * Scripts/VCSUtils.pm:
2171         * Scripts/modules/scm_unittest.py:
2172
2173 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
2174
2175         Reviewed by Beth Dakin.
2176
2177         Need to implement ARIA role="combobox"
2178         https://bugs.webkit.org/show_bug.cgi?id=31096
2179
2180         * DumpRenderTree/AccessibilityUIElement.cpp:
2181         (showMenuCallback):
2182         (getIsExpandedCallback):
2183         (AccessibilityUIElement::getJSClass):
2184         * DumpRenderTree/AccessibilityUIElement.h:
2185         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2186         (AccessibilityUIElement::isExpanded):
2187         (AccessibilityUIElement::showMenu):
2188         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2189         (AccessibilityUIElement::isExpanded):
2190         (AccessibilityUIElement::showMenu):
2191         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2192         (AccessibilityUIElement::isSelected):
2193         (AccessibilityUIElement::isExpanded):
2194         (AccessibilityUIElement::showMenu):
2195
2196 2009-11-04  Eric Seidel  <eric@webkit.org>
2197
2198         Reviewed by Adam Barth.
2199
2200         commit-queue is crashing when trying to reject patches after unknown failures
2201         https://bugs.webkit.org/show_bug.cgi?id=31091
2202
2203         * Scripts/bugzilla-tool:
2204          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
2205            so we have to find out what the current patch is by asking bugzilla again.
2206          - Discovered that this code was also leaking file descriptors, so fixed that.
2207
2208 2009-11-04  Adam Roben  <aroben@apple.com>
2209
2210         Make run-webkit-tests work for the Debug_Internal Windows
2211         configuration
2212
2213         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
2214         suffix.
2215
2216         Fixes <http://webkit.org/b/31123>.
2217
2218         Reviewed by Sam Weinig.
2219
2220         * Scripts/run-webkit-tests: Don't add the _debug suffix in
2221         Debug_Internal, either.
2222
2223 2009-11-04  Eric Seidel  <eric@webkit.org>
2224
2225         Reviewed by Adam Barth.
2226
2227         committers.py needs a way to store non-bugzilla email addresses
2228         https://bugs.webkit.org/show_bug.cgi?id=31037
2229
2230         Make Committer and Reviewer constructors take a single email or a list of emails.
2231         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
2232         Expose reviewers(), used by validate-committer-lists on bug 30970.
2233
2234         * Scripts/modules/committers.py:
2235         * Scripts/modules/committers_unittest.py: Added tests for the new code.
2236
2237 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
2238
2239         Reviewed by David Levin.
2240
2241         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
2242         https://bugs.webkit.org/show_bug.cgi?id=27491
2243
2244         The test path determination logic is changed to handle websocket and websocket/ssl cases.
2245         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
2246
2247         Functions to start or stop Web Socket servers are added.
2248
2249         * Scripts/run-webkit-tests:
2250
2251 2009-11-03  Eric Seidel  <eric@webkit.org>
2252
2253         No review, just changing wording of log message.
2254
2255         Change log string to say "failed" instead of "rejected"
2256         when a commit fails due to an out of date checkout.
2257         This makes grepping the commit-queue log for rejected patches easier.
2258
2259         * Scripts/bugzilla-tool:
2260
2261 2009-11-03  Eric Seidel  <eric@webkit.org>
2262
2263         No review, adding commonly known committers missing from the file.
2264
2265         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
2266
2267 2009-11-03  Eric Seidel  <eric@webkit.org>
2268
2269         No review, just sort-order cleanup.
2270
2271         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
2272
2273 2009-11-03  Stephen White  <senorblanco@chromium.org>
2274
2275         (Unreviewed).
2276
2277         Add myself to committers.py.
2278
2279         * Scripts/modules/committers.py:
2280
2281 2009-11-03  Robin Dunn  <robin@alldunn.com>
2282
2283         Reviewed by Kevin Ollviier.
2284
2285         Add packaging scripts for Debian-based Linux distros.
2286         
2287         https://bugs.webkit.org/show_bug.cgi?id=31075
2288
2289         * wx/packaging/build-debian-installer.py: Added.
2290         * wx/packaging/debian: Added.
2291
2292 2009-11-03  Dan Bernstein  <mitz@apple.com>
2293
2294         Reviewed by Anders Carlsson and Beth Dakin.
2295
2296         https://bugs.webkit.org/show_bug.cgi?id=31070
2297
2298         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
2299         destroyed, it executes the value of the 'ondestroy' parameter as a
2300         script.
2301
2302         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2303         (pluginAllocate): Initialize onDestroy.
2304         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
2305         onDestroy.
2306         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2307         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
2308         specified.
2309         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
2310
2311 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2312
2313         Reviewed by Xan Lopez.
2314
2315         https://bugs.webkit.org/show_bug.cgi?id=31035
2316         [GTK] some accessibility tests hitting assertion in debug builds
2317
2318         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
2319
2320         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2321         (AccessibilityController::rootElement):
2322
2323 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
2324
2325         Reviewed by Beth Dakin.
2326
2327         Support ARIA "tab" roles
2328         https://bugs.webkit.org/show_bug.cgi?id=30842
2329
2330         * DumpRenderTree/AccessibilityUIElement.cpp:
2331         * DumpRenderTree/AccessibilityUIElement.h:
2332         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2333         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2334         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2335
2336 2009-11-01  Eric Seidel  <eric@webkit.org>
2337
2338         Reviewed by David Levin.
2339
2340         buildbots should use --exit-after-N-failures
2341         https://bugs.webkit.org/show_bug.cgi?id=30809
2342
2343         Make the bots exit after 20 failures to prevent never-ending
2344         test runs where every test spends a minute crashing.
2345
2346         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2347
2348 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2349
2350         Reviewed by Eric Seidel.
2351
2352         Turn on warnings for QtWebKit for gcc
2353         https://bugs.webkit.org/show_bug.cgi?id=30958
2354
2355         * DumpRenderTree/qt/main.cpp: 
2356         (crashHandler): Mark function NO_RETURN
2357
2358 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
2359
2360         Adding myself to the committers list.
2361
2362         * Scripts/modules/committers.py:
2363
2364 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
2365
2366         Fix an issue that Adam noticed in DRT.
2367
2368         Reviewed by Darin Adler.
2369
2370         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2371         (AccessibilityUIElement::role):
2372         Get the length of the role text, and create a buffer dynamically.
2373
2374 2009-10-30  Eric Seidel  <eric@webkit.org>
2375
2376         No review, rolling out r50105.
2377         http://trac.webkit.org/changeset/50105
2378
2379         This commit was causing:
2380         https://bugs.webkit.org/show_bug.cgi?id=30869
2381         We'll re-implement the feature a different way.
2382
2383         * Scripts/bugzilla-tool:
2384
2385 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2386
2387         Test for MSAA: Accessibility of headings is not correct
2388
2389         https://bugs.webkit.org/show_bug.cgi?id=30937
2390
2391         Reviewed by Adam Roben.
2392
2393         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2394         (AccessibilityUIElement::role):
2395         Allow the role returned to be a BSTR.
2396         (AccessibilityUIElement::description):
2397         Fix a copy/paste error.
2398
2399 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2400
2401         Test for MSAA: Accessibility of links is wrong
2402
2403         https://bugs.webkit.org/show_bug.cgi?id=30928
2404
2405         Reviewed by Darin Adler.
2406
2407         * DumpRenderTree/AccessibilityUIElement.cpp:
2408         (getAccessibilityValueCallback):
2409         Return the accessibility value.
2410         (AccessibilityUIElement::getJSClass):
2411         Added "accessibilityValue" value.
2412
2413         * DumpRenderTree/AccessibilityUIElement.h:
2414
2415         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2416         (AccessibilityUIElement::accessibilityValue):
2417         Stubbed.
2418
2419         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2420         (AccessibilityUIElement::accessibilityValue):
2421         Stubbed.
2422
2423         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2424         (AccessibilityUIElement::accessibilityValue):
2425         Get the object's value, and return it as a JS string.
2426
2427 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
2428
2429         Fix typo in command name used by wx build system.
2430
2431         * wx/build/build_utils.py:
2432
2433 2009-10-30  Adam Barth  <abarth@webkit.org>
2434
2435         Reviewed by Darin Adler.
2436
2437         Patch v1 is a dumb default name for patches
2438         https://bugs.webkit.org/show_bug.cgi?id=30952
2439
2440         Let's use "Patch" instead.
2441
2442         * Scripts/bugzilla-tool:
2443
2444 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2445
2446         Unreviewed trivial buildfix.
2447
2448         [Qt] Buildfix for r50333.
2449
2450         * DumpRenderTree/qt/DumpRenderTree.pro:
2451
2452 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
2453
2454         Reviewed by Holger Freyther.
2455
2456         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
2457         https://bugs.webkit.org/show_bug.cgi?id=30953
2458
2459         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
2460         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
2461         makes qt DRT to share this implementation (as gtk and mac ports do).
2462
2463         * DumpRenderTree/qt/DumpRenderTree.pro:
2464         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
2465         * DumpRenderTree/qt/WorkQueue.h: Removed.
2466
2467 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2468
2469         Unreviewed potential buildbot fix.
2470
2471         Second try: Reset page history before running each test.
2472
2473         Apparently the QWebHistory::clear() keeps the current page
2474         in history which is not what we want, so we not additionally
2475         sets the history capacity to 0 (forces removing everything)
2476         and then sets it back to its original value.
2477
2478         * DumpRenderTree/qt/DumpRenderTree.cpp:
2479         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2480
2481 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2482
2483         Unreviewed potential buildbot fix.
2484
2485         Reset page history before running each test.
2486
2487         * DumpRenderTree/qt/DumpRenderTree.cpp:
2488         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2489
2490 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
2491
2492         Reviewed by Eric Seidel.
2493
2494         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
2495
2496         Bug 28420 -  Implement HTML5 <ruby> rendering
2497         (https://bugs.webkit.org/show_bug.cgi?id=28420)
2498
2499         No new tests (no functional change).
2500
2501         * Scripts/build-webkit:
2502
2503 2009-10-29  Dan Bernstein  <mitz@apple.com>
2504
2505         Reviewed by Mark Rowe.
2506
2507         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
2508         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
2509         define it.
2510
2511         * Scripts/VCSUtils.pm:
2512         * Scripts/svn-apply:
2513         * Scripts/svn-unapply:
2514
2515 2009-10-29  Xan Lopez  <xlopez@igalia.com>
2516
2517         Reviewed by Gustavo Noronha.
2518
2519         Use the GTK+ main loop instead of rolling our own mini-version of
2520         it.
2521
2522         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2523         (dump):
2524         (runTest):
2525         (webViewLoadFinished):
2526
2527 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2528
2529         Reviewed by Oliver Hunt.
2530
2531         Implement the Qt version of DRT dumpBackForwardList().
2532
2533         * DumpRenderTree/qt/DumpRenderTree.cpp:
2534         (WebCore::dumpHistoryItem):
2535         (WebCore::DumpRenderTree::dumpBackForwardList):
2536
2537 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2538
2539         Reviewed by Adam Roben.
2540
2541         Implement DRT functionality for Qt introduced in
2542         r28690 and r28705.
2543
2544         - Implemented pathToLocalResource which exposes the functionality of
2545         converting a given unix path to the correct location on Windows.
2546         - Implemented a way to remove machine-dependent information from paths
2547         in layout test results.
2548
2549         * DumpRenderTree/qt/DumpRenderTree.cpp:
2550         (WebCore::urlSuitableForTestResult):
2551         (WebCore::WebPage::javaScriptConsoleMessage):
2552         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2553         (LayoutTestController::pathToLocalResource):
2554         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2555
2556 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
2557
2558         Adding myself to the committers list.
2559
2560         * Scripts/modules/committers.py:
2561
2562 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
2563
2564         Adding myself to the committers list.
2565
2566         * Scripts/modules/committers.py:
2567
2568 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2569
2570         Reviewed by Jan Alonzo.
2571
2572         [GTK] API to start inspector for a WebView
2573         https://bugs.webkit.org/show_bug.cgi?id=22551
2574
2575         Use the new inspector API to implement the LayoutTestController
2576         interfaces used to test the inspector.
2577
2578         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2579         (webInspectorInspectWebView):
2580         (createWebView):
2581         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2582         (LayoutTestController::showWebInspector):
2583         (LayoutTestController::closeWebInspector):
2584         (LayoutTestController::evaluateInWebInspector):
2585
2586 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
2587
2588         Reviewed by Eric Seidel.
2589
2590         [Qt] WebFrame::counterValueForElementById must not be exposed
2591         https://bugs.webkit.org/show_bug.cgi?id=30882
2592
2593         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2594         (LayoutTestController::counterValueForElementById):
2595
2596 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2597
2598         Rubberstamped by Oliver Hunt.
2599
2600         Fix the warning:
2601
2602         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
2603         declared with attribute warn_unused_result".
2604
2605         by actually checking the result. In the case it is null, an
2606         error has occoured, so treat it as the other fatal errors.
2607
2608         * DumpRenderTree/qt/DumpRenderTree.cpp:
2609         (WebCore::DumpRenderTree::initializeFonts):
2610
2611 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
2612
2613         Reviewed by Darin Adler.
2614
2615         Provide a way to get counter values with layoutTestContoller
2616         https://bugs.webkit.org/show_bug.cgi?id=30555
2617
2618         Define layoutTestContoller.counterValueForElementById.
2619
2620         * DumpRenderTree/LayoutTestController.cpp:
2621         (counterValueForElementByIdCallback):
2622         (LayoutTestController::staticFunctions):
2623         * DumpRenderTree/LayoutTestController.h:
2624         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2625         (LayoutTestController::counterValueForElementById):
2626
2627 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2628
2629         Rubberstamped by Oliver Hunt.
2630
2631         Change two methods to be internal for DRT use only.
2632
2633         Part of [Qt] Review all new API in Qt 4.6
2634         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
2635
2636         * DumpRenderTree/qt/DumpRenderTree.cpp:
2637         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2638         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2639         (LayoutTestController::whiteListAccessFromOrigin):
2640
2641 2009-10-27  Eric Seidel  <eric@webkit.org>
2642
2643         Reviewed by Adam Barth.
2644
2645         REGRESSION: svn-apply exits(1) when applying a patch with a file add
2646         https://bugs.webkit.org/show_bug.cgi?id=30826
2647
2648         * Scripts/svn-apply:
2649          - Add () around all system() calls.
2650          - Use the correct system() == 0 or die instead of system() or die
2651          - Add descriptive messages to all die statements.
2652
2653 2009-10-27  Steve Block  <steveblock@google.com>
2654
2655         Reviewed by NOBODY.
2656
2657         Adds steveblock@google.com to list of committers.
2658
2659         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
2660
2661 2009-10-27  Eric Seidel  <eric@webkit.org>
2662
2663         Reviewed by Adam Barth.
2664
2665         svn-apply can exit(0) even on patch failure
2666         https://bugs.webkit.org/show_bug.cgi?id=29622
2667
2668         * Scripts/svn-apply:
2669          - Add a bunch of "or die" statements, hopefully catching all
2670            possible cases where failure could still exit(0).
2671
2672 2009-10-27  Eric Seidel  <eric@webkit.org>
2673
2674         Reviewed by Adam Barth.
2675
2676         svn-* scripts should share code through VCSUtils.pm
2677         https://bugs.webkit.org/show_bug.cgi?id=30791
2678
2679         Just moving code into a shared location.
2680
2681         * Scripts/VCSUtils.pm:
2682         * Scripts/prepare-ChangeLog:
2683         * Scripts/resolve-ChangeLogs:
2684         * Scripts/svn-apply:
2685         * Scripts/svn-create-patch:
2686         * Scripts/svn-unapply:
2687         * Scripts/update-webkit:
2688
2689 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
2690
2691         Suppress a huge number of MSVC warnings when building wxWebKit.
2692
2693         * wx/build/settings.py:
2694
2695 2009-10-26  Eric Seidel  <eric@webkit.org>
2696
2697         No review, just adding Mike Belshe to the committers list.
2698
2699         * Scripts/modules/committers.py:
2700
2701 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2702
2703         Reviewed by Darin Adler.
2704
2705         Make .rc files compile on Windows without depending on MFC headers
2706         https://bugs.webkit.org/show_bug.cgi?id=30750
2707
2708         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
2709         windows.h instead of afxres.h because it exists even when MFC is not 
2710         installed, and is all that's needed here.
2711
2712         * FindSafari/FindSafari.rc: Ditto
2713
2714 2009-10-24  Eric Seidel  <eric@webkit.org>
2715
2716         Reviewed by Adam Barth.
2717
2718         bugzilla-tool post-diff should know how to mark commit-queue=?
2719         https://bugs.webkit.org/show_bug.cgi?id=29202
2720
2721         * Scripts/bugzilla-tool:
2722          - Add --commit-queue option to post-diff, post-commits and create-bug.
2723         * Scripts/modules/bugzilla.py:
2724          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
2725          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
2726
2727 2009-10-23  Eric Seidel  <eric@webkit.org>
2728
2729         Reviewed by Adam Barth.
2730
2731         bugzilla-tool commit-queue does not notice modifications to committers.py
2732         https://bugs.webkit.org/show_bug.cgi?id=30084
2733
2734         * Scripts/bugzilla-tool:
2735          - Make commit-queue re-exec itself instead of using while(1).
2736          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
2737          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
2738
2739 2009-10-22  Eric Seidel  <eric@webkit.org>
2740
2741         Reviewed by Adam Barth.
2742
2743         commit-queue will get stuck on patches if land-patches terminates unexpectedly
2744         https://bugs.webkit.org/show_bug.cgi?id=30634
2745
2746         * Scripts/bugzilla-tool:
2747          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
2748          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
2749
2750 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
2751
2752         Reviewed by Eric Seidel.
2753
2754         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
2755
2756         https://bugs.webkit.org/show_bug.cgi?id=30763
2757
2758         * pywebsocket/mod_pywebsocket/__init__.py:
2759         * pywebsocket/mod_pywebsocket/dispatch.py:
2760         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
2761         * pywebsocket/mod_pywebsocket/standalone.py:
2762         * pywebsocket/setup.py:
2763         * pywebsocket/test/test_dispatch.py:
2764
2765 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
2766
2767         Reviewed by David Levin.
2768
2769         REGRESSION: 2 failures in run-webkit-unittests
2770         https://bugs.webkit.org/show_bug.cgi?id=30645
2771
2772         * Scripts/modules/cpp_style_unittest.py:
2773         Fixed a few test scenarios which apparently lost some spaces from 
2774         text literals.
2775
2776 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
2777
2778         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
2779
2780         * Scripts/webkitdirs.pm:
2781
2782 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
2783
2784         Reviewed by Darin Adler.
2785
2786         Unification of using null device in perl scripts.
2787         https://bugs.webkit.org/show_bug.cgi?id=30572
2788
2789         * Scripts/VCSUtils.pm:
2790         * Scripts/bisect-builds:
2791         * Scripts/resolve-ChangeLogs:
2792         * Scripts/run-iexploder-tests:
2793         * Scripts/run-jsc:
2794         * Scripts/run-mangleme-tests:
2795         * Scripts/run-webkit-tests:
2796         * Scripts/webkitdirs.pm:
2797         Using File::Spec->devnull() instead of hard coded /dev/null.
2798
2799 2009-10-26  Eric Seidel  <eric@webkit.org>
2800
2801         Reviewed by Holger Freyther.
2802
2803         Reviewers are missing from committers.py
2804         https://bugs.webkit.org/show_bug.cgi?id=30733
2805
2806         * Scripts/modules/committers.py:
2807
2808 2009-10-23  Eric Seidel  <eric@webkit.org>
2809
2810         No review, only adding Alice to the list of reviewers.
2811
2812         * Scripts/modules/committers.py:
2813
2814 2009-10-23  Eric Seidel  <eric@webkit.org>
2815
2816         Reviewed by Eric Carlson.
2817
2818         fast/media/mq-transform-02.html failed on Leopard Commit Bot
2819         https://bugs.webkit.org/show_bug.cgi?id=30700
2820
2821         * DumpRenderTree/mac/DumpRenderTree.mm:
2822         (resetDefaultsToConsistentValues): Update QuickTime version check.
2823
2824 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
2825
2826         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
2827         character measurement APIs that are private on Tiger.
2828
2829         * wx/build/settings.py:
2830
2831 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2832
2833         Reviewed by NOBODY (build fix).
2834         Build fix following bug #30696.
2835
2836         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2837         (LayoutTestController::evaluateScriptInIsolatedWorld):
2838
2839 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2840
2841         Reviewed by Sam Weinig & Geoff Garen.
2842
2843         https://bugs.webkit.org/show_bug.cgi?id=30696
2844         Enable isolated-worlds tests on mac.
2845
2846         Add private interface for DRT to invoke execution in a given world.
2847
2848         * DumpRenderTree/LayoutTestController.cpp:
2849         (evaluateScriptInIsolatedWorldCallback):
2850         (LayoutTestController::staticFunctions):
2851         * DumpRenderTree/LayoutTestController.h:
2852         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2853         (LayoutTestController::evaluateScriptInIsolatedWorld):
2854         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2855         (LayoutTestController::evaluateScriptInIsolatedWorld):
2856
2857 2009-10-21  Eric Seidel  <eric@webkit.org>
2858
2859         Reviewed by Adam Barth.
2860
2861         bugzilla-tool's "patch failed to download an apply" error should give more information
2862         https://bugs.webkit.org/show_bug.cgi?id=30632
2863
2864         * Scripts/modules/scm.py:
2865          - Use the common run_command method instead of custom POpen code.
2866          - Make run_command know how to take pipes as input.
2867         * Scripts/modules/scm_unittest.py:
2868          - Add new tests to cover change.
2869          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
2870
2871 2009-10-21  Kent Tamura  <tkent@chromium.org>
2872
2873         Unreviewed.  Adding myself to the committers list.
2874
2875         * Scripts/modules/committers.py:
2876
2877 2009-10-21  Robin Dunn  <robin@alldunn.com>
2878
2879         Reviewed by Kevin Ollivier.
2880
2881         Update the Windows installer builder to work with Vista / Win 7 and with git.
2882         
2883         https://bugs.webkit.org/show_bug.cgi?id=30649
2884
2885         * wx/build/build_utils.py:
2886         * wx/packaging/build-mac-installer.py:
2887         * wx/packaging/build-win-installer.py:
2888         * wx/packaging/wxWebKitInstaller.iss.in:
2889
2890 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2891
2892         Reviewed by Gustavo Noronha.
2893
2894         [GTK] Added conditional code to avoid using
2895         gdk_window_get_root_coords if we do not have a gtk+ release newer
2896         than 2.17.3.
2897         https://bugs.webkit.org/show_bug.cgi?id=30636
2898
2899         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2900
2901 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
2902
2903         Reviewed by Eric Seidel.
2904
2905         [Qt] Added dummy implementation for keepWebHistory()
2906         https://bugs.webkit.org/show_bug.cgi?id=30592
2907
2908         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2909         (LayoutTestController::keepWebHistory):
2910         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2911
2912 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2913
2914         Reviewed by Xan Lopez.
2915
2916         [GTK] Fixed the double click condition, it is not double click if
2917         we move in just in one direction.
2918         https://bugs.webkit.org/show_bug.cgi?id=30636
2919
2920         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2921
2922 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2923
2924         Reviewed by Xan Lopez.
2925
2926         [GTK] Initialize the events completly before emitting them.
2927         https://bugs.webkit.org/show_bug.cgi?id=30633
2928
2929         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2930
2931 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2932
2933         wx build fix. Fix for when linking using --as-needed with gcc.
2934
2935         * wx/browser/wscript:
2936
2937 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2938
2939         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
2940         to support all the features used by CURL backend.
2941         
2942         * wx/build/settings.py:
2943         * wx/install-unix-extras:
2944
2945 2009-10-20  Anton Muhin  <antonm@chromium.org>
2946
2947         Reviewed by Adam Barth.
2948
2949         Add {ager,antonm,yurys}@chromium.org into committers.py
2950         https://bugs.webkit.org/show_bug.cgi?id=30560
2951
2952         * Scripts/modules/committers.py:
2953
2954 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2955
2956         Reviewed by Tor Arne Vestbø.
2957
2958         Make the Netscape Test plugin available to the Qt launcher.
2959
2960         * Scripts/run-launcher:
2961
2962 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
2963
2964         Reviewed by David Levin.
2965
2966         Removed WebSocket runtime settings.
2967         https://bugs.webkit.org/show_bug.cgi?id=29896
2968
2969         WebSocket runtime configuration is supported by chromium/v8 only.
2970
2971         * DumpRenderTree/mac/DumpRenderTree.mm:
2972         (resetDefaultsToConsistentValues):
2973         * DumpRenderTree/win/DumpRenderTree.cpp:
2974         (resetDefaultsToConsistentValues):
2975
2976 2009-10-19  Nate Chapin  <japhet@chromium.org>
2977
2978         Reviewed by Adam Barth.
2979
2980         Add testFail() to test plugin so we can test our handling of a
2981         plugin invoke call returning false.
2982
2983         https://bugs.webkit.org/show_bug.cgi?id=30239
2984
2985         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
2986         (pluginInvoke):
2987         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
2988
2989 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
2990
2991         Reviewed by Gustavo Noronha.
2992
2993         Enable DOM pasting when running layout tests.
2994
2995         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2996         (resetDefaultsToConsistentValues):
2997
2998 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2999
3000         Reviewed by Simon Hausmann.
3001
3002         Use the setPreferredContentsSize method instead
3003         of setFixedContentsSize, as the method has been renamed.
3004
3005         * DumpRenderTree/qt/DumpRenderTree.cpp:
3006         (WebCore::DumpRenderTree::open):
3007         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3008         (LayoutTestController::setFixedContentsSize):
3009
3010 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3011
3012         Reviewed by Dan Bernstein.
3013
3014         https://bugs.webkit.org/show_bug.cgi?id=30456
3015         Fixes for new Debug_All Windows build configuration.
3016
3017         * DumpRenderTree/win/DumpRenderTree.cpp:
3018         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
3019         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
3020
3021 2009-10-16  Eric Seidel  <eric@webkit.org>
3022
3023         Reviewed by Adam Barth.
3024
3025         commit-queue status bot should list which buildbot is blocking the queue
3026         https://bugs.webkit.org/show_bug.cgi?id=30452
3027
3028         Add new methods and testing.
3029
3030         * Scripts/bugzilla-tool:
3031         * Scripts/modules/buildbot.py:
3032         * Scripts/modules/buildbot_unittest.py:
3033
3034 2009-10-16  Eric Seidel  <eric@webkit.org>
3035
3036         Reviewed by Adam Barth.
3037
3038         run-webkit-tests fails when CWD is not inside a WebKit checkout
3039         https://bugs.webkit.org/show_bug.cgi?id=30451
3040
3041         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
3042         * Scripts/modules/scm_unittest.py:
3043           - Remove use of original_path (we don't need to restore the CWD).
3044           - Don't use '.' to find the webkit checkout, use __file__ instead.
3045
3046 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3047
3048         Reviewed by Adam Roben.
3049
3050         Add a Debug_All configuration to build entire stack as debug.
3051         Change Debug_Internal to:
3052         - stop using _debug suffix for all WebKit/Safari binaries
3053         - not use _debug as a DLL naming suffix
3054         - use non-debug C runtime lib.
3055
3056         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
3057         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
3058         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
3059         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3060         Add missing debug.vsprops inherited property sheet.
3061         Add Debug_All configuration.
3062         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
3063         * WinLauncher/WinLauncher.vcproj:
3064         Removed extraneous definitions inherited from vsprops.
3065         Add Debug_All configuration.
3066
3067 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
3068
3069         Reviewed by David Levin.
3070
3071         check-webkit-style is wrong about indent checking in namespaces
3072         in header files and a few other things
3073         https://bugs.webkit.org/show_bug.cgi?id=30362
3074
3075         The few other things include:
3076         + check-webkit-style does not require spaces around the equal sign
3077           inside 'if' statements and around binary operators that take 
3078           numeric literals.
3079         + check-webkit-style reports false errors for the / operator
3080           when part of a filename in the #include directive.
3081
3082         * Scripts/modules/cpp_style.py:
3083         Improved indentation checking and space checking around
3084         binary operators. While the checks are still not perfect,
3085         they are clearly better than before.
3086         * Scripts/modules/cpp_style_unittest.py:
3087         Added test cases for the newly supported checks and modified old
3088         test cases to match the new guidelines
3089
3090 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
3091
3092         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
3093
3094         * wx/build/settings.py:
3095
3096 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
3097
3098         Reviewed by David Levin.
3099
3100         Add mod_pywebsocket to test Web Sockets.
3101         http://code.google.com/p/pywebsocket/
3102         https://bugs.webkit.org/show_bug.cgi?id=27490
3103
3104         * pywebsocket/COPYING: Added.
3105         * pywebsocket/MANIFEST.in: Added.
3106         * pywebsocket/README: Added.
3107         * pywebsocket/example/echo_client.py: Added.
3108         * pywebsocket/example/echo_wsh.py: Added.
3109         * pywebsocket/mod_pywebsocket/__init__.py: Added.
3110         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
3111         * pywebsocket/mod_pywebsocket/handshake.py: Added.
3112         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
3113         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
3114         * pywebsocket/mod_pywebsocket/standalone.py: Added.
3115         * pywebsocket/mod_pywebsocket/util.py: Added.
3116         * pywebsocket/setup.py: Added.
3117         * pywebsocket/test/config.py: Added.
3118         * pywebsocket/test/mock.py: Added.
3119         * pywebsocket/test/run_all.py: Added.
3120         * pywebsocket/test/test_dispatch.py: Added.
3121         * pywebsocket/test/test_handshake.py: Added.
3122         * pywebsocket/test/test_mock.py: Added.
3123         * pywebsocket/test/test_msgutil.py: Added.
3124         * pywebsocket/test/test_util.py: Added.
3125         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
3126         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
3127         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
3128         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
3129         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
3130         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
3131         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
3132         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
3133
3134 2009-10-15  James Robinson  <jamesr@google.com>
3135
3136         Reviewed by David Levin.
3137
3138         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
3139
3140         https://bugs.webkit.org/show_bug.cgi?id=30426
3141
3142         * Scripts/modules/cpp_style.py:
3143         * Scripts/modules/cpp_style_unittest.py:
3144
3145 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
3146
3147         Reviewed by Adam Roben.
3148
3149         Fixes <http://webkit.org/b/30411>.
3150         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
3151         
3152         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
3153         building Chromium.
3154
3155         * Scripts/pdevenv:
3156
3157 2009-10-15  Robin Dunn  <robin@alldunn.com>
3158
3159         Reviewed by Kevin Ollivier.
3160
3161         Add Mac package building scripts for wx.
3162         
3163         https://bugs.webkit.org/show_bug.cgi?id=30405
3164
3165         * wx/build/build_utils.py:
3166         * wx/build/settings.py:
3167         * wx/packaging/build-mac-installer.py: Added.
3168
3169 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
3170
3171         Reviewed by Gustavo Noronha.
3172
3173         Enable Web Sockets support when running layout tests.
3174
3175         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3176         (resetDefaultsToConsistentValues):
3177
3178 2009-10-15  Xan Lopez  <xlopez@igalia.com>
3179
3180         Reviewed by Gustavo Noronha.
3181
3182         Need to initialize event.button.button, since in most cases a
3183         button number is not passed as an argument.
3184
3185         * DumpRenderTree/gtk/EventSender.cpp:
3186         (mouseDownCallback):
3187         (mouseUpCallback):
3188
3189 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
3190
3191         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
3192         the OS if none was explicitly set.
3193
3194         * wx/build/settings.py:
3195
3196 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
3197
3198         Reviewed by Timothy Hatcher.
3199
3200         Web Inspector: enable developers extras within inspector layout tests.
3201
3202         https://bugs.webkit.org/show_bug.cgi?id=30014
3203
3204         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3205         (LayoutTestController::showWebInspector):
3206         (LayoutTestController::closeWebInspector):
3207         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3208         (LayoutTestController::showWebInspector):
3209         (LayoutTestController::closeWebInspector):
3210
3211 2009-10-14  José Millán Soto  <jmillan@igalia.com>
3212
3213         Reviewed by Jan Alonzo.
3214
3215         GtkLauncher is using a deprecated signal
3216         https://bugs.webkit.org/show_bug.cgi?id=30364
3217
3218         Modified GtkLauncher to use notify::title signal instead of
3219         deprecated title-changed signal
3220
3221         * GtkLauncher/main.c:
3222         (notify_title_cb):
3223         (create_browser):
3224
3225 2009-10-14  Brady Eidson  <beidson@apple.com>
3226
3227         Reviewed by Sam Weinig.
3228
3229         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
3230         1 - Disables WebHistory
3231         2 - Doesn't make sense in that context anyway.
3232
3233         * DumpRenderTree/win/DumpRenderTree.cpp:
3234         (createWebViewAndOffscreenWindow):
3235
3236 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
3237
3238         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
3239         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
3240
3241         * wx/build/settings.py:
3242         * wx/install-unix-extras:
3243
3244 2009-10-14  Brady Eidson  <beidson@apple.com>
3245
3246         Reviewed by Sam Weinig.
3247
3248         WebKit Win API should provide a delegate interface for global history.
3249         https://bugs.webkit.org/show_bug.cgi?id=29905
3250
3251         * DumpRenderTree/LayoutTestController.cpp:
3252         (LayoutTestController::LayoutTestController):
3253         * DumpRenderTree/LayoutTestController.h:
3254         (LayoutTestController::dumpHistoryDelegateCallbacks):
3255         (LayoutTestController::setDumpHistoryDelegateCallbacks):
3256                 
3257         * DumpRenderTree/win/DumpRenderTree.cpp:
3258         (shouldLogHistoryDelegates):
3259         (runTest):
3260         (createWebViewAndOffscreenWindow):
3261         (main):
3262         * DumpRenderTree/win/DumpRenderTree.vcproj:
3263         
3264         Add the IWebHistoryDelegate to DRT Windows:
3265         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
3266         (wstringFromBSTR):
3267         (HistoryDelegate::HistoryDelegate):
3268         (HistoryDelegate::~HistoryDelegate):
3269         (HistoryDelegate::QueryInterface):
3270         (HistoryDelegate::AddRef):
3271         (HistoryDelegate::Release):
3272         (HistoryDelegate::didNavigateWithNavigationData):
3273         (HistoryDelegate::didPerformClientRedirectFromURL):
3274         (HistoryDelegate::didPerformServerRedirectFromURL):
3275         (HistoryDelegate::updateHistoryTitle):
3276         (HistoryDelegate::populateVisitedLinksForWebView):
3277         * DumpRenderTree/win/HistoryDelegate.h: Added.
3278
3279         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3280         (LayoutTestController::removeAllVisitedLinks):
3281
3282 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
3283
3284         Reviewed by Simon Hausmann.
3285
3286         [Qt] Implement support for setPOSIXLocale on Qt.
3287         https://bugs.webkit.org/show_bug.cgi?id=30268 
3288  
3289         * DumpRenderTree/qt/DumpRenderTree.cpp:
3290         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3291         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3292         (LayoutTestController::setPOSIXLocale):
3293         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3294
3295 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3296
3297         Unreviewed, adding myself to reviewers list.
3298
3299         * Scripts/modules/committers.py:
3300
3301 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3302
3303         Reviewed by Mark Rowe.
3304
3305         Fix null assignment so root tests work again.
3306
3307         * Scripts/webkitdirs.pm:
3308
3309 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3310
3311         Reviewed by Simon Hausmann.
3312
3313         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
3314         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
3315         This is done in preparation of implementing missing features in DRT.
3316         No functionality changes made yet.
3317
3318         * DumpRenderTree/qt/DumpRenderTree.cpp:
3319         * DumpRenderTree/qt/DumpRenderTree.pro:
3320         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
3321         (EventSender::EventSender):
3322         (EventSender::mouseDown):
3323         (EventSender::mouseUp):
3324         (EventSender::mouseMoveTo):
3325         (EventSender::leapForward):
3326         (EventSender::keyDown):
3327         (EventSender::contextClick):
3328         (EventSender::scheduleAsynchronousClick):
3329         (EventSender::frameUnderMouse):
3330         * DumpRenderTree/qt/EventSenderQt.h: Added.
3331         (EventSender::clearKillRing):
3332         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
3333         (LayoutTestController::LayoutTestController):
3334         (LayoutTestController::reset):
3335         (LayoutTestController::processWork):
3336         (LayoutTestController::maybeDump):
3337         (LayoutTestController::waitUntilDone):
3338         (LayoutTestController::notifyDone):
3339         (LayoutTestController::windowCount):
3340         (LayoutTestController::clearBackForwardList):
3341         (LayoutTestController::dumpEditingCallbacks):
3342         (LayoutTestController::dumpResourceLoadCallbacks):
3343         (LayoutTestController::queueBackNavigation):
3344         (LayoutTestController::queueForwardNavigation):
3345         (LayoutTestController::queueLoad):
3346         (LayoutTestController::queueReload):
3347         (LayoutTestController::queueScript):
3348         (LayoutTestController::provisionalLoad):
3349         (LayoutTestController::timerEvent):
3350         (LayoutTestController::encodeHostName):
3351         (LayoutTestController::decodeHostName):
3352         (LayoutTestController::setJavaScriptProfilingEnabled):
3353         (LayoutTestController::setFixedContentsSize):
3354         (LayoutTestController::setPrivateBrowsingEnabled):
3355         (LayoutTestController::setPopupBlockingEnabled):
3356         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3357         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3358         (LayoutTestController::numberOfActiveAnimations):
3359         (LayoutTestController::disableImageLoading):
3360         (LayoutTestController::dispatchPendingLoadRequests):
3361         (LayoutTestController::setDatabaseQuota):
3362         (LayoutTestController::clearAllDatabases):
3363         (LayoutTestController::whiteListAccessFromOrigin):
3364         (LayoutTestController::waitForPolicyDelegate):
3365         (LayoutTestController::overridePreference):
3366         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
3367         (LayoutTestController::isLoading):
3368         (LayoutTestController::setLoading):
3369         (LayoutTestController::shouldDumpAsText):
3370         (LayoutTestController::shouldDumpBackForwardList):
3371         (LayoutTestController::shouldDumpChildrenAsText):
3372         (LayoutTestController::shouldDumpDatabaseCallbacks):
3373         (LayoutTestController::shouldDumpStatusCallbacks):
3374         (LayoutTestController::shouldWaitUntilDone):
3375         (LayoutTestController::canOpenWindows):
3376         (LayoutTestController::shouldDumpTitleChanges):
3377         (LayoutTestController::waitForPolicy):
3378         (LayoutTestController::dumpAsText):
3379         (LayoutTestController::dumpChildFramesAsText):
3380         (LayoutTestController::dumpDatabaseCallbacks):
3381         (LayoutTestController::dumpStatusCallbacks):
3382         (LayoutTestController::setCanOpenWindows):
3383         (LayoutTestController::dumpBackForwardList):
3384         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3385         (LayoutTestController::display):
3386         (LayoutTestController::dumpTitleChanges):
3387         (LayoutTestController::dumpSelectionRect):
3388         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
3389         (TextInputController::TextInputController):
3390         (TextInputController::doCommand):
3391         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
3392         * DumpRenderTree/qt/WorkQueue.cpp:
3393         * DumpRenderTree/qt/WorkQueue.h:
3394         * DumpRenderTree/qt/WorkQueueItem.h:
3395         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
3396         (findFrameNamed):
3397         (LoadItem::invoke):
3398         (ReloadItem::invoke):
3399         (ScriptItem::invoke):
3400         (BackForwardItem::invoke):
3401         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
3402         * DumpRenderTree/qt/jsobjects.h:
3403
3404 2009-10-13  Dmitry Titov  <dimich@chromium.org>
3405
3406         Not reviewed, adding myself to the list of reviewers.
3407
3408         * Scripts/modules/committers.py:
3409
3410 2009-10-13  Anders Carlsson  <andersca@apple.com>
3411
3412         Reviewed by Sam Weinig.
3413
3414         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
3415
3416         Make the private browsing mode testable by the test plug-in.
3417         
3418         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3419         (pluginGetProperty):
3420         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3421         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3422         (NPP_New):
3423         (NPP_SetValue):
3424
3425 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
3426
3427         No review, just adding self to the list of reviewers.
3428
3429         * Scripts/modules/committers.py:
3430
3431 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
3432
3433         Reviewed by Adam Roben.
3434
3435         Web Inspector: Use proper web view in inspector layout
3436         tests for windows.
3437
3438         https://bugs.webkit.org/show_bug.cgi?id=30298
3439
3440         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3441         (LayoutTestController::showWebInspector):
3442         (LayoutTestController::closeWebInspector):
3443         (LayoutTestController::evaluateInWebInspector):
3444
3445 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
3446
3447         Reviewed by Sam Weinig.
3448
3449         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
3450         https://bugs.webkit.org/show_bug.cgi?id=29841
3451
3452         * DumpRenderTree/mac/DumpRenderTree.mm:
3453         (resetDefaultsToConsistentValues):
3454         * DumpRenderTree/win/DumpRenderTree.cpp:
3455         (resetDefaultsToConsistentValues):
3456
3457 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
3458
3459         Reviewed by Dimitri Glazkov.
3460
3461         Chromium Port - Windows
3462         https://bugs.webkit.org/show_bug.cgi?id=29969
3463
3464         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
3465         * Scripts/webkitdirs.pm:
3466
3467 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
3468
3469         Reviewed by Darin Adler.
3470
3471         jsc scripts cleanup and Qt/GTK fix
3472         https://bugs.webkit.org/show_bug.cgi?id=30288
3473
3474         Duplicated jscPath() moved to webkitdirs.pm.
3475         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
3476         Configuration added (release/debug) to path for Qt-port on Windows.
3477
3478         * Scripts/run-javascriptcore-tests:
3479         * Scripts/run-jsc:
3480         * Scripts/run-sunspider:
3481         * Scripts/sunspider-compare-results:
3482         * Scripts/webkitdirs.pm:
3483
3484 2009-10-11  Adam Barth  <abarth@webkit.org>
3485
3486         Unreviewed.  Add Collin to committers.py.
3487
3488         * Scripts/modules/committers.py:
3489
3490 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
3491
3492         wx build fix, add bindings to source/include dirs now that there are sources there.
3493
3494         * wx/build/settings.py:
3495
3496 2009-10-09  Mark Rowe  <mrowe@apple.com>
3497
3498         Reviewed by Brady Eidson.
3499
3500         Enable plug-in halting in DumpRenderTree.
3501
3502         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
3503         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
3504
3505         * DumpRenderTree/mac/DumpRenderTree.mm:
3506         (resetDefaultsToConsistentValues):
3507         * DumpRenderTree/mac/UIDelegate.mm:
3508         (-[UIDelegate webView:shouldHaltPlugin:]):
3509
3510 2009-10-08  Brady Eidson  <beidson@apple.com>
3511
3512         Reviewed by Dan Bernstein.
3513
3514         Ask the History Delegate to populate the visited links hash.
3515         <rdar://problem/7285293> and https://webkit.org/b/29904
3516
3517         Add the ability for LayoutTestController to clear all visited links.
3518         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
3519
3520         * DumpRenderTree/LayoutTestController.cpp:
3521         (LayoutTestController::LayoutTestController):
3522         (removeAllVisitedLinksCallback):
3523         (LayoutTestController::staticFunctions):
3524         * DumpRenderTree/LayoutTestController.h:
3525         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3526         (LayoutTestController::removeAllVisitedLinks):
3527
3528         * DumpRenderTree/mac/HistoryDelegate.mm:
3529         (-[HistoryDelegate populateVisitedLinksForWebView:]):
3530
3531         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3532         (LayoutTestController::removeAllVisitedLinks):
3533         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3534         (LayoutTestController::removeAllVisitedLinks):
3535         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3536         (LayoutTestController::removeAllVisitedLinks):
3537
3538
3539 2009-10-08  Daniel Bates  <dbates@webkit.org>
3540
3541         Reviewed by Adam Roben.
3542
3543         https://bugs.webkit.org/show_bug.cgi?id=30175
3544         
3545         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
3546         the OLE drag-and-drop return value like the function it emulates. Currently, 
3547         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
3548         whether the drag-and-drop operation was successful or was cancelled.
3549         
3550         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
3551         return value according to whether the drop operation was successful or not.
3552
3553         * DumpRenderTree/win/EventSender.cpp:
3554         (doMouseUp): Added parameter oleDragAndDropReturnValue.
3555         (replaySavedEvents): Ditto.
3556         * DumpRenderTree/win/EventSender.h:
3557         * DumpRenderTree/win/UIDelegate.cpp:
3558         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
3559
3560 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3561
3562         Reviewed by Xan Lopez.
3563
3564         [GTK] Added support for a parameter setting the button that was
3565         pressed in the mouseDown function.
3566         https://bugs.webkit.org/show_bug.cgi?id=30220
3567
3568         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3569
3570 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3571
3572         Reviewed by Xan Lopez.
3573
3574         [GTK] Added a line to the bottom of the expected result to match
3575         the output of the test.
3576         https://bugs.webkit.org/show_bug.cgi?id=30220
3577
3578         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
3579         expected.txt:
3580
3581 2009-10-08  Adam Roben  <aroben@apple.com>
3582
3583         Use QueryInterface to get IWebInspectorPrivate
3584
3585         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
3586         accessed in a more standard way
3587
3588         Reviewed by John Sullivan and Tim Hatcher.
3589
3590         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3591         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
3592         by calling IWebViewPrivate::inspector, then use QueryInterface to get
3593         to the IWebInspectorPrivate interface.
3594
3595 2009-10-07  Adam Roben  <aroben@apple.com>
3596
3597         Implement DRT support for origin whitelisting
3598
3599         Fixes <http://webkit.org/b/30185>.
3600
3601         Reviewed by Eric Seidel.
3602
3603         * DumpRenderTree/win/DumpRenderTree.cpp:
3604         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
3605         whitelist, to match Mac DRT.
3606         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3607         (LayoutTestController::whiteListAccessFromOrigin): Call through to
3608         IWebViewPrivate::whiteListAccessFromOrigin.
3609
3610 2009-10-07  Brady Eidson  <beidson@apple.com>
3611
3612         Reviewed by Darin Adler.
3613
3614         Send title changes to the global history delegate.
3615         <rdar://problem/7285293> and https://webkit.org/b/29904
3616
3617         * DumpRenderTree/mac/HistoryDelegate.mm:
3618         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
3619
3620 2009-10-07  Adam Barth  <abarth@webkit.org>
3621
3622         Unreviewed.  Remove some folks from committers.py who were listed on
3623         the WebKit Team wiki page but who weren't actually listed as commit+.
3624         At some point, we should coorelate this list with the committers
3625         mailing list.
3626
3627         * Scripts/modules/committers.py:
3628
3629 2009-10-07  Adam Barth  <abarth@webkit.org>
3630
3631         Unreviewed.  Import a bunch of committers from the WebKit Team page on
3632         the wiki into committers.py.
3633
3634         * Scripts/modules/committers.py:
3635
3636 2009-10-07  Adam Barth  <abarth@webkit.org>
3637
3638         Unreviewed.  Added Aaron Boodman to committers.py.
3639
3640         * Scripts/modules/committers.py:
3641
3642 2009-10-07  Evan Martin  <evan@chromium.org>
3643
3644         Reviewed by Darin Adler.
3645
3646         Add API to LayoutTestController for re/setting the system locale.
3647         https://bugs.webkit.org/show_bug.cgi?id=18994
3648
3649         * DumpRenderTree/LayoutTestController.cpp:
3650         (setLocaleCallback):
3651         (LayoutTestController::staticFunctions):
3652         (LayoutTestController::setLocale):
3653         * DumpRenderTree/LayoutTestController.h:
3654
3655 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
3656
3657         Reviewed by Jan Alonzo.
3658
3659         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3660         https://bugs.webkit.org/show_bug.cgi?id=29689
3661
3662         Build fix by adding -lfontconfig for DumpRenderTree.
3663
3664         * GNUmakefile.am:
3665
3666 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3667
3668         Reviewed by Simon Hausmann.
3669
3670         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
3671
3672         * Scripts/run-webkit-tests:
3673
3674 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3675
3676         Reviewed by Gustavo Noronha.
3677
3678         "delete" in EventSender is the backspace key, not the delete one.
3679
3680         * DumpRenderTree/gtk/EventSender.cpp:
3681         (keyDownCallback):
3682
3683 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3684
3685         Reviewed by Gustavo Noronha.
3686
3687         getChildrenWithRange expects as last parameter the end index, not