first bit of implementation for the textinputcontroller.
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-10-24  Lars Knoll  <lars@trolltech.com>
2
3         Reviewed by Simon.
4
5         first bit of implementation for the textinputcontroller.
6
7         * DumpRenderTree/qt/DumpRenderTree.cpp:
8         (WebCore::DumpRenderTree::DumpRenderTree):
9         * DumpRenderTree/qt/DumpRenderTree.h:
10         * DumpRenderTree/qt/jsobjects.cpp:
11         (TextInputController::TextInputController):
12         (TextInputController::doCommand):
13         * DumpRenderTree/qt/jsobjects.h:
14
15 2007-10-24  Lars Knoll  <lars@trolltech.com>
16
17         Reviewed by Simon.
18
19         make the man webpage believe it has focus, so the editing tests work correctly.
20
21         * DumpRenderTree/qt/DumpRenderTree.cpp:
22         (WebCore::DumpRenderTree::DumpRenderTree):
23
24 2007-10-24  Lars Knoll  <lars@trolltech.com>
25
26         Reviewed by Simon.
27
28         implement layoutTestController.dumpEditingCallbacks() correctly.
29
30         * DumpRenderTree/qt/DumpRenderTree.cpp:
31         (WebCore::DumpRenderTree::DumpRenderTree):
32         * DumpRenderTree/qt/jsobjects.cpp:
33         (LayoutTestController::reset):
34         (LayoutTestController::dumpEditingCallbacks):
35
36 2007-10-24  Lars Knoll  <lars@trolltech.com>
37
38         Reviewed by Simon.
39
40         Implement support for testing editing.
41
42         * DumpRenderTree/qt/DumpRenderTree.cpp:
43         (WebCore::DumpRenderTree::DumpRenderTree):
44
45 2007-10-23  Sam Weinig  <sam@webkit.org>
46
47         Check for null BSTR that can be passed to the UIDelegate methods
48         from javascript null and undefined.  Fixes a failing test case on
49         Windows (fast/dom/Window/alert-undefined.html)
50
51         Reviewed by Eric Seidel.
52
53         * DumpRenderTree/win/UIDelegate.cpp:
54         (UIDelegate::runJavaScriptAlertPanelWithMessage):
55         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
56         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
57         (UIDelegate::webViewAddMessageToConsole):
58
59 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
60
61         Reviewed by Darin.
62         
63         Don't print a massive pile of setenvs from tools that automatically build testkjs.
64
65         * Scripts/build-testkjs:
66
67 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
68
69         Reviewed by Darin.
70
71         - add wrapper that finds the right copy of testkjs
72         
73         * Scripts/sunspider-compare-results: Added.
74
75 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
76
77         Reviewed by Sam.
78
79         - After talking with Steve I now see that the WebKit server must be
80         running for DCOM to create the distributed objects, which makes sense
81         and currently WebKit only allows one instance to be running at a time
82         which avoids accidentally connecting to the wrong server
83         - In light of this I have removed the code for the attach box and
84         NotificationServer and known server names, since they are all extranious
85         now.
86
87         * Drosera/win/Drosera.cpp: Removed notification classes and known server
88         names.
89         (_tWinMain): Uses init instead of initUI.
90         (droseraWndProc): No longer creats an attach dialog box.
91         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
92         it's not manditory to call init before doing COM stuff.
93         (Drosera::init): calls initUI and will call attach when the
94         functionality exists. 
95         (Drosera::initUI): Has changed very little.
96         (Drosera::attach): Changed the signature to reflect that we no longer
97         need the dictionary of known server names.
98         * Drosera/win/Drosera.h: Removed notification classes and known server
99         names.  Also renamed and moved some functions.
100         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
101         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
102         headers to the resources folder. 
103         * Drosera/win/resource.h: Removed the Attach box.
104
105 2007-10-22  Adam Roben  <aroben@apple.com>
106
107         Windows build fix
108
109         Reviewed by NOBODY.
110
111         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
112
113 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
114
115         - Removed a leak that was fixed.
116
117         * Scripts/run-webkit-tests:
118
119 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
120
121         Reviewed by Darin.
122
123         - Changed the Client so that the DebuggerDocument now own the
124         ServerConnection.  This simplifies ownership and cleanup. 
125
126         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
127         ServerConnection.
128         (DebuggerClient::initWithServerName):
129         (DebuggerClient::didFinishLoadForFrame):
130         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
131         ServerConnection.
132         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
133         until after we have a server which we are attached to.
134         (Drosera::initUI):
135         (Drosera::attach):
136         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
137         out previously.
138
139 2007-10-22  Simon Hausmann  <hausmann@kde.org>
140
141         Reviewed by Nikolas.
142
143         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
144
145         * Scripts/run-javascriptcore-tests:
146
147 2007-10-22  Simon Hausmann  <hausmann@kde.org>
148
149         Reviewed by Nikolas.
150
151         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
152
153         * Scripts/build-drosera:
154         * Scripts/build-dumprendertree:
155         * Scripts/build-testkjs:
156         * Scripts/build-webkit:
157         * Scripts/run-javascriptcore-tests:
158         * Scripts/run-sunspider:
159         * Scripts/run-webkit-tests:
160         * Scripts/webkitdirs.pm:
161
162 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
163
164         Reviewed by Mark Rowe.
165         
166         Fix for local database support after r26879
167         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
168
169         * Scripts/build-webkit:
170
171 2007-10-22  Holger Freyther  <zecke@selfish.org>
172
173         Reviewed by Simon Hausmann <hausmann@kde.org>.
174
175         - Do not build testkjs as an application bundle. This is
176         needed for run-javascriptcore-tests on OSX.
177         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
178         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
179         as we do not have -rpath on OSX.
180
181         * DumpRenderTree/qt/DumpRenderTree.pro:
182         * Scripts/run-webkit-tests:
183
184 2007-10-22  Simon Hausmann  <hausmann@kde.org>
185
186         Reviewed by aroben.
187
188         Fix support for Signed-off-by detection in prepare-ChangeLog
189         --git-commit. The Signed-off-by tag does not appear in the header
190         but usually at the end.
191
192         * Scripts/prepare-ChangeLog:
193
194 2007-10-21  Mark Rowe  <mrowe@apple.com>
195
196         Reviewed by Eric.
197
198         Fix run-javascriptcore-tests for Gtk.
199
200         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
201
202 2007-10-20  Eric Seidel  <eric@webkit.org>
203
204         Reviewed by aroben.
205
206         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
207
208 2007-10-20  Eric Seidel  <eric@webkit.org>
209
210         Reviewed by darin.
211         
212         Add improved argument handling to run-sunspider, including
213         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
214         Also re-factor code into subroutines
215
216         * Scripts/build-dumprendertree: removed bogus comments
217         * Scripts/build-testkjs: Added.
218         * Scripts/run-javascriptcore-tests: use build-testkjs
219         * Scripts/run-sunspider: improved argument handling, abstraction
220         * Scripts/run-webkit-tests: improved abstraction
221
222 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
223
224         Not reviewed, Windows build fix.
225
226         * DumpRenderTree/win/EventSender.cpp:
227         (keyDownCallback):
228
229 2007-10-20  Darin Adler  <darin@apple.com>
230
231         Reviewed by Tim Hatcher.
232
233         - http://bugs.webkit.org/show_bug.cgi?id=15544
234           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
235           not rely on Apple-specific key codes
236
237         * DumpRenderTree/mac/EventSendingController.mm:
238         (-[EventSendingController keyDown:withModifiers:]):
239         Added named key "rightArrow". Later we could have a whole table of these.
240         Also tweaked modifiers code a little.
241
242         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
243
244 2007-10-19  Darin Adler  <darin@apple.com>
245
246         Reviewed by Eric.
247
248         - http://bugs.webkit.org/show_bug.cgi?id=15566
249           possible fix for leak seen in DumpRenderTree
250
251         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
252         Delete the item if it's not put on the queue, since the caller has
253         no way of knowing that. Would be better to have the parameter type
254         be auto_ptr to express the fact that we take ownership.
255
256         - unrelated change
257
258         * Drosera/mac/main.m: Add missing include.
259
260 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
261
262         Reviewed by Adam.
263
264         - This change should be identical but for some reason was not working
265         on my machine.
266
267         * Scripts/prepare-ChangeLog:
268
269 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
270
271         Reviewed by Oliver and Tim.
272
273         - Made use of RetainPtr to avoid retain and release issues and moved the
274         log function to DebuggerDocumentPlatform, which seems to be a more
275         logical place for it to live.
276         - Also moved knownServers from the ServerConnection to
277         DebuggerApplication to match the Windows code and because it makes sense
278         that a connection knows its own server but not all of them.
279
280         * Drosera/mac/DebuggerClient.h: Moved the log function to
281           DebuggerDocumentPlatform.
282         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
283           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
284           call for the server name up from the ServerConnection class.
285         (-[DebuggerClient dealloc]):
286         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
287           for the server name up from the ServerConnection.
288         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
289         (DebuggerDocument::platformPause):
290         (DebuggerDocument::platformResume):
291         (DebuggerDocument::platformStepInto):
292         (DebuggerDocument::platformEvaluateScript):
293         (DebuggerDocument::getPlatformCurrentFunctionStack):
294         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
295         (DebuggerDocument::platformValueForScopeVariableNamed):
296         (DebuggerDocument::platformLog): Log directly from here. No need to call
297           DebuggerClient.
298         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
299           way I see it, a ServerConnection should only know about its connection
300           and the group of all possible servers should be kept by the
301           application.
302         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
303           currentServerName, it makes sense that the connection should know that
304           name.
305         (-[ServerConnection currentServerName]):
306
307 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
308
309         Reviewed by Adam.
310
311         - Integrated changes from mac drosera.  Recently I've encapsulated
312         out the server connection object from the rest of Drosera because
313         it is very platform dependent right now and RPC is not implemented on
314         windows.  This functionality, of communicating with the WebKit server
315         is the next area I will be focusing on in Windows.
316
317         - Other changes and cleanup were made to organize the code and add notes
318         on which parts still need work.  Also some mac code is added and
319         commented out, to act as pseudocode for the logic of those parts.
320
321         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
322           pointer.
323         * Drosera/config.h: Added whitespace.
324         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
325           these files got moved into Drosera.h/cpp
326         * Drosera/win/DebuggerApplication.h: Removed.
327         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
328           happened here to better match the logic flow of the same code on the 
329           mac side and to use the new ServerConnection class.
330         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
331         (DebuggerClient::initWithServerName): Initializer that will set up the
332           class to use a ServerConnection object.  This was necessary so I could
333           create a DebuggerClient without having to initilaize it at
334           construction.
335         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
336           will be the UIDelegate and FrameLoadDelegate.
337         (DebuggerClient::AddRef): For IUnknown.
338         (DebuggerClient::Release): For IUnknown.
339         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
340           this still needs to set the global context of the server, but
341           IWebFrame does not have an accessor for the global context yet. 
342         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
343           this is a pass through for the same function in the document.
344         (DebuggerClient::didReceiveTitle): Unimplemented part of
345           FrameLoadDelegate this would change the title of the window.
346         (DebuggerClient::createWebViewWithRequest): Part of the
347           FrameLoadDelegate.  This is about new windows via Window.open() and
348           how their delegates are set.
349         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
350           UIDelegate.  Just a debug function for printing messages.
351         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
352           because the Client should be the UIDelegate and FrameLoadDelegate
353           to match the delegates on mac.
354         (DebuggerClient::webViewLoaded): Added accessor method.
355         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
356           forgotten to add this file before.  This is where the platform
357           dependent versions of the Documents functions live. Most of these are
358           unimplemented because some piece of functionality does not exist on
359           Windows yet.
360         (DebuggerDocument::platformPause):
361         (DebuggerDocument::platformResume):
362         (DebuggerDocument::platformStepInto):
363         (DebuggerDocument::platformEvaluateScript):
364         (DebuggerDocument::getPlatformCurrentFunctionStack):
365         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
366         (DebuggerDocument::platformValueForScopeVariableNamed):
367         (DebuggerDocument::platformLog):
368         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
369           responsibilities becaue they belong in the Client. Also I laid the
370           groundwork for attaching Drosera to a WebKit process
371         (attachWndProc): Now if a server is selected the Client becomes it's
372           delegate.
373         (Drosera::Drosera): Added the construction of the Client and dictionary
374           of server names. 
375         (Drosera::initUI): This is no longer the delegates, the Client is.
376         (Drosera::webViewLoaded): Now asks the Client instead of holding local
377           state. 
378         (Drosera::applicationDidFinishLaunching): Placeholder for needed
379           notification registration when it's possible to implement.
380         (Drosera::serverLoaded): Ditto
381         (Drosera::serverUnloaded): Ditto
382         (Drosera::attach): Attach Drosera to the WebKit server.
383         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
384         (Drosera::getInst): 
385         (Drosera::setInst):
386         (Drosera::knownServers):
387         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
388           and added the ServerConnection.
389         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
390         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
391           Most of the functions are completely unimlemented because they cannot
392           connect with the WebKit server, because one does not exist on Windows
393           yet.
394         (ServerConnection::initWithServerName): 
395         (ServerConnection::~ServerConnection):
396         (ServerConnection::setGlobalContext):
397         (ServerConnection::pause):
398         (ServerConnection::resume):
399         (ServerConnection::stepInto):
400         (ServerConnection::switchToServerNamed):
401         (ServerConnection::applicationTerminating):
402         (ServerConnection::serverConnectionDidDie):
403         (ServerConnection::currentFrame):
404         * Drosera/win/ServerConnection.h: Added. Ditto.
405         (ServerConnection::ServerConnection):
406
407 2007-10-19  Alice Liu  <alice.liu@apple.com>
408
409         Reviewed by Darin.
410
411         Fix for these broken layout tests on Windows:
412         
413         fast/forms/focus-selection-input.html
414         fast/forms/focus-selection-textarea.html
415         fast/forms/select-accesskey.html
416         
417         * DumpRenderTree/win/EventSender.cpp:
418         (keyDownCallback):
419         correct the VK code for alt key.
420         
421 2007-10-19  Eric Seidel  <eric@webkit.org>
422
423         Reviewed by Mark Rowe.
424         
425         Make the GtkLauncher code slightly more readable.
426
427         * GtkLauncher/main.cpp:
428         (setupMainMenu): Added.
429         (setupMainWindowUI): Added.
430         (main):
431
432 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
433
434         Rubber stamped by Adam.
435         
436         - don't delay-load WebKit in DumpRenderTree.
437
438         * DumpRenderTree/win/DumpRenderTree.vcproj:
439
440 2007-10-18  Dan Bernstein  <dan.bernstein@apple.com>
441
442         Reviewed by Adam Roben.
443
444         - fix <rdar://problem/5313523>
445         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
446
447         * DumpRenderTree/mac/DumpRenderTree.mm:
448         (dump): Changed to use _responseMIMEType.
449
450 2007-10-17  Adam Roben  <aroben@apple.com>
451
452         Make it possible to have Windows-specific tests and results
453
454         When searching for tests to run and the Skipped file, we will only
455         look in platform/win and the cross-platform directory. When looking
456         for expected results, we will look in platform/win, then
457         platform/mac-leopard, then platform/mac, then finally the
458         cross-platform directory.
459
460         Reviewed by Sam.
461
462         * Scripts/run-webkit-tests:
463         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
464         searching in the cross-platform directory.
465         (sub buildPlatformHierarchy): Removed some unneeded calls to
466         dirname/basename.
467
468 2007-10-17  Adam Roben  <aroben@apple.com>
469
470         Add back the call to register WebKit that we had before WebKitInitializer existed
471
472         This is needed to ensure that the right WebKit is used when
473         instantiating COM objects.
474
475         Reviewed by Oliver.
476
477         * DumpRenderTree/win/debug_internal.vsprops: Define
478         DEBUG_WEBKIT_HAS_SUFFIX.
479         * DumpRenderTree/win/DumpRenderTree.cpp:
480         (initialize):
481
482 2007-10-17  Adam Roben  <aroben@apple.com>
483
484         Import File::Basename in webkitdirs since we use it
485
486         Reviewed by NOBODY.
487
488         * Scripts/webkitdirs.pm:
489
490 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
491
492         - Updated the tiger leaks list to make the internal bots green.
493
494         * Scripts/run-webkit-tests:
495
496 2007-10-17  Adam Roben  <aroben@apple.com>
497
498         Build fix for VC++ Express
499
500         Reviewed by NOBODY.
501
502         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
503         and ole32.lib.
504
505 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
506
507         Reviewed by Sam.
508
509         - Minor mac improvements based on observations I made while implementing the
510         Windows code.
511
512         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
513         then hand it to the Client who will retain it, it should just be the client who
514         creates and owns the server.
515         (-[DebuggerApplication attach:]):
516         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
517         * Drosera/mac/DebuggerClient.mm: Creates the server.
518         (-[DebuggerClient initWithServerName:]):
519         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
520         can instead forward declare what it needs.
521
522 2007-10-16  Darin Adler  <darin@apple.com>
523
524         Reviewed by Geoff Garen.
525
526         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
527         want to turn failing tests into platform-specific test results. Also did a
528         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
529         would take the type of results into account only some of the time.
530
531 2007-10-16  Adam Roben  <aroben@apple.com>
532
533         Add a new nightly launcher script for Windows
534
535         This new script is for versions of Safari that don't delay-load
536         WebKit. I had to make FindSafari be able to print out the nightly
537         launcher script on stdout because Windows shell scripts can't capture
538         the output from a command into an environment variable.
539
540         Reviewed by Steve.
541
542         * FindSafari/FindSafari.cpp:
543         (_tmain): Added /printSafariLauncher option.
544         * Scripts/run-webkit-nightly.cmd: Added.
545
546 2007-10-16  Adam Roben  <aroben@apple.com>
547
548         Replace WebKitInitializer with FindSafari
549
550         We now rely on setting the PATH environment variable to tell Windows
551         where to find WebKit and its dependencies (similar to
552         DYLD_FRAMEWORK_PATH on Mac).
553
554         This change also make DumpRenderTree no longer delay-load WebKit.
555
556         Reviewed by Sam.
557
558         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
559         FindSafari.
560         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
561         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
562         WebKitInitializer, don't delay-load WebKit.
563         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
564         * Scripts/run-webkit-tests: Ditto.
565         * Scripts/webkitdirs.pm:
566         (sub setPathForRunningWebKitApp): Added.
567         * WebKitInitializer/WebKitInitializer.cpp: Removed.
568         * WebKitInitializer/WebKitInitializer.h: Removed.
569         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
570         * WebKitInitializer/debug.vsprops: Removed.
571         * WebKitInitializer/debug_internal.vsprops: Removed.
572         * WebKitInitializer/release.vsprops: Removed.
573
574 2007-10-16  Adam Roben  <aroben@apple.com>
575
576         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
577
578         http://bugs.webkit.org/show_bug.cgi?id=15532
579
580         FindSafari simply prints the location of an installed Safari.exe on
581         stdout.
582
583         Reviewed by Darin.
584
585         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
586         (getStringValue):
587         (getWebViewCLSID):
588         (getInstalledWebKitDirectory):
589         (_tmain):
590         * FindSafari/FindSafari.vcproj: Added.
591         * Scripts/webkitdirs.pm:
592         (sub installedSafariPath): Added. Calls FindSafari on Windows.
593
594 2007-10-16  Adam Roben  <aroben@apple.com>
595
596         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
597
598         Reviewed by Kevin McCullough.
599
600         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
601         when referring to WebKit.dll.
602         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
603         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
604         * DumpRenderTree/win/release.vsprops: Ditto.
605         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
606         never have a _debug suffix on WebKit.dll.
607         * WebKitInitializer/WebKitInitializer.cpp:
608         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
609         specified.
610         * WebKitInitializer/debug_internal.vsprops: Added
611         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
612
613 2007-10-16  Darin Adler  <darin@apple.com>
614
615         Reviewed by Adele.
616
617         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
618         Remove now-unneeded control/alt key hack; the tests have been updated.
619
620 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
621
622         - Updated leaks list because our internal bot upgraded it's version of leopard and 
623         one of the leaks was fixed between that revision and the bot's previous version of
624         leopard.
625
626         * Scripts/run-webkit-tests:
627
628 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
629
630         Reviewed by Tim.
631
632         - I encapsulated out the server connecton functionality because it is a specific part
633         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
634         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
635         Windows.  So the majority of this patch is moving preexisting functionality.
636
637         - Also I removed the prefix header and changed to use config.h because it is more
638         standard on how we use config.h in windows and it didn't make much sense to keep
639         the prefix header and the config.h
640
641         * Drosera/DebuggerDocument.cpp:
642         (DebuggerDocument::DebuggerDocument):
643         * Drosera/DebuggerDocument.h:
644         * Drosera/config.h:
645         * Drosera/mac/DebuggerApplication.mm:
646         (-[DebuggerApplication attach:]):
647         * Drosera/mac/DebuggerClient.h:
648         * Drosera/mac/DebuggerClient.mm:
649         (-[DebuggerClient initWithServerConnection:]):
650         (-[DebuggerClient dealloc]):
651         (-[DebuggerClient windowDidLoad]):
652         (-[DebuggerClient windowWillClose:]):
653         (-[DebuggerClient webView:didFinishLoadForFrame:]):
654         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
655         * Drosera/mac/DebuggerDocumentPlatform.mm:
656         (DebuggerDocument::platformPause):
657         (DebuggerDocument::platformResume):
658         (DebuggerDocument::platformStepInto):
659         (DebuggerDocument::platformEvaluateScript):
660         (DebuggerDocument::getPlatformCurrentFunctionStack):
661         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
662         (DebuggerDocument::platformValueForScopeVariableNamed):
663         (DebuggerDocument::platformLog):
664         * Drosera/mac/Drosera.pch: Removed.
665         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
666         * Drosera/mac/ServerConnection.h: Added.
667         * Drosera/mac/ServerConnection.mm: Added.
668         (-[ServerConnection initWithServerName:]):
669         (-[ServerConnection dealloc]):
670         (-[ServerConnection setGlobalContext:]):
671         (-[ServerConnection pause]):
672         (-[ServerConnection resume]):
673         (-[ServerConnection stepInto]):
674         (-[ServerConnection switchToServerNamed:]):
675         (-[ServerConnection applicationTerminating:]):
676         (-[ServerConnection serverConnectionDidDie:]):
677         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
678         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
679         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
680         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
681         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
682         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
683         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
684         (-[ServerConnection currentFrame]):
685         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
686         (-[ServerConnection knownServers]):
687
688 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
689
690         Reviewed by Eric.
691
692         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
693           Script to automatically search nightly builds for regressions (bisect-builds)
694
695         * Scripts/bisect-builds: Added.
696
697 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
698
699         Reviewed by Darin.
700
701         - New JavaScript benchmark
702         http://bugs.webkit.org/show_bug.cgi?id=15515
703
704         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
705         current development or release build of JavaScriptCore.
706
707 2007-10-15  Mark Rowe  <mrowe@apple.com>
708
709         Reviewed by Sam.
710
711         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
712
713         * Scripts/webkitdirs.pm:
714         - Change checkArgv to remove the options from @ARGV to prevent
715         them from interfering with further option processing.
716         - Fix logic error in determineIsQt that would prevent it from bailing out early.
717         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
718         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
719         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
720
721 2007-10-15  Darin Adler  <darin@apple.com>
722
723         Reviewed by Sam.
724
725         - added logging of window.prompt and window.confirm
726
727         * DumpRenderTree/mac/UIDelegate.mm:
728         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
729         Implement the recommended delegate rather than the deprecated one.
730         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
731         Added.
732         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
733         Added.
734
735         * DumpRenderTree/win/UIDelegate.h:
736         * DumpRenderTree/win/UIDelegate.cpp:
737         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
738         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
739         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
740         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
741
742 2007-10-15  Alice Liu  <alice.liu@apple.com>
743
744         Reviewed by Sam Weinig.
745
746         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
747
748         * DumpRenderTree/win/DumpRenderTree.cpp:
749         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
750         (main): allocate the global policy delegate for DRT's custom use
751         * DumpRenderTree/win/DumpRenderTree.vcproj:
752         Adding files to project
753         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
754         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
755         (LayoutTestController::setCustomPolicyDelegate):
756         set the webview's policy delegate to DRT's custom one if the test requests it.
757         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
758         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
759         (PolicyDelegate::PolicyDelegate):
760         (PolicyDelegate::QueryInterface):
761         (PolicyDelegate::AddRef):
762         (PolicyDelegate::Release):
763         (PolicyDelegate::decidePolicyForNavigationAction):
764         * DumpRenderTree/win/PolicyDelegate.h: Added.
765         (PolicyDelegate::decidePolicyForNewWindowAction):
766         (PolicyDelegate::decidePolicyForMIMEType):
767         (PolicyDelegate::unableToImplementPolicyWithError):
768
769 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
770
771         Reviewed by Mark.
772
773         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
774         when querying for QMAKE_MKSPECS.
775
776 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
777
778         Reviewed by Adam Roben.
779         
780         Fix run-webkit-tests is too greedy calculating platform hierarchy
781         http://bugs.webkit.org/show_bug.cgi?id=15465
782         
783         Fix run-webkit-tests being too greedy in trying to split the platform name up
784         causing it to try and find tests in every directory above the first "-" in the
785         path to the LayoutTests
786
787         * Scripts/run-webkit-tests:
788
789 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
790
791         Reviewed by Darin.
792
793         http://bugs.webkit.org/show_bug.cgi?id=15006
794         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
795         to reduce code duplication.
796
797         * Scripts/build-webkit:
798         * Scripts/webkitdirs.pm:
799         buildQMakeProject() renamed to buildQMakeQtProject().
800         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
801         unused $colorize has been removed.
802
803 === Start merge of feature-branch 2007-10-12 ===
804
805 2007-10-08  Eric Seidel  <eric@webkit.org>
806
807         Reviewed by Mark Rowe.
808
809         * Scripts/build-webkit: add --help, remove unused --color
810
811 2007-10-07  Eric Seidel  <eric@webkit.org>
812
813         Reviewed by darin.
814
815         * Drosera/mac/DebuggerDocumentPlatform.mm:
816         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
817
818 2007-10-03  Rob Buis  <buis@kde.org>
819
820         Reviewed by Olliej.
821
822         Adapt to changed location of Ahem font.
823
824         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
825
826 2007-10-02  Eric Seidel  <eric@webkit.org>
827
828         Reviewed by Adam Roben.
829         
830         Make pixel tests more useful!
831         Finally fix the image diff 0.00% mystery problem
832         Highlight any image differences in the image diff.
833         Add a link from image diffs back to original test file.
834
835         * DumpRenderTree/mac/ImageDiff.m:
836         (compareImages): highlight any differences
837         (computePercentageDifferent): round to two decimal places
838         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
839
840 2007-10-02  Eric Seidel  <eric@webkit.org>
841
842         Reviewed by Alexey Proskuryakov.
843
844         * Scripts/run-webkit-tests: print the % image difference on main results page
845
846 2007-10-02  Mark Rowe  <mrowe@apple.com>
847
848         Reviewed by Oliver.
849
850         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
851
852         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
853         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
854
855 2007-10-01  Mark Rowe  <mrowe@apple.com>
856
857         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
858
859 2007-09-25  Eric Seidel  <eric@webkit.org>
860
861         Reviewed by Mark Rowe.
862         
863         DerivedSources.make was finding "ENABLE_SVG" in the string
864         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
865         quite correctly.
866
867         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
868
869 2007-09-25  Mark Rowe  <mrowe@apple.com>
870
871         Rubber-stamped by Eric.
872
873         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
874         This makes it possible to automate nightly builds for the feature-branch.
875
876 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
877
878         Rubber stamped by Mark.
879
880         Enable svg experimental features as default here in feature-branch.
881
882         * Scripts/build-webkit:
883
884 2007-06-29  Antti Koivisto  <antti@apple.com>
885
886         Reviewed by Weinig.
887         
888         Add VIDEO flag for timed media features
889
890         * Scripts/build-webkit
891         
892 === End merge of feature-branch 2007-10-12 ===
893
894 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
895
896         Reviewed by Darin.
897
898         - Updated rational for the leaks list to be more clear.
899
900         * Scripts/run-webkit-tests:
901
902 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
903
904         Rubber Stamp by Sam.
905
906         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
907         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
908
909         * Scripts/run-webkit-tests:
910
911 2007-10-10  Simon Hausmann  <hausmann@kde.org>
912
913         Reviewed by Lars.
914
915         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
916         includes are needed for INT_MAX, std::auto_ptr and the like.
917
918         * DumpRenderTree/qt/main.cpp:
919
920 2007-10-09  Lars Knoll  <lars@trolltech.com>
921
922         Reviewed by Simon.
923
924         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
925
926         * DumpRenderTree/qt/jsobjects.cpp:
927         (LayoutTestController::encodeHostName):
928         (LayoutTestController::decodeHostName):
929         * DumpRenderTree/qt/jsobjects.h:
930
931 2007-10-09  Lars Knoll  <lars@trolltech.com>
932
933         Reviewed by Simon.
934
935         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
936
937         * DumpRenderTree/qt/DumpRenderTree.cpp:
938         (WebCore::WebPage::createFrame):
939         (WebCore::DumpRenderTree::DumpRenderTree):
940         (WebCore::DumpRenderTree::titleChanged):
941         * DumpRenderTree/qt/DumpRenderTree.h:
942         * DumpRenderTree/qt/jsobjects.cpp:
943         (LayoutTestController::reset):
944         * DumpRenderTree/qt/jsobjects.h:
945
946 2007-10-09  Lars Knoll  <lars@trolltech.com>
947
948         Reviewed by Simon.
949
950         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
951
952         * DumpRenderTree/qt/DumpRenderTree.h:
953         * DumpRenderTree/qt/jsobjects.cpp:
954         (LayoutTestController::clearBackForwardList):
955         * DumpRenderTree/qt/jsobjects.h:
956
957 2007-10-09  Lars Knoll  <lars@trolltech.com>
958
959         Reviewed by Simon.
960
961         make --git-reviewer work again.
962
963         * Scripts/prepare-ChangeLog:
964
965 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
966
967         Rubber stamped by Eric.
968
969         Connect to the "hovering-over-link" signal emitted by WebKitPage and
970         show the current link inside the statusbar.
971         This shows how to make use of this signal and allows to easily test
972         http://bugs.webkit.org/show_bug.cgi?id=15299.
973
974         * GtkLauncher/main.cpp:
975         (hoveringOverLink):
976         (main):
977
978 2007-10-05  Lars Knoll  <lars@trolltech.com>
979
980         add proper error messages to the FrameLoaderClient.
981         Implement ChromeClientQt::closeWindowSoon and
982         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
983         Some fixes in DRT to make it work correctly with multiple windows.
984
985         Reviewed by Maciej.
986
987         * DumpRenderTree/qt/DumpRenderTree.cpp:
988         (WebCore::DumpRenderTree::DumpRenderTree):
989         (WebCore::DumpRenderTree::createWindow):
990         (WebCore::DumpRenderTree::windowCount):
991         * DumpRenderTree/qt/DumpRenderTree.h:
992         * DumpRenderTree/qt/jsobjects.cpp:
993         (LayoutTestController::maybeDump):
994         (LayoutTestController::windowCount):
995         * DumpRenderTree/qt/jsobjects.h:
996
997 2007-10-05  Lars Knoll  <lars@trolltech.com>
998
999         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
1000         Add support for layoutTextController.setCanOpenWindows() to DRT
1001         fixing another 2 test cases in fast/dom/Window.
1002
1003         Reviewed by Maciej.
1004
1005         * DumpRenderTree/qt/DumpRenderTree.cpp:
1006         (WebCore::WebPage::WebPage):
1007         (WebCore::WebPage::createWindow):
1008         (WebCore::DumpRenderTree::resetJSObjects):
1009         (WebCore::DumpRenderTree::createWindow):
1010         * DumpRenderTree/qt/DumpRenderTree.h:
1011         * DumpRenderTree/qt/DumpRenderTree.pro:
1012         * DumpRenderTree/qt/jsobjects.cpp:
1013         (LayoutTestController::LayoutTestController):
1014         (LayoutTestController::reset):
1015         * DumpRenderTree/qt/jsobjects.h:
1016         * DumpRenderTree/qt/main.cpp:
1017         * DumpRenderTree/qt/testplugin.cpp: Added.
1018         * DumpRenderTree/qt/testplugin.h: Added.
1019
1020 2007-10-04  Sam Weinig  <sam@webkit.org>
1021
1022         Rubber stamped by Adam.
1023
1024         Remove empty directories.
1025
1026         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
1027         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
1028
1029 2007-10-03  Darin Adler  <darin@apple.com>
1030
1031         Reviewed by Adam.
1032
1033         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
1034         we find the internal libraries in the libraries directory. This
1035         is helpful for Safari team engineers at Apple.
1036
1037 2007-10-03  Adam Roben  <aroben@apple.com>
1038
1039         Update the location of AHEM___.TTF after r25968
1040
1041         Reviewed by Sam.
1042
1043         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1044
1045 2007-10-03  Alp Toker  <alp@atoker.com>
1046
1047         Reviewed by Adam.
1048
1049         http://bugs.webkit.org/show_bug.cgi?id=14726
1050         [gtk] API design. Mapping the WebView delegates to signals.
1051
1052         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
1053
1054         * GtkLauncher/main.cpp:
1055         (goToURLBarText):
1056         (titleChanged):
1057         (progressChanged):
1058         (menuMainBackCallback):
1059         (menuMainForwardCallback):
1060         (main):
1061
1062 2007-10-03  Lars Knoll  <lars@trolltech.com>
1063
1064         Reviewed by Rob.
1065
1066         This fixes --strict mode in run-webkit-tests again after
1067         the platform dependent test results have been moved.
1068
1069         * Scripts/run-webkit-tests:
1070
1071 2007-10-03  Lars Knoll  <lars@trolltech.com>
1072
1073         Reviewed by bdash.
1074
1075         remove the hack in run-webkit-tests that forced text only test
1076         to be taken from the platform independent dir. It was only left
1077         there from early days.
1078         
1079         Remove platform dependent results for tests that are text only nowadays,
1080         and add one platform dependent result for a text only test that requires it.
1081
1082         * Scripts/run-webkit-tests:
1083
1084 2007-10-03  Lars Knoll  <lars@trolltech.com>
1085
1086         Reviewed by olliej.
1087
1088         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
1089
1090         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
1091         (WebCore::WebFrame::WebFrame):
1092         (WebCore::WebPage::WebPage):
1093         (WebCore::WebPage::createFrame):
1094         (WebCore::WebPage::javaScriptAlert):
1095         (WebCore::WebPage::javaScriptConsoleMessage):
1096         (WebCore::DumpRenderTree::DumpRenderTree):
1097         (WebCore::DumpRenderTree::~DumpRenderTree):
1098         (WebCore::DumpRenderTree::open):
1099         (WebCore::DumpRenderTree::readStdin):
1100         (WebCore::DumpRenderTree::resetJSObjects):
1101         (WebCore::DumpRenderTree::initJSObjects):
1102         (WebCore::DumpRenderTree::dumpFramesAsText):
1103         (WebCore::DumpRenderTree::dump):
1104         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
1105         (WebCore::DumpRenderTree::layoutTestController):
1106         (WebCore::DumpRenderTree::eventSender):
1107         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
1108         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
1109         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
1110         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
1111         (HackWebFrame::mousePressEvent):
1112         (HackWebFrame::mouseReleaseEvent):
1113         (HackWebFrame::mouseMoveEvent):
1114         (HackWebFrame::HackWebFrame):
1115         (HackWebFrame::~HackWebFrame):
1116         (LayoutTestController::LayoutTestController):
1117         (LayoutTestController::reset):
1118         (LayoutTestController::maybeDump):
1119         (LayoutTestController::waitUntilDone):
1120         (LayoutTestController::notifyDone):
1121         (LayoutTestController::dumpEditingCallbacks):
1122         (LayoutTestController::queueReload):
1123         (LayoutTestController::provisionalLoad):
1124         (LayoutTestController::timerEvent):
1125         (EventSender::EventSender):
1126         (EventSender::mouseDown):
1127         (EventSender::mouseUp):
1128         (EventSender::mouseMoveTo):
1129         (EventSender::leapForward):
1130         (EventSender::keyDown):
1131         (EventSender::frameUnderMouse):
1132         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
1133         (LayoutTestController::isLoading):
1134         (LayoutTestController::setLoading):
1135         (LayoutTestController::shouldDumpAsText):
1136         (LayoutTestController::shouldDumpChildrenAsText):
1137         (LayoutTestController::shouldWaitUntilDone):
1138         (LayoutTestController::dumpAsText):
1139         (LayoutTestController::dumpChildFramesAsText):
1140         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
1141         (messageHandler):
1142         (crashHandler):
1143         (main):
1144         * Scripts/run-webkit-tests:
1145
1146 2007-10-03  Mark Rowe  <mrowe@apple.com>
1147
1148         Reviewed by Alp Toker.
1149
1150         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
1151         should take precedence over QTDIR when determining which port we are working with.
1152
1153         * Scripts/webkitdirs.pm: 
1154
1155 2007-10-02  Adam Roben  <aroben@apple.com>
1156
1157         Add keychain to the list of default packages to install
1158
1159         Rubberstamped by Sam.
1160
1161         * CygwinDownloader/cygwin-downloader.py:
1162         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
1163
1164 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
1165
1166         Reviewed by Adam.
1167
1168         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
1169         Also makes WebCore regression test case logic work when using git.
1170
1171         * Scripts/prepare-ChangeLog:
1172         (reviewerAndDescriptionForGitCommit): Added.
1173
1174 2007-10-02  Lars Knoll  <lars@trolltech.com>
1175
1176         Reviewed by bdash.
1177
1178         Add API to retrieve the frame name from QWebFrame.
1179         Implement support for DRT::dumpChildrenAsText.
1180
1181         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
1182         (WebCore::DumpRenderTree::dumpFramesAsText):
1183         (WebCore::DumpRenderTree::dump):
1184         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
1185         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
1186         (LayoutTestController::LayoutTestController):
1187         (LayoutTestController::reset):
1188         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
1189
1190 2007-10-02  Lars Knoll  <lars@trolltech.com>
1191
1192         Reviewed by bdash.
1193
1194         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
1195
1196         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
1197         (WebCore::DumpRenderTree::readStdin):
1198
1199 2007-10-02  Mark Rowe  <mrowe@apple.com>
1200
1201         Reviewed by Oliver.
1202
1203         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
1204
1205         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
1206         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
1207
1208 2007-10-02  Mark Rowe  <mrowe@apple.com>
1209
1210         Rubber-stamped by Maciej.
1211
1212         Configuration changes from build.webkit.org.  The major change is refactoring to work
1213         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
1214         last few weeks.
1215
1216         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1217         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
1218         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
1219         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
1220         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
1221         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
1222         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
1223         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
1224
1225 2007-10-02  Lars Knoll  <lars@trolltech.com>
1226
1227         Reviewed by Maciej.
1228
1229         Add support for eventSender.mouseMove to DRT.
1230         Fixes fast/css/hover-affects-child.html
1231
1232         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
1233         (EventSender::mouseMoveTo):
1234
1235 2007-10-01  Mark Rowe  <mrowe@apple.com>
1236
1237         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
1238
1239 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
1240
1241         Reviewed by Hyatt.
1242
1243         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
1244
1245         * Scripts/svn-apply:
1246         (gitdiff2svndiff): Ignore lines beginning with "new file".
1247         * Scripts/svn-unapply:
1248         (gitdiff2svndiff): Ditto.
1249
1250 2007-09-30  George Staikos  <staikos@kde.org>
1251
1252         Qt build fix (Mac OS X specific)
1253
1254         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
1255
1256 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
1257
1258         Reviewed by Mark.
1259
1260         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
1261         Remove Bakefiles from svn.
1262
1263         * GtkLauncher/Bakefiles.bkgen: Removed.
1264         * GtkLauncher/ENV: Removed.
1265         * GtkLauncher/gdklauncher.bkl: Removed.
1266         * GtkLauncher/mk: Removed.
1267         * Scripts/regenerate-makefiles: Removed.
1268
1269 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
1270
1271         Reviewed by John.
1272
1273         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
1274
1275         * Scripts/run-webkit-tests:
1276
1277 2007-09-26  Adam Roben  <aroben@apple.com>
1278
1279         Make not finding an installed WebKit non-fatal
1280
1281         What really matters is that we are able to load WebKit and its
1282         dependencies, not whether we think we've found an installed WebKit.
1283
1284         Reviewed by Sam.
1285
1286         * WebKitInitializer/WebKitInitializer.cpp:
1287         (getWebViewCLSID): Use new LOG_WARNING macro.
1288         (getInstalledWebKitDirectory): Ditto.
1289         (initializeWebKit): Don't die if we didn't find an installed WebKit,
1290         and use new macros.
1291         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
1292
1293 2007-09-26  Adam Roben  <aroben@apple.com>
1294
1295         Committed this file before saving it
1296
1297         * WebKitInitializer/debug_internal.vsprops:
1298
1299 2007-09-26  Adam Roben  <aroben@apple.com>
1300
1301         Load WebKit and its dependencies manually so they come from DllDirectory
1302
1303         I had to change WebKitInitializer to use malloc/free instead of
1304         new/delete to avoid pulling in WebKit (and its dependencies) early
1305         through use of fastMalloc.
1306
1307         Reviewed by Oliver.
1308
1309         * WebKitInitializer/WebKitInitializer.cpp:
1310         (getStringValue): Changed to use malloc/free.
1311         (getInstalledWebKitDirectory): Ditto.
1312         (initializeWebKit): Call SetDllDirectory first, then load all of
1313         WebKit's dependencies manually, finally followed by WebKit itself.
1314         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
1315         configuration to match our other projects.
1316         * WebKitInitializer/debug_internal.vsprops: Added.
1317
1318 2007-09-25  Adam Roben  <aroben@apple.com>
1319
1320         Actually define DEBUG/NDEBUG so that we load WebKit correctly
1321
1322         Rubberstamped by Sam.
1323
1324         * WebKitInitializer/WebKitInitializer.vcproj:
1325
1326 2007-09-25  Adam Roben  <aroben@apple.com>
1327
1328         Make DumpRenderTree delay-load its dependencies
1329
1330         This lets WebKitInitializer re-route the dependencies to be loaded out
1331         of the Safari installation directory.
1332
1333         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
1334         same thing), since we can't import the kCFAllocatorDefault symbol when
1335         delay-loading CoreFoundation.dll.
1336
1337         Rubberstamped by Sam.
1338
1339         * DumpRenderTree/win/DumpRenderTree.cpp:
1340         (runTest):
1341         (javaScriptThreads):
1342         * DumpRenderTree/win/DumpRenderTree.vcproj:
1343         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1344         (LayoutTestController::setWaitToDump):
1345
1346 2007-09-25  Adam Roben  <aroben@apple.com>
1347
1348         Pull ole32.lib into WebKitInitializer
1349
1350         Rubberstamped by Sam.
1351
1352         * WebKitInitializer/WebKitInitializer.vcproj:
1353
1354 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
1355
1356         Reviewed by Adam.
1357
1358         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
1359           LGPL'ed files contain incorrect FSF address
1360
1361         * Drosera/config.h:
1362
1363 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
1364
1365         Reviewed by Adam.
1366
1367         Make svn-apply and svn-unapply work with git-diff formatted patches.
1368
1369         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
1370         (gitdiff2svndiff): Added.
1371         * Scripts/svn-unapply: Ditto.
1372         (gitdiff2svndiff): Added.
1373
1374 2007-09-25  Adam Roben  <aroben@apple.com>
1375
1376         Pull advapi32.lib into WebKitInitializer
1377
1378         This is needed to get the registry functions we use.
1379
1380         Rubberstamped by Sam.
1381
1382         * WebKitInitializer/WebKitInitializer.vcproj:
1383
1384 2007-09-25  Adam Roben  <aroben@apple.com>
1385
1386         Add python and rsync to cygwin-downloader
1387
1388         Our build slaves need this, and it can't hurt for everyone else to
1389         have it, too.
1390
1391         Reviewed by Sam.
1392
1393         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
1394         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
1395
1396 2007-09-25  Adam Roben  <aroben@apple.com>
1397
1398         Add WebKitInitializer and use it in DumpRenderTree
1399
1400         WebKitInitializer is a static library that has one function,
1401         initializeWebKit(). This registers WebKit and sets up the DLL search
1402         path so that WebKit's dependencies that are installed with Safari can
1403         be found.
1404
1405         Reviewed by Sam.
1406
1407         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
1408         DumpRenderTree depend on it.
1409         * DumpRenderTree/win/DumpRenderTree.cpp:
1410         (initialize): Call initializeWebKit.
1411         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
1412         WebKitInitializer.lib.
1413         * WebKitInitializer/WebKitInitializer.cpp: Added.
1414         (getStringValue):
1415         (getWebViewCLSID):
1416         (getInstalledWebKitDirectory):
1417         (initializeWebKit):
1418         * WebKitInitializer/WebKitInitializer.h: Added.
1419         * WebKitInitializer/WebKitInitializer.vcproj: Added.
1420         * WebKitInitializer/debug.vsprops: Added.
1421         * WebKitInitializer/release.vsprops: Added.
1422
1423 2007-09-25  Adam Roben  <aroben@apple.com>
1424
1425         Make run-webkit-tests respect set-webkit-configuration
1426
1427         Reviewed by Sam.
1428
1429         * Scripts/run-webkit-tests: Initialize $configuration to whatever
1430         set-webkit-configuration was last set to.
1431
1432 2007-09-25  Mark Rowe  <mrowe@apple.com>
1433
1434         Rubber-stamped by Eric.
1435
1436         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
1437         This makes it possible to automate nightly builds for the feature-branch.
1438
1439 2007-09-25  Adam Roben  <aroben@apple.com>
1440
1441         A couple of fixes/enhancements to update-webkit-*-libs
1442
1443         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
1444         to tell update-webkit-support-libraries where it should find the
1445         WebKitSupportLibrary.zip file you downloaded.
1446
1447         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
1448         Windows-style path.
1449
1450         Reviewed by Sam.
1451
1452         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
1453         to $auxiliaryLibsURL and removed an irrelevant comment.
1454         * Scripts/update-webkit-support-libs:
1455
1456 2007-09-25  Adam Treat  <treat@kde.org>
1457
1458         Reviewed by Simon and Lars.
1459
1460         Refactors and cleans up Qt DRT member variable names, member variable
1461         initialization, style fixes and general code cleanup.
1462
1463         Adds queueReload slot to LayoutTestController that some tests require.
1464
1465         Subclasses QWebFrame to make sure that all frames have an associated
1466         LayoutTestController JS window object.
1467
1468         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
1469         aren't dumped twice.
1470
1471         EOF fixes.
1472
1473         Together, this patch fixes some 20+ layout tests in QtWebKit.
1474
1475         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
1476         (WebCore::WebFrame::WebFrame):
1477         (WebCore::WebPage::WebPage):
1478         (WebCore::WebPage::createFrame):
1479         (WebCore::DumpRenderTree::DumpRenderTree):
1480         (WebCore::DumpRenderTree::open):
1481         (WebCore::DumpRenderTree::readStdin):
1482         (WebCore::DumpRenderTree::initJSObjects):
1483         (WebCore::DumpRenderTree::dump):
1484         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
1485         (WebCore::DumpRenderTree::layoutTestController):
1486         (WebCore::DumpRenderTree::eventSender):
1487         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
1488         (LayoutTestController::LayoutTestController):
1489         (LayoutTestController::reset):
1490         (LayoutTestController::maybeDump):
1491         (LayoutTestController::waitUntilDone):
1492         (LayoutTestController::notifyDone):
1493         (LayoutTestController::queueReload):
1494         (LayoutTestController::provisionalLoad):
1495         (EventSender::EventSender):
1496         (EventSender::mouseDown):
1497         (EventSender::mouseUp):
1498         (EventSender::mouseMoveTo):
1499         (EventSender::frameUnderMouse):
1500         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
1501         (LayoutTestController::isLoading):
1502         (LayoutTestController::setLoading):
1503         (LayoutTestController::dumpAsText):
1504         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
1505         (main):
1506
1507 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
1508
1509
1510         - Reverted an accidentally checked in file.
1511
1512         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
1513
1514 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
1515         Reviewed by Sam.
1516
1517         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
1518
1519         * DumpRenderTree/win/DumpRenderTree.vcproj:
1520         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1521
1522 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
1523
1524         Rubber stamped by Adam.
1525
1526         * GdkLauncher: Removed.
1527         * GdkLauncher/Bakefiles.bkgen: Removed.
1528         * GdkLauncher/ENV: Removed.
1529         * GdkLauncher/GdkLauncher.pro: Removed.
1530         * GdkLauncher/gdklauncher.bkl: Removed.
1531         * GdkLauncher/main.cpp: Removed.
1532         * GdkLauncher/mk: Removed.
1533         * GdkLauncher/simple.svg: Removed.
1534         * GdkLauncher/text.html: Removed.
1535         * GtkLauncher: Added.
1536         * GtkLauncher/GdkLauncher.pro: Removed.
1537         * GtkLauncher/GtkLauncher.pro: Added.
1538         * GtkLauncher/main.cpp:
1539         (updateWindowTitle):
1540         (main):
1541         * Scripts/build-webkit:
1542         * Scripts/regenerate-makefiles:
1543         * Scripts/run-javascriptcore-tests:
1544         * Scripts/run-launcher:
1545         * Scripts/run-webkit-tests:
1546         * Scripts/webkitdirs.pm:
1547
1548 2007-09-21  Timothy Hatcher  <timothy@apple.com>
1549
1550         Reviewed by Darin.
1551
1552         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
1553
1554         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
1555         This is tested by plugins/root-object-premature-delete-crash.html.
1556
1557         * DumpRenderTree/mac/ObjCController.m:
1558         (-[ObjCController accessStoredWebScriptObject]):
1559
1560 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
1561
1562         Reviewed by Oliver.
1563
1564         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
1565
1566         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
1567         (FrameLoadDelegate::FrameLoadDelegate):
1568
1569 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
1570
1571         Reviewed by Adam.
1572
1573         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
1574         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
1575
1576         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
1577         Now isQt() and isGdk() use global variables that are only set once.
1578
1579         An array of all the parameters is now given to build-dumprender which includes
1580         the platform on linux.
1581
1582         * Scripts/build-dumprendertree:
1583         * Scripts/run-webkit-tests:
1584         * Scripts/webkitdirs.pm:
1585
1586 2007-09-19  Adam Roben  <aroben@apple.com>
1587
1588         Rubberstamped by Hyatt.
1589
1590         * Spinneret: Removed.
1591
1592 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
1593
1594         Reviewed by David Kilzer.
1595
1596         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
1597
1598 2007-09-18  Sam Weinig  <sam@webkit.org>
1599
1600         Add JSRetainPtr.h #include to fix some builds.
1601
1602         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1603
1604 2007-09-18  Mike Hommey  <glandium@debian.org>
1605
1606         Reviewed by Adam.
1607
1608         * Scripts/prepare-ChangeLog:
1609         - Properly parse GECOS field.
1610         - Use git configuration for user name and email when appropriate.
1611
1612 2007-09-17  Sam Weinig  <sam@webkit.org>
1613
1614         Build fix.
1615
1616         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1617
1618 2007-09-17  Sam Weinig  <sam@webkit.org>
1619
1620         Reviewed by Adam Roben.
1621
1622         Share more code between mac and windows DRT.
1623             - GCController is now shared.
1624             - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
1625
1626         * DumpRenderTree/GCController.cpp:
1627         * DumpRenderTree/win/DumpRenderTree.cpp:
1628         * DumpRenderTree/win/DumpRenderTree.vcproj:
1629         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
1630         (FrameLoadDelegate::FrameLoadDelegate):
1631         (FrameLoadDelegate::~FrameLoadDelegate):
1632         (FrameLoadDelegate::windowScriptObjectAvailable):
1633         * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
1634         * DumpRenderTree/win/GCController.cpp: Removed.
1635         * DumpRenderTree/win/GCController.h: Removed.
1636         * DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp.
1637         (GCController::collect):
1638         (GCController::collectOnAlternateThread):
1639         (GCController::getJSObjectCount):
1640         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
1641         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
1642
1643 2007-09-17  Sam Weinig  <sam@webkit.org>
1644
1645         Reviewed by Adam Roben.
1646
1647         Begin sharing code between mac and windows DRT.
1648             - both now share LayoutTestController.h/cpp and implement platform dependant 
1649               operations in LayoutTestControllerMac/Win.
1650             - DumpRenderTree.h is now shared.
1651             - WorkQueue and WorkQueueItem are also shared.
1652
1653         * DumpRenderTree/DumpRenderTree.h:
1654         * DumpRenderTree/LayoutTestController.cpp:
1655         * DumpRenderTree/win/DumpRenderTree.cpp:
1656         (displayWebView):
1657         (dumpFrameScrollPosition):
1658         (dumpFramesAsText):
1659         (dump):
1660         (runTest):
1661         * DumpRenderTree/win/DumpRenderTree.h: Removed.
1662         * DumpRenderTree/win/DumpRenderTree.vcproj:
1663         * DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
1664         * DumpRenderTree/win/EditingDelegate.cpp:
1665         (EditingDelegate::shouldBeginEditingInDOMRange):
1666         (EditingDelegate::shouldEndEditingInDOMRange):
1667         (EditingDelegate::shouldInsertNode):
1668         (EditingDelegate::shouldInsertText):
1669         (EditingDelegate::shouldDeleteDOMRange):
1670         (EditingDelegate::shouldChangeSelectedDOMRange):
1671         (EditingDelegate::shouldApplyStyle):
1672         (EditingDelegate::shouldChangeTypingStyle):
1673         (EditingDelegate::doPlatformCommand):
1674         (EditingDelegate::webViewDidBeginEditing):
1675         (EditingDelegate::webViewDidChange):
1676         (EditingDelegate::webViewDidEndEditing):
1677         (EditingDelegate::webViewDidChangeTypingStyle):
1678         (EditingDelegate::webViewDidChangeSelection):
1679         * DumpRenderTree/win/LayoutTestController.cpp: Removed.
1680         * DumpRenderTree/win/LayoutTestController.h: Removed.
1681         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Copied from DumpRenderTree/win/LayoutTestController.cpp.
1682         (LayoutTestController::addDisallowedURL):
1683         (LayoutTestController::clearBackForwardList):
1684         (LayoutTestController::copyDecodedHostName):
1685         (LayoutTestController::copyEncodedHostName):
1686         (LayoutTestController::display):
1687         (LayoutTestController::keepWebHistory):
1688         (LayoutTestController::notifyDone):
1689         (LayoutTestController::queueBackNavigation):
1690         (LayoutTestController::queueForwardNavigation):
1691         (jsStringRefToWString):
1692         (LayoutTestController::queueLoad):
1693         (LayoutTestController::queueReload):
1694         (LayoutTestController::queueScript):
1695         (LayoutTestController::setAcceptsEditing):
1696         (LayoutTestController::setCustomPolicyDelegate):
1697         (LayoutTestController::setMainFrameIsFirstResponder):
1698         (LayoutTestController::setTabKeyCyclesThroughElements):
1699         (LayoutTestController::setUseDashboardCompatibilityMode):
1700         (LayoutTestController::setUserStyleSheetEnabled):
1701         (LayoutTestController::setUserStyleSheetLocation):
1702         (LayoutTestController::setWindowIsKey):
1703         (waitUntilDoneWatchdogFired):
1704         (LayoutTestController::setWaitToDump):
1705         (LayoutTestController::windowCount):
1706         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp:
1707         (FrameLoadDelegate::didReceiveTitle):
1708         (FrameLoadDelegate::processWork):
1709         (FrameLoadDelegate::locationChangeDone):
1710         (FrameLoadDelegate::windowScriptObjectAvailable):
1711         * DumpRenderTree/win/WorkQueue.cpp: Removed.
1712         * DumpRenderTree/win/WorkQueue.h: Removed.
1713         * DumpRenderTree/win/WorkQueueItem.cpp: Removed.
1714         * DumpRenderTree/win/WorkQueueItem.h: Removed.
1715         * DumpRenderTree/win/WorkQueueItemWin.cpp: Copied from DumpRenderTree/win/WorkQueueItem.cpp.
1716         (jsStringRefToWString):
1717         (LoadItem::invoke):
1718         (ScriptItem::invoke):
1719
1720 2007-09-17  Sam Weinig  <sam@webkit.org>
1721
1722         Reviewed by Adam Roben.
1723
1724         - Move Windows DumpRenderTree and TestNetscapePlugin to WebCoreTools/DumpRenderTree/win
1725
1726         * DumpRenderTree/DumpRenderTree.sln: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln.
1727         * DumpRenderTree/DumpRenderTree.vcproj: Removed.
1728         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Removed.
1729         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Removed.
1730         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h: Removed.
1731         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Removed.
1732         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Removed.
1733         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed.
1734         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: Removed.
1735         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: Removed.
1736         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: Removed.
1737         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h: Removed.
1738         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp: Removed.
1739         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h: Removed.
1740         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Removed.
1741         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Removed.
1742         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Removed.
1743         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Removed.
1744         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: Removed.
1745         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Removed.
1746         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp: Removed.
1747         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h: Removed.
1748         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: Removed.
1749         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: Removed.
1750         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops: Removed.
1751         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops: Removed.
1752         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops: Removed.
1753         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin: Removed.
1754         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
1755         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
1756         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
1757         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/main.c: Removed.
1758         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/resource.h: Removed.
1759         * DumpRenderTree/win: Added.
1760         * DumpRenderTree/win/DraggingInfo.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h.
1761         * DumpRenderTree/win/DumpRenderTree.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp.
1762         * DumpRenderTree/win/DumpRenderTree.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h.
1763         * DumpRenderTree/win/DumpRenderTree.vcproj: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj.
1764         * DumpRenderTree/win/EditingDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp.
1765         * DumpRenderTree/win/EditingDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h.
1766         * DumpRenderTree/win/EventSender.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp.
1767         * DumpRenderTree/win/EventSender.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h.
1768         * DumpRenderTree/win/GCController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp.
1769         * DumpRenderTree/win/GCController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h.
1770         * DumpRenderTree/win/LayoutTestController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp.
1771         * DumpRenderTree/win/LayoutTestController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h.
1772         * DumpRenderTree/win/TestNetscapePlugin: Copied from DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin.
1773         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1774         * DumpRenderTree/win/UIDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp.
1775         * DumpRenderTree/win/UIDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h.
1776         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp.
1777         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h.
1778         * DumpRenderTree/win/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
1779         * DumpRenderTree/win/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
1780         * DumpRenderTree/win/WorkQueueItem.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp.
1781         * DumpRenderTree/win/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
1782         * DumpRenderTree/win/debug.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops.
1783         * DumpRenderTree/win/debug_internal.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops.
1784         * DumpRenderTree/win/release.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops.
1785         * Scripts/run-webkit-tests: Update to point to the new location of the sln.
1786
1787 2007-09-15  Mark Rowe  <mrowe@apple.com>
1788
1789         Build fix for DumpRenderTree.
1790
1791         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Reinstate -Wno-deprecated-declarations on DumpRenderTree.mm.
1792
1793 2007-09-14  Sam Weinig  <sam@webkit.org>
1794
1795         Rubber stamped by Adam Roben.
1796
1797         Split the WaitUntilDoneDelegate into a UIDelegate and a FrameLoadDelegate.
1798           - The UIDelegate was put into a new file while the FrameLoadDelegate was
1799             kept in the WaitUntilDoneDelegate file for the time being.
1800
1801         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
1802         (main):
1803         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
1804         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Added.
1805         (UIDelegate::QueryInterface):
1806         (UIDelegate::AddRef):
1807         (UIDelegate::Release):
1808         (UIDelegate::hasCustomMenuImplementation):
1809         (UIDelegate::setFrame):
1810         (UIDelegate::webViewFrame):
1811         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1812         (UIDelegate::webViewAddMessageToConsole):
1813         (UIDelegate::doDragDrop):
1814         (UIDelegate::webViewGetDlgCode):
1815         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Added.
1816         (UIDelegate::UIDelegate):
1817         (UIDelegate::createWebViewWithRequest):
1818         (UIDelegate::webViewShow):
1819         (UIDelegate::webViewClose):
1820         (UIDelegate::webViewFocus):
1821         (UIDelegate::webViewUnfocus):
1822         (UIDelegate::webViewFirstResponder):
1823         (UIDelegate::makeFirstResponder):
1824         (UIDelegate::setStatusText):
1825         (UIDelegate::webViewStatusText):
1826         (UIDelegate::webViewAreToolbarsVisible):
1827         (UIDelegate::setToolbarsVisible):
1828         (UIDelegate::webViewIsStatusBarVisible):
1829         (UIDelegate::setStatusBarVisible):
1830         (UIDelegate::webViewIsResizable):
1831         (UIDelegate::setResizable):
1832         (UIDelegate::setContentRect):
1833         (UIDelegate::webViewContentRect):
1834         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1835         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1836         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
1837         (UIDelegate::runOpenPanelForFileButtonWithResultListener):
1838         (UIDelegate::mouseDidMoveOverElement):
1839         (UIDelegate::contextMenuItemsForElement):
1840         (UIDelegate::validateUserInterfaceItem):
1841         (UIDelegate::shouldPerformAction):
1842         (UIDelegate::dragDestinationActionMaskForDraggingInfo):
1843         (UIDelegate::willPerformDragDestinationAction):
1844         (UIDelegate::dragSourceActionMaskForPoint):
1845         (UIDelegate::willPerformDragSourceAction):
1846         (UIDelegate::contextMenuItemSelected):
1847         (UIDelegate::trackCustomPopupMenu):
1848         (UIDelegate::measureCustomMenuItem):
1849         (UIDelegate::drawCustomMenuItem):
1850         (UIDelegate::addCustomMenuDrawingData):
1851         (UIDelegate::cleanUpCustomMenuDrawingData):
1852         (UIDelegate::canTakeFocus):
1853         (UIDelegate::takeFocus):
1854         (UIDelegate::registerUndoWithTarget):
1855         (UIDelegate::removeAllActionsWithTarget):
1856         (UIDelegate::setActionTitle):
1857         (UIDelegate::undo):
1858         (UIDelegate::redo):
1859         (UIDelegate::canUndo):
1860         (UIDelegate::canRedo):
1861         (UIDelegate::webViewResizerRect):
1862         (UIDelegate::webViewDrawResizer):
1863         (UIDelegate::webViewScrolled):
1864         (UIDelegate::webViewShouldInterruptJavaScript):
1865         (UIDelegate::webViewReceivedFocus):
1866         (UIDelegate::webViewLostFocus):
1867         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
1868         (FrameLoadDelegate::QueryInterface):
1869         (FrameLoadDelegate::AddRef):
1870         (FrameLoadDelegate::Release):
1871         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
1872         (FrameLoadDelegate::didCommitLoadForFrame):
1873         (FrameLoadDelegate::didReceiveTitle):
1874         (FrameLoadDelegate::processWork):
1875         (processWorkTimer):
1876         (FrameLoadDelegate::locationChangeDone):
1877         (FrameLoadDelegate::didFinishLoadForFrame):
1878         (FrameLoadDelegate::didFailLoadWithError):
1879         (FrameLoadDelegate::windowScriptObjectAvailable):
1880         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h:
1881         (FrameLoadDelegate::FrameLoadDelegate):
1882
1883 2007-09-14  Sam Weinig  <sam@webkit.org>
1884
1885         Reviewed by Kevin McCullough.
1886
1887         Move mac specific globals in to mac/DumpRenderTreeMac.h
1888
1889         * DumpRenderTree/DumpRenderTree.h:
1890         * DumpRenderTree/DumpRenderTree.mm: Removed.
1891         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1892         * DumpRenderTree/mac/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.mm.
1893         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added.
1894
1895 2007-09-14  Brady Eidson  <beidson@apple.com>
1896
1897         Rubberstamped by Weinig
1898
1899         You know, Sam, some of us use case-sensitve filesystems...
1900
1901         * DumpRenderTree/DumpRenderTree.h:
1902         * DumpRenderTree/mac/UIDelegate.mm:
1903
1904 2007-09-14  Sam Weinig  <sam@webkit.org>
1905
1906         Rubber stamped by Adam Roben.
1907
1908         - Move dump state data to LayoutTestContoller and add getter/setters to accommodate.
1909         - Move mac specific DumpRenderTree files to DumpRenderTree/mac
1910
1911         * DumpRenderTree/AppleScriptController.h: Removed.
1912         * DumpRenderTree/AppleScriptController.m: Removed.
1913         * DumpRenderTree/DumpRenderTree.h:
1914         * DumpRenderTree/DumpRenderTree.mm:
1915         (startJavaScriptThreads):
1916         (stopJavaScriptThreads):
1917         (activateAhemFont):
1918         (setDefaultColorProfileToRGB):
1919         (makeLargeMallocFailSilently):
1920         (dumpFrameScrollPosition):
1921         (dumpFramesAsText):
1922         (dump):
1923         (runTest):
1924         (-[DumpRenderTreeWindow isKeyWindow]):
1925         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1926         * DumpRenderTree/DumpRenderTreeDraggingInfo.h: Removed.
1927         * DumpRenderTree/DumpRenderTreeDraggingInfo.m: Removed.
1928         * DumpRenderTree/EditingDelegate.h: Removed.
1929         * DumpRenderTree/EditingDelegate.m: Removed.
1930         * DumpRenderTree/EventSendingController.h: Removed.
1931         * DumpRenderTree/EventSendingController.m: Removed.
1932         * DumpRenderTree/FrameLoadDelegate.h: Removed.
1933         * DumpRenderTree/FrameLoadDelegate.mm: Removed.
1934         * DumpRenderTree/GCController.mm: Removed.
1935         * DumpRenderTree/ImageDiff.m: Removed.
1936         * DumpRenderTree/LayoutTestController.cpp:
1937         (LayoutTestController::LayoutTestController):
1938         (dumpAsTextCallback):
1939         (dumpBackForwardListCallback):
1940         (dumpChildFramesAsTextCallback):
1941         (dumpChildFrameScrollPositionsCallback):
1942         (dumpDOMAsWebArchiveCallback):
1943         (dumpEditingCallbacksCallback):
1944         (dumpFrameLoadCallbacksCallback):
1945         (dumpResourceLoadCallbacksCallback):
1946         (dumpSelectionRectCallback):
1947         (dumpSourceAsWebArchiveCallback):
1948         (dumpTitleChangesCallback):
1949         (repaintSweepHorizontallyCallback):
1950         (setCallCloseOnWebViewsCallback):
1951         (setCanOpenWindowsCallback):
1952         (setCloseRemainingWindowsWhenCompleteCallback):
1953         (testRepaintCallback):
1954         (addFileToPasteboardOnDragCallback):
1955         (waitUntilDoneCallback):
1956         * DumpRenderTree/LayoutTestController.h:
1957         (LayoutTestController::dumpAsText):
1958         (LayoutTestController::setDumpAsText):
1959         (LayoutTestController::dumpBackForwardList):
1960         (LayoutTestController::setDumpBackForwardList):
1961         (LayoutTestController::dumpChildFrameScrollPositions):
1962         (LayoutTestController::setDumpChildFrameScrollPositions):
1963         (LayoutTestController::dumpChildFramesAsText):
1964         (LayoutTestController::setDumpChildFramesAsText):
1965         (LayoutTestController::dumpDOMAsWebArchive):
1966         (LayoutTestController::setDumpDOMAsWebArchive):
1967         (LayoutTestController::dumpSelectionRect):
1968         (LayoutTestController::setDumpSelectionRect):
1969         (LayoutTestController::dumpSourceAsWebArchive):
1970         (LayoutTestController::setDumpSourceAsWebArchive):
1971         (LayoutTestController::dumpTitleChanges):
1972         (LayoutTestController::setDumpTitleChanges):
1973         (LayoutTestController::dumpEditingCallbacks):
1974         (LayoutTestController::setDumpEditingCallbacks):
1975         (LayoutTestController::dumpResourceLoadCallbacks):
1976         (LayoutTestController::setDumpResourceLoadCallbacks):
1977         (LayoutTestController::dumpFrameLoadCallbacks):
1978         (LayoutTestController::setDumpFrameLoadCallbacks):
1979         (LayoutTestController::addFileToPasteboardOnDrag):
1980         (LayoutTestController::setAddFileToPasteboardOnDrag):
1981         (LayoutTestController::callCloseOnWebViews):
1982         (LayoutTestController::setCallCloseOnWebViews):
1983         (LayoutTestController::canOpenWindows):
1984         (LayoutTestController::setCanOpenWindows):
1985         (LayoutTestController::closeRemainingWindowsWhenComplete):
1986         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
1987         (LayoutTestController::testRepaint):
1988         (LayoutTestController::setTestRepaint):
1989         (LayoutTestController::testRepaintSweepHorizontally):
1990         (LayoutTestController::setTestRepaintSweepHorizontally):
1991         (LayoutTestController::waitToDump):
1992         (LayoutTestController::windowIsKey):
1993         * DumpRenderTree/LayoutTestControllerMac.mm: Removed.
1994         * DumpRenderTree/NavigationController.h: Removed.
1995         * DumpRenderTree/NavigationController.m: Removed.
1996         * DumpRenderTree/ObjCController.h: Removed.
1997         * DumpRenderTree/ObjCController.m: Removed.
1998         * DumpRenderTree/ObjCPlugin.h: Removed.
1999         * DumpRenderTree/ObjCPlugin.m: Removed.
2000         * DumpRenderTree/ObjCPluginFunction.h: Removed.
2001         * DumpRenderTree/ObjCPluginFunction.m: Removed.
2002         * DumpRenderTree/PolicyDelegate.h: Removed.
2003         * DumpRenderTree/PolicyDelegate.m: Removed.
2004         * DumpRenderTree/ResourceLoadDelegate.h: Removed.
2005         * DumpRenderTree/ResourceLoadDelegate.m: Removed.
2006         * DumpRenderTree/TextInputController.h: Removed.
2007         * DumpRenderTree/TextInputController.m: Removed.
2008         * DumpRenderTree/UIDelegate.h: Removed.
2009         * DumpRenderTree/UIDelegate.mm: Removed.
2010         * DumpRenderTree/WorkQueueItemMac.mm: Removed.
2011         * DumpRenderTree/mac: Added.
2012         * DumpRenderTree/mac/AppleScriptController.h: Copied from DumpRenderTree/AppleScriptController.h.
2013         * DumpRenderTree/mac/AppleScriptController.m: Copied from DumpRenderTree/AppleScriptController.m.
2014         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.h.
2015         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.m.
2016         * DumpRenderTree/mac/EditingDelegate.h: Copied from DumpRenderTree/EditingDelegate.h.
2017         * DumpRenderTree/mac/EditingDelegate.mm: Copied from DumpRenderTree/EditingDelegate.m.
2018         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2019         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2020         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2021         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2022         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2023         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2024         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2025         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2026         (-[EditingDelegate webViewDidBeginEditing:]):
2027         (-[EditingDelegate webViewDidChange:]):
2028         (-[EditingDelegate webViewDidEndEditing:]):
2029         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2030         (-[EditingDelegate webViewDidChangeSelection:]):
2031         * DumpRenderTree/mac/EventSendingController.h: Copied from DumpRenderTree/EventSendingController.h.
2032         * DumpRenderTree/mac/EventSendingController.mm: Copied from DumpRenderTree/EventSendingController.m.
2033         * DumpRenderTree/mac/FrameLoadDelegate.h: Copied from DumpRenderTree/FrameLoadDelegate.h.
2034         * DumpRenderTree/mac/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.mm.
2035         (-[FrameLoadDelegate init]):
2036         (-[FrameLoadDelegate dealloc]):
2037         (-[FrameLoadDelegate processWork:]):
2038         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
2039         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2040         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2041         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2042         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2043         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2044         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2045         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2046         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2047         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2048         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2049         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2050         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2051         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2052         (-[FrameLoadDelegate webView:willCloseFrame:]):
2053         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2054         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2055         * DumpRenderTree/mac/GCControllerMac.mm: Copied from DumpRenderTree/GCController.mm.
2056         * DumpRenderTree/mac/ImageDiff.m: Copied from DumpRenderTree/ImageDiff.m.
2057         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Copied from DumpRenderTree/LayoutTestControllerMac.mm.
2058         (LayoutTestController::notifyDone):
2059         (LayoutTestController::setWindowIsKey):
2060         (LayoutTestController::setWaitToDump):
2061         * DumpRenderTree/mac/NavigationController.h: Copied from DumpRenderTree/NavigationController.h.
2062         * DumpRenderTree/mac/NavigationController.m: Copied from DumpRenderTree/NavigationController.m.
2063         * DumpRenderTree/mac/ObjCController.h: Copied from DumpRenderTree/ObjCController.h.
2064         * DumpRenderTree/mac/ObjCController.m: Copied from DumpRenderTree/ObjCController.m.
2065         * DumpRenderTree/mac/ObjCPlugin.h: Copied from DumpRenderTree/ObjCPlugin.h.
2066         * DumpRenderTree/mac/ObjCPlugin.m: Copied from DumpRenderTree/ObjCPlugin.m.
2067         * DumpRenderTree/mac/ObjCPluginFunction.h: Copied from DumpRenderTree/ObjCPluginFunction.h.
2068         * DumpRenderTree/mac/ObjCPluginFunction.m: Copied from DumpRenderTree/ObjCPluginFunction.m.
2069         * DumpRenderTree/mac/PolicyDelegate.h: Copied from DumpRenderTree/PolicyDelegate.h.
2070         * DumpRenderTree/mac/PolicyDelegate.mm: Copied from DumpRenderTree/PolicyDelegate.m.
2071         * DumpRenderTree/mac/ResourceLoadDelegate.h: Copied from DumpRenderTree/ResourceLoadDelegate.h.
2072         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Copied from DumpRenderTree/ResourceLoadDelegate.m.
2073         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2074         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2075         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2076         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2077         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2078         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2079         * DumpRenderTree/mac/TextInputController.h: Copied from DumpRenderTree/TextInputController.h.
2080         * DumpRenderTree/mac/TextInputController.m: Copied from DumpRenderTree/TextInputController.m.
2081         * DumpRenderTree/mac/UIDelegate.h: Copied from DumpRenderTree/UIDelegate.h.
2082         * DumpRenderTree/mac/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.mm.
2083         (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
2084         (-[UIDelegate webViewFocus:]):
2085         (-[UIDelegate webView:createWebViewWithRequest:]):
2086         (-[UIDelegate webViewClose:]):
2087         * DumpRenderTree/mac/WorkQueueItemMac.mm: Copied from DumpRenderTree/WorkQueueItemMac.mm.
2088
2089 2007-09-14  Kevin McCullough  <kmccullough@apple.com>
2090
2091         Reviewed by Adam.
2092
2093         - Changing Win version of Drosera work with recent changes.
2094
2095         * Drosera/DebuggerDocument.cpp:
2096         * Drosera/DebuggerDocument.h:
2097         * Drosera/mac/DebuggerDocumentPlatform.mm:
2098         (NSStringCreateWithJSStringRef):
2099         (JSValueRefCreateWithNSString):
2100         * Drosera/win/DebuggerClient.cpp:
2101         (DebuggerClient::stepInto):
2102         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2103
2104 2007-09-13  Kevin McCullough  <kmccullough@apple.com>
2105
2106         Reviewed by Tim.
2107
2108         - Moved isPaused into the JS for efficiency and simplicity.
2109
2110         * Drosera/DebuggerDocument.cpp:
2111         (DebuggerDocument::DebuggerDocument):
2112         (DebuggerDocument::pauseCallback):
2113         (DebuggerDocument::resumeCallback):
2114         (DebuggerDocument::isPaused):
2115         (DebuggerDocument::staticFunctions):
2116         * Drosera/DebuggerDocument.h:
2117         * Drosera/console.js:
2118         * Drosera/debugger.js:
2119         * Drosera/mac/DebuggerClient.mm:
2120         (-[DebuggerClient validateUserInterfaceItem:]):
2121
2122 2007-09-13  Sam Weinig  <sam@webkit.org>
2123
2124         Rubber stamped by Darin.
2125
2126         Make DumpRenderTree more cross platform ready.
2127         - Convert GCController to use the JSCore API instead of the WebScriptObject.
2128         - Use CF types instead of NS objects.
2129         - General cleanup.
2130
2131         * DumpRenderTree/DumpRenderTree.h:
2132         * DumpRenderTree/DumpRenderTree.mm:
2133         (dumpRenderTree):
2134         (dump):
2135         (runTest):
2136         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2137         * DumpRenderTree/EditingDelegate.m:
2138         * DumpRenderTree/FrameLoadDelegate.h:
2139         * DumpRenderTree/FrameLoadDelegate.mm:
2140         (-[FrameLoadDelegate init]):
2141         (-[FrameLoadDelegate dealloc]):
2142         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2143         * DumpRenderTree/GCController.cpp: Added.
2144         (GCController::GCController):
2145         (GCController::~GCController):
2146         (collectCallback):
2147         (collectOnAlternateThreadCallback):
2148         (getJSObjectCountCallback):
2149         (GCController::makeWindowObject):
2150         (GCController::getJSClass):
2151         (GCController::staticFunctions):
2152         * DumpRenderTree/GCController.h:
2153         * DumpRenderTree/GCController.mm:
2154         (GCController::collect):
2155         (GCController::collectOnAlternateThread):
2156         (GCController::getJSObjectCount):
2157         * DumpRenderTree/LayoutTestController.cpp:
2158         (LayoutTestController::makeWindowObject):
2159         (LayoutTestController::getJSClass):
2160         * DumpRenderTree/LayoutTestController.h:
2161         * DumpRenderTree/LayoutTestControllerMac.mm:
2162         (LayoutTestController::addDisallowedURL):
2163         (waitUntilDoneWatchdogFired):
2164         (LayoutTestController::waitUntilDone):
2165         * DumpRenderTree/ResourceLoadDelegate.m:
2166         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2167
2168 2007-09-12  Sam Weinig  <sam@webkit.org>
2169
2170         Reviewed by Stephanie.
2171
2172         Fix leaks in mac DumpRenderTree.
2173
2174         * DumpRenderTree/FrameLoadDelegate.mm:
2175         (-[FrameLoadDelegate init]): Initalize in the correct order.
2176         (-[FrameLoadDelegate processWork:]): Delete WorkQueueItem's after dequeueing them.
2177         * DumpRenderTree/LayoutTestController.cpp:
2178         (decodeHostNameCallback): Put return value in a temporary JSRetainPtr to ensure it gets released.
2179         (encodeHostNameCallback): ditto.
2180         * DumpRenderTree/LayoutTestController.h:
2181         * DumpRenderTree/LayoutTestControllerMac.mm:
2182         (LayoutTestController::copyDecodedHostName): Rename function to signal that it follows the Create rule.
2183         (LayoutTestController::copyEncodedHostName): ditto
2184         (LayoutTestController::queueLoad): Use a JSRetainPtr to ensure the url gets released.
2185
2186 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
2187
2188         Reviewed by Geof.
2189
2190         - Updated Leopard leak list to include a leak which appears to be fixed in 9A549 but not the version the bot is on.  This will allow us to get the bot green, but later we should remove it.
2191
2192         * Scripts/run-webkit-tests:
2193
2194 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
2195
2196         Reviewed by Darin.
2197
2198         - Simplified code paths and extracted out functions to increase encapsulation.
2199
2200         * Drosera/DebuggerDocument.cpp:
2201         (DebuggerDocument::breakpointEditorHTMLCallback):
2202         (DebuggerDocument::isPausedCallback):
2203         (DebuggerDocument::pauseCallback):
2204         (DebuggerDocument::resumeCallback):
2205         (DebuggerDocument::stepIntoCallback):
2206         (DebuggerDocument::evaluateScriptCallback):
2207         (DebuggerDocument::currentFunctionStackCallback):
2208         (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
2209         (DebuggerDocument::valueForScopeVariableNamedCallback):
2210         (DebuggerDocument::logCallback):
2211         * Drosera/DebuggerDocument.h:
2212         (DebuggerDocument::getPaused):
2213         * Drosera/mac/DebuggerClient.mm:
2214         (-[DebuggerClient pause:]):
2215         (-[DebuggerClient resume:]):
2216         (-[DebuggerClient stepInto:]):
2217         (-[DebuggerClient stepOver:]):
2218         (-[DebuggerClient stepOut:]):
2219         (-[DebuggerClient showConsole:]):
2220         (-[DebuggerClient closeCurrentFile:]):
2221         (-[DebuggerClient validateUserInterfaceItem:]):
2222         * Drosera/mac/DebuggerDocumentPlatform.mm: Added.
2223         (+[NSString stringOrNilFromWebScriptResult:]):
2224         (DebuggerDocument::platformPause):
2225         (DebuggerDocument::platformResume):
2226         (DebuggerDocument::platformStepInto):
2227         (DebuggerDocument::platformEvaluateScript):
2228         (DebuggerDocument::getPlatformCurrentFunctionStack):
2229         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2230         (DebuggerDocument::platformValueForScopeVariableNamed):
2231         (DebuggerDocument::platformLog):
2232         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2233
2234 2007-09-12  Sam Weinig  <sam@webkit.org>
2235
2236         Build fix for Buildbot.
2237
2238         * DumpRenderTree/DumpRenderTree.mm:
2239         (dump):
2240
2241 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
2242
2243         Reviewed by Geoff.
2244
2245         - Updated the leaks list for leopard to help identify regressions.
2246
2247         * Scripts/run-webkit-tests:
2248
2249 2007-09-12  Sam Weinig  <sam@webkit.org>
2250
2251         Rubber stamped by Darin.
2252
2253         Convert the LayoutTestController to use the JSCore API instead of WebScriptObject.
2254
2255         * DumpRenderTree/DumpRenderTree.h: Re-order variables. 
2256         * DumpRenderTree/DumpRenderTree.m: Removed.
2257         * DumpRenderTree/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.m.
2258         (stopJavaScriptThreads): Fix initialization.
2259         (setDefaultColorProfileToRGB): Add explicit cast from void*.
2260         (dumpRenderTree): Ditto.
2261         (runTest):
2262         Used the WorkQueue from the windows DRT instead of the old NSMutableArray one.
2263
2264         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2265         * DumpRenderTree/FrameLoadDelegate.h: Add LayoutTestController instance variable.
2266         * DumpRenderTree/FrameLoadDelegate.m: Removed.
2267         * DumpRenderTree/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.m.
2268         (-[FrameLoadDelegate init]):
2269         (-[FrameLoadDelegate dealloc]):
2270         (-[FrameLoadDelegate processWork:]):
2271         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
2272         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2273         Convert to use the new JSCore based LayoutTestController and the new WorkQueue.
2274         
2275         * DumpRenderTree/LayoutTestController.cpp: Added.
2276         (LayoutTestController::LayoutTestController):
2277         (LayoutTestController::~LayoutTestController):
2278         (dumpAsTextCallback):
2279         (dumpBackForwardListCallback):
2280         (dumpChildFramesAsTextCallback):
2281         (dumpChildFrameScrollPositionsCallback):
2282         (dumpDOMAsWebArchiveCallback):
2283         (dumpEditingCallbacksCallback):
2284         (dumpFrameLoadCallbacksCallback):
2285         (dumpResourceLoadCallbacksCallback):
2286         (dumpSelectionRectCallback):
2287         (dumpSourceAsWebArchiveCallback):
2288         (dumpTitleChangesCallback):
2289         (repaintSweepHorizontallyCallback):
2290         (setCallCloseOnWebViewsCallback):
2291         (setCanOpenWindowsCallback):
2292         (setCloseRemainingWindowsWhenCompleteCallback):
2293         (testRepaintCallback):
2294         (addFileToPasteboardOnDragCallback):
2295         (addDisallowedURLCallback):
2296         (clearBackForwardListCallback):
2297         (decodeHostNameCallback):
2298         (displayCallback):
2299         (encodeHostNameCallback):
2300         (keepWebHistoryCallback):
2301         (notifyDoneCallback):
2302         (queueBackNavigationCallback):
2303         (queueForwardNavigationCallback):
2304         (queueLoadCallback):
2305         (queueReloadCallback):
2306         (queueScriptCallback):
2307         (setAcceptsEditingCallback):
2308         (setCustomPolicyDelegateCallback):
2309         (setMainFrameIsFirstResponderCallback):
2310         (setTabKeyCyclesThroughElementsCallback):
2311         (setUseDashboardCompatibilityModeCallback):
2312         (setUserStyleSheetEnabledCallback):
2313         (setUserStyleSheetLocationCallback):
2314         (setWindowIsKeyCallback):
2315         (waitUntilDoneCallback):
2316         (windowCountCallback):
2317         (LayoutTestController::makeWindowObject):
2318         (LayoutTestController::getLayoutTestControllerJSClass):
2319         (LayoutTestController::staticFunctions):
2320         * DumpRenderTree/LayoutTestController.h: Replaced.
2321         * DumpRenderTree/LayoutTestController.m: Removed.
2322         * DumpRenderTree/LayoutTestControllerMac.mm: Added.
2323         (LayoutTestController::dumpAsText):
2324         (LayoutTestController::dumpBackForwardList):
2325         (LayoutTestController::dumpChildFramesAsText):
2326         (LayoutTestController::dumpChildFrameScrollPositions):
2327         (LayoutTestController::dumpDOMAsWebArchive):
2328         (LayoutTestController::dumpEditingCallbacks):
2329         (LayoutTestController::dumpFrameLoadCallbacks):
2330         (LayoutTestController::dumpResourceLoadCallbacks):
2331         (LayoutTestController::dumpSelectionRect):
2332         (LayoutTestController::dumpSourceAsWebArchive):
2333         (LayoutTestController::dumpTitleChanges):
2334         (LayoutTestController::repaintSweepHorizontally):
2335         (LayoutTestController::setCallCloseOnWebViews):
2336         (LayoutTestController::setCanOpenWindows):
2337         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
2338         (LayoutTestController::testRepaint):
2339         (LayoutTestController::addFileToPasteboardOnDrag):
2340         (LayoutTestController::addDisallowedURL):
2341         (LayoutTestController::clearBackForwardList):
2342         (LayoutTestController::decodeHostName):
2343         (LayoutTestController::encodeHostName):
2344         (LayoutTestController::display):
2345         (LayoutTestController::keepWebHistory):
2346         (LayoutTestController::notifyDone):
2347         (LayoutTestController::queueBackNavigation):
2348         (LayoutTestController::queueForwardNavigation):
2349         (LayoutTestController::queueLoad):
2350         (LayoutTestController::queueReload):
2351         (LayoutTestController::queueScript):
2352         (LayoutTestController::setAcceptsEditing):
2353         (LayoutTestController::setCustomPolicyDelegate):
2354         (LayoutTestController::setMainFrameIsFirstResponder):
2355         (LayoutTestController::setTabKeyCyclesThroughElements):
2356         (LayoutTestController::setUseDashboardCompatibilityMode):
2357         (LayoutTestController::setUserStyleSheetEnabled):
2358         (LayoutTestController::setUserStyleSheetLocation):
2359         (LayoutTestController::setWindowIsKey):
2360         (+[WaitToDumpWatchdog waitUntilDoneWatchdogFired]):
2361         (LayoutTestController::waitUntilDone):
2362         (LayoutTestController::windowCount):
2363         Use the JSCore API to implement the LayoutTestController.
2364
2365         * DumpRenderTree/ObjCController.h:
2366         * DumpRenderTree/ObjCController.m:
2367         (+[ObjCController isSelectorExcludedFromWebScript:]):
2368         (+[ObjCController webScriptNameForSelector:]):
2369         (-[ObjCController accessStoredWebScriptObject]):
2370         (-[ObjCController storeWebScriptObject:]):
2371         (-[ObjCController dealloc]):
2372         (-[ObjCController invokeUndefinedMethodFromWebScript:withArguments:]):
2373         Move WebScriptObject tests to ObjCController.
2374
2375         * DumpRenderTree/UIDelegate.m: Removed.
2376         * DumpRenderTree/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.m.
2377
2378         * DumpRenderTree/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
2379         * DumpRenderTree/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
2380         * DumpRenderTree/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
2381         (WorkQueueItem::~WorkQueueItem):
2382         (LoadItem::LoadItem):
2383         (LoadItem::url):
2384         (LoadItem::target):
2385         (ScriptItem::ScriptItem):
2386         (ScriptItem::script):
2387         * DumpRenderTree/WorkQueueItemMac.mm: Added.
2388         (LoadItem::invoke):
2389         (ReloadItem::invoke):
2390         (ScriptItem::invoke):
2391         (BackForwardItem::invoke):
2392         Copy WorkQueue and WorkQueueItem from windows DRT. Changed the WorkQueueItem to use JSStringRefs instead of wstrings
2393         to avoid conversion until the last possible moment.  These changes will be merged with the windows DRT when we start
2394         sharing code.
2395
2396 2007-09-11  Kevin McCullough  <kmccullough@apple.com>
2397
2398         Reviewed by Maciej.
2399
2400         - Updated Win side to take advantage of the platform separating changes.
2401
2402         * Drosera/DebuggerDocument.cpp:
2403         (DebuggerDocument::localScopeVariableNamesForCallFrame):
2404         * Drosera/DebuggerDocument.h:
2405         * Drosera/win/DebuggerClient.cpp:
2406         (DebuggerClient::pause):
2407         (DebuggerClient::resume):
2408         (DebuggerClient::stepInto):
2409         (DebuggerDocument::platformPause):
2410         (DebuggerDocument::platformResume):
2411         (DebuggerDocument::platformStepInto):
2412         (DebuggerDocument::platformEvaluateScript):
2413         (DebuggerDocument::getPlatformCurrentFunctionStack):
2414         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2415         (DebuggerDocument::platformValueForScopeVariableNamed):
2416         (DebuggerDocument::platformLog):
2417         * Drosera/win/DebuggerClient.h:
2418         * Drosera/win/Drosera.cpp:
2419         (Drosera::Drosera):
2420         (Drosera::windowScriptObjectAvailable):
2421         (Drosera::initWithServerName):
2422         (Drosera::switchToServerNamed):
2423         * Drosera/win/Drosera.h:
2424         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2425
2426 2007-09-11  Kevin McCullough  <kmccullough@apple.com>
2427
2428         Reviewed by Adam.
2429
2430         - Just doing the moves in a separate patch so the changes are easier to see.
2431
2432         * Drosera/win/DebuggerClient.cpp: Copied from Drosera/win/DebuggerDocumentWin.cpp.
2433         * Drosera/win/DebuggerClient.h: Copied from Drosera/win/DebuggerDocumentWin.h.
2434         * Drosera/win/DebuggerDocumentWin.cpp: Removed.
2435         * Drosera/win/DebuggerDocumentWin.h: Removed.
2436         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2437
2438 2007-09-11  Sven Herzberg  <sven@imendio.com>
2439
2440         Don't overwrite LD_LIBRARY_PATH, prepend to it. Fixes:
2441         http://bugs.webkit.org/show_bug.cgi?id=15176
2442
2443         * Scripts/run-launcher: don't replace LD_LIBRARY_PATH with
2444         $projectDir, but prepend $projectDir to LD_LIBRARY_PATH (to preserve
2445         other paths eg. from jhbuild)
2446
2447 2007-09-10  Kevin McCullough  <kmccullough@apple.com>
2448
2449         Reviewed by Adam.
2450
2451         - Made an order-of-deletion mistake.
2452
2453         * Drosera/DebuggerDocument.h:
2454         * Drosera/ForwardingHeaders/wtf/Assertions.h: Removed.
2455         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Removed.
2456         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Removed.
2457         * Drosera/mac/DebuggerClient.mm:
2458         (DebuggerDocument::platformPause):
2459         (DebuggerDocument::platformResume):
2460         (DebuggerDocument::platformStepInto):
2461         (DebuggerDocument::platformEvaluateScript):
2462         (DebuggerDocument::getPlatformCurrentFunctionStack):
2463         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2464         (DebuggerDocument::platformValueForScopeVariableNamed):
2465         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2466
2467 2007-09-10  Kevin McCullough  <kmccullough@apple.com>
2468
2469         Reviewed by Darin.
2470
2471         - Renaming DebuggerDocument[platform] to DebuggerClient to be more clear.
2472
2473         * Drosera/DebuggerDocument.cpp:
2474         (DebuggerDocument::DebuggerDocument):
2475         * Drosera/DebuggerDocument.h:
2476         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
2477         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
2478         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
2479         * Drosera/mac/DebuggerApplication.mm:
2480         (-[DebuggerApplication attach:]):
2481         * Drosera/mac/DebuggerClient.h: Copied from Drosera/mac/DebuggerDocumentMac.h.
2482         * Drosera/mac/DebuggerClient.mm: Copied from Drosera/mac/DebuggerDocumentMac.mm.
2483         (DebuggerDocument::platformPause):
2484         (DebuggerDocument::platformResume):
2485         (DebuggerDocument::platformStepInto):
2486         (DebuggerDocument::platformEvaluateScript):
2487         (DebuggerDocument::getPlatformCurrentFunctionStack):
2488         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2489         (DebuggerDocument::platformValueForScopeVariableNamed):
2490         (DebuggerDocument::platformLog):
2491         * Drosera/mac/DebuggerDocumentMac.h: Removed.
2492         * Drosera/mac/DebuggerDocumentMac.mm: Removed.
2493         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2494
2495 2007-09-09  Sam Weinig  <sam@webkit.org>
2496
2497         Reviewed by Mark Rowe.
2498
2499         Remove 'objC' prefix from methods now in the ObjCController. 
2500
2501         * DumpRenderTree/ObjCController.m:
2502         (+[ObjCController isSelectorExcludedFromWebScript:]):
2503         (+[ObjCController webScriptNameForSelector:]):
2504         (-[ObjCController classNameOf:]):
2505         (-[ObjCController objectOfClass:]):
2506         (-[ObjCController identityIsEqual::]):
2507         (-[ObjCController longLongRoundTrip:]):
2508         (-[ObjCController unsignedLongLongRoundTrip:]):
2509
2510 2007-09-09  Sam Weinig  <sam@webkit.org>
2511
2512         Reviewed by Oliver.
2513
2514         Initial refactor of DumpRenderTree in preparation of making it more platform independent. 
2515         - Move LayoutTestController into its own file.
2516         - Move Objective-C only functions on LayoutTestController into a new controller called the
2517           ObjCController. 
2518
2519         * DumpRenderTree/DumpRenderTree.h:
2520         * DumpRenderTree/DumpRenderTree.m:
2521         (displayWebView):
2522         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2523         * DumpRenderTree/FrameLoadDelegate.m:
2524         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2525         * DumpRenderTree/LayoutTestController.h: Added.
2526         * DumpRenderTree/LayoutTestController.m: Added.
2527         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
2528         (+[LayoutTestController webScriptNameForSelector:]):
2529         (-[LayoutTestController clearBackForwardList]):
2530         (-[LayoutTestController setUseDashboardCompatibilityMode:]):
2531         (-[LayoutTestController setCloseRemainingWindowsWhenComplete:]):
2532         (-[LayoutTestController setCustomPolicyDelegate:]):
2533         (-[LayoutTestController keepWebHistory]):
2534         (-[LayoutTestController setCallCloseOnWebViews:]):
2535         (-[LayoutTestController setCanOpenWindows]):
2536         (-[LayoutTestController waitUntilDone]):
2537         (-[LayoutTestController waitUntilDoneWatchdogFired]):
2538         (-[LayoutTestController notifyDone]):
2539         (-[LayoutTestController dumpAsText]):
2540         (-[LayoutTestController addFileToPasteboardOnDrag]):
2541         (-[LayoutTestController addDisallowedURL:]):
2542         (-[LayoutTestController setUserStyleSheetLocation:]):
2543         (-[LayoutTestController setUserStyleSheetEnabled:]):
2544         (-[LayoutTestController dumpDOMAsWebArchive]):
2545         (-[LayoutTestController dumpSourceAsWebArchive]):
2546         (-[LayoutTestController dumpSelectionRect]):
2547         (-[LayoutTestController dumpTitleChanges]):
2548         (-[LayoutTestController dumpBackForwardList]):
2549         (-[LayoutTestController windowCount]):
2550         (-[LayoutTestController dumpChildFrameScrollPositions]):
2551         (-[LayoutTestController dumpChildFramesAsText]):
2552         (-[LayoutTestController dumpEditingCallbacks]):
2553         (-[LayoutTestController dumpResourceLoadCallbacks]):
2554         (-[LayoutTestController dumpFrameLoadCallbacks]):
2555         (-[LayoutTestController setWindowIsKey:]):
2556         (-[LayoutTestController setMainFrameIsFirstResponder:]):
2557         (-[LayoutTestController display]):
2558         (-[LayoutTestController testRepaint]):
2559         (-[LayoutTestController repaintSweepHorizontally]):
2560         (-[LayoutTestController invokeUndefinedMethodFromWebScript:withArguments:]):
2561         (-[LayoutTestController _addWorkForTarget:selector:arg1:arg2:]):
2562         (-[LayoutTestController _doLoad:target:]):
2563         (-[LayoutTestController _doBackOrForwardNavigation:]):
2564         (-[LayoutTestController queueBackNavigation:]):
2565         (-[LayoutTestController queueForwardNavigation:]):
2566         (-[LayoutTestController queueReload]):
2567         (-[LayoutTestController queueScript:]):
2568         (-[LayoutTestController queueLoad:target:]):
2569         (-[LayoutTestController setAcceptsEditing:]):
2570         (-[LayoutTestController setTabKeyCyclesThroughElements:]):
2571         (-[LayoutTestController storeWebScriptObject:]):
2572         (-[LayoutTestController accessStoredWebScriptObject]):
2573         (-[LayoutTestController dealloc]):
2574         (-[LayoutTestController decodeHostName:]):
2575         (-[LayoutTestController encodeHostName:]):
2576         * DumpRenderTree/ObjCController.h: Added.
2577         * DumpRenderTree/ObjCController.m: Added.
2578         (+[ObjCController isSelectorExcludedFromWebScript:]):
2579         (+[ObjCController webScriptNameForSelector:]):
2580         (-[ObjCController objCClassNameOf:]):
2581         (-[ObjCController objCObjectOfClass:]):
2582         (-[ObjCController objCIdentityIsEqual::]):
2583         (-[ObjCController objCLongLongRoundTrip:]):
2584         (-[ObjCController objCUnsignedLongLongRoundTrip:]):
2585         (-[ObjCController testWrapperRoundTripping:]):
2586
2587 2007-09-07  Sam Weinig  <sam@webkit.org>
2588
2589         Reviewed by Alice.
2590
2591         Strip trailing and leading space/newline characters from skiplist file names.
2592
2593         * Scripts/run-webkit-tests:
2594
2595 2007-09-06  Kevin McCullough  <kmccullough@apple.com>
2596
2597         Reviewed by Maciej.
2598
2599         - Changed Drosera to take advantage of the JSRetainPtr changes.
2600
2601         * Drosera/DebuggerDocument.cpp:
2602         (DebuggerDocument::breakpointEditorHTML):
2603         (DebuggerDocument::evaluateScript):
2604         (DebuggerDocument::valueForScopeVariableNamed):
2605         (DebuggerDocument::log):
2606         (DebuggerDocument::windowScriptObjectAvailable):
2607         (DebuggerDocument::toJSArray):
2608         (DebuggerDocument::callFunctionOnObject):
2609         (DebuggerDocument::logException):
2610         * Drosera/mac/DebuggerDocumentMac.mm:
2611         (-[DebuggerClientMac webView:didLoadMainResourceForDataSource:]):
2612         (-[DebuggerClientMac webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
2613         (DebuggerDocument::platformEvaluateScript):
2614         (DebuggerDocument::getPlatformCurrentFunctionStack):
2615         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2616         (DebuggerDocument::platformValueForScopeVariableNamed):
2617
2618 2007-09-05  Kevin McCullough  <kmccullough@apple.com>
2619
2620         Reviewed by Adam, Sam, Darin.
2621
2622         - Separated what is platform dependant from what is not.  Creating the structure needed for Drosera for Win.
2623
2624         * Drosera/Debugger.h: Added.
2625         * Drosera/DebuggerDocument.cpp:
2626         (DebuggerDocument::breakpointEditorHTMLCallback):
2627         (DebuggerDocument::isPausedCallback):
2628         (DebuggerDocument::pauseCallback):
2629         (DebuggerDocument::resumeCallback):
2630         (DebuggerDocument::stepIntoCallback):
2631         (DebuggerDocument::evaluateScriptCallback):
2632         (DebuggerDocument::currentFunctionStackCallback):
2633         (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
2634         (DebuggerDocument::valueForScopeVariableNamedCallback):
2635         (DebuggerDocument::logCallback):
2636         (DebuggerDocument::breakpointEditorHTML):
2637         (DebuggerDocument::isPaused):
2638         (DebuggerDocument::pause):
2639         (DebuggerDocument::resume):
2640         (DebuggerDocument::stepInto):
2641         (DebuggerDocument::evaluateScript):
2642         (DebuggerDocument::currentFunctionStack):
2643         (DebuggerDocument::localScopeVariableNamesForCallFrame):
2644         (DebuggerDocument::valueForScopeVariableNamed):
2645         (DebuggerDocument::log):
2646         (DebuggerDocument::toolbarPause):
2647         (DebuggerDocument::toolbarResume):
2648         (DebuggerDocument::toolbarStepInto):
2649         (DebuggerDocument::toolbarStepOver):
2650         (DebuggerDocument::toolbarStepOut):
2651         (DebuggerDocument::toolbarShowConsole):
2652         (DebuggerDocument::toolbarCloseCurrentFile):
2653         (DebuggerDocument::updateFileSource):
2654         (DebuggerDocument::didParseScript):
2655         (DebuggerDocument::willExecuteStatement):
2656         (DebuggerDocument::didEnterCallFrame):
2657         (DebuggerDocument::willLeaveCallFrame):
2658         (DebuggerDocument::exceptionWasRaised):
2659         (DebuggerDocument::windowScriptObjectAvailable):
2660         (DebuggerDocument::toJSArray):
2661         (DebuggerDocument::callGlobalFunction):
2662         (DebuggerDocument::callFunctionOnObject):
2663         (DebuggerDocument::getDroseraJSClass):
2664         (DebuggerDocument::staticFunctions):
2665         (DebuggerDocument::logException):
2666         * Drosera/DebuggerDocument.h:
2667         (DebuggerDocument::DebuggerDocument):
2668         * Drosera/ForwardingHeaders: Added.
2669         * Drosera/ForwardingHeaders/wtf: Added.
2670         * Drosera/ForwardingHeaders/wtf/Platform.h: Added.
2671         * Drosera/config.h:
2672         * Drosera/console.html:
2673         * Drosera/console.js:
2674         * Drosera/debugger.js:
2675         * Drosera/mac/DebuggerApplication.mm:
2676         (-[DebuggerApplication attach:]):
2677         * Drosera/mac/DebuggerDocumentMac.h:
2678         * Drosera/mac/DebuggerDocumentMac.mm:
2679         (+[NSString stringOrNilFromWebScriptResult:]):
2680         (+[DebuggerClientMac log:]):
2681         (-[DebuggerClientMac initWithServerName:]):
2682         (-[DebuggerClientMac dealloc]):
2683         (-[DebuggerClientMac pause]):
2684         (-[DebuggerClientMac resume]):
2685         (-[DebuggerClientMac pause:]):
2686         (-[DebuggerClientMac resume:]):
2687         (-[DebuggerClientMac stepInto:]):
2688         (-[DebuggerClientMac stepOver:]):
2689         (-[DebuggerClientMac stepOut:]):
2690         (-[DebuggerClientMac showConsole:]):
2691         (-[DebuggerClientMac closeCurrentFile:]):
2692         (-[DebuggerClientMac validateUserInterfaceItem:]):
2693         (-[DebuggerClientMac webView:windowScriptObjectAvailable:]):
2694         (-[DebuggerClientMac webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
2695         (-[DebuggerClientMac webView:willExecuteStatement:sourceId:line:forWebFrame:]):
2696         (-[DebuggerClientMac webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
2697         (-[DebuggerClientMac webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
2698         (DebuggerDocument::platformPause):
2699         (DebuggerDocument::platformResume):
2700         (DebuggerDocument::platformStepInto):
2701         (DebuggerDocument::platformEvaluateScript):
2702         (DebuggerDocument::platformCurrentFunctionStack):
2703         (DebuggerDocument::platformLocalScopeVariableNamesForCallFrame):
2704         (DebuggerDocument::platformValueForScopeVariableNamed):
2705         (DebuggerDocument::platformLog):
2706         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2707
2708 2007-09-06  Sam Weinig  <sam@webkit.org>
2709
2710         Reviewed by Adam Roben.
2711
2712         Register the WebKit DLL on initialization of the DumpRenderTree.
2713
2714         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
2715         (initialize):
2716
2717 2007-09-05  Sam Weinig  <sam@webkit.org>
2718
2719         Reviewed by Oliver.
2720
2721         Fix many layout test failures caused by r25364.
2722         Set text size to standand size at the begining of each test matching the mac.
2723
2724         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
2725         (runTest):
2726
2727 2007-09-04  Sam Weinig  <sam@webkit.org>
2728
2729         Reviewed by Adam.
2730
2731         Fix for <rdar://problem/5382277>
2732         Implement eventSender.textZoomIn and eventSender.textZoomOut for windows DRT.
2733
2734         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp:
2735         (textZoomInCallback):
2736         (textZoomOutCallback):
2737
2738 2007-08-29  David Kilzer  <ddkilzer@apple.com>
2739
2740         Reviewed by Adam.
2741
2742         Added case-insensitivity to checks for adding regression tests.
2743
2744         * Scripts/prepare-ChangeLog:
2745         (generateFileList):
2746
2747 2007-08-28  David Kilzer  <ddkilzer@apple.com>
2748
2749         Reviewed by Maciej.
2750
2751         Ignore files in /resources/ subdirectories when creating a list of added tests.
2752
2753         * Scripts/prepare-ChangeLog:
2754         (generateFileList):
2755
2756 2007-08-27  Kevin McCullough  <kmccullough@apple.com>
2757
2758         Reviewed by John.
2759
2760         - Removed Leopard leaks list since all of those radars were fixed.
2761
2762         * Scripts/run-webkit-tests:
2763
2764 2007-08-27  Adam Roben  <aroben@apple.com>
2765
2766         Rubberstamped by Mark.
2767
2768         * Scripts/pdevenv: Pass arguments along to devenv.com.
2769
2770 2007-08-26  David Kilzer  <ddkilzer@webkit.org>
2771
2772         Reviewed by Mark Rowe.
2773
2774         Update prepare-ChangeLog to generate the datestamp in the correct timezone.
2775
2776         * Scripts/prepare-ChangeLog:
2777         (changeLogDate): Added.
2778
2779 2007-08-24  Sam Weinig  <sam@webkit.org>
2780
2781         Revert r25216 which renamed the COM DOM bindings to use Deprecated prefix.
2782
2783 2007-08-24  Sam Weinig  <sam@webkit.org>
2784
2785         Rubber-stamped by Adam Roben.
2786
2787         <rdar://problem/5434593> Deprecate current manually written COM DOM bindings in anticipation of autogeneration
2788
2789         Rename COM DOM bindings to use Deprecated prefix.
2790
2791         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
2792         (dumpFramesAsText):
2793         (dump):
2794         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp:
2795         (dumpPath):
2796         (dump):
2797         (EditingDelegate::shouldBeginEditingInDOMRange):
2798         (EditingDelegate::shouldEndEditingInDOMRange):
2799         (EditingDelegate::shouldInsertNode):
2800         (EditingDelegate::shouldInsertText):
2801         (EditingDelegate::shouldDeleteDOMRange):
2802         (EditingDelegate::shouldChangeSelectedDOMRange):
2803         (EditingDelegate::shouldApplyStyle):
2804         (EditingDelegate::shouldChangeTypingStyle):
2805         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h:
2806
2807 2007-08-24  Oliver Hunt  <oliver@apple.com>
2808
2809         Reviewed by John H.
2810
2811         WebDataSource::response can legitimately have a null response, so we
2812         must check that case.
2813
2814         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp:
2815         (queueLoadCallback):
2816
2817 2007-08-23  Mitz Pettel  <mitz@webkit.org>
2818
2819         Reviewed by Darin and Adam.
2820
2821         - DumpRenderTree changes to allow testing for
2822           http://bugs.webkit.org/show_bug.cgi?id=11756
2823           REGRESSION: link targeting a frame in another window does not work
2824           <rdar://problem/5286420>
2825
2826         Use a frame group name for all WebViews created by DumpRenderTree to
2827         allow testing of cross-page frame lookup.
2828
2829         * DumpRenderTree/DumpRenderTree.m:
2830         (createWebView): Pass group name to -[WebView initWithFrame:frameName:groupName:].
2831         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
2832         (main): Pass group name to WebView::initWithFrame(RECT, BSTR, BSTR).
2833
2834 2007-08-23  David Kilzer  <ddkilzer@webkit.org>
2835
2836         Reviewed by Adam.
2837
2838         Quote the $sslCertificate path in case it contains a space.
2839
2840         * Scripts/run-webkit-httpd:
2841         * Scripts/run-webkit-tests:
2842
2843 2007-08-22  Oliver Hunt  <oliver@apple.com>
2844
2845         Reviewed by John and Adam.
2846         
2847         WebDataSource::response can legitimately have a null response, so we
2848         must check that case.
2849
2850         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
2851         (dump):
2852
2853 2007-08-21  Kevin McCullough  <kmccullough@apple.com>
2854
2855         Reviewed by Geof.
2856
2857         - Changing the usage to be more clear.
2858
2859         * Scripts/run-testkjs:
2860
2861 2007-08-20  John Sullivan  <sullivan@apple.com>
2862
2863         Reviewed by Adam Roben
2864
2865         * DumpRenderTree/DumpRenderTree.m:
2866         (runTest):
2867         call new +[WebView _setUsesTestModeFocusRingColor:YES] so we get the same focus ring colors
2868         in layout tests on Tiger and Leopard
2869
2870 2007-08-20  Adam Roben  <aroben@apple.com>
2871
2872         Put LayoutTests after all other ChangeLogs in commit logs
2873
2874         We use "~" to sort LayoutTests after all the other ChangeLogs because
2875         "~" is the last ASCII character (other than "DEL").
2876
2877         Reviewed by Sam.
2878
2879         * Scripts/commit-log-editor:
2880
2881 2007-08-20  Adam Roben  <aroben@apple.com>
2882
2883         Detect that DRT crashed even if a crash dialog is running
2884
2885         On Windows, when DRT crashes a crash dialog commonly appears. The DRT
2886         process is still running at this point, so run-webkit-tests wouldn't
2887         detect that DRT had crashed. We now record the crash in our SIGPIPE
2888         handler so that we know if DRT crashed even if the crash dialog is up.
2889
2890         Reviewed by Sam.
2891
2892         * Scripts/run-webkit-tests:
2893         (sub catch_pipe): Set the crashed bit.
2894         (sub openDumpTool): Reset the crashed bit.
2895         (sub dumpToolDidCrash): Check the crashed bit.
2896
2897 2007-08-20  Adam Roben  <aroben@apple.com>
2898
2899         Fix Bug 15026: prepare-ChangeLog should list new tests in WebCore/ChangeLog
2900
2901         http://bugs.webkit.org/show_bug.cgi?id=15026
2902
2903         Reviewed by David Kilzer and Darin Adler.
2904
2905         * Scripts/prepare-ChangeLog:
2906         (sub isModifiedStatus): Split out from isModifiedOrAddedStatus.
2907         (sub isAddedStatus): Ditto.
2908         (sub testListForChangeLog): Added.
2909
2910 2007-08-19  Oleg Sukhodolsky  <son.two@gmail.com>
2911
2912         Reviewed by Mark.
2913
2914         -fixes http://bugs.webkit.org/show_bug.cgi?id=14632
2915
2916         * Scripts/webkitdirs.pm:
2917         qt and gtk ports now explicitly pass debug (or release) mode to qmake.
2918
2919 2007-08-17  Darin Adler  <darin@apple.com>
2920
2921         Reviewed by Oliver Hunt.
2922
2923         - don't look for Apple-style localizable strings in the GTK version of WebKit
2924
2925         * Scripts/extract-localizable-strings: Add a feature where you can pass in the
2926         name of subdirectories to skip.
2927         * Scripts/update-webkit-localizable-strings: Pass WebKit/gtk as a subdirectory
2928         to skip.
2929
2930 2007-08-17  Anders Carlsson  <andersca@apple.com>
2931
2932         Build fix.
2933         
2934         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
2935         (NPP_SetWindow):
2936
2937 2007-08-17  Anders Carlsson  <andersca@apple.com>
2938
2939         Reviewed by Dave Hyatt.
2940
2941         <rdar://problem/5379040>
2942         REGRESSION (Tiger-Leopard): ADOBE: Safari calls NPP_SetWindow with bad values sometimes
2943
2944         Add a way for the plug-in to dump the width and height when it gets its  NPP_SetWindow call.
2945         
2946         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
2947         (pluginAllocate):
2948         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2949         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
2950         (NPP_New):
2951         (NPP_SetWindow):
2952
2953 2007-08-16  Alice Liu  <alice.liu@apple.com>
2954
2955         Reviewed by Maciej.
2956
2957         Fix <rdar://problem/5360135> REGRESSION (Leopard only): editing/selection/5354455-1.html is causing subsequent tests to fail
2958
2959         * DumpRenderTree/DumpRenderTree.m:
2960         (createWebView):
2961         Create a DumpRenderTreeWindow instead of a NSWindow, now that a DumpRenderTreeWindow no longer poses as a NSWindow.
2962         (dumpRenderTree):
2963         Don't pose as a NSWindow, since when the spelling panel gets created, it creates an NSWindow which ends up creating a DumpRenderTreeWindow. 
2964
2965 2007-08-16  Kevin McCullough  <kmccullough@apple.com>
2966
2967         Reviewed by Adam.
2968
2969         - Added tests for regressions in other components.  In this case we also need to add a skipped list for Tiger since this functionality didn't exist in 10.4.
2970
2971         * Scripts/run-webkit-tests:
2972
2973 2007-08-15  Timothy Hatcher  <timothy@apple.com>
2974
2975         Look for the new Xcode 3 preference key (PBXApplicationwideBuildSettings) for the global build locations.
2976         The value of PBXApplicationwideBuildSettings is a dictionary, so we have to pull the SYMROOT out of it.
2977
2978         Also pass xcodebuild OBJROOT with the same value as SYMROOT if we fallback to the default WebKitBuild,
2979         this prevents making "build" directories in each project folder.
2980
2981         * Scripts/webkitdirs.pm:
2982
2983 2007-08-14  Geoffrey Garen  <ggaren@apple.com>
2984
2985         Reviewed by Kevin Mccullough.
2986         
2987         Removed special case that didn't belong. (It would allow a global 
2988         initializer to sneak into production builds, which would cause a 
2989         system-wide performance regression on Mac OS X.)
2990
2991         * Scripts/check-for-global-initializers:
2992
2993 2007-08-14  Justin Garcia  <justin.garcia@apple.com>
2994
2995         Reviewed by Tim.
2996         
2997         <rdar://problem/5408255> REGRESSION: In Mail, clicking the containing element's UI closebox doesn't delete element
2998
2999         * DumpRenderTree/EditingDelegate.m:
3000         (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Added, return YES
3001         only for elements with the class needsDeletionUI.
3002
3003 2007-08-14  David Kilzer  <ddkilzer@webkit.org>
3004
3005         Reviewed by Darin.
3006
3007         - fix http://bugs.webkit.org/show_bug.cgi?id=14965
3008           svn-create-patch uses deprecated tail switch
3009
3010         * Scripts/svn-create-patch: Use 'tail -n +3' instead of 'tail +3'.
3011
3012 2007-08-13  Sam Weinig  <sam@webkit.org>
3013
3014         Reviewed by Adam Roben.
3015
3016         Use the cygwin specific Apache config file under cygwin.
3017
3018         * Scripts/run-webkit-httpd:
3019
3020 2007-08-12  Adam Roben  <aroben@apple.com>
3021
3022         Generate results for new tests in a more logical location
3023
3024         New platform-specific tests always have their results generated right
3025         next to the test. New cross-platform tests will have their results
3026         generated a) in the cross-platform directory, if they are text-only,
3027         or b) in the least-specific platform directory, if they are render
3028         tree dumps.
3029
3030         Reviewed by Lars.
3031
3032         * Scripts/run-webkit-tests:
3033
3034 2007-08-12  Adam Roben  <aroben@apple.com>
3035
3036         Print the actual directory where new results are generated.
3037
3038         Before, we were printing an unpredictable, context-specific substring
3039         of the directory.
3040
3041         Reviewed by Lars.
3042
3043         * Scripts/run-webkit-tests:
3044
3045 2007-08-12  Adam Roben  <aroben@apple.com>
3046
3047         Factor some common code into a stripExtension() subroutine.
3048
3049         Reviewed by Lars.
3050
3051         * Scripts/run-webkit-tests: Also removed some debugging output.
3052
3053 2007-08-11  Matt Lilek  <pewtermoose@gmail.com>
3054
3055         Reviewed over and over and over by Adam Roben.
3056
3057         Bug 14740: Hierarchical layout tests and platform organization
3058         http://bugs.webkit.org/show_bug.cgi?id=14740
3059
3060         Add support for platform-specific layout tests and results.
3061
3062         * Scripts/run-webkit-tests:
3063
3064 2007-08-11  David Kilzer  <ddkilzer@webkit.org>
3065
3066         Reviewed by Adam.
3067
3068         Refactored svn-create-path to use a hash-of-hashes data structure to keep
3069         track of changed files.  In the top level hash, keys are paths to files and
3070         values are 'fileData' hashes with the following keys and values:
3071
3072         - isBinary: boolean value (set to true for non-text files like images, etc.)
3073         - isTestFile: boolean value (set to true if file exists within a known test
3074           directory)
3075         - modificationType: string equal to one of 'addition', 'additionWithHistory',
3076           'modification' or 'deletion'
3077         - path: string equal to the path to the file (this may seem redundant, but it
3078           is required to use the second-level 'fileData' hash independent of the
3079           top-level hash)
3080         - sourceFile: [optional] string equal to the path of the original file that was
3081           copied or moved
3082         - sourceRevision: [optional] string equal to the revision of the original file
3083           that was copied or moved
3084
3085         * Scripts/svn-create-patch: Moved call to GetOptions() to its own statement
3086         that saves the return value in $result, then checks it before printing help.
3087         Combined sourceFiles, %testFiles, and %binaryFiles into single %diffFiles hash
3088         and eliminated two for() loops.
3089         (binarycmp): Added.  Used with sort() to order non-binary files before binary
3090         files.
3091         (findBaseUrl): Added.  Extracted from findSourceFileAndRevision().
3092         (findMimeType): Added optional second argument that takes a revision number.
3093         (generateDiff): Updated to take one fileData argument instead of three ($file,
3094         $modificationType, $isBinary).
3095         (generateFileList): Updated to take one hash ref argument (%diffFiles)
3096         instead of three (%sourceFiles, %testFiles, %binaryFiles).  Populates
3097         %diffFiles using paths for keys and fileData hashes for values.
3098         (manufacturePatchForAdditionWithHistory): Updated to take one fileData
3099         argument.
3100         (pathcmp): Updated to take two fileData arguments instead of two strings.
3101         (testfilecmp): Added.  Used with sort() to order non-test files before test
3102         files.
3103
3104 2007-08-11  Darin Adler  <darin@apple.com>
3105
3106         * Scripts/run-webkit-tests: Give a different message when only the pixel test failed.
3107
3108 2007-08-06  Nigel Tao  <nigeltao@gnome.org>
3109
3110         Reviewed by David Kilzer.
3111
3112         Fix bug 14745: WebKitTools/Scripts/run-launcher doesn't speak --gdk
3113         http://bugs.webkit.org/show_bug.cgi?id=14745
3114
3115         * Scripts/run-launcher:
3116         Scrub the "--gdk" out of the command line args, if given, so that
3117         GdkLauncher doesn't try to interpret it as a URL.
3118
3119 2007-08-03  Adam Roben  <aroben@apple.com>
3120
3121         Catch SIGPIPE on Windows so that run-webkit-tests doesn't quit when DRT crashes
3122
3123         Reviewed by Sam.
3124
3125         * Scripts/run-webkit-tests: Also close ERROR when we finish running the tests.
3126
3127 2007-08-03  Sam Weinig  <sam@webkit.org>
3128
3129         Reviewed by Darin.
3130
3131         Recursively dump all frames as text using new
3132         layoutTestController.dumpChildFramesAsText() function.
3133
3134         * DumpRenderTree/DumpRenderTree.m:
3135         (dumpFramesAsText):
3136         (dump):
3137         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
3138         (-[LayoutTestController dumpChildFramesAsText]):
3139         (runTest):
3140         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3141         (dumpFramesAsText):
3142         (dump):
3143         (runTest):
3144         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h:
3145         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp:
3146         (dumpChildFramesAsTextCallback):
3147         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3148
3149 2007-08-02  Adam Roben  <aroben@apple.com>
3150
3151         Fix fast/dom/Window/alert-undefined.html
3152
3153         Reviewed by Sam.
3154
3155         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
3156         (WaitUntilDoneDelegate::runJavaScriptAlertPanelWithMessage): Don't let
3157         Windows translate a null BSTR into "(null)"
3158
3159 2007-08-02  Kevin McCullough  <kmccullough@apple.com>
3160
3161         Reviewed by Tim. 
3162
3163         - It would help if I actually called the right function.
3164
3165         * Drosera/DebuggerDocument.cpp:
3166         (DebuggerDocument::showConsole):
3167
3168 2007-08-02  Adam Roben  <aroben@apple.com>
3169
3170         Don't delete the stderr file right after creating it
3171
3172         Reviewed by NOBODY.
3173
3174         * Scripts/run-webkit-tests:
3175
3176 2007-08-01  Adam Roben  <aroben@apple.com>
3177
3178         When DRT crashes, record stderr and restart DRT
3179
3180         This prevents a DRT crash from causing the next few hundred tests to
3181         "fail" because DRT is no longer running. 
3182
3183         I also changed the terminology that run-webkit-tests uses in its
3184         output a bit, so that crashing tests are referred to as "crashes"
3185         instead of "failures".
3186
3187         Reviewed by Mark.
3188
3189         * Scripts/run-webkit-tests: Detect a crash and record it as a tool
3190         failure.
3191         (sub openDumpTool): Use open3 so that we can access stderr.
3192         (sub dumpToolCrashed): Added.
3193         (sub printFailureMessageForTest): Added.
3194         (sub htmlForExpectedAndActualResults): Added.
3195         (sub deleteExpectedAndActualResults): Added.
3196         (sub recordActualResultsAndDiff): Added.
3197
3198 2007-07-30  Darin Adler  <darin@apple.com>
3199
3200         Reviewed by Tim Hatcher.
3201
3202         * DumpRenderTree/DumpRenderTree.m: (dump): Fix dumping for documents that include null
3203         characters. This turned out not to be needed for the test case that motivated me to
3204         do it, but it's nice to have this for the future.
3205
3206 2007-07-30  Simon Hausmann  <hausmann@kde.org>
3207
3208         Reviewed by Lars.
3209
3210         Link QtLauncher into $$OUTPUT_DIR/bin
3211
3212         * Scripts/run-launcher:
3213
3214 2007-07-27  David Kilzer  <ddkilzer@apple.com>
3215
3216         Reviewed by Geoff and Darin.
3217
3218         Use a subroutine for validating the --skipped switch.
3219
3220         * Scripts/run-webkit-tests:
3221
3222 2007-07-27  Darin Adler  <darin@apple.com>
3223
3224         Reviewed by Sam.
3225
3226         * Scripts/run-webkit-tests: Remove exception for leaks bug that has been fixed on Leopard.
3227
3228 2007-07-27  Holger Hans Peter Freyther  <zecke@selfish.org>
3229
3230         Reviewed by Mark.
3231
3232         Correct the path of GdkLauncher and make checkFrameworks work on OSX
3233         when building the Qt or Gtk+ port.
3234
3235         * GdkLauncher/GdkLauncher.pro: Don't create an app bundle on OSX
3236         * Scripts/run-launcher:
3237         * Scripts/webkitdirs.pm: Don't add WebKit if we build the Qt or Gtk+ port.
3238
3239 2007-07-27  Simon Hausmann  <hausmann@kde.org>
3240
3241         Done with and reviewed by Lars and Zack.
3242
3243         Fix build-webkit for the Qt build on Windows with msvc/nmake by trying to detect the Qt mkspec and using "nmake" instead of "make" as build command.
3244
3245         * Scripts/webkitdirs.pm:
3246
3247 2007-07-27  Simon Hausmann  <hausmann@kde.org>
3248
3249         Done with and reviewed by Lars and Zack.
3250
3251         For detecting the SVG support for the Qt build don't do the nm hack. Just always claim SVG support is enabled because that's what it is. The nm hack doesn't work on Windows anyway.
3252
3253         * Scripts/webkitdirs.pm:
3254
3255 2007-07-26  Kevin McCullough  <kmccullough@apple.com>
3256
3257         Reviewed by Darin, Geoff, Sam.
3258
3259         - <rdar://problem/5150461> Resizing the window larger than the screen causes no resize.
3260
3261         - Added delegate methods to intercept and fake the frame location so methods like resizeTo and moveTo can change the window location without actually making the window appear on-screen.
3262
3263         * DumpRenderTree/UIDelegate.h:
3264         * DumpRenderTree/UIDelegate.m:
3265         (-[UIDelegate webView:setFrame:]):
3266         (-[UIDelegate webViewFrame:]):
3267
3268 2007-07-26  Kevin McCullough  <kmccullough@apple.com>
3269
3270         Reviewed by Adam.
3271
3272         - Lars wanted this check for Qt but it breaks platform specific layout tests.
3273
3274         * Scripts/run-webkit-tests:
3275
3276 2007-07-25  Kevin McCullough  <kmccullough@apple.com>
3277
3278         Reviewed by Tim, Darin, Oliver.
3279
3280         - <rdar://problem/5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
3281         - Change DRT to be able to intercept the requst to load so it can check if a scheme was allowed or not.
3282
3283         * ChangeLog:
3284         * DumpRenderTree/DumpRenderTree.m:
3285         (createWebView):
3286         (dumpRenderTree):
3287         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
3288         (+[LayoutTestController webScriptNameForSelector:]):
3289         (-[LayoutTestController setCustomPolicyDelegate:]):
3290         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3291         * DumpRenderTree/FrameLoadDelegate.h:
3292         * DumpRenderTree/PolicyDelegate.h: Added.
3293         * DumpRenderTree/PolicyDelegate.m: Added.
3294         (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
3295         * DumpRenderTree/ResourceLoadDelegate.h:
3296
3297 2007-07-25  Adam Treat  <treat@kde.org>
3298
3299         Reviewed by Niko.
3300
3301         Fix build for some reported systems.
3302
3303         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3304
3305 2007-07-23  Adam Treat  <treat@kde.org>
3306
3307         Reviewed by Nikolas.
3308
3309         Fix qt DRT to suppress js popup alerts and log instead.
3310
3311         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3312         (WebCore::WebPage::javaScriptAlert):
3313
3314 2007-07-22  Holger Hans Peter Freyther  <zecke@selfish.org>
3315
3316         Reviewed by Adam.
3317
3318         Make the GdkLauncher use the new WebKit/Gtk API. Change webkitdirs.pm to
3319         honor --qmakearg for the Gdk/Gtk build as well.
3320
3321         * GdkLauncher/main.cpp: Switch to the new API
3322         * Scripts/webkitdirs.pm: Allow to specify --qmakearg, e.g. to control the WEBKIT_{INC,LIB}_DIR 
3323
3324 2007-07-22  Darin Adler  <darin@apple.com>
3325
3326         * DumpRenderTree/TextInputController.m: (-[TextInputController interpretKeyEvents:withSender:]):
3327         Fix a leak by releasing the array used here.
3328
3329 2007-07-22  David Kilzer  <ddkilzer@webkit.org>
3330
3331         Reviewed by Darin.
3332
3333         - fix http://bugs.webkit.org/show_bug.cgi?id=14713
3334           Script to update iExploder cssproperties.in file based on CSSPropertyNames.in
3335
3336         Added script to update WebKitTools/iExploder/htdocs/cssproperties.in based on the contents
3337         of WebCore/css/CSSPropertyNames.in.  Also updated cssproperties.in.
3338
3339         * Scripts/update-iexploder-cssproperties: Added.
3340         * iExploder/htdocs/cssproperties.in: Updated by running update-iexploder-cssproperties script.
3341         Added new CSS3 property section and Moved box-sizing property to it.
3342
3343 2007-07-22  Oliver Hunt  <oliver@apple.com>
3344
3345         Reviewed by Darin.
3346
3347         http://bugs.webkit.org/show_bug.cgi?id=14710
3348
3349         Add preliminary support for testing Input Method/WebKit behaviour and interaction 
3350         in DRT.  This provides the NSTextInput API which is most of what should be necessary
3351         to mimic the event sequences Input Methods trigger.
3352
3353         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3354         * DumpRenderTree/TextInputController.h:
3355         * DumpRenderTree/TextInputController.m:
3356         (-[WebHTMLView interpretKeyEvents:]):
3357         (+[TextInputController isSelectorExcludedFromWebScript:]):
3358         (+[TextInputController webScriptNameForSelector:]):
3359         (-[TextInputController initWithWebView:]):
3360         (-[TextInputController dealloc]):
3361         (-[TextInputController textInput]):
3362         (-[TextInputController setInputMethodHandler:]):
3363         (-[TextInputController interpretKeyEvents:withSender:]):
3364
3365 2007-07-20  Adam Roben  <aroben@apple.com>
3366
3367         * Scripts/commit-log-editor: Small fix to make an all-whitespace log
3368         message not count as an existing log.
3369
3370 2007-07-19  Geoffrey Garen  <ggaren@apple.com>
3371
3372         Reviewed by Darin Adler.
3373         
3374         Updated DumpRenderTree for <rdar://problem/5348384> Restore old return 
3375         value behavior of stringByEvaluatingJavaScriptFromString
3376
3377         * DumpRenderTree/DumpRenderTree.m:
3378         (testStringByEvaluatingJavaScriptFromString):
3379         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3380
3381 2007-07-19  Adam Roben  <aroben@apple.com>
3382
3383         Make commit-log-editor work with git
3384
3385         Reviewed by Sam.
3386
3387         * Scripts/commit-log-editor: Use VCSUtils and accept a git-style
3388         commit message template. Also removed the unused $breakPoint variable.
3389
3390 2007-07-19  Adam Roben  <aroben@apple.com>
3391
3392         Move generally-useful VCS code into a new VCSUtils.pm module
3393
3394         This is in preparation for making commit-log-editor git-friendly.
3395
3396         Reviewed by Sam.
3397
3398         * Scripts/VCSUtils.pm: Added. Code moved here from prepare-ChangeLog.
3399         * Scripts/prepare-ChangeLog: Use VCSUtils.
3400
3401 2007-07-19  Lars Knoll <lars@trolltech.com>
3402
3403         Fix a crash on exit when running DRT against a current
3404         Qt 4.4 snapshot.
3405
3406         Reviewed by Zack
3407
3408         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
3409         (main):
3410
3411 2007-07-18  Adam Roben  <aroben@apple.com>
3412
3413         Don't try to use an SSL certificate on Windows until <rdar://problem/5345985> is fixed
3414
3415         Reviewed by Mark.
3416
3417         * Scripts/run-webkit-httpd:
3418         * Scripts/run-webkit-tests:
3419
3420 2007-07-18  Adam Roben  <aroben@apple.com>
3421
3422         More git friendliness for prepare-ChangeLog
3423
3424         The overall change is to remove the use of git-status and replace it
3425         with git-diff --name-status (which we were already using in the
3426         --git-commit case).
3427
3428         This lets us respect directories specified on the command line when
3429         using git, just as we do for Subversion. It also speeds things up a
3430         bit, especially in the subdirectory case, as git-status is pretty slow.
3431
3432         I also fixed some issues where we wouldn't detect copied files and
3433         would reverse the new filename and the original filename for renamed files.
3434
3435         Reviewed by Mark.
3436
3437         * Scripts/prepare-ChangeLog:
3438         (sub diffFromToString): Added.
3439         (sub diffCommand): Don't append the paths in the --git-commit case, as
3440         we should be operating on the entire commit.
3441         (sub statusCommand): Always use git-diff --name-status, and added an
3442         extra -C option to git-diff to make it find a few more copied files.
3443         (sub createPatchCommand): Collapsed the two git cases a bit, and added
3444         the extra -C option as above.
3445         (sub generateFileList): Remove the git-status codepath, and recognize
3446         file copies in the --name-status output.
3447         (sub isModifiedOrAddedStatus): Collapsed the status codes into one
3448         dictionary.
3449         (sub isConflictStatus): Updated the git dictionary.
3450         (sub statusDescription): Updated the git dictionary.
3451
3452 2007-07-18  Timothy Hatcher  <timothy@apple.com>
3453
3454         * Scripts/build-drosera: Update where we look for the Xcode project.
3455
3456 2007-07-18  Adam Treat <treat@kde.org>
3457
3458         Reviewed by bdash.
3459
3460         Use the old wording for Safari.
3461
3462         * Scripts/build-webkit:
3463         * Scripts/webkitdirs.pm:
3464
3465 2007-07-18  Adam Treat <treat@kde.org>
3466
3467         Reviewed by bdash.
3468
3469         Add convenience script for launching test apps for Qt and Gdk ports.
3470         Change the build-webkit script accordingly.
3471
3472         * Scripts/build-webkit:
3473         * Scripts/run-launcher: Added.
3474         * Scripts/webkitdirs.pm:
3475
3476 2007-07-18  Timothy Hatcher  <timothy@apple.com>
3477
3478         Reviewed by Adam.
3479
3480         Make the Page with the now required InspectorClient.
3481
3482         * GdkLauncher/main.cpp:
3483         (main):
3484
3485 2007-07-18  Timothy Hatcher  <timothy@apple.com>
3486
3487         Remove the redundant copies of Makefile.shared and the new Makefile.Drosera.
3488         Now included the main Makefile.shared and change the SCRIPTS_PATH variable as needed.
3489
3490         * Drosera/Makefile: Added.
3491         * Drosera/mac/Makefile:
3492         * DumpRenderTree/Makefile:
3493         * Makefile:
3494         * Makefile.Drosera: Removed.
3495         * Makefile.shared: Removed.
3496
3497 2007-07-18  Timothy Hatcher  <timothy@apple.com>
3498
3499         The console log was 20px down from the top for no reason, move it up.
3500
3501         * Drosera/console.css:
3502
3503 2007-07-18  Timothy Hatcher  <timothy@apple.com>
3504
3505         Use contentDocument to get the source view's iframe document.
3506         Also adds a null/undefined check for localVariableNames.
3507
3508         * Drosera/debugger.js:
3509
3510 2007-07-18  Lars Knoll <lars@trolltech.com>
3511
3512         We really don't want to compare non text only tests to the 
3513         Mac results if we don't have a result for Qt, as this would
3514         give a failure and not a notification that the test is new.
3515
3516         Reviewed by Zack
3517
3518         * Scripts/run-webkit-tests:
3519
3520 2007-07-18  Lars Knoll <lars@trolltech.com>
3521
3522         Reviewed by Zack & Simon
3523
3524         Adjust to changed API in QWebFrame
3525
3526         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3527         (WebCore::DumpRenderTree::DumpRenderTree):
3528
3529 2007-07-18  Mark Rowe  <mrowe@apple.com>
3530
3531         Update path to the Drosera Xcode project now that it has moved into a subdirectory.
3532
3533         * BuildSlaveSupport/build-launcher-app:
3534
3535 2007-07-17  Geoffrey Garen  <ggaren@apple.com>
3536
3537         Reviewed by Antti Koivisto.
3538         
3539         Added watchdog timer to waitUntilDone to prevent a run-away test from
3540         hanging the test harness.
3541
3542         * DumpRenderTree/DumpRenderTree.m:
3543         (dump):
3544         (-[LayoutTestController waitUntilDone]):
3545         (-[LayoutTestController waitUntilDoneWatchdogFired]):
3546         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3547
3548 2007-07-17  Kevin McCullough  <kmccullough@apple.com>
3549
3550         Reviewed by Adam.
3551
3552         - Implemented cross-platform code for functions calling into the JavaScript.
3553