0f6c739186c2efd7bb572f64fb652909f4266122
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
2
3         Reviewed by Kenneth Rohde Christiansen.
4
5         [Qt] Watchdog timer implementation for WTR
6         https://bugs.webkit.org/show_bug.cgi?id=47337
7
8         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Factor out
9         the definition of the timer type to a typedef.
10         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: Added.
11         Timer implementation with QTimer and a helper QObject class.
12         (WTR::WatchdogTimerHelper::instance):
13         (WTR::WatchdogTimerHelper::timerFired):
14         (WTR::WatchdogTimerHelper::WatchdogTimerHelper):
15         (WTR::LayoutTestController::platformInitialize):
16         (WTR::LayoutTestController::invalidateWaitToDumpWatchdogTimer):
17         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
18
19 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
20
21         Unreviewed buildfix for 69297 again
22
23         * WebKitTestRunner/TestController.cpp:
24         (WTR::blankURL):
25
26 2010-10-07  Balazs Kelemen  <Balazs Kelemen>
27
28         Unreviewed trivial build fix for r69297
29
30         * WebKitTestRunner/TestController.cpp:
31         (WTR::blankURL):
32
33 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
34
35         Reviewed by Kenneth Rohde Christiansen.
36
37         WebKitTestRunner should be portable
38         https://bugs.webkit.org/show_bug.cgi?id=45393
39
40         Use only the WebKit API for working with urls.
41         * WebKitTestRunner/StringFunctions.h:
42         (WTR::createWKURL):
43         * WebKitTestRunner/TestController.cpp:
44         (WTR::blankURL):
45         (WTR::TestController::resetStateToConsistentValues):
46         (WTR::TestController::didFinishLoadForFrame):
47
48 2010-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
49
50         Reviewed by Xan Lopez.
51
52         [GTK] Use gtk_widget_draw() instead of gtk_widget_get_snapshot() in PixelDumpSupportGtk when building with gtk3
53         https://bugs.webkit.org/show_bug.cgi?id=47332
54
55         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
56         (createBitmapContextFromWebView):
57
58 2010-10-06  Chris Guillory  <chris.guillory@google.com>
59
60         Reviewed by Chris Fleizach.
61
62         Remove unused accessibility functions from webkit.
63         https://bugs.webkit.org/attachment.cgi?bugid=46707
64
65         * DumpRenderTree/chromium/WebViewHost.cpp:
66         (WebViewHost::postAccessibilityNotification):
67         * DumpRenderTree/chromium/WebViewHost.h:
68
69 2010-10-06  Lucas Forschler  <lforschler@apple.com>
70
71         Reviewed by Adam Roben.
72
73         Fix the sunspider-compare-results to actually use the passed in value for $root.
74
75         * Scripts/sunspider-compare-results:
76
77 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
78
79         Reviewed by Kenneth Rohde Christiansen.
80
81         [Qt] Runloop implementation for WTR
82         https://bugs.webkit.org/show_bug.cgi?id=47280
83
84         * WebKitTestRunner/qt/TestControllerQt.cpp:
85         Implemented TestController::runUntil by a timerEvent
86         and a QEventLoop. We step into the event loop from runUntil.
87         While we are waiting in the loop a timerEvent is periodically
88         checking the value of the condition. Once the condition has
89         becoming true the timerEvent wakes us up.
90         (WTR::RunUntilLoop::start):
91         (WTR::RunUntilLoop::RunUntilLoop):
92         (WTR::RunUntilLoop::run):
93         (WTR::RunUntilLoop::timerEvent):
94         (WTR::TestController::platformInitialize):
95         (WTR::TestController::runUntil):
96         * WebKitTestRunner/qt/main.cpp:
97         Start the main event loop first and creating the TestController later.
98         (Launcher::Launcher):
99         (Launcher::~Launcher):
100         (Launcher::launch): Creating the TestController.
101         (main): Setting up a timer for calling Launcher::launch from
102         the main event loop.
103
104 2010-10-06  Dirk Pranke  <dpranke@chromium.org>
105
106         Reviewed by Kenneth Russell.
107
108         new-run-webkit-tests: fix typo in chromium-gpu that was trying to
109         enable 'accelerated-composting' instead of 'accelerated-compositing'.
110
111         https://bugs.webkit.org/show_bug.cgi?id=47312
112
113         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
114         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
115
116 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
117
118         Reviewed by Kenneth Rohde Christiansen.
119
120         [Qt] PlatformWebView implementation for WebKitTestRunner
121         https://bugs.webkit.org/show_bug.cgi?id=47276
122
123         The implementation follows the way how
124         we use the API in MiniBrowser.
125         * WebKitTestRunner/PlatformWebView.h:
126         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
127         (WTR::WebView::wkView):
128         (WTR::WebView::~WebView):
129         (WTR::WebView::WebView):
130         (WTR::PlatformWebView::PlatformWebView):
131         (WTR::PlatformWebView::~PlatformWebView):
132         (WTR::PlatformWebView::resizeTo):
133         (WTR::PlatformWebView::page):
134         (WTR::PlatformWebView::focus):
135         * WebKitTestRunner/qt/WebKitTestRunner.pro:
136
137 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
138
139         Reviewed by Kenneth Rohde Christiansen.
140
141         [Qt] Add WebKitTestRunner's build files
142         https://bugs.webkit.org/show_bug.cgi?id=44155
143
144         Parts was taken by Zoltan Horvath's patch.
145
146         * Scripts/generate-forwarding-headers.pl: Moved from WebKit2.
147         * Scripts/webkitdirs.pm: Make the generated files needed by WTR.
148         * WebKitTestRunner/PlatformWebView.h: Addeed typedefs for
149         PlatformWKView and PlatformWindow (void* for now).
150         Buildfix the case when __APPLE__ is not defined.
151         * WebKitTestRunner/qt/DerivedSources.pro: Added.
152         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Added.
153         Empty stub implementation.
154         (WTR::registerWindowClass):
155         (WTR::PlatformWebView::PlatformWebView):
156         (WTR::PlatformWebView::~PlatformWebView):
157         (WTR::PlatformWebView::resizeTo):
158         (WTR::PlatformWebView::page):
159         (WTR::PlatformWebView::focus):
160         * WebKitTestRunner/qt/TestControllerQt.cpp: Added.
161         Empty stub implementation.
162         (WTR::registerWindowClass):
163         (WTR::TestController::runUntil):
164         (WTR::TestController::platformInitialize):
165         (WTR::TestController::initializeInjectedBundlePath):
166         (WTR::TestController::initializeTestPluginDirectory):
167         (WTR::TestController::platformInitializeContext):
168         * WebKitTestRunner/qt/WebKitTestRunner.pro: Added.
169         * WebKitTestRunner/qt/main.cpp: Added.
170         (main):
171
172 2010-10-06  Tony Chang  <tony@chromium.org>
173
174         Unreviewed, rolling out r69202.
175         http://trac.webkit.org/changeset/69202
176         https://bugs.webkit.org/show_bug.cgi?id=46937
177
178         Broke compile of test_shell
179
180         * DumpRenderTree/chromium/EventSender.cpp:
181         (EventSender::beginDragWithFiles):
182         * DumpRenderTree/chromium/WebViewHost.cpp:
183         (addDRTFakeFileToDataObject):
184
185 2010-10-06  Daniel Cheng  <dcheng@chromium.org>
186
187         Reviewed by Tony Chang.
188
189         [chromium] Minor naming cleanup in WebDragData, part 2
190         https://bugs.webkit.org/show_bug.cgi?id=46937
191
192         Update DRT to use the renamed methods.
193
194         * DumpRenderTree/chromium/EventSender.cpp:
195         (EventSender::beginDragWithFiles):
196         * DumpRenderTree/chromium/WebViewHost.cpp:
197         (addDRTFakeFileToDataObject):
198
199 2010-10-06  David Kilzer  <ddkilzer@apple.com>
200
201         <http://webkit.org/b/47270> Move WebArchive serialization code into its own file
202
203         Reviewed by Adam Roben.
204
205         This is the first step in making webarchive tests work on
206         Windows.
207
208         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added
209         new files to the project.
210         * DumpRenderTree/mac/DumpRenderTree.mm: Removed code that moved
211         to WebArchiveDumpSupport.mm.
212         * DumpRenderTree/mac/WebArchiveDumpSupport.h: Added.
213         * DumpRenderTree/mac/WebArchiveDumpSupport.mm: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm.
214         (serializeWebArchiveToXML):
215
216 2010-10-05  Daniel Bates  <dbates@rim.com>
217
218         Reviewed by David Kilzer.
219
220         Add infrastructure to towards detecting change log diffs that aren't at the top of the ChangeLog
221         https://bugs.webkit.org/show_bug.cgi?id=46058
222
223         Make VCSUtils::fixChangeLogPatch() return a reference to a hash
224         structure so as to support returning additional information
225         about a change log diff.
226
227         Currently, VCSUtils::fixChangeLogPatch() returns a string that
228         represents the change log diff. Towards supporting the return
229         of additional information, such as whether the change log diff
230         inserts an entry at the top of the ChangeLog file, we need to
231         make VCSUtils::fixChangeLogPatch() return a reference to hash
232         structure.
233
234         * Scripts/VCSUtils.pm:
235           - Modified fixChangeLogPatch() to return a reference to a
236             hash structure.
237           - Added documentation to fixChangeLogPatch().
238           - Modified call site in mergeChangeLogs() as necessary.
239         * Scripts/svn-apply:
240           - Modified call site in patch() as necessary.
241         * Scripts/svn-create-patch:
242           - Modified call site in generateDiff() as necessary.
243         * Scripts/svn-unapply:
244           - Modified call site in patch() as necessary.
245         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
246           - Modified the unit tests as necessary.
247
248 2010-10-05  Tony Chang  <tony@chromium.org>
249
250         Reviewed by Darin Adler.
251
252         fix the link to the expected image on windows
253         https://bugs.webkit.org/show_bug.cgi?id=47228
254
255         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: On
256             windows, the file must be opened in binary mode when writing
257             binary data.
258
259 2010-10-05  Adam Barth  <abarth@webkit.org>
260
261         Update expected result of unittest to match Tony's change below.
262
263         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
264
265 2010-10-05  Tony Chang  <tony@chromium.org>
266
267         Reviewed by Ojan Vafai (over the shoulder).
268
269         Paper over errors in image_diff so we don't crash the whole test run.
270
271         * Scripts/webkitpy/layout_tests/port/chromium.py:
272
273 2010-10-05  Tony Chang  <tony@chromium.org>
274
275         Unreviewed, make shutil.rmtree more resiliant to errors
276         since windows was raising WindowsError: The process cannot access the file because it
277         is being used by another process.
278
279         * Scripts/webkitpy/layout_tests/port/chromium.py:
280
281 2010-10-05  Tony Chang  <tony@chromium.org>
282
283         Reviewed by Ojan Vafai.
284
285         [chromium] fix image diffing in NRWT
286         https://bugs.webkit.org/show_bug.cgi?id=47128
287
288         * Scripts/webkitpy/layout_tests/port/chromium.py: Stop using
289             NamedTemporaryFile since it doesn't work on Windows.
290         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
291
292 2010-10-05  Kenneth Russell  <kbr@google.com>
293
294         Reviewed by Tony Chang.
295
296         [chromium] Implement layerTreeAsText in DumpRenderTree
297         https://bugs.webkit.org/show_bug.cgi?id=47216
298
299         Plumbed Frame::layerTreeAsText through Chromium's WebKit API to
300         make it callable from DumpRenderTree.
301
302         No new tests; verified with existing compositor layout tests.
303
304         * DumpRenderTree/chromium/LayoutTestController.cpp:
305         (LayoutTestController::LayoutTestController):
306         (LayoutTestController::layerTreeAsText):
307         * DumpRenderTree/chromium/LayoutTestController.h:
308
309 2010-10-05  Brent Fulgham  <bfulgham@webkit.org>
310
311         Unreviewed build correction.
312
313         * DumpRenderTree/win/ImageDiff.vcproj: Use WinCairo debug
314         property sheet so proper libraries are linked.
315
316 2010-10-05  Robert Hogan  <robert@webkit.org>
317
318         Reviewed by Andreas Kling.
319
320         [Qt] Fix url conversion in QWebHistory
321
322         Converting from KURL to WFT::String to QUrl does not
323         permit proper percent encoding later.
324
325         https://bugs.webkit.org/show_bug.cgi?id=47048
326
327         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
328         (WebCore::dumpHistoryItem):
329
330 2010-10-05  Anders Carlsson  <andersca@apple.com>
331
332         Reviewed by Sam Weinig.
333
334         REGRESSION (r68966?): All dumpAsText test fail on WebKit2
335         https://bugs.webkit.org/show_bug.cgi?id=47188
336         <rdar://problem/8514104>
337
338         When constructing the std::string, use the real string length instead of the maximum buffer size.
339
340         * TestWebKitAPI/PlatformUtilities.h:
341         (TestWebKitAPI::Util::toSTD):
342         * WebKitTestRunner/StringFunctions.h:
343         (WTR::toSTD):
344
345 2010-10-04  Sam Weinig  <sam@webkit.org>
346
347         Reviewed by Mark Rowe.
348
349         Add MIMEType accessor to WKFrame
350         <rdar://problem/8347683>
351         https://bugs.webkit.org/show_bug.cgi?id=47138
352
353         * TestWebKitAPI/PlatformUtilities.h:
354         (TestWebKitAPI::Util::toSTD):
355         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
356         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: Added.
357         (TestWebKitAPI::didStartProvisionalLoadForFrame):
358         (TestWebKitAPI::didCommitLoadForFrame):
359         (TestWebKitAPI::didFinishLoadForFrame):
360         (TestWebKitAPI::TEST):
361         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: Added.
362         (TestWebKitAPI::didStartProvisionalLoadForFrame):
363         (TestWebKitAPI::didCommitLoadForFrame):
364         (TestWebKitAPI::didFinishLoadForFrame):
365         (TestWebKitAPI::TEST):
366         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
367         (TestWebKitAPI::TEST):
368         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Removed.
369         * TestWebKitAPI/Tests/WebKit2/icon.png: Added.
370         * TestWebKitAPI/Tests/WebKit2/simple.html: Added.
371         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
372         (TestWebKitAPI::Util::createURLForResource):
373
374 2010-10-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
375
376         Reviewed by Ojan Vafai.
377
378         [NRWT] Rename current_dir to current_group because it's not a directory
379         https://bugs.webkit.org/show_bug.cgi?id=47169
380
381         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
382         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
383
384 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
385
386         Unreviewed, build fix.
387
388         r69065 broke test-webkitpy by trying to create a '/tmp-X' directory,
389         which can't always be done. This test uses tempfile.mkdtemp(), which
390         should be safe.
391
392         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
393
394 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
395
396         Unreviewed, build fix.
397
398         Add missing "from __future__ import with_statement" that was
399         breaking test-webkitpy on the Leopard bots (broke in r69040).
400
401         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
402
403 2010-10-04  Sheriff Bot  <webkit.review.bot@gmail.com>
404
405         Unreviewed, rolling out r69066.
406         http://trac.webkit.org/changeset/69066
407         https://bugs.webkit.org/show_bug.cgi?id=47163
408
409         Made NRWT reliability worse. (Requested by tkent on #webkit).
410
411         * Scripts/webkitpy/layout_tests/port/chromium.py:
412         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
413
414 2010-10-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
415
416         Reviewed by Tony Chang.
417
418         [NRWT] Reverse the http tests to alphabetical order.
419         https://bugs.webkit.org/show_bug.cgi?id=47075
420
421         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
422
423 2010-10-04  Robert Hogan  <robert@webkit.org>
424
425         Reviewed by Andreas Kling.
426
427         [Qt] Fix timeout on http/tests/navigation/post-goback2.html and postredirect-goback2.html
428
429         We need to queue back and forward navigations in the DRT from the
430         LayoutTestController so that maybeDump() knows about them.
431
432         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
433         (LayoutTestController::queueBackNavigation):
434         (LayoutTestController::queueForwardNavigation):
435
436 2010-10-04  Tony Chang  <tony@chromium.org>
437
438         Reviewed by Kent Tamura.
439
440         [chromium] fix image diffing in NRWT
441         https://bugs.webkit.org/show_bug.cgi?id=47128
442
443         * Scripts/webkitpy/layout_tests/port/chromium.py: Flush data to the
444               temp file and check the image_diff error code more carefully
445         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
446
447 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
448
449         Reviewed by Adam Barth.
450
451         aroben's change in r68792 actually broke new-run-webkit-tests when
452         running the DRT code path. His change was intended to fix the
453         way we were converting windows paths to URIs when running under
454         Cygwin (the paths were getting one too many "/" on the front).
455         However, the change ended up breaking the chromium_win port, which
456         had slightly different logic.
457
458         This patch removes the port-specific code and adds tests to make
459         sure we're getting the behavior we expect. The Port object no longer
460         exposes a get_absolute_path() method that can be used outside of
461         of converting test filenames, because it's unreliable otherwise
462         (we don't have the right context to know which conversion is intended).
463
464         https://bugs.webkit.org/show_bug.cgi?id=47140
465
466         * Scripts/webkitpy/layout_tests/port/base.py:
467         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
468         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
469         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
470         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
471
472 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
473
474         Unreviewed, build fix.
475
476         Handle crash introduced in r69040 if we are not running in a
477         Chromium checkout.
478
479         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
480
481 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
482
483         Reviewed by Tony Chang.
484
485         Add a way for us to have test expectations that are specific to the
486         official builds of Google Chrome (as opposed to Chromium). This change
487         looks for an additional "test_expectations_chrome.txt" file in
488         Chromium's repository (webkit/tools/layout_tests), and uses the
489         concatenation of that file and the regular test_expectations.txt
490         file for test overrides.
491
492         https://bugs.webkit.org/show_bug.cgi?id=46854
493
494         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
495         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
496
497 2010-10-04  Simon Fraser  <simon.fraser@apple.com>
498
499         Color tests in the list based on existing pass/fail result.
500         
501         Fix the summary data to account for htmlOnly and nonHTML tests.
502
503         * CSSTestSuiteHarness/harness/harness.css:
504         (#test-list > option.pass):
505         (#test-list > option.fail):
506         (#test-list > option.skipped):
507         * CSSTestSuiteHarness/harness/harness.js:
508         (Test):
509         (Test.prototype.statusForFormat):
510         (TestSuite.prototype.fillTestList):
511         (TestSuite.prototype.updateTestList):
512         (TestSuite.prototype.recordResult):
513         (TestSuite.prototype.markTestCompleted):
514         (TestSuite.prototype.countTestsWithFlag):
515         (TestSuite.prototype.queryDatabaseForSummary.this.db.transaction):
516         (TestSuite.prototype.queryDatabaseForSummary):
517
518 2010-10-04  Chris Fleizach  <cfleizach@apple.com>
519
520         Reviewed by Beth Dakin.
521
522         AX: doAXRangeForLine does not work
523         https://bugs.webkit.org/show_bug.cgi?id=47101
524
525         DRT support to handle NSAccessibilityRangeForLineParameterizedAttribute.
526
527         * DumpRenderTree/AccessibilityUIElement.cpp:
528         (rangeForLineCallback):
529         (AccessibilityUIElement::rangeForLine):
530         (AccessibilityUIElement::getJSClass):
531         * DumpRenderTree/AccessibilityUIElement.h:
532         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
533         (AccessibilityUIElement::rangeForLine):
534
535 2010-10-04  Andrey Kosyakov  <caseq@chromium.org>
536
537         Unreviewed. Adding myself to the committers list.
538
539         * Scripts/webkitpy/common/config/committers.py:
540
541 2010-10-04  Sam Weinig  <sam@webkit.org>
542
543         Reviewed by Anders Carlsson.
544
545         Add ability to set the CacheModel in Webkit2
546         https://bugs.webkit.org/show_bug.cgi?id=47066
547
548         * MiniBrowser/mac/AppDelegate.m:
549         (-[BrowserAppDelegate init]): Opt minibrowser into
550         a PrimaryWebBrowser cache model.
551
552 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
553
554         Make sure to enter all tests when creating the database
555         for the first time.
556         
557         When migrating to a new version of the suite, be sure to
558         sync up the database and testinfo.data by removing old
559         tests, and inserting new ones.
560
561         * CSSTestSuiteHarness/harness/harness.js:
562         (TestSuite.prototype.openDatabase.creation):
563         (TestSuite.prototype.databaseCreated):
564         (TestSuite.prototype.populateDatabaseFromTestInfoData):
565         (TestSuite.prototype.insertTest):
566
567 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
568
569         More work on treating HTML4 and XHTML1 independently; when 
570         changing the format, rebuild the test list, and update the 
571         numbers in the chapter popup.
572
573         * CSSTestSuiteHarness/harness/harness.js:
574         (Test):
575         (Test.prototype.runForFormat):
576         (Test.prototype.completedForFormat):
577         (ChapterSection):
578         (ChapterSection.prototype.countTests):
579         (Chapter):
580         (Chapter.prototype.description):
581         (Chapter.prototype.countTests):
582         (Chapter.prototype.testCount):
583         (Chapter.prototype.untestedCount):
584         (TestSuite.prototype.buildChapters):
585         (TestSuite.prototype.loadCurrentTest):
586         (TestSuite.prototype.updateProgressLabel):
587         (TestSuite.prototype.processFlags):
588         (TestSuite.prototype.formatChanged):
589
590 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
591
592         Update test suite version 20101001.
593         
594         Handle database migration, and delete tests from the db that are
595         not present in testinfo.data.
596         
597         Load about:blank into the test frame before the test url, to make
598         missing tests more obvious.
599         
600         * CSSTestSuiteHarness/harness/harness.js:
601         (TestSuite.prototype.loadTest):
602         (TestSuite.prototype.openDatabase.creation):
603         (TestSuite.prototype.openDatabase.migration1_0To1_1):
604         (TestSuite.prototype.openDatabase.if.return):
605         (TestSuite.prototype.databaseReady):
606         (TestSuite.prototype.populateDatabaseFromTestInfoData):
607         (TestSuite.prototype.syncDatabaseWithTestInfoData.this.db.transaction):
608         (TestSuite.prototype.syncDatabaseWithTestInfoData):
609
610 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
611
612         Add the ability to jump to a specific test.
613
614         * CSSTestSuiteHarness/harness/harness.html:
615         * CSSTestSuiteHarness/harness/harness.js:
616         (TestSuite.prototype.goToTestByName):
617         (TestSuite.prototype.switchToFormat):
618
619 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
620
621         For a ref test, load the ref in the same format (HTML4 vs XHTML1)
622         as the test.
623
624         * CSSTestSuiteHarness/harness/harness.js:
625         (TestSuite.prototype.loadRef):
626
627 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
628
629         Update the UI to reflect the fact that each test needs to be tested
630         in both HTML4 and XHTML1 format.
631         
632         * CSSTestSuiteHarness/harness/harness.js:
633         (Test):
634         (Chapter.prototype.description):
635         (Chapter.prototype.untestedCount):
636         (TestSuite.prototype.fillChapterPopup):
637         (TestSuite.prototype.updateChapterPopup):
638         (TestSuite.prototype.fillTestList):
639         (TestSuite.prototype.updateTestList):
640         (TestSuite.prototype.goToNextIncompleteTest):
641         (TestSuite.prototype.firstIncompleteTestIndex):
642         (TestSuite.prototype.recordResult):
643         (TestSuite.prototype.formatChanged):
644         (TestSuite.prototype.markTestCompleted):
645         (TestSuite.prototype.resetTestStatus):
646
647 2010-10-01  Simon Fraser  <simon.fraser@apple.com>
648
649         Add the ability to remove results for re-testing, and
650         to import results.
651
652         * CSSTestSuiteHarness/harness/harness.css:
653         (.custom button):
654         (#overlay):
655         (#overlay.visible):
656         (.overlay-contents):
657         (.overlay-contents textarea):
658         (.overlay-contents .buttons):
659         (.overlay-contents .note):
660         (.overlay-contents .buttons button):
661         * CSSTestSuiteHarness/harness/harness.html:
662         * CSSTestSuiteHarness/harness/harness.js:
663         (TestSuite.prototype.importResults):
664         (TestSuite.prototype.clearResults):
665         (TestSuite.prototype.markTestCompleted):
666         (TestSuite.prototype.resetTestStatus):
667         (TestSuite.prototype.storeTestResult):
668         (TestSuite.prototype.importTestResults):
669         (TestSuite.prototype.clearTestResults):
670
671 2010-10-01  Sam Weinig  <sam@webkit.org>
672
673         Reviewed by Jon Honeycutt.
674
675         Deploy the new WKString functions to remove most uses of CF from
676         the WebKitTestRunner.
677
678         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
679         (WTR::InjectedBundle::didReceiveMessage):
680         (WTR::InjectedBundle::done):
681         * WebKitTestRunner/StringFunctions.h:
682         (WTR::toWK):
683         (WTR::toJS):
684         (WTR::toSTD):
685         (WTR::operator<<):
686         (WTR::copyURLString):
687         * WebKitTestRunner/TestController.cpp:
688         (WTR::TestController::resetStateToConsistentValues):
689         (WTR::TestController::didFinishLoadForFrame):
690         * WebKitTestRunner/TestInvocation.cpp:
691         (WTR::TestInvocation::invoke):
692         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
693
694 2010-10-01  Mihai Parparita  <mihaip@chromium.org>
695
696         Unreviewed TestResultsServer change.
697
698         Add files introduced by http://crrev.com/61273 to the list of dashboard 
699         files to update.
700
701         * TestResultServer/handlers/dashboardhandler.py:
702
703 2010-10-01  Brian Weinstein  <bweinstein@apple.com>
704
705         Build Fix for Windows.
706
707         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Don't copy ForwardingHeaders from
708             WebKitTestRunner/ForwardingHeaders, instead, add $(WebKitOutputDir)/include/WebCore/
709             ForwardingHeaders to the include path.
710
711 2010-10-01  Sam Weinig  <sam@webkit.org>
712
713         Reviewed by Anders Carlsson.
714
715         Add SPI to convert a WKStringRef to a JSStringRef and vice-versa.
716
717         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
718         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
719         (TestWebKitAPI::TEST):
720         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp: Added.
721         (TestWebKitAPI::TEST):
722
723 2010-10-01  Sam Weinig  <sam@webkit.org>
724
725         Reviewed by Kenneth Rohde Christiansen.
726
727         Add additional WKString API
728         https://bugs.webkit.org/show_bug.cgi?id=46958
729
730         Add basic WKStringRef tests.
731
732         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
733         * TestWebKitAPI/Tests/WebKit2/WKString.cpp: Added.
734
735 2010-10-01  Sam Weinig  <sam@webkit.org>
736
737         Reviewed by Dan Bernstein.
738
739         Add makefile for TestWebKitAPI and call it from the base makefile.
740
741         * Makefile:
742         * TestWebKitAPI/Makefile: Added.
743
744 2010-10-01  Sam Weinig  <sam@webkit.org>
745
746         Reviewed by Adam Roben.
747
748         Remove unnecessary ForwardingHeaders from test runners.
749         https://bugs.webkit.org/show_bug.cgi?id=47010
750
751         * TestWebKitAPI/Configurations/Base.xcconfig:
752         * TestWebKitAPI/ForwardingHeaders: Removed.
753         * WebKitTestRunner/Configurations/Base.xcconfig:
754         * WebKitTestRunner/ForwardingHeaders: Removed.
755
756 2010-09-30  Adam Barth  <abarth@webkit.org>
757
758         Reviewed by Eric Seidel.
759
760         WebSocket tests are flaky
761         https://bugs.webkit.org/show_bug.cgi?id=46956
762
763         Update these tools to understand how to run the WebSocket tests off the
764         Apache server.
765
766         * Scripts/old-run-webkit-tests:
767         * Scripts/webkitpy/layout_tests/port/base.py:
768         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
769         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
770
771 2010-10-01  Adam Roben  <aroben@apple.com>
772
773         Encode Executive command arguments using UTF-8 on Cygwin
774
775         Cygwin's Python's os.execv doesn't support unicode command arguments.
776         Cygwin's execv expects arguments to be encoded using the current code
777         page. But code pages are limited in what characters they can handle,
778         and our tests include characters that the English code page can't
779         handle.  So for now we'll just encode everything in UTF-8 on Cygwin,
780         which can handle all characters but might confuse some commands, for
781         expediency's sake. I'm sure we'll run into cases where UTF-8 isn't
782         good enough, but we can deal with that when the problem arises.
783
784         Reviewed by Adam Barth.
785
786         Fixes <http://webkit.org/b/46892> <rdar://problem/8496639>
787         webkitpy.common.system.executive_unittest.ExecutiveTest.test_run_command_with_unicode
788         fails on Windows
789
790         * Scripts/webkitpy/common/system/executive.py:
791         (Executive._run_command_with_teed_output):
792         (Executive.run_command):
793         On Cygwin, encode arguments using UTF-8.
794
795 2010-10-01  Sam Weinig  <sam@webkit.org>
796
797         Reviewed by Adam Roben.
798
799         Add simple API tester for WebKit2
800         https://bugs.webkit.org/show_bug.cgi?id=46953
801
802         This adds a very simple testing infrastructure for testing APIs exposed
803         through the WebKit project. It consists of two parts: 1) a project that
804         builds the all the tests 2) a script that searches the tests directory and
805         calls the tester once for each test.
806
807         This adds the infrastructure and two tests:
808         - Tests/WTF/Vector1.cpp - A proof of concept test of WTF data-structures.
809         - Tests/WebKit2/BasicTest1.cpp - A proof of concept test of WebKit2 API.
810
811         This currently only works on the mac, but is designed to be easily ported 
812         to any platform.
813
814         * Scripts/run-api-tests: Added.
815         * Scripts/build-api-tests: Added.
816         Scripts to build/run the tests.
817
818         * TestWebKitAPI: Added.
819         * TestWebKitAPI/Configurations: Added.
820         * TestWebKitAPI/Configurations/Base.xcconfig: Added.
821         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Added.
822         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Added.
823         * TestWebKitAPI/ForwardingHeaders: Added.
824         * TestWebKitAPI/ForwardingHeaders/wtf: Added.
825         * TestWebKitAPI/PlatformUtilities.h: Added.
826         * TestWebKitAPI/PlatformWebView.h: Added.
827         (TestWebKitAPI::PlatformWebView::platformView):
828         * TestWebKitAPI/StringFunctions.h: Added.
829         * TestWebKitAPI/Test.h: Added.
830         (TestWebKitAPI::Test::~Test):
831         (TestWebKitAPI::Test::name):
832         (TestWebKitAPI::Test::Register::Register):
833         (TestWebKitAPI::Test::Register::create):
834         (TestWebKitAPI::Test::Test):
835         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Added.
836         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added.
837         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added.
838         * TestWebKitAPI/TestsController.cpp: Added.
839         (TestWebKitAPI::TestsController::shared):
840         (TestWebKitAPI::TestsController::TestsController):
841         (TestWebKitAPI::TestsController::runTestNamed):
842         (TestWebKitAPI::TestsController::testFailed):
843         (TestWebKitAPI::TestsController::registerCreateTestFunction):
844         * TestWebKitAPI/TestsController.h: Added.
845         * TestWebKitAPI/mac: Added.
846         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: Added.
847         (TestWebKitAPI::Util::run):
848         (TestWebKitAPI::Util::createURLForResource):
849         * TestWebKitAPI/mac/PlatformWebViewMac.mm: Added.
850         (TestWebKitAPI::PlatformWebView::PlatformWebView):
851         (TestWebKitAPI::PlatformWebView::resizeTo):
852         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
853         (TestWebKitAPI::PlatformWebView::page):
854         (TestWebKitAPI::PlatformWebView::focus):
855         * TestWebKitAPI/mac/main.mm: Added.
856         Infrastructure.
857
858         * TestWebKitAPI/Tests: Added.
859         * TestWebKitAPI/Tests/WTF: Added.
860         * TestWebKitAPI/Tests/WTF/Vector1.cpp: Added.
861         * TestWebKitAPI/Tests/WebKit2: Added.
862         * TestWebKitAPI/Tests/WebKit2/BasicTest1.cpp: Added.
863         (TestWebKitAPI::State::State):
864         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Added.
865         Proof of concept tests.
866
867 2010-10-01  Adam Roben  <aroben@apple.com>
868
869         Don't assume AccessibleObjectFromEvent succeeds
870
871         Fixes <http://webkit.org/b/44136> <rdar://problem/8321684> Crash in
872         DumpRenderTree!notificationListenerProc when running
873         plugins/access-after-page-destroyed.html
874
875         Reviewed by Sam Weinig.
876
877         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
878         (notificationListenerProc): Check both the return value of
879         AccessibleObjectFromEvent and the object it returns, as MSDN
880         recommends.
881
882 2010-10-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
883
884         Reviewed by Tony Chang.
885
886         [NRWT] Put the http and websocket tests first in the test list.
887         https://bugs.webkit.org/show_bug.cgi?id=46453
888
889         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
890         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
891
892 2010-10-01  Fady Samuel  <fsamuel@chromium.org>
893
894         Unreviewed, adding myself to the committer list.
895
896         * Scripts/webkitpy/common/config/committers.py:
897
898 2010-10-01  Adam Roben  <aroben@apple.com>
899
900         Test NPN_GetValue(NPNVnetscapeWindow)
901
902         Test for <http://webkit.org/b/46726> <rdar://problem/8486319>
903         Right-clicking on windowless Flash plugin in WebKit2 makes a context
904         menu appear in the bottom-right corner of the screen
905
906         Reviewed by Anders Carlsson.
907
908         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
909         (PluginTest::NPN_GetValue): Added. Calls through to the browser.
910
911         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added NPN_GetValue.
912
913         * DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp: Added.
914         (GetValueNetscapeWindow::GetValueNetscapeWindow): Initialize members.
915         (GetValueNetscapeWindow::NPP_SetWindow): Test that
916         NPN_GetValue(NPNVnetscapeWindow) returns a valid HWND and that it
917         isn't our HWND.
918
919         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
920         Added GetValueNetscapeWindow.
921
922 2010-10-01  Andreas Kling  <andreas.kling@nokia.com>
923
924         Unreviewed, adding my webkit.org identity to reviewer list.
925
926         * Scripts/webkitpy/common/config/committers.py:
927
928 2010-09-30  Adam Barth  <abarth@webkit.org>
929
930         Reviewed by Eric Seidel.
931
932         The WebSocket server should flush its logs
933         https://bugs.webkit.org/show_bug.cgi?id=46946
934
935         The WebSocket server logs are truncated because the driver just
936         terminates the child.  It should run Python without buffering so we can
937         see the end of the log.
938
939         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
940
941 2010-09-30  Simon Fraser  <simon.fraser@apple.com>
942
943         Add a button to jump to the next untested test.
944         
945         * CSSTestSuiteHarness/harness/harness.css:
946         (.test-type):
947         (.name > button):
948         * CSSTestSuiteHarness/harness/harness.html:
949         * CSSTestSuiteHarness/harness/harness.js:
950         (Chapter.prototype.description):
951         (Chapter.prototype.untestedCount):
952         (TestSuite.prototype.testInfoDataLoaded):
953         (TestSuite.prototype.fillChapterPopup):
954         (TestSuite.prototype.updateChapterPopup):
955         (TestSuite.prototype.buildTestListForChapter):
956         (TestSuite.prototype.goToNextIncompleteTest):
957         (TestSuite.prototype.firstIncompleteTestIndex):
958         (TestSuite.prototype.testCompletionStateChanged):
959
960 2010-09-29  Jon Honeycutt  <jhoneycutt@apple.com>
961
962         WebKit2 on Windows should use Windows fonts for the various standard
963         font families
964         https://bugs.webkit.org/show_bug.cgi?id=43499
965         <rdar://problem/8272758>
966
967         Reviewed by Adam Roben.
968
969         * WebKitTestRunner/TestController.cpp:
970         (WTR::TestController::resetStateToConsistentValues):
971         Use the Mac fonts for running tests. This matches DRT behavior.
972
973 2010-09-30  Adam Barth  <abarth@webkit.org>
974
975         Third attempt.  We need a better integration test environment.
976
977         * Scripts/webkitpy/common/net/failuremap.py:
978         * Scripts/webkitpy/common/net/failuremap_unittest.py:
979
980 2010-09-30  Robert Hogan  <robert@webkit.org>
981
982         Reviewed by Andreas Kling.
983
984         [Qt] Support for PlainTextController
985
986         Unskip editing/text-iterator/basic-iteration.html
987
988         https://bugs.webkit.org/show_bug.cgi?id=38805
989
990         * DumpRenderTree/qt/DumpRenderTree.pro:
991         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
992         (WebCore::DumpRenderTree::DumpRenderTree):
993         (WebCore::DumpRenderTree::initJSObjects):
994         * DumpRenderTree/qt/DumpRenderTreeQt.h:
995         * DumpRenderTree/qt/PlainTextControllerQt.cpp: Added.
996         (PlainTextController::PlainTextController):
997         (PlainTextController::plainText):
998         * DumpRenderTree/qt/PlainTextControllerQt.h: Added.
999
1000 2010-09-30  Adam Barth  <abarth@webkit.org>
1001
1002         Unreviewed.  Second attempt to fix sheriffbot.
1003
1004         * Scripts/webkitpy/common/net/buildbot.py:
1005
1006 2010-09-30  Adam Barth  <abarth@webkit.org>
1007
1008         Unreviewed.
1009
1010         This patch should stop the sheriffbot from throwing an exception.
1011
1012         * Scripts/webkitpy/common/net/buildbot.py:
1013
1014 2010-09-30  Brian Weinstein  <bweinstein@apple.com>
1015
1016         Reviewed by Adam Roben.
1017
1018         The same bots shouldn't run both Windows Debug Tests and Windows Release Tests.
1019         https://bugs.webkit.org/show_bug.cgi?id=46926
1020
1021         * BuildSlaveSupport/build.webkit.org-config/config.json: Have two bots running Windows 
1022             Release Tests, and two bots running Windows Debug Tests, instead of four running both.
1023
1024 2010-09-30  Adam Barth  <abarth@webkit.org>
1025
1026         Reviewed by Eric Seidel.
1027
1028         webkit-patch find-flaky-tests should print results URLs
1029         https://bugs.webkit.org/show_bug.cgi?id=46917
1030
1031         Printing out the results URL makes find-flaky-tests more actionable
1032         because you can see what happens when a test fails.  The output from
1033         the script is still pretty noisy, but it seems useful.
1034
1035         * Scripts/webkitpy/tool/commands/queries.py:
1036
1037 2010-09-30  Chris Marrin  <cmarrin@apple.com>
1038
1039         Reviewed by Simon Fraser.
1040
1041         Make 2D accelerated canvas rendering build on Mac
1042         https://bugs.webkit.org/show_bug.cgi?id=46007
1043         
1044         Added ACCELERATED_2D_CANVAS to build-webkit
1045
1046         * Scripts/build-webkit:
1047
1048 2010-09-29  Kenneth Russell  <kbr@google.com>
1049
1050         Reviewed by Dimitri Glazkov.
1051
1052         [chromium] Add accelerated compositing support to DumpRenderTree and test_shell
1053         https://bugs.webkit.org/show_bug.cgi?id=46849
1054
1055         Added offscreen code path for WebGraphicsContext3DDefaultImpl which
1056         works with the compositor integration in both DumpRenderTree and
1057         test_shell, since both pass a non-null WebCanvas* to WebViewImpl::paint
1058         and thereby trigger the compositor's readback code path. Added support
1059         for --enable-accelerated-compositing to DumpRenderTree.
1060
1061         Tested in both test_shell and DumpRenderTree on Linux, the latter by
1062         modifying a compositing layout test, dumping the pixels and verifying
1063         that they matched the output when the compositor was active.
1064
1065         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1066         (main):
1067         * DumpRenderTree/chromium/TestShell.cpp:
1068         (TestShell::TestShell):
1069         (TestShell::resetWebSettings):
1070         * DumpRenderTree/chromium/TestShell.h:
1071         (TestShell::setAcceleratedCompositingEnabled):
1072         * DumpRenderTree/chromium/WebPreferences.cpp:
1073         (WebPreferences::reset):
1074         (WebPreferences::applyTo):
1075         * DumpRenderTree/chromium/WebPreferences.h:
1076         * DumpRenderTree/chromium/WebViewHost.cpp:
1077         (WebViewHost::scheduleComposite):
1078         * DumpRenderTree/chromium/WebViewHost.h:
1079
1080 2010-09-30  Adam Roben  <aroben@apple.com>
1081
1082         Ensure that QueueEngine cleans up its log files when its delegate
1083         tells it to stop processing work
1084
1085         Reviewed by Adam Barth.
1086
1087         Fixes <http://webkit.org/b/46891> <rdar://problem/8496638> Many tests
1088         in webkitpy.tool.bot.queueengine_unittest.QueueEngineTest crash on
1089         Windows
1090
1091         * Scripts/webkitpy/tool/bot/queueengine.py:
1092         (QueueEngine.run): Stop ourselves normally (including cleaning up log
1093         files) when the delegate tells us to stop processing work.
1094
1095         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1096         (LoggingDelegate.__init__): Moved code here from
1097         RaisingDelegate.__init__.
1098         (LoggingDelegate.expeced_callbacks): Added the stop_work_queue
1099         callback.
1100         (LoggingDelegate.stop_work_queue): Moved here from RaisingDelegate.
1101         (RaisingDelegate.__init__): Removed code that LoggingDelegate takes
1102         care of for us now.
1103         (QueueEngineTest.test_trivial): Make sure we got the expected stop
1104         message.
1105         (QueueEngineTest.test_not_safe_to_proceed): Changed to explicitly
1106         remove the callbacks that are related to processing a single work
1107         item, rather than removing all callbacks after a certain point, as
1108         there are now more callbacks we expect to receive at the end.
1109
1110 2010-09-30  Adam Roben  <aroben@apple.com>
1111
1112         Fix path -> URL conversion on Cygwin
1113
1114         Reviewed by Adam Barth.
1115
1116         Fixes <http://webkit.org/b/46890> <rdar://problem/8496637> Many tests
1117         in webkitpy.layout_tests.run_webkit_tests_unittest assert on Windows
1118
1119         * Scripts/webkitpy/layout_tests/port/base.py:
1120         (Port.filename_to_uri): Treat Cygwin like other UNIX-y platforms by
1121         assuming paths already have a leading slash.
1122
1123 2010-09-30  Adam Roben  <aroben@apple.com>
1124
1125         Teach WindowGeometryInitializedBeforeSetWindow that NPP_SetWindow can
1126         be called more than once
1127
1128         The NPP_SetWindow call made when the plugin is torn down was confusing
1129         us, and was causing us to spew an error into the next test.
1130
1131         Fixes <http://webkit.org/b/46900> <rdar://problem/8496888> REGRESSION
1132         (r68520): plugins/access-after-page-destroyed.html failing on Windows
1133
1134         Reviewed by Anders Carlsson.
1135
1136         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
1137         (WindowGeometryInitializedBeforeSetWindow::WindowGeometryInitializedBeforeSetWindow):
1138         Initialize member.
1139         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Bail if
1140         this isn't the first time this is called.
1141
1142 2010-09-30  Eric Seidel  <eric@webkit.org>
1143
1144         Reviewed by Adam Barth.
1145
1146         webkit-patch upload warns that I'm using Xcode when I'm not
1147         https://bugs.webkit.org/show_bug.cgi?id=46869
1148
1149         String.find returns -1 when not found, so switched to "in".
1150
1151         * Scripts/webkitpy/common/system/user.py:
1152         * Scripts/webkitpy/common/system/user_unittest.py:
1153
1154 2010-09-30  Eric Seidel  <eric@webkit.org>
1155
1156         Reviewed by Adam Barth.
1157
1158         webkit-patch failure-reason dies if non-trunk commits are in the blame range
1159         https://bugs.webkit.org/show_bug.cgi?id=46866
1160
1161         I also made failure-reason use RegressionWindow in a cleaner way.
1162
1163         * Scripts/webkitpy/tool/commands/queries.py:
1164
1165 2010-09-29  Adam Barth  <abarth@webkit.org>
1166
1167         Reviewed by Eric Seidel.
1168
1169         webkit-patch find-flaky-tests
1170         https://bugs.webkit.org/show_bug.cgi?id=46876
1171
1172         This command helps us find flaky tests so we can squash them.
1173
1174         * Scripts/webkitpy/tool/commands/queries.py:
1175
1176 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1177
1178         Fix export to use '?' instead of 'null' for
1179         tests with no results.
1180         
1181         * CSSTestSuiteHarness/harness/harness.js:
1182
1183 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1184
1185         Add a warning when a test requires special steps.
1186         Add a Print Preview button for 'paged' tests that
1187         brings up the print dialog, allowing the user to 
1188         judge paged media tests.
1189
1190         * CSSTestSuiteHarness/harness/harness.css:
1191         * CSSTestSuiteHarness/harness/harness.html:
1192         * CSSTestSuiteHarness/harness/harness.js:
1193         (TestSuite.prototype.loadTest):
1194         (TestSuite.prototype.processFlags):
1195
1196 2010-09-29  Adam Barth  <abarth@webkit.org>
1197
1198         Reviewed by Eric Seidel.
1199
1200         Remove revisions_casuing_failures
1201         https://bugs.webkit.org/show_bug.cgi?id=46872
1202
1203         This function exists only to be unit tested.
1204
1205         * Scripts/webkitpy/common/net/failuremap.py:
1206         * Scripts/webkitpy/common/net/failuremap_unittest.py:
1207         * Scripts/webkitpy/tool/mocktool.py:
1208
1209 2010-09-29  Adam Barth  <abarth@webkit.org>
1210
1211         Reviewed by Eric Seidel.
1212
1213         SheriffBot should post the list of failing tests to bugs
1214         https://bugs.webkit.org/show_bug.cgi?id=46871
1215
1216         * Scripts/webkitpy/common/net/buildbot.py:
1217         * Scripts/webkitpy/common/net/failuremap.py:
1218         * Scripts/webkitpy/common/net/regressionwindow.py:
1219         * Scripts/webkitpy/tool/bot/sheriff.py:
1220         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
1221         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1222         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1223         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1224         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1225         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1226         * Scripts/webkitpy/tool/mocktool.py:
1227
1228 2010-09-29  Brent Fulgham  <bfulgham@webkit.org>
1229
1230         Reviewed by Martin Robinson, Eric Seidel, and Mark Rowe.
1231
1232         [WinCairo] Adds a build slave.
1233         https://bugs.webkit.org/show_bug.cgi?id=46360
1234
1235         * BuildSlaveSupport/build.webkit.org-config/config.json: Add
1236         entries for a debug build of the WinCairo port.
1237         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add
1238         platform flag to configuration for wincairo (like gtk, chromium, etc.)
1239         * Scripts/build-webkit: Change 'cairo-win32' labeling to 'wincairo'
1240         * Scripts/webkitdirs.pm: Change 'cairo-win32' labeling to 'wincairo'
1241
1242 2010-09-29  Adam Barth  <abarth@webkit.org>
1243
1244         Reviewed by Eric Seidel.
1245
1246         Move more SheriffBot smarts into FailureMap
1247         https://bugs.webkit.org/show_bug.cgi?id=46703
1248
1249         This patch pushes the FailureMap model object further into the
1250         SheriffBot machine.  In addition, it moves a couple operations on this
1251         object from SheriffBot itself to the model.
1252
1253         Eventually, FailureMap will be the canonical context object for
1254         SheriffBot operations.  FailureMap represents a map of the current
1255         failures on the bots that might require remediation.
1256
1257         * Scripts/webkitpy/common/net/failuremap.py:
1258         * Scripts/webkitpy/common/net/regressionwindow.py:
1259         * Scripts/webkitpy/tool/commands/queries.py:
1260         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1261         * Scripts/webkitpy/tool/mocktool.py:
1262
1263 2010-09-29  Tony Chang  <tony@chromium.org>
1264
1265         Reviewed by James Robinson.
1266
1267         [chromium] enable -Werror for DRT and webkit_unit_tests on Linux
1268         https://bugs.webkit.org/show_bug.cgi?id=46829
1269
1270         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1271         (DRTDevToolsClient::DRTDevToolsClient):
1272         * DumpRenderTree/chromium/TestShell.cpp:
1273         (TestShell::TestShell):
1274         * DumpRenderTree/chromium/WebViewHost.cpp:
1275         (WebViewHost::postAccessibilityNotification):
1276         (WebViewHost::WebViewHost):
1277
1278 2010-09-29  Chris Fleizach  <cfleizach@apple.com>
1279
1280         Reviewed by Darin Adler.
1281
1282         AX: implement CSS3 Speech "speak"
1283         https://bugs.webkit.org/show_bug.cgi?id=46827
1284
1285         * DumpRenderTree/AccessibilityUIElement.cpp:
1286         (speakCallback):
1287         (AccessibilityUIElement::speak):
1288         (AccessibilityUIElement::getJSClass):
1289         * DumpRenderTree/AccessibilityUIElement.h:
1290         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1291         (AccessibilityUIElement::speak):
1292
1293 2010-09-29  Mihai Parparita  <mihaip@chromium.org>
1294
1295         Reviewed by Adam Barth.
1296
1297         Record bot ID when updating queue status
1298         https://bugs.webkit.org/show_bug.cgi?id=46764
1299         
1300         Since we now have multiple bots handling patches from the commit queue,
1301         we need to differentiate status updates from them, so that we can group
1302         the queue status page in a less confusing way.
1303
1304         * QueueStatusServer/handlers/updatestatus.py: Accept bot_id as input
1305         * QueueStatusServer/model/queuestatus.py: Add bot_id property
1306         * QueueStatusServer/templates/updatestatus.html: Add bot_id input
1307         * Scripts/webkitpy/common/net/bugzilla_unittest.py: Extract MockBrowser
1308         * Scripts/webkitpy/common/net/statusserver.py: Add bot_id
1309         * Scripts/webkitpy/common/net/statusserver_unittest.py: Added.
1310         * Scripts/webkitpy/tool/main.py: Add --bot-id
1311         * Scripts/webkitpy/tool/mocktool.py: Add MockBrowser
1312
1313 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1314
1315         No review.
1316         
1317         References always refert to a file in .xht format, even
1318         for HTML tests, so fix their loading.
1319
1320         * CSSTestSuiteHarness/harness/harness.js:
1321         (TestSuite.prototype.loadRef):
1322
1323 2010-09-28  Johnny Ding  <jnd@chromium.org>
1324
1325         Reviewed by Adam Barth.
1326
1327         https://bugs.webkit.org/show_bug.cgi?id=41292
1328         Add a new parameter to the test plugin to allow specifying a script 
1329         and a mouse/keyboard event. The specified script will be evaluated
1330         in the browser when the specified event is received by the plugin.
1331
1332         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1333         (pluginAllocate):
1334         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1335         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1336         (NPP_New):
1337         (handleEventCarbon):
1338         (handleEventCocoa):
1339
1340 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1341
1342         Fix export by adding missing argument.
1343
1344         * CSSTestSuiteHarness/harness/harness.js:
1345         (TestSuite.prototype.showResultsForAllTests):
1346
1347 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
1348
1349         [wx] Build fix, add missing import.
1350
1351         * wx/packaging/build-win-installer.py:
1352
1353 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1354
1355         No review
1356         
1357         Show which tests have been run by dimming them out in the test list.
1358         
1359         Adjust some element sizes.
1360         
1361         * CSSTestSuiteHarness/harness/harness.css:
1362         (#test-list > option.untested):
1363         (#test-list > option.completed):
1364         (#output):
1365         (.output-options):
1366         * CSSTestSuiteHarness/harness/harness.js:
1367         (Test):
1368         (TestSuite.prototype.fillTestList):
1369         (TestSuite.prototype.updateTestList):
1370         (TestSuite.prototype.setSelectedChapter):
1371         (TestSuite.prototype.recordResult):
1372         (TestSuite.prototype.markTestCompleted):
1373         (TestSuite.prototype.testCompletionStateChanged):
1374         (TestSuite.prototype.loadTestStatus):
1375
1376 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1377
1378         No review.
1379         
1380         Implement export of various queries on the test database, sharing
1381         code with that which displays results inline.
1382
1383         * CSSTestSuiteHarness/harness/harness.js:
1384         ():
1385         (TestSuite.prototype.exportResultsCompletion.var):
1386         (TestSuite.prototype.exportResultsCompletion):
1387         (TestSuite.prototype.showResultsForCompletedTests):
1388         (TestSuite.prototype.exportResultsForCompletedTests):
1389         (TestSuite.prototype.showResultsForAllTests):
1390         (TestSuite.prototype.exportResultsForAllTests):
1391         (TestSuite.prototype.exportResultsForTestsNotRun):
1392         (TestSuite.prototype.exportResultsForTestsWithStatus):
1393         (TestSuite.prototype.exportResultsForTestsWithMismatchedResults):
1394
1395 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1396
1397         No review.
1398
1399         Work around uncertainty about the order of database
1400         transactions when creating the database, so that we don't
1401         try to query the table before it has been created.
1402
1403         * CSSTestSuiteHarness/harness/harness.js:
1404         (TestSuite):
1405         (TestSuite.prototype.databaseCreated):
1406         (TestSuite.prototype.storeTestResult):
1407         (TestSuite.prototype.populateDatabaseFromTestInfoData):
1408         (TestSuite.prototype.queryDatabaseForTestsWithStatus):
1409         (TestSuite.prototype.queryDatabaseForTestsWithMixedStatus):
1410         (TestSuite.prototype.queryDatabaseForCompletedTests):
1411         (TestSuite.prototype.queryDatabaseForTestsNotRun):
1412
1413 2010-09-28  Tony Chang  <tony@chromium.org>
1414
1415         Reviewed by Eric Seidel.
1416
1417         add python keyring support to webkit-patch
1418         https://bugs.webkit.org/show_bug.cgi?id=41269
1419
1420         * Scripts/webkitpy/common/net/credentials.py: Add the ability to read passwords using
1421             the python keyring module
1422         * Scripts/webkitpy/common/net/credentials_unittest.py:
1423         * Scripts/webkitpy/common/system/user.py: Allow confirm() to default to no and add testing params.
1424         * Scripts/webkitpy/common/system/user_unittest.py:
1425         * Scripts/webkitpy/tool/mocktool.py:
1426
1427 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1428
1429         Reviewed by Gustavo Noronha Silva.
1430
1431         [Cairo] FreeType fonts should obey FontConfig hinting/anti-aliasing settings
1432         https://bugs.webkit.org/show_bug.cgi?id=46740
1433
1434         * DumpRenderTree/gtk/fonts/fonts.conf: Add specialized variants of common
1435         fonts which can be used to fully test FontConfig rendering settings.
1436
1437 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1438
1439         Reviewed by Gustavo Noronha Silva.
1440
1441         [gtk] Fedora has a different path for the liberation fonts
1442         https://bugs.webkit.org/show_bug.cgi?id=46709
1443
1444         When searching for DRT fonts, also look in the path where those fonts
1445         are commonly found on Fedora systems.
1446
1447         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1448         (initializeFonts): Include logic for looking for Fedora-style font paths.
1449
1450 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1451
1452         Reviewed by Andreas Kling.
1453
1454         run-webkit-tests needs an updated list of directories with webgl tests
1455         https://bugs.webkit.org/show_bug.cgi?id=46747
1456
1457         Update the list of directories containing WebGL tests and a unit test
1458         which depends on this list.
1459
1460         * Scripts/old-run-webkit-tests: Update the list of directories.
1461         * Scripts/webkitpy/layout_tests/port/webkit.py: Ditto.
1462         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Update the expected result.
1463
1464 2010-09-28  Adam Barth  <abarth@webkit.org>
1465
1466         Reviewed by Eric Seidel.
1467
1468         Introduce FailureMap to summaries the failures status of all the bots
1469         https://bugs.webkit.org/show_bug.cgi?id=46700
1470
1471         This patch gives the SheriffBot a handle on the list of failing tests.
1472
1473         * Scripts/webkitpy/common/net/buildbot.py:
1474         * Scripts/webkitpy/common/net/failuremap.py: Added.
1475         * Scripts/webkitpy/tool/commands/queries.py:
1476         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1477         * Scripts/webkitpy/tool/mocktool.py:
1478
1479 2010-09-28  Adam Roben  <aroben@apple.com>
1480
1481         Update for the addition of WKPageUIClient::didNotHandleKeyEvent
1482
1483         Fixes <http://webkit.org/b/46660> <rdar://problem/8483465> Need API to
1484         tell a WebKit2 client application that a key event was not handled
1485
1486         Reviewed by Kenneth Rohde Christiansen and Sam Weinig.
1487
1488         * MiniBrowser/mac/BrowserWindowController.m:
1489         (-[BrowserWindowController awakeFromNib]):
1490         * MiniBrowser/win/BrowserView.cpp:
1491         (BrowserView::create):
1492         * WebKitTestRunner/TestController.cpp:
1493         (WTR::createOtherPage):
1494         (WTR::TestController::initialize):
1495
1496 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1497
1498         Unreviewed.
1499
1500         Update the CSSTestSuiteHarness to not scrape the XHTML chapter files
1501         for the test order, but instead use information from testinfo.data.
1502         
1503         * CSSTestSuiteHarness/harness/harness.html:
1504         * CSSTestSuiteHarness/harness/harness.js:
1505
1506 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
1507
1508         [wx] Build fix, don't try to get the svn revision from the git repo when packaging,
1509         it causes the process to hang on the gitorious repo.
1510
1511         * wx/packaging/build-mac-installer.py:
1512         * wx/packaging/build-win-installer.py:
1513
1514 2010-09-28  Adam Roben  <aroben@apple.com>
1515
1516         Test that a plugin's HWND is sized/positioned before NPP_SetWindow is
1517         called
1518
1519         Reviewed by Anders Carlsson.
1520
1521         Test for <http://webkit.org/b/46716> <rdar://problem/8482014>
1522         Full-page Adobe Reader does not paint until window is resized
1523
1524         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1525         (PluginTest::NPP_SetWindow): Added. Just returns NPERR_NO_ERROR at
1526         this level.
1527
1528         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Declared
1529         NPP_SetWindow.
1530
1531         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp: Added.
1532         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Checks that
1533         the plugin's HWND has a non-zero size and that its size/position
1534         matches that specified in the NPWindow.
1535
1536         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1537         (NPP_SetWindow): Call through to the PluginTest.
1538
1539         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1540         Added WindowGeometryInitializedBeforeSetWindow.cpp, and let VS reorder
1541         the files as it saw fit.
1542
1543 2010-09-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
1544
1545         Reviewed by Andreas Kling.
1546
1547         [Qt] Remove support for Qt 4.5
1548         https://bugs.webkit.org/show_bug.cgi?id=46718
1549
1550         Remove the code for versions of Qt prior to 4.6.
1551
1552         * DumpRenderTree/qt/EventSenderQt.cpp:
1553         (EventSender::addTouchPoint):
1554         (EventSender::updateTouchPoint):
1555         (EventSender::setTouchModifier):
1556         (EventSender::touchStart):
1557         (EventSender::touchMove):
1558         (EventSender::touchEnd):
1559         (EventSender::clearTouchPoints):
1560         (EventSender::releaseTouchPoint):
1561         (EventSender::sendTouchEvent):
1562         * DumpRenderTree/qt/EventSenderQt.h:
1563         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1564         (TextInputController::setMarkedText):
1565         * QtTestBrowser/launcherwindow.cpp:
1566         (LauncherWindow::LauncherWindow):
1567         (LauncherWindow::initializeView):
1568         (LauncherWindow::createChrome):
1569         (LauncherWindow::sendTouchEvent):
1570         (LauncherWindow::eventFilter):
1571         (LauncherWindow::applyZoom):
1572         (LauncherWindow::setTouchMocking):
1573         * QtTestBrowser/launcherwindow.h:
1574         * QtTestBrowser/utils.cpp:
1575         (urlFromUserInput):
1576         * QtTestBrowser/webview.cpp:
1577         (WebViewGraphicsBased::animatedFlip):
1578         (WebViewGraphicsBased::animatedYFlip):
1579         * QtTestBrowser/webview.h:
1580         (WebViewGraphicsBased::setYRotation):
1581
1582 2010-09-28  İsmail Dönmez  <ismail@namtrac.org>
1583
1584         Reviewed by Andreas Kling.
1585
1586         Fix DRT compilation on WinCE. Introduce a WCECOMPAT variable
1587         which should point to wcecompat installation. Needs wcecompat
1588         library from http://github.com/mauricek/wcecompat .
1589
1590         * DumpRenderTree/qt/DumpRenderTree.pro:
1591         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1592         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1593
1594 2010-09-28  Daniel Bates  <dbates@rim.com>
1595
1596         Rollout changeset 68493 <http://trac.webkit.org/changeset/68493>
1597         <https://bugs.webkit.org/show_bug.cgi?id=39136>
1598
1599         Rollout changeset 68493 because it broke Sheriffbot's rollout feature.
1600         In particular, this change caused Sheriffbot to raise an exception when
1601         trying to parse the bug id on a bug page. We need to look into this
1602         some more.
1603
1604         * Scripts/webkitpy/common/net/bugzilla.py:
1605         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1606         * Scripts/webkitpy/tool/bot/sheriff.py:
1607         * Scripts/webkitpy/tool/commands/download.py:
1608         * Scripts/webkitpy/tool/commands/queues.py:
1609         * Scripts/webkitpy/tool/commands/upload.py:
1610         * Scripts/webkitpy/tool/steps/closebug.py:
1611         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
1612         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1613         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1614
1615 2010-09-28  Adam Barth  <abarth@webkit.org>
1616
1617         Reviewed by Eric Seidel.
1618
1619         Move RegressionWindow further up the dependency chain
1620         https://bugs.webkit.org/show_bug.cgi?id=46698
1621
1622         Baby steps towards pushing this information into bug posts.
1623
1624         * Scripts/webkitpy/common/net/buildbot.py:
1625         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1626         * Scripts/webkitpy/common/net/regressionwindow.py:
1627         * Scripts/webkitpy/tool/commands/queries.py:
1628
1629 2010-09-27  Daniel Bates  <dbates@rim.com>
1630
1631         Reviewed by Adam Barth.
1632
1633         sheriffbot can't roll out security patches
1634         https://bugs.webkit.org/show_bug.cgi?id=39136
1635
1636         Make SheriffBot determine if it's authorized to view a bug
1637         whose change it wants to rollout before it tries to rollout
1638         the change.
1639
1640         Moreover, make both webkit-patch and Sheriffbot provide human-
1641         readable error messages when they are not authorized to view
1642         a bug and when a bug number is invalid.
1643
1644         Currently, Sheriffbot does not parse Bugzilla bugs for
1645         <bug error="...">, which indicates an error when retrieving
1646         a bug. In particular, error="NotPermitted" if a person (or bot)
1647         is not authorized to view a bug. For such error="NotPermitted" bugs,
1648         Sheriffbot raises an exception when parsing the bug report and
1649         this exception does not explicitly indicate Sheriffbot's lack
1650         of authorization. Instead, Sheriffbot should explicitly check
1651         for the presence <bug error="..."> before operating on a bug
1652         and error with a human-readable message if it's not permitted
1653         to view it.
1654
1655         * Scripts/webkitpy/common/net/bugzilla.py: Added BugzillaError class.
1656         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1657           - Added unit test test_bug_parsing_for_bugzilla_not_permitted_error().
1658           - Added unit test test_bug_parsing_for_bugzilla_not_found_error().
1659           - Added unit test test_bug_parsing_for_bugzilla_invalid_bug_id_error().
1660         * Scripts/webkitpy/tool/bot/sheriff.py: Modified to catch BugzillaError.
1661         * Scripts/webkitpy/tool/commands/download.py: Ditto.
1662         * Scripts/webkitpy/tool/commands/queues.py: Ditto.
1663         * Scripts/webkitpy/tool/commands/upload.py: Ditto.
1664         * Scripts/webkitpy/tool/steps/closebug.py: Ditto.
1665         * Scripts/webkitpy/tool/steps/obsoletepatches.py: Ditto.
1666         * Scripts/webkitpy/tool/steps/preparechangelog.py: Ditto.
1667         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: Ditto.
1668
1669 2010-09-27  Adam Barth  <abarth@webkit.org>
1670
1671         Reviewed by Eric Seidel.
1672
1673         Expose more more failure information from Buildbot to SheriffBot
1674         https://bugs.webkit.org/show_bug.cgi?id=46697
1675
1676         This patch moves the information about what tests failured closer to
1677         SheriffBot.  There are still a couple more patches to go before
1678         SheriffBot can post this information to bugs, but this is a step in
1679         that direction.  Yay for unit tests, which caught some bugs in earlier
1680         versions of this patch.
1681
1682         * Scripts/webkitpy/common/net/buildbot.py:
1683         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1684         * Scripts/webkitpy/common/net/regressionwindow.py: Added.
1685         * Scripts/webkitpy/tool/commands/queries.py:
1686
1687 2010-09-27  Eric Seidel  <eric@webkit.org>
1688
1689         Unreviewed.  Fixing 500 error seen in the status server.
1690
1691         It turns out that a = b = []; b.append(1); then a[0] will be 1!
1692         This should have been obvious to me, I guess, but it was not what I was expecting.
1693
1694         * QueueStatusServer/model/activeworkitems.py:
1695
1696 2010-09-27  Adam Barth  <abarth@webkit.org>
1697
1698         Reviewed by Eric Seidel.
1699
1700         commit-queue should reject patches that fail to land
1701         https://bugs.webkit.org/show_bug.cgi?id=46694
1702
1703         This can happen, for example, if there's no reviewer.  Without this
1704         patch, we'll keep retrying the patch.
1705
1706         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1707         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1708
1709 2010-09-27  Simon Fraser  <simon.fraser@apple.com>
1710
1711         Rubber-stamped by Adele Peterson.
1712
1713         Add a harness for running the CSS 2.1 test suite.
1714         
1715         This harness assumes that you've got a local a copy of the suite
1716         adjacent to the 'harness' directory.
1717         
1718         The harness lets you go through the tests in chapter order,
1719         denoting pass/fail/skipped for each test.
1720         
1721         It uses a client-side database to store the results of testing.
1722
1723         * CSSTestSuiteHarness/harness/harness.css: Added.
1724         * CSSTestSuiteHarness/harness/harness.html: Added.
1725         * CSSTestSuiteHarness/harness/harness.js: Added.
1726
1727 2010-09-27  Eric Seidel  <eric@webkit.org>
1728
1729         Reviewed by Adam Barth.
1730
1731         Patch locks should expire if a patch is marked for retry
1732         https://bugs.webkit.org/show_bug.cgi?id=46682
1733
1734         This was part Adam's original CommitQueueTask design,
1735         but support for it was missing from the server.
1736         I added the support, but triggering lock-release based on this
1737         special "retry" status feels a bit strange so I added a FIXME.
1738
1739         I also changed the text in queuestatus.html to say "Lock Acquired"
1740         since "Last Activity" isn't really true.  We only update the lock
1741         date when the patch is started, not on every status update.
1742
1743         I also noticed an exception in next-patch, which I fixed by re-writing
1744         the unzip logic in activeworkitems.py again.
1745
1746         * QueueStatusServer/handlers/updatestatus.py:
1747         * QueueStatusServer/model/activeworkitems.py:
1748         * QueueStatusServer/templates/queuestatus.html:
1749
1750 2010-09-27  Tony Chang  <tony@chromium.org>
1751
1752         Reviewed by David Levin.
1753
1754         [chromium] fix a warning when compiling DRT on 32-bit linux
1755         https://bugs.webkit.org/show_bug.cgi?id=46641
1756
1757         * DumpRenderTree/chromium/TestEventPrinter.cpp:
1758         (DRTPrinter::handleImage):
1759
1760 2010-09-27  Eric Seidel  <eric@webkit.org>
1761
1762         Reviewed by Adam Barth.
1763
1764         queue-status should report when the patch was last locked to a queue
1765         https://bugs.webkit.org/show_bug.cgi?id=46674
1766
1767         This isn't necessarily the best way to expose this information
1768         but having this accessible via the web interface is very
1769         useful until we come up with a nicer way to display this.
1770
1771         I also cleaned up the code in activeworkitems.py a little
1772         to use list comprehensions and to have the code work with
1773         pairs instead of two lists at once.  Eventually I think those
1774         item/time pairs need to be their own little helper class.
1775
1776         * QueueStatusServer/handlers/queuestatus.py:
1777         * QueueStatusServer/model/activeworkitems.py:
1778         * QueueStatusServer/templates/queuestatus.html:
1779
1780 2010-09-27  Tony Chang  <tony@chromium.org>
1781
1782         Reviewed by David Levin.
1783
1784         [chromium] fix detection of missing fonts on DRT
1785         https://bugs.webkit.org/show_bug.cgi?id=46651
1786
1787         * DumpRenderTree/chromium/TestShellGtk.cpp:
1788         (setupFontconfig):  Only print an error message if lohit isn't found in both locations.
1789
1790 2010-09-27  Tony Chang  <tony@chromium.org>
1791
1792         Reviewed by Dimitri Glazkov.
1793
1794         add webkit unit tests to the chromium testers
1795         https://bugs.webkit.org/show_bug.cgi?id=46669
1796
1797         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1798         * Scripts/run-chromium-webkit-unit-tests: Fix a bug where we weren't using the right configuration.
1799
1800 2010-09-27  Kwang Yul Seo  <skyul@company100.net>
1801
1802         Unreviewed.
1803
1804         Adding myself to the committers list.
1805
1806         * Scripts/webkitpy/common/config/committers.py:
1807
1808 2010-09-27  Mihai Parparita  <mihaip@chromium.org>
1809
1810         Reviewed by Eric Seidel.
1811
1812         webkitpy.common.system.user_unittest.UserTest.test_prompt_with_list spams the console
1813         https://bugs.webkit.org/show_bug.cgi?id=46634
1814         
1815         Use OutputCapture to prevent console spam (and also check for expected
1816         output).
1817
1818         * Scripts/webkitpy/common/system/user_unittest.py:
1819
1820 2010-09-27  Eric Seidel  <eric@webkit.org>
1821
1822         Reviewed by James Robinson.
1823
1824         start-commit-queue should abort any rebases in progress
1825         https://bugs.webkit.org/show_bug.cgi?id=46640
1826
1827         webkit-patch commit-queue would do this itself, but this just
1828         helps ensure that the commit-queue script is properly updated
1829         before we run it (in the case where a previous rebase is in
1830         progress the git svn rebase would not work before we run the
1831         commit-queue).
1832
1833         * EWSTools/start-commit-queue.sh:
1834
1835 2010-09-18  Martin Robinson  <mrobinson@igalia.com>
1836
1837         Reviewed by Gustavo Noronha Silva.
1838
1839         [GTK] Clean up the DRT fonts.conf and switch to Liberation
1840         https://bugs.webkit.org/show_bug.cgi?id=46038
1841
1842         Switch to Liberation fonts for GTK+ layout tests. This will make our
1843         test results metric-compatible with many Windows/Chromium results. It
1844         also simplifies the fonts.conf that we load and prepares the way for
1845         fixing many font bugs.
1846
1847         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1848         (initializeFonts): Initialize a known list of fonts instead of loading
1849         every font in the WEBKIT_TESTFONTS directory.
1850         * DumpRenderTree/gtk/fonts.conf: Removed.
1851         * DumpRenderTree/gtk/fonts/AHEM____.TTF: Copied from WebKitTools/DumpRenderTree/qt/fonts/AHEM____.TTF.
1852         * DumpRenderTree/gtk/fonts/fonts.conf: Added.
1853         * GNUmakefile.am: Modify FONTS_CONF_FILE to be FONTS_CONF_DIR, so that
1854         we can load both fonts.conf and AHEM____.TTF from this location.
1855         * Scripts/old-run-webkit-tests: Remove the check for WEBKIT_TESTFONTS, since
1856         it is no longer used.
1857
1858 2010-09-26  Mihai Parparita  <mihaip@chromium.org>
1859
1860         Reviewed by Ojan Vafai.
1861
1862         new-run-webkit-httpd fails if Perl is not installed
1863         https://bugs.webkit.org/show_bug.cgi?id=46602
1864         
1865         Make Port._read_configuration catch all exceptions, since trying to run
1866         perl (because of _webkit_build_directory) when it's not installed throws
1867         a WindowsError or OSError, not an IOError (this became an issue after 
1868         r68268, since ChromiumPort ends up calling Port.default_configuration in
1869         its constructor, which means that we're ending up on this codepath in
1870         non-NRWT cases too, e.g. for the Chromium NaCl tests, which use
1871         new-run-webkit-httpd).
1872
1873         * Scripts/webkitpy/layout_tests/port/base.py:
1874         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1875
1876 2010-09-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1877
1878         Reviewed by Antonio Gomes.
1879
1880         [EFL] Add setting API to set a local storage database path.
1881         https://bugs.webkit.org/show_bug.cgi?id=45446
1882
1883         Add a setting API to set local storage database path.
1884
1885         * EWebLauncher/main.c:
1886         (on_key_down):
1887         (browserCreate):
1888         (main):
1889
1890 2010-09-26  Sam Weinig  <sam@webkit.org>
1891
1892         Reviewed by Anders Carlsson.
1893
1894         Move shared WebKit2 API (used by both bundle and main API) to WebKit2/Shared/API
1895         https://bugs.webkit.org/show_bug.cgi?id=46587
1896
1897         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1898
1899 2010-09-26  Antonio Gomes  <agomes@rim.com>
1900
1901         Reviewed by Kenneth Rohde Christiansen.
1902
1903         DRT/Mac nodesFromRect support
1904
1905         [Mac][DRT] Implement LayoutTestController::nodesFromRect
1906         https://bugs.webkit.org/show_bug.cgi?id=46580
1907
1908         Implements LayoutTestController::nodesFromRect for Mac DRT, and
1909         adding stubs for GTK+ and Windows.
1910
1911         * DumpRenderTree/LayoutTestController.cpp:
1912         (nodesFromRectCallback):
1913         (LayoutTestController::staticFunctions):
1914         * DumpRenderTree/LayoutTestController.h:
1915         (LayoutTestController::LayoutTestController::nodesFromRect):
1916         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1917         (LayoutTestController::nodesFromRect):
1918
1919 2010-09-25  Nicolas Weber  <thakis@chromium.org>
1920
1921         Reviewed by Adam Barth.
1922
1923         https://bugs.webkit.org/show_bug.cgi?id=46555
1924         Fix typo in prepare-ChangeLog's help output.
1925
1926         * Scripts/prepare-ChangeLog:
1927
1928 2010-09-24  Sam Weinig  <sam@webkit.org>
1929
1930         Reviewed by Darin Adler.
1931
1932         Implement WebKit2 callback equivalent to -[WebUIDelegate mouseDidMoveOverElement:modifierFlags:]
1933         <rdar://problem/8359279>
1934         https://bugs.webkit.org/show_bug.cgi?id=46546
1935
1936         * MiniBrowser/mac/BrowserWindowController.m:
1937         (mouseDidMoveOverElement):
1938         (-[BrowserWindowController awakeFromNib]):
1939         * MiniBrowser/win/BrowserView.cpp:
1940         (mouseDidMoveOverElement):
1941         (BrowserView::create):
1942         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1943         (WTR::InjectedBundlePage::InjectedBundlePage):
1944         * WebKitTestRunner/TestController.cpp:
1945         (WTR::createOtherPage):
1946         (WTR::TestController::initialize):
1947
1948 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
1949
1950         Reviewed by Adam Barth.
1951
1952         Allow rebaselines for webkit-patch rebaseline to be chosen
1953         https://bugs.webkit.org/show_bug.cgi?id=46407
1954         
1955         Instead of always rebaselining all failing tests, allow a subset to be
1956         chosen.
1957
1958         * Scripts/webkitpy/common/system/user.py:
1959         * Scripts/webkitpy/tool/commands/rebaseline.py:
1960
1961 2010-09-24  Ryosuke Niwa  <rniwa@webkit.org>
1962
1963         Reviewed by Tony Chang.
1964
1965         [chromium] Implement TextInputController::firstRectForCharacterRange
1966         https://bugs.webkit.org/show_bug.cgi?id=38100
1967
1968         Implemented TextInputController::firstRectForCharacterRange for chromium platform.
1969         No new tests are added since we need to implement the same feature in chromium side
1970         in order to enable any tests that uses this function.
1971
1972         * DumpRenderTree/chromium/TextInputController.cpp:
1973         (TextInputController::firstRectForCharacterRange): Added.
1974
1975 2010-09-24  Adam Barth  <abarth@webkit.org>
1976
1977         Reviewed by Eric Seidel.
1978
1979         commit-queue reports land failures as "PASS"
1980         https://bugs.webkit.org/show_bug.cgi?id=46530
1981
1982         We were ignoring the return value of land instead of passing it back to
1983         CommitQueue.  Of course, this was the one case I forgot to test!
1984
1985         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1986         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1987
1988 2010-09-24  Kenichi Ishibashi  <bashi@google.com>
1989
1990         Reviewed by Eric Seidel.
1991
1992         new-run-webkit-tests prints out nothing when build-dumprendertree fails
1993         https://bugs.webkit.org/show_bug.cgi?id=37563
1994
1995         Print error message when build-dumprendertree fails.
1996
1997         * Scripts/webkitpy/layout_tests/port/webkit.py:
1998         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1999
2000 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
2001
2002         Reviewed by Tony Chang.
2003
2004         NRWT doesn't respect config set with set-webkit-configuration
2005         https://bugs.webkit.org/show_bug.cgi?id=46278
2006         
2007         Use Port.default_configuration() instead of hardcoding Release in
2008         ChromiumPort configuration initialization, so that we still inherit the
2009         configuration set by set-webkit-configuration.
2010
2011         * Scripts/webkitpy/layout_tests/port/chromium.py:
2012         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2013
2014 2010-09-24  Chang Shu  <chang.shu@nokia.com>
2015
2016         Reviewed by Csaba Osztrogonác.
2017
2018         [Qt] Fix the code to check file existence.
2019         https://bugs.webkit.org/show_bug.cgi?id=46465
2020
2021         * QtTestBrowser/main.cpp:
2022         (main):
2023
2024 2010-09-23  Tony Chang  <tony@chromium.org>
2025
2026         Unreviewed, rolling out r68232.
2027         http://trac.webkit.org/changeset/68232
2028
2029         Broken NRWT on the canary bots.
2030
2031         * Scripts/webkitpy/layout_tests/port/chromium.py:
2032
2033 2010-09-23  Dirk Pranke  <dpranke@chromium.org>
2034
2035         Unreviewed, build fix.
2036
2037         r68008 broke new-run-webkit-tests in that the chromium ports no
2038         longer respect set-webkit-configuration. The correct fix for this
2039         is being pursued in bug 46278 (along with a bunch of unit tests),
2040         but in the meantime I'm reverting the particular lines that broke
2041         things. This was tested by hand.
2042
2043         * Scripts/webkitpy/layout_tests/port/chromium.py:
2044
2045 2010-09-23  Sam Weinig  <sam@webkit.org>
2046
2047         Reviewed by Anders Carlsson.
2048
2049         WebKit2 API: Need way to know when a frame is removed from the hierarchy
2050         <rdar://problem/8414062>
2051         https://bugs.webkit.org/show_bug.cgi?id=46432
2052
2053         * MiniBrowser/mac/BrowserWindowController.m:
2054         (didRemoveFrameFromHierarchy):
2055         (-[BrowserWindowController awakeFromNib]):
2056         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2057         (WTR::InjectedBundlePage::InjectedBundlePage):
2058         * WebKitTestRunner/TestController.cpp:
2059         (WTR::TestController::initialize):
2060
2061 2010-09-23  Tony Chang  <tony@chromium.org>
2062
2063         Reviewed by Dimitri Glazkov.
2064
2065         [chromium] implement layoutTestController.sampleSVGAnimationForElementAtTime
2066         https://bugs.webkit.org/show_bug.cgi?id=46426
2067
2068         * DumpRenderTree/chromium/LayoutTestController.cpp:
2069         (LayoutTestController::LayoutTestController):
2070         (LayoutTestController::sampleSVGAnimationForElementAtTime):
2071         * DumpRenderTree/chromium/LayoutTestController.h:
2072
2073 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
2074
2075         Reviewed by Nate Chapin.
2076
2077         [GTK] r68199 introduced two test failures
2078         https://bugs.webkit.org/show_bug.cgi?id=46424
2079
2080         Fix a regression handling preference overrides that are attached to boolean properties.
2081
2082         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2083         (LayoutTestController::overridePreference): g_strcasecmp returns 0 when strings match
2084         so we must check for that when converting a string to a boolean.
2085
2086 2010-09-23  Dimitri Glazkov  <dglazkov@chromium.org>
2087
2088         Reviewed by David Levin.
2089
2090         Fix a condition check in ServerProcess, which becomes relevant when reading binary data.
2091         https://bugs.webkit.org/show_bug.cgi?id=46406
2092
2093         This breaks when the method is called with specified size of data (image data), and the
2094         buffer hasn't yet reached this size.
2095
2096         * Scripts/webkitpy/layout_tests/port/server_process.py: Changed to check for values of
2097           index larger than 0.
2098
2099 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
2100
2101         Reviewed by Nate Chapin.
2102
2103         [GTK] Some tests from r68174 fail on the GTK+ bots
2104         https://bugs.webkit.org/show_bug.cgi?id=46396
2105
2106         Simplify LayoutTestController::overridePreference to make it easier for
2107         people unfamiliar with the code to keep the list of preferences up to date.
2108         Add the conversion for enable-hyperlink-auditing.
2109
2110         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2111         (LayoutTestController::overridePreference): Use a simple if-else block to determine
2112         out the property name for overrridePreference. Also simplify the logic for setting
2113         string properties. Add the conversion for enable-hyperlink-auditing.
2114
2115 2010-09-23  Tony Chang  <tony@chromium.org>
2116
2117         Reviewed by David Levin.
2118
2119         [chromium] add caretBrowsingEnabled to WebSettings and DRT
2120         https://bugs.webkit.org/show_bug.cgi?id=46388
2121
2122         * DumpRenderTree/chromium/LayoutTestController.cpp:
2123         (LayoutTestController::overridePreference):
2124         * DumpRenderTree/chromium/WebPreferences.cpp:
2125         (WebPreferences::reset):
2126         (WebPreferences::applyTo):
2127         * DumpRenderTree/chromium/WebPreferences.h:
2128
2129 2010-09-23  Nate Chapin  <japhet@chromium.org>
2130
2131         Reviewed by Darin Fisher.
2132
2133         Allow DRT to toggle hyperlink auditing (i.e., <a ping>).
2134         https://bugs.webkit.org/show_bug.cgi?id=30458
2135
2136         * DumpRenderTree/chromium/LayoutTestController.cpp:
2137         (LayoutTestController::overridePreference):
2138         * DumpRenderTree/chromium/WebPreferences.cpp:
2139         (WebPreferences::reset):
2140         (WebPreferences::applyTo):
2141         * DumpRenderTree/chromium/WebPreferences.h:
2142         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2143         (resetDefaultsToConsistentValues):
2144         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2145         (LayoutTestController::overridePreference):
2146
2147 2010-09-21  Stephen White  <senorblanco@chromium.org>
2148
2149         Reviewed by David Levin.
2150
2151         Implement --enable-accelerated-2d-canvas flag in DumpRenderTree.
2152         https://bugs.webkit.org/show_bug.cgi?id=46208
2153
2154         This flag allows the layout tests to be run with or without accelerated
2155         2D canvas rendering.
2156
2157         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2158         (main):
2159         Declare the new flag string, and check for it on startup.
2160         * DumpRenderTree/chromium/TestShell.cpp:
2161         (TestShell::TestShell):
2162         Add a boolean for the new flag, in order to preserve its value over
2163         preferences reset.
2164         (TestShell::resetWebSettings):
2165         Set the new flag to the stored value on reset.
2166         * DumpRenderTree/chromium/TestShell.h:
2167         (TestShell::setAccelerated2dCanvasEnabled):
2168         Add an accessor for the new flag.
2169         * DumpRenderTree/chromium/WebPreferences.cpp:
2170         (WebPreferences::reset):
2171         Initialize the new flag to false.
2172         (WebPreferences::applyTo):
2173         Copy the flag's value to the WebSettings.
2174         * DumpRenderTree/chromium/WebPreferences.h:
2175         Add the new flag.
2176
2177 2010-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2178
2179         Reviewed by Simon Hausmann.
2180
2181         [Qt] Refactor QtWebKitPlatformPlugin interface
2182
2183         Make it easier to keep source-compability for the
2184         QtWebKitPlatformPlugin interface, and run qmake
2185         on the example (but not build) for convenience. 
2186
2187         https://bugs.webkit.org/show_bug.cgi?id=46345
2188
2189         * Scripts/webkitdirs.pm:
2190
2191 2010-09-23  Adam Barth  <abarth@webkit.org>
2192
2193         Reviewed by Eric Seidel.
2194
2195         Tweak some status messages that Eric thought were confusing
2196         https://bugs.webkit.org/show_bug.cgi?id=46342
2197
2198         * Scripts/webkitpy/tool/commands/queues.py:
2199         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2200
2201 2010-09-22  Adam Barth  <abarth@webkit.org>
2202
2203         Reviewed by Eric Seidel.
2204
2205         Fix comm-queue typo
2206         https://bugs.webkit.org/show_bug.cgi?id=46339
2207
2208         We were missing a "self".  The real problem is that we didn't have an
2209         integration test for the failure case.
2210
2211         * Scripts/webkitpy/tool/commands/queues.py:
2212         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2213
2214 2010-09-22  Adam Barth  <abarth@webkit.org>
2215
2216         Reviewed by Eric Seidel.
2217
2218         commit-queue should log more detailed messages to the QueueStatusServer
2219         https://bugs.webkit.org/show_bug.cgi?id=46333
2220
2221         When I created CommitQueueTask, I removed most of the previous logging.
2222         This patch adds back more detailed logging so folks can see their patch
2223         progress through the queue.
2224
2225         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2226         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2227         * Scripts/webkitpy/tool/commands/queues.py:
2228         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2229
2230 2010-09-22  Mihai Parparita  <mihaip@chromium.org>
2231
2232         Reviewed by Darin Fisher.
2233
2234         [Chromium] User style layout tests don't pass on Chromium
2235         https://bugs.webkit.org/show_bug.cgi?id=46069
2236
2237         Fix a typo in LayoutTestController::addUserStyleSheet that was causing a
2238         crash the Chromium DRT. Pass InjectInExistingDocuments to mimic DRT
2239         behavior from other ports.
2240
2241         * DumpRenderTree/chromium/LayoutTestController.cpp:
2242         (LayoutTestController::addUserStyleSheet):
2243
2244 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
2245
2246         Reviewed by Martin Robinson.
2247
2248         [WinCairo] Part 2: Update WebKitTestRunner and DumpRenderTree Build.
2249         https://bugs.webkit.org/show_bug.cgi?id=46303.
2250
2251         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added.
2252         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Moved
2253         CoreFoundation-specific stuff to new MiniBrowserCoreFoundation
2254         property sheet.
2255         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added.
2256         * MiniBrowser/MiniBrowser.vcproj: Updated configuration to use
2257         appropriate property sheet for the build types.
2258         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Updated the
2259         configuration to use appropriate property sheet for CoreFoundation
2260         and CFLite-style builds.
2261
2262 2010-09-22  Adam Barth  <abarth@webkit.org>
2263
2264         Reviewed by Eric Seidel.
2265
2266         Optimize commit-queue performance for green trees
2267         https://bugs.webkit.org/show_bug.cgi?id=46254
2268
2269         This patch redesigns the controller logic for the commit-queue.  In the
2270         new design, the controller exercises much finer-grained control over
2271         the landing process.  In particular:
2272
2273         - Patches that fail to apply now get rejected almost immediately.
2274         - Patches that fail to build get rejects after two builds (instead of
2275           three builds and one test run).
2276         - Patches that run into a flaky test now get accepted after one build
2277           and two test runs instead of three full build-and-test runs.
2278
2279         The main cost of these optimizations is that we don't find out the tree
2280         has a failing test until the very end of the process, but if the tree
2281         has a busted test, there's not much we can do anyway.  We might as well
2282         burn commit-queue resources spinning optimisticly.
2283
2284         * Scripts/webkitpy/tool/bot/commitqueuetask.py: Added.
2285         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Added.
2286         * Scripts/webkitpy/tool/commands/queues.py:
2287
2288 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
2289
2290         Reviewed by Martin Robinson.
2291
2292         [WinCairo] Update WebKitTestRunner and DumpRenderTree Build.
2293         https://bugs.webkit.org/show_bug.cgi?id=46303.
2294
2295         * DumpRenderTree/win/DumpRenderTree.vcproj: Disable local MD5 sources
2296         for Cairo build. Copy wtf MD5 header to ForwardingHeaders for the
2297         WinCairo build.
2298         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added.
2299         * WebKitTestRunner/win/InjectedBundle.vcproj: Update win new *_Cairo
2300         build targets that use the new InjectedBundleCFLite.vsprops file.
2301
2302 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2303
2304         Unreviewed, build fix.
2305
2306         Fix bustage of rebaseline-chromium-webkit-tests resulting from
2307         r67974. Really need better unit tests for this tool :(
2308
2309         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2310
2311 2010-09-22  Adam Roben  <aroben@apple.com>
2312
2313         Unbreak test-webkitpy
2314
2315         * Scripts/webkitpy/test/main.py:
2316         (Tester.run_tests): Add a line that mysteriously got deleted.
2317
2318 2010-09-22  Adam Roben  <aroben@apple.com>
2319
2320         Make test-webkitpy test WebKit2's scripts
2321
2322         These scripts can't be in WebKitTools due to limitations of Apple's
2323         build process. But that doesn't mean we can't test them!
2324
2325         Fixes <http://webkit.org/b/46297> test-webkitpy should test code in
2326         WebKit2/Scripts
2327
2328         Reviewed by Adam Barth.
2329
2330         * Scripts/test-webkitpy:
2331         (_clean_packages_with_test): Renamed from _clean_webkitpy_with_test.
2332         Now takes an external_package_paths parameter and cleans both webkitpy
2333         and any external packages.
2334         (init): Added an external_package_paths parameter which we pass along
2335         to _clean_packages_with_test.
2336         (top level): Add WebKit2/Scripts/webkit2 as our only external package
2337         and pass it along to init and Tester.run_tests.
2338
2339         * Scripts/webkitpy/test/main.py:
2340         (Tester.run_tests): Added an optional external_package_paths
2341         parameter. We modify sys.path so that the external packages can be
2342         imported, and search for unittest files inside all external packages
2343         in addition to inside webkitpy.
2344
2345 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2346
2347         Reviewed by Tony Chang.
2348
2349         new-run-webkit-tests: r68063 broke linux python tests
2350
2351         Add a missing "from __future__ import with_statement" to this
2352         new file; the perils of testing only on the Mac and by review :(
2353
2354         https://bugs.webkit.org/show_bug.cgi?id=46293
2355
2356         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2357
2358 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2359
2360         Reviewed by Tony Chang.
2361
2362         Add a 'chromium-gpu' set of ports that will test the accelerated
2363         GPU paths. This patch adds:
2364
2365         - support for the '--accelerated-compositing' and
2366           'accelerated-2d-canvas' flags to new-run-webkit-tests (and the
2367           'no-' flags)
2368         - adds a new set of Ports that will look under
2369           platform/chromium-gpu-$OS/ for baselines before looking in the
2370           regular chromium search path
2371         - adds a new test_expectations.txt file in platform/chromium-gpu
2372           that skips all but the tests we actually want to run with
2373           acceleration.
2374
2375         This patch will allow us to run both with and without acceleration
2376         and to change the defaults for both the regular and -gpu options
2377         as the code evolves.
2378
2379         We plan to add both --chromium-$OS and --chromium-gpu-$OS runs to
2380         each test bot.
2381
2382         https://bugs.webkit.org/show_bug.cgi?id=46225
2383
2384         * Scripts/webkitpy/layout_tests/port/chromium.py:
2385         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2386         * Scripts/webkitpy/layout_tests/port/factory.py:
2387         * Scripts/webkitpy/layout_tests/port/webkit.py:
2388
2389 2010-09-22  Jamey Hicks  <jamey.hicks@nokia.com>
2390
2391         Reviewed by Kenneth Rohde Christiansen.
2392
2393         [Qt] Web Inspector: Remote Web Inspector support for QtWebKit
2394         https://bugs.webkit.org/show_bug.cgi?id=43988
2395
2396         Runs a web debug server on port specified by QtTestBrowser
2397         argument -remote-inspector-port. Property
2398         _q_webInspectorServerPort of the QWebPage instance will be set
2399         according to the argument. All pages with that property set will
2400         be remotely inspectable.
2401
2402         URL for remote inspection of first QWebPage is
2403             http://localhost:9222/webkit/inspector/inspector.html?page=1
2404         where 1 is the number of the QWebPage instance.
2405
2406         The base URL yields an index page with links to the individual inspectors:
2407             http://localhost:9222/
2408
2409         * QtTestBrowser/launcherwindow.cpp:
2410         (LauncherWindow::init):
2411         * QtTestBrowser/launcherwindow.h:
2412         * QtTestBrowser/main.cpp:
2413         (LauncherApplication::handleUserOptions):
2414
2415 2010-09-22  Adam Roben  <aroben@apple.com>
2416
2417         Fix webkit-patch failure-reason now that build.webkit.org has been
2418         updated
2419
2420         Fixes <http://webkit.org/b/46273> webkit-patch failure-reason crashes
2421         every time
2422
2423         Reviewed by Eric Seidel.
2424
2425         * Scripts/webkitpy/common/net/buildbot.py:
2426         (BuildBot._file_cell_text): Added. Travels down the firstChild chain
2427         looking for an element that contains text, then returns it.
2428         (BuildBot._parse_twisted_file_row): Use _file_cell_text to get the
2429         text out of the cells. This way it doesn't matter whether the cells
2430         have <b> children (as for cells in directory rows) or not (as for
2431         cells in file rows)
2432         (BuildBot._parse_twisted_directory_listing): Look for rows that have
2433         the "directory" or "file" class, rather than rows with any class,
2434         since header rows now have a class attribute.
2435
2436         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2437         (BuildBotTest._example_directory_listing): Updated to more closely
2438         match the markup that build.webkit.org is producing now.
2439
2440 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2441
2442         Unreviewed, build fix.
2443
2444         new-run-webkit-tests: fix bug introduced in r68008 where if you
2445         specify --chromium and no --platform, and you're running on
2446         windows, you use the 'chromium-win' port by default instead of the
2447         version-specific port. This breaks the buildbots.
2448
2449         It will be good for this refactoring to settle down so I can
2450         rewrite the logic for default ports and the unit tests to be
2451         clearer (and the testing more comprehensive).
2452
2453         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2454
2455 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2456
2457         Reviewed by Adam Barth.
2458
2459         Modify the Port interface to take only a series of keyword arguments
2460         in the constructor, and modify Port/factory.get() to accomodate that,
2461         and to accept user=XXX as an argument so we can pass
2462         webkitpy.common.system.user.User objects in.
2463
2464         Then, modify new-run-webkit-tests and rebaseline-chromium-webkit-tests
2465         to use the common routine in webkitpy.common.system.user.open_url()
2466         to display HTML files.
2467
2468         There was a routine in the Port interface to do the same thing,
2469         but I see no need for a port-specific hook for this, since it is
2470         something that will always be executed by the host environment
2471         and displaying web pages has nothing to do with running layout tests.
2472
2473         Note that new-run-webkit-tests used to use test_shell to display
2474         the page; this is potentially useful so that you can actually click
2475         from a result to the broken page; however, since DumpRenderTree
2476         doesn't support this functionality, it will be going away eventually.
2477
2478         https://bugs.webkit.org/show_bug.cgi?id=46128
2479
2480         * Scripts/webkitpy/layout_tests/port/base.py:
2481         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2482         * Scripts/webkitpy/layout_tests/port/chromium.py:
2483         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2484         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2485         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2486         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2487         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2488         * Scripts/webkitpy/layout_tests/port/factory.py:
2489         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2490         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2491         * Scripts/webkitpy/layout_tests/port/gtk.py:
2492         * Scripts/webkitpy/layout_tests/port/mac.py:
2493         * Scripts/webkitpy/layout_tests/port/qt.py:
2494         * Scripts/webkitpy/layout_tests/port/test.py:
2495         * Scripts/webkitpy/layout_tests/port/webkit.py:
2496         * Scripts/webkitpy/layout_tests/port/win.py:
2497         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2498         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2499         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2500
2501 2010-09-21  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2502
2503         Reviewed by Kenneth Rohde Christiansen.
2504
2505         [EFL] Get fresh theme when running EWebLauncher
2506         https://bugs.webkit.org/show_bug.cgi?id=46210
2507
2508         If user tried to run EWebLauncher outside of the build tree, it would
2509         not find the theme and fallback to the installed one. However, since
2510         EWebLauncher is not installed, we always want to take the theme from
2511         the just compiled source code. If user had never installed WebKit's
2512         EFL port it could even receive a segv since no theme would be found.
2513
2514         Now EWebLauncher does not fallback to the installed theme and CMake
2515         gives as DATA_DIR the directory of the theme it has just built.
2516
2517         * CMakeListsEfl.txt: Pass the build directory as DATA_DIR to
2518         EWebLauncher.
2519         * EWebLauncher/main.c: Use only the theme from build director. Do not
2520         fallback to others as this could hide real bugs.
2521         (quit):
2522         (browserCreate):
2523         (findThemePath):
2524         (main):
2525
2526 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2527
2528         Unreviewed, build fix.
2529
2530         Don't pass the --test-shell arg to the Chromium Mac port of DRT;
2531         it just confuses it.
2532
2533         https://bugs.webkit.org/show_bug.cgi?id=46230
2534
2535         * Scripts/webkitpy/layout_tests/port/webkit.py:
2536
2537 2010-09-21  Lucas Forschler  <lforschler@apple.com>
2538
2539         Reviewed by Stephanie Lewis.
2540
2541         Make a new buildbot for Leopard Debug Test
2542
2543         * BuildSlaveSupport/build.webkit.org-config/config.json:
2544
2545 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2546
2547         Unreviewed, build fix.
2548
2549         Fix breakage of Chromium Mac DRT port caused by r67905.
2550
2551         https://bugs.webkit.org/show_bug.cgi?id=46230
2552
2553         * Scripts/webkitpy/layout_tests/port/webkit.py:
2554
2555 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2556
2557         Unreviewed, build fix.
2558
2559         Add missing import of 'tempfile'.
2560
2561         * Scripts/webkitpy/layout_tests/port/chromium.py:
2562
2563 2010-09-17  Dirk Pranke  <dpranke@chromium.org>
2564
2565         Reviewed by Ojan Vafai.
2566
2567         new-run-webkit-tests: pull the list of tests from the Port, and
2568            make it possible to run with no actual test files in the filesystem.
2569
2570         This set of changes allows us to delete the special
2571         webkitpy/layout_tests/data directory and test the generic code without
2572         touching the filesystem (except to write results). This speeds up
2573         test-webkitpy substantially.
2574
2575         This also cleans up and removes several code paths in the generic
2576         code and fixes some minor bugs, notably in the test_expectations
2577         parsing, which was previously fragile if the tests weren't present.
2578
2579         We also change the way we diff image results to be able to do so
2580         in memory, without relying on files. This slows down chromium
2581         test_shell, which always writes images to files, but should speed
2582         up DRT and ImageDiff-based implementations slightly.
2583
2584         Note that pulling the list of tests to run from the Port will allow
2585         ports to specify what tests to run as an inclusive list; previously
2586         you could only do this as an exclusive list by using a 
2587         test_expectations file or Skipped files; nothing actually uses this
2588         feature yet and it's unclear if it should be used.
2589
2590         Note that there are no functional changes -- apart from now 
2591         always printing out the location of the checksum file when we are
2592         tracing test runs -- and the total number of lines of non-test code
2593         actually drops by two.
2594
2595         There is some more cleanup that can be done in the Port/Driver 
2596         interface and in some handling of filenames, but I'll save that
2597         for another change.
2598
2599         https://bugs.webkit.org/show_bug.cgi?id=45801
2600
2601         * Scripts/webkitpy/layout_tests/data/*: Removed.
2602             - no longer need special mock layout_tests_directory in the
2603               repository.
2604         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2605             - add code to display missing text files, checksums when tracing
2606             - update to not look at the filesystem directly.
2607         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2608             - add more unit tests
2609         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2610             - remove tests_are_present flag
2611             - update with changes in Port interface - no longer access
2612               the filesystem directly, although we still use os.path for
2613               filename manipulation.
2614         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2615             - add more unit tests
2616         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Removed.
2617             - renamed to port/test_files.py
2618         * Scripts/webkitpy/layout_tests/port/base.py:
2619             - change diff_image() to expect actual image data, not filenames
2620             - add expected_checksum(), expected_image(), expected_text() to
2621               return the content of the files so that we don't need a filesystem
2622             - add path_exists(), path_isdir() for filesystem-like access.
2623             - add test_dirs() to keep clobber-test-results from needing to
2624               actually look at a real layout tests dir
2625             - add tests() to return the list of tests to run on the port
2626               (calls port/test_files to do the work).
2627             - add update_baseline() to be able to save new baselines
2628             - add uri_to_test_name() from port/dryrun.py so we can easily check
2629               filename_to_uri()
2630         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2631             - add more unit tests
2632         * Scripts/webkitpy/layout_tests/port/chromium.py:
2633             - change diff_image() to accept image content, not filenames.
2634               This will be slower for test_shell/image_diff, but faster
2635               for DRT/ImageDiff.
2636         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2637             - add more unit tests
2638         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2639             - simplify greatly
2640         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2641             - add more unit tests
2642         * Scripts/webkitpy/layout_tests/port/test.py:
2643             - massive rewrite to use in-script list of tests and expectations
2644         * Scripts/webkitpy/layout_tests/port/test_files.py:
2645             - rename from layout_package/test_files.
2646         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2647             - add unit tests
2648         * Scripts/webkitpy/layout_tests/port/webkit.py:
2649             - update diff_image() to take image contents, not files. Should
2650               make things slightly faster.
2651         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2652             - update with changes to diff_image()
2653         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2654             - update with changes to diff_image()
2655         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2656             - remove tests_are_present from test_expectations
2657             - pull the list of tests from port.tests() instead
2658               of calling test_files.py directly.
2659         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2660             - update unit tests
2661         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2662             - update with changes to 
2663         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2664             - update with change in Port interface
2665         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2666             - update with change in Port interface
2667         * Scripts/webkitpy/style/checkers/test_expectations.py:
2668             - remove the tests_are_present flag
2669
2670 2010-09-21  Anders Carlsson  <andersca@apple.com>
2671
2672         Disable logging.
2673
2674         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2675
2676 2010-09-21  Tony Chang  <tony@chromium.org>
2677
2678         Reviewed by Kent Tamura.
2679
2680         add a script for running webkit_unit_tests
2681         https://bugs.webkit.org/show_bug.cgi?id=46014
2682
2683         * Scripts/run-chromium-webkit-unit-tests: Added.
2684
2685 2010-09-21  Fridrich Strba  <fridrich.strba@bluewin.ch>
2686
2687         Reviewed by Martin Robinson.
2688
2689         Fix linking problems on Windows.
2690         https://bugs.webkit.org/show_bug.cgi?id=45844
2691
2692         * GNUmakefile.am: link the executables with winmm.dll
2693
2694 2010-09-21  Adam Barth  <abarth@webkit.org>
2695
2696         Reviewed by Eric Seidel.
2697
2698         feeder-queue svn updates more often than needed
2699         https://bugs.webkit.org/show_bug.cgi?id=46171
2700
2701         We don't need to poll SVN every time we feed the feeders.  Rather, we
2702         can count on the wrapper shell script to auto-update the queue.
2703
2704         * Scripts/webkitpy/tool/commands/queues.py:
2705         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2706
2707 2010-09-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2708
2709         Reviewed by Andreas Kling.
2710
2711         [Qt] Add robot loader timeout and extra time options.
2712         https://bugs.webkit.org/show_bug.cgi?id=46172
2713
2714         [-robot-timeout <s>]: Load the next page after s seconds if the current
2715         page didn't finish loading.
2716         [-robot-extra-time <s>]: Wait s seconds after the current page finished
2717         loading before loading the next one. This should allow some time for the
2718         page's JavaScript to execute.
2719
2720         * QtTestBrowser/launcherwindow.cpp:
2721         (LauncherWindow::applyPrefs):
2722         * QtTestBrowser/main.cpp:
2723         (LauncherApplication::robotTimeout):
2724         (LauncherApplication::robotExtraTime):
2725         (LauncherApplication::LauncherApplication):
2726         (LauncherApplication::handleUserOptions):
2727         (main):
2728         * QtTestBrowser/urlloader.cpp:
2729         (UrlLoader::UrlLoader):
2730         (UrlLoader::loadNext):
2731         (UrlLoader::loadUrlList):
2732         * QtTestBrowser/urlloader.h:
2733
2734 2010-09-21  Pavel Podivilov  <podivilov@chromium.org>
2735
2736         Unreviewed.
2737
2738         Adding myself to the committers list.
2739
2740         * Scripts/webkitpy/common/config/committers.py:
2741
2742 2010-09-20  Philippe Normand  <pnormand@igalia.com>
2743
2744         Reviewed by Eric Carlson.
2745
2746         [GTK] enhanced context menu for media elements
2747         https://bugs.webkit.org/show_bug.cgi?id=45021
2748
2749         EventSender::contextClick() now returns an array of js
2750         objects. Each object has a title property and a click() method.
2751
2752         * DumpRenderTree/gtk/EventSender.cpp:
2753         (getMenuItemTitleCallback):
2754         (setMenuItemTitleCallback):
2755         (menuItemClickCallback):
2756         (getMenuItemClass):
2757         (contextClickCallback):
2758
2759 2010-09-20  Hayato Ito  <hayato@chromium.org>
2760
2761         Unreviewed.
2762         Adding myself to the committers list.
2763
2764         * Scripts/webkitpy/common/config/committers.py:
2765
2766 2010-09-20  Adam Barth  <abarth@webkit.org>
2767
2768         Reviewed by Eric Seidel.
2769
2770         The tool member variable should be called _tool
2771         https://bugs.webkit.org/show_bug.cgi?id=46160
2772
2773         Created by find-and-replace.
2774
2775         * Scripts/webkitpy/tool/commands/download.py:
2776         * Scripts/webkitpy/tool/commands/openbugs.py:
2777         * Scripts/webkitpy/tool/commands/queries.py:
2778         * Scripts/webkitpy/tool/commands/queues.py:
2779         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2780         * Scripts/webkitpy/tool/commands/rebaseline.py:
2781         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2782         * Scripts/webkitpy/tool/commands/upload.py:
2783         * Scripts/webkitpy/tool/multicommandtool.py:
2784
2785 2010-09-20  Adam Barth  <abarth@webkit.org>
2786
2787         I ran the tests before landing but ignored the fact that they failed.  :(
2788
2789         * Scripts/webkitpy/tool/commands/queues.py:
2790
2791 2010-09-20  Adam Barth  <abarth@webkit.org>
2792
2793         Reviewed by Eric Seidel.
2794
2795         Add a feeder queue that polls bugs.webkit.org for the commit-cluster
2796         https://bugs.webkit.org/show_bug.cgi?id=46141
2797
2798         The feeder-queue polls bugs.webkit.org every 30 seconds and updates the
2799         list of work items on the status server.  The individual commit-cluster
2800         nodes then grab the patches from the server and process them.
2801
2802         * Scripts/webkitpy/tool/bot/feeders.py: Added.
2803         * Scripts/webkitpy/tool/bot/feeders_unittest.py: Added.
2804         * Scripts/webkitpy/tool/commands/queues.py:
2805         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2806         * Scripts/webkitpy/tool/commands/queuestest.py:
2807
2808 2010-09-20  Leandro Pereira  <leandro@profusion.mobi>
2809
2810         Reviewed by Darin Adler.
2811
2812         build-webkit: Add support for CMake build system
2813         https://bugs.webkit.org/show_bug.cgi?id=44979
2814
2815         * Scripts/build-webkit: Add "--efl" command-line option to build the
2816         EFL port of WebKit.
2817         * Scripts/webkitdirs.pm: Define buildCMakeProject() and
2818         buildEflCMakeProject() subroutines.
2819
2820 2010-09-20  Dirk Pranke  <dpranke@chromium.org>
2821
2822         Reviewed by Ojan Vafai.
2823
2824         new-run-webkit-tests: refactor command line args getting passed to DRT
2825
2826         This change cleans up some argument parsing between functions to get
2827         rid of some overlapping data structures. There should be no functional
2828         changes in this patch; it is pure refactoring in preparation for
2829         landing the Chrome GPU port and adding a generic way to pass
2830         args to DRT/TestShell.
2831
2832         https://bugs.webkit.org/show_bug.cgi?id=46135
2833
2834         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2835           - pass the options argument explicitly to the threads and drivers,
2836             also consolidate the passing of options to the driver.
2837           - pass options directly to process_output() to remove a couple
2838             parameters (minor cleanup).
2839         * Scripts/webkitpy/layout_tests/port/base.py:
2840           - pass the options argument to Port.create_driver().
2841         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2842           - update Port.create_driver() test
2843         * Scripts/webkitpy/layout_tests/port/chromium.py:
2844           - pass the options argument to Port.create_driver(), and clean up
2845             building of the cmd line for DRT.
2846         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2847           - pass the options argument to Port.create_driver()
2848         * Scripts/webkitpy/layout_tests/port/test.py:
2849           - pass the options argument to Port.create_driver()
2850         * Scripts/webkitpy/layout_tests/port/webkit.py:
2851           - pass the options argument to Port.create_driver(), and clean up
2852             building of the cmd line for DRT.
2853         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2854           - consolidate args in _get_dump_render_tree_args and rename to
2855             _get_test_args(); move all of the command-line args to the
2856             Port implementations.
2857
2858 2010-09-20  Andrew Wilson  <atwilson@chromium.org>
2859
2860         Revert change which was accidentally committed along with some expectation changes.
2861
2862         * Scripts/webkitpy/layout_tests/port/base.py:
2863
2864 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
2865
2866         Reviewed by Adam Barth.
2867
2868         Add explicit --force-patch flag to webkitpy tools
2869         https://bugs.webkit.org/show_bug.cgi?id=46103
2870         
2871         It wasn't obvious until I read the applypatch.py source code that
2872         --non-interfactive implies passing --force to patch. Add --force-patch
2873         as an alias to the flag, so that this behavior is more discoverable.
2874
2875         * Scripts/webkitpy/tool/steps/applypatch.py:
2876         * Scripts/webkitpy/tool/steps/options.py:
2877
2878 2010-09-20  Eric Seidel  <eric@webkit.org>
2879
2880         Unreviewed, adding a line which got dropped and is trivially correct (and tested).
2881
2882         commit-queue can't land patches
2883         https://bugs.webkit.org/show_bug.cgi?id=46138
2884
2885         Add a line of code I forgot in my last commit.
2886
2887         * Scripts/webkitpy/common/net/bugzilla.py:
2888         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2889
2890 2010-09-20  Adam Barth  <abarth@webkit.org>
2891
2892         Reviewed by Eric Seidel.
2893
2894         The commit-cluster bots still race to lock patch_ids
2895         https://bugs.webkit.org/show_bug.cgi?id=46130
2896
2897         It turns out we need to use a transaction object to make the
2898         read/modify/write lock operation atomic.  From reading the AppEngine
2899         documentation, I think this patch should do what we want.  It's hard to
2900         test locally because the test instance isn't distributed in the same
2901         way the production instance is.
2902
2903         * QueueStatusServer/handlers/nextpatch.py:
2904         * QueueStatusServer/model/activeworkitems.py: Added.
2905
2906 2010-09-20  Andy Estes  <aestes@apple.com>
2907
2908         Reviewed by Adam Barth.
2909
2910         REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
2911         https://bugs.webkit.org/show_bug.cgi?id=40961
2912
2913         Implement WebKitUsePreHTML5ParserQuirks preference.
2914
2915         * DumpRenderTree/mac/DumpRenderTree.mm:
2916         (resetDefaultsToConsistentValues): Reset WebKitUsePreHTML5ParserQuirks
2917         to false after a test finishes.
2918
2919 2010-09-20  Adam Roben  <aroben@apple.com>
2920
2921         Windows build fix
2922
2923         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Put
2924         $(WebKitOutputDir)\include before $(WebKitLibrariesDir)\include so
2925         we'll pick up the most recent versions of the headers.
2926
2927 2010-09-20  Eric Seidel  <eric@webkit.org>
2928
2929         Reviewed by Adam Barth.
2930
2931         commit-queue should check commit-queue+ again just before committing
2932         https://bugs.webkit.org/show_bug.cgi?id=32679
2933
2934         Added a _revalidate_patch check, right before landing.
2935
2936         Since _revalidate_patch passes the patch_id from the work item
2937         back to bugzilla, I had to fix all of the previous queue tests to
2938         use valid attachment ids (that's the majority of this change).
2939
2940         In order to validate that the bug was still open, I had to teach
2941         bugzilla.Bug about open/closed states.
2942
2943         * Scripts/webkitpy/common/net/bugzilla.py:
2944         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2945         * Scripts/webkitpy/tool/commands/queues.py:
2946         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2947         * Scripts/webkitpy/tool/commands/queuestest.py:
2948         * Scripts/webkitpy/tool/mocktool.py:
2949
2950 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
2951
2952         Unreviewed.
2953
2954         Adding myself as a comitter.
2955
2956         * Scripts/webkitpy/common/config/committers.py:
2957
2958 2010-09-20  Adam Barth  <abarth@webkit.org>
2959
2960         Reviewed by Eric Seidel.
2961
2962         Two instances of commit-queue try to process the same patch
2963         https://bugs.webkit.org/show_bug.cgi?id=46113
2964
2965         This patch makes next-patch atomic so that the server won't vend the
2966         same patch twice in the same hour.
2967
2968         * QueueStatusServer/handlers/nextpatch.py:
2969
2970 2010-09-20  Adam Roben  <aroben@apple.com>
2971
2972         Make WebKitTestRunner's wait-to-dump watchdog timer work on Windows
2973
2974         We were previously trying to use a CFRunLoopTimer, but since Windows
2975         doesn't use CFRunLoop on most threads this doesn't work. Now we use a
2976         Windows-style timer on Windows.
2977
2978         I also replaced all uses of "watchdog" with "watchdog timer".
2979
2980         Fixes <http://webkit.org/b/46101> WebKitTestRunner's wait-to-dump
2981         watchdog timer doesn't work on Windows
2982
2983         Reviewed by Anders Carlsson.
2984
2985         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2986         (WTR::InjectedBundlePage::dump): Updated for rename.
2987
2988         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed
2989         platform-specific functions.
2990         (WTR::LayoutTestController::LayoutTestController): Added call to
2991         platformInitialize.
2992         (WTR::LayoutTestController::waitUntilDone): Changed to call
2993         initializeWaitToDumpWatchdogTimerIfNeeded instead of doing the work
2994         right in this function.
2995         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Updated for
2996         rename.
2997
2998         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added new
2999         members needed to support the watchdog timer abstraction. Replaced
3000         some "watchdog"s with "watchdog timer".
3001
3002         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
3003         Added.
3004         (WTR::LayoutTestController::platformInitialize): Does nothing on this
3005         platform.
3006         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Moved here
3007         from LayoutTestController.cpp and changed to use an early return.
3008         (WTR::waitUntilDoneWatchdogTimerFired): Moved here from
3009         LayoutTestController.cpp.
3010         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
3011         Moved code here from LayoutTestController::waitUntilDone and changed
3012         to use an early return.
3013
3014         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
3015         Added.
3016         (WTR::LayoutTestController::platformInitialize): Initialize our
3017         watchdog timer.
3018         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Added.
3019         Kills and clears the watchdog timer.
3020         (WTR::waitToDumpWatchdogTimerFired): Added. Calls through to the
3021         LayoutTestController member function of the same name.
3022         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
3023         Added. Sets up the timer if it isn't already set.
3024
3025         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added
3026         LayoutTestControllerMac.mm.
3027
3028         * WebKitTestRunner/win/InjectedBundle.vcproj: Added
3029         LayoutTestControllerWin.cpp.
3030
3031 2010-09-20  Martin Robinson  <mrobinson@igalia.com>
3032
3033         Reviewed by Daniel Bates.
3034
3035         [GTK] fast/forms/listbox-selection.html fails
3036         https://bugs.webkit.org/show_bug.cgi?id=45942
3037
3038         Use the gdkModifersFromJSValue helper to parse all appropriate modifier
3039         strings in keyDownCallback.
3040
3041         * DumpRenderTree/gtk/EventSender.cpp:
3042         (keyDownCallback): Use the gdkModifersFromJSValue instead of duplicating the 
3043         modifier parsing logic.
3044
3045 2010-09-19  Sam Weinig  <sam@webkit.org>
3046
3047         Reviewed by Anders Carlsson.
3048
3049         WebKit2 decidePolicyForNavigationAction should include mouse button information
3050         <rdar://problem/8413165>
3051         https://bugs.webkit.org/show_bug.cgi?id=46060
3052
3053         * MiniBrowser/mac/BrowserWindowController.m:
3054         (decidePolicyForNavigationAction):
3055         (decidePolicyForNewWindowAction):
3056
3057 2010-09-19  Daniel Bates  <dbates@rim.com>
3058
3059         Reviewed by Martin Robinson.
3060
3061         Add unit tests for diffs that delete or modify a change log entry
3062         or describe changes that are far apart
3063         https://bugs.webkit.org/show_bug.cgi?id=46046
3064
3065         Add additional unit tests to test change log diffs that contain
3066         deletions or changes that are far apart from each other in the
3067         ChangeLog file.
3068
3069         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3070           - Added the following unit tests:
3071           "fixChangeLogPatch: [no change] In-place change."
3072           "fixChangeLogPatch: [no change] Remove first entry."
3073           "fixChangeLogPatch: [no change] Remove entry in the middle."
3074           "fixChangeLogPatch: [no change] Far apart changes (i.e. more than one chunk)."
3075
3076 2010-09-19  Sam Weinig  <sam@webkit.org>
3077
3078         Reviewed by Anders Carlsson.
3079
3080         Replace WKBundleRangeRef with WKBundleRangeHandleRef.
3081         https://bugs.webkit.org/show_bug.cgi?id=46054
3082
3083         The new one acts like WKBundleNodeHandleRef and allows for getting a
3084         wrapper in a specific world for the handle.
3085
3086         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3087         (WTR::propertyValue):
3088         (WTR::propertyValueDouble):
3089         (WTR::propertyValueInt):
3090         (WTR::numericWindowPropertyValue):
3091         (WTR::toStr):
3092         (WTR::InjectedBundlePage::shouldBeginEditing):
3093         (WTR::InjectedBundlePage::shouldEndEditing):
3094         (WTR::InjectedBundlePage::shouldInsertNode):
3095         (WTR::InjectedBundlePage::shouldInsertText):
3096         (WTR::InjectedBundlePage::shouldDeleteRange):
3097         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
3098         (WTR::InjectedBundlePage::shouldApplyStyle):
3099         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3100
3101 2010-09-19  Kent Tamura  <tkent@chromium.org>
3102
3103         Unreviewed. Fix WebGL test regressions by r67809.
3104
3105         * DumpRenderTree/chromium/WebPreferences.cpp:
3106         (WebPreferences::applyTo): Call setExperimentalWebGLEnabled().
3107
3108 2010-09-19  Kent Tamura  <tkent@chromium.org>
3109
3110         Reviewed by Adam Barth.
3111
3112         [DRT/Chromium] Fix a WebSettings handling bug
3113         https://bugs.webkit.org/show_bug.cgi?id=45945
3114
3115         Before this change, Chromium DRT reset WebSettings for every new
3116         window. It was wrong.
3117         If new window is not the first one, we have to apply the same
3118         settings as the first window.  So, we introduce WebPreference to
3119         store the current settings, and apply it to new windows. It's same
3120         as test_shell's behavior.
3121
3122         * DumpRenderTree/DumpRenderTree.gypi:
3123         * DumpRenderTree/chromium/LayoutTestController.cpp:
3124           Use WebPreferences instead of WebSettings.
3125         (LayoutTestController::setUserStyleSheetEnabled):
3126         (LayoutTestController::setUserStyleSheetLocation):
3127         (LayoutTestController::setAuthorAndUserStylesEnabled):
3128         (LayoutTestController::setPopupBlockingEnabled):
3129         (LayoutTestController::disableImageLoading):
3130         (LayoutTestController::setJavaScriptCanAccessClipboard):
3131         (LayoutTestController::setXSSAuditorEnabled):
3132         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
3133         (LayoutTestController::setAllowFileAccessFromFileURLs):
3134         (LayoutTestController::overridePreference):
3135         (LayoutTestController::setEditingBehavior):
3136         * DumpRenderTree/chromium/TestShell.cpp:
3137         (TestShell::resetWebSettings): Use WebPreferences.
3138         (TestShell::runFileTest): ditto.
3139         (TestShell::createNewWindow): Apply existing WebPreferences to a new WebView.
3140         * DumpRenderTree/chromium/TestShell.h:
3141         (TestShell::preferences):
3142         (TestShell::applyPreferences):
3143         * DumpRenderTree/chromium/WebPreferences.cpp: Added.
3144         * DumpRenderTree/chromium/WebPreferences.h: Added.
3145
3146 2010-09-18  Prasad Tammana  <prasadt@chromium.org>
3147
3148         Reviewed by David Levin.
3149
3150         update-webkit --chromium spitting out a spurious error
3151         https://bugs.webkit.org/show_bug.cgi?id=45868
3152
3153         * Scripts/update-webkit-chromium: Use commandExists() function to check for existence of gclient.
3154
3155 2010-09-18  Sam Weinig  <sam@webkit.org>
3156
3157         Reviewed by Dan Bernstein.
3158
3159         Improve/unify the PageLoadClient interfaces
3160         https://bugs.webkit.org/show_bug.cgi?id=46043
3161
3162         * MiniBrowser/mac/BrowserWindowController.m:
3163         (didStartProvisionalLoadForFrame):
3164         (didReceiveServerRedirectForProvisionalLoadForFrame):
3165         (didFailProvisionalLoadWithErrorForFrame):
3166         (didCommitLoadForFrame):
3167         (didFinishDocumentLoadForFrame):
3168         (didFinishLoadForFrame):
3169         (didFailLoadWithErrorForFrame):
3170         (didReceiveTitleForFrame):
3171         (didFirstLayoutForFrame):
3172         (didFirstVisuallyNonEmptyLayoutForFrame):
3173         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3174         (WTR::InjectedBundlePage::InjectedBundlePage):
3175         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
3176         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
3177         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
3178         (WTR::InjectedBundlePage::didCommitLoadForFrame):
3179         (WTR::InjectedBundlePage::didFinishLoadForFrame):
3180         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
3181         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
3182         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
3183         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3184         * WebKitTestRunner/TestController.cpp:
3185         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3186         (WTR::TestController::didFinishLoadForFrame):
3187         * WebKitTestRunner/TestController.h:
3188
3189 2010-09-17  Eric Seidel  <eric@webkit.org>
3190
3191         Unreviewed.  Adding a shell script I use to run the
3192         commit-queue. Now that multiple machines run the cq,
3193         it makes sense to share the script between them.
3194
3195         * EWSTools/start-commit-queue.sh: Added.
3196
3197 2010-09-17  Brian Weinstein  <bweinstein@apple.com>
3198
3199         Reviewed by Jon Honeycutt.
3200
3201         The colors on the new build.webkit.org (after upgrading the master to 0.8.1) are
3202         slightly harder to read, so this reverts the previous background colors for various
3203         states, making it easier to read.
3204
3205         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
3206         (.success):
3207         (.failure):
3208         (.warnings):
3209         (.exception):
3210         (.start,.running,td.building):
3211         (.offline,td.offline):
3212
3213 2010-09-17  Sheriff Bot  <webkit.review.bot@gmail.com>
3214
3215         Unreviewed, rolling out r67692.
3216         http://trac.webkit.org/changeset/67692
3217         https://bugs.webkit.org/show_bug.cgi?id=46011
3218
3219         broke layout test dashboard (Requested by johnny_g on
3220         #webkit).
3221
3222         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3223         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3224         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3225
3226 2010-09-17  Martin Robinson  <mrobinson@igalia.com>
3227
3228         Reviewed by Oliver Hunt.
3229
3230         Style bot complains about cairo forward declaration naming
3231         https://bugs.webkit.org/show_bug.cgi?id=45867
3232
3233         Exclude Cairo forward declarations from indentifiers with underscores checks.
3234
3235         * Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations.
3236         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
3237
3238 2010-09-16  Kinuko Yasuda  <kinuko@chromium.org>
3239
3240         Reviewed by Ojan Vafai.
3241
3242         Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests
3243         https://bugs.webkit.org/show_bug.cgi?id=45408
3244
3245         This change also tries to remove duplicated upload_results_json methods
3246         in run_webkit_tests.py and json_results_generator.py.
3247
3248         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3249         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3250         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3251
3252 2010-09-16  Antonio Gomes  <tonikitoo@webkit.org>
3253
3254         Reviewed by Andreas Kling.
3255
3256         [Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set.
3257
3258         Recently r67554 changed the way different views use the WebPage class: it was previously being shared between
3259         different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's
3260         were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking
3261         all page specific stuff to the UI.
3262
3263         * QtTestBrowser/launcherwindow.cpp:
3264         (LauncherWindow::initializeView):
3265         * QtTestBrowser/mainwindow.cpp:
3266         (MainWindow::MainWindow):
3267         (MainWindow::buildUI):
3268         (MainWindow::setPage):
3269         * QtTestBrowser/mainwindow.h:
3270
3271 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3272
3273         Reviewed by Andreas Kling.
3274
3275         Make all accesses to m_item (GraphicsWebView) done by WebViewGraphicsBased class happen though graphicsWebView getter method.
3276
3277         This patch is mostly a preparation for another commit, where the ownership of the m_item/GraphicsWebView
3278         object will move to the qgraphicsscene instead of the qgraphicsview.
3279
3280         * QtTestBrowser/webview.cpp:
3281         (WebViewGraphicsBased::setPage):
3282         (WebViewGraphicsBased::setResizesToContents):
3283         (WebViewGraphicsBased::resizeEvent):
3284         (WebViewGraphicsBased::animatedFlip):
3285         * QtTestBrowser/webview.h:
3286         (WebViewGraphicsBased::setItemCacheMode):
3287         (WebViewGraphicsBased::itemCacheMode):
3288
3289 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3290
3291         Reviewed by Andreas Kling.
3292
3293         Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.
3294
3295         We usually separate methods whose body are larger than a few lines from the class definition.
3296
3297         * QtTestBrowser/webview.h:
3298         (WebViewGraphicsBased::yRotation):
3299         (WebViewGraphicsBased::setYRotation):
3300
3301 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3302
3303         Reviewed by Andreas Kling.
3304
3305         Make initializeView method of LauncherWindow private.
3306
3307         No one else needs to be able to call it but LauncherWindow.
3308         Also moving the declation of isGraphicsBased method down in the same file, in order
3309         to better group related methods.
3310
3311         * QtTestBrowser/launcherwindow.h:
3312
3313 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3314
3315         Reviewed by Andreas Kling.
3316
3317         Make the getter 'page' method of MainWindow const.
3318
3319         * QtTestBrowser/mainwindow.cpp:
3320         (MainWindow::page):
3321         * QtTestBrowser/mainwindow.h:
3322
3323 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3324
3325         Reviewed by Andreas Kling.
3326
3327         Remove useless parameter from MainWindow class' constructor.
3328
3329         The parameter defaults to an empty URL and is not being used by any caller. Apart from that it is also
3330         not referred in the constructor body and does not make much sense.
3331
3332         * QtTestBrowser/mainwindow.cpp:
3333         (MainWindow::MainWindow):
3334         * QtTestBrowser/mainwindow.h:
3335
3336 2010-09-15  Tony Chang  <tony@chromium.org>
3337
3338         Reviewed by Kent Tamura.
3339
3340         [Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
3341         https://bugs.webkit.org/show_bug.cgi?id=42151
3342
3343         * DumpRenderTree/chromium/LayoutTestController.cpp:
3344         (LayoutTestController::LayoutTestController):
3345         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
3346         (WorkItemLoadHTMLString::run):
3347         (LayoutTestController::queueLoadHTMLString):
3348         (LayoutTestController::reset):
3349         (LayoutTestController::setDeferMainResourceDataLoad):
3350         * DumpRenderTree/chromium/LayoutTestController.h:
3351         (LayoutTestController::deferMainResourceDataLoad):
3352         * DumpRenderTree/chromium/WebViewHost.cpp:
3353         (WebViewHost::didCreateDataSource):
3354
3355 2010-09-16  Adrienne Walker  <enne@google.com>
3356
3357         Reviewed by Kenneth Russell.
3358
3359         Add script to synchronize WebKit and Khronos WebGL tests
3360         https://bugs.webkit.org/show_bug.cgi?id=42336
3361
3362         * Scripts/update-webgl-conformance-tests: Added.
3363         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Added.
3364         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Added.
3365
3366 2010-09-16  Sam Weinig  <sam@webkit.org>
3367
3368         Reviewed by Anders Carlsson.
3369
3370         Add support for sending synchronous messages from the InjectedBundle to the WKContext
3371         <rdar://problem/8365320>
3372         https://bugs.webkit.org/show_bug.cgi?id=44785
3373
3374         * MiniBrowser/mac/AppDelegate.m:
3375         (didReceiveSynchronousMessageFromInjectedBundle):
3376         (-[BrowserAppDelegate init]):
3377         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3378         (didCreatePage):
3379         * WebKitTestRunner/TestController.cpp:
3380         (WTR::TestController::initialize):
3381
3382 2010-09-16  Leonid Ebril  <leonid.ebril@nokia.com>
3383
3384         Reviewed by Andreas Kling.
3385
3386         [Qt] QtTestBrowser: Disable creation of a new window for screenshot on Symbian platform.
3387         https://bugs.webkit.org/show_bug.cgi?id=45885
3388
3389         Avoid creation of an additional window for screenshot to prevent overlapping with original window.
3390
3391         * QtTestBrowser/launcherwindow.cpp:
3392         (LauncherWindow::screenshot):
3393
3394 2010-09-16  Anders Carlsson  <andersca@apple.com>
3395
3396         Fix clang++ build.
3397
3398         * MiniBrowser/mac/BrowserWindowController.m:
3399         (-[BrowserWindowController zoomIn:]):
3400         (-[BrowserWindowController zoomOut:]):
3401         (-[BrowserWindowController resetZoom:]):
3402         Remove trailing semicolons.
3403
3404 2010-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
3405
3406         Unreviewed, rolling out r67628.
3407         http://trac.webkit.org/changeset/67628
3408         https://bugs.webkit.org/show_bug.cgi?id=45904
3409
3410         broke the build (Requested by eric_carlson on #webkit).
3411
3412         * DumpRenderTree/gtk/EventSender.cpp:
3413         (contextClickCallback):
3414
3415 2010-09-16  Balazs Kelemen  <kbalazs@webkit.org>
3416
3417         Unreviewed.
3418
3419         Adding myself as a comitter.
3420
3421         * Scripts/webkitpy/common/config/committers.py:
3422
3423 2010-09-15  Philippe Normand  <pnormand@igalia.com>
3424
3425         Reviewed by Eric Carlson.
3426
3427         [GTK] enhanced context menu for media elements
3428         https://bugs.webkit.org/show_bug.cgi?id=45021
3429
3430         EventSender::contextClick() now returns an array of js
3431         objects. Each object has a title property and a click() method.
3432
3433         * DumpRenderTree/gtk/EventSender.cpp:
3434         (getMenuItemTitleCallback):
3435         (setMenuItemTitleCallback):
3436         (menuItemClickCallback):
3437         (getMenuItemClass):
3438         (contextClickCallback):
3439
3440 2010-09-14  Philippe Normand  <pnormand@igalia.com>
3441
3442         Reviewed by Eric Carlson and Martin Robinson.
3443
3444         [GTK] eventSender.contextClick() should return the contents of the context menu
3445         https://bugs.webkit.org/show_bug.cgi?id=39102
3446
3447         Make the eventSender use the new private WebKitGtk+ API to
3448         retrieve the context-menu item titles and store them in an array.
3449
3450         * DumpRenderTree/gtk/EventSender.cpp:
3451         (contextClickCallback):
3452
3453 2010-09-16  Eric Uhrhane  <ericu@chromium.org>
3454
3455         Reviewed by Jian Li.
3456
3457         Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
3458         https://bugs.webkit.org/show_bug.cgi?id=45798
3459
3460         * Scripts/build-webkit:
3461
3462 2010-09-16  Robert Hogan  <robert@webkit.org>
3463
3464         Reviewed by Antonio Gomes.
3465
3466         [Qt] Support globalhistory tests
3467         https://bugs.webkit.org/show_bug.cgi?id=45774
3468
3469         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3470         (WebCore::isGlobalHistoryTest):
3471         (WebCore::DumpRenderTree::open):
3472         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3473         (LayoutTestController::reset):
3474         (LayoutTestController::dumpHistoryCallbacks):
3475         (LayoutTestController::removeAllVisitedLinks):
3476         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3477
3478 2010-09-10  Tony Chang  <tony@chromium.org>
3479
3480         Reviewed by Eric Seidel.
3481
3482         deduplicate-tests should be runnable from any WebKit directory
3483         https://bugs.webkit.org/show_bug.cgi?id=44709
3484
3485         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3486         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3487
3488 2010-09-15  Tony Chang  <tony@chromium.org>
3489
3490         Reviewed by Kent Tamura.
3491
3492         [chromium] sort testing methods in DRT
3493         https://bugs.webkit.org/show_bug.cgi?id=45850
3494
3495         * DumpRenderTree/chromium/EventSender.cpp:
3496         (EventSender::EventSender):
3497         * DumpRenderTree/chromium/LayoutTestController.cpp:
3498         (LayoutTestController::LayoutTestController):
3499         * DumpRenderTree/chromium/TextInputController.cpp:
3500         (TextInputController::TextInputController):
3501
3502 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
3503
3504         Reviewed by Adam Barth.
3505
3506         CQ status shows items out of order
3507         https://bugs.webkit.org/show_bug.cgi?id=45846
3508         
3509         Only group consecutive status items with the same patch ID into the same
3510         group, so that overall item ordering is preserved.
3511         
3512         Also don't indent status items that only have a single item in their
3513         group.
3514
3515         * QueueStatusServer/handlers/queuestatus.py:
3516         * QueueStatusServer/templates/includes/singlequeuestatus.html: Added.
3517         * QueueStatusServer/templates/queuestatus.html:
3518
3519 2010-09-15  Eric Seidel  <eric@webkit.org>
3520
3521         Reviewed by Adam Barth.
3522
3523         Add queue start/stop messages
3524         https://bugs.webkit.org/show_bug.cgi?id=45853
3525
3526         I ended up needing to clean up a bunch of our unit testing
3527         in order to test this new code path nicely.
3528
3529         There are also a few PEP8 changes needed to pass check-webkit-style.
3530
3531         * Scripts/webkitpy/tool/bot/queueengine.py:
3532         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3533         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3534         * Scripts/webkitpy/tool/commands/queues.py:
3535         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3536         * Scripts/webkitpy/tool/commands/queuestest.py:
3537         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3538
3539 2010-09-15  Simon Fraser  <simon.fraser@apple.com>
3540
3541         https://bugs.webkit.org/show_bug.cgi?id=45849
3542         WKURLCreateWithCFURL crashes with null url
3543         
3544         Fix MiniBrowser crash when the url is not parseable.
3545
3546         * MiniBrowser/mac/BrowserWindowController.m:
3547         (-[BrowserWindowController fetch:]):
3548
3549 2010-09-15  Patrick Gansterer  <paroga@paroga.com>
3550
3551         Unreviewed.
3552
3553         Adding myself to the committers list.
3554
3555         * Scripts/webkitpy/common/config/committers.py:
3556
3557 2010-09-14  Eric Seidel  <eric@webkit.org>
3558
3559         Reviewed by Adam Barth.
3560
3561         Make it possible to run more than one commit-queue instance
3562         https://bugs.webkit.org/show_bug.cgi?id=45786
3563
3564         Mostly we need to make sure the two (or more) instances get
3565         different patches to work on.  To do this, I re-worked
3566         the code responsible for getting the next work item to
3567         round trip through the status server.  The status server only
3568         vends patches from the work items list, only if those patches
3569         have not had status reported for them in the last hour.
3570
3571         This is another step towards making all queues go through the
3572         status server, thus making it possible to run more than one
3573         instance of various EWS bots (as requested in bug 44292).
3574
3575         The webkitpy changes are already covered by existing unit tests.
3576         The QueueStatusSever sadly has no testing infrastructure yet. :(
3577
3578         * QueueStatusServer/handlers/nextpatch.py: Added.
3579         * QueueStatusServer/index.yaml:
3580         * QueueStatusServer/main.py:
3581         * Scripts/webkitpy/tool/commands/queues.py:
3582
3583 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
3584
3585         Reviewed by Tony Chang.
3586
3587         NRWT fails with UnicodeDecodeError on editing/selection/mixed-editability-10.html
3588         https://bugs.webkit.org/show_bug.cgi?id=45791
3589
3590         Force filenames to be raw bytes before running difflib.unified_diff.
3591
3592         * Scripts/webkitpy/layout_tests/port/base.py:
3593