0f6b868c3dec748e4f35b797e452f0121e97a2f3
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
2
3         Reviewed by Gustavo Noronha.
4
5         Enable Web Sockets support when running layout tests.
6
7         * DumpRenderTree/gtk/DumpRenderTree.cpp:
8         (resetDefaultsToConsistentValues):
9
10 2009-10-15  Xan Lopez  <xlopez@igalia.com>
11
12         Reviewed by Gustavo Noronha.
13
14         Need to initialize event.button.button, since in most cases a
15         button number is not passed as an argument.
16
17         * DumpRenderTree/gtk/EventSender.cpp:
18         (mouseDownCallback):
19         (mouseUpCallback):
20
21 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
22
23         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
24         the OS if none was explicitly set.
25
26         * wx/build/settings.py:
27
28 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
29
30         Reviewed by Timothy Hatcher.
31
32         Web Inspector: enable developers extras within inspector layout tests.
33
34         https://bugs.webkit.org/show_bug.cgi?id=30014
35
36         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
37         (LayoutTestController::showWebInspector):
38         (LayoutTestController::closeWebInspector):
39         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
40         (LayoutTestController::showWebInspector):
41         (LayoutTestController::closeWebInspector):
42
43 2009-10-14  José Millán Soto  <jmillan@igalia.com>
44
45         Reviewed by Jan Alonzo.
46
47         GtkLauncher is using a deprecated signal
48         https://bugs.webkit.org/show_bug.cgi?id=30364
49
50         Modified GtkLauncher to use notify::title signal instead of
51         deprecated title-changed signal
52
53         * GtkLauncher/main.c:
54         (notify_title_cb):
55         (create_browser):
56
57 2009-10-14  Brady Eidson  <beidson@apple.com>
58
59         Reviewed by Sam Weinig.
60
61         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
62         1 - Disables WebHistory
63         2 - Doesn't make sense in that context anyway.
64
65         * DumpRenderTree/win/DumpRenderTree.cpp:
66         (createWebViewAndOffscreenWindow):
67
68 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
69
70         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
71         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
72
73         * wx/build/settings.py:
74         * wx/install-unix-extras:
75
76 2009-10-14  Brady Eidson  <beidson@apple.com>
77
78         Reviewed by Sam Weinig.
79
80         WebKit Win API should provide a delegate interface for global history.
81         https://bugs.webkit.org/show_bug.cgi?id=29905
82
83         * DumpRenderTree/LayoutTestController.cpp:
84         (LayoutTestController::LayoutTestController):
85         * DumpRenderTree/LayoutTestController.h:
86         (LayoutTestController::dumpHistoryDelegateCallbacks):
87         (LayoutTestController::setDumpHistoryDelegateCallbacks):
88                 
89         * DumpRenderTree/win/DumpRenderTree.cpp:
90         (shouldLogHistoryDelegates):
91         (runTest):
92         (createWebViewAndOffscreenWindow):
93         (main):
94         * DumpRenderTree/win/DumpRenderTree.vcproj:
95         
96         Add the IWebHistoryDelegate to DRT Windows:
97         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
98         (wstringFromBSTR):
99         (HistoryDelegate::HistoryDelegate):
100         (HistoryDelegate::~HistoryDelegate):
101         (HistoryDelegate::QueryInterface):
102         (HistoryDelegate::AddRef):
103         (HistoryDelegate::Release):
104         (HistoryDelegate::didNavigateWithNavigationData):
105         (HistoryDelegate::didPerformClientRedirectFromURL):
106         (HistoryDelegate::didPerformServerRedirectFromURL):
107         (HistoryDelegate::updateHistoryTitle):
108         (HistoryDelegate::populateVisitedLinksForWebView):
109         * DumpRenderTree/win/HistoryDelegate.h: Added.
110
111         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
112         (LayoutTestController::removeAllVisitedLinks):
113
114 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
115
116         Reviewed by Simon Hausmann.
117
118         [Qt] Implement support for setPOSIXLocale on Qt.
119         https://bugs.webkit.org/show_bug.cgi?id=30268 
120  
121         * DumpRenderTree/qt/DumpRenderTree.cpp:
122         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
123         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
124         (LayoutTestController::setPOSIXLocale):
125         * DumpRenderTree/qt/LayoutTestControllerQt.h:
126
127 2009-10-13  Stephanie Lewis  <slewis@apple.com>
128
129         Unreviewed, adding myself to reviewers list.
130
131         * Scripts/modules/committers.py:
132
133 2009-10-13  Stephanie Lewis  <slewis@apple.com>
134
135         Reviewed by Mark Rowe.
136
137         Fix null assignment so root tests work again.
138
139         * Scripts/webkitdirs.pm:
140
141 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
142
143         Reviewed by Simon Hausmann.
144
145         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
146         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
147         This is done in preparation of implementing missing features in DRT.
148         No functionality changes made yet.
149
150         * DumpRenderTree/qt/DumpRenderTree.cpp:
151         * DumpRenderTree/qt/DumpRenderTree.pro:
152         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
153         (EventSender::EventSender):
154         (EventSender::mouseDown):
155         (EventSender::mouseUp):
156         (EventSender::mouseMoveTo):
157         (EventSender::leapForward):
158         (EventSender::keyDown):
159         (EventSender::contextClick):
160         (EventSender::scheduleAsynchronousClick):
161         (EventSender::frameUnderMouse):
162         * DumpRenderTree/qt/EventSenderQt.h: Added.
163         (EventSender::clearKillRing):
164         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
165         (LayoutTestController::LayoutTestController):
166         (LayoutTestController::reset):
167         (LayoutTestController::processWork):
168         (LayoutTestController::maybeDump):
169         (LayoutTestController::waitUntilDone):
170         (LayoutTestController::notifyDone):
171         (LayoutTestController::windowCount):
172         (LayoutTestController::clearBackForwardList):
173         (LayoutTestController::dumpEditingCallbacks):
174         (LayoutTestController::dumpResourceLoadCallbacks):
175         (LayoutTestController::queueBackNavigation):
176         (LayoutTestController::queueForwardNavigation):
177         (LayoutTestController::queueLoad):
178         (LayoutTestController::queueReload):
179         (LayoutTestController::queueScript):
180         (LayoutTestController::provisionalLoad):
181         (LayoutTestController::timerEvent):
182         (LayoutTestController::encodeHostName):
183         (LayoutTestController::decodeHostName):
184         (LayoutTestController::setJavaScriptProfilingEnabled):
185         (LayoutTestController::setFixedContentsSize):
186         (LayoutTestController::setPrivateBrowsingEnabled):
187         (LayoutTestController::setPopupBlockingEnabled):
188         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
189         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
190         (LayoutTestController::numberOfActiveAnimations):
191         (LayoutTestController::disableImageLoading):
192         (LayoutTestController::dispatchPendingLoadRequests):
193         (LayoutTestController::setDatabaseQuota):
194         (LayoutTestController::clearAllDatabases):
195         (LayoutTestController::whiteListAccessFromOrigin):
196         (LayoutTestController::waitForPolicyDelegate):
197         (LayoutTestController::overridePreference):
198         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
199         (LayoutTestController::isLoading):
200         (LayoutTestController::setLoading):
201         (LayoutTestController::shouldDumpAsText):
202         (LayoutTestController::shouldDumpBackForwardList):
203         (LayoutTestController::shouldDumpChildrenAsText):
204         (LayoutTestController::shouldDumpDatabaseCallbacks):
205         (LayoutTestController::shouldDumpStatusCallbacks):
206         (LayoutTestController::shouldWaitUntilDone):
207         (LayoutTestController::canOpenWindows):
208         (LayoutTestController::shouldDumpTitleChanges):
209         (LayoutTestController::waitForPolicy):
210         (LayoutTestController::dumpAsText):
211         (LayoutTestController::dumpChildFramesAsText):
212         (LayoutTestController::dumpDatabaseCallbacks):
213         (LayoutTestController::dumpStatusCallbacks):
214         (LayoutTestController::setCanOpenWindows):
215         (LayoutTestController::dumpBackForwardList):
216         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
217         (LayoutTestController::display):
218         (LayoutTestController::dumpTitleChanges):
219         (LayoutTestController::dumpSelectionRect):
220         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
221         (TextInputController::TextInputController):
222         (TextInputController::doCommand):
223         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
224         * DumpRenderTree/qt/WorkQueue.cpp:
225         * DumpRenderTree/qt/WorkQueue.h:
226         * DumpRenderTree/qt/WorkQueueItem.h:
227         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
228         (findFrameNamed):
229         (LoadItem::invoke):
230         (ReloadItem::invoke):
231         (ScriptItem::invoke):
232         (BackForwardItem::invoke):
233         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
234         * DumpRenderTree/qt/jsobjects.h:
235
236 2009-10-13  Dmitry Titov  <dimich@chromium.org>
237
238         Not reviewed, adding myself to the list of reviewers.
239
240         * Scripts/modules/committers.py:
241
242 2009-10-13  Anders Carlsson  <andersca@apple.com>
243
244         Reviewed by Sam Weinig.
245
246         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
247
248         Make the private browsing mode testable by the test plug-in.
249         
250         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
251         (pluginGetProperty):
252         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
253         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
254         (NPP_New):
255         (NPP_SetValue):
256
257 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
258
259         No review, just adding self to the list of reviewers.
260
261         * Scripts/modules/committers.py:
262
263 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
264
265         Reviewed by Adam Roben.
266
267         Web Inspector: Use proper web view in inspector layout
268         tests for windows.
269
270         https://bugs.webkit.org/show_bug.cgi?id=30298
271
272         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
273         (LayoutTestController::showWebInspector):
274         (LayoutTestController::closeWebInspector):
275         (LayoutTestController::evaluateInWebInspector):
276
277 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
278
279         Reviewed by Sam Weinig.
280
281         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
282         https://bugs.webkit.org/show_bug.cgi?id=29841
283
284         * DumpRenderTree/mac/DumpRenderTree.mm:
285         (resetDefaultsToConsistentValues):
286         * DumpRenderTree/win/DumpRenderTree.cpp:
287         (resetDefaultsToConsistentValues):
288
289 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
290
291         Reviewed by Dimitri Glazkov.
292
293         Chromium Port - Windows
294         https://bugs.webkit.org/show_bug.cgi?id=29969
295
296         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
297         * Scripts/webkitdirs.pm:
298
299 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
300
301         Reviewed by Darin Adler.
302
303         jsc scripts cleanup and Qt/GTK fix
304         https://bugs.webkit.org/show_bug.cgi?id=30288
305
306         Duplicated jscPath() moved to webkitdirs.pm.
307         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
308         Configuration added (release/debug) to path for Qt-port on Windows.
309
310         * Scripts/run-javascriptcore-tests:
311         * Scripts/run-jsc:
312         * Scripts/run-sunspider:
313         * Scripts/sunspider-compare-results:
314         * Scripts/webkitdirs.pm:
315
316 2009-10-11  Adam Barth  <abarth@webkit.org>
317
318         Unreviewed.  Add Collin to committers.py.
319
320         * Scripts/modules/committers.py:
321
322 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
323
324         wx build fix, add bindings to source/include dirs now that there are sources there.
325
326         * wx/build/settings.py:
327
328 2009-10-09  Mark Rowe  <mrowe@apple.com>
329
330         Reviewed by Brady Eidson.
331
332         Enable plug-in halting in DumpRenderTree.
333
334         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
335         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
336
337         * DumpRenderTree/mac/DumpRenderTree.mm:
338         (resetDefaultsToConsistentValues):
339         * DumpRenderTree/mac/UIDelegate.mm:
340         (-[UIDelegate webView:shouldHaltPlugin:]):
341
342 2009-10-08  Brady Eidson  <beidson@apple.com>
343
344         Reviewed by Dan Bernstein.
345
346         Ask the History Delegate to populate the visited links hash.
347         <rdar://problem/7285293> and https://webkit.org/b/29904
348
349         Add the ability for LayoutTestController to clear all visited links.
350         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
351
352         * DumpRenderTree/LayoutTestController.cpp:
353         (LayoutTestController::LayoutTestController):
354         (removeAllVisitedLinksCallback):
355         (LayoutTestController::staticFunctions):
356         * DumpRenderTree/LayoutTestController.h:
357         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
358         (LayoutTestController::removeAllVisitedLinks):
359
360         * DumpRenderTree/mac/HistoryDelegate.mm:
361         (-[HistoryDelegate populateVisitedLinksForWebView:]):
362
363         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
364         (LayoutTestController::removeAllVisitedLinks):
365         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
366         (LayoutTestController::removeAllVisitedLinks):
367         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
368         (LayoutTestController::removeAllVisitedLinks):
369
370
371 2009-10-08  Daniel Bates  <dbates@webkit.org>
372
373         Reviewed by Adam Roben.
374
375         https://bugs.webkit.org/show_bug.cgi?id=30175
376         
377         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
378         the OLE drag-and-drop return value like the function it emulates. Currently, 
379         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
380         whether the drag-and-drop operation was successful or was cancelled.
381         
382         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
383         return value according to whether the drop operation was successful or not.
384
385         * DumpRenderTree/win/EventSender.cpp:
386         (doMouseUp): Added parameter oleDragAndDropReturnValue.
387         (replaySavedEvents): Ditto.
388         * DumpRenderTree/win/EventSender.h:
389         * DumpRenderTree/win/UIDelegate.cpp:
390         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
391
392 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
393
394         Reviewed by Xan Lopez.
395
396         [GTK] Added support for a parameter setting the button that was
397         pressed in the mouseDown function.
398         https://bugs.webkit.org/show_bug.cgi?id=30220
399
400         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
401
402 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
403
404         Reviewed by Xan Lopez.
405
406         [GTK] Added a line to the bottom of the expected result to match
407         the output of the test.
408         https://bugs.webkit.org/show_bug.cgi?id=30220
409
410         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
411         expected.txt:
412
413 2009-10-08  Adam Roben  <aroben@apple.com>
414
415         Use QueryInterface to get IWebInspectorPrivate
416
417         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
418         accessed in a more standard way
419
420         Reviewed by John Sullivan and Tim Hatcher.
421
422         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
423         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
424         by calling IWebViewPrivate::inspector, then use QueryInterface to get
425         to the IWebInspectorPrivate interface.
426
427 2009-10-07  Adam Roben  <aroben@apple.com>
428
429         Implement DRT support for origin whitelisting
430
431         Fixes <http://webkit.org/b/30185>.
432
433         Reviewed by Eric Seidel.
434
435         * DumpRenderTree/win/DumpRenderTree.cpp:
436         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
437         whitelist, to match Mac DRT.
438         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
439         (LayoutTestController::whiteListAccessFromOrigin): Call through to
440         IWebViewPrivate::whiteListAccessFromOrigin.
441
442 2009-10-07  Brady Eidson  <beidson@apple.com>
443
444         Reviewed by Darin Adler.
445
446         Send title changes to the global history delegate.
447         <rdar://problem/7285293> and https://webkit.org/b/29904
448
449         * DumpRenderTree/mac/HistoryDelegate.mm:
450         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
451
452 2009-10-07  Adam Barth  <abarth@webkit.org>
453
454         Unreviewed.  Remove some folks from committers.py who were listed on
455         the WebKit Team wiki page but who weren't actually listed as commit+.
456         At some point, we should coorelate this list with the committers
457         mailing list.
458
459         * Scripts/modules/committers.py:
460
461 2009-10-07  Adam Barth  <abarth@webkit.org>
462
463         Unreviewed.  Import a bunch of committers from the WebKit Team page on
464         the wiki into committers.py.
465
466         * Scripts/modules/committers.py:
467
468 2009-10-07  Adam Barth  <abarth@webkit.org>
469
470         Unreviewed.  Added Aaron Boodman to committers.py.
471
472         * Scripts/modules/committers.py:
473
474 2009-10-07  Evan Martin  <evan@chromium.org>
475
476         Reviewed by Darin Adler.
477
478         Add API to LayoutTestController for re/setting the system locale.
479         https://bugs.webkit.org/show_bug.cgi?id=18994
480
481         * DumpRenderTree/LayoutTestController.cpp:
482         (setLocaleCallback):
483         (LayoutTestController::staticFunctions):
484         (LayoutTestController::setLocale):
485         * DumpRenderTree/LayoutTestController.h:
486
487 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
488
489         Reviewed by Jan Alonzo.
490
491         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
492         https://bugs.webkit.org/show_bug.cgi?id=29689
493
494         Build fix by adding -lfontconfig for DumpRenderTree.
495
496         * GNUmakefile.am:
497
498 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
499
500         Reviewed by Simon Hausmann.
501
502         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
503
504         * Scripts/run-webkit-tests:
505
506 2009-10-07  Xan Lopez  <xlopez@igalia.com>
507
508         Reviewed by Gustavo Noronha.
509
510         "delete" in EventSender is the backspace key, not the delete one.
511
512         * DumpRenderTree/gtk/EventSender.cpp:
513         (keyDownCallback):
514
515 2009-10-07  Xan Lopez  <xlopez@igalia.com>
516
517         Reviewed by Gustavo Noronha.
518
519         getChildrenWithRange expects as last parameter the end index, not
520         the length of the range. Correct this and clarify the variable
521         names to reflect how the code works.
522
523         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
524         (AccessibilityUIElement::getChildrenWithRange):
525         (AccessibilityUIElement::getChildAtIndex):
526
527 2009-10-06  Mark Rowe  <mrowe@apple.com>
528
529         Reviewed by Simon Fraser.
530
531         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
532
533         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
534         the fact we have already changed the working directory to the top of the open source tree.
535
536 2009-10-06  Julie Parent  <jparent@chromium.org>
537
538         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
539         rather than my committer email.
540
541         * Scripts/modules/committers.py:
542
543 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
544
545         Reviewed by Eric Seidel.
546
547         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
548
549         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
550         it after each layout test as it should do, making the DRT dump additional output
551         for all of the subsequent layout tests.
552
553         * DumpRenderTree/qt/jsobjects.cpp:
554         (LayoutTestController::reset):
555
556 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
557
558         Reviewed by Simon Hausmann.
559
560         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
561         fast/dom/assign-to-window-status.html test, which is passing as a result.
562
563         https://bugs.webkit.org/show_bug.cgi?id=30127
564
565         * DumpRenderTree/qt/DumpRenderTree.cpp:
566         (WebCore::DumpRenderTree::DumpRenderTree):
567         (WebCore::DumpRenderTree::statusBarMessage):
568         * DumpRenderTree/qt/DumpRenderTree.h:
569         * DumpRenderTree/qt/jsobjects.h:
570         (LayoutTestController::shouldDumpStatusCallbacks):
571         (LayoutTestController::dumpStatusCallbacks):
572
573 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
574
575         Reviewed by Simon Hausmann.
576
577         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
578         ignores the argument indicating which mouse button to trigger.
579         https://bugs.webkit.org/show_bug.cgi?id=30048
580
581         This affects the fast/events/mouse-click-events.html layout test.
582
583         * DumpRenderTree/qt/jsobjects.cpp:
584         (EventSender::mouseDown):
585         (EventSender::mouseUp):
586         * DumpRenderTree/qt/jsobjects.h:
587
588 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
589
590         Reviewed by Simon Hausmann.
591
592         [Qt] Fix the EventSender::keyDown() implementation
593         https://bugs.webkit.org/show_bug.cgi?id=30043
594
595         It should post both a key press event and a key release event,
596         just like other ports do.
597
598         * DumpRenderTree/qt/jsobjects.cpp:
599         (EventSender::keyDown):
600
601 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
602
603         wx build fix. Add jpeg to the list of libs to link against.
604
605         * wx/build/settings.py:
606
607 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
608
609         Reviewed by Simon Hausmann.
610
611         [Qt] EventSender::keyDown() cannot send function-key events.
612         https://bugs.webkit.org/show_bug.cgi?id=30044
613
614         This affects the fast/events/keydown-function-keys.html layout test.
615
616         * DumpRenderTree/qt/jsobjects.cpp:
617         (EventSender::keyDown):
618
619 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
620
621         Added --wx-compiler-prefix waf option to allow building wxWebKit with
622         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
623
624         * wx/build/settings.py:
625         * wx/build/wxpresets.py:
626
627 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
628
629         Reviewed by Timothy Hatcher.
630
631         Web Inspector: add testing harness for Web Inspector.
632
633         https://bugs.webkit.org/show_bug.cgi?id=30010
634
635         * DumpRenderTree/LayoutTestController.cpp:
636         (showWebInspectorCallback):
637         (closeWebInspectorCallback):
638         (evaluateInWebInspectorCallback):
639         (LayoutTestController::staticFunctions):
640         * DumpRenderTree/LayoutTestController.h:
641         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
642         (LayoutTestController::showWebInspector):
643         (LayoutTestController::closeWebInspector):
644         (LayoutTestController::evaluateInWebInspector):
645         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
646         (LayoutTestController::showWebInspector):
647         (LayoutTestController::closeWebInspector):
648         (LayoutTestController::evaluateInWebInspector):
649         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
650         (LayoutTestController::showWebInspector):
651         (LayoutTestController::closeWebInspector):
652         (LayoutTestController::evaluateInWebInspector):
653         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
654         (LayoutTestController::showWebInspector):
655         (LayoutTestController::closeWebInspector):
656         (LayoutTestController::evaluateInWebInspector):
657
658 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
659
660         Reviewed by Ariyha Hidayat.
661
662         Pass arguments to system() as a string instead of array
663
664         When passed as an array entries with a space fail to translate
665         to two arguments to the child process, so instead of manually
666         splitting all the entries in @buildArgs we pass the whole thing
667         as a string instead.
668
669         * Scripts/webkitdirs.pm:
670
671 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
672
673         Reviewed by David Levin.
674
675         check-webkit-style misses whitespace errors for operators:
676         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
677         https://bugs.webkit.org/show_bug.cgi?id=30021
678
679         * Scripts/modules/cpp_style.py:
680         Added the operators mentioned above to the same list as == and !=.
681
682 2009-10-02  Julie Parent  <jparent@chromium.org>
683
684         Unreviewed.
685
686         Adding myself and Ojan Vafai as committers, because we are committers.
687
688         * Scripts/modules/committers.py:
689
690 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
691
692         Reviewed by Adam Roben.
693
694         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
695         this will help the patch merging process when TryBots are used.
696
697         * Scripts/svn-create-patch:
698
699 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
700
701         Reviewed by Simon Hausmann.
702
703         [Qt] Implement layoutTestController.overridePreference().
704         https://bugs.webkit.org/show_bug.cgi?id=29970
705
706         * DumpRenderTree/qt/DumpRenderTree.cpp:
707         (WebCore::WebPage::WebPage):
708         (WebCore::WebPage::resetSettings):
709         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
710         * DumpRenderTree/qt/jsobjects.cpp:
711         (LayoutTestController::reset):
712         (LayoutTestController::setPrivateBrowsingEnabled):
713         (LayoutTestController::setPopupBlockingEnabled):
714         (LayoutTestController::overridePreference):
715         * DumpRenderTree/qt/jsobjects.h:
716
717 2009-10-01  Chris Marrin  <cmarrin@apple.com>
718
719         Reviewed by Oliver Hunt.
720
721         Turn on ENABLE_3D_CANVAS in TOT
722         https://bugs.webkit.org/show_bug.cgi?id=29906
723
724         * Scripts/build-webkit:
725
726 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
727
728         Rubberstamped by Simon Hausmann.
729
730         Enable HTTP tests for Qt
731
732         * Scripts/run-webkit-tests:
733
734 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
735
736         Reviewed by Dimitri Glazkov.
737
738         build-webkit --chromium now also works on cygwin.
739
740         https://bugs.webkit.org/show_bug.cgi?id=29973
741
742         * Scripts/webkitdirs.pm:
743
744 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
745
746         Reviewed by Simon Hausmann.
747
748         [Qt] Don't use TCmalloc in DumpRenderTree
749         https://bugs.webkit.org/show_bug.cgi?id=27029
750
751         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
752
753         * DumpRenderTree/qt/DumpRenderTree.pro:
754
755 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
756
757         Reviewed by Simon Hausmann.
758
759         [Qt] Implement eventSender.scheduleAsynchronousClick().
760
761         https://bugs.webkit.org/show_bug.cgi?id=29931
762
763         * DumpRenderTree/qt/jsobjects.cpp:
764         (EventSender::scheduleAsynchronousClick):
765         * DumpRenderTree/qt/jsobjects.h:
766
767 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
768
769         Reviewed by Simon Hausmann.
770
771         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
772         fast/events/open-window-from-another-frame.html from the Skipped list.
773
774         https://bugs.webkit.org/show_bug.cgi?id=29930
775
776         * DumpRenderTree/qt/jsobjects.cpp:
777         (LayoutTestController::setPopupBlockingEnabled):
778         * DumpRenderTree/qt/jsobjects.h:
779
780 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
781
782         Unreviewed.
783
784         Added myself to the list of committers.
785
786         * Scripts/modules/committers.py:
787
788 2009-09-30  Eric Seidel  <eric@webkit.org>
789
790         No review, just adding Geoff to the list of reviewers.
791
792         * Scripts/modules/committers.py:
793
794 2009-09-30  Dan Bernstein  <mitz@apple.com>
795
796         Reviewed by Sam Weinig.
797
798         Added the WebKit Layout Tests fonts that are referenced in
799         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
800
801         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
802         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
803
804 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
805
806         Reviewed by David Kilzer.
807
808         Make sunspider scripts work on Windows platform.
809         https://bugs.webkit.org/show_bug.cgi?id=29656
810
811         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
812         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
813         * Scripts/webkitdirs.pm: currentPerlPath() added.
814
815 2009-09-29  Brady Eidson  <beidson@apple.com>
816
817         Rubberstamped by Dan Bernstein.
818
819         Fix license and some sorting in new files.
820
821         * DumpRenderTree/mac/HistoryDelegate.h:
822         * DumpRenderTree/mac/HistoryDelegate.mm:
823
824 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
825
826         Reviewed by David Kilzer.
827
828         Fixed how error codes are handled.
829         https://bugs.webkit.org/show_bug.cgi?id=29898
830
831         * Scripts/update-webkit:
832         * Scripts/update-webkit-chromium:
833
834 2009-09-29  Brady Eidson  <beidson@apple.com>
835
836         Reviewed by John Sullivan.
837
838         Updated way-out-of-date sorting throughout the dump methods/flags.
839
840         * DumpRenderTree/LayoutTestController.cpp:
841         (LayoutTestController::LayoutTestController):
842         (dumpAsPDFCallback):
843         (dumpAsTextCallback):
844         (dumpFrameLoadCallbacksCallback):
845         (dumpResourceLoadCallbacksCallback):
846         (LayoutTestController::staticFunctions):
847
848         * DumpRenderTree/LayoutTestController.h:
849         (LayoutTestController::dumpAsText):
850         (LayoutTestController::setDumpAsText):
851         (LayoutTestController::dumpFrameLoadCallbacks):
852         (LayoutTestController::setDumpFrameLoadCallbacks):
853         (LayoutTestController::dumpSelectionRect):
854         (LayoutTestController::setDumpSelectionRect):
855         (LayoutTestController::dumpSourceAsWebArchive):
856         (LayoutTestController::setDumpSourceAsWebArchive):
857         (LayoutTestController::dumpStatusCallbacks):
858         (LayoutTestController::setDumpStatusCallbacks):
859         (LayoutTestController::dumpTitleChanges):
860         (LayoutTestController::setDumpTitleChanges):
861         (LayoutTestController::dumpWillCacheResponse):
862         (LayoutTestController::setDumpWillCacheResponse):
863
864 2009-09-29  Brady Eidson  <beidson@apple.com>
865
866         Reviewed by John Sullivan.
867
868         WebKit Mac API should provide a delegate interface for global history.
869         <rdar://problem/7042773> and https://webkit.org/b/29904
870
871         Adding the dumping of global history delegate callbacks.
872
873         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
874
875         Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
876         * DumpRenderTree/mac/DumpRenderTree.mm:
877         (createWebViewAndOffscreenWindow):
878         (allocateGlobalControllers):
879         (shouldLogFrameLoadDelegates):
880         (shouldLogHistoryDelegates):
881         (runTest):
882
883         Dump history delegate callbacks:
884         * DumpRenderTree/mac/HistoryDelegate.h: Added.
885         * DumpRenderTree/mac/HistoryDelegate.mm: Added.
886         (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
887         (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
888         (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
889
890 2009-09-29  Daniel Bates  <dbates@webkit.org>
891
892         Reviewed by Adam Roben.
893
894         https://bugs.webkit.org/show_bug.cgi?id=28902
895         
896         Fixes an issue where the drop effect returned by Window Dump Render Tree 
897         was always DROPEFFECT_NONE (since it was hard coded to do so).
898         
899         This patch corrects this issue by determining the actual drop effect 
900         performed by the corresponding drag-and-drop operation so that we can 
901         return it.
902
903         * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
904         (DraggingInfo::DraggingInfo):
905         (DraggingInfo::performedDropEffect): Added method.
906         (DraggingInfo::setPerformedDropEffect): Added method.
907         * DumpRenderTree/win/EventSender.cpp:
908         (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
909         Moved delete draggingInfo to UIDelegate::doDragDrop.
910         * DumpRenderTree/win/UIDelegate.cpp:
911         (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
912
913 2009-09-29  Dan Bernstein  <mitz@apple.com>
914
915         Reviewed by Adam Roben.
916
917         Remove copying of unnecessary or nonexistent files from the ImageDiff
918         post-build event.
919
920         * DumpRenderTree/win/ImageDiff.vcproj:
921
922 2009-09-29  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
923
924         Reviewed by David Kilzer.
925
926         [Qt] Make build-webkit script work on Windows
927         https://bugs.webkit.org/show_bug.cgi?id=29802
928
929         * Scripts/run-webkit-tests:
930         * Scripts/webkitdirs.pm:
931          - Removed unnecessary -p switch for mkdir on Windows.
932          - Use canonical path, which uses slashes or backslashes depends on platform.
933          - isWindows() only test for Windows and not for Cyqwin.
934
935 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
936
937         Reviewed by Simon Hausmann.
938
939         Fix time measurement in build-webkit after refactoring done in r48853.
940
941         * Scripts/build-webkit:
942
943 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
944
945         Reviewed by Tor Arne Vestbø.
946
947         [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.
948         This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.
949
950         * DumpRenderTree/qt/DumpRenderTree.cpp:
951         (WebCore::WebPage::WebPage):
952
953 2009-09-29  Jakub Wieczorek  <faw217@gmail.com>
954
955         Reviewed by Simon Hausmann.
956
957         [Qt] Implement eventSender.contextClick().
958         https://bugs.webkit.org/show_bug.cgi?id=29821
959
960         * DumpRenderTree/qt/jsobjects.cpp:
961         (EventSender::contextClick):
962         * DumpRenderTree/qt/jsobjects.h:
963
964 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
965
966         Reviewed by Eric Seidel.
967
968         Add experimentalWebSocketsEnabled in WebPreferences.
969         https://bugs.webkit.org/show_bug.cgi?id=28941
970
971         * DumpRenderTree/mac/DumpRenderTree.mm:
972         (resetDefaultsToConsistentValues):
973         * DumpRenderTree/win/DumpRenderTree.cpp:
974         (resetDefaultsToConsistentValues):
975
976 2009-09-28  Yaar Schnitman  <yaar@chromium.org>
977
978         Reviewed by David Kilzer.
979
980         Integrated chromium port building into webkit tools update-webkit and
981         build-webkit.
982
983         https://bugs.webkit.org/show_bug.cgi?id=29749
984
985         * Scripts/build-webkit: When --chromium is specified, will build
986           the chromium port (currently only Mac is supported).
987         * Scripts/update-webkit: When --chromium is specified, delegates to
988           update-webkit-chromium.
989         * Scripts/webkitdirs.pm: Added chromium specific defs.
990         * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch
991           chromium port's dependencies and update its project files.
992
993 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
994
995         Unreviewed.
996
997         Add myself to list of committers.
998
999         * Scripts/modules/committers.py:
1000
1001 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
1002
1003         Reviewed by Darin Adler.
1004
1005         run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
1006         https://bugs.webkit.org/show_bug.cgi?id=29771
1007
1008         * Scripts/run-webkit-tests:
1009
1010 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
1011
1012         Reviewed by Simon Hausmann.
1013
1014         [Qt] Implement layoutTestController.waitForPolicyDelegate.
1015         https://bugs.webkit.org/show_bug.cgi?id=25037
1016
1017         * DumpRenderTree/qt/DumpRenderTree.cpp:
1018         (WebCore::WebPage::acceptNavigationRequest):
1019         * DumpRenderTree/qt/DumpRenderTree.pro:
1020         * DumpRenderTree/qt/jsobjects.cpp:
1021         (LayoutTestController::reset):
1022         (LayoutTestController::notifyDone):
1023         (LayoutTestController::waitForPolicyDelegate):
1024         * DumpRenderTree/qt/jsobjects.h:
1025         (LayoutTestController::waitForPolicy):
1026
1027 2009-09-26  David Kilzer  <ddkilzer@apple.com>
1028
1029         <http://webkit.org/b/29764> mark-bug-fixed: add -o|--open switch
1030
1031         Reviewed by Eric Seidel.
1032
1033         The -o|--open switch uses the open(1) command on Mac OS X to
1034         open the bug URL in the default web browser.  If there are
1035         similar mechanisms on other platforms, they may be added later.
1036
1037         * Scripts/mark-bug-fixed:
1038         (MarkBugFixed.__init__): Added -o|--open switch to list of parse
1039         options.
1040         (MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
1041         code into main() and extracted prompting code into
1042         _prompt_user_for_correctness().
1043         (MarkBugFixed._open_bug_in_web_browser): Added.
1044         (MarkBugFixed._prompt_user_for_correctness): Added.
1045         (MarkBugFixed.main): Added logging code from
1046         _determine_bug_id_and_svn_revision().  Added code to call
1047         _open_bug_in_web_browser() if the switch is set.  Added code to
1048         call _prompt_user_for_correctness() when needed.
1049         * Scripts/modules/bugzilla.py:
1050         (Bugzilla.short_bug_url_for_bug_id): Added.
1051
1052 2009-09-26  David Kilzer  <ddkilzer@apple.com>
1053
1054         svn-unapply and svn-apply don't work when used outside multiple svn working directories
1055
1056         <http://webkit.org/b/29744>
1057         <rdar://problem/7252905>
1058
1059         Reviewed by Eric Seidel.
1060
1061         Some users have a workflow where svn-create-patch, svn-apply and
1062         svn-unapply are used outside of multiple svn working
1063         directories.  Instead of aborting the scripts in these cases,
1064         print a warning and assume that Subversion is being used.
1065
1066         * Scripts/VCSUtils.pm:
1067         (determineVCSRoot): Call warn() instead of die() if both isGit()
1068         and isSVN() initially return false.  Set $VCSUtils::isSVN to 1
1069         to enforce the assumption about Subversion, then return
1070         determineSVNRoot().
1071         * Scripts/svn-apply: Switch to using isGit() and isSVN() from
1072         VCSUtils.pm.  They both already cache their values and checking
1073         here is redundant since determineVCSRoot() is called later.
1074
1075 2009-09-26  Zan Dobersek  <zandobersek@gmail.com>
1076
1077         Reviewed by Gustavo Noronha.
1078
1079         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
1080         https://bugs.webkit.org/show_bug.cgi?id=29689
1081
1082         Load test fonts through FontConfig before each test.
1083         This ensures a more proper rendering of the tests.
1084
1085         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1086         (initializeFonts):
1087         (runTest):
1088         (main):
1089         * DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf.
1090         * GNUmakefile.am:
1091
1092 2009-09-25  David Kilzer  <ddkilzer@apple.com>
1093
1094         <http://webkit.org/b/29718> mark-bug-fixed: add -u|--update-only switch
1095
1096         Reviewed by Eric Seidel.
1097
1098         * Scripts/mark-bug-fixed:
1099         (MarkBugFixed.__init__): Added -u|--update-only switch to list
1100         of parse options.
1101         (MarkBugFixed.main): When -u|--update-only is specified, add a
1102         comment to the bug without marking it Resolved/Fixed.
1103
1104 2009-09-25  Darin Adler  <darin@apple.com>
1105
1106         Reviewed by Geoffrey Garen.
1107
1108         * Scripts/prepare-ChangeLog: Leave files from the script-tests directory
1109         out, just as we do for the resources directory.
1110
1111 2009-09-25  Adam Barth  <abarth@webkit.org>
1112
1113         Unreviewed.  Added Tony to committers.py because he's a
1114         committer now.
1115
1116         * Scripts/modules/committers.py:
1117
1118 2009-09-25  Eric Seidel  <eric@webkit.org>
1119
1120         Reviewed by Simon Fraser.
1121
1122         REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
1123         https://bugs.webkit.org/show_bug.cgi?id=28624
1124
1125         Disable hardware compositing on Leopard for versions of QuickTime 7.6.4 and older.
1126
1127         * DumpRenderTree/mac/DumpRenderTree.mm:
1128         (resetDefaultsToConsistentValues):
1129
1130 2009-09-25  Eric Seidel  <eric@webkit.org>
1131
1132         Reviewed by Adam Barth.
1133
1134         commit-queue should auto-retry patches which fail to commit due to out of date files
1135         https://bugs.webkit.org/show_bug.cgi?id=28316
1136
1137         * Scripts/bugzilla-tool:
1138          - Handle new CheckoutNeedsUpdate exception.
1139         * Scripts/modules/logging_unittest.py:
1140          - Call the ScriptError constructor correctly (this test had regressed).
1141         * Scripts/modules/scm.py:
1142          - Added the ability to define custom error handlers for run_command
1143            and added a commit_error_handler which throws CheckoutNeedsUpdate
1144            instead of ScriptError.
1145          - Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible.
1146         * Scripts/modules/scm_unittest.py:
1147          - Added tests of new error handlers.
1148
1149 2009-09-25  Eric Seidel  <eric@webkit.org>
1150
1151         Reviewed by Adam Barth.
1152
1153         commit-queue should give better feedback when failing a patch
1154         https://bugs.webkit.org/show_bug.cgi?id=29316
1155
1156         * Scripts/bugzilla-tool:
1157          - Update ScriptError uses to the new constructor format.
1158          - Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output
1159            so that we can print to both stdout as well as an output buffer for error reporting.
1160          - Update run_and_throw_if_fail to use teed output so that it can report the "output" as part of ScriptError.
1161          - Use e.message_with_output() when failing a patch (this is the real fix here).
1162            I also removed use of "This patch will require manual commit." as that's not always true.
1163          - Add missing word "bug" from log message.
1164         * Scripts/modules/scm.py:
1165          - Make ScriptError save a bunch more data so that error messages can be nicer.
1166          - Update ScriptError callers.
1167
1168 2009-09-24  John Gregg  <johnnyg@google.com>
1169
1170         Reviewed by Eric Seidel.
1171
1172         Enable switch for notifications (experimental) in Page Settings
1173         https://bugs.webkit.org/show_bug.cgi?id=28930
1174
1175         Now that desktop notifications are controlled by run-time switch,
1176         set that switch to true for DumpRenderTree.
1177
1178         * DumpRenderTree/mac/DumpRenderTree.mm:
1179         (resetDefaultsToConsistentValues):
1180         * DumpRenderTree/win/DumpRenderTree.cpp:
1181         (resetDefaultsToConsistentValues):
1182         * DumpRenderTree/win/UIDelegate.cpp:
1183         (UIDelegate::QueryInterface):
1184
1185 2009-09-24  Kevin Ollivier  <kevino@theolliviers.com>
1186
1187         wx build fix. SnowLeopard fixes for Mac dependencies.
1188
1189         * wx/build/build_utils.py:
1190         * wx/build/settings.py:
1191         * wx/install-unix-extras:
1192
1193 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1194
1195         Reviewed by Oliver Hunt.
1196
1197         Add support for DRT to send mouse wheel events.
1198
1199         https://bugs.webkit.org/show_bug.cgi?id=29348
1200         [Gtk] Scrollwheel on horizontal scrollbars should slide horizontally
1201
1202         * DumpRenderTree/gtk/EventSender.cpp:
1203         (mouseWheelToCallback):
1204
1205 2009-09-17  Eric Seidel  <eric@webkit.org>
1206
1207         Reviewed by David Levin.
1208
1209         commit-queue needs web-based status reporting
1210         https://bugs.webkit.org/show_bug.cgi?id=29307
1211
1212         Add a first-pass web-based status for the commit-queue.
1213         The bot is currently reachable at:
1214         http://webkit-commit-queue.appspot.com/
1215
1216         * CommitQueueStatus/app.yaml: Added.
1217          - Application description file required by App Engine.
1218         * CommitQueueStatus/filters/__init__.py: Added.
1219          - Required by python to treat 'filters' as a module.
1220         * CommitQueueStatus/filters/webkit_extras.py: Added.
1221          - Support for turning 'bug 123' and 'patch 123' into links.
1222            This lets us use plain text strings in our logs yet display nice HTML (help prevent XSS attacks on the page).
1223         * CommitQueueStatus/index.html: Added.
1224         * CommitQueueStatus/index.yaml: Added.
1225          - Some auto-generated file from app engine.
1226         * CommitQueueStatus/queue_status.py: Added.
1227          - The core logic of this bot.  We could eventually split this file out into pieces.
1228         * CommitQueueStatus/stylesheets/main.css: Added.
1229          - Some basic lame-o CSS to make the page look less awful.
1230         * CommitQueueStatus/update_status.html: Added.
1231          - The form that the commit-queue (or a human) can use to update the status.
1232         * Scripts/bugzilla-tool:
1233          - Add some very basic update_status calls.
1234         * Scripts/modules/statusbot.py: Added.
1235          - Knows how to post to the CommitQueueStatus web application.
1236
1237 2009-09-24  David Kilzer  <ddkilzer@apple.com>
1238
1239         <http://webkit.org/b/29712> mark-bug-fixed: add -m|--comment switch
1240
1241         Reviewed by Adam Roben.
1242
1243         * Scripts/mark-bug-fixed:
1244         (MarkBugFixed.__init__): Added -m|--comment switch to list of
1245         parse options.
1246         (MarkBugFixed.main): When specified, prepend comment from
1247         -m|--comment command-line switch to the bug comment.
1248
1249 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1250
1251         Reviewed by Jan Alonzo.
1252
1253         [GTK] DRT must display window instead of just realizing, to enable synthesizing events correctly
1254         https://bugs.webkit.org/show_bug.cgi?id=29693
1255
1256         Show the window, to be able to synthesize events correctly.
1257
1258         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1259         (runTest):
1260         (main):
1261
1262 2009-09-24  Oliver Hunt  <oliver@apple.com>
1263
1264         Reviewed by NOBODY(rollout)
1265
1266         Roll out r48712 as it is incorrect.
1267
1268         * DumpRenderTree/mac/ObjCController.m:
1269         (+[ObjCController isSelectorExcludedFromWebScript:]):
1270         (+[ObjCController webScriptNameForSelector:]):
1271
1272 2009-09-24  Benjamin Poulain  <benjamin.poulain@nokia.com>
1273
1274         Reviewed by Eric Seidel.
1275
1276         https://bugs.webkit.org/show_bug.cgi?id=29005
1277         The indices of RuntimeArray should be enumerated like for a regular array.
1278
1279         * DumpRenderTree/mac/ObjCController.m:
1280         (+[ObjCController isSelectorExcludedFromWebScript:]):
1281         (+[ObjCController webScriptNameForSelector:]):
1282         (-[ObjCController arrayOfString]):
1283
1284 2009-09-23  David Kilzer  <ddkilzer@apple.com>
1285
1286         <http://webkit.org/b/28910> Move bugzilla-tool mark-fixed to standalone mark-bug-fixed tool
1287
1288         Reviewed by Darin Adler.
1289
1290         Also fixed a bug where specifying a revision on the command-line
1291         as 'r12345' would fail.  See <http://webkit.org/b/29699>.
1292
1293         * Scripts/bugzilla-tool: Updated module import statements.
1294         (parse_bug_id): Removed.  Moved to bugzilla.py.
1295         (bug_comment_from_svn_revision): Removed.  Moved to comments.py.
1296         (bug_comment_from_commit_text): Removed.  Moved to comments.py.
1297         (MarkBugFixed): Removed.  Code moved to mark-bug-fixed.
1298         (BugzillaTool.__init__): Removed mark-fixed subcommand.
1299         * Scripts/mark-bug-fixed: Added.
1300         * Scripts/modules/bugzilla.py:
1301         (parse_bug_id): Added.  Moved from bugzilla-tool.
1302         * Scripts/modules/comments.py: Added.
1303         (bug_comment_from_svn_revision): Added.  Moved from bugzilla-tool.
1304         (bug_comment_from_commit_text): Added.  Moved from bugzilla-tool.
1305
1306 2009-09-23  Marshall Culpepper  <mculpepper@appcelerator.com>
1307
1308         Reviewed by Eric Seidel.
1309         
1310          jpeg.lib is now libjpeg.lib in DRT Cairo dependencies. return
1311          "false" in non-implemented stub for setAlwaysAcceptCookies.
1312          https://bugs.webkit.org/show_bug.cgi?id=29661
1313
1314         * DumpRenderTree/win/DumpRenderTree.vcproj:
1315         * DumpRenderTree/win/DumpRenderTree.cpp:
1316
1317 2009-09-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1318
1319         Reviewed by Xan Lopez.
1320
1321         [GTK] need to dump number of pending unload handlers
1322         https://bugs.webkit.org/show_bug.cgi?id=29685
1323
1324         Implement dumping of the number of pending unload handlers.
1325
1326         The following tests will pass:
1327
1328           fast/loader/unload-form-about-blank.html
1329           fast/loader/unload-form-post-about-blank.html
1330           fast/loader/unload-form-post.html
1331           fast/loader/unload-form.html
1332           fast/loader/unload-hyperlink.html
1333           fast/loader/unload-javascript-url.html
1334           fast/loader/unload-reload.html
1335           fast/loader/unload-window-location.html
1336
1337         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1338         (getFrameNameSuitableForTestResult):
1339         (webViewLoadFinished):
1340
1341 2009-09-22  Shinichiro Hamaji  <hamaji@chromium.org>
1342
1343         Reviewed by Eric Seidel.
1344
1345         js tests should move into jstests subdirectory instead of resources/
1346         https://bugs.webkit.org/show_bug.cgi?id=25880
1347
1348         Remove support of resources directory.
1349
1350         * Scripts/make-script-test-wrappers:
1351
1352 2009-09-22  Eric Seidel  <eric@webkit.org>
1353
1354         No review, only fixing typo (missing space character).
1355
1356         Fix typo from https://bugs.webkit.org/show_bug.cgi?id=29220
1357
1358         * Scripts/run-webkit-tests:
1359
1360 2009-09-22  Eric Seidel  <eric@webkit.org>
1361
1362         Reviewed by Darin Adler.
1363
1364         run-webkit-tests needs a --repeat-each=N option (AAABBBCCC instead of ABCABCABC)
1365         https://bugs.webkit.org/show_bug.cgi?id=29220
1366
1367         * Scripts/run-webkit-tests:
1368
1369 2009-09-22  Eric Seidel  <eric@webkit.org>
1370
1371         Reviewed by David Kilzer.
1372
1373         svn-apply can't handle single-line binary file additions
1374         https://bugs.webkit.org/show_bug.cgi?id=29100
1375
1376         Fixed the regexp and added a unit test.
1377
1378         * Scripts/modules/scm_unittest.py:
1379         * Scripts/svn-apply:
1380
1381 2009-09-11  Eric Seidel  <eric@webkit.org>
1382
1383         Reviewed by David Kilzer.
1384
1385         post-diff and post-commits should be able to find bug urls in ChangeLogs.
1386         https://bugs.webkit.org/show_bug.cgi?id=29206
1387
1388         * Scripts/bugzilla-tool:
1389          - Share common options by adding a PostDiffAsPatchToBug.posting_options() method.
1390          - Rename --no-comment to --add-log-as-comment and reverse behavior.
1391            Comments tend to just be noise.  I'll eventually remove this argument if no one uses it.
1392          - Split out code into helper functions to try and make execute() more legible.
1393          - Make post-diff find the bug url in the ChangeLogs if not passed as an argument.
1394          - Fallback to bug urls in commit diffs, instead of just in commit messages,
1395            meaning post-commits will now find bug urls in ChangeLogs.
1396
1397 2009-09-21  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
1398
1399         Reviewed by Maciej Stachowiak.
1400
1401         --parse-only parameter wasn't passed to SunSpider/sunspider script.
1402         https://bugs.webkit.org/show_bug.cgi?id=29611
1403
1404         * Scripts/run-sunspider: Missing parameter passing added.
1405
1406 2009-09-20  David Kilzer  <ddkilzer@apple.com>
1407
1408         <http://webkit.org/b/29521> run-webkit-tests: use require instead eval to load DumpRenderTreeSupport module
1409
1410         Reviewed by Mark Rowe.
1411
1412         The require statement is like the use statement, except that it
1413         is run during script execution instead of during the 'BEGIN'
1414         phase.  This makes it possible to change @INC before the require
1415         statement is run.  See 'require' and 'use' in the perlfunc(1)
1416         manpage and 'BEGIN' in perlmod(1) manpage.
1417
1418         * Scripts/run-webkit-tests: Replace eval statement with require
1419         statement.
1420
1421 2009-09-18  Kevin Ollivier  <kevino@theolliviers.com>
1422
1423         wx build fixes. Fix the config name under git and allow users to specify
1424         their own waf install for experimenting with new versions.
1425
1426         * Scripts/webkitdirs.pm:
1427         * wx/build/settings.py:
1428
1429 2009-09-18  Alex Milowski  <alex@milowski.com>
1430
1431         Reviewed by Maciej Stachowiak.
1432
1433         Added checkWebCoreMathMLSupport and hasMathMLSupport to support 
1434         checking for whether MathML tests should be run
1435
1436         * Scripts/run-webkit-tests:
1437         * Scripts/webkitdirs.pm:
1438
1439 2009-08-28  Darin Adler  <darin@apple.com>
1440
1441         Reviewed by Mark Rowe.
1442
1443         Break more of run-webkit-tests into separate functions
1444         https://bugs.webkit.org/show_bug.cgi?id=29497
1445
1446         Some small steps toward improving run-webkit-tests. My goal is to
1447         refactor much more of the script into functions. Later we can add
1448         parallel test running to the tool. But better structure may help
1449         even if someone decides to translate this into another scripting
1450         language instead.
1451
1452         * Scripts/run-webkit-tests: Break more pieces of the script into
1453         seprate functions. Added readSkippedFiles, findTestsToRun, and
1454         printResults functions. Removed custom code to skip results.html
1455         and instead just put it into the ignoredFiles hash. Fixed some
1456         indentation. Sorted function declarations, global variables,
1457         and options at the top of the file alphabetically so they're not
1458         in a semi-random order.
1459
1460 2009-09-17  Kevin Ollivier  <kevino@theolliviers.com>
1461
1462         wx build fix, add missing dependency.
1463
1464         * wx/browser/wscript:
1465
1466 2009-09-16  Mark Rowe  <mrowe@apple.com>
1467
1468         Split the SnowLeopard build across a few machines.
1469
1470         * BuildSlaveSupport/build.webkit.org-config/config.json:
1471
1472 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
1473
1474         wx build fix to support monolithic builds on Windows.
1475
1476         * wx/build/wxpresets.py:
1477
1478 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
1479
1480         wx build fix, improve debug support and 2.9 support on MSW.
1481
1482         * wx/build/settings.py:
1483         * wx/build/wxpresets.py:
1484
1485 2009-09-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1486
1487         Blind try at fixing new test failure on Windows.
1488
1489         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1490         (FrameLoadDelegate::didReceiveTitle):
1491
1492 2009-09-15  Alex Milowski  <alex@milowski.com>
1493
1494         Reviewed by Tor Arne Vestbø.
1495
1496         Added mathml toggle
1497
1498         * Scripts/build-webkit:
1499
1500 2009-09-15  Kevin Ollivier  <kevino@theolliviers.com>
1501
1502         wx build fix. Allow waf build to support Python < 2.6.
1503
1504         * wx/build/waf_extensions.py:
1505
1506 2009-09-14  Chris Marrin  <cmarrin@apple.com>
1507
1508         Reviewed by Oliver Hunt.
1509
1510         Add LayoutTests infrastructure to enable and disable webgl tests.
1511         https://bugs.webkit.org/show_bug.cgi?id=29254
1512
1513         * Scripts/run-webkit-tests:
1514         * Scripts/webkitdirs.pm:
1515
1516 2009-09-14  Simon Fraser  <simon.fraser@apple.com>
1517
1518         Reviewed by Darin Adler.
1519         
1520         Add --iterations option to run-webkit-tests to repeat the tests N times
1521         https://bugs.webkit.org/show_bug.cgi?id=29263
1522
1523         When run with --iterations N, run-webkit-tests will repeat the tests N times.
1524
1525         * Scripts/run-webkit-tests:
1526
1527 2009-09-14  Brady Eidson  <beidson@apple.com>
1528
1529         Not reviewed, maybe should've been:
1530
1531         Cleaning up more Windows-specific fallout from the fix for:
1532         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
1533
1534         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1535         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):  Correct printf() formatter, 
1536           and call the correct method to get the Sender.
1537
1538 2009-09-14  Jon Honeycutt  <jhoneycutt@apple.com>
1539
1540         GTK build fix.
1541
1542         Unreviewed.
1543
1544         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1545         (AccessibilityController::setLogScrollingStartEvents):
1546
1547 2009-09-11  Jon Honeycutt  <jhoneycutt@apple.com>
1548
1549         DRT/test part of
1550         <rdar://problem/7197644> WebKit should broadcast an MSAA event when
1551         jumping to a named anchor
1552
1553         https://bugs.webkit.org/show_bug.cgi?id=28899
1554
1555         Reviewed by Adam Roben.
1556
1557         * DumpRenderTree/AccessibilityController.cpp:
1558         (logScrollingStartEventsCallback):
1559         Turn on logging of scrolling start events.
1560         (AccessibilityController::getJSClass):
1561         Add a "logScrollingStartEvents" to the AccessibilityController's JS
1562         class definition.
1563         (AccessibilityController::resetToConsistentState):
1564         Turn off logging of scrolling start events.
1565
1566         * DumpRenderTree/AccessibilityController.h:
1567         Declare setLogScrollingStartEvents(). Add a member for the scrolling
1568         start event hook.
1569
1570         * DumpRenderTree/mac/AccessibilityControllerMac.cpp:
1571         (AccessibilityController::setLogScrollingStartEvents):
1572         Stubbed.
1573
1574         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1575         (AccessibilityController::AccessibilityController):
1576         Initialize the handle to 0.
1577         (logEventProc):
1578         Renamed from logFocusEventProc; now logs scrolling start events, too.
1579         Removed the assertion that the event is a focus event. Added a switch
1580         to print a message for focus, scrolling start, and other, unknown
1581         events.
1582         (AccessibilityController::setLogFocusEvents):
1583         Changed to use logEventProc.
1584         (AccessibilityController::setLogScrollingStartEvents):
1585         If turning logging off, unhook the scrolling start event hook, and clear
1586         the member holding the handle. If turning on, query for the root
1587         accessible, so that accessibility is enabled for the WebView, and call
1588         SetWinEventHook to setup an event hook using logEventProc as the
1589         callback function.
1590
1591 2009-09-14  Brady Eidson  <beidson@apple.com>
1592
1593         Windows build fix.
1594
1595         * DumpRenderTree/LayoutTestController.cpp:
1596         (setAuthenticationPasswordCallback):
1597         (setAuthenticationUsernameCallback):
1598         
1599         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1600         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1601
1602 2009-09-14  Brady Eidson  <beidson@apple.com>
1603
1604         Reviewed by Alexey Proskuryakov.
1605
1606         Safari 4 cannot be used to update firmware on Linksys routers.
1607         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
1608
1609         Add the ability for DRT to handle authentication challenges.
1610
1611         * DumpRenderTree/LayoutTestController.cpp:
1612         (setAuthenticationPasswordCallback):
1613         (setAuthenticationUsernameCallback):
1614         (setHandlesAuthenticationChallengesCallback):
1615         (LayoutTestController::staticFunctions):
1616
1617         * DumpRenderTree/LayoutTestController.h:
1618         (LayoutTestController::handlesAuthenticationChallenges):
1619         (LayoutTestController::setHandlesAuthenticationChallenges):
1620         (LayoutTestController::authenticationUsername):
1621         (LayoutTestController::setAuthenticationUsername):
1622         (LayoutTestController::authenticationPassword):
1623         (LayoutTestController::setAuthenticationPassword):
1624
1625         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1626         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
1627
1628         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1629         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1630         * DumpRenderTree/win/ResourceLoadDelegate.h:
1631
1632 2009-09-12  Mark Rowe  <mrowe@apple.com>
1633
1634         Reviewed by Dan Bernstein.
1635
1636         Test for <rdar://problem/6954546> and <rdar://problem/7090444>.
1637
1638         Add a flag on the test plug-in that asks it to clear the document during the call to NPP_New.
1639         This is the trigger for both <rdar://problem/6954546> and <rdar://problem/7090444>.
1640
1641         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1642         (NPP_New):
1643
1644 2009-09-14  Kevin Ollivier  <kevino@theolliviers.com>
1645
1646         wx build fix for non-wxPython builds and a fix for errors when updating swig.py.
1647
1648         * wx/build/build_utils.py:
1649         * wx/build/settings.py:
1650
1651 2009-09-14  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
1652
1653         Reviewed by Tor Arne Vestbø.
1654
1655         [Qt] Build fix for windows build.
1656
1657         * Scripts/bisect-builds: Add missing paranthesis for tmpdir function.
1658
1659 2009-09-13  Kevin Ollivier  <kevino@theolliviers.com>
1660
1661         Fix typo accidently landed in last commit.
1662
1663         * wx/build/settings.py:
1664
1665 2009-09-13  Kevin Ollivier  <kevino@theolliviers.com>
1666
1667         wx build fix, error out if using the wrong Python.
1668
1669         * wx/build/settings.py:
1670
1671 2009-09-13  Xan Lopez  <xlopez@igalia.com>
1672
1673         Build fix for GTK+ < 2.14.
1674
1675         Do not use gtk_widget_get_window, access the window directly
1676         through the struct.
1677
1678         * DumpRenderTree/gtk/EventSender.cpp:
1679         (contextClickCallback):
1680         (mouseDownCallback):
1681         (mouseUpCallback):
1682         (mouseMoveToCallback):
1683         (keyDownCallback):
1684
1685 2009-09-13  Martin Robinson  <martin.james.robinson@gmail.com>
1686
1687         Reviewed by Xan Lopez and Jan Alonzo.
1688
1689         [GTK] EventSender does not set 'window' property on synthesized GDK events
1690         https://bugs.webkit.org/show_bug.cgi?id=29169
1691
1692         Set the window property on synthesized GDK events in the GTK+ EventSender.
1693
1694         * DumpRenderTree/gtk/EventSender.cpp:
1695         (contextClickCallback):
1696         (mouseDownCallback):
1697         (mouseUpCallback):
1698         (mouseMoveToCallback):
1699         (keyDownCallback):
1700
1701 2009-09-12  Drew Wilson  <atwilson@google.com>
1702
1703         Reviewed by Mark Rowe.
1704
1705         run-webkit-tests has a timeout value that is too low
1706         https://bugs.webkit.org/show_bug.cgi?id=29223
1707
1708         * Scripts/run-webkit-tests:
1709         Changed timeout value to 20 seconds to avoid timing out too early.
1710
1711 2009-09-11  Kevin Ollivier  <kevino@theolliviers.com>
1712
1713         wx build fix. Mark dependencies as mandatory and declare which MSVC versions and
1714         architectures are supported for building wxWebKit.
1715
1716         * wx/build/settings.py:
1717
1718 2009-09-11  Eric Seidel  <eric@webkit.org>
1719
1720         Reviewed by David Levin.
1721
1722         bugzilla-tool rollout threw exception under svn
1723         https://bugs.webkit.org/show_bug.cgi?id=29211
1724
1725         * Scripts/modules/scm.py: add missing return, and convert number arguments to strings.
1726         * Scripts/modules/scm_unittest.py: add testing for this fix.
1727
1728 2009-09-11  Brian Weinstein  <bweinstein@apple.com>
1729
1730         Add myself to the committers list.
1731
1732         * Scripts/modules/committers.py:
1733
1734 2009-09-11  Eric Seidel  <eric@webkit.org>
1735
1736         Reviewed by Adam Barth.
1737
1738         bugzilla-tool land-patches should only fail-fast in --commit-queue mode
1739         https://bugs.webkit.org/show_bug.cgi?id=29201
1740
1741         * Scripts/bugzilla-tool:
1742
1743 2009-09-11  Adam Roben  <aroben@apple.com>
1744
1745         Make commit-log-editor move common prefixes to the top of the log
1746
1747         Fies <http://webkit.org/b/29190> commit-log-editor should move common
1748         prefixes to the top of the commit log
1749
1750         Reviewed by Darin Adler.
1751
1752         * Scripts/commit-log-editor: Find and remove the longest common prefix
1753         ending in a double newline from each ChangeLog entry, then put that
1754         common prefix at the top of the commit log.
1755         (removeLongestCommonPrefixEndingInDoubleNewline): Added. Finds,
1756         removes, and returns the longest common prefix ending in a double
1757         newline from a hash of strings
1758
1759 2009-09-11  Eric Seidel  <eric@webkit.org>
1760
1761         Fix obvious typo in previous commit, no review.
1762
1763         bugzilla-tool should automate rollouts
1764         https://bugs.webkit.org/show_bug.cgi?id=26715
1765
1766         * Scripts/bugzilla-tool: add back missing "scm" argument.
1767
1768 2009-09-11  Eric Seidel  <eric@webkit.org>
1769
1770         Reviewed by Adam Barth.
1771
1772         bugzilla-tool should automate rollouts
1773         https://bugs.webkit.org/show_bug.cgi?id=26715
1774
1775         bugzilla-tool rollout will do the rollout locally and leave the diff for you to verify and commit.
1776         The --complete-rollout option will automatically land and update the bug.
1777         Eventually --complete-rollout will be default, but that will require more testing.
1778
1779         This first pass is good enough for others to try and file bugs about.
1780
1781         * Scripts/bugzilla-tool:
1782          - Move modified_changelogs into scm.py.
1783          - Move svn_revision_from_commit_text logic into scm.py.
1784          - Add RolloutCommit command.
1785         * Scripts/modules/bugzilla.py:
1786          - Add reopen_bug command used by RolloutCommit.
1787         * Scripts/modules/scm.py:
1788          - Add functions to support RolloutCommit.
1789          - Abstract find_uuid into value_from_svn_info so it can be re-used for _repository_url (needed by svn merge).
1790          - Add a str() call so that svn_commit_log can take a numeric argument.
1791          - Remove a bunch of very slow code from last_svn_commit_log and used the built-in 'BASE' alias instead.
1792          - Made dry_run commits return something that svn_revision_from_commit_text can parse.
1793         * Scripts/modules/scm_unittest.py:
1794          - Add read_from_path for easy file reading.
1795          - Put test4 on a new line to make reverts work w/o conflict.
1796          - Add an "svn update" call so that the checkout revision matches the server revision.
1797          - Add tests for svn_revision_from_commit_text.
1798          - Add a simple test for apply_reverse_diff.
1799          - Add a new self.scm member and use it in the new tests (eventually other tests can use it too).
1800          - Add test for svn_commit_log to make sure my 'BASE' change above worked as expected.
1801
1802 2009-09-11  Adam Roben  <aroben@apple.com>
1803
1804         Get user script/stylesheet tests running on Windows
1805
1806         Fixes <http://webkit.org/b/29181> User script/stylesheet tests are
1807         skipped on Windows
1808
1809         Reviewed by John Sullivan.
1810
1811         * DumpRenderTree/win/DumpRenderTree.vcproj: Link all configurations
1812         against comsuppw.lib so we can use _bstr_t.
1813
1814         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Fixed #include
1815         order, added #include of comutil.h for _bstr_t.
1816
1817         (bstrT): Helper function to convert a JSStringRef to a _bstr_t.
1818         (LayoutTestController::addUserScript):
1819         (LayoutTestController::addUserStyleSheet):
1820         Implemented. Implementations were based on those in
1821         LayoutTestControllerMac.mm.
1822
1823 2009-09-10  David Kilzer  <ddkilzer@apple.com>
1824
1825         <http://webkit.org/b/29147> run-webkit-tests:  make -h show help 
1826
1827         Reviewed by Mark Rowe.
1828
1829         * Scripts/run-webkit-tests: Updated to make -h switch show help.
1830
1831 2009-09-10  Fumitoshi Ukai  <ukai@chromium.org>
1832
1833         Reviewed by Alexey Proskuryakov.
1834
1835         Add WebCore/websockets directory in wx build system.
1836         https://bugs.webkit.org/show_bug.cgi?id=28038
1837
1838         * wx/build/settings.py:
1839
1840 2009-09-10  Martin Robinson  <martin.james.robinson@gmail.com>
1841
1842         [GTK] EventSender does not properly convert some keyDown strings
1843         https://bugs.webkit.org/show_bug.cgi?id=29119
1844
1845         Add more keyDown string to character code conversions for GTK+ EventSender.
1846
1847         * DumpRenderTree/gtk/EventSender.cpp:
1848         (keyDownCallback):
1849
1850 2009-09-09  Steve Block  <steveblock@google.com>
1851
1852         Reviewed by Maciej Stachowiak.
1853
1854         Geolocation Coordinates::toString() prints bogus values for unspecified properties.
1855         https://bugs.webkit.org/show_bug.cgi?id=29080
1856
1857         * Scripts/make-script-test-wrappers: Modified. Adds asynchronous Geolocation tests to exclusion list.
1858
1859 2009-09-09  Eric Seidel  <eric@webkit.org>
1860
1861         Reviewed by Eric Carlson.
1862
1863         reviewer/committer lookups are backwards
1864         https://bugs.webkit.org/show_bug.cgi?id=29113
1865
1866         I also moved Eric Carlson from the committer list to the reviewer list now that he is one.
1867
1868         * Scripts/modules/bugzilla.py:
1869         * Scripts/modules/committers.py:
1870
1871 2009-09-09  Cameron McCormack  <cam@mcc.id.au>
1872
1873         Reviewed by Eric Seidel.
1874
1875         svn-unapply doesn't revert directories correctly
1876         https://bugs.webkit.org/show_bug.cgi?id=29065
1877
1878         * Scripts/svn-unapply: Make svnStatus consistently return status
1879         lines including a newline.
1880         * Scripts/svn-apply: Keep svnStatus in sync with the one in
1881         svn-unapply, in lieu of moving it to a common file.
1882
1883 2009-09-09  Cameron McCormack  <cam@mcc.id.au>
1884
1885         Reviewed by Eric Seidel.
1886
1887         svn-apply doesn't handle changes to files copied to new directories properly
1888         https://bugs.webkit.org/show_bug.cgi?id=29059
1889
1890         * Scripts/svn-apply: Don't treat "--- revision 0" patches as being
1891         additions if we know that we've just copied a file to this name.
1892
1893 2009-09-09  Eric Seidel  <eric@webkit.org>
1894
1895         Reviewed by David Levin.
1896
1897         commit-queue hangs if a builder has never built
1898         https://bugs.webkit.org/show_bug.cgi?id=29091
1899
1900         * Scripts/modules/buildbot.py:
1901         * Scripts/modules/buildbot_unittest.py:
1902
1903 2009-09-09  Zan Dobersek  <zandobersek@gmail.com>
1904
1905         Reviewed by Gustavo Noronha.
1906
1907         [GTK] DumpRenderTree needs eventSender object and implementation
1908         https://bugs.webkit.org/show_bug.cgi?id=25990
1909
1910         Implements most of the EventSender object's functionality for
1911         the DumpRenderTree tool. Implementation still lacks support
1912         for drag and drop tests and forward leaps.
1913
1914         Based on work by Holger Hans Peter Freyther.
1915
1916         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1917         (runTest): Focus on the view before loading a new test.
1918         (webViewWindowObjectCleared):
1919         * DumpRenderTree/gtk/EventSender.cpp: Added.
1920         (getDragModeCallback):
1921         (setDragModeCallback):
1922         (leapForwardCallback):
1923         (contextClickCallback):
1924         (updateClickCount):
1925         (mouseDownCallback):
1926         (mouseUpCallback):
1927         (mouseMoveToCallback):
1928         (beginDragWithFilesCallback):
1929         (replaySavedEvents):
1930         (keyDownCallback):
1931         (textZoomInCallback):
1932         (textZoomOutCallback):
1933         (zoomPageInCallback):
1934         (zoomPageOutCallback):
1935         (getClass):
1936         (makeEventSender):
1937         * DumpRenderTree/gtk/EventSender.h: Added.
1938         * GNUmakefile.am: Add build rules for EventSender.
1939
1940 2009-09-09  Daniel Bates  <dbates@webkit.org>
1941
1942         Reviewed by Adam Roben.
1943         
1944         https://bugs.webkit.org/show_bug.cgi?id=28953
1945
1946         Added pre- and post- build events so that on build failure, the file 
1947         buildfailed is written to the directory $(WebKitOutputDir).
1948
1949         * WinLauncher/WinLauncher.vcproj:
1950
1951 2009-09-09  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1952
1953         Unreviewed.
1954
1955         Add myself to list of committers.
1956
1957         * Scripts/modules/committers.py:
1958
1959 2009-09-08  Eric Seidel  <eric@webkit.org>
1960
1961         Reviewed by David Levin.
1962
1963         commit-queue gets stuck if a non-committer sets commit-queue+ or review+
1964         https://bugs.webkit.org/show_bug.cgi?id=28605
1965         https://bugs.webkit.org/show_bug.cgi?id=28916
1966
1967         * Scripts/bugzilla-tool:
1968          - Fix comment and adjust reject_patch_from_commit_queue call to pass "manual commit"
1969            comment now that it's used for rejecting patches for invalid committers too.
1970          - Pass reject_invalid_patches=True for commit-queue calls, normally we just ignore patches with invalid reviewers, the commit-queue rejects them.
1971          - Make the commit queue print patches count instead of bugs count, this also fixes https://bugs.webkit.org/show_bug.cgi?id=28916.
1972         * Scripts/modules/bugzilla.py:
1973          - Make _parse_attachment_element not validate reviewer/committer.
1974          - Share flag parsing code in _parse_attachment_flag.
1975          - Add _validate* methods for validating reviewers and committers and updating bugs when validation fails.
1976          - Add reject_invalid_patches argument so the commit-queue can update bugs on failed validation and other "read only" commands will not.
1977          - Add reject_patch_from_review_queue using a new _set_flag_on_attachment abstraction.
1978         * Scripts/modules/bugzilla_unittest.py:
1979          - Update this test to no longer expect committer/reviewer validation.
1980         * Scripts/modules/committers.py:
1981          - Return None on failed lookups instead of raising Exceptions.
1982         * Scripts/modules/committers_unittest.py:
1983          - Update tests to expect None returns instead of exceptions.
1984
1985 2009-09-09  David Kilzer  <ddkilzer@apple.com>
1986
1987         <http://webkit.org/b/29061> Fix obvious copy-paste error in AccessibilityUIElement::clickPointY()
1988
1989         Reviewed by Mark Rowe.
1990
1991         No change to layout test results.
1992
1993         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1994         (AccessibilityUIElement::clickPointY): Changed to return y value
1995         instead of x value.
1996
1997 2009-09-08  Dimitri Glazkov  <dglazkov@chromium.org>
1998
1999         Reviewed by Mark Rowe.
2000
2001         Reduce dglazkov's boboiness by properly concatenating revision value.
2002
2003         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Used substitution
2004             rather than "+".
2005
2006 2009-09-08  Kevin Ollivier  <kevino@theolliviers.com>
2007
2008         wxWebKit Python extension build fix - get swig.py if it doesn't exist.
2009
2010         * wx/build/build_utils.py:
2011
2012 2009-09-08  Mark Rowe  <mrowe@apple.com>
2013
2014         Fix an incorrect variable name in UpdateChromiumSource.
2015
2016         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2017
2018 2009-09-08  Mark Rowe  <mrowe@apple.com>
2019
2020         Don't check for leaks on the release SnowLeopard builder.
2021
2022         * BuildSlaveSupport/build.webkit.org-config/config.json:
2023
2024 2009-09-08  Mark Rowe  <mrowe@apple.com>
2025
2026         Add a SnowLeopard release builder.
2027
2028         * BuildSlaveSupport/build.webkit.org-config/config.json:
2029
2030 2009-09-08  David Levin  <levin@chromium.org>
2031
2032         Reviewed by Darin Adler.
2033
2034         Remove end of line whitespace check from check-webkit-style.
2035         https://bugs.webkit.org/show_bug.cgi?id=29053
2036
2037         * Scripts/modules/cpp_style.py:
2038
2039 2009-09-08  Cameron McCormack  <cam@mcc.id.au>
2040
2041         Reviewed by Darin Adler.
2042
2043         Fix DumpRenderTree build from clean tree on Tiger
2044         https://bugs.webkit.org/show_bug.cgi?id=28927
2045
2046         * DumpRenderTree/mac/PerlSupport/Makefile: Ensure the
2047         DerivedSources/DumpRenderTree directory exists when
2048         building on Tiger.
2049
2050 2009-09-08  Kevin Ollivier  <kevino@theolliviers.com>
2051
2052         wx build fix after introduction of platform/mock directory.
2053
2054         * wx/build/settings.py:
2055
2056 2009-09-08  Yael Aharon  <yael.aharon@nokia.com>
2057
2058         Unreviewed.
2059
2060         Add myself to list of committers.
2061
2062         * Scripts/modules/committers.py:
2063
2064 2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2065
2066         Unreviewed.
2067
2068         Add myself to list of committers.
2069
2070         * Scripts/modules/committers.py:
2071
2072 2009-09-08  Cameron McCormack  <cam@mcc.id.au>
2073
2074         Reviewed by Darin Adler.
2075
2076         prepare-ChangeLog too chatty on file additions
2077         https://bugs.webkit.org/show_bug.cgi?id=29019
2078
2079         * Scripts/prepare-ChangeLog: Omit description of added properties
2080         on newly added files.
2081
2082 2009-09-08  Steve Block  <steveblock@google.com>
2083
2084         Reviewed by Adam Barth.
2085
2086         Adds a LayoutTestController method to set the permission state for Geolocation.
2087         This is required to use the mock Geolocation service for testing.
2088         https://bugs.webkit.org/show_bug.cgi?id=29027
2089
2090         * DumpRenderTree/LayoutTestController.cpp: Modified.
2091         (setDatabaseQuotaCallback): Modified. Style fix.
2092         (setGeolocationPermissionCallback): Added. Sets the Geolocation permission state.
2093         (LayoutTestController::staticFunctions): Modified. Registers the above function on the LayoutTestController.
2094         * DumpRenderTree/LayoutTestController.h: Modified.
2095         (LayoutTestController::setGeolocationPermission): Added. Sets the Geolocation permission state.
2096         (LayoutTestController::isGeolocationPermissionSet): Added. Returns whether the Geolocation permission has been set.
2097         (LayoutTestController::geolocationPermission): Added. Returns the Geolocation permission state.
2098         * DumpRenderTree/mac/UIDelegate.mm: Modified.
2099         (-[UIDelegate webView:frame:requestGeolocationPermission:securityOrigin:]): Added. Implement chrome method to respond to request for Geolocation permission state. Response is made using above methods to access permission state.
2100
2101 2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2102
2103         Reviewed by Simon Hausmann.
2104
2105         [Qt] QtWebKit single API to enable persistency
2106         https://bugs.webkit.org/show_bug.cgi?id=28682
2107
2108         Use the new enablePersistentStorage API instead 
2109         of enabling all persistent features one-by-one.
2110
2111         * DumpRenderTree/qt/DumpRenderTree.cpp:
2112         (WebCore::WebPage::WebPage):
2113         (WebCore::DumpRenderTree::DumpRenderTree):
2114
2115 2009-09-07  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2116
2117         Reviewed by Tor Arne Vestbø.
2118
2119         Refactor --strict switch to --ignore-metrics and correct the
2120         implementation to make the feature usable on all platforms.
2121         https://bugs.webkit.org/show_bug.cgi?id=28907
2122
2123         run-webkit-tests --ignore-metrics strips the font related metrics from
2124         the actual and expected data before comparing them.
2125         In this way the render trees can be checked for obvious differences but
2126         a successful test implies by no means that the layout is actually correct.
2127
2128         * Scripts/run-webkit-tests:
2129
2130 2009-09-07  Steve Block  <steveblock@google.com>
2131
2132         Reviewed by Adam Barth.
2133
2134         Adds a mock Geolocation service. This will be used to provide predictable behavior of the
2135         Geolocation API for use in LayoutTests. Later changes will integrate the the mock
2136         Geolocation service with DumpRenderTree.
2137         https://bugs.webkit.org/show_bug.cgi?id=28264
2138
2139         * DumpRenderTree/LayoutTestController.cpp: Modified.
2140         (setMockGeolocationPositionCallback): Added. Configures the mock Geolocation service.
2141         (setMockGeolocationErrorCallback): Added. Configures the mock Geolocation service.
2142         (LayoutTestController::staticFunctions): Added. Registers the above functions on the LayoutTestController.
2143         * DumpRenderTree/LayoutTestController.h: Modified.
2144         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Modified.
2145         (LayoutTestController::setMockGeolocationPosition): Added. Configures the mock Geolocation service.
2146         (LayoutTestController::setMockGeolocationError): Added. Configures the mock Geolocation service.
2147
2148 2009-09-07  Drew Wilson  <atwilson@google.com>
2149
2150         Reviewed by David Levin.
2151
2152         Enable SHARED_WORKERS by default
2153         https://bugs.webkit.org/show_bug.cgi?id=28959
2154
2155         * Scripts/build-webkit:
2156
2157 2009-09-07  Kevin Ollivier  <kevino@theolliviers.com>
2158
2159         wx build fixes for wx SVN trunk.
2160
2161         * wx/build/settings.py:
2162
2163 2009-09-04  Kevin Ollivier  <kevino@theolliviers.com>
2164
2165         wx build fix. Switch USE_ defines over to the compiler so that they can be
2166         checked by files not including config.h (like WebCorePrefix.h).
2167
2168         * wx/build/settings.py:
2169
2170 2009-09-04  Adam Barth  <abarth@webkit.org>
2171
2172         Unreviewed build fix.
2173
2174         Update declaration of FrameLoadDelegate to reflect that
2175         IWebFrameLoadDelegatePrivate2 inherits from
2176         IWebFrameLoadDelegatePrivate.
2177
2178         * DumpRenderTree/win/FrameLoadDelegate.h:
2179
2180 2009-09-04  Adam Barth  <abarth@webkit.org>
2181
2182         Reviewed by Eric Seidel.
2183
2184         https://bugs.webkit.org/show_bug.cgi?id=24696
2185
2186         Add testing instrumentation for mixed content.
2187
2188         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2189         (-[FrameLoadDelegate webView:]):
2190         (-[FrameLoadDelegate webView:didRunInsecureContent:]):
2191         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2192         (descriptionSuitableForTestResult):
2193         (FrameLoadDelegate::QueryInterface):
2194         (FrameLoadDelegate::didDisplayInsecureContent):
2195         (FrameLoadDelegate::didRunInsecureContent):
2196         * DumpRenderTree/win/FrameLoadDelegate.h:
2197
2198 2009-09-03  Kevin Watters  <kevinwatters@gmail.com>
2199
2200         Reviewed by Kevin Ollivier.
2201
2202         [wx] Frames support
2203         https://bugs.webkit.org/show_bug.cgi?id=19041
2204
2205         * wx/build-wxwebkit:
2206
2207 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2208
2209         <http://webkit.org/b/28880> svn-apply --force doesn't actually work
2210
2211         Reviewed by Eric Seidel.
2212
2213         This fixes "svn-apply --force" and adds unit tests for the
2214         scm.apply_patch() method which uses this script.
2215
2216         * Scripts/svn-apply: Created $globalExitCode variable that
2217         defaults to 0.  Exit with a value of $globalExitCode when the
2218         script is finished.
2219         (applyPatch): Ignore a non-zero $exitCode if $force is true, but
2220         set $globalExitCode to $exitCode so that svn-apply exits with a
2221         non-zero status if any patches did not apply cleanly.  Also
2222         print out the actual patch command if $force was not true.
2223
2224         * Scripts/modules/scm.py:
2225         (scripts_directory): Added.  Extracted from script_path().
2226         (script_path): Extracted scripts_directory().
2227         * Scripts/modules/scm_unittest.py: Import urllib.
2228         (SVNTestRepository.setup): Save the original working directory
2229         in test_object since this represents the WebKit repository from
2230         where the unit tests are run.
2231         (SCMTest): Created new super class to hold utility methods.
2232         (SCMTest._create_patch): Creates a patch file on disk and a
2233         dictionary for use with scm.svn_apply().
2234         (SCMTest._setup_webkittools_scripts_symlink): Sets up a symlink
2235         back to WebKitTools/Scripts in the test repository so that
2236         scm.apply_patch() is able to find the svn-apply script.
2237         (SVNTest): Inherit from SCMTest instead of unittest.TestCase.
2238         (SVNTest.tearDown): Make sure to change directories back to the
2239         original_path before the next test.
2240         (SVNTest.test_apply_svn_patch): New test case for applying an
2241         svn patch with scm.apply_patch().
2242         (SVNTest.test_apply_svn_patch_force): New test case for applying
2243         an svn patch with scm.apply_patch() that conflicts.
2244         (GitTest): Inherit from SCMTest instead of unittest.TestCase.
2245         (GitTest.tearDown): Make sure to change directories back to the
2246         original_path before the next test.
2247         (GitTest.test_apply_git_patch): New test case for applying a git
2248         patch with scm.apply_patch().
2249         (GitTest.test_apply_git_patch_force): New test case for applying
2250         a git patch with scm.apply_patch() that conflicts.
2251
2252 2009-09-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2253
2254         Reviewed by Mark Rowe.
2255
2256         [Qt] Add support for platform-spesific layout-test results
2257
2258         For the Qt port we use the qt-[mac|linux|win] directories and then fall
2259         back to the generic qt directory for both test results and skipped list.
2260
2261         * Scripts/run-webkit-tests:
2262         * Scripts/webkitdirs.pm:
2263
2264 2009-09-02  Laurent Cerveau  <lcerveau@me.com>
2265
2266         Reviewed by David Kilzer.
2267
2268         <http://webkit.org/b/25517> build-webkit script should print build time at end
2269
2270         * Scripts/build-webkit:
2271         Added startTime and endTime variable so that the build time is computed and printed as
2272         part of the build message; display formatting has been separated in a dedicated subroutine.
2273
2274 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2275
2276         <http://webkit.org/b/28881> svn-create-patch should check if the repo path is the same when trying to find the root
2277
2278         Reviewed by Eric Seidel.
2279
2280         * Scripts/VCSUtils.pm:
2281         (determineSvnRoot): Added back check for repository root that
2282         was removed in r46134 when this code lived in svn-create-patch.
2283         It's necessary to check both the repository root and the
2284         repository UUID in case two different working directories are
2285         checked out from the same repository.
2286
2287 2009-09-02  Timothy Hatcher  <timothy@apple.com>
2288
2289         Use new 512x512 icons for nightly builds.
2290
2291         Rubber-stamped by Mark Rowe.
2292
2293         * WebKitLauncher/webkit.icns:
2294
2295 2009-09-02  Kevin Ollivier  <kevino@theolliviers.com>
2296
2297         waf build fix. Remove local variable shadowing global.
2298
2299         * wx/build/settings.py:
2300
2301 2009-09-02  Zan Dobersek  <zandobersek@gmail.com>
2302
2303         Reviewed by David Kilzer.
2304
2305         Calls exitStatus function from the main package where it is also defined.
2306
2307         * Scripts/VCSUtils.pm:
2308
2309 2009-09-02  Kevin Ollivier  <kevino@theolliviers.com>
2310
2311         waf build fixes for Windows/MSVC and Mac/Snow Leopard.
2312
2313         * wx/browser/wscript:
2314         * wx/build/build_utils.py:
2315         * wx/build/settings.py:
2316
2317 2009-08-10  Kevin Ollivier  <kevino@theolliviers.com>
2318
2319         Reviewed by Eric Seidel.
2320
2321         Changes needed for build-webkit to support the waf build system for the wx port.
2322         
2323         https://bugs.webkit.org/show_bug.cgi?id=27619
2324
2325         * Scripts/build-webkit:
2326         * Scripts/run-launcher:
2327         * Scripts/webkitdirs.pm:
2328
2329 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2330
2331         <http://webkit.org/b/27168> With Subversion 1.6, update-webkit prompts on conflicts
2332
2333         Reviewed by Eric Seidel.
2334
2335         * Scripts/update-webkit: Added "--accept postpone" to
2336         @svnOptions when running with svn-1.6 or newer.
2337
2338 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2339
2340         Moved svn 1.6 version check into VCSUtils::isSVNVersion16OrNewer()
2341
2342         Reviewed by Eric Seidel.
2343
2344         * Scripts/VCSUtils.pm:
2345         (@EXPORT): Added &isSVNVersion16OrNewer.
2346         (svnVersion): Added.  Internal method that gets the SVN version
2347         and caches it.
2348         (isSVNVersion16OrNewer): Added.  Method that does the SVN 1.6
2349         version check.
2350         * Scripts/prepare-ChangeLog: Switched to use new
2351         isSVNVersion16OrNewer() method.
2352         * Scripts/resolve-ChangeLogs: Ditto.
2353         * Scripts/svn-create-patch: Ditto.
2354
2355 2009-09-02  David Kilzer  <ddkilzer@apple.com>
2356
2357         Clean up VCSUtils.pm
2358
2359         Reviewed by Eric Seidel.
2360
2361         * Scripts/VCSUtils.pm: Added proper package statement.  Fixed
2362         indentation of BEGIN block.  Listed each exported method on a
2363         line by itself.  Added methods to the export list after adding
2364         the package statement.  Sorted module variables.  Moved
2365         definiton of $gitRoot next to other module variables.
2366
2367 2009-09-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2368
2369         Rubber-stamped by Simon Hausmann.
2370
2371         [Qt] Fix layout-test plugins/plugin-javascript-access.html
2372
2373         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2374
2375 2009-09-02  Shinichiro Hamaji  <hamaji@chromium.org>
2376
2377         Reviewed by Eric Seidel.
2378
2379         js tests should move into jstests subdirectory instead of resources/
2380         https://bugs.webkit.org/show_bug.cgi?id=25880
2381
2382         make-script-wrappers supports both resources and script-tests directories.
2383         run-webkit-tests ignores files in script-tests.
2384         Move script tests of animations to check the new script is working.
2385
2386         * Scripts/make-script-test-wrappers:
2387         * Scripts/run-webkit-tests:
2388
2389 2009-09-02  Szabo Carol  <carol.szabo@nokia.com>
2390
2391         Reviewed by David Levin.
2392
2393         check-webkit-style uses python from /usr/bin instead of the PATH
2394         https://bugs.webkit.org/show_bug.cgi?id=28225
2395
2396         * Scripts/bugzilla-tool:
2397         * Scripts/check-webkit-style:
2398         * Scripts/run-webkit-unittests:
2399         * Scripts/update-sources-list.py:
2400           Changed the first line from
2401           #!/usr/bin/python
2402           to
2403           #!/usr/bin/env python
2404           which causes python to be invoked from the path location returned
2405           by "which python" when any of these scripts are launched.
2406           these are currently all the python scripts in WebKitTools/Scripts.
2407
2408 2009-09-01  David Kilzer  <ddkilzer@apple.com>
2409
2410         <http://webkit.org/b/28601> bugzilla-tool post-commits posts commits backwards
2411
2412         Reviewed by Adam Barth.
2413
2414         * Scripts/modules/scm.py:
2415         (Git.commit_ids_from_commitish_arguments): Reverse the list of
2416         commits returned from git-rev-list since we always want to post
2417         the oldest patches first to bugs.webkit.org.
2418         * Scripts/modules/scm_unittest.py:
2419         (run): Added return statement to return the output now that we
2420         want it sometimes.
2421         (SVNTestRepository._setup_test_commits): Added a fourth commit
2422         so the GitTest.test_commitish_order() test has more commits to
2423         work with.
2424         (GitTest.test_commitish_order): Added unit test for change to
2425         Git.commit_ids_from_commitish_arguments() in scm.py.
2426
2427 2009-09-01  David Kilzer  <ddkilzer@apple.com>
2428
2429         <http://webkit.org/b/28877> Implement bugzilla-tool mark-fixed
2430
2431         Reviewed by David Levin.
2432
2433         The mark-fixed subcommand is for those times when you don't use
2434         bugzilla-tool to commit a patch, but you want to use it to close
2435         the bug with a committed-revision message.
2436
2437         * Scripts/bugzilla-tool:
2438         (bug_comment_from_svn_revision): Added.  Extracted from
2439         bug_comment_from_commit_text().
2440         (bug_comment_from_commit_text): Extracted
2441         bug_comment_from_svn_revision() from this method.
2442         (MarkBugFixed.__init__): Added.
2443         (MarkBugFixed._fetch_commit_log): Added.  Retrieves the commit
2444         log from the last commit if no svn revision is specified, else
2445         the commit log for the specified svn revision.
2446         (MarkBugFixed._determine_bug_id_and_svn_revision): Added.
2447         Attempts to determine the bug id and svn revision if one or both
2448         were not defined on the command line.
2449         (MarkBugFixed.execute): Added.  Adds a comment about the
2450         revision that fixed the bug and closes the bug.
2451         (BugzillaTool.__init__): Added mark-fixed subcommand.
2452         * Scripts/modules/bugzilla.py:
2453         (Bugzilla.fetch_title_from_bug): Added.  Returns the title of a
2454         bug given a bug id.
2455         * Scripts/modules/scm.py:
2456         (SCM.strip_r_from_svn_revision): Added.  Utility method to strip
2457         the leading 'r' from an svn revision.
2458         (SCM.svn_commit_log): Added.  Subclasses must override.
2459         (SCM.last_svn_commit_log): Added.  Subclasses must override.
2460         (SVN.svn_commit_log): Added.  Returns svn log for a given
2461         revision.
2462         (SVN.last_svn_commit_log): Added.  Uses svnversion to find the
2463         last commit in an svn working directory and then runs svn log.
2464         (Git.svn_commit_log): Added.  Returns svn log for a given
2465         revision.
2466         (Git.last_svn_commit_log): Added.  Runs git-svn-log with a limit
2467         of one log message.
2468
2469 2009-09-01  David Kilzer  <ddkilzer@apple.com>
2470
2471         <http://webkit.org/b/28880> svn-apply --force doesn't actually work
2472
2473         Reviewed by Brady Eidson.
2474
2475         * Scripts/svn-apply:
2476         (applyPatch): Add "--force" to $options arrayref if $force is
2477         set.
2478
2479 2009-09-01  David Kilzer  <ddkilzer@apple.com>
2480
2481         <http://webkit.org/b/28725> resolve-ChangeLogs: determineVCSRoot() returns incorrect repository root during git filter-branch
2482
2483         Reviewed by Adam Roben.
2484
2485         When git-filter-branch has been invoked to rewrite ChangeLog
2486         files on series of git commits, it changes directories into
2487         .git-rewrite/t before re-running resolve-ChangeLogs.  This
2488         causes determineVCSRoot() in VCSUtils.pm to return
2489         ".git-rewrite/t", which causes that path to be prepended to all
2490         ChangeLog paths, which results in an error like this:
2491
2492             error: pathspec '.git-rewrite/t/ChangeLog' did not match any file(s) known to git.
2493             Died at WebKitTools/Scripts/resolve-ChangeLogs line 376.
2494
2495         The correct way to fix this is not to try to find the repository
2496         root when invoked by git-filter-branch.
2497
2498         * Scripts/resolve-ChangeLogs: If isInGitFilterBranch() is true,
2499         set $relativePath to '.' instead of calling
2500         chdirReturningRelativePath(determineVCSRoot()).
2501         (isInGitFilterBranch): Added.  Checks for the existence of the
2502         MAPPED_PREVIOUS_COMMIT environment variable.
2503
2504 2009-09-01  Xan Lopez  <xlopez@igalia.com>
2505
2506         Reviewed by Gustavo Noronha.
2507
2508         Add support for Fedora distros in the http tests
2509         https://bugs.webkit.org/show_bug.cgi?id=28263
2510
2511         Add detection code for Fedora distribution, and use the proper
2512         httpd conf file when needed.
2513
2514         * Scripts/run-webkit-httpd:
2515         * Scripts/run-webkit-tests:
2516         * Scripts/webkitdirs.pm:
2517
2518 2009-09-01  Jan Michael Alonzo  <jmalonzo@webkit.org>
2519
2520         Reviewed by Eric Seidel.
2521
2522         [Gtk] DRT needs implementation of overridePreference
2523         https://bugs.webkit.org/show_bug.cgi?id=28830
2524
2525         Implement overridePreference.
2526
2527         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2528         (resetDefaultsToConsistentValues):
2529         (setDefaultsToConsistentStateValuesForTesting):
2530         (runTest):
2531         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2532         (toWebSettingKey):
2533         (LayoutTestController::overridePreference):
2534
2535 2009-09-01  Joseph Pecoraro  <joepeck@webkit.org>
2536
2537         <http://webkit.org/b/28623> svn-[un]apply should change directories to the repository root before [un]applying
2538
2539         Reviewed by Eric Seidel.
2540
2541         Jump back and forth between the repository root directory (to apply) and the
2542         directory the script was run from (to find the patch).
2543
2544         * Scripts/svn-apply:
2545         * Scripts/svn-unapply:
2546
2547 2009-08-31  Adam Roben  <aroben@apple.com>
2548
2549         Fall back to a Release version of Safari if a Debug one doesn't exist
2550
2551         <http://webkit.org/b/28849>
2552
2553         Reviewed by Sam Weinig.
2554
2555         * Scripts/webkitdirs.pm:
2556         (safariPath): If the user is working with a Debug build, but there's
2557         no Debug version of Safari present, fall back to using a Release
2558         version of Safari.
2559
2560 2009-08-31  Adam Roben  <aroben@apple.com>
2561
2562         Make safariPath() work for Debug builds of Safari on Windows
2563
2564         <http://webkit.org/b/28849>
2565
2566         Reviewed by Sam Weinig.
2567
2568         * Scripts/webkitdirs.pm:
2569         (safariPath): If the user is working with a Debug build, add the
2570         _debug suffix to Safari.exe.
2571
2572 2009-08-28  Eric Seidel  <eric@webkit.org>
2573
2574         Reviewed by Adam Barth.
2575
2576         commit-queue needs a master process
2577         https://bugs.webkit.org/show_bug.cgi?id=28040
2578
2579         Add a bugzilla-tool commit-queue command
2580         Keeps per-bug logs, but doesn't yet upload them anywhere.
2581
2582         * Scripts/bugzilla-tool: Add LandPatchesFromCommitQueue to handle 'commit-queue'
2583         * Scripts/modules/buildbot.py: remove noisy log message
2584         * Scripts/modules/logging.py: add a 'tee()' call for splitting outputs in python
2585
2586 2009-08-28  Jan Michael Alonzo  <jmalonzo@webkit.org>
2587
2588         Reviewed by Gustavo Noronha.
2589
2590         [GTK] Geolocation needs permission API before being enabled by default
2591
2592         Build the Gtk port with geolocation enabled. This option is only
2593         enabled for the buildbot. The autotools option will be enabled by
2594         default once the permissions API is implemented.
2595
2596         * Scripts/build-webkit:
2597
2598 2009-08-26  Cameron McCormack  <cam@mcc.id.au>
2599
2600         Reviewed by David Kilzer.
2601
2602         Make prepare-ChangeLog notice property changes
2603         https://bugs.webkit.org/show_bug.cgi?id=28675
2604
2605         Make the generated ChangeLog entry include a short description of
2606         property changes if there were such changes.  Also make
2607         prepare-ChangeLog not bail if the only changes are property changes.
2608
2609         * Scripts/prepare-ChangeLog:
2610
2611 2009-08-26  Adam Barth  <abarth@webkit.org>
2612
2613         Reviewed by Oliver Hunt.
2614
2615         Don't let local files access web URLs
2616         https://bugs.webkit.org/show_bug.cgi?id=28480
2617
2618         A bunch of our LayoutTests rely on our old behavior, so we explicitly
2619         grant local files universal access during testing.  Mainly, these tests
2620         involve making XMLHttpRequests for data URLs.
2621
2622         * DumpRenderTree/mac/DumpRenderTree.mm:
2623         (resetDefaultsToConsistentValues):
2624         * DumpRenderTree/qt/DumpRenderTree.cpp:
2625         (WebCore::WebPage::WebPage):
2626         * DumpRenderTree/win/DumpRenderTree.cpp:
2627         (resetDefaultsToConsistentValues):
2628
2629 2009-08-26  John Gregg  <johnnyg@google.com>
2630
2631         Reviewed by David Levin.
2632
2633         Minor style correction and include fix for notifications
2634         https://bugs.webkit.org/show_bug.cgi?id=28745
2635
2636         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2637           change to correct EnumStyle
2638         (DRTDesktopNotificationPresenter::checkNotificationPermission):
2639
2640 2009-08-26  David Levin  <levin@chromium.org>
2641
2642         Reviewed by Alexey Proskuryakov.
2643
2644         XMLHttpRequest.withCredentials=false shouldn't save cookies.
2645         https://bugs.webkit.org/show_bug.cgi?id=28743
2646
2647         Added the support to the layout test controller on OSX and
2648         Windows (for CFNETWORK) to allow for changing the accept cookie
2649         policy.
2650
2651         * DumpRenderTree/LayoutTestController.cpp:
2652         (LayoutTestController::LayoutTestController): Added a bool
2653         to track the state of accepting cookies.
2654         (setAlwaysAcceptCookiesCallback): Standard wrapper method
2655         to go from js to a C++ method.
2656         (LayoutTestController::staticFunctions): Added the
2657         setAlwaysAcceptCookies method to the js layoutTestController.
2658         * DumpRenderTree/LayoutTestController.h:
2659         (LayoutTestController::alwaysAcceptCookies): Returns the value.
2660         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2661         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
2662         * DumpRenderTree/mac/DumpRenderTree.mm:
2663         (resetDefaultsToConsistentValues): Reset the accept cookie to
2664         its default.
2665         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2666         (LayoutTestController::setAlwaysAcceptCookies): Does the work for
2667         OSX to change the cookie accept policy.
2668         * DumpRenderTree/win/DumpRenderTree.cpp:
2669         (setAlwaysAcceptCookies): Method to handle all the calls necessary
2670         to change the accept cookie policy on Windows.
2671         (resetDefaultsToConsistentValues): Reset the accept cookie to
2672         its default.
2673         * DumpRenderTree/win/DumpRenderTreeWin.h:
2674         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2675         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
2676         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2677         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
2678
2679 2009-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2680
2681         Unreviewed.
2682
2683         Remove accidentally left in clobber option.
2684         https://bugs.webkit.org/show_bug.cgi?id=28400
2685
2686         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed clobber option.
2687
2688 2009-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2689
2690         Reviewed by Mark Rowe.
2691
2692         Add canary-style Chromium WebKit build slave to the waterfall.
2693         https://bugs.webkit.org/show_bug.cgi?id=28400
2694
2695         * BuildSlaveSupport/build.webkit.org-config/config.json: Added one Chromium/Windows slave
2696         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added support for Chromium slave commands.
2697
2698 2009-08-25  Cameron McCormack  <cam@mcc.id.au>
2699
2700         Reviewed by Darin Adler.
2701
2702         make-script-test-wrappers should be executable
2703         https://bugs.webkit.org/show_bug.cgi?id=28669
2704
2705         Make make-script-test-wrappers and update-sources-list.py both be
2706         executable.
2707
2708         * Scripts/update-sources-list.py:
2709         * Scripts/make-script-test-wrappers:
2710
2711 2009-08-25  Brent Fulgham  <bfulgham@webkit.org>
2712
2713         Build fix
2714
2715         Revise Debug_Cairo targets to point inherit from the 
2716         debug_wincairo.vsprops property sheet so that they link
2717         against the proper libraries in Debug build.
2718
2719         * DumpRenderTree/win/DumpRenderTree.vcproj:
2720         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2721         * WinLauncher/WinLauncher.vcproj:
2722
2723 2009-08-25  David Levin  <levin@chromium.org>
2724
2725         Reviewed by Adam Roben.
2726
2727         PLATFORM(CFNETWORK) should be USE(CFNETWORK).
2728         https://bugs.webkit.org/show_bug.cgi?id=28713
2729
2730         * DumpRenderTree/win/DumpRenderTree.cpp:
2731         (main):
2732
2733 2009-08-25  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2734
2735         Reviewed by Ariya Hidayat.
2736
2737         [Qt/Mac] Use CONFIG+=build_all only when building libraries
2738
2739         If no configuration is specified when building WebKit we pass the
2740         debug_and_release option to QMake which results in Makefiles for
2741         both configurations being generated.
2742
2743         Previously we built both of these configurations by default, for
2744         all targets (both the QtWebKit framework/dyldlib and the various
2745         executables such as QtLauncher and tests). This makes sense for
2746         the libraries, which get the _debug suffix and can be loaded on
2747         demand by setting the DYLD_IMAGE_SUFFIX, but for executables we
2748         ended up building the same executable twice.
2749
2750         We now only build one instance of each executable, and since this
2751         is a developer build we build the debug-version. Passing either
2752         --debug or --release to build-webkit will override this, and
2753         even in the default case the release version can still be built
2754         by running 'make release' in the the build directory of each
2755         target.
2756
2757         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2758         * Scripts/webkitdirs.pm:
2759
2760 2009-08-24  Hironori Bono  <hbono@chromium.org>
2761
2762         Reviewed by Adam Barth.
2763
2764         Fix Bug 27827 "[Chromium] Functions Keys don't work in google spreadsheet".
2765         <https://bugs.webkit.org/show_bug.cgi?id=27827>.
2766
2767         Because of the lack of mappings from GDK key-codes to WebKit key-codes,
2768         Chromium cannot send valid key-codes to JavaScript when a user types
2769         function keys. This change just copies the mappings from 'KeyEventGtk.cpp'.
2770
2771         To write layout tests for this issue, added mappings from function-key
2772         names to platform-specific key-codes to EventSendingController objects
2773         so that eventSender.keyDown() can send function-key events without using
2774         platform-specific key codes. (Unfortunately, this eventSender.keyDown() change
2775         is only for Mac. So this change adds this new test to Skipped tests for other
2776         platforms to prevent this change from crashing the build trees.)
2777
2778         * DumpRenderTree/mac/EventSendingController.mm:
2779         (-[EventSendingController keyDown:withModifiers:]):
2780
2781 2009-08-23  Jan Michael Alonzo  <jmalonzo@webkit.org>
2782
2783         Reviewed by Xan Lopez.
2784
2785         [Gtk] API for disabling local file access to web URLs
2786         https://bugs.webkit.org/show_bug.cgi?id=28663
2787
2788         Enable this setting for DRT.
2789
2790         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2791         (resetWebViewToConsistentStateBeforeTesting):
2792
2793 2009-08-22  Adam Barth  <abarth@webkit.org>
2794
2795         Revert 47684.  We're going to do this later once clients have had a
2796         chance to opt into the setting they like.
2797
2798         * DumpRenderTree/mac/DumpRenderTree.mm:
2799         (resetDefaultsToConsistentValues):
2800         * DumpRenderTree/qt/DumpRenderTree.cpp:
2801         (WebCore::WebPage::WebPage):
2802         * DumpRenderTree/win/DumpRenderTree.cpp:
2803         (resetDefaultsToConsistentValues):
2804
2805 2009-08-22  Adam Barth  <abarth@webkit.org>
2806
2807         Reviewed by Eric Seidel.
2808
2809         Don't let local files access web URLs
2810         https://bugs.webkit.org/show_bug.cgi?id=28480
2811
2812         A bunch of our LayoutTests rely on our old behavior, so we explicitly
2813         grant local files universal access during testing.  Mainly, these tests
2814         involve making XMLHttpRequests for data URLs.
2815
2816         * DumpRenderTree/mac/DumpRenderTree.mm:
2817         (resetDefaultsToConsistentValues):
2818         * DumpRenderTree/qt/DumpRenderTree.cpp:
2819         (WebCore::WebPage::WebPage):
2820         * DumpRenderTree/win/DumpRenderTree.cpp:
2821         (resetDefaultsToConsistentValues):
2822
2823 2009-08-22  Mark Rowe  <mrowe@apple.com>
2824
2825         Rubber-stamped by Anders Carlsson.
2826
2827         Bring signed updates to the Mac nightly builds.
2828
2829         * WebKitLauncher/Info.plist:
2830         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2831         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
2832         (initializeSparkle):
2833         * WebKitLauncher/nightly.webkit.org.public.pem: Added.
2834
2835 2009-08-21  Jan Michael Alonzo  <jmalonzo@webkit.org>
2836
2837         Rubberstamped by Simon Fraser.
2838
2839         Remove GNOME keyring support in build-webkit. This dependency's
2840         already been removed in the Gtk port.
2841
2842         * Scripts/build-webkit:
2843
2844 2009-08-20  Brian Weinstein  <bweinstein@apple.com>
2845
2846         Reviewed by Adam Roben.
2847         Based on original patch by Stephanie Lewis.
2848
2849         Added support of the Windows malloc history format to parse-malloc history, so we can
2850         read and parse it.
2851
2852         * Scripts/parse-malloc-history:
2853
2854 2009-08-20  Chris Fleizach  <cfleizach@apple.com>
2855
2856         Reviewed by Darin Adler.
2857
2858         Enable various "grouping" ARIA roles
2859         https://bugs.webkit.org/show_bug.cgi?id=28486
2860
2861         Expose the ability to retrieve the subrole through accessibility for DRT.
2862
2863         * DumpRenderTree/AccessibilityUIElement.cpp:
2864         * DumpRenderTree/AccessibilityUIElement.h:
2865         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2866         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2867         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2868
2869 2009-08-20  Joseph Pecoraro  <joepeck@webkit.org>
2870
2871         Unreviewed.
2872
2873         Added myself as a committer.
2874
2875         * Scripts/modules/committers.py:
2876
2877 2009-08-20  Xan Lopez  <xlopez@igalia.com>
2878
2879         Reviewed by Gustavo Noronha.
2880
2881         Fix memory leaks.
2882
2883         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2884         (LayoutTestController::whiteListAccessFromOrigin):
2885         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2886         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2887
2888 2009-08-20  Eric Seidel  <eric@webkit.org>
2889
2890         Reviewed by Adam Barth.
2891
2892         bugzilla-tool post-diff can post partial diffs from SVN checkouts.
2893         https://bugs.webkit.org/show_bug.cgi?id=28445
2894
2895         Pass the checkout root as the cwd.  Also wrote a test to ensure this.
2896
2897         * Scripts/modules/scm.py:
2898         * Scripts/modules/scm_unittest.py:
2899
2900 2009-08-20  Mark Rowe  <mrowe@apple.com>
2901
2902         Reviewed by Adele Peterson.
2903
2904         Don't leak the JSStringRef returned by AccessibilityUIElement::attributeValue.
2905
2906         * DumpRenderTree/AccessibilityUIElement.cpp:
2907         (attributeValueCallback):
2908
2909 2009-08-20  Ariya Hidayat  <ariya.hidayat@nokia.com>
2910
2911         Unreviewed, build fix.
2912
2913         [Qt] The template-based qMax() compares two qreals.
2914
2915         * DumpRenderTree/qt/ImageDiff.cpp:
2916         (main):
2917
2918 2009-08-20  David Levin  <levin@chromium.org>
2919
2920         Reviewed by David Kilzer.
2921
2922         bugzilla-tool patch retrieval should handle 302 redirects.
2923         https://bugs.webkit.org/show_bug.cgi?id=28485
2924
2925         * Scripts/modules/scm.py: Pass the --location parameter to curl
2926         so that 302's are followed.
2927
2928 2009-08-20  Aaron Boodman  <aa@chromium.org>
2929
2930         One more speculative build for gtk.
2931
2932         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2933
2934 2009-08-20  Aaron Boodman  <aa@chromium.org>
2935
2936         Speculative build for gtk.
2937
2938         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2939         (LayoutTestController::whiteListAccessFromOrigin):
2940
2941 2009-08-20  Mark Rowe  <mrowe@apple.com>
2942
2943         Ignore some leaks that are known to originate from ImageIO.
2944
2945         * Scripts/run-webkit-tests:
2946
2947 2009-08-20  Aaron Boodman  <aa@chromium.org>
2948
2949         With David Levin.
2950
2951         Speculative build fix for qt.
2952
2953         * DumpRenderTree/qt/jsobjects.cpp:
2954         (LayoutTestController::whiteListAccessFromOrigin):
2955         * DumpRenderTree/qt/jsobjects.h:
2956
2957 2009-08-19  Mark Rowe  <mrowe@apple.com>
2958
2959         Reviewed by Dan Bernstein.
2960
2961         Fix <http://webkit.org/b/28484> Plug-in-related leaks seen on the build bot
2962
2963         Update check-for-global-initializers to accommodate the new uses of RefCountedLeakCounter in WebKit.
2964
2965         * Scripts/check-for-global-initializers:
2966
2967 2009-08-19  Aaron Boodman  <aa@chromium.org>
2968
2969         Reviewed by David Levin.
2970
2971         https://bugs.webkit.org/show_bug.cgi?id=24853: Provide a way for WebKit clients to
2972         specify a more granular policy for cross-origin XHR access.
2973
2974         * DumpRenderTree/LayoutTestController.cpp: Expose whiteListAccessFromOrigin() to layout tests.
2975         (whiteListAccessFromOriginCallback): Ditto.
2976         (LayoutTestController::staticFunctions): Ditto.
2977         * DumpRenderTree/LayoutTestController.h: Ditto.
2978         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Ditto.
2979         (LayoutTestController::whiteListAccessToOrigin): Ditto.
2980         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Ditto.
2981         (LayoutTestController::whiteListAccessFromOrigin): Ditto.
2982         * DumpRenderTree/qt/jsobjects.cpp: Ditto.
2983         (LayoutTestController::whiteListAccessFromOrigin): Ditto.
2984         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Stub out whiteListAccessFromOrigin().
2985         (LayoutTestController::whiteListAccessFromOrigin): Ditto.
2986         * DumpRenderTree/gtk/DumpRenderTree.cpp: Reset origin access lists before each test.
2987         (resetWebViewToConsistentStateBeforeTesting): Ditto.
2988         * DumpRenderTree/mac/DumpRenderTree.mm: Ditto.
2989         (resetWebViewToConsistentStateBeforeTesting): Ditto.
2990         * DumpRenderTree/qt/DumpRenderTree.cpp: Ditto.
2991         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Ditto.
2992
2993 2009-08-19  Mark Rowe  <mrowe@apple.com>
2994
2995         Rubber-stamped by Dan Bernstein.
2996
2997         Ignore some leaks that are known to originate from QTKit.
2998
2999         * Scripts/run-webkit-tests:
3000
3001 2009-08-19  Eric Seidel  <eric@webkit.org>
3002
3003         Reviewed by Adam Barth.
3004
3005         commit-queue/bugzilla-tool can get wedged if git is mid-rebase
3006         https://bugs.webkit.org/show_bug.cgi?id=28436
3007
3008         Make clean_working_directory cancel rebases too (even though that's a bit of a hack).
3009         This code will only ever be run when --force-clean is passed.
3010
3011         I also added a new unit test to make sure this code actually works. :)
3012
3013         * Scripts/modules/scm.py:
3014         * Scripts/modules/scm_unittest.py:
3015
3016 2009-08-19  Eric Seidel  <eric@webkit.org>
3017
3018         Reviewed by David Levin.
3019
3020         WebKit needs a changelogs.py to hold changelog-related code
3021         https://bugs.webkit.org/show_bug.cgi?id=28477
3022
3023         This is moving code and adding tests.  There was only one functional
3024         change (which was removing a trailing newline from the last_entry() result).
3025
3026         * Scripts/bugzilla-tool:
3027         * Scripts/modules/changelogs.py: Added.
3028         * Scripts/modules/changelogs_unittest.py: Added.
3029         * Scripts/run-webkit-unittests:
3030
3031 2009-08-20  Eric Seidel  <eric@webkit.org>
3032
3033         Reviewed by Adam Barth.
3034
3035         bugzilla-tool needs a way to ask build.webkit.org if the bots are passing
3036         https://bugs.webkit.org/show_bug.cgi?id=28222
3037
3038         Basic support for now.  This has been in testing for 24 hours now and worked great!
3039
3040         * Scripts/bugzilla-tool:
3041         * Scripts/modules/buildbot.py: Added.
3042         * Scripts/modules/buildbot_unittest.py: Added.
3043         * Scripts/run-webkit-unittests:
3044
3045 2009-08-19  Jan Michael Alonzo  <jmalonzo@webkit.org>
3046
3047         Reviewed by Gustavo Noronha.
3048
3049         [Gtk] Bump waitToDumpWatchdog interval to 15 seconds to match the
3050         default timeout used by run-webkit-tests. Mac and Win ports were
3051         recently bumped in http://trac.webkit.org/changeset/r47465.
3052
3053         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3054         (LayoutTestController::setWaitToDump):
3055
3056 2009-08-19  David D. Kilzer  <ddkilzer@webkit.org>
3057
3058         DumpRenderTreeSupport.pm: provide pre-generated swig source for Tiger
3059
3060         Reviewed by Mark Rowe.
3061
3062         Provide pre-generated swig source files for Tiger so it may
3063         benefit from the faster run-webkit-tests.
3064
3065         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm:
3066         Generated by swig.
3067         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c: Added.
3068         Generated by swig.
3069         (swig_type_info::SWIG_TypeNameComp):
3070         (swig_type_info::SWIG_TypeEquiv):
3071         (swig_type_info::SWIG_TypeRegisterTL):
3072         (swig_type_info::SWIG_TypeCheck):
3073         (swig_type_info::SWIG_TypeCast):
3074         (swig_type_info::SWIG_TypeDynamicCast):
3075         (swig_type_info::SWIG_TypeName):
3076         (swig_type_info::SWIG_TypePrettyName):
3077         (swig_type_info::SWIG_TypeQueryTL):
3078         (swig_type_info::SWIG_TypeClientDataTL):
3079         (swig_type_info::SWIG_PackData):
3080         (swig_type_info::SWIG_UnpackData):
3081         (swig_type_info::SWIG_PropagateClientDataTL):
3082         (swig_type_info::SWIG_PackVoidPtr):
3083         (swig_type_info::SWIG_UnpackVoidPtr):
3084         (swig_type_info::SWIG_PackDataName):
3085         (swig_type_info::SWIG_UnpackDataName):
3086         * DumpRenderTree/mac/PerlSupport/Makefile: Updated to build on
3087         Tiger using pre-generated files.
3088
3089 2009-08-18  Shinichiro Hamaji  <hamaji@chromium.org>
3090
3091         Reviewed by David Kilzer.
3092
3093         run-webkit-tests hangs when WebCore tries to log too much
3094         https://bugs.webkit.org/show_bug.cgi?id=15743
3095
3096         Read stdout and stderr in parallel.
3097
3098         * Scripts/run-webkit-tests:
3099
3100 2009-08-18  Mark Rowe  <mrowe@apple.com>
3101
3102         Rubber-stamped by Oliver Hunt.
3103
3104         Add a new build configuration that checks for leaks during the layout tests,
3105         and hook a new machine up to it.
3106
3107         * BuildSlaveSupport/build.webkit.org-config/config.json:
3108         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3109
3110 2009-08-18  Aaron Boodman  <aa@chromium.org>
3111
3112         Reviewed by Maciej Stachowiak.
3113
3114         https://bugs.webkit.org/show_bug.cgi?id=28412: Leak of WebCore::XMLHttpRequest object during layout tests.
3115
3116         No new tests: Already covered by existing tests.
3117
3118         * Scripts/check-for-global-initializers: Allow global initialization of WTF::RefCountedLeakCounter for XMLHttpRequest.
3119
3120 2009-08-18  Mark Rowe  <mrowe@apple.com>
3121
3122         Rubber-stamped by Geoff Garen.
3123
3124         Bump waitToDumpWatchdogInterval to 15 seconds to match the time-out used by run-webkit-tests.
3125
3126         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3127         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3128
3129 2009-08-18  Brian Weinstein  <bweinstein@apple.com>
3130
3131         Rubber-stamped by Adam Roben.
3132
3133         Changed use of CComBSTR in exceededDatabaseQuota to BSTRs, and free them,
3134         and removed include to fix building on VC++ Express.
3135
3136         * DumpRenderTree/win/UIDelegate.cpp:
3137         (UIDelegate::exceededDatabaseQuota):
3138
3139 2009-08-18  Brian Weinstein  <bweinstein@apple.com>
3140
3141         Reviewed by Oliver Hunt.
3142
3143         Fix of <https://bugs.webkit.org/show_bug.cgi?id=28326> DRT on Windows doesn't support 
3144         LayoutTestController::setQuota or print a callback on UIDelegate::exceededDatabaseQuota.
3145         
3146         Implemenent setDatabaseQuota and added a new function to the IWebDatabaseManager interface.
3147         Also added a console output on UIDelegate::exceededDatabaseQuota to match the mac.
3148
3149         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3150         (LayoutTestController::setDatabaseQuota):
3151         * DumpRenderTree/win/UIDelegate.cpp:
3152         (UIDelegate::exceededDatabaseQuota):
3153
3154 2009-08-18  Peter Kasting  <pkasting@google.com>
3155
3156         Reviewed by Eric Seidel.
3157
3158         https://bugs.webkit.org/show_bug.cgi?id=28415
3159         Set svn:eol-style CRLF on all .sln and .vcproj files that don't already
3160         have it.
3161
3162         * record-memory-win/record-memory-win.vcproj:
3163         * WinLauncher/WinLauncher.vcproj:
3164         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3165         * DumpRenderTree/win/ImageDiff.vcproj:
3166         * FindSafari/FindSafari.vcproj:
3167
3168 2009-08-18  Drew Wilson  <atwilson@google.com>
3169
3170         Reviewed by Eric Seidel.
3171
3172         Need to extend DumpRenderTree to expose number of worker threads
3173         https://bugs.webkit.org/show_bug.cgi?id=28292
3174
3175         Added layoutTestController.workerThreadCount, and implementations on various platforms that call into WebKit.
3176
3177         * DumpRenderTree/LayoutTestController.cpp:
3178         (getWorkerThreadCountCallback):
3179         (LayoutTestController::staticValues):
3180         * DumpRenderTree/LayoutTestController.h:
3181         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3182         (LayoutTestController::workerThreadCount):
3183         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3184         (LayoutTestController::workerThreadCount):
3185         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3186         (LayoutTestController::workerThreadCount):
3187         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3188         (LayoutTestController::workerThreadCount):
3189
3190 2009-08-18  Xan Lopez  <xlopez@igalia.com>
3191
3192         Reviewed by Jan Alonzo.
3193
3194         Initialize x and y in the GtkAllocation structure to shut up
3195         valgrind.
3196
3197         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3198         (runTest):
3199
3200 2009-08-17  Shinichiro Hamaji  <hamaji@chromium.org>
3201
3202         Reviewed by Darin Adler.
3203
3204         Some HTMLs are modified by make-script-test-wrappers
3205         https://bugs.webkit.org/show_bug.cgi?id=28213
3206
3207         Add fast/js/const.js and fast/canvas/canvas-2d-imageData-create-nonfinite.js into
3208         the exclude list, modified fast/dom/Geolocation/resources/TEMPLATE.html, and
3209         re-generated wml/* and Geolocation/* .
3210
3211         * Scripts/make-script-test-wrappers:
3212
3213 2009-08-17  Shinichiro Hamaji  <hamaji@chromium.org>
3214
3215         Reviewed by Eric Seidel.
3216
3217         -webkit-box-orient:horizontal doesn't work on <button> tag
3218         https://bugs.webkit.org/show_bug.cgi?id=34445
3219
3220         Make a flexible button's anonymous child flexible and pass the
3221         parent's box-orient to the anonymous child.
3222
3223         Also, added a renderName for anonymous flexible boxes.
3224
3225         * Scripts/make-script-test-wrappers:
3226
3227 2009-08-17  Eric Seidel  <eric@webkit.org>
3228
3229         Reviewed by Darin Adler.
3230
3231         Can no longer --reset-results of a layout test directory
3232         https://bugs.webkit.org/show_bug.cgi?id=28336
3233
3234         --reset-results and --exit-after-n-failures are incompatible.
3235
3236         * Scripts/run-webkit-tests:
3237
3238 2009-08-17  David Kilzer  <ddkilzer@apple.com>
3239
3240         <http://webkit.org/b/26920> bugzilla-tool dumps too much junk the the commit comment from git
3241
3242         Reviewed by Adam Roben.
3243
3244         New commit message:
3245             Committed r12345: <http://trac.webkit.org/changeset/12345>
3246
3247         * Scripts/bugzilla-tool:
3248         (bug_comment_from_commit_text): Print out a compact,
3249         standardized commit message for both git and svn.
3250
3251 2009-08-17  Peter Kasting  <pkasting@google.com>
3252
3253         Reviewed by Steve Falkenburg.
3254
3255         https://bugs.webkit.org/show_bug.cgi?id=27323
3256         Only add Cygwin to the path when it isn't already there.  This avoids
3257         causing problems for people who purposefully have non-Cygwin versions of
3258         executables like svn in front of the Cygwin ones in their paths.
3259
3260         * DumpRenderTree/win/DumpRenderTree.vcproj:
3261         * DumpRenderTree/win/ImageDiff.vcproj:
3262         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3263
3264 2009-08-17  David Kilzer  <ddkilzer@apple.com>
3265
3266         <http://webkit.org/b/28393> check-webkit-style: add check for use of std::max()/std::min() instead of MAX()/MIN()
3267
3268         Reviewed by David Levin.
3269
3270         * Scripts/modules/cpp_style.py:
3271         (_ERROR_CATEGORIES): Added 'runtime/max_min_macros'.
3272         (check_max_min_macros): Added.  Returns level 4 error when MAX()
3273         and MIN() macros are used in header files and C++ source files.
3274         (check_style): Added call to check_max_min_macros().
3275         * Scripts/modules/cpp_style_unittest.py: Added unit tests.
3276         (test_max_macro): Added.
3277         (test_min_macro): Added.
3278
3279 2009-08-13  Mike Fenton  <mike.fenton@torchmobile.com>
3280
3281         Reviewed by Eric Seidel.
3282
3283         Move adjustLineToPixelBoundaries overlapping function to GraphicsContext.cpp
3284         and remove from GraphicsContextCairo.cpp and GraphicsContextQt.cpp.
3285
3286         https://bugs.webkit.org/show_bug.cgi?id=28268
3287
3288         * platform/graphics/GraphicsContext.cpp:
3289         (WebCore::GraphicsContext::adjustLineToPixelBoundaries):
3290         * platform/graphics/GraphicsContext.h:
3291         * platform/graphics/cairo/GraphicsContextCairo.cpp:
3292         * platform/graphics/qt/GraphicsContextQt.cpp:
3293
3294 2009-08-10  Mike Fenton  <mike.fenton@torchmobile.com>
3295
3296         Reviewed by Adam Treat.
3297
3298         Style fixes for DumpRenderTree/qt/jsobjects.cpp based on cpp_style.py and
3299         WebKit style guide.
3300
3301         https://bugs.webkit.org/show_bug.cgi?id=28161
3302
3303         * DumpRenderTree/qt/jsobjects.cpp:
3304         (findFrameNamed):
3305         (LoadItem::invoke):
3306         (LayoutTestController::provisionalLoad):
3307         (LayoutTestController::timerEvent):
3308         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3309         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3310         (LayoutTestController::numberOfActiveAnimations):
3311         (EventSender::keyDown):
3312         (EventSender::frameUnderMouse):
3313         (TextInputController::doCommand):
3314
3315 2009-08-16  David Kilzer  <ddkilzer@apple.com>
3316
3317         <http://webkit.org/b/28370> check-webkit-style: add check for 'using std::foo;' statements
3318
3319         Reviewed by David Levin.
3320
3321         In <http://webkit.org/b/28355#c1>, it was noted that new source
3322         files use 'using namespace std;' instead of individual
3323         'using std::foo;' statements.  This adds a level 4 check for
3324         such statements.
3325
3326         * Scripts/modules/cpp_style.py:
3327         (_ERROR_CATEGORIES): Added 'build/using_std'.
3328         (check_using_std): Added.
3329         (check_style): Added call to check_using_std().
3330         * Scripts/modules/cpp_style_unittest.py:
3331         (WebKitStyleTest.test_using_std): Added unit test.
3332
3333 2009-08-16  David Kilzer  <ddkilzer@apple.com>
3334
3335         Backed out r47343 which was mistakenly committed
3336
3337         * Scripts/bugzilla-tool:
3338         * Scripts/modules/scm.py:
3339
3340 2009-08-16  David Kilzer  <ddkilzer@apple.com>
3341
3342         <http://webkit.org/b/28367> bugzilla.py: replace ScriptError class with BugzillaError class
3343
3344         Reviewed by David Levin.
3345
3346         The ScriptError class doesn't exist in bugzilla.py, so any
3347         errors print error messages about ScriptError instead of the
3348         actual error:
3349
3350             NameError: global name 'ScriptError' is not defined
3351
3352         * Scripts/modules/bugzilla.py:
3353         (BugzillaError): Added class.  Modeled after ScriptError class
3354         in scm.py.
3355         (Bugzilla.authenticate): Changed to use BugzillaError instead of
3356         ScriptError.
3357         (Bugzilla._check_create_bug_response): Ditto.
3358
3359 2009-08-14  Adam Bergkvist  <adam.bergkvist@ericsson.com>
3360
3361         Reviewed by Sam Weinig.
3362
3363         Added EventSource to the build script (default on).
3364         https://bugs.webkit.org/show_bug.cgi?id=14997 
3365
3366         * Scripts/build-webkit:
3367
3368 2009-08-15  Ryosuke Niwa  <rniwa@webkit.org>
3369
3370         Unreviewed.
3371
3372         Add myself to list of committers.
3373
3374         * Scripts/modules/committers.py:
3375
3376 2009-08-15  Jon Honeycutt  <jhoneycutt@apple.com>
3377
3378         Fix layout test failures after r47312.
3379
3380         Reviewed by Cameron Zwarich.
3381
3382         * DumpRenderTree/AccessibilityController.h:
3383         Replaced logFocusEvents() with setLogFocusEvents(), which takes a
3384         boolean argument to turn logging of focus events on or off.
3385         Added a function to reset the AccessibilityController to a consistent
3386         state.
3387
3388         * DumpRenderTree/AccessibilityController.cpp:
3389         (logFocusEventsCallback):
3390         Call setLogFocusEvents() to enable logging.
3391         (AccessibilityController::resetToConsistentState):
3392         Call setLogFocusEvents() to disable logging.
3393
3394         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3395         (AccessibilityController::setLogFocusEvents):
3396         Update stub.
3397
3398         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3399         (AccessibilityController::setLogFocusEvents):
3400         Update stub.
3401
3402         * DumpRenderTree/mac/DumpRenderTree.mm:
3403         (resetWebViewToConsistentStateBeforeTesting):
3404         Call the FrameLoadDelegate's resetToConsistentState method.
3405
3406         * DumpRenderTree/mac/FrameLoadDelegate.h:
3407         Declare the resetToConsistentState method.
3408
3409         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3410         (-[FrameLoadDelegate resetToConsistentState]):
3411         Call the AccessibilityController's resetToConsistentState() function.
3412
3413         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3414         (AccessibilityController::~AccessibilityController):
3415         Turn off focus event logging when the controller is destroyed.
3416         (AccessibilityController::setLogFocusEvents):
3417         If the caller passes false, unhook the focus event, and clear
3418         m_focusEventHook.
3419
3420         * DumpRenderTree/win/DumpRenderTree.cpp:
3421         (resetWebViewToConsistentStateBeforeTesting):
3422         Call the FrameLoadDelegate's resetToConsistentState function.
3423
3424         * DumpRenderTree/win/FrameLoadDelegate.h:
3425         Declare the resetToConsistentState() function.
3426
3427         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3428         (FrameLoadDelegate::resetToConsistentState):
3429         Call the AccessibilityController's resetToConsistentState() function.
3430
3431
3432 2009-08-14  Jon Honeycutt  <jhoneycutt@apple.com>
3433
3434         Add a mechanism for logging MSAA focus events.
3435
3436         Part of <rdar://problem/6218721> No MSAA focus events fired for Webkit
3437         nightly (20866)
3438
3439         https://bugs.webkit.org/show_bug.cgi?id=20866
3440
3441         Reviewed by Oliver Hunt.
3442
3443         * DumpRenderTree/AccessibilityController.cpp:
3444         (logFocusEventsCallback):
3445         Call the AccessibilityController's logFocusEvents() function.
3446         (AccessibilityController::getJSClass):
3447         Add a "logFocusEvents" function to the AccessibilityController's JS
3448         class definition.
3449
3450         * DumpRenderTree/AccessibilityController.h:
3451         On Windows, include windows.h, and add a member variable to hold the
3452         handle to the event hook for focus events. Add a declaration for a
3453         function that enables logging of focus events.
3454
3455         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3456         (AccessibilityController::logFocusEvents):
3457         Stubbed.
3458
3459         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3460         (AccessibilityController::logFocusEvents):
3461         Stubbed.
3462
3463         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3464         (AccessibilityController::AccessibilityController):
3465         (AccessibilityController::~AccessibilityController):
3466         If we hooked the focus event, unhook it.
3467         (logFocusEventProc):
3468         When we receive a focus event, get the accessible object for the event,
3469         and log its name to stdout.
3470         (AccessibilityController::logFocusEvents):
3471         Setup the focus event hook to listen for events in the current process.
3472
3473 2009-08-14  Eric Seidel  <eric@webkit.org>
3474
3475         No review.  Fix 5-space indent to be 4-spaces.
3476
3477         * Scripts/bugzilla-tool:
3478
3479 2009-08-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3480
3481         Reviewed by Simon Hausmann.
3482
3483         [Qt] Public API to configure the storage path for HTML5 localStorage
3484         https://bugs.webkit.org/show_bug.cgi?id=28036
3485
3486         Turn on LocalStorage support for Qt DumpRenderTree since
3487         LocalStorage is now disabled by defult for QtWebkit.
3488
3489         * DumpRenderTree/qt/DumpRenderTree.cpp: 
3490         (WebCore::WebPage::WebPage):
3491
3492 2009-08-14  Xan Lopez  <xlopez@igalia.com>
3493
3494         Reviewed by Jan Alonzo.
3495
3496         Do not unref the main webview, it's owned by its parent
3497         container. Instead destroy the container, which should take care
3498         of everything (not terribly important since we exit right after
3499         that, but still).
3500
3501         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3502         (main):
3503
3504 2009-08-13  Eric Seidel  <eric@webkit.org>
3505
3506         No review, correcting obvious python error seen in the commit queue.
3507
3508         args can be a string or an array.  Assuming args is always an array results in
3509         double-spaced text in error logs.
3510
3511         * Scripts/bugzilla-tool:
3512
3513 2009-08-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3514
3515         Unreviewed build fix. Include stdio.h for using stdout, stderr,
3516         and fprintf.
3517
3518         * DumpRenderTree/LayoutTestController.cpp:
3519
3520 2009-08-13  Shinichiro Hamaji  <hamaji@chromium.org>
3521
3522         Reviewed by Eric Seidel.
3523
3524         rename make-js-test-wrappers to make-script-test-wrappers
3525         https://bugs.webkit.org/show_bug.cgi?id=28212
3526
3527         * Scripts/make-script-test-wrappers: Renamed from WebKitTools/Scripts/make-js-test-wrappers.
3528
3529 2009-08-13  Drew Wilson <atwilson@chromium.org>
3530
3531         Unreviewed.
3532
3533         Add myself to list of committers.
3534
3535         * Scripts/modules/committers.py:
3536
3537 2009-08-13  John Sullivan  <sullivan@apple.com>
3538
3539         Unreviewed.
3540
3541         Add myself to list of committers.
3542
3543         * Scripts/modules/committers.py:
3544
3545 2009-08-13  Eric Seidel  <eric@webkit.org>
3546
3547         Correct spelling error in file name.  No review.
3548
3549         * Scripts/modules/committers_unittest.py: Renamed from WebKitTools/Scripts/modules/commiters_unittest.py.
3550         * Scripts/run-webkit-unittests:
3551
3552 2009-08-13  Eric Seidel  <eric@webkit.org>
3553
3554         Reviewed by Simon Fraser.
3555
3556         REGRESSION(r47175): error running run-webkit-tests
3557         https://bugs.webkit.org/show_bug.cgi?id=28261
3558
3559         Fix "Use of uninitialized value in concatenation (.) or string at
3560         WebKitTools/Scripts/run-webkit-tests line 191." by setting
3561         $testsPerDumpTool to 1000 by default.
3562
3563         * Scripts/run-webkit-tests:
3564
3565 2009-08-13  Nate Chapin  <japhet@chromium.org>
3566
3567         Unreviewed.
3568
3569         Add myself to list of committers.
3570
3571         * Scripts/modules/committers.py:
3572
3573 2009-08-13  Brent Fulgham  <bfulgham@webkit.org>
3574
3575         Unreviewed.
3576
3577         Add 'Brent Fulgham' to the committers list.
3578
3579         * Scripts/modules/committers.py:
3580
3581 2009-08-13  Adam Langley  <agl@chromium.org>
3582
3583         Review not required.
3584
3585         * Scripts/modules/committers.py:
3586           Adding myself to this list because Eric told me to.
3587
3588 2009-08-13  Greg Bolsinga  <bolsinga@apple.com>
3589
3590         Unreviewed.
3591
3592         Add 'Greg Bolsinga' to the committers list.
3593
3594         * Scripts/modules/committers.py:
3595
3596 2009-08-13  Adam Roben  <aroben@apple.com>
3597
3598         Fix off-by-one result comparisons in media tests on Windows Debug
3599         builds
3600
3601         media/video-played.html seems always to time out in Windows Debug
3602         builds. A race condition between media/video-test.js's "hang" timer and
3603         DumpRenderTree's built-in "watchdog" timer was causing results for
3604         media/video-played.html to be printed twice, causing all future media
3605         tests to be compared to the previous test's results.
3606
3607         The fix is to make the watchdog timer got through the same code path
3608         as calling notifyDone manually, so that the results will only get
3609         printed once. A subsequent patch will remove video-test.js's hang
3610         timer entirely, since it is redundant.
3611
3612         Fixes <http://webkit.org/b/28265>.
3613
3614         Reviewed by Mark Rowe.
3615
3616         * DumpRenderTree/LayoutTestController.cpp:
3617         (LayoutTestController::waitToDumpWatchdogTimerFired): Added. Code came
3618         from Gtk/Mac/Win's watchdog timer handlers, but we now call
3619         notifyDone() instead of dump() so that a subsequent call to
3620         notifyDone() won't print the results out again.
3621
3622         * DumpRenderTree/LayoutTestController.h: Added
3623         waitToDumpWatchdogTimerFired.
3624
3625         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3626         (waitToDumpWatchdogFired):
3627         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3628         (waitUntilDoneWatchdogFired):
3629         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3630         (waitUntilDoneWatchdogFired):
3631         Changed to call waitToDumpWatchdogTimerFired.
3632
3633 2009-08-13  Eric Carlson  <eric.carlson@apple.com>
3634
3635         Unreviewed.
3636
3637         Added 'Eric Carlson' to the committers list.
3638
3639         * Scripts/modules/committers.py:
3640
3641 2009-08-13  Dirk Schulze  <krit@webkit.org>
3642
3643         Unreviewed.
3644         Added 'Dirk Schulze' to the committers list.
3645
3646         * Scripts/modules/committers.py:
3647
3648 2009-08-13  Adam Roben  <aroben@apple.com>
3649
3650         Enable running testapi in run-javascriptcore-tests on Windows
3651