take a QString as identifier in QWebFrame::addToJSWindowObject.
[WebKit-https.git] / WebKitTools / ChangeLog
1 2008-01-04  Lars Knoll  <lars@trolltech.com>
2
3         Reviewed by Simon.
4
5         take a QString as identifier in QWebFrame::addToJSWindowObject.
6
7         * DumpRenderTree/qt/DumpRenderTree.cpp:
8         (WebCore::DumpRenderTree::initJSObjects):
9
10 2008-01-04  Alp Toker  <alp@atoker.com>
11
12         GTK+ DRT build fix for breakage introduced in r29149.
13
14         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
15         (LayoutTestController::execCommand):
16
17 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
18
19         Reviewed by Darin.
20
21         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
22
23         Added layoutTestController.execCommand to access editor commands that are not available
24         via document.execCommand.
25
26         * DumpRenderTree/LayoutTestController.cpp:
27         (execCommandCallback):
28         (LayoutTestController::staticFunctions):
29         * DumpRenderTree/LayoutTestController.h:
30         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
31         (LayoutTestController::execCommand):
32         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
33         (LayoutTestController::queueLoad):
34         (LayoutTestController::execCommand):
35
36 2008-01-03  Alice Liu  <alice.liu@apple.com>
37
38         Reviewed by Darin, Mitz.
39
40         fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
41
42         the clickcount should not increase if the last click was at a different location.  it's a new click.
43
44         * DumpRenderTree/mac/DumpRenderTree.mm:
45         (runTest):
46         * DumpRenderTree/mac/EventSendingController.h:
47         * DumpRenderTree/mac/EventSendingController.mm:
48         (-[EventSendingController mouseDown]):
49         (-[EventSendingController mouseUp]):
50
51 2008-01-03  Darin Adler  <darin@apple.com>
52
53         Reviewed by Adam.
54
55         * Scripts/update-webkit: Make this work a little better for the people at Apple
56         who have a directory named Internal.
57
58 2008-01-03  Adam Roben  <aroben@apple.com>
59
60         Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default
61
62         Rubberstamped by Mark.
63
64         * Scripts/update-webkit-auxiliary-libs:
65
66 2008-01-03  Adam Roben  <aroben@apple.com>
67
68         Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
69
70         http://bugs.webkit.org/show_bug.cgi?id=15663
71
72         Added a fuzz factor into the Last-Modified comparison for downloading
73         WebKitAuxiliaryLibrary.zip.
74
75         The zip file is served from a set of mirrors who give Last-Modified
76         times that are off by 1-3 seconds from each other. This was causing
77         the build bots to redownload WebKitAuxiliaryLibrary for every build,
78         which would then cause all of WebCore to rebuild each time.
79
80         Reviewed by Mark.
81
82         * Scripts/update-webkit-auxiliary-libs: Check if the new zip file is
83         at least 30 seconds newer than the old one -- otherwise we assume that
84         the difference in time is due to the mirrors being slightly offset
85         from each other.
86         (sub lastModifiedToUnixTime): Added.
87
88 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
89
90         Windows build fix.
91
92         * DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
93
94 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
95
96         Reviewed by Lars.
97
98         Moved QWebPage::open to QWebFrame::load and added setHtml.
99         
100
101         * DumpRenderTree/qt/DumpRenderTree.cpp:
102         (WebCore::DumpRenderTree::open):
103
104 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
105
106         Reviewed by Lars.
107
108         Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.
109         
110
111         * DumpRenderTree/qt/DumpRenderTree.cpp:
112         (WebCore::DumpRenderTree::DumpRenderTree):
113
114 2008-01-02  Sam Weinig  <sam@webkit.org>
115
116         * Scripts/do-webcore-rename: Yet more renaming ideas.
117
118 2008-01-02  Darin Adler  <darin@apple.com>
119
120         * Scripts/do-webcore-rename: More renaming ideas. (Maciej, please merge yours with mine.)
121
122 2008-01-02  Alice Liu  <alice.liu@apple.com>
123
124         Reviewed by Sam Weinig.
125
126         fixing assertion hit with editing/selection/move-begin-end.html
127
128         * DumpRenderTree/ForwardingHeaders/wtf/ASCIICType.h: Added.
129         * DumpRenderTree/win/DumpRenderTree.vcproj:
130         * DumpRenderTree/win/EventSender.cpp:
131         (keyDownCallback):
132         using isupper will cause an assertion for inputs outside of ascii range. use isASCIIUpper instead.
133
134 2008-01-02  Darin Adler  <darin@apple.com>
135
136         * Scripts/do-webcore-rename: Some more name change plans.
137
138 2008-01-02  Alice Liu  <alice.liu@apple.com>
139
140         Reviewed by Maciej.
141
142         Added handling for page up and page down in EventSender
143
144         * DumpRenderTree/mac/EventSendingController.mm:
145         (-[EventSendingController keyDown:withModifiers:]):
146         * DumpRenderTree/win/EventSender.cpp:
147         (keyDownCallback):
148
149 2008-01-02  Alexey Proskuryakov  <ap@webkit.org>
150
151         Reviewed by Darin.
152
153         Fix fast/events/arrow-keys-on-body.html for real.
154
155         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Pass proper keyData for WM_KEYUP, too.
156
157 2008-01-02  Luca Bruno  <lethalman88@gmail.com>
158
159         Reviewed by Darin.
160
161         http://bugs.webkit.org/show_bug.cgi?id=16674
162         [GTK] run-launcher sets wrong LD_LIBRARY_PATH
163
164         * Scripts/run-launcher:
165
166 2007-12-31  Darin Adler  <darin@apple.com>
167
168         Suggested by Antti.
169
170         * Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until
171         we get it installed on the build bots.
172
173 2007-12-30  Eric Seidel  <eric@webkit.org>
174
175         Reviewed by Sam.
176
177         * Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
178
179 2007-12-29  Darin Adler  <darin@apple.com>
180
181         Reviewed by Oliver.
182
183         - fix http://bugs.webkit.org/show_bug.cgi?id=16663
184           leak bot shows createCStringFromNPVariant result leaking
185
186         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
187         (pluginInvoke): Added a missing free.
188
189 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
190
191         Reviewed by Alp Toker.
192
193         http://bugs.webkit.org/show_bug.cgi?id=16390
194         Use autotools or GNU make as the build system for the GTK port
195
196         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: include glib.h
197         * GNUmakefile.am: Added.
198
199 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
200
201         Reviewed by Oliver.
202
203         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
204
205         * DumpRenderTree/win/EventSender.cpp:
206         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
207         of 1, even though WebKit currently ignores it.
208
209 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
210
211         wx buildbot fix. Update libpng dl script to the latest version.
212
213         * wx/install-unix-extras:
214
215 2007-12-22  Antti Koivisto  <antti@apple.com>
216
217         Fix a typo.
218
219         * Scripts/webkitdirs.pm:
220
221 2007-12-21  Sam Weinig  <sam@webkit.org>
222
223         Reviewed by Mark Rowe.
224
225         - Disable the back/forward cache using the new WebPreferences API
226           instead of through the BackForwardList.  This makes us match what
227           we do on Windows.
228
229         * DumpRenderTree/mac/DumpRenderTree.mm:
230         (createWebViewAndOffscreenWindow):
231         (setDefaultsToConsistentValuesForTesting):
232
233 2007-12-21  Dan Bernstein  <mitz@apple.com>
234
235         Reviewed by Mark Rowe.
236
237         - disable the back/forward cache in Windows DumpRenderTree. It is
238           already disabled in Mac DumpRenderTree.
239
240         * DumpRenderTree/win/DumpRenderTree.cpp:
241         (initializePreferences):
242
243 2007-12-13  Antti Koivisto  <antti@apple.com>
244
245         Reviewed by Darin and Steve.
246         
247         - check for QuickTime SDK on Windows.
248         - build media support on Windows by default
249
250         * Scripts/build-webkit:
251         * Scripts/webkitdirs.pm:
252
253 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
254
255         Build script fix for buildbot.
256
257         * wx/build-wxwebkit:
258
259 2007-12-20  Eric Seidel  <eric@webkit.org>
260
261         Reviewed by mjs.
262
263         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
264
265 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
266
267         Reviewed by Steve.
268
269         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
270         WebKit.
271
272         - Drosera and Safari need to use the same ProgIDs in order for
273         CoCreateInstance to work properly.  The most robust way to do this is
274         for WebKit to dynamically publish those ProgIDs.
275
276         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
277         (DebuggerClient::createWebViewWithRequest):
278         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
279         statics.
280         (Drosera::initUI):
281         (Drosera::attach):
282         (Drosera::attemptToCreateServerConnection):
283         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
284         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
285         make use of the published ProgIDs.
286         (ServerConnection::attemptToCreateServerConnection):
287
288 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
289
290         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
291         - Build bot and leak fix.
292
293         * DumpRenderTree/LayoutTestController.cpp:
294         (pathToLocalResourceCallback):
295
296 2007-12-19  David Kilzer  <ddkilzer@apple.com>
297
298         Make svn-apply/svn-unapply work with patches from git-format-patch.
299
300         Reviewed by Darin.
301
302         * Scripts/svn-apply:
303         (patch): If 'Index:' can't be found in the text passed in, print it
304         out with a warning and return early.
305         * Scripts/svn-unapply:
306         (patch): Ditto.
307
308 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
309
310         Reviewed by Alp Toker.
311
312         Build related fixes.
313
314         * wx/build-wxwebkit:
315         - Check to make sure the user is running a supported wx port
316         - More robust checks for Cygwin
317         - Only run install-unix-extras on Mac, it's not the right solution
318           for Linux distros.
319         - Remove outdated Linux instructions after successful build
320         - Clean Bakefile-generated files during a clean operation
321
322 2007-12-18  Darin Adler  <darin@apple.com>
323
324         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
325
326 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
327
328         Add script to run Drosera as part of the nightly.
329         
330         Reviewed by Kevin M.
331
332         * Scripts/run-drosera.cmd: Added.
333
334 2007-12-18  Darin Adler  <darin@apple.com>
335
336         * Scripts/do-webcore-rename: Remove a stray K.
337
338 2007-12-18  Darin Adler  <darin@apple.com>
339
340         * Scripts/do-webcore-rename: Plan more renaming.
341
342 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
343
344         Reviewed by Alp Toker.
345
346         http://bugs.webkit.org/show_bug.cgi?id=16042
347         [GTK] Eliminate webkit_init()
348
349         Moving webkit initialization to WebView class init.
350
351         * DumpRenderTree/gtk/DumpRenderTree.cpp:
352         (main):
353         * GtkLauncher/main.c:
354         (main):
355
356 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
357
358         Reviewed by Alp Toker.
359
360         http://bugs.webkit.org/show_bug.cgi?id=13542
361         gdklauncher doesnt change URL in adress GTKEntry.
362
363         * GtkLauncher/main.c:
364         (load_commit_cb): added
365         (title_change_cb):
366         (create_browser):
367
368 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
369
370         Reviewed by Adam Roben.
371
372         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
373
374         * FindSafari/FindSafari.cpp:
375         (_tmain):
376
377 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
378
379         Reviewed by Adam Roben.
380
381         http://bugs.webkit.org/show_bug.cgi?id=16315
382         FindSafari needs a path-only option.
383
384         * FindSafari/FindSafari.cpp:
385         (_tmain):
386
387 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
388
389         Reviewed by Darin.
390
391         http://bugs.webkit.org/show_bug.cgi?id=16462
392         REGRESSION: access keys broken on Windows
393
394         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
395         if Alt is pressed.
396
397 2007-12-15  Sam Weinig  <sam@webkit.org>
398
399         Reviewed by Mark Rowe.
400
401         Fix urlSuitableForTestResult to correctly identify wstring::npos as
402         the case when wstring.find doesn't find anything.
403
404         * DumpRenderTree/win/DumpRenderTree.cpp:
405         (urlSuitableForTestResult):
406
407 2007-12-15  Alp Toker  <alp@atoker.com>
408
409         GTK+ DRT build fix for GLib < 2.14.
410
411         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
412         (LayoutTestController::setWaitToDump):
413
414 2007-12-05  Mark Rowe  <mrowe@apple.com>
415
416         Reviewed by Alp Toker.
417
418         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
419         many layout tests from hanging while waiting on user responses to dialogs.
420
421         * DumpRenderTree/gtk/DumpRenderTree.cpp:
422         (invalidateAnyPreviousWaitToDumpWatchdog):
423         (webViewScriptAlert):
424         (webViewScriptPrompt):
425         (webViewScriptConfirm):
426         (main):
427         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
428         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
429         (waitToDumpWatchdogFired):
430         (LayoutTestController::setWaitToDump):
431
432 2007-12-05  Mark Rowe  <mrowe@apple.com>
433
434         Reviewed by Alp Toker.
435
436         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
437
438         * DumpRenderTree/gtk/DumpRenderTree.cpp:
439         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
440         (dump):
441         (runTest):
442         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
443         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
444         work queue is empty.
445         (webViewWindowObjectCleared): Set up window.layoutTestController.
446         (webViewConsoleMessage): Match the console message format expected by the layout test results.
447         (main): Hook up the new signals.
448         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
449         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
450         dumping multiple times.
451         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
452         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
453
454 2007-12-14  Anders Carlsson  <andersca@apple.com>
455
456         Reviewed by Brady.
457
458         Assert that a web frame that's loading a resource always has either a data source or 
459         a provisional data source.
460         
461         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
462         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
463
464 2007-12-14  Darin Adler  <darin@apple.com>
465
466         - fix mistake causing nearly all tests to fail on Windows
467
468         * DumpRenderTree/win/UIDelegate.cpp:
469         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
470         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
471
472         * DumpRenderTree/mac/UIDelegate.mm:
473         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
474         than passing the entire message.
475
476 2007-12-14  Darin Adler  <darin@apple.com>
477
478         - fix Tiger build
479
480         * DumpRenderTree/mac/UIDelegate.mm:
481         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
482         new-to-Leopard methods.
483
484 2007-12-14  Darin Adler  <darin@apple.com>
485
486         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
487         since it now triggers unwanted icon loading. We only had it because we implemented "all"
488         delegate methods here.
489
490 2007-12-14  Anders Carlsson  <andersca@apple.com>
491
492         Reviewed by Darin and Geoff.
493
494         <rdar://problem/5619295> 
495         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
496         
497         Add property getting methods to the plug-in.
498         
499         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
500         (pluginInvoke):
501
502 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
503
504         Reviewed by Darin.
505
506         - Layout test fix for mac. When dumped to the console local file paths
507         now only show the name of the resource not the whole path.  This is to
508         make the results machine and OS independent.
509
510         * DumpRenderTree/mac/UIDelegate.mm:
511         (-[UIDelegate webView:addMessageToConsole:]):
512
513 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
514
515         Reviewed by Adam.
516
517         - Layout tests fix.  We need a way to remove machine-dependent
518         information from paths in layout test results. The UIDelegate now does
519         this.
520
521         * DumpRenderTree/DumpRenderTree.h:
522         * DumpRenderTree/win/DumpRenderTree.cpp:
523         (urlSuitableForTestResult):
524         * DumpRenderTree/win/DumpRenderTreeWin.h:
525         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
526         * DumpRenderTree/win/UIDelegate.cpp:
527         (UIDelegate::webViewAddMessageToConsole):
528
529 2007-12-13  Alp Toker  <alp@atoker.com>
530
531         Build fix for DRT breakage introduced in r28690.
532
533         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
534         (LayoutTestController::pathToLocalResource):
535
536 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
537
538         Reviewed by Alice and Sam.
539
540         - <rdar://5621435> Need a way to specify local resources (being loaded
541         from HTTP tests) on Windows.
542         - Implemented pathToLocalResource which exposes the functionality of
543         converting a given unix path to the correct location on Windows.
544
545         * DumpRenderTree/LayoutTestController.cpp:
546         (pathToLocalResourceCallback):
547         (LayoutTestController::staticFunctions):
548         * DumpRenderTree/LayoutTestController.h:
549         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
550         (LayoutTestController::pathToLocalResource):
551         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
552         (LayoutTestController::pathToLocalResource):
553
554 2007-12-12  Anders Carlsson  <andersca@apple.com>
555
556         Reviewed by Sam.
557
558         <rdar://problem/5132003>
559         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
560
561         * DumpRenderTree/win/DumpRenderTree.cpp:
562         (main):
563         Set the resource load delegate.
564         
565         * DumpRenderTree/win/DumpRenderTree.vcproj:
566         
567         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
568         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
569
570 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
571
572         Reviewed by Adam Roben.
573
574         Fix conversion from double to LPARAM in dispatchMessage().
575
576         * DumpRenderTree/win/EventSender.cpp:
577         (dispatchMessageCallback):
578
579 2007-12-11  Dan Bernstein  <mitz@apple.com>
580
581         Reviewed by Mark Rowe and Sam Weinig too!
582
583         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
584           fonts DumpRenderTree registers.
585
586         * DumpRenderTree/win/DumpRenderTree.cpp:
587         (initialize):
588
589 2007-12-11  Brady Eidson  <beidson@apple.com>
590
591         Reviewed by Anders
592
593         Make DumpRenderTree on mac use its own path for Databases testing
594
595         * DumpRenderTree/mac/DumpRenderTree.mm:
596         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
597           for future DRT-only use, then use it to construct the Databases path and set that default
598
599 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
600
601         Reviewed by Darin.
602
603         <rdar://problem/5535636>
604         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
605
606         http://bugs.webkit.org/show_bug.cgi?id=13916
607         JavaScript detects Tab as a character input on a textfield validation
608
609         * DumpRenderTree/mac/EventSendingController.mm:
610         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
611         Dispatch a keyup to better match what happens when a key is physically pressed.
612
613         * DumpRenderTree/win/EventSender.cpp:
614         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
615         returning from keyDown().
616         (getConstantCallback): Fixed a couple copy/paste mistakes.
617
618 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
619
620         Reviewed by Oliver.
621
622         - <rdar://5599845> Drosera: Does not show loal files in the file list
623         on the left side.
624
625         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
626         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
627         so the open source community can build.
628
629 2007-12-10  Brady Eidson  <beidson@apple.com>
630
631         Rubberstamped by Sam Weinig
632
633         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
634
635         * DumpRenderTree/mac/UIDelegate.mm:
636         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
637         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
638
639 2007-12-08  Oliver Hunt  <oliver@apple.com>
640
641         Reviewed by Sam W.
642
643         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
644         
645         Fixes <rdar://problem/5620249> Must disable SVG animation
646         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
647         
648         In order to allow finer grained control over the set of SVG features
649         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
650         distinct flags:
651         ENABLE_SVG_ANIMATION
652         ENABLE_SVG_FILTERS
653         ENABLE_SVG_FONTS
654         ENABLE_SVG_AS_IMAGE
655         ENABLE_SVG_USE
656         
657         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
658         
659         Script handles all the new build flags, and allows --svg-experimental
660         to automatically enable all features.
661
662         * Scripts/build-webkit:
663
664 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
665
666         Fix version parsing.
667
668         Rubber-stamped by Oliver.
669
670         * Drosera/win/Drosera.vcproj/auto-version.sh:
671
672 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
673
674         Build modifications for Drosera.
675
676         Reviewed by Adam.
677
678         * Drosera/DroseraWin.make: Added.
679         * Drosera/win/Drosera.vcproj/Drosera.rc:
680         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
681         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
682         * Drosera/win/Drosera.vcproj/VERSION: Added.
683         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
684
685 2007-12-06  Adam Roben  <aroben@apple.com>
686
687         Explicitly turn on the Mac font ascent hack on Windows
688
689         This keeps our font metrics matching those from Mac.
690
691         Reviewed by Hyatt.
692
693         * DumpRenderTree/win/DumpRenderTree.cpp:
694         (main):
695
696 2007-12-06  Anders Carlsson  <andersca@apple.com>
697
698         Rename main.c to main.cpp here too.
699         
700         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
701
702 2007-12-06  Sam Weinig  <sam@webkit.org>
703
704         Rubber stamped by Geoff.
705
706         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
707
708 2007-12-06  Darin Adler  <darin@apple.com>
709
710         * Scripts/do-webcore-rename: Some more renaming plans.
711
712 2007-12-06  Anders Carlsson  <andersca@apple.com>
713
714         Restore implementation of testGetIntIdentifier that was accidentally
715         removed somehow (possibly when I made PluginObject be a cpp file).
716         
717         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
718         (pluginInvoke):
719
720 2007-12-05  Anders Carlsson  <andersca@apple.com>
721
722         Make the entry points extern "C".
723         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
724         
725 2007-12-05  Anders Carlsson  <andersca@apple.com>
726
727         C++ warning fixes.
728         
729         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
730         (NPP_New):
731         (NPP_Destroy):
732         (NPP_SetWindow):
733         (NPP_NewStream):
734         (NPP_HandleEvent):
735         (NPP_URLNotify):
736         (NPP_GetValue):
737
738 2007-12-05  Anders Carlsson  <andersca@apple.com>
739
740         Add the .cpp files to the TestNetscapePlugIn target.
741
742         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
743
744 2007-12-05  Anders Carlsson  <andersca@apple.com>
745
746         Reviewed by Geoff.
747         
748         Rename the TestNetscapePlugIn .c files to be .cpp.
749
750         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
751         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
752         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
753         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
754         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
755         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
756         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
757         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
758
759 2007-12-05  Adam Roben  <aroben@apple.com>
760
761         Fix case of keypresses from the Windows implementation of eventSender.keyDown
762
763         This fixes several regression tests.
764
765         Reviewed by Alice.
766
767         * DumpRenderTree/win/EventSender.cpp:
768         (keyDownCallback): Virtual keycodes for ASCII characters are always
769         uppercase, so we need to check the case of the original character
770         passed in to eventSender.keyDown.
771
772 2007-12-05  Adam Roben  <aroben@apple.com>
773
774         Learn from Tim's mistakes
775
776         * DumpRenderTree/win/DumpRenderTree.cpp:
777         (runTest): Reset the authorAndUserStylesEnabled preference for each
778         test.
779
780 2007-12-05  Alp Toker  <alp@atoker.com>
781
782         Reviewed by Mark Rowe.
783
784         Initialize GTK+ and WebKit so the tests can run.
785
786         Reorganize the headers a little.
787
788         * DumpRenderTree/gtk/DumpRenderTree.cpp:
789         (main):
790
791 2007-12-04  Anders Carlsson  <andersca@apple.com>
792
793         Remove IWebScriptScope include.
794         
795         * Drosera/win/DebuggerDocumentPlatform.cpp:
796
797 2007-12-04  Sam Weinig  <sam@webkit.org>
798
799         Rubber stamped by Mark Rowe.
800
801         Define CF as platform for mac and revert r28409
802
803         * DumpRenderTree/DumpRenderTree.h:
804         * DumpRenderTree/mac/DumpRenderTreeMac.h:
805
806 2007-12-04  Sam Weinig  <sam@webkit.org>
807
808         Define CF as platform for windows.
809
810         Reviewed by Adam Roben.
811
812         * DumpRenderTree/win/DumpRenderTreeWin.h:
813
814 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
815
816         Reviewed by Adam and Darin.
817
818         - Removed a needless BSTR cleanup.
819
820         * Drosera/win/DebuggerDocumentPlatform.cpp:
821         (DebuggerDocument::getPlatformCurrentFunctionStack):
822
823 2007-11-27  Adam Roben  <aroben@apple.com>
824
825         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
826
827         Reviewed by Maciej.
828
829         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
830         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
831
832 2007-12-04  Alp Toker  <alp@atoker.com>
833
834         Prospective Win DRT build fix.
835
836         * DumpRenderTree/DumpRenderTree.h:
837
838 2007-12-04  Alp Toker  <alp@atoker.com>
839
840         Fix a clobbered copyright header.
841
842         * DumpRenderTree/gtk/DumpRenderTree.cpp:
843
844 2007-12-04  Xan Lopez  <xan@gnome.org>
845
846         Reviewed by Alp Toker.
847
848         http://bugs.webkit.org/show_bug.cgi?id=15561
849         GTK port needs DumpRenderTree implementation
850
851         Start work on the GTK+ DRT.
852
853         This does not work yet, and there are a few lingering style issues
854         (nothing major) but this patch has been stuck in the bug tracker for
855         too long already.
856
857         * DumpRenderTree/DumpRenderTree.h:
858         * DumpRenderTree/gtk: Added.
859         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
860         (autocorrectURL):
861         (shouldLogFrameLoadDelegates):
862         (dumpFrameScrollPosition):
863         (displayWebView):
864         (appendString):
865         (dumpFramesAsText):
866         (dumpRenderTreeAsText):
867         (dump):
868         (runTest):
869         (main):
870         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
871         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
872         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
873         (GCController::collect):
874         (GCController::collectOnAlternateThread):
875         (GCController::getJSObjectCount):
876         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
877         (LayoutTestController::~LayoutTestController):
878         (LayoutTestController::addDisallowedURL):
879         (LayoutTestController::clearBackForwardList):
880         (LayoutTestController::copyDecodedHostName):
881         (LayoutTestController::copyEncodedHostName):
882         (LayoutTestController::display):
883         (LayoutTestController::keepWebHistory):
884         (LayoutTestController::notifyDone):
885         (LayoutTestController::queueBackNavigation):
886         (LayoutTestController::queueForwardNavigation):
887         (LayoutTestController::queueLoad):
888         (LayoutTestController::queueReload):
889         (LayoutTestController::queueScript):
890         (LayoutTestController::setAcceptsEditing):
891         (LayoutTestController::setCustomPolicyDelegate):
892         (LayoutTestController::setMainFrameIsFirstResponder):
893         (LayoutTestController::setTabKeyCyclesThroughElements):
894         (LayoutTestController::setUseDashboardCompatibilityMode):
895         (LayoutTestController::setUserStyleSheetEnabled):
896         (LayoutTestController::setUserStyleSheetLocation):
897         (LayoutTestController::setWindowIsKey):
898         (LayoutTestController::setWaitToDump):
899         (LayoutTestController::windowCount):
900         (LayoutTestController::setPrivateBrowsingEnabled):
901         (LayoutTestController::setAuthorAndUserStylesEnabled):
902         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
903         (JSStringCopyUTF8CString):
904         (LoadItem::invoke):
905         (ReloadItem::invoke):
906         (ScriptItem::invoke):
907         (BackForwardItem::invoke):
908
909 2007-12-03  Sam Weinig  <sam@webkit.org>
910
911         Move JavaScriptCore thread testing code to pthread specific directory
912         and remove the dependance on CoreFoundation by using WTF::HashSet.
913
914         Reviewed by Geoff and Oliver.
915
916         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
917         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
918         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
919         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
920         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
921         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
922         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
923         * DumpRenderTree/pthreads: Added.
924         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
925         (javaScriptThreads):
926         (runJavaScriptThread):
927         (startJavaScriptThreads):
928         (stopJavaScriptThreads):
929
930 2007-12-03  Andrew Bonventre  <andybons@google.com>
931
932         Reviewed by Darin Adler.
933
934         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
935         Symbol lookup menu broken in debugger view
936
937         * Drosera/debugger.js: Fixed javascript error where document property
938         should have been used instead of contentDocument in switchFunction that
939         was breaking the select symbol dropdown menu.  This is because
940         window.frames will return a Window object and not a frame object like
941         the author was originally expecting.
942
943 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
944
945         Reviewed by Adam.
946
947         - <rdar://5618942> Drosera: Console window does not process everything
948         correctly.
949         - <rdar://5619005> Drosera: could be sped up by moving the 
950         WebScriptScope stuff into the WebScriptCallFrame.
951         - Now the console can correctly process objects and does not receive
952         notifications from JavaScriptCore about the JavaScript in Drosera's
953         own process.
954
955         * Drosera/win/DebuggerDocumentPlatform.cpp:
956         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
957         (DebuggerDocument::platformValueForScopeVariableNamed):
958
959 2007-12-03  Stephanie  <slewis@apple.com>
960
961         Reviewed by Darin.
962
963         Check to see if we are building a debug root
964
965         * Scripts/check-for-global-initializers: 
966
967 2007-12-03  Dan Bernstein  <mitz@apple.com>
968
969         Reviewed by Darin Adler.
970
971         - added a testGetIntIdentifier() method to TestNetscapePlugIn
972
973         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
974         (pluginInvoke):
975
976 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
977
978         Reviewed by Oliver.
979
980         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
981         in a more fine-grained manner than eventSender.keyDown().
982
983         * DumpRenderTree/win/EventSender.cpp:
984         (getConstantCallback):
985         (dispatchMessageCallback):
986
987 2007-12-02  Darin Adler  <darin@apple.com>
988
989         * Scripts/do-webcore-rename: More planned renaming.
990
991 2007-12-02  Sam Weinig  <sam@webkit.org>
992
993         Rubber stamped by Anders.
994
995         Use [NSURL absoluteString] instead of [NSURL description] in order to get
996         more uniform results cross platform.
997
998         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
999         (-[NSURL _drt_descriptionSuitableForTestResult]):
1000
1001 2007-12-02  Sam Weinig  <sam@webkit.org>
1002
1003         Rubber stamped by Niko.
1004
1005         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
1006
1007         * DumpRenderTree/win/DumpRenderTree.cpp:
1008         * DumpRenderTree/win/DumpRenderTree.vcproj:
1009         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
1010         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
1011         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
1012         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
1013
1014 2007-12-01  Alp Toker  <alp@atoker.com>
1015
1016         Reviewed by Adam Roben.
1017
1018         Make use of the newly introduced webkit.h convenience header.
1019
1020         * GtkLauncher/main.c:
1021
1022 2007-12-01  Adam Treat  <treat@kde.org>
1023
1024         Reviewed by Simon.
1025
1026         * Check to see if the directory exists and exit if not.
1027
1028         * DumpRenderTree/qt/main.cpp:
1029         (main):
1030
1031 2007-12-01  Adam Treat  <treat@kde.org>
1032
1033         Reviewed by Simon.
1034
1035         * Don't hide symbols when in Debug mode
1036         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
1037
1038
1039         * DumpRenderTree/qt/main.cpp:
1040         (messageHandler):
1041
1042 2007-11-30  Alp Toker  <alp@atoker.com>
1043
1044         Reviewed by Adam Roben.
1045
1046         http://bugs.webkit.org/show_bug.cgi?id=15691
1047         [GTK] Public API does not follow GTK+ conventions
1048
1049         Refactor the WebKit/GTK+ public API. Changes:
1050           WebKitPage -> WebKitWebView
1051           WebKitFrame -> WebKitWebFrame
1052
1053         Public API source and header names have been updated to mirror the API
1054         changes.
1055
1056         The API is now kept in WebKit/gtk/WebView to match other ports in the
1057         same class such as Mac and Win.
1058
1059         * GtkLauncher/main.c:
1060         (activate_uri_entry_cb):
1061         (link_hover_cb):
1062         (title_change_cb):
1063         (progress_change_cb):
1064         (go_back_cb):
1065         (go_forward_cb):
1066         (create_browser):
1067         (main):
1068
1069 2007-11-30  Adam Roben  <aroben@apple.com>
1070
1071         Hopefully the final build fix
1072
1073         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
1074         pull in WTF's assertion/logging functions.
1075
1076 2007-11-30  Adam Roben  <aroben@apple.com>
1077
1078         Another build fix
1079
1080         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
1081         WebKit.lib.
1082
1083 2007-11-30  Adam Roben  <aroben@apple.com>
1084
1085         Debug build fix
1086
1087         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
1088         configuration.
1089         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
1090         projects.
1091         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
1092         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
1093         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
1094
1095 2007-11-30  Sam Weinig  <sam@webkit.org>
1096
1097         Reviewed by Adam Roben.
1098
1099         Fix drawSelectionRect to actually draw the selection rect.
1100
1101         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1102         (drawSelectionRect):
1103
1104 2007-11-30  Darin Adler  <darin@apple.com>
1105
1106         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
1107
1108 2007-11-30  Darin Adler  <darin@apple.com>
1109
1110         * Scripts/do-webcore-rename: Get ready for some future renaming.
1111
1112 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1113
1114         Reviewed by Adam.
1115
1116         - Removed some unnecessary functions and changed an unused return type. 
1117
1118         * Drosera/win/DebuggerClient.cpp:
1119         (registerConsoleClass):
1120         * Drosera/win/DebuggerClient.h:
1121         * Drosera/win/Drosera.cpp:
1122         (registerDroseraClass):
1123
1124 2007-11-28  Alp Toker  <alp@atoker.com>
1125
1126         Reviewed by Timothy Hatcher.
1127
1128         http://bugs.webkit.org/show_bug.cgi?id=16174
1129         [GTK] Use "URI" not "URL" in public API
1130
1131         Replace use of the term "URL" with "URI" in public headers,
1132         documentation and some internal code to match GLib/GTK+ convention.
1133
1134         This is now mentioned in the API guidelines:
1135           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
1136
1137         * GtkLauncher/main.c:
1138         (activate_uri_entry_cb):
1139         (title_change_cb):
1140         (create_toolbar):
1141         (main):
1142
1143 2007-11-29  Anders Carlsson  <andersca@apple.com>
1144
1145         Reviewed by Sam.
1146
1147         <rdar://problem/5230478>
1148         FrameLoadDelegate callbacks are not dumped in DRT.
1149         
1150         * DumpRenderTree/win/DumpRenderTree.cpp:
1151         (shouldLogFrameLoadDelegates):
1152         (runTest):
1153         (main):
1154         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
1155         (BSTRtoString):
1156         (descriptionSuitableForTestResult):
1157         (FrameLoadDelegate::QueryInterface):
1158         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
1159         (FrameLoadDelegate::didFailProvisionalLoadWithError):
1160         (FrameLoadDelegate::didCommitLoadForFrame):
1161         (FrameLoadDelegate::didFinishLoadForFrame):
1162         (FrameLoadDelegate::willCloseFrame):
1163         (FrameLoadDelegate::didClearWindowObject):
1164         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
1165         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
1166         * DumpRenderTree/win/FrameLoaderDelegate.h:
1167         (FrameLoadDelegate::windowScriptObjectAvailable):
1168         (FrameLoadDelegate::didFirstLayoutInFrame):
1169
1170 2007-11-29  Sam Weinig  <sam@webkit.org>
1171
1172         Reviewed by Anders.
1173
1174         Add database quota UIDelegates methods to DRT UIDelegate.
1175
1176         * DumpRenderTree/mac/UIDelegate.mm:
1177         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1178         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
1179
1180 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1181
1182         Reviewed by Sam.
1183
1184         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
1185         dying and vice versa.
1186         - This fix will allow Drosera and Safari to reconnect if either of them
1187         closes correctly, but does not fix the case where one of them dies
1188         silently.
1189
1190         * Drosera/win/ServerConnection.cpp:
1191         (ServerConnection::attemptToCreateServerConnection): Added a safety
1192         check, because it's possilbe to try to connect to a server that's dying.
1193         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
1194         the server has died.
1195         * Drosera/win/ServerConnection.h: Added the new function and removed
1196         an unnecessary member.
1197
1198 2007-11-29  Anders Carlsson  <andersca@apple.com>
1199
1200         * DumpRenderTree/win/DumpRenderTree.vcproj:
1201         Add shlwapi.lib to all configurations.
1202
1203 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1204
1205         - Build fix.  Added additional includes for VS Express to the Release
1206         project.
1207
1208         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1209
1210 2007-11-29  Anders Carlsson  <andersca@apple.com>
1211
1212         Reviewed by Adam.
1213
1214         <rdar://problem/5132005>
1215         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
1216         
1217         * DumpRenderTree/win/DumpRenderTree.vcproj:
1218         Add shlwapi.lib
1219         
1220         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1221         (LayoutTestController::setUserStyleSheetEnabled):
1222         Implement this.
1223         
1224         (appendComponentToPath):
1225         New method which wraps the Win32 API PathAppend.
1226         
1227         (followShortcuts):
1228         New method which checks if a file points to a shortcut and
1229         follows the shortcut.
1230         
1231         (resolveCygwinPath):
1232         New method that takes a cygwin unix-style path and returns the Win32 path.
1233         
1234         (cfStringRefToWString):
1235         
1236         (LayoutTestController::setUserStyleSheetLocation):
1237         Implement this.
1238
1239 2007-11-29  Alice Liu  <alice.liu@apple.com>
1240
1241         Reviewed by Adam.
1242
1243         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
1244
1245         * DumpRenderTree/win/EventSender.cpp:
1246         (keyDownCallback):
1247         uppercase letters were being sent as lowercase letters without the shift key down.
1248
1249 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1250
1251         - Windows build fix. VS express needs some love.
1252
1253         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1254
1255 2007-11-28  Darin Adler  <darin@apple.com>
1256
1257         Reviewed by Adam Roben.
1258
1259         * DumpRenderTree/mac/EventSendingController.mm:
1260         (-[EventSendingController keyDown:withModifiers:]):
1261         Send capital letters through as lowercase letters with the shift key down
1262         rather than sending them as if they were highly unusual "capital letter keys".
1263
1264         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
1265         where you need to update results and more tests are failing than before.
1266
1267 2007-11-28  Anders Carlsson  <andersca@apple.com>
1268
1269         Reviewed by Darin.
1270
1271         <rdar://problem/5132001>
1272         contextClick is not implemented in DRT on Windows.
1273         
1274         * DumpRenderTree/win/EventSender.cpp:
1275         (contextClickCallback):
1276         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
1277         by a WM_RBUTTONUP message.
1278         
1279         * DumpRenderTree/win/UIDelegate.cpp:
1280         (UIDelegate::hasCustomMenuImplementation):
1281         (UIDelegate::trackCustomPopupMenu):
1282         * DumpRenderTree/win/UIDelegate.h:
1283         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
1284         menu from being shown (and causing the DRT to hang).
1285
1286 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
1287
1288         Reviewed by Darin.
1289
1290         Fix DumpRenderTree ObjC bug comparing strings.
1291
1292         * DumpRenderTree/mac/ObjCController.m:
1293         (-[ObjCController identityIsEqual::]): Compare strings with string
1294         equality instead of identiy equality.
1295
1296 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1297
1298         Reviewed by Sam.
1299
1300         Reset the authorAndUserStylesEnabled preference
1301         back to YES for each test. Fixes the broken tests.
1302
1303         * DumpRenderTree/mac/DumpRenderTree.mm:
1304         (resetWebViewToConsistentStateBeforeTesting):
1305
1306 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
1307
1308         Reviewed by Adam.
1309
1310         - Drosera now displays the console window, although it cannot currently
1311         process JavaScript.
1312
1313         * Drosera/win/DebuggerClient.cpp: Shows the console window.
1314         (registerConsoleClass): Implemented.
1315         (consoleWndProc): Implemented.
1316         (DebuggerClient::onSize): Implemented.
1317         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
1318         new window.
1319         * Drosera/win/DebuggerClient.h: Added needed method and members for 
1320         creating and maintaining a new window.
1321         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
1322         lines of code to more appropriate places.
1323         (Drosera::handleCommand):
1324         (Drosera::initUI):
1325         (Drosera::onSize):
1326         (Drosera::attach):
1327
1328 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1329
1330         Reviewed by Dave Hyatt.
1331
1332         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
1333         
1334         Add support for disabling author and user styles for testing.
1335
1336         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1337         * DumpRenderTree/LayoutTestController.cpp:
1338         (setAuthorAndUserStylesEnabledCallback):
1339         (LayoutTestController::staticFunctions):
1340         * DumpRenderTree/LayoutTestController.h:
1341         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1342         (LayoutTestController::setAuthorAndUserStylesEnabled):
1343         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1344         (LayoutTestController::setAuthorAndUserStylesEnabled):
1345
1346 2007-11-26  Dan Bernstein  <mitz@apple.com>
1347
1348         - Tiger build fix.
1349
1350         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1351
1352 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
1353
1354         Reviewed by Maciej.
1355
1356         - Implemented displaying variables for Drosera on Win.
1357
1358         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
1359         that retrieve variables to not hold onto the return value since it's
1360         not returned.  Also changed to use the new signatures of the retrieval
1361         functions.
1362         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1363         (DebuggerDocument::platformValueForScopeVariableNamed):
1364         * Drosera/win/Drosera.cpp: Removed a needless TODO.
1365         (droseraWndProc):
1366
1367 2007-11-26  Sam Weinig  <sam@webkit.org>
1368
1369         Cleanup names of painting and repainting functions.
1370
1371         Reviewed by Adam Roben.
1372
1373         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1374         (drawSelectionRect): was drawSelectionRectIntoContext.
1375         (dumpWebViewAsPixelsAndCompareWithExpected):
1376         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1377         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1378         (paintWebView): was drawWebViewIntoContext.
1379         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
1380
1381 2007-11-26  Sam Weinig  <sam@webkit.org>
1382
1383         Reviewed by Dan Bernstein.
1384
1385         - Leopard build fix
1386
1387         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1388
1389 2007-11-26  Sam Weinig  <sam@webkit.org>
1390
1391         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
1392         Use shared PixelDumpSupport for Mac DRT
1393
1394         Reviewed by Adam Roben.
1395
1396         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1397         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
1398         * DumpRenderTree/cg/ImageDiffCG.cpp:
1399         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1400         (drawSelectionRectIntoContext):
1401         (dumpWebViewAsPixelsAndCompareWithExpected):
1402         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1403         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1404         * DumpRenderTree/mac/DumpRenderTree.mm:
1405         (dump):
1406         * DumpRenderTree/mac/ImageDiff.m: Removed.
1407         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
1408         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
1409         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
1410         (setDefaultColorProfileToRGB):
1411         (getBitmapContextFromWebView):
1412         (drawWebViewIntoContext):
1413         (repaintWithVerticalSweep):
1414         (repaintWithHorizontalSweep):
1415         (getSelectionRect):
1416         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
1417
1418 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
1419
1420         Bug 16052: prepare-ChangeLog doesn't report deleted files
1421         <http://bugs.webkit.org/show_bug.cgi?id=16052>
1422
1423         Reviewed by Sam.
1424
1425         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
1426
1427 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
1428
1429         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
1430         <http://bugs.webkit.org/show_bug.cgi?id=15864>
1431
1432         Reviewed by Adam.
1433
1434         Roll functionality of merge-changelog into resolve-ChangeLogs
1435         script.  The script now checks for ChangeLog.rej and
1436         ChangeLog.orig files first.  If it finds them, it uses the
1437         ChangeLog.rej file as a patch (in old contextual diff format) to
1438         apply with --fuzz=3.
1439
1440         * Scripts/merge-changelog: Removed.
1441         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
1442
1443 2007-11-25  Sam Weinig  <sam@webkit.org>
1444
1445         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
1446
1447         Reviewed by Mark Rowe.
1448
1449         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1450         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1451         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1452         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
1453         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
1454
1455 2007-11-25  Sam Weinig  <sam@webkit.org>
1456
1457         Convert DumpRenderTree to ues .xcconfig files.
1458
1459         Reviewed by Mark Rowe.
1460
1461         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1462         * DumpRenderTree/mac/Configurations: Added.
1463         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
1464         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
1465         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
1466
1467 2007-11-25  Sam Weinig  <sam@webkit.org>
1468
1469         Add ForwardingHeaders to wtf for DumpRenderTree.
1470
1471         Reviewed by Mark Rowe.
1472
1473         * DumpRenderTree/DumpRenderTree.h:
1474         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1475         * DumpRenderTree/ForwardingHeaders: Added.
1476         * DumpRenderTree/ForwardingHeaders/wtf: Added.
1477         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
1478         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
1479         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
1480         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
1481         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
1482         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
1483         * DumpRenderTree/LayoutTestController.cpp:
1484         * DumpRenderTree/WorkQueue.cpp:
1485         * DumpRenderTree/mac/DumpRenderTree.mm:
1486         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1487         * DumpRenderTree/mac/JavaScriptThreading.cpp:
1488         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1489         * DumpRenderTree/mac/ObjCController.m:
1490         * DumpRenderTree/mac/UIDelegate.mm:
1491         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1492
1493 2007-11-25  Adam Roben  <aroben@apple.com>
1494
1495         Fix some test failures caused by r28019
1496
1497         Now that stdout is in binary mode, we need to always use printf
1498         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
1499         the output.
1500
1501         Reviewed by Sam.
1502
1503         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
1504         printf.
1505         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1506         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1507         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1508         (UIDelegate::webViewAddMessageToConsole):
1509
1510 2007-11-25  Adam Roben  <aroben@apple.com>
1511
1512         Set the font smoothing preference in DRT
1513
1514         This makes the pixel results on Windows closer to the Mac results.
1515
1516         Reviewed by Mitz.
1517
1518         * DumpRenderTree/win/DumpRenderTree.cpp:
1519         (initializePreferences):
1520
1521 2007-11-25  Adam Roben  <aroben@apple.com>
1522
1523         Port ImageDiff to CG and C++
1524
1525         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
1526         <rdar://5071708>
1527
1528         Reviewed by Sam.
1529
1530         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
1531         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
1532         (main):
1533         (createImageFromStdin):
1534         (compareImages):
1535         (getDifferenceBitmap):
1536         (computePercentageDifferent):
1537         * DumpRenderTree/win/ImageDiff.vcproj: Added.
1538
1539 2007-11-25  Adam Roben  <aroben@apple.com>
1540
1541         Fix image diff link generation on Windows
1542
1543         Reviewed by Sam.
1544
1545         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
1546         to toURL.
1547
1548 2007-11-25  Adam Roben  <aroben@apple.com>
1549
1550         Implement pixel dumping in Windows DRT
1551
1552         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
1553         <rdar://5071708>
1554
1555         Reviewed by Sam.
1556
1557         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
1558         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
1559         Content-Length header.
1560         (getMD5HashStringForBitmap):
1561         (dumpWebViewAsPixelsAndCompareWithExpected):
1562         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
1563         * DumpRenderTree/win/DumpRenderTree.cpp:
1564         (dump): Do a pixel dump if requested.
1565         (main): Parse pixel test options.
1566         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
1567         the cg/ subdirectory to the include path.
1568         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
1569         available in a header or import library, so we have to go through this
1570         LoadLibrary/GetProcAddress dance to use them.
1571         (cryptDLL):
1572         (init):
1573         (update):
1574         (final):
1575         (MD5_Init):
1576         (MD5_Update):
1577         (MD5_Final):
1578         * DumpRenderTree/win/MD5.h: Added.
1579         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
1580         moved up to the top level to share it with Mac eventually.
1581         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
1582         (getBitmapContextFromWebView): Forces the WebView to paint using a
1583         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
1584
1585 2007-11-25  Adam Roben  <aroben@apple.com>
1586
1587         Clean up Windows DRT's option parsing a little bit
1588
1589         Reviewed by Sam.
1590
1591         * DumpRenderTree/win/DumpRenderTree.cpp:
1592         (main): Put non-option arguments into a Vector.
1593
1594 2007-11-25  Adam Roben  <aroben@apple.com>
1595
1596         Make Windows DRT stop changing LF into CRLF
1597
1598         Reviewed by Sam.
1599
1600         * DumpRenderTree/win/DumpRenderTree.cpp:
1601         (main): Put stdout in binary mode.
1602         * Scripts/run-webkit-tests: Remove the CRLF hack.
1603
1604 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
1605
1606         Removed empty directory.
1607
1608         * Scripts/resources: Removed.
1609
1610 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
1611
1612         Fix bisect-builds to work with recent WebKit nightly builds.
1613
1614         Reviewed by Dan.
1615
1616         * Scripts/bisect-builds: Check for the 
1617         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
1618         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
1619         to WebKit.app/Contents/Resources.
1620
1621 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
1622
1623         Reviewed by Maciej.
1624
1625         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
1626         not closed (affects digg.com)
1627
1628         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
1629         one after finishing with a test to avoid having its delayed onload handler firing when
1630         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
1631         but it helps somewhat.
1632
1633 2007-11-22  Mark Rowe  <mrowe@apple.com>
1634
1635         Reviewed by Alp Toker.
1636
1637         Fix build-webkit to propagate make's exit status if it fails.
1638
1639         * Scripts/webkitdirs.pm:
1640
1641 2007-11-22  Dan Bernstein  <mitz@apple.com>
1642
1643         Reviewed by Mark Rowe.
1644
1645         - fix crash when running pixel tests
1646
1647         * DumpRenderTree/mac/DumpRenderTree.mm:
1648         (dumpRenderTree): Parse the command line options before setting up the
1649         environment so that we know if we need to set up the pixel dump
1650         machinery.
1651
1652 2007-11-21  Eric Seidel  <eric@webkit.org>
1653
1654         Speculative build fix for Tiger.
1655
1656         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
1657
1658 2007-11-21  Eric Seidel  <eric@webkit.org>
1659
1660         Reviewed by Tim Hatcher.
1661
1662         Break out more of DumpRenderTree.mm into individual files
1663
1664         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1665         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
1666         (checkedMalloc):
1667         (checkedRealloc):
1668         (makeLargeMallocFailSilently):
1669         * DumpRenderTree/mac/CheckedMalloc.h: Added.
1670         * DumpRenderTree/mac/DumpRenderTree.mm:
1671         (crashHandler):
1672         (dump):
1673         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1674         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
1675         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1676         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1677         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1678         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
1679         (javaScriptThreads):
1680         (runJavaScriptThread):
1681         (startJavaScriptThreads):
1682         (stopJavaScriptThreads):
1683         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
1684         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
1685         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
1686         (restoreColorSpace):
1687         (setDefaultColorProfileToRGB):
1688         (initializeColorSpaceAndScreeBufferForPixelTests):
1689         (md5HashStringForBitmap):
1690         (dumpWebViewAsPixelsAndCompareWithExpected):
1691
1692 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
1693
1694         Move install-unix-extras to wx directory as it seems only to be used by that 
1695         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
1696         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
1697         have install-unix-extras install into WebKitLibraries as per
1698         convention.
1699         
1700         Reviewed by Mark Rowe.
1701
1702         * Scripts/install-unix-extras: Removed.
1703         * wx/build-wxwebkit:
1704         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
1705
1706 2007-11-21  Eric Seidel  <eric@webkit.org>
1707
1708         Reviewed by Adam.
1709
1710         More refactoring for greater code readability
1711
1712         * DumpRenderTree/mac/DumpRenderTree.mm:
1713         (initializeGlobalsFromCommandLineOptions):
1714         (initializeColorSpaceAndScreeBufferForPixelTests):
1715         (addTestPluginsToPluginSearchPath):
1716         (useLongRunningServerMode):
1717         (runTestingServerLoop):
1718         (prepareConsistentTestingEnvironment):
1719         (dumpRenderTree):
1720         (main):
1721         (dumpFramesAsText):
1722         (dumpBackForwardListForWebView):
1723         (sizeWebViewForCurrentTest):
1724         (methodNameStringForFailedTest):
1725         (dumpBackForwardListForAllWindows):
1726         (dumpWebViewAsPixelsAndCompareWithExpected):
1727         (invalidateAnyPreviousWaitToDumpWatchdog):
1728         (dump):
1729         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1730         * DumpRenderTree/mac/UIDelegate.mm:
1731         (-[UIDelegate webView:createWebViewWithRequest:]):
1732
1733 2007-11-21  Eric Seidel  <eric@webkit.org>
1734
1735         Reviewed by Tim Hatcher.
1736
1737         Abstract more of DRT into static methods
1738
1739         * DumpRenderTree/mac/DumpRenderTree.mm:
1740         (setDefaultsToConsistentValuesForTesting):
1741         (setupSignalHandlers):
1742         (allocateGlobalControllers):
1743         (releaseAndZero):
1744         (releaseGlobalControllers):
1745         (dumpRenderTree):
1746         (shouldLogFrameLoadDelegates):
1747         (createCFURLFromPathOrURL):
1748         (resetWebViewToConsistentStateBeforeTesting):
1749         (runTest):
1750
1751 2007-11-21  Eric Seidel  <eric@webkit.org>
1752
1753         Reviewed by Tim Hatcher.
1754
1755         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
1756
1757         * DumpRenderTree/DumpRenderTree.h:
1758         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1759         * DumpRenderTree/mac/DumpRenderTree.mm:
1760         (dumpRenderTree):
1761         (dump):
1762         (runTest):
1763         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
1764         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
1765         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
1766         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
1767         (-[DumpRenderTreePasteboard declareType:owner:]):
1768         (+[LocalPasteboard alloc]):
1769         (-[LocalPasteboard init]):
1770         (-[LocalPasteboard dealloc]):
1771         (-[LocalPasteboard name]):
1772         (-[LocalPasteboard releaseGlobally]):
1773         (-[LocalPasteboard declareTypes:owner:]):
1774         (-[LocalPasteboard addTypes:owner:]):
1775         (-[LocalPasteboard changeCount]):
1776         (-[LocalPasteboard types]):
1777         (-[LocalPasteboard availableTypeFromArray:]):
1778         (-[LocalPasteboard setData:forType:]):
1779         (-[LocalPasteboard dataForType:]):
1780         (-[LocalPasteboard setPropertyList:forType:]):
1781         (-[LocalPasteboard setString:forType:]):
1782         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
1783         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
1784         (+[DumpRenderTreeWindow allWindows]):
1785         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1786         (-[DumpRenderTreeWindow dealloc]):
1787         (-[DumpRenderTreeWindow isKeyWindow]):
1788         (-[DumpRenderTreeWindow keyDown:]):
1789
1790 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
1791
1792         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
1793         it indiscriminately copies any headers inside JavaScriptCore,
1794         which includes Tiger ICU headers. 
1795
1796         * wx/build-wxwebkit:
1797         Don't run WebCore/move-js-headers.sh any longer.
1798
1799 2007-11-20  Adam Treat  <treat@kde.org>
1800
1801         Reviewed by David Kilzer.
1802
1803         * Prepend git branch name to $baseProductDir
1804
1805         * Scripts/VCSUtils.pm:
1806         * Scripts/webkitdirs.pm:
1807
1808 2007-11-20  Mark Rowe  <mrowe@apple.com>
1809
1810         Reviewed by Simon Hausmann.
1811
1812         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
1813         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
1814         Have it trigger a "make distclean" rather than "make clean" to ensure that the
1815         built product and generated Makefile's are removed.
1816
1817 2007-11-19  Alp Toker  <alp@atoker.com>
1818
1819         Reviewed by Mark Rowe.
1820
1821         http://bugs.webkit.org/show_bug.cgi?id=16040
1822         [GTK] GtkLauncher should be written in C
1823
1824         Port GtkLauncher to plain C.
1825
1826         Use a more conventional GTK+ coding style.
1827
1828         Use a toolbar instead of menus.
1829
1830         Various signature fixes and cleanups.
1831
1832         Add a license header. Assume all previous modifications were copyright
1833         assigned to Apple Inc. by default.
1834
1835         * GtkLauncher/GtkLauncher.pro:
1836         * GtkLauncher/main.c: Added.
1837         (activate_url_entry_cb):
1838         (update_title):
1839         (link_hover_cb):
1840         (title_change_cb):
1841         (progress_change_cb):
1842         (destroy_cb):
1843         (go_back_cb):
1844         (go_forward_cb):
1845         (create_browser):
1846         (create_statusbar):
1847         (create_toolbar):
1848         (create_window):
1849         (main):
1850         * GtkLauncher/main.cpp: Removed.
1851
1852 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
1853
1854         Build script fixes to ensure they do the right thing for the 
1855         wx port, and update build-wxwebkit to reflect the way the
1856         build scripts now work.
1857
1858         Reviewed by Adam.
1859
1860         * Scripts/build-testkjs:
1861         * Scripts/build-webkit:
1862         * Scripts/run-javascriptcore-tests:
1863         * Scripts/webkitdirs.pm:
1864         * wx/build-wxwebkit:
1865
1866 2007-11-18  Eric Seidel  <eric@webkit.org>
1867
1868         Reviewed by Anders.
1869
1870         Make run-javascriptcore-tests report failures on exit (to support git bisect)
1871
1872         * Scripts/run-javascriptcore-tests:
1873
1874 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
1875
1876         Reviewed by Adam Roben.
1877
1878         Make run-webkit-tests work with Windows debug build.
1879
1880         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
1881         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
1882         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
1883         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
1884         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
1885
1886 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
1887
1888         Add wxWebKit sample and build script, and integrate it with 
1889         build-webkit. Also make build-webkit --clean work for all
1890         ports.
1891
1892         Reviewed by Darin Adler.
1893
1894         * Scripts/build-webkit:
1895         * Scripts/webkitdirs.pm:
1896         * wx: Added.
1897         * wx/browser: Added.
1898         * wx/browser/browser.bkl: Added.
1899         * wx/browser/browser.cpp: Added.
1900         * wx/build-wxwebkit: Added.
1901
1902 2007-11-17  Adam Roben  <aroben@apple.com>
1903
1904         Make it easy to run Safari in the debugger on Windows
1905
1906         I've added a new script, debug-safari, which launches Safari in the
1907         debugger. On OS X it just calls gdb-safari.
1908
1909         Reviewed by Mark Rowe.
1910
1911         * FindSafari/FindSafari.cpp:
1912         (_tmain): Added a /debugger flag, which in combination with
1913         /printSafariLauncher will print a script that launches Safari in the
1914         debugger.
1915         * Scripts/debug-safari: Added.
1916         * Scripts/run-safari: Changed to call runSafari().
1917         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
1918         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
1919         first argument along to FindSafari.
1920         * Scripts/webkitdirs.pm:
1921         (sub runSafari): Added.
1922
1923 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
1924
1925         Reviewed by Adam Roben.
1926
1927         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
1928
1929 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
1930
1931         Reviewed by David Kilzer.
1932
1933         The git config command was renamed to repo-config at some point. This
1934         change tries git config and then git repo-config if the first fails.
1935
1936         * Scripts/prepare-ChangeLog:
1937         (gitConfig):
1938
1939 2007-11-16  Dan Bernstein  <mitz@apple.com>
1940
1941         Reviewed by Darin Adler and Sam Weinig.
1942
1943         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
1944
1945         * DumpRenderTree/win/EventSender.cpp:
1946         (keyDownCallback): For characters that cannot be entered on the active
1947         keyboard layout, send a WM_CHAR message with the character along with
1948         a WM_KEYDOWN message with a virtual key code of 255.
1949
1950 2007-11-16  Mark Rowe  <mrowe@apple.com>
1951
1952         Reviewed by Tim Hatcher.
1953
1954         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
1955
1956         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1957         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1958
1959 2007-11-15  Adam Roben  <aroben@apple.com>
1960
1961         Make run-safari actually work on Windows
1962
1963         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
1964         chdir call.
1965
1966 2007-11-14  Adam Roben  <aroben@apple.com>
1967
1968         Updates to Safari launching now that 3.0.4 is released
1969
1970         Reviewed by Sam.
1971
1972         * FindSafari/FindSafari.cpp:
1973         (getWebViewCLSID): Use version-independent ProgID.
1974         * Scripts/run-safari: Use run-webkit-nightly.cmd.
1975
1976 2007-11-14  Anders Carlsson  <andersca@apple.com>
1977
1978         Reviewed by Adam.
1979
1980         <rdar://problem/5309081>
1981         In DRT, "plugin.logDestroy = true" not working on Windows.
1982         
1983         * DumpRenderTree/win/TestNetscapePlugin/main.c:
1984         (NPP_Destroy):
1985
1986 2007-11-14  Eric Seidel  <eric@webkit.org>
1987
1988         Reviewed by Sam.
1989
1990         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
1991
1992 2007-11-14  Anders Carlsson  <andersca@apple.com>
1993
1994         Reviewed by Adam.
1995
1996         <rdar://problem/5141186>
1997         window.layoutTestController.setWindowIsKey is not implemented in DRT.
1998         
1999         Implement setWindowIsKey.
2000         
2001         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2002         (LayoutTestController::setWindowIsKey):
2003
2004 2007-11-13  Sam Weinig  <sam@webkit.org>
2005
2006         Reviewed by Adam Roben.
2007
2008         Fix for <rdar://problem/5382579>
2009         http/tests/security/cross-frame-access-put.html reports large 
2010         negative numbers for screenLeft and screenTop (Mac reports "0")
2011
2012         * DumpRenderTree/win/UIDelegate.cpp:
2013         (UIDelegate::UIDelegate): Initialize the RECT.
2014         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
2015         (UIDelegate::webViewFrame): ditto.
2016         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
2017
2018 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
2019
2020         Reviewed by Adam.
2021
2022         - Make Drosera show source, source URLs, and function stack on Windows,
2023         and some minor fixes.
2024
2025         * Drosera/DebuggerDocument.cpp: Force source to always update display.
2026         (DebuggerDocument::updateFileSource):
2027         * Drosera/debugger.js: Force source to always update display.
2028         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
2029         menu controls.
2030         (DebuggerClient::resume):
2031         (DebuggerClient::pause):
2032         (DebuggerClient::stepInto):
2033         (DebuggerClient::stepOver):
2034         (DebuggerClient::stepOut):
2035         (DebuggerClient::showConsole):
2036         (DebuggerClient::closeCurrentFile):
2037         * Drosera/win/DebuggerClient.h: Ditto.
2038         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
2039         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
2040         removed two bugs.  1) caller could be in a bad state when asked to
2041         assign into it. 2) BSTRs were not created correctly.
2042         (DebuggerDocument::getPlatformCurrentFunctionStack):
2043         * Drosera/win/Drosera.cpp: Hook up the menu controls.
2044         (droseraWndProc):
2045         (handleCommand):
2046         (Drosera::resume):
2047         (Drosera::pause):
2048         (Drosera::stepInto):
2049         (Drosera::stepOver):
2050         (Drosera::stepOut):
2051         (Drosera::showConsole):
2052         (Drosera::closeCurrentFile):
2053         * Drosera/win/Drosera.h: Hook up the menu controls.
2054         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
2055         functions, added a null check, and fixed another bug where caller could
2056         be in a bad state when asked to assign into it.
2057         (ServerConnection::didLoadMainResourceForDataSource):
2058         (ServerConnection::getCallerFrame):
2059         * Drosera/win/ServerConnection.h: Safety first.
2060
2061 2007-11-13  Dan Bernstein  <mitz@apple.com>
2062
2063         Reviewed by Darin Adler.
2064
2065         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
2066           DumpRenderTree --pixel-tests renders each test twice
2067
2068         * DumpRenderTree/mac/DumpRenderTree.mm:
2069         (dumpRenderTree): Removed the --paint option because the painting code
2070         is always exercised as a result of
2071         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
2072         calling -displayIfNeeded.
2073         (dump): Changed to always grab the image from the window since the view
2074         is always displayed.
2075         (runTest):
2076         (displayWebView):
2077         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
2078         because it always paints.
2079
2080 2007-11-12  Antti Koivisto  <antti@apple.com>
2081
2082         Reviewed by Adele.
2083         
2084         Add support for http media tests
2085
2086         * Scripts/run-webkit-tests:
2087
2088 2007-11-12  Sam Weinig  <sam@webkit.org>
2089
2090         Reviewed by Adam Roben.
2091
2092         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
2093
2094         * DumpRenderTree/win/DumpRenderTree.cpp:
2095         (runTest):
2096         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2097         (LayoutTestController::setPrivateBrowsingEnabled):
2098
2099 2007-11-12  Adam Roben  <aroben@apple.com>
2100
2101         * Scripts/update-webkit-localizable-strings: Changed to only scan the
2102         mac and win subdirectories.
2103
2104 2007-11-11  Adam Roben  <aroben@apple.com>
2105
2106         Fix <rdar://5133816> keepWebHistory is not implemented
2107
2108         Fixes fast/history/clicked-link-is-visited.html.
2109
2110         Reviewed by Darin.
2111
2112         * DumpRenderTree/win/DumpRenderTree.cpp:
2113         (runTest): Clear the optionalSharedHistory.
2114         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2115         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
2116
2117 2007-11-10  Sam Weinig  <sam@webkit.org>
2118
2119         Reviewed by Tim Hatcher.
2120
2121         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
2122         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
2123         is turned on)
2124
2125         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
2126
2127         Added test: http/tests/security/cross-frame-access-private-browsing.html
2128
2129         * DumpRenderTree/LayoutTestController.cpp:
2130         (setPrivateBrowsingEnabledCallback):
2131         (LayoutTestController::staticFunctions):
2132         * DumpRenderTree/LayoutTestController.h:
2133         * DumpRenderTree/mac/DumpRenderTree.mm:
2134         (runTest): Default to private browsing disabled.
2135         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2136         (LayoutTestController::setPrivateBrowsingEnabled):
2137         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2138         (LayoutTestController::setPrivateBrowsingEnabled):
2139
2140 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2141
2142         Reviewed by Adam.
2143
2144         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
2145         WebCore's!
2146
2147         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
2148         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
2149         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
2150         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
2151         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
2152         * Drosera/win/Drosera.cpp:
2153         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2154
2155 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2156
2157         Reviewed by Sam.
2158
2159         - Use the new IWebFrame [local] function signature and get the shared
2160         server correctly.
2161
2162         * Drosera/win/DebuggerClient.cpp:
2163         (DebuggerClient::didFinishLoadForFrame):
2164         * Drosera/win/ServerConnection.cpp:
2165         (ServerConnection::attemptToCreateServerConnection):
2166
2167 2007-11-07  Dan Bernstein  <mitz@apple.com>
2168
2169         Reviewed by Darin Adler.
2170
2171         - add an option to run-webkit-tests to ignore pixel test failures where
2172           all pixels differ by no more than a specified threshold
2173
2174         * DumpRenderTree/mac/ImageDiff.m:
2175         (main):
2176         (compareImages):
2177         (computePercentageDifferent):
2178         * Scripts/run-webkit-tests:
2179
2180 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2181
2182         Reviewed by Lars.
2183
2184         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
2185
2186         * DumpRenderTree/qt/DumpRenderTree.cpp:
2187
2188 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2189
2190         Reviewed by Lars.
2191
2192         Reworked the QWebSettings API.
2193         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
2194
2195         * DumpRenderTree/qt/DumpRenderTree.cpp:
2196
2197 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2198
2199         Reviewed by Lars.
2200
2201         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
2202
2203         * DumpRenderTree/qt/jsobjects.cpp:
2204
2205 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2206
2207         Reviewed by Lars Knoll <lars@trolltech.com>.
2208
2209         Add a QWebPage::frameCreated() signal and fix DRT
2210         
2211         The removal of createFrame in QWebPage broke the re-implementation
2212         in DumpRenderTree. Instead emit a frameCreated() signal and
2213         connect to it in DumpRenderTree.
2214         
2215
2216         * DumpRenderTree/qt/DumpRenderTree.cpp:
2217         (WebCore::WebPage::WebPage):
2218         (WebCore::DumpRenderTree::dump):
2219         (WebCore::DumpRenderTree::connectFrame):
2220         * DumpRenderTree/qt/DumpRenderTree.h:
2221
2222 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2223
2224         Reviewed by Lars Knoll <lars@trolltech.com>.
2225
2226         Moved all the event handlers from QWebFrame into QWebPage.
2227         
2228         This cleans up the public API and allows us to remove the
2229         HackWebFrame hack in DumpRenderTree.
2230         
2231
2232         * DumpRenderTree/qt/jsobjects.cpp:
2233         (EventSender::mouseDown):
2234         (EventSender::mouseUp):
2235         (EventSender::mouseMoveTo):
2236
2237 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2238
2239         Reviewed by Mark.
2240
2241         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
2242         to prevent the default implementation from popping up messageboxes.
2243
2244         * DumpRenderTree/qt/DumpRenderTree.cpp:
2245         (WebCore::WebPage::javaScriptConfirm):
2246         (WebCore::WebPage::javaScriptPrompt):
2247
2248 2007-11-06  Eric Seidel  <eric@webkit.org>
2249
2250         * Scripts/build-testkjs: build fix... too many $$
2251
2252 2007-11-06  Eric Seidel  <eric@webkit.org>
2253
2254         Reviewed by Mark Rowe.
2255
2256         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
2257
2258 2007-11-05  Adam Roben  <aroben@apple.com>
2259
2260         Add support on Windows for WEBKIT_TESTFONTS
2261
2262         This environment variable lets you specify where the fonts to be used
2263         by DumpRenderTree reside. The Qt port is already using this, so I'm
2264         just following their lead.
2265
2266         Reviewed by Darin.
2267
2268         * DumpRenderTree/win/DumpRenderTree.cpp:
2269         (exePath): Refactored code out of initialize().
2270         (fontsPath): Returns either $WEBKIT_TESTFONTS or
2271         DumpRenderTree.resources.
2272         (initialize): Use the new fontsPath function.
2273         (main): Use the new exePath function.
2274         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
2275         variable to DRT, like Qt does.
2276
2277 2007-11-05  Mark Rowe  <mrowe@apple.com>
2278
2279         Rubber-stamped by Alp Toker.
2280
2281         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
2282
2283         * GtkLauncher/main.cpp:
2284         (goToURLBarText):
2285         (main):
2286
2287 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
2288
2289         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
2290         <http://bugs.webkit.org/show_bug.cgi?id=15830>
2291
2292         Reviewed by Timothy.
2293
2294         Restrict the range of nightly builds used by the bisect-builds script
2295         based on the version of Safari and the version of Mac OS X being used.
2296
2297         Mac OS X 10.4: Safari 2.0: r11976 or newer
2298         Mac OS X 10.4: Safari 3.0: r19992 or newer
2299
2300         Mac OS X 10.5: Safari 2.0: r19594 or newer
2301         Mac OS X 10.5: Safari 3.0: r25124 or newer
2302
2303         * Scripts/bisect-builds:
2304         (findMacOSXVersion): Added.
2305         (makeNightlyList): Added argument to provide version of Mac OS X.
2306         Restrict range of nightly builds based on Safari and Mac OS X versions.
2307
2308 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
2309
2310         Reviewed by Maciej.
2311
2312         - This patch involves several changes, all of them were noticed that
2313         they were needed by the work being done in WebKit to get Drosera and
2314         WebKit working together on Windows.
2315         - The changes are:
2316         1) Added a debugger console for output messages.
2317         2) Drosera now listens for the WebKit server (before, the server would
2318         have to be running before Drosera was started.)
2319         3) Fixed a bug where the WebView started out as 0x0 pixels.
2320         4) Fixed a bug when there is no scope.
2321         5) Added the HTML, JS, and CSS to the project file to make them easy to
2322         find.
2323         6) Made the ServerConnection functions virtual.
2324
2325         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
2326         for the WebKit server.
2327         (DebuggerClient::DebuggerClient):
2328         (DebuggerClient::~DebuggerClient):
2329         (DebuggerClient::didFinishLoadForFrame):
2330         (DebuggerClient::serverConnected):
2331         (DebuggerClient::attemptToCreateServerConnection):
2332         * Drosera/win/DebuggerClient.h: Ditto.
2333         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
2334         scope.
2335         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2336         (DebuggerDocument::platformValueForScopeVariableNamed):
2337         * Drosera/win/Drosera.cpp:
2338         (_tWinMain): Added a console in debug for output messages.
2339         (Drosera::Drosera): Listen for server.
2340         (Drosera::initUI): The server now Initializes COM.
2341         (Drosera::serverConnected): Part of the listening for the server.
2342         (Drosera::attemptToCreateServerConnection): Ditto.
2343         * Drosera/win/Drosera.h: New interface for listening for the server.
2344         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
2345         files to the VS project.
2346         * Drosera/win/ServerConnection.cpp: Part of listening for the server
2347         connection.
2348         (ServerConnection::ServerConnection):
2349         (ServerConnection::attemptToCreateServerConnection):
2350         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
2351         methods.
2352         (ServerConnection::serverConnected):
2353
2354 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
2355
2356         Reviewed by Maciej.
2357
2358         http://bugs.webkit.org/show_bug.cgi?id=15832
2359         fast/dom/gc-10.html crashes when run alone
2360
2361         Check for !done before using objects that can be already deallocated.
2362
2363         * DumpRenderTree/mac/EditingDelegate.mm:
2364         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2365         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2366         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2367         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2368         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2369         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2370         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2371         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2372         (-[EditingDelegate webViewDidBeginEditing:]):
2373         (-[EditingDelegate webViewDidChange:]):
2374         (-[EditingDelegate webViewDidEndEditing:]):
2375         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2376         (-[EditingDelegate webViewDidChangeSelection:]):
2377         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2378         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2379         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2380         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2381         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2382         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2383         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2384         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2385         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2386         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2387         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2388         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2389         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2390         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2391         (-[FrameLoadDelegate webView:willCloseFrame:]):
2392         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2393         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2394         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2395         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2396         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2397         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2398         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2399         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2400         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2401
2402 2007-11-04  Mark Rowe  <mrowe@apple.com>
2403
2404         Build fix.  Don't use Carbon.h as the prefix header as it triggers
2405         warnings that would otherwise be suppressed due to it being a system header.
2406
2407         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2408
2409 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
2410
2411         Rubber stamped by Adam.
2412         
2413         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
2414
2415         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2416
2417 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2418
2419         Sort files(...); sections of Xcode project files.
2420
2421         Rubber-stamped by Darin.
2422
2423         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
2424         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2425         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2426         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2427
2428 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2429
2430         Script to sort "files(...);" sections in Xcode project.pbxproj files.
2431
2432         Reviewed by Darin.
2433
2434         * Scripts/sort-Xcode-project-file: Added.
2435
2436 2007-11-02  Darin Adler  <darin@apple.com>
2437
2438         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
2439
2440 2007-11-02  Darin Adler  <darin@apple.com>
2441
2442         Reviewed by Maciej.
2443
2444         * Scripts/run-sunspider: Pass the "--base" option through.
2445
2446         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
2447         the real script do that. Default configuration to Release to match run-sunspider
2448         so we don't end up building Debug just to compare results.
2449
2450 2007-11-01  Adam Roben  <aroben@apple.com>
2451
2452         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
2453
2454         Reviewed by Sam.
2455
2456         * Scripts/commit-log-editor: Show all the directories beneath the
2457         source root, instead of just the last one.
2458
2459 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
2460
2461         Reviewed by Adam Roben.
2462
2463         Print out an error message when the Windows build fails
2464         and provide guidance on how to find out what went wrong.
2465
2466         * Scripts/build-webkit:
2467         * Scripts/webkitdirs.pm:
2468
2469 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
2470
2471         Rubber-stamped by Adam Roben.
2472
2473         Rolled out r27326 - debug CRT seems to cause no problems after all.
2474
2475         * DumpRenderTree/win/DumpRenderTree.vcproj:
2476
2477 2007-10-31  Adam Roben  <aroben@apple.com>
2478
2479         Switch the Debug configuration to using the non-debug CRT
2480
2481         This matches WebKit.
2482
2483         Reviewed by Steve.
2484
2485         * DumpRenderTree/win/DumpRenderTree.vcproj:
2486
2487 2007-10-31  Antti Koivisto  <antti@apple.com>
2488
2489         Reviewed by bdash.
2490         
2491         Disable media tests when doing leak checking on Tiger.
2492         They crash in QuickTime (rdar://problem/5537157).
2493
2494         * Scripts/run-webkit-tests:
2495
2496 2007-10-29  Antti Koivisto  <antti@apple.com>
2497
2498         Reviewed by Maciej.
2499         
2500         Build media support by default on OSX only.
2501
2502         * Scripts/build-webkit:
2503
2504 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2505
2506         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
2507         get caught by the pre-commit hooks.
2508
2509 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2510
2511         Reviewed by Adam.
2512
2513         - This is a collection of relatively unrelated changes and cleanups
2514         to Drosera to prepare it for interacting with WebKit.  A lot of these
2515         changes are just correcting mistakes, for example removing included
2516         headers that are no longer needed.
2517
2518         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
2519         this will be needed by the DebuggerClient.
2520         (DebuggerDocument::server):
2521         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
2522         * Drosera/win/DebuggerClient.cpp: 
2523         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
2524         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
2525         (DebuggerClient::createWebViewWithRequest): Added comment about its
2526         purpose. 
2527         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
2528         declarations.
2529         (DebuggerClient::webViewLoaded): Moved.
2530         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
2531         file, since this was the only place it was used.
2532         (cfStringToBSTR):
2533         * Drosera/win/Drosera.h: Cleaned up the includes.
2534         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
2535         * Drosera/win/HelperFunctions.h: Removed.
2536
2537 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2538
2539         Reviewed by Adam.
2540
2541         - Small cleanup in the ServerConnection class.
2542
2543         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
2544         and added an include.
2545         (ServerConnection::currentFrame):
2546         (ServerConnection::getCallerFrame):
2547         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
2548         made a pointer into a COMPtr, and cleaned up the includes.
2549
2550 2007-10-29  Timothy Hatcher  <timothy@apple.com>
2551
2552         Reviewed by John Sullivan.
2553         
2554         - Place the Localizable.strings file in mac or win directories
2555           if that location exists.
2556         - Also look for UI_STRING in .c files.
2557
2558         * Scripts/extract-localizable-strings:
2559
2560 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2561
2562         Reviewed by Adam.
2563
2564         - Set the eol-style to native and made all the line endings the same
2565         so that I avoid messy diffs that show eol changes.
2566
2567         * Drosera/win/ServerConnection.cpp:
2568         (ServerConnection::didParseSource):
2569         (ServerConnection::didEnterCallFrame):
2570         (ServerConnection::willExecuteStatement):
2571         (ServerConnection::willLeaveCallFrame):
2572         (ServerConnection::exceptionWasRaised):
2573
2574 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2575
2576         Reviewed by Adam.
2577
2578         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
2579         functionality that could not have existed previously without the new
2580         interfaces.
2581         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
2582         from a BSTR to a JSValueRef.
2583         (DebuggerDocument::platformEvaluateScript): Implemented.
2584         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
2585         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2586         Implemented.
2587         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
2588         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
2589         * Drosera/win/ServerConnection.cpp: Added a helper function.
2590         (ServerConnection::getCallerFrame):
2591         * Drosera/win/ServerConnection.h: Added a helper function.
2592
2593 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2594
2595         updated reviewers for my previous changelog.
2596
2597 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2598         Reviewed by Maciej and Adam and Geoff.
2599
2600         - Minor mac-side improvements including moving a function to a more
2601         appropriate location, fixing a warning, and correctly checking
2602         exceptions.
2603
2604         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
2605         (DebuggerDocument::willExecuteStatement):
2606         (DebuggerDocument::didEnterCallFrame):
2607         (DebuggerDocument::willLeaveCallFrame):
2608         (DebuggerDocument::windowScriptObjectAvailable):
2609         (DebuggerDocument::callFunctionOnObject):
2610         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
2611         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
2612         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
2613         because it doesn't require the ServerConnection at all.
2614         (NSStringCreateWithJSStringRef): Made an argument const.
2615         (JSValueRefCreateWithNSString): Made an argument const.
2616         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
2617         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2618         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
2619         * Drosera/mac/ServerConnection.mm: Ditto.
2620         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2621
2622 2007-10-29  Sam Weinig  <sam@webkit.org>
2623
2624         Reviewed by Adam Roben.
2625
2626         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
2627
2628         * DumpRenderTree/LayoutTestController.cpp:
2629         (LayoutTestController::LayoutTestController):
2630         (getGlobalFlagCallback):
2631         (setGlobalFlagCallback):
2632         (LayoutTestController::getJSClass):
2633         (LayoutTestController::staticValues):
2634         * DumpRenderTree/LayoutTestController.h:
2635         (LayoutTestController::globalFlag):
2636         (LayoutTestController::setGlobalFlag):
2637
2638 2007-10-29  Darin Adler  <darin@apple.com>
2639
2640         Reviewed by Maciej.
2641
2642         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
2643         resolution instead of its default.
2644
2645 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
2646
2647         Fixed showStatus() to print status for successfully resolved conflicts when using git.
2648
2649         Reviewed by Mark Rowe.
2650
2651         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
2652         was successfully resolved, but this would not show any status because the change had
2653         already been cached in the index using "git add".  The solution is to add an optional
2654         second argument to showStatus() which adds the "--cached" switch to the command.
2655
2656         * Scripts/resolve-ChangeLogs:
2657         (showStatus):
2658
2659 2007-10-28  Eric Seidel  <eric@webkit.org>
2660
2661         Reviewed by Maciej and Geoff, in unison.
2662
2663         * Scripts/run-webkit-tests: remove broken --svg option
2664
2665 2007-10-28  Darin Adler  <darin@apple.com>
2666
2667         Reviewed by Adam.
2668
2669         * Scripts/run-sunspider: Default to "Release" configuration rather than
2670         defaulting to the last configuration used as other scripts do. This can
2671         still be overriden on the command line with "--debug" if there's some
2672         reason to do so. Also fix a typo.
2673
2674         * Scripts/sunspider-compare-results: Fix a typo.
2675
2676 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
2677
2678         Reviewed by Adam.
2679
2680         - Implemented the WebScriptDebugListener functions now that the
2681         WebScriptDebugServer exists
2682
2683         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
2684         functions.
2685         (ServerConnection::currentFrame):
2686         (ServerConnection::didLoadMainResourceForDataSource):
2687         (ServerConnection::didParseSource):
2688         (ServerConnection::failedToParseSource):
2689         (ServerConnection::didEnterCallFrame):
2690         (ServerConnection::willExecuteStatement):
2691         (ServerConnection::willLeaveCallFrame):
2692         (ServerConnection::exceptionWasRaised):
2693         * Drosera/win/ServerConnection.h: Removed unused arguments from the
2694         members arguments list.
2695
2696 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
2697
2698         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
2699         <http://bugs.webkit.org/show_bug.cgi?id=15600>
2700
2701         Reviewed by Darin.
2702
2703         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
2704         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
2705         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
2706         file.  Note that it may also be used as a stand-alone script.
2707
2708         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
2709         * Scripts/resolve-ChangeLogs: Added.
2710         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
2711
2712 2007-10-26  Mark Rowe  <mrowe@apple.com>
2713
2714         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
2715         to the Qt port on the assumption that it was an implementation of the cross-platform
2716         LayoutTestController class.  It is not, so it did not need to be changed.
2717
2718         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
2719
2720 2007-10-25  Mark Rowe  <mrowe@apple.com>
2721
2722         Reviewed by Maciej.
2723
2724         Fix builds with code coverage enabled.
2725
2726         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
2727
2728 2007-10-25  Darin Adler  <darin@apple.com>
2729
2730         Reviewed by Mark Rowe.
2731
2732         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
2733         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
2734
2735 2007-10-25  Stephanie  <slewis@apple.com>
2736
2737         build Fix
2738
2739         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2740
2741 2007-10-25  Stephanie  <slewis@apple.com>
2742
2743         Reviewed by Mark Rowe, Adam Roben.
2744
2745         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
2746
2747         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
2748
2749 2007-10-25  Alice Liu  <alice.liu@apple.com>
2750
2751         Reviewed by Adam.
2752
2753         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
2754
2755         Moving destructor into platform-specific files
2756         * DumpRenderTree/LayoutTestController.cpp:
2757         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2758         (LayoutTestController::~LayoutTestController):
2759         * DumpRenderTree/qt/jsobjects.cpp:
2760         (LayoutTestController::~LayoutTestController):
2761
2762         LayoutTestController wasn't being destroyed
2763         * DumpRenderTree/win/DumpRenderTree.cpp:
2764         (runTest):
2765
2766         Added declspec
2767         * DumpRenderTree/win/EditingDelegate.h:
2768
2769         Reset certain values on the webview (or related delegate) that might 
2770         have changed while running a test
2771         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2772         (LayoutTestController::~LayoutTestController):
2773
2774 2007-10-25  Adam Roben  <aroben@apple.com>
2775
2776         Make sunspider-compare-results work with relative paths
2777
2778         Reviewed by Sam.
2779
2780         * Scripts/sunspider-compare-results: Convert arguments to absolute
2781         paths before we chdir.
2782
2783 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
2784
2785         Reviewed by Sam.
2786
2787         - Implemented server calls now the WebScriptDebugServer exists.
2788         - Also removed no longer needed call to initialize CG.
2789
2790         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
2791         automatically now.
2792         (_tWinMain):
2793         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
2794         (ServerConnection::ServerConnection):
2795         (ServerConnection::~ServerConnection):
2796         (ServerConnection::pause):
2797         (ServerConnection::resume):
2798         (ServerConnection::stepInto):
2799         (ServerConnection::applicationTerminating):
2800         (ServerConnection::serverConnectionDidDie):
2801         * Drosera/win/ServerConnection.h: Now uses the COM class.
2802
2803 2007-10-24  George Staikos  <staikos@kde.org>
2804
2805         Unbreak Qt build.
2806
2807         * Scripts/build-webkit:
2808
2809 2007-10-24  Adam Roben  <aroben@apple.com>
2810
2811         Remove now-unnecessary call to InitializeCoreGraphics
2812
2813         WebKit takes care of this now.
2814
2815         Reviewed by Ada.
2816
2817         * DumpRenderTree/win/DumpRenderTree.cpp:
2818         (initialize):
2819
2820 2007-10-24  Adam Roben  <aroben@apple.com>
2821
2822         Use WebTextRenderer in DRT
2823
2824         Reviewed by Ada.
2825
2826         * DumpRenderTree/win/DumpRenderTree.cpp:
2827         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
2828
2829 2007-10-24  Sven Herzberg  <sven@imendio.com>
2830
2831         Reviewed by Mark Rowe.
2832
2833         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
2834         Bug 15614: [GTK] qmake based backends don't build on OS X
2835
2836         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
2837         GTK backend on a Mac
2838         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
2839         isDarwin() to make it reusable in other places (like the workaround-
2840         for-prebuilt-qmake in build-webkit)
2841
2842 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2843
2844         Refurbish update-webkit script.
2845
2846         Reviewed by Adam.
2847
2848         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
2849         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
2850         multi-argument version of system() for flexibility and security.  Check for existence
2851         of Internal directory using -d test instead of -x.
2852
2853 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2854
2855         Minor clean-up of prepare-ChangeLog script.
2856
2857         Reviewed by Adam.
2858
2859         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
2860         of a string.  Use multi-argument versions of open() and system() for flexibility and
2861         security.
2862
2863 2007-10-24  Alice Liu  <alice.liu@apple.com>
2864
2865         Reviewed by Oliver.
2866
2867         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
2868
2869         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
2870         replay the saved events when we're still processing the mousedown that starts the drag
2871         * DumpRenderTree/win/EventSender.cpp:
2872         (doMouseMove):
2873         * DumpRenderTree/win/UIDelegate.cpp:
2874         (UIDelegate::doDragDrop):
2875
2876 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
2877
2878         Reviewed by Sam, Steve and Darin.
2879
2880         - Stubbed out the WebScriptDebugListener functionality in the Server
2881         Connection class to prepare it for receiving those callbacks.
2882         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
2883         and the ServerConnection to not need to be initialized with a server
2884         name, since that is not the way we connect to the WebKit server. 
2885
2886         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
2887         no exception.  Now it only loggs when there is an exception
2888         (DebuggerDocument::willExecuteStatement):
2889         (DebuggerDocument::didEnterCallFrame):
2890         (DebuggerDocument::willLeaveCallFrame):
2891         (DebuggerDocument::windowScriptObjectAvailable):
2892         (DebuggerDocument::callFunctionOnObject):
2893         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
2894         to be instantiated with a server's name.
2895         (DebuggerClient::DebuggerClient):
2896         (DebuggerClient::didFinishLoadForFrame):
2897         * Drosera/win/DebuggerClient.h: Removed unsued variable.
2898         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
2899         a server name.
2900         (Drosera::init):
2901         (Drosera::initServer):
2902         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
2903         instantiated with a server's name.
2904         * Drosera/win/ServerConnection.cpp: 
2905         (ServerConnection::ServerConnection): No longer needs a server name
2906         (ServerConnection::~ServerConnection): Only release the global context
2907         if there is one.
2908         (ServerConnection::serverConnectionDidDie): Stub for
2909         IWebScriptDebugListener
2910         (ServerConnection::QueryInterface): ditto
2911         (ServerConnection::AddRef): ditto
2912         (ServerConnection::Release): ditto
2913         (ServerConnection::didLoadMainResourceForDataSource): ditto
2914         (ServerConnection::didParseSource): ditto
2915         (ServerConnection::failedToParseSource): ditto
2916         (ServerConnection::didEnterCallFrame): ditto
2917         (ServerConnection::willExecuteStatement): ditto
2918         (ServerConnection::willLeaveCallFrame): ditto
2919         (ServerConnection::exceptionWasRaised): ditto
2920         * Drosera/win/ServerConnection.h: Stubbed out the
2921         IWebScriptDebugListener functions, and this class no longer needs to be
2922         instantiated with a server name.
2923
2924 2007-10-24  Lars Knoll  <lars@trolltech.com>
2925
2926         Reviewed by Simon.
2927
2928         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
2929
2930         * DumpRenderTree/qt/jsobjects.h:
2931
2932 2007-10-24  Lars Knoll  <lars@trolltech.com>
2933
2934         Reviewed by Simon.
2935
2936         add another command.
2937
2938         * DumpRenderTree/qt/jsobjects.cpp:
2939         (TextInputController::doCommand):
2940
2941 2007-10-24  Lars Knoll  <lars@trolltech.com>
2942
2943         Reviewed by Simon.
2944
2945         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
2946
2947         * DumpRenderTree/qt/jsobjects.cpp:
2948         (EventSender::keyDown):
2949         * DumpRenderTree/qt/jsobjects.h:
2950
2951 2007-10-24  Lars Knoll  <lars@trolltech.com>
2952
2953         Reviewed by Simon.
2954
2955         implement eventSender.keyDown().
2956
2957         * DumpRenderTree/qt/jsobjects.cpp:
2958         (EventSender::keyDown):
2959
2960 2007-10-24  Lars Knoll  <lars@trolltech.com>
2961
2962         Reviewed by Simon.
2963
2964         some smaller fixes to the editing support in DRT. Makes another few tests pass.
2965
2966         * DumpRenderTree/qt/DumpRenderTree.cpp:
2967         (WebCore::DumpRenderTree::DumpRenderTree):
2968         (WebCore::DumpRenderTree::initJSObjects):
2969         * DumpRenderTree/qt/jsobjects.cpp:
2970         (TextInputController::doCommand):
2971
2972 2007-10-24  Lars Knoll  <lars@trolltech.com>
2973
2974         Reviewed by Simon.
2975
2976         first bit of implementation for the textinputcontroller.
2977
2978         * DumpRenderTree/qt/DumpRenderTree.cpp:
2979         (WebCore::DumpRenderTree::DumpRenderTree):
2980         * DumpRenderTree/qt/DumpRenderTree.h:
2981         * DumpRenderTree/qt/jsobjects.cpp:
2982         (TextInputController::TextInputController):
2983         (TextInputController::doCommand):
2984         * DumpRenderTree/qt/jsobjects.h:
2985
2986 2007-10-24  Lars Knoll  <lars@trolltech.com>
2987
2988         Reviewed by Simon.
2989
2990         make the man webpage believe it has focus, so the editing tests work correctly.
2991
2992         * DumpRenderTree/qt/DumpRenderTree.cpp:
2993         (WebCore::DumpRenderTree::DumpRenderTree):
2994
2995 2007-10-24  Lars Knoll  <lars@trolltech.com>
2996
2997         Reviewed by Simon.
2998
2999         implement layoutTestController.dumpEditingCallbacks() correctly.
3000
3001         * DumpRenderTree/qt/DumpRenderTree.cpp:
3002         (WebCore::DumpRenderTree::DumpRenderTree):
3003         * DumpRenderTree/qt/jsobjects.cpp:
3004         (LayoutTestController::reset):
3005         (LayoutTestController::dumpEditingCallbacks):
3006
3007 2007-10-24  Lars Knoll  <lars@trolltech.com>
3008
3009         Reviewed by Simon.
3010
3011         Implement support for testing editing.
3012
3013         * DumpRenderTree/qt/DumpRenderTree.cpp:
3014         (WebCore::DumpRenderTree::DumpRenderTree):
3015
3016 2007-10-23  Sam Weinig  <sam@webkit.org>
3017
3018         Check for null BSTR that can be passed to the UIDelegate methods
3019         from javascript null and undefined.  Fixes a failing test case on
3020         Windows (fast/dom/Window/alert-undefined.html)
3021
3022         Reviewed by Eric Seidel.
3023
3024         * DumpRenderTree/win/UIDelegate.cpp:
3025         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3026         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3027         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3028         (UIDelegate::webViewAddMessageToConsole):
3029
3030 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3031
3032         Reviewed by Darin.
3033         
3034         Don't print a massive pile of setenvs from tools that automatically build testkjs.
3035
3036         * Scripts/build-testkjs:
3037
3038 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3039
3040         Reviewed by Darin.
3041
3042         - add wrapper that finds the right copy of testkjs
3043         
3044         * Scripts/sunspider-compare-results: Added.
3045
3046 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
3047
3048         Reviewed by Sam.
3049
3050         - After talking with Steve I now see that the WebKit server must be
3051         running for DCOM to create the distributed objects, which makes sense
3052         and currently WebKit only allows one instance to be running at a time
3053         which avoids accidentally connecting to the wrong server
3054         - In light of this I have removed the code for the attach box and
3055         NotificationServer and known server names, since they are all extranious
3056         now.
3057
3058         * Drosera/win/Drosera.cpp: Removed notification classes and known server
3059         names.
3060         (_tWinMain): Uses init instead of initUI.
3061         (droseraWndProc): No longer creats an attach dialog box.
3062         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
3063         it's not manditory to call init before doing COM stuff.
3064         (Drosera::init): calls initUI and will call attach when the
3065         functionality exists. 
3066         (Drosera::initUI): Has changed very little.
3067         (Drosera::attach): Changed the signature to reflect that we no longer
3068         need the dictionary of known server names.
3069         * Drosera/win/Drosera.h: Removed notification classes and known server
3070         names.  Also renamed and moved some functions.
3071         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
3072         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
3073         headers to the resources folder. 
3074         * Drosera/win/resource.h: Removed the Attach box.
3075
3076 2007-10-22  Adam Roben  <aroben@apple.com>
3077
3078         Windows build fix
3079
3080         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
3081
3082 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
3083
3084         - Removed a leak that was fixed.
3085
3086         * Scripts/run-webkit-tests:
3087
3088 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3089
3090         Reviewed by Darin.
3091
3092         - Changed the Client so that the DebuggerDocument now own the
3093         ServerConnection.  This simplifies ownership and cleanup. 
3094
3095         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
3096         ServerConnection.
3097         (DebuggerClient::initWithServerName):
3098         (DebuggerClient::didFinishLoadForFrame):
3099         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
3100         ServerConnection.
3101         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
3102         until after we have a server which we are attached to.
3103         (Drosera::initUI):
3104         (Drosera::attach):
3105         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
3106         out previously.
3107
3108 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3109
3110         Reviewed by Nikolas.
3111
3112         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
3113
3114         * Scripts/run-javascriptcore-tests:
3115
3116 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3117
3118         Reviewed by Nikolas.
3119
3120         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
3121
3122         * Scripts/build-drosera:
3123         * Scripts/build-dumprendertree:
3124         * Scripts/build-testkjs:
3125         * Scripts/build-webkit:
3126         * Scripts/run-javascriptcore-tests:
3127         * Scripts/run-sunspider:
3128         * Scripts/run-webkit-tests:
3129         * Scripts/webkitdirs.pm:
3130
3131 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
3132
3133         Reviewed by Mark Rowe.
3134         
3135         Fix for local database support after r26879
3136         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
3137
3138         * Scripts/build-webkit:
3139
3140 2007-10-22  Holger Freyther  <zecke@selfish.org>
3141
3142         Reviewed by Simon Hausmann <hausmann@kde.org>.
3143
3144         - Do not build testkjs as an application bundle. This is
3145         needed for run-javascriptcore-tests on OSX.
3146         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
3147         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
3148         as we do not have -rpath on OSX.
3149
3150         * DumpRenderTree/qt/DumpRenderTree.pro:
3151         * Scripts/run-webkit-tests:
3152
3153 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3154
3155         Reviewed by aroben.
3156
3157         Fix support for Signed-off-by detection in prepare-ChangeLog
3158         --git-commit. The Signed-off-by tag does not appear in the header
3159         but usually at the end.
3160
3161         * Scripts/prepare-ChangeLog:
3162
3163 2007-10-21  Mark Rowe  <mrowe@apple.com>
3164
3165         Reviewed by Eric.
3166
3167         Fix run-javascriptcore-tests for Gtk.
3168
3169         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
3170
3171 2007-10-20  Eric Seidel  <eric@webkit.org>
3172
3173         Reviewed by aroben.
3174
3175         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
3176
3177 2007-10-20  Eric Seidel  <eric@webkit.org>
3178
3179         Reviewed by darin.
3180         
3181         Add improved argument handling to run-sunspider, including
3182         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
3183         Also re-factor code into subroutines
3184
3185         * Scripts/build-dumprendertree: removed bogus comments
3186         * Scripts/build-testkjs: Added.
3187         * Scripts/run-javascriptcore-tests: use build-testkjs
3188         * Scripts/run-sunspider: improved argument handling, abstraction
3189         * Scripts/run-webkit-tests: improved abstraction
3190
3191 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
3192
3193         Not reviewed, Windows build fix.
3194
3195         * DumpRenderTree/win/EventSender.cpp:
3196         (keyDownCallback):
3197
3198 2007-10-20  Darin Adler  <darin@apple.com>
3199
3200         Reviewed by Tim Hatcher.
3201
3202         - http://bugs.webkit.org/show_bug.cgi?id=15544
3203           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
3204           not rely on Apple-specific key codes
3205
3206         * DumpRenderTree/mac/EventSendingController.mm:
3207         (-[EventSendingController keyDown:withModifiers:]):
3208         Added named key "rightArrow". Later we could have a whole table of these.
3209         Also tweaked modifiers code a little.
3210
3211         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
3212
3213 2007-10-19  Darin Adler  <darin@apple.com>
3214
3215         Reviewed by Eric.
3216
3217         - http://bugs.webkit.org/show_bug.cgi?id=15566
3218           possible fix for leak seen in DumpRenderTree
3219
3220         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
3221         Delete the item if it's not put on the queue, since the caller has
3222         no way of knowing that. Would be better to have the parameter type
3223         be auto_ptr to express the fact that we take ownership.
3224
3225         - unrelated change
3226
3227         * Drosera/mac/main.m: Add missing include.
3228
3229 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3230
3231         Reviewed by Adam.
3232
3233         - This change should be identical but for some reason was not working
3234         on my machine.
3235
3236         * Scripts/prepare-ChangeLog:
3237
3238 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3239
3240         Reviewed by Oliver and Tim.
3241
3242         - Made use of RetainPtr to avoid retain and release issues and moved the
3243         log function to DebuggerDocumentPlatform, which seems to be a more
3244         logical place for it to live.
3245         - Also moved knownServers from the ServerConnection to
3246         DebuggerApplication to match the Windows code and because it makes sense
3247         that a connection knows its own server but not all of them.
3248
3249         * Drosera/mac/DebuggerClient.h: Moved the log function to
3250           DebuggerDocumentPlatform.
3251         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
3252           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
3253           call for the server name up from the ServerConnection class.
3254         (-[DebuggerClient dealloc]):
3255         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
3256           for the server name up from the ServerConnection.
3257         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
3258         (DebuggerDocument::platformPause):
3259         (DebuggerDocument::platformResume):
3260         (DebuggerDocument::platformStepInto):
3261         (DebuggerDocument::platformEvaluateScript):
3262         (DebuggerDocument::getPlatformCurrentFunctionStack):
3263         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3264         (DebuggerDocument::platformValueForScopeVariableNamed):
3265         (DebuggerDocument::platformLog): Log directly from here. No need to call
3266           DebuggerClient.
3267         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
3268           way I see it, a ServerConnection should only know about its connection
3269           and the group of all possible servers should be kept by the
3270           application.
3271         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
3272           currentServerName, it makes sense that the connection should know that
3273           name.
3274         (-[ServerConnection currentServerName]):
3275
3276 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3277
3278         Reviewed by Adam.
3279
3280         - Integrated changes from mac drosera.  Recently I've encapsulated
3281         out the server connection object from the rest of Drosera because
3282         it is very platform dependent right now and RPC is not implemented on
3283         windows.  This functionality, of communicating with the WebKit server
3284         is the next area I will be focusing on in Windows.
3285
3286         - Other changes and cleanup were made to organize the code and add notes
3287         on which parts still need work.  Also some mac code is added and
3288         commented out, to act as pseudocode for the logic of those parts.
3289
3290         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
3291           pointer.
3292         * Drosera/config.h: Added whitespace.
3293         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
3294           these files got moved into Drosera.h/cpp
3295         * Drosera/win/DebuggerApplication.h: Removed.
3296         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
3297           happened here to better match the logic flow of the same code on the 
3298           mac side and to use the new ServerConnection class.
3299         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
3300         (DebuggerClient::initWithServerName): Initializer that will set up the
3301           class to use a ServerConnection object.  This was necessary so I could
3302           create a DebuggerClient without having to initilaize it at
3303           construction.
3304         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
3305           will be the UIDelegate and FrameLoadDelegate.
3306         (DebuggerClient::AddRef): For IUnknown.
3307         (DebuggerClient::Release): For IUnknown.
3308         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
3309           this still needs to set the global context of the server, but
3310           IWebFrame does not have an accessor for the global context yet. 
3311         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
3312           this is a pass through for the same function in the document.
3313         (DebuggerClient::didReceiveTitle): Unimplemented part of
3314           FrameLoadDelegate this would change the title of the window.
3315         (DebuggerClient::createWebViewWithRequest): Part of the
3316           FrameLoadDelegate.  This is about new windows via Window.open() and
3317           how their delegates are set.
3318         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
3319           UIDelegate.  Just a debug function for printing messages.
3320         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
3321           because the Client should be the UIDelegate and FrameLoadDelegate
3322           to match the delegates on mac.
3323         (DebuggerClient::webViewLoaded): Added accessor method.
3324         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
3325           forgotten to add this file before.  This is where the platform
3326           dependent versions of the Documents functions live. Most of these are
3327           unimplemented because some piece of functionality does not exist on
3328           Windows yet.
3329         (DebuggerDocument::platformPause):
3330         (DebuggerDocument::platformResume):
3331         (DebuggerDocument::platformStepInto):
3332         (DebuggerDocument::platformEvaluateScript):
3333         (DebuggerDocument::getPlatformCurrentFunctionStack):
3334         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3335         (DebuggerDocument::platformValueForScopeVariableNamed):
3336         (DebuggerDocument::platformLog):
3337         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
3338           responsibilities becaue they belong in the Client. Also I laid the
3339           groundwork for attaching Drosera to a WebKit process
3340         (attachWndProc): Now if a server is selected the Client becomes it's
3341           delegate.
3342         (Drosera::Drosera): Added the construction of the Client and dictionary
3343           of server names. 
3344         (Drosera::initUI): This is no longer the delegates, the Client is.
3345         (Drosera::webViewLoaded): Now asks the Client instead of holding local
3346           state. 
3347         (Drosera::applicationDidFinishLaunching): Placeholder for needed
3348           notification registration when it's possible to implement.
3349         (Drosera::serverLoaded): Ditto
3350         (Drosera::serverUnloaded): Ditto
3351         (Drosera::attach): Attach Drosera to the WebKit server.
3352         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
3353         (Drosera::getInst): 
3354         (Drosera::setInst):
3355         (Drosera::knownServers):
3356         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
3357           and added the ServerConnection.
3358         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
3359         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
3360           Most of the functions are completely unimlemented because they cannot
3361           connect with the WebKit server, because one does not exist on Windows
3362           yet.
3363         (ServerConnection::initWithServerName): 
3364         (ServerConnection::~ServerConnection):
3365         (ServerConnection::setGlobalContext):
3366         (ServerConnection::pause):
3367         (ServerConnection::resume):
3368         (ServerConnection::stepInto):
3369         (ServerConnection::switchToServerNamed):
3370         (ServerConnection::applicationTerminating):
3371         (ServerConnection::serverConnectionDidDie):
3372         (ServerConnection::currentFrame):
3373         * Drosera/win/ServerConnection.h: Added. Ditto.
3374         (ServerConnection::ServerConnection):
3375
3376 2007-10-19  Alice Liu  <alice.liu@apple.com>
3377
3378         Reviewed by Darin.
3379
3380         Fix for these broken layout tests on Windows:
3381         
3382         fast/forms/focus-selection-input.html
3383         fast/forms/focus-selection-textarea.html
3384         fast/forms/select-accesskey.html
3385         
3386         * DumpRenderTree/win/EventSender.cpp:
3387         (keyDownCallback):
3388         correct the VK code for alt key.
3389         
3390 2007-10-19  Eric Seidel  <eric@webkit.org>
3391
3392         Reviewed by Mark Rowe.
3393         
3394         Make the GtkLauncher code slightly more readable.
3395
3396         * GtkLauncher/main.cpp:
3397         (setupMainMenu): Added.
3398         (setupMainWindowUI): Added.
3399         (main):
3400
3401 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
3402
3403         Rubber stamped by Adam.
3404         
3405         - don't delay-load WebKit in DumpRenderTree.
3406
3407         * DumpRenderTree/win/DumpRenderTree.vcproj:
3408
3409 2007-10-18  Dan Bernstein  <mitz@apple.com>
3410
3411         Reviewed by Adam Roben.
3412
3413         - fix <rdar://problem/5313523>
3414         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
3415
3416         * DumpRenderTree/mac/DumpRenderTree.mm:
3417         (dump): Changed to use _responseMIMEType.
3418
3419 2007-10-17  Adam Roben  <aroben@apple.com>
3420
3421         Make it possible to have Windows-specific tests and results
3422
3423         When searching for tests to run and the Skipped file, we will only
3424         look in platform/win and the cross-platform directory. When looking
3425         for expected results, we will look in platform/win, then
3426         platform/mac-leopard, then platform/mac, then finally the
3427         cross-platform directory.
3428
3429         Reviewed by Sam.
3430
3431         * Scripts/run-webkit-tests:
3432         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
3433         searching in the cross-platform directory.
3434         (sub buildPlatformHierarchy): Removed some unneeded calls to
3435         dirname/basename.
3436
3437 2007-10-17  Adam Roben  <aroben@apple.com>
3438
3439         Add back the call to register WebKit that we had before WebKitInitializer existed
3440
3441         This is needed to ensure that the right WebKit is used when
3442         instantiating COM objects.
3443
3444         Reviewed by Oliver.
3445
3446         * DumpRenderTree/win/debug_internal.vsprops: Define
3447         DEBUG_WEBKIT_HAS_SUFFIX.
3448         * DumpRenderTree/win/DumpRenderTree.cpp:
3449         (initialize):
3450
3451 2007-10-17  Adam Roben  <aroben@apple.com>
3452
3453         Import File::Basename in webkitdirs since we use it
3454
3455         * Scripts/webkitdirs.pm:
3456
3457 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
3458
3459         - Updated the tiger leaks list to make the internal bots green.
3460
3461         * Scripts/run-webkit-tests:
3462
3463 2007-10-17  Adam Roben  <aroben@apple.com>
3464
3465         Build fix for VC++ Express
3466
3467         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
3468         and ole32.lib.
3469
3470 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3471
3472         Reviewed by Sam.
3473
3474         - Minor mac improvements based on observations I made while implementing the
3475         Windows code.
3476
3477         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
3478         then hand it to the Client who will retain it, it should just be the client who
3479         creates and owns the server.
3480         (-[DebuggerApplication attach:]):
3481         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
3482         * Drosera/mac/DebuggerClient.mm: Creates the server.
3483         (-[DebuggerClient initWithServerName:]):
3484         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
3485         can instead forward declare what it needs.
3486
3487 2007-10-16  Darin Adler  <darin@apple.com>
3488
3489         Reviewed by Geoff Garen.
3490
3491         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
3492         want to turn failing tests into platform-specific test results. Also did a
3493         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
3494         would take the type of results into account only some of the time.
3495
3496 2007-10-16  Adam Roben  <aroben@apple.com>
3497
3498         Add a new nightly launcher script for Windows
3499
3500         This new script is for versions of Safari that don't delay-load
3501         WebKit. I had to make FindSafari be able to print out the nightly
3502         launcher script on stdout because Windows shell scripts can't capture
3503         the output from a command into an environment variable.
3504
3505         Reviewed by Steve.
3506
3507         * FindSafari/FindSafari.cpp:
3508         (_tmain): Added /printSafariLauncher option.
3509         * Scripts/run-webkit-nightly.cmd: Added.
3510
3511 2007-10-16  Adam Roben  <aroben@apple.com>
3512
3513         Replace WebKitInitializer with FindSafari
3514
3515         We now rely on setting the PATH environment variable to tell Windows
3516         where to find WebKit and its dependencies (similar to
3517         DYLD_FRAMEWORK_PATH on Mac).
3518
3519         This change also make DumpRenderTree no longer delay-load WebKit.
3520
3521         Reviewed by Sam.
3522
3523         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
3524         FindSafari.
3525         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
3526         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
3527         WebKitInitializer, don't delay-load WebKit.
3528         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
3529         * Scripts/run-webkit-tests: Ditto.
3530         * Scripts/webkitdirs.pm:
3531         (sub setPathForRunningWebKitApp): Added.
3532         * WebKitInitializer/WebKitInitializer.cpp: Removed.
3533         * WebKitInitializer/WebKitInitializer.h: Removed.
3534         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
3535         * WebKitInitializer/debug.vsprops: Removed.
3536         * WebKitInitializer/debug_internal.vsprops: Removed.
3537         * WebKitInitializer/release.vsprops: Removed.
3538
3539 2007-10-16  Adam Roben  <aroben@apple.com>
3540
3541         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
3542
3543         http://bugs.webkit.org/show_bug.cgi?id=15532
3544
3545         FindSafari simply prints the location of an installed Safari.exe on
3546         stdout.
3547
3548         Reviewed by Darin.
3549
3550         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
3551         (getStringValue):
3552         (getWebViewCLSID):
3553         (getInstalledWebKitDirectory):
3554         (_tmain):
3555         * FindSafari/FindSafari.vcproj: Added.
3556         * Scripts/webkitdirs.pm:
3557         (sub installedSafariPath): Added. Calls FindSafari on Windows.
3558
3559 2007-10-16  Adam Roben  <aroben@apple.com>
3560
3561         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
3562
3563         Reviewed by Kevin McCullough.
3564
3565         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
3566         when referring to WebKit.dll.
3567         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
3568         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
3569         * DumpRenderTree/win/release.vsprops: Ditto.
3570         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
3571         never have a _debug suffix on WebKit.dll.
3572         * WebKitInitializer/WebKitInitializer.cpp:
3573         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
3574         specified.
3575         * WebKitInitializer/debug_internal.vsprops: Added
3576         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
3577
3578 2007-10-16  Darin Adler  <darin@apple.com>
3579
3580         Reviewed by Adele.
3581
3582         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
3583         Remove now-unneeded control/alt key hack; the tests have been updated.
3584
3585 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3586
3587         - Updated leaks list because our internal bot upgraded it's version of leopard and 
3588         one of the leaks was fixed between that revision and the bot's previous version of
3589         leopard.
3590
3591         * Scripts/run-webkit-tests:
3592
3593 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
3594
3595         Reviewed by Tim.
3596
3597         - I encapsulated out the server connecton functionality because it is a specific part
3598         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
3599         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
3600         Windows.  So the majority of this patch is moving preexisting functionality.
3601
3602         - Also I removed the prefix header and changed to use config.h because it is more
3603         standard on how we use config.h in windows and it didn't make much sense to keep
3604         the prefix header and the config.h
3605
3606         * Drosera/DebuggerDocument.cpp:
3607         (DebuggerDocument::DebuggerDocument):
3608         * Drosera/DebuggerDocument.h:
3609         * Drosera/config.h:
3610         * Drosera/mac/DebuggerApplication.mm:
3611         (-[DebuggerApplication attach:]):
3612         * Drosera/mac/DebuggerClient.h:
3613         * Drosera/mac/DebuggerClient.mm:
3614         (-[DebuggerClient initWithServerConnection:]):
3615         (-[DebuggerClient dealloc]):
3616         (-[DebuggerClient windowDidLoad]):
3617         (-[DebuggerClient windowWillClose:]):
3618         (-[DebuggerClient webView:didFinishLoadForFrame:]):
3619         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
3620         * Drosera/mac/DebuggerDocumentPlatform.mm:
3621         (DebuggerDocument::platformPause):
3622         (DebuggerDocument::platformResume):
3623         (DebuggerDocument::platformStepInto):
3624         (DebuggerDocument::platformEvaluateScript):
3625         (DebuggerDocument::getPlatformCurrentFunctionStack):
3626         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):