0a77a7be446291a4bd8adca48875b80393a88bec
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-11-25  Adam Barth  <abarth@webkit.org>
2
3         Reviewed by Eric Seidel.
4
5         Add unit test for mark-fixed
6         https://bugs.webkit.org/show_bug.cgi?id=31896
7
8         * Scripts/modules/commands/commandtest.py: Added.
9         * Scripts/modules/commands/queries_unittest.py:
10         * Scripts/modules/commands/upload_unittest.py: Added.
11         * Scripts/modules/mock_bugzillatool.py:
12         * Scripts/run-webkit-unittests:
13
14 2009-11-25  Adam Barth  <abarth@webkit.org>
15
16         Reviewed by Eric Seidel.
17
18         bugzilla-tool should have a mark-fixed command
19         https://bugs.webkit.org/show_bug.cgi?id=31853
20
21         Pretty simple stuff.
22
23         * Scripts/modules/commands/upload.py:
24
25 2009-11-25  Eric Seidel  <eric@webkit.org>
26
27         Reviewed by Adam Barth.
28
29         'bugzilla-tool help' should only show common commands like how 'git help' does
30         https://bugs.webkit.org/show_bug.cgi?id=31772
31
32         I also took this opportunity to make 'help' a real Command.
33         Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).
34
35         * Scripts/bugzilla-tool:
36          - change should_show_command_help to should_show_in_main_help
37         * Scripts/modules/commands/download.py:
38          - Mark commands as being shown in main help or not.
39          - show_in_main_help = False is not required (default is false),
40            but it seemed to make the commands more self-documenting.
41         * Scripts/modules/commands/queries.py: ditto
42         * Scripts/modules/commands/queues.py: ditto
43         * Scripts/modules/commands/upload.py: ditto
44         * Scripts/modules/multicommandtool.py:
45          - Make Command hold a pointer to tool in self.tool.  Most Command
46            subclasses do not take advantage of this yet, but it was required
47            for HelpCommand to be able to reach the tool from _help_epilog().
48          - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
49          - Move MultiCommandTool._help_epilog to Command._help_epilog
50          - Move "help" logic into HelpCommand.execute()
51          - Change should_show_command_help to should_show_in_main_help and add a default implementation.
52         * Scripts/modules/multicommandtool_unittest.py:
53          - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'
54
55 2009-11-25  Brian Weinstein  <bweinstein@apple.com>
56
57         Reviewed by Dan Bernstein.
58         
59         Patch by Mark Rowe.
60
61         The buildbots are failing on Windows because when they were upgraded
62         to 4.0.4, Apple Application Support was not in their path. Add it to
63         the path to fix the buildots.
64
65         * Scripts/webkitdirs.pm:
66
67 2009-11-25  Csaba Osztrogonác  <ossy@webkit.org>
68
69         Reviewed by David Kilzer.
70
71         run-webkit-tests doesn't accept directories/files with --skipped=only parameter
72         https://bugs.webkit.org/show_bug.cgi?id=31799
73
74         * Scripts/run-webkit-tests: Fixed.
75
76 2009-11-25  Zoltan Horvath  <zoltan@webkit.org>
77
78         Reviewed by Eric Seidel.
79
80         Change run_command to give back stderr by default
81         https://bugs.webkit.org/show_bug.cgi?id=31734
82
83         Change run_command to give back stderr by default.
84         Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
85         Change the related unittest call.
86
87         * Scripts/modules/scm.py:
88         * Scripts/modules/scm_unittest.py:
89
90 2009-11-25  Eric Seidel  <eric@webkit.org>
91
92         Reviewed by Adam Barth.
93
94         Centralize required argument parsing in Command
95         https://bugs.webkit.org/show_bug.cgi?id=31872
96
97         * Scripts/modules/commands/download.py: remove custom required arg message.
98         * Scripts/modules/commands/upload.py: ditto.
99         * Scripts/modules/multicommandtool.py:
100          - Add _parse_required_arguments.
101          - Pass program name off to OptionParser.
102          - Add name() for access to tool name.
103          - Add check_arguments_and_execute and make it return a return code.
104          - Replace a couple uses of + with %.
105         * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
106
107 2009-11-25  Eric Seidel  <eric@webkit.org>
108
109         Reviewed by Adam Barth.
110
111         Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
112         https://bugs.webkit.org/show_bug.cgi?id=31870
113
114         * Scripts/modules/commands/queries_unittest.py: Use the new class.
115         * Scripts/modules/multicommandtool_unittest.py: Ditto.
116         * Scripts/modules/outputcapture.py: Added.
117
118 2009-11-24  Dmitry Titov  <dimich@chromium.org>
119
120         Reviewed by Eric Seidel.
121
122         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
123         https://bugs.webkit.org/show_bug.cgi?id=31444
124
125         * Scripts/build-webkit:
126
127 2009-11-24  Chris Marrin  <cmarrin@apple.com>
128
129         Reviewed by Simon Fraser.
130
131         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
132         https://bugs.webkit.org/show_bug.cgi?id=27314
133         
134         Now the script allows the directories with these tests to be included on all
135         platforms but Mac, where they behave the same as always. For all other platforms
136         the tests need to be excluded using the Skipped files, which is currently done
137         for all platforms (including win since we're not turned on yet)
138
139         * Scripts/webkitdirs.pm:
140
141 2009-11-24  Eric Seidel  <eric@webkit.org>
142
143         Reviewed by Adam Barth.
144
145         queries_unittest.py should test command output
146         https://bugs.webkit.org/show_bug.cgi?id=31845
147
148         * Scripts/modules/commands/queries_unittest.py:
149          - Capture stdout and stderr and compare with expected strings.
150
151 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
152
153         No Review.
154
155         Fix spelling error ("depenedencies").
156
157         * Scripts/build-webkit:
158
159 2009-11-24  Mark Rowe  <mrowe@apple.com>
160
161         Land the configuration that includes the two debug GTK Linux builders.
162
163         * BuildSlaveSupport/build.webkit.org-config/config.json:
164
165 2009-11-24  David Kilzer  <ddkilzer@apple.com>
166
167         <http://webkit.org/b/31840> bisect-builds broke after r50080
168
169         Reviewed by Dan Bernstein.
170
171         * Scripts/bisect-builds:
172         (mountAndRunNightly): Switched back to using backticks to run
173         the hdiutil command since exec() will terminate the existing
174         script, which is not what we want.  Store the output of
175         File::Spec->devnull() in a variable for use in the hdiutil
176         detach commands.
177
178 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
179
180         Reviewed by Kenneth Rohde Christiansen.
181
182         Include "config.h" to meet Coding Style Guidelines
183         https://bugs.webkit.org/show_bug.cgi?id=31792
184
185         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
186         * DumpRenderTree/qt/jsobjects.cpp:
187         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
188
189 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
190
191         Reviewed by Oliver Hunt.
192
193         Implement new required function to pass test we used to pass. This
194         change is required since r51294.
195
196         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
197         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
198
199 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
200
201         Reviewed by Kenneth Rohde Christiansen.
202
203         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
204         https://bugs.webkit.org/show_bug.cgi?id=31775
205
206         LayoutTestController::dumpBackForwardList() should work with local URLs
207         as well as with normal URLs (in http tests for instance).
208         Currently it does not output the latter properly.
209
210         Unskip a bunch of passing http/navigation tests.
211
212         * DumpRenderTree/qt/DumpRenderTree.cpp:
213         (WebCore::dumpHistoryItem):
214
215 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
216
217         Reviewed by Oliver Hunt.
218
219         ARIA: support aria-flowto
220         https://bugs.webkit.org/show_bug.cgi?id=31762
221
222         * DumpRenderTree/AccessibilityUIElement.cpp:
223         (ariaFlowToElementAtIndexCallback):
224         (AccessibilityUIElement::getJSClass):
225         * DumpRenderTree/AccessibilityUIElement.h:
226         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
227         (AccessibilityUIElement::ariaFlowToElementAtIndex):
228         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
229         (AccessibilityUIElement::ariaFlowToElementAtIndex):
230         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
231         (AccessibilityUIElement::ariaFlowToElementAtIndex):
232
233 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
234
235         Reviewed by Kenneth Christiansen.
236
237         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
238         https://bugs.webkit.org/show_bug.cgi?id=31638
239
240         Unfreeze WorkQueue after each test execution.
241
242         * DumpRenderTree/qt/DumpRenderTree.cpp:
243         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
244
245 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
246
247         Reviewed by Adam Barth.
248
249         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
250         for localhost and 127.0.0.1.
251         https://bugs.webkit.org/show_bug.cgi?id=31783
252
253         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
254
255         * DumpRenderTree/qt/DumpRenderTree.cpp:
256         (WebCore::NetworkAccessManager::NetworkAccessManager):
257         (WebCore::NetworkAccessManager::sslErrorsEncountered):
258         (WebCore::WebPage::WebPage):
259         * DumpRenderTree/qt/DumpRenderTree.h:
260
261 2009-11-22  Chris Evans  <cevans@chromium.org>
262
263         Reviewed by Adam Barth.
264
265         Disable access to file:/// directory listings
266         https://bugs.webkit.org/show_bug.cgi?id=31329
267
268         Implemented setAllowUniversalAccessFromFileURLs to support testing of
269         file URL security.
270
271         * DumpRenderTree/LayoutTestController.cpp:
272         (setAllowUniversalAccessFromFileURLsCallback):
273         (LayoutTestController::staticFunctions):
274         * DumpRenderTree/LayoutTestController.h:
275         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
276         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
277         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
278         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
279         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
280         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
281         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
282         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
283
284 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
285
286         Reviewed by Kenneth Rohde Christiansen.
287
288         [Qt] Fix the timeout of fast/frames/frame-navigation.html
289         https://bugs.webkit.org/show_bug.cgi?id=31638
290
291         The test is timeouting, because it uses the WorkQueue to load a document in one
292         of the child frames and once the loading is finished, the DRT does not dump the
293         tree. This is because it waits for the QWebFrame::loadFinished() signal from
294         the main frame, while it should connect to QWebPage::loadFinished().
295
296         * DumpRenderTree/qt/DumpRenderTree.cpp:
297         (WebCore::DumpRenderTree::DumpRenderTree):
298
299 2009-11-21  Eric Seidel  <eric@webkit.org>
300
301         Reviewed by Adam Barth.
302
303         bugzilla-tool --help spews way too much text
304         https://bugs.webkit.org/show_bug.cgi?id=31771
305
306         * Scripts/bugzilla-tool:
307          - Remove self.cached_scm initialization hack.
308         * Scripts/modules/buildbot.py:
309          - Make default_host accessible to callers.
310         * Scripts/modules/commands/download.py:
311          - Phrase help for all commands consistently and remove spurious help text punctuation.
312         * Scripts/modules/commands/queries.py: Ditto.
313         * Scripts/modules/commands/queues.py: Ditto.
314         * Scripts/modules/commands/upload.py: Ditto.
315         * Scripts/modules/multicommandtool.py:
316          - Add HelpPrintingOptionParser.format_epilog to replace
317            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
318            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
319          - Make --help only show a list of commands like "svn help" and "git help" do --
320            previously --help was listing all commands and options.
321          - Sort list of commands alphabetically.
322
323 2009-11-21  Eric Seidel  <eric@webkit.org>
324
325         No review.  Fixing a typo from the previous patch for bug 31767.
326
327         AbstractQueue.run_bugzilla_tool throws an exception
328         https://bugs.webkit.org/show_bug.cgi?id=31769
329
330         * Scripts/modules/commands/queues.py:
331
332 2009-11-21  Eric Seidel  <eric@webkit.org>
333
334         Reviewed by Adam Barth.
335
336         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
337         https://bugs.webkit.org/show_bug.cgi?id=31767
338
339         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
340         Since we don't have a good way to test BugzillaTool pieces, I've
341         left out a test for now.
342
343         * Scripts/bugzilla-tool:
344          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
345         * Scripts/modules/commands/queues.py:
346          - Use tool.path() instead of __file__.
347         * Scripts/modules/multicommandtool.py:
348          - Add a new path() method to MultiComandTool.
349         * Scripts/modules/multicommandtool_unittest.py:
350          - Provide a path() method.  Little point in testing this mock implementation.
351
352 2009-11-21  Adam Barth  <abarth@webkit.org>
353
354         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
355         WebKitTools.
356
357         * Scripts/modules/commands/download.py:
358
359 2009-11-21  Adam Barth  <abarth@webkit.org>
360
361         Reviewed by Eric Seidel.
362
363         Convert check-style to use LandingSequence
364         https://bugs.webkit.org/show_bug.cgi?id=31763
365
366         Instead of manipulating the working copy by hand, we should use the
367         LandingSequence in CheckStyle.  This will make this code eaiser to
368         test.
369
370         * Scripts/modules/commands/download.py:
371
372 2009-11-20  Adam Barth  <abarth@webkit.org>
373
374         Reviewed by Eric Seidel.
375
376         Unit test query commands
377         https://bugs.webkit.org/show_bug.cgi?id=31755
378
379         These tests are pretty rough, but hopefully they'll grow.
380
381         * Scripts/modules/commands/queries_unittest.py: Added.
382         * Scripts/modules/mock_bugzillatool.py: Added.
383         * Scripts/run-webkit-unittests:
384
385 2009-11-20  Eric Seidel  <eric@webkit.org>
386
387         Reviewed by Adam Barth.
388
389         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
390         https://bugs.webkit.org/show_bug.cgi?id=31758
391
392         * Scripts/modules/multicommandtool.py:
393          - Allow passing of explicit commands to MultiCommandTool.__init__
394         * Scripts/modules/multicommandtool_unittest.py:
395          - Use new Command.name naming system.
396          - Test Command auto-discovery.
397         * Scripts/modules/workqueue.py:
398          - bug_id no longer exists, use patch['bug_id'] instead.
399         * Scripts/modules/workqueue_unittest.py:
400          - WorkQueues require names now.
401          - should_proceed_with_work_item must return a patch object.
402
403 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
404
405         Reviewed by Beth Dakin.
406
407         WAI-ARIA: add support for aria-owns
408         https://bugs.webkit.org/show_bug.cgi?id=31702
409
410         * DumpRenderTree/AccessibilityUIElement.cpp:
411         (ariaOwnsElementAtIndexCallback):
412         (AccessibilityUIElement::getJSClass):
413         * DumpRenderTree/AccessibilityUIElement.h:
414         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
415         (AccessibilityUIElement::ariaOwnsElementAtIndex):
416         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
417         (AccessibilityUIElement::ariaOwnsElementAtIndex):
418         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
419         (AccessibilityUIElement::ariaOwnsElementAtIndex):
420
421 2009-11-20  Eric Seidel  <eric@webkit.org>
422
423         Reviewed by Adam Barth.
424
425         Fix exception thrown when running the commit-queue.
426
427         * Scripts/modules/statusbot.py: patch is optional.
428         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
429
430 2009-11-20  Eric Seidel  <eric@webkit.org>
431
432         Reviewed by Adam Barth.
433
434         Teach the StatusBot how to support more than just the commit-queue
435         https://bugs.webkit.org/show_bug.cgi?id=31754
436
437         * Scripts/modules/workqueue.py: Another typo.
438
439 2009-11-20  Eric Seidel  <eric@webkit.org>
440
441         Reviewed by Adam Barth.
442
443         Teach the StatusBot how to support more than just the commit-queue
444         https://bugs.webkit.org/show_bug.cgi?id=31754
445
446         * Scripts/modules/commands/queues.py: Fix silly typo.
447
448 2009-11-20  Eric Seidel  <eric@webkit.org>
449
450         Reviewed by Adam Barth.
451
452         Teach the StatusBot how to support more than just the commit-queue
453         https://bugs.webkit.org/show_bug.cgi?id=31754
454
455         * CommitQueueStatus/index.yaml:
456          - Add indices required for the new queries.
457         * CommitQueueStatus/queue_status.py:
458          - Add a patch-status page and move update_status to update-status.
459          - Only display "commit-queue" status records for the commit-queue.
460          - Add support for a queue_name property on status records.
461          - Fix _int_from_request to actually work.
462         * CommitQueueStatus/update_status.html:
463          - Add support for a queue_name on status records.
464          - Remove unused list of bug ids.
465          * Scripts/modules/commands/queues.py
466           - Make the queues pass the patch instead of the bug_id to StatusBot.
467         * Scripts/modules/statusbot.py:
468          - Support passing the queue_name to the status updates.
469          - Support fetching patch status with patch_status().
470         * Scripts/modules/workqueue.py:
471          - Pass the patch to the StatusBot instead of the bug_id.
472          - Let WorkQueues have a name.
473
474 2009-11-20  Adam Barth  <abarth@webkit.org>
475
476         Reviewed by Eric Seidel.
477
478         Move bugzilla-tool commands into their own file
479         https://bugs.webkit.org/show_bug.cgi?id=31752
480
481         This will let us write unit tests.
482
483         * Scripts/bugzilla-tool:
484         * Scripts/modules/commands/__init__.py: Added.
485         * Scripts/modules/commands/download.py: Added.
486         * Scripts/modules/commands/queries.py: Added.
487         * Scripts/modules/commands/queues.py: Added.
488         * Scripts/modules/commands/upload.py: Added.
489         * Scripts/modules/grammar.py: Added.
490
491 2009-11-20  Adam Barth  <abarth@webkit.org>
492
493         Reviewed by Eric Seidel.
494
495         BuildQueue should check if the tree is currently buildable
496         https://bugs.webkit.org/show_bug.cgi?id=31744
497
498         * Scripts/bugzilla-tool:
499         * Scripts/modules/landingsequence.py:
500         * Scripts/modules/webkitlandingscripts.py:
501
502 2009-11-20  Adam Barth  <abarth@webkit.org>
503
504         Reviewed by Eric Seidel.
505
506         Move prepare_clean_working_directory into the LandingSequence
507         https://bugs.webkit.org/show_bug.cgi?id=31743
508
509         * Scripts/bugzilla-tool:
510         * Scripts/modules/landingsequence.py:
511
512 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
513
514         Reviewed by Kenneth Rohde Christiansen.
515
516         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
517         https://bugs.webkit.org/show_bug.cgi?id=30460
518
519         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
520
521         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
522         (pluginInvoke):
523
524 2009-11-20  Adam Barth  <abarth@webkit.org>
525
526         Reviewed by Eric Seidel.
527
528         Pass the port information to the child process
529         https://bugs.webkit.org/show_bug.cgi?id=31736
530
531         We need to do this so the child process knows what to build!
532
533         * Scripts/bugzilla-tool:
534         * Scripts/modules/landingsequence.py:
535         * Scripts/modules/webkitport.py:
536         * Scripts/modules/webkitport_unittest.py:
537
538 2009-11-20  Adam Barth  <abarth@webkit.org>
539
540         Reviewed by Eric Seidel.
541
542         Support Qt port in build-queue
543         https://bugs.webkit.org/show_bug.cgi?id=31733
544
545         * Scripts/bugzilla-tool:
546
547 2009-11-20  Adam Barth  <abarth@webkit.org>
548
549         Reviewed by Eric Seidel.
550
551         Implement a build-queue
552         https://bugs.webkit.org/show_bug.cgi?id=31725
553
554         Currently this just builds the first 10 patches in the review queue.
555         We'll want to do something smarter soon.
556
557         * Scripts/bugzilla-tool:
558
559 2009-11-20  Adam Barth  <abarth@webkit.org>
560
561         Reviewed by Eric Seidel.
562
563         Make commit-queue and style-queue show up in help
564         https://bugs.webkit.org/show_bug.cgi?id=31724
565
566         We need to store their names on their class to make these commands
567         properly register themselves with MultiCommandTool.
568
569         * Scripts/bugzilla-tool:
570
571 2009-11-20  Adam Barth  <abarth@webkit.org>
572
573         Reviewed by Eric Seidel.
574
575         Implement bugzilla-tool build-attachment
576         https://bugs.webkit.org/show_bug.cgi?id=31722
577
578         This command builds an attachment from bugzilla.  It leaves the built
579         patch in the working copy.
580
581         * Scripts/bugzilla-tool:
582         * Scripts/modules/landingsequence.py:
583         * Scripts/modules/webkitlandingscripts.py:
584
585 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
586
587         Reviewed by Xan Lopez.
588
589         [GTK] DRT release event does not create the state correctly
590         https://bugs.webkit.org/show_bug.cgi?id=31717
591
592         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
593
594 2009-11-20  Eric Seidel  <eric@webkit.org>
595
596         Reviewed by Adam Barth.
597
598         MultiCommandTool should find Command objects automatically instead of with a manual list
599         https://bugs.webkit.org/show_bug.cgi?id=31710
600
601         * Scripts/bugzilla-tool:
602         * Scripts/modules/multicommandtool.py:
603          - Use some wild python-fu to crawl all the known subclasses of Command.
604
605 2009-11-20  Adam Barth  <abarth@webkit.org>
606
607         Unreviewed "build" fix.  Added missing import.
608
609         * Scripts/bugzilla-tool:
610
611 2009-11-20  Adam Barth  <abarth@webkit.org>
612
613         Unreviewed "build" fix.  I failed to update LandingSequence.test
614         properly.
615
616         * Scripts/modules/landingsequence.py:
617
618 2009-11-20  Adam Barth  <abarth@webkit.org>
619
620         Reviewed by Eric Seidel.
621
622         Create LandingSequence as the all-sing, all-dance landing class
623         https://bugs.webkit.org/show_bug.cgi?id=31709
624
625         Client can inherit from this class to carefully control exactly which
626         steps they wish to have happen in the landing sequence.
627
628         * Scripts/bugzilla-tool:
629         * Scripts/modules/landingsequence.py: Added.
630         * Scripts/modules/webkitlandingscripts.py: Added.
631
632 2009-11-19  Adam Barth  <abarth@webkit.org>
633
634         Reviewed by Eric Seidel.
635
636         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
637         https://bugs.webkit.org/show_bug.cgi?id=31707
638
639         This is to help when we implement build-attachment.
640
641         * Scripts/bugzilla-tool:
642
643 2009-11-19  Adam Barth  <abarth@webkit.org>
644
645         Reviewed by Eric Seidel.
646
647         Support Qt port in bugzilla-tool
648         https://bugs.webkit.org/show_bug.cgi?id=31701
649
650         Now we support building with Qt!
651
652         * Scripts/bugzilla-tool:
653         * Scripts/modules/webkitport.py: Added.
654         * Scripts/modules/webkitport_unittest.py: Added.
655         * Scripts/run-webkit-unittests:
656
657 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
658
659         Reviewed by Adam Barth.
660
661         Remove inserting stderr into patch in bugzilla-tool
662         https://bugs.webkit.org/show_bug.cgi?id=29914
663
664         Modify SCM python module's run_command function to avoid return of stderr
665         by default, so stderr won't be inserted into the patches.
666         Modify the related unit test.
667
668         * Scripts/modules/scm.py:
669         * Scripts/modules/scm_unittest.py:
670
671 2009-11-19  Eric Seidel  <eric@webkit.org>
672
673         Reviewed by Adam Barth.
674
675         bugzilla-tool needs per-command help
676         https://bugs.webkit.org/show_bug.cgi?id=31697
677
678         Added support for "bugzilla-tool help command-name"
679         and a unit test to make sure it works.
680
681         * Scripts/modules/multicommandtool.py:
682         * Scripts/modules/multicommandtool_unittest.py:
683
684 2009-11-19  Eric Seidel  <eric@webkit.org>
685
686         Reviewed by Adam Barth.
687
688         Move MultiCommandTool and Command into a separate file and add some basic unit tests
689         https://bugs.webkit.org/show_bug.cgi?id=31695
690
691         * Scripts/bugzilla-tool:
692         * Scripts/modules/multicommandtool.py: Added.
693         * Scripts/modules/multicommandtool_unittest.py: Added.
694         * Scripts/run-webkit-unittests:
695
696 2009-11-19  Eric Seidel  <eric@webkit.org>
697
698         No review, just adding a FIXME.
699
700         Split out command parsing and help printing from BugzillaTool
701         https://bugs.webkit.org/show_bug.cgi?id=31688
702
703         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
704
705 2009-11-19  Eric Seidel  <eric@webkit.org>
706
707         Reviewed by Adam Barth.
708
709         Split out command parsing and help printing from BugzillaTool
710         https://bugs.webkit.org/show_bug.cgi?id=31688
711
712         * Scripts/bugzilla-tool:
713          - Add new MultiCommandTool class to contain option parsing and help printing logic.
714          - Rename private methods to use _ pattern.
715          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
716          - 
717
718 2009-11-19  Eric Seidel  <eric@webkit.org>
719
720         Reviewed by Adam Barth.
721
722         Re-factor help printing to use modern python idioms
723         https://bugs.webkit.org/show_bug.cgi?id=31685
724
725         * Scripts/bugzilla-tool:
726
727 2009-11-19  Eric Seidel  <eric@webkit.org>
728
729         Reviewed by Darin Adler.
730
731         commit-queue empty queue logs twice
732         https://bugs.webkit.org/show_bug.cgi?id=31679
733
734         * Scripts/bugzilla-tool:
735
736 2009-11-19  Eric Seidel  <eric@webkit.org>
737
738         Reviewed by Darin Adler.
739
740         bugzilla-tool's reviewer/committer rejection message should be clearer
741         https://bugs.webkit.org/show_bug.cgi?id=31126
742
743         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
744
745         * Scripts/modules/bugzilla.py:
746
747 2009-11-19  Eric Z. Ayers  <zundel@google.com>
748
749         Reviewed by Pavel Feldman.
750
751         Forces a WM_PAINT event on calling layoutTestController.display()
752         in order to enable the timeline-paint.html test on Windows.
753         ::UpdateWindow() does not force an event becaue the window is 
754         not visible.
755
756         https://bugs.webkit.org/show_bug.cgi?id=31402
757
758         * DumpRenderTree/win/DumpRenderTree.cpp:
759         (displayWebView):
760
761 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
762
763         No review needed.
764
765         Added myself to committers list.
766
767         * Scripts/modules/committers.py:
768
769 2009-11-19  Adam Barth  <abarth@webkit.org>
770
771         Reviewed by Eric Seidel.
772
773         Bugzilla-tool command classes should match command names
774         https://bugs.webkit.org/show_bug.cgi?id=31666
775
776         I renamed all the commands except CommitMessageForCurrentDiff because
777         the new name would conflict with an existing class.
778
779         * Scripts/bugzilla-tool:
780
781 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
782
783         Reviewed by Gustavo Noronha Silva.
784
785         Web Inspector: Implement "show inspector" in WebKit GTK
786         API and enable console tests.
787
788         https://bugs.webkit.org/show_bug.cgi?id=31669
789
790         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
791         (LayoutTestController::showWebInspector):
792
793 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
794
795         Reviewed by Simon Hausmann.
796
797         Minor refactoring + more documentation.
798
799         * DumpRenderTree/qt/DumpRenderTree.cpp:
800         (WebCore::clearHistory):
801         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
802
803 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
804
805         Reviewed by Eric Seidel.
806
807         Ignore websocket tests when --no-http is specified.
808         https://bugs.webkit.org/show_bug.cgi?id=31662
809
810         * Scripts/run-webkit-tests:
811
812 2009-11-18  Adam Barth  <abarth@webkit.org>
813
814         Reviewed by Eric Seidel.
815
816         Normalize ' and " in bugzilla-tool
817         https://bugs.webkit.org/show_bug.cgi?id=31655
818
819         We decided " is better than ' and we should be consistent.
820
821         * Scripts/bugzilla-tool:
822
823 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
824
825         Reviewed by Kenneth Rohde Christiansen.
826
827         [Qt] Remove support for Qt v4.3 or older versions
828         https://bugs.webkit.org/show_bug.cgi?id=29469
829
830         * DumpRenderTree/qt/DumpRenderTree.pro:
831         * DumpRenderTree/qt/ImageDiff.pro:
832
833 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
834
835         Reviewed by Eric Seidel.
836
837         GitTest.test_create_binary_patch fails if /tmp is symlink
838         https://bugs.webkit.org/show_bug.cgi?id=31536
839
840         * Scripts/modules/scm_unittest.py:
841
842 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
843
844         Reviewed by Darin Adler.
845
846         Configuration for Chromium Build Slaves.
847
848         https://bugs.webkit.org/show_bug.cgi?id=31442
849
850         * BuildSlaveSupport/build.webkit.org-config/config.json:
851         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
852
853 2009-11-18  Eric Seidel  <eric@webkit.org>
854
855         Reviewed by Darin Adler.
856
857         workqueue.py results in totally broken commit-queue UI
858         https://bugs.webkit.org/show_bug.cgi?id=31645
859
860         * Scripts/bugzilla-tool:
861          - Remove unneeded use of PatchCollection.
862          - Grab a new copy of the cq'd patches every run of the queue.
863
864 2009-11-18  Sam Weinig  <sam@webkit.org>
865
866         Reviewed by Anders Carlsson.
867
868         Make the Mac Geolocation API async.
869
870         Update DRT to use the new async Mac Geolocation API.
871
872         * DumpRenderTree/mac/UIDelegate.mm:
873         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
874
875 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
876
877         Reviewed by Kenneth Rohde Christiansen.
878
879         Add and option to toggle HTML5 datalist support to build-webkit
880         https://bugs.webkit.org/show_bug.cgi?id=31599
881
882         * Scripts/build-webkit:
883
884 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
885
886         Reviewed by Kevin Ollivier.
887
888         Enable wx plugin support using the Windows implementation as a base.
889         
890         https://bugs.webkit.org/show_bug.cgi?id=31636
891
892         * wx/build/settings.py:
893
894 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
895
896         Reviewed by Simon Hausmann.
897
898         Change the initialization order so that the controllers
899         will be created before exporting them to the JS DOM window.
900
901         * DumpRenderTree/qt/DumpRenderTree.cpp:
902         (WebCore::DumpRenderTree::DumpRenderTree):
903
904 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
905
906         Reviewed by Simon Hausmann.
907
908         Fix a code copy and paste error. m_page should be page.
909
910         * DumpRenderTree/qt/DumpRenderTree.cpp:
911         (WebCore::DumpRenderTree::createWindow):
912
913 2009-11-17  Mark Rowe  <mrowe@apple.com>
914
915         Reviewed by Alexey Proskuryakov.
916
917         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
918
919         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
920         This prevents symlinks from confusing the descendant check.
921
922 2009-11-17  Mark Rowe  <mrowe@apple.com>
923
924         Reviewed by Alexey Proskuryakov.
925
926         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
927
928         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
929         server to be up rather than having run-webkit-tests abort immediately.
930
931         * Scripts/run-webkit-tests:
932
933 2009-11-17  Eric Seidel  <eric@webkit.org>
934
935         Reviewed by Darin Adler.
936
937         commit-queue is failing to set reviewer in ChangeLogs
938         https://bugs.webkit.org/show_bug.cgi?id=31592
939
940         * Scripts/bugzilla-tool: Clarify the "applying" log message.
941         * Scripts/modules/bugzilla.py:
942          - Add a new _validate_committer_and_reviewer function as a
943            temporary solution until we can make a real Attachment object
944            which knows how to fill in its committer/reviewer fields automatically.
945
946 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
947
948         Unreviewed buildbot fix.
949
950         Revert part of earlier patch and add comment, as it
951         was causing timeouts on the buildbot.
952
953         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
954         (LayoutTestController::notifyDone):
955
956 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
957
958         Reviewed by Oliver Hunt.
959
960         Make the timeout 15 sec as for the other DRT's and make
961         it print out the same output when a test timeout.
962
963         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
964         (LayoutTestController::waitUntilDone):
965         (LayoutTestController::notifyDone):
966         (LayoutTestController::timerEvent):
967
968 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
969
970         Reviewed by Timothy Hatcher.
971
972         Fixed typos in comments.
973
974         * Scripts/modules/committers.py:
975
976 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
977
978         Reviewed by Timothy Hatcher.
979
980         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
981         - Updated DRT to show/close inspector for all tests under /inspector
982         - Introduced LayoutTestController::setTimelineProfilingEnabled and
983           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
984         - Removed reload on each inspector test
985         - Renamed fast/inspector to fast/inspector-support in order not to trigger
986         inspector for those.
987         - Reimplemented timeline tests in order to get rid of reload there.
988         - Moved tests that don't require harness into the fast group.
989
990         https://bugs.webkit.org/show_bug.cgi?id=31472
991
992         * DumpRenderTree/LayoutTestController.cpp:
993         (setTimelineProfilingEnabledCallback):
994         (closeWebInspectorCallback):
995         (LayoutTestController::staticFunctions):
996         * DumpRenderTree/LayoutTestController.h:
997         * DumpRenderTree/gtk/DumpRenderTree.cpp:
998         (shouldOpenWebInspector):
999         (runTest):
1000         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1001         (LayoutTestController::setTimelineProfilingEnabled):
1002         * DumpRenderTree/mac/DumpRenderTree.mm:
1003         (shouldOpenWebInspector):
1004         (runTest):
1005         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1006         (LayoutTestController::setTimelineProfilingEnabled):
1007         * DumpRenderTree/win/DumpRenderTree.cpp:
1008         (shouldOpenWebInspector):
1009         (runTest):
1010         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1011         (LayoutTestController::setTimelineProfilingEnabled):
1012
1013 2009-11-17  Oliver Hunt  <oliver@apple.com>
1014
1015         Reviewed by Maciej Stachowiak.
1016
1017         Incorrect use of JavaScriptCore API in DumpRenderTree
1018         https://bugs.webkit.org/show_bug.cgi?id=31577
1019
1020         Return undefined rather than a literal null.
1021
1022         * DumpRenderTree/AccessibilityUIElement.cpp:
1023         (setSelectedTextRangeCallback):
1024         (incrementCallback):
1025         (decrementCallback):
1026         (showMenuCallback):
1027
1028 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
1029
1030         Reviewed by Beth Dakin.
1031
1032         AX: aria-labelledby duplicates some of its WAI-ARIA label
1033         https://bugs.webkit.org/show_bug.cgi?id=31565
1034
1035         * DumpRenderTree/AccessibilityUIElement.cpp:
1036         (titleUIElementCallback):
1037         (getIsValidCallback):
1038         (AccessibilityUIElement::getJSClass):
1039
1040 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1041
1042         Reviewed by Simon Hausmann.
1043
1044         r50942 broke output from created windows. Make the
1045         m_enableTextOutput a member of the DRT and not the
1046         WebPage.
1047
1048         * DumpRenderTree/qt/DumpRenderTree.cpp:
1049         (WebCore::WebPage::WebPage):
1050         (WebCore::WebPage::javaScriptAlert):
1051         (WebCore::WebPage::javaScriptConsoleMessage):
1052         (WebCore::WebPage::javaScriptConfirm):
1053         (WebCore::WebPage::javaScriptPrompt):
1054         (WebCore::WebPage::acceptNavigationRequest):
1055         (WebCore::DumpRenderTree::DumpRenderTree):
1056         (WebCore::DumpRenderTree::open):
1057         (WebCore::DumpRenderTree::createWindow):
1058         * DumpRenderTree/qt/DumpRenderTree.h:
1059         (WebCore::DumpRenderTree::setTextOutputEnabled):
1060         (WebCore::DumpRenderTree::isTextOutputEnabled):
1061         (WebCore::WebPage::shouldInterruptJavaScript):
1062         (WebCore::WebPage::isTextOutputEnabled):
1063         (WebCore::WebPage::setViewGeometry):
1064
1065 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1066
1067         Reviewed by Gustavo Noronha Silva.
1068
1069         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
1070         as the implementation is being used by at least Qt and Gtk+.
1071
1072         Update buildsystems as well.
1073
1074         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1075         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
1076         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
1077         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
1078         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1079         * GNUmakefile.am:
1080
1081 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
1082
1083         Reviewed by Alexey Proskuryakov.
1084
1085         Disable wss until all platforms support pyOpenSSL
1086
1087         https://bugs.webkit.org/show_bug.cgi?id=31479
1088
1089         * Scripts/run-webkit-tests:
1090
1091 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
1092
1093         Reviewed by Kenneth Christiansen.
1094
1095         [Qt] Implement load error pages support for Qt's DRT.
1096         https://bugs.webkit.org/show_bug.cgi?id=31509
1097
1098         For now, it will not be a default feature, and layout tests
1099         that want to make use of this have to explicitily call
1100         'handleErrorPages();' for the test source.
1101
1102         Any of the other DumpRenderTree's (mac, win and gtk)
1103         support handling error pages. Qt's will be the first.
1104
1105         * DumpRenderTree/qt/DumpRenderTree.cpp:
1106         (WebCore::WebPage::supportsExtension):
1107         (WebCore::WebPage::extension):
1108         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1109         (LayoutTestController::reset):
1110         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1111         (LayoutTestController::shouldHandleErrorPages):
1112         (LayoutTestController::handleErrorPages):
1113
1114 2009-11-16  Eric Seidel  <eric@webkit.org>
1115
1116         Reviewed by Adam Barth.
1117
1118         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
1119         https://bugs.webkit.org/show_bug.cgi?id=31549
1120
1121         Renamed --commit-queue to --non-interactive in most places
1122         and remove the code in land-patches which is no longer needed.
1123
1124         * Scripts/bugzilla-tool:
1125
1126 2009-11-16  Eric Seidel  <eric@webkit.org>
1127
1128         Reviewed by Adam Barth.
1129
1130         The commit-queue should use land-attachment
1131         https://bugs.webkit.org/show_bug.cgi?id=31548
1132
1133         * Scripts/bugzilla-tool:
1134
1135 2009-11-16  Adam Barth  <abarth@webkit.org>
1136
1137         Reviewed by Eric Seidel.
1138
1139         Convert CommitQueue over to PatchCollection
1140         https://bugs.webkit.org/show_bug.cgi?id=31547
1141
1142         Also fixes a bug in workqueue and adds a test!
1143
1144         * Scripts/bugzilla-tool:
1145         * Scripts/modules/workqueue.py:
1146         * Scripts/modules/workqueue_unittest.py:
1147
1148 2009-11-16  Adam Barth  <abarth@webkit.org>
1149
1150         Reviewed by Eric Seidel.
1151
1152         Move StyleQueue over to using PatchCollection
1153         https://bugs.webkit.org/show_bug.cgi?id=31544
1154
1155         That's what the class it's for.
1156
1157         * Scripts/bugzilla-tool:
1158         * Scripts/modules/patchcollection.py:
1159         * Scripts/modules/patchcollection_unittest.py:
1160
1161 2009-11-16  Eric Seidel  <eric@webkit.org>
1162
1163         Reviewed by Adam Barth.
1164
1165         bugzilla-tool needs a land-attachment command
1166         https://bugs.webkit.org/show_bug.cgi?id=31546
1167
1168         * Scripts/bugzilla-tool:
1169          - Move all the logic into AbstractLandingCommand and
1170            add a new LandAttachment command subclass.
1171          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
1172
1173 2009-11-16  Eric Seidel  <eric@webkit.org>
1174
1175         Reviewed by Adam Barth.
1176
1177         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
1178         https://bugs.webkit.org/show_bug.cgi?id=31543
1179
1180         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
1181
1182         * Scripts/bugzilla-tool:
1183
1184 2009-11-16  Eric Seidel  <eric@webkit.org>
1185
1186         Reviewed by Adam Barth.
1187
1188         Disable the style queue from posting to the commit queue status page.
1189
1190         * Scripts/bugzilla-tool:
1191
1192 2009-11-16  Adam Barth  <abarth@webkit.org>
1193
1194         Reviewed by Eric Seidel.
1195
1196         Implement PatchCollection
1197         https://bugs.webkit.org/show_bug.cgi?id=31541
1198
1199         This class holds a set of patches and lets clients iterate through
1200         them.  Optionally, clients can install a filter.
1201
1202         * Scripts/modules/patchcollection.py: Added.
1203         * Scripts/modules/patchcollection_unittest.py: Added.
1204         * Scripts/run-webkit-unittests:
1205
1206 2009-11-16  Eric Seidel  <eric@webkit.org>
1207
1208         Reviewed by Adam Barth.
1209
1210         bugzilla-tool land-patches will close bugs with patches r=?
1211         https://bugs.webkit.org/show_bug.cgi?id=28230
1212
1213         The commit-queue shouldn't close patches with outstanding reviews on them,
1214         even if many reviewers seem to be against multi-patch bugs.
1215
1216         * Scripts/bugzilla-tool:
1217
1218 2009-11-16  Eric Seidel  <eric@webkit.org>
1219
1220         Reviewed by Adam Barth.
1221
1222         bugzilla-tool check-style should work with attachment ids instead of bug ids
1223         https://bugs.webkit.org/show_bug.cgi?id=31540
1224
1225         * Scripts/bugzilla-tool:
1226
1227 2009-11-16  Eric Seidel  <eric@webkit.org>
1228
1229         Reviewed by Adam Barth.
1230
1231         WorkQueue is the only place that should know about special exit codes
1232         https://bugs.webkit.org/show_bug.cgi?id=31534
1233
1234         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
1235         and add tests for handling exit codes.
1236         I also cleaned up workqueue_unittest.py more.
1237
1238         * Scripts/bugzilla-tool:
1239         * Scripts/modules/workqueue.py:
1240         * Scripts/modules/workqueue_unittest.py:
1241
1242 2009-11-16  Eric Seidel  <eric@webkit.org>
1243
1244         Reviewed by Adam Barth.
1245
1246         Re-factor workqueue_unittest to allow for more than one test.
1247         https://bugs.webkit.org/show_bug.cgi?id=31535
1248
1249         * Scripts/modules/workqueue_unittest.py:
1250
1251 2009-11-16  Eric Seidel  <eric@webkit.org>
1252
1253         Reviewed by Adam Barth.
1254
1255         land-patches needs to be re-factored into smaller chunks
1256         https://bugs.webkit.org/show_bug.cgi?id=31532
1257
1258         * Scripts/bugzilla-tool: fix a couple obvious typos.
1259
1260 2009-11-16  Eric Seidel  <eric@webkit.org>
1261
1262         Reviewed by Adam Barth.
1263
1264         land-patches needs to be re-factored into smaller chunks
1265         https://bugs.webkit.org/show_bug.cgi?id=31532
1266
1267         The next patch will move these methods into WebKitLandingScripts.
1268
1269         * Scripts/bugzilla-tool:
1270          - Split out _land_patch and _close_bug_if_no_active_patches.
1271
1272 2009-11-16  Adam Barth  <abarth@webkit.org>
1273
1274         Reviewed by Eric Seidel.
1275
1276         Fix silly copy-and-paste code.  I am a terrible coder.
1277
1278         * Scripts/modules/bugzilla.py:
1279
1280 2009-11-16  Adam Barth  <abarth@webkit.org>
1281
1282         Reviewed by Eric Seidel.
1283
1284         Implement a StyleQueue
1285         https://bugs.webkit.org/show_bug.cgi?id=31537
1286
1287         The first iteration of the style queue only produces output locally.
1288         There is also a limit of 10 patches because it's not that useful to
1289         iterate through the entire review queue at this point.  We can remove
1290         the limit later.
1291
1292         * Scripts/bugzilla-tool:
1293         * Scripts/modules/bugzilla.py:
1294
1295 2009-11-16  Adam Barth  <abarth@webkit.org>
1296
1297         Reviewed by Eric Seidel.
1298
1299         Unit test WorkQueue
1300         https://bugs.webkit.org/show_bug.cgi?id=31531
1301
1302         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
1303
1304         * Scripts/bugzilla-tool:
1305         * Scripts/modules/statusbot.py:
1306         * Scripts/modules/workqueue.py:
1307         * Scripts/modules/workqueue_unittest.py: Added.
1308         * Scripts/run-webkit-unittests:
1309
1310 2009-11-16  Eric Seidel  <eric@webkit.org>
1311
1312         Reviewed by Adam Barth.
1313
1314         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
1315         https://bugs.webkit.org/show_bug.cgi?id=31530
1316
1317         * Scripts/bugzilla-tool:
1318
1319 2009-11-16  Eric Seidel  <eric@webkit.org>
1320
1321         Reviewed by Adam Barth.
1322
1323         bugzilla-tool needs apply-attachment
1324         https://bugs.webkit.org/show_bug.cgi?id=31528
1325
1326         * Scripts/bugzilla-tool:
1327          - Add ApplyAttachment command.
1328          - Abstract applying code into WebKitApplyingScripts.
1329          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
1330         * Scripts/modules/bugzilla.py:
1331          - Add fetch_attachment and bug_id_for_attachment_id.
1332         * Scripts/modules/bugzilla_unittest.py:
1333          - Add test for new parsing.
1334          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
1335
1336 2009-11-16  Eric Seidel  <eric@webkit.org>
1337
1338         Reviewed by Adam Barth.
1339
1340         Document check-style's use of force_clean.
1341
1342         * Scripts/bugzilla-tool:
1343         * Scripts/modules/scm.py:
1344
1345 2009-11-16  Adam Barth  <abarth@webkit.org>
1346
1347         Reviewed by Eric Seidel.
1348
1349         Move WorkQueue to its own file
1350         https://bugs.webkit.org/show_bug.cgi?id=31529
1351
1352         WorkQueue and WorkQueueDelegate are separate concerns from
1353         bugzilla-tool.  Also added a missing include to logging.py.
1354
1355         * Scripts/bugzilla-tool:
1356         * Scripts/modules/logging.py:
1357         * Scripts/modules/workqueue.py:
1358
1359 2009-11-16  Adam Barth  <abarth@webkit.org>
1360
1361         Reviewed by Eric Seidel.
1362
1363         Move OutputTee to logging.py.
1364
1365         * Scripts/bugzilla-tool:
1366         * Scripts/modules/logging.py:
1367
1368 2009-11-15  Adam Barth  <abarth@webkit.org>
1369
1370         Reviewed by Eric Seidel.
1371
1372         Refactor bugzilla-tool to allow for multiple queues
1373         https://bugs.webkit.org/show_bug.cgi?id=31513
1374
1375         Divide the commit queue class into three class to make creating
1376         additional queues easier.
1377
1378         * Scripts/bugzilla-tool:
1379
1380 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1381
1382         Reviewed by Eric Seidel.
1383
1384         svn-apply may not handle git patches created by bugzilla-tool
1385         https://bugs.webkit.org/show_bug.cgi?id=31457
1386
1387         * Scripts/modules/scm.py:
1388         * Scripts/modules/scm_unittest.py:
1389
1390 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1391
1392         Reviewed by Eric Seidel.
1393
1394         bugzilla-tool should post git binary diff
1395         https://bugs.webkit.org/show_bug.cgi?id=31458
1396
1397         Add --binary option to Git.create_patch.
1398
1399         * Scripts/modules/scm.py:
1400         * Scripts/modules/scm_unittest.py:
1401
1402 2009-11-15  Adam Barth  <abarth@webkit.org>
1403
1404         Reviewed by Darin Adler.
1405
1406         Add bugzilla-tool check-style
1407         https://bugs.webkit.org/show_bug.cgi?id=31515
1408
1409         * Scripts/bugzilla-tool:
1410         * Scripts/modules/bugzilla.py:
1411
1412 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1413
1414         Reviewed by Simon Hausmann.
1415
1416         Make the Qt Linux only --valgrind feature, suppress errors
1417         defined in the SuppressedValgrindErrors file.
1418
1419         * Scripts/run-webkit-tests:
1420
1421 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1422
1423         Reviewed by Simon Hausmann.
1424
1425         Set the locale to C and not to the current one in use on the system.
1426
1427         * DumpRenderTree/qt/DumpRenderTree.cpp:
1428         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1429
1430 2009-11-13  Adam Roben  <aroben@apple.com>
1431
1432         Add support for
1433         http/tests/security/isolatedWorld/didClearWindowObject.html
1434
1435         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
1436         window objects in isolated worlds are cleared
1437
1438         Reviewed by Dave Hyatt.
1439
1440         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
1441
1442         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1443         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1444         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
1445         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
1446         Added. Sets a __worldID property on the global object whose value is
1447         the ID of this world.
1448         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
1449         Respond to this new delegate callback by calling through to one of the
1450         above new methods.
1451         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1452         (worldMap): Added. Returns a HashMap containing all the worlds we've
1453         created.
1454         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
1455         haven't kept track of this world.
1456         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1457         instead of declaring our own.
1458
1459         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
1460
1461         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1462         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
1463         didClearWindowObjectForFrameInStandardWorld.
1464         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
1465         Respond to this new delegate callback by calling through to one of the
1466         below new methods.
1467         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
1468         Added. Sets a __worldID property on the gobal object whose value is
1469         the ID of this world.
1470         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1471         Added. Moved code here from didClearWindowObject.
1472
1473         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
1474         didClearWindowObjectForFrame* functions.
1475
1476         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1477         (worldMap): Added. Returns a HashMap containing all the worlds we've
1478         created.
1479         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
1480         haven't kept track of this world.
1481         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1482         instead of declaring our own.
1483
1484 2009-11-13  Adam Roben  <aroben@apple.com>
1485
1486         Finish replacing worldIDs with world objects
1487
1488         The only remaining use of worldIDs was in a method only used by DRT
1489         for the isolated worlds tests.
1490
1491         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
1492
1493         Reviewed by Mark Rowe.
1494
1495         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1496         (LayoutTestController::evaluateScriptInIsolatedWorld):
1497         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1498         (LayoutTestController::evaluateScriptInIsolatedWorld):
1499         Updated for changes to WebFrame. Now holds the map of worldID -> world
1500         at this level instead of making WebKit do it.
1501
1502 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1503
1504         Reviewed by Simon Hausmann.
1505
1506         [Qt] Ensure the DRT does not output anything until first test is run
1507
1508         * DumpRenderTree/qt/DumpRenderTree.cpp:
1509         * DumpRenderTree/qt/DumpRenderTree.h:
1510
1511 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1512
1513         Reviewed by Tor Arne Vestbø.
1514
1515         Clear the undo stack in before each new test run.
1516
1517         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
1518
1519         * DumpRenderTree/qt/DumpRenderTree.cpp:
1520         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1521
1522 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1523
1524         Reviewed by Kenneth Rohde Christiansen.
1525
1526         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
1527
1528         * DumpRenderTree/qt/DumpRenderTree.cpp:
1529         (WebCore::WebPage::resetSettings):
1530         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1531         (LayoutTestController::overridePreference):
1532
1533 2009-11-13  Eric Seidel  <eric@webkit.org>
1534
1535         Reviewed by Adam Barth.
1536
1537         Update committers.py based on svn records
1538         https://bugs.webkit.org/show_bug.cgi?id=31366
1539
1540         This list was generated using validate-committer-lists from
1541         https://bugs.webkit.org/show_bug.cgi?id=30970
1542         and makes committers.py current for committers who have
1543         committed in the last 3 years.
1544
1545         * Scripts/modules/committers.py:
1546
1547 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
1548
1549         Reviewed by Adam Barth.
1550
1551         The document-open.html test was flaky at times. The test invokes the layout test plugin
1552         which in its destroy stream handler opens a new document. This basically tears down the
1553         stream and the associated plugin instance. The pluginLog function in the layout test
1554         plugin attempts to retrieve the window script object on a torn down plugin instance
1555         which crashed consistently on windows in the debugger. The functions which issue
1556         these logs already have a valid window script object. We now have variants of the pluginLog
1557         function which take in a window script object with and without variable arguments. 
1558
1559         https://bugs.webkit.org/show_bug.cgi?id=31067
1560
1561         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1562         (pluginLogWithWindowObject):
1563         (pluginLogWithWindowObjectVariableArgs):
1564         (pluginLog):
1565         (notifyTestCompletion):
1566         (testDocumentOpen):
1567         (testWindowOpen):
1568
1569 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1570
1571         Reviewed by Gustavo Noronha Silva.
1572
1573         https://bugs.webkit.org/show_bug.cgi?id=30997
1574         [Gtk] Implemment AtkDocument
1575
1576         Added testing support.
1577
1578         * DumpRenderTree/AccessibilityUIElement.cpp:
1579         * DumpRenderTree/AccessibilityUIElement.h:
1580         (getDocumentEncodingCallback):
1581         (getDocumentURICallback):
1582         (AccessibilityUIElement::getJSClass):
1583         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1584         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1585         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1586         (AccessibilityUIElement::documentEncoding):
1587         (AccessibilityUIElement::documentURI):
1588
1589 2009-11-12  Adam Roben  <aroben@apple.com>
1590
1591         Replace worldIDs with world objects
1592
1593         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
1594         user scripts/stylesheets and isolated worlds
1595
1596         Reviewed by Sam Weinig.
1597
1598         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1599         (LayoutTestController::addUserScript):
1600         (LayoutTestController::addUserStyleSheet):
1601         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1602         (LayoutTestController::addUserScript):
1603         (LayoutTestController::addUserStyleSheet):
1604         Changed these functions to create a new WebJSWorld each time they're
1605         called and to pass that world to WebKit.
1606
1607 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
1608
1609         Reviewed by Oliver Hunt.
1610
1611         need to implement aria tree roles
1612         https://bugs.webkit.org/show_bug.cgi?id=31284
1613
1614         * DumpRenderTree/AccessibilityUIElement.cpp:
1615         (disclosedRowAtIndexCallback):
1616         (selectedRowAtIndexCallback):
1617         (isEqualCallback):
1618         (isAttributeSettableCallback):
1619         (isActionSupportedCallback):
1620         (disclosedByRowCallback):
1621         (hierarchicalLevelCallback):
1622         (AccessibilityUIElement::getJSClass):
1623         * DumpRenderTree/AccessibilityUIElement.h:
1624         (AccessibilityUIElement::isEqual):
1625         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1626         (AccessibilityUIElement::hierarchicalLevel):
1627         (AccessibilityUIElement::disclosedRowAtIndex):
1628         (AccessibilityUIElement::selectedRowAtIndex):
1629         (AccessibilityUIElement::disclosedByRow):
1630         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1631         (AccessibilityUIElement::getChildAtIndex):
1632         (AccessibilityUIElement::disclosedRowAtIndex):
1633         (AccessibilityUIElement::selectedRowAtIndex):
1634         (AccessibilityUIElement::titleUIElement):
1635         (AccessibilityUIElement::parentElement):
1636         (AccessibilityUIElement::disclosedByRow):
1637         (AccessibilityUIElement::hierarchicalLevel):
1638         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1639         (AccessibilityUIElement::hierarchicalLevel):
1640         (AccessibilityUIElement::disclosedRowAtIndex):
1641         (AccessibilityUIElement::selectedRowAtIndex):
1642         (AccessibilityUIElement::disclosedByRow):
1643
1644 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
1645
1646         Reviewed by Darin Adler.
1647
1648         svn-apply can not handle git binary diffs
1649         https://bugs.webkit.org/show_bug.cgi?id=26830
1650
1651         Support "literal" type git binary diffs.
1652
1653         * Scripts/VCSUtils.pm:
1654         * Scripts/modules/scm_unittest.py:
1655         * Scripts/svn-apply:
1656
1657 2009-11-11  Dmitry Titov  <dimich@chromium.org>
1658
1659         Not reviewed, removing duplicate entry for myself in committers.py.
1660
1661         * Scripts/modules/committers.py:
1662
1663 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
1664
1665         Reviewed by Darin Adler and Mark Rowe.
1666
1667         https://bugs.webkit.org/show_bug.cgi?id=31200
1668         Tests in http/tests/security/mixedContent start to fail when new tests are added
1669
1670         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
1671
1672 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1673
1674         Reviewed by Jan Alonzo.
1675
1676         Create, and display a window for the inspector, for inspector
1677         tests.
1678
1679         Need to also show/hide the inspector window to avoid having
1680         problems with code assuming it is realized
1681         https://bugs.webkit.org/show_bug.cgi?id=31347
1682
1683         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1684         (webInspectorShowWindow):
1685         (webInspectorCloseWindow):
1686         (webInspectorInspectWebView):
1687         (createWebView):
1688
1689 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1690
1691         Unreviewed Qt buildbot fix.
1692
1693         My previous fix was wrong, so revert that change and fix it by
1694         returning when the document of the frame has no document element.
1695         Idea is borrowed from mac and win DRT.
1696
1697         * DumpRenderTree/qt/DumpRenderTree.cpp:
1698         (WebCore::DumpRenderTree::dumpFramesAsText):
1699
1700 2009-11-11  Eric Seidel  <eric@webkit.org>
1701
1702         Reviewed byg Kenneth Rohde Christiansen.
1703
1704         Update Kenneth's committer record to include the email he
1705         uses on lists.webkit.org.
1706
1707         * Scripts/modules/committers.py:
1708
1709 2009-11-11  Eric Seidel  <eric@webkit.org>
1710
1711         Reviewed by Gustavo Noronha Silva.
1712
1713         Several committers use separate email addresses for bugzilla and svn.webkit.org
1714         https://bugs.webkit.org/show_bug.cgi?id=31364
1715
1716         Update records for existing committers to include email addresses
1717         used in svn.webkit.org and lists.webkit.org.
1718         Most committers use the same email address in all 3 places, but some use
1719         separate addresses.  committers.py needs record of each of these addresses.
1720
1721         * Scripts/modules/committers.py:
1722
1723 2009-11-11  Eric Seidel  <eric@webkit.org>
1724
1725         No review, adding second email address for an existing committer.
1726
1727         Add Yong Li's second bugzilla account to his committer record.
1728         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
1729
1730         * Scripts/modules/committers.py:
1731
1732 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1733
1734         Reviewed by Simon Hausmann.
1735
1736         If the frame has no innerText don't append it, and
1737         do not add a newline which breaks some cross platform
1738         results.
1739
1740         * DumpRenderTree/qt/DumpRenderTree.cpp:
1741         (WebCore::DumpRenderTree::dumpFramesAsText):
1742
1743 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1744
1745         Reviewed by Simon Hausmann.
1746
1747         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
1748
1749         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1750         (webkit_test_plugin_new_instance):
1751         (webkit_test_plugin_destroy_instance):
1752         (webkit_test_plugin_destroy_stream):
1753
1754 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1755
1756         Reviewed by Mark Rowe.
1757
1758         Implement the functionality needed by plugins/window-open.html
1759
1760         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1761         (webkit_test_plugin_new_instance):
1762         (webkit_test_plugin_set_window):
1763
1764 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1765
1766         Reviewed by Simon Hausmann.
1767
1768         [Qt] Force -graphicssystem raster and -style windows when running DRT
1769
1770         * DumpRenderTree/qt/main.cpp:
1771         * Scripts/run-webkit-tests:
1772
1773 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1774
1775         Reviewed by Simon Hausmann.
1776
1777         Compute correct library paths for Qt
1778
1779         * Scripts/webkitdirs.pm:
1780
1781 2009-11-10  Mark Rowe  <mrowe@apple.com>
1782
1783         Reviewed by Sam Weinig.
1784
1785         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
1786
1787         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
1788         about the validity of the self-signed certificates used in the regression tests.  We would then add the
1789         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
1790         that had enabled frame load delegate logging this would result in extra log messages being generated,
1791         causing the test to fail.
1792
1793         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
1794         tests.
1795
1796         * DumpRenderTree/mac/DumpRenderTree.mm:
1797         (dumpRenderTree):
1798         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1799         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1800
1801 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1802
1803         Reviewed by Kenneth Rohde Christiansen.
1804
1805         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
1806
1807         * DumpRenderTree/qt/DumpRenderTree.cpp:
1808         (WebCore::DumpRenderTree::DumpRenderTree):
1809
1810 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1811
1812         Reviewed by Jan Alonzo.
1813
1814         [GTK] Remove WebSocket configuration from WebKitWebSettings
1815         https://bugs.webkit.org/show_bug.cgi?id=31244
1816
1817         Follow-up of r50724. Don't set the enable-web-socket property
1818         anymore.
1819
1820         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1821         (resetDefaultsToConsistentValues):
1822
1823 2009-11-10  Oliver Hunt  <oliver@apple.com>
1824
1825         Reviewed by Maciej Stachowiak.
1826
1827         Rename 3D Canvas related classes to use WebGL prefix
1828         https://bugs.webkit.org/show_bug.cgi?id=29095
1829
1830         Checkin new version of do-webcore-rename used to do the WebGL type rename,
1831         and upate webkitdirs script to new method of testing for WebGL.
1832
1833         * Scripts/do-webcore-rename:
1834         * Scripts/webkitdirs.pm:
1835
1836 2009-11-09  Oliver Hunt  <oliver@apple.com>
1837
1838         Reviewed by Geoff Garen.
1839
1840         Make do-webcore-rename work with git.
1841
1842         * Scripts/do-webcore-rename:
1843
1844 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
1845
1846         Adding Kenneth to the reviewers list.
1847
1848         * Scripts/modules/committers.py:
1849
1850 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1851
1852         Reviewed by Jan Alonzo.
1853
1854         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
1855         https://bugs.webkit.org/show_bug.cgi?id=30482
1856
1857         LayoutTestControllerGtk now uses the exposed
1858         Page::tabKeyCyclesThroughElements API
1859
1860         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1861         (LayoutTestController::setTabKeyCyclesThroughElements):
1862
1863 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
1864
1865         Reviewed by Holger Freyther.
1866
1867         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
1868         This helps to pass the test case below. Also replaced hardcoded
1869         code numbers with defined constants.
1870         https://bugs.webkit.org/show_bug.cgi?id=31185
1871         
1872         Test: editing/undo/undo-deleteWord.html
1873
1874         * DumpRenderTree/qt/EventSenderQt.cpp:
1875         (EventSender::keyDown):
1876
1877 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
1878
1879         Reviewed by Holger Freyther.
1880
1881         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
1882         https://bugs.webkit.org/show_bug.cgi?id=31164
1883
1884         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
1885
1886         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1887         (LayoutTestController::processWork):
1888
1889 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
1890
1891         Reviewed by Holger Freyther.
1892
1893         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
1894         https://bugs.webkit.org/show_bug.cgi?id=31158
1895
1896         By invoking a script queue'd by queueScript(), 'true' was beeing returned
1897         always, which from WorkQueue prospective means that a load has been started
1898         and the queue processing should stop and wait for the load to finish.
1899         Spinning it off into a loading and a non-loading variants was the solution
1900         adopted by Mac's DRT to work around this problem. The former keeps returning
1901         'true' while the later executes the script synchronously and returns 'false'
1902         making it possible to the WorkQueue to proceed right away.
1903
1904         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1905         (LayoutTestController::processWork):
1906         (LayoutTestController::queueLoadingScript):
1907         (LayoutTestController::queueNonLoadingScript):
1908         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1909         * DumpRenderTree/qt/WorkQueueItem.h:
1910         (LoadingScriptItem::LoadingScriptItem):
1911         (LoadingScriptItem::invoke):
1912         (NonLoadingScriptItem::NonLoadingScriptItem):
1913         (NonLoadingScriptItem::invoke):
1914
1915 2009-11-07  Mark Rowe  <mrowe@apple.com>
1916
1917         Rubber-stamped by Cameron Zwarich.
1918
1919         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
1920
1921         * Scripts/commit-log-editor:
1922
1923 2009-11-07  Mark Rowe  <mrowe@apple.com>
1924
1925         Reviewed by Darin Adler.
1926
1927         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
1928         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
1929
1930         Move logic for determining the name and email address to use in a ChangeLog entry from
1931         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
1932         whether the author of the patch matches committer, and therefore needs access to the
1933         email address that would be used in a ChangeLog entry.
1934
1935         Based on a patch by Pierre d'Herbemont.
1936
1937         * Scripts/VCSUtils.pm:
1938         * Scripts/commit-log-editor:
1939         * Scripts/prepare-ChangeLog:
1940         * Scripts/webkitdirs.pm:
1941
1942 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
1943
1944         Reviewed by Adam Barth.
1945
1946         Added functionality to the layout test plugin to invoke document.open and
1947         window.open with default arguments. The associated webkit bug is
1948         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
1949         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
1950         work in Chromium (V8) if there is no calling javascript context. To achieve this
1951         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
1952         for the window.open test case and in NPP_DestroyStream for the document.open test case.
1953
1954         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1955         (testDocumentOpen):
1956         (testWindowOpen):
1957         (pluginAllocate):
1958         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1959         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1960         (NPP_New):
1961         (NPP_SetWindow):
1962         (NPP_DestroyStream):
1963         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1964         (NPP_New):
1965         (NPP_SetWindow):
1966         (NPP_NewStream):
1967         (NPP_DestroyStream):
1968
1969 2009-11-06  Eric Seidel  <eric@webkit.org>
1970
1971         Reviewed by Adam Barth.
1972
1973         bugzilla-tool crashed with exception
1974         https://bugs.webkit.org/show_bug.cgi?id=31092
1975
1976         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
1977
1978 2009-11-04  Eric Seidel  <eric@webkit.org>
1979
1980         No review, just add a line which got left out of the patch uploaded for commit.
1981
1982         commit-queue is crashing when trying to reject patches after unknown failures
1983         https://bugs.webkit.org/show_bug.cgi?id=31091
1984
1985         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
1986
1987 2009-11-04  Adam Roben  <aroben@apple.com>
1988
1989         Remove bogus else clause in bugzilla-tool
1990
1991         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
1992         create-bug raises exception after entering bug description
1993
1994         Reviewed by David Kilzer.
1995
1996         * Scripts/bugzilla-tool:
1997         (CreateBug): else clauses are only hit if no exception is raised, so
1998         it makes no sense to try to re-raise the exception in an else clause.
1999         The exception will automatically be re-raised if it doesn't match any
2000         of the except clauses, so we don't have to do anything special here at
2001         all to get the desired behavior.
2002
2003 2009-11-04  Eric Seidel  <eric@webkit.org>
2004
2005         Reviewed by David Kilzer.
2006
2007         svn-apply's fixChangeLogPatch function seems broken
2008         https://bugs.webkit.org/show_bug.cgi?id=30683
2009
2010         Update fixChangeLogPatch to be able to handle patches which
2011         don't start at line 1.
2012         Add unit tests for svn-apply to scm_unittest.py.
2013
2014         * Scripts/VCSUtils.pm:
2015         * Scripts/modules/scm_unittest.py:
2016
2017 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
2018
2019         Reviewed by Beth Dakin.
2020
2021         Need to implement ARIA role="combobox"
2022         https://bugs.webkit.org/show_bug.cgi?id=31096
2023
2024         * DumpRenderTree/AccessibilityUIElement.cpp:
2025         (showMenuCallback):
2026         (getIsExpandedCallback):
2027         (AccessibilityUIElement::getJSClass):
2028         * DumpRenderTree/AccessibilityUIElement.h:
2029         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2030         (AccessibilityUIElement::isExpanded):
2031         (AccessibilityUIElement::showMenu):
2032         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2033         (AccessibilityUIElement::isExpanded):
2034         (AccessibilityUIElement::showMenu):
2035         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2036         (AccessibilityUIElement::isSelected):
2037         (AccessibilityUIElement::isExpanded):
2038         (AccessibilityUIElement::showMenu):
2039
2040 2009-11-04  Eric Seidel  <eric@webkit.org>
2041
2042         Reviewed by Adam Barth.
2043
2044         commit-queue is crashing when trying to reject patches after unknown failures
2045         https://bugs.webkit.org/show_bug.cgi?id=31091
2046
2047         * Scripts/bugzilla-tool:
2048          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
2049            so we have to find out what the current patch is by asking bugzilla again.
2050          - Discovered that this code was also leaking file descriptors, so fixed that.
2051
2052 2009-11-04  Adam Roben  <aroben@apple.com>
2053
2054         Make run-webkit-tests work for the Debug_Internal Windows
2055         configuration
2056
2057         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
2058         suffix.
2059
2060         Fixes <http://webkit.org/b/31123>.
2061
2062         Reviewed by Sam Weinig.
2063
2064         * Scripts/run-webkit-tests: Don't add the _debug suffix in
2065         Debug_Internal, either.
2066
2067 2009-11-04  Eric Seidel  <eric@webkit.org>
2068
2069         Reviewed by Adam Barth.
2070
2071         committers.py needs a way to store non-bugzilla email addresses
2072         https://bugs.webkit.org/show_bug.cgi?id=31037
2073
2074         Make Committer and Reviewer constructors take a single email or a list of emails.
2075         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
2076         Expose reviewers(), used by validate-committer-lists on bug 30970.
2077
2078         * Scripts/modules/committers.py:
2079         * Scripts/modules/committers_unittest.py: Added tests for the new code.
2080
2081 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
2082
2083         Reviewed by David Levin.
2084
2085         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
2086         https://bugs.webkit.org/show_bug.cgi?id=27491
2087
2088         The test path determination logic is changed to handle websocket and websocket/ssl cases.
2089         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
2090
2091         Functions to start or stop Web Socket servers are added.
2092
2093         * Scripts/run-webkit-tests:
2094
2095 2009-11-03  Eric Seidel  <eric@webkit.org>
2096
2097         No review, just changing wording of log message.
2098
2099         Change log string to say "failed" instead of "rejected"
2100         when a commit fails due to an out of date checkout.
2101         This makes grepping the commit-queue log for rejected patches easier.
2102
2103         * Scripts/bugzilla-tool:
2104
2105 2009-11-03  Eric Seidel  <eric@webkit.org>
2106
2107         No review, adding commonly known committers missing from the file.
2108
2109         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
2110
2111 2009-11-03  Eric Seidel  <eric@webkit.org>
2112
2113         No review, just sort-order cleanup.
2114
2115         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
2116
2117 2009-11-03  Stephen White  <senorblanco@chromium.org>
2118
2119         (Unreviewed).
2120
2121         Add myself to committers.py.
2122
2123         * Scripts/modules/committers.py:
2124
2125 2009-11-03  Robin Dunn  <robin@alldunn.com>
2126
2127         Reviewed by Kevin Ollviier.
2128
2129         Add packaging scripts for Debian-based Linux distros.
2130         
2131         https://bugs.webkit.org/show_bug.cgi?id=31075
2132
2133         * wx/packaging/build-debian-installer.py: Added.
2134         * wx/packaging/debian: Added.
2135
2136 2009-11-03  Dan Bernstein  <mitz@apple.com>
2137
2138         Reviewed by Anders Carlsson and Beth Dakin.
2139
2140         https://bugs.webkit.org/show_bug.cgi?id=31070
2141
2142         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
2143         destroyed, it executes the value of the 'ondestroy' parameter as a
2144         script.
2145
2146         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2147         (pluginAllocate): Initialize onDestroy.
2148         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
2149         onDestroy.
2150         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2151         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
2152         specified.
2153         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
2154
2155 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2156
2157         Reviewed by Xan Lopez.
2158
2159         https://bugs.webkit.org/show_bug.cgi?id=31035
2160         [GTK] some accessibility tests hitting assertion in debug builds
2161
2162         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
2163
2164         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2165         (AccessibilityController::rootElement):
2166
2167 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
2168
2169         Reviewed by Beth Dakin.
2170
2171         Support ARIA "tab" roles
2172         https://bugs.webkit.org/show_bug.cgi?id=30842
2173
2174         * DumpRenderTree/AccessibilityUIElement.cpp:
2175         * DumpRenderTree/AccessibilityUIElement.h:
2176         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2177         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2178         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2179
2180 2009-11-01  Eric Seidel  <eric@webkit.org>
2181
2182         Reviewed by David Levin.
2183
2184         buildbots should use --exit-after-N-failures
2185         https://bugs.webkit.org/show_bug.cgi?id=30809
2186
2187         Make the bots exit after 20 failures to prevent never-ending
2188         test runs where every test spends a minute crashing.
2189
2190         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2191
2192 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2193
2194         Reviewed by Eric Seidel.
2195
2196         Turn on warnings for QtWebKit for gcc
2197         https://bugs.webkit.org/show_bug.cgi?id=30958
2198
2199         * DumpRenderTree/qt/main.cpp: 
2200         (crashHandler): Mark function NO_RETURN
2201
2202 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
2203
2204         Adding myself to the committers list.
2205
2206         * Scripts/modules/committers.py:
2207
2208 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
2209
2210         Fix an issue that Adam noticed in DRT.
2211
2212         Reviewed by Darin Adler.
2213
2214         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2215         (AccessibilityUIElement::role):
2216         Get the length of the role text, and create a buffer dynamically.
2217
2218 2009-10-30  Eric Seidel  <eric@webkit.org>
2219
2220         No review, rolling out r50105.
2221         http://trac.webkit.org/changeset/50105
2222
2223         This commit was causing:
2224         https://bugs.webkit.org/show_bug.cgi?id=30869
2225         We'll re-implement the feature a different way.
2226
2227         * Scripts/bugzilla-tool:
2228
2229 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2230
2231         Test for MSAA: Accessibility of headings is not correct
2232
2233         https://bugs.webkit.org/show_bug.cgi?id=30937
2234
2235         Reviewed by Adam Roben.
2236
2237         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2238         (AccessibilityUIElement::role):
2239         Allow the role returned to be a BSTR.
2240         (AccessibilityUIElement::description):
2241         Fix a copy/paste error.
2242
2243 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2244
2245         Test for MSAA: Accessibility of links is wrong
2246
2247         https://bugs.webkit.org/show_bug.cgi?id=30928
2248
2249         Reviewed by Darin Adler.
2250
2251         * DumpRenderTree/AccessibilityUIElement.cpp:
2252         (getAccessibilityValueCallback):
2253         Return the accessibility value.
2254         (AccessibilityUIElement::getJSClass):
2255         Added "accessibilityValue" value.
2256
2257         * DumpRenderTree/AccessibilityUIElement.h:
2258
2259         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2260         (AccessibilityUIElement::accessibilityValue):
2261         Stubbed.
2262
2263         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2264         (AccessibilityUIElement::accessibilityValue):
2265         Stubbed.
2266
2267         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2268         (AccessibilityUIElement::accessibilityValue):
2269         Get the object's value, and return it as a JS string.
2270
2271 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
2272
2273         Fix typo in command name used by wx build system.
2274
2275         * wx/build/build_utils.py:
2276
2277 2009-10-30  Adam Barth  <abarth@webkit.org>
2278
2279         Reviewed by Darin Adler.
2280
2281         Patch v1 is a dumb default name for patches
2282         https://bugs.webkit.org/show_bug.cgi?id=30952
2283
2284         Let's use "Patch" instead.
2285
2286         * Scripts/bugzilla-tool:
2287
2288 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2289
2290         Unreviewed trivial buildfix.
2291
2292         [Qt] Buildfix for r50333.
2293
2294         * DumpRenderTree/qt/DumpRenderTree.pro:
2295
2296 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
2297
2298         Reviewed by Holger Freyther.
2299
2300         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
2301         https://bugs.webkit.org/show_bug.cgi?id=30953
2302
2303         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
2304         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
2305         makes qt DRT to share this implementation (as gtk and mac ports do).
2306
2307         * DumpRenderTree/qt/DumpRenderTree.pro:
2308         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
2309         * DumpRenderTree/qt/WorkQueue.h: Removed.
2310
2311 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2312
2313         Unreviewed potential buildbot fix.
2314
2315         Second try: Reset page history before running each test.
2316
2317         Apparently the QWebHistory::clear() keeps the current page
2318         in history which is not what we want, so we not additionally
2319         sets the history capacity to 0 (forces removing everything)
2320         and then sets it back to its original value.
2321
2322         * DumpRenderTree/qt/DumpRenderTree.cpp:
2323         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2324
2325 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2326
2327         Unreviewed potential buildbot fix.
2328
2329         Reset page history before running each test.
2330
2331         * DumpRenderTree/qt/DumpRenderTree.cpp:
2332         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2333
2334 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
2335
2336         Reviewed by Eric Seidel.
2337
2338         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
2339
2340         Bug 28420 -  Implement HTML5 <ruby> rendering
2341         (https://bugs.webkit.org/show_bug.cgi?id=28420)
2342
2343         No new tests (no functional change).
2344
2345         * Scripts/build-webkit:
2346
2347 2009-10-29  Dan Bernstein  <mitz@apple.com>
2348
2349         Reviewed by Mark Rowe.
2350
2351         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
2352         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
2353         define it.
2354
2355         * Scripts/VCSUtils.pm:
2356         * Scripts/svn-apply:
2357         * Scripts/svn-unapply:
2358
2359 2009-10-29  Xan Lopez  <xlopez@igalia.com>
2360
2361         Reviewed by Gustavo Noronha.
2362
2363         Use the GTK+ main loop instead of rolling our own mini-version of
2364         it.
2365
2366         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2367         (dump):
2368         (runTest):
2369         (webViewLoadFinished):
2370
2371 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2372
2373         Reviewed by Oliver Hunt.
2374
2375         Implement the Qt version of DRT dumpBackForwardList().
2376
2377         * DumpRenderTree/qt/DumpRenderTree.cpp:
2378         (WebCore::dumpHistoryItem):
2379         (WebCore::DumpRenderTree::dumpBackForwardList):
2380
2381 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2382
2383         Reviewed by Adam Roben.
2384
2385         Implement DRT functionality for Qt introduced in
2386         r28690 and r28705.
2387
2388         - Implemented pathToLocalResource which exposes the functionality of
2389         converting a given unix path to the correct location on Windows.
2390         - Implemented a way to remove machine-dependent information from paths
2391         in layout test results.
2392
2393         * DumpRenderTree/qt/DumpRenderTree.cpp:
2394         (WebCore::urlSuitableForTestResult):
2395         (WebCore::WebPage::javaScriptConsoleMessage):
2396         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2397         (LayoutTestController::pathToLocalResource):
2398         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2399
2400 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
2401
2402         Adding myself to the committers list.
2403
2404         * Scripts/modules/committers.py:
2405
2406 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
2407
2408         Adding myself to the committers list.
2409
2410         * Scripts/modules/committers.py:
2411
2412 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2413
2414         Reviewed by Jan Alonzo.
2415
2416         [GTK] API to start inspector for a WebView
2417         https://bugs.webkit.org/show_bug.cgi?id=22551
2418
2419         Use the new inspector API to implement the LayoutTestController
2420         interfaces used to test the inspector.
2421
2422         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2423         (webInspectorInspectWebView):
2424         (createWebView):
2425         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2426         (LayoutTestController::showWebInspector):
2427         (LayoutTestController::closeWebInspector):
2428         (LayoutTestController::evaluateInWebInspector):
2429
2430 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
2431
2432         Reviewed by Eric Seidel.
2433
2434         [Qt] WebFrame::counterValueForElementById must not be exposed
2435         https://bugs.webkit.org/show_bug.cgi?id=30882
2436
2437         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2438         (LayoutTestController::counterValueForElementById):
2439
2440 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2441
2442         Rubberstamped by Oliver Hunt.
2443
2444         Fix the warning:
2445
2446         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
2447         declared with attribute warn_unused_result".
2448
2449         by actually checking the result. In the case it is null, an
2450         error has occoured, so treat it as the other fatal errors.
2451
2452         * DumpRenderTree/qt/DumpRenderTree.cpp:
2453         (WebCore::DumpRenderTree::initializeFonts):
2454
2455 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
2456
2457         Reviewed by Darin Adler.
2458
2459         Provide a way to get counter values with layoutTestContoller
2460         https://bugs.webkit.org/show_bug.cgi?id=30555
2461
2462         Define layoutTestContoller.counterValueForElementById.
2463
2464         * DumpRenderTree/LayoutTestController.cpp:
2465         (counterValueForElementByIdCallback):
2466         (LayoutTestController::staticFunctions):
2467         * DumpRenderTree/LayoutTestController.h:
2468         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2469         (LayoutTestController::counterValueForElementById):
2470
2471 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2472
2473         Rubberstamped by Oliver Hunt.
2474
2475         Change two methods to be internal for DRT use only.
2476
2477         Part of [Qt] Review all new API in Qt 4.6
2478         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
2479
2480         * DumpRenderTree/qt/DumpRenderTree.cpp:
2481         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2482         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2483         (LayoutTestController::whiteListAccessFromOrigin):
2484
2485 2009-10-27  Eric Seidel  <eric@webkit.org>
2486
2487         Reviewed by Adam Barth.
2488
2489         REGRESSION: svn-apply exits(1) when applying a patch with a file add
2490         https://bugs.webkit.org/show_bug.cgi?id=30826
2491
2492         * Scripts/svn-apply:
2493          - Add () around all system() calls.
2494          - Use the correct system() == 0 or die instead of system() or die
2495          - Add descriptive messages to all die statements.
2496
2497 2009-10-27  Steve Block  <steveblock@google.com>
2498
2499         Reviewed by NOBODY.
2500
2501         Adds steveblock@google.com to list of committers.
2502
2503         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
2504
2505 2009-10-27  Eric Seidel  <eric@webkit.org>
2506
2507         Reviewed by Adam Barth.
2508
2509         svn-apply can exit(0) even on patch failure
2510         https://bugs.webkit.org/show_bug.cgi?id=29622
2511
2512         * Scripts/svn-apply:
2513          - Add a bunch of "or die" statements, hopefully catching all
2514            possible cases where failure could still exit(0).
2515
2516 2009-10-27  Eric Seidel  <eric@webkit.org>
2517
2518         Reviewed by Adam Barth.
2519
2520         svn-* scripts should share code through VCSUtils.pm
2521         https://bugs.webkit.org/show_bug.cgi?id=30791
2522
2523         Just moving code into a shared location.
2524
2525         * Scripts/VCSUtils.pm:
2526         * Scripts/prepare-ChangeLog:
2527         * Scripts/resolve-ChangeLogs:
2528         * Scripts/svn-apply:
2529         * Scripts/svn-create-patch:
2530         * Scripts/svn-unapply:
2531         * Scripts/update-webkit:
2532
2533 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
2534
2535         Suppress a huge number of MSVC warnings when building wxWebKit.
2536
2537         * wx/build/settings.py:
2538
2539 2009-10-26  Eric Seidel  <eric@webkit.org>
2540
2541         No review, just adding Mike Belshe to the committers list.
2542
2543         * Scripts/modules/committers.py:
2544
2545 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2546
2547         Reviewed by Darin Adler.
2548
2549         Make .rc files compile on Windows without depending on MFC headers
2550         https://bugs.webkit.org/show_bug.cgi?id=30750
2551
2552         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
2553         windows.h instead of afxres.h because it exists even when MFC is not 
2554         installed, and is all that's needed here.
2555
2556         * FindSafari/FindSafari.rc: Ditto
2557
2558 2009-10-24  Eric Seidel  <eric@webkit.org>
2559
2560         Reviewed by Adam Barth.
2561
2562         bugzilla-tool post-diff should know how to mark commit-queue=?
2563         https://bugs.webkit.org/show_bug.cgi?id=29202
2564
2565         * Scripts/bugzilla-tool:
2566          - Add --commit-queue option to post-diff, post-commits and create-bug.
2567         * Scripts/modules/bugzilla.py:
2568          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
2569          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
2570
2571 2009-10-23  Eric Seidel  <eric@webkit.org>
2572
2573         Reviewed by Adam Barth.
2574
2575         bugzilla-tool commit-queue does not notice modifications to committers.py
2576         https://bugs.webkit.org/show_bug.cgi?id=30084
2577
2578         * Scripts/bugzilla-tool:
2579          - Make commit-queue re-exec itself instead of using while(1).
2580          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
2581          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
2582
2583 2009-10-22  Eric Seidel  <eric@webkit.org>
2584
2585         Reviewed by Adam Barth.
2586
2587         commit-queue will get stuck on patches if land-patches terminates unexpectedly
2588         https://bugs.webkit.org/show_bug.cgi?id=30634
2589
2590         * Scripts/bugzilla-tool:
2591          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
2592          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
2593
2594 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
2595
2596         Reviewed by Eric Seidel.
2597
2598         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
2599
2600         https://bugs.webkit.org/show_bug.cgi?id=30763
2601
2602         * pywebsocket/mod_pywebsocket/__init__.py:
2603         * pywebsocket/mod_pywebsocket/dispatch.py:
2604         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
2605         * pywebsocket/mod_pywebsocket/standalone.py:
2606         * pywebsocket/setup.py:
2607         * pywebsocket/test/test_dispatch.py:
2608
2609 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
2610
2611         Reviewed by David Levin.
2612
2613         REGRESSION: 2 failures in run-webkit-unittests
2614         https://bugs.webkit.org/show_bug.cgi?id=30645
2615
2616         * Scripts/modules/cpp_style_unittest.py:
2617         Fixed a few test scenarios which apparently lost some spaces from 
2618         text literals.
2619
2620 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
2621
2622         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
2623
2624         * Scripts/webkitdirs.pm:
2625
2626 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
2627
2628         Reviewed by Darin Adler.
2629
2630         Unification of using null device in perl scripts.
2631         https://bugs.webkit.org/show_bug.cgi?id=30572
2632
2633         * Scripts/VCSUtils.pm:
2634         * Scripts/bisect-builds:
2635         * Scripts/resolve-ChangeLogs:
2636         * Scripts/run-iexploder-tests:
2637         * Scripts/run-jsc:
2638         * Scripts/run-mangleme-tests:
2639         * Scripts/run-webkit-tests:
2640         * Scripts/webkitdirs.pm:
2641         Using File::Spec->devnull() instead of hard coded /dev/null.
2642
2643 2009-10-26  Eric Seidel  <eric@webkit.org>
2644
2645         Reviewed by Holger Freyther.
2646
2647         Reviewers are missing from committers.py
2648         https://bugs.webkit.org/show_bug.cgi?id=30733
2649
2650         * Scripts/modules/committers.py:
2651
2652 2009-10-23  Eric Seidel  <eric@webkit.org>
2653
2654         No review, only adding Alice to the list of reviewers.
2655
2656         * Scripts/modules/committers.py:
2657
2658 2009-10-23  Eric Seidel  <eric@webkit.org>
2659
2660         Reviewed by Eric Carlson.
2661
2662         fast/media/mq-transform-02.html failed on Leopard Commit Bot
2663         https://bugs.webkit.org/show_bug.cgi?id=30700
2664
2665         * DumpRenderTree/mac/DumpRenderTree.mm:
2666         (resetDefaultsToConsistentValues): Update QuickTime version check.
2667
2668 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
2669
2670         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
2671         character measurement APIs that are private on Tiger.
2672
2673         * wx/build/settings.py:
2674
2675 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2676
2677         Reviewed by NOBODY (build fix).
2678         Build fix following bug #30696.
2679
2680         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2681         (LayoutTestController::evaluateScriptInIsolatedWorld):
2682
2683 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2684
2685         Reviewed by Sam Weinig & Geoff Garen.
2686
2687         https://bugs.webkit.org/show_bug.cgi?id=30696
2688         Enable isolated-worlds tests on mac.
2689
2690         Add private interface for DRT to invoke execution in a given world.
2691
2692         * DumpRenderTree/LayoutTestController.cpp:
2693         (evaluateScriptInIsolatedWorldCallback):
2694         (LayoutTestController::staticFunctions):
2695         * DumpRenderTree/LayoutTestController.h:
2696         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2697         (LayoutTestController::evaluateScriptInIsolatedWorld):
2698         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2699         (LayoutTestController::evaluateScriptInIsolatedWorld):
2700
2701 2009-10-21  Eric Seidel  <eric@webkit.org>
2702
2703         Reviewed by Adam Barth.
2704
2705         bugzilla-tool's "patch failed to download an apply" error should give more information
2706         https://bugs.webkit.org/show_bug.cgi?id=30632
2707
2708         * Scripts/modules/scm.py:
2709          - Use the common run_command method instead of custom POpen code.
2710          - Make run_command know how to take pipes as input.
2711         * Scripts/modules/scm_unittest.py:
2712          - Add new tests to cover change.
2713          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
2714
2715 2009-10-21  Kent Tamura  <tkent@chromium.org>
2716
2717         Unreviewed.  Adding myself to the committers list.
2718
2719         * Scripts/modules/committers.py:
2720
2721 2009-10-21  Robin Dunn  <robin@alldunn.com>
2722
2723         Reviewed by Kevin Ollivier.
2724
2725         Update the Windows installer builder to work with Vista / Win 7 and with git.
2726         
2727         https://bugs.webkit.org/show_bug.cgi?id=30649
2728
2729         * wx/build/build_utils.py:
2730         * wx/packaging/build-mac-installer.py:
2731         * wx/packaging/build-win-installer.py:
2732         * wx/packaging/wxWebKitInstaller.iss.in:
2733
2734 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2735
2736         Reviewed by Gustavo Noronha.
2737
2738         [GTK] Added conditional code to avoid using
2739         gdk_window_get_root_coords if we do not have a gtk+ release newer
2740         than 2.17.3.
2741         https://bugs.webkit.org/show_bug.cgi?id=30636
2742
2743         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2744
2745 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
2746
2747         Reviewed by Eric Seidel.
2748
2749         [Qt] Added dummy implementation for keepWebHistory()
2750         https://bugs.webkit.org/show_bug.cgi?id=30592
2751
2752         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2753         (LayoutTestController::keepWebHistory):
2754         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2755
2756 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2757
2758         Reviewed by Xan Lopez.
2759
2760         [GTK] Fixed the double click condition, it is not double click if
2761         we move in just in one direction.
2762         https://bugs.webkit.org/show_bug.cgi?id=30636
2763
2764         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2765
2766 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2767
2768         Reviewed by Xan Lopez.
2769
2770         [GTK] Initialize the events completly before emitting them.
2771         https://bugs.webkit.org/show_bug.cgi?id=30633
2772
2773         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2774
2775 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2776
2777         wx build fix. Fix for when linking using --as-needed with gcc.
2778
2779         * wx/browser/wscript:
2780
2781 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2782
2783         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
2784         to support all the features used by CURL backend.
2785         
2786         * wx/build/settings.py:
2787         * wx/install-unix-extras:
2788
2789 2009-10-20  Anton Muhin  <antonm@chromium.org>
2790
2791         Reviewed by Adam Barth.
2792
2793         Add {ager,antonm,yurys}@chromium.org into committers.py
2794         https://bugs.webkit.org/show_bug.cgi?id=30560
2795
2796         * Scripts/modules/committers.py:
2797
2798 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2799
2800         Reviewed by Tor Arne Vestbø.
2801
2802         Make the Netscape Test plugin available to the Qt launcher.
2803
2804         * Scripts/run-launcher:
2805
2806 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
2807
2808         Reviewed by David Levin.
2809
2810         Removed WebSocket runtime settings.
2811         https://bugs.webkit.org/show_bug.cgi?id=29896
2812
2813         WebSocket runtime configuration is supported by chromium/v8 only.
2814
2815         * DumpRenderTree/mac/DumpRenderTree.mm:
2816         (resetDefaultsToConsistentValues):
2817         * DumpRenderTree/win/DumpRenderTree.cpp:
2818         (resetDefaultsToConsistentValues):
2819
2820 2009-10-19  Nate Chapin  <japhet@chromium.org>
2821
2822         Reviewed by Adam Barth.
2823
2824         Add testFail() to test plugin so we can test our handling of a
2825         plugin invoke call returning false.
2826
2827         https://bugs.webkit.org/show_bug.cgi?id=30239
2828
2829         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
2830         (pluginInvoke):
2831         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
2832
2833 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
2834
2835         Reviewed by Gustavo Noronha.
2836
2837         Enable DOM pasting when running layout tests.
2838
2839         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2840         (resetDefaultsToConsistentValues):
2841
2842 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2843
2844         Reviewed by Simon Hausmann.
2845
2846         Use the setPreferredContentsSize method instead
2847         of setFixedContentsSize, as the method has been renamed.
2848
2849         * DumpRenderTree/qt/DumpRenderTree.cpp:
2850         (WebCore::DumpRenderTree::open):
2851         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2852         (LayoutTestController::setFixedContentsSize):
2853
2854 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2855
2856         Reviewed by Dan Bernstein.
2857
2858         https://bugs.webkit.org/show_bug.cgi?id=30456
2859         Fixes for new Debug_All Windows build configuration.
2860
2861         * DumpRenderTree/win/DumpRenderTree.cpp:
2862         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
2863         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
2864
2865 2009-10-16  Eric Seidel  <eric@webkit.org>
2866
2867         Reviewed by Adam Barth.
2868
2869         commit-queue status bot should list which buildbot is blocking the queue
2870         https://bugs.webkit.org/show_bug.cgi?id=30452
2871
2872         Add new methods and testing.
2873
2874         * Scripts/bugzilla-tool:
2875         * Scripts/modules/buildbot.py:
2876         * Scripts/modules/buildbot_unittest.py:
2877
2878 2009-10-16  Eric Seidel  <eric@webkit.org>
2879
2880         Reviewed by Adam Barth.
2881
2882         run-webkit-tests fails when CWD is not inside a WebKit checkout
2883         https://bugs.webkit.org/show_bug.cgi?id=30451
2884
2885         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
2886         * Scripts/modules/scm_unittest.py:
2887           - Remove use of original_path (we don't need to restore the CWD).
2888           - Don't use '.' to find the webkit checkout, use __file__ instead.
2889
2890 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2891
2892         Reviewed by Adam Roben.
2893
2894         Add a Debug_All configuration to build entire stack as debug.
2895         Change Debug_Internal to:
2896         - stop using _debug suffix for all WebKit/Safari binaries
2897         - not use _debug as a DLL naming suffix
2898         - use non-debug C runtime lib.
2899
2900         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
2901         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
2902         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
2903         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2904         Add missing debug.vsprops inherited property sheet.
2905         Add Debug_All configuration.
2906         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
2907         * WinLauncher/WinLauncher.vcproj:
2908         Removed extraneous definitions inherited from vsprops.
2909         Add Debug_All configuration.
2910
2911 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
2912
2913         Reviewed by David Levin.
2914
2915         check-webkit-style is wrong about indent checking in namespaces
2916         in header files and a few other things
2917         https://bugs.webkit.org/show_bug.cgi?id=30362
2918
2919         The few other things include:
2920         + check-webkit-style does not require spaces around the equal sign
2921           inside 'if' statements and around binary operators that take 
2922           numeric literals.
2923         + check-webkit-style reports false errors for the / operator
2924           when part of a filename in the #include directive.
2925
2926         * Scripts/modules/cpp_style.py:
2927         Improved indentation checking and space checking around
2928         binary operators. While the checks are still not perfect,
2929         they are clearly better than before.
2930         * Scripts/modules/cpp_style_unittest.py:
2931         Added test cases for the newly supported checks and modified old
2932         test cases to match the new guidelines
2933
2934 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
2935
2936         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
2937
2938         * wx/build/settings.py:
2939
2940 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
2941
2942         Reviewed by David Levin.
2943
2944         Add mod_pywebsocket to test Web Sockets.
2945         http://code.google.com/p/pywebsocket/
2946         https://bugs.webkit.org/show_bug.cgi?id=27490
2947
2948         * pywebsocket/COPYING: Added.
2949         * pywebsocket/MANIFEST.in: Added.
2950         * pywebsocket/README: Added.
2951         * pywebsocket/example/echo_client.py: Added.
2952         * pywebsocket/example/echo_wsh.py: Added.
2953         * pywebsocket/mod_pywebsocket/__init__.py: Added.
2954         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
2955         * pywebsocket/mod_pywebsocket/handshake.py: Added.
2956         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
2957         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
2958         * pywebsocket/mod_pywebsocket/standalone.py: Added.
2959         * pywebsocket/mod_pywebsocket/util.py: Added.
2960         * pywebsocket/setup.py: Added.
2961         * pywebsocket/test/config.py: Added.
2962         * pywebsocket/test/mock.py: Added.
2963         * pywebsocket/test/run_all.py: Added.
2964         * pywebsocket/test/test_dispatch.py: Added.
2965         * pywebsocket/test/test_handshake.py: Added.
2966         * pywebsocket/test/test_mock.py: Added.
2967         * pywebsocket/test/test_msgutil.py: Added.
2968         * pywebsocket/test/test_util.py: Added.
2969         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
2970         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
2971         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
2972         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
2973         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
2974         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
2975         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
2976         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
2977
2978 2009-10-15  James Robinson  <jamesr@google.com>
2979
2980         Reviewed by David Levin.
2981
2982         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
2983
2984         https://bugs.webkit.org/show_bug.cgi?id=30426
2985
2986         * Scripts/modules/cpp_style.py:
2987         * Scripts/modules/cpp_style_unittest.py:
2988
2989 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
2990
2991         Reviewed by Adam Roben.
2992
2993         Fixes <http://webkit.org/b/30411>.
2994         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
2995         
2996         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
2997         building Chromium.
2998
2999         * Scripts/pdevenv:
3000
3001 2009-10-15  Robin Dunn  <robin@alldunn.com>
3002
3003         Reviewed by Kevin Ollivier.
3004
3005         Add Mac package building scripts for wx.
3006         
3007         https://bugs.webkit.org/show_bug.cgi?id=30405
3008
3009         * wx/build/build_utils.py:
3010         * wx/build/settings.py:
3011         * wx/packaging/build-mac-installer.py: Added.
3012
3013 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
3014
3015         Reviewed by Gustavo Noronha.
3016
3017         Enable Web Sockets support when running layout tests.
3018
3019         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3020         (resetDefaultsToConsistentValues):
3021
3022 2009-10-15  Xan Lopez  <xlopez@igalia.com>
3023
3024         Reviewed by Gustavo Noronha.
3025
3026         Need to initialize event.button.button, since in most cases a
3027         button number is not passed as an argument.
3028
3029         * DumpRenderTree/gtk/EventSender.cpp:
3030         (mouseDownCallback):
3031         (mouseUpCallback):
3032
3033 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
3034
3035         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
3036         the OS if none was explicitly set.
3037
3038         * wx/build/settings.py:
3039
3040 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
3041
3042         Reviewed by Timothy Hatcher.
3043
3044         Web Inspector: enable developers extras within inspector layout tests.
3045
3046         https://bugs.webkit.org/show_bug.cgi?id=30014
3047
3048         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3049         (LayoutTestController::showWebInspector):
3050         (LayoutTestController::closeWebInspector):
3051         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3052         (LayoutTestController::showWebInspector):
3053         (LayoutTestController::closeWebInspector):
3054
3055 2009-10-14  José Millán Soto  <jmillan@igalia.com>
3056
3057         Reviewed by Jan Alonzo.
3058
3059         GtkLauncher is using a deprecated signal
3060         https://bugs.webkit.org/show_bug.cgi?id=30364
3061
3062         Modified GtkLauncher to use notify::title signal instead of
3063         deprecated title-changed signal
3064
3065         * GtkLauncher/main.c:
3066         (notify_title_cb):
3067         (create_browser):
3068
3069 2009-10-14  Brady Eidson  <beidson@apple.com>
3070
3071         Reviewed by Sam Weinig.
3072
3073         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
3074         1 - Disables WebHistory
3075         2 - Doesn't make sense in that context anyway.
3076
3077         * DumpRenderTree/win/DumpRenderTree.cpp:
3078         (createWebViewAndOffscreenWindow):
3079
3080 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
3081
3082         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
3083         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
3084
3085         * wx/build/settings.py:
3086         * wx/install-unix-extras:
3087
3088 2009-10-14  Brady Eidson  <beidson@apple.com>
3089
3090         Reviewed by Sam Weinig.
3091
3092         WebKit Win API should provide a delegate interface for global history.
3093         https://bugs.webkit.org/show_bug.cgi?id=29905
3094
3095         * DumpRenderTree/LayoutTestController.cpp:
3096         (LayoutTestController::LayoutTestController):
3097         * DumpRenderTree/LayoutTestController.h:
3098         (LayoutTestController::dumpHistoryDelegateCallbacks):
3099         (LayoutTestController::setDumpHistoryDelegateCallbacks):
3100                 
3101         * DumpRenderTree/win/DumpRenderTree.cpp:
3102         (shouldLogHistoryDelegates):
3103         (runTest):
3104         (createWebViewAndOffscreenWindow):
3105         (main):
3106         * DumpRenderTree/win/DumpRenderTree.vcproj:
3107         
3108         Add the IWebHistoryDelegate to DRT Windows:
3109         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
3110         (wstringFromBSTR):
3111         (HistoryDelegate::HistoryDelegate):
3112         (HistoryDelegate::~HistoryDelegate):
3113         (HistoryDelegate::QueryInterface):
3114         (HistoryDelegate::AddRef):
3115         (HistoryDelegate::Release):
3116         (HistoryDelegate::didNavigateWithNavigationData):
3117         (HistoryDelegate::didPerformClientRedirectFromURL):
3118         (HistoryDelegate::didPerformServerRedirectFromURL):
3119         (HistoryDelegate::updateHistoryTitle):
3120         (HistoryDelegate::populateVisitedLinksForWebView):
3121         * DumpRenderTree/win/HistoryDelegate.h: Added.
3122
3123         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3124         (LayoutTestController::removeAllVisitedLinks):
3125
3126 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
3127
3128         Reviewed by Simon Hausmann.
3129
3130         [Qt] Implement support for setPOSIXLocale on Qt.
3131         https://bugs.webkit.org/show_bug.cgi?id=30268 
3132  
3133         * DumpRenderTree/qt/DumpRenderTree.cpp:
3134         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3135         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3136         (LayoutTestController::setPOSIXLocale):
3137         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3138
3139 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3140
3141         Unreviewed, adding myself to reviewers list.
3142
3143         * Scripts/modules/committers.py:
3144
3145 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3146
3147         Reviewed by Mark Rowe.
3148
3149         Fix null assignment so root tests work again.
3150
3151         * Scripts/webkitdirs.pm:
3152
3153 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3154
3155         Reviewed by Simon Hausmann.
3156
3157         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
3158         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
3159         This is done in preparation of implementing missing features in DRT.
3160         No functionality changes made yet.
3161
3162         * DumpRenderTree/qt/DumpRenderTree.cpp:
3163         * DumpRenderTree/qt/DumpRenderTree.pro:
3164         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
3165         (EventSender::EventSender):
3166         (EventSender::mouseDown):
3167         (EventSender::mouseUp):
3168         (EventSender::mouseMoveTo):
3169         (EventSender::leapForward):
3170         (EventSender::keyDown):
3171         (EventSender::contextClick):
3172         (EventSender::scheduleAsynchronousClick):
3173         (EventSender::frameUnderMouse):
3174         * DumpRenderTree/qt/EventSenderQt.h: Added.
3175         (EventSender::clearKillRing):
3176         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
3177         (LayoutTestController::LayoutTestController):
3178         (LayoutTestController::reset):
3179         (LayoutTestController::processWork):
3180         (LayoutTestController::maybeDump):
3181         (LayoutTestController::waitUntilDone):
3182         (LayoutTestController::notifyDone):
3183         (LayoutTestController::windowCount):
3184         (LayoutTestController::clearBackForwardList):
3185         (LayoutTestController::dumpEditingCallbacks):
3186         (LayoutTestController::dumpResourceLoadCallbacks):
3187         (LayoutTestController::queueBackNavigation):
3188         (LayoutTestController::queueForwardNavigation):
3189         (LayoutTestController::queueLoad):
3190         (LayoutTestController::queueReload):
3191         (LayoutTestController::queueScript):
3192         (LayoutTestController::provisionalLoad):
3193         (LayoutTestController::timerEvent):
3194         (LayoutTestController::encodeHostName):
3195         (LayoutTestController::decodeHostName):
3196         (LayoutTestController::setJavaScriptProfilingEnabled):
3197         (LayoutTestController::setFixedContentsSize):
3198         (LayoutTestController::setPrivateBrowsingEnabled):
3199         (LayoutTestController::setPopupBlockingEnabled):
3200         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3201         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3202         (LayoutTestController::numberOfActiveAnimations):
3203         (LayoutTestController::disableImageLoading):
3204         (LayoutTestController::dispatchPendingLoadRequests):
3205         (LayoutTestController::setDatabaseQuota):
3206         (LayoutTestController::clearAllDatabases):
3207         (LayoutTestController::whiteListAccessFromOrigin):
3208         (LayoutTestController::waitForPolicyDelegate):
3209         (LayoutTestController::overridePreference):
3210         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
3211         (LayoutTestController::isLoading):
3212         (LayoutTestController::setLoading):
3213         (LayoutTestController::shouldDumpAsText):
3214         (LayoutTestController::shouldDumpBackForwardList):
3215         (LayoutTestController::shouldDumpChildrenAsText):
3216         (LayoutTestController::shouldDumpDatabaseCallbacks):
3217         (LayoutTestController::shouldDumpStatusCallbacks):
3218         (LayoutTestController::shouldWaitUntilDone):
3219         (LayoutTestController::canOpenWindows):
3220         (LayoutTestController::shouldDumpTitleChanges):
3221         (LayoutTestController::waitForPolicy):
3222         (LayoutTestController::dumpAsText):
3223         (LayoutTestController::dumpChildFramesAsText):
3224         (LayoutTestController::dumpDatabaseCallbacks):
3225         (LayoutTestController::dumpStatusCallbacks):
3226         (LayoutTestController::setCanOpenWindows):
3227         (LayoutTestController::dumpBackForwardList):
3228         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3229         (LayoutTestController::display):
3230         (LayoutTestController::dumpTitleChanges):
3231         (LayoutTestController::dumpSelectionRect):
3232         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
3233         (TextInputController::TextInputController):
3234         (TextInputController::doCommand):
3235         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
3236         * DumpRenderTree/qt/WorkQueue.cpp:
3237         * DumpRenderTree/qt/WorkQueue.h:
3238         * DumpRenderTree/qt/WorkQueueItem.h:
3239         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
3240         (findFrameNamed):
3241         (LoadItem::invoke):
3242         (ReloadItem::invoke):
3243         (ScriptItem::invoke):
3244         (BackForwardItem::invoke):
3245         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
3246         * DumpRenderTree/qt/jsobjects.h:
3247
3248 2009-10-13  Dmitry Titov  <dimich@chromium.org>
3249
3250         Not reviewed, adding myself to the list of reviewers.
3251
3252         * Scripts/modules/committers.py:
3253
3254 2009-10-13  Anders Carlsson  <andersca@apple.com>
3255
3256         Reviewed by Sam Weinig.
3257
3258         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
3259
3260         Make the private browsing mode testable by the test plug-in.
3261         
3262         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3263         (pluginGetProperty):
3264         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3265         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3266         (NPP_New):
3267         (NPP_SetValue):
3268
3269 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
3270
3271         No review, just adding self to the list of reviewers.
3272
3273         * Scripts/modules/committers.py:
3274
3275 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
3276
3277         Reviewed by Adam Roben.
3278
3279         Web Inspector: Use proper web view in inspector layout
3280         tests for windows.
3281
3282         https://bugs.webkit.org/show_bug.cgi?id=30298
3283
3284         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3285         (LayoutTestController::showWebInspector):
3286         (LayoutTestController::closeWebInspector):
3287         (LayoutTestController::evaluateInWebInspector):
3288
3289 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
3290
3291         Reviewed by Sam Weinig.
3292
3293         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
3294         https://bugs.webkit.org/show_bug.cgi?id=29841
3295
3296         * DumpRenderTree/mac/DumpRenderTree.mm:
3297         (resetDefaultsToConsistentValues):
3298         * DumpRenderTree/win/DumpRenderTree.cpp:
3299         (resetDefaultsToConsistentValues):
3300
3301 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
3302
3303         Reviewed by Dimitri Glazkov.
3304
3305         Chromium Port - Windows
3306         https://bugs.webkit.org/show_bug.cgi?id=29969
3307
3308         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
3309         * Scripts/webkitdirs.pm:
3310
3311 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
3312
3313         Reviewed by Darin Adler.
3314
3315         jsc scripts cleanup and Qt/GTK fix
3316         https://bugs.webkit.org/show_bug.cgi?id=30288
3317
3318         Duplicated jscPath() moved to webkitdirs.pm.
3319         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
3320         Configuration added (release/debug) to path for Qt-port on Windows.
3321
3322         * Scripts/run-javascriptcore-tests:
3323         * Scripts/run-jsc:
3324         * Scripts/run-sunspider:
3325         * Scripts/sunspider-compare-results:
3326         * Scripts/webkitdirs.pm:
3327
3328 2009-10-11  Adam Barth  <abarth@webkit.org>
3329
3330         Unreviewed.  Add Collin to committers.py.
3331
3332         * Scripts/modules/committers.py:
3333
3334 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
3335
3336         wx build fix, add bindings to source/include dirs now that there are sources there.
3337
3338         * wx/build/settings.py:
3339
3340 2009-10-09  Mark Rowe  <mrowe@apple.com>
3341
3342         Reviewed by Brady Eidson.
3343
3344         Enable plug-in halting in DumpRenderTree.
3345
3346         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
3347         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
3348
3349         * DumpRenderTree/mac/DumpRenderTree.mm:
3350         (resetDefaultsToConsistentValues):
3351         * DumpRenderTree/mac/UIDelegate.mm:
3352         (-[UIDelegate webView:shouldHaltPlugin:]):
3353
3354 2009-10-08  Brady Eidson  <beidson@apple.com>
3355
3356         Reviewed by Dan Bernstein.
3357
3358         Ask the History Delegate to populate the visited links hash.
3359         <rdar://problem/7285293> and https://webkit.org/b/29904
3360
3361         Add the ability for LayoutTestController to clear all visited links.
3362         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
3363
3364         * DumpRenderTree/LayoutTestController.cpp:
3365         (LayoutTestController::LayoutTestController):
3366         (removeAllVisitedLinksCallback):
3367         (LayoutTestController::staticFunctions):
3368         * DumpRenderTree/LayoutTestController.h:
3369         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3370         (LayoutTestController::removeAllVisitedLinks):
3371
3372         * DumpRenderTree/mac/HistoryDelegate.mm:
3373         (-[HistoryDelegate populateVisitedLinksForWebView:]):
3374
3375         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3376         (LayoutTestController::removeAllVisitedLinks):
3377         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3378         (LayoutTestController::removeAllVisitedLinks):
3379         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3380         (LayoutTestController::removeAllVisitedLinks):
3381
3382
3383 2009-10-08  Daniel Bates  <dbates@webkit.org>
3384
3385         Reviewed by Adam Roben.
3386
3387         https://bugs.webkit.org/show_bug.cgi?id=30175
3388         
3389         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
3390         the OLE drag-and-drop return value like the function it emulates. Currently, 
3391         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
3392         whether the drag-and-drop operation was successful or was cancelled.
3393         
3394         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
3395         return value according to whether the drop operation was successful or not.
3396
3397         * DumpRenderTree/win/EventSender.cpp:
3398         (doMouseUp): Added parameter oleDragAndDropReturnValue.
3399         (replaySavedEvents): Ditto.
3400         * DumpRenderTree/win/EventSender.h:
3401         * DumpRenderTree/win/UIDelegate.cpp:
3402         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
3403
3404 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3405
3406         Reviewed by Xan Lopez.
3407
3408         [GTK] Added support for a parameter setting the button that was
3409         pressed in the mouseDown function.
3410         https://bugs.webkit.org/show_bug.cgi?id=30220
3411
3412         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3413
3414 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3415
3416         Reviewed by Xan Lopez.
3417
3418         [GTK] Added a line to the bottom of the expected result to match
3419         the output of the test.
3420         https://bugs.webkit.org/show_bug.cgi?id=30220
3421
3422         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
3423         expected.txt:
3424
3425 2009-10-08  Adam Roben  <aroben@apple.com>
3426
3427         Use QueryInterface to get IWebInspectorPrivate
3428
3429         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
3430         accessed in a more standard way
3431
3432         Reviewed by John Sullivan and Tim Hatcher.
3433
3434         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3435         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
3436         by calling IWebViewPrivate::inspector, then use QueryInterface to get
3437         to the IWebInspectorPrivate interface.
3438
3439 2009-10-07  Adam Roben  <aroben@apple.com>
3440
3441         Implement DRT support for origin whitelisting
3442
3443         Fixes <http://webkit.org/b/30185>.
3444
3445         Reviewed by Eric Seidel.
3446
3447         * DumpRenderTree/win/DumpRenderTree.cpp:
3448         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
3449         whitelist, to match Mac DRT.
3450         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3451         (LayoutTestController::whiteListAccessFromOrigin): Call through to
3452         IWebViewPrivate::whiteListAccessFromOrigin.
3453
3454 2009-10-07  Brady Eidson  <beidson@apple.com>
3455
3456         Reviewed by Darin Adler.
3457
3458         Send title changes to the global history delegate.
3459         <rdar://problem/7285293> and https://webkit.org/b/29904
3460
3461         * DumpRenderTree/mac/HistoryDelegate.mm:
3462         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
3463
3464 2009-10-07  Adam Barth  <abarth@webkit.org>
3465
3466         Unreviewed.  Remove some folks from committers.py who were listed on
3467         the WebKit Team wiki page but who weren't actually listed as commit+.
3468         At some point, we should coorelate this list with the committers
3469         mailing list.
3470
3471         * Scripts/modules/committers.py:
3472
3473 2009-10-07  Adam Barth  <abarth@webkit.org>
3474
3475         Unreviewed.  Import a bunch of committers from the WebKit Team page on
3476         the wiki into committers.py.
3477
3478         * Scripts/modules/committers.py:
3479
3480 2009-10-07  Adam Barth  <abarth@webkit.org>
3481
3482         Unreviewed.  Added Aaron Boodman to committers.py.
3483
3484         * Scripts/modules/committers.py:
3485
3486 2009-10-07  Evan Martin  <evan@chromium.org>
3487
3488         Reviewed by Darin Adler.
3489
3490         Add API to LayoutTestController for re/setting the system locale.
3491         https://bugs.webkit.org/show_bug.cgi?id=18994
3492
3493         * DumpRenderTree/LayoutTestController.cpp:
3494         (setLocaleCallback):
3495         (LayoutTestController::staticFunctions):
3496         (LayoutTestController::setLocale):
3497         * DumpRenderTree/LayoutTestController.h:
3498
3499 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
3500
3501         Reviewed by Jan Alonzo.
3502
3503         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3504         https://bugs.webkit.org/show_bug.cgi?id=29689
3505
3506         Build fix by adding -lfontconfig for DumpRenderTree.
3507
3508         * GNUmakefile.am:
3509
3510 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3511
3512         Reviewed by Simon Hausmann.
3513
3514         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
3515
3516         * Scripts/run-webkit-tests:
3517
3518 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3519
3520         Reviewed by Gustavo Noronha.
3521
3522         "delete" in EventSender is the backspace key, not the delete one.
3523
3524         * DumpRenderTree/gtk/EventSender.cpp:
3525         (keyDownCallback):
3526
3527 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3528
3529         Reviewed by Gustavo Noronha.
3530
3531         getChildrenWithRange expects as last parameter the end index, not
3532         the length of the range. Correct this and clarify the variable
3533         names to reflect how the code works.
3534
3535         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3536         (AccessibilityUIElement::getChildrenWithRange):
3537         (AccessibilityUIElement::getChildAtIndex):
3538
3539 2009-10-06  Mark Rowe  <mrowe@apple.com>
3540
3541         Reviewed by Simon Fraser.
3542
3543         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
3544
3545         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
3546         the fact we have already changed the working directory to the top of the open source tree.
3547
3548 2009-10-06  Julie Parent  <jparent@chromium.org>
3549
3550         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
3551         rather than my committer email.
3552
3553         * Scripts/modules/committers.py:
3554
3555 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3556
3557         Reviewed by Eric Seidel.
3558
3559         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
3560
3561         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
3562         it after each layout test as it should do, making the DRT dump additional output
3563         for all of the subsequent layout tests.
3564
3565         * DumpRenderTree/qt/jsobjects.cpp:
3566         (LayoutTestController::reset):
3567
3568 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3569
3570         Reviewed by Simon Hausmann.
3571
3572         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
3573         fast/dom/assign-to-window-status.html test, which is passing as a result.
3574
3575         https://bugs.webkit.org/show_bug.cgi?id=30127
3576
3577         * DumpRenderTree/qt/DumpRenderTree.cpp:
3578         (WebCore::DumpRenderTree::DumpRenderTree):
3579         (WebCore::DumpRenderTree::statusBarMessage):
3580         * DumpRenderTree/qt/DumpRenderTree.h:
3581         * DumpRenderTree/qt/jsobjects.h:
3582         (LayoutTestController::shouldDumpStatusCallbacks):
3583         (LayoutTestController::dumpStatusCallbacks):
3584
3585 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3586
3587         Reviewed by Simon Hausmann.
3588
3589         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
3590         ignores the argument indicating which mouse button to trigger.
3591         https://bugs.webkit.org/show_bug.cgi?id=30048
3592
3593         This affects the fast/events/mouse-click-events.html layout test.
3594
3595         * DumpRenderTree/qt/jsobjects.cpp:
3596         (EventSender::mouseDown):
3597         (EventSender::mouseUp):
3598         * DumpRenderTree/qt/jsobjects.h:
3599
3600 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3601
3602         Reviewed by Simon Hausmann.
3603
3604         [Qt] Fix the EventSender::keyDown() implementation
3605         https://bugs.webkit.org/show_bug.cgi?id=30043
3606
3607         It should post both a key press event and a key release event,
3608         just like other ports do.
3609
3610         * DumpRenderTree/qt/jsobjects.cpp:
3611         (EventSender::keyDown):
3612
3613 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
3614
3615         wx build fix. Add jpeg to the list of libs to link against.
3616
3617         * wx/build/settings.py:
3618
3619 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
3620
3621         Reviewed by Simon Hausmann.
3622
3623         [Qt] EventSender::keyDown() cannot send function-key events.
3624         https://bugs.webkit.org/show_bug.cgi?id=30044
3625
3626         This affects the fast/events/keydown-function-keys.html layout test.
3627
3628         * DumpRenderTree/qt/jsobjects.cpp:
3629         (EventSender::keyDown):
3630
3631 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
3632
3633         Added --wx-compiler-prefix waf option to allow building wxWebKit with
3634         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
3635
3636         * wx/build/settings.py:
3637         * wx/build/wxpresets.py:
3638
3639 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
3640
3641         Reviewed by Timothy Hatcher.
3642
3643         Web Inspector: add testing harness for Web Inspector.
3644
3645         https://bugs.webkit.org/show_bug.cgi?id=30010
3646
3647         * DumpRenderTree/LayoutTestController.cpp:
3648         (showWebInspectorCallback):
3649         (closeWebInspectorCallback):
3650         (evaluateInWebInspectorCallback):
3651         (LayoutTestController::staticFunctions):
3652         * DumpRenderTree/LayoutTestController.h:
3653         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3654         (LayoutTestController::showWebInspector):
3655         (LayoutTestController::closeWebInspector):
3656         (LayoutTestController::evaluateInWebInspector):
3657         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3658         (LayoutTestController::showWebInspector):
3659         (LayoutTestController::closeWebInspector):
3660         (LayoutTestController::evaluateInWebInspector):
3661         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3662         (LayoutTestController::showWebInspector):
3663         (LayoutTestController::closeWebInspector):
3664         (LayoutTestController::evaluateInWebInspector):
3665         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3666         (LayoutTestController::showWebInspector):
3667         (LayoutTestController::closeWebInspector):
3668         (LayoutTestController::evaluateInWebInspector):
3669
3670 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3671
3672         Reviewed by Ariyha Hidayat.
3673
3674         Pass arguments to system() as a string instead of array
3675
3676         When passed as an array entries with a space fail to translate
3677         to two arguments to the child process, so instead of manually
3678         splitting all the entries in @buildArgs we pass the whole thing
3679         as a string instead.
3680
3681         * Scripts/webkitdirs.pm:
3682
3683 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
3684
3685         Reviewed by David Levin.
3686
3687         check-webkit-style misses whitespace errors for operators:
3688         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
3689         https://bugs.webkit.org/show_bug.cgi?id=30021
3690
3691         * Scripts/modules/cpp_style.py:
3692         Added the operators mentioned above to the same list as == and !=.
3693
3694 2009-10-02  Julie Parent  <jparent@chromium.org>
3695
3696         Unreviewed.
3697
3698         Adding myself and Ojan Vafai as committers, because we are committers.
3699
3700         * Scripts/modules/committers.py:
3701
3702 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
3703
3704         Reviewed by Adam Roben.
3705
3706         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
3707         this will help the patch merging process when TryBots are used.
3708
3709         * Scripts/svn-create-patch:
3710
3711 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
3712
3713         Reviewed by Simon Hausmann.
3714
3715         [Qt] Implement layoutTestController.overridePreference().
3716         https://bugs.webkit.org/show_bug.cgi?id=29970
3717
3718         * DumpRenderTree/qt/DumpRenderTree.cpp:
3719         (WebCore::WebPage::WebPage):
3720         (WebCore::WebPage::resetSettings):
3721         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3722         * DumpRenderTree/qt/jsobjects.cpp:
3723         (LayoutTestController::reset):
3724         (LayoutTestController::setPrivateBrowsingEnabled):
3725         (LayoutTestController::setPopupBlockingEnabled):
3726         (LayoutTestController::overridePreference):
3727         * DumpRenderTree/qt/jsobjects.h:
3728
3729 2009-10-01  Chris Marrin  <cmarrin@apple.com>
3730
3731         Reviewed by Oliver Hunt.
3732
3733         Turn on ENABLE_3D_CANVAS in TOT
3734         https://bugs.webkit.org/show_bug.cgi?id=29906
3735
3736         * Scripts/build-webkit:
3737
3738 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3739
3740         Rubberstamped by Simon Hausmann.
3741
3742         Enable HTTP tests for Qt
3743
3744         * Scripts/run-webkit-tests:
3745
3746 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
3747
3748         Reviewed by Dimitri Glazkov.
3749
3750         build-webkit --chromium now also works on cygwin.
3751
3752         https://bugs.webkit.org/show_bug.cgi?id=29973
3753
3754         * Scripts/webkitdirs.pm:
3755
3756 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
3757
3758         Reviewed by Simon Hausmann.
3759
3760         [Qt] Don't use TCmalloc in DumpRenderTree
3761         https://bugs.webkit.org/show_bug.cgi?id=27029
3762
3763         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
3764
3765         * DumpRenderTree/qt/DumpRenderTree.pro:
3766
3767 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3768
3769         Reviewed by Simon Hausmann.
3770
3771         [Qt] Implement eventSender.scheduleAsynchronousClick().
3772
3773         https://bugs.webkit.org/show_bug.cgi?id=29931
3774
3775         * DumpRenderTree/qt/jsobjects.cpp:
3776         (EventSender::scheduleAsynchronousClick):
3777         * DumpRenderTree/qt/jsobjects.h:
3778
3779 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3780
3781         Reviewed by Simon Hausmann.
3782
3783         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
3784         fast/events/open-window-from-another-frame.html from the Skipped list.
3785
3786         https://bugs.webkit.org/show_bug.cgi?id=29930
3787
3788         * DumpRenderTree/qt/jsobjects.cpp:
3789         (LayoutTestController::setPopupBlockingEnabled):
3790         * DumpRenderTree/qt/jsobjects.h:
3791
3792 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
3793
3794         Unreviewed.
3795
3796         Added myself to the list of committers.
3797
3798         * Scripts/modules/committers.py:
3799
3800 2009-09-30  Eric Seidel  <eric@webkit.org>
3801
3802         No review, just adding Geoff to the list of reviewers.
3803
3804         * Scripts/modules/committers.py:
3805
3806 2009-09-30  Dan Bernstein  <mitz@apple.com>
3807
3808         Reviewed by Sam Weinig.
3809
3810         Added the WebKit Layout Tests fonts that are referenced in
3811         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
3812
3813         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
3814         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
3815
3816 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3817
3818         Reviewed by David Kilzer.
3819
3820         Make sunspider scripts work on Windows platform.
3821         https://bugs.webkit.org/show_bug.cgi?id=29656
3822
3823         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
3824         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
3825         * Scripts/webkitdirs.pm: currentPerlPath() added.
3826
3827 2009-09-29  Brady Eidson  <beidson@apple.com>
3828
3829         Rubberstamped by Dan Bernstein.
3830
3831         Fix license and some sorting in new files.
3832
3833         * DumpRenderTree/mac/HistoryDelegate.h:
3834         * DumpRenderTree/mac/HistoryDelegate.mm:
3835
3836 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
3837
3838         Reviewed by David Kilzer.
3839
3840         Fixed how error codes are handled.
3841         https://bugs.webkit.org/show_bug.cgi?id=29898
3842
3843         * Scripts/update-webkit:
3844         * Scripts/update-webkit-chromium:
3845
3846 2009-09-29  Brady Eidson  <beidson@apple.com>
3847
3848         Reviewed by John Sullivan.
3849
3850         Updated way-out-of-date sorting throughout the dump methods/flags.
3851
3852         * DumpRenderTree/LayoutTestController.cpp:
3853         (LayoutTestController::LayoutTestController):
3854         (dumpAsPDFCallback):
3855         (dumpAsTextCallback):
3856         (dumpFrameLoadCallbacksCallback):
3857         (dumpResourceLoadCallbacksCallback):
3858         (LayoutTestController::staticFunctions):
3859
3860         * DumpRenderTree/LayoutTestController.h:
3861         (LayoutTestController::dumpAsText):
3862         (LayoutTestController::setDumpAsText):
3863         (LayoutTestController::dumpFrameLoadCallbacks):
3864         (LayoutTestController::setDumpFrameLoadCallbacks):
3865         (LayoutTestController::dumpSelectionRect):
3866         (LayoutTestController::setDumpSelectionRect):
3867         (LayoutTestController::dumpSourceAsWebArchive):
3868         (LayoutTestController::setDumpSourceAsWebArchive):
3869         (LayoutTestController::dumpStatusCallbacks):
3870         (LayoutTestController::setDumpStatusCallbacks):
3871         (LayoutTestController::dumpTitleChanges):
3872         (LayoutTestController::setDumpTitleChanges):
3873         (LayoutTestController::dumpWillCacheResponse):
3874         (LayoutTestController::setDumpWillCacheResponse):
3875
3876 2009-09-29  Brady Eidson  <beidson@apple.com>
3877
3878         Reviewed by John Sullivan.
3879
3880         WebKit Mac API should provide a delegate interface for global history.
3881         <rdar://problem/7042773> and https://webkit.org/b/29904
3882
3883         Adding the dumping of global history delegate callbacks.
3884
3885         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3886
3887         Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
3888         * DumpRenderTree/mac/DumpRenderTree.mm:
3889         (createWebViewAndOffscreenWindow):
3890         (allocateGlobalControllers):
3891         (shouldLogFrameLoadDelegates):
3892         (shouldLogHistoryDelegates):
3893         (runTest):
3894
3895         Dump history delegate callbacks:
3896         * DumpRenderTree/mac/HistoryDelegate.h: Added.
3897         * DumpRenderTree/mac/HistoryDelegate.mm: Added.
3898         (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
3899         (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
3900         (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
3901
3902 2009-09-29  Daniel Bates  <dbates@webkit.org>
3903
3904         Reviewed by Adam Roben.
3905
3906         https://bugs.webkit.org/show_bug.cgi?id=28902
3907         
3908         Fixes an issue where the drop effect returned by Window Dump Render Tree 
3909         was always DROPEFFECT_NONE (since it was hard coded to do so).
3910         
3911         This patch corrects this issue by determining the actual drop effect 
3912         performed by the corresponding drag-and-drop operation so that we can 
3913         return it.
3914
3915         * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
3916         (DraggingInfo::DraggingInfo):
3917         (DraggingInfo::performedDropEffect): Added method.
3918         (DraggingInfo::setPerformedDropEffect): Added method.
3919         * DumpRenderTree/win/EventSender.cpp:
3920         (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
3921         Moved delete draggingInfo to UIDelegate::doDragDrop.
3922         * DumpRenderTree/win/UIDelegate.cpp:
3923         (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
3924
3925 2009-09-29  Dan Bernstein  <mitz@apple.com>
3926
3927         Reviewed by Adam Roben.
3928
3929         Remove copying of unnecessary or nonexistent files from the ImageDiff
3930         post-build event.
3931
3932         * DumpRenderTree/win/ImageDiff.vcproj:
3933
3934 2009-09-29  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3935
3936         Reviewed by David Kilzer.
3937
3938         [Qt] Make build-webkit script work on Windows
3939         https://bugs.webkit.org/show_bug.cgi?id=29802
3940
3941         * Scripts/run-webkit-tests:
3942         * Scripts/webkitdirs.pm:
3943          - Removed unnecessary -p switch for mkdir on Windows.
3944          - Use canonical path, which uses slashes or backslashes depends on platform.
3945          - isWindows() only test for Windows and not for Cyqwin.
3946
3947 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3948
3949         Reviewed by Simon Hausmann.
3950
3951         Fix time measurement in build-webkit after refactoring done in r48853.
3952
3953         * Scripts/build-webkit:
3954
3955 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3956
3957         Reviewed by Tor Arne Vestbø.
3958
3959         [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.
3960         This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.
3961
3962         * DumpRenderTree/qt/DumpRenderTree.cpp:
3963         (WebCore::WebPage::WebPage):
3964
3965 2009-09-29  Jakub Wieczorek  <faw217@gmail.com>
3966
3967         Reviewed by Simon Hausmann.
3968
3969         [Qt] Implement eventSender.contextClick().
3970         https://bugs.webkit.org/show_bug.cgi?id=29821
3971
3972         * DumpRenderTree/qt/jsobjects.cpp:
3973         (EventSender::contextClick):
3974         * DumpRenderTree/qt/jsobjects.h:
3975
3976 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
3977
3978         Reviewed by Eric Seidel.
3979
3980         Add experimentalWebSocketsEnabled in WebPreferences.
3981         https://bugs.webkit.org/show_bug.cgi?id=28941
3982
3983         * DumpRenderTree/mac/DumpRenderTree.mm:
3984         (resetDefaultsToConsistentValues):
3985         * DumpRenderTree/win/DumpRenderTree.cpp:
3986         (resetDefaultsToConsistentValues):
3987
3988 2009-09-28  Yaar Schnitman  <yaar@chromium.org>
3989
3990         Reviewed by David Kilzer.
3991
3992         Integrated chromium port building into webkit tools update-webkit and
3993         build-webkit.
3994
3995         https://bugs.webkit.org/show_bug.cgi?id=29749
3996
3997         * Scripts/build-webkit: When --chromium is specified, will build
3998           the chromium port (currently only Mac is supported).
3999         * Scripts/update-webkit: When --chromium is specified, delegates to
4000           update-webkit-chromium.
4001         * Scripts/webkitdirs.pm: Added chromium specific defs.
4002         * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch
4003           chromium port's dependencies and update its project files.
4004
4005 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
4006
4007         Unreviewed.
4008
4009         Add myself to list of committers.
4010
4011         * Scripts/modules/committers.py:
4012
4013 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
4014
4015         Reviewed by Darin Adler.
4016
4017         run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
4018         https://bugs.webkit.org/show_bug.cgi?id=29771
4019
4020         * Scripts/run-webkit-tests:
4021
4022 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
4023
4024         Reviewed by Simon Hausmann.
4025
4026         [Qt] Implement layoutTestController.waitForPolicyDelegate.
4027         https://bugs.webkit.org/show_bug.cgi?id=25037
4028
4029         * DumpRenderTree/qt/DumpRenderTree.cpp:
4030         (WebCore::WebPage::acceptNavigationRequest):
4031         * DumpRenderTree/qt/DumpRenderTree.pro:
4032         * DumpRenderTree/qt/jsobjects.cpp:
4033         (LayoutTestController::reset):
4034         (LayoutTestController::notifyDone):
4035         (LayoutTestController::waitForPolicyDelegate):
4036         * DumpRenderTree/qt/jsobjects.h:
4037         (LayoutTestController::waitForPolicy):
4038
4039 2009-09-26  David Kilzer  <ddkilzer@apple.com>
4040
4041         <http://webkit.org/b/29764> mark-bug-fixed: add -o|--open switch
4042
4043         Reviewed by Eric Seidel.
4044
4045         The -o|--open switch uses the open(1) command on Mac OS X to
4046         open the bug URL in the default web browser.  If there are
4047         similar mechanisms on other platforms, they may be added later.
4048
4049         * Scripts/mark-bug-fixed:
4050         (MarkBugFixed.__init__): Added -o|--open switch to list of parse
4051         options.
4052         (MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
4053         code into main() and extracted prompting code into
4054         _prompt_user_for_correctness().
4055         (MarkBugFixed._open_bug_in_web_browser): Added.
4056         (MarkBugFixed._prompt_user_for_correctness): Added.
4057         (MarkBugFixed.main): Added logging code from
4058         _determine_bug_id_and_svn_revision().  Added code to call
4059         _open_bug_in_web_browser() if the switch is set.  Added code to
4060         call _prompt_user_for_correctness() when needed.
4061         * Scripts/modules/bugzilla.py:
4062         (Bugzilla.short_bug_url_for_bug_id): Added.
4063
4064 2009-09-26  David Kilzer  <ddkilzer@apple.com>
4065
4066         svn-unapply and svn-apply don't work when used outside multiple svn working directories
4067
4068         <http://webkit.org/b/29744>
4069         <rdar://problem/7252905>
4070
4071         Reviewed by Eric Seidel.
4072
4073         Some users have a workflow where svn-create-patch, svn-apply and
4074         svn-unapply are used outside of multiple svn working
4075         directories.  Instead of aborting the scripts in these cases,
4076         print a warning and assume that Subversion is being used.
4077
4078         * Scripts/VCSUtils.pm:
4079         (determineVCSRoot): Call warn() instead of die() if both isGit()
4080         and isSVN() initially return false.  Set $VCSUtils::isSVN to 1
4081         to enforce the assumption about Subversion, then return
4082         determineSVNRoot().
4083         * Scripts/svn-apply: Switch to using isGit() and isSVN() from
4084         VCSUtils.pm.  They both already cache their values and checking
4085         here is redundant since determineVCSRoot() is called later.
4086
4087 2009-09-26  Zan Dobersek  <zandobersek@gmail.com>
4088
4089         Reviewed by Gustavo Noronha.
4090
4091         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
4092         https://bugs.webkit.org/show_bug.cgi?id=29689
4093
4094         Load test fonts through FontConfig before each test.
4095         This ensures a more proper rendering of the tests.
4096
4097         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4098         (initializeFonts):
4099         (runTest):
4100         (main):
4101         * DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf.
4102         * GNUmakefile.am:
4103
4104 2009-09-25  David Kilzer  <ddkilzer@apple.com>
4105
4106         <http://webkit.org/b/29718> mark-bug-fixed: add -u|--update-only switch
4107
4108         Reviewed by Eric Seidel.
4109
4110         * Scripts/mark-bug-fixed:
4111         (MarkBugFixed.__init__): Added -u|--update-only switch to list
4112         of parse options.
4113         (MarkBugFixed.main): When -u|--update-only is specified, add a
4114         comment to the bug without marking it Resolved/Fixed.
4115
4116 2009-09-25  Darin Adler  <darin@apple.com>
4117
4118         Reviewed by Geoffrey Garen.
4119
4120         * Scripts/prepare-ChangeLog: Leave files from the script-tests directory
4121         out, just as we do for the resources directory.
4122
4123 2009-09-25  Adam Barth  <abarth@webkit.org>
4124
4125         Unreviewed.  Added Tony to committers.py because he's a
4126         committer now.
4127
4128         * Scripts/modules/committers.py:
4129
4130 2009-09-25  Eric Seidel  <eric@webkit.org>
4131
4132         Reviewed by Simon Fraser.
4133
4134         REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
4135         https://bugs.webkit.org/show_bug.cgi?id=28624
4136
4137         Disable hardware compositing on Leopard for versions of QuickTime 7.6.4 and older.
4138
4139         * DumpRenderTree/mac/DumpRenderTree.mm:
4140         (resetDefaultsToConsistentValues):
4141
4142 2009-09-25  Eric Seidel  <eric@webkit.org>
4143
4144         Reviewed by Adam Barth.
4145
4146         commit-queue should auto-retry patches which fail to commit due to out of date files
4147         https://bugs.webkit.org/show_bug.cgi?id=28316
4148
4149         * Scripts/bugzilla-tool:
4150          - Handle new CheckoutNeedsUpdate exception.
4151         * Scripts/modules/logging_unittest.py:
4152          - Call the ScriptError constructor correctly (this test had regressed).
4153         * Scripts/modules/scm.py:
4154          - Added the ability to define custom error handlers for run_command
4155            and added a commit_error_handler which throws CheckoutNeedsUpdate
4156            instead of ScriptError.
4157          - Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible.
4158         * Scripts/modules/scm_unittest.py:
4159          - Added tests of new error handlers.
4160
4161 2009-09-25  Eric Seidel  <eric@webkit.org>
4162
4163         Reviewed by Adam Barth.
4164
4165         commit-queue should give better feedback when failing a patch
4166         https://bugs.webkit.org/show_bug.cgi?id=29316
4167
4168         * Scripts/bugzilla-tool:
4169          - Update ScriptError uses to the new constructor format.
4170          - Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output
4171            so that we can print to both stdout as well as an output buffer for error reporting.
4172          - Update run_and_throw_if_fail to use teed output so that it can report the "output" as part of ScriptError.
4173          - Use e.message_with_output() when failing a patch (this is the real fix here).
4174            I also removed use of "This patch will require manual commit." as that's not always true.
4175          - Add missing word "bug" from log message.
4176         * Scripts/modules/scm.py:
4177          - Make ScriptError save a bunch more data so that error messages can be nicer.
4178          - Update ScriptError callers.
4179
4180 2009-09-24  John Gregg  <johnnyg@google.com>
4181
4182         Reviewed by Eric Seidel.
4183
4184         Enable switch for notifications (experimental) in Page Settings
4185         https://bugs.webkit.org/show_bug.cgi?id=28930
4186
4187         Now that desktop notifications are controlled by run-time switch,
4188         set that switch to true for DumpRenderTree.
4189
4190         * DumpRenderTree/mac/DumpRenderTree.mm:
4191         (resetDefaultsToConsistentValues):
4192         * DumpRenderTree/win/DumpRenderTree.cpp:
4193         (resetDefaultsToConsistentValues):
4194         * DumpRenderTree/win/UIDelegate.cpp:
4195         (UIDelegate::QueryInterface):
4196
4197 2009-09-24  Kevin Ollivier  <kevino@theolliviers.com>
4198
4199         wx build fix. SnowLeopard fixes for Mac dependencies.
4200
4201         * wx/build/build_utils.py:
4202         * wx/build/settings.py:
4203         * wx/install-unix-extras:
4204
4205 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
4206
4207         Reviewed by Oliver Hunt.
4208
4209         Add support for DRT to send mouse wheel events.
4210
4211         https://bugs.webkit.org/show_bug.cgi?id=29348
4212         [Gtk] Scrollwheel on horizontal scrollbars should slide horizontally
4213
4214         * DumpRenderTree/gtk/EventSender.cpp:
4215         (mouseWheelToCallback):
4216
4217 2009-09-17  Eric Seidel  <eric@webkit.org>
4218
4219         Reviewed by David Levin.
4220
4221         commit-queue needs web-based status reporting
4222         https://bugs.webkit.org/show_bug.cgi?id=29307
4223
4224         Add a first-pass web-based status for the commit-queue.
4225         The bot is currently reachable at:
4226         http://webkit-commit-queue.appspot.com/
4227
4228         * CommitQueueStatus/app.yaml: Added.
4229          - Application description file required by App Engine.
4230         * CommitQueueStatus/filters/__init__.py: Added.
4231          - Required by python to treat 'filters' as a module.
4232         * CommitQueueStatus/filters/webkit_extras.py: Added.
4233          - Support for turning 'bug 123' and 'patch 123' into links.
4234            This lets us use plain text strings in our logs yet display nice HTML (help prevent XSS attacks on the page).
4235         * CommitQueueStatus/index.html: Added.
4236         * CommitQueueStatus/index.yaml: Added.
4237          - Some auto-generated file from app engine.
4238         * CommitQueueStatus/queue_status.py: Added.
4239          - The core logic of this bot.  We could eventually split this file out into pieces.
4240         * CommitQueueStatus/stylesheets/main.css: Added.
4241          - Some basic lame-o CSS to make the page look less awful.
4242         * CommitQueueStatus/update_status.html: Added.
4243          - The form that the commit-queue (or a human) can use to update the status.
4244         * Scripts/bugzilla-tool:
4245          - Add some very basic update_status calls.
4246         * Scripts/modules/statusbot.py: Added.
4247          - Knows how to post to the CommitQueueStatus web application.
4248
4249 2009-09-24  David Kilzer  <ddkilzer@apple.com>
4250
4251         <http://webkit.org/b/29712> mark-bug-fixed: add -m|--comment switch
4252
4253         Reviewed by Adam Roben.
4254
4255         * Scripts/mark-bug-fixed:
4256         (MarkBugFixed.__init__): Added -m|--comment switch to list of
4257         parse options.
4258         (MarkBugFixed.main): When specified, prepend comment from
4259         -m|--comment command-line switch to the bug comment.
4260
4261 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
4262
4263         Reviewed by Jan Alonzo.
4264
4265         [GTK] DRT must display window instead of just realizing, to enable synthesizing events correctly
4266         https://bugs.webkit.org/show_bug.cgi?id=29693
4267
4268         Show the window, to be able to synthesize events correctly.
4269
4270         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4271         (runTest):
4272         (main):
4273
4274 2009-09-24  Oliver Hunt  <oliver@apple.com>
4275
4276         Reviewed by NOBODY(rollout)
4277
4278         Roll out r48712 as it is incorrect.
4279
4280         * DumpRenderTree/mac/ObjCController.m:
4281         (+[ObjCController isSelectorExcludedFromWebScript:]):
4282         (+[ObjCController webScriptNameForSelector:]):
4283
4284 2009-09-24  Benjamin Poulain  <benjamin.poulain@nokia.com>
4285
4286         Reviewed by Eric Seidel.
4287
4288         https://bugs.webkit.org/show_bug.cgi?id=29005
4289         The indices of RuntimeArray should be enumerated like for a regular array.
4290
4291         * DumpRenderTree/mac/ObjCController.m:
4292         (+[ObjCController isSelectorExcludedFromWebScript:]):
4293         (+[ObjCController webScriptNameForSelector:]):
4294         (-[ObjCController arrayOfString]):
4295
4296 2009-09-23  David Kilzer  <ddkilzer@apple.com>
4297
4298         <http://webkit.org/b/28910> Move bugzilla-tool mark-fixed to standalone mark-bug-fixed tool
4299
4300         Reviewed by Darin Adler.
4301
4302         Also fixed a bug where specifying a revision on the command-line
4303         as 'r12345' would fail.  See <http://webkit.org/b/29699>.
4304
4305         * Scripts/bugzilla-tool: Updated module import statements.
4306         (parse_bug_id): Removed.  Moved to bugzilla.py.
4307         (bug_comment_from_svn_revision): Removed.  Moved to comments.py.
4308         (bug_comment_from_commit_text): Removed.  Moved to comments.py.
4309         (MarkBugFixed): Removed.  Code moved to mark-bug-fixed.
4310         (BugzillaTool.__init__): Removed mark-fixed subcommand.
4311         * Scripts/mark-bug-fixed: Added.
4312         * Scripts/modules/bugzilla.py:
4313         (parse_bug_id): Added.  Moved from bugzilla-tool.
4314         * Scripts/modules/comments.py: Added.
4315         (bug_comment_from_svn_revision): Added.  Moved from bugzilla-tool.
4316         (bug_comment_from_commit_text): Added.  Moved from bugzilla-tool.
4317
4318 2009-09-23  Marshall Culpepper  <mculpepper@appcelerator.com>
4319
4320         Reviewed by Eric Seidel.
4321         
4322          jpeg.lib is now libjpeg.lib in DRT Cairo dependencies. return
4323          "false" in non-implemented stub for setAlwaysAcceptCookies.
4324          https://bugs.webkit.org/show_bug.cgi?id=29661
4325
4326         * DumpRenderTree/win/DumpRenderTree.vcproj:
4327         * DumpRenderTree/win/DumpRenderTree.cpp:
4328
4329 2009-09-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
4330
4331         Reviewed by Xan Lopez.
4332
4333         [GTK] need to dump number of pending unload handlers
4334         https://bugs.webkit.org/show_bug.cgi?id=29685
4335
4336         Implement dumping of the number of pending unload handlers.
4337
4338         The following tests will pass:
4339
4340           fast/loader/unload-form-about-blank.html
4341           fast/loader/unload-form-post-about-blank.html
4342           fast/loader/unload-form-post.html
4343           fast/loader/unload-form.html
4344           fast/loader/unload-hyperlink.html
4345           fast/loader/unload-javascript-url.html
4346           fast/loader/unload-reload.html
4347           fast/loader/unload-window-location.html
4348
4349         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4350         (getFrameNameSuitableForTestResult):
4351         (webViewLoadFinished):
4352
4353 2009-09-22  Shinichiro Hamaji  <hamaji@chromium.org>