WebKitTools/ChangeLog

   1 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
   2
   3         Reviewed by Adam.
   4
   5         - Implemented the WebScriptDebugListener functions now that the
   6         WebScriptDebugServer exists
   7
   8         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
   9         functions.
  10         (ServerConnection::currentFrame):
  11         (ServerConnection::didLoadMainResourceForDataSource):
  12         (ServerConnection::didParseSource):
  13         (ServerConnection::failedToParseSource):
  14         (ServerConnection::didEnterCallFrame):
  15         (ServerConnection::willExecuteStatement):
  16         (ServerConnection::willLeaveCallFrame):
  17         (ServerConnection::exceptionWasRaised):
  18         * Drosera/win/ServerConnection.h: Removed unused arguments from the
  19         members arguments list.
  20
  21 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
  22
  23         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
  24         <http://bugs.webkit.org/show_bug.cgi?id=15600>
  25
  26         Reviewed by Darin.
  27
  28         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
  29         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
  30         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
  31         file.  Note that it may also be used as a stand-alone script.
  32
  33         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
  34         * Scripts/resolve-ChangeLogs: Added.
  35         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
  36
  37 2007-10-26  Mark Rowe  <mrowe@apple.com>
  38
  39         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
  40         to the Qt port on the assumption that it was an implementation of the cross-platform
  41         LayoutTestController class.  It is not, so it did not need to be changed.
  42
  43         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
  44
  45 2007-10-25  Mark Rowe  <mrowe@apple.com>
  46
  47         Reviewed by Maciej.
  48
  49         Fix builds with code coverage enabled.
  50
  51         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
  52
  53 2007-10-25  Darin Adler  <darin@apple.com>
  54
  55         Reviewed by Mark Rowe.
  56
  57         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
  58         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
  59
  60 2007-10-25  Stephanie  <slewis@apple.com>
  61
  62         build Fix
  63
  64         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  65
  66 2007-10-25  Stephanie  <slewis@apple.com>
  67
  68         Reviewed by Mark Rowe, Adam Roben.
  69
  70         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
  71
  72         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  73
  74 2007-10-25  Alice Liu  <alice.liu@apple.com>
  75
  76         Reviewed by Adam.
  77
  78         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
  79
  80         Moving destructor into platform-specific files
  81         * DumpRenderTree/LayoutTestController.cpp:
  82         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  83         (LayoutTestController::~LayoutTestController):
  84         * DumpRenderTree/qt/jsobjects.cpp:
  85         (LayoutTestController::~LayoutTestController):
  86
  87         LayoutTestController wasn't being destroyed
  88         * DumpRenderTree/win/DumpRenderTree.cpp:
  89         (runTest):
  90
  91         Added declspec
  92         * DumpRenderTree/win/EditingDelegate.h:
  93
  94         Reset certain values on the webview (or related delegate) that might
  95         have changed while running a test
  96         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  97         (LayoutTestController::~LayoutTestController):
  98
  99 2007-10-25  Adam Roben  <aroben@apple.com>
 100
 101         Make sunspider-compare-results work with relative paths
 102
 103         Reviewed by Sam.
 104
 105         * Scripts/sunspider-compare-results: Convert arguments to absolute
 106         paths before we chdir.
 107
 108 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
 109
 110         Reviewed by Sam.
 111
 112         - Implemented server calls now the WebScriptDebugServer exists.
 113         - Also removed no longer needed call to initialize CG.
 114
 115         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
 116         automatically now.
 117         (_tWinMain):
 118         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
 119         (ServerConnection::ServerConnection):
 120         (ServerConnection::~ServerConnection):
 121         (ServerConnection::pause):
 122         (ServerConnection::resume):
 123         (ServerConnection::stepInto):
 124         (ServerConnection::applicationTerminating):
 125         (ServerConnection::serverConnectionDidDie):
 126         * Drosera/win/ServerConnection.h: Now uses the COM class.
 127
 128 2007-10-24  George Staikos  <staikos@kde.org>
 129
 130         Unbreak Qt build.
 131
 132         * Scripts/build-webkit:
 133
 134 2007-10-24  Adam Roben  <aroben@apple.com>
 135
 136         Remove now-unnecessary call to InitializeCoreGraphics
 137
 138         WebKit takes care of this now.
 139
 140         Reviewed by Ada.
 141
 142         * DumpRenderTree/win/DumpRenderTree.cpp:
 143         (initialize):
 144
 145 2007-10-24  Adam Roben  <aroben@apple.com>
 146
 147         Use WebTextRenderer in DRT
 148
 149         Reviewed by Ada.
 150
 151         * DumpRenderTree/win/DumpRenderTree.cpp:
 152         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
 153
 154 2007-10-24  Sven Herzberg  <sven@imendio.com>
 155
 156         Reviewed by Mark Rowe.
 157
 158         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
 159         Bug 15614: [GTK] qmake based backends don't build on OS X
 160
 161         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
 162         GTK backend on a Mac
 163         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
 164         isDarwin() to make it reusable in other places (like the workaround-
 165         for-prebuilt-qmake in build-webkit)
 166
 167 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
 168
 169         Refurbish update-webkit script.
 170
 171         Reviewed by Adam.
 172
 173         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
 174         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
 175         multi-argument version of system() for flexibility and security.  Check for existence
 176         of Internal directory using -d test instead of -x.
 177
 178 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
 179
 180         Minor clean-up of prepare-ChangeLog script.
 181
 182         Reviewed by Adam.
 183
 184         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
 185         of a string.  Use multi-argument versions of open() and system() for flexibility and
 186         security.
 187
 188 2007-10-24  Alice Liu  <alice.liu@apple.com>
 189
 190         Reviewed by Oliver.
 191
 192         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
 193
 194         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to
 195         replay the saved events when we're still processing the mousedown that starts the drag
 196         * DumpRenderTree/win/EventSender.cpp:
 197         (doMouseMove):
 198         * DumpRenderTree/win/UIDelegate.cpp:
 199         (UIDelegate::doDragDrop):
 200
 201 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
 202
 203         Reviewed by Sam, Steve and Darin.
 204
 205         - Stubbed out the WebScriptDebugListener functionality in the Server
 206         Connection class to prepare it for receiving those callbacks.
 207         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
 208         and the ServerConnection to not need to be initialized with a server
 209         name, since that is not the way we connect to the WebKit server.
 210
 211         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
 212         no exception.  Now it only loggs when there is an exception
 213         (DebuggerDocument::willExecuteStatement):
 214         (DebuggerDocument::didEnterCallFrame):
 215         (DebuggerDocument::willLeaveCallFrame):
 216         (DebuggerDocument::windowScriptObjectAvailable):
 217         (DebuggerDocument::callFunctionOnObject):
 218         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
 219         to be instantiated with a server's name.
 220         (DebuggerClient::DebuggerClient):
 221         (DebuggerClient::didFinishLoadForFrame):
 222         * Drosera/win/DebuggerClient.h: Removed unsued variable.
 223         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
 224         a server name.
 225         (Drosera::init):
 226         (Drosera::initServer):
 227         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
 228         instantiated with a server's name.
 229         * Drosera/win/ServerConnection.cpp:
 230         (ServerConnection::ServerConnection): No longer needs a server name
 231         (ServerConnection::~ServerConnection): Only release the global context
 232         if there is one.
 233         (ServerConnection::serverConnectionDidDie): Stub for
 234         IWebScriptDebugListener
 235         (ServerConnection::QueryInterface): ditto
 236         (ServerConnection::AddRef): ditto
 237         (ServerConnection::Release): ditto
 238         (ServerConnection::didLoadMainResourceForDataSource): ditto
 239         (ServerConnection::didParseSource): ditto
 240         (ServerConnection::failedToParseSource): ditto
 241         (ServerConnection::didEnterCallFrame): ditto
 242         (ServerConnection::willExecuteStatement): ditto
 243         (ServerConnection::willLeaveCallFrame): ditto
 244         (ServerConnection::exceptionWasRaised): ditto
 245         * Drosera/win/ServerConnection.h: Stubbed out the
 246         IWebScriptDebugListener functions, and this class no longer needs to be
 247         instantiated with a server name.
 248
 249 2007-10-24  Lars Knoll  <lars@trolltech.com>
 250
 251         Reviewed by Simon.
 252
 253         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
 254
 255         * DumpRenderTree/qt/jsobjects.h:
 256
 257 2007-10-24  Lars Knoll  <lars@trolltech.com>
 258
 259         Reviewed by Simon.
 260
 261         add another command.
 262
 263         * DumpRenderTree/qt/jsobjects.cpp:
 264         (TextInputController::doCommand):
 265
 266 2007-10-24  Lars Knoll  <lars@trolltech.com>
 267
 268         Reviewed by Simon.
 269
 270         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
 271
 272         * DumpRenderTree/qt/jsobjects.cpp:
 273         (EventSender::keyDown):
 274         * DumpRenderTree/qt/jsobjects.h:
 275
 276 2007-10-24  Lars Knoll  <lars@trolltech.com>
 277
 278         Reviewed by Simon.
 279
 280         implement eventSender.keyDown().
 281
 282         * DumpRenderTree/qt/jsobjects.cpp:
 283         (EventSender::keyDown):
 284
 285 2007-10-24  Lars Knoll  <lars@trolltech.com>
 286
 287         Reviewed by Simon.
 288
 289         some smaller fixes to the editing support in DRT. Makes another few tests pass.
 290
 291         * DumpRenderTree/qt/DumpRenderTree.cpp:
 292         (WebCore::DumpRenderTree::DumpRenderTree):
 293         (WebCore::DumpRenderTree::initJSObjects):
 294         * DumpRenderTree/qt/jsobjects.cpp:
 295         (TextInputController::doCommand):
 296
 297 2007-10-24  Lars Knoll  <lars@trolltech.com>
 298
 299         Reviewed by Simon.
 300
 301         first bit of implementation for the textinputcontroller.
 302
 303         * DumpRenderTree/qt/DumpRenderTree.cpp:
 304         (WebCore::DumpRenderTree::DumpRenderTree):
 305         * DumpRenderTree/qt/DumpRenderTree.h:
 306         * DumpRenderTree/qt/jsobjects.cpp:
 307         (TextInputController::TextInputController):
 308         (TextInputController::doCommand):
 309         * DumpRenderTree/qt/jsobjects.h:
 310
 311 2007-10-24  Lars Knoll  <lars@trolltech.com>
 312
 313         Reviewed by Simon.
 314
 315         make the man webpage believe it has focus, so the editing tests work correctly.
 316
 317         * DumpRenderTree/qt/DumpRenderTree.cpp:
 318         (WebCore::DumpRenderTree::DumpRenderTree):
 319
 320 2007-10-24  Lars Knoll  <lars@trolltech.com>
 321
 322         Reviewed by Simon.
 323
 324         implement layoutTestController.dumpEditingCallbacks() correctly.
 325
 326         * DumpRenderTree/qt/DumpRenderTree.cpp:
 327         (WebCore::DumpRenderTree::DumpRenderTree):
 328         * DumpRenderTree/qt/jsobjects.cpp:
 329         (LayoutTestController::reset):
 330         (LayoutTestController::dumpEditingCallbacks):
 331
 332 2007-10-24  Lars Knoll  <lars@trolltech.com>
 333
 334         Reviewed by Simon.
 335
 336         Implement support for testing editing.
 337
 338         * DumpRenderTree/qt/DumpRenderTree.cpp:
 339         (WebCore::DumpRenderTree::DumpRenderTree):
 340
 341 2007-10-23  Sam Weinig  <sam@webkit.org>
 342
 343         Check for null BSTR that can be passed to the UIDelegate methods
 344         from javascript null and undefined.  Fixes a failing test case on
 345         Windows (fast/dom/Window/alert-undefined.html)
 346
 347         Reviewed by Eric Seidel.
 348
 349         * DumpRenderTree/win/UIDelegate.cpp:
 350         (UIDelegate::runJavaScriptAlertPanelWithMessage):
 351         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
 352         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
 353         (UIDelegate::webViewAddMessageToConsole):
 354
 355 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
 356
 357         Reviewed by Darin.
 358
 359         Don't print a massive pile of setenvs from tools that automatically build testkjs.
 360
 361         * Scripts/build-testkjs:
 362
 363 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
 364
 365         Reviewed by Darin.
 366
 367         - add wrapper that finds the right copy of testkjs
 368
 369         * Scripts/sunspider-compare-results: Added.
 370
 371 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
 372
 373         Reviewed by Sam.
 374
 375         - After talking with Steve I now see that the WebKit server must be
 376         running for DCOM to create the distributed objects, which makes sense
 377         and currently WebKit only allows one instance to be running at a time
 378         which avoids accidentally connecting to the wrong server
 379         - In light of this I have removed the code for the attach box and
 380         NotificationServer and known server names, since they are all extranious
 381         now.
 382
 383         * Drosera/win/Drosera.cpp: Removed notification classes and known server
 384         names.
 385         (_tWinMain): Uses init instead of initUI.
 386         (droseraWndProc): No longer creats an attach dialog box.
 387         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
 388         it's not manditory to call init before doing COM stuff.
 389         (Drosera::init): calls initUI and will call attach when the
 390         functionality exists.
 391         (Drosera::initUI): Has changed very little.
 392         (Drosera::attach): Changed the signature to reflect that we no longer
 393         need the dictionary of known server names.
 394         * Drosera/win/Drosera.h: Removed notification classes and known server
 395         names.  Also renamed and moved some functions.
 396         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
 397         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
 398         headers to the resources folder.
 399         * Drosera/win/resource.h: Removed the Attach box.
 400
 401 2007-10-22  Adam Roben  <aroben@apple.com>
 402
 403         Windows build fix
 404
 405         Reviewed by NOBODY.
 406
 407         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
 408
 409 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
 410
 411         - Removed a leak that was fixed.
 412
 413         * Scripts/run-webkit-tests:
 414
 415 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
 416
 417         Reviewed by Darin.
 418
 419         - Changed the Client so that the DebuggerDocument now own the
 420         ServerConnection.  This simplifies ownership and cleanup.
 421
 422         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
 423         ServerConnection.
 424         (DebuggerClient::initWithServerName):
 425         (DebuggerClient::didFinishLoadForFrame):
 426         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the
 427         ServerConnection.
 428         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
 429         until after we have a server which we are attached to.
 430         (Drosera::initUI):
 431         (Drosera::attach):
 432         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
 433         out previously.
 434
 435 2007-10-22  Simon Hausmann  <hausmann@kde.org>
 436
 437         Reviewed by Nikolas.
 438
 439         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
 440
 441         * Scripts/run-javascriptcore-tests:
 442
 443 2007-10-22  Simon Hausmann  <hausmann@kde.org>
 444
 445         Reviewed by Nikolas.
 446
 447         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
 448
 449         * Scripts/build-drosera:
 450         * Scripts/build-dumprendertree:
 451         * Scripts/build-testkjs:
 452         * Scripts/build-webkit:
 453         * Scripts/run-javascriptcore-tests:
 454         * Scripts/run-sunspider:
 455         * Scripts/run-webkit-tests:
 456         * Scripts/webkitdirs.pm:
 457
 458 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
 459
 460         Reviewed by Mark Rowe.
 461
 462         Fix for local database support after r26879
 463         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
 464
 465         * Scripts/build-webkit:
 466
 467 2007-10-22  Holger Freyther  <zecke@selfish.org>
 468
 469         Reviewed by Simon Hausmann <hausmann@kde.org>.
 470
 471         - Do not build testkjs as an application bundle. This is
 472         needed for run-javascriptcore-tests on OSX.
 473         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
 474         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
 475         as we do not have -rpath on OSX.
 476
 477         * DumpRenderTree/qt/DumpRenderTree.pro:
 478         * Scripts/run-webkit-tests:
 479
 480 2007-10-22  Simon Hausmann  <hausmann@kde.org>
 481
 482         Reviewed by aroben.
 483
 484         Fix support for Signed-off-by detection in prepare-ChangeLog
 485         --git-commit. The Signed-off-by tag does not appear in the header
 486         but usually at the end.
 487
 488         * Scripts/prepare-ChangeLog:
 489
 490 2007-10-21  Mark Rowe  <mrowe@apple.com>
 491
 492         Reviewed by Eric.
 493
 494         Fix run-javascriptcore-tests for Gtk.
 495
 496         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
 497
 498 2007-10-20  Eric Seidel  <eric@webkit.org>
 499
 500         Reviewed by aroben.
 501
 502         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
 503
 504 2007-10-20  Eric Seidel  <eric@webkit.org>
 505
 506         Reviewed by darin.
 507
 508         Add improved argument handling to run-sunspider, including
 509         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
 510         Also re-factor code into subroutines
 511
 512         * Scripts/build-dumprendertree: removed bogus comments
 513         * Scripts/build-testkjs: Added.
 514         * Scripts/run-javascriptcore-tests: use build-testkjs
 515         * Scripts/run-sunspider: improved argument handling, abstraction
 516         * Scripts/run-webkit-tests: improved abstraction
 517
 518 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
 519
 520         Not reviewed, Windows build fix.
 521
 522         * DumpRenderTree/win/EventSender.cpp:
 523         (keyDownCallback):
 524
 525 2007-10-20  Darin Adler  <darin@apple.com>
 526
 527         Reviewed by Tim Hatcher.
 528
 529         - http://bugs.webkit.org/show_bug.cgi?id=15544
 530           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
 531           not rely on Apple-specific key codes
 532
 533         * DumpRenderTree/mac/EventSendingController.mm:
 534         (-[EventSendingController keyDown:withModifiers:]):
 535         Added named key "rightArrow". Later we could have a whole table of these.
 536         Also tweaked modifiers code a little.
 537
 538         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
 539
 540 2007-10-19  Darin Adler  <darin@apple.com>
 541
 542         Reviewed by Eric.
 543
 544         - http://bugs.webkit.org/show_bug.cgi?id=15566
 545           possible fix for leak seen in DumpRenderTree
 546
 547         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
 548         Delete the item if it's not put on the queue, since the caller has
 549         no way of knowing that. Would be better to have the parameter type
 550         be auto_ptr to express the fact that we take ownership.
 551
 552         - unrelated change
 553
 554         * Drosera/mac/main.m: Add missing include.
 555
 556 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
 557
 558         Reviewed by Adam.
 559
 560         - This change should be identical but for some reason was not working
 561         on my machine.
 562
 563         * Scripts/prepare-ChangeLog:
 564
 565 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
 566
 567         Reviewed by Oliver and Tim.
 568
 569         - Made use of RetainPtr to avoid retain and release issues and moved the
 570         log function to DebuggerDocumentPlatform, which seems to be a more
 571         logical place for it to live.
 572         - Also moved knownServers from the ServerConnection to
 573         DebuggerApplication to match the Windows code and because it makes sense
 574         that a connection knows its own server but not all of them.
 575
 576         * Drosera/mac/DebuggerClient.h: Moved the log function to
 577           DebuggerDocumentPlatform.
 578         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
 579           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
 580           call for the server name up from the ServerConnection class.
 581         (-[DebuggerClient dealloc]):
 582         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
 583           for the server name up from the ServerConnection.
 584         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
 585         (DebuggerDocument::platformPause):
 586         (DebuggerDocument::platformResume):
 587         (DebuggerDocument::platformStepInto):
 588         (DebuggerDocument::platformEvaluateScript):
 589         (DebuggerDocument::getPlatformCurrentFunctionStack):
 590         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 591         (DebuggerDocument::platformValueForScopeVariableNamed):
 592         (DebuggerDocument::platformLog): Log directly from here. No need to call
 593           DebuggerClient.
 594         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
 595           way I see it, a ServerConnection should only know about its connection
 596           and the group of all possible servers should be kept by the
 597           application.
 598         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
 599           currentServerName, it makes sense that the connection should know that
 600           name.
 601         (-[ServerConnection currentServerName]):
 602
 603 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
 604
 605         Reviewed by Adam.
 606
 607         - Integrated changes from mac drosera.  Recently I've encapsulated
 608         out the server connection object from the rest of Drosera because
 609         it is very platform dependent right now and RPC is not implemented on
 610         windows.  This functionality, of communicating with the WebKit server
 611         is the next area I will be focusing on in Windows.
 612
 613         - Other changes and cleanup were made to organize the code and add notes
 614         on which parts still need work.  Also some mac code is added and
 615         commented out, to act as pseudocode for the logic of those parts.
 616
 617         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
 618           pointer.
 619         * Drosera/config.h: Added whitespace.
 620         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
 621           these files got moved into Drosera.h/cpp
 622         * Drosera/win/DebuggerApplication.h: Removed.
 623         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring
 624           happened here to better match the logic flow of the same code on the
 625           mac side and to use the new ServerConnection class.
 626         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
 627         (DebuggerClient::initWithServerName): Initializer that will set up the
 628           class to use a ServerConnection object.  This was necessary so I could
 629           create a DebuggerClient without having to initilaize it at
 630           construction.
 631         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
 632           will be the UIDelegate and FrameLoadDelegate.
 633         (DebuggerClient::AddRef): For IUnknown.
 634         (DebuggerClient::Release): For IUnknown.
 635         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
 636           this still needs to set the global context of the server, but
 637           IWebFrame does not have an accessor for the global context yet.
 638         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
 639           this is a pass through for the same function in the document.
 640         (DebuggerClient::didReceiveTitle): Unimplemented part of
 641           FrameLoadDelegate this would change the title of the window.
 642         (DebuggerClient::createWebViewWithRequest): Part of the
 643           FrameLoadDelegate.  This is about new windows via Window.open() and
 644           how their delegates are set.
 645         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
 646           UIDelegate.  Just a debug function for printing messages.
 647         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
 648           because the Client should be the UIDelegate and FrameLoadDelegate
 649           to match the delegates on mac.
 650         (DebuggerClient::webViewLoaded): Added accessor method.
 651         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
 652           forgotten to add this file before.  This is where the platform
 653           dependent versions of the Documents functions live. Most of these are
 654           unimplemented because some piece of functionality does not exist on
 655           Windows yet.
 656         (DebuggerDocument::platformPause):
 657         (DebuggerDocument::platformResume):
 658         (DebuggerDocument::platformStepInto):
 659         (DebuggerDocument::platformEvaluateScript):
 660         (DebuggerDocument::getPlatformCurrentFunctionStack):
 661         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 662         (DebuggerDocument::platformValueForScopeVariableNamed):
 663         (DebuggerDocument::platformLog):
 664         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
 665           responsibilities becaue they belong in the Client. Also I laid the
 666           groundwork for attaching Drosera to a WebKit process
 667         (attachWndProc): Now if a server is selected the Client becomes it's
 668           delegate.
 669         (Drosera::Drosera): Added the construction of the Client and dictionary
 670           of server names.
 671         (Drosera::initUI): This is no longer the delegates, the Client is.
 672         (Drosera::webViewLoaded): Now asks the Client instead of holding local
 673           state.
 674         (Drosera::applicationDidFinishLaunching): Placeholder for needed
 675           notification registration when it's possible to implement.
 676         (Drosera::serverLoaded): Ditto
 677         (Drosera::serverUnloaded): Ditto
 678         (Drosera::attach): Attach Drosera to the WebKit server.
 679         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
 680         (Drosera::getInst):
 681         (Drosera::setInst):
 682         (Drosera::knownServers):
 683         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
 684           and added the ServerConnection.
 685         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
 686         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
 687           Most of the functions are completely unimlemented because they cannot
 688           connect with the WebKit server, because one does not exist on Windows
 689           yet.
 690         (ServerConnection::initWithServerName):
 691         (ServerConnection::~ServerConnection):
 692         (ServerConnection::setGlobalContext):
 693         (ServerConnection::pause):
 694         (ServerConnection::resume):
 695         (ServerConnection::stepInto):
 696         (ServerConnection::switchToServerNamed):
 697         (ServerConnection::applicationTerminating):
 698         (ServerConnection::serverConnectionDidDie):
 699         (ServerConnection::currentFrame):
 700         * Drosera/win/ServerConnection.h: Added. Ditto.
 701         (ServerConnection::ServerConnection):
 702
 703 2007-10-19  Alice Liu  <alice.liu@apple.com>
 704
 705         Reviewed by Darin.
 706
 707         Fix for these broken layout tests on Windows:
 708
 709         fast/forms/focus-selection-input.html
 710         fast/forms/focus-selection-textarea.html
 711         fast/forms/select-accesskey.html
 712
 713         * DumpRenderTree/win/EventSender.cpp:
 714         (keyDownCallback):
 715         correct the VK code for alt key.
 716
 717 2007-10-19  Eric Seidel  <eric@webkit.org>
 718
 719         Reviewed by Mark Rowe.
 720
 721         Make the GtkLauncher code slightly more readable.
 722
 723         * GtkLauncher/main.cpp:
 724         (setupMainMenu): Added.
 725         (setupMainWindowUI): Added.
 726         (main):
 727
 728 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
 729
 730         Rubber stamped by Adam.
 731
 732         - don't delay-load WebKit in DumpRenderTree.
 733
 734         * DumpRenderTree/win/DumpRenderTree.vcproj:
 735
 736 2007-10-18  Dan Bernstein  <dan.bernstein@apple.com>
 737
 738         Reviewed by Adam Roben.
 739
 740         - fix <rdar://problem/5313523>
 741         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
 742
 743         * DumpRenderTree/mac/DumpRenderTree.mm:
 744         (dump): Changed to use _responseMIMEType.
 745
 746 2007-10-17  Adam Roben  <aroben@apple.com>
 747
 748         Make it possible to have Windows-specific tests and results
 749
 750         When searching for tests to run and the Skipped file, we will only
 751         look in platform/win and the cross-platform directory. When looking
 752         for expected results, we will look in platform/win, then
 753         platform/mac-leopard, then platform/mac, then finally the
 754         cross-platform directory.
 755
 756         Reviewed by Sam.
 757
 758         * Scripts/run-webkit-tests:
 759         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
 760         searching in the cross-platform directory.
 761         (sub buildPlatformHierarchy): Removed some unneeded calls to
 762         dirname/basename.
 763
 764 2007-10-17  Adam Roben  <aroben@apple.com>
 765
 766         Add back the call to register WebKit that we had before WebKitInitializer existed
 767
 768         This is needed to ensure that the right WebKit is used when
 769         instantiating COM objects.
 770
 771         Reviewed by Oliver.
 772
 773         * DumpRenderTree/win/debug_internal.vsprops: Define
 774         DEBUG_WEBKIT_HAS_SUFFIX.
 775         * DumpRenderTree/win/DumpRenderTree.cpp:
 776         (initialize):
 777
 778 2007-10-17  Adam Roben  <aroben@apple.com>
 779
 780         Import File::Basename in webkitdirs since we use it
 781
 782         Reviewed by NOBODY.
 783
 784         * Scripts/webkitdirs.pm:
 785
 786 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
 787
 788         - Updated the tiger leaks list to make the internal bots green.
 789
 790         * Scripts/run-webkit-tests:
 791
 792 2007-10-17  Adam Roben  <aroben@apple.com>
 793
 794         Build fix for VC++ Express
 795
 796         Reviewed by NOBODY.
 797
 798         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
 799         and ole32.lib.
 800
 801 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
 802
 803         Reviewed by Sam.
 804
 805         - Minor mac improvements based on observations I made while implementing the
 806         Windows code.
 807
 808         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
 809         then hand it to the Client who will retain it, it should just be the client who
 810         creates and owns the server.
 811         (-[DebuggerApplication attach:]):
 812         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
 813         * Drosera/mac/DebuggerClient.mm: Creates the server.
 814         (-[DebuggerClient initWithServerName:]):
 815         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
 816         can instead forward declare what it needs.
 817
 818 2007-10-16  Darin Adler  <darin@apple.com>
 819
 820         Reviewed by Geoff Garen.
 821
 822         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
 823         want to turn failing tests into platform-specific test results. Also did a
 824         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
 825         would take the type of results into account only some of the time.
 826
 827 2007-10-16  Adam Roben  <aroben@apple.com>
 828
 829         Add a new nightly launcher script for Windows
 830
 831         This new script is for versions of Safari that don't delay-load
 832         WebKit. I had to make FindSafari be able to print out the nightly
 833         launcher script on stdout because Windows shell scripts can't capture
 834         the output from a command into an environment variable.
 835
 836         Reviewed by Steve.
 837
 838         * FindSafari/FindSafari.cpp:
 839         (_tmain): Added /printSafariLauncher option.
 840         * Scripts/run-webkit-nightly.cmd: Added.
 841
 842 2007-10-16  Adam Roben  <aroben@apple.com>
 843
 844         Replace WebKitInitializer with FindSafari
 845
 846         We now rely on setting the PATH environment variable to tell Windows
 847         where to find WebKit and its dependencies (similar to
 848         DYLD_FRAMEWORK_PATH on Mac).
 849
 850         This change also make DumpRenderTree no longer delay-load WebKit.
 851
 852         Reviewed by Sam.
 853
 854         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
 855         FindSafari.
 856         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
 857         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
 858         WebKitInitializer, don't delay-load WebKit.
 859         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
 860         * Scripts/run-webkit-tests: Ditto.
 861         * Scripts/webkitdirs.pm:
 862         (sub setPathForRunningWebKitApp): Added.
 863         * WebKitInitializer/WebKitInitializer.cpp: Removed.
 864         * WebKitInitializer/WebKitInitializer.h: Removed.
 865         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
 866         * WebKitInitializer/debug.vsprops: Removed.
 867         * WebKitInitializer/debug_internal.vsprops: Removed.
 868         * WebKitInitializer/release.vsprops: Removed.
 869
 870 2007-10-16  Adam Roben  <aroben@apple.com>
 871
 872         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
 873
 874         http://bugs.webkit.org/show_bug.cgi?id=15532
 875
 876         FindSafari simply prints the location of an installed Safari.exe on
 877         stdout.
 878
 879         Reviewed by Darin.
 880
 881         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
 882         (getStringValue):
 883         (getWebViewCLSID):
 884         (getInstalledWebKitDirectory):
 885         (_tmain):
 886         * FindSafari/FindSafari.vcproj: Added.
 887         * Scripts/webkitdirs.pm:
 888         (sub installedSafariPath): Added. Calls FindSafari on Windows.
 889
 890 2007-10-16  Adam Roben  <aroben@apple.com>
 891
 892         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
 893
 894         Reviewed by Kevin McCullough.
 895
 896         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
 897         when referring to WebKit.dll.
 898         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
 899         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
 900         * DumpRenderTree/win/release.vsprops: Ditto.
 901         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
 902         never have a _debug suffix on WebKit.dll.
 903         * WebKitInitializer/WebKitInitializer.cpp:
 904         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
 905         specified.
 906         * WebKitInitializer/debug_internal.vsprops: Added
 907         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
 908
 909 2007-10-16  Darin Adler  <darin@apple.com>
 910
 911         Reviewed by Adele.
 912
 913         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
 914         Remove now-unneeded control/alt key hack; the tests have been updated.
 915
 916 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
 917
 918         - Updated leaks list because our internal bot upgraded it's version of leopard and
 919         one of the leaks was fixed between that revision and the bot's previous version of
 920         leopard.
 921
 922         * Scripts/run-webkit-tests:
 923
 924 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
 925
 926         Reviewed by Tim.
 927
 928         - I encapsulated out the server connecton functionality because it is a specific part
 929         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
 930         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
 931         Windows.  So the majority of this patch is moving preexisting functionality.
 932
 933         - Also I removed the prefix header and changed to use config.h because it is more
 934         standard on how we use config.h in windows and it didn't make much sense to keep
 935         the prefix header and the config.h
 936
 937         * Drosera/DebuggerDocument.cpp:
 938         (DebuggerDocument::DebuggerDocument):
 939         * Drosera/DebuggerDocument.h:
 940         * Drosera/config.h:
 941         * Drosera/mac/DebuggerApplication.mm:
 942         (-[DebuggerApplication attach:]):
 943         * Drosera/mac/DebuggerClient.h:
 944         * Drosera/mac/DebuggerClient.mm:
 945         (-[DebuggerClient initWithServerConnection:]):
 946         (-[DebuggerClient dealloc]):
 947         (-[DebuggerClient windowDidLoad]):
 948         (-[DebuggerClient windowWillClose:]):
 949         (-[DebuggerClient webView:didFinishLoadForFrame:]):
 950         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
 951         * Drosera/mac/DebuggerDocumentPlatform.mm:
 952         (DebuggerDocument::platformPause):
 953         (DebuggerDocument::platformResume):
 954         (DebuggerDocument::platformStepInto):
 955         (DebuggerDocument::platformEvaluateScript):
 956         (DebuggerDocument::getPlatformCurrentFunctionStack):
 957         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 958         (DebuggerDocument::platformValueForScopeVariableNamed):
 959         (DebuggerDocument::platformLog):
 960         * Drosera/mac/Drosera.pch: Removed.
 961         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
 962         * Drosera/mac/ServerConnection.h: Added.
 963         * Drosera/mac/ServerConnection.mm: Added.
 964         (-[ServerConnection initWithServerName:]):
 965         (-[ServerConnection dealloc]):
 966         (-[ServerConnection setGlobalContext:]):
 967         (-[ServerConnection pause]):
 968         (-[ServerConnection resume]):
 969         (-[ServerConnection stepInto]):
 970         (-[ServerConnection switchToServerNamed:]):
 971         (-[ServerConnection applicationTerminating:]):
 972         (-[ServerConnection serverConnectionDidDie:]):
 973         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
 974         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
 975         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
 976         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
 977         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
 978         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
 979         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
 980         (-[ServerConnection currentFrame]):
 981         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
 982         (-[ServerConnection knownServers]):
 983
 984 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
 985
 986         Reviewed by Eric.
 987
 988         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
 989           Script to automatically search nightly builds for regressions (bisect-builds)
 990
 991         * Scripts/bisect-builds: Added.
 992
 993 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
 994
 995         Reviewed by Darin.
 996
 997         - New JavaScript benchmark
 998         http://bugs.webkit.org/show_bug.cgi?id=15515
 999
1000         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
1001         current development or release build of JavaScriptCore.
1002
1003 2007-10-15  Mark Rowe  <mrowe@apple.com>
1004
1005         Reviewed by Sam.
1006
1007         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
1008
1009         * Scripts/webkitdirs.pm:
1010         - Change checkArgv to remove the options from @ARGV to prevent
1011         them from interfering with further option processing.
1012         - Fix logic error in determineIsQt that would prevent it from bailing out early.
1013         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
1014         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
1015         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
1016
1017 2007-10-15  Darin Adler  <darin@apple.com>
1018
1019         Reviewed by Sam.
1020
1021         - added logging of window.prompt and window.confirm
1022
1023         * DumpRenderTree/mac/UIDelegate.mm:
1024         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
1025         Implement the recommended delegate rather than the deprecated one.
1026         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
1027         Added.
1028         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
1029         Added.
1030
1031         * DumpRenderTree/win/UIDelegate.h:
1032         * DumpRenderTree/win/UIDelegate.cpp:
1033         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
1034         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
1035         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
1036         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
1037
1038 2007-10-15  Alice Liu  <alice.liu@apple.com>
1039
1040         Reviewed by Sam Weinig.
1041
1042         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
1043
1044         * DumpRenderTree/win/DumpRenderTree.cpp:
1045         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
1046         (main): allocate the global policy delegate for DRT's custom use
1047         * DumpRenderTree/win/DumpRenderTree.vcproj:
1048         Adding files to project
1049         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
1050         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1051         (LayoutTestController::setCustomPolicyDelegate):
1052         set the webview's policy delegate to DRT's custom one if the test requests it.
1053         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
1054         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
1055         (PolicyDelegate::PolicyDelegate):
1056         (PolicyDelegate::QueryInterface):
1057         (PolicyDelegate::AddRef):
1058         (PolicyDelegate::Release):
1059         (PolicyDelegate::decidePolicyForNavigationAction):
1060         * DumpRenderTree/win/PolicyDelegate.h: Added.
1061         (PolicyDelegate::decidePolicyForNewWindowAction):
1062         (PolicyDelegate::decidePolicyForMIMEType):
1063         (PolicyDelegate::unableToImplementPolicyWithError):
1064
1065 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
1066
1067         Reviewed by Mark.
1068
1069         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
1070         when querying for QMAKE_MKSPECS.
1071
1072 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
1073
1074         Reviewed by Adam Roben.
1075
1076         Fix run-webkit-tests is too greedy calculating platform hierarchy
1077         http://bugs.webkit.org/show_bug.cgi?id=15465
1078
1079         Fix run-webkit-tests being too greedy in trying to split the platform name up
1080         causing it to try and find tests in every directory above the first "-" in the
1081         path to the LayoutTests
1082
1083         * Scripts/run-webkit-tests:
1084
1085 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
1086
1087         Reviewed by Darin.
1088
1089         http://bugs.webkit.org/show_bug.cgi?id=15006
1090         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
1091         to reduce code duplication.
1092
1093         * Scripts/build-webkit:
1094         * Scripts/webkitdirs.pm:
1095         buildQMakeProject() renamed to buildQMakeQtProject().
1096         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
1097         unused $colorize has been removed.
1098
1099 === Start merge of feature-branch 2007-10-12 ===
1100
1101 2007-10-08  Eric Seidel  <eric@webkit.org>
1102
1103         Reviewed by Mark Rowe.
1104
1105         * Scripts/build-webkit: add --help, remove unused --color
1106
1107 2007-10-07  Eric Seidel  <eric@webkit.org>
1108
1109         Reviewed by darin.
1110
1111         * Drosera/mac/DebuggerDocumentPlatform.mm:
1112         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
1113
1114 2007-10-03  Rob Buis  <buis@kde.org>
1115
1116         Reviewed by Olliej.
1117
1118         Adapt to changed location of Ahem font.
1119
1120         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1121
1122 2007-10-02  Eric Seidel  <eric@webkit.org>
1123
1124         Reviewed by Adam Roben.
1125
1126         Make pixel tests more useful!
1127         Finally fix the image diff 0.00% mystery problem
1128         Highlight any image differences in the image diff.
1129         Add a link from image diffs back to original test file.
1130
1131         * DumpRenderTree/mac/ImageDiff.m:
1132         (compareImages): highlight any differences
1133         (computePercentageDifferent): round to two decimal places
1134         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
1135
1136 2007-10-02  Eric Seidel  <eric@webkit.org>
1137
1138         Reviewed by Alexey Proskuryakov.
1139
1140         * Scripts/run-webkit-tests: print the % image difference on main results page
1141
1142 2007-10-02  Mark Rowe  <mrowe@apple.com>
1143
1144         Reviewed by Oliver.
1145
1146         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
1147
1148         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
1149         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
1150
1151 2007-10-01  Mark Rowe  <mrowe@apple.com>
1152
1153         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
1154
1155 2007-09-25  Eric Seidel  <eric@webkit.org>
1156
1157         Reviewed by Mark Rowe.
1158
1159         DerivedSources.make was finding "ENABLE_SVG" in the string
1160         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
1161         quite correctly.
1162
1163         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
1164
1165 2007-09-25  Mark Rowe  <mrowe@apple.com>
1166
1167         Rubber-stamped by Eric.
1168
1169         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
1170         This makes it possible to automate nightly builds for the feature-branch.
1171
1172 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
1173
1174         Rubber stamped by Mark.
1175
1176         Enable svg experimental features as default here in feature-branch.
1177
1178         * Scripts/build-webkit:
1179
1180 2007-06-29  Antti Koivisto  <antti@apple.com>
1181
1182         Reviewed by Weinig.
1183
1184         Add VIDEO flag for timed media features
1185
1186         * Scripts/build-webkit
1187
1188 === End merge of feature-branch 2007-10-12 ===
1189
1190 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
1191
1192         Reviewed by Darin.
1193
1194         - Updated rational for the leaks list to be more clear.
1195
1196         * Scripts/run-webkit-tests:
1197
1198 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
1199
1200         Rubber Stamp by Sam.
1201
1202         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
1203         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
1204
1205         * Scripts/run-webkit-tests:
1206
1207 2007-10-10  Simon Hausmann  <hausmann@kde.org>
1208
1209         Reviewed by Lars.
1210
1211         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
1212         includes are needed for INT_MAX, std::auto_ptr and the like.
1213
1214         * DumpRenderTree/qt/main.cpp:
1215
1216 2007-10-09  Lars Knoll  <lars@trolltech.com>
1217
1218         Reviewed by Simon.
1219
1220         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
1221
1222         * DumpRenderTree/qt/jsobjects.cpp:
1223         (LayoutTestController::encodeHostName):
1224         (LayoutTestController::decodeHostName):
1225         * DumpRenderTree/qt/jsobjects.h:
1226
1227 2007-10-09  Lars Knoll  <lars@trolltech.com>
1228
1229         Reviewed by Simon.
1230
1231         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
1232
1233         * DumpRenderTree/qt/DumpRenderTree.cpp:
1234         (WebCore::WebPage::createFrame):
1235         (WebCore::DumpRenderTree::DumpRenderTree):
1236         (WebCore::DumpRenderTree::titleChanged):
1237         * DumpRenderTree/qt/DumpRenderTree.h:
1238         * DumpRenderTree/qt/jsobjects.cpp:
1239         (LayoutTestController::reset):
1240         * DumpRenderTree/qt/jsobjects.h:
1241
1242 2007-10-09  Lars Knoll  <lars@trolltech.com>
1243
1244         Reviewed by Simon.
1245
1246         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
1247
1248         * DumpRenderTree/qt/DumpRenderTree.h:
1249         * DumpRenderTree/qt/jsobjects.cpp:
1250         (LayoutTestController::clearBackForwardList):
1251         * DumpRenderTree/qt/jsobjects.h:
1252
1253 2007-10-09  Lars Knoll  <lars@trolltech.com>
1254
1255         Reviewed by Simon.
1256
1257         make --git-reviewer work again.
1258
1259         * Scripts/prepare-ChangeLog:
1260
1261 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
1262
1263         Rubber stamped by Eric.
1264
1265         Connect to the "hovering-over-link" signal emitted by WebKitPage and
1266         show the current link inside the statusbar.
1267         This shows how to make use of this signal and allows to easily test
1268         http://bugs.webkit.org/show_bug.cgi?id=15299.
1269
1270         * GtkLauncher/main.cpp:
1271         (hoveringOverLink):
1272         (main):
1273
1274 2007-10-05  Lars Knoll  <lars@trolltech.com>
1275
1276         add proper error messages to the FrameLoaderClient.
1277         Implement ChromeClientQt::closeWindowSoon and
1278         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
1279         Some fixes in DRT to make it work correctly with multiple windows.
1280
1281         Reviewed by Maciej.
1282
1283         * DumpRenderTree/qt/DumpRenderTree.cpp:
1284         (WebCore::DumpRenderTree::DumpRenderTree):
1285         (WebCore::DumpRenderTree::createWindow):
1286         (WebCore::DumpRenderTree::windowCount):
1287         * DumpRenderTree/qt/DumpRenderTree.h:
1288         * DumpRenderTree/qt/jsobjects.cpp:
1289         (LayoutTestController::maybeDump):
1290         (LayoutTestController::windowCount):
1291         * DumpRenderTree/qt/jsobjects.h:
1292
1293 2007-10-05  Lars Knoll  <lars@trolltech.com>
1294
1295         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
1296         Add support for layoutTextController.setCanOpenWindows() to DRT
1297         fixing another 2 test cases in fast/dom/Window.
1298
1299         Reviewed by Maciej.
1300
1301         * DumpRenderTree/qt/DumpRenderTree.cpp:
1302         (WebCore::WebPage::WebPage):
1303         (WebCore::WebPage::createWindow):
1304         (WebCore::DumpRenderTree::resetJSObjects):
1305         (WebCore::DumpRenderTree::createWindow):
1306         * DumpRenderTree/qt/DumpRenderTree.h:
1307         * DumpRenderTree/qt/DumpRenderTree.pro:
1308         * DumpRenderTree/qt/jsobjects.cpp:
1309         (LayoutTestController::LayoutTestController):
1310         (LayoutTestController::reset):
1311         * DumpRenderTree/qt/jsobjects.h:
1312         * DumpRenderTree/qt/main.cpp:
1313         * DumpRenderTree/qt/testplugin.cpp: Added.
1314         * DumpRenderTree/qt/testplugin.h: Added.
1315
1316 2007-10-04  Sam Weinig  <sam@webkit.org>
1317
1318         Rubber stamped by Adam.
1319
1320         Remove empty directories.
1321
1322         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
1323         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
1324
1325 2007-10-03  Darin Adler  <darin@apple.com>
1326
1327         Reviewed by Adam.
1328
1329         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
1330         we find the internal libraries in the libraries directory. This
1331         is helpful for Safari team engineers at Apple.
1332
1333 2007-10-03  Adam Roben  <aroben@apple.com>
1334
1335         Update the location of AHEM___.TTF after r25968
1336
1337         Reviewed by Sam.
1338
1339         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1340
1341 2007-10-03  Alp Toker  <alp@atoker.com>
1342
1343         Reviewed by Adam.
1344
1345         http://bugs.webkit.org/show_bug.cgi?id=14726
1346         [gtk] API design. Mapping the WebView delegates to signals.
1347
1348         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
1349
1350         * GtkLauncher/main.cpp:
1351         (goToURLBarText):
1352         (titleChanged):
1353         (progressChanged):
1354         (menuMainBackCallback):
1355         (menuMainForwardCallback):
1356         (main):
1357
1358 2007-10-03  Lars Knoll  <lars@trolltech.com>
1359
1360         Reviewed by Rob.
1361
1362         This fixes --strict mode in run-webkit-tests again after
1363         the platform dependent test results have been moved.
1364
1365         * Scripts/run-webkit-tests:
1366
1367 2007-10-03  Lars Knoll  <lars@trolltech.com>
1368
1369         Reviewed by bdash.
1370
1371         remove the hack in run-webkit-tests that forced text only test
1372         to be taken from the platform independent dir. It was only left
1373         there from early days.
1374
1375         Remove platform dependent results for tests that are text only nowadays,
1376         and add one platform dependent result for a text only test that requires it.
1377
1378         * Scripts/run-webkit-tests:
1379
1380 2007-10-03  Lars Knoll  <lars@trolltech.com>
1381
1382         Reviewed by olliej.
1383
1384         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
1385
1386         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
1387         (WebCore::WebFrame::WebFrame):
1388         (WebCore::WebPage::WebPage):
1389         (WebCore::WebPage::createFrame):
1390         (WebCore::WebPage::javaScriptAlert):
1391         (WebCore::WebPage::javaScriptConsoleMessage):
1392         (WebCore::DumpRenderTree::DumpRenderTree):
1393         (WebCore::DumpRenderTree::~DumpRenderTree):
1394         (WebCore::DumpRenderTree::open):
1395         (WebCore::DumpRenderTree::readStdin):
1396         (WebCore::DumpRenderTree::resetJSObjects):
1397         (WebCore::DumpRenderTree::initJSObjects):
1398         (WebCore::DumpRenderTree::dumpFramesAsText):
1399         (WebCore::DumpRenderTree::dump):
1400         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
1401         (WebCore::DumpRenderTree::layoutTestController):
1402         (WebCore::DumpRenderTree::eventSender):
1403         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
1404         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
1405         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
1406         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
1407         (HackWebFrame::mousePressEvent):
1408         (HackWebFrame::mouseReleaseEvent):
1409         (HackWebFrame::mouseMoveEvent):
1410         (HackWebFrame::HackWebFrame):
1411         (HackWebFrame::~HackWebFrame):
1412         (LayoutTestController::LayoutTestController):
1413         (LayoutTestController::reset):
1414         (LayoutTestController::maybeDump):
1415         (LayoutTestController::waitUntilDone):
1416         (LayoutTestController::notifyDone):
1417         (LayoutTestController::dumpEditingCallbacks):
1418         (LayoutTestController::queueReload):
1419         (LayoutTestController::provisionalLoad):
1420         (LayoutTestController::timerEvent):
1421         (EventSender::EventSender):
1422         (EventSender::mouseDown):
1423         (EventSender::mouseUp):
1424         (EventSender::mouseMoveTo):
1425         (EventSender::leapForward):
1426         (EventSender::keyDown):
1427         (EventSender::frameUnderMouse):
1428         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
1429         (LayoutTestController::isLoading):
1430         (LayoutTestController::setLoading):
1431         (LayoutTestController::shouldDumpAsText):
1432         (LayoutTestController::shouldDumpChildrenAsText):
1433         (LayoutTestController::shouldWaitUntilDone):
1434         (LayoutTestController::dumpAsText):
1435         (LayoutTestController::dumpChildFramesAsText):
1436         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
1437         (messageHandler):
1438         (crashHandler):
1439         (main):
1440         * Scripts/run-webkit-tests:
1441
1442 2007-10-03  Mark Rowe  <mrowe@apple.com>
1443
1444         Reviewed by Alp Toker.
1445
1446         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
1447         should take precedence over QTDIR when determining which port we are working with.
1448
1449         * Scripts/webkitdirs.pm:
1450
1451 2007-10-02  Adam Roben  <aroben@apple.com>
1452
1453         Add keychain to the list of default packages to install
1454
1455         Rubberstamped by Sam.
1456
1457         * CygwinDownloader/cygwin-downloader.py:
1458         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
1459
1460 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
1461
1462         Reviewed by Adam.
1463
1464         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
1465         Also makes WebCore regression test case logic work when using git.
1466
1467         * Scripts/prepare-ChangeLog:
1468         (reviewerAndDescriptionForGitCommit): Added.
1469
1470 2007-10-02  Lars Knoll  <lars@trolltech.com>
1471
1472         Reviewed by bdash.
1473
1474         Add API to retrieve the frame name from QWebFrame.
1475         Implement support for DRT::dumpChildrenAsText.
1476
1477         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
1478         (WebCore::DumpRenderTree::dumpFramesAsText):
1479         (WebCore::DumpRenderTree::dump):
1480         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
1481         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
1482         (LayoutTestController::LayoutTestController):
1483         (LayoutTestController::reset):
1484         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
1485
1486 2007-10-02  Lars Knoll  <lars@trolltech.com>
1487
1488         Reviewed by bdash.
1489
1490         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
1491
1492         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
1493         (WebCore::DumpRenderTree::readStdin):
1494
1495 2007-10-02  Mark Rowe  <mrowe@apple.com>
1496
1497         Reviewed by Oliver.
1498
1499         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
1500
1501         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
1502         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
1503
1504 2007-10-02  Mark Rowe  <mrowe@apple.com>
1505
1506         Rubber-stamped by Maciej.
1507
1508         Configuration changes from build.webkit.org.  The major change is refactoring to work
1509         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
1510         last few weeks.
1511
1512         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1513         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
1514         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
1515         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
1516         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
1517         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
1518         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
1519         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
1520
1521 2007-10-02  Lars Knoll  <lars@trolltech.com>
1522
1523         Reviewed by Maciej.
1524
1525         Add support for eventSender.mouseMove to DRT.
1526         Fixes fast/css/hover-affects-child.html
1527
1528         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
1529         (EventSender::mouseMoveTo):
1530
1531 2007-10-01  Mark Rowe  <mrowe@apple.com>
1532
1533         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
1534
1535 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
1536
1537         Reviewed by Hyatt.
1538
1539         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
1540
1541         * Scripts/svn-apply:
1542         (gitdiff2svndiff): Ignore lines beginning with "new file".
1543         * Scripts/svn-unapply:
1544         (gitdiff2svndiff): Ditto.
1545
1546 2007-09-30  George Staikos  <staikos@kde.org>
1547
1548         Qt build fix (Mac OS X specific)
1549
1550         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
1551
1552 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
1553
1554         Reviewed by Mark.
1555
1556         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
1557         Remove Bakefiles from svn.
1558
1559         * GtkLauncher/Bakefiles.bkgen: Removed.
1560         * GtkLauncher/ENV: Removed.
1561         * GtkLauncher/gdklauncher.bkl: Removed.
1562         * GtkLauncher/mk: Removed.
1563         * Scripts/regenerate-makefiles: Removed.
1564
1565 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
1566
1567         Reviewed by John.
1568
1569         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
1570
1571         * Scripts/run-webkit-tests:
1572
1573 2007-09-26  Adam Roben  <aroben@apple.com>
1574
1575         Make not finding an installed WebKit non-fatal
1576
1577         What really matters is that we are able to load WebKit and its
1578         dependencies, not whether we think we've found an installed WebKit.
1579
1580         Reviewed by Sam.
1581
1582         * WebKitInitializer/WebKitInitializer.cpp:
1583         (getWebViewCLSID): Use new LOG_WARNING macro.
1584         (getInstalledWebKitDirectory): Ditto.
1585         (initializeWebKit): Don't die if we didn't find an installed WebKit,
1586         and use new macros.
1587         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
1588
1589 2007-09-26  Adam Roben  <aroben@apple.com>
1590
1591         Committed this file before saving it
1592
1593         * WebKitInitializer/debug_internal.vsprops:
1594
1595 2007-09-26  Adam Roben  <aroben@apple.com>
1596
1597         Load WebKit and its dependencies manually so they come from DllDirectory
1598
1599         I had to change WebKitInitializer to use malloc/free instead of
1600         new/delete to avoid pulling in WebKit (and its dependencies) early
1601         through use of fastMalloc.
1602
1603         Reviewed by Oliver.
1604
1605         * WebKitInitializer/WebKitInitializer.cpp:
1606         (getStringValue): Changed to use malloc/free.
1607         (getInstalledWebKitDirectory): Ditto.
1608         (initializeWebKit): Call SetDllDirectory first, then load all of
1609         WebKit's dependencies manually, finally followed by WebKit itself.
1610         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
1611         configuration to match our other projects.
1612         * WebKitInitializer/debug_internal.vsprops: Added.
1613
1614 2007-09-25  Adam Roben  <aroben@apple.com>
1615
1616         Actually define DEBUG/NDEBUG so that we load WebKit correctly
1617
1618         Rubberstamped by Sam.
1619
1620         * WebKitInitializer/WebKitInitializer.vcproj:
1621
1622 2007-09-25  Adam Roben  <aroben@apple.com>
1623
1624         Make DumpRenderTree delay-load its dependencies
1625
1626         This lets WebKitInitializer re-route the dependencies to be loaded out
1627         of the Safari installation directory.
1628
1629         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
1630         same thing), since we can't import the kCFAllocatorDefault symbol when
1631         delay-loading CoreFoundation.dll.
1632
1633         Rubberstamped by Sam.
1634
1635         * DumpRenderTree/win/DumpRenderTree.cpp:
1636         (runTest):
1637         (javaScriptThreads):
1638         * DumpRenderTree/win/DumpRenderTree.vcproj:
1639         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1640         (LayoutTestController::setWaitToDump):
1641
1642 2007-09-25  Adam Roben  <aroben@apple.com>
1643
1644         Pull ole32.lib into WebKitInitializer
1645
1646         Rubberstamped by Sam.
1647
1648         * WebKitInitializer/WebKitInitializer.vcproj:
1649
1650 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
1651
1652         Reviewed by Adam.
1653
1654         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
1655           LGPL'ed files contain incorrect FSF address
1656
1657         * Drosera/config.h:
1658
1659 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
1660
1661         Reviewed by Adam.
1662
1663         Make svn-apply and svn-unapply work with git-diff formatted patches.
1664
1665         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
1666         (gitdiff2svndiff): Added.
1667         * Scripts/svn-unapply: Ditto.
1668         (gitdiff2svndiff): Added.
1669
1670 2007-09-25  Adam Roben  <aroben@apple.com>
1671
1672         Pull advapi32.lib into WebKitInitializer
1673
1674         This is needed to get the registry functions we use.
1675
1676         Rubberstamped by Sam.
1677
1678         * WebKitInitializer/WebKitInitializer.vcproj:
1679
1680 2007-09-25  Adam Roben  <aroben@apple.com>
1681
1682         Add python and rsync to cygwin-downloader
1683
1684         Our build slaves need this, and it can't hurt for everyone else to
1685         have it, too.
1686
1687         Reviewed by Sam.
1688
1689         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
1690         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
1691
1692 2007-09-25  Adam Roben  <aroben@apple.com>
1693
1694         Add WebKitInitializer and use it in DumpRenderTree
1695
1696         WebKitInitializer is a static library that has one function,
1697         initializeWebKit(). This registers WebKit and sets up the DLL search
1698         path so that WebKit's dependencies that are installed with Safari can
1699         be found.
1700
1701         Reviewed by Sam.
1702
1703         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
1704         DumpRenderTree depend on it.
1705         * DumpRenderTree/win/DumpRenderTree.cpp:
1706         (initialize): Call initializeWebKit.
1707         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
1708         WebKitInitializer.lib.
1709         * WebKitInitializer/WebKitInitializer.cpp: Added.
1710         (getStringValue):
1711         (getWebViewCLSID):
1712         (getInstalledWebKitDirectory):
1713         (initializeWebKit):
1714         * WebKitInitializer/WebKitInitializer.h: Added.
1715         * WebKitInitializer/WebKitInitializer.vcproj: Added.
1716         * WebKitInitializer/debug.vsprops: Added.
1717         * WebKitInitializer/release.vsprops: Added.
1718
1719 2007-09-25  Adam Roben  <aroben@apple.com>
1720
1721         Make run-webkit-tests respect set-webkit-configuration
1722
1723         Reviewed by Sam.
1724
1725         * Scripts/run-webkit-tests: Initialize $configuration to whatever
1726         set-webkit-configuration was last set to.
1727
1728 2007-09-25  Mark Rowe  <mrowe@apple.com>
1729
1730         Rubber-stamped by Eric.
1731
1732         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
1733         This makes it possible to automate nightly builds for the feature-branch.
1734
1735 2007-09-25  Adam Roben  <aroben@apple.com>
1736
1737         A couple of fixes/enhancements to update-webkit-*-libs
1738
1739         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
1740         to tell update-webkit-support-libraries where it should find the
1741         WebKitSupportLibrary.zip file you downloaded.
1742
1743         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
1744         Windows-style path.
1745
1746         Reviewed by Sam.
1747
1748         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
1749         to $auxiliaryLibsURL and removed an irrelevant comment.
1750         * Scripts/update-webkit-support-libs:
1751
1752 2007-09-25  Adam Treat  <treat@kde.org>
1753
1754         Reviewed by Simon and Lars.
1755
1756         Refactors and cleans up Qt DRT member variable names, member variable
1757         initialization, style fixes and general code cleanup.
1758
1759         Adds queueReload slot to LayoutTestController that some tests require.
1760
1761         Subclasses QWebFrame to make sure that all frames have an associated
1762         LayoutTestController JS window object.
1763
1764         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
1765         aren't dumped twice.
1766
1767         EOF fixes.
1768
1769         Together, this patch fixes some 20+ layout tests in QtWebKit.
1770
1771         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
1772         (WebCore::WebFrame::WebFrame):
1773         (WebCore::WebPage::WebPage):
1774         (WebCore::WebPage::createFrame):
1775         (WebCore::DumpRenderTree::DumpRenderTree):
1776         (WebCore::DumpRenderTree::open):
1777         (WebCore::DumpRenderTree::readStdin):
1778         (WebCore::DumpRenderTree::initJSObjects):
1779         (WebCore::DumpRenderTree::dump):
1780         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
1781         (WebCore::DumpRenderTree::layoutTestController):
1782         (WebCore::DumpRenderTree::eventSender):
1783         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
1784         (LayoutTestController::LayoutTestController):
1785         (LayoutTestController::reset):
1786         (LayoutTestController::maybeDump):
1787         (LayoutTestController::waitUntilDone):
1788         (LayoutTestController::notifyDone):
1789         (LayoutTestController::queueReload):
1790         (LayoutTestController::provisionalLoad):
1791         (EventSender::EventSender):
1792         (EventSender::mouseDown):
1793         (EventSender::mouseUp):
1794         (EventSender::mouseMoveTo):
1795         (EventSender::frameUnderMouse):
1796         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
1797         (LayoutTestController::isLoading):
1798         (LayoutTestController::setLoading):
1799         (LayoutTestController::dumpAsText):
1800         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
1801         (main):
1802
1803 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
1804
1805
1806         - Reverted an accidentally checked in file.
1807
1808         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
1809
1810 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
1811         Reviewed by Sam.
1812
1813         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
1814
1815         * DumpRenderTree/win/DumpRenderTree.vcproj:
1816         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1817
1818 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
1819
1820         Rubber stamped by Adam.
1821
1822         * GdkLauncher: Removed.
1823         * GdkLauncher/Bakefiles.bkgen: Removed.
1824         * GdkLauncher/ENV: Removed.
1825         * GdkLauncher/GdkLauncher.pro: Removed.
1826         * GdkLauncher/gdklauncher.bkl: Removed.
1827         * GdkLauncher/main.cpp: Removed.
1828         * GdkLauncher/mk: Removed.
1829         * GdkLauncher/simple.svg: Removed.
1830         * GdkLauncher/text.html: Removed.
1831         * GtkLauncher: Added.
1832         * GtkLauncher/GdkLauncher.pro: Removed.
1833         * GtkLauncher/GtkLauncher.pro: Added.
1834         * GtkLauncher/main.cpp:
1835         (updateWindowTitle):
1836         (main):
1837         * Scripts/build-webkit:
1838         * Scripts/regenerate-makefiles:
1839         * Scripts/run-javascriptcore-tests:
1840         * Scripts/run-launcher:
1841         * Scripts/run-webkit-tests:
1842         * Scripts/webkitdirs.pm:
1843
1844 2007-09-21  Timothy Hatcher  <timothy@apple.com>
1845
1846         Reviewed by Darin.
1847
1848         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
1849
1850         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
1851         This is tested by plugins/root-object-premature-delete-crash.html.
1852
1853         * DumpRenderTree/mac/ObjCController.m:
1854         (-[ObjCController accessStoredWebScriptObject]):
1855
1856 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
1857
1858         Reviewed by Oliver.
1859
1860         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
1861
1862         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
1863         (FrameLoadDelegate::FrameLoadDelegate):
1864
1865 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
1866
1867         Reviewed by Adam.
1868
1869         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
1870         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
1871
1872         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
1873         Now isQt() and isGdk() use global variables that are only set once.
1874
1875         An array of all the parameters is now given to build-dumprender which includes
1876         the platform on linux.
1877
1878         * Scripts/build-dumprendertree:
1879         * Scripts/run-webkit-tests:
1880         * Scripts/webkitdirs.pm:
1881
1882 2007-09-19  Adam Roben  <aroben@apple.com>
1883
1884         Rubberstamped by Hyatt.
1885
1886         * Spinneret: Removed.
1887
1888 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
1889
1890         Reviewed by David Kilzer.
1891
1892         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
1893
1894 2007-09-18  Sam Weinig  <sam@webkit.org>
1895
1896         Add JSRetainPtr.h #include to fix some builds.
1897
1898         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1899
1900 2007-09-18  Mike Hommey  <glandium@debian.org>
1901
1902         Reviewed by Adam.
1903
1904         * Scripts/prepare-ChangeLog:
1905         - Properly parse GECOS field.
1906         - Use git configuration for user name and email when appropriate.
1907
1908 2007-09-17  Sam Weinig  <sam@webkit.org>
1909
1910         Build fix.
1911
1912         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1913
1914 2007-09-17  Sam Weinig  <sam@webkit.org>
1915
1916         Reviewed by Adam Roben.
1917
1918         Share more code between mac and windows DRT.
1919             - GCController is now shared.
1920             - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
1921
1922         * DumpRenderTree/GCController.cpp:
1923         * DumpRenderTree/win/DumpRenderTree.cpp:
1924         * DumpRenderTree/win/DumpRenderTree.vcproj:
1925         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
1926         (FrameLoadDelegate::FrameLoadDelegate):
1927         (FrameLoadDelegate::~FrameLoadDelegate):
1928         (FrameLoadDelegate::windowScriptObjectAvailable):
1929         * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
1930         * DumpRenderTree/win/GCController.cpp: Removed.
1931         * DumpRenderTree/win/GCController.h: Removed.
1932         * DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp.
1933         (GCController::collect):
1934         (GCController::collectOnAlternateThread):
1935         (GCController::getJSObjectCount):
1936         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
1937         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
1938
1939 2007-09-17  Sam Weinig  <sam@webkit.org>
1940
1941         Reviewed by Adam Roben.
1942
1943         Begin sharing code between mac and windows DRT.
1944             - both now share LayoutTestController.h/cpp and implement platform dependant
1945               operations in LayoutTestControllerMac/Win.
1946             - DumpRenderTree.h is now shared.
1947             - WorkQueue and WorkQueueItem are also shared.
1948
1949         * DumpRenderTree/DumpRenderTree.h:
1950         * DumpRenderTree/LayoutTestController.cpp:
1951         * DumpRenderTree/win/DumpRenderTree.cpp:
1952         (displayWebView):
1953         (dumpFrameScrollPosition):
1954         (dumpFramesAsText):
1955         (dump):
1956         (runTest):
1957         * DumpRenderTree/win/DumpRenderTree.h: Removed.
1958         * DumpRenderTree/win/DumpRenderTree.vcproj:
1959         * DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
1960         * DumpRenderTree/win/EditingDelegate.cpp:
1961         (EditingDelegate::shouldBeginEditingInDOMRange):
1962         (EditingDelegate::shouldEndEditingInDOMRange):
1963         (EditingDelegate::shouldInsertNode):
1964         (EditingDelegate::shouldInsertText):
1965         (EditingDelegate::shouldDeleteDOMRange):
1966         (EditingDelegate::shouldChangeSelectedDOMRange):
1967         (EditingDelegate::shouldApplyStyle):
1968         (EditingDelegate::shouldChangeTypingStyle):
1969         (EditingDelegate::doPlatformCommand):
1970         (EditingDelegate::webViewDidBeginEditing):
1971         (EditingDelegate::webViewDidChange):
1972         (EditingDelegate::webViewDidEndEditing):
1973         (EditingDelegate::webViewDidChangeTypingStyle):
1974         (EditingDelegate::webViewDidChangeSelection):
1975         * DumpRenderTree/win/LayoutTestController.cpp: Removed.
1976         * DumpRenderTree/win/LayoutTestController.h: Removed.
1977         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Copied from DumpRenderTree/win/LayoutTestController.cpp.
1978         (LayoutTestController::addDisallowedURL):
1979         (LayoutTestController::clearBackForwardList):
1980         (LayoutTestController::copyDecodedHostName):
1981         (LayoutTestController::copyEncodedHostName):
1982         (LayoutTestController::display):
1983         (LayoutTestController::keepWebHistory):
1984         (LayoutTestController::notifyDone):
1985         (LayoutTestController::queueBackNavigation):
1986         (LayoutTestController::queueForwardNavigation):
1987         (jsStringRefToWString):
1988         (LayoutTestController::queueLoad):
1989         (LayoutTestController::queueReload):
1990         (LayoutTestController::queueScript):
1991         (LayoutTestController::setAcceptsEditing):
1992         (LayoutTestController::setCustomPolicyDelegate):
1993         (LayoutTestController::setMainFrameIsFirstResponder):
1994         (LayoutTestController::setTabKeyCyclesThroughElements):
1995         (LayoutTestController::setUseDashboardCompatibilityMode):
1996         (LayoutTestController::setUserStyleSheetEnabled):
1997         (LayoutTestController::setUserStyleSheetLocation):
1998         (LayoutTestController::setWindowIsKey):
1999         (waitUntilDoneWatchdogFired):
2000         (LayoutTestController::setWaitToDump):
2001         (LayoutTestController::windowCount):
2002         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp:
2003         (FrameLoadDelegate::didReceiveTitle):
2004         (FrameLoadDelegate::processWork):
2005         (FrameLoadDelegate::locationChangeDone):
2006         (FrameLoadDelegate::windowScriptObjectAvailable):
2007         * DumpRenderTree/win/WorkQueue.cpp: Removed.
2008         * DumpRenderTree/win/WorkQueue.h: Removed.
2009         * DumpRenderTree/win/WorkQueueItem.cpp: Removed.
2010         * DumpRenderTree/win/WorkQueueItem.h: Removed.
2011         * DumpRenderTree/win/WorkQueueItemWin.cpp: Copied from DumpRenderTree/win/WorkQueueItem.cpp.
2012         (jsStringRefToWString):
2013         (LoadItem::invoke):
2014         (ScriptItem::invoke):
2015
2016 2007-09-17  Sam Weinig  <sam@webkit.org>
2017
2018         Reviewed by Adam Roben.
2019
2020         - Move Windows DumpRenderTree and TestNetscapePlugin to WebCoreTools/DumpRenderTree/win
2021
2022         * DumpRenderTree/DumpRenderTree.sln: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln.
2023         * DumpRenderTree/DumpRenderTree.vcproj: Removed.
2024         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Removed.
2025         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Removed.
2026         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h: Removed.
2027         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Removed.
2028         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Removed.
2029         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed.
2030         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: Removed.
2031         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: Removed.
2032         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: Removed.
2033         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h: Removed.
2034         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp: Removed.
2035         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h: Removed.
2036         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Removed.
2037         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Removed.
2038         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Removed.
2039         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Removed.
2040         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: Removed.
2041         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Removed.
2042         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp: Removed.
2043         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h: Removed.
2044         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: Removed.
2045         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: Removed.
2046         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops: Removed.
2047         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops: Removed.
2048         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops: Removed.
2049         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin: Removed.
2050         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
2051         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
2052         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
2053         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/main.c: Removed.
2054         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/resource.h: Removed.
2055         * DumpRenderTree/win: Added.
2056         * DumpRenderTree/win/DraggingInfo.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h.
2057         * DumpRenderTree/win/DumpRenderTree.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp.
2058         * DumpRenderTree/win/DumpRenderTree.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h.
2059         * DumpRenderTree/win/DumpRenderTree.vcproj: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj.
2060         * DumpRenderTree/win/EditingDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp.
2061         * DumpRenderTree/win/EditingDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h.
2062         * DumpRenderTree/win/EventSender.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp.
2063         * DumpRenderTree/win/EventSender.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h.
2064         * DumpRenderTree/win/GCController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp.
2065         * DumpRenderTree/win/GCController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h.
2066         * DumpRenderTree/win/LayoutTestController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp.
2067         * DumpRenderTree/win/LayoutTestController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h.
2068         * DumpRenderTree/win/TestNetscapePlugin: Copied from DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin.
2069         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2070         * DumpRenderTree/win/UIDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp.
2071         * DumpRenderTree/win/UIDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h.
2072         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp.
2073         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h.
2074         * DumpRenderTree/win/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
2075         * DumpRenderTree/win/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
2076         * DumpRenderTree/win/WorkQueueItem.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp.
2077         * DumpRenderTree/win/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
2078         * DumpRenderTree/win/debug.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops.
2079         * DumpRenderTree/win/debug_internal.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops.
2080         * DumpRenderTree/win/release.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops.
2081         * Scripts/run-webkit-tests: Update to point to the new location of the sln.
2082
2083 2007-09-15  Mark Rowe  <mrowe@apple.com>
2084
2085         Build fix for DumpRenderTree.
2086
2087         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Reinstate -Wno-deprecated-declarations on DumpRenderTree.mm.
2088
2089 2007-09-14  Sam Weinig  <sam@webkit.org>
2090
2091         Rubber stamped by Adam Roben.
2092
2093         Split the WaitUntilDoneDelegate into a UIDelegate and a FrameLoadDelegate.
2094           - The UIDelegate was put into a new file while the FrameLoadDelegate was
2095             kept in the WaitUntilDoneDelegate file for the time being.
2096
2097         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
2098         (main):
2099         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
2100         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Added.
2101         (UIDelegate::QueryInterface):
2102         (UIDelegate::AddRef):
2103         (UIDelegate::Release):
2104         (UIDelegate::hasCustomMenuImplementation):
2105         (UIDelegate::setFrame):
2106         (UIDelegate::webViewFrame):
2107         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2108         (UIDelegate::webViewAddMessageToConsole):
2109         (UIDelegate::doDragDrop):
2110         (UIDelegate::webViewGetDlgCode):
2111         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Added.
2112         (UIDelegate::UIDelegate):
2113         (UIDelegate::createWebViewWithRequest):
2114         (UIDelegate::webViewShow):
2115         (UIDelegate::webViewClose):
2116         (UIDelegate::webViewFocus):
2117         (UIDelegate::webViewUnfocus):
2118         (UIDelegate::webViewFirstResponder):
2119         (UIDelegate::makeFirstResponder):
2120         (UIDelegate::setStatusText):
2121         (UIDelegate::webViewStatusText):
2122         (UIDelegate::webViewAreToolbarsVisible):
2123         (UIDelegate::setToolbarsVisible):
2124         (UIDelegate::webViewIsStatusBarVisible):
2125         (UIDelegate::setStatusBarVisible):
2126         (UIDelegate::webViewIsResizable):
2127         (UIDelegate::setResizable):
2128         (UIDelegate::setContentRect):
2129         (UIDelegate::webViewContentRect):
2130         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2131         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2132         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
2133         (UIDelegate::runOpenPanelForFileButtonWithResultListener):
2134         (UIDelegate::mouseDidMoveOverElement):
2135         (UIDelegate::contextMenuItemsForElement):
2136         (UIDelegate::validateUserInterfaceItem):
2137         (UIDelegate::shouldPerformAction):
2138         (UIDelegate::dragDestinationActionMaskForDraggingInfo):
2139         (UIDelegate::willPerformDragDestinationAction):
2140         (UIDelegate::dragSourceActionMaskForPoint):
2141         (UIDelegate::willPerformDragSourceAction):
2142         (UIDelegate::contextMenuItemSelected):
2143         (UIDelegate::trackCustomPopupMenu):
2144         (UIDelegate::measureCustomMenuItem):
2145         (UIDelegate::drawCustomMenuItem):
2146         (UIDelegate::addCustomMenuDrawingData):
2147         (UIDelegate::cleanUpCustomMenuDrawingData):
2148         (UIDelegate::canTakeFocus):
2149         (UIDelegate::takeFocus):
2150         (UIDelegate::registerUndoWithTarget):
2151         (UIDelegate::removeAllActionsWithTarget):
2152         (UIDelegate::setActionTitle):
2153         (UIDelegate::undo):
2154         (UIDelegate::redo):
2155         (UIDelegate::canUndo):
2156         (UIDelegate::canRedo):
2157         (UIDelegate::webViewResizerRect):
2158         (UIDelegate::webViewDrawResizer):
2159         (UIDelegate::webViewScrolled):
2160         (UIDelegate::webViewShouldInterruptJavaScript):
2161         (UIDelegate::webViewReceivedFocus):
2162         (UIDelegate::webViewLostFocus):
2163         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
2164         (FrameLoadDelegate::QueryInterface):
2165         (FrameLoadDelegate::AddRef):
2166         (FrameLoadDelegate::Release):
2167         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2168         (FrameLoadDelegate::didCommitLoadForFrame):
2169         (FrameLoadDelegate::didReceiveTitle):
2170         (FrameLoadDelegate::processWork):
2171         (processWorkTimer):
2172         (FrameLoadDelegate::locationChangeDone):
2173         (FrameLoadDelegate::didFinishLoadForFrame):
2174         (FrameLoadDelegate::didFailLoadWithError):
2175         (FrameLoadDelegate::windowScriptObjectAvailable):
2176         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h:
2177         (FrameLoadDelegate::FrameLoadDelegate):
2178
2179 2007-09-14  Sam Weinig  <sam@webkit.org>
2180
2181         Reviewed by Kevin McCullough.
2182
2183         Move mac specific globals in to mac/DumpRenderTreeMac.h
2184
2185         * DumpRenderTree/DumpRenderTree.h:
2186         * DumpRenderTree/DumpRenderTree.mm: Removed.
2187         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2188         * DumpRenderTree/mac/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.mm.
2189         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added.
2190
2191 2007-09-14  Brady Eidson  <beidson@apple.com>
2192
2193         Rubberstamped by Weinig
2194
2195         You know, Sam, some of us use case-sensitve filesystems...
2196
2197         * DumpRenderTree/DumpRenderTree.h:
2198         * DumpRenderTree/mac/UIDelegate.mm:
2199
2200 2007-09-14  Sam Weinig  <sam@webkit.org>
2201
2202         Rubber stamped by Adam Roben.
2203
2204         - Move dump state data to LayoutTestContoller and add getter/setters to accommodate.
2205         - Move mac specific DumpRenderTree files to DumpRenderTree/mac
2206
2207         * DumpRenderTree/AppleScriptController.h: Removed.
2208         * DumpRenderTree/AppleScriptController.m: Removed.
2209         * DumpRenderTree/DumpRenderTree.h:
2210         * DumpRenderTree/DumpRenderTree.mm:
2211         (startJavaScriptThreads):
2212         (stopJavaScriptThreads):
2213         (activateAhemFont):
2214         (setDefaultColorProfileToRGB):
2215         (makeLargeMallocFailSilently):
2216         (dumpFrameScrollPosition):
2217         (dumpFramesAsText):
2218         (dump):
2219         (runTest):
2220         (-[DumpRenderTreeWindow isKeyWindow]):
2221         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2222         * DumpRenderTree/DumpRenderTreeDraggingInfo.h: Removed.
2223         * DumpRenderTree/DumpRenderTreeDraggingInfo.m: Removed.
2224         * DumpRenderTree/EditingDelegate.h: Removed.
2225         * DumpRenderTree/EditingDelegate.m: Removed.
2226         * DumpRenderTree/EventSendingController.h: Removed.
2227         * DumpRenderTree/EventSendingController.m: Removed.
2228         * DumpRenderTree/FrameLoadDelegate.h: Removed.
2229         * DumpRenderTree/FrameLoadDelegate.mm: Removed.
2230         * DumpRenderTree/GCController.mm: Removed.
2231         * DumpRenderTree/ImageDiff.m: Removed.
2232         * DumpRenderTree/LayoutTestController.cpp:
2233         (LayoutTestController::LayoutTestController):
2234         (dumpAsTextCallback):
2235         (dumpBackForwardListCallback):
2236         (dumpChildFramesAsTextCallback):
2237         (dumpChildFrameScrollPositionsCallback):
2238         (dumpDOMAsWebArchiveCallback):
2239         (dumpEditingCallbacksCallback):
2240         (dumpFrameLoadCallbacksCallback):
2241         (dumpResourceLoadCallbacksCallback):
2242         (dumpSelectionRectCallback):
2243         (dumpSourceAsWebArchiveCallback):
2244         (dumpTitleChangesCallback):
2245         (repaintSweepHorizontallyCallback):
2246         (setCallCloseOnWebViewsCallback):
2247         (setCanOpenWindowsCallback):
2248         (setCloseRemainingWindowsWhenCompleteCallback):
2249         (testRepaintCallback):
2250         (addFileToPasteboardOnDragCallback):
2251         (waitUntilDoneCallback):
2252         * DumpRenderTree/LayoutTestController.h:
2253         (LayoutTestController::dumpAsText):
2254         (LayoutTestController::setDumpAsText):
2255         (LayoutTestController::dumpBackForwardList):
2256         (LayoutTestController::setDumpBackForwardList):
2257         (LayoutTestController::dumpChildFrameScrollPositions):
2258         (LayoutTestController::setDumpChildFrameScrollPositions):
2259         (LayoutTestController::dumpChildFramesAsText):
2260         (LayoutTestController::setDumpChildFramesAsText):
2261         (LayoutTestController::dumpDOMAsWebArchive):
2262         (LayoutTestController::setDumpDOMAsWebArchive):
2263         (LayoutTestController::dumpSelectionRect):
2264         (LayoutTestController::setDumpSelectionRect):
2265         (LayoutTestController::dumpSourceAsWebArchive):
2266         (LayoutTestController::setDumpSourceAsWebArchive):
2267         (LayoutTestController::dumpTitleChanges):
2268         (LayoutTestController::setDumpTitleChanges):
2269         (LayoutTestController::dumpEditingCallbacks):
2270         (LayoutTestController::setDumpEditingCallbacks):
2271         (LayoutTestController::dumpResourceLoadCallbacks):
2272         (LayoutTestController::setDumpResourceLoadCallbacks):
2273         (LayoutTestController::dumpFrameLoadCallbacks):
2274         (LayoutTestController::setDumpFrameLoadCallbacks):
2275         (LayoutTestController::addFileToPasteboardOnDrag):
2276         (LayoutTestController::setAddFileToPasteboardOnDrag):
2277         (LayoutTestController::callCloseOnWebViews):
2278         (LayoutTestController::setCallCloseOnWebViews):
2279         (LayoutTestController::canOpenWindows):
2280         (LayoutTestController::setCanOpenWindows):
2281         (LayoutTestController::closeRemainingWindowsWhenComplete):
2282         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
2283         (LayoutTestController::testRepaint):
2284         (LayoutTestController::setTestRepaint):
2285         (LayoutTestController::testRepaintSweepHorizontally):
2286         (LayoutTestController::setTestRepaintSweepHorizontally):
2287         (LayoutTestController::waitToDump):
2288         (LayoutTestController::windowIsKey):
2289         * DumpRenderTree/LayoutTestControllerMac.mm: Removed.
2290         * DumpRenderTree/NavigationController.h: Removed.
2291         * DumpRenderTree/NavigationController.m: Removed.
2292         * DumpRenderTree/ObjCController.h: Removed.
2293         * DumpRenderTree/ObjCController.m: Removed.
2294         * DumpRenderTree/ObjCPlugin.h: Removed.
2295         * DumpRenderTree/ObjCPlugin.m: Removed.
2296         * DumpRenderTree/ObjCPluginFunction.h: Removed.
2297         * DumpRenderTree/ObjCPluginFunction.m: Removed.
2298         * DumpRenderTree/PolicyDelegate.h: Removed.
2299         * DumpRenderTree/PolicyDelegate.m: Removed.
2300         * DumpRenderTree/ResourceLoadDelegate.h: Removed.
2301         * DumpRenderTree/ResourceLoadDelegate.m: Removed.
2302         * DumpRenderTree/TextInputController.h: Removed.
2303         * DumpRenderTree/TextInputController.m: Removed.
2304         * DumpRenderTree/UIDelegate.h: Removed.
2305         * DumpRenderTree/UIDelegate.mm: Removed.
2306         * DumpRenderTree/WorkQueueItemMac.mm: Removed.
2307         * DumpRenderTree/mac: Added.
2308         * DumpRenderTree/mac/AppleScriptController.h: Copied from DumpRenderTree/AppleScriptController.h.
2309         * DumpRenderTree/mac/AppleScriptController.m: Copied from DumpRenderTree/AppleScriptController.m.
2310         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.h.
2311         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.m.
2312         * DumpRenderTree/mac/EditingDelegate.h: Copied from DumpRenderTree/EditingDelegate.h.
2313         * DumpRenderTree/mac/EditingDelegate.mm: Copied from DumpRenderTree/EditingDelegate.m.
2314         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2315         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2316         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2317         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2318         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2319         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2320         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2321         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2322         (-[EditingDelegate webViewDidBeginEditing:]):
2323         (-[EditingDelegate webViewDidChange:]):
2324         (-[EditingDelegate webViewDidEndEditing:]):
2325         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2326         (-[EditingDelegate webViewDidChangeSelection:]):
2327         * DumpRenderTree/mac/EventSendingController.h: Copied from DumpRenderTree/EventSendingController.h.
2328         * DumpRenderTree/mac/EventSendingController.mm: Copied from DumpRenderTree/EventSendingController.m.
2329         * DumpRenderTree/mac/FrameLoadDelegate.h: Copied from DumpRenderTree/FrameLoadDelegate.h.
2330         * DumpRenderTree/mac/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.mm.
2331         (-[FrameLoadDelegate init]):
2332         (-[FrameLoadDelegate dealloc]):
2333         (-[FrameLoadDelegate processWork:]):
2334         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
2335         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2336         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2337         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2338         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2339         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2340         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2341         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2342         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2343         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2344         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2345         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2346         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2347         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2348         (-[FrameLoadDelegate webView:willCloseFrame:]):
2349         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2350         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2351         * DumpRenderTree/mac/GCControllerMac.mm: Copied from DumpRenderTree/GCController.mm.
2352         * DumpRenderTree/mac/ImageDiff.m: Copied from DumpRenderTree/ImageDiff.m.
2353         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Copied from DumpRenderTree/LayoutTestControllerMac.mm.
2354         (LayoutTestController::notifyDone):
2355         (LayoutTestController::setWindowIsKey):
2356         (LayoutTestController::setWaitToDump):
2357         * DumpRenderTree/mac/NavigationController.h: Copied from DumpRenderTree/NavigationController.h.
2358         * DumpRenderTree/mac/NavigationController.m: Copied from DumpRenderTree/NavigationController.m.
2359         * DumpRenderTree/mac/ObjCController.h: Copied from DumpRenderTree/ObjCController.h.
2360         * DumpRenderTree/mac/ObjCController.m: Copied from DumpRenderTree/ObjCController.m.
2361         * DumpRenderTree/mac/ObjCPlugin.h: Copied from DumpRenderTree/ObjCPlugin.h.
2362         * DumpRenderTree/mac/ObjCPlugin.m: Copied from DumpRenderTree/ObjCPlugin.m.
2363         * DumpRenderTree/mac/ObjCPluginFunction.h: Copied from DumpRenderTree/ObjCPluginFunction.h.
2364         * DumpRenderTree/mac/ObjCPluginFunction.m: Copied from DumpRenderTree/ObjCPluginFunction.m.
2365         * DumpRenderTree/mac/PolicyDelegate.h: Copied from DumpRenderTree/PolicyDelegate.h.
2366         * DumpRenderTree/mac/PolicyDelegate.mm: Copied from DumpRenderTree/PolicyDelegate.m.
2367         * DumpRenderTree/mac/ResourceLoadDelegate.h: Copied from DumpRenderTree/ResourceLoadDelegate.h.
2368         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Copied from DumpRenderTree/ResourceLoadDelegate.m.
2369         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2370         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2371         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2372         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2373         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2374         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2375         * DumpRenderTree/mac/TextInputController.h: Copied from DumpRenderTree/TextInputController.h.
2376         * DumpRenderTree/mac/TextInputController.m: Copied from DumpRenderTree/TextInputController.m.
2377         * DumpRenderTree/mac/UIDelegate.h: Copied from DumpRenderTree/UIDelegate.h.
2378         * DumpRenderTree/mac/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.mm.
2379         (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
2380         (-[UIDelegate webViewFocus:]):
2381         (-[UIDelegate webView:createWebViewWithRequest:]):
2382         (-[UIDelegate webViewClose:]):
2383         * DumpRenderTree/mac/WorkQueueItemMac.mm: Copied from DumpRenderTree/WorkQueueItemMac.mm.
2384
2385 2007-09-14  Kevin McCullough  <kmccullough@apple.com>
2386
2387         Reviewed by Adam.
2388
2389         - Changing Win version of Drosera work with recent changes.
2390
2391         * Drosera/DebuggerDocument.cpp:
2392         * Drosera/DebuggerDocument.h:
2393         * Drosera/mac/DebuggerDocumentPlatform.mm:
2394         (NSStringCreateWithJSStringRef):
2395         (JSValueRefCreateWithNSString):
2396         * Drosera/win/DebuggerClient.cpp:
2397         (DebuggerClient::stepInto):
2398         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2399
2400 2007-09-13  Kevin McCullough  <kmccullough@apple.com>
2401
2402         Reviewed by Tim.
2403
2404         - Moved isPaused into the JS for efficiency and simplicity.
2405
2406         * Drosera/DebuggerDocument.cpp:
2407         (DebuggerDocument::DebuggerDocument):
2408         (DebuggerDocument::pauseCallback):
2409         (DebuggerDocument::resumeCallback):
2410         (DebuggerDocument::isPaused):
2411         (DebuggerDocument::staticFunctions):
2412         * Drosera/DebuggerDocument.h:
2413         * Drosera/console.js:
2414         * Drosera/debugger.js:
2415         * Drosera/mac/DebuggerClient.mm:
2416         (-[DebuggerClient validateUserInterfaceItem:]):
2417
2418 2007-09-13  Sam Weinig  <sam@webkit.org>
2419
2420         Rubber stamped by Darin.
2421
2422         Make DumpRenderTree more cross platform ready.
2423         - Convert GCController to use the JSCore API instead of the WebScriptObject.
2424         - Use CF types instead of NS objects.
2425         - General cleanup.
2426
2427         * DumpRenderTree/DumpRenderTree.h:
2428         * DumpRenderTree/DumpRenderTree.mm:
2429         (dumpRenderTree):
2430         (dump):
2431         (runTest):
2432         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2433         * DumpRenderTree/EditingDelegate.m:
2434         * DumpRenderTree/FrameLoadDelegate.h:
2435         * DumpRenderTree/FrameLoadDelegate.mm:
2436         (-[FrameLoadDelegate init]):
2437         (-[FrameLoadDelegate dealloc]):
2438         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2439         * DumpRenderTree/GCController.cpp: Added.
2440         (GCController::GCController):
2441         (GCController::~GCController):
2442         (collectCallback):
2443         (collectOnAlternateThreadCallback):
2444         (getJSObjectCountCallback):
2445         (GCController::makeWindowObject):
2446         (GCController::getJSClass):
2447         (GCController::staticFunctions):
2448         * DumpRenderTree/GCController.h:
2449         * DumpRenderTree/GCController.mm:
2450         (GCController::collect):
2451         (GCController::collectOnAlternateThread):
2452         (GCController::getJSObjectCount):
2453         * DumpRenderTree/LayoutTestController.cpp:
2454         (LayoutTestController::makeWindowObject):
2455         (LayoutTestController::getJSClass):
2456         * DumpRenderTree/LayoutTestController.h:
2457         * DumpRenderTree/LayoutTestControllerMac.mm:
2458         (LayoutTestController::addDisallowedURL):
2459         (waitUntilDoneWatchdogFired):
2460         (LayoutTestController::waitUntilDone):
2461         * DumpRenderTree/ResourceLoadDelegate.m:
2462         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2463
2464 2007-09-12  Sam Weinig  <sam@webkit.org>
2465
2466         Reviewed by Stephanie.
2467
2468         Fix leaks in mac DumpRenderTree.
2469
2470         * DumpRenderTree/FrameLoadDelegate.mm:
2471         (-[FrameLoadDelegate init]): Initalize in the correct order.
2472         (-[FrameLoadDelegate processWork:]): Delete WorkQueueItem's after dequeueing them.
2473         * DumpRenderTree/LayoutTestController.cpp:
2474         (decodeHostNameCallback): Put return value in a temporary JSRetainPtr to ensure it gets released.
2475         (encodeHostNameCallback): ditto.
2476         * DumpRenderTree/LayoutTestController.h:
2477         * DumpRenderTree/LayoutTestControllerMac.mm:
2478         (LayoutTestController::copyDecodedHostName): Rename function to signal that it follows the Create rule.
2479         (LayoutTestController::copyEncodedHostName): ditto
2480         (LayoutTestController::queueLoad): Use a JSRetainPtr to ensure the url gets released.
2481
2482 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
2483
2484         Reviewed by Geof.
2485
2486         - Updated Leopard leak list to include a leak which appears to be fixed in 9A549 but not the version the bot is on.  This will allow us to get the bot green, but later we should remove it.
2487
2488         * Scripts/run-webkit-tests:
2489
2490 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
2491
2492         Reviewed by Darin.
2493
2494         - Simplified code paths and extracted out functions to increase encapsulation.
2495
2496         * Drosera/DebuggerDocument.cpp:
2497         (DebuggerDocument::breakpointEditorHTMLCallback):
2498         (DebuggerDocument::isPausedCallback):
2499         (DebuggerDocument::pauseCallback):
2500         (DebuggerDocument::resumeCallback):
2501         (DebuggerDocument::stepIntoCallback):
2502         (DebuggerDocument::evaluateScriptCallback):
2503         (DebuggerDocument::currentFunctionStackCallback):
2504         (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
2505         (DebuggerDocument::valueForScopeVariableNamedCallback):
2506         (DebuggerDocument::logCallback):
2507         * Drosera/DebuggerDocument.h:
2508         (DebuggerDocument::getPaused):
2509         * Drosera/mac/DebuggerClient.mm:
2510         (-[DebuggerClient pause:]):
2511         (-[DebuggerClient resume:]):
2512         (-[DebuggerClient stepInto:]):
2513         (-[DebuggerClient stepOver:]):
2514         (-[DebuggerClient stepOut:]):
2515         (-[DebuggerClient showConsole:]):
2516         (-[DebuggerClient closeCurrentFile:]):
2517         (-[DebuggerClient validateUserInterfaceItem:]):
2518         * Drosera/mac/DebuggerDocumentPlatform.mm: Added.
2519         (+[NSString stringOrNilFromWebScriptResult:]):
2520         (DebuggerDocument::platformPause):
2521         (DebuggerDocument::platformResume):
2522         (DebuggerDocument::platformStepInto):
2523         (DebuggerDocument::platformEvaluateScript):
2524         (DebuggerDocument::getPlatformCurrentFunctionStack):
2525         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2526         (DebuggerDocument::platformValueForScopeVariableNamed):
2527         (DebuggerDocument::platformLog):
2528         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2529
2530 2007-09-12  Sam Weinig  <sam@webkit.org>
2531
2532         Build fix for Buildbot.
2533
2534         * DumpRenderTree/DumpRenderTree.mm:
2535         (dump):
2536
2537 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
2538
2539         Reviewed by Geoff.
2540
2541         - Updated the leaks list for leopard to help identify regressions.
2542
2543         * Scripts/run-webkit-tests:
2544
2545 2007-09-12  Sam Weinig  <sam@webkit.org>
2546
2547         Rubber stamped by Darin.
2548
2549         Convert the LayoutTestController to use the JSCore API instead of WebScriptObject.
2550
2551         * DumpRenderTree/DumpRenderTree.h: Re-order variables.
2552         * DumpRenderTree/DumpRenderTree.m: Removed.
2553         * DumpRenderTree/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.m.
2554         (stopJavaScriptThreads): Fix initialization.
2555         (setDefaultColorProfileToRGB): Add explicit cast from void*.
2556         (dumpRenderTree): Ditto.
2557         (runTest):
2558         Used the WorkQueue from the windows DRT instead of the old NSMutableArray one.
2559
2560         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2561         * DumpRenderTree/FrameLoadDelegate.h: Add LayoutTestController instance variable.
2562         * DumpRenderTree/FrameLoadDelegate.m: Removed.
2563         * DumpRenderTree/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.m.
2564         (-[FrameLoadDelegate init]):
2565         (-[FrameLoadDelegate dealloc]):
2566         (-[FrameLoadDelegate processWork:]):
2567         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
2568         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2569         Convert to use the new JSCore based LayoutTestController and the new WorkQueue.
2570
2571         * DumpRenderTree/LayoutTestController.cpp: Added.
2572         (LayoutTestController::LayoutTestController):
2573         (LayoutTestController::~LayoutTestController):
2574         (dumpAsTextCallback):
2575         (dumpBackForwardListCallback):
2576         (dumpChildFramesAsTextCallback):
2577         (dumpChildFrameScrollPositionsCallback):
2578         (dumpDOMAsWebArchiveCallback):
2579         (dumpEditingCallbacksCallback):
2580         (dumpFrameLoadCallbacksCallback):
2581         (dumpResourceLoadCallbacksCallback):
2582         (dumpSelectionRectCallback):
2583         (dumpSourceAsWebArchiveCallback):
2584         (dumpTitleChangesCallback):
2585         (repaintSweepHorizontallyCallback):
2586         (setCallCloseOnWebViewsCallback):
2587         (setCanOpenWindowsCallback):
2588         (setCloseRemainingWindowsWhenCompleteCallback):
2589         (testRepaintCallback):
2590         (addFileToPasteboardOnDragCallback):
2591         (addDisallowedURLCallback):
2592         (clearBackForwardListCallback):
2593         (decodeHostNameCallback):
2594         (displayCallback):
2595         (encodeHostNameCallback):
2596         (keepWebHistoryCallback):
2597         (notifyDoneCallback):
2598         (queueBackNavigationCallback):
2599         (queueForwardNavigationCallback):
2600         (queueLoadCallback):
2601         (queueReloadCallback):
2602         (queueScriptCallback):
2603         (setAcceptsEditingCallback):
2604         (setCustomPolicyDelegateCallback):
2605         (setMainFrameIsFirstResponderCallback):
2606         (setTabKeyCyclesThroughElementsCallback):
2607         (setUseDashboardCompatibilityModeCallback):
2608         (setUserStyleSheetEnabledCallback):
2609         (setUserStyleSheetLocationCallback):
2610         (setWindowIsKeyCallback):
2611         (waitUntilDoneCallback):
2612         (windowCountCallback):
2613         (LayoutTestController::makeWindowObject):
2614         (LayoutTestController::getLayoutTestControllerJSClass):
2615         (LayoutTestController::staticFunctions):
2616         * DumpRenderTree/LayoutTestController.h: Replaced.
2617         * DumpRenderTree/LayoutTestController.m: Removed.
2618         * DumpRenderTree/LayoutTestControllerMac.mm: Added.
2619         (LayoutTestController::dumpAsText):
2620         (LayoutTestController::dumpBackForwardList):
2621         (LayoutTestController::dumpChildFramesAsText):
2622         (LayoutTestController::dumpChildFrameScrollPositions):
2623         (LayoutTestController::dumpDOMAsWebArchive):
2624         (LayoutTestController::dumpEditingCallbacks):
2625         (LayoutTestController::dumpFrameLoadCallbacks):
2626         (LayoutTestController::dumpResourceLoadCallbacks):
2627         (LayoutTestController::dumpSelectionRect):
2628         (LayoutTestController::dumpSourceAsWebArchive):
2629         (LayoutTestController::dumpTitleChanges):
2630         (LayoutTestController::repaintSweepHorizontally):
2631         (LayoutTestController::setCallCloseOnWebViews):
2632         (LayoutTestController::setCanOpenWindows):
2633         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
2634         (LayoutTestController::testRepaint):
2635         (LayoutTestController::addFileToPasteboardOnDrag):
2636         (LayoutTestController::addDisallowedURL):
2637         (LayoutTestController::clearBackForwardList):
2638         (LayoutTestController::decodeHostName):
2639         (LayoutTestController::encodeHostName):
2640         (LayoutTestController::display):
2641         (LayoutTestController::keepWebHistory):
2642         (LayoutTestController::notifyDone):
2643         (LayoutTestController::queueBackNavigation):
2644         (LayoutTestController::queueForwardNavigation):
2645         (LayoutTestController::queueLoad):
2646         (LayoutTestController::queueReload):
2647         (LayoutTestController::queueScript):
2648         (LayoutTestController::setAcceptsEditing):
2649         (LayoutTestController::setCustomPolicyDelegate):
2650         (LayoutTestController::setMainFrameIsFirstResponder):
2651         (LayoutTestController::setTabKeyCyclesThroughElements):
2652         (LayoutTestController::setUseDashboardCompatibilityMode):
2653         (LayoutTestController::setUserStyleSheetEnabled):
2654         (LayoutTestController::setUserStyleSheetLocation):
2655         (LayoutTestController::setWindowIsKey):
2656         (+[WaitToDumpWatchdog waitUntilDoneWatchdogFired]):
2657         (LayoutTestController::waitUntilDone):
2658         (LayoutTestController::windowCount):
2659         Use the JSCore API to implement the LayoutTestController.
2660
2661         * DumpRenderTree/ObjCController.h:
2662         * DumpRenderTree/ObjCController.m:
2663         (+[ObjCController isSelectorExcludedFromWebScript:]):
2664         (+[ObjCController webScriptNameForSelector:]):
2665         (-[ObjCController accessStoredWebScriptObject]):
2666         (-[ObjCController storeWebScriptObject:]):
2667         (-[ObjCController dealloc]):
2668         (-[ObjCController invokeUndefinedMethodFromWebScript:withArguments:]):
2669         Move WebScriptObject tests to ObjCController.
2670
2671         * DumpRenderTree/UIDelegate.m: Removed.
2672         * DumpRenderTree/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.m.
2673
2674         * DumpRenderTree/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
2675         * DumpRenderTree/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
2676         * DumpRenderTree/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
2677         (WorkQueueItem::~WorkQueueItem):
2678         (LoadItem::LoadItem):
2679         (LoadItem::url):
2680         (LoadItem::target):
2681         (ScriptItem::ScriptItem):
2682         (ScriptItem::script):
2683         * DumpRenderTree/WorkQueueItemMac.mm: Added.
2684         (LoadItem::invoke):
2685         (ReloadItem::invoke):
2686         (ScriptItem::invoke):
2687         (BackForwardItem::invoke):
2688         Copy WorkQueue and WorkQueueItem from windows DRT. Changed the WorkQueueItem to use JSStringRefs instead of wstrings
2689         to avoid conversion until the last possible moment.  These changes will be merged with the windows DRT when we start
2690         sharing code.
2691
2692 2007-09-11  Kevin McCullough  <kmccullough@apple.com>
2693
2694         Reviewed by Maciej.
2695
2696         - Updated Win side to take advantage of the platform separating changes.
2697
2698         * Drosera/DebuggerDocument.cpp:
2699         (DebuggerDocument::localScopeVariableNamesForCallFrame):
2700         * Drosera/DebuggerDocument.h:
2701         * Drosera/win/DebuggerClient.cpp:
2702         (DebuggerClient::pause):
2703         (DebuggerClient::resume):
2704         (DebuggerClient::stepInto):
2705         (DebuggerDocument::platformPause):
2706         (DebuggerDocument::platformResume):
2707         (DebuggerDocument::platformStepInto):
2708         (DebuggerDocument::platformEvaluateScript):
2709         (DebuggerDocument::getPlatformCurrentFunctionStack):
2710         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2711         (DebuggerDocument::platformValueForScopeVariableNamed):
2712         (DebuggerDocument::platformLog):
2713         * Drosera/win/DebuggerClient.h:
2714         * Drosera/win/Drosera.cpp:
2715         (Drosera::Drosera):
2716         (Drosera::windowScriptObjectAvailable):
2717         (Drosera::initWithServerName):
2718         (Drosera::switchToServerNamed):
2719         * Drosera/win/Drosera.h:
2720         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2721
2722 2007-09-11  Kevin McCullough  <kmccullough@apple.com>
2723
2724         Reviewed by Adam.
2725
2726         - Just doing the moves in a separate patch so the changes are easier to see.
2727
2728         * Drosera/win/DebuggerClient.cpp: Copied from Drosera/win/DebuggerDocumentWin.cpp.
2729         * Drosera/win/DebuggerClient.h: Copied from Drosera/win/DebuggerDocumentWin.h.
2730         * Drosera/win/DebuggerDocumentWin.cpp: Removed.
2731         * Drosera/win/DebuggerDocumentWin.h: Removed.
2732         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2733
2734 2007-09-11  Sven Herzberg  <sven@imendio.com>
2735
2736         Don't overwrite LD_LIBRARY_PATH, prepend to it. Fixes:
2737         http://bugs.webkit.org/show_bug.cgi?id=15176
2738
2739         * Scripts/run-launcher: don't replace LD_LIBRARY_PATH with
2740         $projectDir, but prepend $projectDir to LD_LIBRARY_PATH (to preserve
2741         other paths eg. from jhbuild)
2742
2743 2007-09-10  Kevin McCullough  <kmccullough@apple.com>
2744
2745         Reviewed by Adam.
2746
2747         - Made an order-of-deletion mistake.
2748
2749         * Drosera/DebuggerDocument.h:
2750         * Drosera/ForwardingHeaders/wtf/Assertions.h: Removed.
2751         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Removed.
2752         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Removed.
2753         * Drosera/mac/DebuggerClient.mm:
2754         (DebuggerDocument::platformPause):
2755         (DebuggerDocument::platformResume):
2756         (DebuggerDocument::platformStepInto):
2757         (DebuggerDocument::platformEvaluateScript):
2758         (DebuggerDocument::getPlatformCurrentFunctionStack):
2759         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2760         (DebuggerDocument::platformValueForScopeVariableNamed):
2761         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2762
2763 2007-09-10  Kevin McCullough  <kmccullough@apple.com>
2764
2765         Reviewed by Darin.
2766
2767         - Renaming DebuggerDocument[platform] to DebuggerClient to be more clear.
2768
2769         * Drosera/DebuggerDocument.cpp:
2770         (DebuggerDocument::DebuggerDocument):
2771         * Drosera/DebuggerDocument.h:
2772         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
2773         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
2774         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
2775         * Drosera/mac/DebuggerApplication.mm:
2776         (-[DebuggerApplication attach:]):
2777         * Drosera/mac/DebuggerClient.h: Copied from Drosera/mac/DebuggerDocumentMac.h.
2778         * Drosera/mac/DebuggerClient.mm: Copied from Drosera/mac/DebuggerDocumentMac.mm.
2779         (DebuggerDocument::platformPause):
2780         (DebuggerDocument::platformResume):
2781         (DebuggerDocument::platformStepInto):
2782         (DebuggerDocument::platformEvaluateScript):
2783         (DebuggerDocument::getPlatformCurrentFunctionStack):
2784         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2785         (DebuggerDocument::platformValueForScopeVariableNamed):
2786         (DebuggerDocument::platformLog):
2787         * Drosera/mac/DebuggerDocumentMac.h: Removed.
2788         * Drosera/mac/DebuggerDocumentMac.mm: Removed.
2789         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2790
2791 2007-09-09  Sam Weinig  <sam@webkit.org>
2792
2793         Reviewed by Mark Rowe.
2794
2795         Remove 'objC' prefix from methods now in the ObjCController.
2796
2797         * DumpRenderTree/ObjCController.m:
2798         (+[ObjCController isSelectorExcludedFromWebScript:]):
2799         (+[ObjCController webScriptNameForSelector:]):
2800         (-[ObjCController classNameOf:]):
2801         (-[ObjCController objectOfClass:]):
2802         (-[ObjCController identityIsEqual::]):
2803         (-[ObjCController longLongRoundTrip:]):
2804         (-[ObjCController unsignedLongLongRoundTrip:]):
2805
2806 2007-09-09  Sam Weinig  <sam@webkit.org>
2807
2808         Reviewed by Oliver.
2809
2810         Initial refactor of DumpRenderTree in preparation of making it more platform independent.
2811         - Move LayoutTestController into its own file.
2812         - Move Objective-C only functions on LayoutTestController into a new controller called the
2813           ObjCController.
2814
2815         * DumpRenderTree/DumpRenderTree.h:
2816         * DumpRenderTree/DumpRenderTree.m:
2817         (displayWebView):
2818         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2819         * DumpRenderTree/FrameLoadDelegate.m:
2820         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2821         * DumpRenderTree/LayoutTestController.h: Added.
2822         * DumpRenderTree/LayoutTestController.m: Added.
2823         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
2824         (+[LayoutTestController webScriptNameForSelector:]):
2825         (-[LayoutTestController clearBackForwardList]):
2826         (-[LayoutTestController setUseDashboardCompatibilityMode:]):
2827         (-[LayoutTestController setCloseRemainingWindowsWhenComplete:]):
2828         (-[LayoutTestController setCustomPolicyDelegate:]):
2829         (-[LayoutTestController keepWebHistory]):
2830         (-[LayoutTestController setCallCloseOnWebViews:]):
2831         (-[LayoutTestController setCanOpenWindows]):
2832         (-[LayoutTestController waitUntilDone]):
2833         (-[LayoutTestController waitUntilDoneWatchdogFired]):
2834         (-[LayoutTestController notifyDone]):
2835         (-[LayoutTestController dumpAsText]):
2836         (-[LayoutTestController addFileToPasteboardOnDrag]):
2837         (-[LayoutTestController addDisallowedURL:]):
2838         (-[LayoutTestController setUserStyleSheetLocation:]):
2839         (-[LayoutTestController setUserStyleSheetEnabled:]):
2840         (-[LayoutTestController dumpDOMAsWebArchive]):
2841         (-[LayoutTestController dumpSourceAsWebArchive]):
2842         (-[LayoutTestController dumpSelectionRect]):
2843         (-[LayoutTestController dumpTitleChanges]):
2844         (-[LayoutTestController dumpBackForwardList]):
2845         (-[LayoutTestController windowCount]):
2846         (-[LayoutTestController dumpChildFrameScrollPositions]):
2847         (-[LayoutTestController dumpChildFramesAsText]):
2848         (-[LayoutTestController dumpEditingCallbacks]):
2849         (-[LayoutTestController dumpResourceLoadCallbacks]):
2850         (-[LayoutTestController dumpFrameLoadCallbacks]):
2851         (-[LayoutTestController setWindowIsKey:]):
2852         (-[LayoutTestController setMainFrameIsFirstResponder:]):
2853         (-[LayoutTestController display]):
2854         (-[LayoutTestController testRepaint]):
2855         (-[LayoutTestController repaintSweepHorizontally]):
2856         (-[LayoutTestController invokeUndefinedMethodFromWebScript:withArguments:]):
2857         (-[LayoutTestController _addWorkForTarget:selector:arg1:arg2:]):
2858         (-[LayoutTestController _doLoad:target:]):
2859         (-[LayoutTestController _doBackOrForwardNavigation:]):
2860         (-[LayoutTestController queueBackNavigation:]):
2861         (-[LayoutTestController queueForwardNavigation:]):
2862         (-[LayoutTestController queueReload]):
2863         (-[LayoutTestController queueScript:]):
2864         (-[LayoutTestController queueLoad:target:]):
2865         (-[LayoutTestController setAcceptsEditing:]):
2866         (-[LayoutTestController setTabKeyCyclesThroughElements:]):
2867         (-[LayoutTestController storeWebScriptObject:]):
2868         (-[LayoutTestController accessStoredWebScriptObject]):
2869         (-[LayoutTestController dealloc]):
2870         (-[LayoutTestController decodeHostName:]):
2871         (-[LayoutTestController encodeHostName:]):
2872         * DumpRenderTree/ObjCController.h: Added.
2873         * DumpRenderTree/ObjCController.m: Added.
2874         (+[ObjCController isSelectorExcludedFromWebScript:]):
2875         (+[ObjCController webScriptNameForSelector:]):
2876         (-[ObjCController objCClassNameOf:]):
2877         (-[ObjCController objCObjectOfClass:]):
2878         (-[ObjCController objCIdentityIsEqual::]):
2879         (-[ObjCController objCLongLongRoundTrip:]):
2880         (-[ObjCController objCUnsignedLongLongRoundTrip:]):
2881         (-[ObjCController testWrapperRoundTripping:]):
2882
2883 2007-09-07  Sam Weinig  <sam@webkit.org>
2884
2885         Reviewed by Alice.
2886
2887         Strip trailing and leading space/newline characters from skiplist file names.
2888
2889         * Scripts/run-webkit-tests:
2890
2891 2007-09-06  Kevin McCullough  <kmccullough@apple.com>
2892
2893         Reviewed by Maciej.
2894
2895         - Changed Drosera to take advantage of the JSRetainPtr changes.
2896
2897         * Drosera/DebuggerDocument.cpp:
2898         (DebuggerDocument::breakpointEditorHTML):
2899         (DebuggerDocument::evaluateScript):
2900         (DebuggerDocument::valueForScopeVariableNamed):
2901         (DebuggerDocument::log):
2902         (DebuggerDocument::windowScriptObjectAvailable):
2903         (DebuggerDocument::toJSArray):
2904         (DebuggerDocument::callFunctionOnObject):
2905         (DebuggerDocument::logException):
2906         * Drosera/mac/DebuggerDocumentMac.mm:
2907         (-[DebuggerClientMac webView:didLoadMainResourceForDataSource:]):
2908         (-[DebuggerClientMac webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
2909         (DebuggerDocument::platformEvaluateScript):
2910         (DebuggerDocument::getPlatformCurrentFunctionStack):
2911         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2912         (DebuggerDocument::platformValueForScopeVariableNamed):
2913
2914 2007-09-05  Kevin McCullough  <kmccullough@apple.com>
2915
2916         Reviewed by Adam, Sam, Darin.
2917
2918         - Separated what is platform dependant from what is not.  Creating the structure needed for Drosera for Win.
2919
2920         * Drosera/Debugger.h: Added.
2921         * Drosera/DebuggerDocument.cpp:
2922         (DebuggerDocument::breakpointEditorHTMLCallback):
2923         (DebuggerDocument::isPausedCallback):
2924         (DebuggerDocument::pauseCallback):
2925         (DebuggerDocument::resumeCallback):
2926         (DebuggerDocument::stepIntoCallback):
2927         (DebuggerDocument::evaluateScriptCallback):
2928         (DebuggerDocument::currentFunctionStackCallback):
2929         (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
2930         (DebuggerDocument::valueForScopeVariableNamedCallback):
2931         (DebuggerDocument::logCallback):
2932         (DebuggerDocument::breakpointEditorHTML):
2933         (DebuggerDocument::isPaused):
2934         (DebuggerDocument::pause):
2935         (DebuggerDocument::resume):
2936         (DebuggerDocument::stepInto):
2937         (DebuggerDocument::evaluateScript):
2938         (DebuggerDocument::currentFunctionStack):
2939         (DebuggerDocument::localScopeVariableNamesForCallFrame):
2940         (DebuggerDocument::valueForScopeVariableNamed):
2941         (DebuggerDocument::log):
2942         (DebuggerDocument::toolbarPause):
2943         (DebuggerDocument::toolbarResume):
2944         (DebuggerDocument::toolbarStepInto):
2945         (DebuggerDocument::toolbarStepOver):
2946         (DebuggerDocument::toolbarStepOut):
2947         (DebuggerDocument::toolbarShowConsole):
2948         (DebuggerDocument::toolbarCloseCurrentFile):
2949         (DebuggerDocument::updateFileSource):
2950         (DebuggerDocument::didParseScript):
2951         (DebuggerDocument::willExecuteStatement):
2952         (DebuggerDocument::didEnterCallFrame):
2953         (DebuggerDocument::willLeaveCallFrame):
2954         (DebuggerDocument::exceptionWasRaised):
2955         (DebuggerDocument::windowScriptObjectAvailable):
2956         (DebuggerDocument::toJSArray):
2957         (DebuggerDocument::callGlobalFunction):
2958         (DebuggerDocument::callFunctionOnObject):
2959         (DebuggerDocument::getDroseraJSClass):
2960         (DebuggerDocument::staticFunctions):
2961         (DebuggerDocument::logException):
2962         * Drosera/DebuggerDocument.h:
2963         (DebuggerDocument::DebuggerDocument):
2964         * Drosera/ForwardingHeaders: Added.
2965         * Drosera/ForwardingHeaders/wtf: Added.
2966         * Drosera/ForwardingHeaders/wtf/Platform.h: Added.
2967         * Drosera/config.h:
2968         * Drosera/console.html:
2969         * Drosera/console.js:
2970         * Drosera/debugger.js:
2971         * Drosera/mac/DebuggerApplication.mm:
2972         (-[DebuggerApplication attach:]):
2973         * Drosera/mac/DebuggerDocumentMac.h:
2974         * Drosera/mac/DebuggerDocumentMac.mm:
2975         (+[NSString stringOrNilFromWebScriptResult:]):
2976         (+[DebuggerClientMac log:]):
2977         (-[DebuggerClientMac initWithServerName:]):
2978         (-[DebuggerClientMac dealloc]):
2979         (-[DebuggerClientMac pause]):
2980         (-[DebuggerClientMac resume]):
2981         (-[DebuggerClientMac pause:]):
2982         (-[DebuggerClientMac resume:]):
2983         (-[DebuggerClientMac stepInto:]):
2984         (-[DebuggerClientMac stepOver:]):
2985         (-[DebuggerClientMac stepOut:]):
2986         (-[DebuggerClientMac showConsole:]):
2987         (-[DebuggerClientMac closeCurrentFile:]):
2988         (-[DebuggerClientMac validateUserInterfaceItem:]):
2989         (-[DebuggerClientMac webView:windowScriptObjectAvailable:]):
2990         (-[DebuggerClientMac webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
2991         (-[DebuggerClientMac webView:willExecuteStatement:sourceId:line:forWebFrame:]):
2992         (-[DebuggerClientMac webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
2993         (-[DebuggerClientMac webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
2994         (DebuggerDocument::platformPause):
2995         (DebuggerDocument::platformResume):
2996         (DebuggerDocument::platformStepInto):
2997         (DebuggerDocument::platformEvaluateScript):
2998         (DebuggerDocument::platformCurrentFunctionStack):
2999         (DebuggerDocument::platformLocalScopeVariableNamesForCallFrame):
3000         (DebuggerDocument::platformValueForScopeVariableNamed):
3001         (DebuggerDocument::platformLog):
3002         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3003
3004 2007-09-06  Sam Weinig  <sam@webkit.org>
3005
3006         Reviewed by Adam Roben.
3007
3008         Register the WebKit DLL on initialization of the DumpRenderTree.
3009
3010         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3011         (initialize):
3012
3013 2007-09-05  Sam Weinig  <sam@webkit.org>
3014
3015         Reviewed by Oliver.
3016
3017         Fix many layout test failures caused by r25364.
3018         Set text size to standand size at the begining of each test matching the mac.
3019
3020         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3021         (runTest):
3022
3023 2007-09-04  Sam Weinig  <sam@webkit.org>
3024
3025         Reviewed by Adam.
3026
3027         Fix for <rdar://problem/5382277>
3028         Implement eventSender.textZoomIn and eventSender.textZoomOut for windows DRT.
3029
3030         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp:
3031         (textZoomInCallback):
3032         (textZoomOutCallback):
3033
3034 2007-08-29  David Kilzer  <ddkilzer@apple.com>
3035
3036         Reviewed by Adam.
3037
3038         Added case-insensitivity to checks for adding regression tests.
3039
3040         * Scripts/prepare-ChangeLog:
3041         (generateFileList):
3042
3043 2007-08-28  David Kilzer  <ddkilzer@apple.com>
3044
3045         Reviewed by Maciej.
3046
3047         Ignore files in /resources/ subdirectories when creating a list of added tests.
3048
3049         * Scripts/prepare-ChangeLog:
3050         (generateFileList):
3051
3052 2007-08-27  Kevin McCullough  <kmccullough@apple.com>
3053
3054         Reviewed by John.
3055
3056         - Removed Leopard leaks list since all of those radars were fixed.
3057
3058         * Scripts/run-webkit-tests:
3059
3060 2007-08-27  Adam Roben  <aroben@apple.com>
3061
3062         Rubberstamped by Mark.
3063
3064         * Scripts/pdevenv: Pass arguments along to devenv.com.
3065
3066 2007-08-26  David Kilzer  <ddkilzer@webkit.org>
3067
3068         Reviewed by Mark Rowe.
3069
3070         Update prepare-ChangeLog to generate the datestamp in the correct timezone.
3071
3072         * Scripts/prepare-ChangeLog:
3073         (changeLogDate): Added.
3074
3075 2007-08-24  Sam Weinig  <sam@webkit.org>
3076
3077         Revert r25216 which renamed the COM DOM bindings to use Deprecated prefix.
3078
3079 2007-08-24  Sam Weinig  <sam@webkit.org>
3080
3081         Rubber-stamped by Adam Roben.
3082
3083         <rdar://problem/5434593> Deprecate current manually written COM DOM bindings in anticipation of autogeneration
3084
3085         Rename COM DOM bindings to use Deprecated prefix.
3086
3087         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3088         (dumpFramesAsText):
3089         (dump):
3090         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp:
3091         (dumpPath):
3092         (dump):
3093         (EditingDelegate::shouldBeginEditingInDOMRange):
3094         (EditingDelegate::shouldEndEditingInDOMRange):
3095         (EditingDelegate::shouldInsertNode):
3096         (EditingDelegate::shouldInsertText):
3097         (EditingDelegate::shouldDeleteDOMRange):
3098         (EditingDelegate::shouldChangeSelectedDOMRange):
3099         (EditingDelegate::shouldApplyStyle):
3100         (EditingDelegate::shouldChangeTypingStyle):
3101         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h:
3102
3103 2007-08-24  Oliver Hunt  <oliver@apple.com>
3104
3105         Reviewed by John H.
3106
3107         WebDataSource::response can legitimately have a null response, so we
3108         must check that case.
3109
3110         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp:
3111         (queueLoadCallback):
3112
3113 2007-08-23  Mitz Pettel  <mitz@webkit.org>
3114
3115         Reviewed by Darin and Adam.
3116
3117         - DumpRenderTree changes to allow testing for
3118           http://bugs.webkit.org/show_bug.cgi?id=11756
3119           REGRESSION: link targeting a frame in another window does not work
3120           <rdar://problem/5286420>
3121
3122         Use a frame group name for all WebViews created by DumpRenderTree to
3123         allow testing of cross-page frame lookup.
3124
3125         * DumpRenderTree/DumpRenderTree.m:
3126         (createWebView): Pass group name to -[WebView initWithFrame:frameName:groupName:].
3127         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3128         (main): Pass group name to WebView::initWithFrame(RECT, BSTR, BSTR).
3129
3130 2007-08-23  David Kilzer  <ddkilzer@webkit.org>
3131
3132         Reviewed by Adam.
3133
3134         Quote the $sslCertificate path in case it contains a space.
3135
3136         * Scripts/run-webkit-httpd:
3137         * Scripts/run-webkit-tests:
3138
3139 2007-08-22  Oliver Hunt  <oliver@apple.com>
3140
3141         Reviewed by John and Adam.
3142
3143         WebDataSource::response can legitimately have a null response, so we
3144         must check that case.
3145
3146         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3147         (dump):
3148
3149 2007-08-21  Kevin McCullough  <kmccullough@apple.com>
3150
3151         Reviewed by Geof.
3152
3153         - Changing the usage to be more clear.
3154
3155         * Scripts/run-testkjs:
3156
3157 2007-08-20  John Sullivan  <sullivan@apple.com>
3158
3159         Reviewed by Adam Roben
3160
3161         * DumpRenderTree/DumpRenderTree.m:
3162         (runTest):
3163         call new +[WebView _setUsesTestModeFocusRingColor:YES] so we get the same focus ring colors
3164         in layout tests on Tiger and Leopard
3165
3166 2007-08-20  Adam Roben  <aroben@apple.com>
3167
3168         Put LayoutTests after all other ChangeLogs in commit logs
3169
3170         We use "~" to sort LayoutTests after all the other ChangeLogs because
3171         "~" is the last ASCII character (other than "DEL").
3172
3173         Reviewed by Sam.
3174
3175         * Scripts/commit-log-editor:
3176
3177 2007-08-20  Adam Roben  <aroben@apple.com>
3178
3179         Detect that DRT crashed even if a crash dialog is running
3180
3181         On Windows, when DRT crashes a crash dialog commonly appears. The DRT
3182         process is still running at this point, so run-webkit-tests wouldn't
3183         detect that DRT had crashed. We now record the crash in our SIGPIPE
3184         handler so that we know if DRT crashed even if the crash dialog is up.
3185
3186         Reviewed by Sam.
3187
3188         * Scripts/run-webkit-tests:
3189         (sub catch_pipe): Set the crashed bit.
3190         (sub openDumpTool): Reset the crashed bit.
3191         (sub dumpToolDidCrash): Check the crashed bit.
3192
3193 2007-08-20  Adam Roben  <aroben@apple.com>
3194
3195         Fix Bug 15026: prepare-ChangeLog should list new tests in WebCore/ChangeLog
3196
3197         http://bugs.webkit.org/show_bug.cgi?id=15026
3198
3199         Reviewed by David Kilzer and Darin Adler.
3200
3201         * Scripts/prepare-ChangeLog:
3202         (sub isModifiedStatus): Split out from isModifiedOrAddedStatus.
3203         (sub isAddedStatus): Ditto.
3204         (sub testListForChangeLog): Added.
3205
3206 2007-08-19  Oleg Sukhodolsky  <son.two@gmail.com>
3207
3208         Reviewed by Mark.
3209
3210         -fixes http://bugs.webkit.org/show_bug.cgi?id=14632
3211
3212         * Scripts/webkitdirs.pm:
3213         qt and gtk ports now explicitly pass debug (or release) mode to qmake.
3214
3215 2007-08-17  Darin Adler  <darin@apple.com>
3216
3217         Reviewed by Oliver Hunt.
3218
3219         - don't look for Apple-style localizable strings in the GTK version of WebKit
3220
3221         * Scripts/extract-localizable-strings: Add a feature where you can pass in the
3222         name of subdirectories to skip.
3223         * Scripts/update-webkit-localizable-strings: Pass WebKit/gtk as a subdirectory
3224         to skip.
3225
3226 2007-08-17  Anders Carlsson  <andersca@apple.com>
3227
3228         Build fix.
3229
3230         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
3231         (NPP_SetWindow):
3232
3233 2007-08-17  Anders Carlsson  <andersca@apple.com>
3234
3235         Reviewed by Dave Hyatt.
3236
3237         <rdar://problem/5379040>
3238         REGRESSION (Tiger-Leopard): ADOBE: Safari calls NPP_SetWindow with bad values sometimes
3239
3240         Add a way for the plug-in to dump the width and height when it gets its  NPP_SetWindow call.
3241
3242         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
3243         (pluginAllocate):
3244         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3245         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
3246         (NPP_New):
3247         (NPP_SetWindow):
3248
3249 2007-08-16  Alice Liu  <alice.liu@apple.com>
3250
3251         Reviewed by Maciej.
3252
3253         Fix <rdar://problem/5360135> REGRESSION (Leopard only): editing/selection/5354455-1.html is causing subsequent tests to fail
3254
3255         * DumpRenderTree/DumpRenderTree.m:
3256         (createWebView):
3257         Create a DumpRenderTreeWindow instead of a NSWindow, now that a DumpRenderTreeWindow no longer poses as a NSWindow.
3258         (dumpRenderTree):
3259         Don't pose as a NSWindow, since when the spelling panel gets created, it creates an NSWindow which ends up creating a DumpRenderTreeWindow.
3260
3261 2007-08-16  Kevin McCullough  <kmccullough@apple.com>
3262
3263         Reviewed by Adam.
3264
3265         - Added tests for regressions in other components.  In this case we also need to add a skipped list for Tiger since this functionality didn't exist in 10.4.
3266
3267         * Scripts/run-webkit-tests:
3268
3269 2007-08-15  Timothy Hatcher  <timothy@apple.com>
3270
3271         Look for the new Xcode 3 preference key (PBXApplicationwideBuildSettings) for the global build locations.
3272         The value of PBXApplicationwideBuildSettings is a dictionary, so we have to pull the SYMROOT out of it.
3273
3274         Also pass xcodebuild OBJROOT with the same value as SYMROOT if we fallback to the default WebKitBuild,
3275         this prevents making "build" directories in each project folder.
3276
3277         * Scripts/webkitdirs.pm:
3278
3279 2007-08-14  Geoffrey Garen  <ggaren@apple.com>
3280
3281         Reviewed by Kevin Mccullough.
3282
3283         Removed special case that didn't belong. (It would allow a global
3284         initializer to sneak into production builds, which would cause a
3285         system-wide performance regression on Mac OS X.)
3286
3287         * Scripts/check-for-global-initializers:
3288
3289 2007-08-14  Justin Garcia  <justin.garcia@apple.com>
3290
3291         Reviewed by Tim.
3292
3293         <rdar://problem/5408255> REGRESSION: In Mail, clicking the containing element's UI closebox doesn't delete element
3294
3295         * DumpRenderTree/EditingDelegate.m:
3296         (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Added, return YES
3297         only for elements with the class needsDeletionUI.
3298
3299 2007-08-14  David Kilzer  <ddkilzer@webkit.org>
3300
3301         Reviewed by Darin.
3302
3303         - fix http://bugs.webkit.org/show_bug.cgi?id=14965
3304           svn-create-patch uses deprecated tail switch
3305
3306         * Scripts/svn-create-patch: Use 'tail -n +3' instead of 'tail +3'.
3307
3308 2007-08-13  Sam Weinig  <sam@webkit.org>
3309
3310         Reviewed by Adam Roben.
3311
3312         Use the cygwin specific Apache config file under cygwin.
3313
3314         * Scripts/run-webkit-httpd:
3315
3316 2007-08-12  Adam Roben  <aroben@apple.com>
3317
3318         Generate results for new tests in a more logical location
3319
3320         New platform-specific tests always have their results generated right
3321         next to the test. New cross-platform tests will have their results
3322         generated a) in the cross-platform directory, if they are text-only,
3323         or b) in the least-specific platform directory, if they are render
3324         tree dumps.
3325
3326         Reviewed by Lars.
3327
3328         * Scripts/run-webkit-tests:
3329
3330 2007-08-12  Adam Roben  <aroben@apple.com>
3331
3332         Print the actual directory where new results are generated.
3333
3334         Before, we were printing an unpredictable, context-specific substring
3335         of the directory.
3336
3337         Reviewed by Lars.
3338
3339         * Scripts/run-webkit-tests:
3340
3341 2007-08-12  Adam Roben  <aroben@apple.com>
3342
3343         Factor some common code into a stripExtension() subroutine.
3344
3345         Reviewed by Lars.
3346
3347         * Scripts/run-webkit-tests: Also removed some debugging output.
3348
3349 2007-08-11  Matt Lilek  <pewtermoose@gmail.com>
3350
3351         Reviewed over and over and over by Adam Roben.
3352
3353         Bug 14740: Hierarchical layout tests and platform organization
3354         http://bugs.webkit.org/show_bug.cgi?id=14740
3355
3356         Add support for platform-specific layout tests and results.
3357
3358         * Scripts/run-webkit-tests:
3359
3360 2007-08-11  David Kilzer  <ddkilzer@webkit.org>
3361
3362         Reviewed by Adam.
3363
3364         Refactored svn-create-path to use a hash-of-hashes data structure to keep
3365         track of changed files.  In the top level hash, keys are paths to files and
3366         values are 'fileData' hashes with the following keys and values:
3367
3368         - isBinary: boolean value (set to true for non-text files like images, etc.)
3369         - isTestFile: boolean value (set to true if file exists within a known test
3370           directory)
3371         - modificationType: string equal to one of 'addition', 'additionWithHistory',
3372           'modification' or 'deletion'
3373         - path: string equal to the path to the file (this may seem redundant, but it
3374           is required to use the second-level 'fileData' hash independent of the
3375           top-level hash)
3376         - sourceFile: [optional] string equal to the path of the original file that was
3377           copied or moved
3378         - sourceRevision: [optional] string equal to the revision of the original file
3379           that was copied or moved
3380
3381         * Scripts/svn-create-patch: Moved call to GetOptions() to its own statement
3382         that saves the return value in $result, then checks it before printing help.
3383         Combined sourceFiles, %testFiles, and %binaryFiles into single %diffFiles hash
3384         and eliminated two for() loops.
3385         (binarycmp): Added.  Used with sort() to order non-binary files before binary
3386         files.
3387         (findBaseUrl): Added.  Extracted from findSourceFileAndRevision().
3388         (findMimeType): Added optional second argument that takes a revision number.
3389         (generateDiff): Updated to take one fileData argument instead of three ($file,
3390         $modificationType, $isBinary).
3391         (generateFileList): Updated to take one hash ref argument (%diffFiles)
3392         instead of three (%sourceFiles, %testFiles, %binaryFiles).  Populates
3393         %diffFiles using paths for keys and fileData hashes for values.
3394         (manufacturePatchForAdditionWithHistory): Updated to take one fileData
3395         argument.
3396         (pathcmp): Updated to take two fileData arguments instead of two strings.
3397         (testfilecmp): Added.  Used with sort() to order non-test files before test
3398         files.
3399
3400 2007-08-11  Darin Adler  <darin@apple.com>
3401
3402         * Scripts/run-webkit-tests: Give a different message when only the pixel test failed.
3403
3404 2007-08-06  Nigel Tao  <nigeltao@gnome.org>
3405
3406         Reviewed by David Kilzer.
3407
3408         Fix bug 14745: WebKitTools/Scripts/run-launcher doesn't speak --gdk
3409         http://bugs.webkit.org/show_bug.cgi?id=14745
3410
3411         * Scripts/run-launcher:
3412         Scrub the "--gdk" out of the command line args, if given, so that
3413         GdkLauncher doesn't try to interpret it as a URL.
3414
3415 2007-08-03  Adam Roben  <aroben@apple.com>
3416
3417         Catch SIGPIPE on Windows so that run-webkit-tests doesn't quit when DRT crashes
3418
3419         Reviewed by Sam.
3420
3421         * Scripts/run-webkit-tests: Also close ERROR when we finish running the tests.
3422
3423 2007-08-03  Sam Weinig  <sam@webkit.org>
3424
3425         Reviewed by Darin.
3426
3427         Recursively dump all frames as text using new
3428         layoutTestController.dumpChildFramesAsText() function.
3429
3430         * DumpRenderTree/DumpRenderTree.m:
3431         (dumpFramesAsText):
3432         (dump):
3433         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
3434         (-[LayoutTestController dumpChildFramesAsText]):
3435         (runTest):
3436         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3437         (dumpFramesAsText):
3438         (dump):
3439         (runTest):
3440         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h:
3441         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp:
3442         (dumpChildFramesAsTextCallback):
3443         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3444
3445 2007-08-02  Adam Roben  <aroben@apple.com>
3446
3447         Fix fast/dom/Window/alert-undefined.html
3448
3449         Reviewed by Sam.
3450
3451         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
3452         (WaitUntilDoneDelegate::runJavaScriptAlertPanelWithMessage): Don't let
3453         Windows translate a null BSTR into "(null)"
3454
3455 2007-08-02  Kevin McCullough  <kmccullough@apple.com>
3456
3457         Reviewed by Tim.
3458
3459         - It would help if I actually called the right function.
3460
3461         * Drosera/DebuggerDocument.cpp:
3462         (DebuggerDocument::showConsole):
3463
3464 2007-08-02  Adam Roben  <aroben@apple.com>
3465
3466         Don't delete the stderr file right after creating it
3467
3468         Reviewed by NOBODY.
3469
3470         * Scripts/run-webkit-tests:
3471
3472 2007-08-01  Adam Roben  <aroben@apple.com>
3473
3474         When DRT crashes, record stderr and restart DRT
3475
3476         This prevents a DRT crash from causing the next few hundred tests to
3477         "fail" because DRT is no longer running.
3478
3479         I also changed the terminology that run-webkit-tests uses in its
3480         output a bit, so that crashing tests are referred to as "crashes"
3481         instead of "failures".
3482
3483         Reviewed by Mark.
3484
3485         * Scripts/run-webkit-tests: Detect a crash and record it as a tool
3486         failure.
3487         (sub openDumpTool): Use open3 so that we can access stderr.
3488         (sub dumpToolCrashed): Added.
3489         (sub printFailureMessageForTest): Added.
3490         (sub htmlForExpectedAndActualResults): Added.
3491         (sub deleteExpectedAndActualResults): Added.
3492         (sub recordActualResultsAndDiff): Added.
3493
3494 2007-07-30  Darin Adler  <darin@apple.com>
3495
3496         Reviewed by Tim Hatcher.
3497
3498         * DumpRenderTree/DumpRenderTree.m: (dump): Fix dumping for documents that include null
3499         characters. This turned out not to be needed for the test case that motivated me to
3500         do it, but it's nice to have this for the future.
3501
3502 2007-07-30  Simon Hausmann  <hausmann@kde.org>
3503
3504         Reviewed by Lars.
3505
3506         Link QtLauncher into $$OUTPUT_DIR/bin
3507
3508         * Scripts/run-launcher:
3509
3510 2007-07-27  David Kilzer  <ddkilzer@apple.com>
3511
3512         Reviewed by Geoff and Darin.
3513
3514         Use a subroutine for validating the --skipped switch.
3515
3516         * Scripts/run-webkit-tests:
3517
3518 2007-07-27  Darin Adler  <darin@apple.com>
3519
3520         Reviewed by Sam.
3521
3522         * Scripts/run-webkit-tests: Remove exception for leaks bug that has been fixed on Leopard.
3523
3524 2007-07-27  Holger Hans Peter Freyther  <zecke@selfish.org>
3525
3526         Reviewed by Mark.
3527
3528         Correct the path of GdkLauncher and make checkFrameworks work on OSX
3529         when building the Qt or Gtk+ port.
3530
3531         * GdkLauncher/GdkLauncher.pro: Don't create an app bundle on OSX
3532         * Scripts/run-launcher:
3533         * Scripts/webkitdirs.pm: Don't add WebKit if we build the Qt or Gtk+ port.
3534
3535 2007-07-27  Simon Hausmann  <hausmann@kde.org>
3536
3537         Done with and reviewed by Lars and Zack.
3538
3539         Fix build-webkit for the Qt build on Windows with msvc/nmake by trying to detect the Qt mkspec and using "nmake" instead of "make" as build command.
3540
3541         * Scripts/webkitdirs.pm:
3542
3543 2007-07-27  Simon Hausmann  <hausmann@kde.org>
3544
3545         Done with and reviewed by Lars and Zack.
3546
3547         For detecting the SVG support for the Qt build don't do the nm hack. Just always claim SVG support is enabled because that's what it is. The nm hack doesn't work on Windows anyway.
3548
3549         * Scripts/webkitdirs.pm:
3550