* Check to see if the directory exists and exit if not.
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-12-01  Adam Treat  <treat@kde.org>
2
3         Reviewed by Simon.
4
5         * Check to see if the directory exists and exit if not.
6
7         * DumpRenderTree/qt/main.cpp:
8         (main):
9
10 2007-12-01  Adam Treat  <treat@kde.org>
11
12         Reviewed by Simon.
13
14         * Don't hide symbols when in Debug mode
15         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
16
17
18         * DumpRenderTree/qt/main.cpp:
19         (messageHandler):
20
21 2007-11-30  Alp Toker  <alp@atoker.com>
22
23         Reviewed by Adam Roben.
24
25         http://bugs.webkit.org/show_bug.cgi?id=15691
26         [GTK] Public API does not follow GTK+ conventions
27
28         Refactor the WebKit/GTK+ public API. Changes:
29           WebKitPage -> WebKitWebView
30           WebKitFrame -> WebKitWebFrame
31
32         Public API source and header names have been updated to mirror the API
33         changes.
34
35         The API is now kept in WebKit/gtk/WebView to match other ports in the
36         same class such as Mac and Win.
37
38         * GtkLauncher/main.c:
39         (activate_uri_entry_cb):
40         (link_hover_cb):
41         (title_change_cb):
42         (progress_change_cb):
43         (go_back_cb):
44         (go_forward_cb):
45         (create_browser):
46         (main):
47
48 2007-11-30  Adam Roben  <aroben@apple.com>
49
50         Hopefully the final build fix
51
52         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
53         pull in WTF's assertion/logging functions.
54
55 2007-11-30  Adam Roben  <aroben@apple.com>
56
57         Another build fix
58
59         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
60         WebKit.lib.
61
62 2007-11-30  Adam Roben  <aroben@apple.com>
63
64         Debug build fix
65
66         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
67         configuration.
68         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
69         projects.
70         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
71         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
72         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
73
74 2007-11-30  Sam Weinig  <sam@webkit.org>
75
76         Reviewed by Adam Roben.
77
78         Fix drawSelectionRect to actually draw the selection rect.
79
80         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
81         (drawSelectionRect):
82
83 2007-11-30  Darin Adler  <darin@apple.com>
84
85         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
86
87 2007-11-30  Darin Adler  <darin@apple.com>
88
89         * Scripts/do-webcore-rename: Get ready for some future renaming.
90
91 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
92
93         Reviewed by Adam.
94
95         - Removed some unnecessary functions and changed an unused return type. 
96
97         * Drosera/win/DebuggerClient.cpp:
98         (registerConsoleClass):
99         * Drosera/win/DebuggerClient.h:
100         * Drosera/win/Drosera.cpp:
101         (registerDroseraClass):
102
103 2007-11-28  Alp Toker  <alp@atoker.com>
104
105         Reviewed by Timothy Hatcher.
106
107         http://bugs.webkit.org/show_bug.cgi?id=16174
108         [GTK] Use "URI" not "URL" in public API
109
110         Replace use of the term "URL" with "URI" in public headers,
111         documentation and some internal code to match GLib/GTK+ convention.
112
113         This is now mentioned in the API guidelines:
114           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
115
116         * GtkLauncher/main.c:
117         (activate_uri_entry_cb):
118         (title_change_cb):
119         (create_toolbar):
120         (main):
121
122 2007-11-29  Anders Carlsson  <andersca@apple.com>
123
124         Reviewed by Sam.
125
126         <rdar://problem/5230478>
127         FrameLoadDelegate callbacks are not dumped in DRT.
128         
129         * DumpRenderTree/win/DumpRenderTree.cpp:
130         (shouldLogFrameLoadDelegates):
131         (runTest):
132         (main):
133         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
134         (BSTRtoString):
135         (descriptionSuitableForTestResult):
136         (FrameLoadDelegate::QueryInterface):
137         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
138         (FrameLoadDelegate::didFailProvisionalLoadWithError):
139         (FrameLoadDelegate::didCommitLoadForFrame):
140         (FrameLoadDelegate::didFinishLoadForFrame):
141         (FrameLoadDelegate::willCloseFrame):
142         (FrameLoadDelegate::didClearWindowObject):
143         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
144         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
145         * DumpRenderTree/win/FrameLoaderDelegate.h:
146         (FrameLoadDelegate::windowScriptObjectAvailable):
147         (FrameLoadDelegate::didFirstLayoutInFrame):
148
149 2007-11-29  Sam Weinig  <sam@webkit.org>
150
151         Reviewed by Anders.
152
153         Add database quota UIDelegates methods to DRT UIDelegate.
154
155         * DumpRenderTree/mac/UIDelegate.mm:
156         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
157         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
158
159 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
160
161         Reviewed by Sam.
162
163         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
164         dying and vice versa.
165         - This fix will allow Drosera and Safari to reconnect if either of them
166         closes correctly, but does not fix the case where one of them dies
167         silently.
168
169         * Drosera/win/ServerConnection.cpp:
170         (ServerConnection::attemptToCreateServerConnection): Added a safety
171         check, because it's possilbe to try to connect to a server that's dying.
172         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
173         the server has died.
174         * Drosera/win/ServerConnection.h: Added the new function and removed
175         an unnecessary member.
176
177 2007-11-29  Anders Carlsson  <andersca@apple.com>
178
179         * DumpRenderTree/win/DumpRenderTree.vcproj:
180         Add shlwapi.lib to all configurations.
181
182 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
183
184         - Build fix.  Added additional includes for VS Express to the Release
185         project.
186
187         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
188
189 2007-11-29  Anders Carlsson  <andersca@apple.com>
190
191         Reviewed by Adam.
192
193         <rdar://problem/5132005>
194         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
195         
196         * DumpRenderTree/win/DumpRenderTree.vcproj:
197         Add shlwapi.lib
198         
199         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
200         (LayoutTestController::setUserStyleSheetEnabled):
201         Implement this.
202         
203         (appendComponentToPath):
204         New method which wraps the Win32 API PathAppend.
205         
206         (followShortcuts):
207         New method which checks if a file points to a shortcut and
208         follows the shortcut.
209         
210         (resolveCygwinPath):
211         New method that takes a cygwin unix-style path and returns the Win32 path.
212         
213         (cfStringRefToWString):
214         
215         (LayoutTestController::setUserStyleSheetLocation):
216         Implement this.
217
218 2007-11-29  Alice Liu  <alice.liu@apple.com>
219
220         Reviewed by Adam.
221
222         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
223
224         * DumpRenderTree/win/EventSender.cpp:
225         (keyDownCallback):
226         uppercase letters were being sent as lowercase letters without the shift key down.
227
228 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
229
230         - Windows build fix. VS express needs some love.
231
232         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
233
234 2007-11-28  Darin Adler  <darin@apple.com>
235
236         Reviewed by Adam Roben.
237
238         * DumpRenderTree/mac/EventSendingController.mm:
239         (-[EventSendingController keyDown:withModifiers:]):
240         Send capital letters through as lowercase letters with the shift key down
241         rather than sending them as if they were highly unusual "capital letter keys".
242
243         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
244         where you need to update results and more tests are failing than before.
245
246 2007-11-28  Anders Carlsson  <andersca@apple.com>
247
248         Reviewed by Darin.
249
250         <rdar://problem/5132001>
251         contextClick is not implemented in DRT on Windows.
252         
253         * DumpRenderTree/win/EventSender.cpp:
254         (contextClickCallback):
255         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
256         by a WM_RBUTTONUP message.
257         
258         * DumpRenderTree/win/UIDelegate.cpp:
259         (UIDelegate::hasCustomMenuImplementation):
260         (UIDelegate::trackCustomPopupMenu):
261         * DumpRenderTree/win/UIDelegate.h:
262         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
263         menu from being shown (and causing the DRT to hang).
264
265 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
266
267         Reviewed by Darin.
268
269         Fix DumpRenderTree ObjC bug comparing strings.
270
271         * DumpRenderTree/mac/ObjCController.m:
272         (-[ObjCController identityIsEqual::]): Compare strings with string
273         equality instead of identiy equality.
274
275 2007-11-27  Timothy Hatcher  <timothy@apple.com>
276
277         Reviewed by Sam.
278
279         Reset the authorAndUserStylesEnabled preference
280         back to YES for each test. Fixes the broken tests.
281
282         * DumpRenderTree/mac/DumpRenderTree.mm:
283         (resetWebViewToConsistentStateBeforeTesting):
284
285 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
286
287         Reviewed by Adam.
288
289         - Drosera now displays the console window, although it cannot currently
290         process JavaScript.
291
292         * Drosera/win/DebuggerClient.cpp: Shows the console window.
293         (registerConsoleClass): Implemented.
294         (consoleWndProc): Implemented.
295         (DebuggerClient::onSize): Implemented.
296         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
297         new window.
298         * Drosera/win/DebuggerClient.h: Added needed method and members for 
299         creating and maintaining a new window.
300         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
301         lines of code to more appropriate places.
302         (Drosera::handleCommand):
303         (Drosera::initUI):
304         (Drosera::onSize):
305         (Drosera::attach):
306
307 2007-11-27  Timothy Hatcher  <timothy@apple.com>
308
309         Reviewed by Dave Hyatt.
310
311         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
312         
313         Add support for disabling author and user styles for testing.
314
315         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
316         * DumpRenderTree/LayoutTestController.cpp:
317         (setAuthorAndUserStylesEnabledCallback):
318         (LayoutTestController::staticFunctions):
319         * DumpRenderTree/LayoutTestController.h:
320         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
321         (LayoutTestController::setAuthorAndUserStylesEnabled):
322         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
323         (LayoutTestController::setAuthorAndUserStylesEnabled):
324
325 2007-11-26  Dan Bernstein  <mitz@apple.com>
326
327         - Tiger build fix.
328
329         * DumpRenderTree/mac/Configurations/Base.xcconfig:
330
331 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
332
333         Reviewed by Maciej.
334
335         - Implemented displaying variables for Drosera on Win.
336
337         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
338         that retrieve variables to not hold onto the return value since it's
339         not returned.  Also changed to use the new signatures of the retrieval
340         functions.
341         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
342         (DebuggerDocument::platformValueForScopeVariableNamed):
343         * Drosera/win/Drosera.cpp: Removed a needless TODO.
344         (droseraWndProc):
345
346 2007-11-26  Sam Weinig  <sam@webkit.org>
347
348         Cleanup names of painting and repainting functions.
349
350         Reviewed by Adam Roben.
351
352         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
353         (drawSelectionRect): was drawSelectionRectIntoContext.
354         (dumpWebViewAsPixelsAndCompareWithExpected):
355         * DumpRenderTree/cg/PixelDumpSupportCG.h:
356         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
357         (paintWebView): was drawWebViewIntoContext.
358         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
359
360 2007-11-26  Sam Weinig  <sam@webkit.org>
361
362         Reviewed by Dan Bernstein.
363
364         - Leopard build fix
365
366         * DumpRenderTree/mac/Configurations/Base.xcconfig:
367
368 2007-11-26  Sam Weinig  <sam@webkit.org>
369
370         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
371         Use shared PixelDumpSupport for Mac DRT
372
373         Reviewed by Adam Roben.
374
375         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
376         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
377         * DumpRenderTree/cg/ImageDiffCG.cpp:
378         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
379         (drawSelectionRectIntoContext):
380         (dumpWebViewAsPixelsAndCompareWithExpected):
381         * DumpRenderTree/cg/PixelDumpSupportCG.h:
382         * DumpRenderTree/mac/Configurations/Base.xcconfig:
383         * DumpRenderTree/mac/DumpRenderTree.mm:
384         (dump):
385         * DumpRenderTree/mac/ImageDiff.m: Removed.
386         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
387         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
388         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
389         (setDefaultColorProfileToRGB):
390         (getBitmapContextFromWebView):
391         (drawWebViewIntoContext):
392         (repaintWithVerticalSweep):
393         (repaintWithHorizontalSweep):
394         (getSelectionRect):
395         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
396
397 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
398
399         Bug 16052: prepare-ChangeLog doesn't report deleted files
400         <http://bugs.webkit.org/show_bug.cgi?id=16052>
401
402         Reviewed by Sam.
403
404         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
405
406 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
407
408         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
409         <http://bugs.webkit.org/show_bug.cgi?id=15864>
410
411         Reviewed by Adam.
412
413         Roll functionality of merge-changelog into resolve-ChangeLogs
414         script.  The script now checks for ChangeLog.rej and
415         ChangeLog.orig files first.  If it finds them, it uses the
416         ChangeLog.rej file as a patch (in old contextual diff format) to
417         apply with --fuzz=3.
418
419         * Scripts/merge-changelog: Removed.
420         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
421
422 2007-11-25  Sam Weinig  <sam@webkit.org>
423
424         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
425
426         Reviewed by Mark Rowe.
427
428         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
429         * DumpRenderTree/mac/Configurations/Base.xcconfig:
430         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
431         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
432         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
433
434 2007-11-25  Sam Weinig  <sam@webkit.org>
435
436         Convert DumpRenderTree to ues .xcconfig files.
437
438         Reviewed by Mark Rowe.
439
440         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
441         * DumpRenderTree/mac/Configurations: Added.
442         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
443         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
444         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
445
446 2007-11-25  Sam Weinig  <sam@webkit.org>
447
448         Add ForwardingHeaders to wtf for DumpRenderTree.
449
450         Reviewed by Mark Rowe.
451
452         * DumpRenderTree/DumpRenderTree.h:
453         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
454         * DumpRenderTree/ForwardingHeaders: Added.
455         * DumpRenderTree/ForwardingHeaders/wtf: Added.
456         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
457         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
458         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
459         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
460         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
461         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
462         * DumpRenderTree/LayoutTestController.cpp:
463         * DumpRenderTree/WorkQueue.cpp:
464         * DumpRenderTree/mac/DumpRenderTree.mm:
465         * DumpRenderTree/mac/FrameLoadDelegate.mm:
466         * DumpRenderTree/mac/JavaScriptThreading.cpp:
467         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
468         * DumpRenderTree/mac/ObjCController.m:
469         * DumpRenderTree/mac/UIDelegate.mm:
470         * DumpRenderTree/mac/WorkQueueItemMac.mm:
471
472 2007-11-25  Adam Roben  <aroben@apple.com>
473
474         Fix some test failures caused by r28019
475
476         Now that stdout is in binary mode, we need to always use printf
477         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
478         the output.
479
480         Reviewed by Sam.
481
482         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
483         printf.
484         (UIDelegate::runJavaScriptAlertPanelWithMessage):
485         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
486         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
487         (UIDelegate::webViewAddMessageToConsole):
488
489 2007-11-25  Adam Roben  <aroben@apple.com>
490
491         Set the font smoothing preference in DRT
492
493         This makes the pixel results on Windows closer to the Mac results.
494
495         Reviewed by Mitz.
496
497         * DumpRenderTree/win/DumpRenderTree.cpp:
498         (initializePreferences):
499
500 2007-11-25  Adam Roben  <aroben@apple.com>
501
502         Port ImageDiff to CG and C++
503
504         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
505         <rdar://5071708>
506
507         Reviewed by Sam.
508
509         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
510         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
511         (main):
512         (createImageFromStdin):
513         (compareImages):
514         (getDifferenceBitmap):
515         (computePercentageDifferent):
516         * DumpRenderTree/win/ImageDiff.vcproj: Added.
517
518 2007-11-25  Adam Roben  <aroben@apple.com>
519
520         Fix image diff link generation on Windows
521
522         Reviewed by Sam.
523
524         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
525         to toURL.
526
527 2007-11-25  Adam Roben  <aroben@apple.com>
528
529         Implement pixel dumping in Windows DRT
530
531         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
532         <rdar://5071708>
533
534         Reviewed by Sam.
535
536         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
537         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
538         Content-Length header.
539         (getMD5HashStringForBitmap):
540         (dumpWebViewAsPixelsAndCompareWithExpected):
541         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
542         * DumpRenderTree/win/DumpRenderTree.cpp:
543         (dump): Do a pixel dump if requested.
544         (main): Parse pixel test options.
545         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
546         the cg/ subdirectory to the include path.
547         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
548         available in a header or import library, so we have to go through this
549         LoadLibrary/GetProcAddress dance to use them.
550         (cryptDLL):
551         (init):
552         (update):
553         (final):
554         (MD5_Init):
555         (MD5_Update):
556         (MD5_Final):
557         * DumpRenderTree/win/MD5.h: Added.
558         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
559         moved up to the top level to share it with Mac eventually.
560         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
561         (getBitmapContextFromWebView): Forces the WebView to paint using a
562         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
563
564 2007-11-25  Adam Roben  <aroben@apple.com>
565
566         Clean up Windows DRT's option parsing a little bit
567
568         Reviewed by Sam.
569
570         * DumpRenderTree/win/DumpRenderTree.cpp:
571         (main): Put non-option arguments into a Vector.
572
573 2007-11-25  Adam Roben  <aroben@apple.com>
574
575         Make Windows DRT stop changing LF into CRLF
576
577         Reviewed by Sam.
578
579         * DumpRenderTree/win/DumpRenderTree.cpp:
580         (main): Put stdout in binary mode.
581         * Scripts/run-webkit-tests: Remove the CRLF hack.
582
583 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
584
585         Removed empty directory.
586
587         * Scripts/resources: Removed.
588
589 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
590
591         Fix bisect-builds to work with recent WebKit nightly builds.
592
593         Reviewed by Dan.
594
595         * Scripts/bisect-builds: Check for the 
596         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
597         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
598         to WebKit.app/Contents/Resources.
599
600 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
601
602         Reviewed by Maciej.
603
604         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
605         not closed (affects digg.com)
606
607         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
608         one after finishing with a test to avoid having its delayed onload handler firing when
609         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
610         but it helps somewhat.
611
612 2007-11-22  Mark Rowe  <mrowe@apple.com>
613
614         Reviewed by Alp Toker.
615
616         Fix build-webkit to propagate make's exit status if it fails.
617
618         * Scripts/webkitdirs.pm:
619
620 2007-11-22  Dan Bernstein  <mitz@apple.com>
621
622         Reviewed by Mark Rowe.
623
624         - fix crash when running pixel tests
625
626         * DumpRenderTree/mac/DumpRenderTree.mm:
627         (dumpRenderTree): Parse the command line options before setting up the
628         environment so that we know if we need to set up the pixel dump
629         machinery.
630
631 2007-11-21  Eric Seidel  <eric@webkit.org>
632
633         Speculative build fix for Tiger.
634
635         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
636
637 2007-11-21  Eric Seidel  <eric@webkit.org>
638
639         Reviewed by Tim Hatcher.
640
641         Break out more of DumpRenderTree.mm into individual files
642
643         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
644         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
645         (checkedMalloc):
646         (checkedRealloc):
647         (makeLargeMallocFailSilently):
648         * DumpRenderTree/mac/CheckedMalloc.h: Added.
649         * DumpRenderTree/mac/DumpRenderTree.mm:
650         (crashHandler):
651         (dump):
652         * DumpRenderTree/mac/DumpRenderTreeMac.h:
653         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
654         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
655         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
656         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
657         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
658         (javaScriptThreads):
659         (runJavaScriptThread):
660         (startJavaScriptThreads):
661         (stopJavaScriptThreads):
662         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
663         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
664         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
665         (restoreColorSpace):
666         (setDefaultColorProfileToRGB):
667         (initializeColorSpaceAndScreeBufferForPixelTests):
668         (md5HashStringForBitmap):
669         (dumpWebViewAsPixelsAndCompareWithExpected):
670
671 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
672
673         Move install-unix-extras to wx directory as it seems only to be used by that 
674         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
675         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
676         have install-unix-extras install into WebKitLibraries as per
677         convention.
678         
679         Reviewed by Mark Rowe.
680
681         * Scripts/install-unix-extras: Removed.
682         * wx/build-wxwebkit:
683         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
684
685 2007-11-21  Eric Seidel  <eric@webkit.org>
686
687         Reviewed by Adam.
688
689         More refactoring for greater code readability
690
691         * DumpRenderTree/mac/DumpRenderTree.mm:
692         (initializeGlobalsFromCommandLineOptions):
693         (initializeColorSpaceAndScreeBufferForPixelTests):
694         (addTestPluginsToPluginSearchPath):
695         (useLongRunningServerMode):
696         (runTestingServerLoop):
697         (prepareConsistentTestingEnvironment):
698         (dumpRenderTree):
699         (main):
700         (dumpFramesAsText):
701         (dumpBackForwardListForWebView):
702         (sizeWebViewForCurrentTest):
703         (methodNameStringForFailedTest):
704         (dumpBackForwardListForAllWindows):
705         (dumpWebViewAsPixelsAndCompareWithExpected):
706         (invalidateAnyPreviousWaitToDumpWatchdog):
707         (dump):
708         * DumpRenderTree/mac/DumpRenderTreeMac.h:
709         * DumpRenderTree/mac/UIDelegate.mm:
710         (-[UIDelegate webView:createWebViewWithRequest:]):
711
712 2007-11-21  Eric Seidel  <eric@webkit.org>
713
714         Reviewed by Tim Hatcher.
715
716         Abstract more of DRT into static methods
717
718         * DumpRenderTree/mac/DumpRenderTree.mm:
719         (setDefaultsToConsistentValuesForTesting):
720         (setupSignalHandlers):
721         (allocateGlobalControllers):
722         (releaseAndZero):
723         (releaseGlobalControllers):
724         (dumpRenderTree):
725         (shouldLogFrameLoadDelegates):
726         (createCFURLFromPathOrURL):
727         (resetWebViewToConsistentStateBeforeTesting):
728         (runTest):
729
730 2007-11-21  Eric Seidel  <eric@webkit.org>
731
732         Reviewed by Tim Hatcher.
733
734         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
735
736         * DumpRenderTree/DumpRenderTree.h:
737         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
738         * DumpRenderTree/mac/DumpRenderTree.mm:
739         (dumpRenderTree):
740         (dump):
741         (runTest):
742         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
743         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
744         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
745         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
746         (-[DumpRenderTreePasteboard declareType:owner:]):
747         (+[LocalPasteboard alloc]):
748         (-[LocalPasteboard init]):
749         (-[LocalPasteboard dealloc]):
750         (-[LocalPasteboard name]):
751         (-[LocalPasteboard releaseGlobally]):
752         (-[LocalPasteboard declareTypes:owner:]):
753         (-[LocalPasteboard addTypes:owner:]):
754         (-[LocalPasteboard changeCount]):
755         (-[LocalPasteboard types]):
756         (-[LocalPasteboard availableTypeFromArray:]):
757         (-[LocalPasteboard setData:forType:]):
758         (-[LocalPasteboard dataForType:]):
759         (-[LocalPasteboard setPropertyList:forType:]):
760         (-[LocalPasteboard setString:forType:]):
761         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
762         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
763         (+[DumpRenderTreeWindow allWindows]):
764         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
765         (-[DumpRenderTreeWindow dealloc]):
766         (-[DumpRenderTreeWindow isKeyWindow]):
767         (-[DumpRenderTreeWindow keyDown:]):
768
769 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
770
771         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
772         it indiscriminately copies any headers inside JavaScriptCore,
773         which includes Tiger ICU headers. 
774
775         * wx/build-wxwebkit:
776         Don't run WebCore/move-js-headers.sh any longer.
777
778 2007-11-20  Adam Treat  <treat@kde.org>
779
780         Reviewed by David Kilzer.
781
782         * Prepend git branch name to $baseProductDir
783
784         * Scripts/VCSUtils.pm:
785         * Scripts/webkitdirs.pm:
786
787 2007-11-20  Mark Rowe  <mrowe@apple.com>
788
789         Reviewed by Simon Hausmann.
790
791         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
792         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
793         Have it trigger a "make distclean" rather than "make clean" to ensure that the
794         built product and generated Makefile's are removed.
795
796 2007-11-19  Alp Toker  <alp@atoker.com>
797
798         Reviewed by Mark Rowe.
799
800         http://bugs.webkit.org/show_bug.cgi?id=16040
801         [GTK] GtkLauncher should be written in C
802
803         Port GtkLauncher to plain C.
804
805         Use a more conventional GTK+ coding style.
806
807         Use a toolbar instead of menus.
808
809         Various signature fixes and cleanups.
810
811         Add a license header. Assume all previous modifications were copyright
812         assigned to Apple Inc. by default.
813
814         * GtkLauncher/GtkLauncher.pro:
815         * GtkLauncher/main.c: Added.
816         (activate_url_entry_cb):
817         (update_title):
818         (link_hover_cb):
819         (title_change_cb):
820         (progress_change_cb):
821         (destroy_cb):
822         (go_back_cb):
823         (go_forward_cb):
824         (create_browser):
825         (create_statusbar):
826         (create_toolbar):
827         (create_window):
828         (main):
829         * GtkLauncher/main.cpp: Removed.
830
831 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
832
833         Build script fixes to ensure they do the right thing for the 
834         wx port, and update build-wxwebkit to reflect the way the
835         build scripts now work.
836
837         Reviewed by Adam.
838
839         * Scripts/build-testkjs:
840         * Scripts/build-webkit:
841         * Scripts/run-javascriptcore-tests:
842         * Scripts/webkitdirs.pm:
843         * wx/build-wxwebkit:
844
845 2007-11-18  Eric Seidel  <eric@webkit.org>
846
847         Reviewed by Anders.
848
849         Make run-javascriptcore-tests report failures on exit (to support git bisect)
850
851         * Scripts/run-javascriptcore-tests:
852
853 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
854
855         Reviewed by Adam Roben.
856
857         Make run-webkit-tests work with Windows debug build.
858
859         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
860         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
861         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
862         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
863         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
864
865 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
866
867         Add wxWebKit sample and build script, and integrate it with 
868         build-webkit. Also make build-webkit --clean work for all
869         ports.
870
871         Reviewed by Darin Adler.
872
873         * Scripts/build-webkit:
874         * Scripts/webkitdirs.pm:
875         * wx: Added.
876         * wx/browser: Added.
877         * wx/browser/browser.bkl: Added.
878         * wx/browser/browser.cpp: Added.
879         * wx/build-wxwebkit: Added.
880
881 2007-11-17  Adam Roben  <aroben@apple.com>
882
883         Make it easy to run Safari in the debugger on Windows
884
885         I've added a new script, debug-safari, which launches Safari in the
886         debugger. On OS X it just calls gdb-safari.
887
888         Reviewed by Mark Rowe.
889
890         * FindSafari/FindSafari.cpp:
891         (_tmain): Added a /debugger flag, which in combination with
892         /printSafariLauncher will print a script that launches Safari in the
893         debugger.
894         * Scripts/debug-safari: Added.
895         * Scripts/run-safari: Changed to call runSafari().
896         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
897         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
898         first argument along to FindSafari.
899         * Scripts/webkitdirs.pm:
900         (sub runSafari): Added.
901
902 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
903
904         Reviewed by Adam Roben.
905
906         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
907
908 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
909
910         Reviewed by David Kilzer.
911
912         The git config command was renamed to repo-config at some point. This
913         change tries git config and then git repo-config if the first fails.
914
915         * Scripts/prepare-ChangeLog:
916         (gitConfig):
917
918 2007-11-16  Dan Bernstein  <mitz@apple.com>
919
920         Reviewed by Darin Adler and Sam Weinig.
921
922         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
923
924         * DumpRenderTree/win/EventSender.cpp:
925         (keyDownCallback): For characters that cannot be entered on the active
926         keyboard layout, send a WM_CHAR message with the character along with
927         a WM_KEYDOWN message with a virtual key code of 255.
928
929 2007-11-16  Mark Rowe  <mrowe@apple.com>
930
931         Reviewed by Tim Hatcher.
932
933         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
934
935         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
936         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
937
938 2007-11-15  Adam Roben  <aroben@apple.com>
939
940         Make run-safari actually work on Windows
941
942         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
943         chdir call.
944
945 2007-11-14  Adam Roben  <aroben@apple.com>
946
947         Updates to Safari launching now that 3.0.4 is released
948
949         Reviewed by Sam.
950
951         * FindSafari/FindSafari.cpp:
952         (getWebViewCLSID): Use version-independent ProgID.
953         * Scripts/run-safari: Use run-webkit-nightly.cmd.
954
955 2007-11-14  Anders Carlsson  <andersca@apple.com>
956
957         Reviewed by Adam.
958
959         <rdar://problem/5309081>
960         In DRT, "plugin.logDestroy = true" not working on Windows.
961         
962         * DumpRenderTree/win/TestNetscapePlugin/main.c:
963         (NPP_Destroy):
964
965 2007-11-14  Eric Seidel  <eric@webkit.org>
966
967         Reviewed by Sam.
968
969         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
970
971 2007-11-14  Anders Carlsson  <andersca@apple.com>
972
973         Reviewed by Adam.
974
975         <rdar://problem/5141186>
976         window.layoutTestController.setWindowIsKey is not implemented in DRT.
977         
978         Implement setWindowIsKey.
979         
980         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
981         (LayoutTestController::setWindowIsKey):
982
983 2007-11-13  Sam Weinig  <sam@webkit.org>
984
985         Reviewed by Adam Roben.
986
987         Fix for <rdar://problem/5382579>
988         http/tests/security/cross-frame-access-put.html reports large 
989         negative numbers for screenLeft and screenTop (Mac reports "0")
990
991         * DumpRenderTree/win/UIDelegate.cpp:
992         (UIDelegate::UIDelegate): Initialize the RECT.
993         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
994         (UIDelegate::webViewFrame): ditto.
995         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
996
997 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
998
999         Reviewed by Adam.
1000
1001         - Make Drosera show source, source URLs, and function stack on Windows,
1002         and some minor fixes.
1003
1004         * Drosera/DebuggerDocument.cpp: Force source to always update display.
1005         (DebuggerDocument::updateFileSource):
1006         * Drosera/debugger.js: Force source to always update display.
1007         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
1008         menu controls.
1009         (DebuggerClient::resume):
1010         (DebuggerClient::pause):
1011         (DebuggerClient::stepInto):
1012         (DebuggerClient::stepOver):
1013         (DebuggerClient::stepOut):
1014         (DebuggerClient::showConsole):
1015         (DebuggerClient::closeCurrentFile):
1016         * Drosera/win/DebuggerClient.h: Ditto.
1017         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
1018         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
1019         removed two bugs.  1) caller could be in a bad state when asked to
1020         assign into it. 2) BSTRs were not created correctly.
1021         (DebuggerDocument::getPlatformCurrentFunctionStack):
1022         * Drosera/win/Drosera.cpp: Hook up the menu controls.
1023         (droseraWndProc):
1024         (handleCommand):
1025         (Drosera::resume):
1026         (Drosera::pause):
1027         (Drosera::stepInto):
1028         (Drosera::stepOver):
1029         (Drosera::stepOut):
1030         (Drosera::showConsole):
1031         (Drosera::closeCurrentFile):
1032         * Drosera/win/Drosera.h: Hook up the menu controls.
1033         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
1034         functions, added a null check, and fixed another bug where caller could
1035         be in a bad state when asked to assign into it.
1036         (ServerConnection::didLoadMainResourceForDataSource):
1037         (ServerConnection::getCallerFrame):
1038         * Drosera/win/ServerConnection.h: Safety first.
1039
1040 2007-11-13  Dan Bernstein  <mitz@apple.com>
1041
1042         Reviewed by Darin Adler.
1043
1044         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
1045           DumpRenderTree --pixel-tests renders each test twice
1046
1047         * DumpRenderTree/mac/DumpRenderTree.mm:
1048         (dumpRenderTree): Removed the --paint option because the painting code
1049         is always exercised as a result of
1050         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
1051         calling -displayIfNeeded.
1052         (dump): Changed to always grab the image from the window since the view
1053         is always displayed.
1054         (runTest):
1055         (displayWebView):
1056         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
1057         because it always paints.
1058
1059 2007-11-12  Antti Koivisto  <antti@apple.com>
1060
1061         Reviewed by Adele.
1062         
1063         Add support for http media tests
1064
1065         * Scripts/run-webkit-tests:
1066
1067 2007-11-12  Sam Weinig  <sam@webkit.org>
1068
1069         Reviewed by Adam Roben.
1070
1071         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
1072
1073         * DumpRenderTree/win/DumpRenderTree.cpp:
1074         (runTest):
1075         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1076         (LayoutTestController::setPrivateBrowsingEnabled):
1077
1078 2007-11-12  Adam Roben  <aroben@apple.com>
1079
1080         * Scripts/update-webkit-localizable-strings: Changed to only scan the
1081         mac and win subdirectories.
1082
1083 2007-11-11  Adam Roben  <aroben@apple.com>
1084
1085         Fix <rdar://5133816> keepWebHistory is not implemented
1086
1087         Fixes fast/history/clicked-link-is-visited.html.
1088
1089         Reviewed by Darin.
1090
1091         * DumpRenderTree/win/DumpRenderTree.cpp:
1092         (runTest): Clear the optionalSharedHistory.
1093         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1094         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
1095
1096 2007-11-10  Sam Weinig  <sam@webkit.org>
1097
1098         Reviewed by Tim Hatcher.
1099
1100         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
1101         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
1102         is turned on)
1103
1104         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
1105
1106         Added test: http/tests/security/cross-frame-access-private-browsing.html
1107
1108         * DumpRenderTree/LayoutTestController.cpp:
1109         (setPrivateBrowsingEnabledCallback):
1110         (LayoutTestController::staticFunctions):
1111         * DumpRenderTree/LayoutTestController.h:
1112         * DumpRenderTree/mac/DumpRenderTree.mm:
1113         (runTest): Default to private browsing disabled.
1114         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1115         (LayoutTestController::setPrivateBrowsingEnabled):
1116         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1117         (LayoutTestController::setPrivateBrowsingEnabled):
1118
1119 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1120
1121         Reviewed by Adam.
1122
1123         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
1124         WebCore's!
1125
1126         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
1127         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
1128         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
1129         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
1130         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
1131         * Drosera/win/Drosera.cpp:
1132         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1133
1134 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1135
1136         Reviewed by Sam.
1137
1138         - Use the new IWebFrame [local] function signature and get the shared
1139         server correctly.
1140
1141         * Drosera/win/DebuggerClient.cpp:
1142         (DebuggerClient::didFinishLoadForFrame):
1143         * Drosera/win/ServerConnection.cpp:
1144         (ServerConnection::attemptToCreateServerConnection):
1145
1146 2007-11-07  Dan Bernstein  <mitz@apple.com>
1147
1148         Reviewed by Darin Adler.
1149
1150         - add an option to run-webkit-tests to ignore pixel test failures where
1151           all pixels differ by no more than a specified threshold
1152
1153         * DumpRenderTree/mac/ImageDiff.m:
1154         (main):
1155         (compareImages):
1156         (computePercentageDifferent):
1157         * Scripts/run-webkit-tests:
1158
1159 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1160
1161         Reviewed by Lars.
1162
1163         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
1164
1165         * DumpRenderTree/qt/DumpRenderTree.cpp:
1166
1167 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1168
1169         Reviewed by Lars.
1170
1171         Reworked the QWebSettings API.
1172         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
1173
1174         * DumpRenderTree/qt/DumpRenderTree.cpp:
1175
1176 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1177
1178         Reviewed by Lars.
1179
1180         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
1181
1182         * DumpRenderTree/qt/jsobjects.cpp:
1183
1184 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1185
1186         Reviewed by Lars Knoll <lars@trolltech.com>.
1187
1188         Add a QWebPage::frameCreated() signal and fix DRT
1189         
1190         The removal of createFrame in QWebPage broke the re-implementation
1191         in DumpRenderTree. Instead emit a frameCreated() signal and
1192         connect to it in DumpRenderTree.
1193         
1194
1195         * DumpRenderTree/qt/DumpRenderTree.cpp:
1196         (WebCore::WebPage::WebPage):
1197         (WebCore::DumpRenderTree::dump):
1198         (WebCore::DumpRenderTree::connectFrame):
1199         * DumpRenderTree/qt/DumpRenderTree.h:
1200
1201 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1202
1203         Reviewed by Lars Knoll <lars@trolltech.com>.
1204
1205         Moved all the event handlers from QWebFrame into QWebPage.
1206         
1207         This cleans up the public API and allows us to remove the
1208         HackWebFrame hack in DumpRenderTree.
1209         
1210
1211         * DumpRenderTree/qt/jsobjects.cpp:
1212         (EventSender::mouseDown):
1213         (EventSender::mouseUp):
1214         (EventSender::mouseMoveTo):
1215
1216 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1217
1218         Reviewed by Mark.
1219
1220         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
1221         to prevent the default implementation from popping up messageboxes.
1222
1223         * DumpRenderTree/qt/DumpRenderTree.cpp:
1224         (WebCore::WebPage::javaScriptConfirm):
1225         (WebCore::WebPage::javaScriptPrompt):
1226
1227 2007-11-06  Eric Seidel  <eric@webkit.org>
1228
1229         * Scripts/build-testkjs: build fix... too many $$
1230
1231 2007-11-06  Eric Seidel  <eric@webkit.org>
1232
1233         Reviewed by Mark Rowe.
1234
1235         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
1236
1237 2007-11-05  Adam Roben  <aroben@apple.com>
1238
1239         Add support on Windows for WEBKIT_TESTFONTS
1240
1241         This environment variable lets you specify where the fonts to be used
1242         by DumpRenderTree reside. The Qt port is already using this, so I'm
1243         just following their lead.
1244
1245         Reviewed by Darin.
1246
1247         * DumpRenderTree/win/DumpRenderTree.cpp:
1248         (exePath): Refactored code out of initialize().
1249         (fontsPath): Returns either $WEBKIT_TESTFONTS or
1250         DumpRenderTree.resources.
1251         (initialize): Use the new fontsPath function.
1252         (main): Use the new exePath function.
1253         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
1254         variable to DRT, like Qt does.
1255
1256 2007-11-05  Mark Rowe  <mrowe@apple.com>
1257
1258         Rubber-stamped by Alp Toker.
1259
1260         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
1261
1262         * GtkLauncher/main.cpp:
1263         (goToURLBarText):
1264         (main):
1265
1266 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
1267
1268         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
1269         <http://bugs.webkit.org/show_bug.cgi?id=15830>
1270
1271         Reviewed by Timothy.
1272
1273         Restrict the range of nightly builds used by the bisect-builds script
1274         based on the version of Safari and the version of Mac OS X being used.
1275
1276         Mac OS X 10.4: Safari 2.0: r11976 or newer
1277         Mac OS X 10.4: Safari 3.0: r19992 or newer
1278
1279         Mac OS X 10.5: Safari 2.0: r19594 or newer
1280         Mac OS X 10.5: Safari 3.0: r25124 or newer
1281
1282         * Scripts/bisect-builds:
1283         (findMacOSXVersion): Added.
1284         (makeNightlyList): Added argument to provide version of Mac OS X.
1285         Restrict range of nightly builds based on Safari and Mac OS X versions.
1286
1287 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
1288
1289         Reviewed by Maciej.
1290
1291         - This patch involves several changes, all of them were noticed that
1292         they were needed by the work being done in WebKit to get Drosera and
1293         WebKit working together on Windows.
1294         - The changes are:
1295         1) Added a debugger console for output messages.
1296         2) Drosera now listens for the WebKit server (before, the server would
1297         have to be running before Drosera was started.)
1298         3) Fixed a bug where the WebView started out as 0x0 pixels.
1299         4) Fixed a bug when there is no scope.
1300         5) Added the HTML, JS, and CSS to the project file to make them easy to
1301         find.
1302         6) Made the ServerConnection functions virtual.
1303
1304         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
1305         for the WebKit server.
1306         (DebuggerClient::DebuggerClient):
1307         (DebuggerClient::~DebuggerClient):
1308         (DebuggerClient::didFinishLoadForFrame):
1309         (DebuggerClient::serverConnected):
1310         (DebuggerClient::attemptToCreateServerConnection):
1311         * Drosera/win/DebuggerClient.h: Ditto.
1312         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
1313         scope.
1314         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1315         (DebuggerDocument::platformValueForScopeVariableNamed):
1316         * Drosera/win/Drosera.cpp:
1317         (_tWinMain): Added a console in debug for output messages.
1318         (Drosera::Drosera): Listen for server.
1319         (Drosera::initUI): The server now Initializes COM.
1320         (Drosera::serverConnected): Part of the listening for the server.
1321         (Drosera::attemptToCreateServerConnection): Ditto.
1322         * Drosera/win/Drosera.h: New interface for listening for the server.
1323         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
1324         files to the VS project.
1325         * Drosera/win/ServerConnection.cpp: Part of listening for the server
1326         connection.
1327         (ServerConnection::ServerConnection):
1328         (ServerConnection::attemptToCreateServerConnection):
1329         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
1330         methods.
1331         (ServerConnection::serverConnected):
1332
1333 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
1334
1335         Reviewed by Maciej.
1336
1337         http://bugs.webkit.org/show_bug.cgi?id=15832
1338         fast/dom/gc-10.html crashes when run alone
1339
1340         Check for !done before using objects that can be already deallocated.
1341
1342         * DumpRenderTree/mac/EditingDelegate.mm:
1343         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
1344         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
1345         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
1346         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
1347         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
1348         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1349         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
1350         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
1351         (-[EditingDelegate webViewDidBeginEditing:]):
1352         (-[EditingDelegate webViewDidChange:]):
1353         (-[EditingDelegate webViewDidEndEditing:]):
1354         (-[EditingDelegate webViewDidChangeTypingStyle:]):
1355         (-[EditingDelegate webViewDidChangeSelection:]):
1356         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1357         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1358         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
1359         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1360         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
1361         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
1362         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
1363         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
1364         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
1365         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
1366         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
1367         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
1368         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
1369         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
1370         (-[FrameLoadDelegate webView:willCloseFrame:]):
1371         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
1372         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
1373         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1374         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1375         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1376         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
1377         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
1378         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
1379         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
1380
1381 2007-11-04  Mark Rowe  <mrowe@apple.com>
1382
1383         Build fix.  Don't use Carbon.h as the prefix header as it triggers
1384         warnings that would otherwise be suppressed due to it being a system header.
1385
1386         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1387
1388 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
1389
1390         Rubber stamped by Adam.
1391         
1392         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
1393
1394         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1395
1396 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1397
1398         Sort files(...); sections of Xcode project files.
1399
1400         Rubber-stamped by Darin.
1401
1402         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
1403         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1404         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1405         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1406
1407 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1408
1409         Script to sort "files(...);" sections in Xcode project.pbxproj files.
1410
1411         Reviewed by Darin.
1412
1413         * Scripts/sort-Xcode-project-file: Added.
1414
1415 2007-11-02  Darin Adler  <darin@apple.com>
1416
1417         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
1418
1419 2007-11-02  Darin Adler  <darin@apple.com>
1420
1421         Reviewed by Maciej.
1422
1423         * Scripts/run-sunspider: Pass the "--base" option through.
1424
1425         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
1426         the real script do that. Default configuration to Release to match run-sunspider
1427         so we don't end up building Debug just to compare results.
1428
1429 2007-11-01  Adam Roben  <aroben@apple.com>
1430
1431         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
1432
1433         Reviewed by Sam.
1434
1435         * Scripts/commit-log-editor: Show all the directories beneath the
1436         source root, instead of just the last one.
1437
1438 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
1439
1440         Reviewed by Adam Roben.
1441
1442         Print out an error message when the Windows build fails
1443         and provide guidance on how to find out what went wrong.
1444
1445         * Scripts/build-webkit:
1446         * Scripts/webkitdirs.pm:
1447
1448 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
1449
1450         Rubber-stamped by Adam Roben.
1451
1452         Rolled out r27326 - debug CRT seems to cause no problems after all.
1453
1454         * DumpRenderTree/win/DumpRenderTree.vcproj:
1455
1456 2007-10-31  Adam Roben  <aroben@apple.com>
1457
1458         Switch the Debug configuration to using the non-debug CRT
1459
1460         This matches WebKit.
1461
1462         Reviewed by Steve.
1463
1464         * DumpRenderTree/win/DumpRenderTree.vcproj:
1465
1466 2007-10-31  Antti Koivisto  <antti@apple.com>
1467
1468         Reviewed by bdash.
1469         
1470         Disable media tests when doing leak checking on Tiger.
1471         They crash in QuickTime (rdar://problem/5537157).
1472
1473         * Scripts/run-webkit-tests:
1474
1475 2007-10-29  Antti Koivisto  <antti@apple.com>
1476
1477         Reviewed by Maciej.
1478         
1479         Build media support by default on OSX only.
1480
1481         * Scripts/build-webkit:
1482
1483 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1484
1485         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
1486         get caught by the pre-commit hooks.
1487
1488 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1489
1490         Reviewed by Adam.
1491
1492         - This is a collection of relatively unrelated changes and cleanups
1493         to Drosera to prepare it for interacting with WebKit.  A lot of these
1494         changes are just correcting mistakes, for example removing included
1495         headers that are no longer needed.
1496
1497         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
1498         this will be needed by the DebuggerClient.
1499         (DebuggerDocument::server):
1500         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
1501         * Drosera/win/DebuggerClient.cpp: 
1502         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
1503         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
1504         (DebuggerClient::createWebViewWithRequest): Added comment about its
1505         purpose. 
1506         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
1507         declarations.
1508         (DebuggerClient::webViewLoaded): Moved.
1509         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
1510         file, since this was the only place it was used.
1511         (cfStringToBSTR):
1512         * Drosera/win/Drosera.h: Cleaned up the includes.
1513         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
1514         * Drosera/win/HelperFunctions.h: Removed.
1515
1516 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1517
1518         Reviewed by Adam.
1519
1520         - Small cleanup in the ServerConnection class.
1521
1522         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
1523         and added an include.
1524         (ServerConnection::currentFrame):
1525         (ServerConnection::getCallerFrame):
1526         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
1527         made a pointer into a COMPtr, and cleaned up the includes.
1528
1529 2007-10-29  Timothy Hatcher  <timothy@apple.com>
1530
1531         Reviewed by John Sullivan.
1532         
1533         - Place the Localizable.strings file in mac or win directories
1534           if that location exists.
1535         - Also look for UI_STRING in .c files.
1536
1537         * Scripts/extract-localizable-strings:
1538
1539 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1540
1541         Reviewed by Adam.
1542
1543         - Set the eol-style to native and made all the line endings the same
1544         so that I avoid messy diffs that show eol changes.
1545
1546         * Drosera/win/ServerConnection.cpp:
1547         (ServerConnection::didParseSource):
1548         (ServerConnection::didEnterCallFrame):
1549         (ServerConnection::willExecuteStatement):
1550         (ServerConnection::willLeaveCallFrame):
1551         (ServerConnection::exceptionWasRaised):
1552
1553 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1554
1555         Reviewed by Adam.
1556
1557         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
1558         functionality that could not have existed previously without the new
1559         interfaces.
1560         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
1561         from a BSTR to a JSValueRef.
1562         (DebuggerDocument::platformEvaluateScript): Implemented.
1563         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
1564         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1565         Implemented.
1566         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
1567         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
1568         * Drosera/win/ServerConnection.cpp: Added a helper function.
1569         (ServerConnection::getCallerFrame):
1570         * Drosera/win/ServerConnection.h: Added a helper function.
1571
1572 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
1573
1574         updated reviewers for my previous changelog.
1575
1576 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
1577         Reviewed by Maciej and Adam and Geoff.
1578
1579         - Minor mac-side improvements including moving a function to a more
1580         appropriate location, fixing a warning, and correctly checking
1581         exceptions.
1582
1583         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
1584         (DebuggerDocument::willExecuteStatement):
1585         (DebuggerDocument::didEnterCallFrame):
1586         (DebuggerDocument::willLeaveCallFrame):
1587         (DebuggerDocument::windowScriptObjectAvailable):
1588         (DebuggerDocument::callFunctionOnObject):
1589         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
1590         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
1591         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
1592         because it doesn't require the ServerConnection at all.
1593         (NSStringCreateWithJSStringRef): Made an argument const.
1594         (JSValueRefCreateWithNSString): Made an argument const.
1595         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
1596         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1597         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
1598         * Drosera/mac/ServerConnection.mm: Ditto.
1599         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
1600
1601 2007-10-29  Sam Weinig  <sam@webkit.org>
1602
1603         Reviewed by Adam Roben.
1604
1605         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
1606
1607         * DumpRenderTree/LayoutTestController.cpp:
1608         (LayoutTestController::LayoutTestController):
1609         (getGlobalFlagCallback):
1610         (setGlobalFlagCallback):
1611         (LayoutTestController::getJSClass):
1612         (LayoutTestController::staticValues):
1613         * DumpRenderTree/LayoutTestController.h:
1614         (LayoutTestController::globalFlag):
1615         (LayoutTestController::setGlobalFlag):
1616
1617 2007-10-29  Darin Adler  <darin@apple.com>
1618
1619         Reviewed by Maciej.
1620
1621         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
1622         resolution instead of its default.
1623
1624 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
1625
1626         Fixed showStatus() to print status for successfully resolved conflicts when using git.
1627
1628         Reviewed by Mark Rowe.
1629
1630         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
1631         was successfully resolved, but this would not show any status because the change had
1632         already been cached in the index using "git add".  The solution is to add an optional
1633         second argument to showStatus() which adds the "--cached" switch to the command.
1634
1635         * Scripts/resolve-ChangeLogs:
1636         (showStatus):
1637
1638 2007-10-28  Eric Seidel  <eric@webkit.org>
1639
1640         Reviewed by Maciej and Geoff, in unison.
1641
1642         * Scripts/run-webkit-tests: remove broken --svg option
1643
1644 2007-10-28  Darin Adler  <darin@apple.com>
1645
1646         Reviewed by Adam.
1647
1648         * Scripts/run-sunspider: Default to "Release" configuration rather than
1649         defaulting to the last configuration used as other scripts do. This can
1650         still be overriden on the command line with "--debug" if there's some
1651         reason to do so. Also fix a typo.
1652
1653         * Scripts/sunspider-compare-results: Fix a typo.
1654
1655 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
1656
1657         Reviewed by Adam.
1658
1659         - Implemented the WebScriptDebugListener functions now that the
1660         WebScriptDebugServer exists
1661
1662         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
1663         functions.
1664         (ServerConnection::currentFrame):
1665         (ServerConnection::didLoadMainResourceForDataSource):
1666         (ServerConnection::didParseSource):
1667         (ServerConnection::failedToParseSource):
1668         (ServerConnection::didEnterCallFrame):
1669         (ServerConnection::willExecuteStatement):
1670         (ServerConnection::willLeaveCallFrame):
1671         (ServerConnection::exceptionWasRaised):
1672         * Drosera/win/ServerConnection.h: Removed unused arguments from the
1673         members arguments list.
1674
1675 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
1676
1677         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
1678         <http://bugs.webkit.org/show_bug.cgi?id=15600>
1679
1680         Reviewed by Darin.
1681
1682         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
1683         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
1684         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
1685         file.  Note that it may also be used as a stand-alone script.
1686
1687         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
1688         * Scripts/resolve-ChangeLogs: Added.
1689         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
1690
1691 2007-10-26  Mark Rowe  <mrowe@apple.com>
1692
1693         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
1694         to the Qt port on the assumption that it was an implementation of the cross-platform
1695         LayoutTestController class.  It is not, so it did not need to be changed.
1696
1697         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
1698
1699 2007-10-25  Mark Rowe  <mrowe@apple.com>
1700
1701         Reviewed by Maciej.
1702
1703         Fix builds with code coverage enabled.
1704
1705         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
1706
1707 2007-10-25  Darin Adler  <darin@apple.com>
1708
1709         Reviewed by Mark Rowe.
1710
1711         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
1712         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
1713
1714 2007-10-25  Stephanie  <slewis@apple.com>
1715
1716         build Fix
1717
1718         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1719
1720 2007-10-25  Stephanie  <slewis@apple.com>
1721
1722         Reviewed by Mark Rowe, Adam Roben.
1723
1724         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
1725
1726         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
1727
1728 2007-10-25  Alice Liu  <alice.liu@apple.com>
1729
1730         Reviewed by Adam.
1731
1732         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
1733
1734         Moving destructor into platform-specific files
1735         * DumpRenderTree/LayoutTestController.cpp:
1736         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1737         (LayoutTestController::~LayoutTestController):
1738         * DumpRenderTree/qt/jsobjects.cpp:
1739         (LayoutTestController::~LayoutTestController):
1740
1741         LayoutTestController wasn't being destroyed
1742         * DumpRenderTree/win/DumpRenderTree.cpp:
1743         (runTest):
1744
1745         Added declspec
1746         * DumpRenderTree/win/EditingDelegate.h:
1747
1748         Reset certain values on the webview (or related delegate) that might 
1749         have changed while running a test
1750         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1751         (LayoutTestController::~LayoutTestController):
1752
1753 2007-10-25  Adam Roben  <aroben@apple.com>
1754
1755         Make sunspider-compare-results work with relative paths
1756
1757         Reviewed by Sam.
1758
1759         * Scripts/sunspider-compare-results: Convert arguments to absolute
1760         paths before we chdir.
1761
1762 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
1763
1764         Reviewed by Sam.
1765
1766         - Implemented server calls now the WebScriptDebugServer exists.
1767         - Also removed no longer needed call to initialize CG.
1768
1769         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
1770         automatically now.
1771         (_tWinMain):
1772         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
1773         (ServerConnection::ServerConnection):
1774         (ServerConnection::~ServerConnection):
1775         (ServerConnection::pause):
1776         (ServerConnection::resume):
1777         (ServerConnection::stepInto):
1778         (ServerConnection::applicationTerminating):
1779         (ServerConnection::serverConnectionDidDie):
1780         * Drosera/win/ServerConnection.h: Now uses the COM class.
1781
1782 2007-10-24  George Staikos  <staikos@kde.org>
1783
1784         Unbreak Qt build.
1785
1786         * Scripts/build-webkit:
1787
1788 2007-10-24  Adam Roben  <aroben@apple.com>
1789
1790         Remove now-unnecessary call to InitializeCoreGraphics
1791
1792         WebKit takes care of this now.
1793
1794         Reviewed by Ada.
1795
1796         * DumpRenderTree/win/DumpRenderTree.cpp:
1797         (initialize):
1798
1799 2007-10-24  Adam Roben  <aroben@apple.com>
1800
1801         Use WebTextRenderer in DRT
1802
1803         Reviewed by Ada.
1804
1805         * DumpRenderTree/win/DumpRenderTree.cpp:
1806         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
1807
1808 2007-10-24  Sven Herzberg  <sven@imendio.com>
1809
1810         Reviewed by Mark Rowe.
1811
1812         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
1813         Bug 15614: [GTK] qmake based backends don't build on OS X
1814
1815         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
1816         GTK backend on a Mac
1817         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
1818         isDarwin() to make it reusable in other places (like the workaround-
1819         for-prebuilt-qmake in build-webkit)
1820
1821 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
1822
1823         Refurbish update-webkit script.
1824
1825         Reviewed by Adam.
1826
1827         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
1828         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
1829         multi-argument version of system() for flexibility and security.  Check for existence
1830         of Internal directory using -d test instead of -x.
1831
1832 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
1833
1834         Minor clean-up of prepare-ChangeLog script.
1835
1836         Reviewed by Adam.
1837
1838         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
1839         of a string.  Use multi-argument versions of open() and system() for flexibility and
1840         security.
1841
1842 2007-10-24  Alice Liu  <alice.liu@apple.com>
1843
1844         Reviewed by Oliver.
1845
1846         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
1847
1848         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
1849         replay the saved events when we're still processing the mousedown that starts the drag
1850         * DumpRenderTree/win/EventSender.cpp:
1851         (doMouseMove):
1852         * DumpRenderTree/win/UIDelegate.cpp:
1853         (UIDelegate::doDragDrop):
1854
1855 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
1856
1857         Reviewed by Sam, Steve and Darin.
1858
1859         - Stubbed out the WebScriptDebugListener functionality in the Server
1860         Connection class to prepare it for receiving those callbacks.
1861         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
1862         and the ServerConnection to not need to be initialized with a server
1863         name, since that is not the way we connect to the WebKit server. 
1864
1865         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
1866         no exception.  Now it only loggs when there is an exception
1867         (DebuggerDocument::willExecuteStatement):
1868         (DebuggerDocument::didEnterCallFrame):
1869         (DebuggerDocument::willLeaveCallFrame):
1870         (DebuggerDocument::windowScriptObjectAvailable):
1871         (DebuggerDocument::callFunctionOnObject):
1872         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
1873         to be instantiated with a server's name.
1874         (DebuggerClient::DebuggerClient):
1875         (DebuggerClient::didFinishLoadForFrame):
1876         * Drosera/win/DebuggerClient.h: Removed unsued variable.
1877         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
1878         a server name.
1879         (Drosera::init):
1880         (Drosera::initServer):
1881         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
1882         instantiated with a server's name.
1883         * Drosera/win/ServerConnection.cpp: 
1884         (ServerConnection::ServerConnection): No longer needs a server name
1885         (ServerConnection::~ServerConnection): Only release the global context
1886         if there is one.
1887         (ServerConnection::serverConnectionDidDie): Stub for
1888         IWebScriptDebugListener
1889         (ServerConnection::QueryInterface): ditto
1890         (ServerConnection::AddRef): ditto
1891         (ServerConnection::Release): ditto
1892         (ServerConnection::didLoadMainResourceForDataSource): ditto
1893         (ServerConnection::didParseSource): ditto
1894         (ServerConnection::failedToParseSource): ditto
1895         (ServerConnection::didEnterCallFrame): ditto
1896         (ServerConnection::willExecuteStatement): ditto
1897         (ServerConnection::willLeaveCallFrame): ditto
1898         (ServerConnection::exceptionWasRaised): ditto
1899         * Drosera/win/ServerConnection.h: Stubbed out the
1900         IWebScriptDebugListener functions, and this class no longer needs to be
1901         instantiated with a server name.
1902
1903 2007-10-24  Lars Knoll  <lars@trolltech.com>
1904
1905         Reviewed by Simon.
1906
1907         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
1908
1909         * DumpRenderTree/qt/jsobjects.h:
1910
1911 2007-10-24  Lars Knoll  <lars@trolltech.com>
1912
1913         Reviewed by Simon.
1914
1915         add another command.
1916
1917         * DumpRenderTree/qt/jsobjects.cpp:
1918         (TextInputController::doCommand):
1919
1920 2007-10-24  Lars Knoll  <lars@trolltech.com>
1921
1922         Reviewed by Simon.
1923
1924         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
1925
1926         * DumpRenderTree/qt/jsobjects.cpp:
1927         (EventSender::keyDown):
1928         * DumpRenderTree/qt/jsobjects.h:
1929
1930 2007-10-24  Lars Knoll  <lars@trolltech.com>
1931
1932         Reviewed by Simon.
1933
1934         implement eventSender.keyDown().
1935
1936         * DumpRenderTree/qt/jsobjects.cpp:
1937         (EventSender::keyDown):
1938
1939 2007-10-24  Lars Knoll  <lars@trolltech.com>
1940
1941         Reviewed by Simon.
1942
1943         some smaller fixes to the editing support in DRT. Makes another few tests pass.
1944
1945         * DumpRenderTree/qt/DumpRenderTree.cpp:
1946         (WebCore::DumpRenderTree::DumpRenderTree):
1947         (WebCore::DumpRenderTree::initJSObjects):
1948         * DumpRenderTree/qt/jsobjects.cpp:
1949         (TextInputController::doCommand):
1950
1951 2007-10-24  Lars Knoll  <lars@trolltech.com>
1952
1953         Reviewed by Simon.
1954
1955         first bit of implementation for the textinputcontroller.
1956
1957         * DumpRenderTree/qt/DumpRenderTree.cpp:
1958         (WebCore::DumpRenderTree::DumpRenderTree):
1959         * DumpRenderTree/qt/DumpRenderTree.h:
1960         * DumpRenderTree/qt/jsobjects.cpp:
1961         (TextInputController::TextInputController):
1962         (TextInputController::doCommand):
1963         * DumpRenderTree/qt/jsobjects.h:
1964
1965 2007-10-24  Lars Knoll  <lars@trolltech.com>
1966
1967         Reviewed by Simon.
1968
1969         make the man webpage believe it has focus, so the editing tests work correctly.
1970
1971         * DumpRenderTree/qt/DumpRenderTree.cpp:
1972         (WebCore::DumpRenderTree::DumpRenderTree):
1973
1974 2007-10-24  Lars Knoll  <lars@trolltech.com>
1975
1976         Reviewed by Simon.
1977
1978         implement layoutTestController.dumpEditingCallbacks() correctly.
1979
1980         * DumpRenderTree/qt/DumpRenderTree.cpp:
1981         (WebCore::DumpRenderTree::DumpRenderTree):
1982         * DumpRenderTree/qt/jsobjects.cpp:
1983         (LayoutTestController::reset):
1984         (LayoutTestController::dumpEditingCallbacks):
1985
1986 2007-10-24  Lars Knoll  <lars@trolltech.com>
1987
1988         Reviewed by Simon.
1989
1990         Implement support for testing editing.
1991
1992         * DumpRenderTree/qt/DumpRenderTree.cpp:
1993         (WebCore::DumpRenderTree::DumpRenderTree):
1994
1995 2007-10-23  Sam Weinig  <sam@webkit.org>
1996
1997         Check for null BSTR that can be passed to the UIDelegate methods
1998         from javascript null and undefined.  Fixes a failing test case on
1999         Windows (fast/dom/Window/alert-undefined.html)
2000
2001         Reviewed by Eric Seidel.
2002
2003         * DumpRenderTree/win/UIDelegate.cpp:
2004         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2005         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2006         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2007         (UIDelegate::webViewAddMessageToConsole):
2008
2009 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2010
2011         Reviewed by Darin.
2012         
2013         Don't print a massive pile of setenvs from tools that automatically build testkjs.
2014
2015         * Scripts/build-testkjs:
2016
2017 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2018
2019         Reviewed by Darin.
2020
2021         - add wrapper that finds the right copy of testkjs
2022         
2023         * Scripts/sunspider-compare-results: Added.
2024
2025 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
2026
2027         Reviewed by Sam.
2028
2029         - After talking with Steve I now see that the WebKit server must be
2030         running for DCOM to create the distributed objects, which makes sense
2031         and currently WebKit only allows one instance to be running at a time
2032         which avoids accidentally connecting to the wrong server
2033         - In light of this I have removed the code for the attach box and
2034         NotificationServer and known server names, since they are all extranious
2035         now.
2036
2037         * Drosera/win/Drosera.cpp: Removed notification classes and known server
2038         names.
2039         (_tWinMain): Uses init instead of initUI.
2040         (droseraWndProc): No longer creats an attach dialog box.
2041         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
2042         it's not manditory to call init before doing COM stuff.
2043         (Drosera::init): calls initUI and will call attach when the
2044         functionality exists. 
2045         (Drosera::initUI): Has changed very little.
2046         (Drosera::attach): Changed the signature to reflect that we no longer
2047         need the dictionary of known server names.
2048         * Drosera/win/Drosera.h: Removed notification classes and known server
2049         names.  Also renamed and moved some functions.
2050         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
2051         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
2052         headers to the resources folder. 
2053         * Drosera/win/resource.h: Removed the Attach box.
2054
2055 2007-10-22  Adam Roben  <aroben@apple.com>
2056
2057         Windows build fix
2058
2059         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
2060
2061 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
2062
2063         - Removed a leak that was fixed.
2064
2065         * Scripts/run-webkit-tests:
2066
2067 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2068
2069         Reviewed by Darin.
2070
2071         - Changed the Client so that the DebuggerDocument now own the
2072         ServerConnection.  This simplifies ownership and cleanup. 
2073
2074         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
2075         ServerConnection.
2076         (DebuggerClient::initWithServerName):
2077         (DebuggerClient::didFinishLoadForFrame):
2078         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
2079         ServerConnection.
2080         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
2081         until after we have a server which we are attached to.
2082         (Drosera::initUI):
2083         (Drosera::attach):
2084         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
2085         out previously.
2086
2087 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2088
2089         Reviewed by Nikolas.
2090
2091         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
2092
2093         * Scripts/run-javascriptcore-tests:
2094
2095 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2096
2097         Reviewed by Nikolas.
2098
2099         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
2100
2101         * Scripts/build-drosera:
2102         * Scripts/build-dumprendertree:
2103         * Scripts/build-testkjs:
2104         * Scripts/build-webkit:
2105         * Scripts/run-javascriptcore-tests:
2106         * Scripts/run-sunspider:
2107         * Scripts/run-webkit-tests:
2108         * Scripts/webkitdirs.pm:
2109
2110 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
2111
2112         Reviewed by Mark Rowe.
2113         
2114         Fix for local database support after r26879
2115         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
2116
2117         * Scripts/build-webkit:
2118
2119 2007-10-22  Holger Freyther  <zecke@selfish.org>
2120
2121         Reviewed by Simon Hausmann <hausmann@kde.org>.
2122
2123         - Do not build testkjs as an application bundle. This is
2124         needed for run-javascriptcore-tests on OSX.
2125         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
2126         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
2127         as we do not have -rpath on OSX.
2128
2129         * DumpRenderTree/qt/DumpRenderTree.pro:
2130         * Scripts/run-webkit-tests:
2131
2132 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2133
2134         Reviewed by aroben.
2135
2136         Fix support for Signed-off-by detection in prepare-ChangeLog
2137         --git-commit. The Signed-off-by tag does not appear in the header
2138         but usually at the end.
2139
2140         * Scripts/prepare-ChangeLog:
2141
2142 2007-10-21  Mark Rowe  <mrowe@apple.com>
2143
2144         Reviewed by Eric.
2145
2146         Fix run-javascriptcore-tests for Gtk.
2147
2148         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
2149
2150 2007-10-20  Eric Seidel  <eric@webkit.org>
2151
2152         Reviewed by aroben.
2153
2154         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
2155
2156 2007-10-20  Eric Seidel  <eric@webkit.org>
2157
2158         Reviewed by darin.
2159         
2160         Add improved argument handling to run-sunspider, including
2161         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
2162         Also re-factor code into subroutines
2163
2164         * Scripts/build-dumprendertree: removed bogus comments
2165         * Scripts/build-testkjs: Added.
2166         * Scripts/run-javascriptcore-tests: use build-testkjs
2167         * Scripts/run-sunspider: improved argument handling, abstraction
2168         * Scripts/run-webkit-tests: improved abstraction
2169
2170 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
2171
2172         Not reviewed, Windows build fix.
2173
2174         * DumpRenderTree/win/EventSender.cpp:
2175         (keyDownCallback):
2176
2177 2007-10-20  Darin Adler  <darin@apple.com>
2178
2179         Reviewed by Tim Hatcher.
2180
2181         - http://bugs.webkit.org/show_bug.cgi?id=15544
2182           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
2183           not rely on Apple-specific key codes
2184
2185         * DumpRenderTree/mac/EventSendingController.mm:
2186         (-[EventSendingController keyDown:withModifiers:]):
2187         Added named key "rightArrow". Later we could have a whole table of these.
2188         Also tweaked modifiers code a little.
2189
2190         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
2191
2192 2007-10-19  Darin Adler  <darin@apple.com>
2193
2194         Reviewed by Eric.
2195
2196         - http://bugs.webkit.org/show_bug.cgi?id=15566
2197           possible fix for leak seen in DumpRenderTree
2198
2199         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
2200         Delete the item if it's not put on the queue, since the caller has
2201         no way of knowing that. Would be better to have the parameter type
2202         be auto_ptr to express the fact that we take ownership.
2203
2204         - unrelated change
2205
2206         * Drosera/mac/main.m: Add missing include.
2207
2208 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2209
2210         Reviewed by Adam.
2211
2212         - This change should be identical but for some reason was not working
2213         on my machine.
2214
2215         * Scripts/prepare-ChangeLog:
2216
2217 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2218
2219         Reviewed by Oliver and Tim.
2220
2221         - Made use of RetainPtr to avoid retain and release issues and moved the
2222         log function to DebuggerDocumentPlatform, which seems to be a more
2223         logical place for it to live.
2224         - Also moved knownServers from the ServerConnection to
2225         DebuggerApplication to match the Windows code and because it makes sense
2226         that a connection knows its own server but not all of them.
2227
2228         * Drosera/mac/DebuggerClient.h: Moved the log function to
2229           DebuggerDocumentPlatform.
2230         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
2231           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
2232           call for the server name up from the ServerConnection class.
2233         (-[DebuggerClient dealloc]):
2234         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
2235           for the server name up from the ServerConnection.
2236         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
2237         (DebuggerDocument::platformPause):
2238         (DebuggerDocument::platformResume):
2239         (DebuggerDocument::platformStepInto):
2240         (DebuggerDocument::platformEvaluateScript):
2241         (DebuggerDocument::getPlatformCurrentFunctionStack):
2242         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2243         (DebuggerDocument::platformValueForScopeVariableNamed):
2244         (DebuggerDocument::platformLog): Log directly from here. No need to call
2245           DebuggerClient.
2246         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
2247           way I see it, a ServerConnection should only know about its connection
2248           and the group of all possible servers should be kept by the
2249           application.
2250         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
2251           currentServerName, it makes sense that the connection should know that
2252           name.
2253         (-[ServerConnection currentServerName]):
2254
2255 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2256
2257         Reviewed by Adam.
2258
2259         - Integrated changes from mac drosera.  Recently I've encapsulated
2260         out the server connection object from the rest of Drosera because
2261         it is very platform dependent right now and RPC is not implemented on
2262         windows.  This functionality, of communicating with the WebKit server
2263         is the next area I will be focusing on in Windows.
2264
2265         - Other changes and cleanup were made to organize the code and add notes
2266         on which parts still need work.  Also some mac code is added and
2267         commented out, to act as pseudocode for the logic of those parts.
2268
2269         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
2270           pointer.
2271         * Drosera/config.h: Added whitespace.
2272         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
2273           these files got moved into Drosera.h/cpp
2274         * Drosera/win/DebuggerApplication.h: Removed.
2275         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
2276           happened here to better match the logic flow of the same code on the 
2277           mac side and to use the new ServerConnection class.
2278         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
2279         (DebuggerClient::initWithServerName): Initializer that will set up the
2280           class to use a ServerConnection object.  This was necessary so I could
2281           create a DebuggerClient without having to initilaize it at
2282           construction.
2283         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
2284           will be the UIDelegate and FrameLoadDelegate.
2285         (DebuggerClient::AddRef): For IUnknown.
2286         (DebuggerClient::Release): For IUnknown.
2287         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
2288           this still needs to set the global context of the server, but
2289           IWebFrame does not have an accessor for the global context yet. 
2290         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
2291           this is a pass through for the same function in the document.
2292         (DebuggerClient::didReceiveTitle): Unimplemented part of
2293           FrameLoadDelegate this would change the title of the window.
2294         (DebuggerClient::createWebViewWithRequest): Part of the
2295           FrameLoadDelegate.  This is about new windows via Window.open() and
2296           how their delegates are set.
2297         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
2298           UIDelegate.  Just a debug function for printing messages.
2299         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
2300           because the Client should be the UIDelegate and FrameLoadDelegate
2301           to match the delegates on mac.
2302         (DebuggerClient::webViewLoaded): Added accessor method.
2303         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
2304           forgotten to add this file before.  This is where the platform
2305           dependent versions of the Documents functions live. Most of these are
2306           unimplemented because some piece of functionality does not exist on
2307           Windows yet.
2308         (DebuggerDocument::platformPause):
2309         (DebuggerDocument::platformResume):
2310         (DebuggerDocument::platformStepInto):
2311         (DebuggerDocument::platformEvaluateScript):
2312         (DebuggerDocument::getPlatformCurrentFunctionStack):
2313         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2314         (DebuggerDocument::platformValueForScopeVariableNamed):
2315         (DebuggerDocument::platformLog):
2316         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
2317           responsibilities becaue they belong in the Client. Also I laid the
2318           groundwork for attaching Drosera to a WebKit process
2319         (attachWndProc): Now if a server is selected the Client becomes it's
2320           delegate.
2321         (Drosera::Drosera): Added the construction of the Client and dictionary
2322           of server names. 
2323         (Drosera::initUI): This is no longer the delegates, the Client is.
2324         (Drosera::webViewLoaded): Now asks the Client instead of holding local
2325           state. 
2326         (Drosera::applicationDidFinishLaunching): Placeholder for needed
2327           notification registration when it's possible to implement.
2328         (Drosera::serverLoaded): Ditto
2329         (Drosera::serverUnloaded): Ditto
2330         (Drosera::attach): Attach Drosera to the WebKit server.
2331         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
2332         (Drosera::getInst): 
2333         (Drosera::setInst):
2334         (Drosera::knownServers):
2335         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
2336           and added the ServerConnection.
2337         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
2338         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
2339           Most of the functions are completely unimlemented because they cannot
2340           connect with the WebKit server, because one does not exist on Windows
2341           yet.
2342         (ServerConnection::initWithServerName): 
2343         (ServerConnection::~ServerConnection):
2344         (ServerConnection::setGlobalContext):
2345         (ServerConnection::pause):
2346         (ServerConnection::resume):
2347         (ServerConnection::stepInto):
2348         (ServerConnection::switchToServerNamed):
2349         (ServerConnection::applicationTerminating):
2350         (ServerConnection::serverConnectionDidDie):
2351         (ServerConnection::currentFrame):
2352         * Drosera/win/ServerConnection.h: Added. Ditto.
2353         (ServerConnection::ServerConnection):
2354
2355 2007-10-19  Alice Liu  <alice.liu@apple.com>
2356
2357         Reviewed by Darin.
2358
2359         Fix for these broken layout tests on Windows:
2360         
2361         fast/forms/focus-selection-input.html
2362         fast/forms/focus-selection-textarea.html
2363         fast/forms/select-accesskey.html
2364         
2365         * DumpRenderTree/win/EventSender.cpp:
2366         (keyDownCallback):
2367         correct the VK code for alt key.
2368         
2369 2007-10-19  Eric Seidel  <eric@webkit.org>
2370
2371         Reviewed by Mark Rowe.
2372         
2373         Make the GtkLauncher code slightly more readable.
2374
2375         * GtkLauncher/main.cpp:
2376         (setupMainMenu): Added.
2377         (setupMainWindowUI): Added.
2378         (main):
2379
2380 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
2381
2382         Rubber stamped by Adam.
2383         
2384         - don't delay-load WebKit in DumpRenderTree.
2385
2386         * DumpRenderTree/win/DumpRenderTree.vcproj:
2387
2388 2007-10-18  Dan Bernstein  <mitz@apple.com>
2389
2390         Reviewed by Adam Roben.
2391
2392         - fix <rdar://problem/5313523>
2393         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
2394
2395         * DumpRenderTree/mac/DumpRenderTree.mm:
2396         (dump): Changed to use _responseMIMEType.
2397
2398 2007-10-17  Adam Roben  <aroben@apple.com>
2399
2400         Make it possible to have Windows-specific tests and results
2401
2402         When searching for tests to run and the Skipped file, we will only
2403         look in platform/win and the cross-platform directory. When looking
2404         for expected results, we will look in platform/win, then
2405         platform/mac-leopard, then platform/mac, then finally the
2406         cross-platform directory.
2407
2408         Reviewed by Sam.
2409
2410         * Scripts/run-webkit-tests:
2411         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
2412         searching in the cross-platform directory.
2413         (sub buildPlatformHierarchy): Removed some unneeded calls to
2414         dirname/basename.
2415
2416 2007-10-17  Adam Roben  <aroben@apple.com>
2417
2418         Add back the call to register WebKit that we had before WebKitInitializer existed
2419
2420         This is needed to ensure that the right WebKit is used when
2421         instantiating COM objects.
2422
2423         Reviewed by Oliver.
2424
2425         * DumpRenderTree/win/debug_internal.vsprops: Define
2426         DEBUG_WEBKIT_HAS_SUFFIX.
2427         * DumpRenderTree/win/DumpRenderTree.cpp:
2428         (initialize):
2429
2430 2007-10-17  Adam Roben  <aroben@apple.com>
2431
2432         Import File::Basename in webkitdirs since we use it
2433
2434         * Scripts/webkitdirs.pm:
2435
2436 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
2437
2438         - Updated the tiger leaks list to make the internal bots green.
2439
2440         * Scripts/run-webkit-tests:
2441
2442 2007-10-17  Adam Roben  <aroben@apple.com>
2443
2444         Build fix for VC++ Express
2445
2446         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
2447         and ole32.lib.
2448
2449 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2450
2451         Reviewed by Sam.
2452
2453         - Minor mac improvements based on observations I made while implementing the
2454         Windows code.
2455
2456         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
2457         then hand it to the Client who will retain it, it should just be the client who
2458         creates and owns the server.
2459         (-[DebuggerApplication attach:]):
2460         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
2461         * Drosera/mac/DebuggerClient.mm: Creates the server.
2462         (-[DebuggerClient initWithServerName:]):
2463         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
2464         can instead forward declare what it needs.
2465
2466 2007-10-16  Darin Adler  <darin@apple.com>
2467
2468         Reviewed by Geoff Garen.
2469
2470         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
2471         want to turn failing tests into platform-specific test results. Also did a
2472         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
2473         would take the type of results into account only some of the time.
2474
2475 2007-10-16  Adam Roben  <aroben@apple.com>
2476
2477         Add a new nightly launcher script for Windows
2478
2479         This new script is for versions of Safari that don't delay-load
2480         WebKit. I had to make FindSafari be able to print out the nightly
2481         launcher script on stdout because Windows shell scripts can't capture
2482         the output from a command into an environment variable.
2483
2484         Reviewed by Steve.
2485
2486         * FindSafari/FindSafari.cpp:
2487         (_tmain): Added /printSafariLauncher option.
2488         * Scripts/run-webkit-nightly.cmd: Added.
2489
2490 2007-10-16  Adam Roben  <aroben@apple.com>
2491
2492         Replace WebKitInitializer with FindSafari
2493
2494         We now rely on setting the PATH environment variable to tell Windows
2495         where to find WebKit and its dependencies (similar to
2496         DYLD_FRAMEWORK_PATH on Mac).
2497
2498         This change also make DumpRenderTree no longer delay-load WebKit.
2499
2500         Reviewed by Sam.
2501
2502         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
2503         FindSafari.
2504         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
2505         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
2506         WebKitInitializer, don't delay-load WebKit.
2507         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
2508         * Scripts/run-webkit-tests: Ditto.
2509         * Scripts/webkitdirs.pm:
2510         (sub setPathForRunningWebKitApp): Added.
2511         * WebKitInitializer/WebKitInitializer.cpp: Removed.
2512         * WebKitInitializer/WebKitInitializer.h: Removed.
2513         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
2514         * WebKitInitializer/debug.vsprops: Removed.
2515         * WebKitInitializer/debug_internal.vsprops: Removed.
2516         * WebKitInitializer/release.vsprops: Removed.
2517
2518 2007-10-16  Adam Roben  <aroben@apple.com>
2519
2520         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
2521
2522         http://bugs.webkit.org/show_bug.cgi?id=15532
2523
2524         FindSafari simply prints the location of an installed Safari.exe on
2525         stdout.
2526
2527         Reviewed by Darin.
2528
2529         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
2530         (getStringValue):
2531         (getWebViewCLSID):
2532         (getInstalledWebKitDirectory):
2533         (_tmain):
2534         * FindSafari/FindSafari.vcproj: Added.
2535         * Scripts/webkitdirs.pm:
2536         (sub installedSafariPath): Added. Calls FindSafari on Windows.
2537
2538 2007-10-16  Adam Roben  <aroben@apple.com>
2539
2540         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
2541
2542         Reviewed by Kevin McCullough.
2543
2544         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
2545         when referring to WebKit.dll.
2546         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
2547         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
2548         * DumpRenderTree/win/release.vsprops: Ditto.
2549         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
2550         never have a _debug suffix on WebKit.dll.
2551         * WebKitInitializer/WebKitInitializer.cpp:
2552         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
2553         specified.
2554         * WebKitInitializer/debug_internal.vsprops: Added
2555         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
2556
2557 2007-10-16  Darin Adler  <darin@apple.com>
2558
2559         Reviewed by Adele.
2560
2561         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
2562         Remove now-unneeded control/alt key hack; the tests have been updated.
2563
2564 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2565
2566         - Updated leaks list because our internal bot upgraded it's version of leopard and 
2567         one of the leaks was fixed between that revision and the bot's previous version of
2568         leopard.
2569
2570         * Scripts/run-webkit-tests:
2571
2572 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
2573
2574         Reviewed by Tim.
2575
2576         - I encapsulated out the server connecton functionality because it is a specific part
2577         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
2578         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
2579         Windows.  So the majority of this patch is moving preexisting functionality.
2580
2581         - Also I removed the prefix header and changed to use config.h because it is more
2582         standard on how we use config.h in windows and it didn't make much sense to keep
2583         the prefix header and the config.h
2584
2585         * Drosera/DebuggerDocument.cpp:
2586         (DebuggerDocument::DebuggerDocument):
2587         * Drosera/DebuggerDocument.h:
2588         * Drosera/config.h:
2589         * Drosera/mac/DebuggerApplication.mm:
2590         (-[DebuggerApplication attach:]):
2591         * Drosera/mac/DebuggerClient.h:
2592         * Drosera/mac/DebuggerClient.mm:
2593         (-[DebuggerClient initWithServerConnection:]):
2594         (-[DebuggerClient dealloc]):
2595         (-[DebuggerClient windowDidLoad]):
2596         (-[DebuggerClient windowWillClose:]):
2597         (-[DebuggerClient webView:didFinishLoadForFrame:]):
2598         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
2599         * Drosera/mac/DebuggerDocumentPlatform.mm:
2600         (DebuggerDocument::platformPause):
2601         (DebuggerDocument::platformResume):
2602         (DebuggerDocument::platformStepInto):
2603         (DebuggerDocument::platformEvaluateScript):
2604         (DebuggerDocument::getPlatformCurrentFunctionStack):
2605         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2606         (DebuggerDocument::platformValueForScopeVariableNamed):
2607         (DebuggerDocument::platformLog):
2608         * Drosera/mac/Drosera.pch: Removed.
2609         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2610         * Drosera/mac/ServerConnection.h: Added.
2611         * Drosera/mac/ServerConnection.mm: Added.
2612         (-[ServerConnection initWithServerName:]):
2613         (-[ServerConnection dealloc]):
2614         (-[ServerConnection setGlobalContext:]):
2615         (-[ServerConnection pause]):
2616         (-[ServerConnection resume]):
2617         (-[ServerConnection stepInto]):
2618         (-[ServerConnection switchToServerNamed:]):
2619         (-[ServerConnection applicationTerminating:]):
2620         (-[ServerConnection serverConnectionDidDie:]):
2621         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2622         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
2623         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
2624         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
2625         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
2626         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
2627         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
2628         (-[ServerConnection currentFrame]):
2629         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
2630         (-[ServerConnection knownServers]):
2631
2632 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
2633
2634         Reviewed by Eric.
2635
2636         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
2637           Script to automatically search nightly builds for regressions (bisect-builds)
2638
2639         * Scripts/bisect-builds: Added.
2640
2641 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
2642
2643         Reviewed by Darin.
2644
2645         - New JavaScript benchmark
2646         http://bugs.webkit.org/show_bug.cgi?id=15515
2647
2648         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
2649         current development or release build of JavaScriptCore.
2650
2651 2007-10-15  Mark Rowe  <mrowe@apple.com>
2652
2653         Reviewed by Sam.
2654
2655         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
2656
2657         * Scripts/webkitdirs.pm:
2658         - Change checkArgv to remove the options from @ARGV to prevent
2659         them from interfering with further option processing.
2660         - Fix logic error in determineIsQt that would prevent it from bailing out early.
2661         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
2662         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
2663         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
2664
2665 2007-10-15  Darin Adler  <darin@apple.com>
2666
2667         Reviewed by Sam.
2668
2669         - added logging of window.prompt and window.confirm
2670
2671         * DumpRenderTree/mac/UIDelegate.mm:
2672         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2673         Implement the recommended delegate rather than the deprecated one.
2674         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
2675         Added.
2676         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2677         Added.
2678
2679         * DumpRenderTree/win/UIDelegate.h:
2680         * DumpRenderTree/win/UIDelegate.cpp:
2681         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
2682         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
2683         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
2684         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
2685
2686 2007-10-15  Alice Liu  <alice.liu@apple.com>
2687
2688         Reviewed by Sam Weinig.
2689
2690         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
2691
2692         * DumpRenderTree/win/DumpRenderTree.cpp:
2693         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
2694         (main): allocate the global policy delegate for DRT's custom use
2695         * DumpRenderTree/win/DumpRenderTree.vcproj:
2696         Adding files to project
2697         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
2698         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2699         (LayoutTestController::setCustomPolicyDelegate):
2700         set the webview's policy delegate to DRT's custom one if the test requests it.
2701         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
2702         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
2703         (PolicyDelegate::PolicyDelegate):
2704         (PolicyDelegate::QueryInterface):
2705         (PolicyDelegate::AddRef):
2706         (PolicyDelegate::Release):
2707         (PolicyDelegate::decidePolicyForNavigationAction):
2708         * DumpRenderTree/win/PolicyDelegate.h: Added.
2709         (PolicyDelegate::decidePolicyForNewWindowAction):
2710         (PolicyDelegate::decidePolicyForMIMEType):
2711         (PolicyDelegate::unableToImplementPolicyWithError):
2712
2713 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
2714
2715         Reviewed by Mark.
2716
2717         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
2718         when querying for QMAKE_MKSPECS.
2719
2720 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
2721
2722         Reviewed by Adam Roben.
2723         
2724         Fix run-webkit-tests is too greedy calculating platform hierarchy
2725         http://bugs.webkit.org/show_bug.cgi?id=15465
2726         
2727         Fix run-webkit-tests being too greedy in trying to split the platform name up
2728         causing it to try and find tests in every directory above the first "-" in the
2729         path to the LayoutTests
2730
2731         * Scripts/run-webkit-tests:
2732
2733 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
2734
2735         Reviewed by Darin.
2736
2737         http://bugs.webkit.org/show_bug.cgi?id=15006
2738         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
2739         to reduce code duplication.
2740
2741         * Scripts/build-webkit:
2742         * Scripts/webkitdirs.pm:
2743         buildQMakeProject() renamed to buildQMakeQtProject().
2744         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
2745         unused $colorize has been removed.
2746
2747 === Start merge of feature-branch 2007-10-12 ===
2748
2749 2007-10-08  Eric Seidel  <eric@webkit.org>
2750
2751         Reviewed by Mark Rowe.
2752
2753         * Scripts/build-webkit: add --help, remove unused --color
2754
2755 2007-10-07  Eric Seidel  <eric@webkit.org>
2756
2757         Reviewed by darin.
2758
2759         * Drosera/mac/DebuggerDocumentPlatform.mm:
2760         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
2761
2762 2007-10-03  Rob Buis  <buis@kde.org>
2763
2764         Reviewed by Olliej.
2765
2766         Adapt to changed location of Ahem font.
2767
2768         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2769
2770 2007-10-02  Eric Seidel  <eric@webkit.org>
2771
2772         Reviewed by Adam Roben.
2773         
2774         Make pixel tests more useful!
2775         Finally fix the image diff 0.00% mystery problem
2776         Highlight any image differences in the image diff.
2777         Add a link from image diffs back to original test file.
2778
2779         * DumpRenderTree/mac/ImageDiff.m:
2780         (compareImages): highlight any differences
2781         (computePercentageDifferent): round to two decimal places
2782         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
2783
2784 2007-10-02  Eric Seidel  <eric@webkit.org>
2785
2786         Reviewed by Alexey Proskuryakov.
2787
2788         * Scripts/run-webkit-tests: print the % image difference on main results page
2789
2790 2007-10-02  Mark Rowe  <mrowe@apple.com>
2791
2792         Reviewed by Oliver.
2793
2794         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
2795
2796         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
2797         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
2798
2799 2007-10-01  Mark Rowe  <mrowe@apple.com>
2800
2801         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
2802
2803 2007-09-25  Eric Seidel  <eric@webkit.org>
2804
2805         Reviewed by Mark Rowe.
2806         
2807         DerivedSources.make was finding "ENABLE_SVG" in the string
2808         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
2809         quite correctly.
2810
2811         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
2812
2813 2007-09-25  Mark Rowe  <mrowe@apple.com>
2814
2815         Rubber-stamped by Eric.
2816
2817         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
2818         This makes it possible to automate nightly builds for the feature-branch.
2819
2820 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
2821
2822         Rubber stamped by Mark.
2823
2824         Enable svg experimental features as default here in feature-branch.
2825
2826         * Scripts/build-webkit:
2827
2828 2007-06-29  Antti Koivisto  <antti@apple.com>
2829
2830         Reviewed by Weinig.
2831         
2832         Add VIDEO flag for timed media features
2833
2834         * Scripts/build-webkit
2835         
2836 === End merge of feature-branch 2007-10-12 ===
2837
2838 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
2839
2840         Reviewed by Darin.
2841
2842         - Updated rational for the leaks list to be more clear.
2843
2844         * Scripts/run-webkit-tests:
2845
2846 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
2847
2848         Rubber Stamp by Sam.
2849
2850         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
2851         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
2852
2853         * Scripts/run-webkit-tests:
2854
2855 2007-10-10  Simon Hausmann  <hausmann@kde.org>
2856
2857         Reviewed by Lars.
2858
2859         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
2860         includes are needed for INT_MAX, std::auto_ptr and the like.
2861
2862         * DumpRenderTree/qt/main.cpp:
2863
2864 2007-10-09  Lars Knoll  <lars@trolltech.com>
2865
2866         Reviewed by Simon.
2867
2868         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
2869
2870         * DumpRenderTree/qt/jsobjects.cpp:
2871         (LayoutTestController::encodeHostName):
2872         (LayoutTestController::decodeHostName):
2873         * DumpRenderTree/qt/jsobjects.h:
2874
2875 2007-10-09  Lars Knoll  <lars@trolltech.com>
2876
2877         Reviewed by Simon.
2878
2879         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
2880
2881         * DumpRenderTree/qt/DumpRenderTree.cpp:
2882         (WebCore::WebPage::createFrame):
2883         (WebCore::DumpRenderTree::DumpRenderTree):
2884         (WebCore::DumpRenderTree::titleChanged):
2885         * DumpRenderTree/qt/DumpRenderTree.h:
2886         * DumpRenderTree/qt/jsobjects.cpp:
2887         (LayoutTestController::reset):
2888         * DumpRenderTree/qt/jsobjects.h:
2889
2890 2007-10-09  Lars Knoll  <lars@trolltech.com>
2891
2892         Reviewed by Simon.
2893
2894         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
2895
2896         * DumpRenderTree/qt/DumpRenderTree.h:
2897         * DumpRenderTree/qt/jsobjects.cpp:
2898         (LayoutTestController::clearBackForwardList):
2899         * DumpRenderTree/qt/jsobjects.h:
2900
2901 2007-10-09  Lars Knoll  <lars@trolltech.com>
2902
2903         Reviewed by Simon.
2904
2905         make --git-reviewer work again.
2906
2907         * Scripts/prepare-ChangeLog:
2908
2909 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
2910
2911         Rubber stamped by Eric.
2912
2913         Connect to the "hovering-over-link" signal emitted by WebKitPage and
2914         show the current link inside the statusbar.
2915         This shows how to make use of this signal and allows to easily test
2916         http://bugs.webkit.org/show_bug.cgi?id=15299.
2917
2918         * GtkLauncher/main.cpp:
2919         (hoveringOverLink):
2920         (main):
2921
2922 2007-10-05  Lars Knoll  <lars@trolltech.com>
2923
2924         add proper error messages to the FrameLoaderClient.
2925         Implement ChromeClientQt::closeWindowSoon and
2926         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
2927         Some fixes in DRT to make it work correctly with multiple windows.
2928
2929         Reviewed by Maciej.
2930
2931         * DumpRenderTree/qt/DumpRenderTree.cpp:
2932         (WebCore::DumpRenderTree::DumpRenderTree):
2933         (WebCore::DumpRenderTree::createWindow):
2934         (WebCore::DumpRenderTree::windowCount):
2935         * DumpRenderTree/qt/DumpRenderTree.h:
2936         * DumpRenderTree/qt/jsobjects.cpp:
2937         (LayoutTestController::maybeDump):
2938         (LayoutTestController::windowCount):
2939         * DumpRenderTree/qt/jsobjects.h:
2940
2941 2007-10-05  Lars Knoll  <lars@trolltech.com>
2942
2943         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
2944         Add support for layoutTextController.setCanOpenWindows() to DRT
2945         fixing another 2 test cases in fast/dom/Window.
2946
2947         Reviewed by Maciej.
2948
2949         * DumpRenderTree/qt/DumpRenderTree.cpp:
2950         (WebCore::WebPage::WebPage):
2951         (WebCore::WebPage::createWindow):
2952         (WebCore::DumpRenderTree::resetJSObjects):
2953         (WebCore::DumpRenderTree::createWindow):
2954         * DumpRenderTree/qt/DumpRenderTree.h:
2955         * DumpRenderTree/qt/DumpRenderTree.pro:
2956         * DumpRenderTree/qt/jsobjects.cpp:
2957         (LayoutTestController::LayoutTestController):
2958         (LayoutTestController::reset):
2959         * DumpRenderTree/qt/jsobjects.h:
2960         * DumpRenderTree/qt/main.cpp:
2961         * DumpRenderTree/qt/testplugin.cpp: Added.
2962         * DumpRenderTree/qt/testplugin.h: Added.
2963
2964 2007-10-04  Sam Weinig  <sam@webkit.org>
2965
2966         Rubber stamped by Adam.
2967
2968         Remove empty directories.
2969
2970         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
2971         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
2972
2973 2007-10-03  Darin Adler  <darin@apple.com>
2974
2975         Reviewed by Adam.
2976
2977         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
2978         we find the internal libraries in the libraries directory. This
2979         is helpful for Safari team engineers at Apple.
2980
2981 2007-10-03  Adam Roben  <aroben@apple.com>
2982
2983         Update the location of AHEM___.TTF after r25968
2984
2985         Reviewed by Sam.
2986
2987         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2988
2989 2007-10-03  Alp Toker  <alp@atoker.com>
2990
2991         Reviewed by Adam.
2992
2993         http://bugs.webkit.org/show_bug.cgi?id=14726
2994         [gtk] API design. Mapping the WebView delegates to signals.
2995
2996         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
2997
2998         * GtkLauncher/main.cpp:
2999         (goToURLBarText):
3000         (titleChanged):
3001         (progressChanged):
3002         (menuMainBackCallback):
3003         (menuMainForwardCallback):
3004         (main):
3005
3006 2007-10-03  Lars Knoll  <lars@trolltech.com>
3007
3008         Reviewed by Rob.
3009
3010         This fixes --strict mode in run-webkit-tests again after
3011         the platform dependent test results have been moved.
3012
3013         * Scripts/run-webkit-tests:
3014
3015 2007-10-03  Lars Knoll  <lars@trolltech.com>
3016
3017         Reviewed by bdash.
3018
3019         remove the hack in run-webkit-tests that forced text only test
3020         to be taken from the platform independent dir. It was only left
3021         there from early days.
3022         
3023         Remove platform dependent results for tests that are text only nowadays,
3024         and add one platform dependent result for a text only test that requires it.
3025
3026         * Scripts/run-webkit-tests:
3027
3028 2007-10-03  Lars Knoll  <lars@trolltech.com>
3029
3030         Reviewed by olliej.
3031
3032         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
3033
3034         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
3035         (WebCore::WebFrame::WebFrame):
3036         (WebCore::WebPage::WebPage):
3037         (WebCore::WebPage::createFrame):
3038         (WebCore::WebPage::javaScriptAlert):
3039         (WebCore::WebPage::javaScriptConsoleMessage):
3040         (WebCore::DumpRenderTree::DumpRenderTree):
3041         (WebCore::DumpRenderTree::~DumpRenderTree):
3042         (WebCore::DumpRenderTree::open):
3043         (WebCore::DumpRenderTree::readStdin):
3044         (WebCore::DumpRenderTree::resetJSObjects):
3045         (WebCore::DumpRenderTree::initJSObjects):
3046         (WebCore::DumpRenderTree::dumpFramesAsText):
3047         (WebCore::DumpRenderTree::dump):
3048         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
3049         (WebCore::DumpRenderTree::layoutTestController):
3050         (WebCore::DumpRenderTree::eventSender):
3051         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
3052         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
3053         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
3054         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
3055         (HackWebFrame::mousePressEvent):
3056         (HackWebFrame::mouseReleaseEvent):
3057         (HackWebFrame::mouseMoveEvent):
3058         (HackWebFrame::HackWebFrame):
3059         (HackWebFrame::~HackWebFrame):
3060         (LayoutTestController::LayoutTestController):
3061         (LayoutTestController::reset):
3062         (LayoutTestController::maybeDump):
3063         (LayoutTestController::waitUntilDone):
3064         (LayoutTestController::notifyDone):
3065         (LayoutTestController::dumpEditingCallbacks):
3066         (LayoutTestController::queueReload):
3067         (LayoutTestController::provisionalLoad):
3068         (LayoutTestController::timerEvent):
3069         (EventSender::EventSender):
3070         (EventSender::mouseDown):
3071         (EventSender::mouseUp):
3072         (EventSender::mouseMoveTo):
3073         (EventSender::leapForward):
3074         (EventSender::keyDown):
3075         (EventSender::frameUnderMouse):
3076         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
3077         (LayoutTestController::isLoading):
3078         (LayoutTestController::setLoading):
3079         (LayoutTestController::shouldDumpAsText):
3080         (LayoutTestController::shouldDumpChildrenAsText):
3081         (LayoutTestController::shouldWaitUntilDone):
3082         (LayoutTestController::dumpAsText):
3083         (LayoutTestController::dumpChildFramesAsText):
3084         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
3085         (messageHandler):
3086         (crashHandler):
3087         (main):
3088         * Scripts/run-webkit-tests:
3089
3090 2007-10-03  Mark Rowe  <mrowe@apple.com>
3091
3092         Reviewed by Alp Toker.
3093
3094         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
3095         should take precedence over QTDIR when determining which port we are working with.
3096
3097         * Scripts/webkitdirs.pm: 
3098
3099 2007-10-02  Adam Roben  <aroben@apple.com>
3100
3101         Add keychain to the list of default packages to install
3102
3103         Rubberstamped by Sam.
3104
3105         * CygwinDownloader/cygwin-downloader.py:
3106         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
3107
3108 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
3109
3110         Reviewed by Adam.
3111
3112         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
3113         Also makes WebCore regression test case logic work when using git.
3114
3115         * Scripts/prepare-ChangeLog:
3116         (reviewerAndDescriptionForGitCommit): Added.
3117
3118 2007-10-02  Lars Knoll  <lars@trolltech.com>
3119
3120         Reviewed by bdash.
3121
3122         Add API to retrieve the frame name from QWebFrame.
3123         Implement support for DRT::dumpChildrenAsText.
3124
3125         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3126         (WebCore::DumpRenderTree::dumpFramesAsText):
3127         (WebCore::DumpRenderTree::dump):
3128         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3129         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3130         (LayoutTestController::LayoutTestController):
3131         (LayoutTestController::reset):
3132         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
3133
3134 2007-10-02  Lars Knoll  <lars@trolltech.com>
3135
3136         Reviewed by bdash.
3137
3138         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
3139
3140         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3141         (WebCore::DumpRenderTree::readStdin):
3142
3143 2007-10-02  Mark Rowe  <mrowe@apple.com>
3144
3145         Reviewed by Oliver.
3146
3147         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3148
3149         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3150         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3151
3152 2007-10-02  Mark Rowe  <mrowe@apple.com>
3153
3154         Rubber-stamped by Maciej.
3155
3156         Configuration changes from build.webkit.org.  The major change is refactoring to work
3157         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
3158         last few weeks.
3159
3160         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3161         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
3162         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
3163         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
3164         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
3165         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
3166         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
3167         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
3168
3169 2007-10-02  Lars Knoll  <lars@trolltech.com>
3170
3171         Reviewed by Maciej.
3172
3173         Add support for eventSender.mouseMove to DRT.
3174         Fixes fast/css/hover-affects-child.html
3175
3176         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3177         (EventSender::mouseMoveTo):
3178
3179 2007-10-01  Mark Rowe  <mrowe@apple.com>
3180
3181         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3182
3183 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
3184
3185         Reviewed by Hyatt.
3186
3187         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
3188
3189         * Scripts/svn-apply:
3190         (gitdiff2svndiff): Ignore lines beginning with "new file".
3191         * Scripts/svn-unapply:
3192         (gitdiff2svndiff): Ditto.
3193
3194 2007-09-30  George Staikos  <staikos@kde.org>
3195
3196         Qt build fix (Mac OS X specific)
3197
3198         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
3199
3200 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
3201
3202         Reviewed by Mark.
3203
3204         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
3205         Remove Bakefiles from svn.
3206
3207         * GtkLauncher/Bakefiles.bkgen: Removed.
3208         * GtkLauncher/ENV: Removed.
3209         * GtkLauncher/gdklauncher.bkl: Removed.
3210         * GtkLauncher/mk: Removed.
3211         * Scripts/regenerate-makefiles: Removed.
3212
3213 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
3214
3215         Reviewed by John.
3216
3217         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
3218
3219         * Scripts/run-webkit-tests:
3220
3221 2007-09-26  Adam Roben  <aroben@apple.com>
3222
3223         Make not finding an installed WebKit non-fatal
3224
3225         What really matters is that we are able to load WebKit and its
3226         dependencies, not whether we think we've found an installed WebKit.
3227
3228         Reviewed by Sam.
3229
3230         * WebKitInitializer/WebKitInitializer.cpp:
3231         (getWebViewCLSID): Use new LOG_WARNING macro.
3232         (getInstalledWebKitDirectory): Ditto.
3233         (initializeWebKit): Don't die if we didn't find an installed WebKit,
3234         and use new macros.
3235         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
3236
3237 2007-09-26  Adam Roben  <aroben@apple.com>
3238
3239         Committed this file before saving it
3240
3241         * WebKitInitializer/debug_internal.vsprops:
3242
3243 2007-09-26  Adam Roben  <aroben@apple.com>
3244
3245         Load WebKit and its dependencies manually so they come from DllDirectory
3246
3247         I had to change WebKitInitializer to use malloc/free instead of
3248         new/delete to avoid pulling in WebKit (and its dependencies) early
3249         through use of fastMalloc.
3250
3251         Reviewed by Oliver.
3252
3253         * WebKitInitializer/WebKitInitializer.cpp:
3254         (getStringValue): Changed to use malloc/free.
3255         (getInstalledWebKitDirectory): Ditto.
3256         (initializeWebKit): Call SetDllDirectory first, then load all of
3257         WebKit's dependencies manually, finally followed by WebKit itself.
3258         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
3259         configuration to match our other projects.
3260         * WebKitInitializer/debug_internal.vsprops: Added.
3261
3262 2007-09-25  Adam Roben  <aroben@apple.com>
3263
3264         Actually define DEBUG/NDEBUG so that we load WebKit correctly
3265
3266         Rubberstamped by Sam.
3267
3268         * WebKitInitializer/WebKitInitializer.vcproj:
3269
3270 2007-09-25  Adam Roben  <aroben@apple.com>
3271
3272         Make DumpRenderTree delay-load its dependencies
3273
3274         This lets WebKitInitializer re-route the dependencies to be loaded out
3275         of the Safari installation directory.
3276
3277         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
3278         same thing), since we can't import the kCFAllocatorDefault symbol when
3279         delay-loading CoreFoundation.dll.
3280
3281         Rubberstamped by Sam.
3282
3283         * DumpRenderTree/win/DumpRenderTree.cpp:
3284         (runTest):
3285         (javaScriptThreads):
3286         * DumpRenderTree/win/DumpRenderTree.vcproj:
3287         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3288         (LayoutTestController::setWaitToDump):
3289
3290 2007-09-25  Adam Roben  <aroben@apple.com>
3291
3292         Pull ole32.lib into WebKitInitializer
3293
3294         Rubberstamped by Sam.
3295
3296         * WebKitInitializer/WebKitInitializer.vcproj:
3297
3298 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
3299
3300         Reviewed by Adam.
3301
3302         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
3303           LGPL'ed files contain incorrect FSF address
3304
3305         * Drosera/config.h:
3306
3307 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
3308
3309         Reviewed by Adam.
3310
3311         Make svn-apply and svn-unapply work with git-diff formatted patches.
3312
3313         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
3314         (gitdiff2svndiff): Added.
3315         * Scripts/svn-unapply: Ditto.
3316         (gitdiff2svndiff): Added.
3317
3318 2007-09-25  Adam Roben  <aroben@apple.com>
3319
3320         Pull advapi32.lib into WebKitInitializer
3321
3322         This is needed to get the registry functions we use.
3323
3324         Rubberstamped by Sam.
3325
3326         * WebKitInitializer/WebKitInitializer.vcproj:
3327
3328 2007-09-25  Adam Roben  <aroben@apple.com>
3329
3330         Add python and rsync to cygwin-downloader
3331
3332         Our build slaves need this, and it can't hurt for everyone else to
3333         have it, too.
3334
3335         Reviewed by Sam.
3336
3337         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
3338         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
3339
3340 2007-09-25  Adam Roben  <aroben@apple.com>
3341
3342         Add WebKitInitializer and use it in DumpRenderTree
3343
3344         WebKitInitializer is a static library that has one function,
3345         initializeWebKit(). This registers WebKit and sets up the DLL search
3346         path so that WebKit's dependencies that are installed with Safari can
3347         be found.
3348
3349         Reviewed by Sam.
3350
3351         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
3352         DumpRenderTree depend on it.
3353         * DumpRenderTree/win/DumpRenderTree.cpp:
3354         (initialize): Call initializeWebKit.
3355         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
3356         WebKitInitializer.lib.
3357         * WebKitInitializer/WebKitInitializer.cpp: Added.
3358         (getStringValue):
3359         (getWebViewCLSID):
3360         (getInstalledWebKitDirectory):
3361         (initializeWebKit):
3362         * WebKitInitializer/WebKitInitializer.h: Added.
3363         * WebKitInitializer/WebKitInitializer.vcproj: Added.
3364         * WebKitInitializer/debug.vsprops: Added.
3365         * WebKitInitializer/release.vsprops: Added.
3366
3367 2007-09-25  Adam Roben  <aroben@apple.com>
3368
3369         Make run-webkit-tests respect set-webkit-configuration
3370
3371         Reviewed by Sam.
3372
3373         * Scripts/run-webkit-tests: Initialize $configuration to whatever
3374         set-webkit-configuration was last set to.
3375
3376 2007-09-25  Mark Rowe  <mrowe@apple.com>
3377
3378         Rubber-stamped by Eric.
3379
3380         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
3381         This makes it possible to automate nightly builds for the feature-branch.
3382
3383 2007-09-25  Adam Roben  <aroben@apple.com>
3384
3385         A couple of fixes/enhancements to update-webkit-*-libs
3386
3387         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
3388         to tell update-webkit-support-libraries where it should find the
3389         WebKitSupportLibrary.zip file you downloaded.
3390
3391         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
3392         Windows-style path.
3393
3394         Reviewed by Sam.
3395
3396         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
3397         to $auxiliaryLibsURL and removed an irrelevant comment.
3398         * Scripts/update-webkit-support-libs:
3399
3400 2007-09-25  Adam Treat  <treat@kde.org>
3401
3402         Reviewed by Simon and Lars.
3403
3404         Refactors and cleans up Qt DRT member variable names, member variable
3405         initialization, style fixes and general code cleanup.
3406
3407         Adds queueReload slot to LayoutTestController that some tests require.
3408
3409         Subclasses QWebFrame to make sure that all frames have an associated
3410         LayoutTestController JS window object.
3411
3412         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
3413         aren't dumped twice.
3414
3415         EOF fixes.
3416
3417         Together, this patch fixes some 20+ layout tests in QtWebKit.
3418
3419         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3420         (WebCore::WebFrame::WebFrame):
3421         (WebCore::WebPage::WebPage):
3422         (WebCore::WebPage::createFrame):
3423         (WebCore::DumpRenderTree::DumpRenderTree):
3424         (WebCore::DumpRenderTree::open):
3425         (WebCore::DumpRenderTree::readStdin):
3426         (WebCore::DumpRenderTree::initJSObjects):
3427         (WebCore::DumpRenderTree::dump):
3428         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3429         (WebCore::DumpRenderTree::layoutTestController):
3430         (WebCore::DumpRenderTree::eventSender):
3431         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3432         (LayoutTestController::LayoutTestController):
3433         (LayoutTestController::reset):
3434         (LayoutTestController::maybeDump):
3435         (LayoutTestController::waitUntilDone):
3436         (LayoutTestController::notifyDone):
3437         (LayoutTestController::queueReload):
3438         (LayoutTestController::provisionalLoad):
3439         (EventSender::EventSender):
3440         (EventSender::mouseDown):
3441         (EventSender::mouseUp):
3442         (EventSender::mouseMoveTo):
3443         (EventSender::frameUnderMouse):
3444         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
3445         (LayoutTestController::isLoading):
3446         (LayoutTestController::setLoading):
3447         (LayoutTestController::dumpAsText):
3448         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
3449         (main):
3450
3451 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
3452
3453
3454         - Reverted an accidentally checked in file.
3455
3456         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
3457
3458 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
3459         Reviewed by Sam.
3460
3461         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
3462
3463         * DumpRenderTree/win/DumpRenderTree.vcproj:
3464         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3465
3466 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
3467
3468         Rubber stamped by Adam.
3469
3470         * GdkLauncher: Removed.
3471         * GdkLauncher/Bakefiles.bkgen: Removed.
3472         * GdkLauncher/ENV: Removed.
3473         * GdkLauncher/GdkLauncher.pro: Removed.
3474         * GdkLauncher/gdklauncher.bkl: Removed.
3475         * GdkLauncher/main.cpp: Removed.
3476         * GdkLauncher/mk: Removed.
3477         * GdkLauncher/simple.svg: Removed.
3478         * GdkLauncher/text.html: Removed.
3479         * GtkLauncher: Added.
3480         * GtkLauncher/GdkLauncher.pro: Removed.
3481         * GtkLauncher/GtkLauncher.pro: Added.
3482         * GtkLauncher/main.cpp:
3483         (updateWindowTitle):
3484         (main):
3485         * Scripts/build-webkit:
3486         * Scripts/regenerate-makefiles:
3487         * Scripts/run-javascriptcore-tests:
3488         * Scripts/run-launcher:
3489         * Scripts/run-webkit-tests:
3490         * Scripts/webkitdirs.pm:
3491
3492 2007-09-21  Timothy Hatcher  <timothy@apple.com>
3493
3494         Reviewed by Darin.
3495
3496         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
3497
3498         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
3499         This is tested by plugins/root-object-premature-delete-crash.html.
3500
3501         * DumpRenderTree/mac/ObjCController.m:
3502         (-[ObjCController accessStoredWebScriptObject]):
3503
3504 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
3505
3506         Reviewed by Oliver.
3507
3508         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
3509
3510         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
3511         (FrameLoadDelegate::FrameLoadDelegate):
3512
3513 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
3514
3515         Reviewed by Adam.
3516
3517         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
3518         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
3519
3520         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
3521         Now isQt() and isGdk() use global variables that are only set once.
3522
3523         An array of all the parameters is now given to build-dumprender which includes
3524         the platform on linux.
3525
3526         * Scripts/build-dumprendertree:
3527         * Scripts/run-webkit-tests:
3528         * Scripts/webkitdirs.pm:
3529
3530 2007-09-19  Adam Roben  <aroben@apple.com>
3531
3532         Rubberstamped by Hyatt.
3533
3534         * Spinneret: Removed.
3535
3536 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
3537
3538         Reviewed by David Kilzer.
3539
3540         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
3541
3542 2007-09-18  Sam Weinig  <sam@webkit.org>
3543
3544         Add JSRetainPtr.h #include to fix some builds.
3545
3546         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3547
3548 2007-09-18  Mike Hommey  <glandium@debian.org>
3549
3550         Reviewed by Adam.
3551
3552         * Scripts/prepare-ChangeLog:
3553         - Properly parse GECOS field.
3554         - Use git configuration for user name and email when appropriate.
3555
3556 2007-09-17  Sam Weinig  <sam@webkit.org>
3557
3558         Build fix.
3559
3560         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3561
3562 2007-09-17  Sam Weinig  <sam@webkit.org>
3563
3564         Reviewed by Adam Roben.
3565
3566         Share more code between mac and windows DRT.
3567             - GCController is now shared.
3568             - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
3569
3570         * DumpRenderTree/GCController.cpp:
3571         * DumpRenderTree/win/DumpRenderTree.cpp:
3572         * DumpRenderTree/win/DumpRenderTree.vcproj:
3573         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
3574         (FrameLoadDelegate::FrameLoadDelegate):
3575         (FrameLoadDelegate::~FrameLoadDelegate):
3576         (FrameLoadDelegate::windowScriptObjectAvailable):
3577         * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
3578         * DumpRenderTree/win/GCController.cpp: Removed.
3579         * DumpRenderTree/win/GCController.h: Removed.
3580         * DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp.
3581         (GCController::collect):
3582         (GCController::collectOnAlternateThread):
3583         (GCController::getJSObjectCount):
3584         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
3585         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
3586
3587 2007-09-17  Sam Weinig  <sam@webkit.org>
3588
3589         Reviewed by Adam Roben.
3590
3591         Begin sharing code between mac and windows DRT.
3592             - both now share LayoutTestController.h/cpp and implement platform dependant 
3593               operations in LayoutTestControllerMac/Win.
3594             - DumpRenderTree.h is now shared.
3595             - WorkQueue and WorkQueueItem are also shared.
3596
3597         * DumpRenderTree/DumpRenderTree.h:
3598         * DumpRenderTree/LayoutTestController.cpp:
3599         * DumpRenderTree/win/DumpRenderTree.cpp:
3600         (displayWebView):
3601         (dumpFrameScrollPosition):
3602         (dumpFramesAsText):
3603         (dump):
3604         (runTest):
3605         * DumpRenderTree/win/DumpRenderTree.h: Removed.
3606         * DumpRenderTree/win/DumpRenderTree.vcproj:
3607         * DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
3608         * DumpRenderTree/win/EditingDelegate.cpp: