02bd387869c07b28ddccb79ba34246e5569e9b01
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-11-12  Adam Roben  <aroben@apple.com>
2
3         Replace worldIDs with world objects
4
5         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
6         user scripts/stylesheets and isolated worlds
7
8         Reviewed by Sam Weinig.
9
10         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
11         (LayoutTestController::addUserScript):
12         (LayoutTestController::addUserStyleSheet):
13         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
14         (LayoutTestController::addUserScript):
15         (LayoutTestController::addUserStyleSheet):
16         Changed these functions to create a new WebJSWorld each time they're
17         called and to pass that world to WebKit.
18
19 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
20
21         Reviewed by Oliver Hunt.
22
23         need to implement aria tree roles
24         https://bugs.webkit.org/show_bug.cgi?id=31284
25
26         * DumpRenderTree/AccessibilityUIElement.cpp:
27         (disclosedRowAtIndexCallback):
28         (selectedRowAtIndexCallback):
29         (isEqualCallback):
30         (isAttributeSettableCallback):
31         (isActionSupportedCallback):
32         (disclosedByRowCallback):
33         (hierarchicalLevelCallback):
34         (AccessibilityUIElement::getJSClass):
35         * DumpRenderTree/AccessibilityUIElement.h:
36         (AccessibilityUIElement::isEqual):
37         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
38         (AccessibilityUIElement::hierarchicalLevel):
39         (AccessibilityUIElement::disclosedRowAtIndex):
40         (AccessibilityUIElement::selectedRowAtIndex):
41         (AccessibilityUIElement::disclosedByRow):
42         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
43         (AccessibilityUIElement::getChildAtIndex):
44         (AccessibilityUIElement::disclosedRowAtIndex):
45         (AccessibilityUIElement::selectedRowAtIndex):
46         (AccessibilityUIElement::titleUIElement):
47         (AccessibilityUIElement::parentElement):
48         (AccessibilityUIElement::disclosedByRow):
49         (AccessibilityUIElement::hierarchicalLevel):
50         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
51         (AccessibilityUIElement::hierarchicalLevel):
52         (AccessibilityUIElement::disclosedRowAtIndex):
53         (AccessibilityUIElement::selectedRowAtIndex):
54         (AccessibilityUIElement::disclosedByRow):
55
56 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
57
58         Reviewed by Darin Adler.
59
60         svn-apply can not handle git binary diffs
61         https://bugs.webkit.org/show_bug.cgi?id=26830
62
63         Support "literal" type git binary diffs.
64
65         * Scripts/VCSUtils.pm:
66         * Scripts/modules/scm_unittest.py:
67         * Scripts/svn-apply:
68
69 2009-11-11  Dmitry Titov  <dimich@chromium.org>
70
71         Not reviewed, removing duplicate entry for myself in committers.py.
72
73         * Scripts/modules/committers.py:
74
75 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
76
77         Reviewed by Darin Adler and Mark Rowe.
78
79         https://bugs.webkit.org/show_bug.cgi?id=31200
80         Tests in http/tests/security/mixedContent start to fail when new tests are added
81
82         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
83
84 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
85
86         Reviewed by Jan Alonzo.
87
88         Create, and display a window for the inspector, for inspector
89         tests.
90
91         Need to also show/hide the inspector window to avoid having
92         problems with code assuming it is realized
93         https://bugs.webkit.org/show_bug.cgi?id=31347
94
95         * DumpRenderTree/gtk/DumpRenderTree.cpp:
96         (webInspectorShowWindow):
97         (webInspectorCloseWindow):
98         (webInspectorInspectWebView):
99         (createWebView):
100
101 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
102
103         Unreviewed Qt buildbot fix.
104
105         My previous fix was wrong, so revert that change and fix it by
106         returning when the document of the frame has no document element.
107         Idea is borrowed from mac and win DRT.
108
109         * DumpRenderTree/qt/DumpRenderTree.cpp:
110         (WebCore::DumpRenderTree::dumpFramesAsText):
111
112 2009-11-11  Eric Seidel  <eric@webkit.org>
113
114         Reviewed byg Kenneth Rohde Christiansen.
115
116         Update Kenneth's committer record to include the email he
117         uses on lists.webkit.org.
118
119         * Scripts/modules/committers.py:
120
121 2009-11-11  Eric Seidel  <eric@webkit.org>
122
123         Reviewed by Gustavo Noronha Silva.
124
125         Several committers use separate email addresses for bugzilla and svn.webkit.org
126         https://bugs.webkit.org/show_bug.cgi?id=31364
127
128         Update records for existing committers to include email addresses
129         used in svn.webkit.org and lists.webkit.org.
130         Most committers use the same email address in all 3 places, but some use
131         separate addresses.  committers.py needs record of each of these addresses.
132
133         * Scripts/modules/committers.py:
134
135 2009-11-11  Eric Seidel  <eric@webkit.org>
136
137         No review, adding second email address for an existing committer.
138
139         Add Yong Li's second bugzilla account to his committer record.
140         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
141
142         * Scripts/modules/committers.py:
143
144 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
145
146         Reviewed by Simon Hausmann.
147
148         If the frame has no innerText don't append it, and
149         do not add a newline which breaks some cross platform
150         results.
151
152         * DumpRenderTree/qt/DumpRenderTree.cpp:
153         (WebCore::DumpRenderTree::dumpFramesAsText):
154
155 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
156
157         Reviewed by Simon Hausmann.
158
159         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
160
161         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
162         (webkit_test_plugin_new_instance):
163         (webkit_test_plugin_destroy_instance):
164         (webkit_test_plugin_destroy_stream):
165
166 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
167
168         Reviewed by Mark Rowe.
169
170         Implement the functionality needed by plugins/window-open.html
171
172         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
173         (webkit_test_plugin_new_instance):
174         (webkit_test_plugin_set_window):
175
176 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
177
178         Reviewed by Simon Hausmann.
179
180         [Qt] Force -graphicssystem raster and -style windows when running DRT
181
182         * DumpRenderTree/qt/main.cpp:
183         * Scripts/run-webkit-tests:
184
185 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
186
187         Reviewed by Simon Hausmann.
188
189         Compute correct library paths for Qt
190
191         * Scripts/webkitdirs.pm:
192
193 2009-11-10  Mark Rowe  <mrowe@apple.com>
194
195         Reviewed by Sam Weinig.
196
197         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
198
199         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
200         about the validity of the self-signed certificates used in the regression tests.  We would then add the
201         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
202         that had enabled frame load delegate logging this would result in extra log messages being generated,
203         causing the test to fail.
204
205         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
206         tests.
207
208         * DumpRenderTree/mac/DumpRenderTree.mm:
209         (dumpRenderTree):
210         * DumpRenderTree/mac/FrameLoadDelegate.mm:
211         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
212
213 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
214
215         Reviewed by Kenneth Rohde Christiansen.
216
217         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
218
219         * DumpRenderTree/qt/DumpRenderTree.cpp:
220         (WebCore::DumpRenderTree::DumpRenderTree):
221
222 2009-11-10  Philippe Normand  <pnormand@igalia.com>
223
224         Reviewed by Jan Alonzo.
225
226         [GTK] Remove WebSocket configuration from WebKitWebSettings
227         https://bugs.webkit.org/show_bug.cgi?id=31244
228
229         Follow-up of r50724. Don't set the enable-web-socket property
230         anymore.
231
232         * DumpRenderTree/gtk/DumpRenderTree.cpp:
233         (resetDefaultsToConsistentValues):
234
235 2009-11-10  Oliver Hunt  <oliver@apple.com>
236
237         Reviewed by Maciej Stachowiak.
238
239         Rename 3D Canvas related classes to use WebGL prefix
240         https://bugs.webkit.org/show_bug.cgi?id=29095
241
242         Checkin new version of do-webcore-rename used to do the WebGL type rename,
243         and upate webkitdirs script to new method of testing for WebGL.
244
245         * Scripts/do-webcore-rename:
246         * Scripts/webkitdirs.pm:
247
248 2009-11-09  Oliver Hunt  <oliver@apple.com>
249
250         Reviewed by Geoff Garen.
251
252         Make do-webcore-rename work with git.
253
254         * Scripts/do-webcore-rename:
255
256 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
257
258         Adding Kenneth to the reviewers list.
259
260         * Scripts/modules/committers.py:
261
262 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
263
264         Reviewed by Jan Alonzo.
265
266         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
267         https://bugs.webkit.org/show_bug.cgi?id=30482
268
269         LayoutTestControllerGtk now uses the exposed
270         Page::tabKeyCyclesThroughElements API
271
272         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
273         (LayoutTestController::setTabKeyCyclesThroughElements):
274
275 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
276
277         Reviewed by Holger Freyther.
278
279         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
280         This helps to pass the test case below. Also replaced hardcoded
281         code numbers with defined constants.
282         https://bugs.webkit.org/show_bug.cgi?id=31185
283         
284         Test: editing/undo/undo-deleteWord.html
285
286         * DumpRenderTree/qt/EventSenderQt.cpp:
287         (EventSender::keyDown):
288
289 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
290
291         Reviewed by Holger Freyther.
292
293         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
294         https://bugs.webkit.org/show_bug.cgi?id=31164
295
296         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
297
298         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
299         (LayoutTestController::processWork):
300
301 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
302
303         Reviewed by Holger Freyther.
304
305         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
306         https://bugs.webkit.org/show_bug.cgi?id=31158
307
308         By invoking a script queue'd by queueScript(), 'true' was beeing returned
309         always, which from WorkQueue prospective means that a load has been started
310         and the queue processing should stop and wait for the load to finish.
311         Spinning it off into a loading and a non-loading variants was the solution
312         adopted by Mac's DRT to work around this problem. The former keeps returning
313         'true' while the later executes the script synchronously and returns 'false'
314         making it possible to the WorkQueue to proceed right away.
315
316         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
317         (LayoutTestController::processWork):
318         (LayoutTestController::queueLoadingScript):
319         (LayoutTestController::queueNonLoadingScript):
320         * DumpRenderTree/qt/LayoutTestControllerQt.h:
321         * DumpRenderTree/qt/WorkQueueItem.h:
322         (LoadingScriptItem::LoadingScriptItem):
323         (LoadingScriptItem::invoke):
324         (NonLoadingScriptItem::NonLoadingScriptItem):
325         (NonLoadingScriptItem::invoke):
326
327 2009-11-07  Mark Rowe  <mrowe@apple.com>
328
329         Rubber-stamped by Cameron Zwarich.
330
331         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
332
333         * Scripts/commit-log-editor:
334
335 2009-11-07  Mark Rowe  <mrowe@apple.com>
336
337         Reviewed by Darin Adler.
338
339         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
340         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
341
342         Move logic for determining the name and email address to use in a ChangeLog entry from
343         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
344         whether the author of the patch matches committer, and therefore needs access to the
345         email address that would be used in a ChangeLog entry.
346
347         Based on a patch by Pierre d'Herbemont.
348
349         * Scripts/VCSUtils.pm:
350         * Scripts/commit-log-editor:
351         * Scripts/prepare-ChangeLog:
352         * Scripts/webkitdirs.pm:
353
354 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
355
356         Reviewed by Adam Barth.
357
358         Added functionality to the layout test plugin to invoke document.open and
359         window.open with default arguments. The associated webkit bug is
360         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
361         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
362         work in Chromium (V8) if there is no calling javascript context. To achieve this
363         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
364         for the window.open test case and in NPP_DestroyStream for the document.open test case.
365
366         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
367         (testDocumentOpen):
368         (testWindowOpen):
369         (pluginAllocate):
370         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
371         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
372         (NPP_New):
373         (NPP_SetWindow):
374         (NPP_DestroyStream):
375         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
376         (NPP_New):
377         (NPP_SetWindow):
378         (NPP_NewStream):
379         (NPP_DestroyStream):
380
381 2009-11-06  Eric Seidel  <eric@webkit.org>
382
383         Reviewed by Adam Barth.
384
385         bugzilla-tool crashed with exception
386         https://bugs.webkit.org/show_bug.cgi?id=31092
387
388         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
389
390 2009-11-04  Eric Seidel  <eric@webkit.org>
391
392         No review, just add a line which got left out of the patch uploaded for commit.
393
394         commit-queue is crashing when trying to reject patches after unknown failures
395         https://bugs.webkit.org/show_bug.cgi?id=31091
396
397         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
398
399 2009-11-04  Adam Roben  <aroben@apple.com>
400
401         Remove bogus else clause in bugzilla-tool
402
403         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
404         create-bug raises exception after entering bug description
405
406         Reviewed by David Kilzer.
407
408         * Scripts/bugzilla-tool:
409         (CreateBug): else clauses are only hit if no exception is raised, so
410         it makes no sense to try to re-raise the exception in an else clause.
411         The exception will automatically be re-raised if it doesn't match any
412         of the except clauses, so we don't have to do anything special here at
413         all to get the desired behavior.
414
415 2009-11-04  Eric Seidel  <eric@webkit.org>
416
417         Reviewed by David Kilzer.
418
419         svn-apply's fixChangeLogPatch function seems broken
420         https://bugs.webkit.org/show_bug.cgi?id=30683
421
422         Update fixChangeLogPatch to be able to handle patches which
423         don't start at line 1.
424         Add unit tests for svn-apply to scm_unittest.py.
425
426         * Scripts/VCSUtils.pm:
427         * Scripts/modules/scm_unittest.py:
428
429 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
430
431         Reviewed by Beth Dakin.
432
433         Need to implement ARIA role="combobox"
434         https://bugs.webkit.org/show_bug.cgi?id=31096
435
436         * DumpRenderTree/AccessibilityUIElement.cpp:
437         (showMenuCallback):
438         (getIsExpandedCallback):
439         (AccessibilityUIElement::getJSClass):
440         * DumpRenderTree/AccessibilityUIElement.h:
441         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
442         (AccessibilityUIElement::isExpanded):
443         (AccessibilityUIElement::showMenu):
444         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
445         (AccessibilityUIElement::isExpanded):
446         (AccessibilityUIElement::showMenu):
447         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
448         (AccessibilityUIElement::isSelected):
449         (AccessibilityUIElement::isExpanded):
450         (AccessibilityUIElement::showMenu):
451
452 2009-11-04  Eric Seidel  <eric@webkit.org>
453
454         Reviewed by Adam Barth.
455
456         commit-queue is crashing when trying to reject patches after unknown failures
457         https://bugs.webkit.org/show_bug.cgi?id=31091
458
459         * Scripts/bugzilla-tool:
460          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
461            so we have to find out what the current patch is by asking bugzilla again.
462          - Discovered that this code was also leaking file descriptors, so fixed that.
463
464 2009-11-04  Adam Roben  <aroben@apple.com>
465
466         Make run-webkit-tests work for the Debug_Internal Windows
467         configuration
468
469         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
470         suffix.
471
472         Fixes <http://webkit.org/b/31123>.
473
474         Reviewed by Sam Weinig.
475
476         * Scripts/run-webkit-tests: Don't add the _debug suffix in
477         Debug_Internal, either.
478
479 2009-11-04  Eric Seidel  <eric@webkit.org>
480
481         Reviewed by Adam Barth.
482
483         committers.py needs a way to store non-bugzilla email addresses
484         https://bugs.webkit.org/show_bug.cgi?id=31037
485
486         Make Committer and Reviewer constructors take a single email or a list of emails.
487         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
488         Expose reviewers(), used by validate-committer-lists on bug 30970.
489
490         * Scripts/modules/committers.py:
491         * Scripts/modules/committers_unittest.py: Added tests for the new code.
492
493 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
494
495         Reviewed by David Levin.
496
497         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
498         https://bugs.webkit.org/show_bug.cgi?id=27491
499
500         The test path determination logic is changed to handle websocket and websocket/ssl cases.
501         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
502
503         Functions to start or stop Web Socket servers are added.
504
505         * Scripts/run-webkit-tests:
506
507 2009-11-03  Eric Seidel  <eric@webkit.org>
508
509         No review, just changing wording of log message.
510
511         Change log string to say "failed" instead of "rejected"
512         when a commit fails due to an out of date checkout.
513         This makes grepping the commit-queue log for rejected patches easier.
514
515         * Scripts/bugzilla-tool:
516
517 2009-11-03  Eric Seidel  <eric@webkit.org>
518
519         No review, adding commonly known committers missing from the file.
520
521         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
522
523 2009-11-03  Eric Seidel  <eric@webkit.org>
524
525         No review, just sort-order cleanup.
526
527         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
528
529 2009-11-03  Stephen White  <senorblanco@chromium.org>
530
531         (Unreviewed).
532
533         Add myself to committers.py.
534
535         * Scripts/modules/committers.py:
536
537 2009-11-03  Robin Dunn  <robin@alldunn.com>
538
539         Reviewed by Kevin Ollviier.
540
541         Add packaging scripts for Debian-based Linux distros.
542         
543         https://bugs.webkit.org/show_bug.cgi?id=31075
544
545         * wx/packaging/build-debian-installer.py: Added.
546         * wx/packaging/debian: Added.
547
548 2009-11-03  Dan Bernstein  <mitz@apple.com>
549
550         Reviewed by Anders Carlsson and Beth Dakin.
551
552         https://bugs.webkit.org/show_bug.cgi?id=31070
553
554         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
555         destroyed, it executes the value of the 'ondestroy' parameter as a
556         script.
557
558         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
559         (pluginAllocate): Initialize onDestroy.
560         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
561         onDestroy.
562         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
563         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
564         specified.
565         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
566
567 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
568
569         Reviewed by Xan Lopez.
570
571         https://bugs.webkit.org/show_bug.cgi?id=31035
572         [GTK] some accessibility tests hitting assertion in debug builds
573
574         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
575
576         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
577         (AccessibilityController::rootElement):
578
579 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
580
581         Reviewed by Beth Dakin.
582
583         Support ARIA "tab" roles
584         https://bugs.webkit.org/show_bug.cgi?id=30842
585
586         * DumpRenderTree/AccessibilityUIElement.cpp:
587         * DumpRenderTree/AccessibilityUIElement.h:
588         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
589         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
590         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
591
592 2009-11-01  Eric Seidel  <eric@webkit.org>
593
594         Reviewed by David Levin.
595
596         buildbots should use --exit-after-N-failures
597         https://bugs.webkit.org/show_bug.cgi?id=30809
598
599         Make the bots exit after 20 failures to prevent never-ending
600         test runs where every test spends a minute crashing.
601
602         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
603
604 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
605
606         Reviewed by Eric Seidel.
607
608         Turn on warnings for QtWebKit for gcc
609         https://bugs.webkit.org/show_bug.cgi?id=30958
610
611         * DumpRenderTree/qt/main.cpp: 
612         (crashHandler): Mark function NO_RETURN
613
614 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
615
616         Adding myself to the committers list.
617
618         * Scripts/modules/committers.py:
619
620 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
621
622         Fix an issue that Adam noticed in DRT.
623
624         Reviewed by Darin Adler.
625
626         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
627         (AccessibilityUIElement::role):
628         Get the length of the role text, and create a buffer dynamically.
629
630 2009-10-30  Eric Seidel  <eric@webkit.org>
631
632         No review, rolling out r50105.
633         http://trac.webkit.org/changeset/50105
634
635         This commit was causing:
636         https://bugs.webkit.org/show_bug.cgi?id=30869
637         We'll re-implement the feature a different way.
638
639         * Scripts/bugzilla-tool:
640
641 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
642
643         Test for MSAA: Accessibility of headings is not correct
644
645         https://bugs.webkit.org/show_bug.cgi?id=30937
646
647         Reviewed by Adam Roben.
648
649         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
650         (AccessibilityUIElement::role):
651         Allow the role returned to be a BSTR.
652         (AccessibilityUIElement::description):
653         Fix a copy/paste error.
654
655 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
656
657         Test for MSAA: Accessibility of links is wrong
658
659         https://bugs.webkit.org/show_bug.cgi?id=30928
660
661         Reviewed by Darin Adler.
662
663         * DumpRenderTree/AccessibilityUIElement.cpp:
664         (getAccessibilityValueCallback):
665         Return the accessibility value.
666         (AccessibilityUIElement::getJSClass):
667         Added "accessibilityValue" value.
668
669         * DumpRenderTree/AccessibilityUIElement.h:
670
671         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
672         (AccessibilityUIElement::accessibilityValue):
673         Stubbed.
674
675         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
676         (AccessibilityUIElement::accessibilityValue):
677         Stubbed.
678
679         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
680         (AccessibilityUIElement::accessibilityValue):
681         Get the object's value, and return it as a JS string.
682
683 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
684
685         Fix typo in command name used by wx build system.
686
687         * wx/build/build_utils.py:
688
689 2009-10-30  Adam Barth  <abarth@webkit.org>
690
691         Reviewed by Darin Adler.
692
693         Patch v1 is a dumb default name for patches
694         https://bugs.webkit.org/show_bug.cgi?id=30952
695
696         Let's use "Patch" instead.
697
698         * Scripts/bugzilla-tool:
699
700 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
701
702         Unreviewed trivial buildfix.
703
704         [Qt] Buildfix for r50333.
705
706         * DumpRenderTree/qt/DumpRenderTree.pro:
707
708 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
709
710         Reviewed by Holger Freyther.
711
712         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
713         https://bugs.webkit.org/show_bug.cgi?id=30953
714
715         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
716         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
717         makes qt DRT to share this implementation (as gtk and mac ports do).
718
719         * DumpRenderTree/qt/DumpRenderTree.pro:
720         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
721         * DumpRenderTree/qt/WorkQueue.h: Removed.
722
723 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
724
725         Unreviewed potential buildbot fix.
726
727         Second try: Reset page history before running each test.
728
729         Apparently the QWebHistory::clear() keeps the current page
730         in history which is not what we want, so we not additionally
731         sets the history capacity to 0 (forces removing everything)
732         and then sets it back to its original value.
733
734         * DumpRenderTree/qt/DumpRenderTree.cpp:
735         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
736
737 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
738
739         Unreviewed potential buildbot fix.
740
741         Reset page history before running each test.
742
743         * DumpRenderTree/qt/DumpRenderTree.cpp:
744         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
745
746 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
747
748         Reviewed by Eric Seidel.
749
750         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
751
752         Bug 28420 -  Implement HTML5 <ruby> rendering
753         (https://bugs.webkit.org/show_bug.cgi?id=28420)
754
755         No new tests (no functional change).
756
757         * Scripts/build-webkit:
758
759 2009-10-29  Dan Bernstein  <mitz@apple.com>
760
761         Reviewed by Mark Rowe.
762
763         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
764         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
765         define it.
766
767         * Scripts/VCSUtils.pm:
768         * Scripts/svn-apply:
769         * Scripts/svn-unapply:
770
771 2009-10-29  Xan Lopez  <xlopez@igalia.com>
772
773         Reviewed by Gustavo Noronha.
774
775         Use the GTK+ main loop instead of rolling our own mini-version of
776         it.
777
778         * DumpRenderTree/gtk/DumpRenderTree.cpp:
779         (dump):
780         (runTest):
781         (webViewLoadFinished):
782
783 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
784
785         Reviewed by Oliver Hunt.
786
787         Implement the Qt version of DRT dumpBackForwardList().
788
789         * DumpRenderTree/qt/DumpRenderTree.cpp:
790         (WebCore::dumpHistoryItem):
791         (WebCore::DumpRenderTree::dumpBackForwardList):
792
793 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
794
795         Reviewed by Adam Roben.
796
797         Implement DRT functionality for Qt introduced in
798         r28690 and r28705.
799
800         - Implemented pathToLocalResource which exposes the functionality of
801         converting a given unix path to the correct location on Windows.
802         - Implemented a way to remove machine-dependent information from paths
803         in layout test results.
804
805         * DumpRenderTree/qt/DumpRenderTree.cpp:
806         (WebCore::urlSuitableForTestResult):
807         (WebCore::WebPage::javaScriptConsoleMessage):
808         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
809         (LayoutTestController::pathToLocalResource):
810         * DumpRenderTree/qt/LayoutTestControllerQt.h:
811
812 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
813
814         Adding myself to the committers list.
815
816         * Scripts/modules/committers.py:
817
818 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
819
820         Adding myself to the committers list.
821
822         * Scripts/modules/committers.py:
823
824 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
825
826         Reviewed by Jan Alonzo.
827
828         [GTK] API to start inspector for a WebView
829         https://bugs.webkit.org/show_bug.cgi?id=22551
830
831         Use the new inspector API to implement the LayoutTestController
832         interfaces used to test the inspector.
833
834         * DumpRenderTree/gtk/DumpRenderTree.cpp:
835         (webInspectorInspectWebView):
836         (createWebView):
837         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
838         (LayoutTestController::showWebInspector):
839         (LayoutTestController::closeWebInspector):
840         (LayoutTestController::evaluateInWebInspector):
841
842 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
843
844         Reviewed by Eric Seidel.
845
846         [Qt] WebFrame::counterValueForElementById must not be exposed
847         https://bugs.webkit.org/show_bug.cgi?id=30882
848
849         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
850         (LayoutTestController::counterValueForElementById):
851
852 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
853
854         Rubberstamped by Oliver Hunt.
855
856         Fix the warning:
857
858         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
859         declared with attribute warn_unused_result".
860
861         by actually checking the result. In the case it is null, an
862         error has occoured, so treat it as the other fatal errors.
863
864         * DumpRenderTree/qt/DumpRenderTree.cpp:
865         (WebCore::DumpRenderTree::initializeFonts):
866
867 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
868
869         Reviewed by Darin Adler.
870
871         Provide a way to get counter values with layoutTestContoller
872         https://bugs.webkit.org/show_bug.cgi?id=30555
873
874         Define layoutTestContoller.counterValueForElementById.
875
876         * DumpRenderTree/LayoutTestController.cpp:
877         (counterValueForElementByIdCallback):
878         (LayoutTestController::staticFunctions):
879         * DumpRenderTree/LayoutTestController.h:
880         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
881         (LayoutTestController::counterValueForElementById):
882
883 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
884
885         Rubberstamped by Oliver Hunt.
886
887         Change two methods to be internal for DRT use only.
888
889         Part of [Qt] Review all new API in Qt 4.6
890         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
891
892         * DumpRenderTree/qt/DumpRenderTree.cpp:
893         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
894         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
895         (LayoutTestController::whiteListAccessFromOrigin):
896
897 2009-10-27  Eric Seidel  <eric@webkit.org>
898
899         Reviewed by Adam Barth.
900
901         REGRESSION: svn-apply exits(1) when applying a patch with a file add
902         https://bugs.webkit.org/show_bug.cgi?id=30826
903
904         * Scripts/svn-apply:
905          - Add () around all system() calls.
906          - Use the correct system() == 0 or die instead of system() or die
907          - Add descriptive messages to all die statements.
908
909 2009-10-27  Steve Block  <steveblock@google.com>
910
911         Reviewed by NOBODY.
912
913         Adds steveblock@google.com to list of committers.
914
915         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
916
917 2009-10-27  Eric Seidel  <eric@webkit.org>
918
919         Reviewed by Adam Barth.
920
921         svn-apply can exit(0) even on patch failure
922         https://bugs.webkit.org/show_bug.cgi?id=29622
923
924         * Scripts/svn-apply:
925          - Add a bunch of "or die" statements, hopefully catching all
926            possible cases where failure could still exit(0).
927
928 2009-10-27  Eric Seidel  <eric@webkit.org>
929
930         Reviewed by Adam Barth.
931
932         svn-* scripts should share code through VCSUtils.pm
933         https://bugs.webkit.org/show_bug.cgi?id=30791
934
935         Just moving code into a shared location.
936
937         * Scripts/VCSUtils.pm:
938         * Scripts/prepare-ChangeLog:
939         * Scripts/resolve-ChangeLogs:
940         * Scripts/svn-apply:
941         * Scripts/svn-create-patch:
942         * Scripts/svn-unapply:
943         * Scripts/update-webkit:
944
945 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
946
947         Suppress a huge number of MSVC warnings when building wxWebKit.
948
949         * wx/build/settings.py:
950
951 2009-10-26  Eric Seidel  <eric@webkit.org>
952
953         No review, just adding Mike Belshe to the committers list.
954
955         * Scripts/modules/committers.py:
956
957 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
958
959         Reviewed by Darin Adler.
960
961         Make .rc files compile on Windows without depending on MFC headers
962         https://bugs.webkit.org/show_bug.cgi?id=30750
963
964         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
965         windows.h instead of afxres.h because it exists even when MFC is not 
966         installed, and is all that's needed here.
967
968         * FindSafari/FindSafari.rc: Ditto
969
970 2009-10-24  Eric Seidel  <eric@webkit.org>
971
972         Reviewed by Adam Barth.
973
974         bugzilla-tool post-diff should know how to mark commit-queue=?
975         https://bugs.webkit.org/show_bug.cgi?id=29202
976
977         * Scripts/bugzilla-tool:
978          - Add --commit-queue option to post-diff, post-commits and create-bug.
979         * Scripts/modules/bugzilla.py:
980          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
981          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
982
983 2009-10-23  Eric Seidel  <eric@webkit.org>
984
985         Reviewed by Adam Barth.
986
987         bugzilla-tool commit-queue does not notice modifications to committers.py
988         https://bugs.webkit.org/show_bug.cgi?id=30084
989
990         * Scripts/bugzilla-tool:
991          - Make commit-queue re-exec itself instead of using while(1).
992          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
993          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
994
995 2009-10-22  Eric Seidel  <eric@webkit.org>
996
997         Reviewed by Adam Barth.
998
999         commit-queue will get stuck on patches if land-patches terminates unexpectedly
1000         https://bugs.webkit.org/show_bug.cgi?id=30634
1001
1002         * Scripts/bugzilla-tool:
1003          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
1004          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
1005
1006 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
1007
1008         Reviewed by Eric Seidel.
1009
1010         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
1011
1012         https://bugs.webkit.org/show_bug.cgi?id=30763
1013
1014         * pywebsocket/mod_pywebsocket/__init__.py:
1015         * pywebsocket/mod_pywebsocket/dispatch.py:
1016         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
1017         * pywebsocket/mod_pywebsocket/standalone.py:
1018         * pywebsocket/setup.py:
1019         * pywebsocket/test/test_dispatch.py:
1020
1021 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
1022
1023         Reviewed by David Levin.
1024
1025         REGRESSION: 2 failures in run-webkit-unittests
1026         https://bugs.webkit.org/show_bug.cgi?id=30645
1027
1028         * Scripts/modules/cpp_style_unittest.py:
1029         Fixed a few test scenarios which apparently lost some spaces from 
1030         text literals.
1031
1032 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
1033
1034         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
1035
1036         * Scripts/webkitdirs.pm:
1037
1038 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
1039
1040         Reviewed by Darin Adler.
1041
1042         Unification of using null device in perl scripts.
1043         https://bugs.webkit.org/show_bug.cgi?id=30572
1044
1045         * Scripts/VCSUtils.pm:
1046         * Scripts/bisect-builds:
1047         * Scripts/resolve-ChangeLogs:
1048         * Scripts/run-iexploder-tests:
1049         * Scripts/run-jsc:
1050         * Scripts/run-mangleme-tests:
1051         * Scripts/run-webkit-tests:
1052         * Scripts/webkitdirs.pm:
1053         Using File::Spec->devnull() instead of hard coded /dev/null.
1054
1055 2009-10-26  Eric Seidel  <eric@webkit.org>
1056
1057         Reviewed by Holger Freyther.
1058
1059         Reviewers are missing from committers.py
1060         https://bugs.webkit.org/show_bug.cgi?id=30733
1061
1062         * Scripts/modules/committers.py:
1063
1064 2009-10-23  Eric Seidel  <eric@webkit.org>
1065
1066         No review, only adding Alice to the list of reviewers.
1067
1068         * Scripts/modules/committers.py:
1069
1070 2009-10-23  Eric Seidel  <eric@webkit.org>
1071
1072         Reviewed by Eric Carlson.
1073
1074         fast/media/mq-transform-02.html failed on Leopard Commit Bot
1075         https://bugs.webkit.org/show_bug.cgi?id=30700
1076
1077         * DumpRenderTree/mac/DumpRenderTree.mm:
1078         (resetDefaultsToConsistentValues): Update QuickTime version check.
1079
1080 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
1081
1082         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
1083         character measurement APIs that are private on Tiger.
1084
1085         * wx/build/settings.py:
1086
1087 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
1088
1089         Reviewed by NOBODY (build fix).
1090         Build fix following bug #30696.
1091
1092         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1093         (LayoutTestController::evaluateScriptInIsolatedWorld):
1094
1095 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
1096
1097         Reviewed by Sam Weinig & Geoff Garen.
1098
1099         https://bugs.webkit.org/show_bug.cgi?id=30696
1100         Enable isolated-worlds tests on mac.
1101
1102         Add private interface for DRT to invoke execution in a given world.
1103
1104         * DumpRenderTree/LayoutTestController.cpp:
1105         (evaluateScriptInIsolatedWorldCallback):
1106         (LayoutTestController::staticFunctions):
1107         * DumpRenderTree/LayoutTestController.h:
1108         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1109         (LayoutTestController::evaluateScriptInIsolatedWorld):
1110         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1111         (LayoutTestController::evaluateScriptInIsolatedWorld):
1112
1113 2009-10-21  Eric Seidel  <eric@webkit.org>
1114
1115         Reviewed by Adam Barth.
1116
1117         bugzilla-tool's "patch failed to download an apply" error should give more information
1118         https://bugs.webkit.org/show_bug.cgi?id=30632
1119
1120         * Scripts/modules/scm.py:
1121          - Use the common run_command method instead of custom POpen code.
1122          - Make run_command know how to take pipes as input.
1123         * Scripts/modules/scm_unittest.py:
1124          - Add new tests to cover change.
1125          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
1126
1127 2009-10-21  Kent Tamura  <tkent@chromium.org>
1128
1129         Unreviewed.  Adding myself to the committers list.
1130
1131         * Scripts/modules/committers.py:
1132
1133 2009-10-21  Robin Dunn  <robin@alldunn.com>
1134
1135         Reviewed by Kevin Ollivier.
1136
1137         Update the Windows installer builder to work with Vista / Win 7 and with git.
1138         
1139         https://bugs.webkit.org/show_bug.cgi?id=30649
1140
1141         * wx/build/build_utils.py:
1142         * wx/packaging/build-mac-installer.py:
1143         * wx/packaging/build-win-installer.py:
1144         * wx/packaging/wxWebKitInstaller.iss.in:
1145
1146 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
1147
1148         Reviewed by Gustavo Noronha.
1149
1150         [GTK] Added conditional code to avoid using
1151         gdk_window_get_root_coords if we do not have a gtk+ release newer
1152         than 2.17.3.
1153         https://bugs.webkit.org/show_bug.cgi?id=30636
1154
1155         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
1156
1157 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
1158
1159         Reviewed by Eric Seidel.
1160
1161         [Qt] Added dummy implementation for keepWebHistory()
1162         https://bugs.webkit.org/show_bug.cgi?id=30592
1163
1164         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1165         (LayoutTestController::keepWebHistory):
1166         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1167
1168 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
1169
1170         Reviewed by Xan Lopez.
1171
1172         [GTK] Fixed the double click condition, it is not double click if
1173         we move in just in one direction.
1174         https://bugs.webkit.org/show_bug.cgi?id=30636
1175
1176         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
1177
1178 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
1179
1180         Reviewed by Xan Lopez.
1181
1182         [GTK] Initialize the events completly before emitting them.
1183         https://bugs.webkit.org/show_bug.cgi?id=30633
1184
1185         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
1186
1187 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
1188
1189         wx build fix. Fix for when linking using --as-needed with gcc.
1190
1191         * wx/browser/wscript:
1192
1193 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
1194
1195         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
1196         to support all the features used by CURL backend.
1197         
1198         * wx/build/settings.py:
1199         * wx/install-unix-extras:
1200
1201 2009-10-20  Anton Muhin  <antonm@chromium.org>
1202
1203         Reviewed by Adam Barth.
1204
1205         Add {ager,antonm,yurys}@chromium.org into committers.py
1206         https://bugs.webkit.org/show_bug.cgi?id=30560
1207
1208         * Scripts/modules/committers.py:
1209
1210 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1211
1212         Reviewed by Tor Arne Vestbø.
1213
1214         Make the Netscape Test plugin available to the Qt launcher.
1215
1216         * Scripts/run-launcher:
1217
1218 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
1219
1220         Reviewed by David Levin.
1221
1222         Removed WebSocket runtime settings.
1223         https://bugs.webkit.org/show_bug.cgi?id=29896
1224
1225         WebSocket runtime configuration is supported by chromium/v8 only.
1226
1227         * DumpRenderTree/mac/DumpRenderTree.mm:
1228         (resetDefaultsToConsistentValues):
1229         * DumpRenderTree/win/DumpRenderTree.cpp:
1230         (resetDefaultsToConsistentValues):
1231
1232 2009-10-19  Nate Chapin  <japhet@chromium.org>
1233
1234         Reviewed by Adam Barth.
1235
1236         Add testFail() to test plugin so we can test our handling of a
1237         plugin invoke call returning false.
1238
1239         https://bugs.webkit.org/show_bug.cgi?id=30239
1240
1241         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
1242         (pluginInvoke):
1243         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
1244
1245 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
1246
1247         Reviewed by Gustavo Noronha.
1248
1249         Enable DOM pasting when running layout tests.
1250
1251         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1252         (resetDefaultsToConsistentValues):
1253
1254 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1255
1256         Reviewed by Simon Hausmann.
1257
1258         Use the setPreferredContentsSize method instead
1259         of setFixedContentsSize, as the method has been renamed.
1260
1261         * DumpRenderTree/qt/DumpRenderTree.cpp:
1262         (WebCore::DumpRenderTree::open):
1263         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1264         (LayoutTestController::setFixedContentsSize):
1265
1266 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
1267
1268         Reviewed by Dan Bernstein.
1269
1270         https://bugs.webkit.org/show_bug.cgi?id=30456
1271         Fixes for new Debug_All Windows build configuration.
1272
1273         * DumpRenderTree/win/DumpRenderTree.cpp:
1274         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
1275         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
1276
1277 2009-10-16  Eric Seidel  <eric@webkit.org>
1278
1279         Reviewed by Adam Barth.
1280
1281         commit-queue status bot should list which buildbot is blocking the queue
1282         https://bugs.webkit.org/show_bug.cgi?id=30452
1283
1284         Add new methods and testing.
1285
1286         * Scripts/bugzilla-tool:
1287         * Scripts/modules/buildbot.py:
1288         * Scripts/modules/buildbot_unittest.py:
1289
1290 2009-10-16  Eric Seidel  <eric@webkit.org>
1291
1292         Reviewed by Adam Barth.
1293
1294         run-webkit-tests fails when CWD is not inside a WebKit checkout
1295         https://bugs.webkit.org/show_bug.cgi?id=30451
1296
1297         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
1298         * Scripts/modules/scm_unittest.py:
1299           - Remove use of original_path (we don't need to restore the CWD).
1300           - Don't use '.' to find the webkit checkout, use __file__ instead.
1301
1302 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
1303
1304         Reviewed by Adam Roben.
1305
1306         Add a Debug_All configuration to build entire stack as debug.
1307         Change Debug_Internal to:
1308         - stop using _debug suffix for all WebKit/Safari binaries
1309         - not use _debug as a DLL naming suffix
1310         - use non-debug C runtime lib.
1311
1312         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
1313         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
1314         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
1315         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1316         Add missing debug.vsprops inherited property sheet.
1317         Add Debug_All configuration.
1318         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
1319         * WinLauncher/WinLauncher.vcproj:
1320         Removed extraneous definitions inherited from vsprops.
1321         Add Debug_All configuration.
1322
1323 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
1324
1325         Reviewed by David Levin.
1326
1327         check-webkit-style is wrong about indent checking in namespaces
1328         in header files and a few other things
1329         https://bugs.webkit.org/show_bug.cgi?id=30362
1330
1331         The few other things include:
1332         + check-webkit-style does not require spaces around the equal sign
1333           inside 'if' statements and around binary operators that take 
1334           numeric literals.
1335         + check-webkit-style reports false errors for the / operator
1336           when part of a filename in the #include directive.
1337
1338         * Scripts/modules/cpp_style.py:
1339         Improved indentation checking and space checking around
1340         binary operators. While the checks are still not perfect,
1341         they are clearly better than before.
1342         * Scripts/modules/cpp_style_unittest.py:
1343         Added test cases for the newly supported checks and modified old
1344         test cases to match the new guidelines
1345
1346 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
1347
1348         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
1349
1350         * wx/build/settings.py:
1351
1352 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
1353
1354         Reviewed by David Levin.
1355
1356         Add mod_pywebsocket to test Web Sockets.
1357         http://code.google.com/p/pywebsocket/
1358         https://bugs.webkit.org/show_bug.cgi?id=27490
1359
1360         * pywebsocket/COPYING: Added.
1361         * pywebsocket/MANIFEST.in: Added.
1362         * pywebsocket/README: Added.
1363         * pywebsocket/example/echo_client.py: Added.
1364         * pywebsocket/example/echo_wsh.py: Added.
1365         * pywebsocket/mod_pywebsocket/__init__.py: Added.
1366         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
1367         * pywebsocket/mod_pywebsocket/handshake.py: Added.
1368         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
1369         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
1370         * pywebsocket/mod_pywebsocket/standalone.py: Added.
1371         * pywebsocket/mod_pywebsocket/util.py: Added.
1372         * pywebsocket/setup.py: Added.
1373         * pywebsocket/test/config.py: Added.
1374         * pywebsocket/test/mock.py: Added.
1375         * pywebsocket/test/run_all.py: Added.
1376         * pywebsocket/test/test_dispatch.py: Added.
1377         * pywebsocket/test/test_handshake.py: Added.
1378         * pywebsocket/test/test_mock.py: Added.
1379         * pywebsocket/test/test_msgutil.py: Added.
1380         * pywebsocket/test/test_util.py: Added.
1381         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
1382         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
1383         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
1384         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
1385         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
1386         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
1387         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
1388         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
1389
1390 2009-10-15  James Robinson  <jamesr@google.com>
1391
1392         Reviewed by David Levin.
1393
1394         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
1395
1396         https://bugs.webkit.org/show_bug.cgi?id=30426
1397
1398         * Scripts/modules/cpp_style.py:
1399         * Scripts/modules/cpp_style_unittest.py:
1400
1401 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
1402
1403         Reviewed by Adam Roben.
1404
1405         Fixes <http://webkit.org/b/30411>.
1406         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
1407         
1408         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
1409         building Chromium.
1410
1411         * Scripts/pdevenv:
1412
1413 2009-10-15  Robin Dunn  <robin@alldunn.com>
1414
1415         Reviewed by Kevin Ollivier.
1416
1417         Add Mac package building scripts for wx.
1418         
1419         https://bugs.webkit.org/show_bug.cgi?id=30405
1420
1421         * wx/build/build_utils.py:
1422         * wx/build/settings.py:
1423         * wx/packaging/build-mac-installer.py: Added.
1424
1425 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
1426
1427         Reviewed by Gustavo Noronha.
1428
1429         Enable Web Sockets support when running layout tests.
1430
1431         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1432         (resetDefaultsToConsistentValues):
1433
1434 2009-10-15  Xan Lopez  <xlopez@igalia.com>
1435
1436         Reviewed by Gustavo Noronha.
1437
1438         Need to initialize event.button.button, since in most cases a
1439         button number is not passed as an argument.
1440
1441         * DumpRenderTree/gtk/EventSender.cpp:
1442         (mouseDownCallback):
1443         (mouseUpCallback):
1444
1445 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
1446
1447         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
1448         the OS if none was explicitly set.
1449
1450         * wx/build/settings.py:
1451
1452 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
1453
1454         Reviewed by Timothy Hatcher.
1455
1456         Web Inspector: enable developers extras within inspector layout tests.
1457
1458         https://bugs.webkit.org/show_bug.cgi?id=30014
1459
1460         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1461         (LayoutTestController::showWebInspector):
1462         (LayoutTestController::closeWebInspector):
1463         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1464         (LayoutTestController::showWebInspector):
1465         (LayoutTestController::closeWebInspector):
1466
1467 2009-10-14  José Millán Soto  <jmillan@igalia.com>
1468
1469         Reviewed by Jan Alonzo.
1470
1471         GtkLauncher is using a deprecated signal
1472         https://bugs.webkit.org/show_bug.cgi?id=30364
1473
1474         Modified GtkLauncher to use notify::title signal instead of
1475         deprecated title-changed signal
1476
1477         * GtkLauncher/main.c:
1478         (notify_title_cb):
1479         (create_browser):
1480
1481 2009-10-14  Brady Eidson  <beidson@apple.com>
1482
1483         Reviewed by Sam Weinig.
1484
1485         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
1486         1 - Disables WebHistory
1487         2 - Doesn't make sense in that context anyway.
1488
1489         * DumpRenderTree/win/DumpRenderTree.cpp:
1490         (createWebViewAndOffscreenWindow):
1491
1492 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
1493
1494         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
1495         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
1496
1497         * wx/build/settings.py:
1498         * wx/install-unix-extras:
1499
1500 2009-10-14  Brady Eidson  <beidson@apple.com>
1501
1502         Reviewed by Sam Weinig.
1503
1504         WebKit Win API should provide a delegate interface for global history.
1505         https://bugs.webkit.org/show_bug.cgi?id=29905
1506
1507         * DumpRenderTree/LayoutTestController.cpp:
1508         (LayoutTestController::LayoutTestController):
1509         * DumpRenderTree/LayoutTestController.h:
1510         (LayoutTestController::dumpHistoryDelegateCallbacks):
1511         (LayoutTestController::setDumpHistoryDelegateCallbacks):
1512                 
1513         * DumpRenderTree/win/DumpRenderTree.cpp:
1514         (shouldLogHistoryDelegates):
1515         (runTest):
1516         (createWebViewAndOffscreenWindow):
1517         (main):
1518         * DumpRenderTree/win/DumpRenderTree.vcproj:
1519         
1520         Add the IWebHistoryDelegate to DRT Windows:
1521         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
1522         (wstringFromBSTR):
1523         (HistoryDelegate::HistoryDelegate):
1524         (HistoryDelegate::~HistoryDelegate):
1525         (HistoryDelegate::QueryInterface):
1526         (HistoryDelegate::AddRef):
1527         (HistoryDelegate::Release):
1528         (HistoryDelegate::didNavigateWithNavigationData):
1529         (HistoryDelegate::didPerformClientRedirectFromURL):
1530         (HistoryDelegate::didPerformServerRedirectFromURL):
1531         (HistoryDelegate::updateHistoryTitle):
1532         (HistoryDelegate::populateVisitedLinksForWebView):
1533         * DumpRenderTree/win/HistoryDelegate.h: Added.
1534
1535         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1536         (LayoutTestController::removeAllVisitedLinks):
1537
1538 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
1539
1540         Reviewed by Simon Hausmann.
1541
1542         [Qt] Implement support for setPOSIXLocale on Qt.
1543         https://bugs.webkit.org/show_bug.cgi?id=30268 
1544  
1545         * DumpRenderTree/qt/DumpRenderTree.cpp:
1546         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1547         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1548         (LayoutTestController::setPOSIXLocale):
1549         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1550
1551 2009-10-13  Stephanie Lewis  <slewis@apple.com>
1552
1553         Unreviewed, adding myself to reviewers list.
1554
1555         * Scripts/modules/committers.py:
1556
1557 2009-10-13  Stephanie Lewis  <slewis@apple.com>
1558
1559         Reviewed by Mark Rowe.
1560
1561         Fix null assignment so root tests work again.
1562
1563         * Scripts/webkitdirs.pm:
1564
1565 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1566
1567         Reviewed by Simon Hausmann.
1568
1569         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
1570         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
1571         This is done in preparation of implementing missing features in DRT.
1572         No functionality changes made yet.
1573
1574         * DumpRenderTree/qt/DumpRenderTree.cpp:
1575         * DumpRenderTree/qt/DumpRenderTree.pro:
1576         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
1577         (EventSender::EventSender):
1578         (EventSender::mouseDown):
1579         (EventSender::mouseUp):
1580         (EventSender::mouseMoveTo):
1581         (EventSender::leapForward):
1582         (EventSender::keyDown):
1583         (EventSender::contextClick):
1584         (EventSender::scheduleAsynchronousClick):
1585         (EventSender::frameUnderMouse):
1586         * DumpRenderTree/qt/EventSenderQt.h: Added.
1587         (EventSender::clearKillRing):
1588         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
1589         (LayoutTestController::LayoutTestController):
1590         (LayoutTestController::reset):
1591         (LayoutTestController::processWork):
1592         (LayoutTestController::maybeDump):
1593         (LayoutTestController::waitUntilDone):
1594         (LayoutTestController::notifyDone):
1595         (LayoutTestController::windowCount):
1596         (LayoutTestController::clearBackForwardList):
1597         (LayoutTestController::dumpEditingCallbacks):
1598         (LayoutTestController::dumpResourceLoadCallbacks):
1599         (LayoutTestController::queueBackNavigation):
1600         (LayoutTestController::queueForwardNavigation):
1601         (LayoutTestController::queueLoad):
1602         (LayoutTestController::queueReload):
1603         (LayoutTestController::queueScript):
1604         (LayoutTestController::provisionalLoad):
1605         (LayoutTestController::timerEvent):
1606         (LayoutTestController::encodeHostName):
1607         (LayoutTestController::decodeHostName):
1608         (LayoutTestController::setJavaScriptProfilingEnabled):
1609         (LayoutTestController::setFixedContentsSize):
1610         (LayoutTestController::setPrivateBrowsingEnabled):
1611         (LayoutTestController::setPopupBlockingEnabled):
1612         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
1613         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1614         (LayoutTestController::numberOfActiveAnimations):
1615         (LayoutTestController::disableImageLoading):
1616         (LayoutTestController::dispatchPendingLoadRequests):
1617         (LayoutTestController::setDatabaseQuota):
1618         (LayoutTestController::clearAllDatabases):
1619         (LayoutTestController::whiteListAccessFromOrigin):
1620         (LayoutTestController::waitForPolicyDelegate):
1621         (LayoutTestController::overridePreference):
1622         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
1623         (LayoutTestController::isLoading):
1624         (LayoutTestController::setLoading):
1625         (LayoutTestController::shouldDumpAsText):
1626         (LayoutTestController::shouldDumpBackForwardList):
1627         (LayoutTestController::shouldDumpChildrenAsText):
1628         (LayoutTestController::shouldDumpDatabaseCallbacks):
1629         (LayoutTestController::shouldDumpStatusCallbacks):
1630         (LayoutTestController::shouldWaitUntilDone):
1631         (LayoutTestController::canOpenWindows):
1632         (LayoutTestController::shouldDumpTitleChanges):
1633         (LayoutTestController::waitForPolicy):
1634         (LayoutTestController::dumpAsText):
1635         (LayoutTestController::dumpChildFramesAsText):
1636         (LayoutTestController::dumpDatabaseCallbacks):
1637         (LayoutTestController::dumpStatusCallbacks):
1638         (LayoutTestController::setCanOpenWindows):
1639         (LayoutTestController::dumpBackForwardList):
1640         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
1641         (LayoutTestController::display):
1642         (LayoutTestController::dumpTitleChanges):
1643         (LayoutTestController::dumpSelectionRect):
1644         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
1645         (TextInputController::TextInputController):
1646         (TextInputController::doCommand):
1647         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
1648         * DumpRenderTree/qt/WorkQueue.cpp:
1649         * DumpRenderTree/qt/WorkQueue.h:
1650         * DumpRenderTree/qt/WorkQueueItem.h:
1651         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
1652         (findFrameNamed):
1653         (LoadItem::invoke):
1654         (ReloadItem::invoke):
1655         (ScriptItem::invoke):
1656         (BackForwardItem::invoke):
1657         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
1658         * DumpRenderTree/qt/jsobjects.h:
1659
1660 2009-10-13  Dmitry Titov  <dimich@chromium.org>
1661
1662         Not reviewed, adding myself to the list of reviewers.
1663
1664         * Scripts/modules/committers.py:
1665
1666 2009-10-13  Anders Carlsson  <andersca@apple.com>
1667
1668         Reviewed by Sam Weinig.
1669
1670         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
1671
1672         Make the private browsing mode testable by the test plug-in.
1673         
1674         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1675         (pluginGetProperty):
1676         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1677         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1678         (NPP_New):
1679         (NPP_SetValue):
1680
1681 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
1682
1683         No review, just adding self to the list of reviewers.
1684
1685         * Scripts/modules/committers.py:
1686
1687 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
1688
1689         Reviewed by Adam Roben.
1690
1691         Web Inspector: Use proper web view in inspector layout
1692         tests for windows.
1693
1694         https://bugs.webkit.org/show_bug.cgi?id=30298
1695
1696         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1697         (LayoutTestController::showWebInspector):
1698         (LayoutTestController::closeWebInspector):
1699         (LayoutTestController::evaluateInWebInspector):
1700
1701 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
1702
1703         Reviewed by Sam Weinig.
1704
1705         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
1706         https://bugs.webkit.org/show_bug.cgi?id=29841
1707
1708         * DumpRenderTree/mac/DumpRenderTree.mm:
1709         (resetDefaultsToConsistentValues):
1710         * DumpRenderTree/win/DumpRenderTree.cpp:
1711         (resetDefaultsToConsistentValues):
1712
1713 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
1714
1715         Reviewed by Dimitri Glazkov.
1716
1717         Chromium Port - Windows
1718         https://bugs.webkit.org/show_bug.cgi?id=29969
1719
1720         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
1721         * Scripts/webkitdirs.pm:
1722
1723 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
1724
1725         Reviewed by Darin Adler.
1726
1727         jsc scripts cleanup and Qt/GTK fix
1728         https://bugs.webkit.org/show_bug.cgi?id=30288
1729
1730         Duplicated jscPath() moved to webkitdirs.pm.
1731         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
1732         Configuration added (release/debug) to path for Qt-port on Windows.
1733
1734         * Scripts/run-javascriptcore-tests:
1735         * Scripts/run-jsc:
1736         * Scripts/run-sunspider:
1737         * Scripts/sunspider-compare-results:
1738         * Scripts/webkitdirs.pm:
1739
1740 2009-10-11  Adam Barth  <abarth@webkit.org>
1741
1742         Unreviewed.  Add Collin to committers.py.
1743
1744         * Scripts/modules/committers.py:
1745
1746 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
1747
1748         wx build fix, add bindings to source/include dirs now that there are sources there.
1749
1750         * wx/build/settings.py:
1751
1752 2009-10-09  Mark Rowe  <mrowe@apple.com>
1753
1754         Reviewed by Brady Eidson.
1755
1756         Enable plug-in halting in DumpRenderTree.
1757
1758         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
1759         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
1760
1761         * DumpRenderTree/mac/DumpRenderTree.mm:
1762         (resetDefaultsToConsistentValues):
1763         * DumpRenderTree/mac/UIDelegate.mm:
1764         (-[UIDelegate webView:shouldHaltPlugin:]):
1765
1766 2009-10-08  Brady Eidson  <beidson@apple.com>
1767
1768         Reviewed by Dan Bernstein.
1769
1770         Ask the History Delegate to populate the visited links hash.
1771         <rdar://problem/7285293> and https://webkit.org/b/29904
1772
1773         Add the ability for LayoutTestController to clear all visited links.
1774         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
1775
1776         * DumpRenderTree/LayoutTestController.cpp:
1777         (LayoutTestController::LayoutTestController):
1778         (removeAllVisitedLinksCallback):
1779         (LayoutTestController::staticFunctions):
1780         * DumpRenderTree/LayoutTestController.h:
1781         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1782         (LayoutTestController::removeAllVisitedLinks):
1783
1784         * DumpRenderTree/mac/HistoryDelegate.mm:
1785         (-[HistoryDelegate populateVisitedLinksForWebView:]):
1786
1787         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1788         (LayoutTestController::removeAllVisitedLinks):
1789         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1790         (LayoutTestController::removeAllVisitedLinks):
1791         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1792         (LayoutTestController::removeAllVisitedLinks):
1793
1794
1795 2009-10-08  Daniel Bates  <dbates@webkit.org>
1796
1797         Reviewed by Adam Roben.
1798
1799         https://bugs.webkit.org/show_bug.cgi?id=30175
1800         
1801         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
1802         the OLE drag-and-drop return value like the function it emulates. Currently, 
1803         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
1804         whether the drag-and-drop operation was successful or was cancelled.
1805         
1806         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
1807         return value according to whether the drop operation was successful or not.
1808
1809         * DumpRenderTree/win/EventSender.cpp:
1810         (doMouseUp): Added parameter oleDragAndDropReturnValue.
1811         (replaySavedEvents): Ditto.
1812         * DumpRenderTree/win/EventSender.h:
1813         * DumpRenderTree/win/UIDelegate.cpp:
1814         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
1815
1816 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
1817
1818         Reviewed by Xan Lopez.
1819
1820         [GTK] Added support for a parameter setting the button that was
1821         pressed in the mouseDown function.
1822         https://bugs.webkit.org/show_bug.cgi?id=30220
1823
1824         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
1825
1826 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
1827
1828         Reviewed by Xan Lopez.
1829
1830         [GTK] Added a line to the bottom of the expected result to match
1831         the output of the test.
1832         https://bugs.webkit.org/show_bug.cgi?id=30220
1833
1834         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
1835         expected.txt:
1836
1837 2009-10-08  Adam Roben  <aroben@apple.com>
1838
1839         Use QueryInterface to get IWebInspectorPrivate
1840
1841         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
1842         accessed in a more standard way
1843
1844         Reviewed by John Sullivan and Tim Hatcher.
1845
1846         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1847         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
1848         by calling IWebViewPrivate::inspector, then use QueryInterface to get
1849         to the IWebInspectorPrivate interface.
1850
1851 2009-10-07  Adam Roben  <aroben@apple.com>
1852
1853         Implement DRT support for origin whitelisting
1854
1855         Fixes <http://webkit.org/b/30185>.
1856
1857         Reviewed by Eric Seidel.
1858
1859         * DumpRenderTree/win/DumpRenderTree.cpp:
1860         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
1861         whitelist, to match Mac DRT.
1862         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1863         (LayoutTestController::whiteListAccessFromOrigin): Call through to
1864         IWebViewPrivate::whiteListAccessFromOrigin.
1865
1866 2009-10-07  Brady Eidson  <beidson@apple.com>
1867
1868         Reviewed by Darin Adler.
1869
1870         Send title changes to the global history delegate.
1871         <rdar://problem/7285293> and https://webkit.org/b/29904
1872
1873         * DumpRenderTree/mac/HistoryDelegate.mm:
1874         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
1875
1876 2009-10-07  Adam Barth  <abarth@webkit.org>
1877
1878         Unreviewed.  Remove some folks from committers.py who were listed on
1879         the WebKit Team wiki page but who weren't actually listed as commit+.
1880         At some point, we should coorelate this list with the committers
1881         mailing list.
1882
1883         * Scripts/modules/committers.py:
1884
1885 2009-10-07  Adam Barth  <abarth@webkit.org>
1886
1887         Unreviewed.  Import a bunch of committers from the WebKit Team page on
1888         the wiki into committers.py.
1889
1890         * Scripts/modules/committers.py:
1891
1892 2009-10-07  Adam Barth  <abarth@webkit.org>
1893
1894         Unreviewed.  Added Aaron Boodman to committers.py.
1895
1896         * Scripts/modules/committers.py:
1897
1898 2009-10-07  Evan Martin  <evan@chromium.org>
1899
1900         Reviewed by Darin Adler.
1901
1902         Add API to LayoutTestController for re/setting the system locale.
1903         https://bugs.webkit.org/show_bug.cgi?id=18994
1904
1905         * DumpRenderTree/LayoutTestController.cpp:
1906         (setLocaleCallback):
1907         (LayoutTestController::staticFunctions):
1908         (LayoutTestController::setLocale):
1909         * DumpRenderTree/LayoutTestController.h:
1910
1911 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
1912
1913         Reviewed by Jan Alonzo.
1914
1915         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
1916         https://bugs.webkit.org/show_bug.cgi?id=29689
1917
1918         Build fix by adding -lfontconfig for DumpRenderTree.
1919
1920         * GNUmakefile.am:
1921
1922 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
1923
1924         Reviewed by Simon Hausmann.
1925
1926         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
1927
1928         * Scripts/run-webkit-tests:
1929
1930 2009-10-07  Xan Lopez  <xlopez@igalia.com>
1931
1932         Reviewed by Gustavo Noronha.
1933
1934         "delete" in EventSender is the backspace key, not the delete one.
1935
1936         * DumpRenderTree/gtk/EventSender.cpp:
1937         (keyDownCallback):
1938
1939 2009-10-07  Xan Lopez  <xlopez@igalia.com>
1940
1941         Reviewed by Gustavo Noronha.
1942
1943         getChildrenWithRange expects as last parameter the end index, not
1944         the length of the range. Correct this and clarify the variable
1945         names to reflect how the code works.
1946
1947         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1948         (AccessibilityUIElement::getChildrenWithRange):
1949         (AccessibilityUIElement::getChildAtIndex):
1950
1951 2009-10-06  Mark Rowe  <mrowe@apple.com>
1952
1953         Reviewed by Simon Fraser.
1954
1955         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
1956
1957         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
1958         the fact we have already changed the working directory to the top of the open source tree.
1959
1960 2009-10-06  Julie Parent  <jparent@chromium.org>
1961
1962         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
1963         rather than my committer email.
1964
1965         * Scripts/modules/committers.py:
1966
1967 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
1968
1969         Reviewed by Eric Seidel.
1970
1971         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
1972
1973         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
1974         it after each layout test as it should do, making the DRT dump additional output
1975         for all of the subsequent layout tests.
1976
1977         * DumpRenderTree/qt/jsobjects.cpp:
1978         (LayoutTestController::reset):
1979
1980 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
1981
1982         Reviewed by Simon Hausmann.
1983
1984         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
1985         fast/dom/assign-to-window-status.html test, which is passing as a result.
1986
1987         https://bugs.webkit.org/show_bug.cgi?id=30127
1988
1989         * DumpRenderTree/qt/DumpRenderTree.cpp:
1990         (WebCore::DumpRenderTree::DumpRenderTree):
1991         (WebCore::DumpRenderTree::statusBarMessage):
1992         * DumpRenderTree/qt/DumpRenderTree.h:
1993         * DumpRenderTree/qt/jsobjects.h:
1994         (LayoutTestController::shouldDumpStatusCallbacks):
1995         (LayoutTestController::dumpStatusCallbacks):
1996
1997 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
1998
1999         Reviewed by Simon Hausmann.
2000
2001         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
2002         ignores the argument indicating which mouse button to trigger.
2003         https://bugs.webkit.org/show_bug.cgi?id=30048
2004
2005         This affects the fast/events/mouse-click-events.html layout test.
2006
2007         * DumpRenderTree/qt/jsobjects.cpp:
2008         (EventSender::mouseDown):
2009         (EventSender::mouseUp):
2010         * DumpRenderTree/qt/jsobjects.h:
2011
2012 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
2013
2014         Reviewed by Simon Hausmann.
2015
2016         [Qt] Fix the EventSender::keyDown() implementation
2017         https://bugs.webkit.org/show_bug.cgi?id=30043
2018
2019         It should post both a key press event and a key release event,
2020         just like other ports do.
2021
2022         * DumpRenderTree/qt/jsobjects.cpp:
2023         (EventSender::keyDown):
2024
2025 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
2026
2027         wx build fix. Add jpeg to the list of libs to link against.
2028
2029         * wx/build/settings.py:
2030
2031 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
2032
2033         Reviewed by Simon Hausmann.
2034
2035         [Qt] EventSender::keyDown() cannot send function-key events.
2036         https://bugs.webkit.org/show_bug.cgi?id=30044
2037
2038         This affects the fast/events/keydown-function-keys.html layout test.
2039
2040         * DumpRenderTree/qt/jsobjects.cpp:
2041         (EventSender::keyDown):
2042
2043 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
2044
2045         Added --wx-compiler-prefix waf option to allow building wxWebKit with
2046         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
2047
2048         * wx/build/settings.py:
2049         * wx/build/wxpresets.py:
2050
2051 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
2052
2053         Reviewed by Timothy Hatcher.
2054
2055         Web Inspector: add testing harness for Web Inspector.
2056
2057         https://bugs.webkit.org/show_bug.cgi?id=30010
2058
2059         * DumpRenderTree/LayoutTestController.cpp:
2060         (showWebInspectorCallback):
2061         (closeWebInspectorCallback):
2062         (evaluateInWebInspectorCallback):
2063         (LayoutTestController::staticFunctions):
2064         * DumpRenderTree/LayoutTestController.h:
2065         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2066         (LayoutTestController::showWebInspector):
2067         (LayoutTestController::closeWebInspector):
2068         (LayoutTestController::evaluateInWebInspector):
2069         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2070         (LayoutTestController::showWebInspector):
2071         (LayoutTestController::closeWebInspector):
2072         (LayoutTestController::evaluateInWebInspector):
2073         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2074         (LayoutTestController::showWebInspector):
2075         (LayoutTestController::closeWebInspector):
2076         (LayoutTestController::evaluateInWebInspector):
2077         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2078         (LayoutTestController::showWebInspector):
2079         (LayoutTestController::closeWebInspector):
2080         (LayoutTestController::evaluateInWebInspector):
2081
2082 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2083
2084         Reviewed by Ariyha Hidayat.
2085
2086         Pass arguments to system() as a string instead of array
2087
2088         When passed as an array entries with a space fail to translate
2089         to two arguments to the child process, so instead of manually
2090         splitting all the entries in @buildArgs we pass the whole thing
2091         as a string instead.
2092
2093         * Scripts/webkitdirs.pm:
2094
2095 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
2096
2097         Reviewed by David Levin.
2098
2099         check-webkit-style misses whitespace errors for operators:
2100         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
2101         https://bugs.webkit.org/show_bug.cgi?id=30021
2102
2103         * Scripts/modules/cpp_style.py:
2104         Added the operators mentioned above to the same list as == and !=.
2105
2106 2009-10-02  Julie Parent  <jparent@chromium.org>
2107
2108         Unreviewed.
2109
2110         Adding myself and Ojan Vafai as committers, because we are committers.
2111
2112         * Scripts/modules/committers.py:
2113
2114 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
2115
2116         Reviewed by Adam Roben.
2117
2118         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
2119         this will help the patch merging process when TryBots are used.
2120
2121         * Scripts/svn-create-patch:
2122
2123 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
2124
2125         Reviewed by Simon Hausmann.
2126
2127         [Qt] Implement layoutTestController.overridePreference().
2128         https://bugs.webkit.org/show_bug.cgi?id=29970
2129
2130         * DumpRenderTree/qt/DumpRenderTree.cpp:
2131         (WebCore::WebPage::WebPage):
2132         (WebCore::WebPage::resetSettings):
2133         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2134         * DumpRenderTree/qt/jsobjects.cpp:
2135         (LayoutTestController::reset):
2136         (LayoutTestController::setPrivateBrowsingEnabled):
2137         (LayoutTestController::setPopupBlockingEnabled):
2138         (LayoutTestController::overridePreference):
2139         * DumpRenderTree/qt/jsobjects.h:
2140
2141 2009-10-01  Chris Marrin  <cmarrin@apple.com>
2142
2143         Reviewed by Oliver Hunt.
2144
2145         Turn on ENABLE_3D_CANVAS in TOT
2146         https://bugs.webkit.org/show_bug.cgi?id=29906
2147
2148         * Scripts/build-webkit:
2149
2150 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2151
2152         Rubberstamped by Simon Hausmann.
2153
2154         Enable HTTP tests for Qt
2155
2156         * Scripts/run-webkit-tests:
2157
2158 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
2159
2160         Reviewed by Dimitri Glazkov.
2161
2162         build-webkit --chromium now also works on cygwin.
2163
2164         https://bugs.webkit.org/show_bug.cgi?id=29973
2165
2166         * Scripts/webkitdirs.pm:
2167
2168 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
2169
2170         Reviewed by Simon Hausmann.
2171
2172         [Qt] Don't use TCmalloc in DumpRenderTree
2173         https://bugs.webkit.org/show_bug.cgi?id=27029
2174
2175         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
2176
2177         * DumpRenderTree/qt/DumpRenderTree.pro:
2178
2179 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
2180
2181         Reviewed by Simon Hausmann.
2182
2183         [Qt] Implement eventSender.scheduleAsynchronousClick().
2184
2185         https://bugs.webkit.org/show_bug.cgi?id=29931
2186
2187         * DumpRenderTree/qt/jsobjects.cpp:
2188         (EventSender::scheduleAsynchronousClick):
2189         * DumpRenderTree/qt/jsobjects.h:
2190
2191 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
2192
2193         Reviewed by Simon Hausmann.
2194
2195         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
2196         fast/events/open-window-from-another-frame.html from the Skipped list.
2197
2198         https://bugs.webkit.org/show_bug.cgi?id=29930
2199
2200         * DumpRenderTree/qt/jsobjects.cpp:
2201         (LayoutTestController::setPopupBlockingEnabled):
2202         * DumpRenderTree/qt/jsobjects.h:
2203
2204 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
2205
2206         Unreviewed.
2207
2208         Added myself to the list of committers.
2209
2210         * Scripts/modules/committers.py:
2211
2212 2009-09-30  Eric Seidel  <eric@webkit.org>
2213
2214         No review, just adding Geoff to the list of reviewers.
2215
2216         * Scripts/modules/committers.py:
2217
2218 2009-09-30  Dan Bernstein  <mitz@apple.com>
2219
2220         Reviewed by Sam Weinig.
2221
2222         Added the WebKit Layout Tests fonts that are referenced in
2223         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
2224
2225         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
2226         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
2227
2228 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
2229
2230         Reviewed by David Kilzer.
2231
2232         Make sunspider scripts work on Windows platform.
2233         https://bugs.webkit.org/show_bug.cgi?id=29656
2234
2235         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
2236         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
2237         * Scripts/webkitdirs.pm: currentPerlPath() added.
2238
2239 2009-09-29  Brady Eidson  <beidson@apple.com>
2240
2241         Rubberstamped by Dan Bernstein.
2242
2243         Fix license and some sorting in new files.
2244
2245         * DumpRenderTree/mac/HistoryDelegate.h:
2246         * DumpRenderTree/mac/HistoryDelegate.mm:
2247
2248 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
2249
2250         Reviewed by David Kilzer.
2251
2252         Fixed how error codes are handled.
2253         https://bugs.webkit.org/show_bug.cgi?id=29898
2254
2255         * Scripts/update-webkit:
2256         * Scripts/update-webkit-chromium:
2257
2258 2009-09-29  Brady Eidson  <beidson@apple.com>
2259
2260         Reviewed by John Sullivan.
2261
2262         Updated way-out-of-date sorting throughout the dump methods/flags.
2263
2264         * DumpRenderTree/LayoutTestController.cpp:
2265         (LayoutTestController::LayoutTestController):
2266         (dumpAsPDFCallback):
2267         (dumpAsTextCallback):
2268         (dumpFrameLoadCallbacksCallback):
2269         (dumpResourceLoadCallbacksCallback):
2270         (LayoutTestController::staticFunctions):
2271
2272         * DumpRenderTree/LayoutTestController.h:
2273         (LayoutTestController::dumpAsText):
2274         (LayoutTestController::setDumpAsText):
2275         (LayoutTestController::dumpFrameLoadCallbacks):
2276         (LayoutTestController::setDumpFrameLoadCallbacks):
2277         (LayoutTestController::dumpSelectionRect):
2278         (LayoutTestController::setDumpSelectionRect):
2279         (LayoutTestController::dumpSourceAsWebArchive):
2280         (LayoutTestController::setDumpSourceAsWebArchive):
2281         (LayoutTestController::dumpStatusCallbacks):
2282         (LayoutTestController::setDumpStatusCallbacks):
2283         (LayoutTestController::dumpTitleChanges):
2284         (LayoutTestController::setDumpTitleChanges):
2285         (LayoutTestController::dumpWillCacheResponse):
2286         (LayoutTestController::setDumpWillCacheResponse):
2287
2288 2009-09-29  Brady Eidson  <beidson@apple.com>
2289
2290         Reviewed by John Sullivan.
2291
2292         WebKit Mac API should provide a delegate interface for global history.
2293         <rdar://problem/7042773> and https://webkit.org/b/29904
2294
2295         Adding the dumping of global history delegate callbacks.
2296
2297         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2298
2299         Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
2300         * DumpRenderTree/mac/DumpRenderTree.mm:
2301         (createWebViewAndOffscreenWindow):
2302         (allocateGlobalControllers):
2303         (shouldLogFrameLoadDelegates):
2304         (shouldLogHistoryDelegates):
2305         (runTest):
2306
2307         Dump history delegate callbacks:
2308         * DumpRenderTree/mac/HistoryDelegate.h: Added.
2309         * DumpRenderTree/mac/HistoryDelegate.mm: Added.
2310         (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
2311         (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
2312         (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
2313
2314 2009-09-29  Daniel Bates  <dbates@webkit.org>
2315
2316         Reviewed by Adam Roben.
2317
2318         https://bugs.webkit.org/show_bug.cgi?id=28902
2319         
2320         Fixes an issue where the drop effect returned by Window Dump Render Tree 
2321         was always DROPEFFECT_NONE (since it was hard coded to do so).
2322         
2323         This patch corrects this issue by determining the actual drop effect 
2324         performed by the corresponding drag-and-drop operation so that we can 
2325         return it.
2326
2327         * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
2328         (DraggingInfo::DraggingInfo):
2329         (DraggingInfo::performedDropEffect): Added method.
2330         (DraggingInfo::setPerformedDropEffect): Added method.
2331         * DumpRenderTree/win/EventSender.cpp:
2332         (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
2333         Moved delete draggingInfo to UIDelegate::doDragDrop.
2334         * DumpRenderTree/win/UIDelegate.cpp:
2335         (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
2336
2337 2009-09-29  Dan Bernstein  <mitz@apple.com>
2338
2339         Reviewed by Adam Roben.
2340
2341         Remove copying of unnecessary or nonexistent files from the ImageDiff
2342         post-build event.
2343
2344         * DumpRenderTree/win/ImageDiff.vcproj:
2345
2346 2009-09-29  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
2347
2348         Reviewed by David Kilzer.
2349
2350         [Qt] Make build-webkit script work on Windows
2351         https://bugs.webkit.org/show_bug.cgi?id=29802
2352
2353         * Scripts/run-webkit-tests:
2354         * Scripts/webkitdirs.pm:
2355          - Removed unnecessary -p switch for mkdir on Windows.
2356          - Use canonical path, which uses slashes or backslashes depends on platform.
2357          - isWindows() only test for Windows and not for Cyqwin.
2358
2359 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2360
2361         Reviewed by Simon Hausmann.
2362
2363         Fix time measurement in build-webkit after refactoring done in r48853.
2364
2365         * Scripts/build-webkit:
2366
2367 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2368
2369         Reviewed by Tor Arne Vestbø.
2370
2371         [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.
2372         This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.
2373
2374         * DumpRenderTree/qt/DumpRenderTree.cpp:
2375         (WebCore::WebPage::WebPage):
2376
2377 2009-09-29  Jakub Wieczorek  <faw217@gmail.com>
2378
2379         Reviewed by Simon Hausmann.
2380
2381         [Qt] Implement eventSender.contextClick().
2382         https://bugs.webkit.org/show_bug.cgi?id=29821
2383
2384         * DumpRenderTree/qt/jsobjects.cpp:
2385         (EventSender::contextClick):
2386         * DumpRenderTree/qt/jsobjects.h:
2387
2388 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
2389
2390         Reviewed by Eric Seidel.
2391
2392         Add experimentalWebSocketsEnabled in WebPreferences.
2393         https://bugs.webkit.org/show_bug.cgi?id=28941
2394
2395         * DumpRenderTree/mac/DumpRenderTree.mm:
2396         (resetDefaultsToConsistentValues):
2397         * DumpRenderTree/win/DumpRenderTree.cpp:
2398         (resetDefaultsToConsistentValues):
2399
2400 2009-09-28  Yaar Schnitman  <yaar@chromium.org>
2401
2402         Reviewed by David Kilzer.
2403
2404         Integrated chromium port building into webkit tools update-webkit and
2405         build-webkit.
2406
2407         https://bugs.webkit.org/show_bug.cgi?id=29749
2408
2409         * Scripts/build-webkit: When --chromium is specified, will build
2410           the chromium port (currently only Mac is supported).
2411         * Scripts/update-webkit: When --chromium is specified, delegates to
2412           update-webkit-chromium.
2413         * Scripts/webkitdirs.pm: Added chromium specific defs.
2414         * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch
2415           chromium port's dependencies and update its project files.
2416
2417 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
2418
2419         Unreviewed.
2420
2421         Add myself to list of committers.
2422
2423         * Scripts/modules/committers.py:
2424
2425 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
2426
2427         Reviewed by Darin Adler.
2428
2429         run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
2430         https://bugs.webkit.org/show_bug.cgi?id=29771
2431
2432         * Scripts/run-webkit-tests:
2433
2434 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
2435
2436         Reviewed by Simon Hausmann.
2437
2438         [Qt] Implement layoutTestController.waitForPolicyDelegate.
2439         https://bugs.webkit.org/show_bug.cgi?id=25037
2440
2441         * DumpRenderTree/qt/DumpRenderTree.cpp:
2442         (WebCore::WebPage::acceptNavigationRequest):
2443         * DumpRenderTree/qt/DumpRenderTree.pro:
2444         * DumpRenderTree/qt/jsobjects.cpp:
2445         (LayoutTestController::reset):
2446         (LayoutTestController::notifyDone):
2447         (LayoutTestController::waitForPolicyDelegate):
2448         * DumpRenderTree/qt/jsobjects.h:
2449         (LayoutTestController::waitForPolicy):
2450
2451 2009-09-26  David Kilzer  <ddkilzer@apple.com>
2452
2453         <http://webkit.org/b/29764> mark-bug-fixed: add -o|--open switch
2454
2455         Reviewed by Eric Seidel.
2456
2457         The -o|--open switch uses the open(1) command on Mac OS X to
2458         open the bug URL in the default web browser.  If there are
2459         similar mechanisms on other platforms, they may be added later.
2460
2461         * Scripts/mark-bug-fixed:
2462         (MarkBugFixed.__init__): Added -o|--open switch to list of parse
2463         options.
2464         (MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
2465         code into main() and extracted prompting code into
2466         _prompt_user_for_correctness().
2467         (MarkBugFixed._open_bug_in_web_browser): Added.
2468         (MarkBugFixed._prompt_user_for_correctness): Added.
2469         (MarkBugFixed.main): Added logging code from
2470         _determine_bug_id_and_svn_revision().  Added code to call
2471         _open_bug_in_web_browser() if the switch is set.  Added code to
2472         call _prompt_user_for_correctness() when needed.
2473         * Scripts/modules/bugzilla.py:
2474         (Bugzilla.short_bug_url_for_bug_id): Added.
2475
2476 2009-09-26  David Kilzer  <ddkilzer@apple.com>
2477
2478         svn-unapply and svn-apply don't work when used outside multiple svn working directories
2479
2480         <http://webkit.org/b/29744>
2481         <rdar://problem/7252905>
2482
2483         Reviewed by Eric Seidel.
2484
2485         Some users have a workflow where svn-create-patch, svn-apply and
2486         svn-unapply are used outside of multiple svn working
2487         directories.  Instead of aborting the scripts in these cases,
2488         print a warning and assume that Subversion is being used.
2489
2490         * Scripts/VCSUtils.pm:
2491         (determineVCSRoot): Call warn() instead of die() if both isGit()
2492         and isSVN() initially return false.  Set $VCSUtils::isSVN to 1
2493         to enforce the assumption about Subversion, then return
2494         determineSVNRoot().
2495         * Scripts/svn-apply: Switch to using isGit() and isSVN() from
2496         VCSUtils.pm.  They both already cache their values and checking
2497         here is redundant since determineVCSRoot() is called later.
2498
2499 2009-09-26  Zan Dobersek  <zandobersek@gmail.com>
2500
2501         Reviewed by Gustavo Noronha.
2502
2503         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
2504         https://bugs.webkit.org/show_bug.cgi?id=29689
2505
2506         Load test fonts through FontConfig before each test.
2507         This ensures a more proper rendering of the tests.
2508
2509         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2510         (initializeFonts):
2511         (runTest):
2512         (main):
2513         * DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf.
2514         * GNUmakefile.am:
2515
2516 2009-09-25  David Kilzer  <ddkilzer@apple.com>
2517
2518         <http://webkit.org/b/29718> mark-bug-fixed: add -u|--update-only switch
2519
2520         Reviewed by Eric Seidel.
2521
2522         * Scripts/mark-bug-fixed:
2523         (MarkBugFixed.__init__): Added -u|--update-only switch to list
2524         of parse options.
2525         (MarkBugFixed.main): When -u|--update-only is specified, add a
2526         comment to the bug without marking it Resolved/Fixed.
2527
2528 2009-09-25  Darin Adler  <darin@apple.com>
2529
2530         Reviewed by Geoffrey Garen.
2531
2532         * Scripts/prepare-ChangeLog: Leave files from the script-tests directory
2533         out, just as we do for the resources directory.
2534
2535 2009-09-25  Adam Barth  <abarth@webkit.org>
2536
2537         Unreviewed.  Added Tony to committers.py because he's a
2538         committer now.
2539
2540         * Scripts/modules/committers.py:
2541
2542 2009-09-25  Eric Seidel  <eric@webkit.org>
2543
2544         Reviewed by Simon Fraser.
2545
2546         REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
2547         https://bugs.webkit.org/show_bug.cgi?id=28624
2548
2549         Disable hardware compositing on Leopard for versions of QuickTime 7.6.4 and older.
2550
2551         * DumpRenderTree/mac/DumpRenderTree.mm:
2552         (resetDefaultsToConsistentValues):
2553
2554 2009-09-25  Eric Seidel  <eric@webkit.org>
2555
2556         Reviewed by Adam Barth.
2557
2558         commit-queue should auto-retry patches which fail to commit due to out of date files
2559         https://bugs.webkit.org/show_bug.cgi?id=28316
2560
2561         * Scripts/bugzilla-tool:
2562          - Handle new CheckoutNeedsUpdate exception.
2563         * Scripts/modules/logging_unittest.py:
2564          - Call the ScriptError constructor correctly (this test had regressed).
2565         * Scripts/modules/scm.py:
2566          - Added the ability to define custom error handlers for run_command
2567            and added a commit_error_handler which throws CheckoutNeedsUpdate
2568            instead of ScriptError.
2569          - Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible.
2570         * Scripts/modules/scm_unittest.py:
2571          - Added tests of new error handlers.
2572
2573 2009-09-25  Eric Seidel  <eric@webkit.org>
2574
2575         Reviewed by Adam Barth.
2576
2577         commit-queue should give better feedback when failing a patch
2578         https://bugs.webkit.org/show_bug.cgi?id=29316
2579
2580         * Scripts/bugzilla-tool:
2581          - Update ScriptError uses to the new constructor format.
2582          - Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output
2583            so that we can print to both stdout as well as an output buffer for error reporting.
2584          - Update run_and_throw_if_fail to use teed output so that it can report the "output" as part of ScriptError.
2585          - Use e.message_with_output() when failing a patch (this is the real fix here).
2586            I also removed use of "This patch will require manual commit." as that's not always true.
2587          - Add missing word "bug" from log message.
2588         * Scripts/modules/scm.py:
2589          - Make ScriptError save a bunch more data so that error messages can be nicer.
2590          - Update ScriptError callers.
2591
2592 2009-09-24  John Gregg  <johnnyg@google.com>
2593
2594         Reviewed by Eric Seidel.
2595
2596         Enable switch for notifications (experimental) in Page Settings
2597         https://bugs.webkit.org/show_bug.cgi?id=28930
2598
2599         Now that desktop notifications are controlled by run-time switch,
2600         set that switch to true for DumpRenderTree.
2601
2602         * DumpRenderTree/mac/DumpRenderTree.mm:
2603         (resetDefaultsToConsistentValues):
2604         * DumpRenderTree/win/DumpRenderTree.cpp:
2605         (resetDefaultsToConsistentValues):
2606         * DumpRenderTree/win/UIDelegate.cpp:
2607         (UIDelegate::QueryInterface):
2608
2609 2009-09-24  Kevin Ollivier  <kevino@theolliviers.com>
2610
2611         wx build fix. SnowLeopard fixes for Mac dependencies.
2612
2613         * wx/build/build_utils.py:
2614         * wx/build/settings.py:
2615         * wx/install-unix-extras:
2616
2617 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2618
2619         Reviewed by Oliver Hunt.
2620
2621         Add support for DRT to send mouse wheel events.
2622
2623         https://bugs.webkit.org/show_bug.cgi?id=29348
2624         [Gtk] Scrollwheel on horizontal scrollbars should slide horizontally
2625
2626         * DumpRenderTree/gtk/EventSender.cpp:
2627         (mouseWheelToCallback):
2628
2629 2009-09-17  Eric Seidel  <eric@webkit.org>
2630
2631         Reviewed by David Levin.
2632
2633         commit-queue needs web-based status reporting
2634         https://bugs.webkit.org/show_bug.cgi?id=29307
2635
2636         Add a first-pass web-based status for the commit-queue.
2637         The bot is currently reachable at:
2638         http://webkit-commit-queue.appspot.com/
2639
2640         * CommitQueueStatus/app.yaml: Added.
2641          - Application description file required by App Engine.
2642         * CommitQueueStatus/filters/__init__.py: Added.
2643          - Required by python to treat 'filters' as a module.
2644         * CommitQueueStatus/filters/webkit_extras.py: Added.
2645          - Support for turning 'bug 123' and 'patch 123' into links.
2646            This lets us use plain text strings in our logs yet display nice HTML (help prevent XSS attacks on the page).
2647         * CommitQueueStatus/index.html: Added.
2648         * CommitQueueStatus/index.yaml: Added.
2649          - Some auto-generated file from app engine.
2650         * CommitQueueStatus/queue_status.py: Added.
2651          - The core logic of this bot.  We could eventually split this file out into pieces.
2652         * CommitQueueStatus/stylesheets/main.css: Added.
2653          - Some basic lame-o CSS to make the page look less awful.
2654         * CommitQueueStatus/update_status.html: Added.
2655          - The form that the commit-queue (or a human) can use to update the status.
2656         * Scripts/bugzilla-tool:
2657          - Add some very basic update_status calls.
2658         * Scripts/modules/statusbot.py: Added.
2659          - Knows how to post to the CommitQueueStatus web application.
2660
2661 2009-09-24  David Kilzer  <ddkilzer@apple.com>
2662
2663         <http://webkit.org/b/29712> mark-bug-fixed: add -m|--comment switch
2664
2665         Reviewed by Adam Roben.
2666
2667         * Scripts/mark-bug-fixed:
2668         (MarkBugFixed.__init__): Added -m|--comment switch to list of
2669         parse options.
2670         (MarkBugFixed.main): When specified, prepend comment from
2671         -m|--comment command-line switch to the bug comment.
2672
2673 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2674
2675         Reviewed by Jan Alonzo.
2676
2677         [GTK] DRT must display window instead of just realizing, to enable synthesizing events correctly
2678         https://bugs.webkit.org/show_bug.cgi?id=29693
2679
2680         Show the window, to be able to synthesize events correctly.
2681
2682         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2683         (runTest):
2684         (main):
2685
2686 2009-09-24  Oliver Hunt  <oliver@apple.com>
2687
2688         Reviewed by NOBODY(rollout)
2689
2690         Roll out r48712 as it is incorrect.
2691
2692         * DumpRenderTree/mac/ObjCController.m:
2693         (+[ObjCController isSelectorExcludedFromWebScript:]):
2694         (+[ObjCController webScriptNameForSelector:]):
2695
2696 2009-09-24  Benjamin Poulain  <benjamin.poulain@nokia.com>
2697
2698         Reviewed by Eric Seidel.
2699
2700         https://bugs.webkit.org/show_bug.cgi?id=29005
2701         The indices of RuntimeArray should be enumerated like for a regular array.
2702
2703         * DumpRenderTree/mac/ObjCController.m:
2704         (+[ObjCController isSelectorExcludedFromWebScript:]):
2705         (+[ObjCController webScriptNameForSelector:]):
2706         (-[ObjCController arrayOfString]):
2707
2708 2009-09-23  David Kilzer  <ddkilzer@apple.com>
2709
2710         <http://webkit.org/b/28910> Move bugzilla-tool mark-fixed to standalone mark-bug-fixed tool
2711
2712         Reviewed by Darin Adler.
2713
2714         Also fixed a bug where specifying a revision on the command-line
2715         as 'r12345' would fail.  See <http://webkit.org/b/29699>.
2716
2717         * Scripts/bugzilla-tool: Updated module import statements.
2718         (parse_bug_id): Removed.  Moved to bugzilla.py.
2719         (bug_comment_from_svn_revision): Removed.  Moved to comments.py.
2720         (bug_comment_from_commit_text): Removed.  Moved to comments.py.
2721         (MarkBugFixed): Removed.  Code moved to mark-bug-fixed.
2722         (BugzillaTool.__init__): Removed mark-fixed subcommand.
2723         * Scripts/mark-bug-fixed: Added.
2724         * Scripts/modules/bugzilla.py:
2725         (parse_bug_id): Added.  Moved from bugzilla-tool.
2726         * Scripts/modules/comments.py: Added.
2727         (bug_comment_from_svn_revision): Added.  Moved from bugzilla-tool.
2728         (bug_comment_from_commit_text): Added.  Moved from bugzilla-tool.
2729
2730 2009-09-23  Marshall Culpepper  <mculpepper@appcelerator.com>
2731
2732         Reviewed by Eric Seidel.
2733         
2734          jpeg.lib is now libjpeg.lib in DRT Cairo dependencies. return
2735          "false" in non-implemented stub for setAlwaysAcceptCookies.
2736          https://bugs.webkit.org/show_bug.cgi?id=29661
2737
2738         * DumpRenderTree/win/DumpRenderTree.vcproj:
2739         * DumpRenderTree/win/DumpRenderTree.cpp:
2740
2741 2009-09-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2742
2743         Reviewed by Xan Lopez.
2744
2745         [GTK] need to dump number of pending unload handlers
2746         https://bugs.webkit.org/show_bug.cgi?id=29685
2747
2748         Implement dumping of the number of pending unload handlers.
2749
2750         The following tests will pass:
2751
2752           fast/loader/unload-form-about-blank.html
2753           fast/loader/unload-form-post-about-blank.html
2754           fast/loader/unload-form-post.html
2755           fast/loader/unload-form.html
2756           fast/loader/unload-hyperlink.html
2757           fast/loader/unload-javascript-url.html
2758           fast/loader/unload-reload.html
2759           fast/loader/unload-window-location.html
2760
2761         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2762         (getFrameNameSuitableForTestResult):
2763         (webViewLoadFinished):
2764
2765 2009-09-22  Shinichiro Hamaji  <hamaji@chromium.org>
2766
2767         Reviewed by Eric Seidel.
2768
2769         js tests should move into jstests subdirectory instead of resources/
2770         https://bugs.webkit.org/show_bug.cgi?id=25880
2771
2772         Remove support of resources directory.
2773
2774         * Scripts/make-script-test-wrappers:
2775
2776 2009-09-22  Eric Seidel  <eric@webkit.org>
2777
2778         No review, only fixing typo (missing space character).
2779
2780         Fix typo from https://bugs.webkit.org/show_bug.cgi?id=29220
2781
2782         * Scripts/run-webkit-tests:
2783
2784 2009-09-22  Eric Seidel  <eric@webkit.org>
2785
2786         Reviewed by Darin Adler.
2787
2788         run-webkit-tests needs a --repeat-each=N option (AAABBBCCC instead of ABCABCABC)
2789         https://bugs.webkit.org/show_bug.cgi?id=29220
2790
2791         * Scripts/run-webkit-tests:
2792
2793 2009-09-22  Eric Seidel  <eric@webkit.org>
2794
2795         Reviewed by David Kilzer.
2796
2797         svn-apply can't handle single-line binary file additions
2798         https://bugs.webkit.org/show_bug.cgi?id=29100
2799
2800         Fixed the regexp and added a unit test.
2801
2802         * Scripts/modules/scm_unittest.py:
2803         * Scripts/svn-apply:
2804
2805 2009-09-11  Eric Seidel  <eric@webkit.org>
2806
2807         Reviewed by David Kilzer.
2808
2809         post-diff and post-commits should be able to find bug urls in ChangeLogs.
2810         https://bugs.webkit.org/show_bug.cgi?id=29206
2811
2812         * Scripts/bugzilla-tool:
2813          - Share common options by adding a PostDiffAsPatchToBug.posting_options() method.
2814          - Rename --no-comment to --add-log-as-comment and reverse behavior.
2815            Comments tend to just be noise.  I'll eventually remove this argument if no one uses it.
2816          - Split out code into helper functions to try and make execute() more legible.
2817          - Make post-diff find the bug url in the ChangeLogs if not passed as an argument.
2818          - Fallback to bug urls in commit diffs, instead of just in commit messages,
2819            meaning post-commits will now find bug urls in ChangeLogs.
2820
2821 2009-09-21  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
2822
2823         Reviewed by Maciej Stachowiak.
2824
2825         --parse-only parameter wasn't passed to SunSpider/sunspider script.
2826         https://bugs.webkit.org/show_bug.cgi?id=29611
2827
2828         * Scripts/run-sunspider: Missing parameter passing added.
2829
2830 2009-09-20  David Kilzer  <ddkilzer@apple.com>
2831
2832         <http://webkit.org/b/29521> run-webkit-tests: use require instead eval to load DumpRenderTreeSupport module
2833
2834         Reviewed by Mark Rowe.
2835
2836         The require statement is like the use statement, except that it
2837         is run during script execution instead of during the 'BEGIN'
2838         phase.  This makes it possible to change @INC before the require
2839         statement is run.  See 'require' and 'use' in the perlfunc(1)
2840         manpage and 'BEGIN' in perlmod(1) manpage.
2841
2842         * Scripts/run-webkit-tests: Replace eval statement with require
2843         statement.
2844
2845 2009-09-18  Kevin Ollivier  <kevino@theolliviers.com>
2846
2847         wx build fixes. Fix the config name under git and allow users to specify
2848         their own waf install for experimenting with new versions.
2849
2850         * Scripts/webkitdirs.pm:
2851         * wx/build/settings.py:
2852
2853 2009-09-18  Alex Milowski  <alex@milowski.com>
2854
2855         Reviewed by Maciej Stachowiak.
2856
2857         Added checkWebCoreMathMLSupport and hasMathMLSupport to support 
2858         checking for whether MathML tests should be run
2859
2860         * Scripts/run-webkit-tests:
2861         * Scripts/webkitdirs.pm:
2862
2863 2009-08-28  Darin Adler  <darin@apple.com>
2864
2865         Reviewed by Mark Rowe.
2866
2867         Break more of run-webkit-tests into separate functions
2868         https://bugs.webkit.org/show_bug.cgi?id=29497
2869
2870         Some small steps toward improving run-webkit-tests. My goal is to
2871         refactor much more of the script into functions. Later we can add
2872         parallel test running to the tool. But better structure may help
2873         even if someone decides to translate this into another scripting
2874         language instead.
2875
2876         * Scripts/run-webkit-tests: Break more pieces of the script into
2877         seprate functions. Added readSkippedFiles, findTestsToRun, and
2878         printResults functions. Removed custom code to skip results.html
2879         and instead just put it into the ignoredFiles hash. Fixed some
2880         indentation. Sorted function declarations, global variables,
2881         and options at the top of the file alphabetically so they're not
2882         in a semi-random order.
2883
2884 2009-09-17  Kevin Ollivier  <kevino@theolliviers.com>
2885
2886         wx build fix, add missing dependency.
2887
2888         * wx/browser/wscript:
2889
2890 2009-09-16  Mark Rowe  <mrowe@apple.com>
2891
2892         Split the SnowLeopard build across a few machines.
2893
2894         * BuildSlaveSupport/build.webkit.org-config/config.json:
2895
2896 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
2897
2898         wx build fix to support monolithic builds on Windows.
2899
2900         * wx/build/wxpresets.py:
2901
2902 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
2903
2904         wx build fix, improve debug support and 2.9 support on MSW.
2905
2906         * wx/build/settings.py:
2907         * wx/build/wxpresets.py:
2908
2909 2009-09-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2910
2911         Blind try at fixing new test failure on Windows.
2912
2913         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2914         (FrameLoadDelegate::didReceiveTitle):
2915
2916 2009-09-15  Alex Milowski  <alex@milowski.com>
2917
2918         Reviewed by Tor Arne Vestbø.
2919
2920         Added mathml toggle
2921
2922         * Scripts/build-webkit:
2923
2924 2009-09-15  Kevin Ollivier  <kevino@theolliviers.com>
2925
2926         wx build fix. Allow waf build to support Python < 2.6.
2927
2928         * wx/build/waf_extensions.py:
2929
2930 2009-09-14  Chris Marrin  <cmarrin@apple.com>
2931
2932         Reviewed by Oliver Hunt.
2933
2934         Add LayoutTests infrastructure to enable and disable webgl tests.
2935         https://bugs.webkit.org/show_bug.cgi?id=29254
2936
2937         * Scripts/run-webkit-tests:
2938         * Scripts/webkitdirs.pm:
2939
2940 2009-09-14  Simon Fraser  <simon.fraser@apple.com>
2941
2942         Reviewed by Darin Adler.
2943         
2944         Add --iterations option to run-webkit-tests to repeat the tests N times
2945         https://bugs.webkit.org/show_bug.cgi?id=29263
2946
2947         When run with --iterations N, run-webkit-tests will repeat the tests N times.
2948
2949         * Scripts/run-webkit-tests:
2950
2951 2009-09-14  Brady Eidson  <beidson@apple.com>
2952
2953         Not reviewed, maybe should've been:
2954
2955         Cleaning up more Windows-specific fallout from the fix for:
2956         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
2957
2958         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2959         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):  Correct printf() formatter, 
2960           and call the correct method to get the Sender.
2961
2962 2009-09-14  Jon Honeycutt  <jhoneycutt@apple.com>
2963
2964         GTK build fix.
2965
2966         Unreviewed.
2967
2968         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2969         (AccessibilityController::setLogScrollingStartEvents):
2970
2971 2009-09-11  Jon Honeycutt  <jhoneycutt@apple.com>
2972
2973         DRT/test part of
2974         <rdar://problem/7197644> WebKit should broadcast an MSAA event when
2975         jumping to a named anchor
2976
2977         https://bugs.webkit.org/show_bug.cgi?id=28899
2978
2979         Reviewed by Adam Roben.
2980
2981         * DumpRenderTree/AccessibilityController.cpp:
2982         (logScrollingStartEventsCallback):
2983         Turn on logging of scrolling start events.
2984         (AccessibilityController::getJSClass):
2985         Add a "logScrollingStartEvents" to the AccessibilityController's JS
2986         class definition.
2987         (AccessibilityController::resetToConsistentState):
2988         Turn off logging of scrolling start events.
2989
2990         * DumpRenderTree/AccessibilityController.h:
2991         Declare setLogScrollingStartEvents(). Add a member for the scrolling
2992         start event hook.
2993
2994         * DumpRenderTree/mac/AccessibilityControllerMac.cpp:
2995         (AccessibilityController::setLogScrollingStartEvents):
2996         Stubbed.
2997
2998         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2999         (AccessibilityController::AccessibilityController):
3000         Initialize the handle to 0.
3001         (logEventProc):
3002         Renamed from logFocusEventProc; now logs scrolling start events, too.
3003         Removed the assertion that the event is a focus event. Added a switch
3004         to print a message for focus, scrolling start, and other, unknown
3005         events.
3006         (AccessibilityController::setLogFocusEvents):
3007         Changed to use logEventProc.
3008         (AccessibilityController::setLogScrollingStartEvents):
3009         If turning logging off, unhook the scrolling start event hook, and clear
3010         the member holding the handle. If turning on, query for the root
3011         accessible, so that accessibility is enabled for the WebView, and call
3012         SetWinEventHook to setup an event hook using logEventProc as the
3013         callback function.
3014
3015 2009-09-14  Brady Eidson  <beidson@apple.com>
3016
3017         Windows build fix.
3018
3019         * DumpRenderTree/LayoutTestController.cpp:
3020         (setAuthenticationPasswordCallback):
3021         (setAuthenticationUsernameCallback):
3022         
3023         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3024         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3025
3026 2009-09-14  Brady Eidson  <beidson@apple.com>
3027
3028         Reviewed by Alexey Proskuryakov.
3029
3030         Safari 4 cannot be used to update firmware on Linksys routers.
3031         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
3032
3033         Add the ability for DRT to handle authentication challenges.
3034
3035         * DumpRenderTree/LayoutTestController.cpp:
3036         (setAuthenticationPasswordCallback):
3037         (setAuthenticationUsernameCallback):
3038         (setHandlesAuthenticationChallengesCallback):
3039         (LayoutTestController::staticFunctions):
3040
3041         * DumpRenderTree/LayoutTestController.h:
3042         (LayoutTestController::handlesAuthenticationChallenges):
3043         (LayoutTestController::setHandlesAuthenticationChallenges):
3044         (LayoutTestController::authenticationUsername):
3045         (LayoutTestController::setAuthenticationUsername):
3046         (LayoutTestController::authenticationPassword):
3047         (LayoutTestController::setAuthenticationPassword):
3048
3049         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3050         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
3051
3052         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3053         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3054         * DumpRenderTree/win/ResourceLoadDelegate.h:
3055
3056 2009-09-12  Mark Rowe  <mrowe@apple.com>
3057
3058         Reviewed by Dan Bernstein.
3059
3060         Test for <rdar://problem/6954546> and <rdar://problem/7090444>.
3061
3062         Add a flag on the test plug-in that asks it to clear the document during the call to NPP_New.
3063         This is the trigger for both <rdar://problem/6954546> and <rdar://problem/7090444>.
3064
3065         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3066         (NPP_New):
3067
3068 2009-09-14  Kevin Ollivier  <kevino@theolliviers.com>
3069
3070         wx build fix for non-wxPython builds and a fix for errors when updating swig.py.
3071
3072         * wx/build/build_utils.py:
3073         * wx/build/settings.py:
3074
3075 2009-09-14  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3076
3077         Reviewed by Tor Arne Vestbø.
3078
3079         [Qt] Build fix for windows build.
3080
3081         * Scripts/bisect-builds: Add missing paranthesis for tmpdir function.
3082
3083 2009-09-13  Kevin Ollivier  <kevino@theolliviers.com>
3084
3085         Fix typo accidently landed in last commit.
3086
3087         * wx/build/settings.py:
3088
3089 2009-09-13  Kevin Ollivier  <kevino@theolliviers.com>
3090
3091         wx build fix, error out if using the wrong Python.
3092
3093         * wx/build/settings.py:
3094
3095 2009-09-13  Xan Lopez  <xlopez@igalia.com>
3096
3097         Build fix for GTK+ < 2.14.
3098
3099         Do not use gtk_widget_get_window, access the window directly
3100         through the struct.
3101
3102         * DumpRenderTree/gtk/EventSender.cpp:
3103         (contextClickCallback):
3104         (mouseDownCallback):
3105         (mouseUpCallback):
3106         (mouseMoveToCallback):
3107         (keyDownCallback):
3108
3109 2009-09-13  Martin Robinson  <martin.james.robinson@gmail.com>
3110
3111         Reviewed by Xan Lopez and Jan Alonzo.
3112
3113         [GTK] EventSender does not set 'window' property on synthesized GDK events
3114         https://bugs.webkit.org/show_bug.cgi?id=29169
3115
3116         Set the window property on synthesized GDK events in the GTK+ EventSender.
3117
3118         * DumpRenderTree/gtk/EventSender.cpp:
3119         (contextClickCallback):
3120         (mouseDownCallback):
3121         (mouseUpCallback):
3122         (mouseMoveToCallback):
3123         (keyDownCallback):
3124
3125 2009-09-12  Drew Wilson  <atwilson@google.com>
3126
3127         Reviewed by Mark Rowe.
3128
3129         run-webkit-tests has a timeout value that is too low
3130         https://bugs.webkit.org/show_bug.cgi?id=29223
3131
3132         * Scripts/run-webkit-tests:
3133         Changed timeout value to 20 seconds to avoid timing out too early.
3134
3135 2009-09-11  Kevin Ollivier  <kevino@theolliviers.com>
3136
3137         wx build fix. Mark dependencies as mandatory and declare which MSVC versions and
3138         architectures are supported for building wxWebKit.
3139
3140         * wx/build/settings.py:
3141
3142 2009-09-11  Eric Seidel  <eric@webkit.org>
3143
3144         Reviewed by David Levin.
3145
3146         bugzilla-tool rollout threw exception under svn
3147         https://bugs.webkit.org/show_bug.cgi?id=29211
3148
3149         * Scripts/modules/scm.py: add missing return, and convert number arguments to strings.
3150         * Scripts/modules/scm_unittest.py: add testing for this fix.
3151
3152 2009-09-11  Brian Weinstein  <bweinstein@apple.com>
3153
3154         Add myself to the committers list.
3155
3156         * Scripts/modules/committers.py:
3157
3158 2009-09-11  Eric Seidel  <eric@webkit.org>
3159
3160         Reviewed by Adam Barth.
3161
3162         bugzilla-tool land-patches should only fail-fast in --commit-queue mode
3163         https://bugs.webkit.org/show_bug.cgi?id=29201
3164
3165         * Scripts/bugzilla-tool:
3166
3167 2009-09-11  Adam Roben  <aroben@apple.com>
3168
3169         Make commit-log-editor move common prefixes to the top of the log
3170
3171         Fies <http://webkit.org/b/29190> commit-log-editor should move common
3172         prefixes to the top of the commit log
3173
3174         Reviewed by Darin Adler.
3175
3176         * Scripts/commit-log-editor: Find and remove the longest common prefix
3177         ending in a double newline from each ChangeLog entry, then put that
3178         common prefix at the top of the commit log.
3179         (removeLongestCommonPrefixEndingInDoubleNewline): Added. Finds,
3180         removes, and returns the longest common prefix ending in a double
3181         newline from a hash of strings
3182
3183 2009-09-11  Eric Seidel  <eric@webkit.org>
3184
3185         Fix obvious typo in previous commit, no review.
3186
3187         bugzilla-tool should automate rollouts
3188         https://bugs.webkit.org/show_bug.cgi?id=26715
3189
3190         * Scripts/bugzilla-tool: add back missing "scm" argument.
3191
3192 2009-09-11  Eric Seidel  <eric@webkit.org>
3193
3194         Reviewed by Adam Barth.
3195
3196         bugzilla-tool should automate rollouts
3197         https://bugs.webkit.org/show_bug.cgi?id=26715
3198
3199         bugzilla-tool rollout will do the rollout locally and leave the diff for you to verify and commit.
3200         The --complete-rollout option will automatically land and update the bug.
3201         Eventually --complete-rollout will be default, but that will require more testing.
3202
3203         This first pass is good enough for others to try and file bugs about.
3204
3205         * Scripts/bugzilla-tool:
3206          - Move modified_changelogs into scm.py.
3207          - Move svn_revision_from_commit_text logic into scm.py.
3208          - Add RolloutCommit command.
3209         * Scripts/modules/bugzilla.py:
3210          - Add reopen_bug command used by RolloutCommit.
3211         * Scripts/modules/scm.py:
3212          - Add functions to support RolloutCommit.
3213          - Abstract find_uuid into value_from_svn_info so it can be re-used for _repository_url (needed by svn merge).
3214          - Add a str() call so that svn_commit_log can take a numeric argument.
3215          - Remove a bunch of very slow code from last_svn_commit_log and used the built-in 'BASE' alias instead.
3216          - Made dry_run commits return something that svn_revision_from_commit_text can parse.
3217         * Scripts/modules/scm_unittest.py:
3218          - Add read_from_path for easy file reading.
3219          - Put test4 on a new line to make reverts work w/o conflict.
3220          - Add an "svn update" call so that the checkout revision matches the server revision.
3221          - Add tests for svn_revision_from_commit_text.
3222          - Add a simple test for apply_reverse_diff.
3223          - Add a new self.scm member and use it in the new tests (eventually other tests can use it too).
3224          - Add test for svn_commit_log to make sure my 'BASE' change above worked as expected.
3225
3226 2009-09-11  Adam Roben  <aroben@apple.com>
3227
3228         Get user script/stylesheet tests running on Windows
3229
3230         Fixes <http://webkit.org/b/29181> User script/stylesheet tests are
3231         skipped on Windows
3232
3233         Reviewed by John Sullivan.
3234
3235         * DumpRenderTree/win/DumpRenderTree.vcproj: Link all configurations
3236         against comsuppw.lib so we can use _bstr_t.
3237
3238         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Fixed #include
3239         order, added #include of comutil.h for _bstr_t.
3240
3241         (bstrT): Helper function to convert a JSStringRef to a _bstr_t.
3242         (LayoutTestController::addUserScript):
3243         (LayoutTestController::addUserStyleSheet):
3244         Implemented. Implementations were based on those in
3245         LayoutTestControllerMac.mm.
3246
3247 2009-09-10  David Kilzer  <ddkilzer@apple.com>
3248
3249         <http://webkit.org/b/29147> run-webkit-tests:  make -h show help 
3250
3251         Reviewed by Mark Rowe.
3252
3253         * Scripts/run-webkit-tests: Updated to make -h switch show help.
3254
3255 2009-09-10  Fumitoshi Ukai  <ukai@chromium.org>
3256
3257         Reviewed by Alexey Proskuryakov.
3258
3259         Add WebCore/websockets directory in wx build system.
3260         https://bugs.webkit.org/show_bug.cgi?id=28038
3261
3262         * wx/build/settings.py:
3263
3264 2009-09-10  Martin Robinson  <martin.james.robinson@gmail.com>
3265
3266         [GTK] EventSender does not properly convert some keyDown strings
3267         https://bugs.webkit.org/show_bug.cgi?id=29119
3268
3269         Add more keyDown string to character code conversions for GTK+ EventSender.
3270
3271         * DumpRenderTree/gtk/EventSender.cpp:
3272         (keyDownCallback):
3273
3274 2009-09-09  Steve Block  <steveblock@google.com>
3275
3276         Reviewed by Maciej Stachowiak.
3277
3278         Geolocation Coordinates::toString() prints bogus values for unspecified properties.
3279         https://bugs.webkit.org/show_bug.cgi?id=29080
3280
3281         * Scripts/make-script-test-wrappers: Modified. Adds asynchronous Geolocation tests to exclusion list.
3282
3283 2009-09-09  Eric Seidel  <eric@webkit.org>
3284
3285         Reviewed by Eric Carlson.
3286
3287         reviewer/committer lookups are backwards
3288         https://bugs.webkit.org/show_bug.cgi?id=29113
3289
3290         I also moved Eric Carlson from the committer list to the reviewer list now that he is one.
3291
3292         * Scripts/modules/bugzilla.py:
3293         * Scripts/modules/committers.py:
3294
3295 2009-09-09  Cameron McCormack  <cam@mcc.id.au>
3296
3297         Reviewed by Eric Seidel.
3298
3299         svn-unapply doesn't revert directories correctly
3300         https://bugs.webkit.org/show_bug.cgi?id=29065
3301
3302         * Scripts/svn-unapply: Make svnStatus consistently return status
3303         lines including a newline.
3304         * Scripts/svn-apply: Keep svnStatus in sync with the one in
3305         svn-unapply, in lieu of moving it to a common file.
3306
3307 2009-09-09  Cameron McCormack  <cam@mcc.id.au>
3308
3309         Reviewed by Eric Seidel.
3310
3311         svn-apply doesn't handle changes to files copied to new directories properly
3312         https://bugs.webkit.org/show_bug.cgi?id=29059
3313
3314         * Scripts/svn-apply: Don't treat "--- revision 0" patches as being
3315         additions if we know that we've just copied a file to this name.
3316
3317 2009-09-09  Eric Seidel  <eric@webkit.org>
3318
3319         Reviewed by David Levin.
3320
3321         commit-queue hangs if a builder has never built
3322         https://bugs.webkit.org/show_bug.cgi?id=29091
3323
3324         * Scripts/modules/buildbot.py:
3325         * Scripts/modules/buildbot_unittest.py:
3326
3327 2009-09-09  Zan Dobersek  <zandobersek@gmail.com>
3328
3329         Reviewed by Gustavo Noronha.
3330
3331         [GTK] DumpRenderTree needs eventSender object and implementation
3332         https://bugs.webkit.org/show_bug.cgi?id=25990
3333
3334         Implements most of the EventSender object's functionality for
3335         the DumpRenderTree tool. Implementation still lacks support
3336         for drag and drop tests and forward leaps.
3337
3338         Based on work by Holger Hans Peter Freyther.
3339
3340         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3341         (runTest): Focus on the view before loading a new test.
3342         (webViewWindowObjectCleared):
3343         * DumpRenderTree/gtk/EventSender.cpp: Added.
3344         (getDragModeCallback):
3345         (setDragModeCallback):
3346         (leapForwardCallback):
3347         (contextClickCallback):
3348         (updateClickCount):
3349         (mouseDownCallback):
3350         (mouseUpCallback):
3351         (mouseMoveToCallback):
3352         (beginDragWithFilesCallback):
3353         (replaySavedEvents):
3354         (keyDownCallback):
3355         (textZoomInCallback):
3356         (textZoomOutCallback):
3357         (zoomPageInCallback):
3358         (zoomPageOutCallback):
3359         (getClass):
3360         (makeEventSender):
3361         * DumpRenderTree/gtk/EventSender.h: Added.
3362         * GNUmakefile.am: Add build rules for EventSender.
3363
3364 2009-09-09  Daniel Bates  <dbates@webkit.org>
3365
3366         Reviewed by Adam Roben.
3367         
3368         https://bugs.webkit.org/show_bug.cgi?id=28953
3369
3370         Added pre- and post- build events so that on build failure, the file 
3371         buildfailed is written to the directory $(WebKitOutputDir).
3372
3373         * WinLauncher/WinLauncher.vcproj:
3374
3375 2009-09-09  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3376
3377         Unreviewed.
3378
3379         Add myself to list of committers.
3380
3381         * Scripts/modules/committers.py:
3382
3383 2009-09-08  Eric Seidel  <eric@webkit.org>
3384
3385         Reviewed by David Levin.
3386
3387         commit-queue gets stuck if a non-committer sets commit-queue+ or review+
3388         https://bugs.webkit.org/show_bug.cgi?id=28605
3389         https://bugs.webkit.org/show_bug.cgi?id=28916
3390
3391         * Scripts/bugzilla-tool:
3392          - Fix comment and adjust reject_patch_from_commit_queue call to pass "manual commit"
3393            comment now that it's used for rejecting patches for invalid committers too.
3394          - Pass reject_invalid_patches=True for commit-queue calls, normally we just ignore patches with invalid reviewers, the commit-queue rejects them.
3395          - Make the commit queue print patches count instead of bugs count, this also fixes https://bugs.webkit.org/show_bug.cgi?id=28916.
3396         * Scripts/modules/bugzilla.py:
3397          - Make _parse_attachment_element not validate reviewer/committer.
3398          - Share flag parsing code in _parse_attachment_flag.
3399          - Add _validate* methods for validating reviewers and committers and updating bugs when validation fails.
3400          - Add reject_invalid_patches argument so the commit-queue can update bugs on failed validation and other "read only" commands will not.
3401          - Add reject_patch_from_review_queue using a new _set_flag_on_attachment abstraction.
3402         * Scripts/modules/bugzilla_unittest.py:
3403          - Update this test to no longer expect committer/reviewer validation.
3404         * Scripts/modules/committers.py:
3405          - Return None on failed lookups instead of raising Exceptions.
3406         * Scripts/modules/committers_unittest.py:
3407          - Update tests to expect None returns instead of exceptions.
3408
3409 2009-09-09  David Kilzer  <ddkilzer@apple.com>
3410
3411         <http://webkit.org/b/29061> Fix obvious copy-paste error in AccessibilityUIElement::clickPointY()
3412
3413         Reviewed by Mark Rowe.
3414
3415         No change to layout test results.
3416
3417         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3418         (AccessibilityUIElement::clickPointY): Changed to return y value
3419         instead of x value.
3420
3421 2009-09-08  Dimitri Glazkov  <dglazkov@chromium.org>
3422
3423         Reviewed by Mark Rowe.
3424
3425         Reduce dglazkov's boboiness by properly concatenating revision value.
3426
3427         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Used substitution
3428             rather than "+".
3429
3430 2009-09-08  Kevin Ollivier  <kevino@theolliviers.com>
3431
3432         wxWebKit Python extension build fix - get swig.py if it doesn't exist.
3433
3434         * wx/build/build_utils.py:
3435
3436 2009-09-08  Mark Rowe  <mrowe@apple.com>
3437
3438         Fix an incorrect variable name in UpdateChromiumSource.
3439
3440         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3441
3442 2009-09-08  Mark Rowe  <mrowe@apple.com>
3443
3444         Don't check for leaks on the release SnowLeopard builder.
3445
3446         * BuildSlaveSupport/build.webkit.org-config/config.json:
3447
3448 2009-09-08  Mark Rowe  <mrowe@apple.com>
3449
3450         Add a SnowLeopard release builder.
3451
3452         * BuildSlaveSupport/build.webkit.org-config/config.json:
3453
3454 2009-09-08  David Levin  <levin@chromium.org>
3455
3456         Reviewed by Darin Adler.
3457
3458         Remove end of line whitespace check from check-webkit-style.
3459         https://bugs.webkit.org/show_bug.cgi?id=29053
3460
3461         * Scripts/modules/cpp_style.py:
3462
3463 2009-09-08  Cameron McCormack  <cam@mcc.id.au>
3464
3465         Reviewed by Darin Adler.
3466
3467         Fix DumpRenderTree build from clean tree on Tiger
3468         https://bugs.webkit.org/show_bug.cgi?id=28927
3469
3470         * DumpRenderTree/mac/PerlSupport/Makefile: Ensure the
3471         DerivedSources/DumpRenderTree directory exists when
3472         building on Tiger.
3473
3474 2009-09-08  Kevin Ollivier  <kevino@theolliviers.com>
3475
3476         wx build fix after introduction of platform/mock directory.
3477
3478         * wx/build/settings.py:
3479
3480 2009-09-08  Yael Aharon  <yael.aharon@nokia.com>
3481
3482         Unreviewed.
3483
3484         Add myself to list of committers.
3485
3486         * Scripts/modules/committers.py:
3487
3488 2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3489
3490         Unreviewed.
3491
3492         Add myself to list of committers.
3493
3494         * Scripts/modules/committers.py:
3495
3496 2009-09-08  Cameron McCormack  <cam@mcc.id.au>
3497
3498         Reviewed by Darin Adler.
3499
3500         prepare-ChangeLog too chatty on file additions
3501         https://bugs.webkit.org/show_bug.cgi?id=29019
3502
3503         * Scripts/prepare-ChangeLog: Omit description of added properties
3504         on newly added files.
3505
3506 2009-09-08  Steve Block  <steveblock@google.com>
3507
3508         Reviewed by Adam Barth.
3509
3510         Adds a LayoutTestController method to set the permission state for Geolocation.
3511         This is required to use the mock Geolocation service for testing.
3512         https://bugs.webkit.org/show_bug.cgi?id=29027
3513
3514         * DumpRenderTree/LayoutTestController.cpp: Modified.
3515         (setDatabaseQuotaCallback): Modified. Style fix.
3516         (setGeolocationPermissionCallback): Added. Sets the Geolocation permission state.
3517         (LayoutTestController::staticFunctions): Modified. Registers the above function on the LayoutTestController.
3518         * DumpRenderTree/LayoutTestController.h: Modified.
3519         (LayoutTestController::setGeolocationPermission): Added. Sets the Geolocation permission state.
3520         (LayoutTestController::isGeolocationPermissionSet): Added. Returns whether the Geolocation permission has been set.
3521         (LayoutTestController::geolocationPermission): Added. Returns the Geolocation permission state.
3522         * DumpRenderTree/mac/UIDelegate.mm: Modified.
3523         (-[UIDelegate webView:frame:requestGeolocationPermission:securityOrigin:]): Added. Implement chrome method to respond to request for Geolocation permission state. Response is made using above methods to access permission state.
3524
3525 2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3526
3527         Reviewed by Simon Hausmann.
3528
3529         [Qt] QtWebKit single API to enable persistency
3530         https://bugs.webkit.org/show_bug.cgi?id=28682
3531
3532         Use the new enablePersistentStorage API instead 
3533         of enabling all persistent features one-by-one.
3534
3535         * DumpRenderTree/qt/DumpRenderTree.cpp:
3536         (WebCore::WebPage::WebPage):
3537         (WebCore::DumpRenderTree::DumpRenderTree):
3538
3539 2009-09-07  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3540
3541         Reviewed by Tor Arne Vestbø.
3542
3543         Refactor --strict switch to --ignore-metrics and correct the
3544         implementation to make the feature usable on all platforms.
3545         https://bugs.webkit.org/show_bug.cgi?id=28907
3546
3547         run-webkit-tests --ignore-metrics strips the font related metrics from
3548         the actual and expected data before comparing them.
3549         In this way the render trees can be checked for obvious differences but
3550         a successful test implies by no means that the layout is actually correct.
3551
3552         * Scripts/run-webkit-tests:
3553
3554 2009-09-07  Steve Block  <steveblock@google.com>
3555
3556         Reviewed by Adam Barth.
3557
3558         Adds a mock Geolocation service. This will be used to provide predictable behavior of the
3559         Geolocation API for use in LayoutTests. Later changes will integrate the the mock
3560         Geolocation service with DumpRenderTree.
3561         https://bugs.webkit.org/show_bug.cgi?id=28264
3562
3563         * DumpRenderTree/LayoutTestController.cpp: Modified.
3564         (setMockGeolocationPositionCallback): Added. Configures the mock Geolocation service.
3565         (setMockGeolocationErrorCallback): Added. Configures the mock Geolocation service.
3566         (LayoutTestController::staticFunctions): Added. Registers the above functions on the LayoutTestController.
3567         * DumpRenderTree/LayoutTestController.h: Modified.
3568         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Modified.
3569         (LayoutTestController::setMockGeolocationPosition): Added. Configures the mock Geolocation service.
3570         (LayoutTestController::setMockGeolocationError): Added. Configures the mock Geolocation service.
3571
3572 2009-09-07  Drew Wilson  <atwilson@google.com>
3573
3574         Reviewed by David Levin.
3575
3576         Enable SHARED_WORKERS by default
3577         https://bugs.webkit.org/show_bug.cgi?id=28959
3578
3579         * Scripts/build-webkit:
3580
3581 2009-09-07  Kevin Ollivier  <kevino@theolliviers.com>
3582
3583         wx build fixes for wx SVN trunk.
3584
3585         * wx/build/settings.py:
3586
3587 2009-09-04  Kevin Ollivier  <kevino@theolliviers.com>
3588
3589         wx build fix. Switch USE_ defines over to the compiler so that they can be
3590         checked by files not including config.h (like WebCorePrefix.h).
3591
3592         * wx/build/settings.py:
3593
3594 2009-09-04  Adam Barth  <abarth@webkit.org>
3595
3596         Unreviewed build fix.
3597
3598         Update declaration of FrameLoadDelegate to reflect that
3599         IWebFrameLoadDelegatePrivate2 inherits from
3600         IWebFrameLoadDelegatePrivate.
3601
3602         * DumpRenderTree/win/FrameLoadDelegate.h:
3603
3604 2009-09-04  Adam Barth  <abarth@webkit.org>
3605
3606         Reviewed by Eric Seidel.
3607
3608         https://bugs.webkit.org/show_bug.cgi?id=24696
3609
3610         Add testing instrumentation for mixed content.
3611
3612         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3613         (-[FrameLoadDelegate webView:]):
3614         (-[FrameLoadDelegate webView:didRunInsecureContent:]):
3615         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3616         (descriptionSuitableForTestResult):
3617         (FrameLoadDelegate::QueryInterface):
3618         (FrameLoadDelegate::didDisplayInsecureContent):
3619         (FrameLoadDelegate::didRunInsecureContent):
3620         * DumpRenderTree/win/FrameLoadDelegate.h:
3621
3622 2009-09-03  Kevin Watters  <kevinwatters@gmail.com>
3623
3624         Reviewed by Kevin Ollivier.
3625
3626         [wx] Frames support
3627         https://bugs.webkit.org/show_bug.cgi?id=19041
3628
3629         * wx/build-wxwebkit:
3630
3631 2009-09-02  David Kilzer  <ddkilzer@apple.com>
3632
3633         <http://webkit.org/b/28880> svn-apply --force doesn't actually work
3634
3635         Reviewed by Eric Seidel.
3636
3637         This fixes "svn-apply --force" and adds unit tests for the
3638         scm.apply_patch() method which uses this script.
3639
3640         * Scripts/svn-apply: Created $globalExitCode variable that
3641         defaults to 0.  Exit with a value of $globalExitCode when the
3642         script is finished.
3643         (applyPatch): Ignore a non-zero $exitCode if $force is true, but
3644         set $globalExitCode to $exitCode so that svn-apply exits with a
3645         non-zero status if any patches did not apply cleanly.  Also
3646         print out the actual patch command if $force was not true.
3647
3648         * Scripts/modules/scm.py:
3649         (scripts_directory): Added.  Extracted from script_path().
3650         (script_path): Extracted scripts_directory().
3651         * Scripts/modules/scm_unittest.py: Import urllib.
3652         (SVNTestRepository.setup): Save the original working directory
3653         in test_object since this represents the WebKit repository from
3654         where the unit tests are run.
3655         (SCMTest): Created new super class to hold utility methods.
3656         (SCMTest._create_patch): Creates a patch file on disk and a
3657         dictionary for use with scm.svn_apply().
3658         (SCMTest._setup_webkittools_scripts_symlink): Sets up a symlink
3659         back to WebKitTools/Scripts in the test repository so that
3660         scm.apply_patch() is able to find the svn-apply script.
3661         (SVNTest): Inherit from SCMTest instead of unittest.TestCase.
3662         (SVNTest.tearDown): Make sure to change directories back to the
3663         original_path before the next test.
3664         (SVNTest.test_apply_svn_patch): New test case for applying an
3665         svn patch with scm.apply_patch().
3666         (SVNTest.test_apply_svn_patch_force): New test case for applying
3667         an svn patch with scm.apply_patch() that conflicts.
3668         (GitTest): Inherit from SCMTest instead of unittest.TestCase.
3669         (GitTest.tearDown): Make sure to change directories back to the
3670         original_path before the next test.
3671         (GitTest.test_apply_git_patch): New test case for applying a git
3672         patch with scm.apply_patch().
3673         (GitTest.test_apply_git_patch_force): New test case for applying
3674         a git patch with scm.apply_patch() that conflicts.
3675
3676 2009-09-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3677
3678         Reviewed by Mark Rowe.
3679
3680         [Qt] Add support for platform-spesific layout-test results
3681
3682         For the Qt port we use the qt-[mac|linux|win] directories and then fall
3683         back to the generic qt directory for both test results and skipped list.
3684
3685         * Scripts/run-webkit-tests:
3686         * Scripts/webkitdirs.pm:
3687
3688 2009-09-02  Laurent Cerveau  <lcerveau@me.com>
3689
3690         Reviewed by David Kilzer.
3691
3692         <http://webkit.org/b/25517> build-webkit script should print build time at end
3693
3694         * Scripts/build-webkit:
3695         Added startTime and endTime variable so that the build time is computed and printed as
3696         part of the build message; display formatting has been separated in a dedicated subroutine.
3697
3698 2009-09-02  David Kilzer  <ddkilzer@apple.com>
3699
3700         <http://webkit.org/b/28881> svn-create-patch should check if the repo path is the same when trying to find the root
3701
3702         Reviewed by Eric Seidel.
3703
3704         * Scripts/VCSUtils.pm:
3705         (determineSvnRoot): Added back check for repository root that
3706         was removed in r46134 when this code lived in svn-create-patch.
3707         It's necessary to check both the repository root and the
3708         repository UUID in case two different working directories are
3709         checked out from the same repository.
3710
3711 2009-09-02  Timothy Hatcher  <timothy@apple.com>
3712
3713         Use new 512x512 icons for nightly builds.
3714
3715         Rubber-stamped by Mark Rowe.
3716
3717         * WebKitLauncher/webkit.icns:
3718
3719 2009-09-02  Kevin Ollivier  <kevino@theolliviers.com>
3720
3721         waf build fix. Remove local variable shadowing global.
3722
3723         * wx/build/settings.py:
3724
3725 2009-09-02  Zan Dobersek  <zandobersek@gmail.com>
3726
3727         Reviewed by David Kilzer.
3728
3729         Calls exitStatus function from the main package where it is also defined.
3730
3731         * Scripts/VCSUtils.pm:
3732
3733 2009-09-02  Kevin Ollivier  <kevino@theolliviers.com>
3734
3735         waf build fixes for Windows/MSVC and Mac/Snow Leopard.
3736
3737         * wx/browser/wscript:
3738         * wx/build/build_utils.py:
3739         * wx/build/settings.py:
3740
3741 2009-08-10  Kevin Ollivier  <kevino@theolliviers.com>
3742
3743         Reviewed by Eric Seidel.
3744
3745         Changes needed for build-webkit to support the waf build system for the wx port.
3746         
3747         https://bugs.webkit.org/show_bug.cgi?id=27619
3748
3749         * Scripts/build-webkit:
3750         * Scripts/run-launcher:
3751         * Scripts/webkitdirs.pm:
3752
3753 2009-09-02  David Kilzer  <ddkilzer@apple.com>
3754
3755         <http://webkit.org/b/27168> With Subversion 1.6, update-webkit prompts on conflicts
3756
3757         Reviewed by Eric Seidel.
3758
3759         * Scripts/update-webkit: Added "--accept postpone" to
3760         @svnOptions when running with svn-1.6 or newer.
3761
3762 2009-09-02  David Kilzer  <ddkilzer@apple.com>
3763
3764         Moved svn 1.6 version check into VCSUtils::isSVNVersion16OrNewer()
3765
3766         Reviewed by Eric Seidel.
3767
3768         * Scripts/VCSUtils.pm:
3769         (@EXPORT): Added &isSVNVersion16OrNewer.
3770         (svnVersion): Added.  Internal method that gets the SVN version
3771         and caches it.
3772         (isSVNVersion16OrNewer): Added.  Method that does the SVN 1.6
3773         version check.
3774         * Scripts/prepare-ChangeLog: Switched to use new
3775         isSVNVersion16OrNewer() method.
3776         * Scripts/resolve-ChangeLogs: Ditto.
3777         * Scripts/svn-create-patch: Ditto.
3778
3779 2009-09-02  David Kilzer  <ddkilzer@apple.com>
3780
3781         Clean up VCSUtils.pm
3782
3783         Reviewed by Eric Seidel.
3784
3785         * Scripts/VCSUtils.pm: Added proper package statement.  Fixed
3786         indentation of BEGIN block.  Listed each exported method on a
3787         line by itself.  Added methods to the export list after adding
3788         the package statement.  Sorted module variables.  Moved
3789         definiton of $gitRoot next to other module variables.
3790
3791 2009-09-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3792
3793         Rubber-stamped by Simon Hausmann.
3794
3795         [Qt] Fix layout-test plugins/plugin-javascript-access.html
3796
3797         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3798
3799 2009-09-02  Shinichiro Hamaji  <hamaji@chromium.org>
3800
3801         Reviewed by Eric Seidel.
3802
3803         js tests should move into jstests subdirectory instead of resources/
3804         https://bugs.webkit.org/show_bug.cgi?id=25880
3805
3806         make-script-wrappers supports both resources and script-tests directories.
3807         run-webkit-tests ignores files in script-tests.
3808         Move script tests of animations to check the new script is working.
3809
3810         * Scripts/make-script-test-wrappers:
3811         * Scripts/run-webkit-tests:
3812
3813 2009-09-02  Szabo Carol  <carol.szabo@nokia.com>
3814
3815         Reviewed by David Levin.
3816
3817         check-webkit-style uses python from /usr/bin instead of the PATH
3818         https://bugs.webkit.org/show_bug.cgi?id=28225
3819
3820         * Scripts/bugzilla-tool:
3821         * Scripts/check-webkit-style:
3822         * Scripts/run-webkit-unittests:
3823         * Scripts/update-sources-list.py:
3824           Changed the first line from
3825           #!/usr/bin/python
3826           to
3827           #!/usr/bin/env python
3828           which causes python to be invoked from the path location returned
3829           by "which python" when any of these scripts are launched.
3830           these are currently all the python scripts in WebKitTools/Scripts.
3831
3832 2009-09-01  David Kilzer  <ddkilzer@apple.com>
3833
3834         <http://webkit.org/b/28601> bugzilla-tool post-commits posts commits backwards
3835
3836         Reviewed by Adam Barth.
3837
3838         * Scripts/modules/scm.py:
3839         (Git.commit_ids_from_commitish_arguments): Reverse the list of
3840         commits returned from git-rev-list since we always want to post
3841         the oldest patches first to bugs.webkit.org.
3842         * Scripts/modules/scm_unittest.py:
3843         (run): Added return statement to return the output now that we
3844         want it sometimes.
3845         (SVNTestRepository._setup_test_commits): Added a fourth commit
3846         so the GitTest.test_commitish_order() test has more commits to
3847         work with.
3848         (GitTest.test_commitish_order): Added unit test for change to
3849         Git.commit_ids_from_commitish_arguments() in scm.py.
3850
3851 2009-09-01  David Kilzer  <ddkilzer@apple.com>
3852
3853         <http://webkit.org/b/28877> Implement bugzilla-tool mark-fixed
3854
3855         Reviewed by David Levin.
3856
3857         The mark-fixed subcommand is for those times when you don't use
3858         bugzilla-tool to commit a patch, but you want to use it to close
3859         the bug with a committed-revision message.
3860
3861         * Scripts/bugzilla-tool:
3862         (bug_comment_from_svn_revision): Added.  Extracted from
3863         bug_comment_from_commit_text().
3864         (bug_comment_from_commit_text): Extracted
3865         bug_comment_from_svn_revision() from this method.
3866         (MarkBugFixed.__init__): Added.
3867         (MarkBugFixed._fetch_commit_log): Added.  Retrieves the commit
3868         log from the last commit if no svn revision is specified, else
3869         the commit log for the specified svn revision.
3870         (MarkBugFixed._determine_bug_id_and_svn_revision): Added.
3871         Attempts to determine the bug id and svn revision if one or both
3872         were not defined on the command line.
3873         (MarkBugFixed.execute): Added.  Adds a comment about the
3874         revision that fixed the bug and closes the bug.
3875         (BugzillaTool.__init__): Added mark-fixed subcommand.
3876         * Scripts/modules/bugzilla.py:
3877         (Bugzilla.fetch_title_from_bug): Added.  Returns the title of a
3878         bug given a bug id.
3879         * Scripts/modules/scm.py:
3880         (SCM.strip_r_from_svn_revision): Added.  Utility method to strip
3881         the leading 'r' from an svn revision.
3882         (SCM.svn_commit_log): Added.  Subclasses must override.
3883         (SCM.last_svn_commit_log): Added.  Subclasses must override.
3884         (SVN.svn_commit_log): Added.  Returns svn log for a given
3885         revision.
3886         (SVN.last_svn_commit_log): Added.  Uses svnversion to find the
3887         last commit in an svn working directory and then runs svn log.
3888         (Git.svn_commit_log): Added.  Returns svn log for a given
3889         revision.
3890         (Git.last_svn_commit_log): Added.  Runs git-svn-log with a limit
3891         of one log message.
3892
3893 2009-09-01  David Kilzer  <ddkilzer@apple.com>
3894
3895         <http://webkit.org/b/28880> svn-apply --force doesn't actually work
3896
3897         Reviewed by Brady Eidson.
3898
3899         * Scripts/svn-apply:
3900         (applyPatch): Add "--force" to $options arrayref if $force is
3901         set.
3902
3903 2009-09-01  David Kilzer  <ddkilzer@apple.com>
3904
3905         <http://webkit.org/b/28725> resolve-ChangeLogs: determineVCSRoot() returns incorrect repository root during git filter-branch
3906
3907         Reviewed by Adam Roben.
3908
3909         When git-filter-branch has been invoked to rewrite ChangeLog
3910         files on series of git commits, it changes directories into
3911         .git-rewrite/t before re-running resolve-ChangeLogs.  This
3912         causes determineVCSRoot() in VCSUtils.pm to return
3913         ".git-rewrite/t", which causes that path to be prepended to all
3914         ChangeLog paths, which results in an error like this:
3915
3916             error: pathspec '.git-rewrite/t/ChangeLog' did not match any file(s) known to git.
3917             Died at WebKitTools/Scripts/resolve-ChangeLogs line 376.
3918
3919         The correct way to fix this is not to try to find the repository
3920         root when invoked by git-filter-branch.
3921
3922         * Scripts/resolve-ChangeLogs: If isInGitFilterBranch() is true,
3923         set $relativePath to '.' instead of calling
3924         chdirReturningRelativePath(determineVCSRoot()).
3925         (isInGitFilterBranch): Added.  Checks for the existence of the
3926         MAPPED_PREVIOUS_COMMIT environment variable.
3927
3928 2009-09-01  Xan Lopez  <xlopez@igalia.com>
3929
3930         Reviewed by Gustavo Noronha.
3931
3932         Add support for Fedora distros in the http tests
3933         https://bugs.webkit.org/show_bug.cgi?id=28263
3934
3935         Add detection code for Fedora distribution, and use the proper
3936         httpd conf file when needed.
3937
3938         * Scripts/run-webkit-httpd:
3939         * Scripts/run-webkit-tests:
3940         * Scripts/webkitdirs.pm:
3941
3942 2009-09-01  Jan Michael Alonzo  <jmalonzo@webkit.org>
3943
3944         Reviewed by Eric Seidel.
3945
3946         [Gtk] DRT needs implementation of overridePreference
3947         https://bugs.webkit.org/show_bug.cgi?id=28830
3948
3949         Implement overridePreference.
3950
3951         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3952         (resetDefaultsToConsistentValues):
3953         (setDefaultsToConsistentStateValuesForTesting):
3954         (runTest):
3955         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3956         (toWebSettingKey):
3957         (LayoutTestController::overridePreference):
3958
3959 2009-09-01  Joseph Pecoraro  <joepeck@webkit.org>
3960
3961         <http://webkit.org/b/28623> svn-[un]apply should change directories to the repository root before [un]applying
3962
3963         Reviewed by Eric Seidel.
3964
3965         Jump back and forth between the repository root directory (to apply) and the
3966         directory the script was run from (to find the patch).
3967
3968         * Scripts/svn-apply:
3969         * Scripts/svn-unapply:
3970
3971 2009-08-31  Adam Roben  <aroben@apple.com>
3972
3973         Fall back to a Release version of Safari if a Debug one doesn't exist
3974
3975         <http://webkit.org/b/28849>
3976
3977         Reviewed by Sam Weinig.
3978
3979         * Scripts/webkitdirs.pm:
3980         (safariPath): If the user is working with a Debug build, but there's
3981         no Debug version of Safari present, fall back to using a Release
3982         version of Safari.
3983
3984 2009-08-31  Adam Roben  <aroben@apple.com>
3985
3986         Make safariPath() work for Debug builds of Safari on Windows
3987
3988         <http://webkit.org/b/28849>
3989
3990         Reviewed by Sam Weinig.
3991
3992         * Scripts/webkitdirs.pm:
3993         (safariPath): If the user is working with a Debug build, add the
3994         _debug suffix to Safari.exe.
3995
3996 2009-08-28  Eric Seidel  <eric@webkit.org>
3997
3998         Reviewed by Adam Barth.
3999
4000         commit-queue needs a master process
4001         https://bugs.webkit.org/show_bug.cgi?id=28040
4002
4003         Add a bugzilla-tool commit-queue command
4004         Keeps per-bug logs, but doesn't yet upload them anywhere.
4005
4006         * Scripts/bugzilla-tool: Add LandPatchesFromCommitQueue to handle 'commit-queue'
4007         * Scripts/modules/buildbot.py: remove noisy log message
4008         * Scripts/modules/logging.py: add a 'tee()' call for splitting outputs in python
4009
4010 2009-08-28  Jan Michael Alonzo  <jmalonzo@webkit.org>
4011
4012         Reviewed by Gustavo Noronha.
4013
4014         [GTK] Geolocation needs permission API before being enabled by default
4015
4016         Build the Gtk port with geolocation enabled. This option is only
4017         enabled for the buildbot. The autotools option will be enabled by
4018         default once the permissions API is implemented.
4019
4020         * Scripts/build-webkit:
4021
4022 2009-08-26  Cameron McCormack  <cam@mcc.id.au>
4023
4024         Reviewed by David Kilzer.
4025
4026         Make prepare-ChangeLog notice property changes
4027         https://bugs.webkit.org/show_bug.cgi?id=28675
4028
4029         Make the generated ChangeLog entry include a short description of
4030         property changes if there were such changes.  Also make
4031         prepare-ChangeLog not bail if the only changes are property changes.
4032
4033         * Scripts/prepare-ChangeLog:
4034
4035 2009-08-26  Adam Barth  <abarth@webkit.org>
4036
4037         Reviewed by Oliver Hunt.
4038
4039         Don't let local files access web URLs
4040         https://bugs.webkit.org/show_bug.cgi?id=28480
4041
4042         A bunch of our LayoutTests rely on our old behavior, so we explicitly
4043         grant local files universal access during testing.  Mainly, these tests
4044         involve making XMLHttpRequests for data URLs.
4045
4046         * DumpRenderTree/mac/DumpRenderTree.mm:
4047         (resetDefaultsToConsistentValues):
4048         * DumpRenderTree/qt/DumpRenderTree.cpp:
4049         (WebCore::WebPage::WebPage):
4050         * DumpRenderTree/win/DumpRenderTree.cpp:
4051         (resetDefaultsToConsistentValues):
4052
4053 2009-08-26  John Gregg  <johnnyg@google.com>
4054
4055         Reviewed by David Levin.
4056
4057         Minor style correction and include fix for notifications
4058         https://bugs.webkit.org/show_bug.cgi?id=28745
4059
4060         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
4061           change to correct EnumStyle
4062         (DRTDesktopNotificationPresenter::checkNotificationPermission):
4063
4064 2009-08-26  David Levin  <levin@chromium.org>
4065
4066         Reviewed by Alexey Proskuryakov.
4067
4068         XMLHttpRequest.withCredentials=false shouldn't save cookies.
4069         https://bugs.webkit.org/show_bug.cgi?id=28743
4070
4071         Added the support to the layout test controller on OSX and
4072         Windows (for CFNETWORK) to allow for changing the accept cookie
4073         policy.
4074
4075         * DumpRenderTree/LayoutTestController.cpp:
4076         (LayoutTestController::LayoutTestController): Added a bool
4077         to track the state of accepting cookies.
4078         (setAlwaysAcceptCookiesCallback): Standard wrapper method
4079         to go from js to a C++ method.
4080         (LayoutTestController::staticFunctions): Added the
4081         setAlwaysAcceptCookies method to the js layoutTestController.
4082         * DumpRenderTree/LayoutTestController.h:
4083         (LayoutTestController::alwaysAcceptCookies): Returns the value.
4084         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4085         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
4086         * DumpRenderTree/mac/DumpRenderTree.mm:
4087         (resetDefaultsToConsistentValues): Reset the accept cookie to
4088         its default.
4089         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4090         (LayoutTestController::setAlwaysAcceptCookies): Does the work for
4091         OSX to change the cookie accept policy.
4092         * DumpRenderTree/win/DumpRenderTree.cpp:
4093         (setAlwaysAcceptCookies): Method to handle all the calls necessary
4094         to change the accept cookie policy on Windows.
4095         (resetDefaultsToConsistentValues): Reset the accept cookie to
4096         its default.
4097         * DumpRenderTree/win/DumpRenderTreeWin.h:
4098         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4099         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
4100         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4101         (LayoutTestController::setAlwaysAcceptCookies): Stub out method.
4102
4103 2009-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
4104
4105         Unreviewed.
4106
4107         Remove accidentally left in clobber option.
4108         https://bugs.webkit.org/show_bug.cgi?id=28400
4109
4110         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed clobber option.
4111
4112 2009-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
4113
4114         Reviewed by Mark Rowe.
4115
4116         Add canary-style Chromium WebKit build slave to the waterfall.
4117         https://bugs.webkit.org/show_bug.cgi?id=28400
4118
4119         * BuildSlaveSupport/build.webkit.org-config/config.json: Added one Chromium/Windows slave
4120         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added support for Chromium slave commands.
4121
4122 2009-08-25  Cameron McCormack  <cam@mcc.id.au>
4123
4124         Reviewed by Darin Adler.
4125
4126         make-script-test-wrappers should be executable
4127         https://bugs.webkit.org/show_bug.cgi?id=28669
4128
4129         Make make-script-test-wrappers and update-sources-list.py both be
4130         executable.
4131
4132         * Scripts/update-sources-list.py:
4133         * Scripts/make-script-test-wrappers:
4134
4135 2009-08-25  Brent Fulgham  <bfulgham@webkit.org>
4136
4137         Build fix
4138
4139         Revise Debug_Cairo targets to point inherit from the 
4140         debug_wincairo.vsprops property sheet so that they link
4141         against the proper libraries in Debug build.
4142
4143         * DumpRenderTree/win/DumpRenderTree.vcproj:
4144         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
4145         * WinLauncher/WinLauncher.vcproj:
4146
4147 2009-08-25  David Levin  <levin@chromium.org>
4148
4149         Reviewed by Adam Roben.
4150
4151         PLATFORM(CFNETWORK) should be USE(CFNETWORK).
4152         https://bugs.webkit.org/show_bug.cgi?id=28713
4153
4154         * DumpRenderTree/win/DumpRenderTree.cpp:
4155         (main):
4156
4157 2009-08-25  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4158
4159         Reviewed by Ariya Hidayat.
4160
4161         [Qt/Mac] Use CONFIG+=build_all only when building libraries
4162
4163         If no configuration is specified when building WebKit we pass the
4164         debug_and_release option to QMake which results in Makefiles for
4165         both configurations being generated.
4166
4167         Previously we built both of these configurations by default, for
4168         all targets (both the QtWebKit framework/dyldlib and the various
4169         executables such as QtLauncher and tests). This makes sense for
4170         the libraries, which get the _debug suffix and can be loaded on
4171         demand by setting the DYLD_IMAGE_SUFFIX, but for executables we
4172         ended up building the same executable twice.
4173
4174         We now only build one instance of each executable, and since this
4175         is a developer build we build the debug-version. Passing either
4176         --debug or --release to build-webkit will override this, and
4177         even in the default case the release version can still be built
4178         by running 'make release' in the the build directory of each
4179         target.
4180
4181         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
4182         * Scripts/webkitdirs.pm:
4183
4184 2009-08-24  Hironori Bono  <hbono@chromium.org>
4185
4186         Reviewed by Adam Barth.
4187
4188         Fix Bug 27827 "[Chromium] Functions Keys don't work in google spreadsheet".
4189         <https://bugs.webkit.org/show_bug.cgi?id=27827>.
4190
4191         Because of the lack of mappings from GDK key-codes to WebKit key-codes,
4192         Chromium cannot send valid key-codes to JavaScript when a user types
4193         function keys. This change just copies the mappings from 'KeyEventGtk.cpp'.
4194
4195         To write layout tests for this issue, added mappings from function-key
4196         names to platform-specific key-codes to EventSendingController objects
4197         so that eventSender.keyDown() can send function-key events without using
4198         platform-specific key codes. (Unfortunately, this eventSender.keyDown() change
4199         is only for Mac. So this change adds this new test to Skipped tests for other
4200         platforms to prevent this change from crashing the build trees.)
4201
4202         * DumpRenderTree/mac/EventSendingController.mm:
4203         (-[EventSendingController keyDown:withModifiers:]):
4204
4205 2009-08-23  Jan Michael Alonzo  <jmalonzo@webkit.org>
4206
4207         Reviewed by Xan Lopez.
4208
4209         [Gtk] API for disabling local file access to web URLs
4210         https://bugs.webkit.org/show_bug.cgi?id=28663
4211
4212         Enable this setting for DRT.
4213
4214         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4215         (resetWebViewToConsistentStateBeforeTesting):
4216
4217 2009-08-22  Adam Barth  <abarth@webkit.org>
4218
4219         Revert 47684.  We're going to do this later once clients have had a
4220         chance to opt into the setting they like.
4221
4222         * DumpRenderTree/mac/DumpRenderTree.mm:
4223         (resetDefaultsToConsistentValues):
4224         * DumpRenderTree/qt/DumpRenderTree.cpp:
4225         (WebCore::WebPage::WebPage):
4226         * DumpRenderTree/win/DumpRenderTree.cpp:
4227         (resetDefaultsToConsistentValues):
4228
4229 2009-08-22  Adam Barth  <abarth@webkit.org>
4230
4231         Reviewed by Eric Seidel.
4232
4233         Don't let local files access web URLs
4234         https://bugs.webkit.org/show_bug.cgi?id=28480
4235
4236         A bunch of our LayoutTests rely on our old behavior, so we explicitly
4237         grant local files universal access during testing.  Mainly, these tests
4238         involve making XMLHttpRequests for data URLs.
4239
4240         * DumpRenderTree/mac/DumpRenderTree.mm:
4241         (resetDefaultsToConsistentValues):
4242         * DumpRenderTree/qt/DumpRenderTree.cpp:
4243         (WebCore::WebPage::WebPage):
4244         * DumpRenderTree/win/DumpRenderTree.cpp:
4245         (resetDefaultsToConsistentValues):
4246
4247 2009-08-22  Mark Rowe  <mrowe@apple.com>
4248
4249         Rubber-stamped by Anders Carlsson.
4250
4251         Bring signed updates to the Mac nightly builds.
4252
4253         * WebKitLauncher/Info.plist:
4254         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
4255         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
4256         (initializeSparkle):
4257         * WebKitLauncher/nightly.webkit.org.public.pem: Added.
4258
4259 2009-08-21  Jan Michael Alonzo  <jmalonzo@webkit.org>
4260
4261         Rubberstamped by Simon Fraser.
4262
4263         Remove GNOME keyring support in build-webkit. This dependency's
4264         already been removed in the Gtk port.
4265
4266         * Scripts/build-webkit:
4267
4268 2009-08-20  Brian Weinstein  <bweinstein@apple.com>
4269
4270         Reviewed by Adam Roben.
4271         Based on original patch by Stephanie Lewis.
4272
4273         Added support of the Windows malloc history format to parse-malloc history, so we can
4274         read and parse it.
4275
4276         * Scripts/parse-malloc-history:
4277
4278 2009-08-20  Chris Fleizach  <cfleizach@apple.com>
4279
4280         Reviewed by Darin Adler.
4281
4282         Enable various "grouping" ARIA roles
4283         https://bugs.webkit.org/show_bug.cgi?id=28486
4284
4285         Expose the ability to retrieve the subrole through accessibility for DRT.
4286
4287         * DumpRenderTree/AccessibilityUIElement.cpp:
4288         * DumpRenderTree/AccessibilityUIElement.h:
4289         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
4290         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4291         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
4292
4293 2009-08-20  Joseph Pecoraro  <joepeck@webkit.org>
4294
4295         Unreviewed.
4296
4297         Added myself as a committer.
4298
4299         * Scripts/modules/committers.py:
4300
4301 2009-08-20  Xan Lopez  <xlopez@igalia.com>
4302
4303         Reviewed by Gustavo Noronha.
4304
4305         Fix memory leaks.
4306
4307         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4308         (LayoutTestController::whiteListAccessFromOrigin):
4309         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
4310         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
4311
4312 2009-08-20  Eric Seidel  <eric@webkit.org>
4313
4314         Reviewed by Adam Barth.
4315
4316         bugzilla-tool post-diff can post partial diffs from SVN checkouts.
4317         https://bugs.webkit.org/show_bug.cgi?id=28445
4318
4319         Pass the checkout root as the&