WebKitTools/ChangeLog

   1 2007-11-12  Sam Weinig  <sam@webkit.org>
   2
   3         Reviewed by Adam Roben.
   4
   5         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
   6
   7         * DumpRenderTree/win/DumpRenderTree.cpp:
   8         (runTest):
   9         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  10         (LayoutTestController::setPrivateBrowsingEnabled):
  11
  12 2007-11-12  Adam Roben  <aroben@apple.com>
  13
  14         * Scripts/update-webkit-localizable-strings: Changed to only scan the
  15         mac and win subdirectories.
  16
  17 2007-11-11  Adam Roben  <aroben@apple.com>
  18
  19         Fix <rdar://5133816> keepWebHistory is not implemented
  20
  21         Fixes fast/history/clicked-link-is-visited.html.
  22
  23         Reviewed by Darin.
  24
  25         * DumpRenderTree/win/DumpRenderTree.cpp:
  26         (runTest): Clear the optionalSharedHistory.
  27         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  28         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
  29
  30 2007-11-10  Sam Weinig  <sam@webkit.org>
  31
  32         Reviewed by Tim Hatcher.
  33
  34         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript
  35         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions
  36         is turned on)
  37
  38         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
  39
  40         Added test: http/tests/security/cross-frame-access-private-browsing.html
  41
  42         * DumpRenderTree/LayoutTestController.cpp:
  43         (setPrivateBrowsingEnabledCallback):
  44         (LayoutTestController::staticFunctions):
  45         * DumpRenderTree/LayoutTestController.h:
  46         * DumpRenderTree/mac/DumpRenderTree.mm:
  47         (runTest): Default to private browsing disabled.
  48         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  49         (LayoutTestController::setPrivateBrowsingEnabled):
  50         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  51         (LayoutTestController::setPrivateBrowsingEnabled):
  52
  53 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
  54
  55         Reviewed by Adam.
  56
  57         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
  58         WebCore's!
  59
  60         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
  61         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
  62         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
  63         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
  64         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
  65         * Drosera/win/Drosera.cpp:
  66         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
  67
  68 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
  69
  70         Reviewed by Sam.
  71
  72         - Use the new IWebFrame [local] function signature and get the shared
  73         server correctly.
  74
  75         * Drosera/win/DebuggerClient.cpp:
  76         (DebuggerClient::didFinishLoadForFrame):
  77         * Drosera/win/ServerConnection.cpp:
  78         (ServerConnection::attemptToCreateServerConnection):
  79
  80 2007-11-07  Dan Bernstein  <mitz@apple.com>
  81
  82         Reviewed by Darin Adler.
  83
  84         - add an option to run-webkit-tests to ignore pixel test failures where
  85           all pixels differ by no more than a specified threshold
  86
  87         * DumpRenderTree/mac/ImageDiff.m:
  88         (main):
  89         (compareImages):
  90         (computePercentageDifferent):
  91         * Scripts/run-webkit-tests:
  92
  93 2007-11-07  Simon Hausmann  <hausmann@kde.org>
  94
  95         Reviewed by Lars.
  96
  97         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
  98
  99         * DumpRenderTree/qt/DumpRenderTree.cpp:
 100
 101 2007-11-07  Simon Hausmann  <hausmann@kde.org>
 102
 103         Reviewed by Lars.
 104
 105         Reworked the QWebSettings API.
 106         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
 107
 108         * DumpRenderTree/qt/DumpRenderTree.cpp:
 109
 110 2007-11-07  Simon Hausmann  <hausmann@kde.org>
 111
 112         Reviewed by Lars.
 113
 114         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
 115
 116         * DumpRenderTree/qt/jsobjects.cpp:
 117
 118 2007-11-07  Simon Hausmann  <hausmann@kde.org>
 119
 120         Reviewed by Lars Knoll <lars@trolltech.com>.
 121
 122         Add a QWebPage::frameCreated() signal and fix DRT
 123
 124         The removal of createFrame in QWebPage broke the re-implementation
 125         in DumpRenderTree. Instead emit a frameCreated() signal and
 126         connect to it in DumpRenderTree.
 127
 128
 129         * DumpRenderTree/qt/DumpRenderTree.cpp:
 130         (WebCore::WebPage::WebPage):
 131         (WebCore::DumpRenderTree::dump):
 132         (WebCore::DumpRenderTree::connectFrame):
 133         * DumpRenderTree/qt/DumpRenderTree.h:
 134
 135 2007-11-07  Simon Hausmann  <hausmann@kde.org>
 136
 137         Reviewed by Lars Knoll <lars@trolltech.com>.
 138
 139         Moved all the event handlers from QWebFrame into QWebPage.
 140
 141         This cleans up the public API and allows us to remove the
 142         HackWebFrame hack in DumpRenderTree.
 143
 144
 145         * DumpRenderTree/qt/jsobjects.cpp:
 146         (EventSender::mouseDown):
 147         (EventSender::mouseUp):
 148         (EventSender::mouseMoveTo):
 149
 150 2007-11-07  Simon Hausmann  <hausmann@kde.org>
 151
 152         Reviewed by Mark.
 153
 154         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
 155         to prevent the default implementation from popping up messageboxes.
 156
 157         * DumpRenderTree/qt/DumpRenderTree.cpp:
 158         (WebCore::WebPage::javaScriptConfirm):
 159         (WebCore::WebPage::javaScriptPrompt):
 160
 161 2007-11-06  Eric Seidel  <eric@webkit.org>
 162
 163         * Scripts/build-testkjs: build fix... too many $$
 164
 165 2007-11-06  Eric Seidel  <eric@webkit.org>
 166
 167         Reviewed by Mark Rowe.
 168
 169         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
 170
 171 2007-11-05  Adam Roben  <aroben@apple.com>
 172
 173         Add support on Windows for WEBKIT_TESTFONTS
 174
 175         This environment variable lets you specify where the fonts to be used
 176         by DumpRenderTree reside. The Qt port is already using this, so I'm
 177         just following their lead.
 178
 179         Reviewed by Darin.
 180
 181         * DumpRenderTree/win/DumpRenderTree.cpp:
 182         (exePath): Refactored code out of initialize().
 183         (fontsPath): Returns either $WEBKIT_TESTFONTS or
 184         DumpRenderTree.resources.
 185         (initialize): Use the new fontsPath function.
 186         (main): Use the new exePath function.
 187         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
 188         variable to DRT, like Qt does.
 189
 190 2007-11-05  Mark Rowe  <mrowe@apple.com>
 191
 192         Rubber-stamped by Alp Toker.
 193
 194         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
 195
 196         * GtkLauncher/main.cpp:
 197         (goToURLBarText):
 198         (main):
 199
 200 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
 201
 202         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
 203         <http://bugs.webkit.org/show_bug.cgi?id=15830>
 204
 205         Reviewed by Timothy.
 206
 207         Restrict the range of nightly builds used by the bisect-builds script
 208         based on the version of Safari and the version of Mac OS X being used.
 209
 210         Mac OS X 10.4: Safari 2.0: r11976 or newer
 211         Mac OS X 10.4: Safari 3.0: r19992 or newer
 212
 213         Mac OS X 10.5: Safari 2.0: r19594 or newer
 214         Mac OS X 10.5: Safari 3.0: r25124 or newer
 215
 216         * Scripts/bisect-builds:
 217         (findMacOSXVersion): Added.
 218         (makeNightlyList): Added argument to provide version of Mac OS X.
 219         Restrict range of nightly builds based on Safari and Mac OS X versions.
 220
 221 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
 222
 223         Reviewed by Maciej.
 224
 225         - This patch involves several changes, all of them were noticed that
 226         they were needed by the work being done in WebKit to get Drosera and
 227         WebKit working together on Windows.
 228         - The changes are:
 229         1) Added a debugger console for output messages.
 230         2) Drosera now listens for the WebKit server (before, the server would
 231         have to be running before Drosera was started.)
 232         3) Fixed a bug where the WebView started out as 0x0 pixels.
 233         4) Fixed a bug when there is no scope.
 234         5) Added the HTML, JS, and CSS to the project file to make them easy to
 235         find.
 236         6) Made the ServerConnection functions virtual.
 237
 238         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
 239         for the WebKit server.
 240         (DebuggerClient::DebuggerClient):
 241         (DebuggerClient::~DebuggerClient):
 242         (DebuggerClient::didFinishLoadForFrame):
 243         (DebuggerClient::serverConnected):
 244         (DebuggerClient::attemptToCreateServerConnection):
 245         * Drosera/win/DebuggerClient.h: Ditto.
 246         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
 247         scope.
 248         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 249         (DebuggerDocument::platformValueForScopeVariableNamed):
 250         * Drosera/win/Drosera.cpp:
 251         (_tWinMain): Added a console in debug for output messages.
 252         (Drosera::Drosera): Listen for server.
 253         (Drosera::initUI): The server now Initializes COM.
 254         (Drosera::serverConnected): Part of the listening for the server.
 255         (Drosera::attemptToCreateServerConnection): Ditto.
 256         * Drosera/win/Drosera.h: New interface for listening for the server.
 257         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
 258         files to the VS project.
 259         * Drosera/win/ServerConnection.cpp: Part of listening for the server
 260         connection.
 261         (ServerConnection::ServerConnection):
 262         (ServerConnection::attemptToCreateServerConnection):
 263         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
 264         methods.
 265         (ServerConnection::serverConnected):
 266
 267 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
 268
 269         Reviewed by Maciej.
 270
 271         http://bugs.webkit.org/show_bug.cgi?id=15832
 272         fast/dom/gc-10.html crashes when run alone
 273
 274         Check for !done before using objects that can be already deallocated.
 275
 276         * DumpRenderTree/mac/EditingDelegate.mm:
 277         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
 278         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
 279         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
 280         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
 281         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
 282         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
 283         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
 284         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
 285         (-[EditingDelegate webViewDidBeginEditing:]):
 286         (-[EditingDelegate webViewDidChange:]):
 287         (-[EditingDelegate webViewDidEndEditing:]):
 288         (-[EditingDelegate webViewDidChangeTypingStyle:]):
 289         (-[EditingDelegate webViewDidChangeSelection:]):
 290         * DumpRenderTree/mac/FrameLoadDelegate.mm:
 291         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
 292         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
 293         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
 294         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
 295         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
 296         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
 297         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
 298         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
 299         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
 300         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
 301         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
 302         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
 303         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
 304         (-[FrameLoadDelegate webView:willCloseFrame:]):
 305         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
 306         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
 307         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
 308         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
 309         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
 310         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
 311         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
 312         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
 313         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
 314
 315 2007-11-04  Mark Rowe  <mrowe@apple.com>
 316
 317         Build fix.  Don't use Carbon.h as the prefix header as it triggers
 318         warnings that would otherwise be suppressed due to it being a system header.
 319
 320         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 321
 322 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
 323
 324         Rubber stamped by Adam.
 325
 326         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
 327
 328         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 329
 330 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
 331
 332         Sort files(...); sections of Xcode project files.
 333
 334         Rubber-stamped by Darin.
 335
 336         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
 337         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
 338         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 339         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
 340
 341 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
 342
 343         Script to sort "files(...);" sections in Xcode project.pbxproj files.
 344
 345         Reviewed by Darin.
 346
 347         * Scripts/sort-Xcode-project-file: Added.
 348
 349 2007-11-02  Darin Adler  <darin@apple.com>
 350
 351         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
 352
 353 2007-11-02  Darin Adler  <darin@apple.com>
 354
 355         Reviewed by Maciej.
 356
 357         * Scripts/run-sunspider: Pass the "--base" option through.
 358
 359         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
 360         the real script do that. Default configuration to Release to match run-sunspider
 361         so we don't end up building Debug just to compare results.
 362
 363 2007-11-01  Adam Roben  <aroben@apple.com>
 364
 365         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
 366
 367         Reviewed by Sam.
 368
 369         * Scripts/commit-log-editor: Show all the directories beneath the
 370         source root, instead of just the last one.
 371
 372 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
 373
 374         Reviewed by Adam Roben.
 375
 376         Print out an error message when the Windows build fails
 377         and provide guidance on how to find out what went wrong.
 378
 379         * Scripts/build-webkit:
 380         * Scripts/webkitdirs.pm:
 381
 382 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
 383
 384         Rubber-stamped by Adam Roben.
 385
 386         Rolled out r27326 - debug CRT seems to cause no problems after all.
 387
 388         * DumpRenderTree/win/DumpRenderTree.vcproj:
 389
 390 2007-10-31  Adam Roben  <aroben@apple.com>
 391
 392         Switch the Debug configuration to using the non-debug CRT
 393
 394         This matches WebKit.
 395
 396         Reviewed by Steve.
 397
 398         * DumpRenderTree/win/DumpRenderTree.vcproj:
 399
 400 2007-10-31  Antti Koivisto  <antti@apple.com>
 401
 402         Reviewed by bdash.
 403
 404         Disable media tests when doing leak checking on Tiger.
 405         They crash in QuickTime (rdar://problem/5537157).
 406
 407         * Scripts/run-webkit-tests:
 408
 409 2007-10-29  Antti Koivisto  <antti@apple.com>
 410
 411         Reviewed by Maciej.
 412
 413         Build media support by default on OSX only.
 414
 415         * Scripts/build-webkit:
 416
 417 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
 418
 419         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
 420         get caught by the pre-commit hooks.
 421
 422 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
 423
 424         Reviewed by Adam.
 425
 426         - This is a collection of relatively unrelated changes and cleanups
 427         to Drosera to prepare it for interacting with WebKit.  A lot of these
 428         changes are just correcting mistakes, for example removing included
 429         headers that are no longer needed.
 430
 431         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
 432         this will be needed by the DebuggerClient.
 433         (DebuggerDocument::server):
 434         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
 435         * Drosera/win/DebuggerClient.cpp:
 436         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
 437         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
 438         (DebuggerClient::createWebViewWithRequest): Added comment about its
 439         purpose.
 440         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
 441         declarations.
 442         (DebuggerClient::webViewLoaded): Moved.
 443         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
 444         file, since this was the only place it was used.
 445         (cfStringToBSTR):
 446         * Drosera/win/Drosera.h: Cleaned up the includes.
 447         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
 448         * Drosera/win/HelperFunctions.h: Removed.
 449
 450 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
 451
 452         Reviewed by Adam.
 453
 454         - Small cleanup in the ServerConnection class.
 455
 456         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
 457         and added an include.
 458         (ServerConnection::currentFrame):
 459         (ServerConnection::getCallerFrame):
 460         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
 461         made a pointer into a COMPtr, and cleaned up the includes.
 462
 463 2007-10-29  Timothy Hatcher  <timothy@apple.com>
 464
 465         Reviewed by John Sullivan.
 466
 467         - Place the Localizable.strings file in mac or win directories
 468           if that location exists.
 469         - Also look for UI_STRING in .c files.
 470
 471         * Scripts/extract-localizable-strings:
 472
 473 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
 474
 475         Reviewed by Adam.
 476
 477         - Set the eol-style to native and made all the line endings the same
 478         so that I avoid messy diffs that show eol changes.
 479
 480         * Drosera/win/ServerConnection.cpp:
 481         (ServerConnection::didParseSource):
 482         (ServerConnection::didEnterCallFrame):
 483         (ServerConnection::willExecuteStatement):
 484         (ServerConnection::willLeaveCallFrame):
 485         (ServerConnection::exceptionWasRaised):
 486
 487 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
 488
 489         Reviewed by Adam.
 490
 491         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
 492         functionality that could not have existed previously without the new
 493         interfaces.
 494         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
 495         from a BSTR to a JSValueRef.
 496         (DebuggerDocument::platformEvaluateScript): Implemented.
 497         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
 498         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 499         Implemented.
 500         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
 501         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
 502         * Drosera/win/ServerConnection.cpp: Added a helper function.
 503         (ServerConnection::getCallerFrame):
 504         * Drosera/win/ServerConnection.h: Added a helper function.
 505
 506 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
 507
 508         updated reviewers for my previous changelog.
 509
 510 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
 511         Reviewed by Maciej and Adam and Geoff.
 512
 513         - Minor mac-side improvements including moving a function to a more
 514         appropriate location, fixing a warning, and correctly checking
 515         exceptions.
 516
 517         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
 518         (DebuggerDocument::willExecuteStatement):
 519         (DebuggerDocument::didEnterCallFrame):
 520         (DebuggerDocument::willLeaveCallFrame):
 521         (DebuggerDocument::windowScriptObjectAvailable):
 522         (DebuggerDocument::callFunctionOnObject):
 523         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
 524         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
 525         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
 526         because it doesn't require the ServerConnection at all.
 527         (NSStringCreateWithJSStringRef): Made an argument const.
 528         (JSValueRefCreateWithNSString): Made an argument const.
 529         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
 530         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 531         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
 532         * Drosera/mac/ServerConnection.mm: Ditto.
 533         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
 534
 535 2007-10-29  Sam Weinig  <sam@webkit.org>
 536
 537         Reviewed by Adam Roben.
 538
 539         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
 540
 541         * DumpRenderTree/LayoutTestController.cpp:
 542         (LayoutTestController::LayoutTestController):
 543         (getGlobalFlagCallback):
 544         (setGlobalFlagCallback):
 545         (LayoutTestController::getJSClass):
 546         (LayoutTestController::staticValues):
 547         * DumpRenderTree/LayoutTestController.h:
 548         (LayoutTestController::globalFlag):
 549         (LayoutTestController::setGlobalFlag):
 550
 551 2007-10-29  Darin Adler  <darin@apple.com>
 552
 553         Reviewed by Maciej.
 554
 555         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
 556         resolution instead of its default.
 557
 558 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
 559
 560         Fixed showStatus() to print status for successfully resolved conflicts when using git.
 561
 562         Reviewed by Mark Rowe.
 563
 564         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
 565         was successfully resolved, but this would not show any status because the change had
 566         already been cached in the index using "git add".  The solution is to add an optional
 567         second argument to showStatus() which adds the "--cached" switch to the command.
 568
 569         * Scripts/resolve-ChangeLogs:
 570         (showStatus):
 571
 572 2007-10-28  Eric Seidel  <eric@webkit.org>
 573
 574         Reviewed by Maciej and Geoff, in unison.
 575
 576         * Scripts/run-webkit-tests: remove broken --svg option
 577
 578 2007-10-28  Darin Adler  <darin@apple.com>
 579
 580         Reviewed by Adam.
 581
 582         * Scripts/run-sunspider: Default to "Release" configuration rather than
 583         defaulting to the last configuration used as other scripts do. This can
 584         still be overriden on the command line with "--debug" if there's some
 585         reason to do so. Also fix a typo.
 586
 587         * Scripts/sunspider-compare-results: Fix a typo.
 588
 589 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
 590
 591         Reviewed by Adam.
 592
 593         - Implemented the WebScriptDebugListener functions now that the
 594         WebScriptDebugServer exists
 595
 596         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
 597         functions.
 598         (ServerConnection::currentFrame):
 599         (ServerConnection::didLoadMainResourceForDataSource):
 600         (ServerConnection::didParseSource):
 601         (ServerConnection::failedToParseSource):
 602         (ServerConnection::didEnterCallFrame):
 603         (ServerConnection::willExecuteStatement):
 604         (ServerConnection::willLeaveCallFrame):
 605         (ServerConnection::exceptionWasRaised):
 606         * Drosera/win/ServerConnection.h: Removed unused arguments from the
 607         members arguments list.
 608
 609 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
 610
 611         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
 612         <http://bugs.webkit.org/show_bug.cgi?id=15600>
 613
 614         Reviewed by Darin.
 615
 616         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
 617         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
 618         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
 619         file.  Note that it may also be used as a stand-alone script.
 620
 621         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
 622         * Scripts/resolve-ChangeLogs: Added.
 623         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
 624
 625 2007-10-26  Mark Rowe  <mrowe@apple.com>
 626
 627         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
 628         to the Qt port on the assumption that it was an implementation of the cross-platform
 629         LayoutTestController class.  It is not, so it did not need to be changed.
 630
 631         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
 632
 633 2007-10-25  Mark Rowe  <mrowe@apple.com>
 634
 635         Reviewed by Maciej.
 636
 637         Fix builds with code coverage enabled.
 638
 639         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
 640
 641 2007-10-25  Darin Adler  <darin@apple.com>
 642
 643         Reviewed by Mark Rowe.
 644
 645         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
 646         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
 647
 648 2007-10-25  Stephanie  <slewis@apple.com>
 649
 650         build Fix
 651
 652         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 653
 654 2007-10-25  Stephanie  <slewis@apple.com>
 655
 656         Reviewed by Mark Rowe, Adam Roben.
 657
 658         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
 659
 660         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 661
 662 2007-10-25  Alice Liu  <alice.liu@apple.com>
 663
 664         Reviewed by Adam.
 665
 666         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
 667
 668         Moving destructor into platform-specific files
 669         * DumpRenderTree/LayoutTestController.cpp:
 670         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 671         (LayoutTestController::~LayoutTestController):
 672         * DumpRenderTree/qt/jsobjects.cpp:
 673         (LayoutTestController::~LayoutTestController):
 674
 675         LayoutTestController wasn't being destroyed
 676         * DumpRenderTree/win/DumpRenderTree.cpp:
 677         (runTest):
 678
 679         Added declspec
 680         * DumpRenderTree/win/EditingDelegate.h:
 681
 682         Reset certain values on the webview (or related delegate) that might
 683         have changed while running a test
 684         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 685         (LayoutTestController::~LayoutTestController):
 686
 687 2007-10-25  Adam Roben  <aroben@apple.com>
 688
 689         Make sunspider-compare-results work with relative paths
 690
 691         Reviewed by Sam.
 692
 693         * Scripts/sunspider-compare-results: Convert arguments to absolute
 694         paths before we chdir.
 695
 696 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
 697
 698         Reviewed by Sam.
 699
 700         - Implemented server calls now the WebScriptDebugServer exists.
 701         - Also removed no longer needed call to initialize CG.
 702
 703         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
 704         automatically now.
 705         (_tWinMain):
 706         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
 707         (ServerConnection::ServerConnection):
 708         (ServerConnection::~ServerConnection):
 709         (ServerConnection::pause):
 710         (ServerConnection::resume):
 711         (ServerConnection::stepInto):
 712         (ServerConnection::applicationTerminating):
 713         (ServerConnection::serverConnectionDidDie):
 714         * Drosera/win/ServerConnection.h: Now uses the COM class.
 715
 716 2007-10-24  George Staikos  <staikos@kde.org>
 717
 718         Unbreak Qt build.
 719
 720         * Scripts/build-webkit:
 721
 722 2007-10-24  Adam Roben  <aroben@apple.com>
 723
 724         Remove now-unnecessary call to InitializeCoreGraphics
 725
 726         WebKit takes care of this now.
 727
 728         Reviewed by Ada.
 729
 730         * DumpRenderTree/win/DumpRenderTree.cpp:
 731         (initialize):
 732
 733 2007-10-24  Adam Roben  <aroben@apple.com>
 734
 735         Use WebTextRenderer in DRT
 736
 737         Reviewed by Ada.
 738
 739         * DumpRenderTree/win/DumpRenderTree.cpp:
 740         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
 741
 742 2007-10-24  Sven Herzberg  <sven@imendio.com>
 743
 744         Reviewed by Mark Rowe.
 745
 746         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
 747         Bug 15614: [GTK] qmake based backends don't build on OS X
 748
 749         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
 750         GTK backend on a Mac
 751         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
 752         isDarwin() to make it reusable in other places (like the workaround-
 753         for-prebuilt-qmake in build-webkit)
 754
 755 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
 756
 757         Refurbish update-webkit script.
 758
 759         Reviewed by Adam.
 760
 761         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
 762         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
 763         multi-argument version of system() for flexibility and security.  Check for existence
 764         of Internal directory using -d test instead of -x.
 765
 766 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
 767
 768         Minor clean-up of prepare-ChangeLog script.
 769
 770         Reviewed by Adam.
 771
 772         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
 773         of a string.  Use multi-argument versions of open() and system() for flexibility and
 774         security.
 775
 776 2007-10-24  Alice Liu  <alice.liu@apple.com>
 777
 778         Reviewed by Oliver.
 779
 780         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
 781
 782         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to
 783         replay the saved events when we're still processing the mousedown that starts the drag
 784         * DumpRenderTree/win/EventSender.cpp:
 785         (doMouseMove):
 786         * DumpRenderTree/win/UIDelegate.cpp:
 787         (UIDelegate::doDragDrop):
 788
 789 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
 790
 791         Reviewed by Sam, Steve and Darin.
 792
 793         - Stubbed out the WebScriptDebugListener functionality in the Server
 794         Connection class to prepare it for receiving those callbacks.
 795         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
 796         and the ServerConnection to not need to be initialized with a server
 797         name, since that is not the way we connect to the WebKit server.
 798
 799         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
 800         no exception.  Now it only loggs when there is an exception
 801         (DebuggerDocument::willExecuteStatement):
 802         (DebuggerDocument::didEnterCallFrame):
 803         (DebuggerDocument::willLeaveCallFrame):
 804         (DebuggerDocument::windowScriptObjectAvailable):
 805         (DebuggerDocument::callFunctionOnObject):
 806         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
 807         to be instantiated with a server's name.
 808         (DebuggerClient::DebuggerClient):
 809         (DebuggerClient::didFinishLoadForFrame):
 810         * Drosera/win/DebuggerClient.h: Removed unsued variable.
 811         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
 812         a server name.
 813         (Drosera::init):
 814         (Drosera::initServer):
 815         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
 816         instantiated with a server's name.
 817         * Drosera/win/ServerConnection.cpp:
 818         (ServerConnection::ServerConnection): No longer needs a server name
 819         (ServerConnection::~ServerConnection): Only release the global context
 820         if there is one.
 821         (ServerConnection::serverConnectionDidDie): Stub for
 822         IWebScriptDebugListener
 823         (ServerConnection::QueryInterface): ditto
 824         (ServerConnection::AddRef): ditto
 825         (ServerConnection::Release): ditto
 826         (ServerConnection::didLoadMainResourceForDataSource): ditto
 827         (ServerConnection::didParseSource): ditto
 828         (ServerConnection::failedToParseSource): ditto
 829         (ServerConnection::didEnterCallFrame): ditto
 830         (ServerConnection::willExecuteStatement): ditto
 831         (ServerConnection::willLeaveCallFrame): ditto
 832         (ServerConnection::exceptionWasRaised): ditto
 833         * Drosera/win/ServerConnection.h: Stubbed out the
 834         IWebScriptDebugListener functions, and this class no longer needs to be
 835         instantiated with a server name.
 836
 837 2007-10-24  Lars Knoll  <lars@trolltech.com>
 838
 839         Reviewed by Simon.
 840
 841         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
 842
 843         * DumpRenderTree/qt/jsobjects.h:
 844
 845 2007-10-24  Lars Knoll  <lars@trolltech.com>
 846
 847         Reviewed by Simon.
 848
 849         add another command.
 850
 851         * DumpRenderTree/qt/jsobjects.cpp:
 852         (TextInputController::doCommand):
 853
 854 2007-10-24  Lars Knoll  <lars@trolltech.com>
 855
 856         Reviewed by Simon.
 857
 858         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
 859
 860         * DumpRenderTree/qt/jsobjects.cpp:
 861         (EventSender::keyDown):
 862         * DumpRenderTree/qt/jsobjects.h:
 863
 864 2007-10-24  Lars Knoll  <lars@trolltech.com>
 865
 866         Reviewed by Simon.
 867
 868         implement eventSender.keyDown().
 869
 870         * DumpRenderTree/qt/jsobjects.cpp:
 871         (EventSender::keyDown):
 872
 873 2007-10-24  Lars Knoll  <lars@trolltech.com>
 874
 875         Reviewed by Simon.
 876
 877         some smaller fixes to the editing support in DRT. Makes another few tests pass.
 878
 879         * DumpRenderTree/qt/DumpRenderTree.cpp:
 880         (WebCore::DumpRenderTree::DumpRenderTree):
 881         (WebCore::DumpRenderTree::initJSObjects):
 882         * DumpRenderTree/qt/jsobjects.cpp:
 883         (TextInputController::doCommand):
 884
 885 2007-10-24  Lars Knoll  <lars@trolltech.com>
 886
 887         Reviewed by Simon.
 888
 889         first bit of implementation for the textinputcontroller.
 890
 891         * DumpRenderTree/qt/DumpRenderTree.cpp:
 892         (WebCore::DumpRenderTree::DumpRenderTree):
 893         * DumpRenderTree/qt/DumpRenderTree.h:
 894         * DumpRenderTree/qt/jsobjects.cpp:
 895         (TextInputController::TextInputController):
 896         (TextInputController::doCommand):
 897         * DumpRenderTree/qt/jsobjects.h:
 898
 899 2007-10-24  Lars Knoll  <lars@trolltech.com>
 900
 901         Reviewed by Simon.
 902
 903         make the man webpage believe it has focus, so the editing tests work correctly.
 904
 905         * DumpRenderTree/qt/DumpRenderTree.cpp:
 906         (WebCore::DumpRenderTree::DumpRenderTree):
 907
 908 2007-10-24  Lars Knoll  <lars@trolltech.com>
 909
 910         Reviewed by Simon.
 911
 912         implement layoutTestController.dumpEditingCallbacks() correctly.
 913
 914         * DumpRenderTree/qt/DumpRenderTree.cpp:
 915         (WebCore::DumpRenderTree::DumpRenderTree):
 916         * DumpRenderTree/qt/jsobjects.cpp:
 917         (LayoutTestController::reset):
 918         (LayoutTestController::dumpEditingCallbacks):
 919
 920 2007-10-24  Lars Knoll  <lars@trolltech.com>
 921
 922         Reviewed by Simon.
 923
 924         Implement support for testing editing.
 925
 926         * DumpRenderTree/qt/DumpRenderTree.cpp:
 927         (WebCore::DumpRenderTree::DumpRenderTree):
 928
 929 2007-10-23  Sam Weinig  <sam@webkit.org>
 930
 931         Check for null BSTR that can be passed to the UIDelegate methods
 932         from javascript null and undefined.  Fixes a failing test case on
 933         Windows (fast/dom/Window/alert-undefined.html)
 934
 935         Reviewed by Eric Seidel.
 936
 937         * DumpRenderTree/win/UIDelegate.cpp:
 938         (UIDelegate::runJavaScriptAlertPanelWithMessage):
 939         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
 940         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
 941         (UIDelegate::webViewAddMessageToConsole):
 942
 943 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
 944
 945         Reviewed by Darin.
 946
 947         Don't print a massive pile of setenvs from tools that automatically build testkjs.
 948
 949         * Scripts/build-testkjs:
 950
 951 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
 952
 953         Reviewed by Darin.
 954
 955         - add wrapper that finds the right copy of testkjs
 956
 957         * Scripts/sunspider-compare-results: Added.
 958
 959 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
 960
 961         Reviewed by Sam.
 962
 963         - After talking with Steve I now see that the WebKit server must be
 964         running for DCOM to create the distributed objects, which makes sense
 965         and currently WebKit only allows one instance to be running at a time
 966         which avoids accidentally connecting to the wrong server
 967         - In light of this I have removed the code for the attach box and
 968         NotificationServer and known server names, since they are all extranious
 969         now.
 970
 971         * Drosera/win/Drosera.cpp: Removed notification classes and known server
 972         names.
 973         (_tWinMain): Uses init instead of initUI.
 974         (droseraWndProc): No longer creats an attach dialog box.
 975         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
 976         it's not manditory to call init before doing COM stuff.
 977         (Drosera::init): calls initUI and will call attach when the
 978         functionality exists.
 979         (Drosera::initUI): Has changed very little.
 980         (Drosera::attach): Changed the signature to reflect that we no longer
 981         need the dictionary of known server names.
 982         * Drosera/win/Drosera.h: Removed notification classes and known server
 983         names.  Also renamed and moved some functions.
 984         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
 985         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
 986         headers to the resources folder.
 987         * Drosera/win/resource.h: Removed the Attach box.
 988
 989 2007-10-22  Adam Roben  <aroben@apple.com>
 990
 991         Windows build fix
 992
 993         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
 994
 995 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
 996
 997         - Removed a leak that was fixed.
 998
 999         * Scripts/run-webkit-tests:
1000
1001 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1002
1003         Reviewed by Darin.
1004
1005         - Changed the Client so that the DebuggerDocument now own the
1006         ServerConnection.  This simplifies ownership and cleanup.
1007
1008         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
1009         ServerConnection.
1010         (DebuggerClient::initWithServerName):
1011         (DebuggerClient::didFinishLoadForFrame):
1012         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the
1013         ServerConnection.
1014         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
1015         until after we have a server which we are attached to.
1016         (Drosera::initUI):
1017         (Drosera::attach):
1018         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
1019         out previously.
1020
1021 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1022
1023         Reviewed by Nikolas.
1024
1025         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
1026
1027         * Scripts/run-javascriptcore-tests:
1028
1029 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1030
1031         Reviewed by Nikolas.
1032
1033         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
1034
1035         * Scripts/build-drosera:
1036         * Scripts/build-dumprendertree:
1037         * Scripts/build-testkjs:
1038         * Scripts/build-webkit:
1039         * Scripts/run-javascriptcore-tests:
1040         * Scripts/run-sunspider:
1041         * Scripts/run-webkit-tests:
1042         * Scripts/webkitdirs.pm:
1043
1044 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
1045
1046         Reviewed by Mark Rowe.
1047
1048         Fix for local database support after r26879
1049         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
1050
1051         * Scripts/build-webkit:
1052
1053 2007-10-22  Holger Freyther  <zecke@selfish.org>
1054
1055         Reviewed by Simon Hausmann <hausmann@kde.org>.
1056
1057         - Do not build testkjs as an application bundle. This is
1058         needed for run-javascriptcore-tests on OSX.
1059         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
1060         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
1061         as we do not have -rpath on OSX.
1062
1063         * DumpRenderTree/qt/DumpRenderTree.pro:
1064         * Scripts/run-webkit-tests:
1065
1066 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1067
1068         Reviewed by aroben.
1069
1070         Fix support for Signed-off-by detection in prepare-ChangeLog
1071         --git-commit. The Signed-off-by tag does not appear in the header
1072         but usually at the end.
1073
1074         * Scripts/prepare-ChangeLog:
1075
1076 2007-10-21  Mark Rowe  <mrowe@apple.com>
1077
1078         Reviewed by Eric.
1079
1080         Fix run-javascriptcore-tests for Gtk.
1081
1082         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
1083
1084 2007-10-20  Eric Seidel  <eric@webkit.org>
1085
1086         Reviewed by aroben.
1087
1088         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
1089
1090 2007-10-20  Eric Seidel  <eric@webkit.org>
1091
1092         Reviewed by darin.
1093
1094         Add improved argument handling to run-sunspider, including
1095         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
1096         Also re-factor code into subroutines
1097
1098         * Scripts/build-dumprendertree: removed bogus comments
1099         * Scripts/build-testkjs: Added.
1100         * Scripts/run-javascriptcore-tests: use build-testkjs
1101         * Scripts/run-sunspider: improved argument handling, abstraction
1102         * Scripts/run-webkit-tests: improved abstraction
1103
1104 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
1105
1106         Not reviewed, Windows build fix.
1107
1108         * DumpRenderTree/win/EventSender.cpp:
1109         (keyDownCallback):
1110
1111 2007-10-20  Darin Adler  <darin@apple.com>
1112
1113         Reviewed by Tim Hatcher.
1114
1115         - http://bugs.webkit.org/show_bug.cgi?id=15544
1116           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
1117           not rely on Apple-specific key codes
1118
1119         * DumpRenderTree/mac/EventSendingController.mm:
1120         (-[EventSendingController keyDown:withModifiers:]):
1121         Added named key "rightArrow". Later we could have a whole table of these.
1122         Also tweaked modifiers code a little.
1123
1124         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
1125
1126 2007-10-19  Darin Adler  <darin@apple.com>
1127
1128         Reviewed by Eric.
1129
1130         - http://bugs.webkit.org/show_bug.cgi?id=15566
1131           possible fix for leak seen in DumpRenderTree
1132
1133         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
1134         Delete the item if it's not put on the queue, since the caller has
1135         no way of knowing that. Would be better to have the parameter type
1136         be auto_ptr to express the fact that we take ownership.
1137
1138         - unrelated change
1139
1140         * Drosera/mac/main.m: Add missing include.
1141
1142 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1143
1144         Reviewed by Adam.
1145
1146         - This change should be identical but for some reason was not working
1147         on my machine.
1148
1149         * Scripts/prepare-ChangeLog:
1150
1151 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1152
1153         Reviewed by Oliver and Tim.
1154
1155         - Made use of RetainPtr to avoid retain and release issues and moved the
1156         log function to DebuggerDocumentPlatform, which seems to be a more
1157         logical place for it to live.
1158         - Also moved knownServers from the ServerConnection to
1159         DebuggerApplication to match the Windows code and because it makes sense
1160         that a connection knows its own server but not all of them.
1161
1162         * Drosera/mac/DebuggerClient.h: Moved the log function to
1163           DebuggerDocumentPlatform.
1164         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
1165           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
1166           call for the server name up from the ServerConnection class.
1167         (-[DebuggerClient dealloc]):
1168         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
1169           for the server name up from the ServerConnection.
1170         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
1171         (DebuggerDocument::platformPause):
1172         (DebuggerDocument::platformResume):
1173         (DebuggerDocument::platformStepInto):
1174         (DebuggerDocument::platformEvaluateScript):
1175         (DebuggerDocument::getPlatformCurrentFunctionStack):
1176         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1177         (DebuggerDocument::platformValueForScopeVariableNamed):
1178         (DebuggerDocument::platformLog): Log directly from here. No need to call
1179           DebuggerClient.
1180         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
1181           way I see it, a ServerConnection should only know about its connection
1182           and the group of all possible servers should be kept by the
1183           application.
1184         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
1185           currentServerName, it makes sense that the connection should know that
1186           name.
1187         (-[ServerConnection currentServerName]):
1188
1189 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1190
1191         Reviewed by Adam.
1192
1193         - Integrated changes from mac drosera.  Recently I've encapsulated
1194         out the server connection object from the rest of Drosera because
1195         it is very platform dependent right now and RPC is not implemented on
1196         windows.  This functionality, of communicating with the WebKit server
1197         is the next area I will be focusing on in Windows.
1198
1199         - Other changes and cleanup were made to organize the code and add notes
1200         on which parts still need work.  Also some mac code is added and
1201         commented out, to act as pseudocode for the logic of those parts.
1202
1203         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
1204           pointer.
1205         * Drosera/config.h: Added whitespace.
1206         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
1207           these files got moved into Drosera.h/cpp
1208         * Drosera/win/DebuggerApplication.h: Removed.
1209         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring
1210           happened here to better match the logic flow of the same code on the
1211           mac side and to use the new ServerConnection class.
1212         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
1213         (DebuggerClient::initWithServerName): Initializer that will set up the
1214           class to use a ServerConnection object.  This was necessary so I could
1215           create a DebuggerClient without having to initilaize it at
1216           construction.
1217         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
1218           will be the UIDelegate and FrameLoadDelegate.
1219         (DebuggerClient::AddRef): For IUnknown.
1220         (DebuggerClient::Release): For IUnknown.
1221         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
1222           this still needs to set the global context of the server, but
1223           IWebFrame does not have an accessor for the global context yet.
1224         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
1225           this is a pass through for the same function in the document.
1226         (DebuggerClient::didReceiveTitle): Unimplemented part of
1227           FrameLoadDelegate this would change the title of the window.
1228         (DebuggerClient::createWebViewWithRequest): Part of the
1229           FrameLoadDelegate.  This is about new windows via Window.open() and
1230           how their delegates are set.
1231         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
1232           UIDelegate.  Just a debug function for printing messages.
1233         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
1234           because the Client should be the UIDelegate and FrameLoadDelegate
1235           to match the delegates on mac.
1236         (DebuggerClient::webViewLoaded): Added accessor method.
1237         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
1238           forgotten to add this file before.  This is where the platform
1239           dependent versions of the Documents functions live. Most of these are
1240           unimplemented because some piece of functionality does not exist on
1241           Windows yet.
1242         (DebuggerDocument::platformPause):
1243         (DebuggerDocument::platformResume):
1244         (DebuggerDocument::platformStepInto):
1245         (DebuggerDocument::platformEvaluateScript):
1246         (DebuggerDocument::getPlatformCurrentFunctionStack):
1247         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1248         (DebuggerDocument::platformValueForScopeVariableNamed):
1249         (DebuggerDocument::platformLog):
1250         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
1251           responsibilities becaue they belong in the Client. Also I laid the
1252           groundwork for attaching Drosera to a WebKit process
1253         (attachWndProc): Now if a server is selected the Client becomes it's
1254           delegate.
1255         (Drosera::Drosera): Added the construction of the Client and dictionary
1256           of server names.
1257         (Drosera::initUI): This is no longer the delegates, the Client is.
1258         (Drosera::webViewLoaded): Now asks the Client instead of holding local
1259           state.
1260         (Drosera::applicationDidFinishLaunching): Placeholder for needed
1261           notification registration when it's possible to implement.
1262         (Drosera::serverLoaded): Ditto
1263         (Drosera::serverUnloaded): Ditto
1264         (Drosera::attach): Attach Drosera to the WebKit server.
1265         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
1266         (Drosera::getInst):
1267         (Drosera::setInst):
1268         (Drosera::knownServers):
1269         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
1270           and added the ServerConnection.
1271         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
1272         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
1273           Most of the functions are completely unimlemented because they cannot
1274           connect with the WebKit server, because one does not exist on Windows
1275           yet.
1276         (ServerConnection::initWithServerName):
1277         (ServerConnection::~ServerConnection):
1278         (ServerConnection::setGlobalContext):
1279         (ServerConnection::pause):
1280         (ServerConnection::resume):
1281         (ServerConnection::stepInto):
1282         (ServerConnection::switchToServerNamed):
1283         (ServerConnection::applicationTerminating):
1284         (ServerConnection::serverConnectionDidDie):
1285         (ServerConnection::currentFrame):
1286         * Drosera/win/ServerConnection.h: Added. Ditto.
1287         (ServerConnection::ServerConnection):
1288
1289 2007-10-19  Alice Liu  <alice.liu@apple.com>
1290
1291         Reviewed by Darin.
1292
1293         Fix for these broken layout tests on Windows:
1294
1295         fast/forms/focus-selection-input.html
1296         fast/forms/focus-selection-textarea.html
1297         fast/forms/select-accesskey.html
1298
1299         * DumpRenderTree/win/EventSender.cpp:
1300         (keyDownCallback):
1301         correct the VK code for alt key.
1302
1303 2007-10-19  Eric Seidel  <eric@webkit.org>
1304
1305         Reviewed by Mark Rowe.
1306
1307         Make the GtkLauncher code slightly more readable.
1308
1309         * GtkLauncher/main.cpp:
1310         (setupMainMenu): Added.
1311         (setupMainWindowUI): Added.
1312         (main):
1313
1314 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
1315
1316         Rubber stamped by Adam.
1317
1318         - don't delay-load WebKit in DumpRenderTree.
1319
1320         * DumpRenderTree/win/DumpRenderTree.vcproj:
1321
1322 2007-10-18  Dan Bernstein  <mitz@apple.com>
1323
1324         Reviewed by Adam Roben.
1325
1326         - fix <rdar://problem/5313523>
1327         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
1328
1329         * DumpRenderTree/mac/DumpRenderTree.mm:
1330         (dump): Changed to use _responseMIMEType.
1331
1332 2007-10-17  Adam Roben  <aroben@apple.com>
1333
1334         Make it possible to have Windows-specific tests and results
1335
1336         When searching for tests to run and the Skipped file, we will only
1337         look in platform/win and the cross-platform directory. When looking
1338         for expected results, we will look in platform/win, then
1339         platform/mac-leopard, then platform/mac, then finally the
1340         cross-platform directory.
1341
1342         Reviewed by Sam.
1343
1344         * Scripts/run-webkit-tests:
1345         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
1346         searching in the cross-platform directory.
1347         (sub buildPlatformHierarchy): Removed some unneeded calls to
1348         dirname/basename.
1349
1350 2007-10-17  Adam Roben  <aroben@apple.com>
1351
1352         Add back the call to register WebKit that we had before WebKitInitializer existed
1353
1354         This is needed to ensure that the right WebKit is used when
1355         instantiating COM objects.
1356
1357         Reviewed by Oliver.
1358
1359         * DumpRenderTree/win/debug_internal.vsprops: Define
1360         DEBUG_WEBKIT_HAS_SUFFIX.
1361         * DumpRenderTree/win/DumpRenderTree.cpp:
1362         (initialize):
1363
1364 2007-10-17  Adam Roben  <aroben@apple.com>
1365
1366         Import File::Basename in webkitdirs since we use it
1367
1368         * Scripts/webkitdirs.pm:
1369
1370 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
1371
1372         - Updated the tiger leaks list to make the internal bots green.
1373
1374         * Scripts/run-webkit-tests:
1375
1376 2007-10-17  Adam Roben  <aroben@apple.com>
1377
1378         Build fix for VC++ Express
1379
1380         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
1381         and ole32.lib.
1382
1383 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
1384
1385         Reviewed by Sam.
1386
1387         - Minor mac improvements based on observations I made while implementing the
1388         Windows code.
1389
1390         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
1391         then hand it to the Client who will retain it, it should just be the client who
1392         creates and owns the server.
1393         (-[DebuggerApplication attach:]):
1394         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
1395         * Drosera/mac/DebuggerClient.mm: Creates the server.
1396         (-[DebuggerClient initWithServerName:]):
1397         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
1398         can instead forward declare what it needs.
1399
1400 2007-10-16  Darin Adler  <darin@apple.com>
1401
1402         Reviewed by Geoff Garen.
1403
1404         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
1405         want to turn failing tests into platform-specific test results. Also did a
1406         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
1407         would take the type of results into account only some of the time.
1408
1409 2007-10-16  Adam Roben  <aroben@apple.com>
1410
1411         Add a new nightly launcher script for Windows
1412
1413         This new script is for versions of Safari that don't delay-load
1414         WebKit. I had to make FindSafari be able to print out the nightly
1415         launcher script on stdout because Windows shell scripts can't capture
1416         the output from a command into an environment variable.
1417
1418         Reviewed by Steve.
1419
1420         * FindSafari/FindSafari.cpp:
1421         (_tmain): Added /printSafariLauncher option.
1422         * Scripts/run-webkit-nightly.cmd: Added.
1423
1424 2007-10-16  Adam Roben  <aroben@apple.com>
1425
1426         Replace WebKitInitializer with FindSafari
1427
1428         We now rely on setting the PATH environment variable to tell Windows
1429         where to find WebKit and its dependencies (similar to
1430         DYLD_FRAMEWORK_PATH on Mac).
1431
1432         This change also make DumpRenderTree no longer delay-load WebKit.
1433
1434         Reviewed by Sam.
1435
1436         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
1437         FindSafari.
1438         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
1439         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
1440         WebKitInitializer, don't delay-load WebKit.
1441         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
1442         * Scripts/run-webkit-tests: Ditto.
1443         * Scripts/webkitdirs.pm:
1444         (sub setPathForRunningWebKitApp): Added.
1445         * WebKitInitializer/WebKitInitializer.cpp: Removed.
1446         * WebKitInitializer/WebKitInitializer.h: Removed.
1447         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
1448         * WebKitInitializer/debug.vsprops: Removed.
1449         * WebKitInitializer/debug_internal.vsprops: Removed.
1450         * WebKitInitializer/release.vsprops: Removed.
1451
1452 2007-10-16  Adam Roben  <aroben@apple.com>
1453
1454         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
1455
1456         http://bugs.webkit.org/show_bug.cgi?id=15532
1457
1458         FindSafari simply prints the location of an installed Safari.exe on
1459         stdout.
1460
1461         Reviewed by Darin.
1462
1463         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
1464         (getStringValue):
1465         (getWebViewCLSID):
1466         (getInstalledWebKitDirectory):
1467         (_tmain):
1468         * FindSafari/FindSafari.vcproj: Added.
1469         * Scripts/webkitdirs.pm:
1470         (sub installedSafariPath): Added. Calls FindSafari on Windows.
1471
1472 2007-10-16  Adam Roben  <aroben@apple.com>
1473
1474         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
1475
1476         Reviewed by Kevin McCullough.
1477
1478         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
1479         when referring to WebKit.dll.
1480         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
1481         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
1482         * DumpRenderTree/win/release.vsprops: Ditto.
1483         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
1484         never have a _debug suffix on WebKit.dll.
1485         * WebKitInitializer/WebKitInitializer.cpp:
1486         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
1487         specified.
1488         * WebKitInitializer/debug_internal.vsprops: Added
1489         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
1490
1491 2007-10-16  Darin Adler  <darin@apple.com>
1492
1493         Reviewed by Adele.
1494
1495         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
1496         Remove now-unneeded control/alt key hack; the tests have been updated.
1497
1498 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
1499
1500         - Updated leaks list because our internal bot upgraded it's version of leopard and
1501         one of the leaks was fixed between that revision and the bot's previous version of
1502         leopard.
1503
1504         * Scripts/run-webkit-tests:
1505
1506 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
1507
1508         Reviewed by Tim.
1509
1510         - I encapsulated out the server connecton functionality because it is a specific part
1511         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
1512         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
1513         Windows.  So the majority of this patch is moving preexisting functionality.
1514
1515         - Also I removed the prefix header and changed to use config.h because it is more
1516         standard on how we use config.h in windows and it didn't make much sense to keep
1517         the prefix header and the config.h
1518
1519         * Drosera/DebuggerDocument.cpp:
1520         (DebuggerDocument::DebuggerDocument):
1521         * Drosera/DebuggerDocument.h:
1522         * Drosera/config.h:
1523         * Drosera/mac/DebuggerApplication.mm:
1524         (-[DebuggerApplication attach:]):
1525         * Drosera/mac/DebuggerClient.h:
1526         * Drosera/mac/DebuggerClient.mm:
1527         (-[DebuggerClient initWithServerConnection:]):
1528         (-[DebuggerClient dealloc]):
1529         (-[DebuggerClient windowDidLoad]):
1530         (-[DebuggerClient windowWillClose:]):
1531         (-[DebuggerClient webView:didFinishLoadForFrame:]):
1532         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
1533         * Drosera/mac/DebuggerDocumentPlatform.mm:
1534         (DebuggerDocument::platformPause):
1535         (DebuggerDocument::platformResume):
1536         (DebuggerDocument::platformStepInto):
1537         (DebuggerDocument::platformEvaluateScript):
1538         (DebuggerDocument::getPlatformCurrentFunctionStack):
1539         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1540         (DebuggerDocument::platformValueForScopeVariableNamed):
1541         (DebuggerDocument::platformLog):
1542         * Drosera/mac/Drosera.pch: Removed.
1543         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1544         * Drosera/mac/ServerConnection.h: Added.
1545         * Drosera/mac/ServerConnection.mm: Added.
1546         (-[ServerConnection initWithServerName:]):
1547         (-[ServerConnection dealloc]):
1548         (-[ServerConnection setGlobalContext:]):
1549         (-[ServerConnection pause]):
1550         (-[ServerConnection resume]):
1551         (-[ServerConnection stepInto]):
1552         (-[ServerConnection switchToServerNamed:]):
1553         (-[ServerConnection applicationTerminating:]):
1554         (-[ServerConnection serverConnectionDidDie:]):
1555         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
1556         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
1557         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
1558         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
1559         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
1560         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
1561         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
1562         (-[ServerConnection currentFrame]):
1563         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
1564         (-[ServerConnection knownServers]):
1565
1566 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
1567
1568         Reviewed by Eric.
1569
1570         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
1571           Script to automatically search nightly builds for regressions (bisect-builds)
1572
1573         * Scripts/bisect-builds: Added.
1574
1575 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
1576
1577         Reviewed by Darin.
1578
1579         - New JavaScript benchmark
1580         http://bugs.webkit.org/show_bug.cgi?id=15515
1581
1582         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
1583         current development or release build of JavaScriptCore.
1584
1585 2007-10-15  Mark Rowe  <mrowe@apple.com>
1586
1587         Reviewed by Sam.
1588
1589         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
1590
1591         * Scripts/webkitdirs.pm:
1592         - Change checkArgv to remove the options from @ARGV to prevent
1593         them from interfering with further option processing.
1594         - Fix logic error in determineIsQt that would prevent it from bailing out early.
1595         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
1596         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
1597         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
1598
1599 2007-10-15  Darin Adler  <darin@apple.com>
1600
1601         Reviewed by Sam.
1602
1603         - added logging of window.prompt and window.confirm
1604
1605         * DumpRenderTree/mac/UIDelegate.mm:
1606         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
1607         Implement the recommended delegate rather than the deprecated one.
1608         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
1609         Added.
1610         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
1611         Added.
1612
1613         * DumpRenderTree/win/UIDelegate.h:
1614         * DumpRenderTree/win/UIDelegate.cpp:
1615         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
1616         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
1617         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
1618         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
1619
1620 2007-10-15  Alice Liu  <alice.liu@apple.com>
1621
1622         Reviewed by Sam Weinig.
1623
1624         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
1625
1626         * DumpRenderTree/win/DumpRenderTree.cpp:
1627         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
1628         (main): allocate the global policy delegate for DRT's custom use
1629         * DumpRenderTree/win/DumpRenderTree.vcproj:
1630         Adding files to project
1631         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
1632         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1633         (LayoutTestController::setCustomPolicyDelegate):
1634         set the webview's policy delegate to DRT's custom one if the test requests it.
1635         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
1636         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
1637         (PolicyDelegate::PolicyDelegate):
1638         (PolicyDelegate::QueryInterface):
1639         (PolicyDelegate::AddRef):
1640         (PolicyDelegate::Release):
1641         (PolicyDelegate::decidePolicyForNavigationAction):
1642         * DumpRenderTree/win/PolicyDelegate.h: Added.
1643         (PolicyDelegate::decidePolicyForNewWindowAction):
1644         (PolicyDelegate::decidePolicyForMIMEType):
1645         (PolicyDelegate::unableToImplementPolicyWithError):
1646
1647 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
1648
1649         Reviewed by Mark.
1650
1651         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
1652         when querying for QMAKE_MKSPECS.
1653
1654 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
1655
1656         Reviewed by Adam Roben.
1657
1658         Fix run-webkit-tests is too greedy calculating platform hierarchy
1659         http://bugs.webkit.org/show_bug.cgi?id=15465
1660
1661         Fix run-webkit-tests being too greedy in trying to split the platform name up
1662         causing it to try and find tests in every directory above the first "-" in the
1663         path to the LayoutTests
1664
1665         * Scripts/run-webkit-tests:
1666
1667 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
1668
1669         Reviewed by Darin.
1670
1671         http://bugs.webkit.org/show_bug.cgi?id=15006
1672         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
1673         to reduce code duplication.
1674
1675         * Scripts/build-webkit:
1676         * Scripts/webkitdirs.pm:
1677         buildQMakeProject() renamed to buildQMakeQtProject().
1678         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
1679         unused $colorize has been removed.
1680
1681 === Start merge of feature-branch 2007-10-12 ===
1682
1683 2007-10-08  Eric Seidel  <eric@webkit.org>
1684
1685         Reviewed by Mark Rowe.
1686
1687         * Scripts/build-webkit: add --help, remove unused --color
1688
1689 2007-10-07  Eric Seidel  <eric@webkit.org>
1690
1691         Reviewed by darin.
1692
1693         * Drosera/mac/DebuggerDocumentPlatform.mm:
1694         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
1695
1696 2007-10-03  Rob Buis  <buis@kde.org>
1697
1698         Reviewed by Olliej.
1699
1700         Adapt to changed location of Ahem font.
1701
1702         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1703
1704 2007-10-02  Eric Seidel  <eric@webkit.org>
1705
1706         Reviewed by Adam Roben.
1707
1708         Make pixel tests more useful!
1709         Finally fix the image diff 0.00% mystery problem
1710         Highlight any image differences in the image diff.
1711         Add a link from image diffs back to original test file.
1712
1713         * DumpRenderTree/mac/ImageDiff.m:
1714         (compareImages): highlight any differences
1715         (computePercentageDifferent): round to two decimal places
1716         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
1717
1718 2007-10-02  Eric Seidel  <eric@webkit.org>
1719
1720         Reviewed by Alexey Proskuryakov.
1721
1722         * Scripts/run-webkit-tests: print the % image difference on main results page
1723
1724 2007-10-02  Mark Rowe  <mrowe@apple.com>
1725
1726         Reviewed by Oliver.
1727
1728         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
1729
1730         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
1731         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
1732
1733 2007-10-01  Mark Rowe  <mrowe@apple.com>
1734
1735         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
1736
1737 2007-09-25  Eric Seidel  <eric@webkit.org>
1738
1739         Reviewed by Mark Rowe.
1740
1741         DerivedSources.make was finding "ENABLE_SVG" in the string
1742         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
1743         quite correctly.
1744
1745         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
1746
1747 2007-09-25  Mark Rowe  <mrowe@apple.com>
1748
1749         Rubber-stamped by Eric.
1750
1751         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
1752         This makes it possible to automate nightly builds for the feature-branch.
1753
1754 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
1755
1756         Rubber stamped by Mark.
1757
1758         Enable svg experimental features as default here in feature-branch.
1759
1760         * Scripts/build-webkit:
1761
1762 2007-06-29  Antti Koivisto  <antti@apple.com>
1763
1764         Reviewed by Weinig.
1765
1766         Add VIDEO flag for timed media features
1767
1768         * Scripts/build-webkit
1769
1770 === End merge of feature-branch 2007-10-12 ===
1771
1772 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
1773
1774         Reviewed by Darin.
1775
1776         - Updated rational for the leaks list to be more clear.
1777
1778         * Scripts/run-webkit-tests:
1779
1780 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
1781
1782         Rubber Stamp by Sam.
1783
1784         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
1785         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
1786
1787         * Scripts/run-webkit-tests:
1788
1789 2007-10-10  Simon Hausmann  <hausmann@kde.org>
1790
1791         Reviewed by Lars.
1792
1793         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
1794         includes are needed for INT_MAX, std::auto_ptr and the like.
1795
1796         * DumpRenderTree/qt/main.cpp:
1797
1798 2007-10-09  Lars Knoll  <lars@trolltech.com>
1799
1800         Reviewed by Simon.
1801
1802         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
1803
1804         * DumpRenderTree/qt/jsobjects.cpp:
1805         (LayoutTestController::encodeHostName):
1806         (LayoutTestController::decodeHostName):
1807         * DumpRenderTree/qt/jsobjects.h:
1808
1809 2007-10-09  Lars Knoll  <lars@trolltech.com>
1810
1811         Reviewed by Simon.
1812
1813         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
1814
1815         * DumpRenderTree/qt/DumpRenderTree.cpp:
1816         (WebCore::WebPage::createFrame):
1817         (WebCore::DumpRenderTree::DumpRenderTree):
1818         (WebCore::DumpRenderTree::titleChanged):
1819         * DumpRenderTree/qt/DumpRenderTree.h:
1820         * DumpRenderTree/qt/jsobjects.cpp:
1821         (LayoutTestController::reset):
1822         * DumpRenderTree/qt/jsobjects.h:
1823
1824 2007-10-09  Lars Knoll  <lars@trolltech.com>
1825
1826         Reviewed by Simon.
1827
1828         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
1829
1830         * DumpRenderTree/qt/DumpRenderTree.h:
1831         * DumpRenderTree/qt/jsobjects.cpp:
1832         (LayoutTestController::clearBackForwardList):
1833         * DumpRenderTree/qt/jsobjects.h:
1834
1835 2007-10-09  Lars Knoll  <lars@trolltech.com>
1836
1837         Reviewed by Simon.
1838
1839         make --git-reviewer work again.
1840
1841         * Scripts/prepare-ChangeLog:
1842
1843 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
1844
1845         Rubber stamped by Eric.
1846
1847         Connect to the "hovering-over-link" signal emitted by WebKitPage and
1848         show the current link inside the statusbar.
1849         This shows how to make use of this signal and allows to easily test
1850         http://bugs.webkit.org/show_bug.cgi?id=15299.
1851
1852         * GtkLauncher/main.cpp:
1853         (hoveringOverLink):
1854         (main):
1855
1856 2007-10-05  Lars Knoll  <lars@trolltech.com>
1857
1858         add proper error messages to the FrameLoaderClient.
1859         Implement ChromeClientQt::closeWindowSoon and
1860         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
1861         Some fixes in DRT to make it work correctly with multiple windows.
1862
1863         Reviewed by Maciej.
1864
1865         * DumpRenderTree/qt/DumpRenderTree.cpp:
1866         (WebCore::DumpRenderTree::DumpRenderTree):
1867         (WebCore::DumpRenderTree::createWindow):
1868         (WebCore::DumpRenderTree::windowCount):
1869         * DumpRenderTree/qt/DumpRenderTree.h:
1870         * DumpRenderTree/qt/jsobjects.cpp:
1871         (LayoutTestController::maybeDump):
1872         (LayoutTestController::windowCount):
1873         * DumpRenderTree/qt/jsobjects.h:
1874
1875 2007-10-05  Lars Knoll  <lars@trolltech.com>
1876
1877         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
1878         Add support for layoutTextController.setCanOpenWindows() to DRT
1879         fixing another 2 test cases in fast/dom/Window.
1880
1881         Reviewed by Maciej.
1882
1883         * DumpRenderTree/qt/DumpRenderTree.cpp:
1884         (WebCore::WebPage::WebPage):
1885         (WebCore::WebPage::createWindow):
1886         (WebCore::DumpRenderTree::resetJSObjects):
1887         (WebCore::DumpRenderTree::createWindow):
1888         * DumpRenderTree/qt/DumpRenderTree.h:
1889         * DumpRenderTree/qt/DumpRenderTree.pro:
1890         * DumpRenderTree/qt/jsobjects.cpp:
1891         (LayoutTestController::LayoutTestController):
1892         (LayoutTestController::reset):
1893         * DumpRenderTree/qt/jsobjects.h:
1894         * DumpRenderTree/qt/main.cpp:
1895         * DumpRenderTree/qt/testplugin.cpp: Added.
1896         * DumpRenderTree/qt/testplugin.h: Added.
1897
1898 2007-10-04  Sam Weinig  <sam@webkit.org>
1899
1900         Rubber stamped by Adam.
1901
1902         Remove empty directories.
1903
1904         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
1905         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
1906
1907 2007-10-03  Darin Adler  <darin@apple.com>
1908
1909         Reviewed by Adam.
1910
1911         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
1912         we find the internal libraries in the libraries directory. This
1913         is helpful for Safari team engineers at Apple.
1914
1915 2007-10-03  Adam Roben  <aroben@apple.com>
1916
1917         Update the location of AHEM___.TTF after r25968
1918
1919         Reviewed by Sam.
1920
1921         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1922
1923 2007-10-03  Alp Toker  <alp@atoker.com>
1924
1925         Reviewed by Adam.
1926
1927         http://bugs.webkit.org/show_bug.cgi?id=14726
1928         [gtk] API design. Mapping the WebView delegates to signals.
1929
1930         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
1931
1932         * GtkLauncher/main.cpp:
1933         (goToURLBarText):
1934         (titleChanged):
1935         (progressChanged):
1936         (menuMainBackCallback):
1937         (menuMainForwardCallback):
1938         (main):
1939
1940 2007-10-03  Lars Knoll  <lars@trolltech.com>
1941
1942         Reviewed by Rob.
1943
1944         This fixes --strict mode in run-webkit-tests again after
1945         the platform dependent test results have been moved.
1946
1947         * Scripts/run-webkit-tests:
1948
1949 2007-10-03  Lars Knoll  <lars@trolltech.com>
1950
1951         Reviewed by bdash.
1952
1953         remove the hack in run-webkit-tests that forced text only test
1954         to be taken from the platform independent dir. It was only left
1955         there from early days.
1956
1957         Remove platform dependent results for tests that are text only nowadays,
1958         and add one platform dependent result for a text only test that requires it.
1959
1960         * Scripts/run-webkit-tests:
1961
1962 2007-10-03  Lars Knoll  <lars@trolltech.com>
1963
1964         Reviewed by olliej.
1965
1966         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
1967
1968         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
1969         (WebCore::WebFrame::WebFrame):
1970         (WebCore::WebPage::WebPage):
1971         (WebCore::WebPage::createFrame):
1972         (WebCore::WebPage::javaScriptAlert):
1973         (WebCore::WebPage::javaScriptConsoleMessage):
1974         (WebCore::DumpRenderTree::DumpRenderTree):
1975         (WebCore::DumpRenderTree::~DumpRenderTree):
1976         (WebCore::DumpRenderTree::open):
1977         (WebCore::DumpRenderTree::readStdin):
1978         (WebCore::DumpRenderTree::resetJSObjects):
1979         (WebCore::DumpRenderTree::initJSObjects):
1980         (WebCore::DumpRenderTree::dumpFramesAsText):
1981         (WebCore::DumpRenderTree::dump):
1982         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
1983         (WebCore::DumpRenderTree::layoutTestController):
1984         (WebCore::DumpRenderTree::eventSender):
1985         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
1986         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
1987         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
1988         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
1989         (HackWebFrame::mousePressEvent):
1990         (HackWebFrame::mouseReleaseEvent):
1991         (HackWebFrame::mouseMoveEvent):
1992         (HackWebFrame::HackWebFrame):
1993         (HackWebFrame::~HackWebFrame):
1994         (LayoutTestController::LayoutTestController):
1995         (LayoutTestController::reset):
1996         (LayoutTestController::maybeDump):
1997         (LayoutTestController::waitUntilDone):
1998         (LayoutTestController::notifyDone):
1999         (LayoutTestController::dumpEditingCallbacks):
2000         (LayoutTestController::queueReload):
2001         (LayoutTestController::provisionalLoad):
2002         (LayoutTestController::timerEvent):
2003         (EventSender::EventSender):
2004         (EventSender::mouseDown):
2005         (EventSender::mouseUp):
2006         (EventSender::mouseMoveTo):
2007         (EventSender::leapForward):
2008         (EventSender::keyDown):
2009         (EventSender::frameUnderMouse):
2010         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
2011         (LayoutTestController::isLoading):
2012         (LayoutTestController::setLoading):
2013         (LayoutTestController::shouldDumpAsText):
2014         (LayoutTestController::shouldDumpChildrenAsText):
2015         (LayoutTestController::shouldWaitUntilDone):
2016         (LayoutTestController::dumpAsText):
2017         (LayoutTestController::dumpChildFramesAsText):
2018         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
2019         (messageHandler):
2020         (crashHandler):
2021         (main):
2022         * Scripts/run-webkit-tests:
2023
2024 2007-10-03  Mark Rowe  <mrowe@apple.com>
2025
2026         Reviewed by Alp Toker.
2027
2028         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
2029         should take precedence over QTDIR when determining which port we are working with.
2030
2031         * Scripts/webkitdirs.pm:
2032
2033 2007-10-02  Adam Roben  <aroben@apple.com>
2034
2035         Add keychain to the list of default packages to install
2036
2037         Rubberstamped by Sam.
2038
2039         * CygwinDownloader/cygwin-downloader.py:
2040         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
2041
2042 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
2043
2044         Reviewed by Adam.
2045
2046         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
2047         Also makes WebCore regression test case logic work when using git.
2048
2049         * Scripts/prepare-ChangeLog:
2050         (reviewerAndDescriptionForGitCommit): Added.
2051
2052 2007-10-02  Lars Knoll  <lars@trolltech.com>
2053
2054         Reviewed by bdash.
2055
2056         Add API to retrieve the frame name from QWebFrame.
2057         Implement support for DRT::dumpChildrenAsText.
2058
2059         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2060         (WebCore::DumpRenderTree::dumpFramesAsText):
2061         (WebCore::DumpRenderTree::dump):
2062         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2063         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2064         (LayoutTestController::LayoutTestController):
2065         (LayoutTestController::reset):
2066         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
2067
2068 2007-10-02  Lars Knoll  <lars@trolltech.com>
2069
2070         Reviewed by bdash.
2071
2072         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
2073
2074         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2075         (WebCore::DumpRenderTree::readStdin):
2076
2077 2007-10-02  Mark Rowe  <mrowe@apple.com>
2078
2079         Reviewed by Oliver.
2080
2081         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
2082
2083         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
2084         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
2085
2086 2007-10-02  Mark Rowe  <mrowe@apple.com>
2087
2088         Rubber-stamped by Maciej.
2089
2090         Configuration changes from build.webkit.org.  The major change is refactoring to work
2091         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
2092         last few weeks.
2093
2094         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2095         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
2096         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
2097         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
2098         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
2099         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
2100         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
2101         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
2102
2103 2007-10-02  Lars Knoll  <lars@trolltech.com>
2104
2105         Reviewed by Maciej.
2106
2107         Add support for eventSender.mouseMove to DRT.
2108         Fixes fast/css/hover-affects-child.html
2109
2110         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2111         (EventSender::mouseMoveTo):
2112
2113 2007-10-01  Mark Rowe  <mrowe@apple.com>
2114
2115         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
2116
2117 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
2118
2119         Reviewed by Hyatt.
2120
2121         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
2122
2123         * Scripts/svn-apply:
2124         (gitdiff2svndiff): Ignore lines beginning with "new file".
2125         * Scripts/svn-unapply:
2126         (gitdiff2svndiff): Ditto.
2127
2128 2007-09-30  George Staikos  <staikos@kde.org>
2129
2130         Qt build fix (Mac OS X specific)
2131
2132         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
2133
2134 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
2135
2136         Reviewed by Mark.
2137
2138         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
2139         Remove Bakefiles from svn.
2140
2141         * GtkLauncher/Bakefiles.bkgen: Removed.
2142         * GtkLauncher/ENV: Removed.
2143         * GtkLauncher/gdklauncher.bkl: Removed.
2144         * GtkLauncher/mk: Removed.
2145         * Scripts/regenerate-makefiles: Removed.
2146
2147 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
2148
2149         Reviewed by John.
2150
2151         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
2152
2153         * Scripts/run-webkit-tests:
2154
2155 2007-09-26  Adam Roben  <aroben@apple.com>
2156
2157         Make not finding an installed WebKit non-fatal
2158
2159         What really matters is that we are able to load WebKit and its
2160         dependencies, not whether we think we've found an installed WebKit.
2161
2162         Reviewed by Sam.
2163
2164         * WebKitInitializer/WebKitInitializer.cpp:
2165         (getWebViewCLSID): Use new LOG_WARNING macro.
2166         (getInstalledWebKitDirectory): Ditto.
2167         (initializeWebKit): Don't die if we didn't find an installed WebKit,
2168         and use new macros.
2169         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
2170
2171 2007-09-26  Adam Roben  <aroben@apple.com>
2172
2173         Committed this file before saving it
2174
2175         * WebKitInitializer/debug_internal.vsprops:
2176
2177 2007-09-26  Adam Roben  <aroben@apple.com>
2178
2179         Load WebKit and its dependencies manually so they come from DllDirectory
2180
2181         I had to change WebKitInitializer to use malloc/free instead of
2182         new/delete to avoid pulling in WebKit (and its dependencies) early
2183         through use of fastMalloc.
2184
2185         Reviewed by Oliver.
2186
2187         * WebKitInitializer/WebKitInitializer.cpp:
2188         (getStringValue): Changed to use malloc/free.
2189         (getInstalledWebKitDirectory): Ditto.
2190         (initializeWebKit): Call SetDllDirectory first, then load all of
2191         WebKit's dependencies manually, finally followed by WebKit itself.
2192         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
2193         configuration to match our other projects.
2194         * WebKitInitializer/debug_internal.vsprops: Added.
2195
2196 2007-09-25  Adam Roben  <aroben@apple.com>
2197
2198         Actually define DEBUG/NDEBUG so that we load WebKit correctly
2199
2200         Rubberstamped by Sam.
2201
2202         * WebKitInitializer/WebKitInitializer.vcproj:
2203
2204 2007-09-25  Adam Roben  <aroben@apple.com>
2205
2206         Make DumpRenderTree delay-load its dependencies
2207
2208         This lets WebKitInitializer re-route the dependencies to be loaded out
2209         of the Safari installation directory.
2210
2211         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
2212         same thing), since we can't import the kCFAllocatorDefault symbol when
2213         delay-loading CoreFoundation.dll.
2214
2215         Rubberstamped by Sam.
2216
2217         * DumpRenderTree/win/DumpRenderTree.cpp:
2218         (runTest):
2219         (javaScriptThreads):
2220         * DumpRenderTree/win/DumpRenderTree.vcproj:
2221         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2222         (LayoutTestController::setWaitToDump):
2223
2224 2007-09-25  Adam Roben  <aroben@apple.com>
2225
2226         Pull ole32.lib into WebKitInitializer
2227
2228         Rubberstamped by Sam.
2229
2230         * WebKitInitializer/WebKitInitializer.vcproj:
2231
2232 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
2233
2234         Reviewed by Adam.
2235
2236         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
2237           LGPL'ed files contain incorrect FSF address
2238
2239         * Drosera/config.h:
2240
2241 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
2242
2243         Reviewed by Adam.
2244
2245         Make svn-apply and svn-unapply work with git-diff formatted patches.
2246
2247         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
2248         (gitdiff2svndiff): Added.
2249         * Scripts/svn-unapply: Ditto.
2250         (gitdiff2svndiff): Added.
2251
2252 2007-09-25  Adam Roben  <aroben@apple.com>
2253
2254         Pull advapi32.lib into WebKitInitializer
2255
2256         This is needed to get the registry functions we use.
2257
2258         Rubberstamped by Sam.
2259
2260         * WebKitInitializer/WebKitInitializer.vcproj:
2261
2262 2007-09-25  Adam Roben  <aroben@apple.com>
2263
2264         Add python and rsync to cygwin-downloader
2265
2266         Our build slaves need this, and it can't hurt for everyone else to
2267         have it, too.
2268
2269         Reviewed by Sam.
2270
2271         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
2272         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
2273
2274 2007-09-25  Adam Roben  <aroben@apple.com>
2275
2276         Add WebKitInitializer and use it in DumpRenderTree
2277
2278         WebKitInitializer is a static library that has one function,
2279         initializeWebKit(). This registers WebKit and sets up the DLL search
2280         path so that WebKit's dependencies that are installed with Safari can
2281         be found.
2282
2283         Reviewed by Sam.
2284
2285         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
2286         DumpRenderTree depend on it.
2287         * DumpRenderTree/win/DumpRenderTree.cpp:
2288         (initialize): Call initializeWebKit.
2289         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
2290         WebKitInitializer.lib.
2291         * WebKitInitializer/WebKitInitializer.cpp: Added.
2292         (getStringValue):
2293         (getWebViewCLSID):
2294         (getInstalledWebKitDirectory):
2295         (initializeWebKit):
2296         * WebKitInitializer/WebKitInitializer.h: Added.
2297         * WebKitInitializer/WebKitInitializer.vcproj: Added.
2298         * WebKitInitializer/debug.vsprops: Added.
2299         * WebKitInitializer/release.vsprops: Added.
2300
2301 2007-09-25  Adam Roben  <aroben@apple.com>
2302
2303         Make run-webkit-tests respect set-webkit-configuration
2304
2305         Reviewed by Sam.
2306
2307         * Scripts/run-webkit-tests: Initialize $configuration to whatever
2308         set-webkit-configuration was last set to.
2309
2310 2007-09-25  Mark Rowe  <mrowe@apple.com>
2311
2312         Rubber-stamped by Eric.
2313
2314         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
2315         This makes it possible to automate nightly builds for the feature-branch.
2316
2317 2007-09-25  Adam Roben  <aroben@apple.com>
2318
2319         A couple of fixes/enhancements to update-webkit-*-libs
2320
2321         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
2322         to tell update-webkit-support-libraries where it should find the
2323         WebKitSupportLibrary.zip file you downloaded.
2324
2325         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
2326         Windows-style path.
2327
2328         Reviewed by Sam.
2329
2330         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
2331         to $auxiliaryLibsURL and removed an irrelevant comment.
2332         * Scripts/update-webkit-support-libs:
2333
2334 2007-09-25  Adam Treat  <treat@kde.org>
2335
2336         Reviewed by Simon and Lars.
2337
2338         Refactors and cleans up Qt DRT member variable names, member variable
2339         initialization, style fixes and general code cleanup.
2340
2341         Adds queueReload slot to LayoutTestController that some tests require.
2342
2343         Subclasses QWebFrame to make sure that all frames have an associated
2344         LayoutTestController JS window object.
2345
2346         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
2347         aren't dumped twice.
2348
2349         EOF fixes.
2350
2351         Together, this patch fixes some 20+ layout tests in QtWebKit.
2352
2353         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2354         (WebCore::WebFrame::WebFrame):
2355         (WebCore::WebPage::WebPage):
2356         (WebCore::WebPage::createFrame):
2357         (WebCore::DumpRenderTree::DumpRenderTree):
2358         (WebCore::DumpRenderTree::open):
2359         (WebCore::DumpRenderTree::readStdin):
2360         (WebCore::DumpRenderTree::initJSObjects):
2361         (WebCore::DumpRenderTree::dump):
2362         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2363         (WebCore::DumpRenderTree::layoutTestController):
2364         (WebCore::DumpRenderTree::eventSender):
2365         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2366         (LayoutTestController::LayoutTestController):
2367         (LayoutTestController::reset):
2368         (LayoutTestController::maybeDump):
2369         (LayoutTestController::waitUntilDone):
2370         (LayoutTestController::notifyDone):
2371         (LayoutTestController::queueReload):
2372         (LayoutTestController::provisionalLoad):
2373         (EventSender::EventSender):
2374         (EventSender::mouseDown):
2375         (EventSender::mouseUp):
2376         (EventSender::mouseMoveTo):
2377         (EventSender::frameUnderMouse):
2378         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
2379         (LayoutTestController::isLoading):
2380         (LayoutTestController::setLoading):
2381         (LayoutTestController::dumpAsText):
2382         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
2383         (main):
2384
2385 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
2386
2387
2388         - Reverted an accidentally checked in file.
2389
2390         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
2391
2392 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
2393         Reviewed by Sam.
2394
2395         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
2396
2397         * DumpRenderTree/win/DumpRenderTree.vcproj:
2398         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2399
2400 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
2401
2402         Rubber stamped by Adam.
2403
2404         * GdkLauncher: Removed.
2405         * GdkLauncher/Bakefiles.bkgen: Removed.
2406         * GdkLauncher/ENV: Removed.
2407         * GdkLauncher/GdkLauncher.pro: Removed.
2408         * GdkLauncher/gdklauncher.bkl: Removed.
2409         * GdkLauncher/main.cpp: Removed.
2410         * GdkLauncher/mk: Removed.
2411         * GdkLauncher/simple.svg: Removed.
2412         * GdkLauncher/text.html: Removed.
2413         * GtkLauncher: Added.
2414         * GtkLauncher/GdkLauncher.pro: Removed.
2415         * GtkLauncher/GtkLauncher.pro: Added.
2416         * GtkLauncher/main.cpp:
2417         (updateWindowTitle):
2418         (main):
2419         * Scripts/build-webkit:
2420         * Scripts/regenerate-makefiles:
2421         * Scripts/run-javascriptcore-tests:
2422         * Scripts/run-launcher:
2423         * Scripts/run-webkit-tests:
2424         * Scripts/webkitdirs.pm:
2425
2426 2007-09-21  Timothy Hatcher  <timothy@apple.com>
2427
2428         Reviewed by Darin.
2429
2430         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
2431
2432         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
2433         This is tested by plugins/root-object-premature-delete-crash.html.
2434
2435         * DumpRenderTree/mac/ObjCController.m:
2436         (-[ObjCController accessStoredWebScriptObject]):
2437
2438 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
2439
2440         Reviewed by Oliver.
2441
2442         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
2443
2444         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
2445         (FrameLoadDelegate::FrameLoadDelegate):
2446
2447 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
2448
2449         Reviewed by Adam.
2450
2451         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
2452         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
2453
2454         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
2455         Now isQt() and isGdk() use global variables that are only set once.
2456
2457         An array of all the parameters is now given to build-dumprender which includes
2458         the platform on linux.
2459
2460         * Scripts/build-dumprendertree:
2461         * Scripts/run-webkit-tests:
2462         * Scripts/webkitdirs.pm:
2463
2464 2007-09-19  Adam Roben  <aroben@apple.com>
2465
2466         Rubberstamped by Hyatt.
2467
2468         * Spinneret: Removed.
2469
2470 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
2471
2472         Reviewed by David Kilzer.
2473
2474         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
2475
2476 2007-09-18  Sam Weinig  <sam@webkit.org>
2477
2478         Add JSRetainPtr.h #include to fix some builds.
2479
2480         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2481
2482 2007-09-18  Mike Hommey  <glandium@debian.org>
2483
2484         Reviewed by Adam.
2485
2486         * Scripts/prepare-ChangeLog:
2487         - Properly parse GECOS field.
2488         - Use git configuration for user name and email when appropriate.
2489
2490 2007-09-17  Sam Weinig  <sam@webkit.org>
2491
2492         Build fix.
2493
2494         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2495
2496 2007-09-17  Sam Weinig  <sam@webkit.org>
2497
2498         Reviewed by Adam Roben.
2499
2500         Share more code between mac and windows DRT.
2501             - GCController is now shared.
2502             - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
2503
2504         * DumpRenderTree/GCController.cpp:
2505         * DumpRenderTree/win/DumpRenderTree.cpp:
2506         * DumpRenderTree/win/DumpRenderTree.vcproj:
2507         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
2508         (FrameLoadDelegate::FrameLoadDelegate):
2509         (FrameLoadDelegate::~FrameLoadDelegate):
2510         (FrameLoadDelegate::windowScriptObjectAvailable):
2511         * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
2512         * DumpRenderTree/win/GCController.cpp: Removed.
2513         * DumpRenderTree/win/GCController.h: Removed.
2514         * DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp.
2515         (GCController::collect):
2516         (GCController::collectOnAlternateThread):
2517         (GCController::getJSObjectCount):
2518         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
2519         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
2520
2521 2007-09-17  Sam Weinig  <sam@webkit.org>
2522
2523         Reviewed by Adam Roben.
2524
2525         Begin sharing code between mac and windows DRT.
2526             - both now share LayoutTestController.h/cpp and implement platform dependant
2527               operations in LayoutTestControllerMac/Win.
2528             - DumpRenderTree.h is now shared.
2529             - WorkQueue and WorkQueueItem are also shared.
2530
2531         * DumpRenderTree/DumpRenderTree.h:
2532         * DumpRenderTree/LayoutTestController.cpp:
2533         * DumpRenderTree/win/DumpRenderTree.cpp:
2534         (displayWebView):
2535         (dumpFrameScrollPosition):
2536         (dumpFramesAsText):
2537         (dump):
2538         (runTest):
2539         * DumpRenderTree/win/DumpRenderTree.h: Removed.
2540         * DumpRenderTree/win/DumpRenderTree.vcproj:
2541         * DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
2542         * DumpRenderTree/win/EditingDelegate.cpp:
2543         (EditingDelegate::shouldBeginEditingInDOMRange):
2544         (EditingDelegate::shouldEndEditingInDOMRange):
2545         (EditingDelegate::shouldInsertNode):
2546         (EditingDelegate::shouldInsertText):
2547         (EditingDelegate::shouldDeleteDOMRange):
2548         (EditingDelegate::shouldChangeSelectedDOMRange):
2549         (EditingDelegate::shouldApplyStyle):
2550         (EditingDelegate::shouldChangeTypingStyle):
2551         (EditingDelegate::doPlatformCommand):
2552         (EditingDelegate::webViewDidBeginEditing):
2553         (EditingDelegate::webViewDidChange):
2554         (EditingDelegate::webViewDidEndEditing):
2555         (EditingDelegate::webViewDidChangeTypingStyle):
2556         (EditingDelegate::webViewDidChangeSelection):
2557         * DumpRenderTree/win/LayoutTestController.cpp: Removed.
2558         * DumpRenderTree/win/LayoutTestController.h: Removed.
2559         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Copied from DumpRenderTree/win/LayoutTestController.cpp.
2560         (LayoutTestController::addDisallowedURL):
2561         (LayoutTestController::clearBackForwardList):
2562         (LayoutTestController::copyDecodedHostName):
2563         (LayoutTestController::copyEncodedHostName):
2564         (LayoutTestController::display):
2565         (LayoutTestController::keepWebHistory):
2566         (LayoutTestController::notifyDone):
2567         (LayoutTestController::queueBackNavigation):
2568         (LayoutTestController::queueForwardNavigation):
2569         (jsStringRefToWString):
2570         (LayoutTestController::queueLoad):
2571         (LayoutTestController::queueReload):
2572         (LayoutTestController::queueScript):
2573         (LayoutTestController::setAcceptsEditing):
2574         (LayoutTestController::setCustomPolicyDelegate):
2575         (LayoutTestController::setMainFrameIsFirstResponder):
2576         (LayoutTestController::setTabKeyCyclesThroughElements):
2577         (LayoutTestController::setUseDashboardCompatibilityMode):
2578         (LayoutTestController::setUserStyleSheetEnabled):
2579         (LayoutTestController::setUserStyleSheetLocation):
2580         (LayoutTestController::setWindowIsKey):
2581         (waitUntilDoneWatchdogFired):
2582         (LayoutTestController::setWaitToDump):
2583         (LayoutTestController::windowCount):
2584         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp:
2585         (FrameLoadDelegate::didReceiveTitle):
2586         (FrameLoadDelegate::processWork):
2587         (FrameLoadDelegate::locationChangeDone):
2588         (FrameLoadDelegate::windowScriptObjectAvailable):
2589         * DumpRenderTree/win/WorkQueue.cpp: Removed.
2590         * DumpRenderTree/win/WorkQueue.h: Removed.
2591         * DumpRenderTree/win/WorkQueueItem.cpp: Removed.
2592         * DumpRenderTree/win/WorkQueueItem.h: Removed.
2593         * DumpRenderTree/win/WorkQueueItemWin.cpp: Copied from DumpRenderTree/win/WorkQueueItem.cpp.
2594         (jsStringRefToWString):
2595         (LoadItem::invoke):
2596         (ScriptItem::invoke):
2597
2598 2007-09-17  Sam Weinig  <sam@webkit.org>
2599
2600         Reviewed by Adam Roben.
2601
2602         - Move Windows DumpRenderTree and TestNetscapePlugin to WebCoreTools/DumpRenderTree/win
2603
2604         * DumpRenderTree/DumpRenderTree.sln: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln.
2605         * DumpRenderTree/DumpRenderTree.vcproj: Removed.
2606         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Removed.
2607         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Removed.
2608         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h: Removed.
2609         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Removed.
2610         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Removed.
2611         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed.
2612         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: Removed.
2613         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: Removed.
2614         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: Removed.
2615         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h: Removed.
2616         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp: Removed.
2617         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h: Removed.
2618         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Removed.
2619         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Removed.
2620         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Removed.
2621         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Removed.
2622         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: Removed.
2623         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Removed.
2624         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp: Removed.
2625         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h: Removed.
2626         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: Removed.
2627         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: Removed.
2628         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops: Removed.
2629         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops: Removed.
2630         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops: Removed.
2631         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin: Removed.
2632         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
2633         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
2634         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
2635         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/main.c: Removed.
2636         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/resource.h: Removed.
2637         * DumpRenderTree/win: Added.
2638         * DumpRenderTree/win/DraggingInfo.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h.
2639         * DumpRenderTree/win/DumpRenderTree.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp.
2640         * DumpRenderTree/win/DumpRenderTree.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h.
2641         * DumpRenderTree/win/DumpRenderTree.vcproj: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj.
2642         * DumpRenderTree/win/EditingDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp.
2643         * DumpRenderTree/win/EditingDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h.
2644         * DumpRenderTree/win/EventSender.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp.
2645         * DumpRenderTree/win/EventSender.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h.
2646         * DumpRenderTree/win/GCController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp.
2647         * DumpRenderTree/win/GCController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h.
2648         * DumpRenderTree/win/LayoutTestController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp.
2649         * DumpRenderTree/win/LayoutTestController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h.
2650         * DumpRenderTree/win/TestNetscapePlugin: Copied from DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin.
2651         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2652         * DumpRenderTree/win/UIDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp.
2653         * DumpRenderTree/win/UIDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h.
2654         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp.
2655         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h.
2656         * DumpRenderTree/win/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
2657         * DumpRenderTree/win/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
2658         * DumpRenderTree/win/WorkQueueItem.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp.
2659         * DumpRenderTree/win/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
2660         * DumpRenderTree/win/debug.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops.
2661         * DumpRenderTree/win/debug_internal.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops.
2662         * DumpRenderTree/win/release.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops.
2663         * Scripts/run-webkit-tests: Update to point to the new location of the sln.
2664
2665 2007-09-15  Mark Rowe  <mrowe@apple.com>
2666
2667         Build fix for DumpRenderTree.
2668
2669         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Reinstate -Wno-deprecated-declarations on DumpRenderTree.mm.
2670
2671 2007-09-14  Sam Weinig  <sam@webkit.org>
2672
2673         Rubber stamped by Adam Roben.
2674
2675         Split the WaitUntilDoneDelegate into a UIDelegate and a FrameLoadDelegate.
2676           - The UIDelegate was put into a new file while the FrameLoadDelegate was
2677             kept in the WaitUntilDoneDelegate file for the time being.
2678
2679         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
2680         (main):
2681         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
2682         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Added.
2683         (UIDelegate::QueryInterface):
2684         (UIDelegate::AddRef):
2685         (UIDelegate::Release):
2686         (UIDelegate::hasCustomMenuImplementation):
2687         (UIDelegate::setFrame):
2688         (UIDelegate::webViewFrame):
2689         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2690         (UIDelegate::webViewAddMessageToConsole):
2691         (UIDelegate::doDragDrop):
2692         (UIDelegate::webViewGetDlgCode):
2693         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Added.
2694         (UIDelegate::UIDelegate):
2695         (UIDelegate::createWebViewWithRequest):
2696         (UIDelegate::webViewShow):
2697         (UIDelegate::webViewClose):
2698         (UIDelegate::webViewFocus):
2699         (UIDelegate::webViewUnfocus):
2700         (UIDelegate::webViewFirstResponder):
2701         (UIDelegate::makeFirstResponder):
2702         (UIDelegate::setStatusText):
2703         (UIDelegate::webViewStatusText):
2704         (UIDelegate::webViewAreToolbarsVisible):
2705         (UIDelegate::setToolbarsVisible):
2706         (UIDelegate::webViewIsStatusBarVisible):
2707         (UIDelegate::setStatusBarVisible):
2708         (UIDelegate::webViewIsResizable):
2709         (UIDelegate::setResizable):
2710         (UIDelegate::setContentRect):
2711         (UIDelegate::webViewContentRect):
2712         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2713         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2714         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
2715         (UIDelegate::runOpenPanelForFileButtonWithResultListener):
2716         (UIDelegate::mouseDidMoveOverElement):
2717         (UIDelegate::contextMenuItemsForElement):
2718         (UIDelegate::validateUserInterfaceItem):
2719         (UIDelegate::shouldPerformAction):
2720         (UIDelegate::dragDestinationActionMaskForDraggingInfo):
2721         (UIDelegate::willPerformDragDestinationAction):
2722         (UIDelegate::dragSourceActionMaskForPoint):
2723         (UIDelegate::willPerformDragSourceAction):
2724         (UIDelegate::contextMenuItemSelected):
2725         (UIDelegate::trackCustomPopupMenu):
2726         (UIDelegate::measureCustomMenuItem):
2727         (UIDelegate::drawCustomMenuItem):
2728         (UIDelegate::addCustomMenuDrawingData):
2729         (UIDelegate::cleanUpCustomMenuDrawingData):
2730         (UIDelegate::canTakeFocus):
2731         (UIDelegate::takeFocus):
2732         (UIDelegate::registerUndoWithTarget):
2733         (UIDelegate::removeAllActionsWithTarget):
2734         (UIDelegate::setActionTitle):
2735         (UIDelegate::undo):
2736         (UIDelegate::redo):
2737         (UIDelegate::canUndo):
2738         (UIDelegate::canRedo):
2739         (UIDelegate::webViewResizerRect):
2740         (UIDelegate::webViewDrawResizer):
2741         (UIDelegate::webViewScrolled):
2742         (UIDelegate::webViewShouldInterruptJavaScript):
2743         (UIDelegate::webViewReceivedFocus):
2744         (UIDelegate::webViewLostFocus):
2745         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
2746         (FrameLoadDelegate::QueryInterface):
2747         (FrameLoadDelegate::AddRef):
2748         (FrameLoadDelegate::Release):
2749         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2750         (FrameLoadDelegate::didCommitLoadForFrame):
2751         (FrameLoadDelegate::didReceiveTitle):
2752         (FrameLoadDelegate::processWork):
2753         (processWorkTimer):
2754         (FrameLoadDelegate::locationChangeDone):
2755         (FrameLoadDelegate::didFinishLoadForFrame):
2756         (FrameLoadDelegate::didFailLoadWithError):
2757         (FrameLoadDelegate::windowScriptObjectAvailable):
2758         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h:
2759         (FrameLoadDelegate::FrameLoadDelegate):
2760
2761 2007-09-14  Sam Weinig  <sam@webkit.org>
2762
2763         Reviewed by Kevin McCullough.
2764
2765         Move mac specific globals in to mac/DumpRenderTreeMac.h
2766
2767         * DumpRenderTree/DumpRenderTree.h:
2768         * DumpRenderTree/DumpRenderTree.mm: Removed.
2769         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2770         * DumpRenderTree/mac/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.mm.
2771         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added.
2772
2773 2007-09-14  Brady Eidson  <beidson@apple.com>
2774
2775         Rubberstamped by Weinig
2776
2777         You know, Sam, some of us use case-sensitve filesystems...
2778
2779         * DumpRenderTree/DumpRenderTree.h:
2780         * DumpRenderTree/mac/UIDelegate.mm:
2781
2782 2007-09-14  Sam Weinig  <sam@webkit.org>
2783
2784         Rubber stamped by Adam Roben.
2785
2786         - Move dump state data to LayoutTestContoller and add getter/setters to accommodate.
2787         - Move mac specific DumpRenderTree files to DumpRenderTree/mac
2788
2789         * DumpRenderTree/AppleScriptController.h: Removed.
2790         * DumpRenderTree/AppleScriptController.m: Removed.
2791         * DumpRenderTree/DumpRenderTree.h:
2792         * DumpRenderTree/DumpRenderTree.mm:
2793         (startJavaScriptThreads):
2794         (stopJavaScriptThreads):
2795         (activateAhemFont):
2796         (setDefaultColorProfileToRGB):
2797         (makeLargeMallocFailSilently):
2798         (dumpFrameScrollPosition):
2799         (dumpFramesAsText):
2800         (dump):
2801         (runTest):
2802         (-[DumpRenderTreeWindow isKeyWindow]):
2803         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2804         * DumpRenderTree/DumpRenderTreeDraggingInfo.h: Removed.
2805         * DumpRenderTree/DumpRenderTreeDraggingInfo.m: Removed.
2806         * DumpRenderTree/EditingDelegate.h: Removed.
2807         * DumpRenderTree/EditingDelegate.m: Removed.
2808         * DumpRenderTree/EventSendingController.h: Removed.
2809         * DumpRenderTree/EventSendingController.m: Removed.
2810         * DumpRenderTree/FrameLoadDelegate.h: Removed.
2811         * DumpRenderTree/FrameLoadDelegate.mm: Removed.
2812         * DumpRenderTree/GCController.mm: Removed.
2813         * DumpRenderTree/ImageDiff.m: Removed.
2814         * DumpRenderTree/LayoutTestController.cpp:
2815         (LayoutTestController::LayoutTestController):
2816         (dumpAsTextCallback):
2817         (dumpBackForwardListCallback):
2818         (dumpChildFramesAsTextCallback):
2819         (dumpChildFrameScrollPositionsCallback):
2820         (dumpDOMAsWebArchiveCallback):
2821         (dumpEditingCallbacksCallback):
2822         (dumpFrameLoadCallbacksCallback):
2823         (dumpResourceLoadCallbacksCallback):
2824         (dumpSelectionRectCallback):
2825         (dumpSourceAsWebArchiveCallback):
2826         (dumpTitleChangesCallback):
2827         (repaintSweepHorizontallyCallback):
2828         (setCallCloseOnWebViewsCallback):
2829         (setCanOpenWindowsCallback):
2830         (setCloseRemainingWindowsWhenCompleteCallback):
2831         (testRepaintCallback):
2832         (addFileToPasteboardOnDragCallback):
2833         (waitUntilDoneCallback):
2834         * DumpRenderTree/LayoutTestController.h:
2835         (LayoutTestController::dumpAsText):
2836         (LayoutTestController::setDumpAsText):
2837         (LayoutTestController::dumpBackForwardList):
2838         (LayoutTestController::setDumpBackForwardList):
2839         (LayoutTestController::dumpChildFrameScrollPositions):
2840         (LayoutTestController::setDumpChildFrameScrollPositions):
2841         (LayoutTestController::dumpChildFramesAsText):
2842         (LayoutTestController::setDumpChildFramesAsText):
2843         (LayoutTestController::dumpDOMAsWebArchive):
2844         (LayoutTestController::setDumpDOMAsWebArchive):
2845         (LayoutTestController::dumpSelectionRect):
2846         (LayoutTestController::setDumpSelectionRect):
2847         (LayoutTestController::dumpSourceAsWebArchive):
2848         (LayoutTestController::setDumpSourceAsWebArchive):
2849         (LayoutTestController::dumpTitleChanges):
2850         (LayoutTestController::setDumpTitleChanges):
2851         (LayoutTestController::dumpEditingCallbacks):
2852         (LayoutTestController::setDumpEditingCallbacks):
2853         (LayoutTestController::dumpResourceLoadCallbacks):
2854         (LayoutTestController::setDumpResourceLoadCallbacks):
2855         (LayoutTestController::dumpFrameLoadCallbacks):
2856         (LayoutTestController::setDumpFrameLoadCallbacks):
2857         (LayoutTestController::addFileToPasteboardOnDrag):
2858         (LayoutTestController::setAddFileToPasteboardOnDrag):
2859         (LayoutTestController::callCloseOnWebViews):
2860         (LayoutTestController::setCallCloseOnWebViews):
2861         (LayoutTestController::canOpenWindows):
2862         (LayoutTestController::setCanOpenWindows):
2863         (LayoutTestController::closeRemainingWindowsWhenComplete):
2864         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
2865         (LayoutTestController::testRepaint):
2866         (LayoutTestController::setTestRepaint):
2867         (LayoutTestController::testRepaintSweepHorizontally):
2868         (LayoutTestController::setTestRepaintSweepHorizontally):
2869         (LayoutTestController::waitToDump):
2870         (LayoutTestController::windowIsKey):
2871         * DumpRenderTree/LayoutTestControllerMac.mm: Removed.
2872         * DumpRenderTree/NavigationController.h: Removed.
2873         * DumpRenderTree/NavigationController.m: Removed.
2874         * DumpRenderTree/ObjCController.h: Removed.
2875         * DumpRenderTree/ObjCController.m: Removed.
2876         * DumpRenderTree/ObjCPlugin.h: Removed.
2877         * DumpRenderTree/ObjCPlugin.m: Removed.
2878         * DumpRenderTree/ObjCPluginFunction.h: Removed.
2879         * DumpRenderTree/ObjCPluginFunction.m: Removed.
2880         * DumpRenderTree/PolicyDelegate.h: Removed.
2881         * DumpRenderTree/PolicyDelegate.m: Removed.
2882         * DumpRenderTree/ResourceLoadDelegate.h: Removed.
2883         * DumpRenderTree/ResourceLoadDelegate.m: Removed.
2884         * DumpRenderTree/TextInputController.h: Removed.
2885         * DumpRenderTree/TextInputController.m: Removed.
2886         * DumpRenderTree/UIDelegate.h: Removed.
2887         * DumpRenderTree/UIDelegate.mm: Removed.
2888         * DumpRenderTree/WorkQueueItemMac.mm: Removed.
2889         * DumpRenderTree/mac: Added.
2890         * DumpRenderTree/mac/AppleScriptController.h: Copied from DumpRenderTree/AppleScriptController.h.
2891         * DumpRenderTree/mac/AppleScriptController.m: Copied from DumpRenderTree/AppleScriptController.m.
2892         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.h.
2893         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.m.
2894         * DumpRenderTree/mac/EditingDelegate.h: Copied from DumpRenderTree/EditingDelegate.h.
2895         * DumpRenderTree/mac/EditingDelegate.mm: Copied from DumpRenderTree/EditingDelegate.m.
2896         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2897         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2898         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2899         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2900         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2901         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2902         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2903         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2904         (-[EditingDelegate webViewDidBeginEditing:]):
2905         (-[EditingDelegate webViewDidChange:]):
2906         (-[EditingDelegate webViewDidEndEditing:]):
2907         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2908         (-[EditingDelegate webViewDidChangeSelection:]):
2909         * DumpRenderTree/mac/EventSendingController.h: Copied from DumpRenderTree/EventSendingController.h.
2910         * DumpRenderTree/mac/EventSendingController.mm: Copied from DumpRenderTree/EventSendingController.m.
2911         * DumpRenderTree/mac/FrameLoadDelegate.h: Copied from DumpRenderTree/FrameLoadDelegate.h.
2912         * DumpRenderTree/mac/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.mm.
2913         (-[FrameLoadDelegate init]):
2914         (-[FrameLoadDelegate dealloc]):
2915         (-[FrameLoadDelegate processWork:]):
2916         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
2917         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2918         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2919         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2920         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2921         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2922         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2923         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2924         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2925         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2926         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2927         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2928         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2929         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2930         (-[FrameLoadDelegate webView:willCloseFrame:]):
2931         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2932         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2933         * DumpRenderTree/mac/GCControllerMac.mm: Copied from DumpRenderTree/GCController.mm.
2934         * DumpRenderTree/mac/ImageDiff.m: Copied from DumpRenderTree/ImageDiff.m.
2935         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Copied from DumpRenderTree/LayoutTestControllerMac.mm.
2936         (LayoutTestController::notifyDone):
2937         (LayoutTestController::setWindowIsKey):
2938         (LayoutTestController::setWaitToDump):
2939         * DumpRenderTree/mac/NavigationController.h: Copied from DumpRenderTree/NavigationController.h.
2940         * DumpRenderTree/mac/NavigationController.m: Copied from DumpRenderTree/NavigationController.m.
2941         * DumpRenderTree/mac/ObjCController.h: Copied from DumpRenderTree/ObjCController.h.
2942         * DumpRenderTree/mac/ObjCController.m: Copied from DumpRenderTree/ObjCController.m.
2943         * DumpRenderTree/mac/ObjCPlugin.h: Copied from DumpRenderTree/ObjCPlugin.h.
2944         * DumpRenderTree/mac/ObjCPlugin.m: Copied from DumpRenderTree/ObjCPlugin.m.
2945         * DumpRenderTree/mac/ObjCPluginFunction.h: Copied from DumpRenderTree/ObjCPluginFunction.h.
2946         * DumpRenderTree/mac/ObjCPluginFunction.m: Copied from DumpRenderTree/ObjCPluginFunction.m.
2947         * DumpRenderTree/mac/PolicyDelegate.h: Copied from DumpRenderTree/PolicyDelegate.h.
2948         * DumpRenderTree/mac/PolicyDelegate.mm: Copied from DumpRenderTree/PolicyDelegate.m.
2949         * DumpRenderTree/mac/ResourceLoadDelegate.h: Copied from DumpRenderTree/ResourceLoadDelegate.h.
2950         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Copied from DumpRenderTree/ResourceLoadDelegate.m.
2951         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2952         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2953         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2954         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2955         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2956         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2957         * DumpRenderTree/mac/TextInputController.h: Copied from DumpRenderTree/TextInputController.h.
2958         * DumpRenderTree/mac/TextInputController.m: Copied from DumpRenderTree/TextInputController.m.
2959         * DumpRenderTree/mac/UIDelegate.h: Copied from DumpRenderTree/UIDelegate.h.
2960         * DumpRenderTree/mac/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.mm.
2961         (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
2962         (-[UIDelegate webViewFocus:]):
2963         (-[UIDelegate webView:createWebViewWithRequest:]):
2964         (-[UIDelegate webViewClose:]):
2965         * DumpRenderTree/mac/WorkQueueItemMac.mm: Copied from DumpRenderTree/WorkQueueItemMac.mm.
2966
2967 2007-09-14  Kevin McCullough  <kmccullough@apple.com>
2968
2969         Reviewed by Adam.
2970
2971         - Changing Win version of Drosera work with recent changes.
2972
2973         * Drosera/DebuggerDocument.cpp:
2974         * Drosera/DebuggerDocument.h:
2975         * Drosera/mac/DebuggerDocumentPlatform.mm:
2976         (NSStringCreateWithJSStringRef):
2977         (JSValueRefCreateWithNSString):
2978         * Drosera/win/DebuggerClient.cpp:
2979         (DebuggerClient::stepInto):
2980         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2981
2982 2007-09-13  Kevin McCullough  <kmccullough@apple.com>
2983
2984         Reviewed by Tim.
2985
2986         - Moved isPaused into the JS for efficiency and simplicity.
2987
2988         * Drosera/DebuggerDocument.cpp:
2989         (DebuggerDocument::DebuggerDocument):
2990         (DebuggerDocument::pauseCallback):
2991         (DebuggerDocument::resumeCallback):
2992         (DebuggerDocument::isPaused):
2993         (DebuggerDocument::staticFunctions):
2994         * Drosera/DebuggerDocument.h:
2995         * Drosera/console.js:
2996         * Drosera/debugger.js:
2997         * Drosera/mac/DebuggerClient.mm:
2998         (-[DebuggerClient validateUserInterfaceItem:]):
2999
3000 2007-09-13  Sam Weinig  <sam@webkit.org>
3001
3002         Rubber stamped by Darin.
3003
3004         Make DumpRenderTree more cross platform ready.
3005         - Convert GCController to use the JSCore API instead of the WebScriptObject.
3006         - Use CF types instead of NS objects.
3007         - General cleanup.
3008
3009         * DumpRenderTree/DumpRenderTree.h:
3010         * DumpRenderTree/DumpRenderTree.mm:
3011         (dumpRenderTree):
3012         (dump):
3013         (runTest):
3014         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3015         * DumpRenderTree/EditingDelegate.m:
3016         * DumpRenderTree/FrameLoadDelegate.h:
3017         * DumpRenderTree/FrameLoadDelegate.mm:
3018         (-[FrameLoadDelegate init]):
3019         (-[FrameLoadDelegate dealloc]):
3020         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3021         * DumpRenderTree/GCController.cpp: Added.
3022         (GCController::GCController):
3023         (GCController::~GCController):
3024         (collectCallback):
3025         (collectOnAlternateThreadCallback):
3026         (getJSObjectCountCallback):
3027         (GCController::makeWindowObject):
3028         (GCController::getJSClass):
3029         (GCController::staticFunctions):
3030         * DumpRenderTree/GCController.h:
3031         * DumpRenderTree/GCController.mm:
3032         (GCController::collect):
3033         (GCController::collectOnAlternateThread):
3034         (GCController::getJSObjectCount):
3035         * DumpRenderTree/LayoutTestController.cpp:
3036         (LayoutTestController::makeWindowObject):
3037         (LayoutTestController::getJSClass):
3038         * DumpRenderTree/LayoutTestController.h:
3039         * DumpRenderTree/LayoutTestControllerMac.mm:
3040         (LayoutTestController::addDisallowedURL):
3041         (waitUntilDoneWatchdogFired):
3042         (LayoutTestController::waitUntilDone):
3043         * DumpRenderTree/ResourceLoadDelegate.m:
3044         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3045
3046 2007-09-12  Sam Weinig  <sam@webkit.org>
3047
3048         Reviewed by Stephanie.
3049
3050         Fix leaks in mac DumpRenderTree.
3051
3052         * DumpRenderTree/FrameLoadDelegate.mm:
3053         (-[FrameLoadDelegate init]): Initalize in the correct order.
3054         (-[FrameLoadDelegate processWork:]): Delete WorkQueueItem's after dequeueing them.
3055         * DumpRenderTree/LayoutTestController.cpp:
3056         (decodeHostNameCallback): Put return value in a temporary JSRetainPtr to ensure it gets released.
3057         (encodeHostNameCallback): ditto.
3058         * DumpRenderTree/LayoutTestController.h:
3059         * DumpRenderTree/LayoutTestControllerMac.mm:
3060         (LayoutTestController::copyDecodedHostName): Rename function to signal that it follows the Create rule.
3061         (LayoutTestController::copyEncodedHostName): ditto
3062         (LayoutTestController::queueLoad): Use a JSRetainPtr to ensure the url gets released.
3063
3064 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
3065
3066         Reviewed by Geof.
3067
3068         - Updated Leopard leak list to include a leak which appears to be fixed in 9A549 but not the version the bot is on.  This will allow us to get the bot green, but later we should remove it.
3069
3070         * Scripts/run-webkit-tests:
3071
3072 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
3073
3074         Reviewed by Darin.
3075
3076         - Simplified code paths and extracted out functions to increase encapsulation.
3077
3078         * Drosera/DebuggerDocument.cpp:
3079         (DebuggerDocument::breakpointEditorHTMLCallback):
3080         (DebuggerDocument::isPausedCallback):
3081         (DebuggerDocument::pauseCallback):
3082         (DebuggerDocument::resumeCallback):
3083         (DebuggerDocument::stepIntoCallback):
3084         (DebuggerDocument::evaluateScriptCallback):
3085         (DebuggerDocument::currentFunctionStackCallback):
3086         (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
3087         (DebuggerDocument::valueForScopeVariableNamedCallback):
3088         (DebuggerDocument::logCallback):
3089         * Drosera/DebuggerDocument.h:
3090         (DebuggerDocument::getPaused):
3091         * Drosera/mac/DebuggerClient.mm:
3092         (-[DebuggerClient pause:]):
3093         (-[DebuggerClient resume:]):
3094         (-[DebuggerClient stepInto:]):
3095         (-[DebuggerClient stepOver:]):
3096         (-[DebuggerClient stepOut:]):
3097         (-[DebuggerClient showConsole:]):
3098         (-[DebuggerClient closeCurrentFile:]):
3099         (-[DebuggerClient validateUserInterfaceItem:]):
3100         * Drosera/mac/DebuggerDocumentPlatform.mm: Added.
3101         (+[NSString stringOrNilFromWebScriptResult:]):
3102         (DebuggerDocument::platformPause):
3103         (DebuggerDocument::platformResume):
3104         (DebuggerDocument::platformStepInto):
3105         (DebuggerDocument::platformEvaluateScript):
3106         (DebuggerDocument::getPlatformCurrentFunctionStack):
3107         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3108         (DebuggerDocument::platformValueForScopeVariableNamed):
3109         (DebuggerDocument::platformLog):
3110         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3111
3112 2007-09-12  Sam Weinig  <sam@webkit.org>
3113
3114         Build fix for Buildbot.
3115
3116         * DumpRenderTree/DumpRenderTree.mm:
3117         (dump):
3118
3119 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
3120
3121         Reviewed by Geoff.
3122
3123         - Updated the leaks list for leopard to help identify regressions.
3124
3125         * Scripts/run-webkit-tests:
3126
3127 2007-09-12  Sam Weinig  <sam@webkit.org>
3128
3129         Rubber stamped by Darin.
3130
3131         Convert the LayoutTestController to use the JSCore API instead of WebScriptObject.
3132
3133         * DumpRenderTree/DumpRenderTree.h: Re-order variables.
3134         * DumpRenderTree/DumpRenderTree.m: Removed.
3135         * DumpRenderTree/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.m.
3136         (stopJavaScriptThreads): Fix initialization.
3137         (setDefaultColorProfileToRGB): Add explicit cast from void*.
3138         (dumpRenderTree): Ditto.
3139         (runTest):
3140         Used the WorkQueue from the windows DRT instead of the old NSMutableArray one.
3141
3142         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3143         * DumpRenderTree/FrameLoadDelegate.h: Add LayoutTestController instance variable.
3144         * DumpRenderTree/FrameLoadDelegate.m: Removed.
3145         * DumpRenderTree/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.m.
3146         (-[FrameLoadDelegate init]):
3147         (-[FrameLoadDelegate dealloc]):
3148         (-[FrameLoadDelegate processWork:]):
3149         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
3150         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3151         Convert to use the new JSCore based LayoutTestController and the new WorkQueue.
3152
3153         * DumpRenderTree/LayoutTestController.cpp: Added.
3154         (LayoutTestController::LayoutTestController):
3155         (LayoutTestController::~LayoutTestController):
3156         (dumpAsTextCallback):
3157         (dumpBackForwardListCallback):
3158         (dumpChildFramesAsTextCallback):
3159         (dumpChildFrameScrollPositionsCallback):
3160         (dumpDOMAsWebArchiveCallback):
3161         (dumpEditingCallbacksCallback):
3162         (dumpFrameLoadCallbacksCallback):
3163         (dumpResourceLoadCallbacksCallback):
3164         (dumpSelectionRectCallback):
3165         (dumpSourceAsWebArchiveCallback):
3166         (dumpTitleChangesCallback):
3167         (repaintSweepHorizontallyCallback):
3168         (setCallCloseOnWebViewsCallback):
3169         (setCanOpenWindowsCallback):
3170         (setCloseRemainingWindowsWhenCompleteCallback):
3171         (testRepaintCallback):
3172         (addFileToPasteboardOnDragCallback):
3173         (addDisallowedURLCallback):
3174         (clearBackForwardListCallback):
3175         (decodeHostNameCallback):
3176         (displayCallback):
3177         (encodeHostNameCallback):
3178         (keepWebHistoryCallback):
3179         (notifyDoneCallback):
3180         (queueBackNavigationCallback):
3181         (queueForwardNavigationCallback):
3182         (queueLoadCallback):
3183         (queueReloadCallback):
3184         (queueScriptCallback):
3185         (setAcceptsEditingCallback):
3186         (setCustomPolicyDelegateCallback):
3187         (setMainFrameIsFirstResponderCallback):
3188         (setTabKeyCyclesThroughElementsCallback):
3189         (setUseDashboardCompatibilityModeCallback):
3190         (setUserStyleSheetEnabledCallback):
3191         (setUserStyleSheetLocationCallback):
3192         (setWindowIsKeyCallback):
3193         (waitUntilDoneCallback):
3194         (windowCountCallback):
3195         (LayoutTestController::makeWindowObject):
3196         (LayoutTestController::getLayoutTestControllerJSClass):
3197         (LayoutTestController::staticFunctions):
3198         * DumpRenderTree/LayoutTestController.h: Replaced.
3199         * DumpRenderTree/LayoutTestController.m: Removed.
3200         * DumpRenderTree/LayoutTestControllerMac.mm: Added.
3201         (LayoutTestController::dumpAsText):
3202         (LayoutTestController::dumpBackForwardList):
3203         (LayoutTestController::dumpChildFramesAsText):
3204         (LayoutTestController::dumpChildFrameScrollPositions):
3205         (LayoutTestController::dumpDOMAsWebArchive):
3206         (LayoutTestController::dumpEditingCallbacks):
3207         (LayoutTestController::dumpFrameLoadCallbacks):
3208         (LayoutTestController::dumpResourceLoadCallbacks):
3209         (LayoutTestController::dumpSelectionRect):
3210         (LayoutTestController::dumpSourceAsWebArchive):
3211         (LayoutTestController::dumpTitleChanges):
3212         (LayoutTestController::repaintSweepHorizontally):
3213         (LayoutTestController::setCallCloseOnWebViews):
3214         (LayoutTestController::setCanOpenWindows):
3215         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3216         (LayoutTestController::testRepaint):
3217         (LayoutTestController::addFileToPasteboardOnDrag):
3218         (LayoutTestController::addDisallowedURL):
3219         (LayoutTestController::clearBackForwardList):
3220         (LayoutTestController::decodeHostName):
3221         (LayoutTestController::encodeHostName):
3222         (LayoutTestController::display):
3223         (LayoutTestController::keepWebHistory):
3224         (LayoutTestController::notifyDone):
3225         (LayoutTestController::queueBackNavigation):
3226         (LayoutTestController::queueForwardNavigation):
3227         (LayoutTestController::queueLoad):
3228         (LayoutTestController::queueReload):
3229         (LayoutTestController::queueScript):
3230         (LayoutTestController::setAcceptsEditing):
3231         (LayoutTestController::setCustomPolicyDelegate):
3232         (LayoutTestController::setMainFrameIsFirstResponder):
3233         (LayoutTestController::setTabKeyCyclesThroughElements):
3234         (LayoutTestController::setUseDashboardCompatibilityMode):
3235         (LayoutTestController::setUserStyleSheetEnabled):
3236         (LayoutTestController::setUserStyleSheetLocation):
3237         (LayoutTestController::setWindowIsKey):
3238         (+[WaitToDumpWatchdog waitUntilDoneWatchdogFired]):
3239         (LayoutTestController::waitUntilDone):
3240         (LayoutTestController::windowCount):
3241         Use the JSCore API to implement the LayoutTestController.
3242
3243         * DumpRenderTree/ObjCController.h:
3244         * DumpRenderTree/ObjCController.m:
3245         (+[ObjCController isSelectorExcludedFromWebScript:]):
3246         (+[ObjCController webScriptNameForSelector:]):
3247         (-[ObjCController accessStoredWebScriptObject]):
3248         (-[ObjCController storeWebScriptObject:]):
3249         (-[ObjCController dealloc]):
3250         (-[ObjCController invokeUndefinedMethodFromWebScript:withArguments:]):
3251         Move WebScriptObject tests to ObjCController.
3252
3253         * DumpRenderTree/UIDelegate.m: Removed.
3254         * DumpRenderTree/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.m.
3255
3256         * DumpRenderTree/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
3257         * DumpRenderTree/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
3258         * DumpRenderTree/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
3259         (WorkQueueItem::~WorkQueueItem):
3260         (LoadItem::LoadItem):
3261         (LoadItem::url):
3262         (LoadItem::target):
3263         (ScriptItem::ScriptItem):
3264         (ScriptItem::script):
3265         * DumpRenderTree/WorkQueueItemMac.mm: Added.
3266         (LoadItem::invoke):
3267         (ReloadItem::invoke):
3268         (ScriptItem::invoke):
3269         (BackForwardItem::invoke):
3270         Copy WorkQueue and WorkQueueItem from windows DRT. Changed the WorkQueueItem to use JSStringRefs instead of wstrings
3271         to avoid conversion until the last possible moment.  These changes will be merged with the windows DRT when we start
3272         sharing code.
3273
3274 2007-09-11  Kevin McCullough  <kmccullough@apple.com>
3275
3276         Reviewed by Maciej.
3277
3278         - Updated Win side to take advantage of the platform separating changes.
3279
3280         * Drosera/DebuggerDocument.cpp:
3281         (DebuggerDocument::localScopeVariableNamesForCallFrame):
3282         * Drosera/DebuggerDocument.h:
3283         * Drosera/win/DebuggerClient.cpp:
3284         (DebuggerClient::pause):
3285         (DebuggerClient::resume):
3286         (DebuggerClient::stepInto):
3287         (DebuggerDocument::platformPause):
3288         (DebuggerDocument::platformResume):
3289         (DebuggerDocument::platformStepInto):
3290         (DebuggerDocument::platformEvaluateScript):
3291         (DebuggerDocument::getPlatformCurrentFunctionStack):
3292         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3293         (DebuggerDocument::platformValueForScopeVariableNamed):
3294         (DebuggerDocument::platformLog):
3295         * Drosera/win/DebuggerClient.h:
3296         * Drosera/win/Drosera.cpp:
3297         (Drosera::Drosera):
3298         (Drosera::windowScriptObjectAvailable):
3299         (Drosera::initWithServerName):
3300         (Drosera::switchToServerNamed):
3301         * Drosera/win/Drosera.h:
3302         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3303
3304 2007-09-11  Kevin McCullough  <kmccullough@apple.com>
3305
3306         Reviewed by Adam.
3307
3308         - Just doing the moves in a separate patch so the changes are easier to see.
3309
3310         * Drosera/win/DebuggerClient.cpp: Copied from Drosera/win/DebuggerDocumentWin.cpp.
3311         * Drosera/win/DebuggerClient.h: Copied from Drosera/win/DebuggerDocumentWin.h.
3312         * Drosera/win/DebuggerDocumentWin.cpp: Removed.
3313         * Drosera/win/DebuggerDocumentWin.h: Removed.
3314         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3315
3316 2007-09-11  Sven Herzberg  <sven@imendio.com>
3317
3318         Don't overwrite LD_LIBRARY_PATH, prepend to it. Fixes:
3319         http://bugs.webkit.org/show_bug.cgi?id=15176
3320
3321         * Scripts/run-launcher: don't replace LD_LIBRARY_PATH with
3322         $projectDir, but prepend $projectDir to LD_LIBRARY_PATH (to preserve
3323         other paths eg. from jhbuild)
3324
3325 2007-09-10  Kevin McCullough  <kmccullough@apple.com>
3326
3327         Reviewed by Adam.
3328
3329         - Made an order-of-deletion mistake.
3330
3331         * Drosera/DebuggerDocument.h:
3332         * Drosera/ForwardingHeaders/wtf/Assertions.h: Removed.
3333         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Removed.
3334         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Removed.
3335         * Drosera/mac/DebuggerClient.mm:
3336         (DebuggerDocument::platformPause):
3337         (DebuggerDocument::platformResume):
3338         (DebuggerDocument::platformStepInto):
3339         (DebuggerDocument::platformEvaluateScript):
3340         (DebuggerDocument::getPlatformCurrentFunctionStack):
3341         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3342         (DebuggerDocument::platformValueForScopeVariableNamed):
3343         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3344
3345 2007-09-10  Kevin McCullough  <kmccullough@apple.com>
3346
3347         Reviewed by Darin.
3348
3349         - Renaming DebuggerDocument[platform] to DebuggerClient to be more clear.
3350
3351         * Drosera/DebuggerDocument.cpp:
3352         (DebuggerDocument::DebuggerDocument):
3353         * Drosera/DebuggerDocument.h:
3354         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
3355         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
3356         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
3357         * Drosera/mac/DebuggerApplication.mm:
3358         (-[DebuggerApplication attach:]):
3359         * Drosera/mac/DebuggerClient.h: Copied from Drosera/mac/DebuggerDocumentMac.h.
3360         * Drosera/mac/DebuggerClient.mm: Copied from Drosera/mac/DebuggerDocumentMac.mm.
3361         (DebuggerDocument::platformPause):
3362         (DebuggerDocument::platformResume):
3363         (DebuggerDocument::platformStepInto):
3364         (DebuggerDocument::platformEvaluateScript):
3365         (DebuggerDocument::getPlatformCurrentFunctionStack):
3366         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3367         (DebuggerDocument::platformValueForScopeVariableNamed):
3368         (DebuggerDocument::platformLog):
3369         * Drosera/mac/DebuggerDocumentMac.h: Removed.
3370         * Drosera/mac/DebuggerDocumentMac.mm: Removed.
3371         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3372
3373 2007-09-09  Sam Weinig  <sam@webkit.org>
3374
3375         Reviewed by Mark Rowe.
3376
3377         Remove 'objC' prefix from methods now in the ObjCController.
3378
3379         * DumpRenderTree/ObjCController.m:
3380         (+[ObjCController isSelectorExcludedFromWebScript:]):
3381         (+[ObjCController webScriptNameForSelector:]):
3382         (-[ObjCController classNameOf:]):
3383         (-[ObjCController objectOfClass:]):
3384         (-[ObjCController identityIsEqual::]):
3385         (-[ObjCController longLongRoundTrip:]):
3386         (-[ObjCController unsignedLongLongRoundTrip:]):
3387
3388 2007-09-09  Sam Weinig  <sam@webkit.org>
3389
3390         Reviewed by Oliver.
3391
3392         Initial refactor of DumpRenderTree in preparation of making it more platform independent.
3393         - Move LayoutTestController into its own file.
3394         - Move Objective-C only functions on LayoutTestController into a new controller called the
3395           ObjCController.
3396
3397         * DumpRenderTree/DumpRenderTree.h:
3398         * DumpRenderTree/DumpRenderTree.m:
3399         (displayWebView):
3400         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3401         * DumpRenderTree/FrameLoadDelegate.m:
3402         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3403         * DumpRenderTree/LayoutTestController.h: Added.
3404         * DumpRenderTree/LayoutTestController.m: Added.
3405         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
3406         (+[LayoutTestController webScriptNameForSelector:]):
3407         (-[LayoutTestController clearBackForwardList]):
3408         (-[LayoutTestController setUseDashboardCompatibilityMode:]):
3409         (-[LayoutTestController setCloseRemainingWindowsWhenComplete:]):
3410         (-[LayoutTestController setCustomPolicyDelegate:]):
3411         (-[LayoutTestController keepWebHistory]):
3412         (-[LayoutTestController setCallCloseOnWebViews:]):
3413         (-[LayoutTestController setCanOpenWindows]):
3414         (-[LayoutTestController waitUntilDone]):
3415         (-[LayoutTestController waitUntilDoneWatchdogFired]):
3416         (-[LayoutTestController notifyDone]):
3417         (-[LayoutTestController dumpAsText]):
3418         (-[LayoutTestController addFileToPasteboardOnDrag]):
3419         (-[LayoutTestController addDisallowedURL:]):
3420         (-[LayoutTestController setUserStyleSheetLocation:]):
3421         (-[LayoutTestController setUserStyleSheetEnabled:]):
3422         (-[LayoutTestController dumpDOMAsWebArchive]):
3423         (-[LayoutTestController dumpSourceAsWebArchive]):
3424         (-[LayoutTestController dumpSelectionRect]):
3425         (-[LayoutTestController dumpTitleChanges]):
3426         (-[LayoutTestController dumpBackForwardList]):
3427         (-[LayoutTestController windowCount]):
3428         (-[LayoutTestController dumpChildFrameScrollPositions]):
3429         (-[LayoutTestController dumpChildFramesAsText]):
3430         (-[LayoutTestController dumpEditingCallbacks]):
3431         (-[LayoutTestController dumpResourceLoadCallbacks]):
3432         (-[LayoutTestController dumpFrameLoadCallbacks]):
3433         (-[LayoutTestController setWindowIsKey:]):
3434         (-[LayoutTestController setMainFrameIsFirstResponder:]):
3435         (-[LayoutTestController display]):
3436         (-[LayoutTestController testRepaint]):
3437         (-[LayoutTestController repaintSweepHorizontally]):
3438         (-[LayoutTestController invokeUndefinedMethodFromWebScript:withArguments:]):
3439         (-[LayoutTestController _addWorkForTarget:selector:arg1:arg2:]):
3440         (-[LayoutTestController _doLoad:target:]):
3441         (-[LayoutTestController _doBackOrForwardNavigation:]):
3442         (-[LayoutTestController queueBackNavigation:]):
3443         (-[LayoutTestController queueForwardNavigation:]):
3444         (-[LayoutTestController queueReload]):
3445         (-[LayoutTestController queueScript:]):
3446         (-[LayoutTestController queueLoad:target:]):
3447         (-[LayoutTestController setAcceptsEditing:]):
3448         (-[LayoutTestController setTabKeyCyclesThroughElements:]):
3449         (-[LayoutTestController storeWebScriptObject:]):
3450         (-[LayoutTestController accessStoredWebScriptObject]):
3451         (-[LayoutTestController dealloc]):
3452         (-[LayoutTestController decodeHostName:]):
3453         (-[LayoutTestController encodeHostName:]):
3454         * DumpRenderTree/ObjCController.h: Added.
3455         * DumpRenderTree/ObjCController.m: Added.
3456         (+[ObjCController isSelectorExcludedFromWebScript:]):
3457         (+[ObjCController webScriptNameForSelector:]):
3458         (-[ObjCController objCClassNameOf:]):
3459         (-[ObjCController objCObjectOfClass:]):
3460         (-[ObjCController objCIdentityIsEqual::]):
3461         (-[ObjCController objCLongLongRoundTrip:]):
3462         (-[ObjCController objCUnsignedLongLongRoundTrip:]):
3463         (-[ObjCController testWrapperRoundTripping:]):
3464
3465 2007-09-07  Sam Weinig  <sam@webkit.org>
3466
3467         Reviewed by Alice.
3468
3469         Strip trailing and leading space/newline characters from skiplist file names.
3470
3471         * Scripts/run-webkit-tests:
3472
3473 2007-09-06  Kevin McCullough  <kmccullough@apple.com>
3474
3475         Reviewed by Maciej.
3476
3477         - Changed Drosera to take advantage of the JSRetainPtr changes.
3478
3479         * Drosera/DebuggerDocument.cpp:
3480         (DebuggerDocument::breakpointEditorHTML):
3481         (DebuggerDocument::evaluateScript):
3482         (DebuggerDocument::valueForScopeVariableNamed):
3483         (DebuggerDocument::log):
3484         (DebuggerDocument::windowScriptObjectAvailable):
3485         (DebuggerDocument::toJSArray):
3486         (DebuggerDocument::callFunctionOnObject):
3487         (DebuggerDocument::logException):
3488         * Drosera/mac/DebuggerDocumentMac.mm:
3489         (-[DebuggerClientMac webView:didLoadMainResourceForDataSource:]):
3490         (-[DebuggerClientMac webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
3491         (DebuggerDocument::platformEvaluateScript):
3492         (DebuggerDocument::getPlatformCurrentFunctionStack):
3493         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3494         (DebuggerDocument::platformValueForScopeVariableNamed):
3495
3496 2007-09-05  Kevin McCullough  <kmccullough@apple.com>
3497
3498         Reviewed by Adam, Sam, Darin.
3499
3500         - Separated what is platform dependant from what is not.  Creating the structure needed for Drosera for Win.
3501
3502         * Drosera/Debugger.h: Added.
3503         * Drosera/DebuggerDocument.cpp:
3504         (DebuggerDocument::breakpointEditorHTMLCallback):
3505         (DebuggerDocument::isPausedCallback):
3506         (DebuggerDocument::pauseCallback):
3507         (DebuggerDocument::resumeCallback):
3508         (DebuggerDocument::stepIntoCallback):
3509         (DebuggerDocument::evaluateScriptCallback):
3510         (DebuggerDocument::currentFunctionStackCallback):
3511         (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
3512         (DebuggerDocument::valueForScopeVariableNamedCallback):
3513         (DebuggerDocument::logCallback):
3514         (DebuggerDocument::breakpointEditorHTML):
3515         (DebuggerDocument::isPaused):
3516         (DebuggerDocument::pause):
3517         (DebuggerDocument::resume):
3518         (DebuggerDocument::stepInto):
3519         (DebuggerDocument::evaluateScript):
3520         (DebuggerDocument::currentFunctionStack):
3521         (DebuggerDocument::localScopeVariableNamesForCallFrame):
3522         (DebuggerDocument::valueForScopeVariableNamed):
3523         (DebuggerDocument::log):
3524         (DebuggerDocument::toolbarPause):
3525         (DebuggerDocument::toolbarResume):
3526         (DebuggerDocument::toolbarStepInto):
3527         (DebuggerDocument::toolbarStepOver):
3528         (DebuggerDocument::toolbarStepOut):
3529         (DebuggerDocument::toolbarShowConsole):
3530         (DebuggerDocument::toolbarCloseCurrentFile):
3531         (DebuggerDocument::updateFileSource):
3532         (DebuggerDocument::didParseScript):
3533         (DebuggerDocument::willExecuteStatement):
3534         (DebuggerDocument::didEnterCallFrame):
3535         (DebuggerDocument::willLeaveCallFrame):
3536         (DebuggerDocument::exceptionWasRaised):
3537         (DebuggerDocument::windowScriptObjectAvailable):
3538         (DebuggerDocument::toJSArray):
3539         (DebuggerDocument::callGlobalFunction):
3540         (DebuggerDocument::callFunctionOnObject):