e14bc4af2f42a19437293a58b0c95e677a6584ab
[WebKit-https.git] / WebKit / win / ChangeLog
1 2007-07-27  Adam Roben  <aroben@apple.com>
2
3         Fix Bug 14773: REGRESSION (r24630): ASSERT_NOT_REACHED in DOMHTMLInputElement::name on Windows
4         http://bugs.webkit.org/show_bug.cgi?id=14773
5
6         Reviewed by Steve.
7
8         * Interfaces/DOMHTML.idl: Change IDOMHTMLInputElement back to
9         inheriting from IDOMElement. Safari 3 Beta uses this interface, so we
10         can't change its vtable.
11
12 2007-07-25  Ada Chan  <adachan@apple.com>
13
14         Reviewed by Adam and Steve.
15         
16         Implemented some DOM methods and other fixes for <rdar://problem/5311601>.
17         
18         * DOMCoreClasses.cpp:
19         (DOMNode::ownerDocument): implemented
20         (DOMDocument::getComputedStyle): get the DOMElement via QueryInterface
21         (DOMElement::QueryInterface):
22         * DOMHTMLClasses.cpp:
23         (DOMHTMLDocument::body): fixed leak
24         (DOMHTMLFormElement::action): implemented
25         (DOMHTMLFormElement::method): ditto
26         (DOMHTMLInputElement::form): ditto
27         (DOMHTMLTextAreaElement::form): ditto
28         * Interfaces/DOMHTML.idl: IDOMHTMLInputElement should inherit from IDOMHTMLElement
29
30 2007-07-24  Steve Falkenburg  <sfalken@apple.com>
31
32         Removed touch of WebKit.rc to prevent rebuilds of the rc file.
33         The autoversion info can get slightly out of date now, but this isn't a huge problem relative to the rebuilds.
34         
35         Rubber-stamped by Adam.
36
37         * WebKit.vcproj/WebKit.vcproj:
38
39 2007-07-23  Steve Falkenburg  <sfalken@apple.com>
40
41         Fixes to versioning script.
42         
43         Reviewed by Ada.
44
45         * WebKit.vcproj/auto-version.sh:
46
47 2007-07-23  Adam Roben  <aroben@apple.com>
48
49         Implement IWebHistoryItem::[set]AlternateTitle
50
51         The argument types were reversed for these two methods, so I fixed that as
52         well.
53
54         Reviewed by Geoff and Oliver.
55
56         * Interfaces/IWebHistoryItem.idl:
57         * WebHistoryItem.cpp:
58         (WebHistoryItem::setAlternateTitle): Implemented.
59         (WebHistoryItem::alternateTitle): Implemented.
60         * WebHistoryItem.h:
61
62 2007-07-23  Ada Chan  <adachan@apple.com>
63
64         Reviewed by Steve.
65         
66         Added a new text drawing method that allows caller to override the font smoothing level.
67
68         * WebKit.vcproj/WebKit.def:
69         * WebKit.vcproj/WebKit_debug.def:
70         * WebKitGraphics.cpp:
71         (WebDrawText):
72         * WebKitGraphics.h:
73
74 2007-07-22  Adam Roben  <aroben@apple.com>
75
76         Implement IDOMElement::setAttribute
77
78         This method was mistakenly called "setResult" in DOMCore.idl, so I
79         fixed that as well.
80
81         Needed for <rdar://problem/5314906>.
82
83         Reviewed by Ada.
84
85         * DOMCoreClasses.cpp:
86         (DOMElement::setAttribute): Implemented/renamed.
87         * DOMCoreClasses.h: Renamed setResult => setAttribute.
88         * DOMHTMLClasses.h: Ditto.
89         * Interfaces/DOMCore.idl: Ditto.
90
91 2007-07-21  Ada Chan  <adachan@apple.com>
92
93         Reviewed by Adam.
94         
95         Fix bug 14706: http://bugs.webkit.org/show_bug.cgi?id=14706
96         Need to set the last visited time before calling WebHistory::addItem().
97
98         * WebHistory.cpp:
99         (WebHistory::addItemForURL):
100
101 2007-07-20  Justin Garcia  <justin.garcia@apple.com>
102
103         Reviewed by Darin.
104         
105         <rdar://problem/5109817> Ctrl-click on word in non-editable text doesn't select it
106
107         * WebEditorClient.cpp: Removed the now unused selectWordBeforeMenuEvent().
108         * WebEditorClient.h:
109
110 2007-07-20  Ada Chan  <adachan@apple.com>
111
112         Reviewed by Steve.
113         
114         <rdar://problem/5350832> History item's visitedCount wasn't updated correctly
115
116         The call to setLastVisitedTimeInterval() in WebHistory::addItemForURL() does not
117         really increment the visitedCount of the HistoryItem - because we only increment the count
118         if the last visited time is different.  We should initialize the HistoryItem with
119         lastVisited time = 0 so when we call setLastVisitedTimeInterval() later, it'll update
120         the last visited time AND the visitedCount.
121         
122         * WebHistory.cpp:
123         (WebHistory::addItemForURL):
124
125 2007-07-20  Oliver Hunt  <oliver@apple.com>
126
127         Reviewed by Maciej.
128
129         <rdar://problem/5349668> WebKit/Win needs to send same key events during IME composition as it does on mac
130
131         Removed guards against sending key events during composition, and added a flag
132         to indicate a key event is IME related.  This is needed to prevent the first 
133         keydown from firing a keypress event, and makes WebEditorClient::handleInputMethodKeypress
134         somewhat cleaner.
135
136         * WebEditorClient.cpp:
137         (WebEditorClient::handleInputMethodKeypress):
138         * WebView.cpp:
139         (WebView::keyUp):
140         (WebView::keyDown):
141         * WebView.h:
142         (WebView::inIMEKeyDown):
143
144 2007-07-19  Maciej Stachowiak  <mjs@apple.com>
145
146         Reviewed by Adam.
147         
148         - WebKit part of fix for <rdar://problem/5262230> Crash while loading a popup in addictinggames.com
149         
150         Made closeWindowSoon fire on a timer instead of happening synchronously.
151
152         * WebChromeClient.cpp:
153         (WebChromeClient::closeWindowSoon): Actually close the window on a timer, not immediately.
154         * WebKit.vcproj/WebKit.vcproj:
155         * WebView.cpp:
156         (WebView::WebView):
157         (WebView::closeWindowSoon):
158         (WebView::closeWindowTimerFired):
159         * WebView.h:
160
161 2007-07-18  Timothy Hatcher  <timothy@apple.com>
162
163         Reviewed by Adam.
164
165         Make the Page with the now required InspectorClient.
166
167         * WebView.cpp:
168         (WebView::initWithFrame):
169
170 2007-07-18  Sam Weinig  <sam@webkit.org>
171
172         Build fix.
173
174         * WebFrame.cpp:
175         (WebFrame::dispatchDecidePolicyForMIMEType):
176         (WebFrame::objectContentType):
177         * WebView.cpp:
178         (WebView::canShowMIMEType):
179
180 2007-07-17  Brady Eidson <beidson@apple.com>
181
182         Blind Windows build fix from r24395
183
184         * WebView.cpp:
185         (WebView::initWithFrame): BSTR, not BString
186
187 2007-07-17  Brady Eidson  <beidson@apple.com>
188
189         Reviewed by Steve
190         
191         <rdar://problem/4516185> - FTP Directory Listings
192
193         * Interfaces/IWebUIDelegate.idl: Add IWebUIDelegate2 method for getting the path to the template
194         
195         * WebView.cpp:
196           (WebView::initWithFrame): Set the preference for the template path in WebCore when the first
197           WebView is initialized
198
199 2007-07-17  Ada Chan  <adachan@apple.com>
200
201         Rubbet-stamped by Adam.
202         
203         Fixed build.
204
205         * Interfaces/IWebFramePrivate.idl:
206         * WebContextMenuClient.cpp:
207         (fixMenuReceivedFromOldSafari):
208         * WebFrame.cpp:
209         (WebFrame::loadURLIntoChild):
210         (WebFrame::download):
211         * WebFrame.h:
212
213 2007-07-17  Adam Roben  <aroben@apple.com>
214
215         Fix Bug 14324: Cannot remove/customize the "Inspect Element" contextual menu item
216         http://bugs.webkit.org/show_bug.cgi?id=14324
217
218         If we detect that we're running against the Safari 3 Beta, we add back
219         the Inspect Element menu item after passing it off to the delegate
220         because Safari's UI delegate will remove it.
221
222         Reviewed by Tim.
223
224         * WebContextMenuClient.cpp:
225         (isPreInspectElementTagSafari): Added.
226         (fixMenuReceivedFromOldSafari): Added.
227         (WebContextMenuClient::getCustomMenuFromDefaultItems): Call
228         fixMenuReceivedFromOldSafari before returning the new menu.
229
230 2007-07-17  Adam Roben  <aroben@apple.com>
231
232         Remove WebContextMenuClient::shouldIncludeInspectElementItem
233
234         Reviewed by Tim.
235
236         * WebContextMenuClient.cpp:
237         * WebContextMenuClient.h:
238
239 2007-07-17  Adam Roben  <aroben@apple.com>
240
241         Initialize Settings::developerExtrasEnabled
242
243         Reviewed by Tim.
244
245         * WebView.cpp:
246         (WebView::updateWebCoreSettingsFromPreferences):
247
248 2007-07-17  Geoffrey Garen  <ggaren@apple.com>
249
250         Build fix. 
251
252         * WebContextMenuClient.cpp:
253         (WebContextMenuClient::searchWithGoogle): Pass false for lockHistory 
254         like we do elsewhere.
255
256 2007-07-17  Oliver Hunt  <oliver@apple.com>
257
258         Reviewed by Adam.
259
260         Fix for <rdar://problem/5339416> Candidate window does not
261                 appear in the correct location for japanese IME
262
263         * WebView.cpp:
264         (WebView::prepareCandidateWindow):
265           We now use an exclusion zone so that the composition window never 
266           overlaps the composition string
267         (WebView::onIMERequestCharPosition):
268           Correctly handle character offsets marked regions
269
270 2007-07-16  Oliver Hunt  <oliver@apple.com>
271
272         Reviewed by Maciej.
273
274         Fix for <rdar://problem/5334818> Support IME reconversion in windows
275
276         Also includes a small amount of IME refactoring.
277
278         * WebView.cpp:
279         (WebView::onIMERequestCharPosition):
280         (WebView::onIMERequestReconvertString):
281         (WebView::onIMERequest):
282         * WebView.h:
283
284 2007-07-16  Brady Eidson  <beidson@apple.com>
285
286         Reviewed by Adam
287
288         Begin the arduous task of localizing FTP directory listings while removing a global initializer!
289
290         * English.lproj/Localizable.strings:
291         * WebCoreLocalizedStrings.cpp:
292         (WebCore::unknownFileSizeText):
293
294 2007-07-16  Oliver Hunt  <oliver@apple.com>
295
296         Reviewed by Maciej.
297
298         Fix for <rdar://problem/5334826> Chinese IME composition window does not appear in the correct location
299
300         Respect IME requests for character position.
301
302         * WebView.cpp:
303         (WebView::onIMERequestCharPosition):
304         (WebView::onIMERequest):
305         * WebView.h:
306
307 2007-07-16  Adam Roben  <aroben@apple.com>
308
309         WebKit/win part of <rdar://problem/5336005> Calling window.print() on a subframe prints whole page, should only print that subframe
310
311         Reviewed by Darin.
312
313         * Interfaces/IWebUIDelegate.idl: Rename print to printFrame to closer
314         match the Mac method, and copy more of the Mac API comments.
315         * WebChromeClient.cpp:
316         (WebChromeClient::print): Call printFrame instead of print.
317
318 2007-07-16  Adam Roben  <aroben@apple.com>
319
320         Updated WebChromeClient for ChromeClient changes.
321
322         Reviewed by Darin.
323
324         * WebChromeClient.cpp:
325         (WebChromeClient::print): Added a Frame* parameter.
326         * WebChromeClient.h: Ditto.
327
328 2007-07-16  Oliver Hunt  <oliver@apple.com>
329
330         Reviewed by Steve.
331
332         Fix for http://bugs.webkit.org/show_bug.cgi?id=14630
333
334         Remove bogus assertion
335
336         * WebView.cpp:
337         (WebView::getIMMContext):
338
339 2007-07-14  Brady Eidson  <beidson@apple.com>
340
341         Reviewed by Sam
342         
343         Set the pref to override the policy delegate for FTP directory listings on Windows
344
345         * WebView.cpp:
346         (WebView::updateWebCoreSettingsFromPreferences):
347
348 2007-07-13  Oliver Hunt  <oliver@apple.com>
349
350         Reviewed by Darin and Alexey.
351
352         Fix for <rdar://problem/5231528> Inline input of International text (IME)
353                 http://bugs.webkit.org/show_bug.cgi?id=14331
354
355         This patch adds IME support to WebKit/win, it currently does not support
356         reconversion (<rdar://problem/5334818>) and has issues with the chinese
357         IMEs (<rdar://problem/5334826>)
358
359         * WebEditorClient.cpp:
360         (WebEditorClient::respondToChangedSelection):
361         (WebEditorClient::handleInputMethodKeypress):
362           Prevent the initial keydown for an IME from triggering a keypressed event
363         * WebView.cpp:
364         (WebView::WebView):
365         (WebView::keyUp):
366         (WebView::keyDown):
367         (WebViewWndProc):
368         (IMMDict::dict):
369         (IMMDict::IMMDict):
370            Dynamic loader for IME libraries
371
372         (WebView::getIMMContext):
373         (WebView::releaseIMMContext):
374         (WebView::prepareCandidateWindow):
375         (selectionInsideMarkedText):
376         (setSelectionToEndOfRange):
377         (WebView::resetIME):
378         (WebView::updateSelectionForIME):
379         (WebView::selectionChanged):
380         (getCompositionString):
381         (compositionToUnderlines):
382            Helper functions
383
384         (WebView::onIMEStartComposition):
385         (WebView::onIMEComposition):
386         (WebView::onIMEEndComposition):
387         (WebView::onIMEChar):
388         (WebView::onIMENotify):
389         (WebView::onIMERequest):
390         (WebView::onIMESelect):
391         (WebView::onIMESetContext):
392            IME event handling, so far most of these are not implemented, but the bulk of functionality 
393            is performed the the composition event handlers
394         * WebView.h:
395
396 2007-07-12  Alice Liu  <alice.liu@apple.com>
397
398         Reviewed by Maciej and Steve.
399
400         fixed <rdar://4982432> window.print() needs to be implemented
401
402         * Interfaces/IWebUIDelegate.idl:
403         * WebChromeClient.cpp:
404         (WebChromeClient::print):
405         * WebChromeClient.h:
406
407 2007-07-11  Steve Falkenburg  <sfalken@apple.com>
408
409         Static analysis build fix.
410         
411         Only specify /analyze (PREfast) if it is available.
412         Prevents entire project from rebuilding each time.        
413
414         Reviewed by Hyatt.
415
416         * WebKit.vcproj/WebKit.vcproj:
417
418 2007-07-10  Ada Chan  <adachan@apple.com>
419         
420         Fixed build.
421
422         * WebView.cpp:
423
424 2007-07-09  Alice Liu  <alice.liu@apple.com>
425
426         Reviewed by Adam Roben.
427         
428         Adding DOM Paste Allowed preference, setters and getters
429         for the purpose of layout tests.
430
431         * Interfaces/IWebPreferences.idl:
432         * WebPreferenceKeysPrivate.h:
433         * WebPreferences.cpp:
434         (WebPreferences::isDOMPasteAllowed):
435         (WebPreferences::setDOMPasteAllowed):
436         * WebPreferences.h:
437         * WebView.cpp:
438         (WebView::updateWebCoreSettingsFromPreferences):
439
440 2007-07-09  Anders Carlsson  <andersca@apple.com>
441
442         Build fix.
443
444         * WebView.cpp:
445         (WebView::stringByEvaluatingJavaScriptFromString):
446
447 2007-07-05  Adam Roben  <aroben@apple.com>
448
449         Fix a leak in WebView::setToolTip
450
451         Reviewed by Beth.
452
453         * WebView.cpp:
454         (WebView::setToolTip):
455
456 2007-07-05  Adam Roben  <aroben@apple.com>
457
458         Fix Bug 14143: Tooltips not displayed on Windows
459         http://bugs.webkit.org/show_bug.cgi?id=14143
460         <rdar://problem/4719799>
461
462         Reviewed by Oliver.
463
464         * WebChromeClient.cpp:
465         (WebChromeClient::setToolTip): Call up to WebView.
466         * WebView.cpp:
467         (WebView::WebView): Initialize m_toolTipHwnd member.
468         (WebView::initWithFrame): Set up the tool tip window.
469         (initCommonControls): Added.
470         (WebView::initializeToolTipWindow): Added.
471         (WebView::setToolTip): Set the tool tip text and enable/disable the
472         tool tip.
473         * WebView.h: Added/updated declarations.
474
475 2007-07-04  Adam Roben  <aroben@apple.com>
476
477         Added a stub for WebChromeClient::setToolTip
478
479         Reviewed by Sam.
480
481         * WebChromeClient.cpp:
482         * WebChromeClient.h:
483
484 2007-07-04  Adam Roben  <aroben@apple.com>
485
486         Initialize Settings::showsURLsInToolTips
487
488         Reviewed by Sam.
489
490         * WebView.cpp:
491         (WebView::updateWebCoreSettingsFromPreferences):
492
493 2007-07-04  Adam Roben  <aroben@apple.com>
494
495         Removed call to mouseDidMoveOverElement now that WebCore handles it
496
497         Reviewed by Sam.
498
499         * WebView.cpp:
500         (WebView::handleMouseEvent):
501
502 2007-07-04  Adam Roben  <aroben@apple.com>
503
504         Add WebChromeClient::mouseDidMoveOverElement
505
506         This is not called yet.
507
508         Reviewed by Sam.
509
510         * WebChromeClient.cpp:
511         (WebChromeClient::mouseDidMoveOverElement):
512         * WebChromeClient.h:
513
514 2007-07-03  Adam Roben  <aroben@apple.com>
515
516         Merge the Windows and Mac localized strings and exceptions files
517
518         Reviewed by Darin and Anders.
519
520         * English.lproj/Localizable.strings: Added Mac strings.
521         * English.lproj/StringsNotToBeLocalized.txt: Removed.
522
523 2007-06-27  Steve Falkenburg  <sfalken@apple.com>
524
525         Turn on static code analysis.
526
527         Reviewed by Oliver.
528         
529         Affects only folks that have Visual Studio Team Suite installed,
530         or who have replaced their compiler with the version shipping in the
531         Vista SDK.
532
533         * CodeAnalysisConfig.h: Added.
534         * WebKit.vcproj/WebKit.vcproj:
535         * WebLocalizableStrings.cpp:
536         (createWebKitBundle):
537
538 2007-06-27  Steve Falkenburg  <sfalken@apple.com>
539
540         Prefast: Remove variable redefinitions in inner scopes.
541         
542         Reviewed by Ada.
543
544         * WebDownload.cpp:
545         (WebDownload::didFinish):
546         * WebNotificationCenter.cpp:
547         (WebNotificationCenter::postNotificationInternal):
548         (WebNotificationCenter::removeObserver):
549
550 2007-06-27  Steve Falkenburg  <sfaken@apple.com>
551
552         Remove SEH block from around history plist read, since the underlying bug has been fixed.
553         
554         Reviewed by Darin.
555
556         * WebHistory.cpp:
557         (createHistoryListFromStream):
558
559 2007-06-27  Steve Falkenburg  <sfalken@apple.com>
560
561         Prefast: Fix misplaced parenthesis.
562         
563         Reviewed by Darin.
564
565         * WebView.cpp:
566         (core):
567
568 2007-06-27  Steve Falkenburg  <sfalken@apple.com>
569
570         Prefast: Add null check prior to writing into allocated BSTR.
571         
572         Reviewed by Darin.
573
574         * MarshallingHelpers.cpp:
575         (MarshallingHelpers::CFStringRefToBSTR):
576
577 2007-06-27  Steve Falkenburg  <sfalken@apple.com>
578
579         Prefast: Add error handling for SysAllocStringLen where the string length is determined by website content.
580
581         Reviewed by Sam, Darin.
582                 
583         Allocation failure will result in a null dereference in this case,
584         so it isn't exploitable.
585
586         * DefaultDownloadDelegate.cpp:
587         (DefaultDownloadDelegate::decideDestinationWithSuggestedFilename):
588
589 2007-06-20  Adam Roben  <aroben@apple.com>
590
591         Land the new Inspector.
592
593         Co-written with Tim Hatcher.
594
595         Reviewed by Anders, Adele, Hyatt, and Sam.
596
597         Implement the InspectorClient interface.
598
599         * WebInspectorClient.cpp: Added.
600         (WebInspectorClient::WebInspectorClient):
601         (WebInspectorClient::~WebInspectorClient):
602         (WebInspectorClient::inspectorDestroyed):
603         (WebInspectorClient::createPage):
604         (WebInspectorClient::showWindow):
605         (WebInspectorClient::closeWindow):
606         (WebInspectorClient::windowVisible):
607         (WebInspectorClient::attachWindow):
608         (WebInspectorClient::detachWindow):
609         (WebInspectorClient::highlight):
610         (WebInspectorClient::hideHighlight):
611         (WebInspectorClient::inspectedURLChanged):
612         (WebInspectorClient::updateWindowTitle):
613         (WebInspectorClient::onSize):
614         (WebInspectorClient::onClose):
615         (WebInspectorClient::onWebViewWindowPosChanging):
616         (WebInspectorWndProc):
617         (SubclassedWebViewWndProc):
618         (registerWindowClass):
619         * WebInspectorClient.h: Added.
620
621         Add an easier-to-see highlight.
622
623         * WebNodeHighlight.cpp: Added.
624         (WebNodeHighlight::WebNodeHighlight):
625         (WebNodeHighlight::~WebNodeHighlight):
626         (WebNodeHighlight::highlight):
627         (WebNodeHighlight::hide):
628         (WebNodeHighlight::visible):
629         (WebNodeHighlight::updateWindow):
630         (WebNodeHighlight::removeSubclass):
631         (registerOverlayClass):
632         (OverlayWndProc):
633         (SubclassedWndProc):
634         * WebNodeHighlight.h: Added.
635
636         WebView changes needed for the new Inspector.
637
638         * WebView.cpp: Removed old inspectElement method now that this is
639         handled by WebCore.
640         (WebView::WebView):
641         (WebView::close):
642         (WebView::performContextMenuAction): Removed handling of the Inspect
643         Element context menu item.
644         (WebView::initWithFrame): Give each Page an InspectorClient to enable
645         the Inspector.
646         (WebView::setProhibitsMainFrameScrolling): Added.
647         * WebView.h:
648
649         Updates needed for WebCore changes.
650
651         * Interfaces/IWebUIDelegate.idl:
652         * WebContextMenuClient.cpp:
653         (WebContextMenuClient::getCustomMenuFromDefaultItems):
654         * WebContextMenuClient.h:
655         * WebCoreLocalizedStrings.cpp:
656
657         Remove old Inspector code.
658
659         * WebFrame.cpp:
660         * WebFrame.h:
661         * WebInspector/WebInspector.cpp: Removed.
662         * WebInspector/WebInspector.h: Removed.
663         * WebInspector/webInspector/Images/button.png: Removed.
664         * WebInspector/webInspector/Images/buttonDivider.png: Removed.
665         * WebInspector/webInspector/Images/buttonPressed.png: Removed.
666         * WebInspector/webInspector/Images/close.png: Removed.
667         * WebInspector/webInspector/Images/closePressed.png: Removed.
668         * WebInspector/webInspector/Images/downTriangle.png: Removed.
669         * WebInspector/webInspector/Images/menu.png: Removed.
670         * WebInspector/webInspector/Images/menuPressed.png: Removed.
671         * WebInspector/webInspector/Images/popup.png: Removed.
672         * WebInspector/webInspector/Images/popupPressed.png: Removed.
673         * WebInspector/webInspector/Images/resize.png: Removed.
674         * WebInspector/webInspector/Images/rightTriangle.png: Removed.
675         * WebInspector/webInspector/Images/scrollThumbBottom.png: Removed.
676         * WebInspector/webInspector/Images/scrollThumbMiddle.png: Removed.
677         * WebInspector/webInspector/Images/scrollTrackMiddle.png: Removed.
678         * WebInspector/webInspector/Images/upTriangle.png: Removed.
679         * WebInspector/webInspector/inspector.css: Removed.
680         * WebInspector/webInspector/inspector.html: Removed.
681         * WebInspector/webInspector/inspector.js: Removed.
682         * WebInspector/webInspector/scrollarea.js: Removed.
683         * WebInspector/webInspector/scrollbar.js: Removed.
684         * WebInspector/webInspector/treeoutline.js: Removed.
685         * WebInspector/webInspector/utilities.js: Removed.
686
687         Build-fu:
688
689         * WebKit.vcproj/WebKit.vcproj:
690
691 2007-06-19  Dave Hyatt  <hyatt@apple.com>
692
693         Fix for <rdar://problem/5022197>, backspace and ctrl+left arrow should go back.  Shift+backspace
694         and ctrl+right arrow should go forward.  Add support for these keybindings to Windows.
695        
696         Reviewed by ada
697
698         * WebView.cpp:
699         (WebView::keyDown):
700
701 2007-06-18  Dave Hyatt  <hyatt@apple.com>
702
703         Let through more newline+modifier key combos in order to support Alt+Enter and Ctrl+Enter in the
704         SafariWin URL bar.
705        
706         Reviewed by mccullough
707
708         * WebView.cpp:
709
710 2007-06-18  Dave Hyatt  <hyatt@apple.com>
711
712         Add support for horizontal mouse wheeling to Windows.  Shift+wheel is supported for horizontal
713         wheeling just like on OS X.  In addition, the WM_MOUSEHWHEEL event is now processed correctly so that
714         input devices like tilt wheels will now work.
715        
716         Reviewed by aroben
717
718         * WebView.cpp:
719         (WebView::mouseWheel):
720         (WebViewWndProc):
721         * WebView.h:
722
723 2007-06-17  Dave Hyatt  <hyatt@apple.com>
724
725         Add support for Ctrl+Mouse Wheel to increase/decrease text zoom (Win32 only).
726        
727         Reviewed by aroben
728
729         * WebView.cpp:
730         (WebView::mouseWheel):
731
732 2007-06-09  Steve Falkenburg  <sfalken@apple.com>
733
734         Reviewed by Adam.
735         
736         Workaround: <rdar://problem/5213266> schwab.com menu is ridiculously big.
737         
738         * WebView.cpp:
739         (WebView::userAgentForKURL): Add schwab to spoof list to fix gigantic menus.
740
741 2007-06-08  Ada Chan  <adachan@apple.com>
742
743         Reviewed by Hyatt, Adam, and Steve.
744
745         Fixed WebView::selectedText to get the selected text out of the focused frame or main frame.
746
747         * WebView.cpp:
748         (WebView::selectedText):
749
750 2007-06-08  Adam Roben  <aroben@apple.com>
751
752         Get rid of the Safari part of the query string used for Google searches.
753
754         Reviewed by Steve and Ada.
755
756         * WebContextMenuClient.cpp:
757         (WebContextMenuClient::searchWithGoogle):
758
759 2007-06-08  Kevin McCullough  <kmccullough@apple.com>
760
761         Reviewed by Kevin Decker, and Sam.
762
763         - Added and updated licenses.
764
765         * CFDictionaryPropertyBag.cpp:
766         * CFDictionaryPropertyBag.h:
767         * DOMCSSClasses.cpp:
768         * DOMCSSClasses.h:
769         * DOMEventsClasses.cpp:
770         * DOMEventsClasses.h:
771         * DOMHTMLClasses.cpp:
772         * DOMHTMLClasses.h:
773         * MarshallingHelpers.cpp:
774         * MarshallingHelpers.h:
775         * MemoryStream.cpp:
776         * MemoryStream.h:
777         * WebBackForwardList.cpp:
778         * WebBackForwardList.h:
779         * WebCache.cpp:
780         * WebCache.h:
781         * WebChromeClient.cpp:
782         * WebChromeClient.h:
783         * WebContextMenuClient.h:
784         * WebDataSource.h:
785         * WebEditorClient.cpp:
786         * WebEditorClient.h:
787         * WebElementPropertyBag.cpp:
788         * WebElementPropertyBag.h:
789         * WebHTMLRepresentation.h:
790         * WebHistory.cpp:
791         * WebHistory.h:
792         * WebIconDatabase.cpp:
793         * WebIconDatabase.h:
794         * WebKit.vcproj/auto-version.sh:
795         * WebKitClassFactory.h:
796         * WebKitDLL.h:
797         * WebLocalizableStrings.cpp:
798         * WebLocalizableStrings.h:
799         * WebMutableURLRequest.cpp:
800         * WebMutableURLRequest.h:
801         * WebNotification.cpp:
802         * WebNotification.h:
803         * WebNotificationCenter.cpp:
804         * WebNotificationCenter.h:
805         * WebPreferenceKeysPrivate.h:
806         * WebPreferences.cpp:
807         * WebPreferences.h:
808         * WebScriptObject.cpp:
809         * WebScriptObject.h:
810         * WebURLResponse.cpp:
811         * WebURLResponse.h:
812
813 2007-06-07  Sam Weinig  <sam@webkit.org>
814
815         Reviewed by Adam Roben.
816
817         Make the inspector compile again.
818
819         * WebInspector/WebInspector.cpp:
820         (setFocusedDOMNodeCallback):
821         (focusedDOMNodeCallback):
822         (setRootDOMNodeCallback):
823         (rootDOMNodeCallback):
824
825 2007-06-06  Steve Falkenburg  <sfalken@apple.com>
826
827         Reviewed by Adam.
828         
829         <rdar://problem/5255861> REGRESSION: Can't download Adobe Acrobat Reader and plug-in
830         <rdar://problem/5243655> Flash download page doesn't recognize Boomer
831         
832         Refine user agent spoofing code to only spoof Flash download as Firefox without spoofing all of adobe.com.
833         This fixes the Acrobat Reader download.
834
835         * WebView.cpp:
836         (WebView::userAgentForKURL):
837
838 2007-06-03  Steve Falkenburg  <sfalken@apple.com>
839
840         Reviewed by Adam.
841         
842         <rdar://problem/5246665> Drop down lists are not drawn on volvocars.us
843
844         * WebView.cpp:
845         (WebView::userAgentForKURL):
846
847 2007-06-01  Kevin McCullough  <kmccullough@apple.com>
848
849         Reviewed by Oliver.
850
851         - Uncommenting some functions that should not be commented out.  I needed them for the Drosera port.
852
853         * WebKit.vcproj/WebKit_debug.def:
854
855 2007-06-01  Steve Falkenburg  <sfalken@apple.com>
856
857         Reviewed by Kevin Decker.
858         
859         Remove unnecessary user agent spoofs, now that we have the final UA in place.
860         Added spoof to allow Flash downloads from adobe.com
861
862         * WebView.cpp:
863         (WebView::userAgentForKURL):
864
865 2007-05-30  Ada Chan  <adachan@apple.com>
866
867         Reviewed by Steve.
868
869         Implemented the mechanism to associate a WebPreferences instance with an identifier.
870
871         * WebIconDatabase.cpp:
872         (WebIconDatabase::init): fixed a missing Release on standardPrefs by using COMPtr.
873         * WebPreferences.cpp:
874         (WebPreferences::getInstanceForIdentifier): implemented
875         (WebPreferences::setInstance): implemented
876         (WebPreferences::removeReferenceForIdentifier): if the WebPreferences going to be
877         released has only one ref left, remove it from the s_webPreferencesInstances dictionary.
878         (WebPreferences::load): don't need to reread in the default preferences if we have done so.
879         (WebPreferences::initWithIdentifier): update the m_identifier data member with the
880         passed in identifier string, and store the identifier to WebPreferences instance mapping in
881         s_webPreferencesInstances dictionary.
882         (WebPreferences::identifier): implemented
883         * WebPreferences.h:
884         * WebView.cpp:
885         (WebView::~WebView): removed the call to removeObserver for the WebPreferencesChangedNotification
886         since it's already done in close().
887         (WebView::close): the call to removeObserver now takes in the WebPreferences instance for the object -
888         this way the WebView is only notified when that particular WebPreferences instance changes.
889         (WebView::initWithFrame): the call to addObserver now takes in the WebPreferences instance for the object -
890         this way the WebView is only notified when that particular WebPreferences instance changes.
891         (WebView::setPreferences): implemented
892         (WebView::onNotify): used COMPtr to fix a missing release
893
894 2007-05-29  Steve Falkenburg  <sfalken@apple.com>
895
896         Reviewed by Darin.
897         
898         Removed setPageCacheSize/pageCacheSize from IWebBackForwardList.
899
900         * Interfaces/IWebBackForwardList.idl: Removed unnecessary methods.
901         * WebBackForwardList.cpp: Removed unnecessary methods.
902         * WebBackForwardList.h: Removed unnecessary methods.
903
904 2007-05-29  Sam Weinig  <sam@webkit.org>
905
906         Reviewed by Adam Roben.
907
908         - Removes platform/win/NotImplemented.h because we have consolidated
909           the notImplemented() for all platforms in platform/NotImplemented.h
910         - Fixes remaining uses of old macro to use the new notImplemented() one.
911
912         * WebChromeClient.cpp:
913         (WebChromeClient::createModalDialog):
914         (WebChromeClient::canRunModal):
915         (WebChromeClient::runModal):
916         (WebChromeClient::setScrollbarsVisible):
917         (WebChromeClient::scrollbarsVisible):
918         (WebChromeClient::setMenubarVisible):
919         (WebChromeClient::menubarVisible):
920         * WebContextMenuClient.cpp:
921         (WebContextMenuClient::lookUpInDictionary):
922         (WebContextMenuClient::speak):
923         (WebContextMenuClient::stopSpeaking):
924         * WebDownload.cpp:
925         (WebDownload::canResumeDownloadDecodedWithEncodingMIMEType):
926         (WebDownload::cancelAuthenticationChallenge):
927         (WebDownload::continueWithoutCredentialForAuthenticationChallenge):
928         (WebDownload::useCredential):
929         (WebDownload::didReceiveAuthenticationChallenge):
930         * WebEditorClient.cpp:
931         (WebEditorClient::spellCheckerDocumentTag):
932         (WebEditorClient::shouldBeginEditing):
933         (WebEditorClient::shouldEndEditing):
934         (WebEditorClient::didBeginEditing):
935         (WebEditorClient::respondToChangedContents):
936         (WebEditorClient::respondToChangedSelection):
937         (WebEditorClient::didEndEditing):
938         (WebEditorClient::didWriteSelectionToPasteboard):
939         (WebEditorClient::didSetSelectionTypesForPasteboard):
940         (WebEditorClient::shouldDeleteRange):
941         (WebEditorClient::shouldInsertNode):
942         (WebEditorClient::shouldInsertText):
943         (WebEditorClient::shouldApplyStyle):
944         (WebEditorClient::shouldChangeTypingStyle):
945         (WebEditorClient::webViewDidChangeTypingStyle):
946         (WebEditorClient::webViewDidChangeSelection):
947         (WebEditorClient::shouldShowDeleteInterface):
948         (WebEditorClient::shouldChangeSelectedRange):
949         * WebFrame.cpp:
950         (WebFrame::makeRepresentation):
951         (WebFrame::forceLayout):
952         (WebFrame::forceLayoutForNonHTML):
953         (WebFrame::setCopiesOnScroll):
954         (WebFrame::detachedFromParent1):
955         (WebFrame::detachedFromParent2):
956         (WebFrame::detachedFromParent3):
957         (WebFrame::detachedFromParent4):
958         (WebFrame::loadedFromCachedPage):
959         (WebFrame::dispatchDidLoadMainResource):
960         (WebFrame::revertToProvisionalState):
961         (WebFrame::clearUnarchivingState):
962         (WebFrame::setMainFrameDocumentReady):
963         (WebFrame::willChangeTitle):
964         (WebFrame::didChangeTitle):
965         (WebFrame::finalSetupForReplace):
966         (WebFrame::setDefersLoading):
967         (WebFrame::isArchiveLoadPending):
968         (WebFrame::cancelPendingArchiveLoad):
969         (WebFrame::clearArchivedResources):
970         (WebFrame::canShowMIMEType):
971         (WebFrame::representationExistsForURLScheme):
972         (WebFrame::generatedMIMETypeForURLScheme):
973         (WebFrame::restoreViewState):
974         (WebFrame::provisionalLoadStarted):
975         (WebFrame::shouldTreatURLAsSameAsCurrent):
976         (WebFrame::addHistoryItemForFragmentScroll):
977         (WebFrame::didFinishLoad):
978         (WebFrame::prepareForDataSourceReplacement):
979         (WebFrame::setDocumentViewFromCachedPage):
980         (WebFrame::shouldGoToHistoryItem):
981         (WebFrame::saveViewStateToItem):
982         (WebFrame::saveDocumentViewToCachedPage):
983         (WebFrame::canCachePage):
984         (WebFrame::setMainDocumentError):
985         (WebFrame::cannotShowURLError):
986         (WebFrame::cannotShowMIMETypeError):
987         (WebFrame::fileDoesNotExistError):
988         (WebFrame::willUseArchive):
989         (WebFrame::dispatchDidLoadResourceFromMemoryCache):
990         (WebFrame::startDownload):
991         (WebFrame::overrideMediaType):
992         (WebFrame::addInspector):
993         (WebFrame::removeInspector):
994
995 2007-05-25  Oliver Hunt  <oliver@apple.com>
996
997         Reviewed by Hyatt.
998         
999         Fix rdar://problem/5212399 <object> with PNG src rendered as image document (causes Acid2 to fail)
1000
1001         * WebFrame.cpp:
1002         (WebFrame::objectContentType):
1003
1004 2007-05-25  Geoffrey Garen  <ggaren@apple.com>
1005
1006         Build fix -- forgot to commit a little bit in my last patch.
1007
1008 2007-05-25  Geoffrey Garen  <ggaren@apple.com>
1009
1010         Reviewed by Darin Adler, Adam Roben.
1011
1012         Fixed <rdar://problem/5055182> The page cache has no global cap.
1013         
1014         The main WebKit changes are:
1015             1. Gutted IWebBackForwardList::setPageCacheSize and IWebBackForwardList:: 
1016             pageCacheSize because they're deprecated on Mac now. I didn't remove
1017             them, though, because doing so can cause COM badness.
1018             
1019             2. Added IWebPreferences::setUsesPageCache IWebPreferences:: 
1020             usesPageCache because that's the new Mac API. I added them to the end
1021             of IWebPreferences to avoid COM badness.
1022             
1023             3. Centralized calculation of object cache and page cache sizes inside
1024             WebPreferences. 
1025             
1026             Changed our old behavior of reading a preference and applying a fudge 
1027             factor with a new behavior of just using the preference directly. The 
1028             old behavior was confusing and often inappropriate. (For example, if 
1029             you set a page cache size of 100, a 256MB machine would somewhat 
1030             arbitrarily reduce that number to 98.)
1031             
1032 2007-05-24  Geoffrey Garen  <ggaren@apple.com>
1033
1034         Reviewed by Darin Adler.
1035
1036         Fixed a bug with Settings where a number of different objects held bare 
1037         Settings* data members, even though the Page owns the Settings object and 
1038         deletes it upon destruction.
1039         
1040         Added NULL checks since the Page can be deleted before the frame/document.
1041
1042 2007-05-23  Steve Falkenburg  <sfalken@apple.com>
1043
1044         Added IWebFramePrivate::isDescendantOfFrame.
1045
1046         * Interfaces/IWebFramePrivate.idl:
1047         * WebFrame.cpp:
1048         (WebFrame::isDescendantOfFrame):
1049         * WebFrame.h:
1050
1051 2007-05-23  Steve Falkenburg  <sfalken@apple.com>
1052
1053         Build fix.  Fix continuous rebuilding of Interfaces by turning off Generate Type Library for every IDL except WebKit.idl.
1054
1055         * WebKit.vcproj/Interfaces.vcproj:
1056
1057 2007-05-22  Alice Liu  <alice.liu@apple.com>
1058
1059         Reviewed by Oliver.
1060         
1061         Enabling smartInsertDelete to resolve 
1062         <rdar://problem/5082891> editing/deleting/smart-delete-003.html (and 004) fail
1063         
1064         * Interfaces/IWebView.idl:
1065         * WebEditorClient.cpp:
1066         (WebEditorClient::smartInsertDeleteEnabled):
1067         * WebView.cpp:
1068         (WebView::WebView):
1069         (WebView::initWithFrame):
1070         (WebView::toggleSmartInsertDelete):
1071         (WebView::setSmartInsertDeleteEnabled):
1072         (WebView::smartInsertDeleteEnabled):
1073         * WebView.h:
1074
1075 2007-05-22  Justin Garcia  <justin.garcia@apple.com>
1076
1077         Reviewed by oliver
1078         
1079         Build fix.
1080
1081         * WebView.cpp:
1082         (WebView::clearFocusNode):
1083
1084 2007-05-22  Steve Falkenburg  <sfalken@apple.com>
1085
1086         Reviewed by Ada.
1087         
1088         Added 3 view-related methods to IWebFramePrivate.
1089
1090         * Interfaces/IWebFramePrivate.idl: Added 3 new methods
1091         * WebFrame.cpp:
1092         (WebFrame::hasScrollBars): Added.
1093         (WebFrame::contentBounds): Added.
1094         (WebFrame::frameBounds): Added.
1095         * WebFrame.h:
1096
1097 2007-05-21  Steve Falkenburg  <sfalken@apple.com>
1098
1099         Reviewed by Adam, Ada.
1100         
1101         Added IWebFramePrivate::size().
1102
1103         * Interfaces/IWebFramePrivate.idl: Added size.
1104         * WebFrame.cpp:
1105         (WebFrame::size): Added.
1106         * WebFrame.h: Added size.
1107
1108 2007-05-21  Ada Chan  <adachan@apple.com>
1109
1110         Reviewed by Steve.
1111
1112         Added IWebViewPrivate::loadBackForwardListFromOtherView().  It replicates the backforward
1113         list from another webview and loads that in the current webview.
1114
1115         * Interfaces/IWebViewPrivate.idl:
1116         * WebView.cpp:
1117         (WebView::loadBackForwardListFromOtherView):
1118         * WebView.h:
1119
1120 2007-05-18  Steve Falkenburg  <sfalken@apple.com>
1121
1122         Build-related fix: stamp version resource properly.
1123
1124         * WebKit.vcproj/WebKit.rc: Fix version resource
1125
1126 2007-05-18  Adam Roben  <aroben@apple.com>
1127
1128         Build fix after r21555.
1129
1130         * WebView.cpp:
1131
1132 2007-05-17  Ada Chan  <adachan@apple.com>
1133
1134         Reviewed by Steve.
1135         
1136         Implemented IWebHTTPURLResponse::localizedStringForStatusCode().
1137
1138         * English.lproj/Localizable.strings: new http status strings
1139         * Interfaces/WebKit.idl: added code to create WebURLResponse instances
1140         * WebKitClassFactory.cpp:
1141         (WebKitClassFactory::CreateInstance): ditto
1142         * WebKitDLL.cpp: ditto
1143         * WebURLResponse.cpp:
1144         (CFHTTPMessageCopyLocalizedShortDescriptionForStatusCode): return the description
1145         text for the given status code
1146         (WebURLResponse::createInstance): create a general instance of web url response.
1147         (WebURLResponse::localizedStringForStatusCode):
1148         * WebURLResponse.h:
1149
1150 2007-05-17  Ada Chan  <adachan@apple.com>
1151
1152         Reviewed by Steve.
1153         
1154         Changed the context menu title "Search in Google" to "Search with Google".
1155
1156         * English.lproj/Localizable.strings:
1157         * WebCoreLocalizedStrings.cpp:
1158         (WebCore::contextMenuItemTagSearchWeb):
1159
1160 2007-05-17  Anders Carlsson  <andersca@apple.com>
1161
1162         Fix build.
1163         
1164         * WebFrame.cpp:
1165         (WebFrame::loadURLIntoChild):
1166
1167 2007-05-15  Steve Falkenburg  <sfalken@apple.com>
1168
1169         Reviewed by Darin, Oliver.
1170         
1171         <rdar://problem/4967360> Need to detect damaged installs, alert the user to reinstall, and exit
1172
1173         * WebLocalizableStrings.cpp:
1174         (WebLocalizedString): Make failure to load a localized string slightly less fatal
1175
1176 2007-05-15  Steve Falkenburg  <sfalken@apple.com>
1177
1178         Reviewed by Darin.
1179         
1180         <rdar://problem/4956541> Need to implement preference for how much History is maintained
1181
1182         * WebHistory.cpp:
1183         (WebHistory::ageLimitDate): Remove extra +30 from history age in days.
1184
1185 2007-05-14  Anders Carlsson  <andersca@apple.com>
1186
1187         Reviewed by Darin.
1188
1189         Pass an empty property bag when constructing the WebError, the code in Safari relies on having a user info bag.
1190         
1191         * WebFrame.cpp:
1192         (WebFrame::createJavaAppletWidget):
1193
1194 2007-05-14  Anders Carlsson  <andersca@apple.com>
1195
1196         Reviewed by Antti.
1197
1198         Report an error to the resource load delegate if the Java plugin can't be loaded.
1199         
1200         * WebFrame.cpp:
1201         (WebFrame::createJavaAppletWidget):
1202
1203 2007-05-11  Steve Falkenburg  <sfalken@apple.com>
1204
1205         Reviewed by Darin, Ada.
1206
1207         WebKit DCOM compatibility.
1208         When a WebKit hosting app calls RunAsLocalServer, the class object for CLSID_WebDebugProgram
1209         is registered to allow creation across processes.  This is for future compatibility with
1210         Drosera.
1211
1212         Added new exported function: RunAsLocalServer.
1213         This exposes WebKit inside the running exe as a LocalServer32 (COM server), which
1214         will allow Drosera to connect to it via DCOM.
1215
1216         We use the DCOM Universal Marshaller from oleaut32.dll, which performs marshalling
1217         based on type libraries, so as part of this change, I've done some work on making our
1218         interfaces compatible with this marshaller.
1219         
1220         Updated for compatibility w/ COM automation, and fixed up our type library.        
1221         Added type library registration/unregistration code.
1222         Marked methods not compatible w/ automation/marshalling as [local].
1223         
1224         As a side-effect, with these changes, the .NET tlbimp tool can create a .NET interop
1225         assembly to theoretically allow WebKit to be invoked from .NET apps.  I haven't
1226         tried this.  It could end up being useful to drive API testing.
1227         
1228         To test, I wrote a small app that calls:
1229         ::CoCreateInstance(CLSID_IWebDebugProgram, 0, CLSCTX_LOCAL_SERVER, IID_IUnknown, (void**)&viewUnknown);
1230         Using this instantiated class, I'm able to iterate the exisitng webviews and retrieve their
1231         source, title, URL, etc.
1232         
1233         * DOMCoreClasses.cpp:
1234         (DOMElement::isEqual):
1235         * DOMCoreClasses.h:
1236         * DefaultDownloadDelegate.cpp:
1237         (DefaultDownloadDelegate::decideDestinationWithSuggestedFilename):
1238         * DefaultDownloadDelegate.h:
1239         * Interfaces/DOMCSS.idl:
1240         * Interfaces/DOMCore.idl:
1241         * Interfaces/DOMEvents.idl:
1242         * Interfaces/DOMExtensions.idl:
1243         * Interfaces/DOMHTML.idl:
1244         * Interfaces/DOMPrivate.idl:
1245         * Interfaces/DOMRange.idl:
1246         * Interfaces/DOMWindow.idl:
1247         * Interfaces/IWebArchive.idl:
1248         * Interfaces/IWebAttributedString.idl: Removed.
1249         * Interfaces/IWebBackForwardList.idl:
1250         * Interfaces/IWebBackForwardListPrivate.idl:
1251         * Interfaces/IWebCache.idl:
1252         * Interfaces/IWebDataSource.idl:
1253         * Interfaces/IWebDebugProgram.idl: Added.
1254         * Interfaces/IWebDocument.idl:
1255         * Interfaces/IWebDownload.idl:
1256         * Interfaces/IWebEditingDelegate.idl:
1257         * Interfaces/IWebError.idl:
1258         * Interfaces/IWebFormDelegate.idl:
1259         * Interfaces/IWebFrame.idl:
1260         * Interfaces/IWebFrameLoadDelegate.idl:
1261         * Interfaces/IWebFrameLoadDelegatePrivate.idl:
1262         * Interfaces/IWebFramePrivate.idl:
1263         * Interfaces/IWebFrameView.idl:
1264         * Interfaces/IWebHTMLRepresentation.idl:
1265         * Interfaces/IWebHTTPURLResponse.idl:
1266         * Interfaces/IWebHistory.idl:
1267         * Interfaces/IWebHistoryItem.idl:
1268         * Interfaces/IWebHistoryItemPrivate.idl:
1269         * Interfaces/IWebIconDatabase.idl:
1270         * Interfaces/IWebJavaScriptCollector.idl:
1271         * Interfaces/IWebKitStatistics.idl:
1272         * Interfaces/IWebMutableURLRequest.idl:
1273         * Interfaces/IWebNotification.idl:
1274         * Interfaces/IWebNotificationCenter.idl:
1275         * Interfaces/IWebNotificationObserver.idl:
1276         * Interfaces/IWebPolicyDelegate.idl:
1277         * Interfaces/IWebPreferences.idl:
1278         * Interfaces/IWebResource.idl:
1279         * Interfaces/IWebResourceLoadDelegate.idl:
1280         * Interfaces/IWebResourceLoadDelegatePrivate.idl:
1281         * Interfaces/IWebScriptObject.idl:
1282         * Interfaces/IWebScrollBarDelegatePrivate.idl:
1283         * Interfaces/IWebScrollBarPrivate.idl:
1284         * Interfaces/IWebUIDelegate.idl:
1285         * Interfaces/IWebUIDelegatePrivate.idl:
1286         * Interfaces/IWebURLAuthenticationChallenge.idl:
1287         * Interfaces/IWebURLRequest.idl:
1288         * Interfaces/IWebURLResponse.idl:
1289         * Interfaces/IWebUndoManager.idl:
1290         * Interfaces/IWebUndoTarget.idl:
1291         * Interfaces/IWebView.idl:
1292         * Interfaces/IWebViewPrivate.idl:
1293         * Interfaces/WebKit.idl:
1294         * WebContextMenuClient.cpp:
1295         (WebContextMenuClient::getCustomMenuFromDefaultItems):
1296         * WebDataSource.cpp:
1297         (WebDataSource::subresources):
1298         * WebDataSource.h:
1299         * WebDebugProgram.cpp: Added.
1300         (EnumViews::EnumViews):
1301         (EnumViews::QueryInterface):
1302         (EnumViews::AddRef):
1303         (EnumViews::Release):
1304         (EnumViews::Next):
1305         (EnumViews::Skip):
1306         (EnumViews::Reset):
1307         (EnumViews::Clone):
1308         (WebDebugProgram::WebDebugProgram):
1309         (WebDebugProgram::~WebDebugProgram):
1310         (WebDebugProgram::createInstance):
1311         (WebDebugProgram::QueryInterface):
1312         (WebDebugProgram::AddRef):
1313         (WebDebugProgram::Release):
1314         (WebDebugProgram::viewAdded):
1315         (WebDebugProgram::viewRemoved):
1316         (WebDebugProgram::attach):
1317         (WebDebugProgram::detach):
1318         (WebDebugProgram::statistics):
1319         (WebDebugProgram::webViews):
1320         * WebDebugProgram.h: Added.
1321         * WebDropSource.cpp:
1322         (generateMouseEvent):
1323         * WebError.cpp:
1324         (WebError::localizedRecoveryOptions):
1325         * WebError.h:
1326         * WebFrame.cpp:
1327         (EnumChildFrames::EnumChildFrames):
1328         (EnumChildFrames::QueryInterface):
1329         (EnumChildFrames::AddRef):
1330         (EnumChildFrames::Release):
1331         (EnumChildFrames::Next):
1332         (EnumChildFrames::Skip):
1333         (EnumChildFrames::Reset):
1334         (EnumChildFrames::Clone):
1335         (WebFrame::childFrames):
1336         (WebFrame::initWithWebFrameView):
1337         * WebFrame.h:
1338         * WebHistoryItem.cpp:
1339         (WebHistoryItem::icon):
1340         * WebHistoryItem.h:
1341         * WebIconDatabase.cpp:
1342         (WebIconDatabase::iconForURL):
1343         (WebIconDatabase::defaultIconWithSize):
1344         * WebIconDatabase.h:
1345         * WebInspector/WebInspector.cpp:
1346         (WebInspector::WebInspector):
1347         (WebInspector::show):
1348         (WebInspector::onDestroy):
1349         (WebInspector::onSize):
1350         * WebInspector/WebInspector.h:
1351         (WebInspector::didReceiveIcon):
1352         (WebInspector::webViewFirstResponder):
1353         (WebInspector::makeFirstResponder):
1354         (WebInspector::contextMenuItemsForElement):
1355         (WebInspector::trackCustomPopupMenu):
1356         (WebInspector::addCustomMenuDrawingData):
1357         (WebInspector::cleanUpCustomMenuDrawingData):
1358         * WebKit.vcproj/Interfaces.vcproj:
1359         * WebKit.vcproj/WebKit.def:
1360         * WebKit.vcproj/WebKit.vcproj:
1361         * WebKit.vcproj/WebKitGUID.vcproj:
1362         * WebKit.vcproj/WebKit_debug.def:
1363         * WebKitClassFactory.cpp:
1364         (WebKitClassFactory::CreateInstance):
1365         * WebKitDLL.cpp:
1366         (DllGetClassObject):
1367         (DllUnregisterServer):
1368         (DllRegisterServer):
1369         (RunAsLocalServer):
1370         * WebKitStatistics.cpp:
1371         * WebScrollBar.cpp:
1372         (WebScrollBar::init):
1373         (WebScrollBar::handleMouseEvent):
1374         * WebScrollBar.h:
1375         * WebView.cpp:
1376         (WebView::WebView):
1377         (WebView::~WebView):
1378         (WebView::handleContextMenuEvent):
1379         (WebView::onInitMenuPopup):
1380         (WebView::onUninitMenuPopup):
1381         (WebViewWndProc):
1382         (WebView::QueryInterface):
1383         (WebView::MIMETypesShownAsHTML):
1384         (WebView::setHostWindow):
1385         (WebView::hostWindow):
1386         (WebView::generateSelectionImage):
1387         (WebView::pasteboardTypesForSelection):
1388         (WebView::pasteboardTypesForElement):
1389         (WebView::mainFrameIcon):
1390         (WebView::canMakeTextStandardSize):
1391         (WebView::viewWindow):
1392         * WebView.h:
1393
1394 2007-05-11  Adele Peterson  <adele@apple.com>
1395
1396         Build fix.
1397
1398         * WebView.cpp: (WebView::selectionImageRect):
1399
1400 2007-05-10  Geoffrey Garen  <ggaren@apple.com>
1401
1402         Reviewed by Darin Adler.
1403         
1404         "IconDatabase::sharedIconDatabase()" => "iconDatabase()" for terseness.
1405
1406 2007-05-10  Maciej Stachowiak  <mjs@apple.com>
1407
1408         Reviewed by Oliver.
1409
1410         - WebKitWin part of fix for:
1411         <rdar://problem/5063277> blank screen after login to Citibank Online (accessing document before frame starts loading cancels load)
1412         <rdar://problem/5159541> REGRESSION (r20972): Wall Street Journal pages replaced by advertisements (13465)
1413
1414         The basic approach is to have Frames start out containing an empty document instead of absolutely nothing,
1415         so there is no need to initialize them on demand. Various side effects of that cause both of these bugs.
1416         
1417         However, this caused many regressions so I had to fix the fallout.
1418
1419         * WebFrame.cpp:
1420         (WebFrame::createFrame): init frame
1421         * WebView.cpp:
1422         (WebView::initWithFrame): init frame
1423         (WebView::stringByEvaluatingJavaScriptFromString): don't create empty document
1424
1425 2007-05-08  Steve Falkenburg  <sfalken@apple.com>
1426
1427         Reviewed by Darin, Oliver.
1428         
1429         Added UI_STRING versions of localized WebCore strings.
1430
1431         * English.lproj/Localizable.strings: Updated.
1432         * English.lproj/StringsNotToBeLocalized.txt: Updated.
1433         * WebCoreLocalizedStrings.cpp: Added.
1434         (WebCore::searchableIndexIntroduction):
1435         (WebCore::submitButtonDefaultLabel):
1436         (WebCore::inputElementAltText):
1437         (WebCore::resetButtonDefaultLabel):
1438         (WebCore::fileButtonChooseFileLabel):
1439         (WebCore::fileButtonNoFileSelectedLabel):
1440         (WebCore::contextMenuItemTagOpenLinkInNewWindow):
1441         (WebCore::contextMenuItemTagDownloadLinkToDisk):
1442         (WebCore::contextMenuItemTagCopyLinkToClipboard):
1443         (WebCore::contextMenuItemTagOpenImageInNewWindow):
1444         (WebCore::contextMenuItemTagDownloadImageToDisk):
1445         (WebCore::contextMenuItemTagCopyImageToClipboard):
1446         (WebCore::contextMenuItemTagOpenFrameInNewWindow):
1447         (WebCore::contextMenuItemTagCopy):
1448         (WebCore::contextMenuItemTagGoBack):
1449         (WebCore::contextMenuItemTagGoForward):
1450         (WebCore::contextMenuItemTagStop):
1451         (WebCore::contextMenuItemTagReload):
1452         (WebCore::contextMenuItemTagCut):
1453         (WebCore::contextMenuItemTagPaste):
1454         (WebCore::contextMenuItemTagNoGuessesFound):
1455         (WebCore::contextMenuItemTagIgnoreSpelling):
1456         (WebCore::contextMenuItemTagLearnSpelling):
1457         (WebCore::contextMenuItemTagSearchWeb):
1458         (WebCore::contextMenuItemTagLookUpInDictionary):
1459         (WebCore::contextMenuItemTagOpenLink):
1460         (WebCore::contextMenuItemTagIgnoreGrammar):
1461         (WebCore::contextMenuItemTagSpellingMenu):
1462         (WebCore::contextMenuItemTagCheckSpelling):
1463         (WebCore::contextMenuItemTagCheckSpellingWhileTyping):
1464         (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
1465         (WebCore::contextMenuItemTagFontMenu):
1466         (WebCore::contextMenuItemTagBold):
1467         (WebCore::contextMenuItemTagItalic):
1468         (WebCore::contextMenuItemTagUnderline):
1469         (WebCore::contextMenuItemTagOutline):
1470         (WebCore::contextMenuItemTagWritingDirectionMenu):
1471         (WebCore::contextMenuItemTagDefaultDirection):
1472         (WebCore::contextMenuItemTagLeftToRight):
1473         (WebCore::contextMenuItemTagRightToLeft):
1474         (WebCore::contextMenuItemTagShowSpellingPanel):
1475         (WebCore::searchMenuNoRecentSearchesText):
1476         (WebCore::searchMenuRecentSearchesText):
1477         (WebCore::searchMenuClearRecentSearchesText):
1478         (WebCore::AXWebAreaText):
1479         (WebCore::AXLinkText):
1480         (WebCore::AXListMarkerText):
1481         (WebCore::AXImageMapText):
1482         (WebCore::AXHeadingText):
1483         * WebKit.vcproj/WebKit.vcproj: Added WebCoreLocalizedStrings.cpp, reorganized other files a bit.
1484
1485 2007-05-08  Steve Falkenburg  <sfalken@apple.com>
1486
1487         Reviewed by Ada.
1488         
1489         Update editing delegate
1490
1491         * Interfaces/IWebEditingDelegate.idl:
1492         * WebEditorClient.cpp:
1493         (WebEditorClient::updateSpellingUIWithGrammarString):
1494         * WebEditorClient.h:
1495
1496 2007-05-07  Steve Falkenburg  <sfalken@apple.com>
1497
1498         Reviewed by Darin.
1499
1500         Fix typo in prefs code.       
1501
1502         * WebPreferences.cpp:
1503         (WebPreferences::preferencesPath): Fix typo in error handling.
1504
1505 2007-05-04  Steve Falkenburg  <sfalken@apple.com>
1506
1507         Reviewed by Darin.
1508         
1509         Fix crash when using "check spelling while typing".
1510
1511         * WebView.cpp:
1512         (WebView::preflightSpellChecker): Set delegate static global for use in spell checker init.
1513
1514 2007-05-03  Steve Falkenburg  <sfalken@apple.com>
1515
1516         Reviewed by Ada, Oliver.
1517         
1518         Checkpoint:
1519         <rdar://problem/4602372> Spelling
1520         <rdar://problem/4769763> Spell checking engine support        
1521
1522         * Interfaces/IWebEditingDelegate.idl: Add userDescription parameter.
1523         * WebEditorClient.cpp:
1524         (WebEditorClient::updateSpellingUIWithGrammarString): Set user description for spelling errors.
1525         * WebEditorClient.h:
1526         * WebView.cpp:
1527         (WebView::replaceSelectionWithText): Implemented.
1528
1529 2007-05-01  Steve Falkenburg  <sfalken@apple.com>
1530
1531         Reviewed by Oliver.
1532         
1533         Fix usage errors in COM enumeration.
1534
1535         * WebEditorClient.cpp:
1536         (WebEditorClient::checkGrammarOfString): Call Next correctly.
1537         (WebEditorClient::getGuessesForWord): Call Next correctly.
1538
1539 2007-04-30  Alice Liu  <alice.liu@apple.com>
1540
1541         Reviewed by Adam.
1542
1543         Fixed <rdar://5126201> crash closing tab when the two following tabs are empty.
1544         Basically this fix involved one thing, which lead to another thing.  First, the crash
1545         was fixed by moving the call to webView->close from SearchableWebView::onDestroy to
1546         WebViewWndProc when WM_DESTROY message is processed.  We now want only WebKit handling
1547         the closure of a WebView, so all calls to WebView::close have been removed, save for
1548         the one call in WebViewWndProc.
1549
1550         * Interfaces/IWebView.idl:
1551         removed close() from public interface
1552         * WebInspector/WebInspector.cpp:
1553         (WebInspector::onDestroy):
1554         removed call to close()
1555         * WebView.cpp:
1556         (WebView::~WebView):
1557         move the deleting of m_page down a bit to avoid a crash 
1558         (WebView::close):
1559         changed from public API to just a public function
1560         (WebViewWndProc):
1561         webView->close() was moved here from SearchableWebView::onDestroy
1562         * WebView.h:
1563         changed close() to a public function not exposed in the WebKit interface
1564
1565 2007-04-24  Steve Falkenburg  <sfalken@apple.com>
1566
1567         Reviewed by Darin, Oliver.
1568         
1569         Checkpoint:
1570         <rdar://problem/4602372> Spelling
1571         <rdar://problem/4769763> Spell checking engine support
1572
1573         * WebEditorClient.cpp:
1574         (WebEditorClient::isContinuousSpellCheckingEnabled):
1575         (WebEditorClient::toggleContinuousSpellChecking):
1576         (WebEditorClient::isGrammarCheckingEnabled):
1577         (WebEditorClient::toggleGrammarChecking):
1578         (initViewSpecificSpelling):
1579         (WebEditorClient::spellCheckerDocumentTag):
1580         (WebEditorClient::ignoreWordInSpellDocument):
1581         (WebEditorClient::learnWord):
1582         (WebEditorClient::checkSpellingOfString):
1583         (WebEditorClient::checkGrammarOfString):
1584         (WebEditorClient::udpateSpellingUIWithGrammarString):
1585         (WebEditorClient::updateSpellingUIWithMisspelledWord):
1586         (WebEditorClient::showSpellingUI):
1587         (WebEditorClient::spellingUIIsShowing):
1588         (WebEditorClient::getGuessesForWord):
1589         * WebPreferences.h:
1590
1591 2007-04-20  Ada Chan  <adachan@apple.com>
1592
1593         Reviewed by Steve and Oliver.
1594         
1595         Implemented some DOM methods I need to support password input and textarea in 
1596         WebView-based edit fields in the app.
1597
1598         * DOMCSSClasses.cpp:
1599         (DOMCSSStyleDeclaration::setCssText): added implementation
1600         * DOMCoreClasses.cpp:
1601         (DOMDocument::createElement): ditto
1602         * DOMHTMLClasses.cpp:
1603         (DOMHTMLInputElement::setType): ditto
1604         (DOMHTMLTextAreaElement::value): ditto
1605         (DOMHTMLTextAreaElement::setValue): ditto
1606         (DOMHTMLTextAreaElement::select): ditto
1607         * Interfaces/IWebUIDelegatePrivate.idl: added a new method webViewGetDlgCode() that client
1608         can implement if it wants to handle keypresses themselves rather than letting the system 
1609         interpret certain keys as dialog box navigation keys.
1610         * WebKitGraphics.cpp:
1611         (DrawTextAtPoint): handle drawing text as password
1612         * WebKitGraphics.h:
1613         * WebView.cpp:
1614         Added Copy, Cut, and Paste to the keyEntries.
1615         (WebViewWndProc): added code to handle WM_GETDLGCODE.  Calls IWebUIDelegatePrivate::webViewGetDlgCode()
1616         if available to see if the client wants to handle it.
1617
1618 2007-04-18  Adam Roben  <aroben@apple.com>
1619
1620         Reviewed by Steve.
1621
1622         Make development builds use the same CLSIDs as archive builds, and get
1623         rid of the now-unused set of CLSIDs.
1624
1625         * Interfaces/WebKit.idl: Use the archive build CLSIDs if we're not
1626         doing a production build.
1627         * WebKit.vcproj/Interfaces.vcproj: Don't define __ARCHIVE_BUILD__
1628         because it's not used anymore.
1629
1630 2007-04-18  Adam Roben  <aroben@apple.com>
1631
1632         Reviewed by Steve.
1633
1634         Use different ProgIDs for production builds.
1635
1636         * ProgIDMacros.h: Added.
1637         * WebKit.vcproj/WebKit.vcproj: Defined the __BUILDBOT__ macro and added
1638         a new header which is copied in the post-build step.
1639         * WebKitDLL.cpp: Macro-ized the declaration of the registry keys to
1640         install.
1641
1642 2007-04-16  Adam Roben  <aroben@apple.com>
1643
1644         Rubberstamped by Steve.
1645
1646         * WebKit.vcproj/WebKit.sln: Removed the Debug_Internal configuration.
1647
1648 2007-04-16  Adam Roben  <aroben@apple.com>
1649
1650         Reviewed by Steve.
1651
1652         Removed the pre-link build step, and removed registration of WebKit.dll
1653         from the post-build step.
1654
1655         * WebKit.vcproj/WebKit.vcproj:
1656
1657 2007-04-16  Adam Roben  <aroben@apple.com>
1658
1659         * WebKit.vcproj/WebKit.sln: Added WTF to the solution.
1660
1661 2007-04-16  Steve Falkenburg  <sfalken@apple.com>
1662
1663         Reviewed by Adam.
1664         
1665         Visual Studio Express compatibility for WebKit build (except for DRT)
1666
1667         * WebDragClient.cpp: Removed unused header (atlsafe.h)
1668         * WebKit.vcproj/WebKit.rc: Removed afxres.h and related code
1669         * WebKit.vcproj/WebKit.sln: Don't use a sln folder - they aren't supported by express
1670         * WebKit.vcproj/WebKit.vcproj: Add explicit lib references for Windows system libs (VS express doesn't include these)
1671         * WebView.cpp: Removed unused header (atldef.h)
1672
1673 2007-04-16  Adam Roben  <aroben@apple.com>
1674
1675         Merge in r20872.
1676
1677         * WebInspector/webInspector/inspector.js:
1678         * WebInspector/webInspector/treeoutline.js:
1679
1680 2007-04-16  Adam Roben  <aroben@apple.com>
1681
1682         Merge in r20861.
1683
1684         * WebInspector/webInspector/inspector.js:
1685         * WebInspector/webInspector/treeoutline.js:
1686
1687 2007-04-16  Adam Roben  <aroben@apple.com>
1688
1689         Merge in r20845.
1690
1691         * WebInspector/webInspector/inspector.js:
1692
1693 2007-04-16  Adam Roben  <aroben@apple.com>
1694
1695         Merge in r20844.
1696
1697         * WebInspector/webInspector/inspector.js:
1698
1699 2007-04-16  Adam Roben  <aroben@apple.com>
1700
1701         Merge in r20843.
1702
1703         * WebInspector/webInspector/inspector.js:
1704         * WebInspector/webInspector/scrollarea.js:
1705         * WebInspector/webInspector/scrollbar.js:
1706         * WebInspector/webInspector/utilities.js:
1707
1708 2007-04-16  Adam Roben  <aroben@apple.com>
1709
1710         Merge in r20842.
1711
1712         * WebInspector/webInspector/inspector.html:
1713         * WebInspector/webInspector/inspector.js:
1714         * WebInspector/webInspector/utilities.js: Added.
1715
1716 2007-04-16  Adam Roben  <aroben@apple.com>
1717
1718         Merge in r20840.
1719
1720         * WebInspector/webInspector/inspector.html:
1721         * WebInspector/webInspector/inspector.js:
1722         * WebInspector/webInspector/treeoutline.js: Added.
1723
1724 2007-04-14  Adam Roben  <aroben@apple.com>
1725
1726         * WebKit.vcproj/WebKitGUID.vcproj: Need to use WebKitConfigSuffix
1727         instead of ConfigSuffix now.
1728
1729 2007-04-14  Adam Roben  <aroben@apple.com>
1730
1731         * WebKit.vcproj/WebKit.submit.sln: Use the Debug_Internal configuration
1732         when B&I builds Debug.
1733
1734 2007-04-12  Steve Falkenburg  <sfalken@apple.com>
1735
1736         Reviewed by Geoff, Adam.
1737         
1738         Changes required for search history content.
1739
1740         * Interfaces/IWebFramePrivate.idl:
1741         * WebFrame.cpp:
1742         (WebFrame::isFrameSet): Added
1743         (WebFrame::string): Added
1744         * WebFrame.h:
1745
1746 2007-04-12  Adam Roben  <aroben@apple.com>
1747
1748         Rubberstamped by Steve.
1749
1750         Copied WebKit.sln to WebKit.submit.sln, and added missing projects to
1751         WebKit.sln so that opensource contributors can use it to build a
1752         working WebKit.
1753
1754         * WebKit.vcproj/WebKit.make: Changed to use WebKit.submit.sln.
1755         * WebKit.vcproj/WebKit.sln: Added JavaScriptCore, WebCore,
1756         DumpRenderTree projects.
1757         * WebKit.vcproj/WebKit.submit.sln: Added.
1758
1759 2007-04-12  Adam Roben  <aroben@apple.com>
1760
1761         Reviewed by Steve.
1762
1763         <rdar://problem/5131565> Need to be able to use debug WebKit with
1764         release Safari.
1765
1766         Added a new configuration to WebKit.vcproj called Debug_Internal to be
1767         used by Apple internal builds. The Debug configuration is now meant to
1768         be used by opensource builds, and will always link against release
1769         versions of CF, CFNet, CG, etc. Debug_Internal is identical to Debug
1770         except for the property sheet it uses, and the Debug configuration
1771         doesn't register WebKit_debug.dll when finished.
1772
1773         We now have two macros, $(WebKitConfigSuffix) and
1774         $(LibraryConfigSuffix). WebKitConfigSuffix is used for WebKit projects,
1775         and is "_debug" for both Debug and Debug_Internal. LibraryConfigSuffix
1776         is used for external projects, and is "" for Debug and "_debug" for
1777         Debug_Internal.
1778
1779         * WebKit.vcproj/WebKit.vcproj:
1780         * WebKit.vcproj/debug.vsprops:
1781         * WebKit.vcproj/debug_internal.vsprops: Added.
1782         * WebKit.vcproj/release.vsprops:
1783
1784 2007-04-12  John Sullivan  <sullivan@apple.com>
1785
1786         Reviewed by Anders
1787
1788         * Interfaces/IWebUIDelegate.idl:
1789         added new PDF-related context menu items to enum to keep it in sync with WebCore
1790
1791 2007-04-12  Mark Rowe  <mrowe@apple.com>
1792
1793         Not reviewed.  Internal counterpart to open-source r20856.
1794
1795         * WebChromeClient.cpp:
1796         (WebChromeClient::createWindow):
1797         (WebChromeClient::createModalDialog):
1798         * WebChromeClient.h:
1799
1800 2007-04-11  Ada Chan  <adachan@apple.com>
1801
1802         Reviewed by Steve.
1803         
1804         Implemented WebHistoryItem::originalURLString().  Added parameter checks to other methods.
1805
1806         * WebHistoryItem.cpp:
1807         (WebHistoryItem::originalURLString):
1808         (WebHistoryItem::URLString):
1809         (WebHistoryItem::title):
1810         (WebHistoryItem::lastVisitedTimeInterval):
1811
1812 2007-04-10  Brady Eidson  <beidson@apple.com>
1813
1814         Reviewed by Darin
1815
1816         <rdar://problem/4887095> - PageCache and PageState should be combined
1817
1818         Basically updated client methods for the new names and signatures 
1819
1820         * WebFrame.cpp:
1821         (WebFrame::loadedFromCachedPage):
1822         (WebFrame::setDocumentViewFromCachedPage):
1823         (WebFrame::saveDocumentViewToCachedPage):
1824         * WebFrame.h:
1825
1826 2007-04-10  Adam Roben  <aroben@apple.com>
1827
1828         Reviewed by Anders.
1829
1830         Fix <rdar://problem/5119803> Web Inspector has no options menu
1831
1832         * WebInspector/WebInspector.cpp:
1833         (interpreterForFrame): Added.
1834         (WebInspector::showOptionsMenu): Implemented.
1835         (WebInspector::onCommand): Added.
1836         (WebInspector::toggleIgnoreWhitespace): Implemented.
1837         (WebInspector::toggleShowUserAgentStyles): Implemented.
1838         (WebInspectorWndProc): Added case for WM_COMMAND.
1839         * WebInspector/WebInspector.h:
1840
1841 2007-04-09  Anders Carlsson  <andersca@apple.com>
1842
1843         Reviewed by Adam.
1844
1845         <rdar://problem/5062624>
1846         No prompt to install QT for pages with uninstalled QT plug-in.
1847         
1848         * CFDictionaryPropertyBag.cpp:
1849         (CFDictionaryPropertyBag::Read):
1850         (CFDictionaryPropertyBag::Write):
1851         Use LPCOLESTRToCFStringRef here since the property names aren't BSTRs.
1852         
1853         * Interfaces/IWebError.idl:
1854         Add user info keys.
1855         
1856         * MarshallingHelpers.cpp:
1857         (MarshallingHelpers::LPCOLESTRToCFStringRef):
1858         * MarshallingHelpers.h:
1859         New function.
1860         
1861         * WebError.cpp:
1862         (WebError::WebError):
1863         (WebError::createInstance):
1864         Take a property bag.
1865         
1866         (WebError::userInfo):
1867         Return the property bag.
1868         
1869         * WebFrame.cpp:
1870         (WebFrame::createPlugin):
1871         If the plug-in wasn't found or failed to load, create a WebError with the right user info and
1872         call IWebResourceLoadDelegate::plugInFailedWithError.
1873
1874 2007-04-09  Brady Eidson  <beidson@apple.com>
1875
1876         Build Fix
1877
1878         * WebContextMenuClient.cpp:
1879         (WebContextMenuClient::searchWithGoogle): userGesture is true
1880
1881 2007-04-09  Timothy Hatcher  <timothy@apple.com>
1882
1883         Merge in r20810.
1884
1885         <rdar://problem/5121757> WebInspector focuses elements on mouse up instead of mouse down
1886
1887         Make selecting a tree node happen on mousedown to match the NSOutlineView behavior.
1888         Also makes selecting rows in the style pane happen on mousedown for consistency.
1889
1890         * WebInspector/webInspector/inspector.js:
1891
1892 2007-04-09  Adam Roben  <aroben@apple.com>
1893
1894         Fixed copyrights.
1895
1896         * WebInspector/WebInspector.cpp:
1897         * WebInspector/WebInspector.h:
1898
1899 2007-04-09  Adam Roben  <aroben@apple.com>
1900
1901         Reviewed by Oliver.
1902
1903         Fix two Web Inspector bugs:
1904         - The WebView wasn't focused when the inspector first appeared.
1905         - Resizing the upper pane did not resize the whole window.
1906
1907         * WebInspector/WebInspector.cpp:
1908         (WebInspector::show): Focus the WebView.
1909         (WebInspector::setFrame): Implemented.
1910         (WebInspector::webViewFrame): Implemented.
1911         * WebInspector/WebInspector.h:
1912
1913 2007-04-09  Adam Roben  <aroben@apple.com>
1914
1915         * WebInspector/WebInspector.cpp:
1916         (WebInspector::WebInspector): Removed two fixed FIXMEs and some
1917         commented-out code.
1918
1919 2007-04-08  Adam Roben  <aroben@apple.com>
1920
1921         When does "merge" != "merge"? When you make the change yourself
1922         pre-emptively and make a typo.
1923
1924         * WebInspector/webInspector/inspector.js:
1925
1926 2007-04-08  Adam Roben  <aroben@apple.com>
1927
1928         Merge in r20800.
1929
1930         * WebInspector/webInspector/inspector.js:
1931
1932 2007-04-08  Adam Roben  <aroben@apple.com>
1933
1934         Merge in r20797.
1935
1936         * WebInspector/webInspector/inspector.js:
1937
1938 2007-04-08  Adam Roben  <aroben@apple.com>
1939
1940         Merge in r20796.
1941
1942         * WebInspector/webInspector/inspector.js:
1943
1944 2007-04-08  Adam Roben  <aroben@apple.com>
1945
1946         Reviewed by Anders.
1947
1948         <rdar://problem/5119804> Web Inspector isn't resizable
1949         <rdar://problem/5119805> Can't move Web Inspector
1950
1951         * WebInspector/WebInspector.cpp:
1952         (WebInspectorPrivate::WebInspectorPrivate):
1953         (WebInspector::WebInspector): Subclass the WebView so we can intercept
1954         its messages.
1955         (WebInspector::onDestroy): Undo the subclassing.
1956         (WebInspector::handleMessageSentToWebView): Added.
1957         (WebInspector::onLButtonDown): Added.
1958         (WebInspector::onLButtonUp): Added.
1959         (WebInspector::onMouseMove): Added.
1960         (WebInspectorWndProc): Added cases for mouse messages.
1961         (SubclassedWebViewWndProc): Added.
1962         * WebInspector/WebInspector.h:
1963
1964 2007-04-08  Adam Roben  <aroben@apple.com>
1965
1966         Merge in r20793.
1967
1968         * WebInspector/webInspector/AppleScrollArea.js: Removed.
1969         * WebInspector/webInspector/AppleScrollbar.js: Removed.
1970         * WebInspector/webInspector/Images/resize.png: Added.
1971         * WebInspector/webInspector/inspector.css:
1972         * WebInspector/webInspector/inspector.html:
1973         * WebInspector/webInspector/inspector.js:
1974         * WebInspector/webInspector/scrollarea.js: Added.
1975         * WebInspector/webInspector/scrollbar.js: Added.
1976
1977 2007-04-08  Adam Roben  <aroben@apple.com>
1978
1979         Merge in r20792.
1980
1981         * WebInspector/webInspector/inspector.js:
1982
1983 2007-04-08  Adam Roben  <aroben@apple.com>
1984
1985         Merge in r20791.
1986
1987         * WebInspector/webInspector/inspector.js:
1988
1989 2007-04-08  Adam Roben  <aroben@apple.com>
1990
1991         Merge in r20789.
1992
1993         * WebInspector/webInspector/inspector.js:
1994
1995 2007-04-08  Adam Roben  <aroben@apple.com>
1996
1997         Build fix.
1998
1999         * WebInspector/WebInspector.cpp:
2000
2001 2007-04-07  Adam Roben  <aroben@apple.com>
2002
2003         Reviewed by Oliver.
2004
2005         <rdar://problem/4769828> Web Inspector
2006
2007         * WebInspector/WebInspector.cpp: Renamed from WebInspector.m. Ported
2008         Mac code. Some parts are left commented out to aid later
2009         implementation.
2010         * WebInspector/WebInspector.h: Ditto.
2011
2012         * DOMCoreClasses.cpp: Added IID_DOMNode.
2013         (DOMNode::QueryInterface): Added case for IID_DOMNode.
2014         (DOMNode::isSameNode): Implemented.
2015         * DOMCoreClasses.h: Added IID_DOMNode.
2016         (DOMNode::node): Added.
2017         * English.lproj/Localizable.strings: Updated for "Inspect Element".
2018         * WebContextMenuClient.cpp:
2019         (WebContextMenuClient::getCustomMenuFromDefaultItems): Add the "Inspect
2020         Element" item.
2021         * WebFrame.cpp:
2022         (WebFrame::addInspector): Stubbed out.
2023         (WebFrame::removeInspector): Ditto.
2024         * WebFrame.h: Added declarations.
2025         * WebKit.resources/Info.plist: Added. This was needed so that the
2026         WebKit bundle would have a bundle identifier.
2027         * WebKit.vcproj/WebKit.vcproj: Added new files to project, and modified
2028         the post-build step to copy Info.plist and everything in
2029         WebInspector/webInspector to WebKit.resources.
2030         * WebView.cpp:
2031         (WebView::performContextMenuAction): Added case for the Inspect Element item.
2032         (WebView::inspectElement): Added.
2033         * WebView.h: Added declaration.
2034
2035 2007-04-07  Adam Roben  <aroben@apple.com>
2036
2037         Forked most of the WebInspector directory from
2038         r20780 of branches/WebInspectorRefresh/WebKit/WebInspector.
2039
2040         * WebInspector/WebInspector.h: Added.
2041         * WebInspector/WebInspector.m: Added.
2042         (+[WebInspector sharedWebInspector]):
2043         (-[WebInspector init]):
2044         (-[WebInspector initWithWebFrame:]):
2045         (-[WebInspector dealloc]):
2046         (-[WebInspector window]):
2047         (-[WebInspector windowWillClose:]):
2048         (-[WebInspector showWindow:]):
2049         (-[WebInspector setWebFrame:]):
2050         (-[WebInspector webFrame]):
2051         (-[WebInspector setRootDOMNode:]):
2052         (-[WebInspector rootDOMNode]):
2053         (-[WebInspector setFocusedDOMNode:]):
2054         (-[WebInspector focusedDOMNode]):
2055         (-[WebInspector setSearchQuery:]):
2056         (-[WebInspector searchQuery]):
2057         (-[WebInspector showOptionsMenu]):
2058         (-[WebInspector _toggleIgnoreWhitespace:]):
2059         (-[WebInspector _toggleShowUserAgentStyles:]):
2060         (-[WebInspector _highlightNode:]):
2061         (-[WebInspector _nodeHighlightExpired:]):
2062         (-[WebInspector _update]):
2063         (-[WebInspector _updateRoot]):
2064         (-[WebInspector _updateSystemColors]):
2065         (-[WebInspector _applicationWillResignActive]):
2066         (-[WebInspector _applicationDidBecomeActive]):
2067         (-[WebInspector _webFrameDetached:]):
2068         (+[WebInspector isSelectorExcludedFromWebScript:]):
2069         (+[WebInspector webScriptNameForSelector:]):
2070         (+[WebInspector isKeyExcludedFromWebScript:]):
2071         (-[WebInspector inspectedWebViewProgressFinished:]):
2072         (-[WebInspector webView:didFinishLoadForFrame:]):
2073         (-[WebInspector webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2074         (-[WebInspector webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
2075         (-[WebInspector webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
2076         (-[WebInspectorPrivate dealloc]):
2077         (-[DOMNode _isAncestorOfNode:]):
2078         * WebInspector/webInspector/AppleScrollArea.js: Added.
2079         * WebInspector/webInspector/AppleScrollbar.js: Added.
2080         * WebInspector/webInspector/Images/button.png: Added.
2081         * WebInspector/webInspector/Images/buttonDivider.png: Added.
2082         * WebInspector/webInspector/Images/buttonPressed.png: Added.
2083         * WebInspector/webInspector/Images/close.png: Added.
2084         * WebInspector/webInspector/Images/closePressed.png: Added.
2085         * WebInspector/webInspector/Images/downTriangle.png: Added.
2086         * WebInspector/webInspector/Images/menu.png: Added.
2087         * WebInspector/webInspector/Images/menuPressed.png: Added.
2088         * WebInspector/webInspector/Images/popup.png: Added.
2089         * WebInspector/webInspector/Images/popupPressed.png: Added.
2090         * WebInspector/webInspector/Images/rightTriangle.png: Added.
2091         * WebInspector/webInspector/Images/scrollThumbBottom.png: Added.
2092         * WebInspector/webInspector/Images/scrollThumbMiddle.png: Added.
2093         * WebInspector/webInspector/Images/scrollThumbTop.png: Added.
2094         * WebInspector/webInspector/Images/scrollTrackBottom.png: Added.
2095         * WebInspector/webInspector/Images/scrollTrackMiddle.png: Added.
2096         * WebInspector/webInspector/Images/scrollTrackTop.png: Added.
2097         * WebInspector/webInspector/Images/upTriangle.png: Added.
2098         * WebInspector/webInspector/inspector.css: Added.
2099         * WebInspector/webInspector/inspector.html: Added.
2100         * WebInspector/webInspector/inspector.js: Added.
2101
2102 2007-04-06  Dave Hyatt  <hyatt@apple.com>
2103
2104         Internal side of fix for bug 13274.
2105
2106         Reviewed by olliej
2107
2108         * Interfaces/IWebScrollBarPrivate.idl:
2109         * WebScrollBar.cpp:
2110         * WebScrollBar.h:
2111         * WebView.cpp:
2112         (WebView::handleMouseEvent):
2113
2114 2007-04-04  Oliver Hunt  <oliver@apple.com>
2115
2116         Reviewed by Ada.
2117         
2118         Fix <rdar://problem/5111027> Dragging a link on page
2119         shows URL thumbnail as nearly-transparent instead 
2120         semi-transparent
2121
2122         Error in createDragImageForLink led me to get wrong 
2123         maximum drag image size, now logic and maximum drag 
2124         image size corrected.
2125
2126         * WebDragClient.cpp:
2127         (WebDragClient::createDragImageForLink):
2128
2129 2007-04-04  Adam Roben  <aroben@apple.com>
2130
2131         Release build fix for TestNetscapePlugin.
2132
2133         * WebKit.vcproj/WebKit.vcproj: Make the Release post-build step the
2134         same as the Debug one so that the npapi headers get copied.
2135
2136 2007-04-03  Adam Roben  <aroben@apple.com>
2137
2138         Reviewed by Anders.
2139
2140         WebKit part of fix for <rdar://problem/5103999> All dom/svg tests are
2141         failing due to extra/missing newlines
2142
2143         * DOMCoreClasses.cpp:
2144         (DOMElement::innerText): Added.
2145         * DOMCoreClasses.h: Added declaration.
2146         * Interfaces/DOMPrivate.idl: Ditto.
2147
2148 2007-04-02  Steve Falkenburg  <sfalken@apple.com>
2149
2150         Reviewed by Darin.
2151         
2152         Expose COM class counter
2153
2154         * Interfaces/IWebKitStatistics.idl: Added comClassCount
2155         * WebKitStatistics.cpp:
2156         (WebKitStatistics::comClassCount): Added
2157         * WebKitStatistics.h:
2158
2159 2007-03-31  Steve Falkenburg  <sfalken@apple.com>
2160
2161         Reviewed by Hyatt.
2162
2163         <rdar://problem/5091159> Boomer has no bundle identifier - is the bundle correctly formed?
2164         <rdar://problem/5088764> Move the "Icon.db" file under "Local Settings"
2165
2166         * WebIconDatabase.cpp:
2167         (userIconDatabasePath): Prefer to store Icon.db file keyed off of bundle executable name
2168         * WebPreferences.cpp:
2169         (WebPreferences::preferencesPath): Prefer to store WebKit Preferences keyed off of bundle executable name
2170
2171 2007-03-30  Adele Peterson  <adele@apple.com>
2172
2173         Reviewed by Beth.
2174
2175         Fix <rdar://problem/5079824> editing/deleting/delete-by-word-001 is failing
2176
2177         * WebView.cpp: Add DeleteWordForward and DeleteWordBackward to key command table.
2178
2179 2007-03-30  Anders Carlsson  <andersca@apple.com>
2180
2181         Reviewed by Adele.
2182
2183         <rdar://problem/5101970> 
2184         Crash when submitting form, running under App Verifier
2185         
2186         * WebActionPropertyBag.cpp:
2187         (findMouseEvent):
2188         Return the right event.
2189
2190 2007-03-30  Anders Carlsson  <andersca@apple.com>
2191
2192         Reviewed by Geoff.
2193
2194         * Interfaces/IWebViewPrivate.idl:
2195         Add addAdditionalPluginPath method.
2196         
2197         * WebKit.vcproj/WebKit.vcproj:
2198         Copy NP includes so they can be included by the test plugin.
2199         
2200         * WebView.cpp:
2201         (WebView::stringByEvaluatingJavaScriptFromString):
2202         Hold JSLock while we call JSValue::getString().
2203         
2204         (WebView::addAdditionalPluginPath):
2205         * WebView.h:
2206         Implement addAdditionalPluginPath.
2207
2208 2007-03-27  Dave Hyatt  <hyatt@apple.com>
2209
2210         Enable complex text.  Selection and small-caps support are now enabled with this patch.
2211         
2212         Reviewed by aroben
2213
2214         * WebPreferences.cpp:
2215         (WebPreferences::initialize):
2216
2217 2007-03-26  Brady Eidson  <beidson@apple.com>
2218
2219         Reviewed by Ada
2220
2221         This one didn't actually have any leaks, but I just felt like doing the
2222         same style cleanup as the others :)
2223         
2224         * WebPreferences.cpp:
2225         (WebPreferences::stringValueForKey):
2226         (WebPreferences::integerValueForKey):
2227         (WebPreferences::floatValueForKey):
2228         (WebPreferences::setStringValue):
2229         (WebPreferences::setIntegerValue):
2230         (WebPreferences::save):
2231         (WebPreferences::load):
2232
2233 2007-03-26  Brady Eidson  <beidson@apple.com>
2234
2235         Reviewed by Ada
2236
2237         <rdar://5090412> - Plug CFNumberRef leaks in WebCache
2238         
2239         * WebCache.cpp:
2240         (WebCache::statistics):
2241
2242 2007-03-26  Beth Dakin  <bdakin@apple.com>
2243
2244         Reviewed by Geoff.
2245
2246         Fix build without breaking anything.
2247
2248         * WebHistory.cpp:
2249         (releaseUserInfo): Added silly void statement for now.
2250
2251 2007-03-26  Beth Dakin  <bdakin@apple.com>
2252
2253         Rubber-stamped by Brady.
2254
2255         Build fix for release build.
2256
2257         * WebHistory.cpp:
2258         (releaseUserInfo): Do not store userInfo->Release() in a local 
2259         variable since it is only used for an ASSERT.
2260
2261 2007-03-26  Steve Falkenburg  <sfalken@apple.com>
2262
2263         Reviewed by Lou.
2264         
2265         <rdar://problem/5088764> Move the "Icon.db" file under "Local Settings"
2266
2267         * WebIconDatabase.cpp:
2268         (userIconDatabasePath): Move icon database to non-roaming location
2269
2270 2007-03-25  Brady Eidson  <beidson@apple.com>
2271
2272         Reviewed by Oliver
2273         
2274         <rdar://problem/5086888> - WebHistory(Item) Leak
2275         
2276         This is a pretty thourough touchup up style and correctness that
2277         plugs at least 1 definite leak and many potential leaks with
2278         extensive use of RetainPtr and COMPtr.
2279         
2280         This should result in no change in behavior
2281
2282         * MarshallingHelpers.cpp: Add kIUnknownDictionaryValueCallBacks
2283         * MarshallingHelpers.h: Ditto
2284         
2285         * WebHistory.cpp:
2286         (createUserInfoFromArray):
2287         (createUserInfoFromHistoryItem):
2288         (releaseUserInfo):
2289         (WebHistory::WebHistory):
2290         (WebHistory::~WebHistory):
2291         (WebHistory::loadFromURL):
2292         (createHistoryListFromStream): Split of the Structured Exception
2293           Handling to a seperate function to cooperate with C++
2294         (WebHistory::loadHistoryGutsFromURL):
2295         (WebHistory::saveToURL):
2296         (WebHistory::saveHistoryGuts):
2297         (WebHistory::datesArray):
2298         (WebHistory::addItems):
2299         (WebHistory::removeItems):
2300         (WebHistory::removeAllItems):
2301         (WebHistory::orderedLastVisitedDays):
2302         (WebHistory::orderedItemsLastVisitedOnDay):
2303         (WebHistory::removeItem):
2304         (WebHistory::addItem):
2305         (WebHistory::addItemForURL):
2306         (WebHistory::itemForURLString):
2307         (WebHistory::itemForURL):
2308         (WebHistory::containsItemForURLString):
2309         (WebHistory::removeItemForURLString):
2310         (WebHistory::addItemToDateCaches):
2311         (WebHistory::removeItemFromDateCaches):
2312         (WebHistory::findIndex):
2313         (WebHistory::insertItem):
2314         (WebHistory::ageLimitDate):
2315         * WebHistory.h:
2316         
2317         * WebHistoryItem.cpp:
2318         (WebHistoryItem::dictionaryRepresentation):
2319         (WebHistoryItem::mergeAutoCompleteHints):
2320
2321 2007-03-25  Adam Roben  <aroben@apple.com>
2322
2323         Reviewed by Oliver.
2324
2325         WebKit part of <rdar://problem/5086934> DumpRenderTree doesn't support
2326         layoutTestController.queueLoad
2327
2328         * WebFrame.cpp:
2329         (WebFrame::findFrameNamed): Implemented.
2330         * WebHistoryItem.cpp:
2331         (WebHistoryItem::children): Don't increment i twice per loop!
2332
2333 2007-03-25  Adam Roben  <aroben@apple.com>
2334
2335         Build fix.
2336
2337         * WebDownload.h: Include RetainPtr from WTF.
2338
2339 2007-03-24  Steve Falkenburg  <sfalken@apple.com>
2340
2341         Build fix.
2342
2343         * WebDownload.h: Remove WebCore namespace
2344
2345 2007-03-24  Adam Roben  <aroben@apple.com>
2346
2347         Reviewed by Oliver.
2348
2349         WebKit part of <rdar://problem/5086932> DumpRenderTree doesn't support
2350         layoutTestController.dumpBackForwardList
2351
2352         * Interfaces/IWebHistoryItemPrivate.idl: Added declarations.
2353         * WebFrame.cpp:
2354         (WebFrame::childFrames): Removed unused variable.
2355         * WebHistoryItem.cpp:
2356         (WebHistoryItem::target): Implemented.
2357         (WebHistoryItem::isTargetItem): Implemented.
2358         (WebHistoryItem::children): Implemented.
2359         * WebHistoryItem.h: Added declarations.
2360
2361 2007-03-23  Brady Eidson  <beidson@apple.com>
2362
2363         Reviewed by Adam
2364         
2365         <rdar://5086194> - WebHistory overreleases a CFNumber
2366         
2367         * WebHistory.cpp:
2368         (WebHistory::loadHistoryGutsFromURL): Don't CFRelease what we didn't 
2369           legitimately get a ref for!
2370
2371 2007-03-23  Adam Roben  <aroben@apple.com>
2372
2373         Reviewed by Darin.
2374
2375         WebKit part of <rdar://problem/5084881> Add a "turn of site-specific
2376         hacks" menu item to the Debug menu
2377
2378         Added new IWebPrivate::setAllowSiteSpecificHacks SPI.
2379
2380         * Interfaces/IWebViewPrivate.idl: Added declaration.
2381         * WebView.cpp:
2382         (WebView::userAgentForKURL): Only give a site-specific UA if
2383         site-specific hacks are turned on.
2384         (WebView::setAllowSiteSpecificHacks): Added.
2385         * WebView.h:
2386         (WebView::allowSiteSpecificHacks): Added.
2387
2388 2007-03-23  Beth Dakin  <bdakin@apple.com>
2389
2390         Reviewed by Hyatt.
2391
2392         Fix for <rdar://problem/5083914> Cursor is wrong for all context 
2393         menus
2394
2395         * WebView.cpp:
2396         (WebView::handleContextMenuEvent): Set the cursor to the pointer 
2397         cursor.
2398
2399 2007-03-23  Alice Liu  <alice.liu@apple.com>
2400
2401         Reviewed by Adam.
2402
2403         Fixed <rdar://5084888> need to add flickr to spoof list in Boomer WebKit
2404
2405         * WebView.cpp:
2406         (WebView::userAgentForKURL):
2407         added flickr spoof
2408
2409 2007-03-23  Adam Roben  <aroben@apple.com>
2410
2411         Reviewed by Oliver.
2412
2413         WebKit part of <rdar://problem/5085170> DumpRenderTree doesn't print
2414         frame scroll offsets
2415
2416         Implemented some WebFrame methods to support dumping frame scroll
2417         offsets in DRT.
2418
2419         * Interfaces/IWebFrame.idl: Changed signature of IWebFrame::childFrames.
2420         * Interfaces/IWebFramePrivate.idl: Added scrollOffset declaration.
2421         * WebFrame.cpp:
2422         (WebFrame::name): Implemented.
2423         (WebFrame::childFrames): Implemented.
2424         (WebFrame::scrollOffset): Implemented.
2425         * WebFrame.h: Updated/added declarations.
2426
2427 2007-03-23  Adam Roben  <aroben@apple.com>
2428
2429         Reviewed by Oliver.
2430
2431         WebKit part of fix for <rdar://problem/4990740>.
2432
2433         Added IWebDataSourcePrivate::mainDocumentError.
2434
2435         * Interfaces/IWebDataSource.idl: Added method declaration and updated
2436         copyrights.
2437         * WebDataSource.cpp:
2438         (WebDataSource::mainDocumentError): Implemented.
2439         * WebDataSource.h: Added declaration.
2440
2441 2007-03-23  Steve Falkenburg  <sfalken@apple.com>
2442
2443         Reviewed by Adam.
2444         
2445         <rdar://problem/5083645> Spoofed UA for gmail doesn't work - should be removed
2446
2447         * WebView.cpp:
2448         (WebView::userAgentForKURL): Remove gmail spoof
2449
2450 2007-03-22  Dave Hyatt  <hyatt@apple.com>
2451
2452         Fix for <rdar://problem/5083072>.
2453
2454         Reviewed by aroben
2455   
2456         * ChangeLog:
2457         * WebFrame.cpp:
2458         (WebFrame::setPrinting):
2459         (WebFrame::spoolPages):
2460         * WebFrame.h:
2461
2462 2007-03-22  Anders Carlsson  <acarlsson@apple.com>
2463
2464         Reviewed by Maciej.
2465
2466         <rdar://problem/5082270>
2467         Crash in windows media player at MTV.COM
2468         
2469         Ignore any WM_PAINT events we get while painting.
2470         
2471         * WebView.cpp:
2472         (WebView::WebView):
2473         (WebView::updateBackingStore):
2474         (WebView::paint):
2475         (WebViewWndProc):
2476         * WebView.h:
2477         (WebView::isPainting):
2478
2479 2007-03-22  Adele Peterson  <adele@apple.com>
2480
2481         Reviewed by Anders.
2482
2483         Fix for <rdar://problem/5071358> window.open won't work with empty urls (24fun test)
2484
2485         * Interfaces/IWebURLRequest.idl:
2486         * WebMutableURLRequest.cpp: (WebMutableURLRequest::isEmpty): Added. Checks whether the ResourceRequest is empty.  On the mac,
2487           NSURLRequests created from empty ResourceRequests are nil.  We may want to consider that in the future, but there were too
2488           many places in the app that expected the IWebURLRequest to be non-null.
2489         * WebMutableURLRequest.h:
2490
2491 2007-03-22  Dave Hyatt  <hyatt@apple.com>
2492
2493         Fix for crasher in layout caused by paints that happen without layout being current.  Change to be
2494         more like the Mac and crawl the frame tree up front ensuring everyone is up to date before painting.
2495
2496         Reviewed by olliej
2497
2498         * WebFrame.cpp:
2499         (WebFrame::WebFramePrivate::m_policyFunction):
2500         (WebFrame::layoutIfNeededRecursive):
2501         * WebFrame.h:
2502         * WebView.cpp:
2503         (WebView::updateBackingStore):
2504         (WebView::paint):
2505         (WebViewWndProc):
2506
2507 2007-03-22  Ada Chan  <adachan@apple.com>
2508
2509         Reviewed by Hyatt and Alice.
2510         
2511         Changed the mouse event processing in the WebView wndproc so we actually
2512         allow a mouse event with click count > 3, which matches the mac safari behavior.
2513         
2514         Set globalPrevButton and globalPrevPoint also in mouse down.
2515
2516         * WebView.cpp:
2517         (WebView::handleMouseEvent):
2518
2519 2007-03-21  Anders Carlsson  <acarlsson@apple.com>
2520
2521         Reviewed by Adam.
2522
2523         * WebView.cpp:
2524         (WebView::initWithFrame):
2525         Remove #ifdef now that DRT no longer crashes.
2526
2527 2007-03-21  Beth Dakin  <bdakin@apple.com>
2528
2529         Reviewed by Adam.
2530
2531         <rdar://problem/5074274> right-clicking in certain iframes ends up 
2532         left-clicking, and context menu appears far away
2533
2534         * WebView.cpp:
2535         (WebView::handleContextMenuEvent): We were always calling 
2536         sendContextMenuEvent() on the main frame!! Instead, call it on the 
2537         focused or main frame.
2538
2539 2007-03-21  Adele Peterson  <adele@apple.com>
2540
2541         Reviewed by Adam.
2542         
2543         Fix for <rdar://problem/5076213> fast/forms/input-text-enter.html fails
2544         
2545         Added updateActiveState SPI for DumpRenderTree.
2546
2547         * Interfaces/IWebViewPrivate.idl:
2548         * WebView.cpp:
2549         (WebViewWndProc): Added comments where we do similar work when the webview gets and loses focus.  We should merge this logic into updateActiveState eventually.
2550         (WebView::updateActiveState):
2551         * WebView.h:
2552
2553 2007-03-19  Maciej Stachowiak  <mjs@apple.com>
2554
2555         Reviewed by Geoff and Adam.
2556
2557         - <rdar://problem/4041141> JavaScriptCore is not thread-safe on Windows
2558
2559         * WebView.cpp:
2560         (WebView::WebView): Tell JavaScriptCore what the main thread is.
2561
2562 2007-03-20  Anders Carlsson  <acarlsson@apple.com>
2563
2564         Reviewed by Adam.
2565
2566         <rdar://problem/5050512>
2567         Need invalid/expired certificate alerts
2568         
2569         Add setAllowsAnyHTTPSCertificate method to IWebMutableURLRequest and have it 
2570         call down to WebCore.
2571         
2572         * Interfaces/IWebMutableURLRequest.idl:
2573         * WebMutableURLRequest.cpp:
2574         (WebMutableURLRequest::setAllowsAnyHTTPSCertificate):
2575         * WebMutableURLRequest.h:
2576
2577 2007-03-20  Adam Roben  <aroben@apple.com>
2578
2579         Rubberstamped by Anders.
2580
2581         Workaround a CFNetwork crash that affects DRT.
2582
2583         * WebView.cpp:
2584         (WebView::initWithFrame): Commented out cookie storage initialization.
2585
2586 2007-03-20  Adam Roben  <aroben@apple.com>
2587
2588         Build fix.
2589
2590         * WebView.cpp: Added missing #include.
2591
2592 2007-03-20  Adam Roben  <aroben@apple.com>
2593
2594         Reviewed by Oliver.
2595
2596         Implemented [set]TabKeyCyclesThroughElements.
2597
2598         * Interfaces/IWebViewPrivate.idl: Added new declarations.
2599         * WebView.cpp:
2600         (WebView::setTabKeyCyclesThroughElements): Implemented.
2601         (WebView::tabKeyCyclesThroughElements): Implemented.
2602         * WebView.h: Updated.
2603
2604 2007-03-20  Dave Hyatt  <hyatt@apple.com>
2605
2606         Land advanced text code path (turned off).
2607        
2608         Reviewed by aroben
2609
2610         * WebKit.vcproj/WebKit.vcproj:
2611
2612 2007-03-20  Anders Carlsson  <acarlsson@apple.com>
2613
2614         Reviewed by Adam.
2615
2616         <rdar://problem/4921198>
2617         Cookie acceptance policy not settable
2618         
2619         * WebView.cpp:
2620         (WebView::updateWebCoreSettingsFromPreferences):
2621         Update the cookie storage accept policy.
2622         
2623         (WebView::initWithFrame):
2624         Initialize the cookie storage.
2625
2626 2007-03-19  Adam Roben  <aroben@apple.com>
2627
2628         Build fix.
2629
2630         * WebKit.vcproj/WebKitGUID.vcproj:
2631
2632 2007-03-19  Adam Roben  <aroben@apple.com>
2633
2634         Reviewed by Anders and Darin.
2635
2636         Added WebJavaScriptCollector for <rdar://problems/5071653>.
2637
2638         * Interfaces/IWebJavaScriptCollector.idl: Added.
2639         * Interfaces/WebKit.idl:
2640         * WebJavaScriptCollector.cpp: Added.
2641         (WebJavaScriptCollector::WebJavaScriptCollector):
2642         (WebJavaScriptCollector::~WebJavaScriptCollector):
2643         (WebJavaScriptCollector::createInstance):
2644         (WebJavaScriptCollector::QueryInterface):
2645         (WebJavaScriptCollector::AddRef):
2646         (WebJavaScriptCollector::Release):
2647         (WebJavaScriptCollector::collect):
2648         (WebJavaScriptCollector::collectOnAlternateThread):
2649         (WebJavaScriptCollector::objectCount):
2650         * WebJavaScriptCollector.h: Added.
2651         * WebKit.vcproj/Interfaces.vcproj: Added IWebJavaScriptCollector.idl.
2652         * WebKit.vcproj/WebKit.vcproj: Added WebJavaScriptCollector.(cpp|h).
2653         * WebKit.vcproj/WebKitGUID.vcproj: Added IWebJavaScriptCollector_i.c.
2654         * WebKitClassFactory.cpp:
2655         (WebKitClassFactory::CreateInstance): Added cases for
2656         WebJavaScriptCollector.
2657         * WebKitDLL.cpp:
2658         (DllGetClassObject): Ditto.
2659
2660 2007-03-19  Adam Roben  <aroben@apple.com>
2661
2662         Build fix.
2663
2664         * Interfaces/IWebView.idl:
2665
2666 2007-03-18  Adam Roben  <aroben@apple.com>
2667
2668         Reviewed by Hyatt.
2669
2670         Implemented getting/setting of the editing delegate (we don't actually
2671         use it for anything yet, though. See <rdar://problem/5071598>).
2672
2673         * Interfaces/IWebEditingDelegate.idl: Renamed IWebViewEditingDelegate
2674         to IWebEditingDelegate to match our other delegates.
2675         * Interfaces/IWebView.idl: Updated for rename.
2676         * WebView.cpp:
2677         (WebView::setEditingDelegate): Implemented.
2678         (WebView::editingDelegate): Ditto.
2679         * WebView.h: Updated for rename.
2680
2681 2007-03-18  Adam Roben  <aroben@apple.com>
2682
2683         Reviewed by Geoff.
2684
2685         Added IWebFramePrivate::layout to support eventSender in DRT.
2686
2687         Made IWebView inherit from IDropTarget to match Mac, and added
2688         IWebUIDelegatePrivate::doDragDrop to support drag-and-drop in DRT.
2689
2690         * Interfaces/IWebFramePrivate.idl: Added layout().
2691         * Interfaces/IWebUIDelegatePrivate.idl: Added doDragDrop().
2692         * Interfaces/IWebView.idl: Added inheritance from IDropTarget.
2693         * WebDragClient.cpp:
2694         (WebDragClient::startDrag): Call the UI delegate if possible,
2695         otherwise fallback to OLE's DoDragDrop.
2696         * WebFrame.cpp:
2697         (WebFrame::layout): Implemented.
2698         * WebFrame.h:
2699         * WebView.h:
2700
2701 2007-03-17  Adam Roben  <aroben@apple.com>
2702
2703         Reviewed by Brady.
2704
2705         Fix repro ASSERT when logging in to facebook.com.
2706
2707         * WebMutableURLRequest.cpp:
2708         (WebMutableURLRequest::valueForHTTPHeaderField): Implemented.
2709
2710 2007-03-16  Brady Eidson  <beidson@apple.com>
2711
2712         Reviewed by Oliver
2713
2714         Make the WebDownload fix a little more correct.
2715         
2716         * WebDownload.cpp:
2717         (WebDownload::init): Release the connection from the ResourceHandle after the CFURLDownload has been created
2718
2719 2007-03-16  Geoffrey Garen  <ggaren@apple.com>
2720
2721         Reviewed by Dave Hyatt.
2722         
2723         Fixed "called Frame::paint with nil renderer" console messages.
2724         You can now launch and exit the app without seeing any
2725         error messages!
2726
2727         * WebView.cpp:
2728         (WebView::paintIntoBackingStore): Only tell the FrameView to
2729         paint if it has a renderer. This isn't an issue on the Mac
2730         because we don't create a FrameView until you load a page.
2731
2732 2007-03-16  Anders Carlsson  <acarlsson@apple.com>
2733
2734         Reviewed by Adam.
2735
2736         Add setters and getters for cookie storage accept policy.
2737         
2738         * Interfaces/IWebPreferences.idl:
2739         * WebPreferenceKeysPrivate.h:
2740         * WebPreferences.cpp:
2741         (WebPreferences::initialize):
2742         (WebPreferences::cookieStorageAcceptPolicy):
2743         (WebPreferences::setCookieStorageAcceptPolicy):
2744         * WebPreferences.h:
2745
2746 2007-03-16  Anders Carlsson  <acarlsson@apple.com>
2747
2748         Reviewed by Adam and Dave Hyatt.
2749
2750         <rdar://problem/5069226>
2751         Boomer fails Acid2.
2752         
2753         Fix acid2 test.
2754         
2755         * WebFrame.cpp:
2756         (WebFrame::shouldFallBack):
2757         Implement this function.
2758
2759 2007-03-16  Ada Chan  <adachan@apple.com>
2760
2761         Reviewed by Steve.
2762         
2763         Implemented a couple of DOM methods so we can set the font-size of an element directly in the app.
2764
2765         * DOMCSSClasses.cpp:
2766         (DOMCSSStyleDeclaration::setProperty):
2767         * DOMCoreClasses.cpp:
2768         (DOMElement::style):
2769
2770 2007-03-15  Alice Liu  <alice.liu@apple.com>
2771
2772         Reviewed by Ada.
2773
2774         Fixing some leaks
2775
2776         * WebFrame.cpp:
2777         (WebFrame::dispatchDidReceiveAuthenticationChallenge):
2778         (WebFrame::dispatchDidCancelAuthenticationChallenge):
2779
2780 2007-03-15  Brady Eidson  <beidson@apple.com>
2781
2782         Reviewed by Oliver
2783
2784         CFNetwork related cleanup that was a work around for previous deficiencies in CFURLDownload
2785         This might fix some of the random crashers we see on stress testing if they end up 
2786         downloading links.
2787
2788         * WebDownload.cpp:
2789         (WebDownload::init): Release the connection from the handle so it no longer refers to it
2790         
2791 2007-03-15  Maciej Stachowiak  <mjs@apple.com>
2792
2793         Reviewed by Geoff and Steve.
2794         
2795         - fixed <rdar://problem/5029776> iBench JavaScript test slower than Opera
2796         - fixes to use FastMalloc on Windows
2797
2798         * WebKit.vcproj/WebKit.def: Add exports of WTF symbols.
2799         * WebKit.vcproj/WebKit_debug.def: ditto
2800         * WebKit.vcproj/WebKit.vcproj: Link pthreads, now needed by WTF.
2801
2802 2007-03-15  Brady Eidson  <beidson@apple.com>
2803
2804         Reviewed by Alice
2805         
2806         Due to OpenSource r20178, all of the sudden we were trying to handle page caching on Windows
2807         even though it is not hooked up yet.  The resulted in very particular cases ending up calling 
2808         clear() in FrameLoader::provisionalLoadStarted().  One such particular case was if a page *would*
2809         be "cachable" (no frames, no passwords, etc etc), and you start a download from that page.
2810         
2811         The fix for now is to manually set the pageCacheSize to 0 whenever we create new pages on Windows.
2812         This prevents the "Should I cache this page?" checking from getting far enough to clear the document.
2813         It so happens this involves exactly one line.
2814         
2815         * WebView.cpp:
2816         (WebView::initWithFrame): Set page cache size to zero on new pages, and add a fixme to remove later
2817
2818 2007-03-15  Brady Eidson  <beidson@apple.com>
2819
2820         Reviewed by Maciej
2821
2822         <rdar://problem/4429701>
2823         Implements a port blocking black list that matches Firefox's
2824         
2825         * Interfaces/IWebError.idl: Add the custom error code for blocked error
2826
2827         * WebFrame.cpp:
2828         (WebFrame::blockedError): FrameLoaderClient fill-in + a Fixme
2829         (WebFrame::interruptForPolicyChangeError): Add a Fixme for localization
2830         * WebFrame.h:
2831
2832 2007-03-15  Adam Roben  <aroben@apple.com>
2833
2834         Rubberstamped by Brady.
2835
2836         * WebKitLogging.cpp: Turn of Download logging by default.
2837
2838 2007-03-14  Ada Chan  <adachan@apple.com>
2839
2840         Reviewed by Lou.
2841
2842         Added a method in IWebViewPrivate to clear the current focus node.  This is called in the app
2843         when focus has been transferred to the address field or search field.
2844
2845         * Interfaces/IWebViewPrivate.idl:
2846         * WebView.cpp:
2847         (WebView::clearFocusNode):
2848         * WebView.h:
2849
2850 2007-03-14  Adele Peterson  <adele@apple.com>
2851
2852         Reviewed by Ada.
2853
2854         Allow empty commands to be sent by doTextFieldCommandFromEvent.  Our autocomplete code relies on this.
2855
2856         * WebEditorClient.cpp: (WebEditorClient::doTextFieldCommandFromEvent):
2857
2858 2007-03-14  Steve Falkenburg  <sfalken@apple.com>
2859
2860         <rdar://problem/5050470> Reproducible crash doing find on page at cnn.com
2861         
2862         Add frame->document() null checks in cases where frame could be a
2863         sub-frame that hasn't started loading yet.
2864
2865         * WebView.cpp:
2866         (WebView::rectsForTextMatches): Add null check
2867
2868 2007-03-14  Adele Peterson  <adele@apple.com>
2869
2870         Reviewed by Darin.
2871
2872         WebKit part of fix for <rdar://problem/5057371> REGRESSION: Shift-selection stopped working in text fields
2873
2874         This fixes doCommandBySelector to take a command string instead of a key code.
2875
2876         * Interfaces/IWebEditingDelegate.idl: Changed parameter to BSTR.
2877         * Interfaces/IWebFormDelegate.idl: ditto.
2878         * WebEditorClient.cpp:
2879         (WebEditorClient::doTextFieldCommandFromEvent): Calls doCommandBySelector with a BString that it gets from interpretKeyEvent instead of a key code.
2880         (WebEditorClient::textWillBeDeletedInTextField): Calls doCommandBySelector with a BString to represent the BackwardDelete command.
2881         (WebEditorClient::handleKeypress): Calls handleEditingKeyboardEvent with just the KeyboardEvent.
2882         * WebView.cpp: Added commands that will be used by doCommandBySelector to the table (Cancel, InsertTab, InsertBacktab, InsertNewline).
2883         (WebView::interpretKeyEvent): Added. Returns a command string for a KeyboardEvent. Removed static editCommandForKey.
2884         (WebView::handleEditingKeyboardEvent): Call Editor methods instead of calling handleTextInputEvent directly.
2885         * WebView.h:
2886
2887 2007-03-14  Administrator  <acarlsson@apple.com>
2888
2889         Build fixes.
2890         
2891         * WebDataSource.cpp:
2892         (WebDataSource::subresourceForURL):
2893         * WebKitDLL.cpp:
2894         (loadResourceIntoBuffer):
2895
2896 2007-03-12  Adele Peterson  <adele@apple.com>
2897
2898         Reviewed by Oliver.
2899
2900         WebKit part of fix for <rdar://problem/5044790> preventing default of keypress event doesn't work (affects .mac)
2901
2902         Removed special handling of the WM_CHAR message.  All this work is now done by WM_KEYDOWN, which will dispatch the keydown event, 
2903         which causes the keypress event to be dispatched, which calls WebEditorClient::handleKeyPress to do all the hard work.
2904         
2905         * WebEditorClient.cpp: (WebEditorClient::handleKeypress): Removed special call to doTextFieldCommandFromEvent since this will now 
2906         happen during normal key event processing. Call handleEditingKeyboardEvent.  Now editing actions can be prevented from the keypress event handler.
2907         * WebView.cpp:
2908         (WebView::WebView): Added m_currentCharacterCode, so we can reuse the computed code from keyDown for keyUp events.
2909         (WebView::keyUp): Renamed arguments.  Don't dispatch event for shift, ctrl, or capslock keys. Use m_currentCharacterCode when constructing the PlatformKeyboardEvent.
2910         (WebView::handleEditingKeyboardEvent): Now takes a KeyboardEvent instead of a PlatformKeyboardEvent.  If no editCommand is created
2911          from the event, then call handleTextInputEvent.
2912         (WebView::keyDown): Peek at the next message in the message loop.  If its a WM_CHAR, then get the character code and remove that message from the queue.
2913          Renamed arguments.  Don't dispatch event for shift, ctrl, or capslock keys. Set m_currentCharacterCode and use it when constructing the PlatformKeyboardEvent.
2914         (WebViewWndProc):  Removed handling of WM_CHAR, since this is now done from WM_KEYDOWN by dispatching the keydown event, which will eventually call handleKeyPress.
2915         * WebView.h: Made handleEditingKeyboardEvent public so it can be accessed from WebEditorClient.
2916
2917 2007-03-11  Oliver Hunt  <oliver@apple.com>
2918
2919         Reviewed by Adele.
2920
2921         Stubbed WebEditorClient::respondToChangedSelection
2922
2923         * WebEditorClient.cpp:
2924         (WebEditorClient::respondToChangedSelection):
2925         * WebEditorClient.h:
2926
2927 2007-03-10  Anders Carlsson <acarlsson@apple.com>
2928
2929         Reviewed by Adam.
2930
2931         * DOMCoreClasses.cpp:
2932         (DOMNode::textContent):
2933         Implement this.
2934
2935 2007-03-09  Anders Carlsson <acarlsson@apple.com>
2936
2937         Reviewed by Adam.
2938
2939         * WebURLResponse.cpp:
2940         (WebURLResponse::suggestedFilename):
2941         Get the suggested filename from the ResourceResponse object.
2942
2943 2007-03-09  Adam Roben  <aroben@apple.com>
2944
2945         Rubberstamped by Steve.
2946
2947         B&I build fix.
2948
2949         * WebKit.vcproj/WebKit.vcproj: Removed all references to iconv.
2950
2951 2007-03-08  Anders Carlsson <acarlsson@apple.com>
2952
2953         Build fix.
2954         
2955         * WebView.cpp:
2956         (WebView::isLoading):
2957
2958 2007-03-08  Anders Carlsson <acarlsson@apple.com>
2959
2960         Reviewed by Adam.
2961
2962         Implement WebView::isLoading.
2963         
2964         * WebView.cpp:
2965         (WebView::isLoading):
2966
2967 2007-03-07  Adam Roben  <aroben@apple.com>
2968
2969         Rubberstamped by Anders.
2970
2971         Return E_POINTER for null parameters.
2972
2973         * WebScrollBar.cpp:
2974         (WebScrollBar::value):
2975         (WebScrollBar::capturingMouse):
2976         (WebScrollBar::frameGeometry):
2977         (WebScrollBar::width):
2978         (WebScrollBar::height):
2979         (WebScrollBar::requestedWidth):
2980         (WebScrollBar::requestedHeight):
2981         (WebScrollBar::windowClipRect):
2982
2983 2007-03-07  Adam Roben  <aroben@apple.com>
2984
2985         Reviewed by Oliver.
2986
2987         Added requestedWidth and requestedHeight methods to WebScrollBar.
2988
2989         * Interfaces/IWebScrollBarPrivate.idl: Added new declarations.
2990         * WebScrollBar.cpp:
2991         (WebScrollBar::requestedWidth): Implemented.
2992         (WebScrollBar::requestedHeight): Implemented.
2993         * WebScrollBar.h: Added method declarations.
2994
2995 2007-03-07  Adam Roben  <aroben@apple.com>
2996
2997         Rubberstamped by Anders.
2998
2999         * WebFrame.cpp:
3000         (WebFrame::cancelledError): Use the WebURLErrorDomain constant.
3001         (WebFrame::interruptForPolicyChangeError): Use the WebKitErrorDomain constant.
3002
3003 2007-03-07  Adam Roben  <aroben@apple.com>
3004
3005         Rubberstamped by Anders.
3006
3007         Switch the definition of WebURLErrorDomain to "CFURLErrorDomain" so
3008         that we will send the right errors once <rdar://problem/5034136> is
3009         fixed.
3010
3011         * Interfaces/IWebError.idl: Changed definition.
3012
3013 2007-03-07  Adele Peterson  <adele@apple.com>
3014
3015         Build fix.
3016
3017         * WebEditorClient.cpp: (WebEditorClient::handleInputMethodKeypress):
3018
3019 2007-03-07  Adele Peterson  <adele@apple.com>
3020
3021         Reviewed by Darin.
3022
3023         WebKitWin part of fix for:
3024         http://bugs.webkit.org/show_bug.cgi?id=10871
3025         http://bugs.webkit.org/show_bug.cgi?id=12677
3026         <rdar://problem/4823129> REGRESSION: IME key events different in nightly
3027         <rdar://problem/4759563> REGRESSION: Return key is always sent when you confirm a clause in kotoeri
3028
3029         * WebEditorClient.cpp:
3030         (WebEditorClient::handleKeypress): Changed handleKeyPress to handleKeypress.
3031         (WebEditorClient::handleInputMethodKeypress): Added.
3032         * WebEditorClient.h:
3033
3034 2007-03-07  Anders Carlsson  <acarlsson@apple.com>
3035
3036         Reviewed by Adam.
3037
3038         * WebFrame.cpp:
3039         (WebFrame::makeDocumentView):
3040         Assert that frame is not null.
3041
3042 2007-03-06  Anders Carlsson  <acarlsson@apple.com>
3043
3044         Reviewed by Adam.
3045
3046         * WebFrame.cpp:
3047         (WebFrame::makeDocumentView):
3048         Call resetMultipleFormSubmissionProtection() so that submitting the same form from separate loads works.
3049
3050 2007-03-06  Brady Eidson  <beidson@apple.com>
3051
3052         Reviewed by Adam
3053
3054         Adapt to an API change in CFURLDownload
3055         
3056         * WebDownload.cpp:
3057         (WebDownload::init):
3058
3059 2007-03-06  Steve Falkenburg  <sfalken@apple.com>
3060
3061         Rubber-stamped by Adam.
3062         
3063         Fix disney.com more.  Disney redirects to disney.go.com.
3064
3065         * WebView.cpp:
3066         (WebView::userAgentForKURL): Added disney.go.com
3067
3068 2007-03-06  Adam Roben  <aroben@apple.com>
3069
3070         Reviewed by Anders.
3071
3072         Always keep rounding hacks on to be consistent.
3073
3074         * WebDragClient.cpp:
3075         (createDragImageForLink): Tell StringTruncator to keep rounding hacks on.
3076         * WebKitGraphics.cpp:
3077         (CenterTruncateStringToWidth): Ditto.
3078         (RightTruncateStringToWidth): Ditto.
3079
3080 2007-03-06  Steve Falkenburg  <sfalken@apple.com>
3081
3082         Reviewed by Adam.
3083         
3084         Allow custom user agents per site.
3085         
3086         This fixes:
3087         
3088         http://www.disney.com
3089         http://www.yahoo.com
3090         http://mail.google.com
3091         iTunes store links (w/ latest unsubmitted CFNetwork from our root share)
3092
3093         * WebView.cpp:
3094         (WebView::userAgentForKURL): Check URL host against a list of known offenders, return them what they're looking for.
3095
3096 2007-03-06  Anders Carlsson  <acarlsson@apple.com>
3097
3098         Reviewed by Adam.
3099         
3100         Pass the user agent on.
3101         
3102         * WebFrame.cpp:
3103         (WebFrame::userAgent):
3104         * WebFrame.h:
3105
3106 2007-03-04  Adam Roben  <aroben@apple.com>
3107
3108         Reviewed by Steve.
3109
3110         Added line spacing querying to FontMetrics to support line wrapping.
3111
3112         * WebKitGraphics.cpp:
3113         (FontMetrics): Return the line spacing.
3114         * WebKitGraphics.h: Added lineSpacing parameter.
3115
3116 2007-03-02  Adam Roben  <aroben@apple.com>
3117
3118         Reviewed by Beth.
3119
3120         Make submenus draw using the UIDelegate.
3121
3122         * Interfaces/IWebUIDelegate.idl: Added new delegate method to add
3123         custom drawing data for menus.
3124         * WebView.cpp:
3125         (WebView::onInitMenuPopup): Added. Calls new delegate method.
3126         (WebViewWndProc): Added handler for WM_INITMENUPOPUP, which is called
3127         for all submenus.
3128         * WebView.h: Added declaration.
3129
3130 2007-03-02  Adam Roben  <aroben@apple.com>
3131
3132         Reviewed by Anders.
3133
3134         Added optional underlining of a single character to WebKitGraphics.
3135
3136         * WebKitGraphics.cpp:
3137         (DrawTextAtPoint): Passed optional underlinedIndex parameter to
3138         WebCoreTextRenderer.
3139         * WebKitGraphics.h: Added optional underlinedIndex parameter.
3140
3141 2007-03-01  Adam Roben  <aroben@apple.com>
3142
3143         Reviewed by Kevin M.
3144
3145         Add support for right-truncation to WebKitGraphics.
3146
3147         * WebKit.vcproj/WebKit.def: Added new export.
3148         * WebKit.vcproj/WebKit_debug.def: Ditto.
3149         * WebKitGraphics.cpp:
3150         (RightTruncateStringToWidth): Added.
3151         * WebKitGraphics.h: Added declaration.
3152
3153 2007-02-28  Adam Roben  <aroben@apple.com>
3154
3155         Reviewed by Anders.
3156
3157         Made WebKitGraphics more flexible.
3158
3159         * WebDragClient.cpp:
3160         (WebDragClient::createDragImageForLink): Updated for changes to
3161         WebKitGraphics/WebCoreTextRenderer.
3162         * WebKit.vcproj/WebKit.def: Added new exported methods.
3163         * WebKit.vcproj/WebKit_debug.def: Ditto.
3164         * WebKitGraphics.cpp:
3165         (makeFont): Added.
3166         (DrawTextAtPoint): Simplified arguments, changed to take a
3167         CGContextRef, and updated for WebCoreTextRenderer changes.
3168         (TextFloatWidth): Added.
3169         (FontMetrics): Added.
3170         (CenterTruncateStringToWidth): Added.
3171         * WebKitGraphics.h: Updated declarations.
3172
3173 2007-02-28  Steve Falkenburg  <sfalken@apple.com>
3174
3175         Fix build (for new SDK) / Break build (for old SDK)
3176
3177         * WebDownload.cpp:
3178         (WebDownload::initToResumeWithBundle):
3179
3180 2007-02-27  Ada Chan  <adachan@apple.com>
3181
3182         Reviewed by Steve and Adam.
3183         
3184         WebKitWin changes to get the aqua scrollbar into the app.
3185
3186         * Interfaces/IWebScrollBarDelegatePrivate.idl: Added.
3187         COM interface for the WebKit scrollbar
3188         * Interfaces/IWebScrollBarPrivate.idl: Added.
3189         COM interface that allows the WebKit scrollbar to update the client.
3190         * Interfaces/WebKit.idl:
3191         * WebKit.vcproj/Interfaces.vcproj:
3192         * WebKit.vcproj/WebKit.vcproj:
3193         * WebKit.vcproj/WebKitGUID.vcproj:
3194         * WebKitClassFactory.cpp:
3195         (WebKitClassFactory::CreateInstance):
3196         Added changes needed to create the WebKitScrollBar through COM
3197         * WebKitDLL.cpp:
3198         (DllGetClassObject):
3199         * WebScrollBar.cpp: Added.
3200         WebKitScrollBar wraps the WebCore's PlatformScrollbar.  This allows the app to
3201         make its own scroll bar that's the same aqua scrollbar in the engine.
3202         (WebScrollBar::WebScrollBar):
3203         (WebScrollBar::~WebScrollBar):
3204         (WebScrollBar::createInstance):
3205         (WebScrollBar::QueryInterface):
3206         (WebScrollBar::AddRef):
3207         (WebScrollBar::Release):
3208         (WebScrollBar::init): instantiate PlatformScrollbar.
3209         (WebScrollBar::setEnabled): call through to PlatformScrollbar
3210         (WebScrollBar::setSteps): ditto
3211         (WebScrollBar::setProportion): ditto
3212         (WebScrollBar::setRect): ditto
3213         (WebScrollBar::setValue): ditto
3214         (WebScrollBar::value): ditto
3215         (WebScrollBar::capturingMouse): ditto
3216         (WebScrollBar::paint): ditto
3217         (WebScrollBar::frameGeometry): ditto
3218         (WebScrollBar::width): ditto
3219         (WebScrollBar::height): ditto
3220         (WebScrollBar::handleMouseEvent): ditto
3221         (WebScrollBar::scroll): ditto
3222         (WebScrollBar::valueChanged): call valueChanged on the delegate
3223         (WebScrollBar::windowClipRect): get the rect from the scrollbar's containing window
3224         * WebScrollBar.h: Added.
3225
3226 2007-02-27  Alice Liu  <alice.liu@apple.com>
3227
3228         Reviewed by Steve, Adam, Maciej, and their mothers.
3229
3230         This is a general leaks fix but helps the effort towards fixing
3231         <rdar://4974495> Boomer leaks while running HTML iBench
3232         However, this fix doens't close that bug. 
3233
3234         * WebFrame.cpp:
3235         (WebFrame::setTitle):
3236             fix a leak of WebHistory
3237         * WebHistory.cpp:
3238         (_WebCoreHistoryProvider::containsItemForURLUnicode):
3239             fix a leak of WebHistory
3240
3241 2007-02-27  Adam Roben  <aroben@apple.com>
3242
3243         Reviewed by Anders.
3244
3245         Fix <rdar://problem/5004615> View source menu option is always disabled
3246         when Netscape 8 is installed
3247
3248         The bug was caused by Netscape's npTrident.dll plugin, which registers
3249         itself as a handler for text/html and text/xml.
3250
3251         * WebFrame.cpp:
3252         (WebFrame::canProvideDocumentSource): Explicitly allow viewing the
3253         source of HTML and XML documents, rather than disallowing text, image,
3254         and plugin documents. Plugins can register themselves as handlers for
3255         HTML and XML MIME types, but we still want to display source in those
3256         cases.
3257
3258 2007-02-27  Beth Dakin  <bdakin@apple.com>
3259
3260         Reviewed by Adam.
3261
3262         Make msimg32.lib available to the engine so that we can use 
3263         AlphaBlend.
3264
3265         * WebKit.vcproj/WebKit.vcproj:
3266
3267 2007-02-27  Ada Chan  <adachan@apple.com>
3268
3269         Fixed build.
3270
3271         * WebFrame.cpp:
3272
3273 2007-02-27  Oliver Hunt  <oliver@apple.com>
3274
3275         Reviewed by Lou and Steve.
3276         
3277         Handle the WM_CURSOR message to stop cursor flickering
3278         to fix <rdar://problem/4788352>
3279
3280         * WebView.cpp:
3281         (WebViewWndProc):
3282
3283 2007-02-27  Ada Chan  <adachan@apple.com>
3284
3285         Reviewed by Steve and Anders.
3286
3287         <rdar://4983106> Stop/reload button never changes back to
3288         reload when a click on a link spawns a download
3289
3290         * WebError.cpp:
3291         (WebError::isPolicyChangeError): fixed string comparison
3292         * WebFrame.cpp:
3293         (WebFrame::interruptForPolicyChangeError): implemented the method
3294
3295 2007-02-26  Adam Roben  <aroben@apple.com>
3296
3297         Reviewed by Adele.
3298
3299         Stop bizarre crashes from happening on startup.
3300
3301         * WebKit.vcproj/WebKit.vcproj: Use new ENABLE_* macros instead of *_SUPPORT.
3302
3303 2007-02-24  Steve Falkenburg  <sfalken@apple.com>
3304
3305         Pre-emptive build fix.
3306         Removed CGPThreads DLL copy
3307
3308         * WebKit.vcproj/WebKit.vcproj:
3309
3310 2007-02-22  Adele Peterson  <adele@apple.com>
3311
3312         Updating this file to match WebCore.
3313
3314         * WebKit.vcproj/textAreaResizeCorner.png:
3315
3316 2007-02-22  Beth Dakin  <bdakin@apple.com>
3317
3318         Reviewed by Adam.
3319
3320         Fix for http://bugs.webkit.org/show_bug.cgi?id=12399 REGRESSION: 
3321         Unable to prevent default context menu from appearing. <rdar://
3322         problem/5017416>
3323
3324         * WebView.cpp:
3325         (WebView::handleContextMenuEvent): Clear the controller's context 
3326         menu before propagating a new context menu event through the DOM.
3327
3328 2007-02-22  Oliver Hunt  <oliver@apple.com>
3329
3330         Reviewed by Ada, Lou, and Steve.
3331
3332         Last of the major changes for drag and drop
3333         - Move COMPtr.h to WebCore
3334         - Added WebDragSource, a modified version of SDataSource from the App
3335           that can notify a WebView's eventhandler of drag events
3336         - Implement the last bits of the DragClient
3337         - As part of drag client added code to draw the "doubled" text used by
3338           drag links.  May be useful for other parts of WebKit/App
3339         
3340         * COMPtr.h: Removed.
3341           Moving to WebCore
3342         * WebDragClient.cpp:
3343         (WebDragClient::actionMaskForDrag):
3344         (WebDragClient::willPerformDragDestinationAction):
3345         (WebDragClient::dragSourceActionMaskForPoint):
3346         (WebDragClient::willPerformDragSourceAction):
3347           Removing WebCore:: as i'm now using the WebCore namespace
3348         (WebDragClient::startDrag):
3349           Implemented client method
3350         (allocImage):
3351         (dragLabelFont):
3352           Helper functions for generating the link dragging image
3353         (WebDragClient::createDragImageForLink):
3354           Implemented client method
3355           
3356         * WebDropSource.cpp: Added.
3357         (WebDropSource::createInstance):
3358         (WebDropSource::WebDropSource):
3359         (WebDropSource::QueryInterface):
3360         (WebDropSource::AddRef):
3361         (WebDropSource::Release):
3362         (generateMouseEvent):
3363           Generates a mouse event for the EventHandler
3364         (WebDropSource::QueryContinueDrag):
3365         (WebDropSource::GiveFeedback):
3366           Copied from SDataObject in the App.  Minor changes per suggestions
3367           from Ada and Steve (error codes, potential leaks)
3368           Also includes logic to notify the source WebView of drag events (moving 
3369           and drag end)
3370           
3371         * WebDropSource.h: Added.
3372           Header for the above
3373           
3374         * WebKit.vcproj/WebKit.vcproj:
3375           Removing COMPtr.h, and adding WebDropSource.{h,cpp}
3376           
3377         * WebKitGraphics.cpp:
3378         (DrawDoubledTextAtPoint):
3379           Utility function for drawing double text, as used by link dragging image
3380           
3381         * WebKitGraphics.h:
3382           Defining the above function
3383
3384 2007-02-21  Brady Eidson  <beidson@apple.com>
3385
3386         Reviewed by the build-fix fairies
3387
3388         * WebDownload.cpp:
3389         (WebDownload::initToResumeWithBundle): Conditionally use CFURLDownload API for the resume case.
3390          I totally made up the flag
3391
3392 2007-02-21  Brady Eidson  <beidson@apple.com>
3393
3394         Reviewed by Anders' rubberstamp
3395         
3396         * WebDownload.cpp:
3397         (WebDownload::initToResumeWithBundle): Make a copy of the string we truncate
3398          so it doesn't affect the original
3399
3400 2007-02-21  Brady Eidson  <beidson@apple.com>
3401
3402         Reviewed by Adam
3403
3404         <rdar://problem/4964763> - Hookup resume downloads on the engine side
3405         
3406         NOTE: Resume downloads are broken in the current ChickenCat - this functionality requires 
3407         a custom ToT CFNetwork as of CFNetwork r3372, or will require CFNetwork 172 or later
3408         
3409         * WebDownload.cpp:
3410         (WebDownload::initWithRequest): Changed some logging, plugged some potential leaks
3411         (WebDownload::initToResumeWithBundle): Added a real implementation - this now works!
3412         (WebDownload::didFinish): Added some logging and fixed up some lifetime issues
3413         (extractResumeDataFromBundle): Renamed to imply the modification of the file.  Truncate
3414           the resume data from the file once it is extracted
3415
3416 2007-02-20  Beth Dakin  <bdakin@apple.com>
3417
3418         Reviewed by Maciej.
3419
3420         Move copyImage functionality from the ContextMenuClient to the 
3421         Pasteboard.
3422
3423         * WebContextMenuClient.cpp:
3424         * WebContextMenuClient.h:
3425
3426 2007-02-20  Adam Roben  <aroben@apple.com>
3427
3428         Reviewed by Darin and Anders.
3429
3430         Fix <rdar://problem/5003318> App: Status bar text is more difficult to
3431         read than Mac OS X Safari
3432
3433         * WebKitGraphics.cpp:
3434         (DrawTextAtPoint): Added bottomAlign and centerTruncate parameters.
3435         * WebKitGraphics.h: Ditto.
3436
3437 2007-02-20  Darin Adler  <darin@apple.com>
3438
3439         Reviewed by Anders.
3440
3441         * WebFrame.cpp: (WebFrame::redirectDataToPlugin): Update for changes to
3442         FrameLoader and DocumentLoader.
3443
3444 2007-02-19  Adam Roben  <aroben@apple.com>
3445
3446         Reviewed by Darin.
3447
3448         Fix <rdar://problem/5007566> Crash in WebFrame::dataSource on dni.ru
3449
3450         The fix for the bug was to zero out WebFrame's Frame pointer in
3451         WebFrame::frameLoaderDestroyed, and then to null-check or ASSERT
3452         non-null as appropriate. All IWebFrame methods that depend on the Frame
3453         pointer will return E_FAIL if it is null, and everywhere within
3454         WebFrame that wasn't null-checking before will now explicitly ASSERT.
3455
3456         I also changed all uses of d->frame and WebFrame::impl() to use the
3457         core() function for consistency, and so that there is only one code
3458         path for getting from a WebFrame to a Frame.
3459
3460         Additional more specific comments below.
3461
3462         * WebChromeClient.cpp:
3463         (WebChromeClient::scrollBackingStore):
3464         (WebChromeClient::updateBackingStore):
3465         * WebFrame.cpp:
3466         (kit): Null-check the frame parameter.
3467         (core): Added two overloads of this.
3468         (WebFrame::DOMDocument): Added argument checking.
3469         (WebFrame::currentForm):
3470         (WebFrame::loadRequest):
3471         (WebFrame::loadData):
3472         (WebFrame::dataSource): Added argument checking, and return E_FAIL if the dataSource is null.
3473         (WebFrame::provisionalDataSource): Ditto.
3474         (WebFrame::stopLoading):
3475         (WebFrame::reload):
3476         (WebFrame::parentFrame):
3477         (WebFrame::renderTreeAsExternalRepresentation): Added argument checking.
3478         (WebFrame::firstLayoutDone): Ditto.
3479         (WebFrame::loadType): Ditto.
3480         (WebFrame::invalidate):
3481         (WebFrame::setTextSizeMultiplier):
3482         (WebFrame::inViewSourceMode): Added argument checking, and changed to return an HRESULT.
3483         (WebFrame::setInViewSourceMode): Changed to return an HRESULT.
3484         (WebFrame::searchForLabelsBeforeElement): Added argument checking.
3485         (WebFrame::matchLabelsAgainstElement): Ditto.
3486         (WebFrame::frameLoaderDestroyed): Zero out the Frame pointer because the Frame is being destroyed.
3487         (WebFrame::createFrame):
3488         (WebFrame::loadURLIntoChild): Added some assertions.
3489         (WebFrame::dispatchWillSubmitForm):
3490         (WebFrame::frameLoadCompleted):
3491         (WebFrame::receivedData):
3492         (WebFrame::setUpPolicyListener):
3493         (WebFrame::receivedPolicyDecision):
3494         (WebFrame::dispatchDecidePolicyForMIMEType):
3495         (WebFrame::dispatchDecidePolicyForNewWindowAction):
3496         (WebFrame::dispatchDecidePolicyForNavigationAction):
3497         (WebFrame::dispatchCreatePage):
3498         (WebFrame::createPlugin):
3499         (WebFrame::redirectDataToPlugin):
3500         (WebFrame::createJavaAppletWidget):
3501         (WebFrame::windowObjectCleared):
3502         (WebFrame::setPrinting):
3503         (WebFrame::setInPrintingMode):
3504         (WebFrame::computePageRects):
3505         (WebFrame::getPrintedPageCount): Zero out the out parameter before proceeding.
3506         (WebFrame::spoolPages):
3507         (WebFrame::forceLayoutWithPageWidthRange):
3508         * WebFrame.h:
3509         * WebView.cpp:
3510         (WebView::paint): Silently fail on a null Frame, because this method could be called at any time.
3511         (WebView::mouseWheel): Ditto.
3512         (WebViewWndProc): Ditto.
3513         (WebView::inViewSourceMode): Return whatever WebFrame::setInViewSourceMode returns.
3514         (WebView::setInViewSourceMode): Ditto.
3515         (WebView::setCustomTextEncodingName): Replaced check for a null
3516         FrameLoader with a check for a null Frame, which is equivalent but, as
3517         a bonus, won't crash.
3518         (WebView::stringByEvaluatingJavaScriptFromString):
3519         (WebView::elementAtPoint): Added argument checking.
3520         (WebView::selectedText): Ditto.
3521         (WebView::centerSelectionInVisibleArea):
3522
3523 2007-02-19  Adam Roben  <aroben@apple.com>
3524
3525         Build fix.
3526
3527         * WebFrame.cpp:
3528         (WebFrame::computePageRects):
3529
3530 2007-02-18  Maciej Stachowiak  <mjs@apple.com>
3531
3532         Reviewed by Oliver.
3533
3534         - Adapt for Lars's patch to clean up Frame
3535
3536         * WebChromeClient.cpp:
3537         (WebChromeClient::tabsToLinks):
3538         (WebChromeClient::windowResizerRect):
3539         (WebChromeClient::addToDirtyRegion):
3540         (WebChromeClient::scrollBackingStore):
3541         (WebChromeClient::updateBackingStore):
3542         * WebChromeClient.h:
3543         * WebEditorClient.cpp:
3544         (WebEditorClient::shouldChangeSelectedRange):
3545         (WebEditorClient::textFieldDidBeginEditing):
3546         (WebEditorClient::textFieldDidEndEditing):
3547         (WebEditorClient::textDidChangeInTextField):
3548         (WebEditorClient::doTextFieldCommandFromEvent):
3549         (WebEditorClient::textWillBeDeletedInTextField):
3550         (WebEditorClient::textDidChangeInTextArea):
3551         * WebEditorClient.h:
3552         * WebElementPropertyBag.cpp:
3553         (WebElementPropertyBag::Read):
3554         * WebFrame.cpp:
3555         (kit):
3556         (WebFrame::initWithWebFrameView):
3557         (WebFrame::searchForLabelsBeforeElement):
3558         (WebFrame::matchLabelsAgainstElement):
3559         (WebFrame::createPlugin):
3560         (WebFrame::createJavaAppletWidget):
3561         (WebFrame::computePageRects):
3562         (WebFrame::getPrintedPageCount):
3563         (WebFrame::spoolPages):
3564         * WebFrame.h:
3565         * WebView.cpp:
3566         (WebView::handleEditingKeyboardEvent):
3567         (WebView::keyDown):
3568         (WebView::generateSelectionImage):
3569         * WebView.h:
3570
3571 2007-02-18  Ada Chan  <adachan@apple.com>
3572
3573         Reviewed by Adam.
3574         
3575         Move app text controls to use webview
3576
3577         * DOMCoreClasses.cpp:
3578         (DOMNode::parentNode): implemented
3579         (DOMElement::blur): implemented
3580         * Interfaces/IWebUIDelegatePrivate.idl: added API for focus/blur notifications
3581         * WebKit.vcproj/WebKit.def: added DrawTextAtPoint
3582         * WebKit.vcproj/WebKit.vcproj: added WebKitGraphics.h/cpp
3583         * WebKit.vcproj/WebKit_debug.def: added DrawTextAtPoint
3584         * WebKitGraphics.cpp: Added.
3585         (DrawTextAtPoint): calls WebCoreDrawTextAtPoint to render text
3586         * WebKitGraphics.h: Added.
3587         * WebView.cpp:
3588         (WebViewWndProc): notify setfocus and killfocus through IWebUIDelegatePrivate delegate.
3589         (WebView::unmarkAllTextMatches): added null check
3590
3591 2007-02-18  Oliver Hunt  <oliver@apple.com>
3592
3593         Reviewed by Adam.
3594
3595         Stubs to keep the build going
3596
3597         * WebDragClient.cpp:
3598         (WebDragClient::willPerformDragSourceAction):
3599         (WebDragClient::startDrag):
3600         (WebDragClient::createDragImageForLink):
3601         * WebDragClient.h:
3602
3603 2007-02-17  Steve Falkenburg  <sfalken@apple.com>
3604
3605         Reviewed by Adam.
3606
3607         <rdar://problem/4918821> Find: clicking on the webview does not hide findoverlay
3608         <rdar://problem/4956428> Find: Showing/hiding the Find banner should not push the page contents down when possible
3609
3610         * Interfaces/IWebViewPrivate.idl: Added scrollBy, visibleContentRect
3611         * WebView.cpp:
3612         (WebView::scrollOffset): Add null check
3613         (WebView::scrollBy): Added so we can scroll a webview easily (matches scroll position getter here)
3614         (WebView::visibleContentRect):  Added so we can size find overlay appropriately (not including scroll bars)
3615         * WebView.h: Added scrollBy, visibleContentRect
3616
3617 2007-02-17  Adele Peterson  <adele@apple.com>
3618
3619         Reviewed by Hyatt.
3620
3621         Fix for <rdar://problem/5006194> Caret is not revealed when a newline is entered into a textarea
3622
3623         * WebView.cpp: (WebView::handleEditingKeyboardEvent):
3624         Use shared code in Editor class to insertParagraphSeparator (or insertLineBreak for plain text).
3625         This will also reveal the selection properly.
3626
3627 2007-02-16  Anders Carlsson  <acarlsson@apple.com>
3628
3629         Build fixes.
3630         
3631         * WebDownload.cpp:
3632         (WebDownload::init):
3633         (WebDownload::initWithRequest):
3634
3635 2007-02-15  Steve Falkenburg  <sfalken@apple.com>
3636
3637         Reviewed by Adam.
3638         
3639         <rdar://problem/5001181> Crash: autofilling empty page
3640         
3641         Return an error from WebFrame::DOMDocument if there's no document
3642
3643         * WebFrame.cpp:
3644         (WebFrame::DOMDocument): null document now maps to E_FAIL
3645
3646 2007-02-15  Brady Eidson  <beidson@apple.com>
3647
3648         Reviewed by Adam
3649
3650         <rdar://4778394> - Save scroll position in the back/forward list
3651         
3652         * WebFrame.cpp:
3653         (WebFrame::restoreViewState):  Renamed, as scroll position was pushed to WebCore
3654         (WebFrame::saveViewStateToItem):  Ditto
3655         * WebFrame.h:
3656
3657 2007-02-15  Adam Roben  <aroben@apple.com>
3658
3659         Reviewed by Anders.
3660
3661         Fix <rdar://problem/4968731> Printing scales frames to page width