Reviewed by Adam.
[WebKit-https.git] / WebKit / win / ChangeLog
1 2007-07-19  Maciej Stachowiak  <mjs@apple.com>
2
3         Reviewed by Adam.
4         
5         - WebKit part of fix for <rdar://problem/5262230> Crash while loading a popup in addictinggames.com
6         
7         Made closeWindowSoon fire on a timer instead of happening synchronously.
8
9         * WebChromeClient.cpp:
10         (WebChromeClient::closeWindowSoon): Actually close the window on a timer, not immediately.
11         * WebKit.vcproj/WebKit.vcproj:
12         * WebView.cpp:
13         (WebView::WebView):
14         (WebView::closeWindowSoon):
15         (WebView::closeWindowTimerFired):
16         * WebView.h:
17
18 2007-07-18  Timothy Hatcher  <timothy@apple.com>
19
20         Reviewed by Adam.
21
22         Make the Page with the now required InspectorClient.
23
24         * WebView.cpp:
25         (WebView::initWithFrame):
26
27 2007-07-18  Sam Weinig  <sam@webkit.org>
28
29         Build fix.
30
31         * WebFrame.cpp:
32         (WebFrame::dispatchDecidePolicyForMIMEType):
33         (WebFrame::objectContentType):
34         * WebView.cpp:
35         (WebView::canShowMIMEType):
36
37 2007-07-17  Brady Eidson <beidson@apple.com>
38
39         Blind Windows build fix from r24395
40
41         * WebView.cpp:
42         (WebView::initWithFrame): BSTR, not BString
43
44 2007-07-17  Brady Eidson  <beidson@apple.com>
45
46         Reviewed by Steve
47         
48         <rdar://problem/4516185> - FTP Directory Listings
49
50         * Interfaces/IWebUIDelegate.idl: Add IWebUIDelegate2 method for getting the path to the template
51         
52         * WebView.cpp:
53           (WebView::initWithFrame): Set the preference for the template path in WebCore when the first
54           WebView is initialized
55
56 2007-07-17  Ada Chan  <adachan@apple.com>
57
58         Rubbet-stamped by Adam.
59         
60         Fixed build.
61
62         * Interfaces/IWebFramePrivate.idl:
63         * WebContextMenuClient.cpp:
64         (fixMenuReceivedFromOldSafari):
65         * WebFrame.cpp:
66         (WebFrame::loadURLIntoChild):
67         (WebFrame::download):
68         * WebFrame.h:
69
70 2007-07-17  Adam Roben  <aroben@apple.com>
71
72         Fix Bug 14324: Cannot remove/customize the "Inspect Element" contextual menu item
73         http://bugs.webkit.org/show_bug.cgi?id=14324
74
75         If we detect that we're running against the Safari 3 Beta, we add back
76         the Inspect Element menu item after passing it off to the delegate
77         because Safari's UI delegate will remove it.
78
79         Reviewed by Tim.
80
81         * WebContextMenuClient.cpp:
82         (isPreInspectElementTagSafari): Added.
83         (fixMenuReceivedFromOldSafari): Added.
84         (WebContextMenuClient::getCustomMenuFromDefaultItems): Call
85         fixMenuReceivedFromOldSafari before returning the new menu.
86
87 2007-07-17  Adam Roben  <aroben@apple.com>
88
89         Remove WebContextMenuClient::shouldIncludeInspectElementItem
90
91         Reviewed by Tim.
92
93         * WebContextMenuClient.cpp:
94         * WebContextMenuClient.h:
95
96 2007-07-17  Adam Roben  <aroben@apple.com>
97
98         Initialize Settings::developerExtrasEnabled
99
100         Reviewed by Tim.
101
102         * WebView.cpp:
103         (WebView::updateWebCoreSettingsFromPreferences):
104
105 2007-07-17  Geoffrey Garen  <ggaren@apple.com>
106
107         Build fix. 
108
109         * WebContextMenuClient.cpp:
110         (WebContextMenuClient::searchWithGoogle): Pass false for lockHistory 
111         like we do elsewhere.
112
113 2007-07-17  Oliver Hunt  <oliver@apple.com>
114
115         Reviewed by Adam.
116
117         Fix for <rdar://problem/5339416> Candidate window does not
118                 appear in the correct location for japanese IME
119
120         * WebView.cpp:
121         (WebView::prepareCandidateWindow):
122           We now use an exclusion zone so that the composition window never 
123           overlaps the composition string
124         (WebView::onIMERequestCharPosition):
125           Correctly handle character offsets marked regions
126
127 2007-07-16  Oliver Hunt  <oliver@apple.com>
128
129         Reviewed by Maciej.
130
131         Fix for <rdar://problem/5334818> Support IME reconversion in windows
132
133         Also includes a small amount of IME refactoring.
134
135         * WebView.cpp:
136         (WebView::onIMERequestCharPosition):
137         (WebView::onIMERequestReconvertString):
138         (WebView::onIMERequest):
139         * WebView.h:
140
141 2007-07-16  Brady Eidson  <beidson@apple.com>
142
143         Reviewed by Adam
144
145         Begin the arduous task of localizing FTP directory listings while removing a global initializer!
146
147         * English.lproj/Localizable.strings:
148         * WebCoreLocalizedStrings.cpp:
149         (WebCore::unknownFileSizeText):
150
151 2007-07-16  Oliver Hunt  <oliver@apple.com>
152
153         Reviewed by Maciej.
154
155         Fix for <rdar://problem/5334826> Chinese IME composition window does not appear in the correct location
156
157         Respect IME requests for character position.
158
159         * WebView.cpp:
160         (WebView::onIMERequestCharPosition):
161         (WebView::onIMERequest):
162         * WebView.h:
163
164 2007-07-16  Adam Roben  <aroben@apple.com>
165
166         WebKit/win part of <rdar://problem/5336005> Calling window.print() on a subframe prints whole page, should only print that subframe
167
168         Reviewed by Darin.
169
170         * Interfaces/IWebUIDelegate.idl: Rename print to printFrame to closer
171         match the Mac method, and copy more of the Mac API comments.
172         * WebChromeClient.cpp:
173         (WebChromeClient::print): Call printFrame instead of print.
174
175 2007-07-16  Adam Roben  <aroben@apple.com>
176
177         Updated WebChromeClient for ChromeClient changes.
178
179         Reviewed by Darin.
180
181         * WebChromeClient.cpp:
182         (WebChromeClient::print): Added a Frame* parameter.
183         * WebChromeClient.h: Ditto.
184
185 2007-07-16  Oliver Hunt  <oliver@apple.com>
186
187         Reviewed by Steve.
188
189         Fix for http://bugs.webkit.org/show_bug.cgi?id=14630
190
191         Remove bogus assertion
192
193         * WebView.cpp:
194         (WebView::getIMMContext):
195
196 2007-07-14  Brady Eidson  <beidson@apple.com>
197
198         Reviewed by Sam
199         
200         Set the pref to override the policy delegate for FTP directory listings on Windows
201
202         * WebView.cpp:
203         (WebView::updateWebCoreSettingsFromPreferences):
204
205 2007-07-13  Oliver Hunt  <oliver@apple.com>
206
207         Reviewed by Darin and Alexey.
208
209         Fix for <rdar://problem/5231528> Inline input of International text (IME)
210                 http://bugs.webkit.org/show_bug.cgi?id=14331
211
212         This patch adds IME support to WebKit/win, it currently does not support
213         reconversion (<rdar://problem/5334818>) and has issues with the chinese
214         IMEs (<rdar://problem/5334826>)
215
216         * WebEditorClient.cpp:
217         (WebEditorClient::respondToChangedSelection):
218         (WebEditorClient::handleInputMethodKeypress):
219           Prevent the initial keydown for an IME from triggering a keypressed event
220         * WebView.cpp:
221         (WebView::WebView):
222         (WebView::keyUp):
223         (WebView::keyDown):
224         (WebViewWndProc):
225         (IMMDict::dict):
226         (IMMDict::IMMDict):
227            Dynamic loader for IME libraries
228
229         (WebView::getIMMContext):
230         (WebView::releaseIMMContext):
231         (WebView::prepareCandidateWindow):
232         (selectionInsideMarkedText):
233         (setSelectionToEndOfRange):
234         (WebView::resetIME):
235         (WebView::updateSelectionForIME):
236         (WebView::selectionChanged):
237         (getCompositionString):
238         (compositionToUnderlines):
239            Helper functions
240
241         (WebView::onIMEStartComposition):
242         (WebView::onIMEComposition):
243         (WebView::onIMEEndComposition):
244         (WebView::onIMEChar):
245         (WebView::onIMENotify):
246         (WebView::onIMERequest):
247         (WebView::onIMESelect):
248         (WebView::onIMESetContext):
249            IME event handling, so far most of these are not implemented, but the bulk of functionality 
250            is performed the the composition event handlers
251         * WebView.h:
252
253 2007-07-12  Alice Liu  <alice.liu@apple.com>
254
255         Reviewed by Maciej and Steve.
256
257         fixed <rdar://4982432> window.print() needs to be implemented
258
259         * Interfaces/IWebUIDelegate.idl:
260         * WebChromeClient.cpp:
261         (WebChromeClient::print):
262         * WebChromeClient.h:
263
264 2007-07-11  Steve Falkenburg  <sfalken@apple.com>
265
266         Static analysis build fix.
267         
268         Only specify /analyze (PREfast) if it is available.
269         Prevents entire project from rebuilding each time.        
270
271         Reviewed by Hyatt.
272
273         * WebKit.vcproj/WebKit.vcproj:
274
275 2007-07-10  Ada Chan  <adachan@apple.com>
276         
277         Fixed build.
278
279         * WebView.cpp:
280
281 2007-07-09  Alice Liu  <alice.liu@apple.com>
282
283         Reviewed by Adam Roben.
284         
285         Adding DOM Paste Allowed preference, setters and getters
286         for the purpose of layout tests.
287
288         * Interfaces/IWebPreferences.idl:
289         * WebPreferenceKeysPrivate.h:
290         * WebPreferences.cpp:
291         (WebPreferences::isDOMPasteAllowed):
292         (WebPreferences::setDOMPasteAllowed):
293         * WebPreferences.h:
294         * WebView.cpp:
295         (WebView::updateWebCoreSettingsFromPreferences):
296
297 2007-07-09  Anders Carlsson  <andersca@apple.com>
298
299         Build fix.
300
301         * WebView.cpp:
302         (WebView::stringByEvaluatingJavaScriptFromString):
303
304 2007-07-05  Adam Roben  <aroben@apple.com>
305
306         Fix a leak in WebView::setToolTip
307
308         Reviewed by Beth.
309
310         * WebView.cpp:
311         (WebView::setToolTip):
312
313 2007-07-05  Adam Roben  <aroben@apple.com>
314
315         Fix Bug 14143: Tooltips not displayed on Windows
316         http://bugs.webkit.org/show_bug.cgi?id=14143
317         <rdar://problem/4719799>
318
319         Reviewed by Oliver.
320
321         * WebChromeClient.cpp:
322         (WebChromeClient::setToolTip): Call up to WebView.
323         * WebView.cpp:
324         (WebView::WebView): Initialize m_toolTipHwnd member.
325         (WebView::initWithFrame): Set up the tool tip window.
326         (initCommonControls): Added.
327         (WebView::initializeToolTipWindow): Added.
328         (WebView::setToolTip): Set the tool tip text and enable/disable the
329         tool tip.
330         * WebView.h: Added/updated declarations.
331
332 2007-07-04  Adam Roben  <aroben@apple.com>
333
334         Added a stub for WebChromeClient::setToolTip
335
336         Reviewed by Sam.
337
338         * WebChromeClient.cpp:
339         * WebChromeClient.h:
340
341 2007-07-04  Adam Roben  <aroben@apple.com>
342
343         Initialize Settings::showsURLsInToolTips
344
345         Reviewed by Sam.
346
347         * WebView.cpp:
348         (WebView::updateWebCoreSettingsFromPreferences):
349
350 2007-07-04  Adam Roben  <aroben@apple.com>
351
352         Removed call to mouseDidMoveOverElement now that WebCore handles it
353
354         Reviewed by Sam.
355
356         * WebView.cpp:
357         (WebView::handleMouseEvent):
358
359 2007-07-04  Adam Roben  <aroben@apple.com>
360
361         Add WebChromeClient::mouseDidMoveOverElement
362
363         This is not called yet.
364
365         Reviewed by Sam.
366
367         * WebChromeClient.cpp:
368         (WebChromeClient::mouseDidMoveOverElement):
369         * WebChromeClient.h:
370
371 2007-07-03  Adam Roben  <aroben@apple.com>
372
373         Merge the Windows and Mac localized strings and exceptions files
374
375         Reviewed by Darin and Anders.
376
377         * English.lproj/Localizable.strings: Added Mac strings.
378         * English.lproj/StringsNotToBeLocalized.txt: Removed.
379
380 2007-06-27  Steve Falkenburg  <sfalken@apple.com>
381
382         Turn on static code analysis.
383
384         Reviewed by Oliver.
385         
386         Affects only folks that have Visual Studio Team Suite installed,
387         or who have replaced their compiler with the version shipping in the
388         Vista SDK.
389
390         * CodeAnalysisConfig.h: Added.
391         * WebKit.vcproj/WebKit.vcproj:
392         * WebLocalizableStrings.cpp:
393         (createWebKitBundle):
394
395 2007-06-27  Steve Falkenburg  <sfalken@apple.com>
396
397         Prefast: Remove variable redefinitions in inner scopes.
398         
399         Reviewed by Ada.
400
401         * WebDownload.cpp:
402         (WebDownload::didFinish):
403         * WebNotificationCenter.cpp:
404         (WebNotificationCenter::postNotificationInternal):
405         (WebNotificationCenter::removeObserver):
406
407 2007-06-27  Steve Falkenburg  <sfaken@apple.com>
408
409         Remove SEH block from around history plist read, since the underlying bug has been fixed.
410         
411         Reviewed by Darin.
412
413         * WebHistory.cpp:
414         (createHistoryListFromStream):
415
416 2007-06-27  Steve Falkenburg  <sfalken@apple.com>
417
418         Prefast: Fix misplaced parenthesis.
419         
420         Reviewed by Darin.
421
422         * WebView.cpp:
423         (core):
424
425 2007-06-27  Steve Falkenburg  <sfalken@apple.com>
426
427         Prefast: Add null check prior to writing into allocated BSTR.
428         
429         Reviewed by Darin.
430
431         * MarshallingHelpers.cpp:
432         (MarshallingHelpers::CFStringRefToBSTR):
433
434 2007-06-27  Steve Falkenburg  <sfalken@apple.com>
435
436         Prefast: Add error handling for SysAllocStringLen where the string length is determined by website content.
437
438         Reviewed by Sam, Darin.
439                 
440         Allocation failure will result in a null dereference in this case,
441         so it isn't exploitable.
442
443         * DefaultDownloadDelegate.cpp:
444         (DefaultDownloadDelegate::decideDestinationWithSuggestedFilename):
445
446 2007-06-20  Adam Roben  <aroben@apple.com>
447
448         Land the new Inspector.
449
450         Co-written with Tim Hatcher.
451
452         Reviewed by Anders, Adele, Hyatt, and Sam.
453
454         Implement the InspectorClient interface.
455
456         * WebInspectorClient.cpp: Added.
457         (WebInspectorClient::WebInspectorClient):
458         (WebInspectorClient::~WebInspectorClient):
459         (WebInspectorClient::inspectorDestroyed):
460         (WebInspectorClient::createPage):
461         (WebInspectorClient::showWindow):
462         (WebInspectorClient::closeWindow):
463         (WebInspectorClient::windowVisible):
464         (WebInspectorClient::attachWindow):
465         (WebInspectorClient::detachWindow):
466         (WebInspectorClient::highlight):
467         (WebInspectorClient::hideHighlight):
468         (WebInspectorClient::inspectedURLChanged):
469         (WebInspectorClient::updateWindowTitle):
470         (WebInspectorClient::onSize):
471         (WebInspectorClient::onClose):
472         (WebInspectorClient::onWebViewWindowPosChanging):
473         (WebInspectorWndProc):
474         (SubclassedWebViewWndProc):
475         (registerWindowClass):
476         * WebInspectorClient.h: Added.
477
478         Add an easier-to-see highlight.
479
480         * WebNodeHighlight.cpp: Added.
481         (WebNodeHighlight::WebNodeHighlight):
482         (WebNodeHighlight::~WebNodeHighlight):
483         (WebNodeHighlight::highlight):
484         (WebNodeHighlight::hide):
485         (WebNodeHighlight::visible):
486         (WebNodeHighlight::updateWindow):
487         (WebNodeHighlight::removeSubclass):
488         (registerOverlayClass):
489         (OverlayWndProc):
490         (SubclassedWndProc):
491         * WebNodeHighlight.h: Added.
492
493         WebView changes needed for the new Inspector.
494
495         * WebView.cpp: Removed old inspectElement method now that this is
496         handled by WebCore.
497         (WebView::WebView):
498         (WebView::close):
499         (WebView::performContextMenuAction): Removed handling of the Inspect
500         Element context menu item.
501         (WebView::initWithFrame): Give each Page an InspectorClient to enable
502         the Inspector.
503         (WebView::setProhibitsMainFrameScrolling): Added.
504         * WebView.h:
505
506         Updates needed for WebCore changes.
507
508         * Interfaces/IWebUIDelegate.idl:
509         * WebContextMenuClient.cpp:
510         (WebContextMenuClient::getCustomMenuFromDefaultItems):
511         * WebContextMenuClient.h:
512         * WebCoreLocalizedStrings.cpp:
513
514         Remove old Inspector code.
515
516         * WebFrame.cpp:
517         * WebFrame.h:
518         * WebInspector/WebInspector.cpp: Removed.
519         * WebInspector/WebInspector.h: Removed.
520         * WebInspector/webInspector/Images/button.png: Removed.
521         * WebInspector/webInspector/Images/buttonDivider.png: Removed.
522         * WebInspector/webInspector/Images/buttonPressed.png: Removed.
523         * WebInspector/webInspector/Images/close.png: Removed.
524         * WebInspector/webInspector/Images/closePressed.png: Removed.
525         * WebInspector/webInspector/Images/downTriangle.png: Removed.
526         * WebInspector/webInspector/Images/menu.png: Removed.
527         * WebInspector/webInspector/Images/menuPressed.png: Removed.
528         * WebInspector/webInspector/Images/popup.png: Removed.
529         * WebInspector/webInspector/Images/popupPressed.png: Removed.
530         * WebInspector/webInspector/Images/resize.png: Removed.
531         * WebInspector/webInspector/Images/rightTriangle.png: Removed.
532         * WebInspector/webInspector/Images/scrollThumbBottom.png: Removed.
533         * WebInspector/webInspector/Images/scrollThumbMiddle.png: Removed.
534         * WebInspector/webInspector/Images/scrollTrackMiddle.png: Removed.
535         * WebInspector/webInspector/Images/upTriangle.png: Removed.
536         * WebInspector/webInspector/inspector.css: Removed.
537         * WebInspector/webInspector/inspector.html: Removed.
538         * WebInspector/webInspector/inspector.js: Removed.
539         * WebInspector/webInspector/scrollarea.js: Removed.
540         * WebInspector/webInspector/scrollbar.js: Removed.
541         * WebInspector/webInspector/treeoutline.js: Removed.
542         * WebInspector/webInspector/utilities.js: Removed.
543
544         Build-fu:
545
546         * WebKit.vcproj/WebKit.vcproj:
547
548 2007-06-19  Dave Hyatt  <hyatt@apple.com>
549
550         Fix for <rdar://problem/5022197>, backspace and ctrl+left arrow should go back.  Shift+backspace
551         and ctrl+right arrow should go forward.  Add support for these keybindings to Windows.
552        
553         Reviewed by ada
554
555         * WebView.cpp:
556         (WebView::keyDown):
557
558 2007-06-18  Dave Hyatt  <hyatt@apple.com>
559
560         Let through more newline+modifier key combos in order to support Alt+Enter and Ctrl+Enter in the
561         SafariWin URL bar.
562        
563         Reviewed by mccullough
564
565         * WebView.cpp:
566
567 2007-06-18  Dave Hyatt  <hyatt@apple.com>
568
569         Add support for horizontal mouse wheeling to Windows.  Shift+wheel is supported for horizontal
570         wheeling just like on OS X.  In addition, the WM_MOUSEHWHEEL event is now processed correctly so that
571         input devices like tilt wheels will now work.
572        
573         Reviewed by aroben
574
575         * WebView.cpp:
576         (WebView::mouseWheel):
577         (WebViewWndProc):
578         * WebView.h:
579
580 2007-06-17  Dave Hyatt  <hyatt@apple.com>
581
582         Add support for Ctrl+Mouse Wheel to increase/decrease text zoom (Win32 only).
583        
584         Reviewed by aroben
585
586         * WebView.cpp:
587         (WebView::mouseWheel):
588
589 2007-06-09  Steve Falkenburg  <sfalken@apple.com>
590
591         Reviewed by Adam.
592         
593         Workaround: <rdar://problem/5213266> schwab.com menu is ridiculously big.
594         
595         * WebView.cpp:
596         (WebView::userAgentForKURL): Add schwab to spoof list to fix gigantic menus.
597
598 2007-06-08  Ada Chan  <adachan@apple.com>
599
600         Reviewed by Hyatt, Adam, and Steve.
601
602         Fixed WebView::selectedText to get the selected text out of the focused frame or main frame.
603
604         * WebView.cpp:
605         (WebView::selectedText):
606
607 2007-06-08  Adam Roben  <aroben@apple.com>
608
609         Get rid of the Safari part of the query string used for Google searches.
610
611         Reviewed by Steve and Ada.
612
613         * WebContextMenuClient.cpp:
614         (WebContextMenuClient::searchWithGoogle):
615
616 2007-06-08  Kevin McCullough  <kmccullough@apple.com>
617
618         Reviewed by Kevin Decker, and Sam.
619
620         - Added and updated licenses.
621
622         * CFDictionaryPropertyBag.cpp:
623         * CFDictionaryPropertyBag.h:
624         * DOMCSSClasses.cpp:
625         * DOMCSSClasses.h:
626         * DOMEventsClasses.cpp:
627         * DOMEventsClasses.h:
628         * DOMHTMLClasses.cpp:
629         * DOMHTMLClasses.h:
630         * MarshallingHelpers.cpp:
631         * MarshallingHelpers.h:
632         * MemoryStream.cpp:
633         * MemoryStream.h:
634         * WebBackForwardList.cpp:
635         * WebBackForwardList.h:
636         * WebCache.cpp:
637         * WebCache.h:
638         * WebChromeClient.cpp:
639         * WebChromeClient.h:
640         * WebContextMenuClient.h:
641         * WebDataSource.h:
642         * WebEditorClient.cpp:
643         * WebEditorClient.h:
644         * WebElementPropertyBag.cpp:
645         * WebElementPropertyBag.h:
646         * WebHTMLRepresentation.h:
647         * WebHistory.cpp:
648         * WebHistory.h:
649         * WebIconDatabase.cpp:
650         * WebIconDatabase.h:
651         * WebKit.vcproj/auto-version.sh:
652         * WebKitClassFactory.h:
653         * WebKitDLL.h:
654         * WebLocalizableStrings.cpp:
655         * WebLocalizableStrings.h:
656         * WebMutableURLRequest.cpp:
657         * WebMutableURLRequest.h:
658         * WebNotification.cpp:
659         * WebNotification.h:
660         * WebNotificationCenter.cpp:
661         * WebNotificationCenter.h:
662         * WebPreferenceKeysPrivate.h:
663         * WebPreferences.cpp:
664         * WebPreferences.h:
665         * WebScriptObject.cpp:
666         * WebScriptObject.h:
667         * WebURLResponse.cpp:
668         * WebURLResponse.h:
669
670 2007-06-07  Sam Weinig  <sam@webkit.org>
671
672         Reviewed by Adam Roben.
673
674         Make the inspector compile again.
675
676         * WebInspector/WebInspector.cpp:
677         (setFocusedDOMNodeCallback):
678         (focusedDOMNodeCallback):
679         (setRootDOMNodeCallback):
680         (rootDOMNodeCallback):
681
682 2007-06-06  Steve Falkenburg  <sfalken@apple.com>
683
684         Reviewed by Adam.
685         
686         <rdar://problem/5255861> REGRESSION: Can't download Adobe Acrobat Reader and plug-in
687         <rdar://problem/5243655> Flash download page doesn't recognize Boomer
688         
689         Refine user agent spoofing code to only spoof Flash download as Firefox without spoofing all of adobe.com.
690         This fixes the Acrobat Reader download.
691
692         * WebView.cpp:
693         (WebView::userAgentForKURL):
694
695 2007-06-03  Steve Falkenburg  <sfalken@apple.com>
696
697         Reviewed by Adam.
698         
699         <rdar://problem/5246665> Drop down lists are not drawn on volvocars.us
700
701         * WebView.cpp:
702         (WebView::userAgentForKURL):
703
704 2007-06-01  Kevin McCullough  <kmccullough@apple.com>
705
706         Reviewed by Oliver.
707
708         - Uncommenting some functions that should not be commented out.  I needed them for the Drosera port.
709
710         * WebKit.vcproj/WebKit_debug.def:
711
712 2007-06-01  Steve Falkenburg  <sfalken@apple.com>
713
714         Reviewed by Kevin Decker.
715         
716         Remove unnecessary user agent spoofs, now that we have the final UA in place.
717         Added spoof to allow Flash downloads from adobe.com
718
719         * WebView.cpp:
720         (WebView::userAgentForKURL):
721
722 2007-05-30  Ada Chan  <adachan@apple.com>
723
724         Reviewed by Steve.
725
726         Implemented the mechanism to associate a WebPreferences instance with an identifier.
727
728         * WebIconDatabase.cpp:
729         (WebIconDatabase::init): fixed a missing Release on standardPrefs by using COMPtr.
730         * WebPreferences.cpp:
731         (WebPreferences::getInstanceForIdentifier): implemented
732         (WebPreferences::setInstance): implemented
733         (WebPreferences::removeReferenceForIdentifier): if the WebPreferences going to be
734         released has only one ref left, remove it from the s_webPreferencesInstances dictionary.
735         (WebPreferences::load): don't need to reread in the default preferences if we have done so.
736         (WebPreferences::initWithIdentifier): update the m_identifier data member with the
737         passed in identifier string, and store the identifier to WebPreferences instance mapping in
738         s_webPreferencesInstances dictionary.
739         (WebPreferences::identifier): implemented
740         * WebPreferences.h:
741         * WebView.cpp:
742         (WebView::~WebView): removed the call to removeObserver for the WebPreferencesChangedNotification
743         since it's already done in close().
744         (WebView::close): the call to removeObserver now takes in the WebPreferences instance for the object -
745         this way the WebView is only notified when that particular WebPreferences instance changes.
746         (WebView::initWithFrame): the call to addObserver now takes in the WebPreferences instance for the object -
747         this way the WebView is only notified when that particular WebPreferences instance changes.
748         (WebView::setPreferences): implemented
749         (WebView::onNotify): used COMPtr to fix a missing release
750
751 2007-05-29  Steve Falkenburg  <sfalken@apple.com>
752
753         Reviewed by Darin.
754         
755         Removed setPageCacheSize/pageCacheSize from IWebBackForwardList.
756
757         * Interfaces/IWebBackForwardList.idl: Removed unnecessary methods.
758         * WebBackForwardList.cpp: Removed unnecessary methods.
759         * WebBackForwardList.h: Removed unnecessary methods.
760
761 2007-05-29  Sam Weinig  <sam@webkit.org>
762
763         Reviewed by Adam Roben.
764
765         - Removes platform/win/NotImplemented.h because we have consolidated
766           the notImplemented() for all platforms in platform/NotImplemented.h
767         - Fixes remaining uses of old macro to use the new notImplemented() one.
768
769         * WebChromeClient.cpp:
770         (WebChromeClient::createModalDialog):
771         (WebChromeClient::canRunModal):
772         (WebChromeClient::runModal):
773         (WebChromeClient::setScrollbarsVisible):
774         (WebChromeClient::scrollbarsVisible):
775         (WebChromeClient::setMenubarVisible):
776         (WebChromeClient::menubarVisible):
777         * WebContextMenuClient.cpp:
778         (WebContextMenuClient::lookUpInDictionary):
779         (WebContextMenuClient::speak):
780         (WebContextMenuClient::stopSpeaking):
781         * WebDownload.cpp:
782         (WebDownload::canResumeDownloadDecodedWithEncodingMIMEType):
783         (WebDownload::cancelAuthenticationChallenge):
784         (WebDownload::continueWithoutCredentialForAuthenticationChallenge):
785         (WebDownload::useCredential):
786         (WebDownload::didReceiveAuthenticationChallenge):
787         * WebEditorClient.cpp:
788         (WebEditorClient::spellCheckerDocumentTag):
789         (WebEditorClient::shouldBeginEditing):
790         (WebEditorClient::shouldEndEditing):
791         (WebEditorClient::didBeginEditing):
792         (WebEditorClient::respondToChangedContents):
793         (WebEditorClient::respondToChangedSelection):
794         (WebEditorClient::didEndEditing):
795         (WebEditorClient::didWriteSelectionToPasteboard):
796         (WebEditorClient::didSetSelectionTypesForPasteboard):
797         (WebEditorClient::shouldDeleteRange):
798         (WebEditorClient::shouldInsertNode):
799         (WebEditorClient::shouldInsertText):
800         (WebEditorClient::shouldApplyStyle):
801         (WebEditorClient::shouldChangeTypingStyle):
802         (WebEditorClient::webViewDidChangeTypingStyle):
803         (WebEditorClient::webViewDidChangeSelection):
804         (WebEditorClient::shouldShowDeleteInterface):
805         (WebEditorClient::shouldChangeSelectedRange):
806         * WebFrame.cpp:
807         (WebFrame::makeRepresentation):
808         (WebFrame::forceLayout):
809         (WebFrame::forceLayoutForNonHTML):
810         (WebFrame::setCopiesOnScroll):
811         (WebFrame::detachedFromParent1):
812         (WebFrame::detachedFromParent2):
813         (WebFrame::detachedFromParent3):
814         (WebFrame::detachedFromParent4):
815         (WebFrame::loadedFromCachedPage):
816         (WebFrame::dispatchDidLoadMainResource):
817         (WebFrame::revertToProvisionalState):
818         (WebFrame::clearUnarchivingState):
819         (WebFrame::setMainFrameDocumentReady):
820         (WebFrame::willChangeTitle):
821         (WebFrame::didChangeTitle):
822         (WebFrame::finalSetupForReplace):
823         (WebFrame::setDefersLoading):
824         (WebFrame::isArchiveLoadPending):
825         (WebFrame::cancelPendingArchiveLoad):
826         (WebFrame::clearArchivedResources):
827         (WebFrame::canShowMIMEType):
828         (WebFrame::representationExistsForURLScheme):
829         (WebFrame::generatedMIMETypeForURLScheme):
830         (WebFrame::restoreViewState):
831         (WebFrame::provisionalLoadStarted):
832         (WebFrame::shouldTreatURLAsSameAsCurrent):
833         (WebFrame::addHistoryItemForFragmentScroll):
834         (WebFrame::didFinishLoad):
835         (WebFrame::prepareForDataSourceReplacement):
836         (WebFrame::setDocumentViewFromCachedPage):
837         (WebFrame::shouldGoToHistoryItem):
838         (WebFrame::saveViewStateToItem):
839         (WebFrame::saveDocumentViewToCachedPage):
840         (WebFrame::canCachePage):
841         (WebFrame::setMainDocumentError):
842         (WebFrame::cannotShowURLError):
843         (WebFrame::cannotShowMIMETypeError):
844         (WebFrame::fileDoesNotExistError):
845         (WebFrame::willUseArchive):
846         (WebFrame::dispatchDidLoadResourceFromMemoryCache):
847         (WebFrame::startDownload):
848         (WebFrame::overrideMediaType):
849         (WebFrame::addInspector):
850         (WebFrame::removeInspector):
851
852 2007-05-25  Oliver Hunt  <oliver@apple.com>
853
854         Reviewed by Hyatt.
855         
856         Fix rdar://problem/5212399 <object> with PNG src rendered as image document (causes Acid2 to fail)
857
858         * WebFrame.cpp:
859         (WebFrame::objectContentType):
860
861 2007-05-25  Geoffrey Garen  <ggaren@apple.com>
862
863         Build fix -- forgot to commit a little bit in my last patch.
864
865 2007-05-25  Geoffrey Garen  <ggaren@apple.com>
866
867         Reviewed by Darin Adler, Adam Roben.
868
869         Fixed <rdar://problem/5055182> The page cache has no global cap.
870         
871         The main WebKit changes are:
872             1. Gutted IWebBackForwardList::setPageCacheSize and IWebBackForwardList:: 
873             pageCacheSize because they're deprecated on Mac now. I didn't remove
874             them, though, because doing so can cause COM badness.
875             
876             2. Added IWebPreferences::setUsesPageCache IWebPreferences:: 
877             usesPageCache because that's the new Mac API. I added them to the end
878             of IWebPreferences to avoid COM badness.
879             
880             3. Centralized calculation of object cache and page cache sizes inside
881             WebPreferences. 
882             
883             Changed our old behavior of reading a preference and applying a fudge 
884             factor with a new behavior of just using the preference directly. The 
885             old behavior was confusing and often inappropriate. (For example, if 
886             you set a page cache size of 100, a 256MB machine would somewhat 
887             arbitrarily reduce that number to 98.)
888             
889 2007-05-24  Geoffrey Garen  <ggaren@apple.com>
890
891         Reviewed by Darin Adler.
892
893         Fixed a bug with Settings where a number of different objects held bare 
894         Settings* data members, even though the Page owns the Settings object and 
895         deletes it upon destruction.
896         
897         Added NULL checks since the Page can be deleted before the frame/document.
898
899 2007-05-23  Steve Falkenburg  <sfalken@apple.com>
900
901         Added IWebFramePrivate::isDescendantOfFrame.
902
903         * Interfaces/IWebFramePrivate.idl:
904         * WebFrame.cpp:
905         (WebFrame::isDescendantOfFrame):
906         * WebFrame.h:
907
908 2007-05-23  Steve Falkenburg  <sfalken@apple.com>
909
910         Build fix.  Fix continuous rebuilding of Interfaces by turning off Generate Type Library for every IDL except WebKit.idl.
911
912         * WebKit.vcproj/Interfaces.vcproj:
913
914 2007-05-22  Alice Liu  <alice.liu@apple.com>
915
916         Reviewed by Oliver.
917         
918         Enabling smartInsertDelete to resolve 
919         <rdar://problem/5082891> editing/deleting/smart-delete-003.html (and 004) fail
920         
921         * Interfaces/IWebView.idl:
922         * WebEditorClient.cpp:
923         (WebEditorClient::smartInsertDeleteEnabled):
924         * WebView.cpp:
925         (WebView::WebView):
926         (WebView::initWithFrame):
927         (WebView::toggleSmartInsertDelete):
928         (WebView::setSmartInsertDeleteEnabled):
929         (WebView::smartInsertDeleteEnabled):
930         * WebView.h:
931
932 2007-05-22  Justin Garcia  <justin.garcia@apple.com>
933
934         Reviewed by oliver
935         
936         Build fix.
937
938         * WebView.cpp:
939         (WebView::clearFocusNode):
940
941 2007-05-22  Steve Falkenburg  <sfalken@apple.com>
942
943         Reviewed by Ada.
944         
945         Added 3 view-related methods to IWebFramePrivate.
946
947         * Interfaces/IWebFramePrivate.idl: Added 3 new methods
948         * WebFrame.cpp:
949         (WebFrame::hasScrollBars): Added.
950         (WebFrame::contentBounds): Added.
951         (WebFrame::frameBounds): Added.
952         * WebFrame.h:
953
954 2007-05-21  Steve Falkenburg  <sfalken@apple.com>
955
956         Reviewed by Adam, Ada.
957         
958         Added IWebFramePrivate::size().
959
960         * Interfaces/IWebFramePrivate.idl: Added size.
961         * WebFrame.cpp:
962         (WebFrame::size): Added.
963         * WebFrame.h: Added size.
964
965 2007-05-21  Ada Chan  <adachan@apple.com>
966
967         Reviewed by Steve.
968
969         Added IWebViewPrivate::loadBackForwardListFromOtherView().  It replicates the backforward
970         list from another webview and loads that in the current webview.
971
972         * Interfaces/IWebViewPrivate.idl:
973         * WebView.cpp:
974         (WebView::loadBackForwardListFromOtherView):
975         * WebView.h:
976
977 2007-05-18  Steve Falkenburg  <sfalken@apple.com>
978
979         Build-related fix: stamp version resource properly.
980
981         * WebKit.vcproj/WebKit.rc: Fix version resource
982
983 2007-05-18  Adam Roben  <aroben@apple.com>
984
985         Build fix after r21555.
986
987         * WebView.cpp:
988
989 2007-05-17  Ada Chan  <adachan@apple.com>
990
991         Reviewed by Steve.
992         
993         Implemented IWebHTTPURLResponse::localizedStringForStatusCode().
994
995         * English.lproj/Localizable.strings: new http status strings
996         * Interfaces/WebKit.idl: added code to create WebURLResponse instances
997         * WebKitClassFactory.cpp:
998         (WebKitClassFactory::CreateInstance): ditto
999         * WebKitDLL.cpp: ditto
1000         * WebURLResponse.cpp:
1001         (CFHTTPMessageCopyLocalizedShortDescriptionForStatusCode): return the description
1002         text for the given status code
1003         (WebURLResponse::createInstance): create a general instance of web url response.
1004         (WebURLResponse::localizedStringForStatusCode):
1005         * WebURLResponse.h:
1006
1007 2007-05-17  Ada Chan  <adachan@apple.com>
1008
1009         Reviewed by Steve.
1010         
1011         Changed the context menu title "Search in Google" to "Search with Google".
1012
1013         * English.lproj/Localizable.strings:
1014         * WebCoreLocalizedStrings.cpp:
1015         (WebCore::contextMenuItemTagSearchWeb):
1016
1017 2007-05-17  Anders Carlsson  <andersca@apple.com>
1018
1019         Fix build.
1020         
1021         * WebFrame.cpp:
1022         (WebFrame::loadURLIntoChild):
1023
1024 2007-05-15  Steve Falkenburg  <sfalken@apple.com>
1025
1026         Reviewed by Darin, Oliver.
1027         
1028         <rdar://problem/4967360> Need to detect damaged installs, alert the user to reinstall, and exit
1029
1030         * WebLocalizableStrings.cpp:
1031         (WebLocalizedString): Make failure to load a localized string slightly less fatal
1032
1033 2007-05-15  Steve Falkenburg  <sfalken@apple.com>
1034
1035         Reviewed by Darin.
1036         
1037         <rdar://problem/4956541> Need to implement preference for how much History is maintained
1038
1039         * WebHistory.cpp:
1040         (WebHistory::ageLimitDate): Remove extra +30 from history age in days.
1041
1042 2007-05-14  Anders Carlsson  <andersca@apple.com>
1043
1044         Reviewed by Darin.
1045
1046         Pass an empty property bag when constructing the WebError, the code in Safari relies on having a user info bag.
1047         
1048         * WebFrame.cpp:
1049         (WebFrame::createJavaAppletWidget):
1050
1051 2007-05-14  Anders Carlsson  <andersca@apple.com>
1052
1053         Reviewed by Antti.
1054
1055         Report an error to the resource load delegate if the Java plugin can't be loaded.
1056         
1057         * WebFrame.cpp:
1058         (WebFrame::createJavaAppletWidget):
1059
1060 2007-05-11  Steve Falkenburg  <sfalken@apple.com>
1061
1062         Reviewed by Darin, Ada.
1063
1064         WebKit DCOM compatibility.
1065         When a WebKit hosting app calls RunAsLocalServer, the class object for CLSID_WebDebugProgram
1066         is registered to allow creation across processes.  This is for future compatibility with
1067         Drosera.
1068
1069         Added new exported function: RunAsLocalServer.
1070         This exposes WebKit inside the running exe as a LocalServer32 (COM server), which
1071         will allow Drosera to connect to it via DCOM.
1072
1073         We use the DCOM Universal Marshaller from oleaut32.dll, which performs marshalling
1074         based on type libraries, so as part of this change, I've done some work on making our
1075         interfaces compatible with this marshaller.
1076         
1077         Updated for compatibility w/ COM automation, and fixed up our type library.        
1078         Added type library registration/unregistration code.
1079         Marked methods not compatible w/ automation/marshalling as [local].
1080         
1081         As a side-effect, with these changes, the .NET tlbimp tool can create a .NET interop
1082         assembly to theoretically allow WebKit to be invoked from .NET apps.  I haven't
1083         tried this.  It could end up being useful to drive API testing.
1084         
1085         To test, I wrote a small app that calls:
1086         ::CoCreateInstance(CLSID_IWebDebugProgram, 0, CLSCTX_LOCAL_SERVER, IID_IUnknown, (void**)&viewUnknown);
1087         Using this instantiated class, I'm able to iterate the exisitng webviews and retrieve their
1088         source, title, URL, etc.
1089         
1090         * DOMCoreClasses.cpp:
1091         (DOMElement::isEqual):
1092         * DOMCoreClasses.h:
1093         * DefaultDownloadDelegate.cpp:
1094         (DefaultDownloadDelegate::decideDestinationWithSuggestedFilename):
1095         * DefaultDownloadDelegate.h:
1096         * Interfaces/DOMCSS.idl:
1097         * Interfaces/DOMCore.idl:
1098         * Interfaces/DOMEvents.idl:
1099         * Interfaces/DOMExtensions.idl:
1100         * Interfaces/DOMHTML.idl:
1101         * Interfaces/DOMPrivate.idl:
1102         * Interfaces/DOMRange.idl:
1103         * Interfaces/DOMWindow.idl:
1104         * Interfaces/IWebArchive.idl:
1105         * Interfaces/IWebAttributedString.idl: Removed.
1106         * Interfaces/IWebBackForwardList.idl:
1107         * Interfaces/IWebBackForwardListPrivate.idl:
1108         * Interfaces/IWebCache.idl:
1109         * Interfaces/IWebDataSource.idl:
1110         * Interfaces/IWebDebugProgram.idl: Added.
1111         * Interfaces/IWebDocument.idl:
1112         * Interfaces/IWebDownload.idl:
1113         * Interfaces/IWebEditingDelegate.idl:
1114         * Interfaces/IWebError.idl:
1115         * Interfaces/IWebFormDelegate.idl:
1116         * Interfaces/IWebFrame.idl:
1117         * Interfaces/IWebFrameLoadDelegate.idl:
1118         * Interfaces/IWebFrameLoadDelegatePrivate.idl:
1119         * Interfaces/IWebFramePrivate.idl:
1120         * Interfaces/IWebFrameView.idl:
1121         * Interfaces/IWebHTMLRepresentation.idl:
1122         * Interfaces/IWebHTTPURLResponse.idl:
1123         * Interfaces/IWebHistory.idl:
1124         * Interfaces/IWebHistoryItem.idl:
1125         * Interfaces/IWebHistoryItemPrivate.idl:
1126         * Interfaces/IWebIconDatabase.idl:
1127         * Interfaces/IWebJavaScriptCollector.idl:
1128         * Interfaces/IWebKitStatistics.idl:
1129         * Interfaces/IWebMutableURLRequest.idl:
1130         * Interfaces/IWebNotification.idl:
1131         * Interfaces/IWebNotificationCenter.idl:
1132         * Interfaces/IWebNotificationObserver.idl:
1133         * Interfaces/IWebPolicyDelegate.idl:
1134         * Interfaces/IWebPreferences.idl:
1135         * Interfaces/IWebResource.idl:
1136         * Interfaces/IWebResourceLoadDelegate.idl:
1137         * Interfaces/IWebResourceLoadDelegatePrivate.idl:
1138         * Interfaces/IWebScriptObject.idl:
1139         * Interfaces/IWebScrollBarDelegatePrivate.idl:
1140         * Interfaces/IWebScrollBarPrivate.idl:
1141         * Interfaces/IWebUIDelegate.idl:
1142         * Interfaces/IWebUIDelegatePrivate.idl:
1143         * Interfaces/IWebURLAuthenticationChallenge.idl:
1144         * Interfaces/IWebURLRequest.idl:
1145         * Interfaces/IWebURLResponse.idl:
1146         * Interfaces/IWebUndoManager.idl:
1147         * Interfaces/IWebUndoTarget.idl:
1148         * Interfaces/IWebView.idl:
1149         * Interfaces/IWebViewPrivate.idl:
1150         * Interfaces/WebKit.idl:
1151         * WebContextMenuClient.cpp:
1152         (WebContextMenuClient::getCustomMenuFromDefaultItems):
1153         * WebDataSource.cpp:
1154         (WebDataSource::subresources):
1155         * WebDataSource.h:
1156         * WebDebugProgram.cpp: Added.
1157         (EnumViews::EnumViews):
1158         (EnumViews::QueryInterface):
1159         (EnumViews::AddRef):
1160         (EnumViews::Release):
1161         (EnumViews::Next):
1162         (EnumViews::Skip):
1163         (EnumViews::Reset):
1164         (EnumViews::Clone):
1165         (WebDebugProgram::WebDebugProgram):
1166         (WebDebugProgram::~WebDebugProgram):
1167         (WebDebugProgram::createInstance):
1168         (WebDebugProgram::QueryInterface):
1169         (WebDebugProgram::AddRef):
1170         (WebDebugProgram::Release):
1171         (WebDebugProgram::viewAdded):
1172         (WebDebugProgram::viewRemoved):
1173         (WebDebugProgram::attach):
1174         (WebDebugProgram::detach):
1175         (WebDebugProgram::statistics):
1176         (WebDebugProgram::webViews):
1177         * WebDebugProgram.h: Added.
1178         * WebDropSource.cpp:
1179         (generateMouseEvent):
1180         * WebError.cpp:
1181         (WebError::localizedRecoveryOptions):
1182         * WebError.h:
1183         * WebFrame.cpp:
1184         (EnumChildFrames::EnumChildFrames):
1185         (EnumChildFrames::QueryInterface):
1186         (EnumChildFrames::AddRef):
1187         (EnumChildFrames::Release):
1188         (EnumChildFrames::Next):
1189         (EnumChildFrames::Skip):
1190         (EnumChildFrames::Reset):
1191         (EnumChildFrames::Clone):
1192         (WebFrame::childFrames):
1193         (WebFrame::initWithWebFrameView):
1194         * WebFrame.h:
1195         * WebHistoryItem.cpp:
1196         (WebHistoryItem::icon):
1197         * WebHistoryItem.h:
1198         * WebIconDatabase.cpp:
1199         (WebIconDatabase::iconForURL):
1200         (WebIconDatabase::defaultIconWithSize):
1201         * WebIconDatabase.h:
1202         * WebInspector/WebInspector.cpp:
1203         (WebInspector::WebInspector):
1204         (WebInspector::show):
1205         (WebInspector::onDestroy):
1206         (WebInspector::onSize):
1207         * WebInspector/WebInspector.h:
1208         (WebInspector::didReceiveIcon):
1209         (WebInspector::webViewFirstResponder):
1210         (WebInspector::makeFirstResponder):
1211         (WebInspector::contextMenuItemsForElement):
1212         (WebInspector::trackCustomPopupMenu):
1213         (WebInspector::addCustomMenuDrawingData):
1214         (WebInspector::cleanUpCustomMenuDrawingData):
1215         * WebKit.vcproj/Interfaces.vcproj:
1216         * WebKit.vcproj/WebKit.def:
1217         * WebKit.vcproj/WebKit.vcproj:
1218         * WebKit.vcproj/WebKitGUID.vcproj:
1219         * WebKit.vcproj/WebKit_debug.def:
1220         * WebKitClassFactory.cpp:
1221         (WebKitClassFactory::CreateInstance):
1222         * WebKitDLL.cpp:
1223         (DllGetClassObject):
1224         (DllUnregisterServer):
1225         (DllRegisterServer):
1226         (RunAsLocalServer):
1227         * WebKitStatistics.cpp:
1228         * WebScrollBar.cpp:
1229         (WebScrollBar::init):
1230         (WebScrollBar::handleMouseEvent):
1231         * WebScrollBar.h:
1232         * WebView.cpp:
1233         (WebView::WebView):
1234         (WebView::~WebView):
1235         (WebView::handleContextMenuEvent):
1236         (WebView::onInitMenuPopup):
1237         (WebView::onUninitMenuPopup):
1238         (WebViewWndProc):
1239         (WebView::QueryInterface):
1240         (WebView::MIMETypesShownAsHTML):
1241         (WebView::setHostWindow):
1242         (WebView::hostWindow):
1243         (WebView::generateSelectionImage):
1244         (WebView::pasteboardTypesForSelection):
1245         (WebView::pasteboardTypesForElement):
1246         (WebView::mainFrameIcon):
1247         (WebView::canMakeTextStandardSize):
1248         (WebView::viewWindow):
1249         * WebView.h:
1250
1251 2007-05-11  Adele Peterson  <adele@apple.com>
1252
1253         Build fix.
1254
1255         * WebView.cpp: (WebView::selectionImageRect):
1256
1257 2007-05-10  Geoffrey Garen  <ggaren@apple.com>
1258
1259         Reviewed by Darin Adler.
1260         
1261         "IconDatabase::sharedIconDatabase()" => "iconDatabase()" for terseness.
1262
1263 2007-05-10  Maciej Stachowiak  <mjs@apple.com>
1264
1265         Reviewed by Oliver.
1266
1267         - WebKitWin part of fix for:
1268         <rdar://problem/5063277> blank screen after login to Citibank Online (accessing document before frame starts loading cancels load)
1269         <rdar://problem/5159541> REGRESSION (r20972): Wall Street Journal pages replaced by advertisements (13465)
1270
1271         The basic approach is to have Frames start out containing an empty document instead of absolutely nothing,
1272         so there is no need to initialize them on demand. Various side effects of that cause both of these bugs.
1273         
1274         However, this caused many regressions so I had to fix the fallout.
1275
1276         * WebFrame.cpp:
1277         (WebFrame::createFrame): init frame
1278         * WebView.cpp:
1279         (WebView::initWithFrame): init frame
1280         (WebView::stringByEvaluatingJavaScriptFromString): don't create empty document
1281
1282 2007-05-08  Steve Falkenburg  <sfalken@apple.com>
1283
1284         Reviewed by Darin, Oliver.
1285         
1286         Added UI_STRING versions of localized WebCore strings.
1287
1288         * English.lproj/Localizable.strings: Updated.
1289         * English.lproj/StringsNotToBeLocalized.txt: Updated.
1290         * WebCoreLocalizedStrings.cpp: Added.
1291         (WebCore::searchableIndexIntroduction):
1292         (WebCore::submitButtonDefaultLabel):
1293         (WebCore::inputElementAltText):
1294         (WebCore::resetButtonDefaultLabel):
1295         (WebCore::fileButtonChooseFileLabel):
1296         (WebCore::fileButtonNoFileSelectedLabel):
1297         (WebCore::contextMenuItemTagOpenLinkInNewWindow):
1298         (WebCore::contextMenuItemTagDownloadLinkToDisk):
1299         (WebCore::contextMenuItemTagCopyLinkToClipboard):
1300         (WebCore::contextMenuItemTagOpenImageInNewWindow):
1301         (WebCore::contextMenuItemTagDownloadImageToDisk):
1302         (WebCore::contextMenuItemTagCopyImageToClipboard):
1303         (WebCore::contextMenuItemTagOpenFrameInNewWindow):
1304         (WebCore::contextMenuItemTagCopy):
1305         (WebCore::contextMenuItemTagGoBack):
1306         (WebCore::contextMenuItemTagGoForward):
1307         (WebCore::contextMenuItemTagStop):
1308         (WebCore::contextMenuItemTagReload):
1309         (WebCore::contextMenuItemTagCut):
1310         (WebCore::contextMenuItemTagPaste):
1311         (WebCore::contextMenuItemTagNoGuessesFound):
1312         (WebCore::contextMenuItemTagIgnoreSpelling):
1313         (WebCore::contextMenuItemTagLearnSpelling):
1314         (WebCore::contextMenuItemTagSearchWeb):
1315         (WebCore::contextMenuItemTagLookUpInDictionary):
1316         (WebCore::contextMenuItemTagOpenLink):
1317         (WebCore::contextMenuItemTagIgnoreGrammar):
1318         (WebCore::contextMenuItemTagSpellingMenu):
1319         (WebCore::contextMenuItemTagCheckSpelling):
1320         (WebCore::contextMenuItemTagCheckSpellingWhileTyping):
1321         (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
1322         (WebCore::contextMenuItemTagFontMenu):
1323         (WebCore::contextMenuItemTagBold):
1324         (WebCore::contextMenuItemTagItalic):
1325         (WebCore::contextMenuItemTagUnderline):
1326         (WebCore::contextMenuItemTagOutline):
1327         (WebCore::contextMenuItemTagWritingDirectionMenu):
1328         (WebCore::contextMenuItemTagDefaultDirection):
1329         (WebCore::contextMenuItemTagLeftToRight):
1330         (WebCore::contextMenuItemTagRightToLeft):
1331         (WebCore::contextMenuItemTagShowSpellingPanel):
1332         (WebCore::searchMenuNoRecentSearchesText):
1333         (WebCore::searchMenuRecentSearchesText):
1334         (WebCore::searchMenuClearRecentSearchesText):
1335         (WebCore::AXWebAreaText):
1336         (WebCore::AXLinkText):
1337         (WebCore::AXListMarkerText):
1338         (WebCore::AXImageMapText):
1339         (WebCore::AXHeadingText):
1340         * WebKit.vcproj/WebKit.vcproj: Added WebCoreLocalizedStrings.cpp, reorganized other files a bit.
1341
1342 2007-05-08  Steve Falkenburg  <sfalken@apple.com>
1343
1344         Reviewed by Ada.
1345         
1346         Update editing delegate
1347
1348         * Interfaces/IWebEditingDelegate.idl:
1349         * WebEditorClient.cpp:
1350         (WebEditorClient::updateSpellingUIWithGrammarString):
1351         * WebEditorClient.h:
1352
1353 2007-05-07  Steve Falkenburg  <sfalken@apple.com>
1354
1355         Reviewed by Darin.
1356
1357         Fix typo in prefs code.       
1358
1359         * WebPreferences.cpp:
1360         (WebPreferences::preferencesPath): Fix typo in error handling.
1361
1362 2007-05-04  Steve Falkenburg  <sfalken@apple.com>
1363
1364         Reviewed by Darin.
1365         
1366         Fix crash when using "check spelling while typing".
1367
1368         * WebView.cpp:
1369         (WebView::preflightSpellChecker): Set delegate static global for use in spell checker init.
1370
1371 2007-05-03  Steve Falkenburg  <sfalken@apple.com>
1372
1373         Reviewed by Ada, Oliver.
1374         
1375         Checkpoint:
1376         <rdar://problem/4602372> Spelling
1377         <rdar://problem/4769763> Spell checking engine support        
1378
1379         * Interfaces/IWebEditingDelegate.idl: Add userDescription parameter.
1380         * WebEditorClient.cpp:
1381         (WebEditorClient::updateSpellingUIWithGrammarString): Set user description for spelling errors.
1382         * WebEditorClient.h:
1383         * WebView.cpp:
1384         (WebView::replaceSelectionWithText): Implemented.
1385
1386 2007-05-01  Steve Falkenburg  <sfalken@apple.com>
1387
1388         Reviewed by Oliver.
1389         
1390         Fix usage errors in COM enumeration.
1391
1392         * WebEditorClient.cpp:
1393         (WebEditorClient::checkGrammarOfString): Call Next correctly.
1394         (WebEditorClient::getGuessesForWord): Call Next correctly.
1395
1396 2007-04-30  Alice Liu  <alice.liu@apple.com>
1397
1398         Reviewed by Adam.
1399
1400         Fixed <rdar://5126201> crash closing tab when the two following tabs are empty.
1401         Basically this fix involved one thing, which lead to another thing.  First, the crash
1402         was fixed by moving the call to webView->close from SearchableWebView::onDestroy to
1403         WebViewWndProc when WM_DESTROY message is processed.  We now want only WebKit handling
1404         the closure of a WebView, so all calls to WebView::close have been removed, save for
1405         the one call in WebViewWndProc.
1406
1407         * Interfaces/IWebView.idl:
1408         removed close() from public interface
1409         * WebInspector/WebInspector.cpp:
1410         (WebInspector::onDestroy):
1411         removed call to close()
1412         * WebView.cpp:
1413         (WebView::~WebView):
1414         move the deleting of m_page down a bit to avoid a crash 
1415         (WebView::close):
1416         changed from public API to just a public function
1417         (WebViewWndProc):
1418         webView->close() was moved here from SearchableWebView::onDestroy
1419         * WebView.h:
1420         changed close() to a public function not exposed in the WebKit interface
1421
1422 2007-04-24  Steve Falkenburg  <sfalken@apple.com>
1423
1424         Reviewed by Darin, Oliver.
1425         
1426         Checkpoint:
1427         <rdar://problem/4602372> Spelling
1428         <rdar://problem/4769763> Spell checking engine support
1429
1430         * WebEditorClient.cpp:
1431         (WebEditorClient::isContinuousSpellCheckingEnabled):
1432         (WebEditorClient::toggleContinuousSpellChecking):
1433         (WebEditorClient::isGrammarCheckingEnabled):
1434         (WebEditorClient::toggleGrammarChecking):
1435         (initViewSpecificSpelling):
1436         (WebEditorClient::spellCheckerDocumentTag):
1437         (WebEditorClient::ignoreWordInSpellDocument):
1438         (WebEditorClient::learnWord):
1439         (WebEditorClient::checkSpellingOfString):
1440         (WebEditorClient::checkGrammarOfString):
1441         (WebEditorClient::udpateSpellingUIWithGrammarString):
1442         (WebEditorClient::updateSpellingUIWithMisspelledWord):
1443         (WebEditorClient::showSpellingUI):
1444         (WebEditorClient::spellingUIIsShowing):
1445         (WebEditorClient::getGuessesForWord):
1446         * WebPreferences.h:
1447
1448 2007-04-20  Ada Chan  <adachan@apple.com>
1449
1450         Reviewed by Steve and Oliver.
1451         
1452         Implemented some DOM methods I need to support password input and textarea in 
1453         WebView-based edit fields in the app.
1454
1455         * DOMCSSClasses.cpp:
1456         (DOMCSSStyleDeclaration::setCssText): added implementation
1457         * DOMCoreClasses.cpp:
1458         (DOMDocument::createElement): ditto
1459         * DOMHTMLClasses.cpp:
1460         (DOMHTMLInputElement::setType): ditto
1461         (DOMHTMLTextAreaElement::value): ditto
1462         (DOMHTMLTextAreaElement::setValue): ditto
1463         (DOMHTMLTextAreaElement::select): ditto
1464         * Interfaces/IWebUIDelegatePrivate.idl: added a new method webViewGetDlgCode() that client
1465         can implement if it wants to handle keypresses themselves rather than letting the system 
1466         interpret certain keys as dialog box navigation keys.
1467         * WebKitGraphics.cpp:
1468         (DrawTextAtPoint): handle drawing text as password
1469         * WebKitGraphics.h:
1470         * WebView.cpp:
1471         Added Copy, Cut, and Paste to the keyEntries.
1472         (WebViewWndProc): added code to handle WM_GETDLGCODE.  Calls IWebUIDelegatePrivate::webViewGetDlgCode()
1473         if available to see if the client wants to handle it.
1474
1475 2007-04-18  Adam Roben  <aroben@apple.com>
1476
1477         Reviewed by Steve.
1478
1479         Make development builds use the same CLSIDs as archive builds, and get
1480         rid of the now-unused set of CLSIDs.
1481
1482         * Interfaces/WebKit.idl: Use the archive build CLSIDs if we're not
1483         doing a production build.
1484         * WebKit.vcproj/Interfaces.vcproj: Don't define __ARCHIVE_BUILD__
1485         because it's not used anymore.
1486
1487 2007-04-18  Adam Roben  <aroben@apple.com>
1488
1489         Reviewed by Steve.
1490
1491         Use different ProgIDs for production builds.
1492
1493         * ProgIDMacros.h: Added.
1494         * WebKit.vcproj/WebKit.vcproj: Defined the __BUILDBOT__ macro and added
1495         a new header which is copied in the post-build step.
1496         * WebKitDLL.cpp: Macro-ized the declaration of the registry keys to
1497         install.
1498
1499 2007-04-16  Adam Roben  <aroben@apple.com>
1500
1501         Rubberstamped by Steve.
1502
1503         * WebKit.vcproj/WebKit.sln: Removed the Debug_Internal configuration.
1504
1505 2007-04-16  Adam Roben  <aroben@apple.com>
1506
1507         Reviewed by Steve.
1508
1509         Removed the pre-link build step, and removed registration of WebKit.dll
1510         from the post-build step.
1511
1512         * WebKit.vcproj/WebKit.vcproj:
1513
1514 2007-04-16  Adam Roben  <aroben@apple.com>
1515
1516         * WebKit.vcproj/WebKit.sln: Added WTF to the solution.
1517
1518 2007-04-16  Steve Falkenburg  <sfalken@apple.com>
1519
1520         Reviewed by Adam.
1521         
1522         Visual Studio Express compatibility for WebKit build (except for DRT)
1523
1524         * WebDragClient.cpp: Removed unused header (atlsafe.h)
1525         * WebKit.vcproj/WebKit.rc: Removed afxres.h and related code
1526         * WebKit.vcproj/WebKit.sln: Don't use a sln folder - they aren't supported by express
1527         * WebKit.vcproj/WebKit.vcproj: Add explicit lib references for Windows system libs (VS express doesn't include these)
1528         * WebView.cpp: Removed unused header (atldef.h)
1529
1530 2007-04-16  Adam Roben  <aroben@apple.com>
1531
1532         Merge in r20872.
1533
1534         * WebInspector/webInspector/inspector.js:
1535         * WebInspector/webInspector/treeoutline.js:
1536
1537 2007-04-16  Adam Roben  <aroben@apple.com>
1538
1539         Merge in r20861.
1540
1541         * WebInspector/webInspector/inspector.js:
1542         * WebInspector/webInspector/treeoutline.js:
1543
1544 2007-04-16  Adam Roben  <aroben@apple.com>
1545
1546         Merge in r20845.
1547
1548         * WebInspector/webInspector/inspector.js:
1549
1550 2007-04-16  Adam Roben  <aroben@apple.com>
1551
1552         Merge in r20844.
1553
1554         * WebInspector/webInspector/inspector.js:
1555
1556 2007-04-16  Adam Roben  <aroben@apple.com>
1557
1558         Merge in r20843.
1559
1560         * WebInspector/webInspector/inspector.js:
1561         * WebInspector/webInspector/scrollarea.js:
1562         * WebInspector/webInspector/scrollbar.js:
1563         * WebInspector/webInspector/utilities.js:
1564
1565 2007-04-16  Adam Roben  <aroben@apple.com>
1566
1567         Merge in r20842.
1568
1569         * WebInspector/webInspector/inspector.html:
1570         * WebInspector/webInspector/inspector.js:
1571         * WebInspector/webInspector/utilities.js: Added.
1572
1573 2007-04-16  Adam Roben  <aroben@apple.com>
1574
1575         Merge in r20840.
1576
1577         * WebInspector/webInspector/inspector.html:
1578         * WebInspector/webInspector/inspector.js:
1579         * WebInspector/webInspector/treeoutline.js: Added.
1580
1581 2007-04-14  Adam Roben  <aroben@apple.com>
1582
1583         * WebKit.vcproj/WebKitGUID.vcproj: Need to use WebKitConfigSuffix
1584         instead of ConfigSuffix now.
1585
1586 2007-04-14  Adam Roben  <aroben@apple.com>
1587
1588         * WebKit.vcproj/WebKit.submit.sln: Use the Debug_Internal configuration
1589         when B&I builds Debug.
1590
1591 2007-04-12  Steve Falkenburg  <sfalken@apple.com>
1592
1593         Reviewed by Geoff, Adam.
1594         
1595         Changes required for search history content.
1596
1597         * Interfaces/IWebFramePrivate.idl:
1598         * WebFrame.cpp:
1599         (WebFrame::isFrameSet): Added
1600         (WebFrame::string): Added
1601         * WebFrame.h:
1602
1603 2007-04-12  Adam Roben  <aroben@apple.com>
1604
1605         Rubberstamped by Steve.
1606
1607         Copied WebKit.sln to WebKit.submit.sln, and added missing projects to
1608         WebKit.sln so that opensource contributors can use it to build a
1609         working WebKit.
1610
1611         * WebKit.vcproj/WebKit.make: Changed to use WebKit.submit.sln.
1612         * WebKit.vcproj/WebKit.sln: Added JavaScriptCore, WebCore,
1613         DumpRenderTree projects.
1614         * WebKit.vcproj/WebKit.submit.sln: Added.
1615
1616 2007-04-12  Adam Roben  <aroben@apple.com>
1617
1618         Reviewed by Steve.
1619
1620         <rdar://problem/5131565> Need to be able to use debug WebKit with
1621         release Safari.
1622
1623         Added a new configuration to WebKit.vcproj called Debug_Internal to be
1624         used by Apple internal builds. The Debug configuration is now meant to
1625         be used by opensource builds, and will always link against release
1626         versions of CF, CFNet, CG, etc. Debug_Internal is identical to Debug
1627         except for the property sheet it uses, and the Debug configuration
1628         doesn't register WebKit_debug.dll when finished.
1629
1630         We now have two macros, $(WebKitConfigSuffix) and
1631         $(LibraryConfigSuffix). WebKitConfigSuffix is used for WebKit projects,
1632         and is "_debug" for both Debug and Debug_Internal. LibraryConfigSuffix
1633         is used for external projects, and is "" for Debug and "_debug" for
1634         Debug_Internal.
1635
1636         * WebKit.vcproj/WebKit.vcproj:
1637         * WebKit.vcproj/debug.vsprops:
1638         * WebKit.vcproj/debug_internal.vsprops: Added.
1639         * WebKit.vcproj/release.vsprops:
1640
1641 2007-04-12  John Sullivan  <sullivan@apple.com>
1642
1643         Reviewed by Anders
1644
1645         * Interfaces/IWebUIDelegate.idl:
1646         added new PDF-related context menu items to enum to keep it in sync with WebCore
1647
1648 2007-04-12  Mark Rowe  <mrowe@apple.com>
1649
1650         Not reviewed.  Internal counterpart to open-source r20856.
1651
1652         * WebChromeClient.cpp:
1653         (WebChromeClient::createWindow):
1654         (WebChromeClient::createModalDialog):
1655         * WebChromeClient.h:
1656
1657 2007-04-11  Ada Chan  <adachan@apple.com>
1658
1659         Reviewed by Steve.
1660         
1661         Implemented WebHistoryItem::originalURLString().  Added parameter checks to other methods.
1662
1663         * WebHistoryItem.cpp:
1664         (WebHistoryItem::originalURLString):
1665         (WebHistoryItem::URLString):
1666         (WebHistoryItem::title):
1667         (WebHistoryItem::lastVisitedTimeInterval):
1668
1669 2007-04-10  Brady Eidson  <beidson@apple.com>
1670
1671         Reviewed by Darin
1672
1673         <rdar://problem/4887095> - PageCache and PageState should be combined
1674
1675         Basically updated client methods for the new names and signatures 
1676
1677         * WebFrame.cpp:
1678         (WebFrame::loadedFromCachedPage):
1679         (WebFrame::setDocumentViewFromCachedPage):
1680         (WebFrame::saveDocumentViewToCachedPage):
1681         * WebFrame.h:
1682
1683 2007-04-10  Adam Roben  <aroben@apple.com>
1684
1685         Reviewed by Anders.
1686
1687         Fix <rdar://problem/5119803> Web Inspector has no options menu
1688
1689         * WebInspector/WebInspector.cpp:
1690         (interpreterForFrame): Added.
1691         (WebInspector::showOptionsMenu): Implemented.
1692         (WebInspector::onCommand): Added.
1693         (WebInspector::toggleIgnoreWhitespace): Implemented.
1694         (WebInspector::toggleShowUserAgentStyles): Implemented.
1695         (WebInspectorWndProc): Added case for WM_COMMAND.
1696         * WebInspector/WebInspector.h:
1697
1698 2007-04-09  Anders Carlsson  <andersca@apple.com>
1699
1700         Reviewed by Adam.
1701
1702         <rdar://problem/5062624>
1703         No prompt to install QT for pages with uninstalled QT plug-in.
1704         
1705         * CFDictionaryPropertyBag.cpp:
1706         (CFDictionaryPropertyBag::Read):
1707         (CFDictionaryPropertyBag::Write):
1708         Use LPCOLESTRToCFStringRef here since the property names aren't BSTRs.
1709         
1710         * Interfaces/IWebError.idl:
1711         Add user info keys.
1712         
1713         * MarshallingHelpers.cpp:
1714         (MarshallingHelpers::LPCOLESTRToCFStringRef):
1715         * MarshallingHelpers.h:
1716         New function.
1717         
1718         * WebError.cpp:
1719         (WebError::WebError):
1720         (WebError::createInstance):
1721         Take a property bag.
1722         
1723         (WebError::userInfo):
1724         Return the property bag.
1725         
1726         * WebFrame.cpp:
1727         (WebFrame::createPlugin):
1728         If the plug-in wasn't found or failed to load, create a WebError with the right user info and
1729         call IWebResourceLoadDelegate::plugInFailedWithError.
1730
1731 2007-04-09  Brady Eidson  <beidson@apple.com>
1732
1733         Build Fix
1734
1735         * WebContextMenuClient.cpp:
1736         (WebContextMenuClient::searchWithGoogle): userGesture is true
1737
1738 2007-04-09  Timothy Hatcher  <timothy@apple.com>
1739
1740         Merge in r20810.
1741
1742         <rdar://problem/5121757> WebInspector focuses elements on mouse up instead of mouse down
1743
1744         Make selecting a tree node happen on mousedown to match the NSOutlineView behavior.
1745         Also makes selecting rows in the style pane happen on mousedown for consistency.
1746
1747         * WebInspector/webInspector/inspector.js:
1748
1749 2007-04-09  Adam Roben  <aroben@apple.com>
1750
1751         Fixed copyrights.
1752
1753         * WebInspector/WebInspector.cpp:
1754         * WebInspector/WebInspector.h:
1755
1756 2007-04-09  Adam Roben  <aroben@apple.com>
1757
1758         Reviewed by Oliver.
1759
1760         Fix two Web Inspector bugs:
1761         - The WebView wasn't focused when the inspector first appeared.
1762         - Resizing the upper pane did not resize the whole window.
1763
1764         * WebInspector/WebInspector.cpp:
1765         (WebInspector::show): Focus the WebView.
1766         (WebInspector::setFrame): Implemented.
1767         (WebInspector::webViewFrame): Implemented.
1768         * WebInspector/WebInspector.h:
1769
1770 2007-04-09  Adam Roben  <aroben@apple.com>
1771
1772         * WebInspector/WebInspector.cpp:
1773         (WebInspector::WebInspector): Removed two fixed FIXMEs and some
1774         commented-out code.
1775
1776 2007-04-08  Adam Roben  <aroben@apple.com>
1777
1778         When does "merge" != "merge"? When you make the change yourself
1779         pre-emptively and make a typo.
1780
1781         * WebInspector/webInspector/inspector.js:
1782
1783 2007-04-08  Adam Roben  <aroben@apple.com>
1784
1785         Merge in r20800.
1786
1787         * WebInspector/webInspector/inspector.js:
1788
1789 2007-04-08  Adam Roben  <aroben@apple.com>
1790
1791         Merge in r20797.
1792
1793         * WebInspector/webInspector/inspector.js:
1794
1795 2007-04-08  Adam Roben  <aroben@apple.com>
1796
1797         Merge in r20796.
1798
1799         * WebInspector/webInspector/inspector.js:
1800
1801 2007-04-08  Adam Roben  <aroben@apple.com>
1802
1803         Reviewed by Anders.
1804
1805         <rdar://problem/5119804> Web Inspector isn't resizable
1806         <rdar://problem/5119805> Can't move Web Inspector
1807
1808         * WebInspector/WebInspector.cpp:
1809         (WebInspectorPrivate::WebInspectorPrivate):
1810         (WebInspector::WebInspector): Subclass the WebView so we can intercept
1811         its messages.
1812         (WebInspector::onDestroy): Undo the subclassing.
1813         (WebInspector::handleMessageSentToWebView): Added.
1814         (WebInspector::onLButtonDown): Added.
1815         (WebInspector::onLButtonUp): Added.
1816         (WebInspector::onMouseMove): Added.
1817         (WebInspectorWndProc): Added cases for mouse messages.
1818         (SubclassedWebViewWndProc): Added.
1819         * WebInspector/WebInspector.h:
1820
1821 2007-04-08  Adam Roben  <aroben@apple.com>
1822
1823         Merge in r20793.
1824
1825         * WebInspector/webInspector/AppleScrollArea.js: Removed.
1826         * WebInspector/webInspector/AppleScrollbar.js: Removed.
1827         * WebInspector/webInspector/Images/resize.png: Added.
1828         * WebInspector/webInspector/inspector.css:
1829         * WebInspector/webInspector/inspector.html:
1830         * WebInspector/webInspector/inspector.js:
1831         * WebInspector/webInspector/scrollarea.js: Added.
1832         * WebInspector/webInspector/scrollbar.js: Added.
1833
1834 2007-04-08  Adam Roben  <aroben@apple.com>
1835
1836         Merge in r20792.
1837
1838         * WebInspector/webInspector/inspector.js:
1839
1840 2007-04-08  Adam Roben  <aroben@apple.com>
1841
1842         Merge in r20791.
1843
1844         * WebInspector/webInspector/inspector.js:
1845
1846 2007-04-08  Adam Roben  <aroben@apple.com>
1847
1848         Merge in r20789.
1849
1850         * WebInspector/webInspector/inspector.js:
1851
1852 2007-04-08  Adam Roben  <aroben@apple.com>
1853
1854         Build fix.
1855
1856         * WebInspector/WebInspector.cpp:
1857
1858 2007-04-07  Adam Roben  <aroben@apple.com>
1859
1860         Reviewed by Oliver.
1861
1862         <rdar://problem/4769828> Web Inspector
1863
1864         * WebInspector/WebInspector.cpp: Renamed from WebInspector.m. Ported
1865         Mac code. Some parts are left commented out to aid later
1866         implementation.
1867         * WebInspector/WebInspector.h: Ditto.
1868
1869         * DOMCoreClasses.cpp: Added IID_DOMNode.
1870         (DOMNode::QueryInterface): Added case for IID_DOMNode.
1871         (DOMNode::isSameNode): Implemented.
1872         * DOMCoreClasses.h: Added IID_DOMNode.
1873         (DOMNode::node): Added.
1874         * English.lproj/Localizable.strings: Updated for "Inspect Element".
1875         * WebContextMenuClient.cpp:
1876         (WebContextMenuClient::getCustomMenuFromDefaultItems): Add the "Inspect
1877         Element" item.
1878         * WebFrame.cpp:
1879         (WebFrame::addInspector): Stubbed out.
1880         (WebFrame::removeInspector): Ditto.
1881         * WebFrame.h: Added declarations.
1882         * WebKit.resources/Info.plist: Added. This was needed so that the
1883         WebKit bundle would have a bundle identifier.
1884         * WebKit.vcproj/WebKit.vcproj: Added new files to project, and modified
1885         the post-build step to copy Info.plist and everything in
1886         WebInspector/webInspector to WebKit.resources.
1887         * WebView.cpp:
1888         (WebView::performContextMenuAction): Added case for the Inspect Element item.
1889         (WebView::inspectElement): Added.
1890         * WebView.h: Added declaration.
1891
1892 2007-04-07  Adam Roben  <aroben@apple.com>
1893
1894         Forked most of the WebInspector directory from
1895         r20780 of branches/WebInspectorRefresh/WebKit/WebInspector.
1896
1897         * WebInspector/WebInspector.h: Added.
1898         * WebInspector/WebInspector.m: Added.
1899         (+[WebInspector sharedWebInspector]):
1900         (-[WebInspector init]):
1901         (-[WebInspector initWithWebFrame:]):
1902         (-[WebInspector dealloc]):
1903         (-[WebInspector window]):
1904         (-[WebInspector windowWillClose:]):
1905         (-[WebInspector showWindow:]):
1906         (-[WebInspector setWebFrame:]):
1907         (-[WebInspector webFrame]):
1908         (-[WebInspector setRootDOMNode:]):
1909         (-[WebInspector rootDOMNode]):
1910         (-[WebInspector setFocusedDOMNode:]):
1911         (-[WebInspector focusedDOMNode]):
1912         (-[WebInspector setSearchQuery:]):
1913         (-[WebInspector searchQuery]):
1914         (-[WebInspector showOptionsMenu]):
1915         (-[WebInspector _toggleIgnoreWhitespace:]):
1916         (-[WebInspector _toggleShowUserAgentStyles:]):
1917         (-[WebInspector _highlightNode:]):
1918         (-[WebInspector _nodeHighlightExpired:]):
1919         (-[WebInspector _update]):
1920         (-[WebInspector _updateRoot]):
1921         (-[WebInspector _updateSystemColors]):
1922         (-[WebInspector _applicationWillResignActive]):
1923         (-[WebInspector _applicationDidBecomeActive]):
1924         (-[WebInspector _webFrameDetached:]):
1925         (+[WebInspector isSelectorExcludedFromWebScript:]):
1926         (+[WebInspector webScriptNameForSelector:]):
1927         (+[WebInspector isKeyExcludedFromWebScript:]):
1928         (-[WebInspector inspectedWebViewProgressFinished:]):
1929         (-[WebInspector webView:didFinishLoadForFrame:]):
1930         (-[WebInspector webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
1931         (-[WebInspector webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
1932         (-[WebInspector webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
1933         (-[WebInspectorPrivate dealloc]):
1934         (-[DOMNode _isAncestorOfNode:]):
1935         * WebInspector/webInspector/AppleScrollArea.js: Added.
1936         * WebInspector/webInspector/AppleScrollbar.js: Added.
1937         * WebInspector/webInspector/Images/button.png: Added.
1938         * WebInspector/webInspector/Images/buttonDivider.png: Added.
1939         * WebInspector/webInspector/Images/buttonPressed.png: Added.
1940         * WebInspector/webInspector/Images/close.png: Added.
1941         * WebInspector/webInspector/Images/closePressed.png: Added.
1942         * WebInspector/webInspector/Images/downTriangle.png: Added.
1943         * WebInspector/webInspector/Images/menu.png: Added.
1944         * WebInspector/webInspector/Images/menuPressed.png: Added.
1945         * WebInspector/webInspector/Images/popup.png: Added.
1946         * WebInspector/webInspector/Images/popupPressed.png: Added.
1947         * WebInspector/webInspector/Images/rightTriangle.png: Added.
1948         * WebInspector/webInspector/Images/scrollThumbBottom.png: Added.
1949         * WebInspector/webInspector/Images/scrollThumbMiddle.png: Added.
1950         * WebInspector/webInspector/Images/scrollThumbTop.png: Added.
1951         * WebInspector/webInspector/Images/scrollTrackBottom.png: Added.
1952         * WebInspector/webInspector/Images/scrollTrackMiddle.png: Added.
1953         * WebInspector/webInspector/Images/scrollTrackTop.png: Added.
1954         * WebInspector/webInspector/Images/upTriangle.png: Added.
1955         * WebInspector/webInspector/inspector.css: Added.
1956         * WebInspector/webInspector/inspector.html: Added.
1957         * WebInspector/webInspector/inspector.js: Added.
1958
1959 2007-04-06  Dave Hyatt  <hyatt@apple.com>
1960
1961         Internal side of fix for bug 13274.
1962
1963         Reviewed by olliej
1964
1965         * Interfaces/IWebScrollBarPrivate.idl:
1966         * WebScrollBar.cpp:
1967         * WebScrollBar.h:
1968         * WebView.cpp:
1969         (WebView::handleMouseEvent):
1970
1971 2007-04-04  Oliver Hunt  <oliver@apple.com>
1972
1973         Reviewed by Ada.
1974         
1975         Fix <rdar://problem/5111027> Dragging a link on page
1976         shows URL thumbnail as nearly-transparent instead 
1977         semi-transparent
1978
1979         Error in createDragImageForLink led me to get wrong 
1980         maximum drag image size, now logic and maximum drag 
1981         image size corrected.
1982
1983         * WebDragClient.cpp:
1984         (WebDragClient::createDragImageForLink):
1985
1986 2007-04-04  Adam Roben  <aroben@apple.com>
1987
1988         Release build fix for TestNetscapePlugin.
1989
1990         * WebKit.vcproj/WebKit.vcproj: Make the Release post-build step the
1991         same as the Debug one so that the npapi headers get copied.
1992
1993 2007-04-03  Adam Roben  <aroben@apple.com>
1994
1995         Reviewed by Anders.
1996
1997         WebKit part of fix for <rdar://problem/5103999> All dom/svg tests are
1998         failing due to extra/missing newlines
1999
2000         * DOMCoreClasses.cpp:
2001         (DOMElement::innerText): Added.
2002         * DOMCoreClasses.h: Added declaration.
2003         * Interfaces/DOMPrivate.idl: Ditto.
2004
2005 2007-04-02  Steve Falkenburg  <sfalken@apple.com>
2006
2007         Reviewed by Darin.
2008         
2009         Expose COM class counter
2010
2011         * Interfaces/IWebKitStatistics.idl: Added comClassCount
2012         * WebKitStatistics.cpp:
2013         (WebKitStatistics::comClassCount): Added
2014         * WebKitStatistics.h:
2015
2016 2007-03-31  Steve Falkenburg  <sfalken@apple.com>
2017
2018         Reviewed by Hyatt.
2019
2020         <rdar://problem/5091159> Boomer has no bundle identifier - is the bundle correctly formed?
2021         <rdar://problem/5088764> Move the "Icon.db" file under "Local Settings"
2022
2023         * WebIconDatabase.cpp:
2024         (userIconDatabasePath): Prefer to store Icon.db file keyed off of bundle executable name
2025         * WebPreferences.cpp:
2026         (WebPreferences::preferencesPath): Prefer to store WebKit Preferences keyed off of bundle executable name
2027
2028 2007-03-30  Adele Peterson  <adele@apple.com>
2029
2030         Reviewed by Beth.
2031
2032         Fix <rdar://problem/5079824> editing/deleting/delete-by-word-001 is failing
2033
2034         * WebView.cpp: Add DeleteWordForward and DeleteWordBackward to key command table.
2035
2036 2007-03-30  Anders Carlsson  <andersca@apple.com>
2037
2038         Reviewed by Adele.
2039
2040         <rdar://problem/5101970> 
2041         Crash when submitting form, running under App Verifier
2042         
2043         * WebActionPropertyBag.cpp:
2044         (findMouseEvent):
2045         Return the right event.
2046
2047 2007-03-30  Anders Carlsson  <andersca@apple.com>
2048
2049         Reviewed by Geoff.
2050
2051         * Interfaces/IWebViewPrivate.idl:
2052         Add addAdditionalPluginPath method.
2053         
2054         * WebKit.vcproj/WebKit.vcproj:
2055         Copy NP includes so they can be included by the test plugin.
2056         
2057         * WebView.cpp:
2058         (WebView::stringByEvaluatingJavaScriptFromString):
2059         Hold JSLock while we call JSValue::getString().
2060         
2061         (WebView::addAdditionalPluginPath):
2062         * WebView.h:
2063         Implement addAdditionalPluginPath.
2064
2065 2007-03-27  Dave Hyatt  <hyatt@apple.com>
2066
2067         Enable complex text.  Selection and small-caps support are now enabled with this patch.
2068         
2069         Reviewed by aroben
2070
2071         * WebPreferences.cpp:
2072         (WebPreferences::initialize):
2073
2074 2007-03-26  Brady Eidson  <beidson@apple.com>
2075
2076         Reviewed by Ada
2077
2078         This one didn't actually have any leaks, but I just felt like doing the
2079         same style cleanup as the others :)
2080         
2081         * WebPreferences.cpp:
2082         (WebPreferences::stringValueForKey):
2083         (WebPreferences::integerValueForKey):
2084         (WebPreferences::floatValueForKey):
2085         (WebPreferences::setStringValue):
2086         (WebPreferences::setIntegerValue):
2087         (WebPreferences::save):
2088         (WebPreferences::load):
2089
2090 2007-03-26  Brady Eidson  <beidson@apple.com>
2091
2092         Reviewed by Ada
2093
2094         <rdar://5090412> - Plug CFNumberRef leaks in WebCache
2095         
2096         * WebCache.cpp:
2097         (WebCache::statistics):
2098
2099 2007-03-26  Beth Dakin  <bdakin@apple.com>
2100
2101         Reviewed by Geoff.
2102
2103         Fix build without breaking anything.
2104
2105         * WebHistory.cpp:
2106         (releaseUserInfo): Added silly void statement for now.
2107
2108 2007-03-26  Beth Dakin  <bdakin@apple.com>
2109
2110         Rubber-stamped by Brady.
2111
2112         Build fix for release build.
2113
2114         * WebHistory.cpp:
2115         (releaseUserInfo): Do not store userInfo->Release() in a local 
2116         variable since it is only used for an ASSERT.
2117
2118 2007-03-26  Steve Falkenburg  <sfalken@apple.com>
2119
2120         Reviewed by Lou.
2121         
2122         <rdar://problem/5088764> Move the "Icon.db" file under "Local Settings"
2123
2124         * WebIconDatabase.cpp:
2125         (userIconDatabasePath): Move icon database to non-roaming location
2126
2127 2007-03-25  Brady Eidson  <beidson@apple.com>
2128
2129         Reviewed by Oliver
2130         
2131         <rdar://problem/5086888> - WebHistory(Item) Leak
2132         
2133         This is a pretty thourough touchup up style and correctness that
2134         plugs at least 1 definite leak and many potential leaks with
2135         extensive use of RetainPtr and COMPtr.
2136         
2137         This should result in no change in behavior
2138
2139         * MarshallingHelpers.cpp: Add kIUnknownDictionaryValueCallBacks
2140         * MarshallingHelpers.h: Ditto
2141         
2142         * WebHistory.cpp:
2143         (createUserInfoFromArray):
2144         (createUserInfoFromHistoryItem):
2145         (releaseUserInfo):
2146         (WebHistory::WebHistory):
2147         (WebHistory::~WebHistory):
2148         (WebHistory::loadFromURL):
2149         (createHistoryListFromStream): Split of the Structured Exception
2150           Handling to a seperate function to cooperate with C++
2151         (WebHistory::loadHistoryGutsFromURL):
2152         (WebHistory::saveToURL):
2153         (WebHistory::saveHistoryGuts):
2154         (WebHistory::datesArray):
2155         (WebHistory::addItems):
2156         (WebHistory::removeItems):
2157         (WebHistory::removeAllItems):
2158         (WebHistory::orderedLastVisitedDays):
2159         (WebHistory::orderedItemsLastVisitedOnDay):
2160         (WebHistory::removeItem):
2161         (WebHistory::addItem):
2162         (WebHistory::addItemForURL):
2163         (WebHistory::itemForURLString):
2164         (WebHistory::itemForURL):
2165         (WebHistory::containsItemForURLString):
2166         (WebHistory::removeItemForURLString):
2167         (WebHistory::addItemToDateCaches):
2168         (WebHistory::removeItemFromDateCaches):
2169         (WebHistory::findIndex):
2170         (WebHistory::insertItem):
2171         (WebHistory::ageLimitDate):
2172         * WebHistory.h:
2173         
2174         * WebHistoryItem.cpp:
2175         (WebHistoryItem::dictionaryRepresentation):
2176         (WebHistoryItem::mergeAutoCompleteHints):
2177
2178 2007-03-25  Adam Roben  <aroben@apple.com>
2179
2180         Reviewed by Oliver.
2181
2182         WebKit part of <rdar://problem/5086934> DumpRenderTree doesn't support
2183         layoutTestController.queueLoad
2184
2185         * WebFrame.cpp:
2186         (WebFrame::findFrameNamed): Implemented.
2187         * WebHistoryItem.cpp:
2188         (WebHistoryItem::children): Don't increment i twice per loop!
2189
2190 2007-03-25  Adam Roben  <aroben@apple.com>
2191
2192         Build fix.
2193
2194         * WebDownload.h: Include RetainPtr from WTF.
2195
2196 2007-03-24  Steve Falkenburg  <sfalken@apple.com>
2197
2198         Build fix.
2199
2200         * WebDownload.h: Remove WebCore namespace
2201
2202 2007-03-24  Adam Roben  <aroben@apple.com>
2203
2204         Reviewed by Oliver.
2205
2206         WebKit part of <rdar://problem/5086932> DumpRenderTree doesn't support
2207         layoutTestController.dumpBackForwardList
2208
2209         * Interfaces/IWebHistoryItemPrivate.idl: Added declarations.
2210         * WebFrame.cpp:
2211         (WebFrame::childFrames): Removed unused variable.
2212         * WebHistoryItem.cpp:
2213         (WebHistoryItem::target): Implemented.
2214         (WebHistoryItem::isTargetItem): Implemented.
2215         (WebHistoryItem::children): Implemented.
2216         * WebHistoryItem.h: Added declarations.
2217
2218 2007-03-23  Brady Eidson  <beidson@apple.com>
2219
2220         Reviewed by Adam
2221         
2222         <rdar://5086194> - WebHistory overreleases a CFNumber
2223         
2224         * WebHistory.cpp:
2225         (WebHistory::loadHistoryGutsFromURL): Don't CFRelease what we didn't 
2226           legitimately get a ref for!
2227
2228 2007-03-23  Adam Roben  <aroben@apple.com>
2229
2230         Reviewed by Darin.
2231
2232         WebKit part of <rdar://problem/5084881> Add a "turn of site-specific
2233         hacks" menu item to the Debug menu
2234
2235         Added new IWebPrivate::setAllowSiteSpecificHacks SPI.
2236
2237         * Interfaces/IWebViewPrivate.idl: Added declaration.
2238         * WebView.cpp:
2239         (WebView::userAgentForKURL): Only give a site-specific UA if
2240         site-specific hacks are turned on.
2241         (WebView::setAllowSiteSpecificHacks): Added.
2242         * WebView.h:
2243         (WebView::allowSiteSpecificHacks): Added.
2244
2245 2007-03-23  Beth Dakin  <bdakin@apple.com>
2246
2247         Reviewed by Hyatt.
2248
2249         Fix for <rdar://problem/5083914> Cursor is wrong for all context 
2250         menus
2251
2252         * WebView.cpp:
2253         (WebView::handleContextMenuEvent): Set the cursor to the pointer 
2254         cursor.
2255
2256 2007-03-23  Alice Liu  <alice.liu@apple.com>
2257
2258         Reviewed by Adam.
2259
2260         Fixed <rdar://5084888> need to add flickr to spoof list in Boomer WebKit
2261
2262         * WebView.cpp:
2263         (WebView::userAgentForKURL):
2264         added flickr spoof
2265
2266 2007-03-23  Adam Roben  <aroben@apple.com>
2267
2268         Reviewed by Oliver.
2269
2270         WebKit part of <rdar://problem/5085170> DumpRenderTree doesn't print
2271         frame scroll offsets
2272
2273         Implemented some WebFrame methods to support dumping frame scroll
2274         offsets in DRT.
2275
2276         * Interfaces/IWebFrame.idl: Changed signature of IWebFrame::childFrames.
2277         * Interfaces/IWebFramePrivate.idl: Added scrollOffset declaration.
2278         * WebFrame.cpp:
2279         (WebFrame::name): Implemented.
2280         (WebFrame::childFrames): Implemented.
2281         (WebFrame::scrollOffset): Implemented.
2282         * WebFrame.h: Updated/added declarations.
2283
2284 2007-03-23  Adam Roben  <aroben@apple.com>
2285
2286         Reviewed by Oliver.
2287
2288         WebKit part of fix for <rdar://problem/4990740>.
2289
2290         Added IWebDataSourcePrivate::mainDocumentError.
2291
2292         * Interfaces/IWebDataSource.idl: Added method declaration and updated
2293         copyrights.
2294         * WebDataSource.cpp:
2295         (WebDataSource::mainDocumentError): Implemented.
2296         * WebDataSource.h: Added declaration.
2297
2298 2007-03-23  Steve Falkenburg  <sfalken@apple.com>
2299
2300         Reviewed by Adam.
2301         
2302         <rdar://problem/5083645> Spoofed UA for gmail doesn't work - should be removed
2303
2304         * WebView.cpp:
2305         (WebView::userAgentForKURL): Remove gmail spoof
2306
2307 2007-03-22  Dave Hyatt  <hyatt@apple.com>
2308
2309         Fix for <rdar://problem/5083072>.
2310
2311         Reviewed by aroben
2312   
2313         * ChangeLog:
2314         * WebFrame.cpp:
2315         (WebFrame::setPrinting):
2316         (WebFrame::spoolPages):
2317         * WebFrame.h:
2318
2319 2007-03-22  Anders Carlsson  <acarlsson@apple.com>
2320
2321         Reviewed by Maciej.
2322
2323         <rdar://problem/5082270>
2324         Crash in windows media player at MTV.COM
2325         
2326         Ignore any WM_PAINT events we get while painting.
2327         
2328         * WebView.cpp:
2329         (WebView::WebView):
2330         (WebView::updateBackingStore):
2331         (WebView::paint):
2332         (WebViewWndProc):
2333         * WebView.h:
2334         (WebView::isPainting):
2335
2336 2007-03-22  Adele Peterson  <adele@apple.com>
2337
2338         Reviewed by Anders.
2339
2340         Fix for <rdar://problem/5071358> window.open won't work with empty urls (24fun test)
2341
2342         * Interfaces/IWebURLRequest.idl:
2343         * WebMutableURLRequest.cpp: (WebMutableURLRequest::isEmpty): Added. Checks whether the ResourceRequest is empty.  On the mac,
2344           NSURLRequests created from empty ResourceRequests are nil.  We may want to consider that in the future, but there were too
2345           many places in the app that expected the IWebURLRequest to be non-null.
2346         * WebMutableURLRequest.h:
2347
2348 2007-03-22  Dave Hyatt  <hyatt@apple.com>
2349
2350         Fix for crasher in layout caused by paints that happen without layout being current.  Change to be
2351         more like the Mac and crawl the frame tree up front ensuring everyone is up to date before painting.
2352
2353         Reviewed by olliej
2354
2355         * WebFrame.cpp:
2356         (WebFrame::WebFramePrivate::m_policyFunction):
2357         (WebFrame::layoutIfNeededRecursive):
2358         * WebFrame.h:
2359         * WebView.cpp:
2360         (WebView::updateBackingStore):
2361         (WebView::paint):
2362         (WebViewWndProc):
2363
2364 2007-03-22  Ada Chan  <adachan@apple.com>
2365
2366         Reviewed by Hyatt and Alice.
2367         
2368         Changed the mouse event processing in the WebView wndproc so we actually
2369         allow a mouse event with click count > 3, which matches the mac safari behavior.
2370         
2371         Set globalPrevButton and globalPrevPoint also in mouse down.
2372
2373         * WebView.cpp:
2374         (WebView::handleMouseEvent):
2375
2376 2007-03-21  Anders Carlsson  <acarlsson@apple.com>
2377
2378         Reviewed by Adam.
2379
2380         * WebView.cpp:
2381         (WebView::initWithFrame):
2382         Remove #ifdef now that DRT no longer crashes.
2383
2384 2007-03-21  Beth Dakin  <bdakin@apple.com>
2385
2386         Reviewed by Adam.
2387
2388         <rdar://problem/5074274> right-clicking in certain iframes ends up 
2389         left-clicking, and context menu appears far away
2390
2391         * WebView.cpp:
2392         (WebView::handleContextMenuEvent): We were always calling 
2393         sendContextMenuEvent() on the main frame!! Instead, call it on the 
2394         focused or main frame.
2395
2396 2007-03-21  Adele Peterson  <adele@apple.com>
2397
2398         Reviewed by Adam.
2399         
2400         Fix for <rdar://problem/5076213> fast/forms/input-text-enter.html fails
2401         
2402         Added updateActiveState SPI for DumpRenderTree.
2403
2404         * Interfaces/IWebViewPrivate.idl:
2405         * WebView.cpp:
2406         (WebViewWndProc): Added comments where we do similar work when the webview gets and loses focus.  We should merge this logic into updateActiveState eventually.
2407         (WebView::updateActiveState):
2408         * WebView.h:
2409
2410 2007-03-19  Maciej Stachowiak  <mjs@apple.com>
2411
2412         Reviewed by Geoff and Adam.
2413
2414         - <rdar://problem/4041141> JavaScriptCore is not thread-safe on Windows
2415
2416         * WebView.cpp:
2417         (WebView::WebView): Tell JavaScriptCore what the main thread is.
2418
2419 2007-03-20  Anders Carlsson  <acarlsson@apple.com>
2420
2421         Reviewed by Adam.
2422
2423         <rdar://problem/5050512>
2424         Need invalid/expired certificate alerts
2425         
2426         Add setAllowsAnyHTTPSCertificate method to IWebMutableURLRequest and have it 
2427         call down to WebCore.
2428         
2429         * Interfaces/IWebMutableURLRequest.idl:
2430         * WebMutableURLRequest.cpp:
2431         (WebMutableURLRequest::setAllowsAnyHTTPSCertificate):
2432         * WebMutableURLRequest.h:
2433
2434 2007-03-20  Adam Roben  <aroben@apple.com>
2435
2436         Rubberstamped by Anders.
2437
2438         Workaround a CFNetwork crash that affects DRT.
2439
2440         * WebView.cpp:
2441         (WebView::initWithFrame): Commented out cookie storage initialization.
2442
2443 2007-03-20  Adam Roben  <aroben@apple.com>
2444
2445         Build fix.
2446
2447         * WebView.cpp: Added missing #include.
2448
2449 2007-03-20  Adam Roben  <aroben@apple.com>
2450
2451         Reviewed by Oliver.
2452
2453         Implemented [set]TabKeyCyclesThroughElements.
2454
2455         * Interfaces/IWebViewPrivate.idl: Added new declarations.
2456         * WebView.cpp:
2457         (WebView::setTabKeyCyclesThroughElements): Implemented.
2458         (WebView::tabKeyCyclesThroughElements): Implemented.
2459         * WebView.h: Updated.
2460
2461 2007-03-20  Dave Hyatt  <hyatt@apple.com>
2462
2463         Land advanced text code path (turned off).
2464        
2465         Reviewed by aroben
2466
2467         * WebKit.vcproj/WebKit.vcproj:
2468
2469 2007-03-20  Anders Carlsson  <acarlsson@apple.com>
2470
2471         Reviewed by Adam.
2472
2473         <rdar://problem/4921198>
2474         Cookie acceptance policy not settable
2475         
2476         * WebView.cpp:
2477         (WebView::updateWebCoreSettingsFromPreferences):
2478         Update the cookie storage accept policy.
2479         
2480         (WebView::initWithFrame):
2481         Initialize the cookie storage.
2482
2483 2007-03-19  Adam Roben  <aroben@apple.com>
2484
2485         Build fix.
2486
2487         * WebKit.vcproj/WebKitGUID.vcproj:
2488
2489 2007-03-19  Adam Roben  <aroben@apple.com>
2490
2491         Reviewed by Anders and Darin.
2492
2493         Added WebJavaScriptCollector for <rdar://problems/5071653>.
2494
2495         * Interfaces/IWebJavaScriptCollector.idl: Added.
2496         * Interfaces/WebKit.idl:
2497         * WebJavaScriptCollector.cpp: Added.
2498         (WebJavaScriptCollector::WebJavaScriptCollector):
2499         (WebJavaScriptCollector::~WebJavaScriptCollector):
2500         (WebJavaScriptCollector::createInstance):
2501         (WebJavaScriptCollector::QueryInterface):
2502         (WebJavaScriptCollector::AddRef):
2503         (WebJavaScriptCollector::Release):
2504         (WebJavaScriptCollector::collect):
2505         (WebJavaScriptCollector::collectOnAlternateThread):
2506         (WebJavaScriptCollector::objectCount):
2507         * WebJavaScriptCollector.h: Added.
2508         * WebKit.vcproj/Interfaces.vcproj: Added IWebJavaScriptCollector.idl.
2509         * WebKit.vcproj/WebKit.vcproj: Added WebJavaScriptCollector.(cpp|h).
2510         * WebKit.vcproj/WebKitGUID.vcproj: Added IWebJavaScriptCollector_i.c.
2511         * WebKitClassFactory.cpp:
2512         (WebKitClassFactory::CreateInstance): Added cases for
2513         WebJavaScriptCollector.
2514         * WebKitDLL.cpp:
2515         (DllGetClassObject): Ditto.
2516
2517 2007-03-19  Adam Roben  <aroben@apple.com>
2518
2519         Build fix.
2520
2521         * Interfaces/IWebView.idl:
2522
2523 2007-03-18  Adam Roben  <aroben@apple.com>
2524
2525         Reviewed by Hyatt.
2526
2527         Implemented getting/setting of the editing delegate (we don't actually
2528         use it for anything yet, though. See <rdar://problem/5071598>).
2529
2530         * Interfaces/IWebEditingDelegate.idl: Renamed IWebViewEditingDelegate
2531         to IWebEditingDelegate to match our other delegates.
2532         * Interfaces/IWebView.idl: Updated for rename.
2533         * WebView.cpp:
2534         (WebView::setEditingDelegate): Implemented.
2535         (WebView::editingDelegate): Ditto.
2536         * WebView.h: Updated for rename.
2537
2538 2007-03-18  Adam Roben  <aroben@apple.com>
2539
2540         Reviewed by Geoff.
2541
2542         Added IWebFramePrivate::layout to support eventSender in DRT.
2543
2544         Made IWebView inherit from IDropTarget to match Mac, and added
2545         IWebUIDelegatePrivate::doDragDrop to support drag-and-drop in DRT.
2546
2547         * Interfaces/IWebFramePrivate.idl: Added layout().
2548         * Interfaces/IWebUIDelegatePrivate.idl: Added doDragDrop().
2549         * Interfaces/IWebView.idl: Added inheritance from IDropTarget.
2550         * WebDragClient.cpp:
2551         (WebDragClient::startDrag): Call the UI delegate if possible,
2552         otherwise fallback to OLE's DoDragDrop.
2553         * WebFrame.cpp:
2554         (WebFrame::layout): Implemented.
2555         * WebFrame.h:
2556         * WebView.h:
2557
2558 2007-03-17  Adam Roben  <aroben@apple.com>
2559
2560         Reviewed by Brady.
2561
2562         Fix repro ASSERT when logging in to facebook.com.
2563
2564         * WebMutableURLRequest.cpp:
2565         (WebMutableURLRequest::valueForHTTPHeaderField): Implemented.
2566
2567 2007-03-16  Brady Eidson  <beidson@apple.com>
2568
2569         Reviewed by Oliver
2570
2571         Make the WebDownload fix a little more correct.
2572         
2573         * WebDownload.cpp:
2574         (WebDownload::init): Release the connection from the ResourceHandle after the CFURLDownload has been created
2575
2576 2007-03-16  Geoffrey Garen  <ggaren@apple.com>
2577
2578         Reviewed by Dave Hyatt.
2579         
2580         Fixed "called Frame::paint with nil renderer" console messages.
2581         You can now launch and exit the app without seeing any
2582         error messages!
2583
2584         * WebView.cpp:
2585         (WebView::paintIntoBackingStore): Only tell the FrameView to
2586         paint if it has a renderer. This isn't an issue on the Mac
2587         because we don't create a FrameView until you load a page.
2588
2589 2007-03-16  Anders Carlsson  <acarlsson@apple.com>
2590
2591         Reviewed by Adam.
2592
2593         Add setters and getters for cookie storage accept policy.
2594         
2595         * Interfaces/IWebPreferences.idl:
2596         * WebPreferenceKeysPrivate.h:
2597         * WebPreferences.cpp:
2598         (WebPreferences::initialize):
2599         (WebPreferences::cookieStorageAcceptPolicy):
2600         (WebPreferences::setCookieStorageAcceptPolicy):
2601         * WebPreferences.h:
2602
2603 2007-03-16  Anders Carlsson  <acarlsson@apple.com>
2604
2605         Reviewed by Adam and Dave Hyatt.
2606
2607         <rdar://problem/5069226>
2608         Boomer fails Acid2.
2609         
2610         Fix acid2 test.
2611         
2612         * WebFrame.cpp:
2613         (WebFrame::shouldFallBack):
2614         Implement this function.
2615
2616 2007-03-16  Ada Chan  <adachan@apple.com>
2617
2618         Reviewed by Steve.
2619         
2620         Implemented a couple of DOM methods so we can set the font-size of an element directly in the app.
2621
2622         * DOMCSSClasses.cpp:
2623         (DOMCSSStyleDeclaration::setProperty):
2624         * DOMCoreClasses.cpp:
2625         (DOMElement::style):
2626
2627 2007-03-15  Alice Liu  <alice.liu@apple.com>
2628
2629         Reviewed by Ada.
2630
2631         Fixing some leaks
2632
2633         * WebFrame.cpp:
2634         (WebFrame::dispatchDidReceiveAuthenticationChallenge):
2635         (WebFrame::dispatchDidCancelAuthenticationChallenge):
2636
2637 2007-03-15  Brady Eidson  <beidson@apple.com>
2638
2639         Reviewed by Oliver
2640
2641         CFNetwork related cleanup that was a work around for previous deficiencies in CFURLDownload
2642         This might fix some of the random crashers we see on stress testing if they end up 
2643         downloading links.
2644
2645         * WebDownload.cpp:
2646         (WebDownload::init): Release the connection from the handle so it no longer refers to it
2647         
2648 2007-03-15  Maciej Stachowiak  <mjs@apple.com>
2649
2650         Reviewed by Geoff and Steve.
2651         
2652         - fixed <rdar://problem/5029776> iBench JavaScript test slower than Opera
2653         - fixes to use FastMalloc on Windows
2654
2655         * WebKit.vcproj/WebKit.def: Add exports of WTF symbols.
2656         * WebKit.vcproj/WebKit_debug.def: ditto
2657         * WebKit.vcproj/WebKit.vcproj: Link pthreads, now needed by WTF.
2658
2659 2007-03-15  Brady Eidson  <beidson@apple.com>
2660
2661         Reviewed by Alice
2662         
2663         Due to OpenSource r20178, all of the sudden we were trying to handle page caching on Windows
2664         even though it is not hooked up yet.  The resulted in very particular cases ending up calling 
2665         clear() in FrameLoader::provisionalLoadStarted().  One such particular case was if a page *would*
2666         be "cachable" (no frames, no passwords, etc etc), and you start a download from that page.
2667         
2668         The fix for now is to manually set the pageCacheSize to 0 whenever we create new pages on Windows.
2669         This prevents the "Should I cache this page?" checking from getting far enough to clear the document.
2670         It so happens this involves exactly one line.
2671         
2672         * WebView.cpp:
2673         (WebView::initWithFrame): Set page cache size to zero on new pages, and add a fixme to remove later
2674
2675 2007-03-15  Brady Eidson  <beidson@apple.com>
2676
2677         Reviewed by Maciej
2678
2679         <rdar://problem/4429701>
2680         Implements a port blocking black list that matches Firefox's
2681         
2682         * Interfaces/IWebError.idl: Add the custom error code for blocked error
2683
2684         * WebFrame.cpp:
2685         (WebFrame::blockedError): FrameLoaderClient fill-in + a Fixme
2686         (WebFrame::interruptForPolicyChangeError): Add a Fixme for localization
2687         * WebFrame.h:
2688
2689 2007-03-15  Adam Roben  <aroben@apple.com>
2690
2691         Rubberstamped by Brady.
2692
2693         * WebKitLogging.cpp: Turn of Download logging by default.
2694
2695 2007-03-14  Ada Chan  <adachan@apple.com>
2696
2697         Reviewed by Lou.
2698
2699         Added a method in IWebViewPrivate to clear the current focus node.  This is called in the app
2700         when focus has been transferred to the address field or search field.
2701
2702         * Interfaces/IWebViewPrivate.idl:
2703         * WebView.cpp:
2704         (WebView::clearFocusNode):
2705         * WebView.h:
2706
2707 2007-03-14  Adele Peterson  <adele@apple.com>
2708
2709         Reviewed by Ada.
2710
2711         Allow empty commands to be sent by doTextFieldCommandFromEvent.  Our autocomplete code relies on this.
2712
2713         * WebEditorClient.cpp: (WebEditorClient::doTextFieldCommandFromEvent):
2714
2715 2007-03-14  Steve Falkenburg  <sfalken@apple.com>
2716
2717         <rdar://problem/5050470> Reproducible crash doing find on page at cnn.com
2718         
2719         Add frame->document() null checks in cases where frame could be a
2720         sub-frame that hasn't started loading yet.
2721
2722         * WebView.cpp:
2723         (WebView::rectsForTextMatches): Add null check
2724
2725 2007-03-14  Adele Peterson  <adele@apple.com>
2726
2727         Reviewed by Darin.
2728
2729         WebKit part of fix for <rdar://problem/5057371> REGRESSION: Shift-selection stopped working in text fields
2730
2731         This fixes doCommandBySelector to take a command string instead of a key code.
2732
2733         * Interfaces/IWebEditingDelegate.idl: Changed parameter to BSTR.
2734         * Interfaces/IWebFormDelegate.idl: ditto.
2735         * WebEditorClient.cpp:
2736         (WebEditorClient::doTextFieldCommandFromEvent): Calls doCommandBySelector with a BString that it gets from interpretKeyEvent instead of a key code.
2737         (WebEditorClient::textWillBeDeletedInTextField): Calls doCommandBySelector with a BString to represent the BackwardDelete command.
2738         (WebEditorClient::handleKeypress): Calls handleEditingKeyboardEvent with just the KeyboardEvent.
2739         * WebView.cpp: Added commands that will be used by doCommandBySelector to the table (Cancel, InsertTab, InsertBacktab, InsertNewline).
2740         (WebView::interpretKeyEvent): Added. Returns a command string for a KeyboardEvent. Removed static editCommandForKey.
2741         (WebView::handleEditingKeyboardEvent): Call Editor methods instead of calling handleTextInputEvent directly.
2742         * WebView.h:
2743
2744 2007-03-14  Administrator  <acarlsson@apple.com>
2745
2746         Build fixes.
2747         
2748         * WebDataSource.cpp:
2749         (WebDataSource::subresourceForURL):
2750         * WebKitDLL.cpp:
2751         (loadResourceIntoBuffer):
2752
2753 2007-03-12  Adele Peterson  <adele@apple.com>
2754
2755         Reviewed by Oliver.
2756
2757         WebKit part of fix for <rdar://problem/5044790> preventing default of keypress event doesn't work (affects .mac)
2758
2759         Removed special handling of the WM_CHAR message.  All this work is now done by WM_KEYDOWN, which will dispatch the keydown event, 
2760         which causes the keypress event to be dispatched, which calls WebEditorClient::handleKeyPress to do all the hard work.
2761         
2762         * WebEditorClient.cpp: (WebEditorClient::handleKeypress): Removed special call to doTextFieldCommandFromEvent since this will now 
2763         happen during normal key event processing. Call handleEditingKeyboardEvent.  Now editing actions can be prevented from the keypress event handler.
2764         * WebView.cpp:
2765         (WebView::WebView): Added m_currentCharacterCode, so we can reuse the computed code from keyDown for keyUp events.
2766         (WebView::keyUp): Renamed arguments.  Don't dispatch event for shift, ctrl, or capslock keys. Use m_currentCharacterCode when constructing the PlatformKeyboardEvent.
2767         (WebView::handleEditingKeyboardEvent): Now takes a KeyboardEvent instead of a PlatformKeyboardEvent.  If no editCommand is created
2768          from the event, then call handleTextInputEvent.
2769         (WebView::keyDown): Peek at the next message in the message loop.  If its a WM_CHAR, then get the character code and remove that message from the queue.
2770          Renamed arguments.  Don't dispatch event for shift, ctrl, or capslock keys. Set m_currentCharacterCode and use it when constructing the PlatformKeyboardEvent.
2771         (WebViewWndProc):  Removed handling of WM_CHAR, since this is now done from WM_KEYDOWN by dispatching the keydown event, which will eventually call handleKeyPress.
2772         * WebView.h: Made handleEditingKeyboardEvent public so it can be accessed from WebEditorClient.
2773
2774 2007-03-11  Oliver Hunt  <oliver@apple.com>
2775
2776         Reviewed by Adele.
2777
2778         Stubbed WebEditorClient::respondToChangedSelection
2779
2780         * WebEditorClient.cpp:
2781         (WebEditorClient::respondToChangedSelection):
2782         * WebEditorClient.h:
2783
2784 2007-03-10  Anders Carlsson <acarlsson@apple.com>
2785
2786         Reviewed by Adam.
2787
2788         * DOMCoreClasses.cpp:
2789         (DOMNode::textContent):
2790         Implement this.
2791
2792 2007-03-09  Anders Carlsson <acarlsson@apple.com>
2793
2794         Reviewed by Adam.
2795
2796         * WebURLResponse.cpp:
2797         (WebURLResponse::suggestedFilename):
2798         Get the suggested filename from the ResourceResponse object.
2799
2800 2007-03-09  Adam Roben  <aroben@apple.com>
2801
2802         Rubberstamped by Steve.
2803
2804         B&I build fix.
2805
2806         * WebKit.vcproj/WebKit.vcproj: Removed all references to iconv.
2807
2808 2007-03-08  Anders Carlsson <acarlsson@apple.com>
2809
2810         Build fix.
2811         
2812         * WebView.cpp:
2813         (WebView::isLoading):
2814
2815 2007-03-08  Anders Carlsson <acarlsson@apple.com>
2816
2817         Reviewed by Adam.
2818
2819         Implement WebView::isLoading.
2820         
2821         * WebView.cpp:
2822         (WebView::isLoading):
2823
2824 2007-03-07  Adam Roben  <aroben@apple.com>
2825
2826         Rubberstamped by Anders.
2827
2828         Return E_POINTER for null parameters.
2829
2830         * WebScrollBar.cpp:
2831         (WebScrollBar::value):
2832         (WebScrollBar::capturingMouse):
2833         (WebScrollBar::frameGeometry):
2834         (WebScrollBar::width):
2835         (WebScrollBar::height):
2836         (WebScrollBar::requestedWidth):
2837         (WebScrollBar::requestedHeight):
2838         (WebScrollBar::windowClipRect):
2839
2840 2007-03-07  Adam Roben  <aroben@apple.com>
2841
2842         Reviewed by Oliver.
2843
2844         Added requestedWidth and requestedHeight methods to WebScrollBar.
2845
2846         * Interfaces/IWebScrollBarPrivate.idl: Added new declarations.
2847         * WebScrollBar.cpp:
2848         (WebScrollBar::requestedWidth): Implemented.
2849         (WebScrollBar::requestedHeight): Implemented.
2850         * WebScrollBar.h: Added method declarations.
2851
2852 2007-03-07  Adam Roben  <aroben@apple.com>
2853
2854         Rubberstamped by Anders.
2855
2856         * WebFrame.cpp:
2857         (WebFrame::cancelledError): Use the WebURLErrorDomain constant.
2858         (WebFrame::interruptForPolicyChangeError): Use the WebKitErrorDomain constant.
2859
2860 2007-03-07  Adam Roben  <aroben@apple.com>
2861
2862         Rubberstamped by Anders.
2863
2864         Switch the definition of WebURLErrorDomain to "CFURLErrorDomain" so
2865         that we will send the right errors once <rdar://problem/5034136> is
2866         fixed.
2867
2868         * Interfaces/IWebError.idl: Changed definition.
2869
2870 2007-03-07  Adele Peterson  <adele@apple.com>
2871
2872         Build fix.
2873
2874         * WebEditorClient.cpp: (WebEditorClient::handleInputMethodKeypress):
2875
2876 2007-03-07  Adele Peterson  <adele@apple.com>
2877
2878         Reviewed by Darin.
2879
2880         WebKitWin part of fix for:
2881         http://bugs.webkit.org/show_bug.cgi?id=10871
2882         http://bugs.webkit.org/show_bug.cgi?id=12677
2883         <rdar://problem/4823129> REGRESSION: IME key events different in nightly
2884         <rdar://problem/4759563> REGRESSION: Return key is always sent when you confirm a clause in kotoeri
2885
2886         * WebEditorClient.cpp:
2887         (WebEditorClient::handleKeypress): Changed handleKeyPress to handleKeypress.
2888         (WebEditorClient::handleInputMethodKeypress): Added.
2889         * WebEditorClient.h:
2890
2891 2007-03-07  Anders Carlsson  <acarlsson@apple.com>
2892
2893         Reviewed by Adam.
2894
2895         * WebFrame.cpp:
2896         (WebFrame::makeDocumentView):
2897         Assert that frame is not null.
2898
2899 2007-03-06  Anders Carlsson  <acarlsson@apple.com>
2900
2901         Reviewed by Adam.
2902
2903         * WebFrame.cpp:
2904         (WebFrame::makeDocumentView):
2905         Call resetMultipleFormSubmissionProtection() so that submitting the same form from separate loads works.
2906
2907 2007-03-06  Brady Eidson  <beidson@apple.com>
2908
2909         Reviewed by Adam
2910
2911         Adapt to an API change in CFURLDownload
2912         
2913         * WebDownload.cpp:
2914         (WebDownload::init):
2915
2916 2007-03-06  Steve Falkenburg  <sfalken@apple.com>
2917
2918         Rubber-stamped by Adam.
2919         
2920         Fix disney.com more.  Disney redirects to disney.go.com.
2921
2922         * WebView.cpp:
2923         (WebView::userAgentForKURL): Added disney.go.com
2924
2925 2007-03-06  Adam Roben  <aroben@apple.com>
2926
2927         Reviewed by Anders.
2928
2929         Always keep rounding hacks on to be consistent.
2930
2931         * WebDragClient.cpp:
2932         (createDragImageForLink): Tell StringTruncator to keep rounding hacks on.
2933         * WebKitGraphics.cpp:
2934         (CenterTruncateStringToWidth): Ditto.
2935         (RightTruncateStringToWidth): Ditto.
2936
2937 2007-03-06  Steve Falkenburg  <sfalken@apple.com>
2938
2939         Reviewed by Adam.
2940         
2941         Allow custom user agents per site.
2942         
2943         This fixes:
2944         
2945         http://www.disney.com
2946         http://www.yahoo.com
2947         http://mail.google.com
2948         iTunes store links (w/ latest unsubmitted CFNetwork from our root share)
2949
2950         * WebView.cpp:
2951         (WebView::userAgentForKURL): Check URL host against a list of known offenders, return them what they're looking for.
2952
2953 2007-03-06  Anders Carlsson  <acarlsson@apple.com>
2954
2955         Reviewed by Adam.
2956         
2957         Pass the user agent on.
2958         
2959         * WebFrame.cpp:
2960         (WebFrame::userAgent):
2961         * WebFrame.h:
2962
2963 2007-03-04  Adam Roben  <aroben@apple.com>
2964
2965         Reviewed by Steve.
2966
2967         Added line spacing querying to FontMetrics to support line wrapping.
2968
2969         * WebKitGraphics.cpp:
2970         (FontMetrics): Return the line spacing.
2971         * WebKitGraphics.h: Added lineSpacing parameter.
2972
2973 2007-03-02  Adam Roben  <aroben@apple.com>
2974
2975         Reviewed by Beth.
2976
2977         Make submenus draw using the UIDelegate.
2978
2979         * Interfaces/IWebUIDelegate.idl: Added new delegate method to add
2980         custom drawing data for menus.
2981         * WebView.cpp:
2982         (WebView::onInitMenuPopup): Added. Calls new delegate method.
2983         (WebViewWndProc): Added handler for WM_INITMENUPOPUP, which is called
2984         for all submenus.
2985         * WebView.h: Added declaration.
2986
2987 2007-03-02  Adam Roben  <aroben@apple.com>
2988
2989         Reviewed by Anders.
2990
2991         Added optional underlining of a single character to WebKitGraphics.
2992
2993         * WebKitGraphics.cpp:
2994         (DrawTextAtPoint): Passed optional underlinedIndex parameter to
2995         WebCoreTextRenderer.
2996         * WebKitGraphics.h: Added optional underlinedIndex parameter.
2997
2998 2007-03-01  Adam Roben  <aroben@apple.com>
2999
3000         Reviewed by Kevin M.
3001
3002         Add support for right-truncation to WebKitGraphics.
3003
3004         * WebKit.vcproj/WebKit.def: Added new export.
3005         * WebKit.vcproj/WebKit_debug.def: Ditto.
3006         * WebKitGraphics.cpp:
3007         (RightTruncateStringToWidth): Added.
3008         * WebKitGraphics.h: Added declaration.
3009
3010 2007-02-28  Adam Roben  <aroben@apple.com>
3011
3012         Reviewed by Anders.
3013
3014         Made WebKitGraphics more flexible.
3015
3016         * WebDragClient.cpp:
3017         (WebDragClient::createDragImageForLink): Updated for changes to
3018         WebKitGraphics/WebCoreTextRenderer.
3019         * WebKit.vcproj/WebKit.def: Added new exported methods.
3020         * WebKit.vcproj/WebKit_debug.def: Ditto.
3021         * WebKitGraphics.cpp:
3022         (makeFont): Added.
3023         (DrawTextAtPoint): Simplified arguments, changed to take a
3024         CGContextRef, and updated for WebCoreTextRenderer changes.
3025         (TextFloatWidth): Added.
3026         (FontMetrics): Added.
3027         (CenterTruncateStringToWidth): Added.
3028         * WebKitGraphics.h: Updated declarations.
3029
3030 2007-02-28  Steve Falkenburg  <sfalken@apple.com>
3031
3032         Fix build (for new SDK) / Break build (for old SDK)
3033
3034         * WebDownload.cpp:
3035         (WebDownload::initToResumeWithBundle):
3036
3037 2007-02-27  Ada Chan  <adachan@apple.com>
3038
3039         Reviewed by Steve and Adam.
3040         
3041         WebKitWin changes to get the aqua scrollbar into the app.
3042
3043         * Interfaces/IWebScrollBarDelegatePrivate.idl: Added.
3044         COM interface for the WebKit scrollbar
3045         * Interfaces/IWebScrollBarPrivate.idl: Added.
3046         COM interface that allows the WebKit scrollbar to update the client.
3047         * Interfaces/WebKit.idl:
3048         * WebKit.vcproj/Interfaces.vcproj:
3049         * WebKit.vcproj/WebKit.vcproj:
3050         * WebKit.vcproj/WebKitGUID.vcproj:
3051         * WebKitClassFactory.cpp:
3052         (WebKitClassFactory::CreateInstance):
3053         Added changes needed to create the WebKitScrollBar through COM
3054         * WebKitDLL.cpp:
3055         (DllGetClassObject):
3056         * WebScrollBar.cpp: Added.
3057         WebKitScrollBar wraps the WebCore's PlatformScrollbar.  This allows the app to
3058         make its own scroll bar that's the same aqua scrollbar in the engine.
3059         (WebScrollBar::WebScrollBar):
3060         (WebScrollBar::~WebScrollBar):
3061         (WebScrollBar::createInstance):
3062         (WebScrollBar::QueryInterface):
3063         (WebScrollBar::AddRef):
3064         (WebScrollBar::Release):
3065         (WebScrollBar::init): instantiate PlatformScrollbar.
3066         (WebScrollBar::setEnabled): call through to PlatformScrollbar
3067         (WebScrollBar::setSteps): ditto
3068         (WebScrollBar::setProportion): ditto
3069         (WebScrollBar::setRect): ditto
3070         (WebScrollBar::setValue): ditto
3071         (WebScrollBar::value): ditto
3072         (WebScrollBar::capturingMouse): ditto
3073         (WebScrollBar::paint): ditto
3074         (WebScrollBar::frameGeometry): ditto
3075         (WebScrollBar::width): ditto
3076         (WebScrollBar::height): ditto
3077         (WebScrollBar::handleMouseEvent): ditto
3078         (WebScrollBar::scroll): ditto
3079         (WebScrollBar::valueChanged): call valueChanged on the delegate
3080         (WebScrollBar::windowClipRect): get the rect from the scrollbar's containing window
3081         * WebScrollBar.h: Added.
3082
3083 2007-02-27  Alice Liu  <alice.liu@apple.com>
3084
3085         Reviewed by Steve, Adam, Maciej, and their mothers.
3086
3087         This is a general leaks fix but helps the effort towards fixing
3088         <rdar://4974495> Boomer leaks while running HTML iBench
3089         However, this fix doens't close that bug. 
3090
3091         * WebFrame.cpp:
3092         (WebFrame::setTitle):
3093             fix a leak of WebHistory
3094         * WebHistory.cpp:
3095         (_WebCoreHistoryProvider::containsItemForURLUnicode):
3096             fix a leak of WebHistory
3097
3098 2007-02-27  Adam Roben  <aroben@apple.com>
3099
3100         Reviewed by Anders.
3101
3102         Fix <rdar://problem/5004615> View source menu option is always disabled
3103         when Netscape 8 is installed
3104
3105         The bug was caused by Netscape's npTrident.dll plugin, which registers
3106         itself as a handler for text/html and text/xml.
3107
3108         * WebFrame.cpp:
3109         (WebFrame::canProvideDocumentSource): Explicitly allow viewing the
3110         source of HTML and XML documents, rather than disallowing text, image,
3111         and plugin documents. Plugins can register themselves as handlers for
3112         HTML and XML MIME types, but we still want to display source in those
3113         cases.
3114
3115 2007-02-27  Beth Dakin  <bdakin@apple.com>
3116
3117         Reviewed by Adam.
3118
3119         Make msimg32.lib available to the engine so that we can use 
3120         AlphaBlend.
3121
3122         * WebKit.vcproj/WebKit.vcproj:
3123
3124 2007-02-27  Ada Chan  <adachan@apple.com>
3125
3126         Fixed build.
3127
3128         * WebFrame.cpp:
3129
3130 2007-02-27  Oliver Hunt  <oliver@apple.com>
3131
3132         Reviewed by Lou and Steve.
3133         
3134         Handle the WM_CURSOR message to stop cursor flickering
3135         to fix <rdar://problem/4788352>
3136
3137         * WebView.cpp:
3138         (WebViewWndProc):
3139
3140 2007-02-27  Ada Chan  <adachan@apple.com>
3141
3142         Reviewed by Steve and Anders.
3143
3144         <rdar://4983106> Stop/reload button never changes back to
3145         reload when a click on a link spawns a download
3146
3147         * WebError.cpp:
3148         (WebError::isPolicyChangeError): fixed string comparison
3149         * WebFrame.cpp:
3150         (WebFrame::interruptForPolicyChangeError): implemented the method
3151
3152 2007-02-26  Adam Roben  <aroben@apple.com>
3153
3154         Reviewed by Adele.
3155
3156         Stop bizarre crashes from happening on startup.
3157
3158         * WebKit.vcproj/WebKit.vcproj: Use new ENABLE_* macros instead of *_SUPPORT.
3159
3160 2007-02-24  Steve Falkenburg  <sfalken@apple.com>
3161
3162         Pre-emptive build fix.
3163         Removed CGPThreads DLL copy
3164
3165         * WebKit.vcproj/WebKit.vcproj:
3166
3167 2007-02-22  Adele Peterson  <adele@apple.com>
3168
3169         Updating this file to match WebCore.
3170
3171         * WebKit.vcproj/textAreaResizeCorner.png:
3172
3173 2007-02-22  Beth Dakin  <bdakin@apple.com>
3174
3175         Reviewed by Adam.
3176
3177         Fix for http://bugs.webkit.org/show_bug.cgi?id=12399 REGRESSION: 
3178         Unable to prevent default context menu from appearing. <rdar://
3179         problem/5017416>
3180
3181         * WebView.cpp:
3182         (WebView::handleContextMenuEvent): Clear the controller's context 
3183         menu before propagating a new context menu event through the DOM.
3184
3185 2007-02-22  Oliver Hunt  <oliver@apple.com>
3186
3187         Reviewed by Ada, Lou, and Steve.
3188
3189         Last of the major changes for drag and drop
3190         - Move COMPtr.h to WebCore
3191         - Added WebDragSource, a modified version of SDataSource from the App
3192           that can notify a WebView's eventhandler of drag events
3193         - Implement the last bits of the DragClient
3194         - As part of drag client added code to draw the "doubled" text used by
3195           drag links.  May be useful for other parts of WebKit/App
3196         
3197         * COMPtr.h: Removed.
3198           Moving to WebCore
3199         * WebDragClient.cpp:
3200         (WebDragClient::actionMaskForDrag):
3201         (WebDragClient::willPerformDragDestinationAction):
3202         (WebDragClient::dragSourceActionMaskForPoint):
3203         (WebDragClient::willPerformDragSourceAction):
3204           Removing WebCore:: as i'm now using the WebCore namespace
3205         (WebDragClient::startDrag):
3206           Implemented client method
3207         (allocImage):
3208         (dragLabelFont):
3209           Helper functions for generating the link dragging image
3210         (WebDragClient::createDragImageForLink):
3211           Implemented client method
3212           
3213         * WebDropSource.cpp: Added.
3214         (WebDropSource::createInstance):
3215         (WebDropSource::WebDropSource):
3216         (WebDropSource::QueryInterface):
3217         (WebDropSource::AddRef):
3218         (WebDropSource::Release):
3219         (generateMouseEvent):
3220           Generates a mouse event for the EventHandler
3221         (WebDropSource::QueryContinueDrag):
3222         (WebDropSource::GiveFeedback):
3223           Copied from SDataObject in the App.  Minor changes per suggestions
3224           from Ada and Steve (error codes, potential leaks)
3225           Also includes logic to notify the source WebView of drag events (moving 
3226           and drag end)
3227           
3228         * WebDropSource.h: Added.
3229           Header for the above
3230           
3231         * WebKit.vcproj/WebKit.vcproj:
3232           Removing COMPtr.h, and adding WebDropSource.{h,cpp}
3233           
3234         * WebKitGraphics.cpp:
3235         (DrawDoubledTextAtPoint):
3236           Utility function for drawing double text, as used by link dragging image
3237           
3238         * WebKitGraphics.h:
3239           Defining the above function
3240
3241 2007-02-21  Brady Eidson  <beidson@apple.com>
3242
3243         Reviewed by the build-fix fairies
3244
3245         * WebDownload.cpp:
3246         (WebDownload::initToResumeWithBundle): Conditionally use CFURLDownload API for the resume case.
3247          I totally made up the flag
3248
3249 2007-02-21  Brady Eidson  <beidson@apple.com>
3250
3251         Reviewed by Anders' rubberstamp
3252         
3253         * WebDownload.cpp:
3254         (WebDownload::initToResumeWithBundle): Make a copy of the string we truncate
3255          so it doesn't affect the original
3256
3257 2007-02-21  Brady Eidson  <beidson@apple.com>
3258
3259         Reviewed by Adam
3260
3261         <rdar://problem/4964763> - Hookup resume downloads on the engine side
3262         
3263         NOTE: Resume downloads are broken in the current ChickenCat - this functionality requires 
3264         a custom ToT CFNetwork as of CFNetwork r3372, or will require CFNetwork 172 or later
3265         
3266         * WebDownload.cpp:
3267         (WebDownload::initWithRequest): Changed some logging, plugged some potential leaks
3268         (WebDownload::initToResumeWithBundle): Added a real implementation - this now works!
3269         (WebDownload::didFinish): Added some logging and fixed up some lifetime issues
3270         (extractResumeDataFromBundle): Renamed to imply the modification of the file.  Truncate
3271           the resume data from the file once it is extracted
3272
3273 2007-02-20  Beth Dakin  <bdakin@apple.com>
3274
3275         Reviewed by Maciej.
3276
3277         Move copyImage functionality from the ContextMenuClient to the 
3278         Pasteboard.
3279
3280         * WebContextMenuClient.cpp:
3281         * WebContextMenuClient.h:
3282
3283 2007-02-20  Adam Roben  <aroben@apple.com>
3284
3285         Reviewed by Darin and Anders.
3286
3287         Fix <rdar://problem/5003318> App: Status bar text is more difficult to
3288         read than Mac OS X Safari
3289
3290         * WebKitGraphics.cpp:
3291         (DrawTextAtPoint): Added bottomAlign and centerTruncate parameters.
3292         * WebKitGraphics.h: Ditto.
3293
3294 2007-02-20  Darin Adler  <darin@apple.com>
3295
3296         Reviewed by Anders.
3297
3298         * WebFrame.cpp: (WebFrame::redirectDataToPlugin): Update for changes to
3299         FrameLoader and DocumentLoader.
3300
3301 2007-02-19  Adam Roben  <aroben@apple.com>
3302
3303         Reviewed by Darin.
3304
3305         Fix <rdar://problem/5007566> Crash in WebFrame::dataSource on dni.ru
3306
3307         The fix for the bug was to zero out WebFrame's Frame pointer in
3308         WebFrame::frameLoaderDestroyed, and then to null-check or ASSERT
3309         non-null as appropriate. All IWebFrame methods that depend on the Frame
3310         pointer will return E_FAIL if it is null, and everywhere within
3311         WebFrame that wasn't null-checking before will now explicitly ASSERT.
3312
3313         I also changed all uses of d->frame and WebFrame::impl() to use the
3314         core() function for consistency, and so that there is only one code
3315         path for getting from a WebFrame to a Frame.
3316
3317         Additional more specific comments below.
3318
3319         * WebChromeClient.cpp:
3320         (WebChromeClient::scrollBackingStore):
3321         (WebChromeClient::updateBackingStore):
3322         * WebFrame.cpp:
3323         (kit): Null-check the frame parameter.
3324         (core): Added two overloads of this.
3325         (WebFrame::DOMDocument): Added argument checking.
3326         (WebFrame::currentForm):
3327         (WebFrame::loadRequest):
3328         (WebFrame::loadData):
3329         (WebFrame::dataSource): Added argument checking, and return E_FAIL if the dataSource is null.
3330         (WebFrame::provisionalDataSource): Ditto.
3331         (WebFrame::stopLoading):
3332         (WebFrame::reload):
3333         (WebFrame::parentFrame):
3334         (WebFrame::renderTreeAsExternalRepresentation): Added argument checking.
3335         (WebFrame::firstLayoutDone): Ditto.
3336         (WebFrame::loadType): Ditto.
3337         (WebFrame::invalidate):
3338         (WebFrame::setTextSizeMultiplier):
3339         (WebFrame::inViewSourceMode): Added argument checking, and changed to return an HRESULT.
3340         (WebFrame::setInViewSourceMode): Changed to return an HRESULT.
3341         (WebFrame::searchForLabelsBeforeElement): Added argument checking.
3342         (WebFrame::matchLabelsAgainstElement): Ditto.
3343         (WebFrame::frameLoaderDestroyed): Zero out the Frame pointer because the Frame is being destroyed.
3344         (WebFrame::createFrame):
3345         (WebFrame::loadURLIntoChild): Added some assertions.
3346         (WebFrame::dispatchWillSubmitForm):
3347         (WebFrame::frameLoadCompleted):
3348         (WebFrame::receivedData):
3349         (WebFrame::setUpPolicyListener):
3350         (WebFrame::receivedPolicyDecision):
3351         (WebFrame::dispatchDecidePolicyForMIMEType):
3352         (WebFrame::dispatchDecidePolicyForNewWindowAction):
3353         (WebFrame::dispatchDecidePolicyForNavigationAction):
3354         (WebFrame::dispatchCreatePage):
3355         (WebFrame::createPlugin):
3356         (WebFrame::redirectDataToPlugin):
3357         (WebFrame::createJavaAppletWidget):
3358         (WebFrame::windowObjectCleared):
3359         (WebFrame::setPrinting):
3360         (WebFrame::setInPrintingMode):
3361         (WebFrame::computePageRects):
3362         (WebFrame::getPrintedPageCount): Zero out the out parameter before proceeding.
3363         (WebFrame::spoolPages):
3364         (WebFrame::forceLayoutWithPageWidthRange):
3365         * WebFrame.h:
3366         * WebView.cpp:
3367         (WebView::paint): Silently fail on a null Frame, because this method could be called at any time.
3368         (WebView::mouseWheel): Ditto.
3369         (WebViewWndProc): Ditto.
3370         (WebView::inViewSourceMode): Return whatever WebFrame::setInViewSourceMode returns.
3371         (WebView::setInViewSourceMode): Ditto.
3372         (WebView::setCustomTextEncodingName): Replaced check for a null
3373         FrameLoader with a check for a null Frame, which is equivalent but, as
3374         a bonus, won't crash.
3375         (WebView::stringByEvaluatingJavaScriptFromString):
3376         (WebView::elementAtPoint): Added argument checking.
3377         (WebView::selectedText): Ditto.
3378         (WebView::centerSelectionInVisibleArea):
3379
3380 2007-02-19  Adam Roben  <aroben@apple.com>
3381
3382         Build fix.
3383
3384         * WebFrame.cpp:
3385         (WebFrame::computePageRects):
3386
3387 2007-02-18  Maciej Stachowiak  <mjs@apple.com>
3388
3389         Reviewed by Oliver.
3390
3391         - Adapt for Lars's patch to clean up Frame
3392
3393         * WebChromeClient.cpp:
3394         (WebChromeClient::tabsToLinks):
3395         (WebChromeClient::windowResizerRect):
3396         (WebChromeClient::addToDirtyRegion):
3397         (WebChromeClient::scrollBackingStore):
3398         (WebChromeClient::updateBackingStore):
3399         * WebChromeClient.h:
3400         * WebEditorClient.cpp:
3401         (WebEditorClient::shouldChangeSelectedRange):
3402         (WebEditorClient::textFieldDidBeginEditing):
3403         (WebEditorClient::textFieldDidEndEditing):
3404         (WebEditorClient::textDidChangeInTextField):
3405         (WebEditorClient::doTextFieldCommandFromEvent):
3406         (WebEditorClient::textWillBeDeletedInTextField):
3407         (WebEditorClient::textDidChangeInTextArea):
3408         * WebEditorClient.h:
3409         * WebElementPropertyBag.cpp:
3410         (WebElementPropertyBag::Read):
3411         * WebFrame.cpp:
3412         (kit):
3413         (WebFrame::initWithWebFrameView):
3414         (WebFrame::searchForLabelsBeforeElement):
3415         (WebFrame::matchLabelsAgainstElement):
3416         (WebFrame::createPlugin):
3417         (WebFrame::createJavaAppletWidget):
3418         (WebFrame::computePageRects):
3419         (WebFrame::getPrintedPageCount):
3420         (WebFrame::spoolPages):
3421         * WebFrame.h:
3422         * WebView.cpp:
3423         (WebView::handleEditingKeyboardEvent):
3424         (WebView::keyDown):
3425         (WebView::generateSelectionImage):
3426         * WebView.h:
3427
3428 2007-02-18  Ada Chan  <adachan@apple.com>
3429
3430         Reviewed by Adam.
3431         
3432         Move app text controls to use webview
3433
3434         * DOMCoreClasses.cpp:
3435         (DOMNode::parentNode): implemented
3436         (DOMElement::blur): implemented
3437         * Interfaces/IWebUIDelegatePrivate.idl: added API for focus/blur notifications
3438         * WebKit.vcproj/WebKit.def: added DrawTextAtPoint
3439         * WebKit.vcproj/WebKit.vcproj: added WebKitGraphics.h/cpp
3440         * WebKit.vcproj/WebKit_debug.def: added DrawTextAtPoint
3441         * WebKitGraphics.cpp: Added.
3442         (DrawTextAtPoint): calls WebCoreDrawTextAtPoint to render text
3443         * WebKitGraphics.h: Added.
3444         * WebView.cpp:
3445         (WebViewWndProc): notify setfocus and killfocus through IWebUIDelegatePrivate delegate.
3446         (WebView::unmarkAllTextMatches): added null check
3447
3448 2007-02-18  Oliver Hunt  <oliver@apple.com>
3449
3450         Reviewed by Adam.
3451
3452         Stubs to keep the build going
3453
3454         * WebDragClient.cpp:
3455         (WebDragClient::willPerformDragSourceAction):
3456         (WebDragClient::startDrag):
3457         (WebDragClient::createDragImageForLink):
3458         * WebDragClient.h:
3459
3460 2007-02-17  Steve Falkenburg  <sfalken@apple.com>
3461
3462         Reviewed by Adam.
3463
3464         <rdar://problem/4918821> Find: clicking on the webview does not hide findoverlay
3465         <rdar://problem/4956428> Find: Showing/hiding the Find banner should not push the page contents down when possible
3466
3467         * Interfaces/IWebViewPrivate.idl: Added scrollBy, visibleContentRect
3468         * WebView.cpp:
3469         (WebView::scrollOffset): Add null check
3470         (WebView::scrollBy): Added so we can scroll a webview easily (matches scroll position getter here)
3471         (WebView::visibleContentRect):  Added so we can size find overlay appropriately (not including scroll bars)
3472         * WebView.h: Added scrollBy, visibleContentRect
3473
3474 2007-02-17  Adele Peterson  <adele@apple.com>
3475
3476         Reviewed by Hyatt.
3477
3478         Fix for <rdar://problem/5006194> Caret is not revealed when a newline is entered into a textarea
3479
3480         * WebView.cpp: (WebView::handleEditingKeyboardEvent):
3481         Use shared code in Editor class to insertParagraphSeparator (or insertLineBreak for plain text).
3482         This will also reveal the selection properly.
3483
3484 2007-02-16  Anders Carlsson  <acarlsson@apple.com>
3485
3486         Build fixes.
3487         
3488         * WebDownload.cpp:
3489         (WebDownload::init):
3490         (WebDownload::initWithRequest):
3491
3492 2007-02-15  Steve Falkenburg  <sfalken@apple.com>
3493
3494         Reviewed by Adam.
3495         
3496         <rdar://problem/5001181> Crash: autofilling empty page
3497         
3498         Return an error from WebFrame::DOMDocument if there's no document
3499
3500         * WebFrame.cpp:
3501         (WebFrame::DOMDocument): null document now maps to E_FAIL
3502
3503 2007-02-15  Brady Eidson  <beidson@apple.com>
3504
3505         Reviewed by Adam
3506
3507         <rdar://4778394> - Save scroll position in the back/forward list
3508         
3509         * WebFrame.cpp:
3510         (WebFrame::restoreViewState):  Renamed, as scroll position was pushed to WebCore
3511         (WebFrame::saveViewStateToItem):  Ditto
3512         * WebFrame.h:
3513
3514 2007-02-15  Adam Roben  <aroben@apple.com>
3515
3516         Reviewed by Anders.
3517
3518         Fix <rdar://problem/4968731> Printing scales frames to page width
3519         instead of doing a layout at that width
3520
3521         * Interfaces/IWebFramePrivate.idl: Added setInPrintingMode method.
3522         * WebFrame.cpp:
3523         (WebFrame::WebFrame): Initialize new member.
3524         (printerRect): New helper function.
3525         (WebFrame::setPrinting): Ported from WebHTMLView.
3526         (WebFrame::setInPrintingMode): Implemented.
3527         (WebFrame::computePageRects): Changed to store the page rects.
3528         (WebFrame::getPrintedPageCount): Added an ASSERT and updated for change to computePageRects.
3529         (WebFrame::spoolPages): Use the stored page rects, and set mediaBox's
3530         size using the print rect instead of the page rect so we will scale the
3531         pages to the full width of the print DC.
3532         (WebFrame::forceLayoutWithPageWidthRange): Ported from WebFrameBridge.
3533         * WebFrame.h: Updated declarations.
3534
3535 2007-02-15  Lou Amadio  <lamadio@apple.com>
3536
3537         Reviewed by Steve.
3538
3539         <rdar://problem/4945799> CGText: should use correct mechanism to set font smoothing style
3540         
3541         * WebKit.vcproj/WebKit.vcproj:
3542         * WebPreferences.cpp:
3543         (WebPreferences::setFontSmoothing):
3544         * WebView.cpp:
3545         (WebViewWndProc):
3546
3547 2007-02-13  Steve Falkenburg  <sfalken@apple.com>
3548
3549         Reviewed by Adam.
3550         
3551         <rdar://problem/4950378> AddressBook autofill doesn't fill rest of form when tabbing out of a completed field
3552         
3553         Send tab keypresses to IWebFormDelegate::doCommandBySelector.
3554
3555         * WebEditorClient.cpp:
3556         (WebEditorClient::handleKeyPress): Call doTextFieldCommandFromEvent if we get a tab keypress
3557
3558 2007-02-12  Ada Chan  <adachan@apple.com>
3559
3560         Reviewed by Steve.
3561         
3562         Also, checked in a fix in WebContextMenuClient that Adam made on my machine, reviewed by me.
3563
3564         <rdar://4952715> Events not being passed from WebCore/WebKit up through IWebForm::doCommandBySelector
3565         Inform form delegate about delete key press.
3566         
3567         DOM event fixes:
3568         - Removed DOMEventTarget class.
3569         - IDOMEventTarget no longer extends IDOMObject
3570         - DOMNode now implements IDOMEventTarget
3571         - DOMEvent::CoCreateInstance creates the correct subclasses
3572         of DOMEvents based on the type of event
3573         - Added IDOMDocumentEvent interface, which DOMDocument implements.
3574         - Fixed the out parameter in IDOMUIEvent::view to be IDOMWindow**
3575         
3576         Implemented DOMHTMLDocument::body and DOMHTMLElement::setInnerText.
3577
3578         * DOMCoreClasses.cpp:
3579         (DOMNode::addEventListener): added as DOMNode now needs to implement IDOMEventTarget
3580         (DOMNode::removeEventListener): ditto above
3581         (DOMNode::dispatchEvent): ditto above
3582         (DOMDocument::QueryInterface): DOMDocument now also implements IDOMDocumentEvent
3583         (DOMDocument::createEvent): added as DOMDocument implements IDOMDocumentEvent
3584         (DOMElement::focus): implemented
3585         * DOMCoreClasses.h:
3586         * DOMEventsClasses.cpp:
3587         (DOMEvent::DOMEvent): The data member m_event is now a RefPtr, and the WebCore::Event is now
3588         passed into the constructor via a PassRefPtr.
3589         (DOMEvent::~DOMEvent): No longer need to deref m_event since we are using a RefPtr.
3590         (DOMEvent::createInstance): instantiate the correct DOMEvent subclass based on event type.
3591         (DOMEvent::QueryInterface): be able to QI IID_DOMEvent, which returns back the DOMEvent type.
3592         (DOMUIEvent::view): fixed the API
3593         (DOMKeyboardEvent::ctrlKey): call .get() on RefPtr
3594         (DOMKeyboardEvent::shiftKey): ditto above
3595         (DOMKeyboardEvent::altKey): ditto above
3596         (DOMKeyboardEvent::metaKey): ditto above
3597         (DOMKeyboardEvent::altGraphKey): ditto above
3598         (DOMMouseEvent::ctrlKey): ditto above
3599         (DOMMouseEvent::shiftKey): ditto above
3600         (DOMMouseEvent::altKey): ditto above
3601         (DOMMouseEvent::metaKey): ditto above
3602         * DOMEventsClasses.h:
3603         (DOMEvent::coreEvent): Added an API to get the WebCore::Event out of a DOMEvent.  Used in DOMNode::dispatchEvent.
3604         (DOMUIEvent::DOMUIEvent): made public so it can be called in DOMEvent::createInstance
3605         (DOMKeyboardEvent::DOMKeyboardEvent): ditto above
3606         (DOMKeyboardEvent::view): fixed API
3607         (DOMMouseEvent::DOMMouseEvent): made public so it can be called in DOMEvent::createInstance
3608         (DOMMouseEvent::view): fixed API
3609         (DOMMutationEvent::DOMMutationEvent): made public so it can be called in DOMEvent::createInstance
3610         (DOMOverflowEvent::DOMOverflowEvent): made public so it can be called in DOMEvent::createInstance
3611         (DOMWheelEvent::DOMWheelEvent): made public so it can be called in DOMEvent::createInstance
3612         (DOMWheelEvent::view): fixed API
3613         * DOMHTMLClasses.cpp:
3614         (DOMHTMLDocument::body):
3615         (DOMHTMLElement::setInnerText):
3616         * Interfaces/DOMEvents.idl: IDOMEventTarget no longer extends IDOMObject.  Added IDOMDocumentEvent.
3617         * WebContextMenuClient.cpp:
3618         (WebContextMenuClient::getCustomMenuFromDefaultItems): check for error from calling contextMenuItemsForElement.
3619         * WebFrame.cpp:
3620         (WebFrame::textWillBeDeletedInTextField): call form delegate callback doCommandBySelector with VK_BACK 
3621         when deleting text.
3622
3623 2007-02-11  Adam Roben  <aroben@apple.com>
3624
3625         Fixing line endings.
3626
3627         * WebResource.cpp:
3628         * WebResource.h:
3629
3630 2007-02-10  Adam Roben  <aroben@apple.com>
3631
3632         Reviewed by Steve.
3633
3634         Fix <rdar://problem/4989705> Loading eBay puts many items into back list
3635
3636         The bug was that WebFrame::createFrame was calling loadRequest on the
3637         new child frame, which would initiate a load of FrameLoadTypeStandard,
3638         when in fact we wanted to do a FrameLoadTypeInternal load. I ported
3639         -[WebFrame _loadURL:referrer:intoChild:] to WebFrame, which contains
3640         the logic we need.
3641
3642         * WebFrame.cpp:
3643         (WebFrame::createFrame): Use a COMPtr to manage the new WebFrame, and
3644         call loadURLIntoChild instead of just calling loadRequest.
3645         (WebFrame::loadURLIntoChild): Ported from Mac WebFrame.