WebKit:
[WebKit-https.git] / WebKit / win / ChangeLog
1 2009-03-16  Darin Adler  <darin@apple.com>
2
3         Reviewed by Dan Bernstein.
4
5         <rdar://problem/6577174> Rename the text directionality submenus to “Paragraph Direction” and “Selection Direction”
6
7         For now, change only the localized strings, not the terminology in the code.
8
9         * WebCoreLocalizedStrings.cpp:
10         (WebCore::contextMenuItemTagWritingDirectionMenu): Changed string here.
11         (WebCore::contextMenuItemTagTextDirectionMenu): And here.
12
13 2009-03-16  Adam Roben  <aroben@apple.com>
14
15         Add IWebFramePrivate::isDisplayingStandaloneImage
16
17         This uses the same logic that -[WebFrame _isDisplayingStandaloneImage]
18         uses.
19
20         Reviewed by Darin Adler.
21
22         * Interfaces/IWebFramePrivate.idl: Added isDisplayingStandaloneImage.
23
24         * WebFrame.cpp:
25         (WebFrame::isDisplayingStandaloneImage): Added. Returns true if our
26         Document is an image document.
27
28         * WebFrame.h: Added isDisplayingStandaloneImage.
29
30 2009-03-12  Peter Kasting  <pkasting@google.com>
31
32         Reviewed by Darin Fisher.
33
34         https://bugs.webkit.org/show_bug.cgi?id=24502
35         Make horizontal scrolling on Windows always go the correct direction.
36
37         * WebView.cpp:
38         (WebView::mouseWheel):
39         (WebViewWndProc):
40         * WebView.h:
41
42 2009-03-12  Adam Roben  <aroben@apple.com>
43
44         Implement DOMHTMLDocument::title
45
46         Reviewed by Dan Bernstein.
47
48         * DOMHTMLClasses.cpp:
49         (DOMHTMLDocument::title): Call through to WebCore::Document (with
50         obligatory COM error checking/type conversions).
51
52 2009-03-11  Adam Roben  <aroben@apple.com>
53
54         Export functions needed by ThreadSpecific from WebKit
55
56         Reviewed by John Sullivan.
57
58         * WebKit.vcproj/WebKit.def:
59         * WebKit.vcproj/WebKit_debug.def:
60         Export WTF::tlsKeyCount and WTF::tlsKeys.
61
62 2009-03-10  Steve Falkenburg  <sfalken@apple.com>
63
64         <rdar://problem/6662167> When clicking in Top Sites search field, WebHistory::findIndex fails causing crash in BookmarksSearcher::collectHistorySearchResults
65         
66         Round CFAbsoluteDates to the nearest second when converting to/from the Windows DATE format.
67         
68         This corrects for inaccuracies introduced by round-tripping between DATE (day based) and CFAbsoluteDate (second based).
69         The WebKit COM API on Windows uses DATE, while our history storage uses CFAbsoluteTime. This could lead to WebKit
70         saying there was browsing history for a particular day, and then return no history items when we requested a
71         list of sites visited that day.        
72         
73         Reviewed by Ada Chan.
74
75         * MarshallingHelpers.cpp:
76         (MarshallingHelpers::DATEToCFAbsoluteTime):
77         (MarshallingHelpers::CFAbsoluteTimeToDATE):
78
79 2009-03-08  Mark Rowe  <mrowe@apple.com>
80
81         Reviewed by Oliver Hunt.
82
83         Split ScrollAlignment and ScrollBehavior out of RenderLayer.h so that
84         Frame.h no longer needs to include it.  This cuts the size of the symbols
85         for a debug build by around 3%.
86
87         * WebView.cpp:
88         (WebView::centerSelectionInVisibleArea):
89
90 2009-03-07  Dan Bernstein  <mitz@apple.com>
91
92         Reviewed by Mark Rowe.
93
94         - WebKit part of removing build-time and run-time support for legacy
95           versions of CFNetwork and Core Graphics
96
97         * WebView.cpp:
98         (WebView::setCacheModel):
99
100 2009-03-04  Adam Barth  <abath@webkit.org>
101
102         Reviewed by Alexey Proskuryakov.
103
104         https://bugs.webkit.org/show_bug.cgi?id=24356
105
106         Fix WebKit style for allowUniversalAccessFromFileURLs.
107
108         * Interfaces/IWebPreferencesPrivate.idl:
109         * WebPreferenceKeysPrivate.h:
110         * WebPreferences.cpp:
111         (WebPreferences::initializeDefaultSettings):
112         (WebPreferences::allowUniversalAccessFromFileURLs):
113         (WebPreferences::setAllowUniversalAccessFromFileURLs):
114         * WebPreferences.h:
115         * WebView.cpp:
116         (WebView::notifyPreferencesChanged):
117
118 2009-02-27  Adam Barth  <abarth@webkit.org>
119
120         Reviewed by Eric Seidel.
121
122         Add a preference to reduce the power of file:// URLs.
123
124         * Interfaces/IWebPreferencesPrivate.idl:
125         * WebPreferenceKeysPrivate.h:
126         * WebPreferences.cpp:
127         (WebPreferences::initializeDefaultSettings):
128         (WebPreferences::allowUniversalAccessFromFileUrls):
129         (WebPreferences::setAllowUniversalAccessFromFileUrls):
130         * WebPreferences.h:
131         * WebView.cpp:
132         (WebView::notifyPreferencesChanged):
133
134 2009-02-19  Alexey Proskuryakov  <ap@webkit.org>
135
136         Reviewed by Darin Adler.
137
138         https://bugs.webkit.org/show_bug.cgi?id=24024
139         REGRESSION (r39845): Assertion failure in -[WebHistoryItem dictionaryRepresentation] when
140         archiving a submission to about:blank
141
142         I don't know how to make an automated test for this bug.
143
144         * WebHistory.cpp: (WebHistory::visitedURL): Account for the fact that HTTP method may be
145         non-empty for non-HTTP requests.
146
147 2009-02-25  Andreia Gaita  <shana@jitted.com>
148
149         Reviewed by Alp Toker.
150
151         Update Win def files with recent JavaScriptCore API additions.
152
153         * WebKit.vcproj/WebKit.def:
154         * WebKit.vcproj/WebKit_Cairo.def:
155         * WebKit.vcproj/WebKit_debug.def:
156
157 2009-02-24  Sam Weinig  <sam@webkit.org>
158
159         Reviewed by Geoffrey Garen.
160
161         Related to <rdar://problem/6590295>
162         Allow disabling javascript: urls.
163
164         * Interfaces/IWebViewPrivate.idl:
165         * WebView.cpp:
166         (WebView::setJavaScriptURLsAreAllowed):
167         * WebView.h:
168
169 2009-02-24  Adam Roben  <aroben@apple.com>
170
171         Windows build fix
172
173         * WebKit.vcproj/WebKit.def:
174         * WebKit.vcproj/WebKit_debug.def:
175         Export WTF::ThreadCondition::timedWait.
176
177 2009-02-12  Brady Eidson  <beidson@apple.com>
178
179         Reviewed by Kevin Decker
180
181         <rdar://problem/6582180> - Wrong HTTP method applied to history item.
182
183         * WebCoreSupport/WebFrameLoaderClient.cpp:
184         (WebFrameLoaderClient::updateGlobalHistory): Check the original request, not any
185           redirected request.
186
187 2009-02-11  Brady Eidson  <beidson@apple.com>
188
189         Fix my last checkin for more effect.
190
191         * WebHistoryItem.cpp:
192         (WebHistoryItem::initFromDictionaryRepresentation):
193
194 2009-02-11  Adam Roben  <aroben@apple.com>
195
196         Windows fix for Bug 22239: Implement missing animation & transition
197         APIs on LayoutTestController for non-mac platforms
198
199         <https://bugs.webkit.org/show_bug.cgi?id=22239>
200
201         Reviewed by Simon Fraser.
202
203         * Interfaces/IWebFramePrivate.idl: Added pauseAnimation,
204         pauseTransition, and numberOfActiveAnimations.
205
206         * WebFrame.cpp:
207         (WebFrame::pauseAnimation):
208         (WebFrame::pauseTransition):
209         (WebFrame::numberOfActiveAnimation):
210         Added. These all call through to AnimationController.
211
212         * WebFrame.h: Added pauseAnimation, pauseTransition, and
213         numberOfActiveAnimations.
214
215 2009-02-11  Brady Eidson  <beidson@apple.com>
216
217         Reviewed by Mark Rowe
218
219         <rdar://problem/6570573> Some visit counts in History.plist have insanely high values, can roll over to negative
220
221         Remove the item from the date caches before registering the visit.  Otherwise it might not be successfully removed 
222         and when we add it back later it will exist in the list twice.  This will cause the entry to be written out twice,
223         which would lead to doubling (or more!) the visit count on next launch when these multiple items are merged.
224
225         * WebHistory.cpp:
226         (WebHistory::loadHistoryGutsFromURL):
227         (WebHistory::addItems):
228         (WebHistory::addItem): Add a mode that allows the entry being added to be discarded if an entry for the URL already 
229           exists.  Use that mode when reading the History.plist so only the most recent entry for a given URL will be used.
230         (WebHistory::visitedURL): Swap the removeItemFromDateCaches and visitedWithTitle calls.
231         * WebHistory.h:
232
233         * WebHistoryItem.cpp:
234         (WebHistoryItem::initFromDictionaryRepresentation):  Add the negative-visit-count-correction-logic as implemented
235           for Mac in http://trac.webkit.org/changeset/40851.
236
237 2009-02-11  Dimitri Dupuis-latour  <dupuislatour@apple.com>
238
239         Stub out WebInspectorClient::hiddenPanels.
240
241         Reviewed by Timothy Hatcher.
242
243         * WebCoreSupport/WebInspectorClient.cpp:
244         (WebInspectorClient::hiddenPanels):
245         * WebCoreSupport/WebInspectorClient.h:
246
247 2009-02-11  Adam Roben  <aroben@apple.com>
248
249         Don't release the shared WebHistory instance on quit
250
251         This matches Mac, and prevents a race condition when the process exits
252         that depends on the order in which global destructors are invoked.
253
254         Reviewed by Alexey Proskuryakov.
255
256         * WebHistory.cpp:
257         (sharedHistoryStorage): Changed to use DEFINE_STATIC_LOCAL so the
258         destructor is never called.
259
260 2009-02-10  Adam Roben  <aroben@apple.com>
261
262         Fix recursive WebView destruction when running DumpRenderTree
263
264         DumpRenderTree would call DestroyWindow on a WebView's host window,
265         which would send a WM_DESTROY message to the WebView's window. Inside
266         the WebView's WndProc, we would hold a ref to the WebView, then call
267         close() and revokeDragDrop(), which would release all remaining
268         references to the WebView other than the ref we held in the WndProc.
269         When the WndProc exited, the final ref to the WebView would be
270         released, invoking WebView's destructor. At this point,
271         IsWindow(m_viewWindow) would return true, since we were still in the
272         process of handling WM_DESTROY, so we would call DestroyWindow on the
273         WebView's window again, re-entering the WndProc and re-reffing the
274         WebView, leading to recursive destruction.
275
276         Reviewed by Alexey Proskuryakov.
277
278         * WebView.cpp:
279         (WebView::~WebView): Don't call DestroyWindow if our window is already
280         being destroyed.
281         (WebViewWndProc): Only hold an extra ref to the WebView when we're not
282         being destroyed.
283
284 2009-02-06  Adam Roben  <aroben@apple.com>
285
286         Build fix
287
288         Reviewed by Sam Weinig.
289
290         * WebCoreSupport/WebFrameLoaderClient.cpp: Added missing #include.
291         (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): Removed
292         incorrect .get(), and changed to use the new overload of
293         WebHistory::itemForURLString.
294
295         * WebHistory.cpp:
296         (WebHistory::itemForURLString): Made this const.
297         (WebHistory::itemForURLString): Added an overload that takes a
298         WebCore::String and returns the IWebHistoryItem instead of using an
299         out parameter.
300
301         * WebHistory.h: Added public overload of itemForURLString.
302
303         * WebView.cpp:
304         (WebView::prepareCandidateWindow):
305         (WebView::onIMERequestCharPosition):
306         (WebView::onIMERequestReconvertString):
307         Updated for toRange -> toNormalizedRange rename.
308
309 2009-02-06  Geoffrey Garen  <ggaren@apple.com>
310
311         Reviewed by Sam Weinig.
312
313         Part III of <rdar://problem/6552272>.
314         
315         Refactored to use the redirect data WebCore makes available, instead of
316         tracking loading state in WebKit.
317         
318         * WebCoreSupport/WebFrameLoaderClient.cpp:
319         (WebFrameLoaderClient::updateGlobalHistory):
320         (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
321         * WebCoreSupport/WebFrameLoaderClient.h:
322         * WebHistory.cpp:
323         (WebHistory::visitedURL):
324         * WebHistory.h:
325
326 2009-02-06  Dan Bernstein  <mitz@apple.com>
327
328         Reviewed by Anders Carlsson.
329
330         - fix an assertion failure in Vector::at() beneath
331           WebHistoryItem::dictionaryRepresentation.
332
333         * WebHistoryItem.cpp:
334         (WebHistoryItem::dictionaryRepresentation): Give the numbers vector initial
335         size. Also reduced the inline capacity of the vector used for weekly visit
336         counts to 5, which is the expected maximum size.
337
338 2009-02-06  Brent Fulgham  <bfulgham@webkit.org>
339
340         Build fix.  
341
342         * WebKit.vcproj/WebKit.vcproj: Re-enable missing file in Release
343           target of Cairo.
344
345 2009-02-06  Maciej Stachowiak  <mjs@apple.com>
346
347         Rubber stamped by Dan Bernstein.
348
349         - fix obvious problem in previous commit (|| used instead of &&)
350
351         * WebHistoryItem.cpp:
352         (WebHistoryItem::initFromDictionaryRepresentation):
353
354 2009-02-05  Maciej Stachowiak  <mjs@apple.com> and Brady Eidson  <beidson@apple.com>
355
356         Reviewed by Dan Bernstein and Geoff Garen..
357
358         - WebKit code to track per-day and per-week visit counts in history
359
360         For now this data is only exposed via SPI for performance reasons.
361
362         * Interfaces/IWebHistoryItemPrivate.idl: Added new interface.
363         * WebHistory.cpp:
364         (WebHistory::visitedURL): Use new recordInitialVisit method.
365         * WebHistoryItem.cpp:
366         (WebHistoryItem::initFromDictionaryRepresentation): Add parsing support
367         for new data.
368         (WebHistoryItem::dictionaryRepresentation): Add saving support for
369         new data.
370         (WebHistoryItem::getDailyVisitCounts): SPI accessor.
371         (WebHistoryItem::getWeeklyVisitCounts): SPI accessor.
372         (WebHistoryItem::recordInitialVisit): Tell WebCore to record an initial visit.
373         * WebHistoryItem.h:
374
375 2009-02-05  Brent Fulgham  <bfulgham@webkit.org>
376
377         Reviewed by Sam Weinig <sam@webkit.org>
378
379         Build fix.  Update file for recently removed EventTargetNodeCast.
380         * DOMCoreClasses.cpp:
381         (DOMNode::dispatchEvent):
382
383 2009-02-05  Aaron Boodman  <aa@chromium.org>
384
385         Reviewed by Dave Hyatt.
386
387         https://bugs.webkit.org/show_bug.cgi?id=23708
388         Adds documentElementAvailable() callback to FrameLoaderClient.
389
390         * WebFrame.cpp:
391         (WebFrame::documentElementAvailable):
392         Stub out documentElementAvailable()
393         * WebFrame.h:
394         Ditto.
395
396 2009-02-04  Geoffrey Garen  <ggaren@apple.com>
397
398         Build fix.
399
400         * WebHistory.cpp:
401         (WebHistory::visitedURL):
402
403 2009-02-04  Geoffrey Garen  <ggaren@apple.com>
404
405         Reviewed by Mark Rowe.
406         
407         Part I of <rdar://problem/6552272>.
408
409         Clear the redirectURLs entry when first visiting a site, so sites that
410         only redirect you the first time you visit them can later learn that
411         they don't redirect.
412
413         * WebHistory.cpp:
414         (WebHistory::visitedURL):
415
416 2009-02-03  Geoffrey Garen  <ggaren@apple.com>
417
418         Build fix.
419
420         * WebHistory.cpp:
421         (WebHistory::visitedURL):
422
423 2009-02-02  Geoffrey Garen  <ggaren@apple.com>
424
425         Build fix.
426
427         * WebHistory.cpp:
428         (WebHistory::visitedURL):
429
430 2009-02-02  Hiroaki Nakamura <hnakamur@gmail.com>
431
432         Reviewed by Adam Roben.
433
434         Fixes https://bugs.webkit.org/show_bug.cgi?id=15813
435         Modify pre-build step to properly handle the errorlevel
436         shell command.
437
438         * WebKit.vcproj/WebKit.vcproj: Change errorlevel handling
439         for all targets so prefast is only enabled in builds
440         where /analyze is available.
441
442 2009-02-02  Geoffrey Garen  <ggaren@apple.com>
443
444         Reviewed by Sam Weinig.
445
446         Track redirects in global history.
447
448         * Interfaces/IWebFramePrivate.idl: Updated for WebCore rename.
449
450         * WebCoreSupport/WebFrameLoaderClient.cpp:
451         (WebFrameLoaderClient::updateGlobalHistory):
452         (WebFrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem):
453         Store redirect information in global history.
454
455         (WebFrameLoaderClient::loadURLIntoChild): Updated for extra parameter.
456
457         * WebCoreSupport/WebFrameLoaderClient.h: See above.
458
459         * WebFrame.cpp:
460         (WebFrame::loadRequest):
461         (WebFrame::loadData): Updated for extra parameter.
462
463         * WebHistory.cpp:
464         (WebHistory::visitedURL):
465         (WebHistory::visitedURLForRedirectWithoutHistoryItem): Store redirect
466         information in global history.
467
468         * WebHistory.h: See above.
469
470 2009-02-02  Brady Eidson  <beidson@apple.com>
471
472         Reviewed by Dan Bernstein
473
474         Transition Windows WebHistory to using the same "update already existing History Items" technique that Mac does.
475
476         * Interfaces/IWebHistoryItemPrivate.idl:
477         * WebCoreSupport/WebFrameLoaderClient.cpp:
478         (WebFrameLoaderClient::updateGlobalHistory):
479
480         * WebHistory.cpp:
481         (WebHistory::visitedURL):
482         * WebHistory.h:
483
484         * WebHistoryItem.cpp:
485         (WebHistoryItem::visitedWithTitle):
486         * WebHistoryItem.h:
487
488 2009-02-02  Anders Carlsson  <andersca@apple.com>
489
490         Fix build.
491         
492         * WebCoreSupport/WebFrameLoaderClient.cpp:
493         (WebFrameLoaderClient::createPlugin):
494         * WebCoreSupport/WebFrameLoaderClient.h:
495
496 2009-02-02  Anders Carlsson  <andersca@apple.com>
497
498         Reviewed by Dan Bernstein.
499
500         Update for changes to WebCore.
501
502         * WebFrame.cpp:
503         (WebFrame::createJavaAppletWidget):
504         * WebFrame.h:
505
506 2009-02-02  Holger Hans Peter Freyther  <zecke@selfish.org>
507
508         Reviewed by Darin Adler.
509
510         Move Frame::forceLayout, Frame::adjustPageHeight and Frame::forceLayoutWithPageWidthRange to FrameView
511
512         https://bugs.webkit.org/show_bug.cgi?id=23428
513
514         FrameView::forceLayout could be killed but the comment might
515         contain a value over the the plain FrameView::layout...
516
517         Adjust the WebCore/WebKit consumers of these methods.
518
519         * WebCoreSupport/WebFrameLoaderClient.cpp:
520         (WebFrameLoaderClient::forceLayout):
521
522 2009-01-31  Matt Lilek  <webkit@mattlilek.com>
523
524         Not reviewed, build fixes.
525
526         * WebCoreSupport/WebContextMenuClient.cpp:
527         (WebContextMenuClient::searchWithGoogle):
528         * WebFrame.cpp:
529         (WebFrame::setInPrintingMode):
530         (WebFrame::isFrameSet):
531         * WebView.cpp:
532         (WebView::notifyPreferencesChanged):
533
534 2009-01-30  Adam Barth  <abarth@webkit.org>
535
536         Reviewed by Sam Weinig.
537
538         Add a pref to disable web security.
539
540         * Interfaces/IWebPreferencesPrivate.idl:
541         * WebPreferenceKeysPrivate.h:
542         * WebPreferences.cpp:
543         (WebPreferences::initializeDefaultSettings):
544         (WebPreferences::isWebSecurityEnabled):
545         (WebPreferences::setWebSecurityEnabled):
546         * WebPreferences.h:
547         * WebView.cpp:
548         (WebView::notifyPreferencesChanged):
549
550 2009-01-30  Geoffrey Garen  <ggaren@apple.com>
551
552         Build fix.
553
554         * Interfaces/IWebFramePrivate.idl:
555         * WebCoreSupport/WebFrameLoaderClient.cpp:
556         (WebFrameLoaderClient::loadURLIntoChild):
557
558 2009-01-30  Holger Hans Peter Freyther  <zecke@selfish.org>
559
560         Reviewed by Simon Hausmann.
561
562         Kill FrameLoaderClient.cpp, move the code over to Frame::createView
563
564         FrameLoaderClient is supposed to be an interface, move the
565         to be shared code to Frame which is a controller and is
566         allowed to create a FrameView.
567
568         * WebCoreSupport/WebFrameLoaderClient.cpp:
569         (WebFrameLoaderClient::transitionToCommittedForNewPage):
570
571 2009-01-30  Brady Eidson  <beidson@apple.com>
572
573         Reviewed by Sam Weinig
574
575         Remove FrameLoaderClient code that is now handled by FrameLoader itself
576
577         * WebFrame.cpp:
578         (WebFrame::frameLoadCompleted):
579
580 2009-01-29  Sam Weinig  <sam@webkit.org>
581
582         Fix Windows build
583
584         * WebHistoryItem.cpp:
585         (WebHistoryItem::initFromDictionaryRepresentation):
586
587 2009-01-29  Sam Weinig  <sam@webkit.org>
588
589         Reviewed by Anders Carlsson.
590
591         Second step in tracking the urls a HistoryItem was redirected through
592         Add SPI to access the array of redirect urls associated with a HistoryItem.
593
594         * Interfaces/IWebHistoryItemPrivate.idl:
595         * WebHistoryItem.cpp:
596         (WebHistoryItem::dictionaryRepresentation):
597         (WebHistoryItem::redirectURLs):
598         * WebHistoryItem.h:
599
600 2009-01-29  Sam Weinig  <sam@webkit.org>
601
602         Reviewed by Mark Rowe.
603
604         First step in tracking the urls a HistoryItem was redirected through.
605
606         * WebHistoryItem.cpp:
607         (WebHistoryItem::initFromDictionaryRepresentation):
608         (WebHistoryItem::dictionaryRepresentation):
609
610 2009-01-29  Adam Roben  <aroben@apple.com>
611
612         Fix Bug 23623: Windowed Flash instances aren't captured when a WebView
613         receives a WM_PRINTCLIENT message
614
615         <https://bugs.webkit.org/show_bug.cgi?id=23623>
616         <rdar://problem/6513921>
617         <rdar://problem/6536874>
618
619         Reviewed by Darin Adler.
620
621         * WebFrame.cpp:
622         (WebFrame::paintDocumentRectToContext):
623         (WebFrame::spoolPages):
624         Call GraphicsContext::setShouldIncludeChildWindows so that child
625         windows will be painted into the GraphicsContext rather than painted
626         directly to the screen.
627
628         * WebView.cpp:
629         (WebView::updateBackingStore): Added a windowsToPaint parameter, which
630         we pass along to paintIntoBackingStore.
631
632         (WebView::paint): Tell updateBackingStore to paint child windows if
633         we're not painting to the screen.
634
635         (WebView::paintIntoBackingStore): Added a windowsToPaint paramter,
636         which we use to tell our GraphicsContext whether or not to include
637         child windows.
638
639         * WebView.h: Added windowsToPaint parameters to paintIntoBackingStore
640         and updateBackingStore (which I also made private).
641
642 2009-01-29  Adam Roben  <aroben@apple.com>
643
644         Build fix after r40353
645
646         * WebCoreSupport/WebFrameLoaderClient.cpp:
647         (WebFrameLoaderClient::loadURLIntoChild): Removed the check for
648         FrameLoadTypeReloadAllowingStaleData.
649
650 2009-01-28  Geoffrey Garen  <ggaren@apple.com>
651
652         Reviewed by Sam Weinig.
653
654         Updated for WebCore rename.
655         
656         * WebView.cpp:
657         (WebView::setCustomTextEncodingName):
658
659 2009-01-27  Brady Eidson  <beidson@apple.com>
660
661         Reviewed by Dan Bernstein
662
663         Rework FrameLoaderClient to work on a CachedFrame basis instead of CachedPage
664
665         * WebCoreSupport/WebFrameLoaderClient.cpp:
666         (WebFrameLoaderClient::savePlatformDataToCachedFrame):
667         (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
668         * WebCoreSupport/WebFrameLoaderClient.h:
669
670         * WebFrame.cpp:
671         * WebFrame.h:
672
673 2009-01-26  Adam Roben  <aroben@apple.com>
674
675         Fix an assertion failure when Safari loads an error page
676
677         Reviewed by Alexey Proskuryakov.
678
679         * WebFrame.cpp:
680         (WebFrame::loadData): Use the two-argument version of KURL and
681         MarshallingHelpers::BSTRToKURL, for reasons mentioned in r40248.
682
683 2009-01-26  Adam Roben  <aroben@apple.com>
684
685         Fix an assertion on launch in KURL::KURL
686
687         All URL strings passed in to the WebKit API need to be passed to
688         MarshallingHelpers::BSTRToKURL so that they may be properly parsed.
689
690         Reviewed by Alexey Proskuryakov.
691
692         * MarshallingHelpers.cpp:
693         (MarshallingHelpers::BSTRToKURL): Changed to use the two-argument
694         constructor for KURL so that the strings will be parsed rather than
695         assumed to be in the correct encoding/form.
696
697         * WebResource.cpp:
698         (WebResource::initWithData):
699         * WebURLResponse.cpp:
700         (WebURLResponse::initWithURL):
701         * WebView.cpp:
702         (WebView::userAgentForURL):
703         (WebView::copyURL):
704         Changed to use MarshallingHelpers::BSTRToKURL instead of trying to do
705         the work manually.
706
707 2009-01-25  Darin Adler  <darin@apple.com>
708
709         Try to fix Windows build.
710
711         * WebView.cpp: Added FloatQuad.h.
712
713 2009-01-23  Brent Fulgham  <bfulgham@webkit.org>
714
715         Reviewed by Darin Adler
716
717         https://bugs.webkit.org/show_bug.cgi?id=23492
718         Exclude calls to WebKitSystemInterface functions when not
719         using CoreGraphics.
720
721         * WebPreferences.cpp:
722         (WebPreferences::setFontSmoothing): 
723         (WebPreferences::setFontSmoothingContrast):
724         * WebTextRenderer.cpp:
725         (WebTextRenderer::registerPrivateFont):
726
727 2009-01-23  Brady Eidson  <beidson@apple.com>
728
729         Rubberstamped by Darin Adler
730
731         Rename CachedPagePlatformData to CachedFramePlatformData to more accurately reflect its true role.
732
733         * WebCachedFramePlatformData.h: Copied from WebKit/win/WebCachedPagePlatformData.h.
734         (WebCachedFramePlatformData::WebCachedFramePlatformData):
735         * WebCachedPagePlatformData.h: Removed.
736
737         * WebCoreSupport/WebFrameLoaderClient.cpp:
738         (WebFrameLoaderClient::savePlatformDataToCachedPage):
739
740         * WebKit.vcproj/WebKit.vcproj:
741
742 2009-01-22  Eric Roman  <eroman@chromium.org>
743
744         Reviewed by Eric Seidel.
745
746         https://bugs.webkit.org/show_bug.cgi?id=20806
747         Deprecate RSSFeedReferrer() and setRSSFeedReferrer().
748
749         * WebHistoryItem.cpp:
750         (WebHistoryItem::RSSFeedReferrer):
751         (WebHistoryItem::setRSSFeedReferrer):
752
753 2009-01-19  Sam Weinig  <sam@webkit.org>
754
755         Rubber-stamped by Gavin Barraclough.
756
757         Remove temporary operator-> from JSValuePtr.
758
759         * WebScriptCallFrame.cpp:
760         (WebScriptCallFrame::jsValueToString):
761         * WebView.cpp:
762         (WebView::stringByEvaluatingJavaScriptFromString):
763
764 2009-01-19  Adam Roben  <aroben@apple.com>
765
766         Windows build fix
767
768         * DOMCoreClasses.cpp: Replaced "using namespace WebCore" with
769         individual using directives for each type we need from that namespace,
770         to avoid conflicts between DOMObject and WebCore::DOMObject.
771         (DOMElement::font): Added a now-needed WebCore::.
772
773 2009-01-17  Steve Falkenburg  <sfalken@apple.com>
774
775         Build fix.
776
777         * WebCoreSupport/WebDragClient.cpp:
778         (WebDragClient::createDragImageForLink):
779
780 2009-01-17  David Hyatt  <hyatt@apple.com>
781
782         Eliminate dependencies on backslashAsCurrencySymbol from WebKit.
783
784         Reviewed by Oliver Hunt
785
786         * WebFrame.cpp:
787         (WebFrame::selectedString):
788
789 2009-01-16  Steve Falkenburg  <sfalken@apple.com>
790
791         <rdar://problem/6502511> Safari crashes if it's running while the desktop theme is changed.
792         
793         This was caused by mismatched ENABLE definitions across WebCore and WebKit.
794         
795         Several virtual methods were added to RenderTheme.h, conditionalized by ENABLE(VIDEO).
796         In addition to adding ENABLE_VIDEO to WebKit, this change also adds ENABLE_DATABASE and ENABLE_ICONDATABASE
797         to Windows WebCore/WebKit, and adds ENABLE_WORKERS, and several ENABLE_SVG_ flags to WebKit on Windows.
798         Our Windows ENABLE flags now match Mac.
799         
800         Reviewed by Adele Peterson.
801
802         * WebKit.vcproj/WebKit.vcproj:
803
804 2009-01-15  Adele Peterson  <adele@apple.com>
805
806         Reviewed by Darin Adler.
807         
808         Fix for https://bugs.webkit.org/show_bug.cgi?id=21799
809         <rdar://problem/6310684> Crash in dumpFramesAsText() when running http/tests/security/cross-origin-xsl-BLOCKED.html
810         
811         Return S_OK or E_FAIL based on the result from CreateInstance.
812         This was causing DumpRenderTree to not realize it had just gotten a null documentElement.
813         
814         * DOMCoreClasses.cpp: Made all functions that return the result of CreateInstance consistent.
815         (DOMNode::parentNode):
816         (DOMNode::ownerDocument):
817         (DOMNodeList::item):
818         (DOMDocument::documentElement):
819         (DOMDocument::createElement):
820         (DOMDocument::getElementsByTagName):
821         (DOMDocument::getElementsByTagNameNS):
822         (DOMDocument::getElementById):
823         (DOMDocument::getComputedStyle):
824         (DOMDocument::createEvent):
825         (DOMElement::style):
826
827 2009-01-14  Adele Peterson  <adele@apple.com>
828
829         Reviewed by Darin Adler.
830
831         Fix for https://bugs.webkit.org/show_bug.cgi?id=23335
832         <rdar://problem/6247650> Update <input type="search"> for RenderThemeWin
833         
834         Added artwork.
835         
836         * WebKit.vcproj/WebKit.rc:
837         * WebKit.vcproj/WebKit.vcproj:
838         * WebKit.vcproj/resource.h:
839         * WebKit.vcproj/searchCancel.png: Added.
840         * WebKit.vcproj/searchCancelPressed.png: Added.
841         * WebKit.vcproj/searchMagnifier.png: Added.
842         * WebKit.vcproj/searchMagnifierResults.png: Added.
843         * WebKitDLL.cpp:(loadResourceIntoBuffer):
844
845 2009-01-14  Dan Bernstein  <mitz@apple.com>
846
847         Reviewed by John Sullivan.
848
849         - update copyright
850
851         * WebKit.resources/Info.plist:
852         * WebKit.vcproj/WebKit.rc:
853
854 2009-01-13  Steve Falkenburg  <sfalken@apple.com>
855
856         Build fix.
857
858         * WebScriptCallFrame.cpp:
859         (WebScriptCallFrame::jsValueToString):
860
861 2009-01-12  Brady Eidson  <beidson@apple.com>
862
863         Reviewed by Dan Bernstein
864         
865         <rdar://problem/6490446> - Crash when going back to a cached page
866
867         * WebCoreSupport/WebFrameLoaderClient.cpp:
868         (WebFrameLoaderClient::savePlatformDataToCachedPage):  ENABLE(CFNETWORK) needed to be USE(CFNETWORK)
869
870 2009-01-12  Brady Eidson  <beidson@apple.com>
871
872         Reviewed by Darin Adler
873
874         <rdar://problem/6468274> - Track Non-get requests in global history
875
876         * WebCoreSupport/WebFrameLoaderClient.cpp:
877         (WebFrameLoaderClient::updateGlobalHistory):
878
879         * WebHistory.cpp:
880         (WebHistory::addItem):
881         * WebHistory.h:
882
883         * Interfaces/IWebHistoryItemPrivate.idl:
884         * WebHistoryItem.cpp:
885         (WebHistoryItem::initFromDictionaryRepresentation):
886         (WebHistoryItem::dictionaryRepresentation):
887         (WebHistoryItem::lastVisitWasHTTPNonGet):
888         (WebHistoryItem::setLastVisitWasHTTPNonGet):
889         * WebHistoryItem.h:
890
891 2009-01-12  Julien Chaffraix  <jchaffraix@pleyo.com>
892
893         Reviewed by Darin Adler.
894
895         Bug 22861: Turn the FontCache into a singleton
896         https://bugs.webkit.org/show_bug.cgi?id=22861
897
898         * WebCoreStatistics.cpp:
899         (WebCoreStatistics::cachedFontDataCount):
900         (WebCoreStatistics::cachedFontDataInactiveCount):
901         (WebCoreStatistics::purgeInactiveFontData):
902         Redirected all the static calls to the global FontCache
903         instance.
904
905 2009-01-11  Dmitry Titov  <dimich@chromium.org>
906
907         Reviewed by Darin Adler.
908
909         https://bugs.webkit.org/show_bug.cgi?id=23207
910         Moved currentTime() to from WebCore to WTF.
911
912         * WebDownload.cpp: a different header file included.
913         * WebDropSource.cpp: a different header file included.
914
915 2009-01-09  Darin Adler  <darin@apple.com>
916
917         Reviewed by Jon Honeycutt.
918
919         Bug 22913: REGRESSION: Space bar doesn't scroll on windows
920         https://bugs.webkit.org/show_bug.cgi?id=22913
921         rdar://problem/6479834
922
923         * WebView.cpp:
924         (WebView::keyPress): Removed code to handle space bar here; put it in
925         WebCore instead.
926
927 2009-01-09  Brent Fulgham  <bfulgham@gmail.com>
928
929         Reviewed by Adam Roben.
930
931         Fixes: http://bugs.webkit.org/show_bug.cgi?id=23092
932         Separate CFNetwork-specific code in WebKit.dll into separate
933         implementation files. Create cURL stub files to be populated
934         with new implementation in a future bug report. 
935
936         * WebCookieManager.cpp: Move CFNetwork-specific routines to
937           the new WebCookieManagerCFNet.cpp file.
938         (WebCookieManager::Release):
939         * WebCookieManagerCFNet.cpp: Copied from WebCookieManager.cpp.
940         (WebCookieManager::cookieStorage):
941         * WebCookieManagerCurl.cpp: Added.
942         (WebCookieManager::cookieStorage):
943         (WebCookieManager::setCookieStorage):
944         * WebCoreSupport/WebFrameLoaderClient.cpp: Conditionalize two
945           methods in this file.
946         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
947         (WebFrameLoaderClient::savePlatformDataToCachedPage):
948         * WebDownload.cpp: Move CFNetwork-specific logic to the new
949           WebDownloadCFNet.cpp
950         (WebDownload::bundleExtension):
951         (WebDownload::bundleMagicNumber):
952         (WebDownload::bundlePathForTargetPath):
953         (WebDownload::extractResumeDataFromBundle): Made static class method
954           so it could be used in WebDownload.cpp and WebDownloadCFNet.cpp
955         (WebDownload::appendResumeDataToBundle): Made static class method
956           so it could be used in WebDownload.cpp and WebDownloadCFNet.cpp
957         * WebDownload.h:
958         * WebDownloadCFNet.cpp: Copied from WebDownload.cpp.
959         (WebDownload::initToResumeWithBundle):
960         (WebDownload::setDestination):
961         (didFailCallback):
962         * WebDownloadCurl.cpp: Added.
963         (WebDownload::init):
964         (WebDownload::initWithRequest):
965         (WebDownload::initToResumeWithBundle):
966         (WebDownload::start):
967         (WebDownload::cancel):
968         (WebDownload::cancelForResume):
969         (WebDownload::deletesFileUponFailure):
970         (WebDownload::setDeletesFileUponFailure):
971         (WebDownload::setDestination):
972         (WebDownload::cancelAuthenticationChallenge):
973         (WebDownload::continueWithoutCredentialForAuthenticationChallenge):
974         (WebDownload::useCredential):
975         * WebKit.vcproj/WebKit.vcproj: Modify Apple targets to exclude the
976           new cURL files. Modify Cairo targets to exclude CFNet files.
977         * WebMutableURLRequest.cpp: Conditionalize the single method
978           with a CFNetwork-speicic call.
979         (WebMutableURLRequest::mutableCopy):
980         * WebURLAuthenticationChallenge.cpp: Conditionalize one line that
981           causes build problems for cURL. This will be removed later.
982         (WebURLAuthenticationChallenge::initWithProtectionSpace):
983         * WebURLAuthenticationChallengeSender.cpp:
984         * WebURLAuthenticationChallengeSenderCFNet.cpp: Copied from WebURLAuthenticationChallengeSender.cpp.
985         (WebURLAuthenticationChallengeSender::useCredential):
986         * WebURLAuthenticationChallengeSenderCurl.cpp: Added.
987         (WebURLAuthenticationChallengeSender::cancelAuthenticationChallenge):
988         (WebURLAuthenticationChallengeSender::continueWithoutCredentialForAuthenticationChallenge):
989         (WebURLAuthenticationChallengeSender::useCredential):
990         * WebURLResponse.cpp: Exclude WebKitSystemInterface when compiling
991           for the cURL target.
992
993 2009-01-09  Alexey Proskuryakov  <ap@webkit.org>
994
995         Reviewed by Darin Adler.
996
997         Fix many appcache tests on Windows by making synchronous XMLHttpRequest throw on cache miss.
998
999         * WebFrame.cpp: (WebFrame::cannotShowURLError): Implement, so that synchronous XHR can
1000         raise exceptions, as needed for AppCache tests. I do not know why this error was not
1001         implemented.
1002
1003 2009-01-09  Darin Adler  <darin@apple.com>
1004
1005         Reviewed and landed by Adele Peterson.
1006
1007         Bug 23160: add setMemoryCacheClientCallsEnabled SPI so Safari can be faster with activity window closed
1008         https://bugs.webkit.org/show_bug.cgi?id=23160
1009
1010         * Interfaces/IWebViewPrivate.idl: Added setMemoryCacheDelegateCallsEnabled.
1011         * WebView.cpp:
1012         (WebView::setMemoryCacheDelegateCallsEnabled): Ditto.
1013         * WebView.h: Ditto.
1014
1015 2009-01-08  Dan Bernstein  <mitz@apple.com>
1016
1017         Reviewed by Adam Roben.
1018
1019         - WebPreferences changes to support Core Graphics native glyph drawing
1020
1021         * Interfaces/IWebPreferencesPrivate.idl: Added font smoothing contrast
1022         getter and setter.
1023         * WebPreferenceKeysPrivate.h: Added
1024         WebKitFontSmoothingContrastPreferenceKey.
1025         * WebPreferences.cpp:
1026         (WebPreferences::initializeDefaultSettings): Initialized
1027         WebKitFontSmoothingContrastPreferenceKey to 2.
1028         (WebPreferences::setFloatValue): Added.
1029         (WebPreferences::setFontSmoothing): Changed to map
1030         FontSmoothingTypeWindows to FontSmoothingTypeMedium.
1031         (WebPreferences::fontSmoothingContrast): Added.
1032         (WebPreferences::setFontSmoothingContrast): Added. Calls
1033         wkSetFontSmoothingContrast().
1034         * WebPreferences.h:
1035
1036 2009-01-08  Steve Falkenburg  <sfalken@apple.com>
1037
1038         <rdar://problem/6474244> REGRESSION(39561-39603): Heap corruption when saving passwords?
1039         
1040         Reviewed by Adam Roben.
1041
1042         * WebView.cpp:
1043         (WebViewWndProc): Hold a ref to the WebView inside the WNDPROC, since it could go away in an event handler.
1044
1045 2009-01-07  Jon Honeycutt  <jhoneycutt@apple.com>
1046
1047         Fix a crash with querying a WebView for its global history item when
1048         its associated Page has no global history item.
1049
1050         Reviewed by Dan Bernstein.
1051
1052         * WebView.cpp:
1053         (WebView::globalHistoryItem): If the Page has no global history item,
1054         report 0.
1055
1056 2009-01-06  Adam Roben  <aroben@apple.com>
1057
1058         Fix Bug 22262: Clicking close ("X") button in docked Web Inspector
1059         clears Web Inspector but doesn't close it
1060
1061         <https://bugs.webkit.org/show_bug.cgi?id=22262>
1062         <rdar://problem/6371873>
1063
1064         Reviewed by Darin Adler.
1065
1066         * WebCoreSupport/WebInspectorClient.cpp:
1067         (WebInspectorClient::WebInspectorClient): Initialize new member.
1068         (WebInspectorClient::showWindow): Moved code from here to
1069         showWindowWithoutNotifications.
1070         (WebInspectorClient::closeWindow): Moved code from here to
1071         closeWindowWithoutNotifications.
1072
1073         (WebInspectorClient::attachWindow):
1074         (WebInspectorClient::detachWindow):
1075         Record whether or not we should be attached, then close and reopen the
1076         window without notifying the InspectorController. Code that was in
1077         these functions moved to showWindowWithoutNotifications and
1078         closeWindowWithoutNotifications, respectively.
1079
1080         (WebInspectorClient::closeWindowWithoutNotifications): Added. Code
1081         came from closeWindow and detachWindow.
1082         (WebInspectorClient::showWindowWithoutNotifications): Added. Code came
1083         from showWindow and attachWindow.
1084
1085         * WebCoreSupport/WebInspectorClient.h: Added
1086         {close,show}WindowWithoutNotifications and m_shouldAttachWhenShown.
1087
1088 2009-01-06  Anders Carlsson  <andersca@apple.com>
1089
1090         Reviewed by Sam Weinig.
1091
1092         Add a way for application to provide custom, full frame, views for certain MIME types.
1093         
1094         * Interfaces/IWebEmbeddedView.idl:
1095         Add loading related methods.
1096         
1097         * Interfaces/IWebViewPrivate.idl:
1098         Add new registerEmbeddedViewMIMEType method.
1099         
1100         * WebCoreSupport/EmbeddedWidget.cpp:
1101         (EmbeddedWidget::didReceiveResponse):
1102         (EmbeddedWidget::didReceiveData):
1103         (EmbeddedWidget::didFinishLoading):
1104         (EmbeddedWidget::didFail):
1105         Implement these and call the IEmbeddedView methods.
1106         
1107         * WebCoreSupport/EmbeddedWidget.h:
1108         Inherit from PluginManualLoader.
1109         
1110         * WebCoreSupport/WebFrameLoaderClient.cpp:
1111         (WebFrameLoaderClient::redirectDataToPlugin):
1112         Handle the case where the widget is an EnbeddedWidget.
1113         
1114         (WebFrameLoaderClient::shouldUsePluginDocument):
1115         Have this call WebView::shouldUseEmbeddedView.
1116         
1117         * WebView.cpp:
1118         (WebView::canShowMIMEType):
1119         Have this call WebView::shouldUseEmbeddedView.
1120         
1121         (WebView::registerEmbeddedViewMIMEType):
1122         Add the MIME type to the set.
1123         
1124         (WebView::shouldUseEmbeddedView):
1125         Given a MIME type, returns whether an embedded view should be used or not.
1126         
1127 2009-01-06  David Kilzer  <ddkilzer@apple.com>
1128
1129         BUILD FIX (r39641): Try to fix WebIconDatabase build errors #4
1130
1131         * WebIconDatabase.cpp:
1132         (WebIconDatabase::isEnabled): Added 'WebIconDatabase::' to method
1133         signature.  (Another copy-paste error.)
1134         (WebIconDatabase::setEnabled): Ditto.
1135         * WebIconDatabase.h:
1136         (WebIconDatabase::startUpIconDatabase): Make private again.
1137         (WebIconDatabase::shutDownIconDatabase): Ditto.
1138
1139 2009-01-06  David Kilzer  <ddkilzer@apple.com>
1140
1141         BUILD FIX (r39641): Try to fix build errors #3
1142
1143         Try to fix the following (more specific) build errors:
1144
1145             WebIconDatabase.cpp
1146             ..\WebIconDatabase.cpp(255) : error C2248: 'WebIconDatabase::shutDownIconDatabase' : cannot access private member declared in class 'WebIconDatabase'
1147                     ...\webkit\win\WebIconDatabase.h(61) : see declaration of 'WebIconDatabase::shutDownIconDatabase'
1148                     ...\webkit\win\WebIconDatabase.h(51) : see declaration of 'WebIconDatabase'
1149             ..\WebIconDatabase.cpp(255) : error C2352: 'WebIconDatabase::shutDownIconDatabase' : illegal call of non-static member function
1150                     ...\webkit\win\WebIconDatabase.h(61) : see declaration of 'WebIconDatabase::shutDownIconDatabase'
1151             ..\WebIconDatabase.cpp(258) : error C2248: 'WebIconDatabase::startUpIconDatabase' : cannot access private member declared in class 'WebIconDatabase'
1152                     ...\webkit\win\WebIconDatabase.h(60) : see declaration of 'WebIconDatabase::startUpIconDatabase'
1153                     ...\webkit\win\WebIconDatabase.h(51) : see declaration of 'WebIconDatabase'
1154             ..\WebIconDatabase.cpp(258) : error C2352: 'WebIconDatabase::startUpIconDatabase' : illegal call of non-static member function
1155                     ...\webkit\win\WebIconDatabase.h(60) : see declaration of 'WebIconDatabase::startUpIconDatabase'
1156
1157         * WebIconDatabase.cpp:
1158         (setEnabled): Get instance of shared WebIconDatabase, then call
1159         startUp/shutDown methods on it.
1160         * WebIconDatabase.h:
1161         (WebIconDatabase::startUpIconDatabase): Make protected again.
1162         (WebIconDatabase::shutDownIconDatabase): Ditto.
1163
1164 2009-01-06  David Kilzer  <ddkilzer@apple.com>
1165
1166         BUILD FIX (r39641): Try to fix build errors again
1167
1168         Try to fix the following build errors:
1169
1170             WebIconDatabase.cpp
1171             ..\WebIconDatabase.cpp(255) : error C3861: 'shutDownIconDatabase': identifier not found
1172             ..\WebIconDatabase.cpp(258) : error C3861: 'startUpIconDatabase': identifier not found
1173
1174         * WebIconDatabase.cpp:
1175         (setEnabled): Add class prefix to startUpIconDatabase() and
1176         shutDownIconDatabase().
1177         * WebIconDatabase.h:
1178         (WebIconDatabase::startUpIconDatabase): Make private again.
1179         (WebIconDatabase::shutDownIconDatabase): Ditto.
1180
1181 2009-01-06  David Kilzer  <ddkilzer@apple.com>
1182
1183         BUILD FIX (r39641): Try to fix build error
1184
1185         Try to fix the following build errors:
1186
1187             WebIconDatabase.cpp
1188             ..\WebIconDatabase.cpp(255) : error C3861: 'shutDownIconDatabase': identifier not found
1189             ..\WebIconDatabase.cpp(258) : error C3861: 'startUpIconDatabase': identifier not found
1190
1191         * WebIconDatabase.h:
1192         (WebIconDatabase::startUpIconDatabase): Make protected.
1193         (WebIconDatabase::shutDownIconDatabase): Ditto.
1194
1195 2009-01-06  David Kilzer  <ddkilzer@apple.com>
1196
1197         BUILD FIX (r39641): Fix more silly errors
1198
1199         Fixes the following compilation errors:
1200
1201             WebIconDatabase.cpp
1202             ..\WebIconDatabase.cpp(85) : error C2065: 'standardPrefs' : undeclared identifier
1203             ..\WebIconDatabase.cpp(85) : error C2227: left of '->iconDatabaseLocation' must point to class/struct/union/generic type
1204                     type is ''unknown-type''
1205             ..\WebIconDatabase.cpp(241) : error C2575: 'isEnabled' : only member functions and bases can be virtual
1206             ..\WebIconDatabase.cpp(248) : error C2575: 'setEnabled' : only member functions and bases can be virtual
1207             ..\WebIconDatabase.cpp(253) : error C3861: 'shutDownIconDatabase': identifier not found
1208             ..\WebIconDatabase.cpp(256) : error C3861: 'startUpIconDatabase': identifier not found
1209
1210         * WebIconDatabase.cpp:
1211         (WebIconDatabase::startUpIconDatabase): Redeclare standardPrefs
1212         since this was in init() but not in this method after it was
1213         extracted from init().
1214         (isEnabled): Don't use "virtual" in method implementation
1215         (silly copy-paste error).
1216         (setEnabled): Ditto.
1217
1218 2009-01-06  David Kilzer  <ddkilzer@apple.com>
1219
1220         BUILD FIX (r39641): Remove STDMETHODCALLTYPE from method declarations in IWebIconDatabase.idl
1221
1222         * Interfaces/IWebIconDatabase.idl: Removed "STDMETHODCALLTYPE"
1223         from silly copy-paste error in two method declarations.
1224
1225 2009-01-05  David Kilzer  <ddkilzer@apple.com>
1226
1227         Add API to enable, disable and check state of WebIconDatabase
1228
1229         Reviewed by Darin Adler & Timothy Hatcher.
1230
1231         Add WebIconDatabase::isEnabled() and WebIconDatabase::setEnabled()
1232         API to make it possible to enable, disable and check the state of
1233         the icon database.
1234
1235         * Interfaces/IWebIconDatabase.idl: Declared isEnabled() and
1236         setEnabled() methods.
1237         * WebIconDatabase.cpp:
1238         (WebIconDatabase::init): Extracted code into startUpIconDatabase().
1239         (WebIconDatabase::startUpIconDatabase): Added.  Extracted from
1240         init().
1241         (WebIconDatabase::shutDownIconDatabase): Added.  Method is empty
1242         since there is nothing to do yet on Windows.
1243         (isEnabled): Added.
1244         (setEnabled): Added.
1245         * WebIconDatabase.h: Added method declarations.
1246
1247 2009-01-05  Anders Carlsson  <andersca@apple.com>
1248
1249         Reviewed by Jon Honeycutt.
1250
1251         Pass more information in the property bag passed to embeddedViewWithArguments.
1252         
1253         * Interfaces/IWebUIDelegatePrivate.idl:
1254         Declare new keys.
1255         
1256         * WebCoreSupport/WebFrameLoaderClient.cpp:
1257         (WebFrameLoaderClient::createPlugin):
1258         Pass the base URL, MIME type and the containing element to embeddedViewWithArguments.
1259
1260 2009-01-05  Anders Carlsson  <andersca@apple.com>
1261
1262         Reviewed by Darin Adler, Jon Honeycutt.
1263
1264         Add a templatized COMVariant constructor so we can make COMVariants out of
1265         everything that has a COMVariantSetter specialization.
1266         
1267         Add a COMVariantSetter specialization for COMVariant.
1268         
1269         * COMVariantSetter.h:
1270         (COMVariant::COMVariant):
1271
1272 2009-01-05  Brent Fulgham  <bfulgham@gmail.com>
1273
1274         Reviewed by Oliver Hunt.
1275
1276         Fixes: https://bugs.webkit.org/show_bug.cgi?id=23027
1277
1278         Removes the WebKitGraphics files from the Cairo build, as well
1279         as excluding their link definitions.  These are not used outside
1280         of Safari, and should not be part of the 'Redistributable API.'
1281
1282         * WebKit.vcproj/WebKit.vcproj:  Update *_Cairo targets to exclude
1283           the WebKitGraphics.cpp/.h files.
1284         * WebKit.vcproj/WebKit_Cairo.def: Added.  File without Safari
1285           link definitions.
1286         * WebKit.vcproj/WebKit_Cairo_debug.def: Added.  File without Safari
1287           link definitions.
1288
1289 2009-01-05  Anders Carlsson  <andersca@apple.com>
1290
1291         Reviewed by Jon Honeycutt.
1292
1293         Add a simple, memory managed, wrapper around a VARIANT struuct.
1294         
1295         * COMVariantSetter.h:
1296         (COMVariant::COMVariant):
1297         (COMVariant::~COMVariant):
1298         (COMVariant::operator=):
1299         (COMVariant::copyTo):
1300         (COMVariant::variantType):
1301
1302 2009-01-05  Adele Peterson  <adele@apple.com>
1303
1304         Windows build fix.
1305
1306         * WebCoreSupport/WebChromeClient.cpp:
1307
1308 2009-01-05  Anders Carlsson  <andersca@apple.com>
1309
1310         Reviewed by Adam Roben.
1311
1312         Make it possible to have per value variant types.
1313         
1314         * COMPropertyBag.h:
1315         (::Read):
1316         Call variantType here, passing in the value.
1317         
1318         (::GetPropertyInfo):
1319         Ditto.
1320         
1321         * COMVariantSetter.h:
1322         (COMVariantSetterBase::variantType):
1323         Add COMVariantSetterBase, whose variantType implementation just returns the
1324         VariantType variable. Make all existing classes inherit from COMVariantSetterBase.
1325
1326 2009-01-05  Adam Treat  <adam.treat@torchmobile.com>
1327
1328         Fix win build
1329
1330         * WebCoreSupport/WebChromeClient.h:
1331
1332 2009-01-05  Adam Treat  <adam.treat@torchmobile.com>
1333
1334         Reviewed by George Staikos.
1335
1336         Build fix for contentsSizeChanged
1337
1338         * WebCoreSupport/WebChromeClient.cpp:
1339         (WebChromeClient::contentsSizeChanged):
1340         * WebCoreSupport/WebChromeClient.h:
1341
1342 2009-01-05  Anders Carlsson  <andersca@apple.com> 
1343
1344         Reviewed by Kevin Decker.
1345
1346         Use the ManualLoader class instead of assuming that the manual loader
1347         is a plug-in view.
1348         
1349         * WebCoreSupport/WebFrameLoaderClient.cpp:
1350         (WebFrameLoaderClient::WebFrameLoaderClient):
1351         (WebFrameLoaderClient::setMainDocumentError):
1352         (WebFrameLoaderClient::committedLoad):
1353         (WebFrameLoaderClient::finishedLoading):
1354         (WebFrameLoaderClient::redirectDataToPlugin):
1355         * WebCoreSupport/WebFrameLoaderClient.h:
1356
1357 2009-01-04  Adam Treat  <adam.treat@torchmobile.com>
1358
1359         Reviewed by George Staikos.
1360
1361         Make the apple windows port build with the new fixedLayoutSize feature
1362
1363         * WebCoreSupport/WebFrameLoaderClient.cpp:
1364         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1365
1366 2008-12-20  Dan Bernstein  <mitz@apple.com>
1367
1368         Reviewed by Ada Chan.
1369
1370         - expose the new allItems() method via a new IWebHistoryPrivate
1371           interface
1372
1373         * Interfaces/IWebHistoryPrivate.idl: Added.
1374         * Interfaces/WebKit.idl: Added IWebHistoryPrivate.idl.
1375         * WebHistory.cpp:
1376         (WebHistory::QueryInterface): Added IWebHistoryPrivate.
1377         (WebHistory::allItems):
1378         * WebHistory.h:
1379
1380 2008-12-19  Geoffrey Garen  <ggaren@apple.com>
1381
1382         Build fix.
1383
1384         * WebHistory.cpp:
1385         (WebHistory::allItems):
1386
1387 2008-12-19  Geoffrey Garen  <ggaren@apple.com>
1388
1389         Reviewed by Darin Adler, Adele Peterson, Brady Eidson.
1390         
1391         Added SPI for getting an unsorted vector of all items in history.
1392         
1393         * WebHistory.cpp:
1394         (WebHistory::orderedItemsLastVisitedOnDay):
1395         (WebHistory::allItems):
1396         * WebHistory.h:
1397
1398 2008-12-18  Dan Bernstein  <mitz@apple.com>
1399
1400         Reviewed by Sam Weinig.
1401
1402         - implement FrameLoaderClient::shouldUseCredentialStorage() by calling
1403           a new resource load delegae method.
1404
1405         * Interfaces/IWebResourceLoadDelegatePrivate.idl: Added
1406         a ne interface, IWebResourceLoadDelegatePrivate2, including a new
1407         method, shouldUseCredentialStorage().
1408         * WebCoreSupport/WebFrameLoaderClient.cpp:
1409         (WebFrameLoaderClient::shouldUseCredentialStorage): Added. Calls the
1410         delegate method. If the method is unimplemented, returns true for
1411         backwards compatibility.
1412         * WebCoreSupport/WebFrameLoaderClient.h:
1413
1414 2008-12-18  Sam Weinig  <sam@webkit.org>
1415
1416         Reviewed by John Sullivan.
1417
1418         Implement FrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout() by calling
1419         a new private frame load delegate method.
1420
1421         * Interfaces/IWebFrameLoadDelegatePrivate.idl:
1422         * WebCoreSupport/WebFrameLoaderClient.cpp:
1423         (WebFrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):
1424         * WebCoreSupport/WebFrameLoaderClient.h:
1425
1426 2008-12-16  Steve Falkenburg  <sfalken@apple.com>
1427
1428         Windows build fix.
1429         
1430         Reviewed by Stephanie Lewis.
1431
1432         * COMPropertyBag.h:
1433         (::createInstance):
1434         (::adopt):
1435         (::QueryInterface):
1436         (::AddRef):
1437         (::Release):
1438         (::Read):
1439         (::Write):
1440         (::CountProperties):
1441         (::GetPropertyInfo):
1442         (::LoadObject):
1443         * WebURLResponse.cpp:
1444         (WebURLResponse::allHeaderFields):
1445
1446 2008-12-16  Stephanie Lewis  <slewis@apple.com>
1447
1448         Another Windows Build Fix.
1449
1450         * WebURLResponse.cpp:
1451         (WebURLResponse::allHeaderFields):
1452
1453 2008-12-14  Dan Bernstein  <mitz@apple.com>
1454
1455         Reviewed by Darin Adler.
1456
1457         - Windows equivalent of <rdar://problem/3258561>
1458           WebHistoryAllItemsRemovedNotification should add items to userInfo
1459
1460         * WebHistory.cpp:
1461         (WebHistory::removeAllItems): Changed to create an array of all items
1462         and send it in the notification.
1463
1464 2008-12-12  Brent Fulgham  <bfulgham@gmail.com>
1465
1466         Reviewed by Oliver Hunt.
1467
1468         Fixes: https://bugs.webkit.org/show_bug.cgi?id=22805
1469
1470         Provides implementation of image drag for Windows Cairo back-end.
1471         Switch to generic PlatformGraphicsContext data type, rather than
1472         specific use of CoreGraphics types.
1473
1474         * WebCoreSupport/WebDragClient.cpp:
1475         (WebDragClient::createDragImageForLink): Revise calls to use more
1476         generic PlatformGraphicsContext data types and calls for better
1477         portability.
1478
1479 2008-12-12  Steve Falkenburg  <sfalken@apple.com>
1480
1481         Update Windows cache sizes to match recent Mac change.
1482         
1483         Reviewed by Stephanie Lewis, Sam Weinig.
1484
1485         * WebView.cpp:
1486         (WebView::setCacheModel):
1487
1488 2008-12-12  Tor Arne Vestbø  <tavestbo@trolltech.com>
1489
1490         Rubber-stamped by Oliver Hunt.
1491
1492         Remove mutables from EmbeddedWidget
1493
1494         We can do this now that frameRectsChanged() is no longer const
1495
1496         * WebCoreSupport/EmbeddedWidget.h:
1497
1498 2008-12-11  Cameron Zwarich  <zwarich@apple.com>
1499
1500         Rubber-stamped by Mark Rowe.
1501
1502         Roll out r39212 due to assertion failures during layout tests, multiple
1503         layout test failures, memory leaks, and obvious incorrectness.
1504
1505         * Interfaces/IWebPreferencesPrivate.idl:
1506         * WebPreferenceKeysPrivate.h:
1507         * WebPreferences.cpp:
1508         * WebPreferences.h:
1509
1510 2008-12-10  Glenn Wilson  <gwilson@google.com>
1511
1512         Reviewed by Adam Roben.
1513
1514         Added support for overriding default preferences per-test.
1515         https://bugs.webkit.org/show_bug.cgi?id=20534
1516         Two new methods were added: resetToDefaults and overridePreference.
1517
1518         * Interfaces/IWebPreferencesPrivate.idl: new method signatures
1519         * WebPreferenceKeysPrivate.h: added new key for internal state
1520         * WebPreferences.cpp: added new methods
1521         (WebPreferences::overridePreference): new method
1522         (WebPreferences::resetToDefaults): new method
1523         * WebPreferences.h: new method signatures
1524
1525 2008-12-08  Tor Arne Vestbø  <tavestbo@trolltech.com>
1526
1527         Reviewed by Darin Adler and Holger Freyther.
1528
1529         Make Widget::frameRectsChanged() and overrides non-const
1530
1531         This will hopefully allow us to get rid of some of the mutables in
1532         the classes that react to the callback by changing their own state.
1533
1534         * WebCoreSupport/EmbeddedWidget.cpp:
1535         (EmbeddedWidget::frameRectsChanged):
1536         * WebCoreSupport/EmbeddedWidget.h:
1537
1538 2008-12-09  Brett Wilson  <brettw@chromium.org>
1539
1540         Reviewed by Dave Hyatt.
1541
1542         https://bugs.webkit.org/show_bug.cgi?id=22177
1543
1544         Add a callback on ChromeClient that the state of form elements on
1545         the page has changed. This is to allow clients implementing session
1546         saving to know when the current state is dirty.
1547
1548         * WebCoreSupport/WebChromeClient.h:
1549         (WebChromeClient::formStateDidChange):
1550
1551 ks2008-12-08  Dan Bernstein  <mitz@apple.com>
1552
1553         Reviewed by Adam Roben.
1554
1555         - Fix nightly builds
1556
1557         * Interfaces/IWebViewPrivate.idl: Moved globalHistoryItem() to the end,
1558         so that it comes after all methods used by Safari 3.2.1.
1559
1560 2008-12-08  Dan Bernstein  <mitz@apple.com>
1561
1562         Reviewed by John Sullivan.
1563
1564         - WebKit/win part of tracking the global history item for a WebView
1565
1566         * Interfaces/IWebViewPrivate.idl: Declared globalHistoryItem()
1567         * WebView.cpp:
1568         (WebView::globalHistoryItem): Added. Gets the page's global history
1569         item.
1570         * WebView.h:
1571
1572 2008-12-06  Simon Fraser  <simon.fraser@apple.com>
1573
1574         Reviewed by Dave Hyatt
1575
1576         https://bugs.webkit.org/show_bug.cgi?id=15671
1577
1578         Renderer::caretRect() is now localCaretRect(), which needs
1579         converting to absolute coordinates (taking transforms into account).
1580
1581         * WebView.cpp:
1582         (WebView::handleContextMenuEvent):
1583
1584 2008-12-05  Darin Adler  <darin@apple.com>
1585
1586         Reviewed by Alexey Proskuryakov.
1587
1588         - fix https://bugs.webkit.org/show_bug.cgi?id=22674
1589           Webkit r39005 does not start, an entry point not found
1590
1591         * WebView.cpp:
1592         (findCFNetworkModule): Added.
1593         (findCopySharedURLCacheFunction): Added.
1594         (WebView::setCacheModel): Call CFURLCacheCopySharedURLCache via dynamic loading
1595         instead of compiling based on which version of CFNetwork headers are present.
1596
1597 2008-12-04  Steve Falkenburg  <sfalken@apple.com>
1598
1599         Implement IPropertyBag2::Read.
1600         Fill in dwType for IPropertyBag2::GetPropertyInfo (we always use PROPBAG2_TYPE_DATA).
1601         https://bugs.webkit.org/show_bug.cgi?id=22659
1602         
1603         This fixes <rdar://problem/6419127> REGRESSION: Forms autocomplete is broken for "other forms"
1604         
1605         Reviewed by Ada Chan, Alice Liu.
1606
1607         * COMPropertyBag.h:
1608         (::Read): Implemented.
1609         (::GetPropertyInfo): Set dwType to PROPBAG2_TYPE_DATA.
1610
1611 2008-12-02  Adam Roben  <aroben@apple.com>
1612
1613         Export new-ish JSCore convenience constructor functions
1614
1615         Reviewed by Jon Honeycutt.
1616
1617         * WebKit.vcproj/WebKit.def:
1618         * WebKit.vcproj/WebKit_debug.def:
1619         Export JSObjectMakeArray, JSObjectMakeDate, and JSObjectMakeRegExp.
1620         Remove duplicate export of JSObjectMakeFunction.
1621
1622 2008-12-02  Michael Moss  <mmoss@chromium.org>
1623
1624         Reviewed by Eric Seidel.
1625
1626         - Fix http/tests/navigation/reload-subframe-*frame.html on Windows.
1627         https://bugs.webkit.org/show_bug.cgi?id=20926
1628
1629         Change 31264 fixed this on Mac (since moved to WebCore/loader/FrameLoader.cpp), but was never ported to Windows.
1630
1631         * WebCoreSupport/WebFrameLoaderClient.cpp:
1632         (WebFrameLoaderClient::loadURLIntoChild):
1633
1634 2008-12-01  Steve Falkenburg  <sfalken@apple.com>
1635
1636         Implement renderedImage for Windows.
1637         https://bugs.webkit.org/show_bug.cgi?25648
1638         
1639         Reviewed by Adam Roben.
1640
1641         * DOMCoreClasses.cpp:
1642         (DOMElement::renderedImage):
1643         * DOMCoreClasses.h:
1644         * Interfaces/DOMPrivate.idl:
1645
1646 2008-12-01  Eric Seidel  <eric@webkit.org>
1647
1648         Reviewed by Adam Roben.
1649
1650         NULL-check documentFrameView() and topDocumentFrameView() it's possible
1651         for either of these methods to return NULL, and this was seen to cause
1652         crashes in Chromium.
1653         https://bugs.webkit.org/show_bug.cgi?id=22572
1654
1655         * AccessibleBase.cpp:
1656         (AccessibleBase::get_accParent):
1657         (AccessibleBase::accLocation):
1658         (AccessibleBase::accHitTest):
1659
1660 2008-11-30  Antti Koivisto  <antti@apple.com>
1661
1662         Another Windows build fix.
1663
1664         * WebCoreStatistics.cpp:
1665         (WebCoreStatistics::javaScriptObjectsCount):
1666
1667 2008-11-30  Antti Koivisto  <antti@apple.com>
1668
1669         Windows build fix.
1670
1671         * WebJavaScriptCollector.cpp:
1672         (WebJavaScriptCollector::objectCount):
1673
1674 2008-11-29  Brent Fulgham  <bfulgham@gmail.com>
1675
1676         Reviewed by Alexey Proskuryakov.
1677
1678         Remove Visual Studio project dependencies on non-redistributable
1679         components in the Debug_Cairo and Release_Cairo build targets.
1680         See https://bugs.webkit.org/show_bug.cgi?id=22527
1681
1682         * WebKit.vcproj/WebKit.vcproj:
1683         * WebKit.vcproj/WebKit.sln: Instruct Cairo builds to not bother
1684           building the unused QuickTime support library.
1685
1686 2008-11-24  Glenn Wilson  <gwilson@chromium.org>
1687
1688         Reviewed by Alexey Proskuryakov.
1689
1690         http://bugs.webkit.org/show_bug.cgi?id=15643
1691
1692         Added API support for the "trailing whitespace" work-around.  This includes an APIs
1693         to get and set the state of this configuration variable.
1694
1695         * Interfaces/IWebView.idl:
1696         * WebCoreSupport/WebEditorClient.cpp:
1697         (WebEditorClient::selectTrailingWhitespaceEnabled):
1698         * WebCoreSupport/WebEditorClient.h:
1699         * WebView.cpp:
1700         (WebView::WebView):
1701         (WebView::setSelectTrailingWhitespaceEnabled):
1702         (WebView::selectTrailingWhitespaceEnabled):
1703         * WebView.h:
1704
1705 2008-11-24  Darin Adler  <darin@apple.com>
1706
1707         Reviewed by Dan Bernstein.
1708
1709         - https://bugs.webkit.org/show_bug.cgi?id=22470
1710           remove unneeded URL argument from FrameLoaderClient::updateGlobalHistory
1711
1712         * WebCoreSupport/WebFrameLoaderClient.cpp:
1713         (WebFrameLoaderClient::updateGlobalHistory): Get the URL from the
1714         DocumentLoader, just as we do the title and the failure flag.
1715         * WebCoreSupport/WebFrameLoaderClient.h: Remove argument.
1716
1717 2008-11-24  Darin Adler  <darin@apple.com>
1718
1719         Reviewed by Dan Bernstein.
1720
1721         - finish https://bugs.webkit.org/show_bug.cgi?id=22295
1722           track which history items are from page load failures
1723
1724         Last time around I did this only for the back/forward list and missed the
1725         global history list.
1726
1727         * Interfaces/IWebHistoryItemPrivate.idl: Added setLastVisitWasFailure.
1728
1729         * WebCoreSupport/WebFrameLoaderClient.cpp:
1730         (WebFrameLoaderClient::updateGlobalHistory): Added code to check for failure
1731         and pass the argument in to WebHistory.
1732
1733         * WebHistory.cpp: (WebHistory::addItem): Added wasFailure argument.
1734         Set the flag on the newly created history item.
1735         * WebHistory.h: Ditto.
1736
1737         * WebHistoryItem.cpp:
1738         (WebHistoryItem::setLastVisitWasFailure): Added.
1739         * WebHistoryItem.h: Ditto.
1740
1741 2008-11-24  Simon Fraser  <simon.fraser@apple.com>
1742
1743         Fix call to Frame::selectionBounds in Windows build.
1744
1745         * WebView.cpp:
1746         (WebView::selectionRect):
1747
1748 2008-11-21  Dimitri Glazkov  <dglazkov@chromium.org>
1749
1750         Reviewed by Alexey Proskuryakov.
1751
1752         Debug WebKit crashes on launch because of threading not being initialized early enough.
1753
1754         * WebKitClassFactory.cpp: (WebKitClassFactory::WebKitClassFactory):
1755         Call JSC::InitializeThreading().
1756
1757 2008-11-19  Darin Fisher  <darin@chromium.org>
1758
1759         Reviewed by Geoff Garen.
1760
1761         https://bugs.webkit.org/show_bug.cgi?id=22345
1762         Define ScriptValue as a thin container for a JSC::Value*.
1763
1764         * WebView.cpp:
1765         (WebView::stringByEvaluatingJavaScriptFromString):
1766
1767 2008-11-19  Adele Peterson  <adele@apple.com>
1768
1769         Reviewed by Darin Adler.
1770
1771         For transparent views, clear the dirty rect instead of painting it white.
1772         
1773         * WebView.cpp: (WebView::paintIntoBackingStore):
1774
1775 2008-11-18  Adele Peterson  <adele@apple.com>
1776
1777         Reverting last change.  I just realized it causes the view to never get cleared out.
1778
1779         * WebView.cpp: (WebView::paintIntoBackingStore):
1780
1781 2008-11-18  Adele Peterson  <adele@apple.com>
1782
1783         Reviewed by John Sullivan.
1784
1785         Don't fill the view with white if its transparent.
1786         
1787         * WebView.cpp: (WebView::paintIntoBackingStore):
1788
1789 2008-11-18  Holger Hans Peter Freyther  <zecke@selfish.org>
1790
1791         Try to fix the Windows build. It is view and not webView.
1792
1793         * WebCoreSupport/WebFrameLoaderClient.cpp:
1794         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1795
1796 2008-11-18  Holger Hans Peter Freyther  <zecke@selfish.org>
1797
1798         Reviewed by Simon Hausmann.
1799
1800         Attempt to share transitionToCommittedForNewPage of FrameLoaderClient with the different ports
1801
1802         After Hyatt's work on Widget and ScrollView there is little difference
1803         between the implementation of Qt, Gtk+ and Win. In fact any kind of
1804         difference is mostly a bug. Alp has fixed two of such errors for the Gtk+
1805         port and the Qt port has at least one of them left.
1806
1807         The only difference between the implementations is in getting the the
1808         IntSize for the new FrameView, the background color to be applied and
1809         eventually some post processing.
1810
1811         Unify the implementations by providing a static helper function that
1812         takes a Frame, IntSize, color and transparency bit and calling it from
1813         the Gtk+, the Qt and the Windows port.
1814
1815         * WebCoreSupport/WebFrameLoaderClient.cpp:
1816         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1817
1818 2008-11-18  Holger Hans Peter Freyther  <zecke@selfish.org>
1819
1820         Reviewed by Simon Hausmann.
1821
1822         https://bugs.webkit.org/show_bug.cgi?id=22056
1823
1824         Move setting the background color and transparency from WebKit/win
1825         to WebCore. This allows WebKit/win, WebKit/Qt and WebKit/Gtk+
1826         to share this code.
1827
1828         * WebFrame.cpp:
1829         (WebFrame::updateBackground):
1830
1831 2008-11-16  Geoffrey Garen  <ggaren@apple.com>
1832
1833         Not reviewed.
1834         
1835         Try to fix Windows build.
1836
1837         * WebCoreSupport/WebFrameLoaderClient.cpp:
1838
1839 2008-11-16  Darin Adler  <darin@apple.com>
1840
1841         Reviewed by Dan Bernstein.
1842
1843         - https://bugs.webkit.org/show_bug.cgi?id=22295
1844           track which history items are from page load failures
1845
1846         * Interfaces/IWebHistoryItemPrivate.idl: Added lastVisitWasFailure function.
1847
1848         * WebHistoryItem.cpp:
1849         (WebHistoryItem::initFromDictionaryRepresentation): Set the lastVisitWasFailure
1850         flag in the history item if the dictionary had an entry for lastVisitWasFailureKey.
1851         (WebHistoryItem::dictionaryRepresentation): Set the lastVisitWasFailureKey key
1852         in the dictionary if the history item had the lastVisitWasFailure flag.
1853         (WebHistoryItem::lastVisitWasFailure): Added.
1854
1855         * WebHistoryItem.h: Added lastVisitWasFailure function.
1856
1857 2008-11-15  Geoffrey Garen  <ggaren@apple.com>
1858
1859         Reviewed by Sam Weinig.
1860         
1861         Updated for JavaScriptCore renames.
1862
1863         * WebScriptCallFrame.cpp:
1864         (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
1865
1866 2008-11-14  Dan Bernstein  <mitz@apple.com>
1867
1868         - try to fix the Windows build
1869
1870         * WebCoreLocalizedStrings.cpp:
1871         (WebCore::contextMenuItemTagTextDirectionMenu): Added.
1872
1873 2008-11-13  Adam Roben  <aroben@apple.com>
1874
1875         Fix Bug 22244: Webkit nightly builds crash with Safari 3.2
1876
1877         <https://bugs.webkit.org/show_bug.cgi?id=22244>
1878
1879         r36652 added IWebViewPrivate::clearMainFrameName into the middle of
1880         the IWebViewPrivate interface, which modifies the part of the
1881         IWebViewPrivate vtable that Safari 3.2 relies on.
1882
1883         Reviewed by Dan Bernstein.
1884
1885         * Interfaces/IWebViewPrivate.idl: Move clearMainFrameName to the end
1886         of the interface.
1887
1888 2008-11-11  Dan Bernstein  <mitz@apple.com>
1889
1890         Reviewed by Adam Roben.
1891
1892         WebKit/win part of adding a master volume control for media elements in a WebView
1893         * Interfaces/IWebViewPrivate.idl: Added setMediaVolume() and
1894         mediaVolume().
1895         * WebView.cpp:
1896         (WebView::setMediaVolume): Added.
1897         (WebView::mediaVolume): Added.
1898         * WebView.h:
1899
1900 2008-11-10  Adam Roben  <aroben@apple.com>
1901
1902         Fix Bug 22158: Would like to turn on WebCore logging channels via an
1903         environment variable
1904
1905         <https://bugs.webkit.org/show_bug.cgi?id=22158>
1906
1907         Reviewed by Anders Carlsson.
1908
1909         * WebView.cpp:
1910         (WebView::initWithFrame): Call WebCore's
1911         InitializeLoggingChannelsIfNecessary.
1912
1913 2008-11-08  Dan Bernstein  <mitz@apple.com>
1914
1915         Reviewed by Darin Adler.
1916
1917         - WebKit/win part of adding WebPreferences for controlling databases and local storage
1918
1919         * Interfaces/IWebPreferencesPrivate.idl: Declared setDatabasesEnabled,
1920         databasesEnabled, setLocalStorageEnabled and localStorageEnabled.
1921         * WebPreferenceKeysPrivate.h: Added WebKitDatabasesEnabledPreferenceKey
1922         and WebKitLocalStorageEnabledPreferenceKey.
1923         * WebPreferences.cpp:
1924         (WebPreferences::initializeDefaultSettings): Made databases and local
1925         storage enabled by default.
1926         (WebPreferences::setDatabasesEnabled): Added.
1927         (WebPreferences::databasesEnabled): Added.
1928         (WebPreferences::setLocalStorageEnabled): Added.
1929         (WebPreferences::localStorageEnabled): Added.
1930         * WebPreferences.h:
1931         * WebView.cpp:
1932         (WebView::notifyPreferencesChanged): Transfer the databases and local
1933         storage preferences to WebCore settings.
1934
1935 2008-11-06  John Sullivan  <sullivan@apple.com>
1936     
1937         Eliminated one of the two booleans tracking whether zoom was text-only, to avoid future problems.
1938     
1939         Reviewed by Adam Roben
1940
1941         * WebView.h:
1942         removed m_zoomMultiplierIsTextOnly
1943         
1944         * WebView.cpp:
1945         (WebView::WebView):
1946         removed initialization of m_zoomMultiplierIsTextOnly
1947         (WebView::setZoomMultiplier):
1948         use m_page->settings()->setZoomsTextOnly() instead of setting m_zoomMultiplierIsTextOnly
1949         (WebView::zoomMultiplier):
1950         use m_page->settings()->zoomsTextOnly() instead of reading m_zoomMultiplierIsTextOnly
1951
1952 2008-11-06  Adele Peterson  <adele@apple.com>
1953
1954         Reviewed by Adam Roben.
1955
1956         Add support for a WebKitZoomsTextOnly preference.
1957
1958         * Interfaces/IWebPreferences.idl:
1959         * WebPreferenceKeysPrivate.h:
1960         * WebPreferences.cpp:
1961         (WebPreferences::setZoomsTextOnly):
1962         (WebPreferences::zoomsTextOnly):
1963         * WebPreferences.h:
1964
1965         * WebView.cpp:
1966         (WebView::canMakeTextLarger): Consider the zoomsTextOnly setting when computing this.
1967         (WebView::makeTextLarger): ditto.
1968         (WebView::canMakeTextSmaller): ditto.
1969         (WebView::makeTextSmaller): ditto.
1970         (WebView::canMakeTextStandardSize): 
1971         Don't consider the setting in this case since we need to reset both text zoom and page zoom regardless of the setting.
1972         (WebView::makeTextStandardSize):
1973         (WebView::notifyPreferencesChanged): Set the WebCore settings to match the WebPreference for WebKitZoomsTextOnly.
1974
1975 2008-11-05  Dan Bernstein  <mitz@apple.com>
1976
1977         Reviewed by John Sullivan.
1978
1979         - make the {protocol,proxyType} argument of
1980           WebURLProtectionSpace::initWith{Proxy}Host actually work and fix
1981           assertion failures.
1982
1983         * WebURLProtectionSpace.cpp:
1984         (WebURLProtectionSpace::initWithHost): The BString comparisons were
1985         applying the BString==BSTR operator to a right hand side that was
1986         actually a WCHAR string. Fixed by using BStrings on both sides.
1987         (WebURLProtectionSpace::initWithProxyHost): Ditto.
1988
1989 2008-11-01  Alexey Proskuryakov  <ap@webkit.org>
1990
1991         Reviewed by Darin Adler.
1992
1993         https://bugs.webkit.org/show_bug.cgi?id=22030
1994         Make EventNames usable from multiple threads
1995
1996         * WebView.cpp: (WebView::interpretKeyEvent): Access event names via eventNames() function.
1997
1998 2008-11-03  Cameron Zwarich  <zwarich@apple.com>
1999
2000         Rubber-stamped by Maciej Stachowiak.
2001
2002         Move more files into the runtime subdirectory of JavaScriptCore.
2003
2004         * WebJavaScriptCollector.cpp:
2005
2006 2008-11-03  Dan Bernstein  <mitz@apple.com>
2007
2008         Reviewed by Steve Falkenburg.
2009
2010         - implement WebMutableURLRequest::setHTTPShouldHandleCookies()
2011         - add and implement WebMutableURLRequest::mutableCopy()
2012
2013         * Interfaces/IWebURLRequest.idl:
2014         * WebMutableURLRequest.cpp:
2015         (WebMutableURLRequest::setHTTPShouldHandleCookies):
2016         (WebMutableURLRequest::mutableCopy):
2017         * WebMutableURLRequest.h:
2018
2019 2008-10-31  Dan Bernstein  <mitz@apple.com>
2020
2021         Reviewed by John Sullivan.
2022
2023         - WebKit/win part of <rdar://problem/6334641> Add WebView SPI for disabling document.cookie
2024
2025         * Interfaces/IWebViewPrivate.idl:
2026         * WebView.cpp:
2027         (WebView::setCookieEnabled):
2028         (WebView::cookieEnabled):
2029         * WebView.h:
2030
2031 2008-10-31  Adele Peterson  <adele@apple.com>
2032
2033         Reviewed by Darin Adler.
2034
2035         WebKit Windows part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.
2036         https://bugs.webkit.org/show_bug.cgi?id=22008
2037         
2038         * WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::runOpenPanel): 
2039         Add support for mulitple file selection.
2040
2041 2008-10-31  Darin Adler  <darin@apple.com>
2042
2043         - try to fix build
2044
2045         * WebView.cpp:
2046         (WebView::setCacheModel): Roll out the part of my last change
2047         that involved no longer using wkCopyFoundationCacheDirectory.
2048
2049 2008-10-30  Darin Adler  <darin@apple.com>
2050
2051         Reviewed by Sam Weinig.
2052
2053         - https://bugs.webkit.org/show_bug.cgi?id=21986
2054           <rdar://problem/6294285> adopt CFURLCopySharedURLCache
2055
2056         * WebView.cpp:
2057         (WebView::setCacheModel): Use CFURLCopySharedURLCache if present.
2058
2059 2008-10-30  Dan Bernstein  <mitz@apple.com>
2060
2061         Reviewed by Sam Weinig.
2062
2063         - export WTFReportAssertionFailureWithMessage()
2064
2065         * WebKit.vcproj/WebKit_debug.def:
2066
2067 2008-10-29  Steve Falkenburg  <sfalken@apple.com>
2068
2069         <rdar://problem/6326563> Crash on launch
2070         
2071         For Windows, export explicit functions rather than exporting data for atomicallyInitializedStaticMutex.
2072         
2073         Exporting data from a DLL on Windows requires specifying __declspec(dllimport) in the header used by
2074         callers, but __declspec(dllexport) when defined in the DLL implementation. By instead exporting
2075         the explicit lock/unlock functions, we can avoid this.
2076         
2077         Fixes a crash on launch, since we were previously erroneously exporting atomicallyInitializedStaticMutex as a function.
2078         
2079         Reviewed by Darin Adler.
2080
2081         * WebKit.vcproj/WebKit.def:
2082         * WebKit.vcproj/WebKit_debug.def:
2083
2084 2008-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2085
2086         Export atomicallyInitializedStaticMutex.
2087
2088         Rubber-stamped by Steve Falkenburg.
2089
2090         * WebKit.vcproj/WebKit.def:
2091         * WebKit.vcproj/WebKit_debug.def:
2092
2093 2008-10-28  Cameron Zwarich  <zwarich@apple.com>
2094
2095         Reviewed by Mark Rowe.
2096
2097         Move ForwardingHeaders to their correct location after the creation of
2098         the runtime directory in JavaScriptCore.
2099
2100         * WebScriptCallFrame.h:
2101
2102 2008-10-28  Adele Peterson  <adele@apple.com>
2103
2104         Reviewed by John Sullivan.
2105
2106         Fix for https://bugs.webkit.org/show_bug.cgi?id=21880
2107         "files" string for multifile uploads needs to be localized
2108
2109         * WebCoreLocalizedStrings.cpp: (multipleFileUploadText):
2110
2111 2008-10-28  Adele Peterson  <adele@apple.com>
2112
2113         Reviewed by Sam Weinig. 
2114
2115         * English.lproj: Removed.
2116         * English.lproj/Localizable.strings: Removed.
2117         * WebKit.vcproj/WebKit.vcproj: Updated to use Localizable.strings in the top directory, to share with the Mac.
2118
2119 2008-10-28  Timothy Hatcher  <timothy@apple.com>
2120
2121         Add IWebInspector methods to enable the profiler.
2122
2123         https://bugs.webkit.org/show_bug.cgi?id=21927
2124
2125         <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
2126         not slow down JavaScript all the time
2127
2128         Reviewed by Darin Adler and Kevin McCullough.
2129
2130         * WebInspector.cpp:
2131         (WebInspector::isJavaScriptProfilingEnabled): Added. Calls InspectorController::profilerEnabled.
2132         (WebInspector::setJavaScriptProfilingEnabled): Added. Call InspectorController's disableProfiler
2133         or enableProfiler methods.
2134         * WebInspector.h:
2135
2136 2008-10-27  Timothy Hatcher  <timothy@apple.com>
2137
2138         Rename a few methods related to attaching and detaching the debugger.
2139
2140         * Rename attachDebugger to enableDebugger.
2141         * Rename detachDebugger to disableDebugger.
2142         * Rename the debuggerAttached getter to debuggerEnabled.
2143
2144         Reviewed by Darin Adler.
2145
2146         * WebInspector.cpp:
2147         (WebInspector::isDebuggingJavaScript):
2148         (WebInspector::toggleDebuggingJavaScript):
2149
2150 2008-10-24  Sam Weinig  <sam@webkit.org>
2151
2152         Yet another windows build fix.
2153
2154         * WebCoreSupport/WebChromeClient.cpp:
2155
2156 2008-10-24  Sam Weinig  <sam@webkit.org>
2157
2158         Another windows build fix.
2159
2160         * WebCoreSupport/WebChromeClient.cpp:
2161
2162 2008-10-24  Sam Weinig  <sam@webkit.org>
2163
2164         Reviewed by Dan Bernstein.
2165
2166         Fix https://bugs.webkit.org/show_bug.cgi?id=21759
2167         Layering violation: FileChooser should not depend on Document/Frame/Page
2168
2169         * WebCoreSupport/WebChromeClient.cpp:
2170         (WebChromeClient::runOpenPanel):
2171         * WebCoreSupport/WebChromeClient.h:
2172
2173 2008-10-24  Timothy Hatcher  <timothy@apple.com>
2174
2175         Implement new InspectorClient methods to work with Settings.
2176
2177         https://bugs.webkit.org/show_bug.cgi?id=21856
2178
2179         Reviewed by Adam Roben.
2180
2181         * WebKit.vcproj/WebKit.vcproj: Add the new InspectorClientCF.cpp file.
2182         * WebCoreSupport/WebInspectorClient.h: Add the new methods.
2183
2184 2008-10-24  Darin Adler  <darin@apple.com>
2185
2186         - finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732
2187
2188         * WebScriptCallFrame.cpp:
2189         (WebScriptCallFrame::jsValueToString):
2190         (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString):
2191         (WebScriptCallFrame::valueForVariable):
2192         (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
2193         * WebScriptCallFrame.h:
2194         * WebView.cpp:
2195         (WebView::stringByEvaluatingJavaScriptFromString):
2196         Use JSValue* instead of JSValuePtr.
2197
2198 2008-10-22  Brent Fulgham  <bfulgham@gmail.com>
2199
2200         Correct build regressions in Cairo port for Windows.
2201         http://bugs.webkit.org/show_bug.cgi?id=21724
2202
2203         Reviewed by Adam Roben.
2204
2205         * WebView.cpp:
2206         (WebView::notifyPreferencesChanged): Don't try to call
2207         setShouldPaintNativeControls when SafariTheme support is disabled, as
2208         that function doesn't exist in that case.
2209
2210 2008-10-22  Brady Eidson  <beidson@apple.com>
2211
2212         Reviewed by Adam Roben
2213         
2214         Move elementDoesAutoComplete() to IWebFramePrivate so it is exposed for DRT to use
2215
2216         * Interfaces/IWebFramePrivate.idl:
2217         
2218         * WebFrame.cpp:
2219         (WebFrame::elementDoesAutoComplete):
2220         * WebFrame.h:
2221         
2222         * WebHTMLRepresentation.cpp:
2223         (WebHTMLRepresentation::elementDoesAutoComplete):
2224
2225 2008-10-20  Sam Weinig  <sam@webkit.org>
2226
2227         Reviewed by Anders Carlsson.
2228
2229         Remove FrameLoaderClient::detachedFromParent4.  It is no longer used by any port.
2230
2231         * WebFrame.cpp:
2232         * WebFrame.h:
2233
2234 2008-10-19  Darin Adler  <darin@apple.com>
2235
2236         Reviewed by Oliver Hunt.
2237
2238         - next step of https://bugs.webkit.org/show_bug.cgi?id=21732
2239           improve performance by eliminating JSValue as a base class for JSCell
2240
2241         Remove most uses of JSValue, which will be removed in a future patch.
2242
2243         * WebScriptCallFrame.cpp:
2244         (WebScriptCallFrame::jsValueToString): Use JSValuePtr.
2245         (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString): Ditto.
2246         (WebScriptCallFrame::valueForVariable): Put more code inside and ifdef.
2247         (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString): Ditto.
2248         * WebScriptCallFrame.h: Use JSValuePtr.
2249
2250         * WebView.cpp:
2251         (WebView::stringByEvaluatingJavaScriptFromString): Use JSValuePtr.
2252
2253 2008-10-18  Dan Bernstein  <mitz@apple.com>
2254
2255         - build fix
2256
2257         * WebScriptCallFrame.cpp:
2258         (WebScriptCallFrame::jsValueToString):
2259
2260 2008-10-18  Dan Bernstein  <mitz@apple.com>
2261
2262         Reviewed by Sam Weinig.
2263
2264         - WebKit/win part of https://bugs.webkit.org/show_bug.cgi?id=21736
2265           Long-dead decoded image data make up for most of the object cache's memory use over time
2266
2267         * WebView.cpp:
2268         (WebView::setCacheModel): In the primary web browser model,
2269         set the cache's dead decoded data deletion interval to 60 seconds.
2270
2271 2008-10-16  Kevin McCullough  <kmccullough@apple.com>
2272
2273         Reviewed by Steve Falkenburg.
2274
2275         <rdar://problem/6292718>
2276         Implement a standard way to get the UA given an application name.
2277
2278         * Interfaces/IWebViewPrivate.idl:
2279         * WebView.cpp:
2280         (WebView::standardUserAgentWithApplicationName):
2281         * WebView.h:
2282
2283 2008-10-17  Dan Bernstein  <mitz@apple.com>
2284
2285         Reviewed by Sam Weinig.
2286
2287         - export WTF::initializeOnMainThread()
2288
2289         * WebKit.vcproj/WebKit.def:
2290         * WebKit.vcproj/WebKit_debug.def:
2291
2292 2008-10-15  Geoffrey Garen  <ggaren@apple.com>
2293
2294         Reviewed by Cameron Zwarich.
2295
2296         Fixed https://bugs.webkit.org/show_bug.cgi?id=21345
2297         Start the debugger without reloading the inspected page
2298
2299         * WebInspector.cpp:
2300         (WebInspector::toggleDebuggingJavaScript): Updated for rename.
2301
2302 2008-10-15  Adam Roben  <aroben@apple.com>
2303
2304         Export WTF::Mutex::tryLock
2305
2306         * WebKit.vcproj/WebKit.def:
2307         * WebKit.vcproj/WebKit_debug.def:
2308
2309 2008-10-14  Jon Honeycutt  <jhoneycutt@apple.com>
2310
2311         Export currentThread.
2312
2313         Rubber-stamped by Dan Bernstein.
2314
2315         * WebKit.vcproj/WebKit.def:
2316         * WebKit.vcproj/WebKit_debug.def:
2317
2318 2008-10-13  Steve Falkenburg  <sfalken@apple.com>
2319
2320         Reorder methods to preserve compatibility.
2321         
2322         Rubber stamped by Oliver Hunt.
2323
2324         * Interfaces/IWebViewPrivate.idl:
2325
2326 2008-10-11  Dan Bernstein  <mitz@apple.com>
2327
2328         Reviewed by Sam Weinig.
2329
2330         - add SPI for forcing the complex text code path to be used for all text
2331
2332         * Interfaces/IWebViewPrivate.idl:
2333         * WebView.cpp:
2334         (WebView::setAlwaysUsesComplexTextCodePath):
2335         (WebView::alwaysUsesComplexTextCodePath):
2336         * WebView.h:
2337
2338 2008-10-10  Ada Chan  <adachan@apple.com>
2339
2340         Bug 21526: The hashmap webPreferencesInstances in WebPreferences.cpp can 
2341         potentially hold onto stale instances of WebPreferences
2342         https://bugs.webkit.org/show_bug.cgi?id=21526
2343         
2344         webPreferencesInstances now keeps a reference to all the instances it holds.
2345         Fix up callers of WebPreferences::removeReferenceForIdentifier() to call 
2346         it after they have released their references to the WebPreferences objects.
2347
2348         Reviewed by Adam Roben.
2349
2350         * WebPreferences.cpp:
2351         (WebPreferences::getInstanceForIdentifier):
2352         (WebPreferences::removeReferenceForIdentifier):
2353         * WebView.cpp:
2354         (WebView::close):
2355         (WebView::setPreferences):
2356
2357 2008-10-06  David Hyatt  <hyatt@apple.com>
2358
2359         Enable viewless Mac WebKit to paint some basic pages.
2360         
2361         Reviewed by Sam Weinig
2362
2363         * WebCoreSupport/WebFrameLoaderClient.cpp:
2364         (WebFrameLoaderClient::createFrame):
2365         * WebCoreSupport/WebFrameLoaderClient.h:
2366
2367 2008-10-03  David Hyatt  <hyatt@apple.com>
2368
2369         https://bugs.webkit.org/show_bug.cgi?id=21340
2370         
2371         Remove "containingWindow()/setContainingWindow()" from Widget.  HostWindow covers this now.
2372         
2373         Reviewed by Dan Bernstein & Darin Adler
2374
2375         * WebCoreSupport/WebFrameLoaderClient.cpp:
2376         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2377         * WebScrollBar.cpp:
2378         (WebScrollBar::WebScrollBar):
2379         (WebScrollBar::init):
2380         (WebScrollBar::invalidateScrollbarRect):
2381         * WebScrollBar.h:
2382
2383 2008-10-03  David Hyatt  <hyatt@apple.com>
2384
2385          Remove addToDirtyRegion.
2386         
2387          Reviewed by Oliver Hunt
2388
2389         * WebCoreSupport/WebChromeClient.cpp:
2390
2391 2008-10-02  David Hyatt  <hyatt@apple.com>
2392
2393         https://bugs.webkit.org/show_bug.cgi?id=21328
2394         
2395         Make widget invalidation more cross-platform.
2396         
2397         (1) Make invalidateRect a pure virtual function on Widget.  All leaf widgets must now implement this function.
2398         
2399         (2) Scrollbars now send invalidations through the ScrollbarClient.  windowClipRect on ScrollbarClient has been removed and replaced with this invalidation call.
2400         This allows all scrollbar invalidations to go through the render tree so that transforms and reflections will be respected.
2401         
2402         (3) Plugins now have the native window invalidation code for windowed plugins.  Windowless plugins do a repaintRectangle on the plugin's renderer.
2403         
2404         (4) FrameViews now do a repaintRectangle on their owner element's renderer.
2405
2406         Reviewed by Sam Weinig
2407
2408         * WebCoreSupport/EmbeddedWidget.cpp:
2409         (EmbeddedWidget::invalidateRect):
2410         * WebCoreSupport/EmbeddedWidget.h:
2411         * WebScrollBar.cpp:
2412         (WebScrollBar::invalidateScrollbarRect):
2413         * WebScrollBar.h:
2414
2415 2008-10-02  Darin Adler  <darin@apple.com>
2416
2417         - https://bugs.webkit.org/show_bug.cgi?id=21321
2418           Bug 21321: speed up JavaScriptCore by inlining Heap in JSGlobalData
2419
2420         * WebCoreStatistics.cpp:
2421         (WebCoreStatistics::javaScriptObjectsCount): Use heap. instead of heap-> to
2422         work with the heap.
2423         (WebCoreStatistics::javaScriptGlobalObjectsCount): Ditto.
2424         (WebCoreStatistics::javaScriptProtectedObjectsCount): Ditto.
2425         (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount): Ditto.
2426         (WebCoreStatistics::javaScriptProtectedObjectTypeCounts): Ditto.
2427         * WebJavaScriptCollector.cpp:
2428         (WebJavaScriptCollector::objectCount): Ditto.
2429
2430 2008-10-02  Dave Hyatt  <hyatt@apple.com>
2431
2432         https://bugs.webkit.org/show_bug.cgi?id=21316
2433
2434         Reviewed by Adele
2435        
2436         * WebCoreSupport/WebFrameLoaderClient.cpp:
2437         (WebFrameLoaderClient::transitionToCommittedForNewPage):
2438
2439 2008-10-02  David Hyatt  <hyatt@apple.com>
2440
2441         https://bugs.webkit.org/show_bug.cgi?id=21314
2442         
2443         Make scrollBackingStore cross-platform.
2444
2445         Reviewed by Sam Weinig
2446
2447         * WebCoreSupport/WebChromeClient.cpp:
2448         (WebChromeClient::repaint):
2449         (WebChromeClient::scroll):
2450         * WebCoreSupport/WebChromeClient.h:
2451         * WebView.cpp:
2452         (WebView::repaint):
2453         * WebView.h:
2454
2455 2008-10-01  David Hyatt  <hyatt@apple.com>
2456
2457         https://bugs.webkit.org/show_bug.cgi?id=21298
2458         
2459         Make updateScrollbars cross-platform.  For now a stubbed out scrollContents function is invoked to do the scrolling of the backing store.  Next patch
2460         will make that cross-platform.  
2461         
2462         The ScrollView now implements ScrollbarClient, which means that there was a clash of windowClipRect methods from the
2463         multiple inheritance.  For now I solved this by adding a Scrollbar* to the ScrollbarClient version of the method, but longer term
2464         windowClipRect is going to be removed from ScrollbarClient (when Widget invalidation gets rewritten).
2465
2466         Reviewed by Sam Weinig
2467
2468         * WebScrollBar.cpp:
2469         (WebScrollBar::windowClipRect):
2470         * WebScrollBar.h:
2471
2472 2008-10-01  David Hyatt  <hyatt@apple.com>
2473         
2474         https://bugs.webkit.org/show_bug.cgi?id=21282
2475         
2476         Make contentsToScreen/screenToContents cross-platform.  Only implemented by Mac/Win right now.
2477         
2478         Reviewed by Adam Roben
2479
2480         * WebCoreSupport/WebChromeClient.cpp:
2481         (WebChromeClient::windowToScreen):
2482         (WebChromeClient::screenToWindow):
2483         * WebCoreSupport/WebChromeClient.h:
2484
2485 2008-09-30   Dave Hyatt  <hyatt@apple.com>
2486
2487         https://bugs.webkit.org/show_bug.cgi?id=21269
2488   
2489         This patch makes the ScrollView::paint method cross-platform.  The paint method calls the base class
2490         Widget paint on platforms with native widgets (Mac and wx).  Otherwise it calls a virtual function,
2491         paintContents, to paint the ScrollView's contents, and then it paints each of the two scrollbars and
2492         the scrollbar corner.
2493         
2494         The scrollbar themes are now responsible for painting scrollbar corners.  At the moment ScrollbarThemeWin still
2495         paints white (which is incorrect), so a future patch will actually implement proper native scroll corner painting
2496         for Windows.
2497         
2498         paintContents is implemented by FrameView, and replaces Frame::paint.  All of the FramePrivate member
2499         variables used by Frame::paint have moved to FrameViewPrivate instead.  All callers of Frame::paint have
2500         been patched to use FrameView::paintContents instead.
2501         
2502         Reviewed by Darin Adler
2503
2504         * WebFrame.cpp:
2505         (WebFrame::paintDocumentRectToContext):
2506         (WebFrame::spoolPages):
2507
2508 2008-09-30  Dave Hyatt  <hyatt@apple.com>
2509
2510         http://bugs.webkit.org/show_bug.cgi?id=21250
2511         
2512         Rename updateContents to repaintContentRectangle and make it cross-platform by always sending
2513         repaints up through the ChromeClient.
2514
2515         Reviewed by Darin Adler
2516
2517         * WebCoreSupport/WebChromeClient.cpp:
2518         (WebChromeClient::repaint):
2519         * WebCoreSupport/WebChromeClient.h:
2520         * WebView.cpp:
2521         (WebView::repaint):
2522         * WebView.h:
2523
2524 2008-09-29  Dan Bernstein  <mitz@apple.com>
2525
2526         Reviewed by Adam Roben.
2527
2528         - WebKit/win part of fixing <rdar://problem/6247906> REGRESSION (r19500): Crash on quit beneath CloseThemeData
2529
2530         * WebKitDLL.cpp:
2531         (DllMain): Call RenderThemeWin::setWebKitIsBeingUnloaded() when WebKit
2532         is being unloaded.
2533
2534 2008-09-27  David Hyatt  <hyatt@apple.com>
2535
2536         Land the frameGeometry->frameRect changes that I forgot to land in WebKit.
2537
2538         * Interfaces/IWebScrollBarPrivate.idl:
2539         * WebCoreSupport/EmbeddedWidget.cpp:
2540         (EmbeddedWidget::setFrameRect):
2541         (EmbeddedWidget::frameRectsChanged):
2542         * WebCoreSupport/EmbeddedWidget.h:
2543         * WebScrollBar.cpp:
2544         (WebScrollBar::setRect):
2545         (WebScrollBar::frameRect):
2546         * WebScrollBar.h:
2547
2548 2008-09-27  Anders Carlsson  <andersca@apple.com>
2549
2550         Fix build.
2551
2552         * WebCoreSupport/EmbeddedWidget.cpp:
2553         (EmbeddedWidget::setFrameRect):
2554         (EmbeddedWidget::frameRectsChanged):
2555         * WebCoreSupport/EmbeddedWidget.h:
2556         * WebScrollBar.cpp:
2557         (WebScrollBar::setRect):
2558         (WebScrollBar::frameGeometry):
2559
2560 2008-09-26  David Kilzer  <ddkilzer@apple.com>
2561
2562         Speculative Windows build fix with XSLT disabled
2563
2564         Reviewed by Alexey.
2565
2566         * WebCache.cpp:
2567         (WebCache::statistics): Populate xslStyleSheet statistics with
2568         zeros if XSLT is disabled.
2569
2570 2008-09-24  Matt Lilek  <webkit@mattlilek.com>
2571
2572         Reviewed by Darin Adler.
2573
2574         Bug 20999: Inspector hover to select does not work properly on Windows
2575         https://bugs.webkit.org/show_bug.cgi?id=20999
2576         <rdar://problem/6236524>
2577
2578         * WebNodeHighlight.cpp:
2579         (WebNodeHighlight::show):
2580
2581 2008-09-24  Darin Adler  <darin@apple.com>
2582
2583         * English.lproj/Localizable.strings: Updated for recent changes.
2584
2585 2008-09-22  Alice Liu  <alice.liu@apple.com>
2586
2587         Added record-memory-win.vcproj tool to the solution
2588
2589         Reviewed by Steve Falkenburg.
2590
2591         * WebKit.vcproj/WebKit.sln:
2592
2593 2008-09-20  Darin Adler  <darin@apple.com>
2594
2595         - fix build
2596
2597         * WebCoreSupport/WebChromeClient.cpp:
2598         (WebChromeClient::paintCustomScrollbar): Tweaked constant names to make this
2599         compile, but it may not be working correctly. Hyatt should do the real fix.
2600
2601 2008-09-19  Alice Liu  <alice.liu@apple.com>
2602
2603         Fix crash when submitting form at bugreport.apple.com rdar://6234126
2604
2605         Reviewed by Mark Rowe.
2606
2607         * COMPropertyBag.h:
2608         (::GetPropertyInfo):
2609         correct mis-use of comma operator
2610
2611 2008-09-18  Mark Rowe  <mrowe@apple.com>
2612
2613         Reviewed by Dan Bernstein.
2614
2615         Add SPI to WebView to allow DRT to clear the main frame's name between tests.
2616
2617         * Interfaces/IWebViewPrivate.idl:
2618         * WebView.cpp:
2619         (WebView::clearMainFrameName):
2620         * WebView.h:
2621
2622 2008-09-16  Alp Toker  <alp@nuanti.com>
2623
2624         Suggested by Dave Hyatt.
2625
2626         Build fix and cleanup. Rename ScrollBar to Scrollbar.
2627
2628         * WebScrollBar.cpp:
2629         * WebScrollBar.h:
2630
2631 2008-09-16  David Hyatt  <hyatt@apple.com>
2632
2633         Eliminate PlatformScrollbar.
2634
2635         Reviewed by Sam Weinig
2636
2637         * WebScrollBar.cpp:
2638         (WebScrollBar::init):
2639         * WebScrollBar.h:
2640
2641 2008-09-15  Chris Fleizach  <cfleizach@apple.com>
2642
2643         Reviewed by Darin Adler, Beth Dakin
2644
2645         Support strings for AXLists
2646
2647         * WebCoreLocalizedStrings.cpp:
2648         (WebCore::AXDefinitionListTermText):
2649         (WebCore::AXDefinitionListDefinitionText):
2650
2651 2008-09-13  Dave Hyatt  <hyatt@apple.com>
2652
2653         Add ScrollbarTheme to the build.
2654         
2655         Reviewed by Sam Weinig
2656
2657         * WebScrollBar.cpp:
2658         (WebScrollBar::requestedWidth):
2659         (WebScrollBar::requestedHeight):
2660
2661 2008-09-13  Dave Hyatt  <hyatt@apple.com>
2662
2663         More scrollbar refactoring.
2664         
2665         Reviewed by Sam Weinig
2666
2667         * WebScrollBar.h:
2668
2669 2008-09-08  Adam Roben  <aroben@apple.com>
2670
2671         Respect the font smoothing preference when drawing via WebKitGraphics
2672
2673         Reviewed by Dave Hyatt.
2674
2675         * WebKitGraphics.cpp:
2676         (makeFont): Check the font smoothing preference and update the
2677         FontDescription's rendering mode based on it.
2678
2679 2008-09-08  Steve Falkenburg  <sfalken@apple.com>
2680
2681         Another Windows nightly build fix.
2682         
2683         Remove non-production versions of CLSIDs since we'll use registry free COM with
2684         an embedded manifest now in all cases to find COM classes.
2685         
2686         Reviewed by Sam Weinig.
2687
2688         * ForEachCoClass.cpp:
2689         (setUseOpenSourceWebKit): Remove COM registration code.
2690         * Interfaces/WebKit.idl: Remove non-production COM classes
2691
2692 2008-09-07  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
2693
2694         Reviewed by Maciej Stachowiak.
2695
2696         Bug 20704: Replace the KJS namespace
2697         <https://bugs.webkit.org/show_bug.cgi?id=20704>
2698
2699         Rename the KJS namespace to JSC.
2700
2701         * WebCoreStatistics.cpp:
2702         * WebJavaScriptCollector.cpp:
2703         * WebScriptCallFrame.cpp:
2704         (WebScriptCallFrame::jsValueToString):
2705         * WebScriptCallFrame.h:
2706         (WebScriptCallFrame::state):
2707         * WebView.cpp:
2708         (WebView::WebView):
2709         (WebView::stringByEvaluatingJavaScriptFromString):
2710
2711 2008-09-05  Dave Hyatt  <hyatt@apple.com>
2712
2713         Add support for runtime switchability of the Aqua look and the native look on Windows.
2714         Make RenderThemeWin compile by default even when USE(SAFARI_THEME) is set.
2715
2716         Reviewed by Adam Roben
2717
2718         * Interfaces/IWebPreferencesPrivate.idl:
2719         * WebPreferenceKeysPrivate.h:
2720         * WebPreferences.cpp:
2721         (WebPreferences::initializeDefaultSettings):
2722         (WebPreferences::shouldPaintNativeControls):
2723         (WebPreferences::setShouldPaintNativeControls):
2724         * WebPreferences.h:
2725         * WebView.cpp:
2726         (WebView::notifyPreferencesChanged):
2727
2728 2008-09-04  Adam Roben  <aroben@apple.com>
2729
2730         Make JavaScriptCoreGenerated build first instead of WTF
2731
2732         JavaScriptCoreGenerated does some setup work that we want to happen
2733         before WTF builds.
2734
2735         * WebKit.vcproj/WebKit.sln: Reversed the dependencies of WTF and
2736         JavaScriptCoreGenerated.
2737
2738 2008-08-30  Sam Weinig  <sam@webkit.org>
2739
2740         Reviewed by Dan Bernstein.
2741
2742         Add WebView SPI to defer loading callbacks.
2743
2744         * Interfaces/IWebViewPrivate.idl:
2745         * WebView.cpp:
2746         (WebView::setDefersCallbacks):
2747         (WebView::defersCallbacks):
2748         * WebView.h:
2749
2750 2008-08-28  Adele Peterson  <adele@apple.com>
2751
2752         Build fix.
2753
2754         * WebIconDatabase.cpp: (WebIconDatabase::getOrCreateDefaultIconBitmap):
2755
2756 2008-08-28  Holger Hans Peter Freyther  <zecke@selfish.org>
2757
2758         Rubber-stamped by Darin Adler.
2759
2760         https://bugs.webkit.org/show_bug.cgi?id=17261
2761
2762         Remove the urlIcon.png from the project and the resource file. Remove
2763         the usage of this icon from WebKitDLL.cpp and change WebIconDatabase
2764         to get the icon from the IconDatabase code which is using a version of
2765         the icon that is compiled into the code.
2766
2767         * WebIconDatabase.cpp:
2768         (WebIconDatabase::getOrCreateDefaultIconBitmap): Use the icon from the
2769         IconDatabase.cpp
2770         * WebKit.vcproj/WebKit.rc: Remove urlIcon.cpp
2771         * WebKit.vcproj/urlIcon.png: Removed.
2772         * WebKitDLL.cpp:
2773         (loadResourceIntoBuffer): Remove "urlIcon"
2774
2775 2008-08-27  Alice Liu  <alice.liu@apple.com>
2776
2777         Add interface for obtaining JS object counts broken down by type
2778
2779         Reviewed by Steve Falkenburg.
2780
2781         * Interfaces/IWebCoreStatistics.idl:
2782         * WebCoreStatistics.cpp:
2783         (WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
2784         * WebCoreStatistics.h:
2785
2786 2008-08-27  Ada Chan  <adachan@apple.com>
2787
2788         Fixed build.
2789
2790         * WebFrame.cpp:
2791         (WebFrame::pluginWillHandleLoadError):
2792
2793 2008-08-27  Brady Eidson  <beidson@apple.com>
2794
2795         Reviewed by Anders
2796
2797         <rdar://problem/6134133> - Crash when loading large movie as a standalone document
2798
2799         * WebFrame.cpp:
2800         (WebFrame::pluginWillHandleLoadError):
2801         * WebFrame.h:
2802
2803 2008-08-26  Alice Liu  <alice.liu@apple.com>
2804
2805         Implement COMPropertyBag::GetPropertyInfo
2806         and a variant setter for type int
2807
2808         Reviewed by Anders Carlsson.
2809
2810         * COMPropertyBag.h:
2811         (::GetPropertyInfo):
2812         * COMVariantSetter.h:
2813
2814 2008-08-25  Adam Roben  <aroben@apple.com>
2815
2816         Fix an assertion when showing the Web Inspector
2817
2818         Reviewed by Kevin McCullough.
2819
2820         * WebCoreSupport/WebInspectorClient.cpp:
2821         (WebInspectorClient::attachWindow):
2822         (WebInspectorClient::detachWindow):
2823         Recent code changes have caused these functions to get called even
2824         when the window is already attached/detached, respectively. Handle
2825         this case gracefully instead of asserting something that is no longer
2826         true.
2827
2828 2008-08-24  Beth Dakin  <bdakin@apple.com>
2829
2830         Reviewed by John Sullivan.
2831
2832         Provide the excludeFromTextSearch SPI on Windows as well.
2833
2834         * Interfaces/IWebFrame.idl:
2835         * WebFrame.cpp:
2836         (WebFrame::setExcludeFromTextSearch):
2837         * WebFrame.h:
2838
2839 2008-08-24  Jon Honeycutt  <jhoneycutt@apple.com>
2840
2841         Cannot get the focused accessible object from the root object.
2842
2843         AccessibleBase::get_AccFocus() checks whether the focused object is a
2844         child of the current object, but 
2845         http://msdn.microsoft.com/en-us/library/ms696150(VS.85).aspx states that
2846         the result is the object itself, if it has focus, or a child object of
2847         the active window, not a child of the object.
2848
2849         Reviewed by Sam Weinig.
2850
2851         * AccessibleBase.cpp:
2852         (AccessibleBase::get_accFocus): Don't check whether the focused object
2853         is our child.
2854
2855 2008-08-18  Jon Honeycutt  <jhoneycutt@apple.com>
2856
2857         Add SPI to make a Windows WebView transparent.
2858
2859         Reviewed by Dan Bernstein.
2860
2861         * Interfaces/IWebViewPrivate.idl:
2862         * WebCoreSupport/WebFrameLoaderClient.cpp:
2863         (WebFrameLoaderClient::transitionToCommittedForNewPage): Call
2864         updateBackground() when a new frame is attached, matching the Mac.
2865         * WebFrame.cpp:
2866         (WebFrame::updateBackground): Propagate WebView transparency to ourself
2867         and our child frames.
2868         * WebFrame.h:
2869         * WebView.cpp:
2870         (WebView::WebView):
2871         (WebView::paintIntoBackingStore): Pass m_transparent when creating a
2872         GraphicsContext, so the context will be created with an alpha channel.
2873         (WebView::setTransparent):
2874         (WebView::transparent):
2875         * WebView.h:
2876
2877 2008-08-12  Jon Honeycutt  <jhoneycutt@apple.com>
2878
2879         Add SPI to get a handle to the WebView's backing store bitmap.
2880
2881         Reviewed by Dan Bernstein.
2882
2883         * Interfaces/IWebViewPrivate.idl:
2884         * WebView.cpp:
2885         (WebView::backingStore):
2886         * WebView.h:
2887
2888 2008-08-21 Jonas Klink <klinktech@gmail.com>
2889
2890         Reviewed by Jon Honeycutt.
2891
2892         Fix https://bugs.webkit.org/show_bug.cgi?id=20231
2893         Bug 20231: accNavigate: no screen element found in the specified direction should return S_FALSE
2894
2895         Per <http://msdn.microsoft.com/en-us/library/ms696145(VS.85).aspx>, we should return S_FALSE
2896         from accNavigate if no screen element is found in the specified direction.
2897
2898         * AccessibleBase.cpp:
2899         (AccessibleBase::accNavigate):
2900
2901 2008-08-21 Jonas Klink <klinktech@gmail.com>
2902
2903         Reviewed by Jon Honeycutt.
2904
2905         Fix http://bugs.webkit.org/show_bug.cgi?id=20230
2906         Bug 20230: get_accState should be testing state on childObj
2907
2908         Also initializes output parameter action to 0 in get_accDefaultAction.
2909
2910         * AccessibleBase.cpp:
2911         (AccessibleBase::get_accState):
2912         (AccessibleBase::get_accDefaultAction):
2913
2914 2008-08-20  Maxime Britto  <britto@apple.com>
2915
2916         Reviewed by Ada Chan.
2917
2918         rdar://5259746
2919         Mouse events are sent to page while resizing window (affects Gmail)
2920         In the WebView, if the MouseEvent is located in the resize corner, we send it back to the UIDelegate and early return.
2921
2922         * Interfaces/IWebUIDelegatePrivate.idl: Add a new method to the UIDelegate to send the resize message
2923         * WebView.cpp:
2924         (WebView::handleMouseEvent): If the mouse event is in the resize corner and our UIDelegate supports the message it sends the new message and early returns
2925
2926 2008-08-19  Alexey Proskuryakov  <ap@webkit.org>
2927
2928         Reviewed by Geoff Garen.
2929
2930         Bring back shared JSGlobalData and implicit locking, because too many clients rely on it.
2931
2932         * WebCoreStatistics.cpp:
2933         (WebCoreStatistics::javaScriptObjectsCount):
2934         (WebCoreStatistics::javaScriptGlobalObjectsCount):
2935         (WebCoreStatistics::javaScriptProtectedObjectsCount):
2936         (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
2937         * WebJavaScriptCollector.cpp:
2938         (WebJavaScriptCollector::objectCount):
2939         * WebScriptCallFrame.cpp:
2940         (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString):
2941         * WebView.cpp:
2942         (WebView::stringByEvaluatingJavaScriptFromString):
2943
2944 2008-08-19  Steve Falkenburg  <sfalken@apple.com>
2945
2946         Fix build.
2947
2948         * WebScriptCallFrame.cpp:
2949         (WebScriptCallFrame::jsValueToString):
2950
2951 2008-08-14  Steve Falkenburg  <sfalken@apple.com>
2952
2953         Update cache capacities to match values used on Mac.
2954         
2955         Reviewed by Dan Bernstein.
2956
2957         * WebView.cpp:
2958         (WebView::setCacheModel):
2959
2960 2008-08-14  Sam Weinig  <sam@webkit.org>
2961
2962         Reviewed by Jon Honeycutt.
2963
2964         Add WebView SPI to set HTMLTokenizer yielding parameters.
2965
2966         * Interfaces/IWebViewPrivate.idl:
2967         * WebView.cpp:
2968         (WebView::setCustomHTMLTokenizerTimeDelay):
2969         (WebView::setCustomHTMLTokenizerChunkSize):
2970         * WebView.h:
2971
2972 2008-08-13  Eric Seidel  <eric@webkit.org>
2973
2974         Attempt to fix the windows build, not review.
2975
2976         * WebIconDatabase.cpp:
2977         (WebIconDatabase::getOrCreateDefaultIconBitmap):
2978
2979 2008-08-13  Ada Chan  <adachan@apple.com>
2980
2981         Implemented DOMHTMLElement::idName() and WebFrame::frameElement().
2982         Added IWebFrame::paintDocumentRectToContext() so we can paint a frame's
2983         content into a device context.  Changed WebView::paintDocumentRectToContext()
2984         to call that WebFrame method.
2985
2986         Reviewed by Adam Roben.
2987
2988         * DOMHTMLClasses.cpp:
2989         (DOMHTMLElement::idName):
2990         * Interfaces/IWebFramePrivate.idl:
2991         * WebFrame.cpp:
2992         (WebFrame::paintDocumentRectToContext):
2993         (WebFrame::frameElement):
2994         * WebFrame.h:
2995         * WebView.cpp:
2996         (WebView::paintDocumentRectToContext):
2997
2998 2008-08-12  Timothy Hatcher  <timothy@apple.com>
2999
3000         Add a stub for InspectorClient::setAttachedWindowHeight.
3001
3002         * WebCoreSupport/WebInspectorClient.cpp:
3003         (WebInspectorClient::setAttachedWindowHeight): Add a FIXME to implement this.
3004         * WebCoreSupport/WebInspectorClient.h:
3005
3006 2008-08-12  Adam Roben  <aroben@apple.com>
3007
3008         Export WTFLog in Debug builds
3009
3010         Reviewed by John Sullivan.
3011
3012         * WebKit.vcproj/WebKit_debug.def:
3013
3014 2008-08-07  Steve Falkenburg  <sfalken@apple.com>
3015
3016         Delete backing stores before 5 second WM_TIMER fires if more than 2 are already queued.
3017         
3018         WM_TIMER-based timers can be starved if enough other events are keeping
3019         our message loop busy. This change prevents many backing store deletes from stacking
3020         up in this case.
3021         
3022         Reviewed by Geoff Garen.
3023
3024         * WebView.cpp:
3025         (WebView::deleteBackingStore):
3026         (WebView::deleteBackingStoreSoon):
3027         (WebView::cancelDeleteBackingStoreSoon):
3028
3029 2008-08-05  Ada Chan  <adachan@apple.com>
3030
3031         Add a getter for CFURLRequestRef in WebMutableURLRequest.
3032
3033         Reviewed by Anders Carlsson.
3034
3035         * Interfaces/IWebMutableURLRequestPrivate.idl:
3036         * WebMutableURLRequest.cpp:
3037         (WebMutableURLRequest::cfRequest):
3038         * WebMutableURLRequest.h:
3039
3040 2008-08-05  Steve Falkenburg  <sfalken@apple.com>
3041
3042         Don't invalidate a WebView in the process of being closed when prefs change.
3043         
3044         Reviewed by Ada Chan.
3045
3046         * WebView.cpp:
3047         (WebView::notifyPreferencesChanged):
3048
3049 2008-08-04  Alice Liu  <alice.liu@apple.com>
3050
3051         Reviewed by Steve Falkenburg.
3052
3053         Fix CFDictionary leak
3054
3055         * CFDictionaryPropertyBag.cpp:
3056         (CFDictionaryPropertyBag::Write):
3057         m_dictionary is a RetainPtr and should adopt the CF type created
3058
3059 2008-08-02  Maxime Britto  <britto@apple.com>
3060
3061         Reviewed by Eric Seidel.
3062       
3063         These icons are copies from the resizers in WebCore/Ressources
3064
3065         * ChangeLog:
3066         * WebKit.vcproj/WebKit.rc:
3067         * WebKit.vcproj/panEastCursor.png: Added.
3068         * WebKit.vcproj/panNorthCursor.png: Added.
3069         * WebKit.vcproj/panNorthEastCursor.png: Added.
3070         * WebKit.vcproj/panNorthWestCursor.png: Added.
3071         * WebKit.vcproj/panSouthCursor.png: Added.
3072         * WebKit.vcproj/panSouthEastCursor.png: Added.
3073         * WebKit.vcproj/panSouthWestCursor.png: Added.
3074         * WebKit.vcproj/panWestCursor.png: Added.
3075         * WebKit.vcproj/resource.h:
3076         * WebKitDLL.cpp:
3077         (loadResourceIntoBuffer):
3078
3079 2008-08-01  Beth Dakin  <bdakin@apple.com>
3080
3081         Reviewed by Adam Roben.
3082
3083         Fix for <rdar://problem/6119382> Need to hook up WebFrame's 
3084         disconnected frame API on Windows.
3085
3086         * Interfaces/IWebFrame.idl:
3087         * WebFrame.cpp:
3088         (WebFrame::setIsDisconnected):
3089         * WebFrame.h:
3090
3091 2008-08-01  Adam Roben  <aroben@apple.com>
3092
3093         Fix <rdar://6118733> REGRESSION (r35502): Crash when submitting any
3094         form
3095
3096         Reviewed by Darin Adler.
3097
3098         * COMPropertyBag.h:
3099         (COMPropertyBag::QueryInterface): Cast to an appropriate type before
3100         assigning into ppvObject.
3101
3102 2008-07-31  Anders Carlsson  <andersca@apple.com>
3103
3104         Reviewed by Adam.
3105
3106         Get rid of FormValuesPropertyBag and use COMPropertyBag instead.
3107         
3108         * COMPropertyBag.h:
3109         Implement parts of IPropertyBag2. 
3110         Currently just one method (CountProperties) is implemented.
3111         
3112         * WebCoreSupport/FormValuesPropertyBag.cpp: Removed.
3113         * WebCoreSupport/FormValuesPropertyBag.h: Removed.
3114       
3115         * WebFrame.cpp:
3116         (WebFrame::dispatchWillSubmitForm):
3117         Create a COMPropertyBag instead.
3118         
3119         * WebKit.vcproj/WebKit.vcproj:
3120
3121 2008-07-31  Anders Carlsson  <andersca@apple.com>
3122
3123         Reviewed by Jon.
3124         
3125         Tweak the names.
3126
3127         * WebCoreSupport/WebFrameLoaderClient.cpp:
3128         (WebFrameLoaderClient::createPlugin):
3129
3130 2008-07-31  Anders Carlsson  <andersca@apple.com>
3131
3132         Reviewed by Jon.
3133
3134         <rdar://problem/5826110>
3135         
3136         Add a way for WebKit clients to embed custom content in web pages.
3137         
3138         * Interfaces/IWebEmbeddedView.idl: Added.
3139         New interface which an embedded view must implement.
3140         
3141         * Interfaces/IWebUIDelegatePrivate.idl:
3142         Add new UI delegate method for creating an embedded view.
3143         
3144         * Interfaces/WebKit.idl:
3145         Include IWebEmbeddedView.idl.
3146         
3147         * WebCoreSupport/EmbeddedWidget.cpp: Added.
3148         * WebCoreSupport/EmbeddedWidget.h: Added.
3149         Add EmbeddedWidget, a widget subclass which can hold an IWebEmbeddedView.
3150         
3151         * WebCoreSupport/WebFrameLoaderClient.cpp:
3152         (WebFrameLoaderClient::createPlugin):
3153         Check if the UI delegate wants to create an embedded view.
3154         
3155         * WebKit.vcproj/WebKit.vcproj:
3156         Add EmbeddedWidget.{cpp|h}
3157
3158 2008-07-31  Alexey Proskuryakov  <ap@webkit.org>
3159
3160         Rubber-stamped by Maciej.
3161
3162         Eliminate JSLock (it was already disabled, removing the stub implementaion and all
3163         call sites now).
3164
3165         * WebCoreStatistics.cpp:
3166         (WebCoreStatistics::javaScriptObjectsCount):
3167         (WebCoreStatistics::javaScriptGlobalObjectsCount):
3168         (WebCoreStatistics::javaScriptProtectedObjectsCount):
3169         (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
3170         * WebJavaScriptCollector.cpp:
3171         (WebJavaScriptCollector::objectCount):
3172         * WebScriptCallFrame.cpp:
3173         (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString):
3174         * WebView.cpp:
3175         (WebView::stringByEvaluatingJavaScriptFromString):
3176
3177 2008-07-31  Jon Honeycutt  <jhoneycutt@apple.com>
3178
3179         Windows build fix.
3180
3181         * WebURLResponse.cpp:
3182
3183 2008-07-30  Mark Rowe  <mrowe@apple.com>
3184
3185         Windows build fix.
3186
3187         * WebURLResponse.cpp:  Don't include a header file that we just deleted.
3188
3189 2008-07-30  Anders Carlsson  <andersca@apple.com>
3190
3191         Reviewed by Mitz.
3192
3193         Use a COMPropertyBag instead of the HTTPHeaderPropertyBag.
3194         
3195         * HTTPHeaderPropertyBag.cpp: Removed.
3196         * HTTPHeaderPropertyBag.h: Removed.
3197         * WebURLResponse.cpp:
3198         (WebURLResponse::allHeaderFields):
3199
3200 2008-07-30  Anders Carlsson  <andersca@apple.com>
3201
3202         Fix copyright years.
3203         
3204         * COMPropertyBag.h:
3205         * COMVariantSetter.h:
3206
3207 2008-07-30  Anders Carlsson  <andersca@apple.com>
3208
3209         Reviewed by Sam.
3210
3211         More property bag work.
3212         
3213         * COMPropertyBag.h:
3214         (COMPropertyBag::COMPropertyBag):        
3215         (::adopt):
3216         (::Read):
3217         * COMVariantSetter.h:
3218         (COMIUnknownVariantSetter::setVariant):
3219
3220 2008-07-30  Anders Carlsson  <andersca@apple.com>
3221
3222         Reviewed by Sam.
3223
3224         Add COMPropertyBag, a simple template class that implements the IPropertyBag interface. All
3225         property bag values must be of the same type.
3226         
3227         The COMVariantSetter helpers are now in COMVariantSetter.h
3228         
3229         * COMEnumVariant.h:
3230         * COMPropertyBag.h: Added.
3231         * COMVariantSetter.h: Added.
3232         * WebKit.vcproj/WebKit.vcproj:
3233         
3234 2008-07-30  Alice Liu  <alice.liu@apple.com>
3235
3236         Reviewed by Adam Roben.
3237
3238         Adding logging of COM class names and counts to facilitate
3239         investigating memory issues.
3240
3241         * Interfaces/IWebKitStatistics.idl:
3242         * WebKitDLL.cpp:
3243         * WebKitDLL.h:
3244         * WebKitStatistics.cpp:
3245         (WebKitStatistics::comClassNameCounts):
3246         * WebKitStatistics.h:
3247
3248 2008-07-29  Alice Liu  <alice.liu@apple.com>
3249
3250         Reviewed by Geoff Garen.
3251
3252         Fix WebDocumentLoader leak on Windows.
3253
3254         * WebCoreSupport/WebFrameLoaderClient.cpp:
3255         (WebFrameLoaderClient::createDocumentLoader):
3256         * WebDocumentLoader.cpp:
3257         (WebDocumentLoader::create):
3258         * WebDocumentLoader.h:
3259
3260 2008-07-29  Adam Roben  <aroben@apple.com>
3261
3262         Export detachThread
3263
3264         Reviewed by Geoff Garen.
3265
3266         * WebKit.vcproj/WebKit.def:
3267         * WebKit.vcproj/WebKit_debug.def:
3268
3269 2008-07-29  Adam Roben  <aroben@apple.com>
3270
3271         Export the new version of createThread
3272
3273         Reviewed by Anders Carlsson.
3274
3275         * WebKit.vcproj/WebKit.def:
3276         * WebKit.vcproj/WebKit_debug.def:
3277         Also moved the old version of createThread into the deprecated
3278         section.
3279
3280 2008-07-26  Matt Lilek  <webkit@mattlilek.com>
3281
3282         Reviewed by Geoff Garen.
3283
3284         Changes to accommodate newly named/signatured loading methods in WebCore.
3285
3286         * WebCoreSupport/WebContextMenuClient.cpp:
3287         (WebContextMenuClient::searchWithGoogle):
3288         * WebCoreSupport/WebFrameLoaderClient.cpp:
3289         (WebFrameLoaderClient::loadURLIntoChild):
3290
3291 2008-07-25  Adam Roben  <aroben@apple.com>
3292
3293         Try to fix the Windows build bot
3294
3295         * WebKit.vcproj/WebKit.sln: Linearize the project dependencies. Each
3296         project now depends only on the project that should immediately
3297         precede it in the build. For the frameworks, this order makes sense.
3298         For the applications built on top of the frameworks, the order is
3299         arbitrary (but roughly follows the applications' complexity).
3300
3301 2008-07-17  Adele Peterson  <adele@apple.com>
3302
3303         Reviewed by Adam.
3304
3305         WebKit part of fix for <rdar://problem/5698672>  Add drawing callback for a WebKit app to draw its own scrollbars
3306         
3307         Added a setting so an application can tell WebKit its going to draw custom scrollbars.  Also added delegate methods for the actual painting.
3308         
3309         * Interfaces/IWebPreferences.idl:  Added setShouldPaintCustomScrollbars and shouldPaintCustomScrollbars.
3310         * Interfaces/IWebScrollBarPrivate.idl: Moved types to WebScrollbarTypes.idl
3311         * Interfaces/IWebUIDelegate.idl: Added WebUIDelegate4 with new delegate methods, paintCustomScrollbar and paintCustomScrollCorner
3312         * Interfaces/WebKit.idl: Include new WebScrollbarTypes.idl
3313         * Interfaces/WebScrollbarTypes.idl: Added. Has types that the new delegate methods use.
3314         * WebCoreSupport/WebChromeClient.cpp:
3315         (WebChromeClient::paintCustomScrollbar): Added. Calls new delegate method and converts between WebCore types and types exported in WebScrollbarTypes.idl
3316         (WebChromeClient::paintCustomScrollCorner): Added. Calls new delegate method.
3317         (WebChromeClient::uiDelegate4): Added.
3318         * WebCoreSupport/WebChromeClient.h:
3319         * WebPreferenceKeysPrivate.h: Added WebKitPaintCustomScrollbarsPreferenceKey
3320         * WebPreferences.cpp:
3321         (WebPreferences::): Added.
3322         (WebPreferences::shouldPaintCustomScrollbars): Added.
3323         * WebPreferences.h:
3324         * WebView.cpp: (WebView::notifyPreferencesChanged):
3325
3326 2008-07-15  Adam Roben  <aroben@apple.com>
3327
3328         Add WebKit[Set]ShouldUseFontSmoothing functions
3329
3330         <rdar://6059127>
3331
3332         Reviewed by John Sullivan.
3333
3334         * WebKit.vcproj/WebKit.def:
3335         * WebKit.vcproj/WebKit_debug.def:
3336         Export the new functions.
3337         * WebKitGraphics.cpp:
3338         (WebKitSetShouldUseFontSmoothing):
3339         (WebKitShouldUseFontSmoothing):
3340         Call through to the relevant WebCore functions.
3341         * WebKitGraphics.h:
3342
3343 2008-07-14  Steve Falkenburg  <sfalken@apple.com>
3344
3345         Don't include autoversion.h in WebKitDLL.cpp.
3346         autoversion.h changes for every build, so we don't want to include it unless necessary.        
3347
3348         Rubber stamped by Ada Chan.
3349
3350         * WebKitDLL.cpp:
3351
3352 2008-07-14  Adam Roben  <aroben@apple.com>
3353
3354         Windows build fix
3355
3356         * WebJavaScriptCollector.cpp:
3357         (WebJavaScriptCollector::objectCount): Updated to match
3358         -[WebCoreStatistics javaScriptsObjectCount].
3359
3360 2008-07-14  Alexey Proskuryakov  <ap@webkit.org>
3361
3362         Reviewed by Geoff Garen.
3363
3364         Eliminate per-thread JavaScript global data instance support and make arbitrary
3365         global data/global object combinations possible.
3366
3367         * WebCoreStatistics.cpp:
3368         (WebCoreStatistics::javaScriptObjectsCount):
3369         (WebCoreStatistics::javaScriptGlobalObjectsCount):
3370         (WebCoreStatistics::javaScriptProtectedObjectsCount):
3371         (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
3372         Ask WebCore for its instance of JSGlobalData, now that it is not in per-thread storage.
3373
3374 2008-07-11  Steve Falkenburg  <sfalken@apple.com>
3375
3376         Build fix.
3377
3378         * WebKit.vcproj/WebKit.vcproj:
3379
3380 2008-07-10  Steve Falkenburg  <sfalken@apple.com>
3381
3382         Build fix.
3383
3384         * WebKit.vcproj/Interfaces.vcproj:
3385
3386 2008-07-10  Adam Roben  <aroben@apple.com>
3387
3388         Windows build fix
3389
3390         * WebKit.vcproj/resource.h: Revert some changes that VS made to this
3391         file in r35083.
3392
3393 2008-07-09  Maxime Britto  <britto@apple.com>
3394
3395         Reviewed by Adele.
3396        
3397         Added the panning icon in the ressources.
3398         Its name is compass.png to make a difference with moveCursor.png (from the WebCore ressources)
3399
3400         * ChangeLog:
3401         * WebKit.vcproj/WebKit.rc:
3402         * WebKit.vcproj/panIcon.png: Added.
3403         * WebKit.vcproj/resource.h:
3404         * WebKitDLL.cpp: Declared the new ressource with the name "panIcon"
3405         (loadResourceIntoBuffer):
3406
3407 2008-07-02  Dan Bernstein  <mitz@apple.com>
3408
3409         - try to fix the Windows build
3410
3411         * WebScriptCallFrame.cpp:
3412
3413 2008-07-01  Alexey Proskuryakov  <ap@webkit.org>
3414
3415         Reviewed by Darin Adler.
3416
3417         Disable JSLock for per-thread contexts.
3418
3419         * WebCoreStatistics.cpp:
3420         (WebCoreStatistics::javaScriptObjectsCount):
3421         (WebCoreStatistics::javaScriptGlobalObjectsCount):
3422         (WebCoreStatistics::javaScriptProtectedObjectsCount):
3423         (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
3424         * WebScriptCallFrame.cpp:
3425         (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString):
3426         * WebView.cpp:
3427         (WebView::stringByEvaluatingJavaScriptFromString):
3428         Pass a parameter (false) to JSLock to indicate that WebKit doesn't need locking.
3429         Include JSLock.h, as it is no longer brought in implicitly.
3430
3431 2008-06-27  Adam Roben  <aroben@apple.com>
3432
3433         Change WebKitGraphics truncation functions to return the length of the
3434         truncated string
3435
3436         Reviewed by Darin Adler.
3437
3438         * WebKitGraphics.cpp:
3439         (CenterTruncateStringToWidth):
3440         (RightTruncateStringToWidth):
3441         Return the length.
3442         * WebKitGraphics.h:
3443         The truncation functions now return an unsigned int that is the length
3444         of the truncated string. The whole file has been marked extern "C" to
3445         keep the symbols for these functions from changing (which would break
3446         nightly builds).
3447
3448 2008-06-19  Alexey Proskuryakov  <ap@webkit.org>
3449
3450         Windows build fix.
3451
3452         * WebJavaScriptCollector.cpp: Added a missing include.
3453
3454 2008-06-17  Alexey Proskuryakov  <ap@webkit.org>
3455
3456         Reviewed by Darin Adler.
3457
3458         Prepare JavaScript heap for being per-thread.
3459
3460         * WebCoreStatistics.cpp:
3461         (WebCoreStatistics::javaScriptObjectsCount):
3462         (WebCoreStatistics::javaScriptGlobalObjectsCount):
3463         (WebCoreStatistics::javaScriptProtectedObjectsCount):
3464         (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
3465         * WebJavaScriptCollector.cpp:
3466         (WebJavaScriptCollector::objectCount):
3467         Use JSGlobalData::threadInstance()->heap instead of static Collector calls.
3468
3469         * WebScriptCallFrame.cpp:
3470         (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString): Pass ExecState* where
3471         now required.
3472
3473 2008-06-16  Alexey Proskuryakov  <ap@webkit.org>
3474
3475         Trying to fix Windows build.
3476
3477         * WebScriptCallFrame.cpp:
3478         (WebScriptCallFrame::variableNames):
3479         (WebScriptCallFrame::valueForVariable):
3480         Give ExecState to functions that now take it.
3481
3482 2008-06-16  Adam Roben  <aroben@apple.com>
3483
3484         Windows build fix
3485
3486         * WebScriptCallFrame.cpp: Fixed a header name.
3487
3488 2008-06-15  Darin Adler  <darin@apple.com>
3489
3490         - give Frame object functions shorter names: scriptProxy() -> script(),
3491           selectionController() -> selection(), animationController() -> animation()
3492
3493         * WebFrame.cpp:
3494         (WebFrame::globalContext):
3495         (WebFrame::windowObjectCleared):
3496         * WebView.cpp:
3497         (WebView::handleContextMenuEvent):
3498         (WebViewWndProc):
3499         (WebView::updateFocusedAndActiveState):
3500         (WebView::hasSelectedRange):
3501         (WebView::replaceSelectionWithText):
3502         (WebView::clearSelection):
3503         (WebView::prepareCandidateWindow):
3504         (WebView::onIMERequestCharPosition):
3505         (WebView::onIMERequestReconvertString):
3506
3507 2008-06-15  Darin Adler  <darin@apple.com>
3508
3509         - rename KJS::List to KJS::ArgList
3510
3511         * WebScriptCallFrame.cpp:
3512         (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
3513
3514 2008-06-15  Darin Adler  <darin@apple.com>
3515
3516         - new names for a few key JavaScriptCore files
3517
3518         * WebView.cpp:
3519
3520 2008-06-15  Darin Adler  <darin@apple.com>
3521
3522         Rubber stamped by Sam.
3523
3524         - use JS prefix and simpler names for basic JavaScriptCore types,
3525           to complement JSValue and JSObject
3526
3527         * WebScriptCallFrame.cpp:
3528         (WebScriptCallFrame::functionName):
3529
3530 2008-06-15  Maciej Stachowiak  <mjs@apple.com>
3531
3532         Rubber stamped by Oliver.
3533         
3534         - fix WebKit solution for testkjs --> jsc rename
3535
3536         * WebKit.vcproj/WebKit.sln:
3537
3538 2008-06-14  Darin Adler  <darin@apple.com>
3539
3540         Rubber stamped by Sam.
3541
3542         - new names for kjs_binding.h and kjs_proxy.h
3543
3544         * WebFrame.cpp:
3545
3546 2008-06-14  Darin Adler  <darin@apple.com>
3547
3548         Rubber stamped by Sam.
3549
3550         - renamed HTMLGenericFormElement to HTMLFormControlElement
3551
3552         * WebFrame.cpp:
3553         (WebFrame::elementWithName):
3554         (WebFrame::controlsInForm):
3555
3556 2008-06-14  Darin Adler  <darin@apple.com>
3557
3558         - try to fix Windows build, again
3559
3560         * WebFrame.cpp:
3561         (WebFrame::dispatchDecidePolicyForNewWindowAction): Fix arguments. Pass form.
3562         (WebFrame::dispatchDecidePolicyForNavigationAction): Ditto.
3563         * WebFrame.h: Fix arguments.
3564
3565 2008-06-14  Darin Adler  <darin@apple.com>
3566
3567         - try to fix Windows build
3568
3569         * WebActionPropertyBag.cpp:
3570         (WebActionPropertyBag::Read): Use IDOMNode, not IHTMLFormElement.
3571         * WebFrame.h: Added missing FormState arguments.
3572         * WebScrollBar.cpp:
3573         (WebScrollBar::init): Use create instead of new.
3574
3575 2008-06-14  Darin Adler  <darin@apple.com>
3576
3577         Reviewed by Sam.
3578
3579         - more of https://bugs.webkit.org/show_bug.cgi?id=17257
3580           start ref counts at 1 instead of 0 for speed
3581
3582         * WebCoreSupport/WebFrameLoaderClient.cpp:
3583         (WebFrameLoaderClient::createFrame): Remove now-obsolete adoptRef that was balanced by
3584         a ref call inside the Frame constructor. The lifetime rules for Frame are now the
3585         conventional ones without a special case.
3586
3587         * WebFrame.cpp:
3588         (WebFrame::init): Renamed function from initWithWebFrameView and removed the unused
3589         IWebFrameView argument (every caller was passing 0). Also changed this to return the
3590         WebCore Frame object, which is needed to straighten out the lifetime and ownership
3591         issues.
3592         * WebFrame.h: Ditto.
3593
3594         * WebView.cpp:
3595         (WebView::initWithFrame): Changed to call new init function and use the return value.
3596
3597 2008-06-13  Darin Adler  <darin@apple.com>
3598
3599         Reviewed by John Sullivan.
3600
3601         - updated for addition of FormState argument to action policy functions
3602         - added WebActionFormKey
3603
3604         * Interfaces/IWebPolicyDelegate.idl:
3605         * WebActionPropertyBag.cpp:
3606         (WebActionPropertyBag::WebActionPropertyBag):
3607         (WebActionPropertyBag::createInstance):
3608         (WebActionPropertyBag::AddRef):
3609         (WebActionPropertyBag::Release):
3610         (WebActionPropertyBag::Read):
3611         * WebActionPropertyBag.h:
3612         * WebFrame.cpp:
3613         (WebFrame::dispatchDecidePolicyForNewWindowAction):
3614         (WebFrame::dispatchDecidePolicyForNavigationAction):
3615
3616 2008-06-07  Darin Adler  <darin@apple.com>
3617
3618         Reviewed by Mitz.
3619
3620         - work on https://bugs.webkit.org/show_bug.cgi?id=17257
3621           start ref counts at 1 instead of 0 for speed
3622
3623         * WebHistoryItem.cpp:
3624         (WebHistoryItem::createInstance):
3625         (WebHistoryItem::initFromDictionaryRepresentation):
3626         (WebHistoryItem::initWithURLString):
3627
3628 2008-05-30  Steve Falkenburg  <sfalken@apple.com>
3629
3630         Registry-free COM.        
3631         
3632         WebKit no longer requires COM registration.
3633         Registry-free COM information is read from the application manifest.
3634
3635         Only 1 set of CLSIDs are now used, since we don't need to worry about registry collisions.
3636         The second set remains, but only temporarily so nightlies continue to work.
3637
3638         This is supported for XPSP2 and later.  Earlier systems require an installer
3639         to write the required registry keys.  Nightlies and developer builds require
3640         XPSP2, Server 2003, or later.
3641
3642         Reviewed by Adam.
3643
3644         * ForEachCoClass.cpp: Moved COM registration code here from WebKitDLL.cpp. This is ONLY used in the nightly case.
3645         (substituteGUID): Moved here from WebKitDLL.cpp.
3646         (registerWebKit): Moved here from WebKitDLL.cpp.
3647         (setUseOpenSourceWebKit): Call registerWebKit instead of swapping progids. There is only 1 set of progids now - for the nightly.
3648         * ForEachCoClass.h: Removed production progids. 
3649         * Interfaces/WebKit.idl: Added prototype for shutDownWebKit.
3650         * WebKit.vcproj/Interfaces.vcproj: Changed path to type library to move it out of project directory.
3651         * WebKit.vcproj/WebKit.vcproj: Changed path to type library to move it out of project directory.
3652         * WebKitDLL.cpp:
3653         (DllUnregisterServer): Does nothing. Entry point is still present for backward compatibility.
3654         (DllRegisterServer): Does nothing. Entry point is still present for backward compatibility.
3655         (RunAsLocalServer): Does nothing. Entry point is still present for backward compatibility.
3656         (shutDownWebKit): Moved from ForEachCoClass.
3657         * WebKitDLL.h:
3658
3659 2008-05-29  Anders Carlsson  <andersca@apple.com>
3660
3661         Reviewed by Brady.
3662
3663         <rdar://problem/5970312> 
3664         icon file specified for stand alone web app causes crash if the icon can't be found
3665         
3666         Handle the case where iconData is null.
3667
3668         * WebIconFetcher.cpp:
3669         (WebIconFetcherClient::finishedFetchingIcon):
3670
3671 2008-05-22  Anders Carlsson  <andersca@apple.com>
3672
3673         Reviewed by Adam.
3674
3675         Add IWebIconFetcher interface and implementation.
3676         
3677         * Interfaces/IWebFramePrivate.idl:
3678         * Interfaces/IWebIconFetcher.idl: Added.
3679         * Interfaces/WebKit.idl:
3680         * WebFrame.cpp:
3681         * WebFrame.h:
3682         * WebIconFetcher.cpp: Added.
3683         * WebIconFetcher.h: Added.
3684         * WebKit.vcproj/WebKit.vcproj:
3685
3686 2008-05-22  Adam Roben  <aroben@apple.com>
3687
3688         Add functions to IWebInspector to start/stop profiling/debugging
3689
3690         <rdar://5956403>