487bf2da6d8888ae31f17c9ce03112d23dee7957
[WebKit-https.git] / WebKit / win / ChangeLog
1 2007-07-27  Ada Chan  <adachan@apple.com>
2
3         Reviewed by Adam.
4         
5         Added methods to track user edited text fields now that 
6         <rdar://problem/5359921> has been fixed.
7
8         * DOMHTMLClasses.cpp:
9         (DOMHTMLInputElement::QueryInterface):
10         (DOMHTMLInputElement::isUserEdited):
11         (DOMHTMLTextAreaElement::QueryInterface):
12         (DOMHTMLTextAreaElement::isUserEdited):
13         * DOMHTMLClasses.h:
14         * Interfaces/DOMPrivate.idl:
15
16 2007-07-27  Adam Roben  <aroben@apple.com>
17
18         Fix Bug 14773: REGRESSION (r24630): ASSERT_NOT_REACHED in DOMHTMLInputElement::name on Windows
19         http://bugs.webkit.org/show_bug.cgi?id=14773
20
21         Reviewed by Steve.
22
23         * Interfaces/DOMHTML.idl: Change IDOMHTMLInputElement back to
24         inheriting from IDOMElement. Safari 3 Beta uses this interface, so we
25         can't change its vtable.
26
27 2007-07-25  Ada Chan  <adachan@apple.com>
28
29         Reviewed by Adam and Steve.
30         
31         Implemented some DOM methods and other fixes for <rdar://problem/5311601>.
32         
33         * DOMCoreClasses.cpp:
34         (DOMNode::ownerDocument): implemented
35         (DOMDocument::getComputedStyle): get the DOMElement via QueryInterface
36         (DOMElement::QueryInterface):
37         * DOMHTMLClasses.cpp:
38         (DOMHTMLDocument::body): fixed leak
39         (DOMHTMLFormElement::action): implemented
40         (DOMHTMLFormElement::method): ditto
41         (DOMHTMLInputElement::form): ditto
42         (DOMHTMLTextAreaElement::form): ditto
43         * Interfaces/DOMHTML.idl: IDOMHTMLInputElement should inherit from IDOMHTMLElement
44
45 2007-07-24  Steve Falkenburg  <sfalken@apple.com>
46
47         Removed touch of WebKit.rc to prevent rebuilds of the rc file.
48         The autoversion info can get slightly out of date now, but this isn't a huge problem relative to the rebuilds.
49         
50         Rubber-stamped by Adam.
51
52         * WebKit.vcproj/WebKit.vcproj:
53
54 2007-07-23  Steve Falkenburg  <sfalken@apple.com>
55
56         Fixes to versioning script.
57         
58         Reviewed by Ada.
59
60         * WebKit.vcproj/auto-version.sh:
61
62 2007-07-23  Adam Roben  <aroben@apple.com>
63
64         Implement IWebHistoryItem::[set]AlternateTitle
65
66         The argument types were reversed for these two methods, so I fixed that as
67         well.
68
69         Reviewed by Geoff and Oliver.
70
71         * Interfaces/IWebHistoryItem.idl:
72         * WebHistoryItem.cpp:
73         (WebHistoryItem::setAlternateTitle): Implemented.
74         (WebHistoryItem::alternateTitle): Implemented.
75         * WebHistoryItem.h:
76
77 2007-07-23  Ada Chan  <adachan@apple.com>
78
79         Reviewed by Steve.
80         
81         Added a new text drawing method that allows caller to override the font smoothing level.
82
83         * WebKit.vcproj/WebKit.def:
84         * WebKit.vcproj/WebKit_debug.def:
85         * WebKitGraphics.cpp:
86         (WebDrawText):
87         * WebKitGraphics.h:
88
89 2007-07-22  Adam Roben  <aroben@apple.com>
90
91         Implement IDOMElement::setAttribute
92
93         This method was mistakenly called "setResult" in DOMCore.idl, so I
94         fixed that as well.
95
96         Needed for <rdar://problem/5314906>.
97
98         Reviewed by Ada.
99
100         * DOMCoreClasses.cpp:
101         (DOMElement::setAttribute): Implemented/renamed.
102         * DOMCoreClasses.h: Renamed setResult => setAttribute.
103         * DOMHTMLClasses.h: Ditto.
104         * Interfaces/DOMCore.idl: Ditto.
105
106 2007-07-21  Ada Chan  <adachan@apple.com>
107
108         Reviewed by Adam.
109         
110         Fix bug 14706: http://bugs.webkit.org/show_bug.cgi?id=14706
111         Need to set the last visited time before calling WebHistory::addItem().
112
113         * WebHistory.cpp:
114         (WebHistory::addItemForURL):
115
116 2007-07-20  Justin Garcia  <justin.garcia@apple.com>
117
118         Reviewed by Darin.
119         
120         <rdar://problem/5109817> Ctrl-click on word in non-editable text doesn't select it
121
122         * WebEditorClient.cpp: Removed the now unused selectWordBeforeMenuEvent().
123         * WebEditorClient.h:
124
125 2007-07-20  Ada Chan  <adachan@apple.com>
126
127         Reviewed by Steve.
128         
129         <rdar://problem/5350832> History item's visitedCount wasn't updated correctly
130
131         The call to setLastVisitedTimeInterval() in WebHistory::addItemForURL() does not
132         really increment the visitedCount of the HistoryItem - because we only increment the count
133         if the last visited time is different.  We should initialize the HistoryItem with
134         lastVisited time = 0 so when we call setLastVisitedTimeInterval() later, it'll update
135         the last visited time AND the visitedCount.
136         
137         * WebHistory.cpp:
138         (WebHistory::addItemForURL):
139
140 2007-07-20  Oliver Hunt  <oliver@apple.com>
141
142         Reviewed by Maciej.
143
144         <rdar://problem/5349668> WebKit/Win needs to send same key events during IME composition as it does on mac
145
146         Removed guards against sending key events during composition, and added a flag
147         to indicate a key event is IME related.  This is needed to prevent the first 
148         keydown from firing a keypress event, and makes WebEditorClient::handleInputMethodKeypress
149         somewhat cleaner.
150
151         * WebEditorClient.cpp:
152         (WebEditorClient::handleInputMethodKeypress):
153         * WebView.cpp:
154         (WebView::keyUp):
155         (WebView::keyDown):
156         * WebView.h:
157         (WebView::inIMEKeyDown):
158
159 2007-07-19  Maciej Stachowiak  <mjs@apple.com>
160
161         Reviewed by Adam.
162         
163         - WebKit part of fix for <rdar://problem/5262230> Crash while loading a popup in addictinggames.com
164         
165         Made closeWindowSoon fire on a timer instead of happening synchronously.
166
167         * WebChromeClient.cpp:
168         (WebChromeClient::closeWindowSoon): Actually close the window on a timer, not immediately.
169         * WebKit.vcproj/WebKit.vcproj:
170         * WebView.cpp:
171         (WebView::WebView):
172         (WebView::closeWindowSoon):
173         (WebView::closeWindowTimerFired):
174         * WebView.h:
175
176 2007-07-18  Timothy Hatcher  <timothy@apple.com>
177
178         Reviewed by Adam.
179
180         Make the Page with the now required InspectorClient.
181
182         * WebView.cpp:
183         (WebView::initWithFrame):
184
185 2007-07-18  Sam Weinig  <sam@webkit.org>
186
187         Build fix.
188
189         * WebFrame.cpp:
190         (WebFrame::dispatchDecidePolicyForMIMEType):
191         (WebFrame::objectContentType):
192         * WebView.cpp:
193         (WebView::canShowMIMEType):
194
195 2007-07-17  Brady Eidson <beidson@apple.com>
196
197         Blind Windows build fix from r24395
198
199         * WebView.cpp:
200         (WebView::initWithFrame): BSTR, not BString
201
202 2007-07-17  Brady Eidson  <beidson@apple.com>
203
204         Reviewed by Steve
205         
206         <rdar://problem/4516185> - FTP Directory Listings
207
208         * Interfaces/IWebUIDelegate.idl: Add IWebUIDelegate2 method for getting the path to the template
209         
210         * WebView.cpp:
211           (WebView::initWithFrame): Set the preference for the template path in WebCore when the first
212           WebView is initialized
213
214 2007-07-17  Ada Chan  <adachan@apple.com>
215
216         Rubbet-stamped by Adam.
217         
218         Fixed build.
219
220         * Interfaces/IWebFramePrivate.idl:
221         * WebContextMenuClient.cpp:
222         (fixMenuReceivedFromOldSafari):
223         * WebFrame.cpp:
224         (WebFrame::loadURLIntoChild):
225         (WebFrame::download):
226         * WebFrame.h:
227
228 2007-07-17  Adam Roben  <aroben@apple.com>
229
230         Fix Bug 14324: Cannot remove/customize the "Inspect Element" contextual menu item
231         http://bugs.webkit.org/show_bug.cgi?id=14324
232
233         If we detect that we're running against the Safari 3 Beta, we add back
234         the Inspect Element menu item after passing it off to the delegate
235         because Safari's UI delegate will remove it.
236
237         Reviewed by Tim.
238
239         * WebContextMenuClient.cpp:
240         (isPreInspectElementTagSafari): Added.
241         (fixMenuReceivedFromOldSafari): Added.
242         (WebContextMenuClient::getCustomMenuFromDefaultItems): Call
243         fixMenuReceivedFromOldSafari before returning the new menu.
244
245 2007-07-17  Adam Roben  <aroben@apple.com>
246
247         Remove WebContextMenuClient::shouldIncludeInspectElementItem
248
249         Reviewed by Tim.
250
251         * WebContextMenuClient.cpp:
252         * WebContextMenuClient.h:
253
254 2007-07-17  Adam Roben  <aroben@apple.com>
255
256         Initialize Settings::developerExtrasEnabled
257
258         Reviewed by Tim.
259
260         * WebView.cpp:
261         (WebView::updateWebCoreSettingsFromPreferences):
262
263 2007-07-17  Geoffrey Garen  <ggaren@apple.com>
264
265         Build fix. 
266
267         * WebContextMenuClient.cpp:
268         (WebContextMenuClient::searchWithGoogle): Pass false for lockHistory 
269         like we do elsewhere.
270
271 2007-07-17  Oliver Hunt  <oliver@apple.com>
272
273         Reviewed by Adam.
274
275         Fix for <rdar://problem/5339416> Candidate window does not
276                 appear in the correct location for japanese IME
277
278         * WebView.cpp:
279         (WebView::prepareCandidateWindow):
280           We now use an exclusion zone so that the composition window never 
281           overlaps the composition string
282         (WebView::onIMERequestCharPosition):
283           Correctly handle character offsets marked regions
284
285 2007-07-16  Oliver Hunt  <oliver@apple.com>
286
287         Reviewed by Maciej.
288
289         Fix for <rdar://problem/5334818> Support IME reconversion in windows
290
291         Also includes a small amount of IME refactoring.
292
293         * WebView.cpp:
294         (WebView::onIMERequestCharPosition):
295         (WebView::onIMERequestReconvertString):
296         (WebView::onIMERequest):
297         * WebView.h:
298
299 2007-07-16  Brady Eidson  <beidson@apple.com>
300
301         Reviewed by Adam
302
303         Begin the arduous task of localizing FTP directory listings while removing a global initializer!
304
305         * English.lproj/Localizable.strings:
306         * WebCoreLocalizedStrings.cpp:
307         (WebCore::unknownFileSizeText):
308
309 2007-07-16  Oliver Hunt  <oliver@apple.com>
310
311         Reviewed by Maciej.
312
313         Fix for <rdar://problem/5334826> Chinese IME composition window does not appear in the correct location
314
315         Respect IME requests for character position.
316
317         * WebView.cpp:
318         (WebView::onIMERequestCharPosition):
319         (WebView::onIMERequest):
320         * WebView.h:
321
322 2007-07-16  Adam Roben  <aroben@apple.com>
323
324         WebKit/win part of <rdar://problem/5336005> Calling window.print() on a subframe prints whole page, should only print that subframe
325
326         Reviewed by Darin.
327
328         * Interfaces/IWebUIDelegate.idl: Rename print to printFrame to closer
329         match the Mac method, and copy more of the Mac API comments.
330         * WebChromeClient.cpp:
331         (WebChromeClient::print): Call printFrame instead of print.
332
333 2007-07-16  Adam Roben  <aroben@apple.com>
334
335         Updated WebChromeClient for ChromeClient changes.
336
337         Reviewed by Darin.
338
339         * WebChromeClient.cpp:
340         (WebChromeClient::print): Added a Frame* parameter.
341         * WebChromeClient.h: Ditto.
342
343 2007-07-16  Oliver Hunt  <oliver@apple.com>
344
345         Reviewed by Steve.
346
347         Fix for http://bugs.webkit.org/show_bug.cgi?id=14630
348
349         Remove bogus assertion
350
351         * WebView.cpp:
352         (WebView::getIMMContext):
353
354 2007-07-14  Brady Eidson  <beidson@apple.com>
355
356         Reviewed by Sam
357         
358         Set the pref to override the policy delegate for FTP directory listings on Windows
359
360         * WebView.cpp:
361         (WebView::updateWebCoreSettingsFromPreferences):
362
363 2007-07-13  Oliver Hunt  <oliver@apple.com>
364
365         Reviewed by Darin and Alexey.
366
367         Fix for <rdar://problem/5231528> Inline input of International text (IME)
368                 http://bugs.webkit.org/show_bug.cgi?id=14331
369
370         This patch adds IME support to WebKit/win, it currently does not support
371         reconversion (<rdar://problem/5334818>) and has issues with the chinese
372         IMEs (<rdar://problem/5334826>)
373
374         * WebEditorClient.cpp:
375         (WebEditorClient::respondToChangedSelection):
376         (WebEditorClient::handleInputMethodKeypress):
377           Prevent the initial keydown for an IME from triggering a keypressed event
378         * WebView.cpp:
379         (WebView::WebView):
380         (WebView::keyUp):
381         (WebView::keyDown):
382         (WebViewWndProc):
383         (IMMDict::dict):
384         (IMMDict::IMMDict):
385            Dynamic loader for IME libraries
386
387         (WebView::getIMMContext):
388         (WebView::releaseIMMContext):
389         (WebView::prepareCandidateWindow):
390         (selectionInsideMarkedText):
391         (setSelectionToEndOfRange):
392         (WebView::resetIME):
393         (WebView::updateSelectionForIME):
394         (WebView::selectionChanged):
395         (getCompositionString):
396         (compositionToUnderlines):
397            Helper functions
398
399         (WebView::onIMEStartComposition):
400         (WebView::onIMEComposition):
401         (WebView::onIMEEndComposition):
402         (WebView::onIMEChar):
403         (WebView::onIMENotify):
404         (WebView::onIMERequest):
405         (WebView::onIMESelect):
406         (WebView::onIMESetContext):
407            IME event handling, so far most of these are not implemented, but the bulk of functionality 
408            is performed the the composition event handlers
409         * WebView.h:
410
411 2007-07-12  Alice Liu  <alice.liu@apple.com>
412
413         Reviewed by Maciej and Steve.
414
415         fixed <rdar://4982432> window.print() needs to be implemented
416
417         * Interfaces/IWebUIDelegate.idl:
418         * WebChromeClient.cpp:
419         (WebChromeClient::print):
420         * WebChromeClient.h:
421
422 2007-07-11  Steve Falkenburg  <sfalken@apple.com>
423
424         Static analysis build fix.
425         
426         Only specify /analyze (PREfast) if it is available.
427         Prevents entire project from rebuilding each time.        
428
429         Reviewed by Hyatt.
430
431         * WebKit.vcproj/WebKit.vcproj:
432
433 2007-07-10  Ada Chan  <adachan@apple.com>
434         
435         Fixed build.
436
437         * WebView.cpp:
438
439 2007-07-09  Alice Liu  <alice.liu@apple.com>
440
441         Reviewed by Adam Roben.
442         
443         Adding DOM Paste Allowed preference, setters and getters
444         for the purpose of layout tests.
445
446         * Interfaces/IWebPreferences.idl:
447         * WebPreferenceKeysPrivate.h:
448         * WebPreferences.cpp:
449         (WebPreferences::isDOMPasteAllowed):
450         (WebPreferences::setDOMPasteAllowed):
451         * WebPreferences.h:
452         * WebView.cpp:
453         (WebView::updateWebCoreSettingsFromPreferences):
454
455 2007-07-09  Anders Carlsson  <andersca@apple.com>
456
457         Build fix.
458
459         * WebView.cpp:
460         (WebView::stringByEvaluatingJavaScriptFromString):
461
462 2007-07-05  Adam Roben  <aroben@apple.com>
463
464         Fix a leak in WebView::setToolTip
465
466         Reviewed by Beth.
467
468         * WebView.cpp:
469         (WebView::setToolTip):
470
471 2007-07-05  Adam Roben  <aroben@apple.com>
472
473         Fix Bug 14143: Tooltips not displayed on Windows
474         http://bugs.webkit.org/show_bug.cgi?id=14143
475         <rdar://problem/4719799>
476
477         Reviewed by Oliver.
478
479         * WebChromeClient.cpp:
480         (WebChromeClient::setToolTip): Call up to WebView.
481         * WebView.cpp:
482         (WebView::WebView): Initialize m_toolTipHwnd member.
483         (WebView::initWithFrame): Set up the tool tip window.
484         (initCommonControls): Added.
485         (WebView::initializeToolTipWindow): Added.
486         (WebView::setToolTip): Set the tool tip text and enable/disable the
487         tool tip.
488         * WebView.h: Added/updated declarations.
489
490 2007-07-04  Adam Roben  <aroben@apple.com>
491
492         Added a stub for WebChromeClient::setToolTip
493
494         Reviewed by Sam.
495
496         * WebChromeClient.cpp:
497         * WebChromeClient.h:
498
499 2007-07-04  Adam Roben  <aroben@apple.com>
500
501         Initialize Settings::showsURLsInToolTips
502
503         Reviewed by Sam.
504
505         * WebView.cpp:
506         (WebView::updateWebCoreSettingsFromPreferences):
507
508 2007-07-04  Adam Roben  <aroben@apple.com>
509
510         Removed call to mouseDidMoveOverElement now that WebCore handles it
511
512         Reviewed by Sam.
513
514         * WebView.cpp:
515         (WebView::handleMouseEvent):
516
517 2007-07-04  Adam Roben  <aroben@apple.com>
518
519         Add WebChromeClient::mouseDidMoveOverElement
520
521         This is not called yet.
522
523         Reviewed by Sam.
524
525         * WebChromeClient.cpp:
526         (WebChromeClient::mouseDidMoveOverElement):
527         * WebChromeClient.h:
528
529 2007-07-03  Adam Roben  <aroben@apple.com>
530
531         Merge the Windows and Mac localized strings and exceptions files
532
533         Reviewed by Darin and Anders.
534
535         * English.lproj/Localizable.strings: Added Mac strings.
536         * English.lproj/StringsNotToBeLocalized.txt: Removed.
537
538 2007-06-27  Steve Falkenburg  <sfalken@apple.com>
539
540         Turn on static code analysis.
541
542         Reviewed by Oliver.
543         
544         Affects only folks that have Visual Studio Team Suite installed,
545         or who have replaced their compiler with the version shipping in the
546         Vista SDK.
547
548         * CodeAnalysisConfig.h: Added.
549         * WebKit.vcproj/WebKit.vcproj:
550         * WebLocalizableStrings.cpp:
551         (createWebKitBundle):
552
553 2007-06-27  Steve Falkenburg  <sfalken@apple.com>
554
555         Prefast: Remove variable redefinitions in inner scopes.
556         
557         Reviewed by Ada.
558
559         * WebDownload.cpp:
560         (WebDownload::didFinish):
561         * WebNotificationCenter.cpp:
562         (WebNotificationCenter::postNotificationInternal):
563         (WebNotificationCenter::removeObserver):
564
565 2007-06-27  Steve Falkenburg  <sfaken@apple.com>
566
567         Remove SEH block from around history plist read, since the underlying bug has been fixed.
568         
569         Reviewed by Darin.
570
571         * WebHistory.cpp:
572         (createHistoryListFromStream):
573
574 2007-06-27  Steve Falkenburg  <sfalken@apple.com>
575
576         Prefast: Fix misplaced parenthesis.
577         
578         Reviewed by Darin.
579
580         * WebView.cpp:
581         (core):
582
583 2007-06-27  Steve Falkenburg  <sfalken@apple.com>
584
585         Prefast: Add null check prior to writing into allocated BSTR.
586         
587         Reviewed by Darin.
588
589         * MarshallingHelpers.cpp:
590         (MarshallingHelpers::CFStringRefToBSTR):
591
592 2007-06-27  Steve Falkenburg  <sfalken@apple.com>
593
594         Prefast: Add error handling for SysAllocStringLen where the string length is determined by website content.
595
596         Reviewed by Sam, Darin.
597                 
598         Allocation failure will result in a null dereference in this case,
599         so it isn't exploitable.
600
601         * DefaultDownloadDelegate.cpp:
602         (DefaultDownloadDelegate::decideDestinationWithSuggestedFilename):
603
604 2007-06-20  Adam Roben  <aroben@apple.com>
605
606         Land the new Inspector.
607
608         Co-written with Tim Hatcher.
609
610         Reviewed by Anders, Adele, Hyatt, and Sam.
611
612         Implement the InspectorClient interface.
613
614         * WebInspectorClient.cpp: Added.
615         (WebInspectorClient::WebInspectorClient):
616         (WebInspectorClient::~WebInspectorClient):
617         (WebInspectorClient::inspectorDestroyed):
618         (WebInspectorClient::createPage):
619         (WebInspectorClient::showWindow):
620         (WebInspectorClient::closeWindow):
621         (WebInspectorClient::windowVisible):
622         (WebInspectorClient::attachWindow):
623         (WebInspectorClient::detachWindow):
624         (WebInspectorClient::highlight):
625         (WebInspectorClient::hideHighlight):
626         (WebInspectorClient::inspectedURLChanged):
627         (WebInspectorClient::updateWindowTitle):
628         (WebInspectorClient::onSize):
629         (WebInspectorClient::onClose):
630         (WebInspectorClient::onWebViewWindowPosChanging):
631         (WebInspectorWndProc):
632         (SubclassedWebViewWndProc):
633         (registerWindowClass):
634         * WebInspectorClient.h: Added.
635
636         Add an easier-to-see highlight.
637
638         * WebNodeHighlight.cpp: Added.
639         (WebNodeHighlight::WebNodeHighlight):
640         (WebNodeHighlight::~WebNodeHighlight):
641         (WebNodeHighlight::highlight):
642         (WebNodeHighlight::hide):
643         (WebNodeHighlight::visible):
644         (WebNodeHighlight::updateWindow):
645         (WebNodeHighlight::removeSubclass):
646         (registerOverlayClass):
647         (OverlayWndProc):
648         (SubclassedWndProc):
649         * WebNodeHighlight.h: Added.
650
651         WebView changes needed for the new Inspector.
652
653         * WebView.cpp: Removed old inspectElement method now that this is
654         handled by WebCore.
655         (WebView::WebView):
656         (WebView::close):
657         (WebView::performContextMenuAction): Removed handling of the Inspect
658         Element context menu item.
659         (WebView::initWithFrame): Give each Page an InspectorClient to enable
660         the Inspector.
661         (WebView::setProhibitsMainFrameScrolling): Added.
662         * WebView.h:
663
664         Updates needed for WebCore changes.
665
666         * Interfaces/IWebUIDelegate.idl:
667         * WebContextMenuClient.cpp:
668         (WebContextMenuClient::getCustomMenuFromDefaultItems):
669         * WebContextMenuClient.h:
670         * WebCoreLocalizedStrings.cpp:
671
672         Remove old Inspector code.
673
674         * WebFrame.cpp:
675         * WebFrame.h:
676         * WebInspector/WebInspector.cpp: Removed.
677         * WebInspector/WebInspector.h: Removed.
678         * WebInspector/webInspector/Images/button.png: Removed.
679         * WebInspector/webInspector/Images/buttonDivider.png: Removed.
680         * WebInspector/webInspector/Images/buttonPressed.png: Removed.
681         * WebInspector/webInspector/Images/close.png: Removed.
682         * WebInspector/webInspector/Images/closePressed.png: Removed.
683         * WebInspector/webInspector/Images/downTriangle.png: Removed.
684         * WebInspector/webInspector/Images/menu.png: Removed.
685         * WebInspector/webInspector/Images/menuPressed.png: Removed.
686         * WebInspector/webInspector/Images/popup.png: Removed.
687         * WebInspector/webInspector/Images/popupPressed.png: Removed.
688         * WebInspector/webInspector/Images/resize.png: Removed.
689         * WebInspector/webInspector/Images/rightTriangle.png: Removed.
690         * WebInspector/webInspector/Images/scrollThumbBottom.png: Removed.
691         * WebInspector/webInspector/Images/scrollThumbMiddle.png: Removed.
692         * WebInspector/webInspector/Images/scrollTrackMiddle.png: Removed.
693         * WebInspector/webInspector/Images/upTriangle.png: Removed.
694         * WebInspector/webInspector/inspector.css: Removed.
695         * WebInspector/webInspector/inspector.html: Removed.
696         * WebInspector/webInspector/inspector.js: Removed.
697         * WebInspector/webInspector/scrollarea.js: Removed.
698         * WebInspector/webInspector/scrollbar.js: Removed.
699         * WebInspector/webInspector/treeoutline.js: Removed.
700         * WebInspector/webInspector/utilities.js: Removed.
701
702         Build-fu:
703
704         * WebKit.vcproj/WebKit.vcproj:
705
706 2007-06-19  Dave Hyatt  <hyatt@apple.com>
707
708         Fix for <rdar://problem/5022197>, backspace and ctrl+left arrow should go back.  Shift+backspace
709         and ctrl+right arrow should go forward.  Add support for these keybindings to Windows.
710        
711         Reviewed by ada
712
713         * WebView.cpp:
714         (WebView::keyDown):
715
716 2007-06-18  Dave Hyatt  <hyatt@apple.com>
717
718         Let through more newline+modifier key combos in order to support Alt+Enter and Ctrl+Enter in the
719         SafariWin URL bar.
720        
721         Reviewed by mccullough
722
723         * WebView.cpp:
724
725 2007-06-18  Dave Hyatt  <hyatt@apple.com>
726
727         Add support for horizontal mouse wheeling to Windows.  Shift+wheel is supported for horizontal
728         wheeling just like on OS X.  In addition, the WM_MOUSEHWHEEL event is now processed correctly so that
729         input devices like tilt wheels will now work.
730        
731         Reviewed by aroben
732
733         * WebView.cpp:
734         (WebView::mouseWheel):
735         (WebViewWndProc):
736         * WebView.h:
737
738 2007-06-17  Dave Hyatt  <hyatt@apple.com>
739
740         Add support for Ctrl+Mouse Wheel to increase/decrease text zoom (Win32 only).
741        
742         Reviewed by aroben
743
744         * WebView.cpp:
745         (WebView::mouseWheel):
746
747 2007-06-09  Steve Falkenburg  <sfalken@apple.com>
748
749         Reviewed by Adam.
750         
751         Workaround: <rdar://problem/5213266> schwab.com menu is ridiculously big.
752         
753         * WebView.cpp:
754         (WebView::userAgentForKURL): Add schwab to spoof list to fix gigantic menus.
755
756 2007-06-08  Ada Chan  <adachan@apple.com>
757
758         Reviewed by Hyatt, Adam, and Steve.
759
760         Fixed WebView::selectedText to get the selected text out of the focused frame or main frame.
761
762         * WebView.cpp:
763         (WebView::selectedText):
764
765 2007-06-08  Adam Roben  <aroben@apple.com>
766
767         Get rid of the Safari part of the query string used for Google searches.
768
769         Reviewed by Steve and Ada.
770
771         * WebContextMenuClient.cpp:
772         (WebContextMenuClient::searchWithGoogle):
773
774 2007-06-08  Kevin McCullough  <kmccullough@apple.com>
775
776         Reviewed by Kevin Decker, and Sam.
777
778         - Added and updated licenses.
779
780         * CFDictionaryPropertyBag.cpp:
781         * CFDictionaryPropertyBag.h:
782         * DOMCSSClasses.cpp:
783         * DOMCSSClasses.h:
784         * DOMEventsClasses.cpp:
785         * DOMEventsClasses.h:
786         * DOMHTMLClasses.cpp:
787         * DOMHTMLClasses.h:
788         * MarshallingHelpers.cpp:
789         * MarshallingHelpers.h:
790         * MemoryStream.cpp:
791         * MemoryStream.h:
792         * WebBackForwardList.cpp:
793         * WebBackForwardList.h:
794         * WebCache.cpp:
795         * WebCache.h:
796         * WebChromeClient.cpp:
797         * WebChromeClient.h:
798         * WebContextMenuClient.h:
799         * WebDataSource.h:
800         * WebEditorClient.cpp:
801         * WebEditorClient.h:
802         * WebElementPropertyBag.cpp:
803         * WebElementPropertyBag.h:
804         * WebHTMLRepresentation.h:
805         * WebHistory.cpp:
806         * WebHistory.h:
807         * WebIconDatabase.cpp:
808         * WebIconDatabase.h:
809         * WebKit.vcproj/auto-version.sh:
810         * WebKitClassFactory.h:
811         * WebKitDLL.h:
812         * WebLocalizableStrings.cpp:
813         * WebLocalizableStrings.h:
814         * WebMutableURLRequest.cpp:
815         * WebMutableURLRequest.h:
816         * WebNotification.cpp:
817         * WebNotification.h:
818         * WebNotificationCenter.cpp:
819         * WebNotificationCenter.h:
820         * WebPreferenceKeysPrivate.h:
821         * WebPreferences.cpp:
822         * WebPreferences.h:
823         * WebScriptObject.cpp:
824         * WebScriptObject.h:
825         * WebURLResponse.cpp:
826         * WebURLResponse.h:
827
828 2007-06-07  Sam Weinig  <sam@webkit.org>
829
830         Reviewed by Adam Roben.
831
832         Make the inspector compile again.
833
834         * WebInspector/WebInspector.cpp:
835         (setFocusedDOMNodeCallback):
836         (focusedDOMNodeCallback):
837         (setRootDOMNodeCallback):
838         (rootDOMNodeCallback):
839
840 2007-06-06  Steve Falkenburg  <sfalken@apple.com>
841
842         Reviewed by Adam.
843         
844         <rdar://problem/5255861> REGRESSION: Can't download Adobe Acrobat Reader and plug-in
845         <rdar://problem/5243655> Flash download page doesn't recognize Boomer
846         
847         Refine user agent spoofing code to only spoof Flash download as Firefox without spoofing all of adobe.com.
848         This fixes the Acrobat Reader download.
849
850         * WebView.cpp:
851         (WebView::userAgentForKURL):
852
853 2007-06-03  Steve Falkenburg  <sfalken@apple.com>
854
855         Reviewed by Adam.
856         
857         <rdar://problem/5246665> Drop down lists are not drawn on volvocars.us
858
859         * WebView.cpp:
860         (WebView::userAgentForKURL):
861
862 2007-06-01  Kevin McCullough  <kmccullough@apple.com>
863
864         Reviewed by Oliver.
865
866         - Uncommenting some functions that should not be commented out.  I needed them for the Drosera port.
867
868         * WebKit.vcproj/WebKit_debug.def:
869
870 2007-06-01  Steve Falkenburg  <sfalken@apple.com>
871
872         Reviewed by Kevin Decker.
873         
874         Remove unnecessary user agent spoofs, now that we have the final UA in place.
875         Added spoof to allow Flash downloads from adobe.com
876
877         * WebView.cpp:
878         (WebView::userAgentForKURL):
879
880 2007-05-30  Ada Chan  <adachan@apple.com>
881
882         Reviewed by Steve.
883
884         Implemented the mechanism to associate a WebPreferences instance with an identifier.
885
886         * WebIconDatabase.cpp:
887         (WebIconDatabase::init): fixed a missing Release on standardPrefs by using COMPtr.
888         * WebPreferences.cpp:
889         (WebPreferences::getInstanceForIdentifier): implemented
890         (WebPreferences::setInstance): implemented
891         (WebPreferences::removeReferenceForIdentifier): if the WebPreferences going to be
892         released has only one ref left, remove it from the s_webPreferencesInstances dictionary.
893         (WebPreferences::load): don't need to reread in the default preferences if we have done so.
894         (WebPreferences::initWithIdentifier): update the m_identifier data member with the
895         passed in identifier string, and store the identifier to WebPreferences instance mapping in
896         s_webPreferencesInstances dictionary.
897         (WebPreferences::identifier): implemented
898         * WebPreferences.h:
899         * WebView.cpp:
900         (WebView::~WebView): removed the call to removeObserver for the WebPreferencesChangedNotification
901         since it's already done in close().
902         (WebView::close): the call to removeObserver now takes in the WebPreferences instance for the object -
903         this way the WebView is only notified when that particular WebPreferences instance changes.
904         (WebView::initWithFrame): the call to addObserver now takes in the WebPreferences instance for the object -
905         this way the WebView is only notified when that particular WebPreferences instance changes.
906         (WebView::setPreferences): implemented
907         (WebView::onNotify): used COMPtr to fix a missing release
908
909 2007-05-29  Steve Falkenburg  <sfalken@apple.com>
910
911         Reviewed by Darin.
912         
913         Removed setPageCacheSize/pageCacheSize from IWebBackForwardList.
914
915         * Interfaces/IWebBackForwardList.idl: Removed unnecessary methods.
916         * WebBackForwardList.cpp: Removed unnecessary methods.
917         * WebBackForwardList.h: Removed unnecessary methods.
918
919 2007-05-29  Sam Weinig  <sam@webkit.org>
920
921         Reviewed by Adam Roben.
922
923         - Removes platform/win/NotImplemented.h because we have consolidated
924           the notImplemented() for all platforms in platform/NotImplemented.h
925         - Fixes remaining uses of old macro to use the new notImplemented() one.
926
927         * WebChromeClient.cpp:
928         (WebChromeClient::createModalDialog):
929         (WebChromeClient::canRunModal):
930         (WebChromeClient::runModal):
931         (WebChromeClient::setScrollbarsVisible):
932         (WebChromeClient::scrollbarsVisible):
933         (WebChromeClient::setMenubarVisible):
934         (WebChromeClient::menubarVisible):
935         * WebContextMenuClient.cpp:
936         (WebContextMenuClient::lookUpInDictionary):
937         (WebContextMenuClient::speak):
938         (WebContextMenuClient::stopSpeaking):
939         * WebDownload.cpp:
940         (WebDownload::canResumeDownloadDecodedWithEncodingMIMEType):
941         (WebDownload::cancelAuthenticationChallenge):
942         (WebDownload::continueWithoutCredentialForAuthenticationChallenge):
943         (WebDownload::useCredential):
944         (WebDownload::didReceiveAuthenticationChallenge):
945         * WebEditorClient.cpp:
946         (WebEditorClient::spellCheckerDocumentTag):
947         (WebEditorClient::shouldBeginEditing):
948         (WebEditorClient::shouldEndEditing):
949         (WebEditorClient::didBeginEditing):
950         (WebEditorClient::respondToChangedContents):
951         (WebEditorClient::respondToChangedSelection):
952         (WebEditorClient::didEndEditing):
953         (WebEditorClient::didWriteSelectionToPasteboard):
954         (WebEditorClient::didSetSelectionTypesForPasteboard):
955         (WebEditorClient::shouldDeleteRange):
956         (WebEditorClient::shouldInsertNode):
957         (WebEditorClient::shouldInsertText):
958         (WebEditorClient::shouldApplyStyle):
959         (WebEditorClient::shouldChangeTypingStyle):
960         (WebEditorClient::webViewDidChangeTypingStyle):
961         (WebEditorClient::webViewDidChangeSelection):
962         (WebEditorClient::shouldShowDeleteInterface):
963         (WebEditorClient::shouldChangeSelectedRange):
964         * WebFrame.cpp:
965         (WebFrame::makeRepresentation):
966         (WebFrame::forceLayout):
967         (WebFrame::forceLayoutForNonHTML):
968         (WebFrame::setCopiesOnScroll):
969         (WebFrame::detachedFromParent1):
970         (WebFrame::detachedFromParent2):
971         (WebFrame::detachedFromParent3):
972         (WebFrame::detachedFromParent4):
973         (WebFrame::loadedFromCachedPage):
974         (WebFrame::dispatchDidLoadMainResource):
975         (WebFrame::revertToProvisionalState):
976         (WebFrame::clearUnarchivingState):
977         (WebFrame::setMainFrameDocumentReady):
978         (WebFrame::willChangeTitle):
979         (WebFrame::didChangeTitle):
980         (WebFrame::finalSetupForReplace):
981         (WebFrame::setDefersLoading):
982         (WebFrame::isArchiveLoadPending):
983         (WebFrame::cancelPendingArchiveLoad):
984         (WebFrame::clearArchivedResources):
985         (WebFrame::canShowMIMEType):
986         (WebFrame::representationExistsForURLScheme):
987         (WebFrame::generatedMIMETypeForURLScheme):
988         (WebFrame::restoreViewState):
989         (WebFrame::provisionalLoadStarted):
990         (WebFrame::shouldTreatURLAsSameAsCurrent):
991         (WebFrame::addHistoryItemForFragmentScroll):
992         (WebFrame::didFinishLoad):
993         (WebFrame::prepareForDataSourceReplacement):
994         (WebFrame::setDocumentViewFromCachedPage):
995         (WebFrame::shouldGoToHistoryItem):
996         (WebFrame::saveViewStateToItem):
997         (WebFrame::saveDocumentViewToCachedPage):
998         (WebFrame::canCachePage):
999         (WebFrame::setMainDocumentError):
1000         (WebFrame::cannotShowURLError):
1001         (WebFrame::cannotShowMIMETypeError):
1002         (WebFrame::fileDoesNotExistError):
1003         (WebFrame::willUseArchive):
1004         (WebFrame::dispatchDidLoadResourceFromMemoryCache):
1005         (WebFrame::startDownload):
1006         (WebFrame::overrideMediaType):
1007         (WebFrame::addInspector):
1008         (WebFrame::removeInspector):
1009
1010 2007-05-25  Oliver Hunt  <oliver@apple.com>
1011
1012         Reviewed by Hyatt.
1013         
1014         Fix rdar://problem/5212399 <object> with PNG src rendered as image document (causes Acid2 to fail)
1015
1016         * WebFrame.cpp:
1017         (WebFrame::objectContentType):
1018
1019 2007-05-25  Geoffrey Garen  <ggaren@apple.com>
1020
1021         Build fix -- forgot to commit a little bit in my last patch.
1022
1023 2007-05-25  Geoffrey Garen  <ggaren@apple.com>
1024
1025         Reviewed by Darin Adler, Adam Roben.
1026
1027         Fixed <rdar://problem/5055182> The page cache has no global cap.
1028         
1029         The main WebKit changes are:
1030             1. Gutted IWebBackForwardList::setPageCacheSize and IWebBackForwardList:: 
1031             pageCacheSize because they're deprecated on Mac now. I didn't remove
1032             them, though, because doing so can cause COM badness.
1033             
1034             2. Added IWebPreferences::setUsesPageCache IWebPreferences:: 
1035             usesPageCache because that's the new Mac API. I added them to the end
1036             of IWebPreferences to avoid COM badness.
1037             
1038             3. Centralized calculation of object cache and page cache sizes inside
1039             WebPreferences. 
1040             
1041             Changed our old behavior of reading a preference and applying a fudge 
1042             factor with a new behavior of just using the preference directly. The 
1043             old behavior was confusing and often inappropriate. (For example, if 
1044             you set a page cache size of 100, a 256MB machine would somewhat 
1045             arbitrarily reduce that number to 98.)
1046             
1047 2007-05-24  Geoffrey Garen  <ggaren@apple.com>
1048
1049         Reviewed by Darin Adler.
1050
1051         Fixed a bug with Settings where a number of different objects held bare 
1052         Settings* data members, even though the Page owns the Settings object and 
1053         deletes it upon destruction.
1054         
1055         Added NULL checks since the Page can be deleted before the frame/document.
1056
1057 2007-05-23  Steve Falkenburg  <sfalken@apple.com>
1058
1059         Added IWebFramePrivate::isDescendantOfFrame.
1060
1061         * Interfaces/IWebFramePrivate.idl:
1062         * WebFrame.cpp:
1063         (WebFrame::isDescendantOfFrame):
1064         * WebFrame.h:
1065
1066 2007-05-23  Steve Falkenburg  <sfalken@apple.com>
1067
1068         Build fix.  Fix continuous rebuilding of Interfaces by turning off Generate Type Library for every IDL except WebKit.idl.
1069
1070         * WebKit.vcproj/Interfaces.vcproj:
1071
1072 2007-05-22  Alice Liu  <alice.liu@apple.com>
1073
1074         Reviewed by Oliver.
1075         
1076         Enabling smartInsertDelete to resolve 
1077         <rdar://problem/5082891> editing/deleting/smart-delete-003.html (and 004) fail
1078         
1079         * Interfaces/IWebView.idl:
1080         * WebEditorClient.cpp:
1081         (WebEditorClient::smartInsertDeleteEnabled):
1082         * WebView.cpp:
1083         (WebView::WebView):
1084         (WebView::initWithFrame):
1085         (WebView::toggleSmartInsertDelete):
1086         (WebView::setSmartInsertDeleteEnabled):
1087         (WebView::smartInsertDeleteEnabled):
1088         * WebView.h:
1089
1090 2007-05-22  Justin Garcia  <justin.garcia@apple.com>
1091
1092         Reviewed by oliver
1093         
1094         Build fix.
1095
1096         * WebView.cpp:
1097         (WebView::clearFocusNode):
1098
1099 2007-05-22  Steve Falkenburg  <sfalken@apple.com>
1100
1101         Reviewed by Ada.
1102         
1103         Added 3 view-related methods to IWebFramePrivate.
1104
1105         * Interfaces/IWebFramePrivate.idl: Added 3 new methods
1106         * WebFrame.cpp:
1107         (WebFrame::hasScrollBars): Added.
1108         (WebFrame::contentBounds): Added.
1109         (WebFrame::frameBounds): Added.
1110         * WebFrame.h:
1111
1112 2007-05-21  Steve Falkenburg  <sfalken@apple.com>
1113
1114         Reviewed by Adam, Ada.
1115         
1116         Added IWebFramePrivate::size().
1117
1118         * Interfaces/IWebFramePrivate.idl: Added size.
1119         * WebFrame.cpp:
1120         (WebFrame::size): Added.
1121         * WebFrame.h: Added size.
1122
1123 2007-05-21  Ada Chan  <adachan@apple.com>
1124
1125         Reviewed by Steve.
1126
1127         Added IWebViewPrivate::loadBackForwardListFromOtherView().  It replicates the backforward
1128         list from another webview and loads that in the current webview.
1129
1130         * Interfaces/IWebViewPrivate.idl:
1131         * WebView.cpp:
1132         (WebView::loadBackForwardListFromOtherView):
1133         * WebView.h:
1134
1135 2007-05-18  Steve Falkenburg  <sfalken@apple.com>
1136
1137         Build-related fix: stamp version resource properly.
1138
1139         * WebKit.vcproj/WebKit.rc: Fix version resource
1140
1141 2007-05-18  Adam Roben  <aroben@apple.com>
1142
1143         Build fix after r21555.
1144
1145         * WebView.cpp:
1146
1147 2007-05-17  Ada Chan  <adachan@apple.com>
1148
1149         Reviewed by Steve.
1150         
1151         Implemented IWebHTTPURLResponse::localizedStringForStatusCode().
1152
1153         * English.lproj/Localizable.strings: new http status strings
1154         * Interfaces/WebKit.idl: added code to create WebURLResponse instances
1155         * WebKitClassFactory.cpp:
1156         (WebKitClassFactory::CreateInstance): ditto
1157         * WebKitDLL.cpp: ditto
1158         * WebURLResponse.cpp:
1159         (CFHTTPMessageCopyLocalizedShortDescriptionForStatusCode): return the description
1160         text for the given status code
1161         (WebURLResponse::createInstance): create a general instance of web url response.
1162         (WebURLResponse::localizedStringForStatusCode):
1163         * WebURLResponse.h:
1164
1165 2007-05-17  Ada Chan  <adachan@apple.com>
1166
1167         Reviewed by Steve.
1168         
1169         Changed the context menu title "Search in Google" to "Search with Google".
1170
1171         * English.lproj/Localizable.strings:
1172         * WebCoreLocalizedStrings.cpp:
1173         (WebCore::contextMenuItemTagSearchWeb):
1174
1175 2007-05-17  Anders Carlsson  <andersca@apple.com>
1176
1177         Fix build.
1178         
1179         * WebFrame.cpp:
1180         (WebFrame::loadURLIntoChild):
1181
1182 2007-05-15  Steve Falkenburg  <sfalken@apple.com>
1183
1184         Reviewed by Darin, Oliver.
1185         
1186         <rdar://problem/4967360> Need to detect damaged installs, alert the user to reinstall, and exit
1187
1188         * WebLocalizableStrings.cpp:
1189         (WebLocalizedString): Make failure to load a localized string slightly less fatal
1190
1191 2007-05-15  Steve Falkenburg  <sfalken@apple.com>
1192
1193         Reviewed by Darin.
1194         
1195         <rdar://problem/4956541> Need to implement preference for how much History is maintained
1196
1197         * WebHistory.cpp:
1198         (WebHistory::ageLimitDate): Remove extra +30 from history age in days.
1199
1200 2007-05-14  Anders Carlsson  <andersca@apple.com>
1201
1202         Reviewed by Darin.
1203
1204         Pass an empty property bag when constructing the WebError, the code in Safari relies on having a user info bag.
1205         
1206         * WebFrame.cpp:
1207         (WebFrame::createJavaAppletWidget):
1208
1209 2007-05-14  Anders Carlsson  <andersca@apple.com>
1210
1211         Reviewed by Antti.
1212
1213         Report an error to the resource load delegate if the Java plugin can't be loaded.
1214         
1215         * WebFrame.cpp:
1216         (WebFrame::createJavaAppletWidget):
1217
1218 2007-05-11  Steve Falkenburg  <sfalken@apple.com>
1219
1220         Reviewed by Darin, Ada.
1221
1222         WebKit DCOM compatibility.
1223         When a WebKit hosting app calls RunAsLocalServer, the class object for CLSID_WebDebugProgram
1224         is registered to allow creation across processes.  This is for future compatibility with
1225         Drosera.
1226
1227         Added new exported function: RunAsLocalServer.
1228         This exposes WebKit inside the running exe as a LocalServer32 (COM server), which
1229         will allow Drosera to connect to it via DCOM.
1230
1231         We use the DCOM Universal Marshaller from oleaut32.dll, which performs marshalling
1232         based on type libraries, so as part of this change, I've done some work on making our
1233         interfaces compatible with this marshaller.
1234         
1235         Updated for compatibility w/ COM automation, and fixed up our type library.        
1236         Added type library registration/unregistration code.
1237         Marked methods not compatible w/ automation/marshalling as [local].
1238         
1239         As a side-effect, with these changes, the .NET tlbimp tool can create a .NET interop
1240         assembly to theoretically allow WebKit to be invoked from .NET apps.  I haven't
1241         tried this.  It could end up being useful to drive API testing.
1242         
1243         To test, I wrote a small app that calls:
1244         ::CoCreateInstance(CLSID_IWebDebugProgram, 0, CLSCTX_LOCAL_SERVER, IID_IUnknown, (void**)&viewUnknown);
1245         Using this instantiated class, I'm able to iterate the exisitng webviews and retrieve their
1246         source, title, URL, etc.
1247         
1248         * DOMCoreClasses.cpp:
1249         (DOMElement::isEqual):
1250         * DOMCoreClasses.h:
1251         * DefaultDownloadDelegate.cpp:
1252         (DefaultDownloadDelegate::decideDestinationWithSuggestedFilename):
1253         * DefaultDownloadDelegate.h:
1254         * Interfaces/DOMCSS.idl:
1255         * Interfaces/DOMCore.idl:
1256         * Interfaces/DOMEvents.idl:
1257         * Interfaces/DOMExtensions.idl:
1258         * Interfaces/DOMHTML.idl:
1259         * Interfaces/DOMPrivate.idl:
1260         * Interfaces/DOMRange.idl:
1261         * Interfaces/DOMWindow.idl:
1262         * Interfaces/IWebArchive.idl:
1263         * Interfaces/IWebAttributedString.idl: Removed.
1264         * Interfaces/IWebBackForwardList.idl:
1265         * Interfaces/IWebBackForwardListPrivate.idl:
1266         * Interfaces/IWebCache.idl:
1267         * Interfaces/IWebDataSource.idl:
1268         * Interfaces/IWebDebugProgram.idl: Added.
1269         * Interfaces/IWebDocument.idl:
1270         * Interfaces/IWebDownload.idl:
1271         * Interfaces/IWebEditingDelegate.idl:
1272         * Interfaces/IWebError.idl:
1273         * Interfaces/IWebFormDelegate.idl:
1274         * Interfaces/IWebFrame.idl:
1275         * Interfaces/IWebFrameLoadDelegate.idl:
1276         * Interfaces/IWebFrameLoadDelegatePrivate.idl:
1277         * Interfaces/IWebFramePrivate.idl:
1278         * Interfaces/IWebFrameView.idl:
1279         * Interfaces/IWebHTMLRepresentation.idl:
1280         * Interfaces/IWebHTTPURLResponse.idl:
1281         * Interfaces/IWebHistory.idl:
1282         * Interfaces/IWebHistoryItem.idl:
1283         * Interfaces/IWebHistoryItemPrivate.idl:
1284         * Interfaces/IWebIconDatabase.idl:
1285         * Interfaces/IWebJavaScriptCollector.idl:
1286         * Interfaces/IWebKitStatistics.idl:
1287         * Interfaces/IWebMutableURLRequest.idl:
1288         * Interfaces/IWebNotification.idl:
1289         * Interfaces/IWebNotificationCenter.idl:
1290         * Interfaces/IWebNotificationObserver.idl:
1291         * Interfaces/IWebPolicyDelegate.idl:
1292         * Interfaces/IWebPreferences.idl:
1293         * Interfaces/IWebResource.idl:
1294         * Interfaces/IWebResourceLoadDelegate.idl:
1295         * Interfaces/IWebResourceLoadDelegatePrivate.idl:
1296         * Interfaces/IWebScriptObject.idl:
1297         * Interfaces/IWebScrollBarDelegatePrivate.idl:
1298         * Interfaces/IWebScrollBarPrivate.idl:
1299         * Interfaces/IWebUIDelegate.idl:
1300         * Interfaces/IWebUIDelegatePrivate.idl:
1301         * Interfaces/IWebURLAuthenticationChallenge.idl:
1302         * Interfaces/IWebURLRequest.idl:
1303         * Interfaces/IWebURLResponse.idl:
1304         * Interfaces/IWebUndoManager.idl:
1305         * Interfaces/IWebUndoTarget.idl:
1306         * Interfaces/IWebView.idl:
1307         * Interfaces/IWebViewPrivate.idl:
1308         * Interfaces/WebKit.idl:
1309         * WebContextMenuClient.cpp:
1310         (WebContextMenuClient::getCustomMenuFromDefaultItems):
1311         * WebDataSource.cpp:
1312         (WebDataSource::subresources):
1313         * WebDataSource.h:
1314         * WebDebugProgram.cpp: Added.
1315         (EnumViews::EnumViews):
1316         (EnumViews::QueryInterface):
1317         (EnumViews::AddRef):
1318         (EnumViews::Release):
1319         (EnumViews::Next):
1320         (EnumViews::Skip):
1321         (EnumViews::Reset):
1322         (EnumViews::Clone):
1323         (WebDebugProgram::WebDebugProgram):
1324         (WebDebugProgram::~WebDebugProgram):
1325         (WebDebugProgram::createInstance):
1326         (WebDebugProgram::QueryInterface):
1327         (WebDebugProgram::AddRef):
1328         (WebDebugProgram::Release):
1329         (WebDebugProgram::viewAdded):
1330         (WebDebugProgram::viewRemoved):
1331         (WebDebugProgram::attach):
1332         (WebDebugProgram::detach):
1333         (WebDebugProgram::statistics):
1334         (WebDebugProgram::webViews):
1335         * WebDebugProgram.h: Added.
1336         * WebDropSource.cpp:
1337         (generateMouseEvent):
1338         * WebError.cpp:
1339         (WebError::localizedRecoveryOptions):
1340         * WebError.h:
1341         * WebFrame.cpp:
1342         (EnumChildFrames::EnumChildFrames):
1343         (EnumChildFrames::QueryInterface):
1344         (EnumChildFrames::AddRef):
1345         (EnumChildFrames::Release):
1346         (EnumChildFrames::Next):
1347         (EnumChildFrames::Skip):
1348         (EnumChildFrames::Reset):
1349         (EnumChildFrames::Clone):
1350         (WebFrame::childFrames):
1351         (WebFrame::initWithWebFrameView):
1352         * WebFrame.h:
1353         * WebHistoryItem.cpp:
1354         (WebHistoryItem::icon):
1355         * WebHistoryItem.h:
1356         * WebIconDatabase.cpp:
1357         (WebIconDatabase::iconForURL):
1358         (WebIconDatabase::defaultIconWithSize):
1359         * WebIconDatabase.h:
1360         * WebInspector/WebInspector.cpp:
1361         (WebInspector::WebInspector):
1362         (WebInspector::show):
1363         (WebInspector::onDestroy):
1364         (WebInspector::onSize):
1365         * WebInspector/WebInspector.h:
1366         (WebInspector::didReceiveIcon):
1367         (WebInspector::webViewFirstResponder):
1368         (WebInspector::makeFirstResponder):
1369         (WebInspector::contextMenuItemsForElement):
1370         (WebInspector::trackCustomPopupMenu):
1371         (WebInspector::addCustomMenuDrawingData):
1372         (WebInspector::cleanUpCustomMenuDrawingData):
1373         * WebKit.vcproj/Interfaces.vcproj:
1374         * WebKit.vcproj/WebKit.def:
1375         * WebKit.vcproj/WebKit.vcproj:
1376         * WebKit.vcproj/WebKitGUID.vcproj:
1377         * WebKit.vcproj/WebKit_debug.def:
1378         * WebKitClassFactory.cpp:
1379         (WebKitClassFactory::CreateInstance):
1380         * WebKitDLL.cpp:
1381         (DllGetClassObject):
1382         (DllUnregisterServer):
1383         (DllRegisterServer):
1384         (RunAsLocalServer):
1385         * WebKitStatistics.cpp:
1386         * WebScrollBar.cpp:
1387         (WebScrollBar::init):
1388         (WebScrollBar::handleMouseEvent):
1389         * WebScrollBar.h:
1390         * WebView.cpp:
1391         (WebView::WebView):
1392         (WebView::~WebView):
1393         (WebView::handleContextMenuEvent):
1394         (WebView::onInitMenuPopup):
1395         (WebView::onUninitMenuPopup):
1396         (WebViewWndProc):
1397         (WebView::QueryInterface):
1398         (WebView::MIMETypesShownAsHTML):
1399         (WebView::setHostWindow):
1400         (WebView::hostWindow):
1401         (WebView::generateSelectionImage):
1402         (WebView::pasteboardTypesForSelection):
1403         (WebView::pasteboardTypesForElement):
1404         (WebView::mainFrameIcon):
1405         (WebView::canMakeTextStandardSize):
1406         (WebView::viewWindow):
1407         * WebView.h:
1408
1409 2007-05-11  Adele Peterson  <adele@apple.com>
1410
1411         Build fix.
1412
1413         * WebView.cpp: (WebView::selectionImageRect):
1414
1415 2007-05-10  Geoffrey Garen  <ggaren@apple.com>
1416
1417         Reviewed by Darin Adler.
1418         
1419         "IconDatabase::sharedIconDatabase()" => "iconDatabase()" for terseness.
1420
1421 2007-05-10  Maciej Stachowiak  <mjs@apple.com>
1422
1423         Reviewed by Oliver.
1424
1425         - WebKitWin part of fix for:
1426         <rdar://problem/5063277> blank screen after login to Citibank Online (accessing document before frame starts loading cancels load)
1427         <rdar://problem/5159541> REGRESSION (r20972): Wall Street Journal pages replaced by advertisements (13465)
1428
1429         The basic approach is to have Frames start out containing an empty document instead of absolutely nothing,
1430         so there is no need to initialize them on demand. Various side effects of that cause both of these bugs.
1431         
1432         However, this caused many regressions so I had to fix the fallout.
1433
1434         * WebFrame.cpp:
1435         (WebFrame::createFrame): init frame
1436         * WebView.cpp:
1437         (WebView::initWithFrame): init frame
1438         (WebView::stringByEvaluatingJavaScriptFromString): don't create empty document
1439
1440 2007-05-08  Steve Falkenburg  <sfalken@apple.com>
1441
1442         Reviewed by Darin, Oliver.
1443         
1444         Added UI_STRING versions of localized WebCore strings.
1445
1446         * English.lproj/Localizable.strings: Updated.
1447         * English.lproj/StringsNotToBeLocalized.txt: Updated.
1448         * WebCoreLocalizedStrings.cpp: Added.
1449         (WebCore::searchableIndexIntroduction):
1450         (WebCore::submitButtonDefaultLabel):
1451         (WebCore::inputElementAltText):
1452         (WebCore::resetButtonDefaultLabel):
1453         (WebCore::fileButtonChooseFileLabel):
1454         (WebCore::fileButtonNoFileSelectedLabel):
1455         (WebCore::contextMenuItemTagOpenLinkInNewWindow):
1456         (WebCore::contextMenuItemTagDownloadLinkToDisk):
1457         (WebCore::contextMenuItemTagCopyLinkToClipboard):
1458         (WebCore::contextMenuItemTagOpenImageInNewWindow):
1459         (WebCore::contextMenuItemTagDownloadImageToDisk):
1460         (WebCore::contextMenuItemTagCopyImageToClipboard):
1461         (WebCore::contextMenuItemTagOpenFrameInNewWindow):
1462         (WebCore::contextMenuItemTagCopy):
1463         (WebCore::contextMenuItemTagGoBack):
1464         (WebCore::contextMenuItemTagGoForward):
1465         (WebCore::contextMenuItemTagStop):
1466         (WebCore::contextMenuItemTagReload):
1467         (WebCore::contextMenuItemTagCut):
1468         (WebCore::contextMenuItemTagPaste):
1469         (WebCore::contextMenuItemTagNoGuessesFound):
1470         (WebCore::contextMenuItemTagIgnoreSpelling):
1471         (WebCore::contextMenuItemTagLearnSpelling):
1472         (WebCore::contextMenuItemTagSearchWeb):
1473         (WebCore::contextMenuItemTagLookUpInDictionary):
1474         (WebCore::contextMenuItemTagOpenLink):
1475         (WebCore::contextMenuItemTagIgnoreGrammar):
1476         (WebCore::contextMenuItemTagSpellingMenu):
1477         (WebCore::contextMenuItemTagCheckSpelling):
1478         (WebCore::contextMenuItemTagCheckSpellingWhileTyping):
1479         (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
1480         (WebCore::contextMenuItemTagFontMenu):
1481         (WebCore::contextMenuItemTagBold):
1482         (WebCore::contextMenuItemTagItalic):
1483         (WebCore::contextMenuItemTagUnderline):
1484         (WebCore::contextMenuItemTagOutline):
1485         (WebCore::contextMenuItemTagWritingDirectionMenu):
1486         (WebCore::contextMenuItemTagDefaultDirection):
1487         (WebCore::contextMenuItemTagLeftToRight):
1488         (WebCore::contextMenuItemTagRightToLeft):
1489         (WebCore::contextMenuItemTagShowSpellingPanel):
1490         (WebCore::searchMenuNoRecentSearchesText):
1491         (WebCore::searchMenuRecentSearchesText):
1492         (WebCore::searchMenuClearRecentSearchesText):
1493         (WebCore::AXWebAreaText):
1494         (WebCore::AXLinkText):
1495         (WebCore::AXListMarkerText):
1496         (WebCore::AXImageMapText):
1497         (WebCore::AXHeadingText):
1498         * WebKit.vcproj/WebKit.vcproj: Added WebCoreLocalizedStrings.cpp, reorganized other files a bit.
1499
1500 2007-05-08  Steve Falkenburg  <sfalken@apple.com>
1501
1502         Reviewed by Ada.
1503         
1504         Update editing delegate
1505
1506         * Interfaces/IWebEditingDelegate.idl:
1507         * WebEditorClient.cpp:
1508         (WebEditorClient::updateSpellingUIWithGrammarString):
1509         * WebEditorClient.h:
1510
1511 2007-05-07  Steve Falkenburg  <sfalken@apple.com>
1512
1513         Reviewed by Darin.
1514
1515         Fix typo in prefs code.       
1516
1517         * WebPreferences.cpp:
1518         (WebPreferences::preferencesPath): Fix typo in error handling.
1519
1520 2007-05-04  Steve Falkenburg  <sfalken@apple.com>
1521
1522         Reviewed by Darin.
1523         
1524         Fix crash when using "check spelling while typing".
1525
1526         * WebView.cpp:
1527         (WebView::preflightSpellChecker): Set delegate static global for use in spell checker init.
1528
1529 2007-05-03  Steve Falkenburg  <sfalken@apple.com>
1530
1531         Reviewed by Ada, Oliver.
1532         
1533         Checkpoint:
1534         <rdar://problem/4602372> Spelling
1535         <rdar://problem/4769763> Spell checking engine support        
1536
1537         * Interfaces/IWebEditingDelegate.idl: Add userDescription parameter.
1538         * WebEditorClient.cpp:
1539         (WebEditorClient::updateSpellingUIWithGrammarString): Set user description for spelling errors.
1540         * WebEditorClient.h:
1541         * WebView.cpp:
1542         (WebView::replaceSelectionWithText): Implemented.
1543
1544 2007-05-01  Steve Falkenburg  <sfalken@apple.com>
1545
1546         Reviewed by Oliver.
1547         
1548         Fix usage errors in COM enumeration.
1549
1550         * WebEditorClient.cpp:
1551         (WebEditorClient::checkGrammarOfString): Call Next correctly.
1552         (WebEditorClient::getGuessesForWord): Call Next correctly.
1553
1554 2007-04-30  Alice Liu  <alice.liu@apple.com>
1555
1556         Reviewed by Adam.
1557
1558         Fixed <rdar://5126201> crash closing tab when the two following tabs are empty.
1559         Basically this fix involved one thing, which lead to another thing.  First, the crash
1560         was fixed by moving the call to webView->close from SearchableWebView::onDestroy to
1561         WebViewWndProc when WM_DESTROY message is processed.  We now want only WebKit handling
1562         the closure of a WebView, so all calls to WebView::close have been removed, save for
1563         the one call in WebViewWndProc.
1564
1565         * Interfaces/IWebView.idl:
1566         removed close() from public interface
1567         * WebInspector/WebInspector.cpp:
1568         (WebInspector::onDestroy):
1569         removed call to close()
1570         * WebView.cpp:
1571         (WebView::~WebView):
1572         move the deleting of m_page down a bit to avoid a crash 
1573         (WebView::close):
1574         changed from public API to just a public function
1575         (WebViewWndProc):
1576         webView->close() was moved here from SearchableWebView::onDestroy
1577         * WebView.h:
1578         changed close() to a public function not exposed in the WebKit interface
1579
1580 2007-04-24  Steve Falkenburg  <sfalken@apple.com>
1581
1582         Reviewed by Darin, Oliver.
1583         
1584         Checkpoint:
1585         <rdar://problem/4602372> Spelling
1586         <rdar://problem/4769763> Spell checking engine support
1587
1588         * WebEditorClient.cpp:
1589         (WebEditorClient::isContinuousSpellCheckingEnabled):
1590         (WebEditorClient::toggleContinuousSpellChecking):
1591         (WebEditorClient::isGrammarCheckingEnabled):
1592         (WebEditorClient::toggleGrammarChecking):
1593         (initViewSpecificSpelling):
1594         (WebEditorClient::spellCheckerDocumentTag):
1595         (WebEditorClient::ignoreWordInSpellDocument):
1596         (WebEditorClient::learnWord):
1597         (WebEditorClient::checkSpellingOfString):
1598         (WebEditorClient::checkGrammarOfString):
1599         (WebEditorClient::udpateSpellingUIWithGrammarString):
1600         (WebEditorClient::updateSpellingUIWithMisspelledWord):
1601         (WebEditorClient::showSpellingUI):
1602         (WebEditorClient::spellingUIIsShowing):
1603         (WebEditorClient::getGuessesForWord):
1604         * WebPreferences.h:
1605
1606 2007-04-20  Ada Chan  <adachan@apple.com>
1607
1608         Reviewed by Steve and Oliver.
1609         
1610         Implemented some DOM methods I need to support password input and textarea in 
1611         WebView-based edit fields in the app.
1612
1613         * DOMCSSClasses.cpp:
1614         (DOMCSSStyleDeclaration::setCssText): added implementation
1615         * DOMCoreClasses.cpp:
1616         (DOMDocument::createElement): ditto
1617         * DOMHTMLClasses.cpp:
1618         (DOMHTMLInputElement::setType): ditto
1619         (DOMHTMLTextAreaElement::value): ditto
1620         (DOMHTMLTextAreaElement::setValue): ditto
1621         (DOMHTMLTextAreaElement::select): ditto
1622         * Interfaces/IWebUIDelegatePrivate.idl: added a new method webViewGetDlgCode() that client
1623         can implement if it wants to handle keypresses themselves rather than letting the system 
1624         interpret certain keys as dialog box navigation keys.
1625         * WebKitGraphics.cpp:
1626         (DrawTextAtPoint): handle drawing text as password
1627         * WebKitGraphics.h:
1628         * WebView.cpp:
1629         Added Copy, Cut, and Paste to the keyEntries.
1630         (WebViewWndProc): added code to handle WM_GETDLGCODE.  Calls IWebUIDelegatePrivate::webViewGetDlgCode()
1631         if available to see if the client wants to handle it.
1632
1633 2007-04-18  Adam Roben  <aroben@apple.com>
1634
1635         Reviewed by Steve.
1636
1637         Make development builds use the same CLSIDs as archive builds, and get
1638         rid of the now-unused set of CLSIDs.
1639
1640         * Interfaces/WebKit.idl: Use the archive build CLSIDs if we're not
1641         doing a production build.
1642         * WebKit.vcproj/Interfaces.vcproj: Don't define __ARCHIVE_BUILD__
1643         because it's not used anymore.
1644
1645 2007-04-18  Adam Roben  <aroben@apple.com>
1646
1647         Reviewed by Steve.
1648
1649         Use different ProgIDs for production builds.
1650
1651         * ProgIDMacros.h: Added.
1652         * WebKit.vcproj/WebKit.vcproj: Defined the __BUILDBOT__ macro and added
1653         a new header which is copied in the post-build step.
1654         * WebKitDLL.cpp: Macro-ized the declaration of the registry keys to
1655         install.
1656
1657 2007-04-16  Adam Roben  <aroben@apple.com>
1658
1659         Rubberstamped by Steve.
1660
1661         * WebKit.vcproj/WebKit.sln: Removed the Debug_Internal configuration.
1662
1663 2007-04-16  Adam Roben  <aroben@apple.com>
1664
1665         Reviewed by Steve.
1666
1667         Removed the pre-link build step, and removed registration of WebKit.dll
1668         from the post-build step.
1669
1670         * WebKit.vcproj/WebKit.vcproj:
1671
1672 2007-04-16  Adam Roben  <aroben@apple.com>
1673
1674         * WebKit.vcproj/WebKit.sln: Added WTF to the solution.
1675
1676 2007-04-16  Steve Falkenburg  <sfalken@apple.com>
1677
1678         Reviewed by Adam.
1679         
1680         Visual Studio Express compatibility for WebKit build (except for DRT)
1681
1682         * WebDragClient.cpp: Removed unused header (atlsafe.h)
1683         * WebKit.vcproj/WebKit.rc: Removed afxres.h and related code
1684         * WebKit.vcproj/WebKit.sln: Don't use a sln folder - they aren't supported by express
1685         * WebKit.vcproj/WebKit.vcproj: Add explicit lib references for Windows system libs (VS express doesn't include these)
1686         * WebView.cpp: Removed unused header (atldef.h)
1687
1688 2007-04-16  Adam Roben  <aroben@apple.com>
1689
1690         Merge in r20872.
1691
1692         * WebInspector/webInspector/inspector.js:
1693         * WebInspector/webInspector/treeoutline.js:
1694
1695 2007-04-16  Adam Roben  <aroben@apple.com>
1696
1697         Merge in r20861.
1698
1699         * WebInspector/webInspector/inspector.js:
1700         * WebInspector/webInspector/treeoutline.js:
1701
1702 2007-04-16  Adam Roben  <aroben@apple.com>
1703
1704         Merge in r20845.
1705
1706         * WebInspector/webInspector/inspector.js:
1707
1708 2007-04-16  Adam Roben  <aroben@apple.com>
1709
1710         Merge in r20844.
1711
1712         * WebInspector/webInspector/inspector.js:
1713
1714 2007-04-16  Adam Roben  <aroben@apple.com>
1715
1716         Merge in r20843.
1717
1718         * WebInspector/webInspector/inspector.js:
1719         * WebInspector/webInspector/scrollarea.js:
1720         * WebInspector/webInspector/scrollbar.js:
1721         * WebInspector/webInspector/utilities.js:
1722
1723 2007-04-16  Adam Roben  <aroben@apple.com>
1724
1725         Merge in r20842.
1726
1727         * WebInspector/webInspector/inspector.html:
1728         * WebInspector/webInspector/inspector.js:
1729         * WebInspector/webInspector/utilities.js: Added.
1730
1731 2007-04-16  Adam Roben  <aroben@apple.com>
1732
1733         Merge in r20840.
1734
1735         * WebInspector/webInspector/inspector.html:
1736         * WebInspector/webInspector/inspector.js:
1737         * WebInspector/webInspector/treeoutline.js: Added.
1738
1739 2007-04-14  Adam Roben  <aroben@apple.com>
1740
1741         * WebKit.vcproj/WebKitGUID.vcproj: Need to use WebKitConfigSuffix
1742         instead of ConfigSuffix now.
1743
1744 2007-04-14  Adam Roben  <aroben@apple.com>
1745
1746         * WebKit.vcproj/WebKit.submit.sln: Use the Debug_Internal configuration
1747         when B&I builds Debug.
1748
1749 2007-04-12  Steve Falkenburg  <sfalken@apple.com>
1750
1751         Reviewed by Geoff, Adam.
1752         
1753         Changes required for search history content.
1754
1755         * Interfaces/IWebFramePrivate.idl:
1756         * WebFrame.cpp:
1757         (WebFrame::isFrameSet): Added
1758         (WebFrame::string): Added
1759         * WebFrame.h:
1760
1761 2007-04-12  Adam Roben  <aroben@apple.com>
1762
1763         Rubberstamped by Steve.
1764
1765         Copied WebKit.sln to WebKit.submit.sln, and added missing projects to
1766         WebKit.sln so that opensource contributors can use it to build a
1767         working WebKit.
1768
1769         * WebKit.vcproj/WebKit.make: Changed to use WebKit.submit.sln.
1770         * WebKit.vcproj/WebKit.sln: Added JavaScriptCore, WebCore,
1771         DumpRenderTree projects.
1772         * WebKit.vcproj/WebKit.submit.sln: Added.
1773
1774 2007-04-12  Adam Roben  <aroben@apple.com>
1775
1776         Reviewed by Steve.
1777
1778         <rdar://problem/5131565> Need to be able to use debug WebKit with
1779         release Safari.
1780
1781         Added a new configuration to WebKit.vcproj called Debug_Internal to be
1782         used by Apple internal builds. The Debug configuration is now meant to
1783         be used by opensource builds, and will always link against release
1784         versions of CF, CFNet, CG, etc. Debug_Internal is identical to Debug
1785         except for the property sheet it uses, and the Debug configuration
1786         doesn't register WebKit_debug.dll when finished.
1787
1788         We now have two macros, $(WebKitConfigSuffix) and
1789         $(LibraryConfigSuffix). WebKitConfigSuffix is used for WebKit projects,
1790         and is "_debug" for both Debug and Debug_Internal. LibraryConfigSuffix
1791         is used for external projects, and is "" for Debug and "_debug" for
1792         Debug_Internal.
1793
1794         * WebKit.vcproj/WebKit.vcproj:
1795         * WebKit.vcproj/debug.vsprops:
1796         * WebKit.vcproj/debug_internal.vsprops: Added.
1797         * WebKit.vcproj/release.vsprops:
1798
1799 2007-04-12  John Sullivan  <sullivan@apple.com>
1800
1801         Reviewed by Anders
1802
1803         * Interfaces/IWebUIDelegate.idl:
1804         added new PDF-related context menu items to enum to keep it in sync with WebCore
1805
1806 2007-04-12  Mark Rowe  <mrowe@apple.com>
1807
1808         Not reviewed.  Internal counterpart to open-source r20856.
1809
1810         * WebChromeClient.cpp:
1811         (WebChromeClient::createWindow):
1812         (WebChromeClient::createModalDialog):
1813         * WebChromeClient.h:
1814
1815 2007-04-11  Ada Chan  <adachan@apple.com>
1816
1817         Reviewed by Steve.
1818         
1819         Implemented WebHistoryItem::originalURLString().  Added parameter checks to other methods.
1820
1821         * WebHistoryItem.cpp:
1822         (WebHistoryItem::originalURLString):
1823         (WebHistoryItem::URLString):
1824         (WebHistoryItem::title):
1825         (WebHistoryItem::lastVisitedTimeInterval):
1826
1827 2007-04-10  Brady Eidson  <beidson@apple.com>
1828
1829         Reviewed by Darin
1830
1831         <rdar://problem/4887095> - PageCache and PageState should be combined
1832
1833         Basically updated client methods for the new names and signatures 
1834
1835         * WebFrame.cpp:
1836         (WebFrame::loadedFromCachedPage):
1837         (WebFrame::setDocumentViewFromCachedPage):
1838         (WebFrame::saveDocumentViewToCachedPage):
1839         * WebFrame.h:
1840
1841 2007-04-10  Adam Roben  <aroben@apple.com>
1842
1843         Reviewed by Anders.
1844
1845         Fix <rdar://problem/5119803> Web Inspector has no options menu
1846
1847         * WebInspector/WebInspector.cpp:
1848         (interpreterForFrame): Added.
1849         (WebInspector::showOptionsMenu): Implemented.
1850         (WebInspector::onCommand): Added.
1851         (WebInspector::toggleIgnoreWhitespace): Implemented.
1852         (WebInspector::toggleShowUserAgentStyles): Implemented.
1853         (WebInspectorWndProc): Added case for WM_COMMAND.
1854         * WebInspector/WebInspector.h:
1855
1856 2007-04-09  Anders Carlsson  <andersca@apple.com>
1857
1858         Reviewed by Adam.
1859
1860         <rdar://problem/5062624>
1861         No prompt to install QT for pages with uninstalled QT plug-in.
1862         
1863         * CFDictionaryPropertyBag.cpp:
1864         (CFDictionaryPropertyBag::Read):
1865         (CFDictionaryPropertyBag::Write):
1866         Use LPCOLESTRToCFStringRef here since the property names aren't BSTRs.
1867         
1868         * Interfaces/IWebError.idl:
1869         Add user info keys.
1870         
1871         * MarshallingHelpers.cpp:
1872         (MarshallingHelpers::LPCOLESTRToCFStringRef):
1873         * MarshallingHelpers.h:
1874         New function.
1875         
1876         * WebError.cpp:
1877         (WebError::WebError):
1878         (WebError::createInstance):
1879         Take a property bag.
1880         
1881         (WebError::userInfo):
1882         Return the property bag.
1883         
1884         * WebFrame.cpp:
1885         (WebFrame::createPlugin):
1886         If the plug-in wasn't found or failed to load, create a WebError with the right user info and
1887         call IWebResourceLoadDelegate::plugInFailedWithError.
1888
1889 2007-04-09  Brady Eidson  <beidson@apple.com>
1890
1891         Build Fix
1892
1893         * WebContextMenuClient.cpp:
1894         (WebContextMenuClient::searchWithGoogle): userGesture is true
1895
1896 2007-04-09  Timothy Hatcher  <timothy@apple.com>
1897
1898         Merge in r20810.
1899
1900         <rdar://problem/5121757> WebInspector focuses elements on mouse up instead of mouse down
1901
1902         Make selecting a tree node happen on mousedown to match the NSOutlineView behavior.
1903         Also makes selecting rows in the style pane happen on mousedown for consistency.
1904
1905         * WebInspector/webInspector/inspector.js:
1906
1907 2007-04-09  Adam Roben  <aroben@apple.com>
1908
1909         Fixed copyrights.
1910
1911         * WebInspector/WebInspector.cpp:
1912         * WebInspector/WebInspector.h:
1913
1914 2007-04-09  Adam Roben  <aroben@apple.com>
1915
1916         Reviewed by Oliver.
1917
1918         Fix two Web Inspector bugs:
1919         - The WebView wasn't focused when the inspector first appeared.
1920         - Resizing the upper pane did not resize the whole window.
1921
1922         * WebInspector/WebInspector.cpp:
1923         (WebInspector::show): Focus the WebView.
1924         (WebInspector::setFrame): Implemented.
1925         (WebInspector::webViewFrame): Implemented.
1926         * WebInspector/WebInspector.h:
1927
1928 2007-04-09  Adam Roben  <aroben@apple.com>
1929
1930         * WebInspector/WebInspector.cpp:
1931         (WebInspector::WebInspector): Removed two fixed FIXMEs and some
1932         commented-out code.
1933
1934 2007-04-08  Adam Roben  <aroben@apple.com>
1935
1936         When does "merge" != "merge"? When you make the change yourself
1937         pre-emptively and make a typo.
1938
1939         * WebInspector/webInspector/inspector.js:
1940
1941 2007-04-08  Adam Roben  <aroben@apple.com>
1942
1943         Merge in r20800.
1944
1945         * WebInspector/webInspector/inspector.js:
1946
1947 2007-04-08  Adam Roben  <aroben@apple.com>
1948
1949         Merge in r20797.
1950
1951         * WebInspector/webInspector/inspector.js:
1952
1953 2007-04-08  Adam Roben  <aroben@apple.com>
1954
1955         Merge in r20796.
1956
1957         * WebInspector/webInspector/inspector.js:
1958
1959 2007-04-08  Adam Roben  <aroben@apple.com>
1960
1961         Reviewed by Anders.
1962
1963         <rdar://problem/5119804> Web Inspector isn't resizable
1964         <rdar://problem/5119805> Can't move Web Inspector
1965
1966         * WebInspector/WebInspector.cpp:
1967         (WebInspectorPrivate::WebInspectorPrivate):
1968         (WebInspector::WebInspector): Subclass the WebView so we can intercept
1969         its messages.
1970         (WebInspector::onDestroy): Undo the subclassing.
1971         (WebInspector::handleMessageSentToWebView): Added.
1972         (WebInspector::onLButtonDown): Added.
1973         (WebInspector::onLButtonUp): Added.
1974         (WebInspector::onMouseMove): Added.
1975         (WebInspectorWndProc): Added cases for mouse messages.
1976         (SubclassedWebViewWndProc): Added.
1977         * WebInspector/WebInspector.h:
1978
1979 2007-04-08  Adam Roben  <aroben@apple.com>
1980
1981         Merge in r20793.
1982
1983         * WebInspector/webInspector/AppleScrollArea.js: Removed.
1984         * WebInspector/webInspector/AppleScrollbar.js: Removed.
1985         * WebInspector/webInspector/Images/resize.png: Added.
1986         * WebInspector/webInspector/inspector.css:
1987         * WebInspector/webInspector/inspector.html:
1988         * WebInspector/webInspector/inspector.js:
1989         * WebInspector/webInspector/scrollarea.js: Added.
1990         * WebInspector/webInspector/scrollbar.js: Added.
1991
1992 2007-04-08  Adam Roben  <aroben@apple.com>
1993
1994         Merge in r20792.
1995
1996         * WebInspector/webInspector/inspector.js:
1997
1998 2007-04-08  Adam Roben  <aroben@apple.com>
1999
2000         Merge in r20791.
2001
2002         * WebInspector/webInspector/inspector.js:
2003
2004 2007-04-08  Adam Roben  <aroben@apple.com>
2005
2006         Merge in r20789.
2007
2008         * WebInspector/webInspector/inspector.js:
2009
2010 2007-04-08  Adam Roben  <aroben@apple.com>
2011
2012         Build fix.
2013
2014         * WebInspector/WebInspector.cpp:
2015
2016 2007-04-07  Adam Roben  <aroben@apple.com>
2017
2018         Reviewed by Oliver.
2019
2020         <rdar://problem/4769828> Web Inspector
2021
2022         * WebInspector/WebInspector.cpp: Renamed from WebInspector.m. Ported
2023         Mac code. Some parts are left commented out to aid later
2024         implementation.
2025         * WebInspector/WebInspector.h: Ditto.
2026
2027         * DOMCoreClasses.cpp: Added IID_DOMNode.
2028         (DOMNode::QueryInterface): Added case for IID_DOMNode.
2029         (DOMNode::isSameNode): Implemented.
2030         * DOMCoreClasses.h: Added IID_DOMNode.
2031         (DOMNode::node): Added.
2032         * English.lproj/Localizable.strings: Updated for "Inspect Element".
2033         * WebContextMenuClient.cpp:
2034         (WebContextMenuClient::getCustomMenuFromDefaultItems): Add the "Inspect
2035         Element" item.
2036         * WebFrame.cpp:
2037         (WebFrame::addInspector): Stubbed out.
2038         (WebFrame::removeInspector): Ditto.
2039         * WebFrame.h: Added declarations.
2040         * WebKit.resources/Info.plist: Added. This was needed so that the
2041         WebKit bundle would have a bundle identifier.
2042         * WebKit.vcproj/WebKit.vcproj: Added new files to project, and modified
2043         the post-build step to copy Info.plist and everything in
2044         WebInspector/webInspector to WebKit.resources.
2045         * WebView.cpp:
2046         (WebView::performContextMenuAction): Added case for the Inspect Element item.
2047         (WebView::inspectElement): Added.
2048         * WebView.h: Added declaration.
2049
2050 2007-04-07  Adam Roben  <aroben@apple.com>
2051
2052         Forked most of the WebInspector directory from
2053         r20780 of branches/WebInspectorRefresh/WebKit/WebInspector.
2054
2055         * WebInspector/WebInspector.h: Added.
2056         * WebInspector/WebInspector.m: Added.
2057         (+[WebInspector sharedWebInspector]):
2058         (-[WebInspector init]):
2059         (-[WebInspector initWithWebFrame:]):
2060         (-[WebInspector dealloc]):
2061         (-[WebInspector window]):
2062         (-[WebInspector windowWillClose:]):
2063         (-[WebInspector showWindow:]):
2064         (-[WebInspector setWebFrame:]):
2065         (-[WebInspector webFrame]):
2066         (-[WebInspector setRootDOMNode:]):
2067         (-[WebInspector rootDOMNode]):
2068         (-[WebInspector setFocusedDOMNode:]):
2069         (-[WebInspector focusedDOMNode]):
2070         (-[WebInspector setSearchQuery:]):
2071         (-[WebInspector searchQuery]):
2072         (-[WebInspector showOptionsMenu]):
2073         (-[WebInspector _toggleIgnoreWhitespace:]):
2074         (-[WebInspector _toggleShowUserAgentStyles:]):
2075         (-[WebInspector _highlightNode:]):
2076         (-[WebInspector _nodeHighlightExpired:]):
2077         (-[WebInspector _update]):
2078         (-[WebInspector _updateRoot]):
2079         (-[WebInspector _updateSystemColors]):
2080         (-[WebInspector _applicationWillResignActive]):
2081         (-[WebInspector _applicationDidBecomeActive]):
2082         (-[WebInspector _webFrameDetached:]):
2083         (+[WebInspector isSelectorExcludedFromWebScript:]):
2084         (+[WebInspector webScriptNameForSelector:]):
2085         (+[WebInspector isKeyExcludedFromWebScript:]):
2086         (-[WebInspector inspectedWebViewProgressFinished:]):
2087         (-[WebInspector webView:didFinishLoadForFrame:]):
2088         (-[WebInspector webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2089         (-[WebInspector webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
2090         (-[WebInspector webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
2091         (-[WebInspectorPrivate dealloc]):
2092         (-[DOMNode _isAncestorOfNode:]):
2093         * WebInspector/webInspector/AppleScrollArea.js: Added.
2094         * WebInspector/webInspector/AppleScrollbar.js: Added.
2095         * WebInspector/webInspector/Images/button.png: Added.
2096         * WebInspector/webInspector/Images/buttonDivider.png: Added.
2097         * WebInspector/webInspector/Images/buttonPressed.png: Added.
2098         * WebInspector/webInspector/Images/close.png: Added.
2099         * WebInspector/webInspector/Images/closePressed.png: Added.
2100         * WebInspector/webInspector/Images/downTriangle.png: Added.
2101         * WebInspector/webInspector/Images/menu.png: Added.
2102         * WebInspector/webInspector/Images/menuPressed.png: Added.
2103         * WebInspector/webInspector/Images/popup.png: Added.
2104         * WebInspector/webInspector/Images/popupPressed.png: Added.
2105         * WebInspector/webInspector/Images/rightTriangle.png: Added.
2106         * WebInspector/webInspector/Images/scrollThumbBottom.png: Added.
2107         * WebInspector/webInspector/Images/scrollThumbMiddle.png: Added.
2108         * WebInspector/webInspector/Images/scrollThumbTop.png: Added.
2109         * WebInspector/webInspector/Images/scrollTrackBottom.png: Added.
2110         * WebInspector/webInspector/Images/scrollTrackMiddle.png: Added.
2111         * WebInspector/webInspector/Images/scrollTrackTop.png: Added.
2112         * WebInspector/webInspector/Images/upTriangle.png: Added.
2113         * WebInspector/webInspector/inspector.css: Added.
2114         * WebInspector/webInspector/inspector.html: Added.
2115         * WebInspector/webInspector/inspector.js: Added.
2116
2117 2007-04-06  Dave Hyatt  <hyatt@apple.com>
2118
2119         Internal side of fix for bug 13274.
2120
2121         Reviewed by olliej
2122
2123         * Interfaces/IWebScrollBarPrivate.idl:
2124         * WebScrollBar.cpp:
2125         * WebScrollBar.h:
2126         * WebView.cpp:
2127         (WebView::handleMouseEvent):
2128
2129 2007-04-04  Oliver Hunt  <oliver@apple.com>
2130
2131         Reviewed by Ada.
2132         
2133         Fix <rdar://problem/5111027> Dragging a link on page
2134         shows URL thumbnail as nearly-transparent instead 
2135         semi-transparent
2136
2137         Error in createDragImageForLink led me to get wrong 
2138         maximum drag image size, now logic and maximum drag 
2139         image size corrected.
2140
2141         * WebDragClient.cpp:
2142         (WebDragClient::createDragImageForLink):
2143
2144 2007-04-04  Adam Roben  <aroben@apple.com>
2145
2146         Release build fix for TestNetscapePlugin.
2147
2148         * WebKit.vcproj/WebKit.vcproj: Make the Release post-build step the
2149         same as the Debug one so that the npapi headers get copied.
2150
2151 2007-04-03  Adam Roben  <aroben@apple.com>
2152
2153         Reviewed by Anders.
2154
2155         WebKit part of fix for <rdar://problem/5103999> All dom/svg tests are
2156         failing due to extra/missing newlines
2157
2158         * DOMCoreClasses.cpp:
2159         (DOMElement::innerText): Added.
2160         * DOMCoreClasses.h: Added declaration.
2161         * Interfaces/DOMPrivate.idl: Ditto.
2162
2163 2007-04-02  Steve Falkenburg  <sfalken@apple.com>
2164
2165         Reviewed by Darin.
2166         
2167         Expose COM class counter
2168
2169         * Interfaces/IWebKitStatistics.idl: Added comClassCount
2170         * WebKitStatistics.cpp:
2171         (WebKitStatistics::comClassCount): Added
2172         * WebKitStatistics.h:
2173
2174 2007-03-31  Steve Falkenburg  <sfalken@apple.com>
2175
2176         Reviewed by Hyatt.
2177
2178         <rdar://problem/5091159> Boomer has no bundle identifier - is the bundle correctly formed?
2179         <rdar://problem/5088764> Move the "Icon.db" file under "Local Settings"
2180
2181         * WebIconDatabase.cpp:
2182         (userIconDatabasePath): Prefer to store Icon.db file keyed off of bundle executable name
2183         * WebPreferences.cpp:
2184         (WebPreferences::preferencesPath): Prefer to store WebKit Preferences keyed off of bundle executable name
2185
2186 2007-03-30  Adele Peterson  <adele@apple.com>
2187
2188         Reviewed by Beth.
2189
2190         Fix <rdar://problem/5079824> editing/deleting/delete-by-word-001 is failing
2191
2192         * WebView.cpp: Add DeleteWordForward and DeleteWordBackward to key command table.
2193
2194 2007-03-30  Anders Carlsson  <andersca@apple.com>
2195
2196         Reviewed by Adele.
2197
2198         <rdar://problem/5101970> 
2199         Crash when submitting form, running under App Verifier
2200         
2201         * WebActionPropertyBag.cpp:
2202         (findMouseEvent):
2203         Return the right event.
2204
2205 2007-03-30  Anders Carlsson  <andersca@apple.com>
2206
2207         Reviewed by Geoff.
2208
2209         * Interfaces/IWebViewPrivate.idl:
2210         Add addAdditionalPluginPath method.
2211         
2212         * WebKit.vcproj/WebKit.vcproj:
2213         Copy NP includes so they can be included by the test plugin.
2214         
2215         * WebView.cpp:
2216         (WebView::stringByEvaluatingJavaScriptFromString):
2217         Hold JSLock while we call JSValue::getString().
2218         
2219         (WebView::addAdditionalPluginPath):
2220         * WebView.h:
2221         Implement addAdditionalPluginPath.
2222
2223 2007-03-27  Dave Hyatt  <hyatt@apple.com>
2224
2225         Enable complex text.  Selection and small-caps support are now enabled with this patch.
2226         
2227         Reviewed by aroben
2228
2229         * WebPreferences.cpp:
2230         (WebPreferences::initialize):
2231
2232 2007-03-26  Brady Eidson  <beidson@apple.com>
2233
2234         Reviewed by Ada
2235
2236         This one didn't actually have any leaks, but I just felt like doing the
2237         same style cleanup as the others :)
2238         
2239         * WebPreferences.cpp:
2240         (WebPreferences::stringValueForKey):
2241         (WebPreferences::integerValueForKey):
2242         (WebPreferences::floatValueForKey):
2243         (WebPreferences::setStringValue):
2244         (WebPreferences::setIntegerValue):
2245         (WebPreferences::save):
2246         (WebPreferences::load):
2247
2248 2007-03-26  Brady Eidson  <beidson@apple.com>
2249
2250         Reviewed by Ada
2251
2252         <rdar://5090412> - Plug CFNumberRef leaks in WebCache
2253         
2254         * WebCache.cpp:
2255         (WebCache::statistics):
2256
2257 2007-03-26  Beth Dakin  <bdakin@apple.com>
2258
2259         Reviewed by Geoff.
2260
2261         Fix build without breaking anything.
2262
2263         * WebHistory.cpp:
2264         (releaseUserInfo): Added silly void statement for now.
2265
2266 2007-03-26  Beth Dakin  <bdakin@apple.com>
2267
2268         Rubber-stamped by Brady.
2269
2270         Build fix for release build.
2271
2272         * WebHistory.cpp:
2273         (releaseUserInfo): Do not store userInfo->Release() in a local 
2274         variable since it is only used for an ASSERT.
2275
2276 2007-03-26  Steve Falkenburg  <sfalken@apple.com>
2277
2278         Reviewed by Lou.
2279         
2280         <rdar://problem/5088764> Move the "Icon.db" file under "Local Settings"
2281
2282         * WebIconDatabase.cpp:
2283         (userIconDatabasePath): Move icon database to non-roaming location
2284
2285 2007-03-25  Brady Eidson  <beidson@apple.com>
2286
2287         Reviewed by Oliver
2288         
2289         <rdar://problem/5086888> - WebHistory(Item) Leak
2290         
2291         This is a pretty thourough touchup up style and correctness that
2292         plugs at least 1 definite leak and many potential leaks with
2293         extensive use of RetainPtr and COMPtr.
2294         
2295         This should result in no change in behavior
2296
2297         * MarshallingHelpers.cpp: Add kIUnknownDictionaryValueCallBacks
2298         * MarshallingHelpers.h: Ditto
2299         
2300         * WebHistory.cpp:
2301         (createUserInfoFromArray):
2302         (createUserInfoFromHistoryItem):
2303         (releaseUserInfo):
2304         (WebHistory::WebHistory):
2305         (WebHistory::~WebHistory):
2306         (WebHistory::loadFromURL):
2307         (createHistoryListFromStream): Split of the Structured Exception
2308           Handling to a seperate function to cooperate with C++
2309         (WebHistory::loadHistoryGutsFromURL):
2310         (WebHistory::saveToURL):
2311         (WebHistory::saveHistoryGuts):
2312         (WebHistory::datesArray):
2313         (WebHistory::addItems):
2314         (WebHistory::removeItems):
2315         (WebHistory::removeAllItems):
2316         (WebHistory::orderedLastVisitedDays):
2317         (WebHistory::orderedItemsLastVisitedOnDay):
2318         (WebHistory::removeItem):
2319         (WebHistory::addItem):
2320         (WebHistory::addItemForURL):
2321         (WebHistory::itemForURLString):
2322         (WebHistory::itemForURL):
2323         (WebHistory::containsItemForURLString):
2324         (WebHistory::removeItemForURLString):
2325         (WebHistory::addItemToDateCaches):
2326         (WebHistory::removeItemFromDateCaches):
2327         (WebHistory::findIndex):
2328         (WebHistory::insertItem):
2329         (WebHistory::ageLimitDate):
2330         * WebHistory.h:
2331         
2332         * WebHistoryItem.cpp:
2333         (WebHistoryItem::dictionaryRepresentation):
2334         (WebHistoryItem::mergeAutoCompleteHints):
2335
2336 2007-03-25  Adam Roben  <aroben@apple.com>
2337
2338         Reviewed by Oliver.
2339
2340         WebKit part of <rdar://problem/5086934> DumpRenderTree doesn't support
2341         layoutTestController.queueLoad
2342
2343         * WebFrame.cpp:
2344         (WebFrame::findFrameNamed): Implemented.
2345         * WebHistoryItem.cpp:
2346         (WebHistoryItem::children): Don't increment i twice per loop!
2347
2348 2007-03-25  Adam Roben  <aroben@apple.com>
2349
2350         Build fix.
2351
2352         * WebDownload.h: Include RetainPtr from WTF.
2353
2354 2007-03-24  Steve Falkenburg  <sfalken@apple.com>
2355
2356         Build fix.
2357
2358         * WebDownload.h: Remove WebCore namespace
2359
2360 2007-03-24  Adam Roben  <aroben@apple.com>
2361
2362         Reviewed by Oliver.
2363
2364         WebKit part of <rdar://problem/5086932> DumpRenderTree doesn't support
2365         layoutTestController.dumpBackForwardList
2366
2367         * Interfaces/IWebHistoryItemPrivate.idl: Added declarations.
2368         * WebFrame.cpp:
2369         (WebFrame::childFrames): Removed unused variable.
2370         * WebHistoryItem.cpp:
2371         (WebHistoryItem::target): Implemented.
2372         (WebHistoryItem::isTargetItem): Implemented.
2373         (WebHistoryItem::children): Implemented.
2374         * WebHistoryItem.h: Added declarations.
2375
2376 2007-03-23  Brady Eidson  <beidson@apple.com>
2377
2378         Reviewed by Adam
2379         
2380         <rdar://5086194> - WebHistory overreleases a CFNumber
2381         
2382         * WebHistory.cpp:
2383         (WebHistory::loadHistoryGutsFromURL): Don't CFRelease what we didn't 
2384           legitimately get a ref for!
2385
2386 2007-03-23  Adam Roben  <aroben@apple.com>
2387
2388         Reviewed by Darin.
2389
2390         WebKit part of <rdar://problem/5084881> Add a "turn of site-specific
2391         hacks" menu item to the Debug menu
2392
2393         Added new IWebPrivate::setAllowSiteSpecificHacks SPI.
2394
2395         * Interfaces/IWebViewPrivate.idl: Added declaration.
2396         * WebView.cpp:
2397         (WebView::userAgentForKURL): Only give a site-specific UA if
2398         site-specific hacks are turned on.
2399         (WebView::setAllowSiteSpecificHacks): Added.
2400         * WebView.h:
2401         (WebView::allowSiteSpecificHacks): Added.
2402
2403 2007-03-23  Beth Dakin  <bdakin@apple.com>
2404
2405         Reviewed by Hyatt.
2406
2407         Fix for <rdar://problem/5083914> Cursor is wrong for all context 
2408         menus
2409
2410         * WebView.cpp:
2411         (WebView::handleContextMenuEvent): Set the cursor to the pointer 
2412         cursor.
2413
2414 2007-03-23  Alice Liu  <alice.liu@apple.com>
2415
2416         Reviewed by Adam.
2417
2418         Fixed <rdar://5084888> need to add flickr to spoof list in Boomer WebKit
2419
2420         * WebView.cpp:
2421         (WebView::userAgentForKURL):
2422         added flickr spoof
2423
2424 2007-03-23  Adam Roben  <aroben@apple.com>
2425
2426         Reviewed by Oliver.
2427
2428         WebKit part of <rdar://problem/5085170> DumpRenderTree doesn't print
2429         frame scroll offsets
2430
2431         Implemented some WebFrame methods to support dumping frame scroll
2432         offsets in DRT.
2433
2434         * Interfaces/IWebFrame.idl: Changed signature of IWebFrame::childFrames.
2435         * Interfaces/IWebFramePrivate.idl: Added scrollOffset declaration.
2436         * WebFrame.cpp:
2437         (WebFrame::name): Implemented.
2438         (WebFrame::childFrames): Implemented.
2439         (WebFrame::scrollOffset): Implemented.
2440         * WebFrame.h: Updated/added declarations.
2441
2442 2007-03-23  Adam Roben  <aroben@apple.com>
2443
2444         Reviewed by Oliver.
2445
2446         WebKit part of fix for <rdar://problem/4990740>.
2447
2448         Added IWebDataSourcePrivate::mainDocumentError.
2449
2450         * Interfaces/IWebDataSource.idl: Added method declaration and updated
2451         copyrights.
2452         * WebDataSource.cpp:
2453         (WebDataSource::mainDocumentError): Implemented.
2454         * WebDataSource.h: Added declaration.
2455
2456 2007-03-23  Steve Falkenburg  <sfalken@apple.com>
2457
2458         Reviewed by Adam.
2459         
2460         <rdar://problem/5083645> Spoofed UA for gmail doesn't work - should be removed
2461
2462         * WebView.cpp:
2463         (WebView::userAgentForKURL): Remove gmail spoof
2464
2465 2007-03-22  Dave Hyatt  <hyatt@apple.com>
2466
2467         Fix for <rdar://problem/5083072>.
2468
2469         Reviewed by aroben
2470   
2471         * ChangeLog:
2472         * WebFrame.cpp:
2473         (WebFrame::setPrinting):
2474         (WebFrame::spoolPages):
2475         * WebFrame.h:
2476
2477 2007-03-22  Anders Carlsson  <acarlsson@apple.com>
2478
2479         Reviewed by Maciej.
2480
2481         <rdar://problem/5082270>
2482         Crash in windows media player at MTV.COM
2483         
2484         Ignore any WM_PAINT events we get while painting.
2485         
2486         * WebView.cpp:
2487         (WebView::WebView):
2488         (WebView::updateBackingStore):
2489         (WebView::paint):
2490         (WebViewWndProc):
2491         * WebView.h:
2492         (WebView::isPainting):
2493
2494 2007-03-22  Adele Peterson  <adele@apple.com>
2495
2496         Reviewed by Anders.
2497
2498         Fix for <rdar://problem/5071358> window.open won't work with empty urls (24fun test)
2499
2500         * Interfaces/IWebURLRequest.idl:
2501         * WebMutableURLRequest.cpp: (WebMutableURLRequest::isEmpty): Added. Checks whether the ResourceRequest is empty.  On the mac,
2502           NSURLRequests created from empty ResourceRequests are nil.  We may want to consider that in the future, but there were too
2503           many places in the app that expected the IWebURLRequest to be non-null.
2504         * WebMutableURLRequest.h:
2505
2506 2007-03-22  Dave Hyatt  <hyatt@apple.com>
2507
2508         Fix for crasher in layout caused by paints that happen without layout being current.  Change to be
2509         more like the Mac and crawl the frame tree up front ensuring everyone is up to date before painting.
2510
2511         Reviewed by olliej
2512
2513         * WebFrame.cpp:
2514         (WebFrame::WebFramePrivate::m_policyFunction):
2515         (WebFrame::layoutIfNeededRecursive):
2516         * WebFrame.h:
2517         * WebView.cpp:
2518         (WebView::updateBackingStore):
2519         (WebView::paint):
2520         (WebViewWndProc):
2521
2522 2007-03-22  Ada Chan  <adachan@apple.com>
2523
2524         Reviewed by Hyatt and Alice.
2525         
2526         Changed the mouse event processing in the WebView wndproc so we actually
2527         allow a mouse event with click count > 3, which matches the mac safari behavior.
2528         
2529         Set globalPrevButton and globalPrevPoint also in mouse down.
2530
2531         * WebView.cpp:
2532         (WebView::handleMouseEvent):
2533
2534 2007-03-21  Anders Carlsson  <acarlsson@apple.com>
2535
2536         Reviewed by Adam.
2537
2538         * WebView.cpp:
2539         (WebView::initWithFrame):
2540         Remove #ifdef now that DRT no longer crashes.
2541
2542 2007-03-21  Beth Dakin  <bdakin@apple.com>
2543
2544         Reviewed by Adam.
2545
2546         <rdar://problem/5074274> right-clicking in certain iframes ends up 
2547         left-clicking, and context menu appears far away
2548
2549         * WebView.cpp:
2550         (WebView::handleContextMenuEvent): We were always calling 
2551         sendContextMenuEvent() on the main frame!! Instead, call it on the 
2552         focused or main frame.
2553
2554 2007-03-21  Adele Peterson  <adele@apple.com>
2555
2556         Reviewed by Adam.
2557         
2558         Fix for <rdar://problem/5076213> fast/forms/input-text-enter.html fails
2559         
2560         Added updateActiveState SPI for DumpRenderTree.
2561
2562         * Interfaces/IWebViewPrivate.idl:
2563         * WebView.cpp:
2564         (WebViewWndProc): Added comments where we do similar work when the webview gets and loses focus.  We should merge this logic into updateActiveState eventually.
2565         (WebView::updateActiveState):
2566         * WebView.h:
2567
2568 2007-03-19  Maciej Stachowiak  <mjs@apple.com>
2569
2570         Reviewed by Geoff and Adam.
2571
2572         - <rdar://problem/4041141> JavaScriptCore is not thread-safe on Windows
2573
2574         * WebView.cpp:
2575         (WebView::WebView): Tell JavaScriptCore what the main thread is.
2576
2577 2007-03-20  Anders Carlsson  <acarlsson@apple.com>
2578
2579         Reviewed by Adam.
2580
2581         <rdar://problem/5050512>
2582         Need invalid/expired certificate alerts
2583         
2584         Add setAllowsAnyHTTPSCertificate method to IWebMutableURLRequest and have it 
2585         call down to WebCore.
2586         
2587         * Interfaces/IWebMutableURLRequest.idl:
2588         * WebMutableURLRequest.cpp:
2589         (WebMutableURLRequest::setAllowsAnyHTTPSCertificate):
2590         * WebMutableURLRequest.h:
2591
2592 2007-03-20  Adam Roben  <aroben@apple.com>
2593
2594         Rubberstamped by Anders.
2595
2596         Workaround a CFNetwork crash that affects DRT.
2597
2598         * WebView.cpp:
2599         (WebView::initWithFrame): Commented out cookie storage initialization.
2600
2601 2007-03-20  Adam Roben  <aroben@apple.com>
2602
2603         Build fix.
2604
2605         * WebView.cpp: Added missing #include.
2606
2607 2007-03-20  Adam Roben  <aroben@apple.com>
2608
2609         Reviewed by Oliver.
2610
2611         Implemented [set]TabKeyCyclesThroughElements.
2612
2613         * Interfaces/IWebViewPrivate.idl: Added new declarations.
2614         * WebView.cpp:
2615         (WebView::setTabKeyCyclesThroughElements): Implemented.
2616         (WebView::tabKeyCyclesThroughElements): Implemented.
2617         * WebView.h: Updated.
2618
2619 2007-03-20  Dave Hyatt  <hyatt@apple.com>
2620
2621         Land advanced text code path (turned off).
2622        
2623         Reviewed by aroben
2624
2625         * WebKit.vcproj/WebKit.vcproj:
2626
2627 2007-03-20  Anders Carlsson  <acarlsson@apple.com>
2628
2629         Reviewed by Adam.
2630
2631         <rdar://problem/4921198>
2632         Cookie acceptance policy not settable
2633         
2634         * WebView.cpp:
2635         (WebView::updateWebCoreSettingsFromPreferences):
2636         Update the cookie storage accept policy.
2637         
2638         (WebView::initWithFrame):
2639         Initialize the cookie storage.
2640
2641 2007-03-19  Adam Roben  <aroben@apple.com>
2642
2643         Build fix.
2644
2645         * WebKit.vcproj/WebKitGUID.vcproj:
2646
2647 2007-03-19  Adam Roben  <aroben@apple.com>
2648
2649         Reviewed by Anders and Darin.
2650
2651         Added WebJavaScriptCollector for <rdar://problems/5071653>.
2652
2653         * Interfaces/IWebJavaScriptCollector.idl: Added.
2654         * Interfaces/WebKit.idl:
2655         * WebJavaScriptCollector.cpp: Added.
2656         (WebJavaScriptCollector::WebJavaScriptCollector):
2657         (WebJavaScriptCollector::~WebJavaScriptCollector):
2658         (WebJavaScriptCollector::createInstance):
2659         (WebJavaScriptCollector::QueryInterface):
2660         (WebJavaScriptCollector::AddRef):
2661         (WebJavaScriptCollector::Release):
2662         (WebJavaScriptCollector::collect):
2663         (WebJavaScriptCollector::collectOnAlternateThread):
2664         (WebJavaScriptCollector::objectCount):
2665         * WebJavaScriptCollector.h: Added.
2666         * WebKit.vcproj/Interfaces.vcproj: Added IWebJavaScriptCollector.idl.
2667         * WebKit.vcproj/WebKit.vcproj: Added WebJavaScriptCollector.(cpp|h).
2668         * WebKit.vcproj/WebKitGUID.vcproj: Added IWebJavaScriptCollector_i.c.
2669         * WebKitClassFactory.cpp:
2670         (WebKitClassFactory::CreateInstance): Added cases for
2671         WebJavaScriptCollector.
2672         * WebKitDLL.cpp:
2673         (DllGetClassObject): Ditto.
2674
2675 2007-03-19  Adam Roben  <aroben@apple.com>
2676
2677         Build fix.
2678
2679         * Interfaces/IWebView.idl:
2680
2681 2007-03-18  Adam Roben  <aroben@apple.com>
2682
2683         Reviewed by Hyatt.
2684
2685         Implemented getting/setting of the editing delegate (we don't actually
2686         use it for anything yet, though. See <rdar://problem/5071598>).
2687
2688         * Interfaces/IWebEditingDelegate.idl: Renamed IWebViewEditingDelegate
2689         to IWebEditingDelegate to match our other delegates.
2690         * Interfaces/IWebView.idl: Updated for rename.
2691         * WebView.cpp:
2692         (WebView::setEditingDelegate): Implemented.
2693         (WebView::editingDelegate): Ditto.
2694         * WebView.h: Updated for rename.
2695
2696 2007-03-18  Adam Roben  <aroben@apple.com>
2697
2698         Reviewed by Geoff.
2699
2700         Added IWebFramePrivate::layout to support eventSender in DRT.
2701
2702         Made IWebView inherit from IDropTarget to match Mac, and added
2703         IWebUIDelegatePrivate::doDragDrop to support drag-and-drop in DRT.
2704
2705         * Interfaces/IWebFramePrivate.idl: Added layout().
2706         * Interfaces/IWebUIDelegatePrivate.idl: Added doDragDrop().
2707         * Interfaces/IWebView.idl: Added inheritance from IDropTarget.
2708         * WebDragClient.cpp:
2709         (WebDragClient::startDrag): Call the UI delegate if possible,
2710         otherwise fallback to OLE's DoDragDrop.
2711         * WebFrame.cpp:
2712         (WebFrame::layout): Implemented.
2713         * WebFrame.h:
2714         * WebView.h:
2715
2716 2007-03-17  Adam Roben  <aroben@apple.com>
2717
2718         Reviewed by Brady.
2719
2720         Fix repro ASSERT when logging in to facebook.com.
2721
2722         * WebMutableURLRequest.cpp:
2723         (WebMutableURLRequest::valueForHTTPHeaderField): Implemented.
2724
2725 2007-03-16  Brady Eidson  <beidson@apple.com>
2726
2727         Reviewed by Oliver
2728
2729         Make the WebDownload fix a little more correct.
2730         
2731         * WebDownload.cpp:
2732         (WebDownload::init): Release the connection from the ResourceHandle after the CFURLDownload has been created
2733
2734 2007-03-16  Geoffrey Garen  <ggaren@apple.com>
2735
2736         Reviewed by Dave Hyatt.
2737         
2738         Fixed "called Frame::paint with nil renderer" console messages.
2739         You can now launch and exit the app without seeing any
2740         error messages!
2741
2742         * WebView.cpp:
2743         (WebView::paintIntoBackingStore): Only tell the FrameView to
2744         paint if it has a renderer. This isn't an issue on the Mac
2745         because we don't create a FrameView until you load a page.
2746
2747 2007-03-16  Anders Carlsson  <acarlsson@apple.com>
2748
2749         Reviewed by Adam.
2750
2751         Add setters and getters for cookie storage accept policy.
2752         
2753         * Interfaces/IWebPreferences.idl:
2754         * WebPreferenceKeysPrivate.h:
2755         * WebPreferences.cpp:
2756         (WebPreferences::initialize):
2757         (WebPreferences::cookieStorageAcceptPolicy):
2758         (WebPreferences::setCookieStorageAcceptPolicy):
2759         * WebPreferences.h:
2760
2761 2007-03-16  Anders Carlsson  <acarlsson@apple.com>
2762
2763         Reviewed by Adam and Dave Hyatt.
2764
2765         <rdar://problem/5069226>
2766         Boomer fails Acid2.
2767         
2768         Fix acid2 test.
2769         
2770         * WebFrame.cpp:
2771         (WebFrame::shouldFallBack):
2772         Implement this function.
2773
2774 2007-03-16  Ada Chan  <adachan@apple.com>
2775
2776         Reviewed by Steve.
2777         
2778         Implemented a couple of DOM methods so we can set the font-size of an element directly in the app.
2779
2780         * DOMCSSClasses.cpp:
2781         (DOMCSSStyleDeclaration::setProperty):
2782         * DOMCoreClasses.cpp:
2783         (DOMElement::style):
2784
2785 2007-03-15  Alice Liu  <alice.liu@apple.com>
2786
2787         Reviewed by Ada.
2788
2789         Fixing some leaks
2790
2791         * WebFrame.cpp:
2792         (WebFrame::dispatchDidReceiveAuthenticationChallenge):
2793         (WebFrame::dispatchDidCancelAuthenticationChallenge):
2794
2795 2007-03-15  Brady Eidson  <beidson@apple.com>
2796
2797         Reviewed by Oliver
2798
2799         CFNetwork related cleanup that was a work around for previous deficiencies in CFURLDownload
2800         This might fix some of the random crashers we see on stress testing if they end up 
2801         downloading links.
2802
2803         * WebDownload.cpp:
2804         (WebDownload::init): Release the connection from the handle so it no longer refers to it
2805         
2806 2007-03-15  Maciej Stachowiak  <mjs@apple.com>
2807
2808         Reviewed by Geoff and Steve.
2809         
2810         - fixed <rdar://problem/5029776> iBench JavaScript test slower than Opera
2811         - fixes to use FastMalloc on Windows
2812
2813         * WebKit.vcproj/WebKit.def: Add exports of WTF symbols.
2814         * WebKit.vcproj/WebKit_debug.def: ditto
2815         * WebKit.vcproj/WebKit.vcproj: Link pthreads, now needed by WTF.
2816
2817 2007-03-15  Brady Eidson  <beidson@apple.com>
2818
2819         Reviewed by Alice
2820         
2821         Due to OpenSource r20178, all of the sudden we were trying to handle page caching on Windows
2822         even though it is not hooked up yet.  The resulted in very particular cases ending up calling 
2823         clear() in FrameLoader::provisionalLoadStarted().  One such particular case was if a page *would*
2824         be "cachable" (no frames, no passwords, etc etc), and you start a download from that page.
2825         
2826         The fix for now is to manually set the pageCacheSize to 0 whenever we create new pages on Windows.
2827         This prevents the "Should I cache this page?" checking from getting far enough to clear the document.
2828         It so happens this involves exactly one line.
2829         
2830         * WebView.cpp:
2831         (WebView::initWithFrame): Set page cache size to zero on new pages, and add a fixme to remove later
2832
2833 2007-03-15  Brady Eidson  <beidson@apple.com>
2834
2835         Reviewed by Maciej
2836
2837         <rdar://problem/4429701>
2838         Implements a port blocking black list that matches Firefox's
2839         
2840         * Interfaces/IWebError.idl: Add the custom error code for blocked error
2841
2842         * WebFrame.cpp:
2843         (WebFrame::blockedError): FrameLoaderClient fill-in + a Fixme
2844         (WebFrame::interruptForPolicyChangeError): Add a Fixme for localization
2845         * WebFrame.h:
2846
2847 2007-03-15  Adam Roben  <aroben@apple.com>
2848
2849         Rubberstamped by Brady.
2850
2851         * WebKitLogging.cpp: Turn of Download logging by default.
2852
2853 2007-03-14  Ada Chan  <adachan@apple.com>
2854
2855         Reviewed by Lou.
2856
2857         Added a method in IWebViewPrivate to clear the current focus node.  This is called in the app
2858         when focus has been transferred to the address field or search field.
2859
2860         * Interfaces/IWebViewPrivate.idl:
2861         * WebView.cpp:
2862         (WebView::clearFocusNode):
2863         * WebView.h:
2864
2865 2007-03-14  Adele Peterson  <adele@apple.com>
2866
2867         Reviewed by Ada.
2868
2869         Allow empty commands to be sent by doTextFieldCommandFromEvent.  Our autocomplete code relies on this.
2870
2871         * WebEditorClient.cpp: (WebEditorClient::doTextFieldCommandFromEvent):
2872
2873 2007-03-14  Steve Falkenburg  <sfalken@apple.com>
2874
2875         <rdar://problem/5050470> Reproducible crash doing find on page at cnn.com
2876         
2877         Add frame->document() null checks in cases where frame could be a
2878         sub-frame that hasn't started loading yet.
2879
2880         * WebView.cpp:
2881         (WebView::rectsForTextMatches): Add null check
2882
2883 2007-03-14  Adele Peterson  <adele@apple.com>
2884
2885         Reviewed by Darin.
2886
2887         WebKit part of fix for <rdar://problem/5057371> REGRESSION: Shift-selection stopped working in text fields
2888
2889         This fixes doCommandBySelector to take a command string instead of a key code.
2890
2891         * Interfaces/IWebEditingDelegate.idl: Changed parameter to BSTR.
2892         * Interfaces/IWebFormDelegate.idl: ditto.
2893         * WebEditorClient.cpp:
2894         (WebEditorClient::doTextFieldCommandFromEvent): Calls doCommandBySelector with a BString that it gets from interpretKeyEvent instead of a key code.
2895         (WebEditorClient::textWillBeDeletedInTextField): Calls doCommandBySelector with a BString to represent the BackwardDelete command.
2896         (WebEditorClient::handleKeypress): Calls handleEditingKeyboardEvent with just the KeyboardEvent.
2897         * WebView.cpp: Added commands that will be used by doCommandBySelector to the table (Cancel, InsertTab, InsertBacktab, InsertNewline).
2898         (WebView::interpretKeyEvent): Added. Returns a command string for a KeyboardEvent. Removed static editCommandForKey.
2899         (WebView::handleEditingKeyboardEvent): Call Editor methods instead of calling handleTextInputEvent directly.
2900         * WebView.h:
2901
2902 2007-03-14  Administrator  <acarlsson@apple.com>
2903
2904         Build fixes.
2905         
2906         * WebDataSource.cpp:
2907         (WebDataSource::subresourceForURL):
2908         * WebKitDLL.cpp:
2909         (loadResourceIntoBuffer):
2910
2911 2007-03-12  Adele Peterson  <adele@apple.com>
2912
2913         Reviewed by Oliver.
2914
2915         WebKit part of fix for <rdar://problem/5044790> preventing default of keypress event doesn't work (affects .mac)
2916
2917         Removed special handling of the WM_CHAR message.  All this work is now done by WM_KEYDOWN, which will dispatch the keydown event, 
2918         which causes the keypress event to be dispatched, which calls WebEditorClient::handleKeyPress to do all the hard work.
2919         
2920         * WebEditorClient.cpp: (WebEditorClient::handleKeypress): Removed special call to doTextFieldCommandFromEvent since this will now 
2921         happen during normal key event processing. Call handleEditingKeyboardEvent.  Now editing actions can be prevented from the keypress event handler.
2922         * WebView.cpp:
2923         (WebView::WebView): Added m_currentCharacterCode, so we can reuse the computed code from keyDown for keyUp events.
2924         (WebView::keyUp): Renamed arguments.  Don't dispatch event for shift, ctrl, or capslock keys. Use m_currentCharacterCode when constructing the PlatformKeyboardEvent.
2925         (WebView::handleEditingKeyboardEvent): Now takes a KeyboardEvent instead of a PlatformKeyboardEvent.  If no editCommand is created
2926          from the event, then call handleTextInputEvent.
2927         (WebView::keyDown): Peek at the next message in the message loop.  If its a WM_CHAR, then get the character code and remove that message from the queue.
2928          Renamed arguments.  Don't dispatch event for shift, ctrl, or capslock keys. Set m_currentCharacterCode and use it when constructing the PlatformKeyboardEvent.
2929         (WebViewWndProc):  Removed handling of WM_CHAR, since this is now done from WM_KEYDOWN by dispatching the keydown event, which will eventually call handleKeyPress.
2930         * WebView.h: Made handleEditingKeyboardEvent public so it can be accessed from WebEditorClient.
2931
2932 2007-03-11  Oliver Hunt  <oliver@apple.com>
2933
2934         Reviewed by Adele.
2935
2936         Stubbed WebEditorClient::respondToChangedSelection
2937
2938         * WebEditorClient.cpp:
2939         (WebEditorClient::respondToChangedSelection):
2940         * WebEditorClient.h:
2941
2942 2007-03-10  Anders Carlsson <acarlsson@apple.com>
2943
2944         Reviewed by Adam.
2945
2946         * DOMCoreClasses.cpp:
2947         (DOMNode::textContent):
2948         Implement this.
2949
2950 2007-03-09  Anders Carlsson <acarlsson@apple.com>
2951
2952         Reviewed by Adam.
2953
2954         * WebURLResponse.cpp:
2955         (WebURLResponse::suggestedFilename):
2956         Get the suggested filename from the ResourceResponse object.
2957
2958 2007-03-09  Adam Roben  <aroben@apple.com>
2959
2960         Rubberstamped by Steve.
2961
2962         B&I build fix.
2963
2964         * WebKit.vcproj/WebKit.vcproj: Removed all references to iconv.
2965
2966 2007-03-08  Anders Carlsson <acarlsson@apple.com>
2967
2968         Build fix.
2969         
2970         * WebView.cpp:
2971         (WebView::isLoading):
2972
2973 2007-03-08  Anders Carlsson <acarlsson@apple.com>
2974
2975         Reviewed by Adam.
2976
2977         Implement WebView::isLoading.
2978         
2979         * WebView.cpp:
2980         (WebView::isLoading):
2981
2982 2007-03-07  Adam Roben  <aroben@apple.com>
2983
2984         Rubberstamped by Anders.
2985
2986         Return E_POINTER for null parameters.
2987
2988         * WebScrollBar.cpp:
2989         (WebScrollBar::value):
2990         (WebScrollBar::capturingMouse):
2991         (WebScrollBar::frameGeometry):
2992         (WebScrollBar::width):
2993         (WebScrollBar::height):
2994         (WebScrollBar::requestedWidth):
2995         (WebScrollBar::requestedHeight):
2996         (WebScrollBar::windowClipRect):
2997
2998 2007-03-07  Adam Roben  <aroben@apple.com>
2999
3000         Reviewed by Oliver.
3001
3002         Added requestedWidth and requestedHeight methods to WebScrollBar.
3003
3004         * Interfaces/IWebScrollBarPrivate.idl: Added new declarations.
3005         * WebScrollBar.cpp:
3006         (WebScrollBar::requestedWidth): Implemented.
3007         (WebScrollBar::requestedHeight): Implemented.
3008         * WebScrollBar.h: Added method declarations.
3009
3010 2007-03-07  Adam Roben  <aroben@apple.com>
3011
3012         Rubberstamped by Anders.
3013
3014         * WebFrame.cpp:
3015         (WebFrame::cancelledError): Use the WebURLErrorDomain constant.
3016         (WebFrame::interruptForPolicyChangeError): Use the WebKitErrorDomain constant.
3017
3018 2007-03-07  Adam Roben  <aroben@apple.com>
3019
3020         Rubberstamped by Anders.
3021
3022         Switch the definition of WebURLErrorDomain to "CFURLErrorDomain" so
3023         that we will send the right errors once <rdar://problem/5034136> is
3024         fixed.
3025
3026         * Interfaces/IWebError.idl: Changed definition.
3027
3028 2007-03-07  Adele Peterson  <adele@apple.com>
3029
3030         Build fix.
3031
3032         * WebEditorClient.cpp: (WebEditorClient::handleInputMethodKeypress):
3033
3034 2007-03-07  Adele Peterson  <adele@apple.com>
3035
3036         Reviewed by Darin.
3037
3038         WebKitWin part of fix for:
3039         http://bugs.webkit.org/show_bug.cgi?id=10871
3040         http://bugs.webkit.org/show_bug.cgi?id=12677
3041         <rdar://problem/4823129> REGRESSION: IME key events different in nightly
3042         <rdar://problem/4759563> REGRESSION: Return key is always sent when you confirm a clause in kotoeri
3043
3044         * WebEditorClient.cpp:
3045         (WebEditorClient::handleKeypress): Changed handleKeyPress to handleKeypress.
3046         (WebEditorClient::handleInputMethodKeypress): Added.
3047         * WebEditorClient.h:
3048
3049 2007-03-07  Anders Carlsson  <acarlsson@apple.com>
3050
3051         Reviewed by Adam.
3052
3053         * WebFrame.cpp:
3054         (WebFrame::makeDocumentView):
3055         Assert that frame is not null.
3056
3057 2007-03-06  Anders Carlsson  <acarlsson@apple.com>
3058
3059         Reviewed by Adam.
3060
3061         * WebFrame.cpp:
3062         (WebFrame::makeDocumentView):
3063         Call resetMultipleFormSubmissionProtection() so that submitting the same form from separate loads works.
3064
3065 2007-03-06  Brady Eidson  <beidson@apple.com>
3066
3067         Reviewed by Adam
3068
3069         Adapt to an API change in CFURLDownload
3070         
3071         * WebDownload.cpp:
3072         (WebDownload::init):
3073
3074 2007-03-06  Steve Falkenburg  <sfalken@apple.com>
3075
3076         Rubber-stamped by Adam.
3077         
3078         Fix disney.com more.  Disney redirects to disney.go.com.
3079
3080         * WebView.cpp:
3081         (WebView::userAgentForKURL): Added disney.go.com
3082
3083 2007-03-06  Adam Roben  <aroben@apple.com>
3084
3085         Reviewed by Anders.
3086
3087         Always keep rounding hacks on to be consistent.
3088
3089         * WebDragClient.cpp:
3090         (createDragImageForLink): Tell StringTruncator to keep rounding hacks on.
3091         * WebKitGraphics.cpp:
3092         (CenterTruncateStringToWidth): Ditto.
3093         (RightTruncateStringToWidth): Ditto.
3094
3095 2007-03-06  Steve Falkenburg  <sfalken@apple.com>
3096
3097         Reviewed by Adam.
3098         
3099         Allow custom user agents per site.
3100         
3101         This fixes:
3102         
3103         http://www.disney.com
3104         http://www.yahoo.com
3105         http://mail.google.com
3106         iTunes store links (w/ latest unsubmitted CFNetwork from our root share)
3107
3108         * WebView.cpp:
3109         (WebView::userAgentForKURL): Check URL host against a list of known offenders, return them what they're looking for.
3110
3111 2007-03-06  Anders Carlsson  <acarlsson@apple.com>
3112
3113         Reviewed by Adam.
3114         
3115         Pass the user agent on.
3116         
3117         * WebFrame.cpp:
3118         (WebFrame::userAgent):
3119         * WebFrame.h:
3120
3121 2007-03-04  Adam Roben  <aroben@apple.com>
3122
3123         Reviewed by Steve.
3124
3125         Added line spacing querying to FontMetrics to support line wrapping.
3126
3127         * WebKitGraphics.cpp:
3128         (FontMetrics): Return the line spacing.
3129         * WebKitGraphics.h: Added lineSpacing parameter.
3130
3131 2007-03-02  Adam Roben  <aroben@apple.com>
3132
3133         Reviewed by Beth.
3134
3135         Make submenus draw using the UIDelegate.
3136
3137         * Interfaces/IWebUIDelegate.idl: Added new delegate method to add
3138         custom drawing data for menus.
3139         * WebView.cpp:
3140         (WebView::onInitMenuPopup): Added. Calls new delegate method.
3141         (WebViewWndProc): Added handler for WM_INITMENUPOPUP, which is called
3142         for all submenus.
3143         * WebView.h: Added declaration.
3144
3145 2007-03-02  Adam Roben  <aroben@apple.com>
3146
3147         Reviewed by Anders.
3148
3149         Added optional underlining of a single character to WebKitGraphics.
3150
3151         * WebKitGraphics.cpp:
3152         (DrawTextAtPoint): Passed optional underlinedIndex parameter to
3153         WebCoreTextRenderer.
3154         * WebKitGraphics.h: Added optional underlinedIndex parameter.
3155
3156 2007-03-01  Adam Roben  <aroben@apple.com>
3157
3158         Reviewed by Kevin M.
3159
3160         Add support for right-truncation to WebKitGraphics.
3161
3162         * WebKit.vcproj/WebKit.def: Added new export.
3163         * WebKit.vcproj/WebKit_debug.def: Ditto.
3164         * WebKitGraphics.cpp:
3165         (RightTruncateStringToWidth): Added.
3166         * WebKitGraphics.h: Added declaration.
3167
3168 2007-02-28  Adam Roben  <aroben@apple.com>
3169
3170         Reviewed by Anders.
3171
3172         Made WebKitGraphics more flexible.
3173
3174         * WebDragClient.cpp:
3175         (WebDragClient::createDragImageForLink): Updated for changes to
3176         WebKitGraphics/WebCoreTextRenderer.
3177         * WebKit.vcproj/WebKit.def: Added new exported methods.
3178         * WebKit.vcproj/WebKit_debug.def: Ditto.
3179         * WebKitGraphics.cpp:
3180         (makeFont): Added.
3181         (DrawTextAtPoint): Simplified arguments, changed to take a
3182         CGContextRef, and updated for WebCoreTextRenderer changes.
3183         (TextFloatWidth): Added.
3184         (FontMetrics): Added.
3185         (CenterTruncateStringToWidth): Added.
3186         * WebKitGraphics.h: Updated declarations.
3187
3188 2007-02-28  Steve Falkenburg  <sfalken@apple.com>
3189
3190         Fix build (for new SDK) / Break build (for old SDK)
3191
3192         * WebDownload.cpp:
3193         (WebDownload::initToResumeWithBundle):
3194
3195 2007-02-27  Ada Chan  <adachan@apple.com>
3196
3197         Reviewed by Steve and Adam.
3198         
3199         WebKitWin changes to get the aqua scrollbar into the app.
3200
3201         * Interfaces/IWebScrollBarDelegatePrivate.idl: Added.
3202         COM interface for the WebKit scrollbar
3203         * Interfaces/IWebScrollBarPrivate.idl: Added.
3204         COM interface that allows the WebKit scrollbar to update the client.
3205         * Interfaces/WebKit.idl:
3206         * WebKit.vcproj/Interfaces.vcproj:
3207         * WebKit.vcproj/WebKit.vcproj:
3208         * WebKit.vcproj/WebKitGUID.vcproj:
3209         * WebKitClassFactory.cpp:
3210         (WebKitClassFactory::CreateInstance):
3211         Added changes needed to create the WebKitScrollBar through COM
3212         * WebKitDLL.cpp:
3213         (DllGetClassObject):
3214         * WebScrollBar.cpp: Added.
3215         WebKitScrollBar wraps the WebCore's PlatformScrollbar.  This allows the app to
3216         make its own scroll bar that's the same aqua scrollbar in the engine.
3217         (WebScrollBar::WebScrollBar):
3218         (WebScrollBar::~WebScrollBar):
3219         (WebScrollBar::createInstance):
3220         (WebScrollBar::QueryInterface):
3221         (WebScrollBar::AddRef):
3222         (WebScrollBar::Release):
3223         (WebScrollBar::init): instantiate PlatformScrollbar.
3224         (WebScrollBar::setEnabled): call through to PlatformScrollbar
3225         (WebScrollBar::setSteps): ditto
3226         (WebScrollBar::setProportion): ditto
3227         (WebScrollBar::setRect): ditto
3228         (WebScrollBar::setValue): ditto
3229         (WebScrollBar::value): ditto
3230         (WebScrollBar::capturingMouse): ditto
3231         (WebScrollBar::paint): ditto
3232         (WebScrollBar::frameGeometry): ditto
3233         (WebScrollBar::width): ditto
3234         (WebScrollBar::height): ditto
3235         (WebScrollBar::handleMouseEvent): ditto
3236         (WebScrollBar::scroll): ditto
3237         (WebScrollBar::valueChanged): call valueChanged on the delegate
3238         (WebScrollBar::windowClipRect): get the rect from the scrollbar's containing window
3239         * WebScrollBar.h: Added.
3240
3241 2007-02-27  Alice Liu  <alice.liu@apple.com>
3242
3243         Reviewed by Steve, Adam, Maciej, and their mothers.
3244
3245         This is a general leaks fix but helps the effort towards fixing
3246         <rdar://4974495> Boomer leaks while running HTML iBench
3247         However, this fix doens't close that bug. 
3248
3249         * WebFrame.cpp:
3250         (WebFrame::setTitle):
3251             fix a leak of WebHistory
3252         * WebHistory.cpp:
3253         (_WebCoreHistoryProvider::containsItemForURLUnicode):
3254             fix a leak of WebHistory
3255
3256 2007-02-27  Adam Roben  <aroben@apple.com>
3257
3258         Reviewed by Anders.
3259
3260         Fix <rdar://problem/5004615> View source menu option is always disabled
3261         when Netscape 8 is installed
3262
3263         The bug was caused by Netscape's npTrident.dll plugin, which registers
3264         itself as a handler for text/html and text/xml.
3265
3266         * WebFrame.cpp:
3267         (WebFrame::canProvideDocumentSource): Explicitly allow viewing the
3268         source of HTML and XML documents, rather than disallowing text, image,
3269         and plugin documents. Plugins can register themselves as handlers for
3270         HTML and XML MIME types, but we still want to display source in those
3271         cases.
3272
3273 2007-02-27  Beth Dakin  <bdakin@apple.com>
3274
3275         Reviewed by Adam.
3276
3277         Make msimg32.lib available to the engine so that we can use 
3278         AlphaBlend.
3279
3280         * WebKit.vcproj/WebKit.vcproj:
3281
3282 2007-02-27  Ada Chan  <adachan@apple.com>
3283
3284         Fixed build.
3285
3286         * WebFrame.cpp:
3287
3288 2007-02-27  Oliver Hunt  <oliver@apple.com>
3289
3290         Reviewed by Lou and Steve.
3291         
3292         Handle the WM_CURSOR message to stop cursor flickering
3293         to fix <rdar://problem/4788352>
3294
3295         * WebView.cpp:
3296         (WebViewWndProc):
3297
3298 2007-02-27  Ada Chan  <adachan@apple.com>
3299
3300         Reviewed by Steve and Anders.
3301
3302         <rdar://4983106> Stop/reload button never changes back to
3303         reload when a click on a link spawns a download
3304
3305         * WebError.cpp:
3306         (WebError::isPolicyChangeError): fixed string comparison
3307         * WebFrame.cpp:
3308         (WebFrame::interruptForPolicyChangeError): implemented the method
3309
3310 2007-02-26  Adam Roben  <aroben@apple.com>
3311
3312         Reviewed by Adele.
3313
3314         Stop bizarre crashes from happening on startup.
3315
3316         * WebKit.vcproj/WebKit.vcproj: Use new ENABLE_* macros instead of *_SUPPORT.
3317
3318 2007-02-24  Steve Falkenburg  <sfalken@apple.com>
3319
3320         Pre-emptive build fix.
3321         Removed CGPThreads DLL copy
3322
3323         * WebKit.vcproj/WebKit.vcproj:
3324
3325 2007-02-22  Adele Peterson  <adele@apple.com>
3326
3327         Updating this file to match WebCore.
3328
3329         * WebKit.vcproj/textAreaResizeCorner.png:
3330
3331 2007-02-22  Beth Dakin  <bdakin@apple.com>
3332
3333         Reviewed by Adam.
3334
3335         Fix for http://bugs.webkit.org/show_bug.cgi?id=12399 REGRESSION: 
3336         Unable to prevent default context menu from appearing. <rdar://
3337         problem/5017416>
3338
3339         * WebView.cpp:
3340         (WebView::handleContextMenuEvent): Clear the controller's context 
3341         menu before propagating a new context menu event through the DOM.
3342
3343 2007-02-22  Oliver Hunt  <oliver@apple.com>
3344
3345         Reviewed by Ada, Lou, and Steve.
3346
3347         Last of the major changes for drag and drop
3348         - Move COMPtr.h to WebCore
3349         - Added WebDragSource, a modified version of SDataSource from the App
3350           that can notify a WebView's eventhandler of drag events
3351         - Implement the last bits of the DragClient
3352         - As part of drag client added code to draw the "doubled" text used by
3353           drag links.  May be useful for other parts of WebKit/App
3354         
3355         * COMPtr.h: Removed.
3356           Moving to WebCore
3357         * WebDragClient.cpp:
3358         (WebDragClient::actionMaskForDrag):
3359         (WebDragClient::willPerformDragDestinationAction):
3360         (WebDragClient::dragSourceActionMaskForPoint):
3361         (WebDragClient::willPerformDragSourceAction):
3362           Removing WebCore:: as i'm now using the WebCore namespace
3363         (WebDragClient::startDrag):
3364           Implemented client method
3365         (allocImage):
3366         (dragLabelFont):
3367           Helper functions for generating the link dragging image
3368         (WebDragClient::createDragImageForLink):
3369           Implemented client method
3370           
3371         * WebDropSource.cpp: Added.
3372         (WebDropSource::createInstance):
3373         (WebDropSource::WebDropSource):
3374         (WebDropSource::QueryInterface):
3375         (WebDropSource::AddRef):
3376         (WebDropSource::Release):
3377         (generateMouseEvent):
3378           Generates a mouse event for the EventHandler
3379         (WebDropSource::QueryContinueDrag):
3380         (WebDropSource::GiveFeedback):
3381           Copied from SDataObject in the App.  Minor changes per suggestions
3382           from Ada and Steve (error codes, potential leaks)
3383           Also includes logic to notify the source WebView of drag events (moving 
3384           and drag end)
3385           
3386         * WebDropSource.h: Added.
3387           Header for the above
3388           
3389         * WebKit.vcproj/WebKit.vcproj:
3390           Removing COMPtr.h, and adding WebDropSource.{h,cpp}
3391           
3392         * WebKitGraphics.cpp:
3393         (DrawDoubledTextAtPoint):
3394           Utility function for drawing double text, as used by link dragging image
3395           
3396         * WebKitGraphics.h:
3397           Defining the above function
3398
3399 2007-02-21  Brady Eidson  <beidson@apple.com>
3400
3401         Reviewed by the build-fix fairies
3402
3403         * WebDownload.cpp:
3404         (WebDownload::initToResumeWithBundle): Conditionally use CFURLDownload API for the resume case.
3405          I totally made up the flag
3406
3407 2007-02-21  Brady Eidson  <beidson@apple.com>
3408
3409         Reviewed by Anders' rubberstamp
3410         
3411         * WebDownload.cpp:
3412         (WebDownload::initToResumeWithBundle): Make a copy of the string we truncate
3413          so it doesn't affect the original
3414
3415 2007-02-21  Brady Eidson  <beidson@apple.com>
3416
3417         Reviewed by Adam
3418
3419         <rdar://problem/4964763> - Hookup resume downloads on the engine side
3420         
3421         NOTE: Resume downloads are broken in the current ChickenCat - this functionality requires 
3422         a custom ToT CFNetwork as of CFNetwork r3372, or will require CFNetwork 172 or later
3423         
3424         * WebDownload.cpp:
3425         (WebDownload::initWithRequest): Changed some logging, plugged some potential leaks
3426         (WebDownload::initToResumeWithBundle): Added a real implementation - this now works!
3427         (WebDownload::didFinish): Added some logging and fixed up some lifetime issues
3428         (extractResumeDataFromBundle): Renamed to imply the modification of the file.  Truncate
3429           the resume data from the file once it is extracted
3430
3431 2007-02-20  Beth Dakin  <bdakin@apple.com>
3432
3433         Reviewed by Maciej.
3434
3435         Move copyImage functionality from the ContextMenuClient to the 
3436         Pasteboard.
3437
3438         * WebContextMenuClient.cpp:
3439         * WebContextMenuClient.h:
3440
3441 2007-02-20  Adam Roben  <aroben@apple.com>
3442
3443         Reviewed by Darin and Anders.
3444
3445         Fix <rdar://problem/5003318> App: Status bar text is more difficult to
3446         read than Mac OS X Safari
3447
3448         * WebKitGraphics.cpp:
3449         (DrawTextAtPoint): Added bottomAlign and centerTruncate parameters.
3450         * WebKitGraphics.h: Ditto.
3451
3452 2007-02-20  Darin Adler  <darin@apple.com>
3453
3454         Reviewed by Anders.
3455
3456         * WebFrame.cpp: (WebFrame::redirectDataToPlugin): Update for changes to
3457         FrameLoader and DocumentLoader.
3458
3459 2007-02-19  Adam Roben  <aroben@apple.com>
3460
3461         Reviewed by Darin.
3462
3463         Fix <rdar://problem/5007566> Crash in WebFrame::dataSource on dni.ru
3464
3465         The fix for the bug was to zero out WebFrame's Frame pointer in
3466         WebFrame::frameLoaderDestroyed, and then to null-check or ASSERT
3467         non-null as appropriate. All IWebFrame methods that depend on the Frame
3468         pointer will return E_FAIL if it is null, and everywhere within
3469         WebFrame that wasn't null-checking before will now explicitly ASSERT.
3470
3471         I also changed all uses of d->frame and WebFrame::impl() to use the
3472         core() function for consistency, and so that there is only one code
3473         path for getting from a WebFrame to a Frame.
3474
3475         Additional more specific comments below.
3476
3477         * WebChromeClient.cpp:
3478         (WebChromeClient::scrollBackingStore):
3479         (WebChromeClient::updateBackingStore):
3480         * WebFrame.cpp:
3481         (kit): Null-check the frame parameter.
3482         (core): Added two overloads of this.
3483         (WebFrame::DOMDocument): Added argument checking.
3484         (WebFrame::currentForm):
3485         (WebFrame::loadRequest):
3486         (WebFrame::loadData):
3487         (WebFrame::dataSource): Added argument checking, and return E_FAIL if the dataSource is null.
3488         (WebFrame::provisionalDataSource): Ditto.
3489         (WebFrame::stopLoading):
3490         (WebFrame::reload):
3491         (WebFrame::parentFrame):
3492         (WebFrame::renderTreeAsExternalRepresentation): Added argument checking.
3493         (WebFrame::firstLayoutDone): Ditto.
3494         (WebFrame::loadType): Ditto.
3495         (WebFrame::invalidate):
3496         (WebFrame::setTextSizeMultiplier):
3497         (WebFrame::inViewSourceMode): Added argument checking, and changed to return an HRESULT.
3498         (WebFrame::setInViewSourceMode): Changed to return an HRESULT.
3499         (WebFrame::searchForLabelsBeforeElement): Added argument checking.
3500         (WebFrame::matchLabelsAgainstElement): Ditto.
3501         (WebFrame::frameLoaderDestroyed): Zero out the Frame pointer because the Frame is being destroyed.
3502         (WebFrame::createFrame):
3503         (WebFrame::loadURLIntoChild): Added some assertions.
3504         (WebFrame::dispatchWillSubmitForm):
3505         (WebFrame::frameLoadCompleted):
3506         (WebFrame::receivedData):
3507         (WebFrame::setUpPolicyListener):
3508         (WebFrame::receivedPolicyDecision):
3509         (WebFrame::dispatchDecidePolicyForMIMEType):
3510         (WebFrame::dispatchDecidePolicyForNewWindowAction):
3511         (WebFrame::dispatchDecidePolicyForNavigationAction):
3512         (WebFrame::dispatchCreatePage):
3513         (WebFrame::createPlugin):
3514         (WebFrame::redirectDataToPlugin):
3515         (WebFrame::createJavaAppletWidget):
3516         (WebFrame::windowObjectCleared):
3517         (WebFrame::setPrinting):
3518         (WebFrame::setInPrintingMode):
3519         (WebFrame::computePageRects):
3520         (WebFrame::getPrintedPageCount): Zero out the out parameter before proceeding.
3521         (WebFrame::spoolPages):
3522         (WebFrame::forceLayoutWithPageWidthRange):
3523         * WebFrame.h:
3524         * WebView.cpp:
3525         (WebView::paint): Silently fail on a null Frame, because this method could be called at any time.
3526         (WebView::mouseWheel): Ditto.
3527         (WebViewWndProc): Ditto.
3528         (WebView::inViewSourceMode): Return whatever WebFrame::setInViewSourceMode returns.
3529         (WebView::setInViewSourceMode): Ditto.
3530         (WebView::setCustomTextEncodingName): Replaced check for a null
3531         FrameLoader with a check for a null Frame, which is equivalent but, as
3532         a bonus, won't crash.
3533         (WebView::stringByEvaluatingJavaScriptFromString):
3534         (WebView::elementAtPoint): Added argument checking.
3535         (WebView::selectedText): Ditto.
3536         (WebView::centerSelectionInVisibleArea):
3537
3538 2007-02-19  Adam Roben  <aroben@apple.com>
3539
3540         Build fix.
3541
3542         * WebFrame.cpp:
3543         (WebFrame::computePageRects):
3544
3545 2007-02-18  Maciej Stachowiak  <mjs@apple.com>
3546
3547         Reviewed by Oliver.
3548
3549         - Adapt for Lars's patch to clean up Frame
3550
3551         * WebChromeClient.cpp:
3552         (WebChromeClient::tabsToLinks):
3553         (WebChromeClient::windowResizerRect):
3554         (WebChromeClient::addToDirtyRegion):
3555         (WebChromeClient::scrollBackingStore):
3556         (WebChromeClient::updateBackingStore):
3557         * WebChromeClient.h:
3558         * WebEditorClient.cpp:
3559         (WebEditorClient::shouldChangeSelectedRange):
3560         (WebEditorClient::textFieldDidBeginEditing):
3561         (WebEditorClient::textFieldDidEndEditing):
3562         (WebEditorClient::textDidChangeInTextField):
3563         (WebEditorClient::doTextFieldCommandFromEvent):
3564         (WebEditorClient::textWillBeDeletedInTextField):
3565         (WebEditorClient::textDidChangeInTextArea):
3566         * WebEditorClient.h:
3567         * WebElementPropertyBag.cpp:
3568         (WebElementPropertyBag::Read):
3569         * WebFrame.cpp:
3570         (kit):
3571         (WebFrame::initWithWebFrameView):
3572         (WebFrame::searchForLabelsBeforeElement):
3573         (WebFrame::matchLabelsAgainstElement):
3574         (WebFrame::createPlugin):
3575         (WebFrame::createJavaAppletWidget):
3576         (WebFrame::computePageRects):
3577         (WebFrame::getPrintedPageCount):
3578         (WebFrame::spoolPages):
3579         * WebFrame.h:
3580         * WebView.cpp:
3581         (WebView::handleEditingKeyboardEvent):
3582         (WebView::keyDown):
3583         (WebView::generateSelectionImage):
3584         * WebView.h:
3585
3586 2007-02-18  Ada Chan  <adachan@apple.com>
3587
3588         Reviewed by Adam.
3589         
3590         Move app text controls to use webview
3591
3592         * DOMCoreClasses.cpp:
3593         (DOMNode::parentNode): implemented
3594         (DOMElement::blur): implemented
3595         * Interfaces/IWebUIDelegatePrivate.idl: added API for focus/blur notifications
3596         * WebKit.vcproj/WebKit.def: added DrawTextAtPoint
3597         * WebKit.vcproj/WebKit.vcproj: added WebKitGraphics.h/cpp
3598         * WebKit.vcproj/WebKit_debug.def: added DrawTextAtPoint
3599         * WebKitGraphics.cpp: Added.
3600         (DrawTextAtPoint): calls WebCoreDrawTextAtPoint to render text
3601         * WebKitGraphics.h: Added.
3602         * WebView.cpp:
3603         (WebViewWndProc): notify setfocus and killfocus through IWebUIDelegatePrivate delegate.
3604         (WebView::unmarkAllTextMatches): added null check
3605
3606 2007-02-18  Oliver Hunt  <oliver@apple.com>
3607
3608         Reviewed by Adam.
3609
3610         Stubs to keep the build going
3611
3612         * WebDragClient.cpp:
3613         (WebDragClient::willPerformDragSourceAction):
3614         (WebDragClient::startDrag):
3615         (WebDragClient::createDragImageForLink):
3616         * WebDragClient.h:
3617
3618 2007-02-17  Steve Falkenburg  <sfalken@apple.com>
3619
3620         Reviewed by Adam.
3621
3622         <rdar://problem/4918821> Find: clicking on the webview does not hide findoverlay
3623         <rdar://problem/4956428> Find: Showing/hiding the Find banner should not push the page contents down when possible
3624
3625         * Interfaces/IWebViewPrivate.idl: Added scrollBy, visibleContentRect
3626         * WebView.cpp:
3627         (WebView::scrollOffset): Add null check
3628         (WebView::scrollBy): Added so we can scroll a webview easily (matches scroll position getter here)
3629         (WebView::visibleContentRect):  Added so we can size find overlay appropriately (not including scroll bars)
3630         * WebView.h: Added scrollBy, visibleContentRect
3631
3632 2007-02-17  Adele Peterson  <adele@apple.com>
3633
3634         Reviewed by Hyatt.
3635
3636         Fix for <rdar://problem/5006194> Caret is not revealed when a newline is entered into a textarea
3637
3638         * WebView.cpp: (WebView::handleEditingKeyboardEvent):
3639         Use shared code in Editor class to insertParagraphSeparator (or insertLineBreak for plain text).
3640         This will also reveal the selection properly.
3641
3642 2007-02-16  Anders Carlsson  <acarlsson@apple.com>
3643
3644         Build fixes.
3645         
3646         * WebDownload.cpp:
3647         (WebDownload::init):
3648         (WebDownload::initWithRequest):
3649
3650 2007-02-15  Steve Falkenburg  <sfalken@apple.com>
3651
3652         Reviewed by Adam.
3653         
3654         <rdar://problem/5001181> Crash: autofilling empty page
3655         
3656         Return an error from WebFrame::DOMDocument if there's no document
3657
3658         * WebFrame.cpp:
3659         (WebFrame::DOMDocument): null document now maps to E_FAIL
3660
3661 2007-02-15  Brady Eidson  <beidso