1 2007-12-14 David D. Kilzer <ddkilzer@apple.com>
3 <rdar://problem/5647272> Remove user agent string hack for flickr.com
8 (-[WebView _userAgentForURL:]): Removed hack.
10 2007-12-14 David D. Kilzer <ddkilzer@apple.com>
12 <rdar://problem/5647261> Remove user agent string hack for yahoo.com
17 (-[WebView _userAgentForURL:]): Removed hack.
19 2007-12-14 Darin Adler <darin@apple.com>
23 - fix http://bugs.webkit.org/show_bug.cgi?id=16296
24 <rdar://problem/5635641> -[WebFrameLoadDelegate didReceiveIcon:forFrame:] never called
27 (-[WebView setFrameLoadDelegate:]): Call [WebIconDatabase sharedIconDatabase] if the
28 a didReceiveIcon method is present.
30 2007-12-14 Darin Adler <darin@apple.com>
34 - Changed a few more editing operations to use WebCore instead of WebKit.
35 - Removed some obsolete unused code.
37 * WebCoreSupport/WebFrameBridge.h: Moved declarations of methods that are both
38 defined and used on the WebKit side to here. These no longer belong on the bridge
39 and should be moved to the WebFrame class (or elsewhere).
40 * WebCoreSupport/WebFrameBridge.mm: Removed some unused methods.
42 * WebView/WebFrameView.mm:
43 (+[WebFrameView _viewTypesAllowImageTypeOmission:]): Fix typo in comment.
45 * WebView/WebHTMLView.mm:
46 (-[WebHTMLViewPrivate dealloc]): Removed unused firstResponderTextViewAtMouseDownTime.
47 (-[WebHTMLViewPrivate clear]): Ditto.
48 (-[WebHTMLView _setMouseDownEvent:]): Ditto.
49 (commandNameForSelector): Added special cases for pageDown:, pageDownAndModifySelection:,
50 pageUp:, and pageUpAndModifySelection:, since those names probably aren't specific enough
51 to be used in WebCore (what AppKit calls scrollPageDown: vs. pageDown: needs to be
52 disambiguated with the word "Move"). Added deleteBackward:,
53 deleteBackwardByDecomposingPreviousCharacter:, deleteForward:, deleteToBeginningOfLine:,
54 deleteToBeginningOfParagraph:, deleteToEndOfLine:, deleteToEndOfParagraph:, pageDown:,
55 pageDownAndModifySelection:, pageUp:, pageUpAndModifySelection:, selectLine:,
56 selectParagraph:, selectSentence:, and selectWord: to the list of commands that are
58 (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Eliminated the long list of
59 operations that we forward to WebCore. Instead, look up any command that WebCore can
60 handle, after any that we handle specially in WebHTMLView. Also fixed a bug where
61 an item that's not a menu item with changeBaseWritingDirection:NSWritingDirectionNatural
62 would end up enabled instead of disabled and streamlined the logic for toggleGrammarChecking:.
63 (-[WebHTMLView mouseDown:]): Removed unused firstResponderTextViewAtMouseDownTime.
64 (-[WebHTMLView becomeFirstResponder]): Removed unused willBecomeFirstResponderForNodeFocus.
65 (-[WebHTMLView resignFirstResponder]): Ditto.
66 (-[WebHTMLView checkSpelling:]): Took unneeded extra initialization of NSSpellChecker.
68 * WebView/WebHTMLViewInternal.h: Removed unused willBecomeFirstResponderForNodeFocus,
69 firstResponderTextViewAtMouseDownTime, _textViewWasFirstResponderAtMouseDownTime: and
70 _willMakeFirstResponderForNodeFocus.
72 2007-12-13 Alexey Proskuryakov <ap@webkit.org>
76 Turn on keyboard event processing quirks for feed views and old applications on Mac OS X.
78 * Misc/WebKitVersionChecks.h:
80 (-[WebView _needsKeyboardEventHandlingQuirks]):
81 (-[WebView _preferencesChangedNotification:]):
83 2007-12-12 Brady Eidson <beidson@apple.com>
85 Reviewed by Sam Weinig
87 Fix for <rdar://problem/4886844> and lay groundwork for <rdar://problem/4516170> (Back/Forward Cache on Windows)
89 * WebCoreSupport/WebCachedPagePlatformData.h: Added.
90 (WebCachedPagePlatformData::WebCachedPagePlatformData): Constructor takes a WebDocumentView for later restoration
91 (WebCachedPagePlatformData::clear):
92 (WebCachedPagePlatformData::webDocumentView):
94 * WebCoreSupport/WebFrameLoaderClient.h:
95 * WebCoreSupport/WebFrameLoaderClient.mm:
96 (WebFrameLoaderClient::savePlatformDataToCachedPage):
97 (WebFrameLoaderClient::transitionToCommittedFromCachedPage): Don't set the DocumentLoader to the Frame here,
98 because that is now done in WebCore.
99 (WebFrameLoaderClient::transitionToCommittedForNewPage):
101 2007-12-12 Mark Rowe <mrowe@apple.com>
103 Reviewed by Dave Kilzer.
105 Remove abuse of projectDirPath from WebKit.xcodeproj to fix Production builds.
107 * Configurations/WebKit.xcconfig:
109 2007-12-11 Sam Weinig <sam@webkit.org>
111 Reviewed by Darin Adler.
113 Scrub URL out of the tree in preparation for renaming KURL to URL.
115 * WebCoreSupport/WebFrameLoaderClient.mm:
116 (WebFrameLoaderClient::actionDictionary):
117 * WebView/WebDataSource.mm:
118 (-[WebDataSource _URL]):
119 * WebView/WebView.mm:
120 (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
122 2007-12-11 Darin Adler <darin@apple.com>
126 - change more editing commands to use WebCore::Editor
127 - change to use the new WebCore::Editor::command() function
129 * WebView/WebHTMLView.mm: Changed alignCenter, alignJustified, alignLeft,
130 alignRight, cut, copy, deleteToMark, indent, insertNewlineIgnoringFieldEditor,
131 insertTabIgnoringFieldEditor, outdent, selectAll, selectToMark, setMark,
132 subscript, superscript, swapWithMark, underline, unscript, yank, and yankAndSelect
133 to use the "forward to WebCore" macro instead of having hand-written implementations.
134 (kit): Added function to change a TriState to an AppKit-style tri-state value.
135 (-[WebHTMLView coreCommandBySelector:]): Added. No longer converts case of the
136 first character or copies the selector name, since the Editor commands are not case
137 sensitive any more. Returns a command object.
138 (-[WebHTMLView coreCommandByName:]): Added.
139 (-[WebHTMLView executeCoreCommandBySelector:]): Renamed from callWebCoreCommand:,
140 and changed to use the new coreCommandBySelector: method.
141 (-[WebHTMLView executeCoreCommandByName:]): Added.
142 (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Changed all the
143 methods that call through to WebCore to also use the state() and isEnabled()
144 functions on the commands for the menu item state and user interface item enabling.
145 (-[WebHTMLView _handleStyleKeyEquivalent:]): Use ToggleBold and ToggleItalic by
146 name rather than having local methods for them; no need for methods with a single
148 (-[WebHTMLView insertParagraphSeparator:]): Use executeCoreCommandByName: rather
149 than the deprecated execCommand().
150 (-[WebHTMLView doCommandBySelector:]): Changed to use command().execute() rather
151 than the deprecated execCommand().
152 * WebView/WebHTMLViewInternal.h: Removed some unneeded method declarations.
154 2007-12-07 Alexey Proskuryakov <ap@webkit.org>
158 <rdar://problem/5535636>
159 Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
161 http://bugs.webkit.org/show_bug.cgi?id=13916
162 JavaScript detects Tab as a character input on a textfield validation
164 * WebCoreSupport/WebEditorClient.h:
165 Renamed handleKeypress() to handleKeyboardEvent(), as it gets both keydowns and keypresses.
166 Renamed handleInputMethodKeypress() to handleInputMethodKeydown().
167 * WebCoreSupport/WebEditorClient.mm:
168 (WebEditorClient::handleKeyboardEvent): This change makes sense only remotely, but it helped
169 to get tests working. I guess Mac keyboard event handling needs further refactoring.
171 * WebView/WebHTMLView.mm:
172 (selectorToCommandName): Convert AppKit editing selector name to Editor command name - extracted
173 from callWebCoreCommand:.
174 (_interceptEditingKeyEvent:shouldSaveCommand:): Insert text from keypress.
176 * WebView/WebPDFView.mm:
177 (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
178 Convert incoming platform KeyDown into RawKeyDown, as this is what the view is interested in.
180 2007-12-10 Brady Eidson <beidson@apple.com>
182 Reviewed by John Sullivan
184 Fix for <rdar://problem/5640080> - Database UI delegate calls need to specify WebFrame
186 This is because a common UI case is to want to know the originating URL of a Database
188 * WebCoreSupport/WebChromeClient.mm:
189 (WebChromeClient::requestQuotaIncreaseForNewDatabase):
190 (WebChromeClient::requestQuotaIncreaseForDatabaseOperation):
192 * WebView/WebUIDelegatePrivate.h:
194 * WebView/WebView.mm:
195 (CallDelegateReturningUnsignedLongLong):
196 (CallUIDelegateReturningUnsignedLongLong):
197 * WebView/WebViewInternal.h:
199 2007-12-10 Timothy Hatcher <timothy@apple.com>
201 Reviewed by Mark Rowe.
203 <rdar://problem/5639463> Bundle versions on Tiger should be 4523.x not 523.x
205 * Configurations/Version.xcconfig: Some Tiger versions of Xcode don't set MAC_OS_X_VERSION_MAJOR,
206 so assume Tiger and use a 4 for the SYSTEM_VERSION_PREFIX.
208 2007-12-10 Kevin Decker <kdecker@apple.com>
212 Fixed: <rdar://problem/4290098> Right-mouse click on element doesn't call onmousedown handler
214 * WebView/WebHTMLView.mm:
215 (-[WebHTMLView menuForEvent:]): Match behavior of other browsers by sending an onmousedown event for right clicks.
217 2007-12-08 Oliver Hunt <oliver@apple.com>
221 Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
223 Fixes <rdar://problem/5620249> Must disable SVG animation
224 <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
226 Minor updates to the feature flags used.
228 * Configurations/WebKit.xcconfig:
229 * DOM/WebDOMOperations.mm:
231 2007-12-07 Darin Adler <darin@apple.com>
233 Reviewed by Kevin Decker and Tim Hatcher.
235 - speculative fix for <rdar://problem/5400159> CrashTracer: [USER] 726 crashes
236 in Safari at com.apple.WebKit: -[WebHTMLView(WebPrivate) _updateMouseoverWithFakeEvent] + 389
238 * WebView/WebHTMLView.mm:
239 (-[WebHTMLView _frameOrBoundsChanged]): Only schedule the mouseover timer if we are in a window
240 and not closed. That's because viewDidMoveToWindow and close are the entry points for cancelling.
241 (-[WebHTMLView close]): Add code to cancel both timers. Needed for the case where the entire
242 window goes away, and the view is never removed from the window.
243 (-[WebHTMLView viewDidMoveToWindow]): Don't do work if the view is closed.
245 2007-12-07 Darin Adler <darin@apple.com>
249 - http://bugs.webkit.org/show_bug.cgi?id=15981
250 speed up visited-link code a bit
252 * History/WebHistory.mm: Removed unused Latin-1 code path.
253 (-[_WebCoreHistoryProvider containsURL:length:]): Updated for method name change.
255 2007-12-07 Geoffrey Garen <ggaren@apple.com>
257 Reviewed by Sam Weinig.
259 Added a forwarding header, since we now #include nodes.h through some
260 JavaScriptCore headers.
262 * ForwardingHeaders/wtf/ListRefPtr.h: Added.
264 2007-12-06 Brady Eidson <beidson@apple.com>
266 Reviewed by Oliver's rubber stamp
268 Let's go ahead and call the correct UI Delegate method, shall we?
270 * WebCoreSupport/WebChromeClient.mm:
271 (WebChromeClient::requestQuotaIncreaseForDatabaseOperation): Call the correct UI delegate
273 2007-12-06 Adam Roben <aroben@apple.com>
275 Remove some assertions we know can fire and replace them with a FIXME
279 * WebCoreSupport/WebFrameLoaderClient.mm:
281 2007-12-06 Timothy Hatcher <timothy@apple.com>
283 Change the ASSERT added for the previous fix. The ASSERT was firing for 10.5.0.
284 Only assert if the major version is zero, since zero is handled in the other cases.
286 * WebView/WebView.mm:
287 (callGestalt): Remove the ASSERT.
288 (createMacOSXVersionString): ASSERT that major is not zero.
290 2007-12-06 Darin Adler <darin@apple.com>
292 Reviewed by Tim Hatcher.
294 - fix <rdar://problem/5513394> No way to detect Tiger vs Leopard from Safari's user agent string
296 * WebView/WebView.mm:
297 (callGestalt): Added.
298 (createMacOSXVersionString): Added.
299 (-[WebView _userAgentWithApplicationName:andWebKitVersion:]): Added Mac OS X version string,
300 right after the string "Mac OS X", but with underscores instead of dots to avoid the dreaded
301 "4." problem (old libraries that think a "4." anywhere in the user agent means Netscape 4).
302 (-[WebView _userAgentForURL:]): Fixed incorrect bug numbers.
304 2007-12-04 Geoffrey Garen <ggaren@apple.com>
306 Reviewed by Darin Adler.
308 Third step in refactoring JSGlobalObject: Moved data members and data
309 member access from Interpreter to JSGlobalObject.
311 * WebView/WebFrame.mm:
312 (-[WebFrame _attachScriptDebugger]):
314 2007-12-04 Kevin McCullough <kmccullough@apple.com>
319 - Security Fix. Instead of having it off by default, WebKit now must
320 explicitly turn off local-resource restriction when needed for backwards
321 coimpatibility reasons.
323 * WebView/WebView.mm:
324 (-[WebView _commonInitializationWithFrameName:groupName:]):
326 2007-12-05 Brady Eidson <beidson@apple.com>
328 Reviewed by Kevin Deckers rubberstamp
330 Disclose and export the Databases Directory defaults key
332 * Storage/WebDatabaseManager.mm:
333 * Storage/WebDatabaseManagerPrivate.h:
336 2007-12-04 Kevin Decker <kdecker@apple.com>
340 <rdar://problem/5629125> PluginInfoStore needs the ability to return the name of a plug-in for a given MIME type
342 * WebCoreSupport/WebViewFactory.mm:
343 (-[WebViewFactory pluginNameForMIMEType:]): Added.
345 2007-12-04 Brady Eidson <beidson@apple.com>
347 Reviewed by Mark Rowe
349 Tweaked the way we typedef and cast these objc_msgSend calls
351 * WebView/WebView.mm:
352 (CallDelegateReturningUnsignedLongLong):
354 2007-12-04 John Sullivan <sullivan@apple.com>
356 Reviewed by Brady Eidson (with help from Mark Rowe)
358 Fixed return values for unsigned-long-long delegate methods
360 * WebView/WebView.mm:
361 (CallDelegateReturningUnsignedLongLong):
362 redid the change that Brady did at home over the weekend but forgot to check in
364 2007-11-27 Adam Roben <aroben@apple.com>
366 Remove -[WebFrameBridge setNeedsReapplyStyles]
368 This functionality is now WebCore's responsibility.
372 * WebCoreSupport/WebFrameBridge.mm:
375 2007-12-04 John Sullivan <sullivan@apple.com>
379 Added deleteOrigin: SPI, which isn't fully implemented
381 * Storage/WebDatabaseManagerPrivate.h:
382 * Storage/WebDatabaseManager.mm:
383 (-[WebDatabaseManager deleteOrigin:]):
384 just calls deleteDatabasesWithOrigin: for now, but needs to delete origin itself too
386 2007-12-04 Timothy Hatcher <timothy@apple.com>
388 Reviewed by Mark Rowe.
390 Remove a check for early versions of Leopard CFNetwork now that
393 * Misc/WebKitVersionChecks.h: Remove WEBKIT_FIRST_CFNETWORK_VERSION_WITH_LARGE_DISK_CACHE_FIX.
394 * WebView/WebView.mm:
395 (+[WebView _setCacheModel:]): Remove the early Leopard CFNetwork check.
397 2007-12-04 Kevin Decker <kdecker@apple.com>
401 Revised fix for: <rdar://problem/5586978> REGRESSION (Safari 2-3): WebKit sometimes doesn't invoke Flash's NPP_SetWindow function and causes a hang
403 This fix is exactly the same as chageset 28359 with the exception of an added early return in
404 updateAndSetWindow to cover the additional case of when a plug-in isn't drawable.
406 The CG-based Flash player would sometimes hang because (for CoreGraphics-based plug-ins) our code would
407 only call into the NPP_SetWindow() function when we tell the plug-in to draw. This created havoc with
408 Flash because Flash expects the browser to call NPP_SetWindow() and provide a valid graphics context
409 regardless of whether or not it actually needs to draw.
411 * Plugins/WebBaseNetscapePluginView.mm:
412 (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Removed an incorrect comment and toned
413 down an ASSERT that was too strict.
414 (-[WebBaseNetscapePluginView updateAndSetWindow]): Removed an early return for CoreGraphics-based plug-ins
415 which would sometimes altogether prevent updating the PortState and calling into a plug-ins NPP_SetWindow()
416 function. Also tweaked a comment and added an early return if the plug-in can't draw.
418 2007-12-04 Darin Adler <darin@apple.com>
420 Reviewed by Kevin Decker.
422 * WebCoreSupport/WebFrameLoaderClient.h: Removed obsolete privateBrowsingEnabled.
423 * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
424 * WebKit.order: Ditto.
426 2007-12-03 Dan Bernstein <mitz@apple.com>
428 Reviewed by Dave Hyatt.
430 - fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame
432 * WebView/WebHTMLView.mm:
433 (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Removed the code
434 that checked if the view had resized and sent the resize event, since
435 FrameView sends resize events now.
436 * WebView/WebHTMLViewInternal.h:
438 2007-12-03 Timothy Hatcher <timothy@apple.com>
442 Change WebViewGetResourceLoadDelegateImplementations and WebViewGetFrameLoadDelegateImplementations
443 to return a pointer to the implementation struct instead of a copy of the struct. This changes
444 all of the callers to dereference the pointer to access the struct fields.
446 * Plugins/WebNullPluginView.mm:
447 (-[WebNullPluginView reportFailure]):
448 * WebCoreSupport/WebFrameBridge.mm:
449 * WebCoreSupport/WebFrameLoaderClient.mm:
450 (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
451 (WebFrameLoaderClient::assignIdentifierToInitialRequest):
452 (WebFrameLoaderClient::dispatchWillSendRequest):
453 (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
454 (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
455 (WebFrameLoaderClient::dispatchDidReceiveResponse):
456 (WebFrameLoaderClient::willCacheResponse):
457 (WebFrameLoaderClient::dispatchDidReceiveContentLength):
458 (WebFrameLoaderClient::dispatchDidFinishLoading):
459 (WebFrameLoaderClient::dispatchDidFailLoading):
460 (WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
461 (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
462 (WebFrameLoaderClient::dispatchDidCancelClientRedirect):
463 (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
464 (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
465 (WebFrameLoaderClient::dispatchWillClose):
466 (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
467 (WebFrameLoaderClient::dispatchDidReceiveTitle):
468 (WebFrameLoaderClient::dispatchDidCommitLoad):
469 (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
470 (WebFrameLoaderClient::dispatchDidFailLoad):
471 (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
472 (WebFrameLoaderClient::dispatchDidFinishLoad):
473 (WebFrameLoaderClient::dispatchDidFirstLayout):
474 * WebView/WebView.mm:
475 (WebViewGetResourceLoadDelegateImplementations):
476 (WebViewGetFrameLoadDelegateImplementations):
477 (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
478 * WebView/WebViewInternal.h:
480 2007-12-03 Timothy Hatcher <timothy@apple.com>
482 Reviewed by Brady Eidson.
484 <rdar://problem/5539913> 188 crashes in WebViewGetFrameLoadDelegateImplementations
485 <rdar://problem/5586095> CrashTracer: [USER] 5000+ crashes in Safari and Dashboard in dispatchDidFailLoading
486 <rdar://problem/5607081> CrashTracer: [USER] 2150 crashes in Safari at com.apple.WebKit:
487 WebViewGetResourceLoadDelegateImplementations + 28
489 * WebView/WebView.mm:
490 (-[WebView _cacheResourceLoadDelegateImplementations]): If the delegate is nil, bzero the
491 implementation cache. This just prevents us from calling getMethod() multiple times just to zero.
492 (-[WebView _cacheFrameLoadDelegateImplementations]): Ditto.
493 (WebViewGetResourceLoadDelegateImplementations): Return a zeroed implementations struct
494 if the WebView is nil. This fixes the crashes.
495 (WebViewGetFrameLoadDelegateImplementations): Ditto.
497 2007-12-02 Geoffrey Garen <ggaren@apple.com>
499 Reviewed by Eric Seidel.
501 Updated to match the JavaScriptCore change to move virtual methods from
502 Interpreter to JSGlobalObject.
504 * WebView/WebFrame.mm:
505 (-[WebFrame globalContext]): Use the toRef function instead of manually
508 2007-12-01 Brady Eidson <beidson@apple.com>
512 Added a default database quota of 5mb to the default WebPreferences
514 * WebView/WebPreferences.m:
515 (+[WebPreferences initialize]):
517 2007-11-30 John Sullivan <sullivan@apple.com>
519 Reviewed by Geoff Garen
521 Added another symbol for WebDatabaseManager clients
524 added .objc_class_name_WebSecurityOrigin
526 2007-11-30 Brady Eidson <beidson@apple.com>
530 Add isEqual operator to WebSecurityOrigin
532 * Storage/WebSecurityOrigin.mm:
533 (-[WebSecurityOrigin isEqual:]):
535 2007-11-30 John Sullivan <sullivan@apple.com>
539 Tweaks to newly-declared NSString * constants to make them usable from clients
541 * Storage/WebDatabaseManagerPrivate.h:
542 * Storage/WebDatabaseManager.mm:
543 removed "const" from new NSNotification names and userInfo keys; these generate compiler warnings when used
546 export new NSNotification names and userInfo keys so clients can use them
548 2007-11-29 Anders Carlsson <andersca@apple.com>
552 Rename WebKitShrinksStandaloneImagesToFitKey to WebKitShrinksStandaloneImagesToFit.
554 This is safe to do because the preference is off by default and Safari 3, which is the only client that turns it on,
555 is using the setter and not messing around with NSUserDefaults.
557 * WebView/WebPreferenceKeysPrivate.h:
558 * WebView/WebPreferences.m:
559 (+[WebPreferences initialize]):
560 (-[WebPreferences shrinksStandaloneImagesToFit]):
561 (-[WebPreferences setShrinksStandaloneImagesToFit:]):
563 2007-11-29 Brady Eidson <beidson@apple.com>
567 Support for <rdar://problem/5556381> and <rdar://problem/5556379>
569 Hook up UI Delegate calls for the database engine feature and other small tweaks
571 * Storage/WebDatabaseManager.mm:
572 (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Renamed databaseName parameter to databaseIdentifier for clarity
573 (-[WebDatabaseManager deleteDatabase:withOrigin:]): Renamed databaseName parameter to databaseIdentifier for clarity
574 * Storage/WebDatabaseManagerPrivate.h:
576 * Storage/WebDatabaseTrackerClient.h:
577 * Storage/WebDatabaseTrackerClient.mm:
578 (WebDatabaseTrackerClient::dispatchDidModifyDatabase): Renamed databaseName parameter to databaseIdentifier for clarity
580 * WebCoreSupport/WebChromeClient.h:
581 * WebCoreSupport/WebChromeClient.mm:
582 (WebChromeClient::requestQuotaIncreaseForNewDatabase): Call through to the UI Delegate
583 (WebChromeClient::requestQuotaIncreaseForDatabaseOperation): Ditto
585 * WebView/WebUIDelegatePrivate.h: Added the two UI Delegate methods
587 * WebView/WebView.mm:
588 (CallDelegateReturningUnsignedLongLong):
589 (CallUIDelegateReturningUnsignedLongLong):
590 * WebView/WebViewInternal.h:
592 2007-11-28 Kevin McCullough <kmccullough@apple.com>
596 - Added recursive runloop guards.
598 * DefaultDelegates/WebScriptDebugServer.m:
599 (-[WebScriptDebugServer suspendProcessIfPaused]):
601 2007-11-29 Mark Rowe <mrowe@apple.com>
603 Reviewed by Oliver Hunt.
605 Fix an assertion failure seen on the layout tests, and when closing the window after
606 visiting <http://www.coudal.com/losalamos/>.
608 * Plugins/WebBaseNetscapePluginStream.mm:
609 (-[WebBaseNetscapePluginStream _destroyStream]): Unlink the file and close the file
610 descriptor even when the stream is being destroyed without the load completing. This
611 avoids leaking the path and file descriptor, and leaving the temporary file on disk.
613 2007-11-28 Adele Peterson <adele@apple.com>
617 Fix for <rdar://problem/5524216> CrashTracer: [USER] 496 crashes in Safari at com.apple.WebCore: WebCore::Frame::eventHandler const + 6
619 The CrashTracer shows a variety of crashes in different methods (including keyDown and keyUp). This change adds nil checks for the frame in
620 WebHTMLView to prevent future problems in other methods as well.
622 * WebView/WebHTMLView.mm:
623 (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
624 (-[WebHTMLView keyDown:]):
625 (-[WebHTMLView keyUp:]):
626 (-[WebHTMLView flagsChanged:]):
627 (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
628 (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
629 (-[WebHTMLView checkSpelling:]):
630 (-[WebHTMLView showGuessPanel:]):
631 (-[WebHTMLView indent:]):
632 (-[WebHTMLView outdent:]):
633 (-[WebHTMLView paste:]):
634 (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
635 (-[WebHTMLView insertText:]):
636 (-[WebHTMLView selectionTextRects]):
638 2007-11-28 Dan Bernstein <mitz@apple.com>
640 Reviewed by Maciej Stachowiak.
642 - fix <rdar://problem/5596160> fast/events/objc-event-api.html fails when run alone (or first)
644 * WebView/WebHTMLView.mm:
645 (-[WebHTMLView setDataSource:]): This method calls addMouseMovedObserver
646 because addMouseMovedObserver returns early if the dataSource
647 is not nil. But if the dataSource is already set (which happens when
648 a WebHTMLView is being reused) then addMouseMovedObserver must not
651 2007-11-27 Anders Carlsson <andersca@apple.com>
655 * Storage/WebDatabaseManager.mm:
656 * Storage/WebDatabaseManagerPrivate.h:
657 * Storage/WebDatabaseTrackerClient.mm:
658 (WebDatabaseTrackerClient::dispatchDidModifyOrigin):
659 (WebDatabaseTrackerClient::dispatchDidModifyDatabase):
660 * Storage/WebSecurityOrigin.mm:
661 (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]):
662 * Storage/WebSecurityOriginInternal.h:
664 2007-11-27 Kevin Decker <kdecker@apple.com>
666 Reviewed by Darin, landed by Anders.
668 Fixed: <rdar://problem/4610818> CrashTracer: 1533 crashes in Safari at com.macromedia.Flash Player.plugin: native_ShockwaveFlash_TCallLabel + 271131
670 The problem was that some Leopard users were still inadvertently using the old Flash 8 plug-in, even though Leopard
671 shipped with Flash 9. To avoid loading an older version of a plug-in when a newer version is installed, the plug-in
672 database will compare bundle versions and always load the latest version.
674 * Plugins/WebBasePluginPackage.h:
675 * Plugins/WebBasePluginPackage.m:
676 (-[WebBasePluginPackage versionNumber]): New method. CFBundleGetVersionNumber doesn't work with all possible versioning schemes,
677 but we think for now it's good enough for us.
678 * Plugins/WebPluginDatabase.m:
679 (considerCandidate): Added a C utility function which compares the current plug-in against a candidate plug-in's version number.
680 If both plug-ins have the same bundle ID and the candiate is newer, the current plug-in becomes the candidate.
681 (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]): Calls the new considerCandidate() function.
683 2007-11-26 Timothy Hatcher <timothy@apple.com>
685 Reviewed by Dave Hyatt.
687 <rdar://problem/5569233> Add the ability to disable author and user CSS styles
689 * WebView/WebPreferenceKeysPrivate.h: Define WebKitRespectStandardStyleKeyEquivalentsPreferenceKey.
690 * WebView/WebPreferences.m:
691 (+[WebPreferences initialize]): Default WebKitRespectStandardStyleKeyEquivalentsPreferenceKey to YES.
692 (-[WebPreferences authorAndUserStylesEnabled]): Return the setting's BOOL value.
693 (-[WebPreferences setAuthorAndUserStylesEnabled:]): Set the setting's BOOL value.
694 * WebView/WebPreferencesPrivate.h: Add authorAndUserStylesEnabled and setAuthorAndUserStylesEnabled:.
695 * WebView/WebView.mm:
696 (-[WebView _preferencesChangedNotification:]): Update WebCore::Settings::authorAndUserStylesEnabled.
698 2007-11-26 Brady Eidson <beidson@apple.com>
700 Reviewed by Mark Rowe
702 Provide API for setting the default storage quota per database origin
704 * Misc/WebNSDictionaryExtras.h:
705 * Misc/WebNSDictionaryExtras.m:
706 (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Helper for UINT64 preferences
708 * WebView/WebPreferenceKeysPrivate.h:
709 * WebView/WebPreferences.m:
710 (-[WebPreferences _unsignedLongLongValueForKey:]): Helper for UINT64 prefs
711 (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto
712 (-[WebPreferences defaultDatabaseQuota]):
713 (-[WebPreferences setDefaultDatabaseQuota:]):
714 * WebView/WebPreferencesPrivate.h:
716 * WebView/WebView.mm:
717 (-[WebView _preferencesChangedNotification:]): Set the WebCore Settings version of the default storage pref
719 2007-11-26 Darin Adler <darin@apple.com>
723 - some middle-mouse-button-related fixes
725 These don't affect Safari since it maps the middle mouse button to the command key,
726 but that might not always be the case for future versions.
728 * WebView/WebHTMLView.mm:
729 (-[WebHTMLView otherMouseDown:]): Pass through middle mouse down events to WebCore.
730 (-[WebHTMLView otherMouseDragged:]): Ditto, for drag events.
731 (-[WebHTMLView otherMouseUp:]): Ditto, for up events.
733 * WebView/WebPolicyDelegate.h: Fixed inaccurate documentation of WebActionButtonKey.
735 2007-11-26 Anders Carlsson <andersca@apple.com>
739 Get rid of the WebSecurityOriginPrivate object and store
740 the WebCore::SecurityOriginData pointer in the _private field of
741 the WebSecurityOrigin object instead.
743 * Storage/WebDatabaseManager.mm:
744 (-[WebDatabaseManager databasesWithOrigin:]):
745 (-[WebDatabaseManager detailsForDatabase:withOrigin:]):
746 (-[WebDatabaseManager deleteDatabasesWithOrigin:]):
747 (-[WebDatabaseManager deleteDatabase:withOrigin:]):
748 * Storage/WebSecurityOrigin.mm:
749 (-[WebSecurityOrigin initWithProtocol:domain:port:]):
750 (-[WebSecurityOrigin protocol]):
751 (-[WebSecurityOrigin domain]):
752 (-[WebSecurityOrigin port]):
753 (-[WebSecurityOrigin usage]):
754 (-[WebSecurityOrigin quota]):
755 (-[WebSecurityOrigin setQuota:]):
756 (-[WebSecurityOrigin dealloc]):
757 (-[WebSecurityOrigin finalize]):
758 (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]):
759 (-[WebSecurityOrigin _core]):
760 * Storage/WebSecurityOriginInternal.h:
762 2007-11-26 Timothy Hatcher <timothy@apple.com>
764 Reviewed by Adam Roben.
766 Bug 16137: Web Inspector window on Leopard should have a unified toolbar and window title
767 http://bugs.webkit.org/show_bug.cgi?id=16137
769 Create the Web Inspector window with the textured style. Set the content border
770 thickness for the top of the window or the height of the toolbar. Also make the
771 window's bottom corners square, since a normal textured window normally has
772 rounded bottom corners.
774 * WebCoreSupport/WebInspectorClient.mm:
775 (-[WebInspectorWindowController window]):
777 2007-11-24 Mark Rowe <mrowe@apple.com>
781 * Plugins/WebBaseNetscapePluginStream.mm:
782 (CarbonPathFromPOSIXPath): Use WebCFAutorelease as this also works on Tiger.
784 2007-11-24 Mark Rowe <mrowe@apple.com>
786 Reviewed by Tim Hatcher.
788 Fix <rdar://problem/5432686> 333MB RPRVT seems to leak @ www.43folders.com (1hr plug-in stream).
789 http://bugs.webkit.org/show_bug.cgi?id=13705
791 Have NP_ASFILE and NP_ASFILEONLY streams write the data to disk as they receive it rather than
792 dumping the data to disk in a single go when the stream has completed loading. On a test case
793 involving a 150MB Flash movie being streamed from a local web server this reduces memory consumption
794 on page load from around 400MB to 22MB.
796 The only plugin I have found that uses NP_ASFILE or NP_ASFILEONLY on the Mac is our NetscapeMoviePlugin
797 example code so the NP_ASFILE portion of this change has not had any testing with a real-world plugin.
799 * Plugins/WebBaseNetscapePluginStream.h:
800 * Plugins/WebBaseNetscapePluginStream.mm:
801 (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]):
802 (-[WebBaseNetscapePluginStream dealloc]):
803 (-[WebBaseNetscapePluginStream finalize]):
804 (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]):
805 (-[WebBaseNetscapePluginStream _destroyStream]): Update to work with paths as NSStrings.
806 (-[WebBaseNetscapePluginStream _deliverDataToFile:]): Open the file if it is not already open, and write any data
808 (-[WebBaseNetscapePluginStream finishedLoading]): If the stream is NP_ASFILE or NP_ASFILEONLY we need to ensure
809 that the file exists before _destroyStream passes it to the plugin. Simulating the arrival of an empty data block
810 ensure that the file will be created if it has not already.
811 (-[WebBaseNetscapePluginStream receivedData:]):
812 (CarbonPathFromPOSIXPath):
813 * Plugins/WebBaseNetscapePluginView.mm:
814 (-[WebBaseNetscapePluginView pluginViewFinishedLoading:]): Data is dealt with incrementally so there's no need to pass
815 it to finishedLoading.
816 (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Ditto.
818 2007-11-23 Oliver Hunt <oliver@apple.com>
820 Reviewed by Mark Rowe.
822 Fixed <rdar://problem/3759190> allow input methods the option of processing mouse events themselves
824 * WebView/WebHTMLView.mm:
825 (-[WebHTMLView mouseDown:]):
827 2007-11-22 Dan Bernstein <mitz@apple.com>
829 Reviewed by Antti Koivisto.
831 - http://bugs.webkit.org/show_bug.cgi?id=15811
832 WebKit plug-ins can re-enter WebKit under attach()
833 <rdar://problem/5577978>
835 * Plugins/WebNullPluginView.mm:
836 (-[WebNullPluginView viewDidMoveToWindow]): Removed workaround for the
837 above bug that added as part of fixing
838 <http://bugs.webkit.org/show_bug.cgi?id=15804>.
840 2007-11-21 Mark Rowe <mrowe@apple.com>
844 Fix WebKit to build without warnings under GCC 4.2.
846 * Configurations/Base.xcconfig:
848 2007-11-21 Mark Rowe <mrowe@apple.com>
850 Reviewed by Tim Hatcher.
852 Changes due to <rdar://problem/5602936> Need to resolve new GCC 4.2 warnings
854 Update format strings to use format specifiers that match the argument types.
856 * Misc/WebGraphicsExtras.c:
857 (WebConvertBGRAToARGB):
859 2007-11-19 Brady Eidson <beidson@apple.com>
863 Finished hooking up the WebKit API for database management.
864 Most of the API is actually implemented in WebCore and some of those methods might
865 only be stubs for now.
867 * Storage/WebDatabaseManager.mm:
868 (-[WebDatabaseManager origins]): Call through to the WebCore tracker and construct an API result
869 (-[WebDatabaseManager databasesWithOrigin:]): Ditto
870 (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Ditto
872 * Storage/WebSecurityOrigin.mm:
873 (-[WebSecurityOrigin usage]): Call through to WebCore
874 (-[WebSecurityOrigin quota]): Ditto
875 (-[WebSecurityOrigin setQuota:]): Ditto
876 (-[WebSecurityOrigin _core]): Get WebCore version of this object
877 * Storage/WebSecurityOriginInternal.h:
879 2007-11-17 Timothy Hatcher <timothy@apple.com>
881 Reviewed by Mark Rowe.
883 Bug 13470: i18n: The Web Inspector is not localizable
884 http://bugs.webkit.org/show_bug.cgi?id=13470
886 Implement the localizedStringsURL() client method to return the
887 localized URL of InspectorLocalizedStrings.js in WebCore.
889 * WebCoreSupport/WebInspectorClient.h: Added localizedStringsURL.
890 * WebCoreSupport/WebInspectorClient.mm:
891 (WebInspectorClient::localizedStringsURL): Added.
892 (WebInspectorClient::updateWindowTitle): Localized the window title.
893 (-[WebInspectorWindowController init]): Remove a FIXME that dosen't make sense anymore.
894 (-[WebInspectorWindowController initWithInspectedWebView:]): Code style cleanup.
896 2007-11-17 Alexey Proskuryakov <ap@webkit.org>
900 http://bugs.webkit.org/show_bug.cgi?id=15969
901 Eliminate Editor::deleteRange()
903 * WebView/WebHTMLView.mm:
904 (+[WebHTMLView initialize]):
905 (-[WebHTMLView yank:]):
906 (-[WebHTMLView yankAndSelect:]):
907 (-[WebHTMLView setMark:]):
908 (-[WebHTMLView deleteToMark:]):
909 (-[WebHTMLView selectToMark:]):
910 (-[WebHTMLView swapWithMark:]):
911 Pushed all kill ring methods to WebCore. They were guilty of using Editor::deleteRange()!
913 2007-11-16 Mark Rowe <mrowe@apple.com>
915 Reviewed by Tim Hatcher.
917 Build WebCore as a sub-framework of WebKit in all configurations.
919 * Configurations/WebKit.xcconfig:
921 2007-11-16 John Sullivan <sullivan@apple.com>
926 Exported some new database-related symbols
928 2007-11-16 Brady Eidson <beidson@apple.com>
932 Database management API tweaks
934 Fleshed out "WebSecurityOrigin" to be the API object representing an origin. This relieves some
935 burden off WebDatabaseManager and allows usage/quota operations on the SecurityOrigin object itself
937 Also added a new subdirectory for Storage related API - Why are we afraid to add new directories to
940 * Misc/WebSecurityOrigin.mm: Removed.
941 * Misc/WebSecurityOriginInternal.h: Removed.
942 * Misc/WebSecurityOriginPrivate.h: Removed.
944 * Storage/WebDatabaseManager.mm: Work in terms of WebSecurityOrigin
945 * Storage/WebDatabaseManagerPrivate.h:
947 * Storage/WebSecurityOrigin.mm: Added.
948 (-[WebSecurityOriginPrivate initWithProtocol:domain:port:]):
949 (-[WebSecurityOriginPrivate initWithWebCoreSecurityOrigin:]):
950 (-[WebSecurityOriginPrivate finalize]):
951 (-[WebSecurityOriginPrivate dealloc]):
952 (-[WebSecurityOrigin initWithProtocol:domain:]):
953 (-[WebSecurityOrigin initWithProtocol:domain:port:]):
954 (-[WebSecurityOrigin protocol]):
955 (-[WebSecurityOrigin domain]):
956 (-[WebSecurityOrigin port]):
957 (-[WebSecurityOrigin usage]):
958 (-[WebSecurityOrigin quota]):
959 (-[WebSecurityOrigin setQuota:]): Clients will set quotas on the WebSecurityOrigin object itself
960 (-[WebSecurityOrigin dealloc]):
961 (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]):
962 * Storage/WebSecurityOriginInternal.h: Added.
963 * Storage/WebSecurityOriginPrivate.h: Added.
965 2007-11-15 Brady Eidson <beidson@apple.com>
969 Stubbing out everything required for a WebKit API for databases
971 These interfaces seem to provide everything we need for UI and management at the browser level
973 * Misc/WebDatabaseManager.h: Removed.
974 * Misc/WebDatabaseManager.mm: Removed.
975 * Misc/WebDatabaseManagerPrivate.h: Removed.
977 * Misc/WebSecurityOrigin.mm: Added. Object that acts as a container for the "SecurityOrigin tuple"
978 (protocol, domain, and port)
979 (-[WebSecurityOriginPrivate initWithProtocol:domain:port:]):
980 (-[WebSecurityOriginPrivate dealloc]):
981 (-[WebSecurityOrigin initWithProtocol:domain:]):
982 (-[WebSecurityOrigin initWithProtocol:domain:port:]):
983 (-[WebSecurityOrigin protocol]):
984 (-[WebSecurityOrigin domain]):
985 (-[WebSecurityOrigin port]):
986 (-[WebSecurityOrigin dealloc]):
987 (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:WebCore::]):
988 * Misc/WebSecurityOriginInternal.h: Added.
989 * Misc/WebSecurityOriginPrivate.h: Added.
991 * Storage/WebDatabaseManager.mm: Added.
992 (+[WebDatabaseManager sharedWebDatabaseManager]):
993 (-[WebDatabaseManager origins]): Get a list of all origins currently tracked
994 (-[WebDatabaseManager detailsForOrigin:]): Get the current usage and current quota for the given origin
995 (-[WebDatabaseManager databasesWithOrigin:]): Get all databases for a certain origin
996 (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Get all details about a specific database
997 (-[WebDatabaseManager setQuota:forOrigin:]): Change origin-wide quota
998 (-[WebDatabaseManager deleteAllDatabases]):
999 (-[WebDatabaseManager deleteAllDatabasesWithOrigin:]):
1000 (-[WebDatabaseManager deleteDatabase:withOrigin:]):
1001 * Storage/WebDatabaseManagerPrivate.h: Added.
1002 * Storage/WebDatabaseManagerInternal.h: Added.
1003 (WebKitInitializeDatabasesIfNecessary): One-time initialization of database-related things
1005 * Storage/WebDatabaseTrackerClient.h: Added. Stubbed out client for notifications
1006 * Storage/WebDatabaseTrackerClient.mm: Added.
1007 (WebDatabaseTrackerClient::sharedWebDatabaseTrackerClient):
1008 (WebDatabaseTrackerClient::WebDatabaseTrackerClient):
1009 (WebDatabaseTrackerClient::~WebDatabaseTrackerClient):
1010 (WebDatabaseTrackerClient::dispatchDidModifyOrigin):
1011 (WebDatabaseTrackerClient::dispatchDidModifyDatabase):
1013 * WebView/WebView.mm:
1014 (-[WebView _commonInitializationWithFrameName:groupName:]): Do one-time initialization of
1015 Database-related things here
1017 2007-11-13 Geoffrey Garen <ggaren@apple.com>
1019 Reviewed by Anders Carlsson.
1021 Renamed Shared to RefCounted.
1023 * ForwardingHeaders/wtf/RefCounted.h: Copied from WebKit/mac/ForwardingHeaders/wtf/Shared.h.
1024 * ForwardingHeaders/wtf/Shared.h: Removed.
1025 * WebCoreSupport/WebContextMenuClient.h:
1027 2007-11-13 Geoffrey Garen <ggaren@apple.com>
1029 Reviewed by Sam Weinig.
1031 Moved Shared.h into wtf so it could be used in more places.
1034 * WebCoreSupport/WebContextMenuClient.h:
1036 2007-11-13 John Sullivan <sullivan@apple.com>
1040 removed recently-added PreferredType concept; we found a better way to do what
1041 ths was accomplishing
1043 * WebCoreSupport/WebChromeClient.mm:
1044 (WebChromeClient::createWindow):
1045 removed use of PreferredType
1047 2007-11-13 John Sullivan <sullivan@apple.com>
1049 Reviewed by Dan Bernstein.
1051 - fixed <rdar://problem/5567954> REGRESSION (Safari 2-3): Autofill no longer automatically fills in
1052 form fields other than the one you're typing into
1054 * WebCoreSupport/WebEditorClient.mm:
1055 (selectorForKeyEvent):
1056 correct the key identifier strings for Tab and Esc; these were updated in WebCore as part of r21445
1057 but didn't get updated here.
1059 2007-11-12 Josh Aas <joshmoz@gmail.com>
1063 - http://bugs.webkit.org/show_bug.cgi?id=15946
1064 add NPPValue NPPVpluginDrawingModel (Mozilla bug 403418 compat)
1066 * Plugins/WebBaseNetscapePluginView.mm:
1067 (-[WebBaseNetscapePluginView setVariable:value:]):
1069 2007-11-12 Alexey Proskuryakov <ap@webkit.org>
1073 http://bugs.webkit.org/show_bug.cgi?id=15954
1074 Move DOM Selection operations out of SelectionController
1076 * WebView/WebHTMLView.mm:
1077 (-[WebHTMLView _expandSelectionToGranularity:]):
1078 (-[WebHTMLView selectToMark:]):
1079 (-[WebHTMLView swapWithMark:]):
1080 * WebView/WebView.mm:
1081 (-[WebView setSelectedDOMRange:affinity:]):
1082 Adapted for SelectionController::setSelectedRange() now returning a bool.
1084 2007-11-12 Oliver Hunt <oliver@apple.com>
1086 Reviewed by Darin and Geoff.
1088 <rdar://problem/5522011> The content of the password field of
1089 Safari is displayed by reconversion.
1091 Some input methods (notably Kotoeri) can incorrectly provide
1092 access to the raw text of a password field. To work around
1093 this we forcefully override the inputContext whenever a password
1096 * WebView/WebHTMLView.mm:
1097 (-[WebHTMLView inputContext]):
1099 2007-11-12 John Sullivan <sullivan@apple.com>
1101 Reviewed by Tim Hatcher
1103 - speculative fix for <rdar://problem/5509989> CrashTracer: [USER] 1 crash in Safari at com.apple.WebKit:
1104 -[WebPDFView(FileInternal) _updatePreferencesSoon] + 56
1106 The crash is probably due to messaging a dealloc'ed dataSource ivar. The dataSource ivar isn't retained
1107 by this class, but should be. (It is retained by WebHTMLView, e.g.).
1109 * WebView/WebPDFView.mm:
1110 (-[WebPDFView dealloc]):
1111 release dataSource ivar
1112 (-[WebPDFView setDataSource:]):
1113 retain dataSource ivar
1115 2007-11-09 Tristan O'Tierney <tristan@apple.com>
1117 Reviewed by Timothy Hatcher.
1119 This patch is for the WebKit side of <rdar://problem/5591115>.
1120 We need a way to tell context menu navigations, such as "Open in New Window"
1121 to override any sort of browser preference for tab based navigation.
1123 * WebCoreSupport/WebChromeClient.mm:
1124 (WebChromeClient::createWindow):
1125 Pass up the new preferredType parameter as a string.
1127 2007-11-09 Timothy Hatcher <timothy@apple.com>
1131 <rdar://problem/5103720> REGRESSION: [WebView stringByEvaluatingJavaScriptFromString:] fails if "return" is used
1133 Extend the linked on or after check to every application when a script passed to
1134 stringByEvaluatingJavaScriptFromString: has a return statement. Before the check
1135 was limited to VitalSource Bookshelf, but other developers are running into this.
1137 * Misc/WebKitVersionChecks.h: Add the WEBKIT_FIRST_VERSION_WITHOUT_JAVASCRIPT_RETURN_QUIRK define.
1138 * WebView/WebDocumentLoaderMac.mm:
1139 (needsDataLoadWorkaround): Use WEBKIT_FIRST_VERSION_WITHOUT_ADOBE_INSTALLER_QUIRK sicne the
1140 WebKitLinkedOnOrAfter check here was about the Adobe installer, not VitalSource.
1141 * WebView/WebView.mm:
1142 (-[WebView stringByEvaluatingJavaScriptFromString:]): Remove the bundle ID check and use
1143 WEBKIT_FIRST_VERSION_WITHOUT_JAVASCRIPT_RETURN_QUIRK for the WebKitLinkedOnOrAfter call.
1145 2007-11-08 Kevin McCullough <kmccullough@apple.com>
1149 * WebCoreSupport/WebFrameLoaderClient.h:
1150 * WebCoreSupport/WebFrameLoaderClient.mm:
1151 (WebFrameLoaderClient::windowObjectCleared):
1153 2007-11-07 Darin Adler <darin@apple.com>
1157 - removed some unused WebCore bridge methods
1159 * WebCoreSupport/WebFrameBridge.mm: Removed issueTransposeCommand and overrideMediaType.
1161 * WebCoreSupport/WebFrameLoaderClient.mm:
1162 (WebFrameLoaderClient::overrideMediaType): Changed to call WebView directly instead of
1163 using the bridge object.
1165 2007-11-06 Mark Rowe <mrowe@apple.com>
1167 Rubber-stamped by Dave Kilzer.
1169 Move Mac files from WebKit into WebKit/mac.
1171 * Carbon: Copied from WebKit/Carbon.
1172 * ChangeLog: Copied from WebKit/ChangeLog.
1173 * ChangeLog-2002-12-03: Copied from WebKit/ChangeLog-2002-12-03.
1174 * ChangeLog-2006-02-09: Copied from WebKit/ChangeLog-2006-02-09.
1175 * ChangeLog-2007-10-14: Copied from WebKit/ChangeLog-2007-10-14.
1176 * Configurations: Copied from WebKit/Configurations.
1177 * DOM: Copied from WebKit/DOM.
1178 * DefaultDelegates: Copied from WebKit/DefaultDelegates.
1179 * ForwardingHeaders: Copied from WebKit/ForwardingHeaders.
1180 * History: Copied from WebKit/History.
1181 * Info.plist: Copied from WebKit/Info.plist.
1182 * MigrateHeaders.make: Copied from WebKit/MigrateHeaders.make.
1183 * Misc: Copied from WebKit/Misc.
1184 * Panels: Copied from WebKit/Panels.
1185 * Plugins: Copied from WebKit/Plugins.
1186 * PublicHeaderChangesFromTiger.txt: Copied from WebKit/PublicHeaderChangesFromTiger.txt.
1187 * Resources: Copied from WebKit/Resources.
1188 * WebCoreSupport: Copied from WebKit/WebCoreSupport.
1189 * WebInspector: Copied from WebKit/WebInspector.
1190 * WebKit.exp: Copied from WebKit/WebKit.exp.
1191 * WebKit.order: Copied from WebKit/WebKit.order.
1192 * WebKitPrefix.h: Copied from WebKit/WebKitPrefix.h.
1193 * WebView: Copied from WebKit/WebView.
1194 * icu: Copied from WebKit/icu.
1196 2007-11-06 Alexey Proskuryakov <ap@webkit.org>
1200 http://bugs.webkit.org/show_bug.cgi?id=15847
1201 Some editing cleanup
1203 No change in functionality.
1205 * WebView/WebHTMLView.mm:
1206 (-[WebHTMLView deleteToEndOfLine:]):
1207 (-[WebHTMLView deleteToEndOfParagraph:]):
1208 WebCore had a duplicate of the same logic already. We are passing a boundary value to
1209 a function that expects granularity, this may need to be straightened out in the future.
1211 2007-11-05 John Sullivan <sullivan@apple.com>
1213 * WebView/WebView.mm:
1214 (-[WebView _searchWithSpotlightFromMenu:]):
1216 Teeny style tweak to test svn access on other machine
1218 2007-11-05 John Sullivan <sullivan@apple.com>
1220 * WebView/WebView.mm:
1221 (-[WebView computedStyleForElement:pseudoElement:]):
1223 Teeny style tweak to test svn access
1225 2007-11-02 Tristan O'Tierney <tristan@apple.com>
1227 Reviewed by Darin Adler.
1229 * DefaultDelegates/WebDefaultUIDelegate.m:
1230 (-[WebDefaultUIDelegate webView:createWebViewWithRequest:windowFeatures:]):
1231 Forward the UI delegate to call webView:createWebViewWithRequest: if
1232 this method doesn't exist.
1234 * WebCoreSupport/WebFrameLoaderClient.mm:
1235 (WebFrameLoaderClient::dispatchCreatePage):
1236 * Plugins/WebBaseNetscapePluginView.mm:
1237 (-[WebBaseNetscapePluginView loadPluginRequest:]):
1238 * WebView/WebView.mm:
1239 (-[WebView _openNewWindowWithRequest:]):
1240 Revised to use new webView:createWebViewWithRequest:windowFeatures: callback.
1242 * WebCoreSupport/WebChromeClient.h:
1243 * WebCoreSupport/WebChromeClient.mm:
1244 (WebChromeClient::createWindow):
1245 Added a new createWindow that accepts 3 parameters, so we can pass up windowFeatures to the chrome.
1246 Removed createModalDialog to use new createWindow function.
1248 * WebView/WebUIDelegatePrivate.h:
1249 Added new webView:createWebViewWithRequest:windowFeatures: method.
1251 2007-11-05 Geoffrey Garen <ggaren@apple.com>
1253 Reviewed by Darin Adler.
1255 http://bugs.webkit.org/show_bug.cgi?id=15835
1257 Small adaptations to new KJS::List class.
1259 * ForwardingHeaders/kjs/value.h: Added.
1261 2007-11-03 David D. Kilzer <ddkilzer@webkit.org>
1263 Sort files(...); sections of Xcode project files.
1265 Rubber-stamped by Darin.
1267 * WebKit.xcodeproj/project.pbxproj:
1269 2007-11-02 Antti Koivisto <antti@apple.com>
1273 Add method to enable video composition.
1275 * WebCoreSupport/WebSystemInterface.m:
1276 (InitWebCoreSystemInterface):
1278 2007-11-02 Darin Adler <darin@apple.com>
1282 - fix problem I ran into while doing some testing on Mac for
1283 <rdar://problem/5530185> WebKit does not show <object>
1284 fallback content when both URL and MIME type is omitted
1286 I don't know how to reproduce this failure in DumpRenderTree, so there is no
1289 * Plugins/WebNullPluginView.h: Removed some unneeded declarations, including
1290 the didSendError local variable. Instead we just set the error to nil once
1292 * Plugins/WebNullPluginView.mm:
1293 (-[WebNullPluginView initWithFrame:error:DOMElement:]): Refactored so that
1294 the null plug-in image code is separate from the rest of the function and
1295 so that the whole thing is not inside an if statement. Also don't hold a
1296 reference to the DOM element if there is no error to report.
1297 (-[WebNullPluginView reportFailure]): Added. Does the actual delegate
1298 callback. Happens back at the top level of the run loop so it doesn't
1299 fire deep inside layout. Also wrote this so that it is guaranteed not to
1300 reenter and so that it can handle the case where the delegate destroys
1301 the world (including this object). NOTE: This is not a real, general
1302 solution to the problem of plug-ins that do work inside layout. We will need
1303 a more general fix that works for other plug-ins, and we'll track that with
1304 a separate bug report.
1305 (-[WebNullPluginView viewDidMoveToWindow]): Removed most of the code;
1306 changed so it just does a performSelector:afterDelay:0.
1308 2007-11-02 Mark Rowe <mrowe@apple.com>
1310 Reviewed by Darin Adler.
1312 Fix http://bugs.webkit.org/show_bug.cgi?id=15780
1313 Bug 15780: WebFrameLoaderClient: WebActionElementKey wrong if view is scrolled
1315 * WebCoreSupport/WebFrameLoaderClient.mm:
1316 (WebFrameLoaderClient::actionDictionary): Retrieve the mouse event coordinates
1317 in the page coordinate system rather than the client area coordinate system.
1319 2007-11-01 Dan Bernstein <mitz@apple.com>
1321 Reviewed by Oliver Hunt.
1323 - fix an assertion failure when Command-Tabbing out of Safari
1325 * WebView/WebHTMLView.mm:
1326 (-[WebHTMLView flagsChanged:]): Avoid passing key code 0 down to
1329 2007-11-01 Justin Garcia <justin.garcia@apple.com>
1331 Reviewed by Oliver Hunt.
1333 <rdar://problem/5195056> Huge plain text pastes are slow, time spent in ApplyStyleCommand::doApply
1335 No need to match style when pasting plain text, since the fragment we build for plain text
1336 won't have any style information on it.
1338 * WebView/WebHTMLView.mm:
1339 (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]): There's no
1340 longer a need to know whether this function chosePlaintext.
1341 (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
1342 (-[WebHTMLView _documentFragmentFromPasteboard:]):
1344 2007-10-31 Timothy Hatcher <timothy@apple.com>
1346 Reviewed by John Sullivan.
1348 Move the developer extras preference to WebPreferences.
1350 * WebView/WebPreferenceKeysPrivate.h: Add WebKitDeveloperExtrasEnabledPreferenceKey
1351 * WebView/WebPreferences.m:
1352 (+[WebPreferences initialize]): Initialize WebKitDeveloperExtrasEnabledPreferenceKey to NO.
1353 (-[WebPreferences developerExtrasEnabled]): Check DisableWebKitDeveloperExtras, WebKitDeveloperExtras
1354 and IncludeDebugMenu in addition to WebKitDeveloperExtrasEnabledPreferenceKey.
1355 (-[WebPreferences setDeveloperExtrasEnabled:]): Set WebKitDeveloperExtrasEnabledPreferenceKey.
1356 * WebView/WebPreferencesPrivate.h: Add developerExtrasEnabled and setDeveloperExtrasEnabled:.
1357 * WebView/WebView.mm:
1358 (+[WebView _developerExtrasEnabled]): Removed.
1359 (-[WebView _preferencesChangedNotification:]): Check the WebPreferences object for developerExtrasEnabled.
1360 * WebView/WebViewPrivate.h: Removed _developerExtrasEnabled.
1362 2007-10-30 David D. Kilzer <ddkilzer@webkit.org>
1364 Generated files missing from WebCore's Xcode project file
1365 <http://bugs.webkit.org/show_bug.cgi?id=15406>
1369 Added the following private header files to MigrateHeaders.make:
1371 - DOMCSSStyleSheetPrivate.h
1373 - DOMHTMLCollectionPrivate.h
1374 - DOMHTMLEmbedElementPrivate.h
1375 - DOMHTMLIFrameElementPrivate.h
1376 - DOMHTMLObjectElementPrivate.h
1377 - DOMHTMLSelectElementPrivate.h
1379 * MigrateHeaders.make:
1381 2007-10-29 Antti Koivisto <antti@apple.com>
1385 Some SPIs for media support.
1387 * WebCoreSupport/WebSystemInterface.m:
1388 (InitWebCoreSystemInterface):
1390 2007-10-29 Timothy Hatcher <timothy@apple.com>
1392 Reviewed by John Sullivan.
1394 Various semi-related changes:
1395 - A WebView can now be asked for it's WebInspector. There is one
1396 WebInspector per WebView.
1397 - Refactor the WebInspector class and move obsolete methods to
1399 - Add new WebInspector methods to show, hide and show the
1400 console/timeline panels.
1401 - Add an isDisabled method to WebCache.
1402 - Allow WebLocalizableStrings.h to be used in C files.
1404 * Misc/WebCache.h: Add isDisabled.
1406 (+[WebCache isDisabled]): New method.
1408 * Misc/WebLocalizableStrings.h: Changes to allow use in plain C files.
1410 * WebCoreSupport/WebInspectorClient.mm:
1411 (-[WebInspectorWindowController showWindow:]): Call super if already visible
1412 so the window will be ordered front.
1413 (-[WebInspectorWindowController showWebInspector:]): Method used by menu items,
1414 so they are enabled and work when the Inspector window is key.
1415 (-[WebInspectorWindowController showErrorConsole:]): Ditto.
1416 (-[WebInspectorWindowController showNetworkTimeline:]): Ditto.
1418 * WebInspector/WebInspector.h: Add and remove methods.
1419 * WebInspector/WebInspector.mm:
1420 (-[WebInspector webViewClosed]): Called when the WebView is closed/dealloced.
1421 Clears the _webView pointer.
1422 (-[WebInspector show:]): Calls thru to the Page's InspectorController.
1423 (-[WebInspector showConsole:]): Ditto.
1424 (-[WebInspector showTimeline:]): Ditto.
1425 (-[WebInspector close:]): Ditto.
1426 (-[WebInspector attach:]): Ditto.
1427 (-[WebInspector detach:]): Ditto.
1428 (+[WebInspector sharedWebInspector]): Moved to the obsolete category.
1429 (+[WebInspector webInspector]): Ditto.
1430 (-[WebInspector setWebFrame:]): Ditto.
1431 (-[WebInspector window]): Ditto.
1432 (-[WebInspector showWindow:]): Ditto.
1434 * WebView/WebView.mm:
1435 (-[WebViewPrivate dealloc]): Release the WebInspector.
1436 (-[WebView _close]): Call webViewClosed on the WebInspector.
1437 (-[WebView inspector]): Create a WebInspector if needed and return it.
1438 * WebView/WebViewPrivate.h: Add the inspector method.
1440 2007-10-30 Adele Peterson <adele@apple.com>
1444 WebKit part of fix for http://bugs.webkit.org/show_bug.cgi?id=10577
1445 <rdar://problem/5103625> REGRESSION: Caps lock icon should show in password fields
1447 * WebView/WebHTMLView.mm:
1448 (-[WebHTMLView flagsChanged:]): Call capsLockStateMayHaveChanged so WebCore knows it may have to update a password field.
1449 (+[WebHTMLView _postFlagsChangedEvent:]): Added a comment with a Radar number for why this isn't just in flagsChanged.
1450 (-[WebHTMLView scrollWheel:]): Instead of calling the next responder explicitly, we can just call super, which will take care of this.
1452 2007-10-27 Mark Ambachtsheer <mark.a@apple.com>
1456 Fix for bug 15710, When QD plugins draw to an offscreen bitmap and the plugin is not at
1457 (0, 0) the clipping rectangle is not correct.
1458 Added the origin to the window clip rectangle coordinates to account for plugins that
1459 don't originate at (0,0); affects code for offscreen GWorlds only.
1461 * Plugins/WebBaseNetscapePluginView.mm:
1462 (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1464 2007-10-26 Adele Peterson <adele@apple.com>
1468 Adding WebKitSystemInterface support for the caps lock indicator
1470 * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
1472 2007-10-25 David Hyatt <hyatt@apple.com>
1474 Fix for bug 15672, backgrounds don't tile properly inside transforms. This patch fixes tiling
1475 of backgrounds inside CSS transforms and also of HTML content with background images inside SVG
1478 Reviewed by aroben and mmitz
1480 * WebCoreSupport/WebSystemInterface.m:
1481 (InitWebCoreSystemInterface):
1482 * WebKit.xcodeproj/project.pbxproj:
1484 2007-10-25 John Sullivan <sullivan@apple.com>
1486 Reviewed by Tim Hatcher
1488 Removed the support for toggling whether WebKit uses the 10.5 PDFKit improvements. Now it
1489 always does, when available.
1491 * WebView/WebPreferencesPrivate.h:
1492 removed _usePDFPreviewView and _setUsePDFPreviewView:. Note that these were guarded with
1493 a comment that says that they can be removed when no longer needed. That time is now.
1495 * WebView/WebPreferences.m:
1496 (+[WebPreferences initialize]):
1497 removed WebKitUsePDFPreviewViewPreferenceKey
1498 (-[WebPreferences _usePDFPreviewView]):
1500 (-[WebPreferences _setUsePDFPreviewView:]):
1503 * WebView/WebPDFView.mm:
1504 (-[WebPDFView initWithFrame:]):
1505 don't check _usePDFPreviewView
1507 * WebView/WebPreferenceKeysPrivate.h:
1508 removed WebKitUsePDFPreviewViewPreferenceKey
1510 2007-10-24 Timothy Hatcher <timothy@apple.com>
1512 Reviewed by Mark Rowe.
1514 <rdar://problem/5069711> OpenSource version of libWebKitSystemInterface.a is Tiger only, causes issues if used on Leopard
1516 Use the WebKitSystemInterface that matches the system version.
1518 * Configurations/DebugRelease.xcconfig:
1519 * WebKit.xcodeproj/project.pbxproj:
1521 2007-10-24 Brady Eidson <beidson@apple.com>
1525 <rdar://problem/5554130> DatabaseTracker.o has a global initializer
1527 * Misc/WebDatabaseManager.mm:
1528 (WebKitSetWebDatabasesPathIfNecessary): Call the member function instead of a static one
1530 2007-10-23 Mark Rowe <mrowe@apple.com>
1532 Build fix for Eric's build fix in r26916.
1534 * MigrateHeaders.make:
1536 2007-10-22 Eric Seidel <eric@webkit.org>
1540 * MigrateHeaders.make: copy over font-face related DOM headers
1542 2007-10-22 Andrew Wellington <proton@wiretapped.net>
1544 Reviewed by Mark Rowe.
1546 Fix for local database support after r26879
1547 Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
1549 * Configurations/WebKit.xcconfig:
1551 2007-10-19 Brady Eidson <beidson@apple.com>
1553 Reviewed by Tim Hatcher
1555 Added support for Chrome prompts required by the Storage API
1556 Added support API for future managing of databases from the WebKit client
1557 Added preference and initialization for the databases path
1559 * Misc/WebDatabaseManager.h: Added. WebDatabaseManager is how a WebKit application can list and
1560 remove the current available databases
1561 * Misc/WebDatabaseManager.mm: Added.
1562 (+[WebDatabaseManager origins]):
1563 (+[WebDatabaseManager databasesWithOrigin:]):
1564 (+[WebDatabaseManager deleteAllDatabases]):
1565 (+[WebDatabaseManager deleteAllDatabasesWithOrigin:]):
1566 (+[WebDatabaseManager deleteDatabaseWithOrigin:named:]):
1567 (WebKitSetWebDatabasesPathIfNecessary): Setup the database path
1568 * Misc/WebDatabaseManagerPrivate.h: Added.
1570 * WebCoreSupport/WebChromeClient.h: Support for calling the delegate to run the prompt for
1571 an origin exceeding its size limit
1572 * WebCoreSupport/WebChromeClient.mm:
1573 (WebChromeClient::runDatabaseSizeLimitPrompt):
1574 * WebKit.xcodeproj/project.pbxproj:
1575 * WebView/WebUIDelegate.h:
1577 * WebView/WebView.mm:
1578 (-[WebView _commonInitializationWithFrameName:groupName:]): Setup the database path
1579 * WebView/WebViewInternal.h:
1581 2007-10-19 John Sullivan <sullivan@apple.com>
1583 Reviewed by Tim Hatcher
1585 - fixed <rdar://problem/5540325> REGRESSION (2.0.4-3): History menu looks odd after clearing history
1587 * History/WebHistory.mm:
1588 (-[WebHistoryPrivate removeAllItems]):
1589 This was fallout from r25275. We need to clear the orderedLastVisitedDays cache here, in addition
1590 to the other places where it's cleared.
1592 2007-10-18 Dan Bernstein <mitz@apple.com>
1596 * WebView/WebDataSource.mm:
1597 (-[WebDataSource _MIMETypeOfResponse:]):
1599 2007-10-18 Dan Bernstein <mitz@apple.com>
1601 Reviewed by Adam Roben.
1603 - fix <rdar://problem/5313523>
1604 REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
1606 * WebCoreSupport/WebFrameLoaderClient.mm:
1607 (WebFrameLoaderClient::makeDocumentView): Changed to use _responseMIMEType.
1608 * WebView/WebDataSource.mm:
1609 (-[WebDataSource _MIMETypeOfResponse:]): Added. Works around
1610 <rdar://problem/5321972> by testing for the case of an NSHTTPURLResponse
1611 with a MIMEType of application/octet-stream and a Content-Type header
1612 starting with text/plain and returning text/plain as the MIME type in
1614 (-[WebDataSource _responseMIMEType]): Added. Used to get the correct
1616 (-[WebDataSource _isDocumentHTML]): Changed to use _responseMIMEType.
1617 (-[WebDataSource _makeRepresentation]): Ditto.
1618 (-[WebDataSource mainResource]): Ditto.
1619 (-[WebDataSource subresources]): Changed to use _MIMETypeOfResponse and
1620 pass the MIME type explicitly.
1621 (-[WebDataSource subresourceForURL:]): Ditto.
1622 * WebView/WebDataSourcePrivate.h:
1623 * WebView/WebFrameView.mm:
1624 (-[WebFrameView _makeDocumentViewForDataSource:]): Changed to use
1626 * WebView/WebResource.mm:
1627 (-[WebResource _initWithData:URL:response:MIMEType:]): Changed this
1628 method to take a MIME type instead of extracting it from the response,
1629 so that WebDataSource could pass the correct MIME type.
1630 * WebView/WebResourcePrivate.h:
1632 2007-10-17 Darin Adler <darin@apple.com>
1634 Reviewed by Mark Rowe.
1636 - fix <rdar://problem/5183775> Uninitialized memory in -[WebDynamicScrollBarsView updateScrollers]
1638 * WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]):
1639 Change code path so it doesn't dispatch a method that returns an NSSize passing a nil object.
1640 It's safe to do that for functions that return integers or pointers, but not structures.
1642 2007-10-16 David Kilzer <ddkilzer@apple.com>
1644 Reviewed by Timothy.
1646 <rdar://problem/5544354> Wrong delegate method called in
1647 WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad()
1649 * WebCoreSupport/WebFrameLoaderClient.mm:
1650 (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): Fixed selector name.
1652 2007-10-16 Darin Adler <darin@apple.com>
1656 - moved transpose command implementation into WebCore
1658 * WebView/WebHTMLView.mm: Removed transpose: and replaced it with standard WebCore forwarding.
1660 2007-10-16 Darin Adler <darin@apple.com>
1662 Reviewed by Maciej and Geoff (and looked over by Eric).
1664 - http://bugs.webkit.org/show_bug.cgi?id=15519
1665 eliminate use of <ctype.h> for processing ASCII
1667 * ForwardingHeaders/wtf/ASCIICType.h: Added.
1668 * ForwardingHeaders/wtf/DisallowCType.h: Added.
1670 * WebKitPrefix.h: Include DisallowCType.h.
1672 * Misc/WebNSURLExtras.mm: (-[NSURL _web_URLWithLowercasedScheme]): Use toASCIILower.
1673 * WebView/WebHTMLView.mm:
1674 (-[WebHTMLView callWebCoreCommand:]): Use toASCIIUpper.
1675 (-[WebTextCompleteController filterKeyDown:]): Add a list of specific character codes,
1676 instead of using ispunct.
1678 2007-10-16 John Sullivan <sullivan@apple.com>
1680 Reviewed by Adam Roben
1682 Cleaned up localizable strings
1684 * English.lproj/Localizable.strings:
1686 * StringsNotToBeLocalized.txt:
1688 * WebKit.xcodeproj/project.pbxproj:
1689 StringsNotToBeLocalized.txt recently moved but project file wasn't updated to match; now it is
1691 2007-10-15 Kevin Decker <kdecker@apple.com>
1693 Reviewed by Darin Adler.
1695 Fixed: <rdar://problem/5520541> REGRESSION: Broken image when forwarding certain email on Tiger
1697 * WebCoreSupport/WebFrameBridge.mm: The problem was that we were loading Mail's WebKit plug-in
1698 too soon, which borked some necessary housekeeping on behalf of Mail. The fix is to add a quirk
1699 that treats Tiger Mail's WebKit plug-in like a Netscape plug-in, thus ensuring the plug-in will
1700 load during first layout and not attach time. For this plug-in, loading at first layout is
1701 expected and is consistent with Safari 2 behavior.
1703 2007-10-15 John Sullivan <sullivan@apple.com>
1705 Reviewed by Geoff Garen
1707 Replaced NS_DURING/NS_HANDLER with @try/@catch throughout WebKit
1709 I made the following changes:
1710 - replaced NS_DURING with @try, and added opening brace if there wasn't one
1711 - replaced NS_HANDLER with @catch (NSException *localException), and added braces if there weren't any
1712 - removed NS_ENDHANDLER, and added a closing brace if there wasn't one
1713 - in a couple of places, fixed indentation therein
1715 * Misc/WebIconDatabase.mm:
1716 (objectFromPathForKey):
1717 * WebView/WebHTMLView.mm:
1718 (-[WebHTMLView drawSingleRect:]):
1719 (-[WebHTMLView beginDocument]):
1720 (-[WebHTMLView deleteToMark:]):
1721 * WebView/WebView.mm:
1722 (-[WebView initWithCoder:]):
1724 == Rolled over to ChangeLog-2007-10-14 ==