Remove -[WebScriptDebugger hitStatement:sourceId:line:]
[WebKit-https.git] / WebKit / mac / ChangeLog
1 2008-03-05  Adam Roben  <aroben@apple.com>
2
3         Remove -[WebScriptDebugger hitStatement:sourceId:line:]
4
5         Reviewed by Kevin M.
6
7         * WebView/WebCoreScriptDebuggerImp.mm:
8         (WebCoreScriptDebuggerImp::atStatement): Moved code here from
9         -[WebScriptDebugger hitStatement:sourceId:line:].
10         * WebView/WebScriptDebugDelegate.mm:
11         (-[WebScriptDebugger webFrame]): Added.
12         * WebView/WebScriptDebugDelegatePrivate.h:
13
14 2008-03-05  Adam Roben  <aroben@apple.com>
15
16         Remove WebCoreScriptDebugger
17
18         Reviewed by Kevin M.
19
20         * WebView/WebCoreScriptDebugger.h: Removed.
21         * WebView/WebCoreScriptDebugger.mm: Removed.
22         * WebView/WebCoreScriptDebuggerImp.h: Replaced WebCoreScriptDebugger
23         with WebScriptDebugger.
24         * WebView/WebCoreScriptDebuggerImp.mm: Ditto, and replaced [m_debugger
25         delegate] with just m_debugger.
26         (toNSString): Moved here from WebCoreScriptDebugger.mm.
27         (toNSURL): Ditto.
28         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp):
29         (WebCoreScriptDebuggerImp::sourceParsed):
30         (WebCoreScriptDebuggerImp::callEvent):
31         (WebCoreScriptDebuggerImp::atStatement):
32         (WebCoreScriptDebuggerImp::returnEvent):
33         (WebCoreScriptDebuggerImp::exception):
34         * WebView/WebScriptDebugDelegate.mm:
35         (-[WebScriptDebugger initWithWebFrame:]): _debugger now holds a
36         WebCoreScriptDebuggerImp, so initialize it properly.
37         * WebView/WebScriptDebugDelegatePrivate.h: Changed _debugger to hold a
38         WebCoreScriptDebuggerImp.
39
40 2008-03-05  Adam Roben  <aroben@apple.com>
41
42         Move WebCoreScriptDebuggerImp to its own source files
43
44         Also changed WebCoreScriptDebuggerImp coding style to match our style
45         guidelines.
46
47         Reviewed by Kevin M.
48
49         * WebView/WebCoreScriptDebugger.h: Added declaration of toNSURL
50         function.
51         * WebView/WebCoreScriptDebugger.mm: Removed WebCoreScriptDebuggerImp
52         implementation.
53         (toNSURL): Made no longer static.
54         * WebView/WebCoreScriptDebuggerImp.h: Added.
55         * WebView/WebCoreScriptDebuggerImp.mm: Added. Code was moved here from
56         WebCoreScriptDebugger.mm and cleaned up.
57         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp):
58         (WebCoreScriptDebuggerImp::sourceParsed):
59         (WebCoreScriptDebuggerImp::callEvent):
60         (WebCoreScriptDebuggerImp::atStatement):
61         (WebCoreScriptDebuggerImp::returnEvent):
62         (WebCoreScriptDebuggerImp::exception):
63
64 2008-03-05  Adam Roben  <aroben@apple.com>
65
66         Move -_enterFrame and -_leaveFrame from WebCoreScriptDebugger to WebScriptDebugger
67
68         Reviewed by Kevin M.
69
70         * WebView/WebCoreScriptDebugger.h:
71           - Removed newFrameWithGlobalObject:caller:state: from
72             WebScriptDebugger protocol
73           - Added enterFrame: and leaveFrame: to WebScriptDebugger protocol
74           - Removed _current ivar from WebCoreScriptDebugger
75         * WebView/WebCoreScriptDebugger.mm:
76         (WebCoreScriptDebuggerImp::callEvent): Changed to call enterFrame on
77         the delegate.
78         (WebCoreScriptDebuggerImp::returnEvent): Ditto for leaveFrame.
79         * WebView/WebScriptDebugDelegate.mm:
80         (-[WebScriptDebugger dealloc]): Added code to release _current.
81         (-[WebScriptDebugger enterFrame:]): Added. Code came from
82         WebCoreScriptDebugger.
83         (-[WebScriptDebugger leaveFrame]): Ditto.
84         * WebView/WebScriptDebugDelegatePrivate.h: Added _current ivar.
85
86 2008-03-05  Adam Roben  <aroben@apple.com>
87
88         Remove WebCoreScriptCallFrame
89
90         Reviewed by Tim.
91
92         * WebView/WebCoreScriptDebugger.h:
93           - Replaced WebCoreScriptCallFrame with WebScriptCallFrame
94           - Replaced -newWrapperForFrame: with
95             -newFrameWithGlobalObject:caller:state:
96           - Removed WebCoreScriptCallFrame interface.
97         * WebView/WebCoreScriptDebugger.mm: Replaced WebCoreScriptCallFrame
98         with WebScriptCallFrame.
99         (-[WebCoreScriptDebugger _enterFrame:]): Changed to call
100         -newFrameWithGlobalObject:caller:state.
101         (-[WebCoreScriptDebugger _leaveFrame]):
102         * WebView/WebScriptDebugDelegate.h: Changed WebScriptCallFrame's
103         _private ivar to be of type WebScriptCallFramePrivate*.
104         * WebView/WebScriptDebugDelegate.mm:
105           - Replaced WebCoreScriptCallFrame with WebScriptCallFrame
106           - Added WebScriptCallFramePrivate
107         (-[WebScriptDebugger enteredFrame:sourceId:line:]):
108         (-[WebScriptDebugger hitStatement:sourceId:line:]):
109         (-[WebScriptDebugger leavingFrame:sourceId:line:]):
110         (-[WebScriptDebugger exceptionRaised:sourceId:line:]):
111         (-[WebScriptCallFramePrivate dealloc]): Added.
112         (-[WebScriptCallFrame _initWithGlobalObject:caller:state:]): Added.
113         Code came from WebCoreScriptCallFrame.
114         (-[WebScriptCallFrame dealloc]): Added a call to release the _private
115         ivar.
116         (-[WebScriptCallFrame _convertValueToObjcValue:]): Replaced calls to
117         _private with direct access of _private's ivars.
118         (-[WebScriptCallFrame caller]): Ditto.
119         (-[WebScriptCallFrame scopeChain]): Ditto.
120         (-[WebScriptCallFrame evaluateWebScript:]): Ditto.
121
122 2008-03-05  Adam Roben  <aroben@apple.com>
123
124         Move -_convertValueToObjcValue to WebScriptCallFrame
125
126         Reviewed by Darin.
127
128         * WebView/WebCoreScriptDebugger.h: Removed declaration of
129         -_convertValueToObjcValue.
130         * WebView/WebCoreScriptDebugger.mm: Removed -_convertValueToObjcValue.
131         * WebView/WebScriptDebugDelegate.mm:
132         (-[WebScriptCallFrame _convertValueToObjcValue:]): Added. Code came
133         from -[WebCoreScriptCallFrame _convertValueToObjcValue].
134         (-[WebScriptCallFrame scopeChain]): Changed to call
135         -_convertValueToObjcValue on self instead of _private.
136         (-[WebScriptCallFrame exception]): Ditto.
137         (-[WebScriptCallFrame evaluateWebScript:]): Ditto.
138
139 2008-03-05  Adam Roben  <aroben@apple.com>
140
141         Move -exception and -evaluateWebScript: to WebScriptCallFrame
142
143         Reviewed by Darin.
144
145         * WebView/WebCoreScriptDebugger.h: Removed declarations of -exception
146         and -evaluateWebScript:.
147         * WebView/WebCoreScriptDebugger.mm: Removed -exception and
148         -evaluateWebScript:.
149         * WebView/WebScriptDebugDelegate.mm:
150         (-[WebScriptCallFrame exception]): Added. Code came from
151         -[WebCoreScriptCallFrame exception].
152         (-[WebScriptCallFrame evaluateWebScript:]): Added. Code came from
153         -[WebCoreScriptCallFrame evaluateWebScript:].
154
155 2008-03-05  Adam Roben  <aroben@apple.com>
156
157         Move -scopeChain to WebScriptCallFrame
158
159         Reviewed by Darin.
160
161         * WebView/WebCoreScriptDebugger.h:
162           - Added declarations of -globalObject and -_convertValueToObjcValue:
163             to WebCoreScriptCallFrame
164           - Removed declaration of -scopeChain.
165         * WebView/WebCoreScriptDebugger.mm: Moved -_convertValueToObjcValue
166         within the main WebCoreScriptCallFrame implementation.
167         (-[WebCoreScriptCallFrame globalObject]): Added.
168         * WebView/WebScriptDebugDelegate.mm:
169         (-[WebScriptCallFrame scopeChain]): Added. Code came from
170         -[WebCoreScriptCallFrame scopeChain].
171
172 2008-03-05  Adam Roben  <aroben@apple.com>
173
174         Move -functionName from WebCoreScriptCallFrame to WebScriptCallFrame
175
176         Reviewed by Darin.
177
178         * WebView/WebCoreScriptDebugger.h:
179           - Removed #else case of #ifdef __cplusplus since this file is only
180             ever used by C++ Objective-C files
181           - Removed 'using KJS::ExecState' statement since we prefer not to
182             have using statements in header files
183           - Consequently prefixed uses of ExecState with KJS::
184           - Added declaration of toNSString method that takes a const
185             UString&
186           - Added declaration of -[WebCoreScriptCallFrame state]
187           - Removed declaration of -[WebCoreScriptCallFrame functionName]
188         * WebView/WebCoreScriptDebugger.mm:
189         (toNSString): Made this no longer static.
190         (-[WebCoreScriptCallFrame state]): Added.
191         * WebView/WebScriptDebugDelegate.mm:
192         (-[WebScriptCallFrame functionName]): Added. Code came from
193         -[WebCoreScriptCallFrame functionName], though I changed some nested
194         ifs into early returns.
195
196 2008-03-05  Adam Roben  <aroben@apple.com>
197
198         Move WebCoreScriptDebugger to WebKit
199
200         Reviewed by Darin.
201
202         * WebView/WebCoreScriptDebugger.h: Renamed from WebCore/page/mac/WebCoreScriptDebugger.h.
203         * WebView/WebCoreScriptDebugger.mm: Renamed from WebCore/page/mac/WebCoreScriptDebugger.mm.
204         (toNSString):
205         (toNSURL):
206         (WebCoreScriptDebuggerImp::WebCoreScriptDebuggerImp):
207         (WebCoreScriptDebuggerImp::sourceParsed):
208         (WebCoreScriptDebuggerImp::callEvent):
209         (WebCoreScriptDebuggerImp::atStatement):
210         (WebCoreScriptDebuggerImp::returnEvent):
211         (WebCoreScriptDebuggerImp::exception):
212         (+[WebCoreScriptDebugger initialize]):
213         (-[WebCoreScriptDebugger initWithDelegate:]):
214         (-[WebCoreScriptDebugger dealloc]):
215         (-[WebCoreScriptDebugger finalize]):
216         (-[WebCoreScriptDebugger delegate]):
217         (-[WebCoreScriptDebugger _enterFrame:]):
218         (-[WebCoreScriptDebugger _leaveFrame]):
219         (-[WebCoreScriptCallFrame _initWithGlobalObject:caller:state:]):
220         (-[WebCoreScriptCallFrame _setWrapper:]):
221         (-[WebCoreScriptCallFrame _convertValueToObjcValue:]):
222         (-[WebCoreScriptCallFrame dealloc]):
223         (-[WebCoreScriptCallFrame wrapper]):
224         (-[WebCoreScriptCallFrame caller]):
225         (-[WebCoreScriptCallFrame scopeChain]):
226         (-[WebCoreScriptCallFrame functionName]):
227         (-[WebCoreScriptCallFrame exception]):
228         (-[WebCoreScriptCallFrame evaluateWebScript:]):
229         * WebView/WebScriptDebugDelegate.mm: Updated header path.
230         * WebView/WebScriptDebugDelegatePrivate.h: Ditto.
231
232 2008-03-05  Anders Carlsson  <andersca@apple.com>
233
234         Reviewed by Geoff.
235
236         Include file changes.
237         
238         * Plugins/WebBaseNetscapePluginView.mm:
239         * Plugins/WebNetscapePluginPackage.m:
240
241 2008-03-04  Timothy Hatcher  <timothy@apple.com>
242
243         Reviewed by Darin Adler.
244
245         <rdar://problem/5720160> Browser windows "do nothing" while modal
246         dialog or menu is up due to run loop modes (or while scrolling)
247
248         Add new API that lets a WebView be scheduled with multiple runloops and modes.
249         This lets loading continue when in a nested runloop or in a different mode.
250
251         * Misc/WebKitVersionChecks.h: Add a new version define:
252         WEBKIT_FIRST_VERSION_WITH_LOADING_DURING_COMMON_RUNLOOP_MODES.
253         * WebView/WebView.mm:
254         (-[WebView _commonInitializationWithFrameName:groupName:]): Schedule in the main runloop and with
255         the default runloop mode if we are linked on an earlier WebKit version, use common modes otherwise.
256         (-[WebView scheduleInRunLoop:forMode:]): New API, that calls through to Page.
257         (-[WebView unscheduleFromRunLoop:forMode:]): Ditto.
258         * WebView/WebViewPrivate.h: Add the new pending API methods.
259
260 2008-03-04  Anders Carlsson  <andersca@apple.com>
261
262         Reviewed by Darin.
263
264         Fix crash that happens when trying to load a page with a Java applet.
265         
266         * WebCoreSupport/WebFrameLoaderClient.mm:
267         Don't release the names and values array - the kit method returns an autoreleased array.
268
269 2008-03-04  Darin Adler  <darin@apple.com>
270
271         Reviewed by Adam.
272
273         - fix 200+ failing regression tests
274         - fix http://bugs.webkit.org/show_bug.cgi?id=17668
275           Vertical scrollbar at slashdot.org is randomly not shown
276
277         * WebCoreSupport/WebFrameLoaderClient.mm:
278         (WebFrameLoaderClient::transitionToCommittedForNewPage): Changed the refcounting
279         code here to exactly match the way it was before it was moved from WebCore. I had
280         introduced a storage leak and that was causing problems with scroll bars!
281
282 2008-03-04  Darin Adler  <darin@apple.com>
283
284         Reviewed by Adam.
285
286         - remove WebCoreFrameBridge reapplyStyles method
287
288         * WebView/WebHTMLView.mm:
289         (-[WebHTMLView reapplyStyles]): Moved code to reapply styles here from the bridge.
290
291 2008-03-04  Darin Adler  <darin@apple.com>
292
293         Reviewed by Adam.
294
295         - eliminate WebCoreFrameBridge createFrameViewWithNSView
296
297         * WebCoreSupport/WebFrameLoaderClient.mm:
298         (WebFrameLoaderClient::transitionToCommittedForNewPage):
299         Moved code here from createFrameViewWithNSView.
300
301 2008-03-04  Darin Adler  <darin@apple.com>
302
303         Reviewed by Adam.
304
305         - removed WebCoreFrameBridge scrollOverflowInDirection
306
307         * WebView/WebFrameView.mm:
308         (-[WebFrameView _scrollOverflowInDirection:granularity:]): Changed to call
309         EventHandler directly instead of using the bridge.
310         (-[WebFrameView scrollToBeginningOfDocument:]): Updated to use WebCore enums instead
311         of the ones from the bridge.
312         (-[WebFrameView scrollToEndOfDocument:]): Ditto.
313         (-[WebFrameView _pageVertically:]): Ditto.
314         (-[WebFrameView _pageHorizontally:]): Ditto.
315         (-[WebFrameView _scrollLineVertically:]): Ditto.
316         (-[WebFrameView _scrollLineHorizontally:]): Ditto.
317
318 2008-03-04  Darin Adler  <darin@apple.com>
319
320         Reviewed by Adam.
321
322         - remove WebCoreFrameBridge installInFrame: method
323
324         * WebCoreSupport/WebFrameLoaderClient.mm:
325         (WebFrameLoaderClient::transitionToCommittedForNewPage): Call
326         -[WebFrameView _install] instead of -[WebCoreFrameBridge installInFrame:].
327         * WebView/WebFrameView.mm:
328         (-[WebFrameView _install]): Added. Has code from -[WebCoreFrameBridge installInFrame:].
329         (-[WebFrameView _setCustomScrollViewClass:]): Used early return idiom so the entire
330         method isn't nested inside an if statement. Call
331         -[WebFrameView _install] instead of -[WebCoreFrameBridge installInFrame:].
332         * WebView/WebFrameViewInternal.h: Added declaration of _install method so it can be
333         used in WebFrameLoaderClient.mm.
334
335 2008-03-04  Darin Adler  <darin@apple.com>
336
337         Reviewed by Adam.
338
339         - remove WebCoreFrameBridge window method
340
341         * WebCoreSupport/WebFrameBridge.mm: Removed window method.
342
343 2008-03-04  Darin Adler  <darin@apple.com>
344
345         Reviewed by Adam.
346
347         - move code from WebFrameBridge into WebFrameLoaderClient
348
349         * WebCoreSupport/WebFrameBridge.h: Removed unused fields, changed frame name parameters
350         to use WebCore::String instead of NSString, add initSubframeWithOwnerElement declaration,
351         removed viewForPluginWithFrame, viewForJavaAppletWithFrame, createChildFrameNamed,
352         redirectDataToPlugin, determineObjectFromMIMEType, and windowObjectCleared methods.
353         * WebCoreSupport/WebFrameBridge.mm:
354         (-[WebFrameBridge finishInitializingWithPage:frameName:WebCore::frameView:ownerElement:]):
355         Changed to use WebCore::String.
356         (-[WebFrameBridge initMainFrameWithPage:frameName:WebCore::frameView:]): Ditto.
357         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:WebCore::frameView:]): Ditto.
358
359         * WebCoreSupport/WebFrameLoaderClient.mm:
360         (WebFrameLoaderClient::setOriginalURLForDownload): Removed some dead code I found here
361         and added a FIXME.
362         (WebFrameLoaderClient::createFrame): Moved the code from WebFrameBridge here.
363         (WebFrameLoaderClient::objectContentType): Ditto.
364         (parameterValue): Added.  Helper function, based on code originally in WebFrameBridge.
365         (pluginView): Ditto.
366         (WebFrameLoaderClient::createPlugin): Moved the code from WebFrameBridge here.
367
368 2008-03-04  Darin Adler  <darin@apple.com>
369
370         Reviewed by Adam.
371
372         - remove -[WebCoreFrameBridge dashboardRegionsChanged:]
373
374         * WebCoreSupport/WebChromeClient.h:
375         * WebCoreSupport/WebChromeClient.mm:
376         (WebChromeClient::dashboardRegionsChanged): Moved code here from the bridge.
377         The WebCore side now calls this only when there's an actual change.
378         * WebCoreSupport/WebFrameBridge.h: Removed lastDashboardRegions.
379         * WebCoreSupport/WebFrameBridge.mm:
380         (-[WebFrameBridge dealloc]): Removed code to release lastDashboardRegions.
381         Removed _compareDashboardRegions: and dashboardRegionsChanged: methods.
382
383 2008-03-04  Darin Adler  <darin@apple.com>
384
385         Reviewed by Adam.
386
387         - remove WebCoreFrameBridge issuePasteComand method
388
389         * WebCoreSupport/WebFrameBridge.mm: Removed issuePasteCommand method.
390         * WebView/WebHTMLViewInternal.h: Removed declaration of paste: method.
391
392 2008-03-03  Darin Adler  <darin@apple.com>
393
394         Reviewed by Adam.
395
396         - some "cleanup" on the path to removing WebCoreFrameBridge
397
398         * Storage/WebDatabaseManager.mm: Tweak includes.
399         * Storage/WebDatabaseTrackerClient.mm: Ditto.
400         * Storage/WebSecurityOrigin.mm: Ditto.
401         * Storage/WebSecurityOriginInternal.h: Ditto.
402
403         * WebView/WebFrame.mm:
404         (core): Changed to get rid of the requirement that WebKitEditableLinkBehavior exactly
405         match WebCore::EditableLinkBehavior.
406         * WebView/WebFrameInternal.h: Removed unused kit function.
407
408         * WebView/WebHTMLView.mm: Moved WebHTMLViewPrivate class in here.
409         * WebView/WebHTMLViewInternal.h: Moved WebHTMLVewPrivate class out of here.
410         * WebView/WebHTMLViewPrivate.h: Tweaked formatting and removed some unneeded declarations.
411
412         * WebView/WebPreferencesPrivate.h: Removed a no-longer-needed comment.
413
414 2008-03-01  Mark Rowe  <mrowe@apple.com>
415
416         Reviewed by Tim Hatcher.
417
418         Update Xcode configuration to support building debug and release from the mysterious future.
419
420         * Configurations/DebugRelease.xcconfig:
421
422 2008-02-29  Mark Rowe  <mrowe@apple.com>
423
424         Reviewed by Anders Carlsson.
425
426         Replace use of WKPathFromFont with implementation in terms of public API.
427
428         * WebCoreSupport/WebSystemInterface.m:
429         (InitWebCoreSystemInterface): Remove unused symbol.
430
431 2008-02-29  Mark Rowe  <mrowe@apple.com>
432
433         Reviewed by Oliver Hunt.
434
435         Fix spelling of "request" in name of WKNSURLProtocolClassForRequest.
436
437         * Misc/WebNSURLExtras.mm:
438         (-[NSURL _webkit_canonicalize]):
439         * WebKit.order:
440
441 2008-02-29  Mark Rowe  <mrowe@apple.com>
442
443         Reviewed by Oliver Hunt.
444
445         Don't use WKSupportsMultipartXMixedReplace on Leopard as multipart/x-mixed-replace is always handled by NSURLRequest.
446
447         * WebCoreSupport/WebSystemInterface.m:
448         (InitWebCoreSystemInterface):
449
450 2008-02-29  Mark Rowe  <mrowe@apple.com>
451
452         Reviewed by Oliver Hunt.
453
454         Remove obsolete code that had been left intact to support users running WebKit with older versions of Safari.
455
456         * Misc/WebNSViewExtras.m:  Remove _web_superviewOfClass:stoppingAtClass:.
457         * Misc/WebNSWindowExtras.m:  Remove _webkit_displayThrottledWindows.
458         * Misc/WebSearchableTextView.m:  Remove selectionImageForcingWhiteText:.
459         * WebCoreSupport/WebImageRendererFactory.m:  Update comment to mention the last version of Safari that
460         requires this class.
461         * WebInspector/WebInspector.mm:  Remove sharedWebInspector and update comments to mention the last version
462         of Safari that calls other obsolete methods.
463         * WebView/WebDocumentPrivate.h:  Remove selectionImageForcingWhiteText:.
464         * WebView/WebHTMLView.mm:  Ditto.
465         * WebView/WebPDFView.mm:  Ditto.
466         * WebView/WebView.mm:  Update comment to mentoin the last version of Safari that requires the obsolete method.
467
468 2008-02-29  Mark Rowe  <mrowe@apple.com>
469
470         Rubber-stamped by Eric Seidel.
471
472         Remove unneeded includes of WebKitSystemInterface.h.
473
474         * History/WebHistoryItem.mm:
475         * Misc/WebNSViewExtras.m:
476         * WebCoreSupport/WebFrameLoaderClient.mm:
477         * WebView/WebDataSource.mm:
478         * WebView/WebPDFView.mm:
479
480 2008-02-29  Mark Rowe  <mrowe@apple.com>
481
482         Reviewed by Oliver Hunt and Oliver Hunt.
483
484         <rdar://problem/4753845> WebKit should use CGEventSourceSecondsSinceLastEventType in place of WKSecondsSinceLastInputEvent SPI.
485
486         * WebCoreSupport/WebSystemInterface.m:
487         (InitWebCoreSystemInterface):  Remove unused symbol.
488         * WebKit.order:  Ditto.
489
490 2008-02-28  Mark Rowe  <mrowe@apple.com>
491
492         Reviewed by Dave Hyatt.
493
494         Make use of new CGFont APIs on Leopard rather than making a WebKitSystemInterface call.
495
496         * WebCoreSupport/WebSystemInterface.m:
497         (InitWebCoreSystemInterface): Only initialize wkGetFontMetrics on Tiger.
498
499 2008-02-27  Brady Eidson  <beidson@apple.com>
500
501         Reviewed by Mark Rowe (code) and Darin (concept)
502
503         Much better fix for <rdar://problem/4930688> (see r19549)
504         Original fix for <rdar://problem/3947312> (and 14 dupes)
505         
506         Let me tell you a story:
507         A long time ago, in a cvs repository far, far away, loader code was almost all up in WebKit.
508         WebArchive code was intertwined with that code in bizarre and complex ways.
509         During the months long loader re-factoring where we pushed much loader code down into WebCore,
510         many portions of the WebKit loader were thinned out until they ceased to exist.  Others remained
511         with a sole purpose.
512
513         One such section of code whose lineage traces back from WebFrameLoaderClient to WebFrameLoader
514         to WebLoader was originally rooted in the method [WebLoader loadRequest:].  This method was the 
515         single entry point for almost all loading (network or web archives)
516
517         This method would check various headers and other fields on the NSURLRequest and NSURLResponse 
518         to make decisions about the load.  If the cache control fields were expired or other conditions 
519         in the headers were met, the load would be forced to go out to the network.
520
521         As the loader was moved and tweaked repeatedly, most of this code was pruned or re-factored.  
522         At some point, all that remained was the special cases for loading WebArchives.  
523         
524         Somewhere in the r16,000s, this remaining responsibility was noticed and related methods we renamed
525         to be WebArchive specific, further cementing the assumed design.
526
527         Problem is, the design was bad.  A WebArchive is meant to be a static snapshot of a WebPage at a
528         specific point in time.  Referring to the request to see if the resource should be reloaded seems
529         nonsensical, as does referring to the response headers to see if the resource is "expired".  In the 
530         context of loading a WebArchive, available data should *always* be loaded from the WebArchive, at least
531         during the initial load!
532
533         After discovering the secret to reproducing all of these bugs is both emptying our your Foundation 
534         cache and disconnecting your network, it was easy to reproduce the 16 individually reported cases 
535         that were all symptoms of this bug, and easy to verify that they are fixed with this patch.
536
537         * WebCoreSupport/WebFrameLoaderClient.h:
538         * WebCoreSupport/WebFrameLoaderClient.mm:
539         (WebFrameLoaderClient::willUseArchive): Do not call either form of "canUseArchivedResource()" that
540           inspect the request or response objects - We are loading from a WebArchive, and we should never
541           make the decision to go out to the network when we actually have the resource available.
542
543         * WebCoreSupport/WebSystemInterface.m:
544         (InitWebCoreSystemInterface):  Remove two methods that are no longer used anywhere in WebKit
545
546 2008-02-27  Matt Lilek  <webkit@mattlilek.com>
547
548         Reviewed by Adam Roben.
549
550         Bug 14348: Messing up the inspector by dragging an URL into it
551         http://bugs.webkit.org/show_bug.cgi?id=14348
552         <rdar://problem/5283620> and <rdar://problem/5712808>
553
554         * WebCoreSupport/WebInspectorClient.mm:
555         (-[WebInspectorWindowController init]): Remove duplicate preference setting.
556         (-[WebInspectorWindowController webView:dragDestinationActionMaskForDraggingInfo:]):
557
558 2008-02-25  Darin Adler  <darin@apple.com>
559
560         Reviewed by Adam.
561
562         * WebView/WebArchiver.mm:
563         (+[WebArchiver archiveSelectionInFrame:]): Use blankURL.
564         * WebView/WebFrame.mm:
565         (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Avoid the
566         variable name URL to avoid clashing with the renamed KURL in the future. Also use
567         blankURL.
568         (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]): Ditto.
569         (-[WebFrame _loadHTMLString:baseURL:unreachableURL:]): Ditto.
570         (-[WebFrame loadHTMLString:baseURL:]): Ditto.
571         (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]): Ditto.
572
573 2008-02-24  Darin Adler  <darin@apple.com>
574
575         Reviewed by Sam.
576
577         - remove separate client calls for "standard" and "reload' history
578
579         * WebCoreSupport/WebFrameLoaderClient.h:
580         * WebCoreSupport/WebFrameLoaderClient.mm:
581         (WebFrameLoaderClient::updateGlobalHistory):
582
583 2008-02-23  Alexey Proskuryakov  <ap@webkit.org>
584
585         Reviewed by Darin.
586
587         Move basic threading support from WebCore to WTF.
588
589         * ForwardingHeaders/wtf/Threading.h: Added.
590         * ForwardingHeaders/wtf/Locker.h: Added.
591
592 2008-02-23  David Kilzer  <ddkilzer@apple.com>
593
594         Please clarify licensing for some files
595         <http://bugs.webkit.org/show_bug.cgi?id=14970>
596
597         Reviewed by Darin.
598
599         * Plugins/WebNetscapeDeprecatedFunctions.c: Updated copyright statement
600         and added Apple BSD-style license.
601         * Plugins/WebNetscapeDeprecatedFunctions.h: Ditto.
602
603 2008-02-22  John Sullivan  <sullivan@apple.com>
604
605         Reviewed by Adam Roben
606         
607         Reverted the changed from yesterday to add pasteAndMatchStyle:, as the existing
608         pasteAsPlainText: has the same behavior.
609
610         * WebView/WebHTMLView.mm:
611         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
612         (-[WebHTMLView readSelectionFromPasteboard:]):
613         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
614         (-[WebHTMLView pasteAsRichText:]):
615         (-[WebHTMLView paste:]):
616         * WebView/WebView.mm:
617         * WebView/WebViewPrivate.h:
618
619 2008-02-21  Anders Carlsson  <andersca@apple.com>
620
621         Reviewed by Sam.
622
623         Use BackForwardList::create instead.
624         
625         * History/WebBackForwardList.mm:
626         (-[WebBackForwardList init]):
627
628 2008-02-21  John Sullivan  <sullivan@apple.com>
629
630         Reviewed by Jessica Kahn
631         
632         support for pasteAndMatchStyle: command (see <rdar://problem/5723952>)
633
634         * WebView/WebHTMLView.mm:
635         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:matchStyle:]):
636         added matchStyle parameter, passed along to bridge (formerly always passed NO to bridge)
637         (-[WebHTMLView readSelectionFromPasteboard:]):
638         pass NO for new matchStyle parameter to match old behavior
639         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
640         validate pasteAndMatchStyle the same way as pasteAsRichText
641         (-[WebHTMLView pasteAndMatchStyle:]):
642         just like pasteAsRichText but passes YES for matchStyle
643         (-[WebHTMLView pasteAsRichText:]):
644         pass NO for new matchStyle parameter to match old behavior
645         (-[WebHTMLView paste:]):
646         ditto
647         
648         * WebView/WebView.mm:
649         added macro(pasteAndMatchStyle)
650         
651         * WebView/WebViewPrivate.h:
652         added pasteAndMatchStyle: to WebViewEditingActionsPendingPublic category
653
654 2008-02-20  Sam Weinig  <sam@webkit.org>
655
656         Reviewed by Darin and Geoff.
657
658         - WebKit part of <rdar://problem/5754378> work around missing video on YouTube front page with a site-specific hack
659
660         * WebView/WebView.mm:
661         (-[WebView _preferencesChangedNotification:]): Added a call to Settings::setNeedsSiteSpecificQuirks.
662         There are currently no site-specific quirks on Mac, but we will propagate the state
663         to WebCore to avoid possible mistakes later.
664
665 2008-02-19  Anders Carlsson  <andersca@apple.com>
666
667         Reviewed by Darin.
668
669         Move back WebKit methods that were unused in WebCore.
670         
671         * Misc/WebNSURLExtras.mm:
672         (+[NSURL _web_URLWithData:]):
673         (+[NSURL _web_URLWithData:relativeToURL:]):
674         (-[NSURL _web_originalData]):
675         (-[NSURL _web_originalDataAsString]):
676         (-[NSURL _web_isEmpty]):
677         (-[NSURL _webkit_canonicalize]):
678         (-[NSURL _webkit_URLByRemovingComponent:]):
679         (-[NSURL _webkit_URLByRemovingFragment]):
680         (-[NSURL _webkit_URLByRemovingResourceSpecifier]):
681         (-[NSURL _webkit_isFileURL]):
682         (-[NSString _webkit_isFileURL]):
683         * WebCoreSupport/WebFrameLoaderClient.mm:
684         (WebFrameLoaderClient::setTitle):
685         * WebCoreSupport/WebSystemInterface.m:
686         (InitWebCoreSystemInterface):
687
688 2008-02-18  Darin Adler  <darin@apple.com>
689
690         Reviewed by Sam.
691
692         * Misc/WebNSAttributedStringExtras.mm:
693         (+[NSAttributedString _web_attributedStringFromRange:]): Eliminate use of
694         DeprecatedString.
695
696 2008-02-17  Sam Weinig  <sam@webkit.org>
697
698         Reviewed by Dan Bernstein.
699
700         Fix for http://bugs.webkit.org/show_bug.cgi?id=17365
701         document.createEvent("MessageEvent") throws NOT_SUPPORTED_ERR
702
703         * MigrateHeaders.make: Migrate DOMProgressEvent.h and DOMTextPrivate.h which were
704         mistakenly not migrated.
705
706 2008-02-15  Dan Bernstein  <mitz@apple.com>
707
708         Reviewed by Alexey Proskuryakov.
709
710         - WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=17360
711           <rdar://problem/5743131> REGRESSION: mp4 file downloaded from server is downloaded as html
712
713         * WebView/WebDataSource.mm:
714         (+[WebDataSource _representationClassForMIMEType:]):
715         (-[WebDataSource _responseMIMEType]):
716         (-[WebDataSource subresources]):
717         (-[WebDataSource subresourceForURL:]):
718         * WebView/WebResource.mm:
719         (-[WebResource _initWithData:URL:response:]):
720         * WebView/WebResourcePrivate.h:
721
722 2008-02-15  Adam Roben  <aroben@apple.com>
723
724         Make WebKit's FEATURE_DEFINES match WebCore's
725
726         Reviewed by Mark.
727
728         * Configurations/WebKit.xcconfig:
729
730 2008-02-14  Darin Adler  <darin@apple.com>
731
732         Reviewed by Eric Seidel.
733
734         - updated for WebCore KURL changes
735
736         * History/WebHistoryItem.mm:
737         (-[WebHistoryItem URL]): Removed getNSURL call.
738         * Misc/WebElementDictionary.mm:
739         (-[WebElementDictionary _absoluteImageURL]): Ditto.
740         (-[WebElementDictionary _absoluteLinkURL]): Ditto.
741         * Misc/WebNSAttributedStringExtras.mm:
742         (fileWrapperForElement): Ditto.
743         (+[NSAttributedString _web_attributedStringFromRange:]): Ditto.
744         * Misc/WebNSURLExtras.mm:
745         (-[NSString _webkit_stringByReplacingValidPercentEscapes]): Updated
746         for function name change.
747         * WebCoreSupport/WebContextMenuClient.mm:
748         (WebContextMenuClient::downloadURL): Removed getNSURL call.
749         * WebCoreSupport/WebDragClient.mm:
750         (WebDragClient::createDragImageForLink): Ditto.
751         * WebCoreSupport/WebFrameLoaderClient.mm:
752         (WebFrameLoaderClient::dispatchWillPerformClientRedirect): Ditto.
753         (WebFrameLoaderClient::startDownload): Ditto.
754         (WebFrameLoaderClient::updateGlobalHistoryForStandardLoad): Ditto.
755         (WebFrameLoaderClient::updateGlobalHistoryForReload): Ditto.
756         (WebFrameLoaderClient::cancelledError): Ditto.
757         (WebFrameLoaderClient::blockedError): Ditto.
758         (WebFrameLoaderClient::cannotShowURLError): Ditto.
759         (WebFrameLoaderClient::interruptForPolicyChangeError): Ditto.
760         (WebFrameLoaderClient::cannotShowMIMETypeError): Ditto.
761         (WebFrameLoaderClient::fileDoesNotExistError): Ditto.
762         (WebFrameLoaderClient::willUseArchive): Ditto.
763         (WebFrameLoaderClient::setTitle): Ditto.
764         (WebFrameLoaderClient::actionDictionary): Ditto.
765         (WebFrameLoaderClient::createFrame): Ditto.
766         (WebFrameLoaderClient::objectContentType): Ditto.
767         (WebFrameLoaderClient::createPlugin): Ditto.
768         (WebFrameLoaderClient::createJavaAppletWidget): Ditto.
769         * WebView/WebDataSource.mm:
770         (-[WebDataSource _URL]): Ditto.
771         (-[WebDataSource _initWithDocumentLoader:]): Ditto.
772         (-[WebDataSource unreachableURL]): Ditto.
773         * WebView/WebHTMLView.mm:
774         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
775
776 2008-02-14  Stephanie Lewis  <slewis@apple.com>
777
778         Reviewed by Geoff.
779
780         Update order files.
781
782         * WebKit.order:
783
784 2008-02-14  Alexey Proskuryakov  <ap@webkit.org>
785
786         Reviewed by Adam Roben.
787
788         http://bugs.webkit.org/show_bug.cgi?id=17207
789         Database example doesn't work (requires not-yet-released Safari)
790
791         * WebCoreSupport/WebChromeClient.mm:
792         (WebChromeClient::exceededDatabaseQuota): Check Safari version, and allow 5 megabytes of storage
793         if it's too old.
794
795 2008-02-11  Darin Adler  <darin@apple.com>
796
797         - roll out fix for <rdar://problem/5726016> REGRESSION: Xcode News window renders
798           incorrectly due to visibility fix
799
800         Removed the Xcode-specific quirk at the request of some folks on the Xcode team.
801
802         * Misc/WebKitVersionChecks.h: Removed the constant.
803
804         * WebView/WebView.mm:
805         (-[WebView _needsXcodeVisibilityQuirk]): Removed.
806         (-[WebView _preferencesChangedNotification:]): Removed call to
807         setNeedsXcodeVisibilityQuirk.
808
809 2008-02-12  Anders Carlsson  <andersca@apple.com>
810
811         Reviewed by Mitz.
812
813         * WebCoreSupport/WebFrameBridge.mm:
814         * WebCoreSupport/WebViewFactory.mm:
815         (-[WebViewFactory imageTitleForFilename:size:]):
816         Move implementation from WebFrameBridge to WebViewFactory.
817
818 2008-02-11  Darin Adler  <darin@apple.com>
819
820         Reviewed by Mitz.
821
822         - fix <rdar://problem/5726016> REGRESSION: Xcode News window renders
823           incorrectly due to visibility fix
824
825         Added an Xcode-specific quirk.
826
827         * Misc/WebKitVersionChecks.h: Added a constant for the "linked on or after"
828         part of the check.
829
830         * WebView/WebView.mm:
831         (-[WebView _needsXcodeVisibilityQuirk]): Added.
832         (-[WebView _preferencesChangedNotification:]): Added a call to
833         setNeedsXcodeVisibilityQuirk based on _needsXcodeVisibilityQuirk.
834
835 2008-02-10  Darin Adler  <darin@apple.com>
836
837         - fix http://bugs.webkit.org/show_bug.cgi?id=17274
838           REGRESSION: User Agent string broken in r30119
839
840         * WebView/WebView.mm:
841         (-[WebView _userAgentWithApplicationName:andWebKitVersion:]):
842         Fix wrong variable name. Doh!
843
844 2008-02-09  Darin Adler  <darin@apple.com>
845
846         Reviewed by Tim Hatcher.
847
848         - fix <rdar://problem/5725996> crash every time you open the Xcode documentation window
849
850         * WebView/WebView.mm:
851         (-[WebView _userAgentWithApplicationName:andWebKitVersion:]): Work around a bug in the
852         garbage collector's Objective C++ support by not initializing a static to an object
853         that needs to be marked when running under GC.
854
855 2008-02-05  Dan Bernstein  <mitz@apple.com>
856
857         Reviewed by Darin Adler.
858
859         - WebKit part of <rdar://problem/5724303> Should implement writing direction shortcuts
860
861         The key bindings are Command-Control-left arrow and
862         Command-Control-right arrow. To match AppKit, the bindings are enabled
863         only when certain user defaults are set.
864
865         * WebView/WebHTMLView.mm:
866         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
867         (-[WebHTMLView toggleBaseWritingDirection:]): Changed to call
868         Frame::baseWritingDirectionForSelectionStart() and
869         Editor::setBaseWritingDirection() directly.
870         (-[WebHTMLView changeBaseWritingDirection:]): Ditto.
871         (writingDirectionKeyBindingsEnabled): Added.
872         (-[WebHTMLView _changeBaseWritingDirectionTo:]): Added this helper
873         method.
874         (-[WebHTMLView changeBaseWritingDirectionToLTR:]): Added.
875         (-[WebHTMLView changeBaseWritingDirectionToRTL:]): Added.
876         * WebView/WebView.mm:
877
878 2008-02-05  Mark Rowe  <mrowe@apple.com>
879
880         Unreviewed build fix.
881
882         * WebView/WebView.mm: Add missing #import.
883
884 2008-02-05  Mark Rowe  <mrowe@apple.com>
885
886         Reviewed by Oliver Hunt.
887
888         Update versioning to support the mysterious future.
889
890         * Configurations/Version.xcconfig: Add SYSTEM_VERSION_PREFIX_1060.
891
892 2008-01-30  Justin Garcia  <justin.garcia@apple.com>
893
894         Reviewed by Darin Adler.
895         
896         <rdar://problem/5708115> REGRESSION: Words selected with a double click and copied won't paste into Mail
897
898         * WebView/WebHTMLView.mm:
899         (-[WebHTMLView _smartInsertForString:replacingRange:beforeString:afterString:]): Brought 
900         this back, it's used by Mail.
901         (-[WebHTMLView _canSmartReplaceWithPasteboard:]): This WebInternal method is
902         also used by Mail.  Moved to WebPrivate.
903         * WebView/WebHTMLViewPrivate.h: Expose two methods that Mail uses here, so that we don't
904         accidently remove them in the future.
905
906 2008-01-30  Mark Rowe  <mrowe@apple.com>
907
908         Reviewed by Oliver Hunt.
909
910         Move off deprecated NSTableView methods.
911
912         * WebView/WebHTMLView.mm:
913         (-[WebTextCompleteController _buildUI]): Switch from -setDrawsGrid: to -setGridStyleMask:.
914         (-[WebTextCompleteController _placePopupWindow:]): Switch from -selectRow:byExtendingSelection: to -selectRowIndexes:byExtendingSelection:.
915         (-[WebTextCompleteController filterKeyDown:]): Ditto.
916
917 2008-01-26  Mark Rowe  <mrowe@apple.com>
918
919         Reviewed by Darin Adler.
920
921         Fix leaks seen after loading <http://www.funnyordie.com/videos/d70b5a11cb>.
922
923         * Misc/WebNSDataExtras.m:
924         (-[NSString _web_capitalizeRFC822HeaderFieldName]): Transfer ownerhip of the allocated buffers
925         to the new CFString so that they will be freed when no longer needed.
926
927 2008-01-26  Greg Bolsinga  <bolsinga@apple.com>
928
929         <rdar://problem/5708388> WebDashboardRegion.h duplicated between WebCore / WebKit
930
931         Reviewed by Darin.
932
933         * WebCoreSupport/WebDashboardRegion.h: Removed.
934         * WebView/WebView.mm: Updated #import to use copy of WebDashboardRegion.h from WebCore.
935
936 2008-01-21  Darin Adler  <darin@apple.com>
937
938         Reviewed by John Sullivan.
939
940         - fix <rdar://problem/5644324> Delegate-less WebKit clients should have no databases
941         - add a missing export of WebDatabaseExpectedSizeKey
942         - implement deleteOrigin: and remove deleteDatabasesWithOrigin:
943
944         * Storage/WebDatabaseManager.mm:
945         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Updated to check for a null
946         name instead of calling isValid().
947         (-[WebDatabaseManager deleteOrigin:]): Implemented.
948         (WebKitInitializeDatabasesIfNecessary): Updated for name change.
949
950         * Storage/WebDatabaseManagerPrivate.h: Removed deleteDatabasesWithOrigin:.
951
952         * WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
953         * WebCoreSupport/WebChromeClient.mm:
954         (WebChromeClient::exceededDatabaseQuota): Replaced the two different client functions
955         we had before with a single one.
956
957         * WebKit.exp: Added missing export for WebDatabaseExpectedSizeKey.
958
959         * WebView/WebPreferenceKeysPrivate.h: Removed WebKitDefaultDatabaseQuotaKey.
960         * WebView/WebPreferences.m:
961         (+[WebPreferences initialize]): Removed the default for WebKitDefaultDatabaseQuotaKey.
962         * WebView/WebPreferencesPrivate.h: Removed defaultDatabaseQuota and
963         setDefaultDatabaseQuota:.
964
965         * WebView/WebUIDelegatePrivate.h: Replaced the two different database quota delegate
966         methods we had before with a single one.
967
968         * WebView/WebView.mm:
969         (-[WebView _preferencesChangedNotification:]): Removed the code to set the
970         default database origin quota in WebCore::Settings based on WebPreferences.
971
972         * WebView/WebViewInternal.h: Removed delegate method dispatch functions for unusual
973         types of parameters that the database UI delegate methods had before.
974
975 2008-01-20  Mark Rowe  <mrowe@apple.com>
976
977         Reviewed by Dan Bernstein.
978
979         Remove code bracketed by REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM as we are no longer
980         interested in supporting Safari 2 with TOT WebKit.
981
982         * WebView/WebView.mm:
983         (+[WebView initialize]):
984
985 2008-01-17  Timothy Hatcher  <timothy@apple.com>
986
987         Reviewed by Adam Roben.
988
989         <rdar://problem/5693558> REGRESSION (r29581): no form field focus rings
990         and inactive text selection after loading a page
991         Bug 16917: REGRESSION (r29581/2): Google Maps search box loses focused appearance
992
993         The problem was other frames were changing the FocusController's active
994         status to false after the first responder frame set it to true. The last
995         frame to call _updateActiveState would win.
996
997         * WebView/WebHTMLView.mm:
998         (-[WebHTMLView _updateActiveState]): Only call page->focusController()->setActive()
999         if the first responder is the current WebHTMLView or the WebFrameView.
1000         (-[WebHTMLView _web_firstResponderCausesFocusDisplay]): Removed, inlined code in _updateActiveState.
1001
1002 2008-01-18  Adam Roben  <aroben@apple.com>
1003
1004         Rename _updateActiveState to _updateFocusedAndActiveState
1005
1006         Also renamed any related methods/members similarly.
1007
1008         Reviewed by Adele.
1009
1010         * WebView/WebHTMLView.mm:
1011         (-[WebHTMLViewPrivate dealloc]):
1012         (-[WebHTMLView _cancelUpdateFocusedAndActiveStateTimer]):
1013         (-[WebHTMLView close]):
1014         (_updateFocusedAndActiveStateTimerCallback):
1015         (-[WebHTMLView viewWillMoveToWindow:]):
1016         (-[WebHTMLView viewDidMoveToWindow]):
1017         (-[WebHTMLView windowDidBecomeKey:]):
1018         (-[WebHTMLView windowDidResignKey:]):
1019         (-[WebHTMLView becomeFirstResponder]):
1020         (-[WebHTMLView resignFirstResponder]):
1021         * WebView/WebHTMLViewInternal.h:
1022         * WebView/WebHTMLViewPrivate.h:
1023
1024 2008-01-17  John Sullivan  <sullivan@apple.com>
1025
1026         Reviewed by Darin
1027         
1028         - fixed <rdar://problem/5692068> -1 WebFrameView world leaks reported after closing view source window
1029
1030         * WebView/WebFrameView.mm:
1031         (-[WebFrameView initWithCoder:]):
1032         override to bump the global WebFrameView count
1033
1034 2008-01-16  Adam Roben  <aroben@apple.com>
1035
1036         Updated for renames/removal of WebCore methods.
1037
1038         Reviewed by Darin.
1039
1040         * Plugins/WebPluginController.mm:
1041         (-[WebPluginController webPlugInContainerSelectionColor]): Changed to
1042         ask isFocusedAndActive directly, instead of going through the frame
1043         bridge.
1044         * WebView/WebHTMLView.mm:
1045         (-[WebHTMLView _updateActiveState]): Updated for method renames.
1046
1047 2008-01-16  John Sullivan  <sullivan@apple.com>
1048
1049         Reviewed by Adam and Dan
1050         
1051         - cleaned up some existing logging
1052
1053         * WebView/WebHTMLView.mm:
1054         (-[WebHTMLView setNeedsDisplay:]):
1055         add method name to log, use "YES" and "NO" instead of (int)flag
1056         (-[WebHTMLView setNeedsLayout:]):
1057         ditto
1058         (-[WebHTMLView setNeedsToApplyStyles:]):
1059         ditto
1060
1061 2008-01-15  Geoffrey Garen  <ggaren@apple.com>
1062
1063         Reviewed by Andre Boule.
1064
1065         Fixed <rdar://problem/5667627> [WebCache empty] implementation should
1066         not disable/enable the cache
1067         
1068         Toggle the cache model instead -- toggling disable/enable just causes
1069         the cache to forget about resources, not reclaim their memory.
1070
1071         * Misc/WebCache.mm:
1072         (+[WebCache empty]):
1073         * WebView/WebView.mm:
1074         * WebView/WebViewInternal.h:
1075
1076 2008-01-15  Adele Peterson  <adele@apple.com>
1077
1078         Reviewed by Adam and Antti.
1079
1080         WebKit part of fix for <rdar://problem/5619062> Add load progress indicator to video controls
1081
1082         * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
1083           Removed initialization for GetMediaControlBackgroundImageData.  Added initialization for DrawMediaSliderTrack.
1084
1085 2008-01-10  Geoffrey Garen  <ggaren@apple.com>
1086
1087         Reviewed by John Sullivan.
1088
1089         Fixed some world leak reports:
1090         * <rdar://problem/5669436> PLT complains about world leak of 1 JavaScript
1091         Interpreter after running cvs-base suite
1092
1093         * <rdar://problem/5669423> PLT complains about world leak if browser
1094         window is open when PLT starts
1095         
1096         These were both bugs in the reporting mechanism, so I took the
1097         opportunity to do some house cleaning there.
1098
1099         * Misc/WebCoreStatistics.h: Did a little renaming, to match
1100         JavaScriptCore better. I kept the methods with the old names around,
1101         though, because old versions of Safari need them.
1102
1103         * Misc/WebCoreStatistics.mm: Removed dependence on
1104         WebCore::JavaScriptStatistics, which is gone now. 
1105         
1106         These two methods are now distinct, for the sake of world leak reporting:
1107         (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
1108         (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
1109
1110 2008-01-10  Maciej Stachowiak  <mjs@apple.com>
1111
1112         Not reviewed. Build fix.
1113         
1114         - Attempt to fix mac build.
1115
1116         * Storage/WebDatabaseManager.mm:
1117
1118 2008-01-10  Maciej Stachowiak  <mjs@apple.com>
1119
1120         Reviewed by Sam.
1121
1122         - remove SecurityOriginData and fold its functionality into SecurityOrigin
1123
1124         * Storage/WebDatabaseManager.mm:
1125         (-[WebDatabaseManager origins]):
1126         (-[WebDatabaseManager databasesWithOrigin:]):
1127         (-[WebDatabaseManager detailsForDatabase:withOrigin:]):
1128         (-[WebDatabaseManager deleteDatabasesWithOrigin:]):
1129         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
1130         * Storage/WebDatabaseTrackerClient.h:
1131         * Storage/WebDatabaseTrackerClient.mm:
1132         (WebDatabaseTrackerClient::dispatchDidModifyOrigin):
1133         (WebDatabaseTrackerClient::dispatchDidModifyDatabase):
1134         * Storage/WebSecurityOrigin.mm:
1135         (-[WebSecurityOrigin initWithProtocol:domain:port:]):
1136         (-[WebSecurityOrigin protocol]):
1137         (-[WebSecurityOrigin domain]):
1138         (-[WebSecurityOrigin port]):
1139         (-[WebSecurityOrigin usage]):
1140         (-[WebSecurityOrigin quota]):
1141         (-[WebSecurityOrigin setQuota:]):
1142         (-[WebSecurityOrigin isEqual:]):
1143         (-[WebSecurityOrigin dealloc]):
1144         (-[WebSecurityOrigin finalize]):
1145         (-[WebSecurityOrigin _initWithWebCoreSecurityOrigin:]):
1146         (-[WebSecurityOrigin _core]):
1147         * Storage/WebSecurityOriginInternal.h:
1148         * WebCoreSupport/WebChromeClient.h:
1149         * WebCoreSupport/WebChromeClient.mm:
1150         (WebChromeClient::requestQuotaIncreaseForNewDatabase):
1151         (WebChromeClient::requestQuotaIncreaseForDatabaseOperation):
1152
1153 2008-01-10  Sam Weinig  <sam@webkit.org>
1154
1155         Reviewed by Anders Carlsson.
1156
1157         Fixes: http://bugs.webkit.org/show_bug.cgi?id=16522
1158         <rdar://problem/5657355>
1159
1160         * Plugins/WebBaseNetscapePluginView.mm:
1161         (-[WebBaseNetscapePluginView loadPluginRequest:]): call findFrameForNavigation
1162         to ensure the shouldAllowNavigation check is made.
1163
1164 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
1165
1166         Reviewed by Mark.
1167
1168         Enable SVG_FONTS by default.
1169
1170         * Configurations/WebKit.xcconfig:
1171
1172 2008-01-07  Adele Peterson  <adele@apple.com>
1173
1174         Reviewed by Antti, Adam, and Mitz.
1175
1176         WebKit part of fix for 
1177         <rdar://problem/5619073> Updated look for <video> controls
1178         <rdar://problem/5619057> Add volume control to video controls
1179
1180         * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
1181
1182 2008-01-07  Dan Bernstein  <mitz@apple.com>
1183
1184         Reviewed by Dave Hyatt.
1185
1186         - <rdar://problem/5665216> Support the unicode-range property in @font-face rules
1187
1188         * Misc/WebNSAttributedStringExtras.mm:
1189
1190 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
1191
1192         Reviewed by Darin.
1193
1194         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
1195
1196         * WebView/WebView.mm:
1197         (-[WebView _executeCoreCommandByName:value:]):
1198         * WebView/WebViewPrivate.h:
1199         Added an SPI to implement layoutTestController.execCommand.
1200
1201 2008-01-03  Kevin Decker  <kdecker@apple.com>
1202
1203         Reviewed by Darin.
1204
1205         Fixed: <rdar://problem/4106190> Include "Where from" metadata in drag-and-dropped images
1206         
1207         * Misc/WebNSFileManagerExtras.h:
1208         * Misc/WebNSFileManagerExtras.m:
1209         (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]): Added new method. Uses WebKitSystemInterface to set
1210         "Where from:" metadata information.
1211         * WebView/WebHTMLView.mm:
1212         (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Added "Where from:" metadata for drag and dropped images.
1213         
1214 2008-01-03  Alice Liu  <alice.liu@apple.com>
1215
1216         Reviewed by Darin.
1217
1218         This fixes pageup/down in iframes.  test for this is fast/frames/iframe-scroll-page-up-down.html
1219
1220         * WebView/WebHTMLView.mm:
1221         (-[WebHTMLView doCommandBySelector:]):
1222         Have the editor handle all the commands it supports instead of just text commands.
1223         If not handled by the editor, the webview will handle the command. 
1224
1225 2008-01-02  Kevin Decker  <kdecker@apple.com>
1226
1227         Reviewed by Darin.
1228         
1229         Fixed: <rdar://problem/5660603> QuickDraw plug-ins can cause a 100% reproducible assertion failure in AppKit (breaks Safari UI)
1230
1231         * Plugins/WebBaseNetscapePluginView.mm:
1232         (-[WebBaseNetscapePluginView updateAndSetWindow]): Simplified an early return for non-QuickDraw plug-ins and switched
1233         to using the more NSView friendly version of lockFocus, lockFocusIfCanDraw.
1234
1235 2008-01-01  David D. Kilzer  <ddkilzer@webkit.org>
1236
1237         Reviewed by Dan.
1238
1239         - fix http://bugs.webkit.org/show_bug.cgi?id=16700
1240           Fix -[WebDefaultPolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]
1241
1242         * DefaultDelegates/WebDefaultPolicyDelegate.m: Check return value of
1243         -[NSFileManager fileExistsAtPath:isDirectory:] before using the value
1244         of isDirectory.
1245
1246 2007-12-29  Nikolas Zimmermann  <zimmermann@kde.org>
1247
1248         Reviewed by Eric.
1249
1250         Add DOMSVGFontElement/DOMSVGGlyphElement/DOMSVGMissingGlyphElement to MigrateHeaders.make
1251
1252         * MigrateHeaders.make:
1253
1254 2007-12-25  Dan Bernstein  <mitz@apple.com>
1255
1256         Reviewed by Oliver Hunt.
1257
1258         - fix an assertion failure when pressing the num lock key
1259
1260         * WebView/WebHTMLView.mm:
1261         (-[WebHTMLView flagsChanged:]): Avoid passing key code 10 down to
1262         WebCore.
1263
1264 2007-12-20  Darin Adler  <darin@apple.com>
1265
1266         Reviewed by Oliver.
1267
1268         - fix <rdar://problem/5658787> Selector -[WebView insertLineBreak:] is not implemented
1269
1270         * WebView/WebView.mm: Added all selectors implemented by WebHTMLView to the list of
1271         selectors to forward here. The new ones are: changeBaseWritingDirection:, changeSpelling:,
1272         deleteToMark:, insertLineBreak:, moveParagraphBackwardAndModifySelection:,
1273         moveParagraphForwardAndModifySelection:, pageDownAndModifySelection:, pageUpAndModifySelection:,
1274         selectToMark:, setMark:, swapWithMark:, takeFindStringFromSelection:, toggleBaseWritingDirection:,
1275         and transpose:.
1276
1277 2007-12-20  Kevin Decker  <kdecker@apple.com>
1278
1279         Reviewed by Anders.
1280         
1281         Fixed: <rdar://problem/5638288> REGRESSION: Flash movies show up in other tabs above the page (16373)
1282
1283         * Plugins/WebBaseNetscapePluginView.mm:
1284         (-[WebBaseNetscapePluginView updateAndSetWindow]): QuickDraw plug-ins must manually be told when to stop
1285          writing to the window backing store. The problem was that change-set 28400 introduced an early return 
1286          which prevented this necessary operation. The fix is to limit the scope of the early return to CG and GL
1287          plug-ins and to tweak the needsFocus check to prevent an exception from occurring in QuickDraw-based plug-ins.
1288
1289 2007-12-19  Geoffrey Garen  <ggaren@apple.com>
1290
1291         Reviewed by Oliver Hunt.
1292
1293         Build fix.
1294
1295         * ForwardingHeaders/kjs/SymbolTable.h: Added.
1296         * ForwardingHeaders/wtf/VectorTraits.h: Added.
1297
1298 2007-12-16  Mark Rowe  <mrowe@apple.com>
1299
1300         Reviewed by Maciej Stachowiak.
1301
1302         Refactor Mac plugin stream code to use the shared NetscapePlugInStreamLoader implementation.
1303
1304         * Plugins/WebBaseNetscapePluginStream.h:
1305         * Plugins/WebNetscapePluginStream.h:
1306         * Plugins/WebNetscapePluginStream.mm:
1307         (-[WebNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):
1308         (-[WebNetscapePluginStream dealloc]):
1309         (-[WebNetscapePluginStream finalize]):
1310         * Plugins/WebPlugInStreamLoaderDelegate.h: Moved from WebCore.
1311         * WebCoreSupport/WebNetscapePlugInStreamLoaderClient.h: Added.
1312         (WebNetscapePlugInStreamLoaderClient::WebNetscapePlugInStreamLoaderClient):
1313         * WebCoreSupport/WebNetscapePlugInStreamLoaderClient.mm: Added.
1314         (WebNetscapePlugInStreamLoaderClient::didReceiveResponse): Call through to the equivalent WebPlugInStreamLoaderDelegate method.
1315         (WebNetscapePlugInStreamLoaderClient::didReceiveData): Ditto.
1316         (WebNetscapePlugInStreamLoaderClient::didFail): Ditto.
1317         (WebNetscapePlugInStreamLoaderClient::didFinishLoading): Ditto.
1318
1319 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
1320
1321         Reviewed by Darin.
1322
1323         http://bugs.webkit.org/show_bug.cgi?id=14140
1324         <rdar://problem/5270958> REGRESSION: Complex system KeyBindings don't work properly
1325
1326         * WebView/WebHTMLView.mm:
1327         (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]): Made command replaying work
1328         when handling keypress, too.
1329         (-[WebHTMLView doCommandBySelector:]): Adapted for the new way to store commands in events.
1330         (-[WebHTMLView insertText:]): Append a command, not replace the whole existing vector. Also,
1331         restore the state for additional commands to be saved correctly.
1332
1333 2007-12-14  David D. Kilzer  <ddkilzer@apple.com>
1334
1335         <rdar://problem/5647272> Remove user agent string hack for flickr.com
1336
1337         Reviewed by Darin.
1338
1339         * WebView/WebView.mm:
1340         (-[WebView _userAgentForURL:]): Removed hack.
1341
1342 2007-12-14  David D. Kilzer  <ddkilzer@apple.com>
1343
1344         <rdar://problem/5647261> Remove user agent string hack for yahoo.com
1345
1346         Reviewed by Darin.
1347
1348         * WebView/WebView.mm:
1349         (-[WebView _userAgentForURL:]): Removed hack.
1350
1351 2007-12-14  Darin Adler  <darin@apple.com>
1352
1353         Reviewed by Brady.
1354
1355         - fix http://bugs.webkit.org/show_bug.cgi?id=16296
1356           <rdar://problem/5635641> -[WebFrameLoadDelegate didReceiveIcon:forFrame:] never called
1357
1358         * WebView/WebView.mm:
1359         (-[WebView setFrameLoadDelegate:]): Call [WebIconDatabase sharedIconDatabase] if the
1360         a didReceiveIcon method is present.
1361
1362 2007-12-14  Darin Adler  <darin@apple.com>
1363
1364         Reviewed by Alexey.
1365
1366         - Changed a few more editing operations to use WebCore instead of WebKit.
1367         - Removed some obsolete unused code.
1368
1369         * WebCoreSupport/WebFrameBridge.h: Moved declarations of methods that are both
1370         defined and used on the WebKit side to here. These no longer belong on the bridge
1371         and should be moved to the WebFrame class (or elsewhere).
1372         * WebCoreSupport/WebFrameBridge.mm: Removed some unused methods.
1373
1374         * WebView/WebFrameView.mm:
1375         (+[WebFrameView _viewTypesAllowImageTypeOmission:]): Fix typo in comment.
1376
1377         * WebView/WebHTMLView.mm:
1378         (-[WebHTMLViewPrivate dealloc]): Removed unused firstResponderTextViewAtMouseDownTime.
1379         (-[WebHTMLViewPrivate clear]): Ditto.
1380         (-[WebHTMLView _setMouseDownEvent:]): Ditto.
1381         (commandNameForSelector): Added special cases for pageDown:, pageDownAndModifySelection:,
1382         pageUp:, and pageUpAndModifySelection:, since those names probably aren't specific enough
1383         to be used in WebCore (what AppKit calls scrollPageDown: vs. pageDown: needs to be
1384         disambiguated with the word "Move"). Added deleteBackward:,
1385         deleteBackwardByDecomposingPreviousCharacter:, deleteForward:, deleteToBeginningOfLine:,
1386         deleteToBeginningOfParagraph:, deleteToEndOfLine:, deleteToEndOfParagraph:, pageDown:,
1387         pageDownAndModifySelection:, pageUp:, pageUpAndModifySelection:, selectLine:,
1388         selectParagraph:, selectSentence:, and selectWord: to the list of commands that are
1389         forwarded to WebCore.
1390         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Eliminated the long list of
1391         operations that we forward to WebCore. Instead, look up any command that WebCore can
1392         handle, after any that we handle specially in WebHTMLView. Also fixed a bug where
1393         an item that's not a menu item with changeBaseWritingDirection:NSWritingDirectionNatural
1394         would end up enabled instead of disabled and streamlined the logic for toggleGrammarChecking:.
1395         (-[WebHTMLView mouseDown:]): Removed unused firstResponderTextViewAtMouseDownTime.
1396         (-[WebHTMLView becomeFirstResponder]): Removed unused willBecomeFirstResponderForNodeFocus.
1397         (-[WebHTMLView resignFirstResponder]): Ditto.
1398         (-[WebHTMLView checkSpelling:]): Took unneeded extra initialization of NSSpellChecker.
1399
1400         * WebView/WebHTMLViewInternal.h: Removed unused willBecomeFirstResponderForNodeFocus,
1401         firstResponderTextViewAtMouseDownTime, _textViewWasFirstResponderAtMouseDownTime: and
1402         _willMakeFirstResponderForNodeFocus.
1403
1404 2007-12-13  Alexey Proskuryakov  <ap@webkit.org>
1405
1406         Reviewed by Darin.
1407
1408         Turn on keyboard event processing quirks for feed views and old applications on Mac OS X.
1409
1410         * Misc/WebKitVersionChecks.h:
1411         * WebView/WebView.mm:
1412         (-[WebView _needsKeyboardEventHandlingQuirks]):
1413         (-[WebView _preferencesChangedNotification:]):
1414
1415 2007-12-12  Brady Eidson  <beidson@apple.com>
1416
1417         Reviewed by Sam Weinig
1418
1419         Fix for <rdar://problem/4886844> and lay groundwork for <rdar://problem/4516170> (Back/Forward Cache on Windows)
1420
1421         * WebCoreSupport/WebCachedPagePlatformData.h: Added.
1422         (WebCachedPagePlatformData::WebCachedPagePlatformData): Constructor takes a WebDocumentView for later restoration
1423         (WebCachedPagePlatformData::clear):
1424         (WebCachedPagePlatformData::webDocumentView):
1425
1426         * WebCoreSupport/WebFrameLoaderClient.h:
1427         * WebCoreSupport/WebFrameLoaderClient.mm:
1428         (WebFrameLoaderClient::savePlatformDataToCachedPage):
1429         (WebFrameLoaderClient::transitionToCommittedFromCachedPage): Don't set the DocumentLoader to the Frame here, 
1430           because that is now done in WebCore.
1431         (WebFrameLoaderClient::transitionToCommittedForNewPage):
1432
1433 2007-12-12  Mark Rowe  <mrowe@apple.com>
1434
1435         Reviewed by Dave Kilzer.
1436
1437         Remove abuse of projectDirPath from WebKit.xcodeproj to fix Production builds.
1438
1439         * Configurations/WebKit.xcconfig:
1440
1441 2007-12-11  Sam Weinig  <sam@webkit.org>
1442
1443         Reviewed by Darin Adler.
1444
1445         Scrub URL out of the tree in preparation for renaming KURL to URL.
1446
1447         * WebCoreSupport/WebFrameLoaderClient.mm:
1448         (WebFrameLoaderClient::actionDictionary):
1449         * WebView/WebDataSource.mm:
1450         (-[WebDataSource _URL]):
1451         * WebView/WebView.mm:
1452         (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
1453
1454 2007-12-11  Darin Adler  <darin@apple.com>
1455
1456         Reviewed by Geoff.
1457
1458         - change more editing commands to use WebCore::Editor
1459         - change to use the new WebCore::Editor::command() function
1460
1461         * WebView/WebHTMLView.mm: Changed alignCenter, alignJustified, alignLeft,
1462         alignRight, cut, copy, deleteToMark, indent, insertNewlineIgnoringFieldEditor,
1463         insertTabIgnoringFieldEditor, outdent, selectAll, selectToMark, setMark,
1464         subscript, superscript, swapWithMark, underline, unscript, yank, and yankAndSelect
1465         to use the "forward to WebCore" macro instead of having hand-written implementations.
1466         (kit): Added function to change a TriState to an AppKit-style tri-state value.
1467         (-[WebHTMLView coreCommandBySelector:]): Added. No longer converts case of the
1468         first character or copies the selector name, since the Editor commands are not case
1469         sensitive any more. Returns a command object.
1470         (-[WebHTMLView coreCommandByName:]): Added.
1471         (-[WebHTMLView executeCoreCommandBySelector:]): Renamed from callWebCoreCommand:,
1472         and changed to use the new coreCommandBySelector: method.
1473         (-[WebHTMLView executeCoreCommandByName:]): Added.
1474         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Changed all the
1475         methods that call through to WebCore to also use the state() and isEnabled()
1476         functions on the commands for the menu item state and user interface item enabling.
1477         (-[WebHTMLView _handleStyleKeyEquivalent:]): Use ToggleBold and ToggleItalic by
1478         name rather than having local methods for them; no need for methods with a single
1479         call site.
1480         (-[WebHTMLView insertParagraphSeparator:]): Use executeCoreCommandByName: rather
1481         than the deprecated execCommand().
1482         (-[WebHTMLView doCommandBySelector:]): Changed to use command().execute() rather
1483         than the deprecated execCommand().
1484         * WebView/WebHTMLViewInternal.h: Removed some unneeded method declarations.
1485
1486 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
1487
1488         Reviewed by Darin.
1489
1490         <rdar://problem/5535636>
1491         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
1492
1493         http://bugs.webkit.org/show_bug.cgi?id=13916
1494         JavaScript detects Tab as a character input on a textfield validation
1495
1496         * WebCoreSupport/WebEditorClient.h:
1497         Renamed handleKeypress() to handleKeyboardEvent(), as it gets both keydowns and keypresses.
1498         Renamed handleInputMethodKeypress() to handleInputMethodKeydown().
1499         * WebCoreSupport/WebEditorClient.mm:
1500         (WebEditorClient::handleKeyboardEvent): This change makes sense only remotely, but it helped
1501         to get tests working. I guess Mac keyboard event handling needs further refactoring.
1502
1503         * WebView/WebHTMLView.mm:
1504         (selectorToCommandName): Convert AppKit editing selector name to Editor command name - extracted
1505         from callWebCoreCommand:.
1506         (_interceptEditingKeyEvent:shouldSaveCommand:): Insert text from keypress.
1507
1508         * WebView/WebPDFView.mm:
1509         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1510         Convert incoming platform KeyDown into RawKeyDown, as this is what the view is interested in.
1511
1512 2007-12-10  Brady Eidson  <beidson@apple.com>
1513
1514         Reviewed by John Sullivan
1515
1516         Fix for <rdar://problem/5640080> - Database UI delegate calls need to specify WebFrame
1517
1518         This is because a common UI case is to want to know the originating URL of a Database
1519
1520         * WebCoreSupport/WebChromeClient.mm:
1521         (WebChromeClient::requestQuotaIncreaseForNewDatabase):
1522         (WebChromeClient::requestQuotaIncreaseForDatabaseOperation):
1523
1524         * WebView/WebUIDelegatePrivate.h:
1525
1526         * WebView/WebView.mm:
1527         (CallDelegateReturningUnsignedLongLong):
1528         (CallUIDelegateReturningUnsignedLongLong):
1529         * WebView/WebViewInternal.h:
1530
1531 2007-12-10  Timothy Hatcher  <timothy@apple.com>
1532
1533         Reviewed by Mark Rowe.
1534
1535         <rdar://problem/5639463> Bundle versions on Tiger should be 4523.x not 523.x
1536
1537         * Configurations/Version.xcconfig: Some Tiger versions of Xcode don't set MAC_OS_X_VERSION_MAJOR,
1538           so assume Tiger and use a 4 for the SYSTEM_VERSION_PREFIX.
1539
1540 2007-12-10  Kevin Decker  <kdecker@apple.com>
1541
1542         Reviewed by Darin.
1543
1544         Fixed: <rdar://problem/4290098> Right-mouse click on element doesn't call onmousedown handler
1545         
1546         * WebView/WebHTMLView.mm:
1547         (-[WebHTMLView menuForEvent:]): Match behavior of other browsers by sending an onmousedown event for right clicks.
1548
1549 2007-12-08  Oliver Hunt  <oliver@apple.com>
1550
1551         Reviewed by Sam W.
1552
1553         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
1554         
1555         Fixes <rdar://problem/5620249> Must disable SVG animation
1556         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
1557         
1558         Minor updates to the feature flags used.
1559
1560         * Configurations/WebKit.xcconfig:
1561         * DOM/WebDOMOperations.mm:
1562
1563 2007-12-07  Darin Adler  <darin@apple.com>
1564
1565         Reviewed by Kevin Decker and Tim Hatcher.
1566
1567         - speculative fix for <rdar://problem/5400159> CrashTracer: [USER] 726 crashes
1568           in Safari at com.apple.WebKit: -[WebHTMLView(WebPrivate) _updateMouseoverWithFakeEvent] + 389
1569
1570         * WebView/WebHTMLView.mm:
1571         (-[WebHTMLView _frameOrBoundsChanged]): Only schedule the mouseover timer if we are in a window
1572         and not closed. That's because viewDidMoveToWindow and close are the entry points for cancelling.
1573         (-[WebHTMLView close]): Add code to cancel both timers. Needed for the case where the entire
1574         window goes away, and the view is never removed from the window.
1575         (-[WebHTMLView viewDidMoveToWindow]): Don't do work if the view is closed.
1576
1577 2007-12-07  Darin Adler  <darin@apple.com>
1578
1579         Reviewed by Mitz.
1580
1581         - http://bugs.webkit.org/show_bug.cgi?id=15981
1582           speed up visited-link code a bit
1583
1584         * History/WebHistory.mm: Removed unused Latin-1 code path.
1585         (-[_WebCoreHistoryProvider containsURL:length:]): Updated for method name change.
1586
1587 2007-12-07  Geoffrey Garen  <ggaren@apple.com>
1588
1589         Reviewed by Sam Weinig.
1590         
1591         Added a forwarding header, since we now #include nodes.h through some
1592         JavaScriptCore headers.
1593
1594         * ForwardingHeaders/wtf/ListRefPtr.h: Added.
1595
1596 2007-12-06  Brady Eidson  <beidson@apple.com>
1597
1598         Reviewed by Oliver's rubber stamp
1599
1600         Let's go ahead and call the correct UI Delegate method, shall we?
1601
1602         * WebCoreSupport/WebChromeClient.mm:
1603         (WebChromeClient::requestQuotaIncreaseForDatabaseOperation): Call the correct UI delegate
1604
1605 2007-12-06  Adam Roben  <aroben@apple.com>
1606
1607         Remove some assertions we know can fire and replace them with a FIXME
1608
1609         Reviewed by Anders.
1610
1611         * WebCoreSupport/WebFrameLoaderClient.mm:
1612
1613 2007-12-06  Timothy Hatcher  <timothy@apple.com>
1614
1615         Change the ASSERT added for the previous fix. The ASSERT was firing for 10.5.0.
1616         Only assert if the major version is zero, since zero is handled in the other cases.
1617
1618         * WebView/WebView.mm:
1619         (callGestalt): Remove the ASSERT.
1620         (createMacOSXVersionString): ASSERT that major is not zero.
1621
1622 2007-12-06  Darin Adler  <darin@apple.com>
1623
1624         Reviewed by Tim Hatcher.
1625
1626         - fix <rdar://problem/5513394> No way to detect Tiger vs Leopard from Safari's user agent string
1627
1628         * WebView/WebView.mm:
1629         (callGestalt): Added.
1630         (createMacOSXVersionString): Added.
1631         (-[WebView _userAgentWithApplicationName:andWebKitVersion:]): Added Mac OS X version string,
1632         right after the string "Mac OS X", but with underscores instead of dots to avoid the dreaded
1633         "4." problem (old libraries that think a "4." anywhere in the user agent means Netscape 4).
1634         (-[WebView _userAgentForURL:]): Fixed incorrect bug numbers.
1635
1636 2007-12-04  Geoffrey Garen  <ggaren@apple.com>
1637
1638         Reviewed by Darin Adler.
1639
1640         Third step in refactoring JSGlobalObject: Moved data members and data
1641         member access from Interpreter to JSGlobalObject.
1642         
1643         * WebView/WebFrame.mm:
1644         (-[WebFrame _attachScriptDebugger]):
1645
1646 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
1647
1648         Reviewed by Darin.
1649
1650         - <rdar://5621435>
1651         - Security Fix. Instead of having it off by default, WebKit now must
1652         explicitly turn off local-resource restriction when needed for backwards
1653         coimpatibility reasons.
1654
1655         * WebView/WebView.mm:
1656         (-[WebView _commonInitializationWithFrameName:groupName:]):
1657
1658 2007-12-05  Brady Eidson  <beidson@apple.com>
1659
1660         Reviewed by Kevin Deckers rubberstamp
1661
1662         Disclose and export the Databases Directory defaults key
1663
1664         * Storage/WebDatabaseManager.mm:
1665         * Storage/WebDatabaseManagerPrivate.h:
1666         * WebKit.exp:
1667
1668 2007-12-04  Kevin Decker  <kdecker@apple.com>
1669
1670         Reviewed by Anders.
1671
1672         <rdar://problem/5629125> PluginInfoStore needs the ability to return the name of a plug-in for a given MIME type
1673
1674         * WebCoreSupport/WebViewFactory.mm:
1675         (-[WebViewFactory pluginNameForMIMEType:]): Added.
1676
1677 2007-12-04  Brady Eidson  <beidson@apple.com>
1678
1679         Reviewed by Mark Rowe
1680
1681         Tweaked the way we typedef and cast these objc_msgSend calls
1682
1683         * WebView/WebView.mm:
1684         (CallDelegateReturningUnsignedLongLong):
1685
1686 2007-12-04  John Sullivan  <sullivan@apple.com>
1687
1688         Reviewed by Brady Eidson (with help from Mark Rowe)
1689         
1690         Fixed return values for unsigned-long-long delegate methods
1691
1692         * WebView/WebView.mm:
1693         (CallDelegateReturningUnsignedLongLong):
1694         redid the change that Brady did at home over the weekend but forgot to check in
1695
1696 2007-11-27  Adam Roben  <aroben@apple.com>
1697
1698         Remove -[WebFrameBridge setNeedsReapplyStyles]
1699
1700         This functionality is now WebCore's responsibility.
1701
1702         Reviewed by Hyatt.
1703
1704         * WebCoreSupport/WebFrameBridge.mm:
1705         * WebKit.order:
1706
1707 2007-12-04  John Sullivan  <sullivan@apple.com>
1708
1709         Reviewed by Darin
1710         
1711         Added deleteOrigin: SPI, which isn't fully implemented
1712
1713         * Storage/WebDatabaseManagerPrivate.h:
1714         * Storage/WebDatabaseManager.mm:
1715         (-[WebDatabaseManager deleteOrigin:]):
1716         just calls deleteDatabasesWithOrigin: for now, but needs to delete origin itself too
1717
1718 2007-12-04  Timothy Hatcher  <timothy@apple.com>
1719
1720         Reviewed by Mark Rowe.
1721
1722         Remove a check for early versions of Leopard CFNetwork now that
1723         Leopard has shipped.
1724
1725         * Misc/WebKitVersionChecks.h: Remove WEBKIT_FIRST_CFNETWORK_VERSION_WITH_LARGE_DISK_CACHE_FIX.
1726         * WebView/WebView.mm:
1727         (+[WebView _setCacheModel:]): Remove the early Leopard CFNetwork check.
1728
1729 2007-12-04  Kevin Decker  <kdecker@apple.com>
1730
1731         Reviewed by Darin.
1732
1733         Revised fix for: <rdar://problem/5586978> REGRESSION (Safari 2-3): WebKit sometimes doesn't invoke Flash's NPP_SetWindow function and causes a hang
1734
1735         This fix is exactly the same as chageset 28359 with the exception of an added early return in
1736         updateAndSetWindow to cover the additional case of when a plug-in isn't drawable.
1737         
1738         The CG-based Flash player would sometimes hang because (for CoreGraphics-based plug-ins) our code would
1739         only call into the NPP_SetWindow() function when we tell the plug-in to draw. This created havoc with 
1740         Flash because Flash expects the browser to call NPP_SetWindow() and provide a valid graphics context 
1741         regardless of whether or not it actually needs to draw. 
1742         
1743         * Plugins/WebBaseNetscapePluginView.mm:
1744         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Removed an incorrect comment and toned
1745         down an ASSERT that was too strict. 
1746         (-[WebBaseNetscapePluginView updateAndSetWindow]): Removed an early return for CoreGraphics-based plug-ins
1747         which would sometimes altogether prevent updating the PortState and calling into a plug-ins NPP_SetWindow()
1748         function. Also tweaked a comment and added an early return if the plug-in can't draw.
1749
1750 2007-12-04  Darin Adler  <darin@apple.com>
1751
1752         Reviewed by Kevin Decker.
1753
1754         * WebCoreSupport/WebFrameLoaderClient.h: Removed obsolete privateBrowsingEnabled.
1755         * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
1756         * WebKit.order: Ditto.
1757
1758 2007-12-03  Dan Bernstein  <mitz@apple.com>
1759
1760         Reviewed by Dave Hyatt.
1761
1762         - fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame
1763
1764         * WebView/WebHTMLView.mm:
1765         (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Removed the code
1766         that checked if the view had resized and sent the resize event, since
1767         FrameView sends resize events now.
1768         * WebView/WebHTMLViewInternal.h:
1769
1770 2007-12-03  Timothy Hatcher  <timothy@apple.com>
1771
1772         Reviewed by Darin.
1773
1774         Change WebViewGetResourceLoadDelegateImplementations and WebViewGetFrameLoadDelegateImplementations
1775         to return a pointer to the implementation struct instead of a copy of the struct. This changes
1776         all of the callers to dereference the pointer to access the struct fields.
1777
1778         * Plugins/WebNullPluginView.mm:
1779         (-[WebNullPluginView reportFailure]):
1780         * WebCoreSupport/WebFrameBridge.mm:
1781         * WebCoreSupport/WebFrameLoaderClient.mm:
1782         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
1783         (WebFrameLoaderClient::assignIdentifierToInitialRequest):
1784         (WebFrameLoaderClient::dispatchWillSendRequest):
1785         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
1786         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
1787         (WebFrameLoaderClient::dispatchDidReceiveResponse):
1788         (WebFrameLoaderClient::willCacheResponse):
1789         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
1790         (WebFrameLoaderClient::dispatchDidFinishLoading):
1791         (WebFrameLoaderClient::dispatchDidFailLoading):
1792         (WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
1793         (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
1794         (WebFrameLoaderClient::dispatchDidCancelClientRedirect):
1795         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1796         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
1797         (WebFrameLoaderClient::dispatchWillClose):
1798         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1799         (WebFrameLoaderClient::dispatchDidReceiveTitle):
1800         (WebFrameLoaderClient::dispatchDidCommitLoad):
1801         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
1802         (WebFrameLoaderClient::dispatchDidFailLoad):
1803         (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
1804         (WebFrameLoaderClient::dispatchDidFinishLoad):
1805         (WebFrameLoaderClient::dispatchDidFirstLayout):
1806         * WebView/WebView.mm:
1807         (WebViewGetResourceLoadDelegateImplementations):
1808         (WebViewGetFrameLoadDelegateImplementations):
1809         (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
1810         * WebView/WebViewInternal.h:
1811
1812 2007-12-03  Timothy Hatcher  <timothy@apple.com>
1813
1814         Reviewed by Brady Eidson.
1815
1816         <rdar://problem/5539913> 188 crashes in WebViewGetFrameLoadDelegateImplementations
1817         <rdar://problem/5586095> CrashTracer: [USER] 5000+ crashes in Safari and Dashboard in dispatchDidFailLoading
1818         <rdar://problem/5607081> CrashTracer: [USER] 2150 crashes in Safari at com.apple.WebKit:
1819         WebViewGetResourceLoadDelegateImplementations + 28
1820
1821         * WebView/WebView.mm:
1822         (-[WebView _cacheResourceLoadDelegateImplementations]): If the delegate is nil, bzero the
1823         implementation cache. This just prevents us from calling getMethod() multiple times just to zero.
1824         (-[WebView _cacheFrameLoadDelegateImplementations]): Ditto.
1825         (WebViewGetResourceLoadDelegateImplementations): Return a zeroed implementations struct
1826         if the WebView is nil. This fixes the crashes.
1827         (WebViewGetFrameLoadDelegateImplementations): Ditto.
1828
1829 2007-12-02  Geoffrey Garen  <ggaren@apple.com>
1830
1831         Reviewed by Eric Seidel.
1832
1833         Updated to match the JavaScriptCore change to move virtual methods from
1834         Interpreter to JSGlobalObject.
1835
1836         * WebView/WebFrame.mm:
1837         (-[WebFrame globalContext]): Use the toRef function instead of manually
1838         casting.
1839
1840 2007-12-01  Brady Eidson  <beidson@apple.com>
1841
1842         Reviewed by Tim
1843
1844         Added a default database quota of 5mb to the default WebPreferences
1845
1846         * WebView/WebPreferences.m:
1847         (+[WebPreferences initialize]):
1848
1849 2007-11-30  John Sullivan  <sullivan@apple.com>
1850
1851         Reviewed by Geoff Garen
1852         
1853         Added another symbol for WebDatabaseManager clients
1854
1855         * WebKit.exp:
1856         added .objc_class_name_WebSecurityOrigin
1857
1858 2007-11-30  Brady Eidson  <beidson@apple.com>
1859
1860         Reviewed by Geoff
1861
1862         Add isEqual operator to WebSecurityOrigin
1863
1864         * Storage/WebSecurityOrigin.mm:
1865         (-[WebSecurityOrigin isEqual:]):
1866
1867 2007-11-30  John Sullivan  <sullivan@apple.com>
1868
1869         Reviewed by Darin
1870         
1871         Tweaks to newly-declared NSString * constants to make them usable from clients
1872
1873         * Storage/WebDatabaseManagerPrivate.h:
1874         * Storage/WebDatabaseManager.mm:
1875         removed "const" from new NSNotification names and userInfo keys; these generate compiler warnings when used
1876         
1877         * WebKit.exp:
1878         export new NSNotification names and userInfo keys so clients can use them
1879
1880 2007-11-29  Anders Carlsson  <andersca@apple.com>
1881
1882         Reviewed by John.
1883
1884         Rename WebKitShrinksStandaloneImagesToFitKey to WebKitShrinksStandaloneImagesToFit.
1885         
1886         This is safe to do because the preference is off by default and Safari 3, which is the only client that turns it on,
1887         is using the setter and not messing around with NSUserDefaults.
1888         
1889         * WebView/WebPreferenceKeysPrivate.h:
1890         * WebView/WebPreferences.m:
1891         (+[WebPreferences initialize]):
1892         (-[WebPreferences shrinksStandaloneImagesToFit]):
1893         (-[WebPreferences setShrinksStandaloneImagesToFit:]):
1894
1895 2007-11-29  Brady Eidson  <beidson@apple.com>
1896
1897         Reviewed by Anders
1898
1899         Support for <rdar://problem/5556381> and <rdar://problem/5556379>
1900
1901         Hook up UI Delegate calls for the database engine feature and other small tweaks
1902
1903         * Storage/WebDatabaseManager.mm:
1904         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Renamed databaseName parameter to databaseIdentifier for clarity
1905         (-[WebDatabaseManager deleteDatabase:withOrigin:]): Renamed databaseName parameter to databaseIdentifier for clarity
1906         * Storage/WebDatabaseManagerPrivate.h:
1907
1908         * Storage/WebDatabaseTrackerClient.h:
1909         * Storage/WebDatabaseTrackerClient.mm:
1910         (WebDatabaseTrackerClient::dispatchDidModifyDatabase): Renamed databaseName parameter to databaseIdentifier for clarity
1911
1912         * WebCoreSupport/WebChromeClient.h:
1913         * WebCoreSupport/WebChromeClient.mm:
1914         (WebChromeClient::requestQuotaIncreaseForNewDatabase): Call through to the UI Delegate
1915         (WebChromeClient::requestQuotaIncreaseForDatabaseOperation): Ditto
1916
1917         * WebView/WebUIDelegatePrivate.h: Added the two UI Delegate methods
1918
1919         * WebView/WebView.mm:
1920         (CallDelegateReturningUnsignedLongLong):
1921         (CallUIDelegateReturningUnsignedLongLong):
1922         * WebView/WebViewInternal.h:
1923
1924 2007-11-28  Kevin McCullough  <kmccullough@apple.com>
1925
1926         Reviewed by Sam.
1927
1928         - Added recursive runloop guards.
1929
1930         * DefaultDelegates/WebScriptDebugServer.m:
1931         (-[WebScriptDebugServer suspendProcessIfPaused]):
1932
1933 2007-11-29  Mark Rowe  <mrowe@apple.com>
1934
1935         Reviewed by Oliver Hunt.
1936
1937         Fix an assertion failure seen on the layout tests, and when closing the window after
1938         visiting <http://www.coudal.com/losalamos/>.
1939
1940         * Plugins/WebBaseNetscapePluginStream.mm:
1941         (-[WebBaseNetscapePluginStream _destroyStream]): Unlink the file and close the file
1942         descriptor even when the stream is being destroyed without the load completing. This
1943         avoids leaking the path and file descriptor, and leaving the temporary file on disk.
1944
1945 2007-11-28  Adele Peterson  <adele@apple.com>
1946
1947         Reviewed by Darin.
1948
1949         Fix for <rdar://problem/5524216> CrashTracer: [USER] 496 crashes in Safari at com.apple.WebCore: WebCore::Frame::eventHandler const + 6
1950
1951         The CrashTracer shows a variety of crashes in different methods (including keyDown and keyUp). This change adds nil checks for the frame in 
1952         WebHTMLView to prevent future problems in other methods as well.
1953
1954         * WebView/WebHTMLView.mm:
1955         (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
1956         (-[WebHTMLView keyDown:]):
1957         (-[WebHTMLView keyUp:]):
1958         (-[WebHTMLView flagsChanged:]):
1959         (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
1960         (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
1961         (-[WebHTMLView checkSpelling:]):
1962         (-[WebHTMLView showGuessPanel:]):
1963         (-[WebHTMLView indent:]):
1964         (-[WebHTMLView outdent:]):
1965         (-[WebHTMLView paste:]):
1966         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
1967         (-[WebHTMLView insertText:]):
1968         (-[WebHTMLView selectionTextRects]):
1969
1970 2007-11-28  Dan Bernstein  <mitz@apple.com>
1971
1972         Reviewed by Maciej Stachowiak.
1973
1974         - fix <rdar://problem/5596160> fast/events/objc-event-api.html fails when run alone (or first)
1975
1976         * WebView/WebHTMLView.mm:
1977         (-[WebHTMLView setDataSource:]): This method calls addMouseMovedObserver
1978         because addMouseMovedObserver returns early if the dataSource
1979         is not nil. But if the dataSource is already set (which happens when
1980         a WebHTMLView is being reused) then addMouseMovedObserver must not
1981         be called again.
1982
1983 2007-11-27  Anders Carlsson  <andersca@apple.com>
1984
1985         Reviewed by Brady.
1986
1987         * Storage/WebDatabaseManager.mm:
1988         * Storage/WebDatabaseManagerPrivate.h:
1989         * Storage/WebDatabaseTrackerClient.mm:
1990         (WebDatabaseTrackerClient::dispatchDidModifyOrigin):
1991         (WebDatabaseTrackerClient::dispatchDidModifyDatabase):
1992         * Storage/WebSecurityOrigin.mm:
1993         (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]):
1994         * Storage/WebSecurityOriginInternal.h:
1995
1996 2007-11-27  Kevin Decker  <kdecker@apple.com>
1997
1998         Reviewed by Darin, landed by Anders.
1999
2000         Fixed: <rdar://problem/4610818> CrashTracer: 1533 crashes in Safari at com.macromedia.Flash Player.plugin: native_ShockwaveFlash_TCallLabel + 271131
2001
2002         The problem was that some Leopard users were still inadvertently using the old Flash 8 plug-in, even though Leopard
2003         shipped with Flash 9. To avoid loading an older version of a plug-in when a newer version is installed, the plug-in
2004         database will compare bundle versions and always load the latest version.
2005
2006         * Plugins/WebBasePluginPackage.h:
2007         * Plugins/WebBasePluginPackage.m:
2008         (-[WebBasePluginPackage versionNumber]): New method. CFBundleGetVersionNumber doesn't work with all possible versioning schemes,
2009         but we think for now it's good enough for us.
2010         * Plugins/WebPluginDatabase.m:
2011         (considerCandidate): Added a C utility function which compares the current plug-in against a candidate plug-in's version number.
2012         If both plug-ins have the same bundle ID and the candiate is newer, the current plug-in becomes the candidate.
2013         (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]): Calls the new considerCandidate() function.
2014
2015 2007-11-26  Timothy Hatcher  <timothy@apple.com>
2016
2017         Reviewed by Dave Hyatt.
2018
2019         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
2020
2021         * WebView/WebPreferenceKeysPrivate.h: Define WebKitRespectStandardStyleKeyEquivalentsPreferenceKey.
2022         * WebView/WebPreferences.m:
2023         (+[WebPreferences initialize]): Default WebKitRespectStandardStyleKeyEquivalentsPreferenceKey to YES.
2024         (-[WebPreferences authorAndUserStylesEnabled]): Return the setting's BOOL value.
2025         (-[WebPreferences setAuthorAndUserStylesEnabled:]): Set the setting's BOOL value.
2026         * WebView/WebPreferencesPrivate.h: Add authorAndUserStylesEnabled and setAuthorAndUserStylesEnabled:.
2027         * WebView/WebView.mm:
2028         (-[WebView _preferencesChangedNotification:]): Update WebCore::Settings::authorAndUserStylesEnabled.
2029
2030 2007-11-26  Brady Eidson  <beidson@apple.com>
2031
2032         Reviewed by Mark Rowe
2033
2034         Provide API for setting the default storage quota per database origin
2035
2036         * Misc/WebNSDictionaryExtras.h:
2037         * Misc/WebNSDictionaryExtras.m:
2038         (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Helper for UINT64 preferences
2039
2040         * WebView/WebPreferenceKeysPrivate.h:
2041         * WebView/WebPreferences.m:
2042         (-[WebPreferences _unsignedLongLongValueForKey:]): Helper for UINT64 prefs
2043         (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto
2044         (-[WebPreferences defaultDatabaseQuota]):
2045         (-[WebPreferences setDefaultDatabaseQuota:]):
2046         * WebView/WebPreferencesPrivate.h:
2047
2048         * WebView/WebView.mm:
2049         (-[WebView _preferencesChangedNotification:]): Set the WebCore Settings version of the default storage pref
2050
2051 2007-11-26  Darin Adler  <darin@apple.com>
2052
2053         Reviewed by Adele.
2054
2055         - some middle-mouse-button-related fixes
2056
2057         These don't affect Safari since it maps the middle mouse button to the command key,
2058         but that might not always be the case for future versions.
2059
2060         * WebView/WebHTMLView.mm:
2061         (-[WebHTMLView otherMouseDown:]): Pass through middle mouse down events to WebCore.
2062         (-[WebHTMLView otherMouseDragged:]): Ditto, for drag events.
2063         (-[WebHTMLView otherMouseUp:]): Ditto, for up events.
2064
2065         * WebView/WebPolicyDelegate.h: Fixed inaccurate documentation of WebActionButtonKey.
2066
2067 2007-11-26  Anders Carlsson  <andersca@apple.com>
2068
2069         Reviewed by Brady.
2070
2071         Get rid of the WebSecurityOriginPrivate object and store 
2072         the WebCore::SecurityOriginData pointer in the _private field of
2073         the WebSecurityOrigin object instead.
2074         
2075         * Storage/WebDatabaseManager.mm:
2076         (-[WebDatabaseManager databasesWithOrigin:]):
2077         (-[WebDatabaseManager detailsForDatabase:withOrigin:]):
2078         (-[WebDatabaseManager deleteDatabasesWithOrigin:]):
2079         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
2080         * Storage/WebSecurityOrigin.mm:
2081         (-[WebSecurityOrigin initWithProtocol:domain:port:]):
2082         (-[WebSecurityOrigin protocol]):
2083         (-[WebSecurityOrigin domain]):
2084         (-[WebSecurityOrigin port]):
2085         (-[WebSecurityOrigin usage]):
2086         (-[WebSecurityOrigin quota]):
2087         (-[WebSecurityOrigin setQuota:]):
2088         (-[WebSecurityOrigin dealloc]):
2089         (-[WebSecurityOrigin finalize]):
2090         (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]):
2091         (-[WebSecurityOrigin _core]):
2092         * Storage/WebSecurityOriginInternal.h:
2093
2094 2007-11-26  Timothy Hatcher  <timothy@apple.com>
2095
2096         Reviewed by Adam Roben.
2097
2098         Bug 16137: Web Inspector window on Leopard should have a unified toolbar and window title
2099         http://bugs.webkit.org/show_bug.cgi?id=16137
2100
2101         Create the Web Inspector window with the textured style. Set the content border
2102         thickness for the top of the window or the height of the toolbar. Also make the
2103         window's bottom corners square, since a normal textured window normally has
2104         rounded bottom corners.
2105
2106         * WebCoreSupport/WebInspectorClient.mm:
2107         (-[WebInspectorWindowController window]):
2108
2109 2007-11-24  Mark Rowe  <mrowe@apple.com>
2110
2111         Tiger build fix.
2112
2113         * Plugins/WebBaseNetscapePluginStream.mm:
2114         (CarbonPathFromPOSIXPath): Use WebCFAutorelease as this also works on Tiger.
2115
2116 2007-11-24  Mark Rowe  <mrowe@apple.com>
2117
2118         Reviewed by Tim Hatcher.
2119
2120         Fix <rdar://problem/5432686> 333MB RPRVT seems to leak @ www.43folders.com (1hr plug-in stream).
2121         http://bugs.webkit.org/show_bug.cgi?id=13705
2122
2123         Have NP_ASFILE and NP_ASFILEONLY streams write the data to disk as they receive it rather than
2124         dumping the data to disk in a single go when the stream has completed loading.  On a test case
2125         involving a 150MB Flash movie being streamed from a local web server this reduces memory consumption
2126         on page load from around 400MB to 22MB.
2127
2128         The only plugin I have found that uses NP_ASFILE or NP_ASFILEONLY on the Mac is our NetscapeMoviePlugin
2129         example code so the NP_ASFILE portion of this change has not had any testing with a real-world plugin.
2130
2131         * Plugins/WebBaseNetscapePluginStream.h:
2132         * Plugins/WebBaseNetscapePluginStream.mm:
2133         (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]):
2134         (-[WebBaseNetscapePluginStream dealloc]):
2135         (-[WebBaseNetscapePluginStream finalize]):
2136         (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]):
2137         (-[WebBaseNetscapePluginStream _destroyStream]): Update to work with paths as NSStrings.
2138         (-[WebBaseNetscapePluginStream _deliverDataToFile:]): Open the file if it is not already open, and write any data
2139         to disk.
2140         (-[WebBaseNetscapePluginStream finishedLoading]): If the stream is NP_ASFILE or NP_ASFILEONLY we need to ensure
2141         that the file exists before _destroyStream passes it to the plugin.  Simulating the arrival of an empty data block
2142         ensure that the file will be created if it has not already.
2143         (-[WebBaseNetscapePluginStream receivedData:]):
2144         (CarbonPathFromPOSIXPath):
2145         * Plugins/WebBaseNetscapePluginView.mm:
2146         (-[WebBaseNetscapePluginView pluginViewFinishedLoading:]): Data is dealt with incrementally so there's no need to pass
2147         it to finishedLoading.
2148         (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Ditto.
2149
2150 2007-11-23  Oliver Hunt  <oliver@apple.com>
2151
2152         Reviewed by Mark Rowe.
2153         
2154         Fixed <rdar://problem/3759190> allow input methods the option of processing mouse events themselves
2155
2156         * WebView/WebHTMLView.mm:
2157         (-[WebHTMLView mouseDown:]):
2158
2159 2007-11-22  Dan Bernstein  <mitz@apple.com>
2160
2161         Reviewed by Antti Koivisto.
2162
2163         - http://bugs.webkit.org/show_bug.cgi?id=15811
2164           WebKit plug-ins can re-enter WebKit under attach()
2165           <rdar://problem/5577978>
2166
2167         * Plugins/WebNullPluginView.mm:
2168         (-[WebNullPluginView viewDidMoveToWindow]): Removed workaround for the
2169         above bug that added as part of fixing
2170         <http://bugs.webkit.org/show_bug.cgi?id=15804>.
2171
2172 2007-11-21  Mark Rowe  <mrowe@apple.com>
2173
2174         Reviewed by Eric.
2175
2176         Fix WebKit to build without warnings under GCC 4.2.
2177
2178         * Configurations/Base.xcconfig:
2179
2180 2007-11-21  Mark Rowe  <mrowe@apple.com>
2181
2182         Reviewed by Tim Hatcher.
2183
2184         Changes due to <rdar://problem/5602936> Need to resolve new GCC 4.2 warnings
2185
2186         Update format strings to use format specifiers that match the argument types.
2187
2188         * Misc/WebGraphicsExtras.c:
2189         (WebConvertBGRAToARGB):
2190
2191 2007-11-19  Brady Eidson <beidson@apple.com>
2192
2193         Reviewed by Maciej
2194
2195         Finished hooking up the WebKit API for database management.
2196         Most of the API is actually implemented in WebCore and some of those methods might
2197         only be stubs for now.
2198
2199         * Storage/WebDatabaseManager.mm:
2200         (-[WebDatabaseManager origins]): Call through to the WebCore tracker and construct an API result
2201         (-[WebDatabaseManager databasesWithOrigin:]): Ditto
2202         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Ditto
2203
2204         * Storage/WebSecurityOrigin.mm:
2205         (-[WebSecurityOrigin usage]): Call through to WebCore
2206         (-[WebSecurityOrigin quota]): Ditto
2207         (-[WebSecurityOrigin setQuota:]): Ditto
2208         (-[WebSecurityOrigin _core]): Get WebCore version of this object
2209         * Storage/WebSecurityOriginInternal.h:
2210
2211 2007-11-17  Timothy Hatcher  <timothy@apple.com>
2212
2213         Reviewed by Mark Rowe.
2214
2215         Bug 13470: i18n: The Web Inspector is not localizable
2216         http://bugs.webkit.org/show_bug.cgi?id=13470
2217
2218         Implement the localizedStringsURL() client method to return the
2219         localized URL of InspectorLocalizedStrings.js in WebCore.
2220
2221         * WebCoreSupport/WebInspectorClient.h: Added localizedStringsURL.
2222         * WebCoreSupport/WebInspectorClient.mm:
2223         (WebInspectorClient::localizedStringsURL): Added.
2224         (WebInspectorClient::updateWindowTitle): Localized the window title.
2225         (-[WebInspectorWindowController init]): Remove a FIXME that dosen't make sense anymore.
2226         (-[WebInspectorWindowController initWithInspectedWebView:]): Code style cleanup.
2227
2228 2007-11-17  Alexey Proskuryakov  <ap@webkit.org>
2229
2230         Reviewed by Darin.
2231
2232         http://bugs.webkit.org/show_bug.cgi?id=15969
2233         Eliminate Editor::deleteRange()
2234
2235         * WebView/WebHTMLView.mm:
2236         (+[WebHTMLView initialize]):
2237         (-[WebHTMLView yank:]):
2238         (-[WebHTMLView yankAndSelect:]):
2239         (-[WebHTMLView setMark:]):
2240         (-[WebHTMLView deleteToMark:]):
2241         (-[WebHTMLView selectToMark:]):
2242         (-[WebHTMLView swapWithMark:]):
2243         Pushed all kill ring methods to WebCore. They were guilty of using Editor::deleteRange()!
2244
2245 2007-11-16  Mark Rowe  <mrowe@apple.com>
2246
2247         Reviewed by Tim Hatcher.
2248
2249         Build WebCore as a sub-framework of WebKit in all configurations.
2250
2251         * Configurations/WebKit.xcconfig:
2252
2253 2007-11-16  John Sullivan  <sullivan@apple.com>
2254
2255         Reviewed by Brady
2256
2257         * WebKit.exp:
2258         Exported some new database-related symbols
2259
2260 2007-11-16  Brady Eidson  <beidson@apple.com>
2261
2262         Reviewed by John
2263
2264         Database management API tweaks
2265
2266         Fleshed out "WebSecurityOrigin" to be the API object representing an origin.  This relieves some
2267         burden off WebDatabaseManager and allows usage/quota operations on the SecurityOrigin object itself
2268
2269         Also added a new subdirectory for Storage related API - Why are we afraid to add new directories to
2270         the WebKit tree?
2271
2272         * Misc/WebSecurityOrigin.mm: Removed.
2273         * Misc/WebSecurityOriginInternal.h: Removed.
2274         * Misc/WebSecurityOriginPrivate.h: Removed.
2275
2276         * Storage/WebDatabaseManager.mm: Work in terms of WebSecurityOrigin
2277         * Storage/WebDatabaseManagerPrivate.h:
2278
2279         * Storage/WebSecurityOrigin.mm: Added.
2280         (-[WebSecurityOriginPrivate initWithProtocol:domain:port:]):
2281         (-[WebSecurityOriginPrivate initWithWebCoreSecurityOrigin:]):
2282         (-[WebSecurityOriginPrivate finalize]):
2283         (-[WebSecurityOriginPrivate dealloc]):
2284         (-[WebSecurityOrigin initWithProtocol:domain:]):
2285         (-[WebSecurityOrigin initWithProtocol:domain:port:]):
2286         (-[WebSecurityOrigin protocol]):
2287         (-[WebSecurityOrigin domain]):
2288         (-[WebSecurityOrigin port]):
2289         (-[WebSecurityOrigin usage]): 
2290         (-[WebSecurityOrigin quota]):
2291         (-[WebSecurityOrigin setQuota:]): Clients will set quotas on the WebSecurityOrigin object itself
2292         (-[WebSecurityOrigin dealloc]):
2293         (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]):
2294         * Storage/WebSecurityOriginInternal.h: Added.
2295         * Storage/WebSecurityOriginPrivate.h: Added.
2296
2297 2007-11-15  Brady Eidson  <beidson@apple.com>
2298
2299         Reviewed by John
2300
2301         Stubbing out everything required for a WebKit API for databases
2302
2303         These interfaces seem to provide everything we need for UI and management at the browser level
2304
2305         * Misc/WebDatabaseManager.h: Removed.
2306         * Misc/WebDatabaseManager.mm: Removed.
2307         * Misc/WebDatabaseManagerPrivate.h: Removed.
2308
2309         * Misc/WebSecurityOrigin.mm: Added. Object that acts as a container for the "SecurityOrigin tuple"
2310           (protocol, domain, and port)
2311         (-[WebSecurityOriginPrivate initWithProtocol:domain:port:]):
2312         (-[WebSecurityOriginPrivate dealloc]):
2313         (-[WebSecurityOrigin initWithProtocol:domain:]):
2314         (-[WebSecurityOrigin initWithProtocol:domain:port:]):
2315         (-[WebSecurityOrigin protocol]):
2316         (-[WebSecurityOrigin domain]):
2317         (-[WebSecurityOrigin port]):
2318         (-[WebSecurityOrigin dealloc]):
2319         (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:WebCore::]):
2320         * Misc/WebSecurityOriginInternal.h: Added.
2321         * Misc/WebSecurityOriginPrivate.h: Added.
2322
2323         * Storage/WebDatabaseManager.mm: Added.
2324         (+[WebDatabaseManager sharedWebDatabaseManager]):
2325         (-[WebDatabaseManager origins]):  Get a list of all origins currently tracked
2326         (-[WebDatabaseManager detailsForOrigin:]): Get the current usage and current quota for the given origin
2327         (-[WebDatabaseManager databasesWithOrigin:]): Get all databases for a certain origin
2328         (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Get all details about a specific database
2329         (-[WebDatabaseManager setQuota:forOrigin:]): Change origin-wide quota
2330         (-[WebDatabaseManager deleteAllDatabases]):
2331         (-[WebDatabaseManager deleteAllDatabasesWithOrigin:]):
2332         (-[WebDatabaseManager deleteDatabase:withOrigin:]):
2333         * Storage/WebDatabaseManagerPrivate.h: Added.
2334         * Storage/WebDatabaseManagerInternal.h: Added.
2335         (WebKitInitializeDatabasesIfNecessary): One-time initialization of database-related things
2336
2337         * Storage/WebDatabaseTrackerClient.h: Added. Stubbed out client for notifications
2338         * Storage/WebDatabaseTrackerClient.mm: Added.
2339         (WebDatabaseTrackerClient::sharedWebDatabaseTrackerClient):
2340         (WebDatabaseTrackerClient::WebDatabaseTrackerClient):
2341         (WebDatabaseTrackerClient::~WebDatabaseTrackerClient):
2342         (WebDatabaseTrackerClient::dispatchDidModifyOrigin):
2343         (WebDatabaseTrackerClient::dispatchDidModifyDatabase):
2344
2345         * WebView/WebView.mm:
2346         (-[WebView _commonInitializationWithFrameName:groupName:]): Do one-time initialization of
2347           Database-related things here
2348
2349 2007-11-13  Geoffrey Garen  <ggaren@apple.com>
2350
2351         Reviewed by Anders Carlsson.
2352         
2353         Renamed Shared to RefCounted.
2354
2355         * ForwardingHeaders/wtf/RefCounted.h: Copied from WebKit/mac/ForwardingHeaders/wtf/Shared.h.
2356         * ForwardingHeaders/wtf/Shared.h: Removed.
2357         * WebCoreSupport/WebContextMenuClient.h:
2358
2359 2007-11-13  Geoffrey Garen  <ggaren@apple.com>
2360
2361         Reviewed by Sam Weinig.
2362
2363         Moved Shared.h into wtf so it could be used in more places.
2364
2365         * ChangeLog:
2366         * WebCoreSupport/WebContextMenuClient.h:
2367
2368 2007-11-13  John Sullivan  <sullivan@apple.com>
2369
2370         Reviewed by Darin.
2371
2372         removed recently-added PreferredType concept; we found a better way to do what
2373         ths was accomplishing
2374
2375         * WebCoreSupport/WebChromeClient.mm:
2376         (WebChromeClient::createWindow):
2377         removed use of PreferredType
2378
2379 2007-11-13  John Sullivan  <sullivan@apple.com>
2380
2381         Reviewed by Dan Bernstein.
2382         
2383         - fixed <rdar://problem/5567954> REGRESSION (Safari 2-3): Autofill no longer automatically fills in 
2384         form fields other than the one you're typing into
2385
2386         * WebCoreSupport/WebEditorClient.mm:
2387         (selectorForKeyEvent):
2388         correct the key identifier strings for Tab and Esc; these were updated in WebCore as part of r21445
2389         but didn't get updated here.
2390
2391 2007-11-12  Josh Aas  <joshmoz@gmail.com>
2392
2393         Reviewed by Darin.
2394
2395         - http://bugs.webkit.org/show_bug.cgi?id=15946
2396           add NPPValue NPPVpluginDrawingModel (Mozilla bug 403418 compat)
2397
2398         * Plugins/WebBaseNetscapePluginView.mm:
2399         (-[WebBaseNetscapePluginView setVariable:value:]):
2400
2401 2007-11-12  Alexey Proskuryakov  <ap@webkit.org>
2402
2403         Reviewed by Darin.
2404
2405         http://bugs.webkit.org/show_bug.cgi?id=15954
2406         Move DOM Selection operations out of SelectionController
2407
2408         * WebView/WebHTMLView.mm:
2409         (-[WebHTMLView _expandSelectionToGranularity:]):
2410         (-[WebHTMLView selectToMark:]):
2411         (-[WebHTMLView swapWithMark:]):
2412         * WebView/WebView.mm:
2413         (-[WebView setSelectedDOMRange:affinity:]):
2414         Adapted for SelectionController::setSelectedRange() now returning a bool.
2415
2416 2007-11-12  Oliver Hunt  <oliver@apple.com>
2417
2418         Reviewed by Darin and Geoff.
2419
2420         <rdar://problem/5522011> The content of the password field of 
2421         Safari is displayed by reconversion.
2422
2423         Some input methods (notably Kotoeri) can incorrectly provide 
2424         access to the raw text of a password field.  To work around 
2425         this we forcefully override the inputContext whenever a password
2426         field is active.
2427
2428         * WebView/WebHTMLView.mm:
2429         (-[WebHTMLView inputContext]):
2430
2431 2007-11-12  John Sullivan  <sullivan@apple.com>
2432
2433         Reviewed by Tim Hatcher
2434         
2435         - speculative fix for <rdar://problem/5509989> CrashTracer: [USER] 1 crash in Safari at com.apple.WebKit: 
2436         -[WebPDFView(FileInternal) _updatePreferencesSoon] + 56
2437         
2438         The crash is probably due to messaging a dealloc'ed dataSource ivar. The dataSource ivar isn't retained
2439         by this class, but should be. (It is retained by WebHTMLView, e.g.).
2440
2441         * WebView/WebPDFView.mm:
2442         (-[WebPDFView dealloc]):
2443         release dataSource ivar
2444         (-[WebPDFView setDataSource:]):
2445         retain dataSource ivar
2446
2447 2007-11-09  Tristan O'Tierney  <tristan@apple.com>
2448
2449         Reviewed by Timothy Hatcher.
2450         
2451         This patch is for the WebKit side of <rdar://problem/5591115>.
2452         We need a way to tell context menu navigations, such as "Open in New Window"
2453         to override any sort of browser preference for tab based navigation.
2454
2455         * WebCoreSupport/WebChromeClient.mm:
2456         (WebChromeClient::createWindow):
2457         Pass up the new preferredType parameter as a string.
2458         
2459 2007-11-09  Timothy Hatcher  <timothy@apple.com>
2460
2461         Reviewed by John.
2462
2463         <rdar://problem/5103720> REGRESSION: [WebView stringByEvaluatingJavaScriptFromString:] fails if "return" is used
2464
2465         Extend the linked on or after check to every application when a script passed to
2466         stringByEvaluatingJavaScriptFromString: has a return statement. Before the check
2467         was limited to VitalSource Bookshelf, but other developers are running into this.
2468
2469         * Misc/WebKitVersionChecks.h: Add the WEBKIT_FIRST_VERSION_WITHOUT_JAVASCRIPT_RETURN_QUIRK define.
2470         * WebView/WebDocumentLoaderMac.mm:
2471         (needsDataLoadWorkaround): Use WEBKIT_FIRST_VERSION_WITHOUT_ADOBE_INSTALLER_QUIRK sicne the
2472           WebKitLinkedOnOrAfter check here was about the Adobe installer, not VitalSource.
2473         * WebView/WebView.mm:
2474         (-[WebView stringByEvaluatingJavaScriptFromString:]): Remove the bundle ID check and use
2475           WEBKIT_FIRST_VERSION_WITHOUT_JAVASCRIPT_RETURN_QUIRK for the WebKitLinkedOnOrAfter call.
2476
2477 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2478
2479         Build Fix.
2480
2481         * WebCoreSupport/WebFrameLoaderClient.h:
2482         * WebCoreSupport/WebFrameLoaderClient.mm:
2483         (WebFrameLoaderClient::windowObjectCleared):
2484
2485 2007-11-07  Darin Adler  <darin@apple.com>
2486
2487         Reviewed by Steve.
2488
2489         - removed some unused WebCore bridge methods
2490
2491         * WebCoreSupport/WebFrameBridge.mm: Removed issueTransposeCommand and overrideMediaType.
2492
2493         * WebCoreSupport/WebFrameLoaderClient.mm:
2494         (WebFrameLoaderClient::overrideMediaType): Changed to call WebView directly instead of
2495         using the bridge object.
2496
2497 2007-11-06  Mark Rowe  <mrowe@apple.com>
2498
2499         Rubber-stamped by Dave Kilzer.
2500
2501         Move Mac files from WebKit into WebKit/mac.
2502
2503         * Carbon: Copied from WebKit/Carbon.
2504         * ChangeLog: Copied from WebKit/ChangeLog.
2505         * ChangeLog-2002-12-03: Copied from WebKit/ChangeLog-2002-12-03.
2506         * ChangeLog-2006-02-09: Copied from WebKit/ChangeLog-2006-02-09.
2507         * ChangeLog-2007-10-14: Copied from WebKit/ChangeLog-2007-10-14.
2508         * Configurations: Copied from WebKit/Configurations.
2509         * DOM: Copied from WebKit/DOM.
2510         * DefaultDelegates: Copied from WebKit/DefaultDelegates.
2511         * ForwardingHeaders: Copied from WebKit/ForwardingHeaders.
2512         * History: Copied from WebKit/History.
2513         * Info.plist: Copied from WebKit/Info.plist.
2514         * MigrateHeaders.make: Copied from WebKit/MigrateHeaders.make.
2515         * Misc: Copied from WebKit/Misc.
2516         * Panels: Copied from WebKit/Panels.
2517         * Plugins: Copied from WebKit/Plugins.
2518         * PublicHeaderChangesFromTiger.txt: Copied from WebKit/PublicHeaderChangesFromTiger.txt.
2519         * Resources: Copied from WebKit/Resources.
2520         * WebCoreSupport: Copied from WebKit/WebCoreSupport.
2521         * WebInspector: Copied from WebKit/WebInspector.
2522         * WebKit.exp: Copied from WebKit/WebKit.exp.
2523         * WebKit.order: Copied from WebKit/WebKit.order.
2524         * WebKitPrefix.h: Copied from WebKit/WebKitPrefix.h.
2525         * WebView: Copied from WebKit/WebView.
2526         * icu: Copied from WebKit/icu.
2527
2528 2007-11-06  Alexey Proskuryakov  <ap@webkit.org>
2529
2530         Reviewed by Darin.
2531
2532         http://bugs.webkit.org/show_bug.cgi?id=15847
2533         Some editing cleanup
2534
2535         No change in functionality.
2536
2537         * WebView/WebHTMLView.mm:
2538         (-[WebHTMLView deleteToEndOfLine:]):
2539         (-[WebHTMLView deleteToEndOfParagraph:]):
2540         WebCore had a duplicate of the same logic already. We are passing a boundary value to
2541         a function that expects granularity, this may need to be straightened out in the future.
2542
2543 2007-11-05  John Sullivan  <sullivan@apple.com>
2544
2545         * WebView/WebView.mm:
2546         (-[WebView _searchWithSpotlightFromMenu:]):
2547
2548         Teeny style tweak to test svn access on other machine
2549
2550 2007-11-05  John Sullivan  <sullivan@apple.com>
2551
2552         * WebView/WebView.mm:
2553         (-[WebView computedStyleForElement:pseudoElement:]):
2554         
2555         Teeny style tweak to test svn access
2556
2557 2007-11-02  Tristan O'Tierney  <tristan@apple.com>
2558
2559         Reviewed by Darin Adler.
2560
2561         * DefaultDelegates/WebDefaultUIDelegate.m:
2562         (-[WebDefaultUIDelegate webView:createWebViewWithRequest:windowFeatures:]):
2563         Forward the UI delegate to call webView:createWebViewWithRequest: if
2564         this method doesn't exist.
2565         
2566         * WebCoreSupport/WebFrameLoaderClient.mm:
2567         (WebFrameLoaderClient::dispatchCreatePage):
2568         * Plugins/WebBaseNetscapePluginView.mm:
2569         (-[WebBaseNetscapePluginView loadPluginRequest:]):
2570         * WebView/WebView.mm:
2571         (-[WebView _openNewWindowWithRequest:]):
2572         Revised to use new webView:createWebViewWithRequest:windowFeatures: callback.
2573         
2574         * WebCoreSupport/WebChromeClient.h:
2575         * WebCoreSupport/WebChromeClient.mm:
2576         (WebChromeClient::createWindow):
2577         Added a new createWindow that accepts 3 parameters, so we can pass up windowFeatures to the chrome.
2578         Removed createModalDialog to use new createWindow function.
2579         
2580         * WebView/WebUIDelegatePrivate.h:
2581         Added new webView:createWebViewWithRequest:windowFeatures: method.
2582
2583 2007-11-05  Geoffrey Garen  <ggaren@apple.com>
2584
2585         Reviewed by Darin Adler.
2586         
2587         http://bugs.webkit.org/show_bug.cgi?id=15835
2588
2589         Small adaptations to new KJS::List class.
2590
2591         * ForwardingHeaders/kjs/value.h: Added.
2592
2593 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2594
2595         Sort files(...); sections of Xcode project files.
2596
2597         Rubber-stamped by Darin.
2598
2599         * WebKit.xcodeproj/project.pbxproj:
2600
2601 2007-11-02  Antti Koivisto  <antti@apple.com>
2602
2603         Reviewed by Darin.
2604         
2605         Add method to enable video composition.
2606
2607         * WebCoreSupport/WebSystemInterface.m:
2608         (InitWebCoreSystemInterface):
2609
2610 2007-11-02  Darin Adler  <darin@apple.com>
2611
2612         Reviewed by Mitz.
2613
2614         - fix problem I ran into while doing some testing on Mac for
2615           <rdar://problem/5530185> WebKit does not show <object>
2616           fallback content when both URL and MIME type is omitted
2617
2618         I don't know how to reproduce this failure in DumpRenderTree, so there is no
2619         regression test.
2620
2621         * Plugins/WebNullPluginView.h: Removed some unneeded declarations, including
2622         the didSendError local variable. Instead we just set the error to nil once
2623         we've sent it.
2624         * Plugins/WebNullPluginView.mm:
2625         (-[WebNullPluginView initWithFrame:error:DOMElement:]): Refactored so that
2626         the null plug-in image code is separate from the rest of the function and
2627         so that the whole thing is not inside an if statement. Also don't hold a
2628         reference to the DOM element if there is no error to report.
2629         (-[WebNullPluginView reportFailure]): Added. Does the actual delegate
2630         callback. Happens back at the top level of the run loop so it doesn't
2631         fire deep inside layout. Also wrote this so that it is guaranteed not to
2632         reenter and so that it can handle the case where the delegate destroys
2633         the world (including this object). NOTE: This is not a real, general
2634         solution to the problem of plug-ins that do work inside layout. We will need
2635         a more general fix that works for other plug-ins, and we'll track that with
2636         a separate bug report.
2637         (-[WebNullPluginView viewDidMoveToWindow]): Removed most of the code;
2638         changed so it just does a performSelector:afterDelay:0.
2639
2640 2007-11-02  Mark Rowe  <mrowe@apple.com>
2641
2642         Reviewed by Darin Adler.
2643
2644         Fix http://bugs.webkit.org/show_bug.cgi?id=15780
2645         Bug 15780: WebFrameLoaderClient: WebActionElementKey wrong if view is scrolled
2646
2647         * WebCoreSupport/WebFrameLoaderClient.mm:
2648         (WebFrameLoaderClient::actionDictionary): Retrieve the mouse event coordinates
2649         in the page coordinate system rather than the client area coordinate system.
2650
2651 2007-11-01  Dan Bernstein  <mitz@apple.com>
2652
2653         Reviewed by Oliver Hunt.
2654
2655         - fix an assertion failure when Command-Tabbing out of Safari
2656
2657         * WebView/WebHTMLView.mm:
2658         (-[WebHTMLView flagsChanged:]): Avoid passing key code 0 down to
2659         WebCore.
2660
2661 2007-11-01  Justin Garcia  <justin.garcia@apple.com>
2662
2663         Reviewed by Oliver Hunt.
2664         
2665         <rdar://problem/5195056> Huge plain text pastes are slow, time spent in ApplyStyleCommand::doApply
2666         
2667         No need to match style when pasting plain text, since the fragment we build for plain text
2668         won't have any style information on it.
2669
2670         * WebView/WebHTMLView.mm:
2671         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]): There's no
2672         longer a need to know whether this function chosePlaintext.
2673         (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
2674         (-[WebHTMLView _documentFragmentFromPasteboard:]):
2675
2676 2007-10-31  Timothy Hatcher  <timothy@apple.com>
2677
2678         Reviewed by John Sullivan.
2679
2680         Move the developer extras preference to WebPreferences.
2681
2682         * WebView/WebPreferenceKeysPrivate.h: Add WebKitDeveloperExtrasEnabledPreferenceKey
2683         * WebView/WebPreferences.m:
2684         (+[WebPreferences initialize]): Initialize WebKitDeveloperExtrasEnabledPreferenceKey to NO.
2685         (-[WebPreferences developerExtrasEnabled]): Check DisableWebKitDeveloperExtras, WebKitDeveloperExtras
2686           and IncludeDebugMenu in addition to WebKitDeveloperExtrasEnabledPreferenceKey.
2687         (-[WebPreferences setDeveloperExtrasEnabled:]): Set WebKitDeveloperExtrasEnabledPreferenceKey.
2688         * WebView/WebPreferencesPrivate.h: Add developerExtrasEnabled and setDeveloperExtrasEnabled:.
2689         * WebView/WebView.mm:
2690         (+[WebView _developerExtrasEnabled]): Removed.
2691         (-[WebView _preferencesChangedNotification:]): Check the WebPreferences object for developerExtrasEnabled.
2692         * WebView/WebViewPrivate.h: Removed _developerExtrasEnabled.
2693
2694 2007-10-30  David D. Kilzer  <ddkilzer@webkit.org>
2695
2696         Generated files missing from WebCore's Xcode project file
2697         <http://bugs.webkit.org/show_bug.cgi?id=15406>
2698
2699         Reviewed by Darin.
2700
2701         Added the following private header files to MigrateHeaders.make:
2702
2703         - DOMCSSStyleSheetPrivate.h
2704         - DOMEventPrivate.h
2705         - DOMHTMLCollectionPrivate.h
2706         - DOMHTMLEmbedElementPrivate.h
2707         - DOMHTMLIFrameElementPrivate.h
2708         - DOMHTMLObjectElementPrivate.h
2709         - DOMHTMLSelectElementPrivate.h
2710
2711         * MigrateHeaders.make:
2712
2713 2007-10-29  Antti Koivisto  <antti@apple.com>
2714
2715         Reviewed by Maciej.
2716         
2717         Some SPIs for media support.
2718
2719         * WebCoreSupport/WebSystemInterface.m:
2720         (InitWebCoreSystemInterface):
2721
2722 2007-10-29  Timothy Hatcher  <timothy@apple.com>
2723
2724         Reviewed by John Sullivan.
2725
2726         Various semi-related changes:
2727         - A WebView can now be asked for it's WebInspector. There is one
2728           WebInspector per WebView. 
2729         - Refactor the WebInspector class and move obsolete methods to
2730           a special category.
2731         - Add new WebInspector methods to show, hide and show the
2732           console/timeline panels.
2733         - Add an isDisabled method to WebCache.
2734         - Allow WebLocalizableStrings.h to be used in C files.
2735
2736         * Misc/WebCache.h: Add isDisabled.
2737         * Misc/WebCache.mm:
2738         (+[WebCache isDisabled]): New method.
2739
2740         * Misc/WebLocalizableStrings.h: Changes to allow use in plain C files.
2741
2742         * WebCoreSupport/WebInspectorClient.mm:
2743         (-[WebInspectorWindowController showWindow:]): Call super if already visible
2744           so the window will be ordered front.
2745         (-[WebInspectorWindowController showWebInspector:]): Method used by menu items,
2746           so they are enabled and work when the Inspector window is key.
2747         (-[WebInspectorWindowController showErrorConsole:]): Ditto.
2748         (-[WebInspectorWindowController showNetworkTimeline:]): Ditto.
2749
2750         * WebInspector/WebInspector.h: Add and remove methods.
2751         * WebInspector/WebInspector.mm:
2752         (-[WebInspector webViewClosed]): Called when the WebView is closed/dealloced.
2753           Clears the _webView pointer.
2754         (-[WebInspector show:]): Calls thru to the Page's InspectorController.
2755         (-[WebInspector showConsole:]): Ditto.
2756         (-[WebInspector showTimeline:]): Ditto.
2757         (-[WebInspector close:]): Ditto.
2758         (-[WebInspector attach:]): Ditto.
2759         (-[WebInspector detach:]): Ditto.
2760         (+[WebInspector sharedWebInspector]): Moved to the obsolete category.
2761         (+[WebInspector webInspector]): Ditto.
2762         (-[WebInspector setWebFrame:]): Ditto.
2763         (-[WebInspector window]): Ditto.
2764         (-[WebInspector showWindow:]): Ditto.
2765
2766         * WebView/WebView.mm:
2767         (-[WebViewPrivate dealloc]): Release the WebInspector.
2768         (-[WebView _close]): Call webViewClosed on the WebInspector.
2769         (-[WebView inspector]): Create a WebInspector if needed and return it.
2770         * WebView/WebViewPrivate.h: Add the inspector method.
2771
2772 2007-10-30  Adele Peterson  <adele@apple.com>
2773
2774         Reviewed by Darin.
2775
2776         WebKit part of fix for http://bugs.webkit.org/show_bug.cgi?id=10577
2777         <rdar://problem/5103625> REGRESSION: Caps lock icon should show in password fields
2778
2779         * WebView/WebHTMLView.mm:
2780         (-[WebHTMLView flagsChanged:]): Call capsLockStateMayHaveChanged so WebCore knows it may have to update a password field.
2781         (+[WebHTMLView _postFlagsChangedEvent:]): Added a comment with a Radar number for why this isn't just in flagsChanged.
2782         (-[WebHTMLView scrollWheel:]): Instead of calling the next responder explicitly, we can just call super, which will take care of this.
2783
2784 2007-10-27  Mark Ambachtsheer  <mark.a@apple.com>
2785
2786         Reviewed by Darin.
2787
2788         Fix for bug 15710, When QD plugins draw to an offscreen bitmap and the plugin is not at 
2789         (0, 0) the clipping rectangle is not correct.
2790         Added the origin to the window clip rectangle coordinates to account for plugins that
2791         don't originate at (0,0); affects code for offscreen GWorlds only.
2792
2793         * Plugins/WebBaseNetscapePluginView.mm:
2794         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2795
2796 2007-10-26  Adele Peterson  <adele@apple.com>
2797
2798         Reviewed by Oliver.
2799
2800         Adding WebKitSystemInterface support for the caps lock indicator
2801
2802         * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
2803
2804 2007-10-25  David Hyatt  <hyatt@apple.com>
2805
2806         Fix for bug 15672, backgrounds don't tile properly inside transforms.  This patch fixes tiling
2807         of backgrounds inside CSS transforms and also of HTML content with background images inside SVG
2808         transforms.
2809
2810         Reviewed by aroben and mmitz
2811
2812         * WebCoreSupport/WebSystemInterface.m:
2813         (InitWebCoreSystemInterface):
2814         * WebKit.xcodeproj/project.pbxproj:
2815
2816 2007-10-25  John Sullivan  <sullivan@apple.com>
2817
2818         Reviewed by Tim Hatcher
2819         
2820         Removed the support for toggling whether WebKit uses the 10.5 PDFKit improvements. Now it
2821         always does, when available.
2822
2823         * WebView/WebPreferencesPrivate.h:
2824         removed _usePDFPreviewView and _setUsePDFPreviewView:. Note that these were guarded with
2825         a comment that says that they can be removed when no longer needed. That time is now.
2826
2827         * WebView/WebPreferences.m:
2828         (+[WebPreferences initialize]):
2829         removed WebKitUsePDFPreviewViewPreferenceKey
2830         (-[WebPreferences _usePDFPreviewView]):
2831         removed
2832         (-[WebPreferences _setUsePDFPreviewView:]):
2833         removed
2834
2835         * WebView/WebPDFView.mm:
2836         (-[WebPDFView initWithFrame:]):
2837         don't check _usePDFPreviewView
2838         
2839         * WebView/WebPreferenceKeysPrivate.h:
2840         removed WebKitUsePDFPreviewViewPreferenceKey
2841         
2842 2007-10-24  Timothy Hatcher  <timothy@apple.com>
2843
2844         Reviewed by Mark Rowe.
2845
2846         <rdar://problem/5069711> OpenSource version of libWebKitSystemInterface.a is Tiger only, causes issues if used on Leopard
2847
2848         Use the WebKitSystemInterface that matches the system version.
2849
2850         * Configurations/DebugRelease.xcconfig:
2851         * WebKit.xcodeproj/project.pbxproj:
2852
2853 2007-10-24  Brady Eidson  <beidson@apple.com>
2854
2855         Reviewed by Anders
2856
2857         <rdar://problem/5554130> DatabaseTracker.o has a global initializer
2858
2859         * Misc/WebDatabaseManager.mm:
2860         (WebKitSetWebDatabasesPathIfNecessary): Call the member function instead of a static one
2861
2862 2007-10-23  Mark Rowe  <mrowe@apple.com>
2863
2864         Build fix for Eric's build fix in r26916.
2865
2866         * MigrateHeaders.make:
2867
2868 2007-10-22  Eric Seidel  <eric@webkit.org>
2869
2870         Reviewed by Maciej.
2871
2872         * MigrateHeaders.make: copy over font-face related DOM headers
2873
2874 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
2875
2876         Reviewed by Mark Rowe.
2877         
2878         Fix for local database support after r26879
2879         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
2880
2881         * Configurations/WebKit.xcconfig:
2882
2883 2007-10-19  Brady Eidson <beidson@apple.com>
2884
2885         Reviewed by Tim Hatcher
2886
2887         Added support for Chrome prompts required by the Storage API
2888         Added support API for future managing of databases from the WebKit client
2889         Added preference and initialization for the databases path
2890
2891         * Misc/WebDatabaseManager.h: Added.  WebDatabaseManager is how a WebKit application can list and
2892           remove the current available databases
2893         * Misc/WebDatabaseManager.mm: Added.
2894         (+[WebDatabaseManager origins]):
2895         (+[WebDatabaseManager databasesWithOrigin:]):
2896         (+[WebDatabaseManager deleteAllDatabases]):
2897         (+[WebDatabaseManager deleteAllDatabasesWithOrigin:]):
2898         (+[WebDatabaseManager deleteDatabaseWithOrigin:named:]):
2899         (WebKitSetWebDatabasesPathIfNecessary): Setup the database path
2900         * Misc/WebDatabaseManagerPrivate.h: Added.
2901
2902         * WebCoreSupport/WebChromeClient.h: Support for calling the delegate to run the prompt for 
2903           an origin exceeding its size limit
2904         * WebCoreSupport/WebChromeClient.mm:
2905         (WebChromeClient::runDatabaseSizeLimitPrompt):
2906         * WebKit.xcodeproj/project.pbxproj:
2907         * WebView/WebUIDelegate.h:
2908
2909         * WebView/WebView.mm:
2910         (-[WebView _commonInitializationWithFrameName:groupName:]): Setup the database path
2911         * WebView/WebViewInternal.h:
2912
2913 2007-10-19  John Sullivan  <sullivan@apple.com>
2914
2915         Reviewed by Tim Hatcher
2916         
2917         - fixed <rdar://problem/5540325> REGRESSION (2.0.4-3): History menu looks odd after clearing history
2918
2919         * History/WebHistory.mm:
2920         (-[WebHistoryPrivate removeAllItems]):
2921         This was fallout from r25275. We need to clear the orderedLastVisitedDays cache here, in addition
2922         to the other places where it's cleared.
2923
2924 2007-10-18  Dan Bernstein  <mitz@apple.com>
2925
2926         Tiger build fix.
2927
2928         * WebView/WebDataSource.mm:
2929         (-[WebDataSource _MIMETypeOfResponse:]):
2930
2931 2007-10-18  Dan Bernstein  <mitz@apple.com>
2932
2933         Reviewed by Adam Roben.
2934
2935         - fix <rdar://problem/5313523>
2936         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
2937
2938         * WebCoreSupport/WebFrameLoaderClient.mm:
2939         (WebFrameLoaderClient::makeDocumentView): Changed to use _responseMIMEType.
2940         * WebView/WebDataSource.mm:
2941         (-[WebDataSource _MIMETypeOfResponse:]): Added. Works around
2942         <rdar://problem/5321972> by testing for the case of an NSHTTPURLResponse
2943         with a MIMEType of application/octet-stream and a Content-Type header
2944         starting with text/plain and returning text/plain as the MIME type in
2945         that case.
2946         (-[WebDataSource _responseMIMEType]): Added. Used to get the correct
2947         response MIME type.
2948         (-[WebDataSource _isDocumentHTML]): Changed to use _responseMIMEType.
2949         (-[WebDataSource _makeRepresentation]): Ditto.
2950         (-[WebDataSource mainResource]): Ditto.
2951         (-[WebDataSource subresources]): Changed to use _MIMETypeOfResponse and
2952         pass the MIME type explicitly.
2953         (-[WebDataSource subresourceForURL:]): Ditto.
2954         * WebView/WebDataSourcePrivate.h:
2955         * WebView/WebFrameView.mm:
2956         (-[WebFrameView _makeDocumentViewForDataSource:]): Changed to use
2957         _responseMIMEType.
2958         * WebView/WebResource.mm:
2959         (-[WebResource _initWithData:URL:response:MIMEType:]): Changed this
2960         method to take a MIME type instead of extracting it from the response,
2961         so that WebDataSource could pass the correct MIME type.
2962         * WebView/WebResourcePrivate.h:
2963
2964 2007-10-17  Darin Adler  <darin@apple.com>
2965
2966         Reviewed by Mark Rowe.
2967
2968         - fix <rdar://problem/5183775> Uninitialized memory in -[WebDynamicScrollBarsView updateScrollers]
2969
2970         * WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]):
2971         Change code path so it doesn't dispatch a method that returns an NSSize passing a nil object.
2972         It's safe to do that for functions that return integers or pointers, but not structures.
2973
2974 2007-10-16  David Kilzer  <ddkilzer@apple.com>
2975
2976         Reviewed by Timothy.
2977
2978         <rdar://problem/5544354> Wrong delegate method called in
2979         WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad()
2980
2981         * WebCoreSupport/WebFrameLoaderClient.mm:
2982         (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): Fixed selector name.
2983
2984 2007-10-16  Darin Adler  <darin@apple.com>
2985
2986         Reviewed by Adele.
2987
2988         - moved transpose command implementation into WebCore
2989
2990         * WebView/WebHTMLView.mm: Removed transpose: and replaced it with standard WebCore forwarding.
2991
2992 2007-10-16  Darin Adler  <darin@apple.com>
2993
2994         Reviewed by Maciej and Geoff (and looked over by Eric).
2995
2996         - http://bugs.webkit.org/show_bug.cgi?id=15519
2997           eliminate use of <ctype.h> for processing ASCII
2998
2999         * ForwardingHeaders/wtf/ASCIICType.h: Added.
3000         * ForwardingHeaders/wtf/DisallowCType.h: Added.
3001
3002         * WebKitPrefix.h: Include DisallowCType.h.
3003
3004         * Misc/WebNSURLExtras.mm: (-[NSURL _web_URLWithLowercasedScheme]): Use toASCIILower.
3005         * WebView/WebHTMLView.mm:
3006         (-[WebHTMLView callWebCoreCommand:]): Use toASCIIUpper.
3007         (-[WebTextCompleteController filterKeyDown:]): Add a list of specific character codes,
3008         instead of using ispunct.
3009
3010 2007-10-16  John Sullivan  <sullivan@apple.com>
3011
3012         Reviewed by Adam Roben
3013         
3014         Cleaned up localizable strings
3015
3016         * English.lproj/Localizable.strings:
3017         updated
3018         * StringsNotToBeLocalized.txt:
3019         updated
3020         * WebKit.xcodeproj/project.pbxproj:
3021         StringsNotToBeLocalized.txt recently moved but project file wasn't updated to match; now it is
3022
3023 2007-10-15  Kevin Decker  <kdecker@apple.com>
3024
3025         Reviewed by Darin Adler.
3026         
3027         Fixed: <rdar://problem/5520541> REGRESSION: Broken image when forwarding certain email on Tiger
3028         
3029         * WebCoreSupport/WebFrameBridge.mm: The problem was that we were loading Mail's WebKit plug-in
3030         too soon, which borked some necessary housekeeping on behalf of Mail. The fix is to add a quirk
3031         that treats Tiger Mail's WebKit plug-in like a Netscape plug-in, thus ensuring the plug-in will
3032         load during first layout and not attach time. For this plug-in, loading at first layout is 
3033         expected and is consistent with Safari 2 behavior.
3034
3035 2007-10-15  John Sullivan  <sullivan@apple.com>
3036
3037         Reviewed by Geoff Garen
3038         
3039         Replaced NS_DURING/NS_HANDLER with @try/@catch throughout WebKit
3040
3041         I made the following changes:
3042         - replaced NS_DURING with @try, and added opening brace if there wasn't one
3043         - replaced NS_HANDLER with @catch (NSException *localException), and added braces if there weren't any
3044         - removed NS_ENDHANDLER, and added a closing brace if there wasn't one
3045         - in a couple of places, fixed indentation therein
3046
3047         * Misc/WebIconDatabase.mm:
3048         (objectFromPathForKey):
3049         * WebView/WebHTMLView.mm:
3050         (-[WebHTMLView drawSingleRect:]):
3051         (-[WebHTMLView beginDocument]):
3052         (-[WebHTMLView deleteToMark:]):
3053         * WebView/WebView.mm:
3054         (-[WebView initWithCoder:]):
3055
3056 == Rolled over to ChangeLog-2007-10-14 ==