Remove last vestiges of JAVASCRIPTCORE_PRIVATE_HEADERS_DIR from WebKit

[WebKit-https.git] / WebKit / mac / ChangeLog

2009-03-03  David Kilzer  <ddkilzer@apple.com>

        Remove last vestiges of JAVASCRIPTCORE_PRIVATE_HEADERS_DIR from WebKit

        Reviewed by Adam Roben.

        Use of JAVASCRIPTCORE_PRIVATE_HEADERS_DIR was removed in r37465
        since NPAPI headers had migrated from JavaScriptCore to WebCore
        before that.

        * Configurations/WebKit.xcconfig: Removed definition of
        JAVASCRIPTCORE_PRIVATE_HEADERS_DIR used in Production builds.

2009-03-03  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Fix <rdar://problem/6633834>.
        
        * Plugins/Hosted/NetscapePluginHostManager.mm:
        (WebKit::NetscapePluginHostManager::instantiatePlugin):
        Create a new plug-in instance if the plug-in host has crashed.
        
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::invalidate):
        Add a null check for the plug-in host proxy.

2009-03-02  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Enable Geolocation (except on Tiger and Leopard).

        * Configurations/WebKit.xcconfig:

2009-03-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        WebKit part of <rdar://problem/6638658>.
        
        * Plugins/Hosted/NetscapePluginHostManager.h:
        * Plugins/Hosted/NetscapePluginHostManager.mm:
        (WebKit::NetscapePluginHostManager::createPropertyListFile):
        Spawn the plug-in host and wait for it to create the property list.
        
        * Plugins/WebBasePluginPackage.mm:
        (-[WebBasePluginPackage createPropertyListFile]):
        Factor code out into a new method.
        
        (-[WebBasePluginPackage pListForPath:createFile:]):
        Call the newly added createPropertyListFile method.
        
        * Plugins/WebNetscapePluginPackage.mm:
        (-[WebNetscapePluginPackage createPropertyListFile]):
        Tell the plug-in host manager to create a property list file for us.

2009-03-02  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen.

        Fix for <rdar://problem/6507404> Add Geolocation support.

        This is not yet turned on for any Mac platform.

        Add SPI to ask the embedding application whether to allow
        Geolocation for an origin.

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::shouldAllowGeolocationForFrame):
        * WebView/WebUIDelegatePrivate.h:

2009-03-02  Anders Carlsson  <andersca@apple.com>

        Fix PowerPC build.

        * Plugins/WebNetscapePluginPackage.mm:
        (-[WebNetscapePluginPackage _tryLoad]):

2009-03-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by John Sullivan, Ada Chan.

        Factor loading code out into its own method and get rid of a bunch of gotos.
        
        * Plugins/WebNetscapePluginPackage.mm:
        (-[WebNetscapePluginPackage _tryLoad]):
        (-[WebNetscapePluginPackage load]):

2009-03-02  Anders Carlsson  <andersca@apple.com>

        Build fix.

        * Plugins/WebNetscapeDeprecatedFunctions.h:

2009-03-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by John Sullivan.

        Rename WebNetscapePluginPackage.m to WebNetscapePluginPackage.mm

        * Plugins/WebNetscapePluginPackage.m: Removed.
        * Plugins/WebNetscapePluginPackage.mm: Copied from mac/Plugins/WebNetscapePluginPackage.m.

2009-03-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        WebKit side of <rdar://problem/6449689>

        Pass the visible name to the plug-in host.
        
        * Plugins/Hosted/NetscapePluginHostManager.mm:
        (WebKit::NetscapePluginHostManager::spawnPluginHost):

2009-02-27  Alice Liu  <alice.liu@apple.com>

        Fix <rdar://problem/6531265> REGRESSION (r39185): adding ".jpeg"
        extension to images that already have .jpg extension

        Reviewed by Oliver Hunt.

        * WebView/WebHTMLView.mm:
        (-[NSString matchesExtensionEquivalent:]):
        (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
        Relax the check for the proper extension to allow for known
        equivalents, special-cased in matchesExtensionEquivalent function.

2009-02-27  Anders Carlsson  <andersca@apple.com>

        Reviewed by Geoffrey Garen.

        <rdar://problem/6631436>
        CrashTracer: [USER] 1 crash in Safari at com.apple.WebKit • WebKit::NetscapePluginInstanceProxy::addValueToArray + 55
        
        Port the NPN_Evaluate code over from WebCore instead of using the frame loader.
        
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::evaluate):

2009-02-27  Anders Carlsson  <andersca@apple.com>

        Reviewed by Geoffrey Garen.

        WebKit side of <rdar://problem/6626814>.
        
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCInvokeDefault):
        Make InvokeDefault async.
        
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::addValueToArray):
        Handle passing NPObjects back to the plug-in host.
        
        * Plugins/Hosted/ProxyInstance.h:
        (WebKit::ProxyInstance::objectID):
        Add objectID getter.
        
        * Plugins/Hosted/WebKitPluginClient.defs:
        Make InvokeDefault a simpleroutine.

2009-02-27  Timothy Hatcher  <timothy@apple.com>

        Fixes an exception by null checking the WebResource before adding it to
        the subresources array.

        <rdar://problem/5950769> Bug in [WebDataSource subresources] can throw an exception

        Reviewed by Geoff Garen and Anders Carlsson.

        * WebView/WebDataSource.mm:
        (-[WebDataSource subresources]): Null check the WebResource before adding it.

2009-02-27  Timothy Hatcher  <timothy@apple.com>

        Adds a workaround for Automator creating a WebView from a secondary thread.

        <rdar://problem/6631951> REGRESSION (Safari 4 Beta): Automator crash on
        secondary thread beneath -[WebView initWithFrame:frameName:groupName:]

        Reviewed by Geoff Garen.

        * WebView/WebView.mm:
        (needsWebViewInitThreadWorkaround): Check for com.apple.Automator.

2009-02-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add a preference to reduce the power of file:// URLs.

        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):
        (-[WebPreferences allowUniversalAccessFromFileUrls]):
        (-[WebPreferences setAllowUniversalAccessFromFileUrls:]):
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]):

2009-02-27  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson

        https://bugs.webkit.org/show_bug.cgi?id=24242
        
        setCursor(), and resetCursorRects() on Tiger, were using global, not local
        coordinates for elementAtPoint:
        
        * WebView/WebHTMLView.mm:
        (resetCursorRects):
        (setCursor):

2009-02-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add a preference to reduce the power of file:// URLs.

        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):
        (-[WebPreferences allowUniversalAccessFromFileUrls]):
        (-[WebPreferences setAllowUniversalAccessFromFileUrls:]):
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]):

2009-02-26  Adele Peterson  <adele@apple.com>

        Reviewed by Geoff Garen.

        Fix for <rdar://problem/6618166>
        https://bugs.webkit.org/show_bug.cgi?id=24216
        (REGRESSION r36919) Safari 4 Beta causes MSN Messenger's text entry field to lose focus after entering a message

        During a series of firstResponder changes, at some point while the WebHTMLView was losing first responder status,
        we incorrectly marked the page as active, and then when the WebHTMLView became first responder again, setActive did nothing.
        This change restores behavior from before r36919 to check if the WebHTMLView is in the middle of losing first responder when calling setActive.

        In addition to updating editing/selection/designmode-no-caret.html results, I also made sure the test cases that were 
        fixed in r36919 and r38570 are still fixed.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView resignFirstResponder]): Keep track if we're in the process of resigning first responder.
        (-[WebHTMLView _isResigningFirstResponder]): Added.
        * WebView/WebHTMLViewInternal.h:
        * WebView/WebView.mm: (-[WebView _updateFocusedAndActiveStateForFrame:]): Don't set the page to be active
        if the document view is currently resigning first responder.

2009-02-25  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        Fix <rdar://problem/6623697>.
        
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::print):
        Ask the plug-in host to print, create a CGImage of the returned bytes and draw
        the image into the passed in context.
        
        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView drawRect:]):
        When printing, call NetscapePluginInstanceProxy::print.
        
        * Plugins/Hosted/WebKitPluginHost.defs:

2009-02-19  Alexey Proskuryakov  <ap@webkit.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=24024
        REGRESSION (r39845): Assertion failure in -[WebHistoryItem dictionaryRepresentation] when
        archiving a submission to about:blank

        I don't know how to make an automated test for this bug.

        * History/WebHistory.mm: (-[WebHistory _visitedURL:withTitle:method:wasFailure:]):
        Account for the fact that HTTP method may be non-empty for non-HTTP requests.

2009-02-25  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Beth Dakin.

        Naming change from
        Bug 24143: Crash occurs at WebCore::AccessibilityTable::isTableExposableThroughAccessibility() when applying a link in GMail
        https://bugs.webkit.org/show_bug.cgi?id=24143

        * WebView/WebFrame.mm:
        (-[WebFrame _accessibilityTree]):

2009-02-25  Simon Fraser  <simon.fraser@apple.com>

        Build fix with ACCELERATED_COMPOSITING turned on.
        
        I missed a spot in my last commit in renaming to
        _stoppedAcceleratedCompositingForFrame:
        
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView close]):

2009-02-25  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein

        https://bugs.webkit.org/show_bug.cgi?id=23854

        Make an observable property, _isUsingAcceleratedCompositing, on
        WebView that DumpRenderTree can use to specialize behavior.
        
        This is implemented via a count of Frames that are using
        accelerated compositing.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLViewPrivate clear]):
        (-[WebHTMLView close]):
        (-[WebHTMLView attachRootLayer:]):
        (-[WebHTMLView detachRootLayer]):
        * WebView/WebView.mm:
        (+[WebView automaticallyNotifiesObserversForKey:]):
        (-[WebView _startedAcceleratedCompositingForFrame:]):
        (-[WebView _stoppedAcceleratedCompositingForFrame:]):
        (-[WebView _isUsingAcceleratedCompositing]):
        * WebView/WebViewInternal.h:
        * WebView/WebViewPrivate.h:

2009-02-24  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen.

        Related to <rdar://problem/6590295>
        Allow disabling javascript: urls.

        * WebView/WebView.mm:
        (-[WebView _setJavaScriptURLsAreAllowed:]):
        * WebView/WebViewPrivate.h:

2009-02-24  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver Hunt.

        <rdar://problem/6259220> Rename AVAILABLE_AFTER_WEBKIT_VERSION_3_1 (etc.) to match the other macros

        * Carbon/CarbonUtils.h:
        * Carbon/HIWebView.h:
        * Plugins/WebPlugin.h:
        * Plugins/WebPluginViewFactory.h:
        * WebView/WebUIDelegate.h:

2009-02-24  Peter Ammon  <pammon@apple.com>

        Reviewed by Mark Rowe.

        Fix <rdar://problem/6251410> Services can modify non-editable content in Safari

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView validRequestorForSendType:returnType:]): Return self only if we can handle
        both the send and return type.  We should also handle a nil send or return type by ignoring
        the argument and returning whether we can handle the other type passed in.

2009-02-23  Anders Carlsson  <andersca@apple.com>

        Reviewed by Geoffrey Garen and Darin Adler.

        WebKit side of <rdar://problem/6613151>.
        
        Make sure to vm_deallocate all memory we get from MIG callbacks.
        
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (DataDeallocator::DataDeallocator):
        (DataDeallocator::~DataDeallocator):
        Add a simple deallocator class.
        
        (WKPCStatusText):
        (WKPCLoadURL):
        (WKPCBooleanAndDataReply):
        (WKPCEvaluate):
        (WKPCGetStringIdentifier):
        (WKPCInvoke):
        (WKPCInvokeDefault):
        (WKPCConstruct):
        (WKPCSetProperty):
        Use the new deallocator class.

2009-02-23  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Fix <rdar://problem/6450656>.
        
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::insertText):
        Add insert text which just calls the new WKPH function.
        
        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView inputContext]):
        Get the input context from the shared input panel.
        
        (-[WebHostedNetscapePluginView keyDown:]):
        Let the shared input panel have a go at the event first.
        
        * Plugins/Hosted/WebKitPluginHost.defs:
        Add new InsertText function.

2009-02-23  Mark Rowe  <mrowe@apple.com>

        Fix the build after r41126.

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::invoke):
        (WebKit::NetscapePluginInstanceProxy::invokeDefault):
        (WebKit::NetscapePluginInstanceProxy::construct):

2009-02-22  Dan Bernstein  <mitz@apple.com>

        Reviewed by Darin Adler.

        - fix <rdar://problem/5966123> REGRESSION (r30741): Generic Sun Applet loading logo appears half off screen

        * WebCoreSupport/WebFrameLoaderClient.mm: Correct a copy & paste error
        in r30741, and assign the height value, rather than the width, to the
        "height" parameter.

2009-02-21  Anders Carlsson  <andersca@apple.com>

        Fix build.
        
        * Plugins/Hosted/WebTextInputWindowController.m:

2009-02-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Add a shared floating text input window implementation, to be used by the hosted plug-in view.
        
        * Plugins/Hosted/WebTextInputWindowController.h: Added.
        * Plugins/Hosted/WebTextInputWindowController.m: Added.

2009-02-20  Kevin Decker  <kdecker@apple.com>

        Reviewed by andersca.
    
        <rdar://problem/6496140> Safari sometimes hangs in WKSetMetadataURL for several seconds after downloading a file
         
         Spawn a background thread for WKSetMetadataURL because this function will not return until mds has journaled the data
         we are trying to set. Depending on what other I/O is going on, it can take some time. 

        * Misc/WebNSFileManagerExtras.m: Import pthread.h and FoundationExtras.h
        (setMetaData): Added. Calls WKSetMetadataURL().
        (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]): Call setMetaData on a background thread 
 
2009-02-19  Dan Bernstein  <mitz@apple.com>

        Reviewed by Sam Weinig.

        - WebKit part of fixing https://bugs.webkit.org/show_bug.cgi?id=24027
          Do not send loader callbacks during CSS styling

        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]): Reverted the
        iChat-specific quirk added in <http://trac.webkit.org/changeset/41071>.

2009-02-18  Dan Bernstein  <mitz@apple.com>

        Reviewed by Brady Eidson.

        - WebKit part of fixing <rdar://problem/6507512> Crash in iChat at CSSStyleSelector::adjustRenderStyle

        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]): Activate the WebCore
        workaround for this crash in iChat.

2009-02-18  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Fix for <rdar://problem/6542390>
        
        There's no need to call setDefersLoading here - we already defer anything a plug-in can do that
        would cause a load to begin.
        
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView sendEvent:isDrawRect:]):

2009-02-18  Adam Roben  <aroben@apple.com>

        Add SPI to get WebKit's custom pointing-hand cursor

        Reviewed by John Sullivan.

        * WebView/WebView.mm:
        (+[WebView _pointingHandCursor]): Added. Returns the custom
        pointing-hand cursor that WebKit uses.
        * WebView/WebViewPrivate.h: Added +_pointingHandCursor.

2009-02-17  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Antti Koivisto.

        https://bugs.webkit.org/show_bug.cgi?id=23917
        Allow a WebKit plug-in to act as a proxy for the <audio> and <video>
        element.

        * Plugins/WebPluginContainerPrivate.h:
        * Plugins/WebPluginController.mm:
        (mediaProxyClient): New, cast to HTMLMediaElement if it is a video or audio element
        (-[WebPluginController _setMediaPlayerProxy:forElement:]): New, pass proxy to HTMLMediaElement
        (-[WebPluginController _postMediaPlayerNotification:forElement:]): New, deliver event to HTMLMediaElement

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::createPlugin): Don't allow a media player proxy plug-in to be chosen by
        file extension, only want a match for the new MIME type proxy plug-ins should have.

2009-02-13  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        <rdar://problem/6584834> ESPN radio live stream link hangs Safari 

        When a plug-in invokes JavaScript code that will destroy the plug-in, we need to
        defer destruction until we're done executing the script.
        
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WebKit::PluginDestroyDeferrer::PluginDestroyDeferrer):
        (WebKit::PluginDestroyDeferrer::~PluginDestroyDeferrer):
        Add a simple RAII object for deferring destruction of the plug-in instance.
        
        (WKPCEvaluate):
        (WKPCInvoke):
        (WKPCInvokeDefault):
        (WKPCConstruct):
        (WKPCGetProperty):
        (WKPCSetProperty):
        (WKPCRemoveProperty):
        (WKPCHasProperty):
        (WKPCHasMethod):
        Use the PluginDestroyDeferrer.
        
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        (WebKit::NetscapePluginInstanceProxy::pluginID):
        Assert that the plug-in ID is not 0 here.
        
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
        Initialize the call depth.
        
        (WebKit::NetscapePluginInstanceProxy::~NetscapePluginInstanceProxy):
        Set the plug-in ID to 0 to aid debugging.
        
        (WebKit::NetscapePluginInstanceProxy::willCallPluginFunction):
        Increment the call depth.
        
        (WebKit::NetscapePluginInstanceProxy::didCallPluginFunction):
        Decrement the call depth, if it's 0 and we should stop the plug-in, do so.
        
        (WebKit::NetscapePluginInstanceProxy::shouldStop):
        If we're called this with a non-zero call depth, set shouldStopSoon to true.
        
        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView shouldStop]):
        Call the proxy.

2009-02-12  Brady Eidson  <beidson@apple.com>

        Reviewed by Kevin Decker

        <rdar://problem/6582180> - Wrong HTTP method applied to history item.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::updateGlobalHistory): Check the original request, not any
          redirected request.

2009-02-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        <rdar://problem/6579412> 
        REGRESSION (3.2.1-ToT): Crash in Silverlight viewing streaming lecture
        
        * Plugins/WebNetscapePluginView.h:
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView userAgent]):
        Apply workaround for Silverlight workaround.
        
        (-[WebNetscapePluginView _createPlugin]):
        Check if the plug-in that we're creating is the silverlight plug-in.

2009-02-12  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler

        Fix potential ref-count or null-deref problems with C++ objects as Obj-C members.

        * History/WebBackForwardList.mm:
        (-[WebBackForwardList dealloc]): Null check before deref()'ing.
        (-[WebBackForwardList finalize]): Ditto.

        * Misc/WebIconFetcher.mm:
        (-[WebIconFetcher dealloc]): Null check before deref()'ing.
        (-[WebIconFetcher finalize]): Ditto.

        * WebCoreSupport/WebEditorClient.mm: Change to use RefPtr<> instead of ref()/deref().
        (-[WebEditCommand initWithEditCommand:]):
        (-[WebEditCommand dealloc]):
        (-[WebEditCommand finalize]):
        (-[WebEditCommand command]):

        * WebView/WebArchive.mm: Change to use RefPtr<> instead of ref()/deref().
        (-[WebArchivePrivate init]):
        (-[WebArchivePrivate initWithCoreArchive:]):
        (-[WebArchivePrivate coreArchive]):
        (-[WebArchivePrivate setCoreArchive:]):
        (-[WebArchivePrivate dealloc]):
        (-[WebArchivePrivate finalize]):

        * WebView/WebDataSource.mm: 
        (-[WebDataSourcePrivate dealloc]): Null check before deref()'ing.
        (-[WebDataSourcePrivate finalize]): Ditto.

2009-02-12  Brady Eidson  <beidson@apple.com>

        Reviewed by Kevin Decker

        <rdar://problem/6579750> - Crash in WebArchivePrivate in Tiger TextEdit

        NSHTMLReader tries to create a WebArchive from a random chunk of data.  Previously, WebArchive creation would
        fail and return nil and NSHTMLReader would try something else.  When we changed the behavior to return an invalid
        WebArchive object, things started getting weird.

        * WebView/WebArchive.mm:
        (-[WebArchivePrivate setCoreArchive:]): Null check the pointer before calling ->deref()
        (-[WebArchivePrivate dealloc]): Remove the ASSERT which is now invalid, and null check the pointer before ->deref().
        (-[WebArchivePrivate finalize]): Ditto
        (-[WebArchive initWithData:]): If the LegacyWebArchive cannot be created, return nil instead of an invalid object.

2009-02-11  Mark Rowe  <mrowe@apple.com>

        Fix the build.

        * History/WebHistory.mm:
        (-[WebHistoryPrivate visitedURL:withTitle:]): Use ASSERT_UNUSED in a manner that makes sense.

2009-02-11  Brady Eidson  <beidson@apple.com>

        Reviewed by Mark Rowe

        <rdar://problem/6570573> Some visit counts in History.plist have insanely high values, can roll over to negative

        Remove the item from the date caches before registering the visit.  Otherwise it might not be successfully removed 
        and when we add it back later it will exist in the list twice.  This will cause the entry to be written out twice,
        which would lead to doubling (or more!) the visit count on next launch when these multiple items are merged.

        * History/WebHistory.mm:
        (-[WebHistoryPrivate visitedURL:withTitle:]): Swap the removeItemFromDateCaches and visitedWithTitle calls.
        (-[WebHistoryPrivate addItem:discardDuplicate:]): Add a mode that allows the entry being added to be discarded
          if an entry for the URL already exists.  Use that mode when reading the History.plist so only the most
          recent entry for a given URL will be used.
        (-[WebHistoryPrivate addItems:]):
        (-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]): 

2009-02-11  Dimitri Dupuis-latour  <dupuislatour@apple.com>

        Added a preference to disable some Inspector's panels (rdar://6419624, rdar://6419645).
        This is controlled via the 'WebKitInspectorHiddenPanels' key; if nothing is specified, all panels are shown.

        Reviewed by Timothy Hatcher.

        * WebCoreSupport/WebInspectorClient.h:
        * WebCoreSupport/WebInspectorClient.mm:
        (WebInspectorClient::hiddenPanels):

2009-02-11  Alexey Proskuryakov  <ap@webkit.org>

        Reviewed by Darin Adler.

        <rdar://problem/6562920> Pasted text should be normalized to NFC

        * Misc/WebNSURLExtras.mm: (-[NSURL _web_userVisibleString]): Route the URL string through
        -[NSString precomposedStringWithCanonicalMapping].

        * WebCoreSupport/WebPasteboardHelper.mm:
        (WebPasteboardHelper::plainTextFromPasteboard): Ditto. 

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
        Ditto. The affected cases are all plain text ones - RTF, RTFD and HTML are assumed to be
        precomposed already, and the conversion is performed outside WebKit for those anyway.

2009-02-10  John Sullivan  <sullivan@apple.com>

        Reviewed by Dan Bernstein
        
        <https://bugs.webkit.org/show_bug.cgi?id=23889>, <rdar://problem/6572300>
        Negative visit counts stored in History.plist aren't corrected.
        
        It's not clear how a huge negative visit count ended up in History.plist, but we can't
        trust data read from disk so we can at least reset this to something sane. WebCore has
        no guard against a visit count overflowing an int, but that seems very unlikely to have
        caused this.

        * History/WebHistoryItem.mm:
        (-[WebHistoryItem initFromDictionaryRepresentation:]):
        If a negative visit count is in the dictionary, replace it with 1. If a negative daily or
        weekly visit count is in the dictionary, replace it with 0. 

2009-02-10  John Sullivan  <sullivan@apple.com>

        Reviewed by Dan Bernstein
        
        <https://bugs.webkit.org/show_bug.cgi?id=23891>
        [WebHistoryItem _setVisitCount:] is unused and should be removed

        * History/WebHistoryItem.mm:
        (-[WebHistoryItem _setVisitCount:]):
        removed this unused method, which is a synonym for setVisitCount: that was introduced
        recently and abandoned even more recently

        * History/WebHistoryItemInternal.h:
        removed declaration of _setVisitCount:

2009-02-10  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mark Rowe.

        <rdar://problem/6573916> 
        CrashTracer: [USER] 1 crash in Safari at com.apple.WebKit • WebKit::NetscapePluginInstanceProxy::pluginHostDied + 25.
        
        * Plugins/Hosted/NetscapePluginHostManager.mm:
        (WebKit::NetscapePluginHostManager::instantiatePlugin):
        If we failed to instantiate the plug-in, invalidate the instance proxy.
        
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::invalidate):
        Remove the instance from the plug-in host's set.
        
        (WebKit::NetscapePluginInstanceProxy::destroy):
        Call invalidate().

2009-02-09  Mark Rowe  <mrowe@apple.com>

        Reviewed by Dan Bernstein.

        Fix <https://bugs.webkit.org/show_bug.cgi?id=23863> / <rdar://problem/6571390>.
        Bug 23863: Reproducible crash in Mail with TOT WebKit when creating a new message

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _removeMouseMovedObserverUnconditionally]): Nil-check _private as it may have not
        yet been initialized if this WebHTMLView was loaded from a nib.
        (-[WebHTMLView _removeSuperviewObservers]): Ditto.

2009-02-09  Eric Seidel  <eric@webkit.org>

        Reviewed by Dave Hyatt.

        Rename Selection to VisibleSelection to allow us to separate
        the selections the user works with from the ones used by
        the JS editing APIs.
        https://bugs.webkit.org/show_bug.cgi?id=23852

        * WebView/WebFrame.mm:
        (-[WebFrame _selectNSRange:]):
        * WebView/WebView.mm:
        (-[WebView textIteratorForRect:]):

2009-02-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.
        
        Fix crash when plug-in host dies.
        
        * Plugins/Hosted/HostedNetscapePluginStream.mm:
        (WebKit::HostedNetscapePluginStream::didFail):

2009-02-05  Eric Seidel  <eric@webkit.org>

        Reviewed by Justin Garcia.

        DOMSelection.getRangeAt() returns a different range than the selection
        https://bugs.webkit.org/show_bug.cgi?id=23601

        Rename toRange to toNormalizedRange and add new firstRange which returns an unmodified range

        * WebView/WebFrame.mm:
        (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
        (-[WebFrame _markDOMRange]):
        (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]):
        (-[WebFrame _selectedNSRange]):
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _selectedRange]):
        (-[WebTextCompleteController doCompletion]):
        (-[WebHTMLView selectedAttributedString]):
        * WebView/WebView.mm:
        (-[WebView textIteratorForRect:]):
        (-[WebView selectedDOMRange]):

2009-02-06  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Part III of <rdar://problem/6552272>.
        
        Refactored to use the redirect data WebCore makes available, instead of
        tracking loading state in WebKit.
        
        * History/WebHistory.mm:
        (-[WebHistoryPrivate dealloc]):
        (-[WebHistory _visitedURL:withTitle:method:wasFailure:]):
        (-[WebHistory _visitedURLForRedirectWithoutHistoryItem:]):
        * History/WebHistoryInternal.h:
        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::updateGlobalHistory):
        (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):

2009-02-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        <rdar://problem/6562220> 
        CrashTracer: [USER] 21 crashes in Safari at com.apple.WebKit • WebKit::NetscapePluginHostProxy::port
        
        Make the handling of crashes in the plug-in host more robust.
        
        * Plugins/Hosted/NetscapePluginHostProxy.h:
        Add m_portSet.
        
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
        Initialize m_portSet.
        
        (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy):
        Free m_portSet.
        
        (WebKit::NetscapePluginHostProxy::processRequests):
        Listen for messages on the port set. If we get a message to the port death notification port,
        then call pluginHostDied. Otherwise, process the message.
        
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::cleanup):
        Factor code that should be shared between destroy() and pluginHostDied() into cleanup.
        
        (WebKit::NetscapePluginInstanceProxy::destroy):
        Call cleanup().
        
        (WebKit::NetscapePluginInstanceProxy::pluginHostDied):
        Call cleanup().
        
        (WebKit::NetscapePluginInstanceProxy::processRequestsAndWaitForReply):
        Call NetscapePluginHostProxy::processRequests.
        
        * Plugins/Hosted/ProxyInstance.mm:
        (WebKit::ProxyInstance::invalidate):
        Add a null check for the host proxy.

2009-02-06  Dan Bernstein  <mitz@apple.com>

        - try to fix the Tiger build

        * Misc/WebNSArrayExtras.h:

2009-02-06  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6563650> 
        Add Netscape plug-in API to tell the browser not to load streams (some plug-ins handle network loading manually)
                
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView loadStream]):
        (-[WebNetscapePluginView pluginView:receivedData:]):
        (-[WebNetscapePluginView _shouldCancelSrcStream]):

2009-02-05  Maciej Stachowiak  <mjs@apple.com> and Brady Eidson  <beidson@apple.com>

        Reviewed by Dan Bernstein and Geoff Garen.

        - WebKit code to track per-day and per-week visit counts in history

        For now this data is only exposed via SPI for performance reasons.
        
        * History/WebHistoryItem.mm:
        (-[WebHistoryItem initFromDictionaryRepresentation:]): Add parsing support
        for new data.
        (-[WebHistoryItem _recordInitialVisit]): Tell WebCore to record an initial visit.
        (-[WebHistoryItem dictionaryRepresentation]): Add saving support for new data.
        (-[WebHistoryItem _getDailyVisitCounts:]): SPI accessor.
        (-[WebHistoryItem _getWeeklyVisitCounts:]): SPI accessor.
        * History/WebHistoryItemInternal.h: Declare new methods.
        * History/WebHistoryItemPrivate.h: Ditto.

        * History/WebHistory.mm:
        (-[WebHistoryPrivate visitedURL:withTitle:]): For the initial visit, use
        the new _recordInitialVisit method instead of setting visit count to 1.

        * Misc/WebNSArrayExtras.h:
        * Misc/WebNSArrayExtras.m:
        (-[NSArray _webkit_numberAtIndex:]): Helper to retrieve an NSNumber or nil from an NSArray
        (-[NSArray _webkit_stringAtIndex:]): Helper to retrieve an NSString of nil from an NSArray
        
2009-02-05  Aaron Boodman  <aa@chromium.org>

        Reviewed by Dave Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=23708
        Adds documentElementAvailable() callback to FrameLoaderClient.

        * WebCoreSupport/WebFrameLoaderClient.h:
        Stub out documentElementAvailable().
        * WebCoreSupport/WebFrameLoaderClient.mm:
        Ditto.

2009-02-05  Dan Bernstein  <mitz@apple.com>

        - build fix

        * WebView/WebScriptDebugger.mm:
        (WebScriptDebugger::initGlobalCallFrame):

2009-02-05  Beth Dakin  <bdakin@apple.com>

        Reviewed by John Sullivan and Brady Eidson.

        Fix for <rdar://problem/6557595> REGRESSION: In Mail, selecting a 
        mail note message doesn't display it in Mail's preview pane

        This was failing because revision 36962 removed a version of 
        setVerticalScrollingMode that mail calls. This patch simply adds 
        that method back.

        * WebView/WebDynamicScrollBarsView.m:
        (-[WebDynamicScrollBarsView setVerticalScrollingMode:]):

2009-02-04  Anders Carlsson  <andersca@apple.com>

        Build fix fix.

        * WebView/WebScriptDebugger.mm:
        (WebScriptDebugger::initGlobalCallFrame):

2009-02-04  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.
        
        Change PCHasProperty, PCHasMethod and PCGetProperty into simpleroutines.
        
        Rename PHEvaluateReply to PHBooleanAndDataReply and add PHBooleanReply.
        
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCEvaluate):
        (WKPCInvoke):
        (WKPCGetProperty):
        (WKPCHasProperty):
        (WKPCHasMethod):
        * Plugins/Hosted/WebKitPluginClient.defs:
        * Plugins/Hosted/WebKitPluginHost.defs:

2009-02-04  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mark Rowe.

        Fix 64-bit build.
        
        * WebView/WebScriptDebugger.mm:
        (WebScriptDebugger::initGlobalCallFrame):

2009-02-04  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Mark Rowe.
        
        Part I of <rdar://problem/6552272>.

        Clear the redirectURLs entry when first visiting a site, so sites that
        only redirect you the first time you visit them can later learn that
        they don't redirect.

        * History/WebHistory.mm:
        (-[WebHistory _visitedURL:withTitle:method:wasFailure:serverRedirectURL:isClientRedirect:]):

2009-02-04  Timothy Hatcher  <timothy@apple.com>

        Change the WebSourceId typedef from int to intptr_t now that <rdar://problem/6263297> is fixed.

        <rdar://problem/6263293> WebScriptDebugDelegate should use intptr_t for sourceId, not int

        Reviewed by Oliver Hunt.

        * WebView/WebScriptDebugDelegate.h:

2009-02-04  Timothy Hatcher  <timothy@apple.com>

        Switched over from using the WebSafeForwarder for the Script Debug
        delegate and added high performance CallScriptDebugDelegate functions.

        <rdar://problem/6508457> Launching widget in Dashcode debugger is
        super-slow due forwardInvocation: calling debug delegate

        Reviewed by Oliver Hunt.

        * DefaultDelegates/WebDefaultScriptDebugDelegate.h: Removed.
        * DefaultDelegates/WebDefaultScriptDebugDelegate.m: Removed.
        * WebView/WebScriptDebugger.mm:
        (WebScriptDebugger::initGlobalCallFrame): Use CallScriptDebugDelegate.
        (WebScriptDebugger::sourceParsed): Ditto.
        (WebScriptDebugger::callEvent): Ditto.
        (WebScriptDebugger::atStatement): Ditto.
        (WebScriptDebugger::returnEvent): Ditto.
        (WebScriptDebugger::exception): Ditto.
        * WebView/WebView.mm:
        (-[WebViewPrivate dealloc]): Removed scriptDebugDelegateForwarder.
        (-[WebView _cacheScriptDebugDelegateImplementations]): Added. Gets the
        method implementations for the script debug delegate. Also caches what
        didParseSource method to use.
        (WebViewGetScriptDebugDelegateImplementations): Added. Returns the
        WebScriptDebugDelegateImplementations structure.
        (-[WebView setScriptDebugDelegate:]): Call _cacheScriptDebugDelegateImplementations.
        (CallDelegate): Added more overloaded versions that take different arguments.
        (CallScriptDebugDelegate): Added overloaded versions that take different arguments.
        * WebView/WebViewInternal.h:

2009-02-03  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=23365
        
        Hook up accelerated compositing layers the native
        view system on Mac.

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::attachRootGraphicsLayer):
        (WebChromeClient::setNeedsOneShotDrawingSynchronization):
        New methods to hook up the root GraphicsLayer to the native
        view system, and to synchronize layer changes with view-based
        drawing when layers come and go.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLViewPrivate clear]):
        Clear the pointer to layerHostingView.

        (-[WebHTMLView _setAsideSubviews]):
        (-[WebHTMLView willRemoveSubview:]):
        Keep the special layer-hosting view in the subviews even 
        when the rest of the subviews are ripped out for
        painting.

        (-[WebHTMLView _isUsingAcceleratedCompositing]):
        New utility method for DumpRenderTree to know if we're
        hosting layers.

        (-[WebHTMLView drawRect:]):
        Call -disableScreenUpdatesUntilFlush if we have to
        synchronize layer changes with painting.

        (-[WebHTMLView attachRootLayer:]):
        (-[WebHTMLView detachRootLayer]):
        Attach and detach the root GraphicsLayer.

        * WebView/WebViewInternal.h:
        * WebView/WebHTMLViewInternal.h:
        * WebView/WebHTMLViewPrivate.h:
        New method declarations.
        
        * WebView/WebView.mm:
        (-[WebView _needsOneShotDrawingSynchronization]):
        (-[WebView _setNeedsOneShotDrawingSynchronization:]):
        Set the flag to say if we need to synchronize layer
        changes and painting on the next -drawRect: call.

        (-[WebView viewWillMoveToWindow:]):
        (-[WebView viewDidMoveToWindow]):
        Call new notifications that the view was added to or removed from
        the window, which are required by the layer hosting mechanism.

2009-02-02  Geoffrey Garen  <ggaren@apple.com>

        Build fix.

        * Plugins/WebPluginController.mm:
        (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):

2009-02-02  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Track redirects in global history.

        * History/WebHistory.mm:
        (-[WebHistoryPrivate dealloc]):
        (-[WebHistoryPrivate lastVisitedEntry]):
        (-[WebHistoryPrivate setLastVisitedEntry:]): Remember the last global history
        entry in case we're asked to add redirect information to it later.

        (-[WebHistory _visitedURL:withTitle:method:wasFailure:serverRedirectURL:isClientRedirect:]):
        (-[WebHistory _visitedURLForRedirectWithoutHistoryItem:]): Record redirect
        information in global history.

        * History/WebHistoryInternal.h:
        * WebCoreSupport/WebFrameLoaderClient.h: See above and below.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::updateGlobalHistory):
        (WebFrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem): Record redirect
        information in global history.

        * WebView/WebFrame.mm:
        (-[WebFrame loadRequest:]):
        (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
        * WebView/WebFramePrivate.h: Updated for rename and extra parameter.

2009-02-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Work around a limitation in MIG where two functions can't have the same name even if they're
        not in the same subsystem.
        
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::processRequestsAndWaitForReply):
        * Plugins/Hosted/WebKitPluginClient.defs:
        * Plugins/Hosted/WebKitPluginHost.defs:

2009-02-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Implement WKPCGetPluginElementObject.
        
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCGetPluginElementNPObject):
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject):
        * Plugins/Hosted/WebKitPluginClient.defs:
        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView WebCore::]):

2009-02-02  Anders Carlsson  <andersca@apple.com>

        Build fix.
        
        * WebView/WebHTMLView.mm:

2009-02-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Make WebBaseNetscapePluginView hold a reference to a HTMLPlugInElement instead of a DOMElement.
        
        * Plugins/Hosted/WebHostedNetscapePluginView.h:
        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
        (-[WebBaseNetscapePluginView _windowClipRect]):        
        (-[WebBaseNetscapePluginView visibleRect]):
        (-[WebBaseNetscapePluginView dataSource]):
        * Plugins/WebKitPluginContainerView.h: Removed.
        * Plugins/WebKitPluginContainerView.mm: Removed.
        * Plugins/WebNetscapePluginView.h:
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
        (-[WebNetscapePluginView getVariable:value:]):
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::createPlugin):

2009-02-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Update for changes to WebCore.
        
        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::createPlugin):

2009-02-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Oliver Hunt.

        When a new Web View was not created, report back to the plug-in host.
        
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::performRequest):
        * Plugins/Hosted/WebKitPluginHost.defs:

2009-02-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        Draw the regular missing plug-in icon instead of a red rect when a plug-in has crashed.
        
        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView drawRect:]):

2009-02-02  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Darin Adler.

        Move Frame::forceLayout, Frame::adjustPageHeight and Frame::forceLayoutWithPageWidthRange to FrameView

        https://bugs.webkit.org/show_bug.cgi?id=23428

        FrameView::forceLayout could be killed but the comment might
        contain a value over the the plain FrameView::layout...

        Adjust the WebCore/WebKit consumers of these methods.

        * WebView/WebFrame.mm:
        (-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]):
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
        (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):

2009-01-31  John Sullivan  <sullivan@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=23665

        Cleaned up code to add/remove NSNotification observers, to avoid performance hit
        of calling removeObserver with unspecified notifications, or calling removeObserver
        multiple times for the same notification.

        Reviewed by Darin Adler

        * WebView/WebHTMLView.mm:
        added observingMouseMovedNotifications, observingSuperviewNotifications, and 
        observingWindowNotifications as BOOL ivars of _private object
        (-[WebHTMLView _removeMouseMovedObserverUnconditionally]):
        moved to file-internal section of file, added leading underscore, now bails out
        if we aren't observing the relevant notifications, now records that we are no longer
        observing the relevant notifications
        (-[WebHTMLView _removeSuperviewObservers]):
        ditto, also stores [NSNoticationCenter defaultCenter] in local var to avoid objc dispatch
        (-[WebHTMLView _removeWindowObservers]):
        ditto
        (-[WebHTMLView close]):
        replace general removeObserver: call with three specific calls for all the notifications
        that this class actually observes
        (-[WebHTMLView addMouseMovedObserver]):
        bail out if already observing relevant notifications, now records that we are observing
        the relevant notifications
        (-[WebHTMLView removeMouseMovedObserver]):
        updated for name change
        (-[WebHTMLView addSuperviewObservers]):
        bail out if already observing relevant notifications, now records that we are observing
        the relevant notifications; also stores [NSNoticationCenter defaultCenter] in local var 
        to avoid objc dispatch
        (-[WebHTMLView addWindowObservers]):
        ditto
        (-[WebHTMLView viewWillMoveToSuperview:]):
        updated for name change
        (-[WebHTMLView viewWillMoveToWindow:]):
        updated for name changes

2009-01-31  Darin Adler  <darin@apple.com>

        Reviewed by Mark Rowe.

        Fix code that assumes all command selectors end in colons.
        rdar://problem/6545874

        * WebView/WebHTMLView.mm:
        (commandNameForSelector): Don't assert, just return a null string, when
        the selector doesn't end in a colon.

2009-01-30  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        Add a pref to disable web security.

        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):
        (-[WebPreferences isWebSecurityEnabled]):
        (-[WebPreferences setWebSecurityEnabled:]):
        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]):

2009-01-30  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Darin Adler.

        Move Frame::sendResizeEvent and Frame::sendScrollEvent to EventHandler

        Carry out the move and catch up in two call sites.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _frameOrBoundsChanged]):

2009-01-30  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Darin Adler.

        isFrameSet was moved from Frame to Document. Update the
        WebKit usage.

        * WebView/WebFrame.mm:
        (-[WebFrame _isFrameSet]):
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView knowsPageRange:]):

2009-01-30  Geoffrey Garen  <ggaren@apple.com>

        Build fix.

        * WebView/WebFramePrivate.h:

2009-01-30  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Split "lockHistory" into "lockHistory" and "lockBackForwardList" in
        preparation for setting them differently during a redirect.

        * WebView/WebPDFView.mm:
        (-[WebPDFView PDFViewWillClickOnLink:withURL:]):

2009-01-30  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Fix <rdar://problem/6544048>
        
        Have NetscapePluginInstanceProxy keep track of all the ProxyInstance objects associated.
        
        When the plug-in instance is destroyed, invalidate all proxy instances.
        
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::destroy):
        (WebKit::NetscapePluginInstanceProxy::addInstance):
        (WebKit::NetscapePluginInstanceProxy::removeInstance):
        * Plugins/Hosted/ProxyInstance.h:
        * Plugins/Hosted/ProxyInstance.mm:
        (WebKit::ProxyInstance::ProxyInstance):
        (WebKit::ProxyInstance::~ProxyInstance):
        (WebKit::ProxyInstance::invalidate):

2009-01-30  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Fix <rdar://problem/6490778>.
        
        Change the NPRuntime related functions to use IdentifierRep directly, and make sure to always
        validate IdentifierReps before dereferencing them.
        
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCEvaluate):
        (WKPCGetStringIdentifier):
        (WKPCGetIntIdentifier):
        (identifierFromIdentifierRep):
        (WKPCInvoke):
        (WKPCGetProperty):
        (WKPCSetProperty):
        (WKPCRemoveProperty):
        (WKPCHasProperty):
        (WKPCHasMethod):
        (WKPCIdentifierInfo):

2009-01-30  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig

        Remove FrameLoaderClient code that is now handled by FrameLoader itself

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::frameLoadCompleted):

2009-01-29  Stephanie Lewis <slewis@apple.com>

        RS by Oliver Hunt.

        Update the order files.

        * WebKit.order:

2009-01-29  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Second step in tracking the urls a HistoryItem was redirected through
        Add SPI to access the array of redirect urls associated with a HistoryItem.

        * History/WebHistoryItem.mm:
        (-[WebHistoryItem dictionaryRepresentation]):
        (-[WebHistoryItem _redirectURLs]):
        * History/WebHistoryItemPrivate.h:

2009-01-29  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Always activate the plug-in host process if we're in "modal mode" and are being told to activate.
        
        * Plugins/Hosted/NetscapePluginHostProxy.h:
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WebKit::NetscapePluginHostProxy::pluginHostDied):
        Call endModal here.
        
        (WebKit::NetscapePluginHostProxy::applicationDidBecomeActive):
        If we're modal, we should always bring the plug-in host process to the front.
        
        (WebKit::NetscapePluginHostProxy::beginModal):
        Add an observer for the NSApplicationWillBecomeActiveNotification callback.
        
        (WebKit::NetscapePluginHostProxy::endModal):
        Remove the observer.

2009-01-29  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        First step in tracking the urls a HistoryItem was redirected through.

        * History/WebHistoryItem.mm:
        (-[WebHistoryItem initFromDictionaryRepresentation:]):
        (-[WebHistoryItem dictionaryRepresentation]):
        * Misc/WebNSDictionaryExtras.h:
        * Misc/WebNSDictionaryExtras.m:
        (-[NSDictionary _webkit_arrayForKey:]): Add helper.

2009-01-29  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Pass the PSN of the client to the host, and get the PSN of the host back when checking in.
        
        * Plugins/Hosted/NetscapePluginHostManager.h:
        * Plugins/Hosted/NetscapePluginHostManager.mm:
        (WebKit::NetscapePluginHostManager::hostForPackage):
        Get the current PSN and pass it to spawnPluginHost.
        
        (WebKit::NetscapePluginHostManager::spawnPluginHost):
        Pass the PSN to the "check in" function.
        
        * Plugins/Hosted/NetscapePluginHostProxy.h:
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
        
        (WebKit::NetscapePluginHostProxy::pluginHostDied):
        Fix a bug noticed by Julien Chaffraix. Call endModal if necessary.
        
        (WebKit::NetscapePluginHostProxy::beginModal):
        (WebKit::NetscapePluginHostProxy::endModal):
        (WebKit::NetscapePluginHostProxy::setModal):
        Split out the code that does all of the work into beginModal and endModal methods.
        
        * Plugins/Hosted/WebKitPluginHost.defs:
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView loadStream]):

2009-01-29  David Kilzer  <ddkilzer@apple.com>

        Remove semi-colons from the end of ObjC method implementations

        Rubber-stamped by Adam Roben.

        $ find WebKit -name \*.m -o -name \*.mm -exec perl -e 'undef $/; $s = <>; while ($s =~ m/[\n\r][-+].*;[\s\r\n]+\{/g) { print "$ARGV: $&\n"; }' {} \;

        * DefaultDelegates/WebDefaultUIDelegate.m:
        (-[WebDefaultUIDelegate webView:setResizable:]):
        (-[WebDefaultUIDelegate webView:dragDestinationActionMaskForDraggingInfo:]):
        (-[WebDefaultUIDelegate webView:dragSourceActionMaskForPoint:]):
        (-[WebDefaultUIDelegate webView:willPerformDragSourceAction:fromPoint:withPasteboard:]):
        * History/WebBackForwardList.mm:
        (-[WebBackForwardList addItem:]):
        (-[WebBackForwardList backListWithLimit:]):
        (-[WebBackForwardList forwardListWithLimit:]):
        * History/WebHistoryItem.mm:
        (-[WebHistoryItem alternateTitle]):
        (-[WebHistoryItem setViewState:]):
        * Misc/WebCoreStatistics.mm:
        (+[WebCoreStatistics garbageCollectJavaScriptObjectsOnAlternateThreadForDebugging:]):
        * Misc/WebKitNSStringExtras.m:
        (-[NSString _web_drawAtPoint:font:textColor:]):
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView setAttributeKeys:andValues:]):
        * WebCoreSupport/WebEditorClient.mm:
        (-[WebEditCommand command]):
        * WebView/WebFrame.mm:
        (-[WebFrame _getVisibleRect:]):
        * WebView/WebHTMLRepresentation.mm:
        (-[WebHTMLRepresentation _redirectDataToManualLoader:forPluginView:]):
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView elementAtPoint:allowShadowContent:]):
        * WebView/WebPreferences.mm:
        (-[WebPreferences setAllowsAnimatedImages:]):
        (-[WebPreferences setAutosaves:]):
        (-[WebPreferences PDFDisplayMode]):
        * WebView/WebView.mm:
        (+[WebView _viewClass:andRepresentationClass:forMIMEType:]):
        (-[WebView _viewClass:andRepresentationClass:forMIMEType:]):
        (+[WebView _unregisterViewClassAndRepresentationClassForMIMEType:]):
        (+[WebView _registerViewClass:representationClass:forURLScheme:]):
        (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
        (-[WebView _insertNewlineInQuotedContent]):

2009-01-28  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Updated for WebCore rename.
        
        * WebView/WebView.mm:
        (-[WebView setCustomTextEncodingName:]):

2009-01-28  David Kilzer  <ddkilzer@apple.com>

        Add missing declaration for -[NSURL(WebNSURLExtras) _webkit_isFileURL]

        Reviewed by Dan Bernstein.

        * Misc/WebNSURLExtras.h:
        (-[NSURL(WebNSURLExtras) _webkit_isFileURL]): Added missing
        declaration after the implementation was added in r9258.

2009-01-28  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoff Garen.

        Fix for <rdar://problem/6129678>
        REGRESSION (Safari 3-4): Local variable not accessible from Dashcode console or variables view

        * WebView/WebScriptDebugDelegate.mm:
        (-[WebScriptCallFrame scopeChain]): Wrap JSActivations in DebuggerActivations.

2009-01-27  Anders Carlsson  <andersca@apple.com>

        Reviewed by Oliver Hunt.

        Fix two bugs with Core Animation based plug-ins.
        
        1. The plug-in view was marked as opaque even though it's not. 
           (This would leave garbage in the plug-in view).
        2. The plug-in layer needs to have autoresizing turned on.
        
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView setLayer:]):

2009-01-27  Brady Eidson  <beidson@apple.com>

        Reviewed by Dan Bernstein

        Rework FrameLoaderClient to work on a CachedFrame basis instead of CachedPage

        * History/WebHistoryItem.mm:

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::savePlatformDataToCachedFrame):
        (WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
        * WebKit.order:

2009-01-26  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Add the ability for plug-ins to make WebKit operate in "modal mode"
        
        * Plugins/Hosted/NetscapePluginHostProxy.h:
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
        (WebKit::NetscapePluginHostProxy::pluginHostDied):
        If the plug-in crashes while we're modal, make sure to leave the modal mode.
        
        (WebKit::NetscapePluginHostProxy::setModal):
        (WKPCSetModal):
        * Plugins/Hosted/WebKitPluginClient.defs:

2009-01-26  John Sullivan  <sullivan@apple.com>

        fixed <rdar://problem/6530053> REGRESSION (Leopard): Shift-tab in http authentication window gets 
        stuck in the Name field rather than cycling around

        Reviewed by Dan Bernstein

        * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
        * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
        The two static text fields and the last button all had their "next key view" outlets set to the
        name field, which caused shift-tab from the name field to do the wrong thing. Fixed by making each
        selectable view have exactly one "next key view" set to it.

2009-01-26  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add the ability for a plug-in to show or hide the menu bar.
        
        * Plugins/Hosted/NetscapePluginHostProxy.h:
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
        (WebKit::NetscapePluginHostProxy::pluginHostDied):
        (WebKit::NetscapePluginHostProxy::setMenuBarVisible):
        (WKPCSetMenuBarVisible):
        * Plugins/Hosted/WebKitPluginClient.defs:

2009-01-26  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Gavin Barraclough.

        Bug 23552: Dashcode evaluator no longer works after making ExecStates actual call frames
        <https://bugs.webkit.org/show_bug.cgi?id=23552>
        <rdar://problem/6398839>

        Dashcode will crash when using the evaluator because it saves a global call
        frame, even after global code has finished executing, and then uses this as
        a launching pad to execute new JS in the evaluator. The fix is to detect
        when Dashcode is attempting to do this and execute code from a global call
        frame instead.        

        * ForwardingHeaders/runtime/Protect.h: Added.
        * WebView/WebScriptDebugDelegate.mm:
        (-[WebScriptCallFrame _initWithGlobalObject:debugger:caller:debuggerCallFrame:]):
        Added debugger, a WebScriptDebugger* argument.
        (-[WebScriptCallFrame evaluateWebScript:]): Detect when Dashcode is using
        a stale WebScriptCallFrame to execute new JS and evaluate it starting from
        the global object's global call frame instead.
        * WebView/WebScriptDebugger.h:
        (WebScriptDebugger::globalObject): Added.
        (WebScriptDebugger::globalCallFrame): Added.
        * WebView/WebScriptDebugger.mm:
        (WebScriptDebugger::WebScriptDebugger): Initialize m_globalObject.
        (WebScriptDebugger::initGlobalCallFrame): Created as a clone of callEvent
        so that the global call frame can be saved immediately after being created.
        (WebScriptDebugger::callEvent): Pass 'this' as the debugger argument of
        WebScriptCallFrame's _initWithGlobalObject method.

2009-01-26  Anders Carlsson  <andersca@apple.com>

        Reviewed by Oliver Hunt.

        Make WKPCInvoke a simpleroutine.
        
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCInvoke):
        * Plugins/Hosted/WebKitPluginClient.defs:

2009-01-26  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Implement using plug-in objects as constructors, and setting and getting properties from a plug-in object.
        
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCBooleanAndDataReply):
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        (WebKit::NetscapePluginInstanceProxy::Reply::):
        (WebKit::NetscapePluginInstanceProxy::BooleanAndDataReply::BooleanAndDataReply):
        Rename NPObjectInvokeReply to BooleanAndDataReply.
        
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::addValueToArray):
        Fix a cut and paste error.
        
        (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
        Handle NPObjects.
        
        * Plugins/Hosted/ProxyInstance.h:
        * Plugins/Hosted/ProxyInstance.mm:
        (WebKit::ProxyField::valueFromInstance):
        (WebKit::ProxyField::setValueToInstance):
        Call the ProxyInstance method.
        
        (WebKit::ProxyInstance::~ProxyInstance):
        Release the NPObject.
        
        (WebKit::ProxyInstance::supportsConstruct):
        Ask the plug-in host if an instance supports construct.
        
        (WebKit::ProxyInstance::fieldValue):
        (WebKit::ProxyInstance::setFieldValue):
        Call the plug-in host methods.
        
        * Plugins/Hosted/WebKitPluginHostTypes.h:
        Rename ObjectValueType to JSObjectValueType, and add NPObjectValueType.

2009-01-26  Mark Rowe  <mrowe@apple.com>

        Fix the build.

        Remove -Wformat=2 from the warning flags as newer versions of GCC emit
        warnings about non-literal format strings for uses of our UI_STRING macro.

        * Configurations/Base.xcconfig:

2009-01-26  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Sam Weinig.

        Clean up after r40240.

        * Configurations/Base.xcconfig: Don't dead code strip in debug builds for now as it leads to link errors.
        * Plugins/Hosted/HostedNetscapePluginStream.mm: Revert change that is no longer needed now that WebKitPluginHost.defs
        is back in the build.

2009-01-25  Darin Adler  <darin@apple.com>

        * Plugins/Hosted/HostedNetscapePluginStream.mm: Added a missing extern "C".

2009-01-25  Darin Adler  <darin@apple.com>

        Discussed with Mark Rowe; not sure he reviewed it.

        * Configurations/Base.xcconfig: Add all the same warnings as in WebCore except for
        -Wcast-qual and -Wunused-parameter, which both need to be off at least for now.

2009-01-25  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Dan Bernstein.

        Improve the consistency of settings in our .xcconfig files.

        * Configurations/Base.xcconfig: Only dead code strip the normal variant.
        Handle all cases in GCC_GENERATE_DEBUGGING_SYMBOLS.

2009-01-25  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Bug 23522: use checked casts for render tree
        https://bugs.webkit.org/show_bug.cgi?id=23522

        Step one: RenderText.

        * WebView/WebRenderNode.mm:
        (copyRenderNode): Use toRenderText.

2009-01-23  Brady Eidson  <beidson@apple.com>

        Rubberstamped by Darin Adler

        Rename CachedPagePlatformData to CachedFramePlatformData to more accurately reflect its true role.

        * WebCoreSupport/WebCachedFramePlatformData.h: Copied from WebKit/mac/WebCoreSupport/WebCachedPagePlatformData.h.
        (WebCachedFramePlatformData::WebCachedFramePlatformData):
        * WebCoreSupport/WebCachedPagePlatformData.h: Removed.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::savePlatformDataToCachedPage):
        (WebFrameLoaderClient::transitionToCommittedFromCachedPage):

        * WebKit.order:

2009-01-23  Adele Peterson  <adele@apple.com>

        Build fix.

        Use new linesBoundingBox method instead of
        boundingBoxWidth and boundingBoxHeight for RenderText objects.

        * WebView/WebRenderNode.mm: (copyRenderNode):

2009-01-23  Anders Carlsson  <andersca@apple.com>

        Fix 64-bit build.
        
        * Plugins/Hosted/ProxyInstance.mm:
        (WebKit::proxyClass):

2009-01-23  Anders Carlsson  <andersca@apple.com>

        Fix GCC 4.0 build.
        
        * Configurations/Base.xcconfig:

2009-01-23  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Turn on -Wmissing-prototypes and fix the resulting warnings.

        * Configurations/Base.xcconfig:
        * History/WebHistory.mm:
        (timeIntervalForBeginningOfDay):
        * History/WebHistoryItem.mm:
        (historyItemWrappers):
        * Misc/WebNSPasteboardExtras.mm:
        (imageFromElement):
        * WebView/WebFrame.mm:
        * WebView/WebScriptDebugger.mm:
        (toNSString):

2009-01-22  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Anders Carlsson.

        Disable GCC_WARN_ABOUT_MISSING_PROTOTYPES temporarily.

        Current versions of Xcode only respect it for C and Objective-C files,
        and our code doesn't currently compile if it is applied to C++ and
        Objective-C++ files.

        * Configurations/Base.xcconfig:

2009-01-22  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add support for Invoke and InvokeDefault. Clean up code.
        
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCBooleanReply):
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        (WebKit::NetscapePluginInstanceProxy::Reply::):
        (WebKit::NetscapePluginInstanceProxy::BooleanReply::BooleanReply):
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
        * Plugins/Hosted/ProxyInstance.h:
        * Plugins/Hosted/ProxyInstance.mm:
        (WebKit::ProxyInstance::invoke):
        (WebKit::ProxyInstance::invokeMethod):
        (WebKit::ProxyInstance::supportsInvokeDefaultMethod):
        (WebKit::ProxyInstance::invokeDefaultMethod):
        (WebKit::ProxyInstance::methodsNamed):
        (WebKit::ProxyInstance::fieldNamed):
        * Plugins/Hosted/WebKitPluginClient.defs:
        * Plugins/Hosted/WebKitPluginHost.defs:
        * Plugins/Hosted/WebKitPluginHostTypes.h:

2009-01-22  Eric Roman  <eroman@chromium.og>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=20806
        Deprecate RSSFeedReferrer() and setRSSFeedReferrer().

        * History/WebHistoryItem.mm:
        (-[WebHistoryItem RSSFeedReferrer]):
        (-[WebHistoryItem setRSSFeedReferrer:]):

2009-01-22  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        Don't crash or hang when we fail to instantiate a plug-in.
        
        * Plugins/Hosted/NetscapePluginHostManager.mm:
        (WebKit::NetscapePluginHostManager::instantiatePlugin):
        Return 0 on failure.
        
        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView JSC::Bindings::createPluginBindingsInstance:JSC::Bindings::]):
        Null check for the proxy member.

2009-01-21  David Hyatt  <hyatt@apple.com>

        Devirtualize width/height/x/y on RenderObject and move the methods to RenderBox.

        Reviewed by Eric Seidel and Darin Adler

        * WebView/WebRenderNode.mm:
        (copyRenderNode):

2009-01-21  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        More browser->plug-in scripting support.
        
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCNPObjectHasPropertyReply):
        (WKPCNPObjectHasMethodReply):
        (WKPCNPObjectInvokeReply):
        MIG reply functions.
        
        (WKPCIdentifierInfo):
        Return information about an identifier given its 64-bit value.
        
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        Add new reply structs.
        
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::addValueToArray):
        Split out code that adds values to the arrays from marshalValue.
        
        (WebKit::NetscapePluginInstanceProxy::marshalValue):
        Call addValueToArray.
    
        (WebKit::NetscapePluginInstanceProxy::marshalValues):
        Marshal a list of values.
        
        (WebKit::NetscapePluginInstanceProxy::createBindingsInstance):
        Actually create a proxy instance.
        
        * Plugins/Hosted/ProxyInstance.h:
        * Plugins/Hosted/ProxyInstance.mm:
        (WebKit::ProxyClass::methodsNamed):
        (WebKit::ProxyClass::fieldNamed):
        Add a proxy ProxyClass class that just forwards everything to the ProxyInstance class.
        
        (WebKit::proxyClass):
        Shared proxyClass getter.
        
        (WebKit::ProxyField::ProxyField):
        (WebKit::ProxyField::valueFromInstance):
        (WebKit::ProxyField::setValueToInstance):
        Add a proxy ProxyField class that just forwards everything to the ProxyInstance class.
        
        (WebKit::ProxyMethod::ProxyMethod):
        (WebKit::ProxyMethod::serverIdentifier):
        (WebKit::ProxyMethod::numParameters):
        Add a dummy ProxyMethod class.
        
        (WebKit::ProxyInstance::invokeMethod):
        Call _WKPHNPObjectInvoke.
        
        (WebKit::ProxyInstance::defaultValue):
        (WebKit::ProxyInstance::stringValue):
        (WebKit::ProxyInstance::numberValue):
        (WebKit::ProxyInstance::booleanValue):
        (WebKit::ProxyInstance::valueOf):
        Add dummy implementations (taken from CInstance).
        
        (WebKit::ProxyInstance::methodsNamed):
        Call _WKPHNPObjectHasMethod to determine whether a method with the given name exists.
        
        (WebKit::ProxyInstance::fieldNamed):
        Call _WKPHNPObjectHasProperty to determine whether a property with the given name exists.
        
        * Plugins/Hosted/WebKitPluginClient.defs:
        * Plugins/Hosted/WebKitPluginHost.defs:
        Add new MIG definitions.

2009-01-21  Mark Rowe  <mrowe@apple.com>

        Reviewed by Tim Hatcher.

        Clean up how we force invocations of API that happened on background threads over to the main thread.

        This was previously accomplished in a somewhat ad-hoc manner using a mutable dictionary to pass arguments
        and return values back from the function.  The new approach is to use a proxy object that forwards an
        NSInvocation over to the main thread and applies it to the target object, which leads to a much cleaner
        call site.

        * Misc/WebNSObjectExtras.h:
        * Misc/WebNSObjectExtras.mm:
        (-[WebMainThreadInvoker initWithTarget:]):
        (-[WebMainThreadInvoker forwardInvocation:]):
        (-[WebMainThreadInvoker methodSignatureForSelector:]):
        (-[WebMainThreadInvoker handleException:]):
        (-[NSInvocation _webkit_invokeAndHandleException:]): Execute the invocation and forward any exception that was
        raised back to the WebMainThreadInvoker.
        (-[NSObject _webkit_invokeOnMainThread]):

        The following methods are updated to use the proxy object to forward methods to the main thread:

        * WebView/WebArchive.mm:
        (-[WebArchive initWithMainResource:subresources:subframeArchives:]):
        (-[WebArchive mainResource]):
        (-[WebArchive subresources]):
        (-[WebArchive subframeArchives]):
        * WebView/WebResource.mm:
        (-[WebResource data]):
        (-[WebResource URL]):
        (-[WebResource MIMEType]):
        (-[WebResource textEncodingName]):
        (-[WebResource frameName]):
        (-[WebResource _ignoreWhenUnarchiving]):
        (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
        (-[WebResource _initWithData:URL:response:]):
        (-[WebResource _suggestedFilename]):
        (-[WebResource _response]):
        (-[WebResource _stringValue]):
        * WebView/WebView.mm:
        (-[WebView initWithFrame:frameName:groupName:]):
        (-[WebView initWithCoder:]):

2009-01-20  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>

        Reviewed by George Staikos.

        Fixes: https://bugs.webkit.org/show_bug.cgi?id=23434 (Add WML <input> element support)

        Protect text field related WebEditorClient.mm methods against non-HTMLElement callers.
        WebEditorClient.mm relies on HTMLInputElement as input element. Ignore calls from non-HTMLElement elements.

        * WebCoreSupport/WebEditorClient.mm:
        (WebEditorClient::textFieldDidBeginEditing):
        (WebEditorClient::textFieldDidEndEditing):
        (WebEditorClient::textDidChangeInTextField):
        (WebEditorClient::doTextFieldCommandFromEvent):
        (WebEditorClient::textWillBeDeletedInTextField):
        (WebEditorClient::textDidChangeInTextArea):

2009-01-19  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add and implement GetScriptableNPObject.
        
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCGetScriptableNPObjectReply):
        Create a new reply struct and set it as the current reply.
        
        (WKPCEvaluate):
        Get rid of an unused variable.
        
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        (WebKit::NetscapePluginInstanceProxy::Reply::):
        (WebKit::NetscapePluginInstanceProxy::GetScriptableNPObjectReply::GetScriptableNPObjectReply):
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::createBindingsInstance):
        Call _WKPHGetScriptableNPObject and wait for a reply.
        
        * Plugins/Hosted/ProxyInstance.h: Added.
        * Plugins/Hosted/ProxyInstance.mm: Added.
        Add empty files.
        
        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView JSC::Bindings::createPluginBindingsInstance:JSC::Bindings::]):
        Call NetscapePluginInstanceProxy::createBindingsInstance.
        
        * Plugins/Hosted/WebKitPluginClient.defs:
        * Plugins/Hosted/WebKitPluginHost.defs:
        Add new declarations.

2009-01-19  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Gavin Barraclough.

        Remove temporary operator-> from JSValuePtr.

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::invoke):
        (WebKit::NetscapePluginInstanceProxy::hasMethod):
        (WebKit::NetscapePluginInstanceProxy::marshalValue):
        * WebView/WebFrame.mm:
        (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
        * WebView/WebView.mm:
        (aeDescFromJSValue):

2009-01-19  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Make Evaluate an asynchronous method that has a reply method.
        
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCEvaluate):
        * Plugins/Hosted/WebKitPluginClient.defs:
        * Plugins/Hosted/WebKitPluginHost.defs:

2009-01-19  Brady Eidson  <beidson@apple.com>

        Rubberstamped by Tim Hatcher

        Fix long standing typo.

        * History/WebBackForwardList.h:

2009-01-19  Mark Rowe  <mrowe@apple.com>

        Fix the build!

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::demarshalValue):
        (WebKit::NetscapePluginInstanceProxy::demarshalValues):

2009-01-18  Mark Rowe  <mrowe@apple.com>

        Reviewed by Anders Carlsson.

        Fix <https://bugs.webkit.org/show_bug.cgi?id=23414>.
        Bug 23414: Reproducible crash accessing View menu with plugins disabled

        * WebView/WebFrame.mm:
        (-[WebFrame _canProvideDocumentSource]): Null-check the PluginData before using it.

2009-01-17  David Hyatt  <hyatt@apple.com>

        Eliminate dependencies on "backslashAsCurrencySymbol()" from WebKit, and make sure these alterations
        are done in WebCore instead.

        Reviewed by Oliver Hunt

        * WebView/WebFrame.mm:
        (-[WebFrame _selectedString]):
        (-[WebFrame _stringForRange:]):

2009-01-17  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Adele Peterson

        Complete <rdar://problem/6293969>

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface): Remove UseSharedMediaUI

2009-01-15  Brady Eidson  <beidson@apple.com>

        Reviewed by Dan Bernstein

        Fix problem where a URL visited as non-GET once is flagged as non-GET forever.

        * History/WebHistory.mm:
        (-[WebHistory _visitedURL:withTitle:method:wasFailure:]): Always update the HTTPNonGet
          flag for all loads with an HTTP Method

2009-01-14  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Implement InvokeDefault, Construct, GetProperty and SetProperty.
        
        Fully implement marshalValue.
        
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCInvokeDefault):
        (WKPCConstruct):
        (WKPCGetProperty):
        (WKPCSetProperty):
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::evaluate):
        (WebKit::NetscapePluginInstanceProxy::invoke):
        (WebKit::NetscapePluginInstanceProxy::invokeDefault):
        (WebKit::NetscapePluginInstanceProxy::construct):
        (WebKit::NetscapePluginInstanceProxy::getProperty):
        (WebKit::NetscapePluginInstanceProxy::setProperty):
        (WebKit::NetscapePluginInstanceProxy::marshalValue):
        (WebKit::NetscapePluginInstanceProxy::demarshalValue):
        * Plugins/Hosted/WebKitPluginClient.defs:

2009-01-14  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Demarshal arguments and pass them to the JS call.
        
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCInvoke):
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::invoke):
        (WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
        (WebKit::NetscapePluginInstanceProxy::demarshalValues):

2009-01-14  Mark Rowe  <mrowe@apple.com>

        Reviewed by Timothy Hatcher.

        <rdar://problem/6496520> REGRESSION: In Mail, a crash occurs when attempting to display a mail message

        Move WebArchive and WebResource to use the same approach for initializing themselves on the main thread
        that WebView uses.

        * WebView/WebArchive.mm:
        (-[WebArchive initWithMainResource:subresources:subframeArchives:]): Use _webkit_performSelectorOnMainThread:withObject:.
        (-[WebArchive _initWithArguments:]):
        * WebView/WebResource.mm:
        (-[WebResource _initWithArguments:]): Unbox the BOOL argument.

2009-01-14  Darin Adler  <darin@apple.com>

        Reviewed by Oliver Hunt.

        Fix crash I ran into while printing. I was unable to reproduce it, but also,
        it's clear there's no guarantee that the frame will be non-zero in this case,
        so it seems fine to check it.

        * WebView/WebHTMLView.mm: (-[WebHTMLView reapplyStyles]): Check frame for zero
        and don't do anything with it if it's zero.

2009-01-14  Dan Bernstein  <mitz@apple.com>

        Reviewed by John Sullivan.

        - update copyright

        * Info.plist:

2009-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Add a bunch of methods to WebKitPluginClient.defs, and implement them.
        
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WebKit::fromUTF8WithLatin1Fallback):
        If the length isn't specified, get it by calling strlen.
        
        (WKPCEvaluate):
        Evaluate doesn't take any arguments.
        
        (WKPCGetIntIdentifier):
        Call _NPN_GetIntIdentifier.
        
        (identifierFromServerIdentifier):
        New helper function that returns a JSC Identifier from an NPIdentifier.
        
        (WKPCInvoke):
        Call identifierFromServerIdentifier.
        
        (WKPCRemoveProperty):
        (WKPCHasProperty):
        (WKPCHasMethod):
        Call NetscapePluginInstanceProxy.

        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::removeProperty):
        (WebKit::NetscapePluginInstanceProxy::hasProperty):
        (WebKit::NetscapePluginInstanceProxy::hasMethod):

        * Plugins/Hosted/WebKitPluginClient.defs:
        Add new definitions.

2009-01-13  Anders Carlsson  <andersca@apple.com>

        Fix build.

        * WebView/WebView.mm:
        (-[WebView _initWithArguments:]):

2009-01-13  Timothy Hatcher  <timothy@apple.com>

        Adds a workaround for the flip4mac installer plugin decoding a WebView from a NIB on a secondary thread.

        <rdar://problem/6489788> New WebKit thread checks break installation of flip4mac (thread violation)

        Reviewed by Darin Adler.

        * Misc/WebKitVersionChecks.h: Add WEBKIT_FIRST_VERSION_WITHOUT_WEBVIEW_INIT_THREAD_WORKAROUND.
        * Misc/WebNSObjectExtras.h: Add _webkit_performSelectorOnMainThread:withObject:.
        * Misc/WebNSObjectExtras.mm:
        (-[NSObject _webkit_performSelectorWithArguments:]): Renamed from _webkit_getPropertyWithArguments.
        Passes the optional object to the selector.
        (-[NSObject _webkit_performSelectorOnMainThread:withObject:]): Renamed from _webkit_getPropertyOnMainThread:.
        Put the optional object into the arguments dictionary.
        (-[NSObject _webkit_getPropertyOnMainThread:]): Call _webkit_performSelectorOnMainThread with a nil object.
        * WebView/WebResource.mm:
        (-[WebResource _ignoreWhenUnarchiving]): Use _cmd instead of making the selector again.
        (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]): Use the new
        _webkit_performSelectorOnMainThread:withObject: method instead of performSelectorOnMainThread.
        * WebView/WebView.mm:
        (-[WebView _initWithArguments:]): Added. Pulls arguments out of the dictionary and calls the right init method.
        (needsWebViewInitThreadWorkaround): Checks if the thead is not the main thread and if we are in the Installer bundle.
        (-[WebView initWithFrame:frameName:groupName:]): Call needsWebViewInitThreadWorkaround and use _webkit_performSelectorOnMainThread
        to call _initWithArguments: passing the frame, frameName and groupName.
        (-[WebView initWithCoder:]): Ditto, except pass the coder to _initWithArguments:.

2009-01-12  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Oliver Hunt.

        Deprecate JSValuePtr::getNumber() - two ways to get a number should  be enough.

        * WebView/WebView.mm:
        (aeDescFromJSValue):

2009-01-12  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin Adler

        <rdar://problem/6468274> - Track Non-get requests in global history

        * History/WebHistory.mm:
        (-[WebHistory _visitedURL:withTitle:method:wasFailure:]):
        * History/WebHistoryInternal.h:

        * History/WebHistoryItem.mm:
        (-[WebHistoryItem initFromDictionaryRepresentation:]):
        (-[WebHistoryItem dictionaryRepresentation]):
        (-[WebHistoryItem _lastVisitWasHTTPNonGet]):
        * History/WebHistoryItemPrivate.h:

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::updateGlobalHistory): Only pass the method through if it was an HTTP load

2009-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Move marshalling into NetscapePluginInstanceProxy.
        
        Add support for marshallin strings.
        
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCEvaluate):
        (WKPCInvoke):
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::evaluate):
        (WebKit::NetscapePluginInstanceProxy::invoke):
        (WebKit::NetscapePluginInstanceProxy::marshalValue):
        * Plugins/Hosted/WebKitPluginHostTypes.h:

2009-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Implement WKPCInvoke.
        
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCEvaluate):
        (WKPCInvoke):
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::idForObject):
        (WebKit::NetscapePluginInstanceProxy::invoke):
        * Plugins/Hosted/WebKitPluginClient.defs:

2009-01-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Move marshalling code to NetscapePluginInstanceProxy. Add support for marshalling JS objects.
        
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCEvaluate):
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::marshalValue):
        * Plugins/Hosted/WebKitPluginHostTypes.h:

2009-01-12  Julien Chaffraix  <jchaffraix@pleyo.com>

        Reviewed by Darin Adler.

        Bug 22861: Turn the FontCache into a singleton
        https://bugs.webkit.org/show_bug.cgi?id=22861

        * Misc/WebCoreStatistics.mm:
        (+[WebCoreStatistics cachedFontDataCount]):
        (+[WebCoreStatistics cachedFontDataInactiveCount]):
        (+[WebCoreStatistics purgeInactiveFontData]):
        Redirected all the static calls to the global FontCache
        instance.

2009-01-11  Dmitry Titov  <dimich@chromium.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=23207
        Moved currentTime() to from WebCore to WTF.

        * WebView/WebFrame.mm: a different header file included.

2009-01-10  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        <rdar://problem/5845089> REGRESSION (r30044): Mail custom stationery missing images
        because of change to -[HTMLObjectElement data]

        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): Added a thread
        violation check because I saw this being done off the main thread while testing Mail, and it
        caused problems. Put all the one time initialization under a single guard to make things just
        a little faster other times, and to make it clearer which things are one-time. Added a call to
        the new patchMailRemoveAttributesMethod function.
        (-[WebView initWithFrame:frameName:groupName:]): Added a thread violation check here too,
        because I assumed it would be slightly better to have a public method name in the violation
        message. This calls commonInitialization later, so it will hit that one eventually.
        (objectElementDataAttribute): Added. Just returns the value of the "data" attribute.
        (recursivelyRemoveMailAttributes): Added. Patch to an internal Mail method that in turn patches
        a WebKit method and removes the patch again on the way out.
        (patchMailRemoveAttributesMethod): Added. On Leopard only, checks the Mail version, and then
        applies the patch that fixes this bug.

2009-01-09  Dan Bernstein  <mitz@apple.com>

        Reviewed by Darin Adler.

        - fixed <rdar://problem/6234347> Add/change conditional key
          bindings for changing paragraph- and character-level writing
          direction (to match NSTextView)

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Added
        code to validate makeBaseWritingDirectionLeftToRight: and
        makeBaseWritingDirectionRightToLeft:.
        (writingDirectionKeyBindingsEnabled): Changed this function to
        always return YES, except on Tiger and Leopard.
        (-[WebHTMLView makeBaseWritingDirectionLeftToRight:]): Renamed
        changeBaseWritingDirectionToLTR: to this.
        (-[WebHTMLView makeBaseWritingDirectionRightToLeft:]): Renamed
        changeBaseWritingDirectionToRTL: to this.
        (-[WebHTMLView changeBaseWritingDirectionToLTR:]): Now calls
        makeBaseWritingDirectionLeftToRight:.
        (-[WebHTMLView changeBaseWritingDirectionToRTL:]): Now calls
        makeBaseWritingDirectionRightToLeft:.
        * WebView/WebView.mm: Added makeBaseWritingDirectionLeftToRight
        and makeBaseWritingDirectionRightToLeft to
        FOR_EACH_RESPONDER_SELECTOR.

2009-01-08  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add and implement WKPCGetStringIdentifier.
        
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCGetStringIdentifier):
        * Plugins/Hosted/WebKitPluginClient.defs:

2009-01-08  Stephanie Lewis  <slewis@gmail.com>

        Fix Tiger build.        

        * WebView/WebTextIterator.mm:

2009-01-08  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add basic support for evaluating scripts.
        
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WebKit::fromUTF8WithLatin1Fallback):
        (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy):
        (WKPCReleaseObject):
        (marshalValue):
        (WKPCEvaluate):
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::releaseObject):
        (WebKit::NetscapePluginInstanceProxy::evaluate):
        * Plugins/Hosted/WebKitPluginClient.defs:
        * Plugins/Hosted/WebKitPluginHostTypes.h:

2009-01-08  David Hyatt  <hyatt@apple.com>

        Fix for <rdar://problem/6465682> REGRESSION: In Mail, can't force a message to auto scroll

        Add a new ChromeClient method for handling exposure of scrolled rects.

        Reviewed by Oliver Hunt

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::scrollRectIntoView):

2009-01-08  Darin Adler  <darin@apple.com>

        Reviewed by Tim Hatcher.

        Bug 23185: add a currentRange method to the WebTextIterator SPI
        https://bugs.webkit.org/show_bug.cgi?id=23185
        rdar://problem/6455834

        I also noticed a garbage-collection-related threading issue that I fixed, and
        that the SPI for getting text was unnecessarily inefficient, so I fixed that too.

        * WebView/WebTextIterator.h: Moved currentNode and currentText into a "deprecated"
        category. Added currentTextPointer and currentTextLength.

        * WebView/WebTextIterator.mm: Changed m_textIterator into an OwnPtr, and also
        used _textIterator to be consistent with ObjC rather than C++ naming.
        (+[WebTextIteratorPrivate initialize]): Added. Calls WebCoreObjCFinalizeOnMainThread,
        since the finalize method here works with main-thread only WebCore objects. 
        (-[WebTextIterator initWithRange:]): Changed since _textIterator is an OwnPtr now.
        (-[WebTextIterator advance]): Changed name of m_textIterator. Removed null assertion,
        since I don't think it provides much value.
        (-[WebTextIterator atEnd]): Ditto.
        (-[WebTextIterator currentRange]): Added.
        (-[WebTextIterator currentTextPointer]): Added.
        (-[WebTextIterator currentTextLength]): Added.
        (-[WebTextIterator currentNode]): Did same as above, but also put into new category.
        (-[WebTextIterator currentText]): Ditto.

2009-01-08  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Adele Peterson.

        Simplify Mac interfaces for drawing media controller elements

        <rdar://problem/6293969>

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface): Update for changes to media controller functions

2009-01-07  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Fix build.
        
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::idForObject):

2009-01-07  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Add a way for a plug-in to get a reference to the Window JS object.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCGetWindowNPObject):
        Call the appropriate instance.
        
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        Add object ID counter.
        
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::destroy):
        Clear the object ID map.
        
        (WebKit::NetscapePluginInstanceProxy::idForObject):
        New method that returns a unique ID for a given JS object.
        
        (WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
        Return the object ID for the window JS object.
        
        * Plugins/Hosted/WebKitPluginClient.defs:
        Add GetWindowNPObject.

2009-01-07  Darin Adler  <darin@apple.com>

        Reviewed by Oliver Hunt.

        Bug 23160: add setMemoryCacheClientCallsEnabled SPI so Safari can be faster with activity window closed
        https://bugs.webkit.org/show_bug.cgi?id=23160

        * WebView/WebView.mm:
        (-[WebView setMemoryCacheDelegateCallsEnabled:]): Added.
        (-[WebView areMemoryCacheDelegateCallsEnabled]): Added
        * WebView/WebViewPrivate.h: Ditto.

2009-01-05  Gavin Barraclough  <baraclough@apple.com>

        Rubber Stamped by Oliver Hunt.

        Replace all uses of JSValue* with new wrapper class, JSValuePtr.
        See JavaScriptCore/ChangeLog for more detailed description.

        * WebView/WebFrame.mm:
        (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
        * WebView/WebScriptDebugDelegate.mm:
        (-[WebScriptCallFrame _convertValueToObjcValue:]):
        (-[WebScriptCallFrame exception]):
        (-[WebScriptCallFrame evaluateWebScript:]):
        * WebView/WebView.mm:
        (aeDescFromJSValue):
        (-[WebView aeDescByEvaluatingJavaScriptFromString:]):

2009-01-06  Pierre-Olivier Latour  <pol@apple.com>

        Reviewed by Darin Adler.

        Exposed through WebFrame private interface the new WebCore API AnimationController::numberOfActiveAnimations() to be used by DRT.

        https://bugs.webkit.org/show_bug.cgi?id=23126

        * WebView/WebFrame.mm:
        (-[WebFrame _numberOfActiveAnimations]):
        * WebView/WebFramePrivate.h:

2009-01-05  David Kilzer  <ddkilzer@apple.com>

        Add SPI to enable, disable and check state of WebIconDatabase

        Reviewed by Darin Adler & Timothy Hatcher.

        Add -[WebIconDatabase isEnabled] and -[WebIconDatabase setEnabled:]
        SPI to make it possible to enable, disable and check the state of
        the icon database.

        * Misc/WebIconDatabase.mm:
        (-[WebIconDatabase init]): Extracted code into -_startUpIconDatabase.
        (-[WebIconDatabase iconForURL:withSize:cache:]): Switched to use
        -isEnabled instead of -_isEnabled.
        (-[WebIconDatabase iconURLForURL:]): Ditto.
        (-[WebIconDatabase retainIconForURL:]): Ditto.
        (-[WebIconDatabase releaseIconForURL:]): Ditto.
        (-[WebIconDatabase isEnabled]): Renamed from -_isEnabled in
        WebInternal category.
        (-[WebIconDatabase setEnabled:]): Added.  Takes care of changing
        the enabled/disabled state of the icon database.
        (-[WebIconDatabase removeAllIcons]): Switched to use -isEnabled
        instead of -_isEnabled.
        (-[WebIconDatabase _startUpIconDatabase]): Added.  Extrated from
        -init.
        (-[WebIconDatabase _shutDownIconDatabase]): Added.  Remove
        observers when the icon database is disabled.
        * Misc/WebIconDatabaseInternal.h: Added declarations for
        -_startUpIconDatabase and -_shutDownIconDatabase.
        * Misc/WebIconDatabasePrivate.h: Added declarations for
        -isEnabled and -setEnabled:.

2009-01-05  Brady Eidson  <beidson@apple.com>

        Reviewed by Jon Honeycutt

        Expose setting the last-visit-was-failure flag on a history items in preparation for <rdar://problem/6173319>

        * History/WebHistoryItem.mm:
        (-[WebHistoryItem _setLastVisitWasFailure:]):
        * History/WebHistoryItemPrivate.h:

2009-01-05  Adam Treat  <adam.treat@torchmobile.com>

        Another blind mac build fix

        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::contentsSizeChanged):

2009-01-05  Adam Treat  <adam.treat@torchmobile.com>

        Blind mac build fix

        * WebCoreSupport/WebChromeClient.mm:

2009-01-05  Adam Treat  <adam.treat@torchmobile.com>

        Fix mac build

        * WebCoreSupport/WebChromeClient.h:

2009-01-05  Adam Treat  <adam.treat@torchmobile.com>

        Reviewed by George Staikos.

        Build fix for contentsSizeChanged

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::contentsSizeChanged):

2009-01-02  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Bug 23072: REGRESSION (r37371): In the Dictionary application, scroll bar appears
        inside its web view when resizing its window
        https://bugs.webkit.org/show_bug.cgi?id=23072
        rdar://problem/6368028

        The first attempt at fixing this did not work.
        This time I was able to reproduce the bug and test the fix.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (applyAppleDictionaryApplicationQuirkNonInlinePart): Changed the arguments and
        function names around a bit to make even less code at the call site.
        (applyAppleDictionaryApplicationQuirk): Put the check for whether this is the
        Dictionary application in here.
        (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache): Put a call to
        applyAppleDictionaryApplicationQuirk here. This was a case I had missed before,
        when the script is cached. This fixes one of the two problems with the initial
        patch; the other fix is in WebCore.
        (WebFrameLoaderClient::dispatchWillSendRequest): Changed the
        applyAppleDictionaryApplicationQuirk call here to work the new simpler way.

        * WebView/WebView.mm: Had to add an include due to changes in WebCore header includes.

2009-01-02  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Darin Adler.

        Bug 23060: REGRESSION (r38629): Cannot scroll a WebHTMLView using Home/End/Page up/Page down
        <https://bugs.webkit.org/show_bug.cgi?id=23060>
        <rdar://problem/6467830>

        After r38629, all keyboard events get sent by Editor to the EditorClient, even
        if the selection is not editable. If the event's command is unsupported by
        WebHTMLView, WebHTMLView mistakenly thinks that the event was handled when it
        was not. When using the page up / page down keys, the events generated are of
        the form scrollPageUp rather than movePageUp, so they are unsupported by
        WebHTMLView and cause this bug to occur.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView doCommandBySelector:]):

2009-01-02  Darin Adler  <darin@apple.com>

        Reviewed by Oliver Hunt.

        Bug 23072: REGRESSION (r37371): In the Dictionary application, scroll bar appears inside its web view when resizing its window
        https://bugs.webkit.org/show_bug.cgi?id=23072
        rdar://problem/6368028

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (isAppleDictionaryApplication): Added.
        (applyAppleDictionaryApplicationQuirk): Added. Under the right conditions, sets
        a flag to ask HTMLFrameElementBase to ignore the scrolling attribute.
        (WebFrameLoaderClient::dispatchWillSendRequest): Call the two functions above to
        apply the quirk when the relevant script is loaded.

2008-12-26  Dan Bernstein  <mitz@apple.com>

        Reviewed by Sam Weinig.

        - fix <rdar://problem/6467608> lastVisitWasFailure flag persists in
          global history after a successful visit

        * History/WebHistory.mm:
        (-[WebHistory _visitedURL:withTitle:wasFailure:]): Changed to always
        update the wasFailure flag on the HistoryItem.

2008-12-23  Darin Adler  <darin@apple.com>

        Reviewed by Alexey Proskuryakov (a slightly earlier version).

        - fix https://bugs.webkit.org/show_bug.cgi?id=22976
          crash due to Mail's use of WebArchive and WebResource on non-main thread

        * Misc/WebKitLogging.h: Improved comments for ASSERT_MAIN_THREAD. Got rid of
        WebKitRunningOnMainThread function, which was just a cover for pthread_main_np.
        * Misc/WebKitLogging.m: Ditto.

        * Misc/WebKitVersionChecks.h: Added a version after which we won't do the
        main thread workaround.

        * Misc/WebNSObjectExtras.h: Added a new method, _webkit_getPropertyOnMainThread:,
        which performs a selector on the main thread, waits for it to complete, and then
        returns the value on the caller thread.
        * Misc/WebNSObjectExtras.mm: Added.

        * WebView/WebArchive.mm:
        (-[WebArchive init]): Added WebCoreThreadViolationCheck.
        (-[WebArchive initWithMainResource:subresources:subframeArchives:]): Perform
        initialization on main thread if needMailThreadWorkaround is true.
        Also added WebCoreThreadViolationCheck.
        (-[WebArchive initWithData:]): Added WebCoreThreadViolationCheck.
        (-[WebArchive mainResource]): Get property on main thread if
        needMailThreadWorkaround is true. Also added WebCoreThreadViolationCheck.
        (-[WebArchive subresources]): Ditto.
        (-[WebArchive subframeArchives]): Ditto.
        (-[WebArchive data]): Ditto.
        (-[WebArchive _initWithCoreLegacyWebArchive:]): Added WebCoreThreadViolationCheck.
        (-[WebArchive _coreLegacyWebArchive]): Ditto.
        (-[WebArchive _initWithArguments:]): Added. Used to implement the cross-thread
        version of initWithMainResource above.

        * WebView/WebResource.mm:
        (-[WebResource initWithCoder:]): Added WebCoreThreadViolationCheck.
        (-[WebResource data]): Get property on main thread if
        needMailThreadWorkaround is true. Also added WebCoreThreadViolationCheck.
        (-[WebResource URL]): Ditto.
        (-[WebResource MIMEType]): Ditto.
        (-[WebResource textEncodingName]): Ditto.
        (-[WebResource frameName]): Ditto.
        (-[WebResource _ignoreWhenUnarchiving]): Ditto.
        (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]):
        Perform initialization on main thread if needMailThreadWorkaround is true.
        Also added WebCoreThreadViolationCheck.
        (-[WebResource _suggestedFilename]): Added. Helper for _fileWrapperRepresentation.
        (-[WebResource _fileWrapperRepresentation]): Rewrote to use methods instead of
        getting at coreResource directly.
        (-[WebResource _response]): Get property on main thread if
        needMailThreadWorkaround is true. Also added WebCoreThreadViolationCheck.
        (-[WebResource _stringValue]): Ditto.
        (+[WebResource _needMailThreadWorkaroundIfCalledOffMainThread]): Added.
        (-[WebResource _initWithArguments:]): Added. Used to implement the cross-thread
        version of _initWithData above.

        * WebView/WebResourceInternal.h: Changed to include WebResourcePrivate.h since internal
        clients have access to the SPI as well as the API. Added definition of MAIL_THREAD_WORKAROUND
        and the needMainThreadWorkaround helper function.

        * Misc/WebIconDatabase.mm: Removed include of now-defunct FoundationExtras.h
        file. This probably fixes clean builds.
        * WebCoreSupport/WebIconDatabaseClient.mm: Ditto.

        * WebCoreSupport/WebFrameLoaderClient.mm: Removed include of WebResourcePrivate.h,
        since it's not actually used.
        * WebView/WebDataSource.mm: Ditto.
        * WebView/WebHTMLRepresentation.mm: Ditto.

2008-12-23  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        - fix https://bugs.webkit.org/show_bug.cgi?id=22979
          crash seen in -[WebView drawsBackground] when quitting
          <rdar://problem/6464601>

        * WebView/WebView.mm:
        (-[WebView drawsBackground]): Added comment and a null check for _private.

2008-12-22  Kevin Decker  <kdecker@apple.com>

        Reviewed by Anders Carlsson.

        <rdar://problem/6449588> REGRESSION (r38279-r38280): Minimize them remaximize a window with a flash plugin, plugin doesn't resume at full speed
        
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView windowDidDeminiaturize:]): Deminiaturizing should restart timers, not stop timers.

2008-12-19  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler, Adele Peterson, Brady Eidson.
        
        Added SPI for getting an unsorted vector of all items in history.
        
        * History/WebHistory.h:
        * History/WebHistory.mm:
        (-[WebHistory allItems]):

2008-12-18  Dan Bernstein  <mitz@apple.com>

        Reviewed by Sam Weinig.

        - implement FrameLoaderClient::shouldUseCredentialStorage() by calling
          a new resource load delegae method.

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::shouldUseCredentialStorage): Added. Calls the
        delegate method. If the method is unimplemented, returns true for
        backwards compatibility.
        * WebView/WebView.mm: 
        (-[WebView _cacheResourceLoadDelegateImplementations]): Initialize the
        shouldUseCredentialStorageFunc member.
        (CallResourceLoadDelegateReturningBoolean): Added.
        * WebView/WebViewInternal.h:
        * WebView/WebResourceLoadDelegatePrivate.h: Declared the delegate method
        -webView:resource:shouldUseCredentialStorageForDataSource:.

2008-12-18  Cameron Zwarich  <zwarich@apple.com>

        Reviewed by Jonathan Honeycutt.

        Fix an apparent typo in r39385 that is causing lots of crashes.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):

2008-12-18  Brady Eidson  <beidson@apple.com>

        Reviewed by John Sullivan

        Initial visit to a website creates history items that start with a visit count of
        zero instead of one

        * History/WebHistory.mm:
        (-[WebHistoryPrivate visitedURL:withTitle:]): Set the visit count on new items

        * History/WebHistoryItem.mm:
        (-[WebHistoryItem _setVisitCount:]): Call through to the WebCore item
        * History/WebHistoryItemInternal.h:

2008-12-18  Sam Weinig  <sam@webkit.org>

        Reviewed by John Sullivan.

        Implement FrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout() by calling
        a new private frame load delegate method.

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):
        * WebView/WebView.mm:
        (-[WebView _cacheFrameLoadDelegateImplementations]):
        * WebView/WebViewInternal.h:
        * WebView/WebViewPrivate.h:

2008-12-16  Antti Koivisto  <antti@apple.com>

        Reviewed by John Sullivan.
        
        Add version check for shift-reload behavior.

        * Misc/WebKitVersionChecks.h:
        * WebView/WebFrame.mm:
        (-[WebFrame reload]):

2008-12-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Start sending keyboard events to the plug-in host.
        
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::keyEvent):
        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView keyDown:]):
        (-[WebHostedNetscapePluginView keyUp:]):
        * Plugins/Hosted/WebKitPluginHost.defs:

2008-12-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        <rdar://problem/6450538>
        
        Fix flag enumeration.
        
        * Plugins/Hosted/WebKitPluginHostTypes.h:

2008-12-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        Instead of passing a gazillion booleans to WKPCLoadURL, pass a single set of flags.
        
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCLoadURL):
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::loadURL):
        * Plugins/Hosted/WebKitPluginClient.defs:
        * Plugins/Hosted/WebKitPluginHostTypes.h:

2008-12-16  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.

        Add trailing null to headers to avoid a crash in the plug-in host.
        
        * Plugins/Hosted/HostedNetscapePluginStream.mm:
        (WebKit::HostedNetscapePluginStream::didReceiveResponse):

2008-12-15  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Cameron Zwarich.

        <rdar://problem/6289933> Change WebKit-related projects to build with GCC 4.2 on Leopard.

        * Configurations/Base.xcconfig:
        * Configurations/DebugRelease.xcconfig:

2008-12-15  Stephanie Lewis  <slewis@apple.com>

        Fix build.

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:

2008-12-15  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Change InstantiatePlugin to be asynchronous so we won't deadlock if the plug-in tries to call
        back into us while it's being instantiated.
        
        * Plugins/Hosted/NetscapePluginHostManager.mm:
        (WebKit::NetscapePluginHostManager::instantiatePlugin):
        * Plugins/Hosted/NetscapePluginHostProxy.h:
        (WebKit::NetscapePluginHostProxy::clientPort):
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCInstantiatePluginReply):
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        (WebKit::NetscapePluginInstanceProxy::Reply::):
        (WebKit::NetscapePluginInstanceProxy::Reply::Reply):
        (WebKit::NetscapePluginInstanceProxy::Reply::~Reply):
        (WebKit::NetscapePluginInstanceProxy::InstantiatePluginReply::InstantiatePluginReply):
        (WebKit::NetscapePluginInstanceProxy::setCurrentReply):
        (WebKit::NetscapePluginInstanceProxy::waitForReply):
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
        (WebKit::NetscapePluginInstanceProxy::processRequestsAndWaitForReply):
        * Plugins/Hosted/WebKitPluginClient.defs:
        * Plugins/Hosted/WebKitPluginHost.defs:

2008-12-15  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Let WebKit generate a plug-in ID instead of having the plug-in host do it.

        * Plugins/Hosted/NetscapePluginHostManager.mm:
        (WebKit::NetscapePluginHostManager::instantiatePlugin):
        Create the plug-in proxy before instantiating the plug-in.
        
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        (WebKit::NetscapePluginInstanceProxy::create):
        (WebKit::NetscapePluginInstanceProxy::setRenderContextID):
        (WebKit::NetscapePluginInstanceProxy::setUseSoftwareRenderer):
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
        * Plugins/Hosted/WebKitPluginHost.defs:

2008-12-15  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        LoadURL doesn't need to be asynchronous.
        
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCLoadURL):
        * Plugins/Hosted/WebKitPluginClient.defs:
        * Plugins/Hosted/WebKitPluginHost.defs:

2008-12-15  Antti Koivisto  <antti@apple.com>

        Reviewed by Darin Adler.
        
        - Add [WebFrame reloadFromOrigin] for performing end-to-end reload.
        - Add corresponding IBAction to WebView.
        - Temporarily make [WebFrame reload] trigger end-to-end reload if shift modifier is pressed when it is called.

        * WebView/WebFrame.h:
        * WebView/WebFrame.mm:
        (-[WebFrame reload]):
        (-[WebFrame reloadFromOrigin]): 
        * WebView/WebFramePrivate.h: Match the FrameLoadType enum in WebCore.
        * WebView/WebView.h:
        * WebView/WebView.mm:
        (-[WebView reloadFromOrigin:]):

2008-12-14  Dan Bernstein  <mitz@apple.com>

        Reviewed by Darin Adler.

        - fix <rdar://problem/3258561> WebHistoryAllItemsRemovedNotification
          should add items to userInfo

        * History/WebHistory.mm:
        (-[WebHistoryPrivate allItems]): Added this helper method, which returns
        all values in the _entriesByURL dictionary.
        (-[WebHistory removeAllItems]): Changed to send the array of all items
        in the notification.

2008-12-13  Darin Adler  <darin@apple.com>

        - <rdar://problem/6441035> WebTextIterator class not exported in WebKit

        * WebKit.exp: Added the class. We forgot to export it when we added
        the WebTextIterator SPI.

2008-12-12  Darin Adler  <darin@apple.com>

        Rubber stamped by Adam Roben.

        - fix <rdar://problem/5648301> Can't tab around to text fields in Safari
          login sheet after clicking static text, due to AppKit key loop change

        * Panels/English.lproj/WebAuthenticationPanel.nib/classes.nib: Removed.
        * Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib: Added.
        * Panels/English.lproj/WebAuthenticationPanel.nib/info.nib: Removed.
        * Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
        Set nextKeyView of the selectable static texts to the editable text.
        Updated nib format.

2008-12-12  Stephanie Lewis  <slewis@apple.com>

        Reviewed by Geoff Garen.

        Shrink Cache Sizes.

        * WebView/WebView.mm:
        (+[WebView _setCacheModel:]):

2008-12-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Tim Hatcher.

        Don't try to free the dummy "1" port state.
        
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView sendEvent:isDrawRect:]):
        (-[WebNetscapePluginView updateAndSetWindow]):

2008-12-11  Cameron Zwarich  <zwarich@apple.com>

        Rubber-stamped by Mark Rowe.

        Roll out r39212 due to assertion failures during layout tests, multiple
        layout test failures, memory leaks, and obvious incorrectness.

        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.mm:
        (-[WebPreferences fullDocumentTeardownEnabled]):
        * WebView/WebPreferencesPrivate.h:

2008-12-11  Stephanie Lewis  <slewis@apple.com>

        Fix build.

        * WebView/WebView.mm:

2008-12-11  Stephanie Lewis  <slewis@apple.com>

        Reviewed by Oliver Hunt.

        Empty Web cache before quitting a debug build in order
        to report accurate CachedResource leaks.

        * WebView/WebView.mm:
        (-[WebView _close]):

2008-12-11  Anders Carlsson  <andersca@apple.com>

        Fix Tiger build.

        * Misc/WebNSDataExtras.h:

2008-12-11  Anders Carlsson  <andersca@apple.com>

        Reviewed by Cameron Zwarich.

        https://bugs.webkit.org/show_bug.cgi?id=22797
        REGRESSION: Crash at http://news.cnet.com/8301-17939_109-10119149-2.html

        Make sure to protect the stream because destroyStream can otherwise cause it to be deleted.
        
        * Plugins/WebBaseNetscapePluginStream.mm:
        (WebNetscapePluginStream::destroyStreamWithReason):

2008-12-10  Glenn Wilson  <gwilson@google.com>

        Reviewed by Adam Roben.

        Added new methods for overriding default WebPreference values
        and for resetting preferences to their defaults.
        https://bugs.webkit.org/show_bug.cgi?id=20534

        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.mm:
        (-[WebPreferences resetToDefaults]): new method
        (-[WebPreferences overridePreference:flag:]): new method
        * WebView/WebPreferencesPrivate.h: new method signatures

2008-12-10  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Implement support for NPN_PostURL/NPN_PostURLNotify in WebKit.
        
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        Add stopAllStreams.
        
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::stopAllStreams):
        Factored out this from ::destroy.
        
        (WebKit::NetscapePluginInstanceProxy::destroy):
        Call stopAllStreams().
        
        (WebKit::NetscapePluginInstanceProxy::pluginHostDied):
        Ditto.
        
        (WebKit::NetscapePluginInstanceProxy::loadURL):
        Handle post being true. This code has been copied from WebNetscapePluginView.mm (for now).

2008-12-10  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Move two NSData category methods to WebNSDataExtras.m.
        
        * Misc/WebNSDataExtras.h:
        * Misc/WebNSDataExtras.m:
        (-[NSData _web_startsWithBlankLine]):
        (-[NSData _web_locationAfterFirstBlankLine]):
        * Plugins/WebNetscapePluginView.mm:

2008-12-10  Alice Liu  <alice.liu@apple.com>

        fixed https://bugs.webkit.org/show_bug.cgi?id=20685

        Reviewed by Darin Adler.

        * Misc/WebNSPasteboardExtras.mm:
        Ask image for its file extension instead of falling back on MIME type and file path.
        Also moved this code to before setting the pasteboard data so as not to set any if
        no extension can be determined.
        (-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):

        * WebView/WebHTMLView.mm:
        Fixed a separate but related long-standing bug of how the filename for the promised
        drag data is determined by asking the image for a proper file extension. 
        (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):

2008-12-09  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Fix typecast.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]):

2008-12-09  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Implement software rendering of hosted plug-ins.
        
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCInvalidateRect):
        New MiG function. This is called by the plug-in host when it has drawn something.
        
        * Plugins/Hosted/WebHostedNetscapePluginView.h:
        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView createPlugin]):
        Create a software renderer.
        
        (-[WebHostedNetscapePluginView destroyPlugin]):
        Destroy the software renderer.
        
        (-[WebHostedNetscapePluginView drawRect:]):
        Draw using the software renderer.
        
        * Plugins/Hosted/WebKitPluginClient.defs:
        Add InvalidateRect.

2008-12-09  Brett Wilson  <brettw@chromium.org>

        Reviewed by Dave Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=22177

        Add a callback on ChromeClient that the state of form elements on
        the page has changed. This is to allow clients implementing session
        saving to know when the current state is dirty.

        * WebCoreSupport/WebChromeClient.h:
        (WebChromeClient::formStateDidChange):

2008-12-09  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Make sure to pause null events for hosted plug-ins as well.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]):

2008-12-09  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        * Plugins/Hosted/NetscapePluginHostProxy.h:
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
        (WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy):
        Unfortunately we can't use a libdispatch source right now, because of <rdar://problem/6393180>.

2008-12-09  Timothy Hatcher  <timothy@apple.com>

        Implement a few methods needed to keep Dictionary.app working on Leopard.

        <rdar://problem/6002160> Internal changes to WebKit in Safari 4
        Developer Preview might break Dictionary

        Reviewed by Dan Bernstein.

        * WebView/WebFrame.mm:
        (-[WebFrame convertNSRangeToDOMRange:]): Added. Calls _convertNSRangeToDOMRange.
        (-[WebFrame convertDOMRangeToNSRange:]): Added. Calls _convertDOMRangeToNSRange.
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _bridge]): Added. Returns the WebFrame, which has the methods
        that Dictionary.app is using.

2008-12-08  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        More work towards getting NPN_GetURL working.
        
        * Plugins/Hosted/HostedNetscapePluginStream.h:
        Inherit from NetscapePlugInStreamLoaderClient.
        
        (WebKit::HostedNetscapePluginStream::streamID):
        * Plugins/Hosted/HostedNetscapePluginStream.mm:
        (WebKit::HostedNetscapePluginStream::startStream):
        Keep track of the resposne URL and the MIME type. Pass the response URL to the 
        plug-in host.
        
        (WebKit::HostedNetscapePluginStream::didFinishLoading):
        Disconnect the stream.
        
        (WebKit::HostedNetscapePluginStream::start):
        Create a plug-in stream loader and start loading.
        
        (WebKit::HostedNetscapePluginStream::stop):
        Cancel the load.
        
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCLoadURL):
        Fix the parameter order.
        
        (WKPCCancelLoadURL):
        New function that cancels a load of a stream with a given reason.
        
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::destroy):
        Stop the streams.
        
        (WebKit::NetscapePluginInstanceProxy::pluginStream):
        Return a plug-in stream given a stream ID.
        
        (WebKit::NetscapePluginInstanceProxy::disconnectStream):
        Remove the stream from the streams map.
        
        (WebKit::NetscapePluginInstanceProxy::loadRequest):
        Create a stream and load it.
        
        * Plugins/Hosted/WebKitPluginClient.defs:
        Add CancelLoadURL.
        
        * Plugins/Hosted/WebKitPluginHost.defs:
        Add responseURL to StartStream.
        
        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView pluginPackage]):
        Move this down to the base class from WebNetscapePluginView.
        
        * Plugins/WebNetscapePluginView.h:
        * Plugins/WebNetscapePluginView.mm:

2008-12-08  Dan Bernstein  <mitz@apple.com>

        Reviewed by John Sullivan.

        - WebKit/mac part of tracking the global history item for a WebView

        * WebView/WebView.mm:
        (-[WebView _globalHistoryItem]): Added. Returns the page's global
        history item.
        * WebView/WebViewPrivate.h:

2008-12-06  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=15671

        VisiblePosition::caretRect() was renaemd to absoluteCaretBounds().
        
        * WebView/WebFrame.mm:
        (-[WebFrame _caretRectAtNode:offset:affinity:]):

2008-12-06  David Kilzer  <ddkilzer@apple.com>

        Bug 22666: Clean up data structures used when collecting URLs of subresources for webarchives

        <https://bugs.webkit.org/show_bug.cgi?id=22666>

        Reviewed by Darin Adler.

        * DOM/WebDOMOperations.mm:
        (-[DOMNode _subresourceURLs]): Changed from using Vector<KURL> to
        ListHashSet<KURL> when calling WebCore::Node::getSubresourceURLs().

2008-12-05  Alexey Proskuryakov  <ap@webkit.org>

        Reviewed by Darin Adler.

        <rdar://problem/6405599> Tiger Mail crashes when using "Mail Contents of This Page"
        in Safari before opening a mail message in Mail

        * Carbon/CarbonWindowAdapter.m: Removed.
        * Carbon/CarbonWindowAdapter.mm: Copied from WebKit/mac/Carbon/CarbonWindowAdapter.m.
        (+[CarbonWindowAdapter initialize]):
        * History/WebBackForwardList.mm:
        (+[WebBackForwardList initialize]):
        * History/WebHistoryItem.mm:
        (+[WebHistoryItem initialize]):
        * Misc/WebElementDictionary.mm:
        (+[WebElementDictionary initialize]):
        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (+[WebHostedNetscapePluginView initialize]):
        * Plugins/WebBaseNetscapePluginView.mm:
        * Plugins/WebBasePluginPackage.m: Removed.
        * Plugins/WebBasePluginPackage.mm: Copied from WebKit/mac/Plugins/WebBasePluginPackage.m.
        (+[WebBasePluginPackage initialize]):
        * Plugins/WebNetscapePluginView.mm:
        (+[WebNetscapePluginView initialize]):
        * WebCoreSupport/WebEditorClient.mm:
        (+[WebEditCommand initialize]):
        * WebCoreSupport/WebFrameLoaderClient.mm:
        * WebView/WebArchive.mm:
        (+[WebArchivePrivate initialize]):
        * WebView/WebDataSource.mm:
        (+[WebDataSourcePrivate initialize]):
        * WebView/WebHTMLView.mm:
        (+[WebHTMLViewPrivate initialize]):
        (+[WebHTMLView initialize]):
        * WebView/WebResource.mm:
        (+[WebResourcePrivate initialize]):
        * WebView/WebView.mm:
        (+[WebViewPrivate initialize]):
        Call JSC::initializeThreading();

2008-12-04  Stephanie Lewis  <slewis@apple.com>

        Fix build.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCLoadURL):

2008-12-04  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        More work on streams.
        
        * Plugins/Hosted/HostedNetscapePluginStream.h: Added.
        (WebKit::HostedNetscapePluginStream::create):
        * Plugins/Hosted/HostedNetscapePluginStream.mm: Added.
        (WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):
        (WebKit::HostedNetscapePluginStream::startStreamWithResponse):
        (WebKit::HostedNetscapePluginStream::startStream):
        (WebKit::HostedNetscapePluginStream::didReceiveData):
        (WebKit::HostedNetscapePluginStream::didFinishLoading):
        (WebKit::HostedNetscapePluginStream::didReceiveResponse):
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        (WebKit::NetscapePluginInstanceProxy::pluginView):
        (WebKit::NetscapePluginInstanceProxy::hostProxy):
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::PluginRequest::PluginRequest):
        (WebKit::NetscapePluginInstanceProxy::PluginRequest::requestID):
        (WebKit::NetscapePluginInstanceProxy::PluginRequest::request):
        (WebKit::NetscapePluginInstanceProxy::PluginRequest::frameName):
        (WebKit::NetscapePluginInstanceProxy::PluginRequest::didStartFromUserGesture):
        (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
        (WebKit::NetscapePluginInstanceProxy::performRequest):
        (WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
        (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
        (WebKit::NetscapePluginInstanceProxy::loadRequest):
        * Plugins/Hosted/WebKitPluginHost.defs:

2008-12-04  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Start implementing WKPCLoadURL. Currently this has copied a lot of code from WebNetscapePluginView
        but once we have a more complete implementation of NPStreams we can start refactoring things so that the
        implementations can share more code.
        
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCLoadURL):
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
        (WebKit::NetscapePluginInstanceProxy::loadURL):
        (WebKit::NetscapePluginInstanceProxy::performRequest):
        (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
        (WebKit::NetscapePluginInstanceProxy::loadRequest):
        * Plugins/Hosted/WebKitPluginClient.defs:
        * Plugins/Hosted/WebKitPluginHost.defs:

2008-12-04  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.
        
        Move requestWithURLCString to WebBaseNetscapePluginView.
        
        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView requestWithURLCString:]):
        * Plugins/WebNetscapePluginView.mm:

2008-12-03  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Move WebPluginRequest to its own file.
        
        * Plugins/WebNetscapePluginView.mm:
        * Plugins/WebPluginRequest.h: Added.
        * Plugins/WebPluginRequest.m: Added.
        (-[WebPluginRequest initWithRequest:frameName:notifyData:sendNotification:didStartFromUserGesture:]):
        (-[WebPluginRequest dealloc]):
        (-[WebPluginRequest request]):
        (-[WebPluginRequest frameName]):
        (-[WebPluginRequest isCurrentEventUserGesture]):
        (-[WebPluginRequest sendNotification]):
        (-[WebPluginRequest notifyData]):

2008-12-03  Anders Carlsson  <andersca@apple.com>

        Handle the CA model.

        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView setWindowIfNecessary]):

2008-12-03  Anders Carlsson  <andersca@apple.com>

        Reviewed by Kevin Decker.
        
        <rdar://problem/6412293>
        Call NPP_SetWindow for CA plug-ins.
        
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
        (-[WebNetscapePluginView restorePortState:]):
        (-[WebNetscapePluginView isNewWindowEqualToOldWindow]):
        (-[WebNetscapePluginView updateAndSetWindow]):
        (-[WebNetscapePluginView setWindowIfNecessary]):

2008-12-03  Anders Carlsson  <andersca@apple.com>

        Fix the release build.

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WebKit::NetscapePluginHostProxy::deadNameNotificationCallback):

2008-12-03  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6412234>
        Don't crash if we can't launch the plug-in host.

        * Plugins/Hosted/NetscapePluginHostManager.mm:
        (WebKit::NetscapePluginHostManager::instantiatePlugin):

2008-12-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Start processing messages sent to the client port.
        
        * Plugins/Hosted/NetscapePluginHostProxy.h:
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        Add a map from ports to plug-in proxies. Turn the set of instances into a map from
        pluginID to instance proxy.
        
        (WKPCStatusText):
        Look up the right instance proxy and call status().
        
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        (WebKit::NetscapePluginInstanceProxy::pluginID):
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::status):
        Implement this.
        
        * Plugins/Hosted/WebKitPluginClient.defs:
        Add the plug-in ID to StatusText.

2008-12-02  Gregory Hughes  <ghughes@apple.com>

        Reviewed by Beth Dakin.

        Bug 22513: ZOOM: text selection does not send correct zoom bounds

        When zoomed, text selection must send the zoom bounds in flipped
        screen coordinates.

        * WebCoreSupport/WebViewFactory.mm:
        (-[WebViewFactory accessibilityConvertScreenRect:]):

2008-12-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Create a client mach port and pass it to the plug-in host.
        
        * Plugins/Hosted/NetscapePluginHostManager.h:
        * Plugins/Hosted/NetscapePluginHostManager.mm:
        (WebKit::NetscapePluginHostManager::hostForPackage):
        (WebKit::NetscapePluginHostManager::spawnPluginHost):
        * Plugins/Hosted/NetscapePluginHostProxy.h:
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
        * Plugins/Hosted/WebKitPluginHost.defs:

2008-12-02  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Let the plug-in views know if the plug-in host crashes.
        
        * Plugins/Hosted/NetscapePluginHostManager.h:
        * Plugins/Hosted/NetscapePluginHostManager.mm:
        (WebKit::NetscapePluginHostManager::instantiatePlugin):
        * Plugins/Hosted/NetscapePluginHostProxy.h:
        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WebKit::NetscapePluginHostProxy::pluginHostDied):
        (WebKit::NetscapePluginHostProxy::addPluginInstance):
        (WebKit::NetscapePluginHostProxy::removePluginInstance):
        
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        (WebKit::NetscapePluginInstanceProxy::create):
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        Keep a pointer to the host proxy.
        
        (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
        Add the instance to the host set.
        
        (WebKit::NetscapePluginInstanceProxy::~NetscapePluginInstanceProxy):
        Remove the instance form the host set.
        
        (WebKit::NetscapePluginInstanceProxy::pluginHostDied):
        Tell the plug-in view that the plug-in died.

        * Plugins/Hosted/WebHostedNetscapePluginView.h:
        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView createPlugin]):
        Pass the plug-in view to the instantiatePlugin.
        
        (-[WebHostedNetscapePluginView pluginHostDied]):
        Handle the plug-in host crashing.
        
        (-[WebHostedNetscapePluginView drawRect:]):
        Fill the plug-in view with a nice red shade if the plug-in crashes.

2008-12-01  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.