1 2008-02-29 Mark Rowe <mrowe@apple.com>
3 Reviewed by Anders Carlsson.
5 Replace use of WKPathFromFont with implementation in terms of public API.
7 * WebCoreSupport/WebSystemInterface.m:
8 (InitWebCoreSystemInterface): Remove unused symbol.
10 2008-02-29 Mark Rowe <mrowe@apple.com>
12 Reviewed by Oliver Hunt.
14 Fix spelling of "request" in name of WKNSURLProtocolClassForRequest.
16 * Misc/WebNSURLExtras.mm:
17 (-[NSURL _webkit_canonicalize]):
20 2008-02-29 Mark Rowe <mrowe@apple.com>
22 Reviewed by Oliver Hunt.
24 Don't use WKSupportsMultipartXMixedReplace on Leopard as multipart/x-mixed-replace is always handled by NSURLRequest.
26 * WebCoreSupport/WebSystemInterface.m:
27 (InitWebCoreSystemInterface):
29 2008-02-29 Mark Rowe <mrowe@apple.com>
31 Reviewed by Oliver Hunt.
33 Remove obsolete code that had been left intact to support users running WebKit with older versions of Safari.
35 * Misc/WebNSViewExtras.m: Remove _web_superviewOfClass:stoppingAtClass:.
36 * Misc/WebNSWindowExtras.m: Remove _webkit_displayThrottledWindows.
37 * Misc/WebSearchableTextView.m: Remove selectionImageForcingWhiteText:.
38 * WebCoreSupport/WebImageRendererFactory.m: Update comment to mention the last version of Safari that
40 * WebInspector/WebInspector.mm: Remove sharedWebInspector and update comments to mention the last version
41 of Safari that calls other obsolete methods.
42 * WebView/WebDocumentPrivate.h: Remove selectionImageForcingWhiteText:.
43 * WebView/WebHTMLView.mm: Ditto.
44 * WebView/WebPDFView.mm: Ditto.
45 * WebView/WebView.mm: Update comment to mentoin the last version of Safari that requires the obsolete method.
47 2008-02-29 Mark Rowe <mrowe@apple.com>
49 Rubber-stamped by Eric Seidel.
51 Remove unneeded includes of WebKitSystemInterface.h.
53 * History/WebHistoryItem.mm:
54 * Misc/WebNSViewExtras.m:
55 * WebCoreSupport/WebFrameLoaderClient.mm:
56 * WebView/WebDataSource.mm:
57 * WebView/WebPDFView.mm:
59 2008-02-29 Mark Rowe <mrowe@apple.com>
61 Reviewed by Oliver Hunt and Oliver Hunt.
63 <rdar://problem/4753845> WebKit should use CGEventSourceSecondsSinceLastEventType in place of WKSecondsSinceLastInputEvent SPI.
65 * WebCoreSupport/WebSystemInterface.m:
66 (InitWebCoreSystemInterface): Remove unused symbol.
67 * WebKit.order: Ditto.
69 2008-02-28 Mark Rowe <mrowe@apple.com>
71 Reviewed by Dave Hyatt.
73 Make use of new CGFont APIs on Leopard rather than making a WebKitSystemInterface call.
75 * WebCoreSupport/WebSystemInterface.m:
76 (InitWebCoreSystemInterface): Only initialize wkGetFontMetrics on Tiger.
78 2008-02-27 Brady Eidson <beidson@apple.com>
80 Reviewed by Mark Rowe (code) and Darin (concept)
82 Much better fix for <rdar://problem/4930688> (see r19549)
83 Original fix for <rdar://problem/3947312> (and 14 dupes)
85 Let me tell you a story:
86 A long time ago, in a cvs repository far, far away, loader code was almost all up in WebKit.
87 WebArchive code was intertwined with that code in bizarre and complex ways.
88 During the months long loader re-factoring where we pushed much loader code down into WebCore,
89 many portions of the WebKit loader were thinned out until they ceased to exist. Others remained
92 One such section of code whose lineage traces back from WebFrameLoaderClient to WebFrameLoader
93 to WebLoader was originally rooted in the method [WebLoader loadRequest:]. This method was the
94 single entry point for almost all loading (network or web archives)
96 This method would check various headers and other fields on the NSURLRequest and NSURLResponse
97 to make decisions about the load. If the cache control fields were expired or other conditions
98 in the headers were met, the load would be forced to go out to the network.
100 As the loader was moved and tweaked repeatedly, most of this code was pruned or re-factored.
101 At some point, all that remained was the special cases for loading WebArchives.
103 Somewhere in the r16,000s, this remaining responsibility was noticed and related methods we renamed
104 to be WebArchive specific, further cementing the assumed design.
106 Problem is, the design was bad. A WebArchive is meant to be a static snapshot of a WebPage at a
107 specific point in time. Referring to the request to see if the resource should be reloaded seems
108 nonsensical, as does referring to the response headers to see if the resource is "expired". In the
109 context of loading a WebArchive, available data should *always* be loaded from the WebArchive, at least
110 during the initial load!
112 After discovering the secret to reproducing all of these bugs is both emptying our your Foundation
113 cache and disconnecting your network, it was easy to reproduce the 16 individually reported cases
114 that were all symptoms of this bug, and easy to verify that they are fixed with this patch.
116 * WebCoreSupport/WebFrameLoaderClient.h:
117 * WebCoreSupport/WebFrameLoaderClient.mm:
118 (WebFrameLoaderClient::willUseArchive): Do not call either form of "canUseArchivedResource()" that
119 inspect the request or response objects - We are loading from a WebArchive, and we should never
120 make the decision to go out to the network when we actually have the resource available.
122 * WebCoreSupport/WebSystemInterface.m:
123 (InitWebCoreSystemInterface): Remove two methods that are no longer used anywhere in WebKit
125 2008-02-27 Matt Lilek <webkit@mattlilek.com>
127 Reviewed by Adam Roben.
129 Bug 14348: Messing up the inspector by dragging an URL into it
130 http://bugs.webkit.org/show_bug.cgi?id=14348
131 <rdar://problem/5283620> and <rdar://problem/5712808>
133 * WebCoreSupport/WebInspectorClient.mm:
134 (-[WebInspectorWindowController init]): Remove duplicate preference setting.
135 (-[WebInspectorWindowController webView:dragDestinationActionMaskForDraggingInfo:]):
137 2008-02-25 Darin Adler <darin@apple.com>
141 * WebView/WebArchiver.mm:
142 (+[WebArchiver archiveSelectionInFrame:]): Use blankURL.
143 * WebView/WebFrame.mm:
144 (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Avoid the
145 variable name URL to avoid clashing with the renamed KURL in the future. Also use
147 (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]): Ditto.
148 (-[WebFrame _loadHTMLString:baseURL:unreachableURL:]): Ditto.
149 (-[WebFrame loadHTMLString:baseURL:]): Ditto.
150 (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]): Ditto.
152 2008-02-24 Darin Adler <darin@apple.com>
156 - remove separate client calls for "standard" and "reload' history
158 * WebCoreSupport/WebFrameLoaderClient.h:
159 * WebCoreSupport/WebFrameLoaderClient.mm:
160 (WebFrameLoaderClient::updateGlobalHistory):
162 2008-02-23 Alexey Proskuryakov <ap@webkit.org>
166 Move basic threading support from WebCore to WTF.
168 * ForwardingHeaders/wtf/Threading.h: Added.
169 * ForwardingHeaders/wtf/Locker.h: Added.
171 2008-02-23 David Kilzer <ddkilzer@apple.com>
173 Please clarify licensing for some files
174 <http://bugs.webkit.org/show_bug.cgi?id=14970>
178 * Plugins/WebNetscapeDeprecatedFunctions.c: Updated copyright statement
179 and added Apple BSD-style license.
180 * Plugins/WebNetscapeDeprecatedFunctions.h: Ditto.
182 2008-02-22 John Sullivan <sullivan@apple.com>
184 Reviewed by Adam Roben
186 Reverted the changed from yesterday to add pasteAndMatchStyle:, as the existing
187 pasteAsPlainText: has the same behavior.
189 * WebView/WebHTMLView.mm:
190 (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
191 (-[WebHTMLView readSelectionFromPasteboard:]):
192 (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
193 (-[WebHTMLView pasteAsRichText:]):
194 (-[WebHTMLView paste:]):
195 * WebView/WebView.mm:
196 * WebView/WebViewPrivate.h:
198 2008-02-21 Anders Carlsson <andersca@apple.com>
202 Use BackForwardList::create instead.
204 * History/WebBackForwardList.mm:
205 (-[WebBackForwardList init]):
207 2008-02-21 John Sullivan <sullivan@apple.com>
209 Reviewed by Jessica Kahn
211 support for pasteAndMatchStyle: command (see <rdar://problem/5723952>)
213 * WebView/WebHTMLView.mm:
214 (-[WebHTMLView _pasteWithPasteboard:allowPlainText:matchStyle:]):
215 added matchStyle parameter, passed along to bridge (formerly always passed NO to bridge)
216 (-[WebHTMLView readSelectionFromPasteboard:]):
217 pass NO for new matchStyle parameter to match old behavior
218 (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
219 validate pasteAndMatchStyle the same way as pasteAsRichText
220 (-[WebHTMLView pasteAndMatchStyle:]):
221 just like pasteAsRichText but passes YES for matchStyle
222 (-[WebHTMLView pasteAsRichText:]):
223 pass NO for new matchStyle parameter to match old behavior
224 (-[WebHTMLView paste:]):
227 * WebView/WebView.mm:
228 added macro(pasteAndMatchStyle)
230 * WebView/WebViewPrivate.h:
231 added pasteAndMatchStyle: to WebViewEditingActionsPendingPublic category
233 2008-02-20 Sam Weinig <sam@webkit.org>
235 Reviewed by Darin and Geoff.
237 - WebKit part of <rdar://problem/5754378> work around missing video on YouTube front page with a site-specific hack
239 * WebView/WebView.mm:
240 (-[WebView _preferencesChangedNotification:]): Added a call to Settings::setNeedsSiteSpecificQuirks.
241 There are currently no site-specific quirks on Mac, but we will propagate the state
242 to WebCore to avoid possible mistakes later.
244 2008-02-19 Anders Carlsson <andersca@apple.com>
248 Move back WebKit methods that were unused in WebCore.
250 * Misc/WebNSURLExtras.mm:
251 (+[NSURL _web_URLWithData:]):
252 (+[NSURL _web_URLWithData:relativeToURL:]):
253 (-[NSURL _web_originalData]):
254 (-[NSURL _web_originalDataAsString]):
255 (-[NSURL _web_isEmpty]):
256 (-[NSURL _webkit_canonicalize]):
257 (-[NSURL _webkit_URLByRemovingComponent:]):
258 (-[NSURL _webkit_URLByRemovingFragment]):
259 (-[NSURL _webkit_URLByRemovingResourceSpecifier]):
260 (-[NSURL _webkit_isFileURL]):
261 (-[NSString _webkit_isFileURL]):
262 * WebCoreSupport/WebFrameLoaderClient.mm:
263 (WebFrameLoaderClient::setTitle):
264 * WebCoreSupport/WebSystemInterface.m:
265 (InitWebCoreSystemInterface):
267 2008-02-18 Darin Adler <darin@apple.com>
271 * Misc/WebNSAttributedStringExtras.mm:
272 (+[NSAttributedString _web_attributedStringFromRange:]): Eliminate use of
275 2008-02-17 Sam Weinig <sam@webkit.org>
277 Reviewed by Dan Bernstein.
279 Fix for http://bugs.webkit.org/show_bug.cgi?id=17365
280 document.createEvent("MessageEvent") throws NOT_SUPPORTED_ERR
282 * MigrateHeaders.make: Migrate DOMProgressEvent.h and DOMTextPrivate.h which were
283 mistakenly not migrated.
285 2008-02-15 Dan Bernstein <mitz@apple.com>
287 Reviewed by Alexey Proskuryakov.
289 - WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=17360
290 <rdar://problem/5743131> REGRESSION: mp4 file downloaded from server is downloaded as html
292 * WebView/WebDataSource.mm:
293 (+[WebDataSource _representationClassForMIMEType:]):
294 (-[WebDataSource _responseMIMEType]):
295 (-[WebDataSource subresources]):
296 (-[WebDataSource subresourceForURL:]):
297 * WebView/WebResource.mm:
298 (-[WebResource _initWithData:URL:response:]):
299 * WebView/WebResourcePrivate.h:
301 2008-02-15 Adam Roben <aroben@apple.com>
303 Make WebKit's FEATURE_DEFINES match WebCore's
307 * Configurations/WebKit.xcconfig:
309 2008-02-14 Darin Adler <darin@apple.com>
311 Reviewed by Eric Seidel.
313 - updated for WebCore KURL changes
315 * History/WebHistoryItem.mm:
316 (-[WebHistoryItem URL]): Removed getNSURL call.
317 * Misc/WebElementDictionary.mm:
318 (-[WebElementDictionary _absoluteImageURL]): Ditto.
319 (-[WebElementDictionary _absoluteLinkURL]): Ditto.
320 * Misc/WebNSAttributedStringExtras.mm:
321 (fileWrapperForElement): Ditto.
322 (+[NSAttributedString _web_attributedStringFromRange:]): Ditto.
323 * Misc/WebNSURLExtras.mm:
324 (-[NSString _webkit_stringByReplacingValidPercentEscapes]): Updated
325 for function name change.
326 * WebCoreSupport/WebContextMenuClient.mm:
327 (WebContextMenuClient::downloadURL): Removed getNSURL call.
328 * WebCoreSupport/WebDragClient.mm:
329 (WebDragClient::createDragImageForLink): Ditto.
330 * WebCoreSupport/WebFrameLoaderClient.mm:
331 (WebFrameLoaderClient::dispatchWillPerformClientRedirect): Ditto.
332 (WebFrameLoaderClient::startDownload): Ditto.
333 (WebFrameLoaderClient::updateGlobalHistoryForStandardLoad): Ditto.
334 (WebFrameLoaderClient::updateGlobalHistoryForReload): Ditto.
335 (WebFrameLoaderClient::cancelledError): Ditto.
336 (WebFrameLoaderClient::blockedError): Ditto.
337 (WebFrameLoaderClient::cannotShowURLError): Ditto.
338 (WebFrameLoaderClient::interruptForPolicyChangeError): Ditto.
339 (WebFrameLoaderClient::cannotShowMIMETypeError): Ditto.
340 (WebFrameLoaderClient::fileDoesNotExistError): Ditto.
341 (WebFrameLoaderClient::willUseArchive): Ditto.
342 (WebFrameLoaderClient::setTitle): Ditto.
343 (WebFrameLoaderClient::actionDictionary): Ditto.
344 (WebFrameLoaderClient::createFrame): Ditto.
345 (WebFrameLoaderClient::objectContentType): Ditto.
346 (WebFrameLoaderClient::createPlugin): Ditto.
347 (WebFrameLoaderClient::createJavaAppletWidget): Ditto.
348 * WebView/WebDataSource.mm:
349 (-[WebDataSource _URL]): Ditto.
350 (-[WebDataSource _initWithDocumentLoader:]): Ditto.
351 (-[WebDataSource unreachableURL]): Ditto.
352 * WebView/WebHTMLView.mm:
353 (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
355 2008-02-14 Stephanie Lewis <slewis@apple.com>
363 2008-02-14 Alexey Proskuryakov <ap@webkit.org>
365 Reviewed by Adam Roben.
367 http://bugs.webkit.org/show_bug.cgi?id=17207
368 Database example doesn't work (requires not-yet-released Safari)
370 * WebCoreSupport/WebChromeClient.mm:
371 (WebChromeClient::exceededDatabaseQuota): Check Safari version, and allow 5 megabytes of storage
374 2008-02-11 Darin Adler <darin@apple.com>
376 - roll out fix for <rdar://problem/5726016> REGRESSION: Xcode News window renders
377 incorrectly due to visibility fix
379 Removed the Xcode-specific quirk at the request of some folks on the Xcode team.
381 * Misc/WebKitVersionChecks.h: Removed the constant.
383 * WebView/WebView.mm:
384 (-[WebView _needsXcodeVisibilityQuirk]): Removed.
385 (-[WebView _preferencesChangedNotification:]): Removed call to
386 setNeedsXcodeVisibilityQuirk.
388 2008-02-12 Anders Carlsson <andersca@apple.com>
392 * WebCoreSupport/WebFrameBridge.mm:
393 * WebCoreSupport/WebViewFactory.mm:
394 (-[WebViewFactory imageTitleForFilename:size:]):
395 Move implementation from WebFrameBridge to WebViewFactory.
397 2008-02-11 Darin Adler <darin@apple.com>
401 - fix <rdar://problem/5726016> REGRESSION: Xcode News window renders
402 incorrectly due to visibility fix
404 Added an Xcode-specific quirk.
406 * Misc/WebKitVersionChecks.h: Added a constant for the "linked on or after"
409 * WebView/WebView.mm:
410 (-[WebView _needsXcodeVisibilityQuirk]): Added.
411 (-[WebView _preferencesChangedNotification:]): Added a call to
412 setNeedsXcodeVisibilityQuirk based on _needsXcodeVisibilityQuirk.
414 2008-02-10 Darin Adler <darin@apple.com>
416 - fix http://bugs.webkit.org/show_bug.cgi?id=17274
417 REGRESSION: User Agent string broken in r30119
419 * WebView/WebView.mm:
420 (-[WebView _userAgentWithApplicationName:andWebKitVersion:]):
421 Fix wrong variable name. Doh!
423 2008-02-09 Darin Adler <darin@apple.com>
425 Reviewed by Tim Hatcher.
427 - fix <rdar://problem/5725996> crash every time you open the Xcode documentation window
429 * WebView/WebView.mm:
430 (-[WebView _userAgentWithApplicationName:andWebKitVersion:]): Work around a bug in the
431 garbage collector's Objective C++ support by not initializing a static to an object
432 that needs to be marked when running under GC.
434 2008-02-05 Dan Bernstein <mitz@apple.com>
436 Reviewed by Darin Adler.
438 - WebKit part of <rdar://problem/5724303> Should implement writing direction shortcuts
440 The key bindings are Command-Control-left arrow and
441 Command-Control-right arrow. To match AppKit, the bindings are enabled
442 only when certain user defaults are set.
444 * WebView/WebHTMLView.mm:
445 (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
446 (-[WebHTMLView toggleBaseWritingDirection:]): Changed to call
447 Frame::baseWritingDirectionForSelectionStart() and
448 Editor::setBaseWritingDirection() directly.
449 (-[WebHTMLView changeBaseWritingDirection:]): Ditto.
450 (writingDirectionKeyBindingsEnabled): Added.
451 (-[WebHTMLView _changeBaseWritingDirectionTo:]): Added this helper
453 (-[WebHTMLView changeBaseWritingDirectionToLTR:]): Added.
454 (-[WebHTMLView changeBaseWritingDirectionToRTL:]): Added.
455 * WebView/WebView.mm:
457 2008-02-05 Mark Rowe <mrowe@apple.com>
459 Unreviewed build fix.
461 * WebView/WebView.mm: Add missing #import.
463 2008-02-05 Mark Rowe <mrowe@apple.com>
465 Reviewed by Oliver Hunt.
467 Update versioning to support the mysterious future.
469 * Configurations/Version.xcconfig: Add SYSTEM_VERSION_PREFIX_1060.
471 2008-01-30 Justin Garcia <justin.garcia@apple.com>
473 Reviewed by Darin Adler.
475 <rdar://problem/5708115> REGRESSION: Words selected with a double click and copied won't paste into Mail
477 * WebView/WebHTMLView.mm:
478 (-[WebHTMLView _smartInsertForString:replacingRange:beforeString:afterString:]): Brought
479 this back, it's used by Mail.
480 (-[WebHTMLView _canSmartReplaceWithPasteboard:]): This WebInternal method is
481 also used by Mail. Moved to WebPrivate.
482 * WebView/WebHTMLViewPrivate.h: Expose two methods that Mail uses here, so that we don't
483 accidently remove them in the future.
485 2008-01-30 Mark Rowe <mrowe@apple.com>
487 Reviewed by Oliver Hunt.
489 Move off deprecated NSTableView methods.
491 * WebView/WebHTMLView.mm:
492 (-[WebTextCompleteController _buildUI]): Switch from -setDrawsGrid: to -setGridStyleMask:.
493 (-[WebTextCompleteController _placePopupWindow:]): Switch from -selectRow:byExtendingSelection: to -selectRowIndexes:byExtendingSelection:.
494 (-[WebTextCompleteController filterKeyDown:]): Ditto.
496 2008-01-26 Mark Rowe <mrowe@apple.com>
498 Reviewed by Darin Adler.
500 Fix leaks seen after loading <http://www.funnyordie.com/videos/d70b5a11cb>.
502 * Misc/WebNSDataExtras.m:
503 (-[NSString _web_capitalizeRFC822HeaderFieldName]): Transfer ownerhip of the allocated buffers
504 to the new CFString so that they will be freed when no longer needed.
506 2008-01-26 Greg Bolsinga <bolsinga@apple.com>
508 <rdar://problem/5708388> WebDashboardRegion.h duplicated between WebCore / WebKit
512 * WebCoreSupport/WebDashboardRegion.h: Removed.
513 * WebView/WebView.mm: Updated #import to use copy of WebDashboardRegion.h from WebCore.
515 2008-01-21 Darin Adler <darin@apple.com>
517 Reviewed by John Sullivan.
519 - fix <rdar://problem/5644324> Delegate-less WebKit clients should have no databases
520 - add a missing export of WebDatabaseExpectedSizeKey
521 - implement deleteOrigin: and remove deleteDatabasesWithOrigin:
523 * Storage/WebDatabaseManager.mm:
524 (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Updated to check for a null
525 name instead of calling isValid().
526 (-[WebDatabaseManager deleteOrigin:]): Implemented.
527 (WebKitInitializeDatabasesIfNecessary): Updated for name change.
529 * Storage/WebDatabaseManagerPrivate.h: Removed deleteDatabasesWithOrigin:.
531 * WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
532 * WebCoreSupport/WebChromeClient.mm:
533 (WebChromeClient::exceededDatabaseQuota): Replaced the two different client functions
534 we had before with a single one.
536 * WebKit.exp: Added missing export for WebDatabaseExpectedSizeKey.
538 * WebView/WebPreferenceKeysPrivate.h: Removed WebKitDefaultDatabaseQuotaKey.
539 * WebView/WebPreferences.m:
540 (+[WebPreferences initialize]): Removed the default for WebKitDefaultDatabaseQuotaKey.
541 * WebView/WebPreferencesPrivate.h: Removed defaultDatabaseQuota and
542 setDefaultDatabaseQuota:.
544 * WebView/WebUIDelegatePrivate.h: Replaced the two different database quota delegate
545 methods we had before with a single one.
547 * WebView/WebView.mm:
548 (-[WebView _preferencesChangedNotification:]): Removed the code to set the
549 default database origin quota in WebCore::Settings based on WebPreferences.
551 * WebView/WebViewInternal.h: Removed delegate method dispatch functions for unusual
552 types of parameters that the database UI delegate methods had before.
554 2008-01-20 Mark Rowe <mrowe@apple.com>
556 Reviewed by Dan Bernstein.
558 Remove code bracketed by REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM as we are no longer
559 interested in supporting Safari 2 with TOT WebKit.
561 * WebView/WebView.mm:
562 (+[WebView initialize]):
564 2008-01-17 Timothy Hatcher <timothy@apple.com>
566 Reviewed by Adam Roben.
568 <rdar://problem/5693558> REGRESSION (r29581): no form field focus rings
569 and inactive text selection after loading a page
570 Bug 16917: REGRESSION (r29581/2): Google Maps search box loses focused appearance
572 The problem was other frames were changing the FocusController's active
573 status to false after the first responder frame set it to true. The last
574 frame to call _updateActiveState would win.
576 * WebView/WebHTMLView.mm:
577 (-[WebHTMLView _updateActiveState]): Only call page->focusController()->setActive()
578 if the first responder is the current WebHTMLView or the WebFrameView.
579 (-[WebHTMLView _web_firstResponderCausesFocusDisplay]): Removed, inlined code in _updateActiveState.
581 2008-01-18 Adam Roben <aroben@apple.com>
583 Rename _updateActiveState to _updateFocusedAndActiveState
585 Also renamed any related methods/members similarly.
589 * WebView/WebHTMLView.mm:
590 (-[WebHTMLViewPrivate dealloc]):
591 (-[WebHTMLView _cancelUpdateFocusedAndActiveStateTimer]):
592 (-[WebHTMLView close]):
593 (_updateFocusedAndActiveStateTimerCallback):
594 (-[WebHTMLView viewWillMoveToWindow:]):
595 (-[WebHTMLView viewDidMoveToWindow]):
596 (-[WebHTMLView windowDidBecomeKey:]):
597 (-[WebHTMLView windowDidResignKey:]):
598 (-[WebHTMLView becomeFirstResponder]):
599 (-[WebHTMLView resignFirstResponder]):
600 * WebView/WebHTMLViewInternal.h:
601 * WebView/WebHTMLViewPrivate.h:
603 2008-01-17 John Sullivan <sullivan@apple.com>
607 - fixed <rdar://problem/5692068> -1 WebFrameView world leaks reported after closing view source window
609 * WebView/WebFrameView.mm:
610 (-[WebFrameView initWithCoder:]):
611 override to bump the global WebFrameView count
613 2008-01-16 Adam Roben <aroben@apple.com>
615 Updated for renames/removal of WebCore methods.
619 * Plugins/WebPluginController.mm:
620 (-[WebPluginController webPlugInContainerSelectionColor]): Changed to
621 ask isFocusedAndActive directly, instead of going through the frame
623 * WebView/WebHTMLView.mm:
624 (-[WebHTMLView _updateActiveState]): Updated for method renames.
626 2008-01-16 John Sullivan <sullivan@apple.com>
628 Reviewed by Adam and Dan
630 - cleaned up some existing logging
632 * WebView/WebHTMLView.mm:
633 (-[WebHTMLView setNeedsDisplay:]):
634 add method name to log, use "YES" and "NO" instead of (int)flag
635 (-[WebHTMLView setNeedsLayout:]):
637 (-[WebHTMLView setNeedsToApplyStyles:]):
640 2008-01-15 Geoffrey Garen <ggaren@apple.com>
642 Reviewed by Andre Boule.
644 Fixed <rdar://problem/5667627> [WebCache empty] implementation should
645 not disable/enable the cache
647 Toggle the cache model instead -- toggling disable/enable just causes
648 the cache to forget about resources, not reclaim their memory.
652 * WebView/WebView.mm:
653 * WebView/WebViewInternal.h:
655 2008-01-15 Adele Peterson <adele@apple.com>
657 Reviewed by Adam and Antti.
659 WebKit part of fix for <rdar://problem/5619062> Add load progress indicator to video controls
661 * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
662 Removed initialization for GetMediaControlBackgroundImageData. Added initialization for DrawMediaSliderTrack.
664 2008-01-10 Geoffrey Garen <ggaren@apple.com>
666 Reviewed by John Sullivan.
668 Fixed some world leak reports:
669 * <rdar://problem/5669436> PLT complains about world leak of 1 JavaScript
670 Interpreter after running cvs-base suite
672 * <rdar://problem/5669423> PLT complains about world leak if browser
673 window is open when PLT starts
675 These were both bugs in the reporting mechanism, so I took the
676 opportunity to do some house cleaning there.
678 * Misc/WebCoreStatistics.h: Did a little renaming, to match
679 JavaScriptCore better. I kept the methods with the old names around,
680 though, because old versions of Safari need them.
682 * Misc/WebCoreStatistics.mm: Removed dependence on
683 WebCore::JavaScriptStatistics, which is gone now.
685 These two methods are now distinct, for the sake of world leak reporting:
686 (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
687 (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
689 2008-01-10 Maciej Stachowiak <mjs@apple.com>
691 Not reviewed. Build fix.
693 - Attempt to fix mac build.
695 * Storage/WebDatabaseManager.mm:
697 2008-01-10 Maciej Stachowiak <mjs@apple.com>
701 - remove SecurityOriginData and fold its functionality into SecurityOrigin
703 * Storage/WebDatabaseManager.mm:
704 (-[WebDatabaseManager origins]):
705 (-[WebDatabaseManager databasesWithOrigin:]):
706 (-[WebDatabaseManager detailsForDatabase:withOrigin:]):
707 (-[WebDatabaseManager deleteDatabasesWithOrigin:]):
708 (-[WebDatabaseManager deleteDatabase:withOrigin:]):
709 * Storage/WebDatabaseTrackerClient.h:
710 * Storage/WebDatabaseTrackerClient.mm:
711 (WebDatabaseTrackerClient::dispatchDidModifyOrigin):
712 (WebDatabaseTrackerClient::dispatchDidModifyDatabase):
713 * Storage/WebSecurityOrigin.mm:
714 (-[WebSecurityOrigin initWithProtocol:domain:port:]):
715 (-[WebSecurityOrigin protocol]):
716 (-[WebSecurityOrigin domain]):
717 (-[WebSecurityOrigin port]):
718 (-[WebSecurityOrigin usage]):
719 (-[WebSecurityOrigin quota]):
720 (-[WebSecurityOrigin setQuota:]):
721 (-[WebSecurityOrigin isEqual:]):
722 (-[WebSecurityOrigin dealloc]):
723 (-[WebSecurityOrigin finalize]):
724 (-[WebSecurityOrigin _initWithWebCoreSecurityOrigin:]):
725 (-[WebSecurityOrigin _core]):
726 * Storage/WebSecurityOriginInternal.h:
727 * WebCoreSupport/WebChromeClient.h:
728 * WebCoreSupport/WebChromeClient.mm:
729 (WebChromeClient::requestQuotaIncreaseForNewDatabase):
730 (WebChromeClient::requestQuotaIncreaseForDatabaseOperation):
732 2008-01-10 Sam Weinig <sam@webkit.org>
734 Reviewed by Anders Carlsson.
736 Fixes: http://bugs.webkit.org/show_bug.cgi?id=16522
737 <rdar://problem/5657355>
739 * Plugins/WebBaseNetscapePluginView.mm:
740 (-[WebBaseNetscapePluginView loadPluginRequest:]): call findFrameForNavigation
741 to ensure the shouldAllowNavigation check is made.
743 2008-01-07 Nikolas Zimmermann <zimmermann@kde.org>
747 Enable SVG_FONTS by default.
749 * Configurations/WebKit.xcconfig:
751 2008-01-07 Adele Peterson <adele@apple.com>
753 Reviewed by Antti, Adam, and Mitz.
755 WebKit part of fix for
756 <rdar://problem/5619073> Updated look for <video> controls
757 <rdar://problem/5619057> Add volume control to video controls
759 * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
761 2008-01-07 Dan Bernstein <mitz@apple.com>
763 Reviewed by Dave Hyatt.
765 - <rdar://problem/5665216> Support the unicode-range property in @font-face rules
767 * Misc/WebNSAttributedStringExtras.mm:
769 2008-01-03 Alexey Proskuryakov <ap@webkit.org>
773 <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
775 * WebView/WebView.mm:
776 (-[WebView _executeCoreCommandByName:value:]):
777 * WebView/WebViewPrivate.h:
778 Added an SPI to implement layoutTestController.execCommand.
780 2008-01-03 Kevin Decker <kdecker@apple.com>
784 Fixed: <rdar://problem/4106190> Include "Where from" metadata in drag-and-dropped images
786 * Misc/WebNSFileManagerExtras.h:
787 * Misc/WebNSFileManagerExtras.m:
788 (-[NSFileManager _webkit_setMetadataURL:referrer:atPath:]): Added new method. Uses WebKitSystemInterface to set
789 "Where from:" metadata information.
790 * WebView/WebHTMLView.mm:
791 (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Added "Where from:" metadata for drag and dropped images.
793 2008-01-03 Alice Liu <alice.liu@apple.com>
797 This fixes pageup/down in iframes. test for this is fast/frames/iframe-scroll-page-up-down.html
799 * WebView/WebHTMLView.mm:
800 (-[WebHTMLView doCommandBySelector:]):
801 Have the editor handle all the commands it supports instead of just text commands.
802 If not handled by the editor, the webview will handle the command.
804 2008-01-02 Kevin Decker <kdecker@apple.com>
808 Fixed: <rdar://problem/5660603> QuickDraw plug-ins can cause a 100% reproducible assertion failure in AppKit (breaks Safari UI)
810 * Plugins/WebBaseNetscapePluginView.mm:
811 (-[WebBaseNetscapePluginView updateAndSetWindow]): Simplified an early return for non-QuickDraw plug-ins and switched
812 to using the more NSView friendly version of lockFocus, lockFocusIfCanDraw.
814 2008-01-01 David D. Kilzer <ddkilzer@webkit.org>
818 - fix http://bugs.webkit.org/show_bug.cgi?id=16700
819 Fix -[WebDefaultPolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]
821 * DefaultDelegates/WebDefaultPolicyDelegate.m: Check return value of
822 -[NSFileManager fileExistsAtPath:isDirectory:] before using the value
825 2007-12-29 Nikolas Zimmermann <zimmermann@kde.org>
829 Add DOMSVGFontElement/DOMSVGGlyphElement/DOMSVGMissingGlyphElement to MigrateHeaders.make
831 * MigrateHeaders.make:
833 2007-12-25 Dan Bernstein <mitz@apple.com>
835 Reviewed by Oliver Hunt.
837 - fix an assertion failure when pressing the num lock key
839 * WebView/WebHTMLView.mm:
840 (-[WebHTMLView flagsChanged:]): Avoid passing key code 10 down to
843 2007-12-20 Darin Adler <darin@apple.com>
847 - fix <rdar://problem/5658787> Selector -[WebView insertLineBreak:] is not implemented
849 * WebView/WebView.mm: Added all selectors implemented by WebHTMLView to the list of
850 selectors to forward here. The new ones are: changeBaseWritingDirection:, changeSpelling:,
851 deleteToMark:, insertLineBreak:, moveParagraphBackwardAndModifySelection:,
852 moveParagraphForwardAndModifySelection:, pageDownAndModifySelection:, pageUpAndModifySelection:,
853 selectToMark:, setMark:, swapWithMark:, takeFindStringFromSelection:, toggleBaseWritingDirection:,
856 2007-12-20 Kevin Decker <kdecker@apple.com>
860 Fixed: <rdar://problem/5638288> REGRESSION: Flash movies show up in other tabs above the page (16373)
862 * Plugins/WebBaseNetscapePluginView.mm:
863 (-[WebBaseNetscapePluginView updateAndSetWindow]): QuickDraw plug-ins must manually be told when to stop
864 writing to the window backing store. The problem was that change-set 28400 introduced an early return
865 which prevented this necessary operation. The fix is to limit the scope of the early return to CG and GL
866 plug-ins and to tweak the needsFocus check to prevent an exception from occurring in QuickDraw-based plug-ins.
868 2007-12-19 Geoffrey Garen <ggaren@apple.com>
870 Reviewed by Oliver Hunt.
874 * ForwardingHeaders/kjs/SymbolTable.h: Added.
875 * ForwardingHeaders/wtf/VectorTraits.h: Added.
877 2007-12-16 Mark Rowe <mrowe@apple.com>
879 Reviewed by Maciej Stachowiak.
881 Refactor Mac plugin stream code to use the shared NetscapePlugInStreamLoader implementation.
883 * Plugins/WebBaseNetscapePluginStream.h:
884 * Plugins/WebNetscapePluginStream.h:
885 * Plugins/WebNetscapePluginStream.mm:
886 (-[WebNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):
887 (-[WebNetscapePluginStream dealloc]):
888 (-[WebNetscapePluginStream finalize]):
889 * Plugins/WebPlugInStreamLoaderDelegate.h: Moved from WebCore.
890 * WebCoreSupport/WebNetscapePlugInStreamLoaderClient.h: Added.
891 (WebNetscapePlugInStreamLoaderClient::WebNetscapePlugInStreamLoaderClient):
892 * WebCoreSupport/WebNetscapePlugInStreamLoaderClient.mm: Added.
893 (WebNetscapePlugInStreamLoaderClient::didReceiveResponse): Call through to the equivalent WebPlugInStreamLoaderDelegate method.
894 (WebNetscapePlugInStreamLoaderClient::didReceiveData): Ditto.
895 (WebNetscapePlugInStreamLoaderClient::didFail): Ditto.
896 (WebNetscapePlugInStreamLoaderClient::didFinishLoading): Ditto.
898 2007-12-16 Alexey Proskuryakov <ap@webkit.org>
902 http://bugs.webkit.org/show_bug.cgi?id=14140
903 <rdar://problem/5270958> REGRESSION: Complex system KeyBindings don't work properly
905 * WebView/WebHTMLView.mm:
906 (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]): Made command replaying work
907 when handling keypress, too.
908 (-[WebHTMLView doCommandBySelector:]): Adapted for the new way to store commands in events.
909 (-[WebHTMLView insertText:]): Append a command, not replace the whole existing vector. Also,
910 restore the state for additional commands to be saved correctly.
912 2007-12-14 David D. Kilzer <ddkilzer@apple.com>
914 <rdar://problem/5647272> Remove user agent string hack for flickr.com
918 * WebView/WebView.mm:
919 (-[WebView _userAgentForURL:]): Removed hack.
921 2007-12-14 David D. Kilzer <ddkilzer@apple.com>
923 <rdar://problem/5647261> Remove user agent string hack for yahoo.com
927 * WebView/WebView.mm:
928 (-[WebView _userAgentForURL:]): Removed hack.
930 2007-12-14 Darin Adler <darin@apple.com>
934 - fix http://bugs.webkit.org/show_bug.cgi?id=16296
935 <rdar://problem/5635641> -[WebFrameLoadDelegate didReceiveIcon:forFrame:] never called
937 * WebView/WebView.mm:
938 (-[WebView setFrameLoadDelegate:]): Call [WebIconDatabase sharedIconDatabase] if the
939 a didReceiveIcon method is present.
941 2007-12-14 Darin Adler <darin@apple.com>
945 - Changed a few more editing operations to use WebCore instead of WebKit.
946 - Removed some obsolete unused code.
948 * WebCoreSupport/WebFrameBridge.h: Moved declarations of methods that are both
949 defined and used on the WebKit side to here. These no longer belong on the bridge
950 and should be moved to the WebFrame class (or elsewhere).
951 * WebCoreSupport/WebFrameBridge.mm: Removed some unused methods.
953 * WebView/WebFrameView.mm:
954 (+[WebFrameView _viewTypesAllowImageTypeOmission:]): Fix typo in comment.
956 * WebView/WebHTMLView.mm:
957 (-[WebHTMLViewPrivate dealloc]): Removed unused firstResponderTextViewAtMouseDownTime.
958 (-[WebHTMLViewPrivate clear]): Ditto.
959 (-[WebHTMLView _setMouseDownEvent:]): Ditto.
960 (commandNameForSelector): Added special cases for pageDown:, pageDownAndModifySelection:,
961 pageUp:, and pageUpAndModifySelection:, since those names probably aren't specific enough
962 to be used in WebCore (what AppKit calls scrollPageDown: vs. pageDown: needs to be
963 disambiguated with the word "Move"). Added deleteBackward:,
964 deleteBackwardByDecomposingPreviousCharacter:, deleteForward:, deleteToBeginningOfLine:,
965 deleteToBeginningOfParagraph:, deleteToEndOfLine:, deleteToEndOfParagraph:, pageDown:,
966 pageDownAndModifySelection:, pageUp:, pageUpAndModifySelection:, selectLine:,
967 selectParagraph:, selectSentence:, and selectWord: to the list of commands that are
968 forwarded to WebCore.
969 (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Eliminated the long list of
970 operations that we forward to WebCore. Instead, look up any command that WebCore can
971 handle, after any that we handle specially in WebHTMLView. Also fixed a bug where
972 an item that's not a menu item with changeBaseWritingDirection:NSWritingDirectionNatural
973 would end up enabled instead of disabled and streamlined the logic for toggleGrammarChecking:.
974 (-[WebHTMLView mouseDown:]): Removed unused firstResponderTextViewAtMouseDownTime.
975 (-[WebHTMLView becomeFirstResponder]): Removed unused willBecomeFirstResponderForNodeFocus.
976 (-[WebHTMLView resignFirstResponder]): Ditto.
977 (-[WebHTMLView checkSpelling:]): Took unneeded extra initialization of NSSpellChecker.
979 * WebView/WebHTMLViewInternal.h: Removed unused willBecomeFirstResponderForNodeFocus,
980 firstResponderTextViewAtMouseDownTime, _textViewWasFirstResponderAtMouseDownTime: and
981 _willMakeFirstResponderForNodeFocus.
983 2007-12-13 Alexey Proskuryakov <ap@webkit.org>
987 Turn on keyboard event processing quirks for feed views and old applications on Mac OS X.
989 * Misc/WebKitVersionChecks.h:
990 * WebView/WebView.mm:
991 (-[WebView _needsKeyboardEventHandlingQuirks]):
992 (-[WebView _preferencesChangedNotification:]):
994 2007-12-12 Brady Eidson <beidson@apple.com>
996 Reviewed by Sam Weinig
998 Fix for <rdar://problem/4886844> and lay groundwork for <rdar://problem/4516170> (Back/Forward Cache on Windows)
1000 * WebCoreSupport/WebCachedPagePlatformData.h: Added.
1001 (WebCachedPagePlatformData::WebCachedPagePlatformData): Constructor takes a WebDocumentView for later restoration
1002 (WebCachedPagePlatformData::clear):
1003 (WebCachedPagePlatformData::webDocumentView):
1005 * WebCoreSupport/WebFrameLoaderClient.h:
1006 * WebCoreSupport/WebFrameLoaderClient.mm:
1007 (WebFrameLoaderClient::savePlatformDataToCachedPage):
1008 (WebFrameLoaderClient::transitionToCommittedFromCachedPage): Don't set the DocumentLoader to the Frame here,
1009 because that is now done in WebCore.
1010 (WebFrameLoaderClient::transitionToCommittedForNewPage):
1012 2007-12-12 Mark Rowe <mrowe@apple.com>
1014 Reviewed by Dave Kilzer.
1016 Remove abuse of projectDirPath from WebKit.xcodeproj to fix Production builds.
1018 * Configurations/WebKit.xcconfig:
1020 2007-12-11 Sam Weinig <sam@webkit.org>
1022 Reviewed by Darin Adler.
1024 Scrub URL out of the tree in preparation for renaming KURL to URL.
1026 * WebCoreSupport/WebFrameLoaderClient.mm:
1027 (WebFrameLoaderClient::actionDictionary):
1028 * WebView/WebDataSource.mm:
1029 (-[WebDataSource _URL]):
1030 * WebView/WebView.mm:
1031 (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
1033 2007-12-11 Darin Adler <darin@apple.com>
1037 - change more editing commands to use WebCore::Editor
1038 - change to use the new WebCore::Editor::command() function
1040 * WebView/WebHTMLView.mm: Changed alignCenter, alignJustified, alignLeft,
1041 alignRight, cut, copy, deleteToMark, indent, insertNewlineIgnoringFieldEditor,
1042 insertTabIgnoringFieldEditor, outdent, selectAll, selectToMark, setMark,
1043 subscript, superscript, swapWithMark, underline, unscript, yank, and yankAndSelect
1044 to use the "forward to WebCore" macro instead of having hand-written implementations.
1045 (kit): Added function to change a TriState to an AppKit-style tri-state value.
1046 (-[WebHTMLView coreCommandBySelector:]): Added. No longer converts case of the
1047 first character or copies the selector name, since the Editor commands are not case
1048 sensitive any more. Returns a command object.
1049 (-[WebHTMLView coreCommandByName:]): Added.
1050 (-[WebHTMLView executeCoreCommandBySelector:]): Renamed from callWebCoreCommand:,
1051 and changed to use the new coreCommandBySelector: method.
1052 (-[WebHTMLView executeCoreCommandByName:]): Added.
1053 (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Changed all the
1054 methods that call through to WebCore to also use the state() and isEnabled()
1055 functions on the commands for the menu item state and user interface item enabling.
1056 (-[WebHTMLView _handleStyleKeyEquivalent:]): Use ToggleBold and ToggleItalic by
1057 name rather than having local methods for them; no need for methods with a single
1059 (-[WebHTMLView insertParagraphSeparator:]): Use executeCoreCommandByName: rather
1060 than the deprecated execCommand().
1061 (-[WebHTMLView doCommandBySelector:]): Changed to use command().execute() rather
1062 than the deprecated execCommand().
1063 * WebView/WebHTMLViewInternal.h: Removed some unneeded method declarations.
1065 2007-12-07 Alexey Proskuryakov <ap@webkit.org>
1069 <rdar://problem/5535636>
1070 Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
1072 http://bugs.webkit.org/show_bug.cgi?id=13916
1073 JavaScript detects Tab as a character input on a textfield validation
1075 * WebCoreSupport/WebEditorClient.h:
1076 Renamed handleKeypress() to handleKeyboardEvent(), as it gets both keydowns and keypresses.
1077 Renamed handleInputMethodKeypress() to handleInputMethodKeydown().
1078 * WebCoreSupport/WebEditorClient.mm:
1079 (WebEditorClient::handleKeyboardEvent): This change makes sense only remotely, but it helped
1080 to get tests working. I guess Mac keyboard event handling needs further refactoring.
1082 * WebView/WebHTMLView.mm:
1083 (selectorToCommandName): Convert AppKit editing selector name to Editor command name - extracted
1084 from callWebCoreCommand:.
1085 (_interceptEditingKeyEvent:shouldSaveCommand:): Insert text from keypress.
1087 * WebView/WebPDFView.mm:
1088 (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1089 Convert incoming platform KeyDown into RawKeyDown, as this is what the view is interested in.
1091 2007-12-10 Brady Eidson <beidson@apple.com>
1093 Reviewed by John Sullivan
1095 Fix for <rdar://problem/5640080> - Database UI delegate calls need to specify WebFrame
1097 This is because a common UI case is to want to know the originating URL of a Database
1099 * WebCoreSupport/WebChromeClient.mm:
1100 (WebChromeClient::requestQuotaIncreaseForNewDatabase):
1101 (WebChromeClient::requestQuotaIncreaseForDatabaseOperation):
1103 * WebView/WebUIDelegatePrivate.h:
1105 * WebView/WebView.mm:
1106 (CallDelegateReturningUnsignedLongLong):
1107 (CallUIDelegateReturningUnsignedLongLong):
1108 * WebView/WebViewInternal.h:
1110 2007-12-10 Timothy Hatcher <timothy@apple.com>
1112 Reviewed by Mark Rowe.
1114 <rdar://problem/5639463> Bundle versions on Tiger should be 4523.x not 523.x
1116 * Configurations/Version.xcconfig: Some Tiger versions of Xcode don't set MAC_OS_X_VERSION_MAJOR,
1117 so assume Tiger and use a 4 for the SYSTEM_VERSION_PREFIX.
1119 2007-12-10 Kevin Decker <kdecker@apple.com>
1123 Fixed: <rdar://problem/4290098> Right-mouse click on element doesn't call onmousedown handler
1125 * WebView/WebHTMLView.mm:
1126 (-[WebHTMLView menuForEvent:]): Match behavior of other browsers by sending an onmousedown event for right clicks.
1128 2007-12-08 Oliver Hunt <oliver@apple.com>
1132 Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
1134 Fixes <rdar://problem/5620249> Must disable SVG animation
1135 <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
1137 Minor updates to the feature flags used.
1139 * Configurations/WebKit.xcconfig:
1140 * DOM/WebDOMOperations.mm:
1142 2007-12-07 Darin Adler <darin@apple.com>
1144 Reviewed by Kevin Decker and Tim Hatcher.
1146 - speculative fix for <rdar://problem/5400159> CrashTracer: [USER] 726 crashes
1147 in Safari at com.apple.WebKit: -[WebHTMLView(WebPrivate) _updateMouseoverWithFakeEvent] + 389
1149 * WebView/WebHTMLView.mm:
1150 (-[WebHTMLView _frameOrBoundsChanged]): Only schedule the mouseover timer if we are in a window
1151 and not closed. That's because viewDidMoveToWindow and close are the entry points for cancelling.
1152 (-[WebHTMLView close]): Add code to cancel both timers. Needed for the case where the entire
1153 window goes away, and the view is never removed from the window.
1154 (-[WebHTMLView viewDidMoveToWindow]): Don't do work if the view is closed.
1156 2007-12-07 Darin Adler <darin@apple.com>
1160 - http://bugs.webkit.org/show_bug.cgi?id=15981
1161 speed up visited-link code a bit
1163 * History/WebHistory.mm: Removed unused Latin-1 code path.
1164 (-[_WebCoreHistoryProvider containsURL:length:]): Updated for method name change.
1166 2007-12-07 Geoffrey Garen <ggaren@apple.com>
1168 Reviewed by Sam Weinig.
1170 Added a forwarding header, since we now #include nodes.h through some
1171 JavaScriptCore headers.
1173 * ForwardingHeaders/wtf/ListRefPtr.h: Added.
1175 2007-12-06 Brady Eidson <beidson@apple.com>
1177 Reviewed by Oliver's rubber stamp
1179 Let's go ahead and call the correct UI Delegate method, shall we?
1181 * WebCoreSupport/WebChromeClient.mm:
1182 (WebChromeClient::requestQuotaIncreaseForDatabaseOperation): Call the correct UI delegate
1184 2007-12-06 Adam Roben <aroben@apple.com>
1186 Remove some assertions we know can fire and replace them with a FIXME
1190 * WebCoreSupport/WebFrameLoaderClient.mm:
1192 2007-12-06 Timothy Hatcher <timothy@apple.com>
1194 Change the ASSERT added for the previous fix. The ASSERT was firing for 10.5.0.
1195 Only assert if the major version is zero, since zero is handled in the other cases.
1197 * WebView/WebView.mm:
1198 (callGestalt): Remove the ASSERT.
1199 (createMacOSXVersionString): ASSERT that major is not zero.
1201 2007-12-06 Darin Adler <darin@apple.com>
1203 Reviewed by Tim Hatcher.
1205 - fix <rdar://problem/5513394> No way to detect Tiger vs Leopard from Safari's user agent string
1207 * WebView/WebView.mm:
1208 (callGestalt): Added.
1209 (createMacOSXVersionString): Added.
1210 (-[WebView _userAgentWithApplicationName:andWebKitVersion:]): Added Mac OS X version string,
1211 right after the string "Mac OS X", but with underscores instead of dots to avoid the dreaded
1212 "4." problem (old libraries that think a "4." anywhere in the user agent means Netscape 4).
1213 (-[WebView _userAgentForURL:]): Fixed incorrect bug numbers.
1215 2007-12-04 Geoffrey Garen <ggaren@apple.com>
1217 Reviewed by Darin Adler.
1219 Third step in refactoring JSGlobalObject: Moved data members and data
1220 member access from Interpreter to JSGlobalObject.
1222 * WebView/WebFrame.mm:
1223 (-[WebFrame _attachScriptDebugger]):
1225 2007-12-04 Kevin McCullough <kmccullough@apple.com>
1230 - Security Fix. Instead of having it off by default, WebKit now must
1231 explicitly turn off local-resource restriction when needed for backwards
1232 coimpatibility reasons.
1234 * WebView/WebView.mm:
1235 (-[WebView _commonInitializationWithFrameName:groupName:]):
1237 2007-12-05 Brady Eidson <beidson@apple.com>
1239 Reviewed by Kevin Deckers rubberstamp
1241 Disclose and export the Databases Directory defaults key
1243 * Storage/WebDatabaseManager.mm:
1244 * Storage/WebDatabaseManagerPrivate.h:
1247 2007-12-04 Kevin Decker <kdecker@apple.com>
1251 <rdar://problem/5629125> PluginInfoStore needs the ability to return the name of a plug-in for a given MIME type
1253 * WebCoreSupport/WebViewFactory.mm:
1254 (-[WebViewFactory pluginNameForMIMEType:]): Added.
1256 2007-12-04 Brady Eidson <beidson@apple.com>
1258 Reviewed by Mark Rowe
1260 Tweaked the way we typedef and cast these objc_msgSend calls
1262 * WebView/WebView.mm:
1263 (CallDelegateReturningUnsignedLongLong):
1265 2007-12-04 John Sullivan <sullivan@apple.com>
1267 Reviewed by Brady Eidson (with help from Mark Rowe)
1269 Fixed return values for unsigned-long-long delegate methods
1271 * WebView/WebView.mm:
1272 (CallDelegateReturningUnsignedLongLong):
1273 redid the change that Brady did at home over the weekend but forgot to check in
1275 2007-11-27 Adam Roben <aroben@apple.com>
1277 Remove -[WebFrameBridge setNeedsReapplyStyles]
1279 This functionality is now WebCore's responsibility.
1283 * WebCoreSupport/WebFrameBridge.mm:
1286 2007-12-04 John Sullivan <sullivan@apple.com>
1290 Added deleteOrigin: SPI, which isn't fully implemented
1292 * Storage/WebDatabaseManagerPrivate.h:
1293 * Storage/WebDatabaseManager.mm:
1294 (-[WebDatabaseManager deleteOrigin:]):
1295 just calls deleteDatabasesWithOrigin: for now, but needs to delete origin itself too
1297 2007-12-04 Timothy Hatcher <timothy@apple.com>
1299 Reviewed by Mark Rowe.
1301 Remove a check for early versions of Leopard CFNetwork now that
1302 Leopard has shipped.
1304 * Misc/WebKitVersionChecks.h: Remove WEBKIT_FIRST_CFNETWORK_VERSION_WITH_LARGE_DISK_CACHE_FIX.
1305 * WebView/WebView.mm:
1306 (+[WebView _setCacheModel:]): Remove the early Leopard CFNetwork check.
1308 2007-12-04 Kevin Decker <kdecker@apple.com>
1312 Revised fix for: <rdar://problem/5586978> REGRESSION (Safari 2-3): WebKit sometimes doesn't invoke Flash's NPP_SetWindow function and causes a hang
1314 This fix is exactly the same as chageset 28359 with the exception of an added early return in
1315 updateAndSetWindow to cover the additional case of when a plug-in isn't drawable.
1317 The CG-based Flash player would sometimes hang because (for CoreGraphics-based plug-ins) our code would
1318 only call into the NPP_SetWindow() function when we tell the plug-in to draw. This created havoc with
1319 Flash because Flash expects the browser to call NPP_SetWindow() and provide a valid graphics context
1320 regardless of whether or not it actually needs to draw.
1322 * Plugins/WebBaseNetscapePluginView.mm:
1323 (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Removed an incorrect comment and toned
1324 down an ASSERT that was too strict.
1325 (-[WebBaseNetscapePluginView updateAndSetWindow]): Removed an early return for CoreGraphics-based plug-ins
1326 which would sometimes altogether prevent updating the PortState and calling into a plug-ins NPP_SetWindow()
1327 function. Also tweaked a comment and added an early return if the plug-in can't draw.
1329 2007-12-04 Darin Adler <darin@apple.com>
1331 Reviewed by Kevin Decker.
1333 * WebCoreSupport/WebFrameLoaderClient.h: Removed obsolete privateBrowsingEnabled.
1334 * WebCoreSupport/WebFrameLoaderClient.mm: Ditto.
1335 * WebKit.order: Ditto.
1337 2007-12-03 Dan Bernstein <mitz@apple.com>
1339 Reviewed by Dave Hyatt.
1341 - fix <rdar://problem/5346452> Resize event doesn't fire on body element inside a frame
1343 * WebView/WebHTMLView.mm:
1344 (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Removed the code
1345 that checked if the view had resized and sent the resize event, since
1346 FrameView sends resize events now.
1347 * WebView/WebHTMLViewInternal.h:
1349 2007-12-03 Timothy Hatcher <timothy@apple.com>
1353 Change WebViewGetResourceLoadDelegateImplementations and WebViewGetFrameLoadDelegateImplementations
1354 to return a pointer to the implementation struct instead of a copy of the struct. This changes
1355 all of the callers to dereference the pointer to access the struct fields.
1357 * Plugins/WebNullPluginView.mm:
1358 (-[WebNullPluginView reportFailure]):
1359 * WebCoreSupport/WebFrameBridge.mm:
1360 * WebCoreSupport/WebFrameLoaderClient.mm:
1361 (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
1362 (WebFrameLoaderClient::assignIdentifierToInitialRequest):
1363 (WebFrameLoaderClient::dispatchWillSendRequest):
1364 (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
1365 (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
1366 (WebFrameLoaderClient::dispatchDidReceiveResponse):
1367 (WebFrameLoaderClient::willCacheResponse):
1368 (WebFrameLoaderClient::dispatchDidReceiveContentLength):
1369 (WebFrameLoaderClient::dispatchDidFinishLoading):
1370 (WebFrameLoaderClient::dispatchDidFailLoading):
1371 (WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
1372 (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
1373 (WebFrameLoaderClient::dispatchDidCancelClientRedirect):
1374 (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1375 (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
1376 (WebFrameLoaderClient::dispatchWillClose):
1377 (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1378 (WebFrameLoaderClient::dispatchDidReceiveTitle):
1379 (WebFrameLoaderClient::dispatchDidCommitLoad):
1380 (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
1381 (WebFrameLoaderClient::dispatchDidFailLoad):
1382 (WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
1383 (WebFrameLoaderClient::dispatchDidFinishLoad):
1384 (WebFrameLoaderClient::dispatchDidFirstLayout):
1385 * WebView/WebView.mm:
1386 (WebViewGetResourceLoadDelegateImplementations):
1387 (WebViewGetFrameLoadDelegateImplementations):
1388 (-[WebView _dispatchDidReceiveIconFromWebFrame:]):
1389 * WebView/WebViewInternal.h:
1391 2007-12-03 Timothy Hatcher <timothy@apple.com>
1393 Reviewed by Brady Eidson.
1395 <rdar://problem/5539913> 188 crashes in WebViewGetFrameLoadDelegateImplementations
1396 <rdar://problem/5586095> CrashTracer: [USER] 5000+ crashes in Safari and Dashboard in dispatchDidFailLoading
1397 <rdar://problem/5607081> CrashTracer: [USER] 2150 crashes in Safari at com.apple.WebKit:
1398 WebViewGetResourceLoadDelegateImplementations + 28
1400 * WebView/WebView.mm:
1401 (-[WebView _cacheResourceLoadDelegateImplementations]): If the delegate is nil, bzero the
1402 implementation cache. This just prevents us from calling getMethod() multiple times just to zero.
1403 (-[WebView _cacheFrameLoadDelegateImplementations]): Ditto.
1404 (WebViewGetResourceLoadDelegateImplementations): Return a zeroed implementations struct
1405 if the WebView is nil. This fixes the crashes.
1406 (WebViewGetFrameLoadDelegateImplementations): Ditto.
1408 2007-12-02 Geoffrey Garen <ggaren@apple.com>
1410 Reviewed by Eric Seidel.
1412 Updated to match the JavaScriptCore change to move virtual methods from
1413 Interpreter to JSGlobalObject.
1415 * WebView/WebFrame.mm:
1416 (-[WebFrame globalContext]): Use the toRef function instead of manually
1419 2007-12-01 Brady Eidson <beidson@apple.com>
1423 Added a default database quota of 5mb to the default WebPreferences
1425 * WebView/WebPreferences.m:
1426 (+[WebPreferences initialize]):
1428 2007-11-30 John Sullivan <sullivan@apple.com>
1430 Reviewed by Geoff Garen
1432 Added another symbol for WebDatabaseManager clients
1435 added .objc_class_name_WebSecurityOrigin
1437 2007-11-30 Brady Eidson <beidson@apple.com>
1441 Add isEqual operator to WebSecurityOrigin
1443 * Storage/WebSecurityOrigin.mm:
1444 (-[WebSecurityOrigin isEqual:]):
1446 2007-11-30 John Sullivan <sullivan@apple.com>
1450 Tweaks to newly-declared NSString * constants to make them usable from clients
1452 * Storage/WebDatabaseManagerPrivate.h:
1453 * Storage/WebDatabaseManager.mm:
1454 removed "const" from new NSNotification names and userInfo keys; these generate compiler warnings when used
1457 export new NSNotification names and userInfo keys so clients can use them
1459 2007-11-29 Anders Carlsson <andersca@apple.com>
1463 Rename WebKitShrinksStandaloneImagesToFitKey to WebKitShrinksStandaloneImagesToFit.
1465 This is safe to do because the preference is off by default and Safari 3, which is the only client that turns it on,
1466 is using the setter and not messing around with NSUserDefaults.
1468 * WebView/WebPreferenceKeysPrivate.h:
1469 * WebView/WebPreferences.m:
1470 (+[WebPreferences initialize]):
1471 (-[WebPreferences shrinksStandaloneImagesToFit]):
1472 (-[WebPreferences setShrinksStandaloneImagesToFit:]):
1474 2007-11-29 Brady Eidson <beidson@apple.com>
1478 Support for <rdar://problem/5556381> and <rdar://problem/5556379>
1480 Hook up UI Delegate calls for the database engine feature and other small tweaks
1482 * Storage/WebDatabaseManager.mm:
1483 (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Renamed databaseName parameter to databaseIdentifier for clarity
1484 (-[WebDatabaseManager deleteDatabase:withOrigin:]): Renamed databaseName parameter to databaseIdentifier for clarity
1485 * Storage/WebDatabaseManagerPrivate.h:
1487 * Storage/WebDatabaseTrackerClient.h:
1488 * Storage/WebDatabaseTrackerClient.mm:
1489 (WebDatabaseTrackerClient::dispatchDidModifyDatabase): Renamed databaseName parameter to databaseIdentifier for clarity
1491 * WebCoreSupport/WebChromeClient.h:
1492 * WebCoreSupport/WebChromeClient.mm:
1493 (WebChromeClient::requestQuotaIncreaseForNewDatabase): Call through to the UI Delegate
1494 (WebChromeClient::requestQuotaIncreaseForDatabaseOperation): Ditto
1496 * WebView/WebUIDelegatePrivate.h: Added the two UI Delegate methods
1498 * WebView/WebView.mm:
1499 (CallDelegateReturningUnsignedLongLong):
1500 (CallUIDelegateReturningUnsignedLongLong):
1501 * WebView/WebViewInternal.h:
1503 2007-11-28 Kevin McCullough <kmccullough@apple.com>
1507 - Added recursive runloop guards.
1509 * DefaultDelegates/WebScriptDebugServer.m:
1510 (-[WebScriptDebugServer suspendProcessIfPaused]):
1512 2007-11-29 Mark Rowe <mrowe@apple.com>
1514 Reviewed by Oliver Hunt.
1516 Fix an assertion failure seen on the layout tests, and when closing the window after
1517 visiting <http://www.coudal.com/losalamos/>.
1519 * Plugins/WebBaseNetscapePluginStream.mm:
1520 (-[WebBaseNetscapePluginStream _destroyStream]): Unlink the file and close the file
1521 descriptor even when the stream is being destroyed without the load completing. This
1522 avoids leaking the path and file descriptor, and leaving the temporary file on disk.
1524 2007-11-28 Adele Peterson <adele@apple.com>
1528 Fix for <rdar://problem/5524216> CrashTracer: [USER] 496 crashes in Safari at com.apple.WebCore: WebCore::Frame::eventHandler const + 6
1530 The CrashTracer shows a variety of crashes in different methods (including keyDown and keyUp). This change adds nil checks for the frame in
1531 WebHTMLView to prevent future problems in other methods as well.
1533 * WebView/WebHTMLView.mm:
1534 (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
1535 (-[WebHTMLView keyDown:]):
1536 (-[WebHTMLView keyUp:]):
1537 (-[WebHTMLView flagsChanged:]):
1538 (-[WebHTMLView _selectionStartFontAttributesAsRTF]):
1539 (-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
1540 (-[WebHTMLView checkSpelling:]):
1541 (-[WebHTMLView showGuessPanel:]):
1542 (-[WebHTMLView indent:]):
1543 (-[WebHTMLView outdent:]):
1544 (-[WebHTMLView paste:]):
1545 (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
1546 (-[WebHTMLView insertText:]):
1547 (-[WebHTMLView selectionTextRects]):
1549 2007-11-28 Dan Bernstein <mitz@apple.com>
1551 Reviewed by Maciej Stachowiak.
1553 - fix <rdar://problem/5596160> fast/events/objc-event-api.html fails when run alone (or first)
1555 * WebView/WebHTMLView.mm:
1556 (-[WebHTMLView setDataSource:]): This method calls addMouseMovedObserver
1557 because addMouseMovedObserver returns early if the dataSource
1558 is not nil. But if the dataSource is already set (which happens when
1559 a WebHTMLView is being reused) then addMouseMovedObserver must not
1562 2007-11-27 Anders Carlsson <andersca@apple.com>
1566 * Storage/WebDatabaseManager.mm:
1567 * Storage/WebDatabaseManagerPrivate.h:
1568 * Storage/WebDatabaseTrackerClient.mm:
1569 (WebDatabaseTrackerClient::dispatchDidModifyOrigin):
1570 (WebDatabaseTrackerClient::dispatchDidModifyDatabase):
1571 * Storage/WebSecurityOrigin.mm:
1572 (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]):
1573 * Storage/WebSecurityOriginInternal.h:
1575 2007-11-27 Kevin Decker <kdecker@apple.com>
1577 Reviewed by Darin, landed by Anders.
1579 Fixed: <rdar://problem/4610818> CrashTracer: 1533 crashes in Safari at com.macromedia.Flash Player.plugin: native_ShockwaveFlash_TCallLabel + 271131
1581 The problem was that some Leopard users were still inadvertently using the old Flash 8 plug-in, even though Leopard
1582 shipped with Flash 9. To avoid loading an older version of a plug-in when a newer version is installed, the plug-in
1583 database will compare bundle versions and always load the latest version.
1585 * Plugins/WebBasePluginPackage.h:
1586 * Plugins/WebBasePluginPackage.m:
1587 (-[WebBasePluginPackage versionNumber]): New method. CFBundleGetVersionNumber doesn't work with all possible versioning schemes,
1588 but we think for now it's good enough for us.
1589 * Plugins/WebPluginDatabase.m:
1590 (considerCandidate): Added a C utility function which compares the current plug-in against a candidate plug-in's version number.
1591 If both plug-ins have the same bundle ID and the candiate is newer, the current plug-in becomes the candidate.
1592 (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]): Calls the new considerCandidate() function.
1594 2007-11-26 Timothy Hatcher <timothy@apple.com>
1596 Reviewed by Dave Hyatt.
1598 <rdar://problem/5569233> Add the ability to disable author and user CSS styles
1600 * WebView/WebPreferenceKeysPrivate.h: Define WebKitRespectStandardStyleKeyEquivalentsPreferenceKey.
1601 * WebView/WebPreferences.m:
1602 (+[WebPreferences initialize]): Default WebKitRespectStandardStyleKeyEquivalentsPreferenceKey to YES.
1603 (-[WebPreferences authorAndUserStylesEnabled]): Return the setting's BOOL value.
1604 (-[WebPreferences setAuthorAndUserStylesEnabled:]): Set the setting's BOOL value.
1605 * WebView/WebPreferencesPrivate.h: Add authorAndUserStylesEnabled and setAuthorAndUserStylesEnabled:.
1606 * WebView/WebView.mm:
1607 (-[WebView _preferencesChangedNotification:]): Update WebCore::Settings::authorAndUserStylesEnabled.
1609 2007-11-26 Brady Eidson <beidson@apple.com>
1611 Reviewed by Mark Rowe
1613 Provide API for setting the default storage quota per database origin
1615 * Misc/WebNSDictionaryExtras.h:
1616 * Misc/WebNSDictionaryExtras.m:
1617 (-[NSMutableDictionary _webkit_setUnsignedLongLong:forKey:]): Helper for UINT64 preferences
1619 * WebView/WebPreferenceKeysPrivate.h:
1620 * WebView/WebPreferences.m:
1621 (-[WebPreferences _unsignedLongLongValueForKey:]): Helper for UINT64 prefs
1622 (-[WebPreferences _setUnsignedLongLongValue:forKey:]): Ditto
1623 (-[WebPreferences defaultDatabaseQuota]):
1624 (-[WebPreferences setDefaultDatabaseQuota:]):
1625 * WebView/WebPreferencesPrivate.h:
1627 * WebView/WebView.mm:
1628 (-[WebView _preferencesChangedNotification:]): Set the WebCore Settings version of the default storage pref
1630 2007-11-26 Darin Adler <darin@apple.com>
1634 - some middle-mouse-button-related fixes
1636 These don't affect Safari since it maps the middle mouse button to the command key,
1637 but that might not always be the case for future versions.
1639 * WebView/WebHTMLView.mm:
1640 (-[WebHTMLView otherMouseDown:]): Pass through middle mouse down events to WebCore.
1641 (-[WebHTMLView otherMouseDragged:]): Ditto, for drag events.
1642 (-[WebHTMLView otherMouseUp:]): Ditto, for up events.
1644 * WebView/WebPolicyDelegate.h: Fixed inaccurate documentation of WebActionButtonKey.
1646 2007-11-26 Anders Carlsson <andersca@apple.com>
1650 Get rid of the WebSecurityOriginPrivate object and store
1651 the WebCore::SecurityOriginData pointer in the _private field of
1652 the WebSecurityOrigin object instead.
1654 * Storage/WebDatabaseManager.mm:
1655 (-[WebDatabaseManager databasesWithOrigin:]):
1656 (-[WebDatabaseManager detailsForDatabase:withOrigin:]):
1657 (-[WebDatabaseManager deleteDatabasesWithOrigin:]):
1658 (-[WebDatabaseManager deleteDatabase:withOrigin:]):
1659 * Storage/WebSecurityOrigin.mm:
1660 (-[WebSecurityOrigin initWithProtocol:domain:port:]):
1661 (-[WebSecurityOrigin protocol]):
1662 (-[WebSecurityOrigin domain]):
1663 (-[WebSecurityOrigin port]):
1664 (-[WebSecurityOrigin usage]):
1665 (-[WebSecurityOrigin quota]):
1666 (-[WebSecurityOrigin setQuota:]):
1667 (-[WebSecurityOrigin dealloc]):
1668 (-[WebSecurityOrigin finalize]):
1669 (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]):
1670 (-[WebSecurityOrigin _core]):
1671 * Storage/WebSecurityOriginInternal.h:
1673 2007-11-26 Timothy Hatcher <timothy@apple.com>
1675 Reviewed by Adam Roben.
1677 Bug 16137: Web Inspector window on Leopard should have a unified toolbar and window title
1678 http://bugs.webkit.org/show_bug.cgi?id=16137
1680 Create the Web Inspector window with the textured style. Set the content border
1681 thickness for the top of the window or the height of the toolbar. Also make the
1682 window's bottom corners square, since a normal textured window normally has
1683 rounded bottom corners.
1685 * WebCoreSupport/WebInspectorClient.mm:
1686 (-[WebInspectorWindowController window]):
1688 2007-11-24 Mark Rowe <mrowe@apple.com>
1692 * Plugins/WebBaseNetscapePluginStream.mm:
1693 (CarbonPathFromPOSIXPath): Use WebCFAutorelease as this also works on Tiger.
1695 2007-11-24 Mark Rowe <mrowe@apple.com>
1697 Reviewed by Tim Hatcher.
1699 Fix <rdar://problem/5432686> 333MB RPRVT seems to leak @ www.43folders.com (1hr plug-in stream).
1700 http://bugs.webkit.org/show_bug.cgi?id=13705
1702 Have NP_ASFILE and NP_ASFILEONLY streams write the data to disk as they receive it rather than
1703 dumping the data to disk in a single go when the stream has completed loading. On a test case
1704 involving a 150MB Flash movie being streamed from a local web server this reduces memory consumption
1705 on page load from around 400MB to 22MB.
1707 The only plugin I have found that uses NP_ASFILE or NP_ASFILEONLY on the Mac is our NetscapeMoviePlugin
1708 example code so the NP_ASFILE portion of this change has not had any testing with a real-world plugin.
1710 * Plugins/WebBaseNetscapePluginStream.h:
1711 * Plugins/WebBaseNetscapePluginStream.mm:
1712 (-[WebBaseNetscapePluginStream initWithRequestURL:plugin:notifyData:sendNotification:]):
1713 (-[WebBaseNetscapePluginStream dealloc]):
1714 (-[WebBaseNetscapePluginStream finalize]):
1715 (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]):
1716 (-[WebBaseNetscapePluginStream _destroyStream]): Update to work with paths as NSStrings.
1717 (-[WebBaseNetscapePluginStream _deliverDataToFile:]): Open the file if it is not already open, and write any data
1719 (-[WebBaseNetscapePluginStream finishedLoading]): If the stream is NP_ASFILE or NP_ASFILEONLY we need to ensure
1720 that the file exists before _destroyStream passes it to the plugin. Simulating the arrival of an empty data block
1721 ensure that the file will be created if it has not already.
1722 (-[WebBaseNetscapePluginStream receivedData:]):
1723 (CarbonPathFromPOSIXPath):
1724 * Plugins/WebBaseNetscapePluginView.mm:
1725 (-[WebBaseNetscapePluginView pluginViewFinishedLoading:]): Data is dealt with incrementally so there's no need to pass
1726 it to finishedLoading.
1727 (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Ditto.
1729 2007-11-23 Oliver Hunt <oliver@apple.com>
1731 Reviewed by Mark Rowe.
1733 Fixed <rdar://problem/3759190> allow input methods the option of processing mouse events themselves
1735 * WebView/WebHTMLView.mm:
1736 (-[WebHTMLView mouseDown:]):
1738 2007-11-22 Dan Bernstein <mitz@apple.com>
1740 Reviewed by Antti Koivisto.
1742 - http://bugs.webkit.org/show_bug.cgi?id=15811
1743 WebKit plug-ins can re-enter WebKit under attach()
1744 <rdar://problem/5577978>
1746 * Plugins/WebNullPluginView.mm:
1747 (-[WebNullPluginView viewDidMoveToWindow]): Removed workaround for the
1748 above bug that added as part of fixing
1749 <http://bugs.webkit.org/show_bug.cgi?id=15804>.
1751 2007-11-21 Mark Rowe <mrowe@apple.com>
1755 Fix WebKit to build without warnings under GCC 4.2.
1757 * Configurations/Base.xcconfig:
1759 2007-11-21 Mark Rowe <mrowe@apple.com>
1761 Reviewed by Tim Hatcher.
1763 Changes due to <rdar://problem/5602936> Need to resolve new GCC 4.2 warnings
1765 Update format strings to use format specifiers that match the argument types.
1767 * Misc/WebGraphicsExtras.c:
1768 (WebConvertBGRAToARGB):
1770 2007-11-19 Brady Eidson <beidson@apple.com>
1774 Finished hooking up the WebKit API for database management.
1775 Most of the API is actually implemented in WebCore and some of those methods might
1776 only be stubs for now.
1778 * Storage/WebDatabaseManager.mm:
1779 (-[WebDatabaseManager origins]): Call through to the WebCore tracker and construct an API result
1780 (-[WebDatabaseManager databasesWithOrigin:]): Ditto
1781 (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Ditto
1783 * Storage/WebSecurityOrigin.mm:
1784 (-[WebSecurityOrigin usage]): Call through to WebCore
1785 (-[WebSecurityOrigin quota]): Ditto
1786 (-[WebSecurityOrigin setQuota:]): Ditto
1787 (-[WebSecurityOrigin _core]): Get WebCore version of this object
1788 * Storage/WebSecurityOriginInternal.h:
1790 2007-11-17 Timothy Hatcher <timothy@apple.com>
1792 Reviewed by Mark Rowe.
1794 Bug 13470: i18n: The Web Inspector is not localizable
1795 http://bugs.webkit.org/show_bug.cgi?id=13470
1797 Implement the localizedStringsURL() client method to return the
1798 localized URL of InspectorLocalizedStrings.js in WebCore.
1800 * WebCoreSupport/WebInspectorClient.h: Added localizedStringsURL.
1801 * WebCoreSupport/WebInspectorClient.mm:
1802 (WebInspectorClient::localizedStringsURL): Added.
1803 (WebInspectorClient::updateWindowTitle): Localized the window title.
1804 (-[WebInspectorWindowController init]): Remove a FIXME that dosen't make sense anymore.
1805 (-[WebInspectorWindowController initWithInspectedWebView:]): Code style cleanup.
1807 2007-11-17 Alexey Proskuryakov <ap@webkit.org>
1811 http://bugs.webkit.org/show_bug.cgi?id=15969
1812 Eliminate Editor::deleteRange()
1814 * WebView/WebHTMLView.mm:
1815 (+[WebHTMLView initialize]):
1816 (-[WebHTMLView yank:]):
1817 (-[WebHTMLView yankAndSelect:]):
1818 (-[WebHTMLView setMark:]):
1819 (-[WebHTMLView deleteToMark:]):
1820 (-[WebHTMLView selectToMark:]):
1821 (-[WebHTMLView swapWithMark:]):
1822 Pushed all kill ring methods to WebCore. They were guilty of using Editor::deleteRange()!
1824 2007-11-16 Mark Rowe <mrowe@apple.com>
1826 Reviewed by Tim Hatcher.
1828 Build WebCore as a sub-framework of WebKit in all configurations.
1830 * Configurations/WebKit.xcconfig:
1832 2007-11-16 John Sullivan <sullivan@apple.com>
1837 Exported some new database-related symbols
1839 2007-11-16 Brady Eidson <beidson@apple.com>
1843 Database management API tweaks
1845 Fleshed out "WebSecurityOrigin" to be the API object representing an origin. This relieves some
1846 burden off WebDatabaseManager and allows usage/quota operations on the SecurityOrigin object itself
1848 Also added a new subdirectory for Storage related API - Why are we afraid to add new directories to
1851 * Misc/WebSecurityOrigin.mm: Removed.
1852 * Misc/WebSecurityOriginInternal.h: Removed.
1853 * Misc/WebSecurityOriginPrivate.h: Removed.
1855 * Storage/WebDatabaseManager.mm: Work in terms of WebSecurityOrigin
1856 * Storage/WebDatabaseManagerPrivate.h:
1858 * Storage/WebSecurityOrigin.mm: Added.
1859 (-[WebSecurityOriginPrivate initWithProtocol:domain:port:]):
1860 (-[WebSecurityOriginPrivate initWithWebCoreSecurityOrigin:]):
1861 (-[WebSecurityOriginPrivate finalize]):
1862 (-[WebSecurityOriginPrivate dealloc]):
1863 (-[WebSecurityOrigin initWithProtocol:domain:]):
1864 (-[WebSecurityOrigin initWithProtocol:domain:port:]):
1865 (-[WebSecurityOrigin protocol]):
1866 (-[WebSecurityOrigin domain]):
1867 (-[WebSecurityOrigin port]):
1868 (-[WebSecurityOrigin usage]):
1869 (-[WebSecurityOrigin quota]):
1870 (-[WebSecurityOrigin setQuota:]): Clients will set quotas on the WebSecurityOrigin object itself
1871 (-[WebSecurityOrigin dealloc]):
1872 (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]):
1873 * Storage/WebSecurityOriginInternal.h: Added.
1874 * Storage/WebSecurityOriginPrivate.h: Added.
1876 2007-11-15 Brady Eidson <beidson@apple.com>
1880 Stubbing out everything required for a WebKit API for databases
1882 These interfaces seem to provide everything we need for UI and management at the browser level
1884 * Misc/WebDatabaseManager.h: Removed.
1885 * Misc/WebDatabaseManager.mm: Removed.
1886 * Misc/WebDatabaseManagerPrivate.h: Removed.
1888 * Misc/WebSecurityOrigin.mm: Added. Object that acts as a container for the "SecurityOrigin tuple"
1889 (protocol, domain, and port)
1890 (-[WebSecurityOriginPrivate initWithProtocol:domain:port:]):
1891 (-[WebSecurityOriginPrivate dealloc]):
1892 (-[WebSecurityOrigin initWithProtocol:domain:]):
1893 (-[WebSecurityOrigin initWithProtocol:domain:port:]):
1894 (-[WebSecurityOrigin protocol]):
1895 (-[WebSecurityOrigin domain]):
1896 (-[WebSecurityOrigin port]):
1897 (-[WebSecurityOrigin dealloc]):
1898 (-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:WebCore::]):
1899 * Misc/WebSecurityOriginInternal.h: Added.
1900 * Misc/WebSecurityOriginPrivate.h: Added.
1902 * Storage/WebDatabaseManager.mm: Added.
1903 (+[WebDatabaseManager sharedWebDatabaseManager]):
1904 (-[WebDatabaseManager origins]): Get a list of all origins currently tracked
1905 (-[WebDatabaseManager detailsForOrigin:]): Get the current usage and current quota for the given origin
1906 (-[WebDatabaseManager databasesWithOrigin:]): Get all databases for a certain origin
1907 (-[WebDatabaseManager detailsForDatabase:withOrigin:]): Get all details about a specific database
1908 (-[WebDatabaseManager setQuota:forOrigin:]): Change origin-wide quota
1909 (-[WebDatabaseManager deleteAllDatabases]):
1910 (-[WebDatabaseManager deleteAllDatabasesWithOrigin:]):
1911 (-[WebDatabaseManager deleteDatabase:withOrigin:]):
1912 * Storage/WebDatabaseManagerPrivate.h: Added.
1913 * Storage/WebDatabaseManagerInternal.h: Added.
1914 (WebKitInitializeDatabasesIfNecessary): One-time initialization of database-related things
1916 * Storage/WebDatabaseTrackerClient.h: Added. Stubbed out client for notifications
1917 * Storage/WebDatabaseTrackerClient.mm: Added.
1918 (WebDatabaseTrackerClient::sharedWebDatabaseTrackerClient):
1919 (WebDatabaseTrackerClient::WebDatabaseTrackerClient):
1920 (WebDatabaseTrackerClient::~WebDatabaseTrackerClient):
1921 (WebDatabaseTrackerClient::dispatchDidModifyOrigin):
1922 (WebDatabaseTrackerClient::dispatchDidModifyDatabase):
1924 * WebView/WebView.mm:
1925 (-[WebView _commonInitializationWithFrameName:groupName:]): Do one-time initialization of
1926 Database-related things here
1928 2007-11-13 Geoffrey Garen <ggaren@apple.com>
1930 Reviewed by Anders Carlsson.
1932 Renamed Shared to RefCounted.
1934 * ForwardingHeaders/wtf/RefCounted.h: Copied from WebKit/mac/ForwardingHeaders/wtf/Shared.h.
1935 * ForwardingHeaders/wtf/Shared.h: Removed.
1936 * WebCoreSupport/WebContextMenuClient.h:
1938 2007-11-13 Geoffrey Garen <ggaren@apple.com>
1940 Reviewed by Sam Weinig.
1942 Moved Shared.h into wtf so it could be used in more places.
1945 * WebCoreSupport/WebContextMenuClient.h:
1947 2007-11-13 John Sullivan <sullivan@apple.com>
1951 removed recently-added PreferredType concept; we found a better way to do what
1952 ths was accomplishing
1954 * WebCoreSupport/WebChromeClient.mm:
1955 (WebChromeClient::createWindow):
1956 removed use of PreferredType
1958 2007-11-13 John Sullivan <sullivan@apple.com>
1960 Reviewed by Dan Bernstein.
1962 - fixed <rdar://problem/5567954> REGRESSION (Safari 2-3): Autofill no longer automatically fills in
1963 form fields other than the one you're typing into
1965 * WebCoreSupport/WebEditorClient.mm:
1966 (selectorForKeyEvent):
1967 correct the key identifier strings for Tab and Esc; these were updated in WebCore as part of r21445
1968 but didn't get updated here.
1970 2007-11-12 Josh Aas <joshmoz@gmail.com>
1974 - http://bugs.webkit.org/show_bug.cgi?id=15946
1975 add NPPValue NPPVpluginDrawingModel (Mozilla bug 403418 compat)
1977 * Plugins/WebBaseNetscapePluginView.mm:
1978 (-[WebBaseNetscapePluginView setVariable:value:]):
1980 2007-11-12 Alexey Proskuryakov <ap@webkit.org>
1984 http://bugs.webkit.org/show_bug.cgi?id=15954
1985 Move DOM Selection operations out of SelectionController
1987 * WebView/WebHTMLView.mm:
1988 (-[WebHTMLView _expandSelectionToGranularity:]):
1989 (-[WebHTMLView selectToMark:]):
1990 (-[WebHTMLView swapWithMark:]):
1991 * WebView/WebView.mm:
1992 (-[WebView setSelectedDOMRange:affinity:]):
1993 Adapted for SelectionController::setSelectedRange() now returning a bool.
1995 2007-11-12 Oliver Hunt <oliver@apple.com>
1997 Reviewed by Darin and Geoff.
1999 <rdar://problem/5522011> The content of the password field of
2000 Safari is displayed by reconversion.
2002 Some input methods (notably Kotoeri) can incorrectly provide
2003 access to the raw text of a password field. To work around
2004 this we forcefully override the inputContext whenever a password
2007 * WebView/WebHTMLView.mm:
2008 (-[WebHTMLView inputContext]):
2010 2007-11-12 John Sullivan <sullivan@apple.com>
2012 Reviewed by Tim Hatcher
2014 - speculative fix for <rdar://problem/5509989> CrashTracer: [USER] 1 crash in Safari at com.apple.WebKit:
2015 -[WebPDFView(FileInternal) _updatePreferencesSoon] + 56
2017 The crash is probably due to messaging a dealloc'ed dataSource ivar. The dataSource ivar isn't retained
2018 by this class, but should be. (It is retained by WebHTMLView, e.g.).
2020 * WebView/WebPDFView.mm:
2021 (-[WebPDFView dealloc]):
2022 release dataSource ivar
2023 (-[WebPDFView setDataSource:]):
2024 retain dataSource ivar
2026 2007-11-09 Tristan O'Tierney <tristan@apple.com>
2028 Reviewed by Timothy Hatcher.
2030 This patch is for the WebKit side of <rdar://problem/5591115>.
2031 We need a way to tell context menu navigations, such as "Open in New Window"
2032 to override any sort of browser preference for tab based navigation.
2034 * WebCoreSupport/WebChromeClient.mm:
2035 (WebChromeClient::createWindow):
2036 Pass up the new preferredType parameter as a string.
2038 2007-11-09 Timothy Hatcher <timothy@apple.com>
2042 <rdar://problem/5103720> REGRESSION: [WebView stringByEvaluatingJavaScriptFromString:] fails if "return" is used
2044 Extend the linked on or after check to every application when a script passed to
2045 stringByEvaluatingJavaScriptFromString: has a return statement. Before the check
2046 was limited to VitalSource Bookshelf, but other developers are running into this.
2048 * Misc/WebKitVersionChecks.h: Add the WEBKIT_FIRST_VERSION_WITHOUT_JAVASCRIPT_RETURN_QUIRK define.
2049 * WebView/WebDocumentLoaderMac.mm:
2050 (needsDataLoadWorkaround): Use WEBKIT_FIRST_VERSION_WITHOUT_ADOBE_INSTALLER_QUIRK sicne the
2051 WebKitLinkedOnOrAfter check here was about the Adobe installer, not VitalSource.
2052 * WebView/WebView.mm:
2053 (-[WebView stringByEvaluatingJavaScriptFromString:]): Remove the bundle ID check and use
2054 WEBKIT_FIRST_VERSION_WITHOUT_JAVASCRIPT_RETURN_QUIRK for the WebKitLinkedOnOrAfter call.
2056 2007-11-08 Kevin McCullough <kmccullough@apple.com>
2060 * WebCoreSupport/WebFrameLoaderClient.h:
2061 * WebCoreSupport/WebFrameLoaderClient.mm:
2062 (WebFrameLoaderClient::windowObjectCleared):
2064 2007-11-07 Darin Adler <darin@apple.com>
2068 - removed some unused WebCore bridge methods
2070 * WebCoreSupport/WebFrameBridge.mm: Removed issueTransposeCommand and overrideMediaType.
2072 * WebCoreSupport/WebFrameLoaderClient.mm:
2073 (WebFrameLoaderClient::overrideMediaType): Changed to call WebView directly instead of
2074 using the bridge object.
2076 2007-11-06 Mark Rowe <mrowe@apple.com>
2078 Rubber-stamped by Dave Kilzer.
2080 Move Mac files from WebKit into WebKit/mac.
2082 * Carbon: Copied from WebKit/Carbon.
2083 * ChangeLog: Copied from WebKit/ChangeLog.
2084 * ChangeLog-2002-12-03: Copied from WebKit/ChangeLog-2002-12-03.
2085 * ChangeLog-2006-02-09: Copied from WebKit/ChangeLog-2006-02-09.
2086 * ChangeLog-2007-10-14: Copied from WebKit/ChangeLog-2007-10-14.
2087 * Configurations: Copied from WebKit/Configurations.
2088 * DOM: Copied from WebKit/DOM.
2089 * DefaultDelegates: Copied from WebKit/DefaultDelegates.
2090 * ForwardingHeaders: Copied from WebKit/ForwardingHeaders.
2091 * History: Copied from WebKit/History.
2092 * Info.plist: Copied from WebKit/Info.plist.
2093 * MigrateHeaders.make: Copied from WebKit/MigrateHeaders.make.
2094 * Misc: Copied from WebKit/Misc.
2095 * Panels: Copied from WebKit/Panels.
2096 * Plugins: Copied from WebKit/Plugins.
2097 * PublicHeaderChangesFromTiger.txt: Copied from WebKit/PublicHeaderChangesFromTiger.txt.
2098 * Resources: Copied from WebKit/Resources.
2099 * WebCoreSupport: Copied from WebKit/WebCoreSupport.
2100 * WebInspector: Copied from WebKit/WebInspector.
2101 * WebKit.exp: Copied from WebKit/WebKit.exp.
2102 * WebKit.order: Copied from WebKit/WebKit.order.
2103 * WebKitPrefix.h: Copied from WebKit/WebKitPrefix.h.
2104 * WebView: Copied from WebKit/WebView.
2105 * icu: Copied from WebKit/icu.
2107 2007-11-06 Alexey Proskuryakov <ap@webkit.org>
2111 http://bugs.webkit.org/show_bug.cgi?id=15847
2112 Some editing cleanup
2114 No change in functionality.
2116 * WebView/WebHTMLView.mm:
2117 (-[WebHTMLView deleteToEndOfLine:]):
2118 (-[WebHTMLView deleteToEndOfParagraph:]):
2119 WebCore had a duplicate of the same logic already. We are passing a boundary value to
2120 a function that expects granularity, this may need to be straightened out in the future.
2122 2007-11-05 John Sullivan <sullivan@apple.com>
2124 * WebView/WebView.mm:
2125 (-[WebView _searchWithSpotlightFromMenu:]):
2127 Teeny style tweak to test svn access on other machine
2129 2007-11-05 John Sullivan <sullivan@apple.com>
2131 * WebView/WebView.mm:
2132 (-[WebView computedStyleForElement:pseudoElement:]):
2134 Teeny style tweak to test svn access
2136 2007-11-02 Tristan O'Tierney <tristan@apple.com>
2138 Reviewed by Darin Adler.
2140 * DefaultDelegates/WebDefaultUIDelegate.m:
2141 (-[WebDefaultUIDelegate webView:createWebViewWithRequest:windowFeatures:]):
2142 Forward the UI delegate to call webView:createWebViewWithRequest: if
2143 this method doesn't exist.
2145 * WebCoreSupport/WebFrameLoaderClient.mm:
2146 (WebFrameLoaderClient::dispatchCreatePage):
2147 * Plugins/WebBaseNetscapePluginView.mm:
2148 (-[WebBaseNetscapePluginView loadPluginRequest:]):
2149 * WebView/WebView.mm:
2150 (-[WebView _openNewWindowWithRequest:]):
2151 Revised to use new webView:createWebViewWithRequest:windowFeatures: callback.
2153 * WebCoreSupport/WebChromeClient.h:
2154 * WebCoreSupport/WebChromeClient.mm:
2155 (WebChromeClient::createWindow):
2156 Added a new createWindow that accepts 3 parameters, so we can pass up windowFeatures to the chrome.
2157 Removed createModalDialog to use new createWindow function.
2159 * WebView/WebUIDelegatePrivate.h:
2160 Added new webView:createWebViewWithRequest:windowFeatures: method.
2162 2007-11-05 Geoffrey Garen <ggaren@apple.com>
2164 Reviewed by Darin Adler.
2166 http://bugs.webkit.org/show_bug.cgi?id=15835
2168 Small adaptations to new KJS::List class.
2170 * ForwardingHeaders/kjs/value.h: Added.
2172 2007-11-03 David D. Kilzer <ddkilzer@webkit.org>
2174 Sort files(...); sections of Xcode project files.
2176 Rubber-stamped by Darin.
2178 * WebKit.xcodeproj/project.pbxproj:
2180 2007-11-02 Antti Koivisto <antti@apple.com>
2184 Add method to enable video composition.
2186 * WebCoreSupport/WebSystemInterface.m:
2187 (InitWebCoreSystemInterface):
2189 2007-11-02 Darin Adler <darin@apple.com>
2193 - fix problem I ran into while doing some testing on Mac for
2194 <rdar://problem/5530185> WebKit does not show <object>
2195 fallback content when both URL and MIME type is omitted
2197 I don't know how to reproduce this failure in DumpRenderTree, so there is no
2200 * Plugins/WebNullPluginView.h: Removed some unneeded declarations, including
2201 the didSendError local variable. Instead we just set the error to nil once
2203 * Plugins/WebNullPluginView.mm:
2204 (-[WebNullPluginView initWithFrame:error:DOMElement:]): Refactored so that
2205 the null plug-in image code is separate from the rest of the function and
2206 so that the whole thing is not inside an if statement. Also don't hold a
2207 reference to the DOM element if there is no error to report.
2208 (-[WebNullPluginView reportFailure]): Added. Does the actual delegate
2209 callback. Happens back at the top level of the run loop so it doesn't
2210 fire deep inside layout. Also wrote this so that it is guaranteed not to
2211 reenter and so that it can handle the case where the delegate destroys
2212 the world (including this object). NOTE: This is not a real, general
2213 solution to the problem of plug-ins that do work inside layout. We will need
2214 a more general fix that works for other plug-ins, and we'll track that with
2215 a separate bug report.
2216 (-[WebNullPluginView viewDidMoveToWindow]): Removed most of the code;
2217 changed so it just does a performSelector:afterDelay:0.
2219 2007-11-02 Mark Rowe <mrowe@apple.com>
2221 Reviewed by Darin Adler.
2223 Fix http://bugs.webkit.org/show_bug.cgi?id=15780
2224 Bug 15780: WebFrameLoaderClient: WebActionElementKey wrong if view is scrolled
2226 * WebCoreSupport/WebFrameLoaderClient.mm:
2227 (WebFrameLoaderClient::actionDictionary): Retrieve the mouse event coordinates
2228 in the page coordinate system rather than the client area coordinate system.
2230 2007-11-01 Dan Bernstein <mitz@apple.com>
2232 Reviewed by Oliver Hunt.
2234 - fix an assertion failure when Command-Tabbing out of Safari
2236 * WebView/WebHTMLView.mm:
2237 (-[WebHTMLView flagsChanged:]): Avoid passing key code 0 down to
2240 2007-11-01 Justin Garcia <justin.garcia@apple.com>
2242 Reviewed by Oliver Hunt.
2244 <rdar://problem/5195056> Huge plain text pastes are slow, time spent in ApplyStyleCommand::doApply
2246 No need to match style when pasting plain text, since the fragment we build for plain text
2247 won't have any style information on it.
2249 * WebView/WebHTMLView.mm:
2250 (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:]): There's no
2251 longer a need to know whether this function chosePlaintext.
2252 (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
2253 (-[WebHTMLView _documentFragmentFromPasteboard:]):
2255 2007-10-31 Timothy Hatcher <timothy@apple.com>
2257 Reviewed by John Sullivan.
2259 Move the developer extras preference to WebPreferences.
2261 * WebView/WebPreferenceKeysPrivate.h: Add WebKitDeveloperExtrasEnabledPreferenceKey
2262 * WebView/WebPreferences.m:
2263 (+[WebPreferences initialize]): Initialize WebKitDeveloperExtrasEnabledPreferenceKey to NO.
2264 (-[WebPreferences developerExtrasEnabled]): Check DisableWebKitDeveloperExtras, WebKitDeveloperExtras
2265 and IncludeDebugMenu in addition to WebKitDeveloperExtrasEnabledPreferenceKey.
2266 (-[WebPreferences setDeveloperExtrasEnabled:]): Set WebKitDeveloperExtrasEnabledPreferenceKey.
2267 * WebView/WebPreferencesPrivate.h: Add developerExtrasEnabled and setDeveloperExtrasEnabled:.
2268 * WebView/WebView.mm:
2269 (+[WebView _developerExtrasEnabled]): Removed.
2270 (-[WebView _preferencesChangedNotification:]): Check the WebPreferences object for developerExtrasEnabled.
2271 * WebView/WebViewPrivate.h: Removed _developerExtrasEnabled.
2273 2007-10-30 David D. Kilzer <ddkilzer@webkit.org>
2275 Generated files missing from WebCore's Xcode project file
2276 <http://bugs.webkit.org/show_bug.cgi?id=15406>
2280 Added the following private header files to MigrateHeaders.make:
2282 - DOMCSSStyleSheetPrivate.h
2284 - DOMHTMLCollectionPrivate.h
2285 - DOMHTMLEmbedElementPrivate.h
2286 - DOMHTMLIFrameElementPrivate.h
2287 - DOMHTMLObjectElementPrivate.h
2288 - DOMHTMLSelectElementPrivate.h
2290 * MigrateHeaders.make:
2292 2007-10-29 Antti Koivisto <antti@apple.com>
2296 Some SPIs for media support.
2298 * WebCoreSupport/WebSystemInterface.m:
2299 (InitWebCoreSystemInterface):
2301 2007-10-29 Timothy Hatcher <timothy@apple.com>
2303 Reviewed by John Sullivan.
2305 Various semi-related changes:
2306 - A WebView can now be asked for it's WebInspector. There is one
2307 WebInspector per WebView.
2308 - Refactor the WebInspector class and move obsolete methods to
2310 - Add new WebInspector methods to show, hide and show the
2311 console/timeline panels.
2312 - Add an isDisabled method to WebCache.
2313 - Allow WebLocalizableStrings.h to be used in C files.
2315 * Misc/WebCache.h: Add isDisabled.
2317 (+[WebCache isDisabled]): New method.
2319 * Misc/WebLocalizableStrings.h: Changes to allow use in plain C files.
2321 * WebCoreSupport/WebInspectorClient.mm:
2322 (-[WebInspectorWindowController showWindow:]): Call super if already visible
2323 so the window will be ordered front.
2324 (-[WebInspectorWindowController showWebInspector:]): Method used by menu items,
2325 so they are enabled and work when the Inspector window is key.
2326 (-[WebInspectorWindowController showErrorConsole:]): Ditto.
2327 (-[WebInspectorWindowController showNetworkTimeline:]): Ditto.
2329 * WebInspector/WebInspector.h: Add and remove methods.
2330 * WebInspector/WebInspector.mm:
2331 (-[WebInspector webViewClosed]): Called when the WebView is closed/dealloced.
2332 Clears the _webView pointer.
2333 (-[WebInspector show:]): Calls thru to the Page's InspectorController.
2334 (-[WebInspector showConsole:]): Ditto.
2335 (-[WebInspector showTimeline:]): Ditto.
2336 (-[WebInspector close:]): Ditto.
2337 (-[WebInspector attach:]): Ditto.
2338 (-[WebInspector detach:]): Ditto.
2339 (+[WebInspector sharedWebInspector]): Moved to the obsolete category.
2340 (+[WebInspector webInspector]): Ditto.
2341 (-[WebInspector setWebFrame:]): Ditto.
2342 (-[WebInspector window]): Ditto.
2343 (-[WebInspector showWindow:]): Ditto.
2345 * WebView/WebView.mm:
2346 (-[WebViewPrivate dealloc]): Release the WebInspector.
2347 (-[WebView _close]): Call webViewClosed on the WebInspector.
2348 (-[WebView inspector]): Create a WebInspector if needed and return it.
2349 * WebView/WebViewPrivate.h: Add the inspector method.
2351 2007-10-30 Adele Peterson <adele@apple.com>
2355 WebKit part of fix for http://bugs.webkit.org/show_bug.cgi?id=10577
2356 <rdar://problem/5103625> REGRESSION: Caps lock icon should show in password fields
2358 * WebView/WebHTMLView.mm:
2359 (-[WebHTMLView flagsChanged:]): Call capsLockStateMayHaveChanged so WebCore knows it may have to update a password field.
2360 (+[WebHTMLView _postFlagsChangedEvent:]): Added a comment with a Radar number for why this isn't just in flagsChanged.
2361 (-[WebHTMLView scrollWheel:]): Instead of calling the next responder explicitly, we can just call super, which will take care of this.
2363 2007-10-27 Mark Ambachtsheer <mark.a@apple.com>
2367 Fix for bug 15710, When QD plugins draw to an offscreen bitmap and the plugin is not at
2368 (0, 0) the clipping rectangle is not correct.
2369 Added the origin to the window clip rectangle coordinates to account for plugins that
2370 don't originate at (0,0); affects code for offscreen GWorlds only.
2372 * Plugins/WebBaseNetscapePluginView.mm:
2373 (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2375 2007-10-26 Adele Peterson <adele@apple.com>
2379 Adding WebKitSystemInterface support for the caps lock indicator
2381 * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
2383 2007-10-25 David Hyatt <hyatt@apple.com>
2385 Fix for bug 15672, backgrounds don't tile properly inside transforms. This patch fixes tiling
2386 of backgrounds inside CSS transforms and also of HTML content with background images inside SVG
2389 Reviewed by aroben and mmitz
2391 * WebCoreSupport/WebSystemInterface.m:
2392 (InitWebCoreSystemInterface):
2393 * WebKit.xcodeproj/project.pbxproj:
2395 2007-10-25 John Sullivan <sullivan@apple.com>
2397 Reviewed by Tim Hatcher
2399 Removed the support for toggling whether WebKit uses the 10.5 PDFKit improvements. Now it
2400 always does, when available.
2402 * WebView/WebPreferencesPrivate.h:
2403 removed _usePDFPreviewView and _setUsePDFPreviewView:. Note that these were guarded with
2404 a comment that says that they can be removed when no longer needed. That time is now.
2406 * WebView/WebPreferences.m:
2407 (+[WebPreferences initialize]):
2408 removed WebKitUsePDFPreviewViewPreferenceKey
2409 (-[WebPreferences _usePDFPreviewView]):
2411 (-[WebPreferences _setUsePDFPreviewView:]):
2414 * WebView/WebPDFView.mm:
2415 (-[WebPDFView initWithFrame:]):
2416 don't check _usePDFPreviewView
2418 * WebView/WebPreferenceKeysPrivate.h:
2419 removed WebKitUsePDFPreviewViewPreferenceKey
2421 2007-10-24 Timothy Hatcher <timothy@apple.com>
2423 Reviewed by Mark Rowe.
2425 <rdar://problem/5069711> OpenSource version of libWebKitSystemInterface.a is Tiger only, causes issues if used on Leopard
2427 Use the WebKitSystemInterface that matches the system version.
2429 * Configurations/DebugRelease.xcconfig:
2430 * WebKit.xcodeproj/project.pbxproj:
2432 2007-10-24 Brady Eidson <beidson@apple.com>
2436 <rdar://problem/5554130> DatabaseTracker.o has a global initializer
2438 * Misc/WebDatabaseManager.mm:
2439 (WebKitSetWebDatabasesPathIfNecessary): Call the member function instead of a static one
2441 2007-10-23 Mark Rowe <mrowe@apple.com>
2443 Build fix for Eric's build fix in r26916.
2445 * MigrateHeaders.make:
2447 2007-10-22 Eric Seidel <eric@webkit.org>
2451 * MigrateHeaders.make: copy over font-face related DOM headers
2453 2007-10-22 Andrew Wellington <proton@wiretapped.net>
2455 Reviewed by Mark Rowe.
2457 Fix for local database support after r26879
2458 Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
2460 * Configurations/WebKit.xcconfig:
2462 2007-10-19 Brady Eidson <beidson@apple.com>
2464 Reviewed by Tim Hatcher
2466 Added support for Chrome prompts required by the Storage API
2467 Added support API for future managing of databases from the WebKit client
2468 Added preference and initialization for the databases path
2470 * Misc/WebDatabaseManager.h: Added. WebDatabaseManager is how a WebKit application can list and
2471 remove the current available databases
2472 * Misc/WebDatabaseManager.mm: Added.
2473 (+[WebDatabaseManager origins]):
2474 (+[WebDatabaseManager databasesWithOrigin:]):
2475 (+[WebDatabaseManager deleteAllDatabases]):
2476 (+[WebDatabaseManager deleteAllDatabasesWithOrigin:]):
2477 (+[WebDatabaseManager deleteDatabaseWithOrigin:named:]):
2478 (WebKitSetWebDatabasesPathIfNecessary): Setup the database path
2479 * Misc/WebDatabaseManagerPrivate.h: Added.
2481 * WebCoreSupport/WebChromeClient.h: Support for calling the delegate to run the prompt for
2482 an origin exceeding its size limit
2483 * WebCoreSupport/WebChromeClient.mm:
2484 (WebChromeClient::runDatabaseSizeLimitPrompt):
2485 * WebKit.xcodeproj/project.pbxproj:
2486 * WebView/WebUIDelegate.h:
2488 * WebView/WebView.mm:
2489 (-[WebView _commonInitializationWithFrameName:groupName:]): Setup the database path
2490 * WebView/WebViewInternal.h:
2492 2007-10-19 John Sullivan <sullivan@apple.com>
2494 Reviewed by Tim Hatcher
2496 - fixed <rdar://problem/5540325> REGRESSION (2.0.4-3): History menu looks odd after clearing history
2498 * History/WebHistory.mm:
2499 (-[WebHistoryPrivate removeAllItems]):
2500 This was fallout from r25275. We need to clear the orderedLastVisitedDays cache here, in addition
2501 to the other places where it's cleared.
2503 2007-10-18 Dan Bernstein <mitz@apple.com>
2507 * WebView/WebDataSource.mm:
2508 (-[WebDataSource _MIMETypeOfResponse:]):
2510 2007-10-18 Dan Bernstein <mitz@apple.com>
2512 Reviewed by Adam Roben.
2514 - fix <rdar://problem/5313523>
2515 REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
2517 * WebCoreSupport/WebFrameLoaderClient.mm:
2518 (WebFrameLoaderClient::makeDocumentView): Changed to use _responseMIMEType.
2519 * WebView/WebDataSource.mm:
2520 (-[WebDataSource _MIMETypeOfResponse:]): Added. Works around
2521 <rdar://problem/5321972> by testing for the case of an NSHTTPURLResponse
2522 with a MIMEType of application/octet-stream and a Content-Type header
2523 starting with text/plain and returning text/plain as the MIME type in
2525 (-[WebDataSource _responseMIMEType]): Added. Used to get the correct
2527 (-[WebDataSource _isDocumentHTML]): Changed to use _responseMIMEType.
2528 (-[WebDataSource _makeRepresentation]): Ditto.
2529 (-[WebDataSource mainResource]): Ditto.
2530 (-[WebDataSource subresources]): Changed to use _MIMETypeOfResponse and
2531 pass the MIME type explicitly.
2532 (-[WebDataSource subresourceForURL:]): Ditto.
2533 * WebView/WebDataSourcePrivate.h:
2534 * WebView/WebFrameView.mm:
2535 (-[WebFrameView _makeDocumentViewForDataSource:]): Changed to use
2537 * WebView/WebResource.mm:
2538 (-[WebResource _initWithData:URL:response:MIMEType:]): Changed this
2539 method to take a MIME type instead of extracting it from the response,
2540 so that WebDataSource could pass the correct MIME type.
2541 * WebView/WebResourcePrivate.h:
2543 2007-10-17 Darin Adler <darin@apple.com>
2545 Reviewed by Mark Rowe.
2547 - fix <rdar://problem/5183775> Uninitialized memory in -[WebDynamicScrollBarsView updateScrollers]
2549 * WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]):
2550 Change code path so it doesn't dispatch a method that returns an NSSize passing a nil object.
2551 It's safe to do that for functions that return integers or pointers, but not structures.
2553 2007-10-16 David Kilzer <ddkilzer@apple.com>
2555 Reviewed by Timothy.
2557 <rdar://problem/5544354> Wrong delegate method called in
2558 WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad()
2560 * WebCoreSupport/WebFrameLoaderClient.mm:
2561 (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): Fixed selector name.
2563 2007-10-16 Darin Adler <darin@apple.com>
2567 - moved transpose command implementation into WebCore
2569 * WebView/WebHTMLView.mm: Removed transpose: and replaced it with standard WebCore forwarding.
2571 2007-10-16 Darin Adler <darin@apple.com>
2573 Reviewed by Maciej and Geoff (and looked over by Eric).
2575 - http://bugs.webkit.org/show_bug.cgi?id=15519
2576 eliminate use of <ctype.h> for processing ASCII
2578 * ForwardingHeaders/wtf/ASCIICType.h: Added.
2579 * ForwardingHeaders/wtf/DisallowCType.h: Added.
2581 * WebKitPrefix.h: Include DisallowCType.h.
2583 * Misc/WebNSURLExtras.mm: (-[NSURL _web_URLWithLowercasedScheme]): Use toASCIILower.
2584 * WebView/WebHTMLView.mm:
2585 (-[WebHTMLView callWebCoreCommand:]): Use toASCIIUpper.
2586 (-[WebTextCompleteController filterKeyDown:]): Add a list of specific character codes,
2587 instead of using ispunct.
2589 2007-10-16 John Sullivan <sullivan@apple.com>
2591 Reviewed by Adam Roben
2593 Cleaned up localizable strings
2595 * English.lproj/Localizable.strings:
2597 * StringsNotToBeLocalized.txt:
2599 * WebKit.xcodeproj/project.pbxproj:
2600 StringsNotToBeLocalized.txt recently moved but project file wasn't updated to match; now it is
2602 2007-10-15 Kevin Decker <kdecker@apple.com>
2604 Reviewed by Darin Adler.
2606 Fixed: <rdar://problem/5520541> REGRESSION: Broken image when forwarding certain email on Tiger
2608 * WebCoreSupport/WebFrameBridge.mm: The problem was that we were loading Mail's WebKit plug-in
2609 too soon, which borked some necessary housekeeping on behalf of Mail. The fix is to add a quirk
2610 that treats Tiger Mail's WebKit plug-in like a Netscape plug-in, thus ensuring the plug-in will
2611 load during first layout and not attach time. For this plug-in, loading at first layout is
2612 expected and is consistent with Safari 2 behavior.
2614 2007-10-15 John Sullivan <sullivan@apple.com>
2616 Reviewed by Geoff Garen
2618 Replaced NS_DURING/NS_HANDLER with @try/@catch throughout WebKit
2620 I made the following changes:
2621 - replaced NS_DURING with @try, and added opening brace if there wasn't one
2622 - replaced NS_HANDLER with @catch (NSException *localException), and added braces if there weren't any
2623 - removed NS_ENDHANDLER, and added a closing brace if there wasn't one
2624 - in a couple of places, fixed indentation therein
2626 * Misc/WebIconDatabase.mm:
2627 (objectFromPathForKey):
2628 * WebView/WebHTMLView.mm:
2629 (-[WebHTMLView drawSingleRect:]):
2630 (-[WebHTMLView beginDocument]):
2631 (-[WebHTMLView deleteToMark:]):
2632 * WebView/WebView.mm:
2633 (-[WebView initWithCoder:]):
2635 == Rolled over to ChangeLog-2007-10-14 ==