1 2009-08-12 Xan Lopez <xlopez@igalia.com>
3 Reviewed by Jan Alonzo.
5 [GTK] Remove keyring optional features
6 https://bugs.webkit.org/show_bug.cgi?id=28173
8 Remove keyring support from our code and rely on libsoup to store
9 the authentication data if the user requests that support in their
12 * webkit/webkitsoupauthdialog.c:
15 (session_authenticate):
17 2009-08-11 Benjamin Otte <otte@gnome.org>
19 Reviewed by Xan Lopez.
21 When instructed to print an out-of-range page, print an empty page
24 * webkit/webkitwebframe.cpp:
27 2009-08-10 Brady Eidson <beidson@apple.com>
31 * webkit/webkitdownload.cpp:
32 (webkit_download_get_suggested_filename):
34 2009-08-08 Xan Lopez <xlopez@igalia.com>
36 Roll out r46928, since it wasn't done in accordance with the
41 Remove the ChangeLog entry, since it was added at the bottom of
44 * gdom/GdomDOMObject.h: Removed.
45 * gdom/GdomDOMObjectPrivate.h: Removed.
47 2009-08-08 Jan Michael Alonzo <jmalonzo@webkit.org>
49 Reviewed by Xan Lopez.
51 [Gtk] Enable accessibility in Gtk DRT
52 https://bugs.webkit.org/show_bug.cgi?id=25989
54 Add SPI to get the focused accessible element to be used by DRT.
56 * webkit/webkitprivate.h:
57 * webkit/webkitwebframe.cpp:
58 (webkit_web_frame_get_focused_accessible_element):
60 2009-07-30 Martin Robinson <mrobinson@appcelerator.com>
62 Reviewed by Xan Lopez, Gustavo Noronha and Jan Alonzo.
64 [GTK] new-window-policy-decision-requested provides no information about the target frame
65 https://bugs.webkit.org/show_bug.cgi?id=27792
67 Add frameName property to the WebKitWebNavigation object.
69 * WebCoreSupport/FrameLoaderClientGtk.cpp:
70 (WebKit::getNavigationAction):
71 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
72 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
73 * webkit/webkitwebnavigationaction.cpp:
74 (webkit_web_navigation_action_get_property):
75 (webkit_web_navigation_action_set_property):
76 (webkit_web_navigation_action_class_init):
77 (webkit_web_navigation_action_get_target_frame):
78 (webkit_web_navigation_action_set_target_frame):
79 * webkit/webkitwebnavigationaction.h:
81 2009-07-29 Kevin McCullough <kmccullough@apple.com>
83 Reviewed by Darin Adler.
85 Added foundation work to allow a testing infrastructure for the Web
88 * WebCoreSupport/InspectorClientGtk.cpp:
89 (WebKit::InspectorClient::inspectorWindowObjectCleared):
90 * WebCoreSupport/InspectorClientGtk.h:
92 2009-07-29 Jan Michael Alonzo <jmalonzo@webkit.org>
94 Reviewed by Eric Seidel and Xan Lopez.
96 [Gtk] Enable http/tests/appcache tests
97 https://bugs.webkit.org/show_bug.cgi?id=27674
99 Add 'enable-offline-web-application-cache' WebSetting to enable
100 or disable the appcache. Also, Add appcache SPI for DRT to use.
102 * webkit/webkitapplicationcache.cpp: Added.
103 (webkit_application_cache_set_maximum_size):
104 * webkit/webkitprivate.cpp:
106 * webkit/webkitprivate.h:
107 * webkit/webkitwebsettings.cpp:
108 (webkit_web_settings_class_init):
109 (webkit_web_settings_set_property):
110 (webkit_web_settings_get_property):
111 (webkit_web_settings_copy):
112 * webkit/webkitwebview.cpp:
113 (webkit_web_view_update_settings):
114 (webkit_web_view_settings_notify):
116 2009-07-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
118 Reviewed by Xan Lopez.
120 Add information about the regression fix for WEBKIT_DEBUG.
124 2009-07-28 Priit Laes <plaes@plaes.org>
126 Reviewed by Xan Lopez.
128 Fix mnemonics in the soup authentication dialog.
130 * webkit/webkitsoupauthdialog.c:
133 2009-07-28 Xan Lopez <xlopez@igalia.com>
135 Reviewed by Gustavo Noronha.
137 * NEWS: update for 1.1.12 release.
139 2009-07-27 Alexey Proskuryakov <ap@webkit.org>
143 * webkit/webkitwebframe.cpp: (webkit_gc_count_javascript_objects): Added a namespace to
144 SilenceAssertionsOnly.
146 2009-07-27 Alexey Proskuryakov <ap@webkit.org>
148 Reviewed by Darin Adler.
150 https://bugs.webkit.org/show_bug.cgi?id=27735
151 Give a helpful name to JSLock constructor argument
153 * webkit/webkitwebframe.cpp:
154 (webkit_gc_count_javascript_objects):
156 2009-07-24 Priit Laes <plaes@plaes.org>
158 Reviewed by Xan Lopez.
160 [Gtk] Password is saved into gnome-keyring even if auth. fails
161 https://bugs.webkit.org/show_bug.cgi?id=27560
163 Check authentication result and save password only when authentication
166 * webkit/webkitsoupauthdialog.c:
169 (save_password_callback):
171 2009-07-24 Andrei Popescu <andreip@google.com>
173 Reviewed by Anders Carlsson.
175 ApplicationCache should have size limit
176 https://bugs.webkit.org/show_bug.cgi?id=22700
178 * WebCoreSupport/ChromeClientGtk.cpp:
179 (WebKit::ChromeClient::reachedMaxAppCacheSize):
180 Adds empty implementation of reachedMaxAppCacheSize.
181 * WebCoreSupport/ChromeClientGtk.h:
183 2009-07-23 Jan Michael Alonzo <jmalonzo@webkit.org>
185 Reviewed by Eric Seidel.
187 [Gtk] Add implementation of GCController for DRT
188 https://bugs.webkit.org/show_bug.cgi?id=27636
190 Add SPI for GCController to use.
192 * webkit/webkitprivate.h:
193 * webkit/webkitwebframe.cpp:
194 (webkit_gc_collect_javascript_objects):
195 (webkit_gc_collect_javascript_objects_on_alternate_thread):
196 (webkit_gc_count_javascript_objects):
198 2009-07-22 Xan Lopez <xlopez@igalia.com>
200 Reviewed by Mark Rowe.
202 Fix compiler warning.
204 * tests/testwebsettings.c:
205 (test_webkit_web_settings_user_agent):
207 2009-07-22 Xan Lopez <xlopez@igalia.com>
209 Reviewed by Gustavo Noronha.
211 Remove unused variables.
213 * webkit/webkitwebview.cpp:
214 (webkit_web_view_grab_focus):
215 (webkit_web_view_focus_in_event):
217 2009-07-21 Priit Laes <plaes@plaes.org>
219 Reviewed by Holger Freyther.
221 [GTK+] Missing accelerator in authentication dialog
222 https://bugs.webkit.org/show_bug.cgi?id=25509
224 Add accelerator to checkbox text.
226 * WebKit/gtk/webkit/webkitsoupauthdialog.c:
229 2009-07-21 Priit Laes <plaes@plaes.org>
231 Reviewed by Holger Freyther.
233 [GTK] http auth dialog pops up twice after a cancelled atempt
234 https://bugs.webkit.org/show_bug.cgi?id=24818
236 Remove workaround required for libsoup versions <=2.26.2 as we depend
239 * webkit/webkitsoupauthdialog.c:
240 (session_authenticate):
242 2009-07-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
244 Reviewed by Holger Freyther.
246 [GTK] Widget size negotiation
247 https://bugs.webkit.org/show_bug.cgi?id=17154
249 Implement proper size request for the WebView widget.
251 * WebCoreSupport/ChromeClientGtk.cpp:
252 (WebKit::ChromeClient::contentsSizeChanged):
253 * webkit/webkitwebview.cpp:
254 (webkit_web_view_size_request):
255 (webkit_web_view_class_init):
257 2009-07-16 Holger Hans Peter Freyther <zecke@selfish.org>
259 Reviewed by Jan Alonzo.
261 [GTK+] Update the focus handling code.
263 Change focus-in to always call setActive(true), call
264 FocusController::setFocusedFrame when no focused frame exists
265 other SelectionController::setActive. This is matching Windows
268 On focus-out call FocusController::setActive(false) and
269 SelectionController::setFocued(false). This is matching Windows
272 * webkit/webkitwebview.cpp:
273 (webkit_web_view_focus_in_event):
274 (webkit_web_view_focus_out_event):
276 2009-07-16 Xiaomei Ji <xji@chromium.org>
278 Reviewed by Dan Bernstein.
280 This is the 2nd part of fixing "RTL: tooltip does not get its directionlity from its element's."
281 https://bugs.webkit.org/show_bug.cgi?id=24187
283 Add one extra parameter to the callee of HitTestResult::title() due to the signature change.
286 * WebCoreSupport/ChromeClientGtk.cpp:
287 (WebKit::ChromeClient::mouseDidMoveOverElement): Add direction as a parameter to the callee of HitTestResult::title().
289 2009-07-16 Xiaomei Ji <xji@chromium.org>
291 Reviewed by Darin Adler.
293 Fix tooltip does not get its directionality from its element's directionality.
294 https://bugs.webkit.org/show_bug.cgi?id=24187
296 Per mitz's suggestion in comment #6, while getting the plain-text
297 title, we also get the directionality of the title. How to handle
298 the directionality is up to clients. Clients could ignore it,
299 or use attribute or unicode control characters to display the title
302 * WebCoreSupport/ChromeClientGtk.cpp:
303 (WebKit::ChromeClient::setToolTip): Add directionality as 2nd parameter to setToopTip() (without handling it yet).
304 * WebCoreSupport/ChromeClientGtk.h: Add directionality as 2nd parameter to setToolTip().
306 2009-07-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
308 Rubber-stamped by Jan Alonzo.
310 Fix enable-xss-auditor property documentation, and default value
311 to match the fact that it is now enabled by default.
313 * webkit/webkitwebsettings.cpp:
314 (webkit_web_settings_class_init):
316 2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
318 Reviewed by Darin Adler.
320 Change all Noncopyable inheriting visibility to public.
321 https://bugs.webkit.org/show_bug.cgi?id=27225
323 Change all Noncopyable inheriting visibility to public because
324 it is needed to the custom allocation framework (bug #20422).
326 * webkit/webkitdownload.cpp:
328 2009-07-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
330 Unreviewed. Late NEWS file for 1.1.11.
334 2009-07-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
336 Unreviewed. Changes to the doc control files for 1.1.11.
338 * docs/webkitgtk-docs.sgml:
339 * docs/webkitgtk-sections.txt:
341 2009-07-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
343 Rubber-stamped by Holger Freyther.
345 Fix unit test to use the correct assumption that the SoupMessage
346 will be NULL when WebKitNetworkRequest is created from an URI.
348 * tests/testnetworkrequest.c:
349 (test_network_request_create_destroy):
351 2009-07-13 Jan Michael Alonzo <jmalonzo@webkit.org>
353 <https://bugs.webkit.org/show_bug.cgi?id=27171> [Gtk]
354 REGRESSION (r45440): fails at fast/events/frame-programmatic-focus.html
356 Reviewed by Gustavo Noronha.
358 focus-in and focus-out events only get triggered when there's user
359 interaction, hence setFocused(bool) never gets called when
360 focusEvent is triggered when running the layout tests. The
361 solution seems to be to implement grab-focus too so we can call
362 setFocused(bool) when a widget has focus.
364 * webkit/webkitwebview.cpp:
365 (webkit_web_view_grab_focus):
366 (webkit_web_view_focus_in_event):
367 (webkit_web_view_class_init):
369 2009-07-13 Jan Michael Alonzo <jmalonzo@webkit.org>
371 https://bugs.webkit.org/show_bug.cgi?id=26718 [Gtk] Add support for javascript windows for DRT
373 Reviewed by Gustavo Noronha and Xan Lopez.
375 Add API to support opening and closing of JavaScript windows automatically.
377 * WebCoreSupport/ChromeClientGtk.cpp:
378 (WebKit::ChromeClient::closeWindowSoon):
379 * webkit/webkitprivate.h:
380 * webkit/webkitwebsettings.cpp:
381 (webkit_web_settings_class_init):
382 (webkit_web_settings_set_property):
383 (webkit_web_settings_get_property):
384 (webkit_web_settings_copy):
385 * webkit/webkitwebview.cpp:
386 (webkit_web_view_real_close_web_view):
387 (webkit_web_view_class_init):
388 (webkit_web_view_update_settings):
389 (webkit_web_view_settings_notify):
390 (webkit_web_view_set_group_name):
391 * webkit/webkitwebview.h:
393 2009-07-12 Brent Fulgham <bfulgham@gmail.com>
395 Speculative build fix after http://trac.webkit.org/changeset/45786.
397 * WebCoreSupport/ChromeClientGtk.cpp:
398 (WebKit::ChromeClient::addMessageToConsole):
399 * WebCoreSupport/ChromeClientGtk.h:
401 2009-07-09 Beth Dakin and Jon Honeycutt <bdakin@apple.com>
403 Reviewed by Dave Hyatt.
405 Make Widget RefCounted to fix:
407 <rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs
408 at WebCore::Widget::afterMouseDown() after clicking To Do's close
410 <rdar://problem/6978804> WER #16: Repro Access Violation in
411 WebCore::PluginView::bindingInstance (1310178023)
413 <rdar://problem/6991251> WER #13: Crash in WebKit!
414 WebCore::PluginView::performRequest+203 (1311461169)
416 * WebCoreSupport/FrameLoaderClientGtk.cpp:
417 (WebKit::FrameLoaderClient::createPlugin):
418 (WebKit::FrameLoaderClient::createJavaAppletWidget):
419 * WebCoreSupport/FrameLoaderClientGtk.h:
421 2009-07-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
423 Reviewed by Jan Alonzo.
425 Use soup's content sniffing
426 https://bugs.webkit.org/show_bug.cgi?id=26982
428 Add the new Content Sniffing feature provided by libsoup.
430 * webkit/webkitprivate.cpp:
433 2009-07-05 Holger Hans Peter Freyther <zecke@selfish.org>
435 Reviewed by Xan Lopez.
437 Always initialize WebCore.
439 It is possible that WebKitWebSettings and other classes get
440 constructed before the WebKitWebView. In this case WebCore is
441 not yet properly initialized. Add webkit_init to every class
442 that can be constructed by API users.
444 * webkit/webkitdownload.cpp:
445 (webkit_download_class_init):
446 * webkit/webkitnetworkrequest.cpp:
447 (webkit_network_request_class_init):
448 * webkit/webkitwebbackforwardlist.cpp:
449 (webkit_web_back_forward_list_class_init):
450 * webkit/webkitwebhistoryitem.cpp:
451 (webkit_web_history_item_class_init):
452 * webkit/webkitwebsettings.cpp:
453 (webkit_web_settings_class_init):
454 * webkit/webkitwebwindowfeatures.cpp:
455 (webkit_web_window_features_class_init):
457 2009-07-03 Jan Michael Alonzo <jmalonzo@webkit.org>
459 Reviewed by Xan Lopez and Gustavo Noronha.
461 Set user-agent from application
462 https://bugs.webkit.org/show_bug.cgi?id=17375
464 Add 'user-agent' setter/getter API to WebSettings.
466 * WebCoreSupport/FrameLoaderClientGtk.cpp:
467 (WebKit::FrameLoaderClient::FrameLoaderClient):
468 (WebKit::FrameLoaderClient::userAgent):
469 * WebCoreSupport/FrameLoaderClientGtk.h:
470 * webkit/webkitprivate.h:
471 * webkit/webkitversion.h.in:
472 * webkit/webkitwebsettings.cpp:
473 (webkit_get_user_agent):
474 (webkit_web_settings_class_init):
475 (webkit_web_settings_finalize):
476 (webkit_web_settings_set_property):
477 (webkit_web_settings_get_property):
478 (webkit_web_settings_copy):
479 (webkit_web_settings_get_user_agent):
480 * webkit/webkitwebsettings.h:
481 * webkit/webkitwebview.cpp:
482 (webkit_web_view_dispose):
484 2009-07-02 Xan Lopez <xlopez@igalia.com>
486 Reviewed by Holger Freyther.
488 Update the new boolean property in FocusController that keeps
489 track of whether or not the Page is focused.
491 * webkit/webkitwebview.cpp:
492 (webkit_web_view_focus_in_event):
493 (webkit_web_view_focus_out_event):
495 2009-06-29 Xan Lopez <xlopez@igalia.com>
497 Reviewed by Jan Alonzo.
499 Fix a couple of compiler warnings.
501 * webkit/webkitwebnavigationaction.cpp:
502 * webkit/webkitwebview.cpp:
503 (webkit_web_view_real_move_cursor):
505 2009-06-28 Xan Lopez <xlopez@igalia.com>
509 * WebCoreSupport/ContextMenuClientGtk.cpp:
510 (WebKit::ContextMenuClient::isSpeaking):
511 * WebCoreSupport/ContextMenuClientGtk.h:
513 2009-06-24 Jiahua Huang <jhuangjiahua@gmail.com>
515 Reviewed by Holger Freyther.
517 [Gtk] Add Undo/Redo support to WebKitGtk
518 https://bugs.webkit.org/show_bug.cgi?id=26573
520 Implement EditorClient::undo and other interested funcs.
522 * WebCoreSupport/EditorClientGtk.cpp:
523 (WebKit::EditorClient::registerCommandForUndo):
524 (WebKit::EditorClient::registerCommandForRedo):
525 (WebKit::EditorClient::clearUndoRedoOperations):
526 (WebKit::EditorClient::canUndo):
527 (WebKit::EditorClient::canRedo):
528 (WebKit::EditorClient::undo):
529 (WebKit::EditorClient::redo):
530 (WebKit::EditorClient::EditorClient):
531 * WebCoreSupport/EditorClientGtk.h:
533 2009-06-20 Jan Michael Alonzo <jmalonzo@webkit.org>
535 Reviewed by Gustavo Noronha and Xan Lopez.
537 [Gtk] Implement DRT XSS auditor support
538 https://bugs.webkit.org/show_bug.cgi?id=26571
540 Add a setting "enable-xss-auditor" to enable this feature.
542 * webkit/webkitwebsettings.cpp:
543 (webkit_web_settings_class_init):
544 (webkit_web_settings_set_property):
545 (webkit_web_settings_get_property):
546 (webkit_web_settings_copy):
547 * webkit/webkitwebview.cpp:
548 (webkit_web_view_update_settings):
549 (webkit_web_view_settings_notify):
551 2009-06-20 Jan Michael Alonzo <jmalonzo@webkit.org>
553 Reviewed by Gustavo Noronha and Xan Lopez.
555 webkit_web_back_forward_list_add_item() should add a ref for the history item
556 https://bugs.webkit.org/show_bug.cgi?id=26517
558 Add a ref to the WebHistoryItem when it's added to the back
559 forward list through webkit_web_back_forward_list_add_item.
560 This keeps the history item alive and prevents pywebkitgtk from
563 * tests/testwebbackforwardlist.c:
564 (test_webkit_web_history_item_lifetime):
565 (test_webkit_web_back_forward_list_order):
566 (test_webkit_web_back_forward_list_add_item):
567 * webkit/webkitwebbackforwardlist.cpp:
568 (webkit_web_back_forward_list_add_item):
570 2009-06-20 Gustavo Noronha Silva <gns@gnome.org>
572 Reviewed by Jan Alonzo.
574 Initial test case for loading statuses.
576 * tests/testloading.c: Added.
579 (test_loading_status):
582 2009-06-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
584 Rubber-stamped by Jan Alonzo.
586 Fix the ordering in which the new load status goes into the enum
587 to avoid ABI breakage.
589 * webkit/webkitwebframe.h:
591 2009-06-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
593 Reviewed by Xan Lopez and Christian Dywan.
595 Add a new load status to report that the first visually non-empty
596 layout has been done.
598 * WebCoreSupport/FrameLoaderClientGtk.cpp:
599 (WebKit::FrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):
600 * webkit/webkitwebframe.h:
602 2009-06-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
604 Reviewed by Xan Lopez.
606 Fix parameters of navigation-policy-decision-requested callback,
607 to be correct in number and type
609 * tests/testhttpbackend.c:
610 (navigation_policy_decision_requested_cb):
612 2009-06-18 Christian Dywan <christian@twotoasts.de>
614 Reviewed by Gustavo Noronha.
616 * WebCoreSupport/FrameLoaderClientGtk.cpp:
618 (WebKit::FrameLoaderClient::dispatchDidFinishLoad):
619 (WebKit::FrameLoaderClient::dispatchDidFailProvisionalLoad):
620 (WebKit::FrameLoaderClient::dispatchDidFailLoad): Introduce the static
621 function loadDone to emit "load-done" and update the status and update
622 the relevent places. We missed some status notifications before.
624 2009-06-18 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
626 Rubber-stamped by Xan Lopez.
628 Be consistent in always using the term URI instead of URL in the
629 documentation of WebKitWebView signals.
631 * webkit/webkitwebview.cpp:
632 (webkit_web_view_class_init):
634 2009-06-16 Xan Lopez <xlopez@igalia.com>
636 Reviewed by Gustavo Noronha.
638 Do not use g_assert_cmpint to test for NULL pointer, just
641 * tests/testnetworkrequest.c:
642 (test_network_request_create_destroy):
644 2009-06-15 Xan Lopez <xlopez@igalia.com>
646 Reviewed by Gustavo Noronha.
648 https://bugs.webkit.org/show_bug.cgi?id=26377
649 [GTK] Confusion about range of 'progress' property
651 Range for the progress property is 0.0 .. 1.0, don't multiply it
652 by 100 to make it a percentage.
654 * webkit/webkitwebview.cpp:
655 (webkit_web_view_get_progress):
657 2009-06-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
659 Unreviewed. Add new symbols list for 1.1.10 release.
661 * docs/webkitgtk-docs.sgml:
663 2009-06-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
665 Rubber-stamped by Xan Lopez.
667 Fix Since tags for the new uri and message properties.
669 * webkit/webkitnetworkrequest.cpp:
670 (webkit_network_request_class_init):
672 2009-06-15 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
674 Unreviewed. Adding new documented API to the generated
677 * docs/webkitgtk-sections.txt:
679 2009-06-15 Xan Lopez <xlopez@igalia.com>
681 Reviewed by Gustavo Noronha.
683 Update NEWS for 1.1.10 release.
687 2009-06-11 Gustavo Noronha Silva <gns@gnome.org>
689 Reviewed by Xan Lopez.
691 Add a test to perform an actual download.
693 * tests/testdownload.c:
694 (navigation_policy_decision_requested_cb):
696 (download_requested_cb):
697 (test_webkit_download_perform):
700 2009-06-11 Gustavo Noronha Silva <gns@gnome.org>
702 Reviewed by Xan Lopez.
704 Fix crash when downloading, caused by assuming SoupMessage would
705 be there. This change factors the logic required to create a
706 ResourceRequest from a WebKitNetworkRequest into a core()
707 function, like we have for some other classes.
709 * webkit/webkitdownload.cpp:
710 (webkit_download_start):
711 * webkit/webkitprivate.cpp:
713 * webkit/webkitprivate.h:
714 * webkit/webkitwebframe.cpp:
715 (webkit_web_frame_load_request):
717 2009-06-10 Gustavo Noronha Silva <gns@gnome.org>
719 Reviewed by Xan Lopez.
721 Make WebKitNetworkRequest a proper GObject, making URI and
722 SoupMessage properties. Also adding unit tests for creation and
725 * tests/testnetworkrequest.c: Added.
726 (test_network_request_create_destroy):
727 (test_network_request_properties):
729 * webkit/webkitnetworkrequest.cpp:
730 (webkit_network_request_get_property):
731 (webkit_network_request_set_property):
732 (webkit_network_request_class_init):
733 (webkit_network_request_init):
734 (webkit_network_request_constructor):
735 (webkit_network_request_new_with_core_request):
736 (webkit_network_request_new):
737 (webkit_network_request_set_uri):
738 (webkit_network_request_get_uri):
739 * webkit/webkitnetworkrequest.h:
741 2009-06-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
743 Reviewed by Xan Lopez.
749 2009-06-09 Jan Michael Alonzo <jmalonzo@webkit.org>
751 Reviewed by Gustavo Noronha.
753 Clear the frame name before we run each tests so we don't get
754 "someFloaString" or "3" in the target frame name.
756 * webkit/webkitprivate.h:
757 * webkit/webkitwebframe.cpp:
758 (webkit_web_frame_clear_main_frame_name):
761 2009-06-10 Xan Lopez <xlopez@igalia.com>
763 Reviewed by Jan Alonzo.
765 https://bugs.webkit.org/show_bug.cgi?id=25415
766 [GTK][ATK] Please implement support for get_text_at_offset
768 Update test for new implementation (it fixes two bugs and adds
769 actual implementations for LINE boundaries).
772 (test_webkit_atk_get_text_at_offset):
774 2009-06-09 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
776 Reviewed by Xan Lopez.
778 https://bugs.webkit.org/show_bug.cgi?id=26104
779 [GTK] Make NetworkRequest a proper GObject and expose SoupMessage
781 Refactor how SoupMessage is handled, so that our ResourceRequest
782 object doesn't have to store it as a member, which complicates
783 managing ResourceRequest's lifetime.
785 * tests/testhttpbackend.c:
786 (navigation_policy_decision_requested_cb):
787 (test_soup_message_lifetime):
788 * webkit/webkitnetworkrequest.cpp:
790 (webkit_network_request_new_with_core_request):
792 2009-06-08 Gustavo Noronha Silva <gns@gnome.org>
794 Reviewed by Jan Alonzo.
796 https://bugs.webkit.org/show_bug.cgi?id=26240
797 [GTK] Try again button loses query strings
799 Only trigger reload, when try again is clicked, this way we do not
800 lose the query strings, like we did when also triggering a form
803 * resources/error.html:
805 2009-06-06 Gustavo Noronha Silva <gns@gnome.org>
807 Reviewed by Xan Lopez.
809 https://bugs.webkit.org/show_bug.cgi?id=26175
810 [GTK] Download progress notification should be throttled, for the benefit of download managers
812 Throttle notifications for the 'progress' property of the Download
813 object, and update documentation to note the fact that this is
814 being done, and how to get all notifications if you really care
817 * webkit/webkitdownload.cpp:
818 (webkit_download_class_init):
819 (webkit_download_received_data):
821 2009-05-29 Jan Michael Alonzo <jmalonzo@webkit.org>
823 Reviewed by Gustavo Noronha.
825 Fixed compile warning when comparing the different navigation types
827 * webkit/webkitwebnavigationaction.cpp:
828 (webkit_web_navigation_action_class_init):
830 2009-05-29 Xan Lopez <xlopez@igalia.com>
832 Reviewed by Gustavo Noronha.
834 https://bugs.webkit.org/show_bug.cgi?id=26075
835 [GTK] Refactor key scrolling code
837 After the scrolling changes in r44177 we can now use the
838 FrameView::scroll method like the other ports, keeping the magic
839 constants for the scrolling amounts inside WebCore proper.
841 * webkit/webkitwebview.cpp:
842 (webkit_web_view_real_move_cursor):
844 2009-05-29 Gustavo Noronha Silva <gns@gnome.org>
846 Reviewed by Jan Alonzo.
848 Make NetworkRequest carry a reference of the SoupMessage used by
849 ResourceRequest, and use that to create new ResourceRequests where
850 needed, so that no information is lost while passing around
851 NetworkRequest objects.
853 * WebCoreSupport/FrameLoaderClientGtk.cpp:
854 (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType):
855 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
856 (WebKit::FrameLoaderClient::startDownload):
857 * webkit/webkitdownload.cpp:
858 (webkit_download_start):
859 * webkit/webkitnetworkrequest.cpp:
860 (webkit_network_request_finalize):
861 (webkit_network_request_new_with_core_request):
862 (webkit_network_request_new):
863 (webkit_network_request_get_message):
864 * webkit/webkitprivate.h:
865 * webkit/webkitwebframe.cpp:
866 (webkit_web_frame_load_request):
868 2009-05-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
870 Reviewed by Xan Lopez.
872 https://bugs.webkit.org/show_bug.cgi?id=26048
873 navigation-policy-decision-requested documentation incomplete
875 Fix documentation for all policy decision request signals, to
876 mention that an actual decision is expected when you return TRUE,
877 meaning that you handled the signal.
879 * webkit/webkitwebview.cpp:
880 (webkit_web_view_class_init):
882 2009-05-28 Xan Lopez <xlopez@igalia.com>
884 Reviewed by Gustavo Noronha.
886 Mention the implementation of the new AtkText methods.
890 2009-05-19 Xan Lopez <xlopez@igalia.com>
892 Reviewed by Jan Alonzo and Gustavo Noronha.
894 https://bugs.webkit.org/show_bug.cgi?id=25415
895 [GTK][ATK] Please implement support for get_text_at_offset
897 New test file for ATK functionality.
899 * tests/testatk.c: Added.
901 (test_get_text_function):
902 (test_webkit_atk_get_text_at_offset):
905 2009-05-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
907 Reviewed by Xan Lopez.
909 Document changes worth noting for 1.1.8.
913 2009-05-27 Xan Lopez <xlopez@igalia.com>
915 Reviewed by Gustavo Noronha.
917 https://bugs.webkit.org/show_bug.cgi?id=26039
918 [GTK] WebKitWebHistoryItem lifetime fixes
920 Modify the management of history items by the BackForward list.
922 Having the objects add themselves to a hash table with an extra
923 reference made impossible for the cleanup code in the dispose
924 method to be ever called in normal conditions, since dispose is
925 called before getting rid of the last reference, which the objects
926 were making to themselves. Get rid of this extra reference and
927 move the responsibility of the cleanup to the BackForward list
928 itself, which effectively owns the WebKitWebHistoryItems now.
930 Also, update the tests to reflect this change.
932 * tests/testwebbackforwardlist.c:
933 (test_webkit_web_history_item_lifetime):
934 (test_webkit_web_back_forward_list_order):
935 (test_webkit_web_back_forward_list_add_item):
936 * tests/testwebhistoryitem.c:
937 (web_history_item_fixture_setup):
938 (web_history_item_fixture_teardown):
939 * webkit/webkitprivate.h:
940 * webkit/webkitwebbackforwardlist.cpp:
941 (webkit_web_back_forward_list_dispose):
942 (webkit_web_back_forward_list_class_init):
943 * webkit/webkitwebhistoryitem.cpp:
944 (webkit_history_items):
945 (webkit_history_item_add):
946 (webkit_web_history_item_dispose):
949 2009-05-26 Xan Lopez <xlopez@igalia.com>
951 Reviewed by Jan Alonzo.
953 https://bugs.webkit.org/show_bug.cgi?id=26039
954 [GTK] WebKitWebHistoryItem lifetime fixes
956 Delete the BackForwardList before the Page, otherwise the references
957 to the WebKitWebHistoryItems will be gone.
959 * webkit/webkitwebview.cpp:
960 (webkit_web_view_dispose):
962 2009-05-27 Gustavo Noronha Silva <gns@gnome.org>
964 Reviewed by Xan Lopez.
966 Add comment to clarify why scrolling is done as it is and not with
969 * WebCoreSupport/ChromeClientGtk.cpp:
970 (WebKit::ChromeClient::scroll):
972 2009-05-27 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
974 Unreviewed. Adding new symbols index for 1.1.8.
976 * docs/webkitgtk-docs.sgml:
978 2009-05-26 Holger Hans Peter Freyther <zecke@selfish.org>
980 Reviewed by Xan Lopez.
982 Add a new signal called "create-plugin-widget" and emit it from
983 within the FrameLoaderClientGtk::createPlugin method. If a
984 GtkWidget gets returned it will be embedded as a WebCore::Widget
985 using the new GtkPluginWidget.
987 * WebCoreSupport/FrameLoaderClientGtk.cpp:
988 (WebKit::FrameLoaderClient::createPlugin):
989 * webkit/webkitwebview.cpp:
990 (webkit_signal_accumulator_object_handled):
991 (webkit_web_view_class_init):
992 * webkitmarshal.list:
994 2009-05-24 Xan Lopez <xlopez@igalia.com>
996 Reviewed by Mark Rowe.
998 https://bugs.webkit.org/show_bug.cgi?id=25987
999 [GTK] Clarify WebKitWebView::download-requested documentation
1001 Explain a bit why this signal is not emitted by default and offer
1002 a common solution/setup for that issue.
1004 * webkit/webkitwebview.cpp:
1005 (webkit_web_view_class_init):
1007 2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>
1009 Rubber-stamped by Gustavo Noronha.
1011 Break the switch once private browsing is selected.
1013 * webkit/webkitwebsettings.cpp:
1014 (webkit_web_settings_set_property):
1015 (webkit_web_settings_get_property):
1017 2009-05-23 Jan Michael Alonzo <jmalonzo@webkit.org>
1019 Reviewed by Gustavo Noronha and Xan Lopez.
1021 [Gtk] Enable database and localStorage support
1022 https://bugs.webkit.org/show_bug.cgi?id=25629
1024 Add settings to enable or disable database and localStorage
1025 support and enable them by default. This allows databases to be
1026 shown in the WebInspector as well as allow us to run the storage
1029 * webkit/webkitwebsettings.cpp:
1030 (webkit_web_settings_class_init):
1031 (webkit_web_settings_set_property):
1032 (webkit_web_settings_get_property):
1033 (webkit_web_settings_copy):
1034 * webkit/webkitwebview.cpp:
1035 (webkit_web_view_update_settings):
1036 (webkit_web_view_settings_notify):
1038 2009-05-23 David Kilzer <ddkilzer@apple.com>
1040 Part 2 of 2: Bug 25495: Implement PassOwnPtr and replace uses of std::auto_ptr
1042 <https://bugs.webkit.org/show_bug.cgi?id=25495>
1044 Reviewed by Oliver Hunt.
1046 * WebCoreSupport/ChromeClientGtk.h:
1047 (WebKit::ChromeClient::createHTMLParserQuirks): Return a
1048 PassOwnPtr<> instead of a raw HTMLParserQuirks pointer.
1050 2009-05-22 Gustavo Noronha Silva <gns@gnome.org>
1052 Reviewed by Jan Alonzo.
1054 Improve NetworkRequest documentation.
1056 * webkit/webkitnetworkrequest.cpp:
1057 (webkit_network_request_class_init):
1058 (webkit_network_request_init):
1060 2009-05-21 Xan Lopez <xlopez@igalia.com>
1062 Reviewed by Maciej Stachowiak.
1064 https://bugs.webkit.org/show_bug.cgi?id=24818
1065 [GTK] http auth dialog pops up twice after a cancelled atempt
1067 Workaround libsoup bug
1068 http://bugzilla.gnome.org/show_bug.cgi?id=583462, which made
1069 libsoup emit the 'authenticate' signal more often than it was
1072 We'll be able to remove this when we depend on libsoup > 2.26.2.
1074 * webkit/webkitsoupauthdialog.c:
1075 (session_authenticate):
1077 2009-05-21 Darin Fisher <darin@chromium.org>
1081 * WebCoreSupport/EditorClientGtk.cpp:
1082 (WebKit::EditorClient::getAutoCorrectSuggestionForMisspelledWord): Add stub for method.
1083 * WebCoreSupport/EditorClientGtk.h:
1085 2009-05-20 Holger Hans Peter Freyther <zecke@selfish.org>
1087 Reviewed by Darin Adler.
1089 https://bugs.webkit.org/show_bug.cgi?id=25834
1091 Make ChromeClient a interface again
1093 With recent additions to ChromeClient.h empty defaults were
1094 added. This is bad for porters as these changes go unnoticed
1095 and at runtime no notImplemented warning is logged and grepping
1096 for notImplemented will not show anything. Change this Client
1097 to be like the other Clients again and always have pure virtuals
1098 (but for stuff inside #ifdef PLATFORM(MAC)).
1100 Update the various WebKit/* implementations to compile again.
1102 * WebCoreSupport/ChromeClientGtk.cpp:
1103 (WebKit::ChromeClient::setCursor):
1104 (WebKit::ChromeClient::requestGeolocationPermissionForFrame):
1105 * WebCoreSupport/ChromeClientGtk.h:
1106 (WebKit::ChromeClient::scrollRectIntoView):
1108 2009-05-19 Xan Lopez <xlopez@igalia.com>
1110 Reviewed by Jan Alonzo.
1112 Do not try to free enchant broker and dictionary if they do not
1113 exist, those functions aren't NULL-safe.
1115 * webkit/webkitwebsettings.cpp:
1116 (free_spell_checking_language):
1118 2009-05-15 Gustavo Noronha Silva <gns@gnome.org>
1120 Reviewed by Jan Alonzo.
1124 * webkit/webkitwebsettings.cpp:
1125 (free_spell_checking_language):
1126 (webkit_web_settings_finalize):
1127 (webkit_web_settings_set_property):
1129 2009-05-15 Fridrich Strba <fridrich.strba@bluewin.ch>
1131 Reviewed by Jan Alonzo.
1133 Converting filename to uri by concatenating strings is broken
1134 on Windows. Use proper glib conversion functions.
1136 * webkit/webkitwebview.cpp:
1137 (webkit_web_view_open):
1138 * tests/testdownload.c:
1139 (test_webkit_download_create):
1141 2009-05-13 Xan Lopez <xlopez@igalia.com>
1143 Reviewed by Gustavo Noronha.
1145 Do not handle KeyEvents with Ctrl or Alt modifiers that we
1146 otherwise know nothing about. Otherwise shortcuts defined in the
1147 WebView will never be executed.
1149 * WebCoreSupport/EditorClientGtk.cpp:
1150 (WebKit::handleEditingKeyboardEvent):
1152 2009-05-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1154 Add information about the SVG index bounds check committed in
1159 2009-05-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1161 Reviewed by Xan Lopez.
1163 Note changes since 1.1.6.
1167 2009-05-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1169 Unreviewed. Updated control file, and main file for the 1.1.7
1172 * docs/webkitgtk-docs.sgml:
1173 * docs/webkitgtk-sections.txt:
1175 2009-05-11 Holger Hans Peter Freyther <zecke@selfish.org>
1177 Reviewed by Xan Lopez.
1179 https://bugs.webkit.org/show_bug.cgi?id=25685
1180 [GTK] Middle click paste form the pasteboard
1182 For paste from middle button (button==2) we want to use
1183 the GDK_PRIMARY_SELECTION. Implement the new getCurrentTarget
1184 method in PasteboardHelperGtk by asking the WebView which
1187 * WebCoreSupport/PasteboardHelperGtk.cpp:
1188 (WebKit::PasteboardHelperGtk::getCurrentTarget):
1189 * WebCoreSupport/PasteboardHelperGtk.h:
1190 * webkit/webkitprivate.h:
1191 * webkit/webkitwebview.cpp:
1192 (webkit_web_view_button_press_event):
1193 (webkit_web_view_use_primary_for_paste):
1195 2009-05-12 Jan Michael Alonzo <jmalonzo@webkit.org>
1197 Reviewed by Holger Freyther.
1199 [Gtk] Various autotools build refactoring and fixes
1200 https://bugs.webkit.org/show_bug.cgi?id=25286
1202 Add glib-2.0 to the list of required package.
1206 2009-05-11 Christian Dywan <christian@twotoasts.de>
1208 Reviewed by Gustavo Noronha.
1210 https://bugs.webkit.org/show_bug.cgi?id=25697
1211 [GTK] Warnings building WebKit/gtk/tests/testwebframe.c
1213 * tests/testwebframe.c:
1214 (test_webkit_web_frame_create_destroy): Declare webView as a GtkWidget*
1215 to fix pointer type incompatibility warnings.
1217 2009-05-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1219 Reviewed by Xan Lopez.
1221 Make the scan program call g_thread_init(NULL) in addition to
1222 g_type_init(), so that it actually works.
1224 * docs/GNUmakefile.am:
1226 2009-05-08 Xan Lopez <xlopez@igalia.com>
1228 Reviewed by Gustavo Noronha.
1230 Unify scrolling code via adjustments and keys. Use the WebCore
1231 defined constants, since that's what people are most used to at
1235 * webkit/webkitwebview.cpp:
1236 (webkit_web_view_real_move_cursor):
1238 2009-05-07 Christian Dywan <christian@twotoasts.de>
1240 Reviewed by Gustavo Noronha.
1242 * WebCoreSupport/FrameLoaderClientGtk.cpp:
1243 (WebKit::FrameLoaderClient::dispatchDidChangeLocationWithinPage):
1244 (WebKit::FrameLoaderClient::dispatchDidCommitLoad): Add missing
1245 call to notifyStatus in the committed case and a missing property notify.
1247 2009-05-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1249 Reviewed by Xan Lopez.
1251 https://bugs.webkit.org/show_bug.cgi?id=24786
1252 WebKitDownload sometimes suggests peculiar filenames
1254 When a download is requested by an ongoing request, use the already
1255 provided response to set the suggested filename for the WebKitDownload
1256 object, if available.
1258 * WebCoreSupport/FrameLoaderClientGtk.cpp:
1259 (WebKit::FrameLoaderClient::download):
1260 * webkit/webkitdownload.cpp:
1261 (_WebKitDownloadPrivate::webkit_download_set_property):
1262 (_WebKitDownloadPrivate::webkit_download_get_suggested_filename):
1263 (_WebKitDownloadPrivate::webkit_download_set_suggested_filename):
1264 * webkit/webkitprivate.h:
1265 * webkit/webkitwebview.cpp:
1267 2009-05-06 Jan Michael Alonzo <jmalonzo@webkit.org>
1269 Reviewed by Holger Freyther.
1271 GTK+ API implementation files have bogus extern "C" entries
1272 https://bugs.webkit.org/show_bug.cgi?id=24322
1274 Remove bogus extern "C" from the source files.
1276 * webkit/webkitdownload.cpp:
1277 (DownloadClient::cannotShowURL):
1278 * webkit/webkiterror.cpp:
1279 (webkit_plugin_error_quark):
1280 * webkit/webkitnetworkrequest.cpp:
1281 (webkit_network_request_get_uri):
1282 * webkit/webkitprivate.cpp:
1284 * webkit/webkitversion.cpp:
1285 (webkit_micro_version):
1286 * webkit/webkitwebbackforwardlist.cpp:
1287 * webkit/webkitwebframe.cpp:
1288 (webkit_web_frame_get_load_status):
1289 * webkit/webkitwebhistoryitem.cpp:
1290 * webkit/webkitwebinspector.cpp:
1291 (webkit_web_inspector_set_inspector_client):
1292 * webkit/webkitwebnavigationaction.cpp:
1293 (webkit_web_navigation_action_get_modifier_state):
1294 * webkit/webkitwebpolicydecision.cpp:
1295 (webkit_web_policy_decision_cancel):
1296 * webkit/webkitwebsettings.cpp:
1297 (webkit_web_settings_get_spell_languages):
1298 * webkit/webkitwebview.cpp:
1299 * webkit/webkitwebwindowfeatures.cpp:
1300 (webkit_web_window_features_equal):
1302 2009-05-06 Jan Michael Alonzo <jmalonzo@webkit.org>
1304 Reviewed by Holger Freyther.
1306 Misc fixes to InspectorClientGtk.
1308 * WebCoreSupport/InspectorClientGtk.cpp:
1309 (WebKit::InspectorClient::createPage): use g_filename_to_uri to
1310 get the URI and use web_view_load_uri instead of the deprecated
1311 web_view_open method for loading the URI.
1312 (WebKit::InspectorClient::localizedStringsURL): implement.
1314 2009-05-05 Ben Murdoch <benm@google.com>
1316 Reviewed by Eric Seidel.
1318 Add #if ENABLE(DATABASE) guards around database code so toggling ENABLE_DATABASE off does not break builds.
1319 https://bugs.webkit.org/show_bug.cgi?id=24776
1321 * WebCoreSupport/ChromeClientGtk.cpp:
1322 (WebKit::ChromeClient::exceededDatabaseQuota):
1323 * WebCoreSupport/ChromeClientGtk.h:
1325 2009-05-06 Christian Dywan <christian@twotoasts.de>
1327 Reviewed by Gustavo Noronha.
1329 http://bugs.webkit.org/show_bug.cgi?id=17066
1330 [GTK] Improve frameloader signals
1332 Implement load-status and progress properties on the view, as well as
1333 load-status on the frame. This supersedes the different load signals
1334 load-progress-changed, load-committed, load-done, load-started and
1335 load-finished which are not only misnamed but broken by design.
1337 * WebCoreSupport/FrameLoaderClientGtk.cpp:
1338 (WebKit::notifyStatus):
1339 (WebKit::FrameLoaderClient::postProgressStartedNotification):
1340 (WebKit::FrameLoaderClient::postProgressEstimateChangedNotification):
1341 (WebKit::FrameLoaderClient::dispatchDidFinishLoad):
1342 (WebKit::FrameLoaderClient::dispatchDidStartProvisionalLoad):
1343 * webkit/webkitprivate.h:
1344 * webkit/webkitwebframe.cpp:
1345 * webkit/webkitwebframe.h:
1346 * webkit/webkitwebview.cpp:
1347 * webkit/webkitwebview.h:
1349 2009-05-05 Xan Lopez <xlopez@igalia.com>
1351 Reviewed by Holger Freyther.
1355 * WebCoreSupport/EditorClientGtk.cpp:
1356 (WebKit::EditorClient::checkSpellingOfString):
1358 2009-05-02 Gustavo Noronha Silva <gns@gnome.org>
1360 Reviewed by Holger Freyther.
1362 https://bugs.webkit.org/show_bug.cgi?id=25466
1363 WebKitGtk+ 1.1.6 prints weird error messages in Liferea
1365 Use strlen instead of g_utf8_strlen when calculating the size of
1366 the data that is being given to webkit_web_frame_load_string to be
1367 loaded, so that we don't miss any of the content.
1369 * webkit/webkitwebframe.cpp:
1371 2009-05-01 Dimitri Glazkov <dglazkov@chromium.org>
1373 Unreviewed, bulid fix.
1375 Fix mis-applied patch.
1377 * WebCoreSupport/FrameLoaderClientGtk.cpp:
1378 (WebKit::FrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
1380 2009-05-01 Pavel Feldman <pfeldman@chromium.org>
1382 Reviewed by Timothy Hatcher.
1384 Add a FrameLoaderClient callback for the ResourceRetrievedByXMLHttpRequest.
1386 https://bugs.webkit.org/show_bug.cgi?id=25347
1388 * WebCoreSupport/FrameLoaderClientGtk.cpp:
1389 (WebKit::FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest):
1390 * WebCoreSupport/FrameLoaderClientGtk.h:
1392 2009-04-30 David Kilzer <ddkilzer@apple.com>
1394 Provide a mechanism to create a quirks delegate for HTMLParser
1396 Reviewed by David Hyatt.
1398 * WebCoreSupport/ChromeClientGtk.h:
1399 (WebKit::ChromeClient::createHTMLParserQuirks): Added. The
1400 default implementation of this factory method returns 0.
1402 2009-04-30 Pavel Feldman <pfeldman@chromium.org>
1404 Reviewed by Dimitri Glazkov.
1406 https://bugs.webkit.org/show_bug.cgi?id=25342
1407 Add MessageSource and MessageLevel parameters to the ChromeClient::addMessageToConsole.
1409 * WebCoreSupport/ChromeClientGtk.cpp:
1410 (WebKit::ChromeClient::addMessageToConsole):
1411 * WebCoreSupport/ChromeClientGtk.h:
1413 2009-04-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1415 Unreviewed. Update gtk-doc control and base sgml files for 1.1.6.
1417 * docs/webkitgtk-docs.sgml:
1418 * docs/webkitgtk-sections.txt:
1420 2009-04-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1422 Reviewed by Xan Lopez.
1424 Updated with news for the 1.1.6 release.
1428 2009-04-28 Xan Lopez <xlopez@igalia.com>
1430 Reviewed by Gustavo Noronha.
1432 Leave a bit of space from the previous page when advacing a whole
1433 page. This matches the behavior of our scrollbar scrolling code
1434 and is just nicer in general.
1436 * webkit/webkitwebview.cpp:
1438 2009-04-28 Xan Lopez <xlopez@igalia.com>
1440 Unreviewed: committed a few bits by mistake, remove them.
1442 * WebCoreSupport/EditorClientGtk.cpp:
1443 (WebKit::handleEditingKeyboardEvent):
1445 2009-04-28 Xan Lopez <xlopez@igalia.com>
1447 Reviewed by Gustavo Noronha.
1449 https://bugs.webkit.org/show_bug.cgi?id=16135
1450 [GTK] Support caret browsing
1452 Refactor keyboard event handling to work properly under caret
1453 browsing mode. Most of the code comes from the Windows port.
1455 * WebCoreSupport/EditorClientGtk.cpp:
1457 (WebKit::interpretKeyEvent):
1458 (WebKit::handleEditingKeyboardEvent):
1459 (WebKit::EditorClient::handleKeyboardEvent):
1461 2009-04-28 Xan Lopez <xlopez@igalia.com>
1463 Reviewed by Gustavo Noronha.
1465 https://bugs.webkit.org/show_bug.cgi?id=16135
1466 [GTK] Support caret browsing
1468 Based on a patch by Alp Toker.
1470 Add enable-caret-browsing setting to WebKitWebView.
1472 * webkit/webkitwebsettings.cpp:
1473 (_WebKitWebSettingsPrivate::):
1474 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
1475 (_WebKitWebSettingsPrivate::webkit_web_settings_set_property):
1476 (_WebKitWebSettingsPrivate::webkit_web_settings_get_property):
1477 (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
1478 * webkit/webkitwebview.cpp:
1480 2009-04-27 Gustavo Noronha Silva <gns@gnome.org>
1482 Reviewed by Xan Lopez.
1484 https://bugs.webkit.org/show_bug.cgi?id=25409
1485 [GTK] incorrectly fallsback on cancellation
1487 Check whether we should fallback also on didFailLoad, so that we
1488 don't get error pages showing up in parts of the content of some
1489 sites because of, for instance, location changes.
1491 * WebCoreSupport/FrameLoaderClientGtk.cpp:
1492 (WebKit::FrameLoaderClient::dispatchDidFailLoad):
1494 2009-04-27 Gustavo Noronha Silva <gns@gnome.org>
1496 Reviewed by Xan Lopez.
1498 https://bugs.webkit.org/show_bug.cgi?id=25409
1499 [GTK] incorrectly fallsback on cancellation
1501 Correctly handle cancellation and frame loading interruption
1502 caused by policy change. This also fixes
1503 fast/frames/location-change.html.
1505 * WebCoreSupport/FrameLoaderClientGtk.cpp:
1506 (WebKit::FrameLoaderClient::shouldFallBack):
1508 2009-04-26 Xan Lopez <xlopez@igalia.com>
1510 Reviewed by Mark Rowe.
1514 * WebCoreSupport/FrameLoaderClientGtk.cpp:
1515 (WebKit::FrameLoaderClient::dispatchDidFailLoad):
1517 2009-04-26 Xan Lopez <xlopez@igalia.com>
1519 Reviewed by Gustavo Noronha.
1521 https://bugs.webkit.org/show_bug.cgi?id=25391
1522 G_SIGNAL_ACTION flag in WebKitWebView signals
1524 Most of the signals in WebKitGTK+ have the G_SIGNAL_ACTION flag,
1525 but I don't think this makes sense. The flag is meant for those
1526 signals that can be emitted by the user to trigger some action in
1527 the view, as if it were a normal API, which is not the case for
1530 * webkit/webkitdownload.cpp:
1531 (_WebKitDownloadPrivate::webkit_download_class_init):
1532 * webkit/webkitwebframe.cpp:
1533 * webkit/webkitwebinspector.cpp:
1534 (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init):
1535 * webkit/webkitwebview.cpp:
1537 2009-04-26 Xan Lopez <xlopez@igalia.com>
1539 Unreviewed, actually apply the right patch.
1541 * webkit/webkitwebview.cpp:
1542 (webkit_web_view_move_cursor):
1544 2009-04-26 Xan Lopez <xlopez@igalia.com>
1546 Reviewed by Gustavo Noronha.
1548 Pass a variable to hold the return value of the 'move-cursor'
1549 signal, otherwise a crash can happen.
1551 * webkit/webkitwebview.cpp:
1552 (webkit_web_view_move_cursor):
1554 2009-04-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1556 Reviewed by Xan Lopez.
1558 https://bugs.webkit.org/show_bug.cgi?id=24786
1559 WebKitDownload sometimes suggests peculiar filenames
1561 Refactor the emission of the download-requested signal so that we
1562 have less code duplication.
1564 * WebCoreSupport/ContextMenuClientGtk.cpp:
1565 (WebKit::ContextMenuClient::downloadURL):
1566 * WebCoreSupport/FrameLoaderClientGtk.cpp:
1567 (WebKit::FrameLoaderClient::startDownload):
1568 * webkit/webkitprivate.h:
1569 * webkit/webkitwebview.cpp:
1571 2009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org>
1573 Reviewed by Xan Lopez.
1575 [GTK] Error reporting
1576 https://bugs.webkit.org/show_bug.cgi?id=18344
1578 Update FrameLoad errors to use WebKitErrors.
1580 * WebCoreSupport/FrameLoaderClientGtk.cpp:
1581 (WebKit::FrameLoaderClient::cancelledError):
1582 (WebKit::FrameLoaderClient::blockedError):
1583 (WebKit::FrameLoaderClient::cannotShowURLError):
1584 (WebKit::FrameLoaderClient::interruptForPolicyChangeError):
1585 (WebKit::FrameLoaderClient::cannotShowMIMETypeError):
1586 (WebKit::FrameLoaderClient::fileDoesNotExistError):
1587 (WebKit::FrameLoaderClient::pluginWillHandleLoadError):
1588 (WebKit::FrameLoaderClient::shouldFallBack):
1589 * webkit/webkiterror.h: Added.
1590 * webkit/webkiterror.cpp: Added.
1592 2009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org>
1594 Reviewed by Xan Lopez.
1596 [GTK] Error reporting
1597 https://bugs.webkit.org/show_bug.cgi?id=18344
1599 Display a default error page for load errors.
1601 * WebCoreSupport/FrameLoaderClientGtk.cpp:
1602 (WebKit::FrameLoaderClient::dispatchDidFailLoad):
1603 * resources/error.html: Added.
1605 2009-04-25 Jan Michael Alonzo <jmalonzo@webkit.org>
1607 Reviewed by Xan Lopez.
1609 [GTK] Error reporting
1610 https://bugs.webkit.org/show_bug.cgi?id=18344
1612 Add a WebKitWebFrame API to load alternate content for unreachable URLs.
1613 Also add a new signal "load-error" for handling load errors.
1615 * WebCoreSupport/FrameLoaderClientGtk.cpp:
1616 (WebKit::FrameLoaderClient::postProgressFinishedNotification):
1617 (WebKit::FrameLoaderClient::dispatchDidFailLoading):
1618 (WebKit::FrameLoaderClient::dispatchDidFailProvisionalLoad):
1619 (WebKit::FrameLoaderClient::dispatchDidFailLoad):
1620 * webkit/webkitwebframe.cpp:
1621 * webkit/webkitwebframe.h:
1622 * webkit/webkitwebview.cpp:
1624 2009-04-24 Jan Michael Alonzo <jmalonzo@webkit.org>
1626 Rubber-stamped by Gustavo Noronha.
1628 Fix braces to comply with style guidelines.
1630 * WebCoreSupport/PasteboardHelperGtk.cpp:
1631 (WebKit::PasteboardHelperGtk::getClipboard):
1632 (WebKit::PasteboardHelperGtk::getCopyTargetList):
1633 (WebKit::PasteboardHelperGtk::getPasteTargetList):
1635 2009-04-24 Sergio GarcÃa-Cuevas <sergio_gcg@telefonica.net>
1637 Reviewed by Gustavo Noronha.
1639 https://bugs.webkit.org/show_bug.cgi?id=17267
1640 [GTK] Primary selection/clipboard support
1642 Add a method for getting the primary selection.
1644 * WebCoreSupport/PasteboardHelperGtk.cpp:
1645 (WebKit::PasteboardHelperGtk::getPrimary):
1646 * WebCoreSupport/PasteboardHelperGtk.h:
1648 2009-04-24 Johan Bilien <jobi@via.ecp.fr>
1650 Reviewed by Xan Lopez.
1652 https://bugs.webkit.org/show_bug.cgi?id=25373
1653 Popup menu has the wrong size when popped up near the edge
1656 * webkit/webkitwebview.cpp:
1657 (webkit_web_view_forward_context_menu_event): Let GTK place
1658 the popup menu instead of trying to do better and failing
1660 2009-04-24 Christian Dywan <christian@twotoasts.de>
1662 Rubber-stamped by Gustavo Noronha.
1664 * webkit/webkitwebsettings.cpp:
1665 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init): Reword the
1666 description of the enable-spell-checking property and correct the
1667 mentioning of the default language used.
1669 2009-04-24 Diego Escalante Urrelo <diegoe@gnome.org>
1671 Reviewed by Gustavo Noronha.
1673 https://bugs.webkit.org/show_bug.cgi?id=15616
1674 [GTK] Add spell checking
1676 Implement EditorClient::ignoreWordInSpellDocument,
1677 EditorClient::learnWord and EditorClient::getGuessesForWord. This
1678 enables the corresponding user actions.
1680 * WebCoreSupport/EditorClientGtk.cpp:
1681 (WebKit::EditorClient::ignoreWordInSpellDocument):
1682 (WebKit::EditorClient::learnWord):
1683 (WebKit::EditorClient::getGuessesForWord):
1685 2009-04-24 Diego Escalante Urrelo <diegoe@gnome.org>
1687 Reviewed by Gustavo Noronha.
1689 https://bugs.webkit.org/show_bug.cgi?id=15616
1690 [GTK] Add spell checking
1692 Implement EditorClient::checkSpellingOfString; enabling spell checking
1693 to actually happen, this is the basis for other spelling functions.
1695 * WebCoreSupport/EditorClientGtk.cpp:
1696 (WebKit::EditorClient::checkSpellingOfString):
1698 2009-04-24 Diego Escalante Urrelo <diegoe@gnome.org>
1700 Reviewed by Gustavo Noronha.
1702 https://bugs.webkit.org/show_bug.cgi?id=15616
1703 [GTK] Add spell checking
1705 Add spell-checking-languages property to WebKitWebSettings.
1707 * webkit/webkitprivate.h:
1708 * webkit/webkitwebsettings.cpp:
1709 (_WebKitWebSettingsPrivate::):
1710 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
1711 (_WebKitWebSettingsPrivate::webkit_web_settings_init):
1712 (_WebKitWebSettingsPrivate::webkit_web_settings_finalize):
1713 (_WebKitWebSettingsPrivate::webkit_web_settings_set_property):
1714 (_WebKitWebSettingsPrivate::webkit_web_settings_get_property):
1715 (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
1716 (_WebKitWebSettingsPrivate::webkit_web_settings_get_spell_languages):
1718 2009-04-24 Diego Escalante Urrelo <diegoe@gnome.org>
1720 Reviewed by Gustavo Noronha.
1722 https://bugs.webkit.org/show_bug.cgi?id=15616
1723 [GTK] Add spell checking
1725 Add enable-spell-checking property to WebKitWebSettings and implement
1726 EditorClient::isContinuousSpellCheckingEnabled and
1727 EditorClient::toggleContinuousSpellChecking to allow the UI to
1728 enable check as you type spell checking.
1730 * WebCoreSupport/EditorClientGtk.cpp:
1731 (WebKit::EditorClient::isContinuousSpellCheckingEnabled):
1732 (WebKit::EditorClient::toggleContinuousSpellChecking):
1733 * webkit/webkitwebsettings.cpp:
1734 (_WebKitWebSettingsPrivate::):
1735 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
1736 (_WebKitWebSettingsPrivate::webkit_web_settings_set_property):
1737 (_WebKitWebSettingsPrivate::webkit_web_settings_get_property):
1738 (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
1740 2009-04-21 Xan Lopez <xlopez@igalia.com>
1742 Reviewed by Gustavo Noronha.
1744 https://bugs.webkit.org/show_bug.cgi?id=21546
1745 [GTK] ATK accessibility enhancements
1747 Implement window<->screen coordinate transformation functions.
1749 * WebCoreSupport/ChromeClientGtk.cpp:
1750 (WebKit::widgetScreenPosition):
1751 (WebKit::ChromeClient::windowToScreen):
1752 (WebKit::ChromeClient::screenToWindow):
1754 2009-04-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1756 Reviewed by Xan Lopez.
1758 https://bugs.webkit.org/show_bug.cgi?id=24786
1759 WebKitDownload sometimes suggests peculiar filenames
1761 Remove query and ref from the URI that is to be downloaded when
1762 using it to provide a file name suggestion.
1764 * webkit/webkitdownload.cpp:
1765 (_WebKitDownloadPrivate::webkit_download_set_property):
1767 2009-04-20 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1769 Reviewed by Xan Lopez.
1771 Handle the case when the plugin view is destroyed during
1772 didReceiveResponse, to avoid crashing.
1774 * WebCoreSupport/FrameLoaderClientGtk.cpp:
1775 (WebKit::FrameLoaderClient::committedLoad):
1777 2009-04-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1779 Reviewed by Alexey Proskuryakov.
1781 https://bugs.webkit.org/show_bug.cgi?id=25251
1782 Crash when frame creation removes it from the parent
1784 This brings us up-to-date with the expectations of sub-frame
1785 creation, following what Mac has done. It fixes crashes when
1786 calling init on the child frame removes it from the page.
1788 This makes the following test pass instead of crash:
1790 fast/loader/frame-creation-removal.html
1792 * WebCoreSupport/FrameLoaderClientGtk.cpp:
1793 (WebKit::FrameLoaderClient::createFrame):
1795 2009-04-16 Christian Dywan <christian@twotoasts.de>
1797 Reviewed by Holger Freyther.
1799 http://bugs.webkit.org/show_bug.cgi?id=25042
1800 destroying webview widget directly causes crash.
1802 * tests/testwebframe.c:
1803 (test_webkit_web_frame_create_destroy): Add a test case for destroying
1804 a web view shortly after packing it in a window.
1806 2009-04-16 Xan Lopez <xlopez@igalia.com>
1808 Reviewed by Sam Weinig.
1810 https://bugs.webkit.org/show_bug.cgi?id=25241
1811 Remove superfluous NotImplemented.h includes.
1813 * webkit/webkitprivate.cpp:
1815 2009-04-14 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1817 Unreviewed. Update gtk-doc control and base sgml files for 1.1.5.
1819 * docs/webkitgtk-docs.sgml:
1820 * docs/webkitgtk-sections.txt:
1822 2009-04-14 Xan Lopez <xlopez@igalia.com>
1824 * NEWS: updated for 1.1.5 release.
1826 2009-04-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1828 Reviewed by Holger Freyther.
1830 https://bugs.webkit.org/show_bug.cgi?id=22898
1831 [GTK] need proper API for printing
1833 Added simple printing unit tests.
1835 * tests/testwebframe.c:
1836 (print_requested_cb):
1838 (test_webkit_web_frame_printing):
1841 2009-04-13 Gustavo Noronha Silva <gns@gnome.org>
1843 Reviewed by Holger Freyther.
1845 https://bugs.webkit.org/show_bug.cgi?id=22898
1846 [GTK] need proper API for printing
1848 Implement proper printing API, using the GTK+ printing API.
1850 * WebCoreSupport/ChromeClientGtk.cpp:
1851 (WebKit::ChromeClient::print):
1852 * webkit/webkitprivate.h:
1853 * webkit/webkitwebframe.cpp:
1854 * webkit/webkitwebframe.h:
1855 * webkit/webkitwebview.cpp:
1857 2009-04-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1859 Reviewed by Holger Freyther.
1861 https://bugs.webkit.org/show_bug.cgi?id=25124
1862 [GTK] many strings still missing translation calls
1864 Mark the missing strings for translation.
1866 * webkit/webkitdownload.cpp:
1867 (_WebKitDownloadPrivate::webkit_download_cancel):
1868 * webkit/webkitsoupauthdialog.c:
1870 * webkit/webkitwebhistoryitem.cpp:
1871 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_class_init):
1872 * webkit/webkitwebinspector.cpp:
1873 (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init):
1874 * webkit/webkitwebnavigationaction.cpp:
1875 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_class_init):
1876 * webkit/webkitwebsettings.cpp:
1877 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
1878 * webkit/webkitwebview.cpp:
1880 2009-04-08 Alejandro Piñeiro <apinheiro@igalia.com>
1882 Reviewed by Holger Freyther.
1884 https://bugs.webkit.org/show_bug.cgi?id=21546
1885 [GTK] ATK accessibility enhancements
1887 Use getOrCreate instead of just get, as we need to actually create
1888 the wrapper object the first time this function is called.
1890 * webkit/webkitwebview.cpp:
1892 2009-04-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1894 Rubber-stamped by Sam Weinig.
1896 https://bugs.webkit.org/show_bug.cgi?id=20575
1897 No localization in WebKitGtk
1899 Implemented localization support for WebKitGTK+.
1901 * WebCoreSupport/ChromeClientGtk.cpp:
1902 * WebCoreSupport/ContextMenuClientGtk.cpp:
1903 * po/POTFILES: Added.
1905 * po/webkit.pot: Added.
1906 * webkit/webkitdownload.cpp:
1907 (_WebKitDownloadPrivate::webkit_download_class_init):
1908 * webkit/webkitprivate.cpp:
1910 * webkit/webkitwebframe.cpp:
1912 2009-04-05 Xan Lopez <xlopez@igalia.com>
1914 Reviewed by Holger Freyther.
1916 https://bugs.webkit.org/show_bug.cgi?id=25042
1917 destroying webview widget directly causes crash.
1919 Do not connect the WebView to its own screen-changed signal, set a
1920 default handler instead.
1922 * webkit/webkitwebview.cpp:
1924 2009-04-05 Xan Lopez <xlopez@igalia.com>
1926 Reviewed by Holger Freyther.
1928 https://bugs.webkit.org/show_bug.cgi?id=25042
1929 destroying webview widget directly causes crash.
1931 GtkWidget::screen-changed can be emitted when a widget is being
1932 destroyed, protect against it.
1934 * webkit/webkitwebview.cpp:
1936 2009-04-05 Jan Michael Alonzo <jmalonzo@webkit.org>
1938 Reviewed by Holger Freyther.
1940 [Gtk] Implement LayoutTestControllerGtk::setPrivateBrowsingEnabled
1941 https://bugs.webkit.org/show_bug.cgi?id=24487
1943 Updated documentation and put more information about the
1944 private-browsing setting for WebKitGtk.
1946 * webkit/webkitwebsettings.cpp:
1947 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
1949 2009-04-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1951 Reviewed by Holger Freyther.
1953 Remove pre-processor checks for GTK+ >= 2.10, since we now require
1954 at least that version.
1956 * WebCoreSupport/EditorClientGtk.cpp:
1957 (WebKit::clipboard_clear_contents_cb):
1958 (WebKit::EditorClient::respondToChangedSelection):
1959 * webkit/webkitwebframe.cpp:
1960 * webkit/webkitwebview.cpp:
1962 2009-04-02 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1964 Reviewed by Alexey Proskuryakov.
1966 https://bugs.webkit.org/show_bug.cgi?id=24844
1967 Unit test WebKitDownload
1969 Extra checks to avoid crashing and a critical message when
1970 property accessor functions are called before the download is
1973 * webkit/webkitdownload.cpp:
1974 (_WebKitDownloadPrivate::webkit_download_get_progress):
1975 (_WebKitDownloadPrivate::webkit_download_get_elapsed_time):
1977 2009-04-01 Christian Dywan <christian@twotoasts.de>
1979 Reviewed by Holger Freyther.
1981 * tests/testdownload.c: Added.
1982 (test_webkit_download_create):
1983 (main): Add an initial unit test for downloading.
1985 2009-04-01 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1987 Unreviewed typo fixes, and naming normalization in the
1990 * docs/webkitenvironment.xml:
1991 * webkit/webkitwebview.cpp:
1993 2009-03-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1995 Reviewed by Holger Freyther.
1997 Updated gtk-doc configuration files for the 1.1.1, 1.1.2, 1.1.3,
1998 and 1.1.4 versions of WebKitGTK+.
2000 * docs/webkitgtk-docs.sgml:
2001 * docs/webkitgtk-sections.txt:
2003 2009-03-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
2005 Reviewed by Holger Freyther.
2007 https://bugs.webkit.org/show_bug.cgi?id=17045
2010 Added header documentation for WebKitWebNavigationAction and
2011 WebKitWebPolicyDecision.
2013 Added missing documentation pieces for WebKitSoupAuthDialog,
2014 WebKitDownload and WebKitWebPolicyDecision.
2016 Wrote a section about using the WEBKIT_DEBUG environment variable.
2018 * docs/GNUmakefile.am:
2019 * docs/webkitenvironment.xml: Added.
2020 * docs/webkitgtk-docs.sgml:
2021 * webkit/webkitdownload.cpp:
2022 * webkit/webkitsoupauthdialog.c:
2023 * webkit/webkitwebnavigationaction.cpp:
2024 * webkit/webkitwebpolicydecision.cpp:
2026 2009-03-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
2028 Reviewed by Holger Freyther.
2030 Integrate gtk-doc into the Gtk+ buildsystem.
2032 Based on original work by Holger Freyther.
2034 Integrate gtk-doc into our buildsystem. We are forced to
2035 use recursive make for gtk-doc itself as the to be installed
2036 gtk-doc.make (done by gtkdocize) is not working in a non
2037 recursive environment.
2039 The documentation can only be generated when srcdir == builddir.
2040 In all other cases the generated files will not be found. This
2041 limitation can be found in pango and gtk+ as well. There is no
2042 easy way around. The resulting html documentation will be saved
2043 in the srcdir as well.
2045 * docs/GNUmakefile.am: Added.
2046 * docs/version.xml.in: Added.
2047 * docs/webkitgtk-docs.sgml:
2049 2009-03-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
2051 Unreviewed. Documenting what changed since the 1.1.3 release, in
2056 2009-03-30 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
2058 Unreviewed. Add information on the bug-fix-only 1.1.3 release.
2062 2009-03-30 Xan Lopez <xlopez@igalia.com>
2064 Reviewed by Holger Freyther.
2066 https://bugs.webkit.org/show_bug.cgi?id=24878
2067 [GTK] Use GtkBinding system to handle key events in WebView
2069 Use GtkBinding system for key events in WebKitWebView. Allows the
2070 user to reconfigure the bindings and fixes a bunch of bugs along
2071 the way (we were not checking modifier keys in most actions).
2073 * webkit/webkitwebview.cpp:
2074 (webkit_web_view_move_cursor):
2075 * webkit/webkitwebview.h:
2076 * webkitmarshal.list:
2078 2009-03-28 Xan Lopez <xlopez@igalia.com>
2080 Reviewed by Mark Rowe.
2082 https://bugs.webkit.org/show_bug.cgi?id=24790
2083 [GTK] webkitsoupauthdialog.h lacks WEBKIT_API before function
2085 Set the right visibility to the WebKitSoupAuthDialog get_type
2088 * webkit/webkitsoupauthdialog.h:
2090 2009-03-28 Jan Michael Alonzo <jmalonzo@webkit.org>
2092 Gtk build fix. Not reviewed.
2094 FrameLoader::loadURL and FrameLoader::detachChildren went private
2095 per changes in http://trac.webkit.org/changeset/42055. Follow
2096 Mac's behaviour and use FrameLoader::loadURLIntoChildFrame for
2097 loadURL and FrameLoader::detachParent for detachChildrem.
2099 * WebCoreSupport/FrameLoaderClientGtk.cpp:
2100 (WebKit::FrameLoaderClient::createFrame):
2101 * webkit/webkitwebview.cpp:
2103 2009-03-25 Gustavo Noronha Silva <gns@gnome.org>
2105 Reviewed by Holger Freyther.
2107 https://bugs.webkit.org/show_bug.cgi?id=15793
2108 [GTK] tooltip position doesn't update when hovering consecutive links
2110 Work-around tooltips not updating their location when the elements
2111 are consecutive, by clearing the tooltip when handling
2112 mouseDidMoveOverElement.
2114 * WebCoreSupport/ChromeClientGtk.cpp:
2115 (WebKit::ChromeClient::mouseDidMoveOverElement):
2117 2009-03-23 Alejandro Garcia Castro <alex@igalia.com>
2119 Reviewed by Holger Freyther.
2121 [Gtk] Current API does not allow us to open target="_blank" links
2122 in new tabs instead of windows
2123 https://bugs.webkit.org/show_bug.cgi?id=23932
2125 Added a signal to the API (new-window-policy-decision-requested)
2126 that allows the browser to decide the policy for the new window
2127 request, if the signal is not handled we open the new window as
2130 * WebCoreSupport/FrameLoaderClientGtk.cpp:
2131 (WebKit::getNavigationAction):
2132 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2133 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2134 * webkit/webkitwebview.cpp:
2136 2009-03-20 Jan Michael Alonzo <jmalonzo@gmail.com>
2138 Not reviewed. Fix style issues with my previous commit (r41866) as
2139 suggested by Holger in https://bugs.webkit.org/show_bug.cgi?id=24493
2141 * tests/testwebhistoryitem.c:
2142 (test_webkit_web_history_item_get_data):
2143 (test_webkit_web_history_item_alternate_title):
2145 2009-03-20 Jan Michael Alonzo <jmalonzo@gmail.com>
2147 Reviewed by Holger Freyther.
2149 [GTK] Misc patches for WebKitWebHistoryItem
2150 https://bugs.webkit.org/show_bug.cgi?id=24493
2152 Add unit test for WebKitWebHistoryItem
2154 * tests/testwebhistoryitem.c: Added.
2155 (web_history_item_fixture_setup):
2156 (web_history_item_fixture_teardown):
2157 (test_webkit_web_history_item_get_data):
2158 (test_webkit_web_history_item_alternate_title):
2161 2009-03-20 Jan Michael Alonzo <jmalonzo@gmail.com>
2163 Reviewed by Holger Freyther.
2165 Separate gtk unit tests
2166 https://bugs.webkit.org/show_bug.cgi?id=24039
2168 Split the current single-file unit test to make it more
2169 modularized and manageable in the future as more unit tests are
2172 * tests/main.c: Removed.
2173 * tests/testwebbackforwardlist.c: Copied from WebKit/gtk/tests/main.c.
2175 * tests/testwebframe.c: Copied from WebKit/gtk/tests/main.c.
2178 2009-03-16 Christian Dywan <christian@twotoasts.de>
2180 Reviewed by Adam Roben.
2182 [gtk] API implementation: url and title
2183 http://bugs.webkit.org/show_bug.cgi?id=14807
2185 * WebCoreSupport/FrameLoaderClientGtk.cpp:
2186 (WebKit::FrameLoaderClient::dispatchDidChangeLocationWithinPage):
2187 (WebKit::FrameLoaderClient::dispatchDidReceiveTitle):
2188 (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
2189 * webkit/webkitwebview.cpp:
2190 * webkit/webkitwebview.h: Implement "title" and "uri" properties as well
2191 as according functions. "uri" always reflects the current location
2192 including navigation inside the same page. title-changed is deprecated.
2194 2009-03-15 Gustavo Noronha Silva <gns@gnome.org>
2196 Reviewed by Anders Carlsson.
2198 Fix default policy decision to be ignore, on MIME checks, if
2199 WebKit doesn't know how to handle the MIME type. The documentation
2200 is already correct, and this was an oversight when the policy
2201 decision code was first committed. Since 1.1.2 will be the first
2202 release to support download, there is no practical change in
2205 * WebCoreSupport/FrameLoaderClientGtk.cpp:
2206 (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType):
2208 2009-03-15 Xan Lopez <xlopez@igalia.com>
2210 * NEWS: update for 1.1.2.
2212 2009-03-14 Jan Michael Alonzo <jmalonzo@webkit.org>
2214 Reviewed by Holger Freyther.
2216 [GTK] use of confirm dialog (yes/no) causes segfault
2217 https://bugs.webkit.org/show_bug.cgi?id=20940
2219 Change the script-confirm marshaller from OBJECT,STRING,BOOLEAN to
2220 OBJECT,STRING,POINTER
2222 * webkit/webkitwebview.cpp:
2223 * webkitmarshal.list:
2225 2009-03-12 Gustavo Noronha Silva <gns@gnome.org>
2227 Reviewed by Alexey Proskuryakov.
2229 https://bugs.webkit.org/show_bug.cgi?id=24553
2230 [GTK] Improvements to WebKitDownload
2232 Rename 'state' to 'status' to match the naming in the frame
2233 loader rework that we plan to land soonish, and make it a
2234 property, for the same reason.
2236 * webkit/webkitdownload.cpp:
2237 (_WebKitDownloadPrivate::):
2238 (_WebKitDownloadPrivate::webkit_download_finalize):
2239 (_WebKitDownloadPrivate::webkit_download_get_property):
2240 (_WebKitDownloadPrivate::webkit_download_set_property):
2241 (_WebKitDownloadPrivate::webkit_download_class_init):
2242 (_WebKitDownloadPrivate::webkit_download_init):
2243 (_WebKitDownloadPrivate::webkit_download_start):
2244 (_WebKitDownloadPrivate::webkit_download_cancel):
2245 (_WebKitDownloadPrivate::webkit_download_set_destination_uri):
2246 (_WebKitDownloadPrivate::webkit_download_get_status):
2247 (_WebKitDownloadPrivate::webkit_download_set_status):
2248 (_WebKitDownloadPrivate::webkit_download_received_data):
2249 (_WebKitDownloadPrivate::webkit_download_finished_loading):
2250 (_WebKitDownloadPrivate::webkit_download_error):
2251 * webkit/webkitdownload.h:
2253 2009-03-12 Gustavo Noronha Silva <gns@gnome.org>
2255 Reviewed by Alexey Proskuryakov.
2257 https://bugs.webkit.org/show_bug.cgi?id=24553
2258 [GTK] Improvements to WebKitDownload
2260 Improved documentation for the download-requested signal, to make
2263 * webkit/webkitwebview.cpp:
2265 2009-03-12 Gustavo Noronha Silva <gns@gnome.org>
2267 Reviewed by Alp Toker.
2269 https://bugs.webkit.org/show_bug.cgi?id=24541
2270 Scrolling with home and end keys not always works
2272 Also make page up and page down keys be handled by the webview key
2273 event code, so that they also work in cases where the GTK+
2274 scrollbars don't handle them directly, like in the bugzill's patch
2277 * webkit/webkitwebview.cpp:
2279 2009-03-12 Gustavo Noronha Silva <gns@gnome.org>
2281 Reviewed by Alp Toker.
2283 https://bugs.webkit.org/show_bug.cgi?id=24541
2284 Scrolling with home and end keys not always works
2286 Make home and end keys behave more consistently for scrolling the
2289 * webkit/webkitwebview.cpp:
2291 2009-03-12 Gustavo Noronha Silva <gns@gnome.org>
2293 Reviewed by Alp Toker.
2295 https://bugs.webkit.org/show_bug.cgi?id=24254
2296 [GTK] spacebar doesn't scroll down
2298 Make spacebar and shift+spacebar scroll like page up and down
2301 * webkit/webkitwebview.cpp:
2303 2009-03-10 Xan Lopez <xlopez@igalia.com>
2305 Reviewed by Holger Freyther.
2307 https://bugs.webkit.org/show_bug.cgi?id=24493
2308 [GTK] Misc patches for WebKitWebHistoryItem
2310 Only run code in dispose once per instance.
2312 * webkit/webkitwebhistoryitem.cpp:
2313 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose):
2315 2009-03-10 Xan Lopez <xlopez@igalia.com>
2317 Reviewed by Holger Freyther.
2319 https://bugs.webkit.org/show_bug.cgi?id=24493
2320 [GTK] Misc patches for WebKitWebHistoryItem
2322 Call deref() on our internal HistoryItem on dispose, as we always
2323 acquire it with a releaseRef() call to a PassRefPtr, which passes
2326 * webkit/webkitwebhistoryitem.cpp:
2327 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose):
2329 2009-03-10 Xan Lopez <xlopez@igalia.com>
2331 Reviewed by Holger Freyther.
2333 https://bugs.webkit.org/show_bug.cgi?id=24493
2334 [GTK] Misc patches for WebKitWebHistoryItem
2336 return foo? foo : NULL == return foo
2338 * webkit/webkitwebhistoryitem.cpp:
2341 2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>
2343 Reviewed by Holger Freyther.
2345 Gtk] Implement LayoutTestControllerGtk::setPrivateBrowsingEnabled
2346 https://bugs.webkit.org/show_bug.cgi?id=24487
2348 Add private browsing option "enable-private-browsing" to WebKitWebSettings.
2350 * webkit/webkitwebsettings.cpp:
2351 (_WebKitWebSettingsPrivate::):
2352 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
2353 (_WebKitWebSettingsPrivate::webkit_web_settings_set_property):
2354 (_WebKitWebSettingsPrivate::webkit_web_settings_get_property):
2355 (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
2356 * webkit/webkitwebview.cpp:
2358 2009-03-11 Jan Michael Alonzo <jmalonzo@webkit.org>
2360 Reviewed by Holger Freyther.
2362 [GTK] BackForward history leak?
2363 https://bugs.webkit.org/show_bug.cgi?id=19528
2365 Don't ref the history items when returning the back/forward list
2366 Added test_webkit_web_history_item_lifetime test case for this.
2369 (test_webkit_web_history_item_lifetime):
2370 (test_webkit_web_back_forward_list_order): Style fix.
2371 (test_webkit_web_back_forward_list_add_item): Style fix.
2373 * webkit/webkitwebbackforwardlist.cpp:
2374 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_list_with_limit):
2375 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_back_list_with_limit):
2377 2009-03-10 Xan Lopez <xlopez@igalia.com>
2379 Reviewed by Alexey Proskuryakov.
2381 https://bugs.webkit.org/show_bug.cgi?id=24493
2382 [GTK] Misc patches for WebKitWebHistoryItem
2384 Use g_hash_table_new_full so we can save the manual unref on the
2385 values when removing them from the table.
2387 * webkit/webkitwebhistoryitem.cpp:
2388 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_dispose):
2390 2009-03-10 Xan Lopez <xan@gnome.org>
2392 Reviewed by Alexey Proskuryakov.
2394 https://bugs.webkit.org/show_bug.cgi?id=24493
2395 [GTK] Misc patches for WebKitWebHistoryItem
2397 Use 'if (foo)' instead of 'if (foo != NULL)', per coding style
2400 * webkit/webkitwebhistoryitem.cpp:
2401 (_WebKitWebHistoryItemPrivate::webkit_history_item_remove):
2402 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_title):
2403 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_alternate_title):
2404 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_uri):
2405 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_original_uri):
2406 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_last_visited_time):
2407 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_target):
2408 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_is_target_item):
2409 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_children):
2411 2009-03-10 Xan Lopez <xlopez@igalia.com>
2413 Reviewed by Alexey Proskuryakov.
2415 Correct return value to false instead of NULL.
2417 * webkit/webkitwebhistoryitem.cpp:
2418 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_is_target_item):
2420 2009-03-08 Holger Hans Peter Freyther <zecke@selfish.org>
2422 Reviewed by Mark Rowe.
2424 Add javascript-profiling-enabled property and implement it. This
2425 will enable/disable the profiler on the InstpectorController.
2427 * webkit/webkitprivate.h:
2428 * webkit/webkitwebinspector.cpp:
2429 (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init):
2430 (_WebKitWebInspectorPrivate::webkit_web_inspector_set_property):
2431 (_WebKitWebInspectorPrivate::webkit_web_inspector_get_property):
2432 (_WebKitWebInspectorPrivate::webkit_web_inspector_set_inspector_client):
2433 * webkit/webkitwebview.cpp:
2435 2009-03-05 Gustavo Noronha Silva <gns@gnome.org>
2439 https://bugs.webkit.org/show_bug.cgi?id=24295
2440 webkit_web_back_forward_list_add_item needs a Since tag
2442 Add missing Since tag to webkit_web_back_forward_list_add_item
2445 * webkit/webkitwebbackforwardlist.cpp:
2447 2009-03-05 Gustavo Noronha Silva <gns@gnome.org>
2449 Reviewed by Mark Rowe.
2451 https://bugs.webkit.org/show_bug.cgi?id=24417
2452 [GTK] WebKitDownload's _cancel and _dispose methods may emit warnings
2454 NULL-check for timer on _cancel and _dispose, to avoid bad
2457 * webkit/webkitdownload.cpp:
2458 (_WebKitDownloadPrivate::webkit_download_finalize):
2459 (_WebKitDownloadPrivate::webkit_download_cancel):
2461 2009-03-02 Xan Lopez <xan@gnome.org>
2463 Reviewed by Mark Rowe.
2465 https://bugs.webkit.org/show_bug.cgi?id=24287
2466 [GTK] Move auth dialog feature to WebKit/
2468 Add WebKitSoupAuthDialog and add it to the session in webkit_init.
2470 * webkit/webkitprivate.cpp:
2471 (currentToplevelCallback):
2473 * webkit/webkitsoupauthdialog.c: Added.
2474 (webkit_soup_auth_dialog_class_init):
2475 (webkit_soup_auth_dialog_init):
2476 (webkit_soup_auth_dialog_session_feature_init):
2478 (set_password_callback):
2479 (response_callback):
2482 (find_password_callback):
2483 (session_authenticate):
2485 * webkit/webkitsoupauthdialog.h: Added.
2487 2009-03-03 Gustavo Noronha Silva <gns@gnome.org>
2489 Reviewed by Alexey Proskuryakov.
2491 https://bugs.webkit.org/show_bug.cgi?id=16826
2492 [Gtk] Implement WebKitDownload
2494 Implement download, and provide a nice object wrapping the
2495 download process. Initial work done by Marco Barisione and
2496 Pierre-Luc Beaudoin for Collabora.
2498 * WebCoreSupport/ContextMenuClientGtk.cpp:
2499 (WebKit::ContextMenuClient::downloadURL):
2500 * WebCoreSupport/FrameLoaderClientGtk.cpp:
2501 (WebKit::FrameLoaderClient::download):
2502 (WebKit::FrameLoaderClient::startDownload):
2504 * webkit/webkitdefines.h:
2505 * webkit/webkitdownload.cpp: Added.
2506 (_WebKitDownloadPrivate::):
2507 (_WebKitDownloadPrivate::webkit_download_dispose):
2508 (_WebKitDownloadPrivate::webkit_download_finalize):
2509 (_WebKitDownloadPrivate::webkit_download_get_property):
2510 (_WebKitDownloadPrivate::webkit_download_set_property):
2511 (_WebKitDownloadPrivate::webkit_download_class_init):
2512 (_WebKitDownloadPrivate::webkit_download_init):
2513 (_WebKitDownloadPrivate::webkit_download_new):
2514 (_WebKitDownloadPrivate::webkit_download_open_stream_for_uri):
2515 (_WebKitDownloadPrivate::webkit_download_close_stream):
2516 (_WebKitDownloadPrivate::webkit_download_start):
2517 (_WebKitDownloadPrivate::webkit_download_cancel):
2518 (_WebKitDownloadPrivate::webkit_download_get_uri):
2519 (_WebKitDownloadPrivate::webkit_download_get_network_request):
2520 (_WebKitDownloadPrivate::webkit_download_set_response):
2521 (_WebKitDownloadPrivate::webkit_download_get_suggested_filename):
2522 (_WebKitDownloadPrivate::webkit_download_get_destination_uri):
2523 (_WebKitDownloadPrivate::webkit_download_set_destination_uri):
2524 (_WebKitDownloadPrivate::webkit_download_get_state):
2525 (_WebKitDownloadPrivate::webkit_download_get_total_size):
2526 (_WebKitDownloadPrivate::webkit_download_get_current_size):
2527 (_WebKitDownloadPrivate::webkit_download_get_progress):
2528 (_WebKitDownloadPrivate::webkit_download_get_elapsed_time):
2529 (_WebKitDownloadPrivate::webkit_download_received_data):
2530 (_WebKitDownloadPrivate::webkit_download_finished_loading):
2531 (_WebKitDownloadPrivate::webkit_download_error):
2532 (_WebKitDownloadPrivate::DownloadClient::DownloadClient):
2533 (_WebKitDownloadPrivate::DownloadClient::didReceiveResponse):
2534 (_WebKitDownloadPrivate::DownloadClient::didReceiveData):
2535 (_WebKitDownloadPrivate::DownloadClient::didFinishLoading):
2536 (_WebKitDownloadPrivate::DownloadClient::didFail):
2537 (_WebKitDownloadPrivate::DownloadClient::wasBlocked):
2538 (_WebKitDownloadPrivate::DownloadClient::cannotShowURL):
2539 * webkit/webkitdownload.h: Added.
2540 * webkit/webkitprivate.h:
2541 * webkit/webkitwebview.cpp:
2542 * webkitmarshal.list:
2544 2009-03-01 Jan Michael Alonzo <jmalonzo@webkit.org>
2546 Reviewed by Holger Freyther.
2548 [Gtk] get the HTTP layout tests going
2549 https://bugs.webkit.org/show_bug.cgi?id=24259
2551 Added API to get the response mime type from a frame. We need this
2552 so we can decide if we need to dump the frame as text or its
2555 * webkit/webkitprivate.h:
2556 * webkit/webkitwebframe.cpp:
2558 2009-03-01 Jan Michael Alonzo <jmalonzo@webkit.org>
2560 Reviewed by Holger Freyther.
2562 [Gtk] get the HTTP layout tests going
2563 https://bugs.webkit.org/show_bug.cgi?id=24259
2565 Create a WebKitWebHistoryItem for each WebCore::HistoryItem when
2567 Add necessary API additions for us to be able to dump a WebKitWebHistoryItem
2569 * webkit/webkitprivate.h:
2570 * webkit/webkitwebbackforwardlist.cpp:
2571 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_list_with_limit):
2572 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_back_list_with_limit):
2573 * webkit/webkitwebhistoryitem.cpp:
2574 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_core_item):
2575 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new):
2576 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_data):
2577 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_target):
2578 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_is_target_item):
2579 (_WebKitWebHistoryItemPrivate::webkit_web_history_item_get_children):
2583 2009-03-01 Christian Dywan <christian@twotoasts.de>
2585 Reviewed by Holger Freyther.
2587 * webkit/webkitprivate.h:
2588 * webkit/webkitwebview.cpp:
2589 (webkit_web_view_get_encoding):
2590 * webkit/webkitwebview.h: Implement 'encoding' and 'custom-encoding'
2591 properties as well as webkit_web_view_get_encoding.
2593 2009-03-01 Gustavo Noronha Silva <gns@gnome.org>
2595 Unreviewed simple wording fix for the NEWS file.
2599 2009-03-01 Xan Lopez <xan@gnome.org>
2601 Add NEWS file to track progress between releases.
2605 2009-02-28 Christian Dywan <christian@twotoasts.de>
2607 Reviewed by Holger Freyther.
2609 * webkit/webkitwebview.cpp: Let webkit_web_view_open add file:// if a
2610 locale path is passed for compatibility, since we used to support that.
2612 2009-02-27 Gustavo Noronha Silva <gns@gnome.org>
2614 Reviewed by David Hyatt.
2616 Automatically ignore empty requests to avoid crashing. This fixes
2617 the crash in fast/loader/empty-embed-src-attribute.html.
2619 * WebCoreSupport/FrameLoaderClientGtk.cpp:
2620 (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType):
2621 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2622 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2624 2009-02-27 Xan Lopez <xan@gnome.org>
2626 Reviewed by Alexey Proskuryakov.
2628 https://bugs.webkit.org/show_bug.cgi?id=24221
2629 [GTK] Do not emit load-finished when being disposed
2631 webkit_web_view_stop_load() is called from dispose() on
2632 WebKitWebView. This eventually calls postProgressFinishedNotification
2633 in FrameLoaderClientGtk, which emits load-finished. Add
2634 a 'disposing' flag to WebView that we can check here, so
2635 we avoid emitting signals on objects on their way to be
2636 destroyed. This fixes a bunch of critical warnings when
2637 closing a loading WebView.
2639 * WebCoreSupport/FrameLoaderClientGtk.cpp:
2640 (WebKit::FrameLoaderClient::postProgressFinishedNotification):
2641 * webkit/webkitprivate.h:
2642 * webkit/webkitwebview.cpp:
2644 2009-02-27 Xan Lopez <xan@gnome.org>
2646 Rubber-stamped by Alexey Proskuryakov.
2648 https://bugs.webkit.org/show_bug.cgi?id=24222
2649 [GTK] Remove checks for old glib versions
2651 libsoup, which is a hard dependency, needs at least glib 2.15.3,
2652 so remove all glib checks for versions older than that.
2654 * webkit/webkitwebview.cpp:
2656 2009-02-26 Xan Lopez <xan@gnome.org>
2658 Reviewed by Holger Freyther.
2660 https://bugs.webkit.org/show_bug.cgi?id=16947
2661 [GTK] Missing HTTP Auth challenge
2663 Add new marshalers list.
2665 * webkitmarshal.list: Added.
2667 2009-02-26 Xan Lopez <xan@gnome.org>
2669 Reviewed by Alexey Proskuryakov.
2671 https://bugs.webkit.org/show_bug.cgi?id=24193
2672 [GTK] Checkbuttons not activated with space
2674 Do not swallow key events with GtkIMContext for non-editable
2677 * WebCoreSupport/EditorClientGtk.cpp:
2678 (WebKit::EditorClient::handleInputMethodKeydown):
2680 2009-02-26 Xan Lopez <xan@gnome.org>
2682 Reviewed by Alexey Proskuryakov.
2684 https://bugs.webkit.org/show_bug.cgi?id=24103
2685 [GTK] Use correct return value for WebView button-release handler
2687 We are returning whatever the core code tells us it did, but this
2688 does not play well with the GTK+ model. GTK+ in general expects it
2689 will see a button-release if it saw a button-press and no
2690 motion/leave/etc events in between. EventHandler.cpp will, in some
2691 cases, not handle press but handle release, confusing the parent
2692 container of the WebView.
2694 As a workaround return always FALSE for button-release (this is
2695 the same than the Windows port does).
2697 * webkit/webkitwebview.cpp:
2699 2009-02-26 Xan Lopez <xan@gnome.org>
2701 Reviewed by Holger Freyther.
2703 https://bugs.webkit.org/show_bug.cgi?id=17585
2704 [gtk] get|set encoding api
2706 Add functions to get and set a custom encoding an a view.
2708 * webkit/webkitprivate.h:
2709 * webkit/webkitwebview.cpp:
2710 (webkit_web_view_set_custom_encoding):
2711 (webkit_web_view_get_custom_encoding):
2712 * webkit/webkitwebview.h:
2714 2009-02-23 Xan Lopez <xan@gnome.org>
2716 Reviewed by Alexey Proskuryakov.
2718 https://bugs.webkit.org/show_bug.cgi?id=22624
2719 [SOUP][GTK] Need API to get SoupSession from WebKit.
2721 Add API to get the default soup session.
2723 * webkit/webkitwebview.cpp:
2724 * webkit/webkitwebview.h:
2726 2009-02-23 Xan Lopez <xan@gnome.org>
2728 Reviewed by Alexey Proskuryakov.
2730 https://bugs.webkit.org/show_bug.cgi?id=22624
2731 [SOUP][GTK] Need API to get SoupSession from WebKit.
2733 Add soup dependency to pc file.
2737 2009-02-23 Jan Michael Alonzo <jmalonzo@webkit.org>
2739 Reviewed by Mark Rowe.
2741 [GTK] Back / Forward history menus are flipped
2742 https://bugs.webkit.org/show_bug.cgi?id=22694
2744 Don't call g_list_reverse when returning the back or forward list.
2747 (test_webkit_web_back_forward_list_order):
2749 * webkit/webkitwebbackforwardlist.cpp:
2750 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_forward_list_with_limit):
2751 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_get_back_list_with_limit):
2753 2009-02-17 Xan Lopez <xan@gnome.org>
2755 Rubber-stamped by Alexey Proskuryakov.
2757 Restoring change landed in r40715, which was accidentally undone
2760 * webkit/webkitwebframe.cpp:
2762 2009-02-12 Christian Dywan <christian@twotoasts.de>
2764 Reviewed by Holger Freyther.
2766 http://bugs.webkit.org/show_bug.cgi?id=17176
2767 [GTK] API: hovering-over-link and webkit_web_view_open /_load_foo
2769 * webkit/webkitwebframe.cpp:
2770 * webkit/webkitwebframe.h:
2771 * webkit/webkitwebview.cpp:
2772 * webkit/webkitwebview.h: Introduce webkit_web_frame_load_uri,
2773 webkit_web_frame_load_string, webkit_web_view_load_uri and
2774 webkit_web_view_load_request and unify implementations.
2776 2009-02-11 Dimitri Dupuis-latour <dupuislatour@apple.com>
2778 Stub out InspectorClient::hiddenPanels.
2780 Reviewed by Timothy Hatcher.
2782 * WebCoreSupport/InspectorClientGtk.cpp:
2783 (WebKit::InspectorClient::hiddenPanels):
2784 * WebCoreSupport/InspectorClientGtk.h:
2786 2009-02-07 Holger Hans Peter Freyther <zecke@selfish.org>
2788 Unreviewed build fix Use toNormalizedRange().
2790 * WebCoreSupport/EditorClientGtk.cpp:
2791 (WebKit::clipboard_get_contents_cb):
2793 2009-02-06 Geoffrey Garen <ggaren@apple.com>
2797 * WebCoreSupport/FrameLoaderClientGtk.cpp:
2798 (WebKit::FrameLoaderClient::updateGlobalHistoryRedirectLinks):
2799 * WebCoreSupport/FrameLoaderClientGtk.h:
2801 2009-02-06 Xan Lopez <xan@gnome.org>
2803 Reviewed by Holger Freyther.
2805 Reported by Daniel Macks.
2807 https://bugs.webkit.org/show_bug.cgi?id=20412
2809 Use positive numbers for the target info IDs, gtk_target_list_add
2810 casts them to 'guint'. Also just start them from 0, since the
2811 values are not relevant or magic in any way, they are just used as
2812 tokens for the user of the API.
2814 * webkit/webkitwebview.h:
2816 2009-02-06 Xan Lopez <xan@gnome.org>
2818 Reviewed by Alexey Proskuryakov.
2820 https://bugs.webkit.org/show_bug.cgi?id=23769
2822 Do not use empty ResourceError errors.
2824 Rather create bogus but non-null errors, since some codepaths
2825 expect these. For example, see DocumentLoader::mainReceivedError.
2827 * WebCoreSupport/FrameLoaderClientGtk.cpp:
2828 (WebKit::FrameLoaderClient::cancelledError):
2829 (WebKit::FrameLoaderClient::blockedError):
2830 (WebKit::FrameLoaderClient::cannotShowURLError):
2831 (WebKit::FrameLoaderClient::interruptForPolicyChangeError):
2832 (WebKit::FrameLoaderClient::cannotShowMIMETypeError):
2833 (WebKit::FrameLoaderClient::fileDoesNotExistError):
2834 (WebKit::FrameLoaderClient::pluginWillHandleLoadError):
2836 2009-02-06 Xan Lopez <xan@gnome.org>
2838 Reviewed by Alexey Proskuryakov.
2840 https://bugs.webkit.org/show_bug.cgi?id=23761
2842 Use two-arg KURL ctor.
2844 We are using the one-arg ctor currently, but:
2846 - It assumes the strings are already encoded, which is not
2847 necesarily the case for us.
2849 - The single-argument KURL ctors expect their input to already be
2850 the output of a previous KURL::parse call, so for the general
2851 case (ie, random user input) we need to use the two-arg ctor
2854 * webkit/webkitwebframe.cpp:
2855 * webkit/webkitwebview.cpp:
2857 2009-02-05 Aaron Boodman <aa@chromium.org>
2859 Reviewed by Dave Hyatt.
2861 https://bugs.webkit.org/show_bug.cgi?id=23708
2862 Adds documentElementAvailable() callback to FrameLoaderClient.
2864 * WebCoreSupport/FrameLoaderClientGtk.cpp:
2865 (WebKit::FrameLoaderClient::documentElementAvailable):
2866 Stub out documentElementAvailable()
2867 * WebCoreSupport/FrameLoaderClientGtk.h:
2870 2009-02-03 Hiroyuki Ikezoe <poincare@ikezoe.net>
2872 Reviewed by Holger Freyther.
2874 https://bugs.webkit.org/show_bug.cgi?id=22988
2875 [GTK] Need a public method to add a WebKitWebHistoryItem to
2876 WebKitWebBackForwardList.
2878 Wrap WebCore::BackForwardList::addItem.
2881 (test_webkit_web_back_forward_list_add_item):
2883 * webkit/webkitwebbackforwardlist.cpp:
2884 (_WebKitWebBackForwardListPrivate::webkit_web_back_forward_list_add_item):
2885 * webkit/webkitwebbackforwardlist.h:
2887 2009-02-02 Geoffrey Garen <ggaren@apple.com>
2891 * webkit/webkitwebview.cpp:
2893 2009-02-02 Geoffrey Garen <ggaren@apple.com>
2897 * webkit/webkitwebframe.cpp:
2899 2009-02-02 Geoffrey Garen <ggaren@apple.com>
2903 * WebCoreSupport/FrameLoaderClientGtk.cpp:
2904 (WebKit::FrameLoaderClient::createFrame):
2906 2009-02-02 Geoffrey Garen <ggaren@apple.com>
2908 Reviewed by Sam Weinig.
2910 Track redirects in global history.
2914 * WebCoreSupport/FrameLoaderClientGtk.cpp:
2915 (WebKit::FrameLoaderClient::createFrame):
2916 (WebKit::FrameLoaderClient::updateGlobalHistoryForRedirectWithoutHistoryItem):
2917 * WebCoreSupport/FrameLoaderClientGtk.h:
2919 2009-02-02 Anders Carlsson <andersca@apple.com>
2923 * WebCoreSupport/FrameLoaderClientGtk.h:
2925 2009-02-02 Anders Carlsson <andersca@apple.com>
2927 Reviewed by Dan Bernstein.
2929 Update for changes to WebCore.
2931 * WebCoreSupport/FrameLoaderClientGtk.cpp:
2932 (WebKit::FrameLoaderClient::createPlugin):
2933 (WebKit::FrameLoaderClient::createJavaAppletWidget):
2934 * WebCoreSupport/FrameLoaderClientGtk.h:
2936 2009-02-02 Holger Hans Peter Freyther <zecke@selfish.org>
2938 Reviewed by Darin Adler.
2940 Move Frame::forceLayout, Frame::adjustPageHeight and Frame::forceLayoutWithPageWidthRange to FrameView
2942 https://bugs.webkit.org/show_bug.cgi?id=23428
2944 FrameView::forceLayout could be killed but the comment might
2945 contain a value over the the plain FrameView::layout...
2947 Adjust the WebCore/WebKit consumers of these methods.
2949 * WebCoreSupport/FrameLoaderClientGtk.cpp:
2950 (WebKit::FrameLoaderClient::forceLayout):
2951 * webkit/webkitwebview.cpp:
2953 2009-01-30 Geoffrey Garen <ggaren@apple.com>
2957 * WebCoreSupport/FrameLoaderClientGtk.cpp:
2958 (WebKit::FrameLoaderClient::createFrame):
2960 2009-01-30 Holger Hans Peter Freyther <zecke@selfish.org>
2962 Reviewed by Simon Hausmann.
2964 https://bugs.webkit.org/show_bug.cgi?id=22056
2966 Kill FrameLoaderClient.cpp, move the code over to Frame::createView
2968 FrameLoaderClient is supposed to be an interface, move the
2969 to be shared code to Frame which is a controller and is
2970 allowed to create a FrameView.
2972 * WebCoreSupport/FrameLoaderClientGtk.cpp:
2973 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
2975 2009-01-27 Brady Eidson <beidson@apple.com>
2977 Reviewed by Dan Bernstein
2979 Rework FrameLoaderClient to work on a CachedFrame basis instead of CachedPage
2981 * WebCoreSupport/FrameLoaderClientGtk.cpp:
2982 (WebKit::FrameLoaderClient::savePlatformDataToCachedFrame):
2983 (WebKit::FrameLoaderClient::transitionToCommittedFromCachedFrame):
2984 * WebCoreSupport/FrameLoaderClientGtk.h:
2986 2009-01-25 Darin Adler <darin@apple.com>
2988 Try to fix GTK build.
2990 * webkit/webkitwebview.cpp: Added include of FloatQuad.h.
2992 2009-01-13 Alexander V. Butenko <alex@digiqube.com>
2994 Reviewed by Holger Freyther.
2996 https://bugs.webkit.org/show_bug.cgi?id=23279
2998 Fix crash on WebView dispose stage.
3000 Add null checks to webkit_web_view_set_scroll_adjustments and
3001 webkit_web_view_get_accessible as they get called from within
3004 * webkit/webkitwebview.cpp:
3006 2009-01-11 Xan Lopez <xan@gnome.org>
3008 Reviewed by Holger Freyther.
3010 Use NULL instead of 0 when dealing with pointers, as agreed for
3011 the coding style of the WebKit GTK port for its GTK+ specific
3014 * webkit/webkitwebview.cpp:
3016 2009-01-11 Xan Lopez <xan@gnome.org>
3018 Reviewed by Holger Freyther.
3020 Add padding to the class structs to avoid breaking ABI each time
3023 * webkit/webkitnetworkrequest.h:
3024 * webkit/webkitwebbackforwardlist.h:
3025 * webkit/webkitwebhistoryitem.h:
3026 * webkit/webkitwebnavigationaction.h:
3027 * webkit/webkitwebpolicydecision.h:
3028 * webkit/webkitwebview.h:
3030 2009-01-09 Benjamin Otte <otte@gnome.org>
3032 Reviewed by Holger Freyther.
3034 https://bugs.webkit.org/show_bug.cgi?id=23194
3036 make the finalize function the dispose function. Not releasing held
3037 objects in dispose can cause crashers later.
3039 * webkit/webkitwebview.cpp:
3041 2009-01-09 Benjamin Otte <otte@gnome.org>
3043 Reviewed by Holger Freyther.
3045 https://bugs.webkit.org/show_bug.cgi?id=23194
3047 Remove broken code that uses a fallback. The previous code did 2
3048 policy decisions which caused crashes.
3049 Download is still notImplemented();
3051 * webkit/webkitwebpolicydecision.cpp:
3052 (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_download):
3054 2009-01-03 Xan Lopez <xan@gnome.org>
3056 Reviewed by Holger Freyther.
3058 [GTK] Need a public method to reload view bypassing cache
3059 https://bugs.webkit.org/show_bug.cgi?id=19815
3061 * webkit/webkitwebview.cpp:
3062 * webkit/webkitwebview.h:
3064 Add webkit_web_view_reload_bypass_cache.
3066 2009-01-07 Holger Hans Peter Freyther <zecke@selfish.org>
3068 Reviewed by Maciej Stachowiak.
3070 Add private API to get the number of active animations of
3071 a frame. This is required by the DumpRenderTree utility.
3073 * webkit/webkitprivate.h:
3074 * webkit/webkitwebframe.cpp:
3076 2009-01-05 Adam Treat <adam.treat@torchmobile.com>
3080 * WebCoreSupport/ChromeClientGtk.h:
3082 2009-01-05 Adam Treat <adam.treat@torchmobile.com>
3084 Reviewed by George Staikos.
3086 Build fix for contentsSizeChanged
3088 * WebCoreSupport/ChromeClientGtk.cpp:
3089 (WebKit::ChromeClient::contentsSizeChanged):
3090 * WebCoreSupport/ChromeClientGtk.h:
3092 2009-01-04 Adam Treat <adam.treat@torchmobile.com>
3094 Reviewed by George Staikos.
3096 Make the gtk port build with the new fixedLayoutSize feature
3098 * WebCoreSupport/FrameLoaderClientGtk.cpp:
3099 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
3101 2009-01-03 Holger Hans Peter Freyther <zecke@selfish.org>
3103 Reviewed by Darin Adler.
3105 [GTK] Fix the reference counting of WebKitWebFrames
3107 The ownership is the following: WebKitWebView owns a WebCore::Page.
3108 WebKitWebView is creating one WebKitWebFrame which will be the
3109 mainFrame of the WebCore::Page (having the reference on the Frame).
3111 The FrameLoaderClient has the reference of the WebKitWebFrame for
3112 the main frame and also any other frame. This means when the
3113 WebCore::Frame goes away the FrameLoaderClient will go away which
3114 will normally remove the last reference of the WebKitWebFrame. Because
3115 an API user might have g_object_ref'ed the WebKitWebFrame null
3116 checks had to be added to WebKitWebFrame.
3118 For WebCore::Frames created by the FrameLoaderClient the ownership
3119 will be passed down to the FrameTree, the WebKitWebFrame is not holding
3120 a reference to the WebCore::Frame.
3122 Do not g_object_unref the mainFrame in the destructor of the
3123 WebKitWebFrame as this will happen from within the WebCore::Page
3124 destruction. Do not hold a reference to the WebCore::Frame (circle) in
3125 WebKitWebFrame, add null checks as the WebCore::Frame might have gone
3126 away. Do not keep track of the FrameLoaderClient in the private
3127 structures as it was mostly unusued.
3129 https://bugs.webkit.org/show_bug.cgi?id=21837
3131 * WebCoreSupport/FrameLoaderClientGtk.cpp:
3132 (WebKit::FrameLoaderClient::frameLoaderDestroyed):
3133 (WebKit::FrameLoaderClient::createFrame):
3134 * tests/main.c: Add test case.
3135 (test_webkit_web_frame_create_destroy):
3136 (test_webkit_web_frame_lifetime):
3138 * webkit/webkitprivate.cpp:
3140 * webkit/webkitprivate.h:
3141 * webkit/webkitwebframe.cpp:
3142 * webkit/webkitwebview.cpp:
3144 2009-01-02 Holger Hans Peter Freyther <zecke@selfish.org>
3146 Unreviewed build fix.
3148 * WebCoreSupport/FrameLoaderClientGtk.cpp:
3150 2008-12-31 Holger Hans Peter Freyther <zecke@selfish.org>
3152 Reviewed by Nikolas Zimmermann.
3154 https://bugs.webkit.org/show_bug.cgi?id=17045
3156 Add section information for View, Frame, Settings, HistoryItem, BackForwardList, WindowFeatures and Inspector
3158 Add section information and informal examples for WebKitWebView,
3159 WebKitWebFrame, WebKitWebSettings, WebKitWebNetworkRequest,
3160 WebKitWebWindowFeatures, WebKitWebHistoryItem,
3161 WebKitWebBackForwardList and WebKitWebInspector.
3163 * docs/webkitgtk-sections.txt: Decide to not document some bits
3164 * webkit/webkitnetworkrequest.cpp:
3165 * webkit/webkitwebbackforwardlist.cpp:
3166 * webkit/webkitwebframe.cpp:
3167 * webkit/webkitwebhistoryitem.cpp:
3168 * webkit/webkitwebhistoryitem.h:
3169 * webkit/webkitwebinspector.cpp:
3170 * webkit/webkitwebsettings.cpp:
3171 * webkit/webkitwebsettings.h:
3172 * webkit/webkitwebview.cpp:
3173 * webkit/webkitwebwindowfeatures.cpp:
3175 2008-12-21 Xan Lopez <xan@gnome.org>
3177 Reviewed by Holger Freyther.
3179 https://bugs.webkit.org/show_bug.cgi?id=16092
3180 [GTK] Middle-mouse click should allow opening a URL in a new tab
3182 Add mouse button and keyboard state modifiers info to navigation action.
3184 * WebCoreSupport/FrameLoaderClientGtk.cpp:
3185 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3186 * webkit/webkitwebnavigationaction.cpp:
3187 (_WebKitWebNavigationActionPrivate::):
3188 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_property):
3189 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_set_property):
3190 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_class_init):
3191 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_button):
3192 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_modifier_state):
3193 * webkit/webkitwebnavigationaction.h:
3195 2008-12-19 Marco Barisione <marco.barisione@collabora.co.uk>
3197 Reviewed by Holger Freyther.
3199 http://bugs.webkit.org/show_bug.cgi?id=16562
3200 [gtk] Implement WebPolicyDelegate methods
3202 Original work by Pierre-Luc Beaudoin. Final touches by Gustavo
3205 This implements the delegates methods of WebPolicyDelegate.
3206 Since Gtk+/C doesn't have delegate methods, they are replaced with
3209 A new object WebKitWebPolicyDecision allows the browser to delay its
3210 response in certain cases. WebKitWebNavigationAction contains the
3211 information about what caused a navigation request.
3213 * WebCoreSupport/FrameLoaderClientGtk.cpp:
3214 (WebKit::FrameLoaderClient::FrameLoaderClient):
3215 (WebKit::FrameLoaderClient::~FrameLoaderClient):
3216 (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType):
3217 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3218 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
3219 (WebKit::FrameLoaderClient::cancelPolicyCheck):
3220 (WebKit::FrameLoaderClient::canShowMIMEType):
3221 * WebCoreSupport/FrameLoaderClientGtk.h:
3223 * webkit/webkitdefines.h:
3224 * webkit/webkitprivate.cpp:
3227 * webkit/webkitprivate.h:
3228 * webkit/webkitwebnavigationaction.cpp: Added.
3229 (_WebKitWebNavigationActionPrivate::):
3230 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_property):
3231 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_set_property):
3232 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_init):
3233 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_finalize):
3234 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_class_init):
3235 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_reason):
3236 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_set_reason):
3237 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_get_original_uri):
3238 (_WebKitWebNavigationActionPrivate::webkit_web_navigation_action_set_original_uri):
3239 * webkit/webkitwebnavigationaction.h: Added.
3240 * webkit/webkitwebpolicydecision.cpp: Added.
3241 (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_class_init):
3242 (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_init):
3243 (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_new):
3244 (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_use):
3245 (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_ignore):
3246 (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_download):
3247 (_WebKitWebPolicyDecisionPrivate::webkit_web_policy_decision_cancel):
3248 * webkit/webkitwebpolicydecision.h: Added.
3249 * webkit/webkitwebview.cpp:
3250 * webkit/webkitwebview.h:
3252 2008-12-18 Dan Bernstein <mitz@apple.com>
3254 Reviewed by Sam Weinig.
3256 - stub out FrameLoaderClient::shouldUseCredentialStorage().
3258 * WebCoreSupport/FrameLoaderClientGtk.cpp:
3259 (WebKit::FrameLoaderClient::shouldUseCredentialStorage):
3260 * WebCoreSupport/FrameLoaderClientGtk.h:
3262 2008-12-18 Sam Weinig <sam@webkit.org>
3264 Reviewed by John Sullivan.
3266 Stub out FrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout()
3268 * WebCoreSupport/FrameLoaderClientGtk.cpp:
3269 (WebKit::FrameLoaderClient::dispatchDidFirstVisuallyNonEmptyLayout):
3270 * WebCoreSupport/FrameLoaderClientGtk.h:
3272 2008-12-13 Holger Hans Peter Freyther <zecke@selfish.org>
3274 Reviewed by Cameron Zwarich.
3276 [GTK] Fix crash with LayoutTests/fast/loader/frame-creation-removal.html
3278 Call WebCore::Frame::init after the frame has been given
3279 a name and been added to the FrameTree of the parent.
3281 Removing the call to init is fine as FrameLoaderClientGtk::createFrame
3282 is the only user of webkit_web_frame_init_with_web_view and is already
3283 calling WebCore::Frame::init.
3285 * webkit/webkitwebframe.cpp:
3287 2008-12-13 Adam Bergkvist <adam.bergkvist@ericsson.com>
3289 Reviewed by Holger Freyther.
3291 https://bugs.webkit.org/show_bug.cgi?id=22779
3293 Check for GTK version >= 2.14.0 before using gtk_test_init.
3298 2008-12-13 Zan Dobersek <zandobersek@gmail.com>
3300 Reviewed by Darin Adler.
3302 https://bugs.webkit.org/show_bug.cgi?id=22039
3304 Implement animation and transition pausing as needed by DumpRenderTree.
3306 * webkit/webkitprivate.h:
3307 * webkit/webkitwebframe.cpp:
3309 2008-11-29 Holger Hans Peter Freyther <zecke@selfish.org>
3311 Rubber-stamped by Simon Hausmann.
3313 https://bugs.webkit.org/show_bug.cgi?id=22574
3315 Make webkit_web_view_set_window_features internal
3317 Calling this method will not result in a notify::window-features
3318 signal being emitted. This would allow replacing a
3319 WebKitWebWindowFeature on a WebKitWebView without anyone noticing
3320 and the client code would monitor the wrong object.
3322 * WebCoreSupport/ChromeClientGtk.cpp:
3323 (WebKit::ChromeClient::createWindow):
3324 * webkit/webkitwebview.cpp:
3325 * webkit/webkitwebview.h:
3327 2008-12-09 Brett Wilson <brettw@chromium.org>
3329 Reviewed by Dave Hyatt.
3331 https://bugs.webkit.org/show_bug.cgi?id=22177
3333 Add a callback on ChromeClient that the state of form elements on
3334 the page has changed. This is to allow clients implementing session
3335 saving to know when the current state is dirty.
3337 * WebCoreSupport/ChromeClientGtk.h:
3338 (WebKit::ChromeClient::formStateDidChange):
3340 2008-12-07 Holger Hans Peter Freyther <zecke@selfish.org>
3342 Reviewed by Eric Seidel.
3344 [Gtk+] Use glib's unit test facilities to test the WebKit/Gtk+ API
3346 https://bugs.webkit.org/show_bug.cgi?id=22491
3348 Add the skeleton to WebKit/gtk/tests and integrate that into the
3349 buildsystem. Testing support was added in glib 2.16. For versions
3350 using glib < 2.16 we compile an empty application.
3352 * tests/main.c: Added. https://bugs.webkit.org/show_bug.cgi?id=21837
3353 will be the first consumer.
3356 2008-12-06 Simon Fraser <simon.fraser@apple.com>
3358 Reviewed by Dave Hyatt
3360 https://bugs.webkit.org/show_bug.cgi?id=15671
3362 Renderer::caretRect() is now localCaretRect(), which needs
3363 converting to absolute coordinates (taking transforms into account).
3365 * webkit/webkitwebview.cpp:
3367 2008-12-01 Xan Lopez <xan@gnome.org>
3369 Reviewed by Holger Freyther.
3371 http://bugs.webkit.org/show_bug.cgi?id=22553
3372 Remove unneeded GObject casts.
3374 Remove unneeded casts to GObject in functions that take a gpointer
3377 * WebCoreSupport/ChromeClientGtk.cpp:
3378 (WebKit::ChromeClient::setWindowRect):
3379 (WebKit::ChromeClient::createWindow):
3380 (WebKit::ChromeClient::setToolbarsVisible):
3381 (WebKit::ChromeClient::toolbarsVisible):
3382 (WebKit::ChromeClient::setStatusbarVisible):
3383 (WebKit::ChromeClient::statusbarVisible):
3384 (WebKit::ChromeClient::setScrollbarsVisible):
3385 (WebKit::ChromeClient::scrollbarsVisible):
3386 (WebKit::ChromeClient::setMenubarVisible):
3387 (WebKit::ChromeClient::menubarVisible):
3388 (WebKit::ChromeClient::setToolTip):
3389 * WebCoreSupport/InspectorClientGtk.cpp:
3390 (WebKit::InspectorClient::createPage):
3391 * webkit/webkitwebframe.cpp:
3392 * webkit/webkitwebview.cpp:
3393 * webkit/webkitwebwindowfeatures.cpp:
3394 (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_new_from_core_features):
3396 2008-11-29 Christian Dywan <christian@twotoasts.de>
3398 Reviewed by Holger Freyther.
3400 http://bugs.webkit.org/show_bug.cgi?id=17122
3401 [GTK] Bad font default settings
3403 Implement a property "enforce-96-dpi" in WebKitWebSettings
3404 that can be enabled to force the view to assume 96 DPI.
3406 * webkit/webkitwebsettings.cpp:
3407 (_WebKitWebSettingsPrivate::):
3408 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
3409 (_WebKitWebSettingsPrivate::webkit_web_settings_set_property):
3410 (_WebKitWebSettingsPrivate::webkit_web_settings_get_property):
3411 * webkit/webkitwebview.cpp:
3413 2008-11-28 Holger Hans Peter Freyther <zecke@selfish.org>
3415 Reviewed by Nikolas Zimmermann.
3417 Simplify the code. There is no reason to have code like
3418 if (true) return false; which is using temporary variables.
3420 * webkit/webkitwebview.cpp:
3422 2008-11-28 Holger Hans Peter Freyther <zecke@selfish.org>
3424 Reviewed by Nikolas Zimmermann.
3426 Remove bogus null checks. The WebKitWebView own's a WebCore::Page
3427 which is owning a WebCore::ChromeClient. There is no way that a
3428 WebCore::ChromeClient is still around when the WebKitWebView is gone.
3430 m_webView can only be null when a ChromeClient gets constructed with
3431 a null WebKitWebView which is not allowed.
3433 * WebCoreSupport/ChromeClientGtk.cpp:
3434 (WebKit::ChromeClient::ChromeClient):
3435 (WebKit::ChromeClient::windowRect):
3436 (WebKit::ChromeClient::setWindowRect):
3437 (WebKit::ChromeClient::pageRect):
3438 (WebKit::ChromeClient::focus):
3439 (WebKit::ChromeClient::unfocus):
3440 (WebKit::ChromeClient::show):
3441 (WebKit::ChromeClient::setToolbarsVisible):
3442 (WebKit::ChromeClient::toolbarsVisible):
3443 (WebKit::ChromeClient::setStatusbarVisible):
3444 (WebKit::ChromeClient::statusbarVisible):
3445 (WebKit::ChromeClient::setScrollbarsVisible):
3446 (WebKit::ChromeClient::setMenubarVisible):
3447 (WebKit::ChromeClient::menubarVisible):
3448 (WebKit::ChromeClient::canTakeFocus):
3449 (WebKit::ChromeClient::repaint):
3450 (WebKit::ChromeClient::scroll):
3451 (WebKit::ChromeClient::platformWindow):
3453 2008-11-28 Gustavo Noronha Silva <gns@gnome.org>
3455 Reviewed and slightly modified by Holger Freyther.
3457 https://bugs.webkit.org/show_bug.cgi?id=19130
3459 ChromeClient::createWindow and friends need to be implemented
3461 Code from Gustavo Noronha and Marco Barisione
3462 <marco.barisione@collabora.co.uk> in this change set.
3464 Implemented all the ChromeClient interfaces needed to have new
3465 window creation functioning and exposed to client code. We
3466 implemented a mirror GObject to the WindowFeatures object provided
3469 * WebCoreSupport/ChromeClientGtk.cpp:
3470 (WebKit::ChromeClient::windowRect):
3471 (WebKit::ChromeClient::setWindowRect):
3472 (WebKit::ChromeClient::unfocus):
3473 (WebKit::ChromeClient::createWindow):
3474 (WebKit::ChromeClient::show):
3475 (WebKit::ChromeClient::setToolbarsVisible):
3476 (WebKit::ChromeClient::toolbarsVisible):
3477 (WebKit::ChromeClient::setStatusbarVisible):
3478 (WebKit::ChromeClient::statusbarVisible):
3479 (WebKit::ChromeClient::setScrollbarsVisible):
3480 (WebKit::ChromeClient::scrollbarsVisible):
3481 (WebKit::ChromeClient::setMenubarVisible):
3482 (WebKit::ChromeClient::menubarVisible):
3483 (WebKit::ChromeClient::setResizable):
3484 * WebCoreSupport/FrameLoaderClientGtk.cpp:
3485 (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
3486 (WebKit::FrameLoaderClient::dispatchShow):
3487 (WebKit::FrameLoaderClient::dispatchCreatePage):
3489 * webkit/webkitdefines.h:
3490 * webkit/webkitprivate.h:
3491 * webkit/webkitwebview.cpp:
3492 * webkit/webkitwebview.h:
3493 * webkit/webkitwebwindowfeatures.cpp: Added.
3494 (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_class_init):
3495 (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_init):
3496 (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_finalize):
3497 (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_set_property):
3498 (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_get_property):
3499 (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_new):
3500 (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_new_from_core_features):
3501 (_WebKitWebWindowFeaturesPrivate::webkit_web_window_features_equal):
3502 * webkit/webkitwebwindowfeatures.h: Added.
3504 2008-11-24 Darin Fisher <darin@chromium.org>
3508 http://bugs.webkit.org/show_bug.cgi?id=15643
3510 * WebCoreSupport/EditorClientGtk.cpp:
3511 (WebKit::EditorClient::isSelectTrailingWhitespaceEnabled):
3512 * WebCoreSupport/EditorClientGtk.h:
3514 2008-11-24 Darin Adler <darin@apple.com>
3516 Reviewed by Dan Bernstein.
3518 - https://bugs.webkit.org/show_bug.cgi?id=22470
3519 remove unneeded URL argument from FrameLoaderClient::updateGlobalHistory
3521 * WebCoreSupport/FrameLoaderClientGtk.cpp:
3522 (WebKit::FrameLoaderClient::updateGlobalHistory): Remove argument.
3523 * WebCoreSupport/FrameLoaderClientGtk.h: Ditto.
3525 2008-11-24 Christian Dywan <christian@twotoasts.de>
3527 Reviewed by Holger Freyther.
3529 http://bugs.webkit.org/show_bug.cgi?id=17122
3530 [GTK] Bad font default settings
3532 * webkit/webkitwebsettings.cpp:
3533 (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
3534 Use default font size 12 instead of 10
3536 2008-11-24 Zan Dobersek <zandobersek@gmail.com>
3538 Reviewed by Holger Freyther.
3540 https://bugs.webkit.org/show_bug.cgi?id=22039
3542 Implement a semi-private function for adding a directory to
3543 PluginDatabase's paths.
3545 * webkit/webkitprivate.h:
3546 * webkit/webkitwebsettings.cpp:
3547 (_WebKitWebSettingsPrivate::webkit_web_settings_add_extra_plugin_directory):
3549 2008-11-23 Holger Hans Peter Freyther <zecke@selfish.org>
3551 Rubber-stamped by Sam Weinig.
3553 Add gtk-doc configuration/source for the WebKit/Gtk+ Reference Manual
3555 These files will be used by gtk-doc to generate the documentation. They
3556 contain information how to group the symbols of our API, which objects
3557 to inspect during the generation of the manual and how to display the
3560 * docs/webkitgtk-docs.sgml: Added.
3561 * docs/webkitgtk-overrides.txt: Added.
3562 * docs/webkitgtk-sections.txt: Added.
3563 * docs/webkitgtk.types: Added.
3565 2008-11-23 Holger Hans Peter Freyther <zecke@selfish.org>
3567 Reviewed by Sam Weinig.
3569 Make gtk-doc happy with the existing API documentation
3571 - Mark the *Private pointers in the struct private
3572 - Use Returns: where gtk-doc wants us to
3573 - Fix the parameters to make gtk-doc happy
3574 - Fix signal references
3576 * webkit/webkitnetworkrequest.h:
3577 * webkit/webkitwebbackforwardlist.cpp:
3578 * webkit/webkitwebbackforwardlist.h:
3579 * webkit/webkitwebframe.h:
3580 * webkit/webkitwebhistoryitem.cpp:
3581 * webkit/webkitwebinspector.cpp:
3582 (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init):
3583 * webkit/webkitwebview.cpp:
3584 * webkit/webkitwebview.h:
3586 2008-11-19 Darin Fisher <darin@chromium.org>
3590 https://bugs.webkit.org/show_bug.cgi?id=22373
3591 Ports busted by addition of ScriptValue.{h,cpp}
3593 * webkit/webkitwebview.cpp:
3595 2008-11-18 Holger Hans Peter Freyther <zecke@selfish.org>
3597 Reviewed by Simon Hausmann.
3599 Attempt to share transitionToCommittedForNewPage of FrameLoaderClient with the different ports
3601 After Hyatt's work on Widget and ScrollView there is little difference
3602 between the implementation of Qt, Gtk+ and Win. In fact any kind of
3603 difference is mostly a bug. Alp has fixed two of such errors for the Gtk+
3604 port and the Qt port has at least one of them left.
3606 The only difference between the implementations is in getting the the
3607 IntSize for the new FrameView, the background color to be applied and
3608 eventually some post processing.
3610 Unify the implementations by providing a static helper function that
3611 takes a Frame, IntSize, color and transparency bit and calling it from
3612 the Gtk+, the Qt and the Windows port.
3614 * WebCoreSupport/FrameLoaderClientGtk.cpp:
3615 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
3617 2008-11-16 Christian Dywan <christian@twoasts.de>
3619 Reviewed by Holger Freyther.
3621 https://bugs.webkit.org/show_bug.cgi?id=22207
3622 [Gtk] Font sizes are not handled properly when updated at runtime
3624 * webkit/webkitwebview.cpp: Move the DPI/ conversion into a
3625 helper function and apply the logic in the notification callback.
3627 2008-11-06 Alp Toker <alp@nuanti.com>
3629 Reviewed by Darin Adler.
3631 https://bugs.webkit.org/show_bug.cgi?id=22047
3632 GTK: Add support for multiple file selection in the file upload control
3634 Implemented with GtkFileChooser.
3636 * WebCoreSupport/ChromeClientGtk.cpp:
3637 (WebKit::ChromeClient::runOpenPanel):
3639 2008-11-03 Cameron Zwarich <zwarich@apple.com>
3641 Rubber-stamped by Maciej Stachowiak.
3643 Move more files into the runtime subdirectory of JavaScriptCore.
3645 * webkit/webkitprivate.cpp:
3647 2008-11-03 Alp Toker <alp@nuanti.com>
3649 Reviewed by Holger Freyther.
3651 Deprecate flawed webkit_web_frame_new() function. This would never
3652 have worked properly when used outside WebCore since Frame::create()
3653 can only be called without an owner element once in the lifetime of a
3654 Page and would result in assertions, leaks and an unusable WebView
3657 Frame creation may be exposed in API some time later via the DOM
3658 binding but probably not in the WebKit GTK+ core API.
3660 * webkit/webkitwebframe.cpp:
3661 * webkit/webkitwebframe.h:
3663 2008-11-03 Alp Toker <alp@nuanti.com>
3665 Reviewed by Holger Freyther.
3667 Redundant scrollbars appear in frames where they shouldn't be visible
3668 eg. embedded Google adverts.
3670 Call setCanHaveScrollbars() when necessary. The Mac and Win ports
3671 already have this but it was missing in FrameLoaderClientGtk.
3673 * WebCoreSupport/FrameLoaderClientGtk.cpp:
3674 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
3676 2008-11-03 Alp Toker <alp@nuanti.com>
3678 Rubber-stamped by Holger Freyther.
3680 Sync WebKit GTK+ default UA version string to 528.5+. (We're still
3681 doing this manually!)
3683 * WebCoreSupport/FrameLoaderClientGtk.cpp:
3684 (WebKit::composeUserAgent):
3686 2008-10-31 Christian Dywan <christian@twotoasts.de>
3688 Reviewed by Mark Rowe.
3690 http://bugs.webkit.org/show_bug.cgi?id=22018
3691 enable-developer-extras doesn't toggle WebInspector
3693 * webkit/webkitwebview.cpp:
3694 Add missing 'if' in notification for 'enable-developer-extras'.
3696 2008-10-30 Alp Toker <alp@nuanti.com>
3698 Reviewed by Dave Hyatt.
3700 Fix GIF animations. WebCore will not update animated GIFs if
3701 the WebView is marked offscreen so we need to call
3702 frameView->setParentVisible() when necessary like the Mac and Win
3703 ports do. Regression was introduced around r37155 during the
3704 HostWindow refactor.
3706 * WebCoreSupport/FrameLoaderClientGtk.cpp:
3707 (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
3709 2008-10-30 Alp Toker <alp@nuanti.com>
3711 Rubber-stamped by Holger Freyther.
3713 Fix typo in recently added web inspector signal. dettach -> detach.
3715 * WebCoreSupport/InspectorClientGtk.cpp:
3716 (WebKit::InspectorClient::detachWindow):
3717 * webkit/webkitwebinspector.cpp: