e1268bdcb402c64d07e0c698c7f55ff009b0167c
[WebKit-https.git] / WebKit / chromium / ChangeLog
1 2010-06-10  Abhishek Arya  <inferno@chromium.org>
2
3         Reviewed by Dimitri Glazkov.
4
5         Add null pointer checks for nativeImageForCurrentFrame
6         function calls.
7         https://bugs.webkit.org/show_bug.cgi?id=39797
8
9         * src/WebImageCG.cpp:
10         (WebKit::WebImage::WebImage):
11         (WebKit::WebImage::operator=):
12
13 2010-06-10  Yury Semikhatsky  <yurys@chromium.org>
14
15         Reviewed by Pavel Feldman.
16
17         Web Inspector: to reduce the front end start up time don't push script
18         sources to frontend if debugger is always enabled, instead request
19         script content lazily at the moment it should be displyed. It is critical for
20         always enabled debugger because in that case lots of script may have
21         already been parsed when the front end is opening and pushing all
22         of them at once may slow things down(even though the script sources will never
23         be used if scripts panel isn't open).
24         https://bugs.webkit.org/show_bug.cgi?id=40364
25
26         * src/js/DevTools.js:
27         * src/js/InspectorControllerImpl.js:
28         (devtools.InspectorBackendImpl):
29         (.devtools.InspectorBackendImpl.prototype.getScriptSource):
30
31 2010-06-10  Mike Belshe  <mbelshe@google.com>
32
33         Reviewed by David Levin
34
35         Track whether a resource is loaded via a proxy.
36
37         https://bugs.webkit.org/show_bug.cgi?id=40312
38
39         * public/WebURLResponse.h:
40         * src/WebURLResponse.cpp:
41         (WebKit::WebURLResponse::wasFetchedViaProxy):
42         (WebKit::WebURLResponse::setWasFetchedViaProxy):
43
44 2010-06-10  Vangelis Kokkevis  <vangelis@chromium.org>
45
46         Reviewed by Dimitri Glazkov.
47
48         [chromium] Adding the ANGLE project to the DEPS file as it's required
49         by the gpu-accelerated compositor.
50         https://bugs.webkit.org/show_bug.cgi?id=40379
51
52         * DEPS:
53
54 2010-06-09  Bo Liu  <boliu@chromium.org>
55
56         Reviewed by David Levin.
57
58         [Chromium] Pass <video> full screen calls to Chromium port client
59         https://bugs.webkit.org/show_bug.cgi?id=40317
60
61         * public/WebViewClient.h:
62         (WebKit::WebViewClient::supportsFullscreen):
63         (WebKit::WebViewClient::enterFullscreenForNode):
64         (WebKit::WebViewClient::exitFullscreenForNode):
65         * src/ChromeClientImpl.cpp:
66         (WebKit::ChromeClientImpl::supportsFullscreenForNode):
67         (WebKit::ChromeClientImpl::enterFullscreenForNode):
68         (WebKit::ChromeClientImpl::exitFullscreenForNode):
69         * src/ChromeClientImpl.h:
70
71 2010-06-09  Kenneth Russell  <kbr@google.com>
72
73         Reviewed by Dimitri Glazkov.
74
75         Rename FloatArray to Float32Array
76         https://bugs.webkit.org/show_bug.cgi?id=40323
77
78         Used do-webcore-rename to perform renaming. Manually undid
79         incorrect changes to WebCore/bridge/jni/jsc/JNIBridgeJSC.cpp,
80         WebCore/manual-tests/resources/ArrayParameterTestApplet.java and
81         ArrayParameterTestApplet.class. Updated LayoutTests. Built and ran
82         all layout tests on Safari; built Chromium and ran selected WebGL
83         tests.
84
85         * src/GraphicsContext3D.cpp:
86
87 2010-06-09  Sheriff Bot  <webkit.review.bot@gmail.com>
88
89         Unreviewed, rolling out r60889.
90         http://trac.webkit.org/changeset/60889
91         https://bugs.webkit.org/show_bug.cgi?id=40365
92
93         gtk bot has some kind of memory corruption (Requested by
94         loislo on #webkit).
95
96         * src/InspectorClientImpl.cpp:
97         * src/InspectorClientImpl.h:
98         * src/WebDevToolsAgentImpl.cpp:
99         (WebKit::WebDevToolsAgentImpl::setInspectorFrontendProxyToInspectorController):
100
101 2010-06-09  Pavel Podivilov  <podivilov@chromium.org>
102
103         Reviewed by Yury Semikhatsky.
104
105         Web Inspector: retreive debugger script source synchronously when
106         frontend is attached. We need this to be able to stop on top-level
107         breakpoints.
108         https://bugs.webkit.org/show_bug.cgi?id=40289
109
110         * WebKit.gypi:
111         * src/DebuggerAgent.h:
112         * src/DebuggerAgentImpl.cpp:
113         * src/DebuggerAgentImpl.h:
114         * src/WebDevToolsAgentImpl.cpp:
115         (WebKit::WebDevToolsAgentImpl::createInspectorFrontendProxy):
116         * src/js/DebuggerScript.js:
117         * src/js/DevTools.js:
118         (WebInspector.loaded):
119         * src/js/DevToolsHostStub.js:
120
121 2010-06-07  Ilya Tikhonovsky  <loislo@chromium.org>
122
123         Reviewed by Pavel Feldman.
124
125         WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc
126         data from inspected page to WebInspector as JSON string via http. The native
127         serialization to JSON string is supported by InspectorValue's classes. This patch
128         has the implementation of sendMessageToFrontend function. WebKit version of it still
129         uses ScriptFunctionCall and will be switched to another transport a little bit later.
130         https://bugs.webkit.org/show_bug.cgi?id=40134
131
132         * src/InspectorClientImpl.cpp:
133         (WebKit::InspectorClientImpl::sendMessageToFrontend):
134         * src/InspectorClientImpl.h:
135         * src/WebDevToolsAgentImpl.cpp:
136         (WebKit::WebDevToolsAgentImpl::setInspectorFrontendProxyToInspectorController):
137
138 2010-06-09  Yury Semikhatsky  <yurys@chromium.org>
139
140         Reviewed by Pavel Feldman.
141
142         Web Inspector: update stack trace after script source editing
143         https://bugs.webkit.org/show_bug.cgi?id=40357
144
145         * src/js/DebuggerAgent.js:
146         (devtools.DebuggerAgent.prototype.editScriptSource.this.requestSeqToCallback_.cmd.getSequenceNumber):
147         (devtools.DebuggerAgent.prototype.editScriptSource.requestBacktrace):
148         (devtools.DebuggerAgent.prototype.editScriptSource.handleBacktraceResponse):
149         (devtools.DebuggerAgent.prototype.editScriptSource.reportDidCommitEditing):
150         (devtools.DebuggerAgent.prototype.editScriptSource):
151         (devtools.DebuggerAgent.prototype.requestBacktrace_):
152         (devtools.DebuggerAgent.prototype.handleDebuggerOutput_):
153         (devtools.DebuggerAgent.prototype.doHandleBacktraceResponse_):
154         (devtools.DebuggerAgent.prototype.updateCallFramesFromBacktraceResponse_):
155         * src/js/InspectorControllerImpl.js:
156         (.devtools.InspectorBackendImpl.prototype.editScriptSource):
157
158 2010-06-08  Tony Chang  <tony@chromium.org>
159
160         Reviewed by David Levin.
161
162         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
163         https://bugs.webkit.org/show_bug.cgi?id=40285
164
165         Take 2 at landing this patch, this time rolling DEPS just a bit
166         further to pick up some chromium fixes.
167
168         * DEPS
169         * gyp_webkit:
170
171 2010-06-08  Sheriff Bot  <webkit.review.bot@gmail.com>
172
173         Unreviewed, rolling out r60878.
174         http://trac.webkit.org/changeset/60878
175         https://bugs.webkit.org/show_bug.cgi?id=40349
176
177         broke linux build (Requested by tony^work on #webkit).
178
179         * DEPS:
180         * gyp_webkit:
181
182 2010-06-08  Tony Chang  <tony@chromium.org>
183
184         Reviewed by David Levin.
185
186         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
187         https://bugs.webkit.org/show_bug.cgi?id=40285
188
189         * gyp_webkit:
190
191 2010-06-08  Tony Chang  <tony@chromium.org>
192
193         Not reviewed, build fix.
194
195         [chromium] fix linux compile
196         https://bugs.webkit.org/show_bug.cgi?id=40343
197
198         * DEPS:
199
200 2010-06-08  Yury Semikhatsky  <yurys@chromium.org>
201
202         Reviewed by Pavel Feldman.
203
204         Web Inspector: extend ScriptDebugServer to support script source editing
205         https://bugs.webkit.org/show_bug.cgi?id=40297
206
207         * src/js/DebuggerAgent.js:
208         (devtools.ScriptInfo.prototype.worldType):
209         * src/js/DebuggerScript.js:
210         (debuggerScriptConstructor.DebuggerScript.editScriptSource):
211         * src/js/DevTools.js:
212         (WebInspector.loaded):
213         * src/js/InspectorControllerImpl.js:
214         (devtools.InspectorBackendImpl):
215
216 2010-06-08  Antonio Gomes  <tonikitoo@webkit.org>
217
218         Reviewed by Ojan Vafai and Darin Adler.
219
220         Refactor platform dependent editing behavior code out of Settings
221         https://bugs.webkit.org/show_bug.cgi?id=39854
222
223         EditingBehavior enum was renamed to EditingBehaviorTypes and moved out from Settings.h to
224         EditingBehaviorTypes.h . Call sites in WebKit/ adjusted accordingly.
225
226         * src/WebSettingsImpl.cpp:
227         (WebKit::WebSettingsImpl::setEditingBehavior):
228 2010-06-07  Tony Chang  <tony@chromium.org>
229
230         Reviewed by Kent Tamura.
231
232         [chromium] roll chromium DEPS
233         https://bugs.webkit.org/show_bug.cgi?id=40277
234
235         * DEPS:
236
237 2010-06-07  Kinuko Yasuda  <kinuko@chromium.org>
238
239         Reviewed by Jian Li.
240
241         Refactor FormData and Blob for better support of Blobs synthesized by BlobBuilder.
242         https://bugs.webkit.org/show_bug.cgi?id=39083
243
244         Replace FormDataList::Item list with BlobItemList to get it compiled
245         with the refactoring in FormDataList.
246
247         * src/WebSearchableFormData.cpp:
248         (WebCore::HasSuitableTextElement):
249
250 2010-06-07  Andrei Popescu  <andreip@google.com>
251
252         Reviewed by Jeremy Orlow.
253
254         [indexedDB] It is impossible to create object stores
255         https://bugs.webkit.org/show_bug.cgi?id=40054
256
257         * WebKit.gyp:
258         * public/WebIDBCallbacks.h:
259         (WebKit::WebIDBCallbacks::onSuccess):
260         * public/WebIDBDatabase.h:
261         (WebKit::WebIDBDatabase::createObjectStore):
262         * public/WebIDBObjectStore.h: Added.
263         (WebKit::WebIDBObjectStore::~WebIDBObjectStore):
264         (WebKit::WebIDBObjectStore::name):
265         (WebKit::WebIDBObjectStore::keyPath):
266         * src/IDBCallbacksProxy.cpp:
267         (WebCore::IDBCallbacksProxy::onSuccess):
268         * src/IDBCallbacksProxy.h:
269         * src/IDBDatabaseProxy.cpp:
270         (WebCore::IDBDatabaseProxy::createObjectStore):
271         * src/IDBDatabaseProxy.h:
272         * src/IDBObjectStoreProxy.cpp: Added.
273         (WebCore::IDBObjectStoreProxy::create):
274         (WebCore::IDBObjectStoreProxy::IDBObjectStoreProxy):
275         (WebCore::IDBObjectStoreProxy::~IDBObjectStoreProxy):
276         (WebCore::IDBObjectStoreProxy::name):
277         (WebCore::IDBObjectStoreProxy::keyPath):
278         (WebCore::IDBObjectStoreProxy::indexNames):
279         (WebCore::IDBObjectStoreProxy::createIndex):
280         (WebCore::IDBObjectStoreProxy::index):
281         (WebCore::IDBObjectStoreProxy::removeIndex):
282         * src/IDBObjectStoreProxy.h: Added.
283         * src/IndexedDatabaseProxy.cpp:
284         (WebCore::IndexedDatabaseProxy::open):
285         * src/WebIDBCallbacksImpl.cpp:
286         (WebCore::WebIDBCallbacksImpl::onSuccess):
287         * src/WebIDBCallbacksImpl.h:
288         * src/WebIDBDatabaseImpl.cpp:
289         (WebKit::WebIDBDatabaseImpl::createObjectStore):
290         * src/WebIDBDatabaseImpl.h:
291         * src/WebIDBObjectStoreImpl.cpp: Added.
292         (WebKit::WebIDBObjectStoreImpl::WebIDBObjectStoreImpl):
293         (WebKit::WebIDBObjectStoreImpl::~WebIDBObjectStoreImpl):
294         (WebKit::WebIDBObjectStoreImpl::name):
295         (WebKit::WebIDBObjectStoreImpl::keyPath):
296         * src/WebIDBObjectStoreImpl.h: Added.
297         * src/WebIndexedDatabaseImpl.cpp:
298         (WebKit::WebIndexedDatabaseImpl::open):
299
300 2010-06-07  Yury Semikhatsky  <yurys@chromium.org>
301
302         Reviewed by Pavel Feldman.
303
304         Web Inspector: should be possible to distinguish extension scripts from main world scripts
305         https://bugs.webkit.org/show_bug.cgi?id=40220
306
307         * src/js/DebuggerAgent.js:
308         (devtools.DebuggerAgent.prototype.initUI):
309         (devtools.DebuggerAgent.prototype.addScriptInfo_):
310         (devtools.DebuggerAgent.prototype.formatCallFrame_):
311         (devtools.ScriptInfo.prototype.worldType):
312         * src/js/DebuggerScript.js:
313         (debuggerScriptConstructor.DebuggerScript.getScripts): use only context id without context type
314         when filtering scripts so that extension scripts are also included.
315         (debuggerScriptConstructor.DebuggerScript._formatScript):
316         * src/js/devTools.css:
317
318 2010-06-04  Jay Civelli  <jcivelli@chromium.org>
319
320         Reviewed by Dimitri Glazkov.
321
322         Accessibility focus change notifications are now sent from
323         ChromeClientImpl::focusedNodeChanged().
324         https://bugs.webkit.org/show_bug.cgi?id=39792
325
326         * src/ChromeClientImpl.cpp:
327         (WebKit::ChromeClientImpl::focus):
328         (WebKit::ChromeClientImpl::focusedNodeChanged):
329
330 2010-06-04  Jay Civelli  <jcivelli@chromium.org>
331
332         Reviewed by David Levin.
333
334         [chromium] Adding support for the left and right Windows keys to the
335                    NativeWebKeyboardEvent.
336         https://bugs.webkit.org/show_bug.cgi?id=39752
337
338         * src/gtk/WebInputEventFactory.cpp:
339         (WebKit::gdkEventToWindowsKeyCode):
340
341 2010-06-04  Pavel Podivilov  <podivilov@chromium.org>
342
343         Reviewed by Yury Semikhatsky.
344
345         Web Inspector: Create resource for DebuggerScript.js.
346         https://bugs.webkit.org/show_bug.cgi?id=40122
347
348         * WebKit.grd:
349         * public/WebDevToolsAgentClient.h:
350         (WebKit::WebDevToolsAgentClient::debuggerScriptSource):
351
352 2010-05-26  MORITA Hajime  <morrita@google.com>
353
354         Reviewed by Jian Li.
355
356         [Chromium] Dragging over an element with scrollbars should scroll the element when dragging near edges
357         https://bugs.webkit.org/show_bug.cgi?id=39725
358
359         Added WebViewImpl::scrollForDragging() to handle scroll-on-drag.
360         Note that this change handes both source and destination cases.
361         
362         * public/WebView.h:
363         * src/WebViewImpl.cpp:
364         (WebKit::WebViewImpl::dragSourceMovedTo):
365         (WebKit::WebViewImpl::dragTargetDragEnterOrOver):
366         (WebKit::WebViewImpl::scrollForDragging):
367         * src/WebViewImpl.h:
368
369 2010-06-03  Yury Semikhatsky  <yurys@chromium.org>
370
371         Reviewed by Pavel Feldman.
372
373         [v8] Web Inspector: show "Object" as description for values with anonymous constructor
374         https://bugs.webkit.org/show_bug.cgi?id=40121
375
376         * src/js/DevTools.js: don't call DebuggerAgent methods if ScriptDebugServer is used.
377
378 2010-06-03  Kent Tamura  <tkent@chromium.org>
379
380         Reviewed by Dimitri Glazkov.
381
382         [DRT/Chromium] Checking out lighttpd
383         https://bugs.webkit.org/show_bug.cgi?id=39948
384
385         - Add lighttpd only on Windows. It is used by new-run-webkit-tests.
386         - Add libvpx.
387         - Remove pthreads-win32 from DEPS.
388           It has not been used since Chromium r28642.
389         - Update Chromium revision to use Windows resource query code and
390           webkit_glue dependency fix.
391
392         * DEPS:
393
394 2010-06-02  Tony Chang  <tony@chromium.org>
395
396         Reviewed by Kent Tamura.
397
398         [chromium] refactor WebKit.gyp's DRT section so the conditions are less messy
399         https://bugs.webkit.org/show_bug.cgi?id=40104
400
401         * WebKit.gyp:
402
403 2010-06-02  Tony Chang  <tony@chromium.org>
404
405         Not reviewed, build fix in downstream chromium.
406
407         Fix the path to repack.py so it works in a chromium checkout too.
408
409         * WebKit.gyp:
410
411 2010-06-02  Tony Chang  <tony@chromium.org>
412
413         Reviewed by Kent Tamura.
414
415         [chromium] generate DumpRenderTree.pak on DRT linux
416         https://bugs.webkit.org/show_bug.cgi?id=40098
417
418         * WebKit.gyp:
419
420 2010-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
421
422         Unreviewed, rolling out r60592.
423         http://trac.webkit.org/changeset/60592
424         https://bugs.webkit.org/show_bug.cgi?id=40099
425
426         broke the build, need to coordiate updating DEPS (Requested by
427         tony^work on #webkit).
428
429         * DEPS:
430         * public/WebMediaPlayer.h:
431
432 2010-06-02  Victoria Kirst  <vrk@google.com>
433
434         Reviewed by David Levin.
435
436         Modifying the WebMediaPlayer interface to be compatible with
437         a change in chrome.
438         This is a part 2 of 3 one-sided changes to chrome and WebKit. Chrome
439         has been updated, so this commit should NOT break chromium anymore.
440         https://bugs.webkit.org/show_bug.cgi?id=39445
441
442         * DEPS: Updated to a newer chrome revision number.
443         * public/WebMediaPlayer.h: Changed buffered() to be non-const.
444
445 2010-06-02  Peter Kasting  <pkasting@google.com>
446
447         Unreviewed, emergency fix for test crashes (verbal r+ beforehand from
448         John Gregg).
449
450         Temporarily make notificationObjectDestroyed() a no-op to avoid an
451         ASSERT failure.
452
453         https://bugs.webkit.org/show_bug.cgi?id=40097
454
455         * src/NotificationPresenterImpl.cpp:
456         (WebKit::NotificationPresenterImpl::notificationObjectDestroyed):
457
458 2010-06-02  Sterling Swigart  <sswigart@google.com>
459
460         Reviewed by David Levin.
461
462         Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
463         https://bugs.webkit.org/show_bug.cgi?id=39906
464
465         * features.gypi:
466
467 2010-06-01  James Hawkins  <jhawkins@chromium.org>
468
469         UNREVIEWED: build fix.
470
471         Implement the added virtual methods from PopupMenuClient to
472         TestPopupMenuClient.
473
474         * tests/PopupMenuTest.cpp:
475         (WebKit::TestPopupMenuClient::selectionChanged):
476         (WebKit::TestPopupMenuClient::selectionCleared):
477
478 2010-05-24  James Hawkins  <jhawkins@chromium.org>
479
480         Reviewed by Darin Fisher.
481
482         [Chromium] Implement new PopupMenuClient methods selectionChanged()
483         and selectionCleared().  Expose placeHolder methods and isAutoFilled()
484         in WebInputElement.
485
486         https://bugs.webkit.org/show_bug.cgi?id=39639
487
488         * public/WebInputElement.h:
489         * public/WebViewClient.h:
490         (WebKit::WebViewClient::didSelectAutoFillSuggestion):
491         (WebKit::WebViewClient::didClearAutoFillSelection):
492         * src/AutoFillPopupMenuClient.cpp:
493         (WebKit::AutoFillPopupMenuClient::selectionChanged):
494         (WebKit::AutoFillPopupMenuClient::selectionCleared):
495         (WebKit::AutoFillPopupMenuClient::popupDidHide):
496         * src/AutoFillPopupMenuClient.h:
497         * src/SuggestionsPopupMenuClient.h:
498         (WebKit::SuggestionsPopupMenuClient::selectionChanged):
499         (WebKit::SuggestionsPopupMenuClient::selectionCleared):
500         * src/WebInputElement.cpp:
501         (WebKit::WebInputElement::setPlaceholder):
502         (WebKit::WebInputElement::placeholder):
503         (WebKit::WebInputElement::isAutofilled):
504
505 2010-06-01  Sheriff Bot  <webkit.review.bot@gmail.com>
506
507         Unreviewed, rolling out r60483.
508         http://trac.webkit.org/changeset/60483
509         https://bugs.webkit.org/show_bug.cgi?id=40013
510
511         Breaks Mac and Linux builds (Requested by antonm on #webkit).
512
513         * DEPS:
514
515 2010-06-01  Jeremy Orlow  <jorlow@chromium.org>
516
517         Reviewed by Darin Fisher.
518
519         IndexedDB cleanup
520         https://bugs.webkit.org/show_bug.cgi?id=40007
521
522         Remove the exception code paramter (that hasn't been used for a while).
523         Add asserts to default implementations.
524
525         * public/WebIDBDatabase.h:
526         (WebKit::WebIDBDatabase::name):
527         (WebKit::WebIDBDatabase::description):
528         (WebKit::WebIDBDatabase::version):
529         (WebKit::WebIDBDatabase::objectStores):
530         * public/WebIndexedDatabase.h:
531         (WebKit::WebIndexedDatabase::open):
532         * src/WebIndexedDatabaseImpl.cpp:
533         (WebKit::WebIndexedDatabaseImpl::open):
534         * src/WebIndexedDatabaseImpl.h:
535
536 2010-06-01  Anton Muhin  <antonm@chromium.org>
537
538         Reviewed by Dimitri Glazkov.
539
540         Rolling Chromium revision to bring recent changes to V8.
541
542         * DEPS:
543
544 2010-06-01  Sheriff Bot  <webkit.review.bot@gmail.com>
545
546         Unreviewed, rolling out r60470.
547         http://trac.webkit.org/changeset/60470
548         https://bugs.webkit.org/show_bug.cgi?id=39990
549
550         Need to rollout until bot can be updated (Requested by jorlow
551         on #webkit).
552
553         * DEPS:
554
555 2010-05-31  Pavel Podivilov  <podivilov@chromium.org>
556
557         Reviewed by Pavel Feldman.
558
559         Chromium: save inspector settings as dictionary, not as string.
560         https://bugs.webkit.org/show_bug.cgi?id=32118
561
562         * public/WebView.h:
563         * public/WebViewClient.h:
564         (WebKit::WebViewClient::didUpdateInspectorSetting):
565         * src/InspectorClientImpl.cpp:
566         (WebKit::InspectorClientImpl::populateSetting):
567         (WebKit::InspectorClientImpl::storeSetting):
568         * src/InspectorClientImpl.h:
569         * src/WebViewImpl.cpp:
570         (WebKit::WebViewImpl::WebViewImpl):
571         (WebKit::WebViewImpl::inspectorSetting):
572         (WebKit::WebViewImpl::setInspectorSetting):
573         * src/WebViewImpl.h:
574
575 2010-05-31  James Robinson  <jamesr@chromium.org>
576
577         Reviewed by Darin Fisher.
578
579         Expose html5 parser enabled flag in WebSettings
580         https://bugs.webkit.org/show_bug.cgi?id=39913
581
582         * public/WebSettings.h:
583         * src/WebSettingsImpl.cpp:
584         (WebKit::WebSettingsImpl::setHTML5ParserEnabled):
585         * src/WebSettingsImpl.h:
586
587 2010-05-31  Lyon Chen  <liachen@rim.com>
588
589         Reviewed by Kent Tamura.
590
591         Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts.
592         https://bugs.webkit.org/show_bug.cgi?id=35530
593
594         Change enum EAlteration from { MOVE, EXTEND } to { AlterationMove, AlterationExtend } and enum EDirection { FORWARD, BACKWARD, RIGHT, LEFT} to { DirectionForward, DirectionBackward, DirectionRight, DirectionLeft } to avoid macro conflict, and also better coding style conformance.
595
596         * src/WebFrameImpl.cpp:
597         (WebKit::WebFrameImpl::executeCommand):
598
599 2010-05-31  Roland Steiner  <rolandsteiner@chromium.org>
600
601         Bug 39977 - Missing Chromium bindings for InspectorController methods introduced in r60443
602         https://bugs.webkit.org/show_bug.cgi?id=39977
603         
604         add missing InspectorController JS bindings:
605         - getStyleSheet
606         - getRuleRangesForStyleSheetId
607         
608         Tests: inspector/styles-source-offsets.html
609
610         * src/js/InspectorControllerImpl.js:
611         (devtools.InspectorBackendImpl):
612
613 2010-05-31  Sheriff Bot  <webkit.review.bot@gmail.com>
614
615         Unreviewed, rolling out r60456.
616         http://trac.webkit.org/changeset/60456
617         https://bugs.webkit.org/show_bug.cgi?id=39974
618
619         Broke Chromium Linux/Max build (Requested by tkent on
620         #webkit).
621
622         * DEPS:
623
624 2010-05-31  Kent Tamura  <tkent@chromium.org>
625
626         Reviewed by Dimitri Glazkov.
627
628         [DRT/Chromium] Checking out lighttpd
629         https://bugs.webkit.org/show_bug.cgi?id=39948
630
631         - Checking out lighttpd only on Windows. It is used by new-run-webkit-tests.
632         - Update Chromium revision to use Windows resource query code
633
634         * DEPS:
635
636 2010-05-31  Yury Semikhatsky  <yurys@chromium.org>
637
638         Reviewed by Pavel Feldman.
639
640         Web Inspector: allow hiding Scripts panel from Chromium code. This
641         is needed to support v8 debugging protocol which has an implementation
642         that conflicts with debugger provided by the inspector.
643         https://bugs.webkit.org/show_bug.cgi?id=39952
644
645         * public/WebDevToolsAgentClient.h:
646         (WebKit::WebDevToolsAgentClient::exposeV8DebuggerProtocol):
647         * public/WebDevToolsFrontendClient.h:
648         (WebKit::WebDevToolsFrontendClient::WebDevToolsFrontendClient):
649         (WebKit::WebDevToolsFrontendClient::sendMessageToAgent):
650         (WebKit::WebDevToolsFrontendClient::sendDebuggerCommandToAgent):
651         (WebKit::WebDevToolsFrontendClient::sendDebuggerPauseScript):
652         (WebKit::WebDevToolsFrontendClient::activateWindow):
653         (WebKit::WebDevToolsFrontendClient::closeWindow):
654         (WebKit::WebDevToolsFrontendClient::requestDockWindow):
655         (WebKit::WebDevToolsFrontendClient::requestUndockWindow):
656         (WebKit::WebDevToolsFrontendClient::hideScriptsPanel):
657         * src/DebuggerAgentManager.cpp:
658         (WebKit::DebuggerAgentManager::debugAttach):
659         (WebKit::DebuggerAgentManager::debugDetach):
660         (WebKit::DebuggerAgentManager::setExposeV8DebuggerProtocol):
661         * src/DebuggerAgentManager.h:
662         * src/InspectorFrontendClientImpl.cpp:
663         (WebKit::InspectorFrontendClientImpl::hiddenPanels):
664         * src/WebDevToolsAgentImpl.cpp:
665         (WebKit::WebDevToolsAgentImpl::WebDevToolsAgentImpl):
666         (WebKit::WebDevToolsAgentImpl::attach):
667
668 2010-05-30  Lyon Chen  <liachen@rim.com>
669
670         Reviewed by Kent Tamura.
671
672         This is a coding style cleanup before fixing to bug 35530.
673
674         Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts.
675         https://bugs.webkit.org/show_bug.cgi?id=35530
676
677         * src/WebFrameImpl.cpp:
678         (WebKit::WebFrameImpl::find):
679         (WebKit::WebFrameImpl::scopeStringMatches):
680         (WebKit::WebFrameImpl::createChildFrame):
681         (WebKit::WebFrameImpl::shouldScopeMatches):
682
683 2010-05-30  Daniel Bates  <dbates@rim.com>
684
685         Unreviewed, attempt to fix the build after http://trac.webkit.org/changeset/60418.
686
687         I missed a few call sites in the Chromium source when I
688         landed http://trac.webkit.org/changeset/60419.
689
690         Credit to Chris Jerdonek for looking over both this patch and the patch
691         committed in r60419.
692
693         * src/WebSearchableFormData.cpp:
694         (WebCore::GetButtonToActivate):
695         (WebCore::HasSuitableTextElement):
696
697 2010-05-30  Daniel Bates  <dbates@rim.com>
698
699         Unreviewed, attempt to fix the build after http://trac.webkit.org/changeset/60418.
700
701         * src/EditorClientImpl.cpp:
702         (WebKit::EditorClientImpl::autofill):
703         * src/WebFormControlElement.cpp:
704         (WebKit::WebFormControlElement::formControlName):
705         (WebKit::WebFormControlElement::formControlType):
706         * src/WebFormElement.cpp:
707         (WebKit::WebFormElement::getFormControlElements):
708         * src/WebPasswordFormUtils.cpp:
709         (WebKit::findPasswordFormFields):
710
711 2010-05-30  Jessie Berlin  <jberlin@webkit.org>
712
713         Reviewed by Pavel Feldman.
714
715         https://bugs.webkit.org/show_bug.cgi?id=39224
716         Bug 39224 - Web Inspector: There should be a way to clean up profiles
717
718         * src/js/InspectorControllerImpl.js:
719         (devtools.InspectorBackendImpl):
720
721 2010-05-29  Vangelis Kokkevis  <vangelis@chromium.org>
722
723         Reviewed by Darin Fisher.
724
725         Adding support for a runtime flag to enable accelerated
726         compositing in chromium.
727         https://bugs.webkit.org/show_bug.cgi?id=39917
728
729         * public/WebSettings.h:
730         * src/WebSettingsImpl.cpp:
731         (WebKit::WebSettingsImpl::setAcceleratedCompositingEnabled):
732         * src/WebSettingsImpl.h:
733
734 2010-05-28  Aaron Boodman  <aa@chromium.org>
735
736         Reviewed by Darin Fisher.
737
738         Add isXHTMLDocument() to WebDocument.
739
740         https://bugs.webkit.org/show_bug.cgi?id=39887
741
742         * public/WebDocument.h: Add isXHTMLDocument().
743         * src/WebDocument.cpp: ditto.
744         (WebKit::WebDocument::isXHTMLDocument): dittorama.
745
746 2010-05-27  Jeremy Orlow  <jorlow@chromium.org>
747
748         Reviewed by Steve Block.
749
750         Add IndexedDB's IDBIndex
751         https://bugs.webkit.org/show_bug.cgi?id=39850
752
753         Add WebKit layer for IDBIndex.
754
755         * WebKit.gyp:
756         * public/WebCommon.h:
757         * public/WebIDBCallbacks.h:
758         (WebKit::WebIDBCallbacks::onError):
759         (WebKit::WebIDBCallbacks::onSuccess):
760         * public/WebIDBDatabase.h:
761         * public/WebIDBIndex.h: Added.
762         (WebKit::WebIDBIndex::~WebIDBIndex):
763         (WebKit::WebIDBIndex::name):
764         (WebKit::WebIDBIndex::keyPath):
765         (WebKit::WebIDBIndex::unique):
766         * src/IDBCallbacksProxy.cpp:
767         (WebCore::IDBCallbacksProxy::onSuccess):
768         * src/IDBCallbacksProxy.h:
769         * src/IDBDatabaseProxy.cpp:
770         * src/IDBDatabaseProxy.h:
771         * src/IDBIndexProxy.cpp: Added.
772         (WebCore::IDBIndexProxy::create):
773         (WebCore::IDBIndexProxy::IDBIndexProxy):
774         (WebCore::IDBIndexProxy::~IDBIndexProxy):
775         (WebCore::IDBIndexProxy::name):
776         (WebCore::IDBIndexProxy::keyPath):
777         (WebCore::IDBIndexProxy::unique):
778         * src/IDBIndexProxy.h: Added.
779         * src/WebIDBCallbacksImpl.cpp:
780         (WebCore::WebIDBCallbacksImpl::onSuccess):
781         * src/WebIDBCallbacksImpl.h:
782         * src/WebIDBDatabaseImpl.cpp:
783         * src/WebIDBDatabaseImpl.h:
784         * src/WebIDBIndexImpl.cpp: Added.
785         (WebKit::WebIDBIndexImpl::WebIDBIndexImpl):
786         (WebKit::WebIDBIndexImpl::~WebIDBIndexImpl):
787         (WebKit::WebIDBIndexImpl::name):
788         (WebKit::WebIDBIndexImpl::keyPath):
789         (WebKit::WebIDBIndexImpl::unique):
790         * src/WebIDBIndexImpl.h: Added.
791
792 2010-05-28  Yury Semikhatsky  <yurys@chromium.org>
793
794         Reviewed by Pavel Feldman.
795
796         Web Inspector: check that ClientMessageLoopAdapter is not 0 before
797         accessing its fileds from inspectedViewClosed method. It may be 0
798         if inspector frontend has not been open.
799         https://bugs.webkit.org/show_bug.cgi?id=39876
800
801         * src/WebDevToolsAgentImpl.cpp:
802         (WebKit::):
803
804 2010-05-27  Eric Uhrhane  <ericu@chromium.org>
805
806         Reviewed by Adam Barth.
807
808         Add v8 bindings for async DB API in workers
809         https://bugs.webkit.org/show_bug.cgi?id=39145
810         
811         * src/DatabaseObserver.cpp:
812         We should check that we're on the context thread now, not the main
813         thread.
814         (WebCore::DatabaseObserver::databaseOpened):
815         (WebCore::DatabaseObserver::databaseModified):
816         (WebCore::DatabaseObserver::databaseClosed):
817
818 2010-05-27  Yury Semikhatsky  <yurys@chromium.org>
819
820         Reviewed by Pavel Feldman.
821
822         Resume script execution if user tries to navigate to another URL
823         https://bugs.webkit.org/show_bug.cgi?id=39842
824
825         * src/WebDevToolsAgentImpl.cpp:
826         (WebKit::):
827         (WebKit::WebDevToolsAgentImpl::didNavigate):
828
829 2010-05-27  Zhenyao Mo  <zmo@google.com>
830
831         Reviewed by Dimitri Glazkov.
832
833         Implement lazy clearing of renderbuffers
834         https://bugs.webkit.org/show_bug.cgi?id=36248
835
836         * src/WebGraphicsContext3DDefaultImpl.cpp:
837         (WebKit::WebGraphicsContext3DDefaultImpl::reshape): Clear WebGL internal buffers.
838
839 2010-05-26  Roland Steiner  <rolandsteiner@chromium.org>
840
841         Reviewed by NOBODY (layout test crashing fix).
842
843         Bug 39811 - WebPluginListBuilderImpl::addMediaTypeToLastPlugin does not initialize pluginIndex
844         https://bugs.webkit.org/show_bug.cgi?id=39811
845
846         Initialize the pluginIndex field (quick fix).
847
848         Tests: covered by fast/dom/prototype-inheritance-2.html
849         (crashed under Chromium Linux and Windows)
850
851         * src/WebPluginListBuilderImpl.cpp:
852         (WebKit::WebPluginListBuilderImpl::addMediaTypeToLastPlugin):
853
854 2010-05-26  Anders Carlsson  <andersca@apple.com>
855
856         Reviewed by Darin Adler.
857
858         Clean up MimeClassInfo and PluginInfo
859         https://bugs.webkit.org/show_bug.cgi?id=39700
860
861         Update for WebCore changes.
862
863         * src/WebPluginListBuilderImpl.cpp:
864         (WebKit::WebPluginListBuilderImpl::addPlugin):
865         (WebKit::WebPluginListBuilderImpl::addMediaTypeToLastPlugin):
866         (WebKit::WebPluginListBuilderImpl::addFileExtensionToLastMediaType):
867         * src/WebPluginListBuilderImpl.h:
868         (WebKit::WebPluginListBuilderImpl::WebPluginListBuilderImpl):
869
870 2010-05-26  Jeremy Orlow  <jorlow@chromium.org>
871
872         Unreviewed chromium build fix
873         https://bugs.webkit.org/show_bug.cgi?id=39739
874
875         The backwards compat function needs to take in a WebSecurityOrigin
876         instead of a WebString.
877
878         * public/WebIndexedDatabase.h:
879         (WebKit::WebIndexedDatabase::open):
880
881 2010-05-26  Jeremy Orlow  <jorlow@chromium.org>
882
883         Reviewed by Darin Fisher.
884
885         Implement WebDOMStorageList and make WebIDBDatabase use it
886         https://bugs.webkit.org/show_bug.cgi?id=39731
887
888         * WebKit.gyp:
889         * public/WebDOMStringList.h: Added.
890         (WebKit::WebDOMStringList::~WebDOMStringList):
891         (WebKit::WebDOMStringList::WebDOMStringList):
892         (WebKit::WebDOMStringList::operator=):
893         * public/WebIDBDatabase.h:
894         (WebKit::WebIDBDatabase::objectStores):
895         * src/IDBDatabaseProxy.cpp:
896         (WebCore::IDBDatabaseProxy::objectStores):
897         * src/WebDOMStringList.cpp: Added.
898         (WebKit::WebDOMStringList::reset):
899         (WebKit::WebDOMStringList::assign):
900         (WebKit::WebDOMStringList::append):
901         (WebKit::WebDOMStringList::length):
902         (WebKit::WebDOMStringList::item):
903         (WebKit::WebDOMStringList::WebDOMStringList):
904         (WebKit::WebDOMStringList::operator=):
905         (WebKit::WebDOMStringList::operator WTF::PassRefPtr<WebCore::DOMStringList>):
906         * src/WebIDBDatabaseImpl.cpp:
907         (WebKit::WebIDBDatabaseImpl::objectStores):
908         * src/WebIDBDatabaseImpl.h:
909
910 2010-05-24  Jeremy Orlow  <jorlow@chromium.org>
911
912         Reviewed by Steve Block.
913
914         Add IDBDatabase's attributes
915         https://bugs.webkit.org/show_bug.cgi?id=39602
916
917         Plumbing to hook up the synchronous attribute requests
918         on IDBDatabase.
919
920         * public/WebIDBDatabase.h:
921         (WebKit::WebIDBDatabase::name):
922         (WebKit::WebIDBDatabase::description):
923         (WebKit::WebIDBDatabase::version):
924         (WebKit::WebIDBDatabase::objectStores):
925         * src/IDBDatabaseProxy.cpp:
926         (WebCore::IDBDatabaseProxy::name):
927         (WebCore::IDBDatabaseProxy::description):
928         (WebCore::IDBDatabaseProxy::version):
929         (WebCore::IDBDatabaseProxy::objectStores):
930         * src/IDBDatabaseProxy.h:
931         * src/WebIDBDatabaseImpl.cpp:
932         (WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl):
933         (WebKit::WebIDBDatabaseImpl::name):
934         (WebKit::WebIDBDatabaseImpl::description):
935         (WebKit::WebIDBDatabaseImpl::version):
936         (WebKit::WebIDBDatabaseImpl::objectStores):
937         * src/WebIDBDatabaseImpl.h:
938
939 2010-05-24  Dirk Pranke  <dpranke@chromium.org>
940
941         Reviewed by Dimitri Glazkov.
942
943         Re-commit r58765 - it had been rolled out to see if it was causing
944         a perf regression (in r59787 and r59789), but that does not seem to
945         have been the case.
946
947         * public/WebNotification.h:
948         * src/WebNotification.cpp:
949         (WebKit::WebNotification::dir):
950         (WebKit::WebNotification::replaceId):
951
952 2010-05-25  Brett Wilson  <brettw@chromium.org>
953
954         Reviewed by Darin Fisher.
955
956         Remove obsolete code for Mac & Windows plugin creation in the Chromium
957         port. This non-Windows code was to prevent a crash which we no longer
958         seem to have, and it is preventing other types of plugins from working.
959         https://bugs.webkit.org/show_bug.cgi?id=39684
960
961         * src/FrameLoaderClientImpl.cpp:
962         (WebKit::FrameLoaderClientImpl::createPlugin):
963
964 2010-05-25  Kent Tamura  <tkent@chromium.org>
965
966         Reviewed by Dimitri Glazkov.
967
968         [DRT/Chromium] Enable 3D_CANVAS, FILTERS, METER_TAG and PROGRESS_TAG
969         https://bugs.webkit.org/show_bug.cgi?id=39652
970
971         3D_CANVAS and FILTERS have been enabled for Chromium tree
972         build. They fix dozens of unexpected test results in a case of
973         upstreaming build.
974         Enable METER_TAG and PROGRESS_TAG too because they will be enabled
975         in Chromium tree in the near future.
976
977         * features.gypi:
978
979 2010-05-25  Vangelis Kokkevis  <vangelis@chromium.org>
980
981         Reviewed by Darin Fisher.
982
983         The GraphicsContext that serves as a backing store for the root layer
984         updates when doing accelerated compositing is now stored in LayerRendererChromium
985         instead of the Layer itself. Updating code in WebViewImpl to reflect
986         that change.
987         https://bugs.webkit.org/show_bug.cgi?id=39640
988
989         * src/WebViewImpl.cpp:
990         (WebKit::WebViewImpl::updateRootLayerContents):
991
992 2010-05-24  Yury Semikhatsky  <yurys@chromium.org>
993
994         Reviewed by Pavel Feldman.
995
996         ScriptDebugServer is now implemented as DebugEventListener which means it doesn't
997         depend on v8 debugging protocol, instead it uses ExecState to collect debugging
998         info and pass it to the listeners.
999
1000         New implementation of ScriptDebugServer uses methods provided by client to dispatch
1001         its messages while JS is paused(previously the messages was dispatched in a callback
1002         passed to v8 along with DebugEventHandler).
1003
1004         Pause command is dispatched on IO thread.
1005
1006         https://bugs.webkit.org/show_bug.cgi?id=39594
1007
1008         * public/WebDevToolsAgentClient.h:
1009         (WebKit::WebDevToolsAgentClient::ClientMessageLoop::~ClientMessageLoop):
1010         (WebKit::WebDevToolsAgentClient::createClientMessageLoop): Returns an object that allows to run
1011         nested client message loop while script execution is paused on a breakpoint.
1012         * src/DebuggerAgentManager.cpp:
1013         (WebKit::DebuggerAgentManager::setMessageLoopDispatchHandler):
1014         * src/DebuggerAgentManager.h:
1015         * src/WebDevToolsAgentImpl.cpp:
1016         (WebKit::):
1017         (WebKit::WebDevToolsAgentImpl::~WebDevToolsAgentImpl):
1018         (WebKit::WebDevToolsAgentImpl::attach):
1019         * src/js/DebuggerScript.js:
1020         (debuggerScriptConstructor.DebuggerScript.getAfterCompileScript):
1021         (debuggerScriptConstructor.DebuggerScript.stepIntoStatement):
1022         (debuggerScriptConstructor.DebuggerScript.stepOverStatement):
1023         (debuggerScriptConstructor.DebuggerScript.stepOutOfFunction):
1024         * src/js/InspectorControllerImpl.js:
1025         (devtools.InspectorBackendImpl):
1026         (else.devtools.InspectorBackendImpl.prototype.pauseInDebugger): Pause command should be handled on IO
1027         thread so that script can be paused even if it's in an infinite loop.
1028
1029 2010-05-25  Yury Semikhatsky  <yurys@chromium.org>
1030
1031         Reviewed by Pavel Feldman.
1032
1033         Add memory graph to Timeline overview pane.
1034
1035         https://bugs.webkit.org/show_bug.cgi?id=37879
1036
1037         * src/js/devTools.css:
1038         (.timeline-category-statusbar-item input):
1039
1040 2010-05-24  Tony Chang  <tony@chromium.org>
1041
1042         Reviewed by David Levin.
1043
1044         [chromium] Fix zoom tests after r60104
1045         https://bugs.webkit.org/show_bug.cgi?id=39645
1046         
1047         m_zoomFactor moved from Frame to FrameView.  FrameView has separate
1048         notions of page zoom and text zoom.  In my hurried compile fix, I
1049         assumed that m_zoomFactor was for page zoom, but it's not always.
1050
1051         * src/WebViewImpl.cpp:
1052         (WebKit::WebViewImpl::setZoomLevel):
1053
1054 2010-05-24  Kent Tamura  <tkent@chromium.org>
1055
1056         Unreviewed. Sort features.
1057
1058         * features.gypi:
1059
1060 2010-05-24  Kent Tamura  <tkent@chromium.org>
1061
1062         Reviewed by Dimitri Glazkov.
1063
1064         [DRT/Chromium] Import layout_test_helper for Windows
1065         https://bugs.webkit.org/show_bug.cgi?id=39581
1066
1067         * WebKit.gyp: Add a build rule for LayoutTestHelper.exe for Windows.
1068
1069 2010-05-24  Marcus Bulach  <bulach@chromium.org>
1070
1071         Reviewed by Kent Tamura.
1072
1073         [chromium] Adds WebGeolocationServiceMockImpl to remove public dependency on wtf/HashMap.h
1074         https://bugs.webkit.org/show_bug.cgi?id=39587
1075
1076         * public/WebGeolocationServiceMock.h:
1077         * src/WebGeolocationServiceMock.cpp:
1078         (WebKit::WebGeolocationServiceMockImpl::~WebGeolocationServiceMockImpl):
1079         (WebKit::WebGeolocationServiceMock::createWebGeolocationServiceMock):
1080         (WebKit::WebGeolocationServiceMockImpl::requestPermissionForFrame):
1081         (WebKit::WebGeolocationServiceMockImpl::attachBridge):
1082         (WebKit::WebGeolocationServiceMockImpl::detachBridge):
1083
1084 2010-05-24  Tony Chang  <tony@chromium.org>
1085
1086         Reviewed by Kent Tamura.
1087
1088         [chromium] setup fonts on chromium linux DRT
1089         https://bugs.webkit.org/show_bug.cgi?id=39644
1090
1091         * WebKit.gyp:
1092
1093 2010-05-24  Tony Chang  <tony@chromium.org>
1094
1095         Not reviewed, build fix.
1096
1097         Fix the chromium compile due to pageZoomFactor refactoring.
1098
1099         * src/WebViewImpl.cpp:
1100         (WebKit::WebViewImpl::setZoomLevel):
1101
1102 2010-05-24  Darin Adler  <darin@apple.com>
1103
1104         Reviewed by Eric Seidel.
1105
1106         Move view-related functions from Frame to FrameView
1107         https://bugs.webkit.org/show_bug.cgi?id=39366
1108
1109         * src/WebViewImpl.cpp:
1110         (WebKit::WebViewImpl::setZoomLevel): Call setZoomLevel on FrameView.
1111
1112 2010-05-24  Anders Carlsson  <andersca@apple.com>
1113
1114         Attempt to fix the Chromium build.
1115
1116         * src/WebViewImpl.cpp:
1117
1118 2010-05-21  Tony Chang  <tony@chromium.org>
1119
1120         Reviewed by Ojan Vafai.
1121
1122         [chromium] if keydown is prevented, don't update the IME and clear the IME state
1123         https://bugs.webkit.org/show_bug.cgi?id=39475
1124
1125         * src/WebViewImpl.cpp:
1126         (WebKit::WebViewImpl::handleCompositionEvent):
1127
1128 2010-05-23  Roman Gershman  <romange@google.com>
1129
1130         Reviewed by Darin Fisher.
1131
1132         [Chromium] Suggestion popup is not closed when the view is scrolled.
1133         https://bugs.webkit.org/show_bug.cgi?id=38640
1134
1135         This bug appears on both Windows and Linux platforms.
1136         Mac OS, however handles window messages differently and
1137         closes popup menu in RenderWidgetHostViewMac::Destroy().
1138
1139         No tests were added because test_shell does not support suggestion
1140         popup.
1141
1142         * src/ChromeClientImpl.cpp:
1143         (WebKit::ChromeClientImpl::invalidateContentsForSlowScroll):
1144         (WebKit::ChromeClientImpl::scroll):
1145
1146 2010-05-23  Marcus Bulach  <bulach@chromium.org>
1147
1148         Reviewed by Kent Tamura.
1149
1150         [chromium] Adds Geolocation support to DumpRenderTree.
1151         https://bugs.webkit.org/show_bug.cgi?id=39440
1152
1153         Existing LayoutTests/fast/dom/Geolocation/* should pass.
1154
1155         * public/WebGeolocationServiceMock.h:
1156         * src/WebGeolocationServiceMock.cpp:
1157         (WebKit::WebGeolocationServiceMock::setMockGeolocationPermission):
1158         (WebKit::WebGeolocationServiceMock::requestPermissionForFrame):
1159         (WebKit::WebGeolocationServiceMock::attachBridge):
1160         (WebKit::WebGeolocationServiceMock::detachBridge):
1161
1162 2010-05-22  Kent Tamura  <tkent@chromium.org>
1163
1164         Reviewed by Dimitri Glazkov.
1165
1166         [DRT/Chromium] Link resources and load Ahem font for Windows
1167         https://bugs.webkit.org/show_bug.cgi?id=39473
1168
1169         * WebKit.gyp:
1170           Add net and webkit resources for Windows.
1171           Copy AHEM____.TTF to DumpRenderTree.exe directory.
1172
1173 2010-05-21  Steve Block  <steveblock@google.com>
1174
1175         Reviewed by Jeremy Orlow.
1176
1177         Add DeviceOrientation and DeviceOrientationClient
1178         https://bugs.webkit.org/show_bug.cgi?id=39479
1179
1180         * src/WebViewImpl.cpp:
1181         (WebKit::WebViewImpl::WebViewImpl):
1182
1183 2010-05-20  Viet-Trung Luu  <viettrungluu@chromium.org>
1184
1185         Reviewed by Darin Fisher.
1186
1187         [Chromium] Don't rely on focused node to route mouse events to plugins.
1188         https://bugs.webkit.org/show_bug.cgi?id=39375
1189         http://crbug.com/43935
1190
1191         On mouse down, do a hit test and check if a plugin was hit. If so, then
1192         save the node for future mouse events (until mouse up or capture lost).
1193
1194         * src/WebViewImpl.cpp:
1195         (WebKit::WebViewImpl::WebViewImpl):
1196         (WebKit::WebViewImpl::mouseDown):
1197         (WebKit::WebViewImpl::handleInputEvent):
1198         (WebKit::WebViewImpl::mouseCaptureLost):
1199         * src/WebViewImpl.h: Remove m_haveMouseCapture; add m_mouseCaptureNode.
1200
1201 2010-05-20  Dominic Mazzoni  <dmazzoni@chromium.org>
1202
1203         Reviewed by Darin Fisher.
1204
1205         Add headingLevel and setFocused methods.
1206
1207         https://bugs.webkit.org/show_bug.cgi?id=39238
1208
1209         * public/WebAccessibilityObject.h:
1210         * src/WebAccessibilityObject.cpp:
1211         (WebKit::WebAccessibilityObject::headingLevel):
1212         (WebKit::WebAccessibilityObject::setFocused):
1213
1214 2010-05-20  Zhenyao Mo  <zmo@google.com>
1215
1216         Reviewed by Dimitri Glazkov.
1217
1218         Map RGBA4/RGB5_A1 to RGBA and RGB565 to RGB in RenderbufferStorage
1219         https://bugs.webkit.org/show_bug.cgi?id=39077
1220
1221         * src/WebGraphicsContext3DDefaultImpl.cpp:
1222         (WebKit::WebGraphicsContext3DDefaultImpl::renderbufferStorage): Mapping the enums.
1223
1224 2010-05-20  Abhishek Arya  <inferno@chromium.org>
1225
1226         Reviewed by Adam Barth.
1227
1228         Added method to WebSecurityOrigin for invoking
1229         SecurityOrigin::canAccessPasswordManager.
1230         https://bugs.webkit.org/show_bug.cgi?id=38916
1231
1232         * public/WebSecurityOrigin.h:
1233         * src/WebSecurityOrigin.cpp:
1234         (WebKit::WebSecurityOrigin::canAccessPasswordManager):
1235
1236 2010-05-20  Darin Fisher  <darin@chromium.org>
1237
1238         Reviewed by Nate Chapin.
1239
1240         [chromium] Provide a way to catch exceptions thrown while interacting
1241         with a NPObject via WebBindings methods.
1242         https://bugs.webkit.org/show_bug.cgi?id=39378
1243
1244         * public/WebBindings.h:
1245         * src/WebBindings.cpp:
1246         (WebKit::WebBindings::pushExceptionHandler):
1247         (WebKit::WebBindings::popExceptionHandler):
1248
1249 2010-05-20  Jian Li  <jianli@chromium.org>
1250
1251         Reviewed by David Levin.
1252
1253         Rename GenericWorkerTask.h to CrossThreadTask.h and move it to dom directory.
1254         https://bugs.webkit.org/show_bug.cgi?id=39135
1255
1256         * src/WebSharedWorkerImpl.cpp:
1257         * src/WebWorkerBase.cpp:
1258         * src/WebWorkerClientImpl.cpp:
1259         * src/WebWorkerImpl.cpp:
1260
1261 2010-05-20  Martin Robinson  <mrobinson@webkit.org>
1262
1263         Reviewed by Ojan Vafai.
1264
1265         Expose the editing behavior setting in DRT to test all editing code paths
1266         https://bugs.webkit.org/show_bug.cgi?id=38603
1267
1268         * public/WebSettings.h:
1269         (WebKit::WebSettings::): Added an enum for EditingBehavior types.
1270         * src/WebSettingsImpl.cpp: 
1271         (WebKit::WebSettingsImpl::setEditingBehavior): Added.
1272         * src/WebSettingsImpl.h:
1273
1274 2010-05-19  Vangelis Kokkevis  <vangelis@chromium.org>
1275
1276         Reviewed by Darin Fisher.
1277
1278         Modifying WebViewImpl to support new hardware compositing for
1279         LayerChromium layers.
1280         https://bugs.webkit.org/show_bug.cgi?id=38783
1281
1282         * src/WebViewImpl.cpp:
1283         (WebKit::WebViewImpl::paint):
1284         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
1285         (WebKit::WebViewImpl::updateRootLayerContents):
1286         (WebKit::WebViewImpl::setRootLayerNeedsDisplay):
1287
1288 2010-05-19  Tony Chang  <tony@chromium.org>
1289
1290         Reviewed by Kent Tamura.
1291
1292         [chromium] disable spelling suggestions if spellcheck=false
1293         https://bugs.webkit.org/show_bug.cgi?id=39402
1294         
1295         This is the Chromium fix for bug 25639 that was fixed in the
1296         other ports in r59585.
1297
1298         * src/ContextMenuClientImpl.cpp:
1299         (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
1300
1301 2010-05-19  Darin Fisher  <darin@chromium.org>
1302
1303         Revert r59790 due to failing Chromium npruntime tests.
1304
1305         * public/WebBindings.h:
1306         * src/WebBindings.cpp:
1307
1308 2010-05-19  Darin Fisher  <darin@chromium.org>
1309
1310         Reviewed by Nate Chapin.
1311
1312         [chromium] Provide a way to catch exceptions thrown while interacting
1313         with a NPObject via WebBindings methods.
1314         https://bugs.webkit.org/show_bug.cgi?id=39378
1315
1316         * public/WebBindings.h:
1317         * src/WebBindings.cpp:
1318         (WebKit::WebBindings::pushExceptionHandler):
1319         (WebKit::WebBindings::popExceptionHandler):
1320
1321 2010-05-19  Dirk Pranke  <dpranke@chromium.org>
1322
1323         Try again to roll out r58765.
1324
1325         * public/WebNotification.h:
1326         * src/WebNotification.cpp:
1327
1328 2010-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>
1329
1330         Unreviewed, rolling out r59782.
1331         http://trac.webkit.org/changeset/59782
1332         https://bugs.webkit.org/show_bug.cgi?id=39379
1333
1334         broke DRT build (Requested by dpranke on #webkit).
1335
1336         * public/WebNotification.h:
1337         * src/WebNotification.cpp:
1338         (WebKit::WebNotification::dir):
1339         (WebKit::WebNotification::replaceId):
1340
1341 2010-05-19  Jian Li  <jianli@chromium.org>
1342
1343         Reviewed by Darin Fisher.
1344
1345         Remove obsolete ChromiumBridge code that routes FileSystem calls to WebKitClient.
1346         https://bugs.webkit.org/show_bug.cgi?id=39332
1347
1348         * public/WebKitClient.h:
1349         * src/ChromiumBridge.cpp:
1350         (WebCore::ChromiumBridge::fileExists):
1351         (WebCore::ChromiumBridge::deleteFile):
1352         (WebCore::ChromiumBridge::deleteEmptyDirectory):
1353         (WebCore::ChromiumBridge::getFileSize):
1354         (WebCore::ChromiumBridge::getFileModificationTime):
1355         (WebCore::ChromiumBridge::directoryName):
1356         (WebCore::ChromiumBridge::pathByAppendingComponent):
1357         (WebCore::ChromiumBridge::makeAllDirectories):
1358         (WebCore::ChromiumBridge::getAbsolutePath):
1359         (WebCore::ChromiumBridge::isDirectory):
1360         (WebCore::ChromiumBridge::filePathToURL):
1361
1362 2010-05-19  Marcus Bulach  <bulach@chromium.org>
1363
1364         Reviewed by Steve Block.
1365
1366         [chromium] Adds supports for layout tests using GeolocationServiceMock.
1367         https://bugs.webkit.org/show_bug.cgi?id=39081
1368
1369         Allows injection of GeolocationServiceMock factory.
1370         Tests: existing fast/dom/Geolocation/*
1371
1372         * WebKit.gyp:
1373         * public/WebGeolocationServiceMock.h: Added.
1374         * src/WebGeolocationServiceMock.cpp: Added.
1375         (WebCore::GeolocationServiceChromiumMock::create):
1376         (WebCore::GeolocationServiceChromiumMock::GeolocationServiceChromiumMock):
1377         (WebCore::GeolocationServiceChromiumMock::startUpdating):
1378         (WebCore::GeolocationServiceChromiumMock::stopUpdating):
1379         (WebCore::GeolocationServiceChromiumMock::lastPosition):
1380         (WebCore::GeolocationServiceChromiumMock::lastError):
1381         (WebCore::GeolocationServiceChromiumMock::geolocationServicePositionChanged):
1382         (WebCore::GeolocationServiceChromiumMock::geolocationServiceErrorOccurred):
1383         (WebKit::WebGeolocationServiceMock::setMockGeolocationPosition):
1384         (WebKit::WebGeolocationServiceMock::setMockGeolocationError):
1385
1386 2010-05-17  Jeremy Orlow  <jorlow@chromium.org>
1387
1388         Reviewed by Darin Fisher.
1389
1390         Hook Chromium's WebIndexedDatabaseImpl up to IndexedDatabaseImpl
1391         https://bugs.webkit.org/show_bug.cgi?id=39216
1392
1393         Web____Impl is for re-entering the WebKit layer from the browser layer.
1394         Thus the previous IDBCallbacksProxy was mis-named (and should have been
1395         WebIDBCallbacksImpl).  This patch renames it and then implements the
1396         proper proxy (which is for going from WebCore to WebKit).
1397
1398         Also change using security origin strings to using WebSecurityOrigin
1399         objects.
1400
1401         This patch also implements the glue between WebIndexedDatabaseImpl and
1402         IndexedDatabaseImpl.
1403
1404         * WebKit.gyp:
1405         * src/IDBCallbacksProxy.cpp:
1406         (WebCore::IDBCallbacksProxy::create):
1407         (WebCore::IDBCallbacksProxy::IDBCallbacksProxy):
1408         (WebCore::IDBCallbacksProxy::onError):
1409         (WebCore::IDBCallbacksProxy::onSuccess):
1410         * src/IDBCallbacksProxy.h:
1411         * src/IndexedDatabaseProxy.cpp:
1412         (WebCore::IndexedDatabaseProxy::open):
1413         * src/IndexedDatabaseProxy.h:
1414         * src/WebIDBCallbacksImpl.cpp: Added.
1415         (WebCore::WebIDBCallbacksImpl::WebIDBCallbacksImpl):
1416         (WebCore::WebIDBCallbacksImpl::~WebIDBCallbacksImpl):
1417         (WebCore::WebIDBCallbacksImpl::onError):
1418         (WebCore::WebIDBCallbacksImpl::onSuccess):
1419         * src/WebIDBCallbacksImpl.h: Added.
1420         * src/WebIDBDatabaseImpl.cpp: Added.
1421         (WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl):
1422         (WebKit::WebIDBDatabaseImpl::~WebIDBDatabaseImpl):
1423         * src/WebIDBDatabaseImpl.h: Added.
1424         * src/WebIndexedDatabaseImpl.cpp:
1425         (WebKit::WebIndexedDatabaseImpl::WebIndexedDatabaseImpl):
1426         (WebKit::WebIndexedDatabaseImpl::open):
1427         * src/WebIndexedDatabaseImpl.h:
1428
1429 2010-05-18  Kent Tamura  <tkent@chromium.org>
1430
1431         Reviewed by Dimitri Glazkov.
1432
1433         [DRT/Chromium] Fix a repaint issue and textarea tests
1434         https://bugs.webkit.org/show_bug.cgi?id=39054
1435
1436         * DEPS: Update to Chromium r47248 to use a fix for CommandLine assertion
1437           and textAreaResizeCorner.png
1438         * WebKit.gyp: Add textAreaResizeCorner.png as a Mac resource
1439
1440 2010-05-18  Tony Chang  <tony@chromium.org>
1441
1442         Reviewed by Ojan Vafai.
1443
1444         [chromium] ignore IME events if the keydown event was prevented
1445         https://bugs.webkit.org/show_bug.cgi?id=37692
1446
1447         * src/WebViewImpl.cpp:
1448         (WebKit::WebViewImpl::handleCompositionEvent):
1449
1450 2010-05-18  MORITA Hajime  <morrita@google.com>
1451
1452         Reviewed by Kent Tamura.
1453
1454         [Chromium] Windows: Determinate progress bar should have glossy overlay
1455         https://bugs.webkit.org/show_bug.cgi?id=39269
1456
1457         Changed WebThemeEngine::drawProgressBar() signature to delegate
1458         theme implementation detail to the engine.
1459         Chromium side will come to http://crbug.com/44430.
1460         
1461         No new tests, animation effect can be confirmed only manually.        
1462
1463         * public/WebThemeEngine.h:
1464         (WebKit::WebThemeEngine::paintProgressBar):
1465         * src/ChromiumBridge.cpp:
1466         (WebCore::ChromiumBridge::paintProgressBar):
1467
1468 2010-05-16  Mike Belshe  <mbelshe@chromium.org>
1469
1470         Reviewed by Dimitri Glazkov.
1471
1472         Add a flag to the ResourceResponse for tracking if a request was
1473         fetched via the TLS/Next-Protocol-Negotiation mechanism.
1474
1475         Also cleaned up the style in ResourceResponse to group the flags
1476         together (and alphabetically) and hopefully improve readability of
1477         the file.
1478
1479         https://bugs.webkit.org/show_bug.cgi?id=39078
1480
1481         * public/WebURLResponse.h:
1482         * src/WebURLResponse.cpp:
1483         (WebKit::WebURLResponse::wasNpnNegotiated):
1484         (WebKit::WebURLResponse::setWasNpnNegotiated):
1485
1486 2010-05-16  Eric Seidel  <eric@webkit.org>
1487
1488         Unreviewed, rolling out r59571.
1489         http://trac.webkit.org/changeset/59571
1490         https://bugs.webkit.org/show_bug.cgi?id=39054
1491
1492         Broke Cr Win, but we didn't notice immediately due to
1493         https://bugs.webkit.org/show_bug.cgi?id=38926.  It's possible
1494         that this didn't actually break Cr Win, but rather that bug
1495         38926 necessitates a clean compile after this and sucessive
1496         checkins only produced a partial recompile and thus failed to
1497         build.
1498
1499         * DEPS:
1500         * WebKit.gyp:
1501         * features.gypi:
1502
1503 2010-05-16  Sheriff Bot  <webkit.review.bot@gmail.com>
1504
1505         Unreviewed, rolling out r59574.
1506         http://trac.webkit.org/changeset/59574
1507         https://bugs.webkit.org/show_bug.cgi?id=39176
1508
1509         Supposedly broke cr-win, but the errors seems somewhat
1510         unrelated (Requested by abarth on #webkit).
1511
1512         * public/WebURLResponse.h:
1513         * src/WebURLResponse.cpp:
1514
1515 2010-05-16  Mike Belshe  <mbelshe@chromium.org>
1516
1517         Reviewed by Dimitri Glazkov.
1518
1519         Add a flag to the ResourceResponse for tracking if a request was
1520         fetched via the TLS/Next-Protocol-Negotiation mechanism.
1521
1522         Also cleaned up the style in ResourceResponse to group the flags
1523         together (and alphabetically) and hopefully improve readability of
1524         the file.
1525
1526         https://bugs.webkit.org/show_bug.cgi?id=39078
1527
1528         * public/WebURLResponse.h:
1529         * src/WebURLResponse.cpp:
1530         (WebKit::WebURLResponse::wasNpnNegotiated):
1531         (WebKit::WebURLResponse::setWasNpnNegotiated):
1532
1533 2010-05-16  Kent Tamura  <tkent@chromium.org>
1534
1535         Reviewed by Dimitri Glazkov.
1536
1537         [DRT/Chromium] Fix repaint, WebGL, textarea tests
1538         https://bugs.webkit.org/show_bug.cgi?id=39054
1539
1540         * DEPS: Update to Chromium r47248 to use a fix for CommandLine assertion
1541           and textAreaResizeCorner.png
1542         * WebKit.gyp: Add textAreaResizeCorner.png as a Mac resource
1543         * features.gypi: Enable ENABLE_3D_CANVAS.
1544
1545 2010-05-15  Darin Fisher  <darin@chromium.org>
1546
1547         Reviewed by Adam Barth.
1548
1549         [chromium] Expose element accessor on WebPluginContainer
1550         https://bugs.webkit.org/show_bug.cgi?id=39152
1551
1552         * public/WebPluginContainer.h:
1553         * src/WebPluginContainerImpl.cpp:
1554         (WebKit::WebPluginContainerImpl::element):
1555         * src/WebPluginContainerImpl.h:
1556
1557 2010-05-15  Jochen Eisinger  <jochen@chromium.org>
1558
1559         Reviewed by Dmitry Titov.
1560
1561         Implement canEstablishDatabase call for workers.
1562         https://bugs.webkit.org/show_bug.cgi?id=38742
1563
1564         * public/WebCommonWorkerClient.h:
1565         * src/DatabaseObserver.cpp:
1566         (WebCore::DatabaseObserver::canEstablishDatabase):
1567         * src/WebWorkerBase.cpp:
1568         (WebKit::WebWorkerBase::allowDatabase):
1569         (WebKit::WebWorkerBase::allowDatabaseTask):
1570         (WebKit::WebWorkerBase::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge):
1571         (WebKit::WebWorkerBase::AllowDatabaseMainThreadBridge::cancel):
1572         (WebKit::WebWorkerBase::AllowDatabaseMainThreadBridge::result):
1573         (WebKit::WebWorkerBase::AllowDatabaseMainThreadBridge::signalCompleted):
1574         (WebKit::WebWorkerBase::AllowDatabaseMainThreadBridge::didComplete):
1575         * src/WebWorkerBase.h:
1576         * src/WebWorkerClientImpl.h:
1577         (WebKit::WebWorkerClientImpl::allowDatabase):
1578
1579 2010-05-15  Jay Civelli  <jcivelli@chromium.org>
1580
1581         Reviewed by Darin Fisher.
1582
1583         [chromium] Adding a notification on WebViewClient when a new 
1584         node gets focused.
1585         https://bugs.webkit.org/show_bug.cgi?id=38508
1586
1587         * public/WebViewClient.h:
1588         (WebKit::WebViewClient::focusedNodeChanged):
1589         * src/ChromeClientImpl.cpp:
1590         (WebKit::ChromeClientImpl::focusedNodeChanged):
1591
1592 2010-05-15  Evan Stade  <estade@chromium.org>
1593
1594         Reviewed by Adam Barth.
1595
1596         [chromium] "Check spelling in this field" context menu item always checked
1597         https://bugs.webkit.org/show_bug.cgi?id=39018
1598
1599         Initialize all POD members of WebContextMenuData in a default
1600         constructor.
1601
1602         No tests because this code would need some major refactoring to unit
1603         test, and AFAICT it's not testable via layout tests. See note at top
1604         of getCustomMenuFromDefaultItems.
1605
1606         * public/WebContextMenuData.h:
1607         (WebKit::WebContextMenuData::WebContextMenuData):
1608         * src/ContextMenuClientImpl.cpp:
1609         (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
1610
1611 2010-05-14  Darin Fisher  <darin@chromium.org>
1612
1613         Reviewed by Dimitri Glazkov.
1614
1615         [chromium] Remove temporary relative include paths
1616         https://bugs.webkit.org/show_bug.cgi?id=38776
1617
1618         * public/WebPasswordAutocompleteListener.h:
1619         * src/FrameLoaderClientImpl.h:
1620         * src/PlatformMessagePortChannel.h:
1621         * src/WebAnimationControllerImpl.h:
1622         * src/WebBindings.cpp:
1623         * src/WebDataSourceImpl.h:
1624         * src/WebDevToolsAgentPrivate.h:
1625         * src/WebFileChooserCompletionImpl.h:
1626         * src/WebFrameImpl.h:
1627         * src/WebInputEventConversion.h:
1628         * src/WebPluginContainerImpl.h:
1629         * src/WebPluginLoadObserver.h:
1630         * src/WebPopupMenuImpl.h:
1631         * src/WebSettingsImpl.h:
1632         * src/WebViewImpl.h:
1633         * src/WebWorkerClientImpl.h:
1634         * src/WrappedResourceRequest.h:
1635         * src/WrappedResourceResponse.h:
1636
1637 2010-05-14  Anton Muhin  <antonm@chromium.org>
1638
1639         Reviewed by Darin Fisher.
1640
1641         [Chromium] Consider implementing addOriginAccessWhitelistEntry method
1642         https://bugs.webkit.org/show_bug.cgi?id=37578
1643
1644         Remove deprecated methods.
1645
1646         * public/WebSecurityPolicy.h:
1647         * src/WebSecurityPolicy.cpp:
1648
1649 2010-05-14  Kenneth Russell  <kbr@google.com>
1650
1651         Reviewed by Darin Adler.
1652
1653         Rename WebGLArray types to TypedArray types
1654         https://bugs.webkit.org/show_bug.cgi?id=39091
1655
1656         Extended functionality of do-webcore-rename script and used it to
1657         rename the WebGLArray types to the TypedArray naming convention.
1658         The only source files which were touched by hand, and which are
1659         being manually reviewed, are:
1660             WebCore/page/DOMWindow.idl
1661             WebCore/bindings/generic/RuntimeEnabledFeatures.h (script's changes undone)
1662             WebKit/WebCore/bindings/js/JSDOMWindowCustom.cpp
1663             WebKit/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp
1664         These only needed to be touched to update the aliases between the
1665         WebGLArray and TypedArray names introduced in bug 39036. (It was
1666         not feasible to have do-webcore-rename handle this as it would
1667         introduce circular renamings.) These aliases will be removed in
1668         roughly a month once existing WebGL content has been updated.
1669
1670         No new tests; covered under existing WebGL tests. Updated
1671         constructed-objects-prototypes and prototype-inheritance-2 tests.
1672         Ran all layout tests in Safari and all WebGL tests in Chromium.
1673
1674         * src/GraphicsContext3D.cpp:
1675         (WebCore::GraphicsContext3DInternal::bufferData):
1676         (WebCore::GraphicsContext3DInternal::bufferSubData):
1677
1678 2010-05-14  Jochen Eisinger  <jochen@chromium.org>
1679
1680         Reviewed by Eric Seidel.
1681
1682         Make ImageDiff depend on webkit (again).
1683         https://bugs.webkit.org/show_bug.cgi?id=39000
1684
1685         * WebKit.gyp:
1686
1687 2010-05-14  James Simonsen  <simonjam+webkit@google.com>
1688
1689         Reviewed by Darin Fisher.
1690
1691         [chromium] Expose volume through WebMediaPlayerClient
1692         https://bugs.webkit.org/show_bug.cgi?id=38947
1693
1694         * public/WebMediaPlayerClient.h:
1695         * src/WebMediaPlayerClientImpl.cpp:
1696         (WebKit::WebMediaPlayerClientImpl::volume):
1697         * src/WebMediaPlayerClientImpl.h:
1698
1699 2010-05-14  Tony Gentilcore  <tonyg@chromium.org>
1700
1701         Reviewed by Darin Fisher.
1702
1703         [chromium] Update chromium port to send/receive cached metadata
1704         https://bugs.webkit.org/show_bug.cgi?id=38665
1705
1706         * public/WebKitClient.h:
1707         (WebKit::WebKitClient::cacheMetadata):
1708         * public/WebURLLoaderClient.h:
1709         (WebKit::WebURLLoaderClient::didReceiveCachedMetadata):
1710         * public/WebURLResponse.h:
1711         * src/ChromiumBridge.cpp:
1712         (WebCore::ChromiumBridge::cacheMetadata):
1713         * src/ResourceHandle.cpp:
1714         (WebCore::ResourceHandleInternal::didReceiveCachedMetadata):
1715         (WebCore::ResourceHandle::cacheMetadata):
1716         * src/WebURLResponse.cpp:
1717         (WebKit::WebURLResponse::responseTime):
1718         (WebKit::WebURLResponse::setResponseTime):
1719
1720 2010-05-13  Tony Chang  <tony@chromium.org>
1721
1722         Reviewed by Kent Tamura.
1723
1724         [chromium] enable DRT build in chromium (for the last time)
1725         https://bugs.webkit.org/show_bug.cgi?id=39109
1726
1727         * WebKit.gyp:
1728
1729 2010-05-13  Pavel Feldman  <pfeldman@chromium.org>
1730
1731         Reviewed by Yury Semikhatsky.
1732
1733         Web Inspector: main inspector toolbar takes noticeable time to expand.
1734
1735         https://bugs.webkit.org/show_bug.cgi?id=39013
1736
1737         * src/js/DevTools.js:
1738         (devtools.domContentLoaded):
1739
1740 2010-05-12  Hans Wennborg  <hans@chromium.org>
1741
1742         Reviewed by Jeremy Orlow.
1743
1744         [Chromium] Remove transitional functions from WebStorageNamespace and WebViewClient.
1745         https://bugs.webkit.org/show_bug.cgi?id=38985
1746
1747         These functions are no longer called as of Chromium revision 47020.
1748         This is part of resolving http://crbug.com/42740
1749
1750         * public/WebStorageNamespace.h:
1751         * public/WebViewClient.h:
1752         (WebKit::WebViewClient::createSessionStorageNamespace):
1753
1754 2010-05-12  Tony Chang  <tony@chromium.org>
1755
1756         Reviewed by Kent Tamura.
1757
1758         [chromium] disable DRT in chromium again
1759         https://bugs.webkit.org/show_bug.cgi?id=39049
1760
1761         * WebKit.gyp:
1762
1763 2010-05-12  John Abd-El-Malek  <jam@chromium.org>
1764
1765         Reviewed by Darin Fisher.
1766
1767         [chromium] Disable WebScrollbarImpl's scrollbar if it's not needed
1768         https://bugs.webkit.org/show_bug.cgi?id=39025
1769
1770         * src/WebScrollbarImpl.cpp:
1771         (WebKit::WebScrollbarImpl::setLocation):
1772         (WebKit::WebScrollbarImpl::setDocumentSize):
1773
1774 2010-05-12  Dumitru Daniliuc  <dumi@chromium.org>
1775
1776         Reviewed by Dimitri Glazkov.
1777
1778         Removing the unnecessary dirfd parameter.
1779         https://bugs.webkit.org/show_bug.cgi?id=38869
1780
1781         * public/WebKitClient.h:
1782         (WebKit::WebKitClient::databaseOpenFile):
1783         * src/ChromiumBridge.cpp:
1784         (WebCore::ChromiumBridge::databaseOpenFile):
1785
1786 2010-05-12  Jeremy Orlow  <jorlow@chromium.org>
1787
1788         Reviewed by Steve Block.
1789
1790         [Chromium] Pass the origin parameter for WebIndexedDatabase::open
1791         https://bugs.webkit.org/show_bug.cgi?id=38983
1792
1793         * public/WebIndexedDatabase.h:
1794         * src/IndexedDatabaseProxy.cpp:
1795         (WebCore::IndexedDatabaseProxy::open):
1796         * src/WebIndexedDatabaseImpl.cpp:
1797         (WebKit::WebIndexedDatabaseImpl::open):
1798         * src/WebIndexedDatabaseImpl.h:
1799
1800 2010-05-10  yael aharon  <yael.aharon@nokia.com>
1801
1802         Reviewed by Darin Adler.
1803
1804         Support control attribute of HTMLLabelElement
1805         https://bugs.webkit.org/show_bug.cgi?id=38688
1806
1807         Renamed HTMLLabelElement::correspondingControl to HTMLLabelElement::control
1808
1809         * src/WebLabelElement.cpp:
1810         (WebKit::WebLabelElement::correspondingControl):
1811
1812 2010-05-12  MORITA Hajime  <morrita@google.com>
1813
1814         Reviewed by Kent Tamura.
1815         
1816         [Chromium] Support HTML5 <progress> element on Windows.
1817         https://bugs.webkit.org/show_bug.cgi?id=37308
1818
1819         Extended ChromiumBridge to handle progress bar painting,
1820         and added delegations to it.
1821         
1822         No new tests. Test cases should be shared with existing ones for
1823         progress element.  Expectaions will be added after PROGRESS_TAG is
1824         enabled on Chromium tree.
1825
1826         * public/WebThemeEngine.h:
1827         (WebKit::WebThemeEngine::paintProgressBar):
1828         * src/ChromiumBridge.cpp:
1829         (WebCore::ChromiumBridge::paintProgressBar):
1830
1831 2010-05-12  Marcus Bulach  <bulach@chromium.org>
1832
1833         Reviewed by Steve Block.
1834
1835         Attaches the geolocation bridge later on startUpdating().
1836         This prevents a page requesting permission when it has just accessed navigator.geolocation (without calling navigator.geolocation.getCurrentPosition/watchPosition).
1837         Note: when Geolocation::haveSuitableCachedPosition(), WebGeolocationServiceBridgeImpl::startUpdating() is not called,
1838         so we attach the bridge if needed at requestGeolocationPermissionForFrame().
1839         https://bugs.webkit.org/show_bug.cgi?id=38323
1840         http://crbug.com/42789
1841
1842         * src/ChromeClientImpl.cpp:
1843         (WebKit::ChromeClientImpl::requestGeolocationPermissionForFrame):
1844         * src/WebGeolocationServiceBridgeImpl.cpp:
1845         (WebKit::WebGeolocationServiceBridgeImpl::attachBridgeIfNeeded):
1846         (WebKit::WebGeolocationServiceBridgeImpl::setLastPosition):
1847
1848 2010-05-12  Tony Chang  <tony@chromium.org>
1849
1850         Reviewed by Kent Tamura.
1851
1852         [chromium] add DRT back to the chromium build
1853         https://bugs.webkit.org/show_bug.cgi?id=38978
1854
1855         * WebKit.gyp:
1856
1857 2010-05-11  Kent Tamura  <tkent@chromium.org>
1858
1859         Reviewed by Dimitri Glazkov.
1860
1861         [DRT/Chromium] Apply recent changes of test_shell to DRT
1862         https://bugs.webkit.org/show_bug.cgi?id=38895
1863
1864         * DEPS: Update Chromium revision to use the recent webkit_support change.
1865         * WebKit.gyp: Add JavaScriptCore/wtf to 'include' section.
1866         * src/WebGraphicsContext3D.cpp:
1867           Remove ENABLE(3D_CANVAS) to provide an empty implementation of
1868           WebGraphicsContext3D::createDefault().
1869
1870 2010-05-11  Avi Drissman  <avi@chromium.org>
1871
1872         Reviewed by Darin Fisher.
1873
1874         [Chromium] Pipe RTL info into WebPopupMenuInfo
1875         https://bugs.webkit.org/show_bug.cgi?id=38749
1876
1877         * public/WebPopupMenuInfo.h:
1878         * src/ChromeClientImpl.cpp:
1879         (WebKit::ChromeClientImpl::getPopupMenuInfo):
1880
1881 2010-05-11  David Holloway  <dhollowa@chromium.org>
1882
1883         Reviewed by Darin Fisher.
1884
1885         [chromium] Add size method to WebInputElement class, providing same data
1886         as HTMLInputElement::size().  During form AutoFill Chromium needs to
1887         access the input element's size attribute in aid of form matching and
1888         filling heuristics.
1889         
1890         https://bugs.webkit.org/show_bug.cgi?id=38825
1891
1892         * public/WebInputElement.h:
1893         * src/WebInputElement.cpp:
1894         (WebKit::WebInputElement::size):
1895
1896 2010-05-11  Nate Chapin  <japhet@chromium.org>
1897
1898         Reviewed by Adam Barth.
1899
1900         Crash fix in WebPageSerializerImpl::serialize().
1901
1902         https://bugs.webkit.org/show_bug.cgi?id=38543
1903
1904         The relevant test is a test_shell_test in src.chromium.org, because neither
1905         DRT nor the Chromium webkit unit tests can currently cover the serializer
1906         functionality.
1907
1908         * src/WebPageSerializerImpl.cpp:
1909         (WebKit::WebPageSerializerImpl::serialize): Check each frame's url before using it,
1910             since they are not guaranteed to be valid (e.g., if the frame was treated as a download).
1911
1912 2010-05-11  Jian Li  <jianli@chromium.org>
1913
1914         Reviewed by Dmitry Titov.
1915
1916         Expose FileReader interface.
1917         https://bugs.webkit.org/show_bug.cgi?id=38609
1918
1919         * features.gypi: turn on building FileReader for Chromium.
1920
1921 2010-05-10  Tony Chang  <tony@chromium.org>
1922
1923         Reviewed by Kent Tamura.
1924
1925         [chromium] don't build DRT in chromium checkouts due to a circular gyp dependency
1926         https://bugs.webkit.org/show_bug.cgi?id=38889
1927
1928         * WebKit.gyp:
1929
1930 2010-05-10  John Abd-El-Malek  <jam@chromium.org>
1931
1932         Reviewed by Darin Fisher.
1933
1934         [chromium] Add WebKitScrollbar interface to allow Chromium code to reuse the scrollbar code
1935         https://bugs.webkit.org/show_bug.cgi?id=38854
1936
1937         * public/WebScrollbar.h: Added.
1938         (WebKit::WebScrollbar::):
1939         (WebKit::WebScrollbar::~WebScrollbar):
1940         * public/WebScrollbarClient.h: Added.
1941         * public/WebThemeEngine.h:
1942         * src/AssertMatchingEnums.cpp:
1943         * src/WebScrollbarImpl.cpp: Added.
1944         (WebKit::WebScrollbar::create):
1945         (WebKit::WebScrollbar::defaultThickness):
1946         (WebKit::WebScrollbarImpl::WebScrollbarImpl):
1947         (WebKit::WebScrollbarImpl::~WebScrollbarImpl):
1948         (WebKit::WebScrollbarImpl::setLocation):
1949         (WebKit::WebScrollbarImpl::value):
1950         (WebKit::WebScrollbarImpl::setValue):
1951         (WebKit::WebScrollbarImpl::setDocumentSize):
1952         (WebKit::WebScrollbarImpl::scroll):
1953         (WebKit::WebScrollbarImpl::paint):
1954         (WebKit::WebScrollbarImpl::handleInputEvent):
1955         (WebKit::WebScrollbarImpl::onMouseDown):
1956         (WebKit::WebScrollbarImpl::onMouseUp):
1957         (WebKit::WebScrollbarImpl::onMouseMove):
1958         (WebKit::WebScrollbarImpl::onMouseLeave):
1959         (WebKit::WebScrollbarImpl::onMouseWheel):
1960         (WebKit::WebScrollbarImpl::onKeyDown):
1961         (WebKit::WebScrollbarImpl::valueChanged):
1962         (WebKit::WebScrollbarImpl::invalidateScrollbarRect):
1963         (WebKit::WebScrollbarImpl::isActive):
1964         (WebKit::WebScrollbarImpl::scrollbarCornerPresent):
1965         (WebKit::WebScrollbarImpl::getTickmarks):
1966         * src/WebScrollbarImpl.h: Added.
1967         * src/WebViewImpl.cpp:
1968         (WebKit::WebViewImpl::scrollViewWithKeyboard):
1969         (WebKit::WebViewImpl::mapKeyCodeForScroll):
1970         * src/WebViewImpl.h:
1971
1972 2010-05-10  Tony Gentilcore  <tonyg@chromium.org>
1973
1974         Reviewed by Adam Barth.
1975
1976         Provide mechanism to cache metadata for a resource
1977         https://bugs.webkit.org/show_bug.cgi?id=37874
1978
1979         * src/ResourceHandle.cpp:
1980         (WebCore::ResourceHandle::cacheMetadata):
1981
1982 2010-05-10  Hans Wennborg  <hans@chromium.org>
1983
1984         Reviewed by Jeremy Orlow.
1985
1986         [Chromium] Add quota parameter to WebViewClient::createSessionStorageNamespace()
1987         https://bugs.webkit.org/show_bug.cgi?id=38750
1988
1989         Put a per-origin quota on session storage since it is using memory in
1990         the browser process, and should not be allowed to grow arbitrarily
1991         large. See also http://trac.webkit.org/changeset/58828.
1992
1993         * public/WebStorageNamespace.h:
1994         * public/WebViewClient.h:
1995         (WebKit::WebViewClient::createSessionStorageNamespace):
1996         * src/StorageNamespaceProxy.cpp:
1997         (WebCore::StorageNamespace::sessionStorageNamespace):
1998
1999
2000 2010-05-10  Jeremy Orlow  <jorlow@chromium.org>
2001
2002         Reviewed by Nate Chapin.
2003
2004         Change IndexedDB to use events instead of callbacks
2005         https://bugs.webkit.org/show_bug.cgi?id=38594
2006
2007         Change the glue here to match the changes I made in WebCore.
2008
2009         * WebKit.gyp:
2010         * public/WebIDBCallbacks.h:
2011         * public/WebIndexedDatabase.h:
2012         * src/IDBCallbacksProxy.cpp: Added.
2013         (WebCore::IDBCallbacksProxy::IDBCallbacksProxy):
2014         (WebCore::IDBCallbacksProxy::~IDBCallbacksProxy):
2015         (WebCore::IDBCallbacksProxy::onError):
2016         (WebCore::IDBCallbacksProxy::onSuccess):
2017         * src/IDBCallbacksProxy.h:
2018         * src/IndexedDatabaseProxy.cpp:
2019         (WebCore::IndexedDatabaseProxy::open):
2020         * src/IndexedDatabaseProxy.h:
2021         * src/WebIndexedDatabaseImpl.cpp:
2022         (WebKit::WebIndexedDatabaseImpl::open):
2023         * src/WebIndexedDatabaseImpl.h:
2024
2025 2010-05-08  Jens Alfke  <snej@chromium.org>
2026
2027         Reviewed by Darin Fisher.
2028
2029         [chromium] WebFrame::registerPasswordListener shouldn't assert on duplicate listener.
2030         https://bugs.webkit.org/show_bug.cgi?id=38765
2031
2032         * public/WebFrame.h:
2033         (WebKit::WebFrameImpl::registerPasswordListener): Changed return type to bool. Updated comment.
2034         * src/WebFrameImpl.cpp:
2035         (WebKit::WebFrameImpl::registerPasswordListener): Return false instead of asserting.
2036         * src/WebFrameImpl.h:
2037         (WebKit::WebFrameImpl::registerPasswordListener): Changed return type to bool.
2038
2039 2010-05-08  Michael Nordman  <michaeln@google.com>
2040
2041         Reviewed by Dmitry Titov.
2042
2043         Add an additional parameter to the WebSharedWorker::startWorkerContext method
2044         to indicate which appcache the shared worker script resource was loaded from,
2045         and provide that value when calling out to chrome via this interface.
2046         https://bugs.webkit.org/show_bug.cgi?id=38605
2047
2048         I'm keeping the old method around until patches can land in both repositories
2049         that make the old method obsolete and unneeded. There's a FIXME for that.
2050
2051         Also somewhat related but independent change to propagate the runtime enabled 
2052         flag thru to the page settings instance used by the 'shadow page'.
2053  
2054         * public/WebSharedWorker.h: Add the new param (but keep the old interface around for now too)
2055         (WebKit::WebSharedWorker::startWorkerContext):
2056         * src/SharedWorkerRepository.cpp: Provide the value when calling out to chrome.
2057         (WebCore::SharedWorkerScriptLoader::notifyFinished):
2058         * src/WebSharedWorkerImpl.cpp:
2059         (WebKit::WebSharedWorkerImpl::startWorkerContext):
2060         * src/WebSharedWorkerImpl.h:
2061         * src/WebWorkerBase.cpp: Propagate runtime enabled flag thru to the page settings.
2062         (WebKit::WebWorkerBase::initializeLoader):
2063
2064 2010-05-07  Darin Fisher  <darin@chromium.org>
2065
2066         Fix build bustage.  Update to Chromium code that avoids a bad
2067         dependency from net/ on chrome/.
2068
2069         * DEPS:
2070
2071 2010-05-07  Darin Fisher  <darin@chromium.org>
2072
2073         Fix build bustage.  Update to Chromium code that no longer uses
2074         deprecated methods.
2075
2076         * DEPS:
2077
2078 2010-05-07  Darin Fisher  <darin@chromium.org>
2079
2080         Reviewed by Dimitri Glazkov.
2081
2082         [chromium] clear out more deprecated methods that are no longer used
2083         https://bugs.webkit.org/show_bug.cgi?id=38702
2084
2085         * public/WebFrame.h:
2086         * public/WebNode.h:
2087         * src/WebFrameImpl.cpp:
2088         * src/WebFrameImpl.h:
2089         * src/WebNode.cpp:
2090
2091 2010-05-07  Finnur Thorarinsson  <finnur.webkit@gmail.com>
2092
2093         Reviewed by Dimitri Glazkov.
2094
2095         [chromium]: Fixing Find in page crash on sites.google.com
2096         https://bugs.webkit.org/show_bug.cgi?id=38591
2097         
2098         setMarkerActive should not try to set a collapsed marker as
2099         active. This can happen when you Edit a Sites page after doing
2100         a Find operation and then you press FindNext.
2101         
2102         * src/WebFrameImpl.cpp:
2103         (WebKit::WebFrameImpl::setMarkerActive):
2104
2105 2010-05-06  Kent Tamura  <tkent@chromium.org>
2106
2107         Reviewed by Dimitri Glazkov.
2108
2109         [DRT/Chromium] Add support for resources on Mac
2110         https://bugs.webkit.org/show_bug.cgi?id=38637
2111
2112         * DEPS: Check out tools/data_pack.
2113
2114 2010-05-06  Pavel Feldman  <pfeldman@chromium.org>
2115
2116         Reviewed by Timothy Hatcher.
2117
2118         Chromium Dev Tools: Large toolbar icons flash when dev
2119         tools is opened in docked mode.
2120
2121         https://bugs.webkit.org/show_bug.cgi?id=38631
2122
2123         * src/js/DevTools.js:
2124         (devtools.domContentLoaded):
2125
2126 2010-05-06  Adam Barth  <abarth@webkit.org>
2127
2128         Reviewed by Eric Seidel.
2129
2130         drop support for sessionStorage in sandbox iframes
2131         https://bugs.webkit.org/show_bug.cgi?id=38151
2132
2133         Update client of sessionStorage to handle exceptions.
2134
2135         * src/StorageAreaProxy.cpp:
2136         (WebCore::StorageAreaProxy::storageEvent):
2137
2138 2010-05-05  Darin Fisher  <darin@chromium.org>
2139
2140         Reviewed by Dimitri Glazkov.
2141
2142         [chromium] clear out deprecated methods that are no longer used
2143         https://bugs.webkit.org/show_bug.cgi?id=38610
2144
2145         * public/WebFormElement.h:
2146         * public/WebInputElement.h:
2147         * public/WebKitClient.h:
2148         * public/WebView.h:
2149         * public/WebViewClient.h:
2150         (WebKit::WebViewClient::createPopupMenu):
2151         * src/ChromeClientImpl.cpp:
2152         (WebKit::ChromeClientImpl::popupOpened):
2153         * src/WebFormElement.cpp:
2154         * src/WebInputElement.cpp:
2155         (WebKit::WebInputElement::setSelectionRange):
2156         * src/WebViewImpl.cpp:
2157         (WebKit::WebViewImpl::hideSuggestionsPopup):
2158         * src/WebViewImpl.h:
2159
2160 2010-05-05  Hans Wennborg  <hans@chromium.org>
2161
2162         Reviewed by Jeremy Orlow.
2163
2164         [chromium] Add quota parameter to  WebStorageNamespace::createSessionStorageNamespace
2165         https://bugs.webkit.org/show_bug.cgi?id=38589
2166
2167         * public/WebStorageNamespace.h:
2168         (WebKit::WebStorageNamespace::createSessionStorageNamespace):
2169         * src/WebStorageNamespaceImpl.cpp:
2170         (WebKit::WebStorageNamespace::createSessionStorageNamespace):
2171
2172 2010-05-05  Stuart Morgan  <stuartmorgan@chromium.org>
2173
2174         Reviewed by Darin Fisher.
2175
2176         Update the plugin container's setFocus implementation to pass the new
2177         boolean argument to the next layer.
2178
2179         https://bugs.webkit.org/show_bug.cgi?id=37961
2180
2181         * src/WebPluginContainerImpl.cpp:
2182         (WebKit::WebPluginContainerImpl::setFocus):
2183         * src/WebPluginContainerImpl.h:
2184
2185 2010-05-04  Vangelis Kokkevis  <vangelis@chromium.org>
2186
2187         Reviewed by Darin Fisher.
2188
2189         Provide an API for querying whether a WebWidget is using gpu accelerated compositing.
2190         Also changed: isAcceleratedCompositing to: isAcceleratedCompositingActive.
2191         https://bugs.webkit.org/show_bug.cgi?id=38220
2192
2193         * public/WebWidget.h:
2194         * src/WebPopupMenuImpl.h:
2195         (WebKit::WebPopupMenuImpl::isAcceleratedCompositingActive):
2196         * src/WebViewImpl.cpp:
2197         (WebKit::WebViewImpl::WebViewImpl):
2198         (WebKit::WebViewImpl::paint):
2199         (WebKit::WebViewImpl::isAcceleratedCompositingActive):
2200         (WebKit::WebViewImpl::setRootGraphicsLayer):
2201         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
2202         (WebKit::WebViewImpl::updateRootLayerContents):
2203         * src/WebViewImpl.h:
2204
2205 2010-04-29  John Gregg  <johnnyg@google.com>
2206
2207         Reviewed by Dmitry Titov.
2208
2209         notifications should have dir and replaceId attributes
2210         https://bugs.webkit.org/show_bug.cgi?id=38336
2211
2212         * public/WebNotification.h:
2213         * src/WebNotification.cpp:
2214         (WebKit::WebNotification::dir):
2215         (WebKit::WebNotification::replaceId):
2216
2217 2010-05-04  Jay Civelli  <jcivelli@chromium.org>
2218
2219         Reviewed by David Levin.
2220
2221         [chromium] Make the select popup not close on right/middle clicks.
2222         https://bugs.webkit.org/show_bug.cgi?id=38473
2223
2224         * src/WebViewImpl.cpp:
2225         (WebKit::WebViewImpl::mouseDown):
2226
2227 2010-05-03  Abhishek Arya  <inferno@chromium.org>
2228
2229         Reviewed by Adam Barth.
2230
2231         Add support for controlling clipboard access from javascript.
2232         Clipboard access from javascript is disabled by default.
2233         https://bugs.webkit.org/show_bug.cgi?id=27751
2234
2235         * public/WebSettings.h:
2236         * src/WebSettingsImpl.cpp:
2237         (WebKit::WebSettingsImpl::setJavaScriptCanAccessClipboard):
2238         * src/WebSettingsImpl.h:
2239
2240 2010-05-03  Jens Alfke  <snej@chromium.org>
2241
2242         Reviewed by Darin Fisher.
2243
2244         [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
2245         https://bugs.webkit.org/show_bug.cgi?id=38397
2246
2247         No tests (functionality is exposed only through native WebKit API.)
2248
2249         * public/WebFrameClient.h:
2250         (WebKit::WebFrameClient::willSendSubmitEvent): New empty method
2251         * src/FrameLoaderClientImpl.cpp:
2252         (WebKit::FrameLoaderClientImpl::dispatchWillSendSubmitEvent): Delegate to client
2253         * src/FrameLoaderClientImpl.h:
2254
2255 2010-05-02  Michael Nordman  <michaeln@google.com>
2256
2257         Reviewed by Dmitry Titov.
2258
2259         Define two new ResourceRequestBase TargetTypes for worker and shared worker
2260         main resources. Use the new target types where appropiate. Add logic to marshal
2261         the target type specified by requests initiated on a background worker thread.
2262
2263         https://bugs.webkit.org/show_bug.cgi?id=38295
2264
2265         * src/SharedWorkerRepository.cpp:  use TargetIsSharedWorker
2266         (WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader):
2267
2268 2010-05-02  Rafael Weinstein  <rafaelw@chromium.org>
2269
2270         Reviewed by Darin Fisher.
2271
2272         Include WebWindowFeatures in call to WebViewClient::createView.
2273         https://bugs.webkit.org/show_bug.cgi?id=38301
2274
2275         * public/WebViewClient.h:
2276         (WebKit::WebViewClient::createView):
2277         * public/WebWindowFeatures.h:
2278         * src/ChromeClientImpl.cpp:
2279         (WebKit::ChromeClientImpl::createWindow):
2280
2281 2010-05-01  Evan Stade  <estade@chromium.org>
2282
2283         Reviewed by David Levin
2284
2285         [chromium] Skia needs to fade DragImages
2286         https://bugs.webkit.org/show_bug.cgi?id=38008
2287
2288         * tests/DragImageTest.cpp:
2289         (DragImageTest.CreateDragImage): test that the drag image is a deep copy
2290
2291 2010-04-30  Jian Li  <jianli@chromium.org>
2292
2293         Reviewed by Darin Fisher.
2294
2295         [chromium] Add WebFileSystem interface and hook up with all FileSystem methods.
2296         https://bugs.webkit.org/show_bug.cgi?id=38228
2297
2298         * WebKit.gyp:
2299         * public/WebFileSystem.h: Added.
2300         * public/WebKitClient.h:
2301         (WebKit::WebKitClient::fileSystem):
2302         * src/ChromiumBridge.cpp:
2303         (WebCore::ChromiumBridge::fileExists):
2304         (WebCore::ChromiumBridge::deleteFile):
2305         (WebCore::ChromiumBridge::deleteEmptyDirectory):
2306         (WebCore::ChromiumBridge::getFileSize):
2307         (WebCore::ChromiumBridge::getFileModificationTime):
2308         (WebCore::ChromiumBridge::directoryName):
2309         (WebCore::ChromiumBridge::pathByAppendingComponent):
2310         (WebCore::ChromiumBridge::makeAllDirectories):
2311         (WebCore::ChromiumBridge::getAbsolutePath):
2312         (WebCore::ChromiumBridge::isDirectory):
2313         (WebCore::ChromiumBridge::filePathToURL):
2314         (WebCore::ChromiumBridge::openFile):
2315         (WebCore::ChromiumBridge::closeFile):
2316         (WebCore::ChromiumBridge::seekFile):
2317         (WebCore::ChromiumBridge::truncateFile):
2318         (WebCore::ChromiumBridge::readFromFile):
2319         (WebCore::ChromiumBridge::writeToFile):
2320
2321 2010-04-29  Jeremy Orlow  <jorlow@chromium.org>
2322
2323         Reviewed by Darin Fisher.
2324
2325         Change StorageEvent.uri to StorageEvent.url to match the spec
2326         https://bugs.webkit.org/show_bug.cgi?id=38331
2327
2328         Get rid of a stale FIXME and combine 2 lines that needn't be split.
2329
2330         * src/StorageEventDispatcherImpl.cpp:
2331         (WebCore::StorageEventDispatcherImpl::dispatchStorageEvent):
2332
2333 2010-04-29  Anton Muhin  <antonm@chromium.org>
2334
2335         Reviewed by Darin Fisher.
2336
2337         [Chromium] Consider implementing addOriginAccessWhitelistEntry method
2338         http://trac.webkit.org/changeset/57537 introduced a new method
2339         to manage whitelisting of origins.
2340         Expose this method in Chromium's bridge.
2341         https://bugs.webkit.org/show_bug.cgi?id=37578
2342
2343         * public/WebSecurityPolicy.h: Start renaming (keep old function names) and add new removeOriginAccessWhitelistEntry method
2344         * src/WebSecurityPolicy.cpp: Start renaming (keep old function names) and add new removeOriginAccessWhitelistEntry method
2345
2346 2010-04-29  Sheriff Bot  <webkit.review.bot@gmail.com>
2347
2348         Unreviewed, rolling out r58498.
2349         http://trac.webkit.org/changeset/58498
2350         https://bugs.webkit.org/show_bug.cgi?id=38332
2351
2352         "Broke a bunch of tests on Chromium canaries" (Requested by
2353         dglazkov on #webkit).
2354
2355         * public/WebViewClient.h:
2356         (WebKit::WebViewClient::createView):
2357         * public/WebWindowFeatures.h:
2358         * src/ChromeClientImpl.cpp:
2359         (WebKit::ChromeClientImpl::createWindow):
2360
2361 2010-04-29  Adam Langley  <agl@chromium.org>
2362
2363         Unreviewed, DEPS roll.
2364
2365         WebKit's r58517 needs OTS's r30 which was rolled into Chromium in
2366         r45932.
2367
2368         * DEPS:
2369           Use Chromium r45932.
2370
2371 2010-04-29  Rafael Weinstein  <rafaelw@chromium.org>
2372
2373         Reviewed by Darin Fisher.
2374
2375         Include WindowFeatures in call to WebViewClient::createView.
2376
2377         https://bugs.webkit.org/show_bug.cgi?id=38301
2378
2379         * public/WebViewClient.h:
2380         (WebKit::WebViewClient::createView):
2381         * public/WebWindowFeatures.h:
2382         * src/ChromeClientImpl.cpp:
2383         (WebKit::ChromeClientImpl::createWindow):
2384
2385 2010-04-29  Garret Kelly  <gdk@chromium.org>
2386
2387         Reviewed by Darin Fisher.
2388
2389         Expose the RuntimeFeature for touch events through the
2390         WebRuntimeFeatures mechanism.
2391         https://bugs.webkit.org/show_bug.cgi?id=37486
2392
2393         * public/WebRuntimeFeatures.h:
2394         * src/WebRuntimeFeatures.cpp:
2395         (WebKit::WebRuntimeFeatures::enableTouch):
2396         (WebKit::WebRuntimeFeatures::isTouchEnabled):
2397
2398 2010-04-29  Zhenyao Mo  <zmo@google.com>
2399
2400         Reviewed by Dimitri Glazkov.
2401
2402         Remove the unnecessary texImage2D function with Image as input in GraphicsContext3D
2403         https://bugs.webkit.org/show_bug.cgi?id=38235
2404
2405         * src/GraphicsContext3D.cpp: Remove tex*image implementation with Image input.
2406
2407 2010-04-28  Pavel Feldman  <pfeldman@chromium.org>
2408
2409         Reviewed by Yury Semikhatsky.
2410
2411         Web Inspector: Allow editing script resources when resource tracking is enabled.
2412
2413         http://bugs.webkit.org/show_bug.cgi?id=38269
2414  
2415         * src/js/DebuggerAgent.js:
2416         * src/js/InspectorControllerImpl.js:
2417         (.devtools.InspectorBackendImpl.prototype.setBreakpoint):
2418         (.devtools.InspectorBackendImpl.prototype.editScriptSource):
2419
2420 2010-04-28  Darin Fisher  <darin@chromium.org>
2421
2422         Reviewed by David Levin.
2423
2424         [Chromium] callOnMainThread should equate to MessageLoop::PostTask
2425         https://bugs.webkit.org/show_bug.cgi?id=38276
2426
2427         * public/WebKitClient.h:
2428         (WebKit::WebKitClient::callOnMainThread):
2429         * src/ChromiumThreading.cpp:
2430         (WTF::ChromiumThreading::callOnMainThread):
2431
2432 2010-04-27  John Abd-El-Malek  <jam@chromium.org>
2433
2434         Reviewed by Darin Fisher.
2435
2436         Make WebThemeEngine::paint take a const ref of ExtraParams
2437         https://bugs.webkit.org/show_bug.cgi?id=38242
2438
2439         * public/WebThemeEngine.h:
2440         (WebKit::WebThemeEngine::paint):
2441
2442 2010-04-28  Andrey Kosyakov  <caseq@chromium.org>
2443
2444         Reviewed by Pavel Feldman.
2445
2446         Fixed passing breakpoints to V8. 
2447         https://bugs.webkit.org/show_bug.cgi?id=38266
2448
2449         * src/js/InspectorControllerImpl.js:
2450         (.devtools.InspectorBackendImpl.prototype.setBreakpoint):
2451
2452 2010-04-28  Yury Semikhatsky  <yurys@chromium.org>
2453
2454         Reviewed by Pavel Feldman.
2455
2456         Support pause on exceptions in v8 implementation of ScriptDebugServer.
2457
2458         https://bugs.webkit.org/show_bug.cgi?id=38205        
2459
2460         * src/js/DebuggerScript.js:
2461         (debuggerScriptConstructor.DebuggerScript.getScripts):
2462         (debuggerScriptConstructor.DebuggerScript.pauseOnExceptionsState):
2463         (debuggerScriptConstructor.DebuggerScript.setPauseOnExceptionsState):
2464         (debuggerScriptConstructor.DebuggerScript._v8ToWebkitLineNumber):
2465         (debuggerScriptConstructor):
2466
2467 2010-04-27  Jens Alfke  <snej@chromium.org>
2468
2469         Reviewed by Eric Seidel.
2470
2471         [chromium] Fix bug that prevents autosave of forms without action attribute
2472         https://bugs.webkit.org/show_bug.cgi?id=38014
2473         Change is in the Chromium WebKit API so it can't be tested with a JS-based layout test.
2474         It needs a native unit test, which would go in the Chromium repo, not WebKit.
2475
2476         * src/WebPasswordFormData.cpp:
2477         (WebKit::WebPasswordFormData::WebPasswordFormData): Set correct URL if action is NULL
2478
2479 2010-04-27  Michael Nordman  <michaeln@google.com>
2480
2481         Reviewed by Dmitry Titov.
2482
2483         [Chromium] Add two things to the webkit API to support appcaches in workers.
2484         1) WebURLRequest TargetTypes for worker and shared worker main resources.
2485         2) Factory method on class WebCommonWorkerClient to
2486            createApplicationCacheHost() for the associated worker.
2487
2488         https://bugs.webkit.org/show_bug.cgi?id=38147
2489
2490         * public/WebCommonWorkerClient.h: add the factory method
2491         * public/WebURLRequest.h: add the TargetTypes
2492         * src/WebWorkerBase.cpp: call the embedder's factory when needed
2493         (WebKit::WebWorkerBase::didCreateDataSource)
2494         (WebKit::WebWorkerBase::createApplicationCacheHost)
2495         * src/WebWorkerBase.h: ditto
2496         * src/WebWorkerClientImpl.h: add a stub impl of the factory method 
2497         (WebKit::WebWorkerClientImpl::createApplicationCacheHost):
2498
2499 2010-04-27  Kent Tamura  <tkent@chromium.org>
2500
2501         Reviewed by Shinichiro Hamaji.
2502
2503         [DRT/Chromium] Enable Windows project generation
2504         https://bugs.webkit.org/show_bug.cgi?id=38103
2505
2506         - Avoid platform.system(), which causes a crash with python.exe in
2507           depot_tools. Use sys.platform instead.
2508         - Process DumpRenderTree.gyp on all platforms.
2509
2510         * gyp_webkit:
2511
2512 2010-04-27  Jay Civelli  <jcivelli@chromium.org>
2513
2514         Reviewed by Darin Fisher.
2515
2516         Makes clicking a select element close its associated popup if
2517         it is open.
2518         https://bugs.webkit.org/show_bug.cgi?id=38105
2519
2520         * src/WebViewImpl.cpp:
2521         (WebKit::WebViewImpl::mouseDown):
2522
2523 2010-04-27  Jay Civelli  <jcivelli@chromium.org>
2524
2525         Reviewed by Darin Fisher.
2526
2527         [chromium] Merged the WebView public method to close suggestion popups
2528         into a single method to close all popups (select and suggestions).
2529         That ensures select popups are closed when the browser window is moved
2530         or resized.
2531         https://bugs.webkit.org/show_bug.cgi?id=37837
2532
2533         * public/WebView.h:
2534         * src/WebViewImpl.cpp:
2535         (WebKit::WebViewImpl::hidePopups):
2536         (WebKit::WebViewImpl::hideSuggestionsPopup):
2537         * src/WebViewImpl.h:
2538
2539 2010-04-27  John Abd-El-Malek  <jam@chromium.org>
2540
2541         Reviewed by Darin Adler.
2542
2543         Remove unnecessary header now that Chrome is updated
2544         https://bugs.webkit.org/show_bug.cgi?id=38211
2545
2546         * public/win/WebThemeEngine.h: Removed.
2547
2548 2010-04-27  Jens Alfke  <snej@chromium.org>
2549
2550         Reviewed by Darin Fisher.
2551
2552         [Chromium] Add some notifications and an accessor to WebKit API
2553         https://bugs.webkit.org/show_bug.cgi?id=37625
2554
2555         * public/WebFrameClient.h:
2556         (WebKit::WebFrameClient::didFirstLayout):
2557         (WebKit::WebFrameClient::didFirstVisuallyNonEmptyLayout):
2558         * public/WebNode.h:
2559         * src/FrameLoaderClientImpl.cpp:
2560         (WebKit::FrameLoaderClientImpl::dispatchDidFirstLayout):
2561         (WebKit::FrameLoaderClientImpl::dispatchDidFirstVisuallyNonEmptyLayout):
2562         * src/WebElement.cpp:
2563         * src/WebNode.cpp:
2564         (WebKit::WebNode::hasNonEmptyBoundingBox):
2565
2566 2010-04-27  Darin Fisher  <darin@chromium.org>
2567
2568         Reviewed by Dimitri Glazkov.
2569
2570         [Chromium] Remove deprecated form of didChangeLocationWithinPage
2571         https://bugs.webkit.org/show_bug.cgi?id=38178
2572
2573         * public/WebFrameClient.h:
2574         * src/FrameLoaderClientImpl.cpp:
2575         (WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):
2576
2577 2010-04-27  Evan Martin  <evan@chromium.org>
2578
2579         Reviewed by David Levin.
2580
2581         [chromium] bold bengali text not rendered properly on Linux
2582         Roll forward Chrome DEPS so we get new Skia API.
2583
2584         * DEPS: update Chrome to r45696.
2585
2586 2010-04-27  Andrey Kosyakov  <caseq@chromium.org>
2587
2588         Reviewed by Pavel Feldman.
2589
2590         Restore breakpoints associated with script's URL once
2591         script is parsed.
2592         https://bugs.webkit.org/show_bug.cgi?id=38132
2593
2594         * src/js/DebuggerAgent.js:
2595         (devtools.DebuggerAgent.prototype.initUI):
2596         (devtools.DebuggerAgent.prototype.addBreakpoint):
2597         (devtools.DebuggerAgent.prototype.addScriptInfo_):
2598         (devtools.DebuggerAgent.prototype.restoreBreakpoints_):
2599         (devtools.BreakpointInfo):
2600         (devtools.BreakpointInfo.prototype.enabled):
2601         (devtools.BreakpointInfo.prototype.condition):
2602
2603 2010-04-27  Pavel Feldman  <pfeldman@chromium.org>
2604
2605         Reviewed by Yury Semikhatsky.
2606
2607         Chrome Dev Tools: Further beautify themes.
2608
2609         https://bugs.webkit.org/show_bug.cgi?id=38187
2610
2611         * src/js/DevTools.js:
2612         (WebInspector.setToolbarColors):
2613         * src/js/devTools.css:
2614         (body.platform-windows #toolbar, body.platform-windows.inactive #toolbar):
2615
2616 2010-04-26  John Abd-El-Malek  <jam@chromium.org>
2617
2618         Reviewed by Darin Fisher.
2619
2620         [chromium] Prepare to making WebThemeEngine cross-platform
2621         https://bugs.webkit.org/show_bug.cgi?id=38077
2622
2623         * WebKit.gyp:
2624         * public/WebThemeEngine.h: Added.
2625         * public/win/WebThemeEngine.h:
2626
2627 2010-04-26  Darin Fisher  <darin@chromium.org>
2628
2629         Reviewed by Adam Barth.
2630
2631         [Chromium] Crash after calling window.print() on a window object that has been closed.
2632         https://bugs.webkit.org/show_bug.cgi?id=38148
2633
2634         It is unfortunately not possible to write a layout test for this as the
2635         crash occurs in an API that is only called by Chrome while showing a
2636         print dialog.
2637
2638         * src/WebViewImpl.cpp:
2639         (WebKit::WebView::willEnterModalLoop):
2640         (WebKit::WebView::didExitModalLoop):
2641
2642 2010-04-25  Sam Weinig  <sam@webkit.org>
2643
2644         Reviewed by Maciej Stachowiak.
2645
2646         Fix for https://bugs.webkit.org/show_bug.cgi?id=38097
2647         Disentangle initializing the main thread from initializing threading
2648
2649         * src/WebKit.cpp:
2650         (WebKit::initialize): Add call to initializeMainThread.
2651         * src/WebViewImpl.cpp:
2652         (WebKit::WebViewImpl::WebViewImpl): Ditto.
2653
2654 2010-04-26  Roman Gershman  <romange@google.com>
2655
2656         Reviewed by Adam Barth.
2657
2658         [Chromium] Font size in suggestions popup menu should be correlated with the font size of its text field.
2659
2660         https://bugs.webkit.org/show_bug.cgi?id=37977
2661
2662         * src/SuggestionsPopupMenuClient.cpp:
2663         (WebKit::SuggestionsPopupMenuClient::initialize):
2664
2665 2010-04-26  Pavel Feldman  <pfeldman@chromium.org>
2666
2667         Reviewed by Yury Semikhatsky.
2668
2669         Chromium Dev Tools: brush up images.
2670
2671         https://bugs.webkit.org/show_bug.cgi?id=38124
2672
2673         * WebKit.gypi:
2674         * src/js/DevTools.js:
2675         (WebInspector.setToolbarColors):
2676         * src/js/Images/segmentChromium.png:
2677         * src/js/Images/segmentChromium2.png: Removed.
2678         * src/js/Images/segmentHoverChromium2.png: Removed.
2679         * src/js/Images/segmentSelectedChromium2.png: Removed.
2680         * src/js/Images/statusbarBackgroundChromium.png:
2681         * src/js/Images/statusbarBackgroundChromium2.png: Removed.
2682         * src/js/Images/statusbarBottomBackgroundChromium.png:
2683         * src/js/Images/statusbarButtonsChromium.png:
2684         * src/js/Images/statusbarMenuButtonChromium.png:
2685         * src/js/Images/statusbarMenuButtonChromium2.png: Removed.
2686         * src/js/devTools.css:
2687         (.section > .header):
2688         (.console-group-messages .section > .header):
2689         (#resources-filter):
2690         (.crumbs .crumb):
2691         (.crumbs .crumb.end):
2692         (.crumbs .crumb.selected):
2693         (.crumbs .crumb.selected:hover):
2694         (.crumbs .crumb.selected.end, .crumbs .crumb.selected.end:hover):
2695         (.crumbs .crumb:hover):
2696         (.crumbs .crumb.dimmed:hover):
2697         (.crumbs .crumb.end:hover):
2698         (body.drawer-visible #main-status-bar):
2699         (.status-bar):
2700         (button.status-bar-item):
2701         (select.status-bar-item:active):
2702         (#drawer):
2703         (select.status-bar-item):
2704
2705 2010-04-23  Zhenyao Mo  <zmo@google.com>
2706
2707         Reviewed by Darin Fisher.
2708
2709         Add isGLES2Compliant to GraphicsContext3D: make the method const.
2710         https://bugs.webkit.org/show_bug.cgi?id=37872
2711
2712         * src/GraphicsContext3D.cpp: Make isGLES2Compliant() const.
2713         (WebCore::GraphicsContext3DInternal::isGLES2Compliant):
2714         (WebCore::GraphicsContext3D::isGLES2Compliant):
2715
2716 2010-04-23  Rafael Weinstein  <rafaelw@grafaelw.sfo.corp.google.com>
2717
2718         Reviewed by Darin Fisher.
2719
2720         This patch adds a WebWindowFeatures binding struct for the
2721         chromium client in anticipation of a follow-on patch which will
2722         pass it to WebViewClient::createWindow.
2723
2724         https://bugs.webkit.org/show_bug.cgi?id=38013
2725
2726         * public/WebViewClient.h:
2727         (WebKit::WebViewClient::createView):
2728         * public/WebWindowFeatures.h: Added.
2729         (WebKit::WebWindowFeatures::WebWindowFeatures):
2730         * src/ChromeClientImpl.cpp:
2731         (WebKit::ChromeClientImpl::createWindow):
2732
2733 2010-04-22  Zhenyao Mo  <zmo@google.com>
2734
2735         Reviewed by Darin Fisher.
2736
2737         Add isGLES2Compliant to GraphicsContext3D
2738         https://bugs.webkit.org/show_bug.cgi?id=37872
2739
2740         * public/WebGraphicsContext3D.h: Add isGLES2Compliant().
2741         * src/GraphicsContext3D.cpp: Ditto.
2742         * src/WebGraphicsContext3DDefaultImpl.cpp: Ditto.
2743         (WebKit::WebGraphicsContext3DDefaultImpl::isGLES2Compliant):
2744         * src/WebGraphicsContext3DDefaultImpl.h: Ditto.
2745
2746 2010-04-22  Dave Moore  <davemoore@chromium.org>
2747
2748         Reviewed by Dimitri Glazkov.
2749
2750         Added notification when the favicons for a page are changed
2751         from a script.
2752         The Document object will notify the frame loader, which will
2753         notify the client. Implementations of FrameLoaderClient will
2754         have to add one method; dispatchDidChangeIcons().
2755
2756         https://bugs.webkit.org/show_bug.cgi?id=33812
2757
2758         * public/WebFrameClient.h:
2759         (WebKit::WebFrameClient::didChangeIcons):
2760         * src/FrameLoaderClientImpl.cpp:
2761         (WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
2762         * src/FrameLoaderClientImpl.h:
2763
2764 2010-04-22  Zhenyao Mo  <zmo@google.com>
2765
2766         Reviewed by Dimitri Glazkov.
2767
2768         Emulate GL_IMPLEMENTATION_COLOR_READ_FORMAT/TYPE for glGet
2769         https://bugs.webkit.org/show_bug.cgi?id=37281
2770
2771         * src/WebGraphicsContext3DDefaultImpl.cpp:
2772         (WebKit::WebGraphicsContext3DDefaultImpl::getIntegerv): Emulate two  enums.
2773
2774 2010-04-22  Adam Barth  <abarth@webkit.org>
2775
2776         Unreviewed, rolling out r58069.
2777         http://trac.webkit.org/changeset/58069
2778         https://bugs.webkit.org/show_bug.cgi?id=27751
2779
2780         Broke compile on Windows.
2781
2782         * public/WebSettings.h:
2783         * src/WebSettingsImpl.cpp:
2784         * src/WebSettingsImpl.h:
2785
2786 2010-04-22  Tony Chang  <tony@chromium.org>
2787
2788         Reviewed by Shinichiro Hamaji.
2789
2790         [chromium] roll chromium deps to pick up some windows build fixes
2791         https://bugs.webkit.org/show_bug.cgi?id=37972
2792
2793         * DEPS:
2794
2795 2010-04-22  Abhishek Arya  <inferno@chromium.org>
2796
2797         Reviewed by Adam Barth.
2798
2799         Add support for controlling clipboard access from javascript.
2800         Clipboard access from javascript is disabled by default.
2801         https://bugs.webkit.org/show_bug.cgi?id=27751
2802
2803         * public/WebSettings.h:
2804         * src/WebSettingsImpl.cpp:
2805         (WebKit::WebSettingsImpl::setJavaScriptCanAccessClipboard):
2806         * src/WebSettingsImpl.h:
2807
2808 2010-04-21  Tony Chang  <tony@chromium.org>
2809
2810         Reviewed by Shinichiro Hamaji.
2811
2812         [chromium] gyp_webkit should be executable
2813         https://bugs.webkit.org/show_bug.cgi?id=37971
2814
2815         * gyp_webkit: Added property svn:executable.
2816
2817 2010-04-21  Jay Civelli  <jcivelli@chromium.org>
2818
2819         Reviewed by Darin Fisher.
2820
2821         [Chromium] Don't notify the WebView that a popup was
2822         opened when the popup is handled externally, as the popup
2823         is in that case transparent to the WebView.
2824         The notification was causing an ASSERT on Mac (where
2825         the popup is handled externally) as there would be no
2826         notification that the popup was closed.
2827         https://bugs.webkit.org/show_bug.cgi?id=37825
2828
2829         * src/ChromeClientImpl.cpp:
2830         (WebKit::ChromeClientImpl::popupOpened):
2831
2832 2010-04-21  Sheriff Bot  <webkit.review.bot@gmail.com>
2833
2834         Unreviewed, rolling out r58028.
2835         http://trac.webkit.org/changeset/58028
2836         https://bugs.webkit.org/show_bug.cgi?id=37962
2837
2838         broke the chromium build (Requested by tony^work on #webkit).
2839
2840         * DEPS:
2841
2842 2010-04-21  Evan Martin  <evan@chromium.org>
2843
2844         Unreviewed, just a dependency change.
2845
2846         [chromium] roll skia forward to r538
2847         https://bugs.webkit.org/show_bug.cgi?id=37960
2848
2849         This will cause a bunch of pixel tests to fail due to bulleted
2850         lists rendering slightly differently.  I will grab new baselines
2851         from the bots and check them in in a followup.
2852
2853         * DEPS:
2854
2855 2010-04-21  Evan Stade  <estade@chromium.org>
2856
2857         Reviewed by Darin Fisher.
2858
2859         [chromium] Web page serializer saves tag names in upper case
2860         https://bugs.webkit.org/show_bug.cgi?id=37940
2861
2862         Simply convert all tags to lower case.
2863
2864         This is tested by chrome tests:
2865          - save page browser tests
2866          - encoding ui tests
2867          - web page serializer test shell tests
2868
2869         * src/WebPageSerializer.cpp:
2870         (WebKit::WebPageSerializer::generateMetaCharsetDeclaration):
2871         (WebKit::WebPageSerializer::generateBaseTagDeclaration):
2872         * src/WebPageSerializerImpl.cpp:
2873         (WebKit::WebPageSerializerImpl::openTagToString):
2874         (WebKit::WebPageSerializerImpl::endTagToString):
2875
2876 2010-04-20  Adam Barth  <abarth@webkit.org>
2877
2878         Reviewed by Eric Seidel.
2879
2880         Factor DocumentWriter out of FrameLoader
2881         https://bugs.webkit.org/show_bug.cgi?id=37175
2882
2883         Update these callsites because the method moved to DocumentWriter.
2884
2885         * src/ContextMenuClientImpl.cpp:
2886         (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
2887         * src/FrameLoaderClientImpl.cpp:
2888         (WebKit::FrameLoaderClientImpl::finishedLoading):
2889         * src/WebFrameImpl.cpp:
2890         (WebKit::WebFrameImpl::encoding):
2891         (WebKit::WebFrameImpl::commitDocumentData):
2892         * src/WebPageSerializerImpl.cpp:
2893         (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag):
2894         (WebKit::WebPageSerializerImpl::serialize):
2895         * src/WebSearchableFormData.cpp:
2896         (WebCore::GetFormEncoding):
2897         * src/WebViewImpl.cpp:
2898         (WebKit::WebViewImpl::pageEncoding):
2899
2900 2010-04-20  Pavel Feldman  <pfeldman@chromium.org>
2901
2902         Reviewed by Timothy Hatcher.
2903
2904         Web Inspector: add basic script editing capabilities to the front-end.
2905
2906         https://bugs.webkit.org/show_bug.cgi?id=37875
2907
2908         * src/js/DebuggerAgent.js:
2909         (devtools.DebuggerAgent.prototype.resolveScriptSource.this.requestSeqToCallback_.cmd.getSequenceNumber):
2910         (devtools.DebuggerAgent.prototype.resolveScriptSource):
2911         (devtools.DebuggerAgent.prototype.editScriptLine.this.requestSeqToCallback_.cmd.getSequenceNumber):
2912         (devtools.DebuggerAgent.prototype.editScriptLine):
2913         (devtools.DebuggerAgent.prototype.handleDebuggerOutput_):
2914         * src/js/DevTools.js:
2915         * src/js/InspectorControllerImpl.js:
2916         (.devtools.InspectorBackendImpl.prototype.editScriptLine):
2917
2918 2010-04-20  Kent Tamura  <tkent@chromium.org>
2919
2920         Reviewed by Darin Adler.
2921
2922         Change a parameter type of chooseIconForFiles()
2923         https://bugs.webkit.org/show_bug.cgi?id=37504
2924
2925         * src/ChromeClientImpl.cpp:
2926         (WebKit::ChromeClientImpl::chooseIconForFiles):
2927         * src/ChromeClientImpl.h:
2928
2929 2010-04-20  Jay Civelli  <jcivelli@chromium.org>
2930
2931         Reviewed by Dimitri Glazkov.
2932
2933         [chromium] Tests that pressing tab now closes the select popup.
2934         https://bugs.webkit.org/show_bug.cgi?id=37721
2935
2936         * tests/PopupMenuTest.cpp:
2937         (WebKit::TEST_F):
2938
2939 2010-04-20  Evan Stade  <estade@chromium.org>
2940
2941         Reviewed by David Levin.
2942
2943         [chromium] crash when dragging images
2944         https://bugs.webkit.org/show_bug.cgi?id=37715
2945
2946         Added unit tests for DragImageChromiumSkia.
2947
2948         * WebKit.gyp:
2949         * tests/DragImageTest.cpp: Added.
2950         (WebCore::TestImage::TestImage):
2951         (WebCore::TestImage::~TestImage):
2952         (WebCore::TestImage::size):
2953         (WebCore::TestImage::nativeImageForCurrentFrame):
2954         (WebCore::TestImage::destroyDecodedData):
2955         (WebCore::TestImage::decodedSize):
2956         (WebCore::TestImage::draw):
2957         (WebCore::TEST):
2958
2959 2010-04-20  Stuart Morgan  <stuartmorgan@chromium.org>
2960
2961         Reviewed by David Levin.
2962
2963         Remove a workaround in plugin cursor setting that was obsoleted by
2964         the change in https://bugs.webkit.org/show_bug.cgi?id=35132
2965         https://bugs.webkit.org/show_bug.cgi?id=37811
2966
2967         * src/ChromeClientImpl.cpp:
2968         (WebKit::ChromeClientImpl::ChromeClientImpl):
2969         (WebKit::ChromeClientImpl::setCursor):
2970         (WebKit::ChromeClientImpl::setCursorForPlugin):
2971         * src/ChromeClientImpl.h:
2972
2973 2010-04-19  Ada Chan  <adachan@apple.com>
2974
2975         Reviewed by Jeremy Orlow.
2976
2977         https://bugs.webkit.org/show_bug.cgi?id=37717
2978         Changes needed now that StorageNamespaceImpl::sessionStorageNamespace() and
2979         StorageNamespace::sessionStorageNamespace() take in a quota parameter.
2980
2981         * src/StorageNamespaceProxy.cpp:
2982         (WebCore::StorageNamespace::sessionStorageNamespace):
2983         * src/WebStorageNamespaceImpl.cpp:
2984         (WebKit::WebStorageNamespace::createSessionStorageNamespace):
2985
2986 2010-04-17  Vangelis Kokkevis  <vangelis@chromium.org>
2987
2988         Reviewed by Dimitri Glazkov.
2989
2990         Adding the implementation of GLES2Context class which provides WebCore access to a GL ES context.
2991         https://bugs.webkit.org/show_bug.cgi?id=37541
2992
2993         * WebKit.gyp:
2994         * public/WebGLES2Context.h: Added.
2995         (WebKit::WebGLES2Context::~WebGLES2Context):
2996         * src/GLES2Context.cpp: Added.
2997         (WebCore::GLES2ContextInternal::GLES2ContextInternal):
2998         (WebCore::GLES2ContextInternal::~GLES2ContextInternal):
2999         (WebCore::GLES2ContextInternal::getWebGLES2Context):
3000         (WebCore::GLES2ContextInternal::initialize):
3001         (WebCore::GLES2Context::create):
3002         (WebCore::GLES2Context::~GLES2Context):
3003         (WebCore::GLES2Context::initialize):
3004         (WebCore::GLES2Context::makeCurrent):
3005         (WebCore::GLES2Context::destroy):
3006         (WebCore::GLES2Context::swapBuffers):
3007
3008 2010-04-16  Dumitru Daniliuc  <dumi@chromium.org>
3009
3010         Reviewed by Eric Seidel.
3011
3012         Get rid of the UNUSED_PARAM macro in GraphicsContext3D.cpp.
3013         https://bugs.webkit.org/show_bug.cgi?id=37733
3014
3015         * src/GraphicsContext3D.cpp:
3016         (WebCore::GraphicsContext3D::GraphicsContext3D):
3017
3018 2010-04-16  Dumitru Daniliuc  <dumi@chromium.org>
3019
3020         Reviewed by Jeremy Orlow.
3021
3022         Changing the return type of WebSecurityOrigin::createFromDatabaseIdentifier().
3023         https://bugs.webkit.org/show_bug.cgi?id=34466
3024
3025         Changing the return type of
3026         WebSecurityOrigin::createFromDatabaseIdentifier() from
3027         WebSecurityOrigin* to WebSecurityOrigin, to make it more
3028         consistent with the other WebSecurityOrigin methods.
3029
3030         * public/WebSecurityOrigin.h:
3031         * src/WebDatabase.cpp:
3032         (WebKit::WebDatabase::closeDatabaseImmediately):
3033         * src/WebSecurityOrigin.cpp:
3034         (WebKit::WebSecurityOrigin::createFromDatabaseIdentifier):
3035
3036 2010-04-16  Dmitry Titov  <dimich@chromium.org>
3037
3038         Reviewed by Yury Semikhatsky.
3039
3040         [v8] In Workers, script errors right after close() are not delivered to the Worker.onerror
3041         https://bugs.webkit.org/show_bug.cgi?id=37691
3042
3043         * src/WebWorkerClientImpl.cpp:
3044         (WebKit::WebWorkerClientImpl::createWorkerContextProxy): Don't need to pull V8 proxy to retrieve current WorkerContext.
3045
3046 2010-04-16  Albert J. Wong  <ajwong@chromium.org>
3047
3048         Not reviewed. Build fix.
3049
3050         [chromium] Compile fix. Missing include header, and missing type conversion.
3051
3052         * src/GraphicsContext3D.cpp:
3053         (WebCore::GraphicsContext3DInternal::beginPaint):
3054
3055 2010-04-16  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
3056  
3057         Reviewed by Simon Hausmann.
3058  
3059         [Qt] WebGL is not visible when QGLWidget viewport is used
3060         https://bugs.webkit.org/show_bug.cgi?id=37070
3061  
3062         Added HostWindow parameter to the constructor of GraphicsContext3D.
3063         Shared OpenGL context is initialized with parent QGLWidget.
3064  
3065         * src/GraphicsContext3D.cpp:
3066         (WebCore::GraphicsContext3D::GraphicsContext3D):
3067
3068 2010-04-16  Fumitoshi Ukai  <ukai@chromium.org>
3069
3070         Reviewed by Jian Li.
3071
3072         [chromium] WebKit::WebURLResponse::addHTTPHeaderField will crash if response is invalid UTF-8
3073         https://bugs.webkit.org/show_bug.cgi?id=37687
3074
3075         * src/WebURLResponse.cpp:
3076         (WebKit::WebURLResponse::addHTTPHeaderField): ignore if name or value is null string.
3077
3078 2010-04-16  Jay Civelli  <jcivelli@chromium.org>
3079
3080         Reviewed by Dimitri Glazkov.
3081
3082         [chromium] Select popups would assert when destroyed.
3083         Also adding unit-tests for the select popup code.
3084         https://bugs.webkit.org/show_bug.cgi?id=37436
3085
3086         * WebKit.gyp:
3087         * src/WebViewImpl.h:
3088         (WebKit::WebViewImpl::selectPopup):
3089         * tests/PopupMenuTest.cpp: Added.
3090
3091 2010-04-16  Tony Chang  <tony@chromium.org>
3092
3093         Reviewed by Dimitri Glazkov.
3094
3095         [chromium] build DRT on Linux
3096         https://bugs.webkit.org/show_bug.cgi?id=37690
3097
3098         * DEPS: Need to roll deps to remove a dependency on src/chrome
3099         * gyp_webkit: generate makefiles for DRT.gyp on Linux
3100
3101 2010-04-15  Tony Chang  <tony@chromium.org>
3102
3103         Reviewed by Dimitri Glazkov.
3104
3105         build DRT on chromium mac
3106         https://bugs.webkit.org/show_bug.cgi?id=37639
3107
3108         * gyp_webkit: generate build files for DRT on mac
3109
3110 2010-04-15  Yury Semikhatsky  <yurys@google.com>
3111
3112         Reviewed by Pavel Feldman.
3113
3114         Support basic debugging capabilities including step in/over/out in v8
3115         implementation of ScriptDebugServer.
3116
3117         https://bugs.webkit.org/show_bug.cgi?id=37604
3118
3119         * WebKit.gypi:
3120         * src/DebuggerAgent.h:
3121         * src/DebuggerAgentImpl.cpp:
3122         (WebKit::DebuggerAgentImpl::setDebuggerScriptSource):
3123         * src/DebuggerAgentImpl.h:
3124         * src/DebuggerAgentManager.cpp:
3125         (WebKit::DebuggerAgentManager::hostDispatchHandler):
3126         (WebKit::DebuggerAgentManager::debugAttach):
3127         (WebKit::DebuggerAgentManager::debugDetach):
3128         (WebKit::DebuggerAgentManager::setMessageLoopDispatchHandler):
3129         * src/DebuggerAgentManager.h:
3130         * src/InspectorFrontendClientImpl.cpp:
3131         (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
3132         * src/js/DebuggerScript.js: Added.
3133         (debuggerScriptConstructor.DebuggerScript.getAfterCompileScript):
3134         (debuggerScriptConstructor.DebuggerScript.getScripts):
3135         (debuggerScriptConstructor.DebuggerScript._formatScript):
3136         (debuggerScriptConstructor.DebuggerScript.setBreakpoint):
3137         (debuggerScriptConstructor.DebuggerScript.removeBreakpoint):
3138         (debuggerScriptConstructor.DebuggerScript.currentCallFrame):
3139         (debuggerScriptConstructor.DebuggerScript.stepIntoStatement):
3140         (debuggerScriptConstructor.DebuggerScript.stepOverStatement):
3141         (debuggerScriptConstructor.DebuggerScript.stepOutOfFunction):
3142         (debuggerScriptConstructor.DebuggerScript.clearBreakpoints):
3143         (debuggerScriptConstructor.DebuggerScript.setBreakpointsActivated):
3144         (debuggerScriptConstructor.DebuggerScript._frameMirrorToJSCallFrame):
3145         (debuggerScriptConstructor.DebuggerScript._webkitToV8LineNumber):
3146         (debuggerScriptConstructor.DebuggerScript._v8ToWwebkitLineNumber):
3147         (debuggerScriptConstructor):
3148         * src/js/DevTools.js:
3149         (WebInspector.loaded):
3150         (.):
3151         ():
3152         * src/js/DevToolsHostStub.js:
3153         (.RemoteDebuggerAgentStub.prototype.setDebuggerScriptSource):
3154         * src/js/InspectorControllerImpl.js:
3155         (devtools.InspectorBackendImpl):
3156
3157 2010-04-15  Matt Perry  <mpcomplete@chromium.org>
3158
3159         Reviewed by Dimitri Glazkov.
3160
3161         Implement layoutTestController's addUserStyleSheet and
3162         setAuthorAndUserStylesEnabled on Chromium port.
3163         https://bugs.webkit.org/show_bug.cgi?id=37595
3164
3165         * public/WebSettings.h:
3166         * public/WebView.h:
3167         * src/WebSettingsImpl.cpp:
3168         (WebKit::WebSettingsImpl::setAuthorAndUserStylesEnabled):
3169         * src/WebSettingsImpl.h:
3170         * src/WebViewImpl.cpp:
3171         (WebKit::WebViewImpl::addUserStyleSheet):
3172         * src/WebViewImpl.h:
3173
3174 2010-04-15  Zhenyao Mo  <zmo@google.com>
3175
3176         Reviewed by Dimitri Glazkov.
3177
3178         Must enable GL_VERTEX_PROGRAM_POINT_SIZE during initialization
3179         https://bugs.webkit.org/show_bug.cgi?id=37178
3180
3181         * src/WebGraphicsContext3DDefaultImpl.cpp: Enable GL_VERTEX_PROGRAM_POINT_SIZE during initialization.
3182         (WebKit::WebGraphicsContext3DDefaultImpl::initialize):
3183
3184 2010-04-15  Albert J. Wong  <ajwong@chromium.org>
3185
3186         Unreviewed, rolling out r57660.
3187         http://trac.webkit.org/changeset/57660
3188         https://bugs.webkit.org/show_bug.cgi?id=37604
3189
3190         Broke a large number of inspector layout tests in chromium.
3191
3192         * WebKit.gypi:
3193         * src/DebuggerAgent.h:
3194         * src/DebuggerAgentImpl.cpp:
3195         * src/DebuggerAgentImpl.h:
3196         * src/DebuggerAgentManager.cpp:
3197         (WebKit::DebuggerAgentManager::debugAttach):
3198         (WebKit::DebuggerAgentManager::debugDetach):
3199         (WebKit::DebuggerAgentManager::setMessageLoopDispatchHandler):
3200         * src/DebuggerAgentManager.h:
3201         * src/InspectorFrontendClientImpl.cpp:
3202         (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
3203         * src/js/DebuggerScript.js: Removed.
3204         * src/js/DevTools.js:
3205         (WebInspector.loaded):
3206         (WebInspector.UnresolvedPropertyValue):
3207         ():
3208         * src/js/DevToolsHostStub.js:
3209         * src/js/InspectorControllerImpl.js:
3210         (devtools.InspectorBackendImpl):
3211
3212 2010-04-15  Yury Semikhatsky  <yurys@google.com>
3213
3214         Reviewed by Pavel Feldman.
3215
3216         Support basic debugging capabilities including step in/over/out in v8
3217         implementation of ScriptDebugServer.
3218
3219         https://bugs.webkit.org/show_bug.cgi?id=37604
3220
3221         * WebKit.gypi:
3222         * src/DebuggerAgent.h:
3223         * src/DebuggerAgentImpl.cpp:
3224         (WebKit::DebuggerAgentImpl::setDebuggerScriptSource):
3225         * src/DebuggerAgentImpl.h:
3226         * src/DebuggerAgentManager.cpp:
3227         (WebKit::DebuggerAgentManager::hostDispatchHandler):
3228         (WebKit::DebuggerAgentManager::debugAttach):
3229         (WebKit::DebuggerAgentManager::debugDetach):
3230         (WebKit::DebuggerAgentManager::setMessageLoopDispatchHandler):
3231         * src/DebuggerAgentManager.h:
3232         * src/InspectorFrontendClientImpl.cpp:
3233         (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
3234         * src/js/DebuggerScript.js: Added.
3235         (debuggerScriptConstructor.DebuggerScript.getAfterCompileScript):
3236         (debuggerScriptConstructor.DebuggerScript.getScripts):
3237         (debuggerScriptConstructor.DebuggerScript._formatScript):
3238         (debuggerScriptConstructor.DebuggerScript.setBreakpoint):
3239         (debuggerScriptConstructor.DebuggerScript.removeBreakpoint):
3240         (debuggerScriptConstructor.DebuggerScript.currentCallFrame):
3241         (debuggerScriptConstructor.DebuggerScript.stepIntoStatement):
3242         (debuggerScriptConstructor.DebuggerScript.stepOverStatement):
3243         (debuggerScriptConstructor.DebuggerScript.stepOutOfFunction):
3244         (debuggerScriptConstructor.DebuggerScript.clearBreakpoints):
3245         (debuggerScriptConstructor.DebuggerScript.setBreakpointsActivated):
3246         (debuggerScriptConstructor.DebuggerScript._frameMirrorToJSCallFrame):
3247         (debuggerScriptConstructor.DebuggerScript._webkitToV8LineNumber):
3248         (debuggerScriptConstructor.DebuggerScript._v8ToWwebkitLineNumber):
3249         (debuggerScriptConstructor):
3250         * src/js/DevTools.js:
3251         (WebInspector.loaded):
3252         (.):
3253         ():
3254         * src/js/DevToolsHostStub.js:
3255         (.RemoteDebuggerAgentStub.prototype.setDebuggerScriptSource):
3256         * src/js/InspectorControllerImpl.js:
3257         (devtools.InspectorBackendImpl):
3258
3259 2010-04-15  Ben Murdoch  <benm@google.com>
3260
3261         Unreviewed, rolling out r57652.
3262         http://trac.webkit.org/changeset/57652
3263         https://bugs.webkit.org/show_bug.cgi?id=37609
3264
3265         Caused a build break on Chromium Mac and Layout Test fail on
3266         Qt
3267
3268         * src/WebInputEventConversion.cpp:
3269         (WebKit::toPlatformTouchPointState):
3270
3271 2010-04-14  Ben Murdoch  <benm@google.com>
3272
3273         Reviewed by Kenneth Rohde Christiansen.
3274
3275         The TouchStationary state of WebCore::PlatformTouchPoint is not
3276         handled inside the touch event handler.
3277         https://bugs.webkit.org/show_bug.cgi?id=37609
3278
3279         After discussions at the WebKit contributors meeting, we decided that
3280         this is a currently unused state without a good future use case in the
3281         Touch API and thus decided to remove it. This patch actions that decision.
3282
3283         * src/WebInputEventConversion.cpp:
3284         (WebKit::toPlatformTouchPointState): Remove TouchStationary.
3285
3286 2010-04-12  Tony Chang  <tony@chromium.org>
3287
3288         Reviewed by Darin Fisher.
3289
3290         [chromium] update chromium DEPS for upstream compile
3291         https://bugs.webkit.org/show_bug.cgi?id=36578
3292
3293         * DEPS: Pull sub deps from chromium's DEPS file
3294
3295 2010-04-14  Sheriff Bot  <webkit.review.bot@gmail.com>
3296
3297         Unreviewed, rolling out r57599.
3298         http://trac.webkit.org/changeset/57599
3299         https://bugs.webkit.org/show_bug.cgi?id=37605
3300
3301         "Broke Chromium build" (Requested by dglazkov on #webkit).
3302
3303         * WebKit.gyp:
3304         * src/WebViewImpl.h:
3305         * tests/PopupMenuTest.cpp: Removed.
3306
3307 2010-04-14  Aaron Boodman  <aa@chromium.org>
3308
3309         Reviewed by David Levin.
3310
3311         Support relative URLs for notifications on Chromium. They weren't working previously because WebCore was inserting
3312         the relative URL into a KURL instance, but when KURL is backed by GURL as it is on Chromium, relative URLs are
3313         unsupported. Fixed by resolving the relative URL first.
3314
3315         https://bugs.webkit.org/show_bug.cgi?id=36623
3316
3317         Adding tests for this is difficult because we don't currently have DRT support for notifications on Mac, only Windows.
3318
3319         * public/WebNotification.h: Remove deprecated icon() method.
3320         * src/WebNotification.cpp: Ditto.
3321
3322 2010-04-14  Jay Civelli  <jcivelli@chromium.org>
3323
3324         Reviewed by Dimitri Glazkov.
3325
3326         [chromium] Select popups would assert when destroyed.
3327         Also adding unit-tests for the select popup code.
3328         https://bugs.webkit.org/show_bug.cgi?id=37436
3329
3330         * WebKit.gyp:
3331         * src/WebViewImpl.h:
3332         (WebKit::WebViewImpl::selectPopup):
3333         * tests/PopupMenuTest.cpp: Added.
3334
3335 2010-04-14  Zhenyao Mo  <zmo@google.com>
3336
3337         Reviewed by Dimitri Glazkov.
3338
3339         readPixels must take PACK_ALIGNMENT into account
3340         https://bugs.webkit.org/show_bug.cgi?id=34718
3341
3342         * src/GraphicsContext3D.cpp: Refactor readPixels.
3343         * src/WebGraphicsContext3DDefaultImpl.cpp:
3344         (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): Temporarily disable pack alignment for glReadPixels.
3345         (WebKit::WebGraphicsContext3DDefaultImpl::readPixels): Move array allocation and alpha fix to WebGLRenderingContext; flush before read pixels.
3346
3347 2010-04-14  Mikhail Naganov  <mnaganov@chromium.org>
3348
3349         Reviewed by Pavel Feldman.
3350
3351         Re-write testProfilerTab to match the new implementation.
3352
3353         https://bugs.webkit.org/show_bug.cgi?id=37516
3354
3355         * src/js/Tests.js:
3356         (.TestSuite.prototype.testProfilerTab.findDisplayedNode):
3357         (.TestSuite.prototype.testProfilerTab.findVisibleView):
3358         (.TestSuite.prototype.testProfilerTab):
3359
3360 2010-04-13  Timothy Hatcher  <timothy@apple.com>
3361
3362         Rename SecurityOrigin::whiteListAccessFromOrigin to addOriginAccessWhitelistEntry.
3363         And SecurityOrigin::resetOriginAccessWhiteLists to resetOriginAccessWhitelists.
3364
3365         SecurityOrigin needs a way to remove individual OriginAccessEntries
3366         https://bugs.webkit.org/show_bug.cgi?id=37449
3367
3368         Reviewed by Dave Hyatt.
3369
3370         * src/WebSecurityPolicy.cpp:
3371         (WebKit::WebSecurityPolicy::whiteListAccessFromOrigin):
3372         (WebKit::WebSecurityPolicy::resetOriginAccessWhiteLists):
3373
3374 2010-04-13  Mikhail Naganov  <mnaganov@chromium.org>
3375
3376         Reviewed by Pavel Feldman.
3377
3378         Fix search behavior in Heap profiles.
3379
3380         https://bugs.webkit.org/show_bug.cgi?id=37498
3381
3382         * src/js/HeapProfilerPanel.js:
3383
3384 2010-04-13  Jeremy Moskovich  <jeremy@chromium.org>
3385
3386         Reviewed by David Levin.
3387
3388         Add some diagnostics to try to track down cause of crash in ArchiveFactory::isArchiveMimeType().
3389
3390         https://bugs.webkit.org/show_bug.cgi?id=36426
3391
3392         * src/ResourceHandle.cpp: Track state across ResourceHandle invocations.
3393         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
3394         (WebCore::ResourceHandleInternal::):
3395         (WebCore::ResourceHandleInternal::start):
3396         (WebCore::ResourceHandleInternal::cancel):
3397         (WebCore::ResourceHandleInternal::didReceiveResponse):
3398         (WebCore::ResourceHandleInternal::didReceiveData):
3399         (WebCore::ResourceHandleInternal::didFinishLoading):
3400         (WebCore::ResourceHandleInternal::didFail):
3401
3402 2010-04-13  Mikhail Naganov  <mnaganov@chromium.org>
3403
3404         Unreviewed Chromium build fix: pin to a newer V8 revision (4386).
3405
3406         * DEPS:
3407
3408 2010-04-12  Mikhail Naganov  <mnaganov@chromium.org>
3409
3410         Reviewed by Yury Semikhatsky.
3411
3412         Replace hand-written JavaScriptProfile* bindings with idl-based, and
3413         in Chromium port, bind them to the new V8's profiler API that is
3414         aligned with JSC.
3415
3416         https://bugs.webkit.org/show_bug.cgi?id=37448
3417
3418         * src/js/InspectorControllerImpl.js:
3419         (devtools.InspectorBackendImpl):
3420         * src/js/ProfilerAgent.js:
3421         (devtools.ProfilerAgent):
3422         (devtools.ProfilerAgent.prototype.initializeProfiling):
3423         (devtools.ProfilerAgent.prototype._didGetActiveProfilerModules):
3424         (devtools.ProfilerAgent.prototype._didGetLogLines):
3425         * src/js/Tests.js:
3426
3427 2010-04-11  Sheriff Bot  <webkit.review.bot@gmail.com>
3428
3429         Unreviewed, rolling out r57468.
3430         http://trac.webkit.org/changeset/57468
3431         https://bugs.webkit.org/show_bug.cgi?id=37433
3432
3433         Broke the world...  Must have applied the patch wrong
3434         (Requested by abarth on #webkit).
3435
3436         * src/ContextMenuClientImpl.cpp:
3437         (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
3438         * src/FrameLoaderClientImpl.cpp:
3439         (WebKit::FrameLoaderClientImpl::finishedLoading):
3440         * src/WebFrameImpl.cpp:
3441         (WebKit::WebFrameImpl::encoding):
3442         (WebKit::WebFrameImpl::commitDocumentData):
3443         * src/WebPageSerializerImpl.cpp:
3444         (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag):
3445         (WebKit::WebPageSerializerImpl::serialize):
3446         * src/WebSearchableFormData.cpp:
3447         (WebCore::GetFormEncoding):
3448         * src/WebViewImpl.cpp:
3449         (WebKit::WebViewImpl::pageEncoding):
3450
3451 2010-04-11  Adam Barth  <abarth@webkit.org>
3452
3453         Reviewed by Eric Seidel.
3454
3455         Factor DocumentWriter out of FrameLoader
3456         https://bugs.webkit.org/show_bug.cgi?id=37175
3457
3458         Update these callsites because the method moved to DocumentWriter.
3459
3460         * src/ContextMenuClientImpl.cpp:
3461         (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
3462         * src/FrameLoaderClientImpl.cpp:
3463         (WebKit::FrameLoaderClientImpl::finishedLoading):
3464         * src/WebFrameImpl.cpp:
3465         (WebKit::WebFrameImpl::encoding):
3466         (WebKit::WebFrameImpl::commitDocumentData):
3467         * src/WebPageSerializerImpl.cpp:
3468         (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag):
3469         (WebKit::WebPageSerializerImpl::serialize):
3470         * src/WebSearchableFormData.cpp:
3471         (WebCore::GetFormEncoding):
3472         * src/WebViewImpl.cpp:
3473         (WebKit::WebViewImpl::pageEncoding):
3474
3475 2010-04-11  Sheriff Bot  <webkit.review.bot@gmail.com>
3476
3477         Unreviewed, rolling out r57460.
3478         http://trac.webkit.org/changeset/57460
3479         https://bugs.webkit.org/show_bug.cgi?id=37424
3480
3481         broke chromium builders (Requested by tony^work on #webkit).
3482
3483         * DEPS:
3484         * gyp_webkit:
3485
3486 2010-04-11  Tony Chang  <tony@chromium.org>
3487
3488         Reviewed by Darin Fisher.
3489
3490         [chromium] update chromium DEPS for upstream compile
3491         https://bugs.webkit.org/show_bug.cgi?id=36578
3492
3493         * DEPS:
3494         * gyp_webkit: Add DumpRenderTree.gyp so we generate xcode projects for DRT.
3495
3496 2010-04-10  Vangelis Kokkevis  <vangelis@chromium.org>
3497
3498         Reviewed by Dimitri Glazkov.
3499
3500         Include file change as a result of renaming LayerRenderSkia.h to LayerRenderChromium.h
3501         https://bugs.webkit.org/show_bug.cgi?id=37231
3502
3503         * src/WebViewImpl.h:
3504
3505 2010-04-10  Rafael Weinstein  <rafaelw@chromium.org>
3506
3507         Reviewed by Eric Seidel.
3508
3509         Cleanup after chromium breakage. All interface methods are
3510         returned to being abstract.
3511
3512         * public/WebNotificationPresenter.h:
3513
3514 2010-04-09  Evan Stade  <estade@chromium.org>
3515
3516         Reviewed by Eric Seidel.
3517
3518         [chromium] Linux: respect the scale factor during printing
3519         https://bugs.webkit.org/show_bug.cgi?id=37168
3520
3521         Chromium doesn't support testing .pdfs from printing at the moment, so
3522         this change is not covered by any tests.
3523
3524         * src/WebFrameImpl.cpp:
3525         (WebKit::ChromePrintContext::spoolPage):
3526
3527 2010-04-09  Aaron Boodman  <aa@chromium.org>
3528
3529         Reviewed by Eric Seidel.
3530
3531         Remove applicationID() from WebDocument as it is Chromium-specific.
3532         https://bugs.webkit.org/show_bug.cgi?id=37350
3533
3534         * public/WebDocument.h:
3535         * src/WebDocument.cpp:
3536
3537 2010-04-09  Jeremy Orlow  <jorlow@chromium.org>
3538
3539         Reviewed by Darin Adler.
3540
3541         Move the IDB::open ExceptionCode paramter to be last
3542         https://bugs.webkit.org/show_bug.cgi?id=37277
3543
3544         Move the ExceptionCode paramter to the last position in 
3545         IndexedDatabaseRequest::open and friends.  It should definitely
3546         go after the callbacks to keep the parameters that come directly
3547         from javascript together.  And having output parameters appear
3548         last is done often in the code base, so it makes sense to push
3549         it past the Frame* param as well.
3550
3551         * public/WebIndexedDatabase.h:
3552         * src/IndexedDatabaseProxy.cpp:
3553         (WebCore::IndexedDatabaseProxy::open):
3554         * src/IndexedDatabaseProxy.h:
3555         * src/WebIndexedDatabaseImpl.cpp:
3556         (WebKit::WebIndexedDatabaseImpl::open):
3557         * src/WebIndexedDatabaseImpl.h:
3558
3559 2010-04-09  Jochen Eisinger  <jochen@chromium.org>
3560
3561         Reviewed by Darin Fisher.
3562
3563         Complete move of createApplicationCacheHost from WebKitClient to WebFrameClient.
3564         https://bugs.webkit.org/show_bug.cgi?id=37330
3565
3566         * public/WebApplicationCacheHost.h:
3567         * public/WebKitClient.h:
3568         * src/ApplicationCacheHostInternal.h:
3569         (WebCore::ApplicationCacheHostInternal::ApplicationCacheHostInternal):
3570
3571 2010-04-09  Marcus Bulach  <bulach@chromium.org>
3572
3573         Reviewed by Jeremy Orlow.
3574
3575         Crash on WebKit::WebGeolocationServiceBridgeImpl::stopUpdating() during frame disconnection
3576         Should not try to access WebViewClient if the frame has already been disconnected.
3577         https://bugs.webkit.org/show_bug.cgi?id=37318
3578
3579         * src/WebGeolocationServiceBridgeImpl.cpp:
3580         (WebKit::WebGeolocationServiceBridgeImpl::stopUpdating):
3581
3582 2010-04-09  Jochen Eisinger  <jochen@chromium.org>
3583
3584         Reviewed by Adam Barth.
3585
3586         Expose SecurityOrigin::canRequest in WebSecurityOrigin.
3587         https://bugs.webkit.org/show_bug.cgi?id=37271
3588
3589         * public/WebSecurityOrigin.h:
3590         * src/WebSecurityOrigin.cpp:
3591         (WebKit::WebSecurityOrigin::canRequest):
3592
3593 2010-04-09  Zhenyao Mo  <zmo@google.com>
3594
3595         Reviewed by Dimitri Glazkov.
3596
3597         Must resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D
3598         https://bugs.webkit.org/show_bug.cgi?id=37174
3599
3600         Test: fast/canvas/webgl/copy-tex-image-and-sub-image-2d.html
3601
3602         * src/WebGraphicsContext3DDefaultImpl.cpp: Resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D.
3603         (WebKit::WebGraphicsContext3DDefaultImpl::copyTexImage2D):
3604         (WebKit::WebGraphicsContext3DDefaultImpl::copyTexSubImage2D):
3605
3606 2010-04-07  Pavel Feldman  <pfeldman@chromium.org>
3607
3608         Reviewed by Yury Semikhatsky.
3609
3610         Chromium: support themes in devtools window.
3611
3612         https://bugs.webkit.org/attachment.cgi?bugid=37216
3613
3614         * WebKit.gypi:
3615         * src/js/DevTools.js:
3616         (WebInspector.setToolbarColors):
3617         (WebInspector.resetToolbarColors):
3618         * src/js/Images/segmentChromium2.png: Added.
3619         * src/js/Images/segmentHoverChromium2.png: Added.
3620         * src/js/Images/segmentSelectedChromium2.png: Added.
3621         * src/js/Images/statusbarBackgroundChromium2.png: Added.
3622         * src/js/Images/statusbarMenuButtonChromium2.png: Added.
3623
3624 2010-04-07  Andrey Kosyakov  <caseq@chromium.org>
3625
3626         Reviewed by Yury Semikhatsky.
3627
3628         Removed inspector methods from ScriptExecutionContext and derived classes.
3629         Removed MessageDestination parameter from console-related calls (we now always
3630         log to the same destination(s)).