2010-05-31 Yury Semikhatsky <yurys@chromium.org>
[WebKit-https.git] / WebKit / chromium / ChangeLog
1 2010-05-31  Yury Semikhatsky  <yurys@chromium.org>
2
3         Reviewed by Pavel Feldman.
4
5         Web Inspector: allow hiding Scripts panel from Chromium code. This
6         is needed to support v8 debugging protocol which has an implementation
7         that conflicts with debugger provided by the inspector.
8         https://bugs.webkit.org/show_bug.cgi?id=39952
9
10         * public/WebDevToolsAgentClient.h:
11         (WebKit::WebDevToolsAgentClient::exposeV8DebuggerProtocol):
12         * public/WebDevToolsFrontendClient.h:
13         (WebKit::WebDevToolsFrontendClient::WebDevToolsFrontendClient):
14         (WebKit::WebDevToolsFrontendClient::sendMessageToAgent):
15         (WebKit::WebDevToolsFrontendClient::sendDebuggerCommandToAgent):
16         (WebKit::WebDevToolsFrontendClient::sendDebuggerPauseScript):
17         (WebKit::WebDevToolsFrontendClient::activateWindow):
18         (WebKit::WebDevToolsFrontendClient::closeWindow):
19         (WebKit::WebDevToolsFrontendClient::requestDockWindow):
20         (WebKit::WebDevToolsFrontendClient::requestUndockWindow):
21         (WebKit::WebDevToolsFrontendClient::hideScriptsPanel):
22         * src/DebuggerAgentManager.cpp:
23         (WebKit::DebuggerAgentManager::debugAttach):
24         (WebKit::DebuggerAgentManager::debugDetach):
25         (WebKit::DebuggerAgentManager::setExposeV8DebuggerProtocol):
26         * src/DebuggerAgentManager.h:
27         * src/InspectorFrontendClientImpl.cpp:
28         (WebKit::InspectorFrontendClientImpl::hiddenPanels):
29         * src/WebDevToolsAgentImpl.cpp:
30         (WebKit::WebDevToolsAgentImpl::WebDevToolsAgentImpl):
31         (WebKit::WebDevToolsAgentImpl::attach):
32
33 2010-05-30  Lyon Chen  <liachen@rim.com>
34
35         Reviewed by Kent Tamura.
36
37         This is a coding style cleanup before fixing to bug 35530.
38
39         Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts.
40         https://bugs.webkit.org/show_bug.cgi?id=35530
41
42         * src/WebFrameImpl.cpp:
43         (WebKit::WebFrameImpl::find):
44         (WebKit::WebFrameImpl::scopeStringMatches):
45         (WebKit::WebFrameImpl::createChildFrame):
46         (WebKit::WebFrameImpl::shouldScopeMatches):
47
48 2010-05-30  Jessie Berlin  <jberlin@webkit.org>
49
50         Reviewed by Pavel Feldman.
51
52         https://bugs.webkit.org/show_bug.cgi?id=39224
53         Bug 39224 - Web Inspector: There should be a way to clean up profiles
54
55         * src/js/InspectorControllerImpl.js:
56         (devtools.InspectorBackendImpl):
57
58 2010-05-29  Vangelis Kokkevis  <vangelis@chromium.org>
59
60         Reviewed by Darin Fisher.
61
62         Adding support for a runtime flag to enable accelerated
63         compositing in chromium.
64         https://bugs.webkit.org/show_bug.cgi?id=39917
65
66         * public/WebSettings.h:
67         * src/WebSettingsImpl.cpp:
68         (WebKit::WebSettingsImpl::setAcceleratedCompositingEnabled):
69         * src/WebSettingsImpl.h:
70
71 2010-05-28  Aaron Boodman  <aa@chromium.org>
72
73         Reviewed by Darin Fisher.
74
75         Add isXHTMLDocument() to WebDocument.
76
77         https://bugs.webkit.org/show_bug.cgi?id=39887
78
79         * public/WebDocument.h: Add isXHTMLDocument().
80         * src/WebDocument.cpp: ditto.
81         (WebKit::WebDocument::isXHTMLDocument): dittorama.
82
83 2010-05-27  Jeremy Orlow  <jorlow@chromium.org>
84
85         Reviewed by Steve Block.
86
87         Add IndexedDB's IDBIndex
88         https://bugs.webkit.org/show_bug.cgi?id=39850
89
90         Add WebKit layer for IDBIndex.
91
92         * WebKit.gyp:
93         * public/WebCommon.h:
94         * public/WebIDBCallbacks.h:
95         (WebKit::WebIDBCallbacks::onError):
96         (WebKit::WebIDBCallbacks::onSuccess):
97         * public/WebIDBDatabase.h:
98         * public/WebIDBIndex.h: Added.
99         (WebKit::WebIDBIndex::~WebIDBIndex):
100         (WebKit::WebIDBIndex::name):
101         (WebKit::WebIDBIndex::keyPath):
102         (WebKit::WebIDBIndex::unique):
103         * src/IDBCallbacksProxy.cpp:
104         (WebCore::IDBCallbacksProxy::onSuccess):
105         * src/IDBCallbacksProxy.h:
106         * src/IDBDatabaseProxy.cpp:
107         * src/IDBDatabaseProxy.h:
108         * src/IDBIndexProxy.cpp: Added.
109         (WebCore::IDBIndexProxy::create):
110         (WebCore::IDBIndexProxy::IDBIndexProxy):
111         (WebCore::IDBIndexProxy::~IDBIndexProxy):
112         (WebCore::IDBIndexProxy::name):
113         (WebCore::IDBIndexProxy::keyPath):
114         (WebCore::IDBIndexProxy::unique):
115         * src/IDBIndexProxy.h: Added.
116         * src/WebIDBCallbacksImpl.cpp:
117         (WebCore::WebIDBCallbacksImpl::onSuccess):
118         * src/WebIDBCallbacksImpl.h:
119         * src/WebIDBDatabaseImpl.cpp:
120         * src/WebIDBDatabaseImpl.h:
121         * src/WebIDBIndexImpl.cpp: Added.
122         (WebKit::WebIDBIndexImpl::WebIDBIndexImpl):
123         (WebKit::WebIDBIndexImpl::~WebIDBIndexImpl):
124         (WebKit::WebIDBIndexImpl::name):
125         (WebKit::WebIDBIndexImpl::keyPath):
126         (WebKit::WebIDBIndexImpl::unique):
127         * src/WebIDBIndexImpl.h: Added.
128
129 2010-05-28  Yury Semikhatsky  <yurys@chromium.org>
130
131         Reviewed by Pavel Feldman.
132
133         Web Inspector: check that ClientMessageLoopAdapter is not 0 before
134         accessing its fileds from inspectedViewClosed method. It may be 0
135         if inspector frontend has not been open.
136         https://bugs.webkit.org/show_bug.cgi?id=39876
137
138         * src/WebDevToolsAgentImpl.cpp:
139         (WebKit::):
140
141 2010-05-27  Eric Uhrhane  <ericu@chromium.org>
142
143         Reviewed by Adam Barth.
144
145         Add v8 bindings for async DB API in workers
146         https://bugs.webkit.org/show_bug.cgi?id=39145
147         
148         * src/DatabaseObserver.cpp:
149         We should check that we're on the context thread now, not the main
150         thread.
151         (WebCore::DatabaseObserver::databaseOpened):
152         (WebCore::DatabaseObserver::databaseModified):
153         (WebCore::DatabaseObserver::databaseClosed):
154
155 2010-05-27  Yury Semikhatsky  <yurys@chromium.org>
156
157         Reviewed by Pavel Feldman.
158
159         Resume script execution if user tries to navigate to another URL
160         https://bugs.webkit.org/show_bug.cgi?id=39842
161
162         * src/WebDevToolsAgentImpl.cpp:
163         (WebKit::):
164         (WebKit::WebDevToolsAgentImpl::didNavigate):
165
166 2010-05-27  Zhenyao Mo  <zmo@google.com>
167
168         Reviewed by Dimitri Glazkov.
169
170         Implement lazy clearing of renderbuffers
171         https://bugs.webkit.org/show_bug.cgi?id=36248
172
173         * src/WebGraphicsContext3DDefaultImpl.cpp:
174         (WebKit::WebGraphicsContext3DDefaultImpl::reshape): Clear WebGL internal buffers.
175
176 2010-05-26  Roland Steiner  <rolandsteiner@chromium.org>
177
178         Reviewed by NOBODY (layout test crashing fix).
179
180         Bug 39811 - WebPluginListBuilderImpl::addMediaTypeToLastPlugin does not initialize pluginIndex
181         https://bugs.webkit.org/show_bug.cgi?id=39811
182
183         Initialize the pluginIndex field (quick fix).
184
185         Tests: covered by fast/dom/prototype-inheritance-2.html
186         (crashed under Chromium Linux and Windows)
187
188         * src/WebPluginListBuilderImpl.cpp:
189         (WebKit::WebPluginListBuilderImpl::addMediaTypeToLastPlugin):
190
191 2010-05-26  Anders Carlsson  <andersca@apple.com>
192
193         Reviewed by Darin Adler.
194
195         Clean up MimeClassInfo and PluginInfo
196         https://bugs.webkit.org/show_bug.cgi?id=39700
197
198         Update for WebCore changes.
199
200         * src/WebPluginListBuilderImpl.cpp:
201         (WebKit::WebPluginListBuilderImpl::addPlugin):
202         (WebKit::WebPluginListBuilderImpl::addMediaTypeToLastPlugin):
203         (WebKit::WebPluginListBuilderImpl::addFileExtensionToLastMediaType):
204         * src/WebPluginListBuilderImpl.h:
205         (WebKit::WebPluginListBuilderImpl::WebPluginListBuilderImpl):
206
207 2010-05-26  Jeremy Orlow  <jorlow@chromium.org>
208
209         Unreviewed chromium build fix
210         https://bugs.webkit.org/show_bug.cgi?id=39739
211
212         The backwards compat function needs to take in a WebSecurityOrigin
213         instead of a WebString.
214
215         * public/WebIndexedDatabase.h:
216         (WebKit::WebIndexedDatabase::open):
217
218 2010-05-26  Jeremy Orlow  <jorlow@chromium.org>
219
220         Reviewed by Darin Fisher.
221
222         Implement WebDOMStorageList and make WebIDBDatabase use it
223         https://bugs.webkit.org/show_bug.cgi?id=39731
224
225         * WebKit.gyp:
226         * public/WebDOMStringList.h: Added.
227         (WebKit::WebDOMStringList::~WebDOMStringList):
228         (WebKit::WebDOMStringList::WebDOMStringList):
229         (WebKit::WebDOMStringList::operator=):
230         * public/WebIDBDatabase.h:
231         (WebKit::WebIDBDatabase::objectStores):
232         * src/IDBDatabaseProxy.cpp:
233         (WebCore::IDBDatabaseProxy::objectStores):
234         * src/WebDOMStringList.cpp: Added.
235         (WebKit::WebDOMStringList::reset):
236         (WebKit::WebDOMStringList::assign):
237         (WebKit::WebDOMStringList::append):
238         (WebKit::WebDOMStringList::length):
239         (WebKit::WebDOMStringList::item):
240         (WebKit::WebDOMStringList::WebDOMStringList):
241         (WebKit::WebDOMStringList::operator=):
242         (WebKit::WebDOMStringList::operator WTF::PassRefPtr<WebCore::DOMStringList>):
243         * src/WebIDBDatabaseImpl.cpp:
244         (WebKit::WebIDBDatabaseImpl::objectStores):
245         * src/WebIDBDatabaseImpl.h:
246
247 2010-05-24  Jeremy Orlow  <jorlow@chromium.org>
248
249         Reviewed by Steve Block.
250
251         Add IDBDatabase's attributes
252         https://bugs.webkit.org/show_bug.cgi?id=39602
253
254         Plumbing to hook up the synchronous attribute requests
255         on IDBDatabase.
256
257         * public/WebIDBDatabase.h:
258         (WebKit::WebIDBDatabase::name):
259         (WebKit::WebIDBDatabase::description):
260         (WebKit::WebIDBDatabase::version):
261         (WebKit::WebIDBDatabase::objectStores):
262         * src/IDBDatabaseProxy.cpp:
263         (WebCore::IDBDatabaseProxy::name):
264         (WebCore::IDBDatabaseProxy::description):
265         (WebCore::IDBDatabaseProxy::version):
266         (WebCore::IDBDatabaseProxy::objectStores):
267         * src/IDBDatabaseProxy.h:
268         * src/WebIDBDatabaseImpl.cpp:
269         (WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl):
270         (WebKit::WebIDBDatabaseImpl::name):
271         (WebKit::WebIDBDatabaseImpl::description):
272         (WebKit::WebIDBDatabaseImpl::version):
273         (WebKit::WebIDBDatabaseImpl::objectStores):
274         * src/WebIDBDatabaseImpl.h:
275
276 2010-05-24  Dirk Pranke  <dpranke@chromium.org>
277
278         Reviewed by Dimitri Glazkov.
279
280         Re-commit r58765 - it had been rolled out to see if it was causing
281         a perf regression (in r59787 and r59789), but that does not seem to
282         have been the case.
283
284         * public/WebNotification.h:
285         * src/WebNotification.cpp:
286         (WebKit::WebNotification::dir):
287         (WebKit::WebNotification::replaceId):
288
289 2010-05-25  Brett Wilson  <brettw@chromium.org>
290
291         Reviewed by Darin Fisher.
292
293         Remove obsolete code for Mac & Windows plugin creation in the Chromium
294         port. This non-Windows code was to prevent a crash which we no longer
295         seem to have, and it is preventing other types of plugins from working.
296         https://bugs.webkit.org/show_bug.cgi?id=39684
297
298         * src/FrameLoaderClientImpl.cpp:
299         (WebKit::FrameLoaderClientImpl::createPlugin):
300
301 2010-05-25  Kent Tamura  <tkent@chromium.org>
302
303         Reviewed by Dimitri Glazkov.
304
305         [DRT/Chromium] Enable 3D_CANVAS, FILTERS, METER_TAG and PROGRESS_TAG
306         https://bugs.webkit.org/show_bug.cgi?id=39652
307
308         3D_CANVAS and FILTERS have been enabled for Chromium tree
309         build. They fix dozens of unexpected test results in a case of
310         upstreaming build.
311         Enable METER_TAG and PROGRESS_TAG too because they will be enabled
312         in Chromium tree in the near future.
313
314         * features.gypi:
315
316 2010-05-25  Vangelis Kokkevis  <vangelis@chromium.org>
317
318         Reviewed by Darin Fisher.
319
320         The GraphicsContext that serves as a backing store for the root layer
321         updates when doing accelerated compositing is now stored in LayerRendererChromium
322         instead of the Layer itself. Updating code in WebViewImpl to reflect
323         that change.
324         https://bugs.webkit.org/show_bug.cgi?id=39640
325
326         * src/WebViewImpl.cpp:
327         (WebKit::WebViewImpl::updateRootLayerContents):
328
329 2010-05-24  Yury Semikhatsky  <yurys@chromium.org>
330
331         Reviewed by Pavel Feldman.
332
333         ScriptDebugServer is now implemented as DebugEventListener which means it doesn't
334         depend on v8 debugging protocol, instead it uses ExecState to collect debugging
335         info and pass it to the listeners.
336
337         New implementation of ScriptDebugServer uses methods provided by client to dispatch
338         its messages while JS is paused(previously the messages was dispatched in a callback
339         passed to v8 along with DebugEventHandler).
340
341         Pause command is dispatched on IO thread.
342
343         https://bugs.webkit.org/show_bug.cgi?id=39594
344
345         * public/WebDevToolsAgentClient.h:
346         (WebKit::WebDevToolsAgentClient::ClientMessageLoop::~ClientMessageLoop):
347         (WebKit::WebDevToolsAgentClient::createClientMessageLoop): Returns an object that allows to run
348         nested client message loop while script execution is paused on a breakpoint.
349         * src/DebuggerAgentManager.cpp:
350         (WebKit::DebuggerAgentManager::setMessageLoopDispatchHandler):
351         * src/DebuggerAgentManager.h:
352         * src/WebDevToolsAgentImpl.cpp:
353         (WebKit::):
354         (WebKit::WebDevToolsAgentImpl::~WebDevToolsAgentImpl):
355         (WebKit::WebDevToolsAgentImpl::attach):
356         * src/js/DebuggerScript.js:
357         (debuggerScriptConstructor.DebuggerScript.getAfterCompileScript):
358         (debuggerScriptConstructor.DebuggerScript.stepIntoStatement):
359         (debuggerScriptConstructor.DebuggerScript.stepOverStatement):
360         (debuggerScriptConstructor.DebuggerScript.stepOutOfFunction):
361         * src/js/InspectorControllerImpl.js:
362         (devtools.InspectorBackendImpl):
363         (else.devtools.InspectorBackendImpl.prototype.pauseInDebugger): Pause command should be handled on IO
364         thread so that script can be paused even if it's in an infinite loop.
365
366 2010-05-25  Yury Semikhatsky  <yurys@chromium.org>
367
368         Reviewed by Pavel Feldman.
369
370         Add memory graph to Timeline overview pane.
371
372         https://bugs.webkit.org/show_bug.cgi?id=37879
373
374         * src/js/devTools.css:
375         (.timeline-category-statusbar-item input):
376
377 2010-05-24  Tony Chang  <tony@chromium.org>
378
379         Reviewed by David Levin.
380
381         [chromium] Fix zoom tests after r60104
382         https://bugs.webkit.org/show_bug.cgi?id=39645
383         
384         m_zoomFactor moved from Frame to FrameView.  FrameView has separate
385         notions of page zoom and text zoom.  In my hurried compile fix, I
386         assumed that m_zoomFactor was for page zoom, but it's not always.
387
388         * src/WebViewImpl.cpp:
389         (WebKit::WebViewImpl::setZoomLevel):
390
391 2010-05-24  Kent Tamura  <tkent@chromium.org>
392
393         Unreviewed. Sort features.
394
395         * features.gypi:
396
397 2010-05-24  Kent Tamura  <tkent@chromium.org>
398
399         Reviewed by Dimitri Glazkov.
400
401         [DRT/Chromium] Import layout_test_helper for Windows
402         https://bugs.webkit.org/show_bug.cgi?id=39581
403
404         * WebKit.gyp: Add a build rule for LayoutTestHelper.exe for Windows.
405
406 2010-05-24  Marcus Bulach  <bulach@chromium.org>
407
408         Reviewed by Kent Tamura.
409
410         [chromium] Adds WebGeolocationServiceMockImpl to remove public dependency on wtf/HashMap.h
411         https://bugs.webkit.org/show_bug.cgi?id=39587
412
413         * public/WebGeolocationServiceMock.h:
414         * src/WebGeolocationServiceMock.cpp:
415         (WebKit::WebGeolocationServiceMockImpl::~WebGeolocationServiceMockImpl):
416         (WebKit::WebGeolocationServiceMock::createWebGeolocationServiceMock):
417         (WebKit::WebGeolocationServiceMockImpl::requestPermissionForFrame):
418         (WebKit::WebGeolocationServiceMockImpl::attachBridge):
419         (WebKit::WebGeolocationServiceMockImpl::detachBridge):
420
421 2010-05-24  Tony Chang  <tony@chromium.org>
422
423         Reviewed by Kent Tamura.
424
425         [chromium] setup fonts on chromium linux DRT
426         https://bugs.webkit.org/show_bug.cgi?id=39644
427
428         * WebKit.gyp:
429
430 2010-05-24  Tony Chang  <tony@chromium.org>
431
432         Not reviewed, build fix.
433
434         Fix the chromium compile due to pageZoomFactor refactoring.
435
436         * src/WebViewImpl.cpp:
437         (WebKit::WebViewImpl::setZoomLevel):
438
439 2010-05-24  Darin Adler  <darin@apple.com>
440
441         Reviewed by Eric Seidel.
442
443         Move view-related functions from Frame to FrameView
444         https://bugs.webkit.org/show_bug.cgi?id=39366
445
446         * src/WebViewImpl.cpp:
447         (WebKit::WebViewImpl::setZoomLevel): Call setZoomLevel on FrameView.
448
449 2010-05-24  Anders Carlsson  <andersca@apple.com>
450
451         Attempt to fix the Chromium build.
452
453         * src/WebViewImpl.cpp:
454
455 2010-05-21  Tony Chang  <tony@chromium.org>
456
457         Reviewed by Ojan Vafai.
458
459         [chromium] if keydown is prevented, don't update the IME and clear the IME state
460         https://bugs.webkit.org/show_bug.cgi?id=39475
461
462         * src/WebViewImpl.cpp:
463         (WebKit::WebViewImpl::handleCompositionEvent):
464
465 2010-05-23  Roman Gershman  <romange@google.com>
466
467         Reviewed by Darin Fisher.
468
469         [Chromium] Suggestion popup is not closed when the view is scrolled.
470         https://bugs.webkit.org/show_bug.cgi?id=38640
471
472         This bug appears on both Windows and Linux platforms.
473         Mac OS, however handles window messages differently and
474         closes popup menu in RenderWidgetHostViewMac::Destroy().
475
476         No tests were added because test_shell does not support suggestion
477         popup.
478
479         * src/ChromeClientImpl.cpp:
480         (WebKit::ChromeClientImpl::invalidateContentsForSlowScroll):
481         (WebKit::ChromeClientImpl::scroll):
482
483 2010-05-23  Marcus Bulach  <bulach@chromium.org>
484
485         Reviewed by Kent Tamura.
486
487         [chromium] Adds Geolocation support to DumpRenderTree.
488         https://bugs.webkit.org/show_bug.cgi?id=39440
489
490         Existing LayoutTests/fast/dom/Geolocation/* should pass.
491
492         * public/WebGeolocationServiceMock.h:
493         * src/WebGeolocationServiceMock.cpp:
494         (WebKit::WebGeolocationServiceMock::setMockGeolocationPermission):
495         (WebKit::WebGeolocationServiceMock::requestPermissionForFrame):
496         (WebKit::WebGeolocationServiceMock::attachBridge):
497         (WebKit::WebGeolocationServiceMock::detachBridge):
498
499 2010-05-22  Kent Tamura  <tkent@chromium.org>
500
501         Reviewed by Dimitri Glazkov.
502
503         [DRT/Chromium] Link resources and load Ahem font for Windows
504         https://bugs.webkit.org/show_bug.cgi?id=39473
505
506         * WebKit.gyp:
507           Add net and webkit resources for Windows.
508           Copy AHEM____.TTF to DumpRenderTree.exe directory.
509
510 2010-05-21  Steve Block  <steveblock@google.com>
511
512         Reviewed by Jeremy Orlow.
513
514         Add DeviceOrientation and DeviceOrientationClient
515         https://bugs.webkit.org/show_bug.cgi?id=39479
516
517         * src/WebViewImpl.cpp:
518         (WebKit::WebViewImpl::WebViewImpl):
519
520 2010-05-20  Viet-Trung Luu  <viettrungluu@chromium.org>
521
522         Reviewed by Darin Fisher.
523
524         [Chromium] Don't rely on focused node to route mouse events to plugins.
525         https://bugs.webkit.org/show_bug.cgi?id=39375
526         http://crbug.com/43935
527
528         On mouse down, do a hit test and check if a plugin was hit. If so, then
529         save the node for future mouse events (until mouse up or capture lost).
530
531         * src/WebViewImpl.cpp:
532         (WebKit::WebViewImpl::WebViewImpl):
533         (WebKit::WebViewImpl::mouseDown):
534         (WebKit::WebViewImpl::handleInputEvent):
535         (WebKit::WebViewImpl::mouseCaptureLost):
536         * src/WebViewImpl.h: Remove m_haveMouseCapture; add m_mouseCaptureNode.
537
538 2010-05-20  Dominic Mazzoni  <dmazzoni@chromium.org>
539
540         Reviewed by Darin Fisher.
541
542         Add headingLevel and setFocused methods.
543
544         https://bugs.webkit.org/show_bug.cgi?id=39238
545
546         * public/WebAccessibilityObject.h:
547         * src/WebAccessibilityObject.cpp:
548         (WebKit::WebAccessibilityObject::headingLevel):
549         (WebKit::WebAccessibilityObject::setFocused):
550
551 2010-05-20  Zhenyao Mo  <zmo@google.com>
552
553         Reviewed by Dimitri Glazkov.
554
555         Map RGBA4/RGB5_A1 to RGBA and RGB565 to RGB in RenderbufferStorage
556         https://bugs.webkit.org/show_bug.cgi?id=39077
557
558         * src/WebGraphicsContext3DDefaultImpl.cpp:
559         (WebKit::WebGraphicsContext3DDefaultImpl::renderbufferStorage): Mapping the enums.
560
561 2010-05-20  Abhishek Arya  <inferno@chromium.org>
562
563         Reviewed by Adam Barth.
564
565         Added method to WebSecurityOrigin for invoking
566         SecurityOrigin::canAccessPasswordManager.
567         https://bugs.webkit.org/show_bug.cgi?id=38916
568
569         * public/WebSecurityOrigin.h:
570         * src/WebSecurityOrigin.cpp:
571         (WebKit::WebSecurityOrigin::canAccessPasswordManager):
572
573 2010-05-20  Darin Fisher  <darin@chromium.org>
574
575         Reviewed by Nate Chapin.
576
577         [chromium] Provide a way to catch exceptions thrown while interacting
578         with a NPObject via WebBindings methods.
579         https://bugs.webkit.org/show_bug.cgi?id=39378
580
581         * public/WebBindings.h:
582         * src/WebBindings.cpp:
583         (WebKit::WebBindings::pushExceptionHandler):
584         (WebKit::WebBindings::popExceptionHandler):
585
586 2010-05-20  Jian Li  <jianli@chromium.org>
587
588         Reviewed by David Levin.
589
590         Rename GenericWorkerTask.h to CrossThreadTask.h and move it to dom directory.
591         https://bugs.webkit.org/show_bug.cgi?id=39135
592
593         * src/WebSharedWorkerImpl.cpp:
594         * src/WebWorkerBase.cpp:
595         * src/WebWorkerClientImpl.cpp:
596         * src/WebWorkerImpl.cpp:
597
598 2010-05-20  Martin Robinson  <mrobinson@webkit.org>
599
600         Reviewed by Ojan Vafai.
601
602         Expose the editing behavior setting in DRT to test all editing code paths
603         https://bugs.webkit.org/show_bug.cgi?id=38603
604
605         * public/WebSettings.h:
606         (WebKit::WebSettings::): Added an enum for EditingBehavior types.
607         * src/WebSettingsImpl.cpp: 
608         (WebKit::WebSettingsImpl::setEditingBehavior): Added.
609         * src/WebSettingsImpl.h:
610
611 2010-05-19  Vangelis Kokkevis  <vangelis@chromium.org>
612
613         Reviewed by Darin Fisher.
614
615         Modifying WebViewImpl to support new hardware compositing for
616         LayerChromium layers.
617         https://bugs.webkit.org/show_bug.cgi?id=38783
618
619         * src/WebViewImpl.cpp:
620         (WebKit::WebViewImpl::paint):
621         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
622         (WebKit::WebViewImpl::updateRootLayerContents):
623         (WebKit::WebViewImpl::setRootLayerNeedsDisplay):
624
625 2010-05-19  Tony Chang  <tony@chromium.org>
626
627         Reviewed by Kent Tamura.
628
629         [chromium] disable spelling suggestions if spellcheck=false
630         https://bugs.webkit.org/show_bug.cgi?id=39402
631         
632         This is the Chromium fix for bug 25639 that was fixed in the
633         other ports in r59585.
634
635         * src/ContextMenuClientImpl.cpp:
636         (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
637
638 2010-05-19  Darin Fisher  <darin@chromium.org>
639
640         Revert r59790 due to failing Chromium npruntime tests.
641
642         * public/WebBindings.h:
643         * src/WebBindings.cpp:
644
645 2010-05-19  Darin Fisher  <darin@chromium.org>
646
647         Reviewed by Nate Chapin.
648
649         [chromium] Provide a way to catch exceptions thrown while interacting
650         with a NPObject via WebBindings methods.
651         https://bugs.webkit.org/show_bug.cgi?id=39378
652
653         * public/WebBindings.h:
654         * src/WebBindings.cpp:
655         (WebKit::WebBindings::pushExceptionHandler):
656         (WebKit::WebBindings::popExceptionHandler):
657
658 2010-05-19  Dirk Pranke  <dpranke@chromium.org>
659
660         Try again to roll out r58765.
661
662         * public/WebNotification.h:
663         * src/WebNotification.cpp:
664
665 2010-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>
666
667         Unreviewed, rolling out r59782.
668         http://trac.webkit.org/changeset/59782
669         https://bugs.webkit.org/show_bug.cgi?id=39379
670
671         broke DRT build (Requested by dpranke on #webkit).
672
673         * public/WebNotification.h:
674         * src/WebNotification.cpp:
675         (WebKit::WebNotification::dir):
676         (WebKit::WebNotification::replaceId):
677
678 2010-05-19  Jian Li  <jianli@chromium.org>
679
680         Reviewed by Darin Fisher.
681
682         Remove obsolete ChromiumBridge code that routes FileSystem calls to WebKitClient.
683         https://bugs.webkit.org/show_bug.cgi?id=39332
684
685         * public/WebKitClient.h:
686         * src/ChromiumBridge.cpp:
687         (WebCore::ChromiumBridge::fileExists):
688         (WebCore::ChromiumBridge::deleteFile):
689         (WebCore::ChromiumBridge::deleteEmptyDirectory):
690         (WebCore::ChromiumBridge::getFileSize):
691         (WebCore::ChromiumBridge::getFileModificationTime):
692         (WebCore::ChromiumBridge::directoryName):
693         (WebCore::ChromiumBridge::pathByAppendingComponent):
694         (WebCore::ChromiumBridge::makeAllDirectories):
695         (WebCore::ChromiumBridge::getAbsolutePath):
696         (WebCore::ChromiumBridge::isDirectory):
697         (WebCore::ChromiumBridge::filePathToURL):
698
699 2010-05-19  Marcus Bulach  <bulach@chromium.org>
700
701         Reviewed by Steve Block.
702
703         [chromium] Adds supports for layout tests using GeolocationServiceMock.
704         https://bugs.webkit.org/show_bug.cgi?id=39081
705
706         Allows injection of GeolocationServiceMock factory.
707         Tests: existing fast/dom/Geolocation/*
708
709         * WebKit.gyp:
710         * public/WebGeolocationServiceMock.h: Added.
711         * src/WebGeolocationServiceMock.cpp: Added.
712         (WebCore::GeolocationServiceChromiumMock::create):
713         (WebCore::GeolocationServiceChromiumMock::GeolocationServiceChromiumMock):
714         (WebCore::GeolocationServiceChromiumMock::startUpdating):
715         (WebCore::GeolocationServiceChromiumMock::stopUpdating):
716         (WebCore::GeolocationServiceChromiumMock::lastPosition):
717         (WebCore::GeolocationServiceChromiumMock::lastError):
718         (WebCore::GeolocationServiceChromiumMock::geolocationServicePositionChanged):
719         (WebCore::GeolocationServiceChromiumMock::geolocationServiceErrorOccurred):
720         (WebKit::WebGeolocationServiceMock::setMockGeolocationPosition):
721         (WebKit::WebGeolocationServiceMock::setMockGeolocationError):
722
723 2010-05-17  Jeremy Orlow  <jorlow@chromium.org>
724
725         Reviewed by Darin Fisher.
726
727         Hook Chromium's WebIndexedDatabaseImpl up to IndexedDatabaseImpl
728         https://bugs.webkit.org/show_bug.cgi?id=39216
729
730         Web____Impl is for re-entering the WebKit layer from the browser layer.
731         Thus the previous IDBCallbacksProxy was mis-named (and should have been
732         WebIDBCallbacksImpl).  This patch renames it and then implements the
733         proper proxy (which is for going from WebCore to WebKit).
734
735         Also change using security origin strings to using WebSecurityOrigin
736         objects.
737
738         This patch also implements the glue between WebIndexedDatabaseImpl and
739         IndexedDatabaseImpl.
740
741         * WebKit.gyp:
742         * src/IDBCallbacksProxy.cpp:
743         (WebCore::IDBCallbacksProxy::create):
744         (WebCore::IDBCallbacksProxy::IDBCallbacksProxy):
745         (WebCore::IDBCallbacksProxy::onError):
746         (WebCore::IDBCallbacksProxy::onSuccess):
747         * src/IDBCallbacksProxy.h:
748         * src/IndexedDatabaseProxy.cpp:
749         (WebCore::IndexedDatabaseProxy::open):
750         * src/IndexedDatabaseProxy.h:
751         * src/WebIDBCallbacksImpl.cpp: Added.
752         (WebCore::WebIDBCallbacksImpl::WebIDBCallbacksImpl):
753         (WebCore::WebIDBCallbacksImpl::~WebIDBCallbacksImpl):
754         (WebCore::WebIDBCallbacksImpl::onError):
755         (WebCore::WebIDBCallbacksImpl::onSuccess):
756         * src/WebIDBCallbacksImpl.h: Added.
757         * src/WebIDBDatabaseImpl.cpp: Added.
758         (WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl):
759         (WebKit::WebIDBDatabaseImpl::~WebIDBDatabaseImpl):
760         * src/WebIDBDatabaseImpl.h: Added.
761         * src/WebIndexedDatabaseImpl.cpp:
762         (WebKit::WebIndexedDatabaseImpl::WebIndexedDatabaseImpl):
763         (WebKit::WebIndexedDatabaseImpl::open):
764         * src/WebIndexedDatabaseImpl.h:
765
766 2010-05-18  Kent Tamura  <tkent@chromium.org>
767
768         Reviewed by Dimitri Glazkov.
769
770         [DRT/Chromium] Fix a repaint issue and textarea tests
771         https://bugs.webkit.org/show_bug.cgi?id=39054
772
773         * DEPS: Update to Chromium r47248 to use a fix for CommandLine assertion
774           and textAreaResizeCorner.png
775         * WebKit.gyp: Add textAreaResizeCorner.png as a Mac resource
776
777 2010-05-18  Tony Chang  <tony@chromium.org>
778
779         Reviewed by Ojan Vafai.
780
781         [chromium] ignore IME events if the keydown event was prevented
782         https://bugs.webkit.org/show_bug.cgi?id=37692
783
784         * src/WebViewImpl.cpp:
785         (WebKit::WebViewImpl::handleCompositionEvent):
786
787 2010-05-18  MORITA Hajime  <morrita@google.com>
788
789         Reviewed by Kent Tamura.
790
791         [Chromium] Windows: Determinate progress bar should have glossy overlay
792         https://bugs.webkit.org/show_bug.cgi?id=39269
793
794         Changed WebThemeEngine::drawProgressBar() signature to delegate
795         theme implementation detail to the engine.
796         Chromium side will come to http://crbug.com/44430.
797         
798         No new tests, animation effect can be confirmed only manually.        
799
800         * public/WebThemeEngine.h:
801         (WebKit::WebThemeEngine::paintProgressBar):
802         * src/ChromiumBridge.cpp:
803         (WebCore::ChromiumBridge::paintProgressBar):
804
805 2010-05-16  Mike Belshe  <mbelshe@chromium.org>
806
807         Reviewed by Dimitri Glazkov.
808
809         Add a flag to the ResourceResponse for tracking if a request was
810         fetched via the TLS/Next-Protocol-Negotiation mechanism.
811
812         Also cleaned up the style in ResourceResponse to group the flags
813         together (and alphabetically) and hopefully improve readability of
814         the file.
815
816         https://bugs.webkit.org/show_bug.cgi?id=39078
817
818         * public/WebURLResponse.h:
819         * src/WebURLResponse.cpp:
820         (WebKit::WebURLResponse::wasNpnNegotiated):
821         (WebKit::WebURLResponse::setWasNpnNegotiated):
822
823 2010-05-16  Eric Seidel  <eric@webkit.org>
824
825         Unreviewed, rolling out r59571.
826         http://trac.webkit.org/changeset/59571
827         https://bugs.webkit.org/show_bug.cgi?id=39054
828
829         Broke Cr Win, but we didn't notice immediately due to
830         https://bugs.webkit.org/show_bug.cgi?id=38926.  It's possible
831         that this didn't actually break Cr Win, but rather that bug
832         38926 necessitates a clean compile after this and sucessive
833         checkins only produced a partial recompile and thus failed to
834         build.
835
836         * DEPS:
837         * WebKit.gyp:
838         * features.gypi:
839
840 2010-05-16  Sheriff Bot  <webkit.review.bot@gmail.com>
841
842         Unreviewed, rolling out r59574.
843         http://trac.webkit.org/changeset/59574
844         https://bugs.webkit.org/show_bug.cgi?id=39176
845
846         Supposedly broke cr-win, but the errors seems somewhat
847         unrelated (Requested by abarth on #webkit).
848
849         * public/WebURLResponse.h:
850         * src/WebURLResponse.cpp:
851
852 2010-05-16  Mike Belshe  <mbelshe@chromium.org>
853
854         Reviewed by Dimitri Glazkov.
855
856         Add a flag to the ResourceResponse for tracking if a request was
857         fetched via the TLS/Next-Protocol-Negotiation mechanism.
858
859         Also cleaned up the style in ResourceResponse to group the flags
860         together (and alphabetically) and hopefully improve readability of
861         the file.
862
863         https://bugs.webkit.org/show_bug.cgi?id=39078
864
865         * public/WebURLResponse.h:
866         * src/WebURLResponse.cpp:
867         (WebKit::WebURLResponse::wasNpnNegotiated):
868         (WebKit::WebURLResponse::setWasNpnNegotiated):
869
870 2010-05-16  Kent Tamura  <tkent@chromium.org>
871
872         Reviewed by Dimitri Glazkov.
873
874         [DRT/Chromium] Fix repaint, WebGL, textarea tests
875         https://bugs.webkit.org/show_bug.cgi?id=39054
876
877         * DEPS: Update to Chromium r47248 to use a fix for CommandLine assertion
878           and textAreaResizeCorner.png
879         * WebKit.gyp: Add textAreaResizeCorner.png as a Mac resource
880         * features.gypi: Enable ENABLE_3D_CANVAS.
881
882 2010-05-15  Darin Fisher  <darin@chromium.org>
883
884         Reviewed by Adam Barth.
885
886         [chromium] Expose element accessor on WebPluginContainer
887         https://bugs.webkit.org/show_bug.cgi?id=39152
888
889         * public/WebPluginContainer.h:
890         * src/WebPluginContainerImpl.cpp:
891         (WebKit::WebPluginContainerImpl::element):
892         * src/WebPluginContainerImpl.h:
893
894 2010-05-15  Jochen Eisinger  <jochen@chromium.org>
895
896         Reviewed by Dmitry Titov.
897
898         Implement canEstablishDatabase call for workers.
899         https://bugs.webkit.org/show_bug.cgi?id=38742
900
901         * public/WebCommonWorkerClient.h:
902         * src/DatabaseObserver.cpp:
903         (WebCore::DatabaseObserver::canEstablishDatabase):
904         * src/WebWorkerBase.cpp:
905         (WebKit::WebWorkerBase::allowDatabase):
906         (WebKit::WebWorkerBase::allowDatabaseTask):
907         (WebKit::WebWorkerBase::AllowDatabaseMainThreadBridge::AllowDatabaseMainThreadBridge):
908         (WebKit::WebWorkerBase::AllowDatabaseMainThreadBridge::cancel):
909         (WebKit::WebWorkerBase::AllowDatabaseMainThreadBridge::result):
910         (WebKit::WebWorkerBase::AllowDatabaseMainThreadBridge::signalCompleted):
911         (WebKit::WebWorkerBase::AllowDatabaseMainThreadBridge::didComplete):
912         * src/WebWorkerBase.h:
913         * src/WebWorkerClientImpl.h:
914         (WebKit::WebWorkerClientImpl::allowDatabase):
915
916 2010-05-15  Jay Civelli  <jcivelli@chromium.org>
917
918         Reviewed by Darin Fisher.
919
920         [chromium] Adding a notification on WebViewClient when a new 
921         node gets focused.
922         https://bugs.webkit.org/show_bug.cgi?id=38508
923
924         * public/WebViewClient.h:
925         (WebKit::WebViewClient::focusedNodeChanged):
926         * src/ChromeClientImpl.cpp:
927         (WebKit::ChromeClientImpl::focusedNodeChanged):
928
929 2010-05-15  Evan Stade  <estade@chromium.org>
930
931         Reviewed by Adam Barth.
932
933         [chromium] "Check spelling in this field" context menu item always checked
934         https://bugs.webkit.org/show_bug.cgi?id=39018
935
936         Initialize all POD members of WebContextMenuData in a default
937         constructor.
938
939         No tests because this code would need some major refactoring to unit
940         test, and AFAICT it's not testable via layout tests. See note at top
941         of getCustomMenuFromDefaultItems.
942
943         * public/WebContextMenuData.h:
944         (WebKit::WebContextMenuData::WebContextMenuData):
945         * src/ContextMenuClientImpl.cpp:
946         (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
947
948 2010-05-14  Darin Fisher  <darin@chromium.org>
949
950         Reviewed by Dimitri Glazkov.
951
952         [chromium] Remove temporary relative include paths
953         https://bugs.webkit.org/show_bug.cgi?id=38776
954
955         * public/WebPasswordAutocompleteListener.h:
956         * src/FrameLoaderClientImpl.h:
957         * src/PlatformMessagePortChannel.h:
958         * src/WebAnimationControllerImpl.h:
959         * src/WebBindings.cpp:
960         * src/WebDataSourceImpl.h:
961         * src/WebDevToolsAgentPrivate.h:
962         * src/WebFileChooserCompletionImpl.h:
963         * src/WebFrameImpl.h:
964         * src/WebInputEventConversion.h:
965         * src/WebPluginContainerImpl.h:
966         * src/WebPluginLoadObserver.h:
967         * src/WebPopupMenuImpl.h:
968         * src/WebSettingsImpl.h:
969         * src/WebViewImpl.h:
970         * src/WebWorkerClientImpl.h:
971         * src/WrappedResourceRequest.h:
972         * src/WrappedResourceResponse.h:
973
974 2010-05-14  Anton Muhin  <antonm@chromium.org>
975
976         Reviewed by Darin Fisher.
977
978         [Chromium] Consider implementing addOriginAccessWhitelistEntry method
979         https://bugs.webkit.org/show_bug.cgi?id=37578
980
981         Remove deprecated methods.
982
983         * public/WebSecurityPolicy.h:
984         * src/WebSecurityPolicy.cpp:
985
986 2010-05-14  Kenneth Russell  <kbr@google.com>
987
988         Reviewed by Darin Adler.
989
990         Rename WebGLArray types to TypedArray types
991         https://bugs.webkit.org/show_bug.cgi?id=39091
992
993         Extended functionality of do-webcore-rename script and used it to
994         rename the WebGLArray types to the TypedArray naming convention.
995         The only source files which were touched by hand, and which are
996         being manually reviewed, are:
997             WebCore/page/DOMWindow.idl
998             WebCore/bindings/generic/RuntimeEnabledFeatures.h (script's changes undone)
999             WebKit/WebCore/bindings/js/JSDOMWindowCustom.cpp
1000             WebKit/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp
1001         These only needed to be touched to update the aliases between the
1002         WebGLArray and TypedArray names introduced in bug 39036. (It was
1003         not feasible to have do-webcore-rename handle this as it would
1004         introduce circular renamings.) These aliases will be removed in
1005         roughly a month once existing WebGL content has been updated.
1006
1007         No new tests; covered under existing WebGL tests. Updated
1008         constructed-objects-prototypes and prototype-inheritance-2 tests.
1009         Ran all layout tests in Safari and all WebGL tests in Chromium.
1010
1011         * src/GraphicsContext3D.cpp:
1012         (WebCore::GraphicsContext3DInternal::bufferData):
1013         (WebCore::GraphicsContext3DInternal::bufferSubData):
1014
1015 2010-05-14  Jochen Eisinger  <jochen@chromium.org>
1016
1017         Reviewed by Eric Seidel.
1018
1019         Make ImageDiff depend on webkit (again).
1020         https://bugs.webkit.org/show_bug.cgi?id=39000
1021
1022         * WebKit.gyp:
1023
1024 2010-05-14  James Simonsen  <simonjam+webkit@google.com>
1025
1026         Reviewed by Darin Fisher.
1027
1028         [chromium] Expose volume through WebMediaPlayerClient
1029         https://bugs.webkit.org/show_bug.cgi?id=38947
1030
1031         * public/WebMediaPlayerClient.h:
1032         * src/WebMediaPlayerClientImpl.cpp:
1033         (WebKit::WebMediaPlayerClientImpl::volume):
1034         * src/WebMediaPlayerClientImpl.h:
1035
1036 2010-05-14  Tony Gentilcore  <tonyg@chromium.org>
1037
1038         Reviewed by Darin Fisher.
1039
1040         [chromium] Update chromium port to send/receive cached metadata
1041         https://bugs.webkit.org/show_bug.cgi?id=38665
1042
1043         * public/WebKitClient.h:
1044         (WebKit::WebKitClient::cacheMetadata):
1045         * public/WebURLLoaderClient.h:
1046         (WebKit::WebURLLoaderClient::didReceiveCachedMetadata):
1047         * public/WebURLResponse.h:
1048         * src/ChromiumBridge.cpp:
1049         (WebCore::ChromiumBridge::cacheMetadata):
1050         * src/ResourceHandle.cpp:
1051         (WebCore::ResourceHandleInternal::didReceiveCachedMetadata):
1052         (WebCore::ResourceHandle::cacheMetadata):
1053         * src/WebURLResponse.cpp:
1054         (WebKit::WebURLResponse::responseTime):
1055         (WebKit::WebURLResponse::setResponseTime):
1056
1057 2010-05-13  Tony Chang  <tony@chromium.org>
1058
1059         Reviewed by Kent Tamura.
1060
1061         [chromium] enable DRT build in chromium (for the last time)
1062         https://bugs.webkit.org/show_bug.cgi?id=39109
1063
1064         * WebKit.gyp:
1065
1066 2010-05-13  Pavel Feldman  <pfeldman@chromium.org>
1067
1068         Reviewed by Yury Semikhatsky.
1069
1070         Web Inspector: main inspector toolbar takes noticeable time to expand.
1071
1072         https://bugs.webkit.org/show_bug.cgi?id=39013
1073
1074         * src/js/DevTools.js:
1075         (devtools.domContentLoaded):
1076
1077 2010-05-12  Hans Wennborg  <hans@chromium.org>
1078
1079         Reviewed by Jeremy Orlow.
1080
1081         [Chromium] Remove transitional functions from WebStorageNamespace and WebViewClient.
1082         https://bugs.webkit.org/show_bug.cgi?id=38985
1083
1084         These functions are no longer called as of Chromium revision 47020.
1085         This is part of resolving http://crbug.com/42740
1086
1087         * public/WebStorageNamespace.h:
1088         * public/WebViewClient.h:
1089         (WebKit::WebViewClient::createSessionStorageNamespace):
1090
1091 2010-05-12  Tony Chang  <tony@chromium.org>
1092
1093         Reviewed by Kent Tamura.
1094
1095         [chromium] disable DRT in chromium again
1096         https://bugs.webkit.org/show_bug.cgi?id=39049
1097
1098         * WebKit.gyp:
1099
1100 2010-05-12  John Abd-El-Malek  <jam@chromium.org>
1101
1102         Reviewed by Darin Fisher.
1103
1104         [chromium] Disable WebScrollbarImpl's scrollbar if it's not needed
1105         https://bugs.webkit.org/show_bug.cgi?id=39025
1106
1107         * src/WebScrollbarImpl.cpp:
1108         (WebKit::WebScrollbarImpl::setLocation):
1109         (WebKit::WebScrollbarImpl::setDocumentSize):
1110
1111 2010-05-12  Dumitru Daniliuc  <dumi@chromium.org>
1112
1113         Reviewed by Dimitri Glazkov.
1114
1115         Removing the unnecessary dirfd parameter.
1116         https://bugs.webkit.org/show_bug.cgi?id=38869
1117
1118         * public/WebKitClient.h:
1119         (WebKit::WebKitClient::databaseOpenFile):
1120         * src/ChromiumBridge.cpp:
1121         (WebCore::ChromiumBridge::databaseOpenFile):
1122
1123 2010-05-12  Jeremy Orlow  <jorlow@chromium.org>
1124
1125         Reviewed by Steve Block.
1126
1127         [Chromium] Pass the origin parameter for WebIndexedDatabase::open
1128         https://bugs.webkit.org/show_bug.cgi?id=38983
1129
1130         * public/WebIndexedDatabase.h:
1131         * src/IndexedDatabaseProxy.cpp:
1132         (WebCore::IndexedDatabaseProxy::open):
1133         * src/WebIndexedDatabaseImpl.cpp:
1134         (WebKit::WebIndexedDatabaseImpl::open):
1135         * src/WebIndexedDatabaseImpl.h:
1136
1137 2010-05-10  yael aharon  <yael.aharon@nokia.com>
1138
1139         Reviewed by Darin Adler.
1140
1141         Support control attribute of HTMLLabelElement
1142         https://bugs.webkit.org/show_bug.cgi?id=38688
1143
1144         Renamed HTMLLabelElement::correspondingControl to HTMLLabelElement::control
1145
1146         * src/WebLabelElement.cpp:
1147         (WebKit::WebLabelElement::correspondingControl):
1148
1149 2010-05-12  MORITA Hajime  <morrita@google.com>
1150
1151         Reviewed by Kent Tamura.
1152         
1153         [Chromium] Support HTML5 <progress> element on Windows.
1154         https://bugs.webkit.org/show_bug.cgi?id=37308
1155
1156         Extended ChromiumBridge to handle progress bar painting,
1157         and added delegations to it.
1158         
1159         No new tests. Test cases should be shared with existing ones for
1160         progress element.  Expectaions will be added after PROGRESS_TAG is
1161         enabled on Chromium tree.
1162
1163         * public/WebThemeEngine.h:
1164         (WebKit::WebThemeEngine::paintProgressBar):
1165         * src/ChromiumBridge.cpp:
1166         (WebCore::ChromiumBridge::paintProgressBar):
1167
1168 2010-05-12  Marcus Bulach  <bulach@chromium.org>
1169
1170         Reviewed by Steve Block.
1171
1172         Attaches the geolocation bridge later on startUpdating().
1173         This prevents a page requesting permission when it has just accessed navigator.geolocation (without calling navigator.geolocation.getCurrentPosition/watchPosition).
1174         Note: when Geolocation::haveSuitableCachedPosition(), WebGeolocationServiceBridgeImpl::startUpdating() is not called,
1175         so we attach the bridge if needed at requestGeolocationPermissionForFrame().
1176         https://bugs.webkit.org/show_bug.cgi?id=38323
1177         http://crbug.com/42789
1178
1179         * src/ChromeClientImpl.cpp:
1180         (WebKit::ChromeClientImpl::requestGeolocationPermissionForFrame):
1181         * src/WebGeolocationServiceBridgeImpl.cpp:
1182         (WebKit::WebGeolocationServiceBridgeImpl::attachBridgeIfNeeded):
1183         (WebKit::WebGeolocationServiceBridgeImpl::setLastPosition):
1184
1185 2010-05-12  Tony Chang  <tony@chromium.org>
1186
1187         Reviewed by Kent Tamura.
1188
1189         [chromium] add DRT back to the chromium build
1190         https://bugs.webkit.org/show_bug.cgi?id=38978
1191
1192         * WebKit.gyp:
1193
1194 2010-05-11  Kent Tamura  <tkent@chromium.org>
1195
1196         Reviewed by Dimitri Glazkov.
1197
1198         [DRT/Chromium] Apply recent changes of test_shell to DRT
1199         https://bugs.webkit.org/show_bug.cgi?id=38895
1200
1201         * DEPS: Update Chromium revision to use the recent webkit_support change.
1202         * WebKit.gyp: Add JavaScriptCore/wtf to 'include' section.
1203         * src/WebGraphicsContext3D.cpp:
1204           Remove ENABLE(3D_CANVAS) to provide an empty implementation of
1205           WebGraphicsContext3D::createDefault().
1206
1207 2010-05-11  Avi Drissman  <avi@chromium.org>
1208
1209         Reviewed by Darin Fisher.
1210
1211         [Chromium] Pipe RTL info into WebPopupMenuInfo
1212         https://bugs.webkit.org/show_bug.cgi?id=38749
1213
1214         * public/WebPopupMenuInfo.h:
1215         * src/ChromeClientImpl.cpp:
1216         (WebKit::ChromeClientImpl::getPopupMenuInfo):
1217
1218 2010-05-11  David Holloway  <dhollowa@chromium.org>
1219
1220         Reviewed by Darin Fisher.
1221
1222         [chromium] Add size method to WebInputElement class, providing same data
1223         as HTMLInputElement::size().  During form AutoFill Chromium needs to
1224         access the input element's size attribute in aid of form matching and
1225         filling heuristics.
1226         
1227         https://bugs.webkit.org/show_bug.cgi?id=38825
1228
1229         * public/WebInputElement.h:
1230         * src/WebInputElement.cpp:
1231         (WebKit::WebInputElement::size):
1232
1233 2010-05-11  Nate Chapin  <japhet@chromium.org>
1234
1235         Reviewed by Adam Barth.
1236
1237         Crash fix in WebPageSerializerImpl::serialize().
1238
1239         https://bugs.webkit.org/show_bug.cgi?id=38543
1240
1241         The relevant test is a test_shell_test in src.chromium.org, because neither
1242         DRT nor the Chromium webkit unit tests can currently cover the serializer
1243         functionality.
1244
1245         * src/WebPageSerializerImpl.cpp:
1246         (WebKit::WebPageSerializerImpl::serialize): Check each frame's url before using it,
1247             since they are not guaranteed to be valid (e.g., if the frame was treated as a download).
1248
1249 2010-05-11  Jian Li  <jianli@chromium.org>
1250
1251         Reviewed by Dmitry Titov.
1252
1253         Expose FileReader interface.
1254         https://bugs.webkit.org/show_bug.cgi?id=38609
1255
1256         * features.gypi: turn on building FileReader for Chromium.
1257
1258 2010-05-10  Tony Chang  <tony@chromium.org>
1259
1260         Reviewed by Kent Tamura.
1261
1262         [chromium] don't build DRT in chromium checkouts due to a circular gyp dependency
1263         https://bugs.webkit.org/show_bug.cgi?id=38889
1264
1265         * WebKit.gyp:
1266
1267 2010-05-10  John Abd-El-Malek  <jam@chromium.org>
1268
1269         Reviewed by Darin Fisher.
1270
1271         [chromium] Add WebKitScrollbar interface to allow Chromium code to reuse the scrollbar code
1272         https://bugs.webkit.org/show_bug.cgi?id=38854
1273
1274         * public/WebScrollbar.h: Added.
1275         (WebKit::WebScrollbar::):
1276         (WebKit::WebScrollbar::~WebScrollbar):
1277         * public/WebScrollbarClient.h: Added.
1278         * public/WebThemeEngine.h:
1279         * src/AssertMatchingEnums.cpp:
1280         * src/WebScrollbarImpl.cpp: Added.
1281         (WebKit::WebScrollbar::create):
1282         (WebKit::WebScrollbar::defaultThickness):
1283         (WebKit::WebScrollbarImpl::WebScrollbarImpl):
1284         (WebKit::WebScrollbarImpl::~WebScrollbarImpl):
1285         (WebKit::WebScrollbarImpl::setLocation):
1286         (WebKit::WebScrollbarImpl::value):
1287         (WebKit::WebScrollbarImpl::setValue):
1288         (WebKit::WebScrollbarImpl::setDocumentSize):
1289         (WebKit::WebScrollbarImpl::scroll):
1290         (WebKit::WebScrollbarImpl::paint):
1291         (WebKit::WebScrollbarImpl::handleInputEvent):
1292         (WebKit::WebScrollbarImpl::onMouseDown):
1293         (WebKit::WebScrollbarImpl::onMouseUp):
1294         (WebKit::WebScrollbarImpl::onMouseMove):
1295         (WebKit::WebScrollbarImpl::onMouseLeave):
1296         (WebKit::WebScrollbarImpl::onMouseWheel):
1297         (WebKit::WebScrollbarImpl::onKeyDown):
1298         (WebKit::WebScrollbarImpl::valueChanged):
1299         (WebKit::WebScrollbarImpl::invalidateScrollbarRect):
1300         (WebKit::WebScrollbarImpl::isActive):
1301         (WebKit::WebScrollbarImpl::scrollbarCornerPresent):
1302         (WebKit::WebScrollbarImpl::getTickmarks):
1303         * src/WebScrollbarImpl.h: Added.
1304         * src/WebViewImpl.cpp:
1305         (WebKit::WebViewImpl::scrollViewWithKeyboard):
1306         (WebKit::WebViewImpl::mapKeyCodeForScroll):
1307         * src/WebViewImpl.h:
1308
1309 2010-05-10  Tony Gentilcore  <tonyg@chromium.org>
1310
1311         Reviewed by Adam Barth.
1312
1313         Provide mechanism to cache metadata for a resource
1314         https://bugs.webkit.org/show_bug.cgi?id=37874
1315
1316         * src/ResourceHandle.cpp:
1317         (WebCore::ResourceHandle::cacheMetadata):
1318
1319 2010-05-10  Hans Wennborg  <hans@chromium.org>
1320
1321         Reviewed by Jeremy Orlow.
1322
1323         [Chromium] Add quota parameter to WebViewClient::createSessionStorageNamespace()
1324         https://bugs.webkit.org/show_bug.cgi?id=38750
1325
1326         Put a per-origin quota on session storage since it is using memory in
1327         the browser process, and should not be allowed to grow arbitrarily
1328         large. See also http://trac.webkit.org/changeset/58828.
1329
1330         * public/WebStorageNamespace.h:
1331         * public/WebViewClient.h:
1332         (WebKit::WebViewClient::createSessionStorageNamespace):
1333         * src/StorageNamespaceProxy.cpp:
1334         (WebCore::StorageNamespace::sessionStorageNamespace):
1335
1336
1337 2010-05-10  Jeremy Orlow  <jorlow@chromium.org>
1338
1339         Reviewed by Nate Chapin.
1340
1341         Change IndexedDB to use events instead of callbacks
1342         https://bugs.webkit.org/show_bug.cgi?id=38594
1343
1344         Change the glue here to match the changes I made in WebCore.
1345
1346         * WebKit.gyp:
1347         * public/WebIDBCallbacks.h:
1348         * public/WebIndexedDatabase.h:
1349         * src/IDBCallbacksProxy.cpp: Added.
1350         (WebCore::IDBCallbacksProxy::IDBCallbacksProxy):
1351         (WebCore::IDBCallbacksProxy::~IDBCallbacksProxy):
1352         (WebCore::IDBCallbacksProxy::onError):
1353         (WebCore::IDBCallbacksProxy::onSuccess):
1354         * src/IDBCallbacksProxy.h:
1355         * src/IndexedDatabaseProxy.cpp:
1356         (WebCore::IndexedDatabaseProxy::open):
1357         * src/IndexedDatabaseProxy.h:
1358         * src/WebIndexedDatabaseImpl.cpp:
1359         (WebKit::WebIndexedDatabaseImpl::open):
1360         * src/WebIndexedDatabaseImpl.h:
1361
1362 2010-05-08  Jens Alfke  <snej@chromium.org>
1363
1364         Reviewed by Darin Fisher.
1365
1366         [chromium] WebFrame::registerPasswordListener shouldn't assert on duplicate listener.
1367         https://bugs.webkit.org/show_bug.cgi?id=38765
1368
1369         * public/WebFrame.h:
1370         (WebKit::WebFrameImpl::registerPasswordListener): Changed return type to bool. Updated comment.
1371         * src/WebFrameImpl.cpp:
1372         (WebKit::WebFrameImpl::registerPasswordListener): Return false instead of asserting.
1373         * src/WebFrameImpl.h:
1374         (WebKit::WebFrameImpl::registerPasswordListener): Changed return type to bool.
1375
1376 2010-05-08  Michael Nordman  <michaeln@google.com>
1377
1378         Reviewed by Dmitry Titov.
1379
1380         Add an additional parameter to the WebSharedWorker::startWorkerContext method
1381         to indicate which appcache the shared worker script resource was loaded from,
1382         and provide that value when calling out to chrome via this interface.
1383         https://bugs.webkit.org/show_bug.cgi?id=38605
1384
1385         I'm keeping the old method around until patches can land in both repositories
1386         that make the old method obsolete and unneeded. There's a FIXME for that.
1387
1388         Also somewhat related but independent change to propagate the runtime enabled 
1389         flag thru to the page settings instance used by the 'shadow page'.
1390  
1391         * public/WebSharedWorker.h: Add the new param (but keep the old interface around for now too)
1392         (WebKit::WebSharedWorker::startWorkerContext):
1393         * src/SharedWorkerRepository.cpp: Provide the value when calling out to chrome.
1394         (WebCore::SharedWorkerScriptLoader::notifyFinished):
1395         * src/WebSharedWorkerImpl.cpp:
1396         (WebKit::WebSharedWorkerImpl::startWorkerContext):
1397         * src/WebSharedWorkerImpl.h:
1398         * src/WebWorkerBase.cpp: Propagate runtime enabled flag thru to the page settings.
1399         (WebKit::WebWorkerBase::initializeLoader):
1400
1401 2010-05-07  Darin Fisher  <darin@chromium.org>
1402
1403         Fix build bustage.  Update to Chromium code that avoids a bad
1404         dependency from net/ on chrome/.
1405
1406         * DEPS:
1407
1408 2010-05-07  Darin Fisher  <darin@chromium.org>
1409
1410         Fix build bustage.  Update to Chromium code that no longer uses
1411         deprecated methods.
1412
1413         * DEPS:
1414
1415 2010-05-07  Darin Fisher  <darin@chromium.org>
1416
1417         Reviewed by Dimitri Glazkov.
1418
1419         [chromium] clear out more deprecated methods that are no longer used
1420         https://bugs.webkit.org/show_bug.cgi?id=38702
1421
1422         * public/WebFrame.h:
1423         * public/WebNode.h:
1424         * src/WebFrameImpl.cpp:
1425         * src/WebFrameImpl.h:
1426         * src/WebNode.cpp:
1427
1428 2010-05-07  Finnur Thorarinsson  <finnur.webkit@gmail.com>
1429
1430         Reviewed by Dimitri Glazkov.
1431
1432         [chromium]: Fixing Find in page crash on sites.google.com
1433         https://bugs.webkit.org/show_bug.cgi?id=38591
1434         
1435         setMarkerActive should not try to set a collapsed marker as
1436         active. This can happen when you Edit a Sites page after doing
1437         a Find operation and then you press FindNext.
1438         
1439         * src/WebFrameImpl.cpp:
1440         (WebKit::WebFrameImpl::setMarkerActive):
1441
1442 2010-05-06  Kent Tamura  <tkent@chromium.org>
1443
1444         Reviewed by Dimitri Glazkov.
1445
1446         [DRT/Chromium] Add support for resources on Mac
1447         https://bugs.webkit.org/show_bug.cgi?id=38637
1448
1449         * DEPS: Check out tools/data_pack.
1450
1451 2010-05-06  Pavel Feldman  <pfeldman@chromium.org>
1452
1453         Reviewed by Timothy Hatcher.
1454
1455         Chromium Dev Tools: Large toolbar icons flash when dev
1456         tools is opened in docked mode.
1457
1458         https://bugs.webkit.org/show_bug.cgi?id=38631
1459
1460         * src/js/DevTools.js:
1461         (devtools.domContentLoaded):
1462
1463 2010-05-06  Adam Barth  <abarth@webkit.org>
1464
1465         Reviewed by Eric Seidel.
1466
1467         drop support for sessionStorage in sandbox iframes
1468         https://bugs.webkit.org/show_bug.cgi?id=38151
1469
1470         Update client of sessionStorage to handle exceptions.
1471
1472         * src/StorageAreaProxy.cpp:
1473         (WebCore::StorageAreaProxy::storageEvent):
1474
1475 2010-05-05  Darin Fisher  <darin@chromium.org>
1476
1477         Reviewed by Dimitri Glazkov.
1478
1479         [chromium] clear out deprecated methods that are no longer used
1480         https://bugs.webkit.org/show_bug.cgi?id=38610
1481
1482         * public/WebFormElement.h:
1483         * public/WebInputElement.h:
1484         * public/WebKitClient.h:
1485         * public/WebView.h:
1486         * public/WebViewClient.h:
1487         (WebKit::WebViewClient::createPopupMenu):
1488         * src/ChromeClientImpl.cpp:
1489         (WebKit::ChromeClientImpl::popupOpened):
1490         * src/WebFormElement.cpp:
1491         * src/WebInputElement.cpp:
1492         (WebKit::WebInputElement::setSelectionRange):
1493         * src/WebViewImpl.cpp:
1494         (WebKit::WebViewImpl::hideSuggestionsPopup):
1495         * src/WebViewImpl.h:
1496
1497 2010-05-05  Hans Wennborg  <hans@chromium.org>
1498
1499         Reviewed by Jeremy Orlow.
1500
1501         [chromium] Add quota parameter to  WebStorageNamespace::createSessionStorageNamespace
1502         https://bugs.webkit.org/show_bug.cgi?id=38589
1503
1504         * public/WebStorageNamespace.h:
1505         (WebKit::WebStorageNamespace::createSessionStorageNamespace):
1506         * src/WebStorageNamespaceImpl.cpp:
1507         (WebKit::WebStorageNamespace::createSessionStorageNamespace):
1508
1509 2010-05-05  Stuart Morgan  <stuartmorgan@chromium.org>
1510
1511         Reviewed by Darin Fisher.
1512
1513         Update the plugin container's setFocus implementation to pass the new
1514         boolean argument to the next layer.
1515
1516         https://bugs.webkit.org/show_bug.cgi?id=37961
1517
1518         * src/WebPluginContainerImpl.cpp:
1519         (WebKit::WebPluginContainerImpl::setFocus):
1520         * src/WebPluginContainerImpl.h:
1521
1522 2010-05-04  Vangelis Kokkevis  <vangelis@chromium.org>
1523
1524         Reviewed by Darin Fisher.
1525
1526         Provide an API for querying whether a WebWidget is using gpu accelerated compositing.
1527         Also changed: isAcceleratedCompositing to: isAcceleratedCompositingActive.
1528         https://bugs.webkit.org/show_bug.cgi?id=38220
1529
1530         * public/WebWidget.h:
1531         * src/WebPopupMenuImpl.h:
1532         (WebKit::WebPopupMenuImpl::isAcceleratedCompositingActive):
1533         * src/WebViewImpl.cpp:
1534         (WebKit::WebViewImpl::WebViewImpl):
1535         (WebKit::WebViewImpl::paint):
1536         (WebKit::WebViewImpl::isAcceleratedCompositingActive):
1537         (WebKit::WebViewImpl::setRootGraphicsLayer):
1538         (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
1539         (WebKit::WebViewImpl::updateRootLayerContents):
1540         * src/WebViewImpl.h:
1541
1542 2010-04-29  John Gregg  <johnnyg@google.com>
1543
1544         Reviewed by Dmitry Titov.
1545
1546         notifications should have dir and replaceId attributes
1547         https://bugs.webkit.org/show_bug.cgi?id=38336
1548
1549         * public/WebNotification.h:
1550         * src/WebNotification.cpp:
1551         (WebKit::WebNotification::dir):
1552         (WebKit::WebNotification::replaceId):
1553
1554 2010-05-04  Jay Civelli  <jcivelli@chromium.org>
1555
1556         Reviewed by David Levin.
1557
1558         [chromium] Make the select popup not close on right/middle clicks.
1559         https://bugs.webkit.org/show_bug.cgi?id=38473
1560
1561         * src/WebViewImpl.cpp:
1562         (WebKit::WebViewImpl::mouseDown):
1563
1564 2010-05-03  Abhishek Arya  <inferno@chromium.org>
1565
1566         Reviewed by Adam Barth.
1567
1568         Add support for controlling clipboard access from javascript.
1569         Clipboard access from javascript is disabled by default.
1570         https://bugs.webkit.org/show_bug.cgi?id=27751
1571
1572         * public/WebSettings.h:
1573         * src/WebSettingsImpl.cpp:
1574         (WebKit::WebSettingsImpl::setJavaScriptCanAccessClipboard):
1575         * src/WebSettingsImpl.h:
1576
1577 2010-05-03  Jens Alfke  <snej@chromium.org>
1578
1579         Reviewed by Darin Fisher.
1580
1581         [chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
1582         https://bugs.webkit.org/show_bug.cgi?id=38397
1583
1584         No tests (functionality is exposed only through native WebKit API.)
1585
1586         * public/WebFrameClient.h:
1587         (WebKit::WebFrameClient::willSendSubmitEvent): New empty method
1588         * src/FrameLoaderClientImpl.cpp:
1589         (WebKit::FrameLoaderClientImpl::dispatchWillSendSubmitEvent): Delegate to client
1590         * src/FrameLoaderClientImpl.h:
1591
1592 2010-05-02  Michael Nordman  <michaeln@google.com>
1593
1594         Reviewed by Dmitry Titov.
1595
1596         Define two new ResourceRequestBase TargetTypes for worker and shared worker
1597         main resources. Use the new target types where appropiate. Add logic to marshal
1598         the target type specified by requests initiated on a background worker thread.
1599
1600         https://bugs.webkit.org/show_bug.cgi?id=38295
1601
1602         * src/SharedWorkerRepository.cpp:  use TargetIsSharedWorker
1603         (WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader):
1604
1605 2010-05-02  Rafael Weinstein  <rafaelw@chromium.org>
1606
1607         Reviewed by Darin Fisher.
1608
1609         Include WebWindowFeatures in call to WebViewClient::createView.
1610         https://bugs.webkit.org/show_bug.cgi?id=38301
1611
1612         * public/WebViewClient.h:
1613         (WebKit::WebViewClient::createView):
1614         * public/WebWindowFeatures.h:
1615         * src/ChromeClientImpl.cpp:
1616         (WebKit::ChromeClientImpl::createWindow):
1617
1618 2010-05-01  Evan Stade  <estade@chromium.org>
1619
1620         Reviewed by David Levin
1621
1622         [chromium] Skia needs to fade DragImages
1623         https://bugs.webkit.org/show_bug.cgi?id=38008
1624
1625         * tests/DragImageTest.cpp:
1626         (DragImageTest.CreateDragImage): test that the drag image is a deep copy
1627
1628 2010-04-30  Jian Li  <jianli@chromium.org>
1629
1630         Reviewed by Darin Fisher.
1631
1632         [chromium] Add WebFileSystem interface and hook up with all FileSystem methods.
1633         https://bugs.webkit.org/show_bug.cgi?id=38228
1634
1635         * WebKit.gyp:
1636         * public/WebFileSystem.h: Added.
1637         * public/WebKitClient.h:
1638         (WebKit::WebKitClient::fileSystem):
1639         * src/ChromiumBridge.cpp:
1640         (WebCore::ChromiumBridge::fileExists):
1641         (WebCore::ChromiumBridge::deleteFile):
1642         (WebCore::ChromiumBridge::deleteEmptyDirectory):
1643         (WebCore::ChromiumBridge::getFileSize):
1644         (WebCore::ChromiumBridge::getFileModificationTime):
1645         (WebCore::ChromiumBridge::directoryName):
1646         (WebCore::ChromiumBridge::pathByAppendingComponent):
1647         (WebCore::ChromiumBridge::makeAllDirectories):
1648         (WebCore::ChromiumBridge::getAbsolutePath):
1649         (WebCore::ChromiumBridge::isDirectory):
1650         (WebCore::ChromiumBridge::filePathToURL):
1651         (WebCore::ChromiumBridge::openFile):
1652         (WebCore::ChromiumBridge::closeFile):
1653         (WebCore::ChromiumBridge::seekFile):
1654         (WebCore::ChromiumBridge::truncateFile):
1655         (WebCore::ChromiumBridge::readFromFile):
1656         (WebCore::ChromiumBridge::writeToFile):
1657
1658 2010-04-29  Jeremy Orlow  <jorlow@chromium.org>
1659
1660         Reviewed by Darin Fisher.
1661
1662         Change StorageEvent.uri to StorageEvent.url to match the spec
1663         https://bugs.webkit.org/show_bug.cgi?id=38331
1664
1665         Get rid of a stale FIXME and combine 2 lines that needn't be split.
1666
1667         * src/StorageEventDispatcherImpl.cpp:
1668         (WebCore::StorageEventDispatcherImpl::dispatchStorageEvent):
1669
1670 2010-04-29  Anton Muhin  <antonm@chromium.org>
1671
1672         Reviewed by Darin Fisher.
1673
1674         [Chromium] Consider implementing addOriginAccessWhitelistEntry method
1675         http://trac.webkit.org/changeset/57537 introduced a new method
1676         to manage whitelisting of origins.
1677         Expose this method in Chromium's bridge.
1678         https://bugs.webkit.org/show_bug.cgi?id=37578
1679
1680         * public/WebSecurityPolicy.h: Start renaming (keep old function names) and add new removeOriginAccessWhitelistEntry method
1681         * src/WebSecurityPolicy.cpp: Start renaming (keep old function names) and add new removeOriginAccessWhitelistEntry method
1682
1683 2010-04-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1684
1685         Unreviewed, rolling out r58498.
1686         http://trac.webkit.org/changeset/58498
1687         https://bugs.webkit.org/show_bug.cgi?id=38332
1688
1689         "Broke a bunch of tests on Chromium canaries" (Requested by
1690         dglazkov on #webkit).
1691
1692         * public/WebViewClient.h:
1693         (WebKit::WebViewClient::createView):
1694         * public/WebWindowFeatures.h:
1695         * src/ChromeClientImpl.cpp:
1696         (WebKit::ChromeClientImpl::createWindow):
1697
1698 2010-04-29  Adam Langley  <agl@chromium.org>
1699
1700         Unreviewed, DEPS roll.
1701
1702         WebKit's r58517 needs OTS's r30 which was rolled into Chromium in
1703         r45932.
1704
1705         * DEPS:
1706           Use Chromium r45932.
1707
1708 2010-04-29  Rafael Weinstein  <rafaelw@chromium.org>
1709
1710         Reviewed by Darin Fisher.
1711
1712         Include WindowFeatures in call to WebViewClient::createView.
1713
1714         https://bugs.webkit.org/show_bug.cgi?id=38301
1715
1716         * public/WebViewClient.h:
1717         (WebKit::WebViewClient::createView):
1718         * public/WebWindowFeatures.h:
1719         * src/ChromeClientImpl.cpp:
1720         (WebKit::ChromeClientImpl::createWindow):
1721
1722 2010-04-29  Garret Kelly  <gdk@chromium.org>
1723
1724         Reviewed by Darin Fisher.
1725
1726         Expose the RuntimeFeature for touch events through the
1727         WebRuntimeFeatures mechanism.
1728         https://bugs.webkit.org/show_bug.cgi?id=37486
1729
1730         * public/WebRuntimeFeatures.h:
1731         * src/WebRuntimeFeatures.cpp:
1732         (WebKit::WebRuntimeFeatures::enableTouch):
1733         (WebKit::WebRuntimeFeatures::isTouchEnabled):
1734
1735 2010-04-29  Zhenyao Mo  <zmo@google.com>
1736
1737         Reviewed by Dimitri Glazkov.
1738
1739         Remove the unnecessary texImage2D function with Image as input in GraphicsContext3D
1740         https://bugs.webkit.org/show_bug.cgi?id=38235
1741
1742         * src/GraphicsContext3D.cpp: Remove tex*image implementation with Image input.
1743
1744 2010-04-28  Pavel Feldman  <pfeldman@chromium.org>
1745
1746         Reviewed by Yury Semikhatsky.
1747
1748         Web Inspector: Allow editing script resources when resource tracking is enabled.
1749
1750         http://bugs.webkit.org/show_bug.cgi?id=38269
1751  
1752         * src/js/DebuggerAgent.js:
1753         * src/js/InspectorControllerImpl.js:
1754         (.devtools.InspectorBackendImpl.prototype.setBreakpoint):
1755         (.devtools.InspectorBackendImpl.prototype.editScriptSource):
1756
1757 2010-04-28  Darin Fisher  <darin@chromium.org>
1758
1759         Reviewed by David Levin.
1760
1761         [Chromium] callOnMainThread should equate to MessageLoop::PostTask
1762         https://bugs.webkit.org/show_bug.cgi?id=38276
1763
1764         * public/WebKitClient.h:
1765         (WebKit::WebKitClient::callOnMainThread):
1766         * src/ChromiumThreading.cpp:
1767         (WTF::ChromiumThreading::callOnMainThread):
1768
1769 2010-04-27  John Abd-El-Malek  <jam@chromium.org>
1770
1771         Reviewed by Darin Fisher.
1772
1773         Make WebThemeEngine::paint take a const ref of ExtraParams
1774         https://bugs.webkit.org/show_bug.cgi?id=38242
1775
1776         * public/WebThemeEngine.h:
1777         (WebKit::WebThemeEngine::paint):
1778
1779 2010-04-28  Andrey Kosyakov  <caseq@chromium.org>
1780
1781         Reviewed by Pavel Feldman.
1782
1783         Fixed passing breakpoints to V8. 
1784         https://bugs.webkit.org/show_bug.cgi?id=38266
1785
1786         * src/js/InspectorControllerImpl.js:
1787         (.devtools.InspectorBackendImpl.prototype.setBreakpoint):
1788
1789 2010-04-28  Yury Semikhatsky  <yurys@chromium.org>
1790
1791         Reviewed by Pavel Feldman.
1792
1793         Support pause on exceptions in v8 implementation of ScriptDebugServer.
1794
1795         https://bugs.webkit.org/show_bug.cgi?id=38205        
1796
1797         * src/js/DebuggerScript.js:
1798         (debuggerScriptConstructor.DebuggerScript.getScripts):
1799         (debuggerScriptConstructor.DebuggerScript.pauseOnExceptionsState):
1800         (debuggerScriptConstructor.DebuggerScript.setPauseOnExceptionsState):
1801         (debuggerScriptConstructor.DebuggerScript._v8ToWebkitLineNumber):
1802         (debuggerScriptConstructor):
1803
1804 2010-04-27  Jens Alfke  <snej@chromium.org>
1805
1806         Reviewed by Eric Seidel.
1807
1808         [chromium] Fix bug that prevents autosave of forms without action attribute
1809         https://bugs.webkit.org/show_bug.cgi?id=38014
1810         Change is in the Chromium WebKit API so it can't be tested with a JS-based layout test.
1811         It needs a native unit test, which would go in the Chromium repo, not WebKit.
1812
1813         * src/WebPasswordFormData.cpp:
1814         (WebKit::WebPasswordFormData::WebPasswordFormData): Set correct URL if action is NULL
1815
1816 2010-04-27  Michael Nordman  <michaeln@google.com>
1817
1818         Reviewed by Dmitry Titov.
1819
1820         [Chromium] Add two things to the webkit API to support appcaches in workers.
1821         1) WebURLRequest TargetTypes for worker and shared worker main resources.
1822         2) Factory method on class WebCommonWorkerClient to
1823            createApplicationCacheHost() for the associated worker.
1824
1825         https://bugs.webkit.org/show_bug.cgi?id=38147
1826
1827         * public/WebCommonWorkerClient.h: add the factory method
1828         * public/WebURLRequest.h: add the TargetTypes
1829         * src/WebWorkerBase.cpp: call the embedder's factory when needed
1830         (WebKit::WebWorkerBase::didCreateDataSource)
1831         (WebKit::WebWorkerBase::createApplicationCacheHost)
1832         * src/WebWorkerBase.h: ditto
1833         * src/WebWorkerClientImpl.h: add a stub impl of the factory method 
1834         (WebKit::WebWorkerClientImpl::createApplicationCacheHost):
1835
1836 2010-04-27  Kent Tamura  <tkent@chromium.org>
1837
1838         Reviewed by Shinichiro Hamaji.
1839
1840         [DRT/Chromium] Enable Windows project generation
1841         https://bugs.webkit.org/show_bug.cgi?id=38103
1842
1843         - Avoid platform.system(), which causes a crash with python.exe in
1844           depot_tools. Use sys.platform instead.
1845         - Process DumpRenderTree.gyp on all platforms.
1846
1847         * gyp_webkit:
1848
1849 2010-04-27  Jay Civelli  <jcivelli@chromium.org>
1850
1851         Reviewed by Darin Fisher.
1852
1853         Makes clicking a select element close its associated popup if
1854         it is open.
1855         https://bugs.webkit.org/show_bug.cgi?id=38105
1856
1857         * src/WebViewImpl.cpp:
1858         (WebKit::WebViewImpl::mouseDown):
1859
1860 2010-04-27  Jay Civelli  <jcivelli@chromium.org>
1861
1862         Reviewed by Darin Fisher.
1863
1864         [chromium] Merged the WebView public method to close suggestion popups
1865         into a single method to close all popups (select and suggestions).
1866         That ensures select popups are closed when the browser window is moved
1867         or resized.
1868         https://bugs.webkit.org/show_bug.cgi?id=37837
1869
1870         * public/WebView.h:
1871         * src/WebViewImpl.cpp:
1872         (WebKit::WebViewImpl::hidePopups):
1873         (WebKit::WebViewImpl::hideSuggestionsPopup):
1874         * src/WebViewImpl.h:
1875
1876 2010-04-27  John Abd-El-Malek  <jam@chromium.org>
1877
1878         Reviewed by Darin Adler.
1879
1880         Remove unnecessary header now that Chrome is updated
1881         https://bugs.webkit.org/show_bug.cgi?id=38211
1882
1883         * public/win/WebThemeEngine.h: Removed.
1884
1885 2010-04-27  Jens Alfke  <snej@chromium.org>
1886
1887         Reviewed by Darin Fisher.
1888
1889         [Chromium] Add some notifications and an accessor to WebKit API
1890         https://bugs.webkit.org/show_bug.cgi?id=37625
1891
1892         * public/WebFrameClient.h:
1893         (WebKit::WebFrameClient::didFirstLayout):
1894         (WebKit::WebFrameClient::didFirstVisuallyNonEmptyLayout):
1895         * public/WebNode.h:
1896         * src/FrameLoaderClientImpl.cpp:
1897         (WebKit::FrameLoaderClientImpl::dispatchDidFirstLayout):
1898         (WebKit::FrameLoaderClientImpl::dispatchDidFirstVisuallyNonEmptyLayout):
1899         * src/WebElement.cpp:
1900         * src/WebNode.cpp:
1901         (WebKit::WebNode::hasNonEmptyBoundingBox):
1902
1903 2010-04-27  Darin Fisher  <darin@chromium.org>
1904
1905         Reviewed by Dimitri Glazkov.
1906
1907         [Chromium] Remove deprecated form of didChangeLocationWithinPage
1908         https://bugs.webkit.org/show_bug.cgi?id=38178
1909
1910         * public/WebFrameClient.h:
1911         * src/FrameLoaderClientImpl.cpp:
1912         (WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):
1913
1914 2010-04-27  Evan Martin  <evan@chromium.org>
1915
1916         Reviewed by David Levin.
1917
1918         [chromium] bold bengali text not rendered properly on Linux
1919         Roll forward Chrome DEPS so we get new Skia API.
1920
1921         * DEPS: update Chrome to r45696.
1922
1923 2010-04-27  Andrey Kosyakov  <caseq@chromium.org>
1924
1925         Reviewed by Pavel Feldman.
1926
1927         Restore breakpoints associated with script's URL once
1928         script is parsed.
1929         https://bugs.webkit.org/show_bug.cgi?id=38132
1930
1931         * src/js/DebuggerAgent.js:
1932         (devtools.DebuggerAgent.prototype.initUI):
1933         (devtools.DebuggerAgent.prototype.addBreakpoint):
1934         (devtools.DebuggerAgent.prototype.addScriptInfo_):
1935         (devtools.DebuggerAgent.prototype.restoreBreakpoints_):
1936         (devtools.BreakpointInfo):
1937         (devtools.BreakpointInfo.prototype.enabled):
1938         (devtools.BreakpointInfo.prototype.condition):
1939
1940 2010-04-27  Pavel Feldman  <pfeldman@chromium.org>
1941
1942         Reviewed by Yury Semikhatsky.
1943
1944         Chrome Dev Tools: Further beautify themes.
1945
1946         https://bugs.webkit.org/show_bug.cgi?id=38187
1947
1948         * src/js/DevTools.js:
1949         (WebInspector.setToolbarColors):
1950         * src/js/devTools.css:
1951         (body.platform-windows #toolbar, body.platform-windows.inactive #toolbar):
1952
1953 2010-04-26  John Abd-El-Malek  <jam@chromium.org>
1954
1955         Reviewed by Darin Fisher.
1956
1957         [chromium] Prepare to making WebThemeEngine cross-platform
1958         https://bugs.webkit.org/show_bug.cgi?id=38077
1959
1960         * WebKit.gyp:
1961         * public/WebThemeEngine.h: Added.
1962         * public/win/WebThemeEngine.h:
1963
1964 2010-04-26  Darin Fisher  <darin@chromium.org>
1965
1966         Reviewed by Adam Barth.
1967
1968         [Chromium] Crash after calling window.print() on a window object that has been closed.
1969         https://bugs.webkit.org/show_bug.cgi?id=38148
1970
1971         It is unfortunately not possible to write a layout test for this as the
1972         crash occurs in an API that is only called by Chrome while showing a
1973         print dialog.
1974
1975         * src/WebViewImpl.cpp:
1976         (WebKit::WebView::willEnterModalLoop):
1977         (WebKit::WebView::didExitModalLoop):
1978
1979 2010-04-25  Sam Weinig  <sam@webkit.org>
1980
1981         Reviewed by Maciej Stachowiak.
1982
1983         Fix for https://bugs.webkit.org/show_bug.cgi?id=38097
1984         Disentangle initializing the main thread from initializing threading
1985
1986         * src/WebKit.cpp:
1987         (WebKit::initialize): Add call to initializeMainThread.
1988         * src/WebViewImpl.cpp:
1989         (WebKit::WebViewImpl::WebViewImpl): Ditto.
1990
1991 2010-04-26  Roman Gershman  <romange@google.com>
1992
1993         Reviewed by Adam Barth.
1994
1995         [Chromium] Font size in suggestions popup menu should be correlated with the font size of its text field.
1996
1997         https://bugs.webkit.org/show_bug.cgi?id=37977
1998
1999         * src/SuggestionsPopupMenuClient.cpp:
2000         (WebKit::SuggestionsPopupMenuClient::initialize):
2001
2002 2010-04-26  Pavel Feldman  <pfeldman@chromium.org>
2003
2004         Reviewed by Yury Semikhatsky.
2005
2006         Chromium Dev Tools: brush up images.
2007
2008         https://bugs.webkit.org/show_bug.cgi?id=38124
2009
2010         * WebKit.gypi:
2011         * src/js/DevTools.js:
2012         (WebInspector.setToolbarColors):
2013         * src/js/Images/segmentChromium.png:
2014         * src/js/Images/segmentChromium2.png: Removed.
2015         * src/js/Images/segmentHoverChromium2.png: Removed.
2016         * src/js/Images/segmentSelectedChromium2.png: Removed.
2017         * src/js/Images/statusbarBackgroundChromium.png:
2018         * src/js/Images/statusbarBackgroundChromium2.png: Removed.
2019         * src/js/Images/statusbarBottomBackgroundChromium.png:
2020         * src/js/Images/statusbarButtonsChromium.png:
2021         * src/js/Images/statusbarMenuButtonChromium.png:
2022         * src/js/Images/statusbarMenuButtonChromium2.png: Removed.
2023         * src/js/devTools.css:
2024         (.section > .header):
2025         (.console-group-messages .section > .header):
2026         (#resources-filter):
2027         (.crumbs .crumb):
2028         (.crumbs .crumb.end):
2029         (.crumbs .crumb.selected):
2030         (.crumbs .crumb.selected:hover):
2031         (.crumbs .crumb.selected.end, .crumbs .crumb.selected.end:hover):
2032         (.crumbs .crumb:hover):
2033         (.crumbs .crumb.dimmed:hover):
2034         (.crumbs .crumb.end:hover):
2035         (body.drawer-visible #main-status-bar):
2036         (.status-bar):
2037         (button.status-bar-item):
2038         (select.status-bar-item:active):
2039         (#drawer):
2040         (select.status-bar-item):
2041
2042 2010-04-23  Zhenyao Mo  <zmo@google.com>
2043
2044         Reviewed by Darin Fisher.
2045
2046         Add isGLES2Compliant to GraphicsContext3D: make the method const.
2047         https://bugs.webkit.org/show_bug.cgi?id=37872
2048
2049         * src/GraphicsContext3D.cpp: Make isGLES2Compliant() const.
2050         (WebCore::GraphicsContext3DInternal::isGLES2Compliant):
2051         (WebCore::GraphicsContext3D::isGLES2Compliant):
2052
2053 2010-04-23  Rafael Weinstein  <rafaelw@grafaelw.sfo.corp.google.com>
2054
2055         Reviewed by Darin Fisher.
2056
2057         This patch adds a WebWindowFeatures binding struct for the
2058         chromium client in anticipation of a follow-on patch which will
2059         pass it to WebViewClient::createWindow.
2060
2061         https://bugs.webkit.org/show_bug.cgi?id=38013
2062
2063         * public/WebViewClient.h:
2064         (WebKit::WebViewClient::createView):
2065         * public/WebWindowFeatures.h: Added.
2066         (WebKit::WebWindowFeatures::WebWindowFeatures):
2067         * src/ChromeClientImpl.cpp:
2068         (WebKit::ChromeClientImpl::createWindow):
2069
2070 2010-04-22  Zhenyao Mo  <zmo@google.com>
2071
2072         Reviewed by Darin Fisher.
2073
2074         Add isGLES2Compliant to GraphicsContext3D
2075         https://bugs.webkit.org/show_bug.cgi?id=37872
2076
2077         * public/WebGraphicsContext3D.h: Add isGLES2Compliant().
2078         * src/GraphicsContext3D.cpp: Ditto.
2079         * src/WebGraphicsContext3DDefaultImpl.cpp: Ditto.
2080         (WebKit::WebGraphicsContext3DDefaultImpl::isGLES2Compliant):
2081         * src/WebGraphicsContext3DDefaultImpl.h: Ditto.
2082
2083 2010-04-22  Dave Moore  <davemoore@chromium.org>
2084
2085         Reviewed by Dimitri Glazkov.
2086
2087         Added notification when the favicons for a page are changed
2088         from a script.
2089         The Document object will notify the frame loader, which will
2090         notify the client. Implementations of FrameLoaderClient will
2091         have to add one method; dispatchDidChangeIcons().
2092
2093         https://bugs.webkit.org/show_bug.cgi?id=33812
2094
2095         * public/WebFrameClient.h:
2096         (WebKit::WebFrameClient::didChangeIcons):
2097         * src/FrameLoaderClientImpl.cpp:
2098         (WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
2099         * src/FrameLoaderClientImpl.h:
2100
2101 2010-04-22  Zhenyao Mo  <zmo@google.com>
2102
2103         Reviewed by Dimitri Glazkov.
2104
2105         Emulate GL_IMPLEMENTATION_COLOR_READ_FORMAT/TYPE for glGet
2106         https://bugs.webkit.org/show_bug.cgi?id=37281
2107
2108         * src/WebGraphicsContext3DDefaultImpl.cpp:
2109         (WebKit::WebGraphicsContext3DDefaultImpl::getIntegerv): Emulate two  enums.
2110
2111 2010-04-22  Adam Barth  <abarth@webkit.org>
2112
2113         Unreviewed, rolling out r58069.
2114         http://trac.webkit.org/changeset/58069
2115         https://bugs.webkit.org/show_bug.cgi?id=27751
2116
2117         Broke compile on Windows.
2118
2119         * public/WebSettings.h:
2120         * src/WebSettingsImpl.cpp:
2121         * src/WebSettingsImpl.h:
2122
2123 2010-04-22  Tony Chang  <tony@chromium.org>
2124
2125         Reviewed by Shinichiro Hamaji.
2126
2127         [chromium] roll chromium deps to pick up some windows build fixes
2128         https://bugs.webkit.org/show_bug.cgi?id=37972
2129
2130         * DEPS:
2131
2132 2010-04-22  Abhishek Arya  <inferno@chromium.org>
2133
2134         Reviewed by Adam Barth.
2135
2136         Add support for controlling clipboard access from javascript.
2137         Clipboard access from javascript is disabled by default.
2138         https://bugs.webkit.org/show_bug.cgi?id=27751
2139
2140         * public/WebSettings.h:
2141         * src/WebSettingsImpl.cpp:
2142         (WebKit::WebSettingsImpl::setJavaScriptCanAccessClipboard):
2143         * src/WebSettingsImpl.h:
2144
2145 2010-04-21  Tony Chang  <tony@chromium.org>
2146
2147         Reviewed by Shinichiro Hamaji.
2148
2149         [chromium] gyp_webkit should be executable
2150         https://bugs.webkit.org/show_bug.cgi?id=37971
2151
2152         * gyp_webkit: Added property svn:executable.
2153
2154 2010-04-21  Jay Civelli  <jcivelli@chromium.org>
2155
2156         Reviewed by Darin Fisher.
2157
2158         [Chromium] Don't notify the WebView that a popup was
2159         opened when the popup is handled externally, as the popup
2160         is in that case transparent to the WebView.
2161         The notification was causing an ASSERT on Mac (where
2162         the popup is handled externally) as there would be no
2163         notification that the popup was closed.
2164         https://bugs.webkit.org/show_bug.cgi?id=37825
2165
2166         * src/ChromeClientImpl.cpp:
2167         (WebKit::ChromeClientImpl::popupOpened):
2168
2169 2010-04-21  Sheriff Bot  <webkit.review.bot@gmail.com>
2170
2171         Unreviewed, rolling out r58028.
2172         http://trac.webkit.org/changeset/58028
2173         https://bugs.webkit.org/show_bug.cgi?id=37962
2174
2175         broke the chromium build (Requested by tony^work on #webkit).
2176
2177         * DEPS:
2178
2179 2010-04-21  Evan Martin  <evan@chromium.org>
2180
2181         Unreviewed, just a dependency change.
2182
2183         [chromium] roll skia forward to r538
2184         https://bugs.webkit.org/show_bug.cgi?id=37960
2185
2186         This will cause a bunch of pixel tests to fail due to bulleted
2187         lists rendering slightly differently.  I will grab new baselines
2188         from the bots and check them in in a followup.
2189
2190         * DEPS:
2191
2192 2010-04-21  Evan Stade  <estade@chromium.org>
2193
2194         Reviewed by Darin Fisher.
2195
2196         [chromium] Web page serializer saves tag names in upper case
2197         https://bugs.webkit.org/show_bug.cgi?id=37940
2198
2199         Simply convert all tags to lower case.
2200
2201         This is tested by chrome tests:
2202          - save page browser tests
2203          - encoding ui tests
2204          - web page serializer test shell tests
2205
2206         * src/WebPageSerializer.cpp:
2207         (WebKit::WebPageSerializer::generateMetaCharsetDeclaration):
2208         (WebKit::WebPageSerializer::generateBaseTagDeclaration):
2209         * src/WebPageSerializerImpl.cpp:
2210         (WebKit::WebPageSerializerImpl::openTagToString):
2211         (WebKit::WebPageSerializerImpl::endTagToString):
2212
2213 2010-04-20  Adam Barth  <abarth@webkit.org>
2214
2215         Reviewed by Eric Seidel.
2216
2217         Factor DocumentWriter out of FrameLoader
2218         https://bugs.webkit.org/show_bug.cgi?id=37175
2219
2220         Update these callsites because the method moved to DocumentWriter.
2221
2222         * src/ContextMenuClientImpl.cpp:
2223         (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
2224         * src/FrameLoaderClientImpl.cpp:
2225         (WebKit::FrameLoaderClientImpl::finishedLoading):
2226         * src/WebFrameImpl.cpp:
2227         (WebKit::WebFrameImpl::encoding):
2228         (WebKit::WebFrameImpl::commitDocumentData):
2229         * src/WebPageSerializerImpl.cpp:
2230         (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag):
2231         (WebKit::WebPageSerializerImpl::serialize):
2232         * src/WebSearchableFormData.cpp:
2233         (WebCore::GetFormEncoding):
2234         * src/WebViewImpl.cpp:
2235         (WebKit::WebViewImpl::pageEncoding):
2236
2237 2010-04-20  Pavel Feldman  <pfeldman@chromium.org>
2238
2239         Reviewed by Timothy Hatcher.
2240
2241         Web Inspector: add basic script editing capabilities to the front-end.
2242
2243         https://bugs.webkit.org/show_bug.cgi?id=37875
2244
2245         * src/js/DebuggerAgent.js:
2246         (devtools.DebuggerAgent.prototype.resolveScriptSource.this.requestSeqToCallback_.cmd.getSequenceNumber):
2247         (devtools.DebuggerAgent.prototype.resolveScriptSource):
2248         (devtools.DebuggerAgent.prototype.editScriptLine.this.requestSeqToCallback_.cmd.getSequenceNumber):
2249         (devtools.DebuggerAgent.prototype.editScriptLine):
2250         (devtools.DebuggerAgent.prototype.handleDebuggerOutput_):
2251         * src/js/DevTools.js:
2252         * src/js/InspectorControllerImpl.js:
2253         (.devtools.InspectorBackendImpl.prototype.editScriptLine):
2254
2255 2010-04-20  Kent Tamura  <tkent@chromium.org>
2256
2257         Reviewed by Darin Adler.
2258
2259         Change a parameter type of chooseIconForFiles()
2260         https://bugs.webkit.org/show_bug.cgi?id=37504
2261
2262         * src/ChromeClientImpl.cpp:
2263         (WebKit::ChromeClientImpl::chooseIconForFiles):
2264         * src/ChromeClientImpl.h:
2265
2266 2010-04-20  Jay Civelli  <jcivelli@chromium.org>
2267
2268         Reviewed by Dimitri Glazkov.
2269
2270         [chromium] Tests that pressing tab now closes the select popup.
2271         https://bugs.webkit.org/show_bug.cgi?id=37721
2272
2273         * tests/PopupMenuTest.cpp:
2274         (WebKit::TEST_F):
2275
2276 2010-04-20  Evan Stade  <estade@chromium.org>
2277
2278         Reviewed by David Levin.
2279
2280         [chromium] crash when dragging images
2281         https://bugs.webkit.org/show_bug.cgi?id=37715
2282
2283         Added unit tests for DragImageChromiumSkia.
2284
2285         * WebKit.gyp:
2286         * tests/DragImageTest.cpp: Added.
2287         (WebCore::TestImage::TestImage):
2288         (WebCore::TestImage::~TestImage):
2289         (WebCore::TestImage::size):
2290         (WebCore::TestImage::nativeImageForCurrentFrame):
2291         (WebCore::TestImage::destroyDecodedData):
2292         (WebCore::TestImage::decodedSize):
2293         (WebCore::TestImage::draw):
2294         (WebCore::TEST):
2295
2296 2010-04-20  Stuart Morgan  <stuartmorgan@chromium.org>
2297
2298         Reviewed by David Levin.
2299
2300         Remove a workaround in plugin cursor setting that was obsoleted by
2301         the change in https://bugs.webkit.org/show_bug.cgi?id=35132
2302         https://bugs.webkit.org/show_bug.cgi?id=37811
2303
2304         * src/ChromeClientImpl.cpp:
2305         (WebKit::ChromeClientImpl::ChromeClientImpl):
2306         (WebKit::ChromeClientImpl::setCursor):
2307         (WebKit::ChromeClientImpl::setCursorForPlugin):
2308         * src/ChromeClientImpl.h:
2309
2310 2010-04-19  Ada Chan  <adachan@apple.com>
2311
2312         Reviewed by Jeremy Orlow.
2313
2314         https://bugs.webkit.org/show_bug.cgi?id=37717
2315         Changes needed now that StorageNamespaceImpl::sessionStorageNamespace() and
2316         StorageNamespace::sessionStorageNamespace() take in a quota parameter.
2317
2318         * src/StorageNamespaceProxy.cpp:
2319         (WebCore::StorageNamespace::sessionStorageNamespace):
2320         * src/WebStorageNamespaceImpl.cpp:
2321         (WebKit::WebStorageNamespace::createSessionStorageNamespace):
2322
2323 2010-04-17  Vangelis Kokkevis  <vangelis@chromium.org>
2324
2325         Reviewed by Dimitri Glazkov.
2326
2327         Adding the implementation of GLES2Context class which provides WebCore access to a GL ES context.
2328         https://bugs.webkit.org/show_bug.cgi?id=37541
2329
2330         * WebKit.gyp:
2331         * public/WebGLES2Context.h: Added.
2332         (WebKit::WebGLES2Context::~WebGLES2Context):
2333         * src/GLES2Context.cpp: Added.
2334         (WebCore::GLES2ContextInternal::GLES2ContextInternal):
2335         (WebCore::GLES2ContextInternal::~GLES2ContextInternal):
2336         (WebCore::GLES2ContextInternal::getWebGLES2Context):
2337         (WebCore::GLES2ContextInternal::initialize):
2338         (WebCore::GLES2Context::create):
2339         (WebCore::GLES2Context::~GLES2Context):
2340         (WebCore::GLES2Context::initialize):
2341         (WebCore::GLES2Context::makeCurrent):
2342         (WebCore::GLES2Context::destroy):
2343         (WebCore::GLES2Context::swapBuffers):
2344
2345 2010-04-16  Dumitru Daniliuc  <dumi@chromium.org>
2346
2347         Reviewed by Eric Seidel.
2348
2349         Get rid of the UNUSED_PARAM macro in GraphicsContext3D.cpp.
2350         https://bugs.webkit.org/show_bug.cgi?id=37733
2351
2352         * src/GraphicsContext3D.cpp:
2353         (WebCore::GraphicsContext3D::GraphicsContext3D):
2354
2355 2010-04-16  Dumitru Daniliuc  <dumi@chromium.org>
2356
2357         Reviewed by Jeremy Orlow.
2358
2359         Changing the return type of WebSecurityOrigin::createFromDatabaseIdentifier().
2360         https://bugs.webkit.org/show_bug.cgi?id=34466
2361
2362         Changing the return type of
2363         WebSecurityOrigin::createFromDatabaseIdentifier() from
2364         WebSecurityOrigin* to WebSecurityOrigin, to make it more
2365         consistent with the other WebSecurityOrigin methods.
2366
2367         * public/WebSecurityOrigin.h:
2368         * src/WebDatabase.cpp:
2369         (WebKit::WebDatabase::closeDatabaseImmediately):
2370         * src/WebSecurityOrigin.cpp:
2371         (WebKit::WebSecurityOrigin::createFromDatabaseIdentifier):
2372
2373 2010-04-16  Dmitry Titov  <dimich@chromium.org>
2374
2375         Reviewed by Yury Semikhatsky.
2376
2377         [v8] In Workers, script errors right after close() are not delivered to the Worker.onerror
2378         https://bugs.webkit.org/show_bug.cgi?id=37691
2379
2380         * src/WebWorkerClientImpl.cpp:
2381         (WebKit::WebWorkerClientImpl::createWorkerContextProxy): Don't need to pull V8 proxy to retrieve current WorkerContext.
2382
2383 2010-04-16  Albert J. Wong  <ajwong@chromium.org>
2384
2385         Not reviewed. Build fix.
2386
2387         [chromium] Compile fix. Missing include header, and missing type conversion.
2388
2389         * src/GraphicsContext3D.cpp:
2390         (WebCore::GraphicsContext3DInternal::beginPaint):
2391
2392 2010-04-16  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
2393  
2394         Reviewed by Simon Hausmann.
2395  
2396         [Qt] WebGL is not visible when QGLWidget viewport is used
2397         https://bugs.webkit.org/show_bug.cgi?id=37070
2398  
2399         Added HostWindow parameter to the constructor of GraphicsContext3D.
2400         Shared OpenGL context is initialized with parent QGLWidget.
2401  
2402         * src/GraphicsContext3D.cpp:
2403         (WebCore::GraphicsContext3D::GraphicsContext3D):
2404
2405 2010-04-16  Fumitoshi Ukai  <ukai@chromium.org>
2406
2407         Reviewed by Jian Li.
2408
2409         [chromium] WebKit::WebURLResponse::addHTTPHeaderField will crash if response is invalid UTF-8
2410         https://bugs.webkit.org/show_bug.cgi?id=37687
2411
2412         * src/WebURLResponse.cpp:
2413         (WebKit::WebURLResponse::addHTTPHeaderField): ignore if name or value is null string.
2414
2415 2010-04-16  Jay Civelli  <jcivelli@chromium.org>
2416
2417         Reviewed by Dimitri Glazkov.
2418
2419         [chromium] Select popups would assert when destroyed.
2420         Also adding unit-tests for the select popup code.
2421         https://bugs.webkit.org/show_bug.cgi?id=37436
2422
2423         * WebKit.gyp:
2424         * src/WebViewImpl.h:
2425         (WebKit::WebViewImpl::selectPopup):
2426         * tests/PopupMenuTest.cpp: Added.
2427
2428 2010-04-16  Tony Chang  <tony@chromium.org>
2429
2430         Reviewed by Dimitri Glazkov.
2431
2432         [chromium] build DRT on Linux
2433         https://bugs.webkit.org/show_bug.cgi?id=37690
2434
2435         * DEPS: Need to roll deps to remove a dependency on src/chrome
2436         * gyp_webkit: generate makefiles for DRT.gyp on Linux
2437
2438 2010-04-15  Tony Chang  <tony@chromium.org>
2439
2440         Reviewed by Dimitri Glazkov.
2441
2442         build DRT on chromium mac
2443         https://bugs.webkit.org/show_bug.cgi?id=37639
2444
2445         * gyp_webkit: generate build files for DRT on mac
2446
2447 2010-04-15  Yury Semikhatsky  <yurys@google.com>
2448
2449         Reviewed by Pavel Feldman.
2450
2451         Support basic debugging capabilities including step in/over/out in v8
2452         implementation of ScriptDebugServer.
2453
2454         https://bugs.webkit.org/show_bug.cgi?id=37604
2455
2456         * WebKit.gypi:
2457         * src/DebuggerAgent.h:
2458         * src/DebuggerAgentImpl.cpp:
2459         (WebKit::DebuggerAgentImpl::setDebuggerScriptSource):
2460         * src/DebuggerAgentImpl.h:
2461         * src/DebuggerAgentManager.cpp:
2462         (WebKit::DebuggerAgentManager::hostDispatchHandler):
2463         (WebKit::DebuggerAgentManager::debugAttach):
2464         (WebKit::DebuggerAgentManager::debugDetach):
2465         (WebKit::DebuggerAgentManager::setMessageLoopDispatchHandler):
2466         * src/DebuggerAgentManager.h:
2467         * src/InspectorFrontendClientImpl.cpp:
2468         (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
2469         * src/js/DebuggerScript.js: Added.
2470         (debuggerScriptConstructor.DebuggerScript.getAfterCompileScript):
2471         (debuggerScriptConstructor.DebuggerScript.getScripts):
2472         (debuggerScriptConstructor.DebuggerScript._formatScript):
2473         (debuggerScriptConstructor.DebuggerScript.setBreakpoint):
2474         (debuggerScriptConstructor.DebuggerScript.removeBreakpoint):
2475         (debuggerScriptConstructor.DebuggerScript.currentCallFrame):
2476         (debuggerScriptConstructor.DebuggerScript.stepIntoStatement):
2477         (debuggerScriptConstructor.DebuggerScript.stepOverStatement):
2478         (debuggerScriptConstructor.DebuggerScript.stepOutOfFunction):
2479         (debuggerScriptConstructor.DebuggerScript.clearBreakpoints):
2480         (debuggerScriptConstructor.DebuggerScript.setBreakpointsActivated):
2481         (debuggerScriptConstructor.DebuggerScript._frameMirrorToJSCallFrame):
2482         (debuggerScriptConstructor.DebuggerScript._webkitToV8LineNumber):
2483         (debuggerScriptConstructor.DebuggerScript._v8ToWwebkitLineNumber):
2484         (debuggerScriptConstructor):
2485         * src/js/DevTools.js:
2486         (WebInspector.loaded):
2487         (.):
2488         ():
2489         * src/js/DevToolsHostStub.js:
2490         (.RemoteDebuggerAgentStub.prototype.setDebuggerScriptSource):
2491         * src/js/InspectorControllerImpl.js:
2492         (devtools.InspectorBackendImpl):
2493
2494 2010-04-15  Matt Perry  <mpcomplete@chromium.org>
2495
2496         Reviewed by Dimitri Glazkov.
2497
2498         Implement layoutTestController's addUserStyleSheet and
2499         setAuthorAndUserStylesEnabled on Chromium port.
2500         https://bugs.webkit.org/show_bug.cgi?id=37595
2501
2502         * public/WebSettings.h:
2503         * public/WebView.h:
2504         * src/WebSettingsImpl.cpp:
2505         (WebKit::WebSettingsImpl::setAuthorAndUserStylesEnabled):
2506         * src/WebSettingsImpl.h:
2507         * src/WebViewImpl.cpp:
2508         (WebKit::WebViewImpl::addUserStyleSheet):
2509         * src/WebViewImpl.h:
2510
2511 2010-04-15  Zhenyao Mo  <zmo@google.com>
2512
2513         Reviewed by Dimitri Glazkov.
2514
2515         Must enable GL_VERTEX_PROGRAM_POINT_SIZE during initialization
2516         https://bugs.webkit.org/show_bug.cgi?id=37178
2517
2518         * src/WebGraphicsContext3DDefaultImpl.cpp: Enable GL_VERTEX_PROGRAM_POINT_SIZE during initialization.
2519         (WebKit::WebGraphicsContext3DDefaultImpl::initialize):
2520
2521 2010-04-15  Albert J. Wong  <ajwong@chromium.org>
2522
2523         Unreviewed, rolling out r57660.
2524         http://trac.webkit.org/changeset/57660
2525         https://bugs.webkit.org/show_bug.cgi?id=37604
2526
2527         Broke a large number of inspector layout tests in chromium.
2528
2529         * WebKit.gypi:
2530         * src/DebuggerAgent.h:
2531         * src/DebuggerAgentImpl.cpp:
2532         * src/DebuggerAgentImpl.h:
2533         * src/DebuggerAgentManager.cpp:
2534         (WebKit::DebuggerAgentManager::debugAttach):
2535         (WebKit::DebuggerAgentManager::debugDetach):
2536         (WebKit::DebuggerAgentManager::setMessageLoopDispatchHandler):
2537         * src/DebuggerAgentManager.h:
2538         * src/InspectorFrontendClientImpl.cpp:
2539         (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
2540         * src/js/DebuggerScript.js: Removed.
2541         * src/js/DevTools.js:
2542         (WebInspector.loaded):
2543         (WebInspector.UnresolvedPropertyValue):
2544         ():
2545         * src/js/DevToolsHostStub.js:
2546         * src/js/InspectorControllerImpl.js:
2547         (devtools.InspectorBackendImpl):
2548
2549 2010-04-15  Yury Semikhatsky  <yurys@google.com>
2550
2551         Reviewed by Pavel Feldman.
2552
2553         Support basic debugging capabilities including step in/over/out in v8
2554         implementation of ScriptDebugServer.
2555
2556         https://bugs.webkit.org/show_bug.cgi?id=37604
2557
2558         * WebKit.gypi:
2559         * src/DebuggerAgent.h:
2560         * src/DebuggerAgentImpl.cpp:
2561         (WebKit::DebuggerAgentImpl::setDebuggerScriptSource):
2562         * src/DebuggerAgentImpl.h:
2563         * src/DebuggerAgentManager.cpp:
2564         (WebKit::DebuggerAgentManager::hostDispatchHandler):
2565         (WebKit::DebuggerAgentManager::debugAttach):
2566         (WebKit::DebuggerAgentManager::debugDetach):
2567         (WebKit::DebuggerAgentManager::setMessageLoopDispatchHandler):
2568         * src/DebuggerAgentManager.h:
2569         * src/InspectorFrontendClientImpl.cpp:
2570         (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
2571         * src/js/DebuggerScript.js: Added.
2572         (debuggerScriptConstructor.DebuggerScript.getAfterCompileScript):
2573         (debuggerScriptConstructor.DebuggerScript.getScripts):
2574         (debuggerScriptConstructor.DebuggerScript._formatScript):
2575         (debuggerScriptConstructor.DebuggerScript.setBreakpoint):
2576         (debuggerScriptConstructor.DebuggerScript.removeBreakpoint):
2577         (debuggerScriptConstructor.DebuggerScript.currentCallFrame):
2578         (debuggerScriptConstructor.DebuggerScript.stepIntoStatement):
2579         (debuggerScriptConstructor.DebuggerScript.stepOverStatement):
2580         (debuggerScriptConstructor.DebuggerScript.stepOutOfFunction):
2581         (debuggerScriptConstructor.DebuggerScript.clearBreakpoints):
2582         (debuggerScriptConstructor.DebuggerScript.setBreakpointsActivated):
2583         (debuggerScriptConstructor.DebuggerScript._frameMirrorToJSCallFrame):
2584         (debuggerScriptConstructor.DebuggerScript._webkitToV8LineNumber):
2585         (debuggerScriptConstructor.DebuggerScript._v8ToWwebkitLineNumber):
2586         (debuggerScriptConstructor):
2587         * src/js/DevTools.js:
2588         (WebInspector.loaded):
2589         (.):
2590         ():
2591         * src/js/DevToolsHostStub.js:
2592         (.RemoteDebuggerAgentStub.prototype.setDebuggerScriptSource):
2593         * src/js/InspectorControllerImpl.js:
2594         (devtools.InspectorBackendImpl):
2595
2596 2010-04-15  Ben Murdoch  <benm@google.com>
2597
2598         Unreviewed, rolling out r57652.
2599         http://trac.webkit.org/changeset/57652
2600         https://bugs.webkit.org/show_bug.cgi?id=37609
2601
2602         Caused a build break on Chromium Mac and Layout Test fail on
2603         Qt
2604
2605         * src/WebInputEventConversion.cpp:
2606         (WebKit::toPlatformTouchPointState):
2607
2608 2010-04-14  Ben Murdoch  <benm@google.com>
2609
2610         Reviewed by Kenneth Rohde Christiansen.
2611
2612         The TouchStationary state of WebCore::PlatformTouchPoint is not
2613         handled inside the touch event handler.
2614         https://bugs.webkit.org/show_bug.cgi?id=37609
2615
2616         After discussions at the WebKit contributors meeting, we decided that
2617         this is a currently unused state without a good future use case in the
2618         Touch API and thus decided to remove it. This patch actions that decision.
2619
2620         * src/WebInputEventConversion.cpp:
2621         (WebKit::toPlatformTouchPointState): Remove TouchStationary.
2622
2623 2010-04-12  Tony Chang  <tony@chromium.org>
2624
2625         Reviewed by Darin Fisher.
2626
2627         [chromium] update chromium DEPS for upstream compile
2628         https://bugs.webkit.org/show_bug.cgi?id=36578
2629
2630         * DEPS: Pull sub deps from chromium's DEPS file
2631
2632 2010-04-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2633
2634         Unreviewed, rolling out r57599.
2635         http://trac.webkit.org/changeset/57599
2636         https://bugs.webkit.org/show_bug.cgi?id=37605
2637
2638         "Broke Chromium build" (Requested by dglazkov on #webkit).
2639
2640         * WebKit.gyp:
2641         * src/WebViewImpl.h:
2642         * tests/PopupMenuTest.cpp: Removed.
2643
2644 2010-04-14  Aaron Boodman  <aa@chromium.org>
2645
2646         Reviewed by David Levin.
2647
2648         Support relative URLs for notifications on Chromium. They weren't working previously because WebCore was inserting
2649         the relative URL into a KURL instance, but when KURL is backed by GURL as it is on Chromium, relative URLs are
2650         unsupported. Fixed by resolving the relative URL first.
2651
2652         https://bugs.webkit.org/show_bug.cgi?id=36623
2653
2654         Adding tests for this is difficult because we don't currently have DRT support for notifications on Mac, only Windows.
2655
2656         * public/WebNotification.h: Remove deprecated icon() method.
2657         * src/WebNotification.cpp: Ditto.
2658
2659 2010-04-14  Jay Civelli  <jcivelli@chromium.org>
2660
2661         Reviewed by Dimitri Glazkov.
2662
2663         [chromium] Select popups would assert when destroyed.
2664         Also adding unit-tests for the select popup code.
2665         https://bugs.webkit.org/show_bug.cgi?id=37436
2666
2667         * WebKit.gyp:
2668         * src/WebViewImpl.h:
2669         (WebKit::WebViewImpl::selectPopup):
2670         * tests/PopupMenuTest.cpp: Added.
2671
2672 2010-04-14  Zhenyao Mo  <zmo@google.com>
2673
2674         Reviewed by Dimitri Glazkov.
2675
2676         readPixels must take PACK_ALIGNMENT into account
2677         https://bugs.webkit.org/show_bug.cgi?id=34718
2678
2679         * src/GraphicsContext3D.cpp: Refactor readPixels.
2680         * src/WebGraphicsContext3DDefaultImpl.cpp:
2681         (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): Temporarily disable pack alignment for glReadPixels.
2682         (WebKit::WebGraphicsContext3DDefaultImpl::readPixels): Move array allocation and alpha fix to WebGLRenderingContext; flush before read pixels.
2683
2684 2010-04-14  Mikhail Naganov  <mnaganov@chromium.org>
2685
2686         Reviewed by Pavel Feldman.
2687
2688         Re-write testProfilerTab to match the new implementation.
2689
2690         https://bugs.webkit.org/show_bug.cgi?id=37516
2691
2692         * src/js/Tests.js:
2693         (.TestSuite.prototype.testProfilerTab.findDisplayedNode):
2694         (.TestSuite.prototype.testProfilerTab.findVisibleView):
2695         (.TestSuite.prototype.testProfilerTab):
2696
2697 2010-04-13  Timothy Hatcher  <timothy@apple.com>
2698
2699         Rename SecurityOrigin::whiteListAccessFromOrigin to addOriginAccessWhitelistEntry.
2700         And SecurityOrigin::resetOriginAccessWhiteLists to resetOriginAccessWhitelists.
2701
2702         SecurityOrigin needs a way to remove individual OriginAccessEntries
2703         https://bugs.webkit.org/show_bug.cgi?id=37449
2704
2705         Reviewed by Dave Hyatt.
2706
2707         * src/WebSecurityPolicy.cpp:
2708         (WebKit::WebSecurityPolicy::whiteListAccessFromOrigin):
2709         (WebKit::WebSecurityPolicy::resetOriginAccessWhiteLists):
2710
2711 2010-04-13  Mikhail Naganov  <mnaganov@chromium.org>
2712
2713         Reviewed by Pavel Feldman.
2714
2715         Fix search behavior in Heap profiles.
2716
2717         https://bugs.webkit.org/show_bug.cgi?id=37498
2718
2719         * src/js/HeapProfilerPanel.js:
2720
2721 2010-04-13  Jeremy Moskovich  <jeremy@chromium.org>
2722
2723         Reviewed by David Levin.
2724
2725         Add some diagnostics to try to track down cause of crash in ArchiveFactory::isArchiveMimeType().
2726
2727         https://bugs.webkit.org/show_bug.cgi?id=36426
2728
2729         * src/ResourceHandle.cpp: Track state across ResourceHandle invocations.
2730         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
2731         (WebCore::ResourceHandleInternal::):
2732         (WebCore::ResourceHandleInternal::start):
2733         (WebCore::ResourceHandleInternal::cancel):
2734         (WebCore::ResourceHandleInternal::didReceiveResponse):
2735         (WebCore::ResourceHandleInternal::didReceiveData):
2736         (WebCore::ResourceHandleInternal::didFinishLoading):
2737         (WebCore::ResourceHandleInternal::didFail):
2738
2739 2010-04-13  Mikhail Naganov  <mnaganov@chromium.org>
2740
2741         Unreviewed Chromium build fix: pin to a newer V8 revision (4386).
2742
2743         * DEPS:
2744
2745 2010-04-12  Mikhail Naganov  <mnaganov@chromium.org>
2746
2747         Reviewed by Yury Semikhatsky.
2748
2749         Replace hand-written JavaScriptProfile* bindings with idl-based, and
2750         in Chromium port, bind them to the new V8's profiler API that is
2751         aligned with JSC.
2752
2753         https://bugs.webkit.org/show_bug.cgi?id=37448
2754
2755         * src/js/InspectorControllerImpl.js:
2756         (devtools.InspectorBackendImpl):
2757         * src/js/ProfilerAgent.js:
2758         (devtools.ProfilerAgent):
2759         (devtools.ProfilerAgent.prototype.initializeProfiling):
2760         (devtools.ProfilerAgent.prototype._didGetActiveProfilerModules):
2761         (devtools.ProfilerAgent.prototype._didGetLogLines):
2762         * src/js/Tests.js:
2763
2764 2010-04-11  Sheriff Bot  <webkit.review.bot@gmail.com>
2765
2766         Unreviewed, rolling out r57468.
2767         http://trac.webkit.org/changeset/57468
2768         https://bugs.webkit.org/show_bug.cgi?id=37433
2769
2770         Broke the world...  Must have applied the patch wrong
2771         (Requested by abarth on #webkit).
2772
2773         * src/ContextMenuClientImpl.cpp:
2774         (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
2775         * src/FrameLoaderClientImpl.cpp:
2776         (WebKit::FrameLoaderClientImpl::finishedLoading):
2777         * src/WebFrameImpl.cpp:
2778         (WebKit::WebFrameImpl::encoding):
2779         (WebKit::WebFrameImpl::commitDocumentData):
2780         * src/WebPageSerializerImpl.cpp:
2781         (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag):
2782         (WebKit::WebPageSerializerImpl::serialize):
2783         * src/WebSearchableFormData.cpp:
2784         (WebCore::GetFormEncoding):
2785         * src/WebViewImpl.cpp:
2786         (WebKit::WebViewImpl::pageEncoding):
2787
2788 2010-04-11  Adam Barth  <abarth@webkit.org>
2789
2790         Reviewed by Eric Seidel.
2791
2792         Factor DocumentWriter out of FrameLoader
2793         https://bugs.webkit.org/show_bug.cgi?id=37175
2794
2795         Update these callsites because the method moved to DocumentWriter.
2796
2797         * src/ContextMenuClientImpl.cpp:
2798         (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
2799         * src/FrameLoaderClientImpl.cpp:
2800         (WebKit::FrameLoaderClientImpl::finishedLoading):
2801         * src/WebFrameImpl.cpp:
2802         (WebKit::WebFrameImpl::encoding):
2803         (WebKit::WebFrameImpl::commitDocumentData):
2804         * src/WebPageSerializerImpl.cpp:
2805         (WebKit::WebPageSerializerImpl::preActionBeforeSerializeOpenTag):
2806         (WebKit::WebPageSerializerImpl::serialize):
2807         * src/WebSearchableFormData.cpp:
2808         (WebCore::GetFormEncoding):
2809         * src/WebViewImpl.cpp:
2810         (WebKit::WebViewImpl::pageEncoding):
2811
2812 2010-04-11  Sheriff Bot  <webkit.review.bot@gmail.com>
2813
2814         Unreviewed, rolling out r57460.
2815         http://trac.webkit.org/changeset/57460
2816         https://bugs.webkit.org/show_bug.cgi?id=37424
2817
2818         broke chromium builders (Requested by tony^work on #webkit).
2819
2820         * DEPS:
2821         * gyp_webkit:
2822
2823 2010-04-11  Tony Chang  <tony@chromium.org>
2824
2825         Reviewed by Darin Fisher.
2826
2827         [chromium] update chromium DEPS for upstream compile
2828         https://bugs.webkit.org/show_bug.cgi?id=36578
2829
2830         * DEPS:
2831         * gyp_webkit: Add DumpRenderTree.gyp so we generate xcode projects for DRT.
2832
2833 2010-04-10  Vangelis Kokkevis  <vangelis@chromium.org>
2834
2835         Reviewed by Dimitri Glazkov.
2836
2837         Include file change as a result of renaming LayerRenderSkia.h to LayerRenderChromium.h
2838         https://bugs.webkit.org/show_bug.cgi?id=37231
2839
2840         * src/WebViewImpl.h:
2841
2842 2010-04-10  Rafael Weinstein  <rafaelw@chromium.org>
2843
2844         Reviewed by Eric Seidel.
2845
2846         Cleanup after chromium breakage. All interface methods are
2847         returned to being abstract.
2848
2849         * public/WebNotificationPresenter.h:
2850
2851 2010-04-09  Evan Stade  <estade@chromium.org>
2852
2853         Reviewed by Eric Seidel.
2854
2855         [chromium] Linux: respect the scale factor during printing
2856         https://bugs.webkit.org/show_bug.cgi?id=37168
2857
2858         Chromium doesn't support testing .pdfs from printing at the moment, so
2859         this change is not covered by any tests.
2860
2861         * src/WebFrameImpl.cpp:
2862         (WebKit::ChromePrintContext::spoolPage):
2863
2864 2010-04-09  Aaron Boodman  <aa@chromium.org>
2865
2866         Reviewed by Eric Seidel.
2867
2868         Remove applicationID() from WebDocument as it is Chromium-specific.
2869         https://bugs.webkit.org/show_bug.cgi?id=37350
2870
2871         * public/WebDocument.h:
2872         * src/WebDocument.cpp:
2873
2874 2010-04-09  Jeremy Orlow  <jorlow@chromium.org>
2875
2876         Reviewed by Darin Adler.
2877
2878         Move the IDB::open ExceptionCode paramter to be last
2879         https://bugs.webkit.org/show_bug.cgi?id=37277
2880
2881         Move the ExceptionCode paramter to the last position in 
2882         IndexedDatabaseRequest::open and friends.  It should definitely
2883         go after the callbacks to keep the parameters that come directly
2884         from javascript together.  And having output parameters appear
2885         last is done often in the code base, so it makes sense to push
2886         it past the Frame* param as well.
2887
2888         * public/WebIndexedDatabase.h:
2889         * src/IndexedDatabaseProxy.cpp:
2890         (WebCore::IndexedDatabaseProxy::open):
2891         * src/IndexedDatabaseProxy.h:
2892         * src/WebIndexedDatabaseImpl.cpp:
2893         (WebKit::WebIndexedDatabaseImpl::open):
2894         * src/WebIndexedDatabaseImpl.h:
2895
2896 2010-04-09  Jochen Eisinger  <jochen@chromium.org>
2897
2898         Reviewed by Darin Fisher.
2899
2900         Complete move of createApplicationCacheHost from WebKitClient to WebFrameClient.
2901         https://bugs.webkit.org/show_bug.cgi?id=37330
2902
2903         * public/WebApplicationCacheHost.h:
2904         * public/WebKitClient.h:
2905         * src/ApplicationCacheHostInternal.h:
2906         (WebCore::ApplicationCacheHostInternal::ApplicationCacheHostInternal):
2907
2908 2010-04-09  Marcus Bulach  <bulach@chromium.org>
2909
2910         Reviewed by Jeremy Orlow.
2911
2912         Crash on WebKit::WebGeolocationServiceBridgeImpl::stopUpdating() during frame disconnection
2913         Should not try to access WebViewClient if the frame has already been disconnected.
2914         https://bugs.webkit.org/show_bug.cgi?id=37318
2915
2916         * src/WebGeolocationServiceBridgeImpl.cpp:
2917         (WebKit::WebGeolocationServiceBridgeImpl::stopUpdating):
2918
2919 2010-04-09  Jochen Eisinger  <jochen@chromium.org>
2920
2921         Reviewed by Adam Barth.
2922
2923         Expose SecurityOrigin::canRequest in WebSecurityOrigin.
2924         https://bugs.webkit.org/show_bug.cgi?id=37271
2925
2926         * public/WebSecurityOrigin.h:
2927         * src/WebSecurityOrigin.cpp:
2928         (WebKit::WebSecurityOrigin::canRequest):
2929
2930 2010-04-09  Zhenyao Mo  <zmo@google.com>
2931
2932         Reviewed by Dimitri Glazkov.
2933
2934         Must resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D
2935         https://bugs.webkit.org/show_bug.cgi?id=37174
2936
2937         Test: fast/canvas/webgl/copy-tex-image-and-sub-image-2d.html
2938
2939         * src/WebGraphicsContext3DDefaultImpl.cpp: Resolve multisampled back buffer during copyTexImage2D and copyTexSubImage2D.
2940         (WebKit::WebGraphicsContext3DDefaultImpl::copyTexImage2D):
2941         (WebKit::WebGraphicsContext3DDefaultImpl::copyTexSubImage2D):
2942
2943 2010-04-07  Pavel Feldman  <pfeldman@chromium.org>
2944
2945         Reviewed by Yury Semikhatsky.
2946
2947         Chromium: support themes in devtools window.
2948
2949         https://bugs.webkit.org/attachment.cgi?bugid=37216
2950
2951         * WebKit.gypi:
2952         * src/js/DevTools.js:
2953         (WebInspector.setToolbarColors):
2954         (WebInspector.resetToolbarColors):
2955         * src/js/Images/segmentChromium2.png: Added.
2956         * src/js/Images/segmentHoverChromium2.png: Added.
2957         * src/js/Images/segmentSelectedChromium2.png: Added.
2958         * src/js/Images/statusbarBackgroundChromium2.png: Added.
2959         * src/js/Images/statusbarMenuButtonChromium2.png: Added.
2960
2961 2010-04-07  Andrey Kosyakov  <caseq@chromium.org>
2962
2963         Reviewed by Yury Semikhatsky.
2964
2965         Removed inspector methods from ScriptExecutionContext and derived classes.
2966         Removed MessageDestination parameter from console-related calls (we now always
2967         log to the same destination(s)).
2968         Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
2969         https://bugs.webkit.org/show_bug.cgi?id=36949
2970
2971         * public/WebCommonWorkerClient.h:
2972         (WebKit::WebCommonWorkerClient::postConsoleMessageToWorkerObject):
2973         * src/FrameLoaderClientImpl.cpp:
2974         * src/FrameLoaderClientImpl.h:
2975         * src/WebWorkerBase.cpp:
2976         (WebKit::WebWorkerBase::postConsoleMessageToWorkerObject):
2977         (WebKit::WebWorkerBase::postConsoleMessageTask):
2978         * src/WebWorkerBase.h:
2979         * src/WebWorkerClientImpl.cpp:
2980         (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObject):
2981         (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObjectTask):
2982         * src/WebWorkerClientImpl.h:
2983
2984 2010-04-07  Jeremy Orlow  <jorlow@chromium.org>
2985
2986         Reviewed by Darin Fisher.
2987
2988         [Chromium] WebIDBDatabaseError::assign doesn't work correctly
2989         https://bugs.webkit.org/show_bug.cgi?id=37209
2990
2991         * src/WebIDBDatabaseError.cpp:
2992         (WebKit::WebIDBDatabaseError::assign):
2993
2994 2010-04-07  Dawit Alemayehu  <adawit@kde.org>
2995
2996         Reviewed by Simon Hausmann.
2997
2998         https://bugs.webkit.org/show_bug.cgi?id=36827
2999
3000         Updated the WebCore::shouldTreatAsAttachement function call with the
3001         new more generic replacement WebCore::contentDispositionType.
3002
3003         See comments 39-42 in https://bugs.webkit.org/show_bug.cgi?id=36395
3004
3005         * src/FrameLoaderClientImpl.cpp:
3006         (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForMIMEType):
3007
3008 2010-04-07  Jochen Eisinger  <jochen@chromium.org>
3009
3010         Reviewed by Darin Fisher.
3011
3012         Add createApplicationCacheHost to WebFrameClient so
3013         the ApplicationCacheHost has access to its frame.
3014
3015         https://bugs.webkit.org/show_bug.cgi?id=36882
3016
3017         * public/WebFrameClient.h:
3018         (WebKit::WebFrameClient::createApplicationCacheHost):
3019         * src/ApplicationCacheHostInternal.h:
3020         (WebCore::ApplicationCacheHostInternal::ApplicationCacheHostInternal):
3021
3022 2010-04-06  Nicolas Weber  <thakis@chromium.org>
3023
3024         Reviewed by Dimitri Glazkov.
3025
3026         Use drag images on OS X as well.
3027         https://bugs.webkit.org/show_bug.cgi?id=37069
3028
3029         * src/DragClientImpl.cpp:
3030         (WebKit::DragClientImpl::startDrag):
3031
3032 2010-04-06  Vangelis Kokkevis  <vangelis@chromium.org>
3033
3034         Reviewed by Dimitri Glazkov.
3035
3036         Changing references to Graphics Layer related classes from *Skia to *Chromium.
3037         https://bugs.webkit.org/show_bug.cgi?id=37116
3038
3039         * src/WebViewImpl.cpp:
3040         (WebKit::WebViewImpl::paint):
3041         (WebKit::WebViewImpl::setAcceleratedCompositing):
3042         (WebKit::WebViewImpl::updateRootLayerContents):
3043         * src/WebViewImpl.h:
3044
3045 2010-04-06  James Hawkins  <jhawkins@chromium.org>
3046
3047         Reviewed by Adam Barth.
3048
3049         [Chromium] Implement WebInputElement::maxLength.
3050         https://bugs.webkit.org/show_bug.cgi?id=37172
3051
3052         * public/WebInputElement.h:
3053         * src/WebInputElement.cpp:
3054         (WebKit::WebInputElement::maxLength):
3055
3056 2010-04-06  Evan Stade  <estade@chromium.org>
3057
3058         Reviewed by Dimitri Glazkov.
3059
3060         [chromium] need DragImage implementation
3061         https://bugs.webkit.org/show_bug.cgi?id=35811
3062
3063         Basic implementation using SkBitmap. Transformations are not supported
3064         yet. No implementation for mac.
3065
3066         This was previously committed but rolled back for breaking layout
3067         tests.
3068
3069         * public/WebViewClient.h:
3070         (WebKit::WebViewClient::startDragging):
3071         * src/DragClientImpl.cpp:
3072         (WebKit::DragClientImpl::startDrag): new: check for null dragImage.
3073         * src/WebViewImpl.cpp:
3074         (WebKit::WebViewImpl::startDragging):
3075         * src/WebViewImpl.h:
3076
3077 2010-04-06  James Hawkins  <jhawkins@chromium.org>
3078
3079         Reviewed by Dimitri Glazkov.
3080
3081         [Chromium] Move the getElementsByTagName from WebDocument to WebNode.
3082         https://bugs.webkit.org/show_bug.cgi?id=37161
3083
3084         * public/WebDocument.h:
3085         * public/WebNode.h:
3086         * src/WebDocument.cpp:
3087         * src/WebNode.cpp:
3088         (WebKit::WebNode::getElementsByTagName):
3089
3090 2010-04-06  Ilya Tikhonovsky  <loislo@chromium.org>
3091
3092         Unreviewed build fix for Chromium DEPS.
3093
3094         * DEPS:
3095
3096 2010-04-06  Ilya Tikhonovsky  <loislo@chromium.org>
3097
3098         Unreviewed: build fix.
3099
3100         * DEPS:
3101
3102 2010-04-06  Mattias Nissler  <mnissler@chromium.org>
3103
3104         Reviewed by Pavel Feldman.
3105
3106         Handle docking requests from the developer tools and forward them to
3107         WebDevToolsFrontendClient.
3108         https://bugs.webkit.org/show_bug.cgi?id=36944
3109
3110         * public/WebDevToolsFrontendClient.h:
3111         (WebKit::WebDevToolsFrontendClient::requestDockWindow):
3112         * src/WebDevToolsFrontendImpl.cpp:
3113         (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
3114         (WebKit::WebDevToolsFrontendImpl::jsRequestAttachWindow):
3115         * src/WebDevToolsFrontendImpl.h:
3116
3117 2010-04-06  Andrey Kosyakov  <caseq@chromium.org>
3118
3119         Reviewed by Yury Semikhatsky.
3120
3121         Fixed logging of unhndled worker exceptions.
3122         https://bugs.webkit.org/show_bug.cgi?id=37143
3123
3124         * src/WebWorkerClientImpl.cpp:
3125         (WebKit::WebWorkerClientImpl::postExceptionToWorkerObject):
3126
3127 2010-04-05  Alexey Proskuryakov  <ap@apple.com>
3128
3129         Reviewed by Darin Adler.
3130
3131         https://bugs.webkit.org/show_bug.cgi?id=37111
3132         <rdar://problem/7790327> Draw replacement text when plug-in host crashes
3133
3134         * src/LocalizedStrings.cpp: (WebCore::crashedPluginText): Added a stub string for plug-in
3135         failure.
3136
3137 2010-04-04  Pavel Feldman  <pfeldman@chromium.org>
3138
3139         Not reviewed. Rolling out chromium changes r57028 and r57032 
3140         for breaking chromium layout tests.
3141
3142         * public/WebViewClient.h:
3143         (WebKit::WebViewClient::startDragging):
3144         * src/DragClientImpl.cpp:
3145         (WebKit::DragClientImpl::startDrag):
3146         * src/WebViewImpl.cpp:
3147         (WebKit::WebViewImpl::startDragging):
3148         * src/WebViewImpl.h:
3149
3150 2010-04-03  Darin Fisher  <darin@chromium.org>
3151
3152         Add default implementations of WebNotificationPresenter methods to
3153         repair the downstream Chromium build.
3154
3155         * public/WebNotificationPresenter.h:
3156         (WebKit::WebNotificationPresenter::show):
3157         (WebKit::WebNotificationPresenter::cancel):
3158         (WebKit::WebNotificationPresenter::objectDestroyed):
3159         (WebKit::WebNotificationPresenter::checkPermission):
3160         (WebKit::WebNotificationPresenter::requestPermission):
3161
3162 2010-04-02  Michael Nordman  <michaeln@google.com>
3163
3164         Reviewed by Nate Chapin.
3165
3166         Set the close policy used by the DatabaseCloseTask at this callsite to
3167         RemoveDatabaseFromContext. This restores its behavior to what it was prior to
3168         r56293.
3169         https://bugs.webkit.org/show_bug.cgi?id=37037
3170
3171         * src/WebDatabase.cpp:
3172         (WebKit::WebDatabase::closeDatabaseImmediately):
3173
3174 2010-04-02  Evan Stade  <estade@chromium.org>
3175
3176         Reviewed by Eric Seidel.
3177
3178         [chromium] need DragImage implementation
3179         https://bugs.webkit.org/show_bug.cgi?id=35811
3180
3181         Use the DragImageRef that the DragController passes to us.
3182
3183         * public/WebViewClient.h:
3184         (WebKit::WebViewClient::startDragging):
3185         * src/DragClientImpl.cpp:
3186         (WebKit::DragClientImpl::startDrag):
3187         * src/WebViewImpl.cpp:
3188         (WebKit::WebViewImpl::startDragging):
3189         * src/WebViewImpl.h:
3190
3191 2010-04-02  Rafael Weinstein  <rafaelw@chromium.org>
3192
3193         Reviewed by Adam Barth.
3194
3195         Clean up unused calls after changes to checkPermission and requestPermission argument lists.
3196
3197         * public/WebNotificationPresenter.h:
3198         * src/NotificationPresenterImpl.cpp:
3199         (WebKit::NotificationPresenterImpl::checkPermission):
3200         (WebKit::NotificationPresenterImpl::requestPermission):
3201
3202 2010-04-02  Zhenyao Mo  <zmo@google.com>
3203
3204         Reviewed by Eric Seidel.
3205
3206         Implement and test new framebuffer object attachment behavior.
3207         https://bugs.webkit.org/show_bug.cgi?id=35611
3208
3209         Test: fast/canvas/webgl/framebuffer-object-attachment.html
3210
3211         * src/WebGraphicsContext3DDefaultImpl.cpp: Map to correct DEPTH_STENCIL format.
3212         (WebKit::WebGraphicsContext3DDefaultImpl::framebufferRenderbuffer):
3213         (WebKit::WebGraphicsContext3DDefaultImpl::getFramebufferAttachmentParameteriv):
3214         (WebKit::WebGraphicsContext3DDefaultImpl::renderbufferStorage):
3215
3216 2010-04-02  Jay Civelli  <jcivelli@chromium.org>
3217
3218         Reviewed by Darin Fisher.
3219
3220         The popup type (select or suggestion) is now passed to the
3221         WebClient::createPopupMenu() method. This is required for
3222         Chromium on Linux to make the select popups work correctly.
3223         https://bugs.webkit.org/show_bug.cgi?id=37013
3224
3225         * WebKit.gyp:
3226         * public/WebPopupType.h: Added.
3227         (WebKit::):
3228         * public/WebViewClient.h:
3229         (WebKit::WebViewClient::createPopupMenu):
3230         * src/ChromeClientImpl.cpp:
3231         (WebCore::convertPopupType):
3232         (WebKit::ChromeClientImpl::popupOpened):
3233
3234 2010-04-02  Yury Semikhatsky  <yurys@chromium.org>
3235
3236         Reviewed by Pavel Feldman.
3237
3238         Implement InspectorFrontendClient in Chromium and remove all custom bindings for the host methods from WebDevToolsFrontendImpl. 
3239
3240         https://bugs.webkit.org/show_bug.cgi?id=36817
3241
3242         * WebKit.gyp:
3243         * src/InspectorFrontendClientImpl.cpp: Added.
3244         (WebKit::InspectorFrontendClientImpl::InspectorFrontendClientImpl):
3245         (WebKit::InspectorFrontendClientImpl::~InspectorFrontendClientImpl):
3246         (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
3247         (WebKit::InspectorFrontendClientImpl::frontendLoaded):
3248         (WebKit::InspectorFrontendClientImpl::moveWindowBy):
3249         (WebKit::InspectorFrontendClientImpl::localizedStringsURL):
3250         (WebKit::InspectorFrontendClientImpl::hiddenPanels):
3251         (WebKit::InspectorFrontendClientImpl::bringToFront):
3252         (WebKit::InspectorFrontendClientImpl::closeWindow):
3253         (WebKit::InspectorFrontendClientImpl::canAttachWindow):
3254         (WebKit::InspectorFrontendClientImpl::attachWindow):
3255         (WebKit::InspectorFrontendClientImpl::detachWindow):
3256         (WebKit::InspectorFrontendClientImpl::changeAttachedWindowHeight):
3257         (WebKit::InspectorFrontendClientImpl::inspectedURLChanged):
3258         * src/InspectorFrontendClientImpl.h: Added.
3259         * src/WebDevToolsFrontendImpl.cpp:
3260         (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
3261         (WebKit::WebDevToolsFrontendImpl::~WebDevToolsFrontendImpl):
3262         (WebKit::WebDevToolsFrontendImpl::frontendLoaded):
3263         * src/WebDevToolsFrontendImpl.h:
3264         * src/js/DebuggerAgent.js:
3265         (devtools.DebuggerAgent.prototype.doHandleBacktraceResponse_):
3266         * src/js/DevTools.js:
3267         ():
3268
3269 2010-04-01  Jay Civelli  <jcivelli@google.com>
3270
3271         Reviewed by David Levin.
3272
3273         Adds a method to WebFrame to execute JavaScript and get the value
3274         it evaluates to.
3275         https://bugs.webkit.org/show_bug.cgi?id=36907
3276
3277         * public/WebFrame.h:
3278         * src/WebFrameImpl.cpp:
3279         (WebKit::WebFrameImpl::executeScriptAndReturnValue):
3280         * src/WebFrameImpl.h:
3281
3282 2010-04-01  Kinuko Yasuda  <kinuko@chromium.org>
3283
3284         Reviewed by Dmitry Titov.
3285
3286         Add FileThread for async file operation support in FileReader and FileWriter
3287         https://bugs.webkit.org/show_bug.cgi?id=36896
3288
3289         Add ENABLE_FILE_READER and ENABLE_FILE_WRITER flags.
3290
3291         * features.gypi:
3292
3293 2010-04-01  Finnur Thorarinsson  <finnur.webkit@gmail.com>
3294
3295         Reviewed by Eric Seidel.
3296
3297         [chromium] FindInPage on multi-frame pages wasn't always updating
3298         tickmarks on scrollbars for the subframes. It was calling invalidateRect
3299         on the View and specifying a rect that's in window coordinates, whereas
3300         the invalidateRect expects frame coordinates.
3301
3302         https://bugs.webkit.org/show_bug.cgi?id=36982
3303         
3304         * src/WebFrameImpl.cpp:
3305         (WebKit::WebFrameImpl::invalidateArea):
3306
3307 2010-04-01  Finnur Thorarinsson  <finnur.webkit@gmail.com>
3308
3309         Reviewed by Dimitri Glazkov.
3310
3311         [chromium] FindInPage should clear the focused node when a match has
3312         been found. This is because WebFrameImpl::setFocus will try to refocus
3313         editable elements if it thinks they have focus, causing the page to
3314         scroll.
3315
3316         https://bugs.webkit.org/show_bug.cgi?id=36923
3317
3318         * src/WebFrameImpl.cpp:
3319         (WebKit::WebFrameImpl::find):
3320
3321 2010-04-01  Marcus Bulach  <bulach@chromium.org>
3322
3323         Reviewed by Jeremy Orlow.
3324
3325         As a follow up on https://bugs.webkit.org/show_bug.cgi?id=36535, remove:
3326         GeolocationServiceBridgeChromium.h
3327         dettachBridge()
3328         getGeolocationService()
3329         https://bugs.webkit.org/show_bug.cgi?id=36895
3330
3331         * WebKit.gyp:
3332         * public/GeolocationServiceBridgeChromium.h: Removed.
3333         * public/WebGeolocationService.h:
3334         (WebKit::WebGeolocationService::detachBridge):
3335         * public/WebViewClient.h:
3336         (WebKit::WebViewClient::geolocationService):
3337
3338 2010-03-31  Jeremy Orlow  <jorlow@chromium.org>
3339
3340         Reviewed by Nate Chapin.
3341
3342         Misc IndexedDatabase cleanup
3343         https://bugs.webkit.org/show_bug.cgi?id=36889
3344
3345         Plumb the Frame* so Chromium knows where the request originated from.
3346
3347         * public/WebIndexedDatabase.h:
3348         * src/IndexedDatabaseProxy.cpp:
3349         (WebCore::IndexedDatabaseProxy::open):
3350         * src/IndexedDatabaseProxy.h:
3351         * src/WebIndexedDatabaseImpl.cpp:
3352         (WebKit::WebIndexedDatabaseImpl::open):
3353         * src/WebIndexedDatabaseImpl.h:
3354
3355 2010-03-31  Alpha Lam  <hclam@chromium.org>
3356
3357         Not reviewed. Build fix.
3358
3359         Fixing a build break caused by 56872. One of the Chromium bots doesn't
3360         like std::strstr(). Includes string.h and use strstr() instead.
3361
3362         * src/WebGraphicsContext3DDefaultImpl.cpp:
3363         (WebKit::WebGraphicsContext3DDefaultImpl::validateAttributes):
3364         Includes string.h and use strstr().
3365
3366 2010-03-31  Zhenyao Mo  <zmo@google.com>
3367
3368         Reviewed by Darin Fisher.
3369
3370         Hook up WebGLContextAttributes to OpenGL context creation code
3371         https://bugs.webkit.org/show_bug.cgi?id=33416
3372
3373         * src/WebGraphicsContext3DDefaultImpl.cpp: Hook up WebGLContextAttributes to OpenGL context creation code for Chrome.
3374         (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl):
3375         (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl):
3376         (WebKit::WebGraphicsContext3DDefaultImpl::initialize):
3377         (WebKit::WebGraphicsContext3DDefaultImpl::validateAttributes):
3378         (WebKit::WebGraphicsContext3DDefaultImpl::reshape):
3379         (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer):
3380         (WebKit::WebGraphicsContext3DDefaultImpl::bindFramebuffer):
3381         (WebKit::WebGraphicsContext3DDefaultImpl::readPixels): Deal with wrong returned alpha values in Mac.
3382         * src/WebGraphicsContext3DDefaultImpl.h: Add a function.
3383
3384 2010-03-31  Darin Fisher  <darin@chromium.org>
3385
3386         Reviewed by David Levin.
3387
3388         [chromium] including WebKit.gyp:webkit should automatically add Skia
3389         and NPAPI include paths
3390
3391         https://bugs.webkit.org/show_bug.cgi?id=36887
3392
3393         * WebKit.gyp:
3394
3395 2010-03-31  Marcus Bulach  <bulach@chromium.org>
3396
3397         Reviewed by Jeremy Orlow.
3398
3399         Implements cancelGeolocationPermissionRequestForFrame.
3400         https://bugs.webkit.org/show_bug.cgi?id=35031
3401
3402         * public/WebGeolocationService.h:
3403         (WebKit::WebGeolocationService::cancelPermissionRequestForFrame):
3404         * src/ChromeClientImpl.cpp:
3405         (WebKit::ChromeClientImpl::cancelGeolocationPermissionRequestForFrame):
3406         * src/ChromeClientImpl.h:
3407
3408 2010-03-31  Pavel Feldman  <pfeldman@chromium.org>
3409
3410         Not reviewed. Rolling out r56829 since it broke chromium layout tests.
3411
3412         [REGRESSION] Inspector tests started crashing since r56829
3413         https://bugs.webkit.org/show_bug.cgi?id=36888
3414
3415         * public/WebFrameClient.h:
3416         * src/FrameLoaderClientImpl.cpp:
3417         * src/FrameLoaderClientImpl.h:
3418
3419 2010-03-31  Yury Semikhatsky  <yurys@chromium.org>
3420
3421         Reviewed by Pavel Feldman.
3422
3423         Add stubs for moveWindowBy and setAttachedWindowHeight.
3424
3425         https://bugs.webkit.org/show_bug.cgi?id=36842
3426
3427         * src/WebDevToolsFrontendImpl.cpp:
3428         (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl):
3429         (WebKit::WebDevToolsFrontendImpl::jsSetAttachedWindowHeight):
3430         (WebKit::WebDevToolsFrontendImpl::jsMoveWindowBy):
3431         * src/WebDevToolsFrontendImpl.h:
3432
3433 2010-03-31  John Gregg  <johnnyg@google.com>
3434
3435         Reviewed by Darin Fisher.
3436
3437         [chromium] add logging of cross-frame property accesses for site isolation
3438         https://bugs.webkit.org/show_bug.cgi?id=35773
3439
3440         * public/WebFrameClient.h:
3441         (WebKit::WebFrameClient::logCrossFramePropertyAccess):
3442         * src/FrameLoaderClientImpl.cpp:
3443         (WebKit::FrameLoaderClientImpl::logCrossFramePropertyAccess):
3444         * src/FrameLoaderClientImpl.h:
3445
3446 2010-03-30  Gavin Barraclough  <barraclough@apple.com>
3447
3448         Rubber stamped by Sam Weinig.
3449
3450         https://bugs.webkit.org/show_bug.cgi?id=36866
3451         Move CString to WTF
3452
3453         * public/WebCString.h:
3454         * src/FrameLoaderClientImpl.cpp:
3455         * src/GraphicsContext3D.cpp:
3456         * src/WebCString.cpp:
3457         (WebKit::WebCString::assign):
3458         (WebKit::WebCString::WebCString):
3459         (WebKit::WebCString::operator=):
3460         (WebKit::WebCString::operator WTF::CString):
3461         * src/WebMediaPlayerClientImpl.cpp:
3462         * src/WebString.cpp:
3463         * src/WebURLError.cpp:
3464
3465 2010-03-30  Marcus Bulach  <bulach@chromium.org>
3466
3467         Reviewed by Darin Fisher.
3468
3469         Rename / tidy up Geolocation bridge:
3470         Rename GeolocationServiceBridgeChromium.cpp to WebGeolocationServiceBridgeImpl.cpp            
3471         Uses a temporary compatibility layer in GeolocationServiceBridgeChromium.h.
3472
3473         https://bugs.webkit.org/show_bug.cgi?id=36535
3474
3475         * WebKit.gyp:
3476         * public/GeolocationServiceBridgeChromium.h:
3477         * public/WebGeolocationService.h: Copied from WebKit/chromium/public/GeolocationServiceBridgeChromium.h.
3478         (WebKit::WebGeolocationService::detachBridge):
3479         * public/WebGeolocationServiceBridge.h: Copied from WebKit/chromium/public/GeolocationServiceBridgeChromium.h.
3480         * public/WebViewClient.h:
3481         (WebKit::WebViewClient::geolocationService):
3482         * src/ChromeClientImpl.cpp:
3483         (WebKit::ChromeClientImpl::requestGeolocationPermissionForFrame):
3484         * src/ChromiumBridge.cpp:
3485         * src/GeolocationServiceBridgeChromium.cpp: Removed.
3486         * src/WebGeolocationServiceBridgeImpl.cpp: Copied from WebKit/chromium/src/GeolocationServiceBridgeChromium.cpp.
3487         (WebKit::createGeolocationServiceBridgeImpl):
3488         (WebKit::WebGeolocationServiceBridgeImpl::WebGeolocationServiceBridgeImpl):
3489         (WebKit::WebGeolocationServiceBridgeImpl::~WebGeolocationServiceBridgeImpl):
3490         (WebKit::WebGeolocationServiceBridgeImpl::startUpdating):
3491         (WebKit::WebGeolocationServiceBridgeImpl::stopUpdating):
3492         (WebKit::WebGeolocationServiceBridgeImpl::suspend):
3493         (WebKit::WebGeolocationServiceBridgeImpl::resume):
3494         (WebKit::WebGeolocationServiceBridgeImpl::getBridgeId):
3495         (WebKit::WebGeolocationServiceBridgeImpl::setIsAllowed):
3496         (WebKit::WebGeolocationServiceBridgeImpl::setLastPosition):
3497         (WebKit::WebGeolocationServiceBridgeImpl::setLastError):
3498         (WebKit::WebGeolocationServiceBridgeImpl::getWebViewClient):
3499         * src/WebGeolocationServiceBridgeImpl.h: Copied from WebKit/chromium/public/GeolocationServiceBridgeChromium.h.
3500
3501 2010-03-30  Jochen Eisinger  <jochen@chromium.org>
3502
3503         Reviewed by Jeremy Orlow.
3504
3505         Remove dysfunctional implementation of canEstablishDatabase for
3506         Workers. I postpone this implementation until Workers can actually
3507         access Web Databases.
3508
3509         https://bugs.webkit.org/show_bug.cgi?id=36795
3510
3511         * src/DatabaseObserver.cpp:
3512         (WebCore::DatabaseObserver::canEstablishDatabase):
3513         * src/WebWorkerBase.h:
3514
3515 2010-03-29  Jeremy Orlow  <jorlow@chromium.org>
3516
3517         Reviewed by Darin Fisher.
3518
3519         More IndexedDB work
3520         https://bugs.webkit.org/show_bug.cgi?id=36770
3521
3522         Start the implementation of WebIndexedDatabase (for entrance back into WebKit).
3523
3524         * WebKit.gyp:
3525         * public/WebIndexedDatabase.h:
3526         * src/WebIndexedDatabaseImpl.cpp: Added.
3527         (WebKit::WebIndexedDatabase::create):
3528         (WebKit::WebIndexedDatabaseImpl::~WebIndexedDatabaseImpl):
3529         (WebKit::WebIndexedDatabaseImpl::open):
3530         * src/WebIndexedDatabaseImpl.h: Added.
3531
3532 2010-03-29  Rafael Weinstein  <rafaelw@chromium.org>
3533
3534         Reviewed by Adam Barth.
3535
3536         Change NotificationPresenter::checkPermission() to take the source frames full KURL,
3537         rather than its SecurityOrigin. This will aid chromium in having more fine grained
3538         permissions to control notification spam.
3539
3540         * public/WebNotificationPresenter.h:
3541         (WebKit::WebNotificationPresenter::checkPermission):
3542         * src/NotificationPresenterImpl.cpp:
3543         (WebKit::NotificationPresenterImpl::checkPermission):
3544         * src/NotificationPresenterImpl.h:
3545
3546 2010-03-29  Dawit Alemayehu  <adawit@kde.org>
3547
3548         Reviewed by Simon Hausmann.
3549
3550         Factored out the 'ShouldTreatAsAttachment' function to HTTPParsers.*
3551         and replacted local version with the factored out version.
3552
3553         The code was factored out to make possible its use in other implementations
3554         such as QtWebKit.
3555
3556         * src/FrameLoaderClientImpl.cpp:
3557         (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForMIMEType):
3558
3559 2010-03-29  Jochen Eisinger  <jochen@chromium.org>
3560
3561         Reviewed by Darin Fisher.
3562
3563         Pass a WebFrame to WebFrameClient::allowDatabase instead of a WebSecurityOrigin
3564         https://bugs.webkit.org/show_bug.cgi?id=36743
3565
3566         * public/WebFrameClient.h:
3567         (WebKit::WebFrameClient::allowDatabase):
3568         * src/DatabaseObserver.cpp:
3569         (WebCore::DatabaseObserver::canEstablishDatabase):
3570
3571 2010-03-24  Jeremy Orlow  <jorlow@chromium.org>
3572
3573         Reviewed by Darin Fisher.
3574
3575         More IndexedDB plumbing
3576         https://bugs.webkit.org/show_bug.cgi?id=36546
3577
3578         Plumbing work towards the goal of making IndexedDatabase::open work.
3579
3580         * WebKit.gyp:
3581         * public/WebIDBCallbacks.h: Added.
3582         (WebKit::WebIDBCallbacks::~WebIDBCallbacks):
3583         * public/WebIDBDatabase.h: Added.
3584         (WebKit::WebIDBDatabase::~WebIDBDatabase):
3585         * public/WebIDBDatabaseError.h: Added.
3586         (WebKit::WebIDBDatabaseError::WebIDBDatabaseError):
3587         (WebKit::WebIDBDatabaseError::operator=):
3588         * public/WebIndexedDatabase.h:
3589         * public/WebKitClient.h:
3590         (WebKit::WebKitClient::indexedDatabase):
3591         * public/WebSerializedScriptValue.h:
3592         * src/IDBCallbacksProxy.h: Added.
3593         (WebCore::IDBCallbacksProxy::IDBCallbacksProxy):
3594         (WebCore::IDBCallbacksProxy::~IDBCallbacksProxy):
3595         (WebCore::IDBCallbacksProxy::onSuccess):
3596         (WebCore::IDBCallbacksProxy::onError):
3597         * src/IDBDatabaseProxy.cpp: Added.
3598         (WebCore::IDBDatabaseProxy::create):
3599         (WebCore::IDBDatabaseProxy::IDBDatabaseProxy):
3600         (WebCore::IDBDatabaseProxy::~IDBDatabaseProxy):
3601         * src/IDBDatabaseProxy.h: Added.
3602         * src/IndexedDatabaseProxy.cpp:
3603         (WebCore::IndexedDatabaseProxy::IndexedDatabaseProxy):
3604         (WebCore::IndexedDatabaseProxy::open):
3605         * src/IndexedDatabaseProxy.h:
3606         * src/WebIDBDatabaseError.cpp: Added.
3607         (WebKit::WebIDBDatabaseError::~WebIDBDatabaseError):
3608         (WebKit::WebIDBDatabaseError::WebIDBDatabaseError):
3609         (WebKit::WebIDBDatabaseError::assign):
3610         (WebKit::WebIDBDatabaseError::code):
3611         (WebKit::WebIDBDatabaseError::message):
3612         (WebKit::WebIDBDatabaseError::operator=):
3613         (WebKit::WebIDBDatabaseError::operator PassRefPtr<IDBDatabaseError>):
3614
3615 2010-03-29  Mikhail Naganov  <mnaganov@chromium.org>
3616
3617         Reviewed by Pavel Feldman.
3618
3619         Remove a possibility of confusion from Profiles panel Welcome screen
3620         by turning buttons into non-clickable glyphs. Also, span instructions
3621         alongside panel width.
3622
3623         https://bugs.webkit.org/show_bug.cgi?id=34319
3624
3625         * src/js/HeapProfilerPanel.js:
3626   &nbs