3 2006-09-11 MorganL <morlmor@yahoo.com>
5 Reviewed/landed by aroben.
7 Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10765
8 Windows build busted due to std::copy usage in Vector.h
10 * WebKit.vcproj/WebKit.vcproj: Define _SCL_SECURE_NO_DEPRECATE to get
11 rid of deprecation warnings on std::copy
13 2006-09-11 Brady Eidson <beidson@apple.com>
15 Despite the fact that some people built okay without this change, it sure was biting me,
16 probably because I just wiped my build directory for a fresh build -
17 Today's earlier removal of DOMList.h needed to occur in MigrateHeaders.make, as well
19 * MigrateHeaders.make: removed DOMList.h
21 2006-09-10 Darin Adler <darin@apple.com>
25 - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10547
26 REGRESSION: Links that should open in a new window open in the same window,
27 while opening another blank window
30 (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
31 Changed a mistaken "self" to "frame", which was the cause of the bug. Also
32 fixed the method so that it won't crash if createWebViewWithRequest does
33 something that has a side effect of releasing this WebView or this frame
34 by retaining "self" and "frame" as needed. Also fixed a problem where the
35 code to set "opener" was backwards, and would set the opener of the old
36 frame to point to the new frame instead of vice versa.
38 2006-09-09 Sam Weinig <sam.weinig@gmail.com>
42 Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10795
43 Auto-generate the Objective-C DOM XPath bindings
45 * MigrateHeaders.make:
47 2006-09-09 Sam Weinig <sam.weinig@gmail.com>
51 Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10791
52 Even More Objective-C DOM auto-generation cleanup
54 * MigrateHeaders.make:
56 2006-09-08 Tim Omernick <timo@apple.com>
58 Reviewed by Brady Eidson.
60 Rolled out Maciej's code cleanup from 8/22. It turns out that keeping the "loading" flag
61 is a useful optimization, as it avoids many Objective-C method calls while polling resources
64 This fixes a 3-4% PLT performance regression (as measured on my MacBook Pro).
66 * Loader/WebFrameLoader.m:
67 (-[WebFrameLoader addPlugInStreamLoader:]):
68 (-[WebFrameLoader removePlugInStreamLoader:]):
69 (-[WebFrameLoader addSubresourceLoader:]):
70 (-[WebFrameLoader removeSubresourceLoader:]):
71 * WebView/WebDataSource.m:
72 (-[WebDataSourcePrivate dealloc]):
73 (-[WebDataSource _prepareForLoadStart]):
74 (-[WebDataSource _setLoading:]):
75 (-[WebDataSource _updateLoading]):
76 (-[WebDataSource _startLoading]):
77 (-[WebDataSource _stopLoading]):
78 (-[WebDataSource _setPrimaryLoadComplete:]):
79 (-[WebDataSource isLoading]):
80 * WebView/WebDataSourceInternal.h:
82 2006-09-07 Sam Weinig <sam.weinig@gmail.com>
84 Reviewed by Darin and Tim H.
86 Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10774
87 Auto-generate the Objective-C DOM Traversal bindings
89 * MigrateHeaders.make:
91 2006-09-07 Sam Weinig <sam.weinig@gmail.com>
95 Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10766
96 Auto-generate the Objective-C DOM Events bindings
98 * MigrateHeaders.make:
99 * WebKit.xcodeproj/project.pbxproj:
101 2006-09-06 Alexey Proskuryakov <ap@nypop.com>
103 * MigrateHeaders.make: Fixed a double slash in
104 "$(PRIVATE_HEADERS_DIR)//DOMCharacterDataPrivate.h" (this was reported
105 to cause a build failure under certain circumstances).
107 2006-09-05 MorganL <morlmor@yahoocom>
109 Reviewed/landed by aroben.
111 Fixes bug 10743: Windows build is busted.
116 2006-09-05 Timothy Hatcher <timothy@apple.com>
120 Drastically simplified the makefile for migrating headers from
121 WebCore and JavaScriptCore. The old version was always copying the files.
123 * MigrateHeaders.make:
125 2006-09-05 Darin Adler <darin@apple.com>
129 - WebKit side of changes to encoding
131 * WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation documentSource]):
132 Changed to call new -[WebCoreFrameBridge stringWithData:] instead of the calling
133 the old methods that used a CFStringEncoding: -[WebCoreFrameBridge textEncoding]
134 and +[WebCoreFrameBridge stringWithData:textEncoding:].
136 * WebView/WebResource.m: (-[WebResource _stringValue]): Removed special case for
137 nil encoding name. The bridge itself now has the rule that "nil encoding name
138 means Latin-1", so we don't need to check for nil.
140 * WebView/WebFrame.m: (-[WebFrame _checkLoadComplete]): Retain the frame until
141 we get the parent frame while walking up parent frames, because it's possible
142 for _checkLoadCompleteForThisFrame to release the last reference to the frame.
143 (Not reviewed; needed to run performance tests successfully.)
145 2006-09-05 Timothy Hatcher <timothy@apple.com>
149 <rdar://problem/4682225> conflicting typedefs in Netscape plug-in headers
151 * Plugins/npfunctions.h: fix the return type for NPN_IntFromIdentifierProcPtr to be int32_t
153 2006-09-04 Timothy Hatcher <timothy@apple.com>
157 Bug 10714: ObjC autogeneration needs safe-guards against easily modifying the public API
158 http://bugzilla.opendarwin.org/show_bug.cgi?id=10714
160 - Added the new private DOM headers.
161 - Factored out the common commands into variables.
162 - Made WebDashboardRegion.h private again.
163 - Rename DOMDOMImplementation.h to DOMImplementation.h when files
164 are migrated. Also fixes up #imports.
166 * MigrateHeaders.make:
168 2006-09-03 Sam Weinig <sam.weinig@gmail.com>
170 Reviewed by Darin and Tim H.
172 - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10711
173 Auto-generate the Objective-C DOM Stylesheet bindings
175 * MigrateHeaders.make:
177 2006-09-02 Sam Weinig <sam.weinig@gmail.com>
181 - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10684
182 Auto-generate the Objective-C DOM CSS bindings
184 * MigrateHeaders.make:
186 2006-09-01 MorganL <morlmor@yahoo.com>
188 Reviewed by Darin. Updated/landed by Adam.
190 Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10553
194 (WebFrame::initWithName):
196 2006-09-01 Brady Eidson <beidson@apple.com>
200 A "never should be reached" method was reached - lets not release the shared database bridge, esp
201 since we never retain it!
203 * Misc/WebIconDatabase.m:
204 (-[WebIconDatabase _applicationWillTerminate:]): Don't release the bridge
206 2006-09-01 Darin Adler <darin@apple.com>
210 - a few small tweaks to the icon database bridge
212 * Misc/WebIconDatabase.m: (-[WebIconDatabase init]): Updated for name change.
214 * WebCoreSupport/WebIconDatabaseBridge.h: Removed unneeded declarations.
215 * WebCoreSupport/WebIconDatabaseBridge.m:
216 (-[WebIconDatabaseBridge init]): Added. Always returns nil since you're not supposed
217 to allocate one of these.
218 (-[WebIconDatabaseBridge _init]): Renamed from init. Used internally to make the
219 shared instance. Added the "self = [super init]" idiom even though it's not important
220 in this case just to be consistent.
221 (-[WebIconDatabaseBridge releaseCachedLoaderForIconURL:]): Moved this up in the file
222 so it can be called without declaring it in the header.
223 (+[WebIconDatabaseBridge sharedInstance]): Renamed. Calls the new _init. Also use
224 CFRetain for compatibility.
225 (-[WebIconDatabaseBridge dealloc]): Emptied this out and made it just assert (false).
226 (-[WebIconDatabaseBridge finalize]): Added and made it assert (false) too.
228 2006-09-01 Timothy Hatcher <timothy@apple.com>
232 Bug 10677: Omit "-webkit-text-security: none;" from the computed style list
233 http://bugzilla.opendarwin.org/show_bug.cgi?id=10677
235 * WebInspector/webInspector/inspector.js:
237 2006-08-31 Sam Weinig <sam.weinig@gmail.com>
241 - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10669
242 Auto-generate the remaining Objective-C HTML DOM bindings
244 * MigrateHeaders.make:
246 2006-08-31 Adele Peterson <adele@apple.com>
250 WebKit part of fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10666
251 Password: Disallow Spelling, Font, Speech, and Writing Direction context menu
253 * DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
254 Check that the selection isn't in a password field before adding these items to the default editing context menu.
255 Search In Google, Search In Spotlight, Look up in Dictionary, Spelling, Font, Speech, Writing Direction
256 * WebView/WebHTMLView.m: (-[WebHTMLView _isSelectionInPasswordField]): Added.
257 * WebView/WebHTMLViewPrivate.h:
259 2006-08-31 Sam Weinig <sam.weinig@gmail.com>
263 - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10653
264 Auto-generate another 20 Objective-C DOM HTML bindings
266 * MigrateHeaders.make:
267 * WebKit.xcodeproj/project.pbxproj:
269 2006-08-31 Adele Peterson <adele@apple.com>
271 Reviewed by John Sullivan.
273 Removed wkSecureEventInput and wkSetSecureEventInput, since this can be done with API.
275 * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
277 2006-08-31 John Sullivan <sullivan@apple.com>
279 Reviewed by Tim Omernick
281 - fixed <rdar://problem/4711200> Loading history would be faster if it bypassed
282 NSURL API for local files
284 * History/WebHistory.m:
285 (-[WebHistoryPrivate _loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
286 Load file URLs using [NSDictionary dictionaryWithContentsOfFile:]. I also cleaned up some minor
287 style issues in this method, and I removed the support for old NSArray-style history files (which we
288 stopped using before Safari 1.0).
290 2006-08-30 Adele Peterson <adele@apple.com>
294 WebKit part of fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10575
295 Enable secure input mode for new password fields
297 * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
299 2006-08-30 Brady Eidson <beidson@apple.com>
303 <rdar://problem/4707718> Change behavior so if the WebCore::IconDatabase can't open, WebKit releases the bridge and
304 continues on as if the IconDatabase is disabled.
306 * Misc/WebIconDatabase.m:
307 (-[WebIconDatabase init]): Release the bridge on failure to open
308 * WebCoreSupport/WebIconDatabaseBridge.m:
309 (+[WebIconDatabaseBridge sharedBridgeInstance]): Moved static shared instance out as a global
310 (-[WebIconDatabaseBridge dealloc]): Clear pointer to the shared instance
312 2006-08-30 Timothy Hatcher <timothy@apple.com>
316 Simplify the header copies from WebCore and JavaScriptCore.
317 Headers that need to be migrated from the other projects need
318 to be added to MigrateHeaders.make.
320 * MigrateHeaders.make: Added.
321 * WebKit.xcodeproj/project.pbxproj:
323 2006-08-30 Sam Weinig <sam.weinig@gmail.com>
327 - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10640
328 Auto-generate 10 more Objective-C DOM HTML bindings
330 * WebKit.xcodeproj/project.pbxproj:
332 2006-08-30 Adele Peterson <adele@apple.com>
336 WebKit part of fix for:
337 http://bugzilla.opendarwin.org/show_bug.cgi?id=10576
338 Disallow copy from new password fields
340 * WebView/WebHTMLView.m:
341 (-[WebHTMLView _canCopy]): Now also calls across the bridge to ask if it mayCopy.
342 (-[WebHTMLView _canCut]): Calls _canCopy now.
343 (-[NSArray validateUserInterfaceItem:]): Calls _canCut when validating the "Cut" menu item.
344 This used to call _canDelete (which used to be the same as _canCut), but now _canCut also checks _canCopy.
346 2006-08-30 Karl Adam <karladam@yahoo-inc.com>
348 Reviewed by Eric and Tim H.
350 Bug 10634: -webView:dragDestinationActionMaskForDraggingInfo: is ignored
351 http://bugzilla.opendarwin.org/show_bug.cgi?id=10634
353 Remove the check for canShowFile: from _web_bestURL: since
354 it shouldn't be concerned with whether or not the view
355 can show the URL, merely return the most appropriate URL.
357 * Misc/WebNSPasteboardExtras.m:
358 (-[NSPasteboard _web_bestURL]):
359 * Misc/WebNSViewExtras.m:
360 (-[NSView _web_dragOperationForDraggingInfo:]):
362 2006-08-29 Brady Eidson <beidson@apple.com>
364 Reviewed by Kevin Decker (Sarge)
366 <rdar://problem/4678414> - New IconDB needs to delete icons when asked
368 * Misc/WebIconDatabase.m:
369 (-[WebIconDatabase removeAllIcons]): Call through to WebCore to remove icons, then send notification
371 2006-08-29 Brady Eidson <beidson@apple.com>
375 Added a truth value check for to setIconURL:forURL so WebKit can avoid sending a notification
376 This is a win on the iBench
378 * Misc/WebIconDatabase.m:
379 (-[WebIconDatabase _setIconURL:forURL:]):
381 2006-08-29 Brady Eidson <beidson@apple.com>
383 Reviewed by Tim Hatchers rubber stamp
385 Removed some accidentally left-in console spew during the conversion to the new DB
387 * Misc/WebIconDatabase.m:
388 (objectFromPathForKey): Nuked some NSLogs
390 2006-08-29 Tim Omernick <timo@apple.com>
392 Reviewed by Darin Adler.
394 <rdar://problem/4688618> REGRESSION(10.4.7-9A241): JMol java applet fails in Safari not Firefox
396 No layout test for now because Java doesn't work in DumpRenderTree.
398 * Plugins/WebPluginDatabase.m:
399 (-[WebPluginDatabase refresh]):
400 Add each plug-in MIME type to registeredMIMETypes, even if we don't register a document view class for the
401 MIME type. This fixes -[WebPluginDatabase isMIMETypeRegistered:] and thus fallback content for Java applets
402 (we were always rendering fallback content, if any, for Java applets).
404 2006-08-29 Sam Weinig <sam.weinig@gmail.com>
408 - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10628
409 Auto-generate the remaining Objective-C DOM bindings
411 Auto-generates DOMHTMLCollection, DOMHTMLElement, DOMHTMLFormElement,
412 and DOMHTMLOptionsCollection.
414 * WebKit.xcodeproj/project.pbxproj:
416 2006-08-28 Brady Eidson <beidson@apple.com>
420 Short of a few small snippets that still need to be pushed to WebCore, this
421 is a final prune of WebIconDatabase. WebFileDatabase and WebLRUFileList are gone
422 and the small remaining snippets of WebFileDatabase code that were still important
423 are now in static functions in WebIconDatabase.m
425 * Loader/WebIconLoader.m:
426 (-[WebIconLoader didFinishLoading]): Removed the flag
427 * Misc/WebFileDatabase.h: Removed.
428 * Misc/WebFileDatabase.m: Removed.
429 * Misc/WebIconDatabase.m:
430 (+[WebIconDatabase sharedIconDatabase]):
431 (-[WebIconDatabase init]):
432 (-[WebIconDatabase iconForURL:withSize:cache:]):
433 (-[WebIconDatabase iconURLForURL:]):
434 (-[WebIconDatabase defaultIconWithSize:]):
435 (-[WebIconDatabase retainIconForURL:]):
436 (-[WebIconDatabase releaseIconForURL:]):
437 (-[WebIconDatabase _isEnabled]):
438 (-[WebIconDatabase _setIconData:forIconURL:]):
439 (-[WebIconDatabase _setHaveNoIconForIconURL:]):
440 (-[WebIconDatabase _setIconURL:forURL:]):
441 (-[WebIconDatabase _hasEntryForIconURL:]):
442 (-[WebIconDatabase _applicationWillTerminate:]):
443 (-[WebIconDatabase _resetCachedWebPreferences:]):
444 (uniqueFilePathForKey): Added from WebFileDatabase
445 (objectFromPathForKey): Added from WebFileDatabase
446 (iconDataFromPathForIconURL):
447 (-[WebIconDatabase _convertToWebCoreFormat]): Make use of static functions and local variables
448 instead of using WebFileDatabase and WebIconDatabase variables that are now obsolete
449 * Misc/WebIconDatabasePrivate.h: Removed alot of obsoleted members
450 * Misc/WebLRUFileList.h: Removed.
451 * Misc/WebLRUFileList.m: Removed.
452 * WebKit.xcodeproj/project.pbxproj: Deleted 4 files
453 * WebKitPrefix.h: Removed ICONDEBUG
455 2006-08-28 Tim Omernick <timo@apple.com>
457 Reviewed by Darin Adler.
459 * Plugins/WebBaseNetscapePluginView.m:
460 (-[WebBaseNetscapePluginView createPluginScriptableObject]):
461 Removed a bogus typecast.
463 2006-08-28 Tim Omernick <timo@apple.com>
465 Reviewed by John Sullivan.
467 Part of <rdar://problem/4481553> NetscapeMoviePlugIn example code scripting doesn't work in Firefox (4319)
468 <http://bugzilla.opendarwin.org/show_bug.cgi?id=4319>: NetscapeMoviePlugIn example code scripting doesn't work
471 * Plugins/WebBaseNetscapePluginView.h:
472 * Plugins/WebBaseNetscapePluginView.m:
473 (-[WebBaseNetscapePluginView createPluginScriptableObject]):
474 Renamed this method (see corresponding WebCore ChangeLog entry for an explanation).
477 2006-08-28 Brady Eidson <beidson@apple.com>
479 Reviewed by Tim Hatcher's rubberstamp
481 Rolled out my last change (16070 - pruning WebFileDatabase code) as it caused a difficult-to-track down
482 failure in layout tests on a release build.
484 * Misc/WebFileDatabase.h:
485 * Misc/WebFileDatabase.m:
486 (+[WebFileDatabaseOp opWithCode:key:object:]):
487 (-[WebFileDatabaseOp initWithCode:key:object:]):
488 (-[WebFileDatabaseOp opcode]):
489 (-[WebFileDatabaseOp key]):
490 (-[WebFileDatabaseOp object]):
491 (-[WebFileDatabaseOp perform:]):
492 (-[WebFileDatabaseOp dealloc]):
494 (-[WebFileDatabase _createLRUList:]):
495 (-[WebFileDatabase _truncateToSizeLimit:]):
496 (+[WebFileDatabase _syncLoop:]):
498 (-[WebFileDatabase setTimer]):
499 (-[WebFileDatabase setObject:forKey:]):
500 (-[WebFileDatabase removeObjectForKey:]):
501 (-[WebFileDatabase removeAllObjects]):
502 (-[WebFileDatabase objectForKey:]):
503 (-[WebFileDatabase performSetObject:forKey:]):
504 (-[WebFileDatabase performRemoveObjectForKey:]):
505 (-[WebFileDatabase open]):
506 (-[WebFileDatabase close]):
507 (-[WebFileDatabase lazySync:]):
508 (-[WebFileDatabase sync]):
509 (-[WebFileDatabase sizeLimit]):
510 (-[WebFileDatabase count]):
511 (-[WebFileDatabase usage]):
512 (-[WebFileDatabase setSizeLimit:]):
513 * Misc/WebIconDatabase.m:
514 (-[WebIconDatabase _createFileDatabase]):
515 (-[WebIconDatabase _loadIconDictionaries]):
516 * WebKit.xcodeproj/project.pbxproj:
518 2006-08-28 Darin Adler <darin@apple.com>
520 Reviewed by Tim Hatcher.
522 * WebInspector/webInspector/inspector.js: Add "resize: none" to the list of
523 default values for CSS properties so it will be omitted from most displays
526 2006-08-28 Brady Eidson <beidson@apple.com>
530 Major prune of unnecessary WebFileDatabase code. In the end, what
531 useful code that remains in WebFileDatabase will likely be moved directly
534 * Misc/WebFileDatabase.h:
535 * Misc/WebFileDatabase.m:
536 (-[WebFileDatabase initWithPath:]):
537 (-[WebFileDatabase objectForKey:]):
538 (-[WebFileDatabase open]):
539 (-[WebFileDatabase close]):
540 * Misc/WebIconDatabase.m:
541 (-[WebIconDatabase _createFileDatabase]):
542 (-[WebIconDatabase _loadIconDictionaries]):
543 * Misc/WebLRUFileList.h: Removed.
544 * Misc/WebLRUFileList.m: Removed.
545 * WebKit.xcodeproj/project.pbxproj:
547 2006-08-27 Sam Weinig <sam.weinig@gmail.com>
551 - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=4624
552 WebCore needs autogenerated Obj-C DOM bindings
554 First round of auto-generated Objective C DOM bindings, starting
557 * WebKit.xcodeproj/project.pbxproj:
559 2006-08-25 Brady Eidson <beidson@apple.com>
561 Reviewed by Tim Hatcher
563 Fixed up some leaks on [WebIconDatabase init]
565 * Misc/WebIconDatabase.m:
566 (-[WebIconDatabase init]):
568 2006-08-24 Timothy Hatcher <timothy@apple.com>
572 * WebView/WebFrame.m:
573 (-[WebFrame _updateBackground]): reworded the comment about scroll view and setDrawsBackground:YES
575 (-[WebViewPrivate dealloc]): release the background color
577 2006-08-24 Timothy Hatcher <timothy@apple.com>
581 WebView API to allow changing the background color that draws under transparent page backgrounds.
583 * WebView/WebFrame.m:
584 (-[WebFrame _makeDocumentView]):
585 (-[WebFrame _updateBackground]):
586 * WebView/WebFrameInternal.h:
587 * WebView/WebFrameView.m:
588 (-[WebFrameView drawRect:]):
590 (-[WebView setBackgroundColor:]):
591 (-[WebView backgroundColor]):
592 (-[WebView _commonInitializationWithFrameName:groupName:]):
593 (-[WebView setDrawsBackground:]):
594 * WebView/WebViewPrivate.h:
596 2006-08-24 Timothy Hatcher <timothy@apple.com>
600 Fix for Mail stationary. Selecting a stationary item would cause this exception.
601 *** -[WebSubresourceLoader copyWithZone:]: selector not recognized
602 Uncaught exception - *** -[WebSubresourceLoader copyWithZone:]: selector not recognized
604 * Loader/WebFrameLoader.m:
605 (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
606 Use _webkit_setObject:forUncopiedKey: when addign the resource to pendingArchivedResources.
608 2006-08-23 Maciej Stachowiak <mjs@apple.com>
612 - fix assertion which I accidentally changed to one that sometimes fails
613 http://bugzilla.opendarwin.org/show_bug.cgi?id=10531
615 * Loader/WebDocumentLoadState.m:
616 (-[WebDocumentLoadState dealloc]):
617 * WebView/WebDataSource.m:
618 (-[WebDataSourcePrivate dealloc]):
619 (-[WebDataSource dealloc]):
621 2006-08-23 Maciej Stachowiak <mjs@apple.com>
625 - move WebFrame code that creates WebDataSources down to WebFrameLoader, in preparation
626 for WebFrameLoader just holding on to WebDocumentLoadState
628 * Loader/WebFrameLoader.h:
629 * Loader/WebFrameLoader.m:
630 (-[WebFrameLoader _loadRequest:archive:]):
631 (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
632 (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]):
633 (-[WebFrameLoader reload]):
634 * WebView/WebFrame.m:
635 (-[WebFrame _loadItem:withLoadType:]):
636 (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
637 (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
638 (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
639 (-[WebFrame _shouldReloadToHandleUnreachableURLFromRequest:]):
640 (-[WebFrame loadRequest:]):
641 (-[WebFrame loadArchive:]):
642 (-[WebFrame reload]):
643 * WebView/WebFrameInternal.h:
644 * WebView/WebFramePrivate.h:
646 (-[WebView setCustomTextEncodingName:]):
648 2006-08-23 Brady Eidson <beidson@apple.com>
652 First pass at pruning unused WebIconDatabase code. Focus on removing methods that simply
653 have no place in the new DB at all. A few renames and a few important FIXMEs result, but no
654 functionality changes.
656 * Loader/WebIconLoader.m:
657 (-[WebIconLoader didFinishLoading]): Call to WebIconDatabase instead of directly to the bridge
658 * Misc/WebIconDatabase.h:
659 * Misc/WebIconDatabase.m:
660 (-[WebIconDatabase init]):
661 (-[WebIconDatabase iconForURL:withSize:cache:]):
662 (-[WebIconDatabase iconURLForURL:]):
663 (-[WebIconDatabase defaultIconWithSize:]):
664 (-[WebIconDatabase retainIconForURL:]):
665 (-[WebIconDatabase releaseIconForURL:]):
666 (-[WebIconDatabase removeAllIcons]):
667 (-[WebIconDatabase _setIconData:forIconURL:]):
668 (-[WebIconDatabase _setHaveNoIconForIconURL:]):
669 (-[WebIconDatabase _setIconURL:forURL:]):
670 (-[WebIconDatabase _hasEntryForIconURL:]):
671 (-[WebIconDatabase _applicationWillTerminate:]):
672 (-[WebIconDatabase _resetCachedWebPreferences:]):
673 * Misc/WebIconDatabasePrivate.h: Changed setIcon: to setIconData:
675 2006-08-23 Maciej Stachowiak <mjs@apple.com>
679 - started factoring most of the guts of WebDataSource into a new class
681 WebDocumentLoadState is decoupled from the rest of WebKit and will
682 be moved down to WebCore. I only moved one of the data fields of
683 WebDataSource for now.
685 * Loader/WebDocumentLoadState.h: Added.
686 * Loader/WebDocumentLoadState.m: Added.
687 (-[WebDocumentLoadState initWithRequest:]): New class.
688 (-[WebDocumentLoadState dealloc]):
689 (-[WebDocumentLoadState setFrameLoader:]):
690 (-[WebDocumentLoadState setMainResourceData:]):
691 (-[WebDocumentLoadState mainResourceData]):
692 * Loader/WebFrameLoader.m:
693 (-[WebFrameLoader _setDataSource:]): Remove redundant _setWebFrame: call,
694 it would have been called already by this point.
695 (-[WebFrameLoader _setProvisionalDataSource:]): ditto.
696 * WebKit.xcodeproj/project.pbxproj:
697 * WebView/WebDataSource.m:
698 (-[WebDataSourcePrivate dealloc]):
699 (-[WebDataSource _setWebFrame:]):
700 (-[WebDataSource _setPrimaryLoadComplete:]):
701 (-[WebDataSource initWithRequest:]):
702 (-[WebDataSource data]):
704 2006-08-23 Maciej Stachowiak <mjs@apple.com>
708 - refactoring of WebDataSource in preparation for moving a bunch of it to a new class
710 - minimize WebDataSourceInternal.h to be only methods called from outside WebDataSource
711 - reduce Private category implementation to be only the SPI methods
712 - make new Internal and FileInternal categories which contain the
713 remainder (depending on whether they are called from outside of
716 * WebView/WebDataSource.m:
717 (-[WebDataSource _setMainDocumentError:]):
719 (+[WebDataSource _representationClassForMIMEType:]):
720 (-[WebDataSource _commitIfReady]):
721 (-[WebDataSource _commitLoadWithData:]):
722 (-[WebDataSource _doesProgressiveLoadWithMIMEType:]):
723 (-[WebDataSource _addResponse:]):
724 (-[WebDataSource _revertToProvisionalState]):
725 (-[WebDataSource _mainDocumentError]):
726 (-[WebDataSource _addSubframeArchives:]):
727 (-[WebDataSource _fileWrapperForURL:]):
728 (+[WebDataSource _repTypesAllowImageTypeOmission:]):
729 (-[WebDataSource _decidePolicyForMIMEType:decisionListener:]):
730 (-[WebDataSource _finishedLoading]):
731 (-[WebDataSource _setResponse:]):
732 (-[WebDataSource _setRequest:]):
733 (-[WebDataSource _setupForReplaceByMIMEType:]):
734 (-[WebDataSource _receivedMainResourceError:complete:]):
735 (-[WebDataSource _mainReceivedError:complete:]):
736 (-[WebDataSource _defersCallbacks]):
737 (-[WebDataSource _downloadWithLoadingConnection:request:response:proxy:]):
738 (-[WebDataSource _didFailLoadingWithError:forResource:]):
739 (-[WebDataSource _didFinishLoadingForResource:]):
740 (-[WebDataSource _didReceiveData:contentLength:forResource:]):
741 (-[WebDataSource _didReceiveResponse:forResource:]):
742 (-[WebDataSource _didCancelAuthenticationChallenge:forResource:]):
743 (-[WebDataSource _didReceiveAuthenticationChallenge:forResource:]):
744 (-[WebDataSource _willSendRequest:forResource:redirectResponse:]):
745 (-[WebDataSource _identifierForInitialRequest:]):
746 (-[WebDataSource _archivedSubresourceForURL:]):
747 (-[WebDataSource _startLoading]):
748 (-[WebDataSource _stopRecordingResponses]):
749 (-[WebDataSource _loadingStartedTime]):
750 (-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]):
751 (-[WebDataSource _documentFragmentWithArchive:]):
752 (-[WebDataSource _documentFragmentWithImageResource:]):
753 (-[WebDataSource _imageElementWithImageResource:]):
754 (-[WebDataSource _title]):
755 (-[WebDataSource _isStopping]):
756 (-[WebDataSource _setWebFrame:]):
757 (-[WebDataSource _URL]):
758 (-[WebDataSource _loadFromPageCache:]):
759 (-[WebDataSource _popSubframeArchiveWithName:]):
760 (-[WebDataSource _setIsClientRedirect:]):
761 (-[WebDataSource _setURL:]):
762 (-[WebDataSource _setLastCheckedRequest:]):
763 (-[WebDataSource _defersCallbacksChanged]):
764 (-[WebDataSource _lastCheckedRequest]):
765 (-[WebDataSource _stopLoading]):
766 (-[WebDataSource _bridge]):
767 (-[WebDataSource _webView]):
768 (-[WebDataSource _triggeringAction]):
769 (-[WebDataSource _setTriggeringAction:]):
770 (-[WebDataSource __adoptRequest:]):
771 (-[WebDataSource _isDocumentHTML]):
772 (-[WebDataSource _stopLoadingWithError:]):
773 (-[WebDataSource _setPrimaryLoadComplete:]):
774 (-[WebDataSource _responses]):
775 (-[WebDataSource _makeRepresentation]):
776 (-[WebDataSource _isClientRedirect]):
777 (-[WebDataSource _originalRequest]):
778 (-[WebDataSource _URLForHistory]):
779 (-[WebDataSource _addToUnarchiveState:]):
780 (-[WebDataSource _setOverrideEncoding:]):
781 (-[WebDataSource _setIconURL:]):
782 (-[WebDataSource _setIconURL:withType:]):
783 (-[WebDataSource _overrideEncoding]):
784 (-[WebDataSource _setTitle:]):
785 * WebView/WebDataSourceInternal.h:
787 2006-08-23 Brady Eidson <beidson@apple.com>
789 Reviewed by John Sullivan
792 Flip the switch to the new Icon Database
793 Massive code pruning is coming up
795 * WebKitPrefix.h: Flipped the switch
797 2006-08-23 Brady Eidson <beidson@apple.com>
800 Since I just pushed the default URL icon from WebKit to WebCore, but
801 WebKit was still using its version of the default icon, this patch makes it
802 use the WebCore version
804 * Misc/WebIconDatabase.m:
805 (-[WebIconDatabase defaultIconWithSize:]):
807 2006-08-22 Maciej Stachowiak <mjs@apple.com>
811 - remove "loading" flag from WebDataSource and code that manages it; it is redundat.
813 * Loader/WebFrameLoader.m:
814 (-[WebFrameLoader addPlugInStreamLoader:]):
815 (-[WebFrameLoader removePlugInStreamLoader:]):
816 (-[WebFrameLoader addSubresourceLoader:]):
817 (-[WebFrameLoader removeSubresourceLoader:]):
818 * WebView/WebDataSource.m:
819 (-[WebDataSourcePrivate dealloc]):
820 (-[WebDataSource _setPrimaryLoadComplete:]):
821 (-[WebDataSource _stopLoading]):
822 (-[WebDataSource _prepareForLoadStart]):
823 (-[WebDataSource _startLoading]):
824 (-[WebDataSource isLoading]):
825 * WebView/WebDataSourceInternal.h:
827 2006-08-22 Maciej Stachowiak <mjs@apple.com>
831 <rdar://problem/4683948> REGRESSION: Assertion failure in [FrameProgressEntry addChild:forDataSource:] (fandango.com)
833 * Loader/WebFrameLoader.m:
834 (-[WebFrameLoader addSubresourceLoader:]): Add a WebKit-level assertion that should fire when this bad
836 * Loader/WebSubresourceLoader.m:
837 (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]): Prevent
838 the situation from occuring.
840 2006-08-22 Maciej Stachowiak <mjs@apple.com>
844 - pull more WebDataSource code into WebFrameLoader
845 - make WebMainResourceLoader not depend on WebKit or on SPI
847 * Loader/WebFrameLoader.h:
848 * Loader/WebFrameLoader.m:
849 (-[WebFrameLoader _downloadWithLoadingConnection:request:response:proxy:]):
850 (-[WebFrameLoader _updateIconDatabaseWithURL:]):
851 (-[WebFrameLoader _notifyIconChanged:]):
852 (-[WebFrameLoader _iconLoaderReceivedPageIcon:]):
853 (-[WebFrameLoader _checkNavigationPolicyForRequest:andCall:withSelector:]):
854 (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]):
855 (-[WebFrameLoader cancelContentPolicy]):
856 * Loader/WebIconLoader.m:
857 (-[WebIconLoader didFinishLoading]):
858 * Loader/WebLoader.m:
859 (-[NSURLProtocol loadWithRequest:]):
860 (-[NSURLProtocol setDefersCallbacks:]):
861 * Loader/WebMainResourceLoader.h:
862 * Loader/WebMainResourceLoader.m:
863 (-[WebMainResourceLoader initWithFrameLoader:]):
864 (-[WebMainResourceLoader dealloc]):
865 (-[WebMainResourceLoader cancelWithError:]):
866 (-[WebMainResourceLoader continueAfterNavigationPolicy:formState:]):
867 (-[WebMainResourceLoader willSendRequest:redirectResponse:]):
868 (-[WebMainResourceLoader continueAfterContentPolicy:]):
869 (-[WebMainResourceLoader checkContentPolicy]):
870 (-[WebMainResourceLoader didReceiveResponse:]):
871 * Plugins/WebPluginContainerCheck.m:
872 * WebCoreSupport/WebSystemInterface.m:
873 (InitWebCoreSystemInterface):
874 * WebView/WebDataSource.m:
875 (-[WebDataSource _loadIcon]):
876 (-[WebDataSource _cancelledError]):
877 (+[WebDataSource _repTypesAllowImageTypeOmission:]):
878 (+[WebDataSource _representationClassForMIMEType:]):
879 (-[WebDataSource _commitLoadWithData:]):
880 (-[WebDataSource _isDocumentHTML]):
881 * WebView/WebDataSourceInternal.h:
882 * WebView/WebFramePrivate.h:
883 * WebView/WebPolicyDelegate.m:
884 * WebView/WebPolicyDelegatePrivate.h:
886 2006-08-21 Maciej Stachowiak <mjs@apple.com>
890 - move more code from WebDataSource to WebFrameLoader
892 Also marked a few more methods in WebDataSource as likely MOVABLE in a future round, since they do not
893 use any of WebDataSource's private data.
895 * Loader/WebFrameLoader.h:
896 * Loader/WebFrameLoader.m:
897 (-[WebFrameLoader addPlugInStreamLoader:]):
898 (-[WebFrameLoader removePlugInStreamLoader:]):
899 (-[WebFrameLoader addSubresourceLoader:]):
900 (-[WebFrameLoader removeSubresourceLoader:]):
901 (-[WebFrameLoader _didReceiveAuthenticationChallenge:forResource:]):
902 (-[WebFrameLoader _didCancelAuthenticationChallenge:forResource:]):
903 (-[WebFrameLoader _didReceiveResponse:forResource:]):
904 (-[WebFrameLoader _didReceiveData:contentLength:forResource:]):
905 (-[WebFrameLoader _didFinishLoadingForResource:]):
906 (-[WebFrameLoader _didFailLoadingWithError:forResource:]):
907 (-[WebFrameLoader _privateBrowsingEnabled]):
908 (-[WebFrameLoader _finishedLoadingResource]):
909 (-[WebFrameLoader _receivedError:]):
910 (-[WebFrameLoader _finishedLoading]):
911 * Loader/WebMainResourceLoader.m:
912 (-[WebMainResourceLoader didReceiveData:lengthReceived:allAtOnce:]):
913 (-[WebMainResourceLoader didFinishLoading]):
914 * Loader/WebNetscapePlugInStreamLoader.m:
915 (-[WebNetscapePlugInStreamLoader didFinishLoading]):
916 (-[WebNetscapePlugInStreamLoader didFailWithError:]):
917 (-[WebNetscapePlugInStreamLoader cancelWithError:]):
918 * Loader/WebSubresourceLoader.m:
919 (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]):
920 (-[WebSubresourceLoader signalFinish]):
921 (-[WebSubresourceLoader didFailWithError:]):
922 (-[WebSubresourceLoader cancel]):
923 * Plugins/WebNetscapePluginStream.m:
924 (-[WebNetscapePluginStream start]):
925 * WebView/WebDataSource.m:
926 (-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]):
927 (-[WebDataSource _updateIconDatabaseWithURL:]):
928 (-[WebDataSource _loadIcon]):
929 (-[WebDataSource _setPrimaryLoadComplete:]):
930 (-[WebDataSource _cancelledError]):
931 (+[WebDataSource _repTypesAllowImageTypeOmission:]):
932 (+[WebDataSource _representationClassForMIMEType:]):
933 (-[WebDataSource _commitLoadWithData:]):
934 (-[WebDataSource _receivedMainResourceError:complete:]):
935 (-[WebDataSource _iconLoaderReceivedPageIcon:]):
936 (-[WebDataSource _isDocumentHTML]):
937 * WebView/WebDataSourceInternal.h:
939 2006-08-21 Brady Eidson <beidson@apple.com>
943 Quick ICONDEBUG flag fix
945 * Misc/WebIconDatabase.m:
946 (-[WebIconDatabase _applicationWillTerminate:]):
948 2006-08-21 Brady Eidson <beidson@apple.com>
952 -Renamed an internal only method for clarity
953 -Tweaked WebDataSource for notification purposes with the new expiring icons
954 -Fixed a bug with the ICONDEBUG flag
956 * Misc/WebIconDatabase.m:
957 (-[WebIconDatabase init]):
958 (-[WebIconDatabase iconForURL:withSize:cache:]): #ifdef bug fixed
959 (-[WebIconDatabase _hasEntryForIconURL:]): Renamed for clarity
960 * Misc/WebIconDatabasePrivate.h:
961 * WebView/WebDataSource.m:
962 (-[WebDataSource _updateIconDatabaseWithURL:]):
963 (-[WebDataSource _notifyIconChanged:]):
964 (-[WebDataSource _loadIcon]):
965 (-[WebDataSource _iconLoaderReceivedPageIcon:]):
967 2006-08-17 Maciej Stachowiak <mjs@apple.com>
971 - pull a bit of WebDataSource code into WebFrameLoader
973 * Loader/WebFrameLoader.m:
974 (-[WebFrameLoader _receivedError:]):
975 (-[WebFrameLoader webFrame]):
976 (-[WebFrameLoader _handleFallbackContent]):
977 (+[WebFrameLoader _canShowMIMEType:]):
978 (+[WebFrameLoader _representationExistsForURLScheme:]):
979 (+[WebFrameLoader _generatedMIMETypeForURLScheme:]):
980 * WebView/WebDataSource.m:
981 * WebView/WebDataSourceInternal.h:
983 2006-08-17 Timothy Hatcher <timothy@apple.com>
985 Reviewed by Kevin Decker.
987 <rdar://problem/4606857> WebKit: WebPreferencesChangedNotification not exported in 64-bit
991 2006-08-17 Timothy Hatcher <timothy@apple.com>
993 Reviewed by Kevin Decker.
995 <rdar://problem/4633896> -[WebView close] should clear all delegates and call setHostWindow:nil
996 <rdar://problem/4649759> Crash when selecting View Source menu using Chinese (-[WebView _close])
998 Check to make sure _private is not null. A WebView can be dealloced before _private is setup.
999 Set the _private->closed flag at the beginning of _close to prevent reentry.
1000 Set the host window and all the delegates to nil in _close.
1002 * WebView/WebView.m:
1003 (-[WebView _close]):
1005 2006-08-16 Brady Eidson <beidson@apple.com>
1009 * Misc/WebIconDatabase.m: Pruned unused method
1010 * Misc/WebIconDatabasePrivate.h: Ditto
1013 2006-08-15 Maciej Stachowiak <mjs@apple.com>
1015 Reviewed by Adele (preliminary version) and later by Kevin.
1017 - remove most WebKit dependencies from WebMainResourceLoader.
1019 * Loader/WebFrameLoader.h:
1020 * Loader/WebFrameLoader.m:
1021 (-[WebFrameLoader cannotShowMIMETypeForURL:]):
1022 (-[WebFrameLoader interruptForPolicyChangeErrorWithRequest:]):
1023 (-[WebFrameLoader isHostedByObjectElement]):
1024 (-[WebFrameLoader isLoadingMainFrame]):
1025 (+[WebFrameLoader _canShowMIMEType:]):
1026 (+[WebFrameLoader _representationExistsForURLScheme:]):
1027 (+[WebFrameLoader _generatedMIMETypeForURLScheme:]):
1028 * Loader/WebMainResourceLoader.h:
1029 * Loader/WebMainResourceLoader.m:
1030 (-[WebMainResourceLoader interruptForPolicyChangeError]):
1031 (-[WebMainResourceLoader willSendRequest:redirectResponse:]):
1032 (isCaseInsensitiveEqual):
1033 (shouldLoadAsEmptyDocument):
1034 (-[WebMainResourceLoader continueAfterContentPolicy:response:]):
1035 (-[WebMainResourceLoader didReceiveResponse:]):
1036 (-[WebMainResourceLoader didReceiveData:lengthReceived:allAtOnce:]):
1037 (-[WebMainResourceLoader didFinishLoading]):
1038 (-[WebMainResourceLoader loadWithRequestNow:]):
1039 (-[WebMainResourceLoader loadWithRequest:]):
1041 2006-08-15 Tim Omernick <timo@apple.com>
1043 Reviewed by Kevin Decker.
1045 * Plugins/WebNetscapePluginPackage.m:
1046 (-[WebNetscapePluginPackage _unloadWithShutdown:]):
1047 Fixed a subtle problem with the 64-bit debug build -- as written, this would LOG() on 64-bit and do nothing on
1049 * Plugins/WebPluginDatabase.m:
1050 (-[WebPluginDatabase _scanForNewPlugins]):
1051 Use +[NSMutableSet set] here.
1053 2006-08-15 Tim Omernick <timo@apple.com>
1055 Reviewed by Darin Adler.
1057 <http://bugzilla.opendarwin.org/show_bug.cgi?id=8980>
1058 ASSERTION FAILED: !isLoaded (WebKit/WebKit/Plugins/WebBasePluginPackage.m:228 -[WebBasePluginPackage dealloc])
1060 <rdar://problem/4526052> intermittent assertion failure in -[WebBasePluginPackage dealloc] running layout tests (8980)
1062 * Plugins/WebPluginDatabase.h:
1063 * Plugins/WebPluginDatabase.m:
1064 (+[WebPluginDatabase installedPlugins]):
1065 Observe NSApplicationWillTerminateNotification so we can unload plug-ins on quit.
1066 (-[WebPluginDatabase plugins]):
1067 'plugins' is now a dictionary.
1068 (-[WebPluginDatabase close]):
1069 Call new -_removePlugin: method.
1070 (-[WebPluginDatabase refresh]):
1071 Moved parts of this method out into other methods: -_addPlugin:, -_removePlugin:, and -_scanForNewPlugins.
1072 (-[WebPluginDatabase _plugInPaths]):
1073 No changes; just moved in file.
1074 (-[WebPluginDatabase _addPlugin:]):
1075 New method. Refactored from -refresh. Adds a plug-in to the database.
1076 (-[WebPluginDatabase _removePlugin:]):
1077 New method. Refactored from -refresh. Remove a plug-in from the database.
1078 (-[WebPluginDatabase _scanForNewPlugins]):
1079 New method. Refactored from -refresh. Returns the list of plug-in packages on disk.
1080 (-[WebPluginDatabase _applicationWillTerminate]):
1081 New method. Called when the application terminates. Closes the plug-in database so that all plug-ins are
1082 removed from the DB (and unloaded if necessary).
1084 * Plugins/WebBasePluginPackage.h:
1085 * Plugins/WebBasePluginPackage.m:
1086 (-[WebBasePluginPackage initWithPath:]):
1087 Try to create the NSBundle first, so if the file is not a valid bundle we bail out early. This
1088 avoids some stat()s and allocations during the plug-in refresh process.
1089 (-[WebBasePluginPackage isLoaded]):
1091 (-[WebBasePluginPackage load]):
1092 Base class for plug-in packages now always loads "successfully".
1093 (-[WebBasePluginPackage dealloc]):
1094 Removed this assertion. The base plug-in package class has no concept of
1096 (-[WebBasePluginPackage finalize]):
1098 (-[WebBasePluginPackage wasRemovedFromPluginDatabase:]):
1099 Moved code to unload plug-in package to WebNetscapePluginPackage. Not all plug-in
1100 packages can be "unloaded".
1102 * Plugins/WebNetscapePluginPackage.h:
1103 * Plugins/WebNetscapePluginPackage.m:
1104 (-[WebNetscapePluginPackage _unloadWithShutdown:]):
1105 Combined old -unload and -unloadWithoutShutdown methods into this new one.
1106 (-[WebNetscapePluginPackage initWithPath:]):
1107 Call new unload method.
1108 (-[WebNetscapePluginPackage load]):
1110 (-[WebNetscapePluginPackage wasRemovedFromPluginDatabase:]):
1112 (-[WebNetscapePluginPackage open]):
1113 New method. Called when a plug-in instance starts running.
1114 (-[WebNetscapePluginPackage close]):
1115 New method. Called when a plug-in instance stops running. When all plug-in instances
1116 close the plug-in package, and the plug-in package is removed from the database, the plug-in
1119 * Plugins/WebPluginPackage.m:
1120 (-[WebPluginPackage initWithPath:]):
1121 (-[WebPluginPackage load]):
1122 Made this a bit more efficient by checking if the bundle is already loaded.
1123 (-[WebBasePluginPackage unload]):
1125 (-[WebBasePluginPackage isLoaded]):
1128 * Plugins/WebBaseNetscapePluginView.m:
1129 (-[WebBaseNetscapePluginView start]):
1130 Open the plug-in package so it remains loaded while this instance uses it.
1131 (-[WebBaseNetscapePluginView stop]):
1132 Close the plug-in package when the plug-in instance is stopped.
1134 * Plugins/WebBaseNetscapePluginStream.m:
1135 (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:]):
1136 This check is not necessary. Netscape plug-in packages are never unloaded until all their instances have
1137 been stopped, and a Netscape plug-in instance will stop its streams when it is stopped.
1138 (-[WebBaseNetscapePluginStream _destroyStream]):
1140 (-[WebBaseNetscapePluginStream finishedLoadingWithData:]):
1142 (-[WebBaseNetscapePluginStream _deliverData]):
1145 2006-08-15 Mark Rowe <opendarwin.org@bdash.net.nz>
1149 Build fix: DWARF and -gfull are incompatible with symbol separation.
1151 * WebKit.xcodeproj/project.pbxproj:
1153 2006-08-15 Mark Rowe <opendarwin.org@bdash.net.nz>
1157 http://bugzilla.opendarwin.org/show_bug.cgi?id=10394
1158 Bug 10394: WebKit Release and Production configurations should enable dead code stripping
1160 * WebKit.xcodeproj/project.pbxproj:
1162 2006-08-15 Maciej Stachowiak <mjs@apple.com>
1166 - remove WebKit dependencies from WebPlugInStreamLoader via a protocol veil of ignorance
1168 * Loader/WebNetscapePlugInStreamLoader.h:
1169 * Loader/WebNetscapePlugInStreamLoader.m:
1170 (-[WebNetscapePlugInStreamLoader initWithDelegate:frameLoader:]):
1171 * Loader/WebPlugInStreamLoaderDelegate.h: Added.
1172 * Plugins/WebBaseNetscapePluginStream.h:
1173 * Plugins/WebNetscapePluginStream.m:
1174 (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]):
1175 * WebKit.xcodeproj/project.pbxproj:
1177 2006-08-15 Mark Rowe <opendarwin.org@bdash.net.nz>
1181 http://bugzilla.opendarwin.org/show_bug.cgi?id=10384
1182 Bug 10384: Switch to DWARF for Release configuration
1184 * WebKit.xcodeproj/project.pbxproj:
1186 2006-08-15 Graham Dennis <graham.dennis@gmail.com>
1190 - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10314
1191 WebUnarchivingState archivedResourceForURL: doesn't work
1193 * WebView/WebUnarchivingState.m:
1194 (-[WebUnarchivingState archivedResourceForURL:]):
1195 Fixed to get objects from the archived resources dictionary using
1196 the URL as a string instead of as the URL itself (as this is how
1197 the data is put into the dictionary).
1199 2006-08-14 Maciej Stachowiak <mjs@apple.com>
1203 - remove many (but not all) WebKit dependencies from WebNetscapePlugInStreamLoader (it still
1204 depends on WebNetscapePluginStream).
1206 * Loader/WebFrameLoader.h:
1207 * Loader/WebFrameLoader.m:
1208 (-[WebFrameLoader fileDoesNotExistErrorWithResponse:]):
1209 * Loader/WebNetscapePlugInStreamLoader.h:
1210 * Loader/WebNetscapePlugInStreamLoader.m:
1211 (-[WebNetscapePlugInStreamLoader initWithStream:frameLoader:]):
1212 (-[WebNetscapePlugInStreamLoader releaseResources]):
1213 (-[WebNetscapePlugInStreamLoader didReceiveResponse:]):
1214 * Plugins/WebNetscapePluginStream.m:
1215 (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]):
1217 2006-08-14 Maciej Stachowiak <mjs@apple.com>
1219 Reviewed by Tim Omernick.
1221 - fixed REGRESSION: crash when leaving youtube page while movie is still loading
1222 http://bugzilla.opendarwin.org/show_bug.cgi?id=10398
1224 * Loader/WebNetscapePlugInStreamLoader.m:
1225 (-[WebNetscapePlugInStreamLoader initWithStream:view:]): Set the frame loader for this stream.
1226 (-[WebNetscapePlugInStreamLoader cancelWithError:]): Make sure to destroy the stream as well;
1227 otherwise, when we try to clean up later, we won't have the right context.
1229 2006-08-14 David Hyatt <hyatt@apple.com>
1231 Fix for Radar bug 4478840, Safari should not reduce null events sent to
1232 plug-ins in windows that are inactive but visible.
1234 With this fix you can view videos in visible background windows on YouTube
1235 (for example) and not see any drop in frame rate.
1239 * Plugins/WebBaseNetscapePluginView.m:
1240 (-[WebBaseNetscapePluginView restartNullEvents]):
1242 2006-08-14 Maciej Stachowiak <mjs@apple.com>
1246 - removed WebKit-level dependencies from WebFormDataStream. Use WebCore version of system interface
1248 * Loader/WebFormDataStream.m:
1250 (formEventCallback):
1252 * WebCoreSupport/WebSystemInterface.m:
1253 (InitWebCoreSystemInterface):
1255 2006-08-14 Maciej Stachowiak <mjs@apple.com>
1257 Rubber stamped by Brady.
1259 - move WebFormDataStream from WebView to Loader
1261 * WebKit.xcodeproj/project.pbxproj:
1262 * WebView/WebFormDataStream.h: Removed.
1263 * WebView/WebFormDataStream.m: Removed.
1265 2006-08-13 Maciej Stachowiak <mjs@apple.com>
1269 - remove WebKit dependencies from WebSubresourceLoader, except WebFormDataStream
1271 (WebFormDataStream will be moved into the Loader directory soon)
1273 * Loader/WebFrameLoader.h:
1274 * Loader/WebFrameLoader.m:
1275 (-[WebFrameLoader _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
1276 * Loader/WebSubresourceLoader.m:
1277 (isConditionalRequest):
1278 (hasCaseInsensitivePrefix):
1281 (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]):
1283 2006-08-13 Brady Eidson <beidson@apple.com>
1287 Relocated the WebIconLoaders
1289 * Misc/WebIconLoader.h: Moved to Loader/
1290 * Misc/WebIconLoader.m: Moved to Loader/
1291 * WebKit.xcodeproj/project.pbxproj:
1293 2006-08-13 Maciej Stachowiak <mjs@apple.com>
1297 - removed non-Loader WebKit dependencies from WebDataProtocol for
1298 real (whoops) and fix some typos.
1300 * Loader/WebDataProtocol.m:
1301 (isCaseInsensitiveEqual): Added.
1302 (+[WebDataProtocol _webIsDataProtocolURL:]): Avoid WebKit calls.
1303 (-[WebDataProtocol startLoading]): ditto
1304 * Loader/WebFrameLoader.m:
1305 (isCaseInsensitiveEqual): Fixed spelling from isCaseSensitiveEqual.
1306 (-[WebFrameLoader _canUseResourceForRequest:]): Use proper call.
1308 2006-08-13 Brady Eidson <beidson@apple.com>
1312 The way of detecting a failed icon load before was to try and construct
1313 an image from the icon and if that image construction failed, mark the icon
1315 A much more efficient way is to check for an error response. We'll still
1316 check for invalid image data, but most servers will correctly return an HTTP
1317 error on a missing icon.
1319 * Misc/WebIconLoader.m:
1320 (-[WebIconLoader didFinishLoading]): Added check for http error response
1322 2006-08-13 Maciej Stachowiak <mjs@apple.com>
1326 - remove all non-Loader dependencies from WebLoader
1328 As part of this I moved WebDataProtocol to the loader directory
1329 and removed dependencies on the rest of WebKit from that too.
1331 * Loader/WebFrameLoader.h:
1332 * Loader/WebFrameLoader.m:
1333 (-[WebFrameLoader setDefersCallbacks:]):
1334 (-[WebFrameLoader stopLoading]):
1335 (-[WebFrameLoader cancelledErrorWithRequest:]):
1336 (-[WebFrameLoader clearArchivedResources]):
1337 (-[WebFrameLoader deliverArchivedResources]):
1338 (-[WebFrameLoader deliverArchivedResourcesAfterDelay]):
1339 (isCaseSensitiveEqual):
1340 (-[WebFrameLoader _canUseResourceForRequest:]):
1341 (-[WebFrameLoader _canUseResourceWithResponse:]):
1342 (-[WebFrameLoader pendingArchivedResources]):
1343 (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
1344 (-[WebFrameLoader archiveLoadPendingForLoader:]):
1345 (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]):
1346 * Loader/WebLoader.h:
1347 * Loader/WebLoader.m:
1348 (-[NSURLProtocol releaseResources]):
1349 (-[NSURLProtocol loadWithRequest:]):
1350 (-[NSURLProtocol setDefersCallbacks:]):
1351 (-[NSURLProtocol addData:allAtOnce:]):
1352 (-[NSURLProtocol resourceData]):
1353 (-[NSURLProtocol didReceiveData:lengthReceived:allAtOnce:]):
1354 (-[NSURLProtocol connection:didReceiveData:lengthReceived:]):
1355 (-[NSURLProtocol cancelWithError:]):
1356 (-[NSURLProtocol cancelledError]):
1357 * Loader/WebMainResourceLoader.m:
1358 (-[WebMainResourceLoader addData:allAtOnce:]):
1359 (-[WebMainResourceLoader didReceiveData:lengthReceived:allAtOnce:]):
1360 * Loader/WebNetscapePlugInStreamLoader.m:
1361 (-[WebNetscapePlugInStreamLoader didReceiveData:lengthReceived:allAtOnce:]):
1362 * Loader/WebSubresourceLoader.m:
1363 (-[WebSubresourceLoader didReceiveData:lengthReceived:allAtOnce:]):
1364 * WebKit.xcodeproj/project.pbxproj:
1365 * WebView/WebDataProtocol.h: Removed.
1366 * WebView/WebDataProtocol.m: Removed.
1368 2006-08-11 Tim Omernick <timo@apple.com>
1372 <http://bugzilla.opendarwin.org/show_bug.cgi?id=10111> - Menu flickers over Flash content
1373 <rdar://problem/3052546> Plugins don't work with z-index (overlapping elements, etc.)
1375 * Plugins/WebBaseNetscapePluginView.m:
1376 (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1377 Don't just clip to the dirty region for "transparent" plug-ins -- do it for all plug-ins. This is a
1378 generally useful thing to do, as it prevents the plug-in from drawing over parts of the window that
1379 have already been drawn and are not expected to be redrawn in the same update.
1381 2006-08-11 Brady Eidson <beidson@apple.com>
1383 Reviewed by John, Timo, Adele, and Darin
1385 In addition to a few style/good-practice cleanups, this patch will convert the old icon database
1386 format to the WebCore format if the WebCore db is empty (implying this conversion has yet to take
1387 place). After the conversion, it will delete all traces of the old format to free the unneeded space
1389 * Misc/WebIconDatabase.m:
1390 (-[WebIconDatabase init]):
1391 (-[WebIconDatabase _setIconURL:forURL:]): Changed the bridge's name for this method to be more clear
1392 (-[WebIconDatabase _createFileDatabase]):
1393 (-[WebIconDatabase _iconDataForIconURL:]): This grabs the raw data for use in the conversion function
1394 (-[WebIconDatabase _convertToWebCoreFormat]): This does the actual conversion
1396 2006-08-11 Tim Omernick <timo@apple.com>
1398 Reviewed by John Sullivan.
1400 Needed for <rdar://problem/4678070>.
1402 * Plugins/WebBaseNetscapePluginView.m:
1403 (-[WebBaseNetscapePluginView sendEvent:]):
1404 Changed an assertion to an early return. It should be possible to send events, especially updateEvt (for image capturing
1405 purposes), to off-screen plug-ins. It just doesn't work right now. See <rdar://problem/4318269>.
1407 2006-08-11 John Sullivan <sullivan@apple.com>
1411 - fixed <rdar://problem/4522894> Would be nice if Safari shrank pages a little if necessary
1412 to avoid printing an almost-empty page
1414 * WebView/WebHTMLView.m:
1415 (-[NSArray knowsPageRange:]):
1416 If the last page has a short-enough orphan (< 1/10 of the page height is the number I pulled
1417 out of ... the air), then we adjust the scale factor slightly and check whether this reduces
1418 the page count and thus eliminates the orphan.
1420 2006-08-07 Brady Eidson <beidson@apple.com>
1422 Reviewed by Anders and John
1424 * Misc/WebIconDatabase.m:
1425 (-[WebIconDatabase init]):
1426 (-[WebIconDatabase isIconExpiredForIconURL:]): Get if an icon expired
1427 (-[WebIconDatabase isIconExpiredForPageURL:]): Ditto
1428 (-[WebIconDatabase _setIconURL:forURL:]):
1429 (-[WebIconDatabase _sendNotificationForURL:]): Moved to WebKitPendingPublic for use outside of WebIconDatabase
1430 (-[WebIconDatabase loadIconFromURL:]): Allow a load outside the context of a page load
1431 * Misc/WebIconDatabasePrivate.h:
1433 * Misc/WebIconLoader.m:
1434 (-[WebIconLoader didFinishLoading]): fixed up the "flipping the switch" #defs a bit
1435 (-[WebIconLoader willSendRequest:redirectResponse:]): override to allow a load
1436 outside of the context of a page load
1438 * WebCoreSupport/WebIconDatabaseBridge.h: Added.
1439 * WebCoreSupport/WebIconDatabaseBridge.m: Added.
1440 (-[WebIconDatabaseBridge init]):
1441 (-[WebIconDatabaseBridge dealloc]):
1442 (-[WebIconDatabaseBridge loadIconFromURL:]): Kick off a load on an icon outside
1443 of the context of any page load
1444 (-[WebIconDatabaseBridge _setIconData:forIconURL:]): WebKit side of bridge method
1445 (-[WebIconDatabaseBridge _setHaveNoIconForIconURL:]): WebKit side of bridge method
1446 (-[WebIconDatabaseBridge releaseCachedLoaderForIconURL:]):
1447 (+[WebIconDatabaseBridge sharedBridgeInstance]): Moved this from WebCore to WebKit
1448 so both sides of the bridge get the WebKit version
1449 * WebKit.xcodeproj/project.pbxproj: Added some files
1450 * WebView/WebDataSource.m:
1451 (-[WebDataSource _loadIcon]): Added check for reload/expired icon to force
1452 a load even if we already have it
1454 2006-08-04 Sam Weinig <sam.weinig@gmail.com>
1458 - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10192
1459 Make WebCore (and friends) compile with -Wshorten-64-to-32
1461 * Adds 'f' to float literals where expecting a float.
1462 * Use ceilf() instead of ceil() when assigning to a float.
1463 * Adds explicit casts where OK.
1465 NOTE: The -Wshorten-64-to-32 flag was not added for WebKit
1466 because there are still a few places where no error handling
1467 is in place. The flag can be added as soon as those are worked
1470 * Misc/WebNSControlExtras.m:
1471 (-[NSControl sizeToFitAndAdjustWindowHeight]):
1472 * Misc/WebNSImageExtras.m:
1473 (-[NSImage _web_scaleToMaxSize:]):
1474 * Misc/WebNSViewExtras.h:
1475 * Misc/WebNSViewExtras.m:
1476 * Plugins/WebBaseNetscapePluginView.m:
1477 (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1478 (-[WebBaseNetscapePluginView drawRect:]):
1479 * WebCoreSupport/WebFrameBridge.m:
1480 (-[WebFrameBridge expiresTimeForResponse:]):
1481 * WebInspector/WebInspector.m:
1482 (-[NSWindow window]):
1483 (-[WebInspector treeViewScrollTo:]):
1484 (-[WebInspector _updateSystemColors]):
1485 (-[WebInspector webView:plugInViewWithArguments:]):
1486 (-[WebInspector outlineView:objectValueForTableColumn:byItem:]):
1487 * WebInspector/WebInspectorOutlineView.m:
1488 (-[WebInspectorOutlineView _highlightRow:clipRect:]):
1489 * WebInspector/WebNodeHighlight.m:
1490 (-[WebNodeHighlight initWithBounds:andRects:forView:]):
1491 * WebInspector/WebNodeHighlightView.m:
1492 (-[WebNodeHighlightView roundedRect:withRadius:]):
1493 (-[WebNodeHighlightView initWithHighlight:andRects:forView:]):
1494 (-[WebNodeHighlightView drawRect:]):
1495 * WebView/WebFrame.m:
1496 (-[WebFrame _opened]):
1497 * WebView/WebFrameView.m:
1498 (-[WebFrameView initWithFrame:]):
1499 * WebView/WebHTMLView.m:
1500 (-[WebHTMLView _dragImageForLinkElement:]):
1501 (-[WebHTMLView _web_setPrintingModeRecursive]):
1502 (-[WebHTMLView _web_clearPrintingModeRecursive]):
1503 (-[NSArray layout]):
1504 (-[NSArray _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]):
1505 (-[NSArray adjustPageHeightNew:top:bottom:limit:]):
1506 (-[NSArray _scaleFactorForPrintOperation:]):
1507 (-[NSArray setPageWidthForPrinting:]):
1508 (-[NSArray _endPrintMode]):
1509 (-[NSArray knowsPageRange:]):
1510 (-[NSArray _originalFontA]):
1511 (-[NSArray _originalFontB]):
1512 (-[WebTextCompleteController _buildUI]):
1513 (-[WebTextCompleteController _placePopupWindow:]):
1514 * WebView/WebPDFView.m:
1515 (-[WebPDFView _makeTextStandardSize:]):
1516 (-[WebPDFView selectionImageForcingWhiteText:]):
1517 (-[PDFPrefUpdatingProxy forwardInvocation:]):
1518 * WebView/WebPreferences.m:
1519 (-[WebPreferences _floatValueForKey:]):
1520 * WebView/WebView.m:
1521 (-[WebView makeTextSmaller:]):
1522 (-[WebView canMakeTextStandardSize]):
1523 (-[WebView makeTextStandardSize:]):
1525 2006-08-04 David Kilzer <ddkilzer@kilzer.net>
1527 Reviewed by NOBODY (build fix).
1529 * WebCoreSupport/WebSubresourceLoader.m: REALLY moved to Loader/
1530 * WebView/WebFrameLoader.h: REALLY moved to Loader/
1531 * WebView/WebFrameLoader.m: REALLY moved to Loader/
1532 * WebView/WebLoader.h: REALLY moved to Loader/
1533 * WebView/WebLoader.m: REALLY moved to Loader/
1534 * WebView/WebMainResourceLoader.m: REALLY moved to Loader/
1536 2006-08-03 Maciej Stachowiak <mjs@apple.com>
1540 - moved all loader code that is slated to be moved down to WebCore to a new Loader directory
1542 (next step is to remove dependencies on the rest of WebKit from this directory)
1544 * Loader/WebNetscapePlugInStreamLoader.h: Added.
1545 * Loader/WebNetscapePlugInStreamLoader.m: Added. Cut out of WebNetscapePluginStream.m
1546 (-[WebNetscapePlugInStreamLoader initWithStream:view:]):
1547 (-[WebNetscapePlugInStreamLoader isDone]):
1548 (-[WebNetscapePlugInStreamLoader releaseResources]):
1549 (-[WebNetscapePlugInStreamLoader didReceiveResponse:]):
1550 (-[WebNetscapePlugInStreamLoader didReceiveData:lengthReceived:]):
1551 (-[WebNetscapePlugInStreamLoader didFinishLoading]):
1552 (-[WebNetscapePlugInStreamLoader didFailWithError:]):
1553 (-[WebNetscapePlugInStreamLoader cancelWithError:]):
1554 * Plugins/WebNetscapePluginStream.m:
1555 * WebKit.xcodeproj/project.pbxproj:
1556 * WebCoreSupport/WebSubresourceLoader.h: Moved to Loader/
1557 * WebCoreSupport/WebSubresourceLoader.m: Moved to Loader/
1558 * WebView/WebFrameLoader.h: Moved to Loader/
1559 * WebView/WebFrameLoader.m: Moved to Loader/
1560 * WebView/WebLoader.h: Moved to Loader/
1561 * WebView/WebLoader.m: Moved to Loader/
1562 * WebView/WebMainResourceLoader.h: Moved to Loader/
1563 * WebView/WebMainResourceLoader.m: Moved to Loader/
1565 2006-08-03 Tim Omernick <timo@apple.com>
1567 Reviewed by Kevin Decker.
1569 <rdar://problem/4667460> Windowless OpenGL plug-ins render incorrectly on PowerPC
1571 * Plugins/WebBaseNetscapePluginView.m:
1572 (-[WebBaseNetscapePluginView _aglOffscreenImageForDrawingInRect:]):
1573 Fixed color component swapping so that it works on both x86 and PPC. See comments.
1575 2006-08-03 Brady Eidson <beidson@apple.com>
1577 Reviewed by Tim Hatcher's rubber stamp
1578 Fixed Intel build break caused by weinig's -W change in r15781
1580 * WebView/WebView.m: wrapped cpu-dependent defs with defined() macro
1582 2006-08-03 Maciej Stachowiak <mjs@apple.com>
1586 - fixed problem that could cause assertion failures in Safari
1588 * Plugins/WebBaseNetscapePluginView.m:
1589 (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]): Don't
1590 allow a plugin to start new loads once its document is no longer the one actively loading.
1592 2006-08-03 Maciej Stachowiak <mjs@apple.com>
1596 - remove use of WebDataSource from WebLoader and subclasses, just have them talk to the
1597 WebFrameLoader instead.
1599 For now this is done by forarding all the calls.
1601 * Misc/WebIconLoader.m:
1602 (-[WebIconLoader didFinishLoading]):
1603 * Plugins/WebNetscapePluginStream.m:
1604 (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]):
1605 (-[WebNetscapePluginStream start]):
1606 (-[WebNetscapePlugInStreamLoader didFinishLoading]):
1607 (-[WebNetscapePlugInStreamLoader didFailWithError:]):
1608 (-[WebNetscapePlugInStreamLoader cancelWithError:]):
1609 * WebCoreSupport/WebFrameBridge.m:
1610 (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
1611 (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
1612 * WebCoreSupport/WebSubresourceLoader.h:
1613 * WebCoreSupport/WebSubresourceLoader.m:
1614 (-[WebSubresourceLoader initWithLoader:frameLoader:]):
1615 (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]):
1616 (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:referrer:forFrameLoader:]):
1617 (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:postData:referrer:forFrameLoader:]):
1618 (-[WebSubresourceLoader receivedError:]):
1619 (-[WebSubresourceLoader signalFinish]):
1620 (-[WebSubresourceLoader didFailWithError:]):
1621 (-[WebSubresourceLoader cancel]):
1622 * WebKit.xcodeproj/project.pbxproj:
1623 * WebView/WebDataSource.m:
1624 (-[WebDataSource _updateLoading]):
1625 (-[WebDataSource textEncodingName]):
1626 (-[WebDataSource _mainReceivedBytesSoFar:complete:]):
1627 * WebView/WebFrameLoader.h:
1628 * WebView/WebFrameLoader.m:
1629 (-[WebFrameLoader loadIconWithRequest:]):
1630 (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]):
1631 (-[WebFrameLoader clearIconLoader]):
1632 (-[WebFrameLoader commitProvisionalLoad]):
1633 (-[WebFrameLoader activeDataSource]):
1634 (-[WebFrameLoader _archivedSubresourceForURL:]):
1635 (-[WebFrameLoader _defersCallbacks]):
1636 (-[WebFrameLoader _identifierForInitialRequest:]):
1637 (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]):
1638 (-[WebFrameLoader _didReceiveAuthenticationChallenge:forResource:]):
1639 (-[WebFrameLoader _didCancelAuthenticationChallenge:forResource:]):
1640 (-[WebFrameLoader _didReceiveResponse:forResource:]):
1641 (-[WebFrameLoader _didReceiveData:contentLength:forResource:]):
1642 (-[WebFrameLoader _didFinishLoadingForResource:]):
1643 (-[WebFrameLoader _didFailLoadingWithError:forResource:]):
1644 (-[WebFrameLoader _privateBrowsingEnabled]):
1645 (-[WebFrameLoader _addPlugInStreamLoader:]):
1646 (-[WebFrameLoader _removePlugInStreamLoader:]):
1647 (-[WebFrameLoader _finishedLoadingResource]):
1648 (-[WebFrameLoader _receivedError:]):
1649 (-[WebFrameLoader _addSubresourceLoader:]):
1650 (-[WebFrameLoader _removeSubresourceLoader:]):
1651 (-[WebFrameLoader _originalRequest]):
1652 (-[WebFrameLoader webFrame]):
1653 (-[WebFrameLoader _receivedMainResourceError:complete:]):
1654 (-[WebFrameLoader initialRequest]):
1655 (-[WebFrameLoader _receivedData:]):
1656 (-[WebFrameLoader _setRequest:]):
1657 (-[WebFrameLoader _downloadWithLoadingConnection:request:response:proxy:]):
1658 (-[WebFrameLoader _handleFallbackContent]):
1659 (-[WebFrameLoader _isStopping]):
1660 (-[WebFrameLoader _decidePolicyForMIMEType:decisionListener:]):
1661 (-[WebFrameLoader _setupForReplaceByMIMEType:]):
1662 (-[WebFrameLoader _setResponse:]):
1663 (-[WebFrameLoader _mainReceivedError:complete:]):
1664 (-[WebFrameLoader _finishedLoading]):
1665 (-[WebFrameLoader _mainReceivedBytesSoFar:complete:]):
1666 (-[WebFrameLoader _iconLoaderReceivedPageIcon:]):
1667 (-[WebFrameLoader _URL]):
1668 * WebView/WebLoader.h:
1669 * WebView/WebLoader.m:
1670 (-[NSURLProtocol releaseResources]):
1671 (-[NSURLProtocol loadWithRequest:]):
1672 (-[NSURLProtocol setFrameLoader:]):
1673 (-[NSURLProtocol frameLoader]):
1674 (-[NSURLProtocol willSendRequest:redirectResponse:]):
1675 (-[NSURLProtocol didReceiveAuthenticationChallenge:]):
1676 (-[NSURLProtocol didCancelAuthenticationChallenge:]):
1677 (-[NSURLProtocol didReceiveResponse:]):
1678 (-[NSURLProtocol didReceiveData:lengthReceived:]):
1679 (-[NSURLProtocol signalFinish]):
1680 (-[NSURLProtocol didFailWithError:]):
1681 (-[NSURLProtocol willCacheResponse:]):
1682 (-[NSURLProtocol cancelWithError:]):
1683 * WebView/WebMainResourceLoader.h:
1684 * WebView/WebMainResourceLoader.m:
1685 (-[WebMainResourceLoader initWithFrameLoader:]):
1686 (-[WebMainResourceLoader receivedError:]):
1687 (-[WebMainResourceLoader cancelWithError:]):
1688 (-[WebMainResourceLoader _isPostOrRedirectAfterPost:redirectResponse:]):
1689 (-[WebMainResourceLoader addData:]):
1690 (-[WebMainResourceLoader willSendRequest:redirectResponse:]):
1691 (-[WebMainResourceLoader continueAfterContentPolicy:response:]):
1692 (-[WebMainResourceLoader continueAfterContentPolicy:]):
1693 (-[WebMainResourceLoader checkContentPolicyForResponse:]):
1694 (-[WebMainResourceLoader didReceiveResponse:]):
1695 (-[WebMainResourceLoader didReceiveData:lengthReceived:]):
1696 (-[WebMainResourceLoader didFinishLoading]):
1697 (-[WebMainResourceLoader didFailWithError:]):
1698 (-[WebMainResourceLoader loadWithRequestNow:]):
1700 2006-08-03 Sam Weinig <sam.weinig@gmail.com>
1704 - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10176
1705 Make WebCore compile with -Wundef
1707 * Adds -Wundef flag to Xcode project
1708 * Converts #ifs to #ifdef and #ifndefs where needed.
1710 * Carbon/CarbonUtils.m:
1711 * Carbon/CarbonWindowAdapter.m:
1712 * Carbon/HIViewAdapter.m:
1713 (+[NSView bindHIViewToNSView:nsView:]):
1714 * Carbon/HIWebView.m:
1715 (HIWebViewEventHandler):
1716 * Misc/WebFileDatabase.m:
1717 (UniqueFilePathForKey):
1718 * Misc/WebNSWindowExtras.m:
1719 (swizzleInstanceMethod):
1720 * Misc/WebTypesInternal.h:
1721 * Plugins/WebNetscapeDeprecatedFunctions.c:
1722 * Plugins/WebNetscapeDeprecatedFunctions.h:
1723 * Plugins/WebNetscapePluginPackage.h:
1724 * Plugins/WebNetscapePluginPackage.m:
1725 (-[WebNetscapePluginPackage unloadWithoutShutdown]):
1726 (-[WebNetscapePluginPackage load]):
1727 * WebKit.xcodeproj/project.pbxproj:
1729 2006-08-03 Darin Adler <darin@apple.com>
1731 Reviewed by Eric Seidel.
1735 * WebView/WebFrame.m: (-[WebFramePrivate dealloc]): Release the frame loader.
1737 2006-08-02 Timothy Hatcher <timothy@apple.com>
1739 Rubber stamped by Maciej.
1741 Adding back resultsWithXpathQuery, removed by Darin's earlier change.
1742 This function is called from ObjC, but not used from JavaScript.
1744 * WebInspector/webInspector/inspector.js:
1746 2006-08-02 Timothy Hatcher <timothy@apple.com>
1750 Bug 10200: [Drosera] Deadlock between Drosera and Safari while loading page
1751 http://bugzilla.opendarwin.org/show_bug.cgi?id=10200
1753 Prevent reentrancy in our debugger callbacks. This was causing a deadlock in Drosera because
1754 suspendProcessIfPaused was being called during a DO call into Safari.
1756 Preventing reentrancy also prevents scripts that Drosera injects and evaluates from showing
1757 up in rare cases (such as a iframe loading about:blank). I thought this would prevent cases
1758 where you call a function from the console and expect it to break on a breakpoint in them, but
1759 this appears to never have worked even without this change. When that is figured out we can
1760 reconsider a better solution to reentrancy. I have filed that as bug 10214.
1762 I also removed the NSRunLoop runMode:beforeDate: calls since DO handles this for us since
1763 we don't use "onway void" as the return type for the callbacks. Note: using onway void for
1764 the listener callbacks causes bad synchronization issues and obscure crashes.
1766 * DefaultDelegates/WebScriptDebugServer.m:
1767 (-[WebScriptDebugServer webView:didLoadMainResourceForDataSource:]):
1768 (-[WebScriptDebugServer webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
1769 (-[WebScriptDebugServer webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
1770 (-[WebScriptDebugServer webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
1771 (-[WebScriptDebugServer webView:willExecuteStatement:sourceId:line:forWebFrame:]):
1772 (-[WebScriptDebugServer webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
1773 (-[WebScriptDebugServer webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
1774 * DefaultDelegates/WebScriptDebugServerPrivate.h:
1776 2006-08-02 Maciej Stachowiak <mjs@apple.com>
1780 - fix assertion failure on layout tests by stopping plugins from loading at a clearly defined time
1781 - add more assertions for safety
1783 * WebView/WebDataSource.m:
1784 (-[WebDataSourcePrivate dealloc]): Removed obsolete comment.
1785 (-[WebDataSource _updateLoading]): Add assertion ensuring this method is only called
1786 at a time when this data source is the one that might be loading for a frame.
1787 (-[WebDataSource _stopLoading]): Stop loading plugins as a FIXME suggests we should.
1788 * WebView/WebFrameLoader.m:
1789 (-[WebFrameLoader isLoadingPlugIns]): New helper method.
1790 (-[WebFrameLoader isLoading]): Consider plugin loads too - otherwise we won't stop them
1791 at stopLoading time.
1793 2006-08-02 Adam Roben <aroben@apple.com>
1797 - Rename TransferJob to ResourceLoader (this file was forgotten in an
1798 earlier change by Maciej)
1802 2006-08-01 Maciej Stachowiak <mjs@apple.com>
1806 - Change things around so WebFrameLoader tracks the main and provisional data source,
1807 as well as the frame load state, pulling much code out of WebFrame along the way.
1809 The most significant aspects of this change are:
1811 - management of WebDataSources and WebFrameState was moved into WebFrameLoader
1812 - there is now just one WebFrameLoader shared between the primary and provisional data source
1814 * WebKit.xcodeproj/project.pbxproj:
1815 * WebView/WebDataSource.m:
1816 (-[WebDataSourcePrivate dealloc]):
1817 (-[WebDataSource _updateLoading]):
1818 (-[WebDataSource _loadIcon]):
1819 (-[WebDataSource _setPrimaryLoadComplete:]):
1820 (-[WebDataSource _stopLoading]):
1821 (-[WebDataSource _startLoading]):
1822 (-[WebDataSource _addSubresourceLoader:]):
1823 (-[WebDataSource _removeSubresourceLoader:]):
1824 (-[WebDataSource _addPlugInStreamLoader:]):
1825 (-[WebDataSource _removePlugInStreamLoader:]):
1826 (-[WebDataSource _defersCallbacksChanged]):
1827 (-[WebDataSource _stopLoadingWithError:]):
1828 (-[WebDataSource _revertToProvisionalState]):
1829 (-[WebDataSource _setupForReplaceByMIMEType:]):
1830 (-[WebDataSource initWithRequest:]):
1831 (-[WebDataSource data]):
1832 (-[WebDataSource isLoading]):
1833 * WebView/WebFrame.m:
1834 (-[WebFramePrivate init]):
1835 (-[WebFramePrivate dealloc]):
1836 (-[WebFrame _closeOldDataSources]):
1837 (-[WebFrame _detachFromParent]):
1838 (-[WebFrame _makeDocumentView]):
1839 (-[WebFrame _receivedMainResourceError:]):
1840 (-[WebFrame _transitionToCommitted:]):
1841 (+[WebFrame _timeOfLastCompletedLoad]):
1842 (-[WebFrame _checkLoadCompleteForThisFrame]):
1843 (-[WebFrame _loadItem:withLoadType:]):
1844 (-[WebFrame _continueAfterWillSubmitForm:]):
1845 (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
1846 (-[WebFrame _initWithWebFrameView:webView:bridge:]):
1847 (-[WebFrame _frameLoader]):
1848 (-[WebFrame _provisionalLoadStarted]):
1849 (-[WebFrame _prepareForDataSourceReplacement]):
1850 (-[WebFrame _frameLoadCompleted]):
1851 (-[WebFrame provisionalDataSource]):
1852 (-[WebFrame dataSource]):
1853 (-[WebFrame stopLoading]):
1854 * WebView/WebFrameInternal.h:
1855 * WebView/WebFrameLoader.h:
1856 * WebView/WebFrameLoader.m:
1857 (-[WebFrameLoader initWithWebFrame:]):
1858 (-[WebFrameLoader dealloc]):
1859 (-[WebFrameLoader dataSource]):
1860 (-[WebFrameLoader _setDataSource:]):
1861 (-[WebFrameLoader clearDataSource]):
1862 (-[WebFrameLoader provisionalDataSource]):
1863 (-[WebFrameLoader _setProvisionalDataSource:]):
1864 (-[WebFrameLoader _clearProvisionalDataSource]):
1865 (-[WebFrameLoader state]):
1866 (+[WebFrameLoader timeOfLastCompletedLoad]):
1867 (-[WebFrameLoader _setState:]):
1868 (-[WebFrameLoader clearProvisionalLoad]):
1869 (-[WebFrameLoader markLoadComplete]):
1870 (-[WebFrameLoader commitProvisionalLoad]):
1871 (-[WebFrameLoader stopLoading]):
1872 (-[WebFrameLoader startLoading]):
1873 (-[WebFrameLoader startProvisionalLoad:]):
1874 (-[WebFrameLoader setupForReplace]):
1875 * WebView/WebFramePrivate.h:
1877 2006-08-01 Tim Omernick <timo@apple.com>
1879 Reviewed by John Sullivan.
1881 <rdar://problem/4480737> Flash crashes after it replaces itself via a document.write()
1883 I kind of hate to do this, but this is the best way to work around buggy plug-ins like Flash that assume that
1884 NPP_Destroy() cannot be called while the browser is calling one of its other plug-in functions. The classic
1885 situation is a plug-in that replaces itself via an NPN_Invoke() that executes a document.write().
1887 * Plugins/WebBaseNetscapePluginView.h:
1888 * Plugins/WebBaseNetscapePluginView.m:
1889 (-[WebBaseNetscapePluginView sendEvent:]):
1890 Call -willCallPlugInFunction and -didCallPlugInFunction around calls to the NPP_* functions.
1891 (-[WebBaseNetscapePluginView setWindowIfNecessary]):
1893 (-[WebBaseNetscapePluginView start]):
1894 It should not be possible to start a plug-in instance while we are calling into it (one of those chicken/egg
1895 problems). Added a sanity-checking assertion.
1896 (-[WebBaseNetscapePluginView stop]):
1897 If we're already calling a plug-in function, do not call NPP_Destroy(). The plug-in function we are calling
1898 may assume that its instance->pdata, or other memory freed by NPP_Destroy(), is valid and unchanged until said
1899 plugin-function returns.
1900 (-[WebBaseNetscapePluginView pluginScriptableObject]):
1901 Call -willCallPlugInFunction and -didCallPlugInFunction around calls to the NPP_* functions.
1902 (-[WebBaseNetscapePluginView willCallPlugInFunction]):
1903 Increment plug-in function call depth.
1904 (-[WebBaseNetscapePluginView didCallPlugInFunction]):
1905 Decrement plug-in function call depth. Stop if we're supposed to stop.
1906 (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
1907 Call -willCallPlugInFunction and -didCallPlugInFunction around calls to the NPP_* functions.
1908 (-[WebBaseNetscapePluginView webFrame:didFinishLoadWithReason:]):
1910 (-[WebBaseNetscapePluginView _printedPluginBitmap]):
1913 * Plugins/WebBaseNetscapePluginStream.m:
1914 (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:]):
1915 Call -willCallPlugInFunction and -didCallPlugInFunction around calls to the NPP_* functions.
1916 (-[WebBaseNetscapePluginStream _destroyStream]):
1918 (-[WebBaseNetscapePluginStream _deliverData]):
1921 2006-08-01 Maciej Stachowiak <mjs@apple.com>
1923 - fix build after last change
1925 * WebView/WebFrame.m:
1926 (-[WebFrame _checkLoadCompleteForThisFrame]):
1928 2006-08-01 Maciej Stachowiak <mjs@apple.com>
1932 - revert part of my last fix that broke the Safari bookmarks view
1934 * WebView/WebFrame.m:
1935 (-[WebFrame _checkLoadCompleteForThisFrame]): still send layout message for non-HTML views
1937 2006-08-01 Tim Omernick <timo@apple.com>
1941 Fixed an assertion failure I ran into while debugging <rdar://problem/4652683>.
1943 * Plugins/WebNetscapePluginEmbeddedView.m:
1944 (-[WebNetscapePluginEmbeddedView redeliverStream]):
1945 Don't clear the "instance" ivar here. This code was refactored here from the old WebNetscapePluginRepresentation,
1946 which also had an "instance" ivar. It is never appropriate to clear a plug-in view's instance. That is done when
1947 the plug-in is destroyed.
1949 2006-08-01 Maciej Stachowiak <mjs@apple.com>
1953 - some refactoring in preparation for moving more stuff to WebFrameLoader.
1955 * WebView/WebFrame.m:
1956 (-[WebFrame _clearDataSource]):
1957 (-[WebFrame _detachFromParent]):
1958 (-[WebFrame _commitProvisionalLoad]):
1959 (-[WebFrame _transitionToCommitted:]):
1960 (-[WebFrame _clearProvisionalLoad]):
1961 (-[WebFrame _markLoadComplete]):
1962 (-[WebFrame _checkLoadCompleteForThisFrame]):
1963 (-[WebFrame _startProvisionalLoad:]):
1964 (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
1965 (-[WebFrame stopLoading]):
1967 2006-07-31 Maciej Stachowiak <mjs@apple.com>
1969 Reviewed by Tim Hatcher.
1971 - renamed TransferJob to ResourceLoader in WebCore
1974 (WebFrame::loadDataSource):
1975 (WebFrame::receivedRedirect):
1976 (WebFrame::receivedResponse):
1977 (WebFrame::receivedData):
1978 (WebFrame::receivedAllData):
1979 (WebFrame::setStatusText):
1982 2006-07-31 Darin Adler <darin@apple.com>
1986 - omit the margin and padding boxes for display types where they are ignored
1987 - use CSS instead of properties for table spacing and padding as suggested by Tim H.
1989 * WebInspector/webInspector/inspector.css: Added rules for spacing and padding.
1990 Added rules that hide the margin and padding boxes (borders and all but the center cell)
1991 when the hide attribute is present.
1992 * WebInspector/webInspector/inspector.html: Added classes for the rules above.
1993 Removed cellpadding and cellspacing attributes.
1994 * WebInspector/webInspector/inspector.js: Added code to hide/show the margin and
1995 padding boxes based on the display type.
1997 2006-07-31 Duncan Wilcox <duncan@mclink.it>
2001 Fixes <http://bugzilla.opendarwin.org/show_bug.cgi?id=10159>
2002 "REGRESSION: delegate returning no menu elements crashes webkit"
2004 No automated test, because there's no way to programmatically open a context menu,
2005 no manual test because there's no way to customize the context menu delegate.
2007 * WebView/WebView.m:
2008 (-[WebView _menuForElement:defaultItems:]): Make sure the context menu returned
2009 some menu items before accessing the first one.
2011 2006-07-31 Timothy Hatcher <timothy@apple.com>
2015 <rdar://problem/4658194> REGRESSION: "Search in Google"
2016 and "Search in Spotlight" fail to work on text selected in a frame
2018 Use selectedFrame to get the frame with the text selection.
2020 * WebView/WebView.m:
2021 (-[WebView _searchWithGoogleFromMenu:]):
2022 (-[WebView _searchWithSpotlightFromMenu:]):
2024 2006-07-31 Darin Adler <darin@apple.com>
2026 Reviewed by Tim Hatcher.
2028 - http://bugzilla.opendarwin.org/show_bug.cgi?id=10168
2029 add a first cut at a Metrics pane to the inspector
2031 * WebInspector/webInspector/inspector.css: Add styles for the new metrics pane.
2032 * WebInspector/webInspector/inspector.html: Add the new metrics pane, starting with
2033 the table to show the box model.
2034 * WebInspector/webInspector/inspector.js: Add the new metrics pane. Add back some
2035 "title" attributes so we have more tooltips. Removed the optional parameter to
2038 2006-07-31 Anders Carlsson <acarlsson@apple.com>
2042 * Plugins/WebPluginDatabase.m:
2043 (-[WebPluginDatabase refresh]):
2044 Create a mutable set instead of a mutable array.
2046 2006-07-30 Darin Adler <darin@apple.com>
2048 Reviewed by Tim Hatcher.
2050 * WebInspector/webInspector/inspector.js: Fix bug where a null property value
2051 leads to an empty style pane.
2053 2006-07-30 Darin Adler <darin@apple.com>
2055 Reviewed by Tim Hatcher.
2057 - http://bugzilla.opendarwin.org/show_bug.cgi?id=10163
2058 some improvements for the inspector
2060 * WebInspector/WebInspector.m:
2061 (+[WebInspector sharedWebInspector:]): Fixed bug that could cause the inspector
2062 to be garbage collected if used in an application with GC enabled.
2063 (-[WebInspector dealloc]): Removed a call to a non-existent close method.
2064 (-[WebInspector window]): Added a custom WebPreferences object and called
2065 setPrivateBrowsingEnabled:YES so the inspector won't appear in the history menu.
2066 Also call setProhibitsMainFrameScrolling:YES to try to get rid of trouble where
2067 the inspector scrolls when dragging.
2069 * WebInspector/webInspector/inspector.css: Added style for the new color swatch,
2070 and JavaScript properties. More of the style should be shared between the panes,
2071 but this should be OK for now.
2073 * WebInspector/webInspector/inspector.html: Added a first cut at a JavaScript
2074 properties pane. Needs work, but better than nothing.
2076 * WebInspector/webInspector/inspector.js: Lots of improvements:
2077 - Omit "typical" property values from computed style display, making it much shorter.
2078 - Use the words "black", "white", and "transparent" when appropriate for color values.
2079 - Refactored the loaded() function to get rid of repetitive scrollbar setup.
2080 - Added a new scrollarea for the JavaScript properties pane.
2081 - Simplified refreshScrollbars() -- we now refresh all scrollbars every time, which does no harm.
2082 - Removed unused resultsWithXpathQuery().
2083 - Use [] instead of "new Array()" and {} instead of "new Object()".
2084 - Removed unused xpathForNode().
2085 - Changed style pane to display the style for a text node's parent instead of saying
2086 it can't display the style for text.
2087 - Fixed regression I caused a while back by checking the length of a computed style
2088 and not trying to display anything if its length is 0. Before this change and the
2089 corresponding change in WebCore, we'd see a complete list of all styles with the
2090 empty string as the value for each one.
2091 - Changed the name of the computedStyle flag on the style rules array to isComputedStyle
2092 to make it easier to understand it's a boolean.
2093 - Fixed an error in the code that does !important scanning where it was trying to
2094 do a special case for computed style, but was checking the computed style flag on
2096 - Added populateStyleListItem() function to factor out things in common between the
2097 items in the top level list and the expanded tree for shorthand properties.
2098 - Added code to make a color swatch next to the textual representation for any
2099 property that contains a color.
2100 - Implemented a first cut at a simple JavaScript properties pane.
2102 2006-07-29 Darin Adler <darin@apple.com>
2104 - Removed tabs from these source files that still had them.
2105 We don't use them; that way source files look fine in editors
2106 that have tabs set to 8 spaces or to 4 spaces.
2107 - Removed allow-tabs Subversion property from the files too.
2109 * DefaultDelegates/WebDefaultPolicyDelegate.m:
2110 * History/WebHistory.m:
2111 * Misc/WebDownload.m:
2112 * Misc/WebIconDatabase.m:
2113 * Misc/WebKitErrors.m:
2114 * Misc/WebKitLogging.m:
2115 * Misc/WebNSDataExtras.m:
2116 * Misc/WebNSFileManagerExtras.m:
2117 * Panels/WebPanelAuthenticationHandler.m:
2118 * Plugins/WebBaseNetscapePluginView.m:
2119 * Plugins/npfunctions.h:
2120 * WebCoreSupport/WebSubresourceLoader.m:
2121 * WebView/WebMainResourceLoader.m:
2122 * WebView/WebView.h:
2123 * WebView/WebView.m:
2125 2006-07-29 Sam Weinig <sam.weinig@gmail.com>
2129 - patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10080
2130 Adopt pedantic changes from the Unity project to improve
2131 cross-compiler compatibility
2134 * Adding missing newline to the end of the file.
2135 * Turning on gcc warning for missing newline at the end of a source file
2136 (GCC_WARN_ABOUT_MISSING_NEWLINE in Xcode, -Wnewline in gcc).
2138 * WebKit.xcodeproj/project.pbxproj:
2139 * WebView/WebResourcePrivate.h:
2141 2006-07-29 Mitz Pettel <opendarwin.org@mitzpettel.com>
2143 Reviewed by John Sullivan.
2145 - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9984
2146 ASSERTION FAILURE: _private->mouseDownEvent != nil
2147 (WebKit/WebView/WebHTMLView.m:4863 -[WebHTMLView(WebInternal) _delegateDragSourceActionMask])
2149 * WebView/WebHTMLView.m:
2150 (-[WebHTMLView _setMouseDownEvent:]): Moved into the WebHTMLViewFileInternal category and changed
2152 (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
2153 Copy the hit HTMLView's mouse down event to the top HTMLView.
2154 (-[WebHTMLView acceptsFirstMouse:]): Added a call to _setMouseDownEvent:nil before returning.
2155 (-[WebHTMLView shouldDelayWindowOrderingForEvent:]): Added a call to _setMouseDownEvent:nil
2157 (-[WebHTMLView mouseUp:]): Added a call to _setMouseDownEvent:nil to clear the event set in
2158 mouseDown: (and used during dragging).
2159 (-[WebHTMLView _delegateDragSourceActionMask]): Copy the hit HTMLView's mouse down event to
2162 2006-07-28 Timothy Hatcher <timothy@apple.com>
2166 <rdar://problem/4657473> REGRESSION: Spell check not available from contextual menu in Mail
2168 The context menu code should be checking isContentEditable
2169 on DOMNode not just DOMElement. This is needed because DOMText
2170 will be the node class of any text that is clicked.
2172 * DefaultDelegates/WebDefaultContextMenuDelegate.m:
2173 (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):
2175 2006-07-25 Geoffrey Garen <ggaren@apple.com>
2177 Reviewed by Maciej, inspired by John.
2179 - Fixed <rdar://problem/4651931> 1% REGRESSION on iBench HTML due to
2180 repeated requests for non-existent favicon
2182 An optimization to avoid serializing favicon data for missing icons had stomped an
2183 optimization to avoid GETing a missing favicon more than once. The solution
2184 is a happy marriage of optimizations, ensuring that we *retain* the missing
2185 favicon's "i am missing" data without posting a notification or saving it to disk.
2187 * Misc/WebIconDatabase.m:
2188 (-[WebIconDatabase _setIconURL:forURL:]):
2190 2006-07-25 David Harrison <harrison@apple.com>
2192 Reviewed by timo and Darin.
2194 <rdar://problem/4618584> "Paste and Match Style" is not working in Mail (add SPI)
2196 * WebKit.xcodeproj/project.pbxproj:
2197 * WebView/WebView.m:
2198 (-[WebView replaceSelectionWithNode:]):
2199 (-[WebView _replaceSelectionWithNode:matchStyle:]):
2200 * WebView/WebViewPrivate.h:
2201 (-[WebView _replaceSelectionWithNode:matchStyle::]):
2202 New SPI that is same as replaceSelectionWithNode: with added parameter whether to match existing style.
2204 2006-07-24 Darin Adler <darin@apple.com>
2206 Reviewed by Adele and Justin.
2208 - update for change to require context when creating fragments from text
2209 (needed to handle whitespace properly)
2211 * WebView/WebHTMLView.m:
2212 (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]):
2213 Added context parameter, pass through to bridge.
2214 (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Pass selection range as context
2215 when calling above method.
2216 (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): Pass drag caret as context when
2217 calling above method.
2219 2006-07-24 Maciej Stachowiak <mjs@apple.com>
2223 - fix <rdar://problem/4609195> Help Viewer loads empty window (not getting didFailLoadingWithError: callback)
2224 (without re-introducing http://bugzilla.opendarwin.org/show_bug.cgi?id=10062 )
2226 * WebView/WebLoader.h:
2227 * WebView/WebMainResourceLoader.m:
2228 (-[WebMainResourceLoader receivedError:]): Copy in some code from the base class to do it in the proper
2229 order, surrounding the call to [ds _receivedMainResourceError:error complete:YES].
2231 2006-07-24 Anders Carlsson <acarlsson@apple.com>
2235 * Misc/WebIconDatabase.m:
2236 (-[WebIconDatabase removeAllIcons]):
2237 Make an array of the keys and iterate through it to avoid modifying the
2238 dictionary while enumerating it.
2240 2006-07-24 Timothy Hatcher <timothy@apple.com>
2242 Reviewed by John and Darin.
2244 <rdar://problem/4634290> Cannot selectively install a custom
2245 scroller that differs from the default Aqua frame size.
2247 Adds two new private methods to WebFrameView that allows
2248 an application to set a custom scroll view class. This is needed
2249 if the application wants to install a custom scroller that is wider
2250 than the typical scroller, because NSScrollView does the content
2251 rect calculations in a class method (ignoring custom scrollers.)
2252 The _setScrollViewClass method requires the class to be a subclass
2253 of WebDynamicScrollBarView, or nil can be passed to reset to the default class.
2254 A new scroll view of the specified class will then replace the previous
2255 one without the need to reload content of the frame.
2257 * WebView/WebFrameView.m:
2258 (-[WebFrameView _customScrollViewClass]):
2259 (-[WebFrameView _setCustomScrollViewClass:]):
2260 * WebView/WebFrameViewPrivate.h:
2262 2006-07-24 Alexey Proskuryakov <ap@nypop.com>
2266 Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10009
2267 REGRESSION: Schubert-IT PDF Plug-in not working for full page (works in frames)
2269 * WebView/WebView.m:
2270 (+[WebView _viewClass:andRepresentationClass:forMIMEType:]): If we've got a type supported by WebPDFView,
2271 make sure to initialize the plugin database, in case a plugin wants to handle it.
2273 2006-07-23 Mark Rowe <opendarwin.org@bdash.net.nz>
2277 Bug 9686: [Drosera] Need the ability to break into Drosera on Javascript exceptions
2278 http://bugzilla.opendarwin.org/show_bug.cgi?id=9686
2280 WebKit portion of the fix.
2282 * DefaultDelegates/WebDefaultScriptDebugDelegate.m:
2283 (-[WebDefaultScriptDebugDelegate webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
2284 * DefaultDelegates/WebScriptDebugServer.h:
2285 * DefaultDelegates/WebScriptDebugServer.m:
2286 (-[WebScriptDebugServer webView:exceptionWasRaised:sourceId:line:forWebFrame:]): Notify
2287 listeners that an exception has been raised.
2288 * WebView/WebScriptDebugDelegate.h:
2289 * WebView/WebScriptDebugDelegate.m:
2290 (-[WebScriptCallFrame exceptionRaised:sourceId:line:]): Dispatch through to delegate and
2291 WebScriptDebugServer.
2293 2006-07-23 Adele Peterson <adele@apple.com>
2297 - Fix for <rdar://problem/4646276> CrashTracer: 7 crashes in Safari at com.apple.WebCore: WebCore::RenderTableSection::paint + 155
2299 * WebView/WebHTMLView.m: (-[WebHTMLView _web_layoutIfNeededRecursive:testDirtyRect:]):
2300 needsDisplay was returning NO even though the view has a dirty rect (see <rdar://problem/4647062>). Since we know about
2301 the dirty rect, we don't actually need to check needsDisplay.
2303 2006-07-22 Timothy Hatcher <timothy@apple.com>
2307 Bug 10062: REGRESSION: dom/xhtml/level2/html/HTMLIFrameElement11.xhtml asserts/crashes
2308 http://bugzilla.opendarwin.org/show_bug.cgi?id=10062
2310 2006-07-21 Timothy Hatcher <timothy@apple.com>
2314 <rdar://problem/4609195> Help Viewer loads empty window
2315 (not getting didFailLoadingWithError: callback)
2317 Call super's didFailWithError before _receivedMainResourceError
2318 because _receivedMainResourceError will cause the datasource's
2319 frame to be set to nil before the didFailLoadingWithError delegate
2320 callback is sent. (This order is needed now that WebDataSource does
2321 not hold on to the WebView; it uses the WebFrame to get to the WebView.
2322 If the WebFrame is nil we can't get to the WebView's resource load delegate.)
2324 * WebView/WebMainResourceLoader.m:
2325 (-[WebMainResourceLoader receivedError:]):
2328 2006-07-22 Timothy Hatcher <timothy@apple.com>
2332 <rdar://problem/4646318> REGRESSION: Ctrl-clicking on a selection containing a word doesn't display a complete contextual menu
2334 Show the editing context menu if the WebView is editible.
2335 The original change only checked if the DOM element was editable,
2336 and isContentEditable returns NO if entire WebView is editable.
2338 * DefaultDelegates/WebDefaultContextMenuDelegate.m:
2339 (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):
2341 2006-07-21 Timothy Hatcher <timothy@apple.com>
2345 <rdar://problem/4609195> Help Viewer loads empty window
2346 (not getting didFailLoadingWithError: callback)
2348 Call super's didFailWithError before _receivedMainResourceError
2349 because _receivedMainResourceError will cause the datasource's
2350 frame to be set to nil before the didFailLoadingWithError delegate
2351 callback is sent. (This order is needed now that WebDataSource does
2352 not hold on to the WebView; it uses the WebFrame to get to the WebView.
2353 If the WebFrame is nil we can't get to the WebView's resource load delegate.)
2355 * WebView/WebMainResourceLoader.m:
2356 (-[WebMainResourceLoader receivedError:]):
2358 === Safari-521.20 ===
2360 2006-07-21 Timothy Hatcher <timothy@apple.com>
2364 <rdar://problem/4607572> REGRESSION (521.10.1 - 521.13): most context menu items missing when a form field is focused (common on google.com) (9680)
2366 Do not use _isEditable call since that only checks if the current
2367 selection or frame is editible. We now check if the currently clicked element
2368 is a content editible area, a textarea, an isindex or an input element that
2369 return YES to _isTextField.
2371 * DefaultDelegates/WebDefaultContextMenuDelegate.m:
2372 (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):
2374 2006-07-20 John Sullivan <sullivan@apple.com>
2378 - WebKit part of fix for:
2379 <rdar://problem/4557386> REGRESSION (419.3-521.19): repro Safari world leak involving
2380 closing tabs after clicking in a web page
2382 * WebCoreSupport/WebFrameBridge.m:
2383 (-[WebFrameBridge textViewWasFirstResponderAtMouseDownTime:]):
2384 renamed to be more specific (formerly wasFirstResponderAtMouseDownTime:)
2386 * WebView/WebHTMLViewInternal.h:
2387 * WebView/WebHTMLView.m:
2388 (-[WebTextCompleteController dealloc]):
2389 updated for name change
2390 (-[NSArray _setMouseDownEvent:]):
2391 Now only retains the first responder if it's a textView, since that's the only case that the only client
2392 actually cares about. This avoids a reference cycle caused by retaining self. This is the only substantive
2393 part of the patch; all the rest is just renaming for clarity, and comments.
2394 (-[NSArray mouseDown:]):
2395 updated for name change
2396 (-[WebHTMLView _textViewWasFirstResponderAtMouseDownTime:]):
2397 renamed to be more specific (formerly _wasFirstResponderAtMouseDownTime:)
2399 2006-07-19 Tim Omernick <timo@apple.com>
2403 <rdar://problem/4523432> safari crashed right after disabling "block pop up windows" (or other WebPreferences changes)
2405 * Plugins/WebBaseNetscapePluginView.m:
2406 (-[WebBaseNetscapePluginView viewWillMoveToSuperview:]):
2407 Stop the plug-in when it is removed from its superview. It is not sufficient to do this in -viewWillMoveToWindow:nil, because
2408 the WebView might still has a hostWindow at that point, which prevents the plug-in from being destroyed.
2409 There is no need to start the plug-in when moving into a superview. -viewDidMoveToWindow takes care of that.
2411 === Safari-521.19 ===
2413 2006-07-17 Tim Omernick <timo@apple.com>
2417 <rdar://problem/4612079> need a way to prevent pages from scrolling to reveal elements that are focused
2420 * WebView/WebViewPrivate.h:
2421 * WebView/WebView.m:
2422 (-[WebView setProhibitsMainFrameScrolling:]):
2423 New method. Prohibits scrolling in the WebView's main frame. Used to "lock" a WebView to a specific
2426 2006-07-17 Timothy Hatcher <timothy@apple.com>
2430 <rdar://problem/4635311> REGRESSION: WebKit should call windowScriptObjectAvailable before attaching the script debugger
2432 * WebCoreSupport/WebFrameBridge.m:
2433 (-[WebFrameBridge windowObjectCleared]):
2435 2006-07-17 Timothy Hatcher <timothy@apple.com>
2439 <rdar://problem/4634874> WebScriptObject and WebUndefined are no longer defined by WebKit
2441 Copy WebScriptObject.h from WebCore's private headers, not JavaScriptCore.
2443 * WebKit.xcodeproj/project.pbxproj:
2445 2006-07-17 John Sullivan <sullivan@apple.com>
2447 Reviewed by Tim Omernick.
2449 - fixed <rdar://problem/4604366> Orange Find highlight displays text in wrong size on PDF pages
2450 if they're not at "actual size"
2452 To match WebHTMLView, I made the methods that return attributed strings take the view's scale
2453 factor into account.
2455 * WebView/WebPDFView.m:
2456 (-[WebPDFView _scaledAttributedString:]):
2457 new helper method, takes an attributed string and returns one that's scaled by the view's
2458 current scale factor
2459 (-[WebPDFView attributedString]):
2460 pass result through _scaledAttributedString:
2461 (-[WebPDFView selectedAttributedString]):
2464 2006-07-17 Justin Garcia <justin.garcia@apple.com>
2468 Rolled the first fix for:
2469 <http://bugzilla.opendarwin.org/show_bug.cgi?id=9642>
2470 GMail Editor: Operations that use drop down menus blow away the selection
2471 back in and removed the call to _clearSelectionInOtherFrames from
2472 -[WebHTMLView becomeFirstResponder] to fix the bug.
2474 * WebView/WebHTMLView.m:
2475 (-[NSArray maintainsInactiveSelection]):
2476 (-[NSArray becomeFirstResponder]):
2477 * WebView/WebView.m:
2478 (-[WebView maintainsInactiveSelection]):
2480 2006-07-15 Darin Adler <darin@apple.com>
2482 Reviewed by John Sullivan.
2484 - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9928
2485 REGRESSION: Text Encoding menu inoperative (after gcc protocol build fix)
2487 * WebView/WebHTMLView.m:
2488 (-[WebHTMLView _documentRange]): Moved into WebHTMLViewFileInternal category.
2489 (-[WebHTMLView selectionRect]): Moved into WebDocumentPrivateProtocols category.
2490 (-[WebHTMLView selectionView]): Ditto.
2491 (-[WebHTMLView selectionImageForcingWhiteText:]): Ditto.
2492 (-[WebHTMLView selectionImageRect]): Ditto.
2493 (-[WebHTMLView pasteboardTypesForSelection]): Ditto.
2494 (-[WebHTMLView selectAll]): Ditto.
2495 (-[WebHTMLView deselectAll]): Ditto.
2496 (-[WebHTMLView string]): Ditto.
2497 (-[WebHTMLView _attributeStringFromDOMRange:]): Ditto.
2498 (-[WebHTMLView attributedString]): Ditto.
2499 (-[WebHTMLView selectedString]): Ditto.
2500 (-[WebHTMLView selectedAttributedString]): Ditto.
2501 (-[WebHTMLView supportsTextEncoding]): Ditto.
2502 (-[WebHTMLView _canProcessDragWithDraggingInfo:]): Moved into WebDocumentInternalProtocols.
2503 (-[WebHTMLView _isMoveDrag]): Ditto.
2504 (-[WebHTMLView _isNSColorDrag:]): Ditto.
2505 (-[WebHTMLView draggingUpdatedWithDraggingInfo:actionMask:]): Ditto.
2506 (-[WebHTMLView draggingCancelledWithDraggingInfo:]): Ditto.
2507 (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): Ditto.
2508 (-[WebHTMLView elementAtPoint:]): Ditto.
2509 (-[WebHTMLView elementAtPoint:allowShadowContent:]): Ditto.
2511 * WebKit.xcodeproj/project.pbxproj: Let Xcode 2.3 do its thing.
2513 === Safari-521.17 ===
2515 2006-07-14 Timothy Hatcher <timothy@apple.com>
2517 Rolling out this fix from r15358 since it isn't resolved.
2519 2006-07-11 Justin Garcia <justin.garcia@apple.com>
2521 Reviewed by levi & thatcher
2523 <http://bugzilla.opendarwin.org/show_bug.cgi?id=9642>
2524 GMail Editor: Operations that use drop down menus blow away the selection
2526 * WebView/WebHTMLView.m:
2527 (-[WebHTMLView maintainsInactiveSelection]): Maintain an inactive selection
2528 when resigning as first responder if the selection is editable
2529 or if the WebView tells us to.
2530 * WebView/WebView.m:
2531 (-[WebView maintainsInactiveSelection]): Just because a WebView is
2532 editable doesn't mean selections inside subframes will be. Return
2535 2006-07-14 Timothy Hatcher <timothy@apple.com>
2537 <rdar://problem/4623957> SWB: gcc-5412 (new?) objc warning causes WebCore project failure
2539 Build fix with the new GCC. Removes forward declarations of protocols.
2541 * Misc/WebSearchableTextView.h:
2542 * WebCoreSupport/WebSubresourceLoader.h:
2543 * WebKit.xcodeproj/project.pbxproj:
2544 * WebView/WebDocumentInternal.h:
2545 * WebView/WebDocumentPrivate.h:
2546 * WebView/WebHTMLView.h:
2547 * WebView/WebPDFView.h:
2548 * WebView/WebScriptDebugDelegatePrivate.h:
2550 2006-06-28 Darin Adler <darin@apple.com>
2554 - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9625
2555 <rdar://problem/4604703>
2556 REGRESSION: Focus not removed from password field after ctrl-click in text field
2558 * WebView/WebHTMLView.m: (-[WebHTMLView menuForEvent:]): Set handlingMouseDownEvent to
2559 YES while calling sendContextMenuEvent: on the bridge.
2561 2006-07-14 Timothy Hatcher <timothy@apple.com>
2565 Moved JavaScriptCore to be a public framework.
2567 * WebKit.xcodeproj/project.pbxproj:
2569 2006-07-13 Mitz Pettel <opendarwin.org@mitzpettel.com>
2573 - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9795
2574 REGRESSION: Crash in [WebHTMLView(WebPrivate)
2575 _updateMouseoverWithEvent:]
2576 and http://bugzilla.opendarwin.org/show_bug.cgi?id=9850
2577 REGRESSION: Assertion failure (SHOULD NEVER BE REACHED) in -
2578 [WebHTMLView(WebPrivate) removeTrackingRect:]
2580 * WebView/WebHTMLView.m:
2581 (-[WebHTMLView _updateMouseoverWithEvent:]): Return immediately if
2582 the view has already been closed.
2584 2006-07-13 David Harrison <harrison@apple.com>
2586 Reviewed by Justin and Levi.
2588 <rdar://problem/4620743> REGRESSION: Option-Delete doesn't delete words during typing
2591 editing/deleting/delete-by-word-001.html
2592 editing/deleting/delete-by-word-002.html
2594 * WebView/WebHTMLView.m:
2595 (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:granularity:]):
2597 2006-07-13 Timothy Hatcher <timothy@apple.com>
2599 Rolling out this earlier change (r15378) now that it is fixed on AGL's end.
2600 Fixes <rdar://problem/4624865> Restore 64-bit OpenGL plug-in support once AGL is 64-bit
2602 <rdar://problem/4624858> AGL isn't 64-bit yet; temporarily remove it from WebKit 64-bit build
2604 * Plugins/WebBaseNetscapePluginView.h:
2605 * Plugins/WebBaseNetscapePluginView.m:
2607 2006-07-13 Timothy Hatcher <timothy@apple.com>
2611 <rdar://problem/4616920> REGRESSION: tabbing in mail moves focus
2612 to next control instead of inserting a tab space.
2614 Change editible WebView's tabKeyCyclesThroughElements to NO only
2615 if the setTabKeyCyclesThroughElements SPI wasn't called.
2617 * WebView/WebView.m:
2618 (-[WebView setEditable:]):
2620 2006-07-12 Anders Carlsson <acarlsson@apple.com>
2624 http://bugzilla.opendarwin.org/show_bug.cgi?id=9624
2625 REGRESSION: After ctrl-clicking in a EMPTY input or textarea field, the contextual menu shows "Search in Google" and "Search in Spotlight" as active menu items
2627 * DefaultDelegates/WebDefaultContextMenuDelegate.m:
2628 (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
2629 Don't create Dictionary, Spotlight or Google lookup items if there's no selection.
2631 2006-07-12 Mark Rowe <opendarwin.org@bdash.net.nz>
2633 Reviewed by Timothy.
2635 http://bugzilla.opendarwin.org/show_bug.cgi?id=9868
2636 Applications shown in Drosera's "Attach" window remain after exit
2638 * DefaultDelegates/WebScriptDebugServer.m:
2639 (-[WebScriptDebugServer init]): Register for NSApplicationWillTerminateNotification so we will
2640 know when the application is being exited.
2641 (-[WebScriptDebugServer dealloc]): Unregister notification before we are deallocated.
2642 (-[WebScriptDebugServer applicationTerminating:]): Inform anyone listening that we are going away.
2644 2006-07-12 Tim Omernick <timo@apple.com>
2646 Reviewed by Tim Hatcher.
2648 <rdar://problem/4624858> AGL isn't 64-bit yet; temporarily remove it from WebKit 64-bit build
2650 Also, fixed a LOG_ERROR() so that it uses the CGL error instead of the AGL error; Tim H missed this in his build fix
2653 * Plugins/WebBaseNetscapePluginView.h:
2654 * Plugins/WebBaseNetscapePluginView.m:
2656 2006-07-11 John Sullivan <sullivan@apple.com>
2658 Reviewed by Kevin and Tim O
2660 - added support for creating a selection image with white text
2662 * WebView/WebDocumentPrivate.h:
2663 added -selectionImageForcingWhiteText: and -selectionImageRect to the private
2664 <WebDocumentSelection> protocol
2666 * Misc/WebSearchableTextView.m:
2667 (-[NSString selectionImageForcingWhiteText:]):
2668 added stub for this new method to this obsolete class to satisfy the compiler
2669 (-[NSString selectionImageRect]):
2672 * WebView/WebHTMLView.m:
2673 (-[WebHTMLView _selectionDraggingImage]):
2674 now calls -selectionImageForcingWhiteText:NO instead of just -selectionImage
2675 (-[WebHTMLView _selectionDraggingRect]):
2676 now calls selectionImageRect, to which the implementation moved
2677 (-[WebHTMLView selectionImageForcingWhiteText:]):
2678 implemented this new method by calling through to new bridge method selectionImageForcingWhiteText:
2679 (-[WebHTMLView selectionImageRect]):
2680 implemented this new method by using existing _selectionDraggingRect implementation
2682 * WebView/WebPDFView.m:
2683 (-[WebPDFView selectionImageForcingWhiteText:]):
2684 implemented by using code that was formerly in Safari
2685 (-[WebPDFView selectionImageRect]):
2686 implemented by returning selectionRect
2688 2006-07-11 Tim Omernick <timo@apple.com>
2692 <http://bugzilla.opendarwin.org/show_bug.cgi?id=9843>:
2693 Give Netscape plug-ins access to their own DOM element
2695 * Plugins/WebBaseNetscapePluginView.h:
2696 * Plugins/WebBaseNetscapePluginView.m:
2697 (-[WebBaseNetscapePluginView dealloc]):
2698 Release DOM element.
2699 (-[WebBaseNetscapePluginView getVariable:value:]):
2700 Return NPObject for plugin DOM element.
2702 * Plugins/WebNetscapePluginEmbeddedView.h:
2703 * Plugins/WebNetscapePluginEmbeddedView.m:
2704 (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):
2705 Now takes a DOMElement, in much the same way that WebKit plug-in views take a DOMElement.
2707 * WebCoreSupport/WebFrameBridge.m:
2708 (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
2709 Pass DOMElement to Netscape plug-ins.
2710 (-[WebFrameBridge viewForJavaAppletWithFrame:attributeNames:attributeValues:baseURL:DOMElement:]):
2713 2006-07-11 Justin Garcia <justin.garcia@apple.com>
2715 Reviewed by levi & thatcher
2717 <http://bugzilla.opendarwin.org/show_bug.cgi?id=9642>
2718 GMail Editor: Operations that use drop down menus blow away the selection
2720 * WebView/WebHTMLView.m:
2721 (-[WebHTMLView maintainsInactiveSelection]): Maintain an inactive selection
2722 when resigning as first responder if the selection is editable
2723 or if the WebView tells us to.
2724 * WebView/WebView.m:
2725 (-[WebView maintainsInactiveSelection]): Just because a WebView is
2726 editable doesn't mean selections inside subframes will be. Return
2729 2006-07-11 Tim Omernick <timo@apple.com>
2731 Reviewed by Tim Hatcher.
2733 <rdar://problem/4622748> WebKit now uses deprecated AGL functions
2735 * Plugins/WebBaseNetscapePluginView.m:
2736 (-[WebBaseNetscapePluginView _createWindowedAGLContext]):
2737 aglSetDrawable() is deprecated in AGL 3.0. Use aglSetWindowRef() instead.
2738 (-[WebBaseNetscapePluginView _createWindowlessAGLContext]):
2739 aglSetOffScreen() is deprecated in AGL 3.0. Use CGLSetOffScreen(), which does the same thing.
2741 2006-07-11 Alexey Proskuryakov <ap@nypop.com>
2745 - http://bugzilla.opendarwin.org/show_bug.cgi?id=7808
2746 Assertion failure in -[WebBaseNetscapePluginStream dealloc] when requesting an invalid URL
2748 * Plugins/WebNetscapePluginStream.m:
2749 (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]):
2750 Remove the early return when requesting an invalid (unsupported) URL.
2752 === Safari-521.16 ===
2754 2006-07-10 Mitz Pettel <opendarwin.org@mitzpettel.com>
2756 Reviewed by John Sullivan.
2758 - fix <rdar://problem/4621541>, aka <http://bugzilla.opendarwin.org/show_bug.cgi?id=9838>
2759 REGRESSION (r14968-r14977): View Source doesn't work for pages from the back/forward cache
2761 * WebView/WebDataSource.m:
2762 (-[WebDataSource _setPrimaryLoadComplete:]): Set our data only if the frame loader is
2763 has just loaded it (when coming from the back/forward cache, it hasn't).
2765 2006-07-10 Brady Eidson <beidson@apple.com>
2769 Resolved the console error messages people got from the new DB even if they didn't have it enabled
2771 * Misc/WebIconDatabase.m:
2772 (-[WebIconDatabase init]):
2773 Disabled initializing the IconDatabaseBridge if user is living on the old DB
2775 2006-07-10 Darin Adler <darin@apple.com>
2777 - try to fix Windows build
2779 * COM/WebFrame.h: Qualify DeprecatedString and KURL with WebCore:: prefixes.
2781 2006-07-09 Darin Adler <darin@apple.com>
2783 - try to fix Windows build
2785 * COM/WebFrame.cpp: Rename QChar to DeprecatedChar.
2787 2006-07-09 Darin Adler <darin@apple.com>
2789 - fix newlines to be consistent for all files in the COM directory
2790 (many had mixed style) and set the EOL style to "native" on them.
2792 * COM/*: Set properties and changed files.
2794 2006-07-09 Tim Omernick <timo@apple.com>
2798 <rdar://problem/4404652> Netscape plug-in mouse events broken in HiDPI
2800 Multiply global mouse coordinates by the window scale factor so that plug-ins can use GlobalToLocal() in HiDPI.
2801 This fixes many bugs involving plug-in mouse event handling in HiDPI. Most notably, the Flash player will now
2802 correctly respond to clicks.
2804 * Plugins/WebBaseNetscapePluginView.m:
2805 (+[WebBaseNetscapePluginView getCarbonEvent:]):
2806 (-[WebBaseNetscapePluginView getCarbonEvent:withEvent:]):
2808 2006-07-09 Darin Adler <darin@apple.com>
2810 Reviewed by Tim Hatcher.
2812 - fix assertion firing in plug-in layout tests
2814 * Plugins/WebBaseNetscapePluginView.m:
2815 (-[WebBaseNetscapePluginView restartNullEvents]):
2816 Don't start null events if the plug-in is not in the
2817 started state. This happens when the plug-in moves within
2818 its view hierarchy after it has been stopped.
2820 2006-07-09 Timothy Hatcher <timothy@apple.com>
2824 Bug 9820: Move new DOM API that has been through API review to public headers
2825 http://bugzilla.opendarwin.org/show_bug.cgi?id=9820
2827 * Misc/WebElementDictionary.m: include DOMExtensions.h
2828 * Misc/WebNSViewExtras.m: include DOMExtensions.h
2829 * WebKit.xcodeproj/project.pbxproj: make DOMXPath.h public
2831 2006-07-09 Timothy Hatcher <timothy@apple.com>
2835 Bug 9818: move new UIDelegate API that has been through API review to public headers
2836 http://bugzilla.opendarwin.org/show_bug.cgi?id=9818
2838 <rdar://problem/4387541> API: Remove webView:setContentRect: & webViewContentRect: delegate methods?
2839 The fix for 4310363 removed the only use of webViewContentRect: in our code. webView:setContentRect:
2840 was never used to begin with. There's no harm in leaving these around in the API, but they'll cruft it up.
2842 Also removes the never used webViewPrint: SPI that was replaced by webView:printFrameView:.
2844 * DefaultDelegates/WebDefaultUIDelegate.m:
2845 * WebCoreSupport/WebFrameBridge.m:
2846 (-[WebFrameBridge print]):
2847 * WebView/WebFrameView.h:
2848 * WebView/WebFrameView.m:
2849 * WebView/WebFrameViewPrivate.h:
2850 * WebView/WebUIDelegate.h:
2851 * WebView/WebUIDelegatePrivate.h:
2853 2006-07-09 Timothy Hatcher <timothy@apple.com>
2857 Bug 9814: Move new WebView API that has been through API review to public headers
2858 http://bugzilla.opendarwin.org/show_bug.cgi?id=9814
2860 * WebView/WebView.h:
2861 * WebView/WebView.m:
2863 (-[WebView setShouldCloseWithWindow:]):
2864 (-[WebView shouldCloseWithWindow]):
2865 (-[WebView selectedFrame]):
2866 (-[WebView setMainFrameURL:]):
2867 (-[WebView mainFrameURL]):
2868 (-[WebView isLoading]):
2869 (-[WebView mainFrameTitle]):
2870 (-[WebView mainFrameIcon]):
2871 (-[WebView mainFrameDocument]):
2872 (-[WebView setDrawsBackground:]):
2873 (-[WebView drawsBackground]):
2874 (-[WebView toggleSmartInsertDelete:]):
2875 (-[WebView toggleContinuousSpellChecking:]):
2876 (-[WebView canMakeTextStandardSize]):
2877 (-[WebView makeTextStandardSize:]):
2878 (-[WebView maintainsInactiveSelection]):
2879 * WebView/WebViewPrivate.h:
2881 2006-07-09 Timothy Hatcher <timothy@apple.com>
2885 Bug 9487: The XPath section should be removed and/or moved.
2886 http://bugzilla.opendarwin.org/show_bug.cgi?id=9487
2888 * WebInspector/webInspector/inspector.css:
2889 * WebInspector/webInspector/inspector.html:
2890 * WebInspector/webInspector/inspector.js:
2892 2006-07-09 Anders Carlsson <acarlsson@apple.com>
2896 * WebCoreSupport/WebSystemInterface.m:
2897 (InitWebCoreSystemInterface):
2898 Initialize wkPathFromFont.
2900 2006-07-09 Darin Adler <darin@apple.com>
2904 * Plugins/WebBaseNetscapePluginView.m:
2905 (-[WebBaseNetscapePluginView restorePortState:]): Cast inside the assertion so
2906 that we don't have an unused variable in versions with assertions disabled.
2907 The alternative would be to wrap the whole thing in an #if statement.
2909 2006-07-08 Tim Omernick <timo@apple.com>
2911 Reviewed by John Sullivan.
2913 * Plugins/WebBaseNetscapePluginView.h:
2914 - Added ivars for OpenGL support. Someday it would be nice to refactor this class so
2915 that each drawing model is encapsulated in a class; this would allow
2916 WebBaseNetscapePluginView to make more efficient use of space, for example by not
2917 keeping OpenGL-related ivars for Quickdraw plug-ins.
2919 * Plugins/WebBaseNetscapePluginView.m:
2920 - Declared a bunch of internal methods for OpenGL support (see below).
2921 - Removed "forUpdate" from CoreGraphics port state struct; it was always set to "YES",
2922 so I just cleaned up the silly code that used it.
2923 - Declared OpenGL port state struct.
2924 (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
2925 - Moved a CoreGraphics-related assertion down to the big "switch" statement.
2926 - Don't set window.type here -- according to the Netscape Plug-in API docs, the plug-in
2927 should default to "windowed" mode, and may call NPN_SetValue() during its NPN_New() to
2928 request that the browser use a "windowless" (offscreen) context instead.
2929 - Moved the assertion from the top of this method here; removed a less restrictive
2930 assertion that is now obsolete.
2931 - Removed "forUpdate" flag from CoreGraphics port state struct.
2932 - Fill in OpenGL port state struct. Set up the viewport appropriately for both windowed
2933 and windowless OpenGL plug-ins. Windowed plug-ins need to have their GL viewport
2934 transformed by the amount the plug-in is clipped; windowless plug-ins are drawn off-screen
2935 into a surface whose geometry is never changed or clipped, so they may always draw with
2936 a viewport origin of (0, 0).
2937 (-[WebBaseNetscapePluginView restorePortState:]):
2938 - Removed "forUpdate" flag from CoreGraphics port state struct.
2939 - Restore the old OpenGL context saved by -saveAndSetNewPortStateForUpdate:.
2940 (-[WebBaseNetscapePluginView sendEvent:]):
2941 - Updated an assertion to also include OpenGL. To ensure that attached plug-in window movements
2942 happen atomically with web page redisplays, we assert that the plug-in's window is set only while
2943 the plug-in view is redrawing.
2944 - Same deal as with the assertion; only save/set port state when redrawing the plug-in view. Plug-ins
2945 that use the new drawing models are only allowed to draw when the web page draws. I might consider
2946 changing this for windowed OpenGL plug-ins, since they always obscure the page content anyway.
2947 (-[WebBaseNetscapePluginView isNewWindowEqualToOldWindow]):
2948 - Compare new NP_GLContext structs.
2949 (-[WebBaseNetscapePluginView updateAndSetWindow]):
2950 - In OpenGL mode, can only set window when updating plug-in view.
2951 (-[WebBaseNetscapePluginView setWindowIfNecessary]):
2953 - Updated logging for OpenGL drawing mode.
2954 (-[WebBaseNetscapePluginView addWindowObservers]):
2955 - No need to observe frame/bounds change notifications for this and all parent views. See -renewGState
2957 (-[WebBaseNetscapePluginView removeWindowObservers]):
2958 - Don't need to remove frame/bounds observers anymore.
2959 (-[WebBaseNetscapePluginView start]):
2960 - Plug-ins are "windowed" by default. This is not a change from our previous behavior, but this is a
2961 better place to set the default value as it allows the plug-in to override it later.
2962 (-[WebBaseNetscapePluginView stop]):
2963 - Destroy AGL context when the plug-in stops.
2964 (-[WebBaseNetscapePluginView dealloc]):
2965 - Assert that the AGL stuff has been cleaned up.
2966 (-[WebBaseNetscapePluginView drawRect:]):
2967 - If this is a windowless OpenGL plugin, blit its contents back into this view.
2968 (-[WebBaseNetscapePluginView renewGState]):
2969 - This method is called when the view or one of its parents is moved or resized (see comments).
2970 (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
2971 - Hide the AGL window if the plug-in view is about to be removed from its window.
2972 (-[WebBaseNetscapePluginView viewHasMoved:]):
2973 - Renamed and moved to the "Internal" category.
2974 (-[WebBaseNetscapePluginView invalidateRegion:]):
2976 - Add support for OpenGL (uses the same region type as CoreGraphics).
2977 (-[WebBaseNetscapePluginView getVariable:value:]):
2979 - Implemented NPNVsupportsOpenGLBool; returns YES since we now support the OpenGL drawing model.
2980 (-[WebBaseNetscapePluginView setVariable:value:]):
2981 - Implemented NPPVpluginWindowBool, which allows plug-ins to specify whether they should be rendered in
2982 "windowed" or "windowless" mode. This is an older part of the Netscape Plug-in API that was never
2983 implemented in WebKit. "Windowed" Quickdraw plug-ins do not actually reside in a separate window, and
2984 can already do many of the same things (such as transparency) that only "windowless" plug-ins can do on
2985 other platforms. However, we need the "windowed" vs. "windowless" distinction for OpenGL plug-ins so
2986 that they have some way of specifying whether they should be rendered on an accelerated overlay surface,
2987 composited into the browser window.
2988 - Support for setting the drawing model to OpenGL.
2989 (-[WebBaseNetscapePluginView _viewHasMoved]):
2990 - Renamed from -viewHasMoved:, and moved down in the file.
2991 - None of this work is necessary when the plug-in is not in a window; the plug-in's state will be properly
2992 restored when it is moved back into a window.
2993 - Reshape OpenGL surface window here.
2994 (-[WebBaseNetscapePluginView _createAGLContextIfNeeded]):
2995 - Creates the AGL context of the appropriate type (windowed/windowless).
2996 (-[WebBaseNetscapePluginView _createWindowedAGLContext]):
2997 - Creates a windowed AGL context, which is an AGL context attached to a child window. This is the only way
2998 to get true hardware acceleration.
2999 (-[WebBaseNetscapePluginView _createWindowlessAGLContext]):
3000 - Creates a windowless AGL context, which is an AGL context attached to an offscreen buffer. This buffer can
3001 then be blitted back into the browser window with a different alpha, or scaled, or whatever.
3002 (-[WebBaseNetscapePluginView _cglContext]):
3003 - Returns the underlying CGL context from the AGL context. We give the plug-in access to the CGL context because
3004 CGL is the more primitive of the GL drawable APIs and allows for finer control over the context.
3005 (-[WebBaseNetscapePluginView _getAGLOffscreenBuffer:width:height:]):
3006 - Returns the buffer allocated for the offscreen AGL context, if there is one.
3007 (-[WebBaseNetscapePluginView _destroyAGLContext]):
3008 - Destroys the AGL context, as well as the associated offscreen buffer or child window.
3009 (-[WebBaseNetscapePluginView _reshapeAGLWindow]):
3010 - Positions the AGL window over the browser window.
3011 (-[WebBaseNetscapePluginView _hideAGLWindow]):
3012 - Hides the AGL window.
3013 (-[WebBaseNetscapePluginView _aglOffscreenImageForDrawingInRect:]):
3014 - Returns an NSImage representation of the offscreen AGL context's framebuffer. This is used to draw the offscreen
3015 bits back into the plug-in view. This is kind of tricky because it has to convert the offscreen buffer in-place
3016 from BGRA to RGBA so that it can be wrapped in an NSBitmapImageRep. See comments.
3018 * WebKit.xcodeproj/project.pbxproj:
3019 Link OpenGL and AGL.
3021 2006-07-09 Brady Eidson <beidson@apple.com>
3025 The ICONDEBUG flag now chooses either the new icon database or the old one
3026 No longer any need to live side by side to compare results
3028 * Misc/WebIconDatabase.m:
3029 (-[NSMutableDictionary iconURLForURL:]):
3030 (-[NSMutableDictionary retainIconForURL:]):
3031 (-[NSMutableDictionary releaseIconForURL:]):
3032 (-[WebIconDatabase _setHaveNoIconForIconURL:]):
3033 (-[WebIconDatabase _setIconURL:forURL:]):
3034 (-[WebIconDatabase _resetCachedWebPreferences:]):
3036 2006-07-08 Timothy Hatcher <timothy@apple.com>
3040 Bug 5312: comments aren't available via DOM
3041 http://bugzilla.opendarwin.org/show_bug.cgi?id=5312
3043 Makes the Web Inspector show comment node contents.
3045 * WebInspector/WebInspector.m:
3046 (-[DOMNode _displayName]): return the contents of the comment
3047 * WebInspector/webInspector/inspector.js: check for comment nodes
3049 2006-07-09 Alexey Proskuryakov <ap@nypop.com>
3053 - http://bugzilla.opendarwin.org/show_bug.cgi?id=9572
3054 Add application/xhtml+xml to the Accept header
3056 * WebView/WebFrame.m:
3057 (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): Add an Accept header
3058 to main resource requests.
3059 * English.lproj/StringsNotToBeLocalized.txt: Added new strings.
3061 2006-07-08 Darin Adler <darin@apple.com>
3063 * DefaultDelegates/WebDefaultContextMenuDelegate.m:
3064 (-[WebDefaultUIDelegate contextMenuItemsForElement:defaultMenuItems:]):
3065 Removed misleading old comment.
3067 === Safari-521.15 ===
3069 2006-07-07 Levi Weintraub <lweintraub@apple.com>
3073 Finished moving deletion selection expansion across the bridge... say that 3 times fast.
3075 * WebView/WebHTMLView.m: Pass granularity to WebCore to handle expansion
3076 (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:granularity:]):
3077 (-[WebHTMLView _deleteSelection]):
3078 (-[WebHTMLView _deleteWithDirection:granularity:killRing:isTypingAction:]):
3079 (-[WebHTMLView deleteToMark:]):
3081 2006-07-07 Brady Eidson <beidson@apple.com>
3085 Changed an ASSERT to a LOG_ERROR for an error that could be handled gracefully, but
3086 whose assertion was reproducibly causing a build bot failure
3088 * Misc/WebIconDatabase.m:
3089 (-[WebIconDatabase _releaseIconForIconURLString:]):
3091 2006-07-06 Levi Weintraub <lweintraub@apple.com>
3095 Improved table editing
3097 * WebCoreSupport/WebFrameBridge.m: Added method to allow WebCore to trigger
3098 deletion editing delegate
3099 (-[WebFrameBridge shouldDeleteSelectedDOMRange:]):
3100 * WebView/WebHTMLView.m: Moved code that expanded a selection when the delete
3101 key is pressed over to WebCore so we can be more intelligent about how to handle it
3102 (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:]):
3103 (-[WebHTMLView _deleteWithDirection:granularity:killRing:isTypingAction:]):
3105 2006-07-07 John Sullivan <sullivan@apple.com>
3107 Reviewed by Tim Hatcher
3109 - fixed <rdar://problem/4606857> WebKit: WebPreferencesChangedNotification not exported
3112 added surprisingly missing _WebPreferencesChangedNotification, defined in
3115 2006-07-06 Brady Eidson <beidson@apple.com>
3119 Small fix to my previous small fix that only lets the ASSERT off the hook if the DB
3122 * Misc/WebIconDatabase.m:
3123 (-[WebIconDatabase _releaseIconForIconURLString:]):
3125 2006-07-05 Brady Eidson <beidson@apple.com>
3129 Small fix that prevents an assertion from triggering if the DB is being cleaned up
3130 (ie, the app being shut down)
3132 * Misc/WebIconDatabase.h:
3133 * Misc/WebIconDatabase.m:
3134 (-[NSMutableDictionary init]):
3135 (-[WebIconDatabase _applicationWillTerminate:]):
3136 (-[WebIconDatabase _releaseIconForIconURLString:]):
3138 2006-07-05 Adele Peterson <adele@apple.com>
3140 Reviewed by Maciej and Hyatt.
3142 WebKit part of initial popup menu implementation.
3144 * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
3145 Initialize WKPopupMenu.
3147 2006-07-05 Anders Carlsson <acarlsson@apple.com>
3151 http://bugzilla.opendarwin.org/show_bug.cgi?id=3581
3152 iFrames set to display:none are Missing from frames array
3154 * WebCoreSupport/WebFrameBridge.m:
3155 (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
3156 (-[WebFrameBridge createChildFrameNamed:withURL:referrer:ownerElement:allowsScrolling:marginWidth:marginHeight:]):
3157 Modify to pass the owner element instead of the owner renderer.
3159 * WebView/WebHTMLView.m:
3160 (-[WebHTMLView _topHTMLView]):
3161 Remove assertion, it's not valid anymore.
3163 2006-07-05 Timothy Hatcher <timothy@apple.com>
3165 Reviewed by Harrison.
3167 <rdar://problem/4608423> HIViewAdapter used but not defined
3168 Adds a new export file to fix the build.
3170 * WebKit.LP64.exp: Added.
3171 * WebKit.xcodeproj/project.pbxproj:
3173 2006-07-04 Timothy Hatcher <timothy@apple.com>
3177 Bug 9731: [Drosera] crash when trying to access the scope chain
3178 http://bugzilla.opendarwin.org/show_bug.cgi?id=9731
3180 Because of <rdar://problem/4608404> the WebScriptObject, _globalObj, that
3181 WebCoreScriptDebugger holds is unprotected each time the page changes.
3182 This causes Drosera to crash Safari when trying to access the scope chain.
3183 We simply need to detach and re-attach the debugger when the window script
3184 object is cleared until 4608404 is fixed. This change also attaches the
3185 debugger before we call the windowScriptObjectAvailable: delegate method,
3186 so the debugger is ready before anyone might use the window object.
3188 * WebCoreSupport/WebFrameBridge.m:
3189 (-[WebFrameBridge windowObjectCleared]):
3191 2006-07-04 Timothy Hatcher <timothy@apple.com>
3195 Bug 9732: [Drosera] calling removeListener to many times will cause
3196 WebKit's listener count to underflow/wraparound
3197 http://bugzilla.opendarwin.org/show_bug.cgi?id=9732
3199 Adds a check to make sure the listener was in our listeners set before
3200 decrementing the global listener count. Also checks for nil in addListner
3201 to prevent a possible exception when adding the object to the set.
3203 * DefaultDelegates/WebScriptDebugServer.m:
3204 (-[WebScriptDebugServer addListener:]):
3205 (-[WebScriptDebugServer removeListener:]):
3207 2006-07-04 Alexey Proskuryakov <ap@nypop.com>
3211 - http://bugzilla.opendarwin.org/show_bug.cgi?id=8210
3212 Conditional XMLHttpRequest gets should pass 304 responses unchanged
3214 Test: http/tests/xmlhttprequest/cache-override.html
3216 * Misc/WebNSURLRequestExtras.h: Added _web_isConditionalRequest
3217 * Misc/WebNSURLRequestExtras.m:
3218 (-[NSURLRequest _web_isConditionalRequest]):
3219 * WebCoreSupport/WebFrameBridge.m:
3220 (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
3221 Bypass the cache for conditional requests.
3222 * WebCoreSupport/WebSubresourceLoader.m:
3223 (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]): Ditto.
3225 2006-07-01 David Kilzer <ddkilzer@kilzer.net>
3227 Reviewed by NOBODY (fixed Tim's build fix).
3229 * WebView/WebView.m: Added back missing '/' at the beginning of the file.
3231 2006-07-01 Tim Omernick <timo@apple.com>
3233 Reviewed by NOBODY (build fix)
3235 * WebView/WebView.m:
3236 (-[WebView _isMIMETypeRegisteredAsPlugin:]):
3237 Changed nil to NO (typo).
3239 === Safari-521.14 ===
3241 2006-06-30 Timothy Hatcher <timothy@apple.com>
3245 Only enable shouldCloseWithWindow when ObjC GC is enabled.
3246 This maintains backwards compatibility with applications
3247 that expect a WebView to be usable after the window closes.
3249 * WebView/WebView.m:
3250 (-[WebViewPrivate init]):
3252 2006-06-30 Timothy Hatcher <timothy@apple.com>
3256 Call _close in dealloc to ensure we cleanup for backwards
3257 compatibility. This will safeguard and cleanup even if the
3258 application doesn't use the new close API yet, like Mail.
3260 * WebView/WebView.m:
3261 (-[WebView dealloc]):
3263 2006-06-29 Timothy Hatcher <timothy@apple.com>
3267 <rdar://problem/4484405> WebKit leaks, improper tear-down
3268 <rdar://problem/3694059> -[WebBackForwardList finalize] is incorrect; design change needed
3269 <rdar://problem/3694103> -[WebFrame finalize] is incorrect; design change needed
3270 <rdar://problem/3694104> -[WebHTMLView finalize] is incorrect; design change needed
3272 Adds a close method to WebView, this needs to be called when the
3273 WebView is no longer needed. To make this easier for the common cases
3274 there is now an "auto close" on WebView that listens to the view's
3275 parent window. If the parent window closes and the WebView has no
3276 hostWindow then the WebView is automatically closed if autoClose is YES.
3277 To manage WebView closing yourself call setAutoClose: and pass NO.
3279 When a WebView closes it will tear-down and not be usable anymore.
3280 Close will will called on various other internal objects as a part
3281 of this, to ensure proper tear-down in GC without relying on finalize.
3283 * History/WebBackForwardList.m:
3284 (-[WebBackForwardList dealloc]):
3285 (-[WebBackForwardList finalize]):
3286 (-[WebBackForwardList _close]):
3287 * History/WebHistoryItem.m:
3288 (+[WebHistoryItem _closeObjectsInPendingPageCaches]):
3289 (+[WebHistoryItem _releaseAllPendingPageCaches]):
3290 * History/WebHistoryItemPrivate.h:
3291 * WebCoreSupport/WebFrameBridge.m:
3292 (-[WebFrameBridge close]):
3293 (-[WebFrameBridge saveDocumentToPageCache:]):
3294 (-[WebFrameBridge canGoBackOrForward:]):
3295 * WebView/WebFrame.m:
3296 (-[WebFrame _detachFromParent]):
3297 (-[WebFrame dealloc]):
3298 (-[WebFrame finalize]):
3299 * WebView/WebFrameView.m:
3300 (-[WebFrameView _setWebFrame:]):
3301 (-[WebFrameView finalize]):
3302 * WebView/WebHTMLView.m:
3303 (-[WebHTMLView close]):
3304 (-[WebHTMLView dealloc]):
3305 (-[WebHTMLView finalize]):
3306 * WebView/WebHTMLViewInternal.h:
3307 * WebView/WebHTMLViewPrivate.h:
3308 * WebView/WebScriptDebugDelegate.m:
3309 (-[WebScriptCallFrame _initWithFrame:initWithWebFrame:]):
3310 (-[WebScriptCallFrame parsedSource:fromURL:sourceId:startLine:errorLine:errorMessage:]):
3311 (-[WebScriptCallFrame enteredFrame:sourceId:line:]):
3312 (-[WebScriptCallFrame hitStatement:sourceId:line:]):
3313 (-[WebScriptCallFrame leavingFrame:sourceId:line:]):
3314 * WebView/WebScriptDebugDelegatePrivate.h:
3315 * WebView/WebView.m:
3316 (-[WebViewPrivate init]):
3317 (-[WebView _close]):
3318 (-[WebView dealloc]):
3319 (-[WebView finalize]):
3320 (-[WebView viewWillMoveToWindow:]):
3321 (-[WebView _windowWillClose:]):
3322 (-[WebView setPreferencesIdentifier:]):
3323 (-[WebView mainFrame]):
3324 (-[WebView setHostWindow:]):
3325 (-[WebView searchFor:direction:caseSensitive:wrap:]):
3326 (-[WebView writeSelectionWithPasteboardTypes:toPasteboard:]):
3328 (-[WebView setAutoClose:]):
3329 (-[WebView autoClose]):
3330 (-[WebView _frameViewAtWindowPoint:]):
3331 * WebView/WebViewPrivate.h:
3333 2006-06-29 Kevin Decker <kdecker@apple.com>
3335 Reviewed by mjs and timo.
3337 Fixed: <rdar://problem/4609119> handleAuthenticationFromResource was removed; needed by the Dashboard
3339 * WebView/WebViewPrivate.h: Added handleAuthenticationFromResource back into the header. Needed by the
3340 Dashboard, but was removed in r.14028 on 2006-04-23.
3342 2006-06-29 Tim Omernick <timo@apple.com>
3344 Reviewed by Kevin Decker.
3346 <rdar://problem/4608487> REGRESSION: reproducible crash in +[WebCoreFrameBridge supportedImageMIMETypes]
3348 * Plugins/WebPluginDatabase.m:
3349 (+[WebPluginDatabase setAdditionalWebPlugInPaths:]):
3350 One might be tempted to add additionalWebPlugInPaths to the global WebPluginDatabase here.
3351 For backward compatibility with earlier versions of the +setAdditionalWebPlugInPaths: SPI,
3352 we need to save a copy of the additional paths and not cause a refresh of the plugin DB
3354 (-[WebPluginDatabase _plugInPaths]):
3355 Include additionalWebPlugInPaths if this is the global DB.
3356 (-[WebPluginDatabase refresh]):
3357 Call -_plugInPaths to get the modified array of paths. This is similar to what the old code
3358 (before we had per-WebView plugin search paths).
3360 2006-06-29 Tim Omernick <timo@apple.com>
3362 Reviewed by John Sullivan.
3364 WebHistoryItem now supports getting and setting arbitrary properties via _transientPropertyForKey: and
3365 -_setTransientProperty:forKey:.
3366 For now, these properties do not persist with the rest of the history data. They are intended to hold transient
3367 per-history-item state, which is something that was until now difficult for a WebKit client app to do.
3369 * History/WebHistoryItemPrivate.h:
3370 * History/WebHistoryItem.m:
3371 (-[WebHistoryItemPrivate dealloc]):
3372 (-[WebHistoryItem _transientPropertyForKey:]):
3373 (-[WebHistoryItem _setTransientProperty:forKey:]):
3375 2006-06-29 Timothy Hatcher <timothy@apple.com>
3377 Reviewed by Harrison.
3379 Smart insert and delete, continuous spell checking and autoscroll
3380 can now be used for any WebView, not just editable ones. All of
3381 these make sense for documents that might contain content editable
3382 areas or our new text fields. Autoscroll is usefull for dragging
3383 for file input controls also.
3385 Added a SPI to toggle WebViews tab key behavior, tabKeyCyclesThroughElements.
3386 WebHTMLView's _interceptEditingKeyEvent now uses WebView's
3387 tabKeyCyclesThroughElements state to determine whether or not
3388 to process tab key events. The idea here is that tabKeyCyclesThroughElements
3389 will be YES when this WebView is being used in a browser, and we
3390 desire the behavior where tab moves to the next element in tab order.
3391 If tabKeyCyclesThroughElements is NO, it is likely that the WebView
3392 is being embedded as the whole view, as in Mail, and tabs should input
3393 tabs as expected in a text editor. Using Option-Tab always cycles
3396 * WebView/WebHTMLRepresentation.m:
3397 (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
3398 * WebView/WebHTMLView.m:
3399 (-[WebHTMLView _interceptEditingKeyEvent:]):
3400 * WebView/WebView.m:
3401 (-[WebViewPrivate init]):
3402 (-[WebView _autoscrollForDraggingInfo:timeDelta:]):
3403 (-[WebView _shouldAutoscrollForDraggingInfo:]):
3404 (-[WebView validateUserInterfaceItem:]):
3405 (-[WebView toggleSmartInsertDelete:]):
3406 (-[WebView toggleContinuousSpellChecking:]):
3407 (-[WebView setTabKeyCyclesThroughElements:]):
3408 (-[WebView tabKeyCyclesThroughElements]):
3409 * WebView/WebViewPrivate.h:
3411 2006-06-29 Anders Carlsson <acarlsson@apple.com>
3415 * WebKit.xcodeproj/project.pbxproj:
3416 Add DOMXPath.h header.
3418 2006-06-28 David Hyatt <hyatt@apple.com>
3420 Fix custom highlighting so that you can paint the entire line (and go
3421 outside the bounds of the line).
3423 Reviewed by harrison
3425 * WebCoreSupport/WebFrameBridge.m:
3426 (-[WebFrameBridge customHighlightRect:forLine:]):
3427 (-[WebFrameBridge paintCustomHighlight:forBox:onLine:behindText:entireLine:]):
3428 * WebKit.xcodeproj/project.pbxproj:
3429 * WebView/WebHTMLViewPrivate.h:
3431 2006-06-28 Maciej Stachowiak <mjs@apple.com>
3435 - fix Frame leak on layout tests
3437 * WebCoreSupport/WebPageBridge.m:
3438 (-[WebPageBridge outerView]): Return WebFrameView for main frame instead
3439 of WebView to avoid reference cycle between WebView and Page.
3441 2006-06-28 Timothy Hatcher <timothy@apple.com>
3443 Prefer the Stabs debugging symbols format until DWARF bugs are fixed.
3445 * WebKit.xcodeproj/project.pbxproj:
3447 2006-06-28 Levi Weintraub <lweintraub@apple.com>
3451 http://bugzilla.opendarwin.org/show_bug.cgi?id=7568
3452 Bug 7568: Implement Indent/Outdent
3453 Added undo action strings and enum values
3455 * English.lproj/Localizable.strings:
3456 * WebCoreSupport/WebFrameBridge.m:
3457 (-[WebFrameBridge nameForUndoAction:]):
3459 2006-06-27 Brady Eidson <beidson@apple.com>
3463 Hookup the new semi-functional SQLite icon database.
3464 For now, it is living side-by-side with the old DB so one can compare the
3465 two for debugging purposes. Also, it is disabled (in WebKit) by default unless you
3466 compile with ICONDEBUG #defined.
3467 Note: To repeat that, if you want to try the new DB, #define ICONDEBUG (WebKitPrefix.h is a good place to do it)
3469 * Misc/WebIconDatabase.m:
3470 (-[NSMutableDictionary iconForURL:withSize:cache:]):
3471 (-[NSMutableDictionary iconURLForURL:]):
3472 (-[NSMutableDictionary retainIconForURL:]):
3473 (-[NSMutableDictionary releaseIconForURL:]):
3474 (-[WebIconDatabase _setHaveNoIconForIconURL:]):
3475 (-[WebIconDatabase _setIconURL:forURL:]):
3476 (-[WebIconDatabase _hasIconForIconURL:]):
3477 (-[WebIconDatabase _resetCachedWebPreferences:]):
3478 * Misc/WebIconLoader.m:
3479 (-[WebIconLoader didFinishLoading]):
3480 * WebKit.xcodeproj/project.pbxproj:
3482 2006-06-26 David Hyatt <hyatt@apple.com>
3484 Fix for 9538, support syntax highlighting for HTML source.
3488 * WebKit.xcodeproj/project.pbxproj:
3489 * WebView/WebView.m:
3490 (-[WebView _setInViewSourceMode:]):
3491 (-[WebView _inViewSourceMode]):
3492 * WebView/WebViewPrivate.h:
3494 2006-06-25 Timothy Hatcher <timothy@apple.com>
3498 Bug 9574: Drosera should show inline scripts within the original HTML
3499 http://bugzilla.opendarwin.org/show_bug.cgi?id=9574
3501 * Adds a new version of the didParseSource delegate callback with base line number.
3502 * Adds a new delegate callback for when a script fails to parse.
3503 * These new callbacks use NSURLs for the url parameter.
3504 * Adds a new script listener callback to notify when the main resource loads.
3505 * Adds a WebScriptErrorDomian and other keys for use with NSError.
3507 * DefaultDelegates/WebDefaultScriptDebugDelegate.m:
3508 (-[WebDefaultScriptDebugDelegate webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
3509 (-[WebDefaultScriptDebugDelegate webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
3510 * DefaultDelegates/WebScriptDebugServer.h:
3511 * DefaultDelegates/WebScriptDebugServer.m:
3512 (-[WebScriptDebugServer webView:didLoadMainResourceForDataSource:]):
3513 (-[WebScriptDebugServer webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
3514 (-[WebScriptDebugServer webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
3515 * DefaultDelegates/WebScriptDebugServerPrivate.h:
3517 * WebView/WebDataSource.m:
3518 (-[WebDataSource _setPrimaryLoadComplete:]):
3519 * WebView/WebScriptDebugDelegate.h:
3520 * WebView/WebScriptDebugDelegate.m:
3521 (-[WebScriptCallFrame parsedSource:fromURL:sourceId:startLine:errorLine:errorMessage:]):
3523 2006-06-24 David Kilzer <ddkilzer@kilzer.net>
3525 Reviewed by Timothy.
3527 * Info.plist: Fixed copyright to include 2003-2006.
3529 2006-06-24 Alexey Proskuryakov <ap@nypop.com>
3533 - http://bugzilla.opendarwin.org/show_bug.cgi?id=9418
3534 WebKit will not build when Space exists in path
3536 * WebKit.xcodeproj/project.pbxproj: Enclose search paths in quotes.
3538 2006-06-23 Tim Omernick <timo@apple.com>