1 2006-09-28 Timothy Hatcher <timothy@apple.com>
5 Switch the inspector over to use border-image with styled buttons and selects.
7 * WebInspector/WebInspector.m:
9 (-[NSWindow setWebFrame:]):
10 (-[WebInspector _updateRoot]):
11 * WebInspector/webInspector/Images/button.png: Added.
12 * WebInspector/webInspector/Images/buttonDivider.png: Added.
13 * WebInspector/webInspector/Images/buttonPressed.png: Added.
14 * WebInspector/webInspector/Images/popup.png: Added.
15 * WebInspector/webInspector/Images/popupFill.png: Removed.
16 * WebInspector/webInspector/Images/popupFillPressed.png: Removed.
17 * WebInspector/webInspector/Images/popupLeft.png: Removed.
18 * WebInspector/webInspector/Images/popupLeftPressed.png: Removed.
19 * WebInspector/webInspector/Images/popupPressed.png: Added.
20 * WebInspector/webInspector/Images/popupRight.png: Removed.
21 * WebInspector/webInspector/Images/popupRightPressed.png: Removed.
22 * WebInspector/webInspector/Images/squareButtonRight.png: Removed.
23 * WebInspector/webInspector/Images/squareButtonRightPressed.png: Removed.
24 * WebInspector/webInspector/inspector.css:
25 * WebInspector/webInspector/inspector.html:
26 * WebInspector/webInspector/inspector.js:
28 2006-09-28 Alice Liu <alice.liu@apple.com>
30 fixing the windows build
33 (WebView::mouseMoved):
36 (WebView::mouseDoubleClick):
38 2006-09-27 Justin Garcia <justin.garcia@apple.com>
42 <rdar://problem/4044271>
43 Writing Direction menu doesn't reflect the current writing direction (9773)
45 * English.lproj/Localizable.strings: Added "Right to Left" and "Left to Right"
46 * WebView/WebHTMLView.m:
47 (-[NSArray validateUserInterfaceItem:]): Validate menu items that perform
48 toggleBaseWritingDirection and changeBaseWritingDirection.
49 Disable the menu item that changes the writing direction to NSWritingDirectionNautral
50 because NSWritingDirectionNatural's behavior can't be implemented with CSS.
51 Take control of the title of the menu item that performs toggleBaseWritingDirection:
52 instead of checking/unchecking it, otherwise we wouldn't know what a check means.
53 (-[NSArray changeBaseWritingDirection:]): ASSERT that the requested writing
54 direction is not NSWritingDirectionNatural, since we've disabled the
55 menu item that performs it.
57 2006-09-27 MorganL <morganl.webkit@yahoo.com>
59 Reviewed by Maciej, landed by Brady
61 Update URL request associated with provisional data source on redirect.
62 Notify IWebFrameLoadDelegate of redirects for the provisional load.
63 Notify IWebFrameLoadDelegate of a provisional load being commited.
65 * COM/WebDataSource.cpp:
66 (WebDataSource::replaceRequest):
67 * COM/WebDataSource.h:
69 (WebFrame::receivedRedirect):
70 (WebFrame::receivedResponse):
71 (WebFrame::receivedData):
73 2006-09-26 John Sullivan <sullivan@apple.com>
77 * WebView/WebHTMLViewPrivate.h:
78 * WebView/WebHTMLView.m:
79 (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]):
80 Added limit parameter, passed over the bridge. Stop the search if it hits limit.
82 * WebView/WebViewPrivate.h:
84 (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):
85 Added limit parameter, passed to WebHTMLView.
87 2006-09-26 David Harrison <harrison@apple.com>
89 Reviewed by John and TimH.
91 <rdar://problem/4743256> Seed: Ctrl-Y key binding does nothing when kill ring is empty
93 Use deleteBackward: when the killring string is empty. Was always using insertText:,
94 but that ends up early-returning if the string to insert is empty.
96 * WebView/WebHTMLView.m:
98 (-[NSArray yankAndSelect:]):
100 2006-09-25 Timothy Hatcher <timothy@apple.com>
104 Use the non-deprecated method names for getComputedStyle, setEnd and setStart.
106 * WebInspector/WebInspector.m:
107 (-[WebInspector _highlightNode:]):
108 * WebView/WebHTMLView.m:
110 (-[WebHTMLView _selectRangeInMarkedText:]):
111 (-[WebTextCompleteController doCompletion]):
113 (-[WebView computedStyleForElement:pseudoElement:]):
115 2006-09-22 Timothy Hatcher <timothy@apple.com>
119 Pass all headers through unifdef to filter out BUILDING_ON_TIGER blocks
120 if MACOSX_DEPLOYMENT_TARGET is 10.4.
122 * MigrateHeaders.make:
124 2006-09-20 Justin Garcia <justin.garcia@apple.com>
128 <http://bugs.webkit.org/show_bug.cgi?id=7165>
129 TinyMCE: Dragging & dropping content always leaves a copy when editing inside a subframe
131 The top level WebHTMLView is responsible for performing dragging operations, but
132 the inner view, the view that holds the drag caret, should be consulted to determine
133 if the drag is a move drag.
135 * WebCoreSupport/WebFrameBridge.m:
136 (-[WebFrameBridge startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
137 * WebKit.xcodeproj/project.pbxproj:
138 * WebView/WebHTMLView.m:
139 (-[NSArray dragImage:at:offset:event:pasteboard:source:slideBack:]): Don't set initatedDrag here, because
140 it's only the top level WebHTMLView that performs this operation.
141 (-[WebHTMLView _setInitiatedDrag:]): Added.
142 (-[WebHTMLView _initiatedDrag]): Ditto.
143 (-[WebHTMLView _canProcessDragWithDraggingInfo:]): Ask the innerView if it initiated the drag,
144 not the top level view.
145 (-[WebHTMLView _isMoveDrag]): The top level view asks the innerView if it should perform
146 a move drag, so don't ASSERT _isTopHTMLView.
147 (-[WebHTMLView draggingUpdatedWithDraggingInfo:actionMask:]): Ask the innerView if _isMoveDrag.
148 (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): Ditto.
149 * WebView/WebHTMLViewInternal.h: Added two private SPI so that
150 the top level WebHTMLView can set and get the initiatedDrag BOOL.
152 === Safari-521.27 ===
154 2006-09-20 Brady Eidson <beidson@apple.com>
156 Reviewed by Tim Omernick
158 Fixing part of a crash Tim O showed me. [WebIconDatabase init] should finish
159 gracefully even if we can't open the database
161 * Misc/WebIconDatabase.m:
162 (-[WebIconDatabase init]):
164 2006-09-20 Timothy Hatcher <timothy@apple.com>
168 <rdar://problem/4741392> Develop a system to find what version of WebKit an app was linked with
170 * Misc/WebKitVersionChecks.h: Added.
171 * Misc/WebKitVersionChecks.m: Added.
172 (WebKitLinkedOnOrAfter): Added.
173 (WebKitLinkTimeVersion): Added.
174 (WebKitRunTimeVersion): Added.
175 * WebKit.xcodeproj/project.pbxproj:
177 2006-09-20 Tim Omernick <timo@apple.com>
181 * Misc/WebIconDatabase.m:
182 (-[WebIconDatabase init]):
185 2006-09-20 Brady Eidson <beidson@apple.com>
189 Preparing to make the WebIconDatabase disabled by default - this patch tells the bridge whether its enabled or not
191 * Misc/WebIconDatabase.m:
192 (-[WebIconDatabase init]):
194 2006-09-19 Brady Eidson <beidson@apple.com>
196 Reviewed by Sarge Decker
198 <rdar://problem/4739892> and <rdar://problem/4729797>
199 - WebCore::IconDatabase needs to have and respect an enabled() flag
200 - Mail on ToT WebKit crashes in IconDatabase code when mailing a page from Safari
202 * Misc/WebIconDatabase.m:
203 (-[WebIconDatabase init]): If preference says icons are disabled, tell the bridge
204 (-[WebIconDatabase _isEnabled]): Ask the bridge if the database is enabled
206 2006-09-19 Alexey Proskuryakov <ap@nypop.com>
210 http://bugs.webkit.org/show_bug.cgi?id=10661
211 REGRESSION: CFM plug-ins (Shockwave, SVG) are not loaded
213 * Plugins/WebBasePluginPackage.m:
214 (-[WebBasePluginPackage initWithPath:]): On 32-bit PowerPC, don't bail out if
215 the bundle is nil - it can be a CFM plugin.
217 2006-09-18 Brady Eidson <beidson@apple.com>
221 Implement a bridge method so WebCore can find the reload type of a frame load
223 * WebCoreSupport/WebFrameBridge.m:
224 (-[WebFrameBridge isLoadTypeReload]):
226 2006-09-18 Sam Weinig <sam.weinig@gmail.com>
230 Patch for http://bugs.webkit.org/show_bug.cgi?id=10903
231 Yet Another Objective-C Bindings Patch
233 * MigrateHeaders.make:
235 2006-09-17 David Harrison <harrison@apple.com>
237 Reviewed by John Sullivan.
239 <rdar://problem/4494340> REGRESSION: Making the font size bigger/smaller in an HTML message doesn't affect the body until you reopen it
241 Problem was the public API -[WebView setTextSizeMultiplier] did not notify anyone that the value changed.
243 * WebView/WebDocumentInternal.h:
244 Add _textSizeMultiplierChanged to the _WebDocumentTextSizing protocol.
246 * WebView/WebHTMLView.m:
247 (-[WebHTMLView _textSizeMultiplierChanged]):
248 Send [self _updateTextSizeMultiplier].
250 * WebView/WebPDFView.m:
251 (-[WebPDFView _textSizeMultiplierChanged]):
252 ASSERT_NOT_REACHED() because WebPDFView does not track the common multiplier.
255 (-[WebView setTextSizeMultiplier:]):
256 Send [self _notifyTextSizeMultiplierChanged];
258 (-[WebView _performTextSizingSelector:withObject:onTrackingDocs:selForNonTrackingDocs:newScaleFactor:]):
259 Alter the _textSizeMultiplier directly so that notification is not sent.
262 (-[WebView _notifyTextSizeMultiplierChanged]):
263 New. Send _textSizeMultiplierChanged to all document views that track the common multiplier.
265 2006-09-16 Brady Eidson <beidson@apple.com>
269 WebIconLoader is dead, long live WebCore::IconLoader
272 * Loader/WebFrameLoader.h:
273 * Loader/WebFrameLoader.m:
274 (-[WebFrameLoader dealloc]):
275 (-[WebFrameLoader commitProvisionalLoad]):
276 * Loader/WebIconLoader.h: Removed.
277 * Loader/WebIconLoader.m: Removed.
278 * Misc/WebIconDatabase.h:
279 * Misc/WebIconDatabase.m:
280 * Misc/WebIconDatabasePrivate.h:
281 * WebCoreSupport/WebFrameBridge.m:
282 (-[WebFrameBridge notifyIconChanged:]):
283 * WebCoreSupport/WebIconDatabaseBridge.h:
284 * WebCoreSupport/WebIconDatabaseBridge.m:
285 (-[WebIconDatabaseBridge _init]):
286 (-[WebIconDatabaseBridge _setIconData:forIconURL:]):
287 (-[WebIconDatabaseBridge _setHaveNoIconForIconURL:]):
289 * WebKit.xcodeproj/project.pbxproj:
290 * WebView/WebDataSource.m:
291 (-[WebDataSourcePrivate dealloc]):
292 (-[WebDataSource _stopLoading]):
293 (-[WebDataSource _setPrimaryLoadComplete:]):
294 * WebView/WebDataSourceInternal.h:
296 2006-09-16 Mark Rowe <opendarwin.org@bdash.net.nz>
300 http://bugs.webkit.org/show_bug.cgi?id=10887
303 * MigrateHeaders.make: Remove reference to DOMEventPrivate.h.
305 2006-09-15 Timothy Hatcher <timothy@apple.com>
309 Make new style ObjC methods public API.
311 * MigrateHeaders.make:
313 2006-09-15 Sam Weinig <sam.weinig@gmail.com>
317 Patch for http://bugs.webkit.org/show_bug.cgi?id=10870
318 Auto-generate DOMNode for the Objective-C bindings
320 * MigrateHeaders.make:
322 2006-09-15 Timothy Hatcher <timothy@apple.com>
326 Call the bridge directly for alter selection calls. All of this logic is now
327 in WebCore's SelectionController.
329 * WebView/WebHTMLView.m:
330 (-[NSArray moveBackward:]):
331 (-[NSArray moveBackwardAndModifySelection:]):
332 (-[NSArray moveDown:]):
333 (-[NSArray moveDownAndModifySelection:]):
334 (-[NSArray moveForward:]):
335 (-[NSArray moveForwardAndModifySelection:]):
336 (-[NSArray moveLeft:]):
337 (-[NSArray moveLeftAndModifySelection:]):
338 (-[NSArray moveRight:]):
339 (-[NSArray moveRightAndModifySelection:]):
340 (-[NSArray moveToBeginningOfDocument:]):
341 (-[NSArray moveToBeginningOfDocumentAndModifySelection:]):
342 (-[NSArray moveToBeginningOfSentence:]):
343 (-[NSArray moveToBeginningOfSentenceAndModifySelection:]):
344 (-[NSArray moveToBeginningOfLine:]):
345 (-[NSArray moveToBeginningOfLineAndModifySelection:]):
346 (-[NSArray moveToBeginningOfParagraph:]):
347 (-[NSArray moveToBeginningOfParagraphAndModifySelection:]):
348 (-[NSArray moveToEndOfDocument:]):
349 (-[NSArray moveToEndOfDocumentAndModifySelection:]):
350 (-[NSArray moveToEndOfSentence:]):
351 (-[NSArray moveToEndOfSentenceAndModifySelection:]):
352 (-[NSArray moveToEndOfLine:]):
353 (-[NSArray moveToEndOfLineAndModifySelection:]):
354 (-[NSArray moveToEndOfParagraph:]):
355 (-[NSArray moveToEndOfParagraphAndModifySelection:]):
356 (-[NSArray moveParagraphBackwardAndModifySelection:]):
357 (-[NSArray moveParagraphForwardAndModifySelection:]):
358 (-[NSArray moveUp:]):
359 (-[NSArray moveUpAndModifySelection:]):
360 (-[NSArray moveWordBackward:]):
361 (-[NSArray moveWordBackwardAndModifySelection:]):
362 (-[NSArray moveWordForward:]):
363 (-[NSArray moveWordForwardAndModifySelection:]):
364 (-[NSArray moveWordLeft:]):
365 (-[NSArray moveWordLeftAndModifySelection:]):
366 (-[NSArray moveWordRight:]):
367 (-[NSArray moveWordRightAndModifySelection:]):
368 (-[NSArray pageUp:]):
369 (-[NSArray pageDown:]):
370 (-[NSArray pageUpAndModifySelection:]):
371 (-[NSArray pageDownAndModifySelection:]):
373 2006-09-15 Adam Roben <aroben@apple.com>
377 Fixes http://bugs.webkit.org/show_bug.cgi?id=10876
378 containsItemForURLUnicode uses matchLetter instead of
381 Small fixes for _WebCoreHistoryProvider.
383 * History/WebHistory.m: Consistently use BUFFER_SIZE #define
384 (-[_WebCoreHistoryProvider containsItemForURLLatin1:length:]):
385 (-[_WebCoreHistoryProvider containsItemForURLUnicode:length:]):
386 Replace incorrect call to matchLetter to matchUnicodeLetter
388 2006-09-13 Brady Eidson <beidson@apple.com>
392 Add infrastructure to support icon loads taking place in WebCore
393 Will remove WebKit icon loaders in a later patch
395 * WebCoreSupport/WebFrameBridge.m:
396 (-[WebFrameBridge notifyIconChanged:]):
397 (-[WebFrameBridge originalRequestURL]):
398 - Nuked two old, obsolete methods
399 - Added bridge for notifying of an icon change
400 - Added bridge for getting the "original request URL" which is still needed
401 until that info is available in the WebCore loaders
403 * WebView/WebDataSource.m:
404 (-[WebDataSource _loadIcon]):
405 - Empty body just for now, as it still gets called - next patch will prune all the old impl out
407 2006-09-13 Timothy Hatcher <timothy@apple.com>
411 <rdar://problem/4726416> obsolete confusing "ADVISORY NOTE" comment in WebHistory.h
413 Removed the "ADVISORY NOTE: This method may change for the 1.0 SDK" comments.
415 * History/WebHistory.h:
417 === Safari-521.26 ===
419 2006-09-11 MorganL <morlmor@yahoo.com>
421 Reviewed/landed by aroben.
423 Fixes http://bugs.webkit.org/show_bug.cgi?id=10765
424 Windows build busted due to std::copy usage in Vector.h
426 * WebKit.vcproj/WebKit.vcproj: Define _SCL_SECURE_NO_DEPRECATE to get
427 rid of deprecation warnings on std::copy
429 2006-09-11 Brady Eidson <beidson@apple.com>
431 Despite the fact that some people built okay without this change, it sure was biting me,
432 probably because I just wiped my build directory for a fresh build -
433 Today's earlier removal of DOMList.h needed to occur in MigrateHeaders.make, as well
435 * MigrateHeaders.make: removed DOMList.h
437 2006-09-10 Darin Adler <darin@apple.com>
441 - fix http://bugs.webkit.org/show_bug.cgi?id=10547
442 REGRESSION: Links that should open in a new window open in the same window,
443 while opening another blank window
445 * WebView/WebFrame.m:
446 (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
447 Changed a mistaken "self" to "frame", which was the cause of the bug. Also
448 fixed the method so that it won't crash if createWebViewWithRequest does
449 something that has a side effect of releasing this WebView or this frame
450 by retaining "self" and "frame" as needed. Also fixed a problem where the
451 code to set "opener" was backwards, and would set the opener of the old
452 frame to point to the new frame instead of vice versa.
454 2006-09-09 Sam Weinig <sam.weinig@gmail.com>
458 Patch for http://bugs.webkit.org/show_bug.cgi?id=10795
459 Auto-generate the Objective-C DOM XPath bindings
461 * MigrateHeaders.make:
463 2006-09-09 Sam Weinig <sam.weinig@gmail.com>
467 Patch for http://bugs.webkit.org/show_bug.cgi?id=10791
468 Even More Objective-C DOM auto-generation cleanup
470 * MigrateHeaders.make:
472 2006-09-08 Tim Omernick <timo@apple.com>
474 Reviewed by Brady Eidson.
476 Rolled out Maciej's code cleanup from 8/22. It turns out that keeping the "loading" flag
477 is a useful optimization, as it avoids many Objective-C method calls while polling resources
478 for their load state.
480 This fixes a 3-4% PLT performance regression (as measured on my MacBook Pro).
482 * Loader/WebFrameLoader.m:
483 (-[WebFrameLoader addPlugInStreamLoader:]):
484 (-[WebFrameLoader removePlugInStreamLoader:]):
485 (-[WebFrameLoader addSubresourceLoader:]):
486 (-[WebFrameLoader removeSubresourceLoader:]):
487 * WebView/WebDataSource.m:
488 (-[WebDataSourcePrivate dealloc]):
489 (-[WebDataSource _prepareForLoadStart]):
490 (-[WebDataSource _setLoading:]):
491 (-[WebDataSource _updateLoading]):
492 (-[WebDataSource _startLoading]):
493 (-[WebDataSource _stopLoading]):
494 (-[WebDataSource _setPrimaryLoadComplete:]):
495 (-[WebDataSource isLoading]):
496 * WebView/WebDataSourceInternal.h:
498 2006-09-07 Sam Weinig <sam.weinig@gmail.com>
500 Reviewed by Darin and Tim H.
502 Patch for http://bugs.webkit.org/show_bug.cgi?id=10774
503 Auto-generate the Objective-C DOM Traversal bindings
505 * MigrateHeaders.make:
507 2006-09-07 Sam Weinig <sam.weinig@gmail.com>
511 Patch for http://bugs.webkit.org/show_bug.cgi?id=10766
512 Auto-generate the Objective-C DOM Events bindings
514 * MigrateHeaders.make:
515 * WebKit.xcodeproj/project.pbxproj:
517 2006-09-06 Alexey Proskuryakov <ap@nypop.com>
519 * MigrateHeaders.make: Fixed a double slash in
520 "$(PRIVATE_HEADERS_DIR)//DOMCharacterDataPrivate.h" (this was reported
521 to cause a build failure under certain circumstances).
523 2006-09-05 MorganL <morlmor@yahoocom>
525 Reviewed/landed by aroben.
527 Fixes bug 10743: Windows build is busted.
532 2006-09-05 Timothy Hatcher <timothy@apple.com>
536 Drastically simplified the makefile for migrating headers from
537 WebCore and JavaScriptCore. The old version was always copying the files.
539 * MigrateHeaders.make:
541 2006-09-05 Darin Adler <darin@apple.com>
545 - WebKit side of changes to encoding
547 * WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation documentSource]):
548 Changed to call new -[WebCoreFrameBridge stringWithData:] instead of the calling
549 the old methods that used a CFStringEncoding: -[WebCoreFrameBridge textEncoding]
550 and +[WebCoreFrameBridge stringWithData:textEncoding:].
552 * WebView/WebResource.m: (-[WebResource _stringValue]): Removed special case for
553 nil encoding name. The bridge itself now has the rule that "nil encoding name
554 means Latin-1", so we don't need to check for nil.
556 * WebView/WebFrame.m: (-[WebFrame _checkLoadComplete]): Retain the frame until
557 we get the parent frame while walking up parent frames, because it's possible
558 for _checkLoadCompleteForThisFrame to release the last reference to the frame.
559 (Not reviewed; needed to run performance tests successfully.)
561 2006-09-05 Timothy Hatcher <timothy@apple.com>
565 <rdar://problem/4682225> conflicting typedefs in Netscape plug-in headers
567 * Plugins/npfunctions.h: fix the return type for NPN_IntFromIdentifierProcPtr to be int32_t
569 2006-09-04 Timothy Hatcher <timothy@apple.com>
573 Bug 10714: ObjC autogeneration needs safe-guards against easily modifying the public API
574 http://bugs.webkit.org/show_bug.cgi?id=10714
576 - Added the new private DOM headers.
577 - Factored out the common commands into variables.
578 - Made WebDashboardRegion.h private again.
579 - Rename DOMDOMImplementation.h to DOMImplementation.h when files
580 are migrated. Also fixes up #imports.
582 * MigrateHeaders.make:
584 2006-09-03 Sam Weinig <sam.weinig@gmail.com>
586 Reviewed by Darin and Tim H.
588 - patch for http://bugs.webkit.org/show_bug.cgi?id=10711
589 Auto-generate the Objective-C DOM Stylesheet bindings
591 * MigrateHeaders.make:
593 2006-09-02 Sam Weinig <sam.weinig@gmail.com>
597 - patch for http://bugs.webkit.org/show_bug.cgi?id=10684
598 Auto-generate the Objective-C DOM CSS bindings
600 * MigrateHeaders.make:
602 2006-09-01 MorganL <morlmor@yahoo.com>
604 Reviewed by Darin. Updated/landed by Adam.
606 Fixes http://bugs.webkit.org/show_bug.cgi?id=10553
610 (WebFrame::initWithName):
612 2006-09-01 Brady Eidson <beidson@apple.com>
616 A "never should be reached" method was reached - lets not release the shared database bridge, esp
617 since we never retain it!
619 * Misc/WebIconDatabase.m:
620 (-[WebIconDatabase _applicationWillTerminate:]): Don't release the bridge
622 2006-09-01 Darin Adler <darin@apple.com>
626 - a few small tweaks to the icon database bridge
628 * Misc/WebIconDatabase.m: (-[WebIconDatabase init]): Updated for name change.
630 * WebCoreSupport/WebIconDatabaseBridge.h: Removed unneeded declarations.
631 * WebCoreSupport/WebIconDatabaseBridge.m:
632 (-[WebIconDatabaseBridge init]): Added. Always returns nil since you're not supposed
633 to allocate one of these.
634 (-[WebIconDatabaseBridge _init]): Renamed from init. Used internally to make the
635 shared instance. Added the "self = [super init]" idiom even though it's not important
636 in this case just to be consistent.
637 (-[WebIconDatabaseBridge releaseCachedLoaderForIconURL:]): Moved this up in the file
638 so it can be called without declaring it in the header.
639 (+[WebIconDatabaseBridge sharedInstance]): Renamed. Calls the new _init. Also use
640 CFRetain for compatibility.
641 (-[WebIconDatabaseBridge dealloc]): Emptied this out and made it just assert (false).
642 (-[WebIconDatabaseBridge finalize]): Added and made it assert (false) too.
644 2006-09-01 Timothy Hatcher <timothy@apple.com>
648 Bug 10677: Omit "-webkit-text-security: none;" from the computed style list
649 http://bugs.webkit.org/show_bug.cgi?id=10677
651 * WebInspector/webInspector/inspector.js:
653 2006-08-31 Sam Weinig <sam.weinig@gmail.com>
657 - patch for http://bugs.webkit.org/show_bug.cgi?id=10669
658 Auto-generate the remaining Objective-C HTML DOM bindings
660 * MigrateHeaders.make:
662 2006-08-31 Adele Peterson <adele@apple.com>
666 WebKit part of fix for http://bugs.webkit.org/show_bug.cgi?id=10666
667 Password: Disallow Spelling, Font, Speech, and Writing Direction context menu
669 * DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
670 Check that the selection isn't in a password field before adding these items to the default editing context menu.
671 Search In Google, Search In Spotlight, Look up in Dictionary, Spelling, Font, Speech, Writing Direction
672 * WebView/WebHTMLView.m: (-[WebHTMLView _isSelectionInPasswordField]): Added.
673 * WebView/WebHTMLViewPrivate.h:
675 2006-08-31 Sam Weinig <sam.weinig@gmail.com>
679 - patch for http://bugs.webkit.org/show_bug.cgi?id=10653
680 Auto-generate another 20 Objective-C DOM HTML bindings
682 * MigrateHeaders.make:
683 * WebKit.xcodeproj/project.pbxproj:
685 2006-08-31 Adele Peterson <adele@apple.com>
687 Reviewed by John Sullivan.
689 Removed wkSecureEventInput and wkSetSecureEventInput, since this can be done with API.
691 * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
693 2006-08-31 John Sullivan <sullivan@apple.com>
695 Reviewed by Tim Omernick
697 - fixed <rdar://problem/4711200> Loading history would be faster if it bypassed
698 NSURL API for local files
700 * History/WebHistory.m:
701 (-[WebHistoryPrivate _loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):
702 Load file URLs using [NSDictionary dictionaryWithContentsOfFile:]. I also cleaned up some minor
703 style issues in this method, and I removed the support for old NSArray-style history files (which we
704 stopped using before Safari 1.0).
706 2006-08-30 Adele Peterson <adele@apple.com>
710 WebKit part of fix for http://bugs.webkit.org/show_bug.cgi?id=10575
711 Enable secure input mode for new password fields
713 * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
715 2006-08-30 Brady Eidson <beidson@apple.com>
719 <rdar://problem/4707718> Change behavior so if the WebCore::IconDatabase can't open, WebKit releases the bridge and
720 continues on as if the IconDatabase is disabled.
722 * Misc/WebIconDatabase.m:
723 (-[WebIconDatabase init]): Release the bridge on failure to open
724 * WebCoreSupport/WebIconDatabaseBridge.m:
725 (+[WebIconDatabaseBridge sharedBridgeInstance]): Moved static shared instance out as a global
726 (-[WebIconDatabaseBridge dealloc]): Clear pointer to the shared instance
728 2006-08-30 Timothy Hatcher <timothy@apple.com>
732 Simplify the header copies from WebCore and JavaScriptCore.
733 Headers that need to be migrated from the other projects need
734 to be added to MigrateHeaders.make.
736 * MigrateHeaders.make: Added.
737 * WebKit.xcodeproj/project.pbxproj:
739 2006-08-30 Sam Weinig <sam.weinig@gmail.com>
743 - patch for http://bugs.webkit.org/show_bug.cgi?id=10640
744 Auto-generate 10 more Objective-C DOM HTML bindings
746 * WebKit.xcodeproj/project.pbxproj:
748 2006-08-30 Adele Peterson <adele@apple.com>
752 WebKit part of fix for:
753 http://bugs.webkit.org/show_bug.cgi?id=10576
754 Disallow copy from new password fields
756 * WebView/WebHTMLView.m:
757 (-[WebHTMLView _canCopy]): Now also calls across the bridge to ask if it mayCopy.
758 (-[WebHTMLView _canCut]): Calls _canCopy now.
759 (-[NSArray validateUserInterfaceItem:]): Calls _canCut when validating the "Cut" menu item.
760 This used to call _canDelete (which used to be the same as _canCut), but now _canCut also checks _canCopy.
762 2006-08-30 Karl Adam <karladam@yahoo-inc.com>
764 Reviewed by Eric and Tim H.
766 Bug 10634: -webView:dragDestinationActionMaskForDraggingInfo: is ignored
767 http://bugs.webkit.org/show_bug.cgi?id=10634
769 Remove the check for canShowFile: from _web_bestURL: since
770 it shouldn't be concerned with whether or not the view
771 can show the URL, merely return the most appropriate URL.
773 * Misc/WebNSPasteboardExtras.m:
774 (-[NSPasteboard _web_bestURL]):
775 * Misc/WebNSViewExtras.m:
776 (-[NSView _web_dragOperationForDraggingInfo:]):
778 2006-08-29 Brady Eidson <beidson@apple.com>
780 Reviewed by Kevin Decker (Sarge)
782 <rdar://problem/4678414> - New IconDB needs to delete icons when asked
784 * Misc/WebIconDatabase.m:
785 (-[WebIconDatabase removeAllIcons]): Call through to WebCore to remove icons, then send notification
787 2006-08-29 Brady Eidson <beidson@apple.com>
791 Added a truth value check for to setIconURL:forURL so WebKit can avoid sending a notification
792 This is a win on the iBench
794 * Misc/WebIconDatabase.m:
795 (-[WebIconDatabase _setIconURL:forURL:]):
797 2006-08-29 Brady Eidson <beidson@apple.com>
799 Reviewed by Tim Hatchers rubber stamp
801 Removed some accidentally left-in console spew during the conversion to the new DB
803 * Misc/WebIconDatabase.m:
804 (objectFromPathForKey): Nuked some NSLogs
806 2006-08-29 Tim Omernick <timo@apple.com>
808 Reviewed by Darin Adler.
810 <rdar://problem/4688618> REGRESSION(10.4.7-9A241): JMol java applet fails in Safari not Firefox
812 No layout test for now because Java doesn't work in DumpRenderTree.
814 * Plugins/WebPluginDatabase.m:
815 (-[WebPluginDatabase refresh]):
816 Add each plug-in MIME type to registeredMIMETypes, even if we don't register a document view class for the
817 MIME type. This fixes -[WebPluginDatabase isMIMETypeRegistered:] and thus fallback content for Java applets
818 (we were always rendering fallback content, if any, for Java applets).
820 2006-08-29 Sam Weinig <sam.weinig@gmail.com>
824 - patch for http://bugs.webkit.org/show_bug.cgi?id=10628
825 Auto-generate the remaining Objective-C DOM bindings
827 Auto-generates DOMHTMLCollection, DOMHTMLElement, DOMHTMLFormElement,
828 and DOMHTMLOptionsCollection.
830 * WebKit.xcodeproj/project.pbxproj:
832 2006-08-28 Brady Eidson <beidson@apple.com>
836 Short of a few small snippets that still need to be pushed to WebCore, this
837 is a final prune of WebIconDatabase. WebFileDatabase and WebLRUFileList are gone
838 and the small remaining snippets of WebFileDatabase code that were still important
839 are now in static functions in WebIconDatabase.m
841 * Loader/WebIconLoader.m:
842 (-[WebIconLoader didFinishLoading]): Removed the flag
843 * Misc/WebFileDatabase.h: Removed.
844 * Misc/WebFileDatabase.m: Removed.
845 * Misc/WebIconDatabase.m:
846 (+[WebIconDatabase sharedIconDatabase]):
847 (-[WebIconDatabase init]):
848 (-[WebIconDatabase iconForURL:withSize:cache:]):
849 (-[WebIconDatabase iconURLForURL:]):
850 (-[WebIconDatabase defaultIconWithSize:]):
851 (-[WebIconDatabase retainIconForURL:]):
852 (-[WebIconDatabase releaseIconForURL:]):
853 (-[WebIconDatabase _isEnabled]):
854 (-[WebIconDatabase _setIconData:forIconURL:]):
855 (-[WebIconDatabase _setHaveNoIconForIconURL:]):
856 (-[WebIconDatabase _setIconURL:forURL:]):
857 (-[WebIconDatabase _hasEntryForIconURL:]):
858 (-[WebIconDatabase _applicationWillTerminate:]):
859 (-[WebIconDatabase _resetCachedWebPreferences:]):
860 (uniqueFilePathForKey): Added from WebFileDatabase
861 (objectFromPathForKey): Added from WebFileDatabase
862 (iconDataFromPathForIconURL):
863 (-[WebIconDatabase _convertToWebCoreFormat]): Make use of static functions and local variables
864 instead of using WebFileDatabase and WebIconDatabase variables that are now obsolete
865 * Misc/WebIconDatabasePrivate.h: Removed alot of obsoleted members
866 * Misc/WebLRUFileList.h: Removed.
867 * Misc/WebLRUFileList.m: Removed.
868 * WebKit.xcodeproj/project.pbxproj: Deleted 4 files
869 * WebKitPrefix.h: Removed ICONDEBUG
871 2006-08-28 Tim Omernick <timo@apple.com>
873 Reviewed by Darin Adler.
875 * Plugins/WebBaseNetscapePluginView.m:
876 (-[WebBaseNetscapePluginView createPluginScriptableObject]):
877 Removed a bogus typecast.
879 2006-08-28 Tim Omernick <timo@apple.com>
881 Reviewed by John Sullivan.
883 Part of <rdar://problem/4481553> NetscapeMoviePlugIn example code scripting doesn't work in Firefox (4319)
884 <http://bugs.webkit.org/show_bug.cgi?id=4319>: NetscapeMoviePlugIn example code scripting doesn't work
887 * Plugins/WebBaseNetscapePluginView.h:
888 * Plugins/WebBaseNetscapePluginView.m:
889 (-[WebBaseNetscapePluginView createPluginScriptableObject]):
890 Renamed this method (see corresponding WebCore ChangeLog entry for an explanation).
893 2006-08-28 Brady Eidson <beidson@apple.com>
895 Reviewed by Tim Hatcher's rubberstamp
897 Rolled out my last change (16070 - pruning WebFileDatabase code) as it caused a difficult-to-track down
898 failure in layout tests on a release build.
900 * Misc/WebFileDatabase.h:
901 * Misc/WebFileDatabase.m:
902 (+[WebFileDatabaseOp opWithCode:key:object:]):
903 (-[WebFileDatabaseOp initWithCode:key:object:]):
904 (-[WebFileDatabaseOp opcode]):
905 (-[WebFileDatabaseOp key]):
906 (-[WebFileDatabaseOp object]):
907 (-[WebFileDatabaseOp perform:]):
908 (-[WebFileDatabaseOp dealloc]):
910 (-[WebFileDatabase _createLRUList:]):
911 (-[WebFileDatabase _truncateToSizeLimit:]):
912 (+[WebFileDatabase _syncLoop:]):
914 (-[WebFileDatabase setTimer]):
915 (-[WebFileDatabase setObject:forKey:]):
916 (-[WebFileDatabase removeObjectForKey:]):
917 (-[WebFileDatabase removeAllObjects]):
918 (-[WebFileDatabase objectForKey:]):
919 (-[WebFileDatabase performSetObject:forKey:]):
920 (-[WebFileDatabase performRemoveObjectForKey:]):
921 (-[WebFileDatabase open]):
922 (-[WebFileDatabase close]):
923 (-[WebFileDatabase lazySync:]):
924 (-[WebFileDatabase sync]):
925 (-[WebFileDatabase sizeLimit]):
926 (-[WebFileDatabase count]):
927 (-[WebFileDatabase usage]):
928 (-[WebFileDatabase setSizeLimit:]):
929 * Misc/WebIconDatabase.m:
930 (-[WebIconDatabase _createFileDatabase]):
931 (-[WebIconDatabase _loadIconDictionaries]):
932 * WebKit.xcodeproj/project.pbxproj:
934 2006-08-28 Darin Adler <darin@apple.com>
936 Reviewed by Tim Hatcher.
938 * WebInspector/webInspector/inspector.js: Add "resize: none" to the list of
939 default values for CSS properties so it will be omitted from most displays
942 2006-08-28 Brady Eidson <beidson@apple.com>
946 Major prune of unnecessary WebFileDatabase code. In the end, what
947 useful code that remains in WebFileDatabase will likely be moved directly
950 * Misc/WebFileDatabase.h:
951 * Misc/WebFileDatabase.m:
952 (-[WebFileDatabase initWithPath:]):
953 (-[WebFileDatabase objectForKey:]):
954 (-[WebFileDatabase open]):
955 (-[WebFileDatabase close]):
956 * Misc/WebIconDatabase.m:
957 (-[WebIconDatabase _createFileDatabase]):
958 (-[WebIconDatabase _loadIconDictionaries]):
959 * Misc/WebLRUFileList.h: Removed.
960 * Misc/WebLRUFileList.m: Removed.
961 * WebKit.xcodeproj/project.pbxproj:
963 2006-08-27 Sam Weinig <sam.weinig@gmail.com>
967 - patch for http://bugs.webkit.org/show_bug.cgi?id=4624
968 WebCore needs autogenerated Obj-C DOM bindings
970 First round of auto-generated Objective C DOM bindings, starting
973 * WebKit.xcodeproj/project.pbxproj:
975 2006-08-25 Brady Eidson <beidson@apple.com>
977 Reviewed by Tim Hatcher
979 Fixed up some leaks on [WebIconDatabase init]
981 * Misc/WebIconDatabase.m:
982 (-[WebIconDatabase init]):
984 2006-08-24 Timothy Hatcher <timothy@apple.com>
988 * WebView/WebFrame.m:
989 (-[WebFrame _updateBackground]): reworded the comment about scroll view and setDrawsBackground:YES
991 (-[WebViewPrivate dealloc]): release the background color
993 2006-08-24 Timothy Hatcher <timothy@apple.com>
997 WebView API to allow changing the background color that draws under transparent page backgrounds.
999 * WebView/WebFrame.m:
1000 (-[WebFrame _makeDocumentView]):
1001 (-[WebFrame _updateBackground]):
1002 * WebView/WebFrameInternal.h:
1003 * WebView/WebFrameView.m:
1004 (-[WebFrameView drawRect:]):
1005 * WebView/WebView.m:
1006 (-[WebView setBackgroundColor:]):
1007 (-[WebView backgroundColor]):
1008 (-[WebView _commonInitializationWithFrameName:groupName:]):
1009 (-[WebView setDrawsBackground:]):
1010 * WebView/WebViewPrivate.h:
1012 2006-08-24 Timothy Hatcher <timothy@apple.com>
1016 Fix for Mail stationary. Selecting a stationary item would cause this exception.
1017 *** -[WebSubresourceLoader copyWithZone:]: selector not recognized
1018 Uncaught exception - *** -[WebSubresourceLoader copyWithZone:]: selector not recognized
1020 * Loader/WebFrameLoader.m:
1021 (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
1022 Use _webkit_setObject:forUncopiedKey: when addign the resource to pendingArchivedResources.
1024 2006-08-23 Maciej Stachowiak <mjs@apple.com>
1028 - fix assertion which I accidentally changed to one that sometimes fails
1029 http://bugs.webkit.org/show_bug.cgi?id=10531
1031 * Loader/WebDocumentLoadState.m:
1032 (-[WebDocumentLoadState dealloc]):
1033 * WebView/WebDataSource.m:
1034 (-[WebDataSourcePrivate dealloc]):
1035 (-[WebDataSource dealloc]):
1037 2006-08-23 Maciej Stachowiak <mjs@apple.com>
1041 - move WebFrame code that creates WebDataSources down to WebFrameLoader, in preparation
1042 for WebFrameLoader just holding on to WebDocumentLoadState
1044 * Loader/WebFrameLoader.h:
1045 * Loader/WebFrameLoader.m:
1046 (-[WebFrameLoader _loadRequest:archive:]):
1047 (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
1048 (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]):
1049 (-[WebFrameLoader reload]):
1050 * WebView/WebFrame.m:
1051 (-[WebFrame _loadItem:withLoadType:]):
1052 (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
1053 (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
1054 (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
1055 (-[WebFrame _shouldReloadToHandleUnreachableURLFromRequest:]):
1056 (-[WebFrame loadRequest:]):
1057 (-[WebFrame loadArchive:]):
1058 (-[WebFrame reload]):
1059 * WebView/WebFrameInternal.h:
1060 * WebView/WebFramePrivate.h:
1061 * WebView/WebView.m:
1062 (-[WebView setCustomTextEncodingName:]):
1064 2006-08-23 Brady Eidson <beidson@apple.com>
1068 First pass at pruning unused WebIconDatabase code. Focus on removing methods that simply
1069 have no place in the new DB at all. A few renames and a few important FIXMEs result, but no
1070 functionality changes.
1072 * Loader/WebIconLoader.m:
1073 (-[WebIconLoader didFinishLoading]): Call to WebIconDatabase instead of directly to the bridge
1074 * Misc/WebIconDatabase.h:
1075 * Misc/WebIconDatabase.m:
1076 (-[WebIconDatabase init]):
1077 (-[WebIconDatabase iconForURL:withSize:cache:]):
1078 (-[WebIconDatabase iconURLForURL:]):
1079 (-[WebIconDatabase defaultIconWithSize:]):
1080 (-[WebIconDatabase retainIconForURL:]):
1081 (-[WebIconDatabase releaseIconForURL:]):
1082 (-[WebIconDatabase removeAllIcons]):
1083 (-[WebIconDatabase _setIconData:forIconURL:]):
1084 (-[WebIconDatabase _setHaveNoIconForIconURL:]):
1085 (-[WebIconDatabase _setIconURL:forURL:]):
1086 (-[WebIconDatabase _hasEntryForIconURL:]):
1087 (-[WebIconDatabase _applicationWillTerminate:]):
1088 (-[WebIconDatabase _resetCachedWebPreferences:]):
1089 * Misc/WebIconDatabasePrivate.h: Changed setIcon: to setIconData:
1091 2006-08-23 Maciej Stachowiak <mjs@apple.com>
1095 - started factoring most of the guts of WebDataSource into a new class
1097 WebDocumentLoadState is decoupled from the rest of WebKit and will
1098 be moved down to WebCore. I only moved one of the data fields of
1099 WebDataSource for now.
1101 * Loader/WebDocumentLoadState.h: Added.
1102 * Loader/WebDocumentLoadState.m: Added.
1103 (-[WebDocumentLoadState initWithRequest:]): New class.
1104 (-[WebDocumentLoadState dealloc]):
1105 (-[WebDocumentLoadState setFrameLoader:]):
1106 (-[WebDocumentLoadState setMainResourceData:]):
1107 (-[WebDocumentLoadState mainResourceData]):
1108 * Loader/WebFrameLoader.m:
1109 (-[WebFrameLoader _setDataSource:]): Remove redundant _setWebFrame: call,
1110 it would have been called already by this point.
1111 (-[WebFrameLoader _setProvisionalDataSource:]): ditto.
1112 * WebKit.xcodeproj/project.pbxproj:
1113 * WebView/WebDataSource.m:
1114 (-[WebDataSourcePrivate dealloc]):
1115 (-[WebDataSource _setWebFrame:]):
1116 (-[WebDataSource _setPrimaryLoadComplete:]):
1117 (-[WebDataSource initWithRequest:]):
1118 (-[WebDataSource data]):
1120 2006-08-23 Maciej Stachowiak <mjs@apple.com>
1124 - refactoring of WebDataSource in preparation for moving a bunch of it to a new class
1126 - minimize WebDataSourceInternal.h to be only methods called from outside WebDataSource
1127 - reduce Private category implementation to be only the SPI methods
1128 - make new Internal and FileInternal categories which contain the
1129 remainder (depending on whether they are called from outside of
1132 * WebView/WebDataSource.m:
1133 (-[WebDataSource _setMainDocumentError:]):
1134 (addTypesFromClass):
1135 (+[WebDataSource _representationClassForMIMEType:]):
1136 (-[WebDataSource _commitIfReady]):
1137 (-[WebDataSource _commitLoadWithData:]):
1138 (-[WebDataSource _doesProgressiveLoadWithMIMEType:]):
1139 (-[WebDataSource _addResponse:]):
1140 (-[WebDataSource _revertToProvisionalState]):
1141 (-[WebDataSource _mainDocumentError]):
1142 (-[WebDataSource _addSubframeArchives:]):
1143 (-[WebDataSource _fileWrapperForURL:]):
1144 (+[WebDataSource _repTypesAllowImageTypeOmission:]):
1145 (-[WebDataSource _decidePolicyForMIMEType:decisionListener:]):
1146 (-[WebDataSource _finishedLoading]):
1147 (-[WebDataSource _setResponse:]):
1148 (-[WebDataSource _setRequest:]):
1149 (-[WebDataSource _setupForReplaceByMIMEType:]):
1150 (-[WebDataSource _receivedMainResourceError:complete:]):
1151 (-[WebDataSource _mainReceivedError:complete:]):
1152 (-[WebDataSource _defersCallbacks]):
1153 (-[WebDataSource _downloadWithLoadingConnection:request:response:proxy:]):
1154 (-[WebDataSource _didFailLoadingWithError:forResource:]):
1155 (-[WebDataSource _didFinishLoadingForResource:]):
1156 (-[WebDataSource _didReceiveData:contentLength:forResource:]):
1157 (-[WebDataSource _didReceiveResponse:forResource:]):
1158 (-[WebDataSource _didCancelAuthenticationChallenge:forResource:]):
1159 (-[WebDataSource _didReceiveAuthenticationChallenge:forResource:]):
1160 (-[WebDataSource _willSendRequest:forResource:redirectResponse:]):
1161 (-[WebDataSource _identifierForInitialRequest:]):
1162 (-[WebDataSource _archivedSubresourceForURL:]):
1163 (-[WebDataSource _startLoading]):
1164 (-[WebDataSource _stopRecordingResponses]):
1165 (-[WebDataSource _loadingStartedTime]):
1166 (-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]):
1167 (-[WebDataSource _documentFragmentWithArchive:]):
1168 (-[WebDataSource _documentFragmentWithImageResource:]):
1169 (-[WebDataSource _imageElementWithImageResource:]):
1170 (-[WebDataSource _title]):
1171 (-[WebDataSource _isStopping]):
1172 (-[WebDataSource _setWebFrame:]):
1173 (-[WebDataSource _URL]):
1174 (-[WebDataSource _loadFromPageCache:]):
1175 (-[WebDataSource _popSubframeArchiveWithName:]):
1176 (-[WebDataSource _setIsClientRedirect:]):
1177 (-[WebDataSource _setURL:]):
1178 (-[WebDataSource _setLastCheckedRequest:]):
1179 (-[WebDataSource _defersCallbacksChanged]):
1180 (-[WebDataSource _lastCheckedRequest]):
1181 (-[WebDataSource _stopLoading]):
1182 (-[WebDataSource _bridge]):
1183 (-[WebDataSource _webView]):
1184 (-[WebDataSource _triggeringAction]):
1185 (-[WebDataSource _setTriggeringAction:]):
1186 (-[WebDataSource __adoptRequest:]):
1187 (-[WebDataSource _isDocumentHTML]):
1188 (-[WebDataSource _stopLoadingWithError:]):
1189 (-[WebDataSource _setPrimaryLoadComplete:]):
1190 (-[WebDataSource _responses]):
1191 (-[WebDataSource _makeRepresentation]):
1192 (-[WebDataSource _isClientRedirect]):
1193 (-[WebDataSource _originalRequest]):
1194 (-[WebDataSource _URLForHistory]):
1195 (-[WebDataSource _addToUnarchiveState:]):
1196 (-[WebDataSource _setOverrideEncoding:]):
1197 (-[WebDataSource _setIconURL:]):
1198 (-[WebDataSource _setIconURL:withType:]):
1199 (-[WebDataSource _overrideEncoding]):
1200 (-[WebDataSource _setTitle:]):
1201 * WebView/WebDataSourceInternal.h:
1203 2006-08-23 Brady Eidson <beidson@apple.com>
1205 Reviewed by John Sullivan
1208 Flip the switch to the new Icon Database
1209 Massive code pruning is coming up
1211 * WebKitPrefix.h: Flipped the switch
1213 2006-08-23 Brady Eidson <beidson@apple.com>
1216 Since I just pushed the default URL icon from WebKit to WebCore, but
1217 WebKit was still using its version of the default icon, this patch makes it
1218 use the WebCore version
1220 * Misc/WebIconDatabase.m:
1221 (-[WebIconDatabase defaultIconWithSize:]):
1223 2006-08-22 Maciej Stachowiak <mjs@apple.com>
1227 - remove "loading" flag from WebDataSource and code that manages it; it is redundat.
1229 * Loader/WebFrameLoader.m:
1230 (-[WebFrameLoader addPlugInStreamLoader:]):
1231 (-[WebFrameLoader removePlugInStreamLoader:]):
1232 (-[WebFrameLoader addSubresourceLoader:]):
1233 (-[WebFrameLoader removeSubresourceLoader:]):
1234 * WebView/WebDataSource.m:
1235 (-[WebDataSourcePrivate dealloc]):
1236 (-[WebDataSource _setPrimaryLoadComplete:]):
1237 (-[WebDataSource _stopLoading]):
1238 (-[WebDataSource _prepareForLoadStart]):
1239 (-[WebDataSource _startLoading]):
1240 (-[WebDataSource isLoading]):
1241 * WebView/WebDataSourceInternal.h:
1243 2006-08-22 Maciej Stachowiak <mjs@apple.com>
1247 <rdar://problem/4683948> REGRESSION: Assertion failure in [FrameProgressEntry addChild:forDataSource:] (fandango.com)
1249 * Loader/WebFrameLoader.m:
1250 (-[WebFrameLoader addSubresourceLoader:]): Add a WebKit-level assertion that should fire when this bad
1252 * Loader/WebSubresourceLoader.m:
1253 (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]): Prevent
1254 the situation from occuring.
1256 2006-08-22 Maciej Stachowiak <mjs@apple.com>
1260 - pull more WebDataSource code into WebFrameLoader
1261 - make WebMainResourceLoader not depend on WebKit or on SPI
1263 * Loader/WebFrameLoader.h:
1264 * Loader/WebFrameLoader.m:
1265 (-[WebFrameLoader _downloadWithLoadingConnection:request:response:proxy:]):
1266 (-[WebFrameLoader _updateIconDatabaseWithURL:]):
1267 (-[WebFrameLoader _notifyIconChanged:]):
1268 (-[WebFrameLoader _iconLoaderReceivedPageIcon:]):
1269 (-[WebFrameLoader _checkNavigationPolicyForRequest:andCall:withSelector:]):
1270 (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]):
1271 (-[WebFrameLoader cancelContentPolicy]):
1272 * Loader/WebIconLoader.m:
1273 (-[WebIconLoader didFinishLoading]):
1274 * Loader/WebLoader.m:
1275 (-[NSURLProtocol loadWithRequest:]):
1276 (-[NSURLProtocol setDefersCallbacks:]):
1277 * Loader/WebMainResourceLoader.h:
1278 * Loader/WebMainResourceLoader.m:
1279 (-[WebMainResourceLoader initWithFrameLoader:]):
1280 (-[WebMainResourceLoader dealloc]):
1281 (-[WebMainResourceLoader cancelWithError:]):
1282 (-[WebMainResourceLoader continueAfterNavigationPolicy:formState:]):
1283 (-[WebMainResourceLoader willSendRequest:redirectResponse:]):
1284 (-[WebMainResourceLoader continueAfterContentPolicy:]):
1285 (-[WebMainResourceLoader checkContentPolicy]):
1286 (-[WebMainResourceLoader didReceiveResponse:]):
1287 * Plugins/WebPluginContainerCheck.m:
1288 * WebCoreSupport/WebSystemInterface.m:
1289 (InitWebCoreSystemInterface):
1290 * WebView/WebDataSource.m:
1291 (-[WebDataSource _loadIcon]):
1292 (-[WebDataSource _cancelledError]):
1293 (+[WebDataSource _repTypesAllowImageTypeOmission:]):
1294 (+[WebDataSource _representationClassForMIMEType:]):
1295 (-[WebDataSource _commitLoadWithData:]):
1296 (-[WebDataSource _isDocumentHTML]):
1297 * WebView/WebDataSourceInternal.h:
1298 * WebView/WebFramePrivate.h:
1299 * WebView/WebPolicyDelegate.m:
1300 * WebView/WebPolicyDelegatePrivate.h:
1302 2006-08-21 Maciej Stachowiak <mjs@apple.com>
1306 - move more code from WebDataSource to WebFrameLoader
1308 Also marked a few more methods in WebDataSource as likely MOVABLE in a future round, since they do not
1309 use any of WebDataSource's private data.
1311 * Loader/WebFrameLoader.h:
1312 * Loader/WebFrameLoader.m:
1313 (-[WebFrameLoader addPlugInStreamLoader:]):
1314 (-[WebFrameLoader removePlugInStreamLoader:]):
1315 (-[WebFrameLoader addSubresourceLoader:]):
1316 (-[WebFrameLoader removeSubresourceLoader:]):
1317 (-[WebFrameLoader _didReceiveAuthenticationChallenge:forResource:]):
1318 (-[WebFrameLoader _didCancelAuthenticationChallenge:forResource:]):
1319 (-[WebFrameLoader _didReceiveResponse:forResource:]):
1320 (-[WebFrameLoader _didReceiveData:contentLength:forResource:]):
1321 (-[WebFrameLoader _didFinishLoadingForResource:]):
1322 (-[WebFrameLoader _didFailLoadingWithError:forResource:]):
1323 (-[WebFrameLoader _privateBrowsingEnabled]):
1324 (-[WebFrameLoader _finishedLoadingResource]):
1325 (-[WebFrameLoader _receivedError:]):
1326 (-[WebFrameLoader _finishedLoading]):
1327 * Loader/WebMainResourceLoader.m:
1328 (-[WebMainResourceLoader didReceiveData:lengthReceived:allAtOnce:]):
1329 (-[WebMainResourceLoader didFinishLoading]):
1330 * Loader/WebNetscapePlugInStreamLoader.m:
1331 (-[WebNetscapePlugInStreamLoader didFinishLoading]):
1332 (-[WebNetscapePlugInStreamLoader didFailWithError:]):
1333 (-[WebNetscapePlugInStreamLoader cancelWithError:]):
1334 * Loader/WebSubresourceLoader.m:
1335 (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]):
1336 (-[WebSubresourceLoader signalFinish]):
1337 (-[WebSubresourceLoader didFailWithError:]):
1338 (-[WebSubresourceLoader cancel]):
1339 * Plugins/WebNetscapePluginStream.m:
1340 (-[WebNetscapePluginStream start]):
1341 * WebView/WebDataSource.m:
1342 (-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]):
1343 (-[WebDataSource _updateIconDatabaseWithURL:]):
1344 (-[WebDataSource _loadIcon]):
1345 (-[WebDataSource _setPrimaryLoadComplete:]):
1346 (-[WebDataSource _cancelledError]):
1347 (+[WebDataSource _repTypesAllowImageTypeOmission:]):
1348 (+[WebDataSource _representationClassForMIMEType:]):
1349 (-[WebDataSource _commitLoadWithData:]):
1350 (-[WebDataSource _receivedMainResourceError:complete:]):
1351 (-[WebDataSource _iconLoaderReceivedPageIcon:]):
1352 (-[WebDataSource _isDocumentHTML]):
1353 * WebView/WebDataSourceInternal.h:
1355 2006-08-21 Brady Eidson <beidson@apple.com>
1359 Quick ICONDEBUG flag fix
1361 * Misc/WebIconDatabase.m:
1362 (-[WebIconDatabase _applicationWillTerminate:]):
1364 2006-08-21 Brady Eidson <beidson@apple.com>
1368 -Renamed an internal only method for clarity
1369 -Tweaked WebDataSource for notification purposes with the new expiring icons
1370 -Fixed a bug with the ICONDEBUG flag
1372 * Misc/WebIconDatabase.m:
1373 (-[WebIconDatabase init]):
1374 (-[WebIconDatabase iconForURL:withSize:cache:]): #ifdef bug fixed
1375 (-[WebIconDatabase _hasEntryForIconURL:]): Renamed for clarity
1376 * Misc/WebIconDatabasePrivate.h:
1377 * WebView/WebDataSource.m:
1378 (-[WebDataSource _updateIconDatabaseWithURL:]):
1379 (-[WebDataSource _notifyIconChanged:]):
1380 (-[WebDataSource _loadIcon]):
1381 (-[WebDataSource _iconLoaderReceivedPageIcon:]):
1383 2006-08-17 Maciej Stachowiak <mjs@apple.com>
1387 - pull a bit of WebDataSource code into WebFrameLoader
1389 * Loader/WebFrameLoader.m:
1390 (-[WebFrameLoader _receivedError:]):
1391 (-[WebFrameLoader webFrame]):
1392 (-[WebFrameLoader _handleFallbackContent]):
1393 (+[WebFrameLoader _canShowMIMEType:]):
1394 (+[WebFrameLoader _representationExistsForURLScheme:]):
1395 (+[WebFrameLoader _generatedMIMETypeForURLScheme:]):
1396 * WebView/WebDataSource.m:
1397 * WebView/WebDataSourceInternal.h:
1399 2006-08-17 Timothy Hatcher <timothy@apple.com>
1401 Reviewed by Kevin Decker.
1403 <rdar://problem/4606857> WebKit: WebPreferencesChangedNotification not exported in 64-bit
1407 2006-08-17 Timothy Hatcher <timothy@apple.com>
1409 Reviewed by Kevin Decker.
1411 <rdar://problem/4633896> -[WebView close] should clear all delegates and call setHostWindow:nil
1412 <rdar://problem/4649759> Crash when selecting View Source menu using Chinese (-[WebView _close])
1414 Check to make sure _private is not null. A WebView can be dealloced before _private is setup.
1415 Set the _private->closed flag at the beginning of _close to prevent reentry.
1416 Set the host window and all the delegates to nil in _close.
1418 * WebView/WebView.m:
1419 (-[WebView _close]):
1421 2006-08-16 Brady Eidson <beidson@apple.com>
1425 * Misc/WebIconDatabase.m: Pruned unused method
1426 * Misc/WebIconDatabasePrivate.h: Ditto
1429 2006-08-15 Maciej Stachowiak <mjs@apple.com>
1431 Reviewed by Adele (preliminary version) and later by Kevin.
1433 - remove most WebKit dependencies from WebMainResourceLoader.
1435 * Loader/WebFrameLoader.h:
1436 * Loader/WebFrameLoader.m:
1437 (-[WebFrameLoader cannotShowMIMETypeForURL:]):
1438 (-[WebFrameLoader interruptForPolicyChangeErrorWithRequest:]):
1439 (-[WebFrameLoader isHostedByObjectElement]):
1440 (-[WebFrameLoader isLoadingMainFrame]):
1441 (+[WebFrameLoader _canShowMIMEType:]):
1442 (+[WebFrameLoader _representationExistsForURLScheme:]):
1443 (+[WebFrameLoader _generatedMIMETypeForURLScheme:]):
1444 * Loader/WebMainResourceLoader.h:
1445 * Loader/WebMainResourceLoader.m:
1446 (-[WebMainResourceLoader interruptForPolicyChangeError]):
1447 (-[WebMainResourceLoader willSendRequest:redirectResponse:]):
1448 (isCaseInsensitiveEqual):
1449 (shouldLoadAsEmptyDocument):
1450 (-[WebMainResourceLoader continueAfterContentPolicy:response:]):
1451 (-[WebMainResourceLoader didReceiveResponse:]):
1452 (-[WebMainResourceLoader didReceiveData:lengthReceived:allAtOnce:]):
1453 (-[WebMainResourceLoader didFinishLoading]):
1454 (-[WebMainResourceLoader loadWithRequestNow:]):
1455 (-[WebMainResourceLoader loadWithRequest:]):
1457 2006-08-15 Tim Omernick <timo@apple.com>
1459 Reviewed by Kevin Decker.
1461 * Plugins/WebNetscapePluginPackage.m:
1462 (-[WebNetscapePluginPackage _unloadWithShutdown:]):
1463 Fixed a subtle problem with the 64-bit debug build -- as written, this would LOG() on 64-bit and do nothing on
1465 * Plugins/WebPluginDatabase.m:
1466 (-[WebPluginDatabase _scanForNewPlugins]):
1467 Use +[NSMutableSet set] here.
1469 2006-08-15 Tim Omernick <timo@apple.com>
1471 Reviewed by Darin Adler.
1473 <http://bugs.webkit.org/show_bug.cgi?id=8980>
1474 ASSERTION FAILED: !isLoaded (WebKit/WebKit/Plugins/WebBasePluginPackage.m:228 -[WebBasePluginPackage dealloc])
1476 <rdar://problem/4526052> intermittent assertion failure in -[WebBasePluginPackage dealloc] running layout tests (8980)
1478 * Plugins/WebPluginDatabase.h:
1479 * Plugins/WebPluginDatabase.m:
1480 (+[WebPluginDatabase installedPlugins]):
1481 Observe NSApplicationWillTerminateNotification so we can unload plug-ins on quit.
1482 (-[WebPluginDatabase plugins]):
1483 'plugins' is now a dictionary.
1484 (-[WebPluginDatabase close]):
1485 Call new -_removePlugin: method.
1486 (-[WebPluginDatabase refresh]):
1487 Moved parts of this method out into other methods: -_addPlugin:, -_removePlugin:, and -_scanForNewPlugins.
1488 (-[WebPluginDatabase _plugInPaths]):
1489 No changes; just moved in file.
1490 (-[WebPluginDatabase _addPlugin:]):
1491 New method. Refactored from -refresh. Adds a plug-in to the database.
1492 (-[WebPluginDatabase _removePlugin:]):
1493 New method. Refactored from -refresh. Remove a plug-in from the database.
1494 (-[WebPluginDatabase _scanForNewPlugins]):
1495 New method. Refactored from -refresh. Returns the list of plug-in packages on disk.
1496 (-[WebPluginDatabase _applicationWillTerminate]):
1497 New method. Called when the application terminates. Closes the plug-in database so that all plug-ins are
1498 removed from the DB (and unloaded if necessary).
1500 * Plugins/WebBasePluginPackage.h:
1501 * Plugins/WebBasePluginPackage.m:
1502 (-[WebBasePluginPackage initWithPath:]):
1503 Try to create the NSBundle first, so if the file is not a valid bundle we bail out early. This
1504 avoids some stat()s and allocations during the plug-in refresh process.
1505 (-[WebBasePluginPackage isLoaded]):
1507 (-[WebBasePluginPackage load]):
1508 Base class for plug-in packages now always loads "successfully".
1509 (-[WebBasePluginPackage dealloc]):
1510 Removed this assertion. The base plug-in package class has no concept of
1512 (-[WebBasePluginPackage finalize]):
1514 (-[WebBasePluginPackage wasRemovedFromPluginDatabase:]):
1515 Moved code to unload plug-in package to WebNetscapePluginPackage. Not all plug-in
1516 packages can be "unloaded".
1518 * Plugins/WebNetscapePluginPackage.h:
1519 * Plugins/WebNetscapePluginPackage.m:
1520 (-[WebNetscapePluginPackage _unloadWithShutdown:]):
1521 Combined old -unload and -unloadWithoutShutdown methods into this new one.
1522 (-[WebNetscapePluginPackage initWithPath:]):
1523 Call new unload method.
1524 (-[WebNetscapePluginPackage load]):
1526 (-[WebNetscapePluginPackage wasRemovedFromPluginDatabase:]):
1528 (-[WebNetscapePluginPackage open]):
1529 New method. Called when a plug-in instance starts running.
1530 (-[WebNetscapePluginPackage close]):
1531 New method. Called when a plug-in instance stops running. When all plug-in instances
1532 close the plug-in package, and the plug-in package is removed from the database, the plug-in
1535 * Plugins/WebPluginPackage.m:
1536 (-[WebPluginPackage initWithPath:]):
1537 (-[WebPluginPackage load]):
1538 Made this a bit more efficient by checking if the bundle is already loaded.
1539 (-[WebBasePluginPackage unload]):
1541 (-[WebBasePluginPackage isLoaded]):
1544 * Plugins/WebBaseNetscapePluginView.m:
1545 (-[WebBaseNetscapePluginView start]):
1546 Open the plug-in package so it remains loaded while this instance uses it.
1547 (-[WebBaseNetscapePluginView stop]):
1548 Close the plug-in package when the plug-in instance is stopped.
1550 * Plugins/WebBaseNetscapePluginStream.m:
1551 (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:]):
1552 This check is not necessary. Netscape plug-in packages are never unloaded until all their instances have
1553 been stopped, and a Netscape plug-in instance will stop its streams when it is stopped.
1554 (-[WebBaseNetscapePluginStream _destroyStream]):
1556 (-[WebBaseNetscapePluginStream finishedLoadingWithData:]):
1558 (-[WebBaseNetscapePluginStream _deliverData]):
1561 2006-08-15 Mark Rowe <opendarwin.org@bdash.net.nz>
1565 Build fix: DWARF and -gfull are incompatible with symbol separation.
1567 * WebKit.xcodeproj/project.pbxproj:
1569 2006-08-15 Mark Rowe <opendarwin.org@bdash.net.nz>
1573 http://bugs.webkit.org/show_bug.cgi?id=10394
1574 Bug 10394: WebKit Release and Production configurations should enable dead code stripping
1576 * WebKit.xcodeproj/project.pbxproj:
1578 2006-08-15 Maciej Stachowiak <mjs@apple.com>
1582 - remove WebKit dependencies from WebPlugInStreamLoader via a protocol veil of ignorance
1584 * Loader/WebNetscapePlugInStreamLoader.h:
1585 * Loader/WebNetscapePlugInStreamLoader.m:
1586 (-[WebNetscapePlugInStreamLoader initWithDelegate:frameLoader:]):
1587 * Loader/WebPlugInStreamLoaderDelegate.h: Added.
1588 * Plugins/WebBaseNetscapePluginStream.h:
1589 * Plugins/WebNetscapePluginStream.m:
1590 (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]):
1591 * WebKit.xcodeproj/project.pbxproj:
1593 2006-08-15 Mark Rowe <opendarwin.org@bdash.net.nz>
1597 http://bugs.webkit.org/show_bug.cgi?id=10384
1598 Bug 10384: Switch to DWARF for Release configuration
1600 * WebKit.xcodeproj/project.pbxproj:
1602 2006-08-15 Graham Dennis <graham.dennis@gmail.com>
1606 - patch for http://bugs.webkit.org/show_bug.cgi?id=10314
1607 WebUnarchivingState archivedResourceForURL: doesn't work
1609 * WebView/WebUnarchivingState.m:
1610 (-[WebUnarchivingState archivedResourceForURL:]):
1611 Fixed to get objects from the archived resources dictionary using
1612 the URL as a string instead of as the URL itself (as this is how
1613 the data is put into the dictionary).
1615 2006-08-14 Maciej Stachowiak <mjs@apple.com>
1619 - remove many (but not all) WebKit dependencies from WebNetscapePlugInStreamLoader (it still
1620 depends on WebNetscapePluginStream).
1622 * Loader/WebFrameLoader.h:
1623 * Loader/WebFrameLoader.m:
1624 (-[WebFrameLoader fileDoesNotExistErrorWithResponse:]):
1625 * Loader/WebNetscapePlugInStreamLoader.h:
1626 * Loader/WebNetscapePlugInStreamLoader.m:
1627 (-[WebNetscapePlugInStreamLoader initWithStream:frameLoader:]):
1628 (-[WebNetscapePlugInStreamLoader releaseResources]):
1629 (-[WebNetscapePlugInStreamLoader didReceiveResponse:]):
1630 * Plugins/WebNetscapePluginStream.m:
1631 (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]):
1633 2006-08-14 Maciej Stachowiak <mjs@apple.com>
1635 Reviewed by Tim Omernick.
1637 - fixed REGRESSION: crash when leaving youtube page while movie is still loading
1638 http://bugs.webkit.org/show_bug.cgi?id=10398
1640 * Loader/WebNetscapePlugInStreamLoader.m:
1641 (-[WebNetscapePlugInStreamLoader initWithStream:view:]): Set the frame loader for this stream.
1642 (-[WebNetscapePlugInStreamLoader cancelWithError:]): Make sure to destroy the stream as well;
1643 otherwise, when we try to clean up later, we won't have the right context.
1645 2006-08-14 David Hyatt <hyatt@apple.com>
1647 Fix for Radar bug 4478840, Safari should not reduce null events sent to
1648 plug-ins in windows that are inactive but visible.
1650 With this fix you can view videos in visible background windows on YouTube
1651 (for example) and not see any drop in frame rate.
1655 * Plugins/WebBaseNetscapePluginView.m:
1656 (-[WebBaseNetscapePluginView restartNullEvents]):
1658 2006-08-14 Maciej Stachowiak <mjs@apple.com>
1662 - removed WebKit-level dependencies from WebFormDataStream. Use WebCore version of system interface
1664 * Loader/WebFormDataStream.m:
1666 (formEventCallback):
1668 * WebCoreSupport/WebSystemInterface.m:
1669 (InitWebCoreSystemInterface):
1671 2006-08-14 Maciej Stachowiak <mjs@apple.com>
1673 Rubber stamped by Brady.
1675 - move WebFormDataStream from WebView to Loader
1677 * WebKit.xcodeproj/project.pbxproj:
1678 * WebView/WebFormDataStream.h: Removed.
1679 * WebView/WebFormDataStream.m: Removed.
1681 2006-08-13 Maciej Stachowiak <mjs@apple.com>
1685 - remove WebKit dependencies from WebSubresourceLoader, except WebFormDataStream
1687 (WebFormDataStream will be moved into the Loader directory soon)
1689 * Loader/WebFrameLoader.h:
1690 * Loader/WebFrameLoader.m:
1691 (-[WebFrameLoader _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
1692 * Loader/WebSubresourceLoader.m:
1693 (isConditionalRequest):
1694 (hasCaseInsensitivePrefix):
1697 (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]):
1699 2006-08-13 Brady Eidson <beidson@apple.com>
1703 Relocated the WebIconLoaders
1705 * Misc/WebIconLoader.h: Moved to Loader/
1706 * Misc/WebIconLoader.m: Moved to Loader/
1707 * WebKit.xcodeproj/project.pbxproj:
1709 2006-08-13 Maciej Stachowiak <mjs@apple.com>
1713 - removed non-Loader WebKit dependencies from WebDataProtocol for
1714 real (whoops) and fix some typos.
1716 * Loader/WebDataProtocol.m:
1717 (isCaseInsensitiveEqual): Added.
1718 (+[WebDataProtocol _webIsDataProtocolURL:]): Avoid WebKit calls.
1719 (-[WebDataProtocol startLoading]): ditto
1720 * Loader/WebFrameLoader.m:
1721 (isCaseInsensitiveEqual): Fixed spelling from isCaseSensitiveEqual.
1722 (-[WebFrameLoader _canUseResourceForRequest:]): Use proper call.
1724 2006-08-13 Brady Eidson <beidson@apple.com>
1728 The way of detecting a failed icon load before was to try and construct
1729 an image from the icon and if that image construction failed, mark the icon
1731 A much more efficient way is to check for an error response. We'll still
1732 check for invalid image data, but most servers will correctly return an HTTP
1733 error on a missing icon.
1735 * Misc/WebIconLoader.m:
1736 (-[WebIconLoader didFinishLoading]): Added check for http error response
1738 2006-08-13 Maciej Stachowiak <mjs@apple.com>
1742 - remove all non-Loader dependencies from WebLoader
1744 As part of this I moved WebDataProtocol to the loader directory
1745 and removed dependencies on the rest of WebKit from that too.
1747 * Loader/WebFrameLoader.h:
1748 * Loader/WebFrameLoader.m:
1749 (-[WebFrameLoader setDefersCallbacks:]):
1750 (-[WebFrameLoader stopLoading]):
1751 (-[WebFrameLoader cancelledErrorWithRequest:]):
1752 (-[WebFrameLoader clearArchivedResources]):
1753 (-[WebFrameLoader deliverArchivedResources]):
1754 (-[WebFrameLoader deliverArchivedResourcesAfterDelay]):
1755 (isCaseSensitiveEqual):
1756 (-[WebFrameLoader _canUseResourceForRequest:]):
1757 (-[WebFrameLoader _canUseResourceWithResponse:]):
1758 (-[WebFrameLoader pendingArchivedResources]):
1759 (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
1760 (-[WebFrameLoader archiveLoadPendingForLoader:]):
1761 (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]):
1762 * Loader/WebLoader.h:
1763 * Loader/WebLoader.m:
1764 (-[NSURLProtocol releaseResources]):
1765 (-[NSURLProtocol loadWithRequest:]):
1766 (-[NSURLProtocol setDefersCallbacks:]):
1767 (-[NSURLProtocol addData:allAtOnce:]):
1768 (-[NSURLProtocol resourceData]):
1769 (-[NSURLProtocol didReceiveData:lengthReceived:allAtOnce:]):
1770 (-[NSURLProtocol connection:didReceiveData:lengthReceived:]):
1771 (-[NSURLProtocol cancelWithError:]):
1772 (-[NSURLProtocol cancelledError]):
1773 * Loader/WebMainResourceLoader.m:
1774 (-[WebMainResourceLoader addData:allAtOnce:]):
1775 (-[WebMainResourceLoader didReceiveData:lengthReceived:allAtOnce:]):
1776 * Loader/WebNetscapePlugInStreamLoader.m:
1777 (-[WebNetscapePlugInStreamLoader didReceiveData:lengthReceived:allAtOnce:]):
1778 * Loader/WebSubresourceLoader.m:
1779 (-[WebSubresourceLoader didReceiveData:lengthReceived:allAtOnce:]):
1780 * WebKit.xcodeproj/project.pbxproj:
1781 * WebView/WebDataProtocol.h: Removed.
1782 * WebView/WebDataProtocol.m: Removed.
1784 2006-08-11 Tim Omernick <timo@apple.com>
1788 <http://bugs.webkit.org/show_bug.cgi?id=10111> - Menu flickers over Flash content
1789 <rdar://problem/3052546> Plugins don't work with z-index (overlapping elements, etc.)
1791 * Plugins/WebBaseNetscapePluginView.m:
1792 (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1793 Don't just clip to the dirty region for "transparent" plug-ins -- do it for all plug-ins. This is a
1794 generally useful thing to do, as it prevents the plug-in from drawing over parts of the window that
1795 have already been drawn and are not expected to be redrawn in the same update.
1797 2006-08-11 Brady Eidson <beidson@apple.com>
1799 Reviewed by John, Timo, Adele, and Darin
1801 In addition to a few style/good-practice cleanups, this patch will convert the old icon database
1802 format to the WebCore format if the WebCore db is empty (implying this conversion has yet to take
1803 place). After the conversion, it will delete all traces of the old format to free the unneeded space
1805 * Misc/WebIconDatabase.m:
1806 (-[WebIconDatabase init]):
1807 (-[WebIconDatabase _setIconURL:forURL:]): Changed the bridge's name for this method to be more clear
1808 (-[WebIconDatabase _createFileDatabase]):
1809 (-[WebIconDatabase _iconDataForIconURL:]): This grabs the raw data for use in the conversion function
1810 (-[WebIconDatabase _convertToWebCoreFormat]): This does the actual conversion
1812 2006-08-11 Tim Omernick <timo@apple.com>
1814 Reviewed by John Sullivan.
1816 Needed for <rdar://problem/4678070>.
1818 * Plugins/WebBaseNetscapePluginView.m:
1819 (-[WebBaseNetscapePluginView sendEvent:]):
1820 Changed an assertion to an early return. It should be possible to send events, especially updateEvt (for image capturing
1821 purposes), to off-screen plug-ins. It just doesn't work right now. See <rdar://problem/4318269>.
1823 2006-08-11 John Sullivan <sullivan@apple.com>
1827 - fixed <rdar://problem/4522894> Would be nice if Safari shrank pages a little if necessary
1828 to avoid printing an almost-empty page
1830 * WebView/WebHTMLView.m:
1831 (-[NSArray knowsPageRange:]):
1832 If the last page has a short-enough orphan (< 1/10 of the page height is the number I pulled
1833 out of ... the air), then we adjust the scale factor slightly and check whether this reduces
1834 the page count and thus eliminates the orphan.
1836 2006-08-07 Brady Eidson <beidson@apple.com>
1838 Reviewed by Anders and John
1840 * Misc/WebIconDatabase.m:
1841 (-[WebIconDatabase init]):
1842 (-[WebIconDatabase isIconExpiredForIconURL:]): Get if an icon expired
1843 (-[WebIconDatabase isIconExpiredForPageURL:]): Ditto
1844 (-[WebIconDatabase _setIconURL:forURL:]):
1845 (-[WebIconDatabase _sendNotificationForURL:]): Moved to WebKitPendingPublic for use outside of WebIconDatabase
1846 (-[WebIconDatabase loadIconFromURL:]): Allow a load outside the context of a page load
1847 * Misc/WebIconDatabasePrivate.h:
1849 * Misc/WebIconLoader.m:
1850 (-[WebIconLoader didFinishLoading]): fixed up the "flipping the switch" #defs a bit
1851 (-[WebIconLoader willSendRequest:redirectResponse:]): override to allow a load
1852 outside of the context of a page load
1854 * WebCoreSupport/WebIconDatabaseBridge.h: Added.
1855 * WebCoreSupport/WebIconDatabaseBridge.m: Added.
1856 (-[WebIconDatabaseBridge init]):
1857 (-[WebIconDatabaseBridge dealloc]):
1858 (-[WebIconDatabaseBridge loadIconFromURL:]): Kick off a load on an icon outside
1859 of the context of any page load
1860 (-[WebIconDatabaseBridge _setIconData:forIconURL:]): WebKit side of bridge method
1861 (-[WebIconDatabaseBridge _setHaveNoIconForIconURL:]): WebKit side of bridge method
1862 (-[WebIconDatabaseBridge releaseCachedLoaderForIconURL:]):
1863 (+[WebIconDatabaseBridge sharedBridgeInstance]): Moved this from WebCore to WebKit
1864 so both sides of the bridge get the WebKit version
1865 * WebKit.xcodeproj/project.pbxproj: Added some files
1866 * WebView/WebDataSource.m:
1867 (-[WebDataSource _loadIcon]): Added check for reload/expired icon to force
1868 a load even if we already have it
1870 2006-08-04 Sam Weinig <sam.weinig@gmail.com>
1874 - patch for http://bugs.webkit.org/show_bug.cgi?id=10192
1875 Make WebCore (and friends) compile with -Wshorten-64-to-32
1877 * Adds 'f' to float literals where expecting a float.
1878 * Use ceilf() instead of ceil() when assigning to a float.
1879 * Adds explicit casts where OK.
1881 NOTE: The -Wshorten-64-to-32 flag was not added for WebKit
1882 because there are still a few places where no error handling
1883 is in place. The flag can be added as soon as those are worked
1886 * Misc/WebNSControlExtras.m:
1887 (-[NSControl sizeToFitAndAdjustWindowHeight]):
1888 * Misc/WebNSImageExtras.m:
1889 (-[NSImage _web_scaleToMaxSize:]):
1890 * Misc/WebNSViewExtras.h:
1891 * Misc/WebNSViewExtras.m:
1892 * Plugins/WebBaseNetscapePluginView.m:
1893 (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1894 (-[WebBaseNetscapePluginView drawRect:]):
1895 * WebCoreSupport/WebFrameBridge.m:
1896 (-[WebFrameBridge expiresTimeForResponse:]):
1897 * WebInspector/WebInspector.m:
1898 (-[NSWindow window]):
1899 (-[WebInspector treeViewScrollTo:]):
1900 (-[WebInspector _updateSystemColors]):
1901 (-[WebInspector webView:plugInViewWithArguments:]):
1902 (-[WebInspector outlineView:objectValueForTableColumn:byItem:]):
1903 * WebInspector/WebInspectorOutlineView.m:
1904 (-[WebInspectorOutlineView _highlightRow:clipRect:]):
1905 * WebInspector/WebNodeHighlight.m:
1906 (-[WebNodeHighlight initWithBounds:andRects:forView:]):
1907 * WebInspector/WebNodeHighlightView.m:
1908 (-[WebNodeHighlightView roundedRect:withRadius:]):
1909 (-[WebNodeHighlightView initWithHighlight:andRects:forView:]):
1910 (-[WebNodeHighlightView drawRect:]):
1911 * WebView/WebFrame.m:
1912 (-[WebFrame _opened]):
1913 * WebView/WebFrameView.m:
1914 (-[WebFrameView initWithFrame:]):
1915 * WebView/WebHTMLView.m:
1916 (-[WebHTMLView _dragImageForLinkElement:]):
1917 (-[WebHTMLView _web_setPrintingModeRecursive]):
1918 (-[WebHTMLView _web_clearPrintingModeRecursive]):
1919 (-[NSArray layout]):
1920 (-[NSArray _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]):
1921 (-[NSArray adjustPageHeightNew:top:bottom:limit:]):
1922 (-[NSArray _scaleFactorForPrintOperation:]):
1923 (-[NSArray setPageWidthForPrinting:]):
1924 (-[NSArray _endPrintMode]):
1925 (-[NSArray knowsPageRange:]):
1926 (-[NSArray _originalFontA]):
1927 (-[NSArray _originalFontB]):
1928 (-[WebTextCompleteController _buildUI]):
1929 (-[WebTextCompleteController _placePopupWindow:]):
1930 * WebView/WebPDFView.m:
1931 (-[WebPDFView _makeTextStandardSize:]):
1932 (-[WebPDFView selectionImageForcingWhiteText:]):
1933 (-[PDFPrefUpdatingProxy forwardInvocation:]):
1934 * WebView/WebPreferences.m:
1935 (-[WebPreferences _floatValueForKey:]):
1936 * WebView/WebView.m:
1937 (-[WebView makeTextSmaller:]):
1938 (-[WebView canMakeTextStandardSize]):
1939 (-[WebView makeTextStandardSize:]):
1941 2006-08-04 David Kilzer <ddkilzer@kilzer.net>
1943 Reviewed by NOBODY (build fix).
1945 * WebCoreSupport/WebSubresourceLoader.m: REALLY moved to Loader/
1946 * WebView/WebFrameLoader.h: REALLY moved to Loader/
1947 * WebView/WebFrameLoader.m: REALLY moved to Loader/
1948 * WebView/WebLoader.h: REALLY moved to Loader/
1949 * WebView/WebLoader.m: REALLY moved to Loader/
1950 * WebView/WebMainResourceLoader.m: REALLY moved to Loader/
1952 2006-08-03 Maciej Stachowiak <mjs@apple.com>
1956 - moved all loader code that is slated to be moved down to WebCore to a new Loader directory
1958 (next step is to remove dependencies on the rest of WebKit from this directory)
1960 * Loader/WebNetscapePlugInStreamLoader.h: Added.
1961 * Loader/WebNetscapePlugInStreamLoader.m: Added. Cut out of WebNetscapePluginStream.m
1962 (-[WebNetscapePlugInStreamLoader initWithStream:view:]):
1963 (-[WebNetscapePlugInStreamLoader isDone]):
1964 (-[WebNetscapePlugInStreamLoader releaseResources]):
1965 (-[WebNetscapePlugInStreamLoader didReceiveResponse:]):
1966 (-[WebNetscapePlugInStreamLoader didReceiveData:lengthReceived:]):
1967 (-[WebNetscapePlugInStreamLoader didFinishLoading]):
1968 (-[WebNetscapePlugInStreamLoader didFailWithError:]):
1969 (-[WebNetscapePlugInStreamLoader cancelWithError:]):
1970 * Plugins/WebNetscapePluginStream.m:
1971 * WebKit.xcodeproj/project.pbxproj:
1972 * WebCoreSupport/WebSubresourceLoader.h: Moved to Loader/
1973 * WebCoreSupport/WebSubresourceLoader.m: Moved to Loader/
1974 * WebView/WebFrameLoader.h: Moved to Loader/
1975 * WebView/WebFrameLoader.m: Moved to Loader/
1976 * WebView/WebLoader.h: Moved to Loader/
1977 * WebView/WebLoader.m: Moved to Loader/
1978 * WebView/WebMainResourceLoader.h: Moved to Loader/
1979 * WebView/WebMainResourceLoader.m: Moved to Loader/
1981 2006-08-03 Tim Omernick <timo@apple.com>
1983 Reviewed by Kevin Decker.
1985 <rdar://problem/4667460> Windowless OpenGL plug-ins render incorrectly on PowerPC
1987 * Plugins/WebBaseNetscapePluginView.m:
1988 (-[WebBaseNetscapePluginView _aglOffscreenImageForDrawingInRect:]):
1989 Fixed color component swapping so that it works on both x86 and PPC. See comments.
1991 2006-08-03 Brady Eidson <beidson@apple.com>
1993 Reviewed by Tim Hatcher's rubber stamp
1994 Fixed Intel build break caused by weinig's -W change in r15781
1996 * WebView/WebView.m: wrapped cpu-dependent defs with defined() macro
1998 2006-08-03 Maciej Stachowiak <mjs@apple.com>
2002 - fixed problem that could cause assertion failures in Safari
2004 * Plugins/WebBaseNetscapePluginView.m:
2005 (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]): Don't
2006 allow a plugin to start new loads once its document is no longer the one actively loading.
2008 2006-08-03 Maciej Stachowiak <mjs@apple.com>
2012 - remove use of WebDataSource from WebLoader and subclasses, just have them talk to the
2013 WebFrameLoader instead.
2015 For now this is done by forarding all the calls.
2017 * Misc/WebIconLoader.m:
2018 (-[WebIconLoader didFinishLoading]):
2019 * Plugins/WebNetscapePluginStream.m:
2020 (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]):
2021 (-[WebNetscapePluginStream start]):
2022 (-[WebNetscapePlugInStreamLoader didFinishLoading]):
2023 (-[WebNetscapePlugInStreamLoader didFailWithError:]):
2024 (-[WebNetscapePlugInStreamLoader cancelWithError:]):
2025 * WebCoreSupport/WebFrameBridge.m:
2026 (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
2027 (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
2028 * WebCoreSupport/WebSubresourceLoader.h:
2029 * WebCoreSupport/WebSubresourceLoader.m:
2030 (-[WebSubresourceLoader initWithLoader:frameLoader:]):
2031 (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]):
2032 (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:referrer:forFrameLoader:]):
2033 (+[WebSubresourceLoader startLoadingResource:withMethod:URL:customHeaders:postData:referrer:forFrameLoader:]):
2034 (-[WebSubresourceLoader receivedError:]):
2035 (-[WebSubresourceLoader signalFinish]):
2036 (-[WebSubresourceLoader didFailWithError:]):
2037 (-[WebSubresourceLoader cancel]):
2038 * WebKit.xcodeproj/project.pbxproj:
2039 * WebView/WebDataSource.m:
2040 (-[WebDataSource _updateLoading]):
2041 (-[WebDataSource textEncodingName]):
2042 (-[WebDataSource _mainReceivedBytesSoFar:complete:]):
2043 * WebView/WebFrameLoader.h:
2044 * WebView/WebFrameLoader.m:
2045 (-[WebFrameLoader loadIconWithRequest:]):
2046 (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]):
2047 (-[WebFrameLoader clearIconLoader]):
2048 (-[WebFrameLoader commitProvisionalLoad]):
2049 (-[WebFrameLoader activeDataSource]):
2050 (-[WebFrameLoader _archivedSubresourceForURL:]):
2051 (-[WebFrameLoader _defersCallbacks]):
2052 (-[WebFrameLoader _identifierForInitialRequest:]):
2053 (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]):
2054 (-[WebFrameLoader _didReceiveAuthenticationChallenge:forResource:]):
2055 (-[WebFrameLoader _didCancelAuthenticationChallenge:forResource:]):
2056 (-[WebFrameLoader _didReceiveResponse:forResource:]):
2057 (-[WebFrameLoader _didReceiveData:contentLength:forResource:]):
2058 (-[WebFrameLoader _didFinishLoadingForResource:]):
2059 (-[WebFrameLoader _didFailLoadingWithError:forResource:]):
2060 (-[WebFrameLoader _privateBrowsingEnabled]):
2061 (-[WebFrameLoader _addPlugInStreamLoader:]):
2062 (-[WebFrameLoader _removePlugInStreamLoader:]):
2063 (-[WebFrameLoader _finishedLoadingResource]):
2064 (-[WebFrameLoader _receivedError:]):
2065 (-[WebFrameLoader _addSubresourceLoader:]):
2066 (-[WebFrameLoader _removeSubresourceLoader:]):
2067 (-[WebFrameLoader _originalRequest]):
2068 (-[WebFrameLoader webFrame]):
2069 (-[WebFrameLoader _receivedMainResourceError:complete:]):
2070 (-[WebFrameLoader initialRequest]):
2071 (-[WebFrameLoader _receivedData:]):
2072 (-[WebFrameLoader _setRequest:]):
2073 (-[WebFrameLoader _downloadWithLoadingConnection:request:response:proxy:]):
2074 (-[WebFrameLoader _handleFallbackContent]):
2075 (-[WebFrameLoader _isStopping]):
2076 (-[WebFrameLoader _decidePolicyForMIMEType:decisionListener:]):
2077 (-[WebFrameLoader _setupForReplaceByMIMEType:]):
2078 (-[WebFrameLoader _setResponse:]):
2079 (-[WebFrameLoader _mainReceivedError:complete:]):
2080 (-[WebFrameLoader _finishedLoading]):
2081 (-[WebFrameLoader _mainReceivedBytesSoFar:complete:]):
2082 (-[WebFrameLoader _iconLoaderReceivedPageIcon:]):
2083 (-[WebFrameLoader _URL]):
2084 * WebView/WebLoader.h:
2085 * WebView/WebLoader.m:
2086 (-[NSURLProtocol releaseResources]):
2087 (-[NSURLProtocol loadWithRequest:]):
2088 (-[NSURLProtocol setFrameLoader:]):
2089 (-[NSURLProtocol frameLoader]):
2090 (-[NSURLProtocol willSendRequest:redirectResponse:]):
2091 (-[NSURLProtocol didReceiveAuthenticationChallenge:]):
2092 (-[NSURLProtocol didCancelAuthenticationChallenge:]):
2093 (-[NSURLProtocol didReceiveResponse:]):
2094 (-[NSURLProtocol didReceiveData:lengthReceived:]):
2095 (-[NSURLProtocol signalFinish]):
2096 (-[NSURLProtocol didFailWithError:]):
2097 (-[NSURLProtocol willCacheResponse:]):
2098 (-[NSURLProtocol cancelWithError:]):
2099 * WebView/WebMainResourceLoader.h:
2100 * WebView/WebMainResourceLoader.m:
2101 (-[WebMainResourceLoader initWithFrameLoader:]):
2102 (-[WebMainResourceLoader receivedError:]):
2103 (-[WebMainResourceLoader cancelWithError:]):
2104 (-[WebMainResourceLoader _isPostOrRedirectAfterPost:redirectResponse:]):
2105 (-[WebMainResourceLoader addData:]):
2106 (-[WebMainResourceLoader willSendRequest:redirectResponse:]):
2107 (-[WebMainResourceLoader continueAfterContentPolicy:response:]):
2108 (-[WebMainResourceLoader continueAfterContentPolicy:]):
2109 (-[WebMainResourceLoader checkContentPolicyForResponse:]):
2110 (-[WebMainResourceLoader didReceiveResponse:]):
2111 (-[WebMainResourceLoader didReceiveData:lengthReceived:]):
2112 (-[WebMainResourceLoader didFinishLoading]):
2113 (-[WebMainResourceLoader didFailWithError:]):
2114 (-[WebMainResourceLoader loadWithRequestNow:]):
2116 2006-08-03 Sam Weinig <sam.weinig@gmail.com>
2120 - patch for http://bugs.webkit.org/show_bug.cgi?id=10176
2121 Make WebCore compile with -Wundef
2123 * Adds -Wundef flag to Xcode project
2124 * Converts #ifs to #ifdef and #ifndefs where needed.
2126 * Carbon/CarbonUtils.m:
2127 * Carbon/CarbonWindowAdapter.m:
2128 * Carbon/HIViewAdapter.m:
2129 (+[NSView bindHIViewToNSView:nsView:]):
2130 * Carbon/HIWebView.m:
2131 (HIWebViewEventHandler):
2132 * Misc/WebFileDatabase.m:
2133 (UniqueFilePathForKey):
2134 * Misc/WebNSWindowExtras.m:
2135 (swizzleInstanceMethod):
2136 * Misc/WebTypesInternal.h:
2137 * Plugins/WebNetscapeDeprecatedFunctions.c:
2138 * Plugins/WebNetscapeDeprecatedFunctions.h:
2139 * Plugins/WebNetscapePluginPackage.h:
2140 * Plugins/WebNetscapePluginPackage.m:
2141 (-[WebNetscapePluginPackage unloadWithoutShutdown]):
2142 (-[WebNetscapePluginPackage load]):
2143 * WebKit.xcodeproj/project.pbxproj:
2145 2006-08-03 Darin Adler <darin@apple.com>
2147 Reviewed by Eric Seidel.
2151 * WebView/WebFrame.m: (-[WebFramePrivate dealloc]): Release the frame loader.
2153 2006-08-02 Timothy Hatcher <timothy@apple.com>
2155 Rubber stamped by Maciej.
2157 Adding back resultsWithXpathQuery, removed by Darin's earlier change.
2158 This function is called from ObjC, but not used from JavaScript.
2160 * WebInspector/webInspector/inspector.js:
2162 2006-08-02 Timothy Hatcher <timothy@apple.com>
2166 Bug 10200: [Drosera] Deadlock between Drosera and Safari while loading page
2167 http://bugs.webkit.org/show_bug.cgi?id=10200
2169 Prevent reentrancy in our debugger callbacks. This was causing a deadlock in Drosera because
2170 suspendProcessIfPaused was being called during a DO call into Safari.
2172 Preventing reentrancy also prevents scripts that Drosera injects and evaluates from showing
2173 up in rare cases (such as a iframe loading about:blank). I thought this would prevent cases
2174 where you call a function from the console and expect it to break on a breakpoint in them, but
2175 this appears to never have worked even without this change. When that is figured out we can
2176 reconsider a better solution to reentrancy. I have filed that as bug 10214.
2178 I also removed the NSRunLoop runMode:beforeDate: calls since DO handles this for us since
2179 we don't use "onway void" as the return type for the callbacks. Note: using onway void for
2180 the listener callbacks causes bad synchronization issues and obscure crashes.
2182 * DefaultDelegates/WebScriptDebugServer.m:
2183 (-[WebScriptDebugServer webView:didLoadMainResourceForDataSource:]):
2184 (-[WebScriptDebugServer webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
2185 (-[WebScriptDebugServer webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
2186 (-[WebScriptDebugServer webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
2187 (-[WebScriptDebugServer webView:willExecuteStatement:sourceId:line:forWebFrame:]):
2188 (-[WebScriptDebugServer webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
2189 (-[WebScriptDebugServer webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
2190 * DefaultDelegates/WebScriptDebugServerPrivate.h:
2192 2006-08-02 Maciej Stachowiak <mjs@apple.com>
2196 - fix assertion failure on layout tests by stopping plugins from loading at a clearly defined time
2197 - add more assertions for safety
2199 * WebView/WebDataSource.m:
2200 (-[WebDataSourcePrivate dealloc]): Removed obsolete comment.
2201 (-[WebDataSource _updateLoading]): Add assertion ensuring this method is only called
2202 at a time when this data source is the one that might be loading for a frame.
2203 (-[WebDataSource _stopLoading]): Stop loading plugins as a FIXME suggests we should.
2204 * WebView/WebFrameLoader.m:
2205 (-[WebFrameLoader isLoadingPlugIns]): New helper method.
2206 (-[WebFrameLoader isLoading]): Consider plugin loads too - otherwise we won't stop them
2207 at stopLoading time.
2209 2006-08-02 Adam Roben <aroben@apple.com>
2213 - Rename TransferJob to ResourceLoader (this file was forgotten in an
2214 earlier change by Maciej)
2218 2006-08-01 Maciej Stachowiak <mjs@apple.com>
2222 - Change things around so WebFrameLoader tracks the main and provisional data source,
2223 as well as the frame load state, pulling much code out of WebFrame along the way.
2225 The most significant aspects of this change are:
2227 - management of WebDataSources and WebFrameState was moved into WebFrameLoader
2228 - there is now just one WebFrameLoader shared between the primary and provisional data source
2230 * WebKit.xcodeproj/project.pbxproj:
2231 * WebView/WebDataSource.m:
2232 (-[WebDataSourcePrivate dealloc]):
2233 (-[WebDataSource _updateLoading]):
2234 (-[WebDataSource _loadIcon]):
2235 (-[WebDataSource _setPrimaryLoadComplete:]):
2236 (-[WebDataSource _stopLoading]):
2237 (-[WebDataSource _startLoading]):
2238 (-[WebDataSource _addSubresourceLoader:]):
2239 (-[WebDataSource _removeSubresourceLoader:]):
2240 (-[WebDataSource _addPlugInStreamLoader:]):
2241 (-[WebDataSource _removePlugInStreamLoader:]):
2242 (-[WebDataSource _defersCallbacksChanged]):
2243 (-[WebDataSource _stopLoadingWithError:]):
2244 (-[WebDataSource _revertToProvisionalState]):
2245 (-[WebDataSource _setupForReplaceByMIMEType:]):
2246 (-[WebDataSource initWithRequest:]):
2247 (-[WebDataSource data]):
2248 (-[WebDataSource isLoading]):
2249 * WebView/WebFrame.m:
2250 (-[WebFramePrivate init]):
2251 (-[WebFramePrivate dealloc]):
2252 (-[WebFrame _closeOldDataSources]):
2253 (-[WebFrame _detachFromParent]):
2254 (-[WebFrame _makeDocumentView]):
2255 (-[WebFrame _receivedMainResourceError:]):
2256 (-[WebFrame _transitionToCommitted:]):
2257 (+[WebFrame _timeOfLastCompletedLoad]):
2258 (-[WebFrame _checkLoadCompleteForThisFrame]):
2259 (-[WebFrame _loadItem:withLoadType:]):
2260 (-[WebFrame _continueAfterWillSubmitForm:]):
2261 (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
2262 (-[WebFrame _initWithWebFrameView:webView:bridge:]):
2263 (-[WebFrame _frameLoader]):
2264 (-[WebFrame _provisionalLoadStarted]):
2265 (-[WebFrame _prepareForDataSourceReplacement]):
2266 (-[WebFrame _frameLoadCompleted]):
2267 (-[WebFrame provisionalDataSource]):
2268 (-[WebFrame dataSource]):
2269 (-[WebFrame stopLoading]):
2270 * WebView/WebFrameInternal.h:
2271 * WebView/WebFrameLoader.h:
2272 * WebView/WebFrameLoader.m:
2273 (-[WebFrameLoader initWithWebFrame:]):
2274 (-[WebFrameLoader dealloc]):
2275 (-[WebFrameLoader dataSource]):
2276 (-[WebFrameLoader _setDataSource:]):
2277 (-[WebFrameLoader clearDataSource]):
2278 (-[WebFrameLoader provisionalDataSource]):
2279 (-[WebFrameLoader _setProvisionalDataSource:]):
2280 (-[WebFrameLoader _clearProvisionalDataSource]):
2281 (-[WebFrameLoader state]):
2282 (+[WebFrameLoader timeOfLastCompletedLoad]):
2283 (-[WebFrameLoader _setState:]):
2284 (-[WebFrameLoader clearProvisionalLoad]):
2285 (-[WebFrameLoader markLoadComplete]):
2286 (-[WebFrameLoader commitProvisionalLoad]):
2287 (-[WebFrameLoader stopLoading]):
2288 (-[WebFrameLoader startLoading]):
2289 (-[WebFrameLoader startProvisionalLoad:]):
2290 (-[WebFrameLoader setupForReplace]):
2291 * WebView/WebFramePrivate.h:
2293 2006-08-01 Tim Omernick <timo@apple.com>
2295 Reviewed by John Sullivan.
2297 <rdar://problem/4480737> Flash crashes after it replaces itself via a document.write()
2299 I kind of hate to do this, but this is the best way to work around buggy plug-ins like Flash that assume that
2300 NPP_Destroy() cannot be called while the browser is calling one of its other plug-in functions. The classic
2301 situation is a plug-in that replaces itself via an NPN_Invoke() that executes a document.write().
2303 * Plugins/WebBaseNetscapePluginView.h:
2304 * Plugins/WebBaseNetscapePluginView.m:
2305 (-[WebBaseNetscapePluginView sendEvent:]):
2306 Call -willCallPlugInFunction and -didCallPlugInFunction around calls to the NPP_* functions.
2307 (-[WebBaseNetscapePluginView setWindowIfNecessary]):
2309 (-[WebBaseNetscapePluginView start]):
2310 It should not be possible to start a plug-in instance while we are calling into it (one of those chicken/egg
2311 problems). Added a sanity-checking assertion.
2312 (-[WebBaseNetscapePluginView stop]):
2313 If we're already calling a plug-in function, do not call NPP_Destroy(). The plug-in function we are calling
2314 may assume that its instance->pdata, or other memory freed by NPP_Destroy(), is valid and unchanged until said
2315 plugin-function returns.
2316 (-[WebBaseNetscapePluginView pluginScriptableObject]):
2317 Call -willCallPlugInFunction and -didCallPlugInFunction around calls to the NPP_* functions.
2318 (-[WebBaseNetscapePluginView willCallPlugInFunction]):
2319 Increment plug-in function call depth.
2320 (-[WebBaseNetscapePluginView didCallPlugInFunction]):
2321 Decrement plug-in function call depth. Stop if we're supposed to stop.
2322 (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
2323 Call -willCallPlugInFunction and -didCallPlugInFunction around calls to the NPP_* functions.
2324 (-[WebBaseNetscapePluginView webFrame:didFinishLoadWithReason:]):
2326 (-[WebBaseNetscapePluginView _printedPluginBitmap]):
2329 * Plugins/WebBaseNetscapePluginStream.m:
2330 (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:]):
2331 Call -willCallPlugInFunction and -didCallPlugInFunction around calls to the NPP_* functions.
2332 (-[WebBaseNetscapePluginStream _destroyStream]):
2334 (-[WebBaseNetscapePluginStream _deliverData]):
2337 2006-08-01 Maciej Stachowiak <mjs@apple.com>
2339 - fix build after last change
2341 * WebView/WebFrame.m:
2342 (-[WebFrame _checkLoadCompleteForThisFrame]):
2344 2006-08-01 Maciej Stachowiak <mjs@apple.com>
2348 - revert part of my last fix that broke the Safari bookmarks view
2350 * WebView/WebFrame.m:
2351 (-[WebFrame _checkLoadCompleteForThisFrame]): still send layout message for non-HTML views
2353 2006-08-01 Tim Omernick <timo@apple.com>
2357 Fixed an assertion failure I ran into while debugging <rdar://problem/4652683>.
2359 * Plugins/WebNetscapePluginEmbeddedView.m:
2360 (-[WebNetscapePluginEmbeddedView redeliverStream]):
2361 Don't clear the "instance" ivar here. This code was refactored here from the old WebNetscapePluginRepresentation,
2362 which also had an "instance" ivar. It is never appropriate to clear a plug-in view's instance. That is done when
2363 the plug-in is destroyed.
2365 2006-08-01 Maciej Stachowiak <mjs@apple.com>
2369 - some refactoring in preparation for moving more stuff to WebFrameLoader.
2371 * WebView/WebFrame.m:
2372 (-[WebFrame _clearDataSource]):
2373 (-[WebFrame _detachFromParent]):
2374 (-[WebFrame _commitProvisionalLoad]):
2375 (-[WebFrame _transitionToCommitted:]):
2376 (-[WebFrame _clearProvisionalLoad]):
2377 (-[WebFrame _markLoadComplete]):
2378 (-[WebFrame _checkLoadCompleteForThisFrame]):
2379 (-[WebFrame _startProvisionalLoad:]):
2380 (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
2381 (-[WebFrame stopLoading]):
2383 2006-07-31 Maciej Stachowiak <mjs@apple.com>
2385 Reviewed by Tim Hatcher.
2387 - renamed TransferJob to ResourceLoader in WebCore
2390 (WebFrame::loadDataSource):
2391 (WebFrame::receivedRedirect):
2392 (WebFrame::receivedResponse):
2393 (WebFrame::receivedData):
2394 (WebFrame::receivedAllData):
2395 (WebFrame::setStatusText):
2398 2006-07-31 Darin Adler <darin@apple.com>
2402 - omit the margin and padding boxes for display types where they are ignored
2403 - use CSS instead of properties for table spacing and padding as suggested by Tim H.
2405 * WebInspector/webInspector/inspector.css: Added rules for spacing and padding.
2406 Added rules that hide the margin and padding boxes (borders and all but the center cell)
2407 when the hide attribute is present.
2408 * WebInspector/webInspector/inspector.html: Added classes for the rules above.
2409 Removed cellpadding and cellspacing attributes.
2410 * WebInspector/webInspector/inspector.js: Added code to hide/show the margin and
2411 padding boxes based on the display type.
2413 2006-07-31 Duncan Wilcox <duncan@mclink.it>
2417 Fixes <http://bugs.webkit.org/show_bug.cgi?id=10159>
2418 "REGRESSION: delegate returning no menu elements crashes webkit"
2420 No automated test, because there's no way to programmatically open a context menu,
2421 no manual test because there's no way to customize the context menu delegate.
2423 * WebView/WebView.m:
2424 (-[WebView _menuForElement:defaultItems:]): Make sure the context menu returned
2425 some menu items before accessing the first one.
2427 2006-07-31 Timothy Hatcher <timothy@apple.com>
2431 <rdar://problem/4658194> REGRESSION: "Search in Google"
2432 and "Search in Spotlight" fail to work on text selected in a frame
2434 Use selectedFrame to get the frame with the text selection.
2436 * WebView/WebView.m:
2437 (-[WebView _searchWithGoogleFromMenu:]):
2438 (-[WebView _searchWithSpotlightFromMenu:]):
2440 2006-07-31 Darin Adler <darin@apple.com>
2442 Reviewed by Tim Hatcher.
2444 - http://bugs.webkit.org/show_bug.cgi?id=10168
2445 add a first cut at a Metrics pane to the inspector
2447 * WebInspector/webInspector/inspector.css: Add styles for the new metrics pane.
2448 * WebInspector/webInspector/inspector.html: Add the new metrics pane, starting with
2449 the table to show the box model.
2450 * WebInspector/webInspector/inspector.js: Add the new metrics pane. Add back some
2451 "title" attributes so we have more tooltips. Removed the optional parameter to
2454 2006-07-31 Anders Carlsson <acarlsson@apple.com>
2458 * Plugins/WebPluginDatabase.m:
2459 (-[WebPluginDatabase refresh]):
2460 Create a mutable set instead of a mutable array.
2462 2006-07-30 Darin Adler <darin@apple.com>
2464 Reviewed by Tim Hatcher.
2466 * WebInspector/webInspector/inspector.js: Fix bug where a null property value
2467 leads to an empty style pane.
2469 2006-07-30 Darin Adler <darin@apple.com>
2471 Reviewed by Tim Hatcher.
2473 - http://bugs.webkit.org/show_bug.cgi?id=10163
2474 some improvements for the inspector
2476 * WebInspector/WebInspector.m:
2477 (+[WebInspector sharedWebInspector:]): Fixed bug that could cause the inspector
2478 to be garbage collected if used in an application with GC enabled.
2479 (-[WebInspector dealloc]): Removed a call to a non-existent close method.
2480 (-[WebInspector window]): Added a custom WebPreferences object and called
2481 setPrivateBrowsingEnabled:YES so the inspector won't appear in the history menu.
2482 Also call setProhibitsMainFrameScrolling:YES to try to get rid of trouble where
2483 the inspector scrolls when dragging.
2485 * WebInspector/webInspector/inspector.css: Added style for the new color swatch,
2486 and JavaScript properties. More of the style should be shared between the panes,
2487 but this should be OK for now.
2489 * WebInspector/webInspector/inspector.html: Added a first cut at a JavaScript
2490 properties pane. Needs work, but better than nothing.
2492 * WebInspector/webInspector/inspector.js: Lots of improvements:
2493 - Omit "typical" property values from computed style display, making it much shorter.
2494 - Use the words "black", "white", and "transparent" when appropriate for color values.
2495 - Refactored the loaded() function to get rid of repetitive scrollbar setup.
2496 - Added a new scrollarea for the JavaScript properties pane.
2497 - Simplified refreshScrollbars() -- we now refresh all scrollbars every time, which does no harm.
2498 - Removed unused resultsWithXpathQuery().
2499 - Use [] instead of "new Array()" and {} instead of "new Object()".
2500 - Removed unused xpathForNode().
2501 - Changed style pane to display the style for a text node's parent instead of saying
2502 it can't display the style for text.
2503 - Fixed regression I caused a while back by checking the length of a computed style
2504 and not trying to display anything if its length is 0. Before this change and the
2505 corresponding change in WebCore, we'd see a complete list of all styles with the
2506 empty string as the value for each one.
2507 - Changed the name of the computedStyle flag on the style rules array to isComputedStyle
2508 to make it easier to understand it's a boolean.
2509 - Fixed an error in the code that does !important scanning where it was trying to
2510 do a special case for computed style, but was checking the computed style flag on
2512 - Added populateStyleListItem() function to factor out things in common between the
2513 items in the top level list and the expanded tree for shorthand properties.
2514 - Added code to make a color swatch next to the textual representation for any
2515 property that contains a color.
2516 - Implemented a first cut at a simple JavaScript properties pane.
2518 2006-07-29 Darin Adler <darin@apple.com>
2520 - Removed tabs from these source files that still had them.
2521 We don't use them; that way source files look fine in editors
2522 that have tabs set to 8 spaces or to 4 spaces.
2523 - Removed allow-tabs Subversion property from the files too.
2525 * DefaultDelegates/WebDefaultPolicyDelegate.m:
2526 * History/WebHistory.m:
2527 * Misc/WebDownload.m:
2528 * Misc/WebIconDatabase.m:
2529 * Misc/WebKitErrors.m:
2530 * Misc/WebKitLogging.m:
2531 * Misc/WebNSDataExtras.m:
2532 * Misc/WebNSFileManagerExtras.m:
2533 * Panels/WebPanelAuthenticationHandler.m:
2534 * Plugins/WebBaseNetscapePluginView.m:
2535 * Plugins/npfunctions.h:
2536 * WebCoreSupport/WebSubresourceLoader.m:
2537 * WebView/WebMainResourceLoader.m:
2538 * WebView/WebView.h:
2539 * WebView/WebView.m:
2541 2006-07-29 Sam Weinig <sam.weinig@gmail.com>
2545 - patch for http://bugs.webkit.org/show_bug.cgi?id=10080
2546 Adopt pedantic changes from the Unity project to improve
2547 cross-compiler compatibility
2550 * Adding missing newline to the end of the file.
2551 * Turning on gcc warning for missing newline at the end of a source file
2552 (GCC_WARN_ABOUT_MISSING_NEWLINE in Xcode, -Wnewline in gcc).
2554 * WebKit.xcodeproj/project.pbxproj:
2555 * WebView/WebResourcePrivate.h:
2557 2006-07-29 Mitz Pettel <opendarwin.org@mitzpettel.com>
2559 Reviewed by John Sullivan.
2561 - fix http://bugs.webkit.org/show_bug.cgi?id=9984
2562 ASSERTION FAILURE: _private->mouseDownEvent != nil
2563 (WebKit/WebView/WebHTMLView.m:4863 -[WebHTMLView(WebInternal) _delegateDragSourceActionMask])
2565 * WebView/WebHTMLView.m:
2566 (-[WebHTMLView _setMouseDownEvent:]): Moved into the WebHTMLViewFileInternal category and changed
2568 (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
2569 Copy the hit HTMLView's mouse down event to the top HTMLView.
2570 (-[WebHTMLView acceptsFirstMouse:]): Added a call to _setMouseDownEvent:nil before returning.
2571 (-[WebHTMLView shouldDelayWindowOrderingForEvent:]): Added a call to _setMouseDownEvent:nil
2573 (-[WebHTMLView mouseUp:]): Added a call to _setMouseDownEvent:nil to clear the event set in
2574 mouseDown: (and used during dragging).
2575 (-[WebHTMLView _delegateDragSourceActionMask]): Copy the hit HTMLView's mouse down event to
2578 2006-07-28 Timothy Hatcher <timothy@apple.com>
2582 <rdar://problem/4657473> REGRESSION: Spell check not available from contextual menu in Mail
2584 The context menu code should be checking isContentEditable
2585 on DOMNode not just DOMElement. This is needed because DOMText
2586 will be the node class of any text that is clicked.
2588 * DefaultDelegates/WebDefaultContextMenuDelegate.m:
2589 (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):
2591 2006-07-25 Geoffrey Garen <ggaren@apple.com>
2593 Reviewed by Maciej, inspired by John.
2595 - Fixed <rdar://problem/4651931> 1% REGRESSION on iBench HTML due to
2596 repeated requests for non-existent favicon
2598 An optimization to avoid serializing favicon data for missing icons had stomped an
2599 optimization to avoid GETing a missing favicon more than once. The solution
2600 is a happy marriage of optimizations, ensuring that we *retain* the missing
2601 favicon's "i am missing" data without posting a notification or saving it to disk.
2603 * Misc/WebIconDatabase.m:
2604 (-[WebIconDatabase _setIconURL:forURL:]):
2606 2006-07-25 David Harrison <harrison@apple.com>
2608 Reviewed by timo and Darin.
2610 <rdar://problem/4618584> "Paste and Match Style" is not working in Mail (add SPI)
2612 * WebKit.xcodeproj/project.pbxproj:
2613 * WebView/WebView.m:
2614 (-[WebView replaceSelectionWithNode:]):
2615 (-[WebView _replaceSelectionWithNode:matchStyle:]):
2616 * WebView/WebViewPrivate.h:
2617 (-[WebView _replaceSelectionWithNode:matchStyle::]):
2618 New SPI that is same as replaceSelectionWithNode: with added parameter whether to match existing style.
2620 2006-07-24 Darin Adler <darin@apple.com>
2622 Reviewed by Adele and Justin.
2624 - update for change to require context when creating fragments from text
2625 (needed to handle whitespace properly)
2627 * WebView/WebHTMLView.m:
2628 (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]):
2629 Added context parameter, pass through to bridge.
2630 (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Pass selection range as context
2631 when calling above method.
2632 (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): Pass drag caret as context when
2633 calling above method.
2635 2006-07-24 Maciej Stachowiak <mjs@apple.com>
2639 - fix <rdar://problem/4609195> Help Viewer loads empty window (not getting didFailLoadingWithError: callback)
2640 (without re-introducing http://bugs.webkit.org/show_bug.cgi?id=10062 )
2642 * WebView/WebLoader.h:
2643 * WebView/WebMainResourceLoader.m:
2644 (-[WebMainResourceLoader receivedError:]): Copy in some code from the base class to do it in the proper
2645 order, surrounding the call to [ds _receivedMainResourceError:error complete:YES].
2647 2006-07-24 Anders Carlsson <acarlsson@apple.com>
2651 * Misc/WebIconDatabase.m:
2652 (-[WebIconDatabase removeAllIcons]):
2653 Make an array of the keys and iterate through it to avoid modifying the
2654 dictionary while enumerating it.
2656 2006-07-24 Timothy Hatcher <timothy@apple.com>
2658 Reviewed by John and Darin.
2660 <rdar://problem/4634290> Cannot selectively install a custom
2661 scroller that differs from the default Aqua frame size.
2663 Adds two new private methods to WebFrameView that allows
2664 an application to set a custom scroll view class. This is needed
2665 if the application wants to install a custom scroller that is wider
2666 than the typical scroller, because NSScrollView does the content
2667 rect calculations in a class method (ignoring custom scrollers.)
2668 The _setScrollViewClass method requires the class to be a subclass
2669 of WebDynamicScrollBarView, or nil can be passed to reset to the default class.
2670 A new scroll view of the specified class will then replace the previous
2671 one without the need to reload content of the frame.
2673 * WebView/WebFrameView.m:
2674 (-[WebFrameView _customScrollViewClass]):
2675 (-[WebFrameView _setCustomScrollViewClass:]):
2676 * WebView/WebFrameViewPrivate.h:
2678 2006-07-24 Alexey Proskuryakov <ap@nypop.com>
2682 Fix http://bugs.webkit.org/show_bug.cgi?id=10009
2683 REGRESSION: Schubert-IT PDF Plug-in not working for full page (works in frames)
2685 * WebView/WebView.m:
2686 (+[WebView _viewClass:andRepresentationClass:forMIMEType:]): If we've got a type supported by WebPDFView,
2687 make sure to initialize the plugin database, in case a plugin wants to handle it.
2689 2006-07-23 Mark Rowe <opendarwin.org@bdash.net.nz>
2693 Bug 9686: [Drosera] Need the ability to break into Drosera on Javascript exceptions
2694 http://bugs.webkit.org/show_bug.cgi?id=9686
2696 WebKit portion of the fix.
2698 * DefaultDelegates/WebDefaultScriptDebugDelegate.m:
2699 (-[WebDefaultScriptDebugDelegate webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
2700 * DefaultDelegates/WebScriptDebugServer.h:
2701 * DefaultDelegates/WebScriptDebugServer.m:
2702 (-[WebScriptDebugServer webView:exceptionWasRaised:sourceId:line:forWebFrame:]): Notify
2703 listeners that an exception has been raised.
2704 * WebView/WebScriptDebugDelegate.h:
2705 * WebView/WebScriptDebugDelegate.m:
2706 (-[WebScriptCallFrame exceptionRaised:sourceId:line:]): Dispatch through to delegate and
2707 WebScriptDebugServer.
2709 2006-07-23 Adele Peterson <adele@apple.com>
2713 - Fix for <rdar://problem/4646276> CrashTracer: 7 crashes in Safari at com.apple.WebCore: WebCore::RenderTableSection::paint + 155
2715 * WebView/WebHTMLView.m: (-[WebHTMLView _web_layoutIfNeededRecursive:testDirtyRect:]):
2716 needsDisplay was returning NO even though the view has a dirty rect (see <rdar://problem/4647062>). Since we know about
2717 the dirty rect, we don't actually need to check needsDisplay.
2719 2006-07-22 Timothy Hatcher <timothy@apple.com>
2723 Bug 10062: REGRESSION: dom/xhtml/level2/html/HTMLIFrameElement11.xhtml asserts/crashes
2724 http://bugs.webkit.org/show_bug.cgi?id=10062
2726 2006-07-21 Timothy Hatcher <timothy@apple.com>
2730 <rdar://problem/4609195> Help Viewer loads empty window
2731 (not getting didFailLoadingWithError: callback)
2733 Call super's didFailWithError before _receivedMainResourceError
2734 because _receivedMainResourceError will cause the datasource's
2735 frame to be set to nil before the didFailLoadingWithError delegate
2736 callback is sent. (This order is needed now that WebDataSource does
2737 not hold on to the WebView; it uses the WebFrame to get to the WebView.
2738 If the WebFrame is nil we can't get to the WebView's resource load delegate.)
2740 * WebView/WebMainResourceLoader.m:
2741 (-[WebMainResourceLoader receivedError:]):
2744 2006-07-22 Timothy Hatcher <timothy@apple.com>
2748 <rdar://problem/4646318> REGRESSION: Ctrl-clicking on a selection containing a word doesn't display a complete contextual menu
2750 Show the editing context menu if the WebView is editible.
2751 The original change only checked if the DOM element was editable,
2752 and isContentEditable returns NO if entire WebView is editable.
2754 * DefaultDelegates/WebDefaultContextMenuDelegate.m:
2755 (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):
2757 2006-07-21 Timothy Hatcher <timothy@apple.com>
2761 <rdar://problem/4609195> Help Viewer loads empty window
2762 (not getting didFailLoadingWithError: callback)
2764 Call super's didFailWithError before _receivedMainResourceError
2765 because _receivedMainResourceError will cause the datasource's
2766 frame to be set to nil before the didFailLoadingWithError delegate
2767 callback is sent. (This order is needed now that WebDataSource does
2768 not hold on to the WebView; it uses the WebFrame to get to the WebView.
2769 If the WebFrame is nil we can't get to the WebView's resource load delegate.)
2771 * WebView/WebMainResourceLoader.m:
2772 (-[WebMainResourceLoader receivedError:]):
2774 === Safari-521.20 ===
2776 2006-07-21 Timothy Hatcher <timothy@apple.com>
2780 <rdar://problem/4607572> REGRESSION (521.10.1 - 521.13): most context menu items missing when a form field is focused (common on google.com) (9680)
2782 Do not use _isEditable call since that only checks if the current
2783 selection or frame is editible. We now check if the currently clicked element
2784 is a content editible area, a textarea, an isindex or an input element that
2785 return YES to _isTextField.
2787 * DefaultDelegates/WebDefaultContextMenuDelegate.m:
2788 (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):
2790 2006-07-20 John Sullivan <sullivan@apple.com>
2794 - WebKit part of fix for:
2795 <rdar://problem/4557386> REGRESSION (419.3-521.19): repro Safari world leak involving
2796 closing tabs after clicking in a web page
2798 * WebCoreSupport/WebFrameBridge.m:
2799 (-[WebFrameBridge textViewWasFirstResponderAtMouseDownTime:]):
2800 renamed to be more specific (formerly wasFirstResponderAtMouseDownTime:)
2802 * WebView/WebHTMLViewInternal.h:
2803 * WebView/WebHTMLView.m:
2804 (-[WebTextCompleteController dealloc]):
2805 updated for name change
2806 (-[NSArray _setMouseDownEvent:]):
2807 Now only retains the first responder if it's a textView, since that's the only case that the only client
2808 actually cares about. This avoids a reference cycle caused by retaining self. This is the only substantive
2809 part of the patch; all the rest is just renaming for clarity, and comments.
2810 (-[NSArray mouseDown:]):
2811 updated for name change
2812 (-[WebHTMLView _textViewWasFirstResponderAtMouseDownTime:]):
2813 renamed to be more specific (formerly _wasFirstResponderAtMouseDownTime:)
2815 2006-07-19 Tim Omernick <timo@apple.com>
2819 <rdar://problem/4523432> safari crashed right after disabling "block pop up windows" (or other WebPreferences changes)
2821 * Plugins/WebBaseNetscapePluginView.m:
2822 (-[WebBaseNetscapePluginView viewWillMoveToSuperview:]):
2823 Stop the plug-in when it is removed from its superview. It is not sufficient to do this in -viewWillMoveToWindow:nil, because
2824 the WebView might still has a hostWindow at that point, which prevents the plug-in from being destroyed.
2825 There is no need to start the plug-in when moving into a superview. -viewDidMoveToWindow takes care of that.
2827 === Safari-521.19 ===
2829 2006-07-17 Tim Omernick <timo@apple.com>
2833 <rdar://problem/4612079> need a way to prevent pages from scrolling to reveal elements that are focused
2836 * WebView/WebViewPrivate.h:
2837 * WebView/WebView.m:
2838 (-[WebView setProhibitsMainFrameScrolling:]):
2839 New method. Prohibits scrolling in the WebView's main frame. Used to "lock" a WebView to a specific
2842 2006-07-17 Timothy Hatcher <timothy@apple.com>
2846 <rdar://problem/4635311> REGRESSION: WebKit should call windowScriptObjectAvailable before attaching the script debugger
2848 * WebCoreSupport/WebFrameBridge.m:
2849 (-[WebFrameBridge windowObjectCleared]):
2851 2006-07-17 Timothy Hatcher <timothy@apple.com>
2855 <rdar://problem/4634874> WebScriptObject and WebUndefined are no longer defined by WebKit
2857 Copy WebScriptObject.h from WebCore's private headers, not JavaScriptCore.
2859 * WebKit.xcodeproj/project.pbxproj:
2861 2006-07-17 John Sullivan <sullivan@apple.com>
2863 Reviewed by Tim Omernick.
2865 - fixed <rdar://problem/4604366> Orange Find highlight displays text in wrong size on PDF pages
2866 if they're not at "actual size"
2868 To match WebHTMLView, I made the methods that return attributed strings take the view's scale
2869 factor into account.
2871 * WebView/WebPDFView.m:
2872 (-[WebPDFView _scaledAttributedString:]):
2873 new helper method, takes an attributed string and returns one that's scaled by the view's
2874 current scale factor
2875 (-[WebPDFView attributedString]):
2876 pass result through _scaledAttributedString:
2877 (-[WebPDFView selectedAttributedString]):
2880 2006-07-17 Justin Garcia <justin.garcia@apple.com>
2884 Rolled the first fix for:
2885 <http://bugs.webkit.org/show_bug.cgi?id=9642>
2886 GMail Editor: Operations that use drop down menus blow away the selection
2887 back in and removed the call to _clearSelectionInOtherFrames from
2888 -[WebHTMLView becomeFirstResponder] to fix the bug.
2890 * WebView/WebHTMLView.m:
2891 (-[NSArray maintainsInactiveSelection]):
2892 (-[NSArray becomeFirstResponder]):
2893 * WebView/WebView.m:
2894 (-[WebView maintainsInactiveSelection]):
2896 2006-07-15 Darin Adler <darin@apple.com>
2898 Reviewed by John Sullivan.
2900 - fix http://bugs.webkit.org/show_bug.cgi?id=9928
2901 REGRESSION: Text Encoding menu inoperative (after gcc protocol build fix)
2903 * WebView/WebHTMLView.m:
2904 (-[WebHTMLView _documentRange]): Moved into WebHTMLViewFileInternal category.
2905 (-[WebHTMLView selectionRect]): Moved into WebDocumentPrivateProtocols category.
2906 (-[WebHTMLView selectionView]): Ditto.
2907 (-[WebHTMLView selectionImageForcingWhiteText:]): Ditto.
2908 (-[WebHTMLView selectionImageRect]): Ditto.
2909 (-[WebHTMLView pasteboardTypesForSelection]): Ditto.
2910 (-[WebHTMLView selectAll]): Ditto.
2911 (-[WebHTMLView deselectAll]): Ditto.
2912 (-[WebHTMLView string]): Ditto.
2913 (-[WebHTMLView _attributeStringFromDOMRange:]): Ditto.
2914 (-[WebHTMLView attributedString]): Ditto.
2915 (-[WebHTMLView selectedString]): Ditto.
2916 (-[WebHTMLView selectedAttributedString]): Ditto.
2917 (-[WebHTMLView supportsTextEncoding]): Ditto.
2918 (-[WebHTMLView _canProcessDragWithDraggingInfo:]): Moved into WebDocumentInternalProtocols.
2919 (-[WebHTMLView _isMoveDrag]): Ditto.
2920 (-[WebHTMLView _isNSColorDrag:]): Ditto.
2921 (-[WebHTMLView draggingUpdatedWithDraggingInfo:actionMask:]): Ditto.
2922 (-[WebHTMLView draggingCancelledWithDraggingInfo:]): Ditto.
2923 (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): Ditto.
2924 (-[WebHTMLView elementAtPoint:]): Ditto.
2925 (-[WebHTMLView elementAtPoint:allowShadowContent:]): Ditto.
2927 * WebKit.xcodeproj/project.pbxproj: Let Xcode 2.3 do its thing.
2929 === Safari-521.17 ===
2931 2006-07-14 Timothy Hatcher <timothy@apple.com>
2933 Rolling out this fix from r15358 since it isn't resolved.
2935 2006-07-11 Justin Garcia <justin.garcia@apple.com>
2937 Reviewed by levi & thatcher
2939 <http://bugs.webkit.org/show_bug.cgi?id=9642>
2940 GMail Editor: Operations that use drop down menus blow away the selection
2942 * WebView/WebHTMLView.m:
2943 (-[WebHTMLView maintainsInactiveSelection]): Maintain an inactive selection
2944 when resigning as first responder if the selection is editable
2945 or if the WebView tells us to.
2946 * WebView/WebView.m:
2947 (-[WebView maintainsInactiveSelection]): Just because a WebView is
2948 editable doesn't mean selections inside subframes will be. Return
2951 2006-07-14 Timothy Hatcher <timothy@apple.com>
2953 <rdar://problem/4623957> SWB: gcc-5412 (new?) objc warning causes WebCore project failure
2955 Build fix with the new GCC. Removes forward declarations of protocols.
2957 * Misc/WebSearchableTextView.h:
2958 * WebCoreSupport/WebSubresourceLoader.h:
2959 * WebKit.xcodeproj/project.pbxproj:
2960 * WebView/WebDocumentInternal.h:
2961 * WebView/WebDocumentPrivate.h:
2962 * WebView/WebHTMLView.h:
2963 * WebView/WebPDFView.h:
2964 * WebView/WebScriptDebugDelegatePrivate.h:
2966 2006-06-28 Darin Adler <darin@apple.com>
2970 - fix http://bugs.webkit.org/show_bug.cgi?id=9625
2971 <rdar://problem/4604703>
2972 REGRESSION: Focus not removed from password field after ctrl-click in text field
2974 * WebView/WebHTMLView.m: (-[WebHTMLView menuForEvent:]): Set handlingMouseDownEvent to
2975 YES while calling sendContextMenuEvent: on the bridge.
2977 2006-07-14 Timothy Hatcher <timothy@apple.com>
2981 Moved JavaScriptCore to be a public framework.
2983 * WebKit.xcodeproj/project.pbxproj:
2985 2006-07-13 Mitz Pettel <opendarwin.org@mitzpettel.com>
2989 - fix http://bugs.webkit.org/show_bug.cgi?id=9795
2990 REGRESSION: Crash in [WebHTMLView(WebPrivate)
2991 _updateMouseoverWithEvent:]
2992 and http://bugs.webkit.org/show_bug.cgi?id=9850
2993 REGRESSION: Assertion failure (SHOULD NEVER BE REACHED) in -
2994 [WebHTMLView(WebPrivate) removeTrackingRect:]
2996 * WebView/WebHTMLView.m:
2997 (-[WebHTMLView _updateMouseoverWithEvent:]): Return immediately if
2998 the view has already been closed.
3000 2006-07-13 David Harrison <harrison@apple.com>
3002 Reviewed by Justin and Levi.
3004 <rdar://problem/4620743> REGRESSION: Option-Delete doesn't delete words during typing
3007 editing/deleting/delete-by-word-001.html
3008 editing/deleting/delete-by-word-002.html
3010 * WebView/WebHTMLView.m:
3011 (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:granularity:]):
3013 2006-07-13 Timothy Hatcher <timothy@apple.com>
3015 Rolling out this earlier change (r15378) now that it is fixed on AGL's end.
3016 Fixes <rdar://problem/4624865> Restore 64-bit OpenGL plug-in support once AGL is 64-bit
3018 <rdar://problem/4624858> AGL isn't 64-bit yet; temporarily remove it from WebKit 64-bit build
3020 * Plugins/WebBaseNetscapePluginView.h:
3021 * Plugins/WebBaseNetscapePluginView.m:
3023 2006-07-13 Timothy Hatcher <timothy@apple.com>
3027 <rdar://problem/4616920> REGRESSION: tabbing in mail moves focus
3028 to next control instead of inserting a tab space.
3030 Change editible WebView's tabKeyCyclesThroughElements to NO only
3031 if the setTabKeyCyclesThroughElements SPI wasn't called.
3033 * WebView/WebView.m:
3034 (-[WebView setEditable:]):
3036 2006-07-12 Anders Carlsson <acarlsson@apple.com>
3040 http://bugs.webkit.org/show_bug.cgi?id=9624
3041 REGRESSION: After ctrl-clicking in a EMPTY input or textarea field, the contextual menu shows "Search in Google" and "Search in Spotlight" as active menu items
3043 * DefaultDelegates/WebDefaultContextMenuDelegate.m:
3044 (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
3045 Don't create Dictionary, Spotlight or Google lookup items if there's no selection.
3047 2006-07-12 Mark Rowe <opendarwin.org@bdash.net.nz>
3049 Reviewed by Timothy.
3051 http://bugs.webkit.org/show_bug.cgi?id=9868
3052 Applications shown in Drosera's "Attach" window remain after exit
3054 * DefaultDelegates/WebScriptDebugServer.m:
3055 (-[WebScriptDebugServer init]): Register for NSApplicationWillTerminateNotification so we will
3056 know when the application is being exited.
3057 (-[WebScriptDebugServer dealloc]): Unregister notification before we are deallocated.
3058 (-[WebScriptDebugServer applicationTerminating:]): Inform anyone listening that we are going away.
3060 2006-07-12 Tim Omernick <timo@apple.com>
3062 Reviewed by Tim Hatcher.
3064 <rdar://problem/4624858> AGL isn't 64-bit yet; temporarily remove it from WebKit 64-bit build
3066 Also, fixed a LOG_ERROR() so that it uses the CGL error instead of the AGL error; Tim H missed this in his build fix
3069 * Plugins/WebBaseNetscapePluginView.h:
3070 * Plugins/WebBaseNetscapePluginView.m:
3072 2006-07-11 John Sullivan <sullivan@apple.com>
3074 Reviewed by Kevin and Tim O
3076 - added support for creating a selection image with white text
3078 * WebView/WebDocumentPrivate.h:
3079 added -selectionImageForcingWhiteText: and -selectionImageRect to the private
3080 <WebDocumentSelection> protocol
3082 * Misc/WebSearchableTextView.m:
3083 (-[NSString selectionImageForcingWhiteText:]):
3084 added stub for this new method to this obsolete class to satisfy the compiler
3085 (-[NSString selectionImageRect]):
3088 * WebView/WebHTMLView.m:
3089 (-[WebHTMLView _selectionDraggingImage]):
3090 now calls -selectionImageForcingWhiteText:NO instead of just -selectionImage
3091 (-[WebHTMLView _selectionDraggingRect]):
3092 now calls selectionImageRect, to which the implementation moved
3093 (-[WebHTMLView selectionImageForcingWhiteText:]):
3094 implemented this new method by calling through to new bridge method selectionImageForcingWhiteText:
3095 (-[WebHTMLView selectionImageRect]):
3096 implemented this new method by using existing _selectionDraggingRect implementation
3098 * WebView/WebPDFView.m:
3099 (-[WebPDFView selectionImageForcingWhiteText:]):
3100 implemented by using code that was formerly in Safari
3101 (-[WebPDFView selectionImageRect]):
3102 implemented by returning selectionRect
3104 2006-07-11 Tim Omernick <timo@apple.com>
3108 <http://bugs.webkit.org/show_bug.cgi?id=9843>:
3109 Give Netscape plug-ins access to their own DOM element
3111 * Plugins/WebBaseNetscapePluginView.h:
3112 * Plugins/WebBaseNetscapePluginView.m:
3113 (-[WebBaseNetscapePluginView dealloc]):
3114 Release DOM element.
3115 (-[WebBaseNetscapePluginView getVariable:value:]):
3116 Return NPObject for plugin DOM element.
3118 * Plugins/WebNetscapePluginEmbeddedView.h:
3119 * Plugins/WebNetscapePluginEmbeddedView.m:
3120 (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):
3121 Now takes a DOMElement, in much the same way that WebKit plug-in views take a DOMElement.
3123 * WebCoreSupport/WebFrameBridge.m:
3124 (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
3125 Pass DOMElement to Netscape plug-ins.
3126 (-[WebFrameBridge viewForJavaAppletWithFrame:attributeNames:attributeValues:baseURL:DOMElement:]):
3129 2006-07-11 Justin Garcia <justin.garcia@apple.com>
3131 Reviewed by levi & thatcher
3133 <http://bugs.webkit.org/show_bug.cgi?id=9642>
3134 GMail Editor: Operations that use drop down menus blow away the selection
3136 * WebView/WebHTMLView.m:
3137 (-[WebHTMLView maintainsInactiveSelection]): Maintain an inactive selection
3138 when resigning as first responder if the selection is editable
3139 or if the WebView tells us to.
3140 * WebView/WebView.m:
3141 (-[WebView maintainsInactiveSelection]): Just because a WebView is
3142 editable doesn't mean selections inside subframes will be. Return
3145 2006-07-11 Tim Omernick <timo@apple.com>
3147 Reviewed by Tim Hatcher.
3149 <rdar://problem/4622748> WebKit now uses deprecated AGL functions
3151 * Plugins/WebBaseNetscapePluginView.m:
3152 (-[WebBaseNetscapePluginView _createWindowedAGLContext]):
3153 aglSetDrawable() is deprecated in AGL 3.0. Use aglSetWindowRef() instead.
3154 (-[WebBaseNetscapePluginView _createWindowlessAGLContext]):
3155 aglSetOffScreen() is deprecated in AGL 3.0. Use CGLSetOffScreen(), which does the same thing.
3157 2006-07-11 Alexey Proskuryakov <ap@nypop.com>
3161 - http://bugs.webkit.org/show_bug.cgi?id=7808
3162 Assertion failure in -[WebBaseNetscapePluginStream dealloc] when requesting an invalid URL
3164 * Plugins/WebNetscapePluginStream.m:
3165 (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]):
3166 Remove the early return when requesting an invalid (unsupported) URL.
3168 === Safari-521.16 ===
3170 2006-07-10 Mitz Pettel <opendarwin.org@mitzpettel.com>
3172 Reviewed by John Sullivan.
3174 - fix <rdar://problem/4621541>, aka <http://bugs.webkit.org/show_bug.cgi?id=9838>
3175 REGRESSION (r14968-r14977): View Source doesn't work for pages from the back/forward cache
3177 * WebView/WebDataSource.m:
3178 (-[WebDataSource _setPrimaryLoadComplete:]): Set our data only if the frame loader is
3179 has just loaded it (when coming from the back/forward cache, it hasn't).
3181 2006-07-10 Brady Eidson <beidson@apple.com>
3185 Resolved the console error messages people got from the new DB even if they didn't have it enabled
3187 * Misc/WebIconDatabase.m:
3188 (-[WebIconDatabase init]):
3189 Disabled initializing the IconDatabaseBridge if user is living on the old DB
3191 2006-07-10 Darin Adler <darin@apple.com>
3193 - try to fix Windows build
3195 * COM/WebFrame.h: Qualify DeprecatedString and KURL with WebCore:: prefixes.
3197 2006-07-09 Darin Adler <darin@apple.com>
3199 - try to fix Windows build
3201 * COM/WebFrame.cpp: Rename QChar to DeprecatedChar.
3203 2006-07-09 Darin Adler <darin@apple.com>
3205 - fix newlines to be consistent for all files in the COM directory
3206 (many had mixed style) and set the EOL style to "native" on them.
3208 * COM/*: Set properties and changed files.
3210 2006-07-09 Tim Omernick <timo@apple.com>
3214 <rdar://problem/4404652> Netscape plug-in mouse events broken in HiDPI
3216 Multiply global mouse coordinates by the window scale factor so that plug-ins can use GlobalToLocal() in HiDPI.
3217 This fixes many bugs involving plug-in mouse event handling in HiDPI. Most notably, the Flash player will now
3218 correctly respond to clicks.
3220 * Plugins/WebBaseNetscapePluginView.m:
3221 (+[WebBaseNetscapePluginView getCarbonEvent:]):
3222 (-[WebBaseNetscapePluginView getCarbonEvent:withEvent:]):
3224 2006-07-09 Darin Adler <darin@apple.com>
3226 Reviewed by Tim Hatcher.
3228 - fix assertion firing in plug-in layout tests
3230 * Plugins/WebBaseNetscapePluginView.m:
3231 (-[WebBaseNetscapePluginView restartNullEvents]):
3232 Don't start null events if the plug-in is not in the
3233 started state. This happens when the plug-in moves within
3234 its view hierarchy after it has been stopped.
3236 2006-07-09 Timothy Hatcher <timothy@apple.com>
3240 Bug 9820: Move new DOM API that has been through API review to public headers
3241 http://bugs.webkit.org/show_bug.cgi?id=9820
3243 * Misc/WebElementDictionary.m: include DOMExtensions.h
3244 * Misc/WebNSViewExtras.m: include DOMExtensions.h
3245 * WebKit.xcodeproj/project.pbxproj: make DOMXPath.h public
3247 2006-07-09 Timothy Hatcher <timothy@apple.com>
3251 Bug 9818: move new UIDelegate API that has been through API review to public headers
3252 http://bugs.webkit.org/show_bug.cgi?id=9818
3254 <rdar://problem/4387541> API: Remove webView:setContentRect: & webViewContentRect: delegate methods?
3255 The fix for 4310363 removed the only use of webViewContentRect: in our code. webView:setContentRect:
3256 was never used to begin with. There's no harm in leaving these around in the API, but they'll cruft it up.
3258 Also removes the never used webViewPrint: SPI that was replaced by webView:printFrameView:.
3260 * DefaultDelegates/WebDefaultUIDelegate.m:
3261 * WebCoreSupport/WebFrameBridge.m:
3262 (-[WebFrameBridge print]):
3263 * WebView/WebFrameView.h:
3264 * WebView/WebFrameView.m:
3265 * WebView/WebFrameViewPrivate.h:
3266 * WebView/WebUIDelegate.h:
3267 * WebView/WebUIDelegatePrivate.h:
3269 2006-07-09 Timothy Hatcher <timothy@apple.com>
3273 Bug 9814: Move new WebView API that has been through API review to public headers
3274 http://bugs.webkit.org/show_bug.cgi?id=9814
3276 * WebView/WebView.h:
3277 * WebView/WebView.m:
3279 (-[WebView setShouldCloseWithWindow:]):
3280 (-[WebView shouldCloseWithWindow]):
3281 (-[WebView selectedFrame]):
3282 (-[WebView setMainFrameURL:]):
3283 (-[WebView mainFrameURL]):
3284 (-[WebView isLoading]):
3285 (-[WebView mainFrameTitle]):
3286 (-[WebView mainFrameIcon]):
3287 (-[WebView mainFrameDocument]):
3288 (-[WebView setDrawsBackground:]):
3289 (-[WebView drawsBackground]):
3290 (-[WebView toggleSmartInsertDelete:]):
3291 (-[WebView toggleContinuousSpellChecking:]):
3292 (-[WebView canMakeTextStandardSize]):
3293 (-[WebView makeTextStandardSize:]):
3294 (-[WebView maintainsInactiveSelection]):
3295 * WebView/WebViewPrivate.h:
3297 2006-07-09 Timothy Hatcher <timothy@apple.com>
3301 Bug 9487: The XPath section should be removed and/or moved.
3302 http://bugs.webkit.org/show_bug.cgi?id=9487
3304 * WebInspector/webInspector/inspector.css:
3305 * WebInspector/webInspector/inspector.html:
3306 * WebInspector/webInspector/inspector.js:
3308 2006-07-09 Anders Carlsson <acarlsson@apple.com>
3312 * WebCoreSupport/WebSystemInterface.m:
3313 (InitWebCoreSystemInterface):
3314 Initialize wkPathFromFont.
3316 2006-07-09 Darin Adler <darin@apple.com>
3320 * Plugins/WebBaseNetscapePluginView.m:
3321 (-[WebBaseNetscapePluginView restorePortState:]): Cast inside the assertion so
3322 that we don't have an unused variable in versions with assertions disabled.
3323 The alternative would be to wrap the whole thing in an #if statement.
3325 2006-07-08 Tim Omernick <timo@apple.com>
3327 Reviewed by John Sullivan.
3329 * Plugins/WebBaseNetscapePluginView.h:
3330 - Added ivars for OpenGL support. Someday it would be nice to refactor this class so
3331 that each drawing model is encapsulated in a class; this would allow
3332 WebBaseNetscapePluginView to make more efficient use of space, for example by not
3333 keeping OpenGL-related ivars for Quickdraw plug-ins.
3335 * Plugins/WebBaseNetscapePluginView.m:
3336 - Declared a bunch of internal methods for OpenGL support (see below).
3337 - Removed "forUpdate" from CoreGraphics port state struct; it was always set to "YES",
3338 so I just cleaned up the silly code that used it.
3339 - Declared OpenGL port state struct.
3340 (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3341 - Moved a CoreGraphics-related assertion down to the big "switch" statement.
3342 - Don't set window.type here -- according to the Netscape Plug-in API docs, the plug-in
3343 should default to "windowed" mode, and may call NPN_SetValue() during its NPN_New() to
3344 request that the browser use a "windowless" (offscreen) context instead.
3345 - Moved the assertion from the top of this method here; removed a less restrictive
3346 assertion that is now obsolete.
3347 - Removed "forUpdate" flag from CoreGraphics port state struct.
3348 - Fill in OpenGL port state struct. Set up the viewport appropriately for both windowed
3349 and windowless OpenGL plug-ins. Windowed plug-ins need to have their GL viewport
3350 transformed by the amount the plug-in is clipped; windowless plug-ins are drawn off-screen
3351 into a surface whose geometry is never changed or clipped, so they may always draw with
3352 a viewport origin of (0, 0).
3353 (-[WebBaseNetscapePluginView restorePortState:]):
3354 - Removed "forUpdate" flag from CoreGraphics port state struct.
3355 - Restore the old OpenGL context saved by -saveAndSetNewPortStateForUpdate:.
3356 (-[WebBaseNetscapePluginView sendEvent:]):
3357 - Updated an assertion to also include OpenGL. To ensure that attached plug-in window movements
3358 happen atomically with web page redisplays, we assert that the plug-in's window is set only while
3359 the plug-in view is redrawing.
3360 - Same deal as with the assertion; only save/set port state when redrawing the plug-in view. Plug-ins
3361 that use the new drawing models are only allowed to draw when the web page draws. I might consider
3362 changing this for windowed OpenGL plug-ins, since they always obscure the page content anyway.
3363 (-[WebBaseNetscapePluginView isNewWindowEqualToOldWindow]):
3364 - Compare new NP_GLContext structs.
3365 (-[WebBaseNetscapePluginView updateAndSetWindow]):
3366 - In OpenGL mode, can only set window when updating plug-in view.
3367 (-[WebBaseNetscapePluginView setWindowIfNecessary]):
3369 - Updated logging for OpenGL drawing mode.
3370 (-[WebBaseNetscapePluginView addWindowObservers]):
3371 - No need to observe frame/bounds change notifications for this and all parent views. See -renewGState
3373 (-[WebBaseNetscapePluginView removeWindowObservers]):
3374 - Don't need to remove frame/bounds observers anymore.
3375 (-[WebBaseNetscapePluginView start]):
3376 - Plug-ins are "windowed" by default. This is not a change from our previous behavior, but this is a
3377 better place to set the default value as it allows the plug-in to override it later.
3378 (-[WebBaseNetscapePluginView stop]):
3379 - Destroy AGL context when the plug-in stops.
3380 (-[WebBaseNetscapePluginView dealloc]):
3381 - Assert that the AGL stuff has been cleaned up.
3382 (-[WebBaseNetscapePluginView drawRect:]):
3383 - If this is a windowless OpenGL plugin, blit its contents back into this view.
3384 (-[WebBaseNetscapePluginView renewGState]):
3385 - This method is called when the view or one of its parents is moved or resized (see comments).
3386 (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
3387 - Hide the AGL window if the plug-in view is about to be removed from its window.
3388 (-[WebBaseNetscapePluginView viewHasMoved:]):
3389 - Renamed and moved to the "Internal" category.
3390 (-[WebBaseNetscapePluginView invalidateRegion:]):
3392 - Add support for OpenGL (uses the same region type as CoreGraphics).
3393 (-[WebBaseNetscapePluginView getVariable:value:]):
3395 - Implemented NPNVsupportsOpenGLBool; returns YES since we now support the OpenGL drawing model.
3396 (-[WebBaseNetscapePluginView setVariable:value:]):
3397 - Implemented NPPVpluginWindowBool, which allows plug-ins to specify whether they should be rendered in
3398 "windowed" or "windowless" mode. This is an older part of the Netscape Plug-in API that was never
3399 implemented in WebKit. "Windowed" Quickdraw plug-ins do not actually reside in a separate window, and
3400 can already do many of the same things (such as transparency) that only "windowless" plug-ins can do on
3401 other platforms. However, we need the "windowed" vs. "windowless" distinction for OpenGL plug-ins so
3402 that they have some way of specifying whether they should be rendered on an accelerated overlay surface,
3403 composited into the browser window.
3404 - Support for setting the drawing model to OpenGL.
3405 (-[WebBaseNetscapePluginView _viewHasMoved]):
3406 - Renamed from -viewHasMoved:, and moved down in the file.
3407 - None of this work is necessary when the plug-in is not in a window; the plug-in's state will be properly
3408 restored when it is moved back into a window.
3409 - Reshape OpenGL surface window here.
3410 (-[WebBaseNetscapePluginView _createAGLContextIfNeeded]):
3411 - Creates the AGL context of the appropriate type (windowed/windowless).
3412 (-[WebBaseNetscapePluginView _createWindowedAGLContext]):
3413 - Creates a windowed AGL context, which is an AGL context attached to a child window. This is the only way
3414 to get true hardware acceleration.
3415 (-[WebBaseNetscapePluginView _createWindowlessAGLContext]):
3416 - Creates a windowless AGL context, which is an AGL context attached to an offscreen buffer. This buffer can
3417 then be blitted back into the browser window with a different alpha, or scaled, or whatever.
3418 (-[WebBaseNetscapePluginView _cglContext]):
3419 - Returns the underlying CGL context from the AGL context. We give the plug-in access to the CGL context because
3420 CGL is the more primitive of the GL drawable APIs and allows for finer control over the context.
3421 (-[WebBaseNetscapePluginView _getAGLOffscreenBuffer:width:height:]):
3422 - Returns the buffer allocated for the offscreen AGL context, if there is one.
3423 (-[WebBaseNetscapePluginView _destroyAGLContext]):
3424 - Destroys the AGL context, as well as the associated offscreen buffer or child window.
3425 (-[WebBaseNetscapePluginView _reshapeAGLWindow]):
3426 - Positions the AGL window over the browser window.
3427 (-[WebBaseNetscapePluginView _hideAGLWindow]):
3428 - Hides the AGL window.
3429 (-[WebBaseNetscapePluginView _aglOffscreenImageForDrawingInRect:]):
3430 - Returns an NSImage representation of the offscreen AGL context's framebuffer. This is used to draw the offscreen
3431 bits back into the plug-in view. This is kind of tricky because it has to convert the offscreen buffer in-place
3432 from BGRA to RGBA so that it can be wrapped in an NSBitmapImageRep. See comments.
3434 * WebKit.xcodeproj/project.pbxproj:
3435 Link OpenGL and AGL.
3437 2006-07-09 Brady Eidson <beidson@apple.com>
3441 The ICONDEBUG flag now chooses either the new icon database or the old one
3442 No longer any need to live side by side to compare results
3444 * Misc/WebIconDatabase.m:
3445 (-[NSMutableDictionary iconURLForURL:]):
3446 (-[NSMutableDictionary retainIconForURL:]):
3447 (-[NSMutableDictionary releaseIconForURL:]):
3448 (-[WebIconDatabase _setHaveNoIconForIconURL:]):
3449 (-[WebIconDatabase _setIconURL:forURL:]):
3450 (-[WebIconDatabase _resetCachedWebPreferences:]):
3452 2006-07-08 Timothy Hatcher <timothy@apple.com>
3456 Bug 5312: comments aren't available via DOM
3457 http://bugs.webkit.org/show_bug.cgi?id=5312
3459 Makes the Web Inspector show comment node contents.
3461 * WebInspector/WebInspector.m:
3462 (-[DOMNode _displayName]): return the contents of the comment
3463 * WebInspector/webInspector/inspector.js: check for comment nodes
3465 2006-07-09 Alexey Proskuryakov <ap@nypop.com>
3469 - http://bugs.webkit.org/show_bug.cgi?id=9572
3470 Add application/xhtml+xml to the Accept header
3472 * WebView/WebFrame.m:
3473 (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): Add an Accept header
3474 to main resource requests.
3475 * English.lproj/StringsNotToBeLocalized.txt: Added new strings.
3477 2006-07-08 Darin Adler <darin@apple.com>
3479 * DefaultDelegates/WebDefaultContextMenuDelegate.m:
3480 (-[WebDefaultUIDelegate contextMenuItemsForElement:defaultMenuItems:]):
3481 Removed misleading old comment.
3483 === Safari-521.15 ===
3485 2006-07-07 Levi Weintraub <lweintraub@apple.com>
3489 Finished moving deletion selection expansion across the bridge... say that 3 times fast.
3491 * WebView/WebHTMLView.m: Pass granularity to WebCore to handle expansion
3492 (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:granularity:]):
3493 (-[WebHTMLView _deleteSelection]):
3494 (-[WebHTMLView _deleteWithDirection:granularity:killRing:isTypingAction:]):
3495 (-[WebHTMLView deleteToMark:]):
3497 2006-07-07 Brady Eidson <beidson@apple.com>
3501 Changed an ASSERT to a LOG_ERROR for an error that could be handled gracefully, but
3502 whose assertion was reproducibly causing a build bot failure
3504 * Misc/WebIconDatabase.m:
3505 (-[WebIconDatabase _releaseIconForIconURLString:]):
3507 2006-07-06 Levi Weintraub <lweintraub@apple.com>
3511 Improved table editing
3513 * WebCoreSupport/WebFrameBridge.m: Added method to allow WebCore to trigger
3514 deletion editing delegate
3515 (-[WebFrameBridge shouldDeleteSelectedDOMRange:]):
3516 * WebView/WebHTMLView.m: Moved code that expanded a selection when the delete
3517 key is pressed over to WebCore so we can be more intelligent about how to handle it
3518 (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:]):
3519 (-[WebHTMLView _deleteWithDirection:granularity:killRing:isTypingAction:]):
3521 2006-07-07 John Sullivan <sullivan@apple.com>
3523 Reviewed by Tim Hatcher
3525 - fixed <rdar://problem/4606857> WebKit: WebPreferencesChangedNotification not exported
3528 added surprisingly missing _WebPreferencesChangedNotification, defined in
3531 2006-07-06 Brady Eidson <beidson@apple.com>
3535 Small fix to my previous small fix that only lets the ASSERT off the hook if the DB
3538 * Misc/WebIconDatabase.m:
3539 (-[WebIconDatabase _releaseIconForIconURLString:]):
3541 2006-07-05 Brady Eidson <beidson@apple.com>
3545 Small fix that prevents an assertion from triggering if the DB is being cleaned up
3546 (ie, the app being shut down)
3548 * Misc/WebIconDatabase.h: