794e80bf8216528e0265aaaae6ff79674ed53b8e
[WebKit-https.git] / WebKit / ChangeLog
1 2006-11-30  Geoffrey Garen  <ggaren@apple.com>
2
3         Rubber Stamped by Anders Carlsson.
4
5         Global rename of Document::focusNode to Document::focusedNode. 'focusNode'
6         suggested a command, and conflicted with a different meaning for 'focusNode'
7         in the Mozilla selection API.
8
9         * WebView/WebHTMLView.m:
10         (-[NSArray clearFocus]):
11
12 2006-11-30  Matt Lilek  <pewtermoose@gmail.com>
13
14         Reviewed by Mitz.
15
16         Bug 10698: Scroll wheel causes inspector to shift up
17         http://bugs.webkit.org/show_bug.cgi?id=10698
18
19         Remove size attribute from the tree popup as a workaround for
20         http://bugs.webkit.org/show_bug.cgi?id=11362 Bug 11362: Native popup with size="1" wraps options
21
22         * WebInspector/webInspector/inspector.css:
23         * WebInspector/webInspector/inspector.html:
24
25 2006-11-30  Matt Lilek  <pewtermoose@gmail.com>
26
27         Reviewed by Tim H.
28
29         Move web inspector style markup to javascript to fix http://bugs.webkit.org/show_bug.cgi?id=6724
30         Bug 6724: Text copied from Web Inspector is different from actual text
31
32         * WebInspector/webInspector/inspector.css:
33         * WebInspector/webInspector/inspector.js:
34
35 2006-11-30  Adam Roben  <aroben@apple.com>
36
37         Reviewed by Beth.
38
39         Put code in place to use WebCore context menus when they are turned
40         on.
41
42         * WebView/WebHTMLView.m:
43         (-[NSArray menuForEvent:]):
44
45 2006-11-29  Timothy Hatcher  <timothy@apple.com>
46
47         Reviewed by Oliver.
48
49         Keep preferences separate from the rest of the client, making sure we are using expected preference values.
50         This lets the inspector work when plugins are disabled for the WebView.
51
52         * WebInspector/WebInspector.m:
53         (-[NSWindow window]):
54
55 2006-11-29  Anders Carlsson  <acarlsson@apple.com>
56
57         Reviewed by Tim.
58
59         Add back methods in WebCoreStatistics that are still used by Tiger Safari.
60         
61         * Misc/WebCoreStatistics.h:
62         * Misc/WebCoreStatistics.m:
63         (+[WebCoreStatistics emptyCache]):
64         (+[WebCoreStatistics setCacheDisabled:]):
65
66 2006-11-28  Alice Liu  <alice.liu@apple.com>
67
68         Reviewed by Maciej.
69
70         A fix for a couple failing layout tests involving copy/cut in iframes.
71
72         * WebCoreSupport/WebEditorClient.h:
73         * WebCoreSupport/WebEditorClient.mm:
74         (WebEditorClient::dataForArchivedSelection):
75         Use the frame parameter instead of using the webview's selectedFrame. 
76
77 2006-11-28  Beth Dakin  <bdakin@apple.com>
78
79         Reviewed by Geoffff.
80
81         Fix for http://bugs.webkit.org/show_bug.cgi?id=11691 REGRESSION 
82         (r17399, r17511): WebElementDictionary no longer returns nil 
83         NSStrings
84
85         String's NSString* operator converts null Strings to empty 
86         NSStrings for compatibility with AppKit. We need to work around 
87         that here.
88
89         * Misc/WebElementDictionary.m:
90         (NSStringOrNil):
91         (-[WebElementDictionary _altDisplayString]):
92         (-[WebElementDictionary _spellingToolTip]):
93         (-[WebElementDictionary _title]):
94         (-[WebElementDictionary _titleDisplayString]):
95         (-[WebElementDictionary _textContent]):
96
97 2006-11-28  Geoffrey Garen  <ggaren@apple.com>
98
99         Reviewed by Beth Dakin.
100
101         Fixed <rdar://problem/4844855> Should clarify when to create clients in 
102         the WebCore client API
103         
104         All clients must now be supplied as constructor arguments. This clarifies 
105         when you need to create clients, and also guarantees that objects can't 
106         (for the most part) be in a clientless state.
107
108         Layout tests pass. No leaks reported.
109         
110         * WebCoreSupport/WebFrameBridge.mm: Shuffled around initialization and changed
111         some arguments to resolve ciruclar dependencies at init time.
112         (-[WebFrame _initWithWebFrameView:webView:bridge:]): We no longer call setClient
113         here, because the client is set up at construction time.
114
115 2006-11-28  Anders Carlsson  <acarlsson@apple.com>
116
117         Reviewed by Maciej.
118
119         Update for changes to ResourceRequest.
120         
121         * WebCoreSupport/WebChromeClient.mm:
122         (WebChromeClient::createWindow):
123         (WebChromeClient::createModalDialog):
124         * WebCoreSupport/WebFrameLoaderClient.mm:
125         (WebFrameLoaderClient::canHandleRequest):
126
127 2006-11-28  Adam Roben  <aroben@apple.com>
128
129         Reviewed by Beth.
130
131         More WebCore context menu work.
132
133         * DefaultDelegates/WebDefaultUIDelegate.m: New stub delegate method implementation.
134         (-[NSApplication webView:contextMenuItemSelected:forElement:]):
135         * WebCoreSupport/WebContextMenuClient.h: Updated to match ContextMenuClient.h changes.
136         * WebCoreSupport/WebContextMenuClient.mm:
137         (WebContextMenuClient::addCustomContextMenuItems): Updated for method name changes.
138         (WebContextMenuClient::contextMenuItemSelected): Added new client method.
139         * WebView/WebUIDelegatePrivate.h: New private delegate method declaration.
140
141 2006-11-28  Alice Liu  <alice.liu@apple.com>
142
143         Reviewed by Justin and Adam.
144
145         * WebCoreSupport/WebEditorClient.h:
146         * WebCoreSupport/WebEditorClient.mm:
147         added the following        
148         (WebEditorClient::smartInsertDeleteEnabled):
149         (WebEditorClient::dataForArchivedSelectionInFrame):
150         (WebEditorClient::_web_userVisibleString):
151         (WebEditorClient::shouldInsertNode):
152         
153         * WebKitPrefix.h:
154         Added flags to control whether WebCore cut/copy/paste is enabled.
155         Turned on Cut and Copy, left Paste and Delete off
156         
157         * WebView/WebHTMLViewPrivate.h:
158         * WebView/WebHTMLView.m:
159         removed _can[Cut|Copy|Paste|Delete]
160         (-[NSArray validateUserInterfaceItem:]):
161         call the editor for canDHTML[C|C|P|D] and _can[C|C|P|D] instead 
162         (-[NSArray delete:]):
163         added code to call the editor's delete instead (not turned on)
164         (-[WebHTMLView copy:]):
165         added code to call the editor's copy (turned on)
166         (-[WebHTMLView cut:]):
167         added code to call the editor's cut (turned on)
168         (-[WebHTMLView paste:]):
169         added code to call the editor's paste (not turned on)
170
171 2006-11-28  Geoffrey Garen  <ggaren@apple.com>
172
173         Reviewed by Adam.
174
175         Fixed <rdar://problem/4844848> REGRESSION: extra cross-library ref/deref 
176         calls cause .5% PLT regression.
177         
178         Changed ref/deref calls to a single 'xxxDestroyed' call. Moved EditorClient
179         from the Frame to the Page, since it's only responsible for
180         Webview-level delegate calls.
181         
182         I don't really love this design, but it fixes the regression and allows
183         a single WebKit object to implement multiple client interfaces.
184         
185         Layout tests pass.
186
187 2006-11-27  Beth Dakin  <bdakin@apple.com>
188
189         Reviewed by Adam.
190
191         WebKit half of getting rid of the FixMes in ContextMenu.cpp
192
193         * WebCoreSupport/WebFrameLoaderClient.h: canHandleRequest takes a 
194         ResourceRequest now.
195         * WebCoreSupport/WebFrameLoaderClient.mm:
196         (WebFrameLoaderClient::canHandleRequest): Same.
197         * WebView/WebHTMLView.m:
198         (-[WebHTMLView _isSelectionMisspelled]): Call into WebCore.
199
200 2006-11-27  Ada Chan  <adachan@apple.com>
201
202         Reviewed by Adam.
203
204         Part of the change to move WebCoreCache into WebKit:
205         Added WebCache which handles emptying and enable/disabling the cache.
206         emptyCache and setCacheDisabled have been removed from WebCoreStatistics.
207
208         * Misc/WebCache.h: Added.
209         * Misc/WebCache.mm: Added.
210         * Misc/WebCoreStatistics.h:
211         * Misc/WebCoreStatistics.m:
212         (+[WebCoreStatistics statistics]):
213         * WebKit.exp:
214         * WebKit.xcodeproj/project.pbxproj:
215
216 2006-11-27  Anders Carlsson  <acarlsson@apple.com>
217
218         Reviewed by Adam.
219
220         Move addMessageToConsole to Chrome.
221
222         * WebCoreSupport/WebChromeClient.h:
223         * WebCoreSupport/WebChromeClient.mm:
224         (WebChromeClient::addMessageToConsole):
225         * WebCoreSupport/WebFrameBridge.mm:
226
227 2006-11-27  Brady Eidson  <beidson@apple.com>
228
229         Reviewed by Anders
230
231         Moved unused Private SPI to Internal and pruned other unused code
232
233         * Misc/WebIconDatabase.m:
234         * Misc/WebIconDatabasePrivate.h:
235
236 2006-11-21  Darin Adler  <darin@apple.com>
237
238         Reviewed by Maciej.
239
240         - make the close method do a more-complete job to prevent world leaks seen when
241           running some of the layout tests
242
243         * WebView/WebHTMLViewInternal.h: Added declaration of -[WebHTMLViewPrivate clear].
244         * WebView/WebHTMLView.m:
245         (-[WebHTMLViewPrivate clear]): Added method to drop references to other objects.
246         We want to do this at "close" time, rather than waiting for deallocation time.
247         This is especially important for the data source, which indirectly keeps a number of
248         objects alive.
249         (-[WebHTMLView close]): Added an explicit call to clear out the data source on the
250         plug-in controller. Without this, we'd see the plug-in controller making calls to
251         a deallocated data source during the layout tests. Added a call to the new clear method
252         on the private object so that we release the objects at close time instead of waiting
253         for deallocation time.
254
255         * WebKit.xcodeproj/project.pbxproj: Let Xcode have its way with the project file,
256         because I can't fight the power.
257
258 2006-11-20  Samuel Weinig  <sam@webkit.org>
259
260         Reviewed by Alexey.
261
262         Fix for http://bugs.webkit.org/show_bug.cgi?id=11656
263         Fix Windows build
264
265         * WebKit.vcproj/WebKit.vcproj: don't include directories that no
266         longer exist.
267
268 2006-11-19  Beth Dakin  <bdakin@apple.com>
269
270         Reviewed by Adam.
271
272         WebKit side of new context menu actions.
273
274         * WebCoreSupport/WebContextMenuClient.h: These are for the 
275         currently-WebKit-dependent menu actions.
276         * WebCoreSupport/WebContextMenuClient.mm:
277         (WebContextMenuClient::copyLinkToClipboard):
278         (WebContextMenuClient::downloadURL):
279         (WebContextMenuClient::copyImageToClipboard):
280         (WebContextMenuClient::searchWithSpotlight):
281         (WebContextMenuClient::lookUpInDictionary):
282         * WebCoreSupport/WebEditorClient.h:
283         * WebCoreSupport/WebEditorClient.mm:
284         (core): These are to convert between WebViewInsertAction and 
285         EditorInsertAction.
286         (kit):
287         (WebEditorClient::shouldInsertText): Added implementation for 
288         shouldInsertText.
289         * WebKit.xcodeproj/project.pbxproj:
290         * WebView/WebHTMLView.m:
291         (-[WebHTMLView _lookUpInDictionaryFromMenu:]): Moved 
292         _lookUpInDictionary to be within the implementation of WebHTMLView 
293         internal.
294         * WebView/WebHTMLViewInternal.h: Add _lookUpInDictionaryFromMenu
295         * WebView/WebViewInternal.h: Add _searchWithSpotlightFromMenu
296
297 2006-11-18  Don Gibson  <dgibson77@gmail.com>
298
299         Reviewed by Sam Weinig.
300
301         http://bugs.webkit.org/show_bug.cgi?id=11634:
302         Fix segfault on startup for Windows build.  Also fix segfault when
303         typing in a URL.
304
305         * COM/WebFrame.cpp:
306         (WebFrame::initWithName):
307
308 === Safari-521.31 ===
309
310 2006-11-17  Timothy Hatcher  <timothy@apple.com>
311
312         Reviewed by Geoff.
313
314         <rdar://problem/4841044> Temporarily default Mail.app editable link clicking behavior, until they do it themselves
315
316         * WebKit.xcodeproj/project.pbxproj:
317         * WebView/WebView.mm:
318         (+[WebView initialize]):
319         (-[WebView setPreferences:]):
320
321 2006-11-16  Don Gibson  <dgibson77@gmail.com>
322
323         Reviewed and landed by ap.
324
325         http://bugs.webkit.org/show_bug.cgi?id=11509:
326         Windows build bustage.
327
328         * COM/WebFrame.cpp:
329         (WebFrame::initWithName):
330         (WebFrame::loadHTMLString):
331         (WebFrame::stopLoading):
332         (WebFrame::reload):
333         (WebFrame::loadDataSource):
334         (WebFrame::didReceiveData):
335         (WebFrame::receivedResponse):
336         (WebFrame::receivedAllData):
337         * COM/WebFrame.h:
338         * COM/WebView.cpp:
339         (WebView::mouseMoved):
340         (WebView::mouseDown):
341         (WebView::mouseUp):
342         (WebView::mouseDoubleClick):
343         * WebKit.vcproj/WebKit.vcproj:
344
345 2006-11-16  Anders Carlsson  <acarlsson@apple.com>
346
347         Reviewed by Tim.
348
349         <rdar://problem/4841123>
350         REGRESSION: Crash in WebCore::Range::boundaryPointsValid when replying to a mail Message
351         
352         * Misc/WebNSAttributedStringExtras.m:
353         (+[NSAttributedString _web_attributedStringFromRange:]):
354         If the range passed in is null, return null. When this function was in the bridge, it would never get called
355         with a null range when nothing was selected. Instead, the range would just have invalid boundary points.
356
357 2006-11-15  Adam Roben  <aroben@apple.com>
358
359         Reviewed by Anders.
360
361         Added new WebContextMenuClient class to act as WebCore's ChromeClient,
362         and moved context menu-related code there from WebChromeClient.
363
364         * WebCoreSupport/WebChromeClient.h:
365         * WebCoreSupport/WebChromeClient.mm:
366         * WebCoreSupport/WebContextMenuClient.h: Added.
367         (WebContextMenuClient::webView):
368         * WebCoreSupport/WebContextMenuClient.mm: Added.
369         (WebContextMenuClient::create):
370         (WebContextMenuClient::WebContextMenuClient):
371         (WebContextMenuClient::ref):
372         (WebContextMenuClient::deref):
373         (WebContextMenuClient::addCustomContextMenuItems):
374         * WebKit.xcodeproj/project.pbxproj: Added new files.
375         * WebView/WebView.mm:
376         (-[WebView _commonInitializationWithFrameName:groupName:]):
377
378 2006-11-15  Beth Dakin  <bdakin@apple.com>
379         &   Adam Roben  <aroben@apple.com>
380
381         Reviewed by Adam & Beth.
382
383         WebKit side of first cut at engine context menus. Use the client to 
384         call into the UIDelegate.
385
386         * WebCoreSupport/WebChromeClient.h:
387         * WebCoreSupport/WebChromeClient.mm:
388         (WebChromeClient::addCustomContextMenuItems):
389         * WebKit.xcodeproj/project.pbxproj:
390
391 2006-11-15  Brady Eidson  <beidson@apple.com>
392
393         Reviewed by Maciej
394
395         Quick change of files to ObjC++ for BF cache re-write
396
397         * History/WebBackForwardList.m: Removed.
398         * History/WebBackForwardList.mm: Added.
399         * History/WebHistoryItem.m: Removed.
400         * History/WebHistoryItem.mm: Added.
401         * WebKit.xcodeproj/project.pbxproj:
402
403 2006-11-15  Brady Eidson  <beidson@apple.com>
404
405         Reviewed by Sarge
406
407         SPI addition
408
409         * WebView/WebFrame.mm:
410         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
411         * WebView/WebFrameInternal.h:
412         * WebView/WebFramePrivate.h:
413
414 2006-11-15  Brady Eidson  <beidson@apple.com>
415
416         Reviewed by Adele
417
418         <rdar://problem/4838729> - Replace mistakenly removed SPI
419
420         * WebView/WebHTMLView.m:
421         (-[WebHTMLView _handleAutoscrollForMouseDragged:]):
422         * WebView/WebHTMLViewPrivate.h:
423
424 2006-11-15  Anders Carlsson  <acarlsson@apple.com>
425
426         Reviewed by Adele.
427
428         isTargetItem is used by DRT, so make it private instead of internal.
429         
430         * History/WebHistoryItem.m:
431         (-[WebHistoryItem isTargetItem]):
432         * History/WebHistoryItemInternal.h:
433         * History/WebHistoryItemPrivate.h:
434         * WebCoreSupport/WebFrameLoaderClient.mm:
435
436 2006-11-15  Brady Eidson  <beidson@apple.com>
437
438         Reviewed by Maciej
439
440         Split much of unused WebHistoryItemPrivate.h SPI into WebHistoryItemInternal.h
441
442         * History/WebBackForwardList.m:
443         * History/WebHistory.m:
444         * History/WebHistoryItem.m:
445         (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]):
446         (-[WebHistoryItem initWithURL:title:]):
447         (-[WebHistoryItem visitCount]):
448         (-[WebHistoryItem RSSFeedReferrer]):
449         (-[WebHistoryItem setRSSFeedReferrer:]):
450         (-[WebHistoryItem children]):
451         (-[WebHistoryItem dictionaryRepresentation]):
452         (-[WebHistoryItem setAlwaysAttemptToUsePageCache:]):
453         (+[WebHistoryItem _releaseAllPendingPageCaches]):
454         (-[WebHistoryItem URL]):
455         (-[WebHistoryItem target]):
456         (-[WebHistoryItem _setLastVisitedTimeInterval:]):
457         (-[WebHistoryItem _lastVisitedDate]):
458         (-[WebHistoryItem targetItem]):
459         * History/WebHistoryItemInternal.h: Added.
460         * History/WebHistoryItemPrivate.h:
461         * WebCoreSupport/WebFrameBridge.mm:
462         * WebCoreSupport/WebFrameLoaderClient.mm:
463         * WebKit.xcodeproj/project.pbxproj:
464         * WebView/WebFrame.mm:
465         * WebView/WebView.mm:
466
467 2006-11-14  Beth Dakin  <bdakin@apple.com>
468
469         Reviewed by Geoff.
470
471         Moving things off the bridge and onto clients.
472
473         * WebCoreSupport/WebEditorClient.h:
474         * WebCoreSupport/WebEditorClient.mm:
475         (WebEditorClient::selectWordBeforeMenuEvent):
476         (WebEditorClient::isEditable):
477         * WebCoreSupport/WebFrameBridge.mm:
478         * WebKit.xcodeproj/project.pbxproj:
479
480 2006-11-14  Timothy Hatcher  <timothy@apple.com>
481
482         Reviewed by Harrison.
483
484         <rdar://problem/4766635> Safari should never follow links in editable areas (add a WebKitEditableLinkNeverLive option)
485
486         Adds an Open Link, Open Link in New Window and Copy Link to the editing context menu.
487         Adds a new WebKitEditableLinkNeverLive preference value that maps to WebCore's EditableLinkNeverLive.
488
489         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
490         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
491         (-[WebDefaultUIDelegate contextMenuItemsForElement:defaultMenuItems:]):
492         (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
493         (-[WebDefaultUIDelegate requestWithURL:includingReferrerFromFrame:]):
494         (-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
495         (-[WebDefaultUIDelegate openLink:]):
496         * English.lproj/Localizable.strings:
497         * WebKit.exp:
498         * WebView/WebPreferences.m:
499         (-[WebPreferences editableLinkBehavior]):
500         * WebView/WebPreferencesPrivate.h:
501         * WebView/WebUIDelegatePrivate.h:
502
503 2006-11-14  Anders Carlsson  <acarlsson@apple.com>
504
505         Turns out I wasn't forcing DWARF on the world at all, 
506         it's now the default!
507
508         * WebKit.xcodeproj/project.pbxproj:
509
510 2006-11-14  Anders Carlsson  <acarlsson@apple.com>
511
512         I must stop trying to force DWARF on the world.
513
514         * WebKit.xcodeproj/project.pbxproj:
515
516 2006-11-14  Darin Adler  <darin@apple.com>
517
518         Reviewed by Anders.
519
520         - update for creation of EventHandler
521
522         * WebCoreSupport/WebFrameLoaderClient.mm:
523         (WebFrameLoaderClient::actionDictionary):
524         * WebView/WebHTMLView.m:
525         (-[WebHTMLView _updateMouseoverWithEvent:]):
526         (-[NSArray menuForEvent:]):
527         (-[NSArray scrollWheel:]):
528         (-[NSArray acceptsFirstMouse:]):
529         (-[NSArray shouldDelayWindowOrderingForEvent:]):
530         (-[NSArray mouseDown:]):
531         (-[NSArray mouseDragged:]):
532         (-[NSArray mouseUp:]):
533         (-[NSArray keyDown:]):
534         (-[NSArray keyUp:]):
535         (-[NSArray performKeyEquivalent:]):
536         (-[WebHTMLView elementAtPoint:allowShadowContent:]):
537
538 2006-11-14  Anders Carlsson  <acarlsson@apple.com>
539
540         Fix build for real this time.
541         
542         * WebCoreSupport/WebEditorClient.mm:
543         (-[WebEditCommand initWithEditCommand:WebCore::]):
544         (-[WebEditCommand dealloc]):
545         (-[WebEditCommand finalize]):
546         (+[WebEditCommand commandWithEditCommand:]):
547         (-[WebEditCommand command]):
548
549 2006-11-14  Anders Carlsson  <acarlsson@apple.com>
550
551         Try fixing the build.
552         
553         * WebCoreSupport/WebEditorClient.mm:
554         (-[WebEditorUndoTarget undoEditing:]):
555         (-[WebEditorUndoTarget redoEditing:]):
556
557 2006-11-14  Anders Carlsson  <acarlsson@apple.com>
558
559         Reviewed by Darin.
560
561         Move undo/redo handling into WebEditorClient.
562         
563         * WebCoreSupport/WebEditorClient.h:
564         * WebCoreSupport/WebEditorClient.mm:
565         (WebEditorClient::WebEditorClient):
566         (WebEditorClient::~WebEditorClient):
567         (-[WebEditCommand initWithEditCommand:WebCore::]):
568         (-[WebEditCommand dealloc]):
569         (-[WebEditCommand finalize]):
570         (+[WebEditCommand commandWithEditCommand:]):
571         (-[WebEditCommand command]):
572         (-[WebEditorUndoTarget undoEditing:]):
573         (-[WebEditorUndoTarget redoEditing:]):
574         (undoNameForEditAction):
575         (WebEditorClient::registerCommandForUndoOrRedo):
576         (WebEditorClient::registerCommandForUndo):
577         (WebEditorClient::registerCommandForRedo):
578         (WebEditorClient::clearUndoRedoOperations):
579         (WebEditorClient::canUndo):
580         (WebEditorClient::canRedo):
581         (WebEditorClient::undo):
582         (WebEditorClient::redo):
583         * WebCoreSupport/WebFrameBridge.mm:
584         * WebKit.xcodeproj/project.pbxproj:
585
586 2006-11-14  Alexey Proskuryakov  <ap@webkit.org>
587
588         Reviewed by Tim H.
589
590         http://bugs.webkit.org/show_bug.cgi?id=3387
591         Redundant keydown, keypress, keyup events sent for arrow keys
592
593         Added another layer of ugly hacks around AppKit event dispatching.
594
595         1. For arrow keys, keyDown: is invoked after performKeyEquivalent:, so had to store
596         _private->keyDownEvent in both methods, and make it persist after leaving them.
597
598         2. For Esc, AppKit calls performKeyEquivalent: with a fake event of some kind,
599         use [NSApp currentEvent] to check for this to prevent it from being passed to  WebCore.
600
601         Test: manual-tests/arrow-key-events.html
602
603         * WebView/WebHTMLView.m:
604         (-[NSMutableDictionary dealloc]):
605         (-[NSArray keyDown:]):
606         (-[NSArray keyUp:]):
607         (-[NSArray performKeyEquivalent:]):
608         * WebView/WebHTMLViewInternal.h:
609
610 2006-11-12  Brady Eidson <beidson@apple.com>
611
612         Rubberstamped by Anders
613
614         Changed some #includes from <WebKit/foo.h> to "foo.h"
615
616         * History/WebBackForwardList.m:
617         * History/WebHistory.m:
618
619 2006-11-11  Geoffrey Garen  <ggaren@apple.com>
620
621         Reviewed by Maciej Stachowiak.
622         
623         - Fixed loader crash by clarifying ownership of WebKit client objects. 
624         WebCore objects own their WebKit clients, and ref and deref through 
625         virtual methods, leaving WebKit free to use whatever client / reference-counting 
626         implementation it likes.
627         
628         WebKit on Mac just uses the same refcounting class that WebCore uses (Shared),
629         but other platforms may choose to do other things.
630
631         * WebCoreSupport/WebChromeClient.h:
632         (WebChromeClient::ref):
633         (WebChromeClient::deref):
634         (WebChromeClient::refCount):
635         * WebCoreSupport/WebEditorClient.h: Nixed commented-out function prototypes.
636         The ones in WebCore make clear what remains to be implemented. Replaced constructor
637         with factory function to avoid leaks.
638         * WebCoreSupport/WebEditorClient.mm:
639         (WebEditorClient::create):
640         (WebEditorClient::WebEditorClient):
641         (WebEditorClient::setWebFrame):
642         * WebCoreSupport/WebFrameBridge.mm:
643         (-[WebFrameBridge initMainFrameWithPage:WebCore::frameName:view:webView:]):
644         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
645         * WebCoreSupport/WebFrameLoaderClient.h: Replaced constructor with factory
646         function to avoid leaks.
647         (WebFrameLoaderClient::ref):
648         (WebFrameLoaderClient::deref):
649         (WebFrameLoaderClient::refCount):
650         * WebCoreSupport/WebFrameLoaderClient.mm:
651         (WebFrameLoaderClient::create):
652         * WebView/WebFrame.mm:
653         (-[WebFrame _initWithWebFrameView:webView:coreFrame:]):
654
655 === Safari-521.30 ===
656
657 2006-11-10  Maciej Stachowiak  <mjs@apple.com>
658
659         Reviewed by Anders.
660         
661         - remove some unnecessary uses of WebDataProtocol
662
663         * WebView/WebDataSource.mm: Remove the unneeded include.
664         * WebView/WebView.mm:
665         (+[WebView _canHandleRequest:]): Don't bother to check for unreachable URL here.
666         Any request that has one will be an applewebdata: request, which will pass the check anyway.
667
668 2006-11-10  Anders Carlsson  <acarlsson@apple.com>
669
670         Reviewed by Geoff.
671
672         Update for changes to WebCore
673         * WebView/WebHTMLView.m:
674         (-[NSArray _applyStyleToSelection:withUndoAction:]):
675         (-[NSArray _applyParagraphStyleToSelection:withUndoAction:]):
676         (-[NSArray _toggleBold]):
677         (-[NSArray _toggleItalic]):
678
679 2006-11-09  Anders Carlsson  <acarlsson@apple.com>
680
681         Reviewed by Maciej, Geoff.
682
683         Call execCommand directly here instead of going through the bridge.
684         
685         * WebView/WebHTMLView.m:
686         (-[NSArray moveBackward:]):
687         (-[NSArray moveBackwardAndModifySelection:]):
688         (-[NSArray moveDown:]):
689         (-[NSArray moveDownAndModifySelection:]):
690         (-[NSArray moveForward:]):
691         (-[NSArray moveForwardAndModifySelection:]):
692         (-[NSArray moveLeft:]):
693         (-[NSArray moveLeftAndModifySelection:]):
694         (-[NSArray moveRight:]):
695         (-[NSArray moveRightAndModifySelection:]):
696         (-[NSArray moveToBeginningOfDocument:]):
697         (-[NSArray moveToBeginningOfDocumentAndModifySelection:]):
698         (-[NSArray moveToBeginningOfSentence:]):
699         (-[NSArray moveToBeginningOfSentenceAndModifySelection:]):
700         (-[NSArray moveToBeginningOfLine:]):
701         (-[NSArray moveToBeginningOfLineAndModifySelection:]):
702         (-[NSArray moveToBeginningOfParagraph:]):
703         (-[NSArray moveToBeginningOfParagraphAndModifySelection:]):
704         (-[NSArray moveToEndOfDocument:]):
705         (-[NSArray moveToEndOfDocumentAndModifySelection:]):
706         (-[NSArray moveToEndOfSentence:]):
707         (-[NSArray moveToEndOfSentenceAndModifySelection:]):
708         (-[NSArray moveToEndOfLine:]):
709         (-[NSArray moveToEndOfLineAndModifySelection:]):
710         (-[NSArray moveToEndOfParagraph:]):
711         (-[NSArray moveToEndOfParagraphAndModifySelection:]):
712         (-[NSArray moveParagraphBackwardAndModifySelection:]):
713         (-[NSArray moveParagraphForwardAndModifySelection:]):
714         (-[NSArray moveUp:]):
715         (-[NSArray moveUpAndModifySelection:]):
716         (-[NSArray moveWordBackward:]):
717         (-[NSArray moveWordBackwardAndModifySelection:]):
718         (-[NSArray moveWordForward:]):
719         (-[NSArray moveWordForwardAndModifySelection:]):
720         (-[NSArray moveWordLeft:]):
721         (-[NSArray moveWordLeftAndModifySelection:]):
722         (-[NSArray moveWordRight:]):
723         (-[NSArray moveWordRightAndModifySelection:]):
724
725 2006-11-10  Brady Eidson  <beidson@apple.com>
726
727         Reviewed by Darin
728   
729         Took out WebIconDatabaseBridge and made WebKit call IconDatabase directly
730
731         * Misc/WebIconDatabase.m:
732         (-[WebIconDatabase init]):
733         (-[WebIconDatabase iconForURL:withSize:cache:]):
734         (-[WebIconDatabase iconURLForURL:]):
735         (-[WebIconDatabase defaultIconWithSize:]):
736         (-[WebIconDatabase defaultIconForURL:withSize:]):
737         (-[WebIconDatabase retainIconForURL:]):
738         (-[WebIconDatabase releaseIconForURL:]):
739         (-[WebIconDatabase setDelegate:]):
740         (-[WebIconDatabase removeAllIcons]):
741         (-[WebIconDatabase isIconExpiredForIconURL:]):
742         (-[WebIconDatabase _isEnabled]):
743         (-[WebIconDatabase _setIconData:forIconURL:]):
744         (-[WebIconDatabase _setHaveNoIconForIconURL:]):
745         (-[WebIconDatabase _setIconURL:forURL:]):
746         (-[WebIconDatabase _hasEntryForIconURL:]):
747         (-[WebIconDatabase _applicationWillTerminate:]):
748         (-[WebIconDatabase _resetCachedWebPreferences:]):
749         (-[WebIconDatabase _convertToWebCoreFormat]):
750         (webGetNSImage):
751         * Misc/WebIconDatabaseInternal.h: Added.
752         * Misc/WebIconDatabasePrivate.h:
753         * WebCoreSupport/WebFrameLoaderClient.h:
754         * WebCoreSupport/WebFrameLoaderClient.mm:
755         (WebFrameLoaderClient::dispatchDidReceiveIcon):
756         * WebCoreSupport/WebIconDatabaseBridge.h: Removed.
757         * WebCoreSupport/WebIconDatabaseBridge.m: Removed.
758         * WebKit.xcodeproj/project.pbxproj:
759
760 2006-11-09  Oliver Hunt  <oliver@apple.com>
761
762         Reviewed by Brady.
763         
764         Updated to make use of MimeTypeRegistry/bridge
765
766         * Misc/WebNSPasteboardExtras.m:
767         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:]):
768         * WebCoreSupport/WebFrameBridge.mm:
769         (-[WebFrameBridge determineObjectFromMIMEType:URL:]):
770         * WebView/WebDataSource.mm:
771         (-[WebDataSource _documentFragmentWithArchive:]):
772         * WebView/WebHTMLRepresentation.m:
773         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
774         (+[WebHTMLRepresentation supportedImageMIMETypes]):
775         * WebView/WebHTMLView.m:
776         (-[WebHTMLView _imageExistsAtPaths:]):
777         (-[WebHTMLView _documentFragmentWithPaths:]):
778
779 2006-11-09  Brady Eidson  <beidson@apple.com>
780
781         Reviewed by Darin
782
783         <rdar://problem/4829080>
784         More loader re-factoring cleanup - WebFramePolicyListener was over-released
785
786         * WebCoreSupport/WebFrameLoaderClient.h: Changed vanilla ptr to a RetainPtr<> 
787         * WebCoreSupport/WebFrameLoaderClient.mm:
788         (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): Ditto
789         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Ditto
790         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto
791         (WebFrameLoaderClient::dispatchWillSubmitForm): Ditto
792         (WebFrameLoaderClient::setUpPolicyListener): Ditto
793         (-[WebFramePolicyListener receivedPolicyDecision:]): Ditto 
794
795 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
796
797         Reviewed by Adam, Oliver.
798
799         Update for changes to WebCore. Pass a specific WebFrame to WebEditorClient
800         instead of just passing the WebView.
801         
802         * WebCoreSupport/WebEditorClient.h:
803         * WebCoreSupport/WebEditorClient.mm:
804         (WebEditorClient::WebEditorClient):
805         (WebEditorClient::setWebFrame):
806         (WebEditorClient::isContinuousSpellCheckingEnabled):
807         (WebEditorClient::spellCheckerDocumentTag):
808         (WebEditorClient::shouldDeleteRange):
809         (WebEditorClient::shouldShowDeleteInterface):
810         (WebEditorClient::shouldApplyStyle):
811         (WebEditorClient::shouldBeginEditing):
812         (WebEditorClient::shouldEndEditing):
813         (WebEditorClient::didBeginEditing):
814         (WebEditorClient::respondToChangedContents):
815         (WebEditorClient::didEndEditing):
816         * WebCoreSupport/WebFrameBridge.mm:
817         (-[WebFrameBridge initMainFrameWithPage:WebCore::frameName:view:webView:]):
818         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
819
820 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
821
822         Reviewed by Adam.
823
824         Move more code into editor.
825
826         * WebCoreSupport/WebEditorClient.h:
827         * WebCoreSupport/WebEditorClient.mm:
828         (WebEditorClient::shouldBeginEditing):
829         (WebEditorClient::shouldEndEditing):
830         (WebEditorClient::didBeginEditing):
831         (WebEditorClient::didEndEditing):
832         * WebCoreSupport/WebFrameBridge.mm:
833         * WebView/WebHTMLView.m:
834         (-[NSArray indent:]):
835         (-[NSArray outdent:]):
836         * WebView/WebView.mm:
837         * WebView/WebViewInternal.h:
838
839 2006-11-08  Beth Dakin  <bdakin@apple.com>
840
841         Reviewed by Adam.
842
843         Add WebElementIsContentEditableKey to the WebElementDictionary, and 
844         use it!
845
846         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
847         (-[WebDefaultUIDelegate 
848         webView:contextMenuItemsForElement:defaultMenuItems:]): Use new 
849         WebElementIsContentEditableKey.
850         * Misc/WebElementDictionary.m:
851         (+[WebElementDictionary initializeLookupTable]):
852         (-[WebElementDictionary _isContentEditable]): Call into 
853         HitTestResult::isContentEditable()
854         * WebView/WebView.mm: Add new key.
855         * WebView/WebViewPrivate.h: Add new key.
856
857 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
858
859         Reviewed by Oliver.
860
861         Call into the WebCore editor object directly.
862         
863         * MigrateHeaders.make:
864         * WebCoreSupport/WebEditorClient.h:
865         * WebCoreSupport/WebEditorClient.mm:
866         (WebEditorClient::shouldDeleteRange):
867         (WebEditorClient::shouldShowDeleteInterface):
868         (WebEditorClient::shouldApplyStyle):
869         * WebView/WebFrame.mm:
870         (core):
871         (kit):
872         * WebView/WebFrameInternal.h:
873         * WebView/WebHTMLView.m:
874         (-[NSArray _applyStyleToSelection:withUndoAction:]):
875         (-[NSArray _applyParagraphStyleToSelection:withUndoAction:]):
876         (-[NSArray _toggleBold]):
877         (-[NSArray _toggleItalic]):
878         (-[NSArray _changeCSSColorUsingSelector:inRange:]):
879         (-[NSArray underline:]):
880         (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
881         * WebView/WebView.mm:
882         (-[WebView applyStyle:]):
883
884 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
885
886         Reviewed by Oliver.
887
888         <rdar://problem/4825370>
889         REGRESSION: Selecting "Look Up In Dictionary" from contextual menu fails to open the Dictionary app
890         
891         * WebView/WebHTMLView.m:
892         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
893         Initialize the framework pointer to 0.
894         
895 2006-11-07  Darin Adler  <darin@apple.com>
896
897         Reviewed by Geoff.
898
899         - udpated for changes to move from Frame/FrameMac to FrameLoader
900
901         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
902         (-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
903         * Misc/WebNSAttributedStringExtras.m:
904         (+[NSAttributedString _web_attributedStringFromRange:]):
905         * Plugins/WebBaseNetscapePluginView.mm:
906         (-[WebBaseNetscapePluginView requestWithURLCString:]):
907         * Plugins/WebNetscapePluginEmbeddedView.m:
908         (-[WebNetscapePluginEmbeddedView didStart]):
909         * Plugins/WebNetscapePluginStream.mm:
910         * Plugins/WebPluginController.mm:
911         (-[WebPluginController pluginView:receivedResponse:]):
912         * WebCoreSupport/WebFrameBridge.mm:
913         (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
914         * WebCoreSupport/WebFrameLoaderClient.mm:
915         (WebFrameLoaderClient::provisionalLoadStarted):
916         * WebView/WebFrame.mm:
917         (-[WebFrame _canCachePage]):
918         (+[WebFrame _timeOfLastCompletedLoad]):
919         (-[WebFrame _loadItem:withLoadType:]):
920         (-[WebFrame _reloadForPluginChanges]):
921         (-[WebFrame stopLoading]):
922
923 2006-11-07  Anders Carlsson  <acarlsson@apple.com>
924
925         Reviewed by Geoff.
926
927         Use the WebCore editing enums.
928         
929         * WebCoreSupport/WebFrameBridge.mm:
930         (-[WebFrameBridge undoNameForEditAction:]):
931         * WebView/WebHTMLView.m:
932         (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:granularity:]):
933         (-[WebHTMLView _deleteSelection]):
934         (-[WebHTMLView moveBackward:]):
935         (-[WebHTMLView moveBackwardAndModifySelection:]):
936         (-[WebHTMLView moveDown:]):
937         (-[WebHTMLView moveDownAndModifySelection:]):
938         (-[WebHTMLView moveForward:]):
939         (-[WebHTMLView moveForwardAndModifySelection:]):
940         (-[WebHTMLView moveLeft:]):
941         (-[WebHTMLView moveLeftAndModifySelection:]):
942         (-[WebHTMLView moveRight:]):
943         (-[WebHTMLView moveRightAndModifySelection:]):
944         (-[WebHTMLView moveToBeginningOfDocument:]):
945         (-[WebHTMLView moveToBeginningOfDocumentAndModifySelection:]):
946         (-[WebHTMLView moveToBeginningOfSentence:]):
947         (-[WebHTMLView moveToBeginningOfSentenceAndModifySelection:]):
948         (-[WebHTMLView moveToBeginningOfLine:]):
949         (-[WebHTMLView moveToBeginningOfLineAndModifySelection:]):
950         (-[WebHTMLView moveToBeginningOfParagraph:]):
951         (-[WebHTMLView moveToBeginningOfParagraphAndModifySelection:]):
952         (-[WebHTMLView moveToEndOfDocument:]):
953         (-[WebHTMLView moveToEndOfDocumentAndModifySelection:]):
954         (-[WebHTMLView moveToEndOfSentence:]):
955         (-[WebHTMLView moveToEndOfSentenceAndModifySelection:]):
956         (-[WebHTMLView moveToEndOfLine:]):
957         (-[WebHTMLView moveToEndOfLineAndModifySelection:]):
958         (-[WebHTMLView moveToEndOfParagraph:]):
959         (-[WebHTMLView moveToEndOfParagraphAndModifySelection:]):
960         (-[WebHTMLView moveParagraphBackwardAndModifySelection:]):
961         (-[WebHTMLView moveParagraphForwardAndModifySelection:]):
962         (-[WebHTMLView moveUp:]):
963         (-[WebHTMLView moveUpAndModifySelection:]):
964         (-[WebHTMLView moveWordBackward:]):
965         (-[WebHTMLView moveWordBackwardAndModifySelection:]):
966         (-[WebHTMLView moveWordForward:]):
967         (-[WebHTMLView moveWordForwardAndModifySelection:]):
968         (-[WebHTMLView moveWordLeft:]):
969         (-[WebHTMLView moveWordLeftAndModifySelection:]):
970         (-[WebHTMLView moveWordRight:]):
971         (-[WebHTMLView moveWordRightAndModifySelection:]):
972         (-[WebHTMLView pageUp:]):
973         (-[WebHTMLView pageDown:]):
974         (-[WebHTMLView pageUpAndModifySelection:]):
975         (-[WebHTMLView pageDownAndModifySelection:]):
976         (-[WebHTMLView _expandSelectionToGranularity:]):
977         (-[WebHTMLView selectParagraph:]):
978         (-[WebHTMLView selectLine:]):
979         (-[WebHTMLView selectSentence:]):
980         (-[WebHTMLView selectWord:]):
981         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
982         (-[WebHTMLView _applyParagraphStyleToSelection:withUndoAction:]):
983         (-[WebHTMLView _toggleBold]):
984         (-[WebHTMLView _toggleItalic]):
985         (-[WebHTMLView pasteFont:]):
986         (-[WebHTMLView changeFont:]):
987         (-[WebHTMLView changeAttributes:]):
988         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
989         (-[WebHTMLView changeColor:]):
990         (-[WebHTMLView _alignSelectionUsingCSSValue:withUndoAction:]):
991         (-[WebHTMLView alignCenter:]):
992         (-[WebHTMLView alignJustified:]):
993         (-[WebHTMLView alignLeft:]):
994         (-[WebHTMLView alignRight:]):
995         (-[WebHTMLView _deleteWithDirection:SelectionController::granularity:killRing:isTypingAction:]):
996         (-[WebHTMLView deleteForward:]):
997         (-[WebHTMLView deleteBackward:]):
998         (-[WebHTMLView deleteWordForward:]):
999         (-[WebHTMLView deleteWordBackward:]):
1000         (-[WebHTMLView deleteToBeginningOfLine:]):
1001         (-[WebHTMLView deleteToEndOfLine:]):
1002         (-[WebHTMLView deleteToBeginningOfParagraph:]):
1003         (-[WebHTMLView deleteToEndOfParagraph:]):
1004         (-[WebHTMLView subscript:]):
1005         (-[WebHTMLView superscript:]):
1006         (-[WebHTMLView unscript:]):
1007         (-[WebHTMLView underline:]):
1008         (-[WebHTMLView deleteToMark:]):
1009         (-[WebHTMLView toggleBaseWritingDirection:]):
1010         (-[WebHTMLView changeBaseWritingDirection:]):
1011         (-[WebHTMLView _canSmartCopyOrDelete]):
1012         (-[WebTextCompleteController doCompletion]):
1013         (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
1014         * WebView/WebView.mm:
1015         (-[WebView setTypingStyle:]):
1016         (-[WebView applyStyle:]):
1017
1018 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
1019
1020         Reviewed by Tim Hatcher.
1021
1022         Removed ScreenClient. It was highly unpopular, risking my midterm re-election.
1023         
1024         None of Screen's responsibilities require up-calls to WebKit or delegates, 
1025         so WebCore can handle it all.
1026
1027         * WebCoreSupport/WebChromeClient.mm:
1028         (WebChromeClient::setWindowRect):
1029         (WebChromeClient::windowRect):
1030         * WebCoreSupport/WebScreenClient.h: Removed.
1031         * WebCoreSupport/WebScreenClient.mm: Removed.
1032         * WebKit.xcodeproj/project.pbxproj:
1033         * WebView/WebView.mm:
1034         (-[WebView _commonInitializationWithFrameName:groupName:]):
1035
1036 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
1037
1038         Reviewed by Darin.
1039         
1040         Accidentally rolled out this change when removing the WebPageBridge. Now
1041         putting it back.
1042
1043         * WebView/WebView.mm:
1044         (-[WebView _commonInitializationWithFrameName:groupName:]):
1045
1046 2006-11-05  Geoffrey Garen  <ggaren@apple.com>
1047
1048         Reviewed by Maciej, Darin, Anders.
1049
1050         Removed the Page bridge. Beefed up Chrome. Added Screen and ScreenClient.
1051         
1052         (WebChromeClient::pageRect): It may seem weird for the page to ask the Chrome/ChromeClient
1053         about its own dimensions. The idea here is that we're asking the Chrome how
1054         much space it has devoted to the page. We have API for this (-webViewContentRect), but 
1055         it was documented incorrectly (even Safari used it wrong), so we don't use 
1056         it anymore. Once we fix our API/documentation, we can return to making a
1057         delegate callback to ask for the page's size.
1058         (WebChromeClient::createWindow): Changed to take a FrameLoadRequest with
1059         an appropriate referrer, instead of making up its own.
1060         (WebChromeClient::createModalDialog): Changed to take a FrameLoadRequest with
1061         an appropriate referrer, instead of broken out parcels.
1062         * WebCoreSupport/WebPageBridge.h: Removed. Dead Code.
1063         * WebCoreSupport/WebPageBridge.mm: Removed. Dead Code.
1064         * WebCoreSupport/WebScreenClient.h: Added.
1065         * WebCoreSupport/WebScreenClient.mm: Added.
1066         * WebView/WebView.mm: Added NULL checks for new _private->page, since
1067         it's not NULL-safe like the bridge was, and it gets cleared before
1068         dealloc.
1069
1070 2006-11-06  Graham Dennis  <graham.dennis@gmail.com>
1071
1072         Reviewed by Tim Hatcher.
1073
1074         Part of patch for http://bugs.webkit.org/show_bug.cgi?id=11323
1075         Link dragging behaviour does not obey WebKitEditableLinkBehavior WebPref
1076
1077         * DefaultDelegates/WebDefaultUIDelegate.m:
1078         (-[NSApplication webView:dragSourceActionMaskForPoint:]): Logic moved to 
1079         WebHTMLView's _mayStartDragAtEventLocation
1080         * Misc/WebElementDictionary.m: added isLiveLink
1081         (+[WebElementDictionary initializeLookupTable]):
1082         (-[WebElementDictionary _isLiveLink]):
1083         * WebView/WebHTMLView.m: 
1084         (-[WebHTMLView _mayStartDragAtEventLocation:]): Editable links should
1085         only be followed if isLiveLink is true
1086         (-[WebHTMLView _isMoveDrag:]): A drag of a live editable link is not
1087         a move
1088         (-[WebHTMLView draggingUpdatedWithDraggingInfo:actionMask:]):
1089         (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
1090         * WebView/WebView.mm: added WebElementLinkIsLiveKey
1091         * WebView/WebViewPrivate.h: ditto
1092
1093 2006-11-04  Maciej Stachowiak  <mjs@apple.com>
1094
1095         Reviewed by Oliver.
1096         
1097         - removed unneeded (and obsolete) header includes
1098
1099         * WebCoreSupport/WebFrameBridge.mm:
1100         * WebView/WebFrame.mm:
1101
1102 2006-11-05  Darin Adler  <darin@apple.com>
1103
1104         - WebKit part of Frame.h check-in (forgot to land it)
1105
1106         * WebCoreSupport/WebFrameBridge.h:
1107         * WebCoreSupport/WebFrameBridge.mm:
1108         (-[WebFrameBridge textViewWasFirstResponderAtMouseDownTime:]):
1109         (-[WebFrameBridge shouldInterruptJavaScript]):
1110         (-[WebFrameBridge saveDocumentState:]):
1111         (-[WebFrameBridge previousKeyViewOutsideWebFrameViews]):
1112         (-[WebFrameBridge valueForKey:keys:values:]):
1113         (-[WebFrameBridge getObjectCacheSize]):
1114         (-[WebFrameBridge startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
1115         (-[WebFrameBridge mayStartDragAtEventLocation:]):
1116         (-[WebFrameBridge canGoBackOrForward:]):
1117         (-[WebFrameBridge goBackOrForward:]):
1118         (-[WebFrameBridge print]):
1119         (-[WebFrameBridge getAppletInView:]):
1120         (-[WebFrameBridge pollForAppletInView:]):
1121         (-[WebFrameBridge respondToChangedContents]):
1122         (-[WebFrameBridge respondToChangedSelection]):
1123         (-[WebFrameBridge setIsSelected:forView:]):
1124
1125 2006-11-04  Darin Adler  <darin@apple.com>
1126
1127         Reviewed by Maciej.
1128
1129         - converted more of the loader machinery to work with cross-platform
1130           data structures instead of Macintosh-specific ones
1131
1132           store the computed user agent string as a WebCore::String instead
1133           of an NSString to avoid overhead converting it every time we get it
1134
1135         * COM/WebFrame.cpp:
1136         (WebFrame::initWithName):
1137         * ChangeLog:
1138         * Misc/WebElementDictionary.m:
1139         (-[WebElementDictionary _image]):
1140         (-[WebElementDictionary _targetWebFrame]):
1141         * WebCoreSupport/WebFrameLoaderClient.h:
1142         * WebCoreSupport/WebFrameLoaderClient.mm:
1143         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1144         (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent):
1145         (WebFrameLoaderClient::setTitle):
1146         (WebFrameLoaderClient::userAgent):
1147         (WebFrameLoaderClient::actionDictionary):
1148         * WebCoreSupport/WebPageBridge.mm:
1149         (WebCore::if):
1150         * WebView/WebDataSource.mm:
1151         (-[WebDataSource _URL]):
1152         (-[WebDataSource _URLForHistory]):
1153         (-[WebDataSource unreachableURL]):
1154         * WebView/WebHTMLView.m:
1155         (-[WebHTMLView elementAtPoint:allowShadowContent:]):
1156         * WebView/WebPDFView.mm:
1157         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1158         (-[WebPDFView _path]):
1159         * WebView/WebView.mm:
1160         (-[WebViewPrivate init]):
1161         (-[WebViewPrivate dealloc]):
1162         (-[WebViewPrivate finalize]):
1163         (-[WebView _preferencesChangedNotification:]):
1164         (-[WebView _cachedResponseForURL:]):
1165         (-[WebView setApplicationNameForUserAgent:]):
1166         (-[WebView setCustomUserAgent:]):
1167         (-[WebView customUserAgent]):
1168         (-[WebView userAgentForURL:]):
1169         (-[WebView _computeUserAgent]):
1170         (-[WebView WebCore::]):
1171         * WebView/WebViewInternal.h:
1172
1173 2006-11-04  Bertrand Guiheneuf <guiheneuf@gmail.com>
1174
1175         Reviewed by Maciej, tweaked and landed by Alexey (using a patch by Don Gibson).
1176
1177         http://bugs.webkit.org/show_bug.cgi?id=11433
1178         Fixes to get WebKit to run on Windows; implemented AffineTransformCairo.
1179
1180         * COM/WebFrame.cpp:
1181         (WebFrame::initWithName):
1182         (WebFrame::loadDataSource):
1183         (WebFrame::receivedRedirect):
1184         (WebFrame::receivedResponse):
1185         (WebFrame::didReceiveData):
1186         (WebFrame::receivedAllData):
1187         Use resource handles now. Do not start doc loader by hand anymore. 
1188         Handle didReceiveData() callback instead of receivedData() which 
1189         is deprecated in implementation of ResourceHandleClient        
1190
1191         * COM/WebFrame.h:
1192         * COM/WebView.cpp:
1193         Applied ResourceLoader --> ResourceHandle renaming
1194
1195         * WebKit.vcproj/WebKit.rc:
1196         Got rid of MFC dependencies (build fix for VCExpress).
1197
1198         * WebKit.vcproj/WebKit.vcproj:
1199         Added platform/graphics platform/network and platform/network/win 
1200         to headers search paths
1201
1202 2006-11-03  Geoffrey Garen  <ggaren@apple.com>
1203
1204         Forgot to add these two files. Oops.
1205
1206         * WebCoreSupport/WebChromeClient.h: Added.
1207         * WebCoreSupport/WebChromeClient.mm: Added.
1208
1209 2006-11-02  Geoffrey Garen  <ggaren@apple.com>
1210
1211         Reviewed by Darin, Beth.
1212
1213         First cut at factoring Page's UIDelegate-related functions into Chrome
1214         and ChromeClient.
1215
1216         Layout tests pass.
1217         
1218         * WebCoreSupport/WebEditorClient.h:
1219         * WebCoreSupport/WebPageBridge.mm:
1220         * WebKit.xcodeproj/project.pbxproj:
1221
1222 2006-11-02  Timothy Hatcher  <timothy@apple.com>
1223
1224         Reviewed by Brady.
1225
1226         Adding outdent to the WebView responder forwarding list.
1227         Also add outdent to WebHTMLView.h and WebViewPrivate.h.
1228
1229         * WebView/WebHTMLView.h:
1230         * WebView/WebViewPrivate.h:
1231         * WebView/WebView.mm:
1232
1233 2006-11-01  John Sullivan  <sullivan@apple.com>
1234
1235         Reviewed by Adam Roben
1236         
1237         - fixed <rdar://problem/4801351> Crash reloading PDF file in new Safari (or closing a window containing a PDF file)
1238
1239         * WebView/WebPDFView.mm:
1240         (-[WebPDFView initWithFrame:]):
1241         Retain the PDFSubview in the code path where we just obtain it by asking the PDFPreviewView for it. We were
1242         unconditionally releasing it in dealloc, but only retaining it in one of the two code paths.
1243
1244 2006-10-31  Mark Rowe  <bdash@webkit.org>
1245
1246         Reviewed by Maciej.
1247
1248         Fix null pointer dereference while running editing/pasteboard/drag-drop-modifies-page.html
1249
1250         * Misc/WebElementDictionary.m:
1251         (-[WebElementDictionary _image]): Add null check.
1252
1253 2006-10-31  Beth Dakin  <bdakin@apple.com>
1254
1255         Reviewed by Maciej.
1256
1257         This creates local functions for the remaining WebElementDictionary 
1258         members that calls into HitTestResult instead of doing magical 
1259         things with the Objective-C DOM classes.
1260
1261         * ChangeLog:
1262         * Misc/WebElementDictionary.m:
1263         (addLookupKey): The values of the dictionary are now just 
1264         selectors. They used to be WebElementMethods which were 
1265         WebElementTargetObjects associated with selectors, but none of that 
1266         is needed any more.
1267         (+[WebElementDictionary initializeLookupTable]): All selectors are 
1268         now local functions, no more WebElementTargetObjects.
1269         (-[WebElementDictionary objectForKey:]): No more target objects!
1270         (-[WebElementDictionary _domNode]): Call into HitTestResult member 
1271         variable.
1272         (-[WebElementDictionary _altDisplayString]): Same.
1273         (-[WebElementDictionary _image]): Same.
1274         (-[WebElementDictionary _absoluteImageURL]): Same.
1275         (-[WebElementDictionary _title]): Same.
1276         (-[WebElementDictionary _absoluteLinkURL]): Same.
1277         (-[WebElementDictionary _targetWebFrame]): Same.
1278         (-[WebElementDictionary _titleDisplayString]): Same.
1279         (-[WebElementDictionary _textContent]): Same.
1280
1281 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
1282
1283         Reviewed by Alice.
1284         
1285         Moved some Editing code from WebKit, the bridge, and WebCore::Frame down 
1286         to WebCore::Editor.
1287
1288         * WebCoreSupport/WebFrameBridge.mm:
1289         * WebView/WebHTMLView.m:
1290         (-[WebHTMLView _shouldDeleteRange:]):
1291         (-[WebHTMLView _canCopy]):
1292         (-[WebHTMLView _canCut]):
1293         (-[WebHTMLView _canDelete]):
1294         (-[WebHTMLView _canPaste]):
1295         (-[WebHTMLView _canEdit]):
1296         (-[WebHTMLView _canEditRichly]):
1297         (-[WebHTMLView _isEditable]):
1298         (-[WebHTMLView _isSelectionInPasswordField]):
1299         (-[NSArray validateUserInterfaceItem:]):
1300         (-[NSArray _expandSelectionToGranularity:]):
1301
1302 2006-10-31  John Sullivan  <sullivan@apple.com>
1303
1304         Reviewed by Beth and Adam
1305         
1306         Display a tooltip when hovering over marked bad grammar.
1307
1308         * Misc/WebElementDictionary.m:
1309         (+[WebElementDictionary initializeLookupTable]):
1310         support spelling tool tip
1311         (-[WebElementDictionary _spellingToolTip]):
1312         new method, calls through to HitTestResult
1313         
1314         * WebView/WebHTMLView.m:
1315         (-[WebHTMLView _updateMouseoverWithEvent:]):
1316         Check for a spelling tool tip; if found, prefer it over the other possible tool tips.
1317         Check for empty strings instead of just nil strings being, since values from 
1318         WebElementDictionary are empty strings.
1319         
1320         * WebView/WebViewPrivate.h:
1321         declare new string constant WebElementSpellingToolTipKey
1322         * WebView/WebView.mm:
1323         define new string constant WebElementSpellingToolTipKey
1324         
1325 2006-10-31  Beth Dakin  <bdakin@apple.com>
1326
1327         Reviewed by Maciej.
1328
1329         Small tweaks to WebKit because of http://bugs.webkit.org/
1330         show_bug.cgi?id=11461 HitTestResult should be split into 
1331         HitTestRequest and HitTestResult
1332
1333         * WebKit.xcodeproj/project.pbxproj:
1334         * WebView/WebHTMLView.m:
1335         (-[WebHTMLView elementAtPoint:allowShadowContent:]): The 
1336         HitTestResult initializer now just takes a point.
1337
1338 2006-10-31  Darin Adler  <darin@apple.com>
1339
1340         Reviewed by Brady.
1341
1342         - got "action dictionary" code out of FrameLoader,
1343           replacing with a class called NavigationAction
1344
1345         * WebCoreSupport/WebFrameLoaderClient.h: Changed parameter types to NavigationAction.
1346         Made elementForEvent non-virtual. Added actionDictionary function.
1347         * WebCoreSupport/WebFrameLoaderClient.mm:
1348         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Changed parameter type,
1349         and used actionDictionary to make the action dictionary.
1350         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.
1351         (WebFrameLoaderClient::actionDictionary): Added. Code that was originally in WebCore
1352         that creates the action dictionary (from a NavigationAction).
1353
1354         * WebView/WebFrame.mm: (-[WebFrame _loadItem:withLoadType:]): Use NavigationAction
1355         instead of a dictionary for the action parameters.
1356
1357 2006-10-31  Marvin Decker  <marv.decker@gmail.com>
1358
1359         Reviewed by Maciej.
1360         
1361         - fixed "Stop and reload don't work on the WebView"
1362         http://bugs.webkit.org/show_bug.cgi?id=11285
1363
1364         * COM/WebFrame.cpp:
1365         (WebFrame::stopLoading): Implement.
1366         * COM/WebView.cpp:
1367         (WebView::stopLoading): ditto
1368         (WebView::reload): ditto
1369
1370 2006-10-30  Darin Adler  <darin@apple.com>
1371
1372         * Plugins/WebBaseNetscapePluginView.mm:
1373         (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
1374         Fix comment.
1375
1376 2006-10-30  John Sullivan  <sullivan@apple.com>
1377
1378         Reviewed by Geoff Garen
1379
1380         * WebView/WebHTMLView.m:
1381         (-[NSArray checkSpelling:]):
1382         removed code to update spelling panel; WebCore handles that now
1383         (-[NSArray showGuessPanel:]):
1384         ditto
1385
1386 2006-10-30  John Sullivan  <sullivan@apple.com>
1387
1388         * English.lproj/WebViewEditingContextMenu.nib/info.nib:
1389         * English.lproj/WebViewEditingContextMenu.nib/objects.nib:
1390         Another wording change to match framework, post-Tiger:
1391         "Check Spelling" -> "Check Document Now"
1392
1393 2006-10-30  John Sullivan  <sullivan@apple.com>
1394
1395         Reviewed by Geoff Garen.
1396         
1397         Moved spelling-related methods from bridge to EditorClient. Added one not-yet-used
1398         grammar-related method.
1399
1400         * WebCoreSupport/WebEditorClient.h:
1401         declare overrides of isContinuousSpellCheckingEnabled(), spellCheckerDocumentTag(), and new
1402         isGrammarCheckingEnabled()
1403         * WebCoreSupport/WebEditorClient.mm:
1404         (WebEditorClient::isContinuousSpellCheckingEnabled):
1405         implement by calling through to WebView
1406         (WebEditorClient::isGrammarCheckingEnabled):
1407         ditto
1408         (WebEditorClient::spellCheckerDocumentTag):
1409         ditto
1410         
1411         * WebCoreSupport/WebFrameBridge.mm:
1412         removed bridge equivalents of these methods
1413
1414 2006-10-30  Geoffrey Garen  <ggaren@apple.com>
1415
1416         Reviewed by Beth.
1417         
1418         Fixed nil-deref crash that I saw while using TOT (not sure how to repro,
1419         but the debugger confirmed the cause).
1420
1421         * WebView/WebFrame.mm:
1422         (core): Added check for NULL bridge.
1423
1424 2006-10-30  Geoffrey Garen  <ggaren@apple.com>
1425
1426         Reviewed by Darin.
1427
1428         Removed a number of editing and selection methods from the bridge.
1429         
1430         I moved cross-platform editing and selection code into WebCore::Editor and 
1431         WebCore::SelectionController, respecitvely.
1432         
1433         All of the seemingly new code here is just code grabbed from WebCore or
1434         merged from WebCoreFrameBridge.
1435         
1436         I changed one piece of internal API: we now pass around Ranges in places
1437         where we used to pass around broken out components of Ranges.
1438         
1439         I also added WebCore XPATH_SUPPORT AND SVG_SUPPORT #defines to the project.
1440         Since we now include WebCore headers that depend on these #defines, we need
1441         to keep in sync with them, to avoid binary incompatibility.
1442
1443 2006-10-30  Darin Adler  <darin@apple.com>
1444
1445         Reviewed by John Sullivan.
1446
1447         - work toward removing Objective-C data types from FrameLoader.h:
1448           removed NSDate, NSString, WebCorePageState, WebCoreResourceLoader,
1449           and WebCoreResourceHandle
1450         - moved bodyBackgroundColor function here from Frame
1451
1452         * History/WebHistoryItem.m: (+[WebHistoryItem _closeObjectsInPendingPageCaches]):
1453         Updated for change in WebCorePageState.
1454
1455         * WebCoreSupport/WebFrameBridge.mm: Removed saveDocumentToPageCache method.
1456
1457         * WebCoreSupport/WebFrameLoaderClient.h: Changed NSDate to double.
1458         * WebCoreSupport/WebFrameLoaderClient.mm:
1459         (WebFrameLoaderClient::invalidateCurrentItemPageCache): Moved the code that was
1460         formerly in invalidatePageCache: on the bridge here.
1461         (WebFrameLoaderClient::dispatchWillPerformClientRedirect): Added code to make the
1462         NSDate here.
1463         (WebFrameLoaderClient::createPageCache): Restructured code to create the
1464         WebCorePageState object directly instead of calling saveDocumentToPageCache on
1465         the bridge.
1466
1467         * WebView/WebFrame.mm: (-[WebFrame _bodyBackgroundColor]): Rewrote this to work
1468         directly with the DOM and renderers rather than using a function on Frame.
1469
1470 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
1471
1472         Reviewed by Anders.
1473
1474         - added ResourceResponse class and didReceiveResponse delegate call
1475
1476         * WebCoreSupport/WebFrameBridge.mm: Removed no longer needed
1477         expiresTimeForResponse: method.
1478
1479 2006-10-29  Darin Adler  <darin@apple.com>
1480
1481         - update for the WebCore rename
1482
1483         * WebCoreSupport/WebFrameLoaderClient.mm:
1484         * WebView/WebFrame.mm:
1485
1486 2006-10-29  Darin Adler  <darin@apple.com>
1487
1488         - update for the WebCore renames
1489
1490         * Plugins/WebNetscapePluginStream.mm:
1491         * Plugins/WebPluginController.mm:
1492         * WebCoreSupport/WebFrameBridge.mm:
1493         * WebCoreSupport/WebFrameLoaderClient.h:
1494         * WebCoreSupport/WebFrameLoaderClient.mm:
1495         (WebFrameLoaderClient::willUseArchive):
1496         (WebFrameLoaderClient::isArchiveLoadPending):
1497         (WebFrameLoaderClient::cancelPendingArchiveLoad):
1498         (WebFrameLoaderClient::deliverArchivedResources):
1499         * WebCoreSupport/WebPageBridge.mm:
1500         (-[WebPageBridge canRunModalNow]):
1501         * WebView/WebDocumentLoaderMac.h:
1502         * WebView/WebFrame.mm:
1503         * WebView/WebHTMLRepresentation.m:
1504         * WebView/WebView.mm:
1505
1506 2006-10-29  Darin Adler  <darin@apple.com>
1507
1508         Rubber stamped by Adam Roben.
1509
1510         - renamed WebCore's WebFrameLoaderClient to match the class name inside it
1511
1512         * WebCoreSupport/WebFrameBridge.mm: Update include.
1513         * WebCoreSupport/WebFrameLoaderClient.h: Ditto.
1514
1515 2006-10-29  Darin Adler  <darin@apple.com>
1516
1517         Reviewed by Maciej.
1518
1519         - eliminate use of NSArray to carry form data around
1520           (the code in this framework was actually using the NSArray to hold a single
1521            NSData anyway, so I just went back to an NSData for now)
1522
1523         - also fixed http://bugs.webkit.org/show_bug.cgi?id=11444
1524           REGRESSION (r17378): Exception (-[NSCFDictionary setObject:forKey:]:
1525           attempt to insert nil value) when submitting a form with an empty
1526           uninitialized field
1527
1528         * History/WebHistoryItem.m:
1529         (-[WebHistoryItem _setFormInfoFromRequest:]):
1530         (-[WebHistoryItem formData]):
1531         * History/WebHistoryItemPrivate.h:
1532         * WebCoreSupport/WebFrameLoaderClient.mm:
1533         (WebFrameLoaderClient::dispatchWillSubmitForm):
1534         * WebView/WebFrame.mm:
1535         (-[WebFrame _loadItem:withLoadType:]):
1536
1537 2006-10-28  Darin Adler  <darin@apple.com>
1538
1539         Reviewed by Maciej.
1540
1541         - eliminated the use of Objective-C for the policy decider
1542           machinery, obviating the need for WebPolicyDeciderMac
1543
1544         - moved the defersLoading flag from WebView to WebCore::Page
1545
1546         - removed unused copies of four methods that in the frame bridge;
1547           the actually-used copies are in the page bridge
1548
1549         - updated for rename of PassRefPtr::release to releaseRef
1550
1551         * WebView/WebPolicyDeciderMac.h: Removed.
1552         * WebView/WebPolicyDeciderMac.m: Removed.
1553         * WebKit.xcodeproj/project.pbxproj: Updated for removal.
1554
1555         * Plugins/WebBaseNetscapePluginView.mm:
1556         (-[WebBaseNetscapePluginView sendEvent:]):
1557         * Plugins/WebNetscapePluginStream.mm:
1558         * WebCoreSupport/WebFrameBridge.mm:
1559         * WebCoreSupport/WebFrameLoaderClient.h:
1560         * WebCoreSupport/WebFrameLoaderClient.mm:
1561         (getWebView):
1562         (WebFrameLoaderClient::WebFrameLoaderClient):
1563         (WebFrameLoaderClient::willCloseDocument):
1564         (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
1565         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1566         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1567         (WebFrameLoaderClient::cancelPolicyCheck):
1568         (WebFrameLoaderClient::dispatchWillSubmitForm):
1569         (WebFrameLoaderClient::setDefersLoading):
1570         (WebFrameLoaderClient::setTitle):
1571         (WebFrameLoaderClient::deliverArchivedResourcesAfterDelay):
1572         (WebFrameLoaderClient::deliverArchivedResources):
1573         (WebFrameLoaderClient::setUpPolicyListener):
1574         (WebFrameLoaderClient::receivedPolicyDecison):
1575         (WebFrameLoaderClient::userAgent):
1576         (-[WebFramePolicyListener initWithWebCoreFrame:]):
1577         (-[WebFramePolicyListener invalidate]):
1578         (-[WebFramePolicyListener dealloc]):
1579         (-[WebFramePolicyListener finalize]):
1580         (-[WebFramePolicyListener receivedPolicyDecision:]):
1581         (-[WebFramePolicyListener ignore]):
1582         (-[WebFramePolicyListener download]):
1583         (-[WebFramePolicyListener use]):
1584         (-[WebFramePolicyListener continue]):
1585         * WebCoreSupport/WebPageBridge.mm:
1586         (-[WebPageBridge runModal]):
1587         * WebView/WebArchiver.m:
1588         (+[WebArchiver archiveSelectionInFrame:]):
1589         * WebView/WebFormDelegate.h:
1590         * WebView/WebFormDelegate.m:
1591         (+[WebFormDelegate _sharedWebFormDelegate]):
1592         (-[WebFormDelegate textFieldDidBeginEditing:inFrame:]):
1593         (-[WebFormDelegate textFieldDidEndEditing:inFrame:]):
1594         (-[WebFormDelegate textDidChangeInTextField:inFrame:]):
1595         (-[WebFormDelegate textDidChangeInTextArea:inFrame:]):
1596         (-[WebFormDelegate frame:sourceFrame:willSubmitForm:withValues:submissionListener:]):
1597         * WebView/WebFrame.mm:
1598         (-[WebFrame _loadURL:referrer:intoChild:]):
1599         (-[WebFrame _isFrameSet]):
1600         * WebView/WebFrameInternal.h:
1601         * WebView/WebFrameView.mm:
1602         (-[WebFrameView _shouldDrawBorder]):
1603         * WebView/WebHTMLView.m:
1604         (-[NSArray knowsPageRange:]):
1605         * WebView/WebView.mm:
1606         (-[WebView _formDelegate]):
1607         * WebView/WebViewInternal.h:
1608         * WebView/WebViewPrivate.h:
1609
1610 2006-10-28  Adam Roben  <aroben@apple.com>
1611
1612         Reviewed by Maciej.
1613
1614         Fix layout tests that broke after r17399. Mitz discovered that the
1615         failures were caused by HitTestResult::m_point being uninitialized
1616         much of the time. HitTestResults are now always constructed with a
1617         point.
1618
1619         * WebView/WebHTMLView.m:
1620         (-[WebHTMLView elementAtPoint:allowShadowContent:]): Pass point to
1621         HitTestResult constructor.
1622
1623 2006-10-28  Beth Dakin  <bdakin@apple.com>
1624
1625         Reviewed by Darin.
1626
1627         This is the WebKit half of pushing the guts of elementAtPoint and 
1628         WebElementDictionary into WebCore. Among other things, this patch 
1629         makes WebElementDictionary.m and WebHTMLView.m Objective-C++
1630
1631         * MigrateHeaders.make: Add DOMElementInternal.h to the list of 
1632         headers to migrate.
1633         * Misc/WebElementDictionary.h: Replaced DOMNode, DOMElement, and 
1634         NSPoint member variables with a HitTestResult member variable.
1635         * Misc/WebElementDictionary.m:
1636         (addLookupKey): Formatting.
1637         (-[WebElementDictionary initWithHitTestResult:]): Constructor just 
1638         takes a HitTestResult now and sets the member variable.
1639         (-[WebElementDictionary dealloc]): delete HitTestResult.
1640         (-[WebElementDictionary finalize]): Address HitTestResult.
1641         (-[WebElementDictionary _domNode]): Use HitTestResult and call into 
1642         WebCore.
1643         (-[WebElementDictionary objectForKey:]): Same.
1644         (-[WebElementDictionary _webFrame]): Same.
1645         (-[WebElementDictionary _targetWebFrame]): Same.
1646         (-[WebElementDictionary _title]): Same.
1647         (-[WebElementDictionary _imageRect]): Same.
1648         (-[WebElementDictionary _isSelected]): Same.
1649         * WebKit.xcodeproj/project.pbxproj:
1650         * WebView/WebFrame.mm:
1651         (core): Convert from DOMNode* to Node*
1652         (kit): Convert from Node* to DOMNode*
1653         * WebView/WebFrameInternal.h: Support for the above.
1654         * WebView/WebHTMLView.m:
1655         (-[WebHTMLView elementAtPoint:allowShadowContent:]): Call directly 
1656         into Frame.cpp to get HitTestResult.
1657
1658 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
1659
1660         Reviewed by John & Adam.
1661         
1662         - various performance improvements for resource delegate dispatch.
1663         
1664         - avoid any ObjC messaging when fetching the WebView
1665         - avoid ObjC calls to WebView to get resource load delegate and impl cache
1666         - cache actual method pointers, not just the fact that the method is present
1667         - added a new SPI resource load delegate method which allows clients to get
1668           just one message in case of synchronously loading from memory cache; if this
1669           is implemented you don't get the normal delegate calls in that case.
1670         - various other minor tweaks
1671
1672         * WebCoreSupport/WebFrameBridge.h:
1673         * WebCoreSupport/WebFrameLoaderClient.h:
1674         * WebCoreSupport/WebFrameLoaderClient.mm:
1675         (getWebView):
1676         (WebFrameLoaderClient::hasBackForwardList):
1677         (WebFrameLoaderClient::resetBackForwardList):
1678         (WebFrameLoaderClient::privateBrowsingEnabled):
1679         (WebFrameLoaderClient::updateHistoryForStandardLoad):
1680         (WebFrameLoaderClient::resetAfterLoadError):
1681         (WebFrameLoaderClient::download):
1682         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
1683         (WebFrameLoaderClient::dispatchIdentifierForInitialRequest):
1684         (WebFrameLoaderClient::dispatchWillSendRequest):
1685         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
1686         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
1687         (WebFrameLoaderClient::dispatchDidReceiveResponse):
1688         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
1689         (WebFrameLoaderClient::dispatchDidFinishLoading):
1690         (WebFrameLoaderClient::dispatchDidFailLoading):
1691         (WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
1692         (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
1693         (WebFrameLoaderClient::dispatchDidCancelClientRedirect):
1694         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1695         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
1696         (WebFrameLoaderClient::dispatchWillClose):
1697         (WebFrameLoaderClient::dispatchDidReceiveIcon):
1698         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1699         (WebFrameLoaderClient::dispatchDidReceiveTitle):
1700         (WebFrameLoaderClient::dispatchDidCommitLoad):
1701         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
1702         (WebFrameLoaderClient::dispatchDidFailLoad):
1703         (WebFrameLoaderClient::dispatchDidFinishLoad):
1704         (WebFrameLoaderClient::dispatchDidFirstLayout):
1705         (WebFrameLoaderClient::dispatchCreatePage):
1706         (WebFrameLoaderClient::dispatchShow):
1707         (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
1708         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1709         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1710         (WebFrameLoaderClient::dispatchUnableToImplementPolicy):
1711         (WebFrameLoaderClient::dispatchWillSubmitForm):
1712         (WebFrameLoaderClient::dispatchDidLoadMainResource):
1713         (WebFrameLoaderClient::progressStarted):
1714         (WebFrameLoaderClient::progressCompleted):
1715         (WebFrameLoaderClient::incrementProgress):
1716         (WebFrameLoaderClient::completeProgress):
1717         (WebFrameLoaderClient::setMainFrameDocumentReady):
1718         (WebFrameLoaderClient::startDownload):
1719         (WebFrameLoaderClient::willChangeTitle):
1720         (WebFrameLoaderClient::didChangeTitle):
1721         (WebFrameLoaderClient::mainFrameURL):
1722         (WebFrameLoaderClient::frameLoadCompleted):
1723         * WebCoreSupport/WebPageBridge.h:
1724         * WebKit.xcodeproj/project.pbxproj:
1725         * WebView/WebFrame.mm:
1726         (frame):
1727         (core):
1728         (kit):
1729         (getWebView):
1730         (-[WebFrame _addBackForwardItemClippedAtTarget:]):
1731         (-[WebFrame _canCachePage]):
1732         (-[WebFrame _purgePageCache]):
1733         (-[WebFrame _loadItem:withLoadType:]):
1734         (-[WebFrame _goToItem:withLoadType:]):
1735         (-[WebFrame _updateBackground]):
1736         (-[WebFrame _clearSelectionInOtherFrames]):
1737         (-[WebFrame _isMainFrame]):
1738         (-[WebFrame webView]):
1739         * WebView/WebResourceLoadDelegatePrivate.h: Added.
1740         * WebView/WebView.mm:
1741         (-[WebView _cacheResourceLoadDelegateImplementations]):
1742         (WebViewGetResourceLoadDelegate):
1743         (WebViewGetResourceLoadDelegateImplementations):
1744         * WebView/WebViewInternal.h:
1745         * WebView/WebViewPrivate.h:
1746
1747 2006-10-27  Geoffrey Garen  <ggaren@apple.com>
1748
1749         Reviewed by Maciej.
1750         
1751         Moved some WebCoreFrameBridge functions into FrameLoader.
1752
1753         * WebView/WebFrame.mm:
1754         (-[WebFrame _numPendingOrLoadingRequests:]):
1755
1756 2006-10-27  Timothy Hatcher  <timothy@apple.com>
1757
1758         Reviewed by Beth.
1759
1760         Make a DerivedSource/Webkit directory to store migrated
1761         internal headers from WebCore.
1762
1763         * MigrateHeaders.make:
1764         * WebKit.xcodeproj/project.pbxproj:
1765         * WebView/WebFrame.mm: import the new migrated DOM*Internal.h headers
1766
1767 2006-10-27  John Sullivan  <sullivan@apple.com>
1768
1769         Reviewed by Anders
1770         
1771         - fixed http://bugs.webkit.org/show_bug.cgi?id=11439 
1772           REGRESSION: Another page loading crash
1773
1774         * WebView/WebFrame.mm:
1775         (-[WebFrame _createItem:]):
1776         Handle nil documentLoader the way we did before ObjC->C++ changes
1777
1778 2006-10-27  John Sullivan  <sullivan@apple.com>
1779
1780         Reviewed by Anders
1781
1782         * WebView/WebHTMLView.m:
1783         (-[NSArray checkSpelling:]):
1784         call advanceToNextMisspelling directly on FrameMac, bypassing bridge
1785         (-[NSArray showGuessPanel:]):
1786         ditto
1787
1788 2006-10-27  Darin Adler  <darin@apple.com>
1789
1790         - build fix
1791
1792         * WebCoreSupport/WebFrameLoaderClient.mm: Corrected header file name.
1793
1794 2006-10-27  Darin Adler  <darin@apple.com>
1795
1796         Reviewed by Maciej.
1797
1798         - moved methods that are there just to be called by the frame loader client into the client
1799           in an attempt to get back some of the speed we lost yesterday
1800
1801         * DefaultDelegates/WebDefaultResourceLoadDelegate.m:
1802         (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
1803         (-[WebDefaultResourceLoadDelegate webView:resource:didCancelAuthenticationChallenge:fromDataSource:]):
1804         * WebCoreSupport/WebFrameLoaderClient.h:
1805         * WebCoreSupport/WebFrameLoaderClient.mm:
1806         (dataSource):
1807         (decisionListener):
1808         (WebFrameLoaderClient::WebFrameLoaderClient):
1809         (WebFrameLoaderClient::hasWebView):
1810         (WebFrameLoaderClient::hasFrameView):
1811         (WebFrameLoaderClient::hasBackForwardList):
1812         (WebFrameLoaderClient::resetBackForwardList):
1813         (WebFrameLoaderClient::provisionalItemIsTarget):
1814         (WebFrameLoaderClient::loadProvisionalItemFromPageCache):
1815         (WebFrameLoaderClient::invalidateCurrentItemPageCache):
1816         (WebFrameLoaderClient::privateBrowsingEnabled):
1817         (WebFrameLoaderClient::makeDocumentView):
1818         (WebFrameLoaderClient::makeRepresentation):
1819         (WebFrameLoaderClient::setDocumentViewFromPageCache):
1820         (WebFrameLoaderClient::forceLayout):
1821         (WebFrameLoaderClient::forceLayoutForNonHTML):
1822         (WebFrameLoaderClient::updateHistoryForCommit):
1823         (WebFrameLoaderClient::updateHistoryForBackForwardNavigation):
1824         (WebFrameLoaderClient::updateHistoryForReload):
1825         (WebFrameLoaderClient::updateHistoryForStandardLoad):
1826         (WebFrameLoaderClient::updateHistoryForInternalLoad):
1827         (WebFrameLoaderClient::updateHistoryAfterClientRedirect):
1828         (WebFrameLoaderClient::setCopiesOnScroll):
1829         (WebFrameLoaderClient::tokenForLoadErrorReset):
1830         (WebFrameLoaderClient::resetAfterLoadError):
1831         (WebFrameLoaderClient::doNotResetAfterLoadError):
1832         (WebFrameLoaderClient::detachedFromParent1):
1833         (WebFrameLoaderClient::detachedFromParent2):
1834         (WebFrameLoaderClient::detachedFromParent3):
1835         (WebFrameLoaderClient::detachedFromParent4):
1836         (WebFrameLoaderClient::loadedFromPageCache):
1837         (WebFrameLoaderClient::download):
1838         (WebFrameLoaderClient::dispatchIdentifierForInitialRequest):
1839         (WebFrameLoaderClient::dispatchWillSendRequest):
1840         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
1841         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
1842         (WebFrameLoaderClient::dispatchDidReceiveResponse):
1843         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
1844         (WebFrameLoaderClient::dispatchDidFinishLoading):
1845         (WebFrameLoaderClient::dispatchDidFailLoading):
1846         (WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
1847         (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
1848         (WebFrameLoaderClient::dispatchDidCancelClientRedirect):
1849         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1850         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
1851         (WebFrameLoaderClient::dispatchWillClose):
1852         (WebFrameLoaderClient::dispatchDidReceiveIcon):
1853         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1854         (WebFrameLoaderClient::dispatchDidReceiveTitle):
1855         (WebFrameLoaderClient::dispatchDidCommitLoad):
1856         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
1857         (WebFrameLoaderClient::dispatchDidFailLoad):
1858         (WebFrameLoaderClient::dispatchDidFinishLoad):
1859         (WebFrameLoaderClient::dispatchDidFirstLayout):
1860         (WebFrameLoaderClient::dispatchCreatePage):
1861         (WebFrameLoaderClient::dispatchShow):
1862         (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
1863         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1864         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1865         (WebFrameLoaderClient::dispatchUnableToImplementPolicy):
1866         (WebFrameLoaderClient::dispatchWillSubmitForm):
1867         (WebFrameLoaderClient::dispatchDidLoadMainResource):
1868         (WebFrameLoaderClient::clearLoadingFromPageCache):
1869         (WebFrameLoaderClient::isLoadingFromPageCache):
1870         (WebFrameLoaderClient::revertToProvisionalState):
1871         (WebFrameLoaderClient::setMainDocumentError):
1872         (WebFrameLoaderClient::clearUnarchivingState):
1873         (WebFrameLoaderClient::progressStarted):
1874         (WebFrameLoaderClient::progressCompleted):
1875         (WebFrameLoaderClient::incrementProgress):
1876         (WebFrameLoaderClient::completeProgress):
1877         (WebFrameLoaderClient::setMainFrameDocumentReady):
1878         (WebFrameLoaderClient::startDownload):
1879         (WebFrameLoaderClient::willChangeTitle):
1880         (WebFrameLoaderClient::didChangeTitle):
1881         (WebFrameLoaderClient::committedLoad):
1882         (WebFrameLoaderClient::finishedLoading):
1883         (WebFrameLoaderClient::finalSetupForReplace):
1884         (WebFrameLoaderClient::cancelledError):
1885         (WebFrameLoaderClient::cannotShowURLError):
1886         (WebFrameLoaderClient::interruptForPolicyChangeError):
1887         (WebFrameLoaderClient::cannotShowMIMETypeError):
1888         (WebFrameLoaderClient::fileDoesNotExistError):
1889         (WebFrameLoaderClient::shouldFallBack):
1890         (WebFrameLoaderClient::mainFrameURL):
1891         (WebFrameLoaderClient::setDefersCallbacks):
1892         (WebFrameLoaderClient::willUseArchive):
1893         (WebFrameLoaderClient::isArchiveLoadPending):
1894         (WebFrameLoaderClient::cancelPendingArchiveLoad):
1895         (WebFrameLoaderClient::clearArchivedResources):
1896         (WebFrameLoaderClient::canHandleRequest):
1897         (WebFrameLoaderClient::canShowMIMEType):
1898         (WebFrameLoaderClient::representationExistsForURLScheme):
1899         (WebFrameLoaderClient::generatedMIMETypeForURLScheme):
1900         (WebFrameLoaderClient::elementForEvent):
1901         (WebFrameLoaderClient::createPolicyDecider):
1902         (WebFrameLoaderClient::frameLoadCompleted):
1903         (WebFrameLoaderClient::restoreScrollPositionAndViewState):
1904         (WebFrameLoaderClient::provisionalLoadStarted):
1905         (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent):
1906         (WebFrameLoaderClient::addHistoryItemForFragmentScroll):
1907         (WebFrameLoaderClient::didFinishLoad):
1908         (WebFrameLoaderClient::prepareForDataSourceReplacement):
1909         (WebFrameLoaderClient::createDocumentLoader):
1910         (WebFrameLoaderClient::setTitle):
1911         (WebFrameLoaderClient::canUseArchivedResource):
1912         (WebFrameLoaderClient::deliverArchivedResourcesAfterDelay):
1913         (WebFrameLoaderClient::deliverArchivedResources):
1914         (WebFrameLoaderClient::createPageCache):
1915         * WebView/WebFrame.mm:
1916         (-[NSView setWebFrame:]):
1917         (-[WebFrame _createItem:]):
1918         (-[WebFrame _loadItem:withLoadType:]):
1919         (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]):
1920         (-[WebFrame _loadURL:referrer:intoChild:]):
1921         (-[WebFrame _saveScrollPositionAndViewStateToItem:]):
1922         (-[WebFrame _hasSelection]):
1923         (-[WebFrame _clearSelection]):
1924         (-[WebFrame _setProvisionalItem:]):
1925         (-[WebFrame _setPreviousItem:]):
1926         (-[WebFrame _setCurrentItem:]):
1927         (-[WebFrame loadArchive:]):
1928         * WebView/WebFrameInternal.h:
1929         * WebView/WebHTMLView.m:
1930         (-[WebHTMLView _topHTMLView]):
1931         * WebView/WebHTMLViewPrivate.h:
1932
1933 2006-10-26  Geoffrey Garen  <ggaren@apple.com>
1934
1935         Reviewed by Darin, Maciej.
1936
1937         Removed many uses of NSString * from WebCore.
1938         
1939         Changed a few files to ObjC++ for compatiblity with new WebCore methods
1940         taking WebCore::Strings as arguments.
1941         
1942         Added a static_cast to make the c++ compiler happy.
1943
1944 2006-10-26  John Sullivan  <sullivan@apple.com>
1945
1946         Reviewed by Anders
1947
1948         * WebView/WebFrame.mm:
1949         now includes <WebCore/Document.h> and <WebCore/DocumentMarker.h>
1950         (-[WebFrame _unmarkAllBadGrammar]):
1951         filled in guts
1952         (-[WebFrame _unmarkAllMisspellings]):
1953         rewrote to call Document directly, bypassing bridge
1954
1955 2006-10-26  John Sullivan  <sullivan@apple.com>
1956
1957         * English.lproj/WebViewEditingContextMenu.nib/info.nib:
1958         * English.lproj/WebViewEditingContextMenu.nib/objects.nib:
1959         
1960         Changed "Spelling" to "Spelling and Grammar" in context menu for post-Tiger.
1961
1962 === Safari-521.29 ===
1963
1964 2006-10-26  John Sullivan  <sullivan@apple.com>
1965
1966         No review, just two localized string changes.
1967         
1968         * WebView/WebHTMLView.m:
1969         (-[NSArray validateUserInterfaceItem:]):
1970         changed "Show/Hide Spelling" to "Show/Hide Spelling and Grammar" post-Tiger to match framework change
1971
1972         * English.lproj/Localizable.strings:
1973         updated for these changes
1974
1975 2006-10-25  Darin Adler  <darin@apple.com>
1976
1977         Reviewed by Anders.
1978
1979         - removed 55 methods from WebCoreFrameBridge
1980         - changed callers to use Frame directly instead
1981         - put FrameLoaderTypes.h types into the WebCore namespace
1982         - first steps to get FrameLoader.h ready for cross-platform duty
1983
1984         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
1985         (-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
1986         * Plugins/WebBaseNetscapePluginView.mm:
1987         (-[WebBaseNetscapePluginView requestWithURLCString:]):
1988         (-[WebBaseNetscapePluginView loadPluginRequest:]):
1989         (-[WebBaseNetscapePluginView getVariable:value:]):
1990         * Plugins/WebNetscapePluginEmbeddedView.m:
1991         (-[WebNetscapePluginEmbeddedView didStart]):
1992         * Plugins/WebNetscapePluginStream.mm:
1993         * Plugins/WebPluginContainerCheck.m:
1994         (-[WebPluginContainerCheck _continueWithPolicy:]):
1995         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
1996         * WebCoreSupport/WebEditorClient.mm:
1997         (WebEditorClient::shouldDeleteRange):
1998         (WebEditorClient::shouldShowDeleteInterface):
1999         * WebCoreSupport/WebFrameBridge.mm:
2000         (-[WebFrameBridge webView]):
2001         (-[WebFrameBridge finishInitializingWithFrameName:view:]):
2002         (-[WebFrameBridge createWindowWithURL:]):
2003         (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
2004         (-[WebFrameBridge windowObjectCleared]):
2005         (-[WebFrameBridge createModalDialogWithURL:]):
2006         * WebCoreSupport/WebFrameLoaderClient.mm:
2007         (WebFrameLoaderClient::dispatchCreatePage):
2008         (WebFrameLoaderClient::dispatchWillSubmitForm):
2009         * WebKit.xcodeproj/project.pbxproj:
2010         * WebView/WebArchiver.m:
2011         (+[WebArchiver archiveSelectionInFrame:]):
2012         * WebView/WebDataSource.mm:
2013         (-[WebDataSource _documentFragmentWithImageResource:]):
2014         (-[WebDataSource _imageElementWithImageResource:]):
2015         * WebView/WebEditingDelegatePrivate.h:
2016         * WebView/WebFrame.mm:
2017         (core):
2018         (kit):
2019         (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]):
2020         (-[WebFrame _canCachePage]):
2021         (-[WebFrame _childFramesMatchItem:]):
2022         (-[WebFrame _URLsMatchItem:]):
2023         (-[WebFrame _loadItem:withLoadType:]):
2024         (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]):
2025         (-[WebFrame _viewWillMoveToHostWindow:]):
2026         (-[WebFrame _viewDidMoveToHostWindow]):
2027         (-[WebFrame _addChild:]):
2028         (-[WebFrame _saveDocumentAndScrollState]):
2029         (-[WebFrame _numPendingOrLoadingRequests:]):
2030         (-[WebFrame _reloadForPluginChanges]):
2031         (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
2032         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
2033         (-[WebFrame _initWithWebFrameView:webView:coreFrame:]):
2034         (-[WebFrame _documentViews]):
2035         (-[WebFrame _updateBackground]):
2036         (-[WebFrame _unmarkAllMisspellings]):
2037         (-[WebFrame _hasSelection]):
2038         (-[WebFrame _atMostOneFrameHasSelection]):
2039         (-[WebFrame _findFrameWithSelection]):
2040         (-[WebFrame _frameLoader]):
2041         (-[WebFrame _isDescendantOfFrame:]):
2042         (-[WebFrame _setShouldCreateRenderers:]):
2043         (-[WebFrame _bodyBackgroundColor]):
2044         (-[WebFrame init]):
2045         (-[WebFrame initWithName:webFrameView:webView:]):
2046         (-[WebFrame dealloc]):
2047         (-[WebFrame finalize]):
2048         (-[WebFrame name]):
2049         (-[WebFrame webView]):
2050         (-[WebFrame DOMDocument]):
2051         (-[WebFrame frameElement]):
2052         (-[WebFrame findFrameNamed:]):
2053         (-[WebFrame parentFrame]):
2054         (-[WebFrame childFrames]):
2055         (-[WebFrame _invalidateCurrentItemPageCache]):
2056         (-[WebFrame _dispatchCreateWebViewWithRequest:]):
2057         (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]):
2058         (-[WebFrame _prepareForDataSourceReplacement]):
2059         (-[WebFrame _provisionalLoadStarted]):
2060         * WebView/WebFrameInternal.h:
2061         * WebView/WebHTMLRepresentation.m:
2062         (-[WebHTMLRepresentation DOMDocument]):
2063         (-[WebHTMLRepresentation attributedText]):
2064         * WebView/WebHTMLView.m:
2065         (-[WebHTMLView _documentRange]):
2066         (-[WebHTMLView _documentFragmentWithPaths:]):
2067         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]):
2068         (-[WebHTMLView _selectedRange]):
2069         (-[WebHTMLView _updateMouseoverWithEvent:]):
2070         (-[WebHTMLView _canEditRichly]):
2071         (-[WebHTMLView _hasSelection]):
2072         (-[WebHTMLView _hasSelectionOrInsertionPoint]):
2073         (-[WebHTMLView _hasInsertionPoint]):
2074         (-[WebHTMLView _isEditable]):
2075         (-[WebHTMLView _isSelectionInPasswordField]):
2076         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
2077         (-[WebHTMLView _selectionDraggingImage]):
2078         (-[WebHTMLView _canIncreaseSelectionListLevel]):
2079         (-[WebHTMLView _canDecreaseSelectionListLevel]):
2080         (-[WebHTMLView _updateActiveState]):
2081         (-[NSArray readSelectionFromPasteboard:]):
2082         (-[NSArray validateUserInterfaceItem:]):
2083         (-[NSArray maintainsInactiveSelection]):
2084         (-[NSArray menuForEvent:]):
2085         (-[NSArray scrollWheel:]):
2086         (-[NSArray acceptsFirstMouse:]):
2087         (-[NSArray shouldDelayWindowOrderingForEvent:]):
2088         (-[NSArray mouseDown:]):
2089         (-[NSArray mouseDragged:]):
2090         (-[NSArray mouseUp:]):
2091         (-[NSArray keyDown:]):
2092         (-[NSArray keyUp:]):
2093         (-[NSArray centerSelectionInVisibleArea:]):
2094         (-[NSArray _selectionStartFontAttributesAsRTF]):
2095         (-[NSArray _emptyStyle]):
2096         (-[NSArray performKeyEquivalent:]):
2097         (-[NSArray indent:]):
2098         (-[NSArray outdent:]):
2099         (-[WebHTMLView cut:]):
2100         (-[WebHTMLView paste:]):
2101         (-[WebHTMLView _selectRangeInMarkedText:]):
2102         (-[WebTextCompleteController doCompletion]):
2103         (-[WebHTMLView selectionRect]):
2104         (-[WebHTMLView selectionImageForcingWhiteText:]):
2105         (-[WebHTMLView selectionImageRect]):
2106         (-[WebHTMLView attributedString]):
2107         (-[WebHTMLView _isMoveDrag]):
2108         (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
2109         * WebView/WebPolicyDelegate.mm:
2110         (-[WebPolicyDecisionListener _usePolicy:]):
2111         (-[WebPolicyDecisionListener use]):
2112         (-[WebPolicyDecisionListener ignore]):
2113         (-[WebPolicyDecisionListener download]):
2114         (-[WebPolicyDecisionListener continue]):
2115         * WebView/WebScriptDebugDelegate.m:
2116         (-[WebScriptCallFrame _initWithFrame:initWithWebFrame:]):
2117         (-[WebScriptCallFrame globalObject]):
2118         * WebView/WebView.mm:
2119         (-[WebView _attachScriptDebuggerToAllFrames]):
2120         (-[WebView _detachScriptDebuggerFromAllFrames]):
2121         (-[WebView windowScriptObject]):
2122         (incrementFrame):
2123         (-[WebView searchFor:direction:caseSensitive:wrap:]):
2124         (-[WebView writeSelectionWithPasteboardTypes:toPasteboard:]):
2125         (-[WebView removeDragCaret]):
2126         (-[WebView setScriptDebugDelegate:]):
2127         (-[WebView scriptDebugDelegate]):
2128         (-[WebView shouldClose]):
2129         (-[WebView selectedDOMRange]):
2130         (-[WebView styleDeclarationWithText:]):
2131
2132 2006-10-25  Geoffrey Garen  <ggaren@apple.com>
2133
2134         Reviewed by Adam.
2135
2136         Renamed WebFrameLoader to FrameLoader, to match class name.
2137
2138         * Plugins/WebBaseNetscapePluginView.mm:
2139         * Plugins/WebNetscapePluginStream.mm:
2140         * Plugins/WebPluginController.mm:
2141         * WebCoreSupport/WebFrameBridge.mm:
2142         * WebView/WebDataSource.mm:
2143         * WebView/WebFrame.mm:
2144         * WebView/WebPDFView.mm:
2145         * WebView/WebPolicyDelegate.mm:
2146         * WebView/WebView.mm:
2147
2148 2006-10-25  Mark Rowe  <bdash@webkit.org>
2149
2150         Reviewed by Anders.
2151
2152         Build fix for the Buildbot.
2153
2154         * WebView/WebHTMLView.m:
2155         (-[NSArray _addToStyle:fontA:fontB:]): Explicit cast.
2156
2157 2006-10-25  Maciej Stachowiak  <mjs@apple.com>
2158
2159         Reviewed by Anders.
2160         
2161         <rdar://problem/4785575> REGRESSION: form resubmission warning occurs twice, then Safari crashes in autorelease pool
2162         <rdar://problem/4799383> REGRESSION: Crash occurs when dismissing the "Would you like to save this password" sheet
2163
2164         * WebView/WebPolicyDeciderMac.m:
2165         (-[WebPolicyDeciderMac dealloc]): release the listener, don't dealloc it
2166
2167 2006-10-24  Anders Carlsson  <acarlsson@apple.com>
2168
2169         Reviewed by Darin.
2170
2171         * WebKitPrefix.h:
2172         Include FastMalloc.h from C++ code.
2173
2174 2006-10-24  Darin Adler  <darin@apple.com>
2175
2176         Reviewed by Anders.
2177
2178         - converted WebFrameLoaderClient to C++
2179         - renamed frame->frameLoader() function to frame->loader()
2180         - renamed [bridge impl] to [bridge _frame]
2181         - removed some bridge methods
2182
2183         * Plugins/WebNetscapePluginStream.mm:
2184         * WebCoreSupport/WebEditorClient.mm:
2185         * WebCoreSupport/WebFrameLoaderClient.h: Added.
2186         (WebFrameLoaderClient::webFrame):
2187         * WebCoreSupport/WebFrameLoaderClient.mm: Added.
2188         (WebFrameLoaderClient::detachFrameLoader):
2189         (WebFrameLoaderClient::hasWebView):
2190         (WebFrameLoaderClient::hasFrameView):
2191         (WebFrameLoaderClient::hasBackForwardList):
2192         (WebFrameLoaderClient::resetBackForwardList):
2193         (WebFrameLoaderClient::provisionalItemIsTarget):
2194         (WebFrameLoaderClient::loadProvisionalItemFromPageCache):
2195         (WebFrameLoaderClient::invalidateCurrentItemPageCache):
2196         (WebFrameLoaderClient::privateBrowsingEnabled):
2197         (WebFrameLoaderClient::makeDocumentView):
2198         (WebFrameLoaderClient::makeRepresentation):
2199         (WebFrameLoaderClient::setDocumentViewFromPageCache):
2200         (WebFrameLoaderClient::forceLayout):
2201         (WebFrameLoaderClient::forceLayoutForNonHTML):
2202         (WebFrameLoaderClient::updateHistoryForCommit):
2203         (WebFrameLoaderClient::updateHistoryForBackForwardNavigation):
2204         (WebFrameLoaderClient::updateHistoryForReload):
2205         (WebFrameLoaderClient::updateHistoryForStandardLoad):
2206         (WebFrameLoaderClient::updateHistoryForInternalLoad):
2207         (WebFrameLoaderClient::updateHistoryAfterClientRedirect):
2208         (WebFrameLoaderClient::setCopiesOnScroll):
2209         (WebFrameLoaderClient::tokenForLoadErrorReset):
2210         (WebFrameLoaderClient::resetAfterLoadError):
2211         (WebFrameLoaderClient::doNotResetAfterLoadError):
2212         (WebFrameLoaderClient::detachedFromParent1):
2213         (WebFrameLoaderClient::detachedFromParent2):
2214         (WebFrameLoaderClient::detachedFromParent3):
2215         (WebFrameLoaderClient::detachedFromParent4):
2216         (WebFrameLoaderClient::loadedFromPageCache):
2217         (WebFrameLoaderClient::download):
2218         (WebFrameLoaderClient::dispatchIdentifierForInitialRequest):
2219         (WebFrameLoaderClient::dispatchWillSendRequest):
2220         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
2221         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
2222         (WebFrameLoaderClient::dispatchDidReceiveResponse):
2223         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
2224         (WebFrameLoaderClient::dispatchDidFinishLoading):
2225         (WebFrameLoaderClient::dispatchDidFailLoading):
2226         (WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
2227         (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
2228         (WebFrameLoaderClient::dispatchDidCancelClientRedirect):
2229         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2230         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
2231         (WebFrameLoaderClient::dispatchWillClose):
2232         (WebFrameLoaderClient::dispatchDidReceiveIcon):
2233         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
2234         (WebFrameLoaderClient::dispatchDidReceiveTitle):
2235         (WebFrameLoaderClient::dispatchDidCommitLoad):
2236         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
2237         (WebFrameLoaderClient::dispatchDidFailLoad):
2238         (WebFrameLoaderClient::dispatchDidFinishLoad):
2239         (WebFrameLoaderClient::dispatchDidFirstLayout):
2240         (WebFrameLoaderClient::dispatchCreatePage):
2241         (WebFrameLoaderClient::dispatchShow):
2242         (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
2243         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2244         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2245         (WebFrameLoaderClient::dispatchUnableToImplementPolicy):
2246         (WebFrameLoaderClient::dispatchWillSubmitForm):
2247         (WebFrameLoaderClient::dispatchDidLoadMainResource):
2248         (WebFrameLoaderClient::clearLoadingFromPageCache):
2249         (WebFrameLoaderClient::isLoadingFromPageCache):
2250         (WebFrameLoaderClient::revertToProvisionalState):
2251         (WebFrameLoaderClient::setMainDocumentError):
2252         (WebFrameLoaderClient::clearUnarchivingState):
2253         (WebFrameLoaderClient::progressStarted):
2254         (WebFrameLoaderClient::progressCompleted):
2255         (WebFrameLoaderClient::incrementProgress):
2256         (WebFrameLoaderClient::completeProgress):
2257         (WebFrameLoaderClient::setMainFrameDocumentReady):
2258         (WebFrameLoaderClient::startDownload):
2259         (WebFrameLoaderClient::willChangeTitle):
2260         (WebFrameLoaderClient::didChangeTitle):
2261         (WebFrameLoaderClient::committedLoad):
2262         (WebFrameLoaderClient::finishedLoading):
2263         (WebFrameLoaderClient::finalSetupForReplace):
2264         (WebFrameLoaderClient::cancelledError):
2265         (WebFrameLoaderClient::cannotShowURLError):
2266         (WebFrameLoaderClient::interruptForPolicyChangeError):
2267         (WebFrameLoaderClient::cannotShowMIMETypeError):
2268         (WebFrameLoaderClient::fileDoesNotExistError):
2269         (WebFrameLoaderClient::shouldFallBack):
2270         (WebFrameLoaderClient::mainFrameURL):
2271         (WebFrameLoaderClient::setDefersCallbacks):
2272         (WebFrameLoaderClient::willUseArchive):
2273         (WebFrameLoaderClient::isArchiveLoadPending):
2274         (WebFrameLoaderClient::cancelPendingArchiveLoad):
2275         (WebFrameLoaderClient::clearArchivedResources):
2276         (WebFrameLoaderClient::canHandleRequest):
2277         (WebFrameLoaderClient::canShowMIMEType):
2278         (WebFrameLoaderClient::representationExistsForURLScheme):
2279         (WebFrameLoaderClient::generatedMIMETypeForURLScheme):
2280         (WebFrameLoaderClient::elementForEvent):
2281         (WebFrameLoaderClient::createPolicyDecider):
2282         (WebFrameLoaderClient::frameLoadCompleted):
2283         (WebFrameLoaderClient::restoreScrollPositionAndViewState):
2284         (WebFrameLoaderClient::provisionalLoadStarted):
2285         (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent):
2286         (WebFrameLoaderClient::addHistoryItemForFragmentScroll):
2287         (WebFrameLoaderClient::didFinishLoad):
2288         (WebFrameLoaderClient::prepareForDataSourceReplacement):
2289         (WebFrameLoaderClient::createDocumentLoader):
2290         (WebFrameLoaderClient::setTitle):
2291         * WebKit.xcodeproj/project.pbxproj:
2292         * WebView/WebDataSource.mm:
2293         (-[WebDataSource webFrame]):
2294         * WebView/WebFrame.mm:
2295         (frame):
2296         (-[WebFrame _loadItem:withLoadType:]):
2297         (-[WebFrame _reloadForPluginChanges]):
2298         (-[WebFrame _initWithWebFrameView:webView:bridge:]):
2299         (-[WebFrame _frameLoader]):
2300         (-[WebFrame provisionalDataSource]):
2301         (-[WebFrame dataSource]):
2302         (-[WebFrame parentFrame]):
2303         (-[WebFrame _provisionalLoadStarted]):
2304         * WebView/WebFrameInternal.h:
2305         * WebView/WebHTMLRepresentation.m:
2306         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
2307         * WebView/WebHTMLView.m:
2308         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
2309         (-[NSArray validateUserInterfaceItem:]):
2310         (-[NSArray scrollWheel:]):
2311         (-[NSArray acceptsFirstMouse:]):
2312         (-[NSArray shouldDelayWindowOrderingForEvent:]):
2313         (-[NSArray _selectionStartFontAttributesAsRTF]):
2314         (-[NSArray changeBaseWritingDirection:]):
2315         (-[NSArray indent:]):
2316         (-[NSArray outdent:]):
2317         (-[WebHTMLView copy:]):
2318         (-[WebHTMLView cut:]):
2319         (-[WebHTMLView paste:]):
2320         * WebView/WebView.mm:
2321         (-[WebView _dashboardRegions]):
2322         (-[WebView setProhibitsMainFrameScrolling:]):
2323         (-[WebView _setInViewSourceMode:]):
2324         (-[WebView _inViewSourceMode]):
2325         (-[WebView setEditable:]):
2326
2327 2006-10-24  John Sullivan  <sullivan@apple.com>
2328
2329         Reviewed by Kevin Decker
2330         
2331         - fixed <rdar://problem/4801331> "Spelling..." menu item should be "Show/Hide Spelling" post-Tiger, to match AppKit
2332
2333         * WebView/WebHTMLView.m:
2334         (-[NSArray validateUserInterfaceItem:]):
2335         post-Tiger, update the menu item text to "Show Spelling"/"Hide Spelling" based on whether
2336         the spelling panel is already showing. Also, removed else's after returns, and removed
2337         braces around one-line if clauses.
2338         (-[NSArray showGuessPanel:]):
2339         post-Tiger, make this item hide the spelling panel if it's already showing
2340
2341         * English.lproj/Localizable.strings:
2342         updated for this change
2343         
2344 2006-10-24  Timothy Hatcher  <timothy@apple.com>
2345
2346         Reviewed by Anders.
2347
2348         <rdar://problem/4588878> 'WebHTMLView' may not respond to '-_webView'
2349
2350         * Misc/WebNSViewExtras.h:
2351         * Misc/WebNSViewExtras.m:
2352         (-[NSView _webView]):
2353
2354 2006-10-24  Brady Eidson  <beidson@apple.com>
2355
2356         Reviewed by Anders
2357
2358         http://bugs.webkit.org/show_bug.cgi?id=11406 - Crash in [WebFrame dataSource]
2359         In the transition to ObjC++ we lost alot of our free nil checking that we must now do manually
2360         to prevent null dereferencing.
2361
2362         * WebView/WebFrame.mm:
2363         (-[WebFrame provisionalDataSource]):
2364         (-[WebFrame dataSource]):
2365
2366 2006-10-24  John Sullivan  <sullivan@apple.com>
2367
2368         Reviewed by Darin
2369         
2370         Initial plumbing for grammar checking. No actual grammar are checked at this time.
2371
2372         * English.lproj/WebViewEditingContextMenu.nib/classes.nib:
2373         * English.lproj/WebViewEditingContextMenu.nib/info.nib:
2374         * English.lproj/WebViewEditingContextMenu.nib/objects.nib:
2375         Added grammar-checking item, reworded to match changes in framework. This will be used
2376         post-Tiger.
2377
2378         * English.lproj/WebViewEditingContextMenuOld.nib/classes.nib: Added.
2379         * English.lproj/WebViewEditingContextMenuOld.nib/info.nib: Added.
2380         * English.lproj/WebViewEditingContextMenuOld.nib/objects.nib: Added.
2381         Copy of WebViewEditingContextMenu.nib, unchanged. This will be used on Tiger.
2382
2383         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
2384         (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
2385         Choose the right context menu based on BUILDING_ON_TIGER.
2386         
2387         * WebView/WebPreferenceKeysPrivate.h:
2388         declare grammar-related NSUserDefault value
2389
2390         * WebView/WebViewPrivate.h:
2391         declare grammar-related methods
2392
2393         * WebView/WebView.mm:
2394         declare static BOOL grammarCheckingEnabled
2395         (-[WebViewPrivate init]):
2396         initialize grammarCheckingEnabled to NSUserDefaults value
2397         (-[WebView validateUserInterfaceItem:]):
2398         validate toggleGrammarChecking: menu item
2399         (-[WebView isGrammarCheckingEnabled]):
2400         return value of grammarCheckingEnabled
2401         (-[WebView setGrammarCheckingEnabled:]):
2402         set value of grammarCheckingEnabled, call frame to remove existing bad grammar markers
2403         (-[WebView toggleGrammarChecking:]):
2404         flip the value
2405         
2406         * WebView/WebFrameInternal.h:
2407         * WebView/WebFrame.mm:
2408         (-[WebFrame _unmarkAllBadGrammar]):
2409         new placeholder method, does nothing yet
2410         
2411         * WebView/WebHTMLViewInternal.h:
2412         declare grammar-related methods
2413
2414         * WebView/WebHTMLView.m:
2415         (-[NSArray validateUserInterfaceItem:]):
2416         validate toggleGrammarChecking: menu item
2417         (-[WebHTMLView isGrammarCheckingEnabled]):
2418         new method, calls through to WebView
2419         (-[WebHTMLView setGrammarCheckingEnabled:]):
2420         ditto
2421         (-[WebHTMLView toggleGrammarChecking:]):
2422         ditto
2423                 
2424         * English.lproj/StringsNotToBeLocalized.txt:
2425         Updated for these changes
2426         
2427         * WebKit.xcodeproj/project.pbxproj:
2428         updated for new files        
2429
2430 2006-10-23  Darin Adler  <darin@apple.com>
2431
2432         Reviewed by Geoff.
2433
2434         - converted WebDocumentLoader to C++
2435
2436         * Plugins/WebPluginController.mm:
2437         (-[WebPluginController pluginView:receivedResponse:]):
2438         * WebKit.xcodeproj/project.pbxproj:
2439         * WebView/WebDataSource.mm:
2440         (-[WebDataSourcePrivate dealloc]):
2441         (-[WebDataSource _mainDocumentError]):
2442         (-[WebDataSource _URL]):
2443         (-[WebDataSource _loadFromPageCache:]):
2444         (-[WebDataSource _bridge]):
2445         (-[WebDataSource _URLForHistory]):
2446         (-[WebDataSource _documentLoader]):
2447         (-[WebDataSource _initWithDocumentLoader:]):
2448         (-[WebDataSource initWithRequest:]):
2449         (-[WebDataSource data]):
2450         (-[WebDataSource webFrame]):
2451         (-[WebDataSource initialRequest]):
2452         (-[WebDataSource request]):
2453         (-[WebDataSource response]):
2454         (-[WebDataSource textEncodingName]):
2455         (-[WebDataSource isLoading]):
2456         (-[WebDataSource unreachableURL]):
2457         (-[WebDataSource webArchive]):
2458         * WebView/WebDataSourceInternal.h:
2459         * WebView/WebDocumentLoaderMac.h:
2460         * WebView/WebDocumentLoaderMac.mm:
2461         (WebDocumentLoaderMac::WebDocumentLoaderMac):
2462         (WebDocumentLoaderMac::setDataSource):
2463         (WebDocumentLoaderMac::dataSource):
2464         (WebDocumentLoaderMac::attachToFrame):
2465         (WebDocumentLoaderMac::detachFromFrame):
2466         * WebView/WebFrame.mm:
2467         (-[WebFrame _createItem:]):
2468         (-[WebFrame _loadItem:withLoadType:]):
2469         (-[WebFrame _addChild:]):
2470         (dataSource):
2471         (-[WebFrame _dataSourceForDocumentLoader:]):
2472         (-[WebFrame _addDocumentLoader:toUnarchiveState:]):
2473         (-[WebFrame loadArchive:]):
2474         (-[WebFrame _updateHistoryForReload]):
2475         (-[WebFrame _updateHistoryForStandardLoad]):
2476         (-[WebFrame _updateHistoryForInternalLoad]):
2477         (-[WebFrame _dispatchIdentifierForInitialRequest:fromDocumentLoader:]):
2478         (-[WebFrame _dispatchResource:willSendRequest:redirectResponse:fromDocumentLoader:]):
2479         (-[WebFrame _dispatchDidReceiveAuthenticationChallenge:forResource:fromDocumentLoader:]):
2480         (-[WebFrame _dispatchDidCancelAuthenticationChallenge:forResource:fromDocumentLoader:]):
2481         (-[WebFrame _dispatchResource:didReceiveResponse:fromDocumentLoader:]):
2482         (-[WebFrame _dispatchResource:didReceiveContentLength:fromDocumentLoader:]):
2483         (-[WebFrame _dispatchResource:didFinishLoadingFromDocumentLoader:]):
2484         (-[WebFrame _dispatchResource:didFailLoadingWithError:fromDocumentLoader:]):
2485         (-[WebFrame _dispatchDidLoadMainResourceForDocumentLoader:]):
2486         (-[WebFrame _clearLoadingFromPageCacheForDocumentLoader:]):
2487         (-[WebFrame _isDocumentLoaderLoadingFromPageCache:]):
2488         (-[WebFrame _makeRepresentationForDocumentLoader:]):
2489         (-[WebFrame _revertToProvisionalStateForDocumentLoader:]):
2490         (-[WebFrame _setMainDocumentError:forDocumentLoader:]):
2491         (-[WebFrame _clearUnarchivingStateForLoader:]):
2492         (-[WebFrame _willChangeTitleForDocument:]):
2493         (-[WebFrame _didChangeTitleForDocument:]):
2494         (-[WebFrame _finishedLoadingDocument:]):
2495         (-[WebFrame _committedLoadWithDocumentLoader:data:]):
2496         (-[WebFrame _documentLoader:setMainDocumentError:]):
2497         (-[WebFrame _finalSetupForReplaceWithDocumentLoader:]):
2498         (-[WebFrame _createDocumentLoaderWithRequest:]):
2499         (-[WebFrame _provisionalLoadStarted]):
2500         * WebView/WebFrameInternal.h:
2501         * WebView/WebHTMLRepresentation.m:
2502         (-[WebHTMLRepresentation title]):
2503         * WebView/WebView.mm:
2504         (-[WebView _mainFrameOverrideEncoding]):
2505
2506 2006-10-23  Geoffrey Garen  <ggaren@apple.com>
2507
2508         RS by Maciej.
2509         
2510         Gave ObjC++ files .mm extension instead of .m.
2511
2512         * WebCoreSupport/WebPageBridge.m: Removed.
2513         * WebKit.xcodeproj/project.pbxproj:
2514         * WebView/WebDocumentLoaderMac.m: Removed.
2515
2516 2006-10-23  Darin Adler  <darin@apple.com>
2517
2518         Reviewed by Maciej.
2519
2520         - converted WebFrameLoader to C++
2521
2522         * History/WebHistoryItem.m:
2523         (+[WebHistoryItem _closeObjectsInPendingPageCaches]):
2524         * Plugins/WebBaseNetscapePluginView.mm:
2525         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
2526         * Plugins/WebNetscapePluginStream.mm:
2527         (-[WebNetscapePluginStream start]):
2528         (-[WebNetscapePluginStream stop]):
2529         * Plugins/WebPluginController.mm:
2530         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
2531         (-[WebPluginController pluginView:receivedResponse:]):
2532         * WebCoreSupport/WebFrameBridge.h:
2533         * WebKit.xcodeproj/project.pbxproj:
2534         * WebView/WebDataSource.mm:
2535         (-[WebDataSource _loadFromPageCache:]):
2536         (-[WebDataSource _webView]):
2537         (-[WebDataSource webFrame]):
2538         * WebView/WebDocumentLoaderMac.h:
2539         * WebView/WebDocumentLoaderMac.m:
2540         (-[WebDocumentLoaderMac dealloc]):
2541         (-[WebDocumentLoaderMac attachToFrame]):
2542         (-[WebDocumentLoaderMac detachFromFrame]):
2543         * WebView/WebFrame.mm:
2544         (+[WebFrame _timeOfLastCompletedLoad]):
2545         (-[WebFrame _loadItem:withLoadType:]):
2546         (-[WebFrame _loadURL:referrer:intoChild:]):
2547         (-[WebFrame _currentBackForwardListItemToResetTo]):
2548         (-[WebFrame _itemForRestoringDocState]):
2549         (-[WebFrame _frameLoader]):
2550         (-[WebFrame _firstLayoutDone]):
2551         (-[WebFrame _loadType]):
2552         (-[WebFrame provisionalDataSource]):
2553         (-[WebFrame dataSource]):
2554         (-[WebFrame loadRequest:]):
2555         (-[WebFrame loadArchive:]):
2556         (-[WebFrame stopLoading]):
2557         (-[WebFrame reload]):
2558         (-[WebFrame _updateHistoryForCommit]):
2559         (-[WebFrame _updateHistoryForReload]):
2560         (-[WebFrame _updateHistoryForInternalLoad]):
2561         (-[WebFrame _deliverArchivedResourcesAfterDelay]):
2562         (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]):
2563         (-[WebFrame _deliverArchivedResources]):
2564         (-[WebFrame _prepareForDataSourceReplacement]):
2565         (-[WebFrame _provisionalLoadStarted]):
2566         * WebView/WebFrameInternal.h:
2567         * WebView/WebHTMLView.m:
2568         (-[WebHTMLView _clearLastHitViewIfSelf]):
2569         (-[WebHTMLView _updateMouseoverWithEvent:]):
2570         (-[NSArray removeMouseMovedObserverUnconditionally]):
2571         (-[NSArray removeMouseMovedObserver]):
2572         (-[NSArray viewWillMoveToWindow:]):
2573         (-[NSArray viewDidMoveToWindow]):
2574         (-[WebHTMLView _canMakeTextSmaller]):
2575         (-[WebHTMLView _canMakeTextLarger]):
2576         (-[WebHTMLView _canMakeTextStandardSize]):
2577         * WebView/WebPDFView.mm:
2578         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2579         * WebView/WebView.mm:
2580         (-[WebView _close]):
2581         (-[WebView setDefersCallbacks:]):
2582         (-[WebView setCustomTextEncodingName:]):
2583
2584 2006-10-23  Geoffrey Garen  <ggaren@apple.com>
2585
2586         Reviewed by Bradee.
2587
2588         Moved some page-level operations from WebFrameBridge to WebPageBridge.
2589
2590         * WebCoreSupport/WebFrameBridge.m:
2591         * WebCoreSupport/WebPageBridge.m:
2592         (-[WebPageBridge createModalDialogWithURL:referrer:]):
2593         (-[WebPageBridge canRunModal]):
2594         (-[WebPageBridge canRunModalNow]):
2595         (-[WebPageBridge runModal]):
2596         * WebKit.xcodeproj/project.pbxproj: Made WebPageBridge.m ObjC++ to support
2597         WebCore #includes.
2598
2599 2006-10-23  John Sullivan  <sullivan@apple.com>
2600
2601         * WebKitPrefix.h:
2602         Removed redundant definition of BUILDING_ON_TIGER that I just added. It turns out this had
2603         already been added between the last time I updated in this tree and when I needed it locally.
2604
2605 2006-10-23  John Sullivan  <sullivan@apple.com>
2606
2607         Reviewed by Anders
2608
2609         * WebKit.xcodeproj/project.pbxproj:
2610         Move WebKitPrefix.h from Misc group to top level, to match WebCore
2611         
2612         * WebKitPrefix.h:
2613         defined BUILDING_ON_TIGER a la WebCore, in preparation for future use of post-Tiger API
2614
2615 2006-10-23  Timothy Hatcher  <timothy@apple.com>
2616
2617         Reviewed by Darin.
2618
2619         Rename the now ObjC++ files to be .mm and remove the explicit file types.
2620
2621         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
2622         (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
2623         * English.lproj/StringsNotToBeLocalized.txt:
2624         * Plugins/WebBaseNetscapePluginView.m: Removed.
2625         * Plugins/WebNetscapePluginStream.m: Removed.
2626         * Plugins/WebPluginController.m: Removed.
2627         * WebCoreSupport/WebFrameBridge.m: Removed.
2628         * WebKit.xcodeproj/project.pbxproj:
2629         * WebView/WebDataSource.m: Removed.
2630         * WebView/WebFrame.m: Removed.
2631         * WebView/WebFrameView.m: Removed.
2632         * WebView/WebPDFView.m: Removed.
2633         * WebView/WebPolicyDelegate.m: Removed.
2634         * WebView/WebView.m: Removed.
2635
2636 2006-10-23  Timothy Hatcher  <timothy@apple.com>
2637
2638         Reviewed by Darin.
2639
2640         Move the undef try/catch to WebKitPrefix.h and include algorithm so we get
2641         exception_defines.h and so the undef of try/catch works.
2642
2643         Break off the BGRA to ARGB code into WebGraphicsExtras.c, this lets
2644         WebBaseNetscapePluginView.m safely compile as ObjC++ and not cause the Accelerate
2645         framework to complain about C++ exceptions being disabled.
2646
2647         * Misc/WebGraphicsExtras.c: Added.
2648         (WebConvertBGRAToARGB):
2649         * Misc/WebGraphicsExtras.h: Added.
2650         * Plugins/WebBaseNetscapePluginView.m:
2651         (-[WebBaseNetscapePluginView _aglOffscreenImageForDrawingInRect:]):
2652         * WebKit.xcodeproj/project.pbxproj:
2653         * WebKitPrefix.h:
2654         * WebView/WebView.m:
2655
2656 2006-10-22  Sam Weinig  <sam.weinig@gmail.com>
2657
2658         Reviewed by Tim H.
2659
2660         - Add DOMHTMLFormElementPrivate.h to the project.
2661
2662         * MigrateHeaders.make:
2663
2664 2006-10-21  Darin Adler  <darin@apple.com>
2665
2666         Reviewed by Adele.
2667
2668         - convert WebLoader and its 3 subclasses to C++
2669
2670         * Plugins/WebNetscapePluginStream.h:
2671         * Plugins/WebNetscapePluginStream.m:
2672         (-[WebNetscapePluginStream dealloc]):
2673         (-[WebNetscapePluginStream finalize]):
2674         (-[WebNetscapePluginStream start]):
2675         (-[WebNetscapePluginStream cancelLoadWithError:]):
2676         (-[WebNetscapePluginStream stop]):
2677         * WebCoreSupport/WebFrameBridge.m:
2678         (-[WebFrameBridge canRunModalNow]):
2679         * WebView/WebFrame.m:
2680         (-[WebFramePrivate dealloc]):
2681         (-[WebFramePrivate finalize]):
2682         (frame): Changed from uppercase to lowercase so that it won't conflict
2683         with the WebCore class named Frame.
2684         (-[WebFrame _firstChildFrame]):
2685         (-[WebFrame _lastChildFrame]):
2686         (-[WebFrame _previousSiblingFrame]):
2687         (-[WebFrame _nextSiblingFrame]):
2688         (-[WebFrame _traverseNextFrameStayWithin:]):
2689         (-[WebFrame _immediateChildFrameNamed:]):
2690         (-[WebFrame _nextFrameWithWrap:]):
2691         (-[WebFrame _previousFrameWithWrap:]):
2692         (-[WebFrame findFrameNamed:]):
2693         (-[WebFrame parentFrame]):
2694         (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]):
2695         (-[WebFrame _deliverArchivedResourcesAfterDelay]):
2696         (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]):
2697         (-[WebFrame _archiveLoadPendingForLoader:]):
2698         (-[WebFrame _cancelPendingArchiveLoadForLoader:]):
2699         (-[WebFrame _clearArchivedResources]):
2700         (-[WebFrame _deliverArchivedResources]):
2701
2702 2006-10-21  Darin Adler  <darin@apple.com>
2703
2704         Reviewed by Anders.
2705
2706         - fix http://bugs.webkit.org/show_bug.cgi?id=10328
2707           REGRESSION: frame leak reported by buildbot
2708
2709         * WebCoreSupport/WebEditorClient.mm:
2710         (WebEditorClient::WebEditorClient): Don't retain the web view.
2711         (WebEditorClient::~WebEditorClient): Don't release the web view.
2712         (WebEditorClient::setWebView): Ditto.
2713
2714         * WebCoreSupport/WebFrameBridge.m:
2715         (-[WebFrameBridge finishInitializingWithFrameName:view:]): Added. Common code for use by both
2716         init methods below.
2717         (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): Changed to use new method.
2718         Also added comment pointing out design flaw -- we attach the client to the web view here,
2719         but we need to be sure to detach in case the web view is deallocated first.
2720         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): Ditto.
2721
2722 2006-10-21  Darin Adler  <darin@apple.com>
2723
2724         Reviewed by Adam.
2725
2726         - http://bugs.webkit.org/show_bug.cgi?id=11376
2727           build scripts should invoke make with "-j" option for multiple processors
2728
2729         * WebKit.xcodeproj/project.pbxproj: Pass -j `sysctl -n hw.ncpu` to make.
2730
2731 2006-10-21  Timothy Hatcher  <timothy@apple.com>
2732
2733         Reviewed by Geoff.
2734
2735         <rdar://problem/4478625> HTML Editing: Basic table editing and culling
2736
2737         Initial implementaltion of table deletion user interface:
2738         * Adds a new editing delegate method, webView:shouldShowDeleteInterfaceForElement:.
2739         * The new delegate method is called from the new shouldShowDeleteInterface EditorClient function.
2740
2741         * DefaultDelegates/WebDefaultEditingDelegate.m:
2742         (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]):
2743         * WebCoreSupport/WebEditorClient.h:
2744         * WebCoreSupport/WebEditorClient.mm:
2745         (WebEditorClient::WebEditorClient):
2746         (WebEditorClient::shouldDeleteRange):
2747         (WebEditorClient::shouldShowDeleteInterface):
2748         * WebKit.xcodeproj/project.pbxproj:
2749         * WebView/WebEditingDelegatePrivate.h: Added.
2750
2751 2006-10-21  Alice Liu  <alice.liu@apple.com>
2752
2753         Reviewed by Maciej.
2754
2755         fix leaks.
2756
2757         * WebCoreSupport/WebEditorClient.mm:
2758         (WebEditorClient::setWebView):
2759         only change webview if its different
2760
2761         * WebCoreSupport/WebFrameBridge.m:
2762         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
2763         actually use the client allocated in the line above instead of
2764         allocation again, duh. 
2765
2766 2006-10-21  Alice Liu  <alice.liu@apple.com>
2767
2768         Build fix.
2769
2770         * WebCoreSupport/WebEditorClient.h:
2771         * WebCoreSupport/WebEditorClient.mm:
2772         (WebEditorClient::setWebView):
2773
2774 2006-10-20  Alice Liu  <alice.liu@apple.com>
2775
2776         Reviewed by Tim Hatcher.
2777
2778         Fixed a problem where the webview passed to the EditorClient wasn't valid yet.  
2779
2780         * WebCoreSupport/WebEditorClient.h:
2781         (WebEditorClient::setWebView):
2782         added webview setter
2783
2784         * WebCoreSupport/WebEditorClient.mm:
2785         (WebEditorClient::WebEditorClient):
2786         add default constructor
2787
2788         * WebCoreSupport/WebFrameBridge.m:
2789         (-[WebFrameBridge initMainFrameWithPage:frameName:view:]):
2790         use [page webView] since _webview isn't valid yet
2791         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
2792         use webview setter on editorclient
2793
2794 2006-10-20  David Hyatt  <hyatt@apple.com>
2795
2796         Tweak cache sizes so that they are back to the way they were,
2797         except for < 512, which will stay doubled.
2798
2799         Reviewed by Tim H.
2800
2801         * WebCoreSupport/WebFrameBridge.m:
2802         (-[WebFrameBridge getObjectCacheSize]):
2803
2804 2006-10-20  Alice Liu  <alice.liu@apple.com>
2805
2806         Reviewed by Maciej.
2807
2808         Adding knowledge of EditorClient to WebKit
2809
2810         * WebCoreSupport/WebEditorClient.h: Added.
2811
2812         * WebCoreSupport/WebEditorClient.mm: Added.
2813         (WebEditorClient::WebEditorClient):
2814         (WebEditorClient::~WebEditorClient):
2815         (WebEditorClient::shouldDeleteRange):
2816         Implementation of mac EditorClient
2817
2818         * WebCoreSupport/WebFrameBridge.m:
2819         (-[WebFrameBridge initMainFrameWithPage:frameName:view:]):
2820         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
2821         create an editor client to pass down the chain of constructors
2822
2823         * WebKit.xcodeproj/project.pbxproj:
2824         Added related EditorClient files
2825
2826         * WebKitPrefix.h:
2827         Added tiger build flag in order to make certain private headers from webcore compile successfully
2828
2829 2006-10-20  Darin Adler  <darin@apple.com>
2830
2831         - rolled out my loader change; caused world leak and possibly a plug-in crash
2832
2833 2006-10-20  Darin Adler  <darin@apple.com>
2834
2835         Reviewed by Adele.
2836
2837         - convert WebLoader and its 3 subclasses to C++
2838
2839         * Plugins/WebNetscapePluginStream.h:
2840         * Plugins/WebNetscapePluginStream.m:
2841         (-[WebNetscapePluginStream dealloc]):
2842         (-[WebNetscapePluginStream finalize]):
2843         (-[WebNetscapePluginStream start]):
2844         (-[WebNetscapePluginStream cancelLoadWithError:]):
2845         (-[WebNetscapePluginStream stop]):
2846         * WebCoreSupport/WebFrameBridge.m:
2847         (-[WebFrameBridge canRunModalNow]):
2848         * WebView/WebFrame.m:
2849         (-[WebFramePrivate dealloc]):
2850         (-[WebFramePrivate finalize]):
2851         (frame): Changed from uppercase to lowercase so that it won't conflict
2852         with the WebCore class named Frame.
2853         (-[WebFrame _firstChildFrame]):
2854         (-[WebFrame _lastChildFrame]):
2855         (-[WebFrame _previousSiblingFrame]):
2856         (-[WebFrame _nextSiblingFrame]):
2857         (-[WebFrame _traverseNextFrameStayWithin:]):
2858         (-[WebFrame _immediateChildFrameNamed:]):
2859         (-[WebFrame _nextFrameWithWrap:]):
2860         (-[WebFrame _previousFrameWithWrap:]):
2861         (-[WebFrame findFrameNamed:]):
2862         (-[WebFrame parentFrame]):
2863         (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]):
2864         (-[WebFrame _deliverArchivedResourcesAfterDelay]):
2865         (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]):
2866         (-[WebFrame _archiveLoadPendingForLoader:]):
2867         (-[WebFrame _cancelPendingArchiveLoadForLoader:]):
2868         (-[WebFrame _clearArchivedResources]):
2869         (-[WebFrame _deliverArchivedResources]):
2870
2871 2006-10-20  John Sullivan  <sullivan@apple.com>
2872
2873         Reviewed by Darin
2874         
2875         - fixed <rdar://problem/4794935> setAcceptsMouseMovedEvents: is called for every layout, 
2876           taking ~1% on the PLT test
2877
2878         * WebView/WebHTMLView.m:
2879         (-[NSArray layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
2880         Don't call setAcceptsMouseMovedEvents: and WKSetNSWindowShouldPostEventNotifications() here
2881         because this is called too often.
2882         
2883         * WebView/WebView.m:
2884         (-[WebView viewWillMoveToWindow:]):
2885         Do call them here, because this is guaranteed to be called at least once for each window
2886         containing a webview, but isn't called too often. Also restructured this method a little.
2887
2888 2006-10-19  Timothy Hatcher  <timothy@apple.com>
2889
2890         Reviewed by Anders.
2891
2892         Bug 11366: Web Inspector should show user agent style rules
2893         http://bugs.webkit.org/show_bug.cgi?id=11366
2894
2895         * WebInspector/WebInspector.m:
2896         (-[WebInspector init]):
2897         (-[WebInspector showOptionsMenu]):
2898         (-[WebInspector _toggleShowUserAgentStyles:]):
2899         * WebInspector/WebInspectorInternal.h:
2900         * WebInspector/webInspector/inspector.js:
2901
2902 2006-10-19  Brady Eidson <beidson@apple.com>
2903
2904         Build fix - 2gig is on that pesky signed/unsigned limit...
2905
2906         * WebCoreSupport/WebFrameBridge.m:
2907         (-[WebFrameBridge getObjectCacheSize]):
2908
2909 2006-10-19  Brady Eidson  <beidson@apple.com>
2910
2911         Reviewed by Hyatt.
2912
2913         Death to 16777216.  Long live 33554432.
2914         (Cache size changed needs to be reflected in localization file)
2915
2916         * English.lproj/StringsNotToBeLocalized.txt:
2917
2918 2006-10-19  Brady Eidson  <beidson@apple.com>
2919
2920         Reviewed by Hyatt
2921
2922         Added an larger in-memory level of cache for machines with 2+gb ram
2923
2924         * WebCoreSupport/WebFrameBridge.m:
2925         (-[WebFrameBridge getObjectCacheSize]):
2926
2927 2006-10-19  Brady Eidson  <beidson@apple.com>
2928
2929         Reviewed by Hyatt
2930
2931         Double the default memory cache size
2932
2933         * WebView/WebPreferences.m:
2934         (+[WebPreferences initialize]):
2935
2936 2006-10-19  John Sullivan  <sullivan@apple.com>
2937
2938         Reviewed by Kevin D and Geoff
2939
2940         * WebKit.xcodeproj/project.pbxproj:
2941         version wars
2942         
2943         Cleaned up this file, as follows:
2944         - renamed all file-internal methods to start with underscores
2945         - moved all file-internal methods into a FileInternal category block, and alphabetized them
2946         - grouped all other methods by where/how they were defined (delegate methods, protocol methods, overrides, etc.)
2947         - removed unstylish braces around one-line clauses
2948         
2949         * WebView/WebPDFView.m:
2950         (_applicationInfoForMIMEType):
2951         (_PDFSelectionsAreEqual):
2952         (+[WebPDFView supportedMIMETypes]):
2953         (-[WebPDFView setPDFDocument:]):
2954         (-[WebPDFView dealloc]):
2955         (-[WebPDFView centerSelectionInVisibleArea:]):
2956         (-[WebPDFView scrollPageDown:]):
2957         (-[WebPDFView scrollPageUp:]):
2958         (-[WebPDFView scrollLineDown:]):
2959         (-[WebPDFView scrollLineUp:]):
2960         (-[WebPDFView scrollToBeginningOfDocument:]):
2961         (-[WebPDFView scrollToEndOfDocument:]):
2962         (-[WebPDFView jumpToSelection:]):
2963         (-[WebPDFView acceptsFirstResponder]):
2964         (-[WebPDFView becomeFirstResponder]):
2965         (-[WebPDFView hitTest:]):
2966         (-[WebPDFView initWithFrame:]):
2967         (-[WebPDFView menuForEvent:]):
2968         (-[WebPDFView setNextKeyView:]):
2969         (-[WebPDFView viewDidMoveToWindow]):
2970         (-[WebPDFView viewWillMoveToWindow:]):
2971         (-[WebPDFView validateUserInterfaceItem:]):
2972         (-[WebPDFView copy:]):
2973         (-[WebPDFView takeFindStringFromSelection:]):
2974         (-[WebPDFView canPrintHeadersAndFooters]):
2975         (-[WebPDFView printOperationWithPrintInfo:]):
2976         (-[WebPDFView viewWillMoveToHostWindow:]):
2977         (-[WebPDFView viewDidMoveToHostWindow]):
2978         (-[WebPDFView elementAtPoint:]):
2979         (-[WebPDFView elementAtPoint:allowShadowContent:]):
2980         (-[WebPDFView searchFor:direction:caseSensitive:wrap:]):
2981         (-[WebPDFView viewState]):
2982         (-[WebPDFView setViewState:]):
2983         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
2984         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2985         (+[WebPDFView _PDFPreviewViewClass]):
2986         (+[WebPDFView _PDFViewClass]):
2987         (-[WebPDFView _anyPDFTagsFoundInMenu:]):
2988         (-[WebPDFView _applyPDFDefaults]):
2989         (-[WebPDFView _fakeKeyEventWithFunctionKey:]):
2990         (-[WebPDFView _menuItemsFromPDFKitForEvent:]):
2991         (-[WebPDFView _openWithFinder:]):
2992         (-[WebPDFView _path]):
2993         (-[WebPDFView _PDFSubview]):
2994         (-[WebPDFView _pointIsInSelection:]):
2995         (-[WebPDFView _receivedPDFKitLaunchNotification:]):
2996         (-[WebPDFView _scaledAttributedString:]):
2997         (-[WebPDFView _trackFirstResponder]):
2998         (-[PDFPrefUpdatingProxy forwardInvocation:]):
2999         (-[PDFPrefUpdatingProxy methodSignatureForSelector:]):
3000
3001 2006-10-19  John Sullivan  <sullivan@apple.com>
3002
3003         Reviewed by Kevin Decker
3004         
3005         - fixed <rdar://problem/4792761> Safari should use fancier embedded PDFKit stuff when it's available
3006
3007         * WebKit.xcodeproj/project.pbxproj:
3008         version wars
3009         
3010         * WebView/WebFrameView.m:
3011         (-[WebFrameView _makeDocumentViewForDataSource:]):
3012         initialize document view with frame view's rect instead of empty rect. This avoids some problems when 
3013         constructing view hierarchies from nibs
3014         
3015         * WebView/WebPreferencesPrivate.h:
3016         declare new _usePDFPreviewView and _setUsePDFPreviewView:, used for debugging
3017         * WebView/WebPreferenceKeysPrivate.h:
3018         declare new preference key string
3019         * WebView/WebPreferences.m:
3020         (+[WebPreferences initialize]):
3021         initialize new preference to true (we will by default use the new view if it's available)
3022         (-[WebPreferences _usePDFPreviewView]):
3023         new accessor for new pref
3024         (-[WebPreferences _setUsePDFPreviewView:]):
3025         ditto
3026
3027         * WebView/WebPDFView.h:
3028         new previewView ivar
3029         
3030         * WebView/WebPDFView.m:
3031         (+[WebPDFView PDFPreviewViewClass]):
3032         new method, returns class to use for fancier embedded PDFKit stuff, or nil if fancy stuff isn't available
3033         (-[WebPDFView initWithFrame:]):
3034         now tries to use fancier embedded PDFKit stuff if it's available and the pref is set to use it; falls back
3035         to old behavior otherwise
3036         (-[WebPDFView dealloc]):
3037         release new previewView ivar (retained in initWithFrame:)
3038         (-[WebPDFView viewWillMoveToWindow:]):
3039         stop observing PDFKit notification when we're removed from window
3040         (-[WebPDFView viewDidMoveToWindow]):
3041         start observing PDFKit notification when we're added to window
3042         (-[WebPDFView _receivedPDFKitLaunchNotification:]):
3043         respond to this new PDFKit notification by opening the document via NSWorkspace
3044         
3045         * English.lproj/StringsNotToBeLocalized.txt:
3046         updated for lots of recent changes
3047         
3048 2006-10-19  Sam Weinig  <sam.weinig@gmail.com>
3049
3050         Reviewed by ap.
3051
3052         Win32 build fix.
3053
3054         * COM/WebFrame.cpp:
3055         (WebFrame::initWithName):
3056         (WebFrame::createNewWindow):
3057
3058 2006-10-19  Mitz Pettel  <mitz@webkit.org>
3059
3060         Reviewed and landed by ap.
3061
3062         - fixed the inspector's tree popup
3063
3064         * WebInspector/webInspector/inspector.html:
3065
3066 2006-10-18  Sam Weinig  <sam.weinig@gmail.com>
3067
3068         Reviewed by Maciej.
3069
3070         Win32 build fix.
3071
3072         * COM/WebFrame.cpp:
3073         (WebFrame::createNewWindow):
3074         * COM/WebFrame.h:
3075
3076 2006-10-18  Anders Carlsson  <acarlsson@apple.com>
3077
3078         Reviewed by Adam.
3079
3080         http://bugs.webkit.org/show_bug.cgi?id=11000
3081         REGRESSION (r16101): css2.1/t0801-c412-hz-box-00-b-a is failing because the QuickTime plugin is taking over but not rendering the png
3082         
3083         * WebCoreSupport/WebFrameBridge.m:
3084         (-[WebFrameBridge determineObjectFromMIMEType:URL:]):
3085         Return ObjectElementFrame if the MIME type is one of the image ones we support.
3086
3087 2006-10-17  Justin Garcia  <justin.garcia@apple.com>
3088
3089         Reviewed by harrison
3090         
3091         <rdar://problem/4765600>
3092         REGRESSION: Mail.app: smart deletion of words does not work
3093         
3094         Regressed when we pushed selecion expansion down into WebCore.  It's OK
3095         to try a smart delete from _deleteWithDirection:, which is called by
3096         deleteFoward: and deleteBackward: if the current selection is a 
3097         range.
3098     
3099         * WebView/WebHTMLView.m:
3100         (-[NSArray _deleteWithDirection:granularity:killRing:isTypingAction:]):
3101
3102 2006-10-13  Justin Garcia  <justin.garcia@apple.com>
3103
3104         Reviewed by harrison
3105         
3106         <rdar://problem/3655385>
3107         Editing: -indent: method unimplemented
3108
3109         * WebView/WebHTMLView.m:
3110         (-[NSArray validateUserInterfaceItem:]): Only allow indent:/outdent: in
3111         richly editable areas.
3112         (-[NSArray indent:]):
3113         (-[NSArray outdent:]):
3114
3115 2006-10-13  Maciej Stachowiak  <mjs@apple.com>
3116
3117         Not reviewed, build fix.
3118         
3119         * icu/unicode/putil.h: Added - needed for build if you don't have apple internal headers.
3120
3121 2006-10-13  Maciej Stachowiak  <mjs@apple.com>
3122
3123         Not reviewed, build fix.
3124         
3125         * icu/unicode/ustring.h: Added - needed for build if you don't have apple internal headers.
3126
3127 2006-10-13  Maciej Stachowiak  <mjs@apple.com>
3128
3129         Reviewed by Anders.
3130         
3131         - add a bunch of casts to get this compiling with older Xcode versions
3132         
3133         (I used static_cast so it will be easier to find and remove these once we have completely moved
3134         on to a new enough compiler version.)
3135
3136         * Plugins/WebBaseNetscapePluginView.m:
3137         (+[WebBaseNetscapePluginView getCarbonEvent:]):
3138         (-[WebBaseNetscapePluginView getCarbonEvent:withEvent:]):
3139         (-[WebBaseNetscapePluginView fixWindowPort]):
3140         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3141         (-[WebBaseNetscapePluginView _createWindowlessAGLContext]):
3142         (-[WebBaseNetscapePluginView _reshapeAGLWindow]):
3143         (-[WebBaseNetscapePluginView _aglOffscreenImageForDrawingInRect:]):
3144         * WebKit.xcodeproj/project.pbxproj:
3145
3146 2006-10-13  Kevin McCullough  <KMcCullough@apple.com>
3147
3148         Changed by Darin, reviewed by me.
3149
3150         * Plugins/WebNetscapePluginStream.m: Fixed case of import so we can compile on
3151         case-sensitive file system.
3152
3153 2006-10-13  Darin Adler  <darin@apple.com>
3154
3155         Reviewed by Adele.
3156
3157         - converted WebFormState from Objective-C to C++
3158
3159         * ForwardingHeaders: Added an entire copy of WebCore's forwarding headers here.
3160         We should eventually come up with a more-elegant solution.
3161
3162         * WebKit.xcodeproj/project.pbxproj: Added ForwardingHeaders to the include paths.
3163         Converted many files from Objective-C to Objective-C++. In a later check-in, I'll
3164         rename them to .mm instead of .m. Removed C-only warning options for now. In a
3165         later check-in I will add these back in a way that omits them for C++.
3166
3167         * Plugins/WebPluginContainerCheck.m: Updated for header changes.
3168
3169         * WebView/WebFrameInternal.h: Updated for header changes. Removed WebFrameLoaderClient category
3170         so this file can still be used by Objective-C code (not just Objective-C++).
3171
3172         * WebView/WebFrame.m: Put WebFrameLoaderClient category in here.
3173         (-[WebFrame _loadItem:withLoadType:]): Changed to use 0 instead of nil for FormState and fixed
3174         enum code for C++ compatibility.
3175         (-[WebFrame _initWithWebFrameView:webView:bridge:]): Added call to setFrameLoaderClient: here.
3176         (-[WebFrame _updateHistoryForCommit]): Fixed enum code for C++ compatibility.
3177         (-[WebFrame _updateHistoryForReload]): Ditto.
3178
3179         * WebCoreSupport/WebFrameBridge.m:
3180         (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): Removed call to setFrameLoaderClient:.
3181         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): Ditto.
3182         (-[WebFrameBridge _retrieveKeyboardUIModeFromPreferences:]): Fixed enum code for C++ compatibility.
3183         (-[WebFrameBridge runModal]): Changed code to not use "namespace" as a local variable name.
3184
3185         * WebView/WebPDFView.m: Added extern "C" so this can compile as Objective-C++.
3186
3187 2006-10-12  Maciej Stachowiak  <mjs@apple.com>
3188
3189         Reviewed by Oliver.
3190         
3191         - liberate more WebKit code down to WebCore
3192
3193         * WebCoreSupport/WebFrameBridge.h:
3194         * WebCoreSupport/WebFrameBridge.m:
3195
3196 2006-10-12  Adele Peterson  <adele@apple.com>
3197
3198         Reviewed by Maciej.
3199
3200         WebKit part of fix for <rdar://problem/4450613> need a means to attach user data to any menu that is popuped up in HTML
3201
3202         Added private delegate method for clients that want access to a PopupMenu's NSMenu.
3203
3204         * DefaultDelegates/WebDefaultUIDelegate.m: (-[NSApplication webView:willPopupMenu:]):
3205         * WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge willPopupMenu:]):
3206         * WebView/WebUIDelegatePrivate.h:
3207
3208 2006-10-12  MorganL  <morganl.webkit@yahoo.com>
3209
3210         Reviewed/landed by Adam.
3211
3212         Fixes http://bugs.webkit.org/show_bug.cgi?id=11264
3213         Windows build busted
3214
3215         * COM/WebFrame.cpp:
3216         (WebFrame::receivedResponse):
3217
3218 2006-10-11  Darin Adler  <darin@apple.com>
3219
3220         Reviewed by Adele.
3221
3222         - preparations for making more code C++
3223
3224         * WebKitPrefix.h: Fixed ifdef so that C++ files get all the precompiled stuff
3225         that non-C++ files get.
3226
3227         * Misc/WebKitLogging.h:
3228         * Misc/WebKitSystemBits.h:
3229         * Misc/WebLocalizableStrings.h:
3230         * WebCoreSupport/WebSystemInterface.h:
3231         Added extern "C".
3232
3233         * Misc/WebNSViewExtras.h:
3234         * WebView/WebDataSource.m: (addTypesFromClass):
3235         * WebView/WebFrameView.m: (addTypesFromClass):
3236         Eliminated use of the identifier "class".
3237
3238         * WebView/WebView.m: (-[WebView _goToItem:withLoadType:]): Added a type cast.
3239
3240         * Plugins/WebBaseNetscapePluginView.m: Added lots of type casts.
3241
3242 2006-10-10  Brady Eidson  <beidson@apple.com>
3243
3244         Reviewed by Maciej.
3245
3246         Moved WebFrameLoader into WebCoreFrameBridge
3247
3248         * WebCoreSupport/WebFrameBridge.h:
3249         * WebCoreSupport/WebFrameBridge.m:
3250         (-[WebFrameBridge initMainFrameWithPage:frameName:view:]):
3251         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
3252         (-[WebFrameBridge dealloc]):
3253         (-[WebFrameBridge setTitle:]):
3254         (-[WebFrameBridge receivedData:textEncodingName:]):
3255         (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
3256         (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
3257         (-[WebFrameBridge objectLoadedFromCacheWithURL:response:data:]):
3258         (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
3259         (-[WebFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
3260         (-[WebFrameBridge reportClientRedirectCancelled:]):
3261         (-[WebFrameBridge close]):
3262         (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):
3263         (-[WebFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
3264         (-[WebFrameBridge tokenizerProcessedData]):
3265         (-[WebFrameBridge frameDetached]):
3266         (-[WebFrameBridge didFirstLayout]):
3267         (-[WebFrameBridge notifyIconChanged:]):
3268         (-[WebFrameBridge originalRequestURL]):
3269         (-[WebFrameBridge isLoadTypeReload]):
3270
3271 2006-10-10  Adele Peterson  <adele@apple.com>
3272
3273         Reviewed by Beth.
3274
3275         Removed handleAutoscrollForMouseDragged.  Except for autoscroll caused by drag and drop, all other
3276         autoscrolling should be done in WebCore instead of in AppKit.
3277
3278         * WebCoreSupport/WebFrameBridge.m:
3279         * WebView/WebHTMLView.m:
3280         * WebView/WebHTMLViewPrivate.h:
3281
3282 2006-10-10  Darin Adler  <darin@apple.com>
3283
3284         - corrected an archive regression caused by loader refactoring
3285           (pointed out by Graham Dennis)
3286
3287         * WebView/WebFrame.m: (-[WebFrame _deliverArchivedResourcesAfterDelay]):
3288         Fix selector name.
3289
3290 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
3291
3292         Rubber stamped by Eric.
3293         
3294         - moved a whole bunch of stuff over to WebCore - updated includes appropriately
3295
3296         * Loader/LoaderNSURLExtras.h: Removed.
3297         * Loader/LoaderNSURLExtras.m: Removed.
3298         * Loader/WebDataProtocol.h: Removed.
3299         * Loader/WebDataProtocol.m: Removed.
3300         * Loader/WebDocumentLoader.h: Removed.
3301         * Loader/WebDocumentLoader.m: Removed.
3302         * Loader/WebFormDataStream.h: Removed.
3303         * Loader/WebFormDataStream.m: Removed.
3304         * Loader/WebFormState.h: Removed.
3305         * Loader/WebFormState.m: Removed.
3306         * Loader/WebFrameLoader.h: Removed.
3307         * Loader/WebFrameLoader.m: Removed.
3308         * Loader/WebFrameLoaderClient.h: Removed.
3309         * Loader/WebLoader.h: Removed.
3310         * Loader/WebLoader.m: Removed.
3311         * Loader/WebMainResourceLoader.h: Removed.
3312         * Loader/WebMainResourceLoader.m: Removed.
3313         * Loader/WebNetscapePlugInStreamLoader.h: Removed.
3314         * Loader/WebNetscapePlugInStreamLoader.m: Removed.
3315         * Loader/WebPlugInStreamLoaderDelegate.h: Removed.
3316         * Loader/WebPolicyDecider.h: Removed.
3317         * Loader/WebPolicyDecider.m: Removed.
3318         * Loader/WebSubresourceLoader.h: Removed.
3319         * Loader/WebSubresourceLoader.m: Removed.
3320         * Misc/WebNSURLExtras.m:
3321         * Plugins/WebBaseNetscapePluginStream.h:
3322         * Plugins/WebBaseNetscapePluginView.m:
3323         * Plugins/WebNetscapePluginStream.m:
3324         * Plugins/WebPluginContainerCheck.m:
3325         * Plugins/WebPluginController.m:
3326         * WebCoreSupport/WebFrameBridge.m:
3327         * WebKit.xcodeproj/project.pbxproj:
3328         * WebView/WebDataSource.m:
3329         * WebView/WebDocumentLoaderMac.h:
3330         * WebView/WebFrame.m:
3331         * WebView/WebFrameInternal.h:
3332         * WebView/WebHTMLView.m:
3333         * WebView/WebPolicyDeciderMac.h:
3334         * WebView/WebPolicyDelegate.m:
3335         * WebView/WebView.m:
3336
3337 2006-10-10  Mark Rowe  <bdash@webkit.org>
3338
3339         Reviewed by Maciej.
3340
3341         Fix crash on launch in nightly builds after r16965.
3342
3343         Safari will sometimes call through to -[NSURL _webkit_canonicalize] before creating a WebView.  If this happens,
3344         InitWebCoreSystemInterface has not yet been called so the call to wkNSURLProtocolClassForReqest is via a garbage
3345         pointer.
3346
3347         * Misc/WebNSURLExtras.m:
3348         (-[NSURL _webkit_canonicalize]): Ensure InitWebCoreSystemInterface is called prior to canonicalURL.
3349
3350 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
3351
3352         Reviewed by Oliver.
3353         
3354         - split out some NSURL extras to be moved to WebCore
3355
3356         * Loader/LoaderNSURLExtras.h: Added.
3357         * Loader/LoaderNSURLExtras.m: Added.
3358         (urlByRemovingComponent):
3359         (urlByRemovingFragment):
3360         (urlOriginalDataAsString):
3361         (urlOriginalData):
3362         (urlWithData):
3363         (WebCFAutorelease):
3364         (urlWithDataRelativeToURL):
3365         (urlByRemovingResourceSpecifier):
3366         (urlIsFileURL):
3367         (stringIsFileURL):
3368         (urlIsEmpty):
3369         (canonicalURL):
3370         * Loader/WebFrameLoader.m:
3371         (-[WebFrameLoader shouldReloadForCurrent:andDestination:]):
3372         (setHTTPReferrer):
3373         (-[WebFrameLoader commitProvisionalLoad:]):
3374         (-[WebFrameLoader _notifyIconChanged:]):
3375         (-[WebFrameLoader didChangeTitleForDocument:]):
3376         (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]):
3377         (-[WebFrameLoader safeLoadURL:]):
3378         * Misc/WebNSURLExtras.m:
3379         (+[NSURL _web_URLWithData:]):
3380         (+[NSURL _web_URLWithData:relativeToURL:]):
3381         (-[NSURL _web_originalData]):
3382         (-[NSURL _web_originalDataAsString]):
3383         (-[NSURL _web_isEmpty]):
3384         (-[NSURL _webkit_canonicalize]):
3385         (-[NSURL _webkit_URLByRemovingComponent:]):
3386         (-[NSURL _webkit_URLByRemovingFragment]):
3387         (-[NSURL _webkit_URLByRemovingResourceSpecifier]):
3388         (-[NSURL _webkit_isFileURL]):
3389         (-[NSString _webkit_isFileURL]):
3390         * WebCoreSupport/WebSystemInterface.m:
3391         (InitWebCoreSystemInterface):
3392         * WebKit.xcodeproj/project.pbxproj:
3393
3394 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
3395
3396         Reviewed by Anders.
3397         
3398         - sever final WebFrame dependencies
3399
3400         * Loader/WebFrameLoader.h:
3401         * Loader/WebFrameLoader.m:
3402         (-[WebFrameLoader initWithFrame:client:]):
3403         (-[WebFrameLoader defersCallbacksChanged]):
3404         (-[WebFrameLoader subframeIsLoading]):
3405         (-[WebFrameLoader transitionToCommitted:]):
3406         (-[WebFrameLoader detachChildren]):
3407         (-[WebFrameLoader checkLoadComplete]):
3408
3409 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
3410
3411         Reviewed by Brady.
3412         
3413         - convert more WebFrameLoader stuff to be independent of WebFrame
3414
3415         * Loader/WebFrameLoader.h:
3416         * Loader/WebFrameLoader.m:
3417         (-[WebFrameLoader stopLoadingSubframes]):
3418         (-[WebFrameLoader _receivedMainResourceError:complete:]):
3419         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
3420         (-[WebFrameLoader closeOldDataSources]):
3421         (-[WebFrameLoader isHostedByObjectElement]):
3422         (-[WebFrameLoader isLoadingMainFrame]):
3423         (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
3424         (-[WebFrameLoader transitionToCommitted:]):
3425         (-[WebFrameLoader checkLoadCompleteForThisFrame]):
3426         (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
3427         (-[WebFrameLoader loadRequest:inFrameNamed:]):
3428         (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
3429         (-[WebFrameLoader actionInformationForNavigationType:event:originalURL:]):
3430         (-[WebFrameLoader client]):
3431         * Loader/WebFrameLoaderClient.h:
3432         * WebView/WebDataSource.m:
3433         (-[WebDataSource _webView]):
3434         (-[WebDataSource webFrame]):
3435         * WebView/WebFrame.m:
3436         (-[WebFrame _dispatchCreateWebViewWithRequest:]):
3437
3438 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
3439
3440         Reviewed by Anders and Oliver.
3441         
3442         - move a bunch of WebFrame methods from the Internal category to the WebFrameLoader protocol
3443
3444         * Loader/WebFrameLoader.h:
3445         * Loader/WebFrameLoader.m:
3446         (-[WebFrameLoader loadRequest:]):
3447         (-[WebFrameLoader loadRequest:inFrameNamed:]):
3448         * Loader/WebFrameLoaderClient.h:
3449         * WebView/WebFrame.m:
3450         (-[WebFrame loadRequest:]):
3451         (-[WebFrame _dispatchDidCommitLoadForFrame]):
3452         (-[WebFrame _hasFrameView]):
3453         (-[WebFrame _frameLoadCompleted]):
3454         (-[WebFrame _restoreScrollPositionAndViewState]):
3455         (-[WebFrame _setTitle:forURL:]):
3456         (-[WebFrame _createDocumentLoaderWithRequest:]):
3457         (-[WebFrame _prepareForDataSourceReplacement]):
3458         (-[WebFrame _didFinishLoad]):
3459         (-[WebFrame _addHistoryItemForFragmentScroll]):
3460         (-[WebFrame _shouldTreatURLAsSameAsCurrent:]):
3461         (-[WebFrame _provisionalLoadStarted]):
3462         * WebView/WebFrameInternal.h:
3463
3464 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
3465
3466         Not reviewed, build fix.
3467         
3468         - added forgotten files
3469
3470         * Loader/WebPolicyDecider.h: Added.
3471         * Loader/WebPolicyDecider.m: Added.
3472         (-[WebPolicyDecider invalidate]):
3473
3474 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
3475
3476         Reviewed by Brady.
3477         
3478         - add wrapper for WebPolicyDecisionListener so we can remove the dependency from WebFrameLoader.
3479
3480         * Loader/WebFrameLoader.h:
3481         * Loader/WebFrameLoader.m:
3482         (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]):
3483         (-[WebFrameLoader cancelContentPolicy]):
3484         (-[WebFrameLoader invalidatePendingPolicyDecisionCallingDefaultAction:]):
3485         (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]):
3486         (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]):
3487         (-[WebFrameLoader continueAfterWillSubmitForm:]):
3488         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
3489         * Loader/WebFrameLoaderClient.h:
3490         * WebKit.xcodeproj/project.pbxproj:
3491         * WebView/WebFrame.m:
3492         (-[WebFrame _createPolicyDeciderWithTarget:action:]):
3493         (decisionListener):
3494         (-[WebFrame _dispatchDecidePolicyForMIMEType:request:decider:]):
3495         (-[WebFrame _dispatchDecidePolicyForNewWindowAction:request:newFrameName:decider:]):
3496         (-[WebFrame _dispatchDecidePolicyForNavigationAction:request:decider:]):
3497         (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]):
3498         * WebView/WebPolicyDeciderMac.h: Added.
3499         * WebView/WebPolicyDeciderMac.m: Added.
3500         (-[WebPolicyDeciderMac initWithTarget:action:]):
3501         (-[WebPolicyDeciderMac dealloc]):
3502         (-[WebPolicyDeciderMac decisionListener]):
3503         (-[WebPolicyDeciderMac invalidate]):
3504
3505 2006-10-09  Brady Eidson  <beidson@apple.com>
3506
3507         Reviewed by John
3508
3509         http://bugs.webkit.org/show_bug.cgi?id=11195
3510         Added the WebIconDatabaseDelegate.  This allows the ability to allow customization of 
3511         IconDatabase behavior in the future, starting now with the ability to override the 
3512         default icon fairly flexibly
3513
3514         * Misc/WebIconDatabase.h: Added setIconDatabaseDelegate:
3515         * Misc/WebIconDatabase.m:
3516         (-[WebIconDatabase iconForURL:withSize:cache:]): Call the delegate for the default icon if delegate is set
3517         (-[WebIconDatabase defaultIconForURL:withSize:]): Get the default icon through the delegate if available, built-in if not
3518         (-[WebIconDatabase setDelegate:]):
3519         (-[WebIconDatabase delegate]):
3520         * Misc/WebIconDatabaseDelegate.h: Added.
3521         * Misc/WebIconDatabasePrivate.h: Added the delegate, nuked an unused class definition
3522         * WebKit.xcodeproj/project.pbxproj:
3523
3524 2006-10-09  Darin Adler  <darin@apple.com>
3525
3526         Reviewed by Maciej.
3527
3528         - eliminated uses of WebResource and WebView from WebFrameLoader
3529
3530         * Loader/WebFrameLoader.h:
3531         * Loader/WebFrameLoader.m:
3532         (-[WebFrameLoader setDefersCallbacks:]):
3533         (-[WebFrameLoader stopLoading]):
3534         (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
3535         (-[WebFrameLoader archiveLoadPendingForLoader:]):
3536         (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]):
3537         (-[WebFrameLoader _canShowMIMEType:]):
3538         (-[WebFrameLoader _representationExistsForURLScheme:]):
3539         (-[WebFrameLoader _generatedMIMETypeForURLScheme:]):
3540         (-[WebFrameLoader loadDocumentLoader:]):
3541         (-[WebFrameLoader continueAfterNavigationPolicy:]):
3542         (-[WebFrameLoader sendRemainingDelegateMessagesWithIdentifier:response:length:error:]):
3543         (-[WebFrameLoader actionInformationForNavigationType:event:originalURL:]):
3544         * Loader/WebFrameLoaderClient.h:
3545         * Loader/WebMainResourceLoader.m:
3546         (-[WebMainResourceLoader continueAfterContentPolicy:response:]):
3547         (-[WebMainResourceLoader loadWithRequestNow:]):
3548         * WebView/WebFrame.m:
3549         (-[WebFramePrivate dealloc]):
3550         (-[WebFrame loadRequest:]):
3551         (-[WebFrame loadArchive:]):
3552         (-[WebFrame _canUseResourceForRequest:]):
3553         (-[WebFrame _canUseResourceWithResponse:]):
3554         (-[WebFrame _deliverArchivedResourcesAfterDelay]):
3555         (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]):
3556         (-[WebFrame _archiveLoadPendingForLoader:]):
3557         (-[WebFrame _cancelPendingArchiveLoadForLoader:]):
3558         (-[WebFrame _clearArchivedResources]):
3559         (-[WebFrame _deliverArchivedResources]):
3560         (-[WebFrame _setDefersCallbacks:]):
3561         (-[WebFrame _canHandleRequest:]):
3562         (-[WebFrame _canShowMIMEType:]):
3563         (-[WebFrame _representationExistsForURLScheme:]):
3564         (-[WebFrame _generatedMIMETypeForURLScheme:]):
3565         (-[WebFrame _elementForEvent:]):
3566
3567 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
3568
3569         Reviewed by Darin.
3570         
3571         - do all the stuff that setting the referrer should
3572
3573         * Loader/WebFrameLoader.m:
3574         (setHTTPReferrer):
3575         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
3576         (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
3577         * WebKit.xcodeproj/project.pbxproj:
3578
3579 2006-10-09  Brady Eidson  <beidson@apple.com>
3580
3581         Reviewed by Maciej
3582
3583         Fix to elminate WebIconDatabaseBridge.h from WebFrameLoader
3584
3585         * Loader/WebFrameLoader.m:
3586         (-[WebFrameLoader _notifyIconChanged:]):
3587         * WebCoreSupport/WebIconDatabaseBridge.m:
3588         (+[WebIconDatabaseBridge createInstance]):
3589
3590 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
3591
3592         Reviewed by Darin.
3593         
3594         (Was reviewed as part of a larger patch but it looks like Darin already did the rest of it)
3595         
3596         - avoid a needless use of WebFrame
3597
3598         * Loader/WebFrameLoader.m:
3599         (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
3600
3601 2006-10-09  Brady Eidson  <beidson@apple.com>
3602
3603         A *real* fake fix for the layouttest problem until the real fix
3604
3605         * Loader/WebFrameLoader.m:
3606         (-[WebFrameLoader _notifyIconChanged:]):
3607
3608 2006-10-09  Brady Eidson  <beidson@apple.com>
3609
3610         Quick layouttest fix until I make the real fix
3611
3612         * Loader/WebFrameLoader.m:
3613
3614 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
3615
3616         Reviewed by Darin.
3617         
3618         - wean WebFrameLoader from WebDataSource private stuff
3619         
3620         (actually just tweaks tot he above to make merging my future
3621         patches easier since Darin did a lot of the same stuff)
3622
3623         * Loader/WebDocumentLoader.h:
3624         * Loader/WebDocumentLoader.m:
3625         (-[WebDocumentLoader URLForHistory]):
3626         * Loader/WebFrameLoader.m:
3627         (-[WebFrameLoader _loadRequest:archive:]):
3628         (-[WebFrameLoader revertToProvisionalWithDocumentLoader:]):
3629         (-[WebFrameLoader documentLoader:setMainDocumentError:]):
3630         (-[WebFrameLoader finalSetupForReplaceWithDocumentLoader:]):
3631         (-[WebFrameLoader didChangeTitleForDocument:]):
3632         (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
3633         * Loader/WebFrameLoaderClient.h:
3634         * WebView/WebDataSource.m:
3635         (-[WebDataSource _URLForHistory]):
3636         * WebView/WebFrame.m:
3637         (-[WebFrame _addDocumentLoader:toUnarchiveState:]):
3638         (-[WebFrame _revertToProvisionalStateForDocumentLoader:]):
3639         (-[WebFrame _setMainDocumentError:forDocumentLoader:]):
3640         (-[WebFrame _clearUnarchivingStateForLoader:]):
3641
3642 2006-10-09  Darin Adler  <darin@apple.com>
3643
3644         Reviewed by Brady.
3645
3646         - eliminated WebFrameLoader dependency on WebDataSourceInternal.h,
3647           WebIconDatabasePrivate.h, and WebKitErrorsPrivate.h, along with
3648           most but not all references to WebView
3649
3650         * Loader/WebFrameLoader.h:
3651         * Loader/WebFrameLoader.m:
3652         (-[WebFrameLoader removePlugInStreamLoader:]):
3653         (-[WebFrameLoader _receivedMainResourceError:complete:]):
3654         (-[WebFrameLoader _notifyIconChanged:]):
3655         (-[WebFrameLoader cancelledErrorWithRequest:]):
3656         (-[WebFrameLoader fileDoesNotExistErrorWithResponse:]):
3657         (-[WebFrameLoader handleUnimplementablePolicyWithError:]):
3658         (-[WebFrameLoader cannotShowMIMETypeWithResponse:]):
3659         (-[WebFrameLoader interruptForPolicyChangeErrorWithRequest:]):
3660         (-[WebFrameLoader _loadRequest:archive:]):
3661         (-[WebFrameLoader finishedLoadingDocument:]):
3662         (-[WebFrameLoader committedLoadWithDocumentLoader:data:]):
3663         (-[WebFrameLoader revertToProvisionalWithDocumentLoader:]):
3664         (-[WebFrameLoader documentLoader:setMainDocumentError:]):
3665         (-[WebFrameLoader finalSetupForReplaceWithDocumentLoader:]):
3666         (-[WebFrameLoader didChangeTitleForDocument:]):
3667         (-[WebFrameLoader continueAfterNavigationPolicy:]):
3668         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
3669         (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
3670         (-[WebFrameLoader transitionToCommitted:]):
3671         (-[WebFrameLoader checkLoadCompleteForThisFrame]):
3672         (-[WebFrameLoader requestFromDelegateForRequest:identifier:error:]):
3673         (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
3674         (-[WebFrameLoader checkLoadComplete]):
3675         * Loader/WebFrameLoaderClient.h:
3676         * Loader/WebMainResourceLoader.m:
3677         (-[WebMainResourceLoader continueAfterContentPolicy:response:]):
3678         * WebView/WebFrame.m:
3679         (-[WebFrame _addDocumentLoader:toUnarchiveState:]):
3680         (-[WebFrame _formDelegate]):
3681         (-[WebFrame _finishedLoadingDocument:]):
3682         (-[WebFrame _committedLoadWithDocumentLoader:data:]):
3683         (-[WebFrame _revertToProvisionalWithDocumentLoader:]):
3684         (-[WebFrame _documentLoader:setMainDocumentError:]):
3685         (-[WebFrame _finalSetupForReplaceWithDocumentLoader:]):
3686         (-[WebFrame _URLForHistoryForDocumentLoader:]):
3687         (-[WebFrame _cancelledErrorWithRequest:]):
3688         (-[WebFrame _cannotShowURLErrorWithRequest:]):
3689         (-[WebFrame _interruptForPolicyChangeErrorWithRequest:]):
3690         (-[WebFrame _cannotShowMIMETypeErrorWithResponse:]):
3691         (-[WebFrame _fileDoesNotExistErrorWithResponse:]):
3692         (-[WebFrame _shouldFallBackForError:]):
3693         (-[WebFrame _hasWebView]):
3694         (-[WebFrame _mainFrameURL]):
3695         * WebView/WebFrameInternal.h:
3696
3697 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
3698
3699         Reviewed, landed, tweaked a bit by Darin.
3700
3701         - removed most uses of WebFrameBridge from WebFrameLoader
3702           (WebCoreFrameBridge use is OK)
3703
3704         * Loader/WebDocumentLoader.m:
3705         (-[WebDocumentLoader bridge]):
3706         * Loader/WebFrameLoader.h:
3707         * Loader/WebFrameLoader.m:
3708         (-[WebFrameLoader initWithFrame:client:]):
3709         (-[WebFrameLoader defersCallbacksChanged]):
3710         (-[WebFrameLoader defersCallbacks]):
3711         (-[WebFrameLoader provisionalLoadStarted]):
3712         (-[WebFrameLoader stopLoadingSubframes]):
3713         (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]):
3714         (-[WebFrameLoader _receivedMainResourceError:complete:]):
3715         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
3716         (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]):
3717         (-[WebFrameLoader closeOldDataSources]):
3718         (-[WebFrameLoader commitProvisionalLoad:]):
3719         (-[WebFrameLoader bridge]):
3720         (-[WebFrameLoader _handleFallbackContent]):
3721         (-[WebFrameLoader _finishedLoading]):
3722         (-[WebFrameLoader reload]):
3723         (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]):
3724         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
3725         (-[WebFrameLoader transitionToCommitted:]):
3726         (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
3727         (-[WebFrameLoader loadRequest:inFrameNamed:]):
3728         (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
3729         (-[WebFrameLoader detachFromParent]):
3730         (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
3731         (-[WebFrameLoader safeLoadURL:]):
3732         (-[WebFrameLoader actionInformationForLoadType:isFormSubmission:event:originalURL:]):
3733         * WebCoreSupport/WebFrameBridge.m:
3734         (-[WebFrameBridge initMainFrameWithPage:frameName:view:]):
3735         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
3736         * WebView/WebFrame.m:
3737         (-[WebFrame _atMostOneFrameHasSelection]):
3738         * WebView/WebFrameInternal.h:
3739
3740 2006-10-09  Darin Adler  <darin@apple.com>
3741
3742         Reviewed by Brady.
3743
3744         - removed almost all direct use of WebView from WebFrameLoader
3745
3746         * Loader/WebFrameLoader.m:
3747         (-[WebFrameLoader defersCallbacksChanged]):
3748         (-[WebFrameLoader defersCallbacks]):
3749         (-[WebFrameLoader clearProvisionalLoad]):
3750         (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]):
3751         (-[WebFrameLoader _didReceiveResponse:forResource:]):
3752         (-[WebFrameLoader _didReceiveData:contentLength:forResource:]):
3753         (-[WebFrameLoader _didFinishLoadingForResource:]):
3754         (-[WebFrameLoader _didFailLoadingWithError:forResource:]):
3755         (-[WebFrameLoader closeOldDataSources]):
3756         (-[WebFrameLoader _notifyIconChanged:]):
3757         (-[WebFrameLoader prepareForLoadStart]):
3758         (-[WebFrameLoader willChangeTitleForDocument:]):
3759         (-[WebFrameLoader didChangeTitleForDocument:]):
3760         (-[WebFrameLoader continueAfterNewWindowPolicy:]):
3761         (-[WebFrameLoader continueAfterNavigationPolicy:]):
3762         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
3763         (-[WebFrameLoader didFirstLayout]):
3764         (-[WebFrameLoader transitionToCommitted:]):
3765         (-[WebFrameLoader checkLoadCompleteForThisFrame]):
3766         (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
3767         * Loader/WebFrameLoaderClient.h:
3768         * WebKit.xcodeproj/project.pbxproj:
3769         * WebView/WebFrame.m:
3770         (-[WebFrame _currentBackForwardListItemToResetTo]):
3771         (-[WebFrame _hasBackForwardList]):
3772         (-[WebFrame _resetBackForwardList]):
3773         (-[WebFrame _dispatchDidReceiveIcon:]):
3774         (-[WebFrame _dispatchDidStartProvisionalLoadForFrame]):
3775         (-[WebFrame _dispatchDidCommitLoadForFrame]):
3776         (-[WebFrame _dispatchDidFailProvisionalLoadWithError:]):
3777         (-[WebFrame _dispatchDidFailLoadWithError:]):
3778         (-[WebFrame _dispatchDidFinishLoadForFrame]):
3779         (-[WebFrame _progressStarted]):
3780         (-[WebFrame _progressCompleted]):
3781         (-[WebFrame _incrementProgressForIdentifier:response:]):
3782         (-[WebFrame _incrementProgressForIdentifier:data:]):
3783         (-[WebFrame _completeProgressForIdentifier:]):
3784         (-[WebFrame _setMainFrameDocumentReady:]):
3785         (-[WebFrame _willChangeTitleForDocument:]):
3786         (-[WebFrame _didChangeTitleForDocument:]):
3787         (-[WebFrame _startDownloadWithRequest:]):
3788
3789 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
3790
3791         Reviewed by Alice.
3792
3793         - moved WebFormState into Loader directory and tweaked to avoid WebKit dependencies
3794         
3795         * Loader/WebDocumentLoader.h:
3796         * Loader/WebFormState.h: Added.
3797         * Loader/WebFormState.m: Added.
3798         (-[WebFormState initWithForm:values:sourceFrame:]):
3799         (-[WebFormState dealloc]):
3800         (-[WebFormState form]):
3801         (-[WebFormState values]):
3802         (-[WebFormState sourceFrame]):
3803         * Loader/WebFrameLoader.h:
3804         * Loader/WebFrameLoader.m:
3805         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
3806         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
3807         (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
3808         * WebKit.xcodeproj/project.pbxproj:
3809         * WebView/WebFrame.m:
3810         * WebView/WebFrameInternal.h:
3811
3812 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
3813
3814         Reviewed by Oliver.
3815
3816         - remove dependency on WebNSURLRequestExtras.h
3817         
3818         * Loader/WebFrameLoader.h:
3819         * Loader/WebFrameLoader.m:
3820         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
3821         (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
3822         (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
3823
3824 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
3825
3826         Reviewed by Oliver.
3827         
3828         - removed unneeded logging code so I can take WebKitLogging.h out and remove a WebKit dependency
3829
3830         * Loader/WebFrameLoader.m:
3831         (-[WebFrameLoader setState:]):
3832         (-[WebFrameLoader clientRedirectCancelledOrFinished:]):
3833         (-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
3834         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
3835         (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]):
3836         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
3837         (-[WebFrameLoader checkLoadCompleteForThisFrame]):
3838
3839 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
3840
3841         Reviewed by Oliver.
3842         
3843         - remove WebDataSource from the WebFrameLoader interface (and thereby from a lot of internal use)
3844
3845         * Loader/WebDocumentLoader.h:
3846         * Loader/WebDocumentLoader.m:
3847         (-[WebDocumentLoader dealloc]):
3848         (-[WebDocumentLoader initialRequest]):
3849         (-[WebDocumentLoader URL]):
3850         (-[WebDocumentLoader unreachableURL]):
3851         * Loader/WebFrameLoader.h:
3852         * Loader/WebFrameLoader.m:
3853         (-[WebFrameLoader setState:]):
3854         (-[WebFrameLoader startLoading]):
3855         (-[WebFrameLoader startProvisionalLoad:]):
3856         (-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
3857         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
3858         (-[WebFrameLoader opened]):
3859         (-[WebFrameLoader commitProvisionalLoad:]):
3860         (-[WebFrameLoader initialRequest]):
3861         (-[WebFrameLoader _finishedLoading]):
3862         (-[WebFrameLoader _notifyIconChanged:]):
3863         (-[WebFrameLoader _URL]):
3864         (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
3865         (-[WebFrameLoader _checkNavigationPolicyForRequest:andCall:withSelector:]):
3866         (-[WebFrameLoader shouldReloadToHandleUnreachableURLFromRequest:]):
3867         (-[WebFrameLoader _loadRequest:archive:]):
3868         (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
3869         (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]):
3870         (-[WebFrameLoader reload]):
3871         (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]):
3872         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
3873         (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
3874         (-[WebFrameLoader frameLoadCompleted]):
3875         (-[WebFrameLoader transitionToCommitted:]):
3876         (-[WebFrameLoader checkLoadCompleteForThisFrame]):
3877         (-[WebFrameLoader safeLoadURL:]):
3878         * Loader/WebFrameLoaderClient.h:
3879         * Plugins/WebBaseNetscapePluginView.m:
3880         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
3881         * WebCoreSupport/WebFrameBridge.m:
3882         (-[WebFrameBridge originalRequestURL]):
3883         * WebView/WebDataSource.m:
3884         (-[WebDataSource _URL]):
3885         (-[WebDataSource dealloc]):
3886         (-[WebDataSource initialRequest]):
3887         (-[WebDataSource unreachableURL]):
3888         * WebView/WebFrame.m:
3889         (-[WebFrame _loadItem:withLoadType:]):
3890         (-[WebFrame _prepareForDataSourceReplacement]):
3891         (-[WebFrame provisionalDataSource]):
3892         (-[WebFrame dataSource]):
3893         (-[WebFrame _makeDocumentView]):
3894         (-[WebFrame _updateHistoryForReload]):
3895         (-[WebFrame _updateHistoryForStandardLoad]):
3896         (-[WebFrame _updateHistoryForInternalLoad]):
3897         (-[WebFrame _forceLayoutForNonHTML]):
3898         (-[WebFrame _clearLoadingFromPageCacheForDocumentLoader:]):
3899         (-[WebFrame _isDocumentLoaderLoadingFromPageCache:]):
3900         (-[WebFrame _archivedSubresourceForURL:fromDocumentLoader:]):
3901         (-[WebFrame _makeRepresentationForDocumentLoader:]):
3902
3903 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
3904
3905         Reviewed by Darin.
3906
3907         - removed need for WebFrameLoader to now about WebDocumentLoaderMac 
3908
3909         * Loader/WebFrameLoader.m:
3910         (-[WebFrameLoader loadDataSource:withLoadType:formState:]):
3911         * WebView/WebDocumentLoaderMac.h:
3912         * WebView/WebDocumentLoaderMac.m:
3913         (-[WebDocumentLoaderMac setFrameLoader:]):
3914         (-[WebDocumentLoaderMac detachFromFrameLoader]):
3915
3916 2006-10-09  Darin Adler  <darin@apple.com>
3917
3918         Reviewed by Maciej.
3919
3920         - passed calls that require WebScriptDebugServer across the client interface
3921
3922         * Loader/WebFrameLoader.m:
3923         (-[WebFrameLoader _finishedLoading]):
3924         (-[WebFrameLoader documentLoader:mainReceivedCompleteError:]):
3925         * Loader/WebFrameLoaderClient.h:
3926         * WebView/WebFrame.m:
3927         (-[WebFrame _dispatchDidLoadMainResourceForDocumentLoader:]):
3928
3929 2006-10-08  Darin Adler  <darin@apple.com>
3930
3931         Reviewed by Maciej.
3932
3933         - passed calls that require WebHTMLView or WebFrameView calls across
3934           the client interface
3935
3936         * Loader/WebFrameLoader.h:
3937         * Loader/WebFrameLoader.m:
3938         (isCaseInsensitiveEqual):
3939         (isBackForwardLoadType):
3940         (-[WebFrameLoader opened]):
3941         (-[WebFrameLoader cancelledErrorWithRequest:]):
3942         (-[WebFrameLoader fileDoesNotExistErrorWithResponse:]):
3943         (-[WebFrameLoader reload]):
3944         (-[WebFrameLoader transitionToCommitted:]):
3945         * Loader/WebFrameLoaderClient.h:
3946         * WebView/WebFrame.m:
3947         (-[WebFrame _forceLayout]):
3948         (-[WebFrame _setDocumentViewFromPageCache:]):
3949         (-[WebFrame _setCopiesOnScroll]):
3950
3951 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
3952
3953         Reviewed by Darin.
3954         
3955         - pass remaining delegate methods across client interface
3956
3957         * Loader/WebFrameLoader.m:
3958         (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]):
3959         (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]):
3960         (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]):
3961         (-[WebFrameLoader handleUnimplementablePolicyWithErrorCode:forURL:]):
3962         (-[WebFrameLoader didFirstLayout]):
3963         (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
3964         * Loader/WebFrameLoaderClient.h:
3965         * WebView/WebFrame.m:
3966         (-[WebFrame _dispatchDidFirstLayoutInFrame]):
3967         (-[WebFrame _dispatchCreateWebViewWithRequest:]):
3968         (-[WebFrame _dispatchShow]):
3969         (-[WebFrame _dispatchDecidePolicyForMIMEType:request:decisionListener:]):
3970         (-[WebFrame _dispatchDecidePolicyForNewWindowAction:request:newFrameName:decisionListener:]):
3971         (-[WebFrame _dispatchDecidePolicyForNavigationAction:request:decisionListener:]):
3972         (-[WebFrame _dispatchUnableToImplementPolicyWithError:]):
3973
3974 2006-10-08  Darin Adler  <darin@apple.com>
3975
3976         Reviewed by Maciej.
3977
3978         - use WebCoreSystemInterface instead of WebSystemInterface in Loader directory
3979
3980         * Loader/WebFrameLoader.m: Update includes.
3981         (-[WebFrameLoader commitProvisionalLoad:]): Use wk calls istead of WK.
3982         (-[WebFrameLoader _canUseResourceWithResponse:]): Ditto.
3983
3984         * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
3985         Added the three new symbols, and resorted the list.
3986
3987         * Loader/WebDataProtocol.m:
3988         * Loader/WebLoader.m:
3989         * Loader/WebMainResourceLoader.h:
3990         * Loader/WebMainResourceLoader.m:
3991         * Loader/WebNetscapePlugInStreamLoader.h:
3992         * Loader/WebNetscapePlugInStreamLoader.m:
3993         * Loader/WebSubresourceLoader.h:
3994         * Loader/WebSubresourceLoader.m:
3995         Changed import statements to consistently use the "" format.
3996
3997 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
3998
3999         Not reviewed.
4000         
4001         - fix accidental build break due to editing while committing
4002
4003         * Loader/WebFrameLoader.m:
4004
4005 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
4006
4007         Reviewed by Darin.
4008         
4009         - move all WebFrameLoadDelegate methods across client interface
4010
4011         * Loader/WebFrameLoader.m:
4012         (-[WebFrameLoader clientRedirectCancelledOrFinished:]):
4013         (-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
4014         (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]):
4015         (-[WebFrameLoader closeOldDataSources]):
4016         (-[WebFrameLoader _notifyIconChanged:]):
4017         (-[WebFrameLoader prepareForLoadStart]):
4018         (-[WebFrameLoader didChangeTitleForDocument:]):
4019         (-[WebFrameLoader transitionToCommitted:]):
4020         (-[WebFrameLoader checkLoadCompleteForThisFrame]):
4021         * Loader/WebFrameLoaderClient.h:
4022         * WebView/WebFrame.m:
4023         (-[WebFrame _dispatchDidCancelClientRedirectForFrame]):
4024         (-[WebFrame _dispatchWillPerformClientRedirectToURL:delay:fireDate:]):
4025         (-[WebFrame _dispatchDidChangeLocationWithinPageForFrame]):
4026         (-[WebFrame _dispatchWillCloseFrame]):
4027         (-[WebFrame _dispatchDidReceiveIcon:]):
4028         (-[WebFrame _dispatchDidStartProvisionalLoadForFrame]):
4029         (-[WebFrame _dispatchDidReceiveTitle:]):
4030         (-[WebFrame _dispatchDidCommitLoadForFrame]):
4031         (-[WebFrame _dispatchDidFailProvisionalLoadWithError:]):
4032         (-[WebFrame _dispatchDidFailLoadWithError:]):
4033         (-[WebFrame _dispatchDidFinishLoadForFrame]):
4034
4035 2006-10-08  Darin Adler  <darin@apple.com>
4036
4037         Reviewed by Maciej.
4038
4039         - removed some of the WebKit dependencies in WebFrameLoader
4040
4041         * Loader/WebFrameLoader.m:
4042         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
4043         (-[WebFrameLoader _downloadWithLoadingConnection:request:response:proxy:]):
4044         (-[WebFrameLoader reload]):
4045         (-[WebFrameLoader didChangeTitleForDocument:]):
4046         * Loader/WebFrameLoaderClient.h:
4047         * WebView/WebFrame.m:
4048         (-[WebFrame _loadItem:withLoadType:]):
4049         (-[WebFrame _loadURL:referrer:intoChild:]):
4050         (-[WebFrame _setTitle:forURL:]):
4051         (-[WebFrame _downloadWithLoadingConnection:request:response:proxy:]):
4052         * WebView/WebFrameInternal.h:
4053
4054         - some other tweaks
4055
4056         * Misc/WebNSURLRequestExtras.m:
4057         (-[NSMutableURLRequest _web_setHTTPReferrer:]):
4058         (-[NSMutableURLRequest _web_setHTTPUserAgent:]):
4059
4060 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
4061
4062         Reviewed by Darin.
4063         
4064         - pass all WebResourceLoadDelegate methods across client, removing need to include related headers
4065
4066         * Loader/WebFrameLoader.m:
4067         (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]):
4068         (-[WebFrameLoader _didReceiveAuthenticationChallenge:forResource:]):
4069         (-[WebFrameLoader _didCancelAuthenticationChallenge:forResource:]):
4070         (-[WebFrameLoader _didReceiveResponse:forResource:]):
4071         (-[WebFrameLoader _didReceiveData:contentLength:forResource:]):
4072         (-[WebFrameLoader _didFinishLoadingForResource:]):
4073         (-[WebFrameLoader _didFailLoadingWithError:forResource:]):
4074         (-[WebFrameLoader sendRemainingDelegateMessagesWithIdentifier:response:length:error:]):
4075         (-[WebFrameLoader requestFromDelegateForRequest:identifier:error:]):
4076         * Loader/WebFrameLoaderClient.h:
4077         * WebView/WebFrame.m:
4078         (-[WebFrame _dispatchDidHandleOnloadEventsForFrame]):
4079         (-[WebFrame _dispatchDidReceiveServerRedirectForProvisionalLoadForFrame]):
4080         (-[WebFrame _dispatchIdentifierForInitialRequest:fromDocumentLoader:]):
4081         (-[WebFrame _dispatchResource:willSendRequest:redirectResponse:fromDocumentLoader:]):
4082         (-[WebFrame _dispatchDidReceiveAuthenticationChallenge:forResource:fromDocumentLoader:]):
4083         (-[WebFrame _dispatchDidCancelAuthenticationChallenge:forResource:fromDocumentLoader:]):
4084         (-[WebFrame _dispatchResource:didReceiveResponse:fromDocumentLoader:]):
4085         (-[WebFrame _dispatchResource:didReceiveContentLength:fromDocumentLoader:]):
4086         (-[WebFrame _dispatchResource:didFinishLoadingFromDocumentLoader:]):
4087         (-[WebFrame _dispatchResource:didFailLoadingWithError:fromDocumentLoader:]):
4088
4089 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
4090
4091         Reviewed by Darin.
4092         
4093         - started adding some _dispatch methods to WebFrameLoaderClient for delegate dispatch
4094
4095         * Loader/WebFrameLoader.m:
4096         (-[WebFrameLoader startLoading]):
4097         (-[WebFrameLoader didReceiveServerRedirectForProvisionalLoadForFrame]):
4098         * Loader/WebFrameLoaderClient.h:
4099         * WebCoreSupport/WebFrameBridge.m:
4100         (-[WebFrameBridge handledOnloadEvents]):
4101         * WebView/WebFrame.m:
4102         (dataSource):
4103         (-[WebFrame _dataSourceForDocumentLoader:]):
4104         (-[WebFrame _dispatchDidHandleOnloadEventsForFrame]):
4105         (-[WebFrame _dispatchDidReceiveServerRedirectForProvisionalLoadForFrame]):
4106         (-[WebFrame _dispatchIdentifierForInitialRequest:fromDocumentLoader:]):
4107         * WebView/WebFrameInternal.h:
4108
4109 2006-10-08  Darin Adler  <darin@apple.com>
4110
4111         Reviewed by Maciej.
4112
4113         - moved more methods to WebFrameLoader from WebFrame
4114
4115         * Loader/WebFrameLoader.h:
4116         * Loader/WebFrameLoader.m:
4117         (-[WebFrameLoader defersCallbacksChanged]):
4118         (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]):
4119         (-[WebFrameLoader setState:]):
4120         (-[WebFrameLoader clearProvisionalLoad]):
4121         (-[WebFrameLoader markLoadComplete]):
4122         (-[WebFrameLoader commitProvisionalLoad]):
4123         (-[WebFrameLoader stopLoading]):
4124         (-[WebFrameLoader startProvisionalLoad:]):
4125         (-[WebFrameLoader setupForReplace]):
4126         (-[WebFrameLoader _identifierForInitialRequest:]):
4127         (-[WebFrameLoader _finishedLoadingResource]):
4128         (-[WebFrameLoader _receivedError:]):
4129         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
4130         (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]):
4131         (-[WebFrameLoader opened]):
4132         (-[WebFrameLoader commitProvisionalLoad:]):
4133         (-[WebFrameLoader _finishedLoading]):
4134         (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
4135         (-[WebFrameLoader _loadRequest:archive:]):
4136         (-[WebFrameLoader reload]):
4137         (-[WebFrameLoader documentLoader:mainReceivedCompleteError:]):
4138         (-[WebFrameLoader subframeIsLoading]):
4139         (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]):
4140         (-[WebFrameLoader continueAfterNewWindowPolicy:]):
4141         (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]):
4142         (-[WebFrameLoader sendRemainingDelegateMessagesWithIdentifier:response:length:error:]):
4143         (-[WebFrameLoader loadRequest:inFrameNamed:]):
4144         (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
4145         (-[WebFrameLoader detachChildren]):
4146         (-[WebFrameLoader detachFromParent]):
4147         (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
4148         (-[WebFrameLoader safeLoadURL:]):
4149         (-[WebFrameLoader actionInformationForLoadType:isFormSubmission:event:originalURL:]):
4150         (-[WebFrameLoader actionInformationForNavigationType:event:originalURL:]):
4151         (-[WebFrameLoader checkLoadComplete]):
4152         * Loader/WebFrameLoaderClient.h:
4153         * Loader/WebSubresourceLoader.m:
4154         (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]):
4155         * WebCoreSupport/WebFrameBridge.m:
4156         (-[WebFrameBridge close]):
4157         (-[WebFrameBridge tokenizerProcessedData]):
4158         (-[WebFrameBridge frameDetached]):
4159         * WebView/WebDataSourceInternal.h:
4160         * WebView/WebFrame.m:
4161         (-[WebFrame _loadItem:withLoadType:]):
4162         (-[WebFrame _prepareForDataSourceReplacement]):
4163         (-[WebFrame _detachedFromParent1]):
4164         (-[WebFrame _detachedFromParent2]):
4165         (-[WebFrame _detachedFromParent3]):
4166         (-[WebFrame _detachedFromParent4]):
4167         (-[WebFrame _updateHistoryAfterClientRedirect]):
4168         (-[WebFrame _loadedFromPageCache]):
4169         * WebView/WebFrameInternal.h:
4170         * WebView/WebPDFView.m:
4171         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
4172         * WebView/WebView.m:
4173         (-[WebView _close]):
4174         (-[WebView setDefersCallbacks:]):
4175
4176 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
4177
4178         Reviewed by Darin.
4179         
4180         - avoid need for WebKitSystemInterface in loader code, via WebCore cover for wkSupportsMultipartXMixedReplace
4181
4182         * Loader/WebDocumentLoader.m:
4183         (-[WebDocumentLoader initWithRequest:]):
4184         * Loader/WebMainResourceLoader.m:
4185         * Loader/WebSubresourceLoader.m:
4186         (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]):
4187         * WebCoreSupport/WebSystemInterface.m:
4188         (InitWebCoreSystemInterface):
4189         * WebView/WebDataSource.m:
4190         (-[WebDataSource _initWithDocumentLoader:]):
4191
4192 2006-10-08  Darin Adler  <darin@apple.com>
4193
4194         - build fix (also a fix for a crasher I forgot to commit before)
4195
4196         * Loader/WebFrameLoader.m: Added some missing includes.
4197         (-[WebFrameLoader checkLoadCompleteForThisFrame]):
4198         Added a needed retain/release.
4199
4200 2006-10-08  Darin Adler  <darin@apple.com>
4201
4202         Reviewed by Anders.
4203         
4204         - quick fix to loader problem causing layout test failures
4205
4206         * Loader/WebFrameLoader.m:
4207         (-[WebFrameLoader _finishedLoading]): Use a local variable for the bridge
4208         that we retain/release.
4209         (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
4210         Same here.
4211
4212 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
4213
4214         Reviewed by Adam.
4215         
4216         - removed a few includes from WebFrameLoader, fixed up as appropriate
4217         - segregated header includes into ones that need to go away to move the code and ones that don't
4218
4219         * Loader/WebFrameLoader.m:
4220         (-[WebFrameLoader _privateBrowsingEnabled]):
4221         (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
4222         * Loader/WebFrameLoaderClient.h:
4223         * WebView/WebFrame.m:
4224         (-[WebFrame _privateBrowsingEnabled]):
4225
4226 2006-10-08  Darin Adler  <darin@apple.com>
4227
4228         Reviewed by Maciej.
4229
4230         - moved a few methods from WebFrame to WebFrameLoader
4231
4232         * Loader/WebFrameLoader.h:
4233         * Loader/WebFrameLoader.m:
4234         (-[WebFrameLoader _setState:]):
4235         (-[WebFrameLoader stopLoadingSubframes]):
4236         (-[WebFrameLoader _receivedMainResourceError:complete:]):
4237         (-[WebFrameLoader closeOldDataSources]):
4238         (-[WebFrameLoader commitProvisionalLoad:]):
4239         (-[WebFrameLoader _finishedLoading]):
4240         (isBackForwardLoadType):
4241         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
4242         (-[WebFrameLoader didFirstLayout]):
4243         (-[WebFrameLoader frameLoadCompleted]):