5c83ba186fe50a3748568faf85068e84a0c5e228
[WebKit-https.git] / WebKit / ChangeLog
1 2006-10-30  John Sullivan  <sullivan@apple.com>
2
3         Reviewed by Geoff Garen
4
5         * WebView/WebHTMLView.m:
6         (-[NSArray checkSpelling:]):
7         removed code to update spelling panel; WebCore handles that now
8         (-[NSArray showGuessPanel:]):
9         ditto
10
11 2006-10-30  John Sullivan  <sullivan@apple.com>
12
13         * English.lproj/WebViewEditingContextMenu.nib/info.nib:
14         * English.lproj/WebViewEditingContextMenu.nib/objects.nib:
15         Another wording change to match framework, post-Tiger:
16         "Check Spelling" -> "Check Document Now"
17
18 2006-10-30  John Sullivan  <sullivan@apple.com>
19
20         Reviewed by Geoff Garen.
21         
22         Moved spelling-related methods from bridge to EditorClient. Added one not-yet-used
23         grammar-related method.
24
25         * WebCoreSupport/WebEditorClient.h:
26         declare overrides of isContinuousSpellCheckingEnabled(), spellCheckerDocumentTag(), and new
27         isGrammarCheckingEnabled()
28         * WebCoreSupport/WebEditorClient.mm:
29         (WebEditorClient::isContinuousSpellCheckingEnabled):
30         implement by calling through to WebView
31         (WebEditorClient::isGrammarCheckingEnabled):
32         ditto
33         (WebEditorClient::spellCheckerDocumentTag):
34         ditto
35         
36         * WebCoreSupport/WebFrameBridge.mm:
37         removed bridge equivalents of these methods
38
39 2006-10-30  Geoffrey Garen  <ggaren@apple.com>
40
41         Reviewed by Beth.
42         
43         Fixed nil-deref crash that I saw while using TOT (not sure how to repro,
44         but the debugger confirmed the cause).
45
46         * WebView/WebFrame.mm:
47         (core): Added check for NULL bridge.
48
49 2006-10-30  Geoffrey Garen  <ggaren@apple.com>
50
51         Reviewed by Darin.
52
53         Removed a number of editing and selection methods from the bridge.
54         
55         I moved cross-platform editing and selection code into WebCore::Editor and 
56         WebCore::SelectionController, respecitvely.
57         
58         All of the seemingly new code here is just code grabbed from WebCore or
59         merged from WebCoreFrameBridge.
60         
61         I changed one piece of internal API: we now pass around Ranges in places
62         where we used to pass around broken out components of Ranges.
63         
64         I also added WebCore XPATH_SUPPORT AND SVG_SUPPORT #defines to the project.
65         Since we now include WebCore headers that depend on these #defines, we need
66         to keep in sync with them, to avoid binary incompatibility.
67
68 2006-10-30  Darin Adler  <darin@apple.com>
69
70         Reviewed by John Sullivan.
71
72         - work toward removing Objective-C data types from FrameLoader.h:
73           removed NSDate, NSString, WebCorePageState, WebCoreResourceLoader,
74           and WebCoreResourceHandle
75         - moved bodyBackgroundColor function here from Frame
76
77         * History/WebHistoryItem.m: (+[WebHistoryItem _closeObjectsInPendingPageCaches]):
78         Updated for change in WebCorePageState.
79
80         * WebCoreSupport/WebFrameBridge.mm: Removed saveDocumentToPageCache method.
81
82         * WebCoreSupport/WebFrameLoaderClient.h: Changed NSDate to double.
83         * WebCoreSupport/WebFrameLoaderClient.mm:
84         (WebFrameLoaderClient::invalidateCurrentItemPageCache): Moved the code that was
85         formerly in invalidatePageCache: on the bridge here.
86         (WebFrameLoaderClient::dispatchWillPerformClientRedirect): Added code to make the
87         NSDate here.
88         (WebFrameLoaderClient::createPageCache): Restructured code to create the
89         WebCorePageState object directly instead of calling saveDocumentToPageCache on
90         the bridge.
91
92         * WebView/WebFrame.mm: (-[WebFrame _bodyBackgroundColor]): Rewrote this to work
93         directly with the DOM and renderers rather than using a function on Frame.
94
95 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
96
97         Reviewed by Anders.
98
99         - added ResourceResponse class and didReceiveResponse delegate call
100
101         * WebCoreSupport/WebFrameBridge.mm: Removed no longer needed
102         expiresTimeForResponse: method.
103
104 2006-10-29  Darin Adler  <darin@apple.com>
105
106         - update for the WebCore rename
107
108         * WebCoreSupport/WebFrameLoaderClient.mm:
109         * WebView/WebFrame.mm:
110
111 2006-10-29  Darin Adler  <darin@apple.com>
112
113         - update for the WebCore renames
114
115         * Plugins/WebNetscapePluginStream.mm:
116         * Plugins/WebPluginController.mm:
117         * WebCoreSupport/WebFrameBridge.mm:
118         * WebCoreSupport/WebFrameLoaderClient.h:
119         * WebCoreSupport/WebFrameLoaderClient.mm:
120         (WebFrameLoaderClient::willUseArchive):
121         (WebFrameLoaderClient::isArchiveLoadPending):
122         (WebFrameLoaderClient::cancelPendingArchiveLoad):
123         (WebFrameLoaderClient::deliverArchivedResources):
124         * WebCoreSupport/WebPageBridge.mm:
125         (-[WebPageBridge canRunModalNow]):
126         * WebView/WebDocumentLoaderMac.h:
127         * WebView/WebFrame.mm:
128         * WebView/WebHTMLRepresentation.m:
129         * WebView/WebView.mm:
130
131 2006-10-29  Darin Adler  <darin@apple.com>
132
133         Rubber stamped by Adam Roben.
134
135         - renamed WebCore's WebFrameLoaderClient to match the class name inside it
136
137         * WebCoreSupport/WebFrameBridge.mm: Update include.
138         * WebCoreSupport/WebFrameLoaderClient.h: Ditto.
139
140 2006-10-29  Darin Adler  <darin@apple.com>
141
142         Reviewed by Maciej.
143
144         - eliminate use of NSArray to carry form data around
145           (the code in this framework was actually using the NSArray to hold a single
146            NSData anyway, so I just went back to an NSData for now)
147
148         - also fixed http://bugs.webkit.org/show_bug.cgi?id=11444
149           REGRESSION (r17378): Exception (-[NSCFDictionary setObject:forKey:]:
150           attempt to insert nil value) when submitting a form with an empty
151           uninitialized field
152
153         * History/WebHistoryItem.m:
154         (-[WebHistoryItem _setFormInfoFromRequest:]):
155         (-[WebHistoryItem formData]):
156         * History/WebHistoryItemPrivate.h:
157         * WebCoreSupport/WebFrameLoaderClient.mm:
158         (WebFrameLoaderClient::dispatchWillSubmitForm):
159         * WebView/WebFrame.mm:
160         (-[WebFrame _loadItem:withLoadType:]):
161
162 2006-10-28  Darin Adler  <darin@apple.com>
163
164         Reviewed by Maciej.
165
166         - eliminated the use of Objective-C for the policy decider
167           machinery, obviating the need for WebPolicyDeciderMac
168
169         - moved the defersLoading flag from WebView to WebCore::Page
170
171         - removed unused copies of four methods that in the frame bridge;
172           the actually-used copies are in the page bridge
173
174         - updated for rename of PassRefPtr::release to releaseRef
175
176         * WebView/WebPolicyDeciderMac.h: Removed.
177         * WebView/WebPolicyDeciderMac.m: Removed.
178         * WebKit.xcodeproj/project.pbxproj: Updated for removal.
179
180         * Plugins/WebBaseNetscapePluginView.mm:
181         (-[WebBaseNetscapePluginView sendEvent:]):
182         * Plugins/WebNetscapePluginStream.mm:
183         * WebCoreSupport/WebFrameBridge.mm:
184         * WebCoreSupport/WebFrameLoaderClient.h:
185         * WebCoreSupport/WebFrameLoaderClient.mm:
186         (getWebView):
187         (WebFrameLoaderClient::WebFrameLoaderClient):
188         (WebFrameLoaderClient::willCloseDocument):
189         (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
190         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
191         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
192         (WebFrameLoaderClient::cancelPolicyCheck):
193         (WebFrameLoaderClient::dispatchWillSubmitForm):
194         (WebFrameLoaderClient::setDefersLoading):
195         (WebFrameLoaderClient::setTitle):
196         (WebFrameLoaderClient::deliverArchivedResourcesAfterDelay):
197         (WebFrameLoaderClient::deliverArchivedResources):
198         (WebFrameLoaderClient::setUpPolicyListener):
199         (WebFrameLoaderClient::receivedPolicyDecison):
200         (WebFrameLoaderClient::userAgent):
201         (-[WebFramePolicyListener initWithWebCoreFrame:]):
202         (-[WebFramePolicyListener invalidate]):
203         (-[WebFramePolicyListener dealloc]):
204         (-[WebFramePolicyListener finalize]):
205         (-[WebFramePolicyListener receivedPolicyDecision:]):
206         (-[WebFramePolicyListener ignore]):
207         (-[WebFramePolicyListener download]):
208         (-[WebFramePolicyListener use]):
209         (-[WebFramePolicyListener continue]):
210         * WebCoreSupport/WebPageBridge.mm:
211         (-[WebPageBridge runModal]):
212         * WebView/WebArchiver.m:
213         (+[WebArchiver archiveSelectionInFrame:]):
214         * WebView/WebFormDelegate.h:
215         * WebView/WebFormDelegate.m:
216         (+[WebFormDelegate _sharedWebFormDelegate]):
217         (-[WebFormDelegate textFieldDidBeginEditing:inFrame:]):
218         (-[WebFormDelegate textFieldDidEndEditing:inFrame:]):
219         (-[WebFormDelegate textDidChangeInTextField:inFrame:]):
220         (-[WebFormDelegate textDidChangeInTextArea:inFrame:]):
221         (-[WebFormDelegate frame:sourceFrame:willSubmitForm:withValues:submissionListener:]):
222         * WebView/WebFrame.mm:
223         (-[WebFrame _loadURL:referrer:intoChild:]):
224         (-[WebFrame _isFrameSet]):
225         * WebView/WebFrameInternal.h:
226         * WebView/WebFrameView.mm:
227         (-[WebFrameView _shouldDrawBorder]):
228         * WebView/WebHTMLView.m:
229         (-[NSArray knowsPageRange:]):
230         * WebView/WebView.mm:
231         (-[WebView _formDelegate]):
232         * WebView/WebViewInternal.h:
233         * WebView/WebViewPrivate.h:
234
235 2006-10-28  Adam Roben  <aroben@apple.com>
236
237         Reviewed by Maciej.
238
239         Fix layout tests that broke after r17399. Mitz discovered that the
240         failures were caused by HitTestResult::m_point being uninitialized
241         much of the time. HitTestResults are now always constructed with a
242         point.
243
244         * WebView/WebHTMLView.m:
245         (-[WebHTMLView elementAtPoint:allowShadowContent:]): Pass point to
246         HitTestResult constructor.
247
248 2006-10-28  Beth Dakin  <bdakin@apple.com>
249
250         Reviewed by Darin.
251
252         This is the WebKit half of pushing the guts of elementAtPoint and 
253         WebElementDictionary into WebCore. Among other things, this patch 
254         makes WebElementDictionary.m and WebHTMLView.m Objective-C++
255
256         * MigrateHeaders.make: Add DOMElementInternal.h to the list of 
257         headers to migrate.
258         * Misc/WebElementDictionary.h: Replaced DOMNode, DOMElement, and 
259         NSPoint member variables with a HitTestResult member variable.
260         * Misc/WebElementDictionary.m:
261         (addLookupKey): Formatting.
262         (-[WebElementDictionary initWithHitTestResult:]): Constructor just 
263         takes a HitTestResult now and sets the member variable.
264         (-[WebElementDictionary dealloc]): delete HitTestResult.
265         (-[WebElementDictionary finalize]): Address HitTestResult.
266         (-[WebElementDictionary _domNode]): Use HitTestResult and call into 
267         WebCore.
268         (-[WebElementDictionary objectForKey:]): Same.
269         (-[WebElementDictionary _webFrame]): Same.
270         (-[WebElementDictionary _targetWebFrame]): Same.
271         (-[WebElementDictionary _title]): Same.
272         (-[WebElementDictionary _imageRect]): Same.
273         (-[WebElementDictionary _isSelected]): Same.
274         * WebKit.xcodeproj/project.pbxproj:
275         * WebView/WebFrame.mm:
276         (core): Convert from DOMNode* to Node*
277         (kit): Convert from Node* to DOMNode*
278         * WebView/WebFrameInternal.h: Support for the above.
279         * WebView/WebHTMLView.m:
280         (-[WebHTMLView elementAtPoint:allowShadowContent:]): Call directly 
281         into Frame.cpp to get HitTestResult.
282
283 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
284
285         Reviewed by John & Adam.
286         
287         - various performance improvements for resource delegate dispatch.
288         
289         - avoid any ObjC messaging when fetching the WebView
290         - avoid ObjC calls to WebView to get resource load delegate and impl cache
291         - cache actual method pointers, not just the fact that the method is present
292         - added a new SPI resource load delegate method which allows clients to get
293           just one message in case of synchronously loading from memory cache; if this
294           is implemented you don't get the normal delegate calls in that case.
295         - various other minor tweaks
296
297         * WebCoreSupport/WebFrameBridge.h:
298         * WebCoreSupport/WebFrameLoaderClient.h:
299         * WebCoreSupport/WebFrameLoaderClient.mm:
300         (getWebView):
301         (WebFrameLoaderClient::hasBackForwardList):
302         (WebFrameLoaderClient::resetBackForwardList):
303         (WebFrameLoaderClient::privateBrowsingEnabled):
304         (WebFrameLoaderClient::updateHistoryForStandardLoad):
305         (WebFrameLoaderClient::resetAfterLoadError):
306         (WebFrameLoaderClient::download):
307         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
308         (WebFrameLoaderClient::dispatchIdentifierForInitialRequest):
309         (WebFrameLoaderClient::dispatchWillSendRequest):
310         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
311         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
312         (WebFrameLoaderClient::dispatchDidReceiveResponse):
313         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
314         (WebFrameLoaderClient::dispatchDidFinishLoading):
315         (WebFrameLoaderClient::dispatchDidFailLoading):
316         (WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
317         (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
318         (WebFrameLoaderClient::dispatchDidCancelClientRedirect):
319         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
320         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
321         (WebFrameLoaderClient::dispatchWillClose):
322         (WebFrameLoaderClient::dispatchDidReceiveIcon):
323         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
324         (WebFrameLoaderClient::dispatchDidReceiveTitle):
325         (WebFrameLoaderClient::dispatchDidCommitLoad):
326         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
327         (WebFrameLoaderClient::dispatchDidFailLoad):
328         (WebFrameLoaderClient::dispatchDidFinishLoad):
329         (WebFrameLoaderClient::dispatchDidFirstLayout):
330         (WebFrameLoaderClient::dispatchCreatePage):
331         (WebFrameLoaderClient::dispatchShow):
332         (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
333         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
334         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
335         (WebFrameLoaderClient::dispatchUnableToImplementPolicy):
336         (WebFrameLoaderClient::dispatchWillSubmitForm):
337         (WebFrameLoaderClient::dispatchDidLoadMainResource):
338         (WebFrameLoaderClient::progressStarted):
339         (WebFrameLoaderClient::progressCompleted):
340         (WebFrameLoaderClient::incrementProgress):
341         (WebFrameLoaderClient::completeProgress):
342         (WebFrameLoaderClient::setMainFrameDocumentReady):
343         (WebFrameLoaderClient::startDownload):
344         (WebFrameLoaderClient::willChangeTitle):
345         (WebFrameLoaderClient::didChangeTitle):
346         (WebFrameLoaderClient::mainFrameURL):
347         (WebFrameLoaderClient::frameLoadCompleted):
348         * WebCoreSupport/WebPageBridge.h:
349         * WebKit.xcodeproj/project.pbxproj:
350         * WebView/WebFrame.mm:
351         (frame):
352         (core):
353         (kit):
354         (getWebView):
355         (-[WebFrame _addBackForwardItemClippedAtTarget:]):
356         (-[WebFrame _canCachePage]):
357         (-[WebFrame _purgePageCache]):
358         (-[WebFrame _loadItem:withLoadType:]):
359         (-[WebFrame _goToItem:withLoadType:]):
360         (-[WebFrame _updateBackground]):
361         (-[WebFrame _clearSelectionInOtherFrames]):
362         (-[WebFrame _isMainFrame]):
363         (-[WebFrame webView]):
364         * WebView/WebResourceLoadDelegatePrivate.h: Added.
365         * WebView/WebView.mm:
366         (-[WebView _cacheResourceLoadDelegateImplementations]):
367         (WebViewGetResourceLoadDelegate):
368         (WebViewGetResourceLoadDelegateImplementations):
369         * WebView/WebViewInternal.h:
370         * WebView/WebViewPrivate.h:
371
372 2006-10-27  Geoffrey Garen  <ggaren@apple.com>
373
374         Reviewed by Maciej.
375         
376         Moved some WebCoreFrameBridge functions into FrameLoader.
377
378         * WebView/WebFrame.mm:
379         (-[WebFrame _numPendingOrLoadingRequests:]):
380
381 2006-10-27  Timothy Hatcher  <timothy@apple.com>
382
383         Reviewed by Beth.
384
385         Make a DerivedSource/Webkit directory to store migrated
386         internal headers from WebCore.
387
388         * MigrateHeaders.make:
389         * WebKit.xcodeproj/project.pbxproj:
390         * WebView/WebFrame.mm: import the new migrated DOM*Internal.h headers
391
392 2006-10-27  John Sullivan  <sullivan@apple.com>
393
394         Reviewed by Anders
395         
396         - fixed http://bugs.webkit.org/show_bug.cgi?id=11439 
397           REGRESSION: Another page loading crash
398
399         * WebView/WebFrame.mm:
400         (-[WebFrame _createItem:]):
401         Handle nil documentLoader the way we did before ObjC->C++ changes
402
403 2006-10-27  John Sullivan  <sullivan@apple.com>
404
405         Reviewed by Anders
406
407         * WebView/WebHTMLView.m:
408         (-[NSArray checkSpelling:]):
409         call advanceToNextMisspelling directly on FrameMac, bypassing bridge
410         (-[NSArray showGuessPanel:]):
411         ditto
412
413 2006-10-27  Darin Adler  <darin@apple.com>
414
415         - build fix
416
417         * WebCoreSupport/WebFrameLoaderClient.mm: Corrected header file name.
418
419 2006-10-27  Darin Adler  <darin@apple.com>
420
421         Reviewed by Maciej.
422
423         - moved methods that are there just to be called by the frame loader client into the client
424           in an attempt to get back some of the speed we lost yesterday
425
426         * DefaultDelegates/WebDefaultResourceLoadDelegate.m:
427         (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
428         (-[WebDefaultResourceLoadDelegate webView:resource:didCancelAuthenticationChallenge:fromDataSource:]):
429         * WebCoreSupport/WebFrameLoaderClient.h:
430         * WebCoreSupport/WebFrameLoaderClient.mm:
431         (dataSource):
432         (decisionListener):
433         (WebFrameLoaderClient::WebFrameLoaderClient):
434         (WebFrameLoaderClient::hasWebView):
435         (WebFrameLoaderClient::hasFrameView):
436         (WebFrameLoaderClient::hasBackForwardList):
437         (WebFrameLoaderClient::resetBackForwardList):
438         (WebFrameLoaderClient::provisionalItemIsTarget):
439         (WebFrameLoaderClient::loadProvisionalItemFromPageCache):
440         (WebFrameLoaderClient::invalidateCurrentItemPageCache):
441         (WebFrameLoaderClient::privateBrowsingEnabled):
442         (WebFrameLoaderClient::makeDocumentView):
443         (WebFrameLoaderClient::makeRepresentation):
444         (WebFrameLoaderClient::setDocumentViewFromPageCache):
445         (WebFrameLoaderClient::forceLayout):
446         (WebFrameLoaderClient::forceLayoutForNonHTML):
447         (WebFrameLoaderClient::updateHistoryForCommit):
448         (WebFrameLoaderClient::updateHistoryForBackForwardNavigation):
449         (WebFrameLoaderClient::updateHistoryForReload):
450         (WebFrameLoaderClient::updateHistoryForStandardLoad):
451         (WebFrameLoaderClient::updateHistoryForInternalLoad):
452         (WebFrameLoaderClient::updateHistoryAfterClientRedirect):
453         (WebFrameLoaderClient::setCopiesOnScroll):
454         (WebFrameLoaderClient::tokenForLoadErrorReset):
455         (WebFrameLoaderClient::resetAfterLoadError):
456         (WebFrameLoaderClient::doNotResetAfterLoadError):
457         (WebFrameLoaderClient::detachedFromParent1):
458         (WebFrameLoaderClient::detachedFromParent2):
459         (WebFrameLoaderClient::detachedFromParent3):
460         (WebFrameLoaderClient::detachedFromParent4):
461         (WebFrameLoaderClient::loadedFromPageCache):
462         (WebFrameLoaderClient::download):
463         (WebFrameLoaderClient::dispatchIdentifierForInitialRequest):
464         (WebFrameLoaderClient::dispatchWillSendRequest):
465         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
466         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
467         (WebFrameLoaderClient::dispatchDidReceiveResponse):
468         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
469         (WebFrameLoaderClient::dispatchDidFinishLoading):
470         (WebFrameLoaderClient::dispatchDidFailLoading):
471         (WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
472         (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
473         (WebFrameLoaderClient::dispatchDidCancelClientRedirect):
474         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
475         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
476         (WebFrameLoaderClient::dispatchWillClose):
477         (WebFrameLoaderClient::dispatchDidReceiveIcon):
478         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
479         (WebFrameLoaderClient::dispatchDidReceiveTitle):
480         (WebFrameLoaderClient::dispatchDidCommitLoad):
481         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
482         (WebFrameLoaderClient::dispatchDidFailLoad):
483         (WebFrameLoaderClient::dispatchDidFinishLoad):
484         (WebFrameLoaderClient::dispatchDidFirstLayout):
485         (WebFrameLoaderClient::dispatchCreatePage):
486         (WebFrameLoaderClient::dispatchShow):
487         (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
488         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
489         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
490         (WebFrameLoaderClient::dispatchUnableToImplementPolicy):
491         (WebFrameLoaderClient::dispatchWillSubmitForm):
492         (WebFrameLoaderClient::dispatchDidLoadMainResource):
493         (WebFrameLoaderClient::clearLoadingFromPageCache):
494         (WebFrameLoaderClient::isLoadingFromPageCache):
495         (WebFrameLoaderClient::revertToProvisionalState):
496         (WebFrameLoaderClient::setMainDocumentError):
497         (WebFrameLoaderClient::clearUnarchivingState):
498         (WebFrameLoaderClient::progressStarted):
499         (WebFrameLoaderClient::progressCompleted):
500         (WebFrameLoaderClient::incrementProgress):
501         (WebFrameLoaderClient::completeProgress):
502         (WebFrameLoaderClient::setMainFrameDocumentReady):
503         (WebFrameLoaderClient::startDownload):
504         (WebFrameLoaderClient::willChangeTitle):
505         (WebFrameLoaderClient::didChangeTitle):
506         (WebFrameLoaderClient::committedLoad):
507         (WebFrameLoaderClient::finishedLoading):
508         (WebFrameLoaderClient::finalSetupForReplace):
509         (WebFrameLoaderClient::cancelledError):
510         (WebFrameLoaderClient::cannotShowURLError):
511         (WebFrameLoaderClient::interruptForPolicyChangeError):
512         (WebFrameLoaderClient::cannotShowMIMETypeError):
513         (WebFrameLoaderClient::fileDoesNotExistError):
514         (WebFrameLoaderClient::shouldFallBack):
515         (WebFrameLoaderClient::mainFrameURL):
516         (WebFrameLoaderClient::setDefersCallbacks):
517         (WebFrameLoaderClient::willUseArchive):
518         (WebFrameLoaderClient::isArchiveLoadPending):
519         (WebFrameLoaderClient::cancelPendingArchiveLoad):
520         (WebFrameLoaderClient::clearArchivedResources):
521         (WebFrameLoaderClient::canHandleRequest):
522         (WebFrameLoaderClient::canShowMIMEType):
523         (WebFrameLoaderClient::representationExistsForURLScheme):
524         (WebFrameLoaderClient::generatedMIMETypeForURLScheme):
525         (WebFrameLoaderClient::elementForEvent):
526         (WebFrameLoaderClient::createPolicyDecider):
527         (WebFrameLoaderClient::frameLoadCompleted):
528         (WebFrameLoaderClient::restoreScrollPositionAndViewState):
529         (WebFrameLoaderClient::provisionalLoadStarted):
530         (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent):
531         (WebFrameLoaderClient::addHistoryItemForFragmentScroll):
532         (WebFrameLoaderClient::didFinishLoad):
533         (WebFrameLoaderClient::prepareForDataSourceReplacement):
534         (WebFrameLoaderClient::createDocumentLoader):
535         (WebFrameLoaderClient::setTitle):
536         (WebFrameLoaderClient::canUseArchivedResource):
537         (WebFrameLoaderClient::deliverArchivedResourcesAfterDelay):
538         (WebFrameLoaderClient::deliverArchivedResources):
539         (WebFrameLoaderClient::createPageCache):
540         * WebView/WebFrame.mm:
541         (-[NSView setWebFrame:]):
542         (-[WebFrame _createItem:]):
543         (-[WebFrame _loadItem:withLoadType:]):
544         (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]):
545         (-[WebFrame _loadURL:referrer:intoChild:]):
546         (-[WebFrame _saveScrollPositionAndViewStateToItem:]):
547         (-[WebFrame _hasSelection]):
548         (-[WebFrame _clearSelection]):
549         (-[WebFrame _setProvisionalItem:]):
550         (-[WebFrame _setPreviousItem:]):
551         (-[WebFrame _setCurrentItem:]):
552         (-[WebFrame loadArchive:]):
553         * WebView/WebFrameInternal.h:
554         * WebView/WebHTMLView.m:
555         (-[WebHTMLView _topHTMLView]):
556         * WebView/WebHTMLViewPrivate.h:
557
558 2006-10-26  Geoffrey Garen  <ggaren@apple.com>
559
560         Reviewed by Darin, Maciej.
561
562         Removed many uses of NSString * from WebCore.
563         
564         Changed a few files to ObjC++ for compatiblity with new WebCore methods
565         taking WebCore::Strings as arguments.
566         
567         Added a static_cast to make the c++ compiler happy.
568
569 2006-10-26  John Sullivan  <sullivan@apple.com>
570
571         Reviewed by Anders
572
573         * WebView/WebFrame.mm:
574         now includes <WebCore/Document.h> and <WebCore/DocumentMarker.h>
575         (-[WebFrame _unmarkAllBadGrammar]):
576         filled in guts
577         (-[WebFrame _unmarkAllMisspellings]):
578         rewrote to call Document directly, bypassing bridge
579
580 2006-10-26  John Sullivan  <sullivan@apple.com>
581
582         * English.lproj/WebViewEditingContextMenu.nib/info.nib:
583         * English.lproj/WebViewEditingContextMenu.nib/objects.nib:
584         
585         Changed "Spelling" to "Spelling and Grammar" in context menu for post-Tiger.
586
587 === Safari-521.29 ===
588
589 2006-10-26  John Sullivan  <sullivan@apple.com>
590
591         No review, just two localized string changes.
592         
593         * WebView/WebHTMLView.m:
594         (-[NSArray validateUserInterfaceItem:]):
595         changed "Show/Hide Spelling" to "Show/Hide Spelling and Grammar" post-Tiger to match framework change
596
597         * English.lproj/Localizable.strings:
598         updated for these changes
599
600 2006-10-25  Darin Adler  <darin@apple.com>
601
602         Reviewed by Anders.
603
604         - removed 55 methods from WebCoreFrameBridge
605         - changed callers to use Frame directly instead
606         - put FrameLoaderTypes.h types into the WebCore namespace
607         - first steps to get FrameLoader.h ready for cross-platform duty
608
609         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
610         (-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
611         * Plugins/WebBaseNetscapePluginView.mm:
612         (-[WebBaseNetscapePluginView requestWithURLCString:]):
613         (-[WebBaseNetscapePluginView loadPluginRequest:]):
614         (-[WebBaseNetscapePluginView getVariable:value:]):
615         * Plugins/WebNetscapePluginEmbeddedView.m:
616         (-[WebNetscapePluginEmbeddedView didStart]):
617         * Plugins/WebNetscapePluginStream.mm:
618         * Plugins/WebPluginContainerCheck.m:
619         (-[WebPluginContainerCheck _continueWithPolicy:]):
620         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
621         * WebCoreSupport/WebEditorClient.mm:
622         (WebEditorClient::shouldDeleteRange):
623         (WebEditorClient::shouldShowDeleteInterface):
624         * WebCoreSupport/WebFrameBridge.mm:
625         (-[WebFrameBridge webView]):
626         (-[WebFrameBridge finishInitializingWithFrameName:view:]):
627         (-[WebFrameBridge createWindowWithURL:]):
628         (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
629         (-[WebFrameBridge windowObjectCleared]):
630         (-[WebFrameBridge createModalDialogWithURL:]):
631         * WebCoreSupport/WebFrameLoaderClient.mm:
632         (WebFrameLoaderClient::dispatchCreatePage):
633         (WebFrameLoaderClient::dispatchWillSubmitForm):
634         * WebKit.xcodeproj/project.pbxproj:
635         * WebView/WebArchiver.m:
636         (+[WebArchiver archiveSelectionInFrame:]):
637         * WebView/WebDataSource.mm:
638         (-[WebDataSource _documentFragmentWithImageResource:]):
639         (-[WebDataSource _imageElementWithImageResource:]):
640         * WebView/WebEditingDelegatePrivate.h:
641         * WebView/WebFrame.mm:
642         (core):
643         (kit):
644         (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]):
645         (-[WebFrame _canCachePage]):
646         (-[WebFrame _childFramesMatchItem:]):
647         (-[WebFrame _URLsMatchItem:]):
648         (-[WebFrame _loadItem:withLoadType:]):
649         (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]):
650         (-[WebFrame _viewWillMoveToHostWindow:]):
651         (-[WebFrame _viewDidMoveToHostWindow]):
652         (-[WebFrame _addChild:]):
653         (-[WebFrame _saveDocumentAndScrollState]):
654         (-[WebFrame _numPendingOrLoadingRequests:]):
655         (-[WebFrame _reloadForPluginChanges]):
656         (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
657         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
658         (-[WebFrame _initWithWebFrameView:webView:coreFrame:]):
659         (-[WebFrame _documentViews]):
660         (-[WebFrame _updateBackground]):
661         (-[WebFrame _unmarkAllMisspellings]):
662         (-[WebFrame _hasSelection]):
663         (-[WebFrame _atMostOneFrameHasSelection]):
664         (-[WebFrame _findFrameWithSelection]):
665         (-[WebFrame _frameLoader]):
666         (-[WebFrame _isDescendantOfFrame:]):
667         (-[WebFrame _setShouldCreateRenderers:]):
668         (-[WebFrame _bodyBackgroundColor]):
669         (-[WebFrame init]):
670         (-[WebFrame initWithName:webFrameView:webView:]):
671         (-[WebFrame dealloc]):
672         (-[WebFrame finalize]):
673         (-[WebFrame name]):
674         (-[WebFrame webView]):
675         (-[WebFrame DOMDocument]):
676         (-[WebFrame frameElement]):
677         (-[WebFrame findFrameNamed:]):
678         (-[WebFrame parentFrame]):
679         (-[WebFrame childFrames]):
680         (-[WebFrame _invalidateCurrentItemPageCache]):
681         (-[WebFrame _dispatchCreateWebViewWithRequest:]):
682         (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]):
683         (-[WebFrame _prepareForDataSourceReplacement]):
684         (-[WebFrame _provisionalLoadStarted]):
685         * WebView/WebFrameInternal.h:
686         * WebView/WebHTMLRepresentation.m:
687         (-[WebHTMLRepresentation DOMDocument]):
688         (-[WebHTMLRepresentation attributedText]):
689         * WebView/WebHTMLView.m:
690         (-[WebHTMLView _documentRange]):
691         (-[WebHTMLView _documentFragmentWithPaths:]):
692         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]):
693         (-[WebHTMLView _selectedRange]):
694         (-[WebHTMLView _updateMouseoverWithEvent:]):
695         (-[WebHTMLView _canEditRichly]):
696         (-[WebHTMLView _hasSelection]):
697         (-[WebHTMLView _hasSelectionOrInsertionPoint]):
698         (-[WebHTMLView _hasInsertionPoint]):
699         (-[WebHTMLView _isEditable]):
700         (-[WebHTMLView _isSelectionInPasswordField]):
701         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
702         (-[WebHTMLView _selectionDraggingImage]):
703         (-[WebHTMLView _canIncreaseSelectionListLevel]):
704         (-[WebHTMLView _canDecreaseSelectionListLevel]):
705         (-[WebHTMLView _updateActiveState]):
706         (-[NSArray readSelectionFromPasteboard:]):
707         (-[NSArray validateUserInterfaceItem:]):
708         (-[NSArray maintainsInactiveSelection]):
709         (-[NSArray menuForEvent:]):
710         (-[NSArray scrollWheel:]):
711         (-[NSArray acceptsFirstMouse:]):
712         (-[NSArray shouldDelayWindowOrderingForEvent:]):
713         (-[NSArray mouseDown:]):
714         (-[NSArray mouseDragged:]):
715         (-[NSArray mouseUp:]):
716         (-[NSArray keyDown:]):
717         (-[NSArray keyUp:]):
718         (-[NSArray centerSelectionInVisibleArea:]):
719         (-[NSArray _selectionStartFontAttributesAsRTF]):
720         (-[NSArray _emptyStyle]):
721         (-[NSArray performKeyEquivalent:]):
722         (-[NSArray indent:]):
723         (-[NSArray outdent:]):
724         (-[WebHTMLView cut:]):
725         (-[WebHTMLView paste:]):
726         (-[WebHTMLView _selectRangeInMarkedText:]):
727         (-[WebTextCompleteController doCompletion]):
728         (-[WebHTMLView selectionRect]):
729         (-[WebHTMLView selectionImageForcingWhiteText:]):
730         (-[WebHTMLView selectionImageRect]):
731         (-[WebHTMLView attributedString]):
732         (-[WebHTMLView _isMoveDrag]):
733         (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
734         * WebView/WebPolicyDelegate.mm:
735         (-[WebPolicyDecisionListener _usePolicy:]):
736         (-[WebPolicyDecisionListener use]):
737         (-[WebPolicyDecisionListener ignore]):
738         (-[WebPolicyDecisionListener download]):
739         (-[WebPolicyDecisionListener continue]):
740         * WebView/WebScriptDebugDelegate.m:
741         (-[WebScriptCallFrame _initWithFrame:initWithWebFrame:]):
742         (-[WebScriptCallFrame globalObject]):
743         * WebView/WebView.mm:
744         (-[WebView _attachScriptDebuggerToAllFrames]):
745         (-[WebView _detachScriptDebuggerFromAllFrames]):
746         (-[WebView windowScriptObject]):
747         (incrementFrame):
748         (-[WebView searchFor:direction:caseSensitive:wrap:]):
749         (-[WebView writeSelectionWithPasteboardTypes:toPasteboard:]):
750         (-[WebView removeDragCaret]):
751         (-[WebView setScriptDebugDelegate:]):
752         (-[WebView scriptDebugDelegate]):
753         (-[WebView shouldClose]):
754         (-[WebView selectedDOMRange]):
755         (-[WebView styleDeclarationWithText:]):
756
757 2006-10-25  Geoffrey Garen  <ggaren@apple.com>
758
759         Reviewed by Adam.
760
761         Renamed WebFrameLoader to FrameLoader, to match class name.
762
763         * Plugins/WebBaseNetscapePluginView.mm:
764         * Plugins/WebNetscapePluginStream.mm:
765         * Plugins/WebPluginController.mm:
766         * WebCoreSupport/WebFrameBridge.mm:
767         * WebView/WebDataSource.mm:
768         * WebView/WebFrame.mm:
769         * WebView/WebPDFView.mm:
770         * WebView/WebPolicyDelegate.mm:
771         * WebView/WebView.mm:
772
773 2006-10-25  Mark Rowe  <bdash@webkit.org>
774
775         Reviewed by Anders.
776
777         Build fix for the Buildbot.
778
779         * WebView/WebHTMLView.m:
780         (-[NSArray _addToStyle:fontA:fontB:]): Explicit cast.
781
782 2006-10-25  Maciej Stachowiak  <mjs@apple.com>
783
784         Reviewed by Anders.
785         
786         <rdar://problem/4785575> REGRESSION: form resubmission warning occurs twice, then Safari crashes in autorelease pool
787         <rdar://problem/4799383> REGRESSION: Crash occurs when dismissing the "Would you like to save this password" sheet
788
789         * WebView/WebPolicyDeciderMac.m:
790         (-[WebPolicyDeciderMac dealloc]): release the listener, don't dealloc it
791
792 2006-10-24  Anders Carlsson  <acarlsson@apple.com>
793
794         Reviewed by Darin.
795
796         * WebKitPrefix.h:
797         Include FastMalloc.h from C++ code.
798
799 2006-10-24  Darin Adler  <darin@apple.com>
800
801         Reviewed by Anders.
802
803         - converted WebFrameLoaderClient to C++
804         - renamed frame->frameLoader() function to frame->loader()
805         - renamed [bridge impl] to [bridge _frame]
806         - removed some bridge methods
807
808         * Plugins/WebNetscapePluginStream.mm:
809         * WebCoreSupport/WebEditorClient.mm:
810         * WebCoreSupport/WebFrameLoaderClient.h: Added.
811         (WebFrameLoaderClient::webFrame):
812         * WebCoreSupport/WebFrameLoaderClient.mm: Added.
813         (WebFrameLoaderClient::detachFrameLoader):
814         (WebFrameLoaderClient::hasWebView):
815         (WebFrameLoaderClient::hasFrameView):
816         (WebFrameLoaderClient::hasBackForwardList):
817         (WebFrameLoaderClient::resetBackForwardList):
818         (WebFrameLoaderClient::provisionalItemIsTarget):
819         (WebFrameLoaderClient::loadProvisionalItemFromPageCache):
820         (WebFrameLoaderClient::invalidateCurrentItemPageCache):
821         (WebFrameLoaderClient::privateBrowsingEnabled):
822         (WebFrameLoaderClient::makeDocumentView):
823         (WebFrameLoaderClient::makeRepresentation):
824         (WebFrameLoaderClient::setDocumentViewFromPageCache):
825         (WebFrameLoaderClient::forceLayout):
826         (WebFrameLoaderClient::forceLayoutForNonHTML):
827         (WebFrameLoaderClient::updateHistoryForCommit):
828         (WebFrameLoaderClient::updateHistoryForBackForwardNavigation):
829         (WebFrameLoaderClient::updateHistoryForReload):
830         (WebFrameLoaderClient::updateHistoryForStandardLoad):
831         (WebFrameLoaderClient::updateHistoryForInternalLoad):
832         (WebFrameLoaderClient::updateHistoryAfterClientRedirect):
833         (WebFrameLoaderClient::setCopiesOnScroll):
834         (WebFrameLoaderClient::tokenForLoadErrorReset):
835         (WebFrameLoaderClient::resetAfterLoadError):
836         (WebFrameLoaderClient::doNotResetAfterLoadError):
837         (WebFrameLoaderClient::detachedFromParent1):
838         (WebFrameLoaderClient::detachedFromParent2):
839         (WebFrameLoaderClient::detachedFromParent3):
840         (WebFrameLoaderClient::detachedFromParent4):
841         (WebFrameLoaderClient::loadedFromPageCache):
842         (WebFrameLoaderClient::download):
843         (WebFrameLoaderClient::dispatchIdentifierForInitialRequest):
844         (WebFrameLoaderClient::dispatchWillSendRequest):
845         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
846         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
847         (WebFrameLoaderClient::dispatchDidReceiveResponse):
848         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
849         (WebFrameLoaderClient::dispatchDidFinishLoading):
850         (WebFrameLoaderClient::dispatchDidFailLoading):
851         (WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
852         (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
853         (WebFrameLoaderClient::dispatchDidCancelClientRedirect):
854         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
855         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
856         (WebFrameLoaderClient::dispatchWillClose):
857         (WebFrameLoaderClient::dispatchDidReceiveIcon):
858         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
859         (WebFrameLoaderClient::dispatchDidReceiveTitle):
860         (WebFrameLoaderClient::dispatchDidCommitLoad):
861         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
862         (WebFrameLoaderClient::dispatchDidFailLoad):
863         (WebFrameLoaderClient::dispatchDidFinishLoad):
864         (WebFrameLoaderClient::dispatchDidFirstLayout):
865         (WebFrameLoaderClient::dispatchCreatePage):
866         (WebFrameLoaderClient::dispatchShow):
867         (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
868         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
869         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
870         (WebFrameLoaderClient::dispatchUnableToImplementPolicy):
871         (WebFrameLoaderClient::dispatchWillSubmitForm):
872         (WebFrameLoaderClient::dispatchDidLoadMainResource):
873         (WebFrameLoaderClient::clearLoadingFromPageCache):
874         (WebFrameLoaderClient::isLoadingFromPageCache):
875         (WebFrameLoaderClient::revertToProvisionalState):
876         (WebFrameLoaderClient::setMainDocumentError):
877         (WebFrameLoaderClient::clearUnarchivingState):
878         (WebFrameLoaderClient::progressStarted):
879         (WebFrameLoaderClient::progressCompleted):
880         (WebFrameLoaderClient::incrementProgress):
881         (WebFrameLoaderClient::completeProgress):
882         (WebFrameLoaderClient::setMainFrameDocumentReady):
883         (WebFrameLoaderClient::startDownload):
884         (WebFrameLoaderClient::willChangeTitle):
885         (WebFrameLoaderClient::didChangeTitle):
886         (WebFrameLoaderClient::committedLoad):
887         (WebFrameLoaderClient::finishedLoading):
888         (WebFrameLoaderClient::finalSetupForReplace):
889         (WebFrameLoaderClient::cancelledError):
890         (WebFrameLoaderClient::cannotShowURLError):
891         (WebFrameLoaderClient::interruptForPolicyChangeError):
892         (WebFrameLoaderClient::cannotShowMIMETypeError):
893         (WebFrameLoaderClient::fileDoesNotExistError):
894         (WebFrameLoaderClient::shouldFallBack):
895         (WebFrameLoaderClient::mainFrameURL):
896         (WebFrameLoaderClient::setDefersCallbacks):
897         (WebFrameLoaderClient::willUseArchive):
898         (WebFrameLoaderClient::isArchiveLoadPending):
899         (WebFrameLoaderClient::cancelPendingArchiveLoad):
900         (WebFrameLoaderClient::clearArchivedResources):
901         (WebFrameLoaderClient::canHandleRequest):
902         (WebFrameLoaderClient::canShowMIMEType):
903         (WebFrameLoaderClient::representationExistsForURLScheme):
904         (WebFrameLoaderClient::generatedMIMETypeForURLScheme):
905         (WebFrameLoaderClient::elementForEvent):
906         (WebFrameLoaderClient::createPolicyDecider):
907         (WebFrameLoaderClient::frameLoadCompleted):
908         (WebFrameLoaderClient::restoreScrollPositionAndViewState):
909         (WebFrameLoaderClient::provisionalLoadStarted):
910         (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent):
911         (WebFrameLoaderClient::addHistoryItemForFragmentScroll):
912         (WebFrameLoaderClient::didFinishLoad):
913         (WebFrameLoaderClient::prepareForDataSourceReplacement):
914         (WebFrameLoaderClient::createDocumentLoader):
915         (WebFrameLoaderClient::setTitle):
916         * WebKit.xcodeproj/project.pbxproj:
917         * WebView/WebDataSource.mm:
918         (-[WebDataSource webFrame]):
919         * WebView/WebFrame.mm:
920         (frame):
921         (-[WebFrame _loadItem:withLoadType:]):
922         (-[WebFrame _reloadForPluginChanges]):
923         (-[WebFrame _initWithWebFrameView:webView:bridge:]):
924         (-[WebFrame _frameLoader]):
925         (-[WebFrame provisionalDataSource]):
926         (-[WebFrame dataSource]):
927         (-[WebFrame parentFrame]):
928         (-[WebFrame _provisionalLoadStarted]):
929         * WebView/WebFrameInternal.h:
930         * WebView/WebHTMLRepresentation.m:
931         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
932         * WebView/WebHTMLView.m:
933         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
934         (-[NSArray validateUserInterfaceItem:]):
935         (-[NSArray scrollWheel:]):
936         (-[NSArray acceptsFirstMouse:]):
937         (-[NSArray shouldDelayWindowOrderingForEvent:]):
938         (-[NSArray _selectionStartFontAttributesAsRTF]):
939         (-[NSArray changeBaseWritingDirection:]):
940         (-[NSArray indent:]):
941         (-[NSArray outdent:]):
942         (-[WebHTMLView copy:]):
943         (-[WebHTMLView cut:]):
944         (-[WebHTMLView paste:]):
945         * WebView/WebView.mm:
946         (-[WebView _dashboardRegions]):
947         (-[WebView setProhibitsMainFrameScrolling:]):
948         (-[WebView _setInViewSourceMode:]):
949         (-[WebView _inViewSourceMode]):
950         (-[WebView setEditable:]):
951
952 2006-10-24  John Sullivan  <sullivan@apple.com>
953
954         Reviewed by Kevin Decker
955         
956         - fixed <rdar://problem/4801331> "Spelling..." menu item should be "Show/Hide Spelling" post-Tiger, to match AppKit
957
958         * WebView/WebHTMLView.m:
959         (-[NSArray validateUserInterfaceItem:]):
960         post-Tiger, update the menu item text to "Show Spelling"/"Hide Spelling" based on whether
961         the spelling panel is already showing. Also, removed else's after returns, and removed
962         braces around one-line if clauses.
963         (-[NSArray showGuessPanel:]):
964         post-Tiger, make this item hide the spelling panel if it's already showing
965
966         * English.lproj/Localizable.strings:
967         updated for this change
968         
969 2006-10-24  Timothy Hatcher  <timothy@apple.com>
970
971         Reviewed by Anders.
972
973         <rdar://problem/4588878> 'WebHTMLView' may not respond to '-_webView'
974
975         * Misc/WebNSViewExtras.h:
976         * Misc/WebNSViewExtras.m:
977         (-[NSView _webView]):
978
979 2006-10-24  Brady Eidson  <beidson@apple.com>
980
981         Reviewed by Anders
982
983         http://bugs.webkit.org/show_bug.cgi?id=11406 - Crash in [WebFrame dataSource]
984         In the transition to ObjC++ we lost alot of our free nil checking that we must now do manually
985         to prevent null dereferencing.
986
987         * WebView/WebFrame.mm:
988         (-[WebFrame provisionalDataSource]):
989         (-[WebFrame dataSource]):
990
991 2006-10-24  John Sullivan  <sullivan@apple.com>
992
993         Reviewed by Darin
994         
995         Initial plumbing for grammar checking. No actual grammar are checked at this time.
996
997         * English.lproj/WebViewEditingContextMenu.nib/classes.nib:
998         * English.lproj/WebViewEditingContextMenu.nib/info.nib:
999         * English.lproj/WebViewEditingContextMenu.nib/objects.nib:
1000         Added grammar-checking item, reworded to match changes in framework. This will be used
1001         post-Tiger.
1002
1003         * English.lproj/WebViewEditingContextMenuOld.nib/classes.nib: Added.
1004         * English.lproj/WebViewEditingContextMenuOld.nib/info.nib: Added.
1005         * English.lproj/WebViewEditingContextMenuOld.nib/objects.nib: Added.
1006         Copy of WebViewEditingContextMenu.nib, unchanged. This will be used on Tiger.
1007
1008         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
1009         (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
1010         Choose the right context menu based on BUILDING_ON_TIGER.
1011         
1012         * WebView/WebPreferenceKeysPrivate.h:
1013         declare grammar-related NSUserDefault value
1014
1015         * WebView/WebViewPrivate.h:
1016         declare grammar-related methods
1017
1018         * WebView/WebView.mm:
1019         declare static BOOL grammarCheckingEnabled
1020         (-[WebViewPrivate init]):
1021         initialize grammarCheckingEnabled to NSUserDefaults value
1022         (-[WebView validateUserInterfaceItem:]):
1023         validate toggleGrammarChecking: menu item
1024         (-[WebView isGrammarCheckingEnabled]):
1025         return value of grammarCheckingEnabled
1026         (-[WebView setGrammarCheckingEnabled:]):
1027         set value of grammarCheckingEnabled, call frame to remove existing bad grammar markers
1028         (-[WebView toggleGrammarChecking:]):
1029         flip the value
1030         
1031         * WebView/WebFrameInternal.h:
1032         * WebView/WebFrame.mm:
1033         (-[WebFrame _unmarkAllBadGrammar]):
1034         new placeholder method, does nothing yet
1035         
1036         * WebView/WebHTMLViewInternal.h:
1037         declare grammar-related methods
1038
1039         * WebView/WebHTMLView.m:
1040         (-[NSArray validateUserInterfaceItem:]):
1041         validate toggleGrammarChecking: menu item
1042         (-[WebHTMLView isGrammarCheckingEnabled]):
1043         new method, calls through to WebView
1044         (-[WebHTMLView setGrammarCheckingEnabled:]):
1045         ditto
1046         (-[WebHTMLView toggleGrammarChecking:]):
1047         ditto
1048                 
1049         * English.lproj/StringsNotToBeLocalized.txt:
1050         Updated for these changes
1051         
1052         * WebKit.xcodeproj/project.pbxproj:
1053         updated for new files        
1054
1055 2006-10-23  Darin Adler  <darin@apple.com>
1056
1057         Reviewed by Geoff.
1058
1059         - converted WebDocumentLoader to C++
1060
1061         * Plugins/WebPluginController.mm:
1062         (-[WebPluginController pluginView:receivedResponse:]):
1063         * WebKit.xcodeproj/project.pbxproj:
1064         * WebView/WebDataSource.mm:
1065         (-[WebDataSourcePrivate dealloc]):
1066         (-[WebDataSource _mainDocumentError]):
1067         (-[WebDataSource _URL]):
1068         (-[WebDataSource _loadFromPageCache:]):
1069         (-[WebDataSource _bridge]):
1070         (-[WebDataSource _URLForHistory]):
1071         (-[WebDataSource _documentLoader]):
1072         (-[WebDataSource _initWithDocumentLoader:]):
1073         (-[WebDataSource initWithRequest:]):
1074         (-[WebDataSource data]):
1075         (-[WebDataSource webFrame]):
1076         (-[WebDataSource initialRequest]):
1077         (-[WebDataSource request]):
1078         (-[WebDataSource response]):
1079         (-[WebDataSource textEncodingName]):
1080         (-[WebDataSource isLoading]):
1081         (-[WebDataSource unreachableURL]):
1082         (-[WebDataSource webArchive]):
1083         * WebView/WebDataSourceInternal.h:
1084         * WebView/WebDocumentLoaderMac.h:
1085         * WebView/WebDocumentLoaderMac.mm:
1086         (WebDocumentLoaderMac::WebDocumentLoaderMac):
1087         (WebDocumentLoaderMac::setDataSource):
1088         (WebDocumentLoaderMac::dataSource):
1089         (WebDocumentLoaderMac::attachToFrame):
1090         (WebDocumentLoaderMac::detachFromFrame):
1091         * WebView/WebFrame.mm:
1092         (-[WebFrame _createItem:]):
1093         (-[WebFrame _loadItem:withLoadType:]):
1094         (-[WebFrame _addChild:]):
1095         (dataSource):
1096         (-[WebFrame _dataSourceForDocumentLoader:]):
1097         (-[WebFrame _addDocumentLoader:toUnarchiveState:]):
1098         (-[WebFrame loadArchive:]):
1099         (-[WebFrame _updateHistoryForReload]):
1100         (-[WebFrame _updateHistoryForStandardLoad]):
1101         (-[WebFrame _updateHistoryForInternalLoad]):
1102         (-[WebFrame _dispatchIdentifierForInitialRequest:fromDocumentLoader:]):
1103         (-[WebFrame _dispatchResource:willSendRequest:redirectResponse:fromDocumentLoader:]):
1104         (-[WebFrame _dispatchDidReceiveAuthenticationChallenge:forResource:fromDocumentLoader:]):
1105         (-[WebFrame _dispatchDidCancelAuthenticationChallenge:forResource:fromDocumentLoader:]):
1106         (-[WebFrame _dispatchResource:didReceiveResponse:fromDocumentLoader:]):
1107         (-[WebFrame _dispatchResource:didReceiveContentLength:fromDocumentLoader:]):
1108         (-[WebFrame _dispatchResource:didFinishLoadingFromDocumentLoader:]):
1109         (-[WebFrame _dispatchResource:didFailLoadingWithError:fromDocumentLoader:]):
1110         (-[WebFrame _dispatchDidLoadMainResourceForDocumentLoader:]):
1111         (-[WebFrame _clearLoadingFromPageCacheForDocumentLoader:]):
1112         (-[WebFrame _isDocumentLoaderLoadingFromPageCache:]):
1113         (-[WebFrame _makeRepresentationForDocumentLoader:]):
1114         (-[WebFrame _revertToProvisionalStateForDocumentLoader:]):
1115         (-[WebFrame _setMainDocumentError:forDocumentLoader:]):
1116         (-[WebFrame _clearUnarchivingStateForLoader:]):
1117         (-[WebFrame _willChangeTitleForDocument:]):
1118         (-[WebFrame _didChangeTitleForDocument:]):
1119         (-[WebFrame _finishedLoadingDocument:]):
1120         (-[WebFrame _committedLoadWithDocumentLoader:data:]):
1121         (-[WebFrame _documentLoader:setMainDocumentError:]):
1122         (-[WebFrame _finalSetupForReplaceWithDocumentLoader:]):
1123         (-[WebFrame _createDocumentLoaderWithRequest:]):
1124         (-[WebFrame _provisionalLoadStarted]):
1125         * WebView/WebFrameInternal.h:
1126         * WebView/WebHTMLRepresentation.m:
1127         (-[WebHTMLRepresentation title]):
1128         * WebView/WebView.mm:
1129         (-[WebView _mainFrameOverrideEncoding]):
1130
1131 2006-10-23  Geoffrey Garen  <ggaren@apple.com>
1132
1133         RS by Maciej.
1134         
1135         Gave ObjC++ files .mm extension instead of .m.
1136
1137         * WebCoreSupport/WebPageBridge.m: Removed.
1138         * WebKit.xcodeproj/project.pbxproj:
1139         * WebView/WebDocumentLoaderMac.m: Removed.
1140
1141 2006-10-23  Darin Adler  <darin@apple.com>
1142
1143         Reviewed by Maciej.
1144
1145         - converted WebFrameLoader to C++
1146
1147         * History/WebHistoryItem.m:
1148         (+[WebHistoryItem _closeObjectsInPendingPageCaches]):
1149         * Plugins/WebBaseNetscapePluginView.mm:
1150         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1151         * Plugins/WebNetscapePluginStream.mm:
1152         (-[WebNetscapePluginStream start]):
1153         (-[WebNetscapePluginStream stop]):
1154         * Plugins/WebPluginController.mm:
1155         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
1156         (-[WebPluginController pluginView:receivedResponse:]):
1157         * WebCoreSupport/WebFrameBridge.h:
1158         * WebKit.xcodeproj/project.pbxproj:
1159         * WebView/WebDataSource.mm:
1160         (-[WebDataSource _loadFromPageCache:]):
1161         (-[WebDataSource _webView]):
1162         (-[WebDataSource webFrame]):
1163         * WebView/WebDocumentLoaderMac.h:
1164         * WebView/WebDocumentLoaderMac.m:
1165         (-[WebDocumentLoaderMac dealloc]):
1166         (-[WebDocumentLoaderMac attachToFrame]):
1167         (-[WebDocumentLoaderMac detachFromFrame]):
1168         * WebView/WebFrame.mm:
1169         (+[WebFrame _timeOfLastCompletedLoad]):
1170         (-[WebFrame _loadItem:withLoadType:]):
1171         (-[WebFrame _loadURL:referrer:intoChild:]):
1172         (-[WebFrame _currentBackForwardListItemToResetTo]):
1173         (-[WebFrame _itemForRestoringDocState]):
1174         (-[WebFrame _frameLoader]):
1175         (-[WebFrame _firstLayoutDone]):
1176         (-[WebFrame _loadType]):
1177         (-[WebFrame provisionalDataSource]):
1178         (-[WebFrame dataSource]):
1179         (-[WebFrame loadRequest:]):
1180         (-[WebFrame loadArchive:]):
1181         (-[WebFrame stopLoading]):
1182         (-[WebFrame reload]):
1183         (-[WebFrame _updateHistoryForCommit]):
1184         (-[WebFrame _updateHistoryForReload]):
1185         (-[WebFrame _updateHistoryForInternalLoad]):
1186         (-[WebFrame _deliverArchivedResourcesAfterDelay]):
1187         (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]):
1188         (-[WebFrame _deliverArchivedResources]):
1189         (-[WebFrame _prepareForDataSourceReplacement]):
1190         (-[WebFrame _provisionalLoadStarted]):
1191         * WebView/WebFrameInternal.h:
1192         * WebView/WebHTMLView.m:
1193         (-[WebHTMLView _clearLastHitViewIfSelf]):
1194         (-[WebHTMLView _updateMouseoverWithEvent:]):
1195         (-[NSArray removeMouseMovedObserverUnconditionally]):
1196         (-[NSArray removeMouseMovedObserver]):
1197         (-[NSArray viewWillMoveToWindow:]):
1198         (-[NSArray viewDidMoveToWindow]):
1199         (-[WebHTMLView _canMakeTextSmaller]):
1200         (-[WebHTMLView _canMakeTextLarger]):
1201         (-[WebHTMLView _canMakeTextStandardSize]):
1202         * WebView/WebPDFView.mm:
1203         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1204         * WebView/WebView.mm:
1205         (-[WebView _close]):
1206         (-[WebView setDefersCallbacks:]):
1207         (-[WebView setCustomTextEncodingName:]):
1208
1209 2006-10-23  Geoffrey Garen  <ggaren@apple.com>
1210
1211         Reviewed by Bradee.
1212
1213         Moved some page-level operations from WebFrameBridge to WebPageBridge.
1214
1215         * WebCoreSupport/WebFrameBridge.m:
1216         * WebCoreSupport/WebPageBridge.m:
1217         (-[WebPageBridge createModalDialogWithURL:referrer:]):
1218         (-[WebPageBridge canRunModal]):
1219         (-[WebPageBridge canRunModalNow]):
1220         (-[WebPageBridge runModal]):
1221         * WebKit.xcodeproj/project.pbxproj: Made WebPageBridge.m ObjC++ to support
1222         WebCore #includes.
1223
1224 2006-10-23  John Sullivan  <sullivan@apple.com>
1225
1226         * WebKitPrefix.h:
1227         Removed redundant definition of BUILDING_ON_TIGER that I just added. It turns out this had
1228         already been added between the last time I updated in this tree and when I needed it locally.
1229
1230 2006-10-23  John Sullivan  <sullivan@apple.com>
1231
1232         Reviewed by Anders
1233
1234         * WebKit.xcodeproj/project.pbxproj:
1235         Move WebKitPrefix.h from Misc group to top level, to match WebCore
1236         
1237         * WebKitPrefix.h:
1238         defined BUILDING_ON_TIGER a la WebCore, in preparation for future use of post-Tiger API
1239
1240 2006-10-23  Timothy Hatcher  <timothy@apple.com>
1241
1242         Reviewed by Darin.
1243
1244         Rename the now ObjC++ files to be .mm and remove the explicit file types.
1245
1246         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
1247         (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
1248         * English.lproj/StringsNotToBeLocalized.txt:
1249         * Plugins/WebBaseNetscapePluginView.m: Removed.
1250         * Plugins/WebNetscapePluginStream.m: Removed.
1251         * Plugins/WebPluginController.m: Removed.
1252         * WebCoreSupport/WebFrameBridge.m: Removed.
1253         * WebKit.xcodeproj/project.pbxproj:
1254         * WebView/WebDataSource.m: Removed.
1255         * WebView/WebFrame.m: Removed.
1256         * WebView/WebFrameView.m: Removed.
1257         * WebView/WebPDFView.m: Removed.
1258         * WebView/WebPolicyDelegate.m: Removed.
1259         * WebView/WebView.m: Removed.
1260
1261 2006-10-23  Timothy Hatcher  <timothy@apple.com>
1262
1263         Reviewed by Darin.
1264
1265         Move the undef try/catch to WebKitPrefix.h and include algorithm so we get
1266         exception_defines.h and so the undef of try/catch works.
1267
1268         Break off the BGRA to ARGB code into WebGraphicsExtras.c, this lets
1269         WebBaseNetscapePluginView.m safely compile as ObjC++ and not cause the Accelerate
1270         framework to complain about C++ exceptions being disabled.
1271
1272         * Misc/WebGraphicsExtras.c: Added.
1273         (WebConvertBGRAToARGB):
1274         * Misc/WebGraphicsExtras.h: Added.
1275         * Plugins/WebBaseNetscapePluginView.m:
1276         (-[WebBaseNetscapePluginView _aglOffscreenImageForDrawingInRect:]):
1277         * WebKit.xcodeproj/project.pbxproj:
1278         * WebKitPrefix.h:
1279         * WebView/WebView.m:
1280
1281 2006-10-22  Sam Weinig  <sam.weinig@gmail.com>
1282
1283         Reviewed by Tim H.
1284
1285         - Add DOMHTMLFormElementPrivate.h to the project.
1286
1287         * MigrateHeaders.make:
1288
1289 2006-10-21  Darin Adler  <darin@apple.com>
1290
1291         Reviewed by Adele.
1292
1293         - convert WebLoader and its 3 subclasses to C++
1294
1295         * Plugins/WebNetscapePluginStream.h:
1296         * Plugins/WebNetscapePluginStream.m:
1297         (-[WebNetscapePluginStream dealloc]):
1298         (-[WebNetscapePluginStream finalize]):
1299         (-[WebNetscapePluginStream start]):
1300         (-[WebNetscapePluginStream cancelLoadWithError:]):
1301         (-[WebNetscapePluginStream stop]):
1302         * WebCoreSupport/WebFrameBridge.m:
1303         (-[WebFrameBridge canRunModalNow]):
1304         * WebView/WebFrame.m:
1305         (-[WebFramePrivate dealloc]):
1306         (-[WebFramePrivate finalize]):
1307         (frame): Changed from uppercase to lowercase so that it won't conflict
1308         with the WebCore class named Frame.
1309         (-[WebFrame _firstChildFrame]):
1310         (-[WebFrame _lastChildFrame]):
1311         (-[WebFrame _previousSiblingFrame]):
1312         (-[WebFrame _nextSiblingFrame]):
1313         (-[WebFrame _traverseNextFrameStayWithin:]):
1314         (-[WebFrame _immediateChildFrameNamed:]):
1315         (-[WebFrame _nextFrameWithWrap:]):
1316         (-[WebFrame _previousFrameWithWrap:]):
1317         (-[WebFrame findFrameNamed:]):
1318         (-[WebFrame parentFrame]):
1319         (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]):
1320         (-[WebFrame _deliverArchivedResourcesAfterDelay]):
1321         (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]):
1322         (-[WebFrame _archiveLoadPendingForLoader:]):
1323         (-[WebFrame _cancelPendingArchiveLoadForLoader:]):
1324         (-[WebFrame _clearArchivedResources]):
1325         (-[WebFrame _deliverArchivedResources]):
1326
1327 2006-10-21  Darin Adler  <darin@apple.com>
1328
1329         Reviewed by Anders.
1330
1331         - fix http://bugs.webkit.org/show_bug.cgi?id=10328
1332           REGRESSION: frame leak reported by buildbot
1333
1334         * WebCoreSupport/WebEditorClient.mm:
1335         (WebEditorClient::WebEditorClient): Don't retain the web view.
1336         (WebEditorClient::~WebEditorClient): Don't release the web view.
1337         (WebEditorClient::setWebView): Ditto.
1338
1339         * WebCoreSupport/WebFrameBridge.m:
1340         (-[WebFrameBridge finishInitializingWithFrameName:view:]): Added. Common code for use by both
1341         init methods below.
1342         (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): Changed to use new method.
1343         Also added comment pointing out design flaw -- we attach the client to the web view here,
1344         but we need to be sure to detach in case the web view is deallocated first.
1345         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): Ditto.
1346
1347 2006-10-21  Darin Adler  <darin@apple.com>
1348
1349         Reviewed by Adam.
1350
1351         - http://bugs.webkit.org/show_bug.cgi?id=11376
1352           build scripts should invoke make with "-j" option for multiple processors
1353
1354         * WebKit.xcodeproj/project.pbxproj: Pass -j `sysctl -n hw.ncpu` to make.
1355
1356 2006-10-21  Timothy Hatcher  <timothy@apple.com>
1357
1358         Reviewed by Geoff.
1359
1360         <rdar://problem/4478625> HTML Editing: Basic table editing and culling
1361
1362         Initial implementaltion of table deletion user interface:
1363         * Adds a new editing delegate method, webView:shouldShowDeleteInterfaceForElement:.
1364         * The new delegate method is called from the new shouldShowDeleteInterface EditorClient function.
1365
1366         * DefaultDelegates/WebDefaultEditingDelegate.m:
1367         (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]):
1368         * WebCoreSupport/WebEditorClient.h:
1369         * WebCoreSupport/WebEditorClient.mm:
1370         (WebEditorClient::WebEditorClient):
1371         (WebEditorClient::shouldDeleteRange):
1372         (WebEditorClient::shouldShowDeleteInterface):
1373         * WebKit.xcodeproj/project.pbxproj:
1374         * WebView/WebEditingDelegatePrivate.h: Added.
1375
1376 2006-10-21  Alice Liu  <alice.liu@apple.com>
1377
1378         Reviewed by Maciej.
1379
1380         fix leaks.
1381
1382         * WebCoreSupport/WebEditorClient.mm:
1383         (WebEditorClient::setWebView):
1384         only change webview if its different
1385
1386         * WebCoreSupport/WebFrameBridge.m:
1387         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
1388         actually use the client allocated in the line above instead of
1389         allocation again, duh. 
1390
1391 2006-10-21  Alice Liu  <alice.liu@apple.com>
1392
1393         Build fix.
1394
1395         * WebCoreSupport/WebEditorClient.h:
1396         * WebCoreSupport/WebEditorClient.mm:
1397         (WebEditorClient::setWebView):
1398
1399 2006-10-20  Alice Liu  <alice.liu@apple.com>
1400
1401         Reviewed by Tim Hatcher.
1402
1403         Fixed a problem where the webview passed to the EditorClient wasn't valid yet.  
1404
1405         * WebCoreSupport/WebEditorClient.h:
1406         (WebEditorClient::setWebView):
1407         added webview setter
1408
1409         * WebCoreSupport/WebEditorClient.mm:
1410         (WebEditorClient::WebEditorClient):
1411         add default constructor
1412
1413         * WebCoreSupport/WebFrameBridge.m:
1414         (-[WebFrameBridge initMainFrameWithPage:frameName:view:]):
1415         use [page webView] since _webview isn't valid yet
1416         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
1417         use webview setter on editorclient
1418
1419 2006-10-20  David Hyatt  <hyatt@apple.com>
1420
1421         Tweak cache sizes so that they are back to the way they were,
1422         except for < 512, which will stay doubled.
1423
1424         Reviewed by Tim H.
1425
1426         * WebCoreSupport/WebFrameBridge.m:
1427         (-[WebFrameBridge getObjectCacheSize]):
1428
1429 2006-10-20  Alice Liu  <alice.liu@apple.com>
1430
1431         Reviewed by Maciej.
1432
1433         Adding knowledge of EditorClient to WebKit
1434
1435         * WebCoreSupport/WebEditorClient.h: Added.
1436
1437         * WebCoreSupport/WebEditorClient.mm: Added.
1438         (WebEditorClient::WebEditorClient):
1439         (WebEditorClient::~WebEditorClient):
1440         (WebEditorClient::shouldDeleteRange):
1441         Implementation of mac EditorClient
1442
1443         * WebCoreSupport/WebFrameBridge.m:
1444         (-[WebFrameBridge initMainFrameWithPage:frameName:view:]):
1445         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
1446         create an editor client to pass down the chain of constructors
1447
1448         * WebKit.xcodeproj/project.pbxproj:
1449         Added related EditorClient files
1450
1451         * WebKitPrefix.h:
1452         Added tiger build flag in order to make certain private headers from webcore compile successfully
1453
1454 2006-10-20  Darin Adler  <darin@apple.com>
1455
1456         - rolled out my loader change; caused world leak and possibly a plug-in crash
1457
1458 2006-10-20  Darin Adler  <darin@apple.com>
1459
1460         Reviewed by Adele.
1461
1462         - convert WebLoader and its 3 subclasses to C++
1463
1464         * Plugins/WebNetscapePluginStream.h:
1465         * Plugins/WebNetscapePluginStream.m:
1466         (-[WebNetscapePluginStream dealloc]):
1467         (-[WebNetscapePluginStream finalize]):
1468         (-[WebNetscapePluginStream start]):
1469         (-[WebNetscapePluginStream cancelLoadWithError:]):
1470         (-[WebNetscapePluginStream stop]):
1471         * WebCoreSupport/WebFrameBridge.m:
1472         (-[WebFrameBridge canRunModalNow]):
1473         * WebView/WebFrame.m:
1474         (-[WebFramePrivate dealloc]):
1475         (-[WebFramePrivate finalize]):
1476         (frame): Changed from uppercase to lowercase so that it won't conflict
1477         with the WebCore class named Frame.
1478         (-[WebFrame _firstChildFrame]):
1479         (-[WebFrame _lastChildFrame]):
1480         (-[WebFrame _previousSiblingFrame]):
1481         (-[WebFrame _nextSiblingFrame]):
1482         (-[WebFrame _traverseNextFrameStayWithin:]):
1483         (-[WebFrame _immediateChildFrameNamed:]):
1484         (-[WebFrame _nextFrameWithWrap:]):
1485         (-[WebFrame _previousFrameWithWrap:]):
1486         (-[WebFrame findFrameNamed:]):
1487         (-[WebFrame parentFrame]):
1488         (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]):
1489         (-[WebFrame _deliverArchivedResourcesAfterDelay]):
1490         (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]):
1491         (-[WebFrame _archiveLoadPendingForLoader:]):
1492         (-[WebFrame _cancelPendingArchiveLoadForLoader:]):
1493         (-[WebFrame _clearArchivedResources]):
1494         (-[WebFrame _deliverArchivedResources]):
1495
1496 2006-10-20  John Sullivan  <sullivan@apple.com>
1497
1498         Reviewed by Darin
1499         
1500         - fixed <rdar://problem/4794935> setAcceptsMouseMovedEvents: is called for every layout, 
1501           taking ~1% on the PLT test
1502
1503         * WebView/WebHTMLView.m:
1504         (-[NSArray layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
1505         Don't call setAcceptsMouseMovedEvents: and WKSetNSWindowShouldPostEventNotifications() here
1506         because this is called too often.
1507         
1508         * WebView/WebView.m:
1509         (-[WebView viewWillMoveToWindow:]):
1510         Do call them here, because this is guaranteed to be called at least once for each window
1511         containing a webview, but isn't called too often. Also restructured this method a little.
1512
1513 2006-10-19  Timothy Hatcher  <timothy@apple.com>
1514
1515         Reviewed by Anders.
1516
1517         Bug 11366: Web Inspector should show user agent style rules
1518         http://bugs.webkit.org/show_bug.cgi?id=11366
1519
1520         * WebInspector/WebInspector.m:
1521         (-[WebInspector init]):
1522         (-[WebInspector showOptionsMenu]):
1523         (-[WebInspector _toggleShowUserAgentStyles:]):
1524         * WebInspector/WebInspectorInternal.h:
1525         * WebInspector/webInspector/inspector.js:
1526
1527 2006-10-19  Brady Eidson <beidson@apple.com>
1528
1529         Build fix - 2gig is on that pesky signed/unsigned limit...
1530
1531         * WebCoreSupport/WebFrameBridge.m:
1532         (-[WebFrameBridge getObjectCacheSize]):
1533
1534 2006-10-19  Brady Eidson  <beidson@apple.com>
1535
1536         Reviewed by Hyatt.
1537
1538         Death to 16777216.  Long live 33554432.
1539         (Cache size changed needs to be reflected in localization file)
1540
1541         * English.lproj/StringsNotToBeLocalized.txt:
1542
1543 2006-10-19  Brady Eidson  <beidson@apple.com>
1544
1545         Reviewed by Hyatt
1546
1547         Added an larger in-memory level of cache for machines with 2+gb ram
1548
1549         * WebCoreSupport/WebFrameBridge.m:
1550         (-[WebFrameBridge getObjectCacheSize]):
1551
1552 2006-10-19  Brady Eidson  <beidson@apple.com>
1553
1554         Reviewed by Hyatt
1555
1556         Double the default memory cache size
1557
1558         * WebView/WebPreferences.m:
1559         (+[WebPreferences initialize]):
1560
1561 2006-10-19  John Sullivan  <sullivan@apple.com>
1562
1563         Reviewed by Kevin D and Geoff
1564
1565         * WebKit.xcodeproj/project.pbxproj:
1566         version wars
1567         
1568         Cleaned up this file, as follows:
1569         - renamed all file-internal methods to start with underscores
1570         - moved all file-internal methods into a FileInternal category block, and alphabetized them
1571         - grouped all other methods by where/how they were defined (delegate methods, protocol methods, overrides, etc.)
1572         - removed unstylish braces around one-line clauses
1573         
1574         * WebView/WebPDFView.m:
1575         (_applicationInfoForMIMEType):
1576         (_PDFSelectionsAreEqual):
1577         (+[WebPDFView supportedMIMETypes]):
1578         (-[WebPDFView setPDFDocument:]):
1579         (-[WebPDFView dealloc]):
1580         (-[WebPDFView centerSelectionInVisibleArea:]):
1581         (-[WebPDFView scrollPageDown:]):
1582         (-[WebPDFView scrollPageUp:]):
1583         (-[WebPDFView scrollLineDown:]):
1584         (-[WebPDFView scrollLineUp:]):
1585         (-[WebPDFView scrollToBeginningOfDocument:]):
1586         (-[WebPDFView scrollToEndOfDocument:]):
1587         (-[WebPDFView jumpToSelection:]):
1588         (-[WebPDFView acceptsFirstResponder]):
1589         (-[WebPDFView becomeFirstResponder]):
1590         (-[WebPDFView hitTest:]):
1591         (-[WebPDFView initWithFrame:]):
1592         (-[WebPDFView menuForEvent:]):
1593         (-[WebPDFView setNextKeyView:]):
1594         (-[WebPDFView viewDidMoveToWindow]):
1595         (-[WebPDFView viewWillMoveToWindow:]):
1596         (-[WebPDFView validateUserInterfaceItem:]):
1597         (-[WebPDFView copy:]):
1598         (-[WebPDFView takeFindStringFromSelection:]):
1599         (-[WebPDFView canPrintHeadersAndFooters]):
1600         (-[WebPDFView printOperationWithPrintInfo:]):
1601         (-[WebPDFView viewWillMoveToHostWindow:]):
1602         (-[WebPDFView viewDidMoveToHostWindow]):
1603         (-[WebPDFView elementAtPoint:]):
1604         (-[WebPDFView elementAtPoint:allowShadowContent:]):
1605         (-[WebPDFView searchFor:direction:caseSensitive:wrap:]):
1606         (-[WebPDFView viewState]):
1607         (-[WebPDFView setViewState:]):
1608         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
1609         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1610         (+[WebPDFView _PDFPreviewViewClass]):
1611         (+[WebPDFView _PDFViewClass]):
1612         (-[WebPDFView _anyPDFTagsFoundInMenu:]):
1613         (-[WebPDFView _applyPDFDefaults]):
1614         (-[WebPDFView _fakeKeyEventWithFunctionKey:]):
1615         (-[WebPDFView _menuItemsFromPDFKitForEvent:]):
1616         (-[WebPDFView _openWithFinder:]):
1617         (-[WebPDFView _path]):
1618         (-[WebPDFView _PDFSubview]):
1619         (-[WebPDFView _pointIsInSelection:]):
1620         (-[WebPDFView _receivedPDFKitLaunchNotification:]):
1621         (-[WebPDFView _scaledAttributedString:]):
1622         (-[WebPDFView _trackFirstResponder]):
1623         (-[PDFPrefUpdatingProxy forwardInvocation:]):
1624         (-[PDFPrefUpdatingProxy methodSignatureForSelector:]):
1625
1626 2006-10-19  John Sullivan  <sullivan@apple.com>
1627
1628         Reviewed by Kevin Decker
1629         
1630         - fixed <rdar://problem/4792761> Safari should use fancier embedded PDFKit stuff when it's available
1631
1632         * WebKit.xcodeproj/project.pbxproj:
1633         version wars
1634         
1635         * WebView/WebFrameView.m:
1636         (-[WebFrameView _makeDocumentViewForDataSource:]):
1637         initialize document view with frame view's rect instead of empty rect. This avoids some problems when 
1638         constructing view hierarchies from nibs
1639         
1640         * WebView/WebPreferencesPrivate.h:
1641         declare new _usePDFPreviewView and _setUsePDFPreviewView:, used for debugging
1642         * WebView/WebPreferenceKeysPrivate.h:
1643         declare new preference key string
1644         * WebView/WebPreferences.m:
1645         (+[WebPreferences initialize]):
1646         initialize new preference to true (we will by default use the new view if it's available)
1647         (-[WebPreferences _usePDFPreviewView]):
1648         new accessor for new pref
1649         (-[WebPreferences _setUsePDFPreviewView:]):
1650         ditto
1651
1652         * WebView/WebPDFView.h:
1653         new previewView ivar
1654         
1655         * WebView/WebPDFView.m:
1656         (+[WebPDFView PDFPreviewViewClass]):
1657         new method, returns class to use for fancier embedded PDFKit stuff, or nil if fancy stuff isn't available
1658         (-[WebPDFView initWithFrame:]):
1659         now tries to use fancier embedded PDFKit stuff if it's available and the pref is set to use it; falls back
1660         to old behavior otherwise
1661         (-[WebPDFView dealloc]):
1662         release new previewView ivar (retained in initWithFrame:)
1663         (-[WebPDFView viewWillMoveToWindow:]):
1664         stop observing PDFKit notification when we're removed from window
1665         (-[WebPDFView viewDidMoveToWindow]):
1666         start observing PDFKit notification when we're added to window
1667         (-[WebPDFView _receivedPDFKitLaunchNotification:]):
1668         respond to this new PDFKit notification by opening the document via NSWorkspace
1669         
1670         * English.lproj/StringsNotToBeLocalized.txt:
1671         updated for lots of recent changes
1672         
1673 2006-10-19  Sam Weinig  <sam.weinig@gmail.com>
1674
1675         Reviewed by ap.
1676
1677         Win32 build fix.
1678
1679         * COM/WebFrame.cpp:
1680         (WebFrame::initWithName):
1681         (WebFrame::createNewWindow):
1682
1683 2006-10-19  Mitz Pettel  <mitz@webkit.org>
1684
1685         Reviewed and landed by ap.
1686
1687         - fixed the inspector's tree popup
1688
1689         * WebInspector/webInspector/inspector.html:
1690
1691 2006-10-18  Sam Weinig  <sam.weinig@gmail.com>
1692
1693         Reviewed by Maciej.
1694
1695         Win32 build fix.
1696
1697         * COM/WebFrame.cpp:
1698         (WebFrame::createNewWindow):
1699         * COM/WebFrame.h:
1700
1701 2006-10-18  Anders Carlsson  <acarlsson@apple.com>
1702
1703         Reviewed by Adam.
1704
1705         http://bugs.webkit.org/show_bug.cgi?id=11000
1706         REGRESSION (r16101): css2.1/t0801-c412-hz-box-00-b-a is failing because the QuickTime plugin is taking over but not rendering the png
1707         
1708         * WebCoreSupport/WebFrameBridge.m:
1709         (-[WebFrameBridge determineObjectFromMIMEType:URL:]):
1710         Return ObjectElementFrame if the MIME type is one of the image ones we support.
1711
1712 2006-10-17  Justin Garcia  <justin.garcia@apple.com>
1713
1714         Reviewed by harrison
1715         
1716         <rdar://problem/4765600>
1717         REGRESSION: Mail.app: smart deletion of words does not work
1718         
1719         Regressed when we pushed selecion expansion down into WebCore.  It's OK
1720         to try a smart delete from _deleteWithDirection:, which is called by
1721         deleteFoward: and deleteBackward: if the current selection is a 
1722         range.
1723     
1724         * WebView/WebHTMLView.m:
1725         (-[NSArray _deleteWithDirection:granularity:killRing:isTypingAction:]):
1726
1727 2006-10-13  Justin Garcia  <justin.garcia@apple.com>
1728
1729         Reviewed by harrison
1730         
1731         <rdar://problem/3655385>
1732         Editing: -indent: method unimplemented
1733
1734         * WebView/WebHTMLView.m:
1735         (-[NSArray validateUserInterfaceItem:]): Only allow indent:/outdent: in
1736         richly editable areas.
1737         (-[NSArray indent:]):
1738         (-[NSArray outdent:]):
1739
1740 2006-10-13  Maciej Stachowiak  <mjs@apple.com>
1741
1742         Not reviewed, build fix.
1743         
1744         * icu/unicode/putil.h: Added - needed for build if you don't have apple internal headers.
1745
1746 2006-10-13  Maciej Stachowiak  <mjs@apple.com>
1747
1748         Not reviewed, build fix.
1749         
1750         * icu/unicode/ustring.h: Added - needed for build if you don't have apple internal headers.
1751
1752 2006-10-13  Maciej Stachowiak  <mjs@apple.com>
1753
1754         Reviewed by Anders.
1755         
1756         - add a bunch of casts to get this compiling with older Xcode versions
1757         
1758         (I used static_cast so it will be easier to find and remove these once we have completely moved
1759         on to a new enough compiler version.)
1760
1761         * Plugins/WebBaseNetscapePluginView.m:
1762         (+[WebBaseNetscapePluginView getCarbonEvent:]):
1763         (-[WebBaseNetscapePluginView getCarbonEvent:withEvent:]):
1764         (-[WebBaseNetscapePluginView fixWindowPort]):
1765         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1766         (-[WebBaseNetscapePluginView _createWindowlessAGLContext]):
1767         (-[WebBaseNetscapePluginView _reshapeAGLWindow]):
1768         (-[WebBaseNetscapePluginView _aglOffscreenImageForDrawingInRect:]):
1769         * WebKit.xcodeproj/project.pbxproj:
1770
1771 2006-10-13  Kevin McCullough  <KMcCullough@apple.com>
1772
1773         Changed by Darin, reviewed by me.
1774
1775         * Plugins/WebNetscapePluginStream.m: Fixed case of import so we can compile on
1776         case-sensitive file system.
1777
1778 2006-10-13  Darin Adler  <darin@apple.com>
1779
1780         Reviewed by Adele.
1781
1782         - converted WebFormState from Objective-C to C++
1783
1784         * ForwardingHeaders: Added an entire copy of WebCore's forwarding headers here.
1785         We should eventually come up with a more-elegant solution.
1786
1787         * WebKit.xcodeproj/project.pbxproj: Added ForwardingHeaders to the include paths.
1788         Converted many files from Objective-C to Objective-C++. In a later check-in, I'll
1789         rename them to .mm instead of .m. Removed C-only warning options for now. In a
1790         later check-in I will add these back in a way that omits them for C++.
1791
1792         * Plugins/WebPluginContainerCheck.m: Updated for header changes.
1793
1794         * WebView/WebFrameInternal.h: Updated for header changes. Removed WebFrameLoaderClient category
1795         so this file can still be used by Objective-C code (not just Objective-C++).
1796
1797         * WebView/WebFrame.m: Put WebFrameLoaderClient category in here.
1798         (-[WebFrame _loadItem:withLoadType:]): Changed to use 0 instead of nil for FormState and fixed
1799         enum code for C++ compatibility.
1800         (-[WebFrame _initWithWebFrameView:webView:bridge:]): Added call to setFrameLoaderClient: here.
1801         (-[WebFrame _updateHistoryForCommit]): Fixed enum code for C++ compatibility.
1802         (-[WebFrame _updateHistoryForReload]): Ditto.
1803
1804         * WebCoreSupport/WebFrameBridge.m:
1805         (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): Removed call to setFrameLoaderClient:.
1806         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): Ditto.
1807         (-[WebFrameBridge _retrieveKeyboardUIModeFromPreferences:]): Fixed enum code for C++ compatibility.
1808         (-[WebFrameBridge runModal]): Changed code to not use "namespace" as a local variable name.
1809
1810         * WebView/WebPDFView.m: Added extern "C" so this can compile as Objective-C++.
1811
1812 2006-10-12  Maciej Stachowiak  <mjs@apple.com>
1813
1814         Reviewed by Oliver.
1815         
1816         - liberate more WebKit code down to WebCore
1817
1818         * WebCoreSupport/WebFrameBridge.h:
1819         * WebCoreSupport/WebFrameBridge.m:
1820
1821 2006-10-12  Adele Peterson  <adele@apple.com>
1822
1823         Reviewed by Maciej.
1824
1825         WebKit part of fix for <rdar://problem/4450613> need a means to attach user data to any menu that is popuped up in HTML
1826
1827         Added private delegate method for clients that want access to a PopupMenu's NSMenu.
1828
1829         * DefaultDelegates/WebDefaultUIDelegate.m: (-[NSApplication webView:willPopupMenu:]):
1830         * WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge willPopupMenu:]):
1831         * WebView/WebUIDelegatePrivate.h:
1832
1833 2006-10-12  MorganL  <morganl.webkit@yahoo.com>
1834
1835         Reviewed/landed by Adam.
1836
1837         Fixes http://bugs.webkit.org/show_bug.cgi?id=11264
1838         Windows build busted
1839
1840         * COM/WebFrame.cpp:
1841         (WebFrame::receivedResponse):
1842
1843 2006-10-11  Darin Adler  <darin@apple.com>
1844
1845         Reviewed by Adele.
1846
1847         - preparations for making more code C++
1848
1849         * WebKitPrefix.h: Fixed ifdef so that C++ files get all the precompiled stuff
1850         that non-C++ files get.
1851
1852         * Misc/WebKitLogging.h:
1853         * Misc/WebKitSystemBits.h:
1854         * Misc/WebLocalizableStrings.h:
1855         * WebCoreSupport/WebSystemInterface.h:
1856         Added extern "C".
1857
1858         * Misc/WebNSViewExtras.h:
1859         * WebView/WebDataSource.m: (addTypesFromClass):
1860         * WebView/WebFrameView.m: (addTypesFromClass):
1861         Eliminated use of the identifier "class".
1862
1863         * WebView/WebView.m: (-[WebView _goToItem:withLoadType:]): Added a type cast.
1864
1865         * Plugins/WebBaseNetscapePluginView.m: Added lots of type casts.
1866
1867 2006-10-10  Brady Eidson  <beidson@apple.com>
1868
1869         Reviewed by Maciej.
1870
1871         Moved WebFrameLoader into WebCoreFrameBridge
1872
1873         * WebCoreSupport/WebFrameBridge.h:
1874         * WebCoreSupport/WebFrameBridge.m:
1875         (-[WebFrameBridge initMainFrameWithPage:frameName:view:]):
1876         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
1877         (-[WebFrameBridge dealloc]):
1878         (-[WebFrameBridge setTitle:]):
1879         (-[WebFrameBridge receivedData:textEncodingName:]):
1880         (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
1881         (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
1882         (-[WebFrameBridge objectLoadedFromCacheWithURL:response:data:]):
1883         (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
1884         (-[WebFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
1885         (-[WebFrameBridge reportClientRedirectCancelled:]):
1886         (-[WebFrameBridge close]):
1887         (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):
1888         (-[WebFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
1889         (-[WebFrameBridge tokenizerProcessedData]):
1890         (-[WebFrameBridge frameDetached]):
1891         (-[WebFrameBridge didFirstLayout]):
1892         (-[WebFrameBridge notifyIconChanged:]):
1893         (-[WebFrameBridge originalRequestURL]):
1894         (-[WebFrameBridge isLoadTypeReload]):
1895
1896 2006-10-10  Adele Peterson  <adele@apple.com>
1897
1898         Reviewed by Beth.
1899
1900         Removed handleAutoscrollForMouseDragged.  Except for autoscroll caused by drag and drop, all other
1901         autoscrolling should be done in WebCore instead of in AppKit.
1902
1903         * WebCoreSupport/WebFrameBridge.m:
1904         * WebView/WebHTMLView.m:
1905         * WebView/WebHTMLViewPrivate.h:
1906
1907 2006-10-10  Darin Adler  <darin@apple.com>
1908
1909         - corrected an archive regression caused by loader refactoring
1910           (pointed out by Graham Dennis)
1911
1912         * WebView/WebFrame.m: (-[WebFrame _deliverArchivedResourcesAfterDelay]):
1913         Fix selector name.
1914
1915 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
1916
1917         Rubber stamped by Eric.
1918         
1919         - moved a whole bunch of stuff over to WebCore - updated includes appropriately
1920
1921         * Loader/LoaderNSURLExtras.h: Removed.
1922         * Loader/LoaderNSURLExtras.m: Removed.
1923         * Loader/WebDataProtocol.h: Removed.
1924         * Loader/WebDataProtocol.m: Removed.
1925         * Loader/WebDocumentLoader.h: Removed.
1926         * Loader/WebDocumentLoader.m: Removed.
1927         * Loader/WebFormDataStream.h: Removed.
1928         * Loader/WebFormDataStream.m: Removed.
1929         * Loader/WebFormState.h: Removed.
1930         * Loader/WebFormState.m: Removed.
1931         * Loader/WebFrameLoader.h: Removed.
1932         * Loader/WebFrameLoader.m: Removed.
1933         * Loader/WebFrameLoaderClient.h: Removed.
1934         * Loader/WebLoader.h: Removed.
1935         * Loader/WebLoader.m: Removed.
1936         * Loader/WebMainResourceLoader.h: Removed.
1937         * Loader/WebMainResourceLoader.m: Removed.
1938         * Loader/WebNetscapePlugInStreamLoader.h: Removed.
1939         * Loader/WebNetscapePlugInStreamLoader.m: Removed.
1940         * Loader/WebPlugInStreamLoaderDelegate.h: Removed.
1941         * Loader/WebPolicyDecider.h: Removed.
1942         * Loader/WebPolicyDecider.m: Removed.
1943         * Loader/WebSubresourceLoader.h: Removed.
1944         * Loader/WebSubresourceLoader.m: Removed.
1945         * Misc/WebNSURLExtras.m:
1946         * Plugins/WebBaseNetscapePluginStream.h:
1947         * Plugins/WebBaseNetscapePluginView.m:
1948         * Plugins/WebNetscapePluginStream.m:
1949         * Plugins/WebPluginContainerCheck.m:
1950         * Plugins/WebPluginController.m:
1951         * WebCoreSupport/WebFrameBridge.m:
1952         * WebKit.xcodeproj/project.pbxproj:
1953         * WebView/WebDataSource.m:
1954         * WebView/WebDocumentLoaderMac.h:
1955         * WebView/WebFrame.m:
1956         * WebView/WebFrameInternal.h:
1957         * WebView/WebHTMLView.m:
1958         * WebView/WebPolicyDeciderMac.h:
1959         * WebView/WebPolicyDelegate.m:
1960         * WebView/WebView.m:
1961
1962 2006-10-10  Mark Rowe  <bdash@webkit.org>
1963
1964         Reviewed by Maciej.
1965
1966         Fix crash on launch in nightly builds after r16965.
1967
1968         Safari will sometimes call through to -[NSURL _webkit_canonicalize] before creating a WebView.  If this happens,
1969         InitWebCoreSystemInterface has not yet been called so the call to wkNSURLProtocolClassForReqest is via a garbage
1970         pointer.
1971
1972         * Misc/WebNSURLExtras.m:
1973         (-[NSURL _webkit_canonicalize]): Ensure InitWebCoreSystemInterface is called prior to canonicalURL.
1974
1975 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
1976
1977         Reviewed by Oliver.
1978         
1979         - split out some NSURL extras to be moved to WebCore
1980
1981         * Loader/LoaderNSURLExtras.h: Added.
1982         * Loader/LoaderNSURLExtras.m: Added.
1983         (urlByRemovingComponent):
1984         (urlByRemovingFragment):
1985         (urlOriginalDataAsString):
1986         (urlOriginalData):
1987         (urlWithData):
1988         (WebCFAutorelease):
1989         (urlWithDataRelativeToURL):
1990         (urlByRemovingResourceSpecifier):
1991         (urlIsFileURL):
1992         (stringIsFileURL):
1993         (urlIsEmpty):
1994         (canonicalURL):
1995         * Loader/WebFrameLoader.m:
1996         (-[WebFrameLoader shouldReloadForCurrent:andDestination:]):
1997         (setHTTPReferrer):
1998         (-[WebFrameLoader commitProvisionalLoad:]):
1999         (-[WebFrameLoader _notifyIconChanged:]):
2000         (-[WebFrameLoader didChangeTitleForDocument:]):
2001         (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]):
2002         (-[WebFrameLoader safeLoadURL:]):
2003         * Misc/WebNSURLExtras.m:
2004         (+[NSURL _web_URLWithData:]):
2005         (+[NSURL _web_URLWithData:relativeToURL:]):
2006         (-[NSURL _web_originalData]):
2007         (-[NSURL _web_originalDataAsString]):
2008         (-[NSURL _web_isEmpty]):
2009         (-[NSURL _webkit_canonicalize]):
2010         (-[NSURL _webkit_URLByRemovingComponent:]):
2011         (-[NSURL _webkit_URLByRemovingFragment]):
2012         (-[NSURL _webkit_URLByRemovingResourceSpecifier]):
2013         (-[NSURL _webkit_isFileURL]):
2014         (-[NSString _webkit_isFileURL]):
2015         * WebCoreSupport/WebSystemInterface.m:
2016         (InitWebCoreSystemInterface):
2017         * WebKit.xcodeproj/project.pbxproj:
2018
2019 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
2020
2021         Reviewed by Anders.
2022         
2023         - sever final WebFrame dependencies
2024
2025         * Loader/WebFrameLoader.h:
2026         * Loader/WebFrameLoader.m:
2027         (-[WebFrameLoader initWithFrame:client:]):
2028         (-[WebFrameLoader defersCallbacksChanged]):
2029         (-[WebFrameLoader subframeIsLoading]):
2030         (-[WebFrameLoader transitionToCommitted:]):
2031         (-[WebFrameLoader detachChildren]):
2032         (-[WebFrameLoader checkLoadComplete]):
2033
2034 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
2035
2036         Reviewed by Brady.
2037         
2038         - convert more WebFrameLoader stuff to be independent of WebFrame
2039
2040         * Loader/WebFrameLoader.h:
2041         * Loader/WebFrameLoader.m:
2042         (-[WebFrameLoader stopLoadingSubframes]):
2043         (-[WebFrameLoader _receivedMainResourceError:complete:]):
2044         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
2045         (-[WebFrameLoader closeOldDataSources]):
2046         (-[WebFrameLoader isHostedByObjectElement]):
2047         (-[WebFrameLoader isLoadingMainFrame]):
2048         (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
2049         (-[WebFrameLoader transitionToCommitted:]):
2050         (-[WebFrameLoader checkLoadCompleteForThisFrame]):
2051         (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
2052         (-[WebFrameLoader loadRequest:inFrameNamed:]):
2053         (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
2054         (-[WebFrameLoader actionInformationForNavigationType:event:originalURL:]):
2055         (-[WebFrameLoader client]):
2056         * Loader/WebFrameLoaderClient.h:
2057         * WebView/WebDataSource.m:
2058         (-[WebDataSource _webView]):
2059         (-[WebDataSource webFrame]):
2060         * WebView/WebFrame.m:
2061         (-[WebFrame _dispatchCreateWebViewWithRequest:]):
2062
2063 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
2064
2065         Reviewed by Anders and Oliver.
2066         
2067         - move a bunch of WebFrame methods from the Internal category to the WebFrameLoader protocol
2068
2069         * Loader/WebFrameLoader.h:
2070         * Loader/WebFrameLoader.m:
2071         (-[WebFrameLoader loadRequest:]):
2072         (-[WebFrameLoader loadRequest:inFrameNamed:]):
2073         * Loader/WebFrameLoaderClient.h:
2074         * WebView/WebFrame.m:
2075         (-[WebFrame loadRequest:]):
2076         (-[WebFrame _dispatchDidCommitLoadForFrame]):
2077         (-[WebFrame _hasFrameView]):
2078         (-[WebFrame _frameLoadCompleted]):
2079         (-[WebFrame _restoreScrollPositionAndViewState]):
2080         (-[WebFrame _setTitle:forURL:]):
2081         (-[WebFrame _createDocumentLoaderWithRequest:]):
2082         (-[WebFrame _prepareForDataSourceReplacement]):
2083         (-[WebFrame _didFinishLoad]):
2084         (-[WebFrame _addHistoryItemForFragmentScroll]):
2085         (-[WebFrame _shouldTreatURLAsSameAsCurrent:]):
2086         (-[WebFrame _provisionalLoadStarted]):
2087         * WebView/WebFrameInternal.h:
2088
2089 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
2090
2091         Not reviewed, build fix.
2092         
2093         - added forgotten files
2094
2095         * Loader/WebPolicyDecider.h: Added.
2096         * Loader/WebPolicyDecider.m: Added.
2097         (-[WebPolicyDecider invalidate]):
2098
2099 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
2100
2101         Reviewed by Brady.
2102         
2103         - add wrapper for WebPolicyDecisionListener so we can remove the dependency from WebFrameLoader.
2104
2105         * Loader/WebFrameLoader.h:
2106         * Loader/WebFrameLoader.m:
2107         (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]):
2108         (-[WebFrameLoader cancelContentPolicy]):
2109         (-[WebFrameLoader invalidatePendingPolicyDecisionCallingDefaultAction:]):
2110         (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]):
2111         (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]):
2112         (-[WebFrameLoader continueAfterWillSubmitForm:]):
2113         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
2114         * Loader/WebFrameLoaderClient.h:
2115         * WebKit.xcodeproj/project.pbxproj:
2116         * WebView/WebFrame.m:
2117         (-[WebFrame _createPolicyDeciderWithTarget:action:]):
2118         (decisionListener):
2119         (-[WebFrame _dispatchDecidePolicyForMIMEType:request:decider:]):
2120         (-[WebFrame _dispatchDecidePolicyForNewWindowAction:request:newFrameName:decider:]):
2121         (-[WebFrame _dispatchDecidePolicyForNavigationAction:request:decider:]):
2122         (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]):
2123         * WebView/WebPolicyDeciderMac.h: Added.
2124         * WebView/WebPolicyDeciderMac.m: Added.
2125         (-[WebPolicyDeciderMac initWithTarget:action:]):
2126         (-[WebPolicyDeciderMac dealloc]):
2127         (-[WebPolicyDeciderMac decisionListener]):
2128         (-[WebPolicyDeciderMac invalidate]):
2129
2130 2006-10-09  Brady Eidson  <beidson@apple.com>
2131
2132         Reviewed by John
2133
2134         http://bugs.webkit.org/show_bug.cgi?id=11195
2135         Added the WebIconDatabaseDelegate.  This allows the ability to allow customization of 
2136         IconDatabase behavior in the future, starting now with the ability to override the 
2137         default icon fairly flexibly
2138
2139         * Misc/WebIconDatabase.h: Added setIconDatabaseDelegate:
2140         * Misc/WebIconDatabase.m:
2141         (-[WebIconDatabase iconForURL:withSize:cache:]): Call the delegate for the default icon if delegate is set
2142         (-[WebIconDatabase defaultIconForURL:withSize:]): Get the default icon through the delegate if available, built-in if not
2143         (-[WebIconDatabase setDelegate:]):
2144         (-[WebIconDatabase delegate]):
2145         * Misc/WebIconDatabaseDelegate.h: Added.
2146         * Misc/WebIconDatabasePrivate.h: Added the delegate, nuked an unused class definition
2147         * WebKit.xcodeproj/project.pbxproj:
2148
2149 2006-10-09  Darin Adler  <darin@apple.com>
2150
2151         Reviewed by Maciej.
2152
2153         - eliminated uses of WebResource and WebView from WebFrameLoader
2154
2155         * Loader/WebFrameLoader.h:
2156         * Loader/WebFrameLoader.m:
2157         (-[WebFrameLoader setDefersCallbacks:]):
2158         (-[WebFrameLoader stopLoading]):
2159         (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
2160         (-[WebFrameLoader archiveLoadPendingForLoader:]):
2161         (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]):
2162         (-[WebFrameLoader _canShowMIMEType:]):
2163         (-[WebFrameLoader _representationExistsForURLScheme:]):
2164         (-[WebFrameLoader _generatedMIMETypeForURLScheme:]):
2165         (-[WebFrameLoader loadDocumentLoader:]):
2166         (-[WebFrameLoader continueAfterNavigationPolicy:]):
2167         (-[WebFrameLoader sendRemainingDelegateMessagesWithIdentifier:response:length:error:]):
2168         (-[WebFrameLoader actionInformationForNavigationType:event:originalURL:]):
2169         * Loader/WebFrameLoaderClient.h:
2170         * Loader/WebMainResourceLoader.m:
2171         (-[WebMainResourceLoader continueAfterContentPolicy:response:]):
2172         (-[WebMainResourceLoader loadWithRequestNow:]):
2173         * WebView/WebFrame.m:
2174         (-[WebFramePrivate dealloc]):
2175         (-[WebFrame loadRequest:]):
2176         (-[WebFrame loadArchive:]):
2177         (-[WebFrame _canUseResourceForRequest:]):
2178         (-[WebFrame _canUseResourceWithResponse:]):
2179         (-[WebFrame _deliverArchivedResourcesAfterDelay]):
2180         (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]):
2181         (-[WebFrame _archiveLoadPendingForLoader:]):
2182         (-[WebFrame _cancelPendingArchiveLoadForLoader:]):
2183         (-[WebFrame _clearArchivedResources]):
2184         (-[WebFrame _deliverArchivedResources]):
2185         (-[WebFrame _setDefersCallbacks:]):
2186         (-[WebFrame _canHandleRequest:]):
2187         (-[WebFrame _canShowMIMEType:]):
2188         (-[WebFrame _representationExistsForURLScheme:]):
2189         (-[WebFrame _generatedMIMETypeForURLScheme:]):
2190         (-[WebFrame _elementForEvent:]):
2191
2192 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
2193
2194         Reviewed by Darin.
2195         
2196         - do all the stuff that setting the referrer should
2197
2198         * Loader/WebFrameLoader.m:
2199         (setHTTPReferrer):
2200         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
2201         (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
2202         * WebKit.xcodeproj/project.pbxproj:
2203
2204 2006-10-09  Brady Eidson  <beidson@apple.com>
2205
2206         Reviewed by Maciej
2207
2208         Fix to elminate WebIconDatabaseBridge.h from WebFrameLoader
2209
2210         * Loader/WebFrameLoader.m:
2211         (-[WebFrameLoader _notifyIconChanged:]):
2212         * WebCoreSupport/WebIconDatabaseBridge.m:
2213         (+[WebIconDatabaseBridge createInstance]):
2214
2215 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
2216
2217         Reviewed by Darin.
2218         
2219         (Was reviewed as part of a larger patch but it looks like Darin already did the rest of it)
2220         
2221         - avoid a needless use of WebFrame
2222
2223         * Loader/WebFrameLoader.m:
2224         (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
2225
2226 2006-10-09  Brady Eidson  <beidson@apple.com>
2227
2228         A *real* fake fix for the layouttest problem until the real fix
2229
2230         * Loader/WebFrameLoader.m:
2231         (-[WebFrameLoader _notifyIconChanged:]):
2232
2233 2006-10-09  Brady Eidson  <beidson@apple.com>
2234
2235         Quick layouttest fix until I make the real fix
2236
2237         * Loader/WebFrameLoader.m:
2238
2239 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
2240
2241         Reviewed by Darin.
2242         
2243         - wean WebFrameLoader from WebDataSource private stuff
2244         
2245         (actually just tweaks tot he above to make merging my future
2246         patches easier since Darin did a lot of the same stuff)
2247
2248         * Loader/WebDocumentLoader.h:
2249         * Loader/WebDocumentLoader.m:
2250         (-[WebDocumentLoader URLForHistory]):
2251         * Loader/WebFrameLoader.m:
2252         (-[WebFrameLoader _loadRequest:archive:]):
2253         (-[WebFrameLoader revertToProvisionalWithDocumentLoader:]):
2254         (-[WebFrameLoader documentLoader:setMainDocumentError:]):
2255         (-[WebFrameLoader finalSetupForReplaceWithDocumentLoader:]):
2256         (-[WebFrameLoader didChangeTitleForDocument:]):
2257         (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
2258         * Loader/WebFrameLoaderClient.h:
2259         * WebView/WebDataSource.m:
2260         (-[WebDataSource _URLForHistory]):
2261         * WebView/WebFrame.m:
2262         (-[WebFrame _addDocumentLoader:toUnarchiveState:]):
2263         (-[WebFrame _revertToProvisionalStateForDocumentLoader:]):
2264         (-[WebFrame _setMainDocumentError:forDocumentLoader:]):
2265         (-[WebFrame _clearUnarchivingStateForLoader:]):
2266
2267 2006-10-09  Darin Adler  <darin@apple.com>
2268
2269         Reviewed by Brady.
2270
2271         - eliminated WebFrameLoader dependency on WebDataSourceInternal.h,
2272           WebIconDatabasePrivate.h, and WebKitErrorsPrivate.h, along with
2273           most but not all references to WebView
2274
2275         * Loader/WebFrameLoader.h:
2276         * Loader/WebFrameLoader.m:
2277         (-[WebFrameLoader removePlugInStreamLoader:]):
2278         (-[WebFrameLoader _receivedMainResourceError:complete:]):
2279         (-[WebFrameLoader _notifyIconChanged:]):
2280         (-[WebFrameLoader cancelledErrorWithRequest:]):
2281         (-[WebFrameLoader fileDoesNotExistErrorWithResponse:]):
2282         (-[WebFrameLoader handleUnimplementablePolicyWithError:]):
2283         (-[WebFrameLoader cannotShowMIMETypeWithResponse:]):
2284         (-[WebFrameLoader interruptForPolicyChangeErrorWithRequest:]):
2285         (-[WebFrameLoader _loadRequest:archive:]):
2286         (-[WebFrameLoader finishedLoadingDocument:]):
2287         (-[WebFrameLoader committedLoadWithDocumentLoader:data:]):
2288         (-[WebFrameLoader revertToProvisionalWithDocumentLoader:]):
2289         (-[WebFrameLoader documentLoader:setMainDocumentError:]):
2290         (-[WebFrameLoader finalSetupForReplaceWithDocumentLoader:]):
2291         (-[WebFrameLoader didChangeTitleForDocument:]):
2292         (-[WebFrameLoader continueAfterNavigationPolicy:]):
2293         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
2294         (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
2295         (-[WebFrameLoader transitionToCommitted:]):
2296         (-[WebFrameLoader checkLoadCompleteForThisFrame]):
2297         (-[WebFrameLoader requestFromDelegateForRequest:identifier:error:]):
2298         (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
2299         (-[WebFrameLoader checkLoadComplete]):
2300         * Loader/WebFrameLoaderClient.h:
2301         * Loader/WebMainResourceLoader.m:
2302         (-[WebMainResourceLoader continueAfterContentPolicy:response:]):
2303         * WebView/WebFrame.m:
2304         (-[WebFrame _addDocumentLoader:toUnarchiveState:]):
2305         (-[WebFrame _formDelegate]):
2306         (-[WebFrame _finishedLoadingDocument:]):
2307         (-[WebFrame _committedLoadWithDocumentLoader:data:]):
2308         (-[WebFrame _revertToProvisionalWithDocumentLoader:]):
2309         (-[WebFrame _documentLoader:setMainDocumentError:]):
2310         (-[WebFrame _finalSetupForReplaceWithDocumentLoader:]):
2311         (-[WebFrame _URLForHistoryForDocumentLoader:]):
2312         (-[WebFrame _cancelledErrorWithRequest:]):
2313         (-[WebFrame _cannotShowURLErrorWithRequest:]):
2314         (-[WebFrame _interruptForPolicyChangeErrorWithRequest:]):
2315         (-[WebFrame _cannotShowMIMETypeErrorWithResponse:]):
2316         (-[WebFrame _fileDoesNotExistErrorWithResponse:]):
2317         (-[WebFrame _shouldFallBackForError:]):
2318         (-[WebFrame _hasWebView]):
2319         (-[WebFrame _mainFrameURL]):
2320         * WebView/WebFrameInternal.h:
2321
2322 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
2323
2324         Reviewed, landed, tweaked a bit by Darin.
2325
2326         - removed most uses of WebFrameBridge from WebFrameLoader
2327           (WebCoreFrameBridge use is OK)
2328
2329         * Loader/WebDocumentLoader.m:
2330         (-[WebDocumentLoader bridge]):
2331         * Loader/WebFrameLoader.h:
2332         * Loader/WebFrameLoader.m:
2333         (-[WebFrameLoader initWithFrame:client:]):
2334         (-[WebFrameLoader defersCallbacksChanged]):
2335         (-[WebFrameLoader defersCallbacks]):
2336         (-[WebFrameLoader provisionalLoadStarted]):
2337         (-[WebFrameLoader stopLoadingSubframes]):
2338         (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]):
2339         (-[WebFrameLoader _receivedMainResourceError:complete:]):
2340         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
2341         (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]):
2342         (-[WebFrameLoader closeOldDataSources]):
2343         (-[WebFrameLoader commitProvisionalLoad:]):
2344         (-[WebFrameLoader bridge]):
2345         (-[WebFrameLoader _handleFallbackContent]):
2346         (-[WebFrameLoader _finishedLoading]):
2347         (-[WebFrameLoader reload]):
2348         (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]):
2349         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
2350         (-[WebFrameLoader transitionToCommitted:]):
2351         (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
2352         (-[WebFrameLoader loadRequest:inFrameNamed:]):
2353         (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
2354         (-[WebFrameLoader detachFromParent]):
2355         (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
2356         (-[WebFrameLoader safeLoadURL:]):
2357         (-[WebFrameLoader actionInformationForLoadType:isFormSubmission:event:originalURL:]):
2358         * WebCoreSupport/WebFrameBridge.m:
2359         (-[WebFrameBridge initMainFrameWithPage:frameName:view:]):
2360         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
2361         * WebView/WebFrame.m:
2362         (-[WebFrame _atMostOneFrameHasSelection]):
2363         * WebView/WebFrameInternal.h:
2364
2365 2006-10-09  Darin Adler  <darin@apple.com>
2366
2367         Reviewed by Brady.
2368
2369         - removed almost all direct use of WebView from WebFrameLoader
2370
2371         * Loader/WebFrameLoader.m:
2372         (-[WebFrameLoader defersCallbacksChanged]):
2373         (-[WebFrameLoader defersCallbacks]):
2374         (-[WebFrameLoader clearProvisionalLoad]):
2375         (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]):
2376         (-[WebFrameLoader _didReceiveResponse:forResource:]):
2377         (-[WebFrameLoader _didReceiveData:contentLength:forResource:]):
2378         (-[WebFrameLoader _didFinishLoadingForResource:]):
2379         (-[WebFrameLoader _didFailLoadingWithError:forResource:]):
2380         (-[WebFrameLoader closeOldDataSources]):
2381         (-[WebFrameLoader _notifyIconChanged:]):
2382         (-[WebFrameLoader prepareForLoadStart]):
2383         (-[WebFrameLoader willChangeTitleForDocument:]):
2384         (-[WebFrameLoader didChangeTitleForDocument:]):
2385         (-[WebFrameLoader continueAfterNewWindowPolicy:]):
2386         (-[WebFrameLoader continueAfterNavigationPolicy:]):
2387         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
2388         (-[WebFrameLoader didFirstLayout]):
2389         (-[WebFrameLoader transitionToCommitted:]):
2390         (-[WebFrameLoader checkLoadCompleteForThisFrame]):
2391         (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
2392         * Loader/WebFrameLoaderClient.h:
2393         * WebKit.xcodeproj/project.pbxproj:
2394         * WebView/WebFrame.m:
2395         (-[WebFrame _currentBackForwardListItemToResetTo]):
2396         (-[WebFrame _hasBackForwardList]):
2397         (-[WebFrame _resetBackForwardList]):
2398         (-[WebFrame _dispatchDidReceiveIcon:]):
2399         (-[WebFrame _dispatchDidStartProvisionalLoadForFrame]):
2400         (-[WebFrame _dispatchDidCommitLoadForFrame]):
2401         (-[WebFrame _dispatchDidFailProvisionalLoadWithError:]):
2402         (-[WebFrame _dispatchDidFailLoadWithError:]):
2403         (-[WebFrame _dispatchDidFinishLoadForFrame]):
2404         (-[WebFrame _progressStarted]):
2405         (-[WebFrame _progressCompleted]):
2406         (-[WebFrame _incrementProgressForIdentifier:response:]):
2407         (-[WebFrame _incrementProgressForIdentifier:data:]):
2408         (-[WebFrame _completeProgressForIdentifier:]):
2409         (-[WebFrame _setMainFrameDocumentReady:]):
2410         (-[WebFrame _willChangeTitleForDocument:]):
2411         (-[WebFrame _didChangeTitleForDocument:]):
2412         (-[WebFrame _startDownloadWithRequest:]):
2413
2414 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
2415
2416         Reviewed by Alice.
2417
2418         - moved WebFormState into Loader directory and tweaked to avoid WebKit dependencies
2419         
2420         * Loader/WebDocumentLoader.h:
2421         * Loader/WebFormState.h: Added.
2422         * Loader/WebFormState.m: Added.
2423         (-[WebFormState initWithForm:values:sourceFrame:]):
2424         (-[WebFormState dealloc]):
2425         (-[WebFormState form]):
2426         (-[WebFormState values]):
2427         (-[WebFormState sourceFrame]):
2428         * Loader/WebFrameLoader.h:
2429         * Loader/WebFrameLoader.m:
2430         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
2431         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
2432         (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
2433         * WebKit.xcodeproj/project.pbxproj:
2434         * WebView/WebFrame.m:
2435         * WebView/WebFrameInternal.h:
2436
2437 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
2438
2439         Reviewed by Oliver.
2440
2441         - remove dependency on WebNSURLRequestExtras.h
2442         
2443         * Loader/WebFrameLoader.h:
2444         * Loader/WebFrameLoader.m:
2445         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
2446         (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
2447         (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
2448
2449 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
2450
2451         Reviewed by Oliver.
2452         
2453         - removed unneeded logging code so I can take WebKitLogging.h out and remove a WebKit dependency
2454
2455         * Loader/WebFrameLoader.m:
2456         (-[WebFrameLoader setState:]):
2457         (-[WebFrameLoader clientRedirectCancelledOrFinished:]):
2458         (-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
2459         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
2460         (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]):
2461         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
2462         (-[WebFrameLoader checkLoadCompleteForThisFrame]):
2463
2464 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
2465
2466         Reviewed by Oliver.
2467         
2468         - remove WebDataSource from the WebFrameLoader interface (and thereby from a lot of internal use)
2469
2470         * Loader/WebDocumentLoader.h:
2471         * Loader/WebDocumentLoader.m:
2472         (-[WebDocumentLoader dealloc]):
2473         (-[WebDocumentLoader initialRequest]):
2474         (-[WebDocumentLoader URL]):
2475         (-[WebDocumentLoader unreachableURL]):
2476         * Loader/WebFrameLoader.h:
2477         * Loader/WebFrameLoader.m:
2478         (-[WebFrameLoader setState:]):
2479         (-[WebFrameLoader startLoading]):
2480         (-[WebFrameLoader startProvisionalLoad:]):
2481         (-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
2482         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
2483         (-[WebFrameLoader opened]):
2484         (-[WebFrameLoader commitProvisionalLoad:]):
2485         (-[WebFrameLoader initialRequest]):
2486         (-[WebFrameLoader _finishedLoading]):
2487         (-[WebFrameLoader _notifyIconChanged:]):
2488         (-[WebFrameLoader _URL]):
2489         (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
2490         (-[WebFrameLoader _checkNavigationPolicyForRequest:andCall:withSelector:]):
2491         (-[WebFrameLoader shouldReloadToHandleUnreachableURLFromRequest:]):
2492         (-[WebFrameLoader _loadRequest:archive:]):
2493         (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
2494         (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]):
2495         (-[WebFrameLoader reload]):
2496         (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]):
2497         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
2498         (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
2499         (-[WebFrameLoader frameLoadCompleted]):
2500         (-[WebFrameLoader transitionToCommitted:]):
2501         (-[WebFrameLoader checkLoadCompleteForThisFrame]):
2502         (-[WebFrameLoader safeLoadURL:]):
2503         * Loader/WebFrameLoaderClient.h:
2504         * Plugins/WebBaseNetscapePluginView.m:
2505         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
2506         * WebCoreSupport/WebFrameBridge.m:
2507         (-[WebFrameBridge originalRequestURL]):
2508         * WebView/WebDataSource.m:
2509         (-[WebDataSource _URL]):
2510         (-[WebDataSource dealloc]):
2511         (-[WebDataSource initialRequest]):
2512         (-[WebDataSource unreachableURL]):
2513         * WebView/WebFrame.m:
2514         (-[WebFrame _loadItem:withLoadType:]):
2515         (-[WebFrame _prepareForDataSourceReplacement]):
2516         (-[WebFrame provisionalDataSource]):
2517         (-[WebFrame dataSource]):
2518         (-[WebFrame _makeDocumentView]):
2519         (-[WebFrame _updateHistoryForReload]):
2520         (-[WebFrame _updateHistoryForStandardLoad]):
2521         (-[WebFrame _updateHistoryForInternalLoad]):
2522         (-[WebFrame _forceLayoutForNonHTML]):
2523         (-[WebFrame _clearLoadingFromPageCacheForDocumentLoader:]):
2524         (-[WebFrame _isDocumentLoaderLoadingFromPageCache:]):
2525         (-[WebFrame _archivedSubresourceForURL:fromDocumentLoader:]):
2526         (-[WebFrame _makeRepresentationForDocumentLoader:]):
2527
2528 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
2529
2530         Reviewed by Darin.
2531
2532         - removed need for WebFrameLoader to now about WebDocumentLoaderMac 
2533
2534         * Loader/WebFrameLoader.m:
2535         (-[WebFrameLoader loadDataSource:withLoadType:formState:]):
2536         * WebView/WebDocumentLoaderMac.h:
2537         * WebView/WebDocumentLoaderMac.m:
2538         (-[WebDocumentLoaderMac setFrameLoader:]):
2539         (-[WebDocumentLoaderMac detachFromFrameLoader]):
2540
2541 2006-10-09  Darin Adler  <darin@apple.com>
2542
2543         Reviewed by Maciej.
2544
2545         - passed calls that require WebScriptDebugServer across the client interface
2546
2547         * Loader/WebFrameLoader.m:
2548         (-[WebFrameLoader _finishedLoading]):
2549         (-[WebFrameLoader documentLoader:mainReceivedCompleteError:]):
2550         * Loader/WebFrameLoaderClient.h:
2551         * WebView/WebFrame.m:
2552         (-[WebFrame _dispatchDidLoadMainResourceForDocumentLoader:]):
2553
2554 2006-10-08  Darin Adler  <darin@apple.com>
2555
2556         Reviewed by Maciej.
2557
2558         - passed calls that require WebHTMLView or WebFrameView calls across
2559           the client interface
2560
2561         * Loader/WebFrameLoader.h:
2562         * Loader/WebFrameLoader.m:
2563         (isCaseInsensitiveEqual):
2564         (isBackForwardLoadType):
2565         (-[WebFrameLoader opened]):
2566         (-[WebFrameLoader cancelledErrorWithRequest:]):
2567         (-[WebFrameLoader fileDoesNotExistErrorWithResponse:]):
2568         (-[WebFrameLoader reload]):
2569         (-[WebFrameLoader transitionToCommitted:]):
2570         * Loader/WebFrameLoaderClient.h:
2571         * WebView/WebFrame.m:
2572         (-[WebFrame _forceLayout]):
2573         (-[WebFrame _setDocumentViewFromPageCache:]):
2574         (-[WebFrame _setCopiesOnScroll]):
2575
2576 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
2577
2578         Reviewed by Darin.
2579         
2580         - pass remaining delegate methods across client interface
2581
2582         * Loader/WebFrameLoader.m:
2583         (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]):
2584         (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]):
2585         (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]):
2586         (-[WebFrameLoader handleUnimplementablePolicyWithErrorCode:forURL:]):
2587         (-[WebFrameLoader didFirstLayout]):
2588         (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
2589         * Loader/WebFrameLoaderClient.h:
2590         * WebView/WebFrame.m:
2591         (-[WebFrame _dispatchDidFirstLayoutInFrame]):
2592         (-[WebFrame _dispatchCreateWebViewWithRequest:]):
2593         (-[WebFrame _dispatchShow]):
2594         (-[WebFrame _dispatchDecidePolicyForMIMEType:request:decisionListener:]):
2595         (-[WebFrame _dispatchDecidePolicyForNewWindowAction:request:newFrameName:decisionListener:]):
2596         (-[WebFrame _dispatchDecidePolicyForNavigationAction:request:decisionListener:]):
2597         (-[WebFrame _dispatchUnableToImplementPolicyWithError:]):
2598
2599 2006-10-08  Darin Adler  <darin@apple.com>
2600
2601         Reviewed by Maciej.
2602
2603         - use WebCoreSystemInterface instead of WebSystemInterface in Loader directory
2604
2605         * Loader/WebFrameLoader.m: Update includes.
2606         (-[WebFrameLoader commitProvisionalLoad:]): Use wk calls istead of WK.
2607         (-[WebFrameLoader _canUseResourceWithResponse:]): Ditto.
2608
2609         * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
2610         Added the three new symbols, and resorted the list.
2611
2612         * Loader/WebDataProtocol.m:
2613         * Loader/WebLoader.m:
2614         * Loader/WebMainResourceLoader.h:
2615         * Loader/WebMainResourceLoader.m:
2616         * Loader/WebNetscapePlugInStreamLoader.h:
2617         * Loader/WebNetscapePlugInStreamLoader.m:
2618         * Loader/WebSubresourceLoader.h:
2619         * Loader/WebSubresourceLoader.m:
2620         Changed import statements to consistently use the "" format.
2621
2622 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
2623
2624         Not reviewed.
2625         
2626         - fix accidental build break due to editing while committing
2627
2628         * Loader/WebFrameLoader.m:
2629
2630 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
2631
2632         Reviewed by Darin.
2633         
2634         - move all WebFrameLoadDelegate methods across client interface
2635
2636         * Loader/WebFrameLoader.m:
2637         (-[WebFrameLoader clientRedirectCancelledOrFinished:]):
2638         (-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
2639         (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]):
2640         (-[WebFrameLoader closeOldDataSources]):
2641         (-[WebFrameLoader _notifyIconChanged:]):
2642         (-[WebFrameLoader prepareForLoadStart]):
2643         (-[WebFrameLoader didChangeTitleForDocument:]):
2644         (-[WebFrameLoader transitionToCommitted:]):
2645         (-[WebFrameLoader checkLoadCompleteForThisFrame]):
2646         * Loader/WebFrameLoaderClient.h:
2647         * WebView/WebFrame.m:
2648         (-[WebFrame _dispatchDidCancelClientRedirectForFrame]):
2649         (-[WebFrame _dispatchWillPerformClientRedirectToURL:delay:fireDate:]):
2650         (-[WebFrame _dispatchDidChangeLocationWithinPageForFrame]):
2651         (-[WebFrame _dispatchWillCloseFrame]):
2652         (-[WebFrame _dispatchDidReceiveIcon:]):
2653         (-[WebFrame _dispatchDidStartProvisionalLoadForFrame]):
2654         (-[WebFrame _dispatchDidReceiveTitle:]):
2655         (-[WebFrame _dispatchDidCommitLoadForFrame]):
2656         (-[WebFrame _dispatchDidFailProvisionalLoadWithError:]):
2657         (-[WebFrame _dispatchDidFailLoadWithError:]):
2658         (-[WebFrame _dispatchDidFinishLoadForFrame]):
2659
2660 2006-10-08  Darin Adler  <darin@apple.com>
2661
2662         Reviewed by Maciej.
2663
2664         - removed some of the WebKit dependencies in WebFrameLoader
2665
2666         * Loader/WebFrameLoader.m:
2667         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
2668         (-[WebFrameLoader _downloadWithLoadingConnection:request:response:proxy:]):
2669         (-[WebFrameLoader reload]):
2670         (-[WebFrameLoader didChangeTitleForDocument:]):
2671         * Loader/WebFrameLoaderClient.h:
2672         * WebView/WebFrame.m:
2673         (-[WebFrame _loadItem:withLoadType:]):
2674         (-[WebFrame _loadURL:referrer:intoChild:]):
2675         (-[WebFrame _setTitle:forURL:]):
2676         (-[WebFrame _downloadWithLoadingConnection:request:response:proxy:]):
2677         * WebView/WebFrameInternal.h:
2678
2679         - some other tweaks
2680
2681         * Misc/WebNSURLRequestExtras.m:
2682         (-[NSMutableURLRequest _web_setHTTPReferrer:]):
2683         (-[NSMutableURLRequest _web_setHTTPUserAgent:]):
2684
2685 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
2686
2687         Reviewed by Darin.
2688         
2689         - pass all WebResourceLoadDelegate methods across client, removing need to include related headers
2690
2691         * Loader/WebFrameLoader.m:
2692         (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]):
2693         (-[WebFrameLoader _didReceiveAuthenticationChallenge:forResource:]):
2694         (-[WebFrameLoader _didCancelAuthenticationChallenge:forResource:]):
2695         (-[WebFrameLoader _didReceiveResponse:forResource:]):
2696         (-[WebFrameLoader _didReceiveData:contentLength:forResource:]):
2697         (-[WebFrameLoader _didFinishLoadingForResource:]):
2698         (-[WebFrameLoader _didFailLoadingWithError:forResource:]):
2699         (-[WebFrameLoader sendRemainingDelegateMessagesWithIdentifier:response:length:error:]):
2700         (-[WebFrameLoader requestFromDelegateForRequest:identifier:error:]):
2701         * Loader/WebFrameLoaderClient.h:
2702         * WebView/WebFrame.m:
2703         (-[WebFrame _dispatchDidHandleOnloadEventsForFrame]):
2704         (-[WebFrame _dispatchDidReceiveServerRedirectForProvisionalLoadForFrame]):
2705         (-[WebFrame _dispatchIdentifierForInitialRequest:fromDocumentLoader:]):
2706         (-[WebFrame _dispatchResource:willSendRequest:redirectResponse:fromDocumentLoader:]):
2707         (-[WebFrame _dispatchDidReceiveAuthenticationChallenge:forResource:fromDocumentLoader:]):
2708         (-[WebFrame _dispatchDidCancelAuthenticationChallenge:forResource:fromDocumentLoader:]):
2709         (-[WebFrame _dispatchResource:didReceiveResponse:fromDocumentLoader:]):
2710         (-[WebFrame _dispatchResource:didReceiveContentLength:fromDocumentLoader:]):
2711         (-[WebFrame _dispatchResource:didFinishLoadingFromDocumentLoader:]):
2712         (-[WebFrame _dispatchResource:didFailLoadingWithError:fromDocumentLoader:]):
2713
2714 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
2715
2716         Reviewed by Darin.
2717         
2718         - started adding some _dispatch methods to WebFrameLoaderClient for delegate dispatch
2719
2720         * Loader/WebFrameLoader.m:
2721         (-[WebFrameLoader startLoading]):
2722         (-[WebFrameLoader didReceiveServerRedirectForProvisionalLoadForFrame]):
2723         * Loader/WebFrameLoaderClient.h:
2724         * WebCoreSupport/WebFrameBridge.m:
2725         (-[WebFrameBridge handledOnloadEvents]):
2726         * WebView/WebFrame.m:
2727         (dataSource):
2728         (-[WebFrame _dataSourceForDocumentLoader:]):
2729         (-[WebFrame _dispatchDidHandleOnloadEventsForFrame]):
2730         (-[WebFrame _dispatchDidReceiveServerRedirectForProvisionalLoadForFrame]):
2731         (-[WebFrame _dispatchIdentifierForInitialRequest:fromDocumentLoader:]):
2732         * WebView/WebFrameInternal.h:
2733
2734 2006-10-08  Darin Adler  <darin@apple.com>
2735
2736         Reviewed by Maciej.
2737
2738         - moved more methods to WebFrameLoader from WebFrame
2739
2740         * Loader/WebFrameLoader.h:
2741         * Loader/WebFrameLoader.m:
2742         (-[WebFrameLoader defersCallbacksChanged]):
2743         (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]):
2744         (-[WebFrameLoader setState:]):
2745         (-[WebFrameLoader clearProvisionalLoad]):
2746         (-[WebFrameLoader markLoadComplete]):
2747         (-[WebFrameLoader commitProvisionalLoad]):
2748         (-[WebFrameLoader stopLoading]):
2749         (-[WebFrameLoader startProvisionalLoad:]):
2750         (-[WebFrameLoader setupForReplace]):
2751         (-[WebFrameLoader _identifierForInitialRequest:]):
2752         (-[WebFrameLoader _finishedLoadingResource]):
2753         (-[WebFrameLoader _receivedError:]):
2754         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
2755         (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]):
2756         (-[WebFrameLoader opened]):
2757         (-[WebFrameLoader commitProvisionalLoad:]):
2758         (-[WebFrameLoader _finishedLoading]):
2759         (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
2760         (-[WebFrameLoader _loadRequest:archive:]):
2761         (-[WebFrameLoader reload]):
2762         (-[WebFrameLoader documentLoader:mainReceivedCompleteError:]):
2763         (-[WebFrameLoader subframeIsLoading]):
2764         (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]):
2765         (-[WebFrameLoader continueAfterNewWindowPolicy:]):
2766         (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]):
2767         (-[WebFrameLoader sendRemainingDelegateMessagesWithIdentifier:response:length:error:]):
2768         (-[WebFrameLoader loadRequest:inFrameNamed:]):
2769         (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
2770         (-[WebFrameLoader detachChildren]):
2771         (-[WebFrameLoader detachFromParent]):
2772         (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
2773         (-[WebFrameLoader safeLoadURL:]):
2774         (-[WebFrameLoader actionInformationForLoadType:isFormSubmission:event:originalURL:]):
2775         (-[WebFrameLoader actionInformationForNavigationType:event:originalURL:]):
2776         (-[WebFrameLoader checkLoadComplete]):
2777         * Loader/WebFrameLoaderClient.h:
2778         * Loader/WebSubresourceLoader.m:
2779         (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]):
2780         * WebCoreSupport/WebFrameBridge.m:
2781         (-[WebFrameBridge close]):
2782         (-[WebFrameBridge tokenizerProcessedData]):
2783         (-[WebFrameBridge frameDetached]):
2784         * WebView/WebDataSourceInternal.h:
2785         * WebView/WebFrame.m:
2786         (-[WebFrame _loadItem:withLoadType:]):
2787         (-[WebFrame _prepareForDataSourceReplacement]):
2788         (-[WebFrame _detachedFromParent1]):
2789         (-[WebFrame _detachedFromParent2]):
2790         (-[WebFrame _detachedFromParent3]):
2791         (-[WebFrame _detachedFromParent4]):
2792         (-[WebFrame _updateHistoryAfterClientRedirect]):
2793         (-[WebFrame _loadedFromPageCache]):
2794         * WebView/WebFrameInternal.h:
2795         * WebView/WebPDFView.m:
2796         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2797         * WebView/WebView.m:
2798         (-[WebView _close]):
2799         (-[WebView setDefersCallbacks:]):
2800
2801 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
2802
2803         Reviewed by Darin.
2804         
2805         - avoid need for WebKitSystemInterface in loader code, via WebCore cover for wkSupportsMultipartXMixedReplace
2806
2807         * Loader/WebDocumentLoader.m:
2808         (-[WebDocumentLoader initWithRequest:]):
2809         * Loader/WebMainResourceLoader.m:
2810         * Loader/WebSubresourceLoader.m:
2811         (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]):
2812         * WebCoreSupport/WebSystemInterface.m:
2813         (InitWebCoreSystemInterface):
2814         * WebView/WebDataSource.m:
2815         (-[WebDataSource _initWithDocumentLoader:]):
2816
2817 2006-10-08  Darin Adler  <darin@apple.com>
2818
2819         - build fix (also a fix for a crasher I forgot to commit before)
2820
2821         * Loader/WebFrameLoader.m: Added some missing includes.
2822         (-[WebFrameLoader checkLoadCompleteForThisFrame]):
2823         Added a needed retain/release.
2824
2825 2006-10-08  Darin Adler  <darin@apple.com>
2826
2827         Reviewed by Anders.
2828         
2829         - quick fix to loader problem causing layout test failures
2830
2831         * Loader/WebFrameLoader.m:
2832         (-[WebFrameLoader _finishedLoading]): Use a local variable for the bridge
2833         that we retain/release.
2834         (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
2835         Same here.
2836
2837 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
2838
2839         Reviewed by Adam.
2840         
2841         - removed a few includes from WebFrameLoader, fixed up as appropriate
2842         - segregated header includes into ones that need to go away to move the code and ones that don't
2843
2844         * Loader/WebFrameLoader.m:
2845         (-[WebFrameLoader _privateBrowsingEnabled]):
2846         (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
2847         * Loader/WebFrameLoaderClient.h:
2848         * WebView/WebFrame.m:
2849         (-[WebFrame _privateBrowsingEnabled]):
2850
2851 2006-10-08  Darin Adler  <darin@apple.com>
2852
2853         Reviewed by Maciej.
2854
2855         - moved a few methods from WebFrame to WebFrameLoader
2856
2857         * Loader/WebFrameLoader.h:
2858         * Loader/WebFrameLoader.m:
2859         (-[WebFrameLoader _setState:]):
2860         (-[WebFrameLoader stopLoadingSubframes]):
2861         (-[WebFrameLoader _receivedMainResourceError:complete:]):
2862         (-[WebFrameLoader closeOldDataSources]):
2863         (-[WebFrameLoader commitProvisionalLoad:]):
2864         (-[WebFrameLoader _finishedLoading]):
2865         (isBackForwardLoadType):
2866         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
2867         (-[WebFrameLoader didFirstLayout]):
2868         (-[WebFrameLoader frameLoadCompleted]):
2869         (-[WebFrameLoader transitionToCommitted:]):
2870         (-[WebFrameLoader checkLoadCompleteForThisFrame]):
2871         (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
2872         (-[WebFrameLoader sendRemainingDelegateMessagesWithIdentifier:response:length:error:]):
2873         (-[WebFrameLoader requestFromDelegateForRequest:identifier:error:]):
2874         (-[WebFrameLoader loadRequest:inFrameNamed:]):
2875         (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
2876         * Loader/WebFrameLoaderClient.h:
2877         * Plugins/WebPluginController.m:
2878         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
2879         * WebCoreSupport/WebFrameBridge.h:
2880         * WebCoreSupport/WebFrameBridge.m:
2881         (-[WebFrameBridge initMainFrameWithPage:frameName:view:]):
2882         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
2883         (-[WebFrameBridge dealloc]):
2884         (-[WebFrameBridge frameLoader]):
2885         (-[WebFrameBridge setTitle:]):
2886         (-[WebFrameBridge receivedData:textEncodingName:]):
2887         (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
2888         (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
2889         (-[WebFrameBridge objectLoadedFromCacheWithURL:response:data:]):
2890         (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
2891         (-[WebFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
2892         (-[WebFrameBridge reportClientRedirectCancelled:]):
2893         (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):
2894         (-[WebFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
2895         (-[WebFrameBridge didFirstLayout]):
2896         (-[WebFrameBridge notifyIconChanged:]):
2897         (-[WebFrameBridge originalRequestURL]):
2898         (-[WebFrameBridge isLoadTypeReload]):
2899         * WebView/WebFrame.m:
2900         (-[WebFrame _opened]):
2901         (-[WebFrame _checkLoadComplete]):
2902         (-[WebFrame _loadItem:withLoadType:]):
2903         (-[WebFrame _actionInformationForLoadType:isFormSubmission:event:originalURL:]):
2904         (-[WebFrame _loadURL:referrer:intoChild:]):
2905         (-[WebFrame _currentBackForwardListItemToResetTo]):
2906         (-[WebFrame _updateBackground]):
2907         (-[WebFrame _frameLoader]):
2908         (-[WebFrame _frameLoadCompleted]):
2909         (-[WebFrame _makeDocumentView]):
2910         (-[WebFrame _updateHistoryForCommit]):
2911         (-[WebFrame _updateHistoryForReload]):
2912         (-[WebFrame _updateHistoryForStandardLoad]):
2913         (-[WebFrame _updateHistoryForBackForwardNavigation]):
2914         (-[WebFrame _updateHistoryForInternalLoad]):
2915         (-[WebFrame _tokenForLoadErrorReset]):
2916         (-[WebFrame _resetAfterLoadError:]):
2917         (-[WebFrame _doNotResetAfterLoadError:]):
2918         * WebView/WebFrameInternal.h:
2919
2920 2006-10-09  Mark Rowe  <bdash@webkit.org>
2921
2922         Rubber-stamped by Darin.
2923
2924         * WebCoreSupport/WebFrameBridge.m:
2925         (-[WebFrameBridge imageTitleForFilename:size:]): Revert accidental change to a UI_STRING that
2926         is triggering an assertion failure.
2927
2928 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
2929
2930         Reviewed by Darin.
2931         
2932         - remove unneeded non-Loader header includes from WebFrameLoader.h (split WebFrameLoadType into
2933         two coincidentally matching enums)
2934
2935         * Loader/WebFrameLoader.h:
2936         * Loader/WebFrameLoader.m:
2937         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
2938         (-[WebFrameLoader commitProvisionalLoad:]):
2939         (isBackForwardLoadType):
2940         (-[WebFrameLoader _loadRequest:archive:]):
2941         (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
2942         (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]):
2943         (-[WebFrameLoader reload]):
2944         (-[WebFrameLoader isReplacing]):
2945         (-[WebFrameLoader setReplacing]):
2946         (-[WebFrameLoader loadType]):
2947         (-[WebFrameLoader setLoadType:]):
2948         (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]):
2949         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
2950         (-[WebFrameLoader loadDataSource:withLoadType:formState:]):
2951         (-[WebFrameLoader didFirstLayout]):
2952         * WebCoreSupport/WebFrameBridge.m:
2953         * WebView/WebFrame.m:
2954         (-[WebFrame _transitionToCommitted:]):
2955         (-[WebFrame _provisionalLoadStarted]):
2956         (-[WebFrame _opened]):
2957         (-[WebFrame _checkLoadCompleteForThisFrame]):
2958         (-[WebFrame _loadItem:withLoadType:]):
2959         (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]):
2960         (-[WebFrame _goToItem:withLoadType:]):
2961         (-[WebFrame _actionInformationForLoadType:isFormSubmission:event:originalURL:]):
2962         (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
2963         (-[WebFrame _loadURL:referrer:intoChild:]):
2964         (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
2965         (-[WebFrame _currentBackForwardListItemToResetTo]):
2966         (-[WebFrame _itemForRestoringDocState]):
2967         (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
2968         (-[WebFrame _loadType]):
2969         (-[WebFrame loadRequest:]):
2970         * WebView/WebFrameInternal.h:
2971         * WebView/WebView.m:
2972
2973 2006-10-08  Darin Adler  <darin@apple.com>
2974
2975         Reviewed by Maciej.
2976
2977         - move WebFrameLoader creation and ownership from WebFrame to WebFrameBridge
2978
2979         * Loader/WebFrameLoader.m:
2980         (-[WebFrameLoader stopLoadingSubframes]):
2981         (-[WebFrameLoader closeOldDataSources]):
2982         * WebCoreSupport/WebFrameBridge.h:
2983         * WebCoreSupport/WebFrameBridge.m:
2984         (-[WebFrameBridge initMainFrameWithPage:frameName:view:]):
2985         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
2986         (-[WebFrameBridge dealloc]):
2987         (-[WebFrameBridge loader]):
2988         (-[WebFrameBridge setTitle:]):
2989         (-[WebFrameBridge receivedData:textEncodingName:]):
2990         (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
2991         (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
2992         (-[WebFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
2993         (-[WebFrameBridge reportClientRedirectCancelled:]):
2994         (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):
2995         (-[WebFrameBridge didFirstLayout]):
2996         (-[WebFrameBridge imageTitleForFilename:size:]):
2997         (-[WebFrameBridge notifyIconChanged:]):
2998         (-[WebFrameBridge originalRequestURL]):
2999         (-[WebFrameBridge isLoadTypeReload]):
3000         * WebView/WebFrame.m:
3001         (-[NSView setWebFrame::]):
3002         (-[WebFramePrivate dealloc]):
3003         (-[WebFramePrivate setWebFrameView:]):
3004         (-[WebFramePrivate setProvisionalItem:]):
3005         (-[WebFrame _webDataRequestForData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
3006         (-[WebFrame _createItem:]):
3007         (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]):
3008         (-[WebFrame _detachFromParent]):
3009         (-[WebFrame _makeDocumentView]):
3010         (-[WebFrame _transitionToCommitted:]):
3011         (-[WebFrame _provisionalLoadStarted]):
3012         (-[WebFrame _opened]):
3013         (-[WebFrame _checkLoadCompleteForThisFrame]):
3014         (-[WebFrame _loadItem:withLoadType:]):
3015         (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]):
3016         (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
3017         (-[WebFrame _loadURL:referrer:intoChild:]):
3018         (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
3019         (-[WebFrame _setTitle:]):
3020         (-[WebFrame _defersCallbacksChanged]):
3021         (-[WebFrame _currentBackForwardListItemToResetTo]):
3022         (-[WebFrame _itemForSavingDocState]):
3023         (-[WebFrame _itemForRestoringDocState]):
3024         (-[WebFrame _saveDocumentAndScrollState]):
3025         (-[WebFrame _shouldTreatURLAsSameAsCurrent:]):
3026         (-[WebFrame _loadRequest:inFrameNamed:]):
3027         (-[WebFrame _initWithWebFrameView:webView:bridge:]):
3028         (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
3029         (-[WebFrame _frameLoader]):
3030         (-[WebFrame _prepareForDataSourceReplacement]):
3031         (-[WebFrame _restoreScrollPositionAndViewState]):
3032         (-[WebFrame _firstLayoutDone]):
3033         (-[WebFrame _loadType]):
3034         (-[WebFrame frameView]):
3035         (-[WebFrame provisionalDataSource]):
3036         (-[WebFrame dataSource]):
3037         (-[WebFrame loadRequest:]):
3038         (-[WebFrame loadArchive:]):
3039         (-[WebFrame stopLoading]):
3040         (-[WebFrame reload]):
3041         (-[WebFrame _resetBackForwardList]):
3042         (-[WebFrame _invalidateCurrentItemPageCache]):
3043         (-[WebFrame _provisionalItemIsTarget]):
3044         (-[WebFrame _loadProvisionalItemFromPageCache]):
3045         * WebView/WebFrameInternal.h:
3046
3047 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
3048
3049         Reviewed by Darin.
3050         
3051         - move remaining movable data fields from WebFrameLoader to WebFrame
3052
3053         * Loader/WebDocumentLoadState.m:
3054         (-[WebDocumentLoadState commitIfReady]):
3055         * Loader/WebFrameLoader.h:
3056         * Loader/WebFrameLoader.m:
3057         (-[WebFrameLoader provisionalLoadStarted]):
3058         (-[WebFrameLoader _setState:]):
3059         (-[WebFrameLoader stopLoadingSubframes]):
3060         (-[WebFrameLoader stopLoading]):
3061         (-[WebFrameLoader startLoading]):
3062         (-[WebFrameLoader _receivedMainResourceError:complete:]):
3063         (-[WebFrameLoader clientRedirectCancelledOrFinished:]):
3064         (-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
3065         (-[WebFrameLoader shouldReloadForCurrent:andDestination:]):
3066         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
3067         (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]):
3068         (-[WebFrameLoader closeOldDataSources]):
3069         (-[WebFrameLoader commitProvisionalLoad:]):
3070         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
3071         (-[WebFrameLoader isQuickRedirectComing]):
3072         * Loader/WebFrameLoaderClient.h:
3073         * WebCoreSupport/WebFrameBridge.h:
3074         * WebCoreSupport/WebFrameBridge.m:
3075         (-[WebFrameBridge frameLoader]):
3076         (-[WebFrameBridge setTitle:]):
3077         (-[WebFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
3078         (-[WebFrameBridge reportClientRedirectCancelled:]):
3079         (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):
3080         * WebView/WebDataSource.m:
3081         (-[WebDataSource _loadFromPageCache:]):
3082         * WebView/WebFrame.m:
3083         (-[NSView setWebFrame::]):
3084         (-[WebFrame _addHistoryItemForFragmentScroll]):
3085         (-[WebFrame _didFinishLoad]):
3086         (-[WebFrame _provisionalLoadStarted]):
3087         (-[WebFrame _checkLoadCompleteForThisFrame]):
3088         (-[WebFrame _loadItem:withLoadType:]):
3089         (-[WebFrame _loadURL:referrer:intoChild:]):
3090         (-[WebFrame _frameLoadCompleted]):
3091         (-[WebFrame stopLoading]):
3092         (-[WebFrame _invalidateCurrentItemPageCache]):
3093         * WebView/WebFrameInternal.h:
3094
3095 2006-10-08  Darin Adler  <darin@apple.com>
3096
3097         Rubber stamped by Maciej.
3098
3099         - changed "document load state" to "document loader"
3100
3101         * Loader/WebDocumentLoadState.h: Removed.
3102         * Loader/WebDocumentLoadState.m: Removed.
3103         * Loader/WebDocumentLoader.h: Added.
3104         * Loader/WebDocumentLoader.m: Added.
3105         (-[WebDocumentLoader setMainDocumentError:]):
3106         (-[WebDocumentLoader mainReceivedError:complete:]):
3107         (-[WebDocumentLoader finishedLoading]):
3108         (-[WebDocumentLoader commitLoadWithData:]):
3109         (-[WebDocumentLoader setupForReplaceByMIMEType:]):
3110         (-[WebDocumentLoader updateLoading]):
3111         (-[WebDocumentLoader setTitle:]):
3112         * Loader/WebFrameLoader.h:
3113         * Loader/WebFrameLoader.m:
3114         (-[WebFrameLoader dealloc]):
3115         (-[WebFrameLoader activeDocumentLoader]):
3116         (-[WebFrameLoader activeDataSource]):
3117         (-[WebFrameLoader addPlugInStreamLoader:]):
3118         (-[WebFrameLoader removePlugInStreamLoader:]):
3119         (-[WebFrameLoader addSubresourceLoader:]):
3120         (-[WebFrameLoader removeSubresourceLoader:]):
3121         (-[WebFrameLoader dataSource]):
3122         (-[WebFrameLoader setDocumentLoader:]):
3123         (-[WebFrameLoader documentLoader]):
3124         (-[WebFrameLoader policyDataSource]):
3125         (-[WebFrameLoader setPolicyDocumentLoader:]):
3126         (-[WebFrameLoader clearDataSource]):
3127         (-[WebFrameLoader provisionalDataSource]):
3128         (-[WebFrameLoader provisionalDocumentLoader]):
3129         (-[WebFrameLoader setProvisionalDocumentLoader:]):
3130         (-[WebFrameLoader _clearProvisionalDataSource]):
3131         (-[WebFrameLoader _setState:]):
3132         (-[WebFrameLoader clearProvisionalLoad]):
3133         (-[WebFrameLoader commitProvisionalLoad]):
3134         (-[WebFrameLoader stopLoading]):
3135         (-[WebFrameLoader startLoading]):
3136         (-[WebFrameLoader startProvisionalLoad:]):
3137         (-[WebFrameLoader setupForReplace]):
3138         (-[WebFrameLoader _didReceiveResponse:forResource:]):
3139         (-[WebFrameLoader _originalRequest]):
3140         (-[WebFrameLoader _receivedMainResourceError:complete:]):
3141         (-[WebFrameLoader _receivedData:]):
3142         (-[WebFrameLoader _setRequest:]):
3143         (-[WebFrameLoader _isStopping]):
3144         (-[WebFrameLoader _setupForReplaceByMIMEType:]):
3145         (-[WebFrameLoader _setResponse:]):
3146         (-[WebFrameLoader _mainReceivedError:complete:]):
3147         (-[WebFrameLoader _finishedLoading]):
3148         (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]):
3149         (-[WebFrameLoader _loadRequest:archive:]):
3150         (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
3151         (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]):
3152         (-[WebFrameLoader reload]):
3153         (-[WebFrameLoader finishedLoadingDocument:]):
3154         (-[WebFrameLoader committedLoadWithDocumentLoader:data:]):
3155         (-[WebFrameLoader revertToProvisionalWithDocumentLoader:]):
3156         (-[WebFrameLoader documentLoader:setMainDocumentError:]):
3157         (-[WebFrameLoader documentLoader:mainReceivedCompleteError:]):
3158         (-[WebFrameLoader finalSetupForReplaceWithDocumentLoader:]):
3159         (-[WebFrameLoader willChangeTitleForDocument:]):
3160         (-[WebFrameLoader didChangeTitleForDocument:]):
3161         (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]):
3162         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
3163         (-[WebFrameLoader loadDataSource:withLoadType:formState:]):
3164         * Plugins/WebPluginController.m:
3165         (-[WebPluginController pluginView:receivedResponse:]):
3166         * WebCoreSupport/WebFrameBridge.m:
3167         (-[WebFrameBridge setTitle:]):
3168         (-[WebFrameBridge receivedData:textEncodingName:]):
3169         * WebKit.xcodeproj/project.pbxproj:
3170         * WebView/WebDataSource.m:
3171         (-[WebDataSourcePrivate dealloc]):
3172         (-[WebDataSource _mainDocumentError]):
3173         (-[WebDataSource _loadFromPageCache:]):
3174         (-[WebDataSource _bridge]):
3175         (-[WebDataSource _webView]):
3176         (-[WebDataSource _URLForHistory]):
3177         (-[WebDataSource _documentLoader]):
3178         (-[WebDataSource _initWithDocumentLoader:]):
3179         (-[WebDataSource initWithRequest:]):
3180         (-[WebDataSource dealloc]):
3181         (-[WebDataSource data]):
3182         (-[WebDataSource webFrame]):
3183         (-[WebDataSource initialRequest]):
3184         (-[WebDataSource request]):
3185         (-[WebDataSource response]):
3186         (-[WebDataSource textEncodingName]):
3187         (-[WebDataSource isLoading]):
3188         (-[WebDataSource unreachableURL]):
3189         (-[WebDataSource webArchive]):
3190         * WebView/WebDataSourceInternal.h:
3191         * WebView/WebDocumentLoadStateMac.h: Removed.
3192         * WebView/WebDocumentLoadStateMac.m: Removed.
3193         * WebView/WebDocumentLoaderMac.h: Added.
3194         * WebView/WebDocumentLoaderMac.m: Added.
3195         * WebView/WebFrame.m:
3196         (-[WebFrame _createItem:]):
3197         (-[WebFrame _receivedMainResourceError:]):
3198         (-[WebFrame _transitionToCommitted:]):
3199         (-[WebFrame _opened]):
3200         (-[WebFrame _checkLoadCompleteForThisFrame]):
3201         (-[WebFrame _loadItem:withLoadType:]):
3202         (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:formState:]):
3203         (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
3204         (-[WebFrame _addChild:]):
3205         (-[WebFrame _provisionalLoadStarted]):
3206         (-[WebFrame _dataSourceForDocumentLoader:]):
3207         (-[WebFrame _createDocumentLoaderWithRequest:]):
3208         * WebView/WebFrameInternal.h:
3209         * WebView/WebHTMLRepresentation.m:
3210         (-[WebHTMLRepresentation title]):
3211         * WebView/WebView.m:
3212         (-[WebView _mainFrameOverrideEncoding]):
3213
3214 2006-10-08  Darin Adler  <darin@apple.com>
3215
3216         Reviewed by Mitz.
3217
3218         - fix http://bugs.webkit.org/show_bug.cgi?id=11218
3219           REGRESSION: Assertion failure in WebFrameLoader when going back from a file: or data: URL
3220
3221         Also added a helper function in WebFrameLoader so that checks for back/forward load types
3222         are easier to read.
3223
3224         * Loader/WebFrameLoader.m:
3225         (-[WebFrameLoader _setPolicyDocumentLoadState:]): Fixed line of code that was setting the load
3226         state to nil instead of the passed-in object.
3227         (isBackForwardLoadType): Added.
3228         (-[WebFrameLoader shouldReloadToHandleUnreachableURLFromRequest:]): Use isBackForwardLoadType.
3229         (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]):
3230         Ditto.
3231         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): Ditto.
3232
3233 2006-10-08  Darin Adler  <darin@apple.com>
3234
3235         Reviewed by Maciej.
3236
3237         - fix two recently introduced leaks: one of an NSString, the other of a WebDataSource
3238
3239         * Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState setTitle:]):
3240         Rearranged code to avoid storage leak in case of identical title.
3241
3242         * Loader/WebFrameLoader.h: Removed _setPolicyDocumentLoadState: method
3243         from the header.
3244         * Loader/WebFrameLoader.m:
3245         (-[WebFrameLoader _setPolicyDocumentLoadState:]): Added logic to call detachFromFrameLoader
3246         as needed if this load state is going away rather than moving on to become the provisional
3247         load state.
3248         (-[WebFrameLoader shouldReloadToHandleUnreachableURLFromRequest:]): Tweaked formatting.
3249         (-[WebFrameLoader _loadRequest:archive:]): Added an assertion.
3250         (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): Added an assertion.
3251         (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]): Added an assertion.
3252         (-[WebFrameLoader reload]): Added an assertion.
3253         (-[WebFrameLoader loadDataSource:withLoadType:formState:]): Added a local variable to avoid
3254         calling _documentLoadState over and over again.
3255
3256 2006-10-07  Don Gibson  <dgibson77@gmail.com>
3257
3258         Reviewed/landed by Adam.
3259
3260         http://bugs.webkit.org/show_bug.cgi?id=11199
3261         Update Session History when a load is committed rather than completed.
3262
3263         * COM/WebFrame.cpp:
3264         (WebFrame::receivedResponse):
3265         (WebFrame::receivedAllData):
3266
3267 2006-10-07  Sam Weinig  <sam.weinig@gmail.com>
3268
3269         Reviewed by Tim H.
3270
3271         Patch for http://bugs.webkit.org/show_bug.cgi?id=11198
3272         Auto-generate a few more Objective-C DOM interfaces
3273
3274         * MigrateHeaders.make:
3275
3276 2006-10-07  Mark Rowe  <bdash@webkit.org>
3277
3278         Reviewed by Mitz.
3279
3280         Fix memory leak from -[WebDocumentLoadState setTitle:].
3281
3282         * Loader/WebDocumentLoadState.m:
3283         (-[WebDocumentLoadState setTitle:]): Ensure 'trimmed' is released even when length is
3284         zero, and untangle the confusing logic around this case.
3285
3286 2006-10-06  Brady Eidson  <beidson@apple.com>
3287
3288         Reviewed by Darin
3289
3290         Refactored a whole bunch of WebFramePrivate.h SPI to WebFrameInternal
3291
3292         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
3293         * History/WebHistoryItem.m:
3294         * Loader/WebFrameLoader.h:
3295         * Misc/WebCoreStatistics.m:
3296         * Misc/WebElementDictionary.m:
3297         * Plugins/WebNetscapePluginEmbeddedView.m:
3298         * Plugins/WebPluginController.m:
3299         * WebCoreSupport/WebViewFactory.m:
3300         * WebView/WebArchiver.m:
3301         * WebView/WebDataSource.m:
3302         * WebView/WebFrame.m:
3303         (-[WebFrame _isDescendantOfFrame:]):
3304         (-[WebFrame _setShouldCreateRenderers:]):
3305         (-[WebFrame _bodyBackgroundColor]):
3306         (-[WebFrame _isFrameSet]):
3307         (-[WebFrame _firstLayoutDone]):
3308         (-[WebFrame _loadType]):
3309         * WebView/WebFrameInternal.h:
3310         * WebView/WebFramePrivate.h:
3311         * WebView/WebHTMLRepresentation.m:
3312         * WebView/WebScriptDebugDelegate.m:
3313
3314 2006-10-06  Maciej Stachowiak  <mjs@apple.com>
3315
3316         Reviewed by Darin.
3317         
3318         - Move all delegate dispatching code out of WebDataSource.
3319
3320         * Loader/WebFrameLoader.m:
3321         (-[WebFrameLoader startLoading]):
3322         (-[WebFrameLoader _identifierForInitialRequest:]):
3323         (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]):
3324         (-[WebFrameLoader _didReceiveAuthenticationChallenge:forResource:]):
3325         (-[WebFrameLoader _didCancelAuthenticationChallenge:forResource:]):
3326         (-[WebFrameLoader _didReceiveResponse:forResource:]):
3327         (-[WebFrameLoader _didReceiveData:contentLength:forResource:]):
3328         (-[WebFrameLoader _didFinishLoadingForResource:]):
3329         (-[WebFrameLoader _didFailLoadingWithError:forResource:]):
3330         (-[WebFrameLoader _receivedMainResourceError:complete:]):
3331         (-[WebFrameLoader _downloadWithLoadingConnection:request:response:proxy:]):
3332         (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]):
3333         * WebView/WebDataSource.m:
3334         (-[WebDataSource _setLoadingFromPageCache:]):
3335         (-[WebDataSource _stopLoadingWithError:]):
3336         * WebView/WebDataSourceInternal.h:
3337
3338 2006-10-06  Darin Adler  <darin@apple.com>
3339
3340         Reviewed by Maciej.
3341
3342         - moved firstLayoutDone BOOL from WebFrame to WebFrameLoader
3343
3344         * Loader/WebFrameLoader.h:
3345         * Loader/WebFrameLoader.m:
3346         (-[WebFrameLoader didFirstLayout]):
3347         (-[WebFrameLoader provisionalLoadStarted]):
3348         (-[WebFrameLoader frameLoadCompleted]):
3349         (-[WebFrameLoader firstLayoutDone]):
3350         * WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge didFirstLayout]):
3351         * WebView/WebFrame.m:
3352         (-[WebFrame _firstLayoutDone]):
3353         (-[WebFrame _provisionalLoadStarted]):
3354         (-[WebFrame _frameLoadCompleted]):
3355         (-[WebFrame _restoreScrollPositionAndViewState]):
3356         * WebView/WebFrameInternal.h:
3357
3358 2006-10-06  Darin Adler  <darin@apple.com>
3359
3360         Reviewed by Maciej.
3361
3362         - moved more data and the corresponding code from WebFrame to WebFrameLoader
3363
3364         * Loader/WebFrameLoader.h:
3365         * Loader/WebFrameLoader.m:
3366         (-[WebFrameLoader cannotShowMIMETypeForURL:]):
3367         (-[WebFrameLoader _checkNavigationPolicyForRequest:andCall:withSelector:]):
3368         (-[WebFrameLoader shouldReloadToHandleUnreachableURLFromRequest:]):
3369         (-[WebFrameLoader _loadRequest:archive:]):
3370         (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
3371         (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]):
3372         (-[WebFrameLoader reload]):
3373         (-[WebFrameLoader invalidatePendingPolicyDecisionCallingDefaultAction:]):
3374         (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]):
3375         (-[WebFrameLoader _continueAfterNewWindowPolicy:]):
3376         (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]):
3377         (-[WebFrameLoader continueAfterNavigationPolicy:]):
3378         (-[WebFrameLoader continueAfterWillSubmitForm:]):
3379         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
3380         (-[WebFrameLoader loadDataSource:withLoadType:formState:]):
3381         (-[WebFrameLoader handleUnimplementablePolicyWithErrorCode:forURL:]):
3382         (-[WebFrameLoader delegateIsHandlingProvisionalLoadError]):
3383         (-[WebFrameLoader setDelegateIsHandlingProvisionalLoadError:]):
3384         * Loader/WebFrameLoaderClient.h:
3385         * WebView/WebFrame.m:
3386         (-[NSView setWebFrame::]):
3387         (-[WebFramePrivate dealloc]):
3388         (-[WebFrame _checkLoadCompleteForThisFrame]):
3389         (-[WebFrame _loadItem:withLoadType:]):
3390         (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
3391         (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
3392         (-[WebFrame _loadRequest:inFrameNamed:]):
3393         (-[WebFrame stopLoading]):
3394         (-[WebFrame _resetBackForwardList]):
3395         (-[WebFrame _quickRedirectComing]):
3396         (-[WebFrame _provisionalItemIsTarget]):
3397         (-[WebFrame _loadProvisionalItemFromPageCache]):
3398         * WebView/WebFrameInternal.h:
3399         * WebView/WebFramePrivate.h:
3400
3401         * WebKit.xcodeproj/project.pbxproj:
3402
3403 2006-10-06  Maciej Stachowiak  <mjs@apple.com>
3404
3405         Rubber stamped by Darin.
3406         
3407         - removed includes of unused headers.
3408
3409         * WebView/WebDataSource.m:
3410
3411 2006-10-06  Maciej Stachowiak  <mjs@apple.com>
3412
3413         Not reviewed.
3414         
3415         - fix build breakage
3416
3417         * Loader/WebFrameLoader.m:
3418         (-[WebFrameLoader willChangeTitleForDocumentLoadState:]):
3419         (-[WebFrameLoader didChangeTitleForDocumentLoadState:]):
3420
3421 2006-10-06  Maciej Stachowiak  <mjs@apple.com>
3422
3423         Reviewed by Darin.
3424         
3425         - move remaining movable WebDataSource fields to WebDocumentLoadState
3426
3427         * Loader/WebDocumentLoadState.h:
3428         * Loader/WebDocumentLoadState.m:
3429         (-[WebDocumentLoadState dealloc]):
3430         (-[WebDocumentLoadState isLoadingInAPISense]):
3431         (-[WebDocumentLoadState addResponse:]):
3432         (-[WebDocumentLoadState stopRecordingResponses]):
3433         (-[WebDocumentLoadState title]):
3434         (-[WebDocumentLoadState setLastCheckedRequest:]):
3435         (-[WebDocumentLoadState lastCheckedRequest]):
3436         (-[WebDocumentLoadState triggeringAction]):
3437         (-[WebDocumentLoadState setTriggeringAction:]):
3438         (-[WebDocumentLoadState responses]):
3439         (-[WebDocumentLoadState setOverrideEncoding:]):
3440         (-[WebDocumentLoadState overrideEncoding]):
3441         (-[WebDocumentLoadState setTitle:]):
3442         * Loader/WebFrameLoader.h:
3443         * Loader/WebFrameLoader.m:
3444         (-[WebFrameLoader _setState:]):
3445         (-[WebFrameLoader _loadRequest:archive:]):
3446         (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
3447         (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]):
3448         (-[WebFrameLoader reload]):
3449         (-[WebFrameLoader willChangeTitleForDocumentLoadState:]):
3450         (-[WebFrameLoader didChangeTitleForDocumentLoadState:]):
3451         * WebCoreSupport/WebFrameBridge.m:
3452         (-[WebFrameBridge setTitle:]):
3453         (-[WebFrameBridge receivedData:textEncodingName:]):
3454         * WebView/WebDataSource.m:
3455         (-[WebDataSourcePrivate dealloc]):
3456         (-[WebDataSource _didReceiveResponse:forResource:]):
3457         (-[WebDataSource textEncodingName]):
3458         * WebView/WebDataSourceInternal.h:
3459         * WebView/WebFrame.m:
3460         (-[WebFrame _opened]):
3461         (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]):
3462         (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
3463         (-[WebFrame _addChild:]):
3464         (-[WebFrame _loadDataSource:withLoadType:formState:]):
3465         * WebView/WebHTMLRepresentation.m:
3466         (-[WebHTMLRepresentation title]):
3467         * WebView/WebView.m:
3468         (-[WebView _mainFrameOverrideEncoding]):
3469
3470 2006-10-06  Darin Adler  <darin@apple.com>
3471
3472         Reviewed by Maciej.
3473
3474         - moved loadType into WebFrameLoader
3475
3476         * WebView/WebFramePrivate.h: Removed _setLoadType, but not _loadType because it's
3477         currently used by Safari.
3478
3479         * Loader/WebFrameLoader.h:
3480         * Loader/WebFrameLoader.m:
3481         (-[WebFrameLoader _loadRequest:archive:]):
3482         (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
3483         (-[WebFrameLoader isReplacing]):
3484         (-[WebFrameLoader setReplacing]):
3485         (-[WebFrameLoader loadType]):
3486         (-[WebFrameLoader setLoadType:]):
3487         * WebCoreSupport/WebFrameBridge.m:
3488         (-[WebFrameBridge isLoadTypeReload]):
3489         * WebView/WebFrame.m:
3490         (-[WebFrame _loadType]):
3491         (-[WebFrame _transitionToCommitted:]):
3492         (-[WebFrame _commitProvisionalLoad:]):
3493         (-[WebFrame _opened]):
3494         (-[WebFrame _checkLoadCompleteForThisFrame]):
3495         (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
3496         (-[WebFrame _loadURL:referrer:intoChild:]):
3497         (-[WebFrame _currentBackForwardListItemToResetTo]):
3498         (-[WebFrame _itemForRestoringDocState]):
3499         (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
3500         (-[WebFrame _didFirstLayout]):
3501         (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
3502         (-[WebFrame _provisionalLoadStarted]):
3503         (-[WebFrame loadRequest:]):
3504
3505 2006-10-06  Darin Adler  <darin@apple.com>
3506
3507         Reviewed by Maciej.
3508
3509         - added WebFrameLoaderClient protocol -- to be used to make WebFrameLoader forget all about WebFrame
3510
3511         * Loader/WebDocumentLoadState.h: Added comment about Maciej's planned renaming here.
3512         * Loader/WebFrameLoader.h:
3513         * Loader/WebFrameLoader.m: Renamed webFrame to client and added the new protocol.
3514         Eventually we'll be removing the dependency on WebFrame entirely.
3515         * WebView/WebFrame.m: (-[WebFrame _initWithWebFrameView:webView:bridge:]): Update to call the method
3516         by its new name.
3517
3518         * Loader/WebFrameLoaderClient.h: Added.
3519         * WebKit.xcodeproj/project.pbxproj: Updated for new file, sorted things.
3520
3521 2006-10-06  Maciej Stachowiak  <mjs@apple.com>
3522
3523         Reviewed by Darin.
3524         
3525         - segregate WebFrame methods into ones that should be moved into WebFrameLoader and ones that don't need to
3526         
3527         Also removed useless WebFrameLoader part
3528
3529         * WebView/WebFrame.m:
3530         (-[WebFramePrivate dealloc]): 
3531
3532 2006-10-06  Maciej Stachowiak  <mjs@apple.com>
3533
3534         Reviewed by Anders.
3535         
3536         - moved more data from WebDataSource to WebDocumentLoadState
3537
3538         * Loader/WebDocumentLoadState.h:
3539         * Loader/WebDocumentLoadState.m:
3540         (-[WebDocumentLoadState commitLoadWithData:]):
3541         (-[WebDocumentLoadState prepareForLoadStart]):
3542         (-[WebDocumentLoadState loadingStartedTime]):
3543         (-[WebDocumentLoadState setIsClientRedirect:]):
3544         (-[WebDocumentLoadState isClientRedirect]):
3545         (-[WebDocumentLoadState setPrimaryLoadComplete:]):
3546         (-[WebDocumentLoadState isLoadingInAPISense]):
3547         * Loader/WebFrameLoader.h:
3548         * Loader/WebFrameLoader.m:
3549         (-[WebFrameLoader _setState:]):
3550         (-[WebFrameLoader _finishedLoading]):
3551         (-[WebFrameLoader documentLoadState:mainReceivedCompleteError:]):
3552         (-[WebFrameLoader prepareForLoadStart]):
3553         (-[WebFrameLoader subframeIsLoading]):
3554         * WebView/WebDataSource.m:
3555         (-[WebDataSource _fileWrapperForURL:]):
3556         (-[WebDataSource _startLoading]):
3557         (-[WebDataSource _loadFromPageCache:]):
3558         (-[WebDataSource isLoading]):
3559         * WebView/WebDataSourceInternal.h:
3560         * WebView/WebFrame.m:
3561         (-[WebFrame _transitionToCommitted:]):
3562         (-[WebFrame _opened]):
3563         (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
3564
3565 2006-10-06  Alexey Proskuryakov  <ap@nypop.com>
3566
3567         Reviewed by Darin.
3568
3569         http://bugs.webkit.org/show_bug.cgi?id=11183
3570         REGRESSION: Safari loads error pages unstyled
3571
3572         * WebView/WebFrame.m:
3573         (-[WebFrame _loadHTMLString:baseURL:unreachableURL:]):
3574         Use utf-8 encoding instead of the string's "fastest" encoding.
3575
3576 2006-10-06  Maciej Stachowiak  <mjs@apple.com>
3577
3578         Reviewed by Adam.
3579         
3580         - fixed the following bugs:
3581         
3582         http://bugs.webkit.org/show_bug.cgi?id=11136
3583         "REGRESSION: Safari snippet editor doesn't work"
3584         http://bugs.webkit.org/show_bug.cgi?id=11140
3585         "REGRESSION: view source window blank"
3586         http://bugs.webkit.org/show_bug.cgi?id=11146
3587         "REGRESSION: Instead of showing the error page, Safari opens its Resources folder in the Finder"
3588         
3589         Possibly more.
3590
3591         * Loader/WebDocumentLoadState.h:
3592         * Loader/WebDocumentLoadState.m:
3593         (-[WebDocumentLoadState actualRequest]): New method.
3594         * WebView/WebDataSource.m:
3595         (-[WebDataSource _startLoading]): We need to make sure not to start loading the main
3596         resource with the fake external request for an applewebdata: request.
3597
3598 2006-10-05  Adele Peterson  <adele@apple.com>
3599
3600         Reviewed by the letter 'B'.
3601
3602         More build fixes.
3603
3604         * WebKit.xcodeproj/project.pbxproj:
3605         * WebView/WebDynamicScrollBarsView.h:
3606         * WebView/WebDynamicScrollBarsView.m:
3607         (-[WebDynamicScrollBarsView updateScrollers]):
3608         (-[WebDynamicScrollBarsView setAllowsScrolling:]):
3609         (-[WebDynamicScrollBarsView allowsScrolling]):
3610         (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]):
3611         (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]):
3612         (-[WebDynamicScrollBarsView allowsHorizontalScrolling]):
3613         (-[WebDynamicScrollBarsView allowsVerticalScrolling]):
3614         (-[WebDynamicScrollBarsView horizontalScrollingMode]):
3615         (-[WebDynamicScrollBarsView verticalScrollingMode]):
3616         (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]):
3617         (-[WebDynamicScrollBarsView setVerticalScrollingMode:]):
3618         (-[WebDynamicScrollBarsView setScrollingMode:]):
3619         * WebView/WebView.m:
3620         (-[WebView setAlwaysShowVerticalScroller:]):
3621         (-[WebView alwaysShowVerticalScroller]):
3622         (-[WebView setAlwaysShowHorizontalScroller:]):
3623         (-[WebView alwaysShowHorizontalScroller]):
3624
3625 2006-10-05  Vladimir Olexa  <vladimir.olexa@gmail.com>
3626
3627         Reviewed by Timothy.
3628
3629         Bug: http://bugs.webkit.org/show_bug.cgi?id=9887
3630         Continuous spell checking now remembers user's setting. The change is applied globally,
3631         meaning, both TextArea and TextField are affected when either of them enables/disables
3632         spell checking. 
3633
3634         * WebView/WebPreferenceKeysPrivate.h: added a define for WebContinuousSpellCheckingEnabled
3635         * WebView/WebView.m:
3636         (-[WebViewPrivate init]): reads WebContinuousSpellCheckingEnabled from NSUserDefaults
3637         (-[WebView setContinuousSpellCheckingEnabled:]):
3638         (-[WebView isContinuousSpellCheckingEnabled]):
3639
3640 2006-10-05  MorganL  <morganl.webkit@yahoo.com>
3641
3642         Reviewed by Darin.
3643
3644         Fixes http://bugs.webkit.org/show_bug.cgi?id=11162
3645
3646         * COM/WebFrame.cpp:
3647         (WebFrame::loadDataSource):
3648         (WebFrame::receivedResponse):
3649
3650 2006-10-05  Don Gibson  <dgibson77@gmail.com>
3651
3652         Reviewed by Darin, landed by Adam.
3653
3654         http://bugs.webkit.org/show_bug.cgi?id=11176
3655         Fix win32 build, adapt to Maciej's ResourceLoader changes.
3656
3657         * COM/WebFrame.cpp:
3658         (WebFrame::loadDataSource):
3659
3660 2006-10-05  Marvin Decker  <marv.decker@gmail.com>
3661
3662         Reviewed by Darin.
3663
3664         http://bugs.webkit.org/show_bug.cgi?id=10989
3665         Provide a way for embedders to implement BrowserExtensionWin
3666
3667         * COM/Interfaces/IWebUIDelegate.idl:
3668         * COM/WebFrame.cpp:
3669         (WebFrame::createNewWindow):
3670         * COM/WebFrame.h:
3671
3672 2006-10-04  Mark Rowe  <bdash@webkit.org>
3673
3674         Reviewed by NOBODY (build fix).
3675
3676         * WebView/WebView.m:
3677         (-[WebView scrollDOMRangeToVisible:]): Move scrollDOMRangeToVisible: into the correct category.
3678
3679 2006-09-26  David Smith  <catfish.man@gmail.com>
3680
3681         Reviewed by Timothy.
3682
3683         http://bugs.webkit.org/show_bug.cgi?id=3723
3684         Add -scrollDOMRangeToVisible:
3685
3686         * WebView/WebView.m:
3687         (-[WebView scrollDOMRangeToVisible:]):
3688         * WebView/WebViewPrivate.h:
3689
3690 2006-10-03  Graham Dennis  <graham.dennis@gmail.com>
3691
3692         Reviewed by Timothy.
3693
3694         <http://bugs.webkit.org/show_bug.cgi?id=10338>
3695         When contentEditable, cursor doesn't change to hand
3696         
3697         Allow the behaviour of editable links to be specified by a WebPreference
3698         The preference WebKitEditableLinkBehavior has four options:
3699          - AlwaysLive: Safari 2.0 behaviour
3700          - OnlyLiveWithShiftKey: Firefox/WinIE behaviour (and prior WebKit-ToT behaviour)
3701          - LiveWhenNotFocused: Editable links are live only when their editable block is not
3702              focused, or when the shift key is pressed
3703          - DefaultBehavior: This is the same as OnlyLiveWithShiftKey.
3704          
3705         No layout tests, just a modification of a manual-test as it isn't possible to test
3706         this automatically.
3707
3708         * WebView/WebPreferenceKeysPrivate.h:
3709         * WebView/WebPreferences.m:
3710         (+[WebPreferences initialize]):
3711         (-[WebPreferences editableLinkBehavior]):
3712         (-[WebPreferences setEditableLinkBehavior:]):
3713         * WebView/WebPreferencesPrivate.h:
3714         * WebView/WebView.m:
3715         (-[WebView _updateWebCoreSettingsFromPreferences:]):
3716
3717 2006-10-03  Justin Garcia  <justin.garcia@apple.com>
3718
3719         Reviewed by harrison
3720         
3721         execCommand("Cut"/"Copy"/"Paste") broken in editable subframes.
3722
3723         * WebCoreSupport/WebFrameBridge.m:
3724         (-[WebFrameBridge issueCutCommand]): Issue the command on the WebHTMLView, not the WebView.
3725         (-[WebFrameBridge issueCopyCommand]): Ditto.
3726         (-[WebFrameBridge issuePasteCommand]): Ditto.
3727         (-[WebFrameBridge issuePasteAndMatchStyleCommand]): Ditto.
3728         (-[WebFrameBridge issueTransposeCommand]): Fixed formatting.
3729         (-[WebFrameBridge canPaste]): Ask the WebHTMLView, not the WebView.
3730         * WebView/WebHTMLView.m:
3731         (-[WebHTMLView copy:]): Moved to WebInternal
3732         (-[WebHTMLView cut:]): Ditto.
3733         (-[WebHTMLView paste:]): Ditto.
3734         (-[WebHTMLView pasteAsPlainText:]): Ditto.
3735         * WebView/WebHTMLViewInternal.h:
3736         * WebView/WebView.m: Removed the now unused _canPaste.
3737         * WebView/WebViewInternal.h: Ditto.
3738
3739 2006-10-03  Justin Garcia  <justin.garcia@apple.com>
3740
3741         Reviewed by geoff
3742         
3743         <rdar://problem/4763519> REGRESSION: Multipart/x-mixed-replace sub-resources fail to load
3744
3745         * Loader/WebSubresourceLoader.m:
3746         (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]): 
3747         Enable multipart/x-mixed-replace support on the request.  This line was accidently removed during 
3748         some loader refactoring.
3749
3750 2006-10-02  Adam Roben  <aroben@apple.com>
3751
3752         Reviewed by Maciej.
3753
3754         Add message paramter to WebView::mouse* methods to pass down to
3755         PlatformMouseEvent.
3756
3757         * COM/WebView.cpp:
3758         (WebView::mouseMoved):
3759         (WebView::mouseDown):
3760         (WebView::mouseUp):
3761         (WebView::mouseDoubleClick):
3762         (WebViewWndProc):
3763         * COM/WebView.h:
3764
3765 2006-10-02  Maciej Stachowiak  <mjs@apple.com>
3766
3767         Reviewed by Alice.
3768         
3769         - take away direct knowledge of WebFrame from WebDataSource
3770
3771         * Loader/WebDocumentLoadState.h:
3772         * Loader/WebDocumentLoadState.m:
3773         (-[WebDocumentLoadState setFrameLoader:]):
3774         (-[WebDocumentLoadState detachFromFrameLoader]):
3775         * Loader/WebFrameLoader.m:
3776         (-[WebFrameLoader _setDocumentLoadState:]):
3777         (-[WebFrameLoader _setProvisionalDocumentLoadState:]):
3778         * WebView/WebDataSource.m:
3779         * WebView/WebDataSourceInternal.h:
3780         * WebView/WebDocumentLoadStateMac.m:
3781         (-[WebDocumentLoadStateMac detachFromFrameLoader]):
3782         * WebView/WebFrame.m:
3783         (-[WebFrame _loadDataSource:withLoadType:formState:]):
3784
3785 2006-10-02  Maciej Stachowiak  <mjs@apple.com>
3786
3787         Reviewed by Darin.
3788         
3789         - move a big slice of data and logic from WebDataSource to WebDocumentLoadState
3790         
3791         * Loader/WebDocumentLoadState.h:
3792         * Loader/WebDocumentLoadState.m:
3793         (-[WebDocumentLoadState initWithRequest:]):
3794         (-[WebDocumentLoadState dealloc]):
3795         (-[WebDocumentLoadState originalRequestCopy]):
3796         (-[WebDocumentLoadState request]):
3797         (-[WebDocumentLoadState replaceRequestURLForAnchorScrollWithURL:]):
3798         (-[WebDocumentLoadState setRequest:]):
3799         (-[WebDocumentLoadState setResponse:]):
3800         (-[WebDocumentLoadState isStopping]):
3801         (-[WebDocumentLoadState bridge]):
3802         (-[WebDocumentLoadState setMainDocumentError:]):
3803         (-[WebDocumentLoadState mainDocumentError]):
3804         (-[WebDocumentLoadState clearErrors]):
3805         (-[WebDocumentLoadState mainReceivedError:complete:]):
3806         (-[WebDocumentLoadState stopLoading]):
3807         (-[WebDocumentLoadState setupForReplace]):
3808         (-[WebDocumentLoadState commitIfReady]):
3809         (-[WebDocumentLoadState finishedLoading]):
3810         (-[WebDocumentLoadState setCommitted:]):
3811         (-[WebDocumentLoadState isCommitted]):
3812         (-[WebDocumentLoadState setLoading:]):
3813         (-[WebDocumentLoadState isLoading]):
3814         (-[WebDocumentLoadState commitLoadWithData:]):
3815         (-[WebDocumentLoadState doesProgressiveLoadWithMIMEType:]):
3816         (-[WebDocumentLoadState receivedData:]):
3817         (-[WebDocumentLoadState setupForReplaceByMIMEType:]):
3818         (-[WebDocumentLoadState updateLoading]):
3819         (-[WebDocumentLoadState response]):
3820         * Loader/WebFrameLoader.h:
3821         * Loader/WebFrameLoader.m:
3822         (-[WebFrameLoader activeDocumentLoadState]):
3823         (-[WebFrameLoader activeDataSource]):
3824         (-[WebFrameLoader _archivedSubresourceForURL:]):
3825         (-[WebFrameLoader addPlugInStreamLoader:]):
3826         (-[WebFrameLoader removePlugInStreamLoader:]):
3827         (-[WebFrameLoader addSubresourceLoader:]):
3828         (-[WebFrameLoader removeSubresourceLoader:]):
3829         (-[WebFrameLoader documentLoadState]):
3830         (-[WebFrameLoader provisionalDocumentLoadState]):
3831         (-[WebFrameLoader stopLoading]):
3832         (-[WebFrameLoader _originalRequest]):
3833         (-[WebFrameLoader _receivedData:]):
3834         (-[WebFrameLoader _setRequest:]):
3835         (-[WebFrameLoader bridge]):
3836         (-[WebFrameLoader _handleFallbackContent]):
3837         (-[WebFrameLoader _isStopping]):
3838         (-[WebFrameLoader _setupForReplaceByMIMEType:]):
3839         (-[WebFrameLoader _setResponse:]):
3840         (-[WebFrameLoader _mainReceivedError:complete:]):
3841         (-[WebFrameLoader _finishedLoading]):
3842         (-[WebFrameLoader didReceiveServerRedirectForProvisionalLoadForFrame]):
3843         (-[WebFrameLoader finishedLoadingDocumentLoadState:]):
3844         (-[WebFrameLoader commitProvisitionalLoad]):
3845         (-[WebFrameLoader committedLoadWithDocumentLoadState:data:]):
3846         (-[WebFrameLoader isReplacing]):
3847         (-[WebFrameLoader setReplacing]):
3848         (-[WebFrameLoader revertToProvisionalWithDocumentLoadState:]):
3849         (-[WebFrameLoader documentLoadState:setMainDocumentError:]):
3850         (-[WebFrameLoader documentLoadState:mainReceivedCompleteError:]):
3851         (-[WebFrameLoader finalSetupForReplaceWithDocumentLoadState:]):
3852         * WebView/WebDataSource.m:
3853         (-[WebDataSourcePrivate dealloc]):
3854         (-[WebDataSource _prepareForLoadStart]):
3855         (-[WebDataSource _mainDocumentError]):
3856         (-[WebDataSource _finishedLoading]):
3857         (-[WebDataSource _receivedData:]):
3858         (-[WebDataSource _setMainDocumentError:]):
3859         (-[WebDataSource _clearUnarchivingState]):
3860         (-[WebDataSource _revertToProvisionalState]):
3861         (-[WebDataSource _receivedMainResourceError:complete:]):
3862         (-[WebDataSource _startLoading]):
3863         (-[WebDataSource _loadFromPageCache:]):
3864         (-[WebDataSource _bridge]):
3865         (-[WebDataSource _setPrimaryLoadComplete:]):
3866         (-[WebDataSource _URLForHistory]):
3867         (-[WebDataSource _setTitle:]):
3868         (-[WebDataSource _initWithDocumentLoadState:]):
3869         (-[WebDataSource request]):
3870         (-[WebDataSource response]):
3871         (-[WebDataSource isLoading]):
3872         (-[WebDataSource webArchive]):
3873         * WebView/WebDataSourceInternal.h:
3874         * WebView/WebDocumentLoadStateMac.m:
3875         (-[WebDocumentLoadStateMac initWithRequest:]):
3876         * WebView/WebFrame.m:
3877         (-[WebFrame _createItem:]):
3878         (-[WebFrame _receivedMainResourceError:]):
3879         (-[WebFrame _transitionToCommitted:]):
3880         (-[WebFrame _commitProvisionalLoad:]):
3881         (-[WebFrame _checkLoadCompleteForThisFrame]):
3882         (-[WebFrame _loadItem:withLoadType:]):
3883         (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:formState:]):
3884         (-[WebFrame _didReceiveServerRedirectForProvisionalLoadForFrame]):
3885         (-[WebFrame _provisionalLoadStarted]):
3886         * WebView/WebFrameInternal.h:
3887
3888 2006-10-02  Justin Garcia  <justin.garcia@apple.com>
3889
3890         Reviewed by john
3891         
3892         <rdar://problem/4757583>
3893         REGRESSION: tabbing into page focuses wrong control on 2nd pass
3894         <rdar://problem/4757594>
3895         REGRESSION: Form field is left with secondary selection after tabbing out of WebView
3896
3897         * WebView/WebHTMLView.m:
3898         (-[NSArray maintainsInactiveSelection]): Replace code that I removed in error in the patch
3899         for 9642.  Only leave inactive editable selections in the WebHTMLView if the nextResponder 
3900         is in the same WebView.
3901
3902 2006-10-02  Maciej Stachowiak  <mjs@apple.com>
3903
3904         Reviewed by Anders.
3905         
3906         - remove webFrame field from WebDataSourcePrivate, it can get it from WebDocumentLoadState now
3907
3908         * Loader/WebDocumentLoadState.h:
3909         * Loader/WebDocumentLoadState.m:
3910         (-[WebDocumentLoadState frameLoader]):
3911         * WebView/WebDataSource.m:
3912         (-[WebDataSourcePrivate dealloc]):
3913         (-[WebDataSource _revertToProvisionalState]):
3914         (-[WebDataSource _setupForReplaceByMIMEType:]):
3915         (-[WebDataSource _updateLoading]):
3916         (-[WebDataSource _startLoading]):
3917         (-[WebDataSource _setWebFrame:]):
3918         (-[WebDataSource _defersCallbacksChanged]):
3919         (-[WebDataSource _stopLoading]):
3920         (-[WebDataSource _webView]):
3921         (-[WebDataSource _stopLoadingWithError:]):
3922         (-[WebDataSource _setPrimaryLoadComplete:]):
3923         (-[WebDataSource dealloc]):
3924         (-[WebDataSource webFrame]):
3925         (-[WebDataSource isLoading]):
3926
3927 2006-10-02  Maciej Stachowiak  <mjs@apple.com>
3928
3929         Reviewed by Anders.
3930         
3931         - fix crash on back/forward - reattach WebDocumentLoadState to data source when needed
3932
3933         * WebView/WebDataSource.m:
3934         (-[WebDataSource _setWebFrame:]):
3935         (-[WebDataSource _initWithDocumentLoadState:]):
3936         * WebView/WebDataSourceInternal.h:
3937
3938 2006-10-02  Maciej Stachowiak  <mjs@apple.com>
3939
3940         Build fix, not reviewed.
3941         
3942         - Added missing files to fix build.
3943
3944         * WebView/WebDocumentLoadStateMac.h: Added.
3945         * WebView/WebDocumentLoadStateMac.m: Added.
3946         (-[WebDocumentLoadStateMac initWithRequest:]):
3947         (-[WebDocumentLoadStateMac dealloc]):
3948         (-[WebDocumentLoadStateMac setDataSource:]):
3949         (-[WebDocumentLoadStateMac dataSource]):
3950         (-[WebDocumentLoadStateMac setFrameLoader:]):
3951
3952 2006-10-01  Maciej Stachowiak  <mjs@apple.com>
3953
3954         Reviewed by Brady and Oliver.
3955         
3956         - move things around so that WebDataSource and WebDocumentLoadState know about each other in
3957         the right way. This lines things up to move nearly all functionality down to WebDocumentLoadState.
3958
3959         * Loader/WebDocumentLoadState.h:
3960         * Loader/WebDocumentLoadState.m:
3961         (-[WebDocumentLoadState initWithRequest:]):
3962         (-[WebDocumentLoadState dealloc]):
3963         (-[WebDocumentLoadState originalRequest]):
3964         * Loader/WebFrameLoader.h:
3965         * Loader/WebFrameLoader.m:
3966         (-[WebFrameLoader dealloc]):
3967         (-[WebFrameLoader addSubresourceLoader:]):
3968         (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]):
3969         (-[WebFrameLoader dataSource]):
3970         (-[WebFrameLoader _setDocumentLoadState:]):
3971         (-[WebFrameLoader policyDataSource]):
3972         (-[WebFrameLoader _setPolicyDocumentLoadState:]):
3973         (-[WebFrameLoader clearDataSource]):
3974         (-[WebFrameLoader provisionalDataSource]):
3975         (-[WebFrameLoader _setProvisionalDocumentLoadState:]):
3976         (-[WebFrameLoader _clearProvisionalDataSource]):
3977         (-[WebFrameLoader _setState:]):
3978         (-[WebFrameLoader clearProvisionalLoad]):
3979         (-[WebFrameLoader commitProvisionalLoad]):
3980         (-[WebFrameLoader stopLoading]):
3981         (-[WebFrameLoader startLoading]):
3982         (-[WebFrameLoader startProvisionalLoad:]):
3983         (-[WebFrameLoader setupForReplace]):
3984         (-[WebFrameLoader activeDocumentLoadState]):
3985         (-[WebFrameLoader activeDataSource]):
3986         (-[WebFrameLoader _loadRequest:archive:]):
3987         (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
3988         (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]):
3989         (-[WebFrameLoader reload]):
3990         * WebKit.xcodeproj/project.pbxproj:
3991         * WebView/WebDataSource.m:
3992         (-[WebDataSourcePrivate dealloc]):
3993         (-[WebDataSource _startLoading]):
3994         (-[WebDataSource _setWebFrame:]):
3995         (-[WebDataSource _documentLoadState]):
3996         (-[WebDataSource _initWithDocumentLoadState:]):
3997         (-[WebDataSource initWithRequest:]):
3998         (-[WebDataSource initialRequest]):
3999         (-[WebDataSource unreachableURL]):
4000         * WebView/WebDataSourceInternal.h:
4001         * WebView/WebFrame.m:
4002         (-[WebFramePrivate dealloc]):
4003         (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
4004         (-[WebFrame _loadDataSource:withLoadType:formState:]):
4005         (-[WebFrame _policyDataSource]):
4006         (-[WebFrame _shouldReloadToHandleUnreachableURLFromRequest:]):
4007         (-[WebFrame _dataSourceForDocumentLoadState:]):
4008         (-[WebFrame _createDocumentLoadStateWithRequest:]):
4009         * WebView/WebFrameInternal.h:
4010
4011 2006-09-29  David Hyatt  <hyatt@apple.com>
4012
4013         Change the default minimum font size pref to 0 in order to allow
4014         font-size:0 to work.
4015
4016         * WebView/WebPreferences.m:
4017         (+[WebPreferences initialize]):
4018
4019 2006-09-28  Timothy Hatcher  <timothy@apple.com>
4020
4021         Reviewed by Maciej.
4022
4023         Switch the inspector over to use border-image with styled buttons and selects.
4024
4025         * WebInspector/WebInspector.m:
4026         (-[NSWindow window]):
4027         (-[NSWindow setWebFrame:]):
4028         (-[WebInspector _updateRoot]):
4029         * WebInspector/webInspector/Images/button.png: Added.
4030         * WebInspector/webInspector/Images/buttonDivider.png: Added.
4031         * WebInspector/webInspector/Images/buttonPressed.png: Added.
4032         * WebInspector/webInspector/Images/popup.png: Added.
4033         * WebInspector/webInspector/Images/popupFill.png: Removed.
4034         * WebInspector/webInspector/Images/popupFillPressed.png: Removed.
4035         * WebInspector/webInspector/Images/popupLeft.png: Removed.
4036         * WebInspector/webInspector/Images/popupLeftPressed.png: Removed.
4037         * WebInspector/webInspector/Images/popupPressed.png: Added.
4038         * WebInspector/webInspector/Images/popupRight.png: Removed.
4039         * WebInspector/webInspector/Images/popupRightPressed.png: Removed.
4040         * WebInspector/webInspector/Images/squareButtonRight.png: Removed.
4041         * WebInspector/webInspector/Images/squareButtonRightPressed.png: Removed.
4042         * WebInspector/webInspector/inspector.css:
4043         * WebInspector/webInspector/inspector.html:
4044         * WebInspector/webInspector/inspector.js:
4045
4046 2006-09-28  Alice Liu  <alice.liu@apple.com>
4047
4048         fixing the windows build
4049
4050         * COM/WebView.cpp:
4051         (WebView::mouseMoved):
4052         (WebView::mouseDown):
4053         (WebView::mouseUp):
4054         (WebView::mouseDoubleClick):
4055
4056 2006-09-27  Justin Garcia  <justin.garcia@apple.com>
4057
4058         Reviewed by thatcher
4059         
4060         <rdar://problem/4044271>
4061         Writing Direction menu doesn't reflect the current writing direction (9773)
4062
4063         * English.lproj/Localizable.strings: Added "Right to Left" and "Left to Right"
4064         * WebView/WebHTMLView.m:
4065         (-[NSArray validateUserInterfaceItem:]): Validate menu items that perform
4066         toggleBaseWritingDirection and changeBaseWritingDirection.  
4067         Disable the menu item that changes the writing direction to NSWritingDirectionNautral
4068         because NSWritingDirectionNatural's behavior can't be implemented with CSS.
4069         Take control of the title of the menu item that performs toggleBaseWritingDirection:
4070         instead of checking/unchecking it, otherwise we wouldn't know what a check means.
4071         (-[NSArray changeBaseWritingDirection:]): ASSERT that the requested writing
4072         direction is not NSWritingDirectionNatural, since we've disabled the
4073         menu item that performs it.
4074
4075 2006-09-27  MorganL  <morganl.webkit@yahoo.com>
4076
4077         Reviewed by Maciej, landed by Brady
4078
4079         Update URL request associated with provisional data source on redirect.
4080         Notify IWebFrameLoadDelegate of redirects for the provisional load.
4081         Notify IWebFrameLoadDelegate of a provisional load being commited.
4082
4083         * COM/WebDataSource.cpp:
4084         (WebDataSource::replaceRequest):
4085         * COM/WebDataSource.h:
4086         * COM/WebFrame.cpp:
4087         (WebFrame::receivedRedirect):
4088         (WebFrame::receivedResponse):
4089         (WebFrame::receivedData):
4090
4091 2006-09-26  John Sullivan  <sullivan@apple.com>
4092
4093         Reviewed by Darin
4094
4095         * WebView/WebHTMLViewPrivate.h:
4096         * WebView/WebHTMLView.m:
4097         (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]):
4098         Added limit parameter, passed over the bridge. Stop the search if it hits limit.
4099
4100         * WebView/WebViewPrivate.h:
4101         * WebView/WebView.m:
4102         (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):
4103         Added limit parameter, passed to WebHTMLView.
4104
4105 2006-09-26  David Harrison  <harrison@apple.com>
4106
4107         Reviewed by John and TimH.
4108
4109         <rdar://problem/4743256> Seed: Ctrl-Y key binding does nothing when kill ring is empty
4110
4111         Use deleteBackward: when the killring string is empty. Was always using insertText:,
4112         but that ends up early-returning if the string to insert is empty.
4113         
4114         * WebView/WebHTMLView.m:
4115         (-[NSArray yank:]):
4116         (-[NSArray yankAndSelect:]):
4117
4118 2006-09-25  Timothy Hatcher  <timothy@apple.com>
4119
4120         Reviewed by Brady.
4121
4122         Use the non-deprecated method names for getComputedStyle, setEnd and setStart.
4123
4124         * WebInspector/WebInspector.m:
4125         (-[WebInspector _highlightNode:]):
4126         * WebView/WebHTMLView.m:
4127         (unionDOMRanges):
4128         (-[WebHTMLView _selectRangeInMarkedText:]):
4129         (-[WebTextCompleteController doCompletion]):
4130         * WebView/WebView.m:
4131         (-[WebView computedStyleForElement:pseudoElement:]):
4132
4133 2006-09-22  Timothy Hatcher  <timothy@apple.com>
4134
4135         Reviewed by Darin.
4136
4137         Pass all headers through unifdef to filter out BUILDING_ON_TIGER blocks
4138         if MACOSX_DEPLOYMENT_TARGET is 10.4.
4139
4140         * MigrateHeaders.make:
4141
4142 2006-09-20  Justin Garcia  <justin.garcia@apple.com>
4143
4144         Reviewed by john
4145         
4146         <http://bugs.webkit.org/show_bug.cgi?id=7165>
4147         TinyMCE: Dragging & dropping content always leaves a copy when editing inside a subframe
4148         
4149         The top level WebHTMLView is responsible for performing dragging operations, but
4150         the inner view, the view that holds the drag caret, should be consulted to determine
4151         if the drag is a move drag.
4152
4153         * WebCoreSupport/WebFrameBridge.m:
4154         (-[WebFrameBridge startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
4155         * WebKit.xcodeproj/project.pbxproj:
4156         * WebView/WebHTMLView.m:
4157         (-[NSArray dragImage:at:offset:event:pasteboard:source:slideBack:]): Don't set initatedDrag here, because
4158         it's only the top level WebHTMLView that performs this operation.
4159         (-[WebHTMLView _setInitiatedDrag:]): Added.
4160         (-[WebHTMLView _initiatedDrag]): Ditto.
4161         (-[WebHTMLView _canProcessDragWithDraggingInfo:]): Ask the innerView if it initiated the drag,
4162         not the top level view.
4163         (-[WebHTMLView _isMoveDrag]): The top level view asks the innerView if it should perform
4164         a move drag, so don't ASSERT _isTopHTMLView.
4165         (-[WebHTMLView draggingUpdatedWithDraggingInfo:actionMask:]): Ask the innerView if _isMoveDrag.
4166         (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): Ditto.
4167         * WebView/WebHTMLViewInternal.h: Added two private SPI so that
4168         the top level WebHTMLView can set and get the initiatedDrag BOOL.
4169
4170 === Safari-521.27 ===
4171
4172 2006-09-20  Brady Eidson  <beidson@apple.com>
4173
4174         Reviewed by Tim Omernick
4175
4176         Fixing part of a crash Tim O showed me.  [WebIconDatabase init] should finish
4177         gracefully even if we can't open the database
4178
4179         * Misc/WebIconDatabase.m:
4180         (-[WebIconDatabase init]):
4181
4182 2006-09-20  Timothy Hatcher  <timothy@apple.com>
4183
4184         Reviewed by Tim O.
4185
4186         <rdar://problem/4741392> Develop a system to find what version of WebKit an app was linked with
4187
4188         * Misc/WebKitVersionChecks.h: Added.
4189         * Misc/WebKitVersionChecks.m: Added.
4190         (WebKitLinkedOnOrAfter): Added.
4191         (WebKitLinkTimeVersion): Added.
4192         (WebKitRunTimeVersion): Added.
4193         * WebKit.xcodeproj/project.pbxproj:
4194
4195 2006-09-20  Tim Omernick  <timo@apple.com>
4196
4197         Reviewed by Darin.
4198
4199         * Misc/WebIconDatabase.m:
4200         (-[WebIconDatabase init]):
4201         Fixed a typo.
4202
4203 2006-09-20  Brady Eidson  <beidson@apple.com>
4204
4205         Reviewed by Darin
4206
4207         Preparing to make the WebIconDatabase disabled by default - this patch tells the bridge whether its enabled or not
4208
4209         * Misc/WebIconDatabase.m:
4210         (-[WebIconDatabase init]):
4211
4212 2006-09-19  Brady Eidson <beidson@apple.com>
4213