LayoutTests:
[WebKit-https.git] / WebKit / ChangeLog
1 2006-12-02  Geoffrey Garen  <ggaren@apple.com>
2
3         Reviewed by Darin Adler.
4         
5         Added SPI for enabling Dashboard backward compatibility mode. For now,
6         we enable it unconditionally for Dashboard and Dashcode. Once they 
7         implement specific support for the backward compatibility mode behavior,
8         we can change that.
9         
10         Set the default WebDashboardBehaviorUseBackwardCompatibilityModeEnabled
11         to YES in order to turn this code on.
12
13         * WebView/WebView.mm:
14         (-[WebView _setDashboardBehavior:to:]):
15         (-[WebView _dashboardBehavior:]):
16         * WebView/WebViewPrivate.h:
17
18 2006-12-04  Darin Adler  <darin@apple.com>
19
20         Reviewed by Alice.
21
22         * WebCoreSupport/WebEditorClient.h: Removed "_web_" prefix from
23         C++ userVisibleString member function.
24         * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::userVisibleString):
25         Ditto.
26
27         * WebView/WebView.mm: (-[WebView selectedFrame]): Removed extra return statement.
28
29 2006-12-04  Don Gibson  <dgibson77@gmail.com>
30
31         Reviewed and landed by Alexey.
32
33         http://bugs.webkit.org/show_bug.cgi?id=11738:
34         Make link clicking work again on Windows.
35
36         The WebKit changes are to ignore WM_MOUSEMOVED messages when the mouse
37         hasn't actually moved, which were preventing clicks from actually
38         getting dispatched in many cases.  It's a peculiarity of Windows mouse
39         handling that we receive these at all.
40
41         * COM/WebView.cpp:
42         (WebView::WebView):
43         (WebView::mouseMoved):
44         * COM/WebView.h:
45
46 2006-12-04  John Sullivan  <sullivan@apple.com>
47
48         Reviewed by Anders
49
50         - fixed <rdar://problem/4857833> REGRESSION: When ctrl-clicking on a misspelled word, "Ignore Spelling" and "Learn Spelling" 
51           menu items not displayed in the contextual menu
52
53         * WebView/WebHTMLView.m:
54         (-[WebHTMLView _isSelectionMisspelled]):
55         We were computing isSelectionMisspelled by calling WebCore, but then ignoring the result and always
56         returning NO. D'oh!
57
58 2006-12-01  Beth Dakin  <bdakin@apple.com>
59
60         Reviewed by Adam.
61
62         Changes to support sub-menus in WebCore ContextMenus.
63
64         * WebCoreSupport/WebContextMenuClient.mm:
65         (WebContextMenuClient::contextMenuItemSelected): 
66         ContextMenuItem::menu() is now called parentMenu()
67         * WebView/WebUIDelegatePrivate.h: New not-yet-API tags.
68
69 2006-12-01  Darin Adler  <darin@apple.com>
70
71         Reviewed by Mitz.
72
73         - fix http://bugs.webkit.org/show_bug.cgi?id=11628
74           REGRESSION (r17597): Command-return in native text fields doesn't open a new tab or window
75
76         * WebCoreSupport/WebFrameLoaderClient.mm:
77         (findKeyStateEvent): Added. Helper that finds the mouse or keyboard event in a chain
78         of events and their underlying events.
79         (findMouseEvent): Added. Same, but specifically for mouse events.
80         (WebFrameLoaderClient::actionDictionary): Rewrote to use the above functions. This means we
81         use the modifiers from the underlying events rather than just the one from the event itself.
82         So if the event is a DOM activate event, we can still see the modifiers from the original
83         keyboard event that triggered it. Has no effect if the event is already the right type or
84         if there is no underlying event.
85
86         * WebView/WebFrame.mm: Added a newly-needed include.
87
88         * WebKit.xcodeproj/project.pbxproj: Xcode wants what it wants.
89
90 2006-12-01  Don Gibson  <dgibson77@gmail.com>
91
92         Reviewed by Mitz.
93
94         http://bugs.webkit.org/show_bug.cgi?id=11732:
95         Windows build bustage.
96
97         * COM/WebFrame.cpp:
98         (WebFrame::initWithName):
99
100 2006-12-01  Timothy Hatcher  <timothy@apple.com>
101
102         Reviewed by Adam.
103
104         <rdar://problem/4841432> 9A312: iWeb crashes on launch; _WebReportError missing from WebKit
105
106         Added back WebReportAssertionFailure and WebReportError for apps that still need these symbols.
107
108         * Misc/OldWebAssertions.c: Added.
109         (WebReportAssertionFailure):
110         (WebReportError):
111         * WebKit.LP64.exp: added the new symbols, and sorted the file
112         * WebKit.exp: added the new symbols, and sorted the file
113         * WebKit.xcodeproj/project.pbxproj:
114
115 2006-11-30  Geoffrey Garen  <ggaren@apple.com>
116
117         Rubber Stamped by Anders Carlsson.
118
119         Global rename of Document::focusNode to Document::focusedNode. 'focusNode'
120         suggested a command, and conflicted with a different meaning for 'focusNode'
121         in the Mozilla selection API.
122
123         * WebView/WebHTMLView.m:
124         (-[NSArray clearFocus]):
125
126 2006-11-30  Matt Lilek  <pewtermoose@gmail.com>
127
128         Reviewed by Mitz.
129
130         Bug 10698: Scroll wheel causes inspector to shift up
131         http://bugs.webkit.org/show_bug.cgi?id=10698
132
133         Remove size attribute from the tree popup as a workaround for
134         http://bugs.webkit.org/show_bug.cgi?id=11362 Bug 11362: Native popup with size="1" wraps options
135
136         * WebInspector/webInspector/inspector.css:
137         * WebInspector/webInspector/inspector.html:
138
139 2006-11-30  Matt Lilek  <pewtermoose@gmail.com>
140
141         Reviewed by Tim H.
142
143         Move web inspector style markup to javascript to fix http://bugs.webkit.org/show_bug.cgi?id=6724
144         Bug 6724: Text copied from Web Inspector is different from actual text
145
146         * WebInspector/webInspector/inspector.css:
147         * WebInspector/webInspector/inspector.js:
148
149 2006-11-30  Adam Roben  <aroben@apple.com>
150
151         Reviewed by Beth.
152
153         Put code in place to use WebCore context menus when they are turned
154         on.
155
156         * WebView/WebHTMLView.m:
157         (-[NSArray menuForEvent:]):
158
159 2006-11-29  Timothy Hatcher  <timothy@apple.com>
160
161         Reviewed by Oliver.
162
163         Keep preferences separate from the rest of the client, making sure we are using expected preference values.
164         This lets the inspector work when plugins are disabled for the WebView.
165
166         * WebInspector/WebInspector.m:
167         (-[NSWindow window]):
168
169 2006-11-29  Anders Carlsson  <acarlsson@apple.com>
170
171         Reviewed by Tim.
172
173         Add back methods in WebCoreStatistics that are still used by Tiger Safari.
174         
175         * Misc/WebCoreStatistics.h:
176         * Misc/WebCoreStatistics.m:
177         (+[WebCoreStatistics emptyCache]):
178         (+[WebCoreStatistics setCacheDisabled:]):
179
180 2006-11-28  Alice Liu  <alice.liu@apple.com>
181
182         Reviewed by Maciej.
183
184         A fix for a couple failing layout tests involving copy/cut in iframes.
185
186         * WebCoreSupport/WebEditorClient.h:
187         * WebCoreSupport/WebEditorClient.mm:
188         (WebEditorClient::dataForArchivedSelection):
189         Use the frame parameter instead of using the webview's selectedFrame. 
190
191 2006-11-28  Beth Dakin  <bdakin@apple.com>
192
193         Reviewed by Geoffff.
194
195         Fix for http://bugs.webkit.org/show_bug.cgi?id=11691 REGRESSION 
196         (r17399, r17511): WebElementDictionary no longer returns nil 
197         NSStrings
198
199         String's NSString* operator converts null Strings to empty 
200         NSStrings for compatibility with AppKit. We need to work around 
201         that here.
202
203         * Misc/WebElementDictionary.m:
204         (NSStringOrNil):
205         (-[WebElementDictionary _altDisplayString]):
206         (-[WebElementDictionary _spellingToolTip]):
207         (-[WebElementDictionary _title]):
208         (-[WebElementDictionary _titleDisplayString]):
209         (-[WebElementDictionary _textContent]):
210
211 2006-11-28  Geoffrey Garen  <ggaren@apple.com>
212
213         Reviewed by Beth Dakin.
214
215         Fixed <rdar://problem/4844855> Should clarify when to create clients in 
216         the WebCore client API
217         
218         All clients must now be supplied as constructor arguments. This clarifies 
219         when you need to create clients, and also guarantees that objects can't 
220         (for the most part) be in a clientless state.
221
222         Layout tests pass. No leaks reported.
223         
224         * WebCoreSupport/WebFrameBridge.mm: Shuffled around initialization and changed
225         some arguments to resolve ciruclar dependencies at init time.
226         (-[WebFrame _initWithWebFrameView:webView:bridge:]): We no longer call setClient
227         here, because the client is set up at construction time.
228
229 2006-11-28  Anders Carlsson  <acarlsson@apple.com>
230
231         Reviewed by Maciej.
232
233         Update for changes to ResourceRequest.
234         
235         * WebCoreSupport/WebChromeClient.mm:
236         (WebChromeClient::createWindow):
237         (WebChromeClient::createModalDialog):
238         * WebCoreSupport/WebFrameLoaderClient.mm:
239         (WebFrameLoaderClient::canHandleRequest):
240
241 2006-11-28  Adam Roben  <aroben@apple.com>
242
243         Reviewed by Beth.
244
245         More WebCore context menu work.
246
247         * DefaultDelegates/WebDefaultUIDelegate.m: New stub delegate method implementation.
248         (-[NSApplication webView:contextMenuItemSelected:forElement:]):
249         * WebCoreSupport/WebContextMenuClient.h: Updated to match ContextMenuClient.h changes.
250         * WebCoreSupport/WebContextMenuClient.mm:
251         (WebContextMenuClient::addCustomContextMenuItems): Updated for method name changes.
252         (WebContextMenuClient::contextMenuItemSelected): Added new client method.
253         * WebView/WebUIDelegatePrivate.h: New private delegate method declaration.
254
255 2006-11-28  Alice Liu  <alice.liu@apple.com>
256
257         Reviewed by Justin and Adam.
258
259         * WebCoreSupport/WebEditorClient.h:
260         * WebCoreSupport/WebEditorClient.mm:
261         added the following        
262         (WebEditorClient::smartInsertDeleteEnabled):
263         (WebEditorClient::dataForArchivedSelectionInFrame):
264         (WebEditorClient::_web_userVisibleString):
265         (WebEditorClient::shouldInsertNode):
266         
267         * WebKitPrefix.h:
268         Added flags to control whether WebCore cut/copy/paste is enabled.
269         Turned on Cut and Copy, left Paste and Delete off
270         
271         * WebView/WebHTMLViewPrivate.h:
272         * WebView/WebHTMLView.m:
273         removed _can[Cut|Copy|Paste|Delete]
274         (-[NSArray validateUserInterfaceItem:]):
275         call the editor for canDHTML[C|C|P|D] and _can[C|C|P|D] instead 
276         (-[NSArray delete:]):
277         added code to call the editor's delete instead (not turned on)
278         (-[WebHTMLView copy:]):
279         added code to call the editor's copy (turned on)
280         (-[WebHTMLView cut:]):
281         added code to call the editor's cut (turned on)
282         (-[WebHTMLView paste:]):
283         added code to call the editor's paste (not turned on)
284
285 2006-11-28  Geoffrey Garen  <ggaren@apple.com>
286
287         Reviewed by Adam.
288
289         Fixed <rdar://problem/4844848> REGRESSION: extra cross-library ref/deref 
290         calls cause .5% PLT regression.
291         
292         Changed ref/deref calls to a single 'xxxDestroyed' call. Moved EditorClient
293         from the Frame to the Page, since it's only responsible for
294         Webview-level delegate calls.
295         
296         I don't really love this design, but it fixes the regression and allows
297         a single WebKit object to implement multiple client interfaces.
298         
299         Layout tests pass.
300
301 2006-11-27  Beth Dakin  <bdakin@apple.com>
302
303         Reviewed by Adam.
304
305         WebKit half of getting rid of the FixMes in ContextMenu.cpp
306
307         * WebCoreSupport/WebFrameLoaderClient.h: canHandleRequest takes a 
308         ResourceRequest now.
309         * WebCoreSupport/WebFrameLoaderClient.mm:
310         (WebFrameLoaderClient::canHandleRequest): Same.
311         * WebView/WebHTMLView.m:
312         (-[WebHTMLView _isSelectionMisspelled]): Call into WebCore.
313
314 2006-11-27  Ada Chan  <adachan@apple.com>
315
316         Reviewed by Adam.
317
318         Part of the change to move WebCoreCache into WebKit:
319         Added WebCache which handles emptying and enable/disabling the cache.
320         emptyCache and setCacheDisabled have been removed from WebCoreStatistics.
321
322         * Misc/WebCache.h: Added.
323         * Misc/WebCache.mm: Added.
324         * Misc/WebCoreStatistics.h:
325         * Misc/WebCoreStatistics.m:
326         (+[WebCoreStatistics statistics]):
327         * WebKit.exp:
328         * WebKit.xcodeproj/project.pbxproj:
329
330 2006-11-27  Anders Carlsson  <acarlsson@apple.com>
331
332         Reviewed by Adam.
333
334         Move addMessageToConsole to Chrome.
335
336         * WebCoreSupport/WebChromeClient.h:
337         * WebCoreSupport/WebChromeClient.mm:
338         (WebChromeClient::addMessageToConsole):
339         * WebCoreSupport/WebFrameBridge.mm:
340
341 2006-11-27  Brady Eidson  <beidson@apple.com>
342
343         Reviewed by Anders
344
345         Moved unused Private SPI to Internal and pruned other unused code
346
347         * Misc/WebIconDatabase.m:
348         * Misc/WebIconDatabasePrivate.h:
349
350 2006-11-21  Darin Adler  <darin@apple.com>
351
352         Reviewed by Maciej.
353
354         - make the close method do a more-complete job to prevent world leaks seen when
355           running some of the layout tests
356
357         * WebView/WebHTMLViewInternal.h: Added declaration of -[WebHTMLViewPrivate clear].
358         * WebView/WebHTMLView.m:
359         (-[WebHTMLViewPrivate clear]): Added method to drop references to other objects.
360         We want to do this at "close" time, rather than waiting for deallocation time.
361         This is especially important for the data source, which indirectly keeps a number of
362         objects alive.
363         (-[WebHTMLView close]): Added an explicit call to clear out the data source on the
364         plug-in controller. Without this, we'd see the plug-in controller making calls to
365         a deallocated data source during the layout tests. Added a call to the new clear method
366         on the private object so that we release the objects at close time instead of waiting
367         for deallocation time.
368
369         * WebKit.xcodeproj/project.pbxproj: Let Xcode have its way with the project file,
370         because I can't fight the power.
371
372 2006-11-20  Samuel Weinig  <sam@webkit.org>
373
374         Reviewed by Alexey.
375
376         Fix for http://bugs.webkit.org/show_bug.cgi?id=11656
377         Fix Windows build
378
379         * WebKit.vcproj/WebKit.vcproj: don't include directories that no
380         longer exist.
381
382 2006-11-19  Beth Dakin  <bdakin@apple.com>
383
384         Reviewed by Adam.
385
386         WebKit side of new context menu actions.
387
388         * WebCoreSupport/WebContextMenuClient.h: These are for the 
389         currently-WebKit-dependent menu actions.
390         * WebCoreSupport/WebContextMenuClient.mm:
391         (WebContextMenuClient::copyLinkToClipboard):
392         (WebContextMenuClient::downloadURL):
393         (WebContextMenuClient::copyImageToClipboard):
394         (WebContextMenuClient::searchWithSpotlight):
395         (WebContextMenuClient::lookUpInDictionary):
396         * WebCoreSupport/WebEditorClient.h:
397         * WebCoreSupport/WebEditorClient.mm:
398         (core): These are to convert between WebViewInsertAction and 
399         EditorInsertAction.
400         (kit):
401         (WebEditorClient::shouldInsertText): Added implementation for 
402         shouldInsertText.
403         * WebKit.xcodeproj/project.pbxproj:
404         * WebView/WebHTMLView.m:
405         (-[WebHTMLView _lookUpInDictionaryFromMenu:]): Moved 
406         _lookUpInDictionary to be within the implementation of WebHTMLView 
407         internal.
408         * WebView/WebHTMLViewInternal.h: Add _lookUpInDictionaryFromMenu
409         * WebView/WebViewInternal.h: Add _searchWithSpotlightFromMenu
410
411 2006-11-18  Don Gibson  <dgibson77@gmail.com>
412
413         Reviewed by Sam Weinig.
414
415         http://bugs.webkit.org/show_bug.cgi?id=11634:
416         Fix segfault on startup for Windows build.  Also fix segfault when
417         typing in a URL.
418
419         * COM/WebFrame.cpp:
420         (WebFrame::initWithName):
421
422 === Safari-521.31 ===
423
424 2006-11-17  Timothy Hatcher  <timothy@apple.com>
425
426         Reviewed by Geoff.
427
428         <rdar://problem/4841044> Temporarily default Mail.app editable link clicking behavior, until they do it themselves
429
430         * WebKit.xcodeproj/project.pbxproj:
431         * WebView/WebView.mm:
432         (+[WebView initialize]):
433         (-[WebView setPreferences:]):
434
435 2006-11-16  Don Gibson  <dgibson77@gmail.com>
436
437         Reviewed and landed by ap.
438
439         http://bugs.webkit.org/show_bug.cgi?id=11509:
440         Windows build bustage.
441
442         * COM/WebFrame.cpp:
443         (WebFrame::initWithName):
444         (WebFrame::loadHTMLString):
445         (WebFrame::stopLoading):
446         (WebFrame::reload):
447         (WebFrame::loadDataSource):
448         (WebFrame::didReceiveData):
449         (WebFrame::receivedResponse):
450         (WebFrame::receivedAllData):
451         * COM/WebFrame.h:
452         * COM/WebView.cpp:
453         (WebView::mouseMoved):
454         (WebView::mouseDown):
455         (WebView::mouseUp):
456         (WebView::mouseDoubleClick):
457         * WebKit.vcproj/WebKit.vcproj:
458
459 2006-11-16  Anders Carlsson  <acarlsson@apple.com>
460
461         Reviewed by Tim.
462
463         <rdar://problem/4841123>
464         REGRESSION: Crash in WebCore::Range::boundaryPointsValid when replying to a mail Message
465         
466         * Misc/WebNSAttributedStringExtras.m:
467         (+[NSAttributedString _web_attributedStringFromRange:]):
468         If the range passed in is null, return null. When this function was in the bridge, it would never get called
469         with a null range when nothing was selected. Instead, the range would just have invalid boundary points.
470
471 2006-11-15  Adam Roben  <aroben@apple.com>
472
473         Reviewed by Anders.
474
475         Added new WebContextMenuClient class to act as WebCore's ChromeClient,
476         and moved context menu-related code there from WebChromeClient.
477
478         * WebCoreSupport/WebChromeClient.h:
479         * WebCoreSupport/WebChromeClient.mm:
480         * WebCoreSupport/WebContextMenuClient.h: Added.
481         (WebContextMenuClient::webView):
482         * WebCoreSupport/WebContextMenuClient.mm: Added.
483         (WebContextMenuClient::create):
484         (WebContextMenuClient::WebContextMenuClient):
485         (WebContextMenuClient::ref):
486         (WebContextMenuClient::deref):
487         (WebContextMenuClient::addCustomContextMenuItems):
488         * WebKit.xcodeproj/project.pbxproj: Added new files.
489         * WebView/WebView.mm:
490         (-[WebView _commonInitializationWithFrameName:groupName:]):
491
492 2006-11-15  Beth Dakin  <bdakin@apple.com>
493         &   Adam Roben  <aroben@apple.com>
494
495         Reviewed by Adam & Beth.
496
497         WebKit side of first cut at engine context menus. Use the client to 
498         call into the UIDelegate.
499
500         * WebCoreSupport/WebChromeClient.h:
501         * WebCoreSupport/WebChromeClient.mm:
502         (WebChromeClient::addCustomContextMenuItems):
503         * WebKit.xcodeproj/project.pbxproj:
504
505 2006-11-15  Brady Eidson  <beidson@apple.com>
506
507         Reviewed by Maciej
508
509         Quick change of files to ObjC++ for BF cache re-write
510
511         * History/WebBackForwardList.m: Removed.
512         * History/WebBackForwardList.mm: Added.
513         * History/WebHistoryItem.m: Removed.
514         * History/WebHistoryItem.mm: Added.
515         * WebKit.xcodeproj/project.pbxproj:
516
517 2006-11-15  Brady Eidson  <beidson@apple.com>
518
519         Reviewed by Sarge
520
521         SPI addition
522
523         * WebView/WebFrame.mm:
524         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
525         * WebView/WebFrameInternal.h:
526         * WebView/WebFramePrivate.h:
527
528 2006-11-15  Brady Eidson  <beidson@apple.com>
529
530         Reviewed by Adele
531
532         <rdar://problem/4838729> - Replace mistakenly removed SPI
533
534         * WebView/WebHTMLView.m:
535         (-[WebHTMLView _handleAutoscrollForMouseDragged:]):
536         * WebView/WebHTMLViewPrivate.h:
537
538 2006-11-15  Anders Carlsson  <acarlsson@apple.com>
539
540         Reviewed by Adele.
541
542         isTargetItem is used by DRT, so make it private instead of internal.
543         
544         * History/WebHistoryItem.m:
545         (-[WebHistoryItem isTargetItem]):
546         * History/WebHistoryItemInternal.h:
547         * History/WebHistoryItemPrivate.h:
548         * WebCoreSupport/WebFrameLoaderClient.mm:
549
550 2006-11-15  Brady Eidson  <beidson@apple.com>
551
552         Reviewed by Maciej
553
554         Split much of unused WebHistoryItemPrivate.h SPI into WebHistoryItemInternal.h
555
556         * History/WebBackForwardList.m:
557         * History/WebHistory.m:
558         * History/WebHistoryItem.m:
559         (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]):
560         (-[WebHistoryItem initWithURL:title:]):
561         (-[WebHistoryItem visitCount]):
562         (-[WebHistoryItem RSSFeedReferrer]):
563         (-[WebHistoryItem setRSSFeedReferrer:]):
564         (-[WebHistoryItem children]):
565         (-[WebHistoryItem dictionaryRepresentation]):
566         (-[WebHistoryItem setAlwaysAttemptToUsePageCache:]):
567         (+[WebHistoryItem _releaseAllPendingPageCaches]):
568         (-[WebHistoryItem URL]):
569         (-[WebHistoryItem target]):
570         (-[WebHistoryItem _setLastVisitedTimeInterval:]):
571         (-[WebHistoryItem _lastVisitedDate]):
572         (-[WebHistoryItem targetItem]):
573         * History/WebHistoryItemInternal.h: Added.
574         * History/WebHistoryItemPrivate.h:
575         * WebCoreSupport/WebFrameBridge.mm:
576         * WebCoreSupport/WebFrameLoaderClient.mm:
577         * WebKit.xcodeproj/project.pbxproj:
578         * WebView/WebFrame.mm:
579         * WebView/WebView.mm:
580
581 2006-11-14  Beth Dakin  <bdakin@apple.com>
582
583         Reviewed by Geoff.
584
585         Moving things off the bridge and onto clients.
586
587         * WebCoreSupport/WebEditorClient.h:
588         * WebCoreSupport/WebEditorClient.mm:
589         (WebEditorClient::selectWordBeforeMenuEvent):
590         (WebEditorClient::isEditable):
591         * WebCoreSupport/WebFrameBridge.mm:
592         * WebKit.xcodeproj/project.pbxproj:
593
594 2006-11-14  Timothy Hatcher  <timothy@apple.com>
595
596         Reviewed by Harrison.
597
598         <rdar://problem/4766635> Safari should never follow links in editable areas (add a WebKitEditableLinkNeverLive option)
599
600         Adds an Open Link, Open Link in New Window and Copy Link to the editing context menu.
601         Adds a new WebKitEditableLinkNeverLive preference value that maps to WebCore's EditableLinkNeverLive.
602
603         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
604         (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
605         (-[WebDefaultUIDelegate contextMenuItemsForElement:defaultMenuItems:]):
606         (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
607         (-[WebDefaultUIDelegate requestWithURL:includingReferrerFromFrame:]):
608         (-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
609         (-[WebDefaultUIDelegate openLink:]):
610         * English.lproj/Localizable.strings:
611         * WebKit.exp:
612         * WebView/WebPreferences.m:
613         (-[WebPreferences editableLinkBehavior]):
614         * WebView/WebPreferencesPrivate.h:
615         * WebView/WebUIDelegatePrivate.h:
616
617 2006-11-14  Anders Carlsson  <acarlsson@apple.com>
618
619         Turns out I wasn't forcing DWARF on the world at all, 
620         it's now the default!
621
622         * WebKit.xcodeproj/project.pbxproj:
623
624 2006-11-14  Anders Carlsson  <acarlsson@apple.com>
625
626         I must stop trying to force DWARF on the world.
627
628         * WebKit.xcodeproj/project.pbxproj:
629
630 2006-11-14  Darin Adler  <darin@apple.com>
631
632         Reviewed by Anders.
633
634         - update for creation of EventHandler
635
636         * WebCoreSupport/WebFrameLoaderClient.mm:
637         (WebFrameLoaderClient::actionDictionary):
638         * WebView/WebHTMLView.m:
639         (-[WebHTMLView _updateMouseoverWithEvent:]):
640         (-[NSArray menuForEvent:]):
641         (-[NSArray scrollWheel:]):
642         (-[NSArray acceptsFirstMouse:]):
643         (-[NSArray shouldDelayWindowOrderingForEvent:]):
644         (-[NSArray mouseDown:]):
645         (-[NSArray mouseDragged:]):
646         (-[NSArray mouseUp:]):
647         (-[NSArray keyDown:]):
648         (-[NSArray keyUp:]):
649         (-[NSArray performKeyEquivalent:]):
650         (-[WebHTMLView elementAtPoint:allowShadowContent:]):
651
652 2006-11-14  Anders Carlsson  <acarlsson@apple.com>
653
654         Fix build for real this time.
655         
656         * WebCoreSupport/WebEditorClient.mm:
657         (-[WebEditCommand initWithEditCommand:WebCore::]):
658         (-[WebEditCommand dealloc]):
659         (-[WebEditCommand finalize]):
660         (+[WebEditCommand commandWithEditCommand:]):
661         (-[WebEditCommand command]):
662
663 2006-11-14  Anders Carlsson  <acarlsson@apple.com>
664
665         Try fixing the build.
666         
667         * WebCoreSupport/WebEditorClient.mm:
668         (-[WebEditorUndoTarget undoEditing:]):
669         (-[WebEditorUndoTarget redoEditing:]):
670
671 2006-11-14  Anders Carlsson  <acarlsson@apple.com>
672
673         Reviewed by Darin.
674
675         Move undo/redo handling into WebEditorClient.
676         
677         * WebCoreSupport/WebEditorClient.h:
678         * WebCoreSupport/WebEditorClient.mm:
679         (WebEditorClient::WebEditorClient):
680         (WebEditorClient::~WebEditorClient):
681         (-[WebEditCommand initWithEditCommand:WebCore::]):
682         (-[WebEditCommand dealloc]):
683         (-[WebEditCommand finalize]):
684         (+[WebEditCommand commandWithEditCommand:]):
685         (-[WebEditCommand command]):
686         (-[WebEditorUndoTarget undoEditing:]):
687         (-[WebEditorUndoTarget redoEditing:]):
688         (undoNameForEditAction):
689         (WebEditorClient::registerCommandForUndoOrRedo):
690         (WebEditorClient::registerCommandForUndo):
691         (WebEditorClient::registerCommandForRedo):
692         (WebEditorClient::clearUndoRedoOperations):
693         (WebEditorClient::canUndo):
694         (WebEditorClient::canRedo):
695         (WebEditorClient::undo):
696         (WebEditorClient::redo):
697         * WebCoreSupport/WebFrameBridge.mm:
698         * WebKit.xcodeproj/project.pbxproj:
699
700 2006-11-14  Alexey Proskuryakov  <ap@webkit.org>
701
702         Reviewed by Tim H.
703
704         http://bugs.webkit.org/show_bug.cgi?id=3387
705         Redundant keydown, keypress, keyup events sent for arrow keys
706
707         Added another layer of ugly hacks around AppKit event dispatching.
708
709         1. For arrow keys, keyDown: is invoked after performKeyEquivalent:, so had to store
710         _private->keyDownEvent in both methods, and make it persist after leaving them.
711
712         2. For Esc, AppKit calls performKeyEquivalent: with a fake event of some kind,
713         use [NSApp currentEvent] to check for this to prevent it from being passed to  WebCore.
714
715         Test: manual-tests/arrow-key-events.html
716
717         * WebView/WebHTMLView.m:
718         (-[NSMutableDictionary dealloc]):
719         (-[NSArray keyDown:]):
720         (-[NSArray keyUp:]):
721         (-[NSArray performKeyEquivalent:]):
722         * WebView/WebHTMLViewInternal.h:
723
724 2006-11-12  Brady Eidson <beidson@apple.com>
725
726         Rubberstamped by Anders
727
728         Changed some #includes from <WebKit/foo.h> to "foo.h"
729
730         * History/WebBackForwardList.m:
731         * History/WebHistory.m:
732
733 2006-11-11  Geoffrey Garen  <ggaren@apple.com>
734
735         Reviewed by Maciej Stachowiak.
736         
737         - Fixed loader crash by clarifying ownership of WebKit client objects. 
738         WebCore objects own their WebKit clients, and ref and deref through 
739         virtual methods, leaving WebKit free to use whatever client / reference-counting 
740         implementation it likes.
741         
742         WebKit on Mac just uses the same refcounting class that WebCore uses (Shared),
743         but other platforms may choose to do other things.
744
745         * WebCoreSupport/WebChromeClient.h:
746         (WebChromeClient::ref):
747         (WebChromeClient::deref):
748         (WebChromeClient::refCount):
749         * WebCoreSupport/WebEditorClient.h: Nixed commented-out function prototypes.
750         The ones in WebCore make clear what remains to be implemented. Replaced constructor
751         with factory function to avoid leaks.
752         * WebCoreSupport/WebEditorClient.mm:
753         (WebEditorClient::create):
754         (WebEditorClient::WebEditorClient):
755         (WebEditorClient::setWebFrame):
756         * WebCoreSupport/WebFrameBridge.mm:
757         (-[WebFrameBridge initMainFrameWithPage:WebCore::frameName:view:webView:]):
758         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
759         * WebCoreSupport/WebFrameLoaderClient.h: Replaced constructor with factory
760         function to avoid leaks.
761         (WebFrameLoaderClient::ref):
762         (WebFrameLoaderClient::deref):
763         (WebFrameLoaderClient::refCount):
764         * WebCoreSupport/WebFrameLoaderClient.mm:
765         (WebFrameLoaderClient::create):
766         * WebView/WebFrame.mm:
767         (-[WebFrame _initWithWebFrameView:webView:coreFrame:]):
768
769 === Safari-521.30 ===
770
771 2006-11-10  Maciej Stachowiak  <mjs@apple.com>
772
773         Reviewed by Anders.
774         
775         - remove some unnecessary uses of WebDataProtocol
776
777         * WebView/WebDataSource.mm: Remove the unneeded include.
778         * WebView/WebView.mm:
779         (+[WebView _canHandleRequest:]): Don't bother to check for unreachable URL here.
780         Any request that has one will be an applewebdata: request, which will pass the check anyway.
781
782 2006-11-10  Anders Carlsson  <acarlsson@apple.com>
783
784         Reviewed by Geoff.
785
786         Update for changes to WebCore
787         * WebView/WebHTMLView.m:
788         (-[NSArray _applyStyleToSelection:withUndoAction:]):
789         (-[NSArray _applyParagraphStyleToSelection:withUndoAction:]):
790         (-[NSArray _toggleBold]):
791         (-[NSArray _toggleItalic]):
792
793 2006-11-09  Anders Carlsson  <acarlsson@apple.com>
794
795         Reviewed by Maciej, Geoff.
796
797         Call execCommand directly here instead of going through the bridge.
798         
799         * WebView/WebHTMLView.m:
800         (-[NSArray moveBackward:]):
801         (-[NSArray moveBackwardAndModifySelection:]):
802         (-[NSArray moveDown:]):
803         (-[NSArray moveDownAndModifySelection:]):
804         (-[NSArray moveForward:]):
805         (-[NSArray moveForwardAndModifySelection:]):
806         (-[NSArray moveLeft:]):
807         (-[NSArray moveLeftAndModifySelection:]):
808         (-[NSArray moveRight:]):
809         (-[NSArray moveRightAndModifySelection:]):
810         (-[NSArray moveToBeginningOfDocument:]):
811         (-[NSArray moveToBeginningOfDocumentAndModifySelection:]):
812         (-[NSArray moveToBeginningOfSentence:]):
813         (-[NSArray moveToBeginningOfSentenceAndModifySelection:]):
814         (-[NSArray moveToBeginningOfLine:]):
815         (-[NSArray moveToBeginningOfLineAndModifySelection:]):
816         (-[NSArray moveToBeginningOfParagraph:]):
817         (-[NSArray moveToBeginningOfParagraphAndModifySelection:]):
818         (-[NSArray moveToEndOfDocument:]):
819         (-[NSArray moveToEndOfDocumentAndModifySelection:]):
820         (-[NSArray moveToEndOfSentence:]):
821         (-[NSArray moveToEndOfSentenceAndModifySelection:]):
822         (-[NSArray moveToEndOfLine:]):
823         (-[NSArray moveToEndOfLineAndModifySelection:]):
824         (-[NSArray moveToEndOfParagraph:]):
825         (-[NSArray moveToEndOfParagraphAndModifySelection:]):
826         (-[NSArray moveParagraphBackwardAndModifySelection:]):
827         (-[NSArray moveParagraphForwardAndModifySelection:]):
828         (-[NSArray moveUp:]):
829         (-[NSArray moveUpAndModifySelection:]):
830         (-[NSArray moveWordBackward:]):
831         (-[NSArray moveWordBackwardAndModifySelection:]):
832         (-[NSArray moveWordForward:]):
833         (-[NSArray moveWordForwardAndModifySelection:]):
834         (-[NSArray moveWordLeft:]):
835         (-[NSArray moveWordLeftAndModifySelection:]):
836         (-[NSArray moveWordRight:]):
837         (-[NSArray moveWordRightAndModifySelection:]):
838
839 2006-11-10  Brady Eidson  <beidson@apple.com>
840
841         Reviewed by Darin
842   
843         Took out WebIconDatabaseBridge and made WebKit call IconDatabase directly
844
845         * Misc/WebIconDatabase.m:
846         (-[WebIconDatabase init]):
847         (-[WebIconDatabase iconForURL:withSize:cache:]):
848         (-[WebIconDatabase iconURLForURL:]):
849         (-[WebIconDatabase defaultIconWithSize:]):
850         (-[WebIconDatabase defaultIconForURL:withSize:]):
851         (-[WebIconDatabase retainIconForURL:]):
852         (-[WebIconDatabase releaseIconForURL:]):
853         (-[WebIconDatabase setDelegate:]):
854         (-[WebIconDatabase removeAllIcons]):
855         (-[WebIconDatabase isIconExpiredForIconURL:]):
856         (-[WebIconDatabase _isEnabled]):
857         (-[WebIconDatabase _setIconData:forIconURL:]):
858         (-[WebIconDatabase _setHaveNoIconForIconURL:]):
859         (-[WebIconDatabase _setIconURL:forURL:]):
860         (-[WebIconDatabase _hasEntryForIconURL:]):
861         (-[WebIconDatabase _applicationWillTerminate:]):
862         (-[WebIconDatabase _resetCachedWebPreferences:]):
863         (-[WebIconDatabase _convertToWebCoreFormat]):
864         (webGetNSImage):
865         * Misc/WebIconDatabaseInternal.h: Added.
866         * Misc/WebIconDatabasePrivate.h:
867         * WebCoreSupport/WebFrameLoaderClient.h:
868         * WebCoreSupport/WebFrameLoaderClient.mm:
869         (WebFrameLoaderClient::dispatchDidReceiveIcon):
870         * WebCoreSupport/WebIconDatabaseBridge.h: Removed.
871         * WebCoreSupport/WebIconDatabaseBridge.m: Removed.
872         * WebKit.xcodeproj/project.pbxproj:
873
874 2006-11-09  Oliver Hunt  <oliver@apple.com>
875
876         Reviewed by Brady.
877         
878         Updated to make use of MimeTypeRegistry/bridge
879
880         * Misc/WebNSPasteboardExtras.m:
881         (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:]):
882         * WebCoreSupport/WebFrameBridge.mm:
883         (-[WebFrameBridge determineObjectFromMIMEType:URL:]):
884         * WebView/WebDataSource.mm:
885         (-[WebDataSource _documentFragmentWithArchive:]):
886         * WebView/WebHTMLRepresentation.m:
887         (+[WebHTMLRepresentation supportedNonImageMIMETypes]):
888         (+[WebHTMLRepresentation supportedImageMIMETypes]):
889         * WebView/WebHTMLView.m:
890         (-[WebHTMLView _imageExistsAtPaths:]):
891         (-[WebHTMLView _documentFragmentWithPaths:]):
892
893 2006-11-09  Brady Eidson  <beidson@apple.com>
894
895         Reviewed by Darin
896
897         <rdar://problem/4829080>
898         More loader re-factoring cleanup - WebFramePolicyListener was over-released
899
900         * WebCoreSupport/WebFrameLoaderClient.h: Changed vanilla ptr to a RetainPtr<> 
901         * WebCoreSupport/WebFrameLoaderClient.mm:
902         (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType): Ditto
903         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Ditto
904         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto
905         (WebFrameLoaderClient::dispatchWillSubmitForm): Ditto
906         (WebFrameLoaderClient::setUpPolicyListener): Ditto
907         (-[WebFramePolicyListener receivedPolicyDecision:]): Ditto 
908
909 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
910
911         Reviewed by Adam, Oliver.
912
913         Update for changes to WebCore. Pass a specific WebFrame to WebEditorClient
914         instead of just passing the WebView.
915         
916         * WebCoreSupport/WebEditorClient.h:
917         * WebCoreSupport/WebEditorClient.mm:
918         (WebEditorClient::WebEditorClient):
919         (WebEditorClient::setWebFrame):
920         (WebEditorClient::isContinuousSpellCheckingEnabled):
921         (WebEditorClient::spellCheckerDocumentTag):
922         (WebEditorClient::shouldDeleteRange):
923         (WebEditorClient::shouldShowDeleteInterface):
924         (WebEditorClient::shouldApplyStyle):
925         (WebEditorClient::shouldBeginEditing):
926         (WebEditorClient::shouldEndEditing):
927         (WebEditorClient::didBeginEditing):
928         (WebEditorClient::respondToChangedContents):
929         (WebEditorClient::didEndEditing):
930         * WebCoreSupport/WebFrameBridge.mm:
931         (-[WebFrameBridge initMainFrameWithPage:WebCore::frameName:view:webView:]):
932         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
933
934 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
935
936         Reviewed by Adam.
937
938         Move more code into editor.
939
940         * WebCoreSupport/WebEditorClient.h:
941         * WebCoreSupport/WebEditorClient.mm:
942         (WebEditorClient::shouldBeginEditing):
943         (WebEditorClient::shouldEndEditing):
944         (WebEditorClient::didBeginEditing):
945         (WebEditorClient::didEndEditing):
946         * WebCoreSupport/WebFrameBridge.mm:
947         * WebView/WebHTMLView.m:
948         (-[NSArray indent:]):
949         (-[NSArray outdent:]):
950         * WebView/WebView.mm:
951         * WebView/WebViewInternal.h:
952
953 2006-11-08  Beth Dakin  <bdakin@apple.com>
954
955         Reviewed by Adam.
956
957         Add WebElementIsContentEditableKey to the WebElementDictionary, and 
958         use it!
959
960         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
961         (-[WebDefaultUIDelegate 
962         webView:contextMenuItemsForElement:defaultMenuItems:]): Use new 
963         WebElementIsContentEditableKey.
964         * Misc/WebElementDictionary.m:
965         (+[WebElementDictionary initializeLookupTable]):
966         (-[WebElementDictionary _isContentEditable]): Call into 
967         HitTestResult::isContentEditable()
968         * WebView/WebView.mm: Add new key.
969         * WebView/WebViewPrivate.h: Add new key.
970
971 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
972
973         Reviewed by Oliver.
974
975         Call into the WebCore editor object directly.
976         
977         * MigrateHeaders.make:
978         * WebCoreSupport/WebEditorClient.h:
979         * WebCoreSupport/WebEditorClient.mm:
980         (WebEditorClient::shouldDeleteRange):
981         (WebEditorClient::shouldShowDeleteInterface):
982         (WebEditorClient::shouldApplyStyle):
983         * WebView/WebFrame.mm:
984         (core):
985         (kit):
986         * WebView/WebFrameInternal.h:
987         * WebView/WebHTMLView.m:
988         (-[NSArray _applyStyleToSelection:withUndoAction:]):
989         (-[NSArray _applyParagraphStyleToSelection:withUndoAction:]):
990         (-[NSArray _toggleBold]):
991         (-[NSArray _toggleItalic]):
992         (-[NSArray _changeCSSColorUsingSelector:inRange:]):
993         (-[NSArray underline:]):
994         (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
995         * WebView/WebView.mm:
996         (-[WebView applyStyle:]):
997
998 2006-11-08  Anders Carlsson  <acarlsson@apple.com>
999
1000         Reviewed by Oliver.
1001
1002         <rdar://problem/4825370>
1003         REGRESSION: Selecting "Look Up In Dictionary" from contextual menu fails to open the Dictionary app
1004         
1005         * WebView/WebHTMLView.m:
1006         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
1007         Initialize the framework pointer to 0.
1008         
1009 2006-11-07  Darin Adler  <darin@apple.com>
1010
1011         Reviewed by Geoff.
1012
1013         - udpated for changes to move from Frame/FrameMac to FrameLoader
1014
1015         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
1016         (-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
1017         * Misc/WebNSAttributedStringExtras.m:
1018         (+[NSAttributedString _web_attributedStringFromRange:]):
1019         * Plugins/WebBaseNetscapePluginView.mm:
1020         (-[WebBaseNetscapePluginView requestWithURLCString:]):
1021         * Plugins/WebNetscapePluginEmbeddedView.m:
1022         (-[WebNetscapePluginEmbeddedView didStart]):
1023         * Plugins/WebNetscapePluginStream.mm:
1024         * Plugins/WebPluginController.mm:
1025         (-[WebPluginController pluginView:receivedResponse:]):
1026         * WebCoreSupport/WebFrameBridge.mm:
1027         (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
1028         * WebCoreSupport/WebFrameLoaderClient.mm:
1029         (WebFrameLoaderClient::provisionalLoadStarted):
1030         * WebView/WebFrame.mm:
1031         (-[WebFrame _canCachePage]):
1032         (+[WebFrame _timeOfLastCompletedLoad]):
1033         (-[WebFrame _loadItem:withLoadType:]):
1034         (-[WebFrame _reloadForPluginChanges]):
1035         (-[WebFrame stopLoading]):
1036
1037 2006-11-07  Anders Carlsson  <acarlsson@apple.com>
1038
1039         Reviewed by Geoff.
1040
1041         Use the WebCore editing enums.
1042         
1043         * WebCoreSupport/WebFrameBridge.mm:
1044         (-[WebFrameBridge undoNameForEditAction:]):
1045         * WebView/WebHTMLView.m:
1046         (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:granularity:]):
1047         (-[WebHTMLView _deleteSelection]):
1048         (-[WebHTMLView moveBackward:]):
1049         (-[WebHTMLView moveBackwardAndModifySelection:]):
1050         (-[WebHTMLView moveDown:]):
1051         (-[WebHTMLView moveDownAndModifySelection:]):
1052         (-[WebHTMLView moveForward:]):
1053         (-[WebHTMLView moveForwardAndModifySelection:]):
1054         (-[WebHTMLView moveLeft:]):
1055         (-[WebHTMLView moveLeftAndModifySelection:]):
1056         (-[WebHTMLView moveRight:]):
1057         (-[WebHTMLView moveRightAndModifySelection:]):
1058         (-[WebHTMLView moveToBeginningOfDocument:]):
1059         (-[WebHTMLView moveToBeginningOfDocumentAndModifySelection:]):
1060         (-[WebHTMLView moveToBeginningOfSentence:]):
1061         (-[WebHTMLView moveToBeginningOfSentenceAndModifySelection:]):
1062         (-[WebHTMLView moveToBeginningOfLine:]):
1063         (-[WebHTMLView moveToBeginningOfLineAndModifySelection:]):
1064         (-[WebHTMLView moveToBeginningOfParagraph:]):
1065         (-[WebHTMLView moveToBeginningOfParagraphAndModifySelection:]):
1066         (-[WebHTMLView moveToEndOfDocument:]):
1067         (-[WebHTMLView moveToEndOfDocumentAndModifySelection:]):
1068         (-[WebHTMLView moveToEndOfSentence:]):
1069         (-[WebHTMLView moveToEndOfSentenceAndModifySelection:]):
1070         (-[WebHTMLView moveToEndOfLine:]):
1071         (-[WebHTMLView moveToEndOfLineAndModifySelection:]):
1072         (-[WebHTMLView moveToEndOfParagraph:]):
1073         (-[WebHTMLView moveToEndOfParagraphAndModifySelection:]):
1074         (-[WebHTMLView moveParagraphBackwardAndModifySelection:]):
1075         (-[WebHTMLView moveParagraphForwardAndModifySelection:]):
1076         (-[WebHTMLView moveUp:]):
1077         (-[WebHTMLView moveUpAndModifySelection:]):
1078         (-[WebHTMLView moveWordBackward:]):
1079         (-[WebHTMLView moveWordBackwardAndModifySelection:]):
1080         (-[WebHTMLView moveWordForward:]):
1081         (-[WebHTMLView moveWordForwardAndModifySelection:]):
1082         (-[WebHTMLView moveWordLeft:]):
1083         (-[WebHTMLView moveWordLeftAndModifySelection:]):
1084         (-[WebHTMLView moveWordRight:]):
1085         (-[WebHTMLView moveWordRightAndModifySelection:]):
1086         (-[WebHTMLView pageUp:]):
1087         (-[WebHTMLView pageDown:]):
1088         (-[WebHTMLView pageUpAndModifySelection:]):
1089         (-[WebHTMLView pageDownAndModifySelection:]):
1090         (-[WebHTMLView _expandSelectionToGranularity:]):
1091         (-[WebHTMLView selectParagraph:]):
1092         (-[WebHTMLView selectLine:]):
1093         (-[WebHTMLView selectSentence:]):
1094         (-[WebHTMLView selectWord:]):
1095         (-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
1096         (-[WebHTMLView _applyParagraphStyleToSelection:withUndoAction:]):
1097         (-[WebHTMLView _toggleBold]):
1098         (-[WebHTMLView _toggleItalic]):
1099         (-[WebHTMLView pasteFont:]):
1100         (-[WebHTMLView changeFont:]):
1101         (-[WebHTMLView changeAttributes:]):
1102         (-[WebHTMLView _undoActionFromColorPanelWithSelector:]):
1103         (-[WebHTMLView changeColor:]):
1104         (-[WebHTMLView _alignSelectionUsingCSSValue:withUndoAction:]):
1105         (-[WebHTMLView alignCenter:]):
1106         (-[WebHTMLView alignJustified:]):
1107         (-[WebHTMLView alignLeft:]):
1108         (-[WebHTMLView alignRight:]):
1109         (-[WebHTMLView _deleteWithDirection:SelectionController::granularity:killRing:isTypingAction:]):
1110         (-[WebHTMLView deleteForward:]):
1111         (-[WebHTMLView deleteBackward:]):
1112         (-[WebHTMLView deleteWordForward:]):
1113         (-[WebHTMLView deleteWordBackward:]):
1114         (-[WebHTMLView deleteToBeginningOfLine:]):
1115         (-[WebHTMLView deleteToEndOfLine:]):
1116         (-[WebHTMLView deleteToBeginningOfParagraph:]):
1117         (-[WebHTMLView deleteToEndOfParagraph:]):
1118         (-[WebHTMLView subscript:]):
1119         (-[WebHTMLView superscript:]):
1120         (-[WebHTMLView unscript:]):
1121         (-[WebHTMLView underline:]):
1122         (-[WebHTMLView deleteToMark:]):
1123         (-[WebHTMLView toggleBaseWritingDirection:]):
1124         (-[WebHTMLView changeBaseWritingDirection:]):
1125         (-[WebHTMLView _canSmartCopyOrDelete]):
1126         (-[WebTextCompleteController doCompletion]):
1127         (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
1128         * WebView/WebView.mm:
1129         (-[WebView setTypingStyle:]):
1130         (-[WebView applyStyle:]):
1131
1132 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
1133
1134         Reviewed by Tim Hatcher.
1135
1136         Removed ScreenClient. It was highly unpopular, risking my midterm re-election.
1137         
1138         None of Screen's responsibilities require up-calls to WebKit or delegates, 
1139         so WebCore can handle it all.
1140
1141         * WebCoreSupport/WebChromeClient.mm:
1142         (WebChromeClient::setWindowRect):
1143         (WebChromeClient::windowRect):
1144         * WebCoreSupport/WebScreenClient.h: Removed.
1145         * WebCoreSupport/WebScreenClient.mm: Removed.
1146         * WebKit.xcodeproj/project.pbxproj:
1147         * WebView/WebView.mm:
1148         (-[WebView _commonInitializationWithFrameName:groupName:]):
1149
1150 2006-11-06  Geoffrey Garen  <ggaren@apple.com>
1151
1152         Reviewed by Darin.
1153         
1154         Accidentally rolled out this change when removing the WebPageBridge. Now
1155         putting it back.
1156
1157         * WebView/WebView.mm:
1158         (-[WebView _commonInitializationWithFrameName:groupName:]):
1159
1160 2006-11-05  Geoffrey Garen  <ggaren@apple.com>
1161
1162         Reviewed by Maciej, Darin, Anders.
1163
1164         Removed the Page bridge. Beefed up Chrome. Added Screen and ScreenClient.
1165         
1166         (WebChromeClient::pageRect): It may seem weird for the page to ask the Chrome/ChromeClient
1167         about its own dimensions. The idea here is that we're asking the Chrome how
1168         much space it has devoted to the page. We have API for this (-webViewContentRect), but 
1169         it was documented incorrectly (even Safari used it wrong), so we don't use 
1170         it anymore. Once we fix our API/documentation, we can return to making a
1171         delegate callback to ask for the page's size.
1172         (WebChromeClient::createWindow): Changed to take a FrameLoadRequest with
1173         an appropriate referrer, instead of making up its own.
1174         (WebChromeClient::createModalDialog): Changed to take a FrameLoadRequest with
1175         an appropriate referrer, instead of broken out parcels.
1176         * WebCoreSupport/WebPageBridge.h: Removed. Dead Code.
1177         * WebCoreSupport/WebPageBridge.mm: Removed. Dead Code.
1178         * WebCoreSupport/WebScreenClient.h: Added.
1179         * WebCoreSupport/WebScreenClient.mm: Added.
1180         * WebView/WebView.mm: Added NULL checks for new _private->page, since
1181         it's not NULL-safe like the bridge was, and it gets cleared before
1182         dealloc.
1183
1184 2006-11-06  Graham Dennis  <graham.dennis@gmail.com>
1185
1186         Reviewed by Tim Hatcher.
1187
1188         Part of patch for http://bugs.webkit.org/show_bug.cgi?id=11323
1189         Link dragging behaviour does not obey WebKitEditableLinkBehavior WebPref
1190
1191         * DefaultDelegates/WebDefaultUIDelegate.m:
1192         (-[NSApplication webView:dragSourceActionMaskForPoint:]): Logic moved to 
1193         WebHTMLView's _mayStartDragAtEventLocation
1194         * Misc/WebElementDictionary.m: added isLiveLink
1195         (+[WebElementDictionary initializeLookupTable]):
1196         (-[WebElementDictionary _isLiveLink]):
1197         * WebView/WebHTMLView.m: 
1198         (-[WebHTMLView _mayStartDragAtEventLocation:]): Editable links should
1199         only be followed if isLiveLink is true
1200         (-[WebHTMLView _isMoveDrag:]): A drag of a live editable link is not
1201         a move
1202         (-[WebHTMLView draggingUpdatedWithDraggingInfo:actionMask:]):
1203         (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
1204         * WebView/WebView.mm: added WebElementLinkIsLiveKey
1205         * WebView/WebViewPrivate.h: ditto
1206
1207 2006-11-04  Maciej Stachowiak  <mjs@apple.com>
1208
1209         Reviewed by Oliver.
1210         
1211         - removed unneeded (and obsolete) header includes
1212
1213         * WebCoreSupport/WebFrameBridge.mm:
1214         * WebView/WebFrame.mm:
1215
1216 2006-11-05  Darin Adler  <darin@apple.com>
1217
1218         - WebKit part of Frame.h check-in (forgot to land it)
1219
1220         * WebCoreSupport/WebFrameBridge.h:
1221         * WebCoreSupport/WebFrameBridge.mm:
1222         (-[WebFrameBridge textViewWasFirstResponderAtMouseDownTime:]):
1223         (-[WebFrameBridge shouldInterruptJavaScript]):
1224         (-[WebFrameBridge saveDocumentState:]):
1225         (-[WebFrameBridge previousKeyViewOutsideWebFrameViews]):
1226         (-[WebFrameBridge valueForKey:keys:values:]):
1227         (-[WebFrameBridge getObjectCacheSize]):
1228         (-[WebFrameBridge startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
1229         (-[WebFrameBridge mayStartDragAtEventLocation:]):
1230         (-[WebFrameBridge canGoBackOrForward:]):
1231         (-[WebFrameBridge goBackOrForward:]):
1232         (-[WebFrameBridge print]):
1233         (-[WebFrameBridge getAppletInView:]):
1234         (-[WebFrameBridge pollForAppletInView:]):
1235         (-[WebFrameBridge respondToChangedContents]):
1236         (-[WebFrameBridge respondToChangedSelection]):
1237         (-[WebFrameBridge setIsSelected:forView:]):
1238
1239 2006-11-04  Darin Adler  <darin@apple.com>
1240
1241         Reviewed by Maciej.
1242
1243         - converted more of the loader machinery to work with cross-platform
1244           data structures instead of Macintosh-specific ones
1245
1246           store the computed user agent string as a WebCore::String instead
1247           of an NSString to avoid overhead converting it every time we get it
1248
1249         * COM/WebFrame.cpp:
1250         (WebFrame::initWithName):
1251         * ChangeLog:
1252         * Misc/WebElementDictionary.m:
1253         (-[WebElementDictionary _image]):
1254         (-[WebElementDictionary _targetWebFrame]):
1255         * WebCoreSupport/WebFrameLoaderClient.h:
1256         * WebCoreSupport/WebFrameLoaderClient.mm:
1257         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1258         (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent):
1259         (WebFrameLoaderClient::setTitle):
1260         (WebFrameLoaderClient::userAgent):
1261         (WebFrameLoaderClient::actionDictionary):
1262         * WebCoreSupport/WebPageBridge.mm:
1263         (WebCore::if):
1264         * WebView/WebDataSource.mm:
1265         (-[WebDataSource _URL]):
1266         (-[WebDataSource _URLForHistory]):
1267         (-[WebDataSource unreachableURL]):
1268         * WebView/WebHTMLView.m:
1269         (-[WebHTMLView elementAtPoint:allowShadowContent:]):
1270         * WebView/WebPDFView.mm:
1271         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1272         (-[WebPDFView _path]):
1273         * WebView/WebView.mm:
1274         (-[WebViewPrivate init]):
1275         (-[WebViewPrivate dealloc]):
1276         (-[WebViewPrivate finalize]):
1277         (-[WebView _preferencesChangedNotification:]):
1278         (-[WebView _cachedResponseForURL:]):
1279         (-[WebView setApplicationNameForUserAgent:]):
1280         (-[WebView setCustomUserAgent:]):
1281         (-[WebView customUserAgent]):
1282         (-[WebView userAgentForURL:]):
1283         (-[WebView _computeUserAgent]):
1284         (-[WebView WebCore::]):
1285         * WebView/WebViewInternal.h:
1286
1287 2006-11-04  Bertrand Guiheneuf <guiheneuf@gmail.com>
1288
1289         Reviewed by Maciej, tweaked and landed by Alexey (using a patch by Don Gibson).
1290
1291         http://bugs.webkit.org/show_bug.cgi?id=11433
1292         Fixes to get WebKit to run on Windows; implemented AffineTransformCairo.
1293
1294         * COM/WebFrame.cpp:
1295         (WebFrame::initWithName):
1296         (WebFrame::loadDataSource):
1297         (WebFrame::receivedRedirect):
1298         (WebFrame::receivedResponse):
1299         (WebFrame::didReceiveData):
1300         (WebFrame::receivedAllData):
1301         Use resource handles now. Do not start doc loader by hand anymore. 
1302         Handle didReceiveData() callback instead of receivedData() which 
1303         is deprecated in implementation of ResourceHandleClient        
1304
1305         * COM/WebFrame.h:
1306         * COM/WebView.cpp:
1307         Applied ResourceLoader --> ResourceHandle renaming
1308
1309         * WebKit.vcproj/WebKit.rc:
1310         Got rid of MFC dependencies (build fix for VCExpress).
1311
1312         * WebKit.vcproj/WebKit.vcproj:
1313         Added platform/graphics platform/network and platform/network/win 
1314         to headers search paths
1315
1316 2006-11-03  Geoffrey Garen  <ggaren@apple.com>
1317
1318         Forgot to add these two files. Oops.
1319
1320         * WebCoreSupport/WebChromeClient.h: Added.
1321         * WebCoreSupport/WebChromeClient.mm: Added.
1322
1323 2006-11-02  Geoffrey Garen  <ggaren@apple.com>
1324
1325         Reviewed by Darin, Beth.
1326
1327         First cut at factoring Page's UIDelegate-related functions into Chrome
1328         and ChromeClient.
1329
1330         Layout tests pass.
1331         
1332         * WebCoreSupport/WebEditorClient.h:
1333         * WebCoreSupport/WebPageBridge.mm:
1334         * WebKit.xcodeproj/project.pbxproj:
1335
1336 2006-11-02  Timothy Hatcher  <timothy@apple.com>
1337
1338         Reviewed by Brady.
1339
1340         Adding outdent to the WebView responder forwarding list.
1341         Also add outdent to WebHTMLView.h and WebViewPrivate.h.
1342
1343         * WebView/WebHTMLView.h:
1344         * WebView/WebViewPrivate.h:
1345         * WebView/WebView.mm:
1346
1347 2006-11-01  John Sullivan  <sullivan@apple.com>
1348
1349         Reviewed by Adam Roben
1350         
1351         - fixed <rdar://problem/4801351> Crash reloading PDF file in new Safari (or closing a window containing a PDF file)
1352
1353         * WebView/WebPDFView.mm:
1354         (-[WebPDFView initWithFrame:]):
1355         Retain the PDFSubview in the code path where we just obtain it by asking the PDFPreviewView for it. We were
1356         unconditionally releasing it in dealloc, but only retaining it in one of the two code paths.
1357
1358 2006-10-31  Mark Rowe  <bdash@webkit.org>
1359
1360         Reviewed by Maciej.
1361
1362         Fix null pointer dereference while running editing/pasteboard/drag-drop-modifies-page.html
1363
1364         * Misc/WebElementDictionary.m:
1365         (-[WebElementDictionary _image]): Add null check.
1366
1367 2006-10-31  Beth Dakin  <bdakin@apple.com>
1368
1369         Reviewed by Maciej.
1370
1371         This creates local functions for the remaining WebElementDictionary 
1372         members that calls into HitTestResult instead of doing magical 
1373         things with the Objective-C DOM classes.
1374
1375         * ChangeLog:
1376         * Misc/WebElementDictionary.m:
1377         (addLookupKey): The values of the dictionary are now just 
1378         selectors. They used to be WebElementMethods which were 
1379         WebElementTargetObjects associated with selectors, but none of that 
1380         is needed any more.
1381         (+[WebElementDictionary initializeLookupTable]): All selectors are 
1382         now local functions, no more WebElementTargetObjects.
1383         (-[WebElementDictionary objectForKey:]): No more target objects!
1384         (-[WebElementDictionary _domNode]): Call into HitTestResult member 
1385         variable.
1386         (-[WebElementDictionary _altDisplayString]): Same.
1387         (-[WebElementDictionary _image]): Same.
1388         (-[WebElementDictionary _absoluteImageURL]): Same.
1389         (-[WebElementDictionary _title]): Same.
1390         (-[WebElementDictionary _absoluteLinkURL]): Same.
1391         (-[WebElementDictionary _targetWebFrame]): Same.
1392         (-[WebElementDictionary _titleDisplayString]): Same.
1393         (-[WebElementDictionary _textContent]): Same.
1394
1395 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
1396
1397         Reviewed by Alice.
1398         
1399         Moved some Editing code from WebKit, the bridge, and WebCore::Frame down 
1400         to WebCore::Editor.
1401
1402         * WebCoreSupport/WebFrameBridge.mm:
1403         * WebView/WebHTMLView.m:
1404         (-[WebHTMLView _shouldDeleteRange:]):
1405         (-[WebHTMLView _canCopy]):
1406         (-[WebHTMLView _canCut]):
1407         (-[WebHTMLView _canDelete]):
1408         (-[WebHTMLView _canPaste]):
1409         (-[WebHTMLView _canEdit]):
1410         (-[WebHTMLView _canEditRichly]):
1411         (-[WebHTMLView _isEditable]):
1412         (-[WebHTMLView _isSelectionInPasswordField]):
1413         (-[NSArray validateUserInterfaceItem:]):
1414         (-[NSArray _expandSelectionToGranularity:]):
1415
1416 2006-10-31  John Sullivan  <sullivan@apple.com>
1417
1418         Reviewed by Beth and Adam
1419         
1420         Display a tooltip when hovering over marked bad grammar.
1421
1422         * Misc/WebElementDictionary.m:
1423         (+[WebElementDictionary initializeLookupTable]):
1424         support spelling tool tip
1425         (-[WebElementDictionary _spellingToolTip]):
1426         new method, calls through to HitTestResult
1427         
1428         * WebView/WebHTMLView.m:
1429         (-[WebHTMLView _updateMouseoverWithEvent:]):
1430         Check for a spelling tool tip; if found, prefer it over the other possible tool tips.
1431         Check for empty strings instead of just nil strings being, since values from 
1432         WebElementDictionary are empty strings.
1433         
1434         * WebView/WebViewPrivate.h:
1435         declare new string constant WebElementSpellingToolTipKey
1436         * WebView/WebView.mm:
1437         define new string constant WebElementSpellingToolTipKey
1438         
1439 2006-10-31  Beth Dakin  <bdakin@apple.com>
1440
1441         Reviewed by Maciej.
1442
1443         Small tweaks to WebKit because of http://bugs.webkit.org/
1444         show_bug.cgi?id=11461 HitTestResult should be split into 
1445         HitTestRequest and HitTestResult
1446
1447         * WebKit.xcodeproj/project.pbxproj:
1448         * WebView/WebHTMLView.m:
1449         (-[WebHTMLView elementAtPoint:allowShadowContent:]): The 
1450         HitTestResult initializer now just takes a point.
1451
1452 2006-10-31  Darin Adler  <darin@apple.com>
1453
1454         Reviewed by Brady.
1455
1456         - got "action dictionary" code out of FrameLoader,
1457           replacing with a class called NavigationAction
1458
1459         * WebCoreSupport/WebFrameLoaderClient.h: Changed parameter types to NavigationAction.
1460         Made elementForEvent non-virtual. Added actionDictionary function.
1461         * WebCoreSupport/WebFrameLoaderClient.mm:
1462         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Changed parameter type,
1463         and used actionDictionary to make the action dictionary.
1464         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.
1465         (WebFrameLoaderClient::actionDictionary): Added. Code that was originally in WebCore
1466         that creates the action dictionary (from a NavigationAction).
1467
1468         * WebView/WebFrame.mm: (-[WebFrame _loadItem:withLoadType:]): Use NavigationAction
1469         instead of a dictionary for the action parameters.
1470
1471 2006-10-31  Marvin Decker  <marv.decker@gmail.com>
1472
1473         Reviewed by Maciej.
1474         
1475         - fixed "Stop and reload don't work on the WebView"
1476         http://bugs.webkit.org/show_bug.cgi?id=11285
1477
1478         * COM/WebFrame.cpp:
1479         (WebFrame::stopLoading): Implement.
1480         * COM/WebView.cpp:
1481         (WebView::stopLoading): ditto
1482         (WebView::reload): ditto
1483
1484 2006-10-30  Darin Adler  <darin@apple.com>
1485
1486         * Plugins/WebBaseNetscapePluginView.mm:
1487         (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
1488         Fix comment.
1489
1490 2006-10-30  John Sullivan  <sullivan@apple.com>
1491
1492         Reviewed by Geoff Garen
1493
1494         * WebView/WebHTMLView.m:
1495         (-[NSArray checkSpelling:]):
1496         removed code to update spelling panel; WebCore handles that now
1497         (-[NSArray showGuessPanel:]):
1498         ditto
1499
1500 2006-10-30  John Sullivan  <sullivan@apple.com>
1501
1502         * English.lproj/WebViewEditingContextMenu.nib/info.nib:
1503         * English.lproj/WebViewEditingContextMenu.nib/objects.nib:
1504         Another wording change to match framework, post-Tiger:
1505         "Check Spelling" -> "Check Document Now"
1506
1507 2006-10-30  John Sullivan  <sullivan@apple.com>
1508
1509         Reviewed by Geoff Garen.
1510         
1511         Moved spelling-related methods from bridge to EditorClient. Added one not-yet-used
1512         grammar-related method.
1513
1514         * WebCoreSupport/WebEditorClient.h:
1515         declare overrides of isContinuousSpellCheckingEnabled(), spellCheckerDocumentTag(), and new
1516         isGrammarCheckingEnabled()
1517         * WebCoreSupport/WebEditorClient.mm:
1518         (WebEditorClient::isContinuousSpellCheckingEnabled):
1519         implement by calling through to WebView
1520         (WebEditorClient::isGrammarCheckingEnabled):
1521         ditto
1522         (WebEditorClient::spellCheckerDocumentTag):
1523         ditto
1524         
1525         * WebCoreSupport/WebFrameBridge.mm:
1526         removed bridge equivalents of these methods
1527
1528 2006-10-30  Geoffrey Garen  <ggaren@apple.com>
1529
1530         Reviewed by Beth.
1531         
1532         Fixed nil-deref crash that I saw while using TOT (not sure how to repro,
1533         but the debugger confirmed the cause).
1534
1535         * WebView/WebFrame.mm:
1536         (core): Added check for NULL bridge.
1537
1538 2006-10-30  Geoffrey Garen  <ggaren@apple.com>
1539
1540         Reviewed by Darin.
1541
1542         Removed a number of editing and selection methods from the bridge.
1543         
1544         I moved cross-platform editing and selection code into WebCore::Editor and 
1545         WebCore::SelectionController, respecitvely.
1546         
1547         All of the seemingly new code here is just code grabbed from WebCore or
1548         merged from WebCoreFrameBridge.
1549         
1550         I changed one piece of internal API: we now pass around Ranges in places
1551         where we used to pass around broken out components of Ranges.
1552         
1553         I also added WebCore XPATH_SUPPORT AND SVG_SUPPORT #defines to the project.
1554         Since we now include WebCore headers that depend on these #defines, we need
1555         to keep in sync with them, to avoid binary incompatibility.
1556
1557 2006-10-30  Darin Adler  <darin@apple.com>
1558
1559         Reviewed by John Sullivan.
1560
1561         - work toward removing Objective-C data types from FrameLoader.h:
1562           removed NSDate, NSString, WebCorePageState, WebCoreResourceLoader,
1563           and WebCoreResourceHandle
1564         - moved bodyBackgroundColor function here from Frame
1565
1566         * History/WebHistoryItem.m: (+[WebHistoryItem _closeObjectsInPendingPageCaches]):
1567         Updated for change in WebCorePageState.
1568
1569         * WebCoreSupport/WebFrameBridge.mm: Removed saveDocumentToPageCache method.
1570
1571         * WebCoreSupport/WebFrameLoaderClient.h: Changed NSDate to double.
1572         * WebCoreSupport/WebFrameLoaderClient.mm:
1573         (WebFrameLoaderClient::invalidateCurrentItemPageCache): Moved the code that was
1574         formerly in invalidatePageCache: on the bridge here.
1575         (WebFrameLoaderClient::dispatchWillPerformClientRedirect): Added code to make the
1576         NSDate here.
1577         (WebFrameLoaderClient::createPageCache): Restructured code to create the
1578         WebCorePageState object directly instead of calling saveDocumentToPageCache on
1579         the bridge.
1580
1581         * WebView/WebFrame.mm: (-[WebFrame _bodyBackgroundColor]): Rewrote this to work
1582         directly with the DOM and renderers rather than using a function on Frame.
1583
1584 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
1585
1586         Reviewed by Anders.
1587
1588         - added ResourceResponse class and didReceiveResponse delegate call
1589
1590         * WebCoreSupport/WebFrameBridge.mm: Removed no longer needed
1591         expiresTimeForResponse: method.
1592
1593 2006-10-29  Darin Adler  <darin@apple.com>
1594
1595         - update for the WebCore rename
1596
1597         * WebCoreSupport/WebFrameLoaderClient.mm:
1598         * WebView/WebFrame.mm:
1599
1600 2006-10-29  Darin Adler  <darin@apple.com>
1601
1602         - update for the WebCore renames
1603
1604         * Plugins/WebNetscapePluginStream.mm:
1605         * Plugins/WebPluginController.mm:
1606         * WebCoreSupport/WebFrameBridge.mm:
1607         * WebCoreSupport/WebFrameLoaderClient.h:
1608         * WebCoreSupport/WebFrameLoaderClient.mm:
1609         (WebFrameLoaderClient::willUseArchive):
1610         (WebFrameLoaderClient::isArchiveLoadPending):
1611         (WebFrameLoaderClient::cancelPendingArchiveLoad):
1612         (WebFrameLoaderClient::deliverArchivedResources):
1613         * WebCoreSupport/WebPageBridge.mm:
1614         (-[WebPageBridge canRunModalNow]):
1615         * WebView/WebDocumentLoaderMac.h:
1616         * WebView/WebFrame.mm:
1617         * WebView/WebHTMLRepresentation.m:
1618         * WebView/WebView.mm:
1619
1620 2006-10-29  Darin Adler  <darin@apple.com>
1621
1622         Rubber stamped by Adam Roben.
1623
1624         - renamed WebCore's WebFrameLoaderClient to match the class name inside it
1625
1626         * WebCoreSupport/WebFrameBridge.mm: Update include.
1627         * WebCoreSupport/WebFrameLoaderClient.h: Ditto.
1628
1629 2006-10-29  Darin Adler  <darin@apple.com>
1630
1631         Reviewed by Maciej.
1632
1633         - eliminate use of NSArray to carry form data around
1634           (the code in this framework was actually using the NSArray to hold a single
1635            NSData anyway, so I just went back to an NSData for now)
1636
1637         - also fixed http://bugs.webkit.org/show_bug.cgi?id=11444
1638           REGRESSION (r17378): Exception (-[NSCFDictionary setObject:forKey:]:
1639           attempt to insert nil value) when submitting a form with an empty
1640           uninitialized field
1641
1642         * History/WebHistoryItem.m:
1643         (-[WebHistoryItem _setFormInfoFromRequest:]):
1644         (-[WebHistoryItem formData]):
1645         * History/WebHistoryItemPrivate.h:
1646         * WebCoreSupport/WebFrameLoaderClient.mm:
1647         (WebFrameLoaderClient::dispatchWillSubmitForm):
1648         * WebView/WebFrame.mm:
1649         (-[WebFrame _loadItem:withLoadType:]):
1650
1651 2006-10-28  Darin Adler  <darin@apple.com>
1652
1653         Reviewed by Maciej.
1654
1655         - eliminated the use of Objective-C for the policy decider
1656           machinery, obviating the need for WebPolicyDeciderMac
1657
1658         - moved the defersLoading flag from WebView to WebCore::Page
1659
1660         - removed unused copies of four methods that in the frame bridge;
1661           the actually-used copies are in the page bridge
1662
1663         - updated for rename of PassRefPtr::release to releaseRef
1664
1665         * WebView/WebPolicyDeciderMac.h: Removed.
1666         * WebView/WebPolicyDeciderMac.m: Removed.
1667         * WebKit.xcodeproj/project.pbxproj: Updated for removal.
1668
1669         * Plugins/WebBaseNetscapePluginView.mm:
1670         (-[WebBaseNetscapePluginView sendEvent:]):
1671         * Plugins/WebNetscapePluginStream.mm:
1672         * WebCoreSupport/WebFrameBridge.mm:
1673         * WebCoreSupport/WebFrameLoaderClient.h:
1674         * WebCoreSupport/WebFrameLoaderClient.mm:
1675         (getWebView):
1676         (WebFrameLoaderClient::WebFrameLoaderClient):
1677         (WebFrameLoaderClient::willCloseDocument):
1678         (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
1679         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1680         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1681         (WebFrameLoaderClient::cancelPolicyCheck):
1682         (WebFrameLoaderClient::dispatchWillSubmitForm):
1683         (WebFrameLoaderClient::setDefersLoading):
1684         (WebFrameLoaderClient::setTitle):
1685         (WebFrameLoaderClient::deliverArchivedResourcesAfterDelay):
1686         (WebFrameLoaderClient::deliverArchivedResources):
1687         (WebFrameLoaderClient::setUpPolicyListener):
1688         (WebFrameLoaderClient::receivedPolicyDecison):
1689         (WebFrameLoaderClient::userAgent):
1690         (-[WebFramePolicyListener initWithWebCoreFrame:]):
1691         (-[WebFramePolicyListener invalidate]):
1692         (-[WebFramePolicyListener dealloc]):
1693         (-[WebFramePolicyListener finalize]):
1694         (-[WebFramePolicyListener receivedPolicyDecision:]):
1695         (-[WebFramePolicyListener ignore]):
1696         (-[WebFramePolicyListener download]):
1697         (-[WebFramePolicyListener use]):
1698         (-[WebFramePolicyListener continue]):
1699         * WebCoreSupport/WebPageBridge.mm:
1700         (-[WebPageBridge runModal]):
1701         * WebView/WebArchiver.m:
1702         (+[WebArchiver archiveSelectionInFrame:]):
1703         * WebView/WebFormDelegate.h:
1704         * WebView/WebFormDelegate.m:
1705         (+[WebFormDelegate _sharedWebFormDelegate]):
1706         (-[WebFormDelegate textFieldDidBeginEditing:inFrame:]):
1707         (-[WebFormDelegate textFieldDidEndEditing:inFrame:]):
1708         (-[WebFormDelegate textDidChangeInTextField:inFrame:]):
1709         (-[WebFormDelegate textDidChangeInTextArea:inFrame:]):
1710         (-[WebFormDelegate frame:sourceFrame:willSubmitForm:withValues:submissionListener:]):
1711         * WebView/WebFrame.mm:
1712         (-[WebFrame _loadURL:referrer:intoChild:]):
1713         (-[WebFrame _isFrameSet]):
1714         * WebView/WebFrameInternal.h:
1715         * WebView/WebFrameView.mm:
1716         (-[WebFrameView _shouldDrawBorder]):
1717         * WebView/WebHTMLView.m:
1718         (-[NSArray knowsPageRange:]):
1719         * WebView/WebView.mm:
1720         (-[WebView _formDelegate]):
1721         * WebView/WebViewInternal.h:
1722         * WebView/WebViewPrivate.h:
1723
1724 2006-10-28  Adam Roben  <aroben@apple.com>
1725
1726         Reviewed by Maciej.
1727
1728         Fix layout tests that broke after r17399. Mitz discovered that the
1729         failures were caused by HitTestResult::m_point being uninitialized
1730         much of the time. HitTestResults are now always constructed with a
1731         point.
1732
1733         * WebView/WebHTMLView.m:
1734         (-[WebHTMLView elementAtPoint:allowShadowContent:]): Pass point to
1735         HitTestResult constructor.
1736
1737 2006-10-28  Beth Dakin  <bdakin@apple.com>
1738
1739         Reviewed by Darin.
1740
1741         This is the WebKit half of pushing the guts of elementAtPoint and 
1742         WebElementDictionary into WebCore. Among other things, this patch 
1743         makes WebElementDictionary.m and WebHTMLView.m Objective-C++
1744
1745         * MigrateHeaders.make: Add DOMElementInternal.h to the list of 
1746         headers to migrate.
1747         * Misc/WebElementDictionary.h: Replaced DOMNode, DOMElement, and 
1748         NSPoint member variables with a HitTestResult member variable.
1749         * Misc/WebElementDictionary.m:
1750         (addLookupKey): Formatting.
1751         (-[WebElementDictionary initWithHitTestResult:]): Constructor just 
1752         takes a HitTestResult now and sets the member variable.
1753         (-[WebElementDictionary dealloc]): delete HitTestResult.
1754         (-[WebElementDictionary finalize]): Address HitTestResult.
1755         (-[WebElementDictionary _domNode]): Use HitTestResult and call into 
1756         WebCore.
1757         (-[WebElementDictionary objectForKey:]): Same.
1758         (-[WebElementDictionary _webFrame]): Same.
1759         (-[WebElementDictionary _targetWebFrame]): Same.
1760         (-[WebElementDictionary _title]): Same.
1761         (-[WebElementDictionary _imageRect]): Same.
1762         (-[WebElementDictionary _isSelected]): Same.
1763         * WebKit.xcodeproj/project.pbxproj:
1764         * WebView/WebFrame.mm:
1765         (core): Convert from DOMNode* to Node*
1766         (kit): Convert from Node* to DOMNode*
1767         * WebView/WebFrameInternal.h: Support for the above.
1768         * WebView/WebHTMLView.m:
1769         (-[WebHTMLView elementAtPoint:allowShadowContent:]): Call directly 
1770         into Frame.cpp to get HitTestResult.
1771
1772 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
1773
1774         Reviewed by John & Adam.
1775         
1776         - various performance improvements for resource delegate dispatch.
1777         
1778         - avoid any ObjC messaging when fetching the WebView
1779         - avoid ObjC calls to WebView to get resource load delegate and impl cache
1780         - cache actual method pointers, not just the fact that the method is present
1781         - added a new SPI resource load delegate method which allows clients to get
1782           just one message in case of synchronously loading from memory cache; if this
1783           is implemented you don't get the normal delegate calls in that case.
1784         - various other minor tweaks
1785
1786         * WebCoreSupport/WebFrameBridge.h:
1787         * WebCoreSupport/WebFrameLoaderClient.h:
1788         * WebCoreSupport/WebFrameLoaderClient.mm:
1789         (getWebView):
1790         (WebFrameLoaderClient::hasBackForwardList):
1791         (WebFrameLoaderClient::resetBackForwardList):
1792         (WebFrameLoaderClient::privateBrowsingEnabled):
1793         (WebFrameLoaderClient::updateHistoryForStandardLoad):
1794         (WebFrameLoaderClient::resetAfterLoadError):
1795         (WebFrameLoaderClient::download):
1796         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
1797         (WebFrameLoaderClient::dispatchIdentifierForInitialRequest):
1798         (WebFrameLoaderClient::dispatchWillSendRequest):
1799         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
1800         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
1801         (WebFrameLoaderClient::dispatchDidReceiveResponse):
1802         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
1803         (WebFrameLoaderClient::dispatchDidFinishLoading):
1804         (WebFrameLoaderClient::dispatchDidFailLoading):
1805         (WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
1806         (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
1807         (WebFrameLoaderClient::dispatchDidCancelClientRedirect):
1808         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1809         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
1810         (WebFrameLoaderClient::dispatchWillClose):
1811         (WebFrameLoaderClient::dispatchDidReceiveIcon):
1812         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1813         (WebFrameLoaderClient::dispatchDidReceiveTitle):
1814         (WebFrameLoaderClient::dispatchDidCommitLoad):
1815         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
1816         (WebFrameLoaderClient::dispatchDidFailLoad):
1817         (WebFrameLoaderClient::dispatchDidFinishLoad):
1818         (WebFrameLoaderClient::dispatchDidFirstLayout):
1819         (WebFrameLoaderClient::dispatchCreatePage):
1820         (WebFrameLoaderClient::dispatchShow):
1821         (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
1822         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1823         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1824         (WebFrameLoaderClient::dispatchUnableToImplementPolicy):
1825         (WebFrameLoaderClient::dispatchWillSubmitForm):
1826         (WebFrameLoaderClient::dispatchDidLoadMainResource):
1827         (WebFrameLoaderClient::progressStarted):
1828         (WebFrameLoaderClient::progressCompleted):
1829         (WebFrameLoaderClient::incrementProgress):
1830         (WebFrameLoaderClient::completeProgress):
1831         (WebFrameLoaderClient::setMainFrameDocumentReady):
1832         (WebFrameLoaderClient::startDownload):
1833         (WebFrameLoaderClient::willChangeTitle):
1834         (WebFrameLoaderClient::didChangeTitle):
1835         (WebFrameLoaderClient::mainFrameURL):
1836         (WebFrameLoaderClient::frameLoadCompleted):
1837         * WebCoreSupport/WebPageBridge.h:
1838         * WebKit.xcodeproj/project.pbxproj:
1839         * WebView/WebFrame.mm:
1840         (frame):
1841         (core):
1842         (kit):
1843         (getWebView):
1844         (-[WebFrame _addBackForwardItemClippedAtTarget:]):
1845         (-[WebFrame _canCachePage]):
1846         (-[WebFrame _purgePageCache]):
1847         (-[WebFrame _loadItem:withLoadType:]):
1848         (-[WebFrame _goToItem:withLoadType:]):
1849         (-[WebFrame _updateBackground]):
1850         (-[WebFrame _clearSelectionInOtherFrames]):
1851         (-[WebFrame _isMainFrame]):
1852         (-[WebFrame webView]):
1853         * WebView/WebResourceLoadDelegatePrivate.h: Added.
1854         * WebView/WebView.mm:
1855         (-[WebView _cacheResourceLoadDelegateImplementations]):
1856         (WebViewGetResourceLoadDelegate):
1857         (WebViewGetResourceLoadDelegateImplementations):
1858         * WebView/WebViewInternal.h:
1859         * WebView/WebViewPrivate.h:
1860
1861 2006-10-27  Geoffrey Garen  <ggaren@apple.com>
1862
1863         Reviewed by Maciej.
1864         
1865         Moved some WebCoreFrameBridge functions into FrameLoader.
1866
1867         * WebView/WebFrame.mm:
1868         (-[WebFrame _numPendingOrLoadingRequests:]):
1869
1870 2006-10-27  Timothy Hatcher  <timothy@apple.com>
1871
1872         Reviewed by Beth.
1873
1874         Make a DerivedSource/Webkit directory to store migrated
1875         internal headers from WebCore.
1876
1877         * MigrateHeaders.make:
1878         * WebKit.xcodeproj/project.pbxproj:
1879         * WebView/WebFrame.mm: import the new migrated DOM*Internal.h headers
1880
1881 2006-10-27  John Sullivan  <sullivan@apple.com>
1882
1883         Reviewed by Anders
1884         
1885         - fixed http://bugs.webkit.org/show_bug.cgi?id=11439 
1886           REGRESSION: Another page loading crash
1887
1888         * WebView/WebFrame.mm:
1889         (-[WebFrame _createItem:]):
1890         Handle nil documentLoader the way we did before ObjC->C++ changes
1891
1892 2006-10-27  John Sullivan  <sullivan@apple.com>
1893
1894         Reviewed by Anders
1895
1896         * WebView/WebHTMLView.m:
1897         (-[NSArray checkSpelling:]):
1898         call advanceToNextMisspelling directly on FrameMac, bypassing bridge
1899         (-[NSArray showGuessPanel:]):
1900         ditto
1901
1902 2006-10-27  Darin Adler  <darin@apple.com>
1903
1904         - build fix
1905
1906         * WebCoreSupport/WebFrameLoaderClient.mm: Corrected header file name.
1907
1908 2006-10-27  Darin Adler  <darin@apple.com>
1909
1910         Reviewed by Maciej.
1911
1912         - moved methods that are there just to be called by the frame loader client into the client
1913           in an attempt to get back some of the speed we lost yesterday
1914
1915         * DefaultDelegates/WebDefaultResourceLoadDelegate.m:
1916         (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
1917         (-[WebDefaultResourceLoadDelegate webView:resource:didCancelAuthenticationChallenge:fromDataSource:]):
1918         * WebCoreSupport/WebFrameLoaderClient.h:
1919         * WebCoreSupport/WebFrameLoaderClient.mm:
1920         (dataSource):
1921         (decisionListener):
1922         (WebFrameLoaderClient::WebFrameLoaderClient):
1923         (WebFrameLoaderClient::hasWebView):
1924         (WebFrameLoaderClient::hasFrameView):
1925         (WebFrameLoaderClient::hasBackForwardList):
1926         (WebFrameLoaderClient::resetBackForwardList):
1927         (WebFrameLoaderClient::provisionalItemIsTarget):
1928         (WebFrameLoaderClient::loadProvisionalItemFromPageCache):
1929         (WebFrameLoaderClient::invalidateCurrentItemPageCache):
1930         (WebFrameLoaderClient::privateBrowsingEnabled):
1931         (WebFrameLoaderClient::makeDocumentView):
1932         (WebFrameLoaderClient::makeRepresentation):
1933         (WebFrameLoaderClient::setDocumentViewFromPageCache):
1934         (WebFrameLoaderClient::forceLayout):
1935         (WebFrameLoaderClient::forceLayoutForNonHTML):
1936         (WebFrameLoaderClient::updateHistoryForCommit):
1937         (WebFrameLoaderClient::updateHistoryForBackForwardNavigation):
1938         (WebFrameLoaderClient::updateHistoryForReload):
1939         (WebFrameLoaderClient::updateHistoryForStandardLoad):
1940         (WebFrameLoaderClient::updateHistoryForInternalLoad):
1941         (WebFrameLoaderClient::updateHistoryAfterClientRedirect):
1942         (WebFrameLoaderClient::setCopiesOnScroll):
1943         (WebFrameLoaderClient::tokenForLoadErrorReset):
1944         (WebFrameLoaderClient::resetAfterLoadError):
1945         (WebFrameLoaderClient::doNotResetAfterLoadError):
1946         (WebFrameLoaderClient::detachedFromParent1):
1947         (WebFrameLoaderClient::detachedFromParent2):
1948         (WebFrameLoaderClient::detachedFromParent3):
1949         (WebFrameLoaderClient::detachedFromParent4):
1950         (WebFrameLoaderClient::loadedFromPageCache):
1951         (WebFrameLoaderClient::download):
1952         (WebFrameLoaderClient::dispatchIdentifierForInitialRequest):
1953         (WebFrameLoaderClient::dispatchWillSendRequest):
1954         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
1955         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
1956         (WebFrameLoaderClient::dispatchDidReceiveResponse):
1957         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
1958         (WebFrameLoaderClient::dispatchDidFinishLoading):
1959         (WebFrameLoaderClient::dispatchDidFailLoading):
1960         (WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
1961         (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
1962         (WebFrameLoaderClient::dispatchDidCancelClientRedirect):
1963         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
1964         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
1965         (WebFrameLoaderClient::dispatchWillClose):
1966         (WebFrameLoaderClient::dispatchDidReceiveIcon):
1967         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
1968         (WebFrameLoaderClient::dispatchDidReceiveTitle):
1969         (WebFrameLoaderClient::dispatchDidCommitLoad):
1970         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
1971         (WebFrameLoaderClient::dispatchDidFailLoad):
1972         (WebFrameLoaderClient::dispatchDidFinishLoad):
1973         (WebFrameLoaderClient::dispatchDidFirstLayout):
1974         (WebFrameLoaderClient::dispatchCreatePage):
1975         (WebFrameLoaderClient::dispatchShow):
1976         (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
1977         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1978         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1979         (WebFrameLoaderClient::dispatchUnableToImplementPolicy):
1980         (WebFrameLoaderClient::dispatchWillSubmitForm):
1981         (WebFrameLoaderClient::dispatchDidLoadMainResource):
1982         (WebFrameLoaderClient::clearLoadingFromPageCache):
1983         (WebFrameLoaderClient::isLoadingFromPageCache):
1984         (WebFrameLoaderClient::revertToProvisionalState):
1985         (WebFrameLoaderClient::setMainDocumentError):
1986         (WebFrameLoaderClient::clearUnarchivingState):
1987         (WebFrameLoaderClient::progressStarted):
1988         (WebFrameLoaderClient::progressCompleted):
1989         (WebFrameLoaderClient::incrementProgress):
1990         (WebFrameLoaderClient::completeProgress):
1991         (WebFrameLoaderClient::setMainFrameDocumentReady):
1992         (WebFrameLoaderClient::startDownload):
1993         (WebFrameLoaderClient::willChangeTitle):
1994         (WebFrameLoaderClient::didChangeTitle):
1995         (WebFrameLoaderClient::committedLoad):
1996         (WebFrameLoaderClient::finishedLoading):
1997         (WebFrameLoaderClient::finalSetupForReplace):
1998         (WebFrameLoaderClient::cancelledError):
1999         (WebFrameLoaderClient::cannotShowURLError):
2000         (WebFrameLoaderClient::interruptForPolicyChangeError):
2001         (WebFrameLoaderClient::cannotShowMIMETypeError):
2002         (WebFrameLoaderClient::fileDoesNotExistError):
2003         (WebFrameLoaderClient::shouldFallBack):
2004         (WebFrameLoaderClient::mainFrameURL):
2005         (WebFrameLoaderClient::setDefersCallbacks):
2006         (WebFrameLoaderClient::willUseArchive):
2007         (WebFrameLoaderClient::isArchiveLoadPending):
2008         (WebFrameLoaderClient::cancelPendingArchiveLoad):
2009         (WebFrameLoaderClient::clearArchivedResources):
2010         (WebFrameLoaderClient::canHandleRequest):
2011         (WebFrameLoaderClient::canShowMIMEType):
2012         (WebFrameLoaderClient::representationExistsForURLScheme):
2013         (WebFrameLoaderClient::generatedMIMETypeForURLScheme):
2014         (WebFrameLoaderClient::elementForEvent):
2015         (WebFrameLoaderClient::createPolicyDecider):
2016         (WebFrameLoaderClient::frameLoadCompleted):
2017         (WebFrameLoaderClient::restoreScrollPositionAndViewState):
2018         (WebFrameLoaderClient::provisionalLoadStarted):
2019         (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent):
2020         (WebFrameLoaderClient::addHistoryItemForFragmentScroll):
2021         (WebFrameLoaderClient::didFinishLoad):
2022         (WebFrameLoaderClient::prepareForDataSourceReplacement):
2023         (WebFrameLoaderClient::createDocumentLoader):
2024         (WebFrameLoaderClient::setTitle):
2025         (WebFrameLoaderClient::canUseArchivedResource):
2026         (WebFrameLoaderClient::deliverArchivedResourcesAfterDelay):
2027         (WebFrameLoaderClient::deliverArchivedResources):
2028         (WebFrameLoaderClient::createPageCache):
2029         * WebView/WebFrame.mm:
2030         (-[NSView setWebFrame:]):
2031         (-[WebFrame _createItem:]):
2032         (-[WebFrame _loadItem:withLoadType:]):
2033         (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]):
2034         (-[WebFrame _loadURL:referrer:intoChild:]):
2035         (-[WebFrame _saveScrollPositionAndViewStateToItem:]):
2036         (-[WebFrame _hasSelection]):
2037         (-[WebFrame _clearSelection]):
2038         (-[WebFrame _setProvisionalItem:]):
2039         (-[WebFrame _setPreviousItem:]):
2040         (-[WebFrame _setCurrentItem:]):
2041         (-[WebFrame loadArchive:]):
2042         * WebView/WebFrameInternal.h:
2043         * WebView/WebHTMLView.m:
2044         (-[WebHTMLView _topHTMLView]):
2045         * WebView/WebHTMLViewPrivate.h:
2046
2047 2006-10-26  Geoffrey Garen  <ggaren@apple.com>
2048
2049         Reviewed by Darin, Maciej.
2050
2051         Removed many uses of NSString * from WebCore.
2052         
2053         Changed a few files to ObjC++ for compatiblity with new WebCore methods
2054         taking WebCore::Strings as arguments.
2055         
2056         Added a static_cast to make the c++ compiler happy.
2057
2058 2006-10-26  John Sullivan  <sullivan@apple.com>
2059
2060         Reviewed by Anders
2061
2062         * WebView/WebFrame.mm:
2063         now includes <WebCore/Document.h> and <WebCore/DocumentMarker.h>
2064         (-[WebFrame _unmarkAllBadGrammar]):
2065         filled in guts
2066         (-[WebFrame _unmarkAllMisspellings]):
2067         rewrote to call Document directly, bypassing bridge
2068
2069 2006-10-26  John Sullivan  <sullivan@apple.com>
2070
2071         * English.lproj/WebViewEditingContextMenu.nib/info.nib:
2072         * English.lproj/WebViewEditingContextMenu.nib/objects.nib:
2073         
2074         Changed "Spelling" to "Spelling and Grammar" in context menu for post-Tiger.
2075
2076 === Safari-521.29 ===
2077
2078 2006-10-26  John Sullivan  <sullivan@apple.com>
2079
2080         No review, just two localized string changes.
2081         
2082         * WebView/WebHTMLView.m:
2083         (-[NSArray validateUserInterfaceItem:]):
2084         changed "Show/Hide Spelling" to "Show/Hide Spelling and Grammar" post-Tiger to match framework change
2085
2086         * English.lproj/Localizable.strings:
2087         updated for these changes
2088
2089 2006-10-25  Darin Adler  <darin@apple.com>
2090
2091         Reviewed by Anders.
2092
2093         - removed 55 methods from WebCoreFrameBridge
2094         - changed callers to use Frame directly instead
2095         - put FrameLoaderTypes.h types into the WebCore namespace
2096         - first steps to get FrameLoader.h ready for cross-platform duty
2097
2098         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
2099         (-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
2100         * Plugins/WebBaseNetscapePluginView.mm:
2101         (-[WebBaseNetscapePluginView requestWithURLCString:]):
2102         (-[WebBaseNetscapePluginView loadPluginRequest:]):
2103         (-[WebBaseNetscapePluginView getVariable:value:]):
2104         * Plugins/WebNetscapePluginEmbeddedView.m:
2105         (-[WebNetscapePluginEmbeddedView didStart]):
2106         * Plugins/WebNetscapePluginStream.mm:
2107         * Plugins/WebPluginContainerCheck.m:
2108         (-[WebPluginContainerCheck _continueWithPolicy:]):
2109         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
2110         * WebCoreSupport/WebEditorClient.mm:
2111         (WebEditorClient::shouldDeleteRange):
2112         (WebEditorClient::shouldShowDeleteInterface):
2113         * WebCoreSupport/WebFrameBridge.mm:
2114         (-[WebFrameBridge webView]):
2115         (-[WebFrameBridge finishInitializingWithFrameName:view:]):
2116         (-[WebFrameBridge createWindowWithURL:]):
2117         (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
2118         (-[WebFrameBridge windowObjectCleared]):
2119         (-[WebFrameBridge createModalDialogWithURL:]):
2120         * WebCoreSupport/WebFrameLoaderClient.mm:
2121         (WebFrameLoaderClient::dispatchCreatePage):
2122         (WebFrameLoaderClient::dispatchWillSubmitForm):
2123         * WebKit.xcodeproj/project.pbxproj:
2124         * WebView/WebArchiver.m:
2125         (+[WebArchiver archiveSelectionInFrame:]):
2126         * WebView/WebDataSource.mm:
2127         (-[WebDataSource _documentFragmentWithImageResource:]):
2128         (-[WebDataSource _imageElementWithImageResource:]):
2129         * WebView/WebEditingDelegatePrivate.h:
2130         * WebView/WebFrame.mm:
2131         (core):
2132         (kit):
2133         (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]):
2134         (-[WebFrame _canCachePage]):
2135         (-[WebFrame _childFramesMatchItem:]):
2136         (-[WebFrame _URLsMatchItem:]):
2137         (-[WebFrame _loadItem:withLoadType:]):
2138         (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]):
2139         (-[WebFrame _viewWillMoveToHostWindow:]):
2140         (-[WebFrame _viewDidMoveToHostWindow]):
2141         (-[WebFrame _addChild:]):
2142         (-[WebFrame _saveDocumentAndScrollState]):
2143         (-[WebFrame _numPendingOrLoadingRequests:]):
2144         (-[WebFrame _reloadForPluginChanges]):
2145         (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
2146         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
2147         (-[WebFrame _initWithWebFrameView:webView:coreFrame:]):
2148         (-[WebFrame _documentViews]):
2149         (-[WebFrame _updateBackground]):
2150         (-[WebFrame _unmarkAllMisspellings]):
2151         (-[WebFrame _hasSelection]):
2152         (-[WebFrame _atMostOneFrameHasSelection]):
2153         (-[WebFrame _findFrameWithSelection]):
2154         (-[WebFrame _frameLoader]):
2155         (-[WebFrame _isDescendantOfFrame:]):
2156         (-[WebFrame _setShouldCreateRenderers:]):
2157         (-[WebFrame _bodyBackgroundColor]):
2158         (-[WebFrame init]):
2159         (-[WebFrame initWithName:webFrameView:webView:]):
2160         (-[WebFrame dealloc]):
2161         (-[WebFrame finalize]):
2162         (-[WebFrame name]):
2163         (-[WebFrame webView]):
2164         (-[WebFrame DOMDocument]):
2165         (-[WebFrame frameElement]):
2166         (-[WebFrame findFrameNamed:]):
2167         (-[WebFrame parentFrame]):
2168         (-[WebFrame childFrames]):
2169         (-[WebFrame _invalidateCurrentItemPageCache]):
2170         (-[WebFrame _dispatchCreateWebViewWithRequest:]):
2171         (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]):
2172         (-[WebFrame _prepareForDataSourceReplacement]):
2173         (-[WebFrame _provisionalLoadStarted]):
2174         * WebView/WebFrameInternal.h:
2175         * WebView/WebHTMLRepresentation.m:
2176         (-[WebHTMLRepresentation DOMDocument]):
2177         (-[WebHTMLRepresentation attributedText]):
2178         * WebView/WebHTMLView.m:
2179         (-[WebHTMLView _documentRange]):
2180         (-[WebHTMLView _documentFragmentWithPaths:]):
2181         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]):
2182         (-[WebHTMLView _selectedRange]):
2183         (-[WebHTMLView _updateMouseoverWithEvent:]):
2184         (-[WebHTMLView _canEditRichly]):
2185         (-[WebHTMLView _hasSelection]):
2186         (-[WebHTMLView _hasSelectionOrInsertionPoint]):
2187         (-[WebHTMLView _hasInsertionPoint]):
2188         (-[WebHTMLView _isEditable]):
2189         (-[WebHTMLView _isSelectionInPasswordField]):
2190         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
2191         (-[WebHTMLView _selectionDraggingImage]):
2192         (-[WebHTMLView _canIncreaseSelectionListLevel]):
2193         (-[WebHTMLView _canDecreaseSelectionListLevel]):
2194         (-[WebHTMLView _updateActiveState]):
2195         (-[NSArray readSelectionFromPasteboard:]):
2196         (-[NSArray validateUserInterfaceItem:]):
2197         (-[NSArray maintainsInactiveSelection]):
2198         (-[NSArray menuForEvent:]):
2199         (-[NSArray scrollWheel:]):
2200         (-[NSArray acceptsFirstMouse:]):
2201         (-[NSArray shouldDelayWindowOrderingForEvent:]):
2202         (-[NSArray mouseDown:]):
2203         (-[NSArray mouseDragged:]):
2204         (-[NSArray mouseUp:]):
2205         (-[NSArray keyDown:]):
2206         (-[NSArray keyUp:]):
2207         (-[NSArray centerSelectionInVisibleArea:]):
2208         (-[NSArray _selectionStartFontAttributesAsRTF]):
2209         (-[NSArray _emptyStyle]):
2210         (-[NSArray performKeyEquivalent:]):
2211         (-[NSArray indent:]):
2212         (-[NSArray outdent:]):
2213         (-[WebHTMLView cut:]):
2214         (-[WebHTMLView paste:]):
2215         (-[WebHTMLView _selectRangeInMarkedText:]):
2216         (-[WebTextCompleteController doCompletion]):
2217         (-[WebHTMLView selectionRect]):
2218         (-[WebHTMLView selectionImageForcingWhiteText:]):
2219         (-[WebHTMLView selectionImageRect]):
2220         (-[WebHTMLView attributedString]):
2221         (-[WebHTMLView _isMoveDrag]):
2222         (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
2223         * WebView/WebPolicyDelegate.mm:
2224         (-[WebPolicyDecisionListener _usePolicy:]):
2225         (-[WebPolicyDecisionListener use]):
2226         (-[WebPolicyDecisionListener ignore]):
2227         (-[WebPolicyDecisionListener download]):
2228         (-[WebPolicyDecisionListener continue]):
2229         * WebView/WebScriptDebugDelegate.m:
2230         (-[WebScriptCallFrame _initWithFrame:initWithWebFrame:]):
2231         (-[WebScriptCallFrame globalObject]):
2232         * WebView/WebView.mm:
2233         (-[WebView _attachScriptDebuggerToAllFrames]):
2234         (-[WebView _detachScriptDebuggerFromAllFrames]):
2235         (-[WebView windowScriptObject]):
2236         (incrementFrame):
2237         (-[WebView searchFor:direction:caseSensitive:wrap:]):
2238         (-[WebView writeSelectionWithPasteboardTypes:toPasteboard:]):
2239         (-[WebView removeDragCaret]):
2240         (-[WebView setScriptDebugDelegate:]):
2241         (-[WebView scriptDebugDelegate]):
2242         (-[WebView shouldClose]):
2243         (-[WebView selectedDOMRange]):
2244         (-[WebView styleDeclarationWithText:]):
2245
2246 2006-10-25  Geoffrey Garen  <ggaren@apple.com>
2247
2248         Reviewed by Adam.
2249
2250         Renamed WebFrameLoader to FrameLoader, to match class name.
2251
2252         * Plugins/WebBaseNetscapePluginView.mm:
2253         * Plugins/WebNetscapePluginStream.mm:
2254         * Plugins/WebPluginController.mm:
2255         * WebCoreSupport/WebFrameBridge.mm:
2256         * WebView/WebDataSource.mm:
2257         * WebView/WebFrame.mm:
2258         * WebView/WebPDFView.mm:
2259         * WebView/WebPolicyDelegate.mm:
2260         * WebView/WebView.mm:
2261
2262 2006-10-25  Mark Rowe  <bdash@webkit.org>
2263
2264         Reviewed by Anders.
2265
2266         Build fix for the Buildbot.
2267
2268         * WebView/WebHTMLView.m:
2269         (-[NSArray _addToStyle:fontA:fontB:]): Explicit cast.
2270
2271 2006-10-25  Maciej Stachowiak  <mjs@apple.com>
2272
2273         Reviewed by Anders.
2274         
2275         <rdar://problem/4785575> REGRESSION: form resubmission warning occurs twice, then Safari crashes in autorelease pool
2276         <rdar://problem/4799383> REGRESSION: Crash occurs when dismissing the "Would you like to save this password" sheet
2277
2278         * WebView/WebPolicyDeciderMac.m:
2279         (-[WebPolicyDeciderMac dealloc]): release the listener, don't dealloc it
2280
2281 2006-10-24  Anders Carlsson  <acarlsson@apple.com>
2282
2283         Reviewed by Darin.
2284
2285         * WebKitPrefix.h:
2286         Include FastMalloc.h from C++ code.
2287
2288 2006-10-24  Darin Adler  <darin@apple.com>
2289
2290         Reviewed by Anders.
2291
2292         - converted WebFrameLoaderClient to C++
2293         - renamed frame->frameLoader() function to frame->loader()
2294         - renamed [bridge impl] to [bridge _frame]
2295         - removed some bridge methods
2296
2297         * Plugins/WebNetscapePluginStream.mm:
2298         * WebCoreSupport/WebEditorClient.mm:
2299         * WebCoreSupport/WebFrameLoaderClient.h: Added.
2300         (WebFrameLoaderClient::webFrame):
2301         * WebCoreSupport/WebFrameLoaderClient.mm: Added.
2302         (WebFrameLoaderClient::detachFrameLoader):
2303         (WebFrameLoaderClient::hasWebView):
2304         (WebFrameLoaderClient::hasFrameView):
2305         (WebFrameLoaderClient::hasBackForwardList):
2306         (WebFrameLoaderClient::resetBackForwardList):
2307         (WebFrameLoaderClient::provisionalItemIsTarget):
2308         (WebFrameLoaderClient::loadProvisionalItemFromPageCache):
2309         (WebFrameLoaderClient::invalidateCurrentItemPageCache):
2310         (WebFrameLoaderClient::privateBrowsingEnabled):
2311         (WebFrameLoaderClient::makeDocumentView):
2312         (WebFrameLoaderClient::makeRepresentation):
2313         (WebFrameLoaderClient::setDocumentViewFromPageCache):
2314         (WebFrameLoaderClient::forceLayout):
2315         (WebFrameLoaderClient::forceLayoutForNonHTML):
2316         (WebFrameLoaderClient::updateHistoryForCommit):
2317         (WebFrameLoaderClient::updateHistoryForBackForwardNavigation):
2318         (WebFrameLoaderClient::updateHistoryForReload):
2319         (WebFrameLoaderClient::updateHistoryForStandardLoad):
2320         (WebFrameLoaderClient::updateHistoryForInternalLoad):
2321         (WebFrameLoaderClient::updateHistoryAfterClientRedirect):
2322         (WebFrameLoaderClient::setCopiesOnScroll):
2323         (WebFrameLoaderClient::tokenForLoadErrorReset):
2324         (WebFrameLoaderClient::resetAfterLoadError):
2325         (WebFrameLoaderClient::doNotResetAfterLoadError):
2326         (WebFrameLoaderClient::detachedFromParent1):
2327         (WebFrameLoaderClient::detachedFromParent2):
2328         (WebFrameLoaderClient::detachedFromParent3):
2329         (WebFrameLoaderClient::detachedFromParent4):
2330         (WebFrameLoaderClient::loadedFromPageCache):
2331         (WebFrameLoaderClient::download):
2332         (WebFrameLoaderClient::dispatchIdentifierForInitialRequest):
2333         (WebFrameLoaderClient::dispatchWillSendRequest):
2334         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
2335         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
2336         (WebFrameLoaderClient::dispatchDidReceiveResponse):
2337         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
2338         (WebFrameLoaderClient::dispatchDidFinishLoading):
2339         (WebFrameLoaderClient::dispatchDidFailLoading):
2340         (WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
2341         (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
2342         (WebFrameLoaderClient::dispatchDidCancelClientRedirect):
2343         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
2344         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
2345         (WebFrameLoaderClient::dispatchWillClose):
2346         (WebFrameLoaderClient::dispatchDidReceiveIcon):
2347         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
2348         (WebFrameLoaderClient::dispatchDidReceiveTitle):
2349         (WebFrameLoaderClient::dispatchDidCommitLoad):
2350         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
2351         (WebFrameLoaderClient::dispatchDidFailLoad):
2352         (WebFrameLoaderClient::dispatchDidFinishLoad):
2353         (WebFrameLoaderClient::dispatchDidFirstLayout):
2354         (WebFrameLoaderClient::dispatchCreatePage):
2355         (WebFrameLoaderClient::dispatchShow):
2356         (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
2357         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
2358         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
2359         (WebFrameLoaderClient::dispatchUnableToImplementPolicy):
2360         (WebFrameLoaderClient::dispatchWillSubmitForm):
2361         (WebFrameLoaderClient::dispatchDidLoadMainResource):
2362         (WebFrameLoaderClient::clearLoadingFromPageCache):
2363         (WebFrameLoaderClient::isLoadingFromPageCache):
2364         (WebFrameLoaderClient::revertToProvisionalState):
2365         (WebFrameLoaderClient::setMainDocumentError):
2366         (WebFrameLoaderClient::clearUnarchivingState):
2367         (WebFrameLoaderClient::progressStarted):
2368         (WebFrameLoaderClient::progressCompleted):
2369         (WebFrameLoaderClient::incrementProgress):
2370         (WebFrameLoaderClient::completeProgress):
2371         (WebFrameLoaderClient::setMainFrameDocumentReady):
2372         (WebFrameLoaderClient::startDownload):
2373         (WebFrameLoaderClient::willChangeTitle):
2374         (WebFrameLoaderClient::didChangeTitle):
2375         (WebFrameLoaderClient::committedLoad):
2376         (WebFrameLoaderClient::finishedLoading):
2377         (WebFrameLoaderClient::finalSetupForReplace):
2378         (WebFrameLoaderClient::cancelledError):
2379         (WebFrameLoaderClient::cannotShowURLError):
2380         (WebFrameLoaderClient::interruptForPolicyChangeError):
2381         (WebFrameLoaderClient::cannotShowMIMETypeError):
2382         (WebFrameLoaderClient::fileDoesNotExistError):
2383         (WebFrameLoaderClient::shouldFallBack):
2384         (WebFrameLoaderClient::mainFrameURL):
2385         (WebFrameLoaderClient::setDefersCallbacks):
2386         (WebFrameLoaderClient::willUseArchive):
2387         (WebFrameLoaderClient::isArchiveLoadPending):
2388         (WebFrameLoaderClient::cancelPendingArchiveLoad):
2389         (WebFrameLoaderClient::clearArchivedResources):
2390         (WebFrameLoaderClient::canHandleRequest):
2391         (WebFrameLoaderClient::canShowMIMEType):
2392         (WebFrameLoaderClient::representationExistsForURLScheme):
2393         (WebFrameLoaderClient::generatedMIMETypeForURLScheme):
2394         (WebFrameLoaderClient::elementForEvent):
2395         (WebFrameLoaderClient::createPolicyDecider):
2396         (WebFrameLoaderClient::frameLoadCompleted):
2397         (WebFrameLoaderClient::restoreScrollPositionAndViewState):
2398         (WebFrameLoaderClient::provisionalLoadStarted):
2399         (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent):
2400         (WebFrameLoaderClient::addHistoryItemForFragmentScroll):
2401         (WebFrameLoaderClient::didFinishLoad):
2402         (WebFrameLoaderClient::prepareForDataSourceReplacement):
2403         (WebFrameLoaderClient::createDocumentLoader):
2404         (WebFrameLoaderClient::setTitle):
2405         * WebKit.xcodeproj/project.pbxproj:
2406         * WebView/WebDataSource.mm:
2407         (-[WebDataSource webFrame]):
2408         * WebView/WebFrame.mm:
2409         (frame):
2410         (-[WebFrame _loadItem:withLoadType:]):
2411         (-[WebFrame _reloadForPluginChanges]):
2412         (-[WebFrame _initWithWebFrameView:webView:bridge:]):
2413         (-[WebFrame _frameLoader]):
2414         (-[WebFrame provisionalDataSource]):
2415         (-[WebFrame dataSource]):
2416         (-[WebFrame parentFrame]):
2417         (-[WebFrame _provisionalLoadStarted]):
2418         * WebView/WebFrameInternal.h:
2419         * WebView/WebHTMLRepresentation.m:
2420         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
2421         * WebView/WebHTMLView.m:
2422         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
2423         (-[NSArray validateUserInterfaceItem:]):
2424         (-[NSArray scrollWheel:]):
2425         (-[NSArray acceptsFirstMouse:]):
2426         (-[NSArray shouldDelayWindowOrderingForEvent:]):
2427         (-[NSArray _selectionStartFontAttributesAsRTF]):
2428         (-[NSArray changeBaseWritingDirection:]):
2429         (-[NSArray indent:]):
2430         (-[NSArray outdent:]):
2431         (-[WebHTMLView copy:]):
2432         (-[WebHTMLView cut:]):
2433         (-[WebHTMLView paste:]):
2434         * WebView/WebView.mm:
2435         (-[WebView _dashboardRegions]):
2436         (-[WebView setProhibitsMainFrameScrolling:]):
2437         (-[WebView _setInViewSourceMode:]):
2438         (-[WebView _inViewSourceMode]):
2439         (-[WebView setEditable:]):
2440
2441 2006-10-24  John Sullivan  <sullivan@apple.com>
2442
2443         Reviewed by Kevin Decker
2444         
2445         - fixed <rdar://problem/4801331> "Spelling..." menu item should be "Show/Hide Spelling" post-Tiger, to match AppKit
2446
2447         * WebView/WebHTMLView.m:
2448         (-[NSArray validateUserInterfaceItem:]):
2449         post-Tiger, update the menu item text to "Show Spelling"/"Hide Spelling" based on whether
2450         the spelling panel is already showing. Also, removed else's after returns, and removed
2451         braces around one-line if clauses.
2452         (-[NSArray showGuessPanel:]):
2453         post-Tiger, make this item hide the spelling panel if it's already showing
2454
2455         * English.lproj/Localizable.strings:
2456         updated for this change
2457         
2458 2006-10-24  Timothy Hatcher  <timothy@apple.com>
2459
2460         Reviewed by Anders.
2461
2462         <rdar://problem/4588878> 'WebHTMLView' may not respond to '-_webView'
2463
2464         * Misc/WebNSViewExtras.h:
2465         * Misc/WebNSViewExtras.m:
2466         (-[NSView _webView]):
2467
2468 2006-10-24  Brady Eidson  <beidson@apple.com>
2469
2470         Reviewed by Anders
2471
2472         http://bugs.webkit.org/show_bug.cgi?id=11406 - Crash in [WebFrame dataSource]
2473         In the transition to ObjC++ we lost alot of our free nil checking that we must now do manually
2474         to prevent null dereferencing.
2475
2476         * WebView/WebFrame.mm:
2477         (-[WebFrame provisionalDataSource]):
2478         (-[WebFrame dataSource]):
2479
2480 2006-10-24  John Sullivan  <sullivan@apple.com>
2481
2482         Reviewed by Darin
2483         
2484         Initial plumbing for grammar checking. No actual grammar are checked at this time.
2485
2486         * English.lproj/WebViewEditingContextMenu.nib/classes.nib:
2487         * English.lproj/WebViewEditingContextMenu.nib/info.nib:
2488         * English.lproj/WebViewEditingContextMenu.nib/objects.nib:
2489         Added grammar-checking item, reworded to match changes in framework. This will be used
2490         post-Tiger.
2491
2492         * English.lproj/WebViewEditingContextMenuOld.nib/classes.nib: Added.
2493         * English.lproj/WebViewEditingContextMenuOld.nib/info.nib: Added.
2494         * English.lproj/WebViewEditingContextMenuOld.nib/objects.nib: Added.
2495         Copy of WebViewEditingContextMenu.nib, unchanged. This will be used on Tiger.
2496
2497         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
2498         (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
2499         Choose the right context menu based on BUILDING_ON_TIGER.
2500         
2501         * WebView/WebPreferenceKeysPrivate.h:
2502         declare grammar-related NSUserDefault value
2503
2504         * WebView/WebViewPrivate.h:
2505         declare grammar-related methods
2506
2507         * WebView/WebView.mm:
2508         declare static BOOL grammarCheckingEnabled
2509         (-[WebViewPrivate init]):
2510         initialize grammarCheckingEnabled to NSUserDefaults value
2511         (-[WebView validateUserInterfaceItem:]):
2512         validate toggleGrammarChecking: menu item
2513         (-[WebView isGrammarCheckingEnabled]):
2514         return value of grammarCheckingEnabled
2515         (-[WebView setGrammarCheckingEnabled:]):
2516         set value of grammarCheckingEnabled, call frame to remove existing bad grammar markers
2517         (-[WebView toggleGrammarChecking:]):
2518         flip the value
2519         
2520         * WebView/WebFrameInternal.h:
2521         * WebView/WebFrame.mm:
2522         (-[WebFrame _unmarkAllBadGrammar]):
2523         new placeholder method, does nothing yet
2524         
2525         * WebView/WebHTMLViewInternal.h:
2526         declare grammar-related methods
2527
2528         * WebView/WebHTMLView.m:
2529         (-[NSArray validateUserInterfaceItem:]):
2530         validate toggleGrammarChecking: menu item
2531         (-[WebHTMLView isGrammarCheckingEnabled]):
2532         new method, calls through to WebView
2533         (-[WebHTMLView setGrammarCheckingEnabled:]):
2534         ditto
2535         (-[WebHTMLView toggleGrammarChecking:]):
2536         ditto
2537                 
2538         * English.lproj/StringsNotToBeLocalized.txt:
2539         Updated for these changes
2540         
2541         * WebKit.xcodeproj/project.pbxproj:
2542         updated for new files        
2543
2544 2006-10-23  Darin Adler  <darin@apple.com>
2545
2546         Reviewed by Geoff.
2547
2548         - converted WebDocumentLoader to C++
2549
2550         * Plugins/WebPluginController.mm:
2551         (-[WebPluginController pluginView:receivedResponse:]):
2552         * WebKit.xcodeproj/project.pbxproj:
2553         * WebView/WebDataSource.mm:
2554         (-[WebDataSourcePrivate dealloc]):
2555         (-[WebDataSource _mainDocumentError]):
2556         (-[WebDataSource _URL]):
2557         (-[WebDataSource _loadFromPageCache:]):
2558         (-[WebDataSource _bridge]):
2559         (-[WebDataSource _URLForHistory]):
2560         (-[WebDataSource _documentLoader]):
2561         (-[WebDataSource _initWithDocumentLoader:]):
2562         (-[WebDataSource initWithRequest:]):
2563         (-[WebDataSource data]):
2564         (-[WebDataSource webFrame]):
2565         (-[WebDataSource initialRequest]):
2566         (-[WebDataSource request]):
2567         (-[WebDataSource response]):
2568         (-[WebDataSource textEncodingName]):
2569         (-[WebDataSource isLoading]):
2570         (-[WebDataSource unreachableURL]):
2571         (-[WebDataSource webArchive]):
2572         * WebView/WebDataSourceInternal.h:
2573         * WebView/WebDocumentLoaderMac.h:
2574         * WebView/WebDocumentLoaderMac.mm:
2575         (WebDocumentLoaderMac::WebDocumentLoaderMac):
2576         (WebDocumentLoaderMac::setDataSource):
2577         (WebDocumentLoaderMac::dataSource):
2578         (WebDocumentLoaderMac::attachToFrame):
2579         (WebDocumentLoaderMac::detachFromFrame):
2580         * WebView/WebFrame.mm:
2581         (-[WebFrame _createItem:]):
2582         (-[WebFrame _loadItem:withLoadType:]):
2583         (-[WebFrame _addChild:]):
2584         (dataSource):
2585         (-[WebFrame _dataSourceForDocumentLoader:]):
2586         (-[WebFrame _addDocumentLoader:toUnarchiveState:]):
2587         (-[WebFrame loadArchive:]):
2588         (-[WebFrame _updateHistoryForReload]):
2589         (-[WebFrame _updateHistoryForStandardLoad]):
2590         (-[WebFrame _updateHistoryForInternalLoad]):
2591         (-[WebFrame _dispatchIdentifierForInitialRequest:fromDocumentLoader:]):
2592         (-[WebFrame _dispatchResource:willSendRequest:redirectResponse:fromDocumentLoader:]):
2593         (-[WebFrame _dispatchDidReceiveAuthenticationChallenge:forResource:fromDocumentLoader:]):
2594         (-[WebFrame _dispatchDidCancelAuthenticationChallenge:forResource:fromDocumentLoader:]):
2595         (-[WebFrame _dispatchResource:didReceiveResponse:fromDocumentLoader:]):
2596         (-[WebFrame _dispatchResource:didReceiveContentLength:fromDocumentLoader:]):
2597         (-[WebFrame _dispatchResource:didFinishLoadingFromDocumentLoader:]):
2598         (-[WebFrame _dispatchResource:didFailLoadingWithError:fromDocumentLoader:]):
2599         (-[WebFrame _dispatchDidLoadMainResourceForDocumentLoader:]):
2600         (-[WebFrame _clearLoadingFromPageCacheForDocumentLoader:]):
2601         (-[WebFrame _isDocumentLoaderLoadingFromPageCache:]):
2602         (-[WebFrame _makeRepresentationForDocumentLoader:]):
2603         (-[WebFrame _revertToProvisionalStateForDocumentLoader:]):
2604         (-[WebFrame _setMainDocumentError:forDocumentLoader:]):
2605         (-[WebFrame _clearUnarchivingStateForLoader:]):
2606         (-[WebFrame _willChangeTitleForDocument:]):
2607         (-[WebFrame _didChangeTitleForDocument:]):
2608         (-[WebFrame _finishedLoadingDocument:]):
2609         (-[WebFrame _committedLoadWithDocumentLoader:data:]):
2610         (-[WebFrame _documentLoader:setMainDocumentError:]):
2611         (-[WebFrame _finalSetupForReplaceWithDocumentLoader:]):
2612         (-[WebFrame _createDocumentLoaderWithRequest:]):
2613         (-[WebFrame _provisionalLoadStarted]):
2614         * WebView/WebFrameInternal.h:
2615         * WebView/WebHTMLRepresentation.m:
2616         (-[WebHTMLRepresentation title]):
2617         * WebView/WebView.mm:
2618         (-[WebView _mainFrameOverrideEncoding]):
2619
2620 2006-10-23  Geoffrey Garen  <ggaren@apple.com>
2621
2622         RS by Maciej.
2623         
2624         Gave ObjC++ files .mm extension instead of .m.
2625
2626         * WebCoreSupport/WebPageBridge.m: Removed.
2627         * WebKit.xcodeproj/project.pbxproj:
2628         * WebView/WebDocumentLoaderMac.m: Removed.
2629
2630 2006-10-23  Darin Adler  <darin@apple.com>
2631
2632         Reviewed by Maciej.
2633
2634         - converted WebFrameLoader to C++
2635
2636         * History/WebHistoryItem.m:
2637         (+[WebHistoryItem _closeObjectsInPendingPageCaches]):
2638         * Plugins/WebBaseNetscapePluginView.mm:
2639         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
2640         * Plugins/WebNetscapePluginStream.mm:
2641         (-[WebNetscapePluginStream start]):
2642         (-[WebNetscapePluginStream stop]):
2643         * Plugins/WebPluginController.mm:
2644         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
2645         (-[WebPluginController pluginView:receivedResponse:]):
2646         * WebCoreSupport/WebFrameBridge.h:
2647         * WebKit.xcodeproj/project.pbxproj:
2648         * WebView/WebDataSource.mm:
2649         (-[WebDataSource _loadFromPageCache:]):
2650         (-[WebDataSource _webView]):
2651         (-[WebDataSource webFrame]):
2652         * WebView/WebDocumentLoaderMac.h:
2653         * WebView/WebDocumentLoaderMac.m:
2654         (-[WebDocumentLoaderMac dealloc]):
2655         (-[WebDocumentLoaderMac attachToFrame]):
2656         (-[WebDocumentLoaderMac detachFromFrame]):
2657         * WebView/WebFrame.mm:
2658         (+[WebFrame _timeOfLastCompletedLoad]):
2659         (-[WebFrame _loadItem:withLoadType:]):
2660         (-[WebFrame _loadURL:referrer:intoChild:]):
2661         (-[WebFrame _currentBackForwardListItemToResetTo]):
2662         (-[WebFrame _itemForRestoringDocState]):
2663         (-[WebFrame _frameLoader]):
2664         (-[WebFrame _firstLayoutDone]):
2665         (-[WebFrame _loadType]):
2666         (-[WebFrame provisionalDataSource]):
2667         (-[WebFrame dataSource]):
2668         (-[WebFrame loadRequest:]):
2669         (-[WebFrame loadArchive:]):
2670         (-[WebFrame stopLoading]):
2671         (-[WebFrame reload]):
2672         (-[WebFrame _updateHistoryForCommit]):
2673         (-[WebFrame _updateHistoryForReload]):
2674         (-[WebFrame _updateHistoryForInternalLoad]):
2675         (-[WebFrame _deliverArchivedResourcesAfterDelay]):
2676         (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]):
2677         (-[WebFrame _deliverArchivedResources]):
2678         (-[WebFrame _prepareForDataSourceReplacement]):
2679         (-[WebFrame _provisionalLoadStarted]):
2680         * WebView/WebFrameInternal.h:
2681         * WebView/WebHTMLView.m:
2682         (-[WebHTMLView _clearLastHitViewIfSelf]):
2683         (-[WebHTMLView _updateMouseoverWithEvent:]):
2684         (-[NSArray removeMouseMovedObserverUnconditionally]):
2685         (-[NSArray removeMouseMovedObserver]):
2686         (-[NSArray viewWillMoveToWindow:]):
2687         (-[NSArray viewDidMoveToWindow]):
2688         (-[WebHTMLView _canMakeTextSmaller]):
2689         (-[WebHTMLView _canMakeTextLarger]):
2690         (-[WebHTMLView _canMakeTextStandardSize]):
2691         * WebView/WebPDFView.mm:
2692         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2693         * WebView/WebView.mm:
2694         (-[WebView _close]):
2695         (-[WebView setDefersCallbacks:]):
2696         (-[WebView setCustomTextEncodingName:]):
2697
2698 2006-10-23  Geoffrey Garen  <ggaren@apple.com>
2699
2700         Reviewed by Bradee.
2701
2702         Moved some page-level operations from WebFrameBridge to WebPageBridge.
2703
2704         * WebCoreSupport/WebFrameBridge.m:
2705         * WebCoreSupport/WebPageBridge.m:
2706         (-[WebPageBridge createModalDialogWithURL:referrer:]):
2707         (-[WebPageBridge canRunModal]):
2708         (-[WebPageBridge canRunModalNow]):
2709         (-[WebPageBridge runModal]):
2710         * WebKit.xcodeproj/project.pbxproj: Made WebPageBridge.m ObjC++ to support
2711         WebCore #includes.
2712
2713 2006-10-23  John Sullivan  <sullivan@apple.com>
2714
2715         * WebKitPrefix.h:
2716         Removed redundant definition of BUILDING_ON_TIGER that I just added. It turns out this had
2717         already been added between the last time I updated in this tree and when I needed it locally.
2718
2719 2006-10-23  John Sullivan  <sullivan@apple.com>
2720
2721         Reviewed by Anders
2722
2723         * WebKit.xcodeproj/project.pbxproj:
2724         Move WebKitPrefix.h from Misc group to top level, to match WebCore
2725         
2726         * WebKitPrefix.h:
2727         defined BUILDING_ON_TIGER a la WebCore, in preparation for future use of post-Tiger API
2728
2729 2006-10-23  Timothy Hatcher  <timothy@apple.com>
2730
2731         Reviewed by Darin.
2732
2733         Rename the now ObjC++ files to be .mm and remove the explicit file types.
2734
2735         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
2736         (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
2737         * English.lproj/StringsNotToBeLocalized.txt:
2738         * Plugins/WebBaseNetscapePluginView.m: Removed.
2739         * Plugins/WebNetscapePluginStream.m: Removed.
2740         * Plugins/WebPluginController.m: Removed.
2741         * WebCoreSupport/WebFrameBridge.m: Removed.
2742         * WebKit.xcodeproj/project.pbxproj:
2743         * WebView/WebDataSource.m: Removed.
2744         * WebView/WebFrame.m: Removed.
2745         * WebView/WebFrameView.m: Removed.
2746         * WebView/WebPDFView.m: Removed.
2747         * WebView/WebPolicyDelegate.m: Removed.
2748         * WebView/WebView.m: Removed.
2749
2750 2006-10-23  Timothy Hatcher  <timothy@apple.com>
2751
2752         Reviewed by Darin.
2753
2754         Move the undef try/catch to WebKitPrefix.h and include algorithm so we get
2755         exception_defines.h and so the undef of try/catch works.
2756
2757         Break off the BGRA to ARGB code into WebGraphicsExtras.c, this lets
2758         WebBaseNetscapePluginView.m safely compile as ObjC++ and not cause the Accelerate
2759         framework to complain about C++ exceptions being disabled.
2760
2761         * Misc/WebGraphicsExtras.c: Added.
2762         (WebConvertBGRAToARGB):
2763         * Misc/WebGraphicsExtras.h: Added.
2764         * Plugins/WebBaseNetscapePluginView.m:
2765         (-[WebBaseNetscapePluginView _aglOffscreenImageForDrawingInRect:]):
2766         * WebKit.xcodeproj/project.pbxproj:
2767         * WebKitPrefix.h:
2768         * WebView/WebView.m:
2769
2770 2006-10-22  Sam Weinig  <sam.weinig@gmail.com>
2771
2772         Reviewed by Tim H.
2773
2774         - Add DOMHTMLFormElementPrivate.h to the project.
2775
2776         * MigrateHeaders.make:
2777
2778 2006-10-21  Darin Adler  <darin@apple.com>
2779
2780         Reviewed by Adele.
2781
2782         - convert WebLoader and its 3 subclasses to C++
2783
2784         * Plugins/WebNetscapePluginStream.h:
2785         * Plugins/WebNetscapePluginStream.m:
2786         (-[WebNetscapePluginStream dealloc]):
2787         (-[WebNetscapePluginStream finalize]):
2788         (-[WebNetscapePluginStream start]):
2789         (-[WebNetscapePluginStream cancelLoadWithError:]):
2790         (-[WebNetscapePluginStream stop]):
2791         * WebCoreSupport/WebFrameBridge.m:
2792         (-[WebFrameBridge canRunModalNow]):
2793         * WebView/WebFrame.m:
2794         (-[WebFramePrivate dealloc]):
2795         (-[WebFramePrivate finalize]):
2796         (frame): Changed from uppercase to lowercase so that it won't conflict
2797         with the WebCore class named Frame.
2798         (-[WebFrame _firstChildFrame]):
2799         (-[WebFrame _lastChildFrame]):
2800         (-[WebFrame _previousSiblingFrame]):
2801         (-[WebFrame _nextSiblingFrame]):
2802         (-[WebFrame _traverseNextFrameStayWithin:]):
2803         (-[WebFrame _immediateChildFrameNamed:]):
2804         (-[WebFrame _nextFrameWithWrap:]):
2805         (-[WebFrame _previousFrameWithWrap:]):
2806         (-[WebFrame findFrameNamed:]):
2807         (-[WebFrame parentFrame]):
2808         (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]):
2809         (-[WebFrame _deliverArchivedResourcesAfterDelay]):
2810         (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]):
2811         (-[WebFrame _archiveLoadPendingForLoader:]):
2812         (-[WebFrame _cancelPendingArchiveLoadForLoader:]):
2813         (-[WebFrame _clearArchivedResources]):
2814         (-[WebFrame _deliverArchivedResources]):
2815
2816 2006-10-21  Darin Adler  <darin@apple.com>
2817
2818         Reviewed by Anders.
2819
2820         - fix http://bugs.webkit.org/show_bug.cgi?id=10328
2821           REGRESSION: frame leak reported by buildbot
2822
2823         * WebCoreSupport/WebEditorClient.mm:
2824         (WebEditorClient::WebEditorClient): Don't retain the web view.
2825         (WebEditorClient::~WebEditorClient): Don't release the web view.
2826         (WebEditorClient::setWebView): Ditto.
2827
2828         * WebCoreSupport/WebFrameBridge.m:
2829         (-[WebFrameBridge finishInitializingWithFrameName:view:]): Added. Common code for use by both
2830         init methods below.
2831         (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): Changed to use new method.
2832         Also added comment pointing out design flaw -- we attach the client to the web view here,
2833         but we need to be sure to detach in case the web view is deallocated first.
2834         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): Ditto.
2835
2836 2006-10-21  Darin Adler  <darin@apple.com>
2837
2838         Reviewed by Adam.
2839
2840         - http://bugs.webkit.org/show_bug.cgi?id=11376
2841           build scripts should invoke make with "-j" option for multiple processors
2842
2843         * WebKit.xcodeproj/project.pbxproj: Pass -j `sysctl -n hw.ncpu` to make.
2844
2845 2006-10-21  Timothy Hatcher  <timothy@apple.com>
2846
2847         Reviewed by Geoff.
2848
2849         <rdar://problem/4478625> HTML Editing: Basic table editing and culling
2850
2851         Initial implementaltion of table deletion user interface:
2852         * Adds a new editing delegate method, webView:shouldShowDeleteInterfaceForElement:.
2853         * The new delegate method is called from the new shouldShowDeleteInterface EditorClient function.
2854
2855         * DefaultDelegates/WebDefaultEditingDelegate.m:
2856         (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]):
2857         * WebCoreSupport/WebEditorClient.h:
2858         * WebCoreSupport/WebEditorClient.mm:
2859         (WebEditorClient::WebEditorClient):
2860         (WebEditorClient::shouldDeleteRange):
2861         (WebEditorClient::shouldShowDeleteInterface):
2862         * WebKit.xcodeproj/project.pbxproj:
2863         * WebView/WebEditingDelegatePrivate.h: Added.
2864
2865 2006-10-21  Alice Liu  <alice.liu@apple.com>
2866
2867         Reviewed by Maciej.
2868
2869         fix leaks.
2870
2871         * WebCoreSupport/WebEditorClient.mm:
2872         (WebEditorClient::setWebView):
2873         only change webview if its different
2874
2875         * WebCoreSupport/WebFrameBridge.m:
2876         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
2877         actually use the client allocated in the line above instead of
2878         allocation again, duh. 
2879
2880 2006-10-21  Alice Liu  <alice.liu@apple.com>
2881
2882         Build fix.
2883
2884         * WebCoreSupport/WebEditorClient.h:
2885         * WebCoreSupport/WebEditorClient.mm:
2886         (WebEditorClient::setWebView):
2887
2888 2006-10-20  Alice Liu  <alice.liu@apple.com>
2889
2890         Reviewed by Tim Hatcher.
2891
2892         Fixed a problem where the webview passed to the EditorClient wasn't valid yet.  
2893
2894         * WebCoreSupport/WebEditorClient.h:
2895         (WebEditorClient::setWebView):
2896         added webview setter
2897
2898         * WebCoreSupport/WebEditorClient.mm:
2899         (WebEditorClient::WebEditorClient):
2900         add default constructor
2901
2902         * WebCoreSupport/WebFrameBridge.m:
2903         (-[WebFrameBridge initMainFrameWithPage:frameName:view:]):
2904         use [page webView] since _webview isn't valid yet
2905         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
2906         use webview setter on editorclient
2907
2908 2006-10-20  David Hyatt  <hyatt@apple.com>
2909
2910         Tweak cache sizes so that they are back to the way they were,
2911         except for < 512, which will stay doubled.
2912
2913         Reviewed by Tim H.
2914
2915         * WebCoreSupport/WebFrameBridge.m:
2916         (-[WebFrameBridge getObjectCacheSize]):
2917
2918 2006-10-20  Alice Liu  <alice.liu@apple.com>
2919
2920         Reviewed by Maciej.
2921
2922         Adding knowledge of EditorClient to WebKit
2923
2924         * WebCoreSupport/WebEditorClient.h: Added.
2925
2926         * WebCoreSupport/WebEditorClient.mm: Added.
2927         (WebEditorClient::WebEditorClient):
2928         (WebEditorClient::~WebEditorClient):
2929         (WebEditorClient::shouldDeleteRange):
2930         Implementation of mac EditorClient
2931
2932         * WebCoreSupport/WebFrameBridge.m:
2933         (-[WebFrameBridge initMainFrameWithPage:frameName:view:]):
2934         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
2935         create an editor client to pass down the chain of constructors
2936
2937         * WebKit.xcodeproj/project.pbxproj:
2938         Added related EditorClient files
2939
2940         * WebKitPrefix.h:
2941         Added tiger build flag in order to make certain private headers from webcore compile successfully
2942
2943 2006-10-20  Darin Adler  <darin@apple.com>
2944
2945         - rolled out my loader change; caused world leak and possibly a plug-in crash
2946
2947 2006-10-20  Darin Adler  <darin@apple.com>
2948
2949         Reviewed by Adele.
2950
2951         - convert WebLoader and its 3 subclasses to C++
2952
2953         * Plugins/WebNetscapePluginStream.h:
2954         * Plugins/WebNetscapePluginStream.m:
2955         (-[WebNetscapePluginStream dealloc]):
2956         (-[WebNetscapePluginStream finalize]):
2957         (-[WebNetscapePluginStream start]):
2958         (-[WebNetscapePluginStream cancelLoadWithError:]):
2959         (-[WebNetscapePluginStream stop]):
2960         * WebCoreSupport/WebFrameBridge.m:
2961         (-[WebFrameBridge canRunModalNow]):
2962         * WebView/WebFrame.m:
2963         (-[WebFramePrivate dealloc]):
2964         (-[WebFramePrivate finalize]):
2965         (frame): Changed from uppercase to lowercase so that it won't conflict
2966         with the WebCore class named Frame.
2967         (-[WebFrame _firstChildFrame]):
2968         (-[WebFrame _lastChildFrame]):
2969         (-[WebFrame _previousSiblingFrame]):
2970         (-[WebFrame _nextSiblingFrame]):
2971         (-[WebFrame _traverseNextFrameStayWithin:]):
2972         (-[WebFrame _immediateChildFrameNamed:]):
2973         (-[WebFrame _nextFrameWithWrap:]):
2974         (-[WebFrame _previousFrameWithWrap:]):
2975         (-[WebFrame findFrameNamed:]):
2976         (-[WebFrame parentFrame]):
2977         (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]):
2978         (-[WebFrame _deliverArchivedResourcesAfterDelay]):
2979         (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]):
2980         (-[WebFrame _archiveLoadPendingForLoader:]):
2981         (-[WebFrame _cancelPendingArchiveLoadForLoader:]):
2982         (-[WebFrame _clearArchivedResources]):
2983         (-[WebFrame _deliverArchivedResources]):
2984
2985 2006-10-20  John Sullivan  <sullivan@apple.com>
2986
2987         Reviewed by Darin
2988         
2989         - fixed <rdar://problem/4794935> setAcceptsMouseMovedEvents: is called for every layout, 
2990           taking ~1% on the PLT test
2991
2992         * WebView/WebHTMLView.m:
2993         (-[NSArray layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
2994         Don't call setAcceptsMouseMovedEvents: and WKSetNSWindowShouldPostEventNotifications() here
2995         because this is called too often.
2996         
2997         * WebView/WebView.m:
2998         (-[WebView viewWillMoveToWindow:]):
2999         Do call them here, because this is guaranteed to be called at least once for each window
3000         containing a webview, but isn't called too often. Also restructured this method a little.
3001
3002 2006-10-19  Timothy Hatcher  <timothy@apple.com>
3003
3004         Reviewed by Anders.
3005
3006         Bug 11366: Web Inspector should show user agent style rules
3007         http://bugs.webkit.org/show_bug.cgi?id=11366
3008
3009         * WebInspector/WebInspector.m:
3010         (-[WebInspector init]):
3011         (-[WebInspector showOptionsMenu]):
3012         (-[WebInspector _toggleShowUserAgentStyles:]):
3013         * WebInspector/WebInspectorInternal.h:
3014         * WebInspector/webInspector/inspector.js:
3015
3016 2006-10-19  Brady Eidson <beidson@apple.com>
3017
3018         Build fix - 2gig is on that pesky signed/unsigned limit...
3019
3020         * WebCoreSupport/WebFrameBridge.m:
3021         (-[WebFrameBridge getObjectCacheSize]):
3022
3023 2006-10-19  Brady Eidson  <beidson@apple.com>
3024
3025         Reviewed by Hyatt.
3026
3027         Death to 16777216.  Long live 33554432.
3028         (Cache size changed needs to be reflected in localization file)
3029
3030         * English.lproj/StringsNotToBeLocalized.txt:
3031
3032 2006-10-19  Brady Eidson  <beidson@apple.com>
3033
3034         Reviewed by Hyatt
3035
3036         Added an larger in-memory level of cache for machines with 2+gb ram
3037
3038         * WebCoreSupport/WebFrameBridge.m:
3039         (-[WebFrameBridge getObjectCacheSize]):
3040
3041 2006-10-19  Brady Eidson  <beidson@apple.com>
3042
3043         Reviewed by Hyatt
3044
3045         Double the default memory cache size
3046
3047         * WebView/WebPreferences.m:
3048         (+[WebPreferences initialize]):
3049
3050 2006-10-19  John Sullivan  <sullivan@apple.com>
3051
3052         Reviewed by Kevin D and Geoff
3053
3054         * WebKit.xcodeproj/project.pbxproj:
3055         version wars
3056         
3057         Cleaned up this file, as follows:
3058         - renamed all file-internal methods to start with underscores
3059         - moved all file-internal methods into a FileInternal category block, and alphabetized them
3060         - grouped all other methods by where/how they were defined (delegate methods, protocol methods, overrides, etc.)
3061         - removed unstylish braces around one-line clauses
3062         
3063         * WebView/WebPDFView.m:
3064         (_applicationInfoForMIMEType):
3065         (_PDFSelectionsAreEqual):
3066         (+[WebPDFView supportedMIMETypes]):
3067         (-[WebPDFView setPDFDocument:]):
3068         (-[WebPDFView dealloc]):
3069         (-[WebPDFView centerSelectionInVisibleArea:]):
3070         (-[WebPDFView scrollPageDown:]):
3071         (-[WebPDFView scrollPageUp:]):
3072         (-[WebPDFView scrollLineDown:]):
3073         (-[WebPDFView scrollLineUp:]):
3074         (-[WebPDFView scrollToBeginningOfDocument:]):
3075         (-[WebPDFView scrollToEndOfDocument:]):
3076         (-[WebPDFView jumpToSelection:]):
3077         (-[WebPDFView acceptsFirstResponder]):
3078         (-[WebPDFView becomeFirstResponder]):
3079         (-[WebPDFView hitTest:]):
3080         (-[WebPDFView initWithFrame:]):
3081         (-[WebPDFView menuForEvent:]):
3082         (-[WebPDFView setNextKeyView:]):
3083         (-[WebPDFView viewDidMoveToWindow]):
3084         (-[WebPDFView viewWillMoveToWindow:]):
3085         (-[WebPDFView validateUserInterfaceItem:]):
3086         (-[WebPDFView copy:]):
3087         (-[WebPDFView takeFindStringFromSelection:]):
3088         (-[WebPDFView canPrintHeadersAndFooters]):
3089         (-[WebPDFView printOperationWithPrintInfo:]):
3090         (-[WebPDFView viewWillMoveToHostWindow:]):
3091         (-[WebPDFView viewDidMoveToHostWindow]):
3092         (-[WebPDFView elementAtPoint:]):
3093         (-[WebPDFView elementAtPoint:allowShadowContent:]):
3094         (-[WebPDFView searchFor:direction:caseSensitive:wrap:]):
3095         (-[WebPDFView viewState]):
3096         (-[WebPDFView setViewState:]):
3097         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
3098         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
3099         (+[WebPDFView _PDFPreviewViewClass]):
3100         (+[WebPDFView _PDFViewClass]):
3101         (-[WebPDFView _anyPDFTagsFoundInMenu:]):
3102         (-[WebPDFView _applyPDFDefaults]):
3103         (-[WebPDFView _fakeKeyEventWithFunctionKey:]):
3104         (-[WebPDFView _menuItemsFromPDFKitForEvent:]):
3105         (-[WebPDFView _openWithFinder:]):
3106         (-[WebPDFView _path]):
3107         (-[WebPDFView _PDFSubview]):
3108         (-[WebPDFView _pointIsInSelection:]):
3109         (-[WebPDFView _receivedPDFKitLaunchNotification:]):
3110         (-[WebPDFView _scaledAttributedString:]):
3111         (-[WebPDFView _trackFirstResponder]):
3112         (-[PDFPrefUpdatingProxy forwardInvocation:]):
3113         (-[PDFPrefUpdatingProxy methodSignatureForSelector:]):
3114
3115 2006-10-19  John Sullivan  <sullivan@apple.com>
3116
3117         Reviewed by Kevin Decker
3118         
3119         - fixed <rdar://problem/4792761> Safari should use fancier embedded PDFKit stuff when it's available
3120
3121         * WebKit.xcodeproj/project.pbxproj:
3122         version wars
3123         
3124         * WebView/WebFrameView.m:
3125         (-[WebFrameView _makeDocumentViewForDataSource:]):
3126         initialize document view with frame view's rect instead of empty rect. This avoids some problems when 
3127         constructing view hierarchies from nibs
3128         
3129         * WebView/WebPreferencesPrivate.h:
3130         declare new _usePDFPreviewView and _setUsePDFPreviewView:, used for debugging
3131         * WebView/WebPreferenceKeysPrivate.h:
3132         declare new preference key string
3133         * WebView/WebPreferences.m:
3134         (+[WebPreferences initialize]):
3135         initialize new preference to true (we will by default use the new view if it's available)
3136         (-[WebPreferences _usePDFPreviewView]):
3137         new accessor for new pref
3138         (-[WebPreferences _setUsePDFPreviewView:]):
3139         ditto
3140
3141         * WebView/WebPDFView.h:
3142         new previewView ivar
3143         
3144         * WebView/WebPDFView.m:
3145         (+[WebPDFView PDFPreviewViewClass]):
3146         new method, returns class to use for fancier embedded PDFKit stuff, or nil if fancy stuff isn't available
3147         (-[WebPDFView initWithFrame:]):
3148         now tries to use fancier embedded PDFKit stuff if it's available and the pref is set to use it; falls back
3149         to old behavior otherwise
3150         (-[WebPDFView dealloc]):
3151         release new previewView ivar (retained in initWithFrame:)
3152         (-[WebPDFView viewWillMoveToWindow:]):
3153         stop observing PDFKit notification when we're removed from window
3154         (-[WebPDFView viewDidMoveToWindow]):
3155         start observing PDFKit notification when we're added to window
3156         (-[WebPDFView _receivedPDFKitLaunchNotification:]):
3157         respond to this new PDFKit notification by opening the document via NSWorkspace
3158         
3159         * English.lproj/StringsNotToBeLocalized.txt:
3160         updated for lots of recent changes
3161         
3162 2006-10-19  Sam Weinig  <sam.weinig@gmail.com>
3163
3164         Reviewed by ap.
3165
3166         Win32 build fix.
3167
3168         * COM/WebFrame.cpp:
3169         (WebFrame::initWithName):
3170         (WebFrame::createNewWindow):
3171
3172 2006-10-19  Mitz Pettel  <mitz@webkit.org>
3173
3174         Reviewed and landed by ap.
3175
3176         - fixed the inspector's tree popup
3177
3178         * WebInspector/webInspector/inspector.html:
3179
3180 2006-10-18  Sam Weinig  <sam.weinig@gmail.com>
3181
3182         Reviewed by Maciej.
3183
3184         Win32 build fix.
3185
3186         * COM/WebFrame.cpp:
3187         (WebFrame::createNewWindow):
3188         * COM/WebFrame.h:
3189
3190 2006-10-18  Anders Carlsson  <acarlsson@apple.com>
3191
3192         Reviewed by Adam.
3193
3194         http://bugs.webkit.org/show_bug.cgi?id=11000
3195         REGRESSION (r16101): css2.1/t0801-c412-hz-box-00-b-a is failing because the QuickTime plugin is taking over but not rendering the png
3196         
3197         * WebCoreSupport/WebFrameBridge.m:
3198         (-[WebFrameBridge determineObjectFromMIMEType:URL:]):
3199         Return ObjectElementFrame if the MIME type is one of the image ones we support.
3200
3201 2006-10-17  Justin Garcia  <justin.garcia@apple.com>
3202
3203         Reviewed by harrison
3204         
3205         <rdar://problem/4765600>
3206         REGRESSION: Mail.app: smart deletion of words does not work
3207         
3208         Regressed when we pushed selecion expansion down into WebCore.  It's OK
3209         to try a smart delete from _deleteWithDirection:, which is called by
3210         deleteFoward: and deleteBackward: if the current selection is a 
3211         range.
3212     
3213         * WebView/WebHTMLView.m:
3214         (-[NSArray _deleteWithDirection:granularity:killRing:isTypingAction:]):
3215
3216 2006-10-13  Justin Garcia  <justin.garcia@apple.com>
3217
3218         Reviewed by harrison
3219         
3220         <rdar://problem/3655385>
3221         Editing: -indent: method unimplemented
3222
3223         * WebView/WebHTMLView.m:
3224         (-[NSArray validateUserInterfaceItem:]): Only allow indent:/outdent: in
3225         richly editable areas.
3226         (-[NSArray indent:]):
3227         (-[NSArray outdent:]):
3228
3229 2006-10-13  Maciej Stachowiak  <mjs@apple.com>
3230
3231         Not reviewed, build fix.
3232         
3233         * icu/unicode/putil.h: Added - needed for build if you don't have apple internal headers.
3234
3235 2006-10-13  Maciej Stachowiak  <mjs@apple.com>
3236
3237         Not reviewed, build fix.
3238         
3239         * icu/unicode/ustring.h: Added - needed for build if you don't have apple internal headers.
3240
3241 2006-10-13  Maciej Stachowiak  <mjs@apple.com>
3242
3243         Reviewed by Anders.
3244         
3245         - add a bunch of casts to get this compiling with older Xcode versions
3246         
3247         (I used static_cast so it will be easier to find and remove these once we have completely moved
3248         on to a new enough compiler version.)
3249
3250         * Plugins/WebBaseNetscapePluginView.m:
3251         (+[WebBaseNetscapePluginView getCarbonEvent:]):
3252         (-[WebBaseNetscapePluginView getCarbonEvent:withEvent:]):
3253         (-[WebBaseNetscapePluginView fixWindowPort]):
3254         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
3255         (-[WebBaseNetscapePluginView _createWindowlessAGLContext]):
3256         (-[WebBaseNetscapePluginView _reshapeAGLWindow]):
3257         (-[WebBaseNetscapePluginView _aglOffscreenImageForDrawingInRect:]):
3258         * WebKit.xcodeproj/project.pbxproj:
3259
3260 2006-10-13  Kevin McCullough  <KMcCullough@apple.com>
3261
3262         Changed by Darin, reviewed by me.
3263
3264         * Plugins/WebNetscapePluginStream.m: Fixed case of import so we can compile on
3265         case-sensitive file system.
3266
3267 2006-10-13  Darin Adler  <darin@apple.com>
3268
3269         Reviewed by Adele.
3270
3271         - converted WebFormState from Objective-C to C++
3272
3273         * ForwardingHeaders: Added an entire copy of WebCore's forwarding headers here.
3274         We should eventually come up with a more-elegant solution.
3275
3276         * WebKit.xcodeproj/project.pbxproj: Added ForwardingHeaders to the include paths.
3277         Converted many files from Objective-C to Objective-C++. In a later check-in, I'll
3278         rename them to .mm instead of .m. Removed C-only warning options for now. In a
3279         later check-in I will add these back in a way that omits them for C++.
3280
3281         * Plugins/WebPluginContainerCheck.m: Updated for header changes.
3282
3283         * WebView/WebFrameInternal.h: Updated for header changes. Removed WebFrameLoaderClient category
3284         so this file can still be used by Objective-C code (not just Objective-C++).
3285
3286         * WebView/WebFrame.m: Put WebFrameLoaderClient category in here.
3287         (-[WebFrame _loadItem:withLoadType:]): Changed to use 0 instead of nil for FormState and fixed
3288         enum code for C++ compatibility.
3289         (-[WebFrame _initWithWebFrameView:webView:bridge:]): Added call to setFrameLoaderClient: here.
3290         (-[WebFrame _updateHistoryForCommit]): Fixed enum code for C++ compatibility.
3291         (-[WebFrame _updateHistoryForReload]): Ditto.
3292
3293         * WebCoreSupport/WebFrameBridge.m:
3294         (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): Removed call to setFrameLoaderClient:.
3295         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): Ditto.
3296         (-[WebFrameBridge _retrieveKeyboardUIModeFromPreferences:]): Fixed enum code for C++ compatibility.
3297         (-[WebFrameBridge runModal]): Changed code to not use "namespace" as a local variable name.
3298
3299         * WebView/WebPDFView.m: Added extern "C" so this can compile as Objective-C++.
3300
3301 2006-10-12  Maciej Stachowiak  <mjs@apple.com>
3302
3303         Reviewed by Oliver.
3304         
3305         - liberate more WebKit code down to WebCore
3306
3307         * WebCoreSupport/WebFrameBridge.h:
3308         * WebCoreSupport/WebFrameBridge.m:
3309
3310 2006-10-12  Adele Peterson  <adele@apple.com>
3311
3312         Reviewed by Maciej.
3313
3314         WebKit part of fix for <rdar://problem/4450613> need a means to attach user data to any menu that is popuped up in HTML
3315
3316         Added private delegate method for clients that want access to a PopupMenu's NSMenu.
3317
3318         * DefaultDelegates/WebDefaultUIDelegate.m: (-[NSApplication webView:willPopupMenu:]):
3319         * WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge willPopupMenu:]):
3320         * WebView/WebUIDelegatePrivate.h:
3321
3322 2006-10-12  MorganL  <morganl.webkit@yahoo.com>
3323
3324         Reviewed/landed by Adam.
3325
3326         Fixes http://bugs.webkit.org/show_bug.cgi?id=11264
3327         Windows build busted
3328
3329         * COM/WebFrame.cpp:
3330         (WebFrame::receivedResponse):
3331
3332 2006-10-11  Darin Adler  <darin@apple.com>
3333
3334         Reviewed by Adele.
3335
3336         - preparations for making more code C++
3337
3338         * WebKitPrefix.h: Fixed ifdef so that C++ files get all the precompiled stuff
3339         that non-C++ files get.
3340
3341         * Misc/WebKitLogging.h:
3342         * Misc/WebKitSystemBits.h:
3343         * Misc/WebLocalizableStrings.h:
3344         * WebCoreSupport/WebSystemInterface.h:
3345         Added extern "C".
3346
3347         * Misc/WebNSViewExtras.h:
3348         * WebView/WebDataSource.m: (addTypesFromClass):
3349         * WebView/WebFrameView.m: (addTypesFromClass):
3350         Eliminated use of the identifier "class".
3351
3352         * WebView/WebView.m: (-[WebView _goToItem:withLoadType:]): Added a type cast.
3353
3354         * Plugins/WebBaseNetscapePluginView.m: Added lots of type casts.
3355
3356 2006-10-10  Brady Eidson  <beidson@apple.com>
3357
3358         Reviewed by Maciej.
3359
3360         Moved WebFrameLoader into WebCoreFrameBridge
3361
3362         * WebCoreSupport/WebFrameBridge.h:
3363         * WebCoreSupport/WebFrameBridge.m:
3364         (-[WebFrameBridge initMainFrameWithPage:frameName:view:]):
3365         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
3366         (-[WebFrameBridge dealloc]):
3367         (-[WebFrameBridge setTitle:]):
3368         (-[WebFrameBridge receivedData:textEncodingName:]):
3369         (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
3370         (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
3371         (-[WebFrameBridge objectLoadedFromCacheWithURL:response:data:]):
3372         (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
3373         (-[WebFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
3374         (-[WebFrameBridge reportClientRedirectCancelled:]):
3375         (-[WebFrameBridge close]):
3376         (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):
3377         (-[WebFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
3378         (-[WebFrameBridge tokenizerProcessedData]):
3379         (-[WebFrameBridge frameDetached]):
3380         (-[WebFrameBridge didFirstLayout]):
3381         (-[WebFrameBridge notifyIconChanged:]):
3382         (-[WebFrameBridge originalRequestURL]):
3383         (-[WebFrameBridge isLoadTypeReload]):
3384
3385 2006-10-10  Adele Peterson  <adele@apple.com>
3386
3387         Reviewed by Beth.
3388
3389         Removed handleAutoscrollForMouseDragged.  Except for autoscroll caused by drag and drop, all other
3390         autoscrolling should be done in WebCore instead of in AppKit.
3391
3392         * WebCoreSupport/WebFrameBridge.m:
3393         * WebView/WebHTMLView.m:
3394         * WebView/WebHTMLViewPrivate.h:
3395
3396 2006-10-10  Darin Adler  <darin@apple.com>
3397
3398         - corrected an archive regression caused by loader refactoring
3399           (pointed out by Graham Dennis)
3400
3401         * WebView/WebFrame.m: (-[WebFrame _deliverArchivedResourcesAfterDelay]):
3402         Fix selector name.
3403
3404 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
3405
3406         Rubber stamped by Eric.
3407         
3408         - moved a whole bunch of stuff over to WebCore - updated includes appropriately
3409
3410         * Loader/LoaderNSURLExtras.h: Removed.
3411         * Loader/LoaderNSURLExtras.m: Removed.
3412         * Loader/WebDataProtocol.h: Removed.
3413         * Loader/WebDataProtocol.m: Removed.
3414         * Loader/WebDocumentLoader.h: Removed.
3415         * Loader/WebDocumentLoader.m: Removed.
3416         * Loader/WebFormDataStream.h: Removed.
3417         * Loader/WebFormDataStream.m: Removed.
3418         * Loader/WebFormState.h: Removed.
3419         * Loader/WebFormState.m: Removed.
3420         * Loader/WebFrameLoader.h: Removed.
3421         * Loader/WebFrameLoader.m: Removed.
3422         * Loader/WebFrameLoaderClient.h: Removed.
3423         * Loader/WebLoader.h: Removed.
3424         * Loader/WebLoader.m: Removed.
3425         * Loader/WebMainResourceLoader.h: Removed.
3426         * Loader/WebMainResourceLoader.m: Removed.
3427         * Loader/WebNetscapePlugInStreamLoader.h: Removed.
3428         * Loader/WebNetscapePlugInStreamLoader.m: Removed.
3429         * Loader/WebPlugInStreamLoaderDelegate.h: Removed.
3430         * Loader/WebPolicyDecider.h: Removed.
3431         * Loader/WebPolicyDecider.m: Removed.
3432         * Loader/WebSubresourceLoader.h: Removed.
3433         * Loader/WebSubresourceLoader.m: Removed.
3434         * Misc/WebNSURLExtras.m:
3435         * Plugins/WebBaseNetscapePluginStream.h:
3436         * Plugins/WebBaseNetscapePluginView.m:
3437         * Plugins/WebNetscapePluginStream.m:
3438         * Plugins/WebPluginContainerCheck.m:
3439         * Plugins/WebPluginController.m:
3440         * WebCoreSupport/WebFrameBridge.m:
3441         * WebKit.xcodeproj/project.pbxproj:
3442         * WebView/WebDataSource.m:
3443         * WebView/WebDocumentLoaderMac.h:
3444         * WebView/WebFrame.m:
3445         * WebView/WebFrameInternal.h:
3446         * WebView/WebHTMLView.m:
3447         * WebView/WebPolicyDeciderMac.h:
3448         * WebView/WebPolicyDelegate.m:
3449         * WebView/WebView.m:
3450
3451 2006-10-10  Mark Rowe  <bdash@webkit.org>
3452
3453         Reviewed by Maciej.
3454
3455         Fix crash on launch in nightly builds after r16965.
3456
3457         Safari will sometimes call through to -[NSURL _webkit_canonicalize] before creating a WebView.  If this happens,
3458         InitWebCoreSystemInterface has not yet been called so the call to wkNSURLProtocolClassForReqest is via a garbage
3459         pointer.
3460
3461         * Misc/WebNSURLExtras.m:
3462         (-[NSURL _webkit_canonicalize]): Ensure InitWebCoreSystemInterface is called prior to canonicalURL.
3463
3464 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
3465
3466         Reviewed by Oliver.
3467         
3468         - split out some NSURL extras to be moved to WebCore
3469
3470         * Loader/LoaderNSURLExtras.h: Added.
3471         * Loader/LoaderNSURLExtras.m: Added.
3472         (urlByRemovingComponent):
3473         (urlByRemovingFragment):
3474         (urlOriginalDataAsString):
3475         (urlOriginalData):
3476         (urlWithData):
3477         (WebCFAutorelease):
3478         (urlWithDataRelativeToURL):
3479         (urlByRemovingResourceSpecifier):
3480         (urlIsFileURL):
3481         (stringIsFileURL):
3482         (urlIsEmpty):
3483         (canonicalURL):
3484         * Loader/WebFrameLoader.m:
3485         (-[WebFrameLoader shouldReloadForCurrent:andDestination:]):
3486         (setHTTPReferrer):
3487         (-[WebFrameLoader commitProvisionalLoad:]):
3488         (-[WebFrameLoader _notifyIconChanged:]):
3489         (-[WebFrameLoader didChangeTitleForDocument:]):
3490         (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]):
3491         (-[WebFrameLoader safeLoadURL:]):
3492         * Misc/WebNSURLExtras.m:
3493         (+[NSURL _web_URLWithData:]):
3494         (+[NSURL _web_URLWithData:relativeToURL:]):
3495         (-[NSURL _web_originalData]):
3496         (-[NSURL _web_originalDataAsString]):
3497         (-[NSURL _web_isEmpty]):
3498         (-[NSURL _webkit_canonicalize]):
3499         (-[NSURL _webkit_URLByRemovingComponent:]):
3500         (-[NSURL _webkit_URLByRemovingFragment]):
3501         (-[NSURL _webkit_URLByRemovingResourceSpecifier]):
3502         (-[NSURL _webkit_isFileURL]):
3503         (-[NSString _webkit_isFileURL]):
3504         * WebCoreSupport/WebSystemInterface.m:
3505         (InitWebCoreSystemInterface):
3506         * WebKit.xcodeproj/project.pbxproj:
3507
3508 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
3509
3510         Reviewed by Anders.
3511         
3512         - sever final WebFrame dependencies
3513
3514         * Loader/WebFrameLoader.h:
3515         * Loader/WebFrameLoader.m:
3516         (-[WebFrameLoader initWithFrame:client:]):
3517         (-[WebFrameLoader defersCallbacksChanged]):
3518         (-[WebFrameLoader subframeIsLoading]):
3519         (-[WebFrameLoader transitionToCommitted:]):
3520         (-[WebFrameLoader detachChildren]):
3521         (-[WebFrameLoader checkLoadComplete]):
3522
3523 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
3524
3525         Reviewed by Brady.
3526         
3527         - convert more WebFrameLoader stuff to be independent of WebFrame
3528
3529         * Loader/WebFrameLoader.h:
3530         * Loader/WebFrameLoader.m:
3531         (-[WebFrameLoader stopLoadingSubframes]):
3532         (-[WebFrameLoader _receivedMainResourceError:complete:]):
3533         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
3534         (-[WebFrameLoader closeOldDataSources]):
3535         (-[WebFrameLoader isHostedByObjectElement]):
3536         (-[WebFrameLoader isLoadingMainFrame]):
3537         (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
3538         (-[WebFrameLoader transitionToCommitted:]):
3539         (-[WebFrameLoader checkLoadCompleteForThisFrame]):
3540         (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
3541         (-[WebFrameLoader loadRequest:inFrameNamed:]):
3542         (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
3543         (-[WebFrameLoader actionInformationForNavigationType:event:originalURL:]):
3544         (-[WebFrameLoader client]):
3545         * Loader/WebFrameLoaderClient.h:
3546         * WebView/WebDataSource.m:
3547         (-[WebDataSource _webView]):
3548         (-[WebDataSource webFrame]):
3549         * WebView/WebFrame.m:
3550         (-[WebFrame _dispatchCreateWebViewWithRequest:]):
3551
3552 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
3553
3554         Reviewed by Anders and Oliver.
3555         
3556         - move a bunch of WebFrame methods from the Internal category to the WebFrameLoader protocol
3557
3558         * Loader/WebFrameLoader.h:
3559         * Loader/WebFrameLoader.m:
3560         (-[WebFrameLoader loadRequest:]):
3561         (-[WebFrameLoader loadRequest:inFrameNamed:]):
3562         * Loader/WebFrameLoaderClient.h:
3563         * WebView/WebFrame.m:
3564         (-[WebFrame loadRequest:]):
3565         (-[WebFrame _dispatchDidCommitLoadForFrame]):
3566         (-[WebFrame _hasFrameView]):
3567         (-[WebFrame _frameLoadCompleted]):
3568         (-[WebFrame _restoreScrollPositionAndViewState]):
3569         (-[WebFrame _setTitle:forURL:]):
3570         (-[WebFrame _createDocumentLoaderWithRequest:]):
3571         (-[WebFrame _prepareForDataSourceReplacement]):
3572         (-[WebFrame _didFinishLoad]):
3573         (-[WebFrame _addHistoryItemForFragmentScroll]):
3574         (-[WebFrame _shouldTreatURLAsSameAsCurrent:]):
3575         (-[WebFrame _provisionalLoadStarted]):
3576         * WebView/WebFrameInternal.h:
3577
3578 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
3579
3580         Not reviewed, build fix.
3581         
3582         - added forgotten files
3583
3584         * Loader/WebPolicyDecider.h: Added.
3585         * Loader/WebPolicyDecider.m: Added.
3586         (-[WebPolicyDecider invalidate]):
3587
3588 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
3589
3590         Reviewed by Brady.
3591         
3592         - add wrapper for WebPolicyDecisionListener so we can remove the dependency from WebFrameLoader.
3593
3594         * Loader/WebFrameLoader.h:
3595         * Loader/WebFrameLoader.m:
3596         (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]):
3597         (-[WebFrameLoader cancelContentPolicy]):
3598         (-[WebFrameLoader invalidatePendingPolicyDecisionCallingDefaultAction:]):
3599         (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]):
3600         (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]):
3601         (-[WebFrameLoader continueAfterWillSubmitForm:]):
3602         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
3603         * Loader/WebFrameLoaderClient.h:
3604         * WebKit.xcodeproj/project.pbxproj:
3605         * WebView/WebFrame.m:
3606         (-[WebFrame _createPolicyDeciderWithTarget:action:]):
3607         (decisionListener):