2f7e0deb8301d29b2bf89dde2d1b0ddcfccac810
[WebKit-https.git] / WebKit / ChangeLog
1 2006-10-31  Mark Rowe  <bdash@webkit.org>
2
3         Reviewed by Maciej.
4
5         Fix null pointer dereference while running editing/pasteboard/drag-drop-modifies-page.html
6
7         * Misc/WebElementDictionary.m:
8         (-[WebElementDictionary _image]): Add null check.
9
10 2006-10-31  Beth Dakin  <bdakin@apple.com>
11
12         Reviewed by Maciej.
13
14         This creates local functions for the remaining WebElementDictionary 
15         members that calls into HitTestResult instead of doing magical 
16         things with the Objective-C DOM classes.
17
18         * ChangeLog:
19         * Misc/WebElementDictionary.m:
20         (addLookupKey): The values of the dictionary are now just 
21         selectors. They used to be WebElementMethods which were 
22         WebElementTargetObjects associated with selectors, but none of that 
23         is needed any more.
24         (+[WebElementDictionary initializeLookupTable]): All selectors are 
25         now local functions, no more WebElementTargetObjects.
26         (-[WebElementDictionary objectForKey:]): No more target objects!
27         (-[WebElementDictionary _domNode]): Call into HitTestResult member 
28         variable.
29         (-[WebElementDictionary _altDisplayString]): Same.
30         (-[WebElementDictionary _image]): Same.
31         (-[WebElementDictionary _absoluteImageURL]): Same.
32         (-[WebElementDictionary _title]): Same.
33         (-[WebElementDictionary _absoluteLinkURL]): Same.
34         (-[WebElementDictionary _targetWebFrame]): Same.
35         (-[WebElementDictionary _titleDisplayString]): Same.
36         (-[WebElementDictionary _textContent]): Same.
37
38 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
39
40         Reviewed by Alice.
41         
42         Moved some Editing code from WebKit, the bridge, and WebCore::Frame down 
43         to WebCore::Editor.
44
45         * WebCoreSupport/WebFrameBridge.mm:
46         * WebView/WebHTMLView.m:
47         (-[WebHTMLView _shouldDeleteRange:]):
48         (-[WebHTMLView _canCopy]):
49         (-[WebHTMLView _canCut]):
50         (-[WebHTMLView _canDelete]):
51         (-[WebHTMLView _canPaste]):
52         (-[WebHTMLView _canEdit]):
53         (-[WebHTMLView _canEditRichly]):
54         (-[WebHTMLView _isEditable]):
55         (-[WebHTMLView _isSelectionInPasswordField]):
56         (-[NSArray validateUserInterfaceItem:]):
57         (-[NSArray _expandSelectionToGranularity:]):
58
59 2006-10-31  John Sullivan  <sullivan@apple.com>
60
61         Reviewed by Beth and Adam
62         
63         Display a tooltip when hovering over marked bad grammar.
64
65         * Misc/WebElementDictionary.m:
66         (+[WebElementDictionary initializeLookupTable]):
67         support spelling tool tip
68         (-[WebElementDictionary _spellingToolTip]):
69         new method, calls through to HitTestResult
70         
71         * WebView/WebHTMLView.m:
72         (-[WebHTMLView _updateMouseoverWithEvent:]):
73         Check for a spelling tool tip; if found, prefer it over the other possible tool tips.
74         Check for empty strings instead of just nil strings being, since values from 
75         WebElementDictionary are empty strings.
76         
77         * WebView/WebViewPrivate.h:
78         declare new string constant WebElementSpellingToolTipKey
79         * WebView/WebView.mm:
80         define new string constant WebElementSpellingToolTipKey
81         
82 2006-10-31  Beth Dakin  <bdakin@apple.com>
83
84         Reviewed by Maciej.
85
86         Small tweaks to WebKit because of http://bugs.webkit.org/
87         show_bug.cgi?id=11461 HitTestResult should be split into 
88         HitTestRequest and HitTestResult
89
90         * WebKit.xcodeproj/project.pbxproj:
91         * WebView/WebHTMLView.m:
92         (-[WebHTMLView elementAtPoint:allowShadowContent:]): The 
93         HitTestResult initializer now just takes a point.
94
95 2006-10-31  Darin Adler  <darin@apple.com>
96
97         Reviewed by Brady.
98
99         - got "action dictionary" code out of FrameLoader,
100           replacing with a class called NavigationAction
101
102         * WebCoreSupport/WebFrameLoaderClient.h: Changed parameter types to NavigationAction.
103         Made elementForEvent non-virtual. Added actionDictionary function.
104         * WebCoreSupport/WebFrameLoaderClient.mm:
105         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Changed parameter type,
106         and used actionDictionary to make the action dictionary.
107         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Ditto.
108         (WebFrameLoaderClient::actionDictionary): Added. Code that was originally in WebCore
109         that creates the action dictionary (from a NavigationAction).
110
111         * WebView/WebFrame.mm: (-[WebFrame _loadItem:withLoadType:]): Use NavigationAction
112         instead of a dictionary for the action parameters.
113
114 2006-10-31  Marvin Decker  <marv.decker@gmail.com>
115
116         Reviewed by Maciej.
117         
118         - fixed "Stop and reload don't work on the WebView"
119         http://bugs.webkit.org/show_bug.cgi?id=11285
120
121         * COM/WebFrame.cpp:
122         (WebFrame::stopLoading): Implement.
123         * COM/WebView.cpp:
124         (WebView::stopLoading): ditto
125         (WebView::reload): ditto
126
127 2006-10-30  Darin Adler  <darin@apple.com>
128
129         * Plugins/WebBaseNetscapePluginView.mm:
130         (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
131         Fix comment.
132
133 2006-10-30  John Sullivan  <sullivan@apple.com>
134
135         Reviewed by Geoff Garen
136
137         * WebView/WebHTMLView.m:
138         (-[NSArray checkSpelling:]):
139         removed code to update spelling panel; WebCore handles that now
140         (-[NSArray showGuessPanel:]):
141         ditto
142
143 2006-10-30  John Sullivan  <sullivan@apple.com>
144
145         * English.lproj/WebViewEditingContextMenu.nib/info.nib:
146         * English.lproj/WebViewEditingContextMenu.nib/objects.nib:
147         Another wording change to match framework, post-Tiger:
148         "Check Spelling" -> "Check Document Now"
149
150 2006-10-30  John Sullivan  <sullivan@apple.com>
151
152         Reviewed by Geoff Garen.
153         
154         Moved spelling-related methods from bridge to EditorClient. Added one not-yet-used
155         grammar-related method.
156
157         * WebCoreSupport/WebEditorClient.h:
158         declare overrides of isContinuousSpellCheckingEnabled(), spellCheckerDocumentTag(), and new
159         isGrammarCheckingEnabled()
160         * WebCoreSupport/WebEditorClient.mm:
161         (WebEditorClient::isContinuousSpellCheckingEnabled):
162         implement by calling through to WebView
163         (WebEditorClient::isGrammarCheckingEnabled):
164         ditto
165         (WebEditorClient::spellCheckerDocumentTag):
166         ditto
167         
168         * WebCoreSupport/WebFrameBridge.mm:
169         removed bridge equivalents of these methods
170
171 2006-10-30  Geoffrey Garen  <ggaren@apple.com>
172
173         Reviewed by Beth.
174         
175         Fixed nil-deref crash that I saw while using TOT (not sure how to repro,
176         but the debugger confirmed the cause).
177
178         * WebView/WebFrame.mm:
179         (core): Added check for NULL bridge.
180
181 2006-10-30  Geoffrey Garen  <ggaren@apple.com>
182
183         Reviewed by Darin.
184
185         Removed a number of editing and selection methods from the bridge.
186         
187         I moved cross-platform editing and selection code into WebCore::Editor and 
188         WebCore::SelectionController, respecitvely.
189         
190         All of the seemingly new code here is just code grabbed from WebCore or
191         merged from WebCoreFrameBridge.
192         
193         I changed one piece of internal API: we now pass around Ranges in places
194         where we used to pass around broken out components of Ranges.
195         
196         I also added WebCore XPATH_SUPPORT AND SVG_SUPPORT #defines to the project.
197         Since we now include WebCore headers that depend on these #defines, we need
198         to keep in sync with them, to avoid binary incompatibility.
199
200 2006-10-30  Darin Adler  <darin@apple.com>
201
202         Reviewed by John Sullivan.
203
204         - work toward removing Objective-C data types from FrameLoader.h:
205           removed NSDate, NSString, WebCorePageState, WebCoreResourceLoader,
206           and WebCoreResourceHandle
207         - moved bodyBackgroundColor function here from Frame
208
209         * History/WebHistoryItem.m: (+[WebHistoryItem _closeObjectsInPendingPageCaches]):
210         Updated for change in WebCorePageState.
211
212         * WebCoreSupport/WebFrameBridge.mm: Removed saveDocumentToPageCache method.
213
214         * WebCoreSupport/WebFrameLoaderClient.h: Changed NSDate to double.
215         * WebCoreSupport/WebFrameLoaderClient.mm:
216         (WebFrameLoaderClient::invalidateCurrentItemPageCache): Moved the code that was
217         formerly in invalidatePageCache: on the bridge here.
218         (WebFrameLoaderClient::dispatchWillPerformClientRedirect): Added code to make the
219         NSDate here.
220         (WebFrameLoaderClient::createPageCache): Restructured code to create the
221         WebCorePageState object directly instead of calling saveDocumentToPageCache on
222         the bridge.
223
224         * WebView/WebFrame.mm: (-[WebFrame _bodyBackgroundColor]): Rewrote this to work
225         directly with the DOM and renderers rather than using a function on Frame.
226
227 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
228
229         Reviewed by Anders.
230
231         - added ResourceResponse class and didReceiveResponse delegate call
232
233         * WebCoreSupport/WebFrameBridge.mm: Removed no longer needed
234         expiresTimeForResponse: method.
235
236 2006-10-29  Darin Adler  <darin@apple.com>
237
238         - update for the WebCore rename
239
240         * WebCoreSupport/WebFrameLoaderClient.mm:
241         * WebView/WebFrame.mm:
242
243 2006-10-29  Darin Adler  <darin@apple.com>
244
245         - update for the WebCore renames
246
247         * Plugins/WebNetscapePluginStream.mm:
248         * Plugins/WebPluginController.mm:
249         * WebCoreSupport/WebFrameBridge.mm:
250         * WebCoreSupport/WebFrameLoaderClient.h:
251         * WebCoreSupport/WebFrameLoaderClient.mm:
252         (WebFrameLoaderClient::willUseArchive):
253         (WebFrameLoaderClient::isArchiveLoadPending):
254         (WebFrameLoaderClient::cancelPendingArchiveLoad):
255         (WebFrameLoaderClient::deliverArchivedResources):
256         * WebCoreSupport/WebPageBridge.mm:
257         (-[WebPageBridge canRunModalNow]):
258         * WebView/WebDocumentLoaderMac.h:
259         * WebView/WebFrame.mm:
260         * WebView/WebHTMLRepresentation.m:
261         * WebView/WebView.mm:
262
263 2006-10-29  Darin Adler  <darin@apple.com>
264
265         Rubber stamped by Adam Roben.
266
267         - renamed WebCore's WebFrameLoaderClient to match the class name inside it
268
269         * WebCoreSupport/WebFrameBridge.mm: Update include.
270         * WebCoreSupport/WebFrameLoaderClient.h: Ditto.
271
272 2006-10-29  Darin Adler  <darin@apple.com>
273
274         Reviewed by Maciej.
275
276         - eliminate use of NSArray to carry form data around
277           (the code in this framework was actually using the NSArray to hold a single
278            NSData anyway, so I just went back to an NSData for now)
279
280         - also fixed http://bugs.webkit.org/show_bug.cgi?id=11444
281           REGRESSION (r17378): Exception (-[NSCFDictionary setObject:forKey:]:
282           attempt to insert nil value) when submitting a form with an empty
283           uninitialized field
284
285         * History/WebHistoryItem.m:
286         (-[WebHistoryItem _setFormInfoFromRequest:]):
287         (-[WebHistoryItem formData]):
288         * History/WebHistoryItemPrivate.h:
289         * WebCoreSupport/WebFrameLoaderClient.mm:
290         (WebFrameLoaderClient::dispatchWillSubmitForm):
291         * WebView/WebFrame.mm:
292         (-[WebFrame _loadItem:withLoadType:]):
293
294 2006-10-28  Darin Adler  <darin@apple.com>
295
296         Reviewed by Maciej.
297
298         - eliminated the use of Objective-C for the policy decider
299           machinery, obviating the need for WebPolicyDeciderMac
300
301         - moved the defersLoading flag from WebView to WebCore::Page
302
303         - removed unused copies of four methods that in the frame bridge;
304           the actually-used copies are in the page bridge
305
306         - updated for rename of PassRefPtr::release to releaseRef
307
308         * WebView/WebPolicyDeciderMac.h: Removed.
309         * WebView/WebPolicyDeciderMac.m: Removed.
310         * WebKit.xcodeproj/project.pbxproj: Updated for removal.
311
312         * Plugins/WebBaseNetscapePluginView.mm:
313         (-[WebBaseNetscapePluginView sendEvent:]):
314         * Plugins/WebNetscapePluginStream.mm:
315         * WebCoreSupport/WebFrameBridge.mm:
316         * WebCoreSupport/WebFrameLoaderClient.h:
317         * WebCoreSupport/WebFrameLoaderClient.mm:
318         (getWebView):
319         (WebFrameLoaderClient::WebFrameLoaderClient):
320         (WebFrameLoaderClient::willCloseDocument):
321         (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
322         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
323         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
324         (WebFrameLoaderClient::cancelPolicyCheck):
325         (WebFrameLoaderClient::dispatchWillSubmitForm):
326         (WebFrameLoaderClient::setDefersLoading):
327         (WebFrameLoaderClient::setTitle):
328         (WebFrameLoaderClient::deliverArchivedResourcesAfterDelay):
329         (WebFrameLoaderClient::deliverArchivedResources):
330         (WebFrameLoaderClient::setUpPolicyListener):
331         (WebFrameLoaderClient::receivedPolicyDecison):
332         (WebFrameLoaderClient::userAgent):
333         (-[WebFramePolicyListener initWithWebCoreFrame:]):
334         (-[WebFramePolicyListener invalidate]):
335         (-[WebFramePolicyListener dealloc]):
336         (-[WebFramePolicyListener finalize]):
337         (-[WebFramePolicyListener receivedPolicyDecision:]):
338         (-[WebFramePolicyListener ignore]):
339         (-[WebFramePolicyListener download]):
340         (-[WebFramePolicyListener use]):
341         (-[WebFramePolicyListener continue]):
342         * WebCoreSupport/WebPageBridge.mm:
343         (-[WebPageBridge runModal]):
344         * WebView/WebArchiver.m:
345         (+[WebArchiver archiveSelectionInFrame:]):
346         * WebView/WebFormDelegate.h:
347         * WebView/WebFormDelegate.m:
348         (+[WebFormDelegate _sharedWebFormDelegate]):
349         (-[WebFormDelegate textFieldDidBeginEditing:inFrame:]):
350         (-[WebFormDelegate textFieldDidEndEditing:inFrame:]):
351         (-[WebFormDelegate textDidChangeInTextField:inFrame:]):
352         (-[WebFormDelegate textDidChangeInTextArea:inFrame:]):
353         (-[WebFormDelegate frame:sourceFrame:willSubmitForm:withValues:submissionListener:]):
354         * WebView/WebFrame.mm:
355         (-[WebFrame _loadURL:referrer:intoChild:]):
356         (-[WebFrame _isFrameSet]):
357         * WebView/WebFrameInternal.h:
358         * WebView/WebFrameView.mm:
359         (-[WebFrameView _shouldDrawBorder]):
360         * WebView/WebHTMLView.m:
361         (-[NSArray knowsPageRange:]):
362         * WebView/WebView.mm:
363         (-[WebView _formDelegate]):
364         * WebView/WebViewInternal.h:
365         * WebView/WebViewPrivate.h:
366
367 2006-10-28  Adam Roben  <aroben@apple.com>
368
369         Reviewed by Maciej.
370
371         Fix layout tests that broke after r17399. Mitz discovered that the
372         failures were caused by HitTestResult::m_point being uninitialized
373         much of the time. HitTestResults are now always constructed with a
374         point.
375
376         * WebView/WebHTMLView.m:
377         (-[WebHTMLView elementAtPoint:allowShadowContent:]): Pass point to
378         HitTestResult constructor.
379
380 2006-10-28  Beth Dakin  <bdakin@apple.com>
381
382         Reviewed by Darin.
383
384         This is the WebKit half of pushing the guts of elementAtPoint and 
385         WebElementDictionary into WebCore. Among other things, this patch 
386         makes WebElementDictionary.m and WebHTMLView.m Objective-C++
387
388         * MigrateHeaders.make: Add DOMElementInternal.h to the list of 
389         headers to migrate.
390         * Misc/WebElementDictionary.h: Replaced DOMNode, DOMElement, and 
391         NSPoint member variables with a HitTestResult member variable.
392         * Misc/WebElementDictionary.m:
393         (addLookupKey): Formatting.
394         (-[WebElementDictionary initWithHitTestResult:]): Constructor just 
395         takes a HitTestResult now and sets the member variable.
396         (-[WebElementDictionary dealloc]): delete HitTestResult.
397         (-[WebElementDictionary finalize]): Address HitTestResult.
398         (-[WebElementDictionary _domNode]): Use HitTestResult and call into 
399         WebCore.
400         (-[WebElementDictionary objectForKey:]): Same.
401         (-[WebElementDictionary _webFrame]): Same.
402         (-[WebElementDictionary _targetWebFrame]): Same.
403         (-[WebElementDictionary _title]): Same.
404         (-[WebElementDictionary _imageRect]): Same.
405         (-[WebElementDictionary _isSelected]): Same.
406         * WebKit.xcodeproj/project.pbxproj:
407         * WebView/WebFrame.mm:
408         (core): Convert from DOMNode* to Node*
409         (kit): Convert from Node* to DOMNode*
410         * WebView/WebFrameInternal.h: Support for the above.
411         * WebView/WebHTMLView.m:
412         (-[WebHTMLView elementAtPoint:allowShadowContent:]): Call directly 
413         into Frame.cpp to get HitTestResult.
414
415 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
416
417         Reviewed by John & Adam.
418         
419         - various performance improvements for resource delegate dispatch.
420         
421         - avoid any ObjC messaging when fetching the WebView
422         - avoid ObjC calls to WebView to get resource load delegate and impl cache
423         - cache actual method pointers, not just the fact that the method is present
424         - added a new SPI resource load delegate method which allows clients to get
425           just one message in case of synchronously loading from memory cache; if this
426           is implemented you don't get the normal delegate calls in that case.
427         - various other minor tweaks
428
429         * WebCoreSupport/WebFrameBridge.h:
430         * WebCoreSupport/WebFrameLoaderClient.h:
431         * WebCoreSupport/WebFrameLoaderClient.mm:
432         (getWebView):
433         (WebFrameLoaderClient::hasBackForwardList):
434         (WebFrameLoaderClient::resetBackForwardList):
435         (WebFrameLoaderClient::privateBrowsingEnabled):
436         (WebFrameLoaderClient::updateHistoryForStandardLoad):
437         (WebFrameLoaderClient::resetAfterLoadError):
438         (WebFrameLoaderClient::download):
439         (WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
440         (WebFrameLoaderClient::dispatchIdentifierForInitialRequest):
441         (WebFrameLoaderClient::dispatchWillSendRequest):
442         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
443         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
444         (WebFrameLoaderClient::dispatchDidReceiveResponse):
445         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
446         (WebFrameLoaderClient::dispatchDidFinishLoading):
447         (WebFrameLoaderClient::dispatchDidFailLoading):
448         (WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
449         (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
450         (WebFrameLoaderClient::dispatchDidCancelClientRedirect):
451         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
452         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
453         (WebFrameLoaderClient::dispatchWillClose):
454         (WebFrameLoaderClient::dispatchDidReceiveIcon):
455         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
456         (WebFrameLoaderClient::dispatchDidReceiveTitle):
457         (WebFrameLoaderClient::dispatchDidCommitLoad):
458         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
459         (WebFrameLoaderClient::dispatchDidFailLoad):
460         (WebFrameLoaderClient::dispatchDidFinishLoad):
461         (WebFrameLoaderClient::dispatchDidFirstLayout):
462         (WebFrameLoaderClient::dispatchCreatePage):
463         (WebFrameLoaderClient::dispatchShow):
464         (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
465         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
466         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
467         (WebFrameLoaderClient::dispatchUnableToImplementPolicy):
468         (WebFrameLoaderClient::dispatchWillSubmitForm):
469         (WebFrameLoaderClient::dispatchDidLoadMainResource):
470         (WebFrameLoaderClient::progressStarted):
471         (WebFrameLoaderClient::progressCompleted):
472         (WebFrameLoaderClient::incrementProgress):
473         (WebFrameLoaderClient::completeProgress):
474         (WebFrameLoaderClient::setMainFrameDocumentReady):
475         (WebFrameLoaderClient::startDownload):
476         (WebFrameLoaderClient::willChangeTitle):
477         (WebFrameLoaderClient::didChangeTitle):
478         (WebFrameLoaderClient::mainFrameURL):
479         (WebFrameLoaderClient::frameLoadCompleted):
480         * WebCoreSupport/WebPageBridge.h:
481         * WebKit.xcodeproj/project.pbxproj:
482         * WebView/WebFrame.mm:
483         (frame):
484         (core):
485         (kit):
486         (getWebView):
487         (-[WebFrame _addBackForwardItemClippedAtTarget:]):
488         (-[WebFrame _canCachePage]):
489         (-[WebFrame _purgePageCache]):
490         (-[WebFrame _loadItem:withLoadType:]):
491         (-[WebFrame _goToItem:withLoadType:]):
492         (-[WebFrame _updateBackground]):
493         (-[WebFrame _clearSelectionInOtherFrames]):
494         (-[WebFrame _isMainFrame]):
495         (-[WebFrame webView]):
496         * WebView/WebResourceLoadDelegatePrivate.h: Added.
497         * WebView/WebView.mm:
498         (-[WebView _cacheResourceLoadDelegateImplementations]):
499         (WebViewGetResourceLoadDelegate):
500         (WebViewGetResourceLoadDelegateImplementations):
501         * WebView/WebViewInternal.h:
502         * WebView/WebViewPrivate.h:
503
504 2006-10-27  Geoffrey Garen  <ggaren@apple.com>
505
506         Reviewed by Maciej.
507         
508         Moved some WebCoreFrameBridge functions into FrameLoader.
509
510         * WebView/WebFrame.mm:
511         (-[WebFrame _numPendingOrLoadingRequests:]):
512
513 2006-10-27  Timothy Hatcher  <timothy@apple.com>
514
515         Reviewed by Beth.
516
517         Make a DerivedSource/Webkit directory to store migrated
518         internal headers from WebCore.
519
520         * MigrateHeaders.make:
521         * WebKit.xcodeproj/project.pbxproj:
522         * WebView/WebFrame.mm: import the new migrated DOM*Internal.h headers
523
524 2006-10-27  John Sullivan  <sullivan@apple.com>
525
526         Reviewed by Anders
527         
528         - fixed http://bugs.webkit.org/show_bug.cgi?id=11439 
529           REGRESSION: Another page loading crash
530
531         * WebView/WebFrame.mm:
532         (-[WebFrame _createItem:]):
533         Handle nil documentLoader the way we did before ObjC->C++ changes
534
535 2006-10-27  John Sullivan  <sullivan@apple.com>
536
537         Reviewed by Anders
538
539         * WebView/WebHTMLView.m:
540         (-[NSArray checkSpelling:]):
541         call advanceToNextMisspelling directly on FrameMac, bypassing bridge
542         (-[NSArray showGuessPanel:]):
543         ditto
544
545 2006-10-27  Darin Adler  <darin@apple.com>
546
547         - build fix
548
549         * WebCoreSupport/WebFrameLoaderClient.mm: Corrected header file name.
550
551 2006-10-27  Darin Adler  <darin@apple.com>
552
553         Reviewed by Maciej.
554
555         - moved methods that are there just to be called by the frame loader client into the client
556           in an attempt to get back some of the speed we lost yesterday
557
558         * DefaultDelegates/WebDefaultResourceLoadDelegate.m:
559         (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
560         (-[WebDefaultResourceLoadDelegate webView:resource:didCancelAuthenticationChallenge:fromDataSource:]):
561         * WebCoreSupport/WebFrameLoaderClient.h:
562         * WebCoreSupport/WebFrameLoaderClient.mm:
563         (dataSource):
564         (decisionListener):
565         (WebFrameLoaderClient::WebFrameLoaderClient):
566         (WebFrameLoaderClient::hasWebView):
567         (WebFrameLoaderClient::hasFrameView):
568         (WebFrameLoaderClient::hasBackForwardList):
569         (WebFrameLoaderClient::resetBackForwardList):
570         (WebFrameLoaderClient::provisionalItemIsTarget):
571         (WebFrameLoaderClient::loadProvisionalItemFromPageCache):
572         (WebFrameLoaderClient::invalidateCurrentItemPageCache):
573         (WebFrameLoaderClient::privateBrowsingEnabled):
574         (WebFrameLoaderClient::makeDocumentView):
575         (WebFrameLoaderClient::makeRepresentation):
576         (WebFrameLoaderClient::setDocumentViewFromPageCache):
577         (WebFrameLoaderClient::forceLayout):
578         (WebFrameLoaderClient::forceLayoutForNonHTML):
579         (WebFrameLoaderClient::updateHistoryForCommit):
580         (WebFrameLoaderClient::updateHistoryForBackForwardNavigation):
581         (WebFrameLoaderClient::updateHistoryForReload):
582         (WebFrameLoaderClient::updateHistoryForStandardLoad):
583         (WebFrameLoaderClient::updateHistoryForInternalLoad):
584         (WebFrameLoaderClient::updateHistoryAfterClientRedirect):
585         (WebFrameLoaderClient::setCopiesOnScroll):
586         (WebFrameLoaderClient::tokenForLoadErrorReset):
587         (WebFrameLoaderClient::resetAfterLoadError):
588         (WebFrameLoaderClient::doNotResetAfterLoadError):
589         (WebFrameLoaderClient::detachedFromParent1):
590         (WebFrameLoaderClient::detachedFromParent2):
591         (WebFrameLoaderClient::detachedFromParent3):
592         (WebFrameLoaderClient::detachedFromParent4):
593         (WebFrameLoaderClient::loadedFromPageCache):
594         (WebFrameLoaderClient::download):
595         (WebFrameLoaderClient::dispatchIdentifierForInitialRequest):
596         (WebFrameLoaderClient::dispatchWillSendRequest):
597         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
598         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
599         (WebFrameLoaderClient::dispatchDidReceiveResponse):
600         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
601         (WebFrameLoaderClient::dispatchDidFinishLoading):
602         (WebFrameLoaderClient::dispatchDidFailLoading):
603         (WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
604         (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
605         (WebFrameLoaderClient::dispatchDidCancelClientRedirect):
606         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
607         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
608         (WebFrameLoaderClient::dispatchWillClose):
609         (WebFrameLoaderClient::dispatchDidReceiveIcon):
610         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
611         (WebFrameLoaderClient::dispatchDidReceiveTitle):
612         (WebFrameLoaderClient::dispatchDidCommitLoad):
613         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
614         (WebFrameLoaderClient::dispatchDidFailLoad):
615         (WebFrameLoaderClient::dispatchDidFinishLoad):
616         (WebFrameLoaderClient::dispatchDidFirstLayout):
617         (WebFrameLoaderClient::dispatchCreatePage):
618         (WebFrameLoaderClient::dispatchShow):
619         (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
620         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
621         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
622         (WebFrameLoaderClient::dispatchUnableToImplementPolicy):
623         (WebFrameLoaderClient::dispatchWillSubmitForm):
624         (WebFrameLoaderClient::dispatchDidLoadMainResource):
625         (WebFrameLoaderClient::clearLoadingFromPageCache):
626         (WebFrameLoaderClient::isLoadingFromPageCache):
627         (WebFrameLoaderClient::revertToProvisionalState):
628         (WebFrameLoaderClient::setMainDocumentError):
629         (WebFrameLoaderClient::clearUnarchivingState):
630         (WebFrameLoaderClient::progressStarted):
631         (WebFrameLoaderClient::progressCompleted):
632         (WebFrameLoaderClient::incrementProgress):
633         (WebFrameLoaderClient::completeProgress):
634         (WebFrameLoaderClient::setMainFrameDocumentReady):
635         (WebFrameLoaderClient::startDownload):
636         (WebFrameLoaderClient::willChangeTitle):
637         (WebFrameLoaderClient::didChangeTitle):
638         (WebFrameLoaderClient::committedLoad):
639         (WebFrameLoaderClient::finishedLoading):
640         (WebFrameLoaderClient::finalSetupForReplace):
641         (WebFrameLoaderClient::cancelledError):
642         (WebFrameLoaderClient::cannotShowURLError):
643         (WebFrameLoaderClient::interruptForPolicyChangeError):
644         (WebFrameLoaderClient::cannotShowMIMETypeError):
645         (WebFrameLoaderClient::fileDoesNotExistError):
646         (WebFrameLoaderClient::shouldFallBack):
647         (WebFrameLoaderClient::mainFrameURL):
648         (WebFrameLoaderClient::setDefersCallbacks):
649         (WebFrameLoaderClient::willUseArchive):
650         (WebFrameLoaderClient::isArchiveLoadPending):
651         (WebFrameLoaderClient::cancelPendingArchiveLoad):
652         (WebFrameLoaderClient::clearArchivedResources):
653         (WebFrameLoaderClient::canHandleRequest):
654         (WebFrameLoaderClient::canShowMIMEType):
655         (WebFrameLoaderClient::representationExistsForURLScheme):
656         (WebFrameLoaderClient::generatedMIMETypeForURLScheme):
657         (WebFrameLoaderClient::elementForEvent):
658         (WebFrameLoaderClient::createPolicyDecider):
659         (WebFrameLoaderClient::frameLoadCompleted):
660         (WebFrameLoaderClient::restoreScrollPositionAndViewState):
661         (WebFrameLoaderClient::provisionalLoadStarted):
662         (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent):
663         (WebFrameLoaderClient::addHistoryItemForFragmentScroll):
664         (WebFrameLoaderClient::didFinishLoad):
665         (WebFrameLoaderClient::prepareForDataSourceReplacement):
666         (WebFrameLoaderClient::createDocumentLoader):
667         (WebFrameLoaderClient::setTitle):
668         (WebFrameLoaderClient::canUseArchivedResource):
669         (WebFrameLoaderClient::deliverArchivedResourcesAfterDelay):
670         (WebFrameLoaderClient::deliverArchivedResources):
671         (WebFrameLoaderClient::createPageCache):
672         * WebView/WebFrame.mm:
673         (-[NSView setWebFrame:]):
674         (-[WebFrame _createItem:]):
675         (-[WebFrame _loadItem:withLoadType:]):
676         (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]):
677         (-[WebFrame _loadURL:referrer:intoChild:]):
678         (-[WebFrame _saveScrollPositionAndViewStateToItem:]):
679         (-[WebFrame _hasSelection]):
680         (-[WebFrame _clearSelection]):
681         (-[WebFrame _setProvisionalItem:]):
682         (-[WebFrame _setPreviousItem:]):
683         (-[WebFrame _setCurrentItem:]):
684         (-[WebFrame loadArchive:]):
685         * WebView/WebFrameInternal.h:
686         * WebView/WebHTMLView.m:
687         (-[WebHTMLView _topHTMLView]):
688         * WebView/WebHTMLViewPrivate.h:
689
690 2006-10-26  Geoffrey Garen  <ggaren@apple.com>
691
692         Reviewed by Darin, Maciej.
693
694         Removed many uses of NSString * from WebCore.
695         
696         Changed a few files to ObjC++ for compatiblity with new WebCore methods
697         taking WebCore::Strings as arguments.
698         
699         Added a static_cast to make the c++ compiler happy.
700
701 2006-10-26  John Sullivan  <sullivan@apple.com>
702
703         Reviewed by Anders
704
705         * WebView/WebFrame.mm:
706         now includes <WebCore/Document.h> and <WebCore/DocumentMarker.h>
707         (-[WebFrame _unmarkAllBadGrammar]):
708         filled in guts
709         (-[WebFrame _unmarkAllMisspellings]):
710         rewrote to call Document directly, bypassing bridge
711
712 2006-10-26  John Sullivan  <sullivan@apple.com>
713
714         * English.lproj/WebViewEditingContextMenu.nib/info.nib:
715         * English.lproj/WebViewEditingContextMenu.nib/objects.nib:
716         
717         Changed "Spelling" to "Spelling and Grammar" in context menu for post-Tiger.
718
719 === Safari-521.29 ===
720
721 2006-10-26  John Sullivan  <sullivan@apple.com>
722
723         No review, just two localized string changes.
724         
725         * WebView/WebHTMLView.m:
726         (-[NSArray validateUserInterfaceItem:]):
727         changed "Show/Hide Spelling" to "Show/Hide Spelling and Grammar" post-Tiger to match framework change
728
729         * English.lproj/Localizable.strings:
730         updated for these changes
731
732 2006-10-25  Darin Adler  <darin@apple.com>
733
734         Reviewed by Anders.
735
736         - removed 55 methods from WebCoreFrameBridge
737         - changed callers to use Frame directly instead
738         - put FrameLoaderTypes.h types into the WebCore namespace
739         - first steps to get FrameLoader.h ready for cross-platform duty
740
741         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
742         (-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
743         * Plugins/WebBaseNetscapePluginView.mm:
744         (-[WebBaseNetscapePluginView requestWithURLCString:]):
745         (-[WebBaseNetscapePluginView loadPluginRequest:]):
746         (-[WebBaseNetscapePluginView getVariable:value:]):
747         * Plugins/WebNetscapePluginEmbeddedView.m:
748         (-[WebNetscapePluginEmbeddedView didStart]):
749         * Plugins/WebNetscapePluginStream.mm:
750         * Plugins/WebPluginContainerCheck.m:
751         (-[WebPluginContainerCheck _continueWithPolicy:]):
752         (-[WebPluginContainerCheck _isForbiddenFileLoad]):
753         * WebCoreSupport/WebEditorClient.mm:
754         (WebEditorClient::shouldDeleteRange):
755         (WebEditorClient::shouldShowDeleteInterface):
756         * WebCoreSupport/WebFrameBridge.mm:
757         (-[WebFrameBridge webView]):
758         (-[WebFrameBridge finishInitializingWithFrameName:view:]):
759         (-[WebFrameBridge createWindowWithURL:]):
760         (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
761         (-[WebFrameBridge windowObjectCleared]):
762         (-[WebFrameBridge createModalDialogWithURL:]):
763         * WebCoreSupport/WebFrameLoaderClient.mm:
764         (WebFrameLoaderClient::dispatchCreatePage):
765         (WebFrameLoaderClient::dispatchWillSubmitForm):
766         * WebKit.xcodeproj/project.pbxproj:
767         * WebView/WebArchiver.m:
768         (+[WebArchiver archiveSelectionInFrame:]):
769         * WebView/WebDataSource.mm:
770         (-[WebDataSource _documentFragmentWithImageResource:]):
771         (-[WebDataSource _imageElementWithImageResource:]):
772         * WebView/WebEditingDelegatePrivate.h:
773         * WebView/WebFrame.mm:
774         (core):
775         (kit):
776         (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]):
777         (-[WebFrame _canCachePage]):
778         (-[WebFrame _childFramesMatchItem:]):
779         (-[WebFrame _URLsMatchItem:]):
780         (-[WebFrame _loadItem:withLoadType:]):
781         (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]):
782         (-[WebFrame _viewWillMoveToHostWindow:]):
783         (-[WebFrame _viewDidMoveToHostWindow]):
784         (-[WebFrame _addChild:]):
785         (-[WebFrame _saveDocumentAndScrollState]):
786         (-[WebFrame _numPendingOrLoadingRequests:]):
787         (-[WebFrame _reloadForPluginChanges]):
788         (-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):
789         (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
790         (-[WebFrame _initWithWebFrameView:webView:coreFrame:]):
791         (-[WebFrame _documentViews]):
792         (-[WebFrame _updateBackground]):
793         (-[WebFrame _unmarkAllMisspellings]):
794         (-[WebFrame _hasSelection]):
795         (-[WebFrame _atMostOneFrameHasSelection]):
796         (-[WebFrame _findFrameWithSelection]):
797         (-[WebFrame _frameLoader]):
798         (-[WebFrame _isDescendantOfFrame:]):
799         (-[WebFrame _setShouldCreateRenderers:]):
800         (-[WebFrame _bodyBackgroundColor]):
801         (-[WebFrame init]):
802         (-[WebFrame initWithName:webFrameView:webView:]):
803         (-[WebFrame dealloc]):
804         (-[WebFrame finalize]):
805         (-[WebFrame name]):
806         (-[WebFrame webView]):
807         (-[WebFrame DOMDocument]):
808         (-[WebFrame frameElement]):
809         (-[WebFrame findFrameNamed:]):
810         (-[WebFrame parentFrame]):
811         (-[WebFrame childFrames]):
812         (-[WebFrame _invalidateCurrentItemPageCache]):
813         (-[WebFrame _dispatchCreateWebViewWithRequest:]):
814         (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]):
815         (-[WebFrame _prepareForDataSourceReplacement]):
816         (-[WebFrame _provisionalLoadStarted]):
817         * WebView/WebFrameInternal.h:
818         * WebView/WebHTMLRepresentation.m:
819         (-[WebHTMLRepresentation DOMDocument]):
820         (-[WebHTMLRepresentation attributedText]):
821         * WebView/WebHTMLView.m:
822         (-[WebHTMLView _documentRange]):
823         (-[WebHTMLView _documentFragmentWithPaths:]):
824         (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]):
825         (-[WebHTMLView _selectedRange]):
826         (-[WebHTMLView _updateMouseoverWithEvent:]):
827         (-[WebHTMLView _canEditRichly]):
828         (-[WebHTMLView _hasSelection]):
829         (-[WebHTMLView _hasSelectionOrInsertionPoint]):
830         (-[WebHTMLView _hasInsertionPoint]):
831         (-[WebHTMLView _isEditable]):
832         (-[WebHTMLView _isSelectionInPasswordField]):
833         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
834         (-[WebHTMLView _selectionDraggingImage]):
835         (-[WebHTMLView _canIncreaseSelectionListLevel]):
836         (-[WebHTMLView _canDecreaseSelectionListLevel]):
837         (-[WebHTMLView _updateActiveState]):
838         (-[NSArray readSelectionFromPasteboard:]):
839         (-[NSArray validateUserInterfaceItem:]):
840         (-[NSArray maintainsInactiveSelection]):
841         (-[NSArray menuForEvent:]):
842         (-[NSArray scrollWheel:]):
843         (-[NSArray acceptsFirstMouse:]):
844         (-[NSArray shouldDelayWindowOrderingForEvent:]):
845         (-[NSArray mouseDown:]):
846         (-[NSArray mouseDragged:]):
847         (-[NSArray mouseUp:]):
848         (-[NSArray keyDown:]):
849         (-[NSArray keyUp:]):
850         (-[NSArray centerSelectionInVisibleArea:]):
851         (-[NSArray _selectionStartFontAttributesAsRTF]):
852         (-[NSArray _emptyStyle]):
853         (-[NSArray performKeyEquivalent:]):
854         (-[NSArray indent:]):
855         (-[NSArray outdent:]):
856         (-[WebHTMLView cut:]):
857         (-[WebHTMLView paste:]):
858         (-[WebHTMLView _selectRangeInMarkedText:]):
859         (-[WebTextCompleteController doCompletion]):
860         (-[WebHTMLView selectionRect]):
861         (-[WebHTMLView selectionImageForcingWhiteText:]):
862         (-[WebHTMLView selectionImageRect]):
863         (-[WebHTMLView attributedString]):
864         (-[WebHTMLView _isMoveDrag]):
865         (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
866         * WebView/WebPolicyDelegate.mm:
867         (-[WebPolicyDecisionListener _usePolicy:]):
868         (-[WebPolicyDecisionListener use]):
869         (-[WebPolicyDecisionListener ignore]):
870         (-[WebPolicyDecisionListener download]):
871         (-[WebPolicyDecisionListener continue]):
872         * WebView/WebScriptDebugDelegate.m:
873         (-[WebScriptCallFrame _initWithFrame:initWithWebFrame:]):
874         (-[WebScriptCallFrame globalObject]):
875         * WebView/WebView.mm:
876         (-[WebView _attachScriptDebuggerToAllFrames]):
877         (-[WebView _detachScriptDebuggerFromAllFrames]):
878         (-[WebView windowScriptObject]):
879         (incrementFrame):
880         (-[WebView searchFor:direction:caseSensitive:wrap:]):
881         (-[WebView writeSelectionWithPasteboardTypes:toPasteboard:]):
882         (-[WebView removeDragCaret]):
883         (-[WebView setScriptDebugDelegate:]):
884         (-[WebView scriptDebugDelegate]):
885         (-[WebView shouldClose]):
886         (-[WebView selectedDOMRange]):
887         (-[WebView styleDeclarationWithText:]):
888
889 2006-10-25  Geoffrey Garen  <ggaren@apple.com>
890
891         Reviewed by Adam.
892
893         Renamed WebFrameLoader to FrameLoader, to match class name.
894
895         * Plugins/WebBaseNetscapePluginView.mm:
896         * Plugins/WebNetscapePluginStream.mm:
897         * Plugins/WebPluginController.mm:
898         * WebCoreSupport/WebFrameBridge.mm:
899         * WebView/WebDataSource.mm:
900         * WebView/WebFrame.mm:
901         * WebView/WebPDFView.mm:
902         * WebView/WebPolicyDelegate.mm:
903         * WebView/WebView.mm:
904
905 2006-10-25  Mark Rowe  <bdash@webkit.org>
906
907         Reviewed by Anders.
908
909         Build fix for the Buildbot.
910
911         * WebView/WebHTMLView.m:
912         (-[NSArray _addToStyle:fontA:fontB:]): Explicit cast.
913
914 2006-10-25  Maciej Stachowiak  <mjs@apple.com>
915
916         Reviewed by Anders.
917         
918         <rdar://problem/4785575> REGRESSION: form resubmission warning occurs twice, then Safari crashes in autorelease pool
919         <rdar://problem/4799383> REGRESSION: Crash occurs when dismissing the "Would you like to save this password" sheet
920
921         * WebView/WebPolicyDeciderMac.m:
922         (-[WebPolicyDeciderMac dealloc]): release the listener, don't dealloc it
923
924 2006-10-24  Anders Carlsson  <acarlsson@apple.com>
925
926         Reviewed by Darin.
927
928         * WebKitPrefix.h:
929         Include FastMalloc.h from C++ code.
930
931 2006-10-24  Darin Adler  <darin@apple.com>
932
933         Reviewed by Anders.
934
935         - converted WebFrameLoaderClient to C++
936         - renamed frame->frameLoader() function to frame->loader()
937         - renamed [bridge impl] to [bridge _frame]
938         - removed some bridge methods
939
940         * Plugins/WebNetscapePluginStream.mm:
941         * WebCoreSupport/WebEditorClient.mm:
942         * WebCoreSupport/WebFrameLoaderClient.h: Added.
943         (WebFrameLoaderClient::webFrame):
944         * WebCoreSupport/WebFrameLoaderClient.mm: Added.
945         (WebFrameLoaderClient::detachFrameLoader):
946         (WebFrameLoaderClient::hasWebView):
947         (WebFrameLoaderClient::hasFrameView):
948         (WebFrameLoaderClient::hasBackForwardList):
949         (WebFrameLoaderClient::resetBackForwardList):
950         (WebFrameLoaderClient::provisionalItemIsTarget):
951         (WebFrameLoaderClient::loadProvisionalItemFromPageCache):
952         (WebFrameLoaderClient::invalidateCurrentItemPageCache):
953         (WebFrameLoaderClient::privateBrowsingEnabled):
954         (WebFrameLoaderClient::makeDocumentView):
955         (WebFrameLoaderClient::makeRepresentation):
956         (WebFrameLoaderClient::setDocumentViewFromPageCache):
957         (WebFrameLoaderClient::forceLayout):
958         (WebFrameLoaderClient::forceLayoutForNonHTML):
959         (WebFrameLoaderClient::updateHistoryForCommit):
960         (WebFrameLoaderClient::updateHistoryForBackForwardNavigation):
961         (WebFrameLoaderClient::updateHistoryForReload):
962         (WebFrameLoaderClient::updateHistoryForStandardLoad):
963         (WebFrameLoaderClient::updateHistoryForInternalLoad):
964         (WebFrameLoaderClient::updateHistoryAfterClientRedirect):
965         (WebFrameLoaderClient::setCopiesOnScroll):
966         (WebFrameLoaderClient::tokenForLoadErrorReset):
967         (WebFrameLoaderClient::resetAfterLoadError):
968         (WebFrameLoaderClient::doNotResetAfterLoadError):
969         (WebFrameLoaderClient::detachedFromParent1):
970         (WebFrameLoaderClient::detachedFromParent2):
971         (WebFrameLoaderClient::detachedFromParent3):
972         (WebFrameLoaderClient::detachedFromParent4):
973         (WebFrameLoaderClient::loadedFromPageCache):
974         (WebFrameLoaderClient::download):
975         (WebFrameLoaderClient::dispatchIdentifierForInitialRequest):
976         (WebFrameLoaderClient::dispatchWillSendRequest):
977         (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
978         (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
979         (WebFrameLoaderClient::dispatchDidReceiveResponse):
980         (WebFrameLoaderClient::dispatchDidReceiveContentLength):
981         (WebFrameLoaderClient::dispatchDidFinishLoading):
982         (WebFrameLoaderClient::dispatchDidFailLoading):
983         (WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
984         (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
985         (WebFrameLoaderClient::dispatchDidCancelClientRedirect):
986         (WebFrameLoaderClient::dispatchWillPerformClientRedirect):
987         (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
988         (WebFrameLoaderClient::dispatchWillClose):
989         (WebFrameLoaderClient::dispatchDidReceiveIcon):
990         (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
991         (WebFrameLoaderClient::dispatchDidReceiveTitle):
992         (WebFrameLoaderClient::dispatchDidCommitLoad):
993         (WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
994         (WebFrameLoaderClient::dispatchDidFailLoad):
995         (WebFrameLoaderClient::dispatchDidFinishLoad):
996         (WebFrameLoaderClient::dispatchDidFirstLayout):
997         (WebFrameLoaderClient::dispatchCreatePage):
998         (WebFrameLoaderClient::dispatchShow):
999         (WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
1000         (WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
1001         (WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
1002         (WebFrameLoaderClient::dispatchUnableToImplementPolicy):
1003         (WebFrameLoaderClient::dispatchWillSubmitForm):
1004         (WebFrameLoaderClient::dispatchDidLoadMainResource):
1005         (WebFrameLoaderClient::clearLoadingFromPageCache):
1006         (WebFrameLoaderClient::isLoadingFromPageCache):
1007         (WebFrameLoaderClient::revertToProvisionalState):
1008         (WebFrameLoaderClient::setMainDocumentError):
1009         (WebFrameLoaderClient::clearUnarchivingState):
1010         (WebFrameLoaderClient::progressStarted):
1011         (WebFrameLoaderClient::progressCompleted):
1012         (WebFrameLoaderClient::incrementProgress):
1013         (WebFrameLoaderClient::completeProgress):
1014         (WebFrameLoaderClient::setMainFrameDocumentReady):
1015         (WebFrameLoaderClient::startDownload):
1016         (WebFrameLoaderClient::willChangeTitle):
1017         (WebFrameLoaderClient::didChangeTitle):
1018         (WebFrameLoaderClient::committedLoad):
1019         (WebFrameLoaderClient::finishedLoading):
1020         (WebFrameLoaderClient::finalSetupForReplace):
1021         (WebFrameLoaderClient::cancelledError):
1022         (WebFrameLoaderClient::cannotShowURLError):
1023         (WebFrameLoaderClient::interruptForPolicyChangeError):
1024         (WebFrameLoaderClient::cannotShowMIMETypeError):
1025         (WebFrameLoaderClient::fileDoesNotExistError):
1026         (WebFrameLoaderClient::shouldFallBack):
1027         (WebFrameLoaderClient::mainFrameURL):
1028         (WebFrameLoaderClient::setDefersCallbacks):
1029         (WebFrameLoaderClient::willUseArchive):
1030         (WebFrameLoaderClient::isArchiveLoadPending):
1031         (WebFrameLoaderClient::cancelPendingArchiveLoad):
1032         (WebFrameLoaderClient::clearArchivedResources):
1033         (WebFrameLoaderClient::canHandleRequest):
1034         (WebFrameLoaderClient::canShowMIMEType):
1035         (WebFrameLoaderClient::representationExistsForURLScheme):
1036         (WebFrameLoaderClient::generatedMIMETypeForURLScheme):
1037         (WebFrameLoaderClient::elementForEvent):
1038         (WebFrameLoaderClient::createPolicyDecider):
1039         (WebFrameLoaderClient::frameLoadCompleted):
1040         (WebFrameLoaderClient::restoreScrollPositionAndViewState):
1041         (WebFrameLoaderClient::provisionalLoadStarted):
1042         (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent):
1043         (WebFrameLoaderClient::addHistoryItemForFragmentScroll):
1044         (WebFrameLoaderClient::didFinishLoad):
1045         (WebFrameLoaderClient::prepareForDataSourceReplacement):
1046         (WebFrameLoaderClient::createDocumentLoader):
1047         (WebFrameLoaderClient::setTitle):
1048         * WebKit.xcodeproj/project.pbxproj:
1049         * WebView/WebDataSource.mm:
1050         (-[WebDataSource webFrame]):
1051         * WebView/WebFrame.mm:
1052         (frame):
1053         (-[WebFrame _loadItem:withLoadType:]):
1054         (-[WebFrame _reloadForPluginChanges]):
1055         (-[WebFrame _initWithWebFrameView:webView:bridge:]):
1056         (-[WebFrame _frameLoader]):
1057         (-[WebFrame provisionalDataSource]):
1058         (-[WebFrame dataSource]):
1059         (-[WebFrame parentFrame]):
1060         (-[WebFrame _provisionalLoadStarted]):
1061         * WebView/WebFrameInternal.h:
1062         * WebView/WebHTMLRepresentation.m:
1063         (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
1064         * WebView/WebHTMLView.m:
1065         (-[WebHTMLView _lookUpInDictionaryFromMenu:]):
1066         (-[NSArray validateUserInterfaceItem:]):
1067         (-[NSArray scrollWheel:]):
1068         (-[NSArray acceptsFirstMouse:]):
1069         (-[NSArray shouldDelayWindowOrderingForEvent:]):
1070         (-[NSArray _selectionStartFontAttributesAsRTF]):
1071         (-[NSArray changeBaseWritingDirection:]):
1072         (-[NSArray indent:]):
1073         (-[NSArray outdent:]):
1074         (-[WebHTMLView copy:]):
1075         (-[WebHTMLView cut:]):
1076         (-[WebHTMLView paste:]):
1077         * WebView/WebView.mm:
1078         (-[WebView _dashboardRegions]):
1079         (-[WebView setProhibitsMainFrameScrolling:]):
1080         (-[WebView _setInViewSourceMode:]):
1081         (-[WebView _inViewSourceMode]):
1082         (-[WebView setEditable:]):
1083
1084 2006-10-24  John Sullivan  <sullivan@apple.com>
1085
1086         Reviewed by Kevin Decker
1087         
1088         - fixed <rdar://problem/4801331> "Spelling..." menu item should be "Show/Hide Spelling" post-Tiger, to match AppKit
1089
1090         * WebView/WebHTMLView.m:
1091         (-[NSArray validateUserInterfaceItem:]):
1092         post-Tiger, update the menu item text to "Show Spelling"/"Hide Spelling" based on whether
1093         the spelling panel is already showing. Also, removed else's after returns, and removed
1094         braces around one-line if clauses.
1095         (-[NSArray showGuessPanel:]):
1096         post-Tiger, make this item hide the spelling panel if it's already showing
1097
1098         * English.lproj/Localizable.strings:
1099         updated for this change
1100         
1101 2006-10-24  Timothy Hatcher  <timothy@apple.com>
1102
1103         Reviewed by Anders.
1104
1105         <rdar://problem/4588878> 'WebHTMLView' may not respond to '-_webView'
1106
1107         * Misc/WebNSViewExtras.h:
1108         * Misc/WebNSViewExtras.m:
1109         (-[NSView _webView]):
1110
1111 2006-10-24  Brady Eidson  <beidson@apple.com>
1112
1113         Reviewed by Anders
1114
1115         http://bugs.webkit.org/show_bug.cgi?id=11406 - Crash in [WebFrame dataSource]
1116         In the transition to ObjC++ we lost alot of our free nil checking that we must now do manually
1117         to prevent null dereferencing.
1118
1119         * WebView/WebFrame.mm:
1120         (-[WebFrame provisionalDataSource]):
1121         (-[WebFrame dataSource]):
1122
1123 2006-10-24  John Sullivan  <sullivan@apple.com>
1124
1125         Reviewed by Darin
1126         
1127         Initial plumbing for grammar checking. No actual grammar are checked at this time.
1128
1129         * English.lproj/WebViewEditingContextMenu.nib/classes.nib:
1130         * English.lproj/WebViewEditingContextMenu.nib/info.nib:
1131         * English.lproj/WebViewEditingContextMenu.nib/objects.nib:
1132         Added grammar-checking item, reworded to match changes in framework. This will be used
1133         post-Tiger.
1134
1135         * English.lproj/WebViewEditingContextMenuOld.nib/classes.nib: Added.
1136         * English.lproj/WebViewEditingContextMenuOld.nib/info.nib: Added.
1137         * English.lproj/WebViewEditingContextMenuOld.nib/objects.nib: Added.
1138         Copy of WebViewEditingContextMenu.nib, unchanged. This will be used on Tiger.
1139
1140         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
1141         (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
1142         Choose the right context menu based on BUILDING_ON_TIGER.
1143         
1144         * WebView/WebPreferenceKeysPrivate.h:
1145         declare grammar-related NSUserDefault value
1146
1147         * WebView/WebViewPrivate.h:
1148         declare grammar-related methods
1149
1150         * WebView/WebView.mm:
1151         declare static BOOL grammarCheckingEnabled
1152         (-[WebViewPrivate init]):
1153         initialize grammarCheckingEnabled to NSUserDefaults value
1154         (-[WebView validateUserInterfaceItem:]):
1155         validate toggleGrammarChecking: menu item
1156         (-[WebView isGrammarCheckingEnabled]):
1157         return value of grammarCheckingEnabled
1158         (-[WebView setGrammarCheckingEnabled:]):
1159         set value of grammarCheckingEnabled, call frame to remove existing bad grammar markers
1160         (-[WebView toggleGrammarChecking:]):
1161         flip the value
1162         
1163         * WebView/WebFrameInternal.h:
1164         * WebView/WebFrame.mm:
1165         (-[WebFrame _unmarkAllBadGrammar]):
1166         new placeholder method, does nothing yet
1167         
1168         * WebView/WebHTMLViewInternal.h:
1169         declare grammar-related methods
1170
1171         * WebView/WebHTMLView.m:
1172         (-[NSArray validateUserInterfaceItem:]):
1173         validate toggleGrammarChecking: menu item
1174         (-[WebHTMLView isGrammarCheckingEnabled]):
1175         new method, calls through to WebView
1176         (-[WebHTMLView setGrammarCheckingEnabled:]):
1177         ditto
1178         (-[WebHTMLView toggleGrammarChecking:]):
1179         ditto
1180                 
1181         * English.lproj/StringsNotToBeLocalized.txt:
1182         Updated for these changes
1183         
1184         * WebKit.xcodeproj/project.pbxproj:
1185         updated for new files        
1186
1187 2006-10-23  Darin Adler  <darin@apple.com>
1188
1189         Reviewed by Geoff.
1190
1191         - converted WebDocumentLoader to C++
1192
1193         * Plugins/WebPluginController.mm:
1194         (-[WebPluginController pluginView:receivedResponse:]):
1195         * WebKit.xcodeproj/project.pbxproj:
1196         * WebView/WebDataSource.mm:
1197         (-[WebDataSourcePrivate dealloc]):
1198         (-[WebDataSource _mainDocumentError]):
1199         (-[WebDataSource _URL]):
1200         (-[WebDataSource _loadFromPageCache:]):
1201         (-[WebDataSource _bridge]):
1202         (-[WebDataSource _URLForHistory]):
1203         (-[WebDataSource _documentLoader]):
1204         (-[WebDataSource _initWithDocumentLoader:]):
1205         (-[WebDataSource initWithRequest:]):
1206         (-[WebDataSource data]):
1207         (-[WebDataSource webFrame]):
1208         (-[WebDataSource initialRequest]):
1209         (-[WebDataSource request]):
1210         (-[WebDataSource response]):
1211         (-[WebDataSource textEncodingName]):
1212         (-[WebDataSource isLoading]):
1213         (-[WebDataSource unreachableURL]):
1214         (-[WebDataSource webArchive]):
1215         * WebView/WebDataSourceInternal.h:
1216         * WebView/WebDocumentLoaderMac.h:
1217         * WebView/WebDocumentLoaderMac.mm:
1218         (WebDocumentLoaderMac::WebDocumentLoaderMac):
1219         (WebDocumentLoaderMac::setDataSource):
1220         (WebDocumentLoaderMac::dataSource):
1221         (WebDocumentLoaderMac::attachToFrame):
1222         (WebDocumentLoaderMac::detachFromFrame):
1223         * WebView/WebFrame.mm:
1224         (-[WebFrame _createItem:]):
1225         (-[WebFrame _loadItem:withLoadType:]):
1226         (-[WebFrame _addChild:]):
1227         (dataSource):
1228         (-[WebFrame _dataSourceForDocumentLoader:]):
1229         (-[WebFrame _addDocumentLoader:toUnarchiveState:]):
1230         (-[WebFrame loadArchive:]):
1231         (-[WebFrame _updateHistoryForReload]):
1232         (-[WebFrame _updateHistoryForStandardLoad]):
1233         (-[WebFrame _updateHistoryForInternalLoad]):
1234         (-[WebFrame _dispatchIdentifierForInitialRequest:fromDocumentLoader:]):
1235         (-[WebFrame _dispatchResource:willSendRequest:redirectResponse:fromDocumentLoader:]):
1236         (-[WebFrame _dispatchDidReceiveAuthenticationChallenge:forResource:fromDocumentLoader:]):
1237         (-[WebFrame _dispatchDidCancelAuthenticationChallenge:forResource:fromDocumentLoader:]):
1238         (-[WebFrame _dispatchResource:didReceiveResponse:fromDocumentLoader:]):
1239         (-[WebFrame _dispatchResource:didReceiveContentLength:fromDocumentLoader:]):
1240         (-[WebFrame _dispatchResource:didFinishLoadingFromDocumentLoader:]):
1241         (-[WebFrame _dispatchResource:didFailLoadingWithError:fromDocumentLoader:]):
1242         (-[WebFrame _dispatchDidLoadMainResourceForDocumentLoader:]):
1243         (-[WebFrame _clearLoadingFromPageCacheForDocumentLoader:]):
1244         (-[WebFrame _isDocumentLoaderLoadingFromPageCache:]):
1245         (-[WebFrame _makeRepresentationForDocumentLoader:]):
1246         (-[WebFrame _revertToProvisionalStateForDocumentLoader:]):
1247         (-[WebFrame _setMainDocumentError:forDocumentLoader:]):
1248         (-[WebFrame _clearUnarchivingStateForLoader:]):
1249         (-[WebFrame _willChangeTitleForDocument:]):
1250         (-[WebFrame _didChangeTitleForDocument:]):
1251         (-[WebFrame _finishedLoadingDocument:]):
1252         (-[WebFrame _committedLoadWithDocumentLoader:data:]):
1253         (-[WebFrame _documentLoader:setMainDocumentError:]):
1254         (-[WebFrame _finalSetupForReplaceWithDocumentLoader:]):
1255         (-[WebFrame _createDocumentLoaderWithRequest:]):
1256         (-[WebFrame _provisionalLoadStarted]):
1257         * WebView/WebFrameInternal.h:
1258         * WebView/WebHTMLRepresentation.m:
1259         (-[WebHTMLRepresentation title]):
1260         * WebView/WebView.mm:
1261         (-[WebView _mainFrameOverrideEncoding]):
1262
1263 2006-10-23  Geoffrey Garen  <ggaren@apple.com>
1264
1265         RS by Maciej.
1266         
1267         Gave ObjC++ files .mm extension instead of .m.
1268
1269         * WebCoreSupport/WebPageBridge.m: Removed.
1270         * WebKit.xcodeproj/project.pbxproj:
1271         * WebView/WebDocumentLoaderMac.m: Removed.
1272
1273 2006-10-23  Darin Adler  <darin@apple.com>
1274
1275         Reviewed by Maciej.
1276
1277         - converted WebFrameLoader to C++
1278
1279         * History/WebHistoryItem.m:
1280         (+[WebHistoryItem _closeObjectsInPendingPageCaches]):
1281         * Plugins/WebBaseNetscapePluginView.mm:
1282         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
1283         * Plugins/WebNetscapePluginStream.mm:
1284         (-[WebNetscapePluginStream start]):
1285         (-[WebNetscapePluginStream stop]):
1286         * Plugins/WebPluginController.mm:
1287         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
1288         (-[WebPluginController pluginView:receivedResponse:]):
1289         * WebCoreSupport/WebFrameBridge.h:
1290         * WebKit.xcodeproj/project.pbxproj:
1291         * WebView/WebDataSource.mm:
1292         (-[WebDataSource _loadFromPageCache:]):
1293         (-[WebDataSource _webView]):
1294         (-[WebDataSource webFrame]):
1295         * WebView/WebDocumentLoaderMac.h:
1296         * WebView/WebDocumentLoaderMac.m:
1297         (-[WebDocumentLoaderMac dealloc]):
1298         (-[WebDocumentLoaderMac attachToFrame]):
1299         (-[WebDocumentLoaderMac detachFromFrame]):
1300         * WebView/WebFrame.mm:
1301         (+[WebFrame _timeOfLastCompletedLoad]):
1302         (-[WebFrame _loadItem:withLoadType:]):
1303         (-[WebFrame _loadURL:referrer:intoChild:]):
1304         (-[WebFrame _currentBackForwardListItemToResetTo]):
1305         (-[WebFrame _itemForRestoringDocState]):
1306         (-[WebFrame _frameLoader]):
1307         (-[WebFrame _firstLayoutDone]):
1308         (-[WebFrame _loadType]):
1309         (-[WebFrame provisionalDataSource]):
1310         (-[WebFrame dataSource]):
1311         (-[WebFrame loadRequest:]):
1312         (-[WebFrame loadArchive:]):
1313         (-[WebFrame stopLoading]):
1314         (-[WebFrame reload]):
1315         (-[WebFrame _updateHistoryForCommit]):
1316         (-[WebFrame _updateHistoryForReload]):
1317         (-[WebFrame _updateHistoryForInternalLoad]):
1318         (-[WebFrame _deliverArchivedResourcesAfterDelay]):
1319         (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]):
1320         (-[WebFrame _deliverArchivedResources]):
1321         (-[WebFrame _prepareForDataSourceReplacement]):
1322         (-[WebFrame _provisionalLoadStarted]):
1323         * WebView/WebFrameInternal.h:
1324         * WebView/WebHTMLView.m:
1325         (-[WebHTMLView _clearLastHitViewIfSelf]):
1326         (-[WebHTMLView _updateMouseoverWithEvent:]):
1327         (-[NSArray removeMouseMovedObserverUnconditionally]):
1328         (-[NSArray removeMouseMovedObserver]):
1329         (-[NSArray viewWillMoveToWindow:]):
1330         (-[NSArray viewDidMoveToWindow]):
1331         (-[WebHTMLView _canMakeTextSmaller]):
1332         (-[WebHTMLView _canMakeTextLarger]):
1333         (-[WebHTMLView _canMakeTextStandardSize]):
1334         * WebView/WebPDFView.mm:
1335         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1336         * WebView/WebView.mm:
1337         (-[WebView _close]):
1338         (-[WebView setDefersCallbacks:]):
1339         (-[WebView setCustomTextEncodingName:]):
1340
1341 2006-10-23  Geoffrey Garen  <ggaren@apple.com>
1342
1343         Reviewed by Bradee.
1344
1345         Moved some page-level operations from WebFrameBridge to WebPageBridge.
1346
1347         * WebCoreSupport/WebFrameBridge.m:
1348         * WebCoreSupport/WebPageBridge.m:
1349         (-[WebPageBridge createModalDialogWithURL:referrer:]):
1350         (-[WebPageBridge canRunModal]):
1351         (-[WebPageBridge canRunModalNow]):
1352         (-[WebPageBridge runModal]):
1353         * WebKit.xcodeproj/project.pbxproj: Made WebPageBridge.m ObjC++ to support
1354         WebCore #includes.
1355
1356 2006-10-23  John Sullivan  <sullivan@apple.com>
1357
1358         * WebKitPrefix.h:
1359         Removed redundant definition of BUILDING_ON_TIGER that I just added. It turns out this had
1360         already been added between the last time I updated in this tree and when I needed it locally.
1361
1362 2006-10-23  John Sullivan  <sullivan@apple.com>
1363
1364         Reviewed by Anders
1365
1366         * WebKit.xcodeproj/project.pbxproj:
1367         Move WebKitPrefix.h from Misc group to top level, to match WebCore
1368         
1369         * WebKitPrefix.h:
1370         defined BUILDING_ON_TIGER a la WebCore, in preparation for future use of post-Tiger API
1371
1372 2006-10-23  Timothy Hatcher  <timothy@apple.com>
1373
1374         Reviewed by Darin.
1375
1376         Rename the now ObjC++ files to be .mm and remove the explicit file types.
1377
1378         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
1379         (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
1380         * English.lproj/StringsNotToBeLocalized.txt:
1381         * Plugins/WebBaseNetscapePluginView.m: Removed.
1382         * Plugins/WebNetscapePluginStream.m: Removed.
1383         * Plugins/WebPluginController.m: Removed.
1384         * WebCoreSupport/WebFrameBridge.m: Removed.
1385         * WebKit.xcodeproj/project.pbxproj:
1386         * WebView/WebDataSource.m: Removed.
1387         * WebView/WebFrame.m: Removed.
1388         * WebView/WebFrameView.m: Removed.
1389         * WebView/WebPDFView.m: Removed.
1390         * WebView/WebPolicyDelegate.m: Removed.
1391         * WebView/WebView.m: Removed.
1392
1393 2006-10-23  Timothy Hatcher  <timothy@apple.com>
1394
1395         Reviewed by Darin.
1396
1397         Move the undef try/catch to WebKitPrefix.h and include algorithm so we get
1398         exception_defines.h and so the undef of try/catch works.
1399
1400         Break off the BGRA to ARGB code into WebGraphicsExtras.c, this lets
1401         WebBaseNetscapePluginView.m safely compile as ObjC++ and not cause the Accelerate
1402         framework to complain about C++ exceptions being disabled.
1403
1404         * Misc/WebGraphicsExtras.c: Added.
1405         (WebConvertBGRAToARGB):
1406         * Misc/WebGraphicsExtras.h: Added.
1407         * Plugins/WebBaseNetscapePluginView.m:
1408         (-[WebBaseNetscapePluginView _aglOffscreenImageForDrawingInRect:]):
1409         * WebKit.xcodeproj/project.pbxproj:
1410         * WebKitPrefix.h:
1411         * WebView/WebView.m:
1412
1413 2006-10-22  Sam Weinig  <sam.weinig@gmail.com>
1414
1415         Reviewed by Tim H.
1416
1417         - Add DOMHTMLFormElementPrivate.h to the project.
1418
1419         * MigrateHeaders.make:
1420
1421 2006-10-21  Darin Adler  <darin@apple.com>
1422
1423         Reviewed by Adele.
1424
1425         - convert WebLoader and its 3 subclasses to C++
1426
1427         * Plugins/WebNetscapePluginStream.h:
1428         * Plugins/WebNetscapePluginStream.m:
1429         (-[WebNetscapePluginStream dealloc]):
1430         (-[WebNetscapePluginStream finalize]):
1431         (-[WebNetscapePluginStream start]):
1432         (-[WebNetscapePluginStream cancelLoadWithError:]):
1433         (-[WebNetscapePluginStream stop]):
1434         * WebCoreSupport/WebFrameBridge.m:
1435         (-[WebFrameBridge canRunModalNow]):
1436         * WebView/WebFrame.m:
1437         (-[WebFramePrivate dealloc]):
1438         (-[WebFramePrivate finalize]):
1439         (frame): Changed from uppercase to lowercase so that it won't conflict
1440         with the WebCore class named Frame.
1441         (-[WebFrame _firstChildFrame]):
1442         (-[WebFrame _lastChildFrame]):
1443         (-[WebFrame _previousSiblingFrame]):
1444         (-[WebFrame _nextSiblingFrame]):
1445         (-[WebFrame _traverseNextFrameStayWithin:]):
1446         (-[WebFrame _immediateChildFrameNamed:]):
1447         (-[WebFrame _nextFrameWithWrap:]):
1448         (-[WebFrame _previousFrameWithWrap:]):
1449         (-[WebFrame findFrameNamed:]):
1450         (-[WebFrame parentFrame]):
1451         (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]):
1452         (-[WebFrame _deliverArchivedResourcesAfterDelay]):
1453         (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]):
1454         (-[WebFrame _archiveLoadPendingForLoader:]):
1455         (-[WebFrame _cancelPendingArchiveLoadForLoader:]):
1456         (-[WebFrame _clearArchivedResources]):
1457         (-[WebFrame _deliverArchivedResources]):
1458
1459 2006-10-21  Darin Adler  <darin@apple.com>
1460
1461         Reviewed by Anders.
1462
1463         - fix http://bugs.webkit.org/show_bug.cgi?id=10328
1464           REGRESSION: frame leak reported by buildbot
1465
1466         * WebCoreSupport/WebEditorClient.mm:
1467         (WebEditorClient::WebEditorClient): Don't retain the web view.
1468         (WebEditorClient::~WebEditorClient): Don't release the web view.
1469         (WebEditorClient::setWebView): Ditto.
1470
1471         * WebCoreSupport/WebFrameBridge.m:
1472         (-[WebFrameBridge finishInitializingWithFrameName:view:]): Added. Common code for use by both
1473         init methods below.
1474         (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): Changed to use new method.
1475         Also added comment pointing out design flaw -- we attach the client to the web view here,
1476         but we need to be sure to detach in case the web view is deallocated first.
1477         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): Ditto.
1478
1479 2006-10-21  Darin Adler  <darin@apple.com>
1480
1481         Reviewed by Adam.
1482
1483         - http://bugs.webkit.org/show_bug.cgi?id=11376
1484           build scripts should invoke make with "-j" option for multiple processors
1485
1486         * WebKit.xcodeproj/project.pbxproj: Pass -j `sysctl -n hw.ncpu` to make.
1487
1488 2006-10-21  Timothy Hatcher  <timothy@apple.com>
1489
1490         Reviewed by Geoff.
1491
1492         <rdar://problem/4478625> HTML Editing: Basic table editing and culling
1493
1494         Initial implementaltion of table deletion user interface:
1495         * Adds a new editing delegate method, webView:shouldShowDeleteInterfaceForElement:.
1496         * The new delegate method is called from the new shouldShowDeleteInterface EditorClient function.
1497
1498         * DefaultDelegates/WebDefaultEditingDelegate.m:
1499         (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]):
1500         * WebCoreSupport/WebEditorClient.h:
1501         * WebCoreSupport/WebEditorClient.mm:
1502         (WebEditorClient::WebEditorClient):
1503         (WebEditorClient::shouldDeleteRange):
1504         (WebEditorClient::shouldShowDeleteInterface):
1505         * WebKit.xcodeproj/project.pbxproj:
1506         * WebView/WebEditingDelegatePrivate.h: Added.
1507
1508 2006-10-21  Alice Liu  <alice.liu@apple.com>
1509
1510         Reviewed by Maciej.
1511
1512         fix leaks.
1513
1514         * WebCoreSupport/WebEditorClient.mm:
1515         (WebEditorClient::setWebView):
1516         only change webview if its different
1517
1518         * WebCoreSupport/WebFrameBridge.m:
1519         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
1520         actually use the client allocated in the line above instead of
1521         allocation again, duh. 
1522
1523 2006-10-21  Alice Liu  <alice.liu@apple.com>
1524
1525         Build fix.
1526
1527         * WebCoreSupport/WebEditorClient.h:
1528         * WebCoreSupport/WebEditorClient.mm:
1529         (WebEditorClient::setWebView):
1530
1531 2006-10-20  Alice Liu  <alice.liu@apple.com>
1532
1533         Reviewed by Tim Hatcher.
1534
1535         Fixed a problem where the webview passed to the EditorClient wasn't valid yet.  
1536
1537         * WebCoreSupport/WebEditorClient.h:
1538         (WebEditorClient::setWebView):
1539         added webview setter
1540
1541         * WebCoreSupport/WebEditorClient.mm:
1542         (WebEditorClient::WebEditorClient):
1543         add default constructor
1544
1545         * WebCoreSupport/WebFrameBridge.m:
1546         (-[WebFrameBridge initMainFrameWithPage:frameName:view:]):
1547         use [page webView] since _webview isn't valid yet
1548         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
1549         use webview setter on editorclient
1550
1551 2006-10-20  David Hyatt  <hyatt@apple.com>
1552
1553         Tweak cache sizes so that they are back to the way they were,
1554         except for < 512, which will stay doubled.
1555
1556         Reviewed by Tim H.
1557
1558         * WebCoreSupport/WebFrameBridge.m:
1559         (-[WebFrameBridge getObjectCacheSize]):
1560
1561 2006-10-20  Alice Liu  <alice.liu@apple.com>
1562
1563         Reviewed by Maciej.
1564
1565         Adding knowledge of EditorClient to WebKit
1566
1567         * WebCoreSupport/WebEditorClient.h: Added.
1568
1569         * WebCoreSupport/WebEditorClient.mm: Added.
1570         (WebEditorClient::WebEditorClient):
1571         (WebEditorClient::~WebEditorClient):
1572         (WebEditorClient::shouldDeleteRange):
1573         Implementation of mac EditorClient
1574
1575         * WebCoreSupport/WebFrameBridge.m:
1576         (-[WebFrameBridge initMainFrameWithPage:frameName:view:]):
1577         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
1578         create an editor client to pass down the chain of constructors
1579
1580         * WebKit.xcodeproj/project.pbxproj:
1581         Added related EditorClient files
1582
1583         * WebKitPrefix.h:
1584         Added tiger build flag in order to make certain private headers from webcore compile successfully
1585
1586 2006-10-20  Darin Adler  <darin@apple.com>
1587
1588         - rolled out my loader change; caused world leak and possibly a plug-in crash
1589
1590 2006-10-20  Darin Adler  <darin@apple.com>
1591
1592         Reviewed by Adele.
1593
1594         - convert WebLoader and its 3 subclasses to C++
1595
1596         * Plugins/WebNetscapePluginStream.h:
1597         * Plugins/WebNetscapePluginStream.m:
1598         (-[WebNetscapePluginStream dealloc]):
1599         (-[WebNetscapePluginStream finalize]):
1600         (-[WebNetscapePluginStream start]):
1601         (-[WebNetscapePluginStream cancelLoadWithError:]):
1602         (-[WebNetscapePluginStream stop]):
1603         * WebCoreSupport/WebFrameBridge.m:
1604         (-[WebFrameBridge canRunModalNow]):
1605         * WebView/WebFrame.m:
1606         (-[WebFramePrivate dealloc]):
1607         (-[WebFramePrivate finalize]):
1608         (frame): Changed from uppercase to lowercase so that it won't conflict
1609         with the WebCore class named Frame.
1610         (-[WebFrame _firstChildFrame]):
1611         (-[WebFrame _lastChildFrame]):
1612         (-[WebFrame _previousSiblingFrame]):
1613         (-[WebFrame _nextSiblingFrame]):
1614         (-[WebFrame _traverseNextFrameStayWithin:]):
1615         (-[WebFrame _immediateChildFrameNamed:]):
1616         (-[WebFrame _nextFrameWithWrap:]):
1617         (-[WebFrame _previousFrameWithWrap:]):
1618         (-[WebFrame findFrameNamed:]):
1619         (-[WebFrame parentFrame]):
1620         (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]):
1621         (-[WebFrame _deliverArchivedResourcesAfterDelay]):
1622         (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]):
1623         (-[WebFrame _archiveLoadPendingForLoader:]):
1624         (-[WebFrame _cancelPendingArchiveLoadForLoader:]):
1625         (-[WebFrame _clearArchivedResources]):
1626         (-[WebFrame _deliverArchivedResources]):
1627
1628 2006-10-20  John Sullivan  <sullivan@apple.com>
1629
1630         Reviewed by Darin
1631         
1632         - fixed <rdar://problem/4794935> setAcceptsMouseMovedEvents: is called for every layout, 
1633           taking ~1% on the PLT test
1634
1635         * WebView/WebHTMLView.m:
1636         (-[NSArray layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
1637         Don't call setAcceptsMouseMovedEvents: and WKSetNSWindowShouldPostEventNotifications() here
1638         because this is called too often.
1639         
1640         * WebView/WebView.m:
1641         (-[WebView viewWillMoveToWindow:]):
1642         Do call them here, because this is guaranteed to be called at least once for each window
1643         containing a webview, but isn't called too often. Also restructured this method a little.
1644
1645 2006-10-19  Timothy Hatcher  <timothy@apple.com>
1646
1647         Reviewed by Anders.
1648
1649         Bug 11366: Web Inspector should show user agent style rules
1650         http://bugs.webkit.org/show_bug.cgi?id=11366
1651
1652         * WebInspector/WebInspector.m:
1653         (-[WebInspector init]):
1654         (-[WebInspector showOptionsMenu]):
1655         (-[WebInspector _toggleShowUserAgentStyles:]):
1656         * WebInspector/WebInspectorInternal.h:
1657         * WebInspector/webInspector/inspector.js:
1658
1659 2006-10-19  Brady Eidson <beidson@apple.com>
1660
1661         Build fix - 2gig is on that pesky signed/unsigned limit...
1662
1663         * WebCoreSupport/WebFrameBridge.m:
1664         (-[WebFrameBridge getObjectCacheSize]):
1665
1666 2006-10-19  Brady Eidson  <beidson@apple.com>
1667
1668         Reviewed by Hyatt.
1669
1670         Death to 16777216.  Long live 33554432.
1671         (Cache size changed needs to be reflected in localization file)
1672
1673         * English.lproj/StringsNotToBeLocalized.txt:
1674
1675 2006-10-19  Brady Eidson  <beidson@apple.com>
1676
1677         Reviewed by Hyatt
1678
1679         Added an larger in-memory level of cache for machines with 2+gb ram
1680
1681         * WebCoreSupport/WebFrameBridge.m:
1682         (-[WebFrameBridge getObjectCacheSize]):
1683
1684 2006-10-19  Brady Eidson  <beidson@apple.com>
1685
1686         Reviewed by Hyatt
1687
1688         Double the default memory cache size
1689
1690         * WebView/WebPreferences.m:
1691         (+[WebPreferences initialize]):
1692
1693 2006-10-19  John Sullivan  <sullivan@apple.com>
1694
1695         Reviewed by Kevin D and Geoff
1696
1697         * WebKit.xcodeproj/project.pbxproj:
1698         version wars
1699         
1700         Cleaned up this file, as follows:
1701         - renamed all file-internal methods to start with underscores
1702         - moved all file-internal methods into a FileInternal category block, and alphabetized them
1703         - grouped all other methods by where/how they were defined (delegate methods, protocol methods, overrides, etc.)
1704         - removed unstylish braces around one-line clauses
1705         
1706         * WebView/WebPDFView.m:
1707         (_applicationInfoForMIMEType):
1708         (_PDFSelectionsAreEqual):
1709         (+[WebPDFView supportedMIMETypes]):
1710         (-[WebPDFView setPDFDocument:]):
1711         (-[WebPDFView dealloc]):
1712         (-[WebPDFView centerSelectionInVisibleArea:]):
1713         (-[WebPDFView scrollPageDown:]):
1714         (-[WebPDFView scrollPageUp:]):
1715         (-[WebPDFView scrollLineDown:]):
1716         (-[WebPDFView scrollLineUp:]):
1717         (-[WebPDFView scrollToBeginningOfDocument:]):
1718         (-[WebPDFView scrollToEndOfDocument:]):
1719         (-[WebPDFView jumpToSelection:]):
1720         (-[WebPDFView acceptsFirstResponder]):
1721         (-[WebPDFView becomeFirstResponder]):
1722         (-[WebPDFView hitTest:]):
1723         (-[WebPDFView initWithFrame:]):
1724         (-[WebPDFView menuForEvent:]):
1725         (-[WebPDFView setNextKeyView:]):
1726         (-[WebPDFView viewDidMoveToWindow]):
1727         (-[WebPDFView viewWillMoveToWindow:]):
1728         (-[WebPDFView validateUserInterfaceItem:]):
1729         (-[WebPDFView copy:]):
1730         (-[WebPDFView takeFindStringFromSelection:]):
1731         (-[WebPDFView canPrintHeadersAndFooters]):
1732         (-[WebPDFView printOperationWithPrintInfo:]):
1733         (-[WebPDFView viewWillMoveToHostWindow:]):
1734         (-[WebPDFView viewDidMoveToHostWindow]):
1735         (-[WebPDFView elementAtPoint:]):
1736         (-[WebPDFView elementAtPoint:allowShadowContent:]):
1737         (-[WebPDFView searchFor:direction:caseSensitive:wrap:]):
1738         (-[WebPDFView viewState]):
1739         (-[WebPDFView setViewState:]):
1740         (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
1741         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
1742         (+[WebPDFView _PDFPreviewViewClass]):
1743         (+[WebPDFView _PDFViewClass]):
1744         (-[WebPDFView _anyPDFTagsFoundInMenu:]):
1745         (-[WebPDFView _applyPDFDefaults]):
1746         (-[WebPDFView _fakeKeyEventWithFunctionKey:]):
1747         (-[WebPDFView _menuItemsFromPDFKitForEvent:]):
1748         (-[WebPDFView _openWithFinder:]):
1749         (-[WebPDFView _path]):
1750         (-[WebPDFView _PDFSubview]):
1751         (-[WebPDFView _pointIsInSelection:]):
1752         (-[WebPDFView _receivedPDFKitLaunchNotification:]):
1753         (-[WebPDFView _scaledAttributedString:]):
1754         (-[WebPDFView _trackFirstResponder]):
1755         (-[PDFPrefUpdatingProxy forwardInvocation:]):
1756         (-[PDFPrefUpdatingProxy methodSignatureForSelector:]):
1757
1758 2006-10-19  John Sullivan  <sullivan@apple.com>
1759
1760         Reviewed by Kevin Decker
1761         
1762         - fixed <rdar://problem/4792761> Safari should use fancier embedded PDFKit stuff when it's available
1763
1764         * WebKit.xcodeproj/project.pbxproj:
1765         version wars
1766         
1767         * WebView/WebFrameView.m:
1768         (-[WebFrameView _makeDocumentViewForDataSource:]):
1769         initialize document view with frame view's rect instead of empty rect. This avoids some problems when 
1770         constructing view hierarchies from nibs
1771         
1772         * WebView/WebPreferencesPrivate.h:
1773         declare new _usePDFPreviewView and _setUsePDFPreviewView:, used for debugging
1774         * WebView/WebPreferenceKeysPrivate.h:
1775         declare new preference key string
1776         * WebView/WebPreferences.m:
1777         (+[WebPreferences initialize]):
1778         initialize new preference to true (we will by default use the new view if it's available)
1779         (-[WebPreferences _usePDFPreviewView]):
1780         new accessor for new pref
1781         (-[WebPreferences _setUsePDFPreviewView:]):
1782         ditto
1783
1784         * WebView/WebPDFView.h:
1785         new previewView ivar
1786         
1787         * WebView/WebPDFView.m:
1788         (+[WebPDFView PDFPreviewViewClass]):
1789         new method, returns class to use for fancier embedded PDFKit stuff, or nil if fancy stuff isn't available
1790         (-[WebPDFView initWithFrame:]):
1791         now tries to use fancier embedded PDFKit stuff if it's available and the pref is set to use it; falls back
1792         to old behavior otherwise
1793         (-[WebPDFView dealloc]):
1794         release new previewView ivar (retained in initWithFrame:)
1795         (-[WebPDFView viewWillMoveToWindow:]):
1796         stop observing PDFKit notification when we're removed from window
1797         (-[WebPDFView viewDidMoveToWindow]):
1798         start observing PDFKit notification when we're added to window
1799         (-[WebPDFView _receivedPDFKitLaunchNotification:]):
1800         respond to this new PDFKit notification by opening the document via NSWorkspace
1801         
1802         * English.lproj/StringsNotToBeLocalized.txt:
1803         updated for lots of recent changes
1804         
1805 2006-10-19  Sam Weinig  <sam.weinig@gmail.com>
1806
1807         Reviewed by ap.
1808
1809         Win32 build fix.
1810
1811         * COM/WebFrame.cpp:
1812         (WebFrame::initWithName):
1813         (WebFrame::createNewWindow):
1814
1815 2006-10-19  Mitz Pettel  <mitz@webkit.org>
1816
1817         Reviewed and landed by ap.
1818
1819         - fixed the inspector's tree popup
1820
1821         * WebInspector/webInspector/inspector.html:
1822
1823 2006-10-18  Sam Weinig  <sam.weinig@gmail.com>
1824
1825         Reviewed by Maciej.
1826
1827         Win32 build fix.
1828
1829         * COM/WebFrame.cpp:
1830         (WebFrame::createNewWindow):
1831         * COM/WebFrame.h:
1832
1833 2006-10-18  Anders Carlsson  <acarlsson@apple.com>
1834
1835         Reviewed by Adam.
1836
1837         http://bugs.webkit.org/show_bug.cgi?id=11000
1838         REGRESSION (r16101): css2.1/t0801-c412-hz-box-00-b-a is failing because the QuickTime plugin is taking over but not rendering the png
1839         
1840         * WebCoreSupport/WebFrameBridge.m:
1841         (-[WebFrameBridge determineObjectFromMIMEType:URL:]):
1842         Return ObjectElementFrame if the MIME type is one of the image ones we support.
1843
1844 2006-10-17  Justin Garcia  <justin.garcia@apple.com>
1845
1846         Reviewed by harrison
1847         
1848         <rdar://problem/4765600>
1849         REGRESSION: Mail.app: smart deletion of words does not work
1850         
1851         Regressed when we pushed selecion expansion down into WebCore.  It's OK
1852         to try a smart delete from _deleteWithDirection:, which is called by
1853         deleteFoward: and deleteBackward: if the current selection is a 
1854         range.
1855     
1856         * WebView/WebHTMLView.m:
1857         (-[NSArray _deleteWithDirection:granularity:killRing:isTypingAction:]):
1858
1859 2006-10-13  Justin Garcia  <justin.garcia@apple.com>
1860
1861         Reviewed by harrison
1862         
1863         <rdar://problem/3655385>
1864         Editing: -indent: method unimplemented
1865
1866         * WebView/WebHTMLView.m:
1867         (-[NSArray validateUserInterfaceItem:]): Only allow indent:/outdent: in
1868         richly editable areas.
1869         (-[NSArray indent:]):
1870         (-[NSArray outdent:]):
1871
1872 2006-10-13  Maciej Stachowiak  <mjs@apple.com>
1873
1874         Not reviewed, build fix.
1875         
1876         * icu/unicode/putil.h: Added - needed for build if you don't have apple internal headers.
1877
1878 2006-10-13  Maciej Stachowiak  <mjs@apple.com>
1879
1880         Not reviewed, build fix.
1881         
1882         * icu/unicode/ustring.h: Added - needed for build if you don't have apple internal headers.
1883
1884 2006-10-13  Maciej Stachowiak  <mjs@apple.com>
1885
1886         Reviewed by Anders.
1887         
1888         - add a bunch of casts to get this compiling with older Xcode versions
1889         
1890         (I used static_cast so it will be easier to find and remove these once we have completely moved
1891         on to a new enough compiler version.)
1892
1893         * Plugins/WebBaseNetscapePluginView.m:
1894         (+[WebBaseNetscapePluginView getCarbonEvent:]):
1895         (-[WebBaseNetscapePluginView getCarbonEvent:withEvent:]):
1896         (-[WebBaseNetscapePluginView fixWindowPort]):
1897         (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
1898         (-[WebBaseNetscapePluginView _createWindowlessAGLContext]):
1899         (-[WebBaseNetscapePluginView _reshapeAGLWindow]):
1900         (-[WebBaseNetscapePluginView _aglOffscreenImageForDrawingInRect:]):
1901         * WebKit.xcodeproj/project.pbxproj:
1902
1903 2006-10-13  Kevin McCullough  <KMcCullough@apple.com>
1904
1905         Changed by Darin, reviewed by me.
1906
1907         * Plugins/WebNetscapePluginStream.m: Fixed case of import so we can compile on
1908         case-sensitive file system.
1909
1910 2006-10-13  Darin Adler  <darin@apple.com>
1911
1912         Reviewed by Adele.
1913
1914         - converted WebFormState from Objective-C to C++
1915
1916         * ForwardingHeaders: Added an entire copy of WebCore's forwarding headers here.
1917         We should eventually come up with a more-elegant solution.
1918
1919         * WebKit.xcodeproj/project.pbxproj: Added ForwardingHeaders to the include paths.
1920         Converted many files from Objective-C to Objective-C++. In a later check-in, I'll
1921         rename them to .mm instead of .m. Removed C-only warning options for now. In a
1922         later check-in I will add these back in a way that omits them for C++.
1923
1924         * Plugins/WebPluginContainerCheck.m: Updated for header changes.
1925
1926         * WebView/WebFrameInternal.h: Updated for header changes. Removed WebFrameLoaderClient category
1927         so this file can still be used by Objective-C code (not just Objective-C++).
1928
1929         * WebView/WebFrame.m: Put WebFrameLoaderClient category in here.
1930         (-[WebFrame _loadItem:withLoadType:]): Changed to use 0 instead of nil for FormState and fixed
1931         enum code for C++ compatibility.
1932         (-[WebFrame _initWithWebFrameView:webView:bridge:]): Added call to setFrameLoaderClient: here.
1933         (-[WebFrame _updateHistoryForCommit]): Fixed enum code for C++ compatibility.
1934         (-[WebFrame _updateHistoryForReload]): Ditto.
1935
1936         * WebCoreSupport/WebFrameBridge.m:
1937         (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): Removed call to setFrameLoaderClient:.
1938         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): Ditto.
1939         (-[WebFrameBridge _retrieveKeyboardUIModeFromPreferences:]): Fixed enum code for C++ compatibility.
1940         (-[WebFrameBridge runModal]): Changed code to not use "namespace" as a local variable name.
1941
1942         * WebView/WebPDFView.m: Added extern "C" so this can compile as Objective-C++.
1943
1944 2006-10-12  Maciej Stachowiak  <mjs@apple.com>
1945
1946         Reviewed by Oliver.
1947         
1948         - liberate more WebKit code down to WebCore
1949
1950         * WebCoreSupport/WebFrameBridge.h:
1951         * WebCoreSupport/WebFrameBridge.m:
1952
1953 2006-10-12  Adele Peterson  <adele@apple.com>
1954
1955         Reviewed by Maciej.
1956
1957         WebKit part of fix for <rdar://problem/4450613> need a means to attach user data to any menu that is popuped up in HTML
1958
1959         Added private delegate method for clients that want access to a PopupMenu's NSMenu.
1960
1961         * DefaultDelegates/WebDefaultUIDelegate.m: (-[NSApplication webView:willPopupMenu:]):
1962         * WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge willPopupMenu:]):
1963         * WebView/WebUIDelegatePrivate.h:
1964
1965 2006-10-12  MorganL  <morganl.webkit@yahoo.com>
1966
1967         Reviewed/landed by Adam.
1968
1969         Fixes http://bugs.webkit.org/show_bug.cgi?id=11264
1970         Windows build busted
1971
1972         * COM/WebFrame.cpp:
1973         (WebFrame::receivedResponse):
1974
1975 2006-10-11  Darin Adler  <darin@apple.com>
1976
1977         Reviewed by Adele.
1978
1979         - preparations for making more code C++
1980
1981         * WebKitPrefix.h: Fixed ifdef so that C++ files get all the precompiled stuff
1982         that non-C++ files get.
1983
1984         * Misc/WebKitLogging.h:
1985         * Misc/WebKitSystemBits.h:
1986         * Misc/WebLocalizableStrings.h:
1987         * WebCoreSupport/WebSystemInterface.h:
1988         Added extern "C".
1989
1990         * Misc/WebNSViewExtras.h:
1991         * WebView/WebDataSource.m: (addTypesFromClass):
1992         * WebView/WebFrameView.m: (addTypesFromClass):
1993         Eliminated use of the identifier "class".
1994
1995         * WebView/WebView.m: (-[WebView _goToItem:withLoadType:]): Added a type cast.
1996
1997         * Plugins/WebBaseNetscapePluginView.m: Added lots of type casts.
1998
1999 2006-10-10  Brady Eidson  <beidson@apple.com>
2000
2001         Reviewed by Maciej.
2002
2003         Moved WebFrameLoader into WebCoreFrameBridge
2004
2005         * WebCoreSupport/WebFrameBridge.h:
2006         * WebCoreSupport/WebFrameBridge.m:
2007         (-[WebFrameBridge initMainFrameWithPage:frameName:view:]):
2008         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
2009         (-[WebFrameBridge dealloc]):
2010         (-[WebFrameBridge setTitle:]):
2011         (-[WebFrameBridge receivedData:textEncodingName:]):
2012         (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
2013         (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
2014         (-[WebFrameBridge objectLoadedFromCacheWithURL:response:data:]):
2015         (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
2016         (-[WebFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
2017         (-[WebFrameBridge reportClientRedirectCancelled:]):
2018         (-[WebFrameBridge close]):
2019         (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):
2020         (-[WebFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
2021         (-[WebFrameBridge tokenizerProcessedData]):
2022         (-[WebFrameBridge frameDetached]):
2023         (-[WebFrameBridge didFirstLayout]):
2024         (-[WebFrameBridge notifyIconChanged:]):
2025         (-[WebFrameBridge originalRequestURL]):
2026         (-[WebFrameBridge isLoadTypeReload]):
2027
2028 2006-10-10  Adele Peterson  <adele@apple.com>
2029
2030         Reviewed by Beth.
2031
2032         Removed handleAutoscrollForMouseDragged.  Except for autoscroll caused by drag and drop, all other
2033         autoscrolling should be done in WebCore instead of in AppKit.
2034
2035         * WebCoreSupport/WebFrameBridge.m:
2036         * WebView/WebHTMLView.m:
2037         * WebView/WebHTMLViewPrivate.h:
2038
2039 2006-10-10  Darin Adler  <darin@apple.com>
2040
2041         - corrected an archive regression caused by loader refactoring
2042           (pointed out by Graham Dennis)
2043
2044         * WebView/WebFrame.m: (-[WebFrame _deliverArchivedResourcesAfterDelay]):
2045         Fix selector name.
2046
2047 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
2048
2049         Rubber stamped by Eric.
2050         
2051         - moved a whole bunch of stuff over to WebCore - updated includes appropriately
2052
2053         * Loader/LoaderNSURLExtras.h: Removed.
2054         * Loader/LoaderNSURLExtras.m: Removed.
2055         * Loader/WebDataProtocol.h: Removed.
2056         * Loader/WebDataProtocol.m: Removed.
2057         * Loader/WebDocumentLoader.h: Removed.
2058         * Loader/WebDocumentLoader.m: Removed.
2059         * Loader/WebFormDataStream.h: Removed.
2060         * Loader/WebFormDataStream.m: Removed.
2061         * Loader/WebFormState.h: Removed.
2062         * Loader/WebFormState.m: Removed.
2063         * Loader/WebFrameLoader.h: Removed.
2064         * Loader/WebFrameLoader.m: Removed.
2065         * Loader/WebFrameLoaderClient.h: Removed.
2066         * Loader/WebLoader.h: Removed.
2067         * Loader/WebLoader.m: Removed.
2068         * Loader/WebMainResourceLoader.h: Removed.
2069         * Loader/WebMainResourceLoader.m: Removed.
2070         * Loader/WebNetscapePlugInStreamLoader.h: Removed.
2071         * Loader/WebNetscapePlugInStreamLoader.m: Removed.
2072         * Loader/WebPlugInStreamLoaderDelegate.h: Removed.
2073         * Loader/WebPolicyDecider.h: Removed.
2074         * Loader/WebPolicyDecider.m: Removed.
2075         * Loader/WebSubresourceLoader.h: Removed.
2076         * Loader/WebSubresourceLoader.m: Removed.
2077         * Misc/WebNSURLExtras.m:
2078         * Plugins/WebBaseNetscapePluginStream.h:
2079         * Plugins/WebBaseNetscapePluginView.m:
2080         * Plugins/WebNetscapePluginStream.m:
2081         * Plugins/WebPluginContainerCheck.m:
2082         * Plugins/WebPluginController.m:
2083         * WebCoreSupport/WebFrameBridge.m:
2084         * WebKit.xcodeproj/project.pbxproj:
2085         * WebView/WebDataSource.m:
2086         * WebView/WebDocumentLoaderMac.h:
2087         * WebView/WebFrame.m:
2088         * WebView/WebFrameInternal.h:
2089         * WebView/WebHTMLView.m:
2090         * WebView/WebPolicyDeciderMac.h:
2091         * WebView/WebPolicyDelegate.m:
2092         * WebView/WebView.m:
2093
2094 2006-10-10  Mark Rowe  <bdash@webkit.org>
2095
2096         Reviewed by Maciej.
2097
2098         Fix crash on launch in nightly builds after r16965.
2099
2100         Safari will sometimes call through to -[NSURL _webkit_canonicalize] before creating a WebView.  If this happens,
2101         InitWebCoreSystemInterface has not yet been called so the call to wkNSURLProtocolClassForReqest is via a garbage
2102         pointer.
2103
2104         * Misc/WebNSURLExtras.m:
2105         (-[NSURL _webkit_canonicalize]): Ensure InitWebCoreSystemInterface is called prior to canonicalURL.
2106
2107 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
2108
2109         Reviewed by Oliver.
2110         
2111         - split out some NSURL extras to be moved to WebCore
2112
2113         * Loader/LoaderNSURLExtras.h: Added.
2114         * Loader/LoaderNSURLExtras.m: Added.
2115         (urlByRemovingComponent):
2116         (urlByRemovingFragment):
2117         (urlOriginalDataAsString):
2118         (urlOriginalData):
2119         (urlWithData):
2120         (WebCFAutorelease):
2121         (urlWithDataRelativeToURL):
2122         (urlByRemovingResourceSpecifier):
2123         (urlIsFileURL):
2124         (stringIsFileURL):
2125         (urlIsEmpty):
2126         (canonicalURL):
2127         * Loader/WebFrameLoader.m:
2128         (-[WebFrameLoader shouldReloadForCurrent:andDestination:]):
2129         (setHTTPReferrer):
2130         (-[WebFrameLoader commitProvisionalLoad:]):
2131         (-[WebFrameLoader _notifyIconChanged:]):
2132         (-[WebFrameLoader didChangeTitleForDocument:]):
2133         (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]):
2134         (-[WebFrameLoader safeLoadURL:]):
2135         * Misc/WebNSURLExtras.m:
2136         (+[NSURL _web_URLWithData:]):
2137         (+[NSURL _web_URLWithData:relativeToURL:]):
2138         (-[NSURL _web_originalData]):
2139         (-[NSURL _web_originalDataAsString]):
2140         (-[NSURL _web_isEmpty]):
2141         (-[NSURL _webkit_canonicalize]):
2142         (-[NSURL _webkit_URLByRemovingComponent:]):
2143         (-[NSURL _webkit_URLByRemovingFragment]):
2144         (-[NSURL _webkit_URLByRemovingResourceSpecifier]):
2145         (-[NSURL _webkit_isFileURL]):
2146         (-[NSString _webkit_isFileURL]):
2147         * WebCoreSupport/WebSystemInterface.m:
2148         (InitWebCoreSystemInterface):
2149         * WebKit.xcodeproj/project.pbxproj:
2150
2151 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
2152
2153         Reviewed by Anders.
2154         
2155         - sever final WebFrame dependencies
2156
2157         * Loader/WebFrameLoader.h:
2158         * Loader/WebFrameLoader.m:
2159         (-[WebFrameLoader initWithFrame:client:]):
2160         (-[WebFrameLoader defersCallbacksChanged]):
2161         (-[WebFrameLoader subframeIsLoading]):
2162         (-[WebFrameLoader transitionToCommitted:]):
2163         (-[WebFrameLoader detachChildren]):
2164         (-[WebFrameLoader checkLoadComplete]):
2165
2166 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
2167
2168         Reviewed by Brady.
2169         
2170         - convert more WebFrameLoader stuff to be independent of WebFrame
2171
2172         * Loader/WebFrameLoader.h:
2173         * Loader/WebFrameLoader.m:
2174         (-[WebFrameLoader stopLoadingSubframes]):
2175         (-[WebFrameLoader _receivedMainResourceError:complete:]):
2176         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
2177         (-[WebFrameLoader closeOldDataSources]):
2178         (-[WebFrameLoader isHostedByObjectElement]):
2179         (-[WebFrameLoader isLoadingMainFrame]):
2180         (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
2181         (-[WebFrameLoader transitionToCommitted:]):
2182         (-[WebFrameLoader checkLoadCompleteForThisFrame]):
2183         (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
2184         (-[WebFrameLoader loadRequest:inFrameNamed:]):
2185         (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
2186         (-[WebFrameLoader actionInformationForNavigationType:event:originalURL:]):
2187         (-[WebFrameLoader client]):
2188         * Loader/WebFrameLoaderClient.h:
2189         * WebView/WebDataSource.m:
2190         (-[WebDataSource _webView]):
2191         (-[WebDataSource webFrame]):
2192         * WebView/WebFrame.m:
2193         (-[WebFrame _dispatchCreateWebViewWithRequest:]):
2194
2195 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
2196
2197         Reviewed by Anders and Oliver.
2198         
2199         - move a bunch of WebFrame methods from the Internal category to the WebFrameLoader protocol
2200
2201         * Loader/WebFrameLoader.h:
2202         * Loader/WebFrameLoader.m:
2203         (-[WebFrameLoader loadRequest:]):
2204         (-[WebFrameLoader loadRequest:inFrameNamed:]):
2205         * Loader/WebFrameLoaderClient.h:
2206         * WebView/WebFrame.m:
2207         (-[WebFrame loadRequest:]):
2208         (-[WebFrame _dispatchDidCommitLoadForFrame]):
2209         (-[WebFrame _hasFrameView]):
2210         (-[WebFrame _frameLoadCompleted]):
2211         (-[WebFrame _restoreScrollPositionAndViewState]):
2212         (-[WebFrame _setTitle:forURL:]):
2213         (-[WebFrame _createDocumentLoaderWithRequest:]):
2214         (-[WebFrame _prepareForDataSourceReplacement]):
2215         (-[WebFrame _didFinishLoad]):
2216         (-[WebFrame _addHistoryItemForFragmentScroll]):
2217         (-[WebFrame _shouldTreatURLAsSameAsCurrent:]):
2218         (-[WebFrame _provisionalLoadStarted]):
2219         * WebView/WebFrameInternal.h:
2220
2221 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
2222
2223         Not reviewed, build fix.
2224         
2225         - added forgotten files
2226
2227         * Loader/WebPolicyDecider.h: Added.
2228         * Loader/WebPolicyDecider.m: Added.
2229         (-[WebPolicyDecider invalidate]):
2230
2231 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
2232
2233         Reviewed by Brady.
2234         
2235         - add wrapper for WebPolicyDecisionListener so we can remove the dependency from WebFrameLoader.
2236
2237         * Loader/WebFrameLoader.h:
2238         * Loader/WebFrameLoader.m:
2239         (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]):
2240         (-[WebFrameLoader cancelContentPolicy]):
2241         (-[WebFrameLoader invalidatePendingPolicyDecisionCallingDefaultAction:]):
2242         (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]):
2243         (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]):
2244         (-[WebFrameLoader continueAfterWillSubmitForm:]):
2245         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
2246         * Loader/WebFrameLoaderClient.h:
2247         * WebKit.xcodeproj/project.pbxproj:
2248         * WebView/WebFrame.m:
2249         (-[WebFrame _createPolicyDeciderWithTarget:action:]):
2250         (decisionListener):
2251         (-[WebFrame _dispatchDecidePolicyForMIMEType:request:decider:]):
2252         (-[WebFrame _dispatchDecidePolicyForNewWindowAction:request:newFrameName:decider:]):
2253         (-[WebFrame _dispatchDecidePolicyForNavigationAction:request:decider:]):
2254         (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]):
2255         * WebView/WebPolicyDeciderMac.h: Added.
2256         * WebView/WebPolicyDeciderMac.m: Added.
2257         (-[WebPolicyDeciderMac initWithTarget:action:]):
2258         (-[WebPolicyDeciderMac dealloc]):
2259         (-[WebPolicyDeciderMac decisionListener]):
2260         (-[WebPolicyDeciderMac invalidate]):
2261
2262 2006-10-09  Brady Eidson  <beidson@apple.com>
2263
2264         Reviewed by John
2265
2266         http://bugs.webkit.org/show_bug.cgi?id=11195
2267         Added the WebIconDatabaseDelegate.  This allows the ability to allow customization of 
2268         IconDatabase behavior in the future, starting now with the ability to override the 
2269         default icon fairly flexibly
2270
2271         * Misc/WebIconDatabase.h: Added setIconDatabaseDelegate:
2272         * Misc/WebIconDatabase.m:
2273         (-[WebIconDatabase iconForURL:withSize:cache:]): Call the delegate for the default icon if delegate is set
2274         (-[WebIconDatabase defaultIconForURL:withSize:]): Get the default icon through the delegate if available, built-in if not
2275         (-[WebIconDatabase setDelegate:]):
2276         (-[WebIconDatabase delegate]):
2277         * Misc/WebIconDatabaseDelegate.h: Added.
2278         * Misc/WebIconDatabasePrivate.h: Added the delegate, nuked an unused class definition
2279         * WebKit.xcodeproj/project.pbxproj:
2280
2281 2006-10-09  Darin Adler  <darin@apple.com>
2282
2283         Reviewed by Maciej.
2284
2285         - eliminated uses of WebResource and WebView from WebFrameLoader
2286
2287         * Loader/WebFrameLoader.h:
2288         * Loader/WebFrameLoader.m:
2289         (-[WebFrameLoader setDefersCallbacks:]):
2290         (-[WebFrameLoader stopLoading]):
2291         (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
2292         (-[WebFrameLoader archiveLoadPendingForLoader:]):
2293         (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]):
2294         (-[WebFrameLoader _canShowMIMEType:]):
2295         (-[WebFrameLoader _representationExistsForURLScheme:]):
2296         (-[WebFrameLoader _generatedMIMETypeForURLScheme:]):
2297         (-[WebFrameLoader loadDocumentLoader:]):
2298         (-[WebFrameLoader continueAfterNavigationPolicy:]):
2299         (-[WebFrameLoader sendRemainingDelegateMessagesWithIdentifier:response:length:error:]):
2300         (-[WebFrameLoader actionInformationForNavigationType:event:originalURL:]):
2301         * Loader/WebFrameLoaderClient.h:
2302         * Loader/WebMainResourceLoader.m:
2303         (-[WebMainResourceLoader continueAfterContentPolicy:response:]):
2304         (-[WebMainResourceLoader loadWithRequestNow:]):
2305         * WebView/WebFrame.m:
2306         (-[WebFramePrivate dealloc]):
2307         (-[WebFrame loadRequest:]):
2308         (-[WebFrame loadArchive:]):
2309         (-[WebFrame _canUseResourceForRequest:]):
2310         (-[WebFrame _canUseResourceWithResponse:]):
2311         (-[WebFrame _deliverArchivedResourcesAfterDelay]):
2312         (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]):
2313         (-[WebFrame _archiveLoadPendingForLoader:]):
2314         (-[WebFrame _cancelPendingArchiveLoadForLoader:]):
2315         (-[WebFrame _clearArchivedResources]):
2316         (-[WebFrame _deliverArchivedResources]):
2317         (-[WebFrame _setDefersCallbacks:]):
2318         (-[WebFrame _canHandleRequest:]):
2319         (-[WebFrame _canShowMIMEType:]):
2320         (-[WebFrame _representationExistsForURLScheme:]):
2321         (-[WebFrame _generatedMIMETypeForURLScheme:]):
2322         (-[WebFrame _elementForEvent:]):
2323
2324 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
2325
2326         Reviewed by Darin.
2327         
2328         - do all the stuff that setting the referrer should
2329
2330         * Loader/WebFrameLoader.m:
2331         (setHTTPReferrer):
2332         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
2333         (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
2334         * WebKit.xcodeproj/project.pbxproj:
2335
2336 2006-10-09  Brady Eidson  <beidson@apple.com>
2337
2338         Reviewed by Maciej
2339
2340         Fix to elminate WebIconDatabaseBridge.h from WebFrameLoader
2341
2342         * Loader/WebFrameLoader.m:
2343         (-[WebFrameLoader _notifyIconChanged:]):
2344         * WebCoreSupport/WebIconDatabaseBridge.m:
2345         (+[WebIconDatabaseBridge createInstance]):
2346
2347 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
2348
2349         Reviewed by Darin.
2350         
2351         (Was reviewed as part of a larger patch but it looks like Darin already did the rest of it)
2352         
2353         - avoid a needless use of WebFrame
2354
2355         * Loader/WebFrameLoader.m:
2356         (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
2357
2358 2006-10-09  Brady Eidson  <beidson@apple.com>
2359
2360         A *real* fake fix for the layouttest problem until the real fix
2361
2362         * Loader/WebFrameLoader.m:
2363         (-[WebFrameLoader _notifyIconChanged:]):
2364
2365 2006-10-09  Brady Eidson  <beidson@apple.com>
2366
2367         Quick layouttest fix until I make the real fix
2368
2369         * Loader/WebFrameLoader.m:
2370
2371 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
2372
2373         Reviewed by Darin.
2374         
2375         - wean WebFrameLoader from WebDataSource private stuff
2376         
2377         (actually just tweaks tot he above to make merging my future
2378         patches easier since Darin did a lot of the same stuff)
2379
2380         * Loader/WebDocumentLoader.h:
2381         * Loader/WebDocumentLoader.m:
2382         (-[WebDocumentLoader URLForHistory]):
2383         * Loader/WebFrameLoader.m:
2384         (-[WebFrameLoader _loadRequest:archive:]):
2385         (-[WebFrameLoader revertToProvisionalWithDocumentLoader:]):
2386         (-[WebFrameLoader documentLoader:setMainDocumentError:]):
2387         (-[WebFrameLoader finalSetupForReplaceWithDocumentLoader:]):
2388         (-[WebFrameLoader didChangeTitleForDocument:]):
2389         (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
2390         * Loader/WebFrameLoaderClient.h:
2391         * WebView/WebDataSource.m:
2392         (-[WebDataSource _URLForHistory]):
2393         * WebView/WebFrame.m:
2394         (-[WebFrame _addDocumentLoader:toUnarchiveState:]):
2395         (-[WebFrame _revertToProvisionalStateForDocumentLoader:]):
2396         (-[WebFrame _setMainDocumentError:forDocumentLoader:]):
2397         (-[WebFrame _clearUnarchivingStateForLoader:]):
2398
2399 2006-10-09  Darin Adler  <darin@apple.com>
2400
2401         Reviewed by Brady.
2402
2403         - eliminated WebFrameLoader dependency on WebDataSourceInternal.h,
2404           WebIconDatabasePrivate.h, and WebKitErrorsPrivate.h, along with
2405           most but not all references to WebView
2406
2407         * Loader/WebFrameLoader.h:
2408         * Loader/WebFrameLoader.m:
2409         (-[WebFrameLoader removePlugInStreamLoader:]):
2410         (-[WebFrameLoader _receivedMainResourceError:complete:]):
2411         (-[WebFrameLoader _notifyIconChanged:]):
2412         (-[WebFrameLoader cancelledErrorWithRequest:]):
2413         (-[WebFrameLoader fileDoesNotExistErrorWithResponse:]):
2414         (-[WebFrameLoader handleUnimplementablePolicyWithError:]):
2415         (-[WebFrameLoader cannotShowMIMETypeWithResponse:]):
2416         (-[WebFrameLoader interruptForPolicyChangeErrorWithRequest:]):
2417         (-[WebFrameLoader _loadRequest:archive:]):
2418         (-[WebFrameLoader finishedLoadingDocument:]):
2419         (-[WebFrameLoader committedLoadWithDocumentLoader:data:]):
2420         (-[WebFrameLoader revertToProvisionalWithDocumentLoader:]):
2421         (-[WebFrameLoader documentLoader:setMainDocumentError:]):
2422         (-[WebFrameLoader finalSetupForReplaceWithDocumentLoader:]):
2423         (-[WebFrameLoader didChangeTitleForDocument:]):
2424         (-[WebFrameLoader continueAfterNavigationPolicy:]):
2425         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
2426         (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
2427         (-[WebFrameLoader transitionToCommitted:]):
2428         (-[WebFrameLoader checkLoadCompleteForThisFrame]):
2429         (-[WebFrameLoader requestFromDelegateForRequest:identifier:error:]):
2430         (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
2431         (-[WebFrameLoader checkLoadComplete]):
2432         * Loader/WebFrameLoaderClient.h:
2433         * Loader/WebMainResourceLoader.m:
2434         (-[WebMainResourceLoader continueAfterContentPolicy:response:]):
2435         * WebView/WebFrame.m:
2436         (-[WebFrame _addDocumentLoader:toUnarchiveState:]):
2437         (-[WebFrame _formDelegate]):
2438         (-[WebFrame _finishedLoadingDocument:]):
2439         (-[WebFrame _committedLoadWithDocumentLoader:data:]):
2440         (-[WebFrame _revertToProvisionalWithDocumentLoader:]):
2441         (-[WebFrame _documentLoader:setMainDocumentError:]):
2442         (-[WebFrame _finalSetupForReplaceWithDocumentLoader:]):
2443         (-[WebFrame _URLForHistoryForDocumentLoader:]):
2444         (-[WebFrame _cancelledErrorWithRequest:]):
2445         (-[WebFrame _cannotShowURLErrorWithRequest:]):
2446         (-[WebFrame _interruptForPolicyChangeErrorWithRequest:]):
2447         (-[WebFrame _cannotShowMIMETypeErrorWithResponse:]):
2448         (-[WebFrame _fileDoesNotExistErrorWithResponse:]):
2449         (-[WebFrame _shouldFallBackForError:]):
2450         (-[WebFrame _hasWebView]):
2451         (-[WebFrame _mainFrameURL]):
2452         * WebView/WebFrameInternal.h:
2453
2454 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
2455
2456         Reviewed, landed, tweaked a bit by Darin.
2457
2458         - removed most uses of WebFrameBridge from WebFrameLoader
2459           (WebCoreFrameBridge use is OK)
2460
2461         * Loader/WebDocumentLoader.m:
2462         (-[WebDocumentLoader bridge]):
2463         * Loader/WebFrameLoader.h:
2464         * Loader/WebFrameLoader.m:
2465         (-[WebFrameLoader initWithFrame:client:]):
2466         (-[WebFrameLoader defersCallbacksChanged]):
2467         (-[WebFrameLoader defersCallbacks]):
2468         (-[WebFrameLoader provisionalLoadStarted]):
2469         (-[WebFrameLoader stopLoadingSubframes]):
2470         (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]):
2471         (-[WebFrameLoader _receivedMainResourceError:complete:]):
2472         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
2473         (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]):
2474         (-[WebFrameLoader closeOldDataSources]):
2475         (-[WebFrameLoader commitProvisionalLoad:]):
2476         (-[WebFrameLoader bridge]):
2477         (-[WebFrameLoader _handleFallbackContent]):
2478         (-[WebFrameLoader _finishedLoading]):
2479         (-[WebFrameLoader reload]):
2480         (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]):
2481         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
2482         (-[WebFrameLoader transitionToCommitted:]):
2483         (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
2484         (-[WebFrameLoader loadRequest:inFrameNamed:]):
2485         (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
2486         (-[WebFrameLoader detachFromParent]):
2487         (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
2488         (-[WebFrameLoader safeLoadURL:]):
2489         (-[WebFrameLoader actionInformationForLoadType:isFormSubmission:event:originalURL:]):
2490         * WebCoreSupport/WebFrameBridge.m:
2491         (-[WebFrameBridge initMainFrameWithPage:frameName:view:]):
2492         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
2493         * WebView/WebFrame.m:
2494         (-[WebFrame _atMostOneFrameHasSelection]):
2495         * WebView/WebFrameInternal.h:
2496
2497 2006-10-09  Darin Adler  <darin@apple.com>
2498
2499         Reviewed by Brady.
2500
2501         - removed almost all direct use of WebView from WebFrameLoader
2502
2503         * Loader/WebFrameLoader.m:
2504         (-[WebFrameLoader defersCallbacksChanged]):
2505         (-[WebFrameLoader defersCallbacks]):
2506         (-[WebFrameLoader clearProvisionalLoad]):
2507         (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]):
2508         (-[WebFrameLoader _didReceiveResponse:forResource:]):
2509         (-[WebFrameLoader _didReceiveData:contentLength:forResource:]):
2510         (-[WebFrameLoader _didFinishLoadingForResource:]):
2511         (-[WebFrameLoader _didFailLoadingWithError:forResource:]):
2512         (-[WebFrameLoader closeOldDataSources]):
2513         (-[WebFrameLoader _notifyIconChanged:]):
2514         (-[WebFrameLoader prepareForLoadStart]):
2515         (-[WebFrameLoader willChangeTitleForDocument:]):
2516         (-[WebFrameLoader didChangeTitleForDocument:]):
2517         (-[WebFrameLoader continueAfterNewWindowPolicy:]):
2518         (-[WebFrameLoader continueAfterNavigationPolicy:]):
2519         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
2520         (-[WebFrameLoader didFirstLayout]):
2521         (-[WebFrameLoader transitionToCommitted:]):
2522         (-[WebFrameLoader checkLoadCompleteForThisFrame]):
2523         (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
2524         * Loader/WebFrameLoaderClient.h:
2525         * WebKit.xcodeproj/project.pbxproj:
2526         * WebView/WebFrame.m:
2527         (-[WebFrame _currentBackForwardListItemToResetTo]):
2528         (-[WebFrame _hasBackForwardList]):
2529         (-[WebFrame _resetBackForwardList]):
2530         (-[WebFrame _dispatchDidReceiveIcon:]):
2531         (-[WebFrame _dispatchDidStartProvisionalLoadForFrame]):
2532         (-[WebFrame _dispatchDidCommitLoadForFrame]):
2533         (-[WebFrame _dispatchDidFailProvisionalLoadWithError:]):
2534         (-[WebFrame _dispatchDidFailLoadWithError:]):
2535         (-[WebFrame _dispatchDidFinishLoadForFrame]):
2536         (-[WebFrame _progressStarted]):
2537         (-[WebFrame _progressCompleted]):
2538         (-[WebFrame _incrementProgressForIdentifier:response:]):
2539         (-[WebFrame _incrementProgressForIdentifier:data:]):
2540         (-[WebFrame _completeProgressForIdentifier:]):
2541         (-[WebFrame _setMainFrameDocumentReady:]):
2542         (-[WebFrame _willChangeTitleForDocument:]):
2543         (-[WebFrame _didChangeTitleForDocument:]):
2544         (-[WebFrame _startDownloadWithRequest:]):
2545
2546 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
2547
2548         Reviewed by Alice.
2549
2550         - moved WebFormState into Loader directory and tweaked to avoid WebKit dependencies
2551         
2552         * Loader/WebDocumentLoader.h:
2553         * Loader/WebFormState.h: Added.
2554         * Loader/WebFormState.m: Added.
2555         (-[WebFormState initWithForm:values:sourceFrame:]):
2556         (-[WebFormState dealloc]):
2557         (-[WebFormState form]):
2558         (-[WebFormState values]):
2559         (-[WebFormState sourceFrame]):
2560         * Loader/WebFrameLoader.h:
2561         * Loader/WebFrameLoader.m:
2562         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
2563         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
2564         (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
2565         * WebKit.xcodeproj/project.pbxproj:
2566         * WebView/WebFrame.m:
2567         * WebView/WebFrameInternal.h:
2568
2569 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
2570
2571         Reviewed by Oliver.
2572
2573         - remove dependency on WebNSURLRequestExtras.h
2574         
2575         * Loader/WebFrameLoader.h:
2576         * Loader/WebFrameLoader.m:
2577         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
2578         (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
2579         (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
2580
2581 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
2582
2583         Reviewed by Oliver.
2584         
2585         - removed unneeded logging code so I can take WebKitLogging.h out and remove a WebKit dependency
2586
2587         * Loader/WebFrameLoader.m:
2588         (-[WebFrameLoader setState:]):
2589         (-[WebFrameLoader clientRedirectCancelledOrFinished:]):
2590         (-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
2591         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
2592         (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]):
2593         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
2594         (-[WebFrameLoader checkLoadCompleteForThisFrame]):
2595
2596 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
2597
2598         Reviewed by Oliver.
2599         
2600         - remove WebDataSource from the WebFrameLoader interface (and thereby from a lot of internal use)
2601
2602         * Loader/WebDocumentLoader.h:
2603         * Loader/WebDocumentLoader.m:
2604         (-[WebDocumentLoader dealloc]):
2605         (-[WebDocumentLoader initialRequest]):
2606         (-[WebDocumentLoader URL]):
2607         (-[WebDocumentLoader unreachableURL]):
2608         * Loader/WebFrameLoader.h:
2609         * Loader/WebFrameLoader.m:
2610         (-[WebFrameLoader setState:]):
2611         (-[WebFrameLoader startLoading]):
2612         (-[WebFrameLoader startProvisionalLoad:]):
2613         (-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
2614         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
2615         (-[WebFrameLoader opened]):
2616         (-[WebFrameLoader commitProvisionalLoad:]):
2617         (-[WebFrameLoader initialRequest]):
2618         (-[WebFrameLoader _finishedLoading]):
2619         (-[WebFrameLoader _notifyIconChanged:]):
2620         (-[WebFrameLoader _URL]):
2621         (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
2622         (-[WebFrameLoader _checkNavigationPolicyForRequest:andCall:withSelector:]):
2623         (-[WebFrameLoader shouldReloadToHandleUnreachableURLFromRequest:]):
2624         (-[WebFrameLoader _loadRequest:archive:]):
2625         (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
2626         (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]):
2627         (-[WebFrameLoader reload]):
2628         (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]):
2629         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
2630         (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
2631         (-[WebFrameLoader frameLoadCompleted]):
2632         (-[WebFrameLoader transitionToCommitted:]):
2633         (-[WebFrameLoader checkLoadCompleteForThisFrame]):
2634         (-[WebFrameLoader safeLoadURL:]):
2635         * Loader/WebFrameLoaderClient.h:
2636         * Plugins/WebBaseNetscapePluginView.m:
2637         (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
2638         * WebCoreSupport/WebFrameBridge.m:
2639         (-[WebFrameBridge originalRequestURL]):
2640         * WebView/WebDataSource.m:
2641         (-[WebDataSource _URL]):
2642         (-[WebDataSource dealloc]):
2643         (-[WebDataSource initialRequest]):
2644         (-[WebDataSource unreachableURL]):
2645         * WebView/WebFrame.m:
2646         (-[WebFrame _loadItem:withLoadType:]):
2647         (-[WebFrame _prepareForDataSourceReplacement]):
2648         (-[WebFrame provisionalDataSource]):
2649         (-[WebFrame dataSource]):
2650         (-[WebFrame _makeDocumentView]):
2651         (-[WebFrame _updateHistoryForReload]):
2652         (-[WebFrame _updateHistoryForStandardLoad]):
2653         (-[WebFrame _updateHistoryForInternalLoad]):
2654         (-[WebFrame _forceLayoutForNonHTML]):
2655         (-[WebFrame _clearLoadingFromPageCacheForDocumentLoader:]):
2656         (-[WebFrame _isDocumentLoaderLoadingFromPageCache:]):
2657         (-[WebFrame _archivedSubresourceForURL:fromDocumentLoader:]):
2658         (-[WebFrame _makeRepresentationForDocumentLoader:]):
2659
2660 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
2661
2662         Reviewed by Darin.
2663
2664         - removed need for WebFrameLoader to now about WebDocumentLoaderMac 
2665
2666         * Loader/WebFrameLoader.m:
2667         (-[WebFrameLoader loadDataSource:withLoadType:formState:]):
2668         * WebView/WebDocumentLoaderMac.h:
2669         * WebView/WebDocumentLoaderMac.m:
2670         (-[WebDocumentLoaderMac setFrameLoader:]):
2671         (-[WebDocumentLoaderMac detachFromFrameLoader]):
2672
2673 2006-10-09  Darin Adler  <darin@apple.com>
2674
2675         Reviewed by Maciej.
2676
2677         - passed calls that require WebScriptDebugServer across the client interface
2678
2679         * Loader/WebFrameLoader.m:
2680         (-[WebFrameLoader _finishedLoading]):
2681         (-[WebFrameLoader documentLoader:mainReceivedCompleteError:]):
2682         * Loader/WebFrameLoaderClient.h:
2683         * WebView/WebFrame.m:
2684         (-[WebFrame _dispatchDidLoadMainResourceForDocumentLoader:]):
2685
2686 2006-10-08  Darin Adler  <darin@apple.com>
2687
2688         Reviewed by Maciej.
2689
2690         - passed calls that require WebHTMLView or WebFrameView calls across
2691           the client interface
2692
2693         * Loader/WebFrameLoader.h:
2694         * Loader/WebFrameLoader.m:
2695         (isCaseInsensitiveEqual):
2696         (isBackForwardLoadType):
2697         (-[WebFrameLoader opened]):
2698         (-[WebFrameLoader cancelledErrorWithRequest:]):
2699         (-[WebFrameLoader fileDoesNotExistErrorWithResponse:]):
2700         (-[WebFrameLoader reload]):
2701         (-[WebFrameLoader transitionToCommitted:]):
2702         * Loader/WebFrameLoaderClient.h:
2703         * WebView/WebFrame.m:
2704         (-[WebFrame _forceLayout]):
2705         (-[WebFrame _setDocumentViewFromPageCache:]):
2706         (-[WebFrame _setCopiesOnScroll]):
2707
2708 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
2709
2710         Reviewed by Darin.
2711         
2712         - pass remaining delegate methods across client interface
2713
2714         * Loader/WebFrameLoader.m:
2715         (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]):
2716         (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]):
2717         (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]):
2718         (-[WebFrameLoader handleUnimplementablePolicyWithErrorCode:forURL:]):
2719         (-[WebFrameLoader didFirstLayout]):
2720         (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
2721         * Loader/WebFrameLoaderClient.h:
2722         * WebView/WebFrame.m:
2723         (-[WebFrame _dispatchDidFirstLayoutInFrame]):
2724         (-[WebFrame _dispatchCreateWebViewWithRequest:]):
2725         (-[WebFrame _dispatchShow]):
2726         (-[WebFrame _dispatchDecidePolicyForMIMEType:request:decisionListener:]):
2727         (-[WebFrame _dispatchDecidePolicyForNewWindowAction:request:newFrameName:decisionListener:]):
2728         (-[WebFrame _dispatchDecidePolicyForNavigationAction:request:decisionListener:]):
2729         (-[WebFrame _dispatchUnableToImplementPolicyWithError:]):
2730
2731 2006-10-08  Darin Adler  <darin@apple.com>
2732
2733         Reviewed by Maciej.
2734
2735         - use WebCoreSystemInterface instead of WebSystemInterface in Loader directory
2736
2737         * Loader/WebFrameLoader.m: Update includes.
2738         (-[WebFrameLoader commitProvisionalLoad:]): Use wk calls istead of WK.
2739         (-[WebFrameLoader _canUseResourceWithResponse:]): Ditto.
2740
2741         * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
2742         Added the three new symbols, and resorted the list.
2743
2744         * Loader/WebDataProtocol.m:
2745         * Loader/WebLoader.m:
2746         * Loader/WebMainResourceLoader.h:
2747         * Loader/WebMainResourceLoader.m:
2748         * Loader/WebNetscapePlugInStreamLoader.h:
2749         * Loader/WebNetscapePlugInStreamLoader.m:
2750         * Loader/WebSubresourceLoader.h:
2751         * Loader/WebSubresourceLoader.m:
2752         Changed import statements to consistently use the "" format.
2753
2754 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
2755
2756         Not reviewed.
2757         
2758         - fix accidental build break due to editing while committing
2759
2760         * Loader/WebFrameLoader.m:
2761
2762 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
2763
2764         Reviewed by Darin.
2765         
2766         - move all WebFrameLoadDelegate methods across client interface
2767
2768         * Loader/WebFrameLoader.m:
2769         (-[WebFrameLoader clientRedirectCancelledOrFinished:]):
2770         (-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
2771         (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]):
2772         (-[WebFrameLoader closeOldDataSources]):
2773         (-[WebFrameLoader _notifyIconChanged:]):
2774         (-[WebFrameLoader prepareForLoadStart]):
2775         (-[WebFrameLoader didChangeTitleForDocument:]):
2776         (-[WebFrameLoader transitionToCommitted:]):
2777         (-[WebFrameLoader checkLoadCompleteForThisFrame]):
2778         * Loader/WebFrameLoaderClient.h:
2779         * WebView/WebFrame.m:
2780         (-[WebFrame _dispatchDidCancelClientRedirectForFrame]):
2781         (-[WebFrame _dispatchWillPerformClientRedirectToURL:delay:fireDate:]):
2782         (-[WebFrame _dispatchDidChangeLocationWithinPageForFrame]):
2783         (-[WebFrame _dispatchWillCloseFrame]):
2784         (-[WebFrame _dispatchDidReceiveIcon:]):
2785         (-[WebFrame _dispatchDidStartProvisionalLoadForFrame]):
2786         (-[WebFrame _dispatchDidReceiveTitle:]):
2787         (-[WebFrame _dispatchDidCommitLoadForFrame]):
2788         (-[WebFrame _dispatchDidFailProvisionalLoadWithError:]):
2789         (-[WebFrame _dispatchDidFailLoadWithError:]):
2790         (-[WebFrame _dispatchDidFinishLoadForFrame]):
2791
2792 2006-10-08  Darin Adler  <darin@apple.com>
2793
2794         Reviewed by Maciej.
2795
2796         - removed some of the WebKit dependencies in WebFrameLoader
2797
2798         * Loader/WebFrameLoader.m:
2799         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
2800         (-[WebFrameLoader _downloadWithLoadingConnection:request:response:proxy:]):
2801         (-[WebFrameLoader reload]):
2802         (-[WebFrameLoader didChangeTitleForDocument:]):
2803         * Loader/WebFrameLoaderClient.h:
2804         * WebView/WebFrame.m:
2805         (-[WebFrame _loadItem:withLoadType:]):
2806         (-[WebFrame _loadURL:referrer:intoChild:]):
2807         (-[WebFrame _setTitle:forURL:]):
2808         (-[WebFrame _downloadWithLoadingConnection:request:response:proxy:]):
2809         * WebView/WebFrameInternal.h:
2810
2811         - some other tweaks
2812
2813         * Misc/WebNSURLRequestExtras.m:
2814         (-[NSMutableURLRequest _web_setHTTPReferrer:]):
2815         (-[NSMutableURLRequest _web_setHTTPUserAgent:]):
2816
2817 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
2818
2819         Reviewed by Darin.
2820         
2821         - pass all WebResourceLoadDelegate methods across client, removing need to include related headers
2822
2823         * Loader/WebFrameLoader.m:
2824         (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]):
2825         (-[WebFrameLoader _didReceiveAuthenticationChallenge:forResource:]):
2826         (-[WebFrameLoader _didCancelAuthenticationChallenge:forResource:]):
2827         (-[WebFrameLoader _didReceiveResponse:forResource:]):
2828         (-[WebFrameLoader _didReceiveData:contentLength:forResource:]):
2829         (-[WebFrameLoader _didFinishLoadingForResource:]):
2830         (-[WebFrameLoader _didFailLoadingWithError:forResource:]):
2831         (-[WebFrameLoader sendRemainingDelegateMessagesWithIdentifier:response:length:error:]):
2832         (-[WebFrameLoader requestFromDelegateForRequest:identifier:error:]):
2833         * Loader/WebFrameLoaderClient.h:
2834         * WebView/WebFrame.m:
2835         (-[WebFrame _dispatchDidHandleOnloadEventsForFrame]):
2836         (-[WebFrame _dispatchDidReceiveServerRedirectForProvisionalLoadForFrame]):
2837         (-[WebFrame _dispatchIdentifierForInitialRequest:fromDocumentLoader:]):
2838         (-[WebFrame _dispatchResource:willSendRequest:redirectResponse:fromDocumentLoader:]):
2839         (-[WebFrame _dispatchDidReceiveAuthenticationChallenge:forResource:fromDocumentLoader:]):
2840         (-[WebFrame _dispatchDidCancelAuthenticationChallenge:forResource:fromDocumentLoader:]):
2841         (-[WebFrame _dispatchResource:didReceiveResponse:fromDocumentLoader:]):
2842         (-[WebFrame _dispatchResource:didReceiveContentLength:fromDocumentLoader:]):
2843         (-[WebFrame _dispatchResource:didFinishLoadingFromDocumentLoader:]):
2844         (-[WebFrame _dispatchResource:didFailLoadingWithError:fromDocumentLoader:]):
2845
2846 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
2847
2848         Reviewed by Darin.
2849         
2850         - started adding some _dispatch methods to WebFrameLoaderClient for delegate dispatch
2851
2852         * Loader/WebFrameLoader.m:
2853         (-[WebFrameLoader startLoading]):
2854         (-[WebFrameLoader didReceiveServerRedirectForProvisionalLoadForFrame]):
2855         * Loader/WebFrameLoaderClient.h:
2856         * WebCoreSupport/WebFrameBridge.m:
2857         (-[WebFrameBridge handledOnloadEvents]):
2858         * WebView/WebFrame.m:
2859         (dataSource):
2860         (-[WebFrame _dataSourceForDocumentLoader:]):
2861         (-[WebFrame _dispatchDidHandleOnloadEventsForFrame]):
2862         (-[WebFrame _dispatchDidReceiveServerRedirectForProvisionalLoadForFrame]):
2863         (-[WebFrame _dispatchIdentifierForInitialRequest:fromDocumentLoader:]):
2864         * WebView/WebFrameInternal.h:
2865
2866 2006-10-08  Darin Adler  <darin@apple.com>
2867
2868         Reviewed by Maciej.
2869
2870         - moved more methods to WebFrameLoader from WebFrame
2871
2872         * Loader/WebFrameLoader.h:
2873         * Loader/WebFrameLoader.m:
2874         (-[WebFrameLoader defersCallbacksChanged]):
2875         (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]):
2876         (-[WebFrameLoader setState:]):
2877         (-[WebFrameLoader clearProvisionalLoad]):
2878         (-[WebFrameLoader markLoadComplete]):
2879         (-[WebFrameLoader commitProvisionalLoad]):
2880         (-[WebFrameLoader stopLoading]):
2881         (-[WebFrameLoader startProvisionalLoad:]):
2882         (-[WebFrameLoader setupForReplace]):
2883         (-[WebFrameLoader _identifierForInitialRequest:]):
2884         (-[WebFrameLoader _finishedLoadingResource]):
2885         (-[WebFrameLoader _receivedError:]):
2886         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
2887         (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]):
2888         (-[WebFrameLoader opened]):
2889         (-[WebFrameLoader commitProvisionalLoad:]):
2890         (-[WebFrameLoader _finishedLoading]):
2891         (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
2892         (-[WebFrameLoader _loadRequest:archive:]):
2893         (-[WebFrameLoader reload]):
2894         (-[WebFrameLoader documentLoader:mainReceivedCompleteError:]):
2895         (-[WebFrameLoader subframeIsLoading]):
2896         (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]):
2897         (-[WebFrameLoader continueAfterNewWindowPolicy:]):
2898         (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]):
2899         (-[WebFrameLoader sendRemainingDelegateMessagesWithIdentifier:response:length:error:]):
2900         (-[WebFrameLoader loadRequest:inFrameNamed:]):
2901         (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
2902         (-[WebFrameLoader detachChildren]):
2903         (-[WebFrameLoader detachFromParent]):
2904         (-[WebFrameLoader addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
2905         (-[WebFrameLoader safeLoadURL:]):
2906         (-[WebFrameLoader actionInformationForLoadType:isFormSubmission:event:originalURL:]):
2907         (-[WebFrameLoader actionInformationForNavigationType:event:originalURL:]):
2908         (-[WebFrameLoader checkLoadComplete]):
2909         * Loader/WebFrameLoaderClient.h:
2910         * Loader/WebSubresourceLoader.m:
2911         (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]):
2912         * WebCoreSupport/WebFrameBridge.m:
2913         (-[WebFrameBridge close]):
2914         (-[WebFrameBridge tokenizerProcessedData]):
2915         (-[WebFrameBridge frameDetached]):
2916         * WebView/WebDataSourceInternal.h:
2917         * WebView/WebFrame.m:
2918         (-[WebFrame _loadItem:withLoadType:]):
2919         (-[WebFrame _prepareForDataSourceReplacement]):
2920         (-[WebFrame _detachedFromParent1]):
2921         (-[WebFrame _detachedFromParent2]):
2922         (-[WebFrame _detachedFromParent3]):
2923         (-[WebFrame _detachedFromParent4]):
2924         (-[WebFrame _updateHistoryAfterClientRedirect]):
2925         (-[WebFrame _loadedFromPageCache]):
2926         * WebView/WebFrameInternal.h:
2927         * WebView/WebPDFView.m:
2928         (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
2929         * WebView/WebView.m:
2930         (-[WebView _close]):
2931         (-[WebView setDefersCallbacks:]):
2932
2933 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
2934
2935         Reviewed by Darin.
2936         
2937         - avoid need for WebKitSystemInterface in loader code, via WebCore cover for wkSupportsMultipartXMixedReplace
2938
2939         * Loader/WebDocumentLoader.m:
2940         (-[WebDocumentLoader initWithRequest:]):
2941         * Loader/WebMainResourceLoader.m:
2942         * Loader/WebSubresourceLoader.m:
2943         (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]):
2944         * WebCoreSupport/WebSystemInterface.m:
2945         (InitWebCoreSystemInterface):
2946         * WebView/WebDataSource.m:
2947         (-[WebDataSource _initWithDocumentLoader:]):
2948
2949 2006-10-08  Darin Adler  <darin@apple.com>
2950
2951         - build fix (also a fix for a crasher I forgot to commit before)
2952
2953         * Loader/WebFrameLoader.m: Added some missing includes.
2954         (-[WebFrameLoader checkLoadCompleteForThisFrame]):
2955         Added a needed retain/release.
2956
2957 2006-10-08  Darin Adler  <darin@apple.com>
2958
2959         Reviewed by Anders.
2960         
2961         - quick fix to loader problem causing layout test failures
2962
2963         * Loader/WebFrameLoader.m:
2964         (-[WebFrameLoader _finishedLoading]): Use a local variable for the bridge
2965         that we retain/release.
2966         (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
2967         Same here.
2968
2969 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
2970
2971         Reviewed by Adam.
2972         
2973         - removed a few includes from WebFrameLoader, fixed up as appropriate
2974         - segregated header includes into ones that need to go away to move the code and ones that don't
2975
2976         * Loader/WebFrameLoader.m:
2977         (-[WebFrameLoader _privateBrowsingEnabled]):
2978         (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
2979         * Loader/WebFrameLoaderClient.h:
2980         * WebView/WebFrame.m:
2981         (-[WebFrame _privateBrowsingEnabled]):
2982
2983 2006-10-08  Darin Adler  <darin@apple.com>
2984
2985         Reviewed by Maciej.
2986
2987         - moved a few methods from WebFrame to WebFrameLoader
2988
2989         * Loader/WebFrameLoader.h:
2990         * Loader/WebFrameLoader.m:
2991         (-[WebFrameLoader _setState:]):
2992         (-[WebFrameLoader stopLoadingSubframes]):
2993         (-[WebFrameLoader _receivedMainResourceError:complete:]):
2994         (-[WebFrameLoader closeOldDataSources]):
2995         (-[WebFrameLoader commitProvisionalLoad:]):
2996         (-[WebFrameLoader _finishedLoading]):
2997         (isBackForwardLoadType):
2998         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
2999         (-[WebFrameLoader didFirstLayout]):
3000         (-[WebFrameLoader frameLoadCompleted]):
3001         (-[WebFrameLoader transitionToCommitted:]):
3002         (-[WebFrameLoader checkLoadCompleteForThisFrame]):
3003         (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
3004         (-[WebFrameLoader sendRemainingDelegateMessagesWithIdentifier:response:length:error:]):
3005         (-[WebFrameLoader requestFromDelegateForRequest:identifier:error:]):
3006         (-[WebFrameLoader loadRequest:inFrameNamed:]):
3007         (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
3008         * Loader/WebFrameLoaderClient.h:
3009         * Plugins/WebPluginController.m:
3010         (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]):
3011         * WebCoreSupport/WebFrameBridge.h:
3012         * WebCoreSupport/WebFrameBridge.m:
3013         (-[WebFrameBridge initMainFrameWithPage:frameName:view:]):
3014         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
3015         (-[WebFrameBridge dealloc]):
3016         (-[WebFrameBridge frameLoader]):
3017         (-[WebFrameBridge setTitle:]):
3018         (-[WebFrameBridge receivedData:textEncodingName:]):
3019         (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
3020         (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
3021         (-[WebFrameBridge objectLoadedFromCacheWithURL:response:data:]):
3022         (-[WebFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
3023         (-[WebFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
3024         (-[WebFrameBridge reportClientRedirectCancelled:]):
3025         (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):
3026         (-[WebFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
3027         (-[WebFrameBridge didFirstLayout]):
3028         (-[WebFrameBridge notifyIconChanged:]):
3029         (-[WebFrameBridge originalRequestURL]):
3030         (-[WebFrameBridge isLoadTypeReload]):
3031         * WebView/WebFrame.m:
3032         (-[WebFrame _opened]):
3033         (-[WebFrame _checkLoadComplete]):
3034         (-[WebFrame _loadItem:withLoadType:]):
3035         (-[WebFrame _actionInformationForLoadType:isFormSubmission:event:originalURL:]):
3036         (-[WebFrame _loadURL:referrer:intoChild:]):
3037         (-[WebFrame _currentBackForwardListItemToResetTo]):
3038         (-[WebFrame _updateBackground]):
3039         (-[WebFrame _frameLoader]):
3040         (-[WebFrame _frameLoadCompleted]):
3041         (-[WebFrame _makeDocumentView]):
3042         (-[WebFrame _updateHistoryForCommit]):
3043         (-[WebFrame _updateHistoryForReload]):
3044         (-[WebFrame _updateHistoryForStandardLoad]):
3045         (-[WebFrame _updateHistoryForBackForwardNavigation]):
3046         (-[WebFrame _updateHistoryForInternalLoad]):
3047         (-[WebFrame _tokenForLoadErrorReset]):
3048         (-[WebFrame _resetAfterLoadError:]):
3049         (-[WebFrame _doNotResetAfterLoadError:]):
3050         * WebView/WebFrameInternal.h:
3051
3052 2006-10-09  Mark Rowe  <bdash@webkit.org>
3053
3054         Rubber-stamped by Darin.
3055
3056         * WebCoreSupport/WebFrameBridge.m:
3057         (-[WebFrameBridge imageTitleForFilename:size:]): Revert accidental change to a UI_STRING that
3058         is triggering an assertion failure.
3059
3060 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
3061
3062         Reviewed by Darin.
3063         
3064         - remove unneeded non-Loader header includes from WebFrameLoader.h (split WebFrameLoadType into
3065         two coincidentally matching enums)
3066
3067         * Loader/WebFrameLoader.h:
3068         * Loader/WebFrameLoader.m:
3069         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
3070         (-[WebFrameLoader commitProvisionalLoad:]):
3071         (isBackForwardLoadType):
3072         (-[WebFrameLoader _loadRequest:archive:]):
3073         (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
3074         (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]):
3075         (-[WebFrameLoader reload]):
3076         (-[WebFrameLoader isReplacing]):
3077         (-[WebFrameLoader setReplacing]):
3078         (-[WebFrameLoader loadType]):
3079         (-[WebFrameLoader setLoadType:]):
3080         (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]):
3081         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
3082         (-[WebFrameLoader loadDataSource:withLoadType:formState:]):
3083         (-[WebFrameLoader didFirstLayout]):
3084         * WebCoreSupport/WebFrameBridge.m:
3085         * WebView/WebFrame.m:
3086         (-[WebFrame _transitionToCommitted:]):
3087         (-[WebFrame _provisionalLoadStarted]):
3088         (-[WebFrame _opened]):
3089         (-[WebFrame _checkLoadCompleteForThisFrame]):
3090         (-[WebFrame _loadItem:withLoadType:]):
3091         (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]):
3092         (-[WebFrame _goToItem:withLoadType:]):
3093         (-[WebFrame _actionInformationForLoadType:isFormSubmission:event:originalURL:]):
3094         (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
3095         (-[WebFrame _loadURL:referrer:intoChild:]):
3096         (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
3097         (-[WebFrame _currentBackForwardListItemToResetTo]):
3098         (-[WebFrame _itemForRestoringDocState]):
3099         (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
3100         (-[WebFrame _loadType]):
3101         (-[WebFrame loadRequest:]):
3102         * WebView/WebFrameInternal.h:
3103         * WebView/WebView.m:
3104
3105 2006-10-08  Darin Adler  <darin@apple.com>
3106
3107         Reviewed by Maciej.
3108
3109         - move WebFrameLoader creation and ownership from WebFrame to WebFrameBridge
3110
3111         * Loader/WebFrameLoader.m:
3112         (-[WebFrameLoader stopLoadingSubframes]):
3113         (-[WebFrameLoader closeOldDataSources]):
3114         * WebCoreSupport/WebFrameBridge.h:
3115         * WebCoreSupport/WebFrameBridge.m:
3116         (-[WebFrameBridge initMainFrameWithPage:frameName:view:]):
3117         (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
3118         (-[WebFrameBridge dealloc]):
3119         (-[WebFrameBridge loader]):
3120         (-[WebFrameBridge setTitle:]):
3121         (-[WebFrameBridge receivedData:textEncodingName:]):
3122         (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
3123         (-[WebFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
3124         (-[WebFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
3125         (-[WebFrameBridge reportClientRedirectCancelled:]):
3126         (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):
3127         (-[WebFrameBridge didFirstLayout]):
3128         (-[WebFrameBridge imageTitleForFilename:size:]):
3129         (-[WebFrameBridge notifyIconChanged:]):
3130         (-[WebFrameBridge originalRequestURL]):
3131         (-[WebFrameBridge isLoadTypeReload]):
3132         * WebView/WebFrame.m:
3133         (-[NSView setWebFrame::]):
3134         (-[WebFramePrivate dealloc]):
3135         (-[WebFramePrivate setWebFrameView:]):
3136         (-[WebFramePrivate setProvisionalItem:]):
3137         (-[WebFrame _webDataRequestForData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
3138         (-[WebFrame _createItem:]):
3139         (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]):
3140         (-[WebFrame _detachFromParent]):
3141         (-[WebFrame _makeDocumentView]):
3142         (-[WebFrame _transitionToCommitted:]):
3143         (-[WebFrame _provisionalLoadStarted]):
3144         (-[WebFrame _opened]):
3145         (-[WebFrame _checkLoadCompleteForThisFrame]):
3146         (-[WebFrame _loadItem:withLoadType:]):
3147         (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]):
3148         (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
3149         (-[WebFrame _loadURL:referrer:intoChild:]):
3150         (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
3151         (-[WebFrame _setTitle:]):
3152         (-[WebFrame _defersCallbacksChanged]):
3153         (-[WebFrame _currentBackForwardListItemToResetTo]):
3154         (-[WebFrame _itemForSavingDocState]):
3155         (-[WebFrame _itemForRestoringDocState]):
3156         (-[WebFrame _saveDocumentAndScrollState]):
3157         (-[WebFrame _shouldTreatURLAsSameAsCurrent:]):
3158         (-[WebFrame _loadRequest:inFrameNamed:]):
3159         (-[WebFrame _initWithWebFrameView:webView:bridge:]):
3160         (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
3161         (-[WebFrame _frameLoader]):
3162         (-[WebFrame _prepareForDataSourceReplacement]):
3163         (-[WebFrame _restoreScrollPositionAndViewState]):
3164         (-[WebFrame _firstLayoutDone]):
3165         (-[WebFrame _loadType]):
3166         (-[WebFrame frameView]):
3167         (-[WebFrame provisionalDataSource]):
3168         (-[WebFrame dataSource]):
3169         (-[WebFrame loadRequest:]):
3170         (-[WebFrame loadArchive:]):
3171         (-[WebFrame stopLoading]):
3172         (-[WebFrame reload]):
3173         (-[WebFrame _resetBackForwardList]):
3174         (-[WebFrame _invalidateCurrentItemPageCache]):
3175         (-[WebFrame _provisionalItemIsTarget]):
3176         (-[WebFrame _loadProvisionalItemFromPageCache]):
3177         * WebView/WebFrameInternal.h:
3178
3179 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
3180
3181         Reviewed by Darin.
3182         
3183         - move remaining movable data fields from WebFrameLoader to WebFrame
3184
3185         * Loader/WebDocumentLoadState.m:
3186         (-[WebDocumentLoadState commitIfReady]):
3187         * Loader/WebFrameLoader.h:
3188         * Loader/WebFrameLoader.m:
3189         (-[WebFrameLoader provisionalLoadStarted]):
3190         (-[WebFrameLoader _setState:]):
3191         (-[WebFrameLoader stopLoadingSubframes]):
3192         (-[WebFrameLoader stopLoading]):
3193         (-[WebFrameLoader startLoading]):
3194         (-[WebFrameLoader _receivedMainResourceError:complete:]):
3195         (-[WebFrameLoader clientRedirectCancelledOrFinished:]):
3196         (-[WebFrameLoader clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
3197         (-[WebFrameLoader shouldReloadForCurrent:andDestination:]):
3198         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
3199         (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]):
3200         (-[WebFrameLoader closeOldDataSources]):
3201         (-[WebFrameLoader commitProvisionalLoad:]):
3202         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
3203         (-[WebFrameLoader isQuickRedirectComing]):
3204         * Loader/WebFrameLoaderClient.h:
3205         * WebCoreSupport/WebFrameBridge.h:
3206         * WebCoreSupport/WebFrameBridge.m:
3207         (-[WebFrameBridge frameLoader]):
3208         (-[WebFrameBridge setTitle:]):
3209         (-[WebFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
3210         (-[WebFrameBridge reportClientRedirectCancelled:]):
3211         (-[WebFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):
3212         * WebView/WebDataSource.m:
3213         (-[WebDataSource _loadFromPageCache:]):
3214         * WebView/WebFrame.m:
3215         (-[NSView setWebFrame::]):
3216         (-[WebFrame _addHistoryItemForFragmentScroll]):
3217         (-[WebFrame _didFinishLoad]):
3218         (-[WebFrame _provisionalLoadStarted]):
3219         (-[WebFrame _checkLoadCompleteForThisFrame]):
3220         (-[WebFrame _loadItem:withLoadType:]):
3221         (-[WebFrame _loadURL:referrer:intoChild:]):
3222         (-[WebFrame _frameLoadCompleted]):
3223         (-[WebFrame stopLoading]):
3224         (-[WebFrame _invalidateCurrentItemPageCache]):
3225         * WebView/WebFrameInternal.h:
3226
3227 2006-10-08  Darin Adler  <darin@apple.com>
3228
3229         Rubber stamped by Maciej.
3230
3231         - changed "document load state" to "document loader"
3232
3233         * Loader/WebDocumentLoadState.h: Removed.
3234         * Loader/WebDocumentLoadState.m: Removed.
3235         * Loader/WebDocumentLoader.h: Added.
3236         * Loader/WebDocumentLoader.m: Added.
3237         (-[WebDocumentLoader setMainDocumentError:]):
3238         (-[WebDocumentLoader mainReceivedError:complete:]):
3239         (-[WebDocumentLoader finishedLoading]):
3240         (-[WebDocumentLoader commitLoadWithData:]):
3241         (-[WebDocumentLoader setupForReplaceByMIMEType:]):
3242         (-[WebDocumentLoader updateLoading]):
3243         (-[WebDocumentLoader setTitle:]):
3244         * Loader/WebFrameLoader.h:
3245         * Loader/WebFrameLoader.m:
3246         (-[WebFrameLoader dealloc]):
3247         (-[WebFrameLoader activeDocumentLoader]):
3248         (-[WebFrameLoader activeDataSource]):
3249         (-[WebFrameLoader addPlugInStreamLoader:]):
3250         (-[WebFrameLoader removePlugInStreamLoader:]):
3251         (-[WebFrameLoader addSubresourceLoader:]):
3252         (-[WebFrameLoader removeSubresourceLoader:]):
3253         (-[WebFrameLoader dataSource]):
3254         (-[WebFrameLoader setDocumentLoader:]):
3255         (-[WebFrameLoader documentLoader]):
3256         (-[WebFrameLoader policyDataSource]):
3257         (-[WebFrameLoader setPolicyDocumentLoader:]):
3258         (-[WebFrameLoader clearDataSource]):
3259         (-[WebFrameLoader provisionalDataSource]):
3260         (-[WebFrameLoader provisionalDocumentLoader]):
3261         (-[WebFrameLoader setProvisionalDocumentLoader:]):
3262         (-[WebFrameLoader _clearProvisionalDataSource]):
3263         (-[WebFrameLoader _setState:]):
3264         (-[WebFrameLoader clearProvisionalLoad]):
3265         (-[WebFrameLoader commitProvisionalLoad]):
3266         (-[WebFrameLoader stopLoading]):
3267         (-[WebFrameLoader startLoading]):
3268         (-[WebFrameLoader startProvisionalLoad:]):
3269         (-[WebFrameLoader setupForReplace]):
3270         (-[WebFrameLoader _didReceiveResponse:forResource:]):
3271         (-[WebFrameLoader _originalRequest]):
3272         (-[WebFrameLoader _receivedMainResourceError:complete:]):
3273         (-[WebFrameLoader _receivedData:]):
3274         (-[WebFrameLoader _setRequest:]):
3275         (-[WebFrameLoader _isStopping]):
3276         (-[WebFrameLoader _setupForReplaceByMIMEType:]):
3277         (-[WebFrameLoader _setResponse:]):
3278         (-[WebFrameLoader _mainReceivedError:complete:]):
3279         (-[WebFrameLoader _finishedLoading]):
3280         (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]):
3281         (-[WebFrameLoader _loadRequest:archive:]):
3282         (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
3283         (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]):
3284         (-[WebFrameLoader reload]):
3285         (-[WebFrameLoader finishedLoadingDocument:]):
3286         (-[WebFrameLoader committedLoadWithDocumentLoader:data:]):
3287         (-[WebFrameLoader revertToProvisionalWithDocumentLoader:]):
3288         (-[WebFrameLoader documentLoader:setMainDocumentError:]):
3289         (-[WebFrameLoader documentLoader:mainReceivedCompleteError:]):
3290         (-[WebFrameLoader finalSetupForReplaceWithDocumentLoader:]):
3291         (-[WebFrameLoader willChangeTitleForDocument:]):
3292         (-[WebFrameLoader didChangeTitleForDocument:]):
3293         (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]):
3294         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
3295         (-[WebFrameLoader loadDataSource:withLoadType:formState:]):
3296         * Plugins/WebPluginController.m:
3297         (-[WebPluginController pluginView:receivedResponse:]):
3298         * WebCoreSupport/WebFrameBridge.m:
3299         (-[WebFrameBridge setTitle:]):
3300         (-[WebFrameBridge receivedData:textEncodingName:]):
3301         * WebKit.xcodeproj/project.pbxproj:
3302         * WebView/WebDataSource.m:
3303         (-[WebDataSourcePrivate dealloc]):
3304         (-[WebDataSource _mainDocumentError]):
3305         (-[WebDataSource _loadFromPageCache:]):
3306         (-[WebDataSource _bridge]):
3307         (-[WebDataSource _webView]):
3308         (-[WebDataSource _URLForHistory]):
3309         (-[WebDataSource _documentLoader]):
3310         (-[WebDataSource _initWithDocumentLoader:]):
3311         (-[WebDataSource initWithRequest:]):
3312         (-[WebDataSource dealloc]):
3313         (-[WebDataSource data]):
3314         (-[WebDataSource webFrame]):
3315         (-[WebDataSource initialRequest]):
3316         (-[WebDataSource request]):
3317         (-[WebDataSource response]):
3318         (-[WebDataSource textEncodingName]):
3319         (-[WebDataSource isLoading]):
3320         (-[WebDataSource unreachableURL]):
3321         (-[WebDataSource webArchive]):
3322         * WebView/WebDataSourceInternal.h:
3323         * WebView/WebDocumentLoadStateMac.h: Removed.
3324         * WebView/WebDocumentLoadStateMac.m: Removed.
3325         * WebView/WebDocumentLoaderMac.h: Added.
3326         * WebView/WebDocumentLoaderMac.m: Added.
3327         * WebView/WebFrame.m:
3328         (-[WebFrame _createItem:]):
3329         (-[WebFrame _receivedMainResourceError:]):
3330         (-[WebFrame _transitionToCommitted:]):
3331         (-[WebFrame _opened]):
3332         (-[WebFrame _checkLoadCompleteForThisFrame]):
3333         (-[WebFrame _loadItem:withLoadType:]):
3334         (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:formState:]):
3335         (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
3336         (-[WebFrame _addChild:]):
3337         (-[WebFrame _provisionalLoadStarted]):
3338         (-[WebFrame _dataSourceForDocumentLoader:]):
3339         (-[WebFrame _createDocumentLoaderWithRequest:]):
3340         * WebView/WebFrameInternal.h:
3341         * WebView/WebHTMLRepresentation.m:
3342         (-[WebHTMLRepresentation title]):
3343         * WebView/WebView.m:
3344         (-[WebView _mainFrameOverrideEncoding]):
3345
3346 2006-10-08  Darin Adler  <darin@apple.com>
3347
3348         Reviewed by Mitz.
3349
3350         - fix http://bugs.webkit.org/show_bug.cgi?id=11218
3351           REGRESSION: Assertion failure in WebFrameLoader when going back from a file: or data: URL
3352
3353         Also added a helper function in WebFrameLoader so that checks for back/forward load types
3354         are easier to read.
3355
3356         * Loader/WebFrameLoader.m:
3357         (-[WebFrameLoader _setPolicyDocumentLoadState:]): Fixed line of code that was setting the load
3358         state to nil instead of the passed-in object.
3359         (isBackForwardLoadType): Added.
3360         (-[WebFrameLoader shouldReloadToHandleUnreachableURLFromRequest:]): Use isBackForwardLoadType.
3361         (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]):
3362         Ditto.
3363         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): Ditto.
3364
3365 2006-10-08  Darin Adler  <darin@apple.com>
3366
3367         Reviewed by Maciej.
3368
3369         - fix two recently introduced leaks: one of an NSString, the other of a WebDataSource
3370
3371         * Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState setTitle:]):
3372         Rearranged code to avoid storage leak in case of identical title.
3373
3374         * Loader/WebFrameLoader.h: Removed _setPolicyDocumentLoadState: method
3375         from the header.
3376         * Loader/WebFrameLoader.m:
3377         (-[WebFrameLoader _setPolicyDocumentLoadState:]): Added logic to call detachFromFrameLoader
3378         as needed if this load state is going away rather than moving on to become the provisional
3379         load state.
3380         (-[WebFrameLoader shouldReloadToHandleUnreachableURLFromRequest:]): Tweaked formatting.
3381         (-[WebFrameLoader _loadRequest:archive:]): Added an assertion.
3382         (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): Added an assertion.
3383         (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]): Added an assertion.
3384         (-[WebFrameLoader reload]): Added an assertion.
3385         (-[WebFrameLoader loadDataSource:withLoadType:formState:]): Added a local variable to avoid
3386         calling _documentLoadState over and over again.
3387
3388 2006-10-07  Don Gibson  <dgibson77@gmail.com>
3389
3390         Reviewed/landed by Adam.
3391
3392         http://bugs.webkit.org/show_bug.cgi?id=11199
3393         Update Session History when a load is committed rather than completed.
3394
3395         * COM/WebFrame.cpp:
3396         (WebFrame::receivedResponse):
3397         (WebFrame::receivedAllData):
3398
3399 2006-10-07  Sam Weinig  <sam.weinig@gmail.com>
3400
3401         Reviewed by Tim H.
3402
3403         Patch for http://bugs.webkit.org/show_bug.cgi?id=11198
3404         Auto-generate a few more Objective-C DOM interfaces
3405
3406         * MigrateHeaders.make:
3407
3408 2006-10-07  Mark Rowe  <bdash@webkit.org>
3409
3410         Reviewed by Mitz.
3411
3412         Fix memory leak from -[WebDocumentLoadState setTitle:].
3413
3414         * Loader/WebDocumentLoadState.m:
3415         (-[WebDocumentLoadState setTitle:]): Ensure 'trimmed' is released even when length is
3416         zero, and untangle the confusing logic around this case.
3417
3418 2006-10-06  Brady Eidson  <beidson@apple.com>
3419
3420         Reviewed by Darin
3421
3422         Refactored a whole bunch of WebFramePrivate.h SPI to WebFrameInternal
3423
3424         * DefaultDelegates/WebDefaultContextMenuDelegate.m:
3425         * History/WebHistoryItem.m:
3426         * Loader/WebFrameLoader.h:
3427         * Misc/WebCoreStatistics.m:
3428         * Misc/WebElementDictionary.m:
3429         * Plugins/WebNetscapePluginEmbeddedView.m:
3430         * Plugins/WebPluginController.m:
3431         * WebCoreSupport/WebViewFactory.m:
3432         * WebView/WebArchiver.m:
3433         * WebView/WebDataSource.m:
3434         * WebView/WebFrame.m:
3435         (-[WebFrame _isDescendantOfFrame:]):
3436         (-[WebFrame _setShouldCreateRenderers:]):
3437         (-[WebFrame _bodyBackgroundColor]):
3438         (-[WebFrame _isFrameSet]):
3439         (-[WebFrame _firstLayoutDone]):
3440         (-[WebFrame _loadType]):
3441         * WebView/WebFrameInternal.h:
3442         * WebView/WebFramePrivate.h:
3443         * WebView/WebHTMLRepresentation.m:
3444         * WebView/WebScriptDebugDelegate.m:
3445
3446 2006-10-06  Maciej Stachowiak  <mjs@apple.com>
3447
3448         Reviewed by Darin.
3449         
3450         - Move all delegate dispatching code out of WebDataSource.
3451
3452         * Loader/WebFrameLoader.m:
3453         (-[WebFrameLoader startLoading]):
3454         (-[WebFrameLoader _identifierForInitialRequest:]):
3455         (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]):
3456         (-[WebFrameLoader _didReceiveAuthenticationChallenge:forResource:]):
3457         (-[WebFrameLoader _didCancelAuthenticationChallenge:forResource:]):
3458         (-[WebFrameLoader _didReceiveResponse:forResource:]):
3459         (-[WebFrameLoader _didReceiveData:contentLength:forResource:]):
3460         (-[WebFrameLoader _didFinishLoadingForResource:]):
3461         (-[WebFrameLoader _didFailLoadingWithError:forResource:]):
3462         (-[WebFrameLoader _receivedMainResourceError:complete:]):
3463         (-[WebFrameLoader _downloadWithLoadingConnection:request:response:proxy:]):
3464         (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]):
3465         * WebView/WebDataSource.m:
3466         (-[WebDataSource _setLoadingFromPageCache:]):
3467         (-[WebDataSource _stopLoadingWithError:]):
3468         * WebView/WebDataSourceInternal.h:
3469
3470 2006-10-06  Darin Adler  <darin@apple.com>
3471
3472         Reviewed by Maciej.
3473
3474         - moved firstLayoutDone BOOL from WebFrame to WebFrameLoader
3475
3476         * Loader/WebFrameLoader.h:
3477         * Loader/WebFrameLoader.m:
3478         (-[WebFrameLoader didFirstLayout]):
3479         (-[WebFrameLoader provisionalLoadStarted]):
3480         (-[WebFrameLoader frameLoadCompleted]):
3481         (-[WebFrameLoader firstLayoutDone]):
3482         * WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge didFirstLayout]):
3483         * WebView/WebFrame.m:
3484         (-[WebFrame _firstLayoutDone]):
3485         (-[WebFrame _provisionalLoadStarted]):
3486         (-[WebFrame _frameLoadCompleted]):
3487         (-[WebFrame _restoreScrollPositionAndViewState]):
3488         * WebView/WebFrameInternal.h:
3489
3490 2006-10-06  Darin Adler  <darin@apple.com>
3491
3492         Reviewed by Maciej.
3493
3494         - moved more data and the corresponding code from WebFrame to WebFrameLoader
3495
3496         * Loader/WebFrameLoader.h:
3497         * Loader/WebFrameLoader.m:
3498         (-[WebFrameLoader cannotShowMIMETypeForURL:]):
3499         (-[WebFrameLoader _checkNavigationPolicyForRequest:andCall:withSelector:]):
3500         (-[WebFrameLoader shouldReloadToHandleUnreachableURLFromRequest:]):
3501         (-[WebFrameLoader _loadRequest:archive:]):
3502         (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
3503         (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]):
3504         (-[WebFrameLoader reload]):
3505         (-[WebFrameLoader invalidatePendingPolicyDecisionCallingDefaultAction:]):
3506         (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]):
3507         (-[WebFrameLoader _continueAfterNewWindowPolicy:]):
3508         (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]):
3509         (-[WebFrameLoader continueAfterNavigationPolicy:]):
3510         (-[WebFrameLoader continueAfterWillSubmitForm:]):
3511         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
3512         (-[WebFrameLoader loadDataSource:withLoadType:formState:]):
3513         (-[WebFrameLoader handleUnimplementablePolicyWithErrorCode:forURL:]):
3514         (-[WebFrameLoader delegateIsHandlingProvisionalLoadError]):
3515         (-[WebFrameLoader setDelegateIsHandlingProvisionalLoadError:]):
3516         * Loader/WebFrameLoaderClient.h:
3517         * WebView/WebFrame.m:
3518         (-[NSView setWebFrame::]):
3519         (-[WebFramePrivate dealloc]):
3520         (-[WebFrame _checkLoadCompleteForThisFrame]):
3521         (-[WebFrame _loadItem:withLoadType:]):
3522         (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
3523         (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
3524         (-[WebFrame _loadRequest:inFrameNamed:]):
3525         (-[WebFrame stopLoading]):
3526         (-[WebFrame _resetBackForwardList]):
3527         (-[WebFrame _quickRedirectComing]):
3528         (-[WebFrame _provisionalItemIsTarget]):
3529         (-[WebFrame _loadProvisionalItemFromPageCache]):
3530         * WebView/WebFrameInternal.h:
3531         * WebView/WebFramePrivate.h:
3532
3533         * WebKit.xcodeproj/project.pbxproj:
3534
3535 2006-10-06  Maciej Stachowiak  <mjs@apple.com>
3536
3537         Rubber stamped by Darin.
3538         
3539         - removed includes of unused headers.
3540
3541         * WebView/WebDataSource.m:
3542
3543 2006-10-06  Maciej Stachowiak  <mjs@apple.com>
3544
3545         Not reviewed.
3546         
3547         - fix build breakage
3548
3549         * Loader/WebFrameLoader.m:
3550         (-[WebFrameLoader willChangeTitleForDocumentLoadState:]):
3551         (-[WebFrameLoader didChangeTitleForDocumentLoadState:]):
3552
3553 2006-10-06  Maciej Stachowiak  <mjs@apple.com>
3554
3555         Reviewed by Darin.
3556         
3557         - move remaining movable WebDataSource fields to WebDocumentLoadState
3558
3559         * Loader/WebDocumentLoadState.h:
3560         * Loader/WebDocumentLoadState.m:
3561         (-[WebDocumentLoadState dealloc]):
3562         (-[WebDocumentLoadState isLoadingInAPISense]):
3563         (-[WebDocumentLoadState addResponse:]):
3564         (-[WebDocumentLoadState stopRecordingResponses]):
3565         (-[WebDocumentLoadState title]):
3566         (-[WebDocumentLoadState setLastCheckedRequest:]):
3567         (-[WebDocumentLoadState lastCheckedRequest]):
3568         (-[WebDocumentLoadState triggeringAction]):
3569         (-[WebDocumentLoadState setTriggeringAction:]):
3570         (-[WebDocumentLoadState responses]):
3571         (-[WebDocumentLoadState setOverrideEncoding:]):
3572         (-[WebDocumentLoadState overrideEncoding]):
3573         (-[WebDocumentLoadState setTitle:]):
3574         * Loader/WebFrameLoader.h:
3575         * Loader/WebFrameLoader.m:
3576         (-[WebFrameLoader _setState:]):
3577         (-[WebFrameLoader _loadRequest:archive:]):
3578         (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
3579         (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]):
3580         (-[WebFrameLoader reload]):
3581         (-[WebFrameLoader willChangeTitleForDocumentLoadState:]):
3582         (-[WebFrameLoader didChangeTitleForDocumentLoadState:]):
3583         * WebCoreSupport/WebFrameBridge.m:
3584         (-[WebFrameBridge setTitle:]):
3585         (-[WebFrameBridge receivedData:textEncodingName:]):
3586         * WebView/WebDataSource.m:
3587         (-[WebDataSourcePrivate dealloc]):
3588         (-[WebDataSource _didReceiveResponse:forResource:]):
3589         (-[WebDataSource textEncodingName]):
3590         * WebView/WebDataSourceInternal.h:
3591         * WebView/WebFrame.m:
3592         (-[WebFrame _opened]):
3593         (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]):
3594         (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
3595         (-[WebFrame _addChild:]):
3596         (-[WebFrame _loadDataSource:withLoadType:formState:]):
3597         * WebView/WebHTMLRepresentation.m:
3598         (-[WebHTMLRepresentation title]):
3599         * WebView/WebView.m:
3600         (-[WebView _mainFrameOverrideEncoding]):
3601
3602 2006-10-06  Darin Adler  <darin@apple.com>
3603
3604         Reviewed by Maciej.
3605
3606         - moved loadType into WebFrameLoader
3607
3608         * WebView/WebFramePrivate.h: Removed _setLoadType, but not _loadType because it's
3609         currently used by Safari.
3610
3611         * Loader/WebFrameLoader.h:
3612         * Loader/WebFrameLoader.m:
3613         (-[WebFrameLoader _loadRequest:archive:]):
3614         (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
3615         (-[WebFrameLoader isReplacing]):
3616         (-[WebFrameLoader setReplacing]):
3617         (-[WebFrameLoader loadType]):
3618         (-[WebFrameLoader setLoadType:]):
3619         * WebCoreSupport/WebFrameBridge.m:
3620         (-[WebFrameBridge isLoadTypeReload]):
3621         * WebView/WebFrame.m:
3622         (-[WebFrame _loadType]):
3623         (-[WebFrame _transitionToCommitted:]):
3624         (-[WebFrame _commitProvisionalLoad:]):
3625         (-[WebFrame _opened]):
3626         (-[WebFrame _checkLoadCompleteForThisFrame]):
3627         (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
3628         (-[WebFrame _loadURL:referrer:intoChild:]):
3629         (-[WebFrame _currentBackForwardListItemToResetTo]):
3630         (-[WebFrame _itemForRestoringDocState]):
3631         (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
3632         (-[WebFrame _didFirstLayout]):
3633         (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
3634         (-[WebFrame _provisionalLoadStarted]):
3635         (-[WebFrame loadRequest:]):
3636
3637 2006-10-06  Darin Adler  <darin@apple.com>
3638
3639         Reviewed by Maciej.
3640
3641         - added WebFrameLoaderClient protocol -- to be used to make WebFrameLoader forget all about WebFrame
3642
3643         * Loader/WebDocumentLoadState.h: Added comment about Maciej's planned renaming here.
3644         * Loader/WebFrameLoader.h:
3645         * Loader/WebFrameLoader.m: Renamed webFrame to client and added the new protocol.
3646         Eventually we'll be removing the dependency on WebFrame entirely.
3647         * WebView/WebFrame.m: (-[WebFrame _initWithWebFrameView:webView:bridge:]): Update to call the method
3648         by its new name.
3649
3650         * Loader/WebFrameLoaderClient.h: Added.
3651         * WebKit.xcodeproj/project.pbxproj: Updated for new file, sorted things.
3652
3653 2006-10-06  Maciej Stachowiak  <mjs@apple.com>
3654
3655         Reviewed by Darin.
3656         
3657         - segregate WebFrame methods into ones that should be moved into WebFrameLoader and ones that don't need to
3658         
3659         Also removed useless WebFrameLoader part
3660
3661         * WebView/WebFrame.m:
3662         (-[WebFramePrivate dealloc]): 
3663
3664 2006-10-06  Maciej Stachowiak  <mjs@apple.com>
3665
3666         Reviewed by Anders.
3667         
3668         - moved more data from WebDataSource to WebDocumentLoadState
3669
3670         * Loader/WebDocumentLoadState.h:
3671         * Loader/WebDocumentLoadState.m:
3672         (-[WebDocumentLoadState commitLoadWithData:]):
3673         (-[WebDocumentLoadState prepareForLoadStart]):
3674         (-[WebDocumentLoadState loadingStartedTime]):
3675         (-[WebDocumentLoadState setIsClientRedirect:]):
3676         (-[WebDocumentLoadState isClientRedirect]):
3677         (-[WebDocumentLoadState setPrimaryLoadComplete:]):
3678         (-[WebDocumentLoadState isLoadingInAPISense]):
3679         * Loader/WebFrameLoader.h:
3680         * Loader/WebFrameLoader.m:
3681         (-[WebFrameLoader _setState:]):
3682         (-[WebFrameLoader _finishedLoading]):
3683         (-[WebFrameLoader documentLoadState:mainReceivedCompleteError:]):
3684         (-[WebFrameLoader prepareForLoadStart]):
3685         (-[WebFrameLoader subframeIsLoading]):
3686         * WebView/WebDataSource.m:
3687         (-[WebDataSource _fileWrapperForURL:]):
3688         (-[WebDataSource _startLoading]):
3689         (-[WebDataSource _loadFromPageCache:]):
3690         (-[WebDataSource isLoading]):
3691         * WebView/WebDataSourceInternal.h:
3692         * WebView/WebFrame.m:
3693         (-[WebFrame _transitionToCommitted:]):
3694         (-[WebFrame _opened]):
3695         (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
3696
3697 2006-10-06  Alexey Proskuryakov  <ap@nypop.com>
3698
3699         Reviewed by Darin.
3700
3701         http://bugs.webkit.org/show_bug.cgi?id=11183
3702         REGRESSION: Safari loads error pages unstyled
3703
3704         * WebView/WebFrame.m:
3705         (-[WebFrame _loadHTMLString:baseURL:unreachableURL:]):
3706         Use utf-8 encoding instead of the string's "fastest" encoding.
3707
3708 2006-10-06  Maciej Stachowiak  <mjs@apple.com>
3709
3710         Reviewed by Adam.
3711         
3712         - fixed the following bugs:
3713         
3714         http://bugs.webkit.org/show_bug.cgi?id=11136
3715         "REGRESSION: Safari snippet editor doesn't work"
3716         http://bugs.webkit.org/show_bug.cgi?id=11140
3717         "REGRESSION: view source window blank"
3718         http://bugs.webkit.org/show_bug.cgi?id=11146
3719         "REGRESSION: Instead of showing the error page, Safari opens its Resources folder in the Finder"
3720         
3721         Possibly more.
3722
3723         * Loader/WebDocumentLoadState.h:
3724         * Loader/WebDocumentLoadState.m:
3725         (-[WebDocumentLoadState actualRequest]): New method.
3726         * WebView/WebDataSource.m:
3727         (-[WebDataSource _startLoading]): We need to make sure not to start loading the main
3728         resource with the fake external request for an applewebdata: request.
3729
3730 2006-10-05  Adele Peterson  <adele@apple.com>
3731
3732         Reviewed by the letter 'B'.
3733
3734         More build fixes.
3735
3736         * WebKit.xcodeproj/project.pbxproj:
3737         * WebView/WebDynamicScrollBarsView.h:
3738         * WebView/WebDynamicScrollBarsView.m:
3739         (-[WebDynamicScrollBarsView updateScrollers]):
3740         (-[WebDynamicScrollBarsView setAllowsScrolling:]):
3741         (-[WebDynamicScrollBarsView allowsScrolling]):
3742         (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]):
3743         (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]):
3744         (-[WebDynamicScrollBarsView allowsHorizontalScrolling]):
3745         (-[WebDynamicScrollBarsView allowsVerticalScrolling]):
3746         (-[WebDynamicScrollBarsView horizontalScrollingMode]):
3747         (-[WebDynamicScrollBarsView verticalScrollingMode]):
3748         (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]):
3749         (-[WebDynamicScrollBarsView setVerticalScrollingMode:]):
3750         (-[WebDynamicScrollBarsView setScrollingMode:]):
3751         * WebView/WebView.m:
3752         (-[WebView setAlwaysShowVerticalScroller:]):
3753         (-[WebView alwaysShowVerticalScroller]):
3754         (-[WebView setAlwaysShowHorizontalScroller:]):
3755         (-[WebView alwaysShowHorizontalScroller]):
3756
3757 2006-10-05  Vladimir Olexa  <vladimir.olexa@gmail.com>
3758
3759         Reviewed by Timothy.
3760
3761         Bug: http://bugs.webkit.org/show_bug.cgi?id=9887
3762         Continuous spell checking now remembers user's setting. The change is applied globally,
3763         meaning, both TextArea and TextField are affected when either of them enables/disables
3764         spell checking. 
3765
3766         * WebView/WebPreferenceKeysPrivate.h: added a define for WebContinuousSpellCheckingEnabled
3767         * WebView/WebView.m:
3768         (-[WebViewPrivate init]): reads WebContinuousSpellCheckingEnabled from NSUserDefaults
3769         (-[WebView setContinuousSpellCheckingEnabled:]):
3770         (-[WebView isContinuousSpellCheckingEnabled]):
3771
3772 2006-10-05  MorganL  <morganl.webkit@yahoo.com>
3773
3774         Reviewed by Darin.
3775
3776         Fixes http://bugs.webkit.org/show_bug.cgi?id=11162
3777
3778         * COM/WebFrame.cpp:
3779         (WebFrame::loadDataSource):
3780         (WebFrame::receivedResponse):
3781
3782 2006-10-05  Don Gibson  <dgibson77@gmail.com>
3783
3784         Reviewed by Darin, landed by Adam.
3785
3786         http://bugs.webkit.org/show_bug.cgi?id=11176
3787         Fix win32 build, adapt to Maciej's ResourceLoader changes.
3788
3789         * COM/WebFrame.cpp:
3790         (WebFrame::loadDataSource):
3791
3792 2006-10-05  Marvin Decker  <marv.decker@gmail.com>
3793
3794         Reviewed by Darin.
3795
3796         http://bugs.webkit.org/show_bug.cgi?id=10989
3797         Provide a way for embedders to implement BrowserExtensionWin
3798
3799         * COM/Interfaces/IWebUIDelegate.idl:
3800         * COM/WebFrame.cpp:
3801         (WebFrame::createNewWindow):
3802         * COM/WebFrame.h:
3803
3804 2006-10-04  Mark Rowe  <bdash@webkit.org>
3805
3806         Reviewed by NOBODY (build fix).
3807
3808         * WebView/WebView.m:
3809         (-[WebView scrollDOMRangeToVisible:]): Move scrollDOMRangeToVisible: into the correct category.
3810
3811 2006-09-26  David Smith  <catfish.man@gmail.com>
3812
3813         Reviewed by Timothy.
3814
3815         http://bugs.webkit.org/show_bug.cgi?id=3723
3816         Add -scrollDOMRangeToVisible:
3817
3818         * WebView/WebView.m:
3819         (-[WebView scrollDOMRangeToVisible:]):
3820         * WebView/WebViewPrivate.h:
3821
3822 2006-10-03  Graham Dennis  <graham.dennis@gmail.com>
3823
3824         Reviewed by Timothy.
3825
3826         <http://bugs.webkit.org/show_bug.cgi?id=10338>
3827         When contentEditable, cursor doesn't change to hand
3828         
3829         Allow the behaviour of editable links to be specified by a WebPreference
3830         The preference WebKitEditableLinkBehavior has four options:
3831          - AlwaysLive: Safari 2.0 behaviour
3832          - OnlyLiveWithShiftKey: Firefox/WinIE behaviour (and prior WebKit-ToT behaviour)
3833          - LiveWhenNotFocused: Editable links are live only when their editable block is not
3834              focused, or when the shift key is pressed
3835          - DefaultBehavior: This is the same as OnlyLiveWithShiftKey.
3836          
3837         No layout tests, just a modification of a manual-test as it isn't possible to test
3838         this automatically.
3839
3840         * WebView/WebPreferenceKeysPrivate.h:
3841         * WebView/WebPreferences.m:
3842         (+[WebPreferences initialize]):
3843         (-[WebPreferences editableLinkBehavior]):
3844         (-[WebPreferences setEditableLinkBehavior:]):
3845         * WebView/WebPreferencesPrivate.h:
3846         * WebView/WebView.m:
3847         (-[WebView _updateWebCoreSettingsFromPreferences:]):
3848
3849 2006-10-03  Justin Garcia  <justin.garcia@apple.com>
3850
3851         Reviewed by harrison
3852         
3853         execCommand("Cut"/"Copy"/"Paste") broken in editable subframes.
3854
3855         * WebCoreSupport/WebFrameBridge.m:
3856         (-[WebFrameBridge issueCutCommand]): Issue the command on the WebHTMLView, not the WebView.
3857         (-[WebFrameBridge issueCopyCommand]): Ditto.
3858         (-[WebFrameBridge issuePasteCommand]): Ditto.
3859         (-[WebFrameBridge issuePasteAndMatchStyleCommand]): Ditto.
3860         (-[WebFrameBridge issueTransposeCommand]): Fixed formatting.
3861         (-[WebFrameBridge canPaste]): Ask the WebHTMLView, not the WebView.
3862         * WebView/WebHTMLView.m:
3863         (-[WebHTMLView copy:]): Moved to WebInternal
3864         (-[WebHTMLView cut:]): Ditto.
3865         (-[WebHTMLView paste:]): Ditto.
3866         (-[WebHTMLView pasteAsPlainText:]): Ditto.
3867         * WebView/WebHTMLViewInternal.h:
3868         * WebView/WebView.m: Removed the now unused _canPaste.
3869         * WebView/WebViewInternal.h: Ditto.
3870
3871 2006-10-03  Justin Garcia  <justin.garcia@apple.com>
3872
3873         Reviewed by geoff
3874         
3875         <rdar://problem/4763519> REGRESSION: Multipart/x-mixed-replace sub-resources fail to load
3876
3877         * Loader/WebSubresourceLoader.m:
3878         (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]): 
3879         Enable multipart/x-mixed-replace support on the request.  This line was accidently removed during 
3880         some loader refactoring.
3881
3882 2006-10-02  Adam Roben  <aroben@apple.com>
3883
3884         Reviewed by Maciej.
3885
3886         Add message paramter to WebView::mouse* methods to pass down to
3887         PlatformMouseEvent.
3888
3889         * COM/WebView.cpp:
3890         (WebView::mouseMoved):
3891         (WebView::mouseDown):
3892         (WebView::mouseUp):
3893         (WebView::mouseDoubleClick):
3894         (WebViewWndProc):
3895         * COM/WebView.h:
3896
3897 2006-10-02  Maciej Stachowiak  <mjs@apple.com>
3898
3899         Reviewed by Alice.
3900         
3901         - take away direct knowledge of WebFrame from WebDataSource
3902
3903         * Loader/WebDocumentLoadState.h:
3904         * Loader/WebDocumentLoadState.m:
3905         (-[WebDocumentLoadState setFrameLoader:]):
3906         (-[WebDocumentLoadState detachFromFrameLoader]):
3907         * Loader/WebFrameLoader.m:
3908         (-[WebFrameLoader _setDocumentLoadState:]):
3909         (-[WebFrameLoader _setProvisionalDocumentLoadState:]):
3910         * WebView/WebDataSource.m:
3911         * WebView/WebDataSourceInternal.h:
3912         * WebView/WebDocumentLoadStateMac.m:
3913         (-[WebDocumentLoadStateMac detachFromFrameLoader]):
3914         * WebView/WebFrame.m:
3915         (-[WebFrame _loadDataSource:withLoadType:formState:]):
3916
3917 2006-10-02  Maciej Stachowiak  <mjs@apple.com>
3918
3919         Reviewed by Darin.
3920         
3921         - move a big slice of data and logic from WebDataSource to WebDocumentLoadState
3922         
3923         * Loader/WebDocumentLoadState.h:
3924         * Loader/WebDocumentLoadState.m:
3925         (-[WebDocumentLoadState initWithRequest:]):
3926         (-[WebDocumentLoadState dealloc]):
3927         (-[WebDocumentLoadState originalRequestCopy]):
3928         (-[WebDocumentLoadState request]):
3929         (-[WebDocumentLoadState replaceRequestURLForAnchorScrollWithURL:]):
3930         (-[WebDocumentLoadState setRequest:]):
3931         (-[WebDocumentLoadState setResponse:]):
3932         (-[WebDocumentLoadState isStopping]):
3933         (-[WebDocumentLoadState bridge]):
3934         (-[WebDocumentLoadState setMainDocumentError:]):
3935         (-[WebDocumentLoadState mainDocumentError]):
3936         (-[WebDocumentLoadState clearErrors]):
3937         (-[WebDocumentLoadState mainReceivedError:complete:]):
3938         (-[WebDocumentLoadState stopLoading]):
3939         (-[WebDocumentLoadState setupForReplace]):
3940         (-[WebDocumentLoadState commitIfReady]):
3941         (-[WebDocumentLoadState finishedLoading]):
3942         (-[WebDocumentLoadState setCommitted:]):
3943         (-[WebDocumentLoadState isCommitted]):
3944         (-[WebDocumentLoadState setLoading:]):
3945         (-[WebDocumentLoadState isLoading]):
3946         (-[WebDocumentLoadState commitLoadWithData:]):
3947         (-[WebDocumentLoadState doesProgressiveLoadWithMIMEType:]):
3948         (-[WebDocumentLoadState receivedData:]):
3949         (-[WebDocumentLoadState setupForReplaceByMIMEType:]):
3950         (-[WebDocumentLoadState updateLoading]):
3951         (-[WebDocumentLoadState response]):
3952         * Loader/WebFrameLoader.h:
3953         * Loader/WebFrameLoader.m:
3954         (-[WebFrameLoader activeDocumentLoadState]):
3955         (-[WebFrameLoader activeDataSource]):
3956         (-[WebFrameLoader _archivedSubresourceForURL:]):
3957         (-[WebFrameLoader addPlugInStreamLoader:]):
3958         (-[WebFrameLoader removePlugInStreamLoader:]):
3959         (-[WebFrameLoader addSubresourceLoader:]):
3960         (-[WebFrameLoader removeSubresourceLoader:]):
3961         (-[WebFrameLoader documentLoadState]):
3962         (-[WebFrameLoader provisionalDocumentLoadState]):
3963         (-[WebFrameLoader stopLoading]):
3964         (-[WebFrameLoader _originalRequest]):
3965         (-[WebFrameLoader _receivedData:]):
3966         (-[WebFrameLoader _setRequest:]):
3967         (-[WebFrameLoader bridge]):
3968         (-[WebFrameLoader _handleFallbackContent]):
3969         (-[WebFrameLoader _isStopping]):
3970         (-[WebFrameLoader _setupForReplaceByMIMEType:]):
3971         (-[WebFrameLoader _setResponse:]):
3972         (-[WebFrameLoader _mainReceivedError:complete:]):
3973         (-[WebFrameLoader _finishedLoading]):
3974         (-[WebFrameLoader didReceiveServerRedirectForProvisionalLoadForFrame]):
3975         (-[WebFrameLoader finishedLoadingDocumentLoadState:]):
3976         (-[WebFrameLoader commitProvisitionalLoad]):
3977         (-[WebFrameLoader committedLoadWithDocumentLoadState:data:]):
3978         (-[WebFrameLoader isReplacing]):
3979         (-[WebFrameLoader setReplacing]):
3980         (-[WebFrameLoader revertToProvisionalWithDocumentLoadState:]):
3981         (-[WebFrameLoader documentLoadState:setMainDocumentError:]):
3982         (-[WebFrameLoader documentLoadState:mainReceivedCompleteError:]):
3983         (-[WebFrameLoader finalSetupForReplaceWithDocumentLoadState:]):
3984         * WebView/WebDataSource.m:
3985         (-[WebDataSourcePrivate dealloc]):
3986         (-[WebDataSource _prepareForLoadStart]):
3987         (-[WebDataSource _mainDocumentError]):
3988         (-[WebDataSource _finishedLoading]):
3989         (-[WebDataSource _receivedData:]):
3990         (-[WebDataSource _setMainDocumentError:]):
3991         (-[WebDataSource _clearUnarchivingState]):
3992         (-[WebDataSource _revertToProvisionalState]):
3993         (-[WebDataSource _receivedMainResourceError:complete:]):
3994         (-[WebDataSource _startLoading]):
3995         (-[WebDataSource _loadFromPageCache:]):
3996         (-[WebDataSource _bridge]):
3997         (-[WebDataSource _setPrimaryLoadComplete:]):
3998         (-[WebDataSource _URLForHistory]):
3999         (-[WebDataSource _setTitle:]):
4000         (-[WebDataSource _initWithDocumentLoadState:]):
4001         (-[WebDataSource request]):
4002         (-[WebDataSource response]):
4003         (-[WebDataSource isLoading]):
4004         (-[WebDataSource webArchive]):
4005         * WebView/WebDataSourceInternal.h:
4006         * WebView/WebDocumentLoadStateMac.m:
4007         (-[WebDocumentLoadStateMac initWithRequest:]):
4008         * WebView/WebFrame.m:
4009         (-[WebFrame _createItem:]):
4010         (-[WebFrame _receivedMainResourceError:]):
4011         (-[WebFrame _transitionToCommitted:]):
4012         (-[WebFrame _commitProvisionalLoad:]):
4013         (-[WebFrame _checkLoadCompleteForThisFrame]):
4014         (-[WebFrame _loadItem:withLoadType:]):
4015         (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:formState:]):
4016         (-[WebFrame _didReceiveServerRedirectForProvisionalLoadForFrame]):
4017         (-[WebFrame _provisionalLoadStarted]):
4018         * WebView/WebFrameInternal.h:
4019
4020 2006-10-02  Justin Garcia  <justin.garcia@apple.com>
4021
4022         Reviewed by john
4023         
4024         <rdar://problem/4757583>
4025         REGRESSION: tabbing into page focuses wrong control on 2nd pass
4026         <rdar://problem/4757594>
4027         REGRESSION: Form field is left with secondary selection after tabbing out of WebView
4028
4029         * WebView/WebHTMLView.m:
4030         (-[NSArray maintainsInactiveSelection]): Replace code that I removed in error in the patch
4031         for 9642.  Only leave inactive editable selections in the WebHTMLView if the nextResponder 
4032         is in the same WebView.
4033
4034 2006-10-02  Maciej Stachowiak  <mjs@apple.com>
4035
4036         Reviewed by Anders.
4037         
4038         - remove webFrame field from WebDataSourcePrivate, it can get it from WebDocumentLoadState now
4039
4040         * Loader/WebDocumentLoadState.h:
4041         * Loader/WebDocumentLoadState.m:
4042         (-[WebDocumentLoadState frameLoader]):
4043         * WebView/WebDataSource.m:
4044         (-[WebDataSourcePrivate dealloc]):
4045         (-[WebDataSource _revertToProvisionalState]):
4046         (-[WebDataSource _setupForReplaceByMIMEType:]):
4047         (-[WebDataSource _updateLoading]):
4048         (-[WebDataSource _startLoading]):
4049         (-[WebDataSource _setWebFrame:]):
4050         (-[WebDataSource _defersCallbacksChanged]):
4051         (-[WebDataSource _stopLoading]):
4052         (-[WebDataSource _webView]):
4053         (-[WebDataSource _stopLoadingWithError:]):
4054         (-[WebDataSource _setPrimaryLoadComplete:]):
4055         (-[WebDataSource dealloc]):
4056         (-[WebDataSource webFrame]):
4057         (-[WebDataSource isLoading]):
4058
4059 2006-10-02  Maciej Stachowiak  <mjs@apple.com>
4060
4061         Reviewed by Anders.
4062         
4063         - fix crash on back/forward - reattach WebDocumentLoadState to data source when needed
4064
4065         * WebView/WebDataSource.m:
4066         (-[WebDataSource _setWebFrame:]):
4067         (-[WebDataSource _initWithDocumentLoadState:]):
4068         * WebView/WebDataSourceInternal.h:
4069
4070 2006-10-02  Maciej Stachowiak  <mjs@apple.com>
4071
4072         Build fix, not reviewed.
4073         
4074         - Added missing files to fix build.
4075
4076         * WebView/WebDocumentLoadStateMac.h: Added.
4077         * WebView/WebDocumentLoadStateMac.m: Added.
4078         (-[WebDocumentLoadStateMac initWithRequest:]):
4079         (-[WebDocumentLoadStateMac dealloc]):
4080         (-[WebDocumentLoadStateMac setDataSource:]):
4081         (-[WebDocumentLoadStateMac dataSource]):
4082         (-[WebDocumentLoadStateMac setFrameLoader:]):
4083
4084 2006-10-01  Maciej Stachowiak  <mjs@apple.com>
4085
4086         Reviewed by Brady and Oliver.
4087         
4088         - move things around so that WebDataSource and WebDocumentLoadState know about each other in
4089         the right way. This lines things up to move nearly all functionality down to WebDocumentLoadState.
4090
4091         * Loader/WebDocumentLoadState.h:
4092         * Loader/WebDocumentLoadState.m:
4093         (-[WebDocumentLoadState initWithRequest:]):
4094         (-[WebDocumentLoadState dealloc]):
4095         (-[WebDocumentLoadState originalRequest]):
4096         * Loader/WebFrameLoader.h:
4097         * Loader/WebFrameLoader.m:
4098         (-[WebFrameLoader dealloc]):
4099         (-[WebFrameLoader addSubresourceLoader:]):
4100         (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]):
4101         (-[WebFrameLoader dataSource]):
4102         (-[WebFrameLoader _setDocumentLoadState:]):
4103         (-[WebFrameLoader policyDataSource]):
4104         (-[WebFrameLoader _setPolicyDocumentLoadState:]):
4105         (-[WebFrameLoader clearDataSource]):
4106         (-[WebFrameLoader provisionalDataSource]):
4107         (-[WebFrameLoader _setProvisionalDocumentLoadState:]):
4108         (-[WebFrameLoader _clearProvisionalDataSource]):
4109         (-[WebFrameLoader _setState:]):
4110         (-[WebFrameLoader clearProvisionalLoad]):
4111         (-[WebFrameLoader commitProvisionalLoad]):
4112         (-[WebFrameLoader stopLoading]):
4113         (-[WebFrameLoader startLoading]):
4114         (-[WebFrameLoader startProvisionalLoad:]):
4115         (-[WebFrameLoader setupForReplace]):
4116         (-[WebFrameLoader activeDocumentLoadState]):
4117         (-[WebFrameLoader activeDataSource]):
4118         (-[WebFrameLoader _loadRequest:archive:]):
4119         (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
4120         (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]):
4121         (-[WebFrameLoader reload]):
4122         * WebKit.xcodeproj/project.pbxproj:
4123         * WebView/WebDataSource.m:
4124         (-[WebDataSourcePrivate dealloc]):
4125         (-[WebDataSource _startLoading]):
4126         (-[WebDataSource _setWebFrame:]):
4127         (-[WebDataSource _documentLoadState]):
4128         (-[WebDataSource _initWithDocumentLoadState:]):
4129         (-[WebDataSource initWithRequest:]):
4130         (-[WebDataSource initialRequest]):
4131         (-[WebDataSource unreachableURL]):
4132         * WebView/WebDataSourceInternal.h:
4133         * WebView/WebFrame.m:
4134         (-[WebFramePrivate dealloc]):
4135         (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
4136         (-[WebFrame _loadDataSource:withLoadType:formState:]):
4137         (-[WebFrame _policyDataSource]):
4138         (-[WebFrame _shouldReloadToHandleUnreachableURLFromRequest:]):
4139         (-[WebFrame _dataSourceForDocumentLoadState:]):
4140         (-[WebFrame _createDocumentLoadStateWithRequest:]):
4141         * WebView/WebFrameInternal.h:
4142
4143 2006-09-29  David Hyatt  <hyatt@apple.com>
4144
4145         Change the default minimum font size pref to 0 in order to allow
4146         font-size:0 to work.
4147
4148         * WebView/WebPreferences.m:
4149         (+[WebPreferences initialize]):
4150
4151 2006-09-28  Timothy Hatcher  <timothy@apple.com>
4152
4153         Reviewed by Maciej.
4154
4155         Switch the inspector over to use border-image with styled buttons and selects.
4156
4157         * WebInspector/WebInspector.m:
4158         (-[NSWindow window]):
4159         (-[NSWindow setWebFrame:]):
4160         (-[WebInspector _updateRoot]):
4161         * WebInspector/webInspector/Images/button.png: Added.
4162         * WebInspector/webInspector/Images/buttonDivider.png: Added.
4163         * WebInspector/webInspector/Images/buttonPressed.png: Added.
4164         * WebInspector/webInspector/Images/popup.png: Added.
4165         * WebInspector/webInspector/Images/popupFill.png: Removed.
4166         * WebInspector/webInspector/Images/popupFillPressed.png: Removed.
4167         * WebInspector/webInspector/Images/popupLeft.png: Removed.
4168         * WebInspector/webInspector/Images/popupLeftPressed.png: Removed.
4169         * WebInspector/webInspector/Images/popupPressed.png: Added.
4170         * WebInspector/webInspector/Images/popupRight.png: Removed.
4171         * WebInspector/webInspector/Images/popupRightPressed.png: Removed.
4172         * WebInspector/webInspector/Images/squareButtonRight.png: Removed.
4173         * WebInspector/webInspector/Images/squareButtonRightPressed.png: Removed.
4174         * WebInspector/webInspector/inspector.css:
4175         * WebInspector/webInspector/inspector.html:
4176         * WebInspector/webInspector/inspector.js:
4177
4178 2006-09-28  Alice Liu  <alice.liu@apple.com>
4179
4180         fixing the windows build
4181
4182         * COM/WebView.cpp:
4183         (WebView::mouseMoved):
4184         (WebView::mouseDown):
4185         (WebView::mouseUp):
4186         (WebView::mouseDoubleClick):
4187
4188 2006-09-27  Justin Garcia  <justin.garcia@apple.com>
4189
4190         Reviewed by thatcher
4191         
4192         <rdar://problem/4044271>
4193         Writing Direction menu doesn't reflect the current writing direction (9773)
4194
4195         * English.lproj/Localizable.strings: Added "Right to Left" and "Left to Right"
4196         * WebView/WebHTMLView.m:
4197         (-[NSArray validateUserInterfaceItem:]): Validate menu items that perform
4198         toggleBaseWritingDirection and changeBaseWritingDirection.  
4199         Disable the menu item that changes the writing direction to NSWritingDirectionNautral
4200         because NSWritingDirectionNatural's behavior can't be implemented with CSS.
4201         Take control of the title of the menu item that performs toggleBaseWritingDirection:
4202         instead of checking/unchecking it, otherwise we wouldn't know what a check means.
4203         (-[NSArray changeBaseWritingDirection:]): ASSERT that the requested writing
4204         direction is not NSWritingDirectionNatural, since we've disabled the
4205         menu item that performs it.
4206
4207 2006-09-27  MorganL  <morganl.webkit@yahoo.com>
4208
4209         Reviewed by Maciej, landed by Brady
4210