1 2009-11-24 Philippe Normand <pnormand@igalia.com>
3 Reviewed by Gustavo Noronha Silva.
5 [Gtk] GStreamer-CRITICAL's (and other warnings) on <video>
6 https://bugs.webkit.org/show_bug.cgi?id=26354
8 Implemented MediaPlayerPrivate::isAvailable by checking the
9 presence of the playbin2 GStreamer element.
11 * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
12 (WebCore::MediaPlayerPrivate::isAvailable):
13 * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
15 2009-11-24 Joanmarie Diggs <joanmarie.diggs@gmail.com>
17 Reviewed by Xan Lopez.
19 https://bugs.webkit.org/show_bug.cgi?id=25415
20 [GTK][ATK] Please implement support for get_text_at_offset
22 When building up the pango layout from text boxes, only append a
23 newline char after verifying there are no more boxes on this line.
25 * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
26 (getPangoLayoutForAtk):
28 2009-11-24 Joseph Pecoraro <joepeck@webkit.org>
30 Reviewed by Pavel Feldman.
32 Web Inspector: Keyboard Shortcut to Clear Console Messages
33 https://bugs.webkit.org/show_bug.cgi?id=31780
35 All Platforms: Ctrl+L = Clear Console Messages
36 Mac Only: Cmd+K = Clear Console Messages
38 * inspector/front-end/ConsoleView.js:
39 (WebInspector.ConsoleView): create shortcuts
40 (WebInspector.ConsoleView.prototype._promptKeyDown): handle shortcuts
41 * inspector/front-end/KeyboardShortcut.js:
42 (WebInspector.KeyboardShortcut.makeKey): convenience conversion of "a-z" character to keyCode
43 * inspector/front-end/ScriptsPanel.js:
44 (WebInspector.ScriptsPanel): style fixes for keyboard shortcuts
46 2009-11-24 Pavel Feldman <pfeldman@chromium.org>
48 Not reviewed: touch inspector controller in order to
49 kick win bot inspector deploy. rs=aroben.
51 * inspector/InspectorController.cpp:
53 2009-11-23 Pavel Feldman <pfeldman@chromium.org>
55 Reviewed by Timothy Hatcher.
57 Web Inspector: Implement expandable compartments on timeline panel.
59 https://bugs.webkit.org/show_bug.cgi?id=31796
61 * inspector/front-end/TimelineOverviewPane.js:
62 (WebInspector.TimelineOverviewPane.prototype._setWindowPosition):
63 * inspector/front-end/TimelinePanel.js:
64 (WebInspector.TimelinePanel):
65 (WebInspector.TimelinePanel.prototype.addRecordToTimeline):
66 (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
67 (WebInspector.TimelinePanel.prototype._formatRecord):
68 (WebInspector.TimelinePanel.prototype._refreshRecords):
69 (WebInspector.TimelinePanel.prototype._addToRecordsWindow):
70 (WebInspector.TimelineRecordListRow):
71 (WebInspector.TimelineRecordListRow.prototype.update):
72 (WebInspector.TimelineRecordListRow.prototype.dispose):
73 (WebInspector.TimelineRecordGraphRow):
74 (WebInspector.TimelineRecordGraphRow.prototype.update):
75 (WebInspector.TimelineRecordGraphRow.prototype._onClick):
76 (WebInspector.TimelineRecordGraphRow.prototype.dispose):
77 * inspector/front-end/inspector.css:
79 2009-11-24 Mark Rowe <mrowe@apple.com>
81 Fix production builds where the source tree may be read-only.
83 * WebCore.xcodeproj/project.pbxproj:
85 2009-11-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>
87 Reviewed by Kenneth Rohde Christiansen.
89 Include "config.h" to meet Coding Style Guidelines
90 https://bugs.webkit.org/show_bug.cgi?id=31792
92 No new tests as there is no new functionality.
94 * platform/graphics/win/IntPointWin.cpp:
95 * platform/graphics/win/IntRectWin.cpp:
96 * platform/graphics/win/IntSizeWin.cpp:
97 * platform/network/chromium/ResourceRequest.cpp:
98 * platform/win/PlatformMouseEventWin.cpp:
100 2009-11-23 Jian Li <jianli@chromium.org>
102 Reviewed by NOBODY (Chromium build fix).
104 * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
105 (WebCore::CALLBACK_FUNC_DECL):
106 * platform/graphics/GraphicsContext3D.h:
108 2009-11-23 Aaron Golden <agolden@apple.com>
110 Reviewed by Alexey Proskuryakov.
112 Prevent ResourceHandleMac's version of ResourceHandle::receivedCredential from stripping
113 identity and certificate information from a WebCore::Credential when receivedCredential
114 needs to modify the credential's persistence.
116 Adding a new constructor Credential(const Credential& original, CredentialPersistence)
117 that copies every field from original except for persistence.
119 * platform/network/Credential.cpp:
120 (WebCore::Credential::Credential):
121 * platform/network/Credential.h:
122 * platform/network/mac/ResourceHandleMac.mm:
123 (WebCore::ResourceHandle::receivedCredential):
125 2009-11-23 Gavin Barraclough <barraclough@apple.com>
127 Reviewed by Geoff Garen.
129 Part 2/3 of <rdar://problem/7377477> REGRESSION: Many web pages fail to render after interesting script runs in isolated world
131 Some clients of the JavaScriptCore API expect to be able to make callbacks over the JSC API,
132 and for this to automagically cause execution to take place in the world associated with the
133 global object associated with the ExecState (JSContextRef) passed. However this is not how
134 things work - the world must be explicitly set within WebCore.
136 Making this work just for API calls to evaluate & call will be a far from perfect solution,
137 since direct (non-API) use of JSC still relies on WebCore setting the current world correctly.
138 A better solution would be to make this all work automagically all throughout WebCore, but this
139 will require more refactoring.
141 Add references from the JSDOMWindowShell and the JSDOMGlobalObject to the world that owns them,
142 so that we can get to the world from the lexical global object of an ExecState. In the long-term
143 we should switch over to using this approach for all cases we want to get a world from an exec state.
145 * bindings/js/JSDOMBinding.cpp:
146 (WebCore::WebCoreJSClientData::beginningExecution):
147 (WebCore::WebCoreJSClientData::completedExecution):
148 * bindings/js/JSDOMBinding.h:
149 * bindings/js/JSDOMGlobalObject.h:
150 (WebCore::JSDOMGlobalObject::world):
151 (WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData):
152 * bindings/js/JSDOMWindowBase.cpp:
153 (WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData):
154 * bindings/js/JSDOMWindowBase.h:
155 * bindings/js/JSDOMWindowShell.cpp:
156 (WebCore::JSDOMWindowShell::JSDOMWindowShell):
157 * bindings/js/JSDOMWindowShell.h:
158 (WebCore::JSDOMWindowShell::world):
159 * bindings/js/JSWorkerContextBase.cpp:
160 (WebCore::JSWorkerContextBase::JSWorkerContextBase):
161 * bindings/js/ScriptController.cpp:
162 (WebCore::ScriptController::initScript):
164 2009-11-23 Chris Marrin <cmarrin@apple.com>
166 Reviewed by Oliver Hunt.
168 Add range checks to rendering calls in WebGL
169 https://bugs.webkit.org/show_bug.cgi?id=31239
171 I am now tracking the size of the data in each CanvasBuffer object
172 and keeping track of the buffer size of each active vertex attrib.
173 In drawArrays and drawElements I make sure no attempt is made to
174 access elements outside the valid buffer ranges. The test at:
176 http://cs.helsinki.fi/u/ilmarihe/c3d/functions/drawArraysOutOfBounds.html
180 I also added all the WebGL enumerations to GraphicsContext3D to use them in the validation checks
182 Tests: fast/canvas/webgl/drawArraysOutOfBounds.html
183 fast/canvas/webgl/drawElementssOutOfBounds.html
185 * bindings/js/JSWebGLArrayCustom.cpp:
187 * bindings/js/JSWebGLRenderingContextCustom.cpp:
188 (WebCore::JSWebGLRenderingContext::bufferData):
189 (WebCore::JSWebGLRenderingContext::bufferSubData):
190 (WebCore::JSWebGLRenderingContext::texSubImage2D):
191 * html/canvas/WebGLArrayBuffer.cpp:
192 (WebCore::WebGLArrayBuffer::create):
193 (WebCore::WebGLArrayBuffer::data):
194 * html/canvas/WebGLArrayBuffer.h:
195 * html/canvas/WebGLBuffer.cpp:
196 (WebCore::WebGLBuffer::WebGLBuffer):
197 (WebCore::WebGLBuffer::associateBufferData):
198 (WebCore::WebGLBuffer::associateBufferSubData):
199 (WebCore::WebGLBuffer::byteLength):
200 * html/canvas/WebGLBuffer.h:
201 (WebCore::WebGLBuffer::elementArrayBuffer):
202 * html/canvas/WebGLRenderingContext.cpp:
203 (WebCore::WebGLRenderingContext::WebGLRenderingContext):
204 (WebCore::WebGLRenderingContext::sizeInBytes):
205 (WebCore::WebGLRenderingContext::bindBuffer):
206 (WebCore::WebGLRenderingContext::bufferData):
207 (WebCore::WebGLRenderingContext::bufferSubData):
208 (WebCore::WebGLRenderingContext::createShader):
209 (WebCore::WebGLRenderingContext::disableVertexAttribArray):
210 (WebCore::WebGLRenderingContext::validateIndexArray):
211 (WebCore::WebGLRenderingContext::validateRenderingState):
212 (WebCore::WebGLRenderingContext::drawArrays):
213 (WebCore::WebGLRenderingContext::drawElements):
214 (WebCore::WebGLRenderingContext::enableVertexAttribArray):
215 (WebCore::WebGLRenderingContext::isFramebuffer):
216 (WebCore::WebGLRenderingContext::isProgram):
217 (WebCore::WebGLRenderingContext::isRenderbuffer):
218 (WebCore::WebGLRenderingContext::isShader):
219 (WebCore::WebGLRenderingContext::isTexture):
220 (WebCore::WebGLRenderingContext::useProgram):
221 (WebCore::WebGLRenderingContext::validateProgram):
222 (WebCore::WebGLRenderingContext::vertexAttribPointer):
223 (WebCore::WebGLRenderingContext::detachAndRemoveAllObjects):
224 * html/canvas/WebGLRenderingContext.h:
225 (WebCore::WebGLRenderingContext::VertexAttribState::VertexAttribState):
226 * html/canvas/WebGLRenderingContext.idl:
227 * html/canvas/WebGLShader.cpp:
228 (WebCore::WebGLShader::create):
229 (WebCore::WebGLShader::WebGLShader):
230 * html/canvas/WebGLShader.h:
231 * platform/graphics/GraphicsContext3D.h:
232 (WebCore::GraphicsContext3D::):
233 * platform/graphics/mac/GraphicsContext3DMac.cpp:
234 (WebCore::GraphicsContext3D::createShader):
236 2009-11-23 Erik Arvidsson <arv@chromium.org>
238 Reviewed by Eric Seidel.
240 JSC bindings for HasIndexGetter generates incorrect code (affects
241 MediaList and CSSStyleDeclaration).
242 This cleans up the edge cases for indexing out of range for style and
243 computed style objects to return an empty string according to the spec.
244 MediaList now returns null when indexed out of range.
245 https://bugs.webkit.org/show_bug.cgi?id=31683
247 Tests: fast/dom/CSSStyleDeclaration/css-computed-style-item.html
248 fast/dom/CSSStyleDeclaration/css-style-item.html
249 fast/dom/StyleSheet/css-medialist-item.html
251 * bindings/scripts/CodeGeneratorJS.pm: If IndexGetterReturnsString then
252 we do not check the length before calling the item function.
253 * css/CSSComputedStyleDeclaration.cpp:
254 (WebCore::CSSComputedStyleDeclaration::item):
255 * css/CSSMutableStyleDeclaration.cpp:
256 (WebCore::CSSMutableStyleDeclaration::item):
257 * css/CSSStyleDeclaration.idl:
259 2009-11-23 Simon Fraser <simon.fraser@apple.com>
261 Reviewed by Dan Bernstein.
263 DocumentMarkers need to be educated about transforms
264 https://bugs.webkit.org/show_bug.cgi?id=31751
266 Find highlight is incorrect with transforms
267 <rdar://problem/6358394>
269 Allow callers to specify that Frame::selectionTextRects() takes transforms into account
270 when computing the set of rects that encompass a selection. For transformed elemenets, the
271 selection rect will be the bounding box of the selected content.
273 Fix DocumentMarkers to cache rects in absolute coordinates, rather than painting coordinates.
275 Test: editing/selection/transformed-selection-rects.html
278 Frame::selectionTextRects() has a new parameter.
281 (WebCore::Document::setRenderedRectForMarker):
283 Pass the marker as a const reference.
287 (WebCore::Range::textQuads):
288 Add a new method, textQuads(), which returns a list of quads, respecting transforms.
292 (WebCore::Frame::selectionTextRects):
293 Add a new parameter, respectTransforms, and when that is RespectTransforms, use the quad
294 method to get quads for ranges, and then take their bounding boxes.
296 * rendering/InlineTextBox.h:
297 * rendering/InlineTextBox.cpp:
298 (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
299 (WebCore::InlineTextBox::paintTextMatchMarker):
300 (WebCore::InlineTextBox::computeRectForReplacementMarker):
301 (WebCore::InlineTextBox::paintDocumentMarkers):
302 (WebCore::InlineTextBox::textPos):
303 (WebCore::InlineTextBox::offsetForPosition):
305 Pass DocumentMarkers as a const references.
306 Convert the argument to setRenderedRectForMarker() into absolute coordinates.
308 * rendering/RenderView.cpp:
309 (WebCore::RenderView::selectionBounds):
311 2009-11-23 Dirk Schulze <krit@webkit.org>
313 Reviewed by Oliver Hunt.
315 [Cairo] support blurred test-shadow
316 [https://bugs.webkit.org/show_bug.cgi?id=31797]
318 Support for blurred text-shadows on Cairo. This patch
319 reuses the code of blurred box-shadows, introduced in
320 bug 26102. For a full textshadow support, a filters enabled
323 * platform/graphics/cairo/FontCairo.cpp:
324 (WebCore::Font::drawGlyphs):
326 2009-11-23 Jens Alfke <snej@chromium.org>
328 Reviewed by Geoffrey Garen.
330 Change incorrect calls to the constructor "EventNames()" to the correct accessor
331 "eventNames()". This saves ~100 AtomicString lookups each time.
332 https://bugs.webkit.org/show_bug.cgi?id=31811
334 * dom/EventNames.h: Make constructor private to prevent this from happening again.
335 * history/CachedFrame.cpp:
336 (WebCore::CachedFrameBase::restore): EventNames() --> eventNames()
337 * html/HTMLFormControlElement.cpp:
338 (WebCore::HTMLFormControlElement::checkValidity): EventNames() --> eventNames()
339 * loader/FrameLoader.cpp:
340 (WebCore::FrameLoader::stopLoading): EventNames() --> eventNames()
341 (WebCore::FrameLoader::pageHidden): EventNames() --> eventNames()
342 * page/DOMWindow.cpp:
343 (WebCore::DOMWindow::dispatchAllPendingUnloadEvents): EventNames() --> eventNames()
345 2009-11-23 Adam Langley <agl@google.com>
347 Reviewed by Dmitry Titov.
349 Chromium Linux: Limit the stroke width and mitre limit.
351 Limit the stroke width and mitre limit that we'll pass into Skia to
352 avoid overflowing Skia's uint16_t glyph widths.
354 http://code.google.com/p/chromium/issues/detail?id=28250
355 https://bugs.webkit.org/show_bug.cgi?id=31747
357 * platform/graphics/skia/PlatformContextSkia.cpp:
359 (PlatformContextSkia::setupPaintForStroking):
361 2009-11-23 Alexey Proskuryakov <ap@apple.com>
363 Reviewed by Oliver Hunt.
365 https://bugs.webkit.org/show_bug.cgi?id=31812
366 WebSocket code uses RefPtr::get() where it shouldn't
368 No change in funcitonality, just coding style correction.
370 * websockets/WebSocket.cpp:
371 (WebCore::WebSocket::~WebSocket):
372 * websockets/WebSocketChannel.cpp:
373 (WebCore::WebSocketChannel::connect):
374 (WebCore::WebSocketChannel::send):
375 (WebCore::WebSocketChannel::bufferedAmount):
376 (WebCore::WebSocketChannel::close):
377 (WebCore::WebSocketChannel::disconnect):
378 (WebCore::WebSocketChannel::didOpen):
379 (WebCore::WebSocketChannel::didClose):
380 (WebCore::WebSocketChannel::didReceiveData):
381 (WebCore::WebSocketChannel::didFail):
383 2009-11-23 Alexey Proskuryakov <ap@apple.com>
387 * platform/network/cf/SocketStreamHandleCFNet.cpp:
388 (WebCore::SocketStreamHandle::pacExecutionCallbackMainThread): pacExecutionCallbackMainThread
389 is static, so it can't use member variables directly.
391 2009-11-23 Alexey Proskuryakov <ap@apple.com>
393 Reviewed by Brady Eidson.
395 https://bugs.webkit.org/show_bug.cgi?id=31748
396 Make WebSocketHandleCFNet respect proxy auto-configuration files via CFProxySupport
398 * platform/network/cf/SocketStreamHandle.h: Removed names from some void* arguments, since
399 they didn't carry useful information.
401 * platform/network/cf/SocketStreamHandleCFNet.cpp:
402 (WebCore::SocketStreamHandle::SocketStreamHandle): When we need an http-style URL, we actually
404 (WebCore::SocketStreamHandle::scheduleStreams): Factored out from constructor, since streams
405 only get scheduled after PAC is fetched and executed asynchronously.
406 (WebCore::SocketStreamHandle::copyPACExecutionDescription): Return a description for event
408 (WebCore::MainThreadPACCallbackInfo::MainThreadPACCallbackInfo): Forward callback to main thread.
409 (WebCore::SocketStreamHandle::pacExecutionCallback): Ditto.
410 (WebCore::SocketStreamHandle::pacExecutionCallbackMainThread): Ditto. To avoid code duplication,
411 we make the call even on Mac.
412 (WebCore::SocketStreamHandle::executePACFileURL): Make an async call to CFNetworkExecuteProxyAutoConfigurationURL.
413 (WebCore::SocketStreamHandle::removePACRunLoopSource): Once PAC execution is done or aborted,
414 we need to get rid of the event source.
415 (WebCore::SocketStreamHandle::chooseProxy): Use stored m_httpsURL.get.
416 (WebCore::SocketStreamHandle::chooseProxyFromArray): Factored out from chooseProxy - the
417 array may come directly from system configuration, or from PAC.
418 (WebCore::SocketStreamHandle::chooseProxy): Tiger version of this function is now completely
420 (WebCore::SocketStreamHandle::~SocketStreamHandle): Run loop source should be destroyed
421 before we get to the destructor.
422 (WebCore::SocketStreamHandle::platformClose): Destroy the run loop source, if PAC execution
423 is still in progress.
425 2009-11-23 Oliver Hunt <oliver@apple.com>
427 Reviewed by Geoff Garen.
429 Don't leak the CGImage we create when drawing a sub image.
431 * platform/graphics/cg/ImageCG.cpp:
432 (WebCore::BitmapImage::draw):
434 2009-11-23 Adam Barth <abarth@webkit.org>
436 Reviewed by Dimitri Glazkov.
438 [V8] Don't crash when OOM in creating isolated world
439 https://bugs.webkit.org/show_bug.cgi?id=31805
441 We need to add some more null checks to avoid crashing. No new tests
442 because we don't have a good way to test out-of-memory bugs.
444 * bindings/v8/V8Proxy.cpp:
445 (WebCore::V8Proxy::evaluateInIsolatedWorld):
446 (WebCore::V8Proxy::evaluateInNewContext):
447 (WebCore::V8Proxy::setInjectedScriptContextDebugId):
448 * bindings/v8/V8Proxy.h:
450 2009-11-23 Dirk Schulze <krit@webkit.org>
452 Reviewed by Nikolas Zimmermann.
454 This is the implementation of the filterRes attribute. It
455 helps the SVG developer to set the quality of a filter by
456 giving the width or height of filter.
457 This patch also sets the filter resolution to lower values
458 if a intermediate ImageBuffer size is bigger than the given
460 The maximal size is set to 5000x5000 by default. This is a
461 subjectiv decission. Everthing greater than this values gets
462 sensible slower. Values of 10000x10000 crashed on WebKitGtk.
463 For mobil devices a maximum size of 100x100 or 200x200 seems
465 The important fact on filter resolution is, that the output
466 size is still the size given by the <filter> element.
468 Tests: svg/filters/big-sized-filter-2.svg
469 svg/filters/big-sized-filter.svg
470 svg/filters/filterRes.svg
472 * platform/graphics/FloatRect.cpp:
473 (WebCore::FloatRect::scale): Add the abbility to scale a rect by x and y.
474 * platform/graphics/FloatRect.h:
475 (WebCore::FloatRect::scale): Add the abbility to scale a rect by x and y.
476 * platform/graphics/cairo/GraphicsContextCairo.cpp:
477 (WebCore::GraphicsContext::createPlatformShadow): Use scaledSubRegion for
479 * platform/graphics/filters/FEBlend.cpp:
480 (WebCore::FEBlend::apply): Use scaledSubRegion for effect intern calculations.
481 * platform/graphics/filters/FEColorMatrix.cpp:
482 (WebCore::FEColorMatrix::apply): Use scaledSubRegion for effect intern calculations.
483 * platform/graphics/filters/FEComponentTransfer.cpp:
484 (WebCore::FEComponentTransfer::apply): Use scaledSubRegion for effect intern
486 * platform/graphics/filters/FEComposite.cpp:
487 (WebCore::FEComposite::apply): Use scaledSubRegion for effect intern calculations.
488 * platform/graphics/filters/FEGaussianBlur.cpp:
489 (WebCore::FEGaussianBlur::apply): Use scaledSubRegion for effect intern calculations.
490 * platform/graphics/filters/Filter.h: Add the abbility to change the quality
492 (WebCore::Filter::filterResolution):
493 (WebCore::Filter::setFilterResolution):
494 (WebCore::Filter::calculateEffectSubRegion): Calculates the correct subRegion
495 as well as the scaledSubRegion. It also searches for the biggest effect size.
496 We have to change the filter resolution, if one intermediate ImageBuffer size
497 doesn't fit in the maximal image size.
498 * platform/graphics/filters/FilterEffect.cpp:
499 (WebCore::FilterEffect::calculateDrawingIntRect): Use scaledSubRegion to get
500 the right part of a previous effect result.
501 (WebCore::FilterEffect::calculateDrawingRect): Use scaledSubRegion to get
502 the right part of a previous effect result.
503 (WebCore::FilterEffect::getEffectContext): Use scaledSubRegion to create
504 a new intermediate ImageBuffer for the result of the current effect.
505 * platform/graphics/filters/FilterEffect.h:
506 (WebCore::FilterEffect::scaledSubRegion): The scaled subRegion of a the
508 (WebCore::FilterEffect::setScaledSubRegion):
509 (WebCore::FilterEffect::effectBoundaries): The original values of the
510 EffectElement for a second subRegion calculation.
511 (WebCore::FilterEffect::setEffectBoundaries):
512 * platform/graphics/filters/ImageBufferFilter.cpp:
513 (WebCore::ImageBufferFilter::ImageBufferFilter): Set the scale factor to one.
514 * platform/graphics/filters/ImageBufferFilter.h:
515 (WebCore::ImageBufferFilter::maxImageSize):
516 (WebCore::ImageBufferFilter::calculateEffectSubRegion):
517 * platform/graphics/filters/SourceAlpha.cpp:
518 (WebCore::SourceAlpha::calculateEffectRect): Use scaledSubRegion for effect
520 * platform/graphics/filters/SourceGraphic.cpp:
521 (WebCore::SourceGraphic::calculateEffectRect): Use scaledSubRegion for effect
523 * svg/SVGFilterElement.cpp:
524 (WebCore::SVGFilterElement::parseMappedAttribute): Parse filterRes attribute.
525 (WebCore::SVGFilterElement::buildFilter): Give SVGResourceFilter the current
527 * svg/SVGFilterPrimitiveStandardAttributes.cpp:
528 (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes): Save
529 values to effectBoundaries of the filter effect
530 * svg/graphics/SVGResourceFilter.cpp:
531 (WebCore::SVGResourceFilter::SVGResourceFilter):
532 (WebCore::shouldProcessFilter): Return signal if a neccessary value is zero.
533 (WebCore::SVGResourceFilter::fitsInMaximumImageSize): Checks if the given size
534 fits into the maximal image size, modifys scale factors if not and return a
536 (WebCore::SVGResourceFilter::prepareFilter): Scale the SourceImage to
537 filterResolution (given by FilterElement or calculated on to big image sizes).
538 Set the scale level to SVGFilter.
539 (WebCore::SVGResourceFilter::applyFilter): Don't apply filters if shouldProcessFilter
541 * svg/graphics/SVGResourceFilter.h:
542 (WebCore::SVGResourceFilter::setFilterResolution): FilterResolution of FilterElement.
543 (WebCore::SVGResourceFilter::setHasFilterResolution): Does FilterElement provides
545 (WebCore::SVGResourceFilter::scaleX): Current scale factor for horizontal.
546 (WebCore::SVGResourceFilter::scaleY): Current scale factor for vertical.
547 * svg/graphics/filters/SVGFEDisplacementMap.cpp:
548 (WebCore::FEDisplacementMap::apply): Use scaledSubRegion for effect intern calculations.
549 Kernel values are scaled to current filter resolution too.
550 * svg/graphics/filters/SVGFEFlood.cpp:
551 (WebCore::FEFlood::apply): Use scaledSubRegion for effect intern calculations.
552 * svg/graphics/filters/SVGFEMerge.cpp:
553 (WebCore::FEMerge::apply): Use scaledSubRegion for effect intern calculations.
554 Kernel values are scaled to current filter resolution too.
555 * svg/graphics/filters/SVGFEMorphology.cpp:
556 (WebCore::FEMorphology::apply): Use scaledSubRegion for effect intern calculations.
557 Kernel values are scaled to current filter resolution too.
558 * svg/graphics/filters/SVGFEOffset.cpp:
559 (WebCore::FEOffset::apply): Use scaledSubRegion for effect intern calculations.
560 * svg/graphics/filters/SVGFETile.cpp:
561 (WebCore::FETile::apply): Use scaledSubRegion for effect intern calculations.
562 * svg/graphics/filters/SVGFilter.cpp:
563 (WebCore::SVGFilter::calculateEffectSubRegion): Calculate subRegion for LayoutTests,
564 scaledSubRegion according to the current filterResolution and get the maximal image size.
565 * svg/graphics/filters/SVGFilter.h:
566 (WebCore::SVGFilter::effectBoundingBoxMode): Original values of the FilterElement.
567 (WebCore::SVGFilter::filterRegion): Use virtual for clarification.
568 (WebCore::SVGFilter::sourceImageRect): Use virtual for clarification.
569 (WebCore::SVGFilter::maxImageSize): Get the maximal image size.
571 2009-11-23 Simon Hausmann <simon.hausmann@nokia.com>
573 Reviewed by Kenneth Rohde Christiansen.
575 [Qt] Wrong runtime instance objects of wrapped QObjects may be used if
576 the wrapped object died before the gc removed the instance.
578 https://bugs.webkit.org/show_bug.cgi?id=31681
580 Before using a cached instance, verify that its wrapped QObject is
583 * bridge/qt/qt_instance.cpp:
584 (JSC::Bindings::QtInstance::getQtInstance):
585 * bridge/qt/qt_instance.h:
586 (JSC::Bindings::QtInstance::hashKey):
588 2009-11-22 Chris Fleizach <cfleizach@apple.com>
590 Reviewed by Oliver Hunt.
592 ARIA: support aria-flowto
593 https://bugs.webkit.org/show_bug.cgi?id=31762
595 Test: platform/mac/accessibility/aria-flowto.html
597 * accessibility/AccessibilityObject.h:
598 (WebCore::AccessibilityObject::ariaOwnsElements):
599 (WebCore::AccessibilityObject::supportsARIAFlowTo):
600 (WebCore::AccessibilityObject::ariaFlowToElements):
601 * accessibility/AccessibilityRenderObject.cpp:
602 (WebCore::AccessibilityRenderObject::linkedUIElements):
603 (WebCore::AccessibilityRenderObject::supportsARIAFlowTo):
604 (WebCore::AccessibilityRenderObject::ariaFlowToElements):
605 * accessibility/AccessibilityRenderObject.h:
606 * html/HTMLAttributeNames.in:
608 2009-11-22 Nikolas Zimmermann <nzimmermann@rim.com>
610 Not reviewed. Build fix for WML enabled builds.
611 Adopt WebCore API changes.
613 * wml/WMLAElement.cpp:
614 (WebCore::WMLAElement::defaultEventHandler):
615 * wml/WMLInputElement.cpp:
616 (WebCore::WMLInputElement::defaultEventHandler):
618 2009-11-22 Pavel Feldman <pfeldman@chromium.org>
620 Reviewed by Timothy Hatcher.
622 Web Inspector: Introduce sidebar background on timeline panel in order
623 to prevent it from flickering on scroll.
625 https://bugs.webkit.org/show_bug.cgi?id=31789
627 * inspector/front-end/TimelinePanel.js:
628 (WebInspector.TimelinePanel):
629 (WebInspector.TimelinePanel.prototype.setSidebarWidth):
630 (WebInspector.TimelinePanel.prototype._onScroll):
631 (WebInspector.TimelinePanel.prototype._scheduleRefresh):
632 * inspector/front-end/inspector.css:
634 2009-11-22 Pavel Feldman <pfeldman@chromium.org>
636 Reviewed by Timothy Hatcher.
638 Web Inspector: Reimplement TimelinePanel to make it fast:
639 - Extract grid and overview into separate files
640 - Make timeline create only divs for visible rows
642 https://bugs.webkit.org/show_bug.cgi?id=31784
645 * WebCore.vcproj/WebCore.vcproj:
646 * inspector/front-end/AbstractTimelinePanel.js:
647 (WebInspector.AbstractTimelinePanel.prototype.createInterface):
648 (WebInspector.AbstractTimelinePanel.prototype.refresh):
649 (WebInspector.AbstractTimelinePanel.prototype.set calculator):
650 * inspector/front-end/TimelineGrid.js: Added.
651 (WebInspector.TimelineGrid):
652 (WebInspector.TimelineGrid.prototype.get itemsGraphsElement):
653 (WebInspector.TimelineGrid.prototype.updateDividers):
654 (WebInspector.TimelineGrid.prototype.addEventDivider):
655 (WebInspector.TimelineGrid.prototype.setScrollAndDividerTop):
656 * inspector/front-end/TimelineOverviewPane.js: Added.
657 (WebInspector.TimelineOverviewPane):
658 (WebInspector.TimelineOverviewPane.prototype._onCheckboxClicked):
659 (WebInspector.TimelineOverviewPane.prototype.update):
660 (WebInspector.TimelineOverviewPane.prototype.setSidebarWidth):
661 (WebInspector.TimelineOverviewPane.prototype.updateMainViewWidth):
662 (WebInspector.TimelineOverviewPane.prototype.reset):
663 (WebInspector.TimelineOverviewPane.prototype._resizeWindow):
664 (WebInspector.TimelineOverviewPane.prototype._windowResizeDragging):
665 (WebInspector.TimelineOverviewPane.prototype._dragWindow):
666 (WebInspector.TimelineOverviewPane.prototype._windowDragging):
667 (WebInspector.TimelineOverviewPane.prototype._resizeWindowLeft):
668 (WebInspector.TimelineOverviewPane.prototype._resizeWindowRight):
669 (WebInspector.TimelineOverviewPane.prototype._setWindowPosition):
670 (WebInspector.TimelineOverviewPane.prototype._endWindowDragging):
671 (WebInspector.TimelineOverviewCalculator):
672 (WebInspector.TimelineOverviewCalculator.prototype.computeBarGraphPercentages):
673 (WebInspector.TimelineOverviewCalculator.prototype.reset):
674 (WebInspector.TimelineOverviewCalculator.prototype.updateBoundaries):
675 (WebInspector.TimelineOverviewCalculator.prototype.get boundarySpan):
676 (WebInspector.TimelineOverviewCalculator.prototype.formatValue):
677 (WebInspector.TimelineCategoryTreeElement):
678 (WebInspector.TimelineCategoryTreeElement.prototype.onattach):
679 (WebInspector.TimelineCategoryGraph):
680 (WebInspector.TimelineCategoryGraph.prototype.get graphElement):
681 (WebInspector.TimelineCategoryGraph.prototype.addChunk):
682 (WebInspector.TimelineCategoryGraph.prototype.clearChunks):
683 (WebInspector.TimelineCategoryGraph.prototype.set dimmed):
684 * inspector/front-end/TimelinePanel.js:
685 (WebInspector.TimelinePanel):
686 (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
687 (WebInspector.TimelinePanel.prototype.addRecordToTimeline):
688 (WebInspector.TimelinePanel.prototype._formatRecord):
689 (WebInspector.TimelinePanel.prototype.setSidebarWidth):
690 (WebInspector.TimelinePanel.prototype.updateMainViewWidth):
691 (WebInspector.TimelinePanel.prototype.resize):
692 (WebInspector.TimelinePanel.prototype.reset):
693 (WebInspector.TimelinePanel.prototype.show):
694 (WebInspector.TimelinePanel.prototype._onScroll):
695 (WebInspector.TimelinePanel.prototype._scheduleRefresh):
696 (WebInspector.TimelinePanel.prototype._refresh):
697 (WebInspector.TimelinePanel.prototype._refreshRecords):
698 (WebInspector.TimelinePanel.prototype._adjustScrollPosition):
699 (WebInspector.TimelineCategory):
700 (WebInspector.TimelineCalculator):
701 (WebInspector.TimelineCalculator.prototype.get boundarySpan):
702 (WebInspector.TimelineRecordListRow):
703 (WebInspector.TimelineRecordListRow.prototype.update):
704 (WebInspector.TimelineRecordGraphRow):
705 (WebInspector.TimelineRecordGraphRow.prototype.update):
706 * inspector/front-end/WebKit.qrc:
707 * inspector/front-end/inspector.css:
708 * inspector/front-end/inspector.html:
710 2009-11-22 Chris Evans <cevans@chromium.org>
712 Reviewed by Adam Barth.
714 Disable access to file:/// directory listings
715 https://bugs.webkit.org/show_bug.cgi?id=31329
717 Deny access to directory listings. This needs doing in WebKit for
718 WebKit clients that do permit top-level navigation to file:///dir.
719 This matches Firefox, plus the existing Safari implementation (which
720 does not support any directory access at all). It will fix the
721 LayoutTest named below for Chromium.
723 Test: fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html
725 * page/SecurityOrigin.cpp: Deny access to directory listings.
726 (WebCore::SecurityOrigin::SecurityOrigin):
727 (WebCore::SecurityOrigin::canRequest):
729 2009-11-20 Joseph Pecoraro <joepeck@webkit.org>
731 Reviewed by Timothy Hatcher.
733 Web Inspector: Support Ctrl+P and Ctrl+N, Readline keyboard shortcuts in the Console
734 https://bugs.webkit.org/show_bug.cgi?id=31400
736 Handle the following when on a Mac:
738 Ctrl+P = Previous (like Up arrow)
739 Ctrl+N = Next (like Down arrow)
741 No longer rerun autocompletion when just pushing a modifier key
742 like Control, Alt, Shift, or Meta.
744 Improved arrow key behavior with Multiline code in the Console, with the following behavior:
746 Up = Previous Command if on First Line (caret moves to the end of the first line)
747 otherwise default caret movement in text.
748 Down = Next Command if on Last Line (caret naturally moves to the end)
749 otherwise default caret movement in text.
751 * inspector/front-end/TextPrompt.js:
752 (WebInspector.TextPrompt.prototype.handleKeyEvent): handle new keyboard shortcuts
753 (WebInspector.TextPrompt.prototype.isCaretOnFirstLine): check if the caret is on the top line
754 (WebInspector.TextPrompt.prototype.isCaretOnLastLine): check if the caret is on the bottom line
755 (WebInspector.TextPrompt.prototype._upKeyPressed):
756 (WebInspector.TextPrompt.prototype._downKeyPressed):
757 (WebInspector.TextPrompt.prototype._moveBackInHistory):
758 (WebInspector.TextPrompt.prototype._moveForwardInHistory):
760 2009-11-21 Jessie Berlin <jberlin@webkit.org>
762 Reviewed by Timothy Hatcher.
764 Adds a tooltip containing the full url of the resource to each element
765 in the Resources panel so that it is possible to quickly see the query
767 https://bugs.webkit.org/show_bug.cgi?id=19103
769 * inspector/front-end/ResourcesPanel.js:
770 (WebInspector.ResourceSidebarTreeElement.prototype.refresh):
771 Set the tooltip to be the resource's url.
773 2009-11-21 Simon Fraser <simon.fraser@apple.com>
775 Reviewed by Dan Bernstein.
777 CSSKeyframesRule::findRule() and deleteRule() should accept 'from' and 'to' as well as percentages
778 https://bugs.webkit.org/show_bug.cgi?id=31588
780 In WebKitCSSKeyframesRule::findRuleIndex(), map 'from' to 0% an 'to' to 100%
781 so that findRule() and deleteRule() work with these keywords.
783 * css/WebKitCSSKeyframesRule.cpp:
784 (WebCore::WebKitCSSKeyframesRule::findRuleIndex):
786 2009-11-21 Daniel Bates <dbates@webkit.org>
788 Reviewed by Eric Seidel.
790 https://bugs.webkit.org/show_bug.cgi?id=31647
792 Changed KeyboardEvent::m_keyEvent from a raw pointer to an OwnPtr.
794 No functionality was changed. So, no new tests.
796 * dom/KeyboardEvent.cpp:
797 (WebCore::KeyboardEvent::~KeyboardEvent):
798 * dom/KeyboardEvent.h: Changed m_keyEvent to OwnPtr.
799 (WebCore::KeyboardEvent::keyEvent):
801 2009-11-20 Chris Fleizach <cfleizach@apple.com>
803 Reviewed by Beth Dakin.
805 WAI-ARIA: add support for aria-owns
806 https://bugs.webkit.org/show_bug.cgi?id=31702
808 Re-organized how accessibilityAttributeNames are returned so
809 that it's possible for an element to add an attribute based on
810 a dynamic value. In this case, we only want to add AXOwn if the
811 element actually supports aria-owns.
813 Test: platform/mac/accessibility/aria-owns.html
815 * accessibility/AccessibilityObject.h:
816 (WebCore::AccessibilityObject::supportsARIAOwns):
817 (WebCore::AccessibilityObject::ariaOwnsElements):
818 * accessibility/AccessibilityRenderObject.cpp:
819 (WebCore::AccessibilityRenderObject::ariaOwnsElements):
820 (WebCore::AccessibilityRenderObject::supportsARIAOwns):
821 * accessibility/AccessibilityRenderObject.h:
822 * accessibility/mac/AccessibilityObjectWrapper.mm:
823 (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
824 (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
825 (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
826 * html/HTMLAttributeNames.in:
828 2009-11-20 Eric Carlson <eric.carlson@apple.com>
830 Reviewed by Simon Fraser.
832 <rdar://problem/7414396> Leopard & Tiger: Support closed caption in <video> element
834 * css/mediaControls.css:
835 Define closed caption toggle button.
837 * rendering/RenderMedia.cpp:
838 (WebCore::RenderMedia::updateControls):
839 Create closed caption toggle button in display order.
841 * rendering/RenderThemeMac.mm:
842 (WebCore::RenderThemeMac::shouldRenderMediaControlPart):
843 Don't require MediaControllerThemeQuickTime theme for captions toggle button.
844 No need to check if the movie has video, a closed captions track is a video
847 2009-11-20 Joseph Pecoraro <joepeck@webkit.org>
849 Reviewed by Timothy Hatcher.
851 Web Inspector: Running code in the Console that ends with a
852 single line comment no longer produces a parse error.
854 * inspector/front-end/InjectedScript.js:
855 (InjectedScript._evaluateOn):
857 2009-11-20 Chris Fleizach <cfleizach@apple.com>
859 Reviewed by Beth Dakin.
861 WAI-ARIA: add support for 'math' role
862 https://bugs.webkit.org/show_bug.cgi?id=31706
864 * accessibility/AccessibilityObject.cpp:
865 * accessibility/AccessibilityObject.h:
866 * accessibility/mac/AccessibilityObjectWrapper.mm:
868 2009-11-20 Yael Aharon <yael.aharon@nokia.com>
870 Reviewed by Kenneth Rohde Christiansen.
872 NPN_ReloadPlugins does not reload the page even if reloadPages is true.
873 https://bugs.webkit.org/show_bug.cgi?id=30460
875 Replace call to PluginDatabase::installedPlugins()->refresh() with Page::refreshPlugins().
876 It already refreshes plugins and reloads pages when necessary.
878 Tests: plugins/reloadplugins-and-pages.html
879 plugins/reloadplugins-no-pages.html
881 * plugins/PluginInfoStore.cpp:
882 (WebCore::refreshPlugins):
884 2009-11-20 Oliver Hunt <oliver@apple.com>
886 Reviewed by Dave Hyatt.
888 <rdar://7409188> WebKit needs to be able to serialize and deserialize objects.
890 Expose WebCore object serialization to WebKit.
893 * bindings/js/SerializedScriptValue.cpp:
894 (WebCore::SerializedScriptValue::~SerializedScriptValue):
895 (WebCore::SerializedScriptValue::create):
896 (WebCore::SerializedScriptValue::deserialize):
897 * bindings/js/SerializedScriptValue.h:
899 2009-11-20 Brian Weinstein <bweinstein@apple.com>
901 Reviewed by Tim Hatcher.
903 Fixes <http://webkit.org/b/31741>.
904 Web Inspector: User Entered Data on the console should show up no matter what filters.
906 Always show .console-user-command-result, no matter what the filter say
907 we should do with the other classes.
909 * inspector/front-end/inspector.css:
911 2009-11-20 Brian Weinstein <bweinstein@apple.com>
913 Reviewed by Tim Hatcher.
915 Fixes <http://webkit.org/b/31700>.
916 Web Inspector: isMac should be in one central location + Cached.
918 We should cache the value of isMac, and make the indexOf call in one
919 single location, because we are calling it from multiple places, and saving
920 the result can save us time, and make the call sites simpler.
922 * inspector/front-end/AbstractTimelinePanel.js:
923 (WebInspector.AbstractTimelinePanel.prototype._updateFilter):
924 * inspector/front-end/ConsoleView.js:
925 (WebInspector.ConsoleView.prototype._updateFilter):
926 * inspector/front-end/ElementsPanel.js:
927 (WebInspector.ElementsPanel.prototype.handleKeyEvent):
928 * inspector/front-end/ScriptsPanel.js:
929 (WebInspector.ScriptsPanel):
930 * inspector/front-end/SourceFrame.js:
931 (WebInspector.SourceFrame.prototype._loaded):
932 * inspector/front-end/inspector.js:
933 (WebInspector.documentKeyDown):
934 (WebInspector.isMac):
936 2009-11-19 Joseph Pecoraro <joepeck@webkit.org>
938 Removed .DS_Store accidentally added in last (r51245).
940 2009-11-19 Joseph Pecoraro <joepeck@webkit.org>
942 Reviewed by Timothy Hatcher.
944 Web Inspector: Add Console Only Layout Mode
945 https://bugs.webkit.org/show_bug.cgi?id=30282
947 Adds a Console Panel, which allows for a Full size Console. This
948 extends the Drawer to the size of a Panel. This also fixes previous
949 resize issues with the Drawer.
951 * inspector/front-end/ConsolePanel.js: added.
952 (WebInspector.ConsolePanel):
953 (WebInspector.ConsolePanel.prototype.toolbarItemClass.get toolbarItemLabel):
954 (WebInspector.ConsolePanel.prototype.show):
955 (WebInspector.ConsolePanel.prototype.hide):
956 * inspector/front-end/Drawer.js:
957 (WebInspector.Drawer):
958 (WebInspector.Drawer.prototype.set visibleView):
959 (WebInspector.Drawer.prototype.get savedHeight): access the saved height of the variable console.
960 (WebInspector.Drawer.prototype.show.animationFinished):
961 (WebInspector.Drawer.prototype.show):
962 (WebInspector.Drawer.prototype.hide.animationFinished):
963 (WebInspector.Drawer.prototype.hide):
964 (WebInspector.Drawer.prototype.resize): resize appropriately if full/non-full
965 (WebInspector.Drawer.prototype.enterPanelMode):
966 (WebInspector.Drawer.prototype.exitPanelMode):
967 (WebInspector.Drawer.prototype.immediatelyExitPanelMode):
968 (WebInspector.Drawer.prototype._cancelAnimationIfNeeded):
969 (WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished):
970 (WebInspector.Drawer.prototype._animateDrawerHeight):
971 (WebInspector.Drawer.prototype._animationDuration):
972 (WebInspector.Drawer.prototype._startStatusBarDragging):
973 (WebInspector.Drawer.prototype._statusBarDragging):
974 (WebInspector.Drawer.prototype._endStatusBarDragging):
976 Miscellaneous changes and cleanup.
978 * English.lproj/localizedStrings.js: "Console" toolbar title.
979 * inspector/front-end/ConsoleView.js: removed unnecessary element reordering
980 * inspector/front-end/Images/consoleIcon.png: added.
981 * inspector/front-end/inspector.css: added icon.
982 * inspector/front-end/inspector.html:
983 * inspector/front-end/inspector.js:
984 (WebInspector._createPanels): create console panel
985 (WebInspector.windowResize): resize drawer if necessary
986 (WebInspector.documentKeyDown): esc should not toggle the console when in panel mode
987 (WebInspector.animateStyle): start animation interval, returns the interval key
988 (WebInspector.toggleAttach): resize drawer if necessary
989 (WebInspector.showConsolePanel): restore the panel when the inspector restarts
990 (WebInspector.showProfileForURL): style fix
992 Restore the panel when the inspector restarts.
994 * inspector/InspectorController.cpp:
995 (WebCore::InspectorController::setWindowVisible):
996 (WebCore::InspectorController::specialPanelForJSName):
997 * inspector/InspectorFrontend.cpp:
998 (WebCore::InspectorFrontend::showPanel):
1003 * WebCore.vcproj/WebCore.vcproj:
1004 * inspector/front-end/WebKit.qrc:
1006 2009-11-20 Brian Weinstein <bweinstein@apple.com>
1008 Reviewed by Tim Hatcher.
1010 Fixes <http://webkit.org/b/31699>.
1011 Web Inspector: Should Cache Values of InspectorController.platform() and port().
1013 Refactor the Inspector to cache the value of InspectorController.platform
1014 and InspectorController.port, because those need to call into C++, they are
1015 being called more and more as we add platform specific keyboard shortcuts, and
1016 they shouldn't change in the lifecycle of the Web Inspector.
1018 * inspector/front-end/AbstractTimelinePanel.js:
1019 (WebInspector.AbstractTimelinePanel.prototype._updateFilter):
1020 * inspector/front-end/ConsoleView.js:
1021 (WebInspector.ConsoleView.prototype._updateFilter):
1022 * inspector/front-end/ElementsPanel.js:
1023 (WebInspector.ElementsPanel.prototype.handleKeyEvent):
1024 * inspector/front-end/ScriptsPanel.js:
1025 (WebInspector.ScriptsPanel):
1026 * inspector/front-end/SourceFrame.js:
1027 (WebInspector.SourceFrame.prototype._loaded):
1028 * inspector/front-end/inspector.js:
1029 (WebInspector.get platform):
1030 (WebInspector.get port):
1031 (WebInspector.loaded):
1032 (WebInspector.documentKeyDown):
1033 (WebInspector.toolbarDragStart):
1035 2009-11-20 Dirk Schulze <krit@webkit.org>
1037 Unreviewed build fix for filters enabled builds.
1039 * platform/graphics/filters/FEColorMatrix.cpp:
1040 (WebCore::FEColorMatrix::apply):
1041 * platform/graphics/filters/FEComposite.cpp:
1042 (WebCore::FEComposite::apply):
1043 * platform/graphics/filters/SourceGraphic.cpp:
1044 (WebCore::SourceGraphic::apply):
1045 * svg/graphics/SVGResourceFilter.cpp:
1046 (WebCore::SVGResourceFilter::applyFilter):
1047 * svg/graphics/filters/SVGFEMerge.cpp:
1048 (WebCore::FEMerge::apply):
1049 * svg/graphics/filters/SVGFEOffset.cpp:
1050 (WebCore::FEOffset::apply):
1051 * svg/graphics/filters/SVGFETile.cpp:
1052 (WebCore::FETile::apply):
1054 2009-11-20 Eric Carlson <eric.carlson@apple.com>
1056 Reviewed by Simon Fraser.
1058 <rdar://problem/7389945> QTKit based media engine should not claim to support
1059 fullscreen on Leopard
1061 * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
1062 (WebCore::MediaPlayerPrivate::supportsFullscreen):
1063 Only return true on SnowLeopard for now.
1065 * rendering/RenderThemeMac.mm:
1066 (WebCore::RenderThemeMac::shouldRenderMediaControlPart):
1067 No need to special case MediaFullscreenButtonPart as the default implementation
1068 asks the media engine if it supports fullscreen.
1070 2009-11-18 Girish Ramakrishnan <girish@forwardbias.in>
1072 Reviewed by Simon Hausmann.
1074 Patch by Yongjun Zhang <yongjun.zhang@nokia.com> and
1075 Girish Ramakrishnan <girish@forwardbias.in>
1077 [Qt] Implement support for rendering plugins on Qt/Mac when a page is used
1078 without a QWebView or when inside QGraphicsWebView.
1080 Currently, the code provides the cgcontext of the PlatformPluginWidget to
1081 the plugin. This approach does not work when we are printing, or using
1082 QWebFrame::render() to render to a QImage/QPixmap since the plugin ends
1083 up drawing on the QWebView (i.e platformPluginWidget's cgcontext) instead
1084 of the QPaintDevice's context.
1086 To solve all cases and keep the code simple, we render the plugin to an
1087 offscreen pixmap in all cases. This way, the plugin always renders to the
1088 CGContext of the pixmap and we then use QPainter to blit the pixmap into
1089 the QPaintDevice. We also create a fake window and set it's WindowRef in
1090 NPWindow. Only with this WindowRef does Flash paint correctly to the QPixmap.
1092 Now, that's the theory. In practice, ATM, mouse events do not work when using
1093 the fake window. So, setPlatformPluginWidget() is still called when using QWebView
1094 so that there are no regressions after this patch. Once we get mouse events
1095 working, setPlatformPluginWidget will be removed.
1097 https://bugs.webkit.org/show_bug.cgi?id=31183
1099 * plugins/PluginView.cpp:
1100 (WebCore::PluginView::PluginView):
1101 * plugins/PluginView.h:
1102 * plugins/mac/PluginViewMac.cpp:
1103 (WebCore::PluginView::platformStart):
1104 (WebCore::PluginView::platformDestroy):
1105 (WebCore::PluginView::setNPWindowIfNeeded):
1106 (WebCore::PluginView::updatePluginWidget):
1107 (WebCore::PluginView::paint):
1108 (WebCore::PluginView::invalidateRect):
1110 2009-11-19 Joseph Pecoraro <joepeck@webkit.org>
1112 Reviewed by Timothy Hatcher.
1114 Web Inspector: Resync Resources Backend and Frontend
1115 https://bugs.webkit.org/show_bug.cgi?id=31705
1117 * inspector/front-end/Resource.js: resync enum values with backend
1118 (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType): return false if all else fails, not true in all cases
1120 2009-11-19 Steve Block <steveblock@google.com>
1122 Reviewed by Darin Fisher.
1124 Android port lacks configuration in Platform.h and config.h.
1125 https://bugs.webkit.org/show_bug.cgi?id=31671
1127 Build change only. No new tests possible.
1129 * config.h: Modified. Added Android-specific configuration.
1131 2009-11-20 Roland Steiner <rolandsteiner@chromium.org>
1133 Reviewed by Darin Adler.
1135 Change default stylesheet to reset text indentation for ruby elements by default.
1136 (https://bugs.webkit.org/show_bug.cgi?id=31247)
1138 Test: fast/ruby/ruby-text-indent.html
1140 * css/html.css: reset text-indent on <ruby> and <rt> elements
1142 2009-11-19 Brian Weinstein <bweinstein@apple.com>
1144 Reviewed by Darin Adler.
1146 Fixes <http://webkit.org/b/22754>.
1147 Web Inspector: Keyboard shortcut for Element finder.
1149 Use Command + Shift + C as a shortcut for Node Search, to
1150 match the Firebug shortcut to do the same thing.
1152 * inspector/front-end/ElementsPanel.js:
1153 (WebInspector.ElementsPanel.prototype.handleKeyEvent):
1155 2009-11-19 Alexey Proskuryakov <ap@apple.com>
1157 Reviewed by Darin Adler.
1159 https://bugs.webkit.org/show_bug.cgi?id=31690
1160 Make SocketStreamHandleCFNet work on Windows
1162 * WebCore.vcproj/WebCore.vcproj: Added LoaderRunLoopCF.
1164 * platform/network/ResourceHandle.h: Removed loaderRunLoop().
1166 * platform/network/cf/LoaderRunLoopCF.cpp: Added.
1167 (WebCore::emptyPerform):
1168 (WebCore::runLoaderThread):
1169 (WebCore::loaderRunLoop):
1170 * platform/network/cf/LoaderRunLoopCF.h: Added.
1171 Moved the run loop that we use for CFNetwork from ResourceHandle to its own file, because
1172 it's needed for more than just resource loading.
1174 * platform/network/cf/ResourceHandleCFNet.cpp: Use loaderRunLoop() from its new location.
1176 * platform/network/cf/DNSCFNet.cpp: (WebCore::DNSResolveQueue::resolve): Ditto.
1178 * platform/network/cf/SocketStreamHandle.h: Added static callbacks for forwarding events to
1180 * platform/network/cf/SocketStreamHandleCFNet.cpp:
1181 (WebCore::SocketStreamHandle::SocketStreamHandle): Use loaderRunLoop() on Windows instead of
1182 inoperable main run loop.
1184 (WebCore::MainThreadEventCallbackInfo::MainThreadEventCallbackInfo):
1185 (WebCore::SocketStreamHandle::readStreamCallback):
1186 (WebCore::SocketStreamHandle::writeStreamCallback):
1187 (WebCore::SocketStreamHandle::readStreamCallbackMainThread):
1188 (WebCore::SocketStreamHandle::writeStreamCallbackMainThread):
1189 Forward stream events to main thread on Windows.
1191 2009-11-19 Avi Drissman <avi@chromium.org>
1193 Reviewed by Darin Adler.
1196 https://bugs.webkit.org/show_bug.cgi?id=27777
1198 * platform/graphics/cg/PDFDocumentImage.cpp:
1200 2009-11-19 Beth Dakin <bdakin@apple.com>
1202 Build fix. No review needed.
1204 * platform/chromium/ScrollbarThemeChromium.cpp:
1205 (WebCore::ScrollbarThemeChromium::paintTickmarks):
1206 * rendering/RenderMediaControlsChromium.cpp:
1207 (WebCore::paintMediaButton):
1209 2009-11-19 Beth Dakin <bdakin@apple.com>
1211 Build fix. No review needed.
1213 * rendering/RenderThemeChromiumSkia.cpp:
1214 (WebCore::RenderThemeChromiumSkia::paintCheckbox):
1215 (WebCore::RenderThemeChromiumSkia::paintRadio):
1216 (WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
1217 (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
1218 (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):
1220 2009-11-19 Beth Dakin <bdakin@apple.com>
1222 Build fix. No review needed.
1224 * platform/graphics/qt/StillImageQt.cpp:
1225 (WebCore::StillImage::draw):
1226 * platform/graphics/qt/StillImageQt.h:
1228 2009-11-19 Beth Dakin <bdakin@apple.com>
1230 Build fix. No review needed.
1232 * rendering/RenderThemeWin.cpp:
1233 (WebCore::RenderThemeWin::paintSearchFieldCancelButton):
1234 (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
1235 (WebCore::RenderThemeWin::paintSearchFieldResultsButton):
1237 2009-11-19 Beth Dakin <bdakin@apple.com>
1239 Build fix. No review needed.
1241 * plugins/PluginView.cpp:
1242 (WebCore::PluginView::paintMissingPluginIcon):
1244 2009-11-19 Beth Dakin <bdakin@apple.com>
1246 Build fix. No review needed.
1248 * platform/graphics/win/ImageCGWin.cpp:
1249 (WebCore::BitmapImage::getHBITMAPOfSize):
1250 (WebCore::BitmapImage::drawFrameMatchingSourceSize):
1252 2009-11-19 Beth Dakin <bdakin@apple.com>
1254 Reviewed by Darin Adler.
1256 Fix for https://bugs.webkit.org/show_bug.cgi?id=31321 Make -webkit-
1257 color-correction work with untagged images
1259 Image's draw(), drawPattern(), and fillWithSolidColor() functions
1260 now take a ColorSpace. A bunch of classes inherit from Image, so
1261 draw() and drawPattern() functions there must also take a
1263 * platform/graphics/Image.cpp:
1264 (WebCore::Image::fillWithSolidColor):
1265 (WebCore::Image::drawTiled):
1266 * platform/graphics/Image.h:
1267 * platform/graphics/BitmapImage.h:
1268 * platform/graphics/GeneratedImage.cpp:
1269 (WebCore::GeneratedImage::draw):
1270 (WebCore::GeneratedImage::drawPattern):
1271 * platform/graphics/GeneratedImage.h:
1272 * platform/graphics/cg/PDFDocumentImage.cpp:
1273 (WebCore::PDFDocumentImage::draw):
1274 * platform/graphics/cg/PDFDocumentImage.h:
1275 * svg/graphics/SVGImage.cpp:
1276 (WebCore::SVGImage::draw):
1277 * svg/graphics/SVGImage.h:
1279 All of the drawImage() functions and drawTiled() functions of
1280 GraphicsContext now take a ColorSpace.
1281 * platform/graphics/GraphicsContext.cpp:
1282 (WebCore::GraphicsContext::drawImage):
1283 (WebCore::GraphicsContext::drawTiledImage):
1284 * platform/graphics/GraphicsContext.h:
1286 This is where the actual work is done.
1287 * platform/graphics/cg/ImageCG.cpp:
1288 (WebCore::imageWithColorSpace): New static function that returns a
1289 copy of the given image in the given ColorSpace *IF* we should use
1290 the given ColorSpace. We will ignore the color space if the image
1291 is tagged and return 0.
1292 (WebCore::BitmapImage::draw): Now takes a ColorSpace and uses it to
1293 call imageWithColorSpace().
1294 (WebCore::Image::drawPattern): Same.
1296 Attempt to keep all ports building.
1297 * platform/graphics/cairo/ImageCairo.cpp:
1298 (WebCore::BitmapImage::draw):
1299 (WebCore::Image::drawPattern):
1300 * platform/graphics/haiku/ImageHaiku.cpp:
1301 (WebCore::BitmapImage::draw):
1302 (WebCore::Image::drawPattern):
1303 * platform/graphics/qt/ImageQt.cpp:
1304 (WebCore::Image::drawPattern):
1305 (WebCore::BitmapImage::draw):
1306 * platform/graphics/skia/BitmapImageSingleFrameSkia.h:
1307 * platform/graphics/skia/ImageSkia.cpp:
1308 (WebCore::Image::drawPattern):
1309 (WebCore::BitmapImage::draw):
1310 (WebCore::BitmapImageSingleFrameSkia::draw):
1311 * platform/graphics/wx/ImageWx.cpp:
1312 (WebCore::BitmapImage::draw):
1313 (WebCore::BitmapImage::drawPattern):
1315 Callers of GraphicsContext's drawImage() and drawTiled() functions
1316 now need to send a ColorSpace.
1317 * html/HTMLCanvasElement.cpp:
1318 (WebCore::HTMLCanvasElement::paint):
1319 * html/canvas/CanvasRenderingContext2D.cpp:
1320 (WebCore::CanvasRenderingContext2D::drawImage):
1321 (WebCore::CanvasRenderingContext2D::drawImageFromRect):
1322 * platform/ScrollView.cpp:
1323 (WebCore::ScrollView::wheelEvent):
1324 * platform/graphics/filters/FEColorMatrix.cpp:
1325 (WebCore::FEColorMatrix::apply):
1326 * platform/graphics/filters/FEComposite.cpp:
1327 (WebCore::FEComposite::apply):
1328 * platform/graphics/filters/SourceGraphic.cpp:
1329 (WebCore::SourceGraphic::apply):
1330 * platform/mac/ScrollbarThemeMac.mm:
1331 (WebCore::ScrollbarThemeMac::paint):
1332 * rendering/RenderBoxModelObject.cpp:
1333 (WebCore::RenderBoxModelObject::paintFillLayerExtended):
1334 (WebCore::RenderBoxModelObject::paintNinePieceImage):
1335 * rendering/RenderImage.cpp:
1336 (WebCore::RenderImage::paintReplaced):
1337 * rendering/RenderLayer.cpp:
1338 (WebCore::RenderLayer::paintResizer):
1339 * rendering/RenderListMarker.cpp:
1340 (WebCore::RenderListMarker::paint):
1341 * rendering/RenderSVGImage.cpp:
1342 (WebCore::RenderSVGImage::paint):
1343 * rendering/RenderWidget.cpp:
1344 (WebCore::RenderWidget::paint):
1345 * svg/graphics/SVGPaintServerPattern.cpp:
1346 (WebCore::SVGPaintServerPattern::setup):
1347 * svg/graphics/SVGResourceFilter.cpp:
1348 (WebCore::SVGResourceFilter::applyFilter):
1349 * svg/graphics/filters/SVGFEMerge.cpp:
1350 (WebCore::FEMerge::apply):
1351 * svg/graphics/filters/SVGFEOffset.cpp:
1352 (WebCore::FEOffset::apply):
1353 * svg/graphics/filters/SVGFETile.cpp:
1354 (WebCore::FETile::apply):
1356 2009-11-19 Avi Drissman <avi@chromium.org>
1358 Reviewed by Darin Adler.
1360 Properly create a CGImageRef on non-PLATFORM(MAC).
1361 https://bugs.webkit.org/show_bug.cgi?id=27777
1363 * platform/graphics/cg/ImageSourceCG.cpp:
1364 (WebCore::sharedBufferGetBytesAtPosition):
1365 (WebCore::sharedBufferRelease):
1366 (WebCore::ImageSource::setData):
1367 * platform/graphics/cg/ImageSourceCG.h:
1368 * platform/graphics/cg/PDFDocumentImage.cpp:
1369 (WebCore::PDFDocumentImage::dataChanged):
1371 2009-11-19 Oliver Hunt <oliver@apple.com>
1373 Reviewed by Dave Hyatt.
1375 -webkit-user-drag: element Drag images include overflow decorations from incorrect nodes
1376 https://bugs.webkit.org/show_bug.cgi?id=31656
1378 Make sure we're a child of the painting root before drawing overflow features.
1380 * manual-tests/user-drag-with-decorations.html: Added.
1381 * rendering/RenderBlock.cpp:
1382 (WebCore::RenderBlock::paint):
1384 2009-11-19 Dmitry Titov <dimich@chromium.org>
1386 Not reviewed, attempt to fix Chromium build.
1388 * rendering/RenderMediaControlsChromium.cpp:
1389 (WebCore::RenderMediaControlsChromium::paintMediaControlsPart): Add new enum values for Show/HideClosedCaptionButton to make it compile.
1391 2009-11-19 Rahul Kuchhal <kuchhal@chromium.org>
1393 Reviewed by Darin Adler.
1395 Do not assert when a high number is used for roman numerals in lists.
1396 https://bugs.webkit.org/show_bug.cgi?id=31652
1398 Test: fast/lists/ol-start-roman.html
1400 * rendering/RenderListMarker.cpp:
1401 (WebCore::toRoman): Increase the char array size.
1403 2009-11-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
1405 Rubber-stamped by Oliver Hunt.
1407 Add translatable strings to cover validationMessage, after
1408 r51172. Already covered by existing test.
1410 * platform/gtk/LocalizedStringsGtk.cpp:
1411 (WebCore::validationMessageValueMissingText):
1412 (WebCore::validationMessageTypeMismatchText):
1413 (WebCore::validationMessagePatternMismatchText):
1414 (WebCore::validationMessageTooLongText):
1415 (WebCore::validationMessageRangeUnderflowText):
1416 (WebCore::validationMessageRangeOverflowText):
1417 (WebCore::validationMessageStepMismatchText):
1419 2009-11-19 Laszlo Gombos <laszlo.1.gombos@nokia.com>
1421 Reviewed by Darin Adler.
1423 Remove HAVE(FLOAT_H) guard
1424 https://bugs.webkit.org/show_bug.cgi?id=31661
1426 WebCore has a dependency on float.h, there is
1427 no need to guard float.h.
1429 No new tests as there is no functional change.
1431 * html/HTMLInputElement.cpp: Remove include directive
1432 for float.h as it is included in MathExtras.h already.
1434 2009-11-19 Simon Fraser <simon.fraser@apple.com>
1436 Reviewed by Pavel Feldman.
1438 Instrumentation should account for painting in compositing layers
1439 https://bugs.webkit.org/show_bug.cgi?id=31674
1441 Add calls to InspectorTimelineAgent for painting into compositing layers,
1442 which is not accounted for in FrameView::paintContents().
1444 * rendering/RenderLayerBacking.cpp:
1445 (WebCore::RenderLayerBacking::paintIntoLayer):
1446 Avoid fetching the FrameView multiple times.
1448 (WebCore::inspectorTimelineAgent):
1449 (WebCore::RenderLayerBacking::paintContents):
1451 2009-11-19 Eric Carlson <eric.carlson@apple.com>
1453 Reviewed by Dan Bernstein.
1455 <rdar://problem/7035231>
1456 Support closed caption in <video> element
1458 Test: media/media-captions.html
1461 * accessibility/AccessibilityMediaControls.cpp:
1462 (WebCore::AccessibilityMediaControl::controlTypeName):
1463 Define ShowClosedCaptionsButton and HideClosedCaptionsButton.
1465 * css/CSSPrimitiveValueMappings.h:
1466 (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
1467 Add MediaToggleClosedCaptionsButtonPart.
1469 * css/CSSSelector.cpp:
1470 (WebCore::CSSSelector::extractPseudoType):
1471 Define and match mediaControlsToggleClosedCaptionsButton.
1473 * css/CSSSelector.h:
1474 (WebCore::CSSSelector::):
1475 * css/CSSStyleSelector.cpp:
1476 (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
1477 Define and match PseudoMediaControlsToggleClosedCaptions.
1479 * css/CSSValueKeywords.in:
1480 Define and use media-toggle-closed-captions-button.
1482 * css/mediaControls.css:
1483 * css/mediaControlsQuickTime.css:
1484 Add webkit-media-controls-toggle-closed-captions-button.
1486 * html/HTMLMediaElement.cpp:
1487 (WebCore::HTMLMediaElement::HTMLMediaElement):
1488 Initialize m_closedCaptionsVisible.
1489 (WebCore::HTMLMediaElement::loadInternal):
1490 Set m_closedCaptionsVisible to false.
1491 (WebCore::HTMLMediaElement::hasClosedCaptions):
1492 (WebCore::HTMLMediaElement::closedCaptionsVisible):
1493 (WebCore::HTMLMediaElement::setClosedCaptionsVisible):
1494 New, captions internal methods.
1495 (WebCore::HTMLMediaElement::setWebkitClosedCaptionsVisible):
1496 (WebCore::HTMLMediaElement::webkitClosedCaptionsVisible):
1497 (WebCore::HTMLMediaElement::webkitHasClosedCaptions):
1498 New, captions DOM API.
1500 * html/HTMLMediaElement.h:
1501 * html/HTMLMediaElement.idl:
1502 Declare methods needed for captions API.
1504 * platform/ThemeTypes.h:
1505 Add MediaToggleClosedCaptionsButtonPart.
1507 * platform/android/LocalizedStringsAndroid.cpp:
1508 (WebCore::localizedMediaControlElementString):
1509 (WebCore::localizedMediaControlElementHelpText):
1510 (WebCore::localizedMediaTimeDescription):
1511 Add empty implmentations.
1513 * platform/graphics/MediaPlayer.cpp:
1514 (WebCore::NullMediaPlayerPrivate::hasClosedCaptions):
1515 (WebCore::NullMediaPlayerPrivate::setClosedCaptionsVisible):
1516 New, empty implementations of media engine closed caption functions.
1517 (WebCore::MediaPlayer::hasClosedCaptions):
1518 (WebCore::MediaPlayer::setClosedCaptionsVisible):
1519 New, call media engine closed caption functions.
1521 * platform/graphics/MediaPlayer.h:
1522 * platform/graphics/MediaPlayerPrivate.h:
1523 (WebCore::MediaPlayerPrivateInterface::hasClosedCaptions):
1524 (WebCore::MediaPlayerPrivateInterface::setClosedCaptionsVisible):
1525 Declare new media engine methods.
1527 * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
1528 * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
1529 (WebCore::MediaPlayerPrivate::hasClosedCaptions):
1530 (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible):
1531 New, QTKit implementation of closed caption methods.
1533 * platform/gtk/LocalizedStringsGtk.cpp:
1534 (WebCore::localizedMediaControlElementString):
1535 (WebCore::localizedMediaControlElementHelpText):
1536 Add help text for ShowClosedCaptionsButton and HideClosedCaptionsButton.
1538 * platform/mac/WebCoreSystemInterface.h:
1539 * platform/mac/WebCoreSystemInterface.mm:
1540 Declare and initialize wkQTMovieHasClosedCaptions and wkQTMovieSetShowClosedCaptions.
1542 * rendering/MediaControlElements.cpp:
1543 (WebCore::MediaControlInputElement::MediaControlInputElement):
1544 Deal with MEDIA_CONTROLS_TOGGLE_CLOSED_CAPTIONS_BUTTON.
1545 (WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
1546 (WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
1547 (WebCore::MediaControlToggleClosedCaptionsButtonElement::updateDisplayType):
1548 New, implement the closed caption toggle button,
1550 * rendering/MediaControlElements.h:
1551 Define MediaShowClosedCaptionsButton and MediaHideClosedCaptionsButton,
1552 declare MediaControlToggleClosedCaptionsButtonElement.
1554 * rendering/RenderMedia.cpp:
1555 (WebCore::RenderMedia::styleDidChange):
1556 (WebCore::RenderMedia::createToggleClosedCaptionsButton):
1557 (WebCore::RenderMedia::createStatusDisplay):
1558 (WebCore::RenderMedia::updateControls):
1559 (WebCore::RenderMedia::forwardEvent):
1560 * rendering/RenderMedia.h:
1561 Deal with m_toggleClosedCaptionsButton.
1563 * rendering/RenderTheme.cpp:
1564 (WebCore::RenderTheme::paint):
1565 Deal with MediaToggleClosedCaptionsButtonPart.
1567 * rendering/RenderTheme.h:
1568 * rendering/RenderThemeMac.h:
1569 Declare paintMediaToggleClosedCaptionsButton.
1571 * rendering/RenderThemeMac.mm:
1572 (WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton):
1574 (WebCore::RenderThemeMac::shouldRenderMediaControlPart):
1575 Don't render captions toggle button unless we are using the new theme, the
1576 movie has captions, and the movie is in a <video> element since we currently
1577 rely on QTKit to render the captions.
1579 * rendering/style/RenderStyleConstants.h:
1580 Define MEDIA_CONTROLS_TOGGLE_CLOSED_CAPTIONS_BUTTON.
1582 2009-11-19 Kevin Ollivier <kevino@theolliviers.com>
1584 wx build fix. Add missing header.
1586 * platform/wx/LocalizedStringsWx.cpp:
1588 2009-11-19 Alexey Proskuryakov <ap@apple.com>
1590 Reviewed by Darin Adler.
1592 https://bugs.webkit.org/show_bug.cgi?id=31634
1593 Ignore realm for proxy protection spaces
1595 Only affects WebSocket proxy authentication, cannot be tested in DRT.
1597 * platform/network/ProtectionSpace.cpp:
1598 (WebCore::operator==):
1599 * platform/network/ProtectionSpaceHash.h:
1600 (WebCore::ProtectionSpaceHash::hash):
1602 2009-11-19 Olivier Goffart <ogoffart@trolltech.com>
1604 Reviewed by Simon Hausmann.
1606 [Qt] Normalize signal and slot signatures.
1608 * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
1609 (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
1611 2009-11-19 Alexander Pavlov <apavlov@chromium.org>
1613 Reviewed by Pavel Feldman.
1615 Store cookie domains in the WebInspector object
1617 The cookie domains have been moved from StoragePanel into WebInspector.
1618 Also, the document URLs are now passed inside the WebInspector.addResource()
1619 payload rather than pushed directly from InspectorController.
1620 https://bugs.webkit.org/show_bug.cgi?id=31627
1622 * inspector/InspectorController.cpp:
1623 (WebCore::InspectorController::populateScriptObjects):
1624 (WebCore::InspectorController::didFinishLoading):
1625 * inspector/InspectorFrontend.cpp:
1626 * inspector/InspectorFrontend.h:
1627 * inspector/InspectorResource.cpp:
1628 (WebCore::InspectorResource::createScriptObject):
1629 (WebCore::InspectorResource::updateScriptObject):
1630 * inspector/front-end/StoragePanel.js:
1631 (WebInspector.StoragePanel.prototype.reset):
1632 (WebInspector.StoragePanel.prototype.addCookieDomain):
1633 * inspector/front-end/inspector.js:
1634 (WebInspector.addResource):
1635 (WebInspector.addCookieDomain):
1636 (WebInspector.reset):
1638 2009-11-19 Zoltan Horvath <zoltan@webkit.org>
1640 Reviewed by Darin Adler.
1642 Allow custom memory allocation control for the other part of platform directory in WebCore
1643 https://bugs.webkit.org/show_bug.cgi?id=31585
1645 Inherits the following classes from FastAllocBase because these are
1646 instantiated by 'new':
1648 class RegularExpression - instantiated at: WebCore/page/Frame.cpp:415
1649 class TransformationMatrix - instantiated at: WebCore/rendering/TransformState.cpp:62
1650 class Path - instantiated at: WebCore/html/HTMLAreaElement.cpp:73
1651 class FontPlatformData - instantiated at: WebCore/platform/graphics/qt/FontCacheQt.cpp:188
1653 Inherits the following classes from Noncopyable because these are
1654 instantiated by 'new' and no need to be copyable:
1656 class Cursors - instantiated at: WebCore/platform/qt/CursorQt.cpp:146
1657 class NetworkStateNotifier - instantiated at: WebCore/platform/network/NetworkStateNotifier.cpp:37
1658 struct CrossThreadResourceRequestData - instantiated at: WebCore/platform/network/ResourceRequestBase.cpp:71
1660 class ImageDecoder - its child class is instantiated at: WebCore/platform/graphics/qt/ImageDecoderQt.cpp:46
1661 class MediaPlayerPrivateInterface - its child class is instantiated at: WebCore/platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:119
1663 * platform/graphics/MediaPlayerPrivate.h:
1664 * platform/graphics/Path.h:
1665 * platform/graphics/qt/FontPlatformData.h:
1666 * platform/graphics/transforms/TransformationMatrix.h:
1667 * platform/image-decoders/ImageDecoder.h:
1668 * platform/network/NetworkStateNotifier.h:
1669 * platform/network/ResourceRequestBase.h:
1670 * platform/qt/CursorQt.cpp:
1671 * platform/text/RegularExpression.h:
1673 2009-11-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>
1677 [Qt] Build fix for QtWebKit after r51172.
1679 * platform/qt/Localizations.cpp:
1680 (WebCore::validationMessageValueMissingText):
1681 (WebCore::validationMessageTypeMismatchText):
1682 (WebCore::validationMessagePatternMismatchText):
1683 (WebCore::validationMessageTooLongText):
1684 (WebCore::validationMessageRangeUnderflowText):
1685 (WebCore::validationMessageRangeOverflowText):
1686 (WebCore::validationMessageStepMismatchText):
1688 2009-11-18 Dan Bernstein <mitz@apple.com>
1690 Reviewed by Simon Fraser.
1692 Fixed <rdar://problem/7398987> Assertion failure in
1693 RenderLayer::updateClipRects when a plug-in’s enclosing layer is
1694 enclosed by a transformed layer
1696 Tests: fast/layers/clip-rects-transformed-2.html
1697 fast/layers/clip-rects-transformed.html
1699 * rendering/RenderLayer.cpp:
1700 (WebCore::RenderLayer::clippingRoot): Added. Finds the nearest ancestor
1701 that is either transformed or composited. During painting and hit
1702 testing, when a transformed or composited layer is hit, it becomes the
1703 new root layer, which ultimately gets passed to calculateRects().
1704 (WebCore::RenderLayer::childrenClipRect): Pass the clipping root as the
1705 root layer to calculateRects(), and return the bounding box of the
1706 transformed rectangle.
1707 (WebCore::RenderLayer::selfClipRect): Ditto.
1708 * rendering/RenderLayer.h:
1710 2009-11-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>
1712 Reviewed by Kenneth Rohde Christiansen.
1714 [Qt] Remove support for Qt v4.3 or older versions
1715 https://bugs.webkit.org/show_bug.cgi?id=29469
1717 No new tests as there is no change if compiled with
1718 Qt v4.4 or later version.
1721 * dom/XMLTokenizerQt.cpp:
1722 (WebCore::EntityResolver::resolveUndeclaredEntity):
1723 (WebCore::XMLTokenizer::XMLTokenizer):
1724 (WebCore::XMLTokenizer::~XMLTokenizer):
1725 (WebCore::XMLTokenizer::doWrite):
1726 (WebCore::XMLTokenizer::startDocument):
1727 (WebCore::XMLTokenizer::parseDtd):
1728 * platform/graphics/qt/FontQt.cpp:
1729 * platform/graphics/qt/FontQt43.cpp: Removed.
1730 * platform/graphics/qt/ImageQt.cpp:
1731 * platform/network/ResourceHandleInternal.h:
1732 * platform/network/qt/QNetworkReplyHandler.cpp:
1733 * platform/network/qt/QNetworkReplyHandler.h:
1734 * platform/network/qt/ResourceHandleQt.cpp:
1735 (WebCore::ResourceHandle::start):
1736 (WebCore::ResourceHandle::cancel):
1737 (WebCore::ResourceHandle::loadResourceSynchronously):
1738 (WebCore::ResourceHandle::setDefersLoading):
1739 * platform/network/qt/ResourceRequest.h:
1740 * platform/network/qt/ResourceRequestQt.cpp:
1741 * platform/qt/ClipboardQt.cpp:
1742 (WebCore::ClipboardQt::clearData):
1743 * platform/qt/CookieJarQt.cpp:
1744 (WebCore::cookieJar):
1745 (WebCore::setCookies):
1747 (WebCore::cookiesEnabled):
1748 * platform/qt/PlatformKeyboardEventQt.cpp:
1749 (WebCore::keyIdentifierForQtKeyCode):
1750 (WebCore::windowsKeyCodeForKeyEvent):
1751 * platform/text/qt/TextBoundaries.cpp:
1752 * platform/text/qt/TextBreakIteratorQt.cpp:
1753 * plugins/qt/PluginDataQt.cpp:
1754 (WebCore::PluginData::initPlugins):
1756 2009-11-18 Michelangelo De Simone <micdesim@gmail.com>
1758 Reviewed by Darin Adler.
1760 Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
1761 Support for validationMessage attribute, as per HTML5 specs.
1763 Test: fast/forms/validationMessage.html
1765 * html/HTMLButtonElement.idl: validationMessage attribute
1766 * html/HTMLFieldSetElement.idl: validationMessage attribute
1767 * html/HTMLFormControlElement.cpp:
1768 * html/HTMLFormControlElement.h:
1769 * html/HTMLInputElement.idl: validationMessage attribute
1770 * html/HTMLSelectElement.idl: validationMessage attribute
1771 * html/HTMLTextAreaElement.idl: validationMessage attribute
1772 * html/ValidityState.cpp: new method to retrieve pertinent localized text
1773 * html/ValidityState.h:
1774 * page/mac/WebCoreViewFactory.h:
1775 * platform/LocalizedStrings.h:
1776 * platform/android/LocalizedStringsAndroid.cpp:
1777 * platform/gtk/LocalizedStringsGtk.cpp:
1778 * platform/haiku/LocalizedStringsHaiku.cpp:
1779 * platform/mac/LocalizedStringsMac.mm:
1780 * platform/wx/LocalizedStringsWx.cpp:
1782 2009-11-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>
1786 Fix a typo. Remove the trailing semicolon
1787 from an include directive after r51137.
1789 No new tests as there is no functional change.
1791 * platform/qt/QWebPageClient.h:
1793 2009-11-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>
1797 [Qt] Build fix for QtWebKit after r51159.
1799 Include float.h for DBL_MANT_DIG. Not sure why this
1800 is not a problem for other ports.
1802 * html/HTMLInputElement.cpp:
1804 2009-11-19 Roland Steiner <rolandsteiner@chromium.org>
1806 Reviewed by Darin Adler.
1808 Bug 31574 - Crashing bug when removing <ruby> element
1809 (https://bugs.webkit.org/show_bug.cgi?id=31574)
1812 1.) RenderBlock::destroy() of the RenderRubyRun called destroyLeftoverChildren()
1813 2.) that called destroy() of the RenderRubyBase(), which in RenderObject::destroy() calls remove()
1814 3.) remove() is being redirected as parent()->removeChild() in RenderObject.h
1815 4.) this triggers the special handling of child removal in RenderRubyRun that
1816 causes it to destroy itself
1817 5.) On returning from all this the renderer crashes when accessing a member
1818 or virtual function on this now illegal object.
1820 I therefore added a flag that tracks if the ruby run is being destroyed.
1821 If so, avoid doing the special handling in removeChild that caused this.
1822 It's not the most elegant solution, but the easiest to implement without
1823 touching unrelated code. Also, it's self-documenting.
1825 Test: fast/ruby/ruby-remove.html
1827 * rendering/RenderRubyRun.cpp:
1828 (WebCore::RenderRubyRun::RenderRubyRun):
1829 (WebCore::RenderRubyRun::destroy):
1830 (WebCore::RenderRubyRun::removeChild):
1831 * rendering/RenderRubyRun.h:
1833 2009-11-18 Laszlo Gombos <laszlo.1.gombos@nokia.com>
1835 Reviewed by Kenneth Rohde Christiansen.
1837 [Qt] Remove WTF_USE_JAVASCRIPTCORE_BINDINGS as it is no longer used
1838 https://bugs.webkit.org/show_bug.cgi?id=31643
1840 No new tests as there is no functional change.
1844 2009-11-18 Yong Li <yong.li@torchmobile.com>
1846 Reviewed by Eric Seidel.
1848 Implement TextBoundaries for WINCE port.
1849 https://bugs.webkit.org/show_bug.cgi?id=27371
1851 * platform/text/wince/TextBoundariesWince.cpp: Added.
1853 2009-11-18 Yong Li <yong.li@torchmobile.com>
1855 Reviewed by Eric Seidel.
1857 Implement TextBreakIterator for WINCE port.
1858 https://bugs.webkit.org/show_bug.cgi?id=27371
1860 * platform/text/wince/TextBreakIteratorWince.cpp: Added.
1862 2009-11-18 Kent Tamura <tkent@chromium.org>
1864 Reviewed by Darin Adler.
1866 Add support for ValidityState.typeMismatch for the following INPUT types:
1867 date datetime datetime-local month time week
1868 https://bugs.webkit.org/show_bug.cgi?id=31342
1870 Tests: fast/forms/ValidityState-typeMismatch-date.html
1871 fast/forms/ValidityState-typeMismatch-datetime.html
1872 fast/forms/ValidityState-typeMismatch-datetimelocal.html
1873 fast/forms/ValidityState-typeMismatch-month.html
1874 fast/forms/ValidityState-typeMismatch-time.html
1875 fast/forms/ValidityState-typeMismatch-week.html
1877 * html/HTMLInputElement.cpp:
1878 (WebCore::HTMLInputElement::formStringToISODateTime): Check the type
1879 validity of the specified type and string using the ISODateTime class.
1880 * html/HTMLInputElement.h:
1881 * html/ValidityState.cpp:
1882 (WebCore::ValidityState::typeMismatch): Check the type validity
1883 for date, datetime, datetime-local, month, time and week with
1884 HTMLInputElemtn::formStringToISODateTime()
1886 2009-11-18 Maciej Stachowiak <mjs@apple.com>
1888 Reviewed by Oliver Hunt.
1890 Fix REGRESSION (r47022): Performance of DocumentFragment.appendChild is 1000x slower sometimes
1891 https://bugs.webkit.org/show_bug.cgi?id=31237
1893 Also speeds up Dromaeo DOM Core tests by 1.31x.
1895 * bindings/js/JSNodeCustom.cpp:
1896 (WebCore::JSNode::markChildren): Change marking algorithm to avoid O(N^2) behavior. The subtree
1897 mark bit was no longer effective; instead I changed things so only a node that has no ancestors
1898 with wrappers would do marking; there should be only one in the typical case (the root of the
1901 (WebCore::Node::Node): Remove now useless m_inSubtreeMark bit and related functions.
1904 2009-11-18 Darin Adler <darin@apple.com>
1906 Reviewed by Sam Weinig.
1908 Get rid of the redundant strokeType and fillType data members on
1909 a GraphicsContext as well as the FillOrStrokeType enum. Use
1910 null pointers instead.
1912 * platform/graphics/GraphicsContext.cpp:
1913 (WebCore::GraphicsContext::setStrokeColor): Null out the pattern
1915 (WebCore::GraphicsContext::setFillColor): Ditto.
1916 (WebCore::GraphicsContext::setStrokePattern): Null out the graident.
1917 (WebCore::GraphicsContext::setFillPattern): Ditto.
1918 (WebCore::GraphicsContext::setStrokeGradient): Null out the pattern.
1919 (WebCore::GraphicsContext::setFillGradient): Ditto.
1921 * platform/graphics/GraphicsContextPrivate.h: Remove all that stuff.
1923 * platform/graphics/cairo/GraphicsContextCairo.cpp:
1924 (WebCore::setPlatformFill): Use null checks on fillPattern and
1925 fillGraident instead of a switch statement.
1926 (WebCore::setPlatformStroke): Ditto.
1928 * platform/graphics/cg/GraphicsContextCG.cpp:
1929 (WebCore::GraphicsContext::applyStrokePattern): Removed unneeded get.
1930 (WebCore::GraphicsContext::applyFillPattern): Ditto.
1931 (WebCore::calculateDrawingMode): Use fillPattern and strokePattern
1932 to see if there is a pattern instead of fillType and strokeType.
1933 (WebCore::GraphicsContext::drawPath): Use fillGradient, strokeGradient,
1934 fillPattern, and strokePattern instead of fillType and strokeType.
1935 (WebCore::GraphicsContext::fillPath): Added FIXME about color space that
1936 is used in the pattern and gradient case probably erroneously. Moved
1937 gradient code inside an if statement. Streamlined pattern code and
1938 use an if statement. No switch any more.
1939 (WebCore::GraphicsContext::strokePath): Ditto.
1940 (WebCore::GraphicsContext::fillRect): Ditto.
1941 (WebCore::GraphicsContext::strokeRect): Ditto.
1943 * platform/graphics/qt/GraphicsContextQt.cpp:
1944 (WebCore::GraphicsContext::fillPath): Use null checks on fillPattern and
1945 fillGraident instead of a switch statement.
1946 (WebCore::GraphicsContext::strokePath): Ditto.
1947 (WebCore::GraphicsContext::fillRect): Ditto.
1949 * platform/graphics/wince/GraphicsContextWince.cpp:
1950 (WebCore::GraphicsContext::fillPath): Removed unneeded check of fillType.
1951 (WebCore::GraphicsContext::fillRect): Ditto.
1953 2009-11-18 Kent Tamura <tkent@chromium.org>
1955 Reviewed by Darin Adler.
1957 Support for step attribute and ValidityStae.stepMismatch for
1958 type=number and range. stepMismatch will be false if the
1959 difference between the current value and a multiple of the step
1960 value is very small.
1962 Change the behavior of RenderSlider so that it always has a value
1963 rounded to the step attribute value.
1965 https://bugs.webkit.org/show_bug.cgi?id=31331
1967 Tests: fast/forms/ValidityState-stepMismatch-number.html
1968 fast/forms/ValidityState-stepMismatch-range.html
1969 fast/forms/ValidityState-stepMismatch-unsupported.html
1970 fast/forms/input-step.html
1972 * html/HTMLAttributeNames.in: Add "step".
1973 * html/HTMLInputElement.cpp:
1974 (WebCore::HTMLInputElement::stepMismatch):
1975 (WebCore::HTMLInputElement::getStepParameters):
1976 (WebCore::HTMLInputElement::getAllowedValueStep):
1977 * html/HTMLInputElement.h:
1978 * html/HTMLInputElement.idl: Add "step".
1979 * html/ValidityState.cpp:
1980 (WebCore::ValidityState::stepMismatch): Forward to HTMLInputElement::stepMismatch().
1981 * html/ValidityState.h:
1982 * rendering/RenderSlider.cpp:
1983 (WebCore::SliderRange::SliderRange):
1984 (WebCore::SliderRange::clampValue):
1986 2009-11-18 Dmitry Titov <dimich@chromium.org>
1988 Reviewed by Darin Adler.
1990 Need to ASSERT(isMainThread()) in ThreadShared methods.
1991 https://bugs.webkit.org/show_bug.cgi?id=31637
1993 Added ASSERT(IsMainThread()) to all following methods:
1994 * platform/TreeShared.h:
1995 (WebCore::TreeShared::TreeShared):
1996 (WebCore::TreeShared::~TreeShared):
1997 (WebCore::TreeShared::ref):
1998 (WebCore::TreeShared::deref):
1999 (WebCore::TreeShared::setParent):
2000 (WebCore::TreeShared::parent):
2002 2009-11-18 Girish Ramakrishnan <girish@forwardbias.in>
2004 Reviewed by Eric Seidel.
2006 Add plugin visibility manual test
2008 https://bugs.webkit.org/show_bug.cgi?id=31542
2010 * manual-tests/plugins/windowed.html:
2011 * manual-tests/plugins/windowless.html:
2013 2009-11-18 Patrick Mueller <Patrick_Mueller@us.ibm.com>
2015 Reviewed by Pavel Feldman.
2017 Web Inspector - remember last script displayed in Scripts panel
2018 https://bugs.webkit.org/show_bug.cgi?id=27552
2022 * inspector/front-end/ScriptsPanel.js:
2023 (WebInspector.ScriptsPanel.prototype.showScript):
2024 (WebInspector.ScriptsPanel.prototype.showResource):
2025 (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
2026 (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
2027 (WebInspector.ScriptsPanel.prototype._callFrameSelected):
2028 (WebInspector.ScriptsPanel.prototype._goBack):
2029 (WebInspector.ScriptsPanel.prototype._goForward):
2030 * manual-tests/inspector/remember-last-script.html: Added.
2032 2009-11-18 Shinichiro Hamaji <hamaji@chromium.org>
2034 Reviewed by Dimitri Glazkov.
2036 Win chromium is slow to draw transparent texts
2037 https://bugs.webkit.org/show_bug.cgi?id=31258
2039 Create bounded transparency layers instead of just clipping.
2041 No new tests because this is just a performance improvement.
2043 * platform/graphics/chromium/FontChromiumWin.cpp:
2044 (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
2046 2009-11-18 Shu Chang <Chang.Shu@nokia.com>
2048 Reviewed by Eric Seidel.
2050 [Qt] Add support for displaying deleteButton.
2051 https://bugs.webkit.org/show_bug.cgi?id=31560
2053 Test: LayoutTests/editing/deleting/5408255.html
2056 * platform/graphics/qt/ImageQt.cpp:
2057 (loadResourcePixmap):
2059 2009-11-18 Mikhail Naganov <mnaganov@chromium.org>
2061 Reviewed by Eric Seidel.
2063 Fix Qt build without JavaScript debugger.
2065 https://bugs.webkit.org/show_bug.cgi?id=31575
2069 2009-11-18 Daniel Bates <dbates@webkit.org>
2071 Reviewed by Dave Hyatt.
2073 https://bugs.webkit.org/show_bug.cgi?id=24971
2075 <rdar://problem/7138265>
2077 Fixes an issue where setting the height of a table row programmatically
2078 (via JavaScript) causes the table to be improperly rendered because the
2079 height of each row in the table is not recalculated with respect to the
2080 CSS height property.
2082 In particular, programmatically setting the height of some table row causes
2083 the rows of that table to be rendered with a height equal to the minimum
2084 height required by the cells in that row, regardless of any specified cell
2085 heights. Instead, when RenderTableSection::recalcCells is called, the height
2086 of each row should be set to the CSS height property just as we do in
2087 RenderTableSection::addChild.
2089 Test: fast/table/row-height-recalc2.html
2091 * rendering/RenderTableSection.cpp:
2092 (WebCore::setRowHeightToRowStyleHeightIfNotRelative): Added.
2093 (WebCore::RenderTableSection::addChild): Moved code that set row height into
2094 method WebCore::setRowHeightToRowStyleHeightIfNotRelative.
2095 (WebCore::RenderTableSection::recalcCells): Modified to call
2096 WebCore::setRowHeightToRowStyleHeightIfNotRelative.
2098 2009-11-18 Zoltan Horvath <zoltan@webkit.org>
2100 Reviewed by Darin Adler.
2102 Allow custom memory allocation control for the part of platform directory in WebCore
2103 https://bugs.webkit.org/show_bug.cgi?id=31473
2105 Inherits the following classes from FastAllocBase because these are
2106 instantiated by 'new':
2108 class AnimationList - instantiated at WebCore/rendering/style/StyleRareNonInheritedData.cpp:85
2109 class Color - instantiated at WebCore/rendering/RenderTheme.cpp:48
2110 struct Length - instantiated at WebCore/platform/Length.cpp:103
2111 class PlatformKeyboardEvent - instantiated at WebCore/dom/KeyboardEvent.cpp:63
2112 class ContextMenuItem - instantiated at WebCore/platform/ContextMenu.cpp:70
2113 class DeprecatedPtrList - instantiated at WebCore/rendering/RenderBlock.cpp:2284
2115 Inherits the following classes from Noncopyable because these are
2116 instantiated by 'new' and no need to be copyable:
2118 class GraphicsContextPrivate - instantiated at WebCore/platform/graphics/GraphicsContext.cpp:78
2119 class FontCache - instantiated at WebCore/platform/graphics/qt/FontCacheQt.cpp:43
2120 struct MediaPlayerFactory - instantiated at WebCore/platform/graphics/MediaPlayer.cpp:163
2121 class DeprecatedPtrListNode - instantiated at WebCore/platform/DeprecatedPtrListImpl.cpp:53
2123 * platform/ContextMenuItem.h:
2124 * platform/DeprecatedPtrList.h:
2125 * platform/DeprecatedPtrListImpl.cpp:
2126 * platform/Length.h:
2127 * platform/PlatformKeyboardEvent.h:
2128 * platform/animation/AnimationList.h:
2129 * platform/graphics/Color.h:
2130 * platform/graphics/FontCache.h:
2131 * platform/graphics/GraphicsContextPrivate.h:
2132 * platform/graphics/MediaPlayer.cpp:
2134 2009-11-18 Daniel Bates <dbates@webkit.org>
2136 Reviewed by Darin Adler.
2138 https://bugs.webkit.org/show_bug.cgi?id=31186
2140 Renames RenderTextControl::m_edited and RenderTextControl::m_userEdited to
2141 m_wasChangedSinceLastChangeEvent and m_lastChangeWasUserEdit, respectively.
2142 These are more descriptive names so as to clear an ambiguity surrounding
2143 their usage. Also, renames associated setters and getters so that they
2144 coincide with the renamed fields.
2146 No functionality was changed. So, no tests were included.
2148 * bindings/objc/DOMHTML.mm:
2149 (-[DOMHTMLInputElement _isEdited]):
2150 (-[DOMHTMLTextAreaElement _isEdited]):
2152 (WebCore::Document::setFocusedNode):
2153 * html/HTMLInputElement.cpp:
2154 (WebCore::HTMLInputElement::defaultEventHandler):
2155 * rendering/RenderTextControl.cpp:
2156 (WebCore::RenderTextControl::RenderTextControl):
2157 (WebCore::RenderTextControl::setInnerTextValue):
2158 (WebCore::RenderTextControl::setLastChangeWasUserEdit): Formerly named setUserEdited.
2159 (WebCore::RenderTextControl::subtreeHasChanged):
2160 * rendering/RenderTextControl.h:
2161 (WebCore::RenderTextControl::wasChangedSinceLastChangeEvent): Formerly named isEdited.
2162 (WebCore::RenderTextControl::setChangedSinceLastChangeEvent): Formerly named setEdited.
2163 (WebCore::RenderTextControl::lastChangeWasUserEdit): Formerly named setUserEdited.
2164 * rendering/RenderTextControlSingleLine.cpp:
2165 (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
2166 * wml/WMLInputElement.cpp:
2167 (WebCore::WMLInputElement::defaultEventHandler):
2169 2009-11-18 Tony Chang <tony@chromium.org>
2171 Reviewed by Adam Barth.
2173 Remove V8CanvasPixelArrayCustom.cpp because it is no longer used by V8.
2174 https://bugs.webkit.org/show_bug.cgi?id=31499
2176 No new tests, just a build cleanup.
2179 * bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Removed.
2180 * bindings/v8/custom/V8CustomBinding.h:
2182 2009-11-18 Kevin Watters <kevinwatters@gmail.com>
2184 Reviewed by Kevin Ollivier.
2186 Enable wx plugin support using the Windows implementation as a base.
2188 https://bugs.webkit.org/show_bug.cgi?id=31636
2190 * platform/graphics/GraphicsContext.h:
2191 (WebCore::GraphicsContext::inTransparencyLayer):
2192 * platform/graphics/wx/GraphicsContextWx.cpp:
2193 (WebCore::GraphicsContext::getWindowsContext):
2194 (WebCore::GraphicsContext::releaseWindowsContext):
2195 * platform/wx/FileSystemWx.cpp:
2196 (WebCore::unloadModule):
2197 (WebCore::listDirectory):
2198 * plugins/PluginDatabase.cpp:
2199 * plugins/PluginView.cpp:
2200 (WebCore::PluginView::stop):
2201 (WebCore::PluginView::PluginView):
2202 * plugins/PluginView.h:
2203 * plugins/win/PluginViewWin.cpp:
2204 (windowHandleForPageClient):
2205 (WebCore::PluginView::handleMouseEvent):
2206 (WebCore::PluginView::platformStart):
2207 (WebCore::PluginView::snapshot):
2210 2009-11-18 Andrei Popescu <andreip@google.com>
2212 Reviewed by Dimitri Glazkov.
2214 [Android] Add shared timer and sound utilities to platform/android
2215 https://bugs.webkit.org/show_bug.cgi?id=31584
2217 No new tests required, this is platform specific code.
2219 * platform/android/SharedTimerAndroid.cpp: Added.
2220 (WebCore::setSharedTimerFiredFunction):
2221 (WebCore::setSharedTimerFireTime):
2222 (WebCore::stopSharedTimer):
2223 * platform/android/SoundAndroid.cpp: Added.
2224 (WebCore::systemBeep):
2226 2009-11-18 Mikhail Naganov <mnaganov@chromium.org>
2228 Reviewed by Timothy Hatcher.
2230 Fix profile tree nodes loss after focus / restore actions.
2232 Focusing on a node is currently implemented via nodes reattaching
2233 with some caching involved. It seems that not all code was updated
2234 to handle this scenario correctly.
2236 https://bugs.webkit.org/show_bug.cgi?id=31553
2238 * inspector/front-end/BottomUpProfileDataGridTree.js:
2239 (WebInspector.BottomUpProfileDataGridNode):
2240 (WebInspector.BottomUpProfileDataGridNode.prototype._restore):
2241 (WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate):
2242 (WebInspector.BottomUpProfileDataGridNode.prototype._willHaveChildren):
2243 * inspector/front-end/DataGrid.js:
2244 (WebInspector.DataGrid.prototype.insertChild):
2245 (WebInspector.DataGridNode.prototype._detach):
2246 (WebInspector.DataGridNode.prototype.savePosition):
2247 (WebInspector.DataGridNode.prototype.restorePosition):
2248 * inspector/front-end/TopDownProfileDataGridTree.js:
2249 (WebInspector.TopDownProfileDataGridTree.prototype.focus):
2250 (WebInspector.TopDownProfileDataGridTree.prototype.restore):
2252 2009-11-18 Carol Szabo <carol.szabo@nokia.com>
2254 Reviewed by Kenneth Rohde Christiansen.
2256 [Qt] QWebPageClient.h needs in some cases QCursor, but it does not
2258 https://bugs.webkit.org/show_bug.cgi?id=31527
2260 No new tests as this is just a coding style fix that affects the
2261 build of some not yet submitted patches (i.e. for bug 30173).
2263 * platform/qt/QWebPageClient.h:
2265 2009-11-18 Nicolas Roard <nicolas@roard.com>
2267 Reviewed by Dimitri Glazkov.
2269 InspectorTimelineAgent.h should be guarded by ENABLE(INSPECTOR)
2270 https://bugs.webkit.org/show_bug.cgi?id=31504
2272 * inspector/InspectorTimelineAgent.h:Added the guard.
2274 2009-11-18 Jens Alfke <snej@chromium.org>
2276 Build fix to my previous checkin, for Windows Chromium
2278 * svg/SVGAnimatedProperty.h:
2279 (WebCore::PropertySynchronizer::synchronize): Fix implicit-conversion error on AtomicString.
2281 2009-11-18 Joseph Pecoraro <joepeck@webkit.org>
2283 Reviewed by Pavel Feldman.
2285 Web Inspector: Directly Access <head> Instead of Searching for It
2286 https://bugs.webkit.org/show_bug.cgi?id=31641
2288 Changed old access of the head element (document.getElementsByTagName)
2289 to just use the document.head accessor.
2291 * inspector/front-end/FontView.js:
2292 (WebInspector.FontView):
2293 * inspector/front-end/InjectedScript.js:
2294 (InjectedScript.addStyleSelector):
2295 * inspector/front-end/SourceFrame.js:
2296 (WebInspector.SourceFrame.prototype._loaded):
2297 * inspector/front-end/inspector.js:
2300 2009-11-18 Sam Weinig <sam@webkit.org>
2302 Reviewed by Anders Carlsson.
2304 Fix two Geolocation assertions.
2307 (WebCore::Chrome::requestGeolocationPermissionForFrame): No need to use PageGroupLoadDeferrer since this
2308 is not called from JS.
2309 * page/Geolocation.cpp:
2310 (WebCore::Geolocation::Watchers::set): The PassRefPtr was getting nulled out, so we need to put it in
2313 2009-11-18 Alexey Proskuryakov <ap@apple.com>
2315 Case sensitive file system build fix.
2317 * platform/network/Credential.h: It's not WTF, just wtf.
2319 2009-11-18 Aaron Golden <agolden@apple.com>
2321 Reviewed by Alexey Proskuryakov.
2323 Add support for certificates to WebCore::Credential so we can convert between NSURLCredential
2324 objects and WebCore::Credential objects without losing certificate information.
2326 * platform/network/Credential.cpp:
2327 (WebCore::Credential::Credential): Adding a constructor that takes an identity argument and a certificate chain argument
2328 (WebCore::Credential::isEmpty): Modifying isEmpty to support certificate based credentials (which don't have a username or password)
2329 (WebCore::Credential::identity): Accessor for the m_identity property
2330 (WebCore::Credential::certificates): Accessor for the m_certificates property
2331 (WebCore::Credential::type): Accessor for the m_type property
2332 (WebCore::operator==): Modifying == to compare the identity and certificate chains of certificate based credentials.
2333 * platform/network/Credential.h: Adding new fields to WebCore::Credential to support certificate based credentials.
2334 * platform/network/mac/AuthenticationMac.mm:
2335 (WebCore::mac): Modifying the mac() conversion method to correctly convert certificate based WebCore::Credential objects.
2336 (WebCore::core): Modifying the core() conversion method to correctly convert certificate based NSURLCredential objects.
2338 2009-11-18 Dmitry Titov <dimich@chromium.org>
2340 Reviewed by Eric Seidel.
2342 Reverting r50919 that has introduced a non-thread-safe refcounting in ScriptExecutionContext::postTaskToMainThread.
2343 https://bugs.webkit.org/show_bug.cgi?id=31615
2346 (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
2347 (WebCore::ScriptExecutionContextTaskTimer::fired):
2348 (WebCore::PerformTaskContext::PerformTaskContext):
2349 (WebCore::performTask):
2350 (WebCore::Document::postTask):
2351 * dom/ScriptExecutionContext.cpp:
2352 * dom/ScriptExecutionContext.h:
2354 2009-11-18 Jens Alfke <snej@chromium.org>
2356 Reviewed by Darin Adler.
2358 Eliminate unnecessary String-->AtomicString conversions from generated V8 bindings,
2359 by causing the right v8-to-WebCore conversion function to be called for every parameter.
2360 This no longer requires any IDL metadata, so I've removed the [HintAtomic] annotations.
2361 To enforce correctness, I added a mode that disables implicit
2362 String-->AtomicString conversions while compiling the generated bindings.
2363 https://bugs.webkit.org/show_bug.cgi?id=31168
2365 * bindings/scripts/CodeGeneratorV8.pm: Generate usage of V8Parameter class.
2366 * bindings/v8/DerivedSourcesAllInOne.cpp: Enable NO_IMPLICIT_ATOMICSTRING.
2367 * bindings/v8/V8Binding.h: Add V8Parameter class.
2368 * css/WebKitCSSKeyframesRule.h: Make AtomicString conversions explicit.
2369 * dom/Document.idl: Remove obsolete [HintAtomic] annotation.
2370 * platform/text/AtomicString.h: Added NO_IMPLICIT_ATOMICSTRING option.
2371 * svg/SVGAnimatedTemplate.h: Change some return types to String to avoid implicit conversion.
2372 * svg/SVGAnimatedProperty.h: Adapt to changed return types in SVGAnimatedTemplate.
2374 2009-11-18 Darin Adler <darin@apple.com>
2376 Reviewed by Dan Bernstein.
2378 Move FillOrStrokeType out of public header.
2380 * platform/graphics/GraphicsContext.h: Updated copyright date to cover
2381 some years we published Apple changes, sorted forward declarations,
2382 removed FillOrStrokeType enum.
2383 * platform/graphics/GraphicsContextPrivate.h: Updated copyright date
2384 to cover some years we published Apple changes, sorted includes,
2385 moved FillOrStrokeType enum here.
2387 2009-11-18 Chris Marrin <cmarrin@apple.com>
2389 Reviewed by Simon Fraser.
2391 Add Settings for WebKitShowDebugBorders and WebKitShowRepaintCounter
2392 https://bugs.webkit.org/show_bug.cgi?id=31601
2394 These are used to debug accelerated compositing layers. I removed
2395 the platform specific code from GraphicsLayerCA.mm and added calls
2396 to GraphicsLayerClient to get it from the higher levels. The values
2397 now get cached in RenderLayerCompositing and are queried from there
2398 by RenderLayerBacking (which implements the GraphicsLayerClient interface).
2401 * page/FrameView.cpp:
2402 (WebCore::FrameView::updateCompositingLayers):
2403 * page/Settings.cpp:
2404 (WebCore::Settings::Settings):
2405 (WebCore::Settings::setShowDebugBorders):
2406 (WebCore::Settings::setShowRepaintCounter):
2408 (WebCore::Settings::showDebugBorders):
2409 (WebCore::Settings::showRepaintCounter):
2410 * platform/graphics/GraphicsLayer.h:
2411 (WebCore::GraphicsLayer::showDebugBorders):
2412 (WebCore::GraphicsLayer::showRepaintCounter):
2413 * platform/graphics/GraphicsLayerClient.h:
2414 * platform/graphics/mac/GraphicsLayerCA.mm:
2415 * rendering/RenderLayerBacking.cpp:
2416 (WebCore::RenderLayerBacking::showDebugBorders):
2417 (WebCore::RenderLayerBacking::showRepaintCounter):
2418 * rendering/RenderLayerBacking.h:
2419 * rendering/RenderLayerCompositor.cpp:
2420 (WebCore::RenderLayerCompositor::RenderLayerCompositor):
2421 (WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
2422 * rendering/RenderLayerCompositor.h:
2423 (WebCore::RenderLayerCompositor::showDebugBorders):
2424 (WebCore::RenderLayerCompositor::showRepaintCounter):
2426 2009-11-18 Pavel Feldman <pfeldman@chromium.org>
2428 Reviewed by Timothy Hatcher.
2430 Web Inspector: Get rid of metrics and properties sidebars'
2433 https://bugs.webkit.org/show_bug.cgi?id=31629
2435 * inspector/front-end/MetricsSidebarPane.js:
2436 * inspector/front-end/PropertiesSidebarPane.js:
2438 2009-11-17 Brian Weinstein <bweinstein@apple.com>
2440 Reviewed by Pavel Feldman.
2442 Fixes <http://webkit.org/b/31606>.
2443 Web Inspector: Enter/Return key should enter edit mode for Editable Fields.
2445 This implements Enter starting editing mode in an editable DataGrid. If the
2446 DataGrid is editable and the user hits return, startEditing the first child
2447 of the selected node. Also refactored some editing functions to take an
2448 event target instead of the event itself, because the functions only needed
2449 the target. Lastly, added had return in editing mode stop propogation, because
2450 when enter was hit to confirm text, it would propagate back to the datagrid
2451 and try to start editing again.
2453 * inspector/front-end/DataGrid.js:
2454 (WebInspector.DataGrid.prototype._ondblclick):
2455 (WebInspector.DataGrid.prototype._startEditing):
2456 (WebInspector.DataGrid.prototype.handleKeyEvent):
2457 (WebInspector.DataGrid.prototype.dataGridNodeFromEvent):
2458 (WebInspector.DataGrid.prototype._mouseDownInDataTable):
2459 (WebInspector.DataGrid.prototype._clickInDataTable):
2460 * inspector/front-end/inspector.js:
2461 (WebInspector.startEditing.element.handleKeyEvent):
2462 (WebInspector.startEditing):
2464 2009-11-18 Ben Murdoch <benm@google.com>
2466 Reviewed by Darin Adler.
2468 HTMLAnchorElement is inconsistent with its internal handling of the value returned for the href attribute.
2469 https://bugs.webkit.org/show_bug.cgi?id=31593
2471 Test: fast/dom/HTMLAnchorElement/set-href-attribute-whitespace.html
2473 * html/HTMLAnchorElement.cpp:
2474 (WebCore::HTMLAnchorElement::href): Add call to deprecatedParseURL.
2476 2009-11-18 Pavel Feldman <pfeldman@chromium.org>
2478 Not reviewed. Touch InspectorController so that frontend
2479 JS files are deployed on Windows.
2481 * inspector/InspectorController.cpp:
2483 2009-11-18 Pavel Feldman <pfeldman@chromium.org>
2485 Reviewed by Timothy Hatcher.
2487 Web Inspector: clone timeline records array instead of
2488 copying reference on invalidate all.
2490 https://bugs.webkit.org/show_bug.cgi?id=31596
2492 * inspector/front-end/AbstractTimelinePanel.js:
2493 (WebInspector.AbstractTimelinePanel.prototype.invalidateAllItems):
2495 2009-11-18 Simon Fraser <simon.fraser@apple.com>
2497 Reviewed by Dan Bernstein.
2499 Elements don't drop out of compositing layers when animation ends
2500 https://bugs.webkit.org/show_bug.cgi?id=31613
2501 <rdar://problem/7402913>
2503 Avoid setting the mustOverlapCompositedLayers flag on RenderLayers which
2504 are compositing anyway for other reasons. Doing so can cause those layers
2505 to stay in compositing mode even after animations finish, because needsToBeComposited()
2506 continues to return true.
2508 No new tests because it's not possible to determine which elements are in
2509 compositing layers from DRT output.
2511 * rendering/RenderLayerCompositor.cpp:
2512 (WebCore::RenderLayerCompositor::computeCompositingRequirements):
2514 2009-11-18 Girish Ramakrishnan <girish@forwardbias.in>
2516 Reviewed by Tor Arne Vestbø.
2518 [Qt] Mac Plugins: Remove null timer
2520 A null timer was used to send mouse move events. Instead, we now use
2521 move events to send nullEvent. This brings down CPU usage by 20-30%.
2523 https://bugs.webkit.org/show_bug.cgi?id=31624
2525 * plugins/PluginView.h:
2526 * plugins/mac/PluginViewMac.cpp:
2527 (WebCore::PluginView::platformStart):
2528 (WebCore::PluginView::handleMouseEvent):
2530 2009-11-18 Benjamin Poulain <benjamin.poulain@nokia.com>
2532 Reviewed by Simon Hausmann.
2534 [Qt] WebKit crashes when loading certain SVG images
2536 Check if the familly exist before creating the PlatformData from it.
2538 https://bugs.webkit.org/show_bug.cgi?id=29443
2540 Test: svg/text/text-font-invalid.html
2542 * platform/graphics/qt/FontFallbackListQt.cpp:
2543 (WebCore::FontFallbackList::fontDataAt):
2545 2009-11-17 Nicolas Weber <thakis@chromium.org>
2547 Reviewed by Darin Fisher.
2549 Fix crash in Chromium/Mac where dropdowns weren't dismissed correctly
2551 https://bugs.webkit.org/show_bug.cgi?id=31609
2553 * platform/chromium/PopupMenuChromium.cpp:
2554 (WebCore::PopupContainer::showExternal): Set parent for external
2555 dropdowns, so that |PopupListBox::hidePopup()| can successfully notify
2556 its parent's client.
2558 2009-11-17 Hayato Ito <hayato@google.com>
2560 Reviewed by Darin Adler.
2562 Avoid infinite mutual recursion when deeply nested tags are loaded
2563 https://bugs.webkit.org/show_bug.cgi?id=30651
2565 Test: fast/parser/block-nesting-cap-table.html
2567 * html/HTMLParser.cpp:
2568 (WebCore::HTMLParser::parseToken):
2569 (WebCore::tagPriorityOfNode):
2570 (WebCore::HTMLParser::limitBlockDepth):
2571 (WebCore::HTMLParser::insertNodeAfterLimitBlockDepth):
2572 (WebCore::HTMLParser::insertNode):
2573 * html/HTMLParser.h:
2575 2009-11-17 Brent Fulgham <bfulgham@webkit.org>
2577 Rubber-stamped by Alexey Proskuryakov.
2579 Final clean-ups for minor coding standard violations.
2580 https://bugs.webkit.org/show_bug.cgi?id=26102.
2582 * platform/graphics/cairo/GraphicsContextCairo.cpp:
2584 2009-11-17 Johnny Ding <jnd@chromium.org>
2586 Reviewed by Darin Adler.
2588 In all valid script tags for JavaScript, the event handler in <script...for> should not get executed.
2589 https://bugs.webkit.org/show_bug.cgi?id=31567
2591 * dom/ScriptElement.cpp:
2592 (WebCore::ScriptElementData::shouldExecuteAsJavaScript):
2594 2009-11-17 Pavel Feldman <pfeldman@chromium.org>
2596 Reviewed by Timothy Hatcher.
2598 Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
2599 - Updated DRT to show/close inspector for all tests under /inspector
2600 - Introduced LayoutTestController::setTimelineProfilingEnabled and
2601 WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
2602 - Removed reload on each inspector test
2603 - Renamed fast/inspector to fast/inspector-support in order not to trigger
2604 inspector for those.
2605 - Reimplemented timeline tests in order to get rid of reload there.
2606 - Moved tests that don't require harness into the fast group.
2608 https://bugs.webkit.org/show_bug.cgi?id=31472
2610 * WebCore.Inspector.exp:
2611 * inspector/front-end/TimelinePanel.js:
2612 (WebInspector.TimelinePanel.prototype._formatRecord):
2614 2009-11-17 Andrei Popescu <andreip@google.com>
2616 Reviewed by Dimitri Glazkov.
2618 [Android] Android is missing the implementation of the GeolocationService iface.
2619 https://bugs.webkit.org/show_bug.cgi?id=31554
2621 No new tests required as this is platform specific code.
2623 * platform/android/GeolocationServiceAndroid.cpp: Added.
2624 (WebCore::GeolocationServiceAndroid::create):
2625 (WebCore::GeolocationServiceAndroid::GeolocationServiceAndroid):
2626 (WebCore::GeolocationServiceAndroid::startUpdating):
2627 (WebCore::GeolocationServiceAndroid::stopUpdating):
2628 (WebCore::GeolocationServiceAndroid::suspend):
2629 (WebCore::GeolocationServiceAndroid::resume):
2630 (WebCore::GeolocationServiceAndroid::newPositionAvailable):
2631 (WebCore::GeolocationServiceAndroid::newErrorAvailable):
2632 (WebCore::GeolocationServiceAndroid::timerFired):
2633 (WebCore::GeolocationServiceAndroid::isPositionMovement):
2634 (WebCore::GeolocationServiceAndroid::isPositionMoreAccurate):
2635 (WebCore::GeolocationServiceAndroid::isPositionMoreTimely):
2636 * platform/android/GeolocationServiceAndroid.h: Added.
2637 (WebCore::GeolocationServiceAndroid::~GeolocationServiceAndroid):
2638 (WebCore::GeolocationServiceAndroid::lastPosition):
2639 (WebCore::GeolocationServiceAndroid::lastError):
2640 * platform/android/GeolocationServiceBridge.cpp: Added.
2642 (WebCore::GeolocationServiceBridge::GeolocationServiceBridge):
2643 (WebCore::GeolocationServiceBridge::~GeolocationServiceBridge):
2644 (WebCore::GeolocationServiceBridge::start):
2645 (WebCore::GeolocationServiceBridge::stop):
2646 (WebCore::GeolocationServiceBridge::setEnableGps):
2647 (WebCore::GeolocationServiceBridge::newLocationAvailable):
2648 (WebCore::GeolocationServiceBridge::newErrorAvailable):
2649 (WebCore::GeolocationServiceBridge::toGeoposition):
2650 (WebCore::GeolocationServiceBridge::startJavaImplementation):
2651 (WebCore::GeolocationServiceBridge::stopJavaImplementation):
2652 * platform/android/GeolocationServiceBridge.h: Added.
2654 2009-11-16 Kent Tamura <tkent@chromium.org>
2656 Unreviewd build fix.
2658 - Fix typo in WebCore.vcproj.
2659 - Intlude limits.h for INT_MAX.
2660 - Enclose with parenthesis to suspress warning.
2662 * WebCore.vcproj/WebCore.vcproj:
2663 * html/ISODateTime.cpp:
2664 (WebCore::ISODateTime::addDay):
2666 2009-11-16 Robin Dunn <robin@alldunn.com>
2668 Reviewed by Kevin Ollivier.
2670 Make sure wx scrollbar drawing code factors in transforms when switching backends,
2671 fix calcs for scrollbar length, and tweak the Mac scrollbar tracking rects.
2673 https://bugs.webkit.org/show_bug.cgi?id=31570
2675 * platform/wx/ScrollbarThemeWx.cpp:
2676 (WebCore::ScrollbarThemeWx::minimumThumbLength):
2677 (WebCore::ScrollbarThemeWx::splitTrack):
2678 (WebCore::ScrollbarThemeWx::forwardButtonRect):
2679 * platform/wx/ScrollbarThemeWx.h:
2680 * platform/wx/wxcode/gtk/scrollbar_render.cpp:
2681 (wxRenderer_DrawScrollbar):
2682 * platform/wx/wxcode/scrollbar_render.h:
2683 (calcThumbStartAndLength):
2684 * platform/wx/wxcode/win/scrollbar_render.cpp:
2685 (wxRenderer_DrawScrollbar):
2687 2009-11-16 Kent Tamura <tkent@chromium.org>
2689 Reviewed by David Levin.
2691 Introduce WebCore::ISODateTime class.
2692 https://bugs.webkit.org/show_bug.cgi?id=31340
2694 This class represents a value of date/time types of the HTML5 INPUT
2695 element, and has some parsing methods for ISO 8601.
2697 This change has no tests because the class is not used yet.
2699 * GNUmakefile.am: Add ISODateTime.cpp and ISODateTime.h.
2700 * WebCore.gypi: ditto.
2701 * WebCore.pro: ditto.
2702 * WebCore.vcproj/WebCore.vcproj: ditto.
2703 * WebCore.xcodeproj/project.pbxproj: ditto.
2704 * WebCoreSources.bkl: ditto.
2705 * html/ISODateTime.cpp: Added. Implementation of WebCore::ISODateTime class.
2706 (WebCore::isLeapYear):
2707 (WebCore::maxDayOfMonth):
2708 (WebCore::dayOfWeek):
2709 (WebCore::ISODateTime::maxWeekNumberInYear):
2710 (WebCore::countDigits):
2712 (WebCore::ISODateTime::parseYear): Private helper for parseDate() and parseWeek().
2713 (WebCore::ISODateTime::addDay): Private helper for parseTimeZone().
2714 (WebCore::ISODateTime::addMinute): ditto.
2715 (WebCore::ISODateTime::parseTimeZone): Private helper for parseDateTime().
2716 (WebCore::ISODateTime::parseMonth): Parser for <input type=month>.
2717 (WebCore::ISODateTime::parseDate): Parser for <input type=date>.
2718 (WebCore::ISODateTime::parseWeek): Parser for <input type=week>.
2719 (WebCore::ISODateTime::parseTime): Parser for <input type=time>.
2720 (WebCore::ISODateTime::parseDateTimeLocal): Parser for <input type=datetime-local>.
2721 (WebCore::ISODateTime::parseDateTime): Parser for <input type=datetime>.
2722 * html/ISODateTime.h: Added. Declare WebCore::ISODateTime class.
2723 (WebCore::ISODateTime::ISODateTime):
2724 (WebCore::ISODateTime::millisecond):
2725 (WebCore::ISODateTime::second):
2726 (WebCore::ISODateTime::minute):
2727 (WebCore::ISODateTime::hour):
2728 (WebCore::ISODateTime::monthDay):
2729 (WebCore::ISODateTime::month):
2730 (WebCore::ISODateTime::fullYear):
2731 (WebCore::ISODateTime::week):
2733 2009-11-16 Alexey Proskuryakov <ap@apple.com>
2735 Fix a typo in previous commit.
2737 * platform/network/cf/SocketStreamHandleCFNet.cpp: #ifdef, not #if.
2739 2009-11-16 Alexey Proskuryakov <ap@apple.com>
2741 Fix a typo in previous commit.
2743 * platform/network/cf/SocketStreamHandleCFNet.cpp:
2745 2009-11-16 Alexey Proskuryakov <ap@apple.com>
2749 * platform/network/cf/SocketStreamHandleCFNet.cpp: Define CFN_EXPORT, as this macro was named
2750 differently in Tiger CFNetwork.
2752 2009-11-16 Dimitri Glazkov <dglazkov@chromium.org>
2754 Reviewed by Darin Fisher.
2756 [KURLGoogle] setHostAndPort doesn't handle arguments without port correctly.
2758 Fix a bug in the code that was dormant until http://trac.webkit.org/changeset/50784.
2760 Covered by existing test: LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-host.html
2762 * platform/KURLGoogle.cpp:
2763 (WebCore::KURL::setHostAndPort): Added handling of arguments without port specified.
2765 2009-11-16 Alexey Proskuryakov <ap@apple.com>
2767 Rubber-stamped by Jon Honeycutt.
2769 A better Windows build fix
2771 * platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::createStreams):
2772 Use a macro that inserts __declspec(dllimport) when appropriate for CFNetwork imports.
2774 2009-11-16 Yael Aharon <yael.aharon@nokia.com>
2776 Reviewed by Darin Adler.
2778 Rename protocolIsValid to isValidProtocol.
2779 https://bugs.webkit.org/show_bug.cgi?id=31503
2781 This name change was suggested in https://bugs.webkit.org/show_bug.cgi?id=29972#c19.
2783 No new tests since no new functionality was introduced.
2785 * html/HTMLAnchorElement.cpp:
2786 (WebCore::HTMLAnchorElement::setProtocol):
2787 * platform/KURL.cpp:
2788 (WebCore::isValidProtocol):
2790 * platform/KURLGoogle.cpp:
2791 (WebCore::isValidProtocol):
2793 2009-11-16 Chris Fleizach <cfleizach@apple.com>
2795 Reviewed by Beth Dakin.
2797 AX: aria-labelledby duplicates some of its WAI-ARIA label
2798 https://bugs.webkit.org/show_bug.cgi?id=31565
2800 Test: accessibility/aria-labelledby-overrides-label.html
2802 * accessibility/AccessibilityRenderObject.cpp:
2803 (WebCore::AccessibilityRenderObject::hasTextAlternative):
2804 (WebCore::AccessibilityRenderObject::exposesTitleUIElement):
2805 (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
2806 * accessibility/AccessibilityRenderObject.h:
2808 2009-11-16 Nate Chapin <japhet@chromium.org>
2810 Reviewed by Darin Fisher.
2812 Handle the case of a null NPObject* in NPN_SetException in
2813 the V8 bindings. This allow out of process plugins calling
2814 NPN_SetException to just send null instead of sending an
2815 NPObject* that would be an address in a different
2816 process's memory space.
2818 https://bugs.webkit.org/show_bug.cgi?id=31561
2820 * bindings/v8/NPV8Object.cpp:
2821 (_NPN_SetException): Allow null NPObject* and just throw a general error.
2823 2009-11-16 Alexey Proskuryakov <ap@apple.com>
2827 * platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::createStreams):
2828 Disable CONNECT proxies on Windows until WebKitSupportLibrary includes support for those.
2830 2009-11-14 Yael Aharon <yael.aharon@nokia.com>
2832 Reviewed by Kenneth Rohde Christiansen.
2834 [Qt] ASSERT failure while running DRT
2835 https://bugs.webkit.org/show_bug.cgi?id=30978
2837 Add needed Structure typeInfo flags to QtRuntimeObjectImpl and QtRuntimeMethod.
2838 These flags are needed after r49649, where HasDefaultmark was changed to OverrideMarkChildren.
2840 * bridge/qt/qt_instance.cpp:
2841 (JSC::Bindings::QtRuntimeObjectImp::createStructure):
2842 * bridge/qt/qt_runtime.h:
2843 (JSC::Bindings::QtRuntimeMethod::createStructure):
2845 2009-11-16 Mark Rowe <mrowe@apple.com>
2847 Attempt to fix the build. Land a file that was missing from r51049.
2849 * bindings/js/JSWebGLArrayHelper.h: Copied from WebCore/html/canvas/WebGLByteArray.idl.
2850 (WebCore::setWebGLArrayFromArray):
2852 2009-11-16 Kenneth Russell <kbr@google.com>
2854 Reviewed by Oliver Hunt.
2856 Update API of WebGLArray and friends
2857 https://bugs.webkit.org/show_bug.cgi?id=31175
2859 * bindings/js/JSWebGLArrayCustom.cpp:
2861 * bindings/js/JSWebGLArrayHelper.h: Added.
2862 (WebCore::setWebGLArrayFromArray):
2863 * bindings/js/JSWebGLByteArrayCustom.cpp:
2864 (WebCore::JSWebGLByteArray::set):
2865 * bindings/js/JSWebGLFloatArrayCustom.cpp:
2866 (WebCore::JSWebGLFloatArray::set):
2867 * bindings/js/JSWebGLIntArrayCustom.cpp:
2868 (WebCore::JSWebGLIntArray::set):
2869 * bindings/js/JSWebGLShortArrayCustom.cpp:
2870 (WebCore::JSWebGLShortArray::set):
2871 * bindings/js/JSWebGLUnsignedByteArrayCustom.cpp:
2872 (WebCore::JSWebGLUnsignedByteArray::set):
2873 * bindings/js/JSWebGLUnsignedIntArrayCustom.cpp:
2874 (WebCore::JSWebGLUnsignedIntArray::set):
2875 * bindings/js/JSWebGLUnsignedShortArrayCustom.cpp:
2876 (WebCore::JSWebGLUnsignedShortArray::set):
2877 * bindings/scripts/CodeGeneratorV8.pm:
2878 * bindings/v8/V8DOMWrapper.cpp:
2879 (WebCore::V8DOMWrapper::convertToV8Object):
2880 * bindings/v8/custom/V8CustomBinding.h:
2881 * bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
2882 (WebCore::CALLBACK_FUNC_DECL):
2883 * bindings/v8/custom/V8WebGLArrayCustom.h:
2884 (WebCore::constructWebGLArray):
2885 (WebCore::getWebGLArrayElement):
2886 (WebCore::setWebGLArrayFromArray):
2887 (WebCore::setWebGLArray):
2888 * bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
2889 (WebCore::CALLBACK_FUNC_DECL):
2890 * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
2891 (WebCore::CALLBACK_FUNC_DECL):
2892 * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
2893 (WebCore::CALLBACK_FUNC_DECL):
2894 * bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
2895 (WebCore::CALLBACK_FUNC_DECL):
2896 * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
2897 (WebCore::CALLBACK_FUNC_DECL):
2898 * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
2899 (WebCore::CALLBACK_FUNC_DECL):
2900 * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
2901 (WebCore::CALLBACK_FUNC_DECL):
2902 * html/canvas/WebGLArray.cpp:
2903 (WebCore::WebGLArray::WebGLArray):
2904 (WebCore::WebGLArray::~WebGLArray):
2905 (WebCore::WebGLArray::setImpl):
2906 * html/canvas/WebGLArray.h:
2907 (WebCore::WebGLArray::isByteArray):
2908 (WebCore::WebGLArray::isUnsignedByteArray):
2909 (WebCore::WebGLArray::isShortArray):
2910 (WebCore::WebGLArray::isUnsignedShortArray):
2911 (WebCore::WebGLArray::isIntArray):
2912 (WebCore::WebGLArray::isUnsignedIntArray):
2913 (WebCore::WebGLArray::isFloatArray):
2914 (WebCore::WebGLArray::buffer):
2915 (WebCore::WebGLArray::baseAddress):
2916 (WebCore::WebGLArray::byteOffset):
2917 * html/canvas/WebGLArray.idl:
2918 * html/canvas/WebGLArrayBuffer.cpp:
2919 (WebCore::WebGLArrayBuffer::create):
2920 (WebCore::WebGLArrayBuffer::WebGLArrayBuffer):
2921 (WebCore::WebGLArrayBuffer::data):
2922 (WebCore::WebGLArrayBuffer::byteLength):
2923 (WebCore::WebGLArrayBuffer::~WebGLArrayBuffer):
2924 * html/canvas/WebGLArrayBuffer.h:
2925 * html/canvas/WebGLByteArray.cpp:
2926 (WebCore::WebGLByteArray::create):
2927 (WebCore::WebGLByteArray::byteLength):
2928 (WebCore::WebGLByteArray::slice):
2929 (WebCore::WebGLByteArray::set):
2930 * html/canvas/WebGLByteArray.h:
2931 (WebCore::WebGLByteArray::isByteArray):
2932 (WebCore::WebGLByteArray::data):
2933 (WebCore::WebGLByteArray::set):
2934 (WebCore::WebGLByteArray::get):
2935 (WebCore::WebGLByteArray::item):
2936 * html/canvas/WebGLByteArray.idl:
2937 * html/canvas/WebGLFloatArray.cpp:
2938 (WebCore::WebGLFloatArray::create):
2939 (WebCore::WebGLFloatArray::WebGLFloatArray):
2940 (WebCore::WebGLFloatArray::length):
2941 (WebCore::WebGLFloatArray::byteLength):
2942 (WebCore::WebGLFloatArray::slice):
2943 (WebCore::WebGLFloatArray::set):
2944 * html/canvas/WebGLFloatArray.h:
2945 (WebCore::WebGLFloatArray::isFloatArray):
2946 (WebCore::WebGLFloatArray::data):
2947 (WebCore::WebGLFloatArray::set):
2948 (WebCore::WebGLFloatArray::get):
2949 (WebCore::WebGLFloatArray::item):
2950 * html/canvas/WebGLFloatArray.idl:
2951 * html/canvas/WebGLIntArray.cpp:
2952 (WebCore::WebGLIntArray::create):
2953 (WebCore::WebGLIntArray::WebGLIntArray):
2954 (WebCore::WebGLIntArray::length):
2955 (WebCore::WebGLIntArray::byteLength):
2956 (WebCore::WebGLIntArray::slice):
2957 (WebCore::WebGLIntArray::set):
2958 * html/canvas/WebGLIntArray.h:
2959 (WebCore::WebGLIntArray::isIntArray):
2960 (WebCore::WebGLIntArray::data):
2961 (WebCore::WebGLIntArray::set):
2962 (WebCore::WebGLIntArray::get):
2963 (WebCore::WebGLIntArray::item):
2964 * html/canvas/WebGLIntArray.idl:
2965 * html/canvas/WebGLShortArray.cpp:
2966 (WebCore::WebGLShortArray::create):
2967 (WebCore::WebGLShortArray::WebGLShortArray):
2968 (WebCore::WebGLShortArray::length):
2969 (WebCore::WebGLShortArray::byteLength):
2970 (WebCore::WebGLShortArray::slice):
2971 (WebCore::WebGLShortArray::set):
2972 * html/canvas/WebGLShortArray.h:
2973 (WebCore::WebGLShortArray::isShortArray):
2974 (WebCore::WebGLShortArray::data):
2975 (WebCore::WebGLShortArray::set):
2976 (WebCore::WebGLShortArray::get):
2977 (WebCore::WebGLShortArray::item):
2978 * html/canvas/WebGLShortArray.idl:
2979 * html/canvas/WebGLUnsignedByteArray.cpp:
2980 (WebCore::WebGLUnsignedByteArray::create):
2981 (WebCore::WebGLUnsignedByteArray::WebGLUnsignedByteArray):
2982 (WebCore::WebGLUnsignedByteArray::length):
2983 (WebCore::WebGLUnsignedByteArray::byteLength):
2984 (WebCore::WebGLUnsignedByteArray::slice):
2985 (WebCore::WebGLUnsignedByteArray::set):
2986 * html/canvas/WebGLUnsignedByteArray.h:
2987 (WebCore::WebGLUnsignedByteArray::isUnsignedByteArray):
2988 (WebCore::WebGLUnsignedByteArray::data):
2989 (WebCore::WebGLUnsignedByteArray::set):
2990 (WebCore::WebGLUnsignedByteArray::get):
2991 (WebCore::WebGLUnsignedByteArray::item):
2992 * html/canvas/WebGLUnsignedByteArray.idl:
2993 * html/canvas/WebGLUnsignedIntArray.cpp:
2994 (WebCore::WebGLUnsignedIntArray::create):
2995 (WebCore::WebGLUnsignedIntArray::WebGLUnsignedIntArray):
2996 (WebCore::WebGLUnsignedIntArray::length):
2997 (WebCore::WebGLUnsignedIntArray::byteLength):
2998 (WebCore::WebGLUnsignedIntArray::slice):
2999 (WebCore::WebGLUnsignedIntArray::set):
3000 * html/canvas/WebGLUnsignedIntArray.h:
3001 (WebCore::WebGLUnsignedIntArray::isUnsignedIntArray):
3002 (WebCore::WebGLUnsignedIntArray::data):
3003 (WebCore::WebGLUnsignedIntArray::set):
3004 (WebCore::WebGLUnsignedIntArray::get):
3005 (WebCore::WebGLUnsignedIntArray::item):
3006 * html/canvas/WebGLUnsignedIntArray.idl:
3007 * html/canvas/WebGLUnsignedShortArray.cpp:
3008 (WebCore::WebGLUnsignedShortArray::create):
3009 (WebCore::WebGLUnsignedShortArray::WebGLUnsignedShortArray):
3010 (WebCore::WebGLUnsignedShortArray::length):
3011 (WebCore::WebGLUnsignedShortArray::byteLength):
3012 (WebCore::WebGLUnsignedShortArray::slice):
3013 (WebCore::WebGLUnsignedShortArray::set):
3014 * html/canvas/WebGLUnsignedShortArray.h:
3015 (WebCore::WebGLUnsignedShortArray::isUnsignedShortArray):
3016 (WebCore::WebGLUnsignedShortArray::data):
3017 (WebCore::WebGLUnsignedShortArray::set):
3018 (WebCore::WebGLUnsignedShortArray::get):
3019 (WebCore::WebGLUnsignedShortArray::item):
3020 * html/canvas/WebGLUnsignedShortArray.idl:
3021 * platform/graphics/mac/GraphicsContext3DMac.cpp:
3022 (WebCore::GraphicsContext3D::bufferData):
3023 (WebCore::GraphicsContext3D::bufferSubData):
3025 2009-11-16 Alexey Proskuryakov <ap@apple.com>
3029 * platform/network/cf/SocketStreamHandleCFNet.cpp: Declare constants as extern "C".
3031 2009-11-15 Brent Fulgham <bfulgham@webkit.org>
3033 Reviewed by Oliver Hunt.
3035 Enable support for webkit-box-shadow in Cairo builds.
3036 https://bugs.webkit.org/show_bug.cgi?id=26102.
3038 Covered by existing fast/box-shadow tests.
3040 * platform/graphics/cairo/GraphicsContextCairo.cpp: Add
3041 support for fillRect shadows.
3043 2009-11-16 Alexey Proskuryakov <ap@apple.com>
3047 * platform/network/cf/SocketStreamHandleCFNet.cpp: Don't try to include a file that's not
3048 in WebKitSupportLibrary.
3050 2009-11-16 Alexey Proskuryakov <ap@apple.com>
3052 Reviewed by Darin Adler.
3054 https://bugs.webkit.org/show_bug.cgi?id=31494
3055 Add unauthenticated proxy support to SocketStreamHandleCFNet
3057 Cannot be tested in DRT.
3059 * platform/network/cf/SocketStreamHandleCFNet.cpp:
3060 (WebCore::SocketStreamHandle::chooseProxy): Fetch proxy information from OS.
3061 (WebCore::SocketStreamHandle::createStreams): Apply it to the newly created streams.
3063 2009-11-14 Antonio Gomes <tonikitoo@webkit.org>
3065 Reviewed by Antti Koivisto.
3067 [Qt] Broken back/forward after using ErrorPageExtension to set error page
3068 https://bugs.webkit.org/show_bug.cgi?id=30573
3070 Make FrameLoader::checkLoadCompleteForThisFrame method
3071 to check for any working DocumentLoader instance (through
3072 activeDocumentLoader()) instead of only checking for
3073 'm_provisionalDocumentLoader' in order to decide to if
3074 it is going to reset of not the back and forward history.
3075 after an error page has been loaded.
3077 Test: LayoutTests/fast/history/back-forward-reset-after-error-handling.html
3079 * loader/FrameLoader.cpp:
3080 (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
3082 2009-11-14 Chris Fleizach <cfleizach@apple.com>
3084 Reviewed by Darin Adler.
3086 Need to implement ARIA role="directory"
3087 https://bugs.webkit.org/show_bug.cgi?id=31516
3089 Test: platform/mac/accessibility/aria-directory.html
3091 * accessibility/AXObjectCache.cpp:
3092 (WebCore::AXObjectCache::getOrCreate):
3093 * accessibility/AccessibilityList.cpp:
3094 (WebCore::AccessibilityList::isOrderedList):
3095 * accessibility/AccessibilityRenderObject.cpp:
3096 (WebCore::createARIARoleMap):
3098 2009-11-15 Dave Tapuska <dtapuska@rim.com>
3100 Reviewed by George Staikos.
3102 Compare UChars single unit at a time as opposed to the uint32_t
3103 approach as casting to unaligned addresses may cause a bus failure
3104 on ARMv5 and below. This change replicates the same defines that
3105 exists in AtomicString.cpp
3107 https://bugs.webkit.org/show_bug.cgi?id=31475
3109 * platform/text/StringHash.h:
3110 (WebCore::StringHash::equal):
3112 2009-11-15 Evan Martin <evan@chromium.org>
3114 Reviewed by Adam Barth.
3116 Wrap some SVG code in V8DOMWrapper with an ENABLE(SVG) test.
3118 https://bugs.webkit.org/show_bug.cgi?id=31490
3120 * bindings/v8/V8DOMWrapper.cpp:
3122 2009-11-15 Maxime Simon <simon.maxime@gmail.com>
3124 Reviewed by Adam Barth.
3126 [Haiku] Build fix. The FileChooser constructor doesn't need to be redefined.
3128 * platform/haiku/FileChooserHaiku.cpp:
3130 2009-11-15 Maxime Simon <simon.maxime@gmail.com>
3132 Reviewed by Adam Barth.
3134 [Haiku] Build fix. ColorSpace name had a wrong CamelCase.
3136 * platform/graphics/haiku/GraphicsContextHaiku.cpp:
3137 (WebCore::GraphicsContext::setPlatformStrokeColor):
3139 2009-11-15 Daniel Bates <dbates@webkit.org>
3141 No review, rolling out r50999.
3142 http://trac.webkit.org/changeset/50999
3144 Need to fix some issues in the Windows build. Missed some places where
3145 RenderTextControl::isEdited is called.
3147 * bindings/objc/DOMHTML.mm:
3148 (-[DOMHTMLInputElement _isEdited]):
3149 (-[DOMHTMLTextAreaElement _isEdited]):
3151 (WebCore::Document::setFocusedNode):
3152 * html/HTMLInputElement.cpp:
3153 (WebCore::HTMLInputElement::defaultEventHandler):
3154 * rendering/RenderTextControl.cpp:
3155 (WebCore::RenderTextControl::RenderTextControl):
3156 (WebCore::RenderTextControl::setInnerTextValue):
3157 (WebCore::RenderTextControl::setUserEdited):
3158 (WebCore::RenderTextControl::subtreeHasChanged):
3159 * rendering/RenderTextControl.h:
3160 (WebCore::RenderTextControl::isEdited):
3161 (WebCore::RenderTextControl::setEdited):
3162 (WebCore::RenderTextControl::isUserEdited):
3163 * rendering/RenderTextControlSingleLine.cpp:
3164 (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
3165 * wml/WMLInputElement.cpp:
3166 (WebCore::WMLInputElement::defaultEventHandler):
3168 2009-11-15 Daniel Bates <dbates@webkit.org>
3170 Reviewed by Darin Adler.
3172 https://bugs.webkit.org/show_bug.cgi?id=31186
3174 Renames RenderTextControl::m_edited and RenderTextControl::m_userEdited to
3175 m_wasChangedSinceLastChangeEvent and m_lastChangeWasUserEdit, respectively.
3176 These are more descriptive names so as to clear an ambiguity surrounding
3177 their usage. Also, renames associated setters and getters so that they
3178 coincide with the renamed fields.
3180 No functionality was changed. So, no tests were included.
3182 * bindings/objc/DOMHTML.mm:
3183 (-[DOMHTMLInputElement _isEdited]):
3184 (-[DOMHTMLTextAreaElement _isEdited]):
3186 (WebCore::Document::setFocusedNode):
3187 * html/HTMLInputElement.cpp:
3188 (WebCore::HTMLInputElement::defaultEventHandler):
3189 * rendering/RenderTextControl.cpp:
3190 (WebCore::RenderTextControl::RenderTextControl):
3191 (WebCore::RenderTextControl::setInnerTextValue):
3192 (WebCore::RenderTextControl::setLastChangeWasUserEdit): Formerly named setUserEdited.
3193 (WebCore::RenderTextControl::subtreeHasChanged):
3194 * rendering/RenderTextControl.h:
3195 (WebCore::RenderTextControl::wasChangedSinceLastChangeEvent): Formerly named isEdited.
3196 (WebCore::RenderTextControl::setChangedSinceLastChangeEvent): Formerly named setEdited.
3197 (WebCore::RenderTextControl::lastChangeWasUserEdit): Formerly named setUserEdited.
3198 * rendering/RenderTextControlSingleLine.cpp:
3199 (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
3200 * wml/WMLInputElement.cpp:
3201 (WebCore::WMLInputElement::defaultEventHandler):
3203 2009-11-14 Adele Peterson <adele@apple.com>
3205 Reviewed by Dan Bernstein.
3207 Fix for <rdar://problem/6946165> Would like to be able to specify the number of visible lines when using -webkit-line-clamp
3209 Test: fast/overflow/line-clamp.html
3211 * css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Updated to handle different types of values.
3212 * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): ditto.
3213 * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): ditto.
3215 * rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox):
3216 Use the line count value if available. Otherwise, convert the percentage to the line count, as we did before. Also,
3217 if there is anchor as the last child box, still allow adding the ellipsis.
3219 * rendering/RenderLayer.cpp:
3220 (WebCore::RenderLayer::scrollByRecursively): Call isNone on the LineClampValue to see if the line-clamp property has been set.
3221 (WebCore::RenderLayer::scrollRectToVisible): ditto.
3223 * WebCore.xcodeproj/project.pbxproj: Added LineClampValue.h
3224 * rendering/style/LineClampValue.h: Added.
3225 (WebCore::LineClampValue::LineClampValue):
3226 (WebCore::LineClampValue::value):
3227 (WebCore::LineClampValue::isPercentage):
3228 (WebCore::LineClampValue::isNone):
3229 (WebCore::LineClampValue::operator==):
3230 (WebCore::LineClampValue::operator!=):
3231 * rendering/style/RenderStyleConstants.h: (WebCore::): Define ELineClampType enum for percentage or line count.
3233 * rendering/style/RenderStyle.h: Use LineClampValue.
3234 (WebCore::InheritedFlags::lineClamp):
3235 (WebCore::InheritedFlags::setLineClamp):
3236 (WebCore::InheritedFlags::initialLineClamp):
3237 * rendering/style/StyleRareNonInheritedData.h:
3239 2009-11-14 Eric Carlson <eric.carlson@apple.com>
3241 Reviewed by Oliver Hunt.
3243 <rdar://problem/7287487>
3244 Do not use QuickTime version to detect media controller theme
3246 * WebCore.base.exp: Export wkMediaControllerThemeAvailable
3247 * platform/mac/WebCoreSystemInterface.h: Ditto.
3248 * platform/mac/WebCoreSystemInterface.mm: Ditto.
3250 * rendering/RenderThemeMac.mm:
3251 (WebCore::mediaControllerTheme): Use wkMediaControllerThemeAvailable instead of the
3252 QuickTime version to see if it is possible to use MediaControllerThemeQuickTime.
3254 2009-11-14 Kent Tamura <tkent@chromium.org>
3256 Reviewed by Darin Adler.
3258 - Recognizes date/datetime/datetime-local/month/time/week types of INPUT element.
3259 They have no dedicated UI and no type validation for now.
3260 - Clean up setInputType() and formControlType() of HTMLInputElement.
3261 https://bugs.webkit.org/show_bug.cgi?id=29004
3263 Test: fast/forms/input-type-change3.html
3265 * html/HTMLInputElement.cpp:
3266 (WebCore::HTMLInputElement::valueMissing):
3267 (WebCore::HTMLInputElement::patternMismatch):
3268 (WebCore::HTMLInputElement::tooLong):
3269 (WebCore::createTypeMap):
3270 (WebCore::HTMLInputElement::setInputType):
3271 (WebCore::createFormControlTypes):
3272 (WebCore::HTMLInputElement::formControlType):
3273 (WebCore::HTMLInputElement::saveFormControlState):
3274 (WebCore::HTMLInputElement::restoreFormControlState):
3275 (WebCore::HTMLInputElement::accessKeyAction):
3276 (WebCore::HTMLInputElement::rendererIsNeeded):
3277 (WebCore::HTMLInputElement::createRenderer):
3278 (WebCore::HTMLInputElement::appendFormData):
3279 (WebCore::HTMLInputElement::isTextField):
3280 (WebCore::HTMLInputElement::valueWithDefault):
3281 (WebCore::HTMLInputElement::storesValueSeparateFromAttribute):
3282 (WebCore::HTMLInputElement::defaultEventHandler):
3283 (WebCore::HTMLInputElement::isRequiredFormControl):
3284 (WebCore::HTMLInputElement::dataList):
3285 * html/HTMLInputElement.h:
3286 (WebCore::HTMLInputElement::):
3288 2009-11-13 Chris Fleizach <cfleizach@apple.com>
3290 Reviewed by Darin Adler.
3292 WAI-ARIA: checkbox does not determine its label from text content
3293 https://bugs.webkit.org/show_bug.cgi?id=31456
3295 Test: accessibility/aria-checkbox-text.html
3297 * accessibility/AccessibilityRenderObject.cpp:
3298 (WebCore::AccessibilityRenderObject::title):
3300 2009-11-13 Dimitri Glazkov <dglazkov@chromium.org>
3302 Unreviewed, build fix.
3304 [Chromium] Fix build to catch up with http://trac.webkit.org/changeset/50973.
3305 This is just enough changes to unbreak the port.
3307 * bindings/v8/ScriptController.cpp:
3308 (WebCore::mainThreadNormalWorld):
3309 * bindings/v8/V8Proxy.cpp:
3310 (WebCore::V8Proxy::initContextIfNeeded):
3311 * loader/FrameLoaderClient.h:
3313 2009-11-13 Aaron Boodman <aa@chromium.org>
3315 Unreviewed fix for Chromium build.
3317 * loader/FrameLoaderClient.h:
3318 (WebCore::FrameLoaderClient::dispatchDidClearWindowObjectInWorld):
3319 Provide an empty implementation of this method because I don't know
3320 what it is supposed to do on Chromium.
3322 2009-11-13 Aaron Boodman <aa@chromium.org>
3324 Unreviewed fix for Chromium build.
3326 * loader/FrameLoader.h: Make dispatchDidClearWindowObjectsInAllWorlds()
3327 public, as Chromium's V8Proxy calls it.
3329 2009-11-13 Aaron Boodman <aa@chromium.org>
3331 Unreviewed fix to Chromium build.
3333 * bindings/v8/ScriptController.cpp:
3334 (WebCore::ScriptController::getAllWorlds):
3336 2009-11-13 Aaron Boodman <aa@chromium.org>
3338 Unreviewed fix for Chromium build.
3340 * platform/text/TextBoundaries.cpp: Use longer path to refer to Unicode.h.
3342 2009-11-13 Adam Barth <abarth@webkit.org>
3344 Unreviewed partial build fix for Chromium. Should fix failure #4.
3346 * bindings/v8/ScriptController.cpp:
3347 (WebCore::ScriptController::getAllWorlds):
3348 * bindings/v8/ScriptController.h:
3349 * bindings/v8/V8Proxy.cpp:
3350 (WebCore::V8Proxy::initContextIfNeeded):
3352 2009-11-13 Adam Barth <abarth@webkit.org>
3354 Unreviewed partial build fix for Chromium.
3356 * bindings/v8/ScriptController.h:
3357 (WebCore::ScriptController::getAllWorlds):
3359 2009-11-13 Eric Seidel <eric@webkit.org>
3361 No review, build fix only.
3363 Fix Windows and Chromium builds after http://trac.webkit.org/changeset/50977.
3365 Unify TextBoundaries implementations by only relying on WTF Unicode abstractions
3366 https://bugs.webkit.org/show_bug.cgi?id=31468
3368 * WebCore.gypi: Rename TextBoundariesICU -> TextBoundaries
3369 * WebCore.vcproj/WebCore.vcproj: Rename TextBoundariesICU -> TextBoundaries
3371 2009-11-12 Jeremy Orlow <jorlow@chromium.org>
3373 Reviewed by Dmitry Titov.
3375 LocalStorage quota should include key sizes in its count
3376 https://bugs.webkit.org/show_bug.cgi?id=31451
3378 * storage/StorageMap.cpp:
3379 (WebCore::StorageMap::setItem):
3380 Count keys in the quota when adding a new item.
3381 (WebCore::StorageMap::removeItem):
3382 Remove the key's length from the quota if we're removing the item.
3383 (WebCore::StorageMap::importItem):
3384 Assume that we're adding things for the first time.
3385 Count keys in the quota.
3387 2009-11-13 Dominik Röttsches <dominik.roettsches@access-company.com>
3389 Reviewed by Eric Seidel.
3391 Unify TextBoundaries implementations by only relying on WTF Unicode abstractions
3392 https://bugs.webkit.org/show_bug.cgi?id=31468
3394 Moving TextBoundariesICU.cpp to TextBoundaries.cpp
3395 by removing the direct ICU dependency and replacing it
3396 with WTF functions and WebCore's own TextBreakIterator
3400 * platform/graphics/gtk/SimpleFontDataGtk.cpp:
3401 * platform/text/TextBoundaries.cpp: Added.
3402 (WebCore::findNextWordFromIndex):
3403 (WebCore::findWordBoundary):
3404 * platform/text/TextBoundariesICU.cpp: Removed.
3405 * platform/text/TextBreakIterator.h:
3406 * platform/text/TextBreakIteratorICU.cpp:
3407 (WebCore::textBreakLast):
3408 (WebCore::textBreakPrevious):
3410 2009-11-13 Shinichiro Hamaji <hamaji@chromium.org>
3412 Reviewed by Darin Adler.
3414 WebCore::externalRepresentation should update layout before getting render object
3415 https://bugs.webkit.org/show_bug.cgi?id=31459
3417 * rendering/RenderTreeAsText.cpp:
3418 (WebCore::externalRepresentation):
3420 2009-11-13 Adam Roben <aroben@apple.com>
3422 Tell FrameLoaderClient when window objects in isolated worlds are
3425 Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
3426 window objects in isolated worlds are cleared
3428 Test: http/tests/security/isolatedWorld/didClearWindowObject.html
3430 Reviewed by Dave Hyatt.
3432 * bindings/js/JSDOMBinding.h:
3433 (WebCore::WebCoreJSClientData::getAllWorlds): Added. Copies all the
3434 worlds in m_worldSet to the passed-in Vector.
3436 * bindings/js/ScriptController.cpp:
3437 (WebCore::ScriptController::getAllWorlds): Added. Calls through to
3438 WebCoreJSClientData.
3439 (WebCore::ScriptController::initScript): Changed to call
3440 FrameLoader::dispatchDidClearWindowObjectInWorld.
3442 * bindings/js/ScriptController.h: Added getAllWorlds.
3444 * loader/EmptyClients.h:
3445 (WebCore::EmptyFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
3446 Updated for FrameLoaderClient change.
3448 * loader/FrameLoader.cpp:
3449 (WebCore::FrameLoader::receivedFirstData):
3450 (WebCore::FrameLoader::begin):
3451 Changed to call dispatchDidClearWindowObjectsInAllWorlds.
3453 (WebCore::FrameLoader::dispatchDidClearWindowObjectsInAllWorlds):
3454 Added. Retrieves all the worlds, then calls through to
3455 dispatchDidClearWindowObjectInWorld for each one.
3456 (WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld): Replaces
3457 dispatchWindowObjectAvailable. Calls up to the client, then, if the
3458 world is the mainThreadNormalWorld(), tells the Inspector about it,
3461 * loader/FrameLoader.h: Replaced dispatchWindowObjectAvailable with
3462 dispatchDidClearWindowObjectInWorld. Added
3463 dispatchDidClearWindowObjectsInAllWorlds.
3465 * loader/FrameLoaderClient.h: Replaced windowObjectCleared with
3466 dispatchDidClearWindowObjectForWorld.
3468 2009-11-13 Vitaly Repeshko <vitalyr@chromium.org>
3470 Reviewed by Dimitri Glazkov.
3472 [V8] Fix SVG context assignment for pod types.
3473 https://bugs.webkit.org/show_bug.cgi?id=31497
3475 I broke this in r50958.
3477 Tested by svg/custom/viewport-update2.svg.
3479 * bindings/scripts/CodeGeneratorV8.pm:
3481 2009-11-13 Andrei Popescu <andreip@google.com>
3483 Reviewed by Dmitry Titov.
3485 Bring the platform/android files inline with Android 2.0
3486 https://bugs.webkit.org/show_bug.cgi?id=31423
3488 No new tests required: these are all Android-specific files.
3490 * platform/android/ClipboardAndroid.cpp:
3491 (WebCore::ClipboardAndroid::files):
3492 * platform/android/ClipboardAndroid.h:
3493 * platform/android/FileChooserAndroid.cpp:
3494 (WebCore::FileChooser::basenameForWidth):
3495 (WebCore::fileButtonChooseFileLabel):
3496 * platform/android/KeyEventAndroid.cpp:
3497 (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
3498 * platform/android/LocalizedStringsAndroid.cpp:
3499 (WebCore::contextMenuItemTagOpenLinkInNewWindow):
3500 (WebCore::contextMenuItemTagDownloadLinkToDisk):
3501 (WebCore::contextMenuItemTagCopyLinkToClipboard):
3502 (WebCore::contextMenuItemTagOpenImageInNewWindow):
3503 (WebCore::contextMenuItemTagDownloadImageToDisk):
3504 (WebCore::contextMenuItemTagCopyImageToClipboard):
3505 (WebCore::contextMenuItemTagOpenFrameInNewWindow):
3506 (WebCore::contextMenuItemTagCopy):
3507 (WebCore::contextMenuItemTagGoBack):
3508 (WebCore::contextMenuItemTagGoForward):
3509 (WebCore::contextMenuItemTagStop):
3510 (WebCore::contextMenuItemTagReload):
3511 (WebCore::contextMenuItemTagCut):
3512 (WebCore::contextMenuItemTagPaste):
3513 (WebCore::contextMenuItemTagNoGuessesFound):
3514 (WebCore::contextMenuItemTagIgnoreSpelling):
3515 (WebCore::contextMenuItemTagLearnSpelling):
3516 (WebCore::contextMenuItemTagSearchWeb):
3517 (WebCore::contextMenuItemTagLookUpInDictionary):
3518 (WebCore::contextMenuItemTagOpenLink):
3519 (WebCore::contextMenuItemTagIgnoreGrammar):
3520 (WebCore::contextMenuItemTagSpellingMenu):
3521 (WebCore::contextMenuItemTagShowSpellingPanel):
3522 (WebCore::contextMenuItemTagCheckSpelling):
3523 (WebCore::contextMenuItemTagCheckSpellingWhileTyping):
3524 (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
3525 (WebCore::contextMenuItemTagFontMenu):
3526 (WebCore::contextMenuItemTagBold):
3527 (WebCore::contextMenuItemTagItalic):
3528 (WebCore::contextMenuItemTagUnderline):
3529 (WebCore::contextMenuItemTagOutline):
3530 (WebCore::contextMenuItemTagWritingDirectionMenu):
3531 (WebCore::contextMenuItemTagTextDirectionMenu):
3532 (WebCore::contextMenuItemTagDefaultDirection):
3533 (WebCore::contextMenuItemTagLeftToRight):
3534 (WebCore::contextMenuItemTagRightToLeft):
3535 (WebCore::mediaElementLoadingStateText):
3536 (WebCore::mediaElementLiveBroadcastStateText):
3537 (WebCore::searchableIndexIntroduction):
3538 (WebCore::resetButtonDefaultLabel):
3539 (WebCore::submitButtonDefaultLabel):
3540 (WebCore::inputElementAltText):
3541 * platform/android/RenderThemeAndroid.cpp:
3542 (WebCore::RenderTheme::themeForPage):
3543 (WebCore::RenderThemeAndroid::baselinePosition):
3544 (WebCore::RenderThemeAndroid::paintButton):
3545 (WebCore::adjustMenuListStyleCommon):
3546 (WebCore::RenderThemeAndroid::paintCombo):
3547 * platform/android/ScreenAndroid.cpp:
3548 * platform/android/ScrollViewAndroid.cpp:
3549 (WebCore::ScrollView::platformOffscreenContentRectangle):
3550 * platform/android/TemporaryLinkStubs.cpp:
3551 (JSC::Bindings::dispatchJNICall):
3552 * platform/android/WidgetAndroid.cpp:
3553 (WebCore::Widget::setFrameRect):
3555 2009-11-13 Norbert Leser <norbert.leser&nokia.com>
3557 Reviewed by Eric Seidel.
3559 Added macros for USERINCLUDE paths within symbian blocks
3560 to guarantee inclusion of respective header files from local path
3561 first (to avoid clashes with same names of header files in system include path).
3565 2009-11-13 Hironori Bono <hbono@chromium.org>
3567 Reviewed by Oliver Hunt.
3569 Implement composition events introduced in DOM Level 3.
3570 This change adds a new IDL which defines the composition events, adds a class which
3571 implements the composition events, and sends the composition events according to
3573 https://bugs.webkit.org/show_bug.cgi?id=26310
3575 Test: fast/events/ime-composition-events-001.html
3577 * DerivedSources.make: Added CompositionEvent so we can compile "CompositionEvent.idl".
3578 * GNUmakefile.am: Added "CompositionEvent.{cpp,h,idl}".
3579 * WebCore.gypi: ditto.
3580 * WebCore.pro: ditto
3581 * WebCore.vcproj/WebCore.vcproj: ditto.
3582 * WebCore.xcodeproj/project.pbxproj: Added "CompositionEvent.{cpp,h,idl}" and "JSCompositionEvent.{cpp,h}".
3583 * WebCoreSources.bkl: Added "JSCompositionEvent.{cpp,h}".
3584 * bindings/js/JSEventCustom.cpp: