Don't skip websocket/tests/url-with-credential.html, it's one of earlier...
[WebKit-https.git] / WebCore / ChangeLog
1 2009-12-07  Dan Bernstein  <mitz@apple.com>
2
3         Reviewed by Darin Adler.
4
5         Fixed <rdar://problem/7437820> Weird selection artifacts
6
7         Tests: fast/repaint/block-selection-gap-stale-cache-2.html
8                fast/repaint/block-selection-gap-stale-cache.html
9
10         Instead of caching the block selection gaps’ bounds in the RenderView at setSelection()
11         time, cache them in each RenderLayer at paint time. This prevents the cache from getting
12         stale due to layout changes and overflow scrolling.
13
14         * rendering/RenderBlock.cpp:
15         (WebCore::RenderBlock::selectionGapRectsForRepaint): Account for overflow scroll.
16         (WebCore::RenderBlock::paintSelection): Update the enclosing layer’s selection gaps bounds.
17         * rendering/RenderLayer.cpp:
18         (WebCore::RenderLayer::addBlockSelectionGapsBounds): Added. Updates the selection gaps
19         bounds to include the given rect.
20         (WebCore::RenderLayer::clearBlockSelectionGapsBounds): Added. Recursively clears the cached
21         selection gaps bounds.
22         (WebCore::RenderLayer::repaintBlockSelectionGaps): Added. Recursively invalidates the
23         selection gaps bounds.
24         * rendering/RenderLayer.h:
25         * rendering/RenderView.cpp:
26         (WebCore::RenderView::setSelection): Clear the layer-level selection gaps bounds instead
27         of the view-level cache.
28         (WebCore::RenderView::clearSelection): Changed to call repaintBlockSelectionGaps().
29         * rendering/RenderView.h:
30
31 2009-12-07  Philippe Normand  <pnormand@igalia.com>
32
33         Reviewed by Gustavo Noronha.
34
35         Fixed whitelist comment and removed useless (tags, sdp) mimetypes
36         from it. Also, GStreamer doesn't handle directly SMIL.
37
38         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
39         (WebCore::mimeTypeCache):
40
41 2009-12-07  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
42
43         Reviewed by Xan Lopez.
44
45         https://bugs.webkit.org/show_bug.cgi?id=25415
46         [GTK][ATK] Please implement support for get_text_at_offset
47
48         Eliminate the segfaults which occur when accessing the text interface now
49         implemented by text controls.
50
51         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
52         (getPangoLayoutForAtk):
53
54 2009-12-07  Gustavo Noronha Silva  <gns@gnome.org>
55
56         Reviewed by Xan Lopez.
57
58         Turn the MediaPlayer supported types blacklist into a whitelist
59
60         [GTK] REGRESSION: webkit thinks it can render PDFs
61         https://bugs.webkit.org/show_bug.cgi?id=32183
62
63         Covered by API test.
64
65         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
66         (WebCore::mimeTypeCache):
67
68 2009-12-07  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
69
70         Reviewed by Xan Lopez.
71
72         https://bugs.webkit.org/show_bug.cgi?id=25524
73         [Gtk] Expose the title attribute to assistive technologies
74
75         Expose 'alt' attribute from images as accessible name.
76         Expose the 'title' core HTML attribute as accessible description.
77         This is a modified version of the original fix submitted by Mario Sanchez Prada,
78         adjusted so that it doesn't impact other platforms.
79
80         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
81         (webkit_accessible_get_name):
82         (webkit_accessible_get_description):
83
84 2009-12-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
85
86         Reviewed by Simon Hausmann.
87
88         [Qt] Fix support for generic font families
89
90         By not propagating the resolved font family in FontCacheQt and
91         only concidering the font description we ended up passing the
92         generic font families to Qt directly. Since most systems don't
93         have a mapping for these font families we ended up using the
94         default font in most cases.
95
96         * platform/graphics/qt/FontCacheQt.cpp:
97         * platform/graphics/qt/FontPlatformData.h:
98         * platform/graphics/qt/FontPlatformDataQt.cpp:
99
100 2009-12-06  Oliver Hunt  <oliver@apple.com>
101
102         Reviewed by Maciej Stachowiak.
103
104         Object.getOwnPropertyDescriptor() allows cross-frame access
105         https://bugs.webkit.org/show_bug.cgi?id=32119
106
107         Make all implementations of getOwnPropertyDescriptor that have
108         cross domain restrictions simply fail immediately on cross domain
109         access, rather than trying to mimic the behaviour of normal
110         property access.
111
112         Test: http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html
113
114         * bindings/js/JSDOMWindowCustom.cpp:
115         (WebCore::JSDOMWindow::getOwnPropertyDescriptor):
116         * bindings/js/JSHistoryCustom.cpp:
117         (WebCore::JSHistory::getOwnPropertyDescriptorDelegate):
118         * bindings/js/JSLocationCustom.cpp:
119         (WebCore::JSLocation::getOwnPropertyDescriptorDelegate):
120         * bindings/scripts/CodeGeneratorJS.pm:
121
122 2009-12-07  Steve Block  <steveblock@google.com>
123
124         Reviewed by Adam Barth.
125
126         Moves JSC-specific functions from jni_utility and moves them to new jsc/jni_utility_private files.
127         https://bugs.webkit.org/show_bug.cgi?id=32157
128
129         Build fix only, no new tests.
130
131         * WebCore.xcodeproj/project.pbxproj: Modified. Add jni_utility_private.[cpp|h].
132         * bridge/jni/jni_instance.cpp: Modified. Include jni_utility_private.h for JSC.
133         * bridge/jni/jni_jsobject.mm: Modified. Include jni_utility_private.h for JSC.
134         * bridge/jni/jni_objc.mm: Modified. Include jni_utility_private.h for JSC.
135         * bridge/jni/jni_runtime.cpp: Modified. Include jni_utility_private.h for JSC.
136         * bridge/jni/jni_utility.cpp: Modified. Removed convertValueToJValue and convertArrayInstanceToJavaArray.
137         * bridge/jni/jni_utility.h: Modified. Removed convertValueToJValue and dispatchJNICall.
138         * bridge/jni/jsc: Added.
139         * bridge/jni/jsc/jni_utility_private.cpp: Added.
140         (JSC::Bindings::convertArrayInstanceToJavaArray):
141         (JSC::Bindings::convertValueToJValue):
142         * bridge/jni/jsc/jni_utility_private.h: Added. Header for convertValueToJValue and dispatchJNICall.
143         * platform/android/TemporaryLinkStubs.cpp: Modified. Include jni_utility_private.h for JSC.
144
145 2009-12-06  Oliver Hunt  <oliver@apple.com>
146
147         Reviewed by Maciej Stachowiak.
148
149         texImage2D pixel junk for transparency
150         https://bugs.webkit.org/show_bug.cgi?id=32188
151
152         Use kCGBlendModeCopy when drawing an image to the intermediate context
153         used to create a GL texture.
154
155         No test as we don't currently have any mechanism to retrieve pixel data
156         from the webgl context.
157
158         * platform/graphics/mac/GraphicsContext3DMac.cpp:
159         (WebCore::imageToTexture):
160
161 2009-12-03  Philippe Normand  <pnormand@igalia.com>
162
163         Reviewed by Gustavo Noronha.
164
165         Advertize audio/ogg correctly and refactored mime-type cache
166         building.
167
168         [GTK] Recognize oga as audio/ogg
169         https://bugs.webkit.org/show_bug.cgi?id=31990
170
171         Test: media/media-can-play-ogg.html
172
173         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
174         (WebCore::mimeTypeCache):
175
176 2009-12-05  Alexey Proskuryakov  <ap@apple.com>
177
178         Reviewed by Eric Seidel.
179
180         https://bugs.webkit.org/show_bug.cgi?id=32175
181         REGRESSION: websocket/tests/url-parsing.html is crashing on Leopard Bot
182
183         * platform/network/cf/SocketStreamHandleCFNet.cpp:
184         (WebCore::SocketStreamHandle::readStreamCallback): Call platformClose() to unschedule both
185         streams, guaranteeing that there will be no callbacks after SocketStreamHandle is destroyed.
186         (WebCore::SocketStreamHandle::writeStreamCallback): Edited a comment a bit.
187
188 2009-12-05  Adam Langley  <agl@google.com>
189
190         Reviewed by Adam Barth.
191
192         Check that a CSS format() argument is of a valid type.
193
194         https://bugs.webkit.org/show_bug.cgi?id=31815
195         http://code.google.com/p/chromium/issues/detail?id=28582
196
197         Test: fast/css/url-format-non-string.html
198
199         * css/CSSParser.cpp:
200         (WebCore::CSSParser::parseFontFaceSrc):
201
202 2009-12-04  Adam Langley  <agl@google.com>
203
204         Reviewed by Eric Seidel.
205
206         Chromium: make rounded borders heavier.
207
208         Skia draws its rounded corners differently from the other ports.
209         Whereas they have anti-aliased clipping regions, Skia only has 1-bit
210         regions. (Which is technically more correct, but somewhat unhelpful
211         for us.) Instead, with Skia we use a layer and collect all the
212         clipping paths in effect. When the state is popped, we paint
213         transparency outside the clipping paths and merge the layer down.
214
215         This appears to cause rounded borders to look a little thin, which is
216         addressed in this patch.
217
218         This is well covered by existing tests but will require new baselines
219         in the Chromium tree.
220
221         https://bugs.webkit.org/show_bug.cgi?id=31778
222
223         * platform/graphics/skia/GraphicsContextSkia.cpp:
224         (WebCore::GraphicsContext::addInnerRoundedRectClip):
225
226 2009-12-04  Simon Fraser  <simon.fraser@apple.com>
227
228         Reviewed by Dan Bernstein.
229
230         <rdar://problem/7441571> Hardware-backed layers are skipped when printing
231         
232         When printing, set the PaintBehaviorFlattenCompositingLayers flag so that compositing layers
233         paint. This also causes 3D transforms to be flattened to 2D.
234
235         Test: printing/compositing-layer-printing.html
236
237         * page/FrameView.cpp:
238         (WebCore::FrameView::paintContents):
239
240 2009-12-04  Oliver Hunt  <oliver@apple.com>
241
242         Reviewed by Beth Dakin.
243
244         Fix up some issues in my SVGListTraits change from yesterday.
245
246         * svg/SVGListTraits.h:
247         (WebCore::):
248
249 2009-12-04  Albert J. Wong  <ajwong@chromium.org>
250
251         Not reviewed: chromium build fix.
252
253         Fix Chromium build break caused by moving of isDefaultPortForProtocol() and
254         portAllowed() into KURL.h/KURL.cpp.  Cloning code.
255
256         * platform/KURLGoogle.cpp:
257         (WebCore::isDefaultPortForProtocol):
258         (WebCore::portAllowed):
259
260 2009-12-04  Pavel Feldman  <pfeldman@chromium.org>
261
262         Reviewed by Timothy Hatcher.
263
264         Web Inspector: Remove suppress highlight when restoring selected node.
265
266         https://bugs.webkit.org/show_bug.cgi?id=32152
267
268         * inspector/front-end/ElementsPanel.js:
269         (WebInspector.ElementsPanel.prototype.setDocument.selectNode):
270         (WebInspector.ElementsPanel.prototype.setDocument.selectLastSelectedNode):
271         (WebInspector.ElementsPanel.prototype.setDocument):
272
273 2009-12-04  Dirk Schulze  <krit@webkit.org>
274
275         Reviewed by Nikolas Zimmermann.
276
277         Gradient SVG animation demonstrates tearing at animation extremes
278         https://bugs.webkit.org/show_bug.cgi?id=11929
279
280         The focalPoint of a radial gradient is temporarly substracted by
281         the centralPoint, if the focalPoint is not in the radius of the
282         gradient. This is needed to calculate a new postion of the focalPoint
283         according to the specification. But the new focalPoint needs to be
284         moved by the centralPoint after this calculation, which is not the case
285         at the moment. This patch fixes this issue. It was also introduced a
286         deviation of maximal 0.2% for Cairo to get around the fixed point numbers
287         in Cairo.
288
289         W3C-SVG-1.1/pservers-grad-13-b needed an update. The missing adjustment
290         of the new focalPoint caused wrong results for the last three tests.
291
292         Test: svg/custom/radial-gradient-with-outstanding-focalPoint.svg
293
294         * svg/SVGRadialGradientElement.cpp:
295         (WebCore::SVGRadialGradientElement::buildGradient):
296
297 2009-12-04  Anton Muhin  <antonm@chromium.org>
298
299         Reviewed by Dmitry Titov.
300
301         Do not use WebCore::String::String(const UChar*, int length) to convert
302         short v8 strings.
303
304         Plus added string traits.
305         https://bugs.webkit.org/show_bug.cgi?id=31415
306
307         * bindings/v8/V8Binding.cpp:
308         (WebCore::):
309         (WebCore::v8StringToWebCoreString):
310
311 2009-12-04  Chris Fleizach  <cfleizach@apple.com>
312
313         Reviewed by Darin Adler.
314
315         REGRESSION: AX: buttons now extremely repetitive
316         https://bugs.webkit.org/show_bug.cgi?id=32164
317
318         Test: platform/mac/accessibility/button-shouldnot-have-axvalue.html
319
320         * accessibility/AccessibilityObject.h:
321         (WebCore::AccessibilityObject::isButton):
322         * accessibility/mac/AccessibilityObjectWrapper.mm:
323         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
324
325 2009-12-04  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
326
327         Reviewed by Darin Adler.
328
329         Check whether the right side of a string append is non-empty
330         https://bugs.webkit.org/show_bug.cgi?id=32151
331
332         Especially beneficial for CachedScript::script() method
333         which usually appends an empty string returned by flush()
334         to its m_script member. m_script is often hundreds of kbytes
335         which is duplated without reason.
336
337         * platform/text/String.cpp:
338         (WebCore::String::append):
339
340 2009-12-04  Enrica Casucci  <enrica@apple.com>
341
342         Reviewed by John Sullivan.
343
344         Mail.app crashes when indenting table pasted from Numbers.app.
345         <rdar://problem/7209507>
346         https://bugs.webkit.org/show_bug.cgi?id=32166
347
348         Test: LayoutTests/editing/execCommand/indent-partial-table.html
349         
350         * editing/IndentOutdentCommand.cpp:
351         (WebCore::IndentOutdentCommand::indentRegion): Added test to verify that the end of the paragraph
352         after the selection has not been moved.
353
354 2009-12-04  Alexey Proskuryakov  <ap@apple.com>
355
356         Reviewed by Darin Adler.
357
358         https://bugs.webkit.org/show_bug.cgi?id=32085
359         WebSocket should block the same ports that are blocked for resource loading
360
361         Test: websocket/tests/url-parsing.html
362
363         * page/SecurityOrigin.cpp:
364         (WebCore::SecurityOrigin::SecurityOrigin):
365         (WebCore::SecurityOrigin::localURLSchemes):
366         * page/SecurityOrigin.h:
367         Move isDefaultPortForProtocol() to KURL, because that's a better place for it (SecurityOrigin
368         is not even in WebCore/platform directory).
369
370         * html/HTMLAnchorElement.cpp:
371         (WebCore::HTMLAnchorElement::host):
372         (WebCore::HTMLAnchorElement::setHost):
373         (WebCore::HTMLAnchorElement::setPort):
374         Updated for the new location of isDefaultPortForProtocol().
375
376         * platform/KURL.cpp:
377         (WebCore::KURL::protocolIs): In an assertion, compare to "javascript" case-insensitively,
378         since the function doesn't require lower case input.
379         (WebCore::isDefaultPortForProtocol): Moved from SecurityOrigin.
380         (WebCore::portAllowed): Moved from ResourceHandle.
381         * platform/KURL.h:
382
383         * platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::create): Updated for the
384         new location of portAllowed().
385
386         * websockets/WebSocket.cpp: (WebCore::WebSocket::connect): Per the spec, raise a SECURITY_ERR
387         if trying to connect to a blocked port.
388
389 2009-12-04  Benjamin Poulain  <benjamin.poulain@nokia.com>
390
391         Reviewed by Kenneth Rohde Christiansen.
392
393         [Qt] WebKit crashes when loading certain SVG images
394         https://bugs.webkit.org/show_bug.cgi?id=29443
395
396         Remove FontFallbackListQt and rely on the common FontFallbackList
397         to handle the fonts. FontCache and FontPlatformData have been
398         updated to work with the common FontFallbackList.
399
400         In the previous implementation, FontPlatformDataCacheKey
401         was a clone of FontPlatformData with the hashing
402         capabilities added in order to use it as a key in the cache's
403         hashmap. FontPlatformData has been modified to handle the hashing
404         function directly so the data are not copied twice in memory.
405
406         FontFallbackList::fontDataAt() from FontFallbackListQt was a copy of
407         code from FontCache::getFontData() and FontFallbackList::fontDataAt().
408         The behavior is similar except currFamily->family().length() was
409         not tested and the fallback fonts selector were not used.
410
411         Existing tests cover the change.
412
413         * WebCore.pro:
414         * platform/graphics/qt/FontCacheQt.cpp:
415         (WebCore::FontCache::platformInit):
416         (WebCore::FontCache::getFontDataForCharacters):
417         (WebCore::FontCache::getSimilarFontPlatformData):
418         (WebCore::FontCache::getLastResortFallbackFont):
419         (WebCore::FontCache::getTraitsInFamily):
420         (WebCore::FontCache::createFontPlatformData):
421         * platform/graphics/qt/FontCustomPlatformData.cpp:
422         (WebCore::FontCustomPlatformData::fontPlatformData):
423         * platform/graphics/qt/FontFallbackListQt.cpp:
424         Removed. We now use the implementation from FontFallbackList.cpp
425         * platform/graphics/qt/FontPlatformData.h:
426         Add hashing capabilities to be able to use the data with the FontCache.
427         This was previously done in FontCacheQt.cpp
428         (WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate):
429         (WebCore::FontPlatformData::FontPlatformData):
430         (WebCore::FontPlatformData::isHashTableDeletedValue):
431         (WebCore::FontPlatformData::font):
432         (WebCore::FontPlatformData::size):
433         (WebCore::FontPlatformData::family):
434         (WebCore::FontPlatformData::bold):
435         (WebCore::FontPlatformData::italic):
436         (WebCore::FontPlatformData::smallCaps):
437         (WebCore::FontPlatformData::pixelSize):
438         * platform/graphics/qt/FontPlatformDataQt.cpp:
439         (WebCore::FontPlatformData::FontPlatformData):
440         (WebCore::FontPlatformData::~FontPlatformData):
441         (WebCore::FontPlatformData::operator=):
442         (WebCore::FontPlatformData::operator==):
443         (WebCore::FontPlatformData::hash):
444
445 2009-12-04  Adam Treat  <atreat@rim.com>
446
447         Reviewed by Dan Bernstein.
448
449         Fix wrong assert that was only working through sheer luck.
450         https://bugs.webkit.org/show_bug.cgi?id=32162
451
452         * platform/text/BidiContext.cpp:
453         (WebCore::BidiContext::create):
454
455 2009-12-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
456
457         Reviewed by Simon Hausmann.
458
459         [Qt] Allow removing 'qrc' as a local security origin scheme
460
461         * page/SecurityOrigin.cpp:
462
463 2009-12-04  Zoltan Horvath  <zoltan@webkit.org>
464
465         Reviewed by Eric Seidel.
466
467         Allow custom memory allocation control for WebCore's CollectionCache
468         https://bugs.webkit.org/show_bug.cgi?id=32109
469
470         Inherits the following class from FastAllocBase because it is
471         instantiated by 'new':
472
473         struct name            - instantiated at: WebCore/'location'
474
475         struct CollectionCache - dom/Document.cpp:4029
476
477         * html/CollectionCache.h:
478
479 2009-12-04  Steve Block  <steveblock@google.com>
480
481         Reviewed by Darin Adler.
482
483         Fixes a crashing bug in Geolocation when a watch is cleared from some callbacks. 
484         https://bugs.webkit.org/show_bug.cgi?id=32111
485
486         In Geolocation::GeoNotifier::timerFired, a JS callback may be invoked if a
487         fatal error was registered on this GeoNotifier or if this request has timed
488         out. If the request is a watch, and is cleared by a call to clearWatch in the
489         callback, the GeoNotifier object will be destroyed. We must therefore cache the
490         m_geolocation member to allow us to call Geolocation::fatalErrorOccurred or
491         Geolocation::requestTimedOut.
492
493         Tests: fast/dom/Geolocation/permission-denied-already-clear-watch.html
494                fast/dom/Geolocation/timeout-clear-watch.html
495
496         * page/Geolocation.cpp: Modified.
497         (WebCore::Geolocation::GeoNotifier::timerFired): Modified. Cache the m_geolocation member before invoking the JS callback.
498
499 2009-12-04  Zoltan Horvath  <zoltan@webkit.org>
500
501         Reviewed by Eric Seidel.
502
503         Allow custom memory allocation control for 2 classes of the platform directory in WebCore
504         https://bugs.webkit.org/show_bug.cgi?id=
505
506         Inherits the following class from Noncopyable because it is instantiated
507         by 'new' and no need to be copyable:
508
509         class/struct name         - instantiated at: WebCore/'location'
510
511         class SharedTimer         - (its child class) workers/WorkerRunLoop.cpp:91
512
513         Inherits the following class from FastAllocBase because it is
514         instantiated by 'new':
515
516         class TransformOperations - rendering/style/RenderStyle.h:1175
517
518         Noncopyable.h's include added to SharedTimer.h.
519
520         * platform/SharedTimer.h:
521         * platform/graphics/transforms/TransformOperations.h:
522
523 2009-12-04  Xan Lopez  <xlopez@igalia.com>
524
525         Reviewed by Gustavo Noronha.
526
527         [GTK]Enable DNS prefetching
528         https://bugs.webkit.org/show_bug.cgi?id=23846
529
530         Enable DNS prefetching.
531
532         Based on a patch by José Millán.
533
534         * platform/network/soup/DNSSoup.cpp:
535         (WebCore::prefetchDNS):
536
537 2009-12-04  Zoltan Horvath  <zoltan@webkit.org>
538
539         Reviewed by Eric Seidel.
540
541         Allow custom memory allocation control for the svg directory in WebCore
542         https://bugs.webkit.org/show_bug.cgi?id=
543
544         Inherits the following classes from Noncopyable because these are instantiated
545         by 'new' and no need to be copyable:
546
547         class/struct name           - instantiated at: WebCore/'location'
548
549         struct ResourceSet          - svg/graphics/SVGResource.cpp:148
550         class SVGFontData           - css/CSSFontFaceSource.cpp:156
551         class SVGDocumentExtensions - dom/Document.cpp:3962
552         class SVGViewSpec           - svg/SVGSVGElement.cpp:191
553
554         * svg/SVGDocumentExtensions.h:
555         * svg/SVGFontData.h:
556         * svg/SVGViewSpec.h:
557         * svg/graphics/SVGResource.cpp:
558
559 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
560
561         Reviewed by Beth Dakin.
562
563         WAI-ARIA: aria-activedescendant doesn't work as intended
564         https://bugs.webkit.org/show_bug.cgi?id=32100
565
566         Fixes a number of issues regarding the "tree" role and aria-activedescendant.
567         1. The indexes were being reported incorrectly by treeitems.
568         2. aria-activedescendant changes were not being sent to the containing item.
569         3. The tree's selected rows need to consult aria-activedescendant.
570         4. Since a tree changes what it returns as its children (it returns its rows)
571            the mac-specific array indexing methods need to correctly handle the tree case.
572
573         Tests: platform/mac/accessibility/aria-tree-activedescendant.html
574                platform/mac/accessibility/aria-tree-index-of-items.html
575
576         * accessibility/AXObjectCache.h:
577         (WebCore::AXObjectCache::):
578         * accessibility/AccessibilityRenderObject.cpp:
579         (WebCore::AccessibilityRenderObject::shouldFocusActiveDescendant):
580         (WebCore::AccessibilityRenderObject::activeDescendant):
581         (WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
582         (WebCore::AccessibilityRenderObject::ariaTreeSelectedRows):
583         * accessibility/mac/AXObjectCacheMac.mm:
584         (WebCore::AXObjectCache::postPlatformNotification):
585         * accessibility/mac/AccessibilityObjectWrapper.mm:
586         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
587         (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
588         (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
589         * accessibility/win/AXObjectCacheWin.cpp:
590         (WebCore::AXObjectCache::postPlatformNotification):
591
592 2009-12-03  Zoltan Horvath  <zoltan@webkit.org>
593
594         Reviewed by Eric Seidel.
595
596         Allow custom memory allocation control for the xml directory in WebCore
597         https://bugs.webkit.org/show_bug.cgi?id=
598
599         Inherits the following class from Noncopyable because it is instantiated 
600         by 'new' and no need to be copyable:
601
602         class/struct name               - instantiated at: WebCore/'location'
603
604         struct XMLHttpRequestStaticData - xml/XMLHttpRequest.cpp:134
605
606         Inherits the following classes from FastAllocBase because these are instantiated by 'new':
607
608         class NodeTest                  - xml/XPathGrammar.y:258
609         class NodeSet                   - xml/XPathValue.cpp:52
610         struct EvaluationContext        - xml/XPathExpressionNode.cpp:40
611
612         * xml/XMLHttpRequest.cpp:
613         * xml/XPathExpressionNode.h:
614         * xml/XPathNodeSet.h:
615         * xml/XPathStep.h:
616
617 2009-12-03  Drew Wilson  <atwilson@chromium.org>
618
619         Reviewed by Adam Barth.
620
621         New History changes do not compile for Chromium/V8
622         https://bugs.webkit.org/show_bug.cgi?id=32148
623
624         Existing tests suffice (just trying to get code to compile).
625
626         * WebCore.gypi:
627         Added V8HistoryCustom.cpp and other missing files.
628         * bindings/v8/custom/V8CustomBinding.h:
629         Added custom handlers for History.pushState()/replaceState().
630         * bindings/v8/custom/V8HistoryCustom.cpp: Added.
631         Added custom handlers for History.pushState()/replaceState().
632         * history/BackForwardListChromium.cpp:
633         (WebCore::BackForwardList::pushStateItem):
634         Stubbed out this routine for now - will implement in the future.
635
636 2009-12-03  Adam Barth  <abarth@webkit.org>
637
638         Reviewed by Eric Seidel.
639
640         OwnPtr<XBLBindingManager> Document::m_bindingManager;
641         https://bugs.webkit.org/show_bug.cgi?id=32147
642
643         The document actually owns the bindingManager.  That's what the code
644         should say.
645
646         * dom/Document.cpp:
647         (WebCore::Document::~Document):
648         * dom/Document.h:
649         (WebCore::Document::bindingManager):
650
651 2009-12-03  Adam Barth  <abarth@webkit.org>
652
653         Reviewed by Eric Seidel.
654
655         OwnPtr<Tokenizer> Document::m_tokenizer;
656         https://bugs.webkit.org/show_bug.cgi?id=32145
657
658         The document actually owns the tokenizer.  That's what the code should say.
659
660         * dom/Document.cpp:
661         (WebCore::Document::removedLastRef):
662         (WebCore::Document::~Document):
663         (WebCore::Document::cancelParsing):
664         (WebCore::Document::implicitOpen):
665         (WebCore::Document::implicitClose):
666         * dom/Document.h:
667         (WebCore::Document::tokenizer):
668
669 2009-12-03  Adam Barth  <abarth@webkit.org>
670
671         Reviewed by Eric Seidel.
672
673         OwnPtr<RenderArena> Document::m_renderArena;
674         https://bugs.webkit.org/show_bug.cgi?id=32146
675
676         The document owns the renderArena.  That's what the code should say.
677
678         * dom/Document.cpp:
679         (WebCore::Document::Document): Also, removed a redundant initialization
680         of the tokenizer that I missed in my previous patch.
681         (WebCore::Document::~Document):
682         (WebCore::Document::attach):
683         (WebCore::Document::detach):
684         * dom/Document.h:
685         (WebCore::Document::renderArena):
686
687 2009-12-03  Drew Wilson  <atwilson@chromium.org>
688
689         Rolling back r51633 because it causes a chromium perf regression.
690
691         * platform/graphics/SimpleFontData.h:
692         * platform/graphics/mac/ComplexTextControllerCoreText.cpp:
693
694 2009-12-03  Adam Barth  <abarth@webkit.org>
695
696         Reviewed by Eric Seidel.
697
698         The code should say that Document owns DocLoader
699         https://bugs.webkit.org/show_bug.cgi?id=32143
700
701         It's the truth.
702
703         * dom/Document.cpp:
704         (WebCore::Document::~Document):
705         * dom/Document.h:
706         (WebCore::Document::docLoader):
707
708 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
709
710         Reviewed by Eric Seidel.
711
712         AX: VO just says "term" on many web sites
713         https://bugs.webkit.org/show_bug.cgi?id=32139
714
715         Test: platform/mac/accessibility/definition-list-term.html
716
717         * accessibility/AccessibilityRenderObject.cpp:
718         (WebCore::AccessibilityRenderObject::accessibilityDescription):
719         * accessibility/mac/AccessibilityObjectWrapper.mm:
720         (-[AccessibilityObjectWrapper subrole]):
721         (-[AccessibilityObjectWrapper roleDescription]):
722
723 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
724
725         Reviewed by Beth Dakin.
726
727         Implement WAI-ARIA scrollbar role and related property aria-orientation
728         https://bugs.webkit.org/show_bug.cgi?id=32126
729
730         Test: accessibility/aria-scrollbar-role.html
731
732         * accessibility/AccessibilityObject.cpp:
733         (WebCore::createARIARoleMap):
734         * accessibility/AccessibilityObject.h:
735         (WebCore::AccessibilityObject::isScrollbar):
736         * accessibility/AccessibilityRenderObject.cpp:
737         (WebCore::AccessibilityRenderObject::valueForRange):
738         (WebCore::AccessibilityRenderObject::orientation):
739         (WebCore::AccessibilityRenderObject::canHaveChildren):
740         * accessibility/AccessibilityRenderObject.h:
741         * accessibility/mac/AccessibilityObjectWrapper.mm:
742         (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
743         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
744         * html/HTMLAttributeNames.in:
745
746 2009-12-03  Dan Bernstein  <mitz@apple.com>
747
748         Reviewed by Darin Adler.
749
750         Fixed <rdar://problem/7401617> Selection painting issue in hardware-
751         accelerated layers
752         which is another part of https://bugs.webkit.org/show_bug.cgi?id=23628
753         Fix selection painting to do container-relative repaints
754
755         Test: fast/repaint/block-selection-gap-in-composited-layer.html
756
757         * rendering/RenderBlock.cpp:
758         (WebCore::RenderBlock::selectionGapRectsForRepaint): Compute and paint
759         gap rects in the coordinate space of the repaint container.
760         * rendering/RenderLayerCompositor.cpp:
761         (WebCore::RenderLayerCompositor::recursiveRepaintLayerRect): Added a
762         FIXME.
763         * rendering/RenderView.cpp:
764         (WebCore::RenderView::setSelection): Map block selection gap rects from
765         the repaint container’s coordinate space to the view’s coordinate space
766         before adding them to the cached selection bounds.
767         (WebCore::RenderView::clearSelection): Changed to use
768         repaintRectangleInViewAndCompositedLayers() so that the selection rect
769         is invalidated in composited layers as well.
770
771 2009-12-03  Jonathan Dixon  <joth@chromium.org>
772
773         Reviewed by Dimitri Glazkov.
774
775         Bug 32066 - Add enable geolocation flag to WebCore::Settings for Chromium
776         https://bugs.webkit.org/show_bug.cgi?id=32066
777
778         Adds geolocationEnabled in Settings for runtime control of geolocaiton features. This defaults to ON
779         as it is intended as a development and testing aid, not a user control. To completely remove geolocation
780         from a given port, the compile time ENABLE_GEOLOCATION should still be used.
781         Adding placeholder GeolocationServiceChromium implementation, as this is required to allows
782         ENABLE_GEOLOCATION to be defined (in turn required for testing), even though this patch does not
783         make that the default just yet.
784
785         * WebCore.gypi:
786         * page/Settings.cpp:
787         (WebCore::Settings::Settings): Add new m_geolocationEnabled flag default value
788         (WebCore::Settings::setGeolocationEnabled): Setter for  m_geolocationEnabled flag
789         * page/Settings.h:
790         (WebCore::Settings::geolocationEnabled):  Add m_geolocationEnabled flag
791         * platform/chromium/GeolocationServiceChromium.cpp: Added.
792         (WebCore::GeolocationServiceChromium::GeolocationServiceChromium): Place holder GeolocationServiceChromium)
793         (WebCore::createGeolocationService): factory function, only required when ENABLED(GEOLOCATION) is true
794
795 2009-12-03  Enrica Casucci  <enrica@apple.com>
796
797         Reviewed by John Sullivan.
798
799         SpinTracer: 349 spins in Mail at WebCore::Editor::advanceToNextMisspelling(bool)
800         <rdar://problem/7198592>
801         https://bugs.webkit.org/show_bug.cgi?id=32129
802
803         Fixed the way the next paragraph is calculated.
804         I've added a repro case in Safari and attached it to the Bugzilla bug.
805
806         * editing/Editor.cpp:
807         (WebCore::findFirstMisspellingOrBadGrammarInRange): Changed the way we move to the
808         next paragraph in the loop.
809
810 2009-12-03  Oliver Hunt  <oliver@apple.com>
811
812         Build fix
813
814         * svg/SVGListTraits.h:
815         (WebCore::):
816
817 2009-12-03  Oliver Hunt  <oliver@apple.com>
818
819         Build fix
820
821         * svg/SVGListTraits.h:
822         (WebCore::):
823
824 2009-12-03  Brady Eidson  <beidson@apple.com>
825
826         No wonder editing WebCore.exp repeatedly while I worked on this patch never seemed to stick.
827
828         Long live our auto-generated overlords that I didn't know about...  
829
830         * WebCore.base.exp:
831
832 2009-12-03  Oliver Hunt  <oliver@apple.com>
833
834         Reviewed by Dan Bernstein.
835
836         REGRESSION (r51627): 3 SVG tests are failing
837         https://bugs.webkit.org/show_bug.cgi?id=32117
838
839         Null checking Items in the SVGList is insufficient as items may
840         be floats, etc so add SVGListTraits::isNull and add appropriate
841         specializations.
842
843         Test: svg/dom/svglist-exception-on-out-bounds-error.html
844
845         * svg/SVGList.h:
846         (WebCore::SVGListTypeOperations::isNull):
847         (WebCore::SVGList::initialize):
848         (WebCore::SVGList::insertItemBefore):
849         (WebCore::SVGList::replaceItem):
850         (WebCore::SVGList::appendItem):
851         * svg/SVGListTraits.h:
852         (WebCore::):
853
854 2009-12-03  Brady Eidson  <beidson@apple.com>
855
856         No review - release build fix.
857
858         * history/HistoryItem.cpp:
859         (WebCore::HistoryItem::documentDetached):
860
861 2009-12-03  Brady Eidson  <beidson@apple.com>
862
863         No review - release build fix.
864
865         * loader/HistoryController.cpp:
866         (WebCore::HistoryController::pushState):
867
868 2009-12-03  Enrica Casucci  <enrica@apple.com>
869
870         Reviewed by Adele Peterson.
871
872         Multiple Undos removes the last posted comment and/or the ones before it.
873         <rdar://problem/6557066>
874         https://bugs.webkit.org/show_bug.cgi?id=32079
875         
876         The fix consists in preventing Undos and Redos to be applied to elements that
877         are no longer editable. We do not attempt to remove the commands from the queue.
878         It is a relatively simple fix that comes with a little extra overhead for the apply
879         and unapply methods where we are now performing the editability check.
880
881         Test: editing/undo/undo-indent-noneditable.html
882
883         * editing/AppendNodeCommand.cpp:
884         (WebCore::AppendNodeCommand::doApply):
885         (WebCore::AppendNodeCommand::doUnapply):
886         * editing/DeleteFromTextNodeCommand.cpp:
887         (WebCore::DeleteFromTextNodeCommand::doApply):
888         (WebCore::DeleteFromTextNodeCommand::doUnapply):
889         * editing/InsertIntoTextNodeCommand.cpp:
890         (WebCore::InsertIntoTextNodeCommand::doApply):
891         (WebCore::InsertIntoTextNodeCommand::doUnapply):
892         * editing/InsertNodeBeforeCommand.cpp:
893         (WebCore::InsertNodeBeforeCommand::doApply):
894         (WebCore::InsertNodeBeforeCommand::doUnapply):
895         * editing/JoinTextNodesCommand.cpp:
896         (WebCore::JoinTextNodesCommand::doApply):
897         (WebCore::JoinTextNodesCommand::doUnapply):
898         * editing/MergeIdenticalElementsCommand.cpp:
899         (WebCore::MergeIdenticalElementsCommand::doApply):
900         (WebCore::MergeIdenticalElementsCommand::doUnapply):
901         * editing/RemoveNodeCommand.cpp:
902         (WebCore::RemoveNodeCommand::doApply):
903         (WebCore::RemoveNodeCommand::doUnapply):
904         * editing/SplitElementCommand.cpp:
905         (WebCore::SplitElementCommand::executeApply):
906         (WebCore::SplitElementCommand::doUnapply):
907         * editing/SplitTextNodeCommand.cpp:
908         (WebCore::SplitTextNodeCommand::doApply):
909         (WebCore::SplitTextNodeCommand::doUnapply):
910         * editing/WrapContentsInDummySpanCommand.cpp:
911         (WebCore::WrapContentsInDummySpanCommand::doUnapply):
912         (WebCore::WrapContentsInDummySpanCommand::doReapply):
913
914 2009-12-03  Brady Eidson  <beidson@apple.com>
915
916         Reviewed by Sam Weinig.
917
918         <rdar://problem/7214236> and http://webkit.org/b/32052 - Implement HTML5 state object history API
919
920         Tests: fast/loader/stateobjects/document-destroyed-navigate-back.html
921                fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html
922                fast/loader/stateobjects/popstate-after-load-complete-addeventlistener.html
923                fast/loader/stateobjects/popstate-after-load-complete-body-attribute.html
924                fast/loader/stateobjects/popstate-after-load-complete-window-attribute.html
925                fast/loader/stateobjects/pushstate-object-types.html
926                fast/loader/stateobjects/pushstate-then-replacestate.html
927                fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html
928                fast/loader/stateobjects/replacestate-then-pushstate.html
929                http/tests/loading/state-object-security-exception.html
930
931         Derived sources and project file changes:
932         * DerivedSources.cpp:
933         * DerivedSources.make:
934         * GNUmakefile.am
935         * WebCore.pro
936         * WebCore.vcproj/WebCore.vcproj:
937         * WebCore.xcodeproj/project.pbxproj:
938
939         Add the new PopStateEvent:
940         * dom/PopStateEvent.cpp: Added.
941         (WebCore::PopStateEvent::PopStateEvent):
942         (WebCore::PopStateEvent::initPopStateEvent):
943         * dom/PopStateEvent.h: Added.
944         (WebCore::PopStateEvent::create):
945         (WebCore::PopStateEvent::isPopStateEvent):
946         (WebCore::PopStateEvent::state):
947         * dom/PopStateEvent.idl: Added.
948         * bindings/js/JSPopStateEventCustom.cpp: Added.
949         (WebCore::JSPopStateEvent::initPopStateEvent):
950         (WebCore::JSPopStateEvent::state):
951         * bindings/js/JSEventCustom.cpp:
952         (WebCore::toJS):
953         * dom/Event.cpp:
954         (WebCore::Event::isPopStateEvent):
955         * dom/Event.h:
956         * dom/EventNames.h:
957
958         Add the "onpopstate" attribute:
959         * html/HTMLAttributeNames.in:
960         * html/HTMLBodyElement.cpp:
961         (WebCore::HTMLBodyElement::parseMappedAttribute):
962         * html/HTMLBodyElement.idl:
963         * html/HTMLFrameSetElement.cpp:
964         (WebCore::HTMLFrameSetElement::parseMappedAttribute):
965         * html/HTMLFrameSetElement.h:
966         * html/HTMLFrameSetElement.idl:
967         * page/DOMWindow.h:
968         * page/DOMWindow.idl:
969
970         Add pushState and replaceState management to the loader and history machinery:
971         * bindings/js/JSHistoryCustom.cpp:
972         (WebCore::JSHistory::pushState):
973         (WebCore::JSHistory::replaceState):
974         * loader/HistoryController.cpp:
975         (WebCore::HistoryController::updateForSameDocumentNavigation): Augmented from "scrollToAnchor()", combining
976           both the same-document fragment scroll case with the new same-document state object activation case.
977         (WebCore::HistoryController::pushState):
978         (WebCore::HistoryController::replaceState):
979         * loader/HistoryController.h:
980         * history/BackForwardList.cpp:
981         (WebCore::BackForwardList::addItem): Use insertItemAfterCurrent.
982         (WebCore::BackForwardList::insertItemAfterCurrent): Optionally insert the item without clearing the forward
983           list, as pushStateItem might've selectively cleared only certain items, with the bulk of the forward list
984           meant to remain.
985         (WebCore::BackForwardList::pushStateItem): Clear the forward list *only* for the state item's document, then 
986           insert the new item.
987         (WebCore::BackForwardList::removeItem):
988         * history/BackForwardList.h:
989         * page/History.cpp:
990         (WebCore::History::urlForState):
991         (WebCore::History::stateObjectAdded):
992         * page/History.h:
993         * page/History.idl:
994
995         Let HistoryItems and Documents associate with each other, as well as letting HistoryItems contain state objects:
996         * history/HistoryItem.cpp:
997         (WebCore::HistoryItem::HistoryItem):
998         (WebCore::HistoryItem::~HistoryItem):
999         (WebCore::HistoryItem::setStateObject):
1000         (WebCore::HistoryItem::setDocument):
1001         (WebCore::HistoryItem::documentDetached):
1002         * history/HistoryItem.h:
1003         (WebCore::HistoryItem::stateObject):
1004         (WebCore::HistoryItem::document):
1005         * dom/Document.cpp:
1006         (WebCore::Document::detach): Notify all back/forward history items owned by this Document that it
1007           is going away.
1008         (WebCore::Document::registerHistoryItem): Manage the list of back/forward history items this document owns.
1009         (WebCore::Document::unregisterHistoryItem): Ditto.
1010         * dom/Document.h:
1011
1012         Add the ability for Documents, DocumentLoaders, and FrameLoaderClients to be notified when a Documents
1013         URL changes as the result of pushState(), replaceState(), or a popstate navigation:
1014         * dom/Document.cpp:
1015         (WebCore::Document::implicitClose): If there's a pending state object, dispatch the popstate event.
1016         (WebCore::Document::updateURLForPushOrReplaceState):
1017         (WebCore::Document::statePopped): If loading is complete, dispatch the popstate event. Otherwise, set 
1018           the pending state object.
1019         * loader/DocumentLoader.cpp:
1020         (WebCore::DocumentLoader::replaceRequestURLForSameDocumentNavigation):
1021         * loader/DocumentLoader.h:
1022         * loader/FrameLoaderClient.h:
1023         * loader/EmptyClients.h:
1024         (WebCore::EmptyFrameLoaderClient::dispatchDidChangeStateObjectForPageForFrame):
1025
1026         Change handling of "loading a HistoryItem" to distinguish between new-Document navigations and same-Document
1027         navigations, combining the old concept of anchor scrolls with the new concept of state object navigations:
1028         * loader/FrameLoader.cpp:
1029         (WebCore::FrameLoader::loadInSameDocument):
1030         (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
1031         (WebCore::FrameLoader::navigateWithinDocument):
1032         (WebCore::FrameLoader::navigateToDifferentDocument):
1033         (WebCore::FrameLoader::loadItem):
1034         * loader/FrameLoader.h:
1035         * page/Page.cpp:
1036         (WebCore::Page::goToItem): Changed to allow state object activations to pass through without the load stopping.
1037
1038 2009-12-03  Pavel Feldman  <pfeldman@chromium.org>
1039
1040         Not reviewed: chromium build fix.
1041         r51621 changed JS bindings only, broke v8's.
1042
1043         * bindings/v8/ScriptFunctionCall.cpp:
1044         (WebCore::ScriptFunctionCall::appendArgument):
1045         * bindings/v8/ScriptFunctionCall.h:
1046
1047 2009-12-03  Dimitri Glazkov  <dglazkov@chromium.org>
1048
1049         Reviewed by Adam Barth.
1050
1051         [V8] Attributes and NamedNodeMaps aren't tracked correctly and may be prematurely garbage-collected.
1052         https://bugs.webkit.org/show_bug.cgi?id=32094
1053
1054         Covered by existing test: LayoutTests/fast/dom/Attr/access-after-element-destruction.html
1055
1056         * bindings/v8/DOMObjectsInclude.h:
1057         * bindings/v8/V8DOMWrapper.cpp:
1058         (WebCore::V8DOMWrapper::getTemplate):
1059         (WebCore::V8DOMWrapper::convertToV8Object):
1060         (WebCore::V8DOMWrapper::convertNamedNodeMapToV8Object):
1061         * bindings/v8/V8DOMWrapper.h:
1062         * bindings/v8/V8GCController.cpp:
1063         (WebCore::ObjectGrouperVisitor::visitDOMWrapper):
1064         * bindings/v8/custom/V8CustomBinding.h:
1065
1066 2009-12-03  Pavel Feldman  <pfeldman@chromium.org>
1067
1068         Reviewed by Timothy Hatcher.
1069
1070         Chromium: Add support for settings containing ":"
1071
1072         https://bugs.webkit.org/show_bug.cgi?id=32118
1073
1074         * inspector/front-end/WatchExpressionsSidebarPane.js:
1075         (WebInspector.WatchExpressionsSection):
1076
1077 2009-12-03  Rafael Antognolli  <antognolli@profusion.mobi>, Kenneth Christiansen <kenneth@webkit.org>
1078
1079         Reviewed by Simon Fraser.
1080
1081         repaint events from outside the viewport aren't received
1082         https://bugs.webkit.org/show_bug.cgi?id=32081
1083
1084         When using a tiled backing store for painting, you need to receive
1085         event from outside the viewport. Setting the viewport to the size
1086         of the contents is not an option if you want to make use of WebCore's
1087         infrastructure for drawing scrollbars etc.
1088
1089         A new property, paintsEntireContents, has been introduced for the
1090         above use-case. It is settable, as tiling will be optional for Qt,
1091         and for the not yet upstreamed EFL port, there will be two different
1092         views, where only one of them are tiled.
1093
1094         No change in behavior, so no new tests added.
1095
1096         * page/FrameView.cpp:
1097         (WebCore::FrameView::repaintContentRectangle):
1098         * platform/ScrollView.cpp:
1099         (WebCore::ScrollView::ScrollView):
1100         (WebCore::ScrollView::setPaintsEntireContents):
1101         (WebCore::ScrollView::wheelEvent):
1102         * platform/ScrollView.h:
1103         (WebCore::ScrollView::paintsEntireContents):
1104
1105 2009-11-23  Jeremy Moskovich  <jeremy@chromium.org>
1106
1107         Reviewed by Eric Seidel.
1108
1109         Switch Chrome/Mac to use Core Text APIs rather than ATSUI APIs.
1110         https://bugs.webkit.org/show_bug.cgi?id=31802
1111
1112         No test since this is already covered by existing pixel tests.
1113
1114         * platform/graphics/SimpleFontData.h: Change #ifdef to define getNSFont() on Chrome/Mac .
1115         * platform/graphics/mac/ComplexTextControllerCoreText.cpp: Provide forward declarations
1116         of Core Text functions that are public on 10.6 but SPI on 10.5.
1117
1118 2009-12-03  Pavel Feldman  <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
1119
1120         Reviewed by Timothy Hatcher.
1121
1122         Web Inspector: Simplify the settings support in inspector controller.
1123
1124         https://bugs.webkit.org/show_bug.cgi?id=32076
1125
1126         Test: inspector/settings-set-get.html
1127
1128         * WebCore.Inspector.exp:
1129         * bindings/js/JSInspectorFrontendHostCustom.cpp:
1130         * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
1131         * inspector/InspectorClient.h:
1132         * inspector/InspectorController.cpp:
1133         (WebCore::InspectorController::~InspectorController):
1134         (WebCore::InspectorController::setting):
1135         (WebCore::InspectorController::setSetting):
1136         (WebCore::InspectorController::setWindowVisible):
1137         (WebCore::InspectorController::attachWindow):
1138         (WebCore::InspectorController::setAttachedWindowHeight):
1139         (WebCore::InspectorController::storeLastActivePanel):
1140         (WebCore::InspectorController::scriptObjectReady):
1141         (WebCore::InspectorController::showWindow):
1142         (WebCore::InspectorController::enableResourceTracking):
1143         (WebCore::InspectorController::disableResourceTracking):
1144         (WebCore::InspectorController::ensureResourceTrackingSettingsLoaded):
1145         (WebCore::InspectorController::enableProfiler):
1146         (WebCore::InspectorController::disableProfiler):
1147         (WebCore::InspectorController::enableDebuggerFromFrontend):
1148         (WebCore::InspectorController::disableDebugger):
1149         * inspector/InspectorController.h:
1150         * inspector/InspectorFrontendHost.cpp:
1151         (WebCore::InspectorFrontendHost::setting):
1152         (WebCore::InspectorFrontendHost::setSetting):
1153         * inspector/InspectorFrontendHost.h:
1154         * inspector/InspectorFrontendHost.idl:
1155         * loader/EmptyClients.h:
1156         (WebCore::EmptyInspectorClient::populateSetting):
1157         (WebCore::EmptyInspectorClient::storeSetting):
1158
1159 2009-12-03  Ben Murdoch  <benm@google.com>
1160
1161         Reviewed by Brady Eidson.
1162
1163         [Android] notifyHistoryItemChanged() should pass a pointer to the HistoryItem that changed.
1164         https://bugs.webkit.org/show_bug.cgi?id=31915
1165
1166         No change in functionality so no new tests required.
1167
1168         * history/HistoryItem.cpp:
1169         (WebCore::defaultNotifyHistoryItemChanged): Update this function to pass the HistoryItem that is being changed.
1170         (WebCore::HistoryItem::setAlternateTitle): Update call to notifyHistoryItemChanged to include the new parameter.
1171         (WebCore::HistoryItem::setURLString): ditto.
1172         (WebCore::HistoryItem::setOriginalURLString): ditto.
1173         (WebCore::HistoryItem::setReferrer): ditto.
1174         (WebCore::HistoryItem::setTitle): ditto.
1175         (WebCore::HistoryItem::setTarget): ditto.
1176         (WebCore::HistoryItem::setDocumentState): On Android, add a call to notifyHistoryItemChanged. See bug for a discussion of why this is needed.
1177         (WebCore::HistoryItem::clearDocumentState): ditto.
1178         (WebCore::HistoryItem::setIsTargetItem): ditto.
1179         (WebCore::HistoryItem::addChildItem): ditto.
1180         (WebCore::HistoryItem::setFormInfoFromRequest): ditto.
1181         * history/HistoryItem.h: Update signature of notifyHistoryItemChanged.
1182
1183 2009-12-03  Ben Murdoch  <benm@google.com>
1184
1185         Reviewed by Brady Eidson.
1186
1187         [Android] The FrameLoaderClient is unaware of BackForwardList changes.
1188         https://bugs.webkit.org/show_bug.cgi?id=31914
1189
1190         This change adds three new methods on the FrameLoaderClient interface to receive notifications when the BackForwardList changes.
1191
1192         No new tests required. Functionality on all platforms upstream remains the same. Android is the first platform to make use of these callbacks.
1193
1194         * history/BackForwardList.cpp:
1195         (WebCore::BackForwardList::addItem): Execute the callback.
1196         (WebCore::BackForwardList::goBack): ditto.
1197         (WebCore::BackForwardList::goForward): ditto.
1198         (WebCore::BackForwardList::goToItem): ditto.
1199         (WebCore::BackForwardList::setCapacity): dito.
1200         * loader/EmptyClients.h:
1201         (WebCore::EmptyFrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation for the callback that does nothing.
1202         (WebCore::EmptyFrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto.
1203         (WebCore::EmptyFrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto.
1204         * loader/FrameLoaderClient.h:
1205
1206 2009-12-03  Ben Murdoch  <benm@google.com>
1207
1208         Reviewed by Brady Eidson.
1209
1210         [Android] Upstream WebCore/history/android: Require some platform specific state attached to HistoryItem.
1211         https://bugs.webkit.org/show_bug.cgi?id=31913
1212
1213         Android stores information such as the zoom scale factor and bridge back to the Java counterpart with HistoryItem.
1214
1215         No new tests required as this is Android specific code.
1216
1217         * history/HistoryItem.h: Add Android specific member data to HistoryItem.
1218         * history/android: Added.
1219         * history/android/AndroidWebHistoryBridge.h: Added.
1220         * history/android/HistoryItemAndroid.cpp: Added, provides implementation for Android specific member functions in HistoryItem.
1221         (WebCore::HistoryItem::bridge): Added.
1222         (WebCore::HistoryItem::setBridge): Added.
1223
1224 2009-12-03  Oliver Hunt  <oliver@apple.com>
1225
1226         Reviewed by Maciej Stachowiak.
1227
1228         NULL ptr in SVGPathSegList::getPathSegAtLength()
1229         https://bugs.webkit.org/show_bug.cgi?id=30313
1230
1231         Add exception checks to SVGPathSegList's implementation to catch (and propagate) exceptions.
1232         Add null checks to SVGList's content manipulation functions to prevent
1233         null values from entering the list in the first place.
1234
1235         Test: svg/dom/svgpath-out-of-bounds-getPathSeg.html
1236
1237         * svg/SVGList.h:
1238         (WebCore::SVGList::initialize):
1239         (WebCore::SVGList::insertItemBefore):
1240         (WebCore::SVGList::replaceItem):
1241         (WebCore::SVGList::appendItem):
1242         * svg/SVGPathElement.cpp:
1243         (WebCore::SVGPathElement::getPathSegAtLength):
1244         * svg/SVGPathElement.h:
1245         * svg/SVGPathElement.idl:
1246         * svg/SVGPathSegList.cpp:
1247         (WebCore::SVGPathSegList::getPathSegAtLength):
1248         (WebCore::SVGPathSegList::toPathData):
1249         (WebCore::SVGPathSegList::createAnimated):
1250         * svg/SVGPathSegList.h:
1251
1252 2009-12-02  Yusuke Sato  <yusukes@chromium.org>
1253
1254         Reviewed by Eric Seidel.
1255
1256         Sanitize web fonts using the OTS library 
1257         https://bugs.webkit.org/show_bug.cgi?id=31106
1258
1259         Add support for OpenType sanitizer (OTS). It parses OpenType files (from @font-face)
1260         and attempts to validate and sanitize them. We hope this reduces the attack surface
1261         of the system font libraries.
1262
1263         * WebCore.gyp/WebCore.gyp: Added dependency to (chromium_src_dir)/third_party/ots/ library.
1264         * WebCore.gypi: Added new files below.
1265         * WebCore.xcodeproj/project.pbxproj: Ditto.
1266         * platform/graphics/chromium/FontCustomPlatformData.cpp: Validate and transcode a web font.
1267         (WebCore::createFontCustomPlatformData):
1268         * platform/graphics/mac/FontCustomPlatformData.cpp: Ditto.
1269         (WebCore::createFontCustomPlatformData):
1270         * platform/graphics/opentype/OpenTypeSanitizer.cpp: Added.
1271         (WebCore::OpenTypeSanitizer::sanitize):
1272         * platform/graphics/opentype/OpenTypeSanitizer.h: Added.
1273         (WebCore::OpenTypeSanitizer::OpenTypeSanitizer):
1274
1275 2009-12-02  Oliver Hunt  <oliver@apple.com>
1276
1277         Reviewed by Sam Weinig.
1278
1279         Web Inspector frontend heap allocates ScriptFunctionCall which is unsafe
1280         https://bugs.webkit.org/show_bug.cgi?id=32098
1281
1282         Fix is simply to make the ScriptFunctionCall stack allocated as nature intended.
1283         Doing this required adding an appendArgument(char*) to ScriptFunctionCall so
1284         that an explicit String cast would not be necessary.
1285
1286         To prevent something like this happening again in future i've added private
1287         operator new implementations to ScriptFunctionCall making this type of mistake
1288         produce errors when compiling.
1289
1290         Test case: Inspector tests now pass with GC on every alloc enabled.
1291
1292         * bindings/js/ScriptFunctionCall.cpp:
1293         (WebCore::ScriptFunctionCall::appendArgument):
1294         * bindings/js/ScriptFunctionCall.h:
1295         (WebCore::ScriptFunctionCall::operator new):
1296         (WebCore::ScriptFunctionCall::operator new[]):
1297         * inspector/InspectorFrontend.cpp:
1298         (WebCore::InspectorFrontend::addConsoleMessage):
1299         (WebCore::InspectorFrontend::updateConsoleMessageRepeatCount):
1300         (WebCore::InspectorFrontend::addResource):
1301         (WebCore::InspectorFrontend::updateResource):
1302         (WebCore::InspectorFrontend::removeResource):
1303         (WebCore::InspectorFrontend::updateFocusedNode):
1304         (WebCore::InspectorFrontend::setAttachedWindow):
1305         (WebCore::InspectorFrontend::addRecordToTimeline):
1306         (WebCore::InspectorFrontend::parsedScriptSource):
1307         (WebCore::InspectorFrontend::failedToParseScriptSource):
1308         (WebCore::InspectorFrontend::addProfileHeader):
1309         (WebCore::InspectorFrontend::setRecordingProfile):
1310         (WebCore::InspectorFrontend::didGetProfileHeaders):
1311         (WebCore::InspectorFrontend::didGetProfile):
1312         (WebCore::InspectorFrontend::pausedScript):
1313         (WebCore::InspectorFrontend::setDocument):
1314         (WebCore::InspectorFrontend::setDetachedRoot):
1315         (WebCore::InspectorFrontend::setChildNodes):
1316         (WebCore::InspectorFrontend::childNodeCountUpdated):
1317         (WebCore::InspectorFrontend::childNodeInserted):
1318         (WebCore::InspectorFrontend::childNodeRemoved):
1319         (WebCore::InspectorFrontend::attributesUpdated):
1320         (WebCore::InspectorFrontend::didRemoveNode):
1321         (WebCore::InspectorFrontend::didGetChildNodes):
1322         (WebCore::InspectorFrontend::didApplyDomChange):
1323         (WebCore::InspectorFrontend::didGetEventListenersForNode):
1324         (WebCore::InspectorFrontend::didGetCookies):
1325         (WebCore::InspectorFrontend::didDispatchOnInjectedScript):
1326         (WebCore::InspectorFrontend::addDatabase):
1327         (WebCore::InspectorFrontend::selectDatabase):
1328         (WebCore::InspectorFrontend::didGetDatabaseTableNames):
1329         (WebCore::InspectorFrontend::addDOMStorage):
1330         (WebCore::InspectorFrontend::selectDOMStorage):
1331         (WebCore::InspectorFrontend::didGetDOMStorageEntries):
1332         (WebCore::InspectorFrontend::didSetDOMStorageItem):
1333         (WebCore::InspectorFrontend::didRemoveDOMStorageItem):
1334         (WebCore::InspectorFrontend::updateDOMStorage):
1335         (WebCore::InspectorFrontend::addNodesToSearchResult):
1336         (WebCore::InspectorFrontend::evaluateForTestInFrontend):
1337         * inspector/InspectorFrontend.h:
1338
1339 2009-12-02  Dave Hyatt  <hyatt@apple.com>
1340
1341         Reviewed by Darin Adler.
1342
1343         https://bugs.webkit.org/show_bug.cgi?id=32072, clean up invalid @-rule error handling so that we
1344         pass more CSS test suite stuff.  Make the grammar stop enforcing the ordering of @namespace vs.
1345         @variables vs. @import.  Just let the parser handle that instead.  This simplifies the grammar and
1346         makes error handling deal with more cases correctly.
1347
1348         Added fast/css/namespaces/namespaces-invalid-at-rules.xml
1349
1350         * css/CSSGrammar.y:
1351         * css/CSSParser.cpp:
1352         (WebCore::CSSParser::CSSParser):
1353         (WebCore::CSSParser::parseRule):
1354         (WebCore::CSSParser::createCharsetRule):
1355         (WebCore::CSSParser::createImportRule):
1356         (WebCore::CSSParser::createMediaRule):
1357         (WebCore::CSSParser::createKeyframesRule):
1358         (WebCore::CSSParser::createStyleRule):
1359         (WebCore::CSSParser::createFontFaceRule):
1360         (WebCore::CSSParser::addNamespace):
1361         (WebCore::CSSParser::createVariablesRule):
1362         * css/CSSParser.h:
1363
1364 2009-12-02  Yusuke Sato  <yusukes@chromium.org>
1365
1366         Reviewed by Dan Bernstein.
1367
1368         Safari/Chromium for Windows fails to load CJK WebFonts
1369         https://bugs.webkit.org/show_bug.cgi?id=31804
1370         
1371         * platform/graphics/opentype/OpenTypeUtilities.cpp:
1372         (WebCore::renameAndActivateFont): Load a remote font even if the font has 2 or more faces.
1373
1374 2009-12-02  Avi Drissman  <avi@chromium.org>
1375
1376         Reviewed by Darin Fisher.
1377
1378         Chromium: Need tickmarks in scrollbar
1379         https://bugs.webkit.org/show_bug.cgi?id=32069
1380
1381         * WebCore.gyp/WebCore.gyp:
1382         * WebCore.gypi:
1383         * platform/chromium/ScrollbarThemeChromiumMac.h: Added.
1384         * platform/chromium/ScrollbarThemeChromiumMac.mm: Added.
1385
1386 2009-11-13  Timothy Hatcher  <timothy@apple.com>
1387
1388         Expose a function to set the value of an input element on behalf of the user.
1389         This function will dispatch the change event so the page is notified when autofill
1390         happens. Also dispatch a change event when a select element is changed by autofill.
1391
1392         <rdar://problem/6760590> Would like a way to detect a login form AutoFill from JavaScript
1393
1394         Reviewed by Darin Adler.
1395
1396         * WebCore.xcodeproj/project.pbxproj: Added the DOMHTMLInputElementPrivate.h header.
1397         * bindings/objc/DOMHTML.mm:
1398         (-[DOMHTMLSelectElement _activateItemAtIndex:]): Call setSelectedIndexByUser instead so
1399         a change event is fired. This method is called by Safari autofill.
1400         * dom/Document.cpp:
1401         (WebCore::Document::setFocusedNode): Use dispatchFormControlChangeEvent instead
1402         of dispatching the change event directly to be consistent.
1403         * html/HTMLFormControlElement.cpp:
1404         (WebCore::HTMLInputElement::setValueForUser): Added. Calls setValue with the sendChangeEvent
1405         (WebCore::HTMLInputElement::setValue): Added the optional sendChangeEvent argument. Mimics setChecked.
1406         * html/HTMLInputElement.h:
1407         * html/HTMLInputElement.idl: Added setValueForUser for non-JS languages.
1408         * html/InputElement.h: Added setValueForUser.
1409
1410 2009-12-02  Pavel Feldman  <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
1411
1412         Reviewed by Timothy Hatcher.
1413
1414         Web Inspector: DOM tree selection disappears upon page refresh.
1415
1416         https://bugs.webkit.org/show_bug.cgi?id=31142
1417
1418         Test: inspector/elements-panel-selection-on-refresh.html
1419
1420         * inspector/InjectedScriptHost.cpp:
1421         (WebCore::InjectedScriptHost::pushNodeByPathToFrontend):
1422         * inspector/InjectedScriptHost.h:
1423         * inspector/InjectedScriptHost.idl:
1424         * inspector/InspectorBackend.h:
1425         * inspector/InspectorController.cpp:
1426         (WebCore::InspectorController::close):
1427         (WebCore::InspectorController::releaseDOMAgent):
1428         (WebCore::InspectorController::resetScriptObjects):
1429         * inspector/InspectorDOMAgent.cpp:
1430         (WebCore::InspectorDOMAgent::~InspectorDOMAgent):
1431         (WebCore::InspectorDOMAgent::reset):
1432         (WebCore::InspectorDOMAgent::setDocument):
1433         (WebCore::InspectorDOMAgent::pushDocumentToFrontend):
1434         (WebCore::InspectorDOMAgent::nodeForPath):
1435         (WebCore::InspectorDOMAgent::pushNodePathToFrontend):
1436         * inspector/InspectorDOMAgent.h:
1437         * inspector/front-end/DOMAgent.js:
1438         (WebInspector.DOMNode.prototype._renumber):
1439         (WebInspector.DOMAgent.prototype._setDocument):
1440         * inspector/front-end/ElementsPanel.js:
1441         (WebInspector.ElementsPanel.prototype.reset):
1442         (WebInspector.ElementsPanel.prototype.setDocument.selectDefaultNode):
1443         (WebInspector.ElementsPanel.prototype.setDocument.selectLastSelectedNode):
1444         (WebInspector.ElementsPanel.prototype.setDocument):
1445         * inspector/front-end/InjectedScript.js:
1446         (InjectedScript.pushNodeByPathToFrontend):
1447         * inspector/front-end/InjectedScriptAccess.js:
1448
1449 2009-12-01  Dave Hyatt  <hyatt@apple.com>
1450
1451         Reviewed by Dan Bernstein.
1452
1453         https://bugs.webkit.org/show_bug.cgi?id=32045, make sure escape sequences work with
1454         all the @-rules we support.  When escape sequences are present, the lexical scanner
1455         just returns a generic token name: ATKEYWORD.  We have to process the escape sequences
1456         and then recheck against the rules we support with the final processed name.  If we
1457         find a match, we mutate the token value to the appropriate rule name token, e.g.,
1458         NAMESPACE_SYM.
1459
1460         Added fast/css/namespaces/namespaces-escapes.xml
1461
1462         * css/CSSParser.cpp:
1463         (WebCore::CSSParser::lex):
1464         (WebCore::CSSParser::recheckAtKeyword):
1465         (WebCore::CSSParser::text):
1466         * css/CSSParser.h:
1467
1468 2009-12-02  Anton Muhin  <antonm@chromium.org>
1469
1470         Reviewed by Adam Barth.:w
1471
1472         Allow to skip thread checks when accessing DOMDataStore for processes
1473         which run V8 in single thread mode.
1474         https://bugs.webkit.org/show_bug.cgi?id=31877
1475
1476         Should be covered by buildbots.
1477
1478         * bindings/v8/V8DOMMap.cpp:
1479         (WebCore::getDOMDataStore):
1480         (WebCore::enableFasterDOMStoreAccess):
1481         (WebCore::getDOMNodeMap):
1482         (WebCore::getDOMObjectMap):
1483         (WebCore::getActiveDOMObjectMap):
1484         (WebCore::getDOMSVGElementInstanceMap):
1485         (WebCore::getDOMSVGObjectWithContextMap):
1486         * bindings/v8/V8DOMMap.h:
1487
1488 2009-12-02  Yury Semikhatsky  <yurys@chromium.org>
1489
1490         Reviewed by Pavel Feldman.
1491
1492         Code clean up: remove ScriptObjectQuarantine.* as a whole.
1493
1494         https://bugs.webkit.org/show_bug.cgi?id=32060
1495
1496         * GNUmakefile.am:
1497         * WebCore.gypi:
1498         * WebCore.pro:
1499         * WebCore.vcproj/WebCore.vcproj:
1500         * WebCore.xcodeproj/project.pbxproj:
1501         * WebCoreSources.bkl:
1502         * bindings/js/JSBindingsAllInOne.cpp:
1503         * bindings/js/ScriptObjectQuarantine.cpp: Removed.
1504         * bindings/js/ScriptObjectQuarantine.h: Removed.
1505         * bindings/js/ScriptValue.cpp:
1506         (WebCore::ScriptValue::quarantineValue):
1507         * bindings/js/ScriptValue.h:
1508         * bindings/v8/ScriptObjectQuarantine.cpp: Removed.
1509         * bindings/v8/ScriptObjectQuarantine.h: Removed.
1510         * bindings/v8/ScriptValue.h:
1511         (WebCore::ScriptValue::quarantineValue):
1512         * inspector/ConsoleMessage.cpp:
1513         (WebCore::ConsoleMessage::ConsoleMessage):
1514         * inspector/InspectorController.cpp:
1515         * inspector/InspectorDatabaseResource.cpp:
1516         (WebCore::InspectorDatabaseResource::bind):
1517         * inspector/InspectorFrontend.cpp:
1518
1519 2009-12-02  Fumitoshi Ukai  <ukai@chromium.org>
1520
1521         Reviewed by Alexey Proskuryakov.
1522
1523         WebSocket handshake check query component of URL
1524         https://bugs.webkit.org/show_bug.cgi?id=31617
1525
1526         Tests: websocket/tests/url-with-credential.html
1527                websocket/tests/url-with-empty-query.html
1528                websocket/tests/url-with-fragment.html
1529                websocket/tests/url-with-query-for-no-query.html
1530                websocket/tests/url-with-query.html
1531
1532         * platform/KURLGoogle.cpp:
1533         (WebCore::KURL::query): returns a null if query is not specified and returns an empty if query is specified but empty.
1534         * websockets/WebSocketHandshake.cpp:
1535         (WebCore::resourceName): added. add query component to path if specified.
1536         (WebCore::WebSocketHandshake::clientLocation):
1537         (WebCore::WebSocketHandshake::clientHandshakeMessage):
1538
1539 2009-12-01  David Levin  <levin@chromium.org>
1540
1541         Reviewed by Eric Seidel.
1542
1543         Incorrect code in WebGLRenderingContext.cpp
1544         https://bugs.webkit.org/show_bug.cgi?id=32046
1545
1546         Fix incorrect code that happened to work. != has higher precendence than &.
1547         The simplest fix is to remove the "!= 0" which violates WebKit style
1548         guidelines anyway.
1549
1550         Also added periods to few comments in the same function.
1551
1552         * html/canvas/WebGLRenderingContext.cpp:
1553         (WebCore::WebGLRenderingContext::validateIndexArray):
1554
1555 2009-12-01  Kent Tamura  <tkent@chromium.org>
1556
1557         Reviewed by Darin Adler.
1558
1559         Change [Reflect] to [ConvertNullToNullString, Reflect] for min, max,
1560         pattern and step attributes of HTMLInputElement.
1561         https://bugs.webkit.org/show_bug.cgi?id=31708
1562
1563         * html/HTMLInputElement.idl:
1564
1565 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
1566
1567         Reviewed by Darin Adler.
1568
1569         WAI-ARIA: implement support for ARIA drag and drop
1570         https://bugs.webkit.org/show_bug.cgi?id=32007
1571
1572         Test: platform/mac/accessibility/aria-drag-drop.html
1573
1574         * accessibility/AccessibilityObject.h:
1575         (WebCore::AccessibilityObject::supportsARIADropping):
1576         (WebCore::AccessibilityObject::supportsARIADragging):
1577         (WebCore::AccessibilityObject::isARIAGrabbed):
1578         (WebCore::AccessibilityObject::setARIAGrabbed):
1579         (WebCore::AccessibilityObject::determineARIADropEffects):
1580         * accessibility/AccessibilityRenderObject.cpp:
1581         (WebCore::AccessibilityRenderObject::supportsARIADropping):
1582         (WebCore::AccessibilityRenderObject::supportsARIADragging):
1583         (WebCore::AccessibilityRenderObject::isARIAGrabbed):
1584         (WebCore::AccessibilityRenderObject::setARIAGrabbed):
1585         (WebCore::AccessibilityRenderObject::determineARIADropEffects):
1586         * accessibility/AccessibilityRenderObject.h:
1587         * accessibility/mac/AccessibilityObjectWrapper.mm:
1588         (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
1589         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
1590         (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
1591         (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
1592         * html/HTMLAttributeNames.in:
1593
1594 2009-12-01  Adam Barth  <abarth@webkit.org>
1595
1596         https://bugs.webkit.org/show_bug.cgi?id=21288
1597
1598         Unreviewed port of @sandbox to V8.
1599
1600         * bindings/v8/ScriptController.cpp:
1601         (WebCore::ScriptController::isEnabled):
1602         * bindings/v8/custom/V8DOMWindowCustom.cpp:
1603         (WebCore::createWindow):
1604
1605 2009-12-01  Patrik Persson  <patrik.j.persson@ericsson.com>
1606
1607         Reviewed by Darin Adler.
1608
1609         Implement HTML5 sandbox attribute for iframes.
1610         http://www.w3.org/TR/html5/text-level-semantics.html#attr-iframe-sandbox
1611         https://bugs.webkit.org/show_bug.cgi?id=21288
1612
1613         Tests: fast/frames/sandboxed-iframe-attribute-parsing.html
1614                fast/frames/sandboxed-iframe-forms.html
1615                fast/frames/sandboxed-iframe-navigation-allowed.html
1616                fast/frames/sandboxed-iframe-navigation-parent.html
1617                fast/frames/sandboxed-iframe-navigation-targetlink.html
1618                fast/frames/sandboxed-iframe-navigation-windowopen.html
1619                fast/frames/sandboxed-iframe-plugins.html
1620                fast/frames/sandboxed-iframe-scripting.html
1621                fast/frames/sandboxed-iframe-storage.html
1622                http/tests/security/sandboxed-iframe-document-cookie.html
1623                http/tests/security/sandboxed-iframe-modify-self.html
1624                http/tests/security/xss-DENIED-sandboxed-iframe.html
1625                http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow.html
1626                http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard.html
1627                http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied.html
1628
1629         * bindings/js/JSDOMWindowCustom.cpp: sandboxing navigation
1630         (WebCore::createWindow):
1631         * bindings/js/ScriptController.cpp: sandboxing scripts
1632         (WebCore::ScriptController::isEnabled):
1633         * dom/Document.cpp:
1634         (WebCore::Document::processHttpEquiv):
1635         (WebCore::Document::cookie): raise exception when accessed from sandbox
1636         (WebCore::Document::setCookie): raise exception when accessed from sandbox
1637         (WebCore::Document::initSecurityContext): updae sandbox status
1638         (WebCore::Document::updateSandboxFlags):
1639         * dom/Document.h:
1640         * dom/Document.idl:
1641         * html/HTMLAppletElement.cpp: sandboxing applets
1642         (WebCore::HTMLAppletElement::createRenderer):
1643         (WebCore::HTMLAppletElement::renderWidgetForJSBindings):
1644         (WebCore::HTMLAppletElement::canEmbedJava):
1645         * html/HTMLAppletElement.h:
1646         * html/HTMLAttributeNames.in:
1647         * html/HTMLFrameOwnerElement.cpp: management of sandbox flags as stated in attribute
1648         (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement):
1649         (WebCore::HTMLFrameOwnerElement::setSandboxFlags):
1650         * html/HTMLFrameOwnerElement.h:
1651         (WebCore::HTMLFrameOwnerElement::sandboxFlags):
1652         * html/HTMLIFrameElement.cpp: sandbox attribute parsing
1653         (WebCore::parseSandboxAttribute):
1654         (WebCore::HTMLIFrameElement::parseMappedAttribute):
1655         * html/HTMLIFrameElement.idl:
1656         * inspector/InspectorController.cpp:
1657         (WebCore::InspectorController::getCookies):
1658         * loader/CrossOriginAccessControl.cpp:
1659         (WebCore::passesAccessControlCheck):
1660         * loader/FrameLoader.cpp:
1661         (WebCore::FrameLoader::FrameLoader):
1662         (WebCore::FrameLoader::init):
1663         (WebCore::FrameLoader::submitForm): sandboxing forms
1664         (WebCore::FrameLoader::requestObject): sandboxing plugins
1665         (WebCore::FrameLoader::shouldAllowNavigation): sandboxing navigation
1666         (WebCore::FrameLoader::updateSandboxFlags): propagation of sandbox flags
1667         * loader/FrameLoader.h:
1668         (WebCore::FrameLoader::ownerElementSandboxFlagsChanged):
1669         (WebCore::FrameLoader::isSandboxed):
1670         (WebCore::FrameLoader::sandboxFlags):
1671         * loader/FrameLoaderTypes.h:
1672         (WebCore::):
1673         * page/DOMWindow.cpp: disable storage and databases in sandboxed frames
1674         (WebCore::DOMWindow::sessionStorage):
1675         (WebCore::DOMWindow::localStorage):
1676         (WebCore::DOMWindow::openDatabase):
1677         * page/SecurityOrigin.cpp: added sandboxing status
1678         (WebCore::SecurityOrigin::SecurityOrigin):
1679         (WebCore::SecurityOrigin::canAccess):
1680         (WebCore::SecurityOrigin::canRequest):
1681         (WebCore::SecurityOrigin::toString):
1682         * page/SecurityOrigin.h:
1683         (WebCore::SecurityOrigin::setSandboxFlags):
1684         (WebCore::SecurityOrigin::isSandboxed):
1685         (WebCore::SecurityOrigin::canAccessDatabase):
1686         (WebCore::SecurityOrigin::canAccessStorage):
1687         * websockets/WebSocketChannel.cpp:
1688         (WebCore::WebSocketChannel::didReceiveData):
1689
1690 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
1691
1692         Reviewed by David Kilzer.
1693
1694         ARIA: support a way to create a static text object
1695         https://bugs.webkit.org/show_bug.cgi?id=32030
1696
1697         Test: accessibility/aria-text-role.html
1698
1699         * accessibility/AccessibilityObject.cpp:
1700         (WebCore::createARIARoleMap):
1701         * accessibility/AccessibilityRenderObject.cpp:
1702         (WebCore::AccessibilityRenderObject::stringValue):
1703         (WebCore::AccessibilityRenderObject::isDescendantOfBarrenParent):
1704         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
1705         (WebCore::AccessibilityRenderObject::text):
1706         * accessibility/AccessibilityRenderObject.h:
1707
1708 2009-12-01  Oliver Hunt  <oliver@apple.com>
1709
1710         Reviewed by Maciej Stachowiak.
1711
1712         Inspector crashes when collecting on every allocation
1713         https://bugs.webkit.org/show_bug.cgi?id=32044
1714
1715         The crash is caused by the prototype wrapper object getting collected
1716         when allocating the object that is going to use it as a prototype.
1717         Because the only reference to the prototype wrapper is through the
1718         new object's Structure it does not get marked automatically.
1719
1720         * bindings/js/JSInspectedObjectWrapper.cpp:
1721         (WebCore::JSInspectedObjectWrapper::wrap):
1722         * bindings/js/JSInspectorCallbackWrapper.cpp:
1723         (WebCore::JSInspectorCallbackWrapper::wrap):
1724
1725 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
1726
1727         Reviewed by Simon Fraser.
1728
1729         Add SVG animation test framework with 'snapshot' functionality
1730         https://bugs.webkit.org/show_bug.cgi?id=31897
1731
1732         Add 'sampleSVGAnimationForElementAtTime' method to the LayoutTestController,
1733         for the use within the new SVG animation test framework (LayoutTests/svg/animations/)
1734
1735         layoutTestController.sampleAnimationAtTime(<svg animation id>, <absolute time>, <svg element id>);
1736         to sample a svg animateMotion/animateColor/animate/set element at certain times.
1737
1738         After the desired SVG animation starts and calling the method above, it's immediately forwarded to
1739         the desired sampling time. After JS returns from the 'sampleSVGAnimationForElementAtTime' method
1740         a callback is fired used to sample the animation value at the target time. It's modelled similar
1741         to the CSS animation/transition testing framework, inspired by
1742         LayoutTests/animations/animation-test-helpers.js.
1743
1744         Though it has been extended to integrate within the fast/js/js-test-* framework, that's used for
1745         the SVG dynamic-updates tests, to simplify test creation, by utilizing script-tests/* only.
1746
1747         Adding a simple testcase testing the DRT methods, it will soon be extended to test animVal/baseVal
1748         interaction, while animating.
1749
1750         Test: svg/animations/animVal-basics.html
1751
1752         * WebCore.base.exp:
1753         * WebCore.xcodeproj/project.pbxproj:
1754         * svg/SVGDocumentExtensions.cpp:
1755         (WebCore::SVGDocumentExtensions::sampleAnimationAtTime):
1756         * svg/SVGDocumentExtensions.h:
1757         * svg/animation/SMILTimeContainer.cpp:
1758         (WebCore::SMILTimeContainer::SMILTimeContainer):
1759         (WebCore::SMILTimeContainer::sampleAnimationAtTime):
1760         (WebCore::SMILTimeContainer::updateAnimations):
1761         * svg/animation/SMILTimeContainer.h:
1762
1763 2009-12-01  Jens Alfke  <snej@chromium.org>
1764
1765         Reviewed by Darin Adler.
1766
1767         Add convenience methods to Element and QualifiedName that take
1768         char* instead of AtomicString, in preparation for removing the
1769         implicit conversion between the two types (30187).
1770         https://bugs.webkit.org/show_bug.cgi?id=31749
1771
1772         * dom/Element.cpp:
1773         (WebCore::Element::setCStringAttribute):  Equivalent to setAttribute.
1774         * dom/Element.h:
1775         * dom/QualifiedName.cpp:
1776         (WebCore::QualifiedName::init):  Shared impl of both constructors
1777         (WebCore::QualifiedName::QualifiedName):  New c'tor taking char*.
1778         * dom/QualifiedName.h:
1779         * platform/network/HTTPHeaderMap.cpp:
1780         (WebCore::CaseFoldingCStringTranslator):  Enables lookup by C string
1781         (WebCore::HTTPHeaderMap::get):  New variant that takes C string
1782         (WebCore::HTTPHeaderMap::contains):  New variant that takes C string
1783         (WebCore::HTTPHeaderMap::add):  New variant that takes C string
1784         * platform/network/HTTPHeaderMap.h:
1785         (WebCore::HTTPHeaderMap::get):
1786         (WebCore::HTTPHeaderMap::add):
1787         * platform/network/ResourceRequestBase.cpp:
1788         (WebCore::ResourceRequestBase::httpHeaderField):  New variant that takes C string
1789         * platform/network/ResourceRequestBase.h:
1790         (WebCore::ResourceRequestBase::setHTTPHeaderField):  Use symbolic names for headers
1791         * platform/network/ResourceResponseBase.cpp:
1792         (WebCore::ResourceResponseBase::httpHeaderField):  New variant that takes C string
1793         * platform/network/ResourceResponseBase.h:
1794
1795 2009-12-01  Alexey Proskuryakov  <ap@apple.com>
1796
1797         More Windows build fix.
1798
1799         * platform/network/cf/CredentialStorageCFNet.cpp:
1800         (WebCore::CredentialStorage::getFromPersistentStorage):
1801
1802 2009-12-01  Alexey Proskuryakov  <ap@apple.com>
1803
1804         Windows build fix.
1805
1806         * platform/network/cf/CredentialStorageCFNet.cpp: Include RetainPtr.h.
1807
1808 2009-12-01  Alexey Proskuryakov  <ap@apple.com>
1809
1810         Reviewed by Darin Adler.
1811
1812         https://bugs.webkit.org/show_bug.cgi?id=32036
1813         Implement CredentialStorage::getFromPersistentStorage for CFNetwork
1814
1815         * platform/network/cf/CredentialStorageCFNet.cpp:
1816         (WebCore::CredentialStorage::getFromPersistentStorage):
1817
1818 2009-12-01  Daniel Bates  <dbates@webkit.org>
1819
1820         Reviewed by Pavel Feldman.
1821
1822         https://bugs.webkit.org/show_bug.cgi?id=32001
1823
1824         Added missing localized strings (that I left out of the patch for bug #21554):
1825         %d × %d pixels
1826         %d × %d pixels (Natural: %d × %d pixels)
1827
1828         Also, changed formatting of these stings to conform with existing ones (added
1829         a space on both sides of the multiply sign).
1830
1831         * English.lproj/localizedStrings.js: Added stings.
1832         * inspector/front-end/ElementsTreeOutline.js:
1833         (WebInspector.ElementsTreeElement.prototype.createTooltipForImageNode):
1834
1835 2009-12-01  Dave Hyatt  <hyatt@apple.com>
1836
1837         Reviewed by Simon Fraser.
1838
1839         Fix for bug 32032, empty namespaces should be allowed in @namespace directives in CSS.
1840
1841         Added fast/css/namespaces/namespaces-empty.xml
1842
1843         * css/CSSStyleSheet.cpp:
1844         (WebCore::CSSStyleSheet::addNamespace):
1845         (WebCore::CSSStyleSheet::determineNamespace):
1846
1847 2009-12-01  Joseph Pecoraro  <joepeck@webkit.org>
1848
1849         Reviewed by Timothy Hatcher.
1850
1851         Web Inspector: Escape key in the Search Field should be more User Friendly
1852         https://bugs.webkit.org/show_bug.cgi?id=32005
1853
1854         * inspector/front-end/inspector.js:
1855         (WebInspector.loaded): add mousedown listener on the search field
1856         (WebInspector.searchFieldManualFocus): user clicked to focus on the search field
1857         (WebInspector.searchKeyDown): handle escape
1858
1859 2009-12-01  Dave Hyatt  <hyatt@apple.com>
1860
1861         Reviewed by David Kilzer.
1862
1863         @namespace directives need to use "maybe_space" in the "maybe_ns_prefix" portion of the grammar to match
1864         the spec.  Not doing so prevent comments from being used immmediately after the namespace prefix.
1865
1866         Added fast/css/namespaces-comments.xml
1867
1868         * css/CSSGrammar.y:
1869
1870 2009-12-01  Yael Aharon  <yael.aharon@nokia.com>
1871
1872         Reviewed by Timothy Hatcher.
1873
1874         Reloading WebInspector from context menu is closing it instead of reloading.
1875         https://bugs.webkit.org/show_bug.cgi?id=32004
1876
1877         When reloading WebInspector, don't delete its m_page.
1878
1879         * inspector/InspectorController.cpp:
1880         (WebCore::InspectorController::close):
1881
1882 2009-12-01  Steve Block  <steveblock@google.com>
1883
1884         Reviewed by Dimitri Glazkov.
1885
1886         Adds V8 bindings for Geolocation.
1887         https://bugs.webkit.org/show_bug.cgi?id=30206
1888
1889         Also adds Geolocation files to Chrome build files.
1890
1891         * WebCore.gyp/WebCore.gyp: Modified. Corrects list of Geolocation IDL files.
1892         * WebCore.gypi: Modified. Adds Geolocation files.
1893         * bindings/v8/DOMObjectsInclude.h: Modified. Adds Geolocation includes.
1894         * bindings/v8/DerivedSourcesAllInOne.cpp: Modified. Adds Geolocation files.
1895         * bindings/v8/V8Index.cpp: Modified. Includes Geolocation generated headers.
1896         * bindings/v8/V8Index.h: Modified. Adds Geolocation types to DOM_OBJECT_TYPES.
1897         * bindings/v8/custom/V8CoordinatesCustom.cpp: Added. Handles optional properties.
1898         * bindings/v8/custom/V8CustomBinding.h: Modified. Declares callbacks and getters.
1899         * bindings/v8/custom/V8CustomPositionCallback.cpp: Added.
1900         (WebCore::V8CustomPositionCallback::V8CustomPositionCallback): Added. Constructor.
1901         (WebCore::V8CustomPositionCallback::~V8CustomPositionCallback): Added. Destructor.
1902         (WebCore::V8CustomPositionCallback::handleEvent): Added. Invokes callback.
1903         * bindings/v8/custom/V8CustomPositionCallback.h: Added.
1904         (WebCore::V8CustomPositionCallback::create): Added. Factory method.
1905         * bindings/v8/custom/V8CustomPositionErrorCallback.cpp: Added.
1906         (WebCore::V8CustomPositionErrorCallback::V8CustomPositionErrorCallback): Added. Constructor.
1907         (WebCore::V8CustomPositionErrorCallback::~V8CustomPositionErrorCallback): Added. Destructor.
1908         (WebCore::V8CustomPositionErrorCallback::handleEvent): Added. Invokes callback.
1909         * bindings/v8/custom/V8CustomPositionErrorCallback.h: Added.
1910         (WebCore::V8CustomPositionErrorCallback::create): Added. Factory method.
1911         * bindings/v8/custom/V8GeolocationCustom.cpp: Added.
1912         (WebCore::throwTypeMismatchException): Added. Throws a type mismatch error.
1913         (WebCore::createPositionCallback): Added. Handles type checking for successCallback argument.
1914         (WebCore::createPositionErrorCallback): Added. Handles type checking for errorCallback argument.
1915         (WebCore::createPositionOptions): Added. Handles type checking for positionOptions argument.
1916
1917 2009-12-01  Yury Semikhatsky  <yurys@chromium.org>
1918
1919         Reviewed by Adam Barth.
1920
1921         Provide a way to get ScriptState for the inspected page.
1922
1923         https://bugs.webkit.org/show_bug.cgi?id=32020
1924
1925         * bindings/v8/ScriptController.cpp:
1926         (WebCore::ScriptController::mainWorldScriptState):
1927         * bindings/v8/ScriptController.h:
1928         * bindings/v8/ScriptState.cpp:
1929         (WebCore::scriptStateFromPage):
1930
1931 2009-12-01  Chris Marrin  <cmarrin@apple.com>
1932
1933         Reviewed by Adam Roben.
1934
1935         Changed mallocs to fastMallocs and frees to fastFrees in GraphicsContext3D. Also added error returns
1936         https://bugs.webkit.org/show_bug.cgi?id=30778
1937
1938         * platform/graphics/mac/GraphicsContext3DMac.cpp:
1939         (WebCore::GraphicsContext3D::getProgramInfoLog):
1940         (WebCore::GraphicsContext3D::getShaderInfoLog):
1941         (WebCore::GraphicsContext3D::getShaderSource):
1942         (WebCore::imageToTexture):
1943
1944 2009-12-01  Mads Ager  <ager@chromium.org>
1945
1946         Reviewed by Eric Seidel.
1947
1948         [V8] Don't crash in DOMWindow event getter in OOM situations
1949         https://bugs.webkit.org/show_bug.cgi?id=32017
1950
1951         Add missing null handle checks in DOMWindow event property
1952         accessors.  V8Proxy::context(frame) can return a null handle in
1953         OOM situations either if failing to initialize a context or if an
1954         OOM is handled gracefully and javascript is disabled.
1955
1956         No new tests because we don't have a good way to test
1957         out-of-memory bugs.
1958
1959         * bindings/v8/custom/V8DOMWindowCustom.cpp:
1960         (WebCore::ACCESSOR_GETTER):
1961         (WebCore::ACCESSOR_SETTER):
1962
1963 2009-12-01  Chris Marrin  <cmarrin@apple.com>
1964
1965         Reviewed by Oliver Hunt.
1966
1967         Updated HTMLCanvasElement to accept "experimental-webgl" as the context name.
1968         https://bugs.webkit.org/show_bug.cgi?id=31672
1969
1970         * html/HTMLCanvasElement.cpp:
1971         (WebCore::HTMLCanvasElement::getContext):
1972
1973 2009-12-01  Pavel Feldman  <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
1974
1975         Not reviewed: chromium build fix, added missing import.
1976
1977         * inspector/InspectorFrontendHost.cpp:
1978
1979 2009-12-01  Pavel Feldman  <pfeldman@chromium.org>
1980
1981         Not reviewed: fix windows build via unexcluding generated files from
1982         project.
1983
1984         * WebCore.vcproj/WebCore.vcproj:
1985
1986 2009-12-01  Mark Rowe  <mrowe@apple.com>
1987
1988         Stop copying IDL files in to the WebCore framework wrapper.
1989
1990         * WebCore.xcodeproj/project.pbxproj:
1991
1992 2009-12-01  Mark Rowe  <mrowe@apple.com>
1993
1994         Fix the Tiger build by making the Xcode project compatible with Xcode 2.4.
1995
1996         This was probably broken by hand-editing the project file as Xcode itself
1997         knows how to keep project files to a backwards-compatible subset of its format.
1998
1999         * WebCore.xcodeproj/project.pbxproj:
2000
2001 2009-12-01  Pavel Feldman  <pfeldman@chromium.org>
2002
2003         Not reviewed: windows build fix (bad vcproj in r51528).
2004
2005         * WebCore.vcproj/WebCore.vcproj:
2006
2007 2009-11-27  Pavel Feldman  <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
2008
2009         Reviewed by Timothy Hatcher.
2010
2011         Web Inspector: Split InspectorBackend into three parts: backend,
2012         injected script host and frontend host.
2013         
2014         https://bugs.webkit.org/show_bug.cgi?id=31888
2015
2016         * DerivedSources.make:
2017         * GNUmakefile.am:
2018         * WebCore.gypi:
2019         * WebCore.pro:
2020         * WebCore.vcproj/WebCore.vcproj:
2021         * WebCore.xcodeproj/project.pbxproj:
2022         * WebCoreSources.bkl:
2023         * bindings/js/JSBindingsAllInOne.cpp:
2024         * bindings/js/JSInspectorBackendCustom.cpp: Removed.
2025         * bindings/js/JSInspectorFrontendHostCustom.cpp: Added.
2026         (WebCore::JSInspectorFrontendHost::search):
2027         (WebCore::JSInspectorFrontendHost::setting):
2028         (WebCore::JSInspectorFrontendHost::setSetting):
2029         * bindings/js/ScriptObject.cpp:
2030         (WebCore::ScriptGlobalObject::set):
2031         * bindings/js/ScriptObject.h:
2032         * bindings/v8/DOMObjectsInclude.h:
2033         * bindings/v8/DerivedSourcesAllInOne.cpp:
2034         * bindings/v8/ScriptObject.cpp:
2035         (WebCore::ScriptGlobalObject::set):
2036         * bindings/v8/ScriptObject.h:
2037         * bindings/v8/V8Index.cpp:
2038         * bindings/v8/V8Index.h:
2039         * bindings/v8/custom/V8CustomBinding.h:
2040         * bindings/v8/custom/V8InjectedScriptHostCustom.cpp: Added.
2041         (WebCore::CALLBACK_FUNC_DECL):
2042         * bindings/v8/custom/V8InspectorBackendCustom.cpp: Removed.
2043         * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp: Added.
2044         (WebCore::CALLBACK_FUNC_DECL):
2045         * inspector/InjectedScriptHost.cpp: Added.
2046         (WebCore::InjectedScriptHost::InjectedScriptHost):
2047         (WebCore::InjectedScriptHost::~InjectedScriptHost):
2048         (WebCore::InjectedScriptHost::copyText):
2049         (WebCore::InjectedScriptHost::nodeForId):
2050         (WebCore::InjectedScriptHost::wrapObject):
2051         (WebCore::InjectedScriptHost::unwrapObject):
2052         (WebCore::InjectedScriptHost::pushNodePathToFrontend):
2053         (WebCore::InjectedScriptHost::addNodesToSearchResult):
2054         (WebCore::InjectedScriptHost::currentCallFrame):
2055         (WebCore::InjectedScriptHost::databaseForId):
2056         (WebCore::InjectedScriptHost::selectDatabase):
2057         (WebCore::InjectedScriptHost::selectDOMStorage):
2058         (WebCore::InjectedScriptHost::reportDidDispatchOnInjectedScript):
2059         (WebCore::InjectedScriptHost::inspectorDOMAgent):
2060         (WebCore::InjectedScriptHost::inspectorFrontend):
2061         * inspector/InjectedScriptHost.h: Added.
2062         (WebCore::InjectedScriptHost::create):
2063         (WebCore::InjectedScriptHost::inspectorController):
2064         (WebCore::InjectedScriptHost::disconnectController):
2065         * inspector/InjectedScriptHost.idl: Added.
2066         * inspector/InspectorBackend.cpp:
2067         (WebCore::InspectorBackend::InspectorBackend):
2068         (WebCore::InspectorBackend::storeLastActivePanel):
2069         (WebCore::InspectorBackend::toggleNodeSearch):
2070         (WebCore::InspectorBackend::resourceTrackingEnabled):
2071         (WebCore::InspectorBackend::debuggerEnabled):
2072         (WebCore::InspectorBackend::enableDebugger):
2073         (WebCore::InspectorBackend::disableDebugger):
2074         (WebCore::InspectorBackend::addBreakpoint):
2075         (WebCore::InspectorBackend::updateBreakpoint):
2076         (WebCore::InspectorBackend::removeBreakpoint):
2077         (WebCore::InspectorBackend::pauseInDebugger):
2078         (WebCore::InspectorBackend::resumeDebugger):
2079         (WebCore::InspectorBackend::stepOverStatementInDebugger):
2080         (WebCore::InspectorBackend::stepIntoStatementInDebugger):
2081         (WebCore::InspectorBackend::stepOutOfFunctionInDebugger):
2082         (WebCore::InspectorBackend::pauseOnExceptions):
2083         (WebCore::InspectorBackend::setPauseOnExceptions):
2084         (WebCore::InspectorBackend::profilerEnabled):
2085         (WebCore::InspectorBackend::enableProfiler):
2086         (WebCore::InspectorBackend::disableProfiler):
2087         (WebCore::InspectorBackend::startProfiling):
2088         (WebCore::InspectorBackend::stopProfiling):
2089         (WebCore::InspectorBackend::getProfileHeaders):
2090         (WebCore::InspectorBackend::getProfile):
2091         (WebCore::InspectorBackend::currentCallFrame):
2092         (WebCore::InspectorBackend::highlightDOMNode):
2093         (WebCore::InspectorBackend::hideDOMNodeHighlight):
2094         (WebCore::InspectorBackend::getCookies):
2095         (WebCore::InspectorBackend::deleteCookie):
2096         (WebCore::InspectorBackend::didEvaluateForTestInFrontend):
2097         (WebCore::InspectorBackend::nodeForId):
2098         * inspector/InspectorBackend.h:
2099         (WebCore::InspectorBackend::create):
2100         * inspector/InspectorBackend.idl:
2101         * inspector/InspectorController.cpp:
2102         (WebCore::InspectorController::InspectorController):
2103         (WebCore::InspectorController::~InspectorController):
2104         (WebCore::InspectorController::inspectedPageDestroyed):
2105         (WebCore::InspectorController::windowScriptObjectAvailable):
2106         * inspector/InspectorController.h:
2107         (WebCore::InspectorController::inspectorFrontendHost):
2108         (WebCore::InspectorController::injectedScriptHost):
2109         * inspector/InspectorFrontendHost.cpp: Added.
2110         (WebCore::InspectorFrontendHost::InspectorFrontendHost):
2111         (WebCore::InspectorFrontendHost::~InspectorFrontendHost):
2112         (WebCore::InspectorFrontendHost::loaded):
2113         (WebCore::InspectorFrontendHost::attach):
2114         (WebCore::InspectorFrontendHost::detach):
2115         (WebCore::InspectorFrontendHost::closeWindow):
2116         (WebCore::InspectorFrontendHost::windowUnloading):
2117         (WebCore::InspectorFrontendHost::setAttachedWindowHeight):
2118         (WebCore::InspectorFrontendHost::moveWindowBy):
2119         (WebCore::InspectorFrontendHost::localizedStringsURL):
2120         (WebCore::InspectorFrontendHost::hiddenPanels):
2121         (WebCore::InspectorFrontendHost::platform):
2122         (WebCore::InspectorFrontendHost::port):
2123         (WebCore::InspectorFrontendHost::addResourceSourceToFrame):
2124         (WebCore::InspectorFrontendHost::addSourceToFrame):
2125         * inspector/InspectorFrontendHost.h: Added.
2126         (WebCore::InspectorFrontendHost::create):
2127         (WebCore::InspectorFrontendHost::inspectorController):
2128         (WebCore::InspectorFrontendHost::disconnectController):
2129         * inspector/InspectorFrontendHost.idl: Added.
2130         * inspector/front-end/Breakpoint.js:
2131         (WebInspector.Breakpoint.prototype.set condition):
2132         * inspector/front-end/BreakpointsSidebarPane.js:
2133         (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint):
2134         (WebInspector.BreakpointsSidebarPane.prototype.removeBreakpoint):
2135         (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
2136         * inspector/front-end/ConsoleView.js:
2137         (WebInspector.ConsoleView.prototype.clearMessages):
2138         * inspector/front-end/CookieItemsView.js:
2139         (WebInspector.CookieItemsView.prototype._deleteCookieCallback):
2140         * inspector/front-end/DOMAgent.js:
2141         (WebInspector.DOMAgent.prototype.getChildNodesAsync):
2142         (WebInspector.DOMAgent.prototype.setAttributeAsync):
2143         (WebInspector.DOMAgent.prototype.removeAttributeAsync):
2144         (WebInspector.DOMAgent.prototype.setTextNodeValueAsync):
2145         (WebInspector.Cookies.getCookiesAsync):
2146         (WebInspector.EventListeners.getEventListenersForNodeAsync):
2147         * inspector/front-end/DOMStorage.js:
2148         (WebInspector.DOMStorage.prototype.getEntries):
2149         (WebInspector.DOMStorage.prototype.setItem):
2150         (WebInspector.DOMStorage.prototype.removeItem):
2151         * inspector/front-end/Database.js:
2152         (WebInspector.Database.prototype.getTableNames):
2153         * inspector/front-end/ElementsPanel.js:
2154         (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):
2155         (WebInspector.ElementsPanel.prototype.hide):
2156         (WebInspector.ElementsPanel.prototype.reset):
2157         (WebInspector.ElementsPanel.prototype.handleCopyEvent):
2158         (WebInspector.ElementsPanel.prototype._nodeSearchButtonClicked):
2159         * inspector/front-end/ElementsTreeOutline.js:
2160         (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode.restoreHighlightToHoveredNode):
2161         (WebInspector.ElementsTreeOutline.prototype.set focusedDOMNode):
2162         ():
2163         * inspector/front-end/EventListenersSidebarPane.js:
2164         (WebInspector.EventListenersSidebarPane.prototype):
2165         * inspector/front-end/InjectedScript.js:
2166         (InjectedScript._evaluateAndWrap):
2167         (InjectedScript.performSearch.addNodesToResults):
2168         (InjectedScript.getCallFrames):
2169         (InjectedScript._callFrameForId):
2170         (InjectedScript._clearConsoleMessages):
2171         (InjectedScript._inspectObject):
2172         (InjectedScript._copy):
2173         (InjectedScript._ensureCommandLineAPIInstalled):
2174         (InjectedScript._window):
2175         (InjectedScript._nodeForId):
2176         (InjectedScript._objectForId):
2177         (InjectedScript.pushNodeToFrontend):
2178         (InjectedScript.executeSql):
2179         (InjectedScript.executeSql.errorCallback):
2180         (InjectedScript.executeSql.queryTransaction):
2181         * inspector/front-end/InjectedScriptAccess.js:
2182         (InjectedScriptAccess._installHandler.InjectedScriptAccess.methodName):
2183         (InjectedScriptAccess._installHandler):
2184         * inspector/front-end/InspectorBackendStub.js: Added.
2185         (.WebInspector.InspectorBackendStub):
2186         (.WebInspector.InspectorBackendStub.prototype.wrapCallback):
2187         (.WebInspector.InspectorBackendStub.prototype.platform):
2188         (.WebInspector.InspectorBackendStub.prototype.port):
2189         (.WebInspector.InspectorBackendStub.prototype.closeWindow):
2190         (.WebInspector.InspectorBackendStub.prototype.attach):
2191         (.WebInspector.InspectorBackendStub.prototype.detach):
2192         (.WebInspector.InspectorBackendStub.prototype.storeLastActivePanel):
2193         (.WebInspector.InspectorBackendStub.prototype.clearMessages):
2194         (.WebInspector.InspectorBackendStub.prototype.searchingForNode):
2195         (.WebInspector.InspectorBackendStub.prototype.search):
2196         (.WebInspector.InspectorBackendStub.prototype.toggleNodeSearch):
2197         (.WebInspector.InspectorBackendStub.prototype.setAttachedWindowHeight):
2198         (.WebInspector.InspectorBackendStub.prototype.moveByUnrestricted):
2199         (.WebInspector.InspectorBackendStub.prototype.addResourceSourceToFrame):
2200         (.WebInspector.InspectorBackendStub.prototype.addSourceToFrame):
2201         (.WebInspector.InspectorBackendStub.prototype.getResourceDocumentNode):
2202         (.WebInspector.InspectorBackendStub.prototype.highlightDOMNode):
2203         (.WebInspector.InspectorBackendStub.prototype.hideDOMNodeHighlight):
2204         (.WebInspector.InspectorBackendStub.prototype.inspectedWindow):
2205         (.WebInspector.InspectorBackendStub.prototype.loaded):
2206         (.WebInspector.InspectorBackendStub.prototype.localizedStringsURL):
2207         (.WebInspector.InspectorBackendStub.prototype.windowUnloading):
2208         (.WebInspector.InspectorBackendStub.prototype.hiddenPanels):
2209         (.WebInspector.InspectorBackendStub.prototype.debuggerEnabled):
2210         (.WebInspector.InspectorBackendStub.prototype.enableResourceTracking):
2211         (.WebInspector.InspectorBackendStub.prototype.disableResourceTracking):
2212         (.WebInspector.InspectorBackendStub.prototype.resourceTrackingEnabled):
2213         (.WebInspector.InspectorBackendStub.prototype.enableDebugger):
2214         (.WebInspector.InspectorBackendStub.prototype.disableDebugger):
2215         (.WebInspector.InspectorBackendStub.prototype.addBreakpoint):
2216         (.WebInspector.InspectorBackendStub.prototype.removeBreakpoint):
2217         (.WebInspector.InspectorBackendStub.prototype.updateBreakpoint):
2218         (.WebInspector.InspectorBackendStub.prototype.pauseInDebugger):
2219         (.WebInspector.InspectorBackendStub.prototype.pauseOnExceptions):
2220         (.WebInspector.InspectorBackendStub.prototype.setPauseOnExceptions):
2221         (.WebInspector.InspectorBackendStub.prototype.resumeDebugger):
2222         (.WebInspector.InspectorBackendStub.prototype.profilerEnabled):
2223         (.WebInspector.InspectorBackendStub.prototype.enableProfiler):
2224         (.WebInspector.InspectorBackendStub.prototype.disableProfiler):
2225         (.WebInspector.InspectorBackendStub.prototype.startProfiling):
2226         (.WebInspector.InspectorBackendStub.prototype.stopProfiling):
2227         (.WebInspector.InspectorBackendStub.prototype.getProfileHeaders):
2228         (.WebInspector.InspectorBackendStub.prototype.getProfile):
2229         (.WebInspector.InspectorBackendStub.prototype.takeHeapSnapshot):
2230         (.WebInspector.InspectorBackendStub.prototype.databaseTableNames):
2231         (.WebInspector.InspectorBackendStub.prototype.stepIntoStatementInDebugger):
2232         (.WebInspector.InspectorBackendStub.prototype.stepOutOfFunctionInDebugger):
2233         (.WebInspector.InspectorBackendStub.prototype.stepOverStatementInDebugger):
2234         (.WebInspector.InspectorBackendStub.prototype.setSetting):
2235         (.WebInspector.InspectorBackendStub.prototype.dispatchOnInjectedScript):
2236         (.WebInspector.InspectorBackendStub.prototype.releaseWrapperObjectGroup):
2237         (.WebInspector.InspectorBackendStub.prototype.setting):
2238         * inspector/front-end/InspectorControllerStub.js:
2239         * inspector/front-end/InspectorFrontendHostStub.js: Added.
2240         (.WebInspector.InspectorFrontendHostStub):
2241         (.WebInspector.InspectorFrontendHostStub.prototype.platform):
2242         (.WebInspector.InspectorFrontendHostStub.prototype.port):
2243         (.WebInspector.InspectorFrontendHostStub.prototype.closeWindow):
2244         (.WebInspector.InspectorFrontendHostStub.prototype.attach):
2245         (.WebInspector.InspectorFrontendHostStub.prototype.detach):
2246         (.WebInspector.InspectorFrontendHostStub.prototype.search):
2247         (.WebInspector.InspectorFrontendHostStub.prototype.setAttachedWindowHeight):
2248         (.WebInspector.InspectorFrontendHostStub.prototype.moveWindowBy):
2249         (.WebInspector.InspectorFrontendHostStub.prototype.addResourceSourceToFrame):
2250         (.WebInspector.InspectorFrontendHostStub.prototype.addSourceToFrame):
2251         (.WebInspector.InspectorFrontendHostStub.prototype.loaded):
2252         (.WebInspector.InspectorFrontendHostStub.prototype.localizedStringsURL):
2253         (.WebInspector.InspectorFrontendHostStub.prototype.hiddenPanels):
2254         (.WebInspector.InspectorFrontendHostStub.prototype.setSetting):
2255         (.WebInspector.InspectorFrontendHostStub.prototype.setting):
2256         * inspector/front-end/ProfileView.js:
2257         (WebInspector.CPUProfileView):
2258         (WebInspector.CPUProfileType.prototype.buttonClicked):
2259         * inspector/front-end/ProfilesPanel.js:
2260         (WebInspector.ProfilesPanel.prototype._updateInterface):
2261         (WebInspector.ProfilesPanel.prototype._enableProfiling):
2262         (WebInspector.ProfilesPanel.prototype._toggleProfiling):
2263         * inspector/front-end/ResourcesPanel.js:
2264         (WebInspector.ResourcesPanel.prototype.reset):
2265         (WebInspector.ResourcesPanel.prototype._toggleLargerResources):
2266         (WebInspector.ResourcesPanel.prototype._enableResourceTracking):
2267         (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
2268         * inspector/front-end/ScriptView.js:
2269         (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
2270         * inspector/front-end/ScriptsPanel.js:
2271         (WebInspector.ScriptsPanel.prototype.show):
2272         (WebInspector.ScriptsPanel.prototype.addScript):
2273         (WebInspector.ScriptsPanel.prototype.attachDebuggerWhenShown):
2274         (WebInspector.ScriptsPanel.prototype.reset):
2275         (WebInspector.ScriptsPanel.prototype.canShowResource):
2276         (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
2277         (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
2278         (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsButton):
2279         (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons):
2280         (WebInspector.ScriptsPanel.prototype._enableDebugging):
2281         (WebInspector.ScriptsPanel.prototype._toggleDebugging):
2282         (WebInspector.ScriptsPanel.prototype._togglePauseOnExceptions):
2283         (WebInspector.ScriptsPanel.prototype._togglePause):
2284         (WebInspector.ScriptsPanel.prototype._stepOverClicked):
2285         (WebInspector.ScriptsPanel.prototype._stepIntoClicked):
2286         (WebInspector.ScriptsPanel.prototype._stepOutClicked):
2287         * inspector/front-end/SourceView.js:
2288         (WebInspector.SourceView.prototype.setupSourceFrameIfNeeded):
2289         (WebInspector.SourceView.prototype.performSearch.findSearchMatches):
2290         (WebInspector.SourceView.prototype.performSearch):
2291         * inspector/front-end/StylesSidebarPane.js:
2292         (WebInspector.StylesSidebarPane.prototype._changeColorFormat):
2293         * inspector/front-end/TestController.js:
2294         (WebInspector.TestController.prototype.notifyDone):
2295         * inspector/front-end/TimelinePanel.js:
2296         (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
2297         * inspector/front-end/WatchExpressionsSidebarPane.js:
2298         (WebInspector.WatchExpressionsSection.prototype.update):
2299         (WebInspector.WatchExpressionsSection.prototype.loadSavedExpressions):
2300         (WebInspector.WatchExpressionsSection.prototype.saveExpressions):
2301         * inspector/front-end/WebKit.qrc:
2302         * inspector/front-end/inspector.html:
2303         * inspector/front-end/inspector.js:
2304         (WebInspector.pendingDispatches.0.get platform):
2305         (WebInspector.get port):
2306         (WebInspector.set currentPanel):
2307         (WebInspector._createPanels):
2308         (WebInspector._loadPreferences):
2309         (WebInspector.set attached):
2310         (WebInspector._updateHoverHighlight):
2311         (WebInspector.loaded):
2312         (windowLoaded):
2313         (WebInspector.windowUnload):
2314         (WebInspector.close):
2315         (WebInspector.toolbarDrag):
2316         (WebInspector.UIString):
2317
2318 2009-11-30  Shinichiro Hamaji  <hamaji@chromium.org>
2319
2320         Reviewed by Dan Bernstein.
2321
2322         css2.1/t1205-c566-list-stl-00-e-ag.html is failing
2323         https://bugs.webkit.org/show_bug.cgi?id=23264
2324         css2.1/t1205-c565-list-pos-00-b.html is failing
2325         https://bugs.webkit.org/show_bug.cgi?id=23263
2326
2327         Ignore whitespaces after list markers.
2328         Rendering of this was already done for the case where inside=false.
2329         This fixes the rendering of inside=true case and calcInlinePrefWidths.
2330
2331         Test: fast/lists/calc-width-with-space.html
2332
2333         * rendering/RenderBlock.cpp:
2334         (WebCore::RenderBlock::calcInlinePrefWidths):
2335         * rendering/RenderBlockLineLayout.cpp:
2336         (WebCore::RenderBlock::findNextLineBreak):
2337
2338 2009-11-30  Fumitoshi Ukai  <ukai@chromium.org>
2339
2340         Unreviewed Chromium build fix introduced by r51212
2341
2342         Fix scriptStateFromNode and ScriptStateFromPage to take DOMWrapperWorld
2343         as the first argument.
2344         Move mainThreadNormalWorld() to ScriptState.{h,cpp}.
2345         Add debuggerWorld() and pluginWorld() in ScriptState.h.
2346
2347         * bindings/v8/ScriptController.cpp:
2348         * bindings/v8/ScriptController.h:
2349         * bindings/v8/ScriptState.cpp:
2350         (WebCore::scriptStateFromNode):
2351         (WebCore::scriptStateFromPage):
2352         (WebCore::mainThreadNormalWorld):
2353         * bindings/v8/ScriptState.h:
2354         (WebCore::debuggerWorld):
2355         (WebCore::pluginWorld):
2356
2357 2009-11-30  Enrica Casucci  <enrica@apple.com>
2358
2359         Reviewed by Darin Adler.
2360
2361         Can focus but not type into content editable block that contains only non-editable content.
2362         <rdar://problem/5982901>
2363         https://bugs.webkit.org/show_bug.cgi?id=31750
2364         
2365         The goal is to change the way we choose a visible position
2366         after hit detection, by preferring a visually equivalent editable
2367         position if available. By doing this, it is possible to add content
2368         to an editable block that initially contains only non editable elements.
2369
2370         Test: editing/selection/mixed-editability-10.html
2371
2372         * WebCore.base.exp: Changed to match the new signature of downstream
2373         and upstream in the Position class.
2374         * dom/Position.cpp:
2375         (WebCore::Position::atEditingBoundary): Added.
2376         (WebCore::Position::upstream): Modified to allow to cross the boundary
2377         between editable and non editable content if required.
2378         (WebCore::Position::downstream): Modified to allow to cross the boundary
2379         between editable and non editable content if required.
2380         (WebCore::Position::isCandidate): Modified to qualify as candidates positions
2381         that are at the editability boundary.
2382         (WebCore::Position::getInlineBoxAndOffset): Modified to retrieve the inline box
2383         to be used in calculating the caret rectangle.
2384         * dom/Position.h:
2385         (WebCore::Position::):
2386         * dom/PositionIterator.cpp:
2387         (WebCore::PositionIterator::atEditingBoundary): Added.
2388         (WebCore::PositionIterator::isCandidate): Modified to qualify as candidates positions
2389         that are at the editability boundary.
2390         * dom/PositionIterator.h:
2391         * editing/htmlediting.cpp:
2392         (WebCore::firstEditablePositionAfterPositionInRoot): Modified to accept not only
2393         descendants of the editable container, but the container itself.
2394         (WebCore::lastEditablePositionBeforePositionInRoot): Modified to accept not only
2395         descendants of the editable container, but the container itself.
2396         * rendering/RenderObject.cpp:
2397         (WebCore::RenderObject::createVisiblePosition): Added logic to prefer an editable position,
2398         if available.
2399         * rendering/RenderText.cpp:
2400         (WebCore::RenderText::isAllCollapsibleWhitespace): Added.
2401         * rendering/RenderText.h:
2402
2403 2009-11-30  Kevin Ollivier  <kevino@theolliviers.com>
2404
2405         wx build fix, add header needed for wx build.
2406
2407         * css/CSSFontFaceSrcValue.cpp:
2408
2409 2009-11-30  Mark Rowe  <mrowe@apple.com>
2410
2411         Reviewed by David Kilzer.
2412
2413         <rdar://problem/7424387> WebCore binary missing symbols when built for x86_64 from a machine that cannot run x86_64 binaries
2414
2415         The check for whether WTF_USE_PLUGIN_HOST_PROCESS is defined occurs under the native architecture of the build machine.
2416         If that is 32-bit then WTF_USE_PLUGIN_HOST_PROCESS will not be defined.  We work around this by forcing the check to
2417         be performed against the x86_64 architecture.
2418
2419         * DerivedSources.make:
2420
2421 2009-11-30  Beth Dakin  <bdakin@apple.com>
2422
2423         Reviewed by Oliver Hunt.
2424
2425         Fix for https://bugs.webkit.org/show_bug.cgi?id=32000 Crash in 
2426         Safari caused by extreme column-gap and column-width values 
2427         -and corresponding-
2428         <rdar://problem/7425433>
2429
2430         Prevent desiredColumnCount from being less than 1 since it is used 
2431         as a divisor.
2432         * rendering/RenderBlock.cpp:
2433         (WebCore::RenderBlock::calcColumnWidth):
2434
2435 2009-11-30  Alexey Proskuryakov  <ap@apple.com>
2436
2437         Reviewed by Oliver Hunt.
2438
2439         https://bugs.webkit.org/show_bug.cgi?id=31659
2440         Connection must be closed in case of Web Socket handshake error
2441
2442         The network connection was closed, but the close event wasn't dispatched.
2443
2444         Tested by websocket/tests/handshake-error.html, which is un-skipped now.
2445
2446         * platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::platformClose):
2447         Call client didHandle() method. This looks strange in CFNetwork implementation, because
2448         it's the client that asked to close the stream, so it shouldn't need the callback. It makes
2449         more sense in cross-process implementation, because closing is async there.
2450
2451 2009-11-30  Gavin Barraclough  <barraclough@apple.com>
2452
2453         Reviewed by Geoff Garen.
2454
2455         Bug 31859 - Make world selection for JSC IsolatedWorlds automagical.
2456
2457         WebCore presently has to explicitly specify the world before entering into JSC,
2458         which is a little fragile (particularly since property access via a
2459         getter/setter might invoke execution). Instead derive the current world from
2460         the lexical global object.
2461
2462         Remove the last uses of mainThreadCurrentWorld(), so the world is always obtained via
2463         currentWorld().  Switch this to obtain the world from the ExecsState's lexical global
2464         object instead.  Remove the call/construct/evaluate 'InWorld' methods, since these
2465         are no longer necessary.
2466
2467         * WebCore.base.exp:
2468         * bindings/js/JSCallbackData.cpp:
2469         (WebCore::JSCallbackData::invokeCallback):
2470         * bindings/js/JSCallbackData.h:
2471         (WebCore::JSCallbackData::JSCallbackData):
2472         * bindings/js/JSCustomXPathNSResolver.cpp:
2473         (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
2474         * bindings/js/JSDOMBinding.cpp:
2475         (WebCore::currentWorld):
2476         (WebCore::mainThreadNormalWorld):
2477         * bindings/js/JSDOMBinding.h:
2478         (WebCore::WebCoreJSClientData::WebCoreJSClientData):
2479         * bindings/js/JSDOMWindowBase.cpp:
2480         (WebCore::JSDOMWindowBase::updateDocument):
2481         * bindings/js/JSDOMWindowBase.h:
2482         * bindings/js/JSEventListener.cpp:
2483         (WebCore::JSEventListener::handleEvent):
2484         (WebCore::JSEventListener::reportError):
2485         * bindings/js/JSHTMLDocumentCustom.cpp:
2486         (WebCore::JSHTMLDocument::open):
2487         * bindings/js/JSNodeFilterCondition.cpp:
2488         (WebCore::JSNodeFilterCondition::acceptNode):
2489         * bindings/js/JSQuarantinedObjectWrapper.cpp:
2490         (WebCore::JSQuarantinedObjectWrapper::construct):
2491         (WebCore::JSQuarantinedObjectWrapper::call):
2492         * bindings/js/ScheduledAction.cpp:
2493         (WebCore::ScheduledAction::executeFunctionInContext):
2494         * bindings/js/ScriptController.cpp:
2495         (WebCore::ScriptController::evaluateInWorld):
2496         (WebCore::ScriptController::initScript):
2497         (WebCore::ScriptController::updateDocument):
2498         * bindings/js/ScriptFunctionCall.cpp:
2499         (WebCore::ScriptFunctionCall::call):
2500         (WebCore::ScriptFunctionCall::construct):
2501         * bindings/js/ScriptObjectQuarantine.cpp:
2502         (WebCore::getQuarantinedScriptObject):
2503         * bindings/js/ScriptState.cpp:
2504         (WebCore::scriptStateFromNode):
2505         (WebCore::scriptStateFromPage):
2506         * bindings/js/ScriptState.h:
2507         * bindings/js/WorkerScriptController.cpp:
2508         (WebCore::WorkerScriptController::evaluate):
2509         * bindings/objc/WebScriptObject.mm:
2510         (-[WebScriptObject callWebScriptMethod:withArguments:]):
2511         (-[WebScriptObject evaluateWebScript:]):
2512         * bridge/NP_jsobject.cpp:
2513         (_NPN_InvokeDefault):
2514         (_NPN_Invoke):
2515         (_NPN_Evaluate):
2516         (_NPN_Construct):
2517         * bridge/jni/jni_jsobject.mm:
2518         (JavaJSObject::call):
2519         (JavaJSObject::eval):
2520         * dom/NodeFilter.h:
2521         (WebCore::NodeFilter::acceptNode):
2522         * dom/NodeIterator.h:
2523         (WebCore::NodeIterator::nextNode):
2524         (WebCore::NodeIterator::previousNode):
2525         * dom/TreeWalker.h:
2526         (WebCore::TreeWalker::parentNode):
2527         (WebCore::TreeWalker::firstChild):
2528         (WebCore::TreeWalker::lastChild):
2529         (WebCore::TreeWalker::previousSibling):
2530         (WebCore::TreeWalker::nextSibling):
2531         (WebCore::TreeWalker::previousNode):
2532         (WebCore::TreeWalker::nextNode):
2533         * inspector/InspectorController.cpp:
2534         (WebCore::InspectorController::windowScriptObjectAvailable):
2535         (WebCore::InspectorController::didEvaluateForTestInFrontend):
2536         * inspector/JavaScriptCallFrame.cpp:
2537         (WebCore::JavaScriptCallFrame::evaluate):
2538
2539 2009-11-30  Eric Carlson  <eric.carlson@apple.com>
2540
2541         Reviewed by Simon Fraser.
2542
2543         All HTML5 media element events should be regular events
2544         https://bugs.webkit.org/show_bug.cgi?id=30513
2545
2546         * html/HTMLMediaElement.cpp:
2547         (WebCore::HTMLMediaElement::selectMediaResource):
2548         (WebCore::HTMLMediaElement::noneSupported):
2549         (WebCore::HTMLMediaElement::mediaEngineError):
2550         (WebCore::HTMLMediaElement::setNetworkState):
2551         (WebCore::HTMLMediaElement::userCancelledLoad):
2552             Call scheduleEvent instead of scheduleProgressEvent.
2553         (WebCore::HTMLMediaElement::progressEventTimerFired):
2554             Call scheduleEvent instead of scheduleProgressEvent. Call renderer->updateFromElement
2555             after scheduling a 'progress' event so the controller will update download
2556             progress indicator.
2557         * html/HTMLMediaElement.h:
2558             Remove scheduleProgressEvent prototype.
2559
2560 2009-11-30  Joseph Pecoraro  <joepeck@webkit.org>
2561
2562         Reviewed by Pavel Feldman.
2563
2564         Web Inspector: Wrong console output for Regexp escape sequence
2565         https://bugs.webkit.org/show_bug.cgi?id=31538
2566
2567         Updated inspector/console-format.html
2568
2569         * inspector/front-end/ConsoleView.js:
2570         (WebInspector.ConsoleView.createDividerElement): style issues.
2571         (WebInspector.ConsoleView.createFilterElement): style issues.
2572         (WebInspector.ConsoleView): added _customFormatters table.
2573         (WebInspector.ConsoleView.prototype.updateMessageRepeatCount): style isses.
2574         (WebInspector.ConsoleView.prototype._incrementErrorWarningCount): style issues.
2575         (WebInspector.ConsoleView.prototype._format): simplified delegation to formatter logic.
2576         (WebInspector.ConsoleView.prototype._formatobject):
2577         (WebInspector.ConsoleView.prototype._formatnode):
2578         (WebInspector.ConsoleView.prototype._printArray):
2579         (WebInspector.ConsoleMessage.prototype._format): commented and broke down the algorithm into parts.
2580         (WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString.append): handle substitution string formatting.
2581         (WebInspector.ConsoleMessage.prototype._formatIndividualValue): handling individual value formatting.
2582         (WebInspector.ConsoleCommandResult):
2583         * inspector/front-end/InjectedScript.js: simplified regex formatting.
2584         * inspector/front-end/inspector.js:
2585         (WebInspector.linkifyStringAsFragment): converted new RegExp to literal for performance benefits.
2586         * inspector/front-end/utilities.js: 
2587         (Element.prototype.hasStyleClass): update inaccurate comment.
2588         (String.prototype.trimURL): converted new RegExp to literal for performance benefits.
2589
2590 2009-11-30  Erik Arvidsson  <arv@chromium.org>
2591
2592         Reviewed by Adam Barth.
2593
2594         Clean up V8 bindings for CSSStyleDeclaration and CSSVariableDeclaration
2595         https://bugs.webkit.org/show_bug.cgi?id=31895
2596
2597         No new tests. This is already covered by:
2598                 fast/dom/CSSStyleDeclaration/css-computed-style-item.html
2599                 fast/dom/CSSStyleDeclaration/css-style-item.html
2600
2601         * bindings/v8/V8Collection.h:
2602         (WebCore::collectionStringIndexedPropertyGetter):
2603         (WebCore::setCollectionStringIndexedGetter):
2604         * bindings/v8/V8DOMWrapper.cpp:
2605         (WebCore::V8DOMWrapper::getTemplate):
2606
2607 2009-11-30  Steve Block  <steveblock@google.com>
2608
2609         Reviewed by Eric Seidel.
2610
2611         Adds include of wtf/StdLibExtras.h for DEFINE_STATIC_LOCAL in V8 ScriptController.
2612         https://bugs.webkit.org/show_bug.cgi?id=31932
2613
2614         Build fix only, no new tests.
2615
2616         * bindings/v8/ScriptController.cpp: Modified. Adds include of wtf/StdLibExtras.h.
2617
2618 2009-11-30  Steve Block  <steveblock@google.com>
2619
2620         Reviewed by Eric Seidel.
2621
2622         Adds PassOwnPtr include to ScriptExecutionContext.h.
2623         https://bugs.webkit.org/show_bug.cgi?id=31929
2624
2625         Build fix only, no new tests.
2626
2627         * dom/ScriptExecutionContext.h: Modified. Adds PassOwnPtr include.
2628
2629 2009-11-30  Dirk Schulze  <krit@webkit.org>
2630
2631         Reviewed by Nikolas Zimmermann.
2632
2633         REGRESSION (r49757): masking-mask-01-b.svg rendered incorrectly
2634         [https://bugs.webkit.org/show_bug.cgi?id=31980]
2635
2636         It turns out, that we did not handle maskUnits="userSpaceOnUse"
2637         correctly. We just need to move the context of the maskImage
2638         if maskContentUnits="objectBoundingBox". The context gets scaled
2639         on this unit combination, so we have to substract the position of
2640         the targetRect. On userSpaceOnUse the position just depends on the
2641         position of the mask element.
2642         I added a test with some senseless and reasonable values for size
2643         and postion of the mask and it's contents. I also used every
2644         combination of maskUnits and maskContentUnits to be sure, that it
2645         is fixed this time.
2646
2647         Test: svg/custom/mask-with-all-units.svg
2648
2649         * svg/SVGMaskElement.cpp:
2650         (WebCore::SVGMaskElement::drawMaskerContent):
2651
2652 2009-11-30  Steve Block  <steveblock@google.com>
2653
2654         Reviewed by Eric Seidel.
2655
2656         Adds ENABLE(INSPECTOR) guards around DOMWindow::inspectorTimelineAgent.
2657         https://bugs.webkit.org/show_bug.cgi?id=31928
2658
2659         Build fix only, no new tests.
2660
2661         * page/DOMWindow.cpp: Modified. Adds ENABLE(INSPECTOR) guards around DOMWindow::inspectorTimelineAgent.
2662
2663 2009-11-30  Steve Block  <steveblock@google.com>
2664
2665         Reviewed by Eric Seidel.
2666
2667         Adds SHARED_WORKERS guards to V8 WorkerContextExecutionProxy.
2668         https://bugs.webkit.org/show_bug.cgi?id=31926
2669
2670         Build fix only, no new tests.
2671
2672         * bindings/v8/WorkerContextExecutionProxy.cpp:
2673         (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
2674         (WebCore::WorkerContextExecutionProxy::convertToV8Object):
2675         (WebCore::WorkerContextExecutionProxy::convertEventTargetToV8Object):
2676
2677 2009-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
2678
2679         Reviewed by Kenneth Rohde Christiansen.
2680
2681         Chrome::contentsSizeChanged() is called when the content size has not changed
2682         https://bugs.webkit.org/show_bug.cgi?id=31978
2683
2684         Do not trigger contentsSizeChaned() is the new size is the same as the old one.
2685
2686         * page/FrameView.cpp:
2687         (WebCore::FrameView::setContentsSize):
2688
2689 2009-11-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2690
2691         Reviewed by Kenneth Rohde Christiansen.
2692
2693         [Qt] Fix some compiler warnings seen on QtWebKit/Mac
2694         https://bugs.webkit.org/show_bug.cgi?id=31962
2695
2696         No new tests as there is no functional change.
2697
2698         * platform/network/ResourceHandle.h: Make destructor virtual as 
2699         after r50772 ResourceHandle has virtual functions.
2700
2701         * plugins/mac/PluginPackageMac.cpp: 
2702         (WebCore::PluginPackage::fetchInfo): Fix typo WTF is a namespace
2703         not a label
2704
2705         * plugins/mac/PluginViewMac.cpp:
2706         (WebCore::PluginView::setNPWindowIfNeeded): Add l to the format
2707         specifier
2708
2709 2009-11-30  Xan Lopez  <xlopez@igalia.com>
2710
2711         Reviewed by Gustavo Noronha.
2712
2713         Add new headers to sources list.
2714
2715         * GNUmakefile.am:
2716
2717 2009-11-30  Girish Ramakrishnan  <girish@forwardbias.in>
2718
2719         Reviewed by Holger Freyther.
2720
2721         [Qt] Mac Plugins : Get context menu to work in QGraphicsView
2722         
2723         Flash expects the value in record.where to be the global position for
2724         displaying the context menu.
2725         
2726         https://bugs.webkit.org/show_bug.cgi?id=31979
2727
2728         * plugins/mac/PluginViewMac.cpp:
2729         (WebCore::PluginView::handleMouseEvent):
2730
2731 2009-11-30  Steve Block  <steveblock@google.com>
2732
2733         Reviewed by Eric Seidel.
2734
2735         Adds PLATFORM(CHROMIUM) guards around memory usage code in V8GCController.
2736         https://bugs.webkit.org/show_bug.cgi?id=31925
2737
2738         This code uses ChromiumBridge and Chromium-specific constant values not
2739         appropriate for other platforms such as Android.
2740
2741         Build fix only, no new tests.
2742
2743         * bindings/v8/V8GCController.cpp: Modified. Adds PLATFORM(CHROMIUM) around Chromium-specific code.
2744
2745 2009-11-29  Brent Fulgham  <bfulgham@webkit.org>
2746
2747         Build fix.
2748
2749         Correct draw signature used in ImageCairoWin.cpp.
2750
2751         * platform/graphics/win/ImageCairoWin.cpp:
2752         (WebCore::BitmapImage::getHBITMAPOfSize):
2753         (WebCore::BitmapImage::drawFrameMatchingSourceSize):
2754
2755 2009-11-28  Oliver Hunt  <oliver@apple.com>
2756
2757         Reviewed by Sam Weinig.
2758
2759         postMessage should serialize File objects
2760         https://bugs.webkit.org/show_bug.cgi?id=31955
2761
2762         Update SerializedScriptValue to include support for
2763         File objects in the serialized object graph.
2764
2765         * bindings/js/SerializedScriptValue.cpp:
2766         (WebCore::SerializedScriptValueData::SerializedScriptValueData):
2767         (WebCore::SerializingTreeWalker::convertIfTerminal):
2768         (WebCore::DeserializingTreeWalker::convertIfTerminal):
2769         * bindings/js/SerializedScriptValue.h:
2770         (WebCore::SerializedScriptValueData::):
2771         (WebCore::SerializedScriptValueData::asString):
2772
2773 2009-11-29  Simon Fraser  <simon.fraser@apple.com>
2774
2775         Reviewed by Dan Bernstein.
2776
2777         Optimize the hierarchy rebuilding of compositing layers
2778         https://bugs.webkit.org/show_bug.cgi?id=31879
2779         
2780         When updating the compositing layer hierarchy, instead of removing all
2781         child layers and then re-adding them one by one, build a vector of child
2782         layers, and set them in one go.
2783         
2784         * platform/graphics/GraphicsLayer.h:
2785         * platform/graphics/GraphicsLayer.cpp:
2786         (WebCore::GraphicsLayer::setChildren): New method that takes a Vector of child
2787         GraphicsLayers.
2788         
2789         * platform/graphics/mac/GraphicsLayerCA.h: Override setChildren().
2790         * platform/graphics/win/GraphicsLayerCACF.h: Ditto.
2791         * platform/graphics/mac/GraphicsLayerCA.mm: 
2792         (WebCore::GraphicsLayerCA::setChildren): Implement setChildren() to 
2793         set the bit that notes that sublayers changed.
2794         * platform/graphics/win/GraphicsLayerCACF.cpp:
2795         (WebCore::GraphicsLayerCACF::setChildren): Implement setChildren() to 
2796         udpate sublayers, with a note that this is not efficient.
2797         
2798         * rendering/RenderLayerCompositor.h:
2799         * rendering/RenderLayerCompositor.cpp:
2800         (WebCore::RenderLayerCompositor::updateCompositingLayers):
2801         When updating compositing layers, use the faster updateLayerTreeGeometry() if
2802         we know that no layer hierarchy changes are needed, and, at the root, use
2803         the vector returned from rebuildCompositingLayerTree() to attach the root
2804         layer.
2805         (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Changed to
2806         collect child layers into Vectors of GraphicsLayers, which can be set as
2807         layer children in one go.
2808         (WebCore::RenderLayerCompositor::updateLayerTreeGeometry): Split out from
2809         rebuildCompositingLayerTree() for simplicity, and called when we just need to
2810         update layer geometry, without doing any reparenting.
2811
2812 2009-11-29  Daniel Bates  <dbates@webkit.org>
2813
2814         Reviewed by Adam Barth.
2815
2816         https://bugs.webkit.org/show_bug.cgi?id=31971
2817
2818         Updated comment to reflect latest XSSAuditor bindings.
2819
2820         No functionality was changed. So, no new tests.
2821
2822         * page/XSSAuditor.h:
2823
2824 2009-11-29  Daniel Bates  <dbates@webkit.org>
2825
2826         Reviewed by Eric Seidel.
2827
2828         https://bugs.webkit.org/show_bug.cgi?id=31969
2829
2830         Removes unnecessary #include files.
2831
2832         No functionality was changed. So, no new tests.
2833
2834         * css/CSSComputedStyleDeclaration.cpp: Removed include CachedImage.h, and
2835         Pair.h
2836         * css/CSSCursorImageValue.cpp: Removed include RenderStyle.h
2837         * css/CSSFontFaceSrcValue.cpp: Removed include Node.h
2838         * css/CSSFontSelector.cpp: Removed include NodeList.h
2839         * css/CSSGradientValue.cpp: Removed include GraphicsContext.h, ImageBuffer.h
2840         * css/CSSImageValue.cpp: Removed include RenderStyle.h
2841         * css/CSSImportRule.cpp: Removed include MediaList.h
2842         * css/CSSMutableStyleDeclaration.cpp: Removed include CSSProperty.h
2843         * css/CSSRule.cpp: Removed include CSSStyleSheet.h
2844         * css/CSSStyleSelector.cpp: Removed include CSSFontFace.h,
2845         CSSFontFaceSource.h, and CSSProperty.h
2846         * page/EventSource.h: Removed include EventListener.h
2847
2848 2009-11-29  Daniel Bates  <dbates@webkit.org>
2849
2850         Reviewed by Eric Seidel.
2851
2852         https://bugs.webkit.org/show_bug.cgi?id=31965
2853
2854         Removed #include KeyframeList.h from CSSStyleSelector.h. Instead,
2855         forward declared it.
2856
2857         As a side effect, we need to #include KeyframeList.h in
2858         RenderLayerBacking.cpp.
2859
2860         No functionality was changed. So, no new tests.
2861
2862         * css/CSSStyleSelector.cpp:
2863         * css/CSSStyleSelector.h: Removed #include KeyframeList.h
2864         * rendering/RenderLayerBacking.cpp: Added #include KeyframeList.h
2865
2866 2009-11-29  Shu Chang  <Chang.Shu@nokia.com>
2867
2868         Reviewed by Eric Seidel.
2869
2870         Continue to search for matching node in the case where multiple nodes
2871         have the same id.
2872         https://bugs.webkit.org/show_bug.cgi?id=31428
2873
2874         Test: fast/dom/Element/id-in-node-list-index01.html
2875
2876         * dom/DynamicNodeList.cpp:
2877         (WebCore::DynamicNodeList::itemWithName):
2878
2879 2009-11-29  Daniel Bates  <dbates@webkit.org>
2880
2881         Reviewed by Eric Seidel.
2882
2883         https://bugs.webkit.org/show_bug.cgi?id=31966
2884
2885         Removed #include RenderStyle.h from file KeyframeAnimation.h. Instead,
2886         forward declared it.
2887
2888         No functionality was changed. So, no new tests.
2889
2890         * page/animation/KeyframeAnimation.cpp:
2891         * page/animation/KeyframeAnimation.h:
2892
2893 2009-11-29  Daniel Bates  <dbates@webkit.org>
2894
2895         Unreviewed, fix change log entry date.
2896
2897         For some reason, bugzilla-tool did not update the date in the change
2898         log entry for my last commit (r51468). So, this commit fixes the date
2899         of that entry.
2900
2901 2009-11-29  Daniel Bates  <dbates@webkit.org>
2902
2903         Reviewed by Dan Bernstein.
2904
2905         https://bugs.webkit.org/show_bug.cgi?id=31964
2906
2907         Removed #include StringImpl, StyleImage. Instead, forward declared them.
2908         Also, we can substitute #include <wtf/PassRefPtr.h> for #include PlatformString.h,
2909         since it seems we only really used it to include PassRefPtr.h.
2910
2911         No functionality was changed. So, no new tests.
2912
2913         * rendering/style/ContentData.h:
2914
2915 2009-11-29  Zoltan Horvath  <zoltan@webkit.org>
2916
2917         Reviewed by Eric Seidel.
2918
2919         Allow custom memory allocation control for classes of the rendering and storage directory in WebCore
2920         https://bugs.webkit.org/show_bug.cgi?id=31906
2921
2922         Inherits the following classes from Noncopyable because these are instantiated
2923         by 'new' and no need to be copyable:
2924
2925         class/struct name               - instantiated at: WebCore/'location'
2926
2927         class SQLTransactionClient      - storage/DatabaseThread.cpp:45
2928         class SQLTransactionCoordinator - storage/DatabaseThread.cpp:46
2929         class OriginUsageRecord         - storage/OriginQuotaManager.cpp:66
2930         class DatabaseTracker           - storage/DatabaseTracker.cpp:62
2931         class ScrollbarTheme            - (its child class) rendering/RenderScrollbarTheme.cpp:35
2932         class RenderSelectionInfoBase   - (its child class) rendering/RenderView.cpp:310
2933         class RenderOverflow            - rendering/RenderBox.cpp:2846
2934
2935         Inherits the following classes from FastAllocBase because these are instantiated by 'new':
2936
2937         struct FillLayer                - css/CSSStyleSelector.cpp:197
2938         struct ShadowData               - rendering/style/ShadowData.cpp:35
2939         class CounterContent            - css/CSSStyleSelector.cpp:4111
2940
2941         * platform/ScrollbarTheme.h:
2942         * rendering/RenderOverflow.h:
2943         * rendering/RenderSelectionInfo.h:
2944         * rendering/style/CounterContent.h:
2945         * rendering/style/FillLayer.h:
2946         * rendering/style/ShadowData.h:
2947         * storage/DatabaseTracker.h:
2948         * storage/OriginUsageRecord.h:
2949         * storage/SQLTransactionClient.h:
2950         * storage/SQLTransactionCoordinator.h:
2951
2952 2009-11-28  Adam Barth  <abarth@webkit.org>
2953
2954         Reviewed by Dimitri Glazkov.
2955
2956         [Chromium] Sify compose button alerts error
2957         https://bugs.webkit.org/show_bug.cgi?id=31394
2958
2959         Test: http/tests/security/calling-versus-current.html
2960
2961         We're supposed to use the calling context for security checks.  In JSC
2962         land, this is the lexicalGlobalObject.
2963
2964         * bindings/v8/V8Proxy.cpp:
2965         (WebCore::V8Proxy::canAccessPrivate):
2966
2967 2009-11-27  Shinichiro Hamaji  <hamaji@chromium.org>
2968
2969         Unreviewed Chromium build fix introduced by r51428.
2970
2971         [Chromium] Ignore line-height CSS property for PushButton
2972         https://bugs.webkit.org/show_bug.cgi?id=31712
2973
2974         * rendering/RenderThemeChromiumSkia.cpp:
2975         (WebCore::RenderThemeChromiumSkia::adjustButtonStyle):
2976
2977 2009-11-27  Shinichiro Hamaji  <hamaji@chromium.org>
2978
2979         Unreviewed Chromium test fix by reverting r51413.
2980
2981         [v8] Do not check the thread when accessing DOMDataStore
2982         https://bugs.webkit.org/show_bug.cgi?id=31877
2983
2984         * bindings/v8/V8DOMMap.cpp:
2985         (WebCore::getDOMNodeMap):
2986         (WebCore::getDOMObjectMap):
2987         (WebCore::getActiveDOMObjectMap):
2988         (WebCore::getDOMSVGElementInstanceMap):
2989         (WebCore::getDOMSVGObjectWithContextMap):
2990
2991 2009-11-27  Daniel Bates  <dbates@webkit.org>
2992
2993         Unreviewed, comment fix.
2994
2995         Corrected misspelling of the word "implemented".
2996
2997         * inspector/front-end/InjectedScriptAccess.js:
2998
2999 2009-11-27  Daniel Bates  <dbates@webkit.org>
3000
3001         Reviewed by Adam Barth.
3002
3003         https://bugs.webkit.org/show_bug.cgi?id=31940
3004
3005         Makes the error messages more descriptive when we refuse to load an object/embed or
3006         refuse to load from the document base URL.
3007
3008         * page/XSSAuditor.cpp:
3009         (WebCore::XSSAuditor::canLoadObject): Changed console message to be more descriptive.
3010         (WebCore::XSSAuditor::canSetBaseElementURL): Ditto.
3011
3012 2009-11-27  Yury Semikhatsky  <yurys@chromium.org>
3013
3014         Reviewed by Pavel Feldman.
3015
3016         This is a WebCore part of the fix that allows to view plugin
3017         resources loaded by plugins.
3018
3019         https://bugs.webkit.org/show_bug.cgi?id=31832
3020
3021         * inspector/InspectorController.cpp:
3022         (WebCore::InspectorController::willSendRequest):
3023         (WebCore::InspectorController::didReceiveResponse):
3024         (WebCore::InspectorController::didReceiveContentLength):
3025         (WebCore::InspectorController::didFinishLoading):
3026         (WebCore::InspectorController::didFailLoading):
3027         * inspector/InspectorController.h:
3028         * inspector/InspectorResource.cpp:
3029         (WebCore::InspectorResource::addLength):
3030         * loader/ResourceLoadNotifier.cpp:
3031         (WebCore::ResourceLoadNotifier::didFailToLoad):
3032         (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
3033         (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
3034         (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength):
3035         (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
3036
3037 2009-11-27  Yury Semikhatsky  <yurys@chromium.org>
3038
3039         Reviewed by Pavel Feldman.
3040
3041         Instead of generating negative identifiers for cached resources in
3042         InspectorController and extending identifier type from 'unsigned long' to 'long
3043         long' reuse progress tracker from the inspected page to generate those
3044         identifiers. It guarantees that InspectorResources have unique ids since
3045         all of them are generated by that progress tracker.
3046
3047         Added a couple new overloaded methods to Script* objects that accept
3048         long and unsigned long arguments. These types of argumens have already
3049         been passed as long long.
3050
3051         https://bugs.webkit.org/show_bug.cgi?id=31921
3052
3053         * bindings/js/ScriptFunctionCall.cpp:
3054         (WebCore::ScriptFunctionCall::appendArgument):
3055         * bindings/js/ScriptFunctionCall.h:
3056         * bindings/js/ScriptObject.cpp:
3057         (WebCore::ScriptObject::set):
3058         * bindings/js/ScriptObject.h:
3059         * bindings/v8/ScriptFunctionCall.cpp:
3060         (WebCore::ScriptFunctionCall::appendArgument):
3061         * bindings/v8/ScriptFunctionCall.h:
3062         * bindings/v8/ScriptObject.cpp:
3063         (WebCore::ScriptObject::set):
3064         * bindings/v8/ScriptObject.h:
3065         * inspector/InspectorBackend.cpp:
3066         (WebCore::InspectorBackend::dispatchOnInjectedScript):
3067         * inspector/InspectorController.cpp:
3068         (WebCore::InspectorController::InspectorController):
3069         (WebCore::InspectorController::getTrackedResource):
3070         (WebCore::InspectorController::didLoadResourceFromMemoryCache): Use inspected page's ProgressTracker to generate unique identifiers for cached resources in InspectorController.
3071         * inspector/InspectorController.h:
3072         * inspector/InspectorDOMAgent.cpp:
3073         (WebCore::InspectorDOMAgent::buildObjectForNode):
3074         (WebCore::InspectorDOMAgent::buildObjectForEventListener):
3075         * inspector/InspectorFrontend.cpp:
3076         (WebCore::InspectorFrontend::addResource):
3077         (WebCore::InspectorFrontend::updateResource):
3078         (WebCore::InspectorFrontend::removeResource):
3079         (WebCore::InspectorFrontend::updateFocusedNode):
3080         * inspector/InspectorFrontend.h:
3081         * inspector/InspectorResource.cpp:
3082         (WebCore::InspectorResource::InspectorResource):
3083         (WebCore::InspectorResource::createCached):
3084         * inspector/InspectorResource.h: Change InspectorResource identifier type from 'long long' to 'unsigned long'.
3085         (WebCore::InspectorResource::create):
3086         (WebCore::InspectorResource::identifier):
3087         * inspector/TimelineRecordFactory.cpp:
3088         (WebCore::TimelineRecordFactory::createResourceSendRequestRecord):
3089         (WebCore::TimelineRecordFactory::createResourceReceiveResponseRecord):
3090         (WebCore::TimelineRecordFactory::createResourceFinishRecord):
3091
3092 2009-11-26  Shinichiro Hamaji  <hamaji@chromium.org>
3093
3094         Reviewed by Dan Bernstein.
3095
3096         Assertion failure in RenderBlock::positionForPointWithInlineChildren when running fast/inline/relative-positioned-overflow.html
3097         https://bugs.webkit.org/show_bug.cgi?id=29966
3098
3099         When an empty inline element is clicked, the root inline box has
3100         no leaf children. Use the renderer of a normal child instead.
3101
3102         This change resolves Windows port's assertion failure in a layout test.
3103         Also, this fixes the behavior when a user drags the mouse from an
3104         empty inline element to above texts.
3105
3106         Test: editing/selection/last-empty-inline.html
3107
3108         * rendering/RenderBlock.cpp:
3109         (WebCore::RenderBlock::positionForPointWithInlineChildren):
3110
3111 2009-11-26  Kent Tamura  <tkent@chromium.org>
3112
3113         Reviewed by Eric Seidel.
3114
3115         [Chromium] Ignore line-height CSS property specified to push buttons on
3116         Windows and Linux.
3117         https://bugs.webkit.org/show_bug.cgi?id=31712
3118
3119         LayoutTests/fast/forms/control-restrict-line-height.html checks that the
3120         following controls should ignore line-height CSS property.
3121          - <select>
3122          - <input type=button>
3123          - <input type=search>
3124         This change addresses the <input type=button> issue with Chromium/Windows
3125         and Chromium/Linux.
3126         
3127         * rendering/RenderThemeChromiumSkia.cpp: Implement adjustButtonStyle() to ignore line-height.
3128         * rendering/RenderThemeChromiumSkia.h: Declare adjustButtonStyle().
3129
3130 2009-11-26  Kinuko Yasuda  <kinuko@chromium.com>
3131
3132         Reviewed by Eric Seidel.
3133
3134         Remove the special charset meta tag in the clipboard so that
3135         copy-and-paste with interchange breaklines/spaces works correctly
3136         within WebKit.
3137
3138         No new tests.  Layout tests that involve copy-and-paste with
3139         interchange breaklines (like editing/pasteboard/paste-line-endings-00?)
3140         should pass on Mac/Chromium with this fix.
3141
3142         * platform/chromium/ClipboardChromium.cpp:
3143         * platform/chromium/PasteboardChromium.cpp:
3144         (WebCore::Pasteboard::documentFragment):
3145
3146 2009-11-26  İsmail Dönmez  <ismail@namtrac.org>
3147
3148         Reviewed by Eric Seidel.
3149
3150         Compile with QT_NO_WHEELEVENT defined.
3151
3152         * platform/qt/WheelEventQt.cpp:
3153         (WebCore::PlatformWheelEvent::applyDelta):
3154
3155 2009-11-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3156
3157         Reviewed by Oliver Hunt.
3158
3159         Move GOwnPtr* from wtf to wtf/gtk
3160         https://bugs.webkit.org/show_bug.cgi?id=31793
3161
3162         No new tests as there is no functional change.
3163
3164         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: Change the
3165           path for GOwnPtr.h.
3166         * platform/text/TextEncoding.cpp: Ditto.
3167         * platform/text/gtk/TextCodecGtk.cpp: Ditto.
3168
3169 2009-11-26  Yury Semikhatsky  <yurys@chromium.org>
3170
3171         Not reviewed. Build fix: revert r51421.
3172
3173         * inspector/InspectorController.cpp:
3174         (WebCore::InspectorController::willSendRequest):
3175         (WebCore::InspectorController::didReceiveResponse):
3176         (WebCore::InspectorController::didReceiveContentLength):
3177         (WebCore::InspectorController::didFinishLoading):
3178         (WebCore::InspectorController::didFailLoading):
3179         * inspector/InspectorController.h:
3180         * inspector/InspectorResource.cpp:
3181         (WebCore::InspectorResource::addLength):
3182         * loader/ResourceLoadNotifier.cpp:
3183         (WebCore::ResourceLoadNotifier::didFailToLoad):
3184         (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
3185         (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
3186         (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength):
3187         (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
3188
3189 2009-11-26  Yury Semikhatsky  <yurys@chromium.org>
3190
3191         Reviewed by Pavel Feldman.
3192
3193         This is a WebCore part of the fix that allows to view plugin
3194         resources loaded by plugins.
3195
3196         https://bugs.webkit.org/show_bug.cgi?id=31832
3197
3198         * inspector/InspectorController.cpp:
3199         (WebCore::InspectorController::willSendRequest):
3200         (WebCore::InspectorController::didReceiveResponse):
3201         (WebCore::InspectorController::didReceiveContentLength):
3202         (WebCore::InspectorController::didFinishLoading):
3203         (WebCore::InspectorController::didFailLoading):
3204         * inspector/InspectorController.h: Remove unused DocumentLoader parameters from inspector methods.
3205         * inspector/InspectorResource.cpp:
3206         (WebCore::InspectorResource::addLength): Update loading end time when new data are received.
3207         * loader/ResourceLoadNotifier.cpp:
3208         (WebCore::ResourceLoadNotifier::didFailToLoad): Notify InspectorController about the failure.
3209         (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
3210         (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
3211         (WebCore::ResourceLoadNotifier::dispatchDidReceiveContentLength):
3212         (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
3213
3214 2009-11-26  Daniel Bates  <dbates@webkit.org>
3215
3216         Reviewed by Pavel Feldman.
3217
3218         https://bugs.webkit.org/show_bug.cgi?id=21554
3219
3220         Implements support for hovering over <img> src to display the height and width of that image
3221         in a tooltip. Displays both the displayable and natural dimensions of the image.
3222
3223         Test: inspector/elements-img-tooltip.html
3224
3225         * inspector/front-end/ElementsTreeOutline.js:
3226         (WebInspector.ElementsTreeElement.prototype.createTooltipForImageNode): Added.
3227         (WebInspector.ElementsTreeElement.prototype._updateTitle.callback):
3228         (WebInspector.ElementsTreeElement.prototype._updateTitle):
3229         (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):
3230         * inspector/front-end/ObjectProxy.js:
3231         (WebInspector.ObjectProxy.getPropertiesAsync): Added.
3232         * inspector/front-end/inspector.js:
3233         (WebInspector.linkifyURLAsNode): Added tooltipText argument.
3234         (WebInspector.linkifyURL): Ditto.
3235
3236 2009-11-26  Kevin Ollivier  <kevino@theolliviers.com>
3237
3238         wx build fix after drawPattern API change.
3239
3240         * platform/graphics/wx/ImageWx.cpp:
3241         (WebCore::Image::drawPattern):
3242
3243 2009-11-26  Anton Muhin  <antonm@chromium.org>
3244
3245         Reviewed by Adam Barth.
3246
3247         Use an internal field instead of hidden property to speedup lookup
3248         of entered isolated world.
3249
3250         Plus some inlinings.
3251         https://bugs.webkit.org/show_bug.cgi?id=31884
3252
3253         Covered by layout tests + manual running of some benchmarks as
3254         content scripts.
3255
3256         * bindings/v8/V8DOMWrapper.cpp:
3257         * bindings/v8/V8DOMWrapper.h:
3258         (WebCore::V8DOMWrapper::setDOMWrapper):
3259         * bindings/v8/V8HiddenPropertyName.h:
3260         * bindings/v8/V8IsolatedWorld.cpp:
3261         (WebCore::V8IsolatedWorld::V8IsolatedWorld):
3262         * bindings/v8/V8IsolatedWorld.h:
3263         (WebCore::V8IsolatedWorld::getEntered):
3264         (WebCore::V8IsolatedWorld::getGlobalObject):
3265         * bindings/v8/custom/V8CustomBinding.h:
3266
3267 2009-11-26  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3268
3269         Reviewed by Kenneth Rohde Christiansen.
3270
3271         [Qt] Corrects build break on Windows.
3272
3273         Rename platform/text/qt/TextBoundaries.cpp to TextBoundariesQt.cpp since
3274         platform/text/TextBoundaries.cpp was compiled instead when compiling with nmake.
3275
3276         * WebCore.pro:
3277         * platform/text/qt/TextBoundariesQt.cpp: Renamed from WebCore/platform/text/qt/TextBoundaries.cpp.
3278         (WebCore::findNextWordFromIndex):
3279         (WebCore::findWordBoundary):
3280
3281 2009-11-26  Anton Muhin  <antonm@chromium.org>
3282
3283         Reviewed by Adam Barth.
3284
3285         Do not check if the thread is main or not when accessing DOMDataStore as currently in Chromium WebKit is used in main thread only.
3286         https://bugs.webkit.org/show_bug.cgi?id=31877
3287
3288         Covered by layout tests and buildbots.
3289
3290         * bindings/v8/V8DOMMap.cpp:
3291         (WebCore::getDOMNodeMap):
3292         (WebCore::getDOMObjectMap):
3293         (WebCore::getActiveDOMObjectMap):
3294         (WebCore::getDOMSVGElementInstanceMap):
3295         (WebCore::getDOMSVGObjectWithContextMap):
3296
3297 2009-11-26  Girish Ramakrishnan  <girish@forwardbias.in>
3298
3299         Reviewed by Holger Freyther.
3300
3301         [Qt] Mac Plugins : Pass mouse position relative to the fake window
3302         
3303         When using off-screen rendering, we need to pass mouse events relative
3304         to the fake window instead of the global position.
3305         
3306         https://bugs.webkit.org/show_bug.cgi?id=31794
3307
3308         * plugins/mac/PluginViewMac.cpp:
3309         (WebCore::PluginView::platformStart):
3310         (WebCore::PluginView::handleMouseEvent):
3311
3312 2009-11-24  Holger Hans Peter Freyther  <zecke@selfish.org>
3313
3314         Reviewed by Eric Seidel.
3315
3316         [Qt] Use QNetworkReply::rawHeaderPairs
3317         https://bugs.webkit.org/show_bug.cgi?id=31826
3318
3319         The QNetworkReply is internally storing the HTTP headers
3320         as a list of pairs. Currently we have to ask the QNetworkReply
3321         to put all header names into a QStringList. Afterwards we will
3322         iterate over this QStringList and ask the QNetworkReply to
3323         give us the value for this header name. The current Qt implementation
3324         is doing a linear to find the header value.
3325
3326         Use a new API to directly access the list of pairs and push
3327         this into WebCore. This avoids doing some allocations and doing
3328         linear searches from within a loop.
3329
3330         * platform/network/qt/QNetworkReplyHandler.cpp:
3331         (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
3332
3333 2009-11-21  Holger Hans Peter Freyther  <zecke@selfish.org>
3334
3335         Reviewed by Kenneth Rohde Christiansen.
3336
3337         [Qt] Add Qt specific information of RenderPart
3338         https://bugs.webkit.org/show_bug.cgi?id=31203
3339
3340         The WebCore::Widget of the RenderPart (RenderWidget) might be
3341         backed with a platform widget. Print both the WebCore::Widget
3342         and platform widget state. In the above bug we had a problem
3343         that the WebCore::Widget was invisible but the QWidget was
3344         visible.
3345
3346         * rendering/RenderTreeAsText.cpp:
3347         (WebCore::operator<<): Add special case for RenderPart
3348
3349 2009-11-17  Holger Hans Peter Freyther  <zecke@selfish.org>
3350
3351         Reviewed by Kenneth Rohde Christiansen.
3352
3353         [Qt] Call Widget::setSelfVisible from hide/show
3354         https://bugs.webkit.org/show_bug.cgi?id=31203
3355
3356         Call Widget::setSelfVisible from Widget::show and
3357         Widget::hide and use isParentVisible to decide
3358         if the widget should be shown. This way client
3359         code can rely on isVisible.
3360
3361         Change PluginViewQt::show, PluginViewQt::hide to
3362         call the base class as it is doing the right thing
3363         now. Add an assert verify that platfomWidget and
3364         platformPluginWidget are the same.
3365
3366         * manual-tests/qt/qtplugin.html: Modify manual test
3367         * platform/qt/WidgetQt.cpp:
3368         (WebCore::Widget::show):
3369         (WebCore::Widget::hide):
3370         * plugins/qt/PluginViewQt.cpp:
3371         (WebCore::PluginView::show):
3372         (WebCore::PluginView::hide):
3373
3374 2009-11-24  Holger Hans Peter Freyther  <zecke@selfish.org>
3375
3376         Reviewed by Alexey Proskuryakov.
3377
3378         Fix compilation of REQUEST_DEBUG debug code
3379         https://bugs.webkit.org/show_bug.cgi?id=31850
3380
3381         In r47907 the single parameter KURL constructor to parse
3382         from a WebCore::String was replaced with a two parameter
3383         constructor. I think in this debug case parsing the urls
3384         again is no problem and I have changed the code to use the
3385         two parameter version.
3386
3387         * loader/loader.cpp:
3388         (WebCore::Loader::Host::didFinishLoading):
3389
3390 2009-11-26  Søren Gjesse  <sgjesse@chromium.org>
3391
3392         Reviewed by Pavel Feldman.
3393
3394         [V8] Avoid using JavaScript objects as context data
3395         https://bugs.webkit.org/show_bug.cgi?id=31873
3396
3397         Change the context "data" from a JavaScript object holding the two properties type and value to
3398         a string holding type and value separated by a comma.
3399
3400         * bindings/v8/V8Proxy.cpp:
3401         (WebCore::V8Proxy::setInjectedScriptContextDebugId):
3402         (WebCore::V8Proxy::setContextDebugId):
3403         (WebCore::V8Proxy::contextDebugId):
3404
3405 2009-11-25  Dimitri Glazkov  <dglazkov@chromium.org>
3406
3407         Reviewed by David Levin.
3408
3409         [Chromium] Implement canSetValueAttribute in the API, the clean-up part.
3410         https://bugs.webkit.org/show_bug.cgi?id=31894
3411
3412         * accessibility/chromium/AccessibilityObjectWrapper.h: Added RefCounted decl.
3413         (WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper): Removed mis-refcountingness.
3414
3415 2009-11-25  Kenneth Russell  <kbr@google.com>
3416
3417         Reviewed by Oliver Hunt.
3418
3419         Off-by-one error in index validation for drawElements and drawArrays
3420         https://bugs.webkit.org/show_bug.cgi?id=31891
3421
3422         Fixed computation of number of elements for bound array objects.
3423
3424         Test: fast/canvas/webgl/index-validation.html
3425
3426         * html/canvas/WebGLRenderingContext.cpp:
3427         (WebCore::WebGLRenderingContext::vertexAttribPointer):
3428
3429 2009-11-25  Dmitry Titov  <dimich@chromium.org>
3430
3431         Reviewed by David Levin.
3432
3433         Update SharedScript to use eventNames() instead of EventNames()
3434         https://bugs.webkit.org/show_bug.cgi?id=31890
3435
3436         * SharedScript/WebKitSharedScript.cpp:
3437         (WebCore::LoadEventTask::performTask):
3438
3439 2009-11-25  Eric Carlson  <eric.carlson@apple.com>
3440
3441         Reviewed by Simon Fraser.
3442
3443         <rdar://problem/7409331> Windows: Support closed caption in <video> element
3444
3445         Enable closed captions in QuickTime/Windows media engine.
3446
3447         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
3448         (WebCore::MediaPlayerPrivate::hasClosedCaptions):
3449         (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible):
3450             New, all through to m_qtMovie.
3451
3452         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
3453             Make all but the destructor private since MediaPlayer call through the media
3454             engine interface.
3455
3456         * platform/graphics/win/QTMovieWin.cpp:
3457         (QTMovieWin::disableUnsupportedTracks):
3458             Use handy new constants for QuickTime track types.
3459         (QTMovieWin::hasClosedCaptions):
3460         (QTMovieWin::setClosedCaptionsVisible):
3461             New, closed caption support.
3462         * platform/graphics/win/QTMovieWin.h:
3463
3464         * rendering/RenderMediaControls.cpp:
3465         (WebCore::RenderMediaControls::paintMediaControlsPart):
3466             Deal with closed caption buttons.
3467
3468         * rendering/RenderThemeWin.cpp:
3469         (WebCore::RenderThemeWin::shouldRenderMediaControlPart):
3470             New, don't ask the media engine if it has closed captions unless the Safari theme will
3471             be able to render the button.
3472         (WebCore::RenderThemeWin::paintMediaToggleClosedCaptionsButton):
3473             New.
3474         * rendering/RenderThemeWin.h:
3475
3476 2009-11-25  Drew Wilson  <atwilson@chromium.org>
3477
3478         Reviewed by David Levin.
3479
3480         MessagePorts always look remotely entangled even when closed.
3481         https://bugs.webkit.org/show_bug.cgi?id=31698
3482
3483         Tests: Existing tests suffice, Chromium soak test passes now.
3484
3485         * bindings/v8/custom/V8CustomBinding.h:
3486         Removed kMessagePortEntangledPortIndex which is no longer used.
3487         * bindings/v8/V8GCController.cpp:
3488         (WebCore::GCPrologueVisitor::visitDOMWrapper):
3489         Simplified GC code to reflect the Chromium MessagePort implementation
3490         (locallyEntangledPort() always returns false).
3491         (WebCore::GCEpilogueVisitor::visitDOMWrapper):
3492         Cleaned up epilogue code to handle the case where the port gets closed
3493         in mid-GC (due to the parent context being freed).
3494         * dom/MessagePort.cpp:
3495         (WebCore::MessagePort::MessagePort):
3496         (WebCore::MessagePort::close):
3497         Now sets the closed flag.
3498         (WebCore::MessagePort::disentanglePorts):
3499         Updated to use new isCloned() API instead of relying on isEntangled(), which was incorrect.
3500         * dom/MessagePort.h:
3501         Added a m_closed flag and updated isEntangled() to check it.
3502         (WebCore::MessagePort::isEntangled):
3503         Now returns false if the port has been closed.
3504         (WebCore::MessagePort::isCloned):
3505         Added new API to differentiate between cloned and closed ports (closed ports can still be passed to postMessage).
3506
3507 2009-11-25  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3508
3509         Reviewed by Simon Hausmann.
3510
3511         [Qt] Fix crash of QtWebKit on any page with Flash when compiled with MinGW.
3512
3513         Fix inline assembly, don't dereference the function pointer twice.
3514
3515         * plugins/win/PluginViewWin.cpp:
3516         (WebCore::PluginView::hookedBeginPaint):
3517         (WebCore::PluginView::hookedEndPaint):
3518
3519 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
3520
3521         Reviewed by Adam Barth.
3522
3523         [Qt] Remove the Referer header when redirecting to a non-secure site
3524         https://bugs.webkit.org/show_bug.cgi?id=31785
3525
3526         This makes Qt pass two tests introduced in r50226.
3527
3528         * platform/network/qt/QNetworkReplyHandler.cpp:
3529         (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
3530
3531 2009-11-25  Andrei Popescu  <andreip@google.com>
3532
3533         Reviewed by Dimitri Glazkov.
3534
3535         The select elements do not reflect the actual choice the user makes.
3536         https://bugs.webkit.org/show_bug.cgi?id=31831
3537
3538         Handle the drawing of the listboxes in Android code.
3539
3540         No new features, just fixing an Android problem. Existing layout tests are sufficient.
3541
3542         * platform/android/RenderThemeAndroid.cpp:
3543         (WebCore::theme):
3544         (WebCore::RenderThemeAndroid::platformActiveSelectionBackgroundColor):
3545         (WebCore::RenderThemeAndroid::platformActiveListBoxSelectionBackgroundColor):
3546         (WebCore::RenderThemeAndroid::platformInactiveListBoxSelectionBackgroundColor):
3547         (WebCore::RenderThemeAndroid::platformActiveListBoxSelectionForegroundColor):
3548         (WebCore::RenderThemeAndroid::platformInactiveListBoxSelectionForegroundColor):
3549         (WebCore::RenderThemeAndroid::adjustButtonStyle):
3550         (WebCore::RenderThemeAndroid::paintTextArea):
3551         (WebCore::RenderThemeAndroid::adjustListboxStyle):
3552         * platform/android/RenderThemeAndroid.h:
3553
3554 2009-11-25  Alexander Pavlov  <apavlov@chromium.org>
3555
3556         Reviewed by Pavel Feldman.
3557
3558         Load InspectorResource mime type from CachedResource for 304 responses
3559
3560         For network libraries that do not merge cache data into 304 ResourceResponses,
3561         the mime type for cached resources is unknown.
3562         https://bugs.webkit.org/show_bug.cgi?id=31868
3563
3564         * inspector/InspectorResource.cpp:
3565         (WebCore::InspectorResource::updateResponse):
3566         (WebCore::InspectorResource::updateScriptObject):
3567         (WebCore::InspectorResource::type):
3568
3569 2009-11-25  Andrei Popescu  <andreip@google.com>
3570
3571         Reviewed by Eric Seidel.
3572
3573         Android is missing implementation of SSL Key generator functions.
3574         https://bugs.webkit.org/show_bug.cgi?id=31825
3575
3576         This change adds the PlatformBridge class to platform/android.