1 2006-10-24 Simon Hausmann <hausmann@kde.org>
5 * CMakeLists.txt: Added project name to kde4_automoc macro, as
6 required by the latest KDE4 cmake module.
8 2006-10-24 Mitz Pettel <mitz@webkit.org>
12 - fix http://bugs.webkit.org/show_bug.cgi?id=11394
13 HTMLViewSourceDocuments are leaking
15 * html/HTMLViewSourceDocument.h: Changed RefPtr to plain pointer to avoid
18 2006-10-23 Geoffrey Garen <ggaren@apple.com>
22 Removed one of Frame's redundant urlSelected methods.
24 * bridge/mac/FrameMac.h:
25 * bridge/mac/FrameMac.mm:
26 (WebCore::FrameMac::urlSelected):
28 * html/HTMLAnchorElement.cpp:
29 (WebCore::HTMLAnchorElement::defaultEventHandler): Changed DeprecatedString
30 to String because the former is deprecated and its performance is irrelevant
31 here. Added call to completeURL because Frame no longer does it for us.
32 Having the call here also improves clarity about the element's behavior.
33 * ksvg2/svg/SVGAElement.cpp:
34 (WebCore::SVGAElement::defaultEventHandler): ditto. Also removed bizarre
35 irrelevent NULL checks on ownerDocument() because I couldn't help myself.
37 (WebCore::Frame::changeLocation):
38 (WebCore::Frame::urlSelected):
40 * platform/network/ResourceRequest.h: Removed explicit keyword on constructor
41 because we want to be able to use these constructors instead of helper functions
42 mimicking their behavior sprinkled across different classes.
43 (WebCore::ResourceRequest::ResourceRequest):
45 2006-10-24 Brady Eidson <beidson@apple.com>
49 Moved FrameLoader from WebCoreFrameBridge to Frame. Frame.h/cpp have generic accessors to the FrameLoader itself
50 and creation/deletion is currently managed in FrameMac.mm
52 Besides explicitly commented-upon methods, most of the touched code simply changes to get the FrameLoader from the
53 frame instead of the bridge.
55 The method [WebCoreFrameBridge frameLoader] remains but only for WebKit's use - No new WebCore code should make
56 use of it as its days are numbered!
58 * bridge/mac/FrameMac.mm:
59 (WebCore::FrameMac::FrameMac): Create the FrameLoader
60 (WebCore::FrameMac::~FrameMac): Nuke it
61 (WebCore::FrameMac::loadRequest):
63 * bridge/mac/WebCoreFrameBridge.h: No longer holds an m_frameLoader
64 * bridge/mac/WebCoreFrameBridge.mm:
65 (-[WebCoreFrameBridge initMainFrameWithPage:withEditorClient:]): No longer creates the FrameLoader
66 (-[WebCoreFrameBridge initSubframeWithOwnerElement:withEditorClient:]): Ditto
67 (-[WebCoreFrameBridge clearFrame]): No longer tears down the FrameLoader
68 (-[WebCoreFrameBridge setFrameLoaderClient:]):
69 (-[WebCoreFrameBridge frameLoader]):
70 (-[WebCoreFrameBridge setTitle:]):
71 (-[WebCoreFrameBridge didFirstLayout]):
72 (-[WebCoreFrameBridge notifyIconChanged:]):
73 (-[WebCoreFrameBridge originalRequestURL]):
74 (-[WebCoreFrameBridge isLoadTypeReload]):
75 (-[WebCoreFrameBridge frameDetached]):
76 (-[WebCoreFrameBridge tokenizerProcessedData]):
77 (-[WebCoreFrameBridge receivedData:textEncodingName:]):
78 (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]):
79 (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
80 (-[WebCoreFrameBridge reportClientRedirectCancelled:]):
81 (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
82 (-[WebCoreFrameBridge incomingReferrer]):
83 (-[WebCoreFrameBridge isReloading]):
84 (-[WebCoreFrameBridge handledOnloadEvents]):
85 (-[WebCoreFrameBridge mainResourceURLResponse]):
86 (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
88 * loader/mac/WebDocumentLoader.mm:
89 (WebCore::DocumentLoader::frameLoader):
91 * loader/mac/WebFrameLoader.mm:
92 (WebCore::FrameLoader::load):
93 (WebCore::FrameLoader::stopLoadingSubframes):
94 (WebCore::FrameLoader::defersCallbacksChanged):
95 (WebCore::FrameLoader::setState):
96 (WebCore::FrameLoader::closeOldDataSources):
97 (WebCore::FrameLoader::subframeIsLoading):
98 (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
99 (WebCore::FrameLoader::post):
100 (WebCore::FrameLoader::detachChildren):
101 (WebCore::FrameLoader::checkLoadComplete):
103 * loader/mac/WebLoader.mm:
104 (WebCore::WebResourceLoader::frameLoader):
106 * loader/mac/WebSubresourceLoader.mm:
107 (-[WebCoreSubresourceHandle initWithLoader:]):
110 (WebCore::Frame::frameLoader):
112 * page/FramePrivate.h:
113 (WebCore::FramePrivate::FramePrivate):
115 2006-10-24 Darin Adler <darin@apple.com>
119 - fixed two crashes in layout tests I just introduced
121 * loader/mac/WebFrameLoader.mm:
122 (WebCore::FrameLoader::load): Add null check.
123 (WebCore::FrameLoader::setState): Ditto.
125 2006-10-23 Darin Adler <darin@apple.com>
129 - converted WebDocumentLoader to C++
132 * bridge/mac/WebCoreFrameBridge.mm:
133 (-[WebCoreFrameBridge setTitle:]):
134 (-[WebCoreFrameBridge originalRequestURL]):
135 (-[WebCoreFrameBridge receivedData:textEncodingName:]):
136 (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
137 (-[WebCoreFrameBridge incomingReferrer]):
138 (-[WebCoreFrameBridge isReloading]):
139 (-[WebCoreFrameBridge mainResourceURLResponse]):
140 * loader/mac/WebDocumentLoader.h:
141 * loader/mac/WebDocumentLoader.mm:
142 (WebCore::DocumentLoader::DocumentLoader):
143 (WebCore::DocumentLoader::frameLoader):
144 (WebCore::DocumentLoader::~DocumentLoader):
145 (WebCore::DocumentLoader::setMainResourceData):
146 (WebCore::DocumentLoader::mainResourceData):
147 (WebCore::DocumentLoader::originalRequest):
148 (WebCore::DocumentLoader::originalRequestCopy):
149 (WebCore::DocumentLoader::request):
150 (WebCore::DocumentLoader::initialRequest):
151 (WebCore::DocumentLoader::actualRequest):
152 (WebCore::DocumentLoader::URL):
153 (WebCore::DocumentLoader::unreachableURL):
154 (WebCore::DocumentLoader::replaceRequestURLForAnchorScroll):
155 (WebCore::DocumentLoader::setRequest):
156 (WebCore::DocumentLoader::setResponse):
157 (WebCore::DocumentLoader::isStopping):
158 (WebCore::DocumentLoader::bridge):
159 (WebCore::DocumentLoader::setMainDocumentError):
160 (WebCore::DocumentLoader::mainDocumentError):
161 (WebCore::DocumentLoader::clearErrors):
162 (WebCore::DocumentLoader::mainReceivedError):
163 (WebCore::DocumentLoader::stopLoading):
164 (WebCore::DocumentLoader::setupForReplace):
165 (WebCore::DocumentLoader::commitIfReady):
166 (WebCore::DocumentLoader::finishedLoading):
167 (WebCore::DocumentLoader::setCommitted):
168 (WebCore::DocumentLoader::isCommitted):
169 (WebCore::DocumentLoader::setLoading):
170 (WebCore::DocumentLoader::isLoading):
171 (WebCore::DocumentLoader::commitLoad):
172 (WebCore::DocumentLoader::doesProgressiveLoad):
173 (WebCore::DocumentLoader::receivedData):
174 (WebCore::DocumentLoader::setupForReplaceByMIMEType):
175 (WebCore::DocumentLoader::updateLoading):
176 (WebCore::DocumentLoader::response):
177 (WebCore::DocumentLoader::setFrame):
178 (WebCore::DocumentLoader::attachToFrame):
179 (WebCore::DocumentLoader::detachFromFrame):
180 (WebCore::DocumentLoader::prepareForLoadStart):
181 (WebCore::DocumentLoader::loadingStartedTime):
182 (WebCore::DocumentLoader::setIsClientRedirect):
183 (WebCore::DocumentLoader::isClientRedirect):
184 (WebCore::DocumentLoader::setPrimaryLoadComplete):
185 (WebCore::DocumentLoader::isLoadingInAPISense):
186 (WebCore::DocumentLoader::addResponse):
187 (WebCore::DocumentLoader::stopRecordingResponses):
188 (WebCore::DocumentLoader::title):
189 (WebCore::DocumentLoader::setLastCheckedRequest):
190 (WebCore::DocumentLoader::lastCheckedRequest):
191 (WebCore::DocumentLoader::triggeringAction):
192 (WebCore::DocumentLoader::setTriggeringAction):
193 (WebCore::DocumentLoader::responses):
194 (WebCore::DocumentLoader::setOverrideEncoding):
195 (WebCore::DocumentLoader::overrideEncoding):
196 (WebCore::DocumentLoader::setTitle):
197 (WebCore::DocumentLoader::URLForHistory):
198 * loader/mac/WebFrameLoader.h:
199 * loader/mac/WebFrameLoader.mm:
200 (WebCore::FrameLoader::setupForReplaceByMIMEType):
201 (WebCore::FrameLoader::finalSetupForReplace):
202 (WebCore::FrameLoader::safeLoad):
203 (WebCore::FrameLoader::load):
204 (WebCore::FrameLoader::startLoading):
205 (WebCore::FrameLoader::stopLoading):
206 (WebCore::FrameLoader::activeDocumentLoader):
207 (WebCore::FrameLoader::addPlugInStreamLoader):
208 (WebCore::FrameLoader::removePlugInStreamLoader):
209 (WebCore::FrameLoader::addSubresourceLoader):
210 (WebCore::FrameLoader::removeSubresourceLoader):
211 (WebCore::FrameLoader::setDocumentLoader):
212 (WebCore::FrameLoader::documentLoader):
213 (WebCore::FrameLoader::setPolicyDocumentLoader):
214 (WebCore::FrameLoader::provisionalDocumentLoader):
215 (WebCore::FrameLoader::setProvisionalDocumentLoader):
216 (WebCore::FrameLoader::setState):
217 (WebCore::FrameLoader::clearProvisionalLoad):
218 (WebCore::FrameLoader::commitProvisionalLoad):
219 (WebCore::FrameLoader::didReceiveResponse):
220 (WebCore::FrameLoader::originalRequest):
221 (WebCore::FrameLoader::receivedMainResourceError):
222 (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
223 (WebCore::FrameLoader::opened):
224 (WebCore::FrameLoader::initialRequest):
225 (WebCore::FrameLoader::receivedData):
226 (WebCore::FrameLoader::setRequest):
227 (WebCore::FrameLoader::isStopping):
228 (WebCore::FrameLoader::setResponse):
229 (WebCore::FrameLoader::mainReceivedError):
230 (WebCore::FrameLoader::finishedLoading):
231 (WebCore::FrameLoader::notifyIconChanged):
232 (WebCore::FrameLoader::URL):
233 (WebCore::FrameLoader::checkContentPolicy):
234 (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL):
235 (WebCore::FrameLoader::reloadAllowingStaleData):
236 (WebCore::FrameLoader::reload):
237 (WebCore::FrameLoader::finishedLoadingDocument):
238 (WebCore::FrameLoader::committedLoad):
239 (WebCore::FrameLoader::revertToProvisional):
240 (WebCore::FrameLoader::setMainDocumentError):
241 (WebCore::FrameLoader::mainReceivedCompleteError):
242 (WebCore::FrameLoader::subframeIsLoading):
243 (WebCore::FrameLoader::willChangeTitle):
244 (WebCore::FrameLoader::didChangeTitle):
245 (WebCore::FrameLoader::checkNavigationPolicy):
246 (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy):
247 (WebCore::FrameLoader::transitionToCommitted):
248 (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
249 (WebCore::FrameLoader::detachFromParent):
250 * loader/mac/WebFrameLoaderClient.h:
252 2006-10-23 Brady Eidson <beidson@apple.com>
254 Lovingly reviewed by Maciej
256 Moved loadURL and postURL logic out of WebCoreFrameBridge to FrameMac::loadRequest
257 This is a big step towards moving FrameLoader out of the Bridge into Frame/Mac itself
259 * bridge/mac/BrowserExtensionMac.mm:
260 (WebCore::BrowserExtensionMac::createNewWindow): Use FrameMac::loadRequest
262 * bridge/mac/FrameMac.mm:
263 (WebCore::FrameMac::loadRequest): loadURL and postURL logic moved from WebCoreFrameBridge to here
265 * bridge/mac/WebCoreFrameBridge.h: Nuked loadURL and postURL
266 * bridge/mac/WebCoreFrameBridge.mm: Ditto
267 * loader/mac/WebFrameLoader.mm:
268 (-[WebFrameLoader safeLoadURL:]): Use FrameMac::loadRequest
270 2006-10-23 Geoffrey Garen <ggaren@apple.com>
274 Inside Frame, moved the plethora of load() and stopLoading() functions next
275 to each other to facilitate merging and crying.
277 * bridge/mac/FrameMac.h:
278 * bridge/mac/FrameMac.mm:
279 (WebCore::FrameMac::loadRequest):
280 (WebCore::FrameMac::submitForm):
281 (WebCore::FrameMac::openURL):
282 (WebCore::FrameMac::openURLRequest):
283 (WebCore::FrameMac::urlSelected):
284 (WebCore::FrameMac::openURLFromPageCache):
285 (WebCore::FrameMac::createFrame):
287 (WebCore::Frame::openURL):
288 (WebCore::Frame::changeLocation):
289 (WebCore::Frame::urlSelected):
290 (WebCore::Frame::requestFrame):
291 (WebCore::Frame::loadSubframe):
292 (WebCore::Frame::submitFormAgain):
293 (WebCore::Frame::submitForm):
294 (WebCore::Frame::stop):
295 (WebCore::Frame::closeURL):
296 (WebCore::Frame::cancelRedirection):
297 (WebCore::Frame::iconURL):
298 (WebCore::Frame::didOpenURL):
299 (WebCore::Frame::didExplicitOpen):
302 2006-10-23 Geoffrey Garen <ggaren@apple.com>
306 Moved our plethora of load() and stopLoading() functions next to each other
307 to facilitate merging and laughter.
309 * loader/mac/WebFrameLoader.h:
310 * loader/mac/WebFrameLoader.mm:
311 (WebCore::cancelAll):
312 (WebCore::FrameLoader::prepareForLoadStart):
313 (WebCore::FrameLoader::setupForReplace):
314 (WebCore::FrameLoader::setupForReplaceByMIMEType):
315 (WebCore::FrameLoader::finalSetupForReplace):
316 (WebCore::FrameLoader::safeLoad):
317 (WebCore::FrameLoader::load):
318 (WebCore::FrameLoader::startLoadingMainResource):
319 (WebCore::FrameLoader::startLoading):
320 (WebCore::FrameLoader::stopLoadingPlugIns):
321 (WebCore::FrameLoader::stopLoadingSubresources):
322 (WebCore::FrameLoader::stopLoading):
323 (WebCore::FrameLoader::stopLoadingSubframes):
324 (WebCore::FrameLoader::cancelMainResourceLoad):
325 (WebCore::FrameLoader::cancelPendingArchiveLoad):
326 (WebCore::FrameLoader::removeSubresourceLoader):
327 (WebCore::FrameLoader::mainResourceData):
328 (WebCore::FrameLoader::releaseMainResourceLoader):
330 2006-10-23 Darin Adler <darin@apple.com>
334 - converted WebFrameLoader to C++
336 * WebCore.exp: Added many new entry points for WebKit.
337 * WebCore.xcodeproj/project.pbxproj: Made more files private (SPI).
339 * bridge/mac/WebCoreFrameBridge.h:
340 * bridge/mac/WebCoreFrameBridge.mm:
341 (-[WebCoreFrameBridge initMainFrameWithPage:withEditorClient:]):
342 (-[WebCoreFrameBridge initSubframeWithOwnerElement:withEditorClient:]):
343 (-[WebCoreFrameBridge dealloc]):
344 (-[WebCoreFrameBridge close]):
345 (-[WebCoreFrameBridge clearFrame]):
346 (-[WebCoreFrameBridge setFrameLoaderClient:]):
347 (-[WebCoreFrameBridge frameLoader]):
348 (-[WebCoreFrameBridge setTitle:]):
349 (-[WebCoreFrameBridge didFirstLayout]):
350 (-[WebCoreFrameBridge notifyIconChanged:]):
351 (-[WebCoreFrameBridge originalRequestURL]):
352 (-[WebCoreFrameBridge isLoadTypeReload]):
353 (-[WebCoreFrameBridge frameDetached]):
354 (-[WebCoreFrameBridge tokenizerProcessedData]):
355 (-[WebCoreFrameBridge receivedData:textEncodingName:]):
356 (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
357 (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]):
358 (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
359 (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
360 (-[WebCoreFrameBridge reportClientRedirectCancelled:]):
361 (-[WebCoreFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):
362 (-[WebCoreFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
363 (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
364 (-[WebCoreFrameBridge incomingReferrer]):
365 (-[WebCoreFrameBridge isReloading]):
366 (-[WebCoreFrameBridge handledOnloadEvents]):
367 (-[WebCoreFrameBridge mainResourceURLResponse]):
368 (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
369 * loader/mac/WebDocumentLoader.h:
370 * loader/mac/WebDocumentLoader.mm:
371 (-[WebDocumentLoader frameLoader]):
372 (-[WebDocumentLoader dealloc]):
373 (-[WebDocumentLoader mainResourceData]):
374 (-[WebDocumentLoader setRequest:]):
375 (-[WebDocumentLoader bridge]):
376 (-[WebDocumentLoader setMainDocumentError:]):
377 (-[WebDocumentLoader mainReceivedError:complete:]):
378 (-[WebDocumentLoader stopLoading]):
379 (-[WebDocumentLoader setupForReplace]):
380 (-[WebDocumentLoader commitIfReady]):
381 (-[WebDocumentLoader finishedLoading]):
382 (-[WebDocumentLoader commitLoadWithData:]):
383 (-[WebDocumentLoader doesProgressiveLoadWithMIMEType:]):
384 (-[WebDocumentLoader setupForReplaceByMIMEType:]):
385 (-[WebDocumentLoader updateLoading]):
386 (-[WebDocumentLoader setFrame:]):
387 (-[WebDocumentLoader attachToFrame]):
388 (-[WebDocumentLoader detachFromFrame]):
389 (-[WebDocumentLoader prepareForLoadStart]):
390 (-[WebDocumentLoader setPrimaryLoadComplete:]):
391 (-[WebDocumentLoader isLoadingInAPISense]):
392 (-[WebDocumentLoader setTitle:]):
393 * loader/mac/WebFrameLoader.h:
394 (WebCore::FrameLoader::frame):
395 * loader/mac/WebFrameLoader.mm:
396 (WebCore::FrameLoader::FrameLoader):
397 (WebCore::FrameLoader::~FrameLoader):
398 (WebCore::FrameLoader::activeDocumentLoader):
399 (WebCore::FrameLoader::addPlugInStreamLoader):
400 (WebCore::FrameLoader::removePlugInStreamLoader):
401 (WebCore::FrameLoader::defersCallbacksChanged):
402 (WebCore::FrameLoader::defersCallbacks):
403 (WebCore::setAllDefersCallbacks):
404 (WebCore::FrameLoader::setDefersCallbacks):
405 (WebCore::cancelAll):
406 (WebCore::FrameLoader::stopLoadingPlugIns):
407 (WebCore::FrameLoader::isLoadingMainResource):
408 (WebCore::FrameLoader::isLoadingSubresources):
409 (WebCore::FrameLoader::isLoadingPlugIns):
410 (WebCore::FrameLoader::isLoading):
411 (WebCore::FrameLoader::stopLoadingSubresources):
412 (WebCore::FrameLoader::addSubresourceLoader):
413 (WebCore::FrameLoader::removeSubresourceLoader):
414 (WebCore::FrameLoader::mainResourceData):
415 (WebCore::FrameLoader::releaseMainResourceLoader):
416 (WebCore::FrameLoader::cancelMainResourceLoad):
417 (WebCore::FrameLoader::startLoadingMainResource):
418 (WebCore::FrameLoader::stopLoading):
419 (WebCore::FrameLoader::setDocumentLoader):
420 (WebCore::FrameLoader::documentLoader):
421 (WebCore::FrameLoader::setPolicyDocumentLoader):
422 (WebCore::FrameLoader::provisionalDocumentLoader):
423 (WebCore::FrameLoader::setProvisionalDocumentLoader):
424 (WebCore::FrameLoader::state):
425 (WebCore::FrameLoader::timeOfLastCompletedLoad):
426 (WebCore::FrameLoader::provisionalLoadStarted):
427 (WebCore::FrameLoader::setState):
428 (WebCore::FrameLoader::clearProvisionalLoad):
429 (WebCore::FrameLoader::markLoadComplete):
430 (WebCore::FrameLoader::commitProvisionalLoad):
431 (WebCore::FrameLoader::stopLoadingSubframes):
432 (WebCore::FrameLoader::startLoading):
433 (WebCore::FrameLoader::setupForReplace):
434 (WebCore::FrameLoader::identifierForInitialRequest):
435 (WebCore::FrameLoader::willSendRequest):
436 (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
437 (WebCore::FrameLoader::didCancelAuthenticationChallenge):
438 (WebCore::FrameLoader::didReceiveResponse):
439 (WebCore::FrameLoader::didReceiveData):
440 (WebCore::FrameLoader::didFinishLoad):
441 (WebCore::FrameLoader::didFailToLoad):
442 (WebCore::FrameLoader::privateBrowsingEnabled):
443 (WebCore::FrameLoader::originalRequest):
444 (WebCore::FrameLoader::receivedMainResourceError):
445 (WebCore::FrameLoader::clientRedirectCancelledOrFinished):
446 (WebCore::FrameLoader::clientRedirected):
447 (WebCore::FrameLoader::shouldReload):
448 (WebCore::FrameLoader::load):
449 (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
450 (WebCore::FrameLoader::closeOldDataSources):
451 (WebCore::FrameLoader::opened):
452 (WebCore::FrameLoader::initialRequest):
453 (WebCore::FrameLoader::receivedData):
454 (WebCore::FrameLoader::setRequest):
455 (WebCore::FrameLoader::download):
456 (WebCore::FrameLoader::bridge):
457 (WebCore::FrameLoader::handleFallbackContent):
458 (WebCore::FrameLoader::isStopping):
459 (WebCore::FrameLoader::setupForReplaceByMIMEType):
460 (WebCore::FrameLoader::setResponse):
461 (WebCore::FrameLoader::mainReceivedError):
462 (WebCore::FrameLoader::finishedLoading):
463 (WebCore::FrameLoader::notifyIconChanged):
464 (WebCore::FrameLoader::URL):
465 (WebCore::FrameLoader::cancelledError):
466 (WebCore::FrameLoader::fileDoesNotExistError):
467 (WebCore::FrameLoader::willUseArchive):
468 (WebCore::FrameLoader::isArchiveLoadPending):
469 (WebCore::FrameLoader::cancelPendingArchiveLoad):
470 (WebCore::FrameLoader::handleUnimplementablePolicy):
471 (WebCore::FrameLoader::cannotShowMIMEType):
472 (WebCore::FrameLoader::interruptionForPolicyChangeError):
473 (WebCore::FrameLoader::isHostedByObjectElement):
474 (WebCore::FrameLoader::isLoadingMainFrame):
475 (WebCore::FrameLoader::canShowMIMEType):
476 (WebCore::FrameLoader::representationExistsForURLScheme):
477 (WebCore::FrameLoader::generatedMIMETypeForURLScheme):
478 (WebCore::FrameLoader::checkNavigationPolicy):
479 (WebCore::FrameLoader::checkContentPolicy):
480 (WebCore::FrameLoader::cancelContentPolicyCheck):
481 (WebCore::FrameLoader::shouldReloadToHandleUnreachableURL):
482 (WebCore::FrameLoader::reloadAllowingStaleData):
483 (WebCore::FrameLoader::reload):
484 (WebCore::FrameLoader::didReceiveServerRedirectForProvisionalLoadForFrame):
485 (WebCore::FrameLoader::finishedLoadingDocument):
486 (WebCore::FrameLoader::committedLoad):
487 (WebCore::FrameLoader::isReplacing):
488 (WebCore::FrameLoader::setReplacing):
489 (WebCore::FrameLoader::revertToProvisional):
490 (WebCore::FrameLoader::setMainDocumentError):
491 (WebCore::FrameLoader::mainReceivedCompleteError):
492 (WebCore::FrameLoader::finalSetupForReplace):
493 (WebCore::FrameLoader::prepareForLoadStart):
494 (WebCore::FrameLoader::subframeIsLoading):
495 (WebCore::FrameLoader::willChangeTitle):
496 (WebCore::FrameLoader::didChangeTitle):
497 (WebCore::FrameLoader::loadType):
498 (WebCore::FrameLoader::invalidatePendingPolicyDecision):
499 (WebCore::FrameLoader::checkNewWindowPolicy):
500 (WebCore::FrameLoader::continueAfterNewWindowPolicy):
501 (WebCore::FrameLoader::continueAfterNavigationPolicy):
502 (WebCore::FrameLoader::continueAfterWillSubmitForm):
503 (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy):
504 (WebCore::FrameLoader::didFirstLayout):
505 (WebCore::FrameLoader::frameLoadCompleted):
506 (WebCore::FrameLoader::firstLayoutDone):
507 (WebCore::FrameLoader::isQuickRedirectComing):
508 (WebCore::FrameLoader::transitionToCommitted):
509 (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
510 (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
511 (WebCore::FrameLoader::sendRemainingDelegateMessages):
512 (WebCore::FrameLoader::requestFromDelegate):
513 (WebCore::FrameLoader::post):
514 (WebCore::FrameLoader::detachChildren):
515 (WebCore::FrameLoader::detachFromParent):
516 (WebCore::FrameLoader::addExtraFieldsToRequest):
517 (WebCore::FrameLoader::safeLoad):
518 (WebCore::FrameLoader::actionInformation):
519 (WebCore::FrameLoader::checkLoadComplete):
520 (WebCore::FrameLoader::setFrameLoaderClient):
521 (WebCore::FrameLoader::client):
522 (WebCore::FrameLoader::asDelegate):
523 (-[WebCoreFrameLoaderAsDelegate initWithLoader:]):
524 (-[WebCoreFrameLoaderAsDelegate detachFromLoader]):
525 (-[WebCoreFrameLoaderAsDelegate continueFragmentScrollAfterNavigationPolicy:formState:]):
526 (-[WebCoreFrameLoaderAsDelegate continueAfterNewWindowPolicy:]):
527 (-[WebCoreFrameLoaderAsDelegate continueAfterNavigationPolicy:]):
528 (-[WebCoreFrameLoaderAsDelegate continueAfterWillSubmitForm:]):
529 (-[WebCoreFrameLoaderAsDelegate continueLoadRequestAfterNavigationPolicy:formState:]):
530 (-[WebCoreFrameLoaderAsDelegate continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
531 * loader/mac/WebLoader.h:
532 (WebCore::WebResourceLoader::identifier):
533 (WebCore::WebResourceLoader::reachedTerminalState):
534 (WebCore::WebResourceLoader::cancelled):
535 * loader/mac/WebLoader.mm:
536 (WebCore::WebResourceLoader::WebResourceLoader):
537 (WebCore::WebResourceLoader::releaseResources):
538 (WebCore::WebResourceLoader::load):
539 (WebCore::WebResourceLoader::frameLoader):
540 (WebCore::WebResourceLoader::willSendRequest):
541 (WebCore::WebResourceLoader::didReceiveAuthenticationChallenge):
542 (WebCore::WebResourceLoader::didCancelAuthenticationChallenge):
543 (WebCore::WebResourceLoader::didReceiveResponse):
544 (WebCore::WebResourceLoader::didReceiveData):
545 (WebCore::WebResourceLoader::didFinishLoading):
546 (WebCore::WebResourceLoader::didFinishLoadingOnePart):
547 (WebCore::WebResourceLoader::didFail):
548 (WebCore::WebResourceLoader::willCacheResponse):
549 (WebCore::WebResourceLoader::didCancel):
550 (WebCore::WebResourceLoader::cancel):
551 (WebCore::WebResourceLoader::cancelledError):
552 (WebCore::WebResourceLoader::delegate):
553 * loader/mac/WebMainResourceLoader.h:
554 * loader/mac/WebMainResourceLoader.mm:
555 (WebCore::MainResourceLoader::MainResourceLoader):
556 (WebCore::MainResourceLoader::create):
557 (WebCore::MainResourceLoader::receivedError):
558 (WebCore::MainResourceLoader::didCancel):
559 (WebCore::MainResourceLoader::interruptionForPolicyChangeError):
560 (WebCore::MainResourceLoader::isPostOrRedirectAfterPost):
561 (WebCore::MainResourceLoader::addData):
562 (WebCore::MainResourceLoader::willSendRequest):
563 (WebCore::MainResourceLoader::continueAfterContentPolicy):
564 (WebCore::MainResourceLoader::didReceiveResponse):
565 (WebCore::MainResourceLoader::didReceiveData):
566 (WebCore::MainResourceLoader::didFinishLoading):
567 (WebCore::MainResourceLoader::didFail):
568 (WebCore::MainResourceLoader::loadNow):
569 (WebCore::MainResourceLoader::policyDelegate):
570 * loader/mac/WebNetscapePlugInStreamLoader.h:
571 * loader/mac/WebNetscapePlugInStreamLoader.mm:
572 (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
573 (WebCore::NetscapePlugInStreamLoader::create):
574 (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
575 (WebCore::NetscapePlugInStreamLoader::didFinishLoading):
576 (WebCore::NetscapePlugInStreamLoader::didFail):
577 (WebCore::NetscapePlugInStreamLoader::didCancel):
578 * loader/mac/WebSubresourceLoader.h:
579 * loader/mac/WebSubresourceLoader.mm:
580 (-[WebCoreSubresourceHandle initWithLoader:]):
582 2006-10-23 Geoffrey Garen <ggaren@apple.com>
586 Shrunk BrowserExtension in preparation for its imminent death, moving page-
587 level operations to Page and frame-level operations to Frame.
589 Removed bizarre Mac(this) syntax inside virtual FrameMac member functions,
590 because 'this' is guaranteed by the compiler to be a FrameMac*.
592 * bindings/js/kjs_window.cpp: Added NULL checks for m_frame in places
593 where it can be NULL.
594 * bindings/js/kjs_window.cpp:
595 (KJS::canShowModalDialog):
596 (KJS::canShowModalDialogNow):
597 (KJS::showModalDialog):
598 (KJS::History::getValueProperty):
599 (KJS::HistoryFunc::callAsFunction):
600 * bridge/BrowserExtension.h:
601 (WebCore::BrowserExtension::~BrowserExtension):
602 * bridge/mac/BrowserExtensionMac.h:
603 * bridge/mac/BrowserExtensionMac.mm:
604 (WebCore::BrowserExtensionMac::createNewWindow):
605 * bridge/mac/FrameMac.h:
606 * bridge/mac/FrameMac.mm:
607 (WebCore::FrameMac::frameDetached):
608 (WebCore::FrameMac::unfocusWindow):
609 (WebCore::FrameMac::bridgeForWidget):
610 (WebCore::FrameMac::documentViewForNode):
611 (WebCore::FrameMac::passSubframeEventToSubframe):
612 (WebCore::Frame::setNeedsReapplyStyles):
613 (WebCore::FrameMac::customHighlightLineRect):
614 (WebCore::FrameMac::paintCustomHighlight):
615 (WebCore::FrameMac::getHistoryLength):
616 (WebCore::FrameMac::goBackOrForward):
617 (WebCore::FrameMac::historyURL):
618 * bridge/mac/PageMac.mm:
619 (WebCore::Page::canRunModal):
620 (WebCore::Page::canRunModalNow):
621 (WebCore::Page::runModal):
622 * bridge/mac/WebCoreFrameBridge.h:
623 * bridge/mac/WebCorePageBridge.h:
624 * bridge/win/BrowserExtensionWin.h:
626 (WebCore::Frame::scheduleHistoryNavigation):
627 (WebCore::Frame::redirectionTimerFired):
631 2006-10-23 Justin Garcia <justin.garcia@apple.com>
635 <http://bugs.webkit.org/show_bug.cgi?id=11334>
636 Writely Editor: Placing caret in a list "highlights" both Numbered List and Bulleted List toolbar icons
638 * WebCore.xcodeproj/project.pbxproj:
639 * editing/Editor.cpp:
640 (WebCore::Editor::selectionUnorderedListState): Added.
641 (WebCore::Editor::selectionOrderedListState): Added.
643 * editing/JSEditor.cpp:
647 2006-10-23 John Sullivan <sullivan@apple.com>
651 * WebCore.xcodeproj/project.pbxproj:
652 Include WebCorePrefix.h in Xcode project for convenience and for consistency with WebKit
654 2006-10-23 Sam Weinig <sam.weinig@gmail.com>
658 Patch for http://bugs.webkit.org/show_bug.cgi?id=11291
659 PNG as cursor image format instead of TIFF
661 Original patch by Lars Naesbye Christensen (larsnaesbye@stud.ku.dk)
663 - Convert cursor images from TIFF to PNG.
665 * Resources/eastResizeCursor.png: Added.
666 * Resources/eastResizeCursor.tiff: Removed.
667 * Resources/eastWestResizeCursor.png: Added.
668 * Resources/eastWestResizeCursor.tiff: Removed.
669 * Resources/helpCursor.png: Added.
670 * Resources/helpCursor.tiff: Removed.
671 * Resources/linkCursor.png: Added.
672 * Resources/linkCursor.tiff: Removed.
673 * Resources/moveCursor.png: Added.
674 * Resources/moveCursor.tiff: Removed.
675 * Resources/northEastResizeCursor.png: Added.
676 * Resources/northEastResizeCursor.tiff: Removed.
677 * Resources/northEastSouthWestResizeCursor.png: Added.
678 * Resources/northEastSouthWestResizeCursor.tiff: Removed.
679 * Resources/northResizeCursor.png: Added.
680 * Resources/northResizeCursor.tiff: Removed.
681 * Resources/northSouthResizeCursor.png: Added.
682 * Resources/northSouthResizeCursor.tiff: Removed.
683 * Resources/northWestResizeCursor.png: Added.
684 * Resources/northWestResizeCursor.tiff: Removed.
685 * Resources/northWestSouthEastResizeCursor.png: Added.
686 * Resources/northWestSouthEastResizeCursor.tiff: Removed.
687 * Resources/southEastResizeCursor.png: Added.
688 * Resources/southEastResizeCursor.tiff: Removed.
689 * Resources/southResizeCursor.png: Added.
690 * Resources/southResizeCursor.tiff: Removed.
691 * Resources/southWestResizeCursor.png: Added.
692 * Resources/southWestResizeCursor.tiff: Removed.
693 * Resources/waitCursor.png: Added.
694 * Resources/waitCursor.tiff: Removed.
695 * Resources/westResizeCursor.png: Added.
696 * Resources/westResizeCursor.tiff: Removed.
697 * WebCore.xcodeproj/project.pbxproj:
698 * platform/mac/CursorMac.mm:
699 (WebCore::leakNamedCursor):
701 2006-10-23 Maciej Stachowiak <mjs@apple.com>
705 - fixed build from last change.
707 * bridge/mac/FrameMac.h:
708 * bridge/mac/FrameMac.mm:
709 (WebCore::FrameMac::loadRequest):
710 (WebCore::FrameMac::openURL):
712 2006-10-23 Adam Roben <aroben@apple.com>
716 Move border-radius rule for <select>s into RenderThemeMac, as this is
717 really a platform-specific look.
720 * rendering/RenderThemeMac.mm:
721 (WebCore::RenderThemeMac::adjustMenuListButtonStyle):
723 2006-10-23 Maciej Stachowiak <mjs@apple.com>
727 - moved things around so loadURL:... is only called from one place
729 * bridge/mac/FrameMac.h:
730 * bridge/mac/FrameMac.mm:
731 (WebCore::FrameMac::frameDetached):
732 (WebCore::FrameMac::loadRequest):
733 (WebCore::FrameMac::submitForm):
734 (WebCore::FrameMac::openURL):
735 (WebCore::FrameMac::openURLRequest):
736 (WebCore::FrameMac::urlSelected):
738 2006-10-23 Justin Garcia <justin.garcia@apple.com>
742 <http://bugs.webkit.org/show_bug.cgi?id=11333>
743 Writely Editor: After inserting a HR element, pressing return key creates a copy of this HR element in the document
745 Added special cases in InsertLineBreakCommand for inserting before
746 and after tables and horizontal rules. Also, perform InsertLineBreak
747 instead of InsertParagraphSeparator at these positions.
749 * editing/InsertLineBreakCommand.cpp:
750 (WebCore::InsertLineBreakCommand::doApply): Use the canonical form
751 of the caret position when we check for the new special cases because
752 we know that we canonicalize VisiblePositions to those positions.
753 Added code to handle inserting before/after tables and horizontal rules.
754 Fixed a bug when inserting at the end of a block (it checked for a collapse
755 of the inserted br by looking for the absence of a br, but the line break
756 might have been a '\n' in white-space:pre text). Removed unused LOGs.
757 * editing/InsertParagraphSeparatorCommand.cpp:
758 (WebCore::InsertParagraphSeparatorCommand::doApply): Perform an
759 InsertLineBreakCommand when before/after a table or a horizontal rule
760 so that we don't have to maintain two pieces of special case code.
761 Migrated to enclosingBlock.
762 * editing/htmlediting.cpp: Added a FIXME.
763 * editing/visible_units.cpp:
764 (WebCore::startOfParagraph): Added a workaround for 8622.
766 2006-10-23 Adam Roben <aroben@apple.com>
770 Make popups a little more flexible.
772 * platform/PopupMenu.h:
774 2006-10-23 Sam Weinig <sam.weinig@gmail.com>
778 Cleanup CodeGeneratorJS.pm
780 * bindings/scripts/CodeGeneratorJS.pm:
782 2006-10-23 Adam Roben <aroben@apple.com>
784 Rubberstamped by Brady.
786 * loader/icon/IconLoader.h: Changed angle-brackets to quotes for
787 #include of ResourceLoader.h, since it's a WebCore header.
789 2006-10-23 Darin Adler <darin@apple.com>
791 - fixed mistake that was preventing any loading from happening
793 * platform/network/ResourceLoaderClient.h: (WebCore::ResourceLoaderClient::didReceiveData):
794 Changed parameter back to int. Perhaps we want to move to "long long" consistently, but
795 I'll leave that up to Maciej.
797 2006-10-23 Maciej Stachowiak <mjs@apple.com>
801 - start converting ResourceLoaderClient to new API
803 Did the bits I could do without introducing new types:
805 - renamed receivedData to didReceiveData
806 - renamed version of receivedAllData that doesn't pass any data to didFinishLoading
808 * bridge/mac/WebCoreResourceLoaderImp.mm:
809 (-[WebCoreResourceLoaderImp addData:]):
810 (-[WebCoreResourceLoaderImp finishJobAndHandle:]):
811 * loader/icon/IconLoader.cpp:
812 (IconLoader::didReceiveData):
813 (IconLoader::didFinishLoading):
814 * loader/icon/IconLoader.h:
816 (WebCore::Loader::didReceiveData):
818 * platform/gdk/FrameGdk.cpp:
819 (WebCore::FrameGdkClientDefault::didReceiveData):
820 * platform/gdk/FrameGdk.h:
821 * platform/network/ResourceLoaderClient.h:
822 (WebCore::ResourceLoaderClient::didReceiveData):
823 (WebCore::ResourceLoaderClient::didFinishLoading):
824 (WebCore::ResourceLoaderClient::receivedResponse):
825 * platform/network/cf/ResourceLoaderCFNet.cpp:
826 (WebCore::didReceiveData):
827 (WebCore::didFinishLoading):
829 (WebCore::ResourceLoader::cancel):
830 * platform/network/gdk/ResourceLoaderManager.cpp:
831 (WebCore::writeCallback):
832 (WebCore::ResourceLoaderManager::downloadTimerCallback):
833 (WebCore::ResourceLoaderManager::remove):
834 * platform/network/qt/ResourceLoaderManager.cpp:
835 (WebCore::ResourceLoaderManager::slotData):
836 (WebCore::ResourceLoaderManager::remove):
837 * platform/network/win/ResourceLoaderWin.cpp:
838 (WebCore::ResourceLoader::onRequestComplete):
839 (WebCore::ResourceLoader::fileLoadTimer):
840 (WebCore::ResourceLoader::cancel):
841 * platform/qt/FrameQtClient.cpp:
842 (WebCore::FrameQtClientDefault::didReceiveData):
843 * platform/qt/FrameQtClient.h:
844 * xml/xmlhttprequest.cpp:
845 (WebCore::XMLHttpRequest::processSyncLoadResults):
846 (WebCore::XMLHttpRequest::didFinishLoading):
847 (WebCore::XMLHttpRequest::didReceiveData):
848 * xml/xmlhttprequest.h:
850 2006-10-23 Maciej Stachowiak <mjs@apple.com>
852 Rubber stamped by Anders.
854 - marked files executable
856 * ksvg2/scripts/csscssmakeprops:
857 * ksvg2/scripts/csscssmakevalues:
859 2006-10-22 Maciej Stachowiak <mjs@apple.com>
863 - moved ResourceLoader and related files to platform/network
864 in preparation for building out this API.
866 I tried to update all the build systems but I'm not sure they are
869 * page/ResourceRequest.h: Moved to platform/network.
870 * platform/ResourceLoader.cpp: Moved to platform/network.
871 * platform/ResourceLoader.h: Moved to platform/network.
872 * platform/ResourceLoaderClient.h: Moved to platform/network.
873 * platform/ResourceLoaderInternal.h: Moved to platform/network.
874 * platform/cf/ResourceLoaderCFNet.cpp: Moved to platform/network/cf.
875 * platform/gdk/ResourceLoaderCurl.cpp: Moved to platform/network/gdk.
876 * platform/gdk/ResourceLoaderManager.cpp: Moved to platform/network/gdk.
877 * platform/gdk/ResourceLoaderManager.h: Moved to platform/network/gdk.
878 * platform/mac/ResourceLoaderMac.mm: Moved to platform/network/mac.
879 * platform/qt/ResourceLoaderManager.cpp: Moved to platform/network/qt.
880 * platform/qt/ResourceLoaderManager.h: Moved to platform/network/qt.
881 * platform/qt/ResourceLoaderQt.cpp: Moved to platform/network/qt.
882 * platform/win/ResourceLoaderWin.cpp: Moved to platform/network/win.
883 * platform/win/ResourceLoaderWin.h: Moved to platform/network/win.
884 * webcore-base.bkl: Updated for new paths.
885 * CMakeLists.txt: ditto
886 * Projects/gdk/webcore-gdk.bkl: ditto
887 * WebCore.xcodeproj/project.pbxproj: ditto
888 * WebCoreSources.bkl: ditto
890 2006-10-22 Sam Weinig <sam.weinig@gmail.com>
894 - Add DOMHTMLFormElementPrivate.h to the project.
896 * WebCore.xcodeproj/project.pbxproj:
897 * bindings/objc/DOMPrivate.h:
899 2006-10-22 Darin Adler <darin@apple.com>
901 - another try at fixing Qt
903 * CMakeLists.txt: Added DeleteButton.cpp and DeleteButtonController.cpp.
905 - and fix a couple warnings while I'm at it
907 * platform/image-decoders/ImageDecoder.h: (WebCore::RGBA32Buffer::setRGBA):
908 Don't do unsigned *= float.
910 * rendering/break_lines.cpp: (WebCore::nextBreakablePosition): Move unused variable
911 inside #if so it's consistent.
913 2006-10-21 Darin Adler <darin@apple.com>
917 * platform/qt/EditorClientQt.cpp:
918 (WebCore::EditorClientQt::shouldShowDeleteInterface):
919 * platform/qt/EditorClientQt.h:
920 * platform/qt/FrameQt.cpp:
922 2006-10-21 Darin Adler <darin@apple.com>
926 - convert WebLoader and its 3 subclasses to C++ (this time with a leak fixed)
928 Renamed WebLoader to WebCore::WebResourceLoader (should be ResourceLoader, but
929 there's currently another class with that name).
930 Renamed WebMainResourceLoader to WebCore::MainResourceLoader.
931 Renamed WebSubresourceLoader to WebCore::SubresourceLoader.
932 Renamed WebNetscapePlugInStreamLoader to WebCore::NetscapePlugInStreamLoader.
934 Converted the classes to C++ and added Objective-C delegates to forward from
935 API that still requires Objective-C.
937 Did not yet rename the source files.
939 * WebCore.exp: Removed WebLoader, WebNetscapePlugInStreamLoader, and WebSubresourceLoader
940 classes. Added 5 functions from the WebResourceLoader and NetscapePlugInStreamLoader
943 * WebCore.xcodeproj/project.pbxproj: Made RetainPtr.h a private header instead of project.
945 * platform/cf/RetainPtr.h: Put into the WebCore namespace rather than the WTF namespace.
947 * loader/mac/WebLoader.h:
948 * loader/mac/WebLoader.mm:
949 * loader/mac/WebMainResourceLoader.h:
950 * loader/mac/WebMainResourceLoader.mm:
951 * loader/mac/WebNetscapePlugInStreamLoader.h:
952 * loader/mac/WebNetscapePlugInStreamLoader.mm:
953 * loader/mac/WebSubresourceLoader.h:
954 * loader/mac/WebSubresourceLoader.mm:
957 * bridge/mac/WebCoreFrameBridge.mm:
958 (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
959 (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
960 * loader/mac/WebFrameLoader.h:
961 * loader/mac/WebFrameLoader.mm:
962 (isCaseInsensitiveEqual):
963 (isBackForwardLoadType):
964 (-[WebFrameLoader dealloc]):
965 (-[WebFrameLoader addPlugInStreamLoader:]):
966 (-[WebFrameLoader removePlugInStreamLoader:]):
967 (-[WebFrameLoader setDefersCallbacks:]):
968 (-[WebFrameLoader stopLoadingPlugIns]):
969 (-[WebFrameLoader isLoadingMainResource]):
970 (-[WebFrameLoader isLoadingSubresources]):
971 (-[WebFrameLoader isLoadingPlugIns]):
972 (-[WebFrameLoader stopLoadingSubresources]):
973 (-[WebFrameLoader addSubresourceLoader:]):
974 (-[WebFrameLoader removeSubresourceLoader:]):
975 (-[WebFrameLoader mainResourceData]):
976 (-[WebFrameLoader releaseMainResourceLoader]):
977 (-[WebFrameLoader cancelMainResourceLoad]):
978 (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]):
979 (-[WebFrameLoader stopLoadingWithError:]):
980 (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
981 (-[WebFrameLoader archiveLoadPendingForLoader:]):
982 (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]):
983 * loader/mac/WebFrameLoaderClient.h:
984 Call the new C++ API.
986 2006-10-21 Adam Roben <aroben@apple.com>
992 * platform/PopupMenu.h:
994 2006-10-21 Darin Adler <darin@apple.com>
996 * editing/DeleteButtonController.cpp: (WebCore::enclosingDeletableTable):
997 Oops, edited this before landing it and introduced a null-deref! This fixes it.
999 2006-10-21 Darin Adler <darin@apple.com>
1003 - fix http://bugs.webkit.org/show_bug.cgi?id=11379
1004 assertion failure seen in editing tests (in new DeleteButtonController)
1006 I cleaned up the relationship between the Frame, Editor, EditorClient, and
1007 DeleteButtonController a bit while also making the simple change to fix the
1010 * bridge/mac/FrameMac.h: Change EditorClient parameter to a PassRefPtr since we take ownership.
1011 * bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac):
1013 * page/Frame.h: Change EditorClient parameter to a PassRefPtr since we take ownership.
1015 (WebCore::Frame::Frame): Ditto.
1016 (WebCore::Frame::appliedEditing): Removed unneeded parameter to the respondToChangedContents
1017 function, and moved it to Editor rather than right on the DeleteButtonController.
1018 (WebCore::Frame::unappliedEditing): Ditto.
1019 (WebCore::Frame::reappliedEditing): Ditto.
1020 * page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): More of the same.
1022 * editing/DeleteButtonController.h:
1023 * editing/DeleteButtonController.cpp:
1024 (WebCore::DeleteButtonController::DeleteButtonController): Replaced Editor* with a Frame*.
1025 The general pattern is that we always use the Frame* as the frame identifier. See FrameTree,
1027 (WebCore::enclosingDeletableTable): Added. Helper function used by the respondToChangedSelection
1028 function. Includes an additional check for whether the container is contentEditable, which
1029 was missing from the old version. This prevents the assertion failure. Also added a check that
1030 the table itself is editable.
1031 (WebCore::DeleteButtonController::respondToChangedSelection): Rewrote to use the helper.
1032 (WebCore::DeleteButtonController::respondToChangedContents): Removed the unnecessary
1033 selection parameter. No need to pass in the state of the frame since we can get it if we need it.
1034 (WebCore::DeleteButtonController::show): Updated to use frame pointer rather than editor pointer.
1036 * editing/Editor.cpp: Fixed formatting. Even the temporary placeholder functions should be
1037 formatted on multiple lines as usual.
1038 (WebCore::Editor::respondToChangedSelection): Added. Forwards to the delete button controller.
1039 (WebCore::Editor::respondToChangedContents): Ditto.
1040 (WebCore::Editor::Editor): Changed EditorClient parameter to a PassRefPtr since we take ownership.
1042 * editing/Editor.h: Changed the DeleteButtonController to use an OwnPtr instead of being
1043 defined inline to decouple so that we don't have to include DeleteButtonController.h. That way
1044 changes to DeleteButtonController.h cause very little to recompile.
1046 * editing/SelectionController.cpp: (WebCore::SelectionController::setSelection):
1047 Updated to call the editor instead of the delete button controller for the selection change.
1049 2006-10-21 Anders Carlsson <acarlsson@apple.com>
1053 * loader/mac/LoaderFunctionsMac.mm:
1054 (WebCore::ServeSynchronousRequest):
1055 * platform/mac/ResourceLoaderMac.mm:
1056 (WebCore::ResourceLoader::start):
1057 Don't leak the header dictionary.
1059 2006-10-21 Darin Adler <darin@apple.com>
1063 - http://bugs.webkit.org/show_bug.cgi?id=11376
1064 build scripts should invoke make with "-j" option for multiple processors
1066 * WebCore.xcodeproj/project.pbxproj: Pass -j `sysctl -n hw.ncpu` to make.
1068 2006-10-21 Timothy Hatcher <timothy@apple.com>
1072 <rdar://problem/4478625> HTML Editing: Basic table editing and culling
1074 Initial implementaltion of table deletion user interface:
1075 * Interface shows up on the nearest table containing the entire selection.
1076 * Shows a Dashboard style close button in the top left corner.
1077 * Shows a 60% opaque black outline around the table.
1078 * Adds a new EditorClient function shouldShowDeleteInterface.
1080 Also adds a new constructor CachedImage and setter functions on
1081 HTMLImageElement and HTMLImageLoader allowing an Image object to be set
1082 and image element in the page. This change also paves the way to allow an
1083 NSImage setter on DOMHTMLImageElement.
1085 * Resources/deleteButton.tiff: Added.
1086 * Resources/deleteButtonPressed.tiff: Added.
1087 * WebCore.xcodeproj/project.pbxproj:
1088 * bridge/EditorClient.h:
1089 * editing/DeleteButton.cpp: Added.
1090 (WebCore::DeleteButton::DeleteButton):
1091 (WebCore::DeleteButton::defaultEventHandler): notify the controller to delete on click
1092 * editing/DeleteButton.h: Added.
1093 * editing/DeleteButtonController.cpp: Added.
1094 (WebCore::DeleteButtonController::DeleteButtonController):
1095 (WebCore::DeleteButtonController::respondToChangedSelection): move the interface to the new element, or hide
1096 (WebCore::DeleteButtonController::respondToChangedContents): call updateOutlineStyle
1097 (WebCore::DeleteButtonController::updateOutlineStyle): resize the outline if the table changed size
1098 (WebCore::DeleteButtonController::show): shows the interface on a new element
1099 (WebCore::DeleteButtonController::hide): hides the existing interface
1100 (WebCore::DeleteButtonController::deleteTarget): deletes the targeted element
1101 * editing/DeleteButtonController.h: Added.
1102 (WebCore::DeleteButtonController::target): getter for the current target
1103 * editing/Editor.cpp:
1104 (WebCore::Editor::shouldShowDeleteInterface): call the new shouldShowDeleteInterface client function
1105 (WebCore::Editor::Editor): remove the manual ref now that we use RefPtr for m_client
1106 (WebCore::Editor::~Editor): remove the manual deref now that we use RefPtr for m_client
1108 (WebCore::Editor::frame): new getter
1109 (WebCore::Editor::deleteButtonController): ditto
1110 * editing/SelectionController.cpp:
1111 (WebCore::SelectionController::setSelection): notify the DeleteButtonController about the new selection
1112 * html/HTMLImageElement.h:
1113 (WebCore::HTMLImageElement::setCachedImage): new setter that replaces the CachedImage
1114 * html/HTMLImageLoader.cpp:
1115 (WebCore::HTMLImageLoader::setImage): ditto
1116 * html/HTMLImageLoader.h:
1117 * loader/CachedImage.cpp:
1118 (WebCore::CachedImage::CachedImage): new constructor that takes an Image
1119 * loader/CachedImage.h: ditto
1121 (WebCore::Frame::selectionController): cleanup coding style
1122 (WebCore::Frame::editor): ditto
1123 (WebCore::Frame::command): ditto
1124 (WebCore::Frame::appliedEditing): tell the delete button outline to update
1125 (WebCore::Frame::unappliedEditing): ditto
1126 (WebCore::Frame::reappliedEditing): ditto
1127 * rendering/RenderTable.cpp:
1128 (WebCore::RenderTable::addChild): workaround until bug 11363 is fixed
1130 2006-10-21 Sam Weinig <sam.weinig@gmail.com>
1134 Cleanup bindings generation a little through re-factoring
1135 and general style cleanup.
1137 * bindings/scripts/CodeGenerator.pm:
1138 * bindings/scripts/CodeGeneratorJS.pm:
1139 * bindings/scripts/CodeGeneratorObjC.pm:
1141 2006-10-21 Nikolas Zimmermann <zimmermann@kde.org>
1145 Fix crashes on Qt/Linux. Offer a default EditorClient and pass it down to Frame ctor.
1148 * platform/qt/EditorClientQt.cpp: Added.
1149 (WebCore::EditorClientQt::shouldDeleteRange):
1150 * platform/qt/EditorClientQt.h: Added.
1151 (WebCore::EditorClientQt::~EditorClientQt):
1152 * platform/qt/FrameQt.cpp:
1153 (WebCore::FrameQt::FrameQt):
1154 * platform/qt/FrameQt.h:
1156 2006-10-21 Sam Weinig <sam.weinig@gmail.com>
1160 Fix for http://bugs.webkit.org/show_bug.cgi?id=11372
1161 Auto-generate a few more Objective-C DOM methods.
1163 - Auto-generate getMatchedCSSRules and getComputedStyle methods.
1165 * bindings/objc/DOMCSS.h:
1166 * bindings/objc/DOMCSS.mm:
1167 * bindings/objc/DOMExtensions.h:
1168 * bindings/objc/PublicDOMInterfaces.h:
1169 * bindings/scripts/CodeGeneratorObjC.pm:
1171 * page/DOMWindow.idl:
1173 2006-10-21 Nikolas Zimmermann <zimmermann@kde.org>
1175 Reviewed by aliu, landed by aliu.
1180 * platform/qt/FrameQt.cpp:
1181 (WebCore::FrameQt::FrameQt):
1182 * platform/qt/SoundQt.cpp: Added.
1183 (WebCore::systemBeep):
1185 2006-10-21 Nikolas Zimmermann <zimmermann@kde.org>
1187 Reviewed by Mitz, landed by ap.
1189 Fix obscure crashes in RenderTableSection on Rob's musicdb file.
1190 The problem was a missing layout() call on the frame view.
1191 Thanks go to Mitz Pettel for the initial hint!
1193 * platform/qt/ScrollViewCanvasQt.cpp:
1194 (WebCore::ScrollViewCanvasQt::paintEvent):
1196 2006-10-20 Steve Falkenburg <sfalken@apple.com>
1200 Send User-Agent on requests.
1201 Send custom request headers properly.
1203 * platform/cf/ResourceLoaderCFNet.cpp:
1204 (WebCore::addHeadersFromHashMap): Switch over to HashMap iteration from string parsing
1205 (WebCore::ResourceLoader::start): Send proper User-Agent, change call to add headers
1207 2006-10-20 Timothy Hatcher <timothy@apple.com>
1211 Fix some bad formatting.
1213 * css/cssstyleselector.cpp:
1214 (WebCore::CSSStyleSelector::checkOneSelector):
1216 2006-10-20 Darin Adler <darin@apple.com>
1220 - fixed <rdar://problem/4795716> REGRESSION: User names and passwords aren't being saved (.Mac, etc.) -- WebKit formState passing empty strings
1222 * loader/mac/WebFormState.mm: (WebCore::FormState::FormState): Fix typo -- need to pass "key"
1223 as the key, not the dictionary itself.
1225 2006-10-20 Alice Liu <alice.liu@apple.com>
1229 This is the initial foundation for the EditingController class and
1230 everything else it needs to work. The idea is that the Frame has an
1231 EditingController object that it calls to handle editing commands, the
1232 most simple examples being copy/paste. This controller will handle
1233 these editing commands in WebCore, and only hand off to WebKit to call
1234 editing delegates (to the let the app intercept editing actions if it
1235 wants to). Thus we need a platform-specific client to which the
1236 EditingController hands off the delegate calls,
1237 WebCoreEditingControllerClient. On the WebCore side this is an
1238 abstract base class, and on the WebKit(Mac) side this is an ObjC++
1239 subclass, WebEditingControllerClient. How does the EditingController
1240 get a handle to its platform-specific client? In WebKit, the creator
1241 of a platform-specific Frame creates the client (which is ref-counted)
1242 and passes it down the chain of constructors until it gets back to the
1243 EditingController, which then refs it in its constructor and derefs in
1246 No Layout tests needed.
1248 * WebCore.xcodeproj/project.pbxproj:
1249 Added files and made DomRangeInternal.h and EditingClient.h private headers, necessary for WebKit to compile
1251 * bridge/EditorClient.h: Added.
1252 (WebCore::EditorClient::~EditorClient):
1254 * bridge/mac/FrameMac.h:
1255 Added an EditingClient to the constructor, to pass down to Frame constructor
1257 * bridge/mac/FrameMac.mm:
1258 (WebCore::FrameMac::FrameMac):
1259 Passed client down to Frame constructor
1261 * bridge/mac/WebCoreFrameBridge.h:
1262 Added an EditingClient to the constructor, to pass down to FrameMac constructor
1264 * bridge/mac/WebCoreFrameBridge.mm:
1265 (-[WebCoreFrameBridge initMainFrameWithPage:withEditorClient:]):
1266 (-[WebCoreFrameBridge initSubframeWithOwnerElement:withEditorClient:]):
1267 Passed client down to FrameMac constructor
1269 * editing/Editor.cpp: Added.
1270 Mostly stuf implementations of the following functions, except for a couple. These are all needed by cut, copy, paste, delete.
1271 (WebCore::generalPasteboard):
1272 (WebCore::Editor::canCopy):
1273 (WebCore::Editor::canCut):
1274 (WebCore::Editor::canDelete):
1275 (WebCore::Editor::canDeleteRange):
1276 (WebCore::Editor::canPaste):
1277 (WebCore::Editor::canSmartCopyOrDelete):
1278 (WebCore::Editor::deleteSelection):
1279 (WebCore::Editor::deleteSelectionWithSmartDelete):
1280 (WebCore::Editor::isSelectionRichlyEditable):
1281 (WebCore::Editor::pasteAsPlainTextWithPasteboard):
1282 (WebCore::Editor::pasteWithPasteboard):
1283 (WebCore::Editor::selectedRange):
1284 (WebCore::Editor::shouldDeleteRange):
1285 (WebCore::Editor::tryDHTMLCopy):
1286 (WebCore::Editor::tryDHTMLCut):
1287 (WebCore::Editor::tryDHTMLPaste):
1288 (WebCore::Editor::writeSelectionToPasteboard):
1289 (WebCore::Editor::Editor):
1290 (WebCore::Editor::~Editor):
1291 (WebCore::Editor::cut):
1292 (WebCore::Editor::copy):
1293 (WebCore::Editor::paste):
1294 (WebCore::Editor::performDelete):
1296 * editing/Editor.h: Added.
1299 Added an EditingClient to the constructor, to pass down to Editor constructor
1302 (WebCore::Frame::Frame):
1303 Passed down to Editor constructor
1304 (WebCore::Frame::editor):
1305 Accessfor for Editor stored in FramePrivate
1307 * page/FramePrivate.h:
1308 (WebCore::FramePrivate::FramePrivate):
1309 Added an Editor object to the FramePrivate data
1311 * platform/Sound.h: Added.
1312 Made a platform-independent accessor to a beep function
1314 * platform/mac/SoundMac.mm: Added.
1315 (WebCore::systemBeep):
1316 calls mac system beep
1318 2006-10-20 David Hyatt <hyatt@apple.com>
1320 Make sure to support the "encoding" property on form elements for
1321 legacy compatibility.
1323 Reviewed by darin/john
1325 No test cases added. Not sure how to do a form submission of
1326 various encodings as a layout test.
1328 * html/HTMLFormElement.h:
1329 (WebCore::HTMLFormElement::encoding):
1330 (WebCore::HTMLFormElement::setEncoding):
1331 * html/HTMLFormElement.idl:
1333 2006-10-20 Nikolas Zimmermann <zimmermann@kde.org>
1335 Reviewed and by Anders.
1337 Fix warnings in JS generation by killing the whole isRefPtr logic,
1338 and just using WTF::getPtr as Sam Weinig suggested. Also kill some
1339 places using get() where getPtr() is cleaner - not for m_impl.get().
1341 * CMakeLists.txt: Tiny cleanup + add deps for CodeGenerator(JS).pm on all IDLs.
1342 * bindings/scripts/CodeGeneratorJS.pm:
1344 2006-10-20 Darin Adler <darin@apple.com>
1346 - rolled out my loader change; caused world leak and possibly a plug-in crash
1348 2006-10-20 Anders Carlsson <acarlsson@apple.com>
1352 * loader/mac/LoaderFunctionsMac.mm:
1353 Autorelease the header NSDictionary.
1355 2006-10-20 Anders Carlsson <acarlsson@apple.com>
1359 * bindings/js/kjs_window.cpp:
1360 (KJS::Window::timerFired):
1361 Check if the timeout id is still in the table before trying to access it. If it isn't in the table
1362 it has been deleted inside of the execute method.
1364 2006-10-20 Anders Carlsson <acarlsson@apple.com>
1366 Reviewed by Darin and Geoff.
1368 Remove debugging output.
1369 * xml/xmlhttprequest.cpp:
1370 (WebCore::XMLHttpRequest::send):
1372 2006-10-20 David Harrison <harrison@apple.com>
1376 <rdar://problem/4792755> REGRESSON: Drag selecting is erratic
1378 No test because it would require autoscrolling, which is not available to layout tests.
1380 * rendering/RenderLayer.cpp:
1381 (WebCore::RenderLayer::autoscroll):
1382 Use hitTest() to find the correct node.
1384 (WebCore::RenderLayer::hitTest):
1385 Trivial source formatting.
1387 2006-10-20 Nikolas Zimmermann <zimmermann@kde.org>
1389 Reviewed and landed by Anders.
1391 Fix regression introduced during the ResourceLoader transition (Maciej's rewrite).
1393 * platform/qt/ResourceLoaderManager.cpp:
1394 (WebCore::ResourceLoaderManager::add):
1396 2006-10-20 Darin Adler <darin@apple.com>
1400 - convert WebLoader and its 3 subclasses to C++
1402 Renamed WebLoader to WebCore::WebResourceLoader (should be ResourceLoader, but
1403 there's currently another class with that name).
1404 Renamed WebMainResourceLoader to WebCore::MainResourceLoader.
1405 Renamed WebSubresourceLoader to WebCore::SubresourceLoader.
1406 Renamed WebNetscapePlugInStreamLoader to WebCore::NetscapePlugInStreamLoader.
1408 Converted the classes to C++ and added Objective-C delegates to forward from
1409 API that still requires Objective-C.
1411 Did not yet rename the source files.
1413 * WebCore.exp: Removed WebLoader, WebNetscapePlugInStreamLoader, and WebSubresourceLoader
1414 classes. Added 5 functions from the WebResourceLoader and NetscapePlugInStreamLoader
1417 * WebCore.xcodeproj/project.pbxproj: Made RetainPtr.h a private header instead of project.
1419 * platform/cf/RetainPtr.h: Put into the WebCore namespace rather than the WTF namespace.
1421 * loader/mac/WebLoader.h:
1422 * loader/mac/WebLoader.mm:
1423 * loader/mac/WebMainResourceLoader.h:
1424 * loader/mac/WebMainResourceLoader.mm:
1425 * loader/mac/WebNetscapePlugInStreamLoader.h:
1426 * loader/mac/WebNetscapePlugInStreamLoader.mm:
1427 * loader/mac/WebSubresourceLoader.h:
1428 * loader/mac/WebSubresourceLoader.mm:
1431 * bridge/mac/WebCoreFrameBridge.mm:
1432 (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
1433 (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
1434 * loader/mac/WebFrameLoader.h:
1435 * loader/mac/WebFrameLoader.mm:
1436 (isCaseInsensitiveEqual):
1437 (isBackForwardLoadType):
1438 (-[WebFrameLoader dealloc]):
1439 (-[WebFrameLoader addPlugInStreamLoader:]):
1440 (-[WebFrameLoader removePlugInStreamLoader:]):
1441 (-[WebFrameLoader setDefersCallbacks:]):
1442 (-[WebFrameLoader stopLoadingPlugIns]):
1443 (-[WebFrameLoader isLoadingMainResource]):
1444 (-[WebFrameLoader isLoadingSubresources]):
1445 (-[WebFrameLoader isLoadingPlugIns]):
1446 (-[WebFrameLoader stopLoadingSubresources]):
1447 (-[WebFrameLoader addSubresourceLoader:]):
1448 (-[WebFrameLoader removeSubresourceLoader:]):
1449 (-[WebFrameLoader mainResourceData]):
1450 (-[WebFrameLoader releaseMainResourceLoader]):
1451 (-[WebFrameLoader cancelMainResourceLoad]):
1452 (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]):
1453 (-[WebFrameLoader stopLoadingWithError:]):
1454 (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
1455 (-[WebFrameLoader archiveLoadPendingForLoader:]):
1456 (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]):
1457 * loader/mac/WebFrameLoaderClient.h:
1458 Call the new C++ API.
1460 2006-10-20 Nikolas Zimmermann <zimmermann@kde.org>
1462 Reviewed and landed by Anders.
1464 Offer a way for WebKitPart to be able to detect when
1465 the webpage has been completly loaded (including subresources).
1467 Also fix Qt/Linux build by removing PopupMenu.cpp from CMakeLists.txt
1468 and removing some functions from PopupMenuQt.cpp, and alter FrameQt.cpp.
1471 * platform/qt/FrameQt.cpp:
1472 (WebCore::FrameQt::submitForm):
1473 (WebCore::FrameQt::client):
1474 * platform/qt/FrameQt.h:
1475 * platform/qt/FrameQtClient.cpp:
1476 (WebCore::FrameQtClientDefault::setFrame):
1477 (WebCore::FrameQtClientDefault::openURL):
1478 (WebCore::FrameQtClientDefault::submitForm):
1479 (WebCore::FrameQtClientDefault::checkLoaded):
1480 (WebCore::FrameQtClientDefault::traverseNextFrameStayWithin):
1481 (WebCore::FrameQtClientDefault::numPendingOrLoadingRequests):
1482 (WebCore::FrameQtClientDefault::receivedAllData):
1483 * platform/qt/FrameQtClient.h:
1484 * platform/qt/LoaderFunctionsQt.cpp:
1485 (WebCore::CheckCacheObjectStatus):
1486 * platform/qt/PopupMenuQt.cpp:
1487 * platform/qt/ResourceLoaderManager.cpp:
1488 (WebCore::ResourceLoaderManager::ResourceLoaderManager):
1489 (WebCore::ResourceLoaderManager::slotResult):
1490 (WebCore::ResourceLoaderManager::add):
1491 * platform/qt/ResourceLoaderManager.h:
1492 * platform/qt/ResourceLoaderQt.cpp:
1493 (WebCore::ResourceLoader::start):
1495 2006-10-20 Steve Falkenburg <sfalken@apple.com>
1499 Fix compiler warnings
1501 * platform/ResourceLoaderClient.h:
1503 2006-10-20 Sam Weinig <sam.weinig@gmail.com>
1507 Win32 build fix and cleanup.
1509 * WebCore.vcproj/WebCore/WebCore.vcproj:
1510 * bridge/win/FrameWin.cpp:
1511 (WebCore::FrameWin::FrameWin):
1512 (WebCore::FrameWin::submitForm):
1513 * page/ResourceRequest.h:
1514 (WebCore::ResourceRequest::addHTTPHeaderField):
1515 * platform/win/TemporaryLinkStubs.cpp:
1516 (WebCore::Slider::~Slider):
1517 (WebCore::Slider::setMinValue):
1518 (WebCore::searchableIndexIntroduction):
1519 (WebCore::findNextSentenceFromIndex):
1520 (WebCore::findSentenceBoundary):
1521 (WebCore::findNextWordFromIndex):
1522 (WebCore::FrameWin::getObjectInstanceForWidget):
1523 (WebCore::FrameWin::getEmbedInstanceForWidget):
1524 (WebCore::FrameWin::runJavaScriptPrompt):
1525 (WebCore::FrameWin::restoreDocumentState):
1526 (WebCore::FrameWin::partClearedInBegin):
1527 (WebCore::FrameWin::createEmptyDocument):
1528 (WebCore::FrameWin::overrideMediaType):
1529 (WebCore::FrameWin::markedTextRange):
1530 (WebCore::FrameWin::passSubframeEventToSubframe):
1531 (WebCore::FrameWin::lastEventIsMouseUp):
1532 (WebCore::FrameWin::addMessageToConsole):
1533 (WebCore::FrameWin::shouldChangeSelection):
1534 (WebCore::FrameWin::respondToChangedSelection):
1535 (WebCore::FrameWin::createFrame):
1536 (WebCore::FrameWin::saveDocumentState):
1537 (WebCore::FrameWin::clearUndoRedoOperations):
1538 (WebCore::FrameWin::incomingReferrer):
1539 (WebCore::FrameWin::markMisspellingsInAdjacentWords):
1540 (WebCore::FrameWin::respondToChangedContents):
1541 (WebCore::FrameWin::handledOnloadEvents):
1542 (WebCore::FrameWin::createPlugin):
1543 (WebCore::FrameWin::objectContentType):
1544 (WebCore::screenDepthPerComponent):
1545 (WebCore::screenIsMonochrome):
1546 (WebCore::historyContains):
1547 (WebCore::submitButtonDefaultLabel):
1548 (WebCore::inputElementAltText):
1549 (WebCore::resetButtonDefaultLabel):
1550 (WebCore::fileButtonChooseFileLabel):
1551 (WebCore::fileButtonNoFileSelectedLabel):
1552 (WebCore::defaultLanguage):
1553 (WebCore::findWordBoundary):
1554 (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex):
1555 (WebCore::PlugInInfoStore::supportsMIMEType):
1556 (WebCore::refreshPlugins):
1557 (WebCore::ResourceLoader::assembleResponseHeaders):
1558 (WebCore::ResourceLoader::retrieveResponseEncoding):
1559 (WebCore::ResourceLoader::startHTTPRequest):
1560 (WebCore::TextField::TextField):
1561 (WebCore::focusRingColor):
1562 (WebCore::setFocusRingColorChangeFunction):
1563 (WebCore::PopupMenu::~PopupMenu):
1564 (WebCore::PopupMenu::hide):
1566 2006-10-20 Rob Buis <buis@kde.org>
1570 http://bugs.webkit.org/show_bug.cgi?id=11303
1571 Path::transform() should be implemented on Qt build
1573 Use QPainterPath API to implement Path::transform.
1574 This fixes svg/custom/clip-path-with-transform.svg on
1577 * platform/qt/PathQt.cpp:
1578 (WebCore::Path::transform):
1580 2006-10-20 Rob Buis <buis@kde.org>
1584 http://bugs.webkit.org/show_bug.cgi?id=11217
1585 Cleanup svg coding style
1587 Cleanup coding style in svg clipping and painting classes.
1589 * ksvg2/svg/SVGClipPathElement.cpp:
1590 (WebCore::SVGClipPathElement::parseMappedAttribute):
1591 (WebCore::SVGClipPathElement::canvasResource):
1592 * ksvg2/svg/SVGClipPathElement.h:
1593 * ksvg2/svg/SVGMarkerElement.cpp:
1594 (WebCore::SVGMarkerElement::SVGMarkerElement):
1595 (WebCore::SVGMarkerElement::parseMappedAttribute):
1596 (WebCore::SVGMarkerElement::setOrientToAngle):
1597 (WebCore::SVGMarkerElement::canvasResource):
1598 * ksvg2/svg/SVGMarkerElement.h:
1599 (WebCore::SVGMarkerElement::rendererIsNeeded):
1600 * ksvg2/svg/SVGMaskElement.cpp:
1601 (WebCore::SVGMaskElement::SVGMaskElement):
1602 (WebCore::SVGMaskElement::parseMappedAttribute):
1603 (WebCore::SVGMaskElement::drawMaskerContent):
1604 (WebCore::SVGMaskElement::canvasResource):
1605 * ksvg2/svg/SVGMaskElement.h:
1606 (WebCore::SVGMaskElement::rendererIsNeeded):
1607 * ksvg2/svg/SVGPaint.cpp:
1608 (WebCore::SVGPaint::setPaint):
1609 (WebCore::SVGPaint::cssText):
1610 * ksvg2/svg/SVGPaint.h:
1612 2006-10-20 David Hyatt <hyatt@apple.com>
1614 Make sure to do the code that checks the repeatInterval before the timer has been
1617 Reviewed by andersca
1619 * bindings/js/kjs_window.cpp:
1620 (KJS::DOMWindowTimer::setNestingLevel):
1621 (KJS::Window::timerFired):
1622 (KJS::DOMWindowTimer::fired):
1625 2006-10-20 David Hyatt <hyatt@apple.com>
1627 Honor tiny timer intervals for JS timeouts as they are nested until a cutoff point is reached.
1628 At that point clamp to 10ms to prevent excessive CPU usage.
1632 * bindings/js/kjs_window.cpp:
1633 (KJS::DOMWindowTimer::DOMWindowTimer):
1634 (KJS::DOMWindowTimer::nestingLevel):
1635 (KJS::Window::installTimeout):
1636 (KJS::Window::pauseTimeouts):
1637 (KJS::Window::resumeTimeouts):
1638 (KJS::DOMWindowTimer::fired):
1640 (WebCore::TimerBase::startRepeating):
1641 (WebCore::TimerBase::startOneShot):
1642 (WebCore::TimerBase::repeatInterval):
1643 (WebCore::TimerBase::augmentRepeatInterval):
1644 (WebCore::TimerBase::inHeap):
1645 (WebCore::Timer::Timer):
1646 (WebCore::Timer::fired):
1648 2006-10-20 Steve Falkenburg <sfalken@apple.com>
1652 * ksvg2/svg/SVGAElement.cpp:
1653 (WebCore::SVGAElement::defaultEventHandler):
1655 2006-10-19 Steve Falkenburg <sfalken@apple.com>
1659 Use GetKeyState rather than GetAsyncKeyState since we're
1660 calling in these cases in direct response to an event, and want the
1661 key state associated with that event.
1663 Pass triggering event to url selection method.
1665 * bridge/mac/FrameMac.h: Add triggeringEvent parameter
1666 * bridge/mac/FrameMac.mm:
1667 (WebCore::FrameMac::urlSelected): Add triggeringEvent parameter
1668 * bridge/win/FrameWin.cpp:
1669 (WebCore::FrameWin::urlSelected): Add triggeringEvent parameter
1670 * bridge/win/FrameWin.h: Add triggeringEvent parameter
1671 * html/HTMLAnchorElement.cpp:
1672 (WebCore::HTMLAnchorElement::defaultEventHandler): Pass triggering event to URL selection method
1674 (WebCore::Frame::changeLocation): Add 0 as triggeringEvent
1675 (WebCore::Frame::urlSelected): Pass through triggeringEvent
1676 * page/Frame.h: Add triggeringEvent parameter to urlSelected methods
1677 * platform/win/KeyEventWin.cpp:
1678 (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Use GetKeyState instead of GetAsyncKeyState
1679 * platform/win/MouseEventWin.cpp: Use GetKeyState instead of GetAsyncKeyState
1680 (WebCore::PlatformMouseEvent::PlatformMouseEvent):
1682 2006-10-19 David Hyatt <hyatt@apple.com>
1684 Correct typos from changing "flush" to "prune" using automated search/replace.
1686 Change the cache heuristic for flushing to allow a higher watermark before initiating an
1687 aggressive prune. This ensures that small cache sizes are no worse in terms of performance
1688 than the old buggy cache.
1690 Make sizes unsigned instead of ints in the cache's APIs and member variables.
1693 (WebCore::Cache::prune):
1694 (WebCore::Cache::setMaximumSize):
1696 (WebCore::Cache::maximumSize):
1698 2006-10-19 Anders Carlsson <acarlsson@apple.com>
1700 Reviewed by Daddy Hyatt.
1702 Use a real hash map for the headers.
1704 * loader/LoaderFunctions.h:
1705 * loader/mac/LoaderFunctionsMac.mm:
1706 (WebCore::ServeSynchronousRequest):
1707 * platform/ResourceLoader.cpp:
1708 (WebCore::ResourceLoader::setRequestHeaders):
1709 (WebCore::ResourceLoader::requestHeaders):
1710 * platform/ResourceLoader.h:
1711 * platform/ResourceLoaderInternal.h:
1712 * platform/mac/ResourceLoaderMac.mm:
1713 (WebCore::ResourceLoader::start):
1714 * xml/xmlhttprequest.cpp:
1715 (WebCore::XMLHttpRequest::open):
1716 (WebCore::XMLHttpRequest::send):
1717 (WebCore::XMLHttpRequest::setRequestHeader):
1718 (WebCore::XMLHttpRequest::getRequestHeader):
1719 * xml/xmlhttprequest.h:
1721 2006-10-19 Adam Roben <aroben@apple.com>
1725 Pippity-poppity popup tweaks.
1727 * WebCore.xcodeproj/project.pbxproj: Removed PopupMenu.cpp from project.
1728 * html/HTMLSelectElement.cpp:
1729 (WebCore::HTMLSelectElement::setSelectedIndex): Only fire onChange if
1730 requested and the new index is actually different than the old one.
1731 * platform/IntPoint.h: Added another casting operator.
1732 * platform/PopupMenu.cpp: Removed. The code in here, while
1733 platform-independent, was only useful for the NSPopUpButtonCell
1734 implementation of popup menus, so I've moved it to PopupMenuMac.mm.
1735 * platform/PopupMenu.h: Moved the definition of PopupMenu::create into
1736 the header since it's fairly simple. Made some more methods private now
1737 that we don't have subclasses and virtual methods anymore.
1738 (WebCore::PopupMenu::create):
1739 (WebCore::PopupMenu::menuList):
1740 (WebCore::PopupMenu::itemHeight):
1741 (WebCore::PopupMenu::windowRect):
1742 (WebCore::PopupMenu::listIndexAtPoint):
1743 (WebCore::PopupMenu::focusedIndex):
1744 (WebCore::PopupMenu::setWasClicked):
1745 (WebCore::PopupMenu::wasClicked):
1746 (WebCore::PopupMenu::setScrollOffset):
1747 (WebCore::PopupMenu::scrollOffset):
1748 (WebCore::PopupMenu::wheelDelta):
1749 * platform/mac/PopupMenuMac.mm: Added the code from PopupMenu.cpp.
1750 (WebCore::PopupMenu::populate): Call our own clear() method to clear
1752 * platform/win/IntPointWin.cpp: New casting operator.
1753 (WebCore::IntPoint::IntPoint):
1754 (WebCore::IntPoint::operator POINTS):
1756 2006-10-19 Adam Roben <aroben@apple.com>
1760 Cleaning up Document::nextFocusNode and Document::previousFocusNode.
1763 (WebCore::Document::nextFocusNode):
1764 (WebCore::Document::previousFocusNode):
1766 2006-10-19 Maciej Stachowiak <mjs@apple.com>
1770 - implement new ResourceRequest API and fix up code as appropriate
1772 * bindings/js/kjs_window.cpp:
1773 (KJS::createNewWindow):
1774 (KJS::WindowFunc::callAsFunction):
1775 * bridge/mac/BrowserExtensionMac.mm:
1776 (WebCore::BrowserExtensionMac::createNewWindow):
1777 * bridge/mac/FrameMac.mm:
1778 (WebCore::FrameMac::submitForm):
1779 (WebCore::FrameMac::openURLRequest):
1780 (WebCore::FrameMac::urlSelected):
1781 * bridge/mac/WebCoreFrameBridge.mm:
1782 (-[WebCoreFrameBridge openURL:reload:contentType:refresh:lastModified:pageCache:]):
1783 * dom/DOMImplementation.cpp:
1784 (WebCore::addString):
1785 (WebCore::isSVG10Feature):
1786 (WebCore::isSVG11Feature):
1788 * editing/CommandByName.cpp:
1789 * editing/JSEditor.cpp:
1791 (WebCore::Frame::changeLocation):
1792 (WebCore::Frame::urlSelected):
1793 (WebCore::Frame::requestFrame):
1794 (WebCore::Frame::submitForm):
1796 * page/FramePrivate.h:
1797 * page/ResourceRequest.h:
1799 (WebCore::ResourceRequest::ResourceRequest):
1800 (WebCore::ResourceRequest::cachePolicy):
1801 (WebCore::ResourceRequest::setCachePolicy):
1802 (WebCore::ResourceRequest::timeoutInterval):
1803 (WebCore::ResourceRequest::setTimeoutInterval):
1804 (WebCore::ResourceRequest::mainDocumentURL):
1805 (WebCore::ResourceRequest::setMainDocumentURL):
1806 (WebCore::ResourceRequest::httpMethod):
1807 (WebCore::ResourceRequest::setHTTPMethod):
1808 (WebCore::ResourceRequest::httpHeaderField):
1809 (WebCore::ResourceRequest::setHTTPHeaderField):
1810 (WebCore::ResourceRequest::httpContentType):
1811 (WebCore::ResourceRequest::setHTTPContentType):
1812 (WebCore::ResourceRequest::httpReferrer):
1813 (WebCore::ResourceRequest::setHTTPReferrer):
1814 (WebCore::ResourceRequest::httpUserAgent):
1815 (WebCore::ResourceRequest::setHTTPUserAgent):
1816 (WebCore::ResourceRequest::httpBody):
1817 (WebCore::ResourceRequest::setHTTPBody):
1818 (WebCore::ResourceRequest::addHTTPHeaderField):
1819 * platform/FontCache.cpp:
1820 (WebCore::computeHash):
1821 * platform/StringHash.h:
1823 * platform/StringImpl.cpp:
1824 (WebCore::equalIgnoringCase):
1825 * rendering/RenderPartObject.cpp:
1826 (WebCore::RenderPartObject::updateWidget):
1828 2006-10-19 Justin Garcia <justin.garcia@apple.com>
1832 <rdar://problem/4447885>
1833 API: WebView should have a method something like incrementLeftMarginBy: or indentBy:
1835 Fixed indent/outdent to only increment the left margin, to match other browsers.
1836 Used blockquote class="webkit-indent-blockquote" to do this. Mail can now
1837 implement indent/outdent by customizing the appearance of these blockquotes,
1838 instead of using a new API.
1840 * css/html4.css: Added margin: 0 0 0 40px for webkit-indent-blockquotes.
1841 * editing/IndentOutdentCommand.cpp:
1842 (WebCore::indentBlockquoteString): Added.
1843 (WebCore::createIndentBlockquoteElement): Added.
1844 (WebCore::isIndentBlockquote): Added.
1845 (WebCore::isListOrBlockquote): Added.
1846 (WebCore::IndentOutdentCommand::IndentOutdentCommand):
1847 (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion): Fixed
1848 a bug in the code that added an extra br if the placeholder collapsed upon insertion.
1849 Used the new indentBlockquote checks and enclosing element getters.
1850 (WebCore::IndentOutdentCommand::indentRegion): Ditto.
1851 (WebCore::IndentOutdentCommand::outdentParagraph): Ditto. Cleaned up the
1852 logic to pull the selection out of a list a bit.
1853 * editing/htmlediting.cpp:
1854 (WebCore::enclosingNodeOfType): Added this generic enclosing element getter.
1855 * editing/htmlediting.h:
1857 2006-10-19 Timothy Hatcher <timothy@apple.com>
1859 Rolling out the this change since it caused a bad regression:
1860 <rdar://problem/4788524> REGRESSION: Incomplete repaint of text area when deleting (11277)
1862 2006-10-12 Adele Peterson <adele@apple.com>
1864 Reviewed by Dave Harrison.
1866 - Fixed <rdar://problem/4650813> REGRESSION: typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
1868 * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout):
1869 Make subtree layouts work for textareas as well as text fields.
1871 2006-10-19 Nikolas Zimmermann <zimmermann@kde.org>
1873 Reviewed and landed by Anders.
1879 * platform/qt/BrowserExtensionQt.cpp:
1880 * platform/qt/BrowserExtensionQt.h:
1881 * platform/qt/CursorQt.cpp:
1882 (WebCore::pointerCursor):
1883 * platform/qt/LoaderFunctionsQt.cpp:
1884 (WebCore::NumberOfPendingOrLoadingRequests):
1885 (WebCore::CheckCacheObjectStatus):
1886 * platform/qt/ResourceLoaderQt.cpp:
1887 (WebCore::ResourceLoader::retrieveResponseEncoding):
1888 (WebCore::ResourceLoader::receivedResponse):
1890 2006-10-19 Sam Weinig <sam.weinig@gmail.com>
1896 * bridge/win/FrameWin.cpp:
1897 * bridge/win/FrameWin.h:
1898 * platform/win/TemporaryLinkStubs.cpp:
1899 (WebCore::ResourceLoader::retrieveResponseEncoding):
1901 2006-10-19 Alexey Proskuryakov <ap@nypop.com>
1905 http://bugs.webkit.org/show_bug.cgi?id=11141
1906 REGRESSION(r16681-r16691): CSS '@import' doesn't respect HTML Base element
1908 Undo one misguided change made in bug 11011 - stop setting inline stylesheet's href
1909 to document URL. This matches WinIE and partially matches Firefox - although the latter
1910 reports the href as if it were inherited, it still doesn't use it when resolving URIs in
1913 Test: http/tests/uri/css-href.php
1915 * html/HTMLStyleElement.cpp:
1916 (WebCore::HTMLStyleElement::childrenChanged):
1917 * ksvg2/svg/SVGStyleElement.cpp:
1918 (WebCore::SVGStyleElement::childrenChanged):
1920 2006-10-19 Anders Carlsson <acarlsson@apple.com>
1923 Get rid of #include "loader.h", Cache.h already includes this and it breaks on operating systems
1924 with case-sensitive file systems.
1926 2006-10-19 Anders Carlsson <acarlsson@apple.com>
1928 Reviewed by Maciej, Brady.
1930 Remove "charset" from the ResourceLoader metadata map and use
1931 a getter function instead. Also, rename charset to encoding in a couple of places.
1933 * loader/CachedCSSStyleSheet.cpp:
1934 (WebCore::CachedCSSStyleSheet::setEncoding):
1935 * loader/CachedCSSStyleSheet.h:
1936 * loader/CachedResource.h:
1937 (WebCore::CachedResource::setEncoding):
1938 * loader/CachedScript.cpp:
1939 (WebCore::CachedScript::setEncoding):
1940 * loader/CachedScript.h:
1941 * loader/CachedXBLDocument.cpp:
1942 (WebCore::CachedXBLDocument::setEncoding):
1943 * loader/CachedXBLDocument.h:
1944 * loader/CachedXSLStyleSheet.cpp:
1945 (WebCore::CachedXSLStyleSheet::setEncoding):
1946 * loader/CachedXSLStyleSheet.h:
1947 * loader/loader.cpp:
1948 (WebCore::Loader::receivedResponse):
1949 * platform/ResourceLoader.cpp:
1950 (WebCore::ResourceLoader::responseEncoding):
1951 (WebCore::ResourceLoader::queryMetaData):
1952 * platform/ResourceLoader.h:
1953 * platform/ResourceLoaderInternal.h:
1954 (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
1955 * platform/mac/ResourceLoaderMac.mm:
1956 (WebCore::ResourceLoader::retrieveResponseEncoding):
1957 (WebCore::ResourceLoader::receivedResponse):
1958 * xml/xmlhttprequest.cpp:
1959 (WebCore::XMLHttpRequest::receivedData):
1961 2006-10-19 David Hyatt <hyatt@apple.com>
1963 Rewrite of the WebCore memory cache. The following changes have been made (along with many more):
1965 (1) Referenced objects are now also cached.
1967 (2) Pruning of the cache will occur once the cache is both full and in addition
1968 more than half full with unreferenced objects.
1970 (3) The prune is much more aggressive now, since referenced objects are counted when
1971 pruning. The cache will therefore often prune out every unreferenced object if lots of
1972 windows/tabs are open.
1974 (4) Consolidated the request methods for various types of resources to go through a single
1975 requestResource bottleneck function.
1977 (5) deref on CachedResource is no longer virtual, since the implementation in every subclass was
1980 (6) Changed "object" to "resource" everywhere.
1982 (7) The Cache is now an actual object, obtained via cache().
1984 (8) Fixed bugs with the autoload images preference so that it would really work properly when disabled
1987 (9) Tweaked ImageDocuments to set up the status properly for the CachedResource that they use.
1989 (10) Fixed the LRU-SP algorithm so that the LRU aspect really kicks in (by leaving the live objects
1990 in the LRU lists). Also fixed a bug with the "-SP" part of the algorithm where the access count was
1991 being incorrectly weighted too much due to a math error.
1993 (11) Fixed a bug where the old cache could grow without bound because it didn't know anything about
1994 the size of referenced resources.
1996 Reviewed by Maciej, bradee-oh
1998 * bridge/mac/WebCoreCache.mm:
1999 (+[WebCoreCache statistics]):
2000 (+[WebCoreCache empty]):
2001 (+[WebCoreCache setDisabled:]):
2002 * bridge/mac/WebCoreFrameBridge.mm:
2003 (-[WebCoreFrameBridge initMainFrameWithPage:]):
2004 (-[WebCoreFrameBridge getData:andResponse:forURL:]):
2005 (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
2006 * css/CSSImageValue.cpp:
2007 (WebCore::CSSImageValue::image):
2008 * dom/XMLTokenizer.cpp:
2009 (WebCore::openFunc):
2010 * html/HTMLImageLoader.cpp:
2011 (WebCore::HTMLImageLoader::updateFromElement):
2014 (WebCore::Cache::Cache):
2015 (WebCore::createResource):
2016 (WebCore::Cache::requestResource):
2017 (WebCore::Cache::resourceForURL):
2018 (WebCore::Cache::prune):
2019 (WebCore::Cache::setMaximumSize):
2020 (WebCore::Cache::remove):
2021 (WebCore::Cache::addDocLoader):
2022 (WebCore::Cache::removeDocLoader):
2023 (WebCore::fastLog2):
2024 (WebCore::Cache::lruListFor):
2025 (WebCore::Cache::removeFromLRUList):
2026 (WebCore::Cache::insertInLRUList):
2027 (WebCore::Cache::resourceAccessed):
2028 (WebCore::Cache::adjustSize):
2029 (WebCore::Cache::getStatistics):
2030 (WebCore::Cache::setDisabled):
2032 (WebCore::LRUList::LRUList):
2033 (WebCore::Cache::loader):
2034 (WebCore::Cache::maximumSize):
2035 (WebCore::Cache::disabled):
2036 (WebCore::Cache::addToLiveObjectSize):
2037 (WebCore::Cache::removeFromLiveObjectSize):
2038 (WebCore::Cache::TypeStatistic::TypeStatistic):
2039 * loader/CachedCSSStyleSheet.cpp:
2040 (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
2041 * loader/CachedCSSStyleSheet.h:
2042 * loader/CachedImage.cpp:
2043 (WebCore::CachedImage::CachedImage):
2044 (WebCore::CachedImage::~CachedImage):
2045 (WebCore::brokenImage):
2046 (WebCore::nullImage):
2047 (WebCore::CachedImage::image):
2048 (WebCore::CachedImage::data):
2049 * loader/CachedImage.h:
2050 (WebCore::CachedImage::stillNeedsLoad):
2051 * loader/CachedResource.cpp:
2052 (WebCore::CachedResource::CachedResource):
2053 (WebCore::CachedResource::~CachedResource):
2054 (WebCore::CachedResource::finish):
2055 (WebCore::CachedResource::setExpireDate):
2056 (WebCore::CachedResource::isExpired):
2057 (WebCore::CachedResource::setRequest):
2058 (WebCore::CachedResource::ref):
2059 (WebCore::CachedResource::deref):
2060 (WebCore::CachedResource::setSize):
2061 * loader/CachedResource.h:
2062 (WebCore::CachedResource::):
2063 (WebCore::CachedResource::setCharset):
2064 (WebCore::CachedResource::url):
2065 (WebCore::CachedResource::type):
2066 (WebCore::CachedResource::referenced):
2067 (WebCore::CachedResource::count):
2068 (WebCore::CachedResource::status):
2069 (WebCore::CachedResource::size):
2070 (WebCore::CachedResource::isLoaded):
2071 (WebCore::CachedResource::setLoading):
2072 (WebCore::CachedResource::isImage):
2073 (WebCore::CachedResource::accessCount):
2074 (WebCore::CachedResource::increaseAccessCount):
2075 (WebCore::CachedResource::setInCache):
2076 (WebCore::CachedResource::inCache):
2077 (WebCore::CachedResource::cachePolicy):
2078 (WebCore::CachedResource::response):
2079 (WebCore::CachedResource::allData):
2080 (WebCore::CachedResource::canDelete):
2081 (WebCore::CachedResource::schedule):
2082 (WebCore::CachedResource::accept):
2083 (WebCore::CachedResource::setAccept):
2084 * loader/CachedScript.cpp:
2085 (WebCore::CachedScript::CachedScript):
2086 * loader/CachedScript.h:
2087 * loader/CachedXBLDocument.cpp:
2088 * loader/CachedXBLDocument.h:
2089 * loader/CachedXSLStyleSheet.cpp:
2090 (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
2091 * loader/CachedXSLStyleSheet.h:
2092 * loader/DocLoader.cpp:
2093 (WebCore::DocLoader::DocLoader):
2094 (WebCore::DocLoader::~DocLoader):
2095 (WebCore::DocLoader::checkForReload):
2096 (WebCore::DocLoader::requestImage):
2097 (WebCore::DocLoader::requestCSSStyleSheet):
2098 (WebCore::DocLoader::requestScript):
2099 (WebCore::DocLoader::requestXSLStyleSheet):
2100 (WebCore::DocLoader::requestXBLDocument):
2101 (WebCore::DocLoader::requestResource):
2102 (WebCore::DocLoader::setAutoLoadImages):
2103 (WebCore::DocLoader::removeCachedResource):
2104 * loader/DocLoader.h:
2105 (WebCore::DocLoader::cachedResource):
2106 (WebCore::DocLoader::allCachedResources):
2107 (WebCore::DocLoader::autoLoadImages):
2108 (WebCore::DocLoader::cachePolicy):
2109 (WebCore::DocLoader::expireDate):
2110 (WebCore::DocLoader::frame):
2111 (WebCore::DocLoader::doc):
2112 (WebCore::DocLoader::loadInProgress):
2113 * loader/ImageDocument.cpp:
2114 (WebCore::ImageTokenizer::finish):
2115 * loader/loader.cpp:
2116 (WebCore::Loader::receivedAllData):
2117 (WebCore::Loader::cancelRequests):
2118 * loader/mac/LoaderFunctionsMac.mm:
2119 (WebCore::NumberOfPendingOrLoadingRequests):
2120 (WebCore::CheckCacheObjectStatus):
2122 (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
2123 (WebCore::Frame::Frame):
2124 (WebCore::Frame::stopLoading):
2125 (WebCore::Frame::setAutoLoadImages):
2126 (WebCore::Frame::autoLoadImages):
2127 (WebCore::Frame::begin):
2128 (WebCore::Frame::checkCompleted):
2129 (WebCore::Frame::reparseConfiguration):
2131 * xml/XSLTProcessor.cpp:
2132 (WebCore::docLoaderFunc):
2133 * xml/xmlhttprequest.cpp:
2134 (WebCore::XMLHttpRequest::send):
2136 2006-10-18 Maciej Stachowiak <mjs@apple.com>
2140 - remove vestiges of KXMLCore name (former name of WTF).
2144 2006-10-18 Geoffrey Garen <ggaren@apple.com>
2148 Fixed http://bugs.webkit.org/show_bug.cgi?id=11222
2150 Some global JS objects lacked references to their property hashtables,
2151 so for-in enumeration didn't work. I added the references, and then removed
2152 a few bogus properties from the tables. The bogus ones got in there through
2155 We should come up with some solution to these hand-written bindings bugs.
2156 Maybe we could use a script to autogenerate them or something.
2158 * bindings/js/kjs_window.cpp:
2160 (KJS::History::getValueProperty):
2162 2006-10-18 Adam Roben <aroben@apple.com>
2166 Change Shift-Tab to generate keyIdentifier U+000009 (Tab) instead of
2167 U+000019 (Backtab). This matches our windowsKeyCode for this key
2170 * platform/mac/KeyEventMac.mm:
2171 (WebCore::keyIdentifierForKeyEvent):
2173 2006-10-18 Steve Falkenburg <sfalken@apple.com>
2175 Reviewed by Adam, Brady.
2179 * platform/cf/ResourceLoaderCFNet.cpp:
2180 (WebCore::didFinishLoading):
2182 (WebCore::didReceiveChallenge):
2183 (WebCore::runLoaderThread):
2184 (WebCore::ResourceLoader::start):
2185 (WebCore::ResourceLoader::cancel):
2187 2006-10-18 Timothy Hatcher <timothy@apple.com>
2191 <rdar://problem/4752138> Manipulating popup in HTML page crashed Xcode
2193 - Store the Mac popup button cell as a RetainPtr to prevent GC collection.
2194 - Convert more ObjC local statics and member variables to use RetainPtr.
2195 - Convert more CFRetain/CFRelease to HardRetain/HardRelease.
2197 * bindings/objc/DOM.mm:
2198 (ObjCNodeFilterCondition::ObjCNodeFilterCondition): use HardRetain and not CFRetain
2199 (ObjCNodeFilterCondition::~ObjCNodeFilterCondition): use HardRelease and not CFRelease
2200 * bridge/mac/AXObjectCacheMac.mm:
2201 (WebCore::AXObjectCache::~AXObjectCache): use HardRelease and not CFRelease
2202 (WebCore::AXObjectCache::get): use HardRetain and not CFRetain
2203 (WebCore::AXObjectCache::remove): use HardRelease and not CFRelease
2204 * bridge/mac/WebCoreFrameBridge.mm:
2205 (+[WebCoreFrameBridge supportedImageResourceMIMETypes]): use RetainPtr
2206 (+[WebCoreFrameBridge supportedImageMIMETypes]): ditto
2207 * bridge/mac/WebCoreIconDatabaseBridge.mm:
2208 (+[WebCoreIconDatabaseBridge sharedInstance]): use RetainPtr
2209 * platform/PopupMenu.h: renamed popup to m_popup and switched to RetainPtr<NSPopUpButtonCell>
2210 * platform/cf/RetainPtr.h:
2211 (WTF::::operator): implement a missing operator= template function
2212 * platform/mac/PopupMenuMac.mm:
2213 (WebCore::PopupMenu::PopupMenu): remove nil initialization
2214 (WebCore::PopupMenu::~PopupMenu): use .get(), remove release message and rename to m_popup
2215 (WebCore::PopupMenu::clear): use .get() when sending a message and rename to m_popup
2216 (WebCore::PopupMenu::populate): ditto
2217 (WebCore::PopupMenu::show): ditto
2218 (WebCore::PopupMenu::hide): ditto
2219 (WebCore::PopupMenu::addSeparator): ditto
2220 (WebCore::PopupMenu::addGroupLabel): ditto
2221 (WebCore::PopupMenu::addOption): ditto
2223 2006-10-18 Geoffrey Garen <ggaren@apple.com>
2227 Fixed <rdar://problem/3673233> JavaScript timers do not fire if controls
2228 are tracking or menus are down (run loop modes)
2230 I spent a few hours trying to write an automated test, but DRT doesn't
2231 seem to support it. Manual tests attached to related bugs.
2233 * bridge/mac/FrameMac.mm:
2234 (WebCore::FrameMac::passMouseDownEventToWidget):
2235 * platform/mac/SharedTimerMac.cpp:
2236 (WebCore::setSharedTimerFireTime):
2238 2006-10-18 Sam Weinig <sam.weinig@gmail.com>
2242 More Win32 buildfix.
2244 * bridge/win/FrameWin.h:
2246 2006-10-18 Sam Weinig <sam.weinig@gmail.com>
2252 * bridge/win/BrowserExtensionWin.cpp:
2253 (WebCore::BrowserExtensionWin::BrowserExtensionWin):
2254 (WebCore::BrowserExtensionWin::createNewWindow):
2255 * bridge/win/BrowserExtensionWin.h:
2256 * bridge/win/FrameWin.cpp:
2257 (WebCore::FrameWin::createNewWindow):
2258 * bridge/win/FrameWin.h:
2259 * platform/win/CursorWin.cpp:
2260 * platform/win/TemporaryLinkStubs.cpp:
2261 (Image::getHBITMAP):
2263 2006-10-18 Justin Garcia <justin.garcia@apple.com>
2265 Reviewed by harrison
2267 <rdar://problem/4784823>
2268 GMail Editor: Hang occurs when removing list styling on text in a rich text message
2270 List removal moves the contents of every list item out of the list it's
2271 in. When the code tried to move the contents of an empty list item (an li
2272 with no child nodes, not even a placeholder br), moveParagraph didn't prune
2273 the li, like it would if the li had a placeholder inside it. So the list
2274 removal code went into an infinite loop, continually attempting to de-list
2277 * editing/CompositeEditCommand.cpp:
2278 (WebCore::CompositeEditCommand::moveParagraphs): If the selection
2279 to move was empty and in an empty block that doesn't require a
2280 placeholder to prop itself open (like a bordered div or an li),
2281 remove it during the move.
2283 2006-10-18 Adele Peterson <adele@apple.com>
2287 - Fixed http://bugs.webkit.org/show_bug.cgi?id=11343
2288 REGRESSION (r16975): fast/events/objc-event-api is failing
2290 When I moved the autoscroll code from FrameMac to Frame, I mistakingly changed the order of
2291 a call to invalidateClick. This change moves it back to the sequence that existed before. This allows
2292 the click count to get properly reset during a selection.
2294 * page/Frame.cpp: (WebCore::Frame::handleMouseMoveEvent):
2296 2006-10-17 Geoffrey Garen <ggaren@apple.com>
2300 Factored common scaling code into a helper function.
2302 * platform/mac/ScreenMac.mm:
2304 (WebCore::scaleScreenRectToPageCoordinates):
2305 (WebCore::scalePageRectToScreenCoordinates):
2307 2006-10-17 Steve Falkenburg <sfalken@apple.com>
2311 * bridge/win/BrowserExtensionWin.cpp:
2312 (WebCore::BrowserExtensionWin::createNewWindow):
2313 * bridge/win/BrowserExtensionWin.h:
2314 * bridge/win/FrameWin.cpp:
2315 (WebCore::FrameWin::createNewWindow):
2316 * bridge/win/FrameWin.h:
2317 * platform/gdk/BrowserExtensionGdk.h:
2318 * platform/gdk/TemporaryLinkStubs.cpp:
2319 (BrowserExtensionGdk::createNewWindow):
2320 * platform/qt/BrowserExtensionQt.cpp:
2321 (WebCore::BrowserExtensionQt::createNewWindow):
2322 * platform/qt/BrowserExtensionQt.h:
2324 2006-10-17 Geoffrey Garen <ggaren@apple.com>
2328 Renamed WindowArgs to WindowFeatures, and moved it into its own header.
2329 ("Features" is the term of art in IE documentation. "Args" is pirate
2332 * WebCore.xcodeproj/project.pbxproj:
2333 * bindings/js/kjs_window.cpp:
2334 (KJS::createNewWindow):
2335 (KJS::showModalDialog):
2336 (KJS::setWindowFeature):
2337 (KJS::parseWindowFeatures):
2338 (KJS::constrainToVisible):
2339 (KJS::WindowFunc::callAsFunction):
2340 * bridge/BrowserExtension.h:
2341 * bridge/WindowFeatures.h: Added.
2342 * bridge/mac/BrowserExtensionMac.h:
2343 * bridge/mac/BrowserExtensionMac.mm:
2344 (WebCore::BrowserExtensionMac::createNewWindow):
2346 2006-10-17 Sam Weinig <sam.weinig@gmail.com>
2350 Patch for http://bugs.webkit.org/show_bug.cgi?id=11268
2351 Implement the Objective-C DOM bindings for SVGNumber, SVGRect, and SVGPoint
2353 - Adds implementation for DOMSVGNumber, DOMSVGRect, and DOMSVGPoint.
2355 - Moves the contents of ksvg/bindings/js/ to bindings/js/.
2357 - Moves SVGZoomEvent.idl from ksvg/svg/ to ksvg/events/.
2359 - Adds isSVGColor() and isSVGPaint() methods to StyleBase, matching
2360 the other CSSValue classing, and allowing the bindings to allocate
2363 - Removes #ifdefs around the getBBox() method in SVGLocatable.idl allowing
2364 generation for Objective-C.
2366 - Assorted style cleanups.
2368 * DerivedSources.make:
2369 * WebCore.xcodeproj/project.pbxproj:
2370 * bindings/objc/DOMCSS.mm:
2371 (+[DOMCSSValue _CSSValueWith:WebCore::]):
2372 * bindings/objc/DOMEvents.mm:
2373 (+[DOMEvent _eventWith:WebCore::]):
2374 * bindings/objc/DOMSVG.h:
2375 * bindings/objc/DOMSVGNumber.mm:
2376 (-[DOMSVGNumber dealloc]):
2377 (-[DOMSVGNumber finalize]):
2378 (-[DOMSVGNumber value]):
2379 (-[DOMSVGNumber setValue:]):
2380 (-[DOMSVGNumber _SVGNumber]):
2381 (-[DOMSVGNumber _initWithFloat:]):
2382 (+[DOMSVGNumber _SVGNumberWith:]):
2383 * bindings/objc/DOMSVGPoint.mm:
2384 (-[DOMSVGPoint dealloc]):
2385 (-[DOMSVGPoint finalize]):
2387 (-[DOMSVGPoint setX:]):
2389 (-[DOMSVGPoint setY:]):
2390 (-[DOMSVGPoint WebCore::]):
2391 (-[DOMSVGPoint _initWithFloatPoint:WebCore::]):
2392 (+[DOMSVGPoint _SVGPointWith:WebCore::]):
2393 * bindings/objc/DOMSVGRect.mm:
2394 (-[DOMSVGRect dealloc]):
2395 (-[DOMSVGRect finalize]):
2397 (-[DOMSVGRect setX:]):
2399 (-[DOMSVGRect setY:]):
2400 (-[DOMSVGRect width]):
2401 (-[DOMSVGRect setWidth:]):
2402 (-[DOMSVGRect height]):
2403 (-[DOMSVGRect setHeight:]):
2404 (-[DOMSVGRect WebCore::]):
2405 (-[DOMSVGRect _initWithFloatRect:WebCore::]):
2406 (+[DOMSVGRect _SVGRectWith:WebCore::]):
2407 * bindings/scripts/CodeGeneratorObjC.pm:
2409 (WebCore::StyleBase::isSVGColor):
2410 (WebCore::StyleBase::isSVGPaint):
2411 * ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp: Removed.
2412 * ksvg2/bindings/js/JSSVGElementWrapperFactory.h: Removed.
2413 * ksvg2/bindings/js/JSSVGNumber.cpp: Removed.
2414 * ksvg2/bindings/js/JSSVGNumber.h: Removed.
2415 * ksvg2/bindings/js/JSSVGPoint.cpp: Removed.
2416 * ksvg2/bindings/js/JSSVGPoint.h: Removed.
2417 * ksvg2/bindings/js/JSSVGRect.cpp: Removed.
2418 * ksvg2/bindings/js/JSSVGRect.h: Removed.
2419 * ksvg2/svg/SVGColor.h:
2420 (WebCore::SVGColor::isSVGColor):
2421 * ksvg2/svg/SVGFECompositeElement.idl:
2422 * ksvg2/svg/SVGFEFloodElement.idl:
2423 * ksvg2/svg/SVGLocatable.idl:
2424 * ksvg2/svg/SVGMarkerElement.idl:
2425 * ksvg2/svg/SVGPaint.h:
2426 (WebCore::SVGPaint::isSVGPaint):
2427 * ksvg2/svg/SVGRectElement.idl:
2428 * ksvg2/svg/SVGZoomEvent.idl: Removed.
2430 2006-10-17 David Hyatt <hyatt@apple.com>
2432 Prepare for the elimination of the RenderLayer for <html> elements. The layer is still present,
2433 but this patch makes everything work without a root layer being around.
2437 * rendering/RenderBlock.cpp:
2438 (WebCore::RenderBlock::paint):
2439 (WebCore::RenderBlock::paintChildren):
2440 (WebCore::RenderBlock::nodeAtPoint):
2441 * rendering/RenderLayer.cpp:
2442 (WebCore::frameVisibleRect):
2443 (WebCore::RenderLayer::hitTest):
2444 (WebCore::RenderLayer::hitTestLayer):
2445 (WebCore::RenderLayer::intersectsDamageRect):
2446 * rendering/RenderObject.cpp:
2447 (WebCore::RenderObject::setInnerNode):
2448 * rendering/RenderView.cpp:
2449 (WebCore::RenderView::paint):
2451 2006-10-17 David Hyatt <hyatt@apple.com>
2453 Back out my previous patch to the WebCore memory cache.
2456 (WebCore::Cache::flush):
2457 (WebCore::Cache::setSize):
2458 (WebCore::Cache::getLRUListFor):
2459 (WebCore::Cache::removeFromLRUList):
2460 (WebCore::Cache::insertInLRUList):
2462 * loader/CachedCSSStyleSheet.cpp:
2463 (WebCore::CachedCSSStyleSheet::deref):
2464 * loader/CachedCSSStyleSheet.h:
2465 * loader/CachedImage.cpp:
2466 (WebCore::CachedImage::deref):
2467 * loader/CachedImage.h:
2468 * loader/CachedResource.cpp:
2469 (WebCore::CachedResource::setRequest):
2470 (WebCore::CachedResource::deref):
2471 * loader/CachedResource.h:
2472 (WebCore::CachedResource::allowInLRUList):
2473 * loader/CachedScript.cpp:
2474 (WebCore::CachedScript::deref):
2475 * loader/CachedScript.h:
2476 * loader/CachedXBLDocument.cpp:
2477 (WebCore::CachedXBLDocument::deref):
2478 * loader/CachedXBLDocument.h:
2479 * loader/CachedXSLStyleSheet.cpp:
2480 (WebCore::CachedXSLStyleSheet::deref):
2481 * loader/CachedXSLStyleSheet.h:
2483 2006-10-17 Oliver Hunt <oliver@apple.com>
2487 Make north and east resize cursors use correct image
2489 * platform/win/CursorWin.cpp:
2490 (WebCore::eastResizeCursor):
2491 (WebCore::northResizeCursor):
2493 2006-10-17 Oliver Hunt <oliver@apple.com>
2497 Various cursor fixes
2499 * page/FrameView.cpp:
2500 (WebCore::FrameView::handleMouseMoveEvent):
2501 * platform/Cursor.h:
2502 * platform/mac/CursorMac.mm:
2503 (WebCore::pointerCursor):
2504 * platform/win/CursorWin.cpp:
2505 (WebCore::supportsAlphaCursors):
2506 (WebCore::Cursor::Cursor):
2507 (WebCore::Cursor::~Cursor):
2508 (WebCore::pointerCursor):
2510 2006-10-17 Justin Garcia <justin.garcia@apple.com>
2512 Reviewed by harrison
2514 <rdar://problem/4776665>
2515 REGRESSION: In Mail, caret is visible when the message body isn't focused
2518 (WebCore::Frame::paintCaret): If a caret blink timer is ever on in error
2519 (like when the frame that contains the caret isn't focused) then we don't
2520 want to paint the caret. We should eventually move to using a single bool
2523 2006-10-17 Justin Garcia <justin.garcia@apple.com>
2525 Reviewed by harrison
2527 <rdar://problem/4774354>
2528 REGRESSION: In Gmail, caret reappears when dragging a selection over some text in the message body
2530 Functions call recomputCaretRect to see if the caret rect has changed,
2531 and, if it has, they invalidate (repaint) it. recomputeCaretRect was
2532 returning false if the caret turned into a range selection or was blown
2535 * editing/SelectionController.cpp:
2536 (WebCore::SelectionController::recomputeCaretRect): Don't early return if
2537 !isCaret(). Obtain the FrameView* using the m_frame pointer, because m_sel
2540 2006-10-17 Geoffrey Garen <ggaren@apple.com>
2544 BrowserExtension cleanup.
2546 - Removed unnecessary #include of BrowserExtension in Frame.h, added
2547 #includes to compensate in other files.
2549 - Removed unused versions of createNewWindow.
2551 * bindings/js/kjs_window.cpp:
2552 * bridge/BrowserExtension.h:
2553 * bridge/mac/BrowserExtensionMac.h:
2554 * bridge/mac/BrowserExtensionMac.mm:
2555 (WebCore::BrowserExtensionMac::createNewWindow):
2556 * bridge/mac/WebCoreFrameBridge.mm:
2557 * html/HTMLFormElement.cpp:
2558 * loader/mac/LoaderFunctionsMac.mm:
2560 * page/FramePrivate.h:
2562 2006-10-15 Geoffrey Garen <ggaren@apple.com>
2566 - Fixed "FIXME: Violates Liskov Substitution principle."
2568 IFRAME was never a true subclass of FRAME, since they disagreed on a
2569 number of behaviors, which, confusingly, IFRAME just overrode and contradicted.
2571 The fix here is to factor out things common to IFRAME and FRAME into a
2572 common base class, HTMLFrameElementBase.
2574 I also changed some " *" to "* " and added #includes in files that implicitly
2575 assumed that HTMLIFrameElement.h #included HTMLFrameElement.h.
2577 2006-10-16 Justin Garcia <justin.garcia@apple.com>
2579 Reviewed by sullivan
2581 <rdar://problem/4776765>
2582 REGRESSION: Caret's ghost left behind after inserting a paragraph separator (11237)
2584 We set m_needsLayout to false and call caretRect() in the hopes that it will give us
2585 the old caret rect. It in fact corrects the caret rect for an offset that it
2586 believes is due to scrolling but which is actually due to a change in selection
2587 without an accompanying layout. So it returns the new caret rect regardless of
2588 what m_needsLayout is set to.
2590 * editing/SelectionController.cpp:
2591 (WebCore::repaintRectForCaret): Moved the code from caretRepaintRect that
2592 adds a one pixel slop to this new function.
2593 (WebCore::SelectionController::caretRepaintRect): Moved this code to
2594 repaintRectForCaret.
2595 (WebCore::SelectionController::recomputeCaretRect): Compare the old
2596 caret rect to the new one that's computed with a fresh layout. If
2597 they are different, invalidate both repaint rects.
2599 2006-10-17 David Harrison <harrison@apple.com>
2603 <rdar://problem/4770453> VO not honoring secure edit fields in web pages
2605 * bridge/mac/WebCoreAXObject.mm:
2606 (-[WebCoreAXObject isPasswordField]):
2607 New. Checks for input with inputType() of PASSWORD.
2609 (-[WebCoreAXObject subrole]):
2610 Returns NSAccessibilitySecureTextFieldSubrole if [self isPasswordField].
2612 (-[WebCoreAXObject roleDescription]):
2613 Pass [self subrole] instead of nil when calling NSAccessibilityRoleDescription.
2615 (-[WebCoreAXObject value]):
2616 Return nil if [self isPasswordField].
2618 (-[WebCoreAXObject accessibilityAttributeNames]):
2619 Return generic attributes if [self isPasswordField].
2621 (-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
2622 Return empty array if [self isPasswordField].
2624 2006-10-17 David Hyatt <hyatt@apple.com>
2626 Fix "flash to white' problem on yahoo.com as it finishes loading. Refine the FOUC suppression
2627 code so that it will only run if the body still has no renderer.
2630 (WebCore::Document::updateLayoutIgnorePendingStylesheets):
2632 2006-10-17 David Hyatt <hyatt@apple.com>
2634 Fix a bug where the WebCore memory cache could grow without bound during extended browsing
2640 (WebCore::Cache::flush):
2641 (WebCore::Cache::setSize):
2642 (WebCore::Cache::getLRUListFor):
2643 (WebCore::Cache::removeFromLRUList):
2644 (WebCore::Cache::insertInLRUList):
2646 * loader/CachedCSSStyleSheet.cpp:
2647 * loader/CachedCSSStyleSheet.h:
2648 * loader/CachedImage.cpp:
2649 * loader/CachedImage.h:
2650 * loader/CachedResource.cpp:
2651 (WebCore::CachedResource::setRequest):
2652 (WebCore::CachedResource::deref):
2653 * loader/CachedResource.h:
2654 (WebCore::CachedResource::allowInLRUList):
2655 * loader/CachedScript.cpp:
2656 * loader/CachedScript.h:
2657 * loader/CachedXBLDocument.cpp:
2658 * loader/CachedXBLDocument.h:
2659 * loader/CachedXSLStyleSheet.cpp:
2660 * loader/CachedXSLStyleSheet.h:
2662 2006-10-13 Justin Garcia <justin.garcia@apple.com>
2664 Reviewed by harrison
2666 <rdar://problem/3655385>
2667 Editing: -indent: method unimplemented
2669 Added Frame and bridge methods.
2671 * bridge/mac/WebCoreFrameBridge.h:
2672 * bridge/mac/WebCoreFrameBridge.mm:
2673 (-[WebCoreFrameBridge indent]):
2674 (-[WebCoreFrameBridge outdent]):
2676 (WebCore::Frame::indent):
2677 (WebCore::Frame::outdent):
2680 2006-10-16 Adam Roben <aroben@apple.com>
2684 More menulist cleanup/tweaking.
2686 * html/HTMLSelectElement.cpp:
2687 (WebCore::HTMLSelectElement::setSelectedIndex): Renamed 'index'
2688 parameter to 'optionIndex' for clarity.
2689 (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Skip over
2690 items that are not enabled <option> elements when using arrow keys, and
2691 make sure we pass an option index to setSelectedIndex.
2692 * platform/PopupMenu.h:
2693 (WebCore::PopupMenu::setWasClicked): Specify default argument.
2694 * rendering/RenderMenuList.cpp:
2695 (WebCore::RenderMenuList::setTextFromOption): Strip whitespace from
2696 option text before setting the control text so that options within
2697 <optgroup>s don't appear indented in the actual control.
2699 2006-10-16 Sam Weinig <sam.weinig@gmail.com>
2705 * WebCore.vcproj/WebCore/WebCore.vcproj:
2706 * bridge/win/BrowserExtensionWin.cpp:
2707 (WebCore::BrowserExtensionWin::createNewWindow):
2708 * bridge/win/FrameWin.cpp:
2709 (WebCore::FrameWin::urlSelected):
2710 (WebCore::FrameWin::submitForm):
2711 (WebCore::FrameWin::createNewWindow):
2712 * bridge/win/FrameWin.h:
2713 * loader/loader.cpp:
2714 (WebCore::Loader::receivedResponse):
2715 * platform/win/GraphicsContextWin.cpp:
2716 (WebCore::GraphicsContext::getWindowsContext):
2717 (WebCore::GraphicsContext::releaseWindowsContext):
2718 * platform/win/TemporaryLinkStubs.cpp:
2719 (FrameWin::openURLRequest):
2720 (WebCore::ServeSynchronousRequest):
2721 (WebCore::CheckIfReloading):
2722 (WebCore::IsResponseURLEqualToURL):
2723 (WebCore::ResponseMIMEType):
2724 (WebCore::ResponseIsMultipart):
2725 (WebCore::CacheObjectExpiresTime):
2726 (CachedResource::setResponse):
2727 (CachedResource::setAllData):
2728 * rendering/RenderThemeWin.cpp:
2729 (WebCore::doneDrawing):
2730 (WebCore::RenderThemeWin::paintButton):
2731 (WebCore::RenderThemeWin::paintTextField):
2733 2006-10-16 David Hyatt <hyatt@apple.com>
2735 Fix for bug 9347, positioned elements have the wrong containing block. This is a change from CSS2 to
2736 CSS2.1. In the absence of any other enclosing positioned elements, the containing block for a positioned
2737 element is the initial containing block (our RenderView).
2741 Test cases added to fast/block/positioning for quirks and strict modes.
2743 * rendering/RenderBlock.cpp:
2744 (WebCore::RenderBlock::lowestPosition):
2745 (WebCore::RenderBlock::rightmostPosition):
2746 (WebCore::RenderBlock::leftmostPosition):
2747 * rendering/RenderBox.cpp:
2748 (WebCore::RenderBox::containingBlockHeightForPositioned):
2749 (WebCore::RenderBox::calcAbsoluteVertical):
2750 * rendering/RenderObject.cpp:
2751 (WebCore::RenderObject::containingBlock):
2752 (WebCore::RenderObject::container):
2754 2006-10-15 Krzysztof Kowalczyk <kkowalczyk@gmail.com>
2758 Misc Gdk/Linux build fixes.
2760 * platform/gdk/BrowserExtensionGdk.h:
2761 * platform/gdk/FrameGdk.cpp:
2762 (WebCore::FrameGdk::submitForm):
2763 (WebCore::FrameGdk::urlSelected):
2764 * platform/gdk/FrameGdk.h:
2765 * platform/gdk/RenderPopupMenuGdk.cpp:
2766 (WebCore::PopupMenu::PopupMenu):
2767 (WebCore::PopupMenu::~PopupMenu):
2768 (WebCore::PopupMenu::clear):
2769 (WebCore::PopupMenu::populate):
2770 (WebCore::PopupMenu::show):
2771 (WebCore::PopupMenu::hide):
2772 (WebCore::PopupMenu::addSeparator):
2773 (WebCore::PopupMenu::addGroupLabel):
2774 (WebCore::PopupMenu::addOption):
2775 * platform/gdk/RenderPopupMenuGdk.h:
2776 * platform/gdk/RenderThemeGdk.cpp:
2777 * platform/gdk/RenderThemeGdk.h:
2778 (WebCore::RenderThemeGdk::RenderThemeGdk):
2779 * platform/gdk/TemporaryLinkStubs.cpp:
2780 (BrowserExtensionGdk::createNewWindow):
2781 (BrowserExtensionGdk::BrowserExtensionGdk):
2782 (BrowserExtensionGdk::setTypedIconURL):
2783 (BrowserExtensionGdk::setIconURL):
2784 (BrowserExtensionGdk::getHistoryLength):
2785 (WebCore::CheckIfReloading):
2786 (WebCore::CacheObjectExpiresTime):
2787 (WebCore::ResponseURL):
2788 (WebCore::IsResponseURLEqualToURL):
2789 (WebCore::ResponseIsMultipart):
2790 (WebCore::ResponseMIMEType):
2791 (WebCore::CachedResource::setResponse):
2792 (WebCore::CachedResource::setAllData):
2793 (FileChooser::disconnectUploadControl):
2794 * rendering/RenderTheme.h:
2795 * rendering/RenderThemeMac.h:
2797 2006-10-15 Sam Weinig <sam.weinig@gmail.com>
2801 Fix for http://bugs.webkit.org/show_bug.cgi?id=11294
2802 Add getModifierState method to KeyboardEvent
2804 * bindings/objc/DOMEvents.h:
2805 * bindings/objc/DOMEvents.mm:
2806 * bindings/objc/PublicDOMInterfaces.h:
2807 * dom/KeyboardEvent.cpp:
2808 (WebCore::KeyboardEvent::getModifierState):
2809 * dom/KeyboardEvent.h:
2810 * dom/KeyboardEvent.idl:
2812 2006-10-15 Nikolas Zimmermann <zimmermann@kde.org>
2814 Reviewed and landed by ap.
2816 Changed PlatformResponse handling for Qt. Don't just store
2817 a QString object containing the data but a new PlatformResponseQt struct
2818 containing data and url, and store it as pointer. This is compatible
2819 to the OS X handling and removes the Qt plaform specific hacks from
2820 CachedCSSStyleSheet, CachedResource & loader.
2822 Add new file LoaderFunctionsQt, similar to LoaderFunctionsMac, and move
2823 all methods from TemporaryLinkStubs related to loading in there, and implement
2824 some like ServeSynchronousRequest (yay for xslt handling!).
2827 * loader/CachedCSSStyleSheet.cpp:
2828 (WebCore::CachedCSSStyleSheet::checkNotify):
2829 * loader/CachedResource.h:
2830 (WebCore::CachedResource::CachedResource):
2831 * loader/loader.cpp:
2832 (WebCore::Loader::receivedResponse):
2833 * platform/ResourceLoaderClient.h:
2834 * platform/ResourceLoaderInternal.h:
2835 * platform/qt/FrameQt.cpp:
2836 (WebCore::FrameQt::~FrameQt):
2837 (WebCore::FrameQt::createEmptyDocument):
2838 * platform/qt/FrameQt.h:
2840 * platform/qt/FrameQtClient.cpp:
2841 (WebCore::FrameQtClientDefault::setFrame):
2842 (WebCore::FrameQtClientDefault::openURL):
2843 (WebCore::FrameQtClientDefault::loadFinished):
2844 (WebCore::FrameQtClientDefault::receivedAllData):
2845 * platform/qt/FrameQtClient.h:
2846 * platform/qt/LoaderFunctionsQt.cpp: Added.
2847 (WebCore::ServeSynchronousRequest):
2848 (WebCore::NumberOfPendingOrLoadingRequests):
2849 (WebCore::CheckIfReloading):
2850 (WebCore::CheckCacheObjectStatus):
2851 (WebCore::IsResponseURLEqualToURL):
2852 (WebCore::ResponseURL):
2853 (WebCore::ResponseMIMEType):
2854 (WebCore::ResponseIsMultipart):
2855 (WebCore::CacheObjectExpiresTime):
2856 (WebCore::CachedResource::setResponse):
2857 (WebCore::CachedResource::setAllData):
2858 * platform/qt/ResourceLoaderManager.cpp:
2859 (WebCore::ResourceLoaderManager::remove):
2860 * platform/qt/ResourceLoaderQt.cpp:
2861 (WebCore::ResourceLoader::~ResourceLoader):
2862 (WebCore::ResourceLoader::start):
2863 (WebCore::ResourceLoader::assembleResponseHeaders):
2864 (WebCore::ResourceLoader::receivedResponse):
2865 * platform/qt/TemporaryLinkStubs.cpp:
2867 2006-10-14 Rob Buis <buis@kde.org>
2871 http://bugs.webkit.org/show_bug.cgi?id=11217
2872 Cleanup svg coding style
2874 Cleanup coding style in svg basic datastructure classes.
2876 * ksvg2/svg/SVGAngle.cpp:
2877 (WebCore::SVGAngle::valueAsString):
2878 (WebCore::SVGAngle::context):
2879 (WebCore::SVGAngle::setContext):
2880 * ksvg2/svg/SVGAngle.h:
2881 * ksvg2/svg/SVGColor.cpp:
2882 * ksvg2/svg/SVGColor.h:
2883 * ksvg2/svg/SVGElement.cpp:
2884 (WebCore::SVGElement::ownerSVGElement):
2885 (WebCore::SVGElement::viewportElement):
2886 (WebCore::SVGElement::parseMappedAttribute):
2887 (WebCore::SVGElement::childShouldCreateRenderer):
2888 * ksvg2/svg/SVGElement.h:
2889 (WebCore::svg_dynamic_cast):
2890 * ksvg2/svg/SVGFitToViewBox.cpp:
2891 (WebCore::SVGFitToViewBox::parseViewBox):
2892 * ksvg2/svg/SVGFitToViewBox.h:
2893 * ksvg2/svg/SVGLangSpace.cpp:
2894 (WebCore::SVGLangSpace::parseMappedAttribute):
2895 * ksvg2/svg/SVGLangSpace.h:
2896 * ksvg2/svg/SVGLength.cpp:
2897 (WebCore::SVGLength::SVGLength):
2898 (WebCore::SVGLength::setValueAsString):
2899 (WebCore::SVGLength::dpi):
2900 (WebCore::SVGLength::updateValue):
2901 (WebCore::SVGLength::updateValueInSpecifiedUnits):
2902 (WebCore::SVGLength::context):
2903 (WebCore::SVGLength::setContext):
2904 * ksvg2/svg/SVGLength.h:
2905 * ksvg2/svg/SVGLengthList.cpp:
2906 * ksvg2/svg/SVGLengthList.h:
2907 * ksvg2/svg/SVGLocatable.cpp:
2908 (WebCore::SVGLocatable::nearestViewportElement):
2909 (WebCore::SVGLocatable::farthestViewportElement):
2910 (WebCore::SVGLocatable::getBBox):
2911 (WebCore::SVGLocatable::getCTM):
2912 (WebCore::SVGLocatable::getScreenCTM):
2913 * ksvg2/svg/SVGNumberList.cpp:
2914 * ksvg2/svg/SVGNumberList.h:
2915 * ksvg2/svg/SVGPreserveAspectRatio.cpp:
2916 (WebCore::SVGPreserveAspectRatio::SVGPreserveAspectRatio):
2917 (WebCore::SVGPreserveAspectRatio::getCTM):
2918 * ksvg2/svg/SVGPreserveAspectRatio.h:
2919 * ksvg2/svg/SVGStringList.cpp:
2920 (WebCore::SVGStringList::reset):
2921 * ksvg2/svg/SVGStringList.h:
2922 * ksvg2/svg/SVGStylable.cpp:
2923 * ksvg2/svg/SVGStylable.h:
2924 * ksvg2/svg/SVGTests.cpp:
2925 (WebCore::SVGTests::requiredFeatures):
2926 (WebCore::SVGTests::requiredExtensions):
2927 (WebCore::SVGTests::systemLanguage):
2928 (WebCore::SVGTests::isValid):
2929 (WebCore::SVGTests::parseMappedAttribute):
2930 * ksvg2/svg/SVGTests.h:
2931 * ksvg2/svg/SVGTransformable.cpp:
2932 (WebCore::SVGTransformable::parseTransformAttribute):
2933 * ksvg2/svg/SVGTransformable.h:
2934 * ksvg2/svg/SVGURIReference.cpp:
2935 (WebCore::SVGURIReference::parseMappedAttribute):
2936 * ksvg2/svg/SVGZoomAndPan.cpp:
2937 (WebCore::SVGZoomAndPan::parseMappedAttribute):
2938 * ksvg2/svg/SVGZoomAndPan.h:
2940 2006-10-15 Nikolas Zimmermann <zimmermann@kde.org>
2944 Implement some functions in FrameQt / ScrollViewQt.
2946 Added comments what needs to be done in quite some places,
2947 marked some functions as no-ops.
2950 * platform/qt/FrameQt.cpp:
2951 (WebCore::FrameQt::FrameQt):
2952 (WebCore::FrameQt::runJavaScriptConfirm):
2953 (WebCore::FrameQt::locationbarVisible):
2954 (WebCore::FrameQt::createFrame):
2955 (WebCore::FrameQt::passSubframeEventToSubframe):
2956 (WebCore::FrameQt::menubarVisible):
2957 (WebCore::FrameQt::personalbarVisible):
2958 (WebCore::FrameQt::statusbarVisible):
2959 (WebCore::FrameQt::toolbarVisible):
2960 (WebCore::FrameQt::markedTextRange):
2961 (WebCore::FrameQt::lastEventIsMouseUp):
2962 (WebCore::FrameQt::openURLRequest):
2963 (WebCore::FrameQt::scheduleClose):
2964 (WebCore::FrameQt::unfocusWindow):
2965 (WebCore::FrameQt::focusWindow):
2966 (WebCore::FrameQt::overrideMediaType):
2967 (WebCore::FrameQt::runJavaScriptPrompt):
2968 (WebCore::FrameQt::bindingRootObject):
2969 (WebCore::FrameQt::addPluginRootObject):
2970 (WebCore::FrameQt::registerCommandForUndo):
2971 (WebCore::FrameQt::registerCommandForRedo):
2972 (WebCore::FrameQt::clearUndoRedoOperations):
2973 (WebCore::FrameQt::respondToChangedSelection):
2974 (WebCore::FrameQt::respondToChangedContents):
2975 (WebCore::FrameQt::shouldChangeSelection):
2976 (WebCore::FrameQt::canGoBackOrForward):
2977 (WebCore::FrameQt::canPaste):
2978 (WebCore::FrameQt::canRedo):
2979 (WebCore::FrameQt::canUndo):
2980 * platform/qt/FrameQt.h:
2981 * platform/qt/FrameQtClient.cpp:
2982 (WebCore::FrameQtClientDefault::runJavaScriptAlert):
2983 (WebCore::FrameQtClientDefault::runJavaScriptConfirm):
2984 (WebCore::FrameQtClientDefault::runJavaScriptPrompt):
2985 (WebCore::FrameQtClientDefault::menubarVisible):
2986 (WebCore::FrameQtClientDefault::toolbarVisible):
2987 (WebCore::FrameQtClientDefault::statusbarVisible):
2988 (WebCore::FrameQtClientDefault::personalbarVisible):
2989 (WebCore::FrameQtClientDefault::locationbarVisible):
2990 * platform/qt/FrameQtClient.h:
2991 * platform/qt/ImageSourceQt.cpp:
2992 * platform/qt/RenderThemeQt.cpp:
2993 * platform/qt/ScrollViewQt.cpp:
2994 (WebCore::ScrollView::scrollPointRecursively):
2995 * platform/qt/TemporaryLinkStubs.cpp:
2996 (WebCore::CachedResource::setResponse):
2997 (WebCore::CachedResource::setAllData):
2999 2006-10-14 David Harrison <harrison@apple.com>
3003 <rdar://problem/4775213> REGRESSION: Can't from tab from last link on the page to URL address field
3004 <rdar://problem/4783926> REGRESSION: Typing tab key enters no text
3006 The problem is that EventTargetNode::defaultEventHandler() calls event->setDefaultHandled() regardless
3007 of whether frame->view()->advanceFocus() actually changed the focus.
3009 Trivial fix is to preventDefault() only if advanceFocus() returns true.
3011 * No test is possible because DumpRenderTree sets the WebView preference to
3012 tab to links, and that preference cannot be changed dynamically after
3013 the webview is initialized. Also, the "tab from last link" is not testable
3014 because DumpRenderTree uses the WebView for the whole window, so tabs can't
3015 shift focus out of the WebView regardless.
3017 * dom/EventTargetNode.cpp:
3018 (WebCore::EventTargetNode::defaultEventHandler):
3020 2006-10-14 Nikolas Zimmermann <zimmermann@kde.org>
3024 Fix Qt/Linux build & some little fixes:
3026 - Adapt to Maciej's FrameLoadRequest changes.
3027 - Fix response handling - don't try to compare with '0' - for us it's a non-ptr QString object.
3028 - Actually call setAllData from loader/loader.cpp (David Carson forgot that in his last commit)
3029 - Fix CacheObjectExpiresTime/ResponseIsMultipart signature.
3031 * loader/CachedCSSStyleSheet.cpp:
3032 (WebCore::CachedCSSStyleSheet::checkNotify):
3033 * loader/CachedResource.h:
3034 (WebCore::CachedResource::CachedResource):
3035 * loader/loader.cpp:
3036 (WebCore::Loader::receivedAllData):
3037 (WebCore::Loader::receivedResponse):
3038 * platform/qt/BrowserExtensionQt.cpp:
3039 (WebCore::BrowserExtensionQt::createNewWindow):
3040 * platform/qt/BrowserExtensionQt.h:
3041 * platform/qt/FrameQt.cpp:
3042 (WebCore::FrameQt::submitForm):
3043 (WebCore::FrameQt::urlSelected):
3044 (WebCore::FrameQt::openURLRequest):
3045 * platform/qt/FrameQt.h:
3046 * platform/qt/GraphicsContextQt.cpp:
3047 (WebCore::GraphicsContext::setURLForRect):
3048 * platform/qt/TemporaryLinkStubs.cpp:
3049 (WebCore::CacheObjectExpiresTime):
3050 (WebCore::ResponseIsMultipart):
3051 (WebCore::CachedResource::setResponse):
3052 (WebCore::CachedResource::setAllData):
3054 2006-10-14 David Carson <dacarson@gmail.com>
3058 Fix: http://bugs.webkit.org/show_bug.cgi?id=11257
3059 Removed Mac platform dependance, changed WebCore functions to
3060 use PlatformResponse/PlatformData rather than NSURLResponse/
3063 * loader/CachedCSSStyleSheet.cpp:
3064 (WebCore::CachedCSSStyleSheet::checkNotify):
3065 * loader/CachedImage.cpp:
3066 (WebCore::CachedImage::createImage):
3067 * loader/CachedResource.cpp:
3068 (WebCore::CachedResource::~CachedResource):
3069 * loader/CachedResource.h:
3070 (WebCore::CachedResource::CachedResource):
3071 (WebCore::CachedResource::response):
3072 (WebCore::CachedResource::allData):
3073 * loader/LoaderFunctions.h:
3074 * loader/loader.cpp:
3075 (WebCore::Loader::receivedResponse):
3076 * loader/mac/LoaderFunctionsMac.mm:
3077 (WebCore::ResponseMIMEType):
3078 (WebCore::ResponseIsMultipart):
3079 (WebCore::CacheObjectExpiresTime):
3080 (WebCore::CachedResource::setResponse):
3081 (WebCore::CachedResource::setAllData):
3082 * platform/qt/TemporaryLinkStubs.cpp:
3083 (WebCore::CacheObjectExpiresTime):
3084 (WebCore::ResponseIsMultipart):
3085 (WebCore::ResponseMIMEType):
3086 (WebCore::CachedResource::setResponse):
3087 (WebCore::CachedResource::setAllData):
3088 * platform/win/TemporaryLinkStubs.cpp:
3089 (WebCore::CacheObjectExpiresTime):
3090 (WebCore::ResponseIsMultipart):
3091 (WebCore::ResponseMIMEType):
3092 (WebCore::CachedResource::setResponse):
3093 (WebCore::CachedResource::setAllData):
3095 2006-10-14 Krzysztof Kowalczyk <kkowalczyk@gmail.com>
3099 Fix GDK build by defining FrameGdkClient() constructor as non-virtual.
3100 Pure virtual classes require non-pure destructor, who knew.
3102 Make CURL networking dependent on USE(CURL) instead of PLATFORM(GDK),
3103 so that other platforms can also use CURL, if they wish.
3105 Silence compiler warning about unused variable in SharedTimerLinux.cpp
3107 * platform/ResourceLoaderInternal.h:
3108 (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
3109 * platform/gdk/FrameGdk.h:
3110 (WebCore::FrameGdkClient::~FrameGdkClient):
3111 * platform/gdk/ResourceLoaderManager.cpp:
3112 (WebCore::ResourceLoaderManager::downloadTimerCallback):
3113 * platform/gdk/SharedTimerLinux.cpp:
3114 (WebCore::stopSharedTimer):
3116 2006-10-13 Beth Dakin <bdakin@apple.com>
3120 Build fix from my last check-in. Make hasOutlineAnnotation() non-
3121 inline so that we don't have to include Document.h in
3123 Doing so causes a build failure in WebKit, and it probably isn't a
3126 * rendering/RenderObject.cpp:
3127 (WebCore::RenderObject::hasOutlineAnnotation):
3128 * rendering/RenderObject.h:
3129 (WebCore::RenderObject::hasOutline):
3131 2006-10-13 Beth Dakin <bdakin@apple.com>
3133 Patch written mostly by Ken Kraisler, but also by me.
3137 Fix for http://bugs.webkit.org/show_bug.cgi?id=10216 and <rdar://
3138 problem/3391162> PDF created by printing should have live
3141 * platform/GraphicsContext.cpp:
3142 (WebCore::GraphicsContext::focusRingBoundingRect):
3143 * platform/GraphicsContext.h:
3144 * platform/cairo/GraphicsContextCairo.cpp:
3145 (WebCore::GraphicsContext::setURLForRect):
3146 * platform/cg/GraphicsContextCG.cpp:
3147 (WebCore::GraphicsContext::setURLForRect): Implement method to add
3148 URL link to PDF document.
3149 * rendering/InlineFlowBox.cpp:
3150 (WebCore::InlineFlowBox::paint): Ask hasOutline() instead of
3151 querying the outline width
3152 * rendering/RenderBlock.cpp:
3153 (WebCore::RenderBlock::paintObject): Same as above.
3154 * rendering/RenderFlow.cpp:
3155 (WebCore::RenderFlow::paintLines): Call the new paintOutline()
3156 (WebCore::RenderFlow::paintOutline): Take care of focus ring and
3157 pdf url rects, and outline painting.
3158 * rendering/RenderFlow.h:
3159 * rendering/RenderObject.cpp:
3160 (WebCore::RenderObject::addPDFURLRect): Declaration to apply a PDF
3161 link to a rectanglular region.
3162 (WebCore::RenderObject::paintOutline): Take care of pdf rects as
3163 well as focus ring painting.
3164 * rendering/RenderObject.h:
3165 (WebCore::RenderObject::hasOutlineAnnotation): Returns true is the
3166 element is a link and we are printing.
3167 (WebCore::RenderObject::hasOutline): Returns true is the style has
3168 an outline and hasOutlineAnnotation() is true.
3169 * rendering/RenderStyle.h:
3170 (WebCore::RenderStyle::hasOutline): Returns true if outlineWidth is
3171 greater than 0 and outlineStyle is greater than BHIDDEN.
3173 2006-10-13 Justin Garcia <justin.garcia@apple.com>
3175 Reviewed by ggaren and harrison
3177 <rdar://problem/4744008>
3178 9A270: Mail crashes when I try to paste large items from Safari
3180 * editing/ReplaceSelectionCommand.cpp:
3181 (WebCore::ReplaceSelectionCommand::removeRedundantStyles):
3182 Even though we put nodes in the hash map in pre-order, they don't necessary
3183 come out of the iterator that way. If a node is a redundant style span
3184 and one of its pruned ancestors comes off the hash map after it, and that
3185 ancestor is a redundant style span or font tag, we will try to remove it
3186 even though it has already been removed and we'll crash.
3187 The test case added with the fix depends on our hash map implementation
3188 because it requires that a particular redundant style span come out of
3189 the iterator before its parent. So, it may eventually not provide
3190 coverage for the fix.
3192 2006-10-13 Maciej Stachowiak <mjs@apple.com>
3196 - split FrameLoadRequest off from ResourceRequest - it's a ResourceRequest plus frame name plus lockHistory bool
3198 * WebCore.xcodeproj/project.pbxproj:
3199 * bindings/js/kjs_window.cpp:
3200 (KJS::createNewWindow):
3201 (KJS::WindowFunc::callAsFunction):
3202 * bridge/BrowserExtension.h:
3203 * bridge/mac/BrowserExtensionMac.h:
3204 * bridge/mac/BrowserExtensionMac.mm:
3205 (WebCore::BrowserExtensionMac::createNewWindow):
3206 * bridge/mac/FrameMac.h:
3207 * bridge/mac/FrameMac.mm:
3208 (WebCore::FrameMac::submitForm):
3209 (WebCore::FrameMac::openURLRequest):
3210 (WebCore::FrameMac::urlSelected):
3211 * bridge/win/BrowserExtensionWin.h:
3213 (WebCore::Frame::changeLocation):
3214 (WebCore::Frame::urlSelected):
3215 (WebCore::Frame::requestFrame):
3216 (WebCore::Frame::submitForm):
3218 * page/FrameLoadRequest.h: Added.
3219 (WebCore::FrameLoadRequest::FrameLoadRequest):
3220 (WebCore::FrameLoadRequest::lockHistory):
3221 (WebCore::FrameLoadRequest::setLockHistory):
3222 * page/ResourceRequest.h:
3223 (WebCore::ResourceRequest::ResourceRequest):
3225 2006-10-13 John Sullivan <sullivan@apple.com>
3229 * loader/mac/WebFrameLoader.mm:
3230 (-[WebFrameLoader loadDocumentLoader:]):
3231 Replace ASSERT(!policyDocumentLoader) with code that handles this case. This can
3232 happen when loading a page during a decidePolicyForNavigationAction callback.
3234 2006-10-13 Dave Hyatt <hyatt@apple.com>
3236 Transparency layer work.
3240 * platform/GraphicsContext.h:
3241 * platform/cg/GraphicsContextCG.cpp:
3242 (WebCore::GraphicsContext::beginTransparencyLayer):
3243 (WebCore::GraphicsContext::endTransparencyLayer):
3244 * platform/cg/GraphicsContextPlatformPrivate.h:
3245 (WebCore::GraphicsContextPlatformPrivate::beginTransparencyLayer):
3246 (WebCore::GraphicsContextPlatformPrivate::endTransparencyLayer):
3248 2006-10-13 Rob Buis <buis@kde.org>
3252 http://bugs.webkit.org/show_bug.cgi?id=11217
3253 Cleanup svg coding style
3255 Cleanup coding style in svg paint server classes.
3257 * ksvg2/svg/SVGGradientElement.cpp:
3258 (WebCore::SVGGradientElement::SVGGradientElement):
3259 (WebCore::SVGGradientElement::parseMappedAttribute):
3260 (WebCore::SVGGradientElement::notifyAttributeChange):
3261 (WebCore::SVGGradientElement::canvasResource):
3262 (WebCore::SVGGradientElement::rebuildStops):
3263 * ksvg2/svg/SVGGradientElement.h:
3264 * ksvg2/svg/SVGLinearGradientElement.cpp:
3265 (WebCore::SVGLinearGradientElement::SVGLinearGradientElement):
3266 (WebCore::SVGLinearGradientElement::parseMappedAttribute):
3267 (WebCore::SVGLinearGradientElement::buildGradient):
3268 * ksvg2/svg/SVGLinearGradientElement.h:
3269 * ksvg2/svg/SVGPatternElement.cpp:
3270 (WebCore::SVGPatternElement::SVGPatternElement):
3271 (WebCore::SVGPatternElement::parseMappedAttribute):
3272 (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
3273 (WebCore::SVGPatternElement::drawPatternContentIntoTile):
3274 (WebCore::SVGPatternElement::notifyClientsToRepaint):
3275 (WebCore::SVGPatternElement::notifyAttributeChange):
3276 (WebCore::SVGPatternElement::canvasResource):
3277 (WebCore::SVGPatternElement::getCTM):
3278 * ksvg2/svg/SVGPatternElement.h:
3279 (WebCore::SVGPatternElement::rendererIsNeeded):
3280 * ksvg2/svg/SVGRadialGradientElement.cpp:
3281 (WebCore::SVGRadialGradientElement::SVGRadialGradientElement):
3282 (WebCore::SVGRadialGradientElement::parseMappedAttribute):
3283 (WebCore::SVGRadialGradientElement::buildGradient):
3284 * ksvg2/svg/SVGRadialGradientElement.h:
3285 * ksvg2/svg/SVGStopElement.cpp:
3286 (WebCore::SVGStopElement::SVGStopElement):
3287 (WebCore::SVGStopElement::parseMappedAttribute):
3288 * ksvg2/svg/SVGStopElement.h:
3290 2006-10-13 Geoffrey Garen <ggaren@apple.com>
3292 Reviewed by Darin, John.
3294 - Merged more frame and iframe code
3295 - Fixed a bug where iframes returned incorrect values for renderer-dependent
3296 properties during javascript: loads because they didn't have renderers at
3299 PLT insists this is a small performance win. Don't believe its lies.
3301 * bindings/js/kjs_html.cpp:
3302 (KJS::JSHTMLElement::frameGetter): Renamed frameWidth and frameHeight to
3303 width and height, for consistency with the rest of the DOM.
3304 * dom/ContainerNode.cpp:
3305 (WebCore::ContainerNode::queuePostAttachCallback): Added a post-attach callback
3306 queue that gets drained after the render tree is fully constructed. Currently,
3307 this is only used for frame loading.
3308 (WebCore::ContainerNode::attach):
3309 * dom/ContainerNode.h:
3310 * html/HTMLFrameElement.cpp:
3311 (WebCore::HTMLFrameElement::insertedIntoDocument): Removed frame loading from
3312 attach() because loading iframes during attach() causes a crash.
3313 Moved frame loading logic into insertedIntoDocument(). That's a more
3314 logical place for it because document insertion is what
3315 triggers frame loading. Made frame loading a post-attach callback, instead
3316 of an immediate action, to fix the incorrect values bug.
3317 (WebCore::HTMLFrameElement::attach): Added setWidget call that used to be
3318 in HTMLIFrameElement::attach. IFRAME requires this call. FRAME will soon
3319 require this call, once I remove the call from WebKit.
3320 (WebCore::HTMLFrameElement::setLocation):
3321 (WebCore::HTMLFrameElement::width):
3322 (WebCore::HTMLFrameElement::height):
3323 * html/HTMLFrameElement.h: Made openURL non-virtual to avoid the unnecessary
3325 * html/HTMLIFrameElement.cpp: Merged code into HTMLFrameElement
3326 (WebCore::HTMLIFrameElement::rendererIsNeeded):
3327 (WebCore::HTMLIFrameElement::createRenderer):
3328 (WebCore::HTMLIFrameElement::insertedIntoDocument):
3329 (WebCore::HTMLIFrameElement::removedFromDocument):
3330 (WebCore::HTMLIFrameElement::attach):
3331 * page/FrameView.h: Removed unused method.
3333 2006-10-13 David Harrison <harrison@apple.com>
3337 <rdar://problem/4746860> Mail crash in WebCore::CSSMutableStyleDeclaration::merge(WebCore::CSSMutableStyleDeclaration*, bool)
3339 Tests added or changed:
3340 * editing/style/style-boundary-005.html: Added. Matches steps from bug.
3341 * editing/execCommand/hilitecolor-expected.txt: Updated (no empty Apple style spans).
3342 * editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Updated (no empty Apple style spans).
3343 * editing/style/remove-underline-in-bold-expected.txt: Updated (no empty Apple style spans).
3344 * editing/style/typing-style-003-expected.txt: Updated (no empty Apple style spans).
3347 (WebCore::Text::splitText):
3350 * editing/ApplyStyleCommand.cpp:
3351 (WebCore::isUnstyledStyleSpan):
3352 Renamed from isEmptyStyleSpan.
3354 (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
3355 Rename emptySpans local to unstyledSpans.
3357 (WebCore::dummySpanAncestorForNode):
3358 New. To locate Apple style span created when splitting a text node.
3360 (WebCore::ApplyStyleCommand::cleanupUnstyledAppleStyleSpans):
3361 Renamed from cleanUpEmptyStyleSpans. Algorithm changed to scan children
3362 of dummy span's parents, rather than traversing up from start and
3363 end locations. Old algorithm would miss empty spans in the bug case.
3365 (WebCore::ApplyStyleCommand::applyInlineStyle):
3366 Use dummySpanAncestorForNode() and cleanupUnstyledAppleStyleSpans().
3368 (WebCore::ApplyStyleCommand::removeCSSStyle):
3369 Renamed isEmptyStyleSpan() to isUnstyledStyleSpan().
3371 (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
3374 * editing/ApplyStyleCommand.h:
3375 Renamed cleanUpEmptyStyleSpans() to cleanupUnstyledAppleStyleSpans().
3377 * editing/ReplaceSelectionCommand.cpp:
3378 (WebCore::ReplaceSelectionCommand::removeRedundantStyles):
3379 Allow for Apple style span to be unstyled, because old email may have this in the DOM.
3380 Use !node->hasChildNodes() instead of !node->firstChild().
3382 * editing/SplitTextNodeCommand.cpp:
3383 (WebCore::SplitTextNodeCommand::doApply):
3386 * rendering/RenderTreeAsText.cpp:
3387 (WebCore::isEmptyOrUnstyledAppleStyleSpan):
3388 (WebCore::operator<<):
3389 Flag empty or unstyled AppleStyleSpa nbecause we never want to leave them in the DOM
3391 2006-10-13 Nikolas Zimmermann <zimmermann@kde.org>
3395 Fix Qt/Linux build after Adele's popup menu changes.
3398 * platform/qt/FileChooserQt.cpp:
3399 (WebCore::FileChooser::disconnectUploadControl):
3400 * platform/qt/PopupMenuQt.cpp: Added.
3401 (WebCore::PopupMenu::PopupMenu):
3402 (WebCore::PopupMenu::~PopupMenu):
3403 (WebCore::PopupMenu::clear):
3404 (WebCore::PopupMenu::populate):
3405 (WebCore::PopupMenu::show):
3406 (WebCore::PopupMenu::hide):
3407 (WebCore::PopupMenu::addSeparator):
3408 (WebCore::PopupMenu::addGroupLabel):
3409 (WebCore::PopupMenu::addOption):
3410 * platform/qt/RenderPopupMenuQt.cpp: Removed.
3411 * platform/qt/RenderPopupMenuQt.h: Removed.
3412 * platform/qt/RenderThemeQt.cpp:
3414 2006-10-13 Kevin McCullough <KMcCullough@apple.com>
3420 * WebCore.xcodeproj/project.pbxproj:
3421 * loader/mac/WebFrameLoader.mm:
3423 2006-10-13 Darin Adler <darin@apple.com>
3427 - converted WebFormState from Objective-C to C++
3429 * WebCore.exp: Added a new symbol, changed one symbol from C to C++.
3431 * WebCore.xcodeproj/project.pbxproj: Made lots of headers "private" instead of "project".
3432 Added UChar.h and FrameLoaderTypes.h.
3434 * loader/FrameLoaderTypes.h: Added. Has enums from WebFrameLoader.h.
3436 * loader/mac/WebFormState.h: Converted class to C++.
3437 * loader/mac/WebFormState.mm: Ditto.
3439 * loader/mac/WebFrameLoader.h:
3440 * loader/mac/WebFrameLoader.mm:
3441 (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
3442 (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]):
3443 (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
3444 (-[WebFrameLoader invalidatePendingPolicyDecisionCallingDefaultAction:]):
3445 (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]):
3446 (-[WebFrameLoader continueAfterNewWindowPolicy:]):
3447 (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]):
3448 (-[WebFrameLoader continueAfterNavigationPolicy:]):
3449 (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
3450 (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
3451 (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
3452 (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
3453 Changed Objective-C WebFormState uses to C++ WebCore::FormState.
3455 2006-10-13 Adele Peterson <adele@apple.com>
3459 - Fix for <rdar://problem/4768591> REGRESSION: List box selection color should just be a darker version of regular selection color
3461 * rendering/RenderListBox.cpp:
3462 (WebCore::RenderListBox::paintItemForeground):
3463 * rendering/RenderTheme.cpp:
3464 (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
3465 (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
3466 (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
3467 (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
3468 * rendering/RenderThemeMac.h:
3469 * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::activeListBoxSelectionBackgroundColor):
3471 2006-10-13 Rob Buis <buis@kde.org>
3475 http://bugs.webkit.org/show_bug.cgi?id=11217
3476 Cleanup svg coding style
3478 Cleanup coding style in svg structure classes.
3480 * ksvg2/svg/SVGDefsElement.cpp:
3481 (WebCore::SVGDefsElement::SVGDefsElement):
3482 * ksvg2/svg/SVGDefsElement.h:
3483 * ksvg2/svg/SVGDescElement.cpp:
3484 (WebCore::SVGDescElement::SVGDescElement):
3485 * ksvg2/svg/SVGDescElement.h:
3486 * ksvg2/svg/SVGDocument.cpp:
3487 * ksvg2/svg/SVGDocument.h:
3488 * ksvg2/svg/SVGElementInstance.cpp:
3489 (WebCore::SVGElementInstance::SVGElementInstance):
3490 (WebCore::SVGElementInstance::correspondingElement):
3491 (WebCore::SVGElementInstance::correspondingUseElement):
3492 (WebCore::SVGElementInstance::parentNode):
3493 (WebCore::SVGElementInstance::childNodes):
3494 (WebCore::SVGElementInstance::previousSibling):
3495 (WebCore::SVGElementInstance::nextSibling):
3496 (WebCore::SVGElementInstance::firstChild):
3497 (WebCore::SVGElementInstance::lastChild):
3498 * ksvg2/svg/SVGElementInstance.h:
3499 * ksvg2/svg/SVGElementInstanceList.cpp:
3500 * ksvg2/svg/SVGElementInstanceList.h:
3501 * ksvg2/svg/SVGGElement.cpp:
3502 (WebCore::SVGGElement::SVGGElement):
3503 (WebCore::SVGGElement::parseMappedAttribute):
3504 (WebCore::SVGDummyElement::SVGDummyElement):
3505 * ksvg2/svg/SVGGElement.h:
3506 (WebCore::SVGGElement::rendererIsNeeded):
3507 * ksvg2/svg/SVGImageElement.cpp:
3508 (WebCore::SVGImageElement::createRenderer):
3509 * ksvg2/svg/SVGImageElement.h:
3510 * ksvg2/svg/SVGSVGElement.cpp:
3511 (WebCore::SVGSVGElement::SVGSVGElement):
3512 (WebCore::SVGSVGElement::pixelUnitToMillimeterX):
3513 (WebCore::SVGSVGElement::pixelUnitToMillimeterY):
3514 (WebCore::SVGSVGElement::currentScale):
3515 (WebCore::SVGSVGElement::setCurrentScale):
3516 (WebCore::SVGSVGElement::currentTranslate):
3517 (WebCore::SVGSVGElement::parseMappedAttribute):
3518 (WebCore::SVGSVGElement::suspendRedraw):
3519 (WebCore::SVGSVGElement::unsuspendRedraw):
3520 (WebCore::SVGSVGElement::unsuspendRedrawAll):
3521 (WebCore::SVGSVGElement::forceRedraw):
3522 (WebCore::SVGSVGElement::getIntersectionList):
3523 (WebCore::SVGSVGElement::getEnclosureList):
3524 (WebCore::SVGSVGElement::checkIntersection):
3525 (WebCore::SVGSVGElement::checkEnclosure):
3526 (WebCore::SVGSVGElement::deselectAll):
3527 (WebCore::SVGSVGElement::createSVGLength):
3528 (WebCore::SVGSVGElement::createSVGAngle):
3529 (WebCore::SVGSVGElement::createSVGMatrix):
3530 (WebCore::SVGSVGElement::createSVGTransform):
3531 (WebCore::SVGSVGElement::createSVGTransformFromMatrix):
3532 (WebCore::SVGSVGElement::getCTM):
3533 (WebCore::SVGSVGElement::getScreenCTM):
3534 (WebCore::SVGSVGElement::setCurrentTime):
3535 * ksvg2/svg/SVGSVGElement.h:
3536 (WebCore::SVGSVGElement::rendererIsNeeded):
3537 * ksvg2/svg/SVGSwitchElement.cpp:
3538 (WebCore::SVGSwitchElement::SVGSwitchElement):
3539 (WebCore::SVGSwitchElement::childShouldCreateRenderer):
3540 * ksvg2/svg/SVGSwitchElement.h:
3541 (WebCore::SVGSwitchElement::rendererIsNeeded):
3542 * ksvg2/svg/SVGSymbolElement.cpp:
3543 (WebCore::SVGSymbolElement::SVGSymbolElement):
3544 (WebCore::SVGSymbolElement::parseMappedAttribute):
3545 * ksvg2/svg/SVGSymbolElement.h:
3546 (WebCore::SVGSymbolElement::shouldAttachChild):
3547 * ksvg2/svg/SVGTitleElement.cpp:
3548 (WebCore::SVGTitleElement::SVGTitleElement):
3549 * ksvg2/svg/SVGTitleElement.h:
3550 * ksvg2/svg/SVGUseElement.cpp:
3551 (WebCore::SVGUseElement::parseMappedAttribute):
3552 (WebCore::SVGUseElement::closeRenderer):
3553 * ksvg2/svg/SVGUseElement.h:
3554 (WebCore::SVGUseElement::rendererIsNeeded):
3556 2006-10-12 Adele Peterson <adele@apple.com>
3560 - Fix for http://bugs.webkit.org/show_bug.cgi?id=11172
3561 REGRESSION (NativeListBox): OPTION text paints over the edge of the select element at http://jobs.apple.com/
3563 Test: fast/forms/listbox-width-change.html
3565 * rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement):
3566 When the options change, call setNeedsLayoutAndMinMaxRecalc.