WebCore/ChangeLog

   1 2006-10-01  Alexey Proskuryakov  <ap@nypop.com>
   2
   3         Reviewed by Maciej and Darin.
   4
   5         http://bugzilla.opendarwin.org/show_bug.cgi?id=4372
   6         JavaScript document.write page form does not submit in Safari
   7
   8         Test: fast/forms/document-write.html
   9
  10         * page/Frame.cpp:
  11         (WebCore::Frame::submitForm): Don't check for parsing().
  12
  13 2006-10-01  Alexey Proskuryakov  <ap@nypop.com>
  14
  15         Build fix.
  16
  17         * bridge/mac/FrameViewMac.mm: Add missing #imports.
  18
  19 2006-10-01  Dave Hyatt  <hyatt@apple.com>
  20
  21         Refactor the code that passes mouse presses to the Mac scrollbar and make it cross-platform.
  22
  23         Reviewed by mitz
  24
  25         * bridge/mac/FrameMac.mm:
  26         (WebCore::FrameMac::passWidgetMouseDownEventToWidget):
  27         * bridge/mac/FrameViewMac.mm:
  28         (WebCore::FrameView::passMousePressEventToScrollbar):
  29         * page/FrameView.cpp:
  30         (WebCore::FrameView::handleMousePressEvent):
  31         (WebCore::FrameView::setMousePressed):
  32         * page/FrameView.h:
  33         * platform/win/TemporaryLinkStubs.cpp:
  34         (FrameView::passMousePressEventToScrollbar):
  35
  36 2006-09-30  Sam Weinig  <sam.weinig@gmail.com>
  37
  38         Reviewed by Darin.
  39
  40         Patch for http://bugs.webkit.org/show_bug.cgi?id=11102
  41         Add more SVG Objective-C DOM bindings
  42
  43         - Auto-generate Objective-C DOM bindings for DOMSVGAElement,
  44           DOMSVGAnimateColorElement, DOMSVGAnimateElement, DOMSVGAnimateTransformElement,
  45           DOMSVGAnimatedPathData, DOMSVGAnimatedPoints, DOMSVGAnimatedPreserveAspectRatio,
  46           DOMSVGAnimationElement, DOMSVGCircleElement, DOMSVGClipPathElement, DOMSVGColor,
  47           DOMSVGCursorElement, DOMSVGDefsElement, DOMSVGDescElement, DOMSVGDocument,
  48           DOMSVGEllipseElement, DOMSVGPreserveAspectRatio, and DOMSVGURIReference.
  49
  50         * DerivedSources.make:
  51         * WebCore.xcodeproj/project.pbxproj:
  52         * bindings/objc/DOMInternal.h:
  53         * bindings/objc/DOMSVG.h:
  54         * bindings/scripts/CodeGeneratorObjC.pm:
  55         * ksvg2/svg/SVGAElement.idl:
  56         * ksvg2/svg/SVGAnimateColorElement.idl:
  57         * ksvg2/svg/SVGAnimateElement.idl:
  58         * ksvg2/svg/SVGAnimateTransformElement.idl:
  59         * ksvg2/svg/SVGAnimatedPathData.idl:
  60         * ksvg2/svg/SVGAnimatedPoints.idl:
  61         * ksvg2/svg/SVGAnimatedPreserveAspectRatio.idl:
  62         * ksvg2/svg/SVGAnimationElement.idl:
  63         * ksvg2/svg/SVGCircleElement.idl:
  64         * ksvg2/svg/SVGClipPathElement.idl:
  65         * ksvg2/svg/SVGColor.idl:
  66         * ksvg2/svg/SVGCursorElement.idl:
  67         * ksvg2/svg/SVGDefsElement.idl:
  68         * ksvg2/svg/SVGDescElement.idl:
  69         * ksvg2/svg/SVGDocument.idl:
  70         * ksvg2/svg/SVGEllipseElement.idl:
  71         * ksvg2/svg/SVGPointList.idl:
  72         * ksvg2/svg/SVGPreserveAspectRatio.idl:
  73         * ksvg2/svg/SVGRect.idl:
  74         * ksvg2/svg/SVGSVGElement.idl:
  75
  76 2006-09-30  Maciej Stachowiak  <mjs@apple.com>
  77
  78         Reviewed by Adele.
  79
  80         - fix build
  81
  82         * platform/FloatRect.h:
  83         (WebCore::FloatRect::contains): Added; not exactly the same semantic as IntRect containment
  84         but more appropriate for path-type stuff.
  85         * platform/cg/PathCG.cpp:
  86         (WebCore::Path::contains): Don't use enclosingIntRect, just use FloatRect::contains.
  87
  88 2006-09-30  Alexey Proskuryakov  <ap@nypop.com>
  89
  90         Reviewed by Darin.
  91
  92         http://bugs.webkit.org/show_bug.cgi?id=11011
  93         External CSS is parsed as iso-8859-1 even though the main document is utf-8
  94
  95         Test: fast/encoding/css-charset-default.xhtml
  96
  97         * loader/CachedResourceClient.h:
  98         (WebCore::CachedResourceClient::setCSSStyleSheet):
  99         (WebCore::CachedResourceClient::setXSLStyleSheet):
 100         Divided setStyleSheet into setCSSStyleSheet and setXSLStyleSheet. The former
 101         takes an additional charset parameter, to be passed to CSSStyleSheet constructor.
 102
 103         * css/CSSImportRule.cpp:
 104         (WebCore::CSSImportRule::setCSSStyleSheet):
 105         (WebCore::CSSImportRule::insertedIntoParent): Default to parent stylesheet's charset.
 106         * css/CSSImportRule.h:
 107
 108         * css/CSSStyleSheet.cpp:
 109         (WebCore::CSSStyleSheet::CSSStyleSheet):
 110         * css/CSSStyleSheet.h:
 111         Added an m_charset member to be used when loading child stylesheets. Removed an unused m_implicit
 112         member. Changed some String parameters to const String&.
 113
 114         * css/StyleSheet.cpp:
 115         (WebCore::StyleSheet::StyleSheet):
 116         * css/StyleSheet.h:
 117         Changed some String parameters to const String&. Removed an unused (even unimplemented) constructor.
 118
 119         * css/StyleSheetList.cpp:
 120         (WebCore::StyleSheetList::length):
 121         (WebCore::StyleSheetList::item):
 122         * css/StyleSheetList.h:
 123         Special-casing implicit stylesheets seemed to be dead code, removed.
 124
 125         * dom/Document.cpp:
 126         (WebCore::Document::setCSSStyleSheet):
 127         (WebCore::Document::recalcStyleSelector):
 128         * dom/Document.h:
 129         Renamed setStyleSheet() to setCSSStyleSheet().
 130
 131         * dom/ProcessingInstruction.cpp:
 132         (WebCore::ProcessingInstruction::checkStyleSheet): Pass a correct charset to requestCSSStyleSheet().
 133         (WebCore::ProcessingInstruction::setCSSStyleSheet):
 134         (WebCore::ProcessingInstruction::setXSLStyleSheet):
 135         (WebCore::ProcessingInstruction::parseStyleSheet):
 136         * dom/ProcessingInstruction.h:
 137
 138         * html/HTMLLinkElement.cpp:
 139         (WebCore::HTMLLinkElement::process): Default to document encoding if a charset attribute
 140         is not specified.
 141         (WebCore::HTMLLinkElement::setCSSStyleSheet):
 142         * html/HTMLLinkElement.h:
 143
 144         * html/HTMLStyleElement.cpp:
 145         (WebCore::HTMLStyleElement::childrenChanged):
 146         * ksvg2/svg/SVGStyleElement.cpp:
 147         (WebCore::SVGStyleElement::childrenChanged):
 148         Inherit URL and charset from the document.
 149
 150         * loader/Cache.cpp:
 151         (WebCore::Cache::requestCSSStyleSheet):
 152         * loader/Cache.h:
 153         Adjust for setStyleSheet() renaming.
 154
 155         * loader/CachedCSSStyleSheet.h: Removed an unused constructor.
 156         * loader/CachedCSSStyleSheet.cpp:
 157         (WebCore::CachedCSSStyleSheet::ref):
 158         (WebCore::CachedCSSStyleSheet::deref):
 159         (WebCore::CachedCSSStyleSheet::checkNotify):
 160         Pass the encoding to setCSSStyleSheet().
 161
 162         * loader/CachedXSLStyleSheet.cpp:
 163         (WebCore::CachedXSLStyleSheet::ref):
 164         (WebCore::CachedXSLStyleSheet::checkNotify):
 165         * loader/DocLoader.cpp:
 166         (WebCore::DocLoader::requestCSSStyleSheet):
 167         * loader/DocLoader.h:
 168         * page/Frame.cpp:
 169         (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
 170         (WebCore::UserStyleSheetLoader::setCSSStyleSheet):
 171         * xml/XSLImportRule.cpp:
 172         (WebCore::XSLImportRule::setXSLStyleSheet):
 173         (WebCore::XSLImportRule::loadSheet):
 174         * xml/XSLImportRule.h:
 175         Adjust for setStyleSheet() renaming.
 176
 177 2006-09-30  Rob Buis  <buis@kde.org>
 178
 179         Reviewed by eseidel.
 180
 181         http://bugs.webkit.org/show_bug.cgi?id=11096
 182         Hit testing for polylines fails
 183
 184         Fix Path::contains so it handles filled, non-closed paths too.
 185
 186         * platform/cg/PathCG.cpp:
 187         (WebCore::Path::contains):
 188
 189 2006-09-30  Dave Hyatt  <hyatt@apple.com>
 190
 191         Refactor subframe event handling to hide more of the Mac-specific logic from the cross-platform code.
 192         Stub out a capturing API that mimics the way Web browsers capture events and route them to specific
 193         subframes while the mouse is down.
 194
 195         Reviewed by mitzpettel
 196
 197         * bridge/mac/FrameMac.h:
 198         * bridge/mac/FrameMac.mm:
 199         (WebCore::FrameMac::passWidgetMouseDownEventToWidget):
 200         (WebCore::FrameMac::passWheelEventToWidget):
 201         * bridge/mac/FrameViewMac.mm:
 202         (WebCore::FrameView::passMousePressEventToSubframe):
 203         (WebCore::FrameView::passMouseMoveEventToSubframe):
 204         (WebCore::FrameView::passMouseReleaseEventToSubframe):
 205         (WebCore::FrameView::passWheelEventToSubframe):
 206         * page/Frame.cpp:
 207         * page/Frame.h:
 208         * page/FrameView.cpp:
 209         (WebCore::subframeForTargetNode):
 210         (WebCore::FrameView::handleMousePressEvent):
 211         (WebCore::FrameView::handleMouseDoubleClickEvent):
 212         (WebCore::FrameView::handleMouseMoveEvent):
 213         (WebCore::FrameView::handleMouseReleaseEvent):
 214         (WebCore::FrameView::handleWheelEvent):
 215         * page/FrameView.h:
 216         * platform/ScrollBar.h:
 217         (WebCore::ScrollBar::handleMouseMoveEvent):
 218         (WebCore::ScrollBar::handleMouseOutEvent):
 219         * platform/Widget.h:
 220         (WebCore::Widget::handleMouseMoveEvent):
 221         (WebCore::Widget::handleMouseReleaseEvent):
 222         * platform/win/TemporaryLinkStubs.cpp:
 223         (FrameView::passMousePressEventToSubframe):
 224         (FrameView::passMouseMoveEventToSubframe):
 225         (FrameView::passMouseReleaseEventToSubframe):
 226         (FrameView::passWheelEventToSubframe):
 227         (Widget::capturingMouse):
 228         (Widget::setCapturingMouse):
 229         (Widget::capturingTarget):
 230         (Widget::capturingChild):
 231         (Widget::setCapturingChild):
 232         * rendering/RenderView.cpp:
 233         (WebCore::RenderView::paintBoxDecorations):
 234
 235 2006-09-29  MorganL  <morganl.webkit@yahoo.com>
 236
 237         Reviewed by Adele.
 238
 239         Fixes windows bustage:
 240         http://bugs.webkit.org/show_bug.cgi?id=11093
 241
 242         * platform/win/PlatformScrollBar.h:
 243         * platform/win/TemporaryLinkStubs.cpp:
 244         (PlatformScrollBar::PlatformScrollBar):
 245         (ScrollBar::ScrollBar):
 246
 247 2006-09-29  David Hyatt  <hyatt@apple.com>
 248
 249         Eliminate RenderLayer::gScrollBar in favor of caching the scrollbar hit
 250         in RenderObject::NodeInfo (and then propagating that Widget to
 251         MouseEventWithHitTestResults).
 252
 253         This allows RenderListBox and RenderBlock to do the same thing when the
 254         mouse is over the scrollbar.
 255
 256         Also land fix to support font-size: 0.
 257
 258         Reviewed by mjs (scrollbar), eric (font-size)
 259
 260         * dom/Document.cpp:
 261         (WebCore::Document::prepareMouseEvent):
 262         * page/Frame.cpp:
 263         (WebCore::Frame::passWidgetMouseDownEventToWidget):
 264         * page/FrameView.cpp:
 265         (WebCore::selectCursor):
 266         (WebCore::FrameView::handleMouseMoveEvent):
 267         (WebCore::FrameView::dispatchMouseEvent):
 268         * page/MouseEventWithHitTestResults.cpp:
 269         (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
 270         * page/MouseEventWithHitTestResults.h:
 271         (WebCore::MouseEventWithHitTestResults::scrollbar):
 272         * rendering/RenderBlock.cpp:
 273         (WebCore::RenderBlock::isPointInScrollbar):
 274         (WebCore::RenderBlock::nodeAtPoint):
 275         * rendering/RenderBlock.h:
 276         * rendering/RenderLayer.cpp:
 277         (WebCore::RenderLayer::hitTest):
 278         * rendering/RenderLayer.h:
 279         (WebCore::RenderLayer::getHiddenBehavior):
 280         * rendering/RenderListBox.cpp:
 281         (WebCore::RenderListBox::RenderListBox):
 282         (WebCore::RenderListBox::~RenderListBox):
 283         (WebCore::RenderListBox::isPointInScrollbar):
 284         * rendering/RenderListBox.h:
 285         * rendering/RenderObject.h:
 286         (WebCore::RenderObject::NodeInfo::NodeInfo):
 287         (WebCore::RenderObject::NodeInfo::scrollbar):
 288         (WebCore::RenderObject::NodeInfo::setScrollbar):
 289
 290 2006-09-29  MorganL  <morganl.webkit@yahoo.com>
 291
 292         Reviewed by Adele.
 293
 294         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11092
 295
 296         * platform/win/ScrollViewWin.cpp:
 297         (WebCore::ScrollView::convertToContainingWindow):
 298         (WebCore::ScrollView::convertFromContainingWindow):
 299         * platform/win/WidgetWin.cpp:
 300         (WebCore::Widget::convertToContainingWindow):
 301         (WebCore::Widget::convertFromContainingWindow):
 302
 303 2006-09-29  Adele Peterson  <adele@apple.com>
 304
 305         Updated with new argument for PlatformScrollBar.
 306
 307         * platform/win/TemporaryLinkStubs.cpp:
 308         (PlatformScrollBar::PlatformScrollBar):
 309
 310 2006-09-29  Adele Peterson  <adele@apple.com>
 311
 312         Reviewed by Hyatt.
 313
 314         Fixing build bustage with cast to int.
 315
 316         * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::lastSelectedListIndex):
 317
 318 2006-09-29  Adele Peterson  <adele@apple.com>
 319
 320         Fixing accidental include.
 321
 322         * rendering/RenderListBox.cpp:
 323
 324 2006-09-29  Adele Peterson  <adele@apple.com>
 325
 326         Adding RenderListBox files.
 327
 328         * WebCore.vcproj/WebCore/WebCore.vcproj:
 329
 330 2006-09-29  Adele Peterson  <adele@apple.com>
 331
 332         Reviewed by Adam.
 333
 334         Initial implementation of engine-based list box control.
 335
 336         * WebCore.xcodeproj/project.pbxproj: Added RenderListBox.h and RenderListBox.cpp
 337
 338         * bridge/mac/FrameMac.h: Added _mouseDownMayStartAutoscroll.
 339         * bridge/mac/FrameMac.mm: Updated autoscroll code to use renderers instead of layers, so any renderer that implements autoscroll will work.
 340         (WebCore::FrameMac::FrameMac):
 341         (WebCore::FrameMac::handleMousePressEvent):
 342         (WebCore::FrameMac::handleMouseMoveEvent):
 343         (WebCore::FrameMac::mouseDown):
 344
 345         * page/Frame.cpp:
 346         (WebCore::Frame::handleMouseMoveEvent):
 347         (WebCore::Frame::scrollOverflow): Don't scroll list box here- this would cause arrow keys to scroll instead of select.
 348         (WebCore::Frame::handleAutoscroll): Updated to use a renderer instead of a layer when setting up autoscroll.
 349         (WebCore::Frame::autoscrollTimerFired): ditto.
 350         (WebCore::Frame::stopAutoscrollTimer): ditto.
 351         (WebCore::Frame::passWidgetMouseDownEventToWidget): Updated to check for list box's scroll bar.
 352         * page/Frame.h:
 353         * page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Updated to use renderer unstead of layer for autoscroll.
 354
 355         * page/FrameView.cpp: Keep track of current mouse position so this can be used for list box autoscroll.
 356         (WebCore::FrameViewPrivate::reset):
 357         (WebCore::FrameView::currentMousePosition):
 358         (WebCore::FrameView::handleMousePressEvent):
 359         (WebCore::FrameView::handleMouseDoubleClickEvent):
 360         (WebCore::selectCursor):
 361         (WebCore::FrameView::handleMouseMoveEvent):
 362         (WebCore::FrameView::handleMouseReleaseEvent):
 363         * page/FrameView.h:
 364
 365         * platform/ScrollBar.cpp: (WebCore::ScrollBar::ScrollBar): Added controlSize argument.  The list box will use a smaller scroll bar size.
 366         * platform/ScrollBar.h:
 367         (WebCore::):
 368         (WebCore::ScrollBar::controlSize):
 369         * platform/mac/PlatformScrollBar.h:
 370         * platform/mac/PlatformScrollBarMac.mm:
 371         (NSControlSizeForScrollBarControlSize):
 372         (-[WebCoreScrollBar initWithPlatformScrollBar:]):
 373         (WebCore::PlatformScrollBar::PlatformScrollBar):
 374
 375         * rendering/RenderBlock.h:
 376         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): Updated to pass regular control size to scrollbar constructor.
 377         * rendering/RenderLayer.h:
 378         * rendering/RenderObject.cpp:
 379         (WebCore::RenderObject::shouldAutoscroll):
 380         (WebCore::RenderObject::autoscroll):
 381         * rendering/RenderObject.h: (WebCore::RenderObject::isListBox):
 382
 383         * css/html4.css: Added properties for new list boxes.
 384
 385         * html/HTMLOptionElement.cpp:
 386         (WebCore::HTMLOptionElement::setSelected): Doesn't allow selection to be changed here if the option is disabled.
 387         (WebCore::HTMLOptionElement::disabled): Added. Checks the parent's disabled status.
 388         * html/HTMLOptionElement.h: Added disabled method.
 389
 390         * html/HTMLSelectElement.cpp: Added appearance switch for new list box implementation.
 391         (WebCore::HTMLSelectElement::recalcStyle):
 392         (WebCore::HTMLSelectElement::lastSelectedListIndex):
 393         (WebCore::HTMLSelectElement::deselectItems):
 394         (WebCore::HTMLSelectElement::setSelectedIndex):
 395         (WebCore::HTMLSelectElement::isKeyboardFocusable):
 396         (WebCore::HTMLSelectElement::isMouseFocusable):
 397         (WebCore::HTMLSelectElement::createRenderer):
 398         (WebCore::HTMLSelectElement::recalcListItems):
 399         (WebCore::HTMLSelectElement::setRecalcListItems):
 400         (WebCore::HTMLSelectElement::reset):
 401         (WebCore::HTMLSelectElement::notifyOptionSelected):
 402         (WebCore::HTMLSelectElement::defaultEventHandler): Added code to select options for list box when clicking and using arrow keys.
 403         (WebCore::HTMLSelectElement::nextSelectableListIndex):
 404         (WebCore::HTMLSelectElement::previousSelectableListIndex):
 405         * html/HTMLSelectElement.h:
 406
 407         * rendering/RenderTheme.cpp: Added support for ListBoxAppearance
 408         (WebCore::RenderTheme::paint):
 409         (WebCore::RenderTheme::paintBorderOnly):
 410         (WebCore::RenderTheme::paintDecorations):
 411         (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
 412         (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
 413         (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
 414         (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
 415         (WebCore::RenderTheme::isControlStyled):
 416         (WebCore::RenderTheme::supportsFocusRing):
 417         * rendering/RenderTheme.h:
 418         * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled):
 419
 420         * rendering/RenderListBox.cpp: Added.
 421         (WebCore::RenderListBox::RenderListBox):
 422         (WebCore::RenderListBox::~RenderListBox):
 423         (WebCore::RenderListBox::setStyle):
 424         (WebCore::RenderListBox::updateFromElement):
 425         (WebCore::RenderListBox::calcMinMaxWidth):
 426         (WebCore::RenderListBox::size):
 427         (WebCore::RenderListBox::numItems):
 428         (WebCore::RenderListBox::calcHeight):
 429         (WebCore::RenderListBox::baselinePosition):
 430         (WebCore::RenderListBox::itemBoundingBoxRect):
 431         (WebCore::RenderListBox::paintObject):
 432         (WebCore::RenderListBox::paintScrollbar):
 433         (WebCore::RenderListBox::paintItemForeground):
 434         (WebCore::RenderListBox::paintItemBackground):
 435         (WebCore::RenderListBox::scrollBarTarget):
 436         (WebCore::RenderListBox::isPointInScrollbar):
 437         (WebCore::RenderListBox::optionAtPoint):
 438         (WebCore::RenderListBox::autoscroll):
 439         (WebCore::RenderListBox::scrollToRevealElementAtListIndex):
 440         (WebCore::RenderListBox::scroll):
 441         (WebCore::RenderListBox::valueChanged):
 442         * rendering/RenderListBox.h: Added.
 443         (WebCore::RenderListBox::isListBox):
 444         (WebCore::RenderListBox::selectionChanged):
 445         (WebCore::RenderListBox::setSelectionChanged):
 446         (WebCore::RenderListBox::canHaveChildren):
 447         (WebCore::RenderListBox::renderName):
 448         (WebCore::RenderListBox::setOptionsChanged):
 449         (WebCore::RenderListBox::shouldAutoscroll):
 450         (WebCore::RenderListBox::listIndexIsVisible):
 451
 452 2006-09-29  Beth Dakin  <bdakin@apple.com>
 453
 454         Reviewed by Darin.
 455
 456         We had a bug where html4.css was ignoring Media Queries. In the end
 457         the problem was that we were trying to send a char* to the
 458         MediaQueryEvaluator constructor that expects a String, but the
 459         char* got interpreted as a bool, the wrong constructor was called,
 460         and the media type was never set.
 461
 462         No test case possible since this only affects html4.css
 463
 464         * css/MediaQueryEvaluator.cpp: New constructor that expects takes a
 465         char*
 466         (WebCore::MediaQueryEvaluator):
 467         * css/MediaQueryEvaluator.h: Same.
 468
 469 2006-09-29  Geoffrey Garen  <ggaren@apple.com>
 470
 471         Reviewed by John, Maciej.
 472
 473         Integrated some frame and iframe code. I'm trying to fix up frame ownership
 474         and loading. Reducing the number of different code paths involved
 475         seemed like a good first step.
 476
 477         As a side effect, I fixed a bug where FRAME elements would report their
 478         src attributes as relative, rather than compelete, URLs. (IFRAME elements
 479         had the correct complete URL behavior.)
 480
 481         * html/HTMLFrameElement.cpp:
 482         (WebCore::HTMLFrameElement::isURLAllowed): Fixed comment typo
 483         (WebCore::HTMLFrameElement::openURL):
 484             (1) Removed checks that requestFrame does for us
 485             (2) Added isURLAllowed check, to have one clear bottleneck for it
 486             (3) Added viewsource check, to have one clear bottleneck for it
 487         (WebCore::HTMLFrameElement::close): Changed to use the common contentFrame()
 488         method, instead of finding our content frame in our own unique way.
 489         (WebCore::HTMLFrameElement::setLocation): Removed isURLAllowed check,
 490         since openURL does this for us now.
 491         (WebCore::HTMLFrameElement::src): Return complete URL instead of relative.
 492         This is what FF does, and it made no sense to have different behaviors
 493         for FRAME and IFRAME elements.
 494         * html/HTMLIFrameElement.cpp:
 495         (WebCore::HTMLIFrameElement::HTMLIFrameElement): Removed duplicate init
 496         code.
 497         * html/HTMLIFrameElement.h: Removed src() and openURL() methods, since
 498         HTMLFrameElement now does everything we need.
 499
 500 2006-09-30  Nikolas Zimmermann  <zimmermann@kde.org>
 501
 502         Reviewed by Hyatt.
 503
 504         Fix Qt/Linux build.
 505
 506         * CMakeLists.txt:
 507         * platform/qt/ScrollViewQt.cpp:
 508         (WebCore::ScrollView::convertToContainingWindow):
 509         (WebCore::ScrollView::convertFromContainingWindow):
 510         * platform/qt/TemporaryLinkStubs.cpp:
 511         (WebCore::signedPublicKeyAndChallengeString):
 512         * platform/qt/WidgetQt.cpp:
 513         (WebCore::Widget::convertToContainingWindow):
 514         (WebCore::Widget::convertFromContainingWindow):
 515
 516 2006-09-29  Sam Weinig  <sam.weinig@gmail.com>
 517
 518         Reviewed by Tim H.
 519
 520         Patch for http://bugs.webkit.org/show_bug.cgi?id=11082
 521         Simplify Internal methods for the auto-generated Objective-C DOM code
 522
 523         - Auto-generate the internal methods for more Objective-C classes.
 524
 525         * WebCore.xcodeproj/project.pbxproj:
 526         * bindings/objc/DOM.mm:
 527         * bindings/objc/DOMCSS.mm:
 528         (-[DOMStyleSheet WebCore::]):
 529         (+[DOMStyleSheet _styleSheetWith:WebCore::]):
 530         (-[DOMCSSRule WebCore::]):
 531         (-[DOMCSSRule _initWithCSSRule:WebCore::]):
 532         (+[DOMCSSRule _CSSRuleWith:WebCore::]):
 533         (-[DOMCSSValue WebCore::]):
 534         (-[DOMCSSValue _initWithCSSValue:WebCore::]):
 535         (+[DOMCSSValue _CSSValueWith:WebCore::]):
 536         * bindings/objc/DOMHTMLAppletElement.mm:
 537         (-[DOMHTMLAppletElement WebCore::]):
 538         (+[DOMHTMLAppletElement _HTMLOptionElementWith:WebCore::]):
 539         * bindings/objc/DOMHTMLEmbedElement.mm:
 540         (-[DOMHTMLEmbedElement WebCore::]):
 541         (+[DOMHTMLEmbedElement _HTMLEmbedElementWith:WebCore::]):
 542         * bindings/objc/DOMInternal.h:
 543         * bindings/objc/DOMInternal.mm:
 544         * bindings/scripts/CodeGeneratorObjC.pm:
 545         * css/CSSCharsetRule.idl:
 546         * css/CSSFontFaceRule.idl:
 547         * css/CSSImportRule.idl:
 548         * css/CSSMediaRule.idl:
 549         * css/CSSPageRule.idl:
 550         * css/CSSPrimitiveValue.idl:
 551         * css/CSSStyleRule.idl:
 552         * css/CSSStyleSheet.idl:
 553         * css/CSSUnknownRule.idl:
 554         * css/CSSValueList.idl:
 555         * dom/KeyboardEvent.idl:
 556         * dom/MouseEvent.idl:
 557         * dom/MutationEvent.idl:
 558         * dom/NodeIterator.idl:
 559         * dom/OverflowEvent.idl:
 560         * dom/UIEvent.idl:
 561         * dom/WheelEvent.idl:
 562
 563 2006-09-29  David Harrison  <harrison@apple.com>
 564
 565         Reviewed by John Sullivan.
 566
 567         <rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
 568         <rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot
 569
 570         Test added
 571         * fast/text/attributed-substring-from-range-001.html
 572
 573         * bridge/mac/FrameMac.mm:
 574         (WebCore::FrameMac::attributedString):
 575         Handle non-zero offsets when start and/or end node is a container. Offset used to be ignored in this case.
 576         Also, add validation of the range.
 577
 578 2006-09-29  Rob Buis  <buis@kde.org>
 579
 580         Reviewed by Maciej.
 581
 582         http://bugs.webkit.org/show_bug.cgi?id=10893
 583         InsertRule can not handle @import statements
 584
 585         Allow @import as part of a css rule.
 586
 587         * css/CSSGrammar.y:
 588
 589 2006-09-28  David Hyatt  <hyatt@apple.com>
 590
 591         Switch over the Mac-specific uses of viewportToContents/contentsToViewport.
 592
 593         * bridge/mac/FrameMac.mm:
 594         (WebCore::FrameMac::eventMayStartDrag):
 595         (WebCore::FrameMac::dragHysteresisExceeded):
 596         (WebCore::FrameMac::mouseDown):
 597         (WebCore::FrameMac::shouldDragAutoNode):
 598         (WebCore::FrameMac::sendContextMenuEvent):
 599         * bridge/mac/WebCoreFrameBridge.mm:
 600         (-[WebCoreFrameBridge _visiblePositionForPoint:]):
 601
 602 2006-09-28  Dave Hyatt  <hyatt@apple.com>
 603
 604         This patch eliminates viewportToContents/contentsToViewport in favor of convertTo/FromContainingWindow.
 605         ScrollView now subclasses these methods to factor in its scrollOffset and to deal with the document
 606         view.
 607
 608         Reviewed by mjs (the convertTo/From changes), (I added the elimination of viewportToContents to
 609         the patch after review, once I realized that these new functions essentially do the same thing.)
 610
 611         * dom/EventTargetNode.cpp:
 612         (WebCore::EventTargetNode::dispatchMouseEvent):
 613         (WebCore::EventTargetNode::dispatchWheelEvent):
 614         * page/Frame.cpp:
 615         (WebCore::Frame::selectClosestWordFromMouseEvent):
 616         (WebCore::Frame::handleMousePressEventTripleClick):
 617         (WebCore::Frame::handleMousePressEventSingleClick):
 618         (WebCore::Frame::handleMouseMoveEvent):
 619         (WebCore::Frame::handleMouseReleaseEvent):
 620         * page/FrameView.cpp:
 621         (WebCore::FrameView::handleMousePressEvent):
 622         (WebCore::selectCursor):
 623         (WebCore::FrameView::dispatchDragEvent):
 624         (WebCore::FrameView::prepareMouseEvent):
 625         (WebCore::FrameView::handleWheelEvent):
 626         * platform/ScrollView.h:
 627         * platform/Widget.cpp:
 628         (WebCore::Widget::convertToContainingWindow):
 629         * platform/Widget.h:
 630         * platform/mac/ScrollViewMac.mm:
 631         (WebCore::ScrollView::convertToContainingWindow):
 632         (WebCore::ScrollView::convertFromContainingWindow):
 633         * platform/mac/WidgetMac.mm:
 634         (WebCore::Widget::convertToContainingWindow):
 635         (WebCore::Widget::convertFromContainingWindow):
 636         * platform/win/ScrollViewWin.cpp:
 637         (WebCore::ScrollView::convertToContainingWindow):
 638         (WebCore::ScrollView::convertFromContainingWindow):
 639         * rendering/RenderLayer.cpp:
 640         (WebCore::RenderLayer::resize):
 641
 642 2006-09-28  Alice Liu  <alice.liu@apple.com>
 643
 644         Build fix by adding missing files for CommandByName
 645
 646         * WebCore.xcodeproj/project.pbxproj:
 647
 648 2006-09-28  Alice Liu  <alice.liu@apple.com>
 649
 650         Adding CommandByName files to the vcproj
 651
 652         * WebCore.vcproj/WebCore/WebCore.vcproj:
 653
 654 2006-09-28  Alice Liu  <alice.liu@apple.com>
 655
 656         Reviewed by Adam Roben.
 657
 658         This patch adds a command class that is attached to the frame so the frame can more easily execute commands such as copy, paste, select, etc.
 659         This patch also exposes some UBRK-related utilities so that they can be used elsewhere.
 660         This patch also changes windows PlatformMouseEvent so that we can detect multiple-click mouse events
 661
 662         * editing/CommandByName.cpp: Added.
 663         Added a command class that hangs off the frame so the frame can call commands more easily.
 664         (WebCore::Frame::commandImp):
 665         (WebCore::Frame::execCopy):
 666         (WebCore::Frame::execCut):
 667         (WebCore::Frame::execDelete):
 668         (WebCore::Frame::execForwardDelete):
 669         (WebCore::Frame::execPaste):
 670         (WebCore::Frame::execMoveLeft):
 671         (WebCore::Frame::execMoveRight):
 672         (WebCore::Frame::execMoveUp):
 673         (WebCore::Frame::execMoveDown):
 674         (WebCore::Frame::execSelectAll):
 675         (WebCore::Frame::execSelectLeft):
 676         (WebCore::Frame::execSelectRight):
 677         (WebCore::Frame::execSelectUp):
 678         (WebCore::Frame::execSelectDown):
 679         (WebCore::Frame::enabled):
 680         (WebCore::Frame::enabledAnySelection):
 681         (WebCore::Frame::enabledAnyEditableSelection):
 682         (WebCore::Frame::enabledPaste):
 683         (WebCore::Frame::enabledAnyRangeSelection):
 684         (WebCore::Frame::enabledAnyEditableRangeSelection):
 685         (WebCore::Frame::createCommandDictionary):
 686         (WebCore::Frame::Command::):
 687         (WebCore:::m_frame):
 688         (WebCore::CommandByName::execCommand):
 689         * editing/CommandByName.h: Added.
 690         * page/Frame.cpp:
 691         Added implementation of accessor for CommandByName member
 692         (WebCore::Frame::command):
 693         * page/Frame.h:
 694         Added accessor for CommandByName member
 695         * page/FramePrivate.h:
 696         Added a CommandByName member
 697         (WebCore::FramePrivate::FramePrivate):
 698         * platform/PlatformMouseEvent.h:
 699         Changed constructor prototype
 700         * platform/StringImpl.cpp:
 701         Exposing getWordBreakIterator to be used elsewhere
 702         (WebCore::getWordBreakIterator):
 703         * platform/StringImpl.h:
 704         Exposing getWordBreakIterator to be used elsewhere
 705         * platform/win/MouseEventWin.cpp:
 706         Changed the PlatformMouseEvent on windows so that we "roll our own" multi-click mouse events instead of relying on the system to tell us, enabling us to detect triple-clicks
 707         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
 708
 709 2006-09-28  Adam Roben  <aroben@apple.com>
 710
 711         Reviewed by Adele.
 712
 713         Remove no-longer-used PopUpButton.
 714
 715         * WebCore.vcproj/WebCore/WebCore.vcproj: Remove PopUpButton.h
 716         * WebCore.xcodeproj/project.pbxproj: Remove PopUpButton.h,
 717         PopUpButtonMac.mm
 718         * platform/PopUpButton.h: Removed.
 719         * platform/mac/PopUpButtonMac.mm: Removed.
 720         * platform/win/TemporaryLinkStubs.cpp: Remove PopUpButton:: methods
 721         * rendering/DeprecatedRenderSelect.cpp: Change #include of
 722         PopUpButton.h to ListBox.h
 723
 724 2006-09-28  Darin Adler  <darin@apple.com>
 725
 726         Reviewed by Alice.
 727
 728         - change that should fix <rdar://problem/4733044> REGRESSION: XML iBench shows
 729           10% perf. regression (copying strings while decoding)
 730
 731         Use Vector<UChar> instead of String when building up the decoded string in
 732         the ICU and Mac decoders. Using String leads to O(n^2) behavior because
 733         String grows the buffer every single time that append is called. Using
 734         Vector::append instead of String::append also avoids constructing a string
 735         each time just to append and a questionable copy that is done inside the
 736         String::append function which also contributed to the slowness.
 737
 738         * platform/PlatformString.h:
 739         * platform/String.cpp: (WebCore::String::adopt): Added. Makes a String from a
 740         Vector<UChar>, adopting the buffer from the vector to avoid copying and memory
 741         allocation.
 742         * platform/StringImpl.h:
 743         * platform/StringImpl.cpp: (WebCore::StringImpl::adopt): Ditto.
 744
 745         * platform/StreamingTextDecoder.h:
 746         * platform/StreamingTextDecoder.cpp: (WebCore::TextCodec::appendOmittingBOM):
 747         Change to use a Vector<UChar> instead of a String, since vectors have better
 748         resizing performance (they store a separate capacity).
 749
 750         * platform/StreamingTextDecoderICU.cpp: (WebCore::TextCodecICU::decode):
 751         * platform/mac/StreamingTextDecoderMac.cpp: (WebCore::TextCodecMac::decode):
 752         Change to use Vector<UChar> instead of String and then create a string at
 753         the end of the process using the new adopt function.
 754
 755 2006-09-28  Sam Weinig  <sam.weinig@gmail.com>
 756
 757         Reviewed by Tim H.
 758
 759         Patch for http://bugs.webkit.org/show_bug.cgi?id=11057
 760         Auto-generate more SVG Objective-C bindings
 761
 762         - Auto-generates DOMSVGAnimatedAngle, DOMSVGAnimatedBoolean,
 763           DOMSVGAnimatedEnumeration, DOMSVGAnimatedInteger, DOMSVGAnimatedLength,
 764           DOMSVGAnimatedLengthList, DOMSVGAnimatedNumber, DOMSVGAnimatedString,
 765           DOMSVGAnimatedTransformList, DOMSVGExternalResourcesRequired,
 766           DOMSVGLangSpace, DOMSVGLocatable, DOMSVGMetadataElement, DOMSVGRectElement,
 767           DOMSVGStringList, DOMSVGStylable, DOMSVGStyleElement, DOMSVGTests,
 768           and DOMSVGTransformable.
 769
 770         - Adds ability to CodeGeneratorObjC.pm to handle interfaces with mulitple
 771           parent interfaces and the SVG animated classes.
 772
 773         - Corrects CodeGenerator.pm to only skip the first parent for the main
 774           interface.
 775
 776         * DerivedSources.make:
 777         * WebCore.xcodeproj/project.pbxproj:
 778         * bindings/objc/DOMInternal.h:
 779         * bindings/objc/DOMSVG.h:
 780         * bindings/scripts/CodeGenerator.pm:
 781         * bindings/scripts/CodeGeneratorObjC.pm:
 782         * ksvg2/svg/SVGAnimatedAngle.idl:
 783         * ksvg2/svg/SVGAnimatedBoolean.idl:
 784         * ksvg2/svg/SVGAnimatedEnumeration.idl:
 785         * ksvg2/svg/SVGAnimatedInteger.idl:
 786         * ksvg2/svg/SVGAnimatedLength.idl:
 787         * ksvg2/svg/SVGAnimatedLengthList.idl:
 788         * ksvg2/svg/SVGAnimatedNumber.idl:
 789         * ksvg2/svg/SVGAnimatedPathData.idl:
 790         * ksvg2/svg/SVGAnimatedString.idl:
 791         * ksvg2/svg/SVGAnimatedTransformList.idl:
 792         * ksvg2/svg/SVGExternalResourcesRequired.idl:
 793         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.idl:
 794         * ksvg2/svg/SVGFitToViewBox.idl:
 795         * ksvg2/svg/SVGLangSpace.idl:
 796         * ksvg2/svg/SVGLocatable.idl:
 797         * ksvg2/svg/SVGMetadataElement.idl:
 798         * ksvg2/svg/SVGStringList.idl:
 799         * ksvg2/svg/SVGStylable.idl:
 800         * ksvg2/svg/SVGStyleElement.idl:
 801         * ksvg2/svg/SVGTests.idl:
 802         * ksvg2/svg/SVGTransformable.idl:
 803         * ksvg2/svg/SVGURIReference.idl:
 804         * ksvg2/svg/SVGUnitTypes.idl:
 805         * ksvg2/svg/SVGZoomAndPan.idl:
 806
 807 2006-09-28  Brady Eidson  <beidson@apple.com>
 808
 809         Reviewed by Mitz Pettel!!!
 810
 811         Change the error code check for common functions from SQLResultOk to SQLResultDone
 812
 813         * loader/icon/IconDatabase.cpp:
 814         (WebCore::IconDatabase::forgetPageURLQuery):
 815         (WebCore::IconDatabase::setIconIDForPageURLQuery):
 816         (WebCore::IconDatabase::addIconForIconURLQuery):
 817
 818 2006-09-28  Dave Hyatt  <hyatt@apple.com>
 819
 820         Just eliminate MapWindowPoints usage and use the HWND as
 821         the viewport.
 822
 823         * platform/win/MouseEventWin.cpp:
 824         (WebCore::positionForEvent):
 825         * platform/win/ScrollViewWin.cpp:
 826         (WebCore::ScrollView::viewportToContents):
 827         (WebCore::ScrollView::contentsToViewport):
 828
 829 2006-09-27  David Hyatt  <hyatt@apple.com>
 830
 831         Fix for bug 9222, cursor is wrong when mousing over overflow scrollbars in textareas.  Make sure
 832         selectCursor checks for whether or not a scrollbar was hit.  Also stub out a mouseMoved method for
 833         scrollbars to provide hover feedback if needed.
 834
 835         Reviewed by Eric
 836
 837         * page/FrameView.cpp:
 838         (WebCore::selectCursor):
 839         (WebCore::FrameView::handleMouseMoveEvent):
 840         * platform/ScrollBar.h:
 841         (WebCore::ScrollBar::mouseMoved):
 842
 843 2006-09-27  MorganL  <morganl.webkit@yahoo.com>
 844
 845         Reviewed by Maciej and Adam, landed by Adam
 846
 847         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11072
 848         Windows build is busted
 849
 850         * platform/win/TemporaryLinkStubs.cpp:
 851         (ScrollView::paint):
 852         (ScrollView::themeChanged):
 853
 854 2006-09-27  Eric Seidel  <eric@eseidel.com>
 855
 856         Reviewed by mitz.
 857
 858         paths with no fill specified default to black but do not recieve paint-related mouse events
 859         http://bugs.webkit.org/show_bug.cgi?id=11069
 860         The default fill was being applied at the wrong place in the rendering chain, causing this problem.
 861
 862         Test: svg/custom/hover-default-fill.svg
 863
 864         * kcanvas/RenderPath.cpp:
 865         (WebCore::RenderPath::nodeAtPoint): use isFilled and isStroked
 866         * ksvg2/css/SVGRenderStyle.h: use defaultFill() and defaultStroke()
 867         * ksvg2/misc/KCanvasRenderingStyle.cpp:
 868         (WebCore::KSVGPainterFactory::isFilled): remove null check
 869         (WebCore::KSVGPainterFactory::fillPaintServer): remove null check
 870         (WebCore::KSVGPainterFactory::isStroked): remove null check
 871         (WebCore::KSVGPainterFactory::strokePaintServer): remove null check
 872         * ksvg2/svg/SVGPaint.cpp:
 873         (WebCore::SVGPaint::defaultFill): added.
 874         (WebCore::SVGPaint::defaultStroke): added.
 875         * ksvg2/svg/SVGPaint.h:
 876
 877 2006-09-27  Rob Buis  <buis@kde.org>
 878
 879         Reviewed by eseidel.
 880
 881         http://bugs.webkit.org/show_bug.cgi?id=11015
 882         SVG handles em units incorrectly
 883
 884         Calculate viewport coordinates at layout time, since
 885         at this point the font size is known and lengths depending
 886         on font sizes can be calculated correctly.
 887
 888         * kcanvas/RenderSVGContainer.cpp:
 889         (WebCore::RenderSVGContainer::layout):
 890         (WebCore::RenderSVGContainer::viewport):
 891         (WebCore::RenderSVGContainer::calcViewport):
 892         * kcanvas/RenderSVGContainer.h:
 893         * ksvg2/svg/SVGLength.cpp:
 894         (WebCore::SVGLength::updateValue):
 895         * ksvg2/svg/SVGMarkerElement.cpp:
 896         (WebCore::SVGMarkerElement::createRenderer):
 897         * ksvg2/svg/SVGSVGElement.cpp:
 898         (WebCore::SVGSVGElement::createRenderer):
 899         (WebCore::SVGSVGElement::attributeChanged):
 900         * ksvg2/svg/SVGSVGElement.h:
 901
 902 2006-09-27  Eric Seidel  <eric@eseidel.com>
 903
 904         Reviewed by darin.
 905
 906         Change our invalid-fill error behavior to match Opera (and soon Firefox)
 907         http://bugs.webkit.org/show_bug.cgi?id=11017
 908
 909         * ksvg2/misc/KCanvasRenderingStyle.cpp:
 910         (WebCore::KSVGPainterFactory::isFilled):
 911         (WebCore::KSVGPainterFactory::fillPaintServer):
 912         (WebCore::KSVGPainterFactory::isStroked):
 913         (WebCore::KSVGPainterFactory::strokePaintServer):
 914
 915 2006-09-27  Brady Eidson  <beidson@apple.com>
 916
 917         Build fix
 918
 919         * loader/icon/IconDatabase.cpp:
 920         (WebCore::readySQLStatement):
 921
 922 2006-09-27  Brady Eidson  <beidson@apple.com>
 923
 924         Reviewed by Adam
 925
 926         In very specific circumstances, prepared SQLStatements can become invalid without
 927         any warning.  This checks for that state and re-prepares the statement and also
 928         adds more aggressive error-checking everywhere these statements are used.
 929
 930         * loader/icon/IconDatabase.cpp:
 931         (WebCore::readySQLStatement): Check if the statement is expired - reprepare it
 932         (WebCore::IconDatabase::imageDataForIconURLQuery): More thoroughly catch error cases
 933         (WebCore::IconDatabase::timeStampForIconURLQuery): Ditto
 934         (WebCore::IconDatabase::iconURLForPageURLQuery): Ditto
 935         (WebCore::IconDatabase::forgetPageURLQuery): Ditto
 936         (WebCore::IconDatabase::setIconIDForPageURLQuery): Ditto
 937         (WebCore::IconDatabase::getIconIDForIconURLQuery): Ditto
 938         (WebCore::IconDatabase::addIconForIconURLQuery): Ditto
 939         (WebCore::IconDatabase::hasIconForIconURLQuery): Ditto
 940         * loader/icon/SQLStatement.cpp:
 941         (WebCore::SQLStatement::isExpired): Added (accessor to sqlite3_expired())
 942         * loader/icon/SQLStatement.h:
 943
 944 2006-09-26  Darin Adler  <darin@apple.com>
 945
 946         Reviewed by Steve.
 947
 948         - clean up options for font code path
 949
 950         * platform/Font.h:
 951         * platform/Font.cpp:
 952         (WebCore::Font::setCodePath): Added. Replaces boolean version.
 953         (WebCore::Font::canUseGlyphCache): Update to handle "never use complex" case too.
 954
 955         * platform/mac/WebCoreTextRenderer.mm:
 956         (WebCoreSetAlwaysUseATSU): Change to call setCodePath.
 957
 958 2006-09-26  John Sullivan  <sullivan@apple.com>
 959
 960         Reviewed by Darin
 961
 962         * bridge/mac/WebCoreFrameBridge.h:
 963         * bridge/mac/WebCoreFrameBridge.mm:
 964         (-[WebCoreFrameBridge markAllMatchesForText:caseSensitive:limit:]):
 965         Added limit parameter, passed down to Frame
 966
 967         * page/Frame.h:
 968         * page/Frame.cpp:
 969         (WebCore::Frame::markAllMatchesForText):
 970         Added limit parameter. Stop the search if it hits limit.
 971
 972 2006-09-26  Sean Gies  <seangies@apple.com>
 973
 974         Reviewed by Brady Eidson.
 975
 976         * platform/cg/ImageCG.cpp: Removed #if's -- Darin said we don't need these.
 977
 978 2006-09-26  Justin Garcia  <justin.garcia@apple.com>
 979
 980         Reviewed by john
 981
 982         <rdar://problem/4747695>
 983         Gmail Editor: Crash at WebCore::Range::startPosition() when decreasing a indent
 984
 985         * editing/DeleteSelectionCommand.cpp:
 986         (WebCore::DeleteSelectionCommand::initializeStartEnd): Stop expanding
 987         to select special elements that are fully selected after expansion
 988         moves to positions that are visually distinct from the originals.
 989         * editing/InsertListCommand.cpp:
 990         (WebCore::InsertListCommand::doApply): If the content of the list
 991         item will be moved into another list, put it in a list item.
 992
 993 2006-09-26  Geoffrey Garen <ggaren@apple.com>
 994
 995         Reviewed by Darin.
 996
 997         Temporary work-around for frame lifetime issue.
 998
 999         * page/Frame.cpp:
1000         (WebCore::Frame::clear):
1001         (WebCore::Frame::disconnectOwnerElement):
1002
1003 2006-09-26  Sam Weinig  <sam.weinig@gmail.com>
1004
1005         Reviewed by Tim H.
1006
1007         Patch for http://bugs.webkit.org/show_bug.cgi?id=11038
1008         Auto-generate DOMSVGElement for the Objective-C bindings
1009
1010         - Auto-generates DOMSVGElement.
1011
1012         - Make SVGExceptions work like all the other ExceptionCode
1013           extensions (Range, XPath, etc.) by adding SVGExceptionOffset
1014           and SVGExceptionMax.
1015
1016         * DerivedSources.make:
1017         * WebCore.xcodeproj/project.pbxproj:
1018         * bindings/js/kjs_binding.cpp:
1019         (KJS::):
1020         (KJS::setDOMException):
1021         * bindings/objc/DOMInternal.h:
1022         * bindings/objc/DOMInternal.mm:
1023         (raiseDOMException):
1024         * bindings/objc/DOMSVG.h:
1025         * bindings/objc/DOMSVGExecption.h: Added.
1026         * ksvg2/ksvg.h:
1027         * ksvg2/svg/SVGElement.cpp:
1028         (WebCore::SVGElement::setId):
1029         (WebCore::SVGElement::setXmlbase):
1030         * ksvg2/svg/SVGElement.h:
1031         * ksvg2/svg/SVGElement.idl:
1032         * ksvg2/svg/SVGException.h: Added.
1033         (WebCore::):
1034
1035 2006-09-26  Eric Seidel  <eric@eseidel.com>
1036
1037         Reviewed by Tim H.
1038
1039         viewbox parser does not allow <tab> as a delimiter
1040         http://bugs.webkit.org/show_bug.cgi?id=11014
1041
1042         Test: svg/hixie/viewbox/003.xml
1043
1044         * ksvg2/svg/svgpathparser.cpp:
1045         (WebCore::isWhitespace): new function
1046         (WebCore::skipOptionalSpaces):
1047         (WebCore::skipOptionalSpacesOrComma):
1048
1049 2006-09-26  Eric Seidel  <eric@eseidel.com>
1050
1051         Reviewed by Tim H.
1052
1053         SVGDocument::createElement does not create elements in the SVG namespace
1054         http://bugs.webkit.org/show_bug.cgi?id=10932
1055
1056         Test: svg/custom/createelement.svg
1057
1058         * ksvg2/svg/SVGDocument.cpp:
1059         (WebCore::SVGDocument::createElement):
1060         * ksvg2/svg/SVGDocument.h:
1061
1062 2006-09-26  Eric Seidel  <eric@eseidel.com>
1063
1064         Reviewed by Tim H.
1065
1066         RenderPath::nodeAtPoint does not respect stroke width
1067         http://bugs.webkit.org/show_bug.cgi?id=10829
1068
1069         Test: svg/custom/stroke-width-click.svg
1070
1071         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
1072         (WebCore::RenderPath::strokeContains):
1073         * kcanvas/device/quartz/QuartzSupport.h:
1074         * kcanvas/device/quartz/QuartzSupport.mm:
1075
1076 2006-09-26  Eric Seidel  <eric@eseidel.com>
1077
1078         Reviewed by mitz.
1079
1080         Bring animation back to life
1081         http://bugs.webkit.org/show_bug.cgi?id=11021
1082
1083         Register/unregister SVGSVGElements as time containers on insertion/removal.
1084         Replace uses of DeprecatedString with String in SVGAnimationElement
1085         Various whitespace clean-up.
1086
1087         * ksvg2/misc/KSVGTimeScheduler.cpp:
1088         (WebCore::SVGTimer::notifyAll):
1089         * ksvg2/misc/SVGDocumentExtensions.cpp:
1090         (WebCore::SVGDocumentExtensions::startAnimations):
1091         (WebCore::SVGDocumentExtensions::pauseAnimations):
1092         (WebCore::SVGDocumentExtensions::unpauseAnimations):
1093         * ksvg2/svg/SVGAnimateTransformElement.cpp:
1094         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
1095         (WebCore::SVGAnimateTransformElement::parseTransformValue):
1096         * ksvg2/svg/SVGAnimateTransformElement.h:
1097         * ksvg2/svg/SVGAnimationElement.cpp:
1098         (WebCore::SVGAnimationElement::SVGAnimationElement):
1099         (WebCore::SVGAnimationElement::parseMappedAttribute):
1100         (WebCore::SVGAnimationElement::parseClockValue):
1101         (WebCore::SVGAnimationElement::targetAttribute):
1102         (WebCore::SVGAnimationElement::setTargetAttribute):
1103         (WebCore::SVGAnimationElement::attributeName):
1104         * ksvg2/svg/SVGAnimationElement.h:
1105         (WebCore::SVGAnimationElement::rendererIsNeeded):
1106         * ksvg2/svg/SVGSVGElement.cpp:
1107         (WebCore::SVGSVGElement::getScreenCTM):
1108         (WebCore::SVGSVGElement::createRenderer):
1109         (WebCore::SVGSVGElement::insertedIntoDocument): added, calls addTimeContainer(this)
1110         (WebCore::SVGSVGElement::removedFromDocument): added, calls removeTimeContainer(this)
1111         * ksvg2/svg/SVGSVGElement.h:
1112         * ksvg2/svg/SVGSetElement.cpp:
1113         (WebCore::SVGSetElement::handleTimerEvent):
1114         * ksvg2/svg/SVGURIReference.cpp:
1115         (WebCore::SVGURIReference::getTarget):
1116         * ksvg2/svg/SVGURIReference.h:
1117
1118 2006-09-26  Graham Dennis  <graham.dennis@gmail.com>
1119
1120         Reviewed by mitzpettel.
1121
1122         - fix http://bugs.webkit.org/show_bug.cgi?id=11020
1123         No-SVG build broken since r16549
1124
1125         Change #if SVG_SUPPORT to #ifdef SVG_SUPPORT
1126
1127         * css/cssparser.cpp:
1128         (WebCore::CSSParser::parseValue):
1129         * css/cssstyleselector.cpp:
1130         (WebCore::CSSStyleSelector::applyProperty):
1131         * page/FrameView.cpp:
1132         (WebCore::selectCursor):
1133         * platform/qt/GraphicsContextQt.cpp:
1134
1135 2006-09-26  Anders Carlsson  <acarlsson@apple.com>
1136
1137         Reviewed by Maciej.
1138
1139         http://bugs.webkit.org/show_bug.cgi?id=10820
1140         Add StringImpl::toDouble() and remove uses of .deprecatedString().toDouble()
1141
1142         (Originally written by Eric Seidel).
1143
1144         * bindings/js/kjs_window.cpp:
1145         (KJS::floatFeature):
1146         * ksvg2/svg/SVGAngle.cpp:
1147         (SVGAngle::setValueAsString):
1148         * ksvg2/svg/SVGAnimationElement.cpp:
1149         (SVGAnimationElement::parseMappedAttribute):
1150         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
1151         (SVGComponentTransferFunctionElement::parseMappedAttribute):
1152         * ksvg2/svg/SVGFECompositeElement.cpp:
1153         (WebCore::SVGFECompositeElement::parseMappedAttribute):
1154         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
1155         (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
1156         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
1157         (SVGFEDisplacementMapElement::parseMappedAttribute):
1158         * ksvg2/svg/SVGFELightElement.cpp:
1159         (SVGFELightElement::parseMappedAttribute):
1160         * ksvg2/svg/SVGFEOffsetElement.cpp:
1161         (WebCore::SVGFEOffsetElement::parseMappedAttribute):
1162         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
1163         (SVGFESpecularLightingElement::parseMappedAttribute):
1164         * ksvg2/svg/SVGFETurbulenceElement.cpp:
1165         (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
1166         * ksvg2/svg/SVGStopElement.cpp:
1167         (SVGStopElement::parseMappedAttribute):
1168         * platform/AtomicString.h:
1169         (WebCore::AtomicString::toDouble):
1170         * platform/PlatformString.h:
1171         * platform/String.cpp:
1172         (WebCore::String::toDouble):
1173         * platform/StringImpl.cpp:
1174         (WebCore::StringImpl::toDouble):
1175         * platform/StringImpl.h:
1176         * rendering/DeprecatedSlider.cpp:
1177         (WebCore::DeprecatedSlider::updateFromElement):
1178         * xml/XPathGrammar.y:
1179
1180 2006-09-25  David Harrison  <harrison@apple.com>
1181
1182         Reviewed by Tim Omernick and Tim Hatcher.
1183
1184         <rdar://problem/4717965> Text Field text parameterized attributes should work
1185         <rdar://problem/4712111> Support NSAccessibilityInsertionPointLineNumberAttribute for AXTextArea elements
1186
1187         * bridge/mac/WebCoreAXObject.mm:
1188         (-[WebCoreAXObject accessibilityAttributeValue:]):
1189         Use new line number support to implement NSAccessibilityInsertionPointLineNumberAttribute.
1190
1191         (-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
1192         Cleaned up. Added text field and text area parameterzed attributes.
1193
1194         (-[WebCoreAXObject doAXLineForTextMarker:]):
1195         Fixed to be zero-based and to deal with the first position properly.
1196
1197         (-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
1198         Minor formatting.
1199
1200         (-[WebCoreAXObject textMarkerForIndex:lastIndexOK:]):
1201         (-[WebCoreAXObject indexForTextMarker:]):
1202         (-[WebCoreAXObject textMarkerRangeForRange:]):
1203         (-[WebCoreAXObject rangeForTextMarkerRange:]):
1204         New utility methods.
1205
1206         (-[WebCoreAXObject doAXLineForIndex:]):
1207         (-[WebCoreAXObject doAXRangeForLine:]):
1208         (-[WebCoreAXObject doAXStringForRange:]):
1209         (-[WebCoreAXObject doAXRangeForPosition:]):
1210         (-[WebCoreAXObject doAXRangeForIndex:]):
1211         (-[WebCoreAXObject doAXBoundsForRange:]):
1212         (-[WebCoreAXObject doAXAttributedStringForRange:]):
1213         (-[WebCoreAXObject doAXRTFForRange:]):
1214         (-[WebCoreAXObject doAXStyleRangeForIndex:]):
1215         Implement text field and text area parameterized attributes.
1216
1217         (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
1218         Added text field and text area parameterzed attributes.
1219
1220         * rendering/RenderTextControl.h:
1221         Made indexForVisiblePosition() and visiblePositionForIndex() public.
1222
1223 2006-09-25  Adam Roben  <aroben@apple.com>
1224
1225         Reviewed by Brady.
1226
1227         Build fixes.
1228
1229         * WebCore.vcproj/WebCore/WebCore.vcproj: Fix malformed XML.
1230         * platform/ResourceLoader.h: Store whether a particular job
1231         has received a response within the ResourceLoader object itself, since
1232         it's possible that we will enter the InternetReadFileExA while loop
1233         twice for the same job.
1234         * platform/ResourceLoaderInternal.h: Add private instance variable to
1235         store whether we've received a response.
1236         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
1237         * platform/win/GraphicsContextWin.cpp: Fix order of preprocessor
1238         directives.
1239         * platform/win/ResourceLoaderWin.cpp:
1240         (WebCore::ResourceLoader::onRequestComplete): Ask the ResourceLoader
1241         whether it has received a response instead of assuming it hasn't.
1242         (WebCore::ResourceLoader::setHasReceivedResponse): Added.
1243         (WebCore::ResourceLoader::hasReceivedResponse): Added.
1244         * platform/win/TemporaryLinkStubs.cpp: Rename setKnobProportion to
1245         setProportion
1246         (ScrollBar::setProportion):
1247
1248 2006-09-25  Brady Eidson  <beidson@apple.com>
1249
1250         Requested by ggaren
1251
1252         Disabled IconDatabase logging by default
1253
1254         * platform/Logging.cpp:
1255         (WebCore::):
1256
1257 2006-09-25  Steve Falkenburg  <sfalken@apple.com>
1258
1259         Build fix
1260
1261         * platform/cf/ResourceLoaderCFNet.cpp:
1262         (WebCore::willCacheResponse):
1263
1264 2006-09-25  Justin Garcia  <justin.garcia@apple.com>
1265
1266         Reviewed by john
1267
1268         <http://bugs.webkit.org/show_bug.cgi?id=11002>
1269         Gmail Editor: Crash at WebCore::SplitElementCommand::doApply() when attempting to indent in a new message
1270
1271         * editing/IndentOutdentCommand.cpp:
1272         (WebCore::IndentOutdentCommand::indentRegion): Special case
1273         an empty root editable element.
1274
1275 2006-09-25  Brady Eidson  <beidson@apple.com>
1276
1277         Reviewed by Steve
1278
1279         Math error in SystemTimeWin
1280
1281         * platform/win/SystemTimeWin.cpp:
1282         (WebCore::currentTime):
1283
1284 2006-09-25  Alexey Proskuryakov  <ap@nypop.com>
1285
1286         Reviewed by Eric.
1287
1288         Whitespace cleanup; rename *job variables to *loader.
1289
1290         * bindings/js/JSXMLHttpRequest.cpp:
1291         (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
1292         (KJS::JSXMLHttpRequestConstructorImp::implementsConstruct):
1293         (KJS::JSXMLHttpRequestConstructorImp::construct):
1294         (KJS::JSXMLHttpRequest::getOwnPropertySlot):
1295         (KJS::JSXMLHttpRequest::getValueProperty):
1296         (KJS::JSXMLHttpRequest::put):
1297         (KJS::JSXMLHttpRequest::putValueProperty):
1298         (KJS::JSXMLHttpRequest::mark):
1299         (KJS::JSXMLHttpRequest::JSXMLHttpRequest):
1300         (KJS::JSXMLHttpRequest::~JSXMLHttpRequest):
1301         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
1302         * bindings/js/JSXMLHttpRequest.h:
1303         (KJS::JSXMLHttpRequest::toBoolean):
1304         * xml/xmlhttprequest.cpp:
1305         (WebCore::XMLHttpRequest::XMLHttpRequest):
1306         (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):
1307         (WebCore::XMLHttpRequest::send):
1308         (WebCore::XMLHttpRequest::abort):
1309         (WebCore::XMLHttpRequest::receivedAllData):
1310         (WebCore::XMLHttpRequest::receivedData):
1311         * xml/xmlhttprequest.h:
1312         (WebCore::):
1313
1314 2006-09-25  Timothy Hatcher  <timothy@apple.com>
1315
1316         Reviewed by Brady.
1317
1318         - Deprecate the rest of the old-style methods that are not generated.
1319         - Add @property syntax to DOMRange.
1320
1321         * WebCore.xcodeproj/project.pbxproj:
1322         * bindings/objc/DOM.mm:
1323         (-[DOMRange setStart:offset:]):
1324         (-[DOMRange setEnd:offset:]):
1325         (-[DOMRange compareBoundaryPoints:sourceRange:]):
1326         (-[DOMRange setStart::]):
1327         (-[DOMRange setEnd::]):
1328         (-[DOMRange compareBoundaryPoints::]):
1329         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
1330         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
1331         (-[DOMDocument createNodeIterator::::]):
1332         (-[DOMDocument createTreeWalker::::]):
1333         * bindings/objc/DOMCSS.h:
1334         * bindings/objc/DOMCSS.mm:
1335         (-[DOMDocument getComputedStyle:pseudoElement:]):
1336         (-[DOMDocument getComputedStyle::]):
1337         (-[DOMDocument getMatchedCSSRules:pseudoElement:]):
1338         * bindings/objc/DOMExtensions.h:
1339         * bindings/objc/DOMHTML.h:
1340         * bindings/objc/DOMRange.h:
1341         * bindings/objc/DOMTraversal.h:
1342
1343 2006-09-25  Eric Seidel  <eric@eseidel.com>
1344
1345         Reviewed by mjs.
1346
1347         Outermost <svg> element should clip to viewport
1348         http://bugs.webkit.org/show_bug.cgi?id=11007
1349
1350         Test: svg/custom/viewport-clip.svg
1351
1352         * css/svg.css: change svg:root overflow: from 'visible' to 'hidden'
1353
1354 2006-09-25  Anders Carlsson  <acarlsson@apple.com>
1355
1356         Reviewed by Maciej.
1357
1358         * css/MediaList.cpp:
1359         Remove unused header.
1360
1361         * dom/Document.cpp:
1362         (WebCore::Document::clear):
1363         Use clear instead of iterating through the list of event listeners, removing each one.
1364         (Doing that causes a crash when running the layout tests with GuardMalloc turned on)
1365
1366         * html/HTMLKeygenElement.cpp:
1367         (WebCore::HTMLKeygenElement::HTMLKeygenElement):
1368         (WebCore::HTMLKeygenElement::appendFormData):
1369         Update due to changes in the SSL key generator.
1370
1371         * ksvg2/svg/SVGAngle.cpp:
1372         Remove unused header.
1373
1374         * ksvg2/svg/SVGAnimationElement.cpp:
1375         (SVGAnimationElement::parseMappedAttribute):
1376         Rename methods and pass Strings instead of DeprecatedStrings to
1377         parseSeparatedList.
1378
1379         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
1380         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
1381         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
1382         * ksvg2/svg/SVGFEMergeElement.cpp:
1383         * ksvg2/svg/SVGFEOffsetElement.cpp:
1384         Remove unused headers.
1385
1386         * ksvg2/svg/SVGHelper.cpp:
1387         (WebCore::SVGHelper::parseSeparatedList):
1388         * ksvg2/svg/SVGHelper.h:
1389         Rename ParseSeperatedList to parseSeparatedList, make it take a String instead of a
1390         DeprecatedString and have it use Vector<String> instead of DeprecatedStringList.
1391
1392         * ksvg2/svg/SVGLengthList.cpp:
1393         (WebCore::SVGLengthList::parse):
1394         * ksvg2/svg/SVGLengthList.h:
1395         Use Vector<String> instead of DeprecatedStringList.
1396
1397         * loader/Cache.cpp:
1398         (WebCore::Cache::requestImage):
1399         (WebCore::Cache::requestStyleSheet):
1400         (WebCore::Cache::requestScript):
1401         (WebCore::Cache::requestXSLStyleSheet):
1402         (WebCore::Cache::requestXBLDocument):
1403         (WebCore::Cache::remove):
1404         (WebCore::Cache::get):
1405         Use a String as the key in the cache set instead of a RefPtr<StringImpl>.
1406
1407         * loader/DocLoader.cpp:
1408         (WebCore::DocLoader::needReload):
1409         * loader/DocLoader.h:
1410         Use a HashSet instead of DeprecatedStringList.
1411
1412         * page/FrameView.h:
1413         Remove declarations that have no functions.
1414
1415         * platform/SSLKeyGenerator.h:
1416         * platform/mac/SSLKeyGeneratorMac.mm:
1417         (WebCore::supportedKeySizes):
1418         (WebCore::signedPublicKeyAndChallengeString):
1419         Convert to use Vector<String> instead of DeprecatedStringList, and String instead of
1420         DeprecatedString.
1421
1422 2006-09-25  Dave Hyatt  <hyatt@apple.com>
1423
1424         Shunt the RenderTheme world transform adoption between
1425         Cairo and Windows into getWindowsContext and move the method
1426         out of GraphicsContextCairo and into GraphicsContextWin.
1427
1428         * ChangeLog:
1429         * WebCore.vcproj/WebCore/WebCore.vcproj:
1430         * platform/cairo/GraphicsContextCairo.cpp:
1431         * platform/win/GraphicsContextWin.cpp: Added.
1432         (WebCore::GraphicsContext::getWindowsContext):
1433         (WebCore::GraphicsContext::releaseWindowsContext):
1434         * rendering/RenderThemeWin.cpp:
1435         (WebCore::prepareForDrawing):
1436
1437 2006-09-24  Eric Seidel  <eric@eseidel.com>
1438
1439         Reviewed by hyatt.
1440
1441         <svg:a> cannot be styled with a:hover
1442         http://bugs.webkit.org/show_bug.cgi?id=11005
1443
1444         Test: svg/hixie/cascade/002.xml
1445
1446         * css/cssstyleselector.cpp:
1447         (WebCore::checkPseudoState):
1448
1449 2006-09-24  Sam Weinig  <sam.weinig@gmail.com>
1450
1451         Reviewed by Tim H.
1452
1453         Patch for http://bugs.webkit.org/show_bug.cgi?id=10882
1454         SVG needs Obj-C DOM bindings
1455
1456         - Auto-generate the first 8 Objective-C SVG DOM bindings.  The
1457           auto-generated classes are DOMSVGAngle, DOMSVGLength, DOMSVGLengthList,
1458           DOMSVGMatrix, DOMSVGPathSeg, DOMSVGPathSegList, DOMSVGTransform, and
1459           DOMSVGTransformList.
1460
1461         * DerivedSources.make:
1462         * WebCore.xcodeproj/project.pbxproj:
1463         * bindings/objc/DOMInternal.h:
1464         * bindings/objc/DOMSVG.h: Added.
1465         * ksvg2/svg/SVGAngle.idl:
1466         * ksvg2/svg/SVGLength.idl:
1467         * ksvg2/svg/SVGLengthList.idl:
1468         * ksvg2/svg/SVGMatrix.idl:
1469         * ksvg2/svg/SVGPathSeg.idl:
1470         * ksvg2/svg/SVGPathSegList.idl:
1471         * ksvg2/svg/SVGTransform.idl:
1472         * ksvg2/svg/SVGTransformList.idl:
1473
1474 2006-09-24  Rob Buis  <buis@kde.org>
1475
1476         Reviewed by eseidel.
1477
1478         Fix for http://bugs.webkit.org/show_bug.cgi?id=6001
1479         WebKit does not handle fallback custom cursors
1480         Fix for http://bugs.webkit.org/show_bug.cgi?id=6002
1481         WebKit does not properly handle SVG <cursor> element
1482
1483         Add support for svg cursor images. Also make sure hotspot
1484         settings are handled correctly. Add tests for handling of css3
1485         cursor syntax with hotspots in strict and quirks mode. Finally
1486         implement fallback.
1487
1488         * WebCore.xcodeproj/project.pbxproj:
1489         * css/CSSComputedStyleDeclaration.cpp:
1490         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
1491         * css/CSSCursorImageValue.cpp: Added.
1492         (WebCore::CSSCursorImageValue::CSSCursorImageValue):
1493         (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
1494         * css/CSSCursorImageValue.h: Added.
1495         (WebCore::CSSCursorImageValue::hotspot):
1496         * css/cssparser.cpp:
1497         (WebCore::CSSParser::parseValue):
1498         * css/cssstyleselector.cpp:
1499         (WebCore::CSSStyleSelector::applyProperty):
1500         * ksvg2/svg/SVGCursorElement.cpp:
1501         * manual-tests/css3-cursor-fallback-quirks.html: Added.
1502         * manual-tests/css3-cursor-fallback-strict.html: Added.
1503         * manual-tests/cursorfallback.xml: Added.
1504         * page/FrameView.cpp:
1505         (WebCore::selectCursor):
1506         * platform/Cursor.h:
1507         * platform/mac/CursorMac.mm:
1508         (WebCore::createCustomCursor):
1509         (WebCore::Cursor::Cursor):
1510         * platform/qt/CursorQt.cpp:
1511         (WebCore::Cursor::Cursor):
1512         * rendering/RenderStyle.cpp:
1513         (WebCore::StyleInheritedData::StyleInheritedData):
1514         (WebCore::StyleInheritedData::operator==):
1515         (WebCore::RenderStyle::diff):
1516         (WebCore::RenderStyle::addCursor):
1517         (WebCore::RenderStyle::addSVGCursor):
1518         (WebCore::RenderStyle::setCursorList):
1519         (WebCore::RenderStyle::clearCursorList):
1520         * rendering/RenderStyle.h:
1521         (WebCore::CursorData::CursorData):
1522         (WebCore::CursorList::operator[]):
1523         (WebCore::CursorList::size):
1524         (WebCore::CursorList::append):
1525         (WebCore::RenderStyle::cursors):
1526
1527 2006-09-24  Sam Weinig  <sam.weinig@gmail.com>
1528
1529         Reviewed by Tim H.
1530
1531         Patch for http://bugs.webkit.org/show_bug.cgi?id=11009
1532         Auto-generate the internal methods interfaces for the Objective-C bindings
1533
1534         - Auto-generate the internal method declarations into their own files
1535           named in the form DOMFooBarInternal.h for class DOMFooBar.
1536
1537         - Remove all use of DOM_cast from code.
1538
1539         - Assorted cleanups.
1540
1541         * WebCore.xcodeproj/project.pbxproj:
1542         * bindings/objc/DOM.mm:
1543         (-[DOMNode _initWithNode:WebCore::]):
1544         (-[DOMNode WebCore::]):
1545         (-[DOMRange dealloc]):
1546         (-[DOMRange finalize]):
1547         (-[DOMRange _initWithRange:WebCore::]):
1548         (-[DOMRange WebCore::]):
1549         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
1550         (-[DOMNodeFilter WebCore::]):
1551         (-[DOMNodeFilter dealloc]):
1552         (-[DOMNodeFilter finalize]):
1553         (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]):
1554         (-[DOMNodeIterator WebCore::]):
1555         (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]):
1556         (-[DOMTreeWalker WebCore::]):
1557         * bindings/objc/DOMAbstractView.mm:
1558         (-[DOMAbstractView _initWithAbstractView:WebCore::]):
1559         * bindings/objc/DOMCSS.mm:
1560         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
1561         (-[DOMCSSRule _initWithRule:WebCore::]):
1562         (-[DOMCSSValue _initWithValue:WebCore::]):
1563         * bindings/objc/DOMEvents.mm:
1564         (-[DOMEvent _initWithEvent:WebCore::]):
1565         * bindings/objc/DOMHTMLAppletElement.mm:
1566         (-[DOMHTMLAppletElement align]):
1567         (-[DOMHTMLAppletElement setAlign:]):
1568         (-[DOMHTMLAppletElement alt]):
1569         (-[DOMHTMLAppletElement setAlt:]):
1570         (-[DOMHTMLAppletElement archive]):
1571         (-[DOMHTMLAppletElement setArchive:]):
1572         (-[DOMHTMLAppletElement code]):
1573         (-[DOMHTMLAppletElement setCode:]):
1574         (-[DOMHTMLAppletElement codeBase]):
1575         (-[DOMHTMLAppletElement setCodeBase:]):
1576         (-[DOMHTMLAppletElement height]):
1577         (-[DOMHTMLAppletElement setHeight:]):
1578         (-[DOMHTMLAppletElement hspace]):
1579         (-[DOMHTMLAppletElement setHspace:]):
1580         (-[DOMHTMLAppletElement name]):
1581         (-[DOMHTMLAppletElement setName:]):
1582         (-[DOMHTMLAppletElement object]):
1583         (-[DOMHTMLAppletElement setObject:]):
1584         (-[DOMHTMLAppletElement vspace]):
1585         (-[DOMHTMLAppletElement setVspace:]):
1586         (-[DOMHTMLAppletElement width]):
1587         (-[DOMHTMLAppletElement setWidth:]):
1588         * bindings/objc/DOMInternal.h:
1589         (getDOMWrapper):
1590         (addDOMWrapper):
1591         (raiseOnDOMError):
1592         * bindings/objc/DOMXPath.mm:
1593         (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
1594         * bindings/scripts/CodeGeneratorObjC.pm:
1595
1596 2006-09-24  Nikolas Zimmermann  <zimmermann@kde.org>
1597
1598         Reviewed by eseidel.
1599
1600         Fix Qt/Linux build after Dave's Scrollbar changes.
1601
1602         * platform/qt/PlatformScrollBar.h: (Somehow this contained the file twice! Removed one instance!)
1603         * platform/qt/TemporaryLinkStubs.cpp:
1604         (WebCore::ScrollBar::setProportion):
1605         (WebCore::PlatformScrollBar::updateThumbPosition):
1606         (WebCore::PlatformScrollBar::updateThumbProportion):
1607
1608 2006-09-24  Nikolas Zimmermann  <zimmermann@kde.org>
1609
1610         Reviewed by eseidel.
1611
1612         Qt/Linux build system changes: enable xpath/xslt by default.
1613         Offer possibility to change all of these using 'ccmake'.
1614
1615         * CMakeLists.txt:
1616
1617 2006-09-24  Dave Hyatt  <hyatt@apple.com>
1618
1619         Cleanup of Scrollbar APIs.  Rename setKnobProportion to setProportion.  Rename setScrollbarValue to updateThumbPosition.
1620         Give setProportion a base class implementation and implement it using the same pattern as setValue/updateThumbPosition (so that
1621         the base calls a protected virtual function, updateThumbProportion, implemented by the derived class to update the actual scrollbar itself).
1622
1623         * platform/ScrollBar.cpp:
1624         (WebCore::ScrollBar::setValue):
1625         (WebCore::ScrollBar::setProportion):
1626         * platform/ScrollBar.h:
1627         (WebCore::ScrollBar::value):
1628         * platform/mac/PlatformScrollBar.h:
1629         * platform/mac/PlatformScrollBarMac.mm:
1630         (WebCore::PlatformScrollBar::updateThumbPosition):
1631         (WebCore::PlatformScrollBar::updateThumbProportion):
1632         * platform/win/PlatformScrollBar.h:
1633         * platform/win/TemporaryLinkStubs.cpp:
1634         (PlatformScrollBar::updateThumbPosition):
1635         (PlatformScrollBar::updateThumbProportion):
1636         * rendering/RenderLayer.cpp:
1637         (WebCore::RenderLayer::updateScrollInfoAfterLayout):
1638
1639 2006-09-23  Alexey Proskuryakov  <ap@nypop.com>
1640
1641         Reviewed by Eric.
1642
1643         http://bugs.webkit.org/show_bug.cgi?id=4872
1644         XMLHttpRequest fails to throw an exception when there is a security violation
1645         (mismatching domains)
1646
1647         Raise an exception if there is a security violation, and also in cases required by
1648         the current draft of XHR specification.
1649
1650         * bindings/js/JSXMLHttpRequest.cpp:
1651         (KJS::JSXMLHttpRequest::getValueProperty): Raise an exception if a DOM method reports one.
1652         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Raise an exception if a DOM method
1653         reports one, and also if there were too few arguments passed.
1654
1655         * bindings/js/kjs_binding.cpp:
1656         (KJS::setDOMException): Added support for custom XHR exceptions.
1657
1658         * xml/xmlhttprequest.h: Changed state names to match the current spec. Defined an
1659         exception code range for XHR exceptions.
1660
1661         * xml/xmlhttprequest.cpp:
1662         (WebCore::XMLHttpRequest::open): Removed a check for m_aborted that could never succeed.
1663         (WebCore::XMLHttpRequest::send):
1664         (WebCore::XMLHttpRequest::setRequestHeader):
1665         (WebCore::XMLHttpRequest::getStatus):
1666         (WebCore::XMLHttpRequest::getStatusText):
1667         (WebCore::XMLHttpRequest::processSyncLoadResults):
1668         (WebCore::XMLHttpRequest::receivedAllData):
1669         (WebCore::XMLHttpRequest::receivedData):
1670
1671 2006-09-22  Steve Falkenburg  <sfalken@apple.com>
1672
1673         Reviewed by Jeff Jenkins.
1674
1675         Tweak CF types.
1676
1677         * platform/cf/ResourceLoaderCFNet.cpp:
1678         (WebCore::willCacheResponse):
1679
1680 2006-09-22  Justin Garcia  <justin.garcia@apple.com>
1681
1682         Reviewed by darin
1683
1684         <http://bugs.webkit.org/show_bug.cgi?id=8029>
1685         Rename Node::isAncestor and RenderObject::hasAncestor to isDescendantOf
1686
1687         * dom/Document.cpp:
1688         (WebCore::Document::clearSelectionIfNeeded):
1689         * dom/Element.cpp:
1690         (WebCore::Element::contains):
1691         * dom/Node.cpp:
1692         (WebCore::Node::traverseNextNode):
1693         (WebCore::Node::traverseNextSibling):
1694         (WebCore::Node::traversePreviousNodePostOrder):
1695         (WebCore::Node::checkAddChild):
1696         (WebCore::Node::isDescendantOf):
1697         * dom/Node.h:
1698         * dom/NodeIterator.cpp:
1699         (WebCore::NodeIterator::notifyBeforeNodeRemoval):
1700         * editing/ApplyStyleCommand.cpp:
1701         (WebCore::ApplyStyleCommand::applyBlockStyle):
1702         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
1703         (WebCore::ApplyStyleCommand::applyInlineStyle):
1704         (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode):
1705         * editing/CompositeEditCommand.cpp:
1706         (WebCore::CompositeEditCommand::mergeIdenticalElements):
1707         (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
1708         * editing/DeleteSelectionCommand.cpp:
1709         (WebCore::updatePositionForNodeRemoval):
1710         (WebCore::DeleteSelectionCommand::handleGeneralDelete):
1711         (WebCore::DeleteSelectionCommand::mergeParagraphs):
1712         * editing/FormatBlockCommand.cpp:
1713         (WebCore::FormatBlockCommand::doApply):
1714         * editing/IndentOutdentCommand.cpp:
1715         (WebCore::enclosingListOrBlockquote):
1716         * editing/Selection.cpp:
1717         (WebCore::Selection::validate):
1718         * editing/SelectionController.cpp:
1719         (WebCore::SelectionController::nodeWillBeRemoved):
1720         * editing/TextIterator.cpp:
1721         (WebCore::SimplifiedBackwardsTextIterator::advance):
1722         * editing/VisiblePosition.cpp:
1723         (WebCore::VisiblePosition::next):
1724         (WebCore::VisiblePosition::previous):
1725         (WebCore::VisiblePosition::canonicalPosition):
1726         (WebCore::isFirstVisiblePositionInNode):
1727         (WebCore::isLastVisiblePositionInNode):
1728         * editing/htmlediting.cpp:
1729         (WebCore::firstEditablePositionAfterPositionInRoot):
1730         (WebCore::lastEditablePositionBeforePositionInRoot):
1731         (WebCore::enclosingNodeWithTag):
1732         (WebCore::enclosingList):
1733         (WebCore::enclosingListChild):
1734         * editing/markup.cpp:
1735         (WebCore::createMarkup):
1736
1737 2006-09-22  Timothy Hatcher  <timothy@apple.com>
1738
1739         Reviewed by Darin.
1740
1741         - Added @property syntax to non-generated headers
1742           inside #ifndef BUILDING_ON_TIGER.
1743         - Changed the DOMEventTarget protocol to have have new versions
1744           of addEventListener and removeEventListener with named parameters.
1745           These old style methods can be removed once Mail changes to use
1746           the new methods <rdar://problem/4746649>.
1747
1748         * WebCorePrefix.h: define BUILDING_ON_TIGER when Tiger is the target
1749         * bindings/objc/DOM.mm:
1750         (-[DOMNode addEventListener:listener:useCapture:]):
1751         (-[DOMNode addEventListener:::]): call the new method
1752         (-[DOMNode removeEventListener:listener:useCapture:]):
1753         (-[DOMNode removeEventListener:::]): call the new method
1754         * bindings/objc/DOMAbstractView.h:
1755         * bindings/objc/DOMEventTarget.h:
1756         * bindings/objc/DOMHTMLAppletElement.h:
1757         * bindings/objc/DOMHTMLEmbedElement.h:
1758         * bindings/objc/DOMHTMLOptionElement.h:
1759         * bindings/objc/DOMObject.h:
1760         * bindings/objc/DOMRGBColor.h:
1761
1762 2006-09-22  Nikolas Zimmermann  <zimmermann@kde.org>
1763
1764         Reviewed by Eric.
1765
1766         Fix Qt/Linux build and a really stupid mixup in GraphicsContextQt.
1767
1768         * platform/qt/FrameQt.cpp:
1769         * platform/qt/GraphicsContextQt.cpp:
1770         (WebCore::GraphicsContext::translate): Make it actually translate, not scale! :-)
1771         (WebCore::GraphicsContext::origin):
1772         * platform/qt/PlatformScrollBar.h: Added.
1773         (WebCore::PlatformScrollBar::isWidget):
1774         * platform/qt/WidgetQt.cpp:
1775         (WebCore::Widget::invalidate):
1776         (WebCore::Widget::invalidateRect):
1777
1778 2006-09-22  Dave Hyatt <hyatt@apple.com>
1779
1780         Super-minor tweaks to the systemFont function on Mac.
1781         Set the generic family to None rather than to Serif, and
1782         don't waste time setting the computed size, since that is
1783         set from the specified size over in CSSStyleSelector anyway.
1784
1785         * rendering/RenderThemeMac.mm:
1786         (WebCore::RenderThemeMac::systemFont):
1787
1788 2006-09-22  Timothy Hatcher  <timothy@apple.com>
1789
1790         Reviewed by Brady.
1791
1792         Build fix for Xcode 2.3. Convert GraphicsContext::translate() to
1793         take floats. There was already an implicit conversion to float/double
1794         when calling CGContextTranslateCTM or cairo_translate.
1795
1796         * platform/GraphicsContext.h:
1797         * platform/cairo/GraphicsContextCairo.cpp:
1798         (WebCore::GraphicsContext::translate):
1799         * platform/cg/GraphicsContextCG.cpp:
1800         (WebCore::GraphicsContext::translate):
1801
1802 2006-09-22  Brady Eidson  <beidson@apple.com>
1803
1804         Reviewed by Sfalken
1805
1806         Add redirect and other cleanup to ResourceLoaderWin.cpp
1807         Fixes bug http://bugs.webkit.org/show_bug.cgi?id=10927
1808         Fixes bug http://bugs.webkit.org/show_bug.cgi?id=10744
1809
1810         * WebCore.xcodeproj/project.pbxproj:
1811         * platform/ResourceLoader.h:
1812         * platform/win/ResourceLoaderWin.cpp:
1813         (WebCore::ResourceLoaderWndProc):
1814         (WebCore::initializeOffScreenResourceLoaderWindow):
1815         (WebCore::ResourceLoader::onHandleCreated):
1816         (WebCore::ResourceLoader::onRequestRedirected):
1817         (WebCore::ResourceLoader::onRequestComplete):
1818         (WebCore::transferJobStatusCallback):
1819
1820 2006-09-22  Alexey Proskuryakov  <ap@nypop.com>
1821
1822         Reviewed by Geoff.
1823
1824         http://bugs.webkit.org/show_bug.cgi?id=10803
1825         REGRESSION (r15536-r15544): manual-tests/bugzilla-6821.html failing
1826
1827         * page/FrameView.cpp:
1828         (WebCore::FrameView::hoverTimerFired): Use the current event.
1829
1830 2006-09-22  Nikolas Zimmermann  <zimmermann@kde.org>
1831
1832         Reviewed by Anders.
1833
1834         Fix (last) svg memory leak.
1835
1836         * ksvg2/svg/SVGTransformable.cpp: delete 't' in error case.
1837         (SVGTransformable::parseTransformAttribute):
1838
1839 2006-09-22  Eric Seidel  <eric@eseidel.com>
1840
1841         No review necessary, just removing a dead file.
1842
1843         Remove unused file (added previously by mistake) to make room for real implementation.
1844
1845         * platform/mac/BitmapImageMac.mm: Removed.
1846
1847 2006-09-22  Dave Hyatt <hyatt@apple.com>
1848
1849         Move PlatformScrollBar.h down into the platforms.
1850
1851         Reviewed by andersca
1852
1853         * platform/PlatformScrollBar.h: Removed.
1854         * platform/win/PlatformScrollBar.h: Added.
1855         * platform/mac/PlatformScrollBar.h: Added.
1856
1857 2006-09-22   Dave Hyatt  <hyatt@apple.com>
1858
1859         Add support for invalidation of widgets.  This will be needed for the Win32 widget subsystem (and for
1860         any widget subsystems that don't have any underlying native objects backing the widgets.
1861
1862         Reviewed by anders
1863
1864         * platform/Widget.h:
1865         * platform/mac/WidgetMac.mm:
1866         (WebCore::Widget::invalidate):
1867         (WebCore::Widget::invalidateRect):
1868         * platform/win/TemporaryLinkStubs.cpp:
1869         (Widget::invalidate):
1870         (Widget::invalidateRect):
1871
1872 2006-09-22  Rob Buis  <buis@kd.org>
1873
1874         Reviewed by eseidel.
1875
1876         http://bugs.webkit.org/show_bug.cgi?id=10901
1877         Merge build fixes from unity
1878
1879         * CMakeLists.txt:
1880
1881 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
1882
1883         Reviewed by eseidel.
1884
1885         http://bugs.webkit.org/show_bug.cgi?id=10977
1886         SVGDocument does not expose 'rootElement' property
1887
1888         Enable 'rootElement' property.
1889
1890         * ksvg2/svg/SVGDocument.idl:
1891
1892 2006-09-21  Steve Falkenburg  <sfalken@apple.com>
1893
1894         Tweak includes.
1895
1896         * platform/ResourceLoaderInternal.h:
1897
1898 2006-09-21  Geoffrey Garen  <ggaren@apple.com>
1899
1900         build fixed. band happy.
1901
1902         * platform/cg/GraphicsContextCG.cpp:
1903         (WebCore::GraphicsContext::translate):
1904         * platform/mac/WidgetMac.mm:
1905
1906 2006-09-21  Geoffrey Garen  <ggaren@apple.com>
1907
1908         Reviewed by Maciej.
1909
1910         Some Widget refactoring.
1911
1912         * WebCore.vcproj/WebCore/WebCore.vcproj:
1913         * bridge/mac/FrameMac.mm:
1914         * bridge/win/FrameWin.cpp:
1915         (WebCore::FrameWin::runJavaScriptAlert):
1916         (WebCore::FrameWin::runJavaScriptConfirm):
1917         * bridge/win/PageWin.cpp:
1918         (WebCore::Page::Page):
1919         (WebCore::rootWindowForFrame):
1920         * html/CanvasRenderingContext2D.cpp:
1921         (WebCore::CanvasRenderingContext2D::translate):
1922         * page/FrameView.cpp:
1923         (WebCore::FrameView::isFrameView):
1924         * page/Page.h:
1925         (WebCore::Page::setInstanceHandle):
1926         (WebCore::Page::instanceHandle):
1927         * platform/GraphicsContext.h:
1928         * platform/ScrollView.h:
1929         * platform/Widget.h:
1930         * platform/cairo/GraphicsContextCairo.cpp:
1931         (WebCore::GraphicsContext::translate):
1932         (WebCore::GraphicsContext::origin):
1933         * platform/mac/WidgetMac.mm:
1934         (WebCore::Widget::clearFocus):
1935         * platform/win/ResourceLoaderWin.cpp:
1936         (WebCore::initializeOffScreenResourceLoaderWindow):
1937         * platform/win/ScreenWin.cpp:
1938         (WebCore::monitorInfo):
1939         * platform/win/ScrollViewWin.cpp:
1940         (WebCore::ScrollView::updateContents):
1941         (WebCore::ScrollView::visibleWidth):
1942         (WebCore::ScrollView::visibleHeight):
1943         (WebCore::ScrollView::visibleContentRect):
1944         (WebCore::ScrollView::viewportToContents):
1945         (WebCore::ScrollView::contentsToViewport):
1946         (WebCore::ScrollView::scrollBy):
1947         (WebCore::ScrollView::updateScrollInfo):
1948         (WebCore::ScrollView::updateScrollBars):
1949         * platform/win/SharedTimerWin.cpp:
1950         (WebCore::initializeOffScreenTimerWindow):
1951         * platform/win/TemporaryLinkStubs.cpp:
1952         (FrameView::updateBorder):
1953         (ScrollView::paint):
1954         (GraphicsContext::clip):
1955         * platform/win/WidgetWin.cpp:
1956         (WebCore::Widget::Widget):
1957         (WebCore::Widget::parentWindow):
1958         (WebCore::Widget::setParentWindow):
1959         (WebCore::Widget::frameGeometry):
1960         (WebCore::Widget::hasFocus):
1961         (WebCore::Widget::setFocus):
1962         (WebCore::Widget::show):
1963         (WebCore::Widget::hide):
1964         (WebCore::Widget::setFrameGeometry):
1965
1966 2006-09-22  Anders Carlsson  <acarlsson@apple.com>
1967
1968         Reviewed by Tim H.
1969
1970         * platform/TextEncoding.cpp:
1971         (WebCore::TextEncoding::backslashAsCurrencySymbol):
1972         Add comment clarifying why backslashAsCurrencySymbol is needed.
1973
1974 2006-09-21  Sean Gies  <seangies@apple.com>
1975
1976         Reviewed by Adam Roben.
1977
1978         Add utility functions to get and release HDC from GraphicsContext.
1979
1980         * platform/GraphicsContext.h: Add utilities to get and release HDC.
1981         * platform/cairo/GraphicsContextCairo.cpp: Implement new utilities.
1982         * rendering/RenderThemeWin.cpp: Switch to new utilities.
1983
1984 2006-09-21  Justin Garcia  <justin.garcia@apple.com>
1985
1986         Reviewed by anders
1987
1988         <rdar://problem/4426622>
1989         Plain text paste slow.  Time spent mostly in WebCore::rebalanceWhitespaceInTextNode(...)
1990
1991         * editing/htmlediting.cpp:
1992         (WebCore::rebalanceWhitespaceInTextNode): We no longer need to use a RegExp replace because we
1993         aren't producing complicated sequences here.  Use multiple UChar -> UChar replaces instead for speed.
1994         Got rid of uses of DepricatedString.
1995
1996 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
1997
1998         Reviewed by eseidel.
1999
2000         Don't crash if no IconDatabase is available (ie. on Qt/Gdk)
2001
2002         * page/Frame.cpp:
2003         (WebCore::Frame::endIfNotLoading):
2004
2005 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
2006
2007         Reviewed by eseidel.
2008
2009         Fix Qt/Linux build.
2010
2011         * CMakeLists.txt:
2012         * kcanvas/device/qt/KCanvasClipperQt.h:
2013         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
2014         * platform/qt/FrameQt.cpp:
2015         (WebCore::FrameQt::isLoadTypeReload):
2016         (WebCore::FrameQt::originalRequestURL):
2017         * platform/qt/FrameQt.h:
2018         * platform/qt/GraphicsContextQt.cpp:
2019         (WebCore::GraphicsContext::concatCTM):
2020         * platform/qt/ScrollViewQt.cpp:
2021         (WebCore::ScrollView::wheelEvent):
2022         * platform/qt/TemporaryLinkStubs.cpp:
2023         (WebCore::IconDatabase::setIconURLForPageURL):
2024
2025 2006-09-20  Justin Garcia  <justin.garcia@apple.com>
2026
2027         Reviewed by john
2028
2029         <http://bugs.webkit.org/show_bug.cgi?id=7165>
2030         TinyMCE: Dragging & dropping content always leaves a copy when editing inside a subframe
2031
2032         * editing/MoveSelectionCommand.cpp:
2033         (WebCore::MoveSelectionCommand::MoveSelectionCommand): Set the document
2034         to the position-to-move-to's document, not the fragment's document.  The
2035         fragment's document is the document used to create the fragment and is irrelavant.
2036
2037 === Safari-521.27 ===
2038
2039 2006-09-21  Brady Eidson  <beidson@apple.com>
2040
2041         Reviewed by Anders
2042
2043         When your assumption is "IconDatabase::sharedIconDatabase()" will never fail but it does, you're in trouble
2044         This fixes Spinneret so it won't crash on its first load!
2045
2046         * page/Frame.cpp:
2047         (WebCore::Frame::endIfNotLoading):
2048
2049 2006-09-21  Brady Eidson  <beidson@apple.com>
2050
2051         Build fix
2052
2053         * platform/win/TemporaryLinkStubs.cpp:
2054         (ScrollView::wheelEvent):
2055
2056 2006-09-20  Rob Buis  <buis@kde.org>
2057
2058         Reviewed by eseidel.
2059
2060         http://bugs.webkit.org/show_bug.cgi?id=10946
2061         new marker code draws end-marker in wrong place
2062
2063         Keep track of the start of the subpath so we can handle
2064         closeTo/moveTo correctly.
2065
2066         * kcanvas/RenderPath.cpp:
2067         (WebCore::DrawMarkersData::DrawMarkersData):
2068         (WebCore::updateMarkerDataForElement):
2069
2070 2006-09-21  David Hyatt <hyatt@apple.com>
2071
2072         Wheel scrolling prep for Win32.
2073
2074         WARNING: NO TEST CASES ADDED OR CHANGED
2075
2076         * platform/PlatformWheelEvent.h:
2077         * platform/ScrollBar.h:
2078         * platform/ScrollView.h:
2079         * platform/mac/ScrollViewMac.mm:
2080         (WebCore::ScrollView::wheelEvent):
2081         * rendering/RenderLayer.cpp:
2082
2083 2006-09-20  Timothy Hatcher  <timothy@apple.com>
2084
2085         Reviewed by Hyatt.
2086
2087         Bug 10917: REGRESSION (r16027): iFrame transparency broken
2088         http://bugs.webkit.org/show_bug.cgi?id=10917
2089
2090         Don't paint the base background color if we transparent.
2091
2092         * rendering/RenderBox.cpp:
2093         (WebCore::RenderBox::paintBackgroundExtended):
2094
2095 2006-09-20  Adam Roben  <aroben@apple.com>
2096
2097         Reviewed by andersca.
2098
2099         * platform/FileChooser.h: Remove no-longer-necessary namespace std
2100
2101 2006-09-20  Eric Seidel  <eric@eseidel.com>
2102
2103         Reviewed by beth.
2104
2105         Cleanup style in KCanvas.
2106         Remove extra white-space, unneeded arguments, etc.
2107
2108         * WebCore.xcodeproj/project.pbxproj:
2109         * kcanvas/KCanvasClipper.cpp:
2110         (WebCore::operator<<):
2111         (WebCore::KCanvasClipper::externalRepresentation):
2112         * kcanvas/KCanvasClipper.h:
2113         * kcanvas/KCanvasFilters.cpp:
2114         (WebCore::KCanvasFilter::externalRepresentation):
2115         (WebCore::operator<<):
2116         (WebCore::KCanvasFilterEffect::externalRepresentation):
2117         (WebCore::KCPointLightSource::externalRepresentation):
2118         (WebCore::KCSpotLightSource::externalRepresentation):
2119         (WebCore::KCDistantLightSource::externalRepresentation):
2120         (WebCore::KCanvasFEBlend::externalRepresentation):
2121         (WebCore::KCanvasFEColorMatrix::externalRepresentation):
2122         (WebCore::KCanvasFEComponentTransfer::externalRepresentation):
2123         (WebCore::KCanvasFEComposite::externalRepresentation):
2124         (WebCore::KCanvasFEConvolveMatrix::externalRepresentation):
2125         (WebCore::KCanvasFEDiffuseLighting::externalRepresentation):
2126         (WebCore::KCanvasFEDisplacementMap::externalRepresentation):
2127         (WebCore::KCanvasFEFlood::externalRepresentation):
2128         (WebCore::KCanvasFEGaussianBlur::externalRepresentation):
2129         (WebCore::KCanvasFEImage::externalRepresentation):
2130         (WebCore::KCanvasFEMerge::externalRepresentation):
2131         (WebCore::KCanvasFEMorphology::externalRepresentation):
2132         (WebCore::KCanvasFEOffset::externalRepresentation):
2133         (WebCore::KCanvasFESpecularLighting::externalRepresentation):
2134         (WebCore::KCanvasFETile::externalRepresentation):
2135         (WebCore::KCanvasFETurbulence::externalRepresentation):
2136         * kcanvas/KCanvasFilters.h:
2137         (WebCore::KCanvasFEDiffuseLighting::lightSource):
2138         (WebCore::KCanvasFESpecularLighting::lightSource):
2139         * kcanvas/KCanvasImage.h:
2140         * kcanvas/KCanvasMarker.cpp:
2141         (WebCore::KCanvasMarker::externalRepresentation):
2142         * kcanvas/KCanvasMarker.h:
2143         * kcanvas/KCanvasResource.cpp:
2144         (WebCore::operator<<):
2145         * kcanvas/KCanvasResource.h:
2146         * kcanvas/KCanvasTreeDebug.cpp:
2147         (WebCore::operator<<):
2148         (WebCore::writeIndent):
2149         (WebCore::writeStyle):
2150         (WebCore::write):
2151         (WebCore::writeRenderResources):
2152         * kcanvas/KCanvasTreeDebug.h:
2153         (WebCore::operator<<):
2154         * kcanvas/RenderForeignObject.cpp:
2155         (WebCore::RenderForeignObject::paint):
2156         * kcanvas/RenderPath.cpp:
2157         (WebCore::RenderPath::paint):
2158         (WebCore::drawStartAndMidMarkers):
2159         * kcanvas/RenderSVGContainer.cpp:
2160         (WebCore::RenderSVGContainer::paint):
2161         * kcanvas/RenderSVGImage.cpp:
2162         (WebCore::RenderSVGImage::translateForAttributes):
2163         * kcanvas/RenderSVGImage.h:
2164         * kcanvas/device/KRenderingDevice.cpp:
2165         (WebCore::KRenderingDevice::currentContext):
2166         (WebCore::KRenderingDevice::popContext):
2167         (WebCore::KRenderingDevice::pushContext):
2168         * kcanvas/device/KRenderingDevice.h:
2169         * kcanvas/device/KRenderingFillPainter.h:
2170         * kcanvas/device/KRenderingPaintServer.h:
2171         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
2172         (WebCore::KRenderingPaintServer::activeClient):
2173         (WebCore::KRenderingPaintServer::setActiveClient):
2174         * kcanvas/device/KRenderingPaintServerGradient.cpp:
2175         (WebCore::operator<<):
2176         (WebCore::KRenderingPaintServerGradient::externalRepresentation):
2177         (WebCore::KRenderingPaintServerLinearGradient::externalRepresentation):
2178         (WebCore::KRenderingPaintServerGradient::listener):
2179         (WebCore::KRenderingPaintServerGradient::setListener):
2180         (WebCore::KRenderingPaintServerRadialGradient::externalRepresentation):
2181         * kcanvas/device/KRenderingPaintServerGradient.h:
2182         * kcanvas/device/KRenderingPaintServerPattern.cpp:
2183         (WebCore::KRenderingPaintServerPattern::tile):
2184         (WebCore::KRenderingPaintServerPattern::setTile):
2185         (WebCore::KRenderingPaintServerPattern::listener):
2186         (WebCore::KRenderingPaintServerPattern::setListener):
2187         (WebCore::KRenderingPaintServerPattern::externalRepresentation):
2188         * kcanvas/device/KRenderingPaintServerPattern.h:
2189         * kcanvas/device/KRenderingPaintServerSolid.cpp:
2190         (WebCore::KRenderingPaintServerSolid::externalRepresentation):
2191         * kcanvas/device/KRenderingPaintServerSolid.h:
2192         * kcanvas/device/KRenderingStrokePainter.cpp:
2193         (WebCore::KRenderingStrokePainter::strokeMiterLimit):
2194         (WebCore::KRenderingStrokePainter::setStrokeMiterLimit):
2195         * kcanvas/device/KRenderingStrokePainter.h:
2196         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
2197         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
2198         (WebCore::KCanvasFilterQuartz::prepareFilter):
2199         * kcanvas/device/quartz/KCanvasItemQuartz.h: Removed.
2200         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
2201         (WebCore::KCanvasMaskerQuartz::applyMask):
2202         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
2203         (WebCore::KCanvasImageQuartz::init):
2204         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
2205         (WebCore::KCanvasClipperQuartz::applyClip):
2206         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
2207         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
2208         (WebCore::KRenderingDeviceQuartz::quartzContext):
2209         (WebCore::KRenderingDeviceQuartz::contextForImage):
2210         (WebCore::KRenderingDeviceQuartz::createPaintServer):
2211         (WebCore::KRenderingDeviceQuartz::createResource):
2212         (WebCore::KRenderingDeviceQuartz::createFilterEffect):
2213         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
2214         (WebCore::CGShadingRefForLinearGradient):
2215         (WebCore::CGShadingRefForRadialGradient):
2216         (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
2217         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
2218         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
2219         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
2220         (WebCore::KRenderingPaintServerQuartzHelper::strokePath):
2221         (WebCore::KRenderingPaintServerQuartzHelper::clipToStrokePath):
2222         (WebCore::KRenderingPaintServerQuartzHelper::fillPath):
2223         (WebCore::KRenderingPaintServerQuartzHelper::clipToFillPath):
2224         (WebCore::KRenderingPaintServerSolidQuartz::draw):
2225         (WebCore::KRenderingPaintServerSolidQuartz::setup):
2226         (WebCore::KRenderingPaintServerSolidQuartz::renderPath):
2227         (WebCore::KRenderingPaintServerPatternQuartz::setup):
2228         (WebCore::KRenderingPaintServerPatternQuartz::renderPath):
2229         (WebCore::KRenderingPaintServerPatternQuartz::teardown):
2230         * kcanvas/device/quartz/QuartzSupport.h:
2231         * kcanvas/device/quartz/QuartzSupport.mm:
2232         (WebCore::applyStrokeStyleToContext):
2233
2234 2006-09-20  Anders Carlsson  <acarlsson@apple.com>
2235
2236         Reviewed by Dave Hyatt.
2237
2238         * dom/WheelEvent.cpp:
2239         (WebCore::WheelEvent::WheelEvent):
2240         Use lroundf instead of lround since deltas are floats.
2241
2242 2006-09-20  Julien Palmas  <julien.palmas@gmail.com>
2243
2244         Reviewed by eseidel.  Landed by eseidel.
2245
2246         Test: svg/custom/pattern-y-offset.svg
2247
2248         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
2249         (WebCore::KRenderingPaintServerPatternQuartz::setup):
2250
2251 2006-09-20  David Hyatt  <hyatt@apple.com>
2252
2253         Add a new wheelEvent method to ScrollView.  Platforms that wish
2254         to handle the wheel event for the scroll view themselves can then
2255         do so there.  (Mac lets the underlying NSScrollView do it for now.)
2256
2257         * page/FrameView.cpp:
2258         (WebCore::FrameView::handleWheelEvent):
2259         * platform/ScrollView.h:
2260         (WebCore::ScrollView::wheelEvent):
2261
2262 2006-09-20  Brady Eidson  <beidson@apple.com>
2263
2264         Reviewed by Tim Omernick
2265
2266         Part of fixing a crash Tim O showed me that I missed in a release build.
2267         WebKit should be able to call through the bridge to WebCore no matter what -
2268         Replace the _iconDB member with calls to IconDatabase::sharedIconDatabase()
2269
2270         * bridge/mac/WebCoreIconDatabaseBridge.h:
2271         * bridge/mac/WebCoreIconDatabaseBridge.mm:
2272         (-[WebCoreIconDatabaseBridge closeSharedDatabase]):
2273         (-[WebCoreIconDatabaseBridge isOpen]):
2274         (-[WebCoreIconDatabaseBridge removeAllIcons]):
2275         (-[WebCoreIconDatabaseBridge _isEmpty]):
2276         (-[WebCoreIconDatabaseBridge isIconExpiredForIconURL:]):
2277         (-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]):
2278         (-[WebCoreIconDatabaseBridge privateBrowsingEnabled]):
2279         (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]):
2280         (-[WebCoreIconDatabaseBridge iconURLForPageURL:]):
2281         (-[WebCoreIconDatabaseBridge defaultIconWithSize:]):
2282         (-[WebCoreIconDatabaseBridge retainIconForURL:]):
2283         (-[WebCoreIconDatabaseBridge releaseIconForURL:]):
2284         (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]):
2285         (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]):
2286         (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]):
2287         (-[WebCoreIconDatabaseBridge _hasEntryForIconURL:]):
2288         (-[WebCoreIconDatabaseBridge _setEnabled:]):
2289         (-[WebCoreIconDatabaseBridge _isEnabled]):
2290
2291 2006-09-20  Anders Carlsson  <acarlsson@apple.com>
2292
2293         Reviewed by Darin.
2294
2295         Add String::split which returns a Vector of Strings and use it instead of
2296         DeprecatedStringList.
2297
2298         * bindings/js/kjs_events.cpp:
2299         (KJS::Clipboard::getValueProperty):
2300         * bindings/js/kjs_window.cpp:
2301         (KJS::parseModalDialogFeatures):
2302         * css/MediaList.cpp:
2303         (WebCore::MediaList::setMediaText):
2304         * dom/Clipboard.h:
2305         * html/HTMLFormElement.cpp:
2306         (WebCore::HTMLFormElement::formData):
2307         * html/HTMLLinkElement.cpp:
2308         (WebCore::HTMLLinkElement::tokenizeRelAttribute):
2309         * platform/PlatformString.h:
2310         * platform/String.cpp:
2311         (WebCore::String::split):
2312         * platform/StringImpl.cpp:
2313         * platform/StringImpl.h:
2314         * platform/mac/ClipboardMac.h:
2315         * platform/mac/ClipboardMac.mm:
2316         (WebCore::ClipboardMac::types):
2317
2318 2006-09-20  Justin Garcia  <justin.garcia@apple.com>
2319
2320         Reviewed by harrison
2321
2322         * css/cssstyleselector.cpp:
2323         (WebCore::CSSStyleSelector::adjustRenderStyle): Don't call
2324         HTMLElement::isContentEditable just to check the Frame's editability, since
2325         it calls updateRenderering, which can get us into infinite recursion.
2326
2327 2006-09-20  Brady Eidson  <beidson@apple.com>
2328
2329         Reviewed by Darin
2330
2331         Cleaned up my last patch alot, and made the WebCore icon database disabled by default
2332
2333         * loader/icon/IconDatabase.cpp:
2334         (WebCore::IconDatabase::IconDatabase): Disabled by default
2335         (WebCore::IconDatabase::removeAllIcons): Respect just isOpen() (disabled database will always be closed)
2336         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ditto
2337         (WebCore::IconDatabase::iconForPageURL): Ditto
2338         (WebCore::IconDatabase::isIconExpiredForIconURL): Ditto
2339         (WebCore::IconDatabase::iconURLForPageURL): Ditto
2340         (WebCore::IconDatabase::retainIconForPageURL): Ditto
2341         (WebCore::IconDatabase::releaseIconForPageURL): Ditto
2342         (WebCore::IconDatabase::setIconDataForIconURL): Ditto
2343         (WebCore::IconDatabase::setIconURLForPageURL): Ditto
2344         (WebCore::IconDatabase::hasEntryForIconURL): Ditto
2345         (WebCore::IconDatabase::setEnabled): Fixed a big bug here!
2346
2347 2006-09-20  Adam Roben  <aroben@apple.com>
2348
2349         Reviewed by Adele.
2350
2351         Fixes http://bugs.webkit.org/show_bug.cgi?id=10935
2352         REGRESSION: file upload control with direction:rtl or text-align:right
2353         draws button on top of filename/icon
2354
2355         * rendering/RenderFileUploadControl.cpp:
2356         (WebCore::RenderFileUploadControl::setStyle): Force text-align to
2357         match direction
2358         (WebCore::RenderFileUploadControl::paintObject): Fix positioning of
2359         the filename and icon in RTL
2360
2361 2006-09-20  Alice Liu  <alice.liu@apple.com>
2362
2363         Reviewed by Adam Roben.
2364
2365         fixed windows build
2366
2367         * dom/WheelEvent.cpp:
2368         (WebCore::WheelEvent::WheelEvent):
2369         changed lrint to lround
2370
2371 2006-09-20  Sam Weinig  <sam.weinig@gmail.com>
2372
2373         Build Fix.  Adds isHorizontal attribute back to WheelEvent
2374         for the Objective-C bindings.  If it is found that isHorizontal
2375         is not used, we should remove it again but also remove it's
2376         declaration from PublicDOMInterfaces.h
2377
2378         * dom/WheelEvent.h:
2379         (WebCore::WheelEvent::isHorizontal):
2380         * dom/WheelEvent.idl:
2381
2382 2006-09-20  David Hyatt  <hyatt@apple.com>
2383
2384         Fix for 10945, WheelEvent should support two dimensions at once, since
2385         MacBooks allow for diagonal scrolling.  Also enhance the PlatformWheelEvent
2386         to allow for diagonal scrolling.
2387
2388         Reviewed by Eric
2389
2390         * dom/EventTargetNode.cpp:
2391         (WebCore::EventTargetNode::dispatchWheelEvent):
2392         * dom/WheelEvent.cpp:
2393         (WebCore::WheelEvent::WheelEvent):
2394         (WebCore::WheelEvent::initWheelEvent):
2395         * dom/WheelEvent.h:
2396         (WebCore::WheelEvent::wheelDelta):
2397         (WebCore::WheelEvent::wheelDeltaX):
2398         (WebCore::WheelEvent::wheelDeltaY):
2399         * dom/WheelEvent.idl:
2400         * page/FrameView.cpp:
2401         (WebCore::FrameView::handleWheelEvent):
2402         * platform/PlatformWheelEvent.h:
2403         (WebCore::PlatformWheelEvent::deltaX):
2404         (WebCore::PlatformWheelEvent::deltaY):
2405         (WebCore::PlatformWheelEvent::normalize):
2406         * platform/mac/WheelEventMac.mm:
2407         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2408
2409 2006-09-19  Eric Seidel  <eric@eseidel.com>
2410
2411         Reviewed by hyatt.
2412
2413         Split KCanvasResources.* into multiple files (and some other minor spacing changes).
2414
2415         No tests were harmed in the making of this patch.
2416
2417         * WebCore.xcodeproj/project.pbxproj:
2418         * kcanvas/KCanvasClipper.cpp: Added.
2419         (WebCore::operator<<):
2420         * kcanvas/KCanvasClipper.h: Added.
2421         * kcanvas/KCanvasFilters.h:
2422         * kcanvas/KCanvasImage.h:
2423         * kcanvas/KCanvasMarker.cpp: Added.
2424         * kcanvas/KCanvasMarker.h: Added.
2425         * kcanvas/KCanvasMasker.cpp: Added.
2426         (WebCore::KCanvasMasker::KCanvasMasker):
2427         (WebCore::KCanvasMasker::setMask):
2428         (WebCore::KCanvasMasker::externalRepresentation):
2429         (WebCore::getMaskerById):
2430         * kcanvas/KCanvasMasker.h: Added.
2431         * kcanvas/KCanvasResource.cpp: Added.
2432         (WebCore::KCanvasResource::invalidate):
2433         (WebCore::KCanvasResource::externalRepresentation):
2434         (WebCore::getResourceById):
2435         (WebCore::getPaintServerById):
2436         * kcanvas/KCanvasResource.h: Added.
2437         * kcanvas/KCanvasResources.cpp: Removed.
2438         * kcanvas/KCanvasResources.h: Removed.
2439         * kcanvas/RenderPath.cpp:
2440         * kcanvas/RenderSVGContainer.cpp:
2441         * kcanvas/RenderSVGImage.cpp:
2442         * kcanvas/RenderSVGText.cpp:
2443         * kcanvas/device/KRenderingPaintServer.h:
2444         * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
2445         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
2446         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
2447         * ksvg2/svg/SVGClipPathElement.h:
2448         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
2449         * ksvg2/svg/SVGFEComponentTransferElement.cpp:
2450         * ksvg2/svg/SVGFECompositeElement.cpp:
2451         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
2452         * ksvg2/svg/SVGFELightElement.cpp:
2453         * ksvg2/svg/SVGFEOffsetElement.cpp:
2454         * ksvg2/svg/SVGFETurbulenceElement.cpp:
2455         * ksvg2/svg/SVGFilterElement.cpp:
2456         * ksvg2/svg/SVGLinearGradientElement.cpp:
2457         * ksvg2/svg/SVGMarkerElement.h:
2458         * ksvg2/svg/SVGMaskElement.h:
2459
2460 2006-09-19  Brady Eidson <beidson@apple.com>
2461
2462         Reviewed by Sarge Decker
2463
2464         <rdar://problem/4739892> and <rdar://problem/4729797>
2465         - WebCore::IconDatabase needs to have and respect an enabled() flag
2466         - Mail on ToT WebKit crashes in IconDatabase code when mailing a page from Safari
2467
2468         * bridge/mac/WebCoreIconDatabaseBridge.h:
2469         * bridge/mac/WebCoreIconDatabaseBridge.mm:
2470         (-[WebCoreIconDatabaseBridge _setEnabled:]): Added
2471         (-[WebCoreIconDatabaseBridge _isEnabled]): Added
2472         * loader/icon/IconDatabase.cpp:
2473         (WebCore::IconDatabase::IconDatabase):
2474         (WebCore::IconDatabase::open): Don't open if disabled
2475         (WebCore::IconDatabase::removeAllIcons): Ignore if disabled/closed
2476         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ignore if disabled/closed
2477         (WebCore::IconDatabase::iconForPageURL): Default Icon if disabled/closed
2478         (WebCore::IconDatabase::isIconExpiredForIconURL): Default return if disabled/closed
2479         (WebCore::IconDatabase::iconURLForPageURL): Default return if disabled/closed
2480         (WebCore::IconDatabase::retainIconForPageURL): Ignore if disabled/closed
2481         (WebCore::IconDatabase::releaseIconForPageURL): Ignore if disabled/closed
2482         (WebCore::IconDatabase::releaseIconURL):
2483         (WebCore::IconDatabase::setIconDataForIconURL): Ignore if disabled/closed
2484         (WebCore::IconDatabase::setIconURLForPageURL): Ignore if disabled/closed
2485         (WebCore::IconDatabase::hasEntryForIconURL): Default return if disabled/closed
2486         (WebCore::IconDatabase::setEnabled): Added
2487         * loader/icon/IconDatabase.h:
2488         (WebCore::IconDatabase::enabled): Added
2489         * page/Frame.cpp:
2490         (WebCore::Frame::endIfNotLoading): do an IconDatabase::enabled() check before bothering to load the icon
2491         * platform/mac/ResourceLoaderMac.mm: Removed extraneous #include
2492
2493 2006-09-20  David Hyatt  <hyatt@apple.com>
2494
2495         Massage mouse wheel handling so that it is more cross-platform.  Make
2496         all the work happen in handleWheelEvent on the FrameView.
2497
2498         Reviewed by bradee-oh
2499
2500         * bridge/mac/FrameMac.mm:
2501         (WebCore::FrameMac::wheelEvent):
2502         * page/FrameView.cpp:
2503         (WebCore::FrameView::handleWheelEvent):
2504         * platform/PlatformWheelEvent.h:
2505         (WebCore::PlatformWheelEvent::platformDelta):
2506         (WebCore::PlatformWheelEvent::delta):
2507         * platform/mac/WheelEventMac.mm:
2508         (WebCore::platformDeltaForEvent):
2509         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
2510         * rendering/RenderLayer.cpp:
2511         (WebCore::RenderLayer::scroll):
2512         * rendering/RenderObject.cpp:
2513         (WebCore::RenderObject::scroll):
2514
2515 2006-09-19  Eric Seidel  <eric@eseidel.com>
2516
2517         Reviewed by adele.
2518
2519         Improve test output for filters with bounding-box relative sizes.
2520         http://bugs.webkit.org/show_bug.cgi?id=8585
2521
2522         Many test results updated.
2523
2524         * kcanvas/KCanvasFilters.cpp:
2525         (WebCore::KCanvasFilter::externalRepresentation):
2526
2527 2006-09-19  Eric Seidel  <eric@eseidel.com>
2528
2529         Reviewed by adele.
2530
2531         Markers should clip to their viewport.
2532         http://bugs.webkit.org/show_bug.cgi?id=5967
2533
2534         Test: svg/custom/marker-overflow-clip.svg
2535
2536         * kcanvas/KCanvasResources.cpp:
2537         (WebCore::KCanvasMarker::KCanvasMarker):
2538         (WebCore::KCanvasMarker::setMarker):
2539         (WebCore::KCanvasMarker::draw):
2540         * kcanvas/KCanvasResources.h:
2541         (WebCore::KCanvasMasker::mask):
2542         * ksvg2/svg/SVGMarkerElement.cpp:
2543         (WebCore::SVGMarkerElement::SVGMarkerElement):
2544         (WebCore::SVGMarkerElement::parseMappedAttribute):
2545         (WebCore::SVGMarkerElement::canvasResource):
2546         (WebCore::SVGMarkerElement::createRenderer):
2547
2548 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
2549
2550         Reviewed by eseidel
2551
2552         Backing out my recent change.
2553
2554         * css/cssstyleselector.cpp:
2555         (WebCore::CSSStyleSelector::adjustRenderStyle):
2556
2557 2006-09-19  Brady Eidson  <beidson@apple.com>
2558
2559         Reviewed by Kevin McCullough
2560
2561         http://bugs.webkit.org/show_bug.cgi?id=10940
2562         Opening a PDF in a new tab/window creates a documentless-frame
2563         and we deref the document without checking its validity
2564
2565         * page/Frame.cpp:
2566         (WebCore::Frame::iconURL):
2567
2568 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
2569
2570         Reviewed by harrison
2571
2572         <rdar://problem/4735272>
2573         Can not click into link in programmatically editable content
2574
2575         * css/cssstyleselector.cpp:
2576         (WebCore::CSSStyleSelector::adjustRenderStyle): We stopped using
2577         userModify to implement document wide editability.
2578
2579 2006-09-19  MorganL  <morlmor@yahoo.com>
2580
2581         Reviewed by Darin and landed by Brady
2582
2583         Fixes http://bugs.webkit.org/show_bug.cgi?id=10939
2584         Build broken when SVG is not enabled.
2585
2586         * dom/XMLTokenizer.cpp:
2587         (WebCore::XMLTokenizer::startElementNs):
2588
2589 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
2590
2591         Reviewed by harrison
2592
2593         <rdar://problem/4727383> REGRESSION: Pasting plain text with tabs into Blot converts the tabs to single spaces
2594
2595         Pasting plain text results in a match style paste, and the insertion
2596         position is whitespace normal, which clobbers the whitespace:pre on
2597         tab spans.  Skip changes to the whitespace mode when computing a style
2598         change for tab spans or the text nodes inside tab spans.
2599
2600         * editing/ApplyStyleCommand.cpp:
2601         (WebCore::StyleChange::init): Don't change the whitespace mode inside
2602         tab spans.
2603
2604 2006-09-19  David Hyatt  <hyatt@apple.com>
2605
2606         Fix for bug 5298, shape=default not supported for image maps.  Implement
2607         support for it.
2608
2609         Reviewed by timo
2610
2611         * html/HTMLAreaElement.cpp:
2612         (WebCore::HTMLAreaElement::getRegion):
2613         * html/HTMLMapElement.cpp:
2614         (WebCore::HTMLMapElement::mapMouseEvent):
2615
2616 2006-09-19  Adam Roben  <aroben@apple.com>
2617
2618         Reviewed by Adele.
2619
2620         Fixes http://bugs.webkit.org/show_bug.cgi?id=10824
2621         "no file selected" placeholder text missing from file upload control
2622
2623         * WebCore.xcodeproj/project.pbxproj:
2624         * rendering/RenderFileUploadControl.cpp: Remove class
2625         RenderFileUploadInnerFileBox, rename defaultFilenameNumChars to
2626         defaultWidthNumChars
2627         (WebCore::RenderFileUploadControl::RenderFileUploadControl): Call
2628         RenderBlock constructor instead of RenderFlexibleBox,
2629         (WebCore::RenderFileUploadControl::setStyle): Remove references to
2630         m_fileBox.
2631         (WebCore::RenderFileUploadControl::valueChanged): Call repaint()
2632         instead of updateIconAndFileName() (which has been removed)
2633         (WebCore::RenderFileUploadControl::updateFromElement): Remove
2634         references to m_fileBox, don't call updateIconAndFilename()
2635         (WebCore::RenderFileUploadControl::maxFilenameWidth): Calculate width
2636         without using m_fileBox
2637         (WebCore::RenderFileUploadControl::createButtonStyle): Remove
2638         now-unnecessary display:box rule.
2639         (WebCore::RenderFileUploadControl::paintObject): Remove redundant call
2640         to paintingDisabled() now that Icon::paint() does it, and add code to
2641         paint the filename directly.
2642         (WebCore::RenderFileUploadControl::calcMinMaxWidth): Move this method
2643         out of RenderFileUploadInnerFileBox and into RenderFileUploadControl
2644         * rendering/RenderFileUploadControl.h: Make RenderFileUploadControl a
2645         subclass of RenderBlock instead of RenderFlexibleBox, remove
2646         updateIconAndFilename() method, remove m_fileBox instance variable.
2647
2648 2006-09-19  Eric Seidel  <eric@eseidel.com>
2649
2650         Reviewed by hyatt.
2651
2652         Exceptions thrown from <script> tags in XHTML/SVG docs show the wrong line numbers
2653         http://bugs.webkit.org/show_bug.cgi?id=10846
2654
2655         No automated test case possible until http://bugs.webkit.org/show_bug.cgi?id=10905 is resolved.
2656
2657         * dom/XMLTokenizer.cpp:
2658         (WebCore::XMLTokenizer::XMLTokenizer):
2659         (WebCore::XMLTokenizer::startElementNs):
2660         (WebCore::XMLTokenizer::endElementNs):
2661
2662 2006-09-19  Krzysztof Kowalczyk <kkowalczyk@gmail.com>
2663
2664         Reviewed by eseidel.  Landed by eseidel.
2665
2666         Build fix only, no tests affected.
2667
2668         * platform/gdk/FontPlatformDataGdk.cpp:
2669         (WebCore::FontPlatformData::FontPlatformData):
2670         (WebCore::FontPlatformData::~FontPlatformData):
2671         * platform/gdk/FrameGdk.h:
2672         * platform/gdk/TemporaryLinkStubs.cpp:
2673         (FrameGdk::isLoadTypeReload):
2674         (FrameGdk::originalRequestURL):
2675         (IconDatabase::setIconURLForPageURL):
2676
2677 2006-09-19  David Hyatt  <hyatt@apple.com>
2678
2679         Refine the fix for 9805 to really get all the complex cases right.
2680
2681         Reviewed by Eric
2682
2683         * rendering/RenderBlock.cpp:
2684         (WebCore::RenderBlock::clearFloatsIfNeeded):
2685         (WebCore::RenderBlock::handleBottomOfBlock):
2686
2687 2006-09-18  David Hyatt  <hyatt@apple.com>
2688
2689         Fix for 9805, <hr> not positioned properly following a previous empty sibling
2690         that had clear:both set on it.  Update self-collapsing block clearance
2691         behavior to match what is specified in the latest draft of CSS2.1.
2692
2693         Reviewed by Eric
2694
2695         Added fast/block/margin-collapse/empty-clear-blocks.html
2696
2697         * rendering/RenderBlock.cpp:
2698         (WebCore::RenderBlock::clearFloatsIfNeeded):
2699         (WebCore::RenderBlock::handleBottomOfBlock):
2700
2701 2006-09-18  MorganL  <morlmor@yahoo.com>
2702
2703         Reviewed by Brady, landed by Brady
2704
2705         Send receivedResponse callback to ResourceLoaderClient when loading
2706         file URLs.
2707
2708         See http://bugs.webkit.org/show_bug.cgi?id=10845
2709
2710         * platform/win/ResourceLoaderWin.cpp:
2711         (WebCore::ResourceLoader::fileLoadTimer):
2712
2713 2006-09-18  Brady Eidson  <beidson@apple.com>
2714
2715         Reviewed by Anders
2716
2717         <rdar://problem/3028061> - WebKit never updates favicon
2718         The WebKit enforced expiration date for icons has worked for some time, but the
2719         move to the new Icon Loader broke the "always get the icon if the user refreshes the page"
2720         functionality.  This patch fixes that up, along with some other architectural improvements,
2721         the main one being that WebCore::Document now contains an iconURL for the Frame to query if needed.
2722
2723         * bridge/mac/FrameMac.h: Added isLoadTypeReload()
2724         * bridge/mac/FrameMac.mm:
2725         (WebCore::FrameMac::isLoadTypeReload): Implementation, calls into the bridge
2726         * bridge/mac/WebCoreFrameBridge.h: Added isLoadTypeReload:
2727         * bridge/win/FrameWin.h: Added isLoadTypeReload() for temporary link stub
2728         * dom/Document.h: Added m_iconURL
2729         (WebCore::Document::iconURL): Added
2730         (WebCore::Document::setIconURL): Ditto
2731         * html/HTMLLinkElement.cpp:
2732         (WebCore::HTMLLinkElement::process): Sets the iconURL in the Document instead of the Frame
2733         * page/Frame.cpp:
2734         (WebCore::Frame::iconURL): Calculates the iconURL based on the document, then the default favicon.ico url
2735         (WebCore::Frame::endIfNotLoading): Checks for the load type - always loads icon on Reload
2736         * page/Frame.h: Nuked setIconURL(), added isLoadTypeReload()
2737         * page/FramePrivate.h: Nuked IconURL
2738         * platform/win/TemporaryLinkStubs.cpp:
2739         (FrameWin::isLoadTypeReload):
2740
2741 2006-09-18  Sam Weinig  <sam.weinig@gmail.com>
2742
2743         Reviewed by Tim H.
2744
2745         - Re-add private method [DOMRGBColor _color] to DOMPrivate.h as
2746           it is it turns out that AppKit uses it.
2747
2748         * bindings/objc/DOMPrivate.h:
2749         * bindings/objc/DOMRGBColor.mm:
2750         (-[DOMRGBColor _color]):
2751
2752 2006-09-18  Sam Weinig  <sam.weinig@gmail.com>
2753
2754         Reviewed by Tim H.
2755
2756         Patch for http://bugs.webkit.org/show_bug.cgi?id=10903
2757         Yet Another Objective-C Bindings Patch
2758
2759         - Whitespace cleanup for IDLParser.pm
2760
2761         - Split DOMException, DOMRangeException, DOMXPathException, DOMEventsException
2762           and DOMAbstractView into their own files.
2763
2764         - Remove private method [DOMRGBColor _color] from DOMPrivate.h as
2765           it is not used and a public method is available now.
2766
2767         - Remove internal method [DOMDocument _ownerElement] from DOMInternal.h
2768           as it not used.
2769
2770         - Auto-generate method isContentEditable for DOMNode.
2771
2772         - General cleanup of bindings code including removing unneeded #imports
2773           and whitespace cleanup
2774
2775         * WebCore.xcodeproj/project.pbxproj:
2776         * bindings/objc/DOM.mm:
2777         (addElementClass):
2778         (elementClass):
2779         (-[DOMNode _initWithNode:WebCore::]):
2780         (+[DOMNode _nodeWith:WebCore::]):
2781         (-[DOMNode WebCore::]):
2782         (-[DOMNode KJS::Bindings::]):
2783         (-[DOMNode addEventListener:::]):
2784         (-[DOMNode removeEventListener:::]):
2785         (-[DOMNode dispatchEvent:]):
2786         (-[DOMElement image]):
2787         (-[DOMElement _font]):
2788         (-[DOMElement _imageTIFFRepresentation]):
2789         (-[DOMElement _getURLAttribute:]):
2790         (-[DOMElement _NPObject]):
2791         (-[DOMElement isFocused]):
2792         (-[DOMRange dealloc]):
2793         (-[DOMRange finalize]):
2794         (-[DOMRange description]):
2795         (-[DOMRange startContainer]):
2796         (-[DOMRange startOffset]):
2797         (-[DOMRange endContainer]):
2798         (-[DOMRange endOffset]):
2799         (-[DOMRange collapsed]):
2800         (-[DOMRange commonAncestorContainer]):
2801         (-[DOMRange setStart::]):
2802         (-[DOMRange setEnd::]):
2803         (-[DOMRange setStartBefore:]):
2804         (-[DOMRange setStartAfter:]):
2805         (-[DOMRange setEndBefore:]):
2806         (-[DOMRange setEndAfter:]):
2807         (-[DOMRange collapse:]):
2808         (-[DOMRange selectNode:]):
2809         (-[DOMRange selectNodeContents:]):
2810         (-[DOMRange compareBoundaryPoints::]):
2811         (-[DOMRange deleteContents]):
2812         (-[DOMRange extractContents]):
2813         (-[DOMRange cloneContents]):
2814         (-[DOMRange insertNode:]):
2815         (-[DOMRange surroundContents:]):
2816         (-[DOMRange cloneRange]):
2817         (-[DOMRange toString]):
2818         (-[DOMRange detach]):
2819         (-[DOMRange _initWithRange:WebCore::]):
2820         (+[DOMRange _rangeWith:WebCore::]):
2821         (-[DOMRange WebCore::]):
2822         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
2823         (+[DOMNodeFilter _nodeFilterWith:WebCore::]):
2824         (-[DOMNodeFilter WebCore::]):
2825         (-[DOMNodeFilter dealloc]):
2826         (-[DOMNodeFilter finalize]):
2827         (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]):
2828         (-[DOMNodeIterator WebCore::]):
2829         (+[DOMNodeIterator _nodeIteratorWith:WebCore::filter:]):
2830         (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]):
2831         (-[DOMTreeWalker WebCore::]):
2832         (+[DOMTreeWalker _treeWalkerWith:WebCore::filter:]):
2833         (ObjCNodeFilterCondition::acceptNode):
2834         (-[DOMDocument createNodeIterator::::]):
2835         (-[DOMDocument createTreeWalker::::]):
2836         (ObjCEventListener::find):
2837         (ObjCEventListener::create):
2838         (ObjCEventListener::handleEvent):
2839         * bindings/objc/DOMAbstractView.h: Added.
2840         * bindings/objc/DOMAbstractView.mm: Added.
2841         (-[DOMAbstractView document]):
2842         (-[DOMAbstractView WebCore::]):
2843         (-[DOMAbstractView _initWithAbstractView:WebCore::]):
2844         (+[DOMAbstractView _abstractViewWith:WebCore::]):
2845         * bindings/objc/DOMCSS.mm:
2846         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
2847         (+[DOMStyleSheet _styleSheetWith:WebCore::]):
2848         (+[DOMCSSStyleSheet _CSSStyleSheetWith:WebCore::]):
2849         (-[DOMCSSRule _initWithRule:WebCore::]):
2850         (+[DOMCSSRule _CSSRuleWith:WebCore::]):
2851         (-[DOMCSSValue _initWithValue:WebCore::]):
2852         (+[DOMCSSValue _CSSValueWith:WebCore::]):
2853         (+[DOMCSSPrimitiveValue _CSSPrimitiveValueWith:WebCore::]):
2854         (-[DOMDocument getComputedStyle::]):
2855         (-[DOMDocument getMatchedCSSRules::]):
2856         * bindings/objc/DOMCore.h:
2857         * bindings/objc/DOMEventException.h: Added.
2858         * bindings/objc/DOMEvents.h:
2859         * bindings/objc/DOMEvents.mm:
2860         * bindings/objc/DOMException.h: Added.
2861         * bindings/objc/DOMHTML.mm:
2862         (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]):
2863         (viewForElement):
2864         (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]):
2865         (-[DOMHTMLInputElement _selectedRange]):
2866         (-[DOMHTMLInputElement _setAutofilled:]):
2867         * bindings/objc/DOMInternal.h:
2868         * bindings/objc/DOMObject.h:
2869         * bindings/objc/DOMPrivate.h:
2870         * bindings/objc/DOMRange.h:
2871         * bindings/objc/DOMRangeException.h: Added.
2872         * bindings/objc/DOMViews.h:
2873         * bindings/objc/DOMViews.mm: Removed.
2874         * bindings/objc/DOMXPath.h:
2875         * bindings/objc/DOMXPathException.h: Added.
2876         * bindings/scripts/IDLParser.pm:
2877         * dom/Node.idl:
2878
2879 2006-09-18  Brady Eidson  <beidson@apple.com>
2880
2881         Windows build fix
2882
2883         * platform/win/TemporaryLinkStubs.cpp:
2884         (IconDatabase::setIconURLForPageURL):
2885
2886 2006-09-18  David Hyatt  <hyatt@apple.com>
2887
2888         Fix for bug 3969, hr width doesn't update when it clears a float.  This
2889         was also a problem with tables and overflow sections.
2890
2891         Reviewed by Eric
2892
2893         Added fast/block/float/width-update-after-clear.html
2894
2895         * rendering/RenderBlock.cpp:
2896         (WebCore::RenderBlock::collapseMargins):
2897         (WebCore::RenderBlock::clearFloatsIfNeeded):
2898
2899 2006-09-18  Brady Eidson  <beidson@apple.com>
2900
2901         Reviewed by John
2902
2903         http://bugs.webkit.org/show_bug.cgi?id=10907
2904         REGRESSION: New Icon Loaders don't handle certain non-server-root URLs correctly
2905
2906         * bridge/mac/FrameMac.h: Changed originalRequestURL() to virtual
2907         * bridge/win/FrameWin.h: Added originalRequestURL()
2908         * loader/icon/IconLoader.cpp:
2909         (IconLoader::receivedAllData): Moved the "pageURL to iconURL mapping logic" to Frame::commitIconURLToIconDatabase()
2910         * page/Frame.cpp:
2911         (WebCore::Frame::iconURL): Construct the icon URL from *only* the protocol and host of the frame's url.
2912         (WebCore::Frame::endIfNotLoading): Call commitIconURLToIconDatabase() if we're not kicking off an icon load
2913         (WebCore::Frame::commitIconURLToIconDatabase): Map the completed doc's pageURL to the iconURL
2914         * page/Frame.h: Added pure virtual originalRequestURL()
2915         * platform/win/TemporaryLinkStubs.cpp:
2916         (FrameWin::originalRequestURL): Added
2917
2918 2006-09-18  Rob Buis  <buis@kde.org>
2919
2920         Reviewed by Maciej.
2921
2922         http://bugs.webkit.org/show_bug.cgi?id=10807
2923         REGRESSION (r16259): Repro crash on manual-tests/svg-repaint-image.svg
2924
2925         Make sure the paint method is not exited without popping
2926         context and transparency layer.
2927
2928         WARNING: NO TEST CASES ADDED OR CHANGED
2929
2930         * kcanvas/RenderSVGImage.cpp:
2931         (WebCore::RenderSVGImage::paint):
2932
2933 2006-09-18  Graham Dennis  <graham.dennis@gmail.com>
2934
2935         Reviewed by Eric.
2936
2937         - fix for http://bugs.webkit.org/show_bug.cgi?id=10896
2938         REGRESSION: WebKit can't be built with SVG disabled
2939
2940         * bindings/scripts/CodeGeneratorObjC.pm:
2941         For each file generated add a #ifdef <something>_SUPPORT / #endif
2942         pair if the idl file has a Conditional extended attribute
2943
2944 2006-09-17  Eric Seidel  <eric@eseidel.com>
2945
2946         Reviewed by ap.
2947
2948         REGRESSION (r16245): double-clicking on javascript exceptions fails to show source
2949         http://bugs.webkit.org/show_bug.cgi?id=10813
2950
2951         * bridge/mac/WebCoreFrameBridge.mm:
2952         (+[WebCoreFrameBridge stringWithData:textEncodingName:]):
2953
2954 2006-09-17  Alexey Proskuryakov  <ap@nypop.com>
2955
2956         Reviewed by Hyatt.
2957
2958         http://bugs.webkit.org/show_bug.cgi?id=10779
2959         REGRESSION: Animated GIF ignores frame intervals and loops infinitely
2960
2961         No test possible.
2962
2963         * platform/Image.cpp:
2964         (WebCore::Image::shouldAnimate): Don't check that there is more than one frame,
2965         maybe the rest just hasn't been loaded yet.
2966         (WebCore::Image::startAnimation): Move the frame count check here - there is no need
2967         to start animating before we get at least two frames.
2968
2969 2006-09-17  Brady Eidson <beidson@apple.com>
2970
2971         Reviewed by Sarge
2972
2973         IconLoader now gracefully handles the condition where there's no document in the frame
2974         (ie. PDFs)
2975
2976         * loader/icon/IconLoader.cpp:
2977         (IconLoader::startLoading):
2978
2979 2006-09-17  David Hyatt  <hyatt@apple.com>
2980
2981         Fix for bug 10899, rework how CSS keywords work to be smarter about
2982         using the correct size when generic families change (e.g., monospace to
2983         serif and vice versa).
2984
2985         Reviewed by aroben
2986
2987         Added fast/text/basic/generic-family-changes.html
2988
2989         * css/cssstyleselector.cpp:
2990         (WebCore::CSSStyleSelector::applyProperty):
2991         (WebCore::CSSStyleSelector::checkForGenericFamilyChange):
2992         (WebCore::CSSStyleSelector::fontSizeForKeyword):
2993         * css/cssstyleselector.h:
2994         * dom/Document.cpp:
2995         (WebCore::Document::recalcStyle):
2996         * platform/FontDescription.h:
2997         (WebCore::FontDescription::FontDescription):
2998         (WebCore::FontDescription::keywordSize):
2999         (WebCore::FontDescription::setKeywordSize):
3000         (WebCore::FontDescription::operator==):
3001
3002 2006-09-17  Alexey Proskuryakov  <ap@nypop.com>
3003
3004         Reviewed by Brady.
3005
3006         http://bugs.webkit.org/show_bug.cgi?id=10852
3007         REGRESSION: Reproducible crash in XMLHttpRequest::abort()
3008
3009         Test: http/tests/xmlhttprequest/xhr-onunload.html
3010
3011         * xml/xmlhttprequest.cpp:
3012         (WebCore::XMLHttpRequest::send): Check the return value of ResourceLoader::start().
3013
3014         * loader/icon/IconLoader.cpp:
3015         (IconLoader::startLoading): Fix a similar latent bug here.
3016
3017 2006-09-17  Adam Roben  <aroben@apple.com>
3018
3019         Build fix.
3020
3021         * loader/icon/IconDatabase.cpp:
3022
3023 2006-09-17  Anders Carlsson  <acarlsson@apple.com>
3024
3025         Reviewed by Brady.
3026
3027         Add simplifyWhiteSpace and stripWhiteSpace to the String class.
3028         Change the XSLT Parameter Map to use Strings instead of StringImpls.
3029         General cleanup.
3030
3031         * bindings/js/JSXSLTProcessor.cpp:
3032         (KJS::XSLTProcessorProtoFunc::callAsFunction):
3033         * bindings/js/kjs_events.cpp:
3034         (KJS::JSAbstractEventListener::handleEvent):
3035         * bindings/js/kjs_window.cpp:
3036         (KJS::ScheduledAction::execute):
3037         * css/MediaList.cpp:
3038         (WebCore::MediaList::setMediaText):
3039         * dom/Document.cpp:
3040         (WebCore::Document::processHttpEquiv):
3041         * editing/ApplyStyleCommand.cpp:
3042         (WebCore::StyleChange::init):
3043         * html/HTMLDocument.cpp:
3044         (WebCore::parseDocTypeDeclaration):
3045         * html/HTMLLinkElement.cpp:
3046         (WebCore::HTMLLinkElement::parseMappedAttribute):
3047         * html/HTMLObjectElement.cpp:
3048         (WebCore::HTMLObjectElement::HTMLObjectElement):
3049         (WebCore::HTMLObjectElement::parseMappedAttribute):
3050         (WebCore::HTMLObjectElement::attach):
3051         (WebCore::HTMLObjectElement::setComplete):
3052         (WebCore::HTMLObjectElement::detach):
3053         (WebCore::HTMLObjectElement::recalcStyle):
3054         (WebCore::HTMLObjectElement::childrenChanged):
3055         (WebCore::HTMLObjectElement::isImageType):
3056         * html/HTMLObjectElement.h:
3057         * html/HTMLOptionElement.cpp:
3058         (WebCore::HTMLOptionElement::value):
3059         * html/HTMLSelectElement.cpp:
3060         (WebCore::HTMLSelectElement::appendFormData):
3061         * html/HTMLTokenizer.cpp:
3062         (WebCore::HTMLTokenizer::parseTag):
3063         * ksvg2/svg/SVGColor.cpp:
3064         (WebCore::SVGColor::setRGBColor):
3065         * ksvg2/svg/SVGDescElement.cpp:
3066         (WebCore::SVGDescElement::description):
3067         * platform/PlatformString.h:
3068         * platform/String.cpp:
3069         (WebCore::String::stripWhiteSpace):
3070         (WebCore::String::simplifyWhiteSpace):
3071         * platform/StringImpl.cpp:
3072         (WebCore::isSpace):
3073         (WebCore::parseLength):
3074         (WebCore::StringImpl::stripWhiteSpace):
3075         (WebCore::StringImpl::simplifyWhiteSpace):
3076         (WebCore::StringImpl::toInt):
3077         * platform/StringImpl.h:
3078         * platform/mac/ClipboardMac.mm:
3079         (WebCore::cocoaTypeFromMIMEType):
3080         * rendering/RenderPartObject.cpp:
3081         (WebCore::RenderPartObject::updateWidget):
3082         * xml/XPathFunctions.cpp:
3083         (WebCore::XPath::FunNormalizeSpace::doEvaluate):
3084         * xml/XPathGrammar.y:
3085         * xml/XPathStep.cpp:
3086         (WebCore::XPath::Step::nodeTestMatches):
3087         * xml/XSLStyleSheet.cpp:
3088         (WebCore::XSLStyleSheet::loadChildSheets):
3089         (WebCore::XSLStyleSheet::locateStylesheetSubResource):
3090         * xml/XSLTProcessor.cpp:
3091         (WebCore::xsltParamArrayFromParameterMap):
3092         (WebCore::XSLTProcessor::setParameter):
3093         (WebCore::XSLTProcessor::getParameter):
3094         (WebCore::XSLTProcessor::removeParameter):
3095         * xml/XSLTProcessor.h:
3096         * xml/xmlhttprequest.cpp:
3097         (WebCore::XMLHttpRequest::getStatusText):
3098
3099 2006-09-17  David Hyatt  <hyatt@apple.com>
3100
3101         Fix for bugzilla bugs 10895 and 6336, fieldsets misbehaving when floats
3102         are declared right before the fieldsets.  It turns out fieldsets in other
3103         browsers avoid floats (like overflow:auto/hidden/scroll sections do), so
3104         adding that behavior to fieldset fixes the bug.
3105
3106         Made avoidsFloats virtual and did some refactoring to make tables, flexboxes
3107         and fieldsets all subclass.
3108
3109         Reviewed by anders
3110
3111         Added fast/forms/float-before-fieldset.html
3112
3113         * rendering/RenderFieldset.h:
3114         (WebCore::RenderFieldset::avoidsFloats):
3115         * rendering/RenderFlexibleBox.h:
3116         (WebCore::RenderFlexibleBox::avoidsFloats):
3117         * rendering/RenderObject.cpp:
3118         (WebCore::RenderObject::avoidsFloats):
3119         * rendering/RenderObject.h:
3120         * rendering/RenderTable.h:
3121         (WebCore::RenderTable::avoidsFloats):
3122
3123 2006-09-17  David Hyatt  <hyatt@apple.com>
3124
3125         Fix for bugzilla bug 3240, implement support for the HTML4 "frame" and
3126         "rules" attributes on tables.
3127
3128         Reviewed by bradee-oh
3129
3130         Well-covered by existing layout tests.
3131
3132         * html/HTMLTableCellElement.cpp:
3133         (WebCore::HTMLTableCellElement::additionalAttributeStyleDecl):
3134         * html/HTMLTableColElement.cpp:
3135         (WebCore::HTMLTableColElement::additionalAttributeStyleDecl):
3136         * html/HTMLTableColElement.h:
3137         * html/HTMLTableElement.cpp:
3138         (WebCore::HTMLTableElement::HTMLTableElement):
3139         (WebCore::HTMLTableElement::~HTMLTableElement):
3140         (WebCore::HTMLTableElement::setCaption):
3141         (WebCore::HTMLTableElement::setTHead):
3142         (WebCore::HTMLTableElement::setTFoot):
3143         (WebCore::HTMLTableElement::setTBody):
3144         (WebCore::HTMLTableElement::createTHead):
3145         (WebCore::HTMLTableElement::deleteTHead):
3146         (WebCore::HTMLTableElement::createTFoot):
3147         (WebCore::HTMLTableElement::deleteTFoot):
3148         (WebCore::HTMLTableElement::createCaption):
3149         (WebCore::HTMLTableElement::deleteCaption):
3150         (WebCore::HTMLTableElement::insertRow):
3151         (WebCore::HTMLTableElement::deleteRow):
3152         (WebCore::HTMLTableElement::addChild):
3153         (WebCore::HTMLTableElement::childrenChanged):
3154         (WebCore::HTMLTableElement::mapToEntry):
3155         (WebCore::HTMLTableElement::parseMappedAttribute):
3156         (WebCore::HTMLTableElement::additionalAttributeStyleDecl):
3157         (WebCore::HTMLTableElement::getSharedCellDecl):
3158         (WebCore::HTMLTableElement::getSharedGroupDecl):
3159         (WebCore::HTMLTableElement::attach):
3160         * html/HTMLTableElement.h:
3161         (WebCore::HTMLTableElement::caption):
3162         (WebCore::HTMLTableElement::tHead):
3163         (WebCore::HTMLTableElement::tFoot):
3164         (WebCore::HTMLTableElement::):
3165         * html/HTMLTableRowElement.h:
3166         * html/HTMLTableSectionElement.cpp:
3167         (WebCore::HTMLTableSectionElement::additionalAttributeStyleDecl):
3168         * html/HTMLTableSectionElement.h:
3169
3170 2006-09-17  David Hyatt  <hyatt@apple.com>
3171
3172         Fix for bugzilla bug 4192, font size wrong for <tt> elements that
3173         specify their own new font-family list.  Make sure to always
3174         reset the generic family along with the family list when mapping in
3175         new font-family values.
3176
3177         Reviewed by bradee-oh
3178
3179         fast/text/basic/generic-family-reset.html
3180
3181         * css/cssstyleselector.cpp:
3182         (WebCore::CSSStyleSelector::applyProperty):
3183
3184 2006-09-16  Brady Eidson <beidson@apple.com>
3185
3186         Reviewed by Hyatt
3187
3188         Pruning code relating to WebKit's icon loader
3189
3190         * bridge/mac/WebCoreIconDatabaseBridge.h:
3191         * bridge/mac/WebCoreIconDatabaseBridge.mm:
3192         * loader/icon/IconDatabase.h:
3193         * page/Frame.cpp:
3194         (WebCore::Frame::endIfNotLoading): Moved a FIXME in from WebKit's IconLoader to
3195         its new home
3196
3197 2006-09-16  Sam Weinig  <sam.weinig@gmail.com>
3198
3199         Reviewed by Tim H.
3200
3201         Patch for http://bugs.webkit.org/show_bug.cgi?id=10885
3202         Auto-generate DOMHTMLDocument for the Objective-C bindings
3203
3204         * DerivedSources.make:
3205         * WebCore.xcodeproj/project.pbxproj:
3206         * bindings/objc/DOMExtensions.h:
3207         * bindings/objc/DOMHTML.mm:
3208         (-[DOMHTMLDocument createDocumentFragmentWithText:]):
3209         * bindings/objc/DOMHTMLDocument.h: Removed.
3210         * bindings/objc/DOMHTMLDocument.mm: Removed.
3211         * bindings/objc/PublicDOMInterfaces.h:
3212         * bindings/scripts/CodeGeneratorObjC.pm:
3213         * html/HTMLDocument.idl:
3214         * platform/DeprecatedString.h:
3215         (WebCore::DeprecatedString::operator NSString*):
3216
3217 2006-09-16  Rob Buis  <buis@kde.org>
3218
3219         Reviewed by Eric.
3220
3221         http://bugs.webkit.org/show_bug.cgi?id=10866
3222         Code in kcanvas/ should not use Private
3223
3224         Remove Private classes and tweak coding style.
3225
3226         WARNING: NO TEST CASES ADDED OR CHANGED
3227
3228         * kcanvas/RenderPath.cpp:
3229         (WebCore::RenderPath::RenderPath):
3230         (WebCore::RenderPath::~RenderPath):
3231         (WebCore::RenderPath::localTransform):
3232         (WebCore::RenderPath::setLocalTransform):
3233         (WebCore::RenderPath::fillContains):
3234         (WebCore::RenderPath::relativeBBox):
3235         (WebCore::RenderPath::setPath):
3236         (WebCore::RenderPath::path):
3237         (WebCore::RenderPath::layout):
3238         * kcanvas/RenderPath.h:
3239         * kcanvas/RenderSVGContainer.cpp:
3240         (WebCore::RenderSVGContainer::RenderSVGContainer):
3241         (WebCore::RenderSVGContainer::~RenderSVGContainer):
3242         (WebCore::RenderSVGContainer::drawsContents):
3243         (WebCore::RenderSVGContainer::setDrawsContents):
3244         (WebCore::RenderSVGContainer::localTransform):
3245         (WebCore::RenderSVGContainer::setLocalTransform):
3246         (WebCore::RenderSVGContainer::layout):
3247         (WebCore::RenderSVGContainer::paint):
3248         (WebCore::RenderSVGContainer::setViewport):
3249         (WebCore::RenderSVGContainer::viewport):
3250         (WebCore::RenderSVGContainer::setViewBox):
3251         (WebCore::RenderSVGContainer::viewBox):
3252         (WebCore::RenderSVGContainer::setAlign):
3253         (WebCore::RenderSVGContainer::align):
3254         (WebCore::RenderSVGContainer::fillContains):
3255         (WebCore::RenderSVGContainer::strokeContains):
3256         (WebCore::RenderSVGContainer::setSlice):
3257         (WebCore::RenderSVGContainer::slice):
3258         * kcanvas/RenderSVGContainer.h:
3259         * kcanvas/device/KRenderingFillPainter.cpp:
3260         (WebCore::KRenderingFillPainter::KRenderingFillPainter):
3261         (WebCore::KRenderingFillPainter::~KRenderingFillPainter):
3262         (WebCore::KRenderingFillPainter::fillRule):
3263         (WebCore::KRenderingFillPainter::setFillRule):
3264         (WebCore::KRenderingFillPainter::opacity):
3265         (WebCore::KRenderingFillPainter::setOpacity):
3266         * kcanvas/device/KRenderingFillPainter.h:
3267         * kcanvas/device/KRenderingPaintServerGradient.cpp:
3268         (WebCore::KRenderingPaintServerGradient::KRenderingPaintServerGradient):
3269         (WebCore::KRenderingPaintServerGradient::~KRenderingPaintServerGradient):
3270         (WebCore::KRenderingPaintServerGradient::gradientStops):
3271         (WebCore::KRenderingPaintServerGradient::setGradientStops):
3272         (WebCore::KRenderingPaintServerGradient::spreadMethod):
3273         (WebCore::KRenderingPaintServerGradient::setGradientSpreadMethod):
3274         (WebCore::KRenderingPaintServerGradient::boundingBoxMode):
3275         (WebCore::KRenderingPaintServerGradient::setBoundingBoxMode):
3276         (WebCore::KRenderingPaintServerGradient::gradientTransform):
3277         (WebCore::KRenderingPaintServerGradient::setGradientTransform):
3278         (WebCore::KRenderingPaintServerLinearGradient::KRenderingPaintServerLinearGradient):
3279         (WebCore::KRenderingPaintServerLinearGradient::~KRenderingPaintServerLinearGradient):
3280         (WebCore::KRenderingPaintServerLinearGradient::gradientStart):
3281         (WebCore::KRenderingPaintServerLinearGradient::setGradientStart):
3282         (WebCore::KRenderingPaintServerLinearGradient::gradientEnd):
3283         (WebCore::KRenderingPaintServerLinearGradient::setGradientEnd):
3284         (WebCore::KRenderingPaintServerRadialGradient::KRenderingPaintServerRadialGradient):
3285         (WebCore::KRenderingPaintServerRadialGradient::~KRenderingPaintServerRadialGradient):
3286         (WebCore::KRenderingPaintServerRadialGradient::gradientCenter):
3287         (WebCore::KRenderingPaintServerRadialGradient::setGradientCenter):
3288         (WebCore::KRenderingPaintServerRadialGradient::gradientFocal):
3289         (WebCore::KRenderingPaintServerRadialGradient::setGradientFocal):
3290         (WebCore::KRenderingPaintServerRadialGradient::gradientRadius):
3291         (WebCore::KRenderingPaintServerRadialGradient::setGradientRadius):
3292         (WebCore::KRenderingPaintServerGradient::listener):
3293         (WebCore::KRenderingPaintServerGradient::setListener):
3294         * kcanvas/device/KRenderingPaintServerGradient.h:
3295         * kcanvas/device/KRenderingPaintServerPattern.cpp:
3296         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
3297         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
3298         (WebCore::KRenderingPaintServerPattern::setBbox):
3299         (WebCore::KRenderingPaintServerPattern::bbox):
3300         (WebCore::KRenderingPaintServerPattern::boundingBoxMode):
3301         (WebCore::KRenderingPaintServerPattern::setBoundingBoxMode):
3302         (WebCore::KRenderingPaintServerPattern::tile):
3303         (WebCore::KRenderingPaintServerPattern::setTile):
3304         (WebCore::KRenderingPaintServerPattern::patternTransform):
3305         (WebCore::KRenderingPaintServerPattern::setPatternTransform):
3306         (WebCore::KRenderingPaintServerPattern::listener):
3307         (WebCore::KRenderingPaintServerPattern::setListener):
3308         * kcanvas/device/KRenderingPaintServerPattern.h:
3309         * kcanvas/device/KRenderingPaintServerSolid.cpp:
3310         (WebCore::KRenderingPaintServerSolid::KRenderingPaintServerSolid):
3311         (WebCore::KRenderingPaintServerSolid::~KRenderingPaintServerSolid):
3312         (WebCore::KRenderingPaintServerSolid::color):
3313         (WebCore::KRenderingPaintServerSolid::setColor):
3314         * kcanvas/device/KRenderingPaintServerSolid.h:
3315         * kcanvas/device/KRenderingStrokePainter.cpp:
3316         (WebCore::KRenderingStrokePainter::KRenderingStrokePainter):
3317         (WebCore::KRenderingStrokePainter::~KRenderingStrokePainter):
3318         (WebCore::KRenderingStrokePainter::strokeWidth):
3319         (WebCore::KRenderingStrokePainter::setStrokeWidth):
3320         (WebCore::KRenderingStrokePainter::strokeMiterLimit):
3321         (WebCore::KRenderingStrokePainter::setStrokeMiterLimit):
3322         (WebCore::KRenderingStrokePainter::strokeCapStyle):
3323         (WebCore::KRenderingStrokePainter::setStrokeCapStyle):
3324         (WebCore::KRenderingStrokePainter::strokeJoinStyle):
3325         (WebCore::KRenderingStrokePainter::setStrokeJoinStyle):
3326         (WebCore::KRenderingStrokePainter::dashOffset):
3327         (WebCore::KRenderingStrokePainter::setDashOffset):
3328         (WebCore::KRenderingStrokePainter::dashArray):
3329         (WebCore::KRenderingStrokePainter::setDashArray):
3330         (WebCore::KRenderingStrokePainter::opacity):
3331         (WebCore::KRenderingStrokePainter::setOpacity):
3332         (WebCore::KRenderingStrokePainter::dirty):
3333         (WebCore::KRenderingStrokePainter::setDirty):
3334         * kcanvas/device/KRenderingStrokePainter.h:
3335
3336 2006-09-16  Mark Rowe  <opendarwin.org@bdash.net.nz>
3337
3338         Reviewed by Anders.
3339
3340         http://bugs.webkit.org/show_bug.cgi?id=10887
3341         Fix build error
3342
3343         * bindings/objc/DOMPrivate.h: Remove reference to DOMEventPrivate.h.
3344
3345 2006-09-16  Sam Weinig  <sam.weinig@gmail.com>
3346
3347         Reviewed by Anders.
3348
3349         Fix for http://bugs.webkit.org/show_bug.cgi?id=10886
3350         REGRESSION (r16387): Reproducible crash when mousing over HTML document
3351
3352         - Special case method [DOMNode ownerDocument] to call document() instead
3353           or ownerDocument() to return to the old behavior.
3354
3355         * WebCore.xcodeproj/project.pbxproj:
3356         * bindings/scripts/CodeGeneratorObjC.pm:
3357
3358 2006-09-15  Brady Eidson  <beidson@apple.com>
3359
3360         Reviewed by Tim Hatcher
3361
3362         <rdar://problem/4730811> - New IconDatabase needs to attempt to create its path.
3363         Otherwise new installs and new user accounts won't have any icons because the icon.db cannot be created
3364
3365         * loader/icon/IconDatabase.cpp: Removed a now obsolete FIXME
3366         (WebCore::makeAllDirectories): Added - candidate to be in a header for "platform neutral file utilities"
3367         (WebCore::IconDatabase::open): Make sure the directory exists
3368
3369 2006-09-15  Timothy Hatcher  <timothy@apple.com>
3370
3371         Reviewed by Brady.
3372
3373         Make new style ObjC methods public API.
3374
3375         * WebCore.xcodeproj/project.pbxproj:
3376         * bindings/objc/DOMPrivate.h:
3377         * bindings/objc/PublicDOMInterfaces.h:
3378
3379 2006-09-15  Sam Weinig  <sam.weinig@gmail.com>
3380
3381         Reviewed by Tim H.
3382
3383         Patch for http://bugs.webkit.org/show_bug.cgi?id=10870
3384         Auto-generate DOMNode for the Objective-C bindings
3385
3386         * DerivedSources.make:
3387         * WebCore.xcodeproj/project.pbxproj:
3388         * bindings/objc/DOM.mm:
3389         (-[DOMNode boundingBox]):
3390         (-[DOMNode lineBoxRects]):
3391         * bindings/objc/DOMEvents.h:
3392         * bindings/objc/DOMExtensions.h:
3393         * bindings/objc/DOMNode.h: Removed.
3394         * bindings/objc/DOMNode.mm: Removed.
3395         * bindings/objc/PublicDOMInterfaces.h:
3396         * bindings/scripts/CodeGeneratorObjC.pm:
3397         * dom/Node.idl:
3398
3399 2006-09-15  Timothy Hatcher  <timothy@apple.com>
3400
3401         Reviewed by Justin.
3402
3403         Removed alter selection logic from WebCoreFrameBridge and moved to SelectionController.
3404
3405         * bridge/mac/WebCoreFrameBridge.h:
3406         * bridge/mac/WebCoreFrameBridge.mm:
3407         (-[WebCoreFrameBridge centerSelectionInVisibleArea]):
3408         (-[WebCoreFrameBridge rangeByExpandingSelectionWithGranularity:]):
3409         (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:direction:granularity:]):
3410         (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]):
3411         (-[WebCoreFrameBridge alterCurrentSelection:verticalDistance:]):
3412         (-[WebCoreFrameBridge replaceMarkedTextWithText:]):
3413         (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
3414         (-[WebCoreFrameBridge increaseSelectionListLevel]):
3415         (-[WebCoreFrameBridge increaseSelectionListLevelOrdered]):
3416         (-[WebCoreFrameBridge increaseSelectionListLevelUnordered]):
3417         (-[WebCoreFrameBridge decreaseSelectionListLevel]):
3418         (-[WebCoreFrameBridge insertLineBreak]):
3419         (-[WebCoreFrameBridge insertParagraphSeparator]):
3420         (-[WebCoreFrameBridge insertParagraphSeparatorInQuotedContent]):
3421         (-[WebCoreFrameBridge insertText:selectInsertedText:]):
3422         (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]):
3423         (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]):
3424         (createMouseEventFromDraggingInfo):
3425         * editing/SelectionController.cpp:
3426         (WebCore::SelectionController::moveTo):
3427         (WebCore::SelectionController::setSelection):
3428         (WebCore::SelectionController::modify):
3429         (WebCore::SelectionController::setBase):
3430         (WebCore::SelectionController::setExtent):
3431         * editing/SelectionController.h:
3432         * page/Frame.cpp:
3433         (WebCore::Frame::revealSelection):
3434         (WebCore::Frame::revealCaret):
3435         * page/Frame.h:
3436
3437 2006-09-15  Brady Eidson  <beidson@apple.com>
3438
3439         Reviewed by Anders
3440
3441         Added the ability to get a mutable char* from a CString, which will copy the internal
3442         buffer if the ref count is greater than 1 so your mutable char* won't affect any other
3443         referrer of that buffer.
3444
3445         * platform/CString.cpp:
3446         (WebCore::CString::mutableData):
3447         (WebCore::CString::copyBufferIfNeeded):
3448         * platform/CString.h:
3449
3450 2006-09-15  Justin Garcia  <justin.garcia@apple.com>
3451
3452         Reviewed by harrison
3453
3454         <rdar://problem/4674869>
3455         REGRESSION: selecting text to write over results in cursor jumping to middle of next line
3456
3457         * editing/SelectionController.cpp:
3458         (WebCore::SelectionController::modify): Added lineBoundary to test fix.
3459         * editing/visible_units.cpp:
3460         (WebCore::endOfLine): If the last box on the line is a lineBreak, return the
3461         position before it, not after it.
3462
3463 2006-09-15  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
3464
3465         Reviewed by Adam.
3466
3467         http://bugs.webkit.org/show_bug.cgi?id=10864
3468         Bug 10864: Linux\GDK build fixes
3469
3470         * Projects/gdk/webcore-gdk.bkl:
3471         * WebCoreSources.bkl:
3472         * platform/gdk/FontCacheGdk.cpp:
3473         * platform/gdk/FontDataGdk.cpp:
3474         (WebCore::FontData::platformInit):
3475         * platform/gdk/FontGdk.cpp:
3476         (WebCore::Font::drawGlyphs):
3477         * platform/gdk/FrameGdk.cpp:
3478         (WebCore::FrameGdk::handleGdkEvent):
3479         * platform/gdk/FrameGdk.h:
3480         * platform/gdk/ImageGdk.cpp: Added.
3481         (WebCore::Image::initPlatformData):
3482         (WebCore::Image::invalidatePlatformData):
3483         (WebCore::Image::loadPlatformResource):
3484         (WebCore::Image::supportsType):
3485         * platform/gdk/RenderPopupMenuGdk.cpp:
3486         (WebCore::RenderPopupMenuGdk::hidePopup):
3487         * platform/gdk/RenderPopupMenuGdk.h:
3488         * platform/gdk/ScreenGdk.cpp:
3489         (WebCore::drawableForPage):
3490         (WebCore::screenRect):
3491         (WebCore::screenDepth):
3492         (WebCore::usableScreenRect):
3493         (WebCore::scaleFactor):
3494         * platform/gdk/SystemTimeLinux.cpp:
3495         (WebCore::currentTime):
3496         * platform/gdk/TemporaryLinkStubs.cpp:
3497         (FrameGdk::bindingRootObject):
3498         (FrameGdk::markMisspellings):
3499         (WebCore::screenDepthPerComponent):
3500         (WebCore::screenIsMonochrome):
3501         (WebCore::fileButtonChooseFileLabel):
3502         (WebCore::fileButtonNoFileSelectedLabel):
3503         (FrameGdk::shouldChangeSelection):
3504         (FrameGdk::respondToChangedSelection):
3505         (FrameGdk::respondToChangedContents):
3506         (Path::contains):
3507         (PlatformScrollBar::PlatformScrollBar):
3508         (PlatformScrollBar::~PlatformScrollBar):
3509         (PlatformScrollBar::width):
3510         (PlatformScrollBar::height):
3511         (PlatformScrollBar::setEnabled):
3512         (PlatformScrollBar::paint):
3513         (PlatformScrollBar::setScrollBarValue):
3514         (PlatformScrollBar::setKnobProportion):
3515         (PlatformScrollBar::setRect):
3516         (ScrollBar::ScrollBar):
3517         (FileChooser::FileChooser):
3518         (FileChooser::~FileChooser):
3519         (FileChooser::openFileChooser):
3520         (FileChooser::basenameForWidth):
3521         (FileChooser::uploadControlDetaching):
3522         (FileChooser::chooseFile):
3523         (Icon::Icon):
3524         (Icon::~Icon):
3525         (Icon::newIconForFile):
3526         (Icon::paint):
3527         (IconLoader::stopLoading):
3528         (IconLoader::startLoading):
3529         (IconLoader::createForFrame):
3530         (IconDatabase::isIconExpiredForIconURL):
3531         (IconDatabase::hasEntryForIconURL):
3532         (IconDatabase::sharedIconDatabase):
3533         * platform/gdk/WidgetGdk.cpp:
3534         * webcore-base.bkl:
3535
3536 2006-09-15  Nikolas Zimmermann  <zimmermann@kde.org>
3537
3538         Reviewed by Eric.
3539
3540         Fixes: http://bugs.webkit.org/show_bug.cgi?id=10835
3541         Fix svg memory leaks.
3542
3543         Reworked SVGList to deal with RefPtr's for ptr types
3544         which makes manual refcounting unnecessary, and is much safer.
3545
3546         Removing all virtual functions (nullItem) from SVGList, and
3547         also remove SVGListBase. Switch to a similar concept like
3548         Vector/VectorTraits (see new file SVGListTraits.h).
3549
3550         Credits go to Eric/Maciej for the inspiration.
3551
3552         * CMakeLists.txt: Add SVGListTraits.cpp to build
3553         * WebCore.xcodeproj/project.pbxproj: Ditto.
3554         * bindings/scripts/CodeGeneratorJS.pm: Generator changes for SVGTransform/PathSeg/LengthList (now RefPtr based)
3555         * kcanvas/RenderSVGText.cpp: Add some get() methods, as SVGLengthList is RefPtr based now.
3556         (WebCore::RenderSVGText::translationForAttributes):
3557         * ksvg2/svg/SVGAnimateTransformElement.cpp: Add some get() methods, as SVGTransformList is RefPtr based now.
3558         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
3559         * ksvg2/svg/SVGElementInstanceList.cpp: Be RefPtr based.
3560         (WebCore::SVGElementInstanceList::SVGElementInstanceList):
3561         * ksvg2/svg/SVGElementInstanceList.h:
3562         * ksvg2/svg/SVGLengthList.cpp: Ditto.
3563         (WebCore::SVGLengthList::SVGLengthList):
3564         * ksvg2/svg/SVGLengthList.h: Ditto.
3565         * ksvg2/svg/SVGList.h: Rewrote, as described above.
3566         (WebCore::SVGListTypeOperations::nullItem):
3567         (WebCore::SVGList::SVGList):
3568         (WebCore::SVGList::~SVGList):
3569         (WebCore::SVGList::clear):
3570         (WebCore::SVGList::getFirst):
3571         (WebCore::SVGList::getLast):
3572         (WebCore::SVGList::getItem):
3573         (WebCore::SVGList::replaceItem):
3574         (WebCore::SVGList::removeItem):
3575         * ksvg2/svg/SVGListTraits.cpp: Added.
3576         * ksvg2/svg/SVGListTraits.h: Added.
3577         (WebCore::):
3578         * ksvg2/svg/SVGPathElement.cpp: Add some get() methods, as SVGPathSegList is RefPtr based now.
3579         (WebCore::SVGPathElement::toPathData):
3580         * ksvg2/svg/SVGPathSegList.cpp: Be RefPtr based.
3581         (WebCore::SVGPathSegList::SVGPathSegList):
3582         * ksvg2/svg/SVGPathSegList.h: Ditto.
3583         * ksvg2/svg/SVGTransform.cpp: Style cleanup.
3584         (SVGTransform::SVGTransform):
3585         * ksvg2/svg/SVGTransformList.cpp: Be RefPtr based.
3586         (SVGTransformList::SVGTransformList):
3587         (SVGTransformList::createSVGTransformFromMatrix):
3588         (SVGTransformList::consolidate):
3589         * ksvg2/svg/SVGTransformList.h: Ditto.
3590         * ksvg2/svg/SVGTransformable.cpp: Fix RefPtr usage of SVGTransform.
3591         (SVGTransformable::parseTransformAttribute):
3592
3593 2006-09-15  Nikolas Zimmermann  <zimmermann@kde.org>
3594
3595         Reviewed by eseidel.  Landed by eseidel.
3596
3597         Fix build on Qt/Linux and implement Frame::addMessageToConsole to
3598         be able to see javascript errors for instance.
3599
3600         * CMakeLists.txt:
3601         * platform/qt/FrameQt.h:
3602         * platform/qt/FrameQt.cpp: Implement addMessageToConsole.
3603         (WebCore::FrameQt::bindingRootObject):
3604         * platform/qt/TemporaryLinkStubs.cp
3605         (WebCore::IconDatabase::hasEntryForIconURL):
3606         (WebCore::IconDatabase::sharedIconDatabase):
3607
3608 2006-09-15  Sam Weinig  <sam.weinig@gmail.com>
3609
3610         Reviewed by Tim H.
3611
3612         Patch for http://bugs.webkit.org/show_bug.cgi?id=10869
3613         Auto-generate the internal methods for the Objective-C bindings
3614
3615         - Auto-generates the internal method (ie. the _fooBar and _fooBarWith methods)
3616           implementations where standard.  For cases where a custom implementation was
3617           needed, added a [ObjCNoInternal] extended attribute to the corresponding IDL.