e67ead672ae04c026de5ed936ea73296ae7c3e44
[WebKit-https.git] / WebCore / ChangeLog
1 2006-11-03  Zack Rusin  <zack@kde.org>
2
3         Reviewed by Hyatt. Landed by Maciej.
4
5         Adding setPlatformPen/setPlatformFont/setPlatformFillColor
6         to graphics context to be able to set consistant state
7         on the platform specific painter without having to change
8         fill/stroke/font on every operation. This fixes color/stroke/fill
9         and font handling in the Qt port.
10
11         * platform/graphics/GraphicsContext.cpp:
12         (WebCore::GraphicsContext::setFont):
13         (WebCore::GraphicsContext::setPen):
14         (WebCore::GraphicsContext::setFillColor):
15         (WebCore::GraphicsContext::setPlatformPen):
16         (WebCore::GraphicsContext::setPlatformFillColor):
17         (WebCore::GraphicsContext::setPlatformFont):
18         * platform/graphics/GraphicsContext.h:
19         * platform/qt/GraphicsContextQt.cpp:
20         (WebCore::toQtCompositionMode):
21         (WebCore::toQtLineCap):
22         (WebCore::toQtLineJoin):
23         (WebCore::toQPenStyle):
24         (WebCore::penToQPen):
25         (WebCore::TransparencyLayer::TransparencyLayer):
26         (WebCore::GraphicsContext::addRoundedRectClip):
27         (WebCore::GraphicsContext::setPlatformFont):
28         (WebCore::GraphicsContext::setPlatformPen):
29         (WebCore::GraphicsContext::setPlatformFillColor):
30         * platform/qt/ScrollViewCanvasQt.cpp:
31         (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt):
32         (WebCore::ScrollViewCanvasQt::paintEvent):
33         (WebCore::ScrollViewCanvasQt::handleKeyEvent):
34         * platform/qt/ScrollViewCanvasQt.h:
35
36 2006-11-02  Adele Peterson  <adele@apple.com>
37
38         Reviewed by Anders.
39
40         - Fix for http://bugs.webkit.org/show_bug.cgi?id=9581
41         REGRESSION: The new NativeTextArea scrolls to the top when the control is unfocused.
42
43         Test: fast/forms/textarea-no-scroll-on-blur.html
44
45         * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::forwardEvent):
46           On blur, only scroll back to the start for text fields.
47
48 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
49
50         Another build fix.
51         
52         * rendering/RenderFileUploadControl.cpp:
53         (WebCore::RenderFileUploadControl::paintObject):
54
55 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
56
57         Build fix.
58         
59         * page/FramePrivate.h:
60         (WebCore::FramePrivate::FramePrivate):
61
62 2006-11-02  Kevin Ollivier <kevino@theolliviers.com>
63
64         Reviewed by Geoff, landed by Anders.
65         
66         Fix dependency problems caused when running move-js-headers.sh
67         
68         * move-js-headers.sh:
69         Use cp -p instead of just cp so that the modification time
70         of the original files are used.
71
72 2006-11-02  Adam Roben  <aroben@apple.com>
73
74         Reviewed by Tim H, landed by Anders.
75
76         Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10840
77         REGRESSION: Shadow of file upload button is clipped
78
79         * rendering/RenderFileUploadControl.cpp:
80         (WebCore::RenderFileUploadControl::paintObject): Add 2px to the clip
81         height to keep from clipping in the shadow
82
83 2006-11-02  Eike Preuss  <mail@eikepreuss.de>
84
85         Reviewed by Maciej, landed by Anders.
86
87         * platform/qt/ScrollViewQt.cpp: Fix translation of coordinates between
88         content and window. ScrollViewQt already receives correct content
89         coordinates from QScrollArea.
90         (WebCore::ScrollView::contentsToWindow):
91         (WebCore::ScrollView::windowToContents):
92
93 2006-11-02  Simon Hausmann  <hausmann@kde.org>
94
95         Reviewed by Maciej, landed by Anders
96
97         * CMakeLists.txt: Make linkage against KDE libraries conditional
98         * platform/network/qt/ResourceHandleManager.cpp: Added a simple
99           Qt base resource handler that supports only requests to the
100           local filesystem. Used when compiling without KDE support.
101           ResourceHandleManager.cpp/h are to be split up into ResourceHandleManagerKDE
102           and ResourceHandleManagerQt in the future, as well as QtJob.cpp/h.
103         (WebCore::QtJob::QtJob):
104         (WebCore::QtJob::timerEvent):
105         (WebCore::ResourceHandleManager::ResourceHandleManager):
106         (WebCore::ResourceHandleManager::~ResourceHandleManager):
107         (WebCore::ResourceHandleManager::self):
108         (WebCore::ResourceHandleManager::remove):
109         (WebCore::ResourceHandleManager::add):
110         (WebCore::ResourceHandleManager::cancel):
111         (WebCore::ResourceHandleManager::deliverJobData):
112         * platform/network/qt/ResourceHandleManager.h:
113         * platform/qt/FrameQtClient.cpp:
114         (WebCore::FrameQtClientDefault::runJavaScriptAlert):
115         (WebCore::FrameQtClientDefault::runJavaScriptConfirm):
116         (WebCore::FrameQtClientDefault::runJavaScriptPrompt):
117         * platform/qt/LoaderFunctionsQt.cpp: Use the Qt messagebox and
118           input dialog functions when compiling without KDE support
119         (WebCore::ServeSynchronousRequest):
120
121 2006-11-02  David Carson  <dacarson@gmail.com>
122
123         Reviewed by Geoff, landed by Anders.
124
125         Fix for: http://bugs.webkit.org/show_bug.cgi?id=11471
126         Initializing variable in constructor.
127
128         * page/FramePrivate.h:
129         (WebCore::FramePrivate::FramePrivate):
130
131 2006-11-02  Anders Carlsson  <acarlsson@apple.com>
132
133         Reviewed by Geoff.
134
135         Use CFMutableURLRequestRef instead of CFHTTPMessageRef since not all URL requests are http requests.
136         
137         * platform/network/cf/ResourceHandleCFNet.cpp:
138         (WebCore::addHeadersFromHashMap):
139         Don't set all headers at once since that clears any previous headers set.
140         
141         (WebCore::ResourceHandle::start):
142
143 2006-11-02  Adele Peterson  <adele@apple.com>
144
145         Reviewed by Mitz and Geoff.
146
147         - Fix for:
148         <rdar://problem/4650271> REGRESSION(NativeTextArea): Textareas don't get scrollbars when text gets too big for content area (10105)
149         <rdar://problem/4650813> REGRESSION(tiger-leopard): typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
150         <rdar://problem/4658779> REGRESSION: Text selection is weird in textareas in Trac wiki editing pages
151
152         Test: fast/forms/textarea-scrollbar.html
153
154         To avoid some of our flexbox bugs for textareas, we're moving the text controls back to RenderBlock.  This should make them
155         a lot more stable.  In the future, when we've worked out more of the flexbox kinks, we may want to consider moving them back.
156
157         * rendering/RenderTextControl.h: Convert text controls back to RenderBlock instead of RenderFlexibleBox.
158         * rendering/RenderTextControl.cpp: 
159         (WebCore::RenderTextControl::RenderTextControl):
160         (WebCore::RenderTextControl::setStyle):
161         (WebCore::RenderTextControl::createDivStyle):
162         (WebCore::RenderTextControl::updateFromElement):
163         (WebCore::RenderTextControl::calcHeight):
164         (WebCore::RenderTextControl::baselinePosition):
165         (WebCore::RenderTextControl::nodeAtPoint):
166         (WebCore::RenderTextControl::layout): Set the inner div's height explicitly before doing a normal layout.
167         (WebCore::RenderTextControl::scrollWidth):
168         (WebCore::RenderTextControl::scrollHeight):
169         (WebCore::RenderTextControl::scrollLeft):
170         (WebCore::RenderTextControl::scrollTop):
171
172         * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Make subtree layout optimization work for textareas.
173
174 2006-11-02  John Sullivan  <sullivan@apple.com>
175
176         Reviewed by Geoff Garen
177
178         * editing/Selection.cpp:
179         (WebCore::Selection::showTreeForThis):
180         this debugging method now displays start offset and end offset, at Darin's suggestion
181
182 2006-11-01  Justin Garcia  <justin.garcia@apple.com>
183
184         Reviewed by darin
185
186         <rdar://problem/4062865>
187         Copy/paste of a select element fails to include the options
188         
189         * editing/SelectionController.cpp:
190         (WebCore::SelectionController::modify): Added paragraphBoundary.
191         * editing/htmlediting.cpp:
192         (WebCore::canHaveChildrenForEditing): Added checks for input elements
193         and textareas.  Insertion operations would fail when performed just 
194         before/after one of these elements b/c the content would be put inside 
195         the element.
196         (WebCore::enclosingNodeWithTag): Fixed a problem when calling these in non
197         editable content, and made the code to stop at an root faster (don't check
198         isDescendantOf on every iteration).
199         (WebCore::enclosingNodeOfType): Ditto.
200         (WebCore::enclosingList): Ditto.
201         (WebCore::enclosingListChild): Ditto.  Added a FIXME, this function seems
202         inappropriately named.
203         * editing/markup.cpp:
204         (WebCore::startMarkup): Use the text node's value instead of its rendered
205         content for text nodes inside select elements.  One might also turn off
206         annotation when createMarkup enters a select element, but createMarkup
207         is iterative, not recursive, so doing so would be complicated.
208         (WebCore::createMarkup): Add markup for unrendered nodes if they are 
209         descendants of a select element.
210         * editing/visible_units.cpp:
211         (WebCore::startOfParagraph): Migrate to isBlock/enclosingBlock.  Fixes bug
212         where various replaced elements can't be copied when they are the only
213         thing selected.
214         (WebCore::endOfParagraph): Ditto.
215
216 2006-11-01  Oliver Hunt  <oliver@apple.com>
217
218         Reviewed by Adam.
219
220         Converting more or kcanvas/quartz from Obj-C to C++
221         Minor SVG updates
222         compatibility fixes
223
224         * WebCore.xcodeproj/project.pbxproj:
225         * kcanvas/device/KRenderingPaintServer.h:
226         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.cpp: Added.
227         (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
228         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: Removed.
229         * kcanvas/device/quartz/KRenderingPaintServerQuartz.cpp: Added.
230         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: Removed.
231         * kcanvas/device/quartz/QuartzSupport.h:
232         * ksvg2/css/SVGCSSStyleSelector.cpp:
233         * ksvg2/misc/KCanvasRenderingStyle.h:
234         * ksvg2/scripts/cssmakeprops:
235         * ksvg2/scripts/cssmakevalues:
236         * ksvg2/scripts/make_names.pl:
237         * ksvg2/svg/SVGAnimateColorElement.cpp:
238         * ksvg2/svg/SVGAnimateTransformElement.cpp:
239         * ksvg2/svg/SVGAnimationElement.cpp:
240         * ksvg2/svg/SVGMaskElement.cpp:
241         * ksvg2/svg/SVGPatternElement.cpp:
242         * ksvg2/svg/svgpathparser.cpp:
243         * platform/Path.cpp:
244         * platform/graphics/svg/SVGResourceImage.h:
245         * rendering/RenderPath.cpp:
246         * rendering/SVGRenderAsText.cpp:
247
248 2006-11-02  Mitz Pettel  <mitz@webkit.org>
249
250         Reviewed by Adele.
251
252         - Fix a regression from r17521: painting of and crash caused by tables
253           with collapsed borders
254
255         * rendering/RenderTable.cpp:
256         (WebCore::RenderTable::paint): Changed 'paintInfo' to 'info'. Prior to
257         r17521, 'paintInfo' was the local variable. Now 'info' is the local variable
258         and 'paintInfo' is the parameter, which we were accidently modifying.
259
260 2006-11-01  Adele Peterson  <adele@apple.com>
261
262         Reviewed by Mitz.
263
264         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11277
265         REGRESSION: Incomplete repaint of overflow areas when deleting
266
267         Restrict the repaint rect for overflow blocks after the height has been fully computed.
268         Also, adjust the repaint rect coordinates for the scroll offset.
269
270         * rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
271         * rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
272
273 2006-11-01  Sam Weinig  <sam.weinig@gmail.com>
274
275         Reviewed by Mitz.
276
277         Fix for http://bugs.webkit.org/show_bug.cgi?id=11474
278         Rename the "p" member variable of the PaintInfo struct to "context"
279
280         - Renames the 'p' and 'r' member variables of the PaintInfo struct to
281           'context' and 'rect' respectively.
282
283         - Assorted surrounding cleanups.
284
285         * rendering/EllipsisBox.cpp:
286         (WebCore::EllipsisBox::paint):
287         * rendering/EllipsisBox.h:
288         * rendering/InlineBox.cpp:
289         (WebCore::InlineBox::paint):
290         * rendering/InlineFlowBox.cpp:
291         (WebCore::InlineFlowBox::paint):
292         (WebCore::InlineFlowBox::paintBackground):
293         (WebCore::InlineFlowBox::paintBackgroundAndBorder):
294         (WebCore::InlineFlowBox::paintDecorations):
295         * rendering/InlineFlowBox.h:
296         * rendering/InlineRunBox.h:
297         * rendering/InlineTextBox.cpp:
298         (WebCore::InlineTextBox::paint):
299         * rendering/InlineTextBox.h:
300         * rendering/RenderBlock.cpp:
301         (WebCore::RenderBlock::paint):
302         (WebCore::RenderBlock::paintChildren):
303         (WebCore::RenderBlock::paintCaret):
304         (WebCore::RenderBlock::paintObject):
305         (WebCore::RenderBlock::paintFloats):
306         (WebCore::RenderBlock::paintEllipsisBoxes):
307         (WebCore::RenderBlock::paintSelection):
308         (WebCore::RenderBlock::fillSelectionGaps):
309         (WebCore::RenderBlock::fillInlineSelectionGaps):
310         (WebCore::RenderBlock::fillBlockSelectionGaps):
311         (WebCore::RenderBlock::fillHorizontalSelectionGap):
312         (WebCore::RenderBlock::fillVerticalSelectionGap):
313         (WebCore::RenderBlock::fillLeftSelectionGap):
314         (WebCore::RenderBlock::fillRightSelectionGap):
315         * rendering/RenderBox.cpp:
316         (WebCore::RenderBox::paint):
317         (WebCore::RenderBox::paintRootBoxDecorations):
318         (WebCore::RenderBox::paintBoxDecorations):
319         * rendering/RenderBox.h:
320         * rendering/RenderButton.cpp:
321         (WebCore::RenderButton::paintObject):
322         * rendering/RenderFieldset.cpp:
323         (WebCore::RenderFieldset::paintBoxDecorations):
324         * rendering/RenderFileUploadControl.cpp:
325         (WebCore::RenderFileUploadControl::paintObject):
326         * rendering/RenderFlow.cpp:
327         (WebCore::RenderFlow::continuationBefore):
328         (WebCore::RenderFlow::addChildWithContinuation):
329         (WebCore::RenderFlow::addChild):
330         (WebCore::RenderFlow::attachLineBox):
331         (WebCore::RenderFlow::destroy):
332         (WebCore::RenderFlow::dirtyLinesFromChangedChild):
333         (WebCore::RenderFlow::dirtyLineBoxes):
334         (WebCore::RenderFlow::createInlineBox):
335         (WebCore::RenderFlow::paintLines):
336         (WebCore::RenderFlow::getAbsoluteRepaintRect):
337         (WebCore::RenderFlow::lowestPosition):
338         (WebCore::RenderFlow::rightmostPosition):
339         (WebCore::RenderFlow::leftmostPosition):
340         (WebCore::RenderFlow::caretRect):
341         (WebCore::RenderFlow::addFocusRingRects):
342         (WebCore::RenderFlow::paintOutline):
343         (WebCore::RenderFlow::paintOutlineForLine):
344         * rendering/RenderForeignObject.cpp:
345         (WebCore::RenderForeignObject::paint):
346         * rendering/RenderHTMLCanvas.cpp:
347         (WebCore::RenderHTMLCanvas::paint):
348         * rendering/RenderImage.cpp:
349         (WebCore::RenderImage::paint):
350         * rendering/RenderLayer.cpp:
351         (WebCore::RenderLayer::paintLayer):
352         * rendering/RenderListBox.cpp:
353         (WebCore::RenderListBox::paintObject):
354         (WebCore::RenderListBox::paintScrollbar):
355         (WebCore::RenderListBox::paintItemForeground):
356         (WebCore::RenderListBox::paintItemBackground):
357         * rendering/RenderListMarker.cpp:
358         (WebCore::RenderListMarker::paint):
359         * rendering/RenderMenuList.cpp:
360         (WebCore::RenderMenuList::paintObject):
361         * rendering/RenderObject.cpp:
362         (WebCore::RenderObject::paint):
363         * rendering/RenderObject.h:
364         (WebCore::RenderObject::PaintInfo::PaintInfo):
365         (WebCore::RenderObject::paintBoxDecorations):
366         (WebCore::RenderObject::paintingRootForChildren):
367         (WebCore::RenderObject::shouldPaintWithinRoot):
368         (WebCore::RenderObject::printBoxDecorations):
369         * rendering/RenderPath.cpp:
370         (WebCore::RenderPath::paint):
371         * rendering/RenderReplaced.cpp:
372         (WebCore::RenderReplaced::shouldPaint):
373         * rendering/RenderSVGContainer.cpp:
374         (WebCore::RenderSVGContainer::paint):
375         * rendering/RenderSVGContainer.h:
376         * rendering/RenderSVGImage.cpp:
377         (WebCore::RenderSVGImage::paint):
378         * rendering/RenderSVGText.cpp:
379         (WebCore::RenderSVGText::paint):
380         * rendering/RenderSVGText.h:
381         (WebCore::RenderSVGText::renderName):
382         * rendering/RenderTable.cpp:
383         (WebCore::RenderTable::paint):
384         (WebCore::RenderTable::paintBoxDecorations):
385         * rendering/RenderTable.h:
386         * rendering/RenderTableCell.cpp:
387         (WebCore::RenderTableCell::paint):
388         (WebCore::RenderTableCell::paintBackgroundsBehindCell):
389         (WebCore::RenderTableCell::paintBoxDecorations):
390         * rendering/RenderTableCell.h:
391         * rendering/RenderTableRow.cpp:
392         (WebCore::RenderTableRow::paint):
393         * rendering/RenderTableRow.h:
394         * rendering/RenderTableSection.cpp:
395         (WebCore::RenderTableSection::paint):
396         * rendering/RenderTableSection.h:
397         (WebCore::RenderTableSection::getBaseline):
398         (WebCore::RenderTableSection::setNeedCellRecalc):
399         * rendering/RenderText.h:
400         (WebCore::RenderText::renderName):
401         (WebCore::RenderText::paint):
402         (WebCore::RenderText::element):
403         * rendering/RenderTheme.cpp:
404         (WebCore::RenderTheme::paint):
405         (WebCore::RenderTheme::paintBorderOnly):
406         (WebCore::RenderTheme::paintDecorations):
407         * rendering/RenderTheme.h:
408         (WebCore::RenderTheme::RenderTheme):
409         (WebCore::RenderTheme::~RenderTheme):
410         (WebCore::RenderTheme::controlSupportsTints):
411         (WebCore::RenderTheme::adjustRepaintRect):
412         (WebCore::RenderTheme::themeChanged):
413         (WebCore::RenderTheme::supportsHover):
414         (WebCore::RenderTheme::paintCheckbox):
415         (WebCore::RenderTheme::setCheckboxSize):
416         (WebCore::RenderTheme::paintRadio):
417         (WebCore::RenderTheme::setRadioSize):
418         (WebCore::RenderTheme::paintButton):
419         (WebCore::RenderTheme::setButtonSize):
420         (WebCore::RenderTheme::paintTextField):
421         (WebCore::RenderTheme::paintTextArea):
422         (WebCore::RenderTheme::paintMenuList):
423         (WebCore::RenderTheme::paintMenuListButton):
424         * rendering/RenderThemeMac.mm:
425         (WebCore::RenderThemeMac::paintCheckbox):
426         (WebCore::RenderThemeMac::paintRadio):
427         (WebCore::RenderThemeMac::paintButton):
428         (WebCore::RenderThemeMac::paintTextField):
429         (WebCore::RenderThemeMac::paintTextArea):
430         (WebCore::RenderThemeMac::paintMenuList):
431         (WebCore::RenderThemeMac::paintMenuListButtonGradients):
432         (WebCore::RenderThemeMac::paintMenuListButton):
433         * rendering/RenderView.cpp:
434         (WebCore::RenderView::paint):
435         (WebCore::RenderView::paintBoxDecorations):
436         * rendering/RenderView.h:
437         * rendering/RenderWidget.cpp:
438         (WebCore::RenderWidget::paint):
439         * rendering/RenderWidget.h:
440         (WebCore::RenderWidget::isWidget):
441         * rendering/RootInlineBox.cpp:
442         (WebCore::RootInlineBox::paintEllipsisBox):
443         (WebCore::RootInlineBox::paintCustomHighlight):
444         (WebCore::RootInlineBox::paint):
445         (WebCore::RootInlineBox::fillLineSelectionGap):
446         * rendering/RootInlineBox.h:
447         * rendering/SVGInlineFlowBox.cpp:
448         (WebCore::paintSVGInlineFlow):
449
450 2006-11-01  Anders Carlsson  <acarlsson@apple.com>
451
452         Reviewed by Oliver, Brady.
453
454         * platform/network/ResourceResponse.h:
455         (WebCore::ResourceResponse::setLastModifiedDate):
456         (WebCore::ResourceResponse::lastModifiedDate):
457         Add getters and setters for last modified dadte.
458         
459         * platform/network/cf/ResourceResponseCFNet.cpp:
460         (WebCore::getResourceResponse):
461         Fetch the last modified date. Add correct offset to expired date.
462
463 2006-11-01  David Kilzer  <ddkilzer@kilzer.net>
464
465         Reviewed by Mitz.
466
467         Added missing "break;" statement in switch statement from r17493.
468
469         Bug 11442: [CSS 3] support for cursor: all-scroll
470         http://bugs.webkit.org/show_bug.cgi?id=11442
471
472         * css/CSSComputedStyleDeclaration.cpp:
473         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
474
475 2006-10-31  Mitz Pettel  <mitz@webkit.org>
476
477         Reviewed by Maciej.
478
479         - fix image dragging
480
481         This is covered by editing/selection/drag-to-contenteditable-iframe.html
482
483         * rendering/HitTestResult.cpp:
484         (WebCore::HitTestResult::altDisplayString): Changed imageTag to imgTag, for
485         HTML IMG elements.
486         (WebCore::HitTestResult::absoluteImageURL): Ditto.
487
488 2006-10-31  Beth Dakin  <bdakin@apple.com>
489
490         Reviewed by Maciej.
491
492         This adds the back-end of the remaining WebElementDictionary 
493         functions into HitTestResult.
494
495         * WebCore.exp:
496         * rendering/HitTestResult.cpp:
497         (WebCore::HitTestResult::title):
498         (WebCore::displayString): This is nearly identical to the 
499         displayString() defined in DOMInternal.mm except that it returns a 
500         String instead of an NSString. The old code path used the 
501         DOMInternal method, so I made a new one here for the new code path.
502         (WebCore::HitTestResult::altDisplayString):
503         (WebCore::HitTestResult::image):
504         (WebCore::HitTestResult::absoluteImageURL):
505         (WebCore::HitTestResult::absoluteLinkURL):
506         (WebCore::HitTestResult::titleDisplayString):
507         (WebCore::HitTestResult::textContent):
508         * rendering/HitTestResult.h:
509
510 2006-10-31  John Sullivan  <sullivan@apple.com>
511
512         * bridge/mac/FrameMac.mm:
513         (WebCore::FrameMac::markMisspellings):
514         Tiger build fix: added an #ifndef BUILDING_ON_TIGER where one was needed.
515
516 2006-10-31  John Sullivan  <sullivan@apple.com>
517
518         Reviewed by Maciej
519         
520         - fixed <rdar://problem/4804627> ToolTips do not appear for grammar suggestions
521         
522         The foundation of this was in my last checkin. This checkin is all about displaying
523         the correct string in the toolTip.
524
525         * dom/DocumentMarker.h:
526         New description field in this struct.
527
528         * bridge/mac/FrameMac.mm:
529         (WebCore::FrameMac::advanceToNextMisspelling):
530         When adding a grammar marker, supply the appropriate description. Also, added a comment
531         about the remaining work to make grammar checking return sensible answers.
532         (WebCore::FrameMac::markMisspellings):
533         ditto (yes, still needs some refactoring to minimize duplicated code)
534         
535         * dom/Document.h:
536         * dom/Document.cpp:
537         (WebCore::Document::addMarker):
538         Now takes an optional description string
539         (WebCore::Document::markerContainingPoint):
540         New function, returns a pointer to the (first) marker of the specified type whose rect 
541         contains the specified point, or 0 if none.
542         
543         * rendering/HitTestResult.cpp:
544         (WebCore::HitTestResult::spellingToolTip):
545         Replaced hardwired string placeholder implementation with code that uses markerContainingPoint
546         and gets the description from the marker.
547
548 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
549
550         Reviewed by Maciej.
551         
552         Fixed crash resulting from Darin's last patch to remove BrowserExtension.
553
554         * loader/mac/FrameLoaderMac.mm:
555         (WebCore::FrameLoader::createWindow):
556         * manual-tests/window-open-features-parsing.html: Updated for clarity.
557
558 2006-10-31  Geoffrey Garen  <ggaren@apple.com>
559
560         Reviewed by Alice.
561
562         Moved some Editing code from WebKit, the bridge, and WebCore::Frame down 
563         to WebCore::Editor.
564         
565         Layout tests pass.
566         
567         Renamed "may*" to "can*" because "can" is more accurate (these functions
568         aren't just about permission) and it matches WebKit.
569
570         (WebCore::FrameMac::handleMouseMoveEvent): Directly test for dragging in a 
571         password field. Now that WebCore fully implements canCopy(), it doesn't just
572         mean "the selection is not in a password field" anymore.
573         (-[WebCoreFrameBridge _shouldAllowAccessFrom:]): Removed this #ifed-out code. 
574         The fact that it's not called anymore may represent a security issue, but I
575         don't see how commented-out code will help reveal the issue, and the
576         bridge is going away, anyway.
577         * editing/SelectionController.h: Changed selection() calls to references
578         to m_sel, to match the rest of the file.
579
580 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
581
582         Reviewed by harrison
583         
584         <rdar://problem/4711063>
585         Pasting 10K lines into Mail/Blot takes ~7sec, in TextEdit it takes ~1.5sec
586
587         * editing/ReplaceSelectionCommand.cpp:
588         (WebCore::ReplacementFragment::ReplacementFragment): Don't do the test
589         insertion and plain text string creation unless we need the string
590         for a BeforeTextInserted event handler or for a plain text only region.
591         (WebCore::ReplacementFragment::removeInterchangeNodes): Added, moved
592         code here from ReplacementFragment's constructor.
593         (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Added a
594         FIXME.
595         * editing/ReplaceSelectionCommand.h:
596
597 2006-10-31  Ada Chan  <adachan@apple.com>
598
599         Reviewed by Adam
600
601         Correct forward declarations of the HitTestRequest struct.
602
603         * rendering/EllipsisBox.h:
604         * rendering/InlineBox.h:
605         * rendering/InlineFlowBox.h:
606         * rendering/RenderLayer.h:
607         * rendering/RenderObject.h:
608
609 2006-10-31  John Sullivan  <sullivan@apple.com>
610
611         Reviewed by Beth and Adam
612
613         Support for displaying tooltips for bad grammar. Currently this always displays the same tooltip; 
614         next I'll make it use a string that's relevant for a specific grammar error.
615
616         * WebCore.exp:
617         export symbol for spellingToolTip function
618         
619         * rendering/HitTestResult.h:
620         * rendering/HitTestResult.cpp:
621         (WebCore::HitTestResult::spellingToolTip):
622         new function, returns the string to be used in a tool tip that describes the questionable grammar
623         
624         * rendering/InlineTextBox.h:
625         * rendering/InlineTextBox.cpp:
626         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
627         now takes a style and font, needed to compute the rect representing the range containing
628         questionable grammar. Computes the rect and associates it with the marker.
629         (WebCore::InlineTextBox::paintDocumentMarkers):
630         Pass in the style and font now needed by paintSpellingOrGrammarMarker
631
632 2006-10-31  Adele Peterson  <adele@apple.com>
633
634         Removed commented out variable from last checkin.
635
636         * html/HTMLSelectElement.cpp:
637         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
638
639 2006-10-31  Brady Eidson  <beidson@apple.com>
640
641         Build fix (unused variable in release builds)
642
643         * html/HTMLSelectElement.cpp:
644         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
645
646 2006-10-31  Adele Peterson  <adele@apple.com>
647
648         Reviewed by Adam.
649
650         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11127 NativeListBox: arrow and drag selection should pivot around one list item
651         and http://bugs.webkit.org/show_bug.cgi?id=11173 REGRESSION (NativeListBox): Shift-clicking items in list box doesn't expand the current selection
652         and http://bugs.webkit.org/show_bug.cgi?id=11417 REGRESSION: onchange does not fire for list-style select elements
653
654         Tests: 
655         * LayoutTests/fast/forms/listbox-selection.html
656         * LayoutTests/fast/forms/listbox-onchange.html
657
658         * html/HTMLSelectElement.h: Added m_selectedListIndexBase and m_selectedListIndexExtent to track indices for the active selection in progress.
659           Added 2 vectors to cache selection state.  One is kept so that the previous selection state can be restored as the active selection grows and shrinks.
660           And one for onChange, that is updated after onChange is fired.
661           Added m_activeSelectionState to keep track of whether the current drag selection is selecting or deselecting.
662  
663         * html/HTMLSelectElement.cpp:
664         (WebCore::HTMLSelectElement::HTMLSelectElement): Initialized new variables.
665         (WebCore::HTMLSelectElement::setSelectedIndex): If needed, initialize m_selectedListIndexBase and m_selectedListIndexExtent.
666         (WebCore::HTMLSelectElement::dispatchBlurEvent): Only fire the onChange event here for menu lists.
667         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Updates base and extent variables for mouse and key events.
668         (WebCore::HTMLSelectElement::setBase): Added. Also caches the selection state.
669         (WebCore::HTMLSelectElement::setExtent): Added.
670         (WebCore::HTMLSelectElement::updateListBoxSelection): Added.
671         (WebCore::HTMLSelectElement::listBoxOnChange): Added.
672
673         * rendering/RenderListBox.cpp:
674         (WebCore::RenderListBox::updateFromElement): Only scroll to reveal the first index if both the first and last indices aren't visible.
675         (WebCore::RenderListBox::listIndexAtOffset): Added.  Replaces optionAtPoint, which is no longer used.
676         (WebCore::RenderListBox::autoscroll): Now sets the selection using the select's base and extent.
677         (WebCore::RenderListBox::stopAutoscroll): Added.  Tells the select element to fire onChange.  This is needed because the autoscroll can end from a mouseUp
678          outside of the list box, and the select element won't get a mouseUp event directly.  But the frame will stop the autoscroll at that point, and now we can
679          notify the select element from here.
680         (WebCore::RenderListBox::scrollToRevealElementAtListIndex): Checks new listIndexIsVisible method.
681         (WebCore::RenderListBox::listIndexIsVisible): Added.
682         (WebCore::RenderListBox::valueChanged): Removed unnecessary printf.
683
684         * page/Frame.cpp: (WebCore::Frame::stopAutoscrollTimer): Added rendererIsBeingDestroyed argument, so when the renderer calls this during destruction, 
685         we don't try to use the pointer to that renderer to call stopAutoscroll.  This is done so a renderer that's still alive has a chance to do some cleanup after autoscroll.
686         * rendering/RenderListBox.h: (WebCore::RenderListBox::shouldAutoscroll): Always returns true now, since we're also updating selection from the autoscroll timer.
687         * rendering/RenderObject.h: (WebCore::RenderObject::stopAutoscroll): Added.
688         * rendering/RenderObject.cpp: (WebCore::RenderObject::destroy): Calls stopAutoscrollTimer with rendererIsBeingDestroyed argument.
689
690 2006-10-31  Beth Dakin  <bdakin@apple.com>
691
692         Forgot to check this in a minute ago. Oops!! Thanks Mitz!
693
694         * rendering/HitTestRequest.h: Added.
695         (WebCore::HitTestRequest::HitTestRequest):
696
697 2006-10-31  Beth Dakin  <bdakin@apple.com>
698
699         Reviewed by Maciej.
700
701         Fix for http://bugs.webkit.org/show_bug.cgi?id=11461 HitTestResult 
702         should be split into HitTestRequest and HitTestResult
703
704         This patch creates a new struct called HitTestRequest that holds 
705         the three boolean values (readonly, active, and mouseMove) that 
706         were formerly a part of HitTestResult. All hitTest() and 
707         nodeAtPoint() functions now take a HitTestRequest in addition to 
708         the HitTestResult.
709
710         * WebCore.exp:
711         * WebCore.xcodeproj/project.pbxproj:
712         * bridge/mac/FrameMac.mm:
713         (WebCore::FrameMac::eventMayStartDrag):
714         (WebCore::FrameMac::handleMouseMoveEvent):
715         * bridge/mac/WebCoreAXObject.mm:
716         (-[WebCoreAXObject doAXTextMarkerForPosition:]):
717         (-[WebCoreAXObject accessibilityHitTest:]):
718         * dom/Document.cpp:
719         (WebCore::Document::elementFromPoint):
720         (WebCore::Document::prepareMouseEvent):
721         * editing/SelectionController.cpp:
722         (WebCore::SelectionController::contains):
723         * page/Frame.cpp:
724         (WebCore::Frame::hitTestResultAtPoint):
725         * page/FrameView.cpp:
726         (WebCore::FrameView::handleWheelEvent):
727         * rendering/EllipsisBox.cpp:
728         (WebCore::EllipsisBox::nodeAtPoint):
729         * rendering/EllipsisBox.h:
730         * rendering/HitTestResult.cpp:
731         (WebCore::HitTestResult::HitTestResult):
732         (WebCore::HitTestResult::operator=):
733         * rendering/HitTestResult.h:
734         * rendering/InlineBox.cpp:
735         (WebCore::InlineBox::nodeAtPoint):
736         * rendering/InlineBox.h:
737         * rendering/InlineFlowBox.cpp:
738         (WebCore::InlineFlowBox::nodeAtPoint):
739         * rendering/InlineFlowBox.h:
740         * rendering/InlineTextBox.cpp:
741         (WebCore::InlineTextBox::nodeAtPoint):
742         * rendering/InlineTextBox.h:
743         * rendering/RenderBlock.cpp:
744         (WebCore::RenderBlock::nodeAtPoint):
745         * rendering/RenderBlock.h:
746         * rendering/RenderBox.cpp:
747         (WebCore::RenderBox::nodeAtPoint):
748         * rendering/RenderBox.h:
749         * rendering/RenderFlow.cpp:
750         (WebCore::RenderFlow::hitTestLines):
751         * rendering/RenderFlow.h:
752         * rendering/RenderForeignObject.cpp:
753         (WebCore::RenderForeignObject::nodeAtPoint):
754         * rendering/RenderForeignObject.h:
755         * rendering/RenderFrameSet.cpp:
756         (WebCore::RenderFrameSet::nodeAtPoint):
757         * rendering/RenderFrameSet.h:
758         * rendering/RenderImage.cpp:
759         (WebCore::RenderImage::nodeAtPoint):
760         * rendering/RenderImage.h:
761         * rendering/RenderInline.cpp:
762         (WebCore::RenderInline::nodeAtPoint):
763         * rendering/RenderInline.h:
764         * rendering/RenderLayer.cpp:
765         (WebCore::RenderLayer::autoscroll):
766         (WebCore::RenderLayer::hitTest):
767         (WebCore::RenderLayer::hitTestLayer):
768         (WebCore::RenderLayer::updateHoverActiveState):
769         * rendering/RenderLayer.h:
770         * rendering/RenderObject.cpp:
771         (WebCore::RenderObject::hitTest):
772         (WebCore::RenderObject::nodeAtPoint):
773         * rendering/RenderObject.h:
774         * rendering/RenderPath.cpp:
775         (WebCore::RenderPath::nodeAtPoint):
776         * rendering/RenderPath.h:
777         * rendering/RenderSVGImage.cpp:
778         (WebCore::RenderSVGImage::nodeAtPoint):
779         * rendering/RenderSVGImage.h:
780         * rendering/RenderSVGText.cpp:
781         (WebCore::RenderSVGText::nodeAtPoint):
782         * rendering/RenderSVGText.h:
783         * rendering/RenderTableRow.cpp:
784         (WebCore::RenderTableRow::nodeAtPoint):
785         * rendering/RenderTableRow.h:
786         * rendering/RenderTableSection.cpp:
787         (WebCore::RenderTableSection::nodeAtPoint):
788         * rendering/RenderTableSection.h:
789         * rendering/RenderText.h:
790         (WebCore::RenderText::nodeAtPoint):
791         * rendering/RenderTextControl.cpp:
792         (WebCore::RenderTextControl::nodeAtPoint):
793         * rendering/RenderTextControl.h:
794         * rendering/RootInlineBox.cpp:
795         (WebCore::RootInlineBox::nodeAtPoint):
796         * rendering/RootInlineBox.h:
797
798 2006-10-31  Lars Naesbye Christensen <larsnaesbye@stud.ku.dk>
799
800         Reviewed by Maciej.
801
802         Bug 11442: [CSS 3] support for cursor: all-scroll
803         http://bugs.webkit.org/show_bug.cgi?id=11442
804
805         * css/CSSComputedStyleDeclaration.cpp:
806         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
807         * css/CSSValueKeywords.in:
808         * css/cssparser.cpp:
809         (WebCore::CSSParser::parseValue):
810         * page/FrameView.cpp:
811         (WebCore::selectCursor):
812         * rendering/RenderStyle.h:
813
814 2006-10-31  Oliver Hunt  <oliver@apple.com>
815
816         Reviewed by Geoff.
817
818         Converting Obj-C++ to C++ in kcanvas
819
820         * WebCore.xcodeproj/project.pbxproj:
821         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
822         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
823         * kcanvas/device/quartz/KCanvasItemQuartz.cpp: Added.
824         * kcanvas/device/quartz/KCanvasItemQuartz.mm: Removed.
825         * kcanvas/device/quartz/KRenderingDeviceQuartz.cpp: Added.
826         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
827         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm: Removed.
828         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
829         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
830         * kcanvas/device/quartz/QuartzSupport.cpp: Added.
831         * kcanvas/device/quartz/QuartzSupport.h:
832         * kcanvas/device/quartz/QuartzSupport.mm: Removed.
833         * platform/graphics/svg/cg/SVGResourceClipperCg.cpp: Added.
834         (WebCore::SVGResourceClipper::applyClip):
835         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Removed.
836         * platform/graphics/svg/cg/SVGResourceImageCg.cpp: Added.
837         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Removed.
838
839 2006-10-31  Justin Garcia  <justin.garcia@apple.com>
840
841         Reviewed by harrison
842         
843         <rdar://problem/4808375>
844         REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) [11460}
845         
846         Completely back out r17276 because of performance issues.
847
848         * editing/TextIterator.cpp:
849         (WebCore::TextIterator::TextIterator):
850         (WebCore::TextIterator::advance):
851         (WebCore::TextIterator::handleTextNode):
852         (WebCore::TextIterator::handleTextBox):
853         (WebCore::TextIterator::handleReplacedElement):
854         (WebCore::TextIterator::handleNonTextNode):
855         (WebCore::TextIterator::exitNode):
856         (WebCore::TextIterator::emitCharacter):
857         (WebCore::TextIterator::range):
858         (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
859         (WebCore::SimplifiedBackwardsTextIterator::advance):
860         (WebCore::SimplifiedBackwardsTextIterator::handleTextNode):
861         (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement):
862         (WebCore::SimplifiedBackwardsTextIterator::emitCharacter):
863         (WebCore::SimplifiedBackwardsTextIterator::emitNewline):
864         (WebCore::SimplifiedBackwardsTextIterator::range):
865         (WebCore::CharacterIterator::range):
866         (WebCore::TextIterator::rangeFromLocationAndLength):
867         * editing/TextIterator.h:
868         (WebCore::TextIterator::atEnd):
869         (WebCore::SimplifiedBackwardsTextIterator::atEnd):
870
871 2006-10-31  Darin Adler  <darin@apple.com>
872
873         Reviewed by Brady.
874
875         - got "action dictionary" code out of FrameLoader,
876           replacing with a class called NavigationAction
877
878         * loader/DocumentLoader.h: Changed m_triggeringAction to a NavigationAction.
879         * loader/mac/DocumentLoaderMac.mm:
880         (WebCore::DocumentLoader::triggeringAction): Ditto.
881         (WebCore::DocumentLoader::setTriggeringAction): Ditto.
882
883         * loader/FrameLoader.h: Changed action parameters to NavigationAction.
884
885         * loader/FrameLoaderClient.h: Changed action parameters to NavigationAction.
886         Removed elementForEvent.
887         * loader/mac/FrameLoaderMac.mm:
888         (WebCore::FrameLoader::load): Ditto.
889         (WebCore::FrameLoader::reload): Ditto.
890         (WebCore::FrameLoader::checkNewWindowPolicy): Ditto.
891         (WebCore::FrameLoader::checkNavigationPolicy): Ditto.
892         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): Ditto.
893         (WebCore::FrameLoader::post): Ditto.
894
895         * loader/NavigationAction.h: Added.
896         * loader/NavigationAction.cpp: Added.
897         * loader/mac/NavigationActionMac.mm: Added.
898
899         * loader/mac/MainResourceLoaderMac.mm: Fixed copyright.
900
901         * WebCore.xcodeproj/project.pbxproj: Updated for new files.
902         * WebCore.exp: Updated.
903
904 2006-10-31  Steve Falkenburg  <sfalken@apple.com>
905
906         Reviewed by Adam.
907
908         Build fix
909
910         * platform/win/CookieJarWin.cpp:
911         (WebCore::cookies):
912
913 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
914
915         Reviewed by Maciej. Landed by Adam.
916
917         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11463
918
919         Move KCanvasTreeDebug into rendering, named as SVGRenderTreeAsText.*,
920         as dicussed with Dave. Also kill the outdated DESIGN document.
921
922         * CMakeLists.txt:
923         * WebCore.xcodeproj/project.pbxproj:
924         * kcanvas/DESIGN: Removed.
925         * kcanvas/KCanvasFilters.cpp:
926         * kcanvas/KCanvasTreeDebug.cpp: Moved to rendering/SVGRenderTreeAsText
927         * kcanvas/KCanvasTreeDebug.h: Ditto.
928         * kcanvas/device/KRenderingPaintServerGradient.cpp:
929         * kcanvas/device/KRenderingPaintServerPattern.cpp:
930         * kcanvas/device/KRenderingPaintServerSolid.cpp:
931         * platform/graphics/svg/SVGResourceClipper.cpp:
932         * rendering/RenderTreeAsText.cpp:
933         * rendering/SVGRenderTreeAsText.cpp: Added.
934         * rendering/SVGRenderTreeAsText.h: Added.
935         (WebCore::operator<<):
936
937 2006-10-31  MorganL  <morganl.webkit@yahoo.com>
938
939         Reviewed by Maciej.
940
941         Fixes http://bugs.webkit.org/show_bug.cgi?id=11286
942         Includes some CRLF -> LF fixups.
943
944         * platform/win/CookieJarWin.cpp:
945         (WebCore::cookies):
946
947 2006-10-31  Adam Roben  <aroben@apple.com>
948
949         Reviewed by Steve.
950
951         Fix some incorrect forward declarations.
952
953         * loader/FrameLoader.h:
954         * page/Frame.h:
955
956 2006-10-31  Darin Adler  <darin@apple.com>
957
958         * WebCore.xcodeproj/project.pbxproj: Change GraphicsTypes.h to a private header to
959         try to fix the build on the buildbot.
960
961 2006-10-31  Darin Adler  <darin@apple.com>
962
963         * bridge/mac/FrameMac.mm:
964         (WebCore::FrameMac::advanceToNextMisspelling): Build fix for release Tiger builds.
965         (WebCore::FrameMac::markMisspellings): Ditto.
966
967 2006-10-31  John Sullivan  <sullivan@apple.com>
968
969         * bridge/mac/FrameMac.mm:
970         (WebCore::FrameMac::advanceToNextMisspelling):
971         build fix: needed #ifndef BUILDING_ON_TIGER in one more place
972
973 2006-10-30  John Sullivan  <sullivan@apple.com>
974
975         Reviewed by Adam Roben
976         
977         - fixes <rdar://problem/4804614> Bad grammar ranges are not visibly marked
978         
979         This patch introduces much of the guts of grammar checking, though still not enough to actually
980         check grammar sensibly, due to:
981           
982         <rdar://problem/4811175> Many false reports of bad grammar appear, caused by insufficient 
983         context passed to grammar checker
984
985         * platform/Logging.h:
986         * platform/Logging.cpp:
987         new log channel SpellingAndGrammar
988
989         * bridge/mac/WebCorePageBridge.mm:
990         (initializeLoggingChannelsIfNecessary):
991         initialize new log channel
992
993         * bridge/mac/FrameMac.mm:
994         (WebCore::FrameMac::advanceToNextMisspelling):
995         Compute bad grammar range when computing misspelling range. Find first detailed grammar range from the
996         set NSSpellChecker determines. Compare it with misspelling range to see which is earliest (or shortest
997         in the event of a tie), and do further processing with that one (select range; create marker that
998         causes range to be visibly marked with a funky underline; update spelling panel appropriately).
999         (WebCore::FrameMac::markMisspellings):
1000         More or less the same types of changes as in advanceToNextMisspelling The loops are structured just 
1001         differently enough to make sharing code between these two functions a little tricky, so I decided to 
1002         save that for a later patch.
1003         
1004         (WebCore::FrameMac::respondToChangedSelection):
1005         remove grammar markers when we remove spelling markers        
1006
1007 2006-10-31  Nikolas Zimmermann <zimmermann@kde.org>
1008
1009         Reviewed by Mitz.
1010
1011         Fix Qt/Linux build with older gcc3.3.4.
1012
1013         * bindings/js/kjs_window.cpp:
1014         (KJS::WindowFunc::callAsFunction):
1015
1016 2006-10-31  Zack Rusin  <zack@kde.org>
1017
1018         Reviewed by Mitz.
1019
1020         Fix the Qt build after last nights changes.
1021
1022         * WebCore/platform/qt/FrameQt.cpp:
1023         * WebCore/platform/qt/EditorClientQt.h:
1024         * WebCore/platform/qt/EditorClientQt.cpp:
1025         * WebCore/platform/graphics/svg/qt/SVGResourceImageQt.cpp:
1026         * WebCore/platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
1027         * WebCore/CMakeLists.txt:
1028         * WebCore/kcanvas/device/qt/KRenderingDeviceQt.cpp:
1029         * WebKitQt/QtLauncher/CMakeLists.txt:
1030         * WebKitQt/WebKitPart/CMakeLists.txt:
1031
1032 2006-10-30  Darin Adler  <darin@apple.com>
1033
1034         Reviewed by Anders.
1035
1036         - remove BrowserExtension
1037
1038         * WebCore.vcproj/WebCore/WebCore.vcproj:
1039         * WebCore.xcodeproj/project.pbxproj:
1040         * bindings/js/kjs_window.cpp:
1041         (KJS::createNewWindow):
1042         (KJS::WindowFunc::callAsFunction):
1043         * bridge/BrowserExtension.h: Removed.
1044         * bridge/mac/BrowserExtensionMac.h: Removed.
1045         * bridge/mac/BrowserExtensionMac.mm: Removed.
1046         * bridge/mac/FrameMac.mm:
1047         (WebCore::FrameMac::FrameMac):
1048         (WebCore::FrameMac::submitForm):
1049         (WebCore::FrameMac::urlSelected):
1050         * bridge/win/BrowserExtensionWin.cpp: Removed.
1051         * bridge/win/BrowserExtensionWin.h: Removed.
1052         * bridge/win/FrameWin.cpp:
1053         (WebCore::FrameWin::FrameWin):
1054         * loader/FrameLoader.cpp:
1055         (WebCore::FrameLoader::createWindow):
1056         * loader/FrameLoader.h:
1057         * loader/icon/IconLoader.cpp:
1058         * loader/mac/FrameLoaderMac.mm:
1059         (WebCore::FrameLoader::safeLoad):
1060         (WebCore::FrameLoader::load):
1061         (WebCore::FrameLoader::createWindow):
1062         * page/Frame.cpp:
1063         (WebCore::Frame::urlSelected):
1064         (WebCore::Frame::requestFrame):
1065         (WebCore::Frame::submitForm):
1066         (WebCore::Frame::scheduleHistoryNavigation):
1067         (WebCore::Frame::redirectionTimerFired):
1068         * page/Frame.h:
1069         * page/FrameLoadRequest.h:
1070         (WebCore::FrameLoadRequest::FrameLoadRequest):
1071         (WebCore::FrameLoadRequest::isEmpty):
1072         (WebCore::FrameLoadRequest::resourceRequest):
1073         (WebCore::FrameLoadRequest::frameName):
1074         (WebCore::FrameLoadRequest::setFrameName):
1075         * page/FramePrivate.h:
1076         (WebCore::FramePrivate::FramePrivate):
1077         (WebCore::FramePrivate::~FramePrivate):
1078         * platform/gdk/BrowserExtensionGdk.h: Removed.
1079         * platform/gdk/FrameGdk.cpp:
1080         (WebCore::FrameGdk::FrameGdk):
1081         * platform/gdk/TemporaryLinkStubs.cpp:
1082         * platform/network/ResourceRequest.h:
1083         (WebCore::ResourceRequest::isEmpty):
1084
1085 2006-10-31  Nikolas Zimmermann  <zimmermann@kde.org>
1086
1087         Reviewed by Oliver.
1088
1089         Modified from original due to earlier reversion
1090
1091         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11436
1092
1093         Better SVG integration in WebKit, Part I.
1094
1095         The patch is mostly about creating a new platform/graphics directory, and
1096         moving the kcanvas resources (clipper/masker/marker) there (in svg budir),
1097         with a new name (KCanvasClipper -> SVGResourceClipper). Also fix several ownership
1098         issues, by using ref counting (the SVG classes now store RefPtrs to the resources).
1099
1100         KCanvasFilters is still left in kcanvas/ subdirectory, to be converted in a next patch.
1101         All details of the patch, and upcoming patches can be found in the bug report.
1102
1103         * CMakeLists.txt:
1104         * WebCore.xcodeproj/project.pbxproj:
1105         * graphics/svg/SVGResource.cpp: Removed.
1106         * graphics/svg/SVGResourceClipper.cpp: Removed.
1107         * graphics/svg/SVGResourceClipper.h: Removed.
1108         * graphics/svg/SVGResourceImage.h: Removed.
1109         * graphics/svg/SVGResourceListener.h: Removed.
1110         * graphics/svg/SVGResourceMarker.cpp: Removed.
1111         * graphics/svg/SVGResourceMarker.h: Removed.
1112         * graphics/svg/SVGResourceMasker.cpp: Removed.
1113         * graphics/svg/SVGResourceMasker.h: Removed.
1114         * kcanvas/KCanvasClipper.cpp: Removed.
1115         * kcanvas/KCanvasClipper.h: Removed.
1116         * kcanvas/KCanvasCreator.cpp: Removed.
1117         * kcanvas/KCanvasCreator.h: Removed.
1118         * kcanvas/KCanvasFilters.cpp:
1119         (WebCore::getFilterById):
1120         * kcanvas/KCanvasFilters.h:
1121         * kcanvas/KCanvasImage.h: Removed.
1122         * kcanvas/KCanvasMarker.cpp: Removed.
1123         * kcanvas/KCanvasMarker.h: Removed.
1124         * kcanvas/KCanvasMasker.cpp: Removed.
1125         * kcanvas/KCanvasMasker.h: Removed.
1126         * kcanvas/KCanvasResource.cpp: Removed.
1127         * kcanvas/KCanvasResource.h: Removed.
1128         * kcanvas/KCanvasResourceListener.h: Removed.
1129         * kcanvas/KCanvasTreeDebug.cpp:
1130         (WebCore::writeRenderResources):
1131         * kcanvas/device/KRenderingDevice.h:
1132         * kcanvas/device/KRenderingPaintServer.h:
1133         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
1134         * kcanvas/device/KRenderingPaintServerGradient.cpp:
1135         (WebCore::KRenderingPaintServerGradient::listener):
1136         (WebCore::KRenderingPaintServerGradient::setListener):
1137         * kcanvas/device/KRenderingPaintServerGradient.h:
1138         * kcanvas/device/KRenderingPaintServerPattern.cpp:
1139         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
1140         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
1141         (WebCore::KRenderingPaintServerPattern::tile):
1142         (WebCore::KRenderingPaintServerPattern::setTile):
1143         (WebCore::KRenderingPaintServerPattern::listener):
1144         (WebCore::KRenderingPaintServerPattern::setListener):
1145         * kcanvas/device/KRenderingPaintServerPattern.h:
1146         * kcanvas/device/KRenderingPaintServerSolid.h:
1147         * kcanvas/device/qt/KCanvasClipperQt.cpp: Removed.
1148         * kcanvas/device/qt/KCanvasClipperQt.h:
1149         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
1150         (WebCore::KRenderingDeviceQt::contextForImage):
1151         (WebCore::KRenderingDeviceQt::createResource):
1152         (WebCore::KRenderingDeviceQt::createPaintServer):
1153         * kcanvas/device/qt/KRenderingDeviceQt.h:
1154         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
1155         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
1156         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
1157         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
1158         * kcanvas/device/qt/RenderPathQt.h: Removed.
1159         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1160         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
1161         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
1162         * kcanvas/device/quartz/KCanvasMaskerQuartz.h: Removed.
1163         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm: Removed.
1164         * kcanvas/device/quartz/KCanvasResourcesQuartz.h: Removed.
1165         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm: Removed.
1166         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
1167         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1168         (WebCore::KRenderingDeviceQuartz::contextForImage):
1169         (WebCore::KRenderingDeviceQuartz::createPaintServer):
1170         (WebCore::KRenderingDeviceQuartz::createResource):
1171         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
1172         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
1173         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
1174         (WebCore::KRenderingPaintServerGradientQuartz::setup):
1175         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
1176         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
1177         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1178         (WebCore::patternCallback):
1179         (WebCore::KRenderingPaintServerPatternQuartz::setup):
1180         * kcanvas/device/quartz/QuartzSupport.mm:
1181         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1182         (WebCore::sharedSolidPaintServer):
1183         * ksvg2/svg/SVGClipPathElement.cpp:
1184         (WebCore::SVGClipPathElement::SVGClipPathElement):
1185         (WebCore::SVGClipPathElement::~SVGClipPathElement):
1186         (WebCore::SVGClipPathElement::canvasResource):
1187         * ksvg2/svg/SVGClipPathElement.h:
1188         * ksvg2/svg/SVGFEImageElement.cpp:
1189         * ksvg2/svg/SVGFilterElement.cpp:
1190         (WebCore::SVGFilterElement::SVGFilterElement):
1191         (WebCore::SVGFilterElement::~SVGFilterElement):
1192         (WebCore::SVGFilterElement::canvasResource):
1193         * ksvg2/svg/SVGFilterElement.h:
1194         * ksvg2/svg/SVGGradientElement.cpp:
1195         (WebCore::SVGGradientElement::SVGGradientElement):
1196         (WebCore::SVGGradientElement::~SVGGradientElement):
1197         (WebCore::SVGGradientElement::canvasResource):
1198         (WebCore::SVGGradientElement::resourceNotification):
1199         * ksvg2/svg/SVGGradientElement.h:
1200         * ksvg2/svg/SVGImageElement.cpp:
1201         * ksvg2/svg/SVGLinearGradientElement.cpp:
1202         (WebCore::SVGLinearGradientElement::buildGradient):
1203         * ksvg2/svg/SVGLinearGradientElement.h:
1204         * ksvg2/svg/SVGMarkerElement.cpp:
1205         (WebCore::SVGMarkerElement::SVGMarkerElement):
1206         (WebCore::SVGMarkerElement::~SVGMarkerElement):
1207         (WebCore::SVGMarkerElement::canvasResource):
1208         * ksvg2/svg/SVGMarkerElement.h:
1209         * ksvg2/svg/SVGMaskElement.cpp:
1210         (WebCore::SVGMaskElement::SVGMaskElement):
1211         (WebCore::SVGMaskElement::~SVGMaskElement):
1212         (WebCore::SVGMaskElement::drawMaskerContent):
1213         (WebCore::SVGMaskElement::canvasResource):
1214         * ksvg2/svg/SVGMaskElement.h:
1215         * ksvg2/svg/SVGPatternElement.cpp:
1216         (WebCore::SVGPatternElement::SVGPatternElement):
1217         (WebCore::SVGPatternElement::~SVGPatternElement):
1218         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
1219         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
1220         (WebCore::SVGPatternElement::canvasResource):
1221         * ksvg2/svg/SVGPatternElement.h:
1222         * ksvg2/svg/SVGRadialGradientElement.cpp:
1223         (WebCore::SVGRadialGradientElement::buildGradient):
1224         * ksvg2/svg/SVGRadialGradientElement.h:
1225         * ksvg2/svg/SVGStyledElement.h:
1226         (WebCore::SVGStyledElement::canvasResource):
1227         * platform/GraphicsContext.cpp: Removed.
1228         * platform/GraphicsContext.h: Removed.
1229         * platform/GraphicsTypes.cpp: Removed.
1230         * platform/GraphicsTypes.h: Removed.
1231         * platform/graphics/GraphicsContext.cpp:
1232         (WebCore::GraphicsContextState::GraphicsContextState):
1233         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
1234         (WebCore::GraphicsContext::createGraphicsContextPrivate):
1235         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
1236         (WebCore::GraphicsContext::save):
1237         (WebCore::GraphicsContext::restore):
1238         (WebCore::GraphicsContext::font):
1239         (WebCore::GraphicsContext::setFont):
1240         (WebCore::GraphicsContext::pen):
1241         (WebCore::GraphicsContext::setPen):
1242         (WebCore::GraphicsContext::setFillColor):
1243         (WebCore::GraphicsContext::fillColor):
1244         (WebCore::GraphicsContext::updatingControlTints):
1245         (WebCore::GraphicsContext::setUpdatingControlTints):
1246         (WebCore::GraphicsContext::setPaintingDisabled):
1247         (WebCore::GraphicsContext::paintingDisabled):
1248         (WebCore::GraphicsContext::drawImage):
1249         (WebCore::GraphicsContext::drawText):
1250         (WebCore::GraphicsContext::drawHighlightForText):
1251         (WebCore::GraphicsContext::initFocusRing):
1252         (WebCore::GraphicsContext::clearFocusRing):
1253         (WebCore::GraphicsContext::focusRingBoundingRect):
1254         (WebCore::GraphicsContext::addFocusRingRect):
1255         (WebCore::GraphicsContext::focusRingWidth):
1256         (WebCore::GraphicsContext::focusRingOffset):
1257         (WebCore::GraphicsContext::focusRingRects):
1258         (WebCore::GraphicsContext::drawTiledImage):
1259         * platform/graphics/GraphicsContext.h:
1260         * platform/graphics/GraphicsTypes.cpp:
1261         (WebCore::):
1262         (WebCore::parseCompositeOperator):
1263         (WebCore::compositeOperatorName):
1264         (WebCore::parseLineCap):
1265         (WebCore::lineCapName):
1266         (WebCore::parseLineJoin):
1267         (WebCore::lineJoinName):
1268         * platform/graphics/GraphicsTypes.h:
1269         (WebCore::):
1270         * platform/graphics/svg/SVGResource.cpp: Added.
1271         (WebCore::SVGResource::SVGResource):
1272         (WebCore::SVGResource::~SVGResource):
1273         (WebCore::SVGResource::invalidate):
1274         (WebCore::SVGResource::addClient):
1275         (WebCore::SVGResource::clients):
1276         (WebCore::SVGResource::idInRegistry):
1277         (WebCore::SVGResource::setIdInRegistry):
1278         (WebCore::SVGResource::externalRepresentation):
1279         (WebCore::getResourceById):
1280         (WebCore::getPaintServerById):
1281         (WebCore::operator<<):
1282         * platform/graphics/svg/SVGResource.h: Added.
1283         (WebCore::):
1284         (WebCore::SVGResource::isPaintServer):
1285         (WebCore::SVGResource::isFilter):
1286         (WebCore::SVGResource::isClipper):
1287         (WebCore::SVGResource::isMarker):
1288         (WebCore::SVGResource::isMasker):
1289         (WebCore::SVGResourceListener::~SVGResourceListener):
1290         * platform/graphics/svg/SVGResourceClipper.cpp: Added.
1291         (WebCore::SVGResourceClipper::SVGResourceClipper):
1292         (WebCore::SVGResourceClipper::~SVGResourceClipper):
1293         (WebCore::SVGResourceClipper::resetClipData):
1294         (WebCore::SVGResourceClipper::addClipData):
1295         (WebCore::SVGResourceClipper::clipData):
1296         (WebCore::SVGResourceClipper::externalRepresentation):
1297         (WebCore::operator<<):
1298         (WebCore::getClipperById):
1299         * platform/graphics/svg/SVGResourceClipper.h: Added.
1300         (WebCore::ClipDataList::addPath):
1301         (WebCore::SVGResourceClipper::isClipper):
1302         * platform/graphics/svg/SVGResourceImage.h: Added.
1303         * platform/graphics/svg/SVGResourceMarker.cpp: Added.
1304         (WebCore::SVGResourceMarker::SVGResourceMarker):
1305         (WebCore::SVGResourceMarker::~SVGResourceMarker):
1306         (WebCore::SVGResourceMarker::setMarker):
1307         (WebCore::SVGResourceMarker::setRef):
1308         (WebCore::SVGResourceMarker::draw):
1309         (WebCore::SVGResourceMarker::externalRepresentation):
1310         (WebCore::getMarkerById):
1311         * platform/graphics/svg/SVGResourceMarker.h: Added.
1312         (WebCore::SVGResourceMarker::refX):
1313         (WebCore::SVGResourceMarker::refY):
1314         (WebCore::SVGResourceMarker::setAngle):
1315         (WebCore::SVGResourceMarker::setAutoAngle):
1316         (WebCore::SVGResourceMarker::angle):
1317         (WebCore::SVGResourceMarker::setUseStrokeWidth):
1318         (WebCore::SVGResourceMarker::useStrokeWidth):
1319         (WebCore::SVGResourceMarker::isMarker):
1320         * platform/graphics/svg/SVGResourceMasker.cpp: Added.
1321         (WebCore::SVGResourceMasker::SVGResourceMasker):
1322         (WebCore::SVGResourceMasker::~SVGResourceMasker):
1323         (WebCore::SVGResourceMasker::setMask):
1324         (WebCore::SVGResourceMasker::mask):
1325         (WebCore::SVGResourceMasker::externalRepresentation):
1326         (WebCore::getMaskerById):
1327         * platform/graphics/svg/SVGResourceMasker.h: Added.
1328         (WebCore::SVGResourceMasker::isMasker):
1329         * platform/graphics/svg/cg/SVGResourceClipperCg.mm: Added.
1330         (WebCore::SVGResourceClipper::applyClip):
1331         * platform/graphics/svg/cg/SVGResourceImageCg.mm: Added.
1332         (WebCore::SVGResourceImage::SVGResourceImage):
1333         (WebCore::SVGResourceImage::~SVGResourceImage):
1334         (WebCore::SVGResourceImage::init):
1335         (WebCore::SVGResourceImage::size):
1336         (WebCore::SVGResourceImage::cgLayer):
1337         (WebCore::SVGResourceImage::setCGLayer):
1338         * platform/graphics/svg/cg/SVGResourceMaskerCg.mm: Added.
1339         (WebCore::applyLuminanceToAlphaFilter):
1340         (WebCore::applyExpandAlphatoGrayscaleFilter):
1341         (WebCore::transformImageIntoGrayscaleMask):
1342         (WebCore::SVGResourceMasker::applyMask):
1343         * platform/graphics/svg/qt/SVGResourceClipperQt.cpp: Added.
1344         (WebCore::SVGResourceClipper::applyClip):
1345         * platform/graphics/svg/qt/SVGResourceImageQt.cpp: Added.
1346         (WebCore::SVGResourceImage::init):
1347         (WebCore::SVGResourceImage::size):
1348         * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp: Added.
1349         (WebCore::SVGResourceMasker::applyMask):
1350         * platform/qt/GraphicsContextQt.cpp:
1351         * rendering/RenderPath.cpp:
1352         (WebCore::RenderPath::paint):
1353         (WebCore::DrawMarkersData::DrawMarkersData):
1354         (WebCore::RenderPath::drawMarkersIfNeeded):
1355         * rendering/RenderSVGContainer.cpp:
1356         (WebCore::RenderSVGContainer::paint):
1357         * rendering/RenderSVGImage.cpp:
1358         (WebCore::RenderSVGImage::paint):
1359         * rendering/SVGInlineFlowBox.cpp:
1360         (WebCore::paintSVGInlineFlow):
1361
1362 2006-10-30  John Sullivan  <sullivan@apple.com>
1363
1364         Reviewed by Brady
1365         
1366         - minor cleanup to make future patches clearer
1367
1368         * bridge/mac/FrameMac.mm:
1369         (WebCore::FrameMac::advanceToNextMisspelling):
1370         renamed misspelling to misspellingNSRange for clarity; changed > 0 test to == 0 test
1371         with "continue" to better match structure of similar code in markMisspellings; a few
1372         other style tweaks.
1373         
1374         (WebCore::FrameMac::markMisspellings):
1375         renamed misspelling to misspellingNSRange for clarity; removed unnecessary braces around
1376         a block just after a break and outdented accordingly.
1377
1378 2006-10-30  John Sullivan  <sullivan@apple.com>
1379
1380         Reviewed by Geoff Garen
1381         
1382         WebCore part of change to push the code that updates the spelling panel
1383         into WebCore, in preparation for some grammar-checking stuff.
1384
1385         * bridge/mac/FrameMac.h:
1386         * bridge/mac/FrameMac.mm:
1387         (WebCore::FrameMac::advanceToNextMisspelling):
1388         no more return value for this method, and update the spelling panel with
1389         the misspelled word here rather than in the WebKit callers.
1390
1391 2006-10-30  Oliver Hunt  <oliver@apple.com>
1392
1393         Reviewed by Anders.
1394
1395         Roll out last patch
1396
1397         * CMakeLists.txt:
1398         * ChangeLog:
1399         * WebCore.xcodeproj/project.pbxproj:
1400         * graphics/svg/SVGResource.cpp:
1401         * graphics/svg/SVGResourceClipper.cpp:
1402         * graphics/svg/SVGResourceClipper.h:
1403         * graphics/svg/SVGResourceImage.h:
1404         * graphics/svg/SVGResourceListener.h:
1405         * graphics/svg/SVGResourceMarker.cpp:
1406         * graphics/svg/SVGResourceMarker.h:
1407         * graphics/svg/SVGResourceMasker.cpp:
1408         * graphics/svg/SVGResourceMasker.h:
1409         * kcanvas/KCanvasClipper.cpp: Added.
1410         (WebCore::operator<<):
1411         (WebCore::KCanvasClipper::KCanvasClipper):
1412         (WebCore::KCanvasClipper::~KCanvasClipper):
1413         (WebCore::KCanvasClipper::resetClipData):
1414         (WebCore::KCanvasClipper::addClipData):
1415         (WebCore::KCanvasClipper::clipData):
1416         (WebCore::KCanvasClipper::externalRepresentation):
1417         (WebCore::getClipperById):
1418         * kcanvas/KCanvasClipper.h: Added.
1419         (WebCore::KCClipData::windRule):
1420         (WebCore::KCClipDataList::KCClipDataList):
1421         (WebCore::KCClipDataList::addPath):
1422         (WebCore::KCanvasClipper::isClipper):
1423         * kcanvas/KCanvasFilters.cpp:
1424         (WebCore::getFilterById):
1425         * kcanvas/KCanvasFilters.h:
1426         * kcanvas/KCanvasImage.h: Added.
1427         (WebCore::KCanvasImage::KCanvasImage):
1428         (WebCore::KCanvasImage::~KCanvasImage):
1429         * kcanvas/KCanvasMarker.cpp: Added.
1430         (WebCore::KCanvasMarker::KCanvasMarker):
1431         (WebCore::KCanvasMarker::~KCanvasMarker):
1432         (WebCore::KCanvasMarker::setMarker):
1433         (WebCore::KCanvasMarker::setRef):
1434         (WebCore::KCanvasMarker::refX):
1435         (WebCore::KCanvasMarker::refY):
1436         (WebCore::KCanvasMarker::setAngle):
1437         (WebCore::KCanvasMarker::angle):
1438         (WebCore::KCanvasMarker::setAutoAngle):
1439         (WebCore::KCanvasMarker::setUseStrokeWidth):
1440         (WebCore::KCanvasMarker::useStrokeWidth):
1441         (WebCore::KCanvasMarker::draw):
1442         (WebCore::KCanvasMarker::externalRepresentation):
1443         (WebCore::getMarkerById):
1444         * kcanvas/KCanvasMarker.h: Added.
1445         (WebCore::KCanvasMarker::isMarker):
1446         * kcanvas/KCanvasMasker.cpp: Added.
1447         (WebCore::KCanvasMasker::KCanvasMasker):
1448         (WebCore::KCanvasMasker::~KCanvasMasker):
1449         (WebCore::KCanvasMasker::setMask):
1450         (WebCore::KCanvasMasker::externalRepresentation):
1451         (WebCore::getMaskerById):
1452         * kcanvas/KCanvasMasker.h: Added.
1453         (WebCore::KCanvasMasker::isMasker):
1454         (WebCore::KCanvasMasker::mask):
1455         * kcanvas/KCanvasResource.cpp: Added.
1456         (WebCore::operator<<):
1457         (WebCore::KCanvasResource::KCanvasResource):
1458         (WebCore::KCanvasResource::~KCanvasResource):
1459         (WebCore::KCanvasResource::addClient):
1460         (WebCore::KCanvasResource::clients):
1461         (WebCore::KCanvasResource::invalidate):
1462         (WebCore::KCanvasResource::idInRegistry):
1463         (WebCore::KCanvasResource::setIdInRegistry):
1464         (WebCore::KCanvasResource::externalRepresentation):
1465         (WebCore::getResourceById):
1466         (WebCore::getPaintServerById):
1467         * kcanvas/KCanvasResource.h:
1468         (WebCore::):
1469         (WebCore::KCanvasResource::isPaintServer):
1470         (WebCore::KCanvasResource::isFilter):
1471         (WebCore::KCanvasResource::isClipper):
1472         (WebCore::KCanvasResource::isMarker):
1473         (WebCore::KCanvasResource::isMasker):
1474         * kcanvas/KCanvasResourceListener.h: Added.
1475         (KCanvasResourceListener::KCanvasResourceListener):
1476         (KCanvasResourceListener::~KCanvasResourceListener):
1477         * kcanvas/KCanvasTreeDebug.cpp:
1478         (WebCore::writeRenderResources):
1479         * kcanvas/device/KRenderingDevice.h:
1480         * kcanvas/device/KRenderingPaintServer.h:
1481         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
1482         (WebCore::KRenderingPaintServer::idInRegistry):
1483         (WebCore::KRenderingPaintServer::setIdInRegistry):
1484         * kcanvas/device/KRenderingPaintServerGradient.cpp:
1485         (WebCore::KRenderingPaintServerGradient::listener):
1486         (WebCore::KRenderingPaintServerGradient::setListener):
1487         * kcanvas/device/KRenderingPaintServerGradient.h:
1488         * kcanvas/device/KRenderingPaintServerPattern.cpp:
1489         (WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
1490         (WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
1491         (WebCore::KRenderingPaintServerPattern::tile):
1492         (WebCore::KRenderingPaintServerPattern::setTile):
1493         (WebCore::KRenderingPaintServerPattern::listener):
1494         (WebCore::KRenderingPaintServerPattern::setListener):
1495         * kcanvas/device/KRenderingPaintServerPattern.h:
1496         * kcanvas/device/KRenderingPaintServerSolid.h:
1497         * kcanvas/device/qt/KCanvasClipperQt.cpp:
1498         (WebCore::KCanvasClipperQt::applyClip):
1499         * kcanvas/device/qt/KCanvasClipperQt.h:
1500         (WebCore::KCanvasClipperQt::KCanvasClipperQt):
1501         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
1502         (WebCore::KRenderingDeviceQt::contextForImage):
1503         (WebCore::KRenderingDeviceQt::createResource):
1504         (WebCore::KRenderingDeviceQt::createPaintServer):
1505         * kcanvas/device/qt/KRenderingDeviceQt.h:
1506         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
1507         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
1508         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
1509         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
1510         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
1511         (WebCore::KCanvasFilterQuartz::getCIFilterStack):
1512         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
1513         * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
1514         (WebCore::KCanvasMaskerQuartz::KCanvasMaskerQuartz):
1515         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
1516         (WebCore::applyLuminanceToAlphaFilter):
1517         (WebCore::applyExpandAlphatoGrayscaleFilter):
1518         (WebCore::transformImageIntoGrayscaleMask):
1519         (WebCore::KCanvasMaskerQuartz::applyMask):
1520         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
1521         (WebCore::KCanvasClipperQuartz::KCanvasClipperQuartz):
1522         (WebCore::KCanvasImageQuartz::KCanvasImageQuartz):
1523         (WebCore::KCanvasImageQuartz::init):
1524         (WebCore::KCanvasImageQuartz::size):
1525         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
1526         (WebCore::KCanvasClipperQuartz::applyClip):
1527         (WebCore::KCanvasImageQuartz::~KCanvasImageQuartz):
1528         (WebCore::KCanvasImageQuartz::cgLayer):
1529         (WebCore::KCanvasImageQuartz::setCGLayer):
1530         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
1531         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
1532         (WebCore::KRenderingDeviceQuartz::contextForImage):
1533         (WebCore::KRenderingDeviceQuartz::createPaintServer):
1534         (WebCore::KRenderingDeviceQuartz::createResource):
1535         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
1536         (WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
1537         (WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
1538         (WebCore::KRenderingPaintServerGradientQuartz::setup):
1539         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
1540         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
1541         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
1542         (WebCore::patternCallback):
1543         (WebCore::KRenderingPaintServerPatternQuartz::setup):
1544         * kcanvas/device/quartz/QuartzSupport.mm:
1545         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1546         (WebCore::sharedSolidPaintServer):
1547         * ksvg2/svg/SVGClipPathElement.cpp:
1548         (WebCore::SVGClipPathElement::SVGClipPathElement):
1549         (WebCore::SVGClipPathElement::~SVGClipPathElement):
1550         (WebCore::SVGClipPathElement::canvasResource):
1551         * ksvg2/svg/SVGClipPathElement.h:
1552         * ksvg2/svg/SVGFEImageElement.cpp:
1553         * ksvg2/svg/SVGFilterElement.cpp:
1554         (WebCore::SVGFilterElement::SVGFilterElement):
1555         (WebCore::SVGFilterElement::~SVGFilterElement):
1556         (WebCore::SVGFilterElement::canvasResource):
1557         * ksvg2/svg/SVGFilterElement.h:
1558         * ksvg2/svg/SVGGradientElement.cpp:
1559         (WebCore::SVGGradientElement::SVGGradientElement):
1560         (WebCore::SVGGradientElement::~SVGGradientElement):
1561         (WebCore::SVGGradientElement::canvasResource):
1562         (WebCore::SVGGradientElement::resourceNotification):
1563         * ksvg2/svg/SVGGradientElement.h:
1564         * ksvg2/svg/SVGImageElement.cpp:
1565         * ksvg2/svg/SVGLinearGradientElement.cpp:
1566         (WebCore::SVGLinearGradientElement::buildGradient):
1567         * ksvg2/svg/SVGLinearGradientElement.h:
1568         * ksvg2/svg/SVGMarkerElement.cpp:
1569         (WebCore::SVGMarkerElement::SVGMarkerElement):
1570         (WebCore::SVGMarkerElement::~SVGMarkerElement):
1571         (WebCore::SVGMarkerElement::canvasResource):
1572         * ksvg2/svg/SVGMarkerElement.h:
1573         * ksvg2/svg/SVGMaskElement.cpp:
1574         (WebCore::SVGMaskElement::SVGMaskElement):
1575         (WebCore::SVGMaskElement::~SVGMaskElement):
1576         (WebCore::SVGMaskElement::drawMaskerContent):
1577         (WebCore::SVGMaskElement::canvasResource):
1578         * ksvg2/svg/SVGMaskElement.h:
1579         * ksvg2/svg/SVGPatternElement.cpp:
1580         (WebCore::SVGPatternElement::SVGPatternElement):
1581         (WebCore::SVGPatternElement::~SVGPatternElement):
1582         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
1583         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
1584         (WebCore::SVGPatternElement::canvasResource):
1585         * ksvg2/svg/SVGPatternElement.h:
1586         * ksvg2/svg/SVGRadialGradientElement.cpp:
1587         (WebCore::SVGRadialGradientElement::buildGradient):
1588         * ksvg2/svg/SVGRadialGradientElement.h:
1589         * ksvg2/svg/SVGStyledElement.h:
1590         (WebCore::SVGStyledElement::canvasResource):
1591         * platform/GraphicsContext.cpp: Added.
1592         (WebCore::GraphicsContextState::GraphicsContextState):
1593         (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
1594         (WebCore::GraphicsContext::createGraphicsContextPrivate):
1595         (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
1596         (WebCore::GraphicsContext::save):
1597         (WebCore::GraphicsContext::restore):
1598         (WebCore::GraphicsContext::font):
1599         (WebCore::GraphicsContext::setFont):
1600         (WebCore::GraphicsContext::pen):
1601         (WebCore::GraphicsContext::setPen):
1602         (WebCore::GraphicsContext::setFillColor):
1603         (WebCore::GraphicsContext::fillColor):
1604         (WebCore::GraphicsContext::updatingControlTints):
1605         (WebCore::GraphicsContext::setUpdatingControlTints):
1606         (WebCore::GraphicsContext::setPaintingDisabled):
1607         (WebCore::GraphicsContext::paintingDisabled):
1608         (WebCore::GraphicsContext::drawImage):
1609         (WebCore::GraphicsContext::drawText):
1610         (WebCore::GraphicsContext::drawHighlightForText):
1611         (WebCore::GraphicsContext::initFocusRing):
1612         (WebCore::GraphicsContext::clearFocusRing):
1613         (WebCore::GraphicsContext::focusRingBoundingRect):
1614         (WebCore::GraphicsContext::addFocusRingRect):
1615         (WebCore::GraphicsContext::focusRingWidth):
1616         (WebCore::GraphicsContext::focusRingOffset):
1617         (WebCore::GraphicsContext::focusRingRects):
1618         (WebCore::GraphicsContext::drawTiledImage):
1619         * platform/GraphicsContext.h: Added.
1620         * platform/GraphicsTypes.cpp: Added.
1621         (WebCore::):
1622         (WebCore::parseCompositeOperator):
1623         (WebCore::compositeOperatorName):
1624         (WebCore::parseLineCap):
1625         (WebCore::lineCapName):
1626         (WebCore::parseLineJoin):
1627         (WebCore::lineJoinName):
1628         * platform/GraphicsTypes.h: Added.
1629         (WebCore::):
1630         * platform/graphics/GraphicsContext.cpp:
1631         * platform/graphics/GraphicsContext.h:
1632         * platform/graphics/GraphicsTypes.cpp:
1633         * platform/graphics/GraphicsTypes.h:
1634         * platform/qt/GraphicsContextQt.cpp:
1635         * rendering/RenderPath.cpp:
1636         (WebCore::RenderPath::paint):
1637         (WebCore::DrawMarkersData::DrawMarkersData):
1638         (WebCore::RenderPath::drawMarkersIfNeeded):
1639         * rendering/RenderSVGContainer.cpp:
1640         (WebCore::RenderSVGContainer::paint):
1641         * rendering/RenderSVGImage.cpp:
1642         (WebCore::RenderSVGImage::paint):
1643         * rendering/SVGInlineFlowBox.cpp:
1644         (WebCore::paintSVGInlineFlow):
1645
1646 2006-10-30  John Sullivan  <sullivan@apple.com>
1647
1648         Reviewed by Geoff Garen.
1649         
1650         Moved spelling-related methods from bridge to EditorClient. Added one not-yet-used
1651         grammar-related method.
1652
1653         * bridge/EditorClient.h:
1654         declare isContinuousSpellCheckingEnabled(), spellCheckerDocumentTag(), and new
1655         isGrammarCheckingEnabled()
1656         
1657         * bridge/mac/WebCoreFrameBridge.h:
1658         removed bridge equivalents
1659
1660         * bridge/mac/FrameMac.mm:
1661         (WebCore::FrameMac::advanceToNextMisspelling):
1662         convert bridge-using code to editor()->client()-using code
1663         (WebCore::FrameMac::markMisspellingsInAdjacentWords):
1664         ditto
1665         (WebCore::FrameMac::markMisspellings):
1666         ditto
1667         (WebCore::FrameMac::respondToChangedSelection):
1668         ditto
1669         
1670         * editing/Editor.h:
1671         * editing/Editor.cpp:
1672         (WebCore::Editor::client):
1673         new method, returns EditorClient pointer. In an ideal world all the code that needed to
1674         access the EditorClient would be in Editor.cpp, and we wouldn't need this accessor.
1675         But for now it's too tricky to extricate the spelling-related code from FrameMac.mm.
1676
1677 2006-10-30  Geoffrey Garen  <ggaren@apple.com>
1678
1679         Reviewed by Darin.
1680
1681         Removed a number of editing and selection methods from the bridge.
1682         
1683         I moved cross-platform editing and selection code into Editor and 
1684         SelectionController, respecitvely.
1685
1686         I moved ObjC and AppKit stuff up into WebKit, so I ended up exporting
1687         everything + the kitchen sink.
1688         
1689         Specific comments below for interesting things.
1690         
1691         * bindings/objc/DOMInternal.h: Moved exception handling helper methods into
1692         a new file so that WebKit can use them, too. Added a helper method for
1693         handling exceptions when selecting a Range.
1694         * bridge/mac/FrameMac.h: Moved attributedString creation and helper functions into 
1695         WebKit, since they have to do with creating an NSAttributedString for API
1696         consumption, and not much to do with general Frame functionality.
1697         * editing/Editor.h: Moved lastEditCommand tracking (at least the data,
1698         for now) into the Editor. Eventually, the Frame will not have to notify 
1699         the Editor of what the lastEditCommand was, since the Editor will perform
1700         all EditCommands.
1701         * editing/SelectionController.h: The code here is just stuff moved from the bridge.
1702         * editing/SelectionController.cpp:
1703         (WebCore::SelectionController::setSelectedRange): We now explicitly check from DOM exceptions
1704         and return them. The bridge method to select a DOM range did this implicitly,
1705         since all ObjC DOM operations handle DOM exceptions by throwing them as
1706         ObjC exceptions.
1707         * editing/TextAffinity.h: Added helper functions for conversion to NSSelectionAffinity.
1708         The two enumerations are numerically identical, but that's an implementation
1709         detail of TextAffinity that clients shouldn't be required to know about.
1710
1711 2006-10-30  Timothy Hatcher  <timothy@apple.com>
1712
1713         Rolling out the following change because this crash:
1714         <rdar://problem/4806705> REGRESSION: Crash occurs at WebCore::Font::lineSpacing() when loading site (http://www.photoplusexpo.com/ppe/index.jsp) 
1715
1716         And this regression:
1717         <rdar://problem/4728514> REGRESSION: Safari applies the wrong font to BODY element at http://www.apple.com/downloads/dashboard/
1718
1719     2006-09-06  David Harrison  <harrison@apple.com>
1720
1721         Reviewed and tweaked by Tim H. 
1722
1723         <rdar://problem/4564955> WebKit doesn't trigger Auto Font Activation 
1724
1725         If we don't find the font in the available fonts list, call [NSFont fontWithName:size:] 
1726         to trigger a search that will include auto activation. No PLT or iBench perf impact. 
1727         No layout tests affected. Not testable in an automated way that will work on all systems. 
1728
1729         * platform/mac/WebFontCache.mm: 
1730         (+[WebFontCache fontWithFamily:traits:size:]): 
1731
1732 2006-10-30  Justin Garcia  <justin.garcia@apple.com>
1733
1734         Reviewed by harrison
1735
1736         <rdar://problem/4808375>
1737         REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) (11460)
1738
1739         * editing/TextIterator.cpp:
1740         (WebCore::TextIterator::exitNode): Only create VisiblePositions
1741         when we're going to use them to create a range for an emitted character.
1742         We should further speed TextIterators up by avoiding creating VisiblePositions
1743         for TIs that are only used for the characters they emit (like the one that 
1744         plainText uses).
1745
1746 2006-10-30  Sam Weinig  <sam.weinig@gmail.com>
1747
1748         Reviewed by Mitz.
1749
1750         Fix for http://bugs.webkit.org/show_bug.cgi?id=11441
1751         More rendering code cleaning
1752
1753         * WebCore.xcodeproj/project.pbxproj:
1754         * rendering/RenderApplet.cpp:
1755         (WebCore::RenderApplet::RenderApplet):
1756         (WebCore::RenderApplet::createWidgetIfNecessary):
1757         * rendering/RenderApplet.h:
1758         * rendering/RenderArena.cpp:
1759         (WebCore::):
1760         (WebCore::RenderArena::RenderArena):
1761         (WebCore::RenderArena::allocate):
1762         (WebCore::RenderArena::free):
1763         * rendering/RenderArena.h:
1764         * rendering/RenderBR.cpp:
1765         (WebCore::RenderBR::RenderBR):
1766         (WebCore::RenderBR::baselinePosition):
1767         (WebCore::RenderBR::lineHeight):
1768         (WebCore::RenderBR::setStyle):
1769         (WebCore::RenderBR::caretMinOffset):
1770         (WebCore::RenderBR::positionForCoordinates):
1771         (WebCore::RenderBR::inlineBox):
1772         * rendering/RenderBR.h:
1773         * rendering/RenderBlock.cpp:
1774         * rendering/RenderBlock.h:
1775         (WebCore::RenderBlock::maxTopMargin):
1776         (WebCore::RenderBlock::maxBottomMargin):
1777         (WebCore::RenderBlock::initMaxMarginValues):
1778         (WebCore::RenderBlock::containsFloats):
1779         (WebCore::RenderBlock::setHasMarkupTruncation):
1780         (WebCore::RenderBlock::BlockSelectionInfo::BlockSelectionInfo):
1781         (WebCore::RenderBlock::BlockSelectionInfo::block):
1782         (WebCore::RenderBlock::BlockSelectionInfo::state):
1783         (WebCore::RenderBlock::FloatingObject::FloatingObject):
1784         (WebCore::RenderBlock::CompactInfo::clear):
1785         * rendering/RenderButton.cpp:
1786         (WebCore::RenderButton::removeChild):
1787         (WebCore::RenderButton::paintObject):
1788         * rendering/RenderButton.h:
1789         (WebCore::RenderButton::renderName):
1790         (WebCore::RenderButton::removeLeftoverAnonymousBoxes):
1791         * rendering/RenderContainer.cpp:
1792         (WebCore::RenderContainer::RenderContainer):
1793         * rendering/RenderContainer.h:
1794         (WebCore::RenderContainer::firstChild):
1795         (WebCore::RenderContainer::lastChild):
1796         (WebCore::RenderContainer::calcMinMaxWidth):
1797         * rendering/RenderCounter.cpp:
1798         (WebCore::RenderCounter::RenderCounter):
1799         (WebCore::toRoman):
1800         (WebCore::toHebrew):
1801         (WebCore::RenderCounter::calcMinMaxWidth):
1802         * rendering/RenderCounter.h:
1803         * rendering/RenderFieldset.cpp:
1804         (WebCore::RenderFieldset::paintBoxDecorations):
1805         (WebCore::RenderFieldset::paintBorderMinusLegend):
1806         (WebCore::RenderFieldset::setStyle):
1807         * rendering/RenderFileUploadControl.cpp:
1808         (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
1809         (WebCore::RenderFileUploadControl::setStyle):
1810         (WebCore::RenderFileUploadControl::paintObject):
1811         (WebCore::RenderFileUploadControl::calcMinMaxWidth):
1812         * rendering/RenderFileUploadControl.h:
1813         (WebCore::RenderFileUploadControl::renderName):
1814         * rendering/RenderFlexibleBox.h:
1815         * rendering/RenderFlow.cpp:
1816         * rendering/RenderFlow.h:
1817         * rendering/RenderForeignObject.cpp:
1818         (WebCore::RenderForeignObject::RenderForeignObject):
1819         (WebCore::RenderForeignObject::paint):
1820         (WebCore::RenderForeignObject::computeAbsoluteRepaintRect):
1821         (WebCore::RenderForeignObject::layout):
1822         (WebCore::RenderForeignObject::nodeAtPoint):
1823         * rendering/RenderForeignObject.h:
1824         (WebCore::RenderForeignObject::renderName):
1825         * rendering/RenderFormElement.cpp:
1826         (WebCore::RenderFormElement::setStyle):
1827         (WebCore::RenderFormElement::layout):
1828         (WebCore::RenderFormElement::textAlignment):
1829         * rendering/RenderFormElement.h:
1830         * rendering/RenderFrame.cpp:
1831         * rendering/RenderFrame.h:
1832         (WebCore::RenderFrame::element):
1833         * rendering/RenderFrameSet.cpp:
1834         * rendering/RenderFrameSet.h:
1835         (WebCore::RenderFrameSet::element):
1836         * rendering/RenderHTMLCanvas.cpp:
1837         (WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
1838         (WebCore::RenderHTMLCanvas::paint):
1839         * rendering/RenderHTMLCanvas.h:
1840         (WebCore::RenderHTMLCanvas::renderName):
1841         * rendering/RenderImage.cpp:
1842         (WebCore::RenderImage::RenderImage):
1843         (WebCore::RenderImage::setStyle):
1844         (WebCore::RenderImage::setContentObject):
1845         (WebCore::RenderImage::setCachedImage):
1846         (WebCore::RenderImage::imageChanged):
1847         (WebCore::RenderImage::paint):
1848         (WebCore::RenderImage::layout):
1849         (WebCore::RenderImage::updateAltText):
1850         * rendering/RenderImage.h:
1851         (WebCore::RenderImage::element):
1852         * rendering/RenderInline.cpp:
1853         (WebCore::RenderInline::RenderInline):
1854         (WebCore::RenderInline::~RenderInline):
1855         (WebCore::RenderInline::setStyle):
1856         (WebCore::RenderInline::addChildToFlow):
1857         (WebCore::RenderInline::cloneInline):
1858         (WebCore::RenderInline::splitInlines):
1859         (WebCore::RenderInline::splitFlow):
1860         (WebCore::RenderInline::paint):
1861         (WebCore::RenderInline::absoluteRects):
1862         (WebCore::RenderInline::calcMinMaxWidth):
1863         (WebCore::RenderInline::requiresLayer):
1864         (WebCore::RenderInline::width):
1865         (WebCore::RenderInline::height):
1866         (WebCore::RenderInline::renderName):
1867         (WebCore::RenderInline::nodeAtPoint):
1868         (WebCore::RenderInline::positionForCoordinates):
1869         * rendering/RenderInline.h:
1870         (WebCore::RenderInline::layout):
1871         * rendering/RenderLayer.cpp:
1872         * rendering/RenderLayer.h:
1873         (WebCore::ClipRects::ClipRects):
1874         (WebCore::RenderLayer::nextSibling):
1875         (WebCore::RenderLayer::root):
1876         (WebCore::RenderLayer::setPos):
1877         (WebCore::RenderLayer::height):
1878         (WebCore::RenderLayer::relativePositionOffset):
1879         * rendering/RenderLineEdit.cpp:
1880         (WebCore::RenderLineEdit::setStyle):
1881         (WebCore::RenderLineEdit::updateFromElement):
1882         (WebCore::RenderLineEdit::selectionStart):
1883         (WebCore::RenderLineEdit::selectionEnd):
1884         (WebCore::RenderLineEdit::setSelectionStart):
1885         (WebCore::RenderLineEdit::setSelectionEnd):
1886         (WebCore::RenderLineEdit::setSelectionRange):
1887         * rendering/RenderLineEdit.h:
1888         * rendering/RenderListBox.cpp:
1889         * rendering/RenderListBox.h:
1890         (WebCore::RenderListBox::renderName):
1891         * rendering/RenderListItem.cpp:
1892         (WebCore::RenderListItem::setStyle):
1893         (WebCore::getParentOfFirstLineBox):
1894         (WebCore::RenderListItem::updateMarkerLocation):
1895         (WebCore::RenderListItem::positionListMarker):
1896         (WebCore::RenderListItem::paint):
1897         * rendering/RenderListItem.h:
1898         * rendering/RenderListMarker.cpp:
1899         * rendering/RenderListMarker.h:
1900         (WebCore::RenderListMarker::renderName):
1901         (WebCore::RenderListMarker::isListMarker):
1902
1903 2006-10-30  Timothy Hatcher  <timothy@apple.com>
1904
1905         Reviewed by Hyatt.
1906
1907         <rdar://problem/4478625> Basic table editing and culling
1908
1909         Refined the criteria for deletable elements, rely on the renderer more.
1910         Corrected the interface positioning for elements that have borders.
1911
1912         * editing/DeleteButtonController.cpp:
1913         (WebCore::isDeletableElement):
1914         (WebCore::DeleteButtonController::show):
1915
1916 2006-10-30  Darin Adler  <darin@apple.com>
1917
1918         - fix build
1919
1920         * loader/ResourceLoader.h: Added header guard.
1921
1922 2006-10-31  Darin Adler  <darin@apple.com>
1923
1924         Reviewed by Adam.
1925
1926         - fix FrameLoader files so they can be built on non-Mac platforms
1927
1928         * page/FramePrivate.h:
1929         (WebCore::FramePrivate::FramePrivate): Added code to create the frame loader.
1930         (WebCore::FramePrivate::~FramePrivate): Added code to delete the frame loader.
1931
1932         * page/Page.h:
1933         * page/Page.cpp: (WebCore::Page::setDefersLoading): Removed the
1934         #if PLATFORM(MAC) that Adam added as a stop-gap when I did this wrong
1935         the other day.
1936
1937         * bridge/mac/FrameMac.mm:
1938         (WebCore::FrameMac::FrameMac): Removed code to create the frame loader.
1939         (WebCore::FrameMac::~FrameMac): Removed code to delete the frame loader.
1940
1941         * loader/FrameLoader.h: Changed import to include, added #if PLATFORM(MAC)
1942         around the PolicyCheck definition.
1943
1944         * loader/FormState.cpp: Changed import to include.
1945         * loader/FrameLoader.cpp: Ditto.
1946         * loader/MainResourceLoader.h: Ditto.
1947
1948         * loader/FrameLoaderTypes.h: Added a header guard.
1949
1950         * loader/NetscapePlugInStreamLoader.h: Changed import to include.
1951         Added #if PLATFORM(MAC) around Mac-specific details.
1952         * loader/SubresourceLoader.h: Ditto.
1953
1954         * page/Frame.cpp: (WebCore::Frame::loader): Updated name of loader to
1955         m_loader from m_frameLoader.
1956
1957         * CMakeLists.txt: Updated.
1958         * WebCoreSources.bkl: Updated.
1959
1960 2006-10-30  Nikolas Zimmermann  <zimmermann@kde.org>
1961
1962         Reviewed and landed by Anders.
1963
1964         Patch by Zack rusin to fix: 
1965         http://bugs.webkit.org/show_bug.cgi?id=11429
1966
1967         Fix startup crash.
1968
1969         * platform/qt/FrameQtClient.cpp:
1970         (WebCore::FrameQtClientDefault::openURL):
1971
1972 2006-10-30  Zach Rusin  <zack@kde.org>
1973
1974         Reviewed and landed by Anders.
1975
1976         * platform/network/qt/ResourceHandleQt.cpp:
1977         (WebCore::ResourceHandle::receivedResponse):
1978         * platform/qt/FrameQtClient.cpp:
1979         (WebCore::FrameQtClientDefault::FrameQtClientDefault):
1980         * platform/qt/LoaderFunctionsQt.cpp:
1981         (WebCore::ServeSynchronousRequest):
1982         More build fixes.
1983
1984 2006-10-30  Simon Hausmann  <hausmann@kde.org>
1985
1986         Reviewed and landed by Anders.
1987         
1988         - fix Qt build
1989         * platform/qt/FrameQtClient.cpp: ResourceLoaderClient ->
1990         ResourceHandleClient
1991
1992 2006-10-30  Darin Adler  <darin@apple.com>
1993
1994         Reviewed by John Sullivan.
1995
1996         - work toward removing Objective-C data types from FrameLoader.h:
1997           removed NSDate, NSString, WebCorePageState, WebCoreResourceLoader,
1998           and WebCoreResourceHandle
1999         - moved bodyBackgroundColor function from Frame to WebFrame in WebKit
2000
2001         * page/PageState.h:
2002         * page/PageState.cpp: Added, C++ class with much of what WebCorePageState had.
2003
2004         * bridge/mac/FrameMac.h: Removed uneeeded declarations and bodyBackgroundColor().
2005         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::startRedirectionTimer): Use a
2006         double for the date instead of an NSDate.
2007
2008         * bridge/mac/WebCoreFrameBridge.h:
2009         * bridge/mac/WebCoreFrameBridge.mm: Removed invalidatePageCache and
2010         saveDocumentToPageCache methods.
2011
2012         * bridge/mac/WebCorePageState.h:
2013         * bridge/mac/WebCorePageState.mm: Removed most of the class and turned it into
2014         an Objective-C wrapper for PageState.
2015
2016         * loader/FrameLoader.h: Removed unused Objective-C types, eliminated use of
2017         NSDate and WebCorePageState.
2018         * loader/FrameLoaderClient.h: Changed NSDate to double.
2019         * loader/mac/FrameLoaderMac.mm:
2020         (WebCore::FrameLoader::receivedMainResourceError): Moved call to setInPageCache
2021         here that used to be in invalidateCurrentItemPageCache on the WebKit side.
2022         (WebCore::FrameLoader::clientRedirected): Changed NSDate to double for date.
2023         (WebCore::FrameLoader::open): Moved one of the open functions that was part of
2024         commitProvisionalLoad inside the commitProvisionalLoad function, so that it can
2025         extract the parameters from the response. Changed the open function that takes
2026         a PageState to use the new C++ PageState.
2027         (WebCore::FrameLoader::commitProvisionalLoad): Added the code from the open
2028         function; tightened up logic, removing a few cases that could never happen, as
2029         well as the unused reload boolean.
2030
2031         * ForwardingHeaders/kjs/property_map.h: Added.
2032
2033         * WebCore.exp: Updated.
2034         * WebCore.xcodeproj/project.pbxproj: Updated.
2035
2036 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2037
2038         Reviewed by Anders.
2039
2040         - added ResourceResponse class and didReceiveResponse delegate call
2041         
2042         * WebCore.xcodeproj/project.pbxproj: Added new files.
2043         * bridge/mac/WebCoreFrameBridge.h: Removed no longer needed
2044         expiresTimeForResponse: method.
2045         * dom/XMLTokenizer.cpp:
2046         (WebCore::openFunc): Updated to use ResourceResponse.
2047         * loader/FrameLoader.h: Update loadResourceSynchronously to
2048         use ResourceResponse.
2049         * loader/LoaderFunctions.h:
2050         * loader/icon/IconLoader.cpp:
2051         (IconLoader::didReceiveResponse): Updated from receivedResponse
2052         and made cross-platform.
2053         * loader/icon/IconLoader.h: updated for above change
2054         * loader/loader.cpp:
2055         (WebCore::Loader::receivedResponse): reduced to just saving
2056         the PlatformResponse (ideally we'd phase out use of this).
2057         (WebCore::Loader::didReceivedResponse): most of the ReceivedResponse 
2058         logic.
2059         * loader/loader.h:
2060         * loader/mac/FrameLoaderMac.mm:
2061         (WebCore::FrameLoader::loadResourceSynchronously): Return results
2062         as ResourceResponse.
2063         * loader/mac/IconLoaderMac.mm: remove receivedResponse.
2064         * loader/mac/LoaderFunctionsMac.mm:
2065         (WebCore::ServeSynchronousRequest): take ResourceResponse as
2066         argument.
2067         * platform/network/ResourceHandle.cpp:
2068         * platform/network/ResourceHandle.h: Remove calls for
2069         broken out response pieces.
2070         * platform/network/ResourceHandleClient.h:
2071         (WebCore::ResourceHandleClient::didReceiveResponse): New
2072         delegate method.
2073         * platform/network/ResourceHandleInternal.h:
2074         (WebCore::ResourceHandleInternal::ResourceHandleInternal): Remove
2075         storage of response bits, we're not gonna return them
2076         seprately any more.
2077         * platform/network/ResourceResponse.h: Added.
2078         (WebCore::ResourceResponse::ResourceResponse): Freshly
2079         implemented. Same for below.
2080         (WebCore::ResourceResponse::url):
2081         (WebCore::ResourceResponse::mimeType):
2082         (WebCore::ResourceResponse::expectedContentLength):
2083         (WebCore::ResourceResponse::textEncodingName):
2084         (WebCore::ResourceResponse::suggestedFilename):
2085         (WebCore::ResourceResponse::httpStatusCode):
2086         (WebCore::ResourceResponse::setHTTPStatusCode):
2087         (WebCore::ResourceResponse::httpHeaderField):
2088         (WebCore::ResourceResponse::httpHeaderFields):
2089         (WebCore::ResourceResponse::isMultipart):
2090         (WebCore::ResourceResponse::setExpirationDate):
2091         (WebCore::ResourceResponse::expirationDate):
2092         * platform/network/cf/ResourceHandleCFNet.cpp:
2093         (WebCore::didReceiveResponse): Send didReceiveResponse
2094         client method.
2095         * platform/network/cf/ResourceResponseCFNet.h: Added.
2096         * platform/network/cf/ResourceResponseCFNet.mm: Added.
2097         (getResourceResponse): Helper function to get a ResourceResponse 
2098         from CFURLResponseRef.
2099         * platform/network/mac/ResourceHandleMac.mm:
2100         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2101         Don't bother cleaning up fields we no longer have.
2102         (WebCore::ResourceHandle::receivedResponse): Send
2103         didReceiveResponse client method.
2104         * platform/network/mac/ResourceResponseMac.h: Added.
2105         * platform/network/mac/ResourceResponseMac.mm: Added.
2106         (getResourceResponse): Helper function to get a ResourceResponse 
2107         from an NSURLResponse*.
2108         * rendering/HitTestResult.cpp:
2109         * xml/XSLTProcessor.cpp:
2110         (WebCore::docLoaderFunc): Prepare for use of ResourceResponse.
2111         * xml/xmlhttprequest.cpp:
2112         (WebCore::XMLHttpRequest::getResponseText): Store http response
2113         info in the form of a ResourceResponse, change all methods to
2114         account for this.
2115         (WebCore::XMLHttpRequest::getResponseXML):
2116         (WebCore::XMLHttpRequest::XMLHttpRequest):
2117         (WebCore::XMLHttpRequest::open):
2118         (WebCore::XMLHttpRequest::send):
2119         (WebCore::XMLHttpRequest::getAllResponseHeaders):
2120         (WebCore::XMLHttpRequest::getResponseHeader):
2121         (WebCore::XMLHttpRequest::getStatus):
2122         (WebCore::XMLHttpRequest::getStatusText):
2123         (WebCore::XMLHttpRequest::processSyncLoadResults):
2124         (WebCore::XMLHttpRequest::didFinishLoading):
2125         (WebCore::XMLHttpRequest::didReceiveResponse):
2126         (WebCore::XMLHttpRequest::didReceiveData):
2127         * xml/xmlhttprequest.h:
2128
2129 2006-10-29  Darin Adler  <darin@apple.com>
2130
2131         - fix build
2132
2133         * loader/DocumentLoader.h: Add declarations so this compiles without ObjC.
2134         * loader/NetscapePlugInStreamLoader.h: Ditto.
2135         * loader/ResourceLoader.h: Ditto.
2136
2137 2006-10-29  Darin Adler  <darin@apple.com>
2138
2139         - one last name change -- WebFormState.h to FormState.h
2140         - added more empty placeholder platform-independent files
2141           for currently-Mac-specific loader classes
2142
2143         * loader/FormState.cpp: Updated include.
2144         * loader/FrameLoader.cpp: Updated include.
2145         * loader/mac/FrameLoaderMac.mm: Updated include.
2146
2147         * loader/WebFormState.h: Removed.
2148         * loader/FormState.h: Added.
2149
2150         * loader/DocumentLoader.cpp: Added.
2151         * loader/MainResourceLoader.cpp: Added.
2152         * loader/NetscapePlugInStreamLoader.cpp: Added.
2153         * loader/ResourceLoader.cpp: Added.
2154         * loader/SubresourceLoader.cpp: Added.
2155
2156         * WebCore.xcodeproj/project.pbxproj: Updated for changes above.
2157
2158 2006-10-29  Darin Adler  <darin@apple.com>
2159
2160         - did the do-webcore-rename renames, including a number of changes
2161           to the names of loader files (and WebResourceLoader -> ResourceLoader),
2162           jScript() to scriptProxy(), jScriptEnabled() to javaScriptEnabled(),
2163           and improvements to the names of decoder classes and their source
2164           files (Decoder -> TextResourceDecoder, StreamingTextDecoder -> TextCodec)
2165
2166         * CMakeLists.txt:
2167         * WebCore.exp:
2168         * WebCore.vcproj/WebCore/WebCore.vcproj:
2169         * WebCore.xcodeproj/project.pbxproj:
2170         * WebCoreSources.bkl:
2171         * bindings/js/kjs_binding.cpp:
2172         (KJS::ScriptInterpreter::updateDOMNodeDocument):
2173         * bindings/js/kjs_events.cpp:
2174         (KJS::JSAbstractEventListener::handleEvent):
2175         (KJS::JSLazyEventListener::parseCode):
2176         * bindings/js/kjs_html.cpp:
2177         (KJS::JSHTMLElement::implementsCall):
2178         * bindings/js/kjs_traversal.cpp:
2179         (KJS::JSNodeFilterCondition::acceptNode):
2180         * bindings/js/kjs_window.cpp:
2181         (KJS::Window::interpreter):
2182         (KJS::Window::retrieveWindow):
2183         (KJS::Window::retrieve):
2184         (KJS::ScheduledAction::execute):
2185         * bindings/objc/DOMInternal.mm:
2186         (-[WebScriptObject _initializeScriptDOMNodeImp]):
2187         * bridge/mac/FrameMac.mm:
2188         (WebCore::FrameMac::executionContextForDOM):
2189         (WebCore::FrameMac::bindingRootObject):
2190         (WebCore::FrameMac::windowScriptObject):
2191         (WebCore::FrameMac::windowScriptNPObject):
2192         (WebCore::FrameMac::partClearedInBegin):
2193         * bridge/mac/WebCoreEncodings.mm:
2194         * bridge/mac/WebCoreFrameBridge.mm:
2195         (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]):
2196         (-[WebCoreFrameBridge stringWithData:]):
2197         (-[WebCoreFrameBridge executionContextForView:]):
2198         * bridge/win/FrameWin.cpp:
2199         * dom/Document.cpp:
2200         (WebCore::Document::inputEncoding):
2201         (WebCore::Document::setCharset):
2202         (WebCore::Document::createHTMLEventListener):
2203         (WebCore::Document::setDecoder):
2204         * dom/Document.h:
2205         (WebCore::Document::decoder):
2206         * dom/EventTargetNode.cpp:
2207         (WebCore::EventTargetNode::dispatchGenericEvent):
2208         * html/HTMLParser.cpp:
2209         (WebCore::HTMLParser::noscriptCreateErrorCheck):
2210         (WebCore::HTMLParser::canvasCreateErrorCheck):
2211         (WebCore::HTMLParser::isInline):
2212         * html/HTMLPlugInElement.cpp:
2213         (WebCore::HTMLPlugInElement::createNPObject):
2214         * html/HTMLScriptElement.cpp:
2215         (WebCore::HTMLScriptElement::evaluateScript):
2216         * html/HTMLTokenizer.cpp:
2217         (WebCore::HTMLTokenizer::parseTag):
2218         (WebCore::HTMLTokenizer::processToken):
2219         * ksvg2/misc/SVGDocumentExtensions.cpp:
2220         (WebCore::SVGDocumentExtensions::createSVGEventListener):
2221         * loader/CachedCSSStyleSheet.cpp:
2222         (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
2223         (WebCore::CachedCSSStyleSheet::setEncoding):
2224         * loader/CachedCSSStyleSheet.h:
2225         * loader/CachedXBLDocument.cpp:
2226         (WebCore::CachedXBLDocument::CachedXBLDocument):
2227         (WebCore::CachedXBLDocument::setEncoding):
2228         * loader/CachedXBLDocument.h:
2229         * loader/CachedXSLStyleSheet.cpp:
2230         (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
2231         (WebCore::CachedXSLStyleSheet::setEncoding):
2232         * loader/CachedXSLStyleSheet.h:
2233         * loader/Decoder.cpp: Removed.
2234         * loader/Decoder.h: Removed.
2235         * loader/FrameLoader.cpp:
2236         * loader/FrameLoader.h:
2237         * loader/FrameLoaderClient.h:
2238         * loader/MainResourceLoader.h: Added.
2239         * loader/NetscapePlugInStreamLoader.h: Added.
2240         * loader/Request.h:
2241         (WebCore::Request::cachedResource):
2242         * loader/ResourceLoader.h: Added.
2243         * loader/SubresourceLoader.h: Added.
2244         * loader/TextResourceDecoder.cpp: Added.
2245         (WebCore::TextResourceDecoder::determineContentType):
2246         (WebCore::TextResourceDecoder::defaultEncoding):
2247         (WebCore::TextResourceDecoder::TextResourceDecoder):
2248         (WebCore::TextResourceDecoder::~TextResourceDecoder):
2249         (WebCore::TextResourceDecoder::setEncoding):
2250         (WebCore::TextResourceDecoder::checkForBOM):
2251         (WebCore::TextResourceDecoder::checkForCSSCharset):
2252         (WebCore::TextResourceDecoder::checkForHeadCharset):
2253         (WebCore::TextResourceDecoder::detectJapaneseEncoding):
2254         (WebCore::TextResourceDecoder::decode):
2255         (WebCore::TextResourceDecoder::flush):
2256         * loader/TextResourceDecoder.h: Added.
2257         * loader/WebDocumentLoader.h: Removed.
2258         * loader/WebLoader.h: Removed.
2259         * loader/WebMainResourceLoader.h: Removed.
2260         * loader/WebNetscapePlugInStreamLoader.h: Removed.
2261         * loader/WebSubresourceLoader.h: Removed.
2262         * loader/loader.cpp:
2263         (WebCore::Loader::servePendingRequests):
2264         (WebCore::Loader::receivedAllData):
2265         (WebCore::Loader::receivedResponse):
2266         (WebCore::Loader::didReceiveData):
2267         (WebCore::Loader::cancelRequests):
2268         (WebCore::Loader::jobForRequest):
2269         * loader/mac/DocumentLoaderMac.mm:
2270         * loader/mac/FormDataStream.m: Added.
2271         * loader/mac/FrameLoaderMac.mm:
2272         (WebCore::FrameLoader::cancelPendingArchiveLoad):
2273         (WebCore::FrameLoader::addPlugInStreamLoader):
2274         (WebCore::FrameLoader::removePlugInStreamLoader):
2275         (WebCore::FrameLoader::addSubresourceLoader):
2276         (WebCore::FrameLoader::removeSubresourceLoader):
2277         (WebCore::FrameLoader::willSendRequest):
2278         (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
2279         (WebCore::FrameLoader::didCancelAuthenticationChallenge):
2280         (WebCore::FrameLoader::didReceiveResponse):
2281         (WebCore::FrameLoader::didReceiveData):
2282         (WebCore::FrameLoader::didFinishLoad):
2283         (WebCore::FrameLoader::didFailToLoad):
2284         (WebCore::FrameLoader::open):
2285         (WebCore::FrameLoader::willUseArchive):
2286         (WebCore::FrameLoader::isArchiveLoadPending):
2287         * loader/mac/ImageDocumentMac.mm:
2288         * loader/mac/LoaderFunctionsMac.mm:
2289         (WebCore::CheckCacheObjectStatus):
2290         * loader/mac/MainResourceLoaderMac.mm:
2291         (WebCore::MainResourceLoader::MainResourceLoader):
2292         (WebCore::MainResourceLoader::releaseDelegate):
2293         (WebCore::MainResourceLoader::didCancel):
2294         (WebCore::MainResourceLoader::addData):
2295         (WebCore::MainResourceLoader::willSendRequest):
2296         (WebCore::MainResourceLoader::continueAfterContentPolicy):
2297         (WebCore::MainResourceLoader::didReceiveData):
2298         (WebCore::MainResourceLoader::didFinishLoading):
2299         (WebCore::MainResourceLoader::setDefersLoading):
2300         * loader/mac/NetscapePlugInStreamLoaderMac.mm:
2301         (WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
2302         (WebCore::NetscapePlugInStreamLoader::releaseResources):
2303         (WebCore::NetscapePlugInStreamLoader::didReceiveResponse):
2304         (WebCore::NetscapePlugInStreamLoader::didReceiveData):
2305         (WebCore::NetscapePlugInStreamLoader::didFinishLoading):
2306         (WebCore::NetscapePlugInStreamLoader::didFail):
2307         (WebCore::NetscapePlugInStreamLoader::didCancel):
2308         * loader/mac/ResourceLoaderMac.mm:
2309         (WebCore::ResourceLoader::ResourceLoader):
2310         (WebCore::ResourceLoader::~ResourceLoader):
2311         (WebCore::ResourceLoader::releaseResources):
2312         (WebCore::ResourceLoader::load):
2313         (WebCore::ResourceLoader::setDefersLoading):
2314         (WebCore::ResourceLoader::frameLoader):
2315         (WebCore::ResourceLoader::addData):
2316         (WebCore::ResourceLoader::resourceData):
2317         (WebCore::ResourceLoader::clearResourceData):
2318         (WebCore::ResourceLoader::willSendRequest):
2319         (WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
2320         (WebCore::ResourceLoader::didCancelAuthenticationChallenge):
2321         (WebCore::ResourceLoader::didReceiveResponse):
2322         (WebCore::ResourceLoader::didReceiveData):
2323         (WebCore::ResourceLoader::willStopBufferingData):
2324         (WebCore::ResourceLoader::didFinishLoading):
2325         (WebCore::ResourceLoader::didFinishLoadingOnePart):
2326         (WebCore::ResourceLoader::didFail):
2327         (WebCore::ResourceLoader::willCacheResponse):
2328         (WebCore::ResourceLoader::didCancel):
2329         (WebCore::ResourceLoader::cancel):
2330         (WebCore::ResourceLoader::setIdentifier):
2331         (WebCore::ResourceLoader::response):
2332         (WebCore::ResourceLoader::inConnectionCallback):
2333         (WebCore::ResourceLoader::cancelledError):
2334         (WebCore::ResourceLoader::receivedCredential):
2335         (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential):
2336         (WebCore::ResourceLoader::receivedCancellation):
2337         (WebCore::ResourceLoader::delegate):
2338         (WebCore::ResourceLoader::releaseDelegate):
2339         (-[WebCoreResourceLoaderAsDelegate initWithLoader:]):
2340         * loader/mac/SubresourceLoaderMac.mm:
2341         (WebCore::SubresourceLoader::SubresourceLoader):
2342         (WebCore::SubresourceLoader::willSendRequest):
2343         (WebCore::SubresourceLoader::didReceiveResponse):
2344         (WebCore::SubresourceLoader::didReceiveData):
2345         (WebCore::SubresourceLoader::didFinishLoading):
2346         (WebCore::SubresourceLoader::didFail):
2347         (WebCore::SubresourceLoader::didCancel):
2348         * loader/mac/WebFormDataStream.h: Removed.
2349         * loader/mac/WebFormDataStream.m: Removed.
2350         * page/Frame.cpp:
2351         (WebCore::Frame::javaScriptEnabled):
2352         (WebCore::Frame::scriptProxy):
2353         (WebCore::Frame::executeScript):
2354         (WebCore::Frame::write):
2355         (WebCore::Frame::userGestureHint):
2356         (WebCore::Frame::saveInterpreterBuiltins):
2357         (WebCore::Frame::restoreInterpreterBuiltins):
2358         (WebCore::Frame::backslashAsCurrencySymbol):
2359         * page/Frame.h:
2360         * page/FramePrivate.h:
2361         * platform/StreamingTextDecoder.cpp: Removed.
2362         * platform/StreamingTextDecoder.h: Removed.
2363         * platform/StreamingTextDecoderICU.cpp: Removed.
2364         * platform/StreamingTextDecoderICU.h: Removed.
2365         * platform/TextCodec.cpp: Added.
2366         * platform/TextCodec.h: Added.
2367         * platform/TextCodecICU.cpp: Added.
2368         * platform/TextCodecICU.h: Added.
2369         * platform/TextCodecLatin1.h:
2370         * platform/TextCodecUTF16.h:
2371         * platform/TextDecoder.h:
2372         * platform/TextEncoding.cpp:
2373         * platform/TextEncodingRegistry.cpp:
2374         * platform/image-decoders/jpeg/jmorecfg.h:
2375         * platform/mac/StreamingTextDecoderMac.cpp: Removed.
2376         * platform/mac/StreamingTextDecoderMac.h: Removed.
2377         * platform/mac/TextCodecMac.cpp: Added.
2378         * platform/mac/TextCodecMac.h: Added.
2379         * platform/network/ResourceHandleInternal.h:
2380         * platform/network/mac/ResourceHandleMac.mm:
2381         * platform/qt/FrameQt.cpp:
2382         (WebCore::FrameQt::bindingRootObject):
2383         * platform/qt/LoaderFunctionsQt.cpp:
2384         (WebCore::CheckCacheObjectStatus):
2385         * rendering/RenderObject.cpp:
2386         (WebCore::RenderObject::backslashAsCurrencySymbol):
2387         * xml/XSLTProcessor.cpp:
2388         (WebCore::XSLTProcessor::createDocumentFromSource):
2389         * xml/xmlhttprequest.cpp:
2390         (WebCore::XMLHttpRequest::didReceiveData):
2391         * xml/xmlhttprequest.h:
2392
2393 2006-10-29  Darin Adler  <darin@apple.com>
2394
2395         Rubber stamped by Adam (kinda).
2396
2397         - add Mac suffixes and correct filenames inside loader/mac
2398
2399         * WebCore.xcodeproj/project.pbxproj: Updated for changes below.
2400
2401         * loader/mac/FrameLoader.mm: Removed.
2402         * loader/mac/WebDocumentLoader.mm: Removed.
2403         * loader/mac/WebLoader.mm: Removed.
2404         * loader/mac/WebMainResourceLoader.mm: Removed.
2405         * loader/mac/WebNetscapePlugInStreamLoader.mm: Removed.
2406         * loader/mac/WebSubresourceLoader.mm: Removed.
2407
2408         * loader/mac/FrameLoaderMac.mm: Added.
2409         * loader/mac/DocumentLoaderMac.mm: Added.
2410         * loader/mac/ResourceLoaderMac.mm: Added.
2411         * loader/mac/MainResourceLoaderMac.mm: Added.
2412         * loader/mac/WebNetscapePlugInStreamLoaderMac.mm: Added.
2413         * loader/mac/SubresourceLoaderMac.mm: Removed.
2414
2415 2006-10-29  Darin Adler  <darin@apple.com>
2416
2417         Reviewed by Adam.
2418
2419         - moving towards use of FrameLoader cross-platform; get FrameLoader.h
2420           and FrameLoader.cpp mostly ready
2421
2422         * WebCore.xcodeproj/project.pbxproj: Added FrameLoader.cpp and
2423         FormState.cpp. Removed WebFormState.mm.
2424
2425         * loader/FrameLoader.h: Put in lots of #if statements to see if we can
2426         get this header compiling on non-Mac.
2427         * loader/FrameLoader.cpp: Added. Has non-Mac-specific bits of FrameLoader.
2428         * loader/mac/FrameLoader.mm: Moved some non-Mac-specific bits out.
2429
2430         * loader/FrameLoaderClient.h: Added some ifdefs.
2431         * loader/WebDocumentLoader.h: Ditto.
2432         * loader/WebLoader.h: Ditto.
2433         * loader/WebMainResourceLoader.h: Ditto.
2434
2435         * loader/mac/WebDocumentLoader.mm:
2436         (WebCore::DocumentLoader::isLoadingInAPISense):
2437         Rewrote to work without bridge, partly to remove the need for ObjC
2438         bridge type in the header, and also because we're tearing down the bridge.
2439
2440         * loader/mac/WebMainResourceLoader.mm:
2441         (WebCore::MainResourceLoader::MainResourceLoader): Removed unused
2442         m_contentLength and m_bytesReceived.
2443         (WebCore::MainResourceLoader::didReceiveResponse): Ditto.
2444         (WebCore::MainResourceLoader::didReceiveData): Ditto.
2445
2446         * bridge/mac/WebCoreFrameBridge.h: Removed doneProcessingData.
2447         * bridge/mac/WebCoreFrameBridge.mm: Ditto.
2448
2449         * loader/mac/FormState.mm: Removed.
2450         * loader/FormState.cpp: Added.
2451
2452 2006-10-29  Darin Adler  <darin@apple.com>
2453
2454         Rubber stamped by Adam.
2455
2456         - moving towards use of FrameLoader cross-platform; move the headers
2457           for the Mac loader from loader/mac into loader, in preparation for
2458           making them useful on non-Mac
2459
2460         * WebCore.xcodeproj/project.pbxproj:
2461
2462         * loader/mac/FrameLoader.h: Removed.
2463         * loader/mac/WebDocumentLoader.h: Removed.
2464         * loader/mac/WebFormState.h: Removed.
2465         * loader/mac/WebLoader.h: Removed.
2466         * loader/mac/WebMainResourceLoader.h: Removed.
2467         * loader/mac/WebNetscapePlugInStreamLoader.h: Removed.
2468         * loader/mac/WebSubresourceLoader.h: Removed.
2469
2470         * loader/FrameLoader.h: Added.
2471         * loader/WebDocumentLoader.h: Added.
2472         * loader/WebFormState.h: Added.
2473         * loader/WebLoader.h: Added.
2474         * loader/WebMainResourceLoader.h: Added.
2475         * loader/WebNetscapePlugInStreamLoader.h: Added.
2476         * loader/WebSubresourceLoader.h: Added.
2477
2478 2006-10-29  Adam Roben  <aroben@apple.com>
2479
2480         Reviewed by Geoff.
2481
2482         Finish Darin's clean up of the use of __APPLE__ in WebCore, begun in
2483         r17405.
2484
2485         * platform/DeprecatedString.h:
2486
2487 2006-10-29  Beth Dakin  <bdakin@apple.com>
2488
2489         Rubber stamped by Geoff.
2490
2491         This is a followup to my HitTestResult checkin. Most of the 
2492         HitTestResult local variables in the code were named i or info for 
2493         when the class was named NodeInfo. This patch renames all of these 
2494         local variables to result.
2495
2496         * dom/Document.cpp:
2497         (WebCore::Document::prepareMouseEvent):
2498         * html/HTMLAreaElement.cpp:
2499         (WebCore::HTMLAreaElement::mapMouseEvent):
2500         * html/HTMLMapElement.cpp:
2501         (WebCore::HTMLMapElement::mapMouseEvent):
2502         * rendering/EllipsisBox.cpp:
2503         (WebCore::EllipsisBox::nodeAtPoint):
2504         * rendering/EllipsisBox.h:
2505         * rendering/InlineBox.cpp:
2506         (WebCore::InlineBox::nodeAtPoint):
2507         * rendering/InlineFlowBox.cpp:
2508         (WebCore::InlineFlowBox::nodeAtPoint):
2509         * rendering/InlineTextBox.cpp:
2510         (WebCore::InlineTextBox::nodeAtPoint):
2511         * rendering/RenderBlock.cpp:
2512         (WebCore::RenderBlock::isPointInScrollbar):
2513         (WebCore::RenderBlock::nodeAtPoint):
2514         * rendering/RenderBlock.h:
2515         * rendering/RenderBox.cpp:
2516         (WebCore::RenderBox::nodeAtPoint):
2517         * rendering/RenderBox.h:
2518         * rendering/RenderFlow.cpp:
2519         (WebCore::RenderFlow::hitTestLines):
2520         * rendering/RenderFlow.h:
2521         * rendering/RenderForeignObject.cpp:
2522         (WebCore::RenderForeignObject::nodeAtPoint):
2523         * rendering/RenderFrameSet.cpp:
2524         (WebCore::RenderFrameSet::nodeAtPoint):
2525         * rendering/RenderImage.cpp:
2526         (WebCore::RenderImage::nodeAtPoint):
2527         * rendering/RenderInline.cpp:
2528         (WebCore::RenderInline::nodeAtPoint):
2529         * rendering/RenderInline.h:
2530         * rendering/RenderLayer.cpp:
2531         (WebCore::RenderLayer::autoscroll):
2532         (WebCore::RenderLayer::hitTest):
2533         (WebCore::RenderLayer::hitTestLayer):
2534         (WebCore::RenderLayer::updateHoverActiveState):
2535         * rendering/RenderListBox.cpp:
2536         (WebCore::RenderListBox::isPointInScrollbar):
2537         * rendering/RenderObject.cpp:
2538         (WebCore::RenderObject::hitTest):
2539         (WebCore::RenderObject::setInnerNode):
2540         (WebCore::RenderObject::nodeAtPoint):
2541         * rendering/RenderObject.h:
2542         * rendering/RenderPath.cpp:
2543         (WebCore::RenderPath::nodeAtPoint):
2544         * rendering/RenderSVGImage.cpp:
2545         (WebCore::RenderSVGImage::nodeAtPoint):
2546         * rendering/RenderSVGText.cpp:
2547         (WebCore::RenderSVGText::nodeAtPoint):
2548         * rendering/RenderTableRow.cpp:
2549         (WebCore::RenderTableRow::nodeAtPoint):
2550         * rendering/RenderTableRow.h:
2551         * rendering/RenderTableSection.cpp:
2552         (WebCore::RenderTableSection::nodeAtPoint):
2553         * rendering/RenderTableSection.h:
2554         * rendering/RenderTextControl.cpp:
2555         (WebCore::RenderTextControl::nodeAtPoint):
2556         * rendering/RootInlineBox.cpp:
2557         (WebCore::RootInlineBox::nodeAtPoint):
2558         * rendering/RootInlineBox.h:
2559
2560 2006-10-29  Adam Roben  <aroben@apple.com>
2561
2562         More semi-fixes.
2563
2564         * page/Page.cpp: Forgot to wrap the actual definition of
2565         setDefersLoading() in PLATFORM(MAC).
2566         * platform/PlatformWheelEvent.h: Fix up preprocessor directives.
2567
2568 2006-10-29  Adam Roben  <aroben@apple.com>
2569
2570         Build semi-fix.
2571
2572         Move all FrameLoader-related code in Page.{cpp,h} within #if
2573         PLATFORM(MAC), since this class currently only exists on Mac.
2574
2575         * page/Page.cpp:
2576         * page/Page.h:
2577
2578 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2579
2580         build fix.
2581         
2582         * platform/PlatformString.h:
2583         (WebCore::String::operator NSString*):
2584
2585 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2586
2587         Rolled out accidental commit.
2588         
2589         * platform/AtomicString.h:
2590         (WebCore::AtomicString::AtomicString):
2591         (WebCore::AtomicString::operator NSString*):
2592
2593 2006-10-29  Geoffrey Garen  <ggaren@apple.com>
2594
2595         RS by Darin.
2596
2597         Rolled out change to map NULL Strings to nil NSStrings because it caused
2598         even more AppKit crashes. Maybe we should remove the NSString * operator
2599         entirely, since its use is not straight-forward, and require callers to
2600         specify explicitly whether they tolerate NULL.
2601         
2602         * platform/AtomicString.h:
2603         * platform/PlatformString.h:
2604         (WebCore::String::operator NSString*):
2605         * platform/mac/TextFieldMac.mm:
2606         (-[NSSearchFieldCell _addStringToRecentSearches:]):
2607
2608 2006-10-29  Darin Adler  <darin@apple.com>
2609
2610         Reviewed by Geoff.
2611
2612         - fixed storage leak showing up on the buildbot
2613
2614         * loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::create):
2615         Release the NSURLRequest after passing it to load. Also clean up logic a bit.
2616
2617 2006-10-29  Darin Adler  <darin@apple.com>
2618
2619         Rubber stamped by Adam.
2620
2621         - renamed WebFrameLoaderClient to match the class name inside it
2622
2623         * loader/mac/WebFrameLoaderClient.h: Removed.
2624         * loader/FrameLoaderClient.h: Moved it here.
2625
2626         * WebCore.xcodeproj/project.pbxproj: Updated project.
2627
2628         * bridge/mac/FrameMac.mm: Updated includes.
2629         * bridge/mac/WebCoreFrameBridge.mm: Ditto.
2630         * loader/mac/FrameLoader.mm: Ditto.
2631         * loader/mac/WebLoader.h: Ditto.
2632
2633 2006-10-29  Darin Adler  <darin@apple.com>
2634
2635         Reviewed by Mitz.
2636
2637         - fix crash visible on buildbot and also when running the test
2638           anchor-image-scrolled-x-y.html under libgmalloc
2639
2640         * loader/mac/WebSubresourceLoader.h: Renamed m_loader to m_handle
2641         now that the class is named ResourceHandle.
2642         * loader/mac/WebSubresourceLoader.mm: Renaming, plus:
2643         (WebCore::SubresourceLoader::didFinishLoading): Get the handle into
2644         a local RefPtr before calling finishJobAndHandle, since we might get
2645         cancelled inside that function, so we should not rely on m_handle to
2646         keep the ResourceHandle alive.
2647         (WebCore::SubresourceLoader::didFail): Ditto.
2648         (WebCore::SubresourceLoader::didCancel): Ditto.
2649
2650 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2651
2652         - build fix
2653
2654         * platform/network/mac/ResourceHandleMac.mm:
2655
2656 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2657
2658         Rubber stamped by Darin.
2659
2660         - renamed ResourceLoader to ResourceHandle (and same for related classes)
2661
2662         * CMakeLists.txt:
2663         * Projects/gdk/webcore-gdk.bkl:
2664         * WebCore.vcproj/WebCore/WebCore.vcproj:
2665         * WebCore.xcodeproj/project.pbxproj:
2666         * WebCoreSources.bkl:
2667         * bridge/mac/FrameMac.mm:
2668         * bridge/win/FrameWin.cpp:
2669         * dom/XMLTokenizer.cpp:
2670         * loader/Cache.cpp:
2671         * loader/CachedResource.h:
2672         * loader/LoaderFunctions.h:
2673         * loader/icon/IconLoader.cpp:
2674         (IconLoader::startLoading):
2675         (IconLoader::didReceiveData):
2676         (IconLoader::didFinishLoading):
2677         * loader/icon/IconLoader.h:
2678         * loader/loader.cpp:
2679         (WebCore::Loader::servePendingRequests):
2680         (WebCore::Loader::receivedAllData):
2681         (WebCore::Loader::receivedResponse):
2682         (WebCore::Loader::didReceiveData):
2683         (WebCore::Loader::cancelRequests):
2684         (WebCore::Loader::jobForRequest):
2685         * loader/loader.h:
2686         * loader/mac/IconLoaderMac.mm:
2687         (IconLoader::receivedResponse):
2688         * loader/mac/LoaderFunctionsMac.mm:
2689         * loader/mac/WebLoader.h:
2690         * loader/mac/WebSubresourceLoader.h:
2691         * loader/mac/WebSubresourceLoader.mm:
2692         (WebCore::SubresourceLoader::SubresourceLoader):
2693         (WebCore::SubresourceLoader::create):
2694         * platform/gdk/FrameGdk.cpp:
2695         (WebCore::FrameGdkClientDefault::FrameGdkClientDefault):
2696         (WebCore::FrameGdkClientDefault::openURL):
2697         (WebCore::FrameGdkClientDefault::submitForm):
2698         (WebCore::FrameGdkClientDefault::receivedResponse):
2699         (WebCore::FrameGdkClientDefault::didReceiveData):
2700         (WebCore::FrameGdkClientDefault::receivedAllData):
2701         * platform/gdk/FrameGdk.h:
2702         * platform/gdk/TemporaryLinkStubs.cpp:
2703         (WebCore::ServeSynchronousRequest):
2704         (WebCore::ResourceHandle::assembleResponseHeaders):
2705         (WebCore::ResourceHandle::retrieveCharset):
2706         * platform/network/ResourceHandle.cpp: Added.
2707         (WebCore::ResourceHandle::ResourceHandle):
2708         (WebCore::ResourceHandle::create):
2709         (WebCore::ResourceHandle::isErrorPage):
2710         (WebCore::ResourceHandle::error):
2711         (WebCore::ResourceHandle::setError):
2712         (WebCore::ResourceHandle::responseEncoding):
2713         (WebCore::ResourceHandle::responseHTTPHeadersAsString):
2714         (WebCore::ResourceHandle::kill):
2715         (WebCore::ResourceHandle::requestHeaders):
2716         (WebCore::ResourceHandle::url):
2717         (WebCore::ResourceHandle::postData):
2718         (WebCore::ResourceHandle::method):
2719         (WebCore::ResourceHandle::client):
2720         * platform/network/ResourceHandle.h: Added.
2721         (WebCore::ResourceHandle::getInternal):
2722         * platform/network/ResourceHandleClient.h: Added.
2723         (WebCore::ResourceHandleClient::~ResourceHandleClient):
2724         (WebCore::ResourceHandleClient::didReceiveData):
2725         (WebCore::ResourceHandleClient::didFinishLoading):
2726         (WebCore::ResourceHandleClient::receivedRedirect):
2727         (WebCore::ResourceHandleClient::receivedResponse):
2728         (WebCore::ResourceHandleClient::receivedAllData):
2729         * platform/network/ResourceHandleInternal.h: Added.
2730         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
2731         * platform/network/ResourceLoader.cpp: Removed.
2732         * platform/network/ResourceLoader.h: Removed.
2733         * platform/network/ResourceLoaderClient.h: Removed.
2734         * platform/network/ResourceLoaderInternal.h: Removed.
2735         * platform/network/cf/ResourceHandleCFNet.cpp: Added.
2736         (WebCore::willSendRequest):
2737         (WebCore::didReceiveResponse):
2738         (WebCore::didReceiveData):
2739         (WebCore::didFinishLoading):
2740         (WebCore::didFail):
2741         (WebCore::willCacheResponse):
2742         (WebCore::didReceiveChallenge):
2743         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2744         (WebCore::ResourceHandle::~ResourceHandle):
2745         (WebCore::ResourceHandle::start):
2746         (WebCore::ResourceHandle::cancel):
2747         * platform/network/cf/ResourceLoaderCFNet.cpp: Removed.
2748         * platform/network/gdk/ResourceHandleCurl.cpp: Added.
2749         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2750         (WebCore::ResourceHandle::~ResourceHandle):
2751         (WebCore::ResourceHandle::start):
2752         (WebCore::ResourceHandle::cancel):
2753         * platform/network/gdk/ResourceHandleManager.cpp: Added.
2754         (WebCore::ResourceHandleManager::ResourceHandleManager):
2755         (WebCore::ResourceHandleManager::get):
2756         (WebCore::ResourceHandleManager::useSimpleTransfer):
2757         (WebCore::writeCallback):
2758         (WebCore::ResourceHandleManager::downloadTimerCallback):
2759         (WebCore::ResourceHandleManager::remove):
2760         (WebCore::ResourceHandleManager::add):
2761         (WebCore::ResourceHandleManager::cancel):
2762         * platform/network/gdk/ResourceHandleManager.h: Added.
2763         * platform/network/gdk/ResourceLoaderCurl.cpp: Removed.
2764         * platform/network/gdk/ResourceLoaderManager.cpp: Removed.
2765         * platform/network/gdk/ResourceLoaderManager.h: Removed.
2766         * platform/network/mac/ResourceHandleMac.mm: Added.
2767         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2768         (WebCore::ResourceHandle::~ResourceHandle):
2769         (WebCore::ResourceHandle::start):
2770         (WebCore::ResourceHandle::assembleResponseHeaders):
2771         (WebCore::ResourceHandle::retrieveResponseEncoding):
2772         (WebCore::ResourceHandle::receivedResponse):
2773         (WebCore::ResourceHandle::cancel):
2774         (WebCore::ResourceHandle::redirectedToURL):
2775         (WebCore::ResourceHandle::addData):
2776         (WebCore::ResourceHandle::finishJobAndHandle):
2777         (WebCore::ResourceHandle::reportError):
2778         * platform/network/mac/ResourceLoaderMac.mm: Removed.
2779         * platform/network/qt/ResourceHandleManager.cpp: Added.
2780         (WebCore::ResourceHandleManager::ResourceHandleManager):
2781         (WebCore::ResourceHandleManager::~ResourceHandleManager):
2782         (WebCore::ResourceHandleManager::self):
2783         (WebCore::ResourceHandleManager::slotData):
2784         (WebCore::ResourceHandleManager::slotMimetype):
2785         (WebCore::ResourceHandleManager::slotResult):
2786         (WebCore::ResourceHandleManager::remove):
2787         (WebCore::ResourceHandleManager::add):
2788         (WebCore::ResourceHandleManager::cancel):
2789         * platform/network/qt/ResourceHandleManager.h: Added.
2790         * platform/network/qt/ResourceHandleQt.cpp: Added.
2791         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2792         (WebCore::ResourceHandle::~ResourceHandle):
2793         (WebCore::ResourceHandle::start):
2794         (WebCore::ResourceHandle::cancel):
2795         (WebCore::ResourceHandle::assembleResponseHeaders):
2796         (WebCore::ResourceHandle::retrieveResponseEncoding):
2797         (WebCore::ResourceHandle::receivedResponse):
2798         (WebCore::ResourceHandle::extractCharsetFromHeaders):
2799         * platform/network/qt/ResourceLoaderManager.cpp: Removed.
2800         * platform/network/qt/ResourceLoaderManager.h: Removed.
2801         * platform/network/qt/ResourceLoaderQt.cpp: Removed.
2802         * platform/network/win/ResourceHandleWin.cpp: Added.
2803         (WebCore::):
2804         (WebCore::addToOutstandingJobs):
2805         (WebCore::lookupResourceHandle):
2806         (WebCore::ResourceHandleWndProc):
2807         (WebCore::initializeOffScreenResourceHandleWindow):
2808         (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
2809         (WebCore::ResourceHandle::~ResourceHandle):
2810         (WebCore::ResourceHandle::onHandleCreated):
2811         (WebCore::ResourceHandle::onRequestRedirected):
2812         (WebCore::ResourceHandle::onRequestComplete):
2813         (WebCore::ResourceHandle::start):
2814         (WebCore::ResourceHandle::fileLoadTimer):
2815         (WebCore::ResourceHandle::cancel):
2816         (WebCore::ResourceHandle::setHasReceivedResponse):
2817         (WebCore::ResourceHandle::hasReceivedResponse):
2818         * platform/network/win/ResourceHandleWin.h: Added.
2819         * platform/network/win/ResourceLoaderWin.cpp: Removed.
2820         * platform/network/win/ResourceLoaderWin.h: Removed.
2821         * platform/qt/FrameQt.cpp:
2822         * platform/qt/FrameQtClient.cpp:
2823         (WebCore::FrameQtClientDefault::openURL):
2824         (WebCore::FrameQtClientDefault::submitForm):
2825         (WebCore::FrameQtClientDefault::receivedResponse):
2826         (WebCore::FrameQtClientDefault::didReceiveData):
2827         (WebCore::FrameQtClientDefault::receivedAllData):
2828         * platform/qt/FrameQtClient.h:
2829         * platform/win/TemporaryLinkStubs.cpp:
2830         (WebCore::ResourceHandle::assembleResponseHeaders):
2831         (WebCore::ResourceHandle::retrieveResponseEncoding):
2832         (WebCore::ServeSynchronousRequest):
2833         * xml/XSLTProcessor.cpp:
2834         * xml/xmlhttprequest.cpp:
2835         (WebCore::XMLHttpRequest::send):
2836         (WebCore::XMLHttpRequest::didFinishLoading):
2837         (WebCore::XMLHttpRequest::receivedRedirect):
2838         (WebCore::XMLHttpRequest::didReceiveData):
2839         * xml/xmlhttprequest.h:
2840
2841 t2006-10-29  Darin Adler  <darin@apple.com>
2842
2843         Reviewed by Maciej.
2844
2845         - eliminate use of NSArray to carry form data around
2846
2847         * WebCore.exp:
2848         * WebCore.xcodeproj/project.pbxproj:
2849         * bridge/mac/FormDataMac.h: Removed.
2850         * bridge/mac/FormDataMac.mm: Removed.
2851         * bridge/mac/FrameMac.h:
2852         * bridge/mac/WebCoreFrameBridge.h:
2853         * bridge/mac/WebCoreFrameBridge.mm:
2854         * html/HTMLFormElement.cpp:
2855         (WebCore::HTMLFormElement::submit):
2856         * loader/FormData.h:
2857         (WebCore::FormData::isEmpty):
2858         * loader/mac/FrameLoader.h:
2859         * loader/mac/FrameLoader.mm:
2860         (WebCore::FrameLoader::load):
2861         (WebCore::FrameLoader::post):
2862         (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
2863         (WebCore::FrameLoader::loadResourceSynchronously):
2864         * loader/mac/LoaderFunctionsMac.mm:
2865         (WebCore::ServeSynchronousRequest):
2866         * loader/mac/WebFormDataStream.h:
2867         * loader/mac/WebFormDataStream.m:
2868         (WebCore::pairRetain):
2869         (WebCore::pairRelease):
2870         (WebCore::pairEqual):
2871         (WebCore::pairHash):
2872         (WebCore::closeCurrentStream):
2873         (WebCore::scheduleWithPair):
2874         (WebCore::advanceCurrentStream):
2875         (WebCore::openNextStream):
2876         (WebCore::formCreate):
2877         (WebCore::formFinalize):
2878         (WebCore::formOpen):
2879         (WebCore::formRead):
2880         (WebCore::formCanRead):
2881         (WebCore::formClose):
2882         (WebCore::formSchedule):
2883         (WebCore::formUnschedule):
2884         (WebCore::formEventCallback):
2885         (WebCore::setHTTPBody):
2886         * loader/mac/WebSubresourceLoader.h:
2887         * loader/mac/WebSubresourceLoader.mm:
2888         (WebCore::SubresourceLoader::create):
2889         * platform/network/mac/ResourceLoaderMac.mm:
2890
2891 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2892
2893         Reviewed by Darin.
2894
2895         - create SubresourceLoader with a ResourceRequest, not broken out request bits
2896
2897         * loader/mac/WebSubresourceLoader.h:
2898         * loader/mac/WebSubresourceLoader.mm:
2899         (WebCore::SubresourceLoader::create):
2900         * platform/network/mac/ResourceLoaderMac.mm:
2901         (WebCore::ResourceLoader::start):
2902
2903 2006-10-29  Maciej Stachowiak  <mjs@apple.com>
2904
2905         Reviewed by Darin.
2906
2907         - removed ObjC glue between ResourceLoader and SubresourceLoader, then now talk to each other directly
2908
2909         Removed WebCoreResourceLoader, WebCoreResourceHandle and WebCoreResourceLoaderImp
2910         
2911         * WebCore.xcodeproj/project.pbxproj:
2912         * bridge/mac/WebCoreFrameBridge.h:
2913         * loader/mac/FrameLoader.h:
2914         * loader/mac/FrameLoader.mm:
2915         * loader/mac/LoaderFunctionsMac.mm:
2916         * loader/mac/WebLoader.h:
2917         * loader/mac/WebSubresourceLoader.h:
2918         * loader/mac/WebSubresourceLoader.mm:
2919         (WebCore::SubresourceLoader::SubresourceLoader):
2920         (WebCore::SubresourceLoader::create):
2921         (WebCore::SubresourceLoader::willSendRequest):
2922         (WebCore::SubresourceLoader::didReceiveResponse):
2923         (WebCore::SubresourceLoader::didReceiveData):
2924         (WebCore::SubresourceLoader::didFinishLoading):
2925         (WebCore::SubresourceLoader::didFail):
2926         (WebCore::SubresourceLoader::didCancel):
2927         * platform/network/ResourceLoader.h:
2928         * platform/network/ResourceLoaderInternal.h:
2929         * platform/network/mac/ResourceLoaderMac.mm:
2930         (WebCore::ResourceLoader::~ResourceLoader):
2931         (WebCore::ResourceLoader::start):
2932         (WebCore::ResourceLoader::receivedResponse):
2933         (WebCore::ResourceLoader::cancel):
2934         (WebCore::ResourceLoader::redirectedToURL):
2935         (WebCore::ResourceLoader::addData):
2936         (WebCore::ResourceLoader::finishJobAndHandle):
2937         (WebCore::ResourceLoader::reportError):
2938         * platform/network/mac/WebCoreResourceLoader.h: Removed.
2939         * platform/network/mac/WebCoreResourceLoaderImp.h: Removed.
2940         * platform/network/mac/WebCoreResourceLoaderImp.mm: Removed.
2941
2942 2006-10-28  Darin Adler  <darin@apple.com>
2943
2944         Reviewed by Maciej.
2945
2946         - eliminated the use of Objective-C for the policy decider
2947           machinery, obviating the need for WebPolicyDecider,
2948           WebCoreFrameLoaderAsDelegate, and
2949           WebCoreMainResourceLoaderAsPolicyDelegate
2950
2951         - grouped the state related to policy decisions into a PolicyCheck
2952           class to simplify the FrameLoader logic
2953
2954         - removed six methods from the bridge, reducing FrameLoader's use of
2955           the bridge to a single method
2956
2957         - changed form state to always use HashMap instead of NSDictionary
2958
2959         - moved the defersLoading flag from WebView to WebCore::Page
2960           and changed code to consistently call it defersLoading rather
2961           than defersCallbacks
2962
2963         - updated for rename of PassRefPtr::release to releaseRef
2964         - replaced all uses of __APPLE__ with appropriate PLATFORM defines
2965         - cleaned up kjs_binding.h a bit
2966         - cleaned up FrameMac.h a bit
2967
2968         * loader/mac/WebPolicyDecider.h: Removed.
2969         * loader/mac/WebPolicyDecider.mm: Removed.
2970         * WebCore.xcodeproj/project.pbxproj: Updated for removal.
2971
2972         * WebCore.exp:
2973         * bindings/js/kjs_binding.cpp:
2974         (KJS::ScriptInterpreter::ScriptInterpreter):
2975         (KJS::ScriptInterpreter::wasRunByUserGesture):
2976         * bindings/js/kjs_binding.h:
2977         (KJS::ScriptInterpreter::setCurrentEvent):
2978         (KJS::ScriptInterpreter::setInlineCode):
2979         (KJS::ScriptInterpreter::setProcessingTimerCallback):
2980         (KJS::ScriptInterpreter::getCurrentEvent):
2981         (KJS::cacheDOMObject):
2982         (KJS::DOMExceptionTranslator::DOMExceptionTranslator):
2983         * bridge/AXObjectCache.h:
2984         * bridge/mac/BrowserExtensionMac.mm:
2985         (WebCore::BrowserExtensionMac::createNewWindow):
2986         * bridge/mac/FrameMac.h:
2987         * bridge/mac/FrameMac.mm:
2988         (WebCore::FrameMac::loadRequest):
2989         (WebCore::FrameMac::submitForm):
2990         (WebCore::FrameMac::urlSelected):
2991         (WebCore::FrameMac::userAgent):
2992         (WebCore::FrameMac::passMouseDownEventToWidget):
2993         (WebCore::FrameMac::handleMouseMoveEvent):
2994         * bridge/mac/PageMac.mm:
2995         (WebCore::Page::Page):
2996         * bridge/mac/WebCoreEditCommand.mm:
2997         * bridge/mac/WebCoreFrameBridge.h:
2998         * bridge/mac/WebCoreFrameBridge.mm:
2999         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
3000         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
3001         * css/CSSComputedStyleDeclaration.cpp:
3002         (WebCore::):
3003         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
3004         * css/CSSPrimitiveValue.cpp:
3005         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
3006         (WebCore::CSSPrimitiveValue::cleanup):
3007         (WebCore::CSSPrimitiveValue::cssText):
3008         * css/CSSPrimitiveValue.h:
3009         (WebCore::CSSPrimitiveValue::):
3010         * css/CSSValueList.cpp:
3011         (WebCore::CSSValueList::append):
3012         * css/cssparser.cpp:
3013         (WebCore::CSSParser::parseValue):
3014         * css/cssparser.h:
3015         * css/cssstyleselector.cpp:
3016         (WebCore::CSSStyleSelector::applyProperty):
3017         * dom/Document.cpp:
3018         (WebCore::Document::Document):
3019         (WebCore::Document::updateSelection):
3020         (WebCore::Document::implicitClose):
3021         (WebCore::Document::setFocusNode):
3022         * dom/Document.h:
3023         * editing/ReplaceSelectionCommand.h:
3024         * html/HTMLParser.cpp:
3025         (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
3026         * loader/mac/FrameLoader.h:
3027         (WebCore::PolicyCheck::request):
3028         * loader/mac/FrameLoader.mm:
3029         (WebCore::FrameLoader::~FrameLoader):
3030         (WebCore::FrameLoader::safeLoad):
3031         (WebCore::FrameLoader::load):
3032         (WebCore::FrameLoader::open):
3033         (WebCore::FrameLoader::stopLoading):
3034         (WebCore::setAllDefersLoading):
3035         (WebCore::FrameLoader::setDefersLoading):
3036         (WebCore::FrameLoader::willSendRequest):
3037         (WebCore::FrameLoader::receivedMainResourceError):
3038         (WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy):
3039         (WebCore::FrameLoader::commitProvisionalLoad):
3040         (WebCore::FrameLoader::checkNavigationPolicy):
3041         (WebCore::FrameLoader::checkContentPolicy):
3042         (WebCore::FrameLoader::cancelContentPolicyCheck):
3043         (WebCore::FrameLoader::stopPolicyCheck):
3044         (WebCore::FrameLoader::checkNewWindowPolicy):
3045         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
3046         (WebCore::FrameLoader::continueAfterNavigationPolicy):
3047         (WebCore::FrameLoader::continueAfterContentPolicy):
3048         (WebCore::FrameLoader::continueAfterWillSubmitForm):
3049         (WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy):
3050         (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
3051         (WebCore::FrameLoader::closeDocument):
3052         (WebCore::FrameLoader::transitionToCommitted):
3053         (WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy):
3054         (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
3055         (WebCore::FrameLoader::post):
3056         (WebCore::FrameLoader::detachFromParent):
3057         (WebCore::FrameLoader::addExtraFieldsToRequest):
3058         (WebCore::PolicyCheck::PolicyCheck):
3059         (WebCore::PolicyCheck::clear):
3060         (WebCore::PolicyCheck::set):
3061         (WebCore::PolicyCheck::call):
3062         (WebCore::PolicyCheck::dropRequest):
3063         (WebCore::FrameLoaderClient::~FrameLoaderClient):
3064         * loader/mac/WebFormState.h:
3065         * loader/mac/WebFormState.mm:
3066         * loader/mac/WebFrameLoaderClient.h:
3067         * loader/mac/WebLoader.h:
3068         (WebCore::WebResourceLoader::defersLoading):
3069         * loader/mac/WebLoader.mm:
3070         (WebCore::WebResourceLoader::WebResourceLoader):
3071         (WebCore::WebResourceLoader::load):
3072         (WebCore::WebResourceLoader::setDefersLoading):
3073         * loader/mac/WebMainResourceLoader.h:
3074         * loader/mac/WebMainResourceLoader.mm:
3075         (WebCore::MainResourceLoader::MainResourceLoader):
3076         (WebCore::MainResourceLoader::releaseDelegate):
3077         (WebCore::MainResourceLoader::didCancel):
3078         (WebCore::MainResourceLoader::callContinueAfterNavigationPolicy):
3079         (WebCore::MainResourceLoader::continueAfterNavigationPolicy):
3080         (WebCore::MainResourceLoader::willSendRequest):
3081         (WebCore::MainResourceLoader::callContinueAfterContentPolicy):
3082         (WebCore::MainResourceLoader::continueAfterContentPolicy):
3083         (WebCore::MainResourceLoader::didReceiveResponse):
3084         (WebCore::MainResourceLoader::didReceiveData):
3085         (WebCore::MainResourceLoader::didFinishLoading):
3086         (WebCore::MainResourceLoader::didFail):
3087         (WebCore::MainResourceLoader::loadNow):
3088         (WebCore::MainResourceLoader::load):
3089         (WebCore::MainResourceLoader::setDefersLoading):
3090         * page/Frame.cpp:
3091         (WebCore::Frame::paint):
3092         * page/FrameView.cpp:
3093         (WebCore::FrameView::layout):
3094         * page/FrameView.h:
3095         * page/Page.cpp:
3096         (WebCore::Page::setDefersLoading):
3097         * page/Page.h:
3098         (WebCore::Page::defersLoading):
3099         * platform/DeprecatedString.h:
3100         * platform/DeprecatedStringList.h:
3101         * platform/FontFallbackList.h:
3102         * platform/PlatformKeyboardEvent.h:
3103         * platform/PlatformMouseEvent.h:
3104         * platform/PlatformWheelEvent.h:
3105         * platform/mac/ClipboardMac.h:
3106         * platform/mac/ClipboardMac.mm:
3107         (WebCore::ClipboardMac::setDragImage):
3108         (WebCore::ClipboardMac::dragNSImage):
3109         (WebCore::ClipboardMac::sourceOperation):
3110         (WebCore::ClipboardMac::destinationOperation):
3111         * rendering/RenderObject.cpp:
3112         (WebCore::RenderObject::setStyle):
3113         * rendering/break_lines.cpp:
3114         (WebCore::nextBreakablePosition):
3115
3116 2006-10-28  Adam Roben  <aroben@apple.com>
3117
3118         Reviewed by Maciej.
3119
3120         Fix layout tests that broke after r17399. Mitz discovered that the
3121         failures were caused by HitTestResult::m_point being uninitialized
3122         much of the time. HitTestResults are now always constructed with a
3123         point, and RenderLayer::hitTest and RenderLayer::hitTestLayer use that
3124         point instead of being passed one explicitly.
3125
3126         * WebCore.exp: Change constructor symbol.
3127         * bridge/mac/FrameMac.mm:
3128         (WebCore::FrameMac::eventMayStartDrag): Update to new constructor and
3129         hitTest().
3130         (WebCore::FrameMac::handleMouseMoveEvent): Ditto.
3131         * bridge/mac/WebCoreAXObject.mm:
3132         (-[WebCoreAXObject doAXTextMarkerForPosition:]): Ditto.
3133         (-[WebCoreAXObject accessibilityHitTest:]): Ditto.
3134         * dom/Document.cpp:
3135         (WebCore::Document::elementFromPoint): Ditto.
3136         (WebCore::Document::prepareMouseEvent): Ditto.
3137         * page/Frame.cpp:
3138         (WebCore::Frame::isPointInsideSelection): Ditto.
3139         (WebCore::Frame::hitTestResultAtPoint): Ditto.
3140         * page/FrameView.cpp:
3141         (WebCore::FrameView::handleWheelEvent): Ditto.
3142         * rendering/HitTestResult.cpp:
3143         (WebCore::HitTestResult::HitTestResult): Initalize m_point with the
3144         passed point.
3145         * rendering/HitTestResult.h: Update constructor declaration.
3146         * rendering/RenderLayer.cpp:
3147         (WebCore::RenderLayer::autoscroll): Update to new constructor and
3148         hitTest().
3149         (WebCore::RenderLayer::hitTest): Use the IntPoint stored in the
3150         HitTestResult instead of being passed one.
3151         (WebCore::RenderLayer::hitTestLayer): Ditto.
3152         * rendering/RenderLayer.h: Update declarations.
3153
3154 2006-10-28  Nikolas Zimmermann  <zimmermann@kde.org>
3155
3156         Reviewed by Anders.
3157
3158         Fix Qt/Linux build.
3159
3160         * CMakeLists.txt:
3161         * platform/qt/FrameQtClient.cpp:
3162         (WebCore::numRequests):
3163         (WebCore::FrameQtClientDefault::numPendingOrLoadingRequests):
3164         * platform/qt/PopupMenuQt.cpp:
3165         (WebCore::PopupMenu::updateFromElement):
3166
3167 2006-10-28  David Carson  <dacarson@gmail.com>
3168
3169         Tweaked by Sam. Reviewed by Brady.
3170
3171         Fix for: http://bugs.webkit.org/show_bug.cgi?id=11437
3172         Initialize m_modifyBiasSet to false, as it sometimes gets 
3173         used before it has been initalized.
3174
3175         * editing/SelectionController.cpp:
3176         (WebCore::SelectionController::SelectionController):
3177
3178 2006-10-28  Beth Dakin  <bdakin@apple.com>
3179
3180         Reviewed by Darin.
3181
3182         This is the WebCore half of pushing elementAtPoint and the backend 
3183         of WebElementDictionary into WebCore. Most of the changes below are 
3184         to accommodate one of the following:
3185                 
3186         -NodeInfo is now a stand-alone class called HitTestResult. 
3187                 Previously it was defined in RenderObject.h, but not for 
3188                 any particular reason. The WebElementDictionary 
3189                 functionality that was pushed into WebCore has been pushed 
3190                 specifically into the this class. In fact, 
3191                 WebElementDictionary now keeps a HitTestResult as a member 
3192                 varibale.
3193                 
3194         -The enumeration AccessPolicy is now called 
3195                 ClipboardAccessPolicy and is defined in its own header. It 
3196                 was previously defined in ClipboardMac.h, but is now 
3197                 defined independently to avoid including ClipboardMac.h 
3198                 from within FrameMac.h since FrameMac.h is now included in 
3199                 WebElementDictionary.m in WebKit.
3200                 
3201         -Element now has a virtual target() for the sake of 
3202                 NodeInfo::targetFrame() 
3203
3204         * WebCore.exp: Several WebCore functions are newly called from 
3205         WebKit, so they have been added here. 
3206         * WebCore.xcodeproj/project.pbxproj:
3207         * bindings/objc/DOM.mm: Must include Image.h because of adjustments 
3208         to ClipboardMac.
3209         * bridge/mac/FrameMac.h: Adjust to HitTestResult changes.
3210         * bridge/mac/FrameMac.mm:
3211         (WebCore::FrameMac::freeClipboard): Adjust to ClipboardAccessPolicy 
3212         and HitTestResult changes.
3213         (WebCore::FrameMac::eventMayStartDrag): Same.
3214         (WebCore::FrameMac::handleMouseMoveEvent): Same.
3215         (WebCore::FrameMac::dispatchCPPEvent): Same.
3216         (WebCore::FrameMac::mayDHTMLCut): Same.
3217         (WebCore::FrameMac::mayDHTMLCopy): Same.
3218         (WebCore::FrameMac::mayDHTMLPaste): Same.
3219         (WebCore::FrameMac::tryDHTMLCut): Same
3220         (WebCore::FrameMac::tryDHTMLCopy): Same.
3221         (WebCore::FrameMac::tryDHTMLPaste): Same.
3222         * bridge/mac/WebCoreAXObject.mm:
3223         (-[WebCoreAXObject doAXTextMarkerForPosition:]): Adjust to 
3224         HitTestResult changes.
3225         (-[WebCoreAXObject accessibilityHitTest:]): Same.
3226         * bridge/mac/WebCoreFrameBridge.h: Same.
3227         * bridge/mac/WebCoreFrameBridge.mm:
3228         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): Adjust for 
3229         ClipboardAccessPolicy changes.
3230         (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): Same.
3231         (-[WebCoreFrameBridge concludeDragForDraggingInfo:]): Same.
3232         * dom/Document.cpp:
3233         (WebCore::Document::elementFromPoint): Adjust for HitTestResult 
3234         changes.
3235         (WebCore::Document::prepareMouseEvent): Same.
3236         * dom/Element.h:
3237         (WebCore::Element::target): Now has a virtual target()
3238         * html/HTMLAnchorElement.h: Same.
3239         * html/HTMLAreaElement.cpp:
3240         (WebCore::HTMLAreaElement::mapMouseEvent): Adjust for HitTestResult 
3241         changes.
3242         * html/HTMLAreaElement.h: Virtual target()
3243         * html/HTMLBaseElement.h:
3244         (WebCore::HTMLBaseElement::target): Same.
3245         * html/HTMLFormElement.h: Same.
3246         * html/HTMLLinkElement.h: Same.
3247         * html/HTMLMapElement.cpp:
3248         (WebCore::HTMLMapElement::mapMouseEvent): Adjust for HitTestResult 
3249         changes.
3250         * html/HTMLMapElement.h: Same.
3251         * page/Frame.cpp:
3252         (WebCore::Frame::isPointInsideSelection): Same.
3253         (WebCore::Frame::hitTestResultAtPoint): Same. 
3254         * page/Frame.h: Same.
3255         * page/FrameView.cpp:
3256         (WebCore::FrameView::handleWheelEvent): Same.
3257         * platform/mac/ClipboardAccessPolicy.h: Added.
3258         (WebCore::):
3259         * platform/mac/ClipboardMac.h: Remove definition of AccessPolicy, 
3260         include ClipboardAccessPolicy.h, and rename AccessPolicy to 
3261         ClipboardAccessPolicy.
3262         * platform/mac/ClipboardMac.mm: Rename ClipboardAccessPolicy.
3263         (WebCore::ClipboardMac::ClipboardMac):
3264         (WebCore::ClipboardMac::setAccessPolicy):
3265         (WebCore::ClipboardMac::clearData):
3266         (WebCore::ClipboardMac::clearAllData):
3267         (WebCore::ClipboardMac::getData):
3268         (WebCore::ClipboardMac::setData):
3269         (WebCore::ClipboardMac::types):
3270         (WebCore::ClipboardMac::setDragImage):
3271         (WebCore::ClipboardMac::setDropEffect):
3272         (WebCore::ClipboardMac::setEffectAllowed):
3273         * rendering/EllipsisBox.cpp:
3274         (WebCore::EllipsisBox::nodeAtPoint): Adjust for HitTestResult 
3275         changes.
3276         * rendering/EllipsisBox.h:
3277         * rendering/HitTestResult.cpp: Added.
3278         (WebCore::HitTestResult::HitTestResult):
3279         (WebCore::HitTestResult::~HitTestResult):
3280         (WebCore::HitTestResult::operator=):
3281         (WebCore::HitTestResult::setInnerNode):
3282         (WebCore::HitTestResult::setInnerNonSharedNode):
3283         (WebCore::HitTestResult::setURLElement):
3284         (WebCore::HitTestResult::setScrollbar):
3285         (WebCore::HitTestResult::targetFrame):
3286         (WebCore::HitTestResult::boundingBox):
3287         (WebCore::HitTestResult::isSelected):
3288         (WebCore::HitTestResult::title):
3289         * rendering/HitTestResult.h: Added.
3290         (WebCore::HitTestResult::readonly):
3291         (WebCore::HitTestResult::active):
3292         (WebCore::HitTestResult::mouseMove):
3293         (WebCore::HitTestResult::innerNode):
3294         (WebCore::HitTestResult::innerNonSharedNode):
3295         (WebCore::HitTestResult::point):
3296         (WebCore::HitTestResult::URLElement):
3297         (WebCore::HitTestResult::scrollbar):
3298         (WebCore::HitTestResult::setPoint):
3299         (WebCore::HitTestResult::setReadonly):
3300         (WebCore::HitTestResult::setActive):
3301         (WebCore::HitTestResult::setMouseMove):
3302         * rendering/InlineBox.cpp:
3303         (WebCore::InlineBox::nodeAtPoint): Adjust to HitTestResult changes.
3304         * rendering/InlineBox.h: Same.
3305         * rendering/InlineFlowBox.cpp:
3306         (WebCore::InlineFlowBox::nodeAtPoint): Same.
3307         * rendering/InlineFlowBox.h: Same.
3308         * rendering/InlineTextBox.cpp: 
3309         (WebCore::InlineTextBox::nodeAtPoint): Same.
3310         * rendering/InlineTextBox.h: Same.
3311         * rendering/RenderBlock.cpp:
3312         (WebCore::RenderBlock::isPointInScrollbar): Same.
3313         (WebCore::RenderBlock::nodeAtPoint): Same.
3314         * rendering/RenderBlock.h: Same.
3315         * rendering/RenderBox.cpp:
3316         (WebCore::RenderBox::nodeAtPoint): Same.
3317         * rendering/RenderBox.h: Same.
3318         * rendering/RenderFlow.cpp:
3319         (WebCore::RenderFlow::hitTestLines): Same.
3320         * rendering/RenderFlow.h: Same.
3321         * rendering/RenderForeignObject.cpp:
3322         (WebCore::RenderForeignObject::nodeAtPoint): Same.
3323         * rendering/RenderForeignObject.h: Same.
3324         * rendering/RenderFrameSet.cpp:
3325         (WebCore::RenderFrameSet::nodeAtPoint): Same.
3326         * rendering/RenderFrameSet.h: Same.
3327         * rendering/RenderImage.cpp:
3328         (WebCore::RenderImage::nodeAtPoint): Same.
3329         * rendering/RenderImage.h: Same.
3330         * rendering/RenderInline.cpp:
3331         (WebCore::RenderInline::nodeAtPoint): Same.
3332         * rendering/RenderInline.h: Same.
3333         * rendering/RenderLayer.cpp:
3334         (WebCore::RenderLayer::autoscroll): Same.
3335         (WebCore::RenderLayer::hitTest): Same.
3336         (WebCore::RenderLayer::hitTestLayer): Same.
3337         (WebCore::RenderLayer::updateHoverActiveState): Same.
3338         * rendering/RenderLayer.h: Same.
3339         * rendering/RenderListBox.cpp:
3340         (WebCore::RenderListBox::isPointInScrollbar): Same.
3341         * rendering/RenderListBox.h: Same.
3342         * rendering/RenderObject.cpp:
3343         (WebCore::RenderObject::hitTest): Same.
3344         (WebCore::RenderObject::setInnerNode): Same.
3345         (WebCore::RenderObject::nodeAtPoint): Same.
3346         * rendering/RenderObject.h: Remove NodeInfo class and forward 
3347         declare HitTestResult.
3348         * rendering/RenderPath.cpp:
3349         (WebCore::RenderPath::nodeAtPoint): Adjust to HitTestResult 
3350         changes.
3351         * rendering/RenderPath.h: Same.
3352         * rendering/RenderSVGImage.cpp:
3353         (WebCore::RenderSVGImage::nodeAtPoint): Same.
3354         * rendering/RenderSVGImage.h: Same
3355         * rendering/RenderSVGText.cpp:
3356         (WebCore::RenderSVGText::nodeAtPoint): Same.
3357         * rendering/RenderSVGText.h: Same.
3358         * rendering/RenderTableRow.cpp:
3359         (WebCore::RenderTableRow::nodeAtPoint): Same.
3360         * rendering/RenderTableRow.h: Same.
3361         * rendering/RenderTableSection.cpp:
3362         (WebCore::RenderTableSection::nodeAtPoint): Same.
3363         * rendering/RenderTableSection.h: Same.
3364         * rendering/RenderText.h: Same.
3365         (WebCore::RenderText::nodeAtPoint): Same.
3366         * rendering/RenderTextControl.cpp:
3367         (WebCore::RenderTextControl::nodeAtPoint): Same.
3368         * rendering/RenderTextControl.h: Same.
3369         * rendering/RootInlineBox.cpp:
3370         (WebCore::RootInlineBox::nodeAtPoint): Same.
3371         * rendering/RootInlineBox.h: Same.
3372
3373 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
3374
3375         Reviewed by Anders.
3376
3377         - reverted fix for http://bugs.webkit.org/show_bug.cgi?id=11212, later we will address the performance
3378         impact of fixing it again.
3379
3380         * bridge/mac/FrameMac.mm:
3381         (WebCore::FrameMac::clear):
3382
3383 2006-10-27  Maciej Stachowiak  <mjs@apple.com>
3384
3385         Reviewed by John & Adam.
3386
3387         - assorted speedups to fix perf regression from fixing correctness regression
3388
3389         * WebCore.exp: exported new methods.
3390         * WebCore.xcodeproj/project.pbxproj: Added CachedResourceMac.mm
3391         * bridge/mac/WebCoreFrameBridge.h:
3392         * bridge/mac/WebCoreFrameBridge.mm:
3393         * loader/CachedResource.cpp: Removed now obsolete getCFURL.
3394         * loader/CachedResource.h:
3395         * loader/mac/CachedResourceMac.mm: Added.
3396         (WebCore::CachedResource::getNSURLRequest): New method; the NSURLRequest is
3397         now cached in the CachedObject.
3398         * loader/mac/FrameLoader.h:
3399         * loader/mac/FrameLoader.mm:
3400         (WebCore::FrameLoader::loadedResourceFromMemoryCache): New method - lets
3401         the WebKit side do faster dispatch for clients that implement the fast path delegate. 
3402         * loader/mac/LoaderFunctionsMac.mm:
3403         (WebCore::CheckCacheObjectStatus): Instead of calling several FrameLoader methods,
3404         just call loadedResourceFromMemoryCache.
3405         * loader/mac/WebFrameLoaderClient.h:
3406
3407 2006-10-27  Oliver Hunt  <oliver@apple.com>
3408
3409         Reviewed by Maciej.
3410
3411         build fix
3412
3413         * dom/Document.cpp:
3414         (WebCore::Document::referrer):
3415
3416 2006-10-27  Geoffrey Garen  <ggaren@apple.com>
3417
3418         Reviewed by Maciej.
3419
3420         Moved some WebCoreFrameBridge functions into FrameLoader.
3421         
3422         I had to make FrameLoader.h capable of compiling in C++-only source files
3423         by adding some forward declarations and __OBJC__ #ifdefs.
3424
3425         * WebCore.exp:
3426         * bridge/mac/FrameMac.h:
3427         * bridge/mac/FrameMac.mm:
3428         (WebCore::FrameMac::createEmptyDocument):
3429         (WebCore::FrameMac::tokenizerProcessedData):
3430         * bridge/mac/WebCoreFrameBridge.h:
3431         * bridge/mac/WebCoreFrameBridge.mm:
3432         * dom/Document.cpp:
3433         (WebCore::Document::processHttpEquiv):
3434         (WebCore::Document::referrer):
3435         * loader/LoaderFunctions.h:
3436         * loader/mac/FrameLoader.h:
3437         * loader/mac/FrameLoader.mm:
3438         (WebCore::numRequests):
3439         (WebCore::FrameLoader::numPendingOrLoadingRequests):
3440         (WebCore::FrameLoader::isReloading):
3441         (WebCore::FrameLoader::referrer):
3442         (WebCore::FrameLoader::loadEmptyDocumentSynchronously):
3443         (WebCore::FrameLoader::startLoadingResource):
3444         * loader/mac/LoaderFunctionsMac.mm:
3445         (WebCore::CheckIfReloading):
3446         * page/Frame.h:
3447         * page/FrameTree.cpp:
3448         (WebCore::FrameTree::isDescendantOf):
3449         (WebCore::FrameTree::traverseNext):
3450         * page/FrameTree.h:
3451         * platform/network/mac/ResourceLoaderMac.mm:
3452         (WebCore::ResourceLoader::start):
3453
3454 2006-10-27  Timothy Hatcher  <timothy@apple.com>
3455
3456         Reviewed by Darin.
3457
3458         <rdar://problem/4478625> HTML Editing: Basic table editing and culling
3459
3460         Expanded the Deletion UI to lists, positioned block element and block elementss with borders.
3461
3462         * editing/DeleteButtonController.cpp:
3463         (WebCore::isDeletableElement):
3464         (WebCore::enclosingDeletableElement):
3465         (WebCore::DeleteButtonController::respondToChangedSelection):
3466
3467 2006-10-27  John Sullivan  <sullivan@apple.com>
3468
3469         Reviewed by Kevin Decker
3470         
3471         Some more grammar-checking plumbing. No additional grammar jokes will have been made by the time
3472         you haven't not finished reading this.
3473
3474         * rendering/InlineTextBox.h:
3475         * rendering/InlineTextBox.cpp:
3476         (WebCore::InlineTextBox::paint):
3477         Updated for changed signature of paintDocumentMarkers, which causes grammar markers to be
3478         considered also.
3479         (WebCore::InlineTextBox::paintDocumentMarkers):
3480         Renamed from paintAllMarkersOfType; now takes a bool for whether background or foreground
3481         markers should be painted, instead of a marker type. This avoids walking the collection of
3482         markers multiple times back to back. Now handles grammar markers.
3483
3484 2006-10-27  Timothy Hatcher  <timothy@apple.com>
3485
3486         Reviewed by Beth.
3487
3488         Renamed Copy Files to Copy Generated Headers.
3489         Copy 4 DOM*Internal.h headers.
3490
3491         * WebCore.xcodeproj/project.pbxproj:
3492         * bindings/scripts/CodeGeneratorObjC.pm:
3493
3494 2006-10-27  John Sullivan  <sullivan@apple.com>
3495
3496         Reviewed by Anders
3497
3498         * WebCore.exp:
3499         exported symbol for FrameMac->advanceToNextSpelling()
3500         
3501         * bridge/mac/WebCoreFrameBridge.h:
3502         * bridge/mac/WebCoreFrameBridge.mm:
3503         removed advanceToNextMisspelling callers. Clients in WebKit must now call FrameMac directly.
3504
3505 2006-10-27  Justin Garcia  <justin.garcia@apple.com>
3506
3507         Reviewed by harrison
3508         
3509         <http://bugs.webkit.org/show_bug.cgi?id=11423>
3510         REGRESSION: First newline missing from textarea's value
3511         
3512         The regression is that foo, return, bar in a textarea serializes as 'foobar'.
3513         
3514         Before my change in r17223, return (an InsertLineBreak) would insert a '\n' 
3515         (the line break) then a br to prevent the '\n' from collapsing, since the 
3516         insertion is being done at the end of a block (the textarea's shadow div).  Then, 
3517         inserting "bar" would displace the br, and "foo\nbar" would serialize as "foo\nbar".  
3518         After my change in r17223, InsertLineBreak would insert a br then a '\n' (reversed 
3519         the order).  Then inserting "bar" would displace the '\n' and "foo"<br>"bar" would 
3520         serialize as "foobar" because when serializing RenderTextControl intentionally asks 
3521         textContent to not convert brs to newlines.  It seems to think that the only brs in 
3522         the shadow div will be placeholders or collapsed.
3523         
3524         We could remove this assumption, but, for consistancy's sake, I changed InsertLineBreak 
3525         to insert two '\n's when at the end of a block in white-space:pre text.  This alone 
3526         would have fixed the bug, but introduced a new one, because foo, return, bar would 
3527         produce "foo\nbar\n" which would serialize as "foo\nbar\n" (even though the second 
3528         '\n' is collapsed, because of 9661).  So, then I changed placeholder displacement to 
3529         displace a '\n' if it's acting as a placeholder.  A "placeholder" is now defined as 
3530         a br or '\n' that will collapse (become superfluous) when content is inserted just 
3531         before it.
3532         
3533         * editing/CompositeEditCommand.cpp:
3534         (WebCore::CompositeEditCommand::removePlaceholderAt): Renamed.  Remove
3535         a br or '\n' if content inserted just before it will cause it to collapse.
3536         * editing/CompositeEditCommand.h:
3537         * editing/InsertLineBreakCommand.cpp:
3538         (WebCore::InsertLineBreakCommand::doApply): Insert the same type of node
3539         to prevent a collapse as was used for the line break.  Fixed comments.
3540         * editing/InsertTextCommand.cpp:
3541         (WebCore::InsertTextCommand::input): Call the renamed function.
3542         
3543 2006-10-27  Geoffrey Garen  <ggaren@apple.com>
3544
3545         Reviewed by Brady.
3546
3547         Fixed semantic inaccuracy in String::operator NSString *(), where a NULL
3548         String became an empty NSString *, instead of nil. This will become important
3549         as we start using this conversion more.
3550         
3551         Added work-around for AppKit crash that semantic accuracy revealed.
3552         
3553         No testcase because I don't think there's a way to reflect this change
3554         in a webpage yet.
3555
3556         * platform/PlatformString.h:
3557         (WebCore::String::operator NSString*):
3558         * platform/mac/TextFieldMac.mm:
3559         (-[NSSearchFieldCell _addStringToRecentSearches:]):
3560
3561 2006-10-27  David Harrison  <harrison@apple.com>
3562
3563         Reviewed by Maciej,
3564
3565         <rdar://problem/4003820> Expose blockquotes in AXAttributedStringForTextMarkerRange
3566
3567         * bridge/mac/WebCoreAXObject.mm:
3568         (blockquoteLevel):
3569         Calculate and return the blockquote level of the element.
3570         
3571         (AXAttributeStringSetBlockquoteLevel):
3572         Add, if non-zero, or clear the block quote level attribute.
3573         
3574         (AXAttributedStringAppendText):
3575         Send AXAttributeStringSetBlockquoteLevel.
3576
3577 2006-10-27  Darin Adler  <darin@apple.com>
3578
3579         - fix one error in the Qt build
3580
3581         * platform/qt/GraphicsContextQt.cpp:
3582         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
3583         Updated.
3584
3585 2006-10-27  Darin Adler  <darin@apple.com>
3586
3587         Reviewed by Maciej.
3588
3589         * WebCore.exp: Export more symbols needed by WebKit.
3590
3591 2006-10-26  Geoffrey Garen  <ggaren@apple.com>
3592
3593         Reviewed by the Baroness Esmeralda Von Scratch N' Purr XIV.
3594
3595         Fixed layout test crash. Oops.
3596         
3597         * loader/mac/WebDocumentLoader.mm:
3598         (WebCore::canonicalizedTitle):
3599
3600 2006-10-26  John Sullivan  <sullivan@apple.com>
3601
3602         Reviewed by Brady
3603         
3604         - fixed <rdar://problem/4806064> Repro crash in FrameMac::loadRequest following iTunes music store link from salon.com
3605         
3606         This restores some of the nil-handling that was implicit before some of the code was converted from
3607         Objective-C to C++.
3608
3609         * bridge/mac/FrameMac.mm:
3610         (WebCore::FrameMac::loadRequest):
3611         handle nil FrameMac
3612         
3613         * bridge/mac/WebCoreFrameBridge.mm:
3614         (-[WebCoreFrameBridge canTargetLoadInFrame:]):
3615         handle nil Frame
3616
3617 2006-10-26  Geoffrey Garen  <ggaren@apple.com>
3618
3619         Reviewed by Darin, Maciej.
3620
3621         Removed many uses of NSString *.
3622         Moved a few methods from WebCoreFrameBridge to FrameLoader, replacing 
3623         stringByCollapsingNonPrintingCharacters with a c++ equivalent.
3624         
3625         PLT says no performance regression.
3626         
3627         * WebCore.exp:
3628         * bridge/mac/WebCoreFrameBridge.mm:
3629         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
3630         * loader/mac/FrameLoader.h:
3631         * loader/mac/FrameLoader.mm:
3632         (WebCore::FrameLoader::setupForReplaceByMIMEType):
3633         (WebCore::FrameLoader::load):
3634         (WebCore::FrameLoader::canShowMIMEType):
3635         (WebCore::FrameLoader::representationExistsForURLScheme):
3636         (WebCore::FrameLoader::generatedMIMETypeForURLScheme):
3637         (WebCore::FrameLoader::checkContentPolicy):
3638         (WebCore::FrameLoader::reloadAllowingStaleData):
3639         (WebCore::FrameLoader::invalidatePendingPolicyDecision):
3640         (WebCore::FrameLoader::checkNewWindowPolicy):
3641         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
3642         (WebCore::FrameLoader::transitionToCommitted):
3643         (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
3644         (WebCore::FrameLoader::post):
3645         * loader/mac/WebDocumentLoader.h:
3646         * loader/mac/WebDocumentLoader.mm:
3647         (WebCore::DocumentLoader::doesProgressiveLoad):
3648         (WebCore::DocumentLoader::setupForReplaceByMIMEType):
3649         (WebCore::DocumentLoader::title):
3650         (WebCore::DocumentLoader::setOverrideEncoding):
3651         (WebCore::DocumentLoader::overrideEncoding):
3652         (WebCore::DocumentLoader::setTitle):
3653         * loader/mac/WebFrameLoaderClient.h:
3654         * loader/mac/WebMainResourceLoader.mm:
3655         (WebCore::MainResourceLoader::continueAfterContentPolicy):
3656
3657 2006-10-26  Timothy Hatcher  <timothy@apple.com>
3658
3659         Reviewed by Adam.
3660
3661         <rdar://problem/4796941> Table deletion outline is misplaced at nytimes.com
3662
3663         The main table at nytimes.com has a fixed width of 874px, but the table ends
3664         up overflowing to 963px. We now use overflowWidth() and overflowHeight() to correct
3665         this. The other bug was a missing top and left of 0px on the container element,
3666         causing the deletion UI to sometimes be offset below the table.
3667
3668         Now check for the element's renderer at the beginning of show() and
3669         return early if it is null.
3670
3671         * editing/DeleteButtonController.cpp:
3672         (WebCore::DeleteButtonController::updateOutlineStyle):
3673         (WebCore::DeleteButtonController::show):
3674
3675 2006-10-26  Anders Carlsson  <acarlsson@apple.com>
3676
3677         Build fix.
3678
3679         * html/CanvasRenderingContext2D.cpp:
3680         Include MathExtras.h
3681         
3682 2006-10-26  John Sullivan  <sullivan@apple.com>
3683
3684         Reviewed by Anders.
3685
3686         Some changes to support new grammar checking code in WebKit.
3687
3688         * WebCore.exp:
3689         added mangled symbol for Document->removeMarkers() so I can call it from WebKit
3690         
3691         * WebCore.xcodeproj/project.pbxproj:
3692         Made Document.h and DocumentMarker.h private so I can include them from WebKit.
3693         Made HTMLCollection.h private because Document.h uses it.
3694         
3695         * bridge/mac/WebCoreFrameBridge.h:
3696         * bridge/mac/WebCoreFrameBridge.mm:
3697         removed unmarkAllMisspellings(); WebKit now calls through to the Document directly
3698
3699 2006-10-26  Anders Carlsson  <acarlsson@apple.com>
3700
3701         Reviewed by Brady.
3702
3703         Add reverseFind to String and use it instead of findRev.
3704         Use CString instead of DeprecatedCString in one place.
3705         
3706         * html/HTMLFormElement.cpp:
3707         (WebCore::HTMLFormElement::formData):
3708         * ksvg2/svg/SVGURIReference.cpp:
3709         (WebCore::SVGURIReference::getTarget):
3710         * loader/Decoder.cpp:
3711         (WebCore::Decoder::checkForCSSCharset):
3712         * platform/PlatformString.h:
3713         (WebCore::String::reverseFind):
3714         * platform/StringImpl.cpp:
3715         (WebCore::StringImpl::reverseFind):
3716         * platform/StringImpl.h:
3717
3718 2006-10-26  John Sullivan  <sullivan@apple.com>
3719
3720         Reviewed by Darin
3721         
3722         More plumbing for grammar checking. Still no grammars is checked.
3723
3724         * dom/DocumentMarker.h:
3725         (WebCore::DocumentMarker::):
3726         added Grammar to enum of marker types; removed explicit enum values; removed unnecessary "enum"
3727         
3728         * platform/GraphicsContext.h:
3729         renamed method drawLineForMisspelling to drawLineForMisspellingOrBadGrammar;
3730         now takes a bool parameter for whether it represents bad grammar or a misspelling 
3731         
3732         * platform/mac/GraphicsContextMac.mm:
3733         (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
3734         Renamed from drawLineForMisspelling; uses green dot instead of red dot for grammar case. Changed
3735         an existing "assert" to "ASSERT".
3736         
3737         * rendering/InlineTextBox.h:
3738         renamed function paintSpellingMarker to paintSpellingOrGrammarMarker;
3739
3740         * rendering/InlineTextBox.cpp:
3741         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
3742         Renamed from paintSpellingMarker; now takes a bool parameter for whether it represents
3743         bad grammar or a misspelling
3744         (WebCore::InlineTextBox::paintAllMarkersOfType):
3745         now handles markers of type Grammar
3746
3747 === Safari-521.29 ===
3748         
3749 2006-10-26  Sam Weinig  <sam.weinig@gmail.com>
3750
3751         Reviewed by Mitz.
3752
3753         Fix for http://bugs.webkit.org/show_bug.cgi?id=11424
3754         Cleanup rendering code
3755
3756         - Assorted code cleanup.
3757
3758         * rendering/AutoTableLayout.cpp:
3759         * rendering/AutoTableLayout.h:
3760         (WebCore::AutoTableLayout::totalPercent):
3761         * rendering/CounterListItem.h:
3762         * rendering/CounterNode.cpp:
3763         * rendering/CounterNode.h:
3764         (WebCore::CounterNode::~CounterNode):
3765         (WebCore::CounterNode::isReset):
3766         * rendering/CounterResetNode.cpp:
3767         * rendering/CounterResetNode.h:
3768         * rendering/DataRef.h:
3769         (WebCore::DataRef::DataRef):
3770         * rendering/DeprecatedRenderSelect.h:
3771         * rendering/DeprecatedSlider.cpp:
3772         * rendering/DeprecatedSlider.h:
3773         * rendering/EllipsisBox.cpp:
3774         * rendering/EllipsisBox.h:
3775         (WebCore::EllipsisBox::EllipsisBox):
3776         * rendering/FixedTableLayout.cpp:
3777         * rendering/FixedTableLayout.h:
3778         * rendering/GapRects.h:
3779         * rendering/InlineBox.cpp:
3780         * rendering/InlineBox.h:
3781         (WebCore::InlineBox::InlineBox):
3782         (WebCore::InlineBox::setConstructed):
3783         (WebCore::InlineBox::clearTruncation):
3784         (WebCore::InlineBox::markDirty):
3785         * rendering/InlineFlowBox.cpp:
3786         * rendering/InlineFlowBox.h:
3787         (WebCore::InlineFlowBox::InlineFlowBox):
3788         (WebCore::InlineFlowBox::setConstructed):
3789         (WebCore::InlineFlowBox::setEdges):
3790         (WebCore::InlineFlowBox::setVerticalOverflowPositions):
3791         (WebCore::InlineFlowBox::setVerticalSelectionPositions):
3792         * rendering/InlineRunBox.h:
3793         (WebCore::InlineRunBox::paintBackgroundAndBorder):
3794         (WebCore::InlineRunBox::paintDecorations):
3795         * rendering/InlineTextBox.cpp:
3796         * rendering/InlineTextBox.h:
3797         (WebCore::InlineTextBox::InlineTextBox):
3798         (WebCore::InlineTextBox::end):
3799         (WebCore::InlineTextBox::textObject):
3800         * rendering/Length.h:
3801         (WebCore::Length::Length):
3802         * rendering/ListMarkerBox.cpp:
3803         * rendering/ListMarkerBox.h:
3804         * rendering/RenderPartObject.h:
3805         * rendering/RootInlineBox.cpp:
3806         * rendering/RootInlineBox.h:
3807         * rendering/SVGInlineFlowBox.cpp:
3808         * rendering/SVGInlineFlowBox.h:
3809         (WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
3810         * rendering/SVGRootInlineBox.cpp:
3811         * rendering/SVGRootInlineBox.h:
3812         (WebCore::SVGRootInlineBox::SVGRootInlineBox):
3813         * rendering/TableLayout.h:
3814         (WebCore::TableLayout::TableLayout):
3815         (WebCore::TableLayout::~TableLayout):
3816         * rendering/bidi.h:
3817         (WebCore::BidiStatus::BidiStatus):
3818         (WebCore::BidiRun::BidiRun):
3819         * rendering/break_lines.h:
3820
3821 2006-10-26  Justin Garcia  <justin.garcia@apple.com>
3822
3823         Reviewed by john
3824
3825         <http://bugs.webkit.org/show_bug.cgi?id=11329>
3826         Gmail Editor: Can't remove styling applied to selection after clicking "Remove Formatting" toolbar icon.
3827         
3828         * editing/Editor.cpp:
3829         (WebCore::Editor::removeFormattingAndStyle): Moved from JSEditor.
3830         Wrapped the plain text fragment in a style span with the document 
3831         default style so that it will appear unstyled regardless of where
3832         it is inserted.  Could have also inserted the plain text fragment 
3833         and then applied the document default style to it, but there is not 
3834         yet any redundant style prevention in ApplyStyleCommand, so this
3835         is cleaner.
3836         * editing/Editor.h:
3837         * editing/JSEditor.cpp:
3838
3839 2006-10-26  Oliver Hunt  <oliver@apple.com>
3840
3841         Reviewed by Anders.
3842         Fixes <rdar://problem/4800518> -- needed to update existing
3843         canvas path elements when transforms are performed on the
3844         context.
3845
3846         * html/CanvasRenderingContext2D.cpp:
3847         (WebCore::CanvasRenderingContext2D::scale):
3848         (WebCore::CanvasRenderingContext2D::rotate):
3849         (WebCore::CanvasRenderingContext2D::translate):
3850
3851 2006-10-26  Nikolas Zimmermann  <zimmermann@kde.org>
3852
3853         Reviewed by Darin.
3854
3855         Fix Qt/Linux build.
3856
3857         * platform/network/qt/ResourceLoaderManager.cpp:
3858         (WebCore::ResourceLoaderManager::slotData):
3859         (WebCore::ResourceLoaderManager::slotMimetype):
3860         (WebCore::ResourceLoaderManager::remove):
3861         (WebCore::ResourceLoaderManager::add):
3862         * platform/network/qt/ResourceLoaderQt.cpp:
3863         (WebCore::ResourceLoader::receivedResponse):
3864         * platform/qt/FrameQtClient.cpp:
3865         (WebCore::FrameQtClientDefault::openURL):
3866         * platform/qt/LoaderFunctionsQt.cpp:
3867         (WebCore::ServeSynchronousRequest):
3868
3869 2006-10-26  Adam Roben  <aroben@apple.com>
3870
3871         Reviewed by Adele.
3872
3873         Fix: <rdar://problem/3951815> add "type-to-select" feature for list
3874         boxes (<select> elements)
3875         Fix: http://bugs.webkit.org/show_bug.cgi?id=9764 New popup menus
3876         should have type-ahead selection without popping up menu
3877
3878         * WebCore.xcodeproj/project.pbxproj: Version wars.
3879         * html/HTMLSelectElement.h: Add new instance variables for type-ahead
3880         find.
3881         * html/HTMLSelectElement.cpp:
3882         (WebCore::HTMLSelectElement::HTMLSelectElement): Initialize new
3883         instance variables.
3884         (WebCore::HTMLSelectElement::defaultEventHandler): Perform type-ahead
3885         find on printable character presses.
3886         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Remove
3887         redundant check that the listIndex has changed (setSelectedIndex does
3888         this for us), and fix indentation.
3889         (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Change an if
3890         to an else-if.
3891         (WebCore::stripLeadingWhiteSpace): Helper function for typeAheadFind()
3892         to strip leading whitespace (including non-breaking spaces) from a
3893         string.
3894         (WebCore::HTMLSelectElement::typeAheadFind): New method to perform
3895         type-ahead find.
3896         * platform/PopupMenu.h: Added new updateFromElement() method to be
3897         called from RenderMenuList::updateFromElement().
3898         * platform/mac/PopupMenuMac.mm:
3899         (WebCore::PopupMenu::updateFromElement): While we are using
3900         NSPopUpButtonCell for our popups, this method can stay empty.
3901         * rendering/RenderListBox.cpp:
3902         (WebCore::RenderListBox::updateFromElement): Scroll to reveal the first
3903         selected element.
3904         * rendering/RenderMenuList.cpp:
3905         (WebCore::RenderMenuList::updateFromElement): Tell the popup to update
3906         if it's visible.
3907
3908 2006-10-26  Darin Adler  <darin@apple.com>
3909
3910         Reviewed by Anders.
3911
3912         - fix http://bugs.webkit.org/show_bug.cgi?id=11360
3913           editing/pasteboard/copy-paste-bidi intermittently fails due to disappearance of anonymous RenderBlock
3914
3915         * editing/ReplaceSelectionCommand.cpp:
3916         (WebCore::ReplaceSelectionCommand::removeRedundantStyles):
3917         Use two vectors instead of a hash map: more efficient, deterministic. There was no
3918         reason to use a hash table.
3919
3920 2006-10-26  Maciej Stachowiak  <mjs@apple.com>
3921
3922         Reviewed by Anders.
3923
3924         - .5% speed improvement by avoiding excess CFURLRef allocation
3925
3926         * loader/CachedResource.cpp:
3927         (WebCore::CachedResource::getCFURL): New method. For Mac only (for now), cache the CFURL
3928         here for later reuse.
3929         * loader/CachedResource.h:
3930         * loader/mac/LoaderFunctionsMac.mm:
3931         (WebCore::CheckCacheObjectStatus): Use the cached CFURL, don't make a whole new one.
3932
3933 2006-10-25  Darin Adler  <darin@apple.com>
3934
3935         Reviewed by Anders.
3936
3937         - removed 55 methods from WebCoreFrameBridge
3938         - changed callers to use Frame directly instead
3939         - put FrameLoaderTypes.h types into the WebCore namespace
3940         - first steps to get FrameLoader.h ready for cross-platform duty
3941
3942         * WebCore.exp:
3943         * WebCore.xcodeproj/project.pbxproj:
3944         * bridge/mac/BrowserExtensionMac.mm:
3945         (WebCore::BrowserExtensionMac::createNewWindow):
3946         * bridge/mac/FrameMac.h:
3947         * bridge/mac/FrameMac.mm:
3948         (WebCore::FrameMac::loadRequest):
3949         (WebCore::FrameMac::startRedirectionTimer):
3950         (WebCore::FrameMac::stopRedirectionTimer):
3951         (WebCore::FrameMac::passSubframeEventToSubframe):
3952         (WebCore::FrameMac::handledOnloadEvents):
3953         (WebCore::FrameMac::isLoadTypeReload):
3954         * bridge/mac/WebCoreFrameBridge.h:
3955         * bridge/mac/WebCoreFrameBridge.mm:
3956         (-[WebCoreFrameBridge executionContextForView:]):
3957         (updateRenderingForBindings):
3958         (-[WebCoreFrameBridge canTargetLoadInFrame:]):
3959         (-[WebCoreFrameBridge forceLayoutAdjustingViewSize:]):
3960         (-[WebCoreFrameBridge forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
3961         (-[WebCoreFrameBridge installInFrame:]):
3962         (-[WebCoreFrameBridge numPendingOrLoadingRequests]):
3963         (-[WebCoreFrameBridge replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]):
3964         (-[WebCoreFrameBridge baseWritingDirectionForSelectionStart]):
3965         (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
3966         (stringByCollapsingNonPrintingCharacters):
3967         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
3968         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
3969         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
3970         * loader/FrameLoaderTypes.h:
3971         * loader/mac/FrameLoader.h:
3972         * loader/mac/FrameLoader.mm:
3973         (WebCore::FrameLoader::FrameLoader):
3974         (WebCore::FrameLoader::setupForReplace):
3975         (WebCore::FrameLoader::load):
3976         (WebCore::FrameLoader::activeDocumentLoader):
3977         (WebCore::FrameLoader::state):
3978         (WebCore::FrameLoader::setState):
3979         (WebCore::FrameLoader::clearProvisionalLoad):
3980         (WebCore::FrameLoader::markLoadComplete):
3981         (WebCore::FrameLoader::commitProvisionalLoad):
3982         (WebCore::FrameLoader::receivedMainResourceError):
3983         (WebCore::FrameLoader::handleFallbackContent):
3984         (WebCore::FrameLoader::isLoadingMainFrame):
3985         (WebCore::FrameLoader::continueAfterNewWindowPolicy):
3986         (WebCore::FrameLoader::continueAfterNavigationPolicy):
3987         (WebCore::FrameLoader::continueAfterWillSubmitForm):
3988         (WebCore::FrameLoader::continueLoadRequestAfterNavigationPolicy):
3989         (WebCore::FrameLoader::transitionToCommitted):
3990         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
3991         (WebCore::FrameLoader::continueLoadRequestAfterNewWindowPolicy):
3992         (-[WebCoreFrameLoaderAsDelegate continueAfterNewWindowPolicy:]):
3993         (-[WebCoreFrameLoaderAsDelegate continueAfterNavigationPolicy:]):
3994         (-[WebCoreFrameLoaderAsDelegate continueAfterWillSubmitForm:]):
3995         * loader/mac/ImageDocumentMac.mm:
3996         (WebCore::finishImageLoad):
3997         * loader/mac/WebDocumentLoader.mm:
3998         (WebCore::DocumentLoader::isLoadingInAPISense):
3999         * loader/mac/WebMainResourceLoader.h:
4000         * loader/mac/WebMainResourceLoader.mm:
4001         (WebCore::MainResourceLoader::continueAfterContentPolicy):
4002         (-[WebCoreMainResourceLoaderAsPolicyDelegate continueAfterContentPolicy:]):
4003         * loader/mac/WebSubresourceLoader.mm:
4004         (-[WebCoreSubresourceHandle initWithLoader:]):
4005         * platform/mac/ListBoxMac.mm:
4006         (-[WebCoreTableView keyDown:]):
4007         (-[WebCoreTableView keyUp:]):
4008         * platform/mac/WebCoreTextField.mm:
4009         (-[WebCoreTextFieldController textView:shouldHandleEvent:]):
4010
4011 2006-10-25  Steve Falkenburg  <sfalken@apple.com>
4012
4013         Reviewed by Darin.
4014
4015         Printing fixes
4016
4017         * page/Frame.cpp:
4018         (WebCore::Frame::adjustPageHeight):
4019         * page/Frame.h:
4020         (WebCore::Frame::setupRootForPrinting):
4021         (WebCore::Frame::computePageRects):
4022
4023 2006-10-25  Anders Carlsson  <acarlsson@apple.com>
4024
4025         Reviewed by Geoff.
4026
4027         <rdar://problem/4799088>
4028         REGRESSION: Translation widget fails to convert data and reports a "Data unavailable" error.
4029
4030         * loader/mac/WebSubresourceLoader.h:
4031         * loader/mac/WebSubresourceLoader.mm:
4032         (-[WebCoreSubresourceHandle initWithLoader:]):
4033         Set the HTTP method before the HTTP body.
4034
4035 2006-10-25  Geoffrey Garen  <ggaren@apple.com>
4036
4037         Reviewed by Adam.
4038
4039         Renamed WebFrameLoader to FrameLoader, to match class name.
4040
4041         * WebCore.xcodeproj/project.pbxproj:
4042         * bridge/mac/FrameMac.mm:
4043         * bridge/mac/WebCoreFrameBridge.mm:
4044         * loader/mac/FrameLoader.mm: Added.
4045         * loader/mac/IconLoaderMac.mm:
4046         * loader/mac/WebDocumentLoader.mm:
4047         * loader/mac/WebFrameLoader.h: Removed.
4048         * loader/mac/WebFrameLoader.mm: Removed.
4049         * loader/mac/WebLoader.mm:
4050         * loader/mac/WebMainResourceLoader.mm:
4051         * loader/mac/WebNetscapePlugInStreamLoader.mm:
4052         * loader/mac/WebSubresourceLoader.mm:
4053
4054 2006-10-25  Darin Adler  <darin@apple.com>
4055
4056         - fix full builds
4057
4058         * WebCore.xcodeproj/project.pbxproj: Mark bridge/mac/WebCoreResourceLoader.h as private.
4059
4060 2006-10-25  David Smith  <catfish.man@gmail.com>
4061
4062         Reviewed by Mitz.
4063
4064         Fixed REGRESSION (r17280): Repro crash when clicking a link with target="_blank"
4065         http://bugs.webkit.org/show_bug.cgi?id=11411
4066
4067         * bridge/mac/WebCoreFrameBridge.mm:
4068         (-[WebCoreFrameBridge canTargetLoadInFrame:]): Check that the target has a frame before using it.
4069
4070 2006-10-25  Maciej Stachowiak  <mjs@apple.com>
4071
4072         Rubber stamped by Mitz.
4073
4074         - moved some files that are essentially part of the ResourceLoader implementation to platform/network/mac
4075
4076         * WebCore.xcodeproj/project.pbxproj:
4077         * bridge/mac/WebCoreResourceLoader.h: Moved to platform/network/mac.
4078         * bridge/mac/WebCoreResourceLoaderImp.h: Moved to platform/network/mac.
4079         * bridge/mac/WebCoreResourceLoaderImp.mm: Moved to platform/network/mac.
4080
4081 2006-10-25  Maciej Stachowiak  <mjs@apple.com>
4082
4083         Rubber stamped by Mark.
4084
4085         - remove no longer existing symbol that was breaking linking
4086
4087         * WebCore.exp:
4088
4089 2006-10-25  Maciej Stachowiak  <mjs@apple.com>
4090
4091         Reviewed by Mitz.
4092         
4093         - fixed "REGRESSION: Activity window doesn't always list all files until refresh"
4094         http://bugs.webkit.org/show_bug.cgi?id=11212
4095
4096         I couldn't figure out how to write a test case.
4097
4098         * bindings/js/kjs_window.cpp:
4099         (KJS::Window::clear): Avoid crashing if already detached.
4100         * bridge/mac/FrameMac.h:
4101         * bridge/mac/FrameMac.mm:
4102         (WebCore::FrameMac::clear): Change prototype to make this a proper
4103         overload for Frame::clear once again(!).
4104
4105 2006-10-24  Darin Adler  <darin@apple.com>
4106
4107         Reviewed by Anders.
4108
4109         - converted WebFrameLoaderClient to C++
4110         - renamed frame->frameLoader() function to frame->loader()
4111         - renamed [bridge impl] to [bridge _frame]
4112         - removed some bridge methods
4113
4114         * WebCore.exp: Added more exports.
4115         * WebCore.xcodeproj/project.pbxproj: Made FrameTree.h private instead of project-internal
4116         so it can be used in WebKit.
4117
4118         * bridge/mac/BrowserExtensionMac.mm:
4119         (WebCore::BrowserExtensionMac::createNewWindow):
4120         * bridge/mac/FrameMac.mm:
4121         (WebCore::FrameMac::createFrame):
4122         (WebCore::FrameMac::didFirstLayout):
4123         * bridge/mac/WebCoreAXObject.mm:
4124         (-[WebCoreAXObject rendererForView:]):
4125         * bridge/mac/WebCoreFrameBridge.h:
4126         * bridge/mac/WebCoreFrameBridge.mm:
4127         (-[WebCoreFrameBridge _shouldAllowAccessFrom:]):
4128         (-[WebCoreFrameBridge canTargetLoadInFrame:]):
4129         (-[WebCoreFrameBridge setOpener:]):
4130         (-[WebCoreFrameBridge getData:andResponse:forURL:]):
4131         (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
4132         (-[WebCoreFrameBridge setTitle:]):
4133         (-[WebCoreFrameBridge originalRequestURL]):
4134         (-[WebCoreFrameBridge isLoadTypeReload]):
4135         (-[WebCoreFrameBridge frameDetached]):
4136         (-[WebCoreFrameBridge tokenizerProcessedData]):
4137         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
4138         (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]):
4139         (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
4140         (-[WebCoreFrameBridge reportClientRedirectCancelled:]):
4141         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
4142         (-[WebCoreFrameBridge incomingReferrer]):
4143         (-[WebCoreFrameBridge isReloading]):
4144         (-[WebCoreFrameBridge handledOnloadEvents]):
4145         (-[WebCoreFrameBridge mainResourceURLResponse]):
4146         (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
4147         (-[WebCoreFrameBridge _frame]):
4148         (-[WebCoreFrameBridge executionContextForView:]):
4149         * bridge/mac/WebCorePageBridge.mm:
4150         (-[WebCorePageBridge setMainFrame:]):
4151         * dom/Position.cpp:
4152         (WebCore::Position::upstream):
4153         * loader/mac/IconLoaderMac.mm:
4154         (IconLoader::notifyIconChanged):
4155         * loader/mac/WebDocumentLoader.mm:
4156         (WebCore::DocumentLoader::frameLoader):
4157         (WebCore::DocumentLoader::stopLoading):
4158         (WebCore::DocumentLoader::finishedLoading):
4159       &n