2009-11-24 Kent Tamura <tkent@chromium.org>
[WebKit-https.git] / WebCore / ChangeLog
1 2009-11-24  Kent Tamura  <tkent@chromium.org>
2
3         Reviewed by Eric Seidel.
4
5         [Chromium] Ignore line-height CSS property specified to a search field on
6         Windows and Linux.
7         https://bugs.webkit.org/show_bug.cgi?id=31820
8
9         LayoutTests/fast/forms/control-restrict-line-height.html checks that the
10         following controls should ignore line-height CSS property.
11          - <select>
12          - <input type=button>
13          - <input type=search>
14         This change addresses the <input type=search> issue with Chromium/Windows
15         and Chromium/Linux.
16
17         * rendering/RenderThemeChromiumSkia.cpp:
18         (WebCore::RenderThemeChromiumSkia::adjustSearchFieldStyle): Implement this to ignore line-height.
19         * rendering/RenderThemeChromiumSkia.h: Declare adjustSearchFieldStyle().
20
21 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
22
23         No review.
24
25         Stylistic fix: indent the member var initialisation.
26
27         * platform/graphics/mac/GraphicsLayerCA.mm:
28         (WebCore::GraphicsLayerCA::GraphicsLayerCA):
29
30 2009-11-24  Gavin Barraclough  <barraclough@apple.com>
31
32         Reviewed by Geoff Garen.
33
34         Bug 31848 - Remove uses of mainThreadCurrentWorld, and of currentWorld using a globalData.
35
36         These methods get the world from the global data rather than from an execstate.
37         If the current world is always read from an exec state then it can be read
38         from the global object, and world entry can become automagical, rather than
39         being explicitly set by an EnterDOMWrapperWorld.
40
41         * bindings/js/JSCSSRuleCustom.cpp:
42         (WebCore::toJS):
43         * bindings/js/JSCSSValueCustom.cpp:
44         (WebCore::toJS):
45         * bindings/js/JSDOMBinding.cpp:
46         (WebCore::currentWorld):
47         (WebCore::DOMObjectWrapperMapFor):
48         (WebCore::hasCachedDOMObjectWrapper):
49         (WebCore::getCachedDOMObjectWrapper):
50         (WebCore::cacheDOMObjectWrapper):
51         (WebCore::hasCachedDOMNodeWrapper):
52         (WebCore::getCachedDOMNodeWrapper):
53         (WebCore::cacheDOMNodeWrapper):
54         * bindings/js/JSDOMBinding.h:
55         (WebCore::createDOMObjectWrapper):
56         (WebCore::getDOMObjectWrapper):
57         (WebCore::createDOMNodeWrapper):
58         (WebCore::getDOMNodeWrapper):
59         * bindings/js/JSDOMWindowCustom.cpp:
60         (WebCore::JSDOMWindow::history):
61         (WebCore::JSDOMWindow::location):
62         * bindings/js/JSDocumentCustom.cpp:
63         (WebCore::JSDocument::location):
64         (WebCore::toJS):
65         * bindings/js/JSElementCustom.cpp:
66         (WebCore::toJSNewlyCreated):
67         * bindings/js/JSEventCustom.cpp:
68         (WebCore::toJS):
69         * bindings/js/JSHTMLCollectionCustom.cpp:
70         (WebCore::toJS):
71         * bindings/js/JSImageDataCustom.cpp:
72         (WebCore::toJS):
73         * bindings/js/JSNodeCustom.cpp:
74         (WebCore::JSNode::markChildren):
75         (WebCore::createWrapper):
76         (WebCore::toJS):
77         * bindings/js/JSSVGPathSegCustom.cpp:
78         (WebCore::toJS):
79         * bindings/js/JSStyleSheetCustom.cpp:
80         (WebCore::toJS):
81         * xml/XMLHttpRequest.cpp:
82         (WebCore::XMLHttpRequest::dropProtection):
83
84 2009-11-24  Alexey Proskuryakov  <ap@apple.com>
85
86         Windows build fix.
87
88         * platform/network/cf/SocketStreamHandleCFNet.cpp: Also, don't include the wrong one!
89
90 2009-11-24  Alexey Proskuryakov  <ap@apple.com>
91
92         Windows build fix.
93
94         * platform/network/cf/SocketStreamHandleCFNet.cpp: Include the proper WKSI header.
95
96 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
97
98         Reviewed by Oliver Hunt.
99
100         SVGUseElement::toClipPath can crash
101         <rdar://problem/7385270>
102
103         Null-test m_shadowTreeRootElement again, because the call to buildPendingResource() may not
104         actually initialize it.
105
106         * svg/SVGUseElement.cpp:
107         (WebCore::SVGUseElement::toClipPath):
108
109 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
110
111         Windows build fix.
112
113         * page/win/FrameCGWin.cpp:
114         (WebCore::imageFromRect):
115         (WebCore::imageFromSelection):
116
117 2009-11-24  Eric Carlson  <eric.carlson@apple.com>
118
119         Not reviewed. Revert r51351 until a new WebKitSupportLibrary is available.
120
121         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
122         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
123         * platform/graphics/win/QTMovieWin.cpp:
124         * platform/graphics/win/QTMovieWin.h:
125         * rendering/RenderMediaControls.cpp:
126         * rendering/RenderThemeWin.cpp:
127         * rendering/RenderThemeWin.h:
128
129 2009-11-24  Alexey Proskuryakov  <ap@apple.com>
130
131         Reviewed by Brady Eidson.
132
133         https://bugs.webkit.org/show_bug.cgi?id=31844
134         SocketStreamHandleCFNet should support CONNECT proxy credentials
135
136         * WebCore.vcproj/WebCore.vcproj:
137         * WebCore.xcodeproj/project.pbxproj:
138         * platform/network/CredentialStorage.h:
139         * platform/network/mac/CredentialStorageMac.mm: Added.
140         (WebCore::CredentialStorage::getFromPersistentStorage):
141         * platform/network/cf/CredentialStorageCFNet.cpp: Added.
142         (WebCore::CredentialStorage::getFromPersistentStorage):
143         Add support for fetching credentials from persistent storage (CFNet version is currently
144         a stub).
145
146         * bindings/js/JSWebSocketCustom.cpp: Removed an unneeded include.
147
148         * platform/network/cf/SocketStreamHandle.h:
149         * platform/network/cf/SocketStreamHandleCFNet.cpp:
150         (WebCore::SocketStreamHandle::SocketStreamHandle):
151         (WebCore::SocketStreamHandle::createStreams):
152         (WebCore::getStoredCONNECTProxyCredentials):
153         (WebCore::authenticationSchemeFromAuthenticationMethod):
154         (WebCore::SocketStreamHandle::addCONNECTCredentials):
155         (WebCore::SocketStreamHandle::readStreamCallback):
156         Check if connection attempt was resulted in 407, and try stored credentials if it did.
157
158         * platform/mac/WebCoreSystemInterface.h:
159         * platform/mac/WebCoreSystemInterface.mm:
160         * WebCore.base.exp:
161         Updated WKSI.
162
163 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
164
165         Reviewed by Dan Bernstein.
166
167         Find highlight is drawn incorrectly on pages with compositing layers
168         <rdar://problem/7413925>
169         
170         Part 2: Add a new bit to the PaintBehavior flags, PaintBehaviorFlattenCompositingLayers,
171         and pass that down when painting into an image.
172         
173         When set, it forces painting of compositing layers to go down a software paint path
174         when all layers are painted, irrespective of compositing status, and where
175         3d transforms are flattened to 2d. When doing this, we also need to use temporary
176         clip rects for layers which are normally composited.
177         
178         * page/FrameView.h:
179         (WebCore::FrameView::paintBehavior):
180         * page/mac/FrameMac.mm:
181         (WebCore::Frame::imageFromRect):
182         * rendering/RenderLayer.cpp:
183         (WebCore::RenderLayer::renderableTransform):
184         (WebCore::expandClipRectForDescendantsAndReflection):
185         (WebCore::transparencyClipBox):
186         (WebCore::RenderLayer::beginTransparencyLayers):
187         (WebCore::RenderLayer::paintLayer):
188         * rendering/RenderLayer.h:
189         (WebCore::RenderLayer::paintsWithTransparency):
190         (WebCore::RenderLayer::paintsWithTransform):
191         * rendering/RenderLayerCompositor.cpp:
192         (WebCore::RenderLayerCompositor::calculateCompositedBounds):
193         * rendering/RenderObject.h:
194
195 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
196
197         Reviewed by Dan Bernstein.
198
199         Find highlight is drawn incorrectly on pages with compositing layers
200         <rdar://problem/7413925>
201         
202         Part 1: Rename PaintRestriction to PaintBehavior, and make it a bitmask, in
203         preparation for adding a new flag related to painting into an image.
204         
205         PaintBehaviorSelectionOnly and PaintBehaviorForceBlackText are now separate flags.
206
207         * page/FrameView.cpp:
208         (WebCore::FrameView::reset):
209         (WebCore::FrameView::paintContents):
210         (WebCore::FrameView::setPaintBehavior):
211         * page/FrameView.h:
212         * page/mac/FrameMac.mm:
213         (WebCore::Frame::selectionImage):
214         * rendering/RenderLayer.cpp:
215         (WebCore::RenderLayer::paint):
216         (WebCore::RenderLayer::paintLayer):
217         * rendering/RenderLayer.h:
218         * rendering/RenderLayerBacking.cpp:
219         (WebCore::RenderLayerBacking::paintIntoLayer):
220         (WebCore::RenderLayerBacking::paintContents):
221         * rendering/RenderLayerBacking.h:
222         * rendering/RenderObject.h:
223         * rendering/RenderReplica.cpp:
224         (WebCore::RenderReplica::paint):
225
226 2009-11-24  Eric Carlson  <eric.carlson@apple.com>
227
228         Reviewed by Simon Fraser.
229
230         <rdar://problem/7409331> Windows: Support closed caption in <video> element
231
232         Enable closed captions in QuickTime/Windows media engine.
233
234         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
235         (WebCore::MediaPlayerPrivate::hasClosedCaptions):
236         (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible):
237         * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
238         * platform/graphics/win/QTMovieWin.cpp:
239         (QTMovieWin::hasClosedCaptions):
240         (QTMovieWin::setClosedCaptionsVisible):
241         * platform/graphics/win/QTMovieWin.h:
242         * rendering/RenderMediaControls.cpp:
243         (WebCore::RenderMediaControls::paintMediaControlsPart):
244         * rendering/RenderThemeWin.cpp:
245         (WebCore::RenderThemeWin::paintMediaToggleClosedCaptionsButton):
246         * rendering/RenderThemeWin.h:
247
248 2009-11-24  Darin Fisher  <darin@chromium.org>
249
250         Reviewed by Adam Barth.
251
252         [Chromium] Renderer hang when using www.expedia.com
253         https://bugs.webkit.org/show_bug.cgi?id=31822
254
255         Test: http/tests/cache/subresource-failover-to-network.html
256
257         * loader/FrameLoader.cpp:
258         (WebCore::FrameLoader::loadResourceSynchronously): Use the originalRequest
259         when inheriting cache policy.  This matches SubresourceLoader::create.
260
261 2009-11-23  Kenneth Russell  <kbr@google.com>
262
263         Reviewed by Oliver Hunt.
264
265         Change get... calls to latest spec
266         https://bugs.webkit.org/show_bug.cgi?id=30091
267
268         Removed old versions of get calls on WebGLRenderingContext and
269         added new ones per spec returning "any". New code simplifies
270         GraphicsContext3D and fixes previously unimplemented routines.
271         Added custom JS and V8 bindings. Added exhaustive test case
272         exercising all new code paths. Updated preexisting test cases for
273         new APIs. Fixed preexisting bugs in WebKit's and Chrome's WebGL
274         implementations.
275
276         Ran WebGL layout tests in WebKit (clean) and Chrome (couple of
277         preexisting known failures) and manual WebGL tests in both
278         browsers.
279
280         Test: fast/canvas/webgl/gl-object-get-calls.html
281
282         * WebCore.gypi:
283         * WebCore.xcodeproj/project.pbxproj:
284         * bindings/js/JSWebGLRenderingContextCustom.cpp:
285         (WebCore::toJS):
286         (WebCore::):
287         (WebCore::getObjectParameter):
288         (WebCore::getProgramParameterHelper):
289         (WebCore::JSWebGLRenderingContext::getBufferParameter):
290         (WebCore::JSWebGLRenderingContext::getFramebufferAttachmentParameter):
291         (WebCore::JSWebGLRenderingContext::getParameter):
292         (WebCore::JSWebGLRenderingContext::getProgramParameter):
293         (WebCore::JSWebGLRenderingContext::getRenderbufferParameter):
294         (WebCore::JSWebGLRenderingContext::getShaderParameter):
295         (WebCore::JSWebGLRenderingContext::getTexParameter):
296         (WebCore::JSWebGLRenderingContext::getUniform):
297         (WebCore::JSWebGLRenderingContext::getVertexAttrib):
298         * bindings/v8/custom/V8CustomBinding.h:
299         * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
300         (WebCore::toV8):
301         (WebCore::):
302         (WebCore::getObjectParameter):
303         (WebCore::getProgramParameter):
304         (WebCore::CALLBACK_FUNC_DECL):
305         * html/canvas/CanvasObject.cpp:
306         (WebCore::CanvasObject::CanvasObject):
307         (WebCore::CanvasObject::setObject):
308         (WebCore::CanvasObject::deleteObject):
309         * html/canvas/CanvasObject.h:
310         * html/canvas/WebGLBuffer.cpp:
311         (WebCore::WebGLBuffer::create):
312         (WebCore::WebGLBuffer::WebGLBuffer):
313         * html/canvas/WebGLBuffer.h:
314         * html/canvas/WebGLGetInfo.cpp: Added.
315         (WebCore::WebGLGetInfo::WebGLGetInfo):
316         (WebCore::WebGLGetInfo::~WebGLGetInfo):
317         (WebCore::WebGLGetInfo::getType):
318         (WebCore::WebGLGetInfo::getBool):
319         (WebCore::WebGLGetInfo::getFloat):
320         (WebCore::WebGLGetInfo::getLong):
321         (WebCore::WebGLGetInfo::getString):
322         (WebCore::WebGLGetInfo::getUnsignedLong):
323         (WebCore::WebGLGetInfo::getWebGLBuffer):
324         (WebCore::WebGLGetInfo::getWebGLFloatArray):
325         (WebCore::WebGLGetInfo::getWebGLFramebuffer):
326         (WebCore::WebGLGetInfo::getWebGLIntArray):
327         (WebCore::WebGLGetInfo::getWebGLProgram):
328         (WebCore::WebGLGetInfo::getWebGLRenderbuffer):
329         (WebCore::WebGLGetInfo::getWebGLTexture):
330         (WebCore::WebGLGetInfo::getWebGLUnsignedByteArray):
331         * html/canvas/WebGLGetInfo.h: Added.
332         (WebCore::WebGLGetInfo::):
333         * html/canvas/WebGLRenderbuffer.cpp:
334         (WebCore::WebGLRenderbuffer::create):
335         (WebCore::WebGLRenderbuffer::WebGLRenderbuffer):
336         * html/canvas/WebGLRenderbuffer.h:
337         * html/canvas/WebGLRenderingContext.cpp:
338         (WebCore::WebGLStateRestorer::WebGLStateRestorer):
339         (WebCore::WebGLStateRestorer::~WebGLStateRestorer):
340         (WebCore::WebGLRenderingContext::WebGLRenderingContext):
341         (WebCore::WebGLRenderingContext::activeTexture):
342         (WebCore::WebGLRenderingContext::bindBuffer):
343         (WebCore::WebGLRenderingContext::bindFramebuffer):
344         (WebCore::WebGLRenderingContext::bindRenderbuffer):
345         (WebCore::WebGLRenderingContext::bindTexture):
346         (WebCore::WebGLRenderingContext::getBufferParameter):
347         (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter):
348         (WebCore::WebGLRenderingContext::getParameter):
349         (WebCore::WebGLRenderingContext::getProgramParameter):
350         (WebCore::WebGLRenderingContext::getProgramInfoLog):
351         (WebCore::WebGLRenderingContext::getRenderbufferParameter):
352         (WebCore::WebGLRenderingContext::getShaderParameter):
353         (WebCore::WebGLRenderingContext::getShaderInfoLog):
354         (WebCore::WebGLRenderingContext::getShaderSource):
355         (WebCore::WebGLRenderingContext::getString):
356         (WebCore::WebGLRenderingContext::getTexParameter):
357         (WebCore::WebGLRenderingContext::getUniform):
358         (WebCore::WebGLRenderingContext::getVertexAttrib):
359         (WebCore::WebGLRenderingContext::useProgram):
360         (WebCore::WebGLRenderingContext::getBooleanParameter):
361         (WebCore::WebGLRenderingContext::getFloatParameter):
362         (WebCore::WebGLRenderingContext::getIntParameter):
363         (WebCore::WebGLRenderingContext::getLongParameter):
364         (WebCore::WebGLRenderingContext::getUnsignedLongParameter):
365         (WebCore::WebGLRenderingContext::getWebGLFloatArrayParameter):
366         (WebCore::WebGLRenderingContext::getWebGLIntArrayParameter):
367         (WebCore::WebGLRenderingContext::getWebGLUnsignedByteArrayParameter):
368         * html/canvas/WebGLRenderingContext.h:
369         * html/canvas/WebGLRenderingContext.idl:
370         * html/canvas/WebGLTexture.cpp:
371         (WebCore::WebGLTexture::create):
372         (WebCore::WebGLTexture::WebGLTexture):
373         * html/canvas/WebGLTexture.h:
374         * manual-tests/webgl/resources/utils3d.js:
375         (initWebGL):
376         (loadShader):
377         (Framerate.prototype.snapshot):
378         * platform/graphics/GraphicsContext3D.h:
379         * platform/graphics/mac/GraphicsContext3DMac.cpp:
380         (WebCore::GraphicsContext3D::bindRenderbuffer):
381         (WebCore::GraphicsContext3D::getBooleanv):
382         (WebCore::GraphicsContext3D::getBufferParameteriv):
383         (WebCore::GraphicsContext3D::getFloatv):
384         (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv):
385         (WebCore::GraphicsContext3D::getIntegerv):
386         (WebCore::GraphicsContext3D::getProgramiv):
387         (WebCore::GraphicsContext3D::getRenderbufferParameteriv):
388         (WebCore::GraphicsContext3D::getShaderiv):
389         (WebCore::GraphicsContext3D::getTexParameterfv):
390         (WebCore::GraphicsContext3D::getTexParameteriv):
391         (WebCore::GraphicsContext3D::getUniformfv):
392         (WebCore::GraphicsContext3D::getUniformiv):
393         (WebCore::GraphicsContext3D::getVertexAttribfv):
394         (WebCore::GraphicsContext3D::getVertexAttribiv):
395
396 2009-11-24  Steve Falkenburg  <sfalken@apple.com>
397
398         Windows build fix.
399
400         * WebCore.vcproj/QTMovieWin.vcproj: Add additional search path for QuickTime SDK.
401
402 2009-11-24  Philippe Normand  <pnormand@igalia.com>
403
404         Reviewed by Gustavo Noronha Silva.
405
406         [Gtk] GStreamer-CRITICAL's (and other warnings) on <video>
407         https://bugs.webkit.org/show_bug.cgi?id=26354
408
409         Implemented MediaPlayerPrivate::isAvailable by checking the
410         presence of the playbin2 GStreamer element.
411
412         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
413         (WebCore::MediaPlayerPrivate::isAvailable):
414         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
415
416 2009-11-24  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
417
418         Reviewed by Xan Lopez.
419
420         https://bugs.webkit.org/show_bug.cgi?id=25415
421         [GTK][ATK] Please implement support for get_text_at_offset
422
423         When building up the pango layout from text boxes, only append a
424         newline char after verifying there are no more boxes on this line.
425
426         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
427         (getPangoLayoutForAtk):
428
429 2009-11-24  Joseph Pecoraro  <joepeck@webkit.org>
430
431         Reviewed by Pavel Feldman.
432
433         Web Inspector: Keyboard Shortcut to Clear Console Messages
434         https://bugs.webkit.org/show_bug.cgi?id=31780
435
436         All Platforms:  Ctrl+L  = Clear Console Messages
437         Mac Only:       Cmd+K   = Clear Console Messages
438
439         * inspector/front-end/ConsoleView.js:
440         (WebInspector.ConsoleView): create shortcuts
441         (WebInspector.ConsoleView.prototype._promptKeyDown): handle shortcuts
442         * inspector/front-end/KeyboardShortcut.js:
443         (WebInspector.KeyboardShortcut.makeKey): convenience conversion of "a-z" character to keyCode
444         * inspector/front-end/ScriptsPanel.js:
445         (WebInspector.ScriptsPanel): style fixes for keyboard shortcuts
446
447 2009-11-24  Pavel Feldman  <pfeldman@chromium.org>
448
449         Not reviewed: touch inspector controller in order to
450         kick win bot inspector deploy. rs=aroben.
451
452         * inspector/InspectorController.cpp:
453
454 2009-11-23  Pavel Feldman  <pfeldman@chromium.org>
455
456         Reviewed by Timothy Hatcher.
457
458         Web Inspector: Implement expandable compartments on timeline panel.
459
460         https://bugs.webkit.org/show_bug.cgi?id=31796
461
462         * inspector/front-end/TimelineOverviewPane.js:
463         (WebInspector.TimelineOverviewPane.prototype._setWindowPosition):
464         * inspector/front-end/TimelinePanel.js:
465         (WebInspector.TimelinePanel):
466         (WebInspector.TimelinePanel.prototype.addRecordToTimeline):
467         (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
468         (WebInspector.TimelinePanel.prototype._formatRecord):
469         (WebInspector.TimelinePanel.prototype._refreshRecords):
470         (WebInspector.TimelinePanel.prototype._addToRecordsWindow):
471         (WebInspector.TimelineRecordListRow):
472         (WebInspector.TimelineRecordListRow.prototype.update):
473         (WebInspector.TimelineRecordListRow.prototype.dispose):
474         (WebInspector.TimelineRecordGraphRow):
475         (WebInspector.TimelineRecordGraphRow.prototype.update):
476         (WebInspector.TimelineRecordGraphRow.prototype._onClick):
477         (WebInspector.TimelineRecordGraphRow.prototype.dispose):
478         * inspector/front-end/inspector.css:
479
480 2009-11-24  Mark Rowe  <mrowe@apple.com>
481
482         Fix production builds where the source tree may be read-only.
483
484         * WebCore.xcodeproj/project.pbxproj:
485
486 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
487
488         Reviewed by Kenneth Rohde Christiansen.
489
490         Include "config.h" to meet Coding Style Guidelines
491         https://bugs.webkit.org/show_bug.cgi?id=31792
492
493         No new tests as there is no new functionality.
494
495         * platform/graphics/win/IntPointWin.cpp:
496         * platform/graphics/win/IntRectWin.cpp:
497         * platform/graphics/win/IntSizeWin.cpp:
498         * platform/network/chromium/ResourceRequest.cpp:
499         * platform/win/PlatformMouseEventWin.cpp:
500
501 2009-11-23  Jian Li  <jianli@chromium.org>
502
503         Reviewed by NOBODY (Chromium build fix).
504
505         * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
506         (WebCore::CALLBACK_FUNC_DECL):
507         * platform/graphics/GraphicsContext3D.h:
508
509 2009-11-23  Aaron Golden  <agolden@apple.com>
510
511         Reviewed by Alexey Proskuryakov.
512
513         Prevent ResourceHandleMac's version of ResourceHandle::receivedCredential from stripping
514         identity and certificate information from a WebCore::Credential when receivedCredential
515         needs to modify the credential's persistence.
516
517         Adding a new constructor Credential(const Credential& original, CredentialPersistence)
518         that copies every field from original except for persistence.
519
520         * platform/network/Credential.cpp:
521         (WebCore::Credential::Credential):
522         * platform/network/Credential.h:
523         * platform/network/mac/ResourceHandleMac.mm:
524         (WebCore::ResourceHandle::receivedCredential):
525
526 2009-11-23  Gavin Barraclough  <barraclough@apple.com>
527
528         Reviewed by Geoff Garen.
529
530         Part 2/3 of <rdar://problem/7377477> REGRESSION: Many web pages fail to render after interesting script runs in isolated world
531
532         Some clients of the JavaScriptCore API expect to be able to make callbacks over the JSC API,
533         and for this to automagically cause execution to take place in the world associated with the
534         global object associated with the ExecState (JSContextRef) passed.  However this is not how
535         things work - the world must be explicitly set within WebCore.
536
537         Making this work just for API calls to evaluate & call will be a far from perfect solution,
538         since direct (non-API) use of JSC still relies on WebCore setting the current world correctly.
539         A better solution would be to make this all work automagically all throughout WebCore, but this
540         will require more refactoring.
541
542         Add references from the JSDOMWindowShell and the JSDOMGlobalObject to the world that owns them,
543         so that we can get to the world from the lexical global object of an ExecState.  In the long-term
544         we should switch over to using this approach for all cases we want to get a world from an exec state.
545
546         * bindings/js/JSDOMBinding.cpp:
547         (WebCore::WebCoreJSClientData::beginningExecution):
548         (WebCore::WebCoreJSClientData::completedExecution):
549         * bindings/js/JSDOMBinding.h:
550         * bindings/js/JSDOMGlobalObject.h:
551         (WebCore::JSDOMGlobalObject::world):
552         (WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData):
553         * bindings/js/JSDOMWindowBase.cpp:
554         (WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData):
555         * bindings/js/JSDOMWindowBase.h:
556         * bindings/js/JSDOMWindowShell.cpp:
557         (WebCore::JSDOMWindowShell::JSDOMWindowShell):
558         * bindings/js/JSDOMWindowShell.h:
559         (WebCore::JSDOMWindowShell::world):
560         * bindings/js/JSWorkerContextBase.cpp:
561         (WebCore::JSWorkerContextBase::JSWorkerContextBase):
562         * bindings/js/ScriptController.cpp:
563         (WebCore::ScriptController::initScript):
564
565 2009-11-23  Chris Marrin  <cmarrin@apple.com>
566
567         Reviewed by Oliver Hunt.
568
569         Add range checks to rendering calls in WebGL
570         https://bugs.webkit.org/show_bug.cgi?id=31239
571
572         I am now tracking the size of the data in each CanvasBuffer object
573         and keeping track of the buffer size of each active vertex attrib.
574         In drawArrays and drawElements I make sure no attempt is made to
575         access elements outside the valid buffer ranges. The test at:
576
577             http://cs.helsinki.fi/u/ilmarihe/c3d/functions/drawArraysOutOfBounds.html
578
579         no longer crashes.
580
581         I also added all the WebGL enumerations to GraphicsContext3D to use them in the validation checks
582
583         Tests: fast/canvas/webgl/drawArraysOutOfBounds.html
584                fast/canvas/webgl/drawElementssOutOfBounds.html
585
586         * bindings/js/JSWebGLArrayCustom.cpp:
587         (WebCore::toJS):
588         * bindings/js/JSWebGLRenderingContextCustom.cpp:
589         (WebCore::JSWebGLRenderingContext::bufferData):
590         (WebCore::JSWebGLRenderingContext::bufferSubData):
591         (WebCore::JSWebGLRenderingContext::texSubImage2D):
592         * html/canvas/WebGLArrayBuffer.cpp:
593         (WebCore::WebGLArrayBuffer::create):
594         (WebCore::WebGLArrayBuffer::data):
595         * html/canvas/WebGLArrayBuffer.h:
596         * html/canvas/WebGLBuffer.cpp:
597         (WebCore::WebGLBuffer::WebGLBuffer):
598         (WebCore::WebGLBuffer::associateBufferData):
599         (WebCore::WebGLBuffer::associateBufferSubData):
600         (WebCore::WebGLBuffer::byteLength):
601         * html/canvas/WebGLBuffer.h:
602         (WebCore::WebGLBuffer::elementArrayBuffer):
603         * html/canvas/WebGLRenderingContext.cpp:
604         (WebCore::WebGLRenderingContext::WebGLRenderingContext):
605         (WebCore::WebGLRenderingContext::sizeInBytes):
606         (WebCore::WebGLRenderingContext::bindBuffer):
607         (WebCore::WebGLRenderingContext::bufferData):
608         (WebCore::WebGLRenderingContext::bufferSubData):
609         (WebCore::WebGLRenderingContext::createShader):
610         (WebCore::WebGLRenderingContext::disableVertexAttribArray):
611         (WebCore::WebGLRenderingContext::validateIndexArray):
612         (WebCore::WebGLRenderingContext::validateRenderingState):
613         (WebCore::WebGLRenderingContext::drawArrays):
614         (WebCore::WebGLRenderingContext::drawElements):
615         (WebCore::WebGLRenderingContext::enableVertexAttribArray):
616         (WebCore::WebGLRenderingContext::isFramebuffer):
617         (WebCore::WebGLRenderingContext::isProgram):
618         (WebCore::WebGLRenderingContext::isRenderbuffer):
619         (WebCore::WebGLRenderingContext::isShader):
620         (WebCore::WebGLRenderingContext::isTexture):
621         (WebCore::WebGLRenderingContext::useProgram):
622         (WebCore::WebGLRenderingContext::validateProgram):
623         (WebCore::WebGLRenderingContext::vertexAttribPointer):
624         (WebCore::WebGLRenderingContext::detachAndRemoveAllObjects):
625         * html/canvas/WebGLRenderingContext.h:
626         (WebCore::WebGLRenderingContext::VertexAttribState::VertexAttribState):
627         * html/canvas/WebGLRenderingContext.idl:
628         * html/canvas/WebGLShader.cpp:
629         (WebCore::WebGLShader::create):
630         (WebCore::WebGLShader::WebGLShader):
631         * html/canvas/WebGLShader.h:
632         * platform/graphics/GraphicsContext3D.h:
633         (WebCore::GraphicsContext3D::):
634         * platform/graphics/mac/GraphicsContext3DMac.cpp:
635         (WebCore::GraphicsContext3D::createShader):
636
637 2009-11-23  Erik Arvidsson  <arv@chromium.org>
638
639         Reviewed by Eric Seidel.
640
641         JSC bindings for HasIndexGetter generates incorrect code (affects
642         MediaList and CSSStyleDeclaration).
643         This cleans up the edge cases for indexing out of range for style and
644         computed style objects to return an empty string according to the spec.
645         MediaList now returns null when indexed out of range.
646         https://bugs.webkit.org/show_bug.cgi?id=31683
647
648         Tests: fast/dom/CSSStyleDeclaration/css-computed-style-item.html
649                fast/dom/CSSStyleDeclaration/css-style-item.html
650                fast/dom/StyleSheet/css-medialist-item.html
651
652         * bindings/scripts/CodeGeneratorJS.pm: If IndexGetterReturnsString then
653                 we do not check the length before calling the item function.
654         * css/CSSComputedStyleDeclaration.cpp:
655         (WebCore::CSSComputedStyleDeclaration::item):
656         * css/CSSMutableStyleDeclaration.cpp:
657         (WebCore::CSSMutableStyleDeclaration::item):
658         * css/CSSStyleDeclaration.idl:
659
660 2009-11-23  Simon Fraser  <simon.fraser@apple.com>
661
662         Reviewed by Dan Bernstein.
663
664         DocumentMarkers need to be educated about transforms
665         https://bugs.webkit.org/show_bug.cgi?id=31751
666         
667         Find highlight is incorrect with transforms
668         <rdar://problem/6358394>
669
670         Allow callers to specify that Frame::selectionTextRects() takes transforms into account
671         when computing the set of rects that encompass a selection. For transformed elemenets, the
672         selection rect will be the bounding box of the selected content.
673         
674         Fix DocumentMarkers to cache rects in absolute coordinates, rather than painting coordinates.
675         
676         Test: editing/selection/transformed-selection-rects.html
677         
678         * WebCore.base.exp:
679         Frame::selectionTextRects() has a new parameter.
680         
681         * dom/Document.cpp:
682         (WebCore::Document::setRenderedRectForMarker):
683         * dom/Document.h:
684         Pass the marker as a const reference.
685         
686         * dom/Range.h:
687         * dom/Range.cpp:
688         (WebCore::Range::textQuads):
689         Add a new method, textQuads(), which returns a list of quads, respecting transforms.
690         
691         * page/Frame.h:
692         * page/Frame.cpp:
693         (WebCore::Frame::selectionTextRects):
694         Add a new parameter, respectTransforms, and when that is RespectTransforms, use the quad
695         method to get quads for ranges, and then take their bounding boxes.
696
697         * rendering/InlineTextBox.h:
698         * rendering/InlineTextBox.cpp:
699         (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
700         (WebCore::InlineTextBox::paintTextMatchMarker):
701         (WebCore::InlineTextBox::computeRectForReplacementMarker):
702         (WebCore::InlineTextBox::paintDocumentMarkers):
703         (WebCore::InlineTextBox::textPos):
704         (WebCore::InlineTextBox::offsetForPosition):
705         
706         Pass DocumentMarkers as a const references.
707         Convert the argument to setRenderedRectForMarker() into absolute coordinates.
708         
709         * rendering/RenderView.cpp:
710         (WebCore::RenderView::selectionBounds):
711
712 2009-11-23  Dirk Schulze  <krit@webkit.org>
713
714         Reviewed by Oliver Hunt.
715
716         [Cairo] support blurred test-shadow
717         [https://bugs.webkit.org/show_bug.cgi?id=31797]
718
719         Support for blurred text-shadows on Cairo. This patch
720         reuses the code of blurred box-shadows, introduced in
721         bug 26102. For a full textshadow support, a filters enabled
722         build is needed.
723
724         * platform/graphics/cairo/FontCairo.cpp:
725         (WebCore::Font::drawGlyphs):
726
727 2009-11-23  Jens Alfke  <snej@chromium.org>
728
729         Reviewed by Geoffrey Garen.
730
731         Change incorrect calls to the constructor "EventNames()" to the correct accessor
732         "eventNames()". This saves ~100 AtomicString lookups each time.
733         https://bugs.webkit.org/show_bug.cgi?id=31811
734
735         * dom/EventNames.h:  Make constructor private to prevent this from happening again.
736         * history/CachedFrame.cpp:
737         (WebCore::CachedFrameBase::restore):  EventNames() --> eventNames()
738         * html/HTMLFormControlElement.cpp:
739         (WebCore::HTMLFormControlElement::checkValidity):  EventNames() --> eventNames()
740         * loader/FrameLoader.cpp:
741         (WebCore::FrameLoader::stopLoading):  EventNames() --> eventNames()
742         (WebCore::FrameLoader::pageHidden):  EventNames() --> eventNames()
743         * page/DOMWindow.cpp:
744         (WebCore::DOMWindow::dispatchAllPendingUnloadEvents):  EventNames() --> eventNames()
745
746 2009-11-23  Adam Langley  <agl@google.com>
747
748         Reviewed by Dmitry Titov.
749
750         Chromium Linux: Limit the stroke width and mitre limit.
751
752         Limit the stroke width and mitre limit that we'll pass into Skia to
753         avoid overflowing Skia's uint16_t glyph widths.
754
755         http://code.google.com/p/chromium/issues/detail?id=28250
756         https://bugs.webkit.org/show_bug.cgi?id=31747
757
758         * platform/graphics/skia/PlatformContextSkia.cpp:
759         (scalarBound):
760         (PlatformContextSkia::setupPaintForStroking):
761
762 2009-11-23  Alexey Proskuryakov  <ap@apple.com>
763
764         Reviewed by Oliver Hunt.
765
766         https://bugs.webkit.org/show_bug.cgi?id=31812
767         WebSocket code uses RefPtr::get() where it shouldn't
768
769         No change in funcitonality, just coding style correction.
770
771         * websockets/WebSocket.cpp:
772         (WebCore::WebSocket::~WebSocket):
773         * websockets/WebSocketChannel.cpp:
774         (WebCore::WebSocketChannel::connect):
775         (WebCore::WebSocketChannel::send):
776         (WebCore::WebSocketChannel::bufferedAmount):
777         (WebCore::WebSocketChannel::close):
778         (WebCore::WebSocketChannel::disconnect):
779         (WebCore::WebSocketChannel::didOpen):
780         (WebCore::WebSocketChannel::didClose):
781         (WebCore::WebSocketChannel::didReceiveData):
782         (WebCore::WebSocketChannel::didFail):
783
784 2009-11-23  Alexey Proskuryakov  <ap@apple.com>
785
786         Build fix.
787
788         * platform/network/cf/SocketStreamHandleCFNet.cpp:
789         (WebCore::SocketStreamHandle::pacExecutionCallbackMainThread): pacExecutionCallbackMainThread
790         is static, so it can't use member variables directly.
791
792 2009-11-23  Alexey Proskuryakov  <ap@apple.com>
793
794         Reviewed by Brady Eidson.
795
796         https://bugs.webkit.org/show_bug.cgi?id=31748
797         Make WebSocketHandleCFNet respect proxy auto-configuration files via CFProxySupport
798
799         * platform/network/cf/SocketStreamHandle.h: Removed names from some void* arguments, since
800         they didn't carry useful information.
801
802         * platform/network/cf/SocketStreamHandleCFNet.cpp:
803         (WebCore::SocketStreamHandle::SocketStreamHandle): When we need an http-style URL, we actually
804         always need https.
805         (WebCore::SocketStreamHandle::scheduleStreams): Factored out from constructor, since streams
806         only get scheduled after PAC is fetched and executed asynchronously.
807         (WebCore::SocketStreamHandle::copyPACExecutionDescription): Return a description for event
808         source.
809         (WebCore::MainThreadPACCallbackInfo::MainThreadPACCallbackInfo): Forward callback to main thread.
810         (WebCore::SocketStreamHandle::pacExecutionCallback): Ditto.
811         (WebCore::SocketStreamHandle::pacExecutionCallbackMainThread): Ditto. To avoid code duplication,
812         we make the call even on Mac.
813         (WebCore::SocketStreamHandle::executePACFileURL): Make an async call to CFNetworkExecuteProxyAutoConfigurationURL.
814         (WebCore::SocketStreamHandle::removePACRunLoopSource): Once PAC execution is done or aborted,
815         we need to get rid of the event source.
816         (WebCore::SocketStreamHandle::chooseProxy): Use stored m_httpsURL.get.
817         (WebCore::SocketStreamHandle::chooseProxyFromArray): Factored out from chooseProxy - the
818         array may come directly from system configuration, or from PAC.
819         (WebCore::SocketStreamHandle::chooseProxy): Tiger version of this function is now completely
820         separate.
821         (WebCore::SocketStreamHandle::~SocketStreamHandle): Run loop source should be destroyed
822         before we get to the destructor.
823         (WebCore::SocketStreamHandle::platformClose): Destroy the run loop source, if PAC execution
824         is still in progress.
825
826 2009-11-23  Oliver Hunt  <oliver@apple.com>
827
828         Reviewed by Geoff Garen.
829
830         Don't leak the CGImage we create when drawing a sub image.
831
832         * platform/graphics/cg/ImageCG.cpp:
833         (WebCore::BitmapImage::draw):
834
835 2009-11-23  Adam Barth  <abarth@webkit.org>
836
837         Reviewed by Dimitri Glazkov.
838
839         [V8] Don't crash when OOM in creating isolated world
840         https://bugs.webkit.org/show_bug.cgi?id=31805
841
842         We need to add some more null checks to avoid crashing.  No new tests
843         because we don't have a good way to test out-of-memory bugs.
844
845         * bindings/v8/V8Proxy.cpp:
846         (WebCore::V8Proxy::evaluateInIsolatedWorld):
847         (WebCore::V8Proxy::evaluateInNewContext):
848         (WebCore::V8Proxy::setInjectedScriptContextDebugId):
849         * bindings/v8/V8Proxy.h:
850
851 2009-11-23  Dirk Schulze  <krit@webkit.org>
852
853         Reviewed by Nikolas Zimmermann.
854
855         This is the implementation of the filterRes attribute. It
856         helps the SVG developer to set the quality of a filter by
857         giving the width or height of filter.
858         This patch also sets the filter resolution to lower values
859         if a intermediate ImageBuffer size is bigger than the given
860         maximal size.
861         The maximal size is set to 5000x5000 by default. This is a
862         subjectiv decission. Everthing greater than this values gets
863         sensible slower. Values of 10000x10000 crashed on WebKitGtk.
864         For mobil devices a maximum size of 100x100 or 200x200 seems
865         to be reasonable.
866         The important fact on filter resolution is, that the output
867         size is still the size given by the <filter> element.
868
869         Tests: svg/filters/big-sized-filter-2.svg
870                svg/filters/big-sized-filter.svg
871                svg/filters/filterRes.svg
872
873         * platform/graphics/FloatRect.cpp:
874         (WebCore::FloatRect::scale): Add the abbility to scale a rect by x and y.
875         * platform/graphics/FloatRect.h:
876         (WebCore::FloatRect::scale): Add the abbility to scale a rect by x and y.
877         * platform/graphics/cairo/GraphicsContextCairo.cpp:
878         (WebCore::GraphicsContext::createPlatformShadow): Use scaledSubRegion for
879         calculation.
880         * platform/graphics/filters/FEBlend.cpp:
881         (WebCore::FEBlend::apply): Use scaledSubRegion for effect intern calculations.
882         * platform/graphics/filters/FEColorMatrix.cpp:
883         (WebCore::FEColorMatrix::apply): Use scaledSubRegion for effect intern calculations.
884         * platform/graphics/filters/FEComponentTransfer.cpp:
885         (WebCore::FEComponentTransfer::apply): Use scaledSubRegion for effect intern
886         calculations.
887         * platform/graphics/filters/FEComposite.cpp:
888         (WebCore::FEComposite::apply): Use scaledSubRegion for effect intern calculations.
889         * platform/graphics/filters/FEGaussianBlur.cpp:
890         (WebCore::FEGaussianBlur::apply): Use scaledSubRegion for effect intern calculations.
891         * platform/graphics/filters/Filter.h: Add the abbility to change the quality
892         of a filter output.
893         (WebCore::Filter::filterResolution):
894         (WebCore::Filter::setFilterResolution):
895         (WebCore::Filter::calculateEffectSubRegion): Calculates the correct subRegion
896         as well as the scaledSubRegion. It also searches for the biggest effect size.
897         We have to change the filter resolution, if one intermediate ImageBuffer size
898         doesn't fit in the maximal image size.
899         * platform/graphics/filters/FilterEffect.cpp:
900         (WebCore::FilterEffect::calculateDrawingIntRect): Use scaledSubRegion to get
901         the right part of a previous effect result.
902         (WebCore::FilterEffect::calculateDrawingRect): Use scaledSubRegion to get
903         the right part of a previous effect result.
904         (WebCore::FilterEffect::getEffectContext): Use scaledSubRegion to create
905         a new intermediate ImageBuffer for the result of the current effect.
906         * platform/graphics/filters/FilterEffect.h:
907         (WebCore::FilterEffect::scaledSubRegion): The scaled subRegion of a the
908         filter effect.
909         (WebCore::FilterEffect::setScaledSubRegion):
910         (WebCore::FilterEffect::effectBoundaries): The original values of the
911         EffectElement for a second subRegion calculation.
912         (WebCore::FilterEffect::setEffectBoundaries):
913         * platform/graphics/filters/ImageBufferFilter.cpp:
914         (WebCore::ImageBufferFilter::ImageBufferFilter): Set the scale factor to one.
915         * platform/graphics/filters/ImageBufferFilter.h:
916         (WebCore::ImageBufferFilter::maxImageSize):
917         (WebCore::ImageBufferFilter::calculateEffectSubRegion):
918         * platform/graphics/filters/SourceAlpha.cpp:
919         (WebCore::SourceAlpha::calculateEffectRect): Use scaledSubRegion for effect
920         intern calculations.
921         * platform/graphics/filters/SourceGraphic.cpp:
922         (WebCore::SourceGraphic::calculateEffectRect): Use scaledSubRegion for effect
923         intern calculations.
924         * svg/SVGFilterElement.cpp:
925         (WebCore::SVGFilterElement::parseMappedAttribute): Parse filterRes attribute.
926         (WebCore::SVGFilterElement::buildFilter): Give SVGResourceFilter the current
927         filterResolution.
928         * svg/SVGFilterPrimitiveStandardAttributes.cpp:
929         (WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes): Save
930         values to effectBoundaries of the filter effect
931         * svg/graphics/SVGResourceFilter.cpp:
932         (WebCore::SVGResourceFilter::SVGResourceFilter):
933         (WebCore::shouldProcessFilter): Return signal if a neccessary value is zero.
934         (WebCore::SVGResourceFilter::fitsInMaximumImageSize): Checks if the given size
935         fits into the maximal image size, modifys scale factors if not and return a
936         bool: fits.
937         (WebCore::SVGResourceFilter::prepareFilter): Scale the SourceImage to
938         filterResolution (given by FilterElement or calculated on to big image sizes).
939         Set the scale level to SVGFilter.
940         (WebCore::SVGResourceFilter::applyFilter): Don't apply filters if shouldProcessFilter
941         is wrong.
942         * svg/graphics/SVGResourceFilter.h:
943         (WebCore::SVGResourceFilter::setFilterResolution): FilterResolution of FilterElement.
944         (WebCore::SVGResourceFilter::setHasFilterResolution): Does FilterElement provides
945         a FilterResolution?
946         (WebCore::SVGResourceFilter::scaleX): Current scale factor for horizontal.
947         (WebCore::SVGResourceFilter::scaleY): Current scale factor for vertical.
948         * svg/graphics/filters/SVGFEDisplacementMap.cpp:
949         (WebCore::FEDisplacementMap::apply): Use scaledSubRegion for effect intern calculations.
950         Kernel values are scaled to current filter resolution too.
951         * svg/graphics/filters/SVGFEFlood.cpp:
952         (WebCore::FEFlood::apply): Use scaledSubRegion for effect intern calculations.
953         * svg/graphics/filters/SVGFEMerge.cpp:
954         (WebCore::FEMerge::apply): Use scaledSubRegion for effect intern calculations.
955         Kernel values are scaled to current filter resolution too.
956         * svg/graphics/filters/SVGFEMorphology.cpp:
957         (WebCore::FEMorphology::apply): Use scaledSubRegion for effect intern calculations.
958         Kernel values are scaled to current filter resolution too.
959         * svg/graphics/filters/SVGFEOffset.cpp:
960         (WebCore::FEOffset::apply): Use scaledSubRegion for effect intern calculations.
961         * svg/graphics/filters/SVGFETile.cpp:
962         (WebCore::FETile::apply): Use scaledSubRegion for effect intern calculations.
963         * svg/graphics/filters/SVGFilter.cpp:
964         (WebCore::SVGFilter::calculateEffectSubRegion): Calculate subRegion for LayoutTests,
965         scaledSubRegion according to the current filterResolution and get the maximal image size.
966         * svg/graphics/filters/SVGFilter.h:
967         (WebCore::SVGFilter::effectBoundingBoxMode): Original values of the FilterElement. 
968         (WebCore::SVGFilter::filterRegion): Use virtual for clarification.
969         (WebCore::SVGFilter::sourceImageRect): Use virtual for clarification.
970         (WebCore::SVGFilter::maxImageSize): Get the maximal image size.
971
972 2009-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
973
974         Reviewed by Kenneth Rohde Christiansen.
975
976         [Qt] Wrong runtime instance objects of wrapped QObjects may be used if
977         the wrapped object died before the gc removed the instance.
978
979         https://bugs.webkit.org/show_bug.cgi?id=31681
980
981         Before using a cached instance, verify that its wrapped QObject is
982         still alive.
983
984         * bridge/qt/qt_instance.cpp:
985         (JSC::Bindings::QtInstance::getQtInstance):
986         * bridge/qt/qt_instance.h:
987         (JSC::Bindings::QtInstance::hashKey):
988
989 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
990
991         Reviewed by Oliver Hunt.
992
993         ARIA: support aria-flowto
994         https://bugs.webkit.org/show_bug.cgi?id=31762
995
996         Test: platform/mac/accessibility/aria-flowto.html
997
998         * accessibility/AccessibilityObject.h:
999         (WebCore::AccessibilityObject::ariaOwnsElements):
1000         (WebCore::AccessibilityObject::supportsARIAFlowTo):
1001         (WebCore::AccessibilityObject::ariaFlowToElements):
1002         * accessibility/AccessibilityRenderObject.cpp:
1003         (WebCore::AccessibilityRenderObject::linkedUIElements):
1004         (WebCore::AccessibilityRenderObject::supportsARIAFlowTo):
1005         (WebCore::AccessibilityRenderObject::ariaFlowToElements):
1006         * accessibility/AccessibilityRenderObject.h:
1007         * html/HTMLAttributeNames.in:
1008
1009 2009-11-22  Nikolas Zimmermann  <nzimmermann@rim.com>
1010
1011         Not reviewed. Build fix for WML enabled builds.
1012         Adopt WebCore API changes.
1013
1014         * wml/WMLAElement.cpp:
1015         (WebCore::WMLAElement::defaultEventHandler):
1016         * wml/WMLInputElement.cpp:
1017         (WebCore::WMLInputElement::defaultEventHandler):
1018
1019 2009-11-22  Pavel Feldman  <pfeldman@chromium.org>
1020
1021         Reviewed by Timothy Hatcher.
1022
1023         Web Inspector: Introduce sidebar background on timeline panel in order
1024         to prevent it from flickering on scroll.
1025
1026         https://bugs.webkit.org/show_bug.cgi?id=31789
1027
1028         * inspector/front-end/TimelinePanel.js:
1029         (WebInspector.TimelinePanel):
1030         (WebInspector.TimelinePanel.prototype.setSidebarWidth):
1031         (WebInspector.TimelinePanel.prototype._onScroll):
1032         (WebInspector.TimelinePanel.prototype._scheduleRefresh):
1033         * inspector/front-end/inspector.css:
1034
1035 2009-11-22  Pavel Feldman  <pfeldman@chromium.org>
1036
1037         Reviewed by Timothy Hatcher.
1038
1039         Web Inspector: Reimplement TimelinePanel to make it fast:
1040         - Extract grid and overview into separate files
1041         - Make timeline create only divs for visible rows
1042
1043         https://bugs.webkit.org/show_bug.cgi?id=31784
1044
1045         * WebCore.gypi:
1046         * WebCore.vcproj/WebCore.vcproj:
1047         * inspector/front-end/AbstractTimelinePanel.js:
1048         (WebInspector.AbstractTimelinePanel.prototype.createInterface):
1049         (WebInspector.AbstractTimelinePanel.prototype.refresh):
1050         (WebInspector.AbstractTimelinePanel.prototype.set calculator):
1051         * inspector/front-end/TimelineGrid.js: Added.
1052         (WebInspector.TimelineGrid):
1053         (WebInspector.TimelineGrid.prototype.get itemsGraphsElement):
1054         (WebInspector.TimelineGrid.prototype.updateDividers):
1055         (WebInspector.TimelineGrid.prototype.addEventDivider):
1056         (WebInspector.TimelineGrid.prototype.setScrollAndDividerTop):
1057         * inspector/front-end/TimelineOverviewPane.js: Added.
1058         (WebInspector.TimelineOverviewPane):
1059         (WebInspector.TimelineOverviewPane.prototype._onCheckboxClicked):
1060         (WebInspector.TimelineOverviewPane.prototype.update):
1061         (WebInspector.TimelineOverviewPane.prototype.setSidebarWidth):
1062         (WebInspector.TimelineOverviewPane.prototype.updateMainViewWidth):
1063         (WebInspector.TimelineOverviewPane.prototype.reset):
1064         (WebInspector.TimelineOverviewPane.prototype._resizeWindow):
1065         (WebInspector.TimelineOverviewPane.prototype._windowResizeDragging):
1066         (WebInspector.TimelineOverviewPane.prototype._dragWindow):
1067         (WebInspector.TimelineOverviewPane.prototype._windowDragging):
1068         (WebInspector.TimelineOverviewPane.prototype._resizeWindowLeft):
1069         (WebInspector.TimelineOverviewPane.prototype._resizeWindowRight):
1070         (WebInspector.TimelineOverviewPane.prototype._setWindowPosition):
1071         (WebInspector.TimelineOverviewPane.prototype._endWindowDragging):
1072         (WebInspector.TimelineOverviewCalculator):
1073         (WebInspector.TimelineOverviewCalculator.prototype.computeBarGraphPercentages):
1074         (WebInspector.TimelineOverviewCalculator.prototype.reset):
1075         (WebInspector.TimelineOverviewCalculator.prototype.updateBoundaries):
1076         (WebInspector.TimelineOverviewCalculator.prototype.get boundarySpan):
1077         (WebInspector.TimelineOverviewCalculator.prototype.formatValue):
1078         (WebInspector.TimelineCategoryTreeElement):
1079         (WebInspector.TimelineCategoryTreeElement.prototype.onattach):
1080         (WebInspector.TimelineCategoryGraph):
1081         (WebInspector.TimelineCategoryGraph.prototype.get graphElement):
1082         (WebInspector.TimelineCategoryGraph.prototype.addChunk):
1083         (WebInspector.TimelineCategoryGraph.prototype.clearChunks):
1084         (WebInspector.TimelineCategoryGraph.prototype.set dimmed):
1085         * inspector/front-end/TimelinePanel.js:
1086         (WebInspector.TimelinePanel):
1087         (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
1088         (WebInspector.TimelinePanel.prototype.addRecordToTimeline):
1089         (WebInspector.TimelinePanel.prototype._formatRecord):
1090         (WebInspector.TimelinePanel.prototype.setSidebarWidth):
1091         (WebInspector.TimelinePanel.prototype.updateMainViewWidth):
1092         (WebInspector.TimelinePanel.prototype.resize):
1093         (WebInspector.TimelinePanel.prototype.reset):
1094         (WebInspector.TimelinePanel.prototype.show):
1095         (WebInspector.TimelinePanel.prototype._onScroll):
1096         (WebInspector.TimelinePanel.prototype._scheduleRefresh):
1097         (WebInspector.TimelinePanel.prototype._refresh):
1098         (WebInspector.TimelinePanel.prototype._refreshRecords):
1099         (WebInspector.TimelinePanel.prototype._adjustScrollPosition):
1100         (WebInspector.TimelineCategory):
1101         (WebInspector.TimelineCalculator):
1102         (WebInspector.TimelineCalculator.prototype.get boundarySpan):
1103         (WebInspector.TimelineRecordListRow):
1104         (WebInspector.TimelineRecordListRow.prototype.update):
1105         (WebInspector.TimelineRecordGraphRow):
1106         (WebInspector.TimelineRecordGraphRow.prototype.update):
1107         * inspector/front-end/WebKit.qrc:
1108         * inspector/front-end/inspector.css:
1109         * inspector/front-end/inspector.html:
1110
1111 2009-11-22  Chris Evans  <cevans@chromium.org>
1112
1113         Reviewed by Adam Barth.
1114
1115         Disable access to file:/// directory listings
1116         https://bugs.webkit.org/show_bug.cgi?id=31329
1117
1118         Deny access to directory listings. This needs doing in WebKit for
1119         WebKit clients that do permit top-level navigation to file:///dir.
1120         This matches Firefox, plus the existing Safari implementation (which
1121         does not support any directory access at all). It will fix the
1122         LayoutTest named below for Chromium.
1123
1124         Test: fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html
1125
1126         * page/SecurityOrigin.cpp: Deny access to directory listings.
1127         (WebCore::SecurityOrigin::SecurityOrigin):
1128         (WebCore::SecurityOrigin::canRequest):
1129
1130 2009-11-20  Joseph Pecoraro  <joepeck@webkit.org>
1131
1132         Reviewed by Timothy Hatcher.
1133
1134         Web Inspector: Support Ctrl+P and Ctrl+N, Readline keyboard shortcuts in the Console
1135         https://bugs.webkit.org/show_bug.cgi?id=31400
1136
1137         Handle the following when on a Mac:
1138
1139           Ctrl+P = Previous (like Up arrow)
1140           Ctrl+N = Next (like Down arrow)
1141
1142         No longer rerun autocompletion when just pushing a modifier key
1143         like Control, Alt, Shift, or Meta.
1144
1145         Improved arrow key behavior with Multiline code in the Console, with the following behavior:
1146
1147           Up   = Previous Command if on First Line (caret moves to the end of the first line)
1148                  otherwise default caret movement in text.
1149           Down = Next Command if on Last Line (caret naturally moves to the end)
1150                  otherwise default caret movement in text.
1151
1152         * inspector/front-end/TextPrompt.js:
1153         (WebInspector.TextPrompt.prototype.handleKeyEvent): handle new keyboard shortcuts
1154         (WebInspector.TextPrompt.prototype.isCaretOnFirstLine): check if the caret is on the top line
1155         (WebInspector.TextPrompt.prototype.isCaretOnLastLine): check if the caret is on the bottom line
1156         (WebInspector.TextPrompt.prototype._upKeyPressed):
1157         (WebInspector.TextPrompt.prototype._downKeyPressed):
1158         (WebInspector.TextPrompt.prototype._moveBackInHistory):
1159         (WebInspector.TextPrompt.prototype._moveForwardInHistory):
1160
1161 2009-11-21  Jessie Berlin  <jberlin@webkit.org>
1162
1163         Reviewed by Timothy Hatcher.
1164
1165         Adds a tooltip containing the full url of the resource to each element
1166         in the Resources panel so that it is possible to quickly see the query
1167         parameters.
1168         https://bugs.webkit.org/show_bug.cgi?id=19103
1169
1170         * inspector/front-end/ResourcesPanel.js:
1171         (WebInspector.ResourceSidebarTreeElement.prototype.refresh):
1172         Set the tooltip to be the resource's url.
1173
1174 2009-11-21  Simon Fraser  <simon.fraser@apple.com>
1175
1176         Reviewed by Dan Bernstein.
1177
1178         CSSKeyframesRule::findRule() and deleteRule() should accept 'from' and 'to' as well as percentages
1179         https://bugs.webkit.org/show_bug.cgi?id=31588
1180         
1181         In WebKitCSSKeyframesRule::findRuleIndex(), map 'from' to 0% an 'to' to 100%
1182         so that findRule() and deleteRule() work with these keywords.
1183
1184         * css/WebKitCSSKeyframesRule.cpp:
1185         (WebCore::WebKitCSSKeyframesRule::findRuleIndex):
1186
1187 2009-11-21  Daniel Bates  <dbates@webkit.org>
1188
1189         Reviewed by Eric Seidel.
1190
1191         https://bugs.webkit.org/show_bug.cgi?id=31647
1192
1193         Changed KeyboardEvent::m_keyEvent from a raw pointer to an OwnPtr.
1194
1195         No functionality was changed. So, no new tests.
1196
1197         * dom/KeyboardEvent.cpp:
1198         (WebCore::KeyboardEvent::~KeyboardEvent):
1199         * dom/KeyboardEvent.h: Changed m_keyEvent to OwnPtr.
1200         (WebCore::KeyboardEvent::keyEvent):
1201
1202 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
1203
1204         Reviewed by Beth Dakin.
1205
1206         WAI-ARIA: add support for aria-owns
1207         https://bugs.webkit.org/show_bug.cgi?id=31702
1208
1209         Re-organized how accessibilityAttributeNames are returned so 
1210         that it's possible for an element to add an attribute based on 
1211         a dynamic value. In this case, we only want to add AXOwn if the 
1212         element actually supports aria-owns.
1213   
1214         Test: platform/mac/accessibility/aria-owns.html
1215
1216         * accessibility/AccessibilityObject.h:
1217         (WebCore::AccessibilityObject::supportsARIAOwns):
1218         (WebCore::AccessibilityObject::ariaOwnsElements):
1219         * accessibility/AccessibilityRenderObject.cpp:
1220         (WebCore::AccessibilityRenderObject::ariaOwnsElements):
1221         (WebCore::AccessibilityRenderObject::supportsARIAOwns):
1222         * accessibility/AccessibilityRenderObject.h:
1223         * accessibility/mac/AccessibilityObjectWrapper.mm:
1224         (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
1225         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
1226         (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
1227         * html/HTMLAttributeNames.in:
1228
1229 2009-11-20  Eric Carlson  <eric.carlson@apple.com>
1230
1231         Reviewed by Simon Fraser.
1232
1233         <rdar://problem/7414396> Leopard & Tiger: Support closed caption in <video> element
1234
1235         * css/mediaControls.css:
1236             Define closed caption toggle button.
1237
1238         * rendering/RenderMedia.cpp:
1239         (WebCore::RenderMedia::updateControls):
1240             Create closed caption toggle button in display order.
1241
1242         * rendering/RenderThemeMac.mm:
1243         (WebCore::RenderThemeMac::shouldRenderMediaControlPart):
1244             Don't require MediaControllerThemeQuickTime theme for captions toggle button.
1245             No need to check if the movie has video, a closed captions track is a video
1246             track.
1247
1248 2009-11-20  Joseph Pecoraro  <joepeck@webkit.org>
1249
1250         Reviewed by Timothy Hatcher.
1251
1252         Web Inspector: Running code in the Console that ends with a
1253         single line comment no longer produces a parse error.
1254
1255         * inspector/front-end/InjectedScript.js:
1256         (InjectedScript._evaluateOn):
1257
1258 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
1259
1260         Reviewed by Beth Dakin.
1261
1262         WAI-ARIA: add support for 'math' role
1263         https://bugs.webkit.org/show_bug.cgi?id=31706
1264
1265         * accessibility/AccessibilityObject.cpp:
1266         * accessibility/AccessibilityObject.h:
1267         * accessibility/mac/AccessibilityObjectWrapper.mm:
1268
1269 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
1270
1271         Reviewed by Kenneth Rohde Christiansen.
1272
1273         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
1274         https://bugs.webkit.org/show_bug.cgi?id=30460
1275
1276         Replace call to PluginDatabase::installedPlugins()->refresh() with Page::refreshPlugins().
1277         It already refreshes plugins and reloads pages when necessary.
1278
1279         Tests: plugins/reloadplugins-and-pages.html
1280                plugins/reloadplugins-no-pages.html
1281
1282         * plugins/PluginInfoStore.cpp:
1283         (WebCore::refreshPlugins):
1284
1285 2009-11-20  Oliver Hunt  <oliver@apple.com>
1286
1287         Reviewed by Dave Hyatt.
1288
1289         <rdar://7409188> WebKit needs to be able to serialize and deserialize objects.
1290
1291         Expose WebCore object serialization to WebKit.
1292
1293         * WebCore.base.exp:
1294         * bindings/js/SerializedScriptValue.cpp:
1295         (WebCore::SerializedScriptValue::~SerializedScriptValue):
1296         (WebCore::SerializedScriptValue::create):
1297         (WebCore::SerializedScriptValue::deserialize):
1298         * bindings/js/SerializedScriptValue.h:
1299
1300 2009-11-20  Brian Weinstein  <bweinstein@apple.com>
1301
1302         Reviewed by Tim Hatcher.
1303
1304         Fixes <http://webkit.org/b/31741>.
1305         Web Inspector: User Entered Data on the console should show up no matter what filters.
1306         
1307         Always show .console-user-command-result, no matter what the filter say
1308         we should do with the other classes.
1309
1310         * inspector/front-end/inspector.css:
1311
1312 2009-11-20  Brian Weinstein  <bweinstein@apple.com>
1313
1314         Reviewed by Tim Hatcher.
1315
1316         Fixes <http://webkit.org/b/31700>.
1317         Web Inspector: isMac should be in one central location + Cached.
1318         
1319         We should cache the value of isMac, and make the indexOf call in one
1320         single location, because we are calling it from multiple places, and saving
1321         the result can save us time, and make the call sites simpler.
1322
1323         * inspector/front-end/AbstractTimelinePanel.js:
1324         (WebInspector.AbstractTimelinePanel.prototype._updateFilter):
1325         * inspector/front-end/ConsoleView.js:
1326         (WebInspector.ConsoleView.prototype._updateFilter):
1327         * inspector/front-end/ElementsPanel.js:
1328         (WebInspector.ElementsPanel.prototype.handleKeyEvent):
1329         * inspector/front-end/ScriptsPanel.js:
1330         (WebInspector.ScriptsPanel):
1331         * inspector/front-end/SourceFrame.js:
1332         (WebInspector.SourceFrame.prototype._loaded):
1333         * inspector/front-end/inspector.js:
1334         (WebInspector.documentKeyDown):
1335         (WebInspector.isMac):
1336
1337 2009-11-19  Joseph Pecoraro  <joepeck@webkit.org>
1338
1339         Removed .DS_Store accidentally added in last (r51245).
1340
1341 2009-11-19  Joseph Pecoraro  <joepeck@webkit.org>
1342
1343         Reviewed by Timothy Hatcher.
1344
1345         Web Inspector: Add Console Only Layout Mode
1346         https://bugs.webkit.org/show_bug.cgi?id=30282
1347
1348         Adds a Console Panel, which allows for a Full size Console. This
1349         extends the Drawer to the size of a Panel. This also fixes previous
1350         resize issues with the Drawer.
1351
1352         * inspector/front-end/ConsolePanel.js: added.
1353         (WebInspector.ConsolePanel):
1354         (WebInspector.ConsolePanel.prototype.toolbarItemClass.get toolbarItemLabel):
1355         (WebInspector.ConsolePanel.prototype.show):
1356         (WebInspector.ConsolePanel.prototype.hide):
1357         * inspector/front-end/Drawer.js:
1358         (WebInspector.Drawer):
1359         (WebInspector.Drawer.prototype.set visibleView):
1360         (WebInspector.Drawer.prototype.get savedHeight): access the saved height of the variable console.
1361         (WebInspector.Drawer.prototype.show.animationFinished):
1362         (WebInspector.Drawer.prototype.show):
1363         (WebInspector.Drawer.prototype.hide.animationFinished):
1364         (WebInspector.Drawer.prototype.hide):
1365         (WebInspector.Drawer.prototype.resize): resize appropriately if full/non-full
1366         (WebInspector.Drawer.prototype.enterPanelMode):
1367         (WebInspector.Drawer.prototype.exitPanelMode):
1368         (WebInspector.Drawer.prototype.immediatelyExitPanelMode):
1369         (WebInspector.Drawer.prototype._cancelAnimationIfNeeded):
1370         (WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished):
1371         (WebInspector.Drawer.prototype._animateDrawerHeight):
1372         (WebInspector.Drawer.prototype._animationDuration):
1373         (WebInspector.Drawer.prototype._startStatusBarDragging):
1374         (WebInspector.Drawer.prototype._statusBarDragging):
1375         (WebInspector.Drawer.prototype._endStatusBarDragging):
1376
1377         Miscellaneous changes and cleanup.
1378
1379         * English.lproj/localizedStrings.js: "Console" toolbar title.
1380         * inspector/front-end/ConsoleView.js: removed unnecessary element reordering  
1381         * inspector/front-end/Images/consoleIcon.png: added.
1382         * inspector/front-end/inspector.css: added icon.
1383         * inspector/front-end/inspector.html:
1384         * inspector/front-end/inspector.js:
1385         (WebInspector._createPanels): create console panel
1386         (WebInspector.windowResize): resize drawer if necessary
1387         (WebInspector.documentKeyDown): esc should not toggle the console when in panel mode
1388         (WebInspector.animateStyle): start animation interval, returns the interval key
1389         (WebInspector.toggleAttach): resize drawer if necessary
1390         (WebInspector.showConsolePanel): restore the panel when the inspector restarts
1391         (WebInspector.showProfileForURL): style fix
1392
1393         Restore the panel when the inspector restarts.
1394
1395         * inspector/InspectorController.cpp:
1396         (WebCore::InspectorController::setWindowVisible):
1397         (WebCore::InspectorController::specialPanelForJSName):
1398         * inspector/InspectorFrontend.cpp:
1399         (WebCore::InspectorFrontend::showPanel):
1400
1401         Build files.
1402
1403         * WebCore.gypi:
1404         * WebCore.vcproj/WebCore.vcproj:
1405         * inspector/front-end/WebKit.qrc:
1406
1407 2009-11-20  Brian Weinstein  <bweinstein@apple.com>
1408
1409         Reviewed by Tim Hatcher.
1410
1411         Fixes <http://webkit.org/b/31699>.
1412         Web Inspector: Should Cache Values of InspectorController.platform() and port().
1413
1414         Refactor the Inspector to cache the value of InspectorController.platform
1415         and InspectorController.port, because those need to call into C++, they are
1416         being called more and more as we add platform specific keyboard shortcuts, and
1417         they shouldn't change in the lifecycle of the Web Inspector.
1418
1419         * inspector/front-end/AbstractTimelinePanel.js:
1420         (WebInspector.AbstractTimelinePanel.prototype._updateFilter):
1421         * inspector/front-end/ConsoleView.js:
1422         (WebInspector.ConsoleView.prototype._updateFilter):
1423         * inspector/front-end/ElementsPanel.js:
1424         (WebInspector.ElementsPanel.prototype.handleKeyEvent):
1425         * inspector/front-end/ScriptsPanel.js:
1426         (WebInspector.ScriptsPanel):
1427         * inspector/front-end/SourceFrame.js:
1428         (WebInspector.SourceFrame.prototype._loaded):
1429         * inspector/front-end/inspector.js:
1430         (WebInspector.get platform):
1431         (WebInspector.get port):
1432         (WebInspector.loaded):
1433         (WebInspector.documentKeyDown):
1434         (WebInspector.toolbarDragStart):
1435
1436 2009-11-20  Dirk Schulze  <krit@webkit.org>
1437
1438         Unreviewed build fix for filters enabled builds.
1439
1440         * platform/graphics/filters/FEColorMatrix.cpp:
1441         (WebCore::FEColorMatrix::apply):
1442         * platform/graphics/filters/FEComposite.cpp:
1443         (WebCore::FEComposite::apply):
1444         * platform/graphics/filters/SourceGraphic.cpp:
1445         (WebCore::SourceGraphic::apply):
1446         * svg/graphics/SVGResourceFilter.cpp:
1447         (WebCore::SVGResourceFilter::applyFilter):
1448         * svg/graphics/filters/SVGFEMerge.cpp:
1449         (WebCore::FEMerge::apply):
1450         * svg/graphics/filters/SVGFEOffset.cpp:
1451         (WebCore::FEOffset::apply):
1452         * svg/graphics/filters/SVGFETile.cpp:
1453         (WebCore::FETile::apply):
1454
1455 2009-11-20  Eric Carlson  <eric.carlson@apple.com>
1456
1457         Reviewed by Simon Fraser.
1458
1459         <rdar://problem/7389945> QTKit based media engine should not claim to support 
1460         fullscreen on Leopard
1461
1462         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
1463         (WebCore::MediaPlayerPrivate::supportsFullscreen):
1464             Only return true on SnowLeopard for now.
1465
1466         * rendering/RenderThemeMac.mm:
1467         (WebCore::RenderThemeMac::shouldRenderMediaControlPart):
1468             No need to special case MediaFullscreenButtonPart as the default implementation 
1469             asks the media engine if it supports fullscreen.
1470
1471 2009-11-18  Girish Ramakrishnan  <girish@forwardbias.in>
1472
1473         Reviewed by Simon Hausmann.
1474
1475         Patch by Yongjun Zhang <yongjun.zhang@nokia.com> and
1476                  Girish Ramakrishnan <girish@forwardbias.in>
1477         
1478         [Qt] Implement support for rendering plugins on Qt/Mac when a page is used
1479         without a QWebView or when inside QGraphicsWebView.
1480         
1481         Currently, the code provides the cgcontext of the PlatformPluginWidget to
1482         the plugin. This approach does not work when we are printing, or using
1483         QWebFrame::render() to render to a QImage/QPixmap since the plugin ends
1484         up drawing on the QWebView (i.e platformPluginWidget's cgcontext) instead
1485         of the QPaintDevice's context.
1486         
1487         To solve all cases and keep the code simple, we render the plugin to an
1488         offscreen pixmap in all cases. This way, the plugin always renders to the
1489         CGContext of the pixmap and we then use QPainter to blit the pixmap into
1490         the QPaintDevice. We also create a fake window and set it's WindowRef in
1491         NPWindow. Only with this WindowRef does Flash paint correctly to the QPixmap.
1492         
1493         Now, that's the theory. In practice, ATM, mouse events do not work when using
1494         the fake window. So, setPlatformPluginWidget() is still called when using QWebView
1495         so that there are no regressions after this patch. Once we get mouse events
1496         working, setPlatformPluginWidget will be removed.
1497         
1498         https://bugs.webkit.org/show_bug.cgi?id=31183
1499
1500         * plugins/PluginView.cpp:
1501         (WebCore::PluginView::PluginView):
1502         * plugins/PluginView.h:
1503         * plugins/mac/PluginViewMac.cpp:
1504         (WebCore::PluginView::platformStart):
1505         (WebCore::PluginView::platformDestroy):
1506         (WebCore::PluginView::setNPWindowIfNeeded):
1507         (WebCore::PluginView::updatePluginWidget):
1508         (WebCore::PluginView::paint):
1509         (WebCore::PluginView::invalidateRect):
1510
1511 2009-11-19  Joseph Pecoraro  <joepeck@webkit.org>
1512
1513         Reviewed by Timothy Hatcher.
1514
1515         Web Inspector: Resync Resources Backend and Frontend
1516         https://bugs.webkit.org/show_bug.cgi?id=31705
1517
1518         * inspector/front-end/Resource.js: resync enum values with backend
1519         (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType): return false if all else fails, not true in all cases
1520
1521 2009-11-19  Steve Block  <steveblock@google.com>
1522
1523         Reviewed by Darin Fisher.
1524
1525         Android port lacks configuration in Platform.h and config.h.
1526         https://bugs.webkit.org/show_bug.cgi?id=31671
1527
1528         Build change only. No new tests possible.
1529
1530         * config.h: Modified. Added Android-specific configuration.
1531
1532 2009-11-20  Roland Steiner  <rolandsteiner@chromium.org>
1533
1534         Reviewed by Darin Adler.
1535
1536         Change default stylesheet to reset text indentation for ruby elements by default.
1537         (https://bugs.webkit.org/show_bug.cgi?id=31247)
1538
1539         Test: fast/ruby/ruby-text-indent.html
1540
1541         * css/html.css: reset text-indent on <ruby> and <rt> elements
1542
1543 2009-11-19  Brian Weinstein  <bweinstein@apple.com>
1544
1545         Reviewed by Darin Adler.
1546
1547         Fixes <http://webkit.org/b/22754>.
1548         Web Inspector: Keyboard shortcut for Element finder.
1549
1550         Use Command + Shift + C as a shortcut for Node Search, to 
1551         match the Firebug shortcut to do the same thing.
1552
1553         * inspector/front-end/ElementsPanel.js:
1554         (WebInspector.ElementsPanel.prototype.handleKeyEvent):
1555
1556 2009-11-19  Alexey Proskuryakov  <ap@apple.com>
1557
1558         Reviewed by Darin Adler.
1559
1560         https://bugs.webkit.org/show_bug.cgi?id=31690
1561         Make SocketStreamHandleCFNet work on Windows
1562
1563         * WebCore.vcproj/WebCore.vcproj: Added LoaderRunLoopCF.
1564
1565         * platform/network/ResourceHandle.h: Removed loaderRunLoop().
1566
1567         * platform/network/cf/LoaderRunLoopCF.cpp: Added.
1568         (WebCore::emptyPerform):
1569         (WebCore::runLoaderThread):
1570         (WebCore::loaderRunLoop):
1571         * platform/network/cf/LoaderRunLoopCF.h: Added.
1572         Moved the run loop that we use for CFNetwork from ResourceHandle to its own file, because
1573         it's needed for more than just resource loading.
1574
1575         * platform/network/cf/ResourceHandleCFNet.cpp: Use loaderRunLoop() from its new location.
1576
1577         * platform/network/cf/DNSCFNet.cpp: (WebCore::DNSResolveQueue::resolve): Ditto.
1578
1579         * platform/network/cf/SocketStreamHandle.h: Added static callbacks for forwarding events to
1580         main thread.
1581         * platform/network/cf/SocketStreamHandleCFNet.cpp:
1582         (WebCore::SocketStreamHandle::SocketStreamHandle): Use loaderRunLoop() on Windows instead of
1583         inoperable main run loop.
1584
1585         (WebCore::MainThreadEventCallbackInfo::MainThreadEventCallbackInfo): 
1586         (WebCore::SocketStreamHandle::readStreamCallback):
1587         (WebCore::SocketStreamHandle::writeStreamCallback):
1588         (WebCore::SocketStreamHandle::readStreamCallbackMainThread):
1589         (WebCore::SocketStreamHandle::writeStreamCallbackMainThread):
1590         Forward stream events to main thread on Windows.
1591
1592 2009-11-19  Avi Drissman  <avi@chromium.org>
1593
1594         Reviewed by Darin Adler.
1595
1596         Quick style fix.
1597         https://bugs.webkit.org/show_bug.cgi?id=27777
1598
1599         * platform/graphics/cg/PDFDocumentImage.cpp:
1600
1601 2009-11-19  Beth Dakin  <bdakin@apple.com>
1602
1603        Build fix. No review needed.
1604
1605         * platform/chromium/ScrollbarThemeChromium.cpp:
1606         (WebCore::ScrollbarThemeChromium::paintTickmarks):
1607         * rendering/RenderMediaControlsChromium.cpp:
1608         (WebCore::paintMediaButton):
1609
1610 2009-11-19  Beth Dakin  <bdakin@apple.com>
1611       
1612        Build fix. No review needed.
1613
1614         * rendering/RenderThemeChromiumSkia.cpp:
1615         (WebCore::RenderThemeChromiumSkia::paintCheckbox):
1616         (WebCore::RenderThemeChromiumSkia::paintRadio):
1617         (WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
1618         (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
1619         (WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):
1620
1621 2009-11-19  Beth Dakin  <bdakin@apple.com>
1622
1623        Build fix. No review needed.
1624
1625         * platform/graphics/qt/StillImageQt.cpp:
1626         (WebCore::StillImage::draw):
1627         * platform/graphics/qt/StillImageQt.h:
1628
1629 2009-11-19  Beth Dakin  <bdakin@apple.com>
1630
1631        Build fix. No review needed.
1632
1633         * rendering/RenderThemeWin.cpp:
1634         (WebCore::RenderThemeWin::paintSearchFieldCancelButton):
1635         (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
1636         (WebCore::RenderThemeWin::paintSearchFieldResultsButton):
1637
1638 2009-11-19  Beth Dakin  <bdakin@apple.com>
1639
1640        Build fix. No review needed.
1641
1642         * plugins/PluginView.cpp:
1643         (WebCore::PluginView::paintMissingPluginIcon):
1644
1645 2009-11-19  Beth Dakin  <bdakin@apple.com>
1646
1647         Build fix. No review needed.
1648
1649         * platform/graphics/win/ImageCGWin.cpp:
1650         (WebCore::BitmapImage::getHBITMAPOfSize):
1651         (WebCore::BitmapImage::drawFrameMatchingSourceSize):
1652
1653 2009-11-19  Beth Dakin  <bdakin@apple.com>
1654
1655         Reviewed by Darin Adler.
1656
1657         Fix for https://bugs.webkit.org/show_bug.cgi?id=31321 Make -webkit-
1658         color-correction work with untagged images
1659
1660         Image's draw(), drawPattern(), and fillWithSolidColor() functions 
1661         now take a ColorSpace. A bunch of classes inherit from Image, so 
1662         draw() and drawPattern() functions there must also take a 
1663         ColorSpace.
1664         * platform/graphics/Image.cpp:
1665         (WebCore::Image::fillWithSolidColor):
1666         (WebCore::Image::drawTiled):
1667         * platform/graphics/Image.h:
1668         * platform/graphics/BitmapImage.h:
1669         * platform/graphics/GeneratedImage.cpp:
1670         (WebCore::GeneratedImage::draw):
1671         (WebCore::GeneratedImage::drawPattern):
1672         * platform/graphics/GeneratedImage.h:
1673         * platform/graphics/cg/PDFDocumentImage.cpp:
1674         (WebCore::PDFDocumentImage::draw):
1675         * platform/graphics/cg/PDFDocumentImage.h:
1676         * svg/graphics/SVGImage.cpp:
1677         (WebCore::SVGImage::draw):
1678         * svg/graphics/SVGImage.h:
1679
1680         All of the drawImage() functions and drawTiled() functions of 
1681         GraphicsContext now take a ColorSpace.
1682         * platform/graphics/GraphicsContext.cpp:
1683         (WebCore::GraphicsContext::drawImage):
1684         (WebCore::GraphicsContext::drawTiledImage):
1685         * platform/graphics/GraphicsContext.h:
1686
1687         This is where the actual work is done.
1688         * platform/graphics/cg/ImageCG.cpp:
1689         (WebCore::imageWithColorSpace): New static function that returns a 
1690         copy of the given image in the given ColorSpace *IF* we should use 
1691         the given ColorSpace. We will ignore the color space if the image 
1692         is tagged and return 0. 
1693         (WebCore::BitmapImage::draw): Now takes a ColorSpace and uses it to 
1694         call imageWithColorSpace(). 
1695         (WebCore::Image::drawPattern): Same.
1696
1697         Attempt to keep all ports building. 
1698         * platform/graphics/cairo/ImageCairo.cpp:
1699         (WebCore::BitmapImage::draw):
1700         (WebCore::Image::drawPattern):
1701         * platform/graphics/haiku/ImageHaiku.cpp:
1702         (WebCore::BitmapImage::draw):
1703         (WebCore::Image::drawPattern):
1704         * platform/graphics/qt/ImageQt.cpp:
1705         (WebCore::Image::drawPattern):
1706         (WebCore::BitmapImage::draw):
1707         * platform/graphics/skia/BitmapImageSingleFrameSkia.h:
1708         * platform/graphics/skia/ImageSkia.cpp:
1709         (WebCore::Image::drawPattern):
1710         (WebCore::BitmapImage::draw):
1711         (WebCore::BitmapImageSingleFrameSkia::draw):
1712         * platform/graphics/wx/ImageWx.cpp:
1713         (WebCore::BitmapImage::draw):
1714         (WebCore::BitmapImage::drawPattern):
1715
1716         Callers of GraphicsContext's drawImage() and drawTiled() functions 
1717         now need to send a ColorSpace.
1718         * html/HTMLCanvasElement.cpp:
1719         (WebCore::HTMLCanvasElement::paint):
1720         * html/canvas/CanvasRenderingContext2D.cpp:
1721         (WebCore::CanvasRenderingContext2D::drawImage):
1722         (WebCore::CanvasRenderingContext2D::drawImageFromRect):
1723         * platform/ScrollView.cpp:
1724         (WebCore::ScrollView::wheelEvent):
1725         * platform/graphics/filters/FEColorMatrix.cpp:
1726         (WebCore::FEColorMatrix::apply):
1727         * platform/graphics/filters/FEComposite.cpp:
1728         (WebCore::FEComposite::apply):
1729         * platform/graphics/filters/SourceGraphic.cpp:
1730         (WebCore::SourceGraphic::apply):
1731         * platform/mac/ScrollbarThemeMac.mm:
1732         (WebCore::ScrollbarThemeMac::paint):
1733         * rendering/RenderBoxModelObject.cpp:
1734         (WebCore::RenderBoxModelObject::paintFillLayerExtended):
1735         (WebCore::RenderBoxModelObject::paintNinePieceImage):
1736         * rendering/RenderImage.cpp:
1737         (WebCore::RenderImage::paintReplaced):
1738         * rendering/RenderLayer.cpp:
1739         (WebCore::RenderLayer::paintResizer):
1740         * rendering/RenderListMarker.cpp:
1741         (WebCore::RenderListMarker::paint):
1742         * rendering/RenderSVGImage.cpp:
1743         (WebCore::RenderSVGImage::paint):
1744         * rendering/RenderWidget.cpp:
1745         (WebCore::RenderWidget::paint):
1746         * svg/graphics/SVGPaintServerPattern.cpp:
1747         (WebCore::SVGPaintServerPattern::setup):
1748         * svg/graphics/SVGResourceFilter.cpp:
1749         (WebCore::SVGResourceFilter::applyFilter):
1750         * svg/graphics/filters/SVGFEMerge.cpp:
1751         (WebCore::FEMerge::apply):
1752         * svg/graphics/filters/SVGFEOffset.cpp:
1753         (WebCore::FEOffset::apply):
1754         * svg/graphics/filters/SVGFETile.cpp:
1755         (WebCore::FETile::apply):
1756
1757 2009-11-19  Avi Drissman  <avi@chromium.org>
1758
1759         Reviewed by Darin Adler.
1760
1761         Properly create a CGImageRef on non-PLATFORM(MAC).
1762         https://bugs.webkit.org/show_bug.cgi?id=27777
1763
1764         * platform/graphics/cg/ImageSourceCG.cpp:
1765         (WebCore::sharedBufferGetBytesAtPosition):
1766         (WebCore::sharedBufferRelease):
1767         (WebCore::ImageSource::setData):
1768         * platform/graphics/cg/ImageSourceCG.h:
1769         * platform/graphics/cg/PDFDocumentImage.cpp:
1770         (WebCore::PDFDocumentImage::dataChanged):
1771
1772 2009-11-19  Oliver Hunt  <oliver@apple.com>
1773
1774         Reviewed by Dave Hyatt.
1775
1776         -webkit-user-drag: element Drag images include overflow decorations from incorrect nodes
1777         https://bugs.webkit.org/show_bug.cgi?id=31656
1778
1779         Make sure we're a child of the painting root before drawing overflow features.
1780
1781         * manual-tests/user-drag-with-decorations.html: Added.
1782         * rendering/RenderBlock.cpp:
1783         (WebCore::RenderBlock::paint):
1784
1785 2009-11-19  Dmitry Titov  <dimich@chromium.org>
1786
1787         Not reviewed, attempt to fix Chromium build.
1788
1789         * rendering/RenderMediaControlsChromium.cpp:
1790         (WebCore::RenderMediaControlsChromium::paintMediaControlsPart): Add new enum values for Show/HideClosedCaptionButton to make it compile.
1791
1792 2009-11-19  Rahul Kuchhal  <kuchhal@chromium.org>
1793
1794         Reviewed by Darin Adler.
1795
1796         Do not assert when a high number is used for roman numerals in lists.
1797         https://bugs.webkit.org/show_bug.cgi?id=31652
1798
1799         Test: fast/lists/ol-start-roman.html
1800
1801         * rendering/RenderListMarker.cpp:
1802         (WebCore::toRoman): Increase the char array size.
1803
1804 2009-11-19  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1805
1806         Rubber-stamped by Oliver Hunt.
1807
1808         Add translatable strings to cover validationMessage, after
1809         r51172. Already covered by existing test.
1810
1811         * platform/gtk/LocalizedStringsGtk.cpp:
1812         (WebCore::validationMessageValueMissingText):
1813         (WebCore::validationMessageTypeMismatchText):
1814         (WebCore::validationMessagePatternMismatchText):
1815         (WebCore::validationMessageTooLongText):
1816         (WebCore::validationMessageRangeUnderflowText):
1817         (WebCore::validationMessageRangeOverflowText):
1818         (WebCore::validationMessageStepMismatchText):
1819
1820 2009-11-19  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1821
1822         Reviewed by Darin Adler.
1823
1824         Remove HAVE(FLOAT_H) guard
1825         https://bugs.webkit.org/show_bug.cgi?id=31661
1826
1827         WebCore has a dependency on float.h, there is
1828         no need to guard float.h.
1829
1830         No new tests as there is no functional change.
1831
1832         * html/HTMLInputElement.cpp: Remove include directive
1833         for float.h as it is included in MathExtras.h already.
1834
1835 2009-11-19  Simon Fraser  <simon.fraser@apple.com>
1836
1837         Reviewed by Pavel Feldman.
1838
1839         Instrumentation should account for painting in compositing layers
1840         https://bugs.webkit.org/show_bug.cgi?id=31674
1841
1842         Add calls to InspectorTimelineAgent for painting into compositing layers,
1843         which is not accounted for in FrameView::paintContents().
1844
1845         * rendering/RenderLayerBacking.cpp:
1846         (WebCore::RenderLayerBacking::paintIntoLayer):
1847         Avoid fetching the FrameView multiple times.
1848         
1849         (WebCore::inspectorTimelineAgent):
1850         (WebCore::RenderLayerBacking::paintContents):
1851
1852 2009-11-19  Eric Carlson  <eric.carlson@apple.com>
1853
1854         Reviewed by Dan Bernstein.
1855
1856         <rdar://problem/7035231>
1857         Support closed caption in <video> element
1858
1859         Test: media/media-captions.html
1860
1861         * WebCore.base.exp:
1862         * accessibility/AccessibilityMediaControls.cpp:
1863         (WebCore::AccessibilityMediaControl::controlTypeName):
1864             Define ShowClosedCaptionsButton and HideClosedCaptionsButton.
1865
1866         * css/CSSPrimitiveValueMappings.h:
1867         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
1868             Add MediaToggleClosedCaptionsButtonPart.
1869
1870         * css/CSSSelector.cpp:
1871         (WebCore::CSSSelector::extractPseudoType):
1872             Define and match mediaControlsToggleClosedCaptionsButton.
1873
1874         * css/CSSSelector.h:
1875         (WebCore::CSSSelector::):
1876         * css/CSSStyleSelector.cpp:
1877         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
1878             Define and match PseudoMediaControlsToggleClosedCaptions.
1879
1880         * css/CSSValueKeywords.in:
1881             Define and use media-toggle-closed-captions-button.
1882
1883         * css/mediaControls.css:
1884         * css/mediaControlsQuickTime.css:
1885             Add webkit-media-controls-toggle-closed-captions-button.
1886
1887         * html/HTMLMediaElement.cpp:
1888         (WebCore::HTMLMediaElement::HTMLMediaElement): 
1889             Initialize m_closedCaptionsVisible.
1890         (WebCore::HTMLMediaElement::loadInternal): 
1891             Set m_closedCaptionsVisible to false.
1892         (WebCore::HTMLMediaElement::hasClosedCaptions): 
1893         (WebCore::HTMLMediaElement::closedCaptionsVisible): 
1894         (WebCore::HTMLMediaElement::setClosedCaptionsVisible): 
1895             New, captions internal methods.
1896         (WebCore::HTMLMediaElement::setWebkitClosedCaptionsVisible): 
1897         (WebCore::HTMLMediaElement::webkitClosedCaptionsVisible): 
1898         (WebCore::HTMLMediaElement::webkitHasClosedCaptions): 
1899             New, captions DOM API.
1900
1901         * html/HTMLMediaElement.h:
1902         * html/HTMLMediaElement.idl:
1903             Declare methods needed for captions API.
1904
1905         * platform/ThemeTypes.h:
1906             Add MediaToggleClosedCaptionsButtonPart.
1907
1908         * platform/android/LocalizedStringsAndroid.cpp:
1909         (WebCore::localizedMediaControlElementString):
1910         (WebCore::localizedMediaControlElementHelpText):
1911         (WebCore::localizedMediaTimeDescription):
1912             Add empty implmentations.
1913
1914         * platform/graphics/MediaPlayer.cpp:
1915         (WebCore::NullMediaPlayerPrivate::hasClosedCaptions):
1916         (WebCore::NullMediaPlayerPrivate::setClosedCaptionsVisible):
1917             New, empty implementations of media engine closed caption functions.
1918         (WebCore::MediaPlayer::hasClosedCaptions):
1919         (WebCore::MediaPlayer::setClosedCaptionsVisible):
1920             New, call media engine closed caption functions.
1921
1922         * platform/graphics/MediaPlayer.h:
1923         * platform/graphics/MediaPlayerPrivate.h:
1924         (WebCore::MediaPlayerPrivateInterface::hasClosedCaptions):
1925         (WebCore::MediaPlayerPrivateInterface::setClosedCaptionsVisible):
1926             Declare new media engine methods.
1927
1928         * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
1929         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
1930         (WebCore::MediaPlayerPrivate::hasClosedCaptions):
1931         (WebCore::MediaPlayerPrivate::setClosedCaptionsVisible):
1932             New, QTKit implementation of closed caption methods.
1933
1934         * platform/gtk/LocalizedStringsGtk.cpp:
1935         (WebCore::localizedMediaControlElementString):
1936         (WebCore::localizedMediaControlElementHelpText):
1937             Add help text for ShowClosedCaptionsButton and HideClosedCaptionsButton.
1938
1939         * platform/mac/WebCoreSystemInterface.h:
1940         * platform/mac/WebCoreSystemInterface.mm:
1941             Declare and initialize wkQTMovieHasClosedCaptions and wkQTMovieSetShowClosedCaptions.
1942
1943         * rendering/MediaControlElements.cpp:
1944         (WebCore::MediaControlInputElement::MediaControlInputElement):
1945             Deal with MEDIA_CONTROLS_TOGGLE_CLOSED_CAPTIONS_BUTTON.
1946         (WebCore::MediaControlToggleClosedCaptionsButtonElement::MediaControlToggleClosedCaptionsButtonElement):
1947         (WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler):
1948         (WebCore::MediaControlToggleClosedCaptionsButtonElement::updateDisplayType):
1949             New, implement the closed caption toggle button,
1950
1951         * rendering/MediaControlElements.h:
1952             Define MediaShowClosedCaptionsButton and MediaHideClosedCaptionsButton,
1953             declare MediaControlToggleClosedCaptionsButtonElement.
1954
1955         * rendering/RenderMedia.cpp:
1956         (WebCore::RenderMedia::styleDidChange):
1957         (WebCore::RenderMedia::createToggleClosedCaptionsButton):
1958         (WebCore::RenderMedia::createStatusDisplay):
1959         (WebCore::RenderMedia::updateControls):
1960         (WebCore::RenderMedia::forwardEvent):
1961         * rendering/RenderMedia.h:
1962             Deal with m_toggleClosedCaptionsButton.
1963
1964         * rendering/RenderTheme.cpp:
1965         (WebCore::RenderTheme::paint):
1966             Deal with MediaToggleClosedCaptionsButtonPart.
1967
1968         * rendering/RenderTheme.h:
1969         * rendering/RenderThemeMac.h:
1970             Declare paintMediaToggleClosedCaptionsButton.
1971
1972         * rendering/RenderThemeMac.mm:
1973         (WebCore::RenderThemeMac::paintMediaToggleClosedCaptionsButton):
1974             New.
1975         (WebCore::RenderThemeMac::shouldRenderMediaControlPart):
1976             Don't render captions toggle button unless we are using the new theme, the
1977             movie has captions, and the movie is in a <video> element since we currently
1978             rely on QTKit to render the captions.
1979
1980         * rendering/style/RenderStyleConstants.h:
1981             Define MEDIA_CONTROLS_TOGGLE_CLOSED_CAPTIONS_BUTTON.
1982
1983 2009-11-19  Kevin Ollivier  <kevino@theolliviers.com>
1984
1985         wx build fix. Add missing header.
1986
1987         * platform/wx/LocalizedStringsWx.cpp:
1988
1989 2009-11-19  Alexey Proskuryakov  <ap@apple.com>
1990
1991         Reviewed by Darin Adler.
1992
1993         https://bugs.webkit.org/show_bug.cgi?id=31634
1994         Ignore realm for proxy protection spaces
1995
1996         Only affects WebSocket proxy authentication, cannot be tested in DRT.
1997
1998         * platform/network/ProtectionSpace.cpp:
1999         (WebCore::operator==):
2000         * platform/network/ProtectionSpaceHash.h:
2001         (WebCore::ProtectionSpaceHash::hash):
2002
2003 2009-11-19  Olivier Goffart  <ogoffart@trolltech.com>
2004
2005         Reviewed by Simon Hausmann.
2006
2007         [Qt] Normalize signal and slot signatures.
2008
2009         * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
2010         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
2011
2012 2009-11-19  Alexander Pavlov  <apavlov@chromium.org>
2013
2014         Reviewed by Pavel Feldman.
2015
2016         Store cookie domains in the WebInspector object
2017
2018         The cookie domains have been moved from StoragePanel into WebInspector.
2019         Also, the document URLs are now passed inside the WebInspector.addResource()
2020         payload rather than pushed directly from InspectorController.
2021         https://bugs.webkit.org/show_bug.cgi?id=31627
2022
2023         * inspector/InspectorController.cpp:
2024         (WebCore::InspectorController::populateScriptObjects):
2025         (WebCore::InspectorController::didFinishLoading):
2026         * inspector/InspectorFrontend.cpp:
2027         * inspector/InspectorFrontend.h:
2028         * inspector/InspectorResource.cpp:
2029         (WebCore::InspectorResource::createScriptObject):
2030         (WebCore::InspectorResource::updateScriptObject):
2031         * inspector/front-end/StoragePanel.js:
2032         (WebInspector.StoragePanel.prototype.reset):
2033         (WebInspector.StoragePanel.prototype.addCookieDomain):
2034         * inspector/front-end/inspector.js:
2035         (WebInspector.addResource):
2036         (WebInspector.addCookieDomain):
2037         (WebInspector.reset):
2038
2039 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
2040
2041         Reviewed by Darin Adler.
2042
2043         Allow custom memory allocation control for the other part of platform directory in WebCore
2044         https://bugs.webkit.org/show_bug.cgi?id=31585
2045
2046         Inherits the following classes from FastAllocBase because these are
2047         instantiated by 'new':
2048
2049         class RegularExpression    - instantiated at: WebCore/page/Frame.cpp:415
2050         class TransformationMatrix - instantiated at: WebCore/rendering/TransformState.cpp:62
2051         class Path                 - instantiated at: WebCore/html/HTMLAreaElement.cpp:73
2052         class FontPlatformData     - instantiated at: WebCore/platform/graphics/qt/FontCacheQt.cpp:188
2053
2054         Inherits the following classes from Noncopyable because these are
2055         instantiated by 'new' and no need to be copyable:
2056
2057         class Cursors                         - instantiated at: WebCore/platform/qt/CursorQt.cpp:146
2058         class NetworkStateNotifier            - instantiated at: WebCore/platform/network/NetworkStateNotifier.cpp:37
2059         struct CrossThreadResourceRequestData - instantiated at: WebCore/platform/network/ResourceRequestBase.cpp:71
2060
2061         class ImageDecoder - its child class is instantiated at: WebCore/platform/graphics/qt/ImageDecoderQt.cpp:46
2062         class MediaPlayerPrivateInterface - its child class is instantiated at: WebCore/platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:119
2063
2064         * platform/graphics/MediaPlayerPrivate.h:
2065         * platform/graphics/Path.h:
2066         * platform/graphics/qt/FontPlatformData.h:
2067         * platform/graphics/transforms/TransformationMatrix.h:
2068         * platform/image-decoders/ImageDecoder.h:
2069         * platform/network/NetworkStateNotifier.h:
2070         * platform/network/ResourceRequestBase.h:
2071         * platform/qt/CursorQt.cpp:
2072         * platform/text/RegularExpression.h:
2073
2074 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2075
2076         Unreviewed.
2077
2078         [Qt] Build fix for QtWebKit after r51172.
2079
2080         * platform/qt/Localizations.cpp:
2081         (WebCore::validationMessageValueMissingText):
2082         (WebCore::validationMessageTypeMismatchText):
2083         (WebCore::validationMessagePatternMismatchText):
2084         (WebCore::validationMessageTooLongText):
2085         (WebCore::validationMessageRangeUnderflowText):
2086         (WebCore::validationMessageRangeOverflowText):
2087         (WebCore::validationMessageStepMismatchText):
2088
2089 2009-11-18  Dan Bernstein  <mitz@apple.com>
2090
2091         Reviewed by Simon Fraser.
2092
2093         Fixed <rdar://problem/7398987> Assertion failure in
2094         RenderLayer::updateClipRects when a plug-in’s enclosing layer is
2095         enclosed by a transformed layer
2096
2097         Tests: fast/layers/clip-rects-transformed-2.html
2098                fast/layers/clip-rects-transformed.html
2099
2100         * rendering/RenderLayer.cpp:
2101         (WebCore::RenderLayer::clippingRoot): Added. Finds the nearest ancestor
2102         that is either transformed or composited. During painting and hit
2103         testing, when a transformed or composited layer is hit, it becomes the
2104         new root layer, which ultimately gets passed to calculateRects().
2105         (WebCore::RenderLayer::childrenClipRect): Pass the clipping root as the
2106         root layer to calculateRects(), and return the bounding box of the
2107         transformed rectangle.
2108         (WebCore::RenderLayer::selfClipRect): Ditto.
2109         * rendering/RenderLayer.h:
2110
2111 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2112
2113         Reviewed by Kenneth Rohde Christiansen.
2114
2115         [Qt] Remove support for Qt v4.3 or older versions
2116         https://bugs.webkit.org/show_bug.cgi?id=29469
2117
2118         No new tests as there is no change if compiled with 
2119         Qt v4.4 or later version.
2120
2121         * WebCore.pro:
2122         * dom/XMLTokenizerQt.cpp:
2123         (WebCore::EntityResolver::resolveUndeclaredEntity):
2124         (WebCore::XMLTokenizer::XMLTokenizer):
2125         (WebCore::XMLTokenizer::~XMLTokenizer):
2126         (WebCore::XMLTokenizer::doWrite):
2127         (WebCore::XMLTokenizer::startDocument):
2128         (WebCore::XMLTokenizer::parseDtd):
2129         * platform/graphics/qt/FontQt.cpp:
2130         * platform/graphics/qt/FontQt43.cpp: Removed.
2131         * platform/graphics/qt/ImageQt.cpp:
2132         * platform/network/ResourceHandleInternal.h:
2133         * platform/network/qt/QNetworkReplyHandler.cpp:
2134         * platform/network/qt/QNetworkReplyHandler.h:
2135         * platform/network/qt/ResourceHandleQt.cpp:
2136         (WebCore::ResourceHandle::start):
2137         (WebCore::ResourceHandle::cancel):
2138         (WebCore::ResourceHandle::loadResourceSynchronously):
2139         (WebCore::ResourceHandle::setDefersLoading):
2140         * platform/network/qt/ResourceRequest.h:
2141         * platform/network/qt/ResourceRequestQt.cpp:
2142         * platform/qt/ClipboardQt.cpp:
2143         (WebCore::ClipboardQt::clearData):
2144         * platform/qt/CookieJarQt.cpp:
2145         (WebCore::cookieJar):
2146         (WebCore::setCookies):
2147         (WebCore::cookies):
2148         (WebCore::cookiesEnabled):
2149         * platform/qt/PlatformKeyboardEventQt.cpp:
2150         (WebCore::keyIdentifierForQtKeyCode):
2151         (WebCore::windowsKeyCodeForKeyEvent):
2152         * platform/text/qt/TextBoundaries.cpp:
2153         * platform/text/qt/TextBreakIteratorQt.cpp:
2154         * plugins/qt/PluginDataQt.cpp:
2155         (WebCore::PluginData::initPlugins):
2156
2157 2009-11-18  Michelangelo De Simone  <micdesim@gmail.com>
2158
2159         Reviewed by Darin Adler.
2160
2161         Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
2162         Support for validationMessage attribute, as per HTML5 specs.
2163
2164         Test: fast/forms/validationMessage.html
2165
2166         * html/HTMLButtonElement.idl: validationMessage attribute
2167         * html/HTMLFieldSetElement.idl: validationMessage attribute
2168         * html/HTMLFormControlElement.cpp:
2169         * html/HTMLFormControlElement.h:
2170         * html/HTMLInputElement.idl: validationMessage attribute
2171         * html/HTMLSelectElement.idl: validationMessage attribute
2172         * html/HTMLTextAreaElement.idl: validationMessage attribute
2173         * html/ValidityState.cpp: new method to retrieve pertinent localized text
2174         * html/ValidityState.h:
2175         * page/mac/WebCoreViewFactory.h:
2176         * platform/LocalizedStrings.h:
2177         * platform/android/LocalizedStringsAndroid.cpp:
2178         * platform/gtk/LocalizedStringsGtk.cpp:
2179         * platform/haiku/LocalizedStringsHaiku.cpp:
2180         * platform/mac/LocalizedStringsMac.mm:
2181         * platform/wx/LocalizedStringsWx.cpp:
2182
2183 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2184
2185         Unreviewed.
2186
2187         Fix a typo. Remove the trailing semicolon
2188         from an include directive after r51137.
2189
2190         No new tests as there is no functional change.
2191
2192         * platform/qt/QWebPageClient.h:
2193
2194 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2195
2196         Unreviewed.
2197
2198         [Qt] Build fix for QtWebKit after r51159.
2199
2200         Include float.h for DBL_MANT_DIG. Not sure why this
2201         is not a problem for other ports.
2202
2203         * html/HTMLInputElement.cpp:
2204
2205 2009-11-19  Roland Steiner  <rolandsteiner@chromium.org>
2206
2207         Reviewed by Darin Adler.
2208
2209         Bug 31574 -  Crashing bug when removing <ruby> element
2210         (https://bugs.webkit.org/show_bug.cgi?id=31574)
2211
2212         Cause of the bug:
2213         1.) RenderBlock::destroy() of the RenderRubyRun called destroyLeftoverChildren()
2214         2.) that called destroy() of the RenderRubyBase(), which in RenderObject::destroy() calls remove()
2215         3.) remove() is being redirected as parent()->removeChild() in RenderObject.h
2216         4.) this triggers the special handling of child removal in RenderRubyRun that
2217             causes it to destroy itself
2218         5.) On returning from all this the renderer crashes when accessing a member
2219             or virtual function on this now illegal object.
2220
2221         I therefore added a flag that tracks if the ruby run is being destroyed.
2222         If so, avoid doing the special handling in removeChild that caused this.
2223         It's not the most elegant solution, but the easiest to implement without
2224         touching unrelated code. Also, it's self-documenting.
2225
2226         Test: fast/ruby/ruby-remove.html
2227
2228         * rendering/RenderRubyRun.cpp:
2229         (WebCore::RenderRubyRun::RenderRubyRun):
2230         (WebCore::RenderRubyRun::destroy):
2231         (WebCore::RenderRubyRun::removeChild):
2232         * rendering/RenderRubyRun.h:
2233
2234 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2235
2236         Reviewed by Kenneth Rohde Christiansen.
2237
2238         [Qt] Remove WTF_USE_JAVASCRIPTCORE_BINDINGS as it is no longer used
2239         https://bugs.webkit.org/show_bug.cgi?id=31643
2240
2241         No new tests as there is no functional change.
2242
2243         * WebCore.pro:
2244
2245 2009-11-18  Yong Li  <yong.li@torchmobile.com>
2246
2247         Reviewed by Eric Seidel.
2248
2249         Implement TextBoundaries for WINCE port.
2250         https://bugs.webkit.org/show_bug.cgi?id=27371
2251
2252         * platform/text/wince/TextBoundariesWince.cpp: Added.
2253
2254 2009-11-18  Yong Li  <yong.li@torchmobile.com>
2255
2256         Reviewed by Eric Seidel.
2257
2258         Implement TextBreakIterator for WINCE port.
2259         https://bugs.webkit.org/show_bug.cgi?id=27371
2260
2261         * platform/text/wince/TextBreakIteratorWince.cpp: Added.
2262
2263 2009-11-18  Kent Tamura  <tkent@chromium.org>
2264
2265         Reviewed by Darin Adler.
2266
2267         Add support for ValidityState.typeMismatch for the following INPUT types:
2268           date datetime datetime-local month time week
2269         https://bugs.webkit.org/show_bug.cgi?id=31342
2270
2271         Tests: fast/forms/ValidityState-typeMismatch-date.html
2272                fast/forms/ValidityState-typeMismatch-datetime.html
2273                fast/forms/ValidityState-typeMismatch-datetimelocal.html
2274                fast/forms/ValidityState-typeMismatch-month.html
2275                fast/forms/ValidityState-typeMismatch-time.html
2276                fast/forms/ValidityState-typeMismatch-week.html
2277
2278         * html/HTMLInputElement.cpp:
2279         (WebCore::HTMLInputElement::formStringToISODateTime): Check the type
2280           validity of the specified type and string using the ISODateTime class.
2281         * html/HTMLInputElement.h:
2282         * html/ValidityState.cpp:
2283         (WebCore::ValidityState::typeMismatch): Check the type validity
2284           for date, datetime, datetime-local, month, time and week with
2285           HTMLInputElemtn::formStringToISODateTime()
2286
2287 2009-11-18  Maciej Stachowiak  <mjs@apple.com>
2288
2289         Reviewed by Oliver Hunt.
2290
2291         Fix REGRESSION (r47022): Performance of DocumentFragment.appendChild is 1000x slower sometimes
2292         https://bugs.webkit.org/show_bug.cgi?id=31237
2293         
2294         Also speeds up Dromaeo DOM Core tests by 1.31x.
2295
2296         * bindings/js/JSNodeCustom.cpp:
2297         (WebCore::JSNode::markChildren): Change marking algorithm to avoid O(N^2) behavior. The subtree
2298         mark bit was no longer effective; instead I changed things so only a node that has no ancestors
2299         with wrappers would do marking; there should be only one in the typical case (the root of the
2300         detached subtree).
2301         * dom/Node.cpp:
2302         (WebCore::Node::Node): Remove now useless m_inSubtreeMark bit and related functions.
2303         * dom/Node.h: ditto
2304
2305 2009-11-18  Darin Adler  <darin@apple.com>
2306
2307         Reviewed by Sam Weinig.
2308
2309         Get rid of the redundant strokeType and fillType data members on
2310         a GraphicsContext as well as the FillOrStrokeType enum. Use
2311         null pointers instead.
2312
2313         * platform/graphics/GraphicsContext.cpp:
2314         (WebCore::GraphicsContext::setStrokeColor): Null out the pattern
2315         and gradient.
2316         (WebCore::GraphicsContext::setFillColor): Ditto.
2317         (WebCore::GraphicsContext::setStrokePattern): Null out the graident.
2318         (WebCore::GraphicsContext::setFillPattern): Ditto.
2319         (WebCore::GraphicsContext::setStrokeGradient): Null out the pattern.
2320         (WebCore::GraphicsContext::setFillGradient): Ditto.
2321
2322         * platform/graphics/GraphicsContextPrivate.h: Remove all that stuff.
2323
2324         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2325         (WebCore::setPlatformFill): Use null checks on fillPattern and
2326         fillGraident instead of a switch statement.
2327         (WebCore::setPlatformStroke): Ditto.
2328
2329         * platform/graphics/cg/GraphicsContextCG.cpp:
2330         (WebCore::GraphicsContext::applyStrokePattern): Removed unneeded get.
2331         (WebCore::GraphicsContext::applyFillPattern): Ditto.
2332         (WebCore::calculateDrawingMode): Use fillPattern and strokePattern
2333         to see if there is a pattern instead of fillType and strokeType.
2334         (WebCore::GraphicsContext::drawPath): Use fillGradient, strokeGradient,
2335         fillPattern, and strokePattern instead of fillType and strokeType.
2336         (WebCore::GraphicsContext::fillPath): Added FIXME about color space that
2337         is used in the pattern and gradient case probably erroneously. Moved
2338         gradient code inside an if statement. Streamlined pattern code and
2339         use an if statement. No switch any more.
2340         (WebCore::GraphicsContext::strokePath): Ditto.
2341         (WebCore::GraphicsContext::fillRect): Ditto.
2342         (WebCore::GraphicsContext::strokeRect): Ditto.
2343
2344         * platform/graphics/qt/GraphicsContextQt.cpp:
2345         (WebCore::GraphicsContext::fillPath): Use null checks on fillPattern and
2346         fillGraident instead of a switch statement.
2347         (WebCore::GraphicsContext::strokePath): Ditto.
2348         (WebCore::GraphicsContext::fillRect): Ditto.
2349
2350         * platform/graphics/wince/GraphicsContextWince.cpp:
2351         (WebCore::GraphicsContext::fillPath): Removed unneeded check of fillType.
2352         (WebCore::GraphicsContext::fillRect): Ditto.
2353
2354 2009-11-18  Kent Tamura  <tkent@chromium.org>
2355
2356         Reviewed by Darin Adler.
2357
2358         Support for step attribute and ValidityStae.stepMismatch for
2359         type=number and range.  stepMismatch will be false if the
2360         difference between the current value and a multiple of the step
2361         value is very small.
2362
2363         Change the behavior of RenderSlider so that it always has a value
2364         rounded to the step attribute value.
2365
2366         https://bugs.webkit.org/show_bug.cgi?id=31331
2367
2368         Tests: fast/forms/ValidityState-stepMismatch-number.html
2369                fast/forms/ValidityState-stepMismatch-range.html
2370                fast/forms/ValidityState-stepMismatch-unsupported.html
2371                fast/forms/input-step.html
2372
2373         * html/HTMLAttributeNames.in: Add "step".
2374         * html/HTMLInputElement.cpp:
2375         (WebCore::HTMLInputElement::stepMismatch):
2376         (WebCore::HTMLInputElement::getStepParameters):
2377         (WebCore::HTMLInputElement::getAllowedValueStep):
2378         * html/HTMLInputElement.h:
2379         * html/HTMLInputElement.idl: Add "step".
2380         * html/ValidityState.cpp:
2381         (WebCore::ValidityState::stepMismatch): Forward to HTMLInputElement::stepMismatch().
2382         * html/ValidityState.h:
2383         * rendering/RenderSlider.cpp:
2384         (WebCore::SliderRange::SliderRange):
2385         (WebCore::SliderRange::clampValue):
2386
2387 2009-11-18  Dmitry Titov  <dimich@chromium.org>
2388
2389         Reviewed by Darin Adler.
2390
2391         Need to ASSERT(isMainThread()) in ThreadShared methods.
2392         https://bugs.webkit.org/show_bug.cgi?id=31637
2393
2394         Added ASSERT(IsMainThread()) to all following methods:
2395         * platform/TreeShared.h:
2396         (WebCore::TreeShared::TreeShared):
2397         (WebCore::TreeShared::~TreeShared):
2398         (WebCore::TreeShared::ref):
2399         (WebCore::TreeShared::deref):
2400         (WebCore::TreeShared::setParent):
2401         (WebCore::TreeShared::parent):
2402
2403 2009-11-18  Girish Ramakrishnan  <girish@forwardbias.in>
2404
2405         Reviewed by Eric Seidel.
2406
2407         Add plugin visibility manual test
2408
2409         https://bugs.webkit.org/show_bug.cgi?id=31542
2410
2411         * manual-tests/plugins/windowed.html:
2412         * manual-tests/plugins/windowless.html:
2413
2414 2009-11-18  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
2415
2416         Reviewed by Pavel Feldman.
2417
2418         Web Inspector - remember last script displayed in Scripts panel
2419         https://bugs.webkit.org/show_bug.cgi?id=27552
2420
2421         Manual test added
2422         
2423         * inspector/front-end/ScriptsPanel.js:
2424         (WebInspector.ScriptsPanel.prototype.showScript):
2425         (WebInspector.ScriptsPanel.prototype.showResource):
2426         (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
2427         (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
2428         (WebInspector.ScriptsPanel.prototype._callFrameSelected):
2429         (WebInspector.ScriptsPanel.prototype._goBack):
2430         (WebInspector.ScriptsPanel.prototype._goForward):
2431         * manual-tests/inspector/remember-last-script.html: Added.
2432
2433 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
2434
2435         Reviewed by Dimitri Glazkov.
2436
2437         Win chromium is slow to draw transparent texts
2438         https://bugs.webkit.org/show_bug.cgi?id=31258
2439
2440         Create bounded transparency layers instead of just clipping.
2441
2442         No new tests because this is just a performance improvement.
2443
2444         * platform/graphics/chromium/FontChromiumWin.cpp:
2445         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
2446
2447 2009-11-18  Shu Chang  <Chang.Shu@nokia.com>
2448
2449         Reviewed by Eric Seidel.
2450
2451         [Qt] Add support for displaying deleteButton.
2452         https://bugs.webkit.org/show_bug.cgi?id=31560
2453
2454         Test: LayoutTests/editing/deleting/5408255.html
2455
2456         * WebCore.qrc:
2457         * platform/graphics/qt/ImageQt.cpp:
2458         (loadResourcePixmap):
2459
2460 2009-11-18  Mikhail Naganov  <mnaganov@chromium.org>
2461
2462         Reviewed by Eric Seidel.
2463
2464         Fix Qt build without JavaScript debugger.
2465
2466         https://bugs.webkit.org/show_bug.cgi?id=31575
2467
2468         * page/Console.idl:
2469
2470 2009-11-18  Daniel Bates  <dbates@webkit.org>
2471
2472         Reviewed by Dave Hyatt.
2473
2474         https://bugs.webkit.org/show_bug.cgi?id=24971
2475         And
2476         <rdar://problem/7138265>
2477
2478         Fixes an issue where setting the height of a table row programmatically
2479         (via JavaScript) causes the table to be improperly rendered because the
2480         height of each row in the table is not recalculated with respect to the
2481         CSS height property.
2482
2483         In particular, programmatically setting the height of some table row causes
2484         the rows of that table to be rendered with a height equal to the minimum
2485         height required by the cells in that row, regardless of any specified cell
2486         heights. Instead, when RenderTableSection::recalcCells is called, the height
2487         of each row should be set to the CSS height property just as we do in
2488         RenderTableSection::addChild.
2489
2490         Test: fast/table/row-height-recalc2.html
2491
2492         * rendering/RenderTableSection.cpp:
2493         (WebCore::setRowHeightToRowStyleHeightIfNotRelative): Added.
2494         (WebCore::RenderTableSection::addChild): Moved code that set row height into
2495         method WebCore::setRowHeightToRowStyleHeightIfNotRelative.
2496         (WebCore::RenderTableSection::recalcCells): Modified to call
2497         WebCore::setRowHeightToRowStyleHeightIfNotRelative.
2498
2499 2009-11-18  Zoltan Horvath  <zoltan@webkit.org>
2500
2501         Reviewed by Darin Adler.
2502
2503         Allow custom memory allocation control for the part of platform directory in WebCore
2504         https://bugs.webkit.org/show_bug.cgi?id=31473
2505
2506         Inherits the following classes from FastAllocBase because these are
2507         instantiated by 'new':
2508
2509         class  AnimationList         - instantiated at WebCore/rendering/style/StyleRareNonInheritedData.cpp:85
2510         class  Color                 - instantiated at WebCore/rendering/RenderTheme.cpp:48
2511         struct Length                - instantiated at WebCore/platform/Length.cpp:103
2512         class  PlatformKeyboardEvent - instantiated at WebCore/dom/KeyboardEvent.cpp:63
2513         class  ContextMenuItem       - instantiated at WebCore/platform/ContextMenu.cpp:70
2514         class  DeprecatedPtrList     - instantiated at WebCore/rendering/RenderBlock.cpp:2284
2515
2516         Inherits the following classes from Noncopyable because these are
2517         instantiated by 'new' and no need to be copyable:
2518
2519         class  GraphicsContextPrivate - instantiated at WebCore/platform/graphics/GraphicsContext.cpp:78
2520         class  FontCache              - instantiated at WebCore/platform/graphics/qt/FontCacheQt.cpp:43
2521         struct MediaPlayerFactory     - instantiated at WebCore/platform/graphics/MediaPlayer.cpp:163
2522         class  DeprecatedPtrListNode  - instantiated at WebCore/platform/DeprecatedPtrListImpl.cpp:53
2523
2524         * platform/ContextMenuItem.h:
2525         * platform/DeprecatedPtrList.h:
2526         * platform/DeprecatedPtrListImpl.cpp:
2527         * platform/Length.h:
2528         * platform/PlatformKeyboardEvent.h:
2529         * platform/animation/AnimationList.h:
2530         * platform/graphics/Color.h:
2531         * platform/graphics/FontCache.h:
2532         * platform/graphics/GraphicsContextPrivate.h:
2533         * platform/graphics/MediaPlayer.cpp:
2534
2535 2009-11-18  Daniel Bates  <dbates@webkit.org>
2536
2537         Reviewed by Darin Adler.
2538
2539         https://bugs.webkit.org/show_bug.cgi?id=31186
2540
2541         Renames RenderTextControl::m_edited and RenderTextControl::m_userEdited to
2542         m_wasChangedSinceLastChangeEvent and m_lastChangeWasUserEdit, respectively.
2543         These are more descriptive names so as to clear an ambiguity surrounding
2544         their usage. Also, renames associated setters and getters so that they
2545         coincide with the renamed fields.
2546
2547         No functionality was changed. So, no tests were included.
2548
2549         * bindings/objc/DOMHTML.mm:
2550         (-[DOMHTMLInputElement _isEdited]):
2551         (-[DOMHTMLTextAreaElement _isEdited]):
2552         * dom/Document.cpp:
2553         (WebCore::Document::setFocusedNode):
2554         * html/HTMLInputElement.cpp:
2555         (WebCore::HTMLInputElement::defaultEventHandler):
2556         * rendering/RenderTextControl.cpp:
2557         (WebCore::RenderTextControl::RenderTextControl):
2558         (WebCore::RenderTextControl::setInnerTextValue):
2559         (WebCore::RenderTextControl::setLastChangeWasUserEdit): Formerly named setUserEdited.
2560         (WebCore::RenderTextControl::subtreeHasChanged):
2561         * rendering/RenderTextControl.h:
2562         (WebCore::RenderTextControl::wasChangedSinceLastChangeEvent): Formerly named isEdited.
2563         (WebCore::RenderTextControl::setChangedSinceLastChangeEvent): Formerly named setEdited.
2564         (WebCore::RenderTextControl::lastChangeWasUserEdit): Formerly named setUserEdited.
2565         * rendering/RenderTextControlSingleLine.cpp:
2566         (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
2567         * wml/WMLInputElement.cpp:
2568         (WebCore::WMLInputElement::defaultEventHandler):
2569
2570 2009-11-18  Tony Chang  <tony@chromium.org>
2571
2572         Reviewed by Adam Barth.
2573
2574         Remove V8CanvasPixelArrayCustom.cpp because it is no longer used by V8.
2575         https://bugs.webkit.org/show_bug.cgi?id=31499
2576
2577         No new tests, just a build cleanup.
2578
2579         * WebCore.gypi:
2580         * bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Removed.
2581         * bindings/v8/custom/V8CustomBinding.h:
2582
2583 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
2584
2585         Reviewed by Kevin Ollivier.
2586
2587         Enable wx plugin support using the Windows implementation as a base.
2588         
2589         https://bugs.webkit.org/show_bug.cgi?id=31636
2590
2591         * platform/graphics/GraphicsContext.h:
2592         (WebCore::GraphicsContext::inTransparencyLayer):
2593         * platform/graphics/wx/GraphicsContextWx.cpp:
2594         (WebCore::GraphicsContext::getWindowsContext):
2595         (WebCore::GraphicsContext::releaseWindowsContext):
2596         * platform/wx/FileSystemWx.cpp:
2597         (WebCore::unloadModule):
2598         (WebCore::listDirectory):
2599         * plugins/PluginDatabase.cpp:
2600         * plugins/PluginView.cpp:
2601         (WebCore::PluginView::stop):
2602         (WebCore::PluginView::PluginView):
2603         * plugins/PluginView.h:
2604         * plugins/win/PluginViewWin.cpp:
2605         (windowHandleForPageClient):
2606         (WebCore::PluginView::handleMouseEvent):
2607         (WebCore::PluginView::platformStart):
2608         (WebCore::PluginView::snapshot):
2609         * wscript:
2610
2611 2009-11-18  Andrei Popescu  <andreip@google.com>
2612
2613         Reviewed by Dimitri Glazkov.
2614
2615         [Android] Add shared timer and sound utilities to platform/android
2616         https://bugs.webkit.org/show_bug.cgi?id=31584
2617
2618         No new tests required, this is platform specific code.
2619
2620         * platform/android/SharedTimerAndroid.cpp: Added.
2621         (WebCore::setSharedTimerFiredFunction):
2622         (WebCore::setSharedTimerFireTime):
2623         (WebCore::stopSharedTimer):
2624         * platform/android/SoundAndroid.cpp: Added.
2625         (WebCore::systemBeep):
2626
2627 2009-11-18  Mikhail Naganov  <mnaganov@chromium.org>
2628
2629         Reviewed by Timothy Hatcher.
2630
2631         Fix profile tree nodes loss after focus / restore actions.
2632
2633         Focusing on a node is currently implemented via nodes reattaching
2634         with some caching involved. It seems that not all code was updated
2635         to handle this scenario correctly.
2636
2637         https://bugs.webkit.org/show_bug.cgi?id=31553
2638
2639         * inspector/front-end/BottomUpProfileDataGridTree.js:
2640         (WebInspector.BottomUpProfileDataGridNode):
2641         (WebInspector.BottomUpProfileDataGridNode.prototype._restore):
2642         (WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate):
2643         (WebInspector.BottomUpProfileDataGridNode.prototype._willHaveChildren):
2644         * inspector/front-end/DataGrid.js:
2645         (WebInspector.DataGrid.prototype.insertChild):
2646         (WebInspector.DataGridNode.prototype._detach):
2647         (WebInspector.DataGridNode.prototype.savePosition):
2648         (WebInspector.DataGridNode.prototype.restorePosition):
2649         * inspector/front-end/TopDownProfileDataGridTree.js:
2650         (WebInspector.TopDownProfileDataGridTree.prototype.focus):
2651         (WebInspector.TopDownProfileDataGridTree.prototype.restore):
2652
2653 2009-11-18  Carol Szabo  <carol.szabo@nokia.com>
2654
2655         Reviewed by Kenneth Rohde Christiansen.
2656
2657         [Qt] QWebPageClient.h needs in some cases QCursor, but it does not
2658         include it 
2659         https://bugs.webkit.org/show_bug.cgi?id=31527
2660
2661         No new tests as this is just a coding style fix that affects the 
2662         build of some not yet submitted patches (i.e. for bug 30173).
2663
2664         * platform/qt/QWebPageClient.h:
2665
2666 2009-11-18  Nicolas Roard   <nicolas@roard.com>
2667
2668         Reviewed by Dimitri Glazkov.
2669
2670         InspectorTimelineAgent.h should be guarded by ENABLE(INSPECTOR)
2671         https://bugs.webkit.org/show_bug.cgi?id=31504
2672
2673         * inspector/InspectorTimelineAgent.h:Added the guard.
2674
2675 2009-11-18  Jens Alfke  <snej@chromium.org>
2676
2677         Build fix to my previous checkin, for Windows Chromium
2678
2679         * svg/SVGAnimatedProperty.h:
2680         (WebCore::PropertySynchronizer::synchronize): Fix implicit-conversion error on AtomicString.
2681
2682 2009-11-18  Joseph Pecoraro  <joepeck@webkit.org>
2683
2684         Reviewed by Pavel Feldman.
2685
2686         Web Inspector: Directly Access <head> Instead of Searching for It
2687         https://bugs.webkit.org/show_bug.cgi?id=31641
2688         
2689         Changed old access of the head element (document.getElementsByTagName)
2690         to just use the document.head accessor.
2691
2692         * inspector/front-end/FontView.js:
2693         (WebInspector.FontView):
2694         * inspector/front-end/InjectedScript.js:
2695         (InjectedScript.addStyleSelector):
2696         * inspector/front-end/SourceFrame.js:
2697         (WebInspector.SourceFrame.prototype._loaded):
2698         * inspector/front-end/inspector.js:
2699         (windowLoaded):
2700
2701 2009-11-18  Sam Weinig  <sam@webkit.org>
2702
2703         Reviewed by Anders Carlsson.
2704
2705         Fix two Geolocation assertions.
2706
2707         * page/Chrome.cpp:
2708         (WebCore::Chrome::requestGeolocationPermissionForFrame): No need to use PageGroupLoadDeferrer since this
2709         is not called from JS. 
2710         * page/Geolocation.cpp:
2711         (WebCore::Geolocation::Watchers::set): The PassRefPtr was getting nulled out, so we need to put it in
2712         a RefPtr first.
2713
2714 2009-11-18  Alexey Proskuryakov  <ap@apple.com>
2715
2716         Case sensitive file system build fix.
2717
2718         * platform/network/Credential.h: It's not WTF, just wtf.
2719
2720 2009-11-18  Aaron Golden  <agolden@apple.com>
2721
2722         Reviewed by Alexey Proskuryakov.
2723
2724         Add support for certificates to WebCore::Credential so we can convert between NSURLCredential
2725         objects and WebCore::Credential objects without losing certificate information.
2726
2727         * platform/network/Credential.cpp:
2728         (WebCore::Credential::Credential):  Adding a constructor that takes an identity argument and a certificate chain argument
2729         (WebCore::Credential::isEmpty):  Modifying isEmpty to support certificate based credentials (which don't have a username or password)
2730         (WebCore::Credential::identity): Accessor for the m_identity property
2731         (WebCore::Credential::certificates): Accessor for the m_certificates property
2732         (WebCore::Credential::type):  Accessor for the m_type property
2733         (WebCore::operator==):  Modifying == to compare the identity and certificate chains of certificate based credentials.
2734         * platform/network/Credential.h:  Adding new fields to WebCore::Credential to support certificate based credentials.
2735         * platform/network/mac/AuthenticationMac.mm:
2736         (WebCore::mac):  Modifying the mac() conversion method to correctly convert certificate based WebCore::Credential objects.
2737         (WebCore::core):  Modifying the core() conversion method to correctly convert certificate based NSURLCredential objects.
2738
2739 2009-11-18  Dmitry Titov  <dimich@chromium.org>
2740
2741         Reviewed by Eric Seidel.
2742
2743         Reverting r50919 that has introduced a non-thread-safe refcounting in ScriptExecutionContext::postTaskToMainThread.
2744         https://bugs.webkit.org/show_bug.cgi?id=31615
2745
2746         * dom/Document.cpp:
2747         (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
2748         (WebCore::ScriptExecutionContextTaskTimer::fired):
2749         (WebCore::PerformTaskContext::PerformTaskContext):
2750         (WebCore::performTask):
2751         (WebCore::Document::postTask):
2752         * dom/ScriptExecutionContext.cpp:
2753         * dom/ScriptExecutionContext.h:
2754
2755 2009-11-18  Jens Alfke  <snej@chromium.org>
2756
2757         Reviewed by Darin Adler.
2758
2759         Eliminate unnecessary String-->AtomicString conversions from generated V8 bindings,
2760         by causing the right v8-to-WebCore conversion function to be called for every parameter.
2761         This no longer requires any IDL metadata, so I've removed the [HintAtomic] annotations.
2762         To enforce correctness, I added a mode that disables implicit
2763         String-->AtomicString conversions while compiling the generated bindings.
2764         https://bugs.webkit.org/show_bug.cgi?id=31168
2765
2766         * bindings/scripts/CodeGeneratorV8.pm:  Generate usage of V8Parameter class.
2767         * bindings/v8/DerivedSourcesAllInOne.cpp:  Enable NO_IMPLICIT_ATOMICSTRING.
2768         * bindings/v8/V8Binding.h:  Add V8Parameter class.
2769         * css/WebKitCSSKeyframesRule.h:  Make AtomicString conversions explicit.
2770         * dom/Document.idl:  Remove obsolete [HintAtomic] annotation.
2771         * platform/text/AtomicString.h:  Added NO_IMPLICIT_ATOMICSTRING option.
2772         * svg/SVGAnimatedTemplate.h:  Change some return types to String to avoid implicit conversion.
2773         * svg/SVGAnimatedProperty.h: Adapt to changed return types in SVGAnimatedTemplate.
2774
2775 2009-11-18  Darin Adler  <darin@apple.com>
2776
2777         Reviewed by Dan Bernstein.
2778
2779         Move FillOrStrokeType out of public header.
2780
2781         * platform/graphics/GraphicsContext.h: Updated copyright date to cover
2782         some years we published Apple changes, sorted forward declarations,
2783         removed FillOrStrokeType enum.
2784         * platform/graphics/GraphicsContextPrivate.h: Updated copyright date
2785         to cover some years we published Apple changes, sorted includes,
2786         moved FillOrStrokeType enum here.
2787
2788 2009-11-18  Chris Marrin  <cmarrin@apple.com>
2789
2790         Reviewed by Simon Fraser.
2791
2792         Add Settings for WebKitShowDebugBorders and WebKitShowRepaintCounter
2793         https://bugs.webkit.org/show_bug.cgi?id=31601
2794
2795         These are used to debug accelerated compositing layers. I removed
2796         the platform specific code from GraphicsLayerCA.mm and added calls
2797         to GraphicsLayerClient to get it from the higher levels. The values 
2798         now get cached in RenderLayerCompositing and are queried from there
2799         by RenderLayerBacking (which implements the GraphicsLayerClient interface).
2800
2801         * WebCore.base.exp:
2802         * page/FrameView.cpp:
2803         (WebCore::FrameView::updateCompositingLayers):
2804         * page/Settings.cpp:
2805         (WebCore::Settings::Settings):
2806         (WebCore::Settings::setShowDebugBorders):
2807         (WebCore::Settings::setShowRepaintCounter):
2808         * page/Settings.h:
2809         (WebCore::Settings::showDebugBorders):
2810         (WebCore::Settings::showRepaintCounter):
2811         * platform/graphics/GraphicsLayer.h:
2812         (WebCore::GraphicsLayer::showDebugBorders):
2813         (WebCore::GraphicsLayer::showRepaintCounter):
2814         * platform/graphics/GraphicsLayerClient.h:
2815         * platform/graphics/mac/GraphicsLayerCA.mm:
2816         * rendering/RenderLayerBacking.cpp:
2817         (WebCore::RenderLayerBacking::showDebugBorders):
2818         (WebCore::RenderLayerBacking::showRepaintCounter):
2819         * rendering/RenderLayerBacking.h:
2820         * rendering/RenderLayerCompositor.cpp:
2821         (WebCore::RenderLayerCompositor::RenderLayerCompositor):
2822         (WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
2823         * rendering/RenderLayerCompositor.h:
2824         (WebCore::RenderLayerCompositor::showDebugBorders):
2825         (WebCore::RenderLayerCompositor::showRepaintCounter):
2826
2827 2009-11-18  Pavel Feldman  <pfeldman@chromium.org>
2828
2829         Reviewed by Timothy Hatcher.
2830
2831         Web Inspector: Get rid of metrics and properties sidebars'
2832         flickering.
2833
2834         https://bugs.webkit.org/show_bug.cgi?id=31629
2835
2836         * inspector/front-end/MetricsSidebarPane.js:
2837         * inspector/front-end/PropertiesSidebarPane.js:
2838
2839 2009-11-17  Brian Weinstein  <bweinstein@apple.com>
2840
2841         Reviewed by Pavel Feldman.
2842
2843         Fixes <http://webkit.org/b/31606>.
2844         Web Inspector: Enter/Return key should enter edit mode for Editable Fields.
2845         
2846         This implements Enter starting editing mode in an editable DataGrid. If the
2847         DataGrid is editable and the user hits return, startEditing the first child
2848         of the selected node. Also refactored some editing functions to take an 
2849         event target instead of the event itself, because the functions only needed
2850         the target. Lastly, added had return in editing mode stop propogation, because
2851         when enter was hit to confirm text, it would propagate back to the datagrid
2852         and try to start editing again.
2853
2854         * inspector/front-end/DataGrid.js:
2855         (WebInspector.DataGrid.prototype._ondblclick):
2856         (WebInspector.DataGrid.prototype._startEditing):
2857         (WebInspector.DataGrid.prototype.handleKeyEvent):
2858         (WebInspector.DataGrid.prototype.dataGridNodeFromEvent):
2859         (WebInspector.DataGrid.prototype._mouseDownInDataTable):
2860         (WebInspector.DataGrid.prototype._clickInDataTable):
2861         * inspector/front-end/inspector.js:
2862         (WebInspector.startEditing.element.handleKeyEvent):
2863         (WebInspector.startEditing):
2864
2865 2009-11-18  Ben Murdoch  <benm@google.com>
2866
2867         Reviewed by Darin Adler.
2868
2869         HTMLAnchorElement is inconsistent with its internal handling of the value returned for the href attribute.
2870         https://bugs.webkit.org/show_bug.cgi?id=31593
2871
2872         Test: fast/dom/HTMLAnchorElement/set-href-attribute-whitespace.html
2873
2874         * html/HTMLAnchorElement.cpp:
2875         (WebCore::HTMLAnchorElement::href): Add call to deprecatedParseURL.
2876
2877 2009-11-18  Pavel Feldman  <pfeldman@chromium.org>
2878
2879         Not reviewed. Touch InspectorController so that frontend
2880         JS files are deployed on Windows.
2881
2882         * inspector/InspectorController.cpp:
2883
2884 2009-11-18  Pavel Feldman  <pfeldman@chromium.org>
2885
2886         Reviewed by Timothy Hatcher.
2887
2888         Web Inspector: clone timeline records array instead of
2889         copying reference on invalidate all.
2890
2891         https://bugs.webkit.org/show_bug.cgi?id=31596
2892
2893         * inspector/front-end/AbstractTimelinePanel.js:
2894         (WebInspector.AbstractTimelinePanel.prototype.invalidateAllItems):
2895
2896 2009-11-18  Simon Fraser  <simon.fraser@apple.com>
2897
2898         Reviewed by Dan Bernstein.
2899
2900         Elements don't drop out of compositing layers when animation ends
2901         https://bugs.webkit.org/show_bug.cgi?id=31613
2902         <rdar://problem/7402913>
2903
2904         Avoid setting the mustOverlapCompositedLayers flag on RenderLayers which
2905         are compositing anyway for other reasons. Doing so can cause those layers
2906         to stay in compositing mode even after animations finish, because needsToBeComposited()
2907         continues to return true.
2908         
2909         No new tests because it's not possible to determine which elements are in
2910         compositing layers from DRT output.
2911
2912         * rendering/RenderLayerCompositor.cpp:
2913         (WebCore::RenderLayerCompositor::computeCompositingRequirements):
2914
2915 2009-11-18  Girish Ramakrishnan  <girish@forwardbias.in>
2916
2917         Reviewed by Tor Arne Vestbø.
2918
2919         [Qt] Mac Plugins: Remove null timer
2920         
2921         A null timer was used to send mouse move events. Instead, we now use
2922         move events to send nullEvent. This brings down CPU usage by 20-30%.
2923         
2924         https://bugs.webkit.org/show_bug.cgi?id=31624
2925
2926         * plugins/PluginView.h:
2927         * plugins/mac/PluginViewMac.cpp:
2928         (WebCore::PluginView::platformStart):
2929         (WebCore::PluginView::handleMouseEvent):
2930
2931 2009-11-18  Benjamin Poulain  <benjamin.poulain@nokia.com>
2932
2933         Reviewed by Simon Hausmann.
2934
2935         [Qt] WebKit crashes when loading certain SVG images
2936
2937         Check if the familly exist before creating the PlatformData from it.
2938
2939         https://bugs.webkit.org/show_bug.cgi?id=29443
2940
2941         Test: svg/text/text-font-invalid.html
2942
2943         * platform/graphics/qt/FontFallbackListQt.cpp:
2944         (WebCore::FontFallbackList::fontDataAt):
2945
2946 2009-11-17  Nicolas Weber  <thakis@chromium.org>
2947
2948         Reviewed by Darin Fisher.
2949
2950         Fix crash in Chromium/Mac where dropdowns weren't dismissed correctly
2951         after navigation.
2952         https://bugs.webkit.org/show_bug.cgi?id=31609
2953
2954         * platform/chromium/PopupMenuChromium.cpp:
2955         (WebCore::PopupContainer::showExternal): Set parent for external
2956         dropdowns, so that |PopupListBox::hidePopup()| can successfully notify
2957         its parent's client.
2958
2959 2009-11-17  Hayato Ito  <hayato@google.com>
2960
2961         Reviewed by Darin Adler.
2962
2963         Avoid infinite mutual recursion when deeply nested tags are loaded
2964         https://bugs.webkit.org/show_bug.cgi?id=30651
2965
2966         Test: fast/parser/block-nesting-cap-table.html
2967
2968         * html/HTMLParser.cpp:
2969         (WebCore::HTMLParser::parseToken):
2970         (WebCore::tagPriorityOfNode):
2971         (WebCore::HTMLParser::limitBlockDepth):
2972         (WebCore::HTMLParser::insertNodeAfterLimitBlockDepth):
2973         (WebCore::HTMLParser::insertNode):
2974         * html/HTMLParser.h:
2975
2976 2009-11-17  Brent Fulgham  <bfulgham@webkit.org>
2977
2978         Rubber-stamped by Alexey Proskuryakov.
2979
2980         Final clean-ups for minor coding standard violations.
2981         https://bugs.webkit.org/show_bug.cgi?id=26102.
2982
2983         * platform/graphics/cairo/GraphicsContextCairo.cpp:
2984
2985 2009-11-17  Johnny Ding  <jnd@chromium.org>
2986
2987         Reviewed by Darin Adler.
2988
2989         In all valid script tags for JavaScript, the event handler in <script...for> should not get executed.
2990         https://bugs.webkit.org/show_bug.cgi?id=31567
2991
2992         * dom/ScriptElement.cpp:
2993         (WebCore::ScriptElementData::shouldExecuteAsJavaScript):
2994
2995 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
2996
2997         Reviewed by Timothy Hatcher.
2998
2999         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
3000         - Updated DRT to show/close inspector for all tests under /inspector
3001         - Introduced LayoutTestController::setTimelineProfilingEnabled and
3002           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
3003         - Removed reload on each inspector test
3004         - Renamed fast/inspector to fast/inspector-support in order not to trigger
3005         inspector for those.
3006         - Reimplemented timeline tests in order to get rid of reload there.
3007         - Moved tests that don't require harness into the fast group.
3008
3009         https://bugs.webkit.org/show_bug.cgi?id=31472
3010
3011         * WebCore.Inspector.exp:
3012         * inspector/front-end/TimelinePanel.js:
3013         (WebInspector.TimelinePanel.prototype._formatRecord):
3014
3015 2009-11-17  Andrei Popescu  <andreip@google.com>
3016
3017         Reviewed by Dimitri Glazkov.
3018
3019         [Android] Android is missing the implementation of the GeolocationService iface.
3020         https://bugs.webkit.org/show_bug.cgi?id=31554
3021
3022         No new tests required as this is platform specific code.
3023
3024         * platform/android/GeolocationServiceAndroid.cpp: Added.
3025         (WebCore::GeolocationServiceAndroid::create):
3026         (WebCore::GeolocationServiceAndroid::GeolocationServiceAndroid):
3027         (WebCore::GeolocationServiceAndroid::startUpdating):
3028         (WebCore::GeolocationServiceAndroid::stopUpdating):
3029         (WebCore::GeolocationServiceAndroid::suspend):
3030         (WebCore::GeolocationServiceAndroid::resume):
3031         (WebCore::GeolocationServiceAndroid::newPositionAvailable):
3032         (WebCore::GeolocationServiceAndroid::newErrorAvailable):
3033         (WebCore::GeolocationServiceAndroid::timerFired):
3034         (WebCore::GeolocationServiceAndroid::isPositionMovement):
3035         (WebCore::GeolocationServiceAndroid::isPositionMoreAccurate):
3036         (WebCore::GeolocationServiceAndroid::isPositionMoreTimely):
3037         * platform/android/GeolocationServiceAndroid.h: Added.
3038         (WebCore::GeolocationServiceAndroid::~GeolocationServiceAndroid):
3039         (WebCore::GeolocationServiceAndroid::lastPosition):
3040         (WebCore::GeolocationServiceAndroid::lastError):
3041         * platform/android/GeolocationServiceBridge.cpp: Added.
3042         (WebCore::):
3043         (WebCore::GeolocationServiceBridge::GeolocationServiceBridge):
3044         (WebCore::GeolocationServiceBridge::~GeolocationServiceBridge):
3045         (WebCore::GeolocationServiceBridge::start):
3046         (WebCore::GeolocationServiceBridge::stop):
3047         (WebCore::GeolocationServiceBridge::setEnableGps):
3048         (WebCore::GeolocationServiceBridge::newLocationAvailable):
3049         (WebCore::GeolocationServiceBridge::newErrorAvailable):
3050         (WebCore::GeolocationServiceBridge::toGeoposition):
3051         (WebCore::GeolocationServiceBridge::startJavaImplementation):
3052         (WebCore::GeolocationServiceBridge::stopJavaImplementation):
3053         * platform/android/GeolocationServiceBridge.h: Added.
3054
3055 2009-11-16  Kent Tamura  <tkent@chromium.org>
3056
3057         Unreviewd build fix.
3058
3059         - Fix typo in WebCore.vcproj.
3060         - Intlude limits.h for INT_MAX.
3061         - Enclose with parenthesis to suspress warning.
3062
3063         * WebCore.vcproj/WebCore.vcproj:
3064         * html/ISODateTime.cpp:
3065         (WebCore::ISODateTime::addDay):
3066
3067 2009-11-16  Robin Dunn  <robin@alldunn.com>
3068
3069         Reviewed by Kevin Ollivier.
3070
3071         Make sure wx scrollbar drawing code factors in transforms when switching backends,
3072         fix calcs for scrollbar length, and tweak the Mac scrollbar tracking rects.
3073         
3074         https://bugs.webkit.org/show_bug.cgi?id=31570
3075
3076         * platform/wx/ScrollbarThemeWx.cpp:
3077         (WebCore::ScrollbarThemeWx::minimumThumbLength):
3078         (WebCore::ScrollbarThemeWx::splitTrack):
3079         (WebCore::ScrollbarThemeWx::forwardButtonRect):
3080         * platform/wx/ScrollbarThemeWx.h:
3081         * platform/wx/wxcode/gtk/scrollbar_render.cpp:
3082         (wxRenderer_DrawScrollbar):
3083         * platform/wx/wxcode/scrollbar_render.h:
3084         (calcThumbStartAndLength):
3085         * platform/wx/wxcode/win/scrollbar_render.cpp:
3086         (wxRenderer_DrawScrollbar):
3087
3088 2009-11-16  Kent Tamura  <tkent@chromium.org>
3089
3090         Reviewed by David Levin.
3091
3092         Introduce WebCore::ISODateTime class.
3093         https://bugs.webkit.org/show_bug.cgi?id=31340
3094
3095         This class represents a value of date/time types of the HTML5 INPUT
3096         element, and has some parsing methods for ISO 8601.
3097
3098         This change has no tests because the class is not used yet.
3099
3100         * GNUmakefile.am: Add ISODateTime.cpp and ISODateTime.h.
3101         * WebCore.gypi: ditto.
3102         * WebCore.pro: ditto.
3103         * WebCore.vcproj/WebCore.vcproj: ditto.
3104         * WebCore.xcodeproj/project.pbxproj: ditto.
3105         * WebCoreSources.bkl: ditto.
3106         * html/ISODateTime.cpp: Added. Implementation of WebCore::ISODateTime class.
3107         (WebCore::isLeapYear):
3108         (WebCore::maxDayOfMonth):
3109         (WebCore::dayOfWeek):
3110         (WebCore::ISODateTime::maxWeekNumberInYear):
3111         (WebCore::countDigits):
3112         (WebCore::toInt):
3113         (WebCore::ISODateTime::parseYear): Private helper for parseDate() and parseWeek().
3114         (WebCore::ISODateTime::addDay): Private helper for parseTimeZone().
3115         (WebCore::ISODateTime::addMinute): ditto.
3116         (WebCore::ISODateTime::parseTimeZone): Private helper for parseDateTime().
3117         (WebCore::ISODateTime::parseMonth): Parser for <input type=month>.
3118         (WebCore::ISODateTime::parseDate): Parser for <input type=date>.
3119         (WebCore::ISODateTime::parseWeek): Parser for <input type=week>.
3120         (WebCore::ISODateTime::parseTime): Parser for <input type=time>.
3121         (WebCore::ISODateTime::parseDateTimeLocal): Parser for <input type=datetime-local>.
3122         (WebCore::ISODateTime::parseDateTime): Parser for <input type=datetime>.
3123         * html/ISODateTime.h: Added.  Declare WebCore::ISODateTime class.
3124         (WebCore::ISODateTime::ISODateTime):
3125         (WebCore::ISODateTime::millisecond):
3126         (WebCore::ISODateTime::second):
3127         (WebCore::ISODateTime::minute):
3128         (WebCore::ISODateTime::hour):
3129         (WebCore::ISODateTime::monthDay):
3130         (WebCore::ISODateTime::month):
3131         (WebCore::ISODateTime::fullYear):
3132         (WebCore::ISODateTime::week):
3133
3134 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
3135
3136         Fix a typo in previous commit.
3137
3138         * platform/network/cf/SocketStreamHandleCFNet.cpp: #ifdef, not #if.
3139
3140 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
3141
3142         Fix a typo in previous commit.
3143
3144         * platform/network/cf/SocketStreamHandleCFNet.cpp:
3145
3146 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
3147
3148         Tiger build fix.
3149
3150         * platform/network/cf/SocketStreamHandleCFNet.cpp: Define CFN_EXPORT, as this macro was named
3151         differently in Tiger CFNetwork.
3152
3153 2009-11-16  Dimitri Glazkov  <dglazkov@chromium.org>
3154
3155         Reviewed by Darin Fisher.
3156
3157         [KURLGoogle] setHostAndPort doesn't handle arguments without port correctly.
3158
3159         Fix a bug in the code that was dormant until http://trac.webkit.org/changeset/50784.
3160
3161         Covered by existing test: LayoutTests/fast/dom/HTMLAnchorElement/set-href-attribute-host.html
3162
3163         * platform/KURLGoogle.cpp:
3164         (WebCore::KURL::setHostAndPort): Added handling of arguments without port specified.
3165
3166 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
3167
3168         Rubber-stamped by Jon Honeycutt.
3169
3170         A better Windows build fix
3171
3172         * platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::createStreams):
3173         Use a macro that inserts __declspec(dllimport) when appropriate for CFNetwork imports.
3174
3175 2009-11-16  Yael Aharon  <yael.aharon@nokia.com>
3176
3177         Reviewed by Darin Adler.
3178
3179         Rename protocolIsValid to isValidProtocol.
3180         https://bugs.webkit.org/show_bug.cgi?id=31503
3181
3182         This name change was suggested in https://bugs.webkit.org/show_bug.cgi?id=29972#c19.
3183
3184         No new tests since no new functionality was introduced.
3185
3186         * html/HTMLAnchorElement.cpp:
3187         (WebCore::HTMLAnchorElement::setProtocol):
3188         * platform/KURL.cpp:
3189         (WebCore::isValidProtocol):
3190         * platform/KURL.h:
3191         * platform/KURLGoogle.cpp:
3192         (WebCore::isValidProtocol):
3193
3194 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
3195
3196         Reviewed by Beth Dakin.
3197
3198         AX: aria-labelledby duplicates some of its WAI-ARIA label
3199         https://bugs.webkit.org/show_bug.cgi?id=31565
3200
3201         Test: accessibility/aria-labelledby-overrides-label.html
3202
3203         * accessibility/AccessibilityRenderObject.cpp:
3204         (WebCore::AccessibilityRenderObject::hasTextAlternative):
3205         (WebCore::AccessibilityRenderObject::exposesTitleUIElement):
3206         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
3207         * accessibility/AccessibilityRenderObject.h:
3208
3209 2009-11-16  Nate Chapin  <japhet@chromium.org>
3210
3211         Reviewed by Darin Fisher.
3212
3213         Handle the case of a null NPObject* in NPN_SetException in
3214         the V8 bindings.  This allow out of process plugins calling
3215         NPN_SetException to just send null instead of sending an
3216         NPObject* that would be an address in a different 
3217         process's memory space.
3218
3219         https://bugs.webkit.org/show_bug.cgi?id=31561
3220
3221         * bindings/v8/NPV8Object.cpp:
3222         (_NPN_SetException): Allow null NPObject* and just throw a general error.
3223
3224 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
3225
3226         Windows build fix.
3227
3228         * platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::createStreams):
3229         Disable CONNECT proxies on Windows until WebKitSupportLibrary includes support for those.
3230
3231 2009-11-14  Yael Aharon  <yael.aharon@nokia.com>
3232
3233         Reviewed by Kenneth Rohde Christiansen.
3234
3235         [Qt] ASSERT failure while running DRT
3236         https://bugs.webkit.org/show_bug.cgi?id=30978
3237
3238         Add needed Structure typeInfo flags to QtRuntimeObjectImpl and QtRuntimeMethod.
3239         These flags are needed after r49649, where HasDefaultmark was changed to OverrideMarkChildren.
3240
3241         * bridge/qt/qt_instance.cpp:
3242         (JSC::Bindings::QtRuntimeObjectImp::createStructure):
3243         * bridge/qt/qt_runtime.h:
3244         (JSC::Bindings::QtRuntimeMethod::createStructure):
3245
3246 2009-11-16  Mark Rowe  <mrowe@apple.com>
3247
3248         Attempt to fix the build.  Land a file that was missing from r51049.
3249
3250         * bindings/js/JSWebGLArrayHelper.h: Copied from WebCore/html/canvas/WebGLByteArray.idl.
3251         (WebCore::setWebGLArrayFromArray):
3252
3253 2009-11-16  Kenneth Russell  <kbr@google.com>
3254
3255         Reviewed by Oliver Hunt.
3256
3257         Update API of WebGLArray and friends
3258         https://bugs.webkit.org/show_bug.cgi?id=31175
3259
3260         * bindings/js/JSWebGLArrayCustom.cpp:
3261         (WebCore::toJS):
3262         * bindings/js/JSWebGLArrayHelper.h: Added.
3263         (WebCore::setWebGLArrayFromArray):
3264         * bindings/js/JSWebGLByteArrayCustom.cpp:
3265         (WebCore::JSWebGLByteArray::set):
3266         * bindings/js/JSWebGLFloatArrayCustom.cpp:
3267         (WebCore::JSWebGLFloatArray::set):
3268         * bindings/js/JSWebGLIntArrayCustom.cpp:
3269         (WebCore::JSWebGLIntArray::set):
3270         * bindings/js/JSWebGLShortArrayCustom.cpp:
3271         (WebCore::JSWebGLShortArray::set):
3272         * bindings/js/JSWebGLUnsignedByteArrayCustom.cpp:
3273         (WebCore::JSWebGLUnsignedByteArray::set):
3274         * bindings/js/JSWebGLUnsignedIntArrayCustom.cpp:
3275         (WebCore::JSWebGLUnsignedIntArray::set):
3276         * bindings/js/JSWebGLUnsignedShortArrayCustom.cpp:
3277         (WebCore::JSWebGLUnsignedShortArray::set):
3278         * bindings/scripts/CodeGeneratorV8.pm:
3279         * bindings/v8/V8DOMWrapper.cpp:
3280         (WebCore::V8DOMWrapper::convertToV8Object):
3281         * bindings/v8/custom/V8CustomBinding.h:
3282         * bindings/v8/custom/V8WebGLArrayBufferCustom.cpp:
3283         (WebCore::CALLBACK_FUNC_DECL):
3284         * bindings/v8/custom/V8WebGLArrayCustom.h:
3285         (WebCore::constructWebGLArray):
3286         (WebCore::getWebGLArrayElement):
3287         (WebCore::setWebGLArrayFromArray):
3288         (WebCore::setWebGLArray):
3289         * bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
3290         (WebCore::CALLBACK_FUNC_DECL):
3291         * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
3292         (WebCore::CALLBACK_FUNC_DECL):
3293         * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
3294         (WebCore::CALLBACK_FUNC_DECL):
3295         * bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
3296         (WebCore::CALLBACK_FUNC_DECL):
3297         * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
3298         (WebCore::CALLBACK_FUNC_DECL):
3299         * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
3300         (WebCore::CALLBACK_FUNC_DECL):
3301         * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
3302         (WebCore::CALLBACK_FUNC_DECL):
3303         * html/canvas/WebGLArray.cpp:
3304         (WebCore::WebGLArray::WebGLArray):
3305         (WebCore::WebGLArray::~WebGLArray):
3306         (WebCore::WebGLArray::setImpl):
3307         * html/canvas/WebGLArray.h:
3308         (WebCore::WebGLArray::isByteArray):
3309         (WebCore::WebGLArray::isUnsignedByteArray):
3310         (WebCore::WebGLArray::isShortArray):
3311         (WebCore::WebGLArray::isUnsignedShortArray):
3312         (WebCore::WebGLArray::isIntArray):
3313         (WebCore::WebGLArray::isUnsignedIntArray):
3314         (WebCore::WebGLArray::isFloatArray):
3315         (WebCore::WebGLArray::buffer):
3316         (WebCore::WebGLArray::baseAddress):
3317         (WebCore::WebGLArray::byteOffset):
3318         * html/canvas/WebGLArray.idl:
3319         * html/canvas/WebGLArrayBuffer.cpp:
3320         (WebCore::WebGLArrayBuffer::create):
3321         (WebCore::WebGLArrayBuffer::WebGLArrayBuffer):
3322         (WebCore::WebGLArrayBuffer::data):
3323         (WebCore::WebGLArrayBuffer::byteLength):
3324         (WebCore::WebGLArrayBuffer::~WebGLArrayBuffer):
3325         * html/canvas/WebGLArrayBuffer.h:
3326         * html/canvas/WebGLByteArray.cpp:
3327         (WebCore::WebGLByteArray::create):
3328         (WebCore::WebGLByteArray::byteLength):
3329         (WebCore::WebGLByteArray::slice):
3330         (WebCore::WebGLByteArray::set):
3331         * html/canvas/WebGLByteArray.h:
3332         (WebCore::WebGLByteArray::isByteArray):
3333         (WebCore::WebGLByteArray::data):
3334         (WebCore::WebGLByteArray::set):
3335         (WebCore::WebGLByteArray::get):
3336         (WebCore::WebGLByteArray::item):
3337         * html/canvas/WebGLByteArray.idl:
3338         * html/canvas/WebGLFloatArray.cpp:
3339         (WebCore::WebGLFloatArray::create):
3340         (WebCore::WebGLFloatArray::WebGLFloatArray):
3341         (WebCore::WebGLFloatArray::length):
3342         (WebCore::WebGLFloatArray::byteLength):
3343         (WebCore::WebGLFloatArray::slice):
3344         (WebCore::WebGLFloatArray::set):
3345         * html/canvas/WebGLFloatArray.h:
3346         (WebCore::WebGLFloatArray::isFloatArray):
3347         (WebCore::WebGLFloatArray::data):
3348         (WebCore::WebGLFloatArray::set):
3349         (WebCore::WebGLFloatArray::get):
3350         (WebCore::WebGLFloatArray::item):
3351         * html/canvas/WebGLFloatArray.idl:
3352         * html/canvas/WebGLIntArray.cpp:
3353         (WebCore::WebGLIntArray::create):
3354         (WebCore::WebGLIntArray::WebGLIntArray):
3355         (WebCore::WebGLIntArray::length):
3356         (WebCore::WebGLIntArray::byteLength):
3357         (WebCore::WebGLIntArray::slice):
3358         (WebCore::WebGLIntArray::set):
3359         * html/canvas/WebGLIntArray.h:
3360         (WebCore::WebGLIntArray::isIntArray):
3361         (WebCore::WebGLIntArray::data):
3362         (WebCore::WebGLIntArray::set):
3363         (WebCore::WebGLIntArray::get):
3364         (WebCore::WebGLIntArray::item):
3365         * html/canvas/WebGLIntArray.idl:
3366         * html/canvas/WebGLShortArray.cpp:
3367         (WebCore::WebGLShortArray::create):
3368         (WebCore::WebGLShortArray::WebGLShortArray):
3369         (WebCore::WebGLShortArray::length):
3370         (WebCore::WebGLShortArray::byteLength):
3371         (WebCore::WebGLShortArray::slice):
3372         (WebCore::WebGLShortArray::set):
3373         * html/canvas/WebGLShortArray.h:
3374         (WebCore::WebGLShortArray::isShortArray):
3375         (WebCore::WebGLShortArray::data):
3376         (WebCore::WebGLShortArray::set):
3377         (WebCore::WebGLShortArray::get):
3378         (WebCore::WebGLShortArray::item):
3379         * html/canvas/WebGLShortArray.idl:
3380         * html/canvas/WebGLUnsignedByteArray.cpp:
3381         (WebCore::WebGLUnsignedByteArray::create):
3382         (WebCore::WebGLUnsignedByteArray::WebGLUnsignedByteArray):
3383         (WebCore::WebGLUnsignedByteArray::length):
3384         (WebCore::WebGLUnsignedByteArray::byteLength):
3385         (WebCore::WebGLUnsignedByteArray::slice):
3386         (WebCore::WebGLUnsignedByteArray::set):
3387         * html/canvas/WebGLUnsignedByteArray.h:
3388         (WebCore::WebGLUnsignedByteArray::isUnsignedByteArray):
3389         (WebCore::WebGLUnsignedByteArray::data):
3390         (WebCore::WebGLUnsignedByteArray::set):
3391         (WebCore::WebGLUnsignedByteArray::get):
3392         (WebCore::WebGLUnsignedByteArray::item):
3393         * html/canvas/WebGLUnsignedByteArray.idl:
3394         * html/canvas/WebGLUnsignedIntArray.cpp:
3395         (WebCore::WebGLUnsignedIntArray::create):
3396         (WebCore::WebGLUnsignedIntArray::WebGLUnsignedIntArray):
3397         (WebCore::WebGLUnsignedIntArray::length):
3398         (WebCore::WebGLUnsignedIntArray::byteLength):
3399         (WebCore::WebGLUnsignedIntArray::slice):
3400         (WebCore::WebGLUnsignedIntArray::set):
3401         * html/canvas/WebGLUnsignedIntArray.h:
3402         (WebCore::WebGLUnsignedIntArray::isUnsignedIntArray):
3403         (WebCore::WebGLUnsignedIntArray::data):
3404         (WebCore::WebGLUnsignedIntArray::set):
3405         (WebCore::WebGLUnsignedIntArray::get):
3406         (WebCore::WebGLUnsignedIntArray::item):
3407         * html/canvas/WebGLUnsignedIntArray.idl:
3408         * html/canvas/WebGLUnsignedShortArray.cpp:
3409         (WebCore::WebGLUnsignedShortArray::create):
3410         (WebCore::WebGLUnsignedShortArray::WebGLUnsignedShortArray):
3411         (WebCore::WebGLUnsignedShortArray::length):
3412         (WebCore::WebGLUnsignedShortArray::byteLength):
3413         (WebCore::WebGLUnsignedShortArray::slice):
3414         (WebCore::WebGLUnsignedShortArray::set):
3415         * html/canvas/WebGLUnsignedShortArray.h:
3416         (WebCore::WebGLUnsignedShortArray::isUnsignedShortArray):
3417         (WebCore::WebGLUnsignedShortArray::data):
3418         (WebCore::WebGLUnsignedShortArray::set):
3419         (WebCore::WebGLUnsignedShortArray::get):
3420         (WebCore::WebGLUnsignedShortArray::item):
3421         * html/canvas/WebGLUnsignedShortArray.idl:
3422         * platform/graphics/mac/GraphicsContext3DMac.cpp:
3423         (WebCore::GraphicsContext3D::bufferData):
3424         (WebCore::GraphicsContext3D::bufferSubData):
3425
3426 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
3427
3428         Windows build fix.
3429
3430         * platform/network/cf/SocketStreamHandleCFNet.cpp: Declare constants as extern "C".
3431
3432 2009-11-15  Brent Fulgham  <bfulgham@webkit.org>
3433
3434         Reviewed by Oliver Hunt.
3435
3436         Enable support for webkit-box-shadow in Cairo builds.
3437         https://bugs.webkit.org/show_bug.cgi?id=26102.
3438
3439         Covered by existing fast/box-shadow tests.
3440
3441         * platform/graphics/cairo/GraphicsContextCairo.cpp:  Add
3442           support for fillRect shadows.
3443
3444 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
3445
3446         Windows build fix.
3447
3448         * platform/network/cf/SocketStreamHandleCFNet.cpp: Don't try to include a file that's not
3449         in WebKitSupportLibrary.
3450
3451 2009-11-16  Alexey Proskuryakov  <ap@apple.com>
3452
3453         Reviewed by Darin Adler.
3454
3455         https://bugs.webkit.org/show_bug.cgi?id=31494
3456         Add unauthenticated proxy support to SocketStreamHandleCFNet
3457
3458         Cannot be tested in DRT.
3459
3460         * platform/network/cf/SocketStreamHandleCFNet.cpp:
3461         (WebCore::SocketStreamHandle::chooseProxy): Fetch proxy information from OS.
3462         (WebCore::SocketStreamHandle::createStreams): Apply it to the newly created streams.
3463
3464 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
3465
3466         Reviewed by Antti Koivisto.
3467
3468         [Qt] Broken back/forward after using ErrorPageExtension to set error page
3469         https://bugs.webkit.org/show_bug.cgi?id=30573
3470
3471         Make FrameLoader::checkLoadCompleteForThisFrame method
3472         to check for any working DocumentLoader instance (through
3473         activeDocumentLoader()) instead of only checking for
3474         'm_provisionalDocumentLoader' in order to decide to if
3475         it is going to reset of not the back and forward history.
3476         after an error page has been loaded.
3477
3478         Test: LayoutTests/fast/history/back-forward-reset-after-error-handling.html
3479
3480         * loader/FrameLoader.cpp:
3481         (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
3482
3483 2009-11-14  Chris Fleizach  <cfleizach@apple.com>
3484
3485         Reviewed by Darin Adler.
3486
3487         Need to implement ARIA role="directory"
3488         https://bugs.webkit.org/show_bug.cgi?id=31516
3489
3490         Test: platform/mac/accessibility/aria-directory.html
3491
3492         * accessibility/AXObjectCache.cpp:
3493         (WebCore::AXObjectCache::getOrCreate):
3494         * accessibility/AccessibilityList.cpp:
3495         (WebCore::AccessibilityList::isOrderedList):
3496         * accessibility/AccessibilityRenderObject.cpp:
3497         (WebCore::createARIARoleMap):
3498
3499 2009-11-15  Dave Tapuska  <dtapuska@rim.com>
3500
3501         Reviewed by George Staikos.
3502         
3503         Compare UChars single unit at a time as opposed to the uint32_t
3504         approach as casting to unaligned addresses may cause a bus failure
3505         on ARMv5 and below. This change replicates the same defines that
3506         exists in AtomicString.cpp
3507
3508         https://bugs.webkit.org/show_bug.cgi?id=31475
3509         
3510         * platform/text/StringHash.h:
3511         (WebCore::StringHash::equal):
3512
3513 2009-11-15  Evan Martin  <evan@chromium.org>
3514
3515         Reviewed by Adam Barth.
3516
3517         Wrap some SVG code in V8DOMWrapper with an ENABLE(SVG) test.
3518
3519         https://bugs.webkit.org/show_bug.cgi?id=31490
3520
3521         * bindings/v8/V8DOMWrapper.cpp:
3522
3523 2009-11-15  Maxime Simon  <simon.maxime@gmail.com>
3524
3525         Reviewed by Adam Barth.
3526
3527         [Haiku] Build fix. The FileChooser constructor doesn't need to be redefined.
3528
3529         * platform/haiku/FileChooserHaiku.cpp:
3530
3531 2009-11-15  Maxime Simon  <simon.maxime@gmail.com>
3532
3533         Reviewed by Adam Barth.
3534
3535         [Haiku] Build fix. ColorSpace name had a wrong CamelCase.
3536
3537         * platform/graphics/haiku/GraphicsContextHaiku.cpp:
3538         (WebCore::GraphicsContext::setPlatformStrokeColor):
3539
3540 2009-11-15  Daniel Bates  <dbates@webkit.org>
3541
3542         No review, rolling out r50999.
3543         http://trac.webkit.org/changeset/50999
3544
3545         Need to fix some issues in the Windows build. Missed some places where
3546         RenderTextControl::isEdited is called.
3547
3548         * bindings/objc/DOMHTML.mm:
3549         (-[DOMHTMLInputElement _isEdited]):
3550         (-[DOMHTMLTextAreaElement _isEdited]):
3551         * dom/Document.cpp:
3552         (WebCore::Document::setFocusedNode):
3553         * html/HTMLInputElement.cpp:
3554         (WebCore::HTMLInputElement::defaultEventHandler):
3555         * rendering/RenderTextControl.cpp:
3556         (WebCore::RenderTextControl::RenderTextControl):
3557         (WebCore::RenderTextControl::setInnerTextValue):
3558         (WebCore::RenderTextControl::setUserEdited):
3559         (WebCore::RenderTextControl::subtreeHasChanged):
3560         * rendering/RenderTextControl.h:
3561         (WebCore::RenderTextControl::isEdited):
3562         (WebCore::RenderTextControl::setEdited):
3563         (WebCore::RenderTextControl::isUserEdited):
3564         * rendering/RenderTextControlSingleLine.cpp:
3565         (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
3566         * wml/WMLInputElement.cpp:
3567         (WebCore::WMLInputElement::defaultEventHandler):
3568
3569 2009-11-15  Daniel Bates  <dbates@webkit.org>
3570
3571         Reviewed by Darin Adler.
3572
3573         https://bugs.webkit.org/show_bug.cgi?id=31186
3574
3575         Renames RenderTextControl::m_edited and RenderTextControl::m_userEdited to
3576         m_wasChangedSinceLastChangeEvent and m_lastChangeWasUserEdit, respectively.
3577         These are more descriptive names so as to clear an ambiguity surrounding
3578         their usage. Also, renames associated setters and getters so that they
3579         coincide with the renamed fields.
3580
3581         No functionality was changed. So, no tests were included.
3582