e3cccb033766ac1bdbd4bf1e7b71d644912481bb
[WebKit-https.git] / WebCore / ChangeLog
1 2009-11-02  Enrica Casucci  <enrica@apple.com>
2
3         Reviewed by Adele Peterson and Dan Bernstein.
4
5         Safari crashes when calling execCommand on formatted html in special case
6         <rdar://problem/7318656>
7         https://bugs.webkit.org/show_bug.cgi?id=31023
8
9         Test: editing/execCommand/align-in-span.html
10
11         * rendering/RenderObject.cpp:
12         (WebCore::RenderObject::containingBlock): Modified comment on containingBlock returning NULL.
13         * rendering/RenderText.cpp:
14         (WebCore::RenderText::setSelectionState): Added check for NULL return from containingBlock,
15         since it is possible when dealing with orphaned trees.
16
17 2009-11-02  Chris Marrin  <cmarrin@apple.com>
18
19         Reviewed by Oliver Hunt.
20
21         Exception checks were being too aggressive
22         https://bugs.webkit.org/show_bug.cgi?id=31005
23
24         Several calls in CanvasRenderingContext3D are allowed to
25         have a null value passed, which indicated that the 
26         object is being unbound. Handle this case and the corresponding
27         null handling in GraphicsContext3DMac.
28
29         * html/canvas/CanvasRenderingContext3D.cpp:
30         (WebCore::CanvasRenderingContext3D::bindBuffer):
31         (WebCore::CanvasRenderingContext3D::bindFramebuffer):
32         (WebCore::CanvasRenderingContext3D::bindRenderbuffer):
33         (WebCore::CanvasRenderingContext3D::bindTexture):
34         (WebCore::CanvasRenderingContext3D::framebufferRenderbuffer):
35         (WebCore::CanvasRenderingContext3D::framebufferTexture2D):
36         * platform/graphics/mac/GraphicsContext3DMac.cpp:
37         (WebCore::GraphicsContext3D::framebufferRenderbuffer):
38         (WebCore::GraphicsContext3D::framebufferTexture2D):
39
40 2009-11-02  Patrick Mueller  <Patrick_Mueller@us.ibm.com>
41
42         Reviewed by Timothy Hatcher.
43
44         Each JS execution in console adds extra item into "scripts" combo
45         https://bugs.webkit.org/show_bug.cgi?id=30212
46
47         Added manual test
48
49         * inspector/front-end/ScriptsPanel.js:
50         (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
51         * manual-tests/inspector/hidden-evals.html: Added.
52
53 2009-11-02  Kelly Norton  <knorton@google.com>
54
55         Reviewed by Timothy Hatcher.
56
57         Adds a missed case for InspectorTimeline, DOMWindow dispatch of DOM events.
58         https://bugs.webkit.org/show_bug.cgi?id=31030
59
60         * dom/Node.cpp:
61         (WebCore::eventHasListeners): Checks DOMWindow for listeners.
62         (WebCore::Node::dispatchGenericEvent):
63
64 2009-11-02  Dmitry Titov  <dimich@chromium.org>
65
66         Reviewed by David Levin.
67
68         Remove threadsafe refcounting from tasks used with WTF::MessageQueue.
69         https://bugs.webkit.org/show_bug.cgi?id=30612
70
71         No new tests since no new functionality. Storage, MessagePorts and Workers tests cover this.
72
73         There are a lot of files but most changes are simply replace RefPtr and PassRefPtr with
74         OwnPtr and PassOwnPtr when dealing with Tasks.
75
76         ScriptExecutionContext::Task, DatabaseTask and WorkerRunLoop::Task are no longer
77         threadsafe refcounted, but simply Noncopyable.
78
79         * dom/Document.cpp:
80         (WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
81         (WebCore::PerformTaskContext::PerformTaskContext):
82         (WebCore::Document::postTask):
83         * dom/Document.h:
84         * dom/ScriptExecutionContext.cpp:
85         (WebCore::ProcessMessagesSoonTask::create):
86         * dom/ScriptExecutionContext.h:
87         * dom/default/PlatformMessagePortChannel.cpp:
88         (WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote):
89         * dom/default/PlatformMessagePortChannel.h:
90         (WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage):
91         (WebCore::PlatformMessagePortChannel::MessagePortQueue::appendAndCheckEmpty):
92         * loader/FrameLoader.cpp:
93         (WebCore::HashChangeEventTask::create):
94         * loader/appcache/ApplicationCacheGroup.cpp:
95         (WebCore::CallCacheListenerTask::create):
96         * storage/Database.cpp:
97         (WebCore::Database::openAndVerifyVersion):
98         (WebCore::Database::markAsDeletedAndClose):
99         (WebCore::Database::scheduleTransaction):
100         (WebCore::Database::scheduleTransactionStep):
101         (WebCore::Database::tableNames):
102         * storage/DatabaseTask.h:
103         (WebCore::DatabaseOpenTask::create):
104         (WebCore::DatabaseCloseTask::create):
105         (WebCore::DatabaseTransactionTask::create):
106         (WebCore::DatabaseTableNamesTask::create):
107         * storage/DatabaseThread.cpp:
108         (WebCore::DatabaseThread::databaseThread):
109         (WebCore::DatabaseThread::scheduleTask):
110         (WebCore::DatabaseThread::scheduleImmediateTask):
111         (WebCore::SameDatabasePredicate::operator()):
112         * storage/DatabaseThread.h:
113         * storage/LocalStorageTask.h:
114         (WebCore::LocalStorageTask::createImport):
115         (WebCore::LocalStorageTask::createSync):
116         (WebCore::LocalStorageTask::createTerminate):
117         * storage/LocalStorageThread.cpp:
118         (WebCore::LocalStorageThread::localStorageThread):
119         * storage/LocalStorageThread.h:
120         * websockets/WebSocket.cpp:
121         (WebCore::ProcessWebSocketEventTask::create):
122         * workers/DefaultSharedWorkerRepository.cpp:
123         (WebCore::SharedWorkerProxy::postTaskToLoader):
124         (WebCore::SharedWorkerProxy::postTaskForModeToWorkerContext):
125         (WebCore::SharedWorkerConnectTask::create):
126         * workers/GenericWorkerTask.h:
127         (WebCore::GenericWorkerTask1::create):
128         (WebCore::GenericWorkerTask2::create):
129         (WebCore::GenericWorkerTask3::create):
130         (WebCore::GenericWorkerTask4::create):
131         (WebCore::GenericWorkerTask5::create):
132         (WebCore::GenericWorkerTask6::create):
133         (WebCore::GenericWorkerTask7::create):
134         (WebCore::GenericWorkerTask8::create):
135         (WebCore::createCallbackTask):
136         * workers/WorkerContext.cpp:
137         (WebCore::WorkerContext::postTask):
138         * workers/WorkerContext.h:
139         * workers/WorkerLoaderProxy.h:
140         * workers/WorkerMessagingProxy.cpp:
141         (WebCore::MessageWorkerContextTask::create):
142         (WebCore::MessageWorkerTask::create):
143         (WebCore::WorkerExceptionTask::create):
144         (WebCore::WorkerContextDestroyedTask::create):
145         (WebCore::WorkerTerminateTask::create):
146         (WebCore::WorkerThreadActivityReportTask::create):
147         (WebCore::WorkerMessagingProxy::postTaskForModeToWorkerContext):
148         (WebCore::WorkerMessagingProxy::postTaskToLoader):
149         (WebCore::WorkerMessagingProxy::workerThreadCreated):
150         * workers/WorkerMessagingProxy.h:
151         * workers/WorkerRunLoop.cpp:
152         (WebCore::ModePredicate::operator()):
153         (WebCore::WorkerRunLoop::runInMode):
154         (WebCore::WorkerRunLoop::postTask):
155         (WebCore::WorkerRunLoop::postTaskForMode):
156         (WebCore::WorkerRunLoop::Task::create):
157         (WebCore::WorkerRunLoop::Task::performTask):
158         (WebCore::WorkerRunLoop::Task::Task):
159         * workers/WorkerRunLoop.h:
160         (WebCore::WorkerRunLoop::Task::~Task):
161         (WebCore::WorkerRunLoop::Task::mode):
162
163 2009-11-02  Philippe Normand  <pnormand@igalia.com>
164
165         Reviewed by Jan Alonzo.
166
167         [GTK] Failing media/video-played-reset.html
168         https://bugs.webkit.org/show_bug.cgi?id=30589
169
170         new m_seekTime attribute to keep track of the seek position
171
172         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
173         (WebCore::MediaPlayerPrivate::currentTime):
174         (WebCore::MediaPlayerPrivate::seek):
175         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
176
177 2009-11-02  Xan Lopez  <xlopez@igalia.com>
178
179         Reviewed by Jan Alonzo.
180
181         [GTK] Remove Referer when redirecting to non-secure site
182         https://bugs.webkit.org/show_bug.cgi?id=31021
183
184         Remove referer from HTTP headers when redirecting to a non-secure
185         site.
186
187         * platform/network/soup/ResourceHandleSoup.cpp:
188         (WebCore::restartedCallback):
189
190 2009-11-02  Alexey Proskuryakov  <ap@apple.com>
191
192         Reviewed by Dan Bernstein.
193
194         https://bugs.webkit.org/show_bug.cgi?id=18539
195         multipart/form-data not being parsed correctly on server due to '+' in boundary string
196
197         No test - the characters that the boundary is made of are not deterministic.
198
199         * platform/network/FormDataBuilder.cpp: (WebCore::FormDataBuilder::generateUniqueBoundaryString):
200         Don't ever put a '+' in boundary string, either. Removed a FIXME to bring '/' back once
201         GMail is fixed - I don't think we'll ever want to allow non-alphanumeric characters, as
202         they cause problems on many web sites.
203
204 2009-10-30  Alexey Proskuryakov  <ap@apple.com>
205
206         Reviewed by Darin Adler.
207
208         https://bugs.webkit.org/show_bug.cgi?id=30969
209         A no-prefix XPath node test should not match no-namespace elements in HTML document
210
211         Test: fast/xpath/null-namespace-in-html.html
212
213         * xml/XPathStep.cpp: (WebCore::XPath::nodeMatchesBasicTest): Special case non-HTML elements
214         in HTML documents (as these are the ones that can have null namespace).
215
216 2009-11-02  Pavel Feldman  <pfeldman@chromium.org>
217
218         Reviewed by Timothy Hatcher.
219
220         Web Inspector: [REGRESSION] No timeline marks on resources panel.
221
222         https://bugs.webkit.org/show_bug.cgi?id=31013
223
224         * inspector/front-end/AbstractTimelinePanel.js:
225         (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
226
227 2009-11-02  David Levin  <levin@chromium.org>
228
229         Reviewed by Dan Bernstein.
230
231         Possible crash in RenderSlider::layout.
232         https://bugs.webkit.org/show_bug.cgi?id=31016
233
234         Fix out of place line of code.
235
236         Test: scrollbars/overflow-scrollbar-combinations.html
237         This crash only seems to repro when WebKit draws the play controls,
238         so the crash repros in chromium running this test but not WebKit
239         nightlies which use QuickTime to draw the controls.
240
241         * rendering/RenderSlider.cpp:
242         (WebCore::RenderSlider::layout):
243
244 2009-11-02  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
245
246         Reviewed by Tor Arne Vestbø.
247
248         [Qt] Fix Qt build on Windows.
249         https://bugs.webkit.org/show_bug.cgi?id=30905
250
251         * WebCore.pro:
252         * platform/graphics/BitmapImage.h:
253         * platform/graphics/qt/ImageQt.cpp:
254         (WebCore::BitmapImage::BitmapImage):
255         (WebCore::BitmapImage::create):
256
257 2009-11-02  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
258
259         Reviewed by Adam Barth.
260
261         QWebView crash fix.
262
263         The QWebView should not crash if the stop() method is called from
264         a function triggered by the loadProgress signal.
265
266         A null pointer protection was added in the ProgressTracker::incrementProgress.
267
268         New autotest was created.
269
270         https://bugs.webkit.org/show_bug.cgi?id=29425
271
272         * loader/ProgressTracker.cpp:
273         (WebCore::ProgressTracker::incrementProgress):
274
275 2009-11-02  Mikhail Naganov  <mnaganov@chromium.org>
276
277         Reviewed by Pavel Feldman.
278
279         Fix a leftover from profiles panel generalization.
280
281         https://bugs.webkit.org/show_bug.cgi?id=31010
282
283         * inspector/front-end/ProfilesPanel.js:
284         (WebInspector.ProfilesPanel.prototype.get searchableViews):
285
286 2009-11-02  Kai Koehne  <kai.koehne@nokia.com>
287
288         Reviewed by Holger Freyther.
289
290         Remove implementation of ImageDecocerQt::clearFrameBufferCache.
291         The implementation was buggy, and will visually break repeating
292         animations anyway.
293
294         https://bugs.webkit.org/show_bug.cgi?id=31009
295
296         * platform/graphics/qt/ImageDecoderQt.cpp:
297         (WebCore::ImageDecoderQt::clearFrameBufferCache):
298
299 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
300
301         Reviewed by Jan Alonzo.
302
303         https://bugs.webkit.org/show_bug.cgi?id=30964
304         [Gtk] Implemment AtkDocument
305
306         Provides access to the reported content language.
307
308         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
309         (webkit_accessible_document_get_locale):
310
311 2009-11-02  Keishi Hattori  <casey.hattori@gmail.com>
312
313         Reviewed by Timothy Hatcher.
314
315         Web Inspector: Rewrite CSSSourceSyntaxHighlighter so it shares more code
316         https://bugs.webkit.org/show_bug.cgi?id=30907
317
318         Test: inspector/css-syntax-highlight.html
319
320         * inspector/front-end/ElementsTreeOutline.js:
321         * inspector/front-end/SourceFrame.js:
322         (WebInspector.SourceFrame.prototype.syntaxHighlightCSS):
323         (WebInspector.SourceSyntaxHighlighter):
324         (WebInspector.SourceSyntaxHighlighter.prototype.process.processChunk):
325         (WebInspector.SourceSyntaxHighlighter.prototype.process.moveToNextLine):
326         (WebInspector.SourceSyntaxHighlighter.prototype.process):
327         (WebInspector.SourceSyntaxHighlighter.prototype.lex):
328         (WebInspector.SourceSyntaxHighlighter.prototype.appendNonToken):
329         (WebInspector.SourceSyntaxHighlighter.prototype.syntaxHighlightNode):
330         (WebInspector.CSSSourceSyntaxHighlighter):
331         * inspector/front-end/inspectorSyntaxHighlight.css:
332
333 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
334
335         Reviewed by Beth Dakin.
336
337         Support ARIA "tab" roles
338         https://bugs.webkit.org/show_bug.cgi?id=30842
339
340         Implement support for ARIA "tab", "tabpanel" and "tablist".
341         As a consequence, we also needed to implement aria-selected
342         and aria-controls.
343
344         Tests: accessibility/aria-controls-with-tabs.html
345                accessibility/aria-tab-roles.html
346
347         * accessibility/AXObjectCache.cpp:
348         * accessibility/AccessibilityObject.h:
349         * accessibility/AccessibilityRenderObject.cpp:
350         * accessibility/AccessibilityRenderObject.h:
351         * accessibility/mac/AccessibilityObjectWrapper.mm:
352         * html/HTMLAttributeNames.in:
353
354 2009-10-27  Stephen White  <senorblanco@chromium.org>
355
356         Reviewed by Dmitry Titov.
357
358         This is the WebKit-side change needed to fix canvas.getImageData() for
359         Chromium.  The unpremultiply code in Skia assumes that unpremultiplied
360         values should be rounded, while CG does not.  In addition, the fixed
361         point inversion used by Skia introduces slight inaccuracies that make
362         us fail this test.  This change brings Chromium in line with
363         the CG path.
364         https://bugs.webkit.org/show_bug.cgi?id=30825
365
366         Covered by LayoutTests/fast/canvas/canvas-getImageData.html
367
368         * platform/graphics/skia/ImageBufferSkia.cpp:
369         (WebCore::getImageData):
370
371 2009-11-01  Kelly Norton  <knorton@google.com>
372
373         Reviewed by Timothy Hatcher.
374
375         Adds window event dispatches to InspectorTimelineAgent.
376         https://bugs.webkit.org/show_bug.cgi?id=31002
377
378         * English.lproj/localizedStrings.js:
379         * dom/Node.cpp: Updated call site to willDispatchEvent and didDispatchEvent.
380         (WebCore::Node::dispatchGenericEvent):
381         * inspector/InspectorTimelineAgent.cpp:
382         (WebCore::InspectorTimelineAgent::willDispatchEvent): Renamed.
383         (WebCore::InspectorTimelineAgent::didDispatchEvent): Renamed.
384         * inspector/InspectorTimelineAgent.h:
385         (WebCore::):
386         * inspector/TimelineRecordFactory.cpp:
387         (WebCore::TimelineRecordFactory::createEventDispatchRecord): Renamed.
388         * inspector/TimelineRecordFactory.h:
389         * inspector/front-end/TimelineAgent.js:
390         * inspector/front-end/TimelinePanel.js:
391         (WebInspector.TimelinePanel.prototype._formatRecord):
392         (WebInspector.TimelinePanel.prototype._getRecordDetails):
393         * page/DOMWindow.cpp:
394         (WebCore::DOMWindow::dispatchEvent):
395
396 2009-11-01  Pavel Feldman  <pfeldman@chromium.org>
397
398         Reviewed by Timothy Hatcher.
399
400         Web Inspector: Convert script tag event into a more generic
401         script eval event in timeline.
402
403         https://bugs.webkit.org/show_bug.cgi?id=30999
404
405         * bindings/js/ScriptController.cpp:
406         (WebCore::ScriptController::evaluateInWorld):
407         * bindings/v8/V8Proxy.cpp:
408         (WebCore::V8Proxy::evaluate):
409         * html/HTMLTokenizer.cpp:
410         (WebCore::HTMLTokenizer::scriptExecution):
411         * inspector/InspectorTimelineAgent.cpp:
412         (WebCore::InspectorTimelineAgent::willEvaluateScript):
413         (WebCore::InspectorTimelineAgent::didEvaluateScript):
414         * inspector/InspectorTimelineAgent.h:
415         (WebCore::):
416         * inspector/TimelineRecordFactory.cpp:
417         (WebCore::TimelineRecordFactory::createEvaluateScriptTimelineRecord):
418         * inspector/TimelineRecordFactory.h:
419         * inspector/front-end/TimelineAgent.js:
420         * inspector/front-end/TimelinePanel.js:
421         (WebInspector.TimelinePanel.prototype._formatRecord):
422         (WebInspector.TimelinePanel.prototype._getRecordDetails):
423
424 2009-11-01  Brian Weinstein  <bweinstein@apple.com>
425
426         Rubber-stamped by Mark Rowe.
427
428         Fix for loop to use an size_t instead of unsigned and some spacing
429         style fixes.
430
431         * dom/Node.cpp:
432         (WebCore::eventHasListeners):
433
434 2009-11-01  Kelly Norton  <knorton@google.com>
435
436         Reviewed by Timothy Hatcher.
437
438         Does not send DOM dispatches to the InspectorTimelineAgent if there
439         are no event listeners.
440         https://bugs.webkit.org/show_bug.cgi?id=30995
441
442         * dom/Node.cpp:
443         (WebCore::eventHasListeners):
444         (WebCore::Node::dispatchGenericEvent):
445         * xml/XMLHttpRequest.cpp:
446         (WebCore::XMLHttpRequest::callReadyStateChangeListener):
447
448 2009-11-01  Roland Steiner  <rolandsteiner@chromium.org>
449
450         No review (build fix).
451
452         Add missing files for Ruby implementation to WebCore.vcproj
453         (Fix build break after 50397)
454         https://bugs.webkit.org/show_bug.cgi?id=31001
455
456         No new tests. (No functional change)
457
458         * WebCore.vcproj/WebCore.vcproj:
459
460 2009-11-02  Roland Steiner  <rolandsteiner@chromium.org>
461
462         Reviewed by Dave Hyatt.
463
464         Bug 28420 -  Implement HTML5 <ruby> rendering
465         (https://bugs.webkit.org/show_bug.cgi?id=28420)
466
467         First rudimentary implementation of HTML5 ruby rendering support.
468
469         Following the HTML 5 spec, the box object model for a <ruby> element allows several runs of ruby
470         bases with their respective ruby texts looks as follows:
471
472         1 RenderRuby object, corresponding to the whole <ruby> HTML element
473              1+ RenderRubyRun (anonymous)
474                  0 or 1 RenderRubyText - shuffled to the front in order to re-use existing block layouting
475                      0-n inline object(s)
476                  0 or 1 RenderRubyBase - contains the inline objects that make up the ruby base
477                      1-n inline object(s)
478
479         Note: <rp> elements are defined as having 'display:none' and thus normally are not assigned a renderer.
480         
481         New layout tests will be committed in a follow-up patch under fast/ruby.
482
483         Makefiles, etc.
484         * GNUmakefile.am:
485         * WebCore.gypi:
486         * WebCore.pro:
487         * WebCore.xcodeproj/project.pbxproj:
488
489         CSS
490         * css/html.css: Added <ruby> and <rt>
491
492         Existing render files:
493         * rendering/RenderBlock.cpp: make moveChild a member function moveChildTo
494         (WebCore::RenderBlock::moveChildTo):
495         (WebCore::RenderBlock::makeChildrenNonInline):
496         (WebCore::RenderBlock::removeChild):
497         * rendering/RenderBlock.h:
498         * rendering/RenderObject.cpp:
499         (WebCore::RenderObject::createObject): instantiate ruby renderers based on element name
500         * rendering/RenderObject.h: add query methods for ruby renderers
501         (WebCore::RenderObject::isRuby):
502         (WebCore::RenderObject::isRubyBase):
503         (WebCore::RenderObject::isRubyRun):
504         (WebCore::RenderObject::isRubyText):
505
506         New ruby renderers:
507         * rendering/RenderRuby.cpp: Added.
508         (WebCore::lastRubyRun):
509         (WebCore::findRubyRunParent):
510         (WebCore::RenderRubyAsInline::RenderRubyAsInline):
511         (WebCore::RenderRubyAsInline::~RenderRubyAsInline):
512         (WebCore::RenderRubyAsInline::isChildAllowed):
513         (WebCore::RenderRubyAsInline::addChild):
514         (WebCore::RenderRubyAsInline::removeChild):
515         (WebCore::RenderRubyAsBlock::RenderRubyAsBlock):
516         (WebCore::RenderRubyAsBlock::~RenderRubyAsBlock):
517         (WebCore::RenderRubyAsBlock::isChildAllowed):
518         (WebCore::RenderRubyAsBlock::addChild):
519         (WebCore::RenderRubyAsBlock::removeChild):
520         * rendering/RenderRuby.h: Added.
521         (WebCore::RenderRubyAsInline::renderName):
522         (WebCore::RenderRubyAsInline::isRuby):
523         (WebCore::RenderRubyAsBlock::renderName):
524         (WebCore::RenderRubyAsBlock::isRuby):
525         * rendering/RenderRubyBase.cpp: Added.
526         (WebCore::RenderRubyBase::RenderRubyBase):
527         (WebCore::RenderRubyBase::~RenderRubyBase):
528         (WebCore::RenderRubyBase::isChildAllowed):
529         (WebCore::RenderRubyBase::splitToLeft):
530         (WebCore::RenderRubyBase::mergeWithRight):
531         * rendering/RenderRubyBase.h: Added.
532         (WebCore::RenderRubyBase::renderName):
533         (WebCore::RenderRubyBase::isRubyBase):
534         * rendering/RenderRubyRun.cpp: Added.
535         (WebCore::RenderRubyRun::RenderRubyRun):
536         (WebCore::RenderRubyRun::~RenderRubyRun):
537         (WebCore::RenderRubyRun::hasRubyText):
538         (WebCore::RenderRubyRun::hasRubyBase):
539         (WebCore::RenderRubyRun::isEmpty):
540         (WebCore::RenderRubyRun::rubyText):
541         (WebCore::RenderRubyRun::rubyBase):
542         (WebCore::RenderRubyRun::rubyBaseSafe):
543         (WebCore::RenderRubyRun::firstLineBlock):
544         (WebCore::RenderRubyRun::updateFirstLetter):
545         (WebCore::RenderRubyRun::isChildAllowed):
546         (WebCore::RenderRubyRun::addChild):
547         (WebCore::RenderRubyRun::removeChild):
548         (WebCore::RenderRubyRun::createRubyBase):
549         (WebCore::RenderRubyRun::staticCreateRubyRun):
550         * rendering/RenderRubyRun.h: Added.
551         (WebCore::RenderRubyRun::renderName):
552         (WebCore::RenderRubyRun::isRubyRun):
553         * rendering/RenderRubyText.cpp: Added.
554         (WebCore::RenderRubyText::RenderRubyText):
555         (WebCore::RenderRubyText::~RenderRubyText):
556         (WebCore::RenderRubyText::isChildAllowed):
557         * rendering/RenderRubyText.h: Added.
558         (WebCore::RenderRubyText::renderName):
559         (WebCore::RenderRubyText::isRubyText):
560
561 2009-11-01  Alexey Proskuryakov  <ap@apple.com>
562
563         Reviewed by Dan Bernstein.
564
565         https://bugs.webkit.org/show_bug.cgi?id=30992
566         Node.isDefaultNamespace doesn't convert empty strings to null
567
568         Test: fast/dom/Node/default-namespace-empty-argument.html
569
570         * dom/Node.cpp: (WebCore::Node::isDefaultNamespace): Per DOM 3 Core, treat empty input
571         as null.
572
573 2009-11-01  Yael Aharon  <yael.aharon@nokia.com>
574
575         Reviewed by Darin Adler.
576
577         Don't add '/' to the URL path if the it does not include '/' after the protocol component
578         https://bugs.webkit.org/show_bug.cgi?id=30971
579
580         Match IE8 behaviour, that does not add '/' if there is none after the protocol component.
581
582         * platform/KURL.cpp:
583         (WebCore::KURL::parse):
584
585 2009-10-31  Oliver Hunt  <oliver@apple.com>
586
587         Reviewed by Darin Adler.
588
589         Fix layering violations in GraphicsContext3D
590         https://bugs.webkit.org/show_bug.cgi?id=30986
591
592         Remove uses of HTMLImageElement and HTMLCanvasElement
593
594         * html/canvas/CanvasRenderingContext3D.cpp:
595         (WebCore::CanvasRenderingContext3D::texImage2D):
596         (WebCore::CanvasRenderingContext3D::texSubImage2D):
597         * platform/graphics/GraphicsContext3D.h:
598         * platform/graphics/mac/GraphicsContext3DMac.cpp:
599         (WebCore::GraphicsContext3D::texImage2D):
600         (WebCore::GraphicsContext3D::texSubImage2D):
601
602 2009-11-01  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
603
604         Reviewed by Jan Alonzo.
605
606         https://bugs.webkit.org/show_bug.cgi?id=30964
607         [Gtk] Implemment AtkDocument
608
609         Implements what has been implemented in AT-SPI.
610
611         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
612         (GetAtkInterfaceTypeFromWAIType):
613         (getInterfaceMaskFromObject):
614         (atk_document_interface_init):
615         (webkit_accessible_document_get_document_attribute_value):
616         (webkit_accessible_document_get_document_attributes):
617         (webkit_accessible_document_get_locale):
618
619 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
620
621         Reviewed by Eric Seidel.
622
623         Turn on warnings for QtWebKit for gcc
624         https://bugs.webkit.org/show_bug.cgi?id=30958
625
626         No new tests as there is no functional change.
627
628         * platform/image-decoders/qt/RGBA32BufferQt.cpp:
629         (WebCore::RGBA32Buffer::RGBA32Buffer): Reorder 
630         initialization list to fix compiler warnings.
631
632
633 2009-11-01  Keishi Hattori  <casey.hattori@gmail.com>
634
635         Reviewed by Pavel Feldman.
636
637         [Regression] monitorEvent doesn't work
638
639         * inspector/front-end/InjectedScript.js:
640         (InjectedScript._ensureCommandLineAPIInstalled):
641
642 2009-11-01  Keishi Hattori  <casey.hattori@gmail.com>
643
644         Reviewed by Pavel Feldman.
645
646         Fix Web Inspector: Bug with Message Bubble in Syntax Highlighter
647         https://bugs.webkit.org/show_bug.cgi?id=30990
648
649         * inspector/front-end/SourceFrame.js:
650
651 2009-10-31  Alexey Proskuryakov  <ap@apple.com>
652
653         Reviewed by John Sullivan.
654
655         https://bugs.webkit.org/show_bug.cgi?id=30982
656         createHTMLDocument doesn't escape ampersand and less-than in title
657
658         Test: fast/dom/DOMImplementation/createHTMLDocument-title.html
659
660         * dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createHTMLDocument):
661         Set document title after creating the document, avoiding parser intricacies.
662
663 2009-11-01  Keishi Hattori  <casey.hattori@gmail.com>
664
665         Reviewed by Timothy Hatcher.
666
667         Web Inspector: Double clicking on a breakpoints should not select text
668         https://bugs.webkit.org/show_bug.cgi?id=30950
669
670         * inspector/front-end/SourceFrame.js:
671         (WebInspector.SourceFrame.prototype._documentMouseDown):
672
673 2009-11-01  Yuta Kitamura  <yutak@chromium.org>
674
675         Reviewed by Darin Adler.
676
677         Fix assertion falure in RenderObjectChildList::updateBeforeAfterContent().
678
679         [Crash (debug)] Combination of list-item and :after causes assertion failure
680         https://bugs.webkit.org/show_bug.cgi?id=30944
681
682         Test: fast/css/list-item-pseudo-nocrash.html
683
684         * rendering/RenderObjectChildList.cpp:
685         (WebCore::RenderObjectChildList::updateBeforeAfterContent):
686
687 2009-11-01  Philippe Normand  <pnormand@igalia.com>
688
689         Reviewed by Eric Seidel.
690
691         https://bugs.webkit.org/show_bug.cgi?id=30586
692         [GTK] Failing test media/video-src-empty.html
693
694         Correctly set network/ready state depending on GStreamer errors
695         received on the bus.
696
697         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
698         (WebCore::mediaPlayerPrivateMessageCallback):
699
700 2009-10-31  Oliver Hunt  <oliver@apple.com>
701
702         Build fix
703
704         * platform/graphics/mac/GraphicsContext3DMac.cpp:
705         (WebCore::GraphicsContext3D::attachShader):
706
707 2009-10-31  Oliver Hunt  <oliver@apple.com>
708
709         Reviewed by Darin Adler.
710
711         Remove obsolete null checks from CanvasRenderingContext3DMac
712         https://bugs.webkit.org/show_bug.cgi?id=30983
713
714         * platform/graphics/mac/GraphicsContext3DMac.cpp:
715         (WebCore::GraphicsContext3D::attachShader):
716         (WebCore::GraphicsContext3D::bindAttribLocation):
717         (WebCore::GraphicsContext3D::compileShader):
718         (WebCore::GraphicsContext3D::detachShader):
719         (WebCore::GraphicsContext3D::framebufferRenderbuffer):
720         (WebCore::GraphicsContext3D::framebufferTexture2D):
721         (WebCore::GraphicsContext3D::linkProgram):
722         (WebCore::GraphicsContext3D::shaderSource):
723         (WebCore::GraphicsContext3D::useProgram):
724         (WebCore::GraphicsContext3D::validateProgram):
725         (WebCore::GraphicsContext3D::getProgramInfoLog):
726         (WebCore::GraphicsContext3D::getShaderi):
727         (WebCore::GraphicsContext3D::getShaderiv):
728         (WebCore::GraphicsContext3D::getShaderInfoLog):
729         (WebCore::GraphicsContext3D::getShaderSource):
730         (WebCore::GraphicsContext3D::getUniformLocation):
731
732 2009-10-31  Oliver Hunt  <oliver@apple.com>
733
734         Reviewed by Jon Honeycutt.
735
736         WebGL allows objects to be used with the wrong context
737         https://bugs.webkit.org/show_bug.cgi?id=30981
738
739         Simply add null checks and a few context guards to ensure we don't
740         deref null or attempt to use an object from a different context.
741
742         Tests: fast/canvas/webgl/incorrect-context-object-behaviour.html
743                fast/canvas/webgl/null-object-behaviour.html
744
745         * html/canvas/CanvasRenderingContext3D.cpp:
746         (WebCore::CanvasRenderingContext3D::attachShader):
747         (WebCore::CanvasRenderingContext3D::bindAttribLocation):
748         (WebCore::CanvasRenderingContext3D::bindBuffer):
749         (WebCore::CanvasRenderingContext3D::bindFramebuffer):
750         (WebCore::CanvasRenderingContext3D::bindRenderbuffer):
751         (WebCore::CanvasRenderingContext3D::bindTexture):
752         (WebCore::CanvasRenderingContext3D::compileShader):
753         (WebCore::CanvasRenderingContext3D::detachShader):
754         (WebCore::CanvasRenderingContext3D::framebufferRenderbuffer):
755         (WebCore::CanvasRenderingContext3D::framebufferTexture2D):
756         (WebCore::CanvasRenderingContext3D::getProgrami):
757         (WebCore::CanvasRenderingContext3D::getProgramiv):
758         (WebCore::CanvasRenderingContext3D::getProgramInfoLog):
759         (WebCore::CanvasRenderingContext3D::getShaderi):
760         (WebCore::CanvasRenderingContext3D::getShaderiv):
761         (WebCore::CanvasRenderingContext3D::getShaderInfoLog):
762         (WebCore::CanvasRenderingContext3D::getShaderSource):
763         (WebCore::CanvasRenderingContext3D::getUniformf):
764         (WebCore::CanvasRenderingContext3D::getUniformfv):
765         (WebCore::CanvasRenderingContext3D::getUniformi):
766         (WebCore::CanvasRenderingContext3D::getUniformiv):
767         (WebCore::CanvasRenderingContext3D::getUniformLocation):
768         (WebCore::CanvasRenderingContext3D::isBuffer):
769         (WebCore::CanvasRenderingContext3D::linkProgram):
770         (WebCore::CanvasRenderingContext3D::shaderSource):
771         * html/canvas/CanvasRenderingContext3D.h:
772         * html/canvas/CanvasRenderingContext3D.idl:
773
774 2009-10-30  Zoltan Horvath  <zoltan@webkit.org>
775
776         Reviewed by Darin Adler.
777
778         Allow custom memory allocation control for WebCore's MediaQueryResult
779         https://bugs.webkit.org/show_bug.cgi?id=30857
780
781         Inherits MediaQueryResult class from Noncopyable because it is
782         instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:5984 and
783         it is no need to be copyable.
784
785         * css/CSSStyleSelector.h:
786
787 2009-10-30  Zoltan Horvath  <zoltan@webkit.org>
788
789         Reviewed by Darin Adler.
790
791         Allow custom memory allocation control for WebCore's MediaQueryEvaluator
792         https://bugs.webkit.org/show_bug.cgi?id=30854
793
794         Inherits MediaQueryEvaluator class from Noncopyable because it is
795         instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:401 and   
796         it is no need to be copyable.
797
798         * css/MediaQueryEvaluator.h:
799
800 2009-10-30  Zoltan Horvath  <zoltan@webkit.org>
801
802         Reviewed by Darin Adler.
803
804         Allow custom memory allocation control for WebCore's CSSRuleSet
805         https://bugs.webkit.org/show_bug.cgi?id=30852
806
807         Inherits CSSRuleSet class from Noncopyable because it is
808         instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:455 and
809         it is no need to be copyable.
810
811         * css/CSSStyleSelector.cpp:
812
813 2009-10-30  Zoltan Horvath  <zoltan@webkit.org>
814
815         Reviewed by Darin Adler.
816
817         Allow custom memory allocation control for WebCore's CSSRuleData
818         https://bugs.webkit.org/show_bug.cgi?id=30851
819
820         Inherits CSSRuleData class from Noncopyable because it is
821         instantiated by 'new' in WebCore/css/CSSStyleSelector.h:320 and
822         it is no need to be copyable.
823
824         * css/CSSStyleSelector.h:
825
826 2009-10-30  Zoltan Horvath  <zoltan@webkit.org>
827
828         Reviewed by Darin Adler.
829
830         Allow custom memory allocation control for WebCore's CSSRuleDataList
831         https://bugs.webkit.org/show_bug.cgi?id=30850
832
833         Inherits CSSRuleDataList class from Noncopyable because it has been
834         instantiated by 'new' in WebCore/css/CSSStyleSelector.cpp:2715 and
835         it is no need to be copyable.
836
837         * css/CSSStyleSelector.h:
838
839 2009-10-30  Zoltan Horvath  <zoltan@webkit.org>
840
841         Reviewed by Darin Adler.
842
843         Allow custom memory allocation control for WebCore's CSSNamespace
844         https://bugs.webkit.org/show_bug.cgi?id=30849
845
846         Inherits CSSNamespace struct from Noncopyable because it is
847         instantiated by 'new' in WebCore/css/CSSStyleSheet.cpp:141 and
848         it is no need to be copyable.
849
850         * css/CSSNamespace.h:
851
852 2009-10-30  Dmitry Titov  <dimich@chromium.org>
853
854         Reviewed by David Levin.
855
856         Refactor DatabaseTask in preparation for removing threadsafe refcounting from it.
857         Move the synchronizer object out of the DatabaseTask so there is no need to keep
858         the pointer to Databasetask around after passing it to MessageQueue.
859         Also pass the references to return parameters to the task so it can update them.
860         https://bugs.webkit.org/show_bug.cgi?id=30941
861
862         No new tests, since this is just moving the code around, no change in functionality.
863
864         * storage/Database.cpp:
865         (WebCore::Database::Database):
866         (WebCore::Database::openAndVerifyVersion): Use new DatabaseTaskSynchronizer to wait for task completion.
867         (WebCore::Database::markAsDeletedAndClose): Ditto.
868         (WebCore::Database::tableNames): Ditto.
869         (WebCore::Database::stop): Use the boolean flag rather then 'killed' flag built into MessageQueue.
870         (WebCore::Database::scheduleTransaction): Transaction queue is a Deque now, change the way to fetch the transaction.
871         * storage/Database.h: Change the SQLTransaction queue to be a Deque rather then a MessageQueue.
872         * storage/DatabaseTask.cpp:
873         (WebCore::DatabaseTaskSynchronizer::DatabaseTaskSynchronizer):
874         (WebCore::DatabaseTaskSynchronizer::waitForTaskCompletion):
875         (WebCore::DatabaseTaskSynchronizer::taskCompleted):
876         (WebCore::DatabaseTask::DatabaseTask): Ctor takes DatabaseTaskSynchronizer which can be 0.
877         (WebCore::DatabaseTask::performTask): Signal completion. m_synchronizer should still be around since main thread is waiting on it.
878         (WebCore::DatabaseOpenTask::DatabaseOpenTask): Pass synchronizer and return parameters via constructor.
879         (WebCore::DatabaseCloseTask::DatabaseCloseTask): Ditto.
880         (WebCore::DatabaseTransactionTask::DatabaseTransactionTask): Ditto.
881         (WebCore::DatabaseTableNamesTask::DatabaseTableNamesTask): Ditto.
882         * storage/DatabaseTask.h:
883         (WebCore::DatabaseOpenTask::create):
884         (WebCore::DatabaseCloseTask::create):
885         (WebCore::DatabaseTransactionTask::create):
886         (WebCore::DatabaseTableNamesTask::create):
887
888 2009-10-30  Enrica Casucci  <enrica@apple.com>
889
890         Reviewed by Darin Adler.
891
892         REGRESSION: In Mail, Undo does not restore some characters I have deleted at the end of a line
893         https://bugs.webkit.org/show_bug.cgi?id=30955
894         <rdar://problem/7067033>
895         
896         When the command is deleteWordBackward or deleteWordForward
897         we should not add to the open typing command, but
898         create a new one.
899         
900         Test: editing/undo/undo-deleteWord.html
901
902         * editing/TypingCommand.cpp:
903         (WebCore::TypingCommand::deleteKeyPressed): Always start a new command if the granularity is
904         not CharacterGranularity. 
905         (WebCore::TypingCommand::forwardDeleteKeyPressed): Always start a new command if the granularity is
906         not CharacterGranularity. 
907
908 2009-10-30  Eric Carlson  <eric.carlson@apple.com>
909
910         Reviewed by Darin Adler.
911
912         Make MediaPlayer constructor private
913         https://bugs.webkit.org/show_bug.cgi?id=30965
914
915         * html/HTMLMediaElement.cpp:
916         (WebCore::HTMLMediaElement::loadResource): 
917         (WebCore::HTMLMediaElement::finishParsingChildren): Use MediaPlayer::create.
918
919         * platform/graphics/MediaPlayer.h:
920         (WebCore::MediaPlayer::create): New.
921
922 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
923
924         MSAA: Accessibility of headings is not correct
925
926         https://bugs.webkit.org/show_bug.cgi?id=30937
927
928         Reviewed by Alice Liu.
929
930         * accessibility/AccessibilityObject.h:
931         (WebCore::AccessibilityObject::stringRoleForMSAA):
932         (WebCore::AccessibilityObject::descriptionForMSAA):
933
934         * accessibility/AccessibilityRenderObject.cpp:
935         (WebCore::shouldReturnTagNameAsRoleForMSAA):
936         If the element's tag name is one of h1, h2, h3, h4, h5, h6, return
937         true.
938         (WebCore::AccessibilityRenderObject::stringRoleForMSAA):
939         If the element should return its tag name as the role, return the tag
940         name.
941         (WebCore::AccessibilityRenderObject::positionalDescriptionForMSAA):
942         If the object is a heading, return the string "L" followed by the
943         heading level.
944         (WebCore::AccessibilityRenderObject::descriptionForMSAA):
945         If the object has a positional description, return it. Otherwise, get
946         the accessibility description, and prefix it with "Description" so that
947         MSAA clients know that it's not a positional description.
948
949         * accessibility/AccessibilityRenderObject.h:
950
951 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
952
953         MSAA: Accessibility of links is wrong
954
955         https://bugs.webkit.org/show_bug.cgi?id=30928
956
957         Reviewed by Darin Adler.
958
959         * accessibility/AccessibilityImageMapLink.cpp:
960         (WebCore::AccessibilityImageMapLink::stringValueForMSAA):
961         Return the URL.
962         (WebCore::AccessibilityImageMapLink::nameForMSAA):
963         Return the alt text.
964
965         * accessibility/AccessibilityImageMapLink.h:
966         (WebCore::AccessibilityImageMapLink::isLinked):
967         Return true.
968
969         * accessibility/AccessibilityObject.h:
970         (WebCore::AccessibilityObject::isLinked):
971         (WebCore::AccessibilityObject::stringValueForMSAA):
972         (WebCore::AccessibilityObject::nameForMSAA):
973
974         * accessibility/AccessibilityRenderObject.cpp:
975         (WebCore::isLinkable):
976         Return true if the element is considered "linkable" with respect to
977         accessibility.
978         (WebCore::AccessibilityRenderObject::stringValueForMSAA):
979         If the element is linkable, check whether it has a parent anchor
980         element. If so, return the anchor element's href.
981         (WebCore::AccessibilityRenderObject::isLinked):
982         Return true if the element is linkable and if it's parent anchor tag's
983         href is non-empty.
984         (WebCore::AccessibilityRenderObject::nameForMSAA):
985         For text nodes, return the text.
986
987         * accessibility/AccessibilityRenderObject.h:
988
989 2009-10-30  Evan Stade  <estade@chromium.org>
990
991         Reviewed by David Levin.
992
993         Notify the chrome when the focused node has changed.
994         https://bugs.webkit.org/show_bug.cgi?id=30832
995
996         This is similar to AX code that is already in place, except that this also informs the
997         chrome when there stops being a focused node. This is needed for a browser to show the
998         anchor for links that have keyboard focus.
999
1000         * dom/Document.cpp:
1001         (WebCore::Document::setFocusedNode):
1002         * loader/EmptyClients.h:
1003         (WebCore::EmptyChromeClient::focusedNodeChanged):
1004         * page/Chrome.cpp:
1005         (WebCore::Chrome::focusedNodeChanged):
1006         * page/Chrome.h:
1007         * page/ChromeClient.h:
1008
1009 2009-10-30  Ben Murdoch  <benm@google.com>
1010
1011         Reviewed by David Kilzer.
1012
1013         openDatabase() with empty version sets db version up incorrectly
1014         https://bugs.webkit.org/show_bug.cgi?id=28417
1015
1016         Test: storage/open-database-set-empty-version.html
1017
1018         * storage/Database.cpp:
1019         (WebCore::Database::performOpenAndVerify): Raise an exception if the current database version does not match the expected version when the current version is the empty string.
1020
1021 2009-10-30  John Gregg  <johnnyg@google.com>
1022
1023         Reviewed by David Levin.
1024
1025         Need to turn off notifications properly at runtime
1026         https://bugs.webkit.org/show_bug.cgi?id=30409
1027
1028         Moving the notificationsEnabled bit from NotificationCenter
1029         to the new V8 RuntimeEnabledFeatures object.
1030
1031         Just moving a bit around, so no new tests.
1032
1033         * bindings/v8/RuntimeEnabledFeatures.cpp:
1034         * bindings/v8/RuntimeEnabledFeatures.h:
1035         (WebCore::RuntimeEnabledFeatures::setNotificationsEnabled):
1036         (WebCore::RuntimeEnabledFeatures::notificationsEnabled):
1037         * bindings/v8/custom/V8DOMWindowCustom.cpp:
1038         (WebCore::ACCESSOR_RUNTIME_ENABLER):
1039         * bindings/v8/custom/V8WorkerContextCustom.cpp:
1040         (WebCore::ACCESSOR_RUNTIME_ENABLER):
1041         * notifications/NotificationCenter.cpp:
1042         * notifications/NotificationCenter.h:
1043
1044 2009-10-30  Dmitry Titov  <dimich@chromium.org>
1045
1046         Reviewed by Dimitri Glazkov.
1047
1048         [V8] More cleanup after r49949: remove ListenerGuard.
1049         ListenerGuard is no longer needed since EventListeners do not depend on frame or v8 context.
1050         https://bugs.webkit.org/show_bug.cgi?id=30943
1051
1052         Covered by fast/events/add-event-without-document.html which will now pass in Chromium.
1053
1054         * bindings/v8/V8AbstractEventListener.cpp:
1055         (WebCore::V8AbstractEventListener::V8AbstractEventListener):
1056         (WebCore::V8AbstractEventListener::handleEvent):
1057         * bindings/v8/V8AbstractEventListener.h:
1058         * bindings/v8/V8DOMWrapper.cpp:
1059         (WebCore::V8DOMWrapper::getEventListener):
1060         * bindings/v8/V8EventListenerList.h:
1061         (WebCore::V8EventListenerList::findOrCreateWrapper):
1062         * bindings/v8/V8LazyEventListener.cpp:
1063         (WebCore::V8LazyEventListener::V8LazyEventListener):
1064         * bindings/v8/V8Proxy.cpp:
1065         (WebCore::V8Proxy::V8Proxy):
1066         (WebCore::V8Proxy::disconnectFrame):
1067         (WebCore::V8Proxy::clearForNavigation):
1068         * bindings/v8/V8Proxy.h:
1069         * bindings/v8/V8WorkerContextEventListener.cpp:
1070         (WebCore::V8WorkerContextEventListener::V8WorkerContextEventListener):
1071         (WebCore::V8WorkerContextEventListener::handleEvent):
1072         (WebCore::V8WorkerContextEventListener::reportError):
1073         * bindings/v8/V8WorkerContextEventListener.h:
1074         (WebCore::V8WorkerContextEventListener::create):
1075         * bindings/v8/WorkerContextExecutionProxy.cpp:
1076         (WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
1077         (WebCore::WorkerContextExecutionProxy::dispose):
1078         (WebCore::WorkerContextExecutionProxy::findOrCreateEventListener):
1079         * bindings/v8/WorkerContextExecutionProxy.h:
1080         * bindings/v8/custom/V8CustomEventListener.cpp:
1081         (WebCore::V8EventListener::V8EventListener):
1082         * bindings/v8/custom/V8CustomEventListener.h:
1083         (WebCore::V8EventListener::create):
1084
1085 2009-10-30  Shinichiro Hamaji  <hamaji@chromium.org>
1086
1087         Reviewed by Darin Adler.
1088
1089         counterValueForElementById should return space-separated string for multiple counters
1090         https://bugs.webkit.org/show_bug.cgi?id=30939
1091
1092         Test: fast/css/counters/counterValueForElementById.html
1093
1094         * rendering/RenderTreeAsText.cpp:
1095         (WebCore::writeCounterValuesFromChildren):
1096         (WebCore::counterValueForElement):
1097
1098 2009-10-30  Sebastian Dröge  <sebastian.droege@collabora.co.uk>
1099
1100         Reviewed by Gustavo Noronha.
1101
1102         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1103         (WebCore::MediaPlayerPrivate::paint):
1104         Add some comments to explain what is happening here.
1105
1106 2009-10-30  Alexander Pavlov  <apavlov@chromium.org>
1107
1108         Reviewed by Timothy Hatcher.
1109
1110         Fix Web Inspector crash on the errors/warnings counter click
1111
1112         RenderObject::createVisiblePosition(const Position& position)
1113         understands "null Positions", so we can construct such a Position manually.
1114
1115         https://bugs.webkit.org/show_bug.cgi?id=30499
1116
1117         * rendering/RenderBox.cpp:
1118         (WebCore::RenderBox::positionForPoint):
1119
1120 2009-10-30  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1121
1122         Reviewed by Xan Lopez.
1123
1124         https://bugs.webkit.org/show_bug.cgi?id=25534
1125         [GTK] Objects of ROLE_TABLE should implement the accessible table interface
1126
1127         Third part of the implementation of AtkTable.
1128
1129         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1130         (nameFromChildren):
1131         (webkit_accessible_get_name):
1132         New convenience function to construct an object's name using the name(s) of
1133         any children it has.
1134
1135         (atk_table_interface_init):
1136         (webkit_accessible_table_get_column_description):
1137         (webkit_accessible_table_get_row_description):
1138         Implemented.
1139
1140         (webkit_accessible_table_get_column_header):
1141         Stub function added so that webkit_accessible_table_get_column_description
1142         could be implemented in the meantime.
1143
1144 2009-10-30  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1145
1146         Reviewed by Xan Lopez.
1147
1148         https://bugs.webkit.org/show_bug.cgi?id=25534
1149         [GTK] Objects of ROLE_TABLE should implement the accessible table interface
1150
1151         Second part of the implementation of AtkTable.
1152
1153         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1154         (cellAtIndex):
1155         (webkit_accessible_table_get_column_at_index):
1156         (webkit_accessible_table_get_row_at_index):
1157         (webkit_accessible_table_get_caption):
1158         (atk_table_interface_init):
1159
1160 2009-10-30  Pavel Feldman  <pfeldman@chromium.org>
1161
1162         Reviewed by Timothy Hatcher.
1163
1164         Web Inspector: Add TimelinePanel into the panels enum.
1165
1166         https://bugs.webkit.org/show_bug.cgi?id=30915
1167
1168         * inspector/InspectorFrontend.cpp:
1169         (WebCore::InspectorFrontend::showPanel):
1170         * inspector/front-end/inspector.js:
1171         (WebInspector.showTimelinePanel):
1172
1173 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1174
1175         Reviewed by Holger Hans Peter Freyther.
1176
1177         If the owner widget of the page has a palette set, we
1178         should use that one. This was only working when the
1179         owner was a QWebView. This patch fixes that.
1180
1181         * platform/qt/RenderThemeQt.cpp:
1182         (WebCore::RenderThemeQt::applyTheme):
1183
1184 2009-10-30  Pavel Feldman  <pfeldman@chromium.org>
1185
1186         Not reviewed: Wire CookieJarChromium to the cookies
1187         backend. This is a final step of a 3-steps raw cookies
1188         access implementation in Chromium.
1189
1190         * platform/network/chromium/CookieJarChromium.cpp:
1191         (WebCore::getRawCookies):
1192         (WebCore::deleteCookie):
1193
1194 2009-10-30  Yury Semikhatsky  <yurys@chromium.org>
1195
1196         Reviewed by Pavel Feldman.
1197
1198         Fix Chromium crash in console.log in "deeply recursive" function 
1199
1200         Check that result of 'frameSourceName' is not null handle
1201         before casting it to String. 
1202       
1203         Allow V8Proxy::sourceName/sourceLineNumber() to report
1204         that they have failed due to JavaScript stack overflow.
1205
1206         https://bugs.webkit.org/show_bug.cgi?id=30904
1207
1208         * bindings/scripts/CodeGeneratorV8.pm:
1209         * bindings/v8/ScriptCallStack.cpp:
1210         (WebCore::ScriptCallStack::create):
1211         (WebCore::ScriptCallStack::ScriptCallStack):
1212         * bindings/v8/ScriptCallStack.h:
1213         * bindings/v8/V8Proxy.cpp:
1214         (WebCore::V8Proxy::sourceLineNumber):
1215         (WebCore::V8Proxy::sourceName):
1216         * bindings/v8/V8Proxy.h:
1217         * bindings/v8/custom/V8WorkerContextCustom.cpp:
1218         (WebCore::CALLBACK_FUNC_DECL):
1219
1220 2009-10-30  Zoltan Horvath  <zoltan@webkit.org>
1221
1222         Reviewed by Darin Adler.
1223
1224         Allow custom memory allocation control for WebCore's MediaQuery
1225         https://bugs.webkit.org/show_bug.cgi?id=30856
1226
1227         Inherits MediaQuery class from Noncopyable because it is
1228         instantiated by 'new' in WebCore/css/CSSParser.cpp:4905 and
1229         it is no need to be copyable.
1230
1231         * css/CSSStyleSelector.h:
1232
1233 2009-10-30  Zoltan Horvath  <zoltan@webkit.org>
1234
1235         Reviewed by Darin Adler.
1236
1237         Allow custom memory allocation control for WebCore's MediaQueryExp
1238         https://bugs.webkit.org/show_bug.cgi?id=30855
1239
1240         Inherits MediaQueryExp class from FastAllocBase because it is
1241         instantiated by 'new' in WebCore/css/CSSParser.cpp:4874.
1242
1243         * css/MediaQueryExp.h:
1244
1245 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
1246
1247         Reviewed by Eric Seidel.
1248
1249         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
1250
1251         Bug 28420 -  Implement HTML5 <ruby> rendering
1252         (https://bugs.webkit.org/show_bug.cgi?id=28420)
1253
1254         No new tests (no functional change).
1255
1256         * Configurations/FeatureDefines.xcconfig:
1257         * DerivedSources.make:
1258         * GNUmakefile.am:
1259         * WebCore.pro:
1260         * WebCore.vcproj/WebCoreCommon.vsprops:
1261         * WebCore.vcproj/build-generated-files.sh:
1262
1263 2009-10-30  Dan Bernstein  <mitz@apple.com>
1264
1265         Reviewed by Adele Peterson.
1266
1267         Removed test for an impossible condition (a glyph in a right-to-left run not having
1268         the RTL flag 0x800)
1269
1270         * platform/graphics/mac/ComplexTextControllerATSUI.cpp:
1271         (WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation):
1272
1273 2009-10-29  Adam Barth  <abarth@webkit.org>
1274
1275         Reviewed by Dimitri Glazkov.
1276
1277         [V8] Out-of-memory crash in isolated worlds
1278         https://bugs.webkit.org/show_bug.cgi?id=30906
1279
1280         We need to handle the fact that creating a V8:Context might fail.  I
1281         don't know how to test this change because creating a context usually
1282         only fails when V8 decides it's using too much memory.
1283
1284         * bindings/v8/V8IsolatedWorld.cpp:
1285         (WebCore::V8IsolatedWorld::V8IsolatedWorld):
1286         * bindings/v8/V8Proxy.cpp:
1287         (WebCore::V8Proxy::evaluateInIsolatedWorld):
1288         (WebCore::V8Proxy::evaluateInNewContext):
1289
1290 2009-10-29  Erik Arvidsson  <arv@chromium.org>
1291
1292         Reviewed by Eric Seidel.
1293
1294         Make links mouse focusable only on GTK and QT.
1295
1296         Links are now always mouse focusable on GTK and QT. On other platforms
1297         the link needs a tabIndex or it needs to be contentEditable.
1298
1299         https://bugs.webkit.org/show_bug.cgi?id=26856
1300
1301         * html/HTMLAnchorElement.cpp:
1302         (WebCore::HTMLAnchorElement::isMouseFocusable):
1303
1304 2009-10-29  Dan Bernstein  <mitz@apple.com>
1305
1306         Reviewed by Sam Weinig.
1307
1308         Complete the fix for hit-testing and selection highlighting in ligatures for the ATSUI
1309         code path.
1310
1311         * platform/graphics/mac/ComplexTextController.h: Added m_ltr member to ComplexTextRun.
1312         * platform/graphics/mac/ComplexTextControllerATSUI.cpp:
1313         (WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation): Skip over deleted
1314         glyphs, but update indexes and advances correctly.
1315         (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Initialize m_ltr.
1316
1317 2009-10-29  Enrica Casucci  <enrica@apple.com>
1318
1319         Reviewed by Darin Adler.
1320
1321         REGRESSION(3.2.3 - 4.0.2): Message composing: when I undo a color change to text in Mail, undo/redo behaves strangely
1322         <rdar://problem/7115041>
1323         https://bugs.webkit.org/show_bug.cgi?id=30892
1324
1325         This problem shows in any scenario where it is necessary to split a text
1326         node to apply a style. SplitElementCommand and WrapContentsInDummySpanCommand both
1327         have member variables initialized in the constructor to keep reference to elements
1328         they need to operate upon. These reference are not updated when reapplying the command.
1329         For this reason it is necessary to guarantee that unapply doesn not delete the references
1330         and that these commands implement doReapply to correctly reuse the existing
1331         elements.
1332
1333         Test: editing/undo/redo-style.html
1334
1335         * editing/SplitElementCommand.cpp:
1336         (WebCore::SplitElementCommand::executeApply): Added.
1337         (WebCore::SplitElementCommand::doApply): Modified to call executeApply. 
1338         (WebCore::SplitElementCommand::doUnapply): Doesn't release m_element1.
1339         (WebCore::SplitElementCommand::doReapply): Added.
1340         * editing/SplitElementCommand.h: Added doReapply and executeApply.
1341         * editing/WrapContentsInDummySpanCommand.cpp:
1342         (WebCore::WrapContentsInDummySpanCommand::executeApply): Added.
1343         (WebCore::WrapContentsInDummySpanCommand::doApply): Modified to call executeApply.
1344         (WebCore::WrapContentsInDummySpanCommand::doUnapply): Doesn't release m_dummySpan.
1345         (WebCore::WrapContentsInDummySpanCommand::doReapply): Added.
1346         * editing/WrapContentsInDummySpanCommand.h: Added doReapply and executeApply.
1347
1348 2009-10-29  Jeremy Orlow  <jorlow@chromium.org>
1349
1350         Reviewed by Darin Fisher.
1351
1352         DOM Storage's condition variable needs to handle spurious wakeups
1353         https://bugs.webkit.org/show_bug.cgi?id=30920
1354
1355         Add a boolean to keep track of whether it's been terminated.  Clean
1356         up the locking code a tiny bit to make it easier to read.  There's
1357         no way to reproduce this reliably in a LayoutTest.
1358
1359         * storage/LocalStorageThread.cpp:
1360         (WebCore::LocalStorageThread::LocalStorageThread):
1361         (WebCore::LocalStorageThread::terminate):
1362         (WebCore::LocalStorageThread::performTerminate):
1363         * storage/LocalStorageThread.h:
1364
1365 2009-10-29  Dimitri Glazkov  <dglazkov@chromium.org>
1366
1367         Unreviewed, build fix.
1368
1369         [Chromium] Include ComplextTextController into Chromium Mac project.
1370
1371         * WebCore.gyp/WebCore.gyp: Added include rule for ComplextText* files.
1372
1373 2009-10-29  Timothy Hatcher  <timothy@apple.com>
1374
1375         Fix tabbing through element attributes in the Web Insector.
1376
1377         https://bugs.webkit.org/show_bug.cgi?id=30429
1378
1379         Reviewed by Pavel Feldman.
1380
1381         * inspector/front-end/ElementsTreeOutline.js:
1382         (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted): Don't call _updateTitle,
1383         it is called for us when removeAttribute succeeds in the back-end.
1384         (WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted): Ditto except for nodeValue.
1385         (WebInspector.ElementsTreeElement.prototype._editingCancelled): Don't call _updateTitle, editing code reverts.
1386         (WebInspector.ElementsTreeElement.prototype._updateTitle): Return early if we are editing.
1387
1388 2009-10-29  Dan Bernstein  <mitz@apple.com>
1389
1390         Reviewed by Sam Weinig.
1391
1392         Problem editing or selecting text containing ligatures
1393         https://bugs.webkit.org/show_bug.cgi?id=30025
1394
1395         Test: platform/mac/fast/text/ligature-subdivision.html
1396
1397         * platform/graphics/mac/ComplexTextController.cpp:
1398         (WebCore::ComplexTextController::ComplexTextController): Initialize
1399         m_characterInCurrentGlyph.
1400         (WebCore::ComplexTextController::offsetForPosition): If the hit glyph spans multiple
1401         characters, compute the hit character based on dividing the glyph’s total advance into
1402         a number of equal intervals equal to the number of characters and assigning the hit to the
1403         character corresponding to the hit interval.
1404         (WebCore::ComplexTextController::advance): If the final offset occurs mid-glyph, advance
1405         by a fraction of the glyph’s total advance.
1406         * platform/graphics/mac/ComplexTextController.h: Added m_characterInCurrentGlyph.
1407
1408 2009-10-29  Brian Weinstein  <bweinstein@apple.com>
1409
1410         Reviewed by Timothy Hatcher.
1411
1412         Fixes <http://webkit.org/b/30918>.
1413         Web Inspector: Datagrid Rows on Windows not properly aligned.
1414         
1415         Use line-height for the table rows to make sure the height
1416         of our text and the height of the table rows are consistent.
1417
1418         * inspector/front-end/inspector.css:
1419
1420 2009-10-29  Adam Barth  <abarth@webkit.org>
1421
1422         No review, rolling out r50296.
1423         http://trac.webkit.org/changeset/50296
1424
1425         * bindings/v8/V8IsolatedWorld.cpp:
1426         (WebCore::V8IsolatedWorld::V8IsolatedWorld):
1427         * bindings/v8/V8Proxy.cpp:
1428         (WebCore::V8Proxy::evaluateInIsolatedWorld):
1429         (WebCore::V8Proxy::evaluateInNewContext):
1430
1431 2009-10-29  Adam Barth  <abarth@webkit.org>
1432
1433         Reviewed by Dimitri Glazkov.
1434
1435         [V8] Out-of-memory crash in isolated worlds
1436         https://bugs.webkit.org/show_bug.cgi?id=30906
1437
1438         We need to handle the fact that creating a V8:Context might fail.  I
1439         don't know how to test this change because creating a context usually
1440         only fails when V8 decides it's using too much memory.
1441
1442         * bindings/v8/V8IsolatedWorld.cpp:
1443         (WebCore::V8IsolatedWorld::V8IsolatedWorld):
1444         * bindings/v8/V8Proxy.cpp:
1445         (WebCore::V8Proxy::evaluateInIsolatedWorld):
1446         (WebCore::V8Proxy::evaluateInNewContext):
1447
1448 2009-10-29  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1449
1450         Reviewed by Xan Lopez.
1451
1452         Remove build warning introduced by r50284.
1453
1454         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1455         (WebCore::MediaPlayerPrivate::duration):
1456
1457 2009-10-29  Dimitri Glazkov  <dglazkov@chromium.org>
1458
1459         Reviewed by Adam Barth.
1460
1461         [V8] Remove random crashes by removing retrieval of V8 context during garbage collection.
1462
1463         https://bugs.webkit.org/show_bug.cgi?id=30919
1464
1465         Unfortunately, I haven't been able to trigger this crash explicitly, so no test :(.
1466
1467         * bindings/v8/V8DOMWrapper.cpp:
1468         (WebCore::V8DOMWrapper::jsWrapperForDOMObject): Added new "assume-it's-there" getter.
1469         * bindings/v8/V8DOMWrapper.h: Added getter decl.
1470         * bindings/v8/V8GCController.cpp:
1471         (WebCore::GCPrologueVisitor::visitDOMWrapper): Changed to use explicit getter.
1472
1473 2009-10-29  Dimitri Glazkov  <dglazkov@chromium.org>
1474
1475         Unreviewed, build fix.
1476
1477         [Chromium] Adjust the project files to sync up with
1478         http://trac.webkit.org/changeset/50259
1479
1480         * WebCore.gypi: Renamed and added files.
1481
1482 2009-10-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1483
1484         Reviewed by Tor Arne Vestbø.
1485
1486         [Qt] Implement DELETE HTTP method for XmlHttpRequest
1487         https://bugs.webkit.org/show_bug.cgi?id=30894
1488
1489         No new tests as this functionality is already tested by the 
1490         xmlhttprequest LayoutTests. As this patch depends on an unreleased
1491         version of the dependent QtNetwork library and the tests will be
1492         enabled later once the dependent library is released (and the
1493         buildbot is updated).
1494
1495         * platform/network/qt/QNetworkReplyHandler.cpp:
1496         (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
1497         (WebCore::QNetworkReplyHandler::start):
1498
1499 2009-10-29  Brian Weinstein  <bweinstein@apple.com>
1500
1501         Reviewed by Timothy Hatcher.
1502
1503         Part of <http://webkit.org/b/30483>.
1504         Web Inspector: Always show the Local and Session Storage Views.
1505         
1506         Even if the length of the DOM Storage entry array is 0, still
1507         generate the Datagrid because users can add things storage items
1508         through the UI, so we should allow them to even if there isn't
1509         anything there currently.
1510
1511         * English.lproj/localizedStrings.js: Removed "This Storage is Empty".
1512         * inspector/front-end/DOMStorageItemsView.js:
1513         (WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):
1514
1515 2009-10-29  Pavel Feldman  <pfeldman@chromium.org>
1516
1517         Reviewed by Timothy Hatcher.
1518
1519         Web Inspector: Add TimelinePanel into the panels enum.
1520
1521         https://bugs.webkit.org/show_bug.cgi?id=30915
1522
1523         * inspector/InspectorController.cpp:
1524         (WebCore::InspectorController::specialPanelForJSName):
1525         * inspector/InspectorController.h:
1526         (WebCore::InspectorController::):
1527
1528 2009-10-29  Xan Lopez  <xlopez@igalia.com>
1529
1530         Reviewed by Oliver Hunt.
1531
1532         [GTK] Threading problems with some of the tests
1533         https://bugs.webkit.org/show_bug.cgi?id=30814
1534
1535         Create strings shared among threads with crossThreadString
1536         constructor method.
1537
1538         * storage/Database.cpp:
1539         (WebCore::Database::Database):
1540
1541 2009-10-29  Sebastian Dröge  <sebastian.droege@collabora.co.uk>
1542
1543         Reviewed by Gustavo Noronha.
1544
1545         https://bugs.webkit.org/show_bug.cgi?id=30308
1546         
1547         Add support for ARGB videos.
1548
1549         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
1550         (WebCore::MediaPlayerPrivate::paint):
1551         Create the Cairo image surface for ARGB32 or RGB24
1552         depending on the buffer's caps.
1553         
1554         * platform/graphics/gtk/VideoSinkGStreamer.cpp:
1555         (webkit_video_sink_timeout_func):
1556         (webkit_video_sink_render):
1557         Handle ARGB video and convert GStreamer's ARGB to
1558         Cairo's for displaying.
1559
1560 2009-10-29  Anton Muhin  <antonm@chromium.org>
1561
1562         Reviewed by David Levin.
1563
1564         [chromium] expose a method to access memory usage information in ChromiumBridge
1565         Declare a static method to be implemented by http://codereview.chromium.org/332010/
1566         https://bugs.webkit.org/show_bug.cgi?id=30829
1567
1568         * platform/chromium/ChromiumBridge.h:
1569
1570 2009-10-29  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1571
1572         Reviewed by Xan Lopez.
1573
1574         https://bugs.webkit.org/show_bug.cgi?id=25679
1575         [Gtk] Improve accessibility of focusable lists
1576
1577         Implements the AtkSelection interface and enables the corresponding
1578         (and expected) object:selection-changed event.
1579
1580         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1581         (optionFromList):
1582         (optionFromSelection):
1583         (atk_selection_interface_init):
1584         (webkit_accessible_selection_add_selection):
1585         (webkit_accessible_selection_clear_selection):
1586         (webkit_accessible_selection_ref_selection):
1587         (webkit_accessible_selection_get_selection_count):
1588         (webkit_accessible_selection_is_child_selected):
1589         (webkit_accessible_selection_remove_selection):
1590         (webkit_accessible_selection_select_all_selection):
1591         (GetAtkInterfaceTypeFromWAIType):
1592         * accessibility/gtk/AXObjectCacheAtk.cpp:
1593         (AXObjectCache::postPlatformNotification):
1594
1595 2009-10-29  Jian Li  <jianli@chromium.org>
1596
1597         Reviewed by Darin Adler.
1598
1599         Bug 30655 - Only plain text should be copied to clipboard for TextArea.
1600         https://bugs.webkit.org/show_bug.cgi?id=30655
1601
1602         * editing/Editor.cpp:
1603         (WebCore::nodeIsInTextFormControl):
1604         (WebCore::Editor::cut):
1605         (WebCore::Editor::copy):
1606
1607 2009-10-29  Pavel Feldman  <pfeldman@chromium.org>
1608
1609         Reviewed by Timothy Hatcher.
1610
1611         Web Inspector: hide timeline for now - not yet ready.
1612
1613         https://bugs.webkit.org/show_bug.cgi?id=30912
1614
1615         * inspector/front-end/inspector.js:
1616         (WebInspector._createPanels):
1617
1618 2009-10-29  Pavel Feldman  <pfeldman@chromium.org>
1619
1620         Not reviewed: deploy Web Inspector's images in WebCore.gypi.
1621
1622         * WebCore.gypi:
1623
1624 2009-10-29  Pavel Feldman  <pfeldman@chromium.org>
1625
1626         Reviewed by Timothy Hatcher.
1627
1628         Web Inspector: get rid of timelineProfilerEnabled method.
1629
1630         https://bugs.webkit.org/show_bug.cgi?id=30911
1631
1632         * inspector/InspectorBackend.cpp:
1633         * inspector/InspectorBackend.h:
1634         * inspector/InspectorBackend.idl:
1635         * inspector/InspectorController.cpp:
1636         (WebCore::InspectorController::setWindowVisible):
1637         * inspector/InspectorController.h:
1638         * inspector/front-end/TimelinePanel.js:
1639         (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
1640
1641 2009-10-29  Pavel Feldman  <pfeldman@chromium.org>
1642
1643         Reviewed by Darin Fisher.
1644
1645         Create stub methods for raw cookies access in ChromiumBridge.h
1646
1647         https://bugs.webkit.org/show_bug.cgi?id=30910
1648
1649         * platform/chromium/ChromiumBridge.h:
1650
1651 2009-10-29  Zoltan Horvath  <zoltan@webkit.org>
1652
1653         Reviewed by Darin Adler.
1654
1655         Allow custom memory allocation control for WebCore's RareData
1656         https://bugs.webkit.org/show_bug.cgi?id=30858
1657
1658         Inherits RareData struct from Noncopyable because it is
1659         instantiated by 'new' in WebCore/css/CSSSelector.h:259 and 
1660         it is no need to be copyable.
1661
1662         * css/CSSSelector.h:
1663
1664 2009-10-29  Zoltan Horvath  <zoltan@webkit.org>
1665
1666         Reviewed by Darin Adler.
1667
1668         Allow custom memory allocation control for WebCore's ShorthandScope
1669         https://bugs.webkit.org/show_bug.cgi?id=30859
1670
1671         Inherits ShorthandScope class from FastAllocBase because it is 
1672         instantiated by 'new' in WebCore/css/CSSParser.cpp:902 and 
1673         it is no need to be copyable.        
1674
1675         * css/CSSParser.h:
1676
1677 2009-10-29  Zoltan Horvath  <zoltan@webkit.org>
1678
1679         Reviewed by Darin Adler.
1680
1681         Allow custom memory allocation control for WebCore's AXObjectCache
1682         https://bugs.webkit.org/show_bug.cgi?id=30848
1683
1684         Inherits AXObjectCache class from FastAllocBase because it is
1685         instantiated by 'new' in WebCore/dom/Document.cpp:1537 and                                
1686         it is no need to be copyable.
1687
1688         * accessibility/AXObjectCache.h:
1689
1690 2009-10-28  Adam Barth  <abarth@webkit.org>
1691
1692         Reviewed by Eric Seidel.
1693
1694         Don't run JavaScript URLs in view source mode
1695         https://bugs.webkit.org/show_bug.cgi?id=30881
1696
1697         Just say no.
1698
1699         Test: http/tests/security/view-source-no-javascript-url.html
1700
1701         * bindings/ScriptControllerBase.cpp:
1702         (WebCore::ScriptController::executeIfJavaScriptURL):
1703
1704 2009-10-29  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1705
1706         Unreviewed. Fixes style problems pointed out by Evan Martin.
1707
1708         * platform/gtk/Language.cpp:
1709         (WebCore::defaultLanguage):
1710
1711 2009-10-29  Dan Bernstein  <mitz@apple.com>
1712
1713         Rubber-stamped by Mark Rowe.
1714
1715         64-bit Leopard build fix after r50259
1716         
1717         * platform/graphics/mac/ComplexTextControllerATSUI.cpp:
1718         Declared ATSUTextInserted in 64-bit.
1719         (WebCore::fontHasMirroringInfo): Use %d format and cast to int.
1720         (WebCore::disableLigatures): Ditto.
1721         (WebCore::initializeATSUStyle): Ditto.
1722         (WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Ditto.
1723
1724 2009-10-29  Dan Bernstein  <mitz@apple.com>
1725
1726         Tiger build fix after r50259
1727
1728         * platform/graphics/mac/ComplexTextController.h:
1729         * platform/graphics/mac/ComplexTextControllerATSUI.cpp:
1730
1731 2009-10-29  Dan Bernstein  <mitz@apple.com>
1732
1733         Attempted Tiger build fix after r50259
1734
1735         * platform/graphics/mac/ComplexTextControllerATSUI.cpp:
1736
1737 2009-10-28  Steve Falkenburg  <sfalken@apple.com>
1738
1739         Rubber stamped by Mark Rowe.
1740
1741         https://bugs.webkit.org/show_bug.cgi?id=30899
1742         WebKit fails to build release on 32-bit Windows systems
1743
1744         * WebCore.vcproj/WebCore.vcproj: Excluded files from project.
1745         * bindings/js/JSBindingsAllInOne.cpp: Added.
1746
1747 2009-10-28  Dan Bernstein  <mitz@apple.com>
1748
1749         Reviewed by Jon Honeycutt.
1750
1751         Fixed typos in color names.
1752
1753         * inspector/front-end/Color.js:
1754
1755 2009-10-28  Dan Bernstein  <mitz@apple.com>
1756
1757         Reviewed by Sam Weinig.
1758
1759         Share code between the ATSUI- and Core Text-based Font implementations by doing the
1760         following:
1761         - Generalize CoreTextController as ComplexTextController, keeping the Core Text-specific
1762           parts in ComplexTextControllerCoreText.cpp.
1763         - Generalize FontMacCoreText as FontComplexTextMac using ComplexTextController
1764         - Implement ATSUI-specific parts of ComplexTextController in ComplexTextControllerATSUI.
1765         - Remove FontMacATSUI.
1766
1767         * WebCore.xcodeproj/project.pbxproj: Removed CoreTextController.{cpp,h}, FontMacATSUI.mm,
1768         and FontMacCoreText.cpp, and added ComplexTextController.{cpp,h},
1769         ComplexTextControllerATSUI.cpp, ComplexTextControllerCoreText.cpp, and
1770         FontComplexTextMac.cpp.
1771
1772         * platform/graphics/mac/ComplexTextController.cpp: Copied from CoreTextController.cpp and
1773         kept the non-Core Text-specific bits.
1774         (WebCore::ComplexTextController::ComplexTextController): Updated for renames, including
1775         its own.
1776         (WebCore::ComplexTextController::offsetForPosition): Updated for renames and for
1777         m_complexTextRuns holding references instead of objects.
1778         (WebCore::ComplexTextController::collectComplexTextRuns): Updated for renames, including
1779         its own.
1780         (WebCore::ComplexTextController::advance): Updated for renames.
1781         (WebCore::ComplexTextController::adjustGlyphsAndAdvances): Updated for renames and for
1782         m_complexTextRuns holding references instead of objects, and changed to use the glyphs()
1783         and advances() accessors.
1784
1785         * platform/graphics/mac/ComplexTextController.h: Copied from CoreTextController.h and
1786         renamed CoreTextController to ComplexTextController and CoreTextRun to ComplexTextRun. Made
1787         the latter RefCounted, added ATSUI-specific members to it, and made some other members
1788         Core Text-specific. Renamed m_coreTextRuns to m_complexTextRuns and made it hold references
1789         rather than objects.
1790         (WebCore::ComplexTextController::ComplexTextRun::create):
1791         (WebCore::ComplexTextController::ComplexTextRun::glyphs):
1792         (WebCore::ComplexTextController::ComplexTextRun::advances):
1793
1794         * platform/graphics/mac/ComplexTextControllerATSUI.cpp: Added. Includes ATSUI-specific
1795         parts of the ComplexTextController implementation. 
1796         (WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation): This ATSUI
1797         callback populates the ComplexTextRun’s glyphs, advances and indices vectors. It is invoked
1798         when the ComplexTextRun constructor calls ATSUGetGlyphBounds().
1799         (WebCore::isArabicLamWithAlefLigature): Helper function, copied from FontMacATSUI.mm.
1800         (WebCore::shapeArabic): Helper function, adapted from FontMacATSUI.mm.
1801         (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Sets up the
1802         ATSUTextLayout, substituting the text buffer if necessary for things like shaping Arabic,
1803         mirroring glyphs or directionality overrides, then calls ATSUGetGlyphBounds() in order to
1804         get the glyphs, advances and indices vectors populated.
1805         (WebCore::fontHasMirroringInfo): Helper function, copied from FontMacATSUI.mm.
1806         (WebCore::disableLigatures): Ditto.
1807         (WebCore::initializeATSUStyle): Ditto, somewhat cleaned up and simplified.
1808         (WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Constructs
1809         ComplexTextRuns, either missing-glyphs ones or ATSUTextLayout-based ones.
1810
1811         * platform/graphics/mac/ComplexTextControllerCoreText.cpp: Copied from
1812         CoreTextController.cpp and kept the Core Text-specific bits.
1813         (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Updated for renames,
1814         including its own, and moved the code to initialize m_glyphs and m_advances here. Previously
1815         this was done in adjustGlyphsAndAdvances().
1816         (WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Updated for renames,
1817         including its own.
1818         * platform/graphics/mac/CoreTextController.cpp: Removed.
1819         * platform/graphics/mac/CoreTextController.h: Removed.
1820         * platform/graphics/mac/FontComplexTextMac.cpp: Renamed FontMacCoreText.cpp to this.
1821         (WebCore::Font::selectionRectForComplexText): Changed to use ComplexTextController instead
1822         of CoreTextController.
1823         (WebCore::Font::drawComplexText): Ditto.
1824         (WebCore::Font::floatWidthForComplexText): Ditto.
1825         (WebCore::Font::offsetForPositionForComplexText): Ditto.
1826         * platform/graphics/mac/FontMacATSUI.mm: Removed.
1827         * platform/graphics/mac/FontMacCoreText.cpp: Removed.
1828
1829 2009-10-27  Chris Fleizach  <cfleizach@apple.com>
1830
1831         Reviewed by Darin Adler.
1832
1833         WAI-ARIA: add support for 'option' role
1834         https://bugs.webkit.org/show_bug.cgi?id=30843
1835
1836         Test: accessibility/aria-option-role.html
1837
1838         * accessibility/AccessibilityListBoxOption.h:
1839         (WebCore::AccessibilityListBoxOption::canHaveChildren):
1840         * accessibility/AccessibilityRenderObject.cpp:
1841         (WebCore::RoleEntry::):
1842         (WebCore::AccessibilityRenderObject::canHaveChildren):
1843
1844 2009-10-28  Jens Alfke  <snej@chromium.org>
1845
1846         Reviewed by Eric Seidel.
1847
1848         Fix GCC compiler warnings in WebCore, and enable -Wall and -Werror for Chromium build.
1849         https://bugs.webkit.org/show_bug.cgi?id=30716
1850
1851         * WebCore.gyp/WebCore.gyp:  Enable "chromium_code" flag, just on Mac build for now.
1852         * accessibility/AccessibilityRenderObject.cpp:
1853         (WebCore::createARIARoleMap):  Fix struct visibiity warning.
1854         * bindings/v8/ScriptCallStack.h:  Fix out-of-order member initialization warning.
1855         * bindings/v8/V8Collection.h:
1856         (WebCore::getV8Object):  Function in header should not be 'static' (fixes unused-static warning.)
1857         * bindings/v8/V8DOMWrapper.cpp:
1858         (WebCore::V8DOMWrapper::convertNewNodeToV8Object):  Fix signed/unsigned comparison warning.
1859         * bindings/v8/V8GCController.cpp:
1860         (WebCore::ObjectGrouperVisitor::applyGrouping):  Fix unused-variable warning.
1861         * css/CSSPrimitiveValueMappings.h:
1862         (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):  Enable ListButtonPart case to avoid
1863             warning about missing cases in 'switch' statement.
1864         * editing/EditorCommand.cpp:
1865         (WebCore::createCommandMap):  Fix struct visibiity warning.
1866         * platform/graphics/skia/PlatformContextSkia.cpp:
1867         (PlatformContextSkia::State::State):  Fix out-of-order member initialization warning.
1868         * rendering/RenderMediaControlsChromium.cpp:
1869         (WebCore::RenderMediaControlsChromium::shouldRenderMediaControlPart):  Add empty 'default' case in
1870             'switch' statement to avoid missing-case warning.
1871         (WebCore::RenderMediaControlsChromium::paintMediaControlsPart):  Ditto.
1872         * xml/XPathFunctions.cpp:
1873         (WebCore::XPath::createFunctionMap):  Fix struct visibiity warning.
1874
1875 2009-10-29  Adam Barth  <abarth@webkit.org>
1876
1877         Reviewed by Darin Adler.
1878
1879         REGRESSION: crashes in WebCore::RedirectScheduler::timerFired(WebCore::Timer<WebCore::RedirectScheduler>*)
1880         https://bugs.webkit.org/show_bug.cgi?id=30839
1881
1882         Added null check for the case when the frame is detached from the page.
1883
1884         * loader/RedirectScheduler.cpp:
1885         (WebCore::RedirectScheduler::timerFired):
1886
1887 2009-10-28  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1888
1889         Reviewed by Xan Lopez.
1890
1891         https://bugs.webkit.org/show_bug.cgi?id=30817
1892         Use parentObjectUnignored instead of parentObject in webkit_accessible_get_parent
1893
1894         Also removes the hack I had originally added to solve bug 25411, because
1895         the fix here is what I should have done in the first place.
1896
1897         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
1898         (webkit_accessible_get_parent):
1899
1900 2009-10-28  Dmitry Titov  <dimich@chromium.org>
1901
1902         Reviewed by David Levin.
1903
1904         https://bugs.webkit.org/show_bug.cgi?id=30805
1905         Add MessageQueue::removeIf(Predicate&) to remove certain tasks without pulling them from the queue.
1906         Existing Database tests cover this, no change in functionality.
1907
1908         * storage/DatabaseThread.cpp:
1909         (WebCore::SameDatabasePredicate::SameDatabasePredicate): Added predicate that flags the tasks belonging to a specified database.
1910         (WebCore::SameDatabasePredicate::operator()):
1911         (WebCore::DatabaseThread::unscheduleDatabaseTasks): changed to use the new removeIf method.
1912
1913 2009-10-28  Pavel Feldman  <pfeldman@chromium.org>
1914
1915         Reviewed by Timothy Hatcher.
1916
1917         Web Inspector: Glue subsequent timeline records with same category
1918         and title together.
1919
1920         https://bugs.webkit.org/show_bug.cgi?id=30885
1921
1922         * English.lproj/localizedStrings.js:
1923         * inspector/front-end/TimelinePanel.js:
1924         (WebInspector.TimelinePanel.prototype.addRecordToTimeline):
1925         (WebInspector.TimelinePanel.prototype._formatRecord):
1926         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
1927         (WebInspector.TimelineRecordTreeElement.prototype.refresh):
1928
1929 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1930
1931         Reviewed by Xan Lopez.
1932
1933         [GTK] Fails new test fast/js/navigator-language.html
1934         https://bugs.webkit.org/show_bug.cgi?id=30440
1935
1936         Reimplement WebCore::defaultLanguage to account for changes in
1937         locale done by setLocale.
1938
1939         Already existing test: fast/js/navigator-language.html
1940
1941         * platform/gtk/Language.cpp:
1942         (WebCore::defaultLanguage):
1943
1944 2009-10-28  Eric Carlson  <eric.carlson@apple.com>
1945
1946         Reviewed by Simon Fraser.
1947
1948         <rdar://problem/7303145> 
1949         Can't exit full screen mode or restart movie after pressing command -R.
1950
1951         * html/HTMLMediaElement.cpp:
1952         (WebCore::HTMLMediaElement::removedFromDocument):
1953         (WebCore::HTMLMediaElement::documentWillBecomeInactive):
1954             Exit from fullscreen if necessary.
1955         * html/HTMLMediaElement.h:
1956
1957 2009-10-28  Alexey Proskuryakov  <ap@apple.com>
1958
1959         Unreviewed - a trivial fix to get Windows bots running.
1960
1961         https://bugs.webkit.org/show_bug.cgi?id=30841
1962         <rdar://problem/7342730> WebKit should not pass Referer header through a redirect to a non-secure site
1963
1964         * platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::setHeaderFields): Don't try to
1965         access empty vector's data.
1966
1967 2009-10-28  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1968
1969         Reviewed by Xan Lopez.
1970
1971         https://bugs.webkit.org/show_bug.cgi?id=25897
1972         [Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries
1973
1974         Remove the extraneous object of ROLE_PANEL.
1975
1976         * accessibility/gtk/AccessibilityObjectAtk.cpp:
1977         (AccessibilityObject::accessibilityPlatformIncludesObject):
1978
1979 2009-10-28  Jonathan Dixon  <joth@chromium.org>
1980
1981         Reviewed by Eric Seidel.
1982
1983         Bug 30547: (Chromium) searchbox not rendered properly due to the css property -webkit-border-radius
1984         https://bugs.webkit.org/show_bug.cgi?id=30547
1985
1986         Test: fast/css/text-input-with-webkit-border-radius.html
1987
1988         * rendering/RenderThemeChromiumWin.cpp:
1989         (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
1990           Implemented rounded border rendering in Chromium Windows theme renderer.
1991
1992 2009-10-28  Pavel Feldman  <pfeldman@chromium.org>
1993
1994         Reviewed by Timothy Hatcher.
1995
1996         Web Inspector: Pull items collections from resources panel and
1997         timeline panel into AbstractTimelinePanel.
1998
1999         https://bugs.webkit.org/show_bug.cgi?id=30875
2000
2001         * inspector/front-end/AbstractTimelinePanel.js:
2002         (WebInspector.AbstractTimelinePanel):
2003         (WebInspector.AbstractTimelinePanel.prototype.populateSidebar):
2004         (WebInspector.AbstractTimelinePanel.prototype.createItemTreeElement):
2005         (WebInspector.AbstractTimelinePanel.prototype.createItemGraph):
2006         (WebInspector.AbstractTimelinePanel.prototype._showCategory):
2007         (WebInspector.AbstractTimelinePanel.prototype._hideCategory):
2008         (WebInspector.AbstractTimelinePanel.prototype.filter):
2009         (WebInspector.AbstractTimelinePanel.prototype._createGraph):
2010         (WebInspector.AbstractTimelinePanel.prototype.updateMainViewWidth):
2011         (WebInspector.AbstractTimelinePanel.prototype.refresh):
2012         (WebInspector.AbstractTimelinePanel.prototype.reset):
2013         (WebInspector.AbstractTimelinePanel.prototype.get calculator):
2014         (WebInspector.AbstractTimelinePanel.prototype.set calculator):
2015         (WebInspector.AbstractTimelinePanel.prototype.addItem):
2016         (WebInspector.AbstractTimelinePanel.prototype.removeItem):
2017         (WebInspector.AbstractTimelinePanel.prototype.refreshItem):
2018         (WebInspector.AbstractTimelinePanel.prototype.revealAndSelectItem):
2019         (WebInspector.AbstractTimelinePanel.prototype.sortItems):
2020         (WebInspector.AbstractTimelinePanel.prototype.adjustScrollPosition):
2021         (WebInspector.AbstractTimelineCategory):
2022         (WebInspector.AbstractTimelineCategory.prototype.toString):
2023         * inspector/front-end/ResourceCategory.js:
2024         (WebInspector.ResourceCategory):
2025         * inspector/front-end/ResourcesPanel.js:
2026         (WebInspector.ResourcesPanel):
2027         (WebInspector.ResourcesPanel.prototype.createItemTreeElement):
2028         (WebInspector.ResourcesPanel.prototype.createItemGraph):
2029         (WebInspector.ResourcesPanel.prototype.isCategoryVisible):
2030         (WebInspector.ResourcesPanel.prototype.populateSidebar):
2031         (WebInspector.ResourcesPanel.prototype.get searchableViews):
2032         (WebInspector.ResourcesPanel.prototype.get searchResultsSortFunction.sortFuction):
2033         (WebInspector.ResourcesPanel.prototype.get searchResultsSortFunction):
2034         (WebInspector.ResourcesPanel.prototype.searchMatchFound):
2035         (WebInspector.ResourcesPanel.prototype.searchCanceled):
2036         (WebInspector.ResourcesPanel.prototype.performSearch):
2037         (WebInspector.ResourcesPanel.prototype.refresh):
2038         (WebInspector.ResourcesPanel.prototype.reset):
2039         (WebInspector.ResourcesPanel.prototype.removeResource):
2040         (WebInspector.ResourcesPanel.prototype.addMessageToResource):
2041         (WebInspector.ResourcesPanel.prototype.clearMessages):
2042         (WebInspector.ResourcesPanel.prototype.refreshResource):
2043         (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
2044         (WebInspector.ResourcesPanel.prototype.showResource):
2045         (WebInspector.ResourcesPanel.prototype._sortResourcesIfNeeded):
2046         (WebInspector.ResourcesPanel.prototype._toggleLargerResources):
2047         (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
2048         (WebInspector.ResourcesPanel.prototype.get _resources):
2049         (WebInspector.ResourceTimeCalculator.prototype._upperBound):
2050         * inspector/front-end/TimelinePanel.js:
2051         (WebInspector.TimelinePanel):
2052         (WebInspector.TimelinePanel.prototype.get categories):
2053         (WebInspector.TimelinePanel.prototype.populateSidebar):
2054         (WebInspector.TimelinePanel.prototype.addRecordToTimeline):
2055         (WebInspector.TimelinePanel.prototype.createItemTreeElement):
2056         (WebInspector.TimelinePanel.prototype.createItemGraph):
2057         (WebInspector.TimelinePanel.prototype._formatRecord):
2058         (WebInspector.TimelineCategory):
2059         * inspector/front-end/inspector.css:
2060         * inspector/front-end/inspector.html:
2061
2062 2009-10-28  Kelly Norton  <knorton@google.com>
2063
2064         Reviewed by Pavel Feldman.
2065
2066         Resets InspectorFrontend in InspectorTimelineAgent instead of removing it so
2067         that it remains active on refreshs and page transitions.
2068         https://bugs.webkit.org/show_bug.cgi?id=30874
2069
2070         * inspector/InspectorController.cpp:
2071         (WebCore::InspectorController::setFrontendProxyObject):
2072         * inspector/InspectorTimelineAgent.cpp:
2073         (WebCore::InspectorTimelineAgent::resetFrontendProxyObject):
2074         * inspector/InspectorTimelineAgent.h:
2075
2076 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
2077
2078         Reviewed by Darin Adler.
2079
2080         Provide a way to get counter values with layoutTestContoller
2081         https://bugs.webkit.org/show_bug.cgi?id=30555
2082
2083         Expose WebCore::counterValueForElement as a WebCore API.
2084
2085         * WebCore.base.exp:
2086         * rendering/RenderTreeAsText.cpp:
2087         (WebCore::writeCounterValuesFromChildren):
2088         (WebCore::counterValueForElement):
2089         * rendering/RenderTreeAsText.h:
2090
2091 2009-10-28  Nate Chapin  <japhet@chromium.org>
2092
2093         Unreviewed, Chromium build fix for r50225.
2094
2095         * loader/FrameLoader.cpp:
2096         (WebCore::FrameLoader::defaultObjectContentType):
2097
2098 2009-10-28  Eric Z. Ayers  <zundel@google.com>
2099
2100         Reviewed by Pavel Feldman.
2101
2102         Adds InspectorTimelineAgent  instrumentation for encountering a
2103         <SCRIPT> tag when parsing an HTML document. 
2104
2105         https://bugs.webkit.org/show_bug.cgi?id=30861
2106
2107         * bindings/js/ScriptSourceCode.h:
2108         (WebCore::ScriptSourceCode::ScriptSourceCode):
2109         (WebCore::ScriptSourceCode::startLine):
2110         (WebCore::ScriptSourceCode::url):
2111         * html/HTMLTokenizer.cpp:
2112         (WebCore::HTMLTokenizer::scriptHandler):
2113         (WebCore::HTMLTokenizer::scriptExecution):
2114         * inspector/InspectorTimelineAgent.cpp:
2115         (WebCore::InspectorTimelineAgent::willLoadXHR):
2116         (WebCore::InspectorTimelineAgent::willScriptTag):
2117         (WebCore::InspectorTimelineAgent::didScriptTag):
2118         * inspector/InspectorTimelineAgent.h:
2119         (WebCore::):
2120         * inspector/TimelineRecordFactory.cpp:
2121         (WebCore::TimelineRecordFactory::createScriptTagTimelineRecord):
2122         * inspector/TimelineRecordFactory.h:
2123         * inspector/front-end/TimelineAgent.js:
2124
2125 2009-10-28  Steve Block  <steveblock@google.com>
2126
2127         Reviewed by Darin Adler.
2128
2129         Makes sure that Geolocation watch IDs remain positive on overflow.
2130         https://bugs.webkit.org/show_bug.cgi?id=30122
2131
2132         No new tests possible.
2133
2134         * page/Geolocation.cpp: Modified.
2135         (WebCore::Geolocation::watchPosition): Modified. Reset the watch ID to 1 on overflow.
2136
2137 2009-10-28  George Staikos  <george.staikos@torchmobile.com>
2138
2139         Attempt to fix the Mac debug build after 50225.
2140
2141         * loader/FrameLoader.cpp:
2142         (WebCore::FrameLoader::defaultObjectContentType):
2143
2144 2009-10-28  Alexey Proskuryakov  <ap@apple.com>
2145
2146         Reviewed by Darin Adler.
2147
2148         https://bugs.webkit.org/show_bug.cgi?id=30841
2149         <rdar://problem/7342730> WebKit should not pass Referer header through a redirect to a non-secure site
2150
2151         Tests: http/tests/ssl/referer-301.html
2152                http/tests/ssl/referer-303.html
2153
2154         * platform/network/mac/ResourceHandleMac.mm:
2155         (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
2156         Remove Referer header if redirecting from https to another protocol.
2157
2158         * platform/network/ResourceRequestBase.cpp:
2159         (WebCore::ResourceRequestBase::clearHTTPReferrer): Update request counterparts, as it is
2160         always done when changing or adding header fields.
2161         (WebCore::ResourceRequestBase::clearHTTPOrigin): Ditto.
2162
2163         * platform/network/ResourceRequestBase.h: clearHTTPReferrer() and clearHTTPOrigin() are
2164         no longer inline, since they have non-trivial implementations.
2165
2166         * platform/network/mac/ResourceRequestMac.mm:
2167         (WebCore::ResourceRequest::doUpdatePlatformRequest): Fixed to synchronize header field removals.
2168         (WebCore::ResourceRequest::doUpdateResourceRequest): Ditto.
2169
2170         * platform/network/cf/ResourceHandleCFNet.cpp:
2171         (WebCore::willSendRequest):
2172         * platform/network/cf/ResourceRequestCFNet.cpp:
2173         (WebCore::setHeaderFields):
2174         (WebCore::ResourceRequest::doUpdatePlatformRequest):
2175         (WebCore::ResourceRequest::doUpdateResourceRequest):
2176         Match Mac changes.
2177         
2178 2009-10-28  Joe Mason  <jmason@rim.com>
2179
2180         Reviewed by Adam Treat.
2181
2182         Add FrameLoader::defaultObjectContentType, containing common code for
2183         implementing FrameLoaderClient::objectContentType.  (Currently the gtk
2184         and win ports have copied this code, and the qt port uses similar code
2185         with a few extra clauses.  Moving this to a utility function cuts down
2186         on copied code.)   This causes no behavioural change.
2187
2188         https://bugs.webkit.org/show_bug.cgi?id=30868
2189
2190         * loader/FrameLoader.cpp:
2191         (WebCore::FrameLoader::defaultObjectContentType):
2192         * loader/FrameLoader.h:
2193
2194 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2195
2196         Reviewed by Tor Arne Vestbø.
2197
2198         [Qt] QWebHistory::saveState() is inconsistent with the Qt API
2199         https://bugs.webkit.org/show_bug.cgi?id=30710
2200
2201         Enforce the versioning, by ignoring any version different
2202         from 1.
2203
2204         * history/qt/HistoryItemQt.cpp:
2205         (WebCore::HistoryItem::restoreState):
2206         (WebCore::HistoryItem::saveState):
2207
2208 2009-10-28  Pavel Feldman  <pfeldman@chromium.org>
2209
2210         Not reviewed: follow up fix to InspectorControllerStub.
2211         Define it after inspector.js due to namespace
2212
2213         https://bugs.webkit.org/show_bug.cgi?id=30866
2214
2215         * inspector/front-end/inspector.html:
2216
2217 2009-10-28  Pavel Feldman  <pfeldman@chromium.org>
2218
2219         Reviewed by Timothy Hatcher.
2220
2221         Web Inspector: Add InspectorController stub in order to
2222         support opening in standalone mode.
2223
2224         https://bugs.webkit.org/show_bug.cgi?id=30866
2225
2226         * WebCore.gypi:
2227         * WebCore.vcproj/WebCore.vcproj:
2228         * inspector/front-end/InspectorControllerStub.js: Added.
2229         (.WebInspector.InspectorControllerStub):
2230         (.WebInspector.InspectorControllerStub.prototype.wrapCallback):
2231         (.WebInspector.InspectorControllerStub.prototype.isWindowVisible):
2232         (.WebInspector.InspectorControllerStub.prototype.platform):
2233         (.WebInspector.InspectorControllerStub.prototype.closeWindow):
2234         (.WebInspector.InspectorControllerStub.prototype.attach):
2235         (.WebInspector.InspectorControllerStub.prototype.detach):
2236         (.WebInspector.InspectorControllerStub.prototype.storeLastActivePanel):
2237         (.WebInspector.InspectorControllerStub.prototype.clearMessages):
2238         (.WebInspector.InspectorControllerStub.prototype.searchingForNode):
2239         (.WebInspector.InspectorControllerStub.prototype.search):
2240         (.WebInspector.InspectorControllerStub.prototype.toggleNodeSearch):
2241         (.WebInspector.InspectorControllerStub.prototype.setAttachedWindowHeight):
2242         (.WebInspector.InspectorControllerStub.prototype.moveByUnrestricted):
2243         (.WebInspector.InspectorControllerStub.prototype.addResourceSourceToFrame):
2244         (.WebInspector.InspectorControllerStub.prototype.addSourceToFrame):
2245         (.WebInspector.InspectorControllerStub.prototype.getResourceDocumentNode):
2246         (.WebInspector.InspectorControllerStub.prototype.highlightDOMNode):
2247         (.WebInspector.InspectorControllerStub.prototype.hideDOMNodeHighlight):
2248         (.WebInspector.InspectorControllerStub.prototype.inspectedWindow):
2249         (.WebInspector.InspectorControllerStub.prototype.loaded):
2250         (.WebInspector.InspectorControllerStub.prototype.localizedStringsURL):
2251         (.WebInspector.InspectorControllerStub.prototype.windowUnloading):
2252         (.WebInspector.InspectorControllerStub.prototype.hiddenPanels):
2253         (.WebInspector.InspectorControllerStub.prototype.debuggerEnabled):
2254         (.WebInspector.InspectorControllerStub.prototype.enableResourceTracking):
2255         (.WebInspector.InspectorControllerStub.prototype.disableResourceTracking):
2256         (.WebInspector.InspectorControllerStub.prototype.resourceTrackingEnabled):
2257         (.WebInspector.InspectorControllerStub.prototype.enableDebugger):
2258         (.WebInspector.InspectorControllerStub.prototype.disableDebugger):
2259         (.WebInspector.InspectorControllerStub.prototype.addBreakpoint):
2260         (.WebInspector.InspectorControllerStub.prototype.removeBreakpoint):
2261         (.WebInspector.InspectorControllerStub.prototype.updateBreakpoint):
2262         (.WebInspector.InspectorControllerStub.prototype.pauseInDebugger):
2263         (.WebInspector.InspectorControllerStub.prototype.pauseOnExceptions):
2264         (.WebInspector.InspectorControllerStub.prototype.setPauseOnExceptions):
2265         (.WebInspector.InspectorControllerStub.prototype.resumeDebugger):
2266         (.WebInspector.InspectorControllerStub.prototype.profilerEnabled):
2267         (.WebInspector.InspectorControllerStub.prototype.enableProfiler):
2268         (.WebInspector.InspectorControllerStub.prototype.disableProfiler):
2269         (.WebInspector.InspectorControllerStub.prototype.startProfiling):
2270         (.WebInspector.InspectorControllerStub.prototype.stopProfiling):
2271         (.WebInspector.InspectorControllerStub.prototype.getProfileHeaders):
2272         (.WebInspector.InspectorControllerStub.prototype.getProfile):
2273         (.WebInspector.InspectorControllerStub.prototype.takeHeapSnapshot):
2274         (.WebInspector.InspectorControllerStub.prototype.databaseTableNames):
2275         (.WebInspector.InspectorControllerStub.prototype.stepIntoStatementInDebugger):
2276         (.WebInspector.InspectorControllerStub.prototype.stepOutOfFunctionInDebugger):
2277         (.WebInspector.InspectorControllerStub.prototype.stepOverStatementInDebugger):
2278         (.WebInspector.InspectorControllerStub.prototype.setSetting):
2279         (.WebInspector.InspectorControllerStub.prototype.dispatchOnInjectedScript):
2280         (.WebInspector.InspectorControllerStub.prototype.releaseWrapperObjectGroup):
2281         (.WebInspector.InspectorControllerStub.prototype.setting):
2282         * inspector/front-end/inspector.html:
2283         * inspector/front-end/inspector.js:
2284         (WebInspector.UIString):
2285
2286 2009-10-28  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2287
2288         Reviewed by Jan Alonzo.
2289
2290         https://bugs.webkit.org/show_bug.cgi?id=25897
2291         [Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries
2292
2293         Expands upon the new funtionality which allows platforms to indicate
2294         that a particular object should not be ignored, so that they can
2295         specify that an object should be ignored or that it should be left up
2296         to the default handling to decide.
2297
2298         * accessibility/AccessibilityObject.h:
2299         * accessibility/chromium/AccessibilityObjectChromium.cpp:
2300         * accessibility/gtk/AccessibilityObjectAtk.cpp:
2301         * accessibility/mac/AccessibilityObjectMac.mm:
2302         * accessibility/qt/AccessibilityObjectQt.cpp:
2303         * accessibility/win/AccessibilityObjectWin.cpp:
2304         * accessibility/wx/AccessibilityObjectWx.cpp:
2305         (AccessibilityObject::accessibilityPlatformIncludesObject):
2306         * accessibility/AccessibilityRenderObject.cpp:
2307         (AccessibilityRenderObject::accessibilityIsIgnored):
2308
2309
2310 2009-10-28  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2311
2312         Reviewed by Jan Alonzo.
2313
2314         https://bugs.webkit.org/show_bug.cgi?id=25534
2315         [GTK] Objects of ROLE_TABLE should implement the accessible table interface
2316
2317         Expose the table summary as the accessible description because there is no summary object.
2318
2319         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2320         (webkit_accessible_get_description):
2321
2322 2009-10-28  Steve Block  <steveblock@google.com>
2323
2324         Reviewed by Eric Seidel.
2325
2326         Adds ScriptController::intializeThreading(), with both JSC and V8 implementations.
2327         https://bugs.webkit.org/show_bug.cgi?id=30678
2328
2329         This new method is used from common code, rather than calling JSC::initializeThreading() (or the V8 equivalent) directly.
2330
2331         Build fix, no new tests required.
2332
2333         * bindings/js/ScriptController.cpp: Modified.
2334         (WebCore::ScriptController::initializeThreading): Added.
2335         * bindings/js/ScriptController.h: Modified. Adds ScriptController::initializeThreading().
2336         * bindings/v8/ScriptController.cpp: Modified.
2337         (WebCore::ScriptController::initializeThreading): Added.
2338         * bindings/v8/ScriptController.h: Modified. Adds ScriptController::initializeThreading().
2339         * loader/icon/IconDatabase.cpp: Modified.
2340         (WebCore::iconDatabase): Call ScriptController::initializeThreading(), rather than JSC::initializeThreading().
2341         * storage/Database.cpp: Modified.
2342         (WebCore::Database::Database): Call ScriptController::initializeThreading(), rather than JSC::initializeThreading().
2343
2344 2009-10-26  Holger Hans Peter Freyther  <zecke@selfish.org>
2345
2346         Reviewed by Darin Adler.
2347
2348         Document a feature of the m_liveDecodedResources list.
2349         https://bugs.webkit.org/show_bug.cgi?id=30209
2350
2351         The code made the assumption that the list is sorted by
2352         the m_lastDecodedAccessTime property of the CachedResource.
2353         The above is not true when CachedResource::setDecodedSize
2354         is called and the item is inserted the first time. In this
2355         case the m_lastDecodedAccessTime is still zero and the
2356         m_liveDecodedResources list becomes unsorted.
2357
2358         It is impossible that Cache::pruneLiveResources will
2359         stop to process the list too early due this feature and
2360         the alternatives of updating m_lastDecodedAccessTime in
2361         CachedResource::setDecodedSize or changing the insert
2362         to search the right position have a negative impact on
2363         performance. The best solution for now is to document
2364         this feature.
2365
2366         * loader/Cache.cpp:
2367         (WebCore::Cache::pruneLiveResources):
2368         * loader/CachedResource.cpp:
2369         (WebCore::CachedResource::setDecodedSize):
2370
2371 2009-10-28  Xan Lopez  <xlopez@igalia.com>
2372
2373         Reviewed by Jan Alonzo.
2374
2375         [Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries
2376         https://bugs.webkit.org/show_bug.cgi?id=25897
2377
2378         Make text controls always implement the text interface, and the
2379         editable text interface when they are not read only. This is what
2380         ATK-users expect.
2381
2382         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2383         (getInterfaceMaskFromObject):
2384
2385 2009-10-27  Holger Hans Peter Freyther  <zecke@selfish.org>
2386
2387         Reviewed by Simon Fraser.
2388
2389         Change HitTestResult methods to use (3d) transformation aware methods
2390         https://bugs.webkit.org/show_bug.cgi?id=27347
2391
2392         The current HitTestResult methods are not using the (3d)
2393         transformation aware routines. This can lead to an assertion
2394         SVGRenderBase::mapLocalToContainer method.
2395
2396         Change HitTestResult::imageRect to use the (3d) transformation
2397         aware RenderBox::absoluteContentQuad to avoid running into
2398         an assertion with SVG content.
2399
2400         Remove HitTestResult::boundingBox() as it is only used in
2401         two places and conceptually doesn't belong into a HitTest
2402         which is operating on points.
2403
2404         A classic test case is not possible as the methods are not excercised
2405         from within HTML/SVG but from the WebKit API Layer. A unittest
2406         for Qt/Gtk+/Mac would need to be written but Qt/Gtk+ currently
2407         do not support 3d transformations making it impossible to write
2408         a reliable test case and the Mac port is currently not doing
2409         unit testing.
2410
2411
2412         * rendering/HitTestResult.cpp: Remove boundingBox() method
2413         (WebCore::HitTestResult::imageRect): Use transformation aware method
2414         * rendering/HitTestResult.h: Remove boundingBox()
2415
2416 2009-10-26  Holger Hans Peter Freyther  <zecke@selfish.org>
2417
2418         Reviewed by Eric Seidel.
2419
2420         [Qt] Custom Cursor doesn't use hotspot.
2421         https://bugs.webkit.org/show_bug.cgi?id=30820
2422
2423         Cursors loaded from a QPixmap didn't specifiy the
2424         hotspot. Take the hotspot values from the mac
2425         implementation.
2426
2427         * platform/qt/CursorQt.cpp:
2428
2429 2009-10-27  Pavel Feldman  <pfeldman@chromium.org>
2430
2431         Reviewed by Timothy Hatcher.
2432
2433         Web Inspector: Initial revision of the Timeline grid.
2434
2435         https://bugs.webkit.org/show_bug.cgi?id=30834
2436
2437         * English.lproj/localizedStrings.js:
2438         * WebCore.gypi:
2439         * inspector/front-end/AbstractTimelinePanel.js:
2440         (WebInspector.AbstractTimelinePanel.prototype.populateSidebar):
2441         (WebInspector.AbstractTimelinePanel.prototype.refresh):
2442         (WebInspector.AbstractTimelineCalculator):
2443         * inspector/front-end/Images/timelineBarBlue.png: Added.
2444         * inspector/front-end/Images/timelineBarGray.png: Added.
2445         * inspector/front-end/Images/timelineBarGreen.png: Added.
2446         * inspector/front-end/Images/timelineBarOrange.png: Added.
2447         * inspector/front-end/Images/timelineBarPurple.png: Added.
2448         * inspector/front-end/Images/timelineBarRed.png: Added.
2449         * inspector/front-end/Images/timelineBarYellow.png: Added.
2450         * inspector/front-end/Images/timelineCheckmarks.png: Added.
2451         * inspector/front-end/Images/timelineDots.png: Added.
2452         * inspector/front-end/ResourcesPanel.js:
2453         (WebInspector.ResourceTimeCalculator):
2454         (WebInspector.ResourceTransferSizeCalculator):
2455         * inspector/front-end/TimelineAgent.js:
2456         * inspector/front-end/TimelinePanel.js:
2457         (WebInspector.TimelinePanel):
2458         (WebInspector.TimelinePanel.prototype.get statusBarItems):
2459         (WebInspector.TimelinePanel.prototype.get categories):
2460         (WebInspector.TimelinePanel.prototype.populateSidebar):
2461         (WebInspector.TimelinePanel.prototype._createStatusbarButtons):
2462         (WebInspector.TimelinePanel.prototype.addItemToTimeline):
2463         (WebInspector.TimelinePanel.prototype.refresh):
2464         (WebInspector.TimelinePanel.prototype._toggleTimelineButtonClick):
2465         (WebInspector.TimelinePanel.prototype.reset):
2466         (WebInspector.TimelinePanel.prototype._formatRecord):
2467         (WebInspector.TimelinePanel.prototype.showCategory):
2468         (WebInspector.TimelinePanel.prototype.hideCategory):
2469         (WebInspector.TimelineRecordTreeElement):
2470         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
2471         (WebInspector.TimelineCalculator):
2472         (WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages):
2473         (WebInspector.TimelineCalculator.prototype.computePercentageFromEventTime):
2474         (WebInspector.TimelineCalculator.prototype.computeBarGraphLabels):
2475         (WebInspector.TimelineCalculator.prototype.updateBoundaries):
2476         (WebInspector.TimelineCalculator.prototype.formatValue):
2477         (WebInspector.TimelineGraph):
2478         (WebInspector.TimelineGraph.prototype.get graphElement):
2479         (WebInspector.TimelineGraph.prototype.refreshLabelPositions):
2480         (WebInspector.TimelineGraph.prototype.refresh):
2481         * inspector/front-end/inspector.css:
2482         * inspector/front-end/inspector.js:
2483         (WebInspector._createPanels):
2484
2485 2009-10-27  Joseph Pecoraro  <joepeck@webkit.org>
2486
2487         Reviewed by Pavel Feldman.
2488
2489         Web Inspector: Move runAfterPendingDispatches to TestController for Clarity
2490         https://bugs.webkit.org/show_bug.cgi?id=30844
2491
2492         * inspector/front-end/TestController.js:
2493         (WebInspector.TestController.prototype.runAfterPendingDispatches):
2494         * inspector/front-end/inspector.js: moved runAfterPendingDispatches
2495
2496 2009-10-27  Darin Fisher  <darin@chromium.org>
2497
2498         Reviewed by Dimitri Glazkov.
2499
2500         Add missing forward declaration of FramelessScrollView.
2501         https://bugs.webkit.org/show_bug.cgi?id=30824
2502
2503         * platform/chromium/FramelessScrollViewClient.h:
2504
2505 2009-10-27  Chris Fleizach  <cfleizach@apple.com>
2506
2507         Reviewed by Adele Peterson.
2508
2509         WAI-ARIA: add support for 'presentation' role
2510         https://bugs.webkit.org/show_bug.cgi?id=30806
2511
2512         Test: accessibility/aria-presentational-role.html
2513
2514         * accessibility/AccessibilityObject.h:
2515         (WebCore::):
2516         * accessibility/AccessibilityRenderObject.cpp:
2517         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
2518         (WebCore::RoleEntry::):
2519
2520 2009-10-27  Chris Fleizach  <cfleizach@apple.com>
2521
2522         Reviewed by Darin Adler.
2523
2524         ARIA menu/menu item need AXRoleDescription
2525         https://bugs.webkit.org/show_bug.cgi?id=30804
2526
2527         Make sure that role descriptions will default to the system's first, before
2528         returning an unknown role.
2529
2530         Test: platform/mac/accessibility/aria-menu-role-descriptions.html
2531
2532         * accessibility/mac/AccessibilityObjectWrapper.mm:
2533         (-[AccessibilityObjectWrapper roleDescription]):
2534
2535 2009-10-27  Geoffrey Garen  <ggaren@apple.com>
2536
2537         Qt build fix: migrated away from API that no longer exists.
2538
2539         * bridge/qt/qt_runtime.cpp:
2540         (JSC::Bindings::convertQVariantToValue):
2541
2542 2009-10-27  Geoffrey Garen  <ggaren@apple.com>
2543
2544         Qt build fix: migrated away from API that no longer exists.
2545
2546         * bridge/qt/qt_runtime.cpp:
2547         (JSC::Bindings::convertValueToQVariant):
2548
2549 2009-10-27  Oliver Hunt  <oliver@apple.com>
2550
2551         Fix wording in comment.
2552
2553         * bridge/objc/objc_instance.mm:
2554         (allocateAutoReleasePool):
2555
2556 2009-10-27  Oliver Hunt  <oliver@apple.com>
2557
2558         Reviewed by Darin Adler.
2559
2560         Crash occurs after launching Newsfire 1.6 for the first time
2561         https://bugs.webkit.org/show_bug.cgi?id=30807
2562
2563         We allocate an autorelease pool but then store it off the stack. In a
2564         GC environment this led to it being collected, and thus caused badness
2565         to ensue.  To work around this we simply avoid using a pool at all in
2566         a GC environment as it would be a no-op anyway.
2567
2568         * bridge/objc/objc_instance.mm:
2569         (allocateAutoReleasePool):
2570         (ObjcInstance::virtualBegin):
2571
2572 2009-10-27  Steve Block  <steveblock@google.com>
2573
2574         Reviewed by Darin Adler.
2575
2576         When a Geolocation method is called, immediately calls the error calback asynchronously if permissions
2577         have already been denied.
2578         https://bugs.webkit.org/show_bug.cgi?id=27944.
2579
2580         Tests: fast/dom/Geolocation/permission-denied-already-error.html
2581                fast/dom/Geolocation/permission-denied-already-success.html
2582
2583         * page/Geolocation.cpp: Modified.
2584         (WebCore::Geolocation::GeoNotifier::GeoNotifier): Modified. GeoNotifier takes Geolocation object as constructor argument.
2585         (WebCore::Geolocation::GeoNotifier::setFatalError): Added. Sets a fatal error for this notifier, causing it to terminate immediately and call the error callback asynchronously.
2586         (WebCore::Geolocation::GeoNotifier::timerFired): Added. Used to call the error callback asynchronously on fatal error.
2587         (WebCore::Geolocation::getCurrentPosition): Modified. Calls startRequest.
2588         (WebCore::Geolocation::watchPosition): Modified. Calls startRequest.
2589         (WebCore::Geolocation::startRequest): Added. Common functionality for starting a one-shot or watch request. Sets a fatal error on the notifier if permissions have already been denied.
2590         (WebCore::Geolocation::fatalErrorOccurred): Added. Registers that a notifier has encountered a fatal error and should be destroyed.
2591         (WebCore::Geolocation::setIsAllowed): Modified. Uses a standard error message for the error callback when permissions are denied.
2592         * page/Geolocation.h: Modified.
2593         (WebCore::Geolocation::isDenied): Added. Determines whether permissions have been denied.
2594
2595 2009-10-27  Chris Marrin  <cmarrin@apple.com>
2596
2597         Reviewed by Oliver Hunt.
2598
2599         Fixed a bug where I was using the wrong Canvas pointer to do a cross-domain check
2600         https://bugs.webkit.org/show_bug.cgi?id=30840
2601
2602         * html/canvas/CanvasRenderingContext2D.cpp:
2603         (WebCore::CanvasRenderingContext2D::drawImage):
2604
2605 2009-10-27  Eric Seidel  <eric@webkit.org>
2606
2607         Reviewed by Nikolas Zimmermann.
2608
2609         SVGStyledElement::getPresentationAttribute() can return a shared CSSValue (some SVG tests randomly fail on the bot, and in release builds)
2610         https://bugs.webkit.org/show_bug.cgi?id=29620
2611
2612         SVG was modifying CSSValues cached of off CSSMappedAttributeDeclarations.
2613         This patch fixes the check to make sure that a new CSSMappedAttributeDeclaration is
2614         created before returning a CSSValue that JavaScript can modify.
2615
2616         Test: svg/dom/getPresentationAttribute-cache-corruption.svg
2617
2618         * svg/SVGStyledElement.cpp:
2619         (WebCore::SVGStyledElement::getPresentationAttribute):
2620
2621 2009-10-27  Dan Bernstein  <mitz@apple.com>
2622
2623         Reviewed by Simon Fraser.
2624
2625         Incomplete repaint of text field in relative positioned inline at imdb.com
2626         https://bugs.webkit.org/show_bug.cgi?id=30047
2627
2628         Test: fast/repaint/inline-relative-positioned.html
2629
2630         Implemented offsetFromContainer(), mapLocalToContainer() and
2631         mapAbsoluteToLocalPoint() in RenderInline.
2632
2633         * rendering/RenderBox.h: Fixed argument names in the declaration of
2634         mapLocalToContainer().
2635         * rendering/RenderInline.cpp:
2636         (WebCore::RenderInline::offsetFromContainer):
2637         (WebCore::RenderInline::mapLocalToContainer):
2638         (WebCore::RenderInline::mapAbsoluteToLocalPoint):
2639         * rendering/RenderInline.h:
2640
2641 2009-10-27  Jeremy Orlow  <jorlow@chromium.org>
2642
2643         Speculative build fix for Chromium.
2644
2645         * platform/graphics/GraphicsContext3D.h:
2646
2647 2009-10-27  Chris Marrin  <cmarrin@apple.com>
2648
2649         Reviewed by Simon Fraser.
2650         
2651         Make WebGL context failure more robust and make it succeed in more cases
2652         https://bugs.webkit.org/show_bug.cgi?id=30349
2653
2654         Bubble a failure to get a CGLContext up to HTMLContextElement so it can
2655         return null from getContext. Also added a more robust pixel format choosing 
2656         mechanism and can render correctly when a SW renderer is chosen.
2657
2658         * html/HTMLCanvasElement.cpp:
2659         (WebCore::HTMLCanvasElement::getContext):
2660         * html/canvas/CanvasRenderingContext.h:
2661         * html/canvas/CanvasRenderingContext2D.cpp:
2662         * html/canvas/CanvasRenderingContext3D.cpp:
2663         * html/canvas/CanvasRenderingContext3D.h:
2664         (WebCore::CanvasRenderingContext3D::graphicsContext3D):
2665         (WebCore::CanvasRenderingContext3D::cleanupAfterGraphicsCall):
2666         * platform/graphics/GraphicsContext3D.h:
2667         * platform/graphics/mac/Canvas3DLayer.mm:
2668         (-[Canvas3DLayer copyCGLPixelFormatForDisplayMask:]):
2669         * platform/graphics/mac/GraphicsContext3DMac.cpp:
2670         (WebCore::setPixelFormat):
2671         (WebCore::GraphicsContext3D::create):
2672         (WebCore::GraphicsContext3D::GraphicsContext3D):
2673         (WebCore::GraphicsContext3D::~GraphicsContext3D):
2674         (WebCore::GraphicsContext3D::reshape):
2675         (WebCore::ensureContext):
2676
2677 2009-10-27  Geoffrey Garen  <ggaren@apple.com>
2678
2679         Mac build fix: a forwarding header.
2680
2681         * ForwardingHeaders/wtf/DateInstanceCache.h: Added.
2682
2683 2009-10-27  Ryosuke Niwa  <rniwa@webkit.org>
2684
2685         No Review.
2686
2687         Making fontWeightIsBold static to fix Snow Leopard build.
2688
2689         * editing/ApplyStyleCommand.cpp:
2690         (WebCore::fontWeightIsBold):
2691
2692 2009-10-27  Ryosuke Niwa  <rniwa@webkit.org>
2693
2694         Reviewed by Eric Seidel.
2695
2696         WebKit cannot remove nested bold tags
2697         https://bugs.webkit.org/show_bug.cgi?id=30784
2698
2699         This patch modifies getPropertiesNotInComputedStyle so that it compares font-weight
2700         more flexibly. Instead of comparing cssText, it uses fontWeightIsBold which converts
2701         all font weights to either bold or unbold state.
2702
2703         * editing/ApplyStyleCommand.cpp:
2704         (WebCore::fontWeightIsBold):
2705         (WebCore::getPropertiesNotInComputedStyle): Removes font-weight property
2706         if two style have the same value under getFontWeightValue
2707
2708 2009-10-27  Carol Szabo  <carol.szabo@nokia.com>
2709
2710         Reviewed by Darin Adler.
2711
2712         Give an ability to WebKit to free statically allocated pointers
2713         before quit.
2714         https://bugs.webkit.org/show_bug.cgi?id=27980
2715
2716         No new tests for this as the change does not affect WebKit
2717         functionality, but only memory usage.
2718
2719         * JavaScriptCore/wtf/StdLibExtras.h:
2720         Allowed for the override of DEFINE_STATIC_LOCAL via compiler 
2721         commandline options or elsewhere in the code. Useful for 
2722         implementing custom builds that free resources allocated via
2723         DEFINE_STATIC_LOCAL.
2724
2725 2009-10-27  Dumitru Daniliuc  <dumi@chromium.org>
2726
2727         Build fix, no review needed.
2728
2729         Fixing the BUILD. m_estimatedSize in Database.h should be of type
2730         'unsigned long' instead of 'unsigned long long'.
2731
2732         No tests required.
2733
2734         * storage/Database.h:
2735
2736 2009-10-27  Dumitru Daniliuc  <dumi@chromium.org>
2737
2738         Reviewed by Adam Barth.
2739
2740         Refactoring the Database class to not depend on
2741         OriginQuotaManager. Also, adding a SecurityOrigin copy to each
2742         Database instance, that is safe to use on the file
2743         thread. Finally, adding new simple fields and getters to the
2744         Database object for storing/getting the display name and estimated
2745         size specified by the user in the openDatabase() call.
2746
2747         https://bugs.webkit.org/show_bug.cgi?id=30548
2748
2749         * page/SecurityOrigin.h:
2750         * storage/Database.cpp:
2751         (WebCore::Database::openDatabase): Storing the display name and
2752         the estimated size in the Database object.
2753         (WebCore::Database::Database): Storing the display name and the
2754         estimated size in the Database object, as well as a SecurityOrigin
2755         instance that is safe to use on the DB thread.
2756         (WebCore::Database::maximumSize): Delegate the call to
2757         DatabaseTracker::getMaxSizeForDatabase().
2758         (WebCore::Database::databaseThreadSecurityOrigin): Return the
2759         SecurityOrigin instance that's safe to use on the DB thread.
2760         (WebCore::Database::threadSafeSecurityOrigin): Return the
2761         SecurityOrigin instance that's safe to use on the current thread.
2762         (WebCore::Database::displayName): Return the display name
2763         specified by the user in the openDatabase() call.
2764         (WebCore::Database::estimatedSize): Return the estimated size
2765         specified by the user in the openDatabase() call.
2766         (WebCore::Database::fileName): Return the name of the file where
2767         the current Database is tored.
2768         * storage/Database.h:
2769         * storage/DatabaseTracker.cpp:
2770         (WebCore::DatabaseTracker::getMaxSizeForDatabase): Returns the
2771         maximum size for a DB file based on the current size of that file
2772         and the space available for that origin.
2773         * storage/DatabaseTracker.h:
2774         * storage/SQLTransaction.cpp:
2775         * storage/SQLTransactionClient.cpp:
2776         (WebCore::SQLTransactionClient::didCommitTransaction): Use the
2777         correct SecurityOrigin instance.
2778
2779 2009-10-27  Joseph Pecoraro  <joepeck@webkit.org>
2780
2781         Reviewed by Timothy Hatcher.
2782
2783         Web Inspector: Pretty Print all HTML Collection Types like we do for NodeList
2784         https://bugs.webkit.org/show_bug.cgi?id=30709
2785
2786         Test: inspector/console-format-collections.html
2787
2788         * inspector/front-end/InjectedScript.js:
2789         (Object.type): check for instances of HTMLCollection like we do for NodeList
2790         * inspector/front-end/inspector.js: added WebInspector.pendingDispatches counter
2791         (WebInspector.dispatch): increment and decrement dispatch counter
2792         (WebInspector.runAfterPendingDispatches): run when there are no more dispatches
2793
2794 2009-10-27  Kelly Norton  <knorton@google.com>
2795
2796         Reviewed by Timothy Hatcher.
2797
2798         Adds XMLHttpRequest support to InspectorTimelineAgent.
2799         https://bugs.webkit.org/show_bug.cgi?id=30578
2800
2801         * inspector/InspectorTimelineAgent.cpp:
2802         (WebCore::InspectorTimelineAgent::willChangeXHRReadyState):
2803         (WebCore::InspectorTimelineAgent::didChangeXHRReadyState):
2804         (WebCore::InspectorTimelineAgent::willLoadXHR):
2805         (WebCore::InspectorTimelineAgent::didLoadXHR):
2806         * inspector/InspectorTimelineAgent.h:
2807         (WebCore::):
2808         * inspector/TimelineRecordFactory.cpp:
2809         (WebCore::TimelineRecordFactory::createXHRReadyStateChangeTimelineRecord):
2810         (WebCore::TimelineRecordFactory::createXHRLoadTimelineRecord):
2811         * inspector/TimelineRecordFactory.h:
2812         * inspector/front-end/TimelineAgent.js:
2813         * xml/XMLHttpRequest.cpp:
2814         (WebCore::XMLHttpRequest::callReadyStateChangeListener):
2815
2816 2009-10-27  Enrica Casucci  <enrica@apple.com>
2817
2818         Reviewed by Adele Peterson.
2819
2820         REGRESSION (Safari 4.0.3-ToT): After pressing Shift-PageDown, pressing Shift-Up 
2821         extends the top of the selection upwards (but should shrink the selection instead)
2822         <rdar://problem/7269075>
2823         https://bugs.webkit.org/show_bug.cgi?id=29981
2824
2825         * editing/SelectionController.cpp:
2826         (WebCore::SelectionController::modify): Added setting m_lastChangeWasHorizontalExtension.
2827
2828 2009-10-27  Brian Weinstein  <bweinstein@apple.com>
2829
2830         Rubber-stamped by Tim Hatcher.
2831         
2832         Removed an extra console.log from ElementsTreeOutline.
2833
2834         * inspector/front-end/ElementsTreeOutline.js:
2835
2836 2009-10-27  Keishi Hattori  <casey.hattori@gmail.com>
2837
2838         Reviewed by Timothy Hatcher.
2839
2840         Rewrote JavaScriptSourceSyntaxHighlighter to be more accurate
2841         https://bugs.webkit.org/show_bug.cgi?id=27147
2842
2843         Tests: LayoutTests/inspector/javascript-syntax-highlight.html
2844
2845         * inspector/front-end/ElementsTreeOutline.js:
2846         * inspector/front-end/SourceFrame.js:
2847         (WebInspector.JavaScriptSourceSyntaxHighlighter.process): Added. Processes 100 tokens at a time.
2848         (WebInspector.JavaScriptSourceSyntaxHighlighter.lex): Added. Scans for a token.
2849         (WebInspector.JavaScriptSourceSyntaxHighlighter.appendNonToken): Added. Appends the non-token characters that lex ignored.
2850         (WebInspector.JavaScriptSourceSyntaxHighlighter.syntaxHighlightNode): Added. To syntax highlight node in ElementsTreeOutline.
2851
2852 2009-10-27  Mads Ager  <ager@chromium.org>
2853
2854         Reviewed by Adam Barth.
2855
2856         [V8] Missing null check after string conversion in error reporting
2857         https://bugs.webkit.org/show_bug.cgi?id=30774
2858
2859         Add null check after string conversion in error reporting code.
2860         ToString conversion can fail for instance when an exception is
2861         thrown during conversion.
2862
2863         Test: fast/dom/error-to-string-stack-overflow.html
2864
2865         * bindings/v8/V8Utilities.cpp:
2866         (WebCore::reportException):
2867
2868 2009-10-27  Steve Block  <steveblock@google.com>
2869
2870         Reviewed by Darin Adler.
2871
2872         Use a pair of maps to store Geolocation watchers.
2873         https://bugs.webkit.org/show_bug.cgi?id=29178
2874
2875         The pair of maps allows us to look up a watcher either by its ID or by its GeoNotifier object.
2876         The ability to look up by a watcher by its GeoNotifier object will be required when implementing
2877         Geolocation::fatalErrorOccurred. See https://bugs.webkit.org/show_bug.cgi?id=27944
2878
2879         * page/Geolocation.cpp: Modified.
2880         (WebCore::Geolocation::Watchers::set): Added. Adds a watcher with the given ID.
2881         (WebCore::Geolocation::Watchers::remove): Added. Removes a watcher by ID.
2882         (WebCore::Geolocation::Watchers::remove): Added. Removes a watcher by GeoNotifier object.
2883         (WebCore::Geolocation::Watchers::clear): Added. Removes all watchers.
2884         (WebCore::Geolocation::Watchers::isEmpty): Added. Determines if there are no watchers.
2885         (WebCore::Geolocation::Watchers::getNotifiersVector): Added. Gets a vector of the GeoNotifier objects.
2886         (WebCore::Geolocation::watchPosition): Modified. Rename watcher identifier static variable.
2887         (WebCore::Geolocation::stopTimersForWatchers): Modified. Use Watchers::getNotifiersVector.
2888         (WebCore::Geolocation::handleError): Modified. Use Watchers::getNotifiersVector.
2889         (WebCore::Geolocation::makeSuccessCallbacks): Modified. Use Watchers::getNotifiersVector.
2890         * page/Geolocation.h: Modified. Adds Geolocation::Watchers class.
2891
2892 2009-10-27  Jeremy Orlow  <jorlow@chromium.org>
2893
2894         Reviewed by Dimitri Glazkov.
2895
2896         [V8] DOM Storage runtime flag should default to on
2897         https://bugs.webkit.org/show_bug.cgi?id=30828
2898
2899         The DOM Storage runtime flag was supposed to default to on.  I accidentally
2900         changed the logic to default to false when I moved the flag.
2901
2902         * bindings/v8/RuntimeEnabledFeatures.cpp:
2903
2904 2009-10-27  Fumitoshi Ukai  <ukai@chromium.org>
2905
2906         Reviewed by Dimitri Glazkov.
2907
2908         Fix crash found in chromium test_shell.
2909         https://bugs.webkit.org/show_bug.cgi?id=30808
2910
2911         When WebSocket is deleted without close, webkit would crash
2912         when it handles didClose.
2913
2914         Check scriptExecutionContext before post task for event.
2915         Use WebSocketChannel::disconnect() instead of close() in WebSocket
2916         destructor, so that WebSocketChannel should not call deleted WebSocket
2917         back in didClose().
2918         To make sure WebSocketChannel alive while it is processing WebSocket
2919         protocol over SocketStreamHandle, ref() in connect() and deref() in
2920         didClose().
2921
2922         * websockets/WebSocket.cpp:
2923         (WebCore::WebSocket::~WebSocket):
2924         (WebCore::WebSocket::didConnect):
2925         (WebCore::WebSocket::didReceiveMessage):
2926         (WebCore::WebSocket::didClose):
2927         * websockets/WebSocketChannel.cpp:
2928         (WebCore::WebSocketChannel::connect):
2929         (WebCore::WebSocketChannel::disconnect):
2930         (WebCore::WebSocketChannel::didClose):
2931         (WebCore::WebSocketChannel::didReceiveData):
2932         * websockets/WebSocketChannel.h:
2933
2934 2009-10-27  Dan Bernstein  <mitz@apple.com>
2935
2936         Reviewed by Darin Adler.
2937
2938         Updated Apple license
2939
2940         * LICENSE-APPLE:
2941
2942 2009-10-27  Brady Eidson  <beidson@apple.com>
2943
2944         Rubberstamped by Sam Weinig.
2945
2946         Re-enable the check that disallows pages with unload handlers in the page cache.
2947
2948         <rdar://problem/7196485> and http://webkit.org/b/29021 
2949
2950         * loader/FrameLoader.cpp:
2951         (WebCore::FrameLoader::canCachePageContainingThisFrame):
2952         (WebCore::FrameLoader::logCanCacheFrameDecision):
2953
2954 2009-10-27  Timothy Hatcher  <timothy@apple.com>
2955
2956         Remove more empty files that didn't get removed earlier.
2957
2958         * inspector/DOMDispatchTimelineItem.cpp: Removed.
2959         * inspector/DOMDispatchTimelineItem.h: Removed.
2960
2961 2009-10-27  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2962
2963         Reviewed by Tor Arne Vestbø.
2964
2965         [Qt] Fix assertion crashes introduced by changes made in r50110.
2966
2967         * dom/XMLTokenizerQt.cpp:
2968         (WebCore::XMLTokenizer::parseEndElement): only call popCurrentNode() if there are nodes left in the stack.
2969
2970 2009-10-27  Timothy Hatcher  <timothy@apple.com>
2971
2972         Remove empty files that didn't get removed earlier.
2973
2974         * inspector/TimelineItem.cpp: Removed.
2975         * inspector/TimelineItem.h: Removed.
2976
2977 2009-10-27  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2978
2979         Reviewed by Xan Lopez.
2980
2981         https://bugs.webkit.org/show_bug.cgi?id=25534
2982         [GTK] Objects of ROLE_TABLE should implement the accessible table interface
2983
2984         First part of the implementation of AtkTable.
2985
2986         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
2987         (getCell):
2988         (getCellIndex):
2989         (webkit_accessible_table_ref_at):
2990         (webkit_accessible_table_get_index_at):
2991         (webkit_accessible_table_get_n_columns):
2992         (webkit_accessible_table_get_n_rows):
2993         (webkit_accessible_table_get_column_extent_at):
2994         (webkit_accessible_table_get_row_extent_at):
2995         (webkit_accessible_table_get_row_header):
2996         (atk_table_interface_init):
2997         (AtkInterfacesInitFunctions):
2998         (GetAtkInterfaceTypeFromWAIType):
2999
3000 2009-10-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3001
3002         Reviewed by Lars Knoll.
3003
3004         [Qt] Don't lose remainder when computing wheel event deltas
3005
3006         * platform/qt/WheelEventQt.cpp:
3007
3008 2009-10-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3009
3010         Reviewed by Antti Koivisto.
3011
3012         Fix QtWebKit build for WIN_OS if Netscape plug-in support
3013         is turned off and refactor some related code
3014         https://bugs.webkit.org/show_bug.cgi?id=30786
3015
3016         No new tests as there is no new functionality introduced.
3017
3018         * platform/FileSystem.h: Refactor to make sure that each different
3019         type definition is only repeated once.
3020
3021         * plugins/PluginPackage.cpp:
3022         (WebCore::PluginPackage::compareFileVersion): Move it out from the
3023         ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH guard and combine it with the
3024         function body from PluginPackageWin.
3025
3026         * plugins/win/PluginPackageWin.cpp: Remove compareFileVersion as
3027         it is now in PluginPackage.cpp.
3028
3029 2009-10-26  Xan Lopez  <xlopez@igalia.com>
3030
3031         Reviewed by Gustavo Noronha.
3032
3033         https://bugs.webkit.org/show_bug.cgi?id=27011
3034         [Gtk] Implement support for get_index_in_parent
3035
3036         Implement atk_object_get_index_in_parent.
3037
3038         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
3039         (webkit_accessible_get_index_in_parent):
3040
3041 2009-10-27  Eric Seidel  <eric@webkit.org>
3042
3043         No review, rolling out r50131.
3044         http://trac.webkit.org/changeset/50131
3045
3046         * bridge/objc/objc_instance.h:
3047         * bridge/objc/objc_instance.mm:
3048         (ObjcInstance::ObjcInstance):
3049         (ObjcInstance::virtualEnd):
3050
3051 2009-10-26  Daniel Bates  <dbates@webkit.org>
3052
3053         Reviewed by Darin Adler.
3054
3055         https://bugs.webkit.org/show_bug.cgi?id=30491
3056
3057         Fixes an issue where pressing return/enter on the keyboard 
3058         in <isindex> does not submit it if is not within a <form>.
3059
3060         According to the HTML 2.0 thru HTML 4.01 spec 
3061         (http://www.w3.org/MarkUp/html-spec/html-spec_7.html#SEC7.5), the 
3062         <isindex> element does not need to be within a <form> element in 
3063         order to submit it. It can submitted on its own. Also, if present,
3064         the href property of the <base> element will dictate where to submit
3065         the value of the <isindex> element (this is analogous to the action 
3066         property of the <form> element).
3067
3068         Tests: http/tests/misc/isindex-with-no-form-base-href.html
3069                http/tests/misc/isindex-with-no-form.html
3070
3071         * html/HTMLInputElement.cpp:
3072         (WebCore::HTMLInputElement::defaultEventHandler): Calls createTemporaryFormForIsIndex()
3073         to create a <form> if none is present and we are an <isindex> element.
3074         (WebCore::HTMLInputElement::createTemporaryFormForIsIndex): Added.
3075         * html/HTMLInputElement.h:
3076
3077 2009-10-26  Oliver Hunt  <oliver@apple.com>
3078
3079         Reviewed by Maciej Stachowiak.
3080
3081         Crash occurs after launching Newsfire 1.6 for the first time
3082         https://bugs.webkit.org/show_bug.cgi?id=30807
3083
3084         Use a RetainPtr in ObjcBinding to ensure that we adequately
3085         protect the autorelease pool from GC in GC'd applications.
3086
3087         * bridge/objc/objc_instance.h:
3088         * bridge/objc/objc_instance.mm:
3089         (ObjcInstance::ObjcInstance):
3090         (ObjcInstance::virtualEnd):
3091
3092 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3093
3094         Unreviewed.
3095
3096         [Qt] Build fix for QtWebKit after r50125.
3097
3098         * WebCore.pro: Rename TimelineItem to TimelineRecord.
3099
3100 2009-10-26  Matt Mueller  <mattm@chromium.org>
3101
3102         Reviewed by Darin Adler.
3103
3104         Refactor synchronizable property handling to store one shouldSynchronize flag per set of properties rather than one per property.
3105
3106         Fixes reading uninitialized memory in SynchronizableProperty hash function as well as simplifying the code.
3107
3108         https://bugs.webkit.org/show_bug.cgi?id=30658
3109
3110         Covered by running various svg tests under valgrind, ex:
3111         LayoutTests/svg/custom/js-late-mask-and-object-creation.svg
3112
3113         * svg/SynchronizablePropertyController.cpp:
3114         (WebCore::SynchronizableProperties::addProperty):
3115         (WebCore::SynchronizableProperties::synchronize):
3116         (WebCore::SynchronizableProperties::startAnimation):
3117         (WebCore::SynchronizableProperties::stopAnimation):
3118         (WebCore::SynchronizablePropertyController::registerProperty):
3119         (WebCore::SynchronizablePropertyController::setPropertyNeedsSynchronization):
3120         (WebCore::SynchronizablePropertyController::synchronizeProperty):
3121         (WebCore::SynchronizablePropertyController::synchronizeAllProperties):
3122         (WebCore::SynchronizablePropertyController::startAnimation):
3123         (WebCore::SynchronizablePropertyController::stopAnimation):
3124         * svg/SynchronizablePropertyController.h:
3125         (WebCore::SynchronizableProperties::SynchronizableProperties):
3126         (WebCore::SynchronizableProperties::setNeedsSynchronization):
3127
3128 2009-10-26  Kelly Norton  <knorton@google.com>
3129
3130         Reviewed by Timothy Hatcher.
3131
3132         Renames TimelineItem to TimelineRecord and updates all call sites.
3133         https://bugs.webkit.org/show_bug.cgi?id=30785
3134
3135         * GNUmakefile.am: 
3136         * WebCore.gypi:
3137         * WebCore.vcproj/WebCore.vcproj:
3138         * WebCore.xcodeproj/project.pbxproj:
3139         * inspector/InspectorFrontend.cpp:
3140         (WebCore::InspectorFrontend::addRecordToTimeline):
3141         * inspector/InspectorFrontend.h:
3142         * inspector/InspectorTimelineAgent.cpp:
3143         (WebCore::InspectorTimelineAgent::willDispatchDOMEvent):
3144         (WebCore::InspectorTimelineAgent::didDispatchDOMEvent):
3145         (WebCore::InspectorTimelineAgent::willLayout):
3146         (WebCore::InspectorTimelineAgent::didLayout):
3147         (WebCore::InspectorTimelineAgent::willRecalculateStyle):
3148         (WebCore::InspectorTimelineAgent::didRecalculateStyle):
3149         (WebCore::InspectorTimelineAgent::willPaint):
3150         (WebCore::InspectorTimelineAgent::didPaint):
3151         (WebCore::InspectorTimelineAgent::willWriteHTML):
3152         (WebCore::InspectorTimelineAgent::didWriteHTML):
3153         (WebCore::InspectorTimelineAgent::didInstallTimer):
3154         (WebCore::InspectorTimelineAgent::didRemoveTimer):
3155         (WebCore::InspectorTimelineAgent::willFireTimer):
3156         (WebCore::InspectorTimelineAgent::didFireTimer):
3157         (WebCore::InspectorTimelineAgent::reset):
3158         (WebCore::InspectorTimelineAgent::addRecordToTimeline):
3159         (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
3160         (WebCore::InspectorTimelineAgent::pushCurrentRecord):
3161         * inspector/InspectorTimelineAgent.h:
3162         (WebCore::):
3163         (WebCore::InspectorTimelineAgent::RecordEntry::RecordEntry):
3164         * inspector/TimelineItemFactory.cpp: Removed.
3165         * inspector/TimelineItemFactory.h: Removed.
3166         * inspector/TimelineRecordFactory.cpp: Added.
3167         (WebCore::TimelineRecordFactory::createGenericRecord):
3168         (WebCore::TimelineRecordFactory::createDOMDispatchRecord):
3169         (WebCore::TimelineRecordFactory::createGenericTimerRecord):
3170         (WebCore::TimelineRecordFactory::createTimerInstallRecord):
3171         * inspector/TimelineRecordFactory.h: Added.
3172         (WebCore::TimelineRecordFactory::TimelineRecordFactory):
3173         * inspector/front-end/TimelineAgent.js:
3174         (WebInspector.addRecordToTimeline):
3175         * inspector/front-end/TimelinePanel.js:
3176         (WebInspector.TimelinePanel.prototype.addRecordToTimeline):
3177         (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
3178         (WebInspector.TimelinePanel.prototype.getRecordTypeName):
3179         (WebInspector.TimelineRecordTreeElement.prototype.onattach):
3180
3181 2009-10-26  Girish Ramakrishnan  <girish@forwardbias.in>
3182
3183         Reviewed by Antti Koivisto.
3184
3185         [Qt] Windowless Plugins : Print preview shows only part of flash when view is scrolled
3186         
3187         When printing, QPrinter's preview mode uses a QPicture to capture the output. The
3188         QPicture holds a reference to the X Pixmap. As a result, the print preview would
3189         update itself when the X Pixmap changes. To prevent the print preview from updating
3190         whenever m_drawable is updated (i.e when the view updates), we create a copy.
3191         
3192         We require that a QPixmap::copy() result in a QPixmap backed by a XPixmap
3193         regardless of the graphicssystem. This is taken care of by
3194         commit d310f7c710ecb331a9689861f0551eabd38e946e in Qt (4.6)
3195         
3196         The beauty of this patch is that the newly created X Pixmap is managed by Qt and
3197         it will free the Pixmap whenever the user closes the print preview dialog and
3198         handles the case of displaying multiple preview dialogs nicely.
3199         
3200         All credit to Samuel Rødal for suggesting usage of QPixmap::copy().
3201         
3202         https://bugs.webkit.org/show_bug.cgi?id=30714
3203
3204         * plugins/qt/PluginViewQt.cpp:
3205         (WebCore::PluginView::paint):
3206
3207 2009-10-26  Benjamin Otte  <otte@gnome.org>
3208
3209         Reviewed by Gustavo Noronha.
3210
3211         Don't store properties in the MediaPlayerPrivate class
3212
3213         Access them via the MediaPlayer class instead.
3214         https://bugs.webkit.org/show_bug.cgi?id=30462
3215
3216         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
3217         (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
3218         (WebCore::MediaPlayerPrivate::seek):
3219         (WebCore::MediaPlayerPrivate::setVolume):
3220         (WebCore::MediaPlayerPrivate::setRate):
3221         (WebCore::MediaPlayerPrivate::setVisible):
3222         (WebCore::MediaPlayerPrivate::paint):
3223         (WebCore::MediaPlayerPrivate::createGSTPlayBin):
3224         * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
3225
3226 2009-10-26  Brian Weinstein  <bweinstein@apple.com>
3227
3228         Reviewed by Timothy Hatcher.
3229
3230         Fixes <http://webkit.org/b/30801>.
3231         Web Inspector: Control + ]/[ on Windows doesn't change Panels.
3232         
3233         In my testing, Windows uses "U+00DB" and "U+00DD" to represent
3234         [ and ], so we should honor those as well.
3235
3236         * inspector/front-end/inspector.js:
3237         (WebInspector.documentKeyDown):
3238
3239 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3240
3241         Reviewed by Darin Adler.
3242
3243         Make .rc files compile on Windows without depending on MFC headers
3244         https://bugs.webkit.org/show_bug.cgi?id=30750
3245
3246         * WebCore.vcproj/QTMovieWin.rc: Use winresrc.h because it exists 
3247         even when MFC is not installed, and is all that's needed here.
3248
3249 2009-10-26  Brent Fulgham  <bfulgham@webkit.org>
3250
3251         Reviewed by Darin Adler.
3252
3253         Build corrections for ENABLE_FILTERS in Windows.
3254         https://bugs.webkit.org/show_bug.cgi?id=30797
3255
3256         Build correction for ENABLE_FILTERS feature.  No new tests needed.
3257
3258         * platform/graphics/filters/FEColorMatrix.cpp: Use MathExtras.h and
3259           its piDouble constant.
3260         * platform/graphics/filters/FEGaussianBlur.cpp: Use MathExtras.h and
3261           its piDouble constant.  Remove unnecessary call to floor used in
3262           the division of an unsigned, converting to int.
3263         * platform/graphics/win/SimpleFontDataCairoWin.cpp: Correct include
3264           style for MathExtras.h.
3265
3266 2009-10-26  Brady Eidson  <beidson@apple.com>
3267
3268         Reviewed by Darin Adler.
3269
3270         <rdar://problem/7289467> and http://webkit.org/b/30798 - REGRESSION (r48687): www.myuhc.com doesn't load.
3271
3272         Test: fast/loader/grandparent-completion-starts-redirect.html
3273
3274         * loader/FrameLoader.cpp:
3275         (WebCore::FrameLoader::completed): Notify all descendants that the load completed, not just direct children.
3276
3277 2009-10-26  Dan Bernstein  <mitz@apple.com>
3278
3279         Reviewed by Beth Dakin.
3280
3281         Re-add CSSPropertyWebkitBackgroundSize in one more place
3282
3283         Fixes transitions/multiple-background-size-transitions.html, transitions/background-transitions.html
3284
3285         * page/animation/AnimationBase.cpp:
3286         (WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper):
3287
3288 2009-10-26  Jeremy Orlow  <jorlow@chromium.org>
3289
3290         Reviewed by Dimitri Glazkov.
3291
3292         [V8] Tidy up the DOM Storage runtime flag stuff
3293         https://bugs.webkit.org/show_bug.cgi?id=30794
3294
3295         Clean up the DOM Storage runtime flag stuff to match the new way of doing
3296         things.  No behavioral changes.
3297
3298         * bindings/v8/RuntimeEnabledFeatures.cpp:
3299         * bindings/v8/RuntimeEnabledFeatures.h:
3300         (WebCore::RuntimeEnabledFeatures::setDatabaseEnabled):
3301         (WebCore::RuntimeEnabledFeatures::databaseEnabled):
3302         (WebCore::RuntimeEnabledFeatures::setLocalStorageEnabled):
3303         (WebCore::RuntimeEnabledFeatures::localStorageEnabled):
3304         (WebCore::RuntimeEnabledFeatures::setSessionStorageEnabled):
3305         (WebCore::RuntimeEnabledFeatures::sessionStorageEnabled):
3306         * bindings/v8/custom/V8DOMWindowCustom.cpp:
3307         (WebCore::ACCESSOR_RUNTIME_ENABLER):
3308         * storage/Storage.cpp:
3309         * storage/Storage.h:
3310
3311 2009-10-26  Brady Eidson  <beidson@apple.com>
3312
3313         Reviewed by Darin Adler.
3314
3315         <rdar://problem/7308952> and http://webkit.org/b/30424 - REGRESSION (r48687): Pages on ucas.com appear blank.
3316
3317         Test: fast/loader/history-forward-in-head.html
3318
3319         * loader/RedirectScheduler.cpp:
3320         (WebCore::RedirectScheduler::scheduleHistoryNavigation): Restore the moved canGoBackOrForward() check.
3321           This restores the side effect of an invalid history navigation canceling previous scheduled redirects
3322           and also fixes the bug of scheduling an invalid history navigation canceling parsing of the current document.
3323         (WebCore::RedirectScheduler::timerFired): Removed the canGoBackOrForward() check as it is now made before
3324           the redirect is scheduled.
3325
3326 2009-10-26  Alexey Proskuryakov  <ap@apple.com>
3327
3328         Reviewed by Darin Adler.
3329
3330         https://bugs.webkit.org/show_bug.cgi?id=30049
3331         <rdar://problem/7286002> Manipulating DOM from a script while parsing XHTML can cause a crash
3332
3333         Tests: fast/parser/remove-current-node-parent-x-2.xhtml
3334                fast/parser/remove-current-node-parent-x.xhtml
3335
3336         * dom/XMLTokenizer.h: Store the whole stack of parent nodes - element.parentNode() is
3337         unreliable after DOM manipulation.
3338
3339         * dom/XMLTokenizer.cpp:
3340         (WebCore::XMLTokenizer::pushCurrentNode): Push the new node onto stack.
3341         (WebCore::XMLTokenizer::popCurrentNode): This is now called instead of setCurrentNode when
3342         exiting a node.
3343         (WebCore::XMLTokenizer::clearCurrentNodeStack): We're aborting; or just done parsing. This
3344         replaces setCurrentNode(0).
3345         (WebCore::XMLTokenizer::enterText): Call pushCurrentNode().
3346         (WebCore::XMLTokenizer::exitText): Call popCurrentNode(), removing a long-standing FIXME
3347         (not sure if it was ever practical though - how can a parent become null while adding text?)
3348
3349         * dom/XMLTokenizerLibxml2.cpp:
3350         (WebCore::XMLTokenizer::~XMLTokenizer): Call clearCurrentNodeStack().
3351         (WebCore::XMLTokenizer::startElementNs): Call pushCurrentNode().
3352         (WebCore::XMLTokenizer::endElementNs): Call popCurrentNode() to safely get to a parent. Also
3353         added a check fo script element still being in document - Firefox parses those that aren't,
3354         but doesn't execute them.
3355
3356         * dom/XMLTokenizerQt.cpp:
3357         (WebCore::XMLTokenizer::~XMLTokenizer):
3358         (WebCore::XMLTokenizer::parseStartElement):
3359         (WebCore::XMLTokenizer::parseEndElement):
3360         Match libxml2 version changes.
3361
3362 2009-10-26  Dan Bernstein  <mitz@apple.com>
3363
3364         Reviewed by Beth Dakin.
3365
3366         background-size: X treated as background-size: X X, not background-size: X auto
3367         https://bugs.webkit.org/show_bug.cgi?id=28440
3368
3369         Updated fast/backgrounds/size/resources/parsing-background-size-values.js
3370         and fast/backgrounds/size/resources/parsing-inherit.js
3371
3372         Reinstated -webkit-background-size and kept its behavior of filling in
3373         the second value with the first one; and changed background-size to have
3374         the behavior of filling in the second value with 'auto'.
3375
3376         * css/CSSComputedStyleDeclaration.cpp:
3377         (computedProperties): Re-added CSSPropertyWebkitBackgroundSize.
3378         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Ditto.
3379         * css/CSSParser.cpp:
3380         (WebCore::CSSParser::parseValue): Ditto.
3381         (WebCore::CSSParser::parseFillSize): Adapted for the new parsing rule.
3382         (WebCore::CSSParser::parseFillProperty): Re-added
3383         CSSPropertyWebkitBackgroundSize.
3384         (WebCore::cssPropertyID): Removed mapping of -webkit-background-size to
3385         background-size.
3386         * css/CSSParser.h:
3387         * css/CSSPropertyNames.in: Re-added -webkit-background-size.
3388         * css/CSSStyleSelector.cpp:
3389         (WebCore::CSSStyleSelector::applyProperty): Re-added
3390         CSSPropertyWebkitBackgroundSize.
3391
3392 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3393
3394         Reviewed by Eric Seidel.
3395
3396         [Qt] Use "%lli" to format "long long" on WIN_OS to fix HTML5 WebDB crash
3397         https://bugs.webkit.org/show_bug.cgi?id=30777
3398
3399         No new tests as the crash can be reproduced by existing storage
3400         LayoutTests (by hitting an assert in debug mode Webkit on WIN_OS).
3401
3402         * platform/text/String.cpp:
3403         (WebCore::String::number): Qt's QString::vsprintf does not
3404         understand the "%I64u" format string. Always use the "%lli"
3405         format string for Qt port.
3406
3407 2009-10-26  Tony Chang  <tony@chromium.org>
3408
3409         Reviewed by Eric Seidel.
3410
3411         Roll back r50073 because r50041-50043 were reverted.  r50073 was
3412         a chromium side fix for r50041.
3413         https://bugs.webkit.org/show_bug.cgi?id=30789
3414
3415         * bindings/v8/V8Collection.h:
3416         * bindings/v8/custom/V8CustomBinding.h:
3417         * bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
3418         (WebCore::getNamedItems):
3419         (WebCore::getItem):
3420         (WebCore::NAMED_PROPERTY_GETTER):
3421         (WebCore::CALLBACK_FUNC_DECL):
3422         * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
3423         (WebCore::getNamedItems):
3424         (WebCore::getItem):
3425         (WebCore::NAMED_PROPERTY_GETTER):
3426         (WebCore::CALLBACK_FUNC_DECL):
3427         * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
3428
3429 2009-10-26  Geoffrey Garen  <ggaren@apple.com>
3430
3431         Reviewed by Dimitri Glazkov.
3432
3433         Fixed https://bugs.webkit.org/show_bug.cgi?id=30765
3434         REGRESSION (r48701): Removing an event listener causes the one added just after it not to fire
3435         
3436         and related bugs.
3437
3438         If the event listener being removed is prior to the current firing event
3439         iterator, we need to decrement the current firing event iterator in
3440         addition to the endpoint. (Otherwise, shrinking the event listener vector
3441         by one implicity moves the current firing event iterator forward by one.
3442         It's like relativity, only without the planets.)
3443         
3444         Also took the opportunity to change some pointers to references, since
3445         they can't be null.
3446
3447         * dom/EventTarget.cpp:
3448         (WebCore::EventTarget::removeEventListener):
3449         (WebCore::EventTarget::removeAllEventListeners): Update iterator in addition
3450         to end, if need be.
3451         (WebCore::EventTarget::fireEventListeners): Updated for interface changes.
3452         Added a comment to explain a behavior that was implicit enough to be
3453         confusing.
3454
3455         * dom/EventTarget.h:
3456         (WebCore::FiringEventIterator::FiringEventIterator):
3457         (WebCore::EventTarget::isFiringEventListeners): Updated for interface changes.
3458
3459 2009-10-26  Brian Weinstein  <bweinstein@apple.com>
3460
3461         Reviewed by Timothy Hatcher.
3462
3463         Fixes <http://webkit.org/b/30792>.
3464         Web Inspector: When changing resource scope, resource graph can get in weird state.
3465         
3466         If the user was scrolled down while looking at All resources, and then just
3467         selects Fonts, or something that doesn't have many resources, then the graph
3468         will stay scrolled down, even when there is no content there.
3469         
3470         When the filter is updated, scroll to the top of the graph view, so this won't
3471         happen.
3472
3473         * inspector/front-end/AbstractTimelinePanel.js:
3474         (WebInspector.AbstractTimelinePanel.prototype._updateFilter):
3475
3476 2009-10-26  Sam Weinig  <sam@webkit.org>
3477
3478         Fix mac clean build.
3479
3480         * html/HTMLOptionsCollection.idl:
3481
3482 2009-10-26  Pavel Feldman  <pfeldman@chromium.org>
3483
3484         Reviewed by Timothy Hatcher.
3485
3486         Web Inspector: Extract AbstractTimelinePanel that will be a base
3487         class for ResourcesPanel and TimelinePanel.
3488
3489         https://bugs.webkit.org/show_bug.cgi?id=30776
3490
3491         * WebCore.gypi:
3492         * WebCore.vcproj/WebCore.vcproj:
3493         * inspector/front-end/AbstractTimelinePanel.js: Added.
3494         (WebInspector.AbstractTimelinePanel):
3495         (WebInspector.AbstractTimelinePanel.prototype.get categories):
3496         (WebInspector.AbstractTimelinePanel.prototype.showCategory):
3497         (WebInspector.AbstractTimelinePanel.prototype.hideCategory):
3498         (WebInspector.AbstractTimelinePanel.prototype.createTimelinePanels):
3499         (WebInspector.AbstractTimelinePanel.prototype._createFilterPanel.createFilterElement):
3500         (WebInspector.AbstractTimelinePanel.prototype._createFilterPanel):
3501         (WebInspector.AbstractTimelinePanel.prototype.filter):
3502         (WebInspector.AbstractTimelinePanel.prototype._updateFilter):
3503         (WebInspector.AbstractTimelinePanel.prototype._createGraph):
3504         (WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
3505         (WebInspector.AbstractTimelinePanel.prototype._updateSummaryGraph):
3506         (WebInspector.AbstractTimelinePanel.prototype._updateDividersLabelBarPosition):
3507         (WebInspector.AbstractTimelinePanel.prototype.get needsRefresh):
3508         (WebInspector.AbstractTimelinePanel.prototype.set needsRefresh):
3509         (WebInspector.AbstractTimelinePanel.prototype.refreshIfNeeded):
3510         (WebInspector.AbstractTimelinePanel.prototype.show):
3511         (WebInspector.AbstractTimelinePanel.prototype.resize):
3512         (WebInspector.AbstractTimelinePanel.prototype.updateMainViewWidth):
3513         (WebInspector.TimelineCalculator):
3514         (WebInspector.TimelineCalculator.prototype.computeSummaryValues):
3515         (WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages):
3516         (WebInspector.TimelineCalculator.prototype.computeBarGraphLabels):
3517         (WebInspector.TimelineCalculator.prototype.get boundarySpan):
3518         (WebInspector.TimelineCalculator.prototype.updateBoundaries):
3519         (WebInspector.TimelineCalculator.prototype.reset):
3520         (WebInspector.TimelineCalculator.prototype._value):
3521         (WebInspector.TimelineCalculator.prototype.formatValue):
3522         * inspector/front-end/ResourceCategory.js:
3523         (WebInspector.ResourceCategory):
3524         * inspector/front-end/ResourcesPanel.js:
3525         (WebInspector.ResourcesPanel):
3526         (WebInspector.ResourcesPanel.prototype.toolbarItemClass.get toolbarItemLabel):
3527         (WebInspector.ResourcesPanel.prototype.get statusBarItems):
3528         (WebInspector.ResourcesPanel.prototype.get categories):
3529         (WebInspector.ResourcesPanel.prototype.showCategory):
3530         (WebInspector.ResourcesPanel.prototype.hideCategory):
3531         (WebInspector.ResourcesPanel.prototype.isCategoryVisible):
3532         (WebInspector.ResourcesPanel.prototype.populateSidebar):
3533         (WebInspector.ResourcesPanel.prototype.createPanelEnabler):
3534         (WebInspector.ResourcesPanel.prototype.createStatusbarButtons):
3535         (WebInspector.ResourcesPanel.prototype.set mainResourceLoadTime):
3536         (WebInspector.ResourcesPanel.prototype.set mainResourceDOMContentTime):
3537         (WebInspector.ResourcesPanel.prototype.show):
3538         (WebInspector.ResourcesPanel.prototype.resize):
3539         (WebInspector.ResourcesPanel.prototype.reset):
3540         (WebInspector.ResourcesPanel.prototype.updateGraphDividersIfNeeded):
3541         (WebInspector.ResourcesPanel.prototype.updateMainViewWidth):
3542         (WebInspector.ResourceTimeCalculator):
3543         (WebInspector.ResourceTransferSizeCalculator):
3544         (WebInspector.ResourceTransferSizeCalculator.prototype.computeBarGraphLabels):
3545         * inspector/front-end/SummaryBar.js:
3546         (WebInspector.SummaryBar.prototype.update):
3547         * inspector/front-end/WebKit.qrc:
3548         * inspector/front-end/inspector.html:
3549         * inspector/front-end/inspector.js:
3550         (WebInspector.loaded):
3551
3552 2009-10-26  Avi Drissman  <avi@google.com>
3553
3554         Reviewed by Darin Adler.
3555
3556         Use Helvetica in the Inspector as intended.
3557         https://bugs.webkit.org/show_bug.cgi?id=30787
3558
3559         * inspector/front-end/inspector.css:
3560
3561 2009-10-26  Nate Chapin  <japhet@chromium.org>
3562
3563         Reviewed by Alexey Proskuryakov.
3564
3565         Don't set window.opener to 0 for the current FrameLoader if a noreferrer link was clicked, only suppress opener in a new frame.
3566         https://bugs.webkit.org/show_bug.cgi?id=30781
3567
3568         * loader/FrameLoader.cpp:
3569         (WebCore::FrameLoader::urlSelected): Don't suppress opener in the current frame for noreferrer navigations.
3570
3571 2009-10-26  Ryosuke Niwa  <rniwa@webkit.org>
3572
3573         Reviewed by Eric Seidel.
3574
3575         Data loss occurs when unbolding nested bold tags.
3576         https://bugs.webkit.org/show_bug.cgi?id=30083
3577
3578         Fixes the loop in swapInNodePreservingAttributesAndChildren by saving nextSibling() of child
3579         to a temporary valuable.  It was originally calling nextSibling() after appending the child
3580         to new parent, in which case, nextSibling is always 0.
3581
3582         Test: editing/style/unbolding-nested-b.html
3583
3584         * editing/ReplaceNodeWithSpanCommand.cpp:
3585         (WebCore::swapInNodePreservingAttributesAndChildren):
3586
3587 2009-10-21  Jeremy Orlow  <jorlow@chromium.org>
3588
3589         Reviewed by Darin Adler.
3590
3591         Storage events should use Document::url() rather than documentURI()
3592         https://bugs.webkit.org/show_bug.cgi?id=30535
3593
3594         Storage events should use Document::url() rather than Document::documentURI()
3595         per http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2009-October/023703.html
3596
3597         Test: storage/domstorage/documentURI.html
3598
3599         * storage/StorageEventDispatcher.cpp:
3600         (WebCore::StorageEventDispatcher::dispatch):
3601
3602 2009-10-26  Sam Weinig  <sam@webkit.org>
3603
3604         Rubber-stamped by Darin Adler.
3605
3606         Rollout r50041-50043.  The HTML5 spec changed to make HTMLOptionsCollection
3607         inherit from HTMLCollection.
3608
3609         * GNUmakefile.am:
3610         * WebCore.gypi:
3611         * WebCore.pro:
3612         * WebCore.vcproj/WebCore.vcproj:
3613         * WebCore.xcodeproj/project.pbxproj:
3614         * bindings/js/JSHTMLAllCollectionCustom.cpp:
3615         (WebCore::getNamedItems):
3616         (WebCore::callHTMLAllCollection):
3617         (WebCore::JSHTMLAllCollection::nameGetter):
3618         (WebCore::JSHTMLAllCollection::item):
3619         (WebCore::JSHTMLAllCollection::namedItem):
3620         * bindings/js/JSHTMLCollectionCustom.cpp:
3621         (WebCore::getNamedItems):
3622         (WebCore::callHTMLCollection):
3623         (WebCore::JSHTMLCollection::nameGetter):
3624         (WebCore::JSHTMLCollection::item):
3625         (WebCore::JSHTMLCollection::namedItem):
3626         (WebCore::toJS):
3627         * bindings/js/JSHTMLCollectionFunctions.h: Removed.
3628         * bindings/js/JSHTMLDocumentCustom.cpp:
3629         * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
3630         (WebCore::JSHTMLOptionsCollection::length):
3631         (WebCore::JSHTMLOptionsCollection::indexSetter):
3632         * bindings/objc/DOMHTML.mm:
3633         (kitClass):
3634         * bindings/objc/DOMUtility.mm:
3635         (JSC::createDOMWrapper):
3636         * bindings/scripts/CodeGeneratorJS.pm:
3637         * html/HTMLCollection.idl:
3638         * html/HTMLOptionsCollection.idl:
3639
3640 2009-10-26  Brent Fulgham  <bfulgham@webkit.org>
3641
3642         Reviewed by Adam Roben.
3643
3644         Build fix for ENABLE_FILTERS under Windows.
3645         https://bugs.webkit.org/show_bug.cgi?id=30762
3646
3647         Build correction for ENABLE_FILTERS feature.  No new tests needed.
3648
3649         * WebCore.vcproj/WebCore.vcproj:  Make the following changes:
3650           (1) Create a new 'filters' sub-folder of the platform/graphics 
3651               folder to properly show the sources held in this directory.
3652           (2) Move the files that are currently shown in svn/graphics/filters
3653               to platform/graphics/filters (where they actually live on disk).
3654           (3) Add the missing SVGFilter, SVGFilterBuilder, and SVGFETile to
3655               the project so they are built.
3656           (4) Remove SVGFEFloodElement.cpp from the build, since it is already
3657               being compiled by SVGAllInOne.cpp.  Its presence as a separate
3658               entity is causing a linker warning for duplicate symbols.
3659           (5) Add ImageBuffer.cpp to the build to support color space
3660               calculations for non-CG builds.
3661         * WebCore.vcproj/WebCoreCommon.vsprops: Add the platform/graphics/filters
3662           path to the search paths in the project.
3663
3664 2009-10-26  Keishi Hattori  <casey.hattori@gmail.com>
3665
3666         Reviewed by Timothy Hatcher.
3667
3668         console.assert should prefix messages with "Assertion failed: "
3669         https://bugs.webkit.org/show_bug.cgi?id=19135
3670
3671         * English.lproj/localizedStrings.js:
3672         * inspector/front-end/ConsoleView.js:
3673         (WebInspector.ConsoleMessage.prototype.toMessageElement): Append "Assertion failed: " for AssertMessageType.
3674         (WebInspector.ConsoleMessage.prototype.toString):
3675         * page/Console.cpp:
3676         (WebCore::Console::assertCondition): Use AssertMessageType.
3677         * page/Console.h:
3678         (WebCore::MessageType): Added AssertMessageType.
3679
3680 2009-10-26  Rahul Kuchhal  <kuchhal@chromium.org>
3681
3682         Reviewed by Eric Seidel.
3683
3684         Prevent crash when optgroup element is empty by adding a NULL check.
3685
3686         https://bugs.webkit.org/show_bug.cgi?id=30365
3687
3688         Test: fast/forms/select-empty-optgroup.html
3689
3690         * dom/SelectElement.cpp:
3691         (WebCore::SelectElement::appendFormData):
3692
3693 2009-10-21  Steven Knight  <sgk@chromium.org>
3694
3695         Reviewed by David Levin.
3696
3697         Refactor gyp for separate webcore_bindings{,_sources} targets.
3698
3699         https://bugs.webkit.org/show_bug.cgi?id=30447
3700
3701         Handle long link lines by building .idl-generated bindings in a
3702         separate webcore_bindings library target.  Avoid Visual Studio
3703         dependency issues by building additional generated .cpp and .h files
3704         in a separate webcore_bindings_sources target.
3705
3706         Chrome should still build and test successfully.
3707
3708         * WebCore.gyp/WebCore.gyp:
3709         * WebCore.gypi:
3710
3711 2009-10-26  Mike Belshe  <mike@belshe.com>
3712
3713         Reviewed by Darin Fisher.
3714
3715         Make the number of connections for chromium controlled by
3716         chromium rather than by ResourceRequestBase.
3717         https://bugs.webkit.org/show_bug.cgi?id=30661
3718
3719         * platform/network/ResourceRequestBase.cpp:
3720         * platform/network/chromium/ResourceRequest.cpp:
3721
3722 2009-10-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3723
3724         Unreviewed. make distcheck build fixes.
3725
3726         * GNUmakefile.am:
3727
3728 2009-10-26  Anton Muhin  <antonm@chromium.org>
3729
3730         Reviewed by Dimitri Glazkov.
3731
3732         Unbreak Chromium build: that requires adding custom implementations
3733         for HTMLOptionsCollection's item and namedItem.  Keep v8 binding
3734         close to JSC bindings as well.
3735         https://bugs.webkit.org/show_bug.cgi?id=30780
3736
3737         * bindings/v8/V8Collection.h:
3738         (WebCore::getNamedItemsFromCollection):
3739         (WebCore::getItemFromCollection):
3740         * bindings/v8/custom/V8CustomBinding.h:
3741         * bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:
3742         (WebCore::NAMED_PROPERTY_GETTER):
3743         (WebCore::CALLBACK_FUNC_DECL):
3744         * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
3745         (WebCore::NAMED_PROPERTY_GETTER):
3746         (WebCore::CALLBACK_FUNC_DECL):
3747         * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
3748         (WebCore::CALLBACK_FUNC_DECL):
3749
3750 2009-10-23  Alexey Proskuryakov  <ap@apple.com>
3751
3752         Reviewed by Adam Barth and Darin Adler.
3753
3754         https://bugs.webkit.org/show_bug.cgi?id=30723
3755         <rdar://problem/6189415> Input names added to multipart/form-data headers need to be escaped.
3756
3757         Test: http/tests/security/escape-form-data-field-names.html
3758
3759         * platform/network/FormDataBuilder.cpp:
3760         (WebCore::appendQuotedString):
3761         (WebCore::FormDataBuilder::beginMultiPartHeader):
3762         (WebCore::FormDataBuilder::addFilenameToMultiPartHeader):
3763         Percent-escape line breaks and quotation marks.
3764
3765 2009-10-26  Kelly Norton  <knorton@google.com>
3766
3767         Reviewed by Pavel Feldman.
3768
3769         Adds DOMTimer support to InspectorTimelineAgent.
3770         https://bugs.webkit.org/show_bug.cgi?id=30467
3771
3772         * inspector/InspectorTimelineAgent.cpp: Added timer support and fixed some method names.
3773         (WebCore::InspectorTimelineAgent::didDispatchDOMEvent):
3774         (WebCore::InspectorTimelineAgent::didLayout):
3775         (WebCore::InspectorTimelineAgent::didRecalculateStyle):
3776         (WebCore::InspectorTimelineAgent::didPaint):
3777         (WebCore::InspectorTimelineAgent::didWriteHTML):
3778         (WebCore::InspectorTimelineAgent::didInstallTimer): Added.
3779         (WebCore::InspectorTimelineAgent::didRemoveTimer): Added.
3780         (WebCore::InspectorTimelineAgent::willFireTimer): Added.
3781         (WebCore::InspectorTimelineAgent::didFireTimer): Added.
3782         (WebCore::InspectorTimelineAgent::addItemToTimeline): Added.
3783         (WebCore::InspectorTimelineAgent::didCompleteCurrentTimelineItem): Renamed.
3784         * inspector/InspectorTimelineAgent.h:
3785         (WebCore::):
3786         * inspector/TimelineItemFactory.cpp: Add methods for timer-related ScriptObjects.
3787         (WebCore::TimelineItemFactory::createGenericTimerTimelineItem):
3788         (WebCore::TimelineItemFactory::createTimerInstallTimelineItem):
3789         * inspector/TimelineItemFactory.h:
3790         * page/DOMTimer.cpp: Added instrumentation points.
3791         (WebCore::DOMTimer::install):
3792         (WebCore::DOMTimer::removeById):
3793         (WebCore::DOMTimer::fired):
3794
3795 2009-10-26  Simon Fraser  <simon.fraser@apple.com>
3796
3797         Reviewed by Sam Weinig.
3798
3799         <rdar://problem/6988966> Hardware layers do not show up in page snapshots
3800
3801         Add a method that gets called when snapshotting Canvas3DLayers for page snapshots,
3802         that allows the layer to return a CGImageRef of its contents.
3803         
3804         * platform/graphics/mac/Canvas3DLayer.h:
3805         * platform/graphics/mac/Canvas3DLayer.mm:
3806         (-[Canvas3DLayer copyImageSnapshotWithColorSpace:]):
3807
3808 2009-10-26  Yury Semikhatsky  <yurys@chromium.org>
3809
3810         Reviewed by Pavel Feldman.
3811
3812         Pass "console" as object group when evaluating selection.
3813
3814         https://bugs.webkit.org/show_bug.cgi?id=30738
3815
3816         * inspector/front-end/SourceFrame.js:
3817         (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
3818
3819 2009-10-26  Keishi Hattori  <casey.hattori@gmail.com>
3820
3821         Reviewed by Pavel Feldman.
3822
3823         Fix for Console not showing repeat count when repeatedly logging an Event
3824         https://bugs.webkit.org/show_bug.cgi?id=30324
3825
3826         * inspector/ConsoleMessage.cpp:
3827         (WebCore::ConsoleMessage::addToConsole):
3828         (WebCore::ConsoleMessage::updateRepeatCountInConsole): Added.
3829         * inspector/ConsoleMessage.h:
3830         * inspector/InspectorController.cpp:
3831         (WebCore::InspectorController::addConsoleMessage): Calls updateRepeatCountInConsole if it is a repeating message.
3832         * inspector/InspectorFrontend.cpp:
3833         (WebCore::InspectorFrontend::addConsoleMessage): Renamed WebCore::InspectorFrontend::addMessageToConsole
3834         (WebCore::InspectorFrontend::updateConsoleMessageRepeatCount): Added. Called when repeatCount is incremented.
3835         * inspector/InspectorFrontend.h:
3836         * inspector/front-end/ConsoleView.js:
3837         (WebInspector.ConsoleView.prototype.addMessage): Removed calls to msg.isEqual.
3838         (WebInspector.ConsoleView.prototype.updateMessageRepeatCount): Added.
3839         (WebInspector.ConsoleView.prototype._incrementErrorWarningCount): Added. Updates the error/warning count.
3840         (WebInspector.ConsoleView.prototype.clearMessages):
3841         (WebInspector.ConsoleMessage):
3842         (WebInspector.ConsoleMessage.prototype.toMessageElement): Use ConsoleMessage._updateRepeatCount
3843         (WebInspector.ConsoleMessage.prototype._updateRepeatCount):
3844         * inspector/front-end/inspector.js:
3845         (WebInspector.addConsoleMessage): Renamed WebInspector.addMessageToConsole.
3846         (WebInspector.updateConsoleMessageRepeatCount): Added.
3847
3848 2009-10-26  Chris Fleizach  <cfleizach@apple.com>
3849
3850         Reviewed by Darin Adler.
3851
3852         crash with AX on when an image map contains an anchor tag
3853         https://bugs.webkit.org/show_bug.cgi?id=30739
3854
3855         Tests: accessibility/crashing-a-tag-in-map.html
3856
3857         * accessibility/AccessibilityRenderObject.cpp:
3858         (WebCore::AccessibilityRenderObject::addChildren):
3859
3860 2009-10-26  Steve Block  <steveblock@google.com>
3861
3862         Reviewed by Eric Seidel.
3863
3864         Adds feature ENABLE guards to V8 bindings.
3865         https://bugs.webkit.org/show_bug.cgi?id=30697
3866
3867         This adds guards for the following features to the V8 bindings,
3868         to allow builds with V8 to succeed when these features are not enabled.
3869         - DATABASE
3870         - WORKERS
3871         - SHARED_WORKERS
3872         - SVG
3873         - XPATH
3874         - XSLT
3875         - INSPECTOR
3876
3877         This is a build fix only, no new tests required.
3878
3879         * bindings/v8/DOMObjectsInclude.h: Modified.
3880         * bindings/v8/DerivedSourcesAllInOne.cpp: Modified.
3881         * bindings/v8/V8Index.cpp: Modified.
3882         * bindings/v8/V8Index.h: Modified.
3883
3884 2009-10-26  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
3885
3886         Reviewed by Xan Lopez.
3887
3888         https://bugs.webkit.org/show_bug.cgi?id=25679
3889         [Gtk] Improve accessibility of focusable lists
3890
3891         Fixes the issues with the Atk states exposed for ListBoxOption
3892
3893         * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
3894         (setAtkStateSetFromCoreObject):
3895
3896 2009-10-26  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
3897
3898         Reviewed by Xan Lopez.
3899
3900         https://bugs.webkit.org/show_bug.cgi?id=27085
3901         [Gtk] Incorrect rendering of list
3902
3903         Adds a way for platforms to indicate that a particular object
3904         should not be ignored.
3905
3906         * accessibility/AccessibilityObject.h:
3907         * accessibility/chromium/AccessibilityObjectChromium.cpp:
3908         * accessibility/gtk/AccessibilityObjectAtk.cpp:
3909         * accessibility/mac/AccessibilityObjectMac.mm:
3910         * accessibility/qt/AccessibilityObjectQt.cpp:
3911         * accessibility/win/AccessibilityObjectWin.cpp:
3912         * accessibility/wx/AccessibilityObjectWx.cpp:
3913         (AccessibilityObject::accessibilityPlatformIncludesObject):
3914         * accessibility/AccessibilityRenderObject.cpp:
3915         (AccessibilityRenderObject::accessibilityIsIgnored):
3916
3917 2009-10-26  Kinuko Yasuda  <kinuko@google.com>
3918
3919         Reviewed by Jan Alonzo.
3920
3921         Bug 30619: [Linux] Menu key doesn't work
3922         https://bugs.webkit.org/show_bug.cgi?id=30619
3923
3924         Test: manual-tests/keyboard-menukey-event.html
3925         No new layout tests: testing this will require changes in the test
3926         controller in a platform-specific way.
3927
3928         * platform/chromium/KeyCodeConversionGtk.cpp:
3929         (WebCore::windowsKeyCodeForKeyEvent): changed switch-case code for
3930         GDK_Menu to return VKEY_APPS instead of VKEY_MENU.
3931         * platform/gtk/KeyEventGtk.cpp:
3932         (WebCore::windowsKeyCodeForKeyEvent): changed switch-case code for
3933         GDK_Menu to return V_APPS instead of VK_MENU.
3934
3935 2009-10-25  Anton Muhin  <antonm@chromium.org>
3936
3937         Reviewed by Adam Barth.
3938
3939         Reuse already fetched proxy.
3940         https://bugs.webkit.org/show_bug.cgi?id=30747
3941
3942         * bindings/v8/V8DOMWrapper.cpp:
3943         (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
3944
3945 2009-10-25  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3946
3947         Unreviewed build fix.
3948
3949         Build fix for WIN_OS if Netscape plugin support is turned off
3950         https://bugs.webkit.org/show_bug.cgi?id=30753
3951
3952         * plugins/PluginDatabase.cpp:
3953
3954 2009-10-25  Hironori Bono  <hbono@chromium.org>
3955
3956         Reviewed by Darin Adler.
3957
3958         A quick fix for Bug 29103.
3959         Since String::startsWith() cannot fold non-ASCII characters, this change folds the prefix string
3960         and the option string before calling String::startsWith().
3961         https://bugs.webkit.org/show_bug.cgi?id=29103
3962
3963         Tests: fast/forms/listbox-typeahead-cyrillic.html
3964                fast/forms/listbox-typeahead-greek.html
3965
3966         * dom/SelectElement.cpp:
3967         (WebCore::SelectElement::typeAheadFind):
3968
3969 2009-10-25  Keishi Hattori  <casey.hattori@gmail.com>
3970
3971         Reviewed by Timothy Hatcher.
3972
3973         Web Inspector: Expanding a node in the Console should not show the element in Elements panel
3974         https://bugs.webkit.org/show_bug.cgi?id=30749
3975
3976         * inspector/front-end/ElementsTreeOutline.js:
3977         (WebInspector.ElementsTreeElement.prototype.onmousedown): Check if inside disclosure triangle.
3978
3979 2009-10-25  Sam Weinig  <sam@webkit.org>
3980
3981         Reviewed by Dan Bernstein.
3982
3983         Fix for https://bugs.webkit.org/show_bug.cgi?id=30751
3984         HTMLOptionsCollection should not inherit from HTMLCollection
3985
3986         * GNUmakefile.am:
3987         * WebCore.gypi:
3988         * WebCore.pro:
3989         * WebCore.vcproj/WebCore.vcproj:
3990         * WebCore.xcodeproj/project.pbxproj:
3991         Added JSHTMLCollectionFunctions.h
3992
3993         * bindings/js/JSHTMLAllCollectionCustom.cpp:
3994         (WebCore::callHTMLAllCollection):
3995         (WebCore::JSHTMLAllCollection::nameGetter):
3996         (WebCore::JSHTMLAllCollection::item):
3997         (WebCore::JSHTMLAllCollection::namedItem):
3998         * bindings/js/JSHTMLCollectionCustom.cpp:
3999         (WebCore::callHTMLCollection):
4000         (WebCore::JSHTMLCollection::nameGetter):
4001         (WebCore::JSHTMLCollection::item):
4002         (WebCore::JSHTMLCollection::namedItem):
4003         * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
4004         (WebCore::callHTMLCollection):
4005         (WebCore::JSHTMLOptionsCollection::getCallData):
4006         (WebCore::JSHTMLOptionsCollection::canGetItemsForName):
4007         (WebCore::JSHTMLOptionsCollection::nameGetter):
4008         (WebCore::JSHTMLOptionsCollection::indexSetter):
4009         (WebCore::JSHTMLOptionsCollection::item):
4010         (WebCore::JSHTMLOptionsCollection::namedItem):
4011         Refactor to use generic implementation of HTMLCollection bindings functions
4012         from JSHTMLCollectionFunctions.h
4013
4014         * bindings/js/JSHTMLCollectionFunctions.h: Added.
4015         (WebCore::getCollectionNamedItems):
4016         (WebCore::getCollectionItems):
4017         (WebCore::callHTMLCollectionGeneric):
4018         Added generic functions that JSHTMLCollection, JSHTMLAllCollection and
4019         JSHTMLOptionsCollection can all use.
4020
4021         * bindings/js/JSHTMLDocumentCustom.cpp: Add include of JSHTMLAllCollection.h
4022         for toJS on document.all.
4023
4024         * bindings/objc/DOMHTML.mm:
4025         * bindings/objc/DOMUtility.mm:
4026         (JSC::createDOMWrapper):
4027         Remove special cases for HTMLOptionsCollection.
4028
4029         * bindings/scripts/CodeGeneratorJS.pm:
4030         * html/HTMLAllCollection.idl:
4031         * html/HTMLCollection.idl:
4032         * html/HTMLOptionsCollection.idl:
4033
4034 2009-10-24  Keishi Hattori  <casey.hattori@gmail.com>
4035
4036         Reviewed by Timothy Hatcher.
4037
4038         WebInspector: Fixed issue with IME inside console
4039         https://bugs.webkit.org/show_bug.cgi?id=30660
4040
4041         * inspector/front-end/ConsoleView.js:
4042         (WebInspector.ConsoleView.prototype._promptKeyDown):
4043         * inspector/front-end/DatabaseQueryView.js:
4044         (WebInspector.DatabaseQueryView.prototype._promptKeyDown):
4045         * inspector/front-end/inspector.js:
4046         (WebInspector.loaded):
4047         (WebInspector.searchKeyDown): Moved performSearch here from WebInspector.searchKeyUp.
4048         (WebInspector.startEditing.element.handleKeyEvent):
4049         (WebInspector.startEditing):
4050         * inspector/front-end/utilities.js:
4051         (isEnterKey): Added. Check if in IME.
4052
4053 2009-10-24  Brian Weinstein  <bweinstein@apple.com>
4054
4055         Reviewed by Timothy Hatcher.
4056
4057         Fixes <https://bugs.webkit.org/show_bug.cgi?id=30752>.
4058         Web Inspector: Multiple Selection on Scope Bars by default Conflicts with other behavior on OSX.
4059         
4060         Have the scope bars select one scope by default, but if the multiple selection key
4061         is pressed, allow for multiple selection.
4062
4063         * inspector/front-end/ConsoleView.js:
4064         (WebInspector.ConsoleView):
4065         (WebInspector.ConsoleView.prototype._updateFilter):
4066         (WebInspector.ConsoleView.prototype.filter):
4067         * inspector/front-end/ResourcesPanel.js:
4068         (WebInspector.ResourcesPanel):
4069         (WebInspector.ResourcesPanel.prototype.filter):
4070         (WebInspector.ResourcesPanel.prototype._updateFilter):
4071
4072 2009-10-24  Timothy Hatcher  <timothy@apple.com>
4073
4074         Make the scope bars in the Web Inspector match other scope bars in Mac OS X.
4075         Also cleans up the CSS to use classes instead of ID selectors.
4076
4077         https://bugs.webkit.org/show_bug.cgi?id=28186
4078
4079         Reviewed by Dan Bernstein.
4080
4081         * inspector/front-end/ResourcesPanel.js: Add the scope-bar class.
4082         * inspector/front-end/inspector.css: Lots of changes to make it look right.
4083         * inspector/front-end/inspector.html: Add the scope-bar class.
4084
4085 2009-10-24  Timothy Hatcher  <timothy@apple.com>
4086
4087         Fix selecting Resources in the Web Inspector's Resources panel.
4088
4089         https://bugs.webkit.org/show_bug.cgi?id=30743
4090
4091         Reviewed by Pavel Feldman.
4092
4093         * inspector/front-end/ResourcesPanel.js:
4094         (WebInspector.ResourcesPanel.prototype.isCategoryVisible): Added.
4095         (WebInspector.ResourceSidebarTreeElement.prototype.get selectable): Call
4096         isCategoryVisible on the ResourcesPanel.
4097
4098 2009-10-24  Timothy Hatcher  <timothy@apple.com>
4099
4100         Fix the Scope Bar in the Web Inspector's Resource panel, so that selecting
4101         All will deselect the other filters.
4102
4103         https://bugs.webkit.org/show_bug.cgi?id=30744
4104
4105         Reviewed by Pavel Feldman.
4106
4107         * inspector/front-end/ResourcesPanel.js:
4108         (WebInspector.ResourcesPanel.createFilterElement): Better syntax.
4109         (WebInspector.ResourcesPanel):
4110         (WebInspector.ResourcesPanel.prototype.filter): Use a normal for loop,
4111         and the child variable instead of target in the loop. Other clean up.
4112
4113 2009-10-24  Timothy Hatcher  <timothy@apple.com>
4114
4115         Make resizing the Web Inspector's Elements panel sidebar work again.
4116         Also makes Resources panel use the sidebar code in Panel.
4117
4118         https://bugs.webkit.org/show_bug.cgi?id=30742
4119
4120         Reviewed by Pavel Feldman.
4121
4122         * inspector/front-end/Panel.js:
4123         (WebInspector.Panel): Don't create the sidebar with an argument.
4124         (WebInspector.Panel.prototype.show): Call updateSidebarWidth.
4125         (WebInspector.Panel.prototype.handleKeyEvent): Call handleSidebarKeyEvent.
4126         (WebInspector.Panel.prototype.handleSidebarKeyEvent): Added.
4127         (WebInspector.Panel.prototype.createSidebar): Renamed from _createSidebar.
4128         (WebInspector.Panel.prototype._sidebarDragging): Call updateSidebarWidth.
4129         (WebInspector.Panel.prototype.updateSidebarWidth): Renamed from _updateSidebarWidth.
4130         (WebInspector.Panel.prototype.setSidebarWidth): Added. Called by updateSidebarWidth.
4131         (WebInspector.Panel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.
4132         * inspector/front-end/ProfilesPanel.js:
4133         (WebInspector.ProfilesPanel): Call createSidebar.
4134         (WebInspector.ProfilesPanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.
4135         * inspector/front-end/ResourcesPanel.js:
4136         (WebInspector.ResourcesPanel.prototype.show): Remove call to _updateSidebarWidth.
4137         (WebInspector.ResourcesPanel.prototype.showResource): Call updateSidebarWidth
4138         (WebInspector.ResourcesPanel.prototype.closeVisibleResource): Ditto.
4139         (WebInspector.ResourcesPanel.prototype.setSidebarWidth): Added.
4140         (WebInspector.ResourcesPanel.prototype.updateMainViewWidth): Added.
4141         * inspector/front-end/StoragePanel.js:
4142         (WebInspector.StoragePanel): Call createSidebar.
4143         (WebInspector.StoragePanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.
4144         * inspector/front-end/TimelinePanel.js:
4145         (WebInspector.TimelinePanel): Call createSidebar.
4146         (WebInspector.TimelinePanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.
4147
4148 2009-10-24  Timothy Hatcher  <timothy@apple.com>
4149
4150         Call updateSelection() in a few places so hovering in the Web Inspector's
4151         Elements panel always has the correct row selection height.
4152
4153         https://bugs.webkit.org/show_bug.cgi?id=30735
4154
4155         Reviewed by Pavel Feldman.
4156
4157         * inspector/front-end/ElementsTreeOutline.js:
4158         (WebInspector.ElementsTreeElement.prototype.toggleNewAttributeButton): Call updateSelection().
4159         (WebInspector.ElementsTreeElement.prototype._insertInLastAttributePosition): Ditto.
4160         * inspector/front-end/inspector.css: Prevent text wrapping in the middle of the add attribute text.
4161
4162 2009-10-24  Timothy Hatcher  <timothy@apple.com>
4163
4164         Remove the re-root tree feature from the Web Inspector's
4165         Elements panel. This feature wasn't super useful and gets
4166         in the way of double-click to edit.
4167
4168         https://bugs.webkit.org/show_bug.cgi?id=30736
4169
4170         Reviewed by Pavel Feldman.
4171
4172         * inspector/front-end/ElementsTreeOutline.js:
4173         (WebInspector.ElementsTreeElement.prototype.ondblclick):
4174
4175 2009-10-24  Anton Muhin  <antonm@chromium.org>
4176
4177         Reviewed by Adam Barth.
4178
4179         Implements ReturnsNew hint for V8 bindings generation code.
4180         https://bugs.webkit.org/show_bug.cgi?id=30745
4181
4182         * bindings/scripts/CodeGeneratorV8.pm:
4183         * bindings/v8/V8DOMWrapper.h:
4184         (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
4185
4186 2009-10-24  Dan Bernstein  <mitz@apple.com>
4187
4188         Reviewed by Sam Weinig.
4189
4190         Missing images at 350.org due to wrong URLs
4191         https://bugs.webkit.org/show_bug.cgi?id=30748
4192
4193         Test: fast/dom/HTMLImageElement/parse-src.html
4194
4195         * dom/Element.cpp:
4196         (WebCore::Element::getURLAttribute): Pass the attribute value through deprecateParseURL().
4197         This matches what the Objective-C bindings do, as well as what HTMLImageLoader::sourceURI()
4198         and SVGImageLoader::sourceURI() do.
4199
4200 2009-10-24  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
4201
4202         Unreviewed.
4203
4204         [Qt] Build fix for QtWebKit after r50013.
4205
4206         * WebCore.pro:
4207
4208 2009-10-24  Dimitri Glazkov  <dglazkov@chromium.org>
4209
4210         Unreviewed, build fix.
4211
4212         [V8] Fix up to accommodate for HTMLAllCollection changes in
4213         http://trac.webkit.org/changeset/49998.
4214
4215         * WebCore.gypi:
4216         * bindings/scripts/CodeGeneratorV8.pm:
4217         * bindings/v8/custom/V8CustomBinding.h:
4218         * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
4219
4220 2009-10-23  Dan Bernstein  <mitz@apple.com>
4221
4222         Reviewed by Alexey Proskuryakov.
4223
4224         <rdar://problem/7294131> Assertion failure in AuthenticationMac at
4225         mac(const Credential&) after authenticating to MobileMe Gallery movie
4226
4227         * platform/network/Credential.cpp:
4228         (WebCore::Credential::Credential): Initialize m_persistence.
4229         (WebCore::Credential::isEmpty): Made this method const.
4230         * platform/network/Credential.h:
4231         * platform/network/mac/AuthenticationMac.mm:
4232         (WebCore::mac): Return nil if the Credential is empty.
4233
4234 2009-10-23  Brian Weinstein  <bweinstein@apple.com>
4235
4236         Reviewed by Timothy Hatcher.
4237
4238         Fixes <https://bugs.webkit.org/show_bug.cgi?id=30617>.
4239         Web Inspector: Resources Scope Bar Should Allow Combinations.
4240         
4241         Refactor the filtering in ResourcePanel to make it match ConsoleView,
4242         and add a divider between All, and the other choices of Resource types.
4243
4244         * inspector/front-end/ResourcesPanel.js:
4245         (WebInspector.ResourcesPanel):
4246         (WebInspector.ResourcesPanel.prototype.filter):
4247         (WebInspector.ResourcesPanel.prototype._updateFilter):
4248         * inspector/front-end/inspector.css:
4249
4250 2009-10-23  Chris Evans  <cevans@chromium.org>
4251
4252         Reviewed by Adam Barth.
4253
4254         Ignore the Refresh header if we're in view source mode.
4255
4256         https://bugs.webkit.org/show_bug.cgi?id=27239
4257
4258         Test: http/tests/security/view-source-no-refresh.html
4259
4260         * loader/FrameLoader.cpp: ignore Refresh in view-source mode.
4261
4262 2009-10-23  Alexey Proskuryakov  <ap@apple.com>
4263
4264         Reviewed by Sam Weinig.
4265
4266         https://bugs.webkit.org/show_bug.cgi?id=30734
4267         Remove XMLTokenizer::m_currentNodeIsReferenced
4268
4269         No change in behavior, no tests.
4270
4271         * dom/XMLTokenizer.cpp:
4272         (WebCore::XMLTokenizer::setCurrentNode):
4273         * dom/XMLTokenizer.h:
4274         Don't store a boolean for the current node being the document - we can always check for that.
4275
4276         * dom/XMLTokenizerLibxml2.cpp: