e1736fcad025a3c179e987785681d08af9958057
[WebKit-https.git] / WebCore / ChangeLog
1 2006-10-17  Geoffrey Garen  <ggaren@apple.com>
2
3         Reviewed by Anders.
4         
5         Renamed WindowArgs to WindowFeatures, and moved it into its own header.
6         ("Features" is the term of art in IE documentation. "Args" is pirate
7         talk.)
8
9         * WebCore.xcodeproj/project.pbxproj:
10         * bindings/js/kjs_window.cpp:
11         (KJS::createNewWindow):
12         (KJS::showModalDialog):
13         (KJS::setWindowFeature):
14         (KJS::parseWindowFeatures):
15         (KJS::constrainToVisible):
16         (KJS::WindowFunc::callAsFunction):
17         * bridge/BrowserExtension.h:
18         * bridge/WindowFeatures.h: Added.
19         * bridge/mac/BrowserExtensionMac.h:
20         * bridge/mac/BrowserExtensionMac.mm:
21         (WebCore::BrowserExtensionMac::createNewWindow):
22
23 2006-10-17  Sam Weinig  <sam.weinig@gmail.com>
24
25         Reviewed by Tim H.
26
27         Patch for http://bugs.webkit.org/show_bug.cgi?id=11268
28         Implement the Objective-C DOM bindings for SVGNumber, SVGRect, and SVGPoint
29
30         - Adds implementation for DOMSVGNumber, DOMSVGRect, and DOMSVGPoint.
31
32         - Moves the contents of ksvg/bindings/js/ to bindings/js/.
33
34         - Moves SVGZoomEvent.idl from ksvg/svg/ to ksvg/events/.
35
36         - Adds isSVGColor() and isSVGPaint() methods to StyleBase, matching 
37           the other CSSValue classing, and allowing the bindings to allocate
38           appropriately.
39
40         - Removes #ifdefs around the getBBox() method in SVGLocatable.idl allowing
41           generation for Objective-C.
42
43         - Assorted style cleanups.
44
45         * DerivedSources.make:
46         * WebCore.xcodeproj/project.pbxproj:
47         * bindings/objc/DOMCSS.mm:
48         (+[DOMCSSValue _CSSValueWith:WebCore::]):
49         * bindings/objc/DOMEvents.mm:
50         (+[DOMEvent _eventWith:WebCore::]):
51         * bindings/objc/DOMSVG.h:
52         * bindings/objc/DOMSVGNumber.mm:
53         (-[DOMSVGNumber dealloc]):
54         (-[DOMSVGNumber finalize]):
55         (-[DOMSVGNumber value]):
56         (-[DOMSVGNumber setValue:]):
57         (-[DOMSVGNumber _SVGNumber]):
58         (-[DOMSVGNumber _initWithFloat:]):
59         (+[DOMSVGNumber _SVGNumberWith:]):
60         * bindings/objc/DOMSVGPoint.mm:
61         (-[DOMSVGPoint dealloc]):
62         (-[DOMSVGPoint finalize]):
63         (-[DOMSVGPoint x]):
64         (-[DOMSVGPoint setX:]):
65         (-[DOMSVGPoint y]):
66         (-[DOMSVGPoint setY:]):
67         (-[DOMSVGPoint WebCore::]):
68         (-[DOMSVGPoint _initWithFloatPoint:WebCore::]):
69         (+[DOMSVGPoint _SVGPointWith:WebCore::]):
70         * bindings/objc/DOMSVGRect.mm:
71         (-[DOMSVGRect dealloc]):
72         (-[DOMSVGRect finalize]):
73         (-[DOMSVGRect x]):
74         (-[DOMSVGRect setX:]):
75         (-[DOMSVGRect y]):
76         (-[DOMSVGRect setY:]):
77         (-[DOMSVGRect width]):
78         (-[DOMSVGRect setWidth:]):
79         (-[DOMSVGRect height]):
80         (-[DOMSVGRect setHeight:]):
81         (-[DOMSVGRect WebCore::]):
82         (-[DOMSVGRect _initWithFloatRect:WebCore::]):
83         (+[DOMSVGRect _SVGRectWith:WebCore::]):
84         * bindings/scripts/CodeGeneratorObjC.pm:
85         * css/StyleBase.h:
86         (WebCore::StyleBase::isSVGColor):
87         (WebCore::StyleBase::isSVGPaint):
88         * ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp: Removed.
89         * ksvg2/bindings/js/JSSVGElementWrapperFactory.h: Removed.
90         * ksvg2/bindings/js/JSSVGNumber.cpp: Removed.
91         * ksvg2/bindings/js/JSSVGNumber.h: Removed.
92         * ksvg2/bindings/js/JSSVGPoint.cpp: Removed.
93         * ksvg2/bindings/js/JSSVGPoint.h: Removed.
94         * ksvg2/bindings/js/JSSVGRect.cpp: Removed.
95         * ksvg2/bindings/js/JSSVGRect.h: Removed.
96         * ksvg2/svg/SVGColor.h:
97         (WebCore::SVGColor::isSVGColor):
98         * ksvg2/svg/SVGFECompositeElement.idl:
99         * ksvg2/svg/SVGFEFloodElement.idl:
100         * ksvg2/svg/SVGLocatable.idl:
101         * ksvg2/svg/SVGMarkerElement.idl:
102         * ksvg2/svg/SVGPaint.h:
103         (WebCore::SVGPaint::isSVGPaint):
104         * ksvg2/svg/SVGRectElement.idl:
105         * ksvg2/svg/SVGZoomEvent.idl: Removed.
106
107 2006-10-17  David Hyatt  <hyatt@apple.com>
108
109         Prepare for the elimination of the RenderLayer for <html> elements.  The layer is still present,
110         but this patch makes everything work without a root layer being around.
111
112         Reviewed by beth
113
114         * rendering/RenderBlock.cpp:
115         (WebCore::RenderBlock::paint):
116         (WebCore::RenderBlock::paintChildren):
117         (WebCore::RenderBlock::nodeAtPoint):
118         * rendering/RenderLayer.cpp:
119         (WebCore::frameVisibleRect):
120         (WebCore::RenderLayer::hitTest):
121         (WebCore::RenderLayer::hitTestLayer):
122         (WebCore::RenderLayer::intersectsDamageRect):
123         * rendering/RenderObject.cpp:
124         (WebCore::RenderObject::setInnerNode):
125         * rendering/RenderView.cpp:
126         (WebCore::RenderView::paint):
127
128 2006-10-17  David Hyatt  <hyatt@apple.com>
129
130         Back out my previous patch to the WebCore memory cache.
131
132         * loader/Cache.cpp:
133         (WebCore::Cache::flush):
134         (WebCore::Cache::setSize):
135         (WebCore::Cache::getLRUListFor):
136         (WebCore::Cache::removeFromLRUList):
137         (WebCore::Cache::insertInLRUList):
138         * loader/Cache.h:
139         * loader/CachedCSSStyleSheet.cpp:
140         (WebCore::CachedCSSStyleSheet::deref):
141         * loader/CachedCSSStyleSheet.h:
142         * loader/CachedImage.cpp:
143         (WebCore::CachedImage::deref):
144         * loader/CachedImage.h:
145         * loader/CachedResource.cpp:
146         (WebCore::CachedResource::setRequest):
147         (WebCore::CachedResource::deref):
148         * loader/CachedResource.h:
149         (WebCore::CachedResource::allowInLRUList):
150         * loader/CachedScript.cpp:
151         (WebCore::CachedScript::deref):
152         * loader/CachedScript.h:
153         * loader/CachedXBLDocument.cpp:
154         (WebCore::CachedXBLDocument::deref):
155         * loader/CachedXBLDocument.h:
156         * loader/CachedXSLStyleSheet.cpp:
157         (WebCore::CachedXSLStyleSheet::deref):
158         * loader/CachedXSLStyleSheet.h:
159
160 2006-10-17  Oliver Hunt  <oliver@apple.com>
161
162         Reviewed by Anders.
163
164         Make north and east resize cursors use correct image
165
166         * platform/win/CursorWin.cpp:
167         (WebCore::eastResizeCursor):
168         (WebCore::northResizeCursor):
169
170 2006-10-17  Oliver Hunt  <oliver@apple.com>
171
172         Reviewed by Brady
173
174         Various cursor fixes
175
176         * page/FrameView.cpp:
177         (WebCore::FrameView::handleMouseMoveEvent):
178         * platform/Cursor.h:
179         * platform/mac/CursorMac.mm:
180         (WebCore::pointerCursor):
181         * platform/win/CursorWin.cpp:
182         (WebCore::supportsAlphaCursors):
183         (WebCore::Cursor::Cursor):
184         (WebCore::Cursor::~Cursor):
185         (WebCore::pointerCursor):
186
187 2006-10-17  Justin Garcia  <justin.garcia@apple.com>
188
189         Reviewed by harrison
190         
191         <rdar://problem/4776665>
192         REGRESSION: In Mail, caret is visible when the message body isn't focused
193
194         * page/Frame.cpp:
195         (WebCore::Frame::paintCaret): If a caret blink timer is ever on in error
196         (like when the frame that contains the caret isn't focused) then we don't 
197         want to paint the caret.  We should eventually move to using a single bool
198         for caret painting.
199
200 2006-10-17  Justin Garcia  <justin.garcia@apple.com>
201
202         Reviewed by harrison
203         
204         <rdar://problem/4774354>
205         REGRESSION: In Gmail, caret reappears when dragging a selection over some text in the message body
206
207         Functions call recomputCaretRect to see if the caret rect has changed, 
208         and, if it has, they invalidate (repaint) it.  recomputeCaretRect was 
209         returning false if the caret turned into a range selection or was blown 
210         away.
211
212         * editing/SelectionController.cpp:
213         (WebCore::SelectionController::recomputeCaretRect): Don't early return if
214         !isCaret().  Obtain the FrameView* using the m_frame pointer, because m_sel 
215         may now be null.
216
217 2006-10-17  Geoffrey Garen  <ggaren@apple.com>
218
219         Reviewed by Brady.
220
221         BrowserExtension cleanup.
222         
223         - Removed unnecessary #include of BrowserExtension in Frame.h, added
224         #includes to compensate in other files.
225         
226         - Removed unused versions of createNewWindow.
227         
228         * bindings/js/kjs_window.cpp:
229         * bridge/BrowserExtension.h:
230         * bridge/mac/BrowserExtensionMac.h:
231         * bridge/mac/BrowserExtensionMac.mm:
232         (WebCore::BrowserExtensionMac::createNewWindow):
233         * bridge/mac/WebCoreFrameBridge.mm:
234         * html/HTMLFormElement.cpp:
235         * loader/mac/LoaderFunctionsMac.mm:
236         * page/Frame.h:
237         * page/FramePrivate.h:
238
239 2006-10-15  Geoffrey Garen  <ggaren@apple.com>
240
241         Reviewed by Adam.
242         
243         - Fixed "FIXME: Violates Liskov Substitution principle."
244         
245         IFRAME was never a true subclass of FRAME, since they disagreed on a
246         number of behaviors, which, confusingly, IFRAME just overrode and contradicted. 
247
248         The fix here is to factor out things common to IFRAME and FRAME into a
249         common base class, HTMLFrameElementBase.
250         
251         I also changed some " *" to "* " and added #includes in files that implicitly
252         assumed that HTMLIFrameElement.h #included HTMLFrameElement.h.
253
254 2006-10-16  Justin Garcia  <justin.garcia@apple.com>
255
256         Reviewed by sullivan
257         
258         <rdar://problem/4776765>
259         REGRESSION: Caret's ghost left behind after inserting a paragraph separator (11237)
260
261         We set m_needsLayout to false and call caretRect() in the hopes that it will give us 
262         the old caret rect.  It in fact corrects the caret rect for an offset that it 
263         believes is due to scrolling but which is actually due to a change in selection
264         without an accompanying layout.  So it returns the new caret rect regardless of
265         what m_needsLayout is set to.
266         
267         * editing/SelectionController.cpp:
268         (WebCore::repaintRectForCaret): Moved the code from caretRepaintRect that
269         adds a one pixel slop to this new function.
270         (WebCore::SelectionController::caretRepaintRect): Moved this code to
271         repaintRectForCaret.
272         (WebCore::SelectionController::recomputeCaretRect): Compare the old
273         caret rect to the new one that's computed with a fresh layout.  If
274         they are different, invalidate both repaint rects.
275
276 2006-10-17  David Harrison  <harrison@apple.com>
277
278         Reviewed by Adele.
279
280         <rdar://problem/4770453> VO not honoring secure edit fields in web pages
281
282         * bridge/mac/WebCoreAXObject.mm:
283         (-[WebCoreAXObject isPasswordField]):
284         New. Checks for input with inputType() of PASSWORD.
285         
286         (-[WebCoreAXObject subrole]):
287         Returns NSAccessibilitySecureTextFieldSubrole if [self isPasswordField].
288         
289         (-[WebCoreAXObject roleDescription]):
290         Pass [self subrole] instead of nil when calling NSAccessibilityRoleDescription.
291         
292         (-[WebCoreAXObject value]):
293         Return nil if [self isPasswordField].
294         
295         (-[WebCoreAXObject accessibilityAttributeNames]):
296         Return generic attributes if [self isPasswordField].
297
298         (-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
299         Return empty array if [self isPasswordField].
300
301 2006-10-17  David Hyatt  <hyatt@apple.com>
302
303         Fix "flash to white' problem on yahoo.com as it finishes loading.  Refine the FOUC suppression
304         code so that it will only run if the body still has no renderer.
305
306         * dom/Document.cpp:
307         (WebCore::Document::updateLayoutIgnorePendingStylesheets):
308
309 2006-10-17  David Hyatt  <hyatt@apple.com>
310
311         Fix a bug where the WebCore memory cache could grow without bound during extended browsing
312         sessions.
313
314         Reviewed by mjs
315
316         * loader/Cache.cpp:
317         (WebCore::Cache::flush):
318         (WebCore::Cache::setSize):
319         (WebCore::Cache::getLRUListFor):
320         (WebCore::Cache::removeFromLRUList):
321         (WebCore::Cache::insertInLRUList):
322         * loader/Cache.h:
323         * loader/CachedCSSStyleSheet.cpp:
324         * loader/CachedCSSStyleSheet.h:
325         * loader/CachedImage.cpp:
326         * loader/CachedImage.h:
327         * loader/CachedResource.cpp:
328         (WebCore::CachedResource::setRequest):
329         (WebCore::CachedResource::deref):
330         * loader/CachedResource.h:
331         (WebCore::CachedResource::allowInLRUList):
332         * loader/CachedScript.cpp:
333         * loader/CachedScript.h:
334         * loader/CachedXBLDocument.cpp:
335         * loader/CachedXBLDocument.h:
336         * loader/CachedXSLStyleSheet.cpp:
337         * loader/CachedXSLStyleSheet.h:
338
339 2006-10-13  Justin Garcia  <justin.garcia@apple.com>
340
341         Reviewed by harrison
342         
343         <rdar://problem/3655385>
344         Editing: -indent: method unimplemented
345
346         Added Frame and bridge methods.
347
348         * bridge/mac/WebCoreFrameBridge.h:
349         * bridge/mac/WebCoreFrameBridge.mm:
350         (-[WebCoreFrameBridge indent]):
351         (-[WebCoreFrameBridge outdent]):
352         * page/Frame.cpp:
353         (WebCore::Frame::indent): 
354         (WebCore::Frame::outdent):
355         * page/Frame.h:
356
357 2006-10-16  Adam Roben  <aroben@apple.com>
358
359         Reviewed by John.
360
361         More menulist cleanup/tweaking.
362
363         * html/HTMLSelectElement.cpp:
364         (WebCore::HTMLSelectElement::setSelectedIndex): Renamed 'index'
365         parameter to 'optionIndex' for clarity.
366         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Skip over
367         items that are not enabled <option> elements when using arrow keys, and
368         make sure we pass an option index to setSelectedIndex.
369         * platform/PopupMenu.h:
370         (WebCore::PopupMenu::setWasClicked): Specify default argument.
371         * rendering/RenderMenuList.cpp:
372         (WebCore::RenderMenuList::setTextFromOption): Strip whitespace from
373         option text before setting the control text so that options within
374         <optgroup>s don't appear indented in the actual control.
375
376 2006-10-16  Sam Weinig  <sam.weinig@gmail.com>
377
378         Reviewed by Adam.
379
380         Win32 build fix.
381
382         * WebCore.vcproj/WebCore/WebCore.vcproj:
383         * bridge/win/BrowserExtensionWin.cpp:
384         (WebCore::BrowserExtensionWin::createNewWindow):
385         * bridge/win/FrameWin.cpp:
386         (WebCore::FrameWin::urlSelected):
387         (WebCore::FrameWin::submitForm):
388         (WebCore::FrameWin::createNewWindow):
389         * bridge/win/FrameWin.h:
390         * loader/loader.cpp:
391         (WebCore::Loader::receivedResponse):
392         * platform/win/GraphicsContextWin.cpp:
393         (WebCore::GraphicsContext::getWindowsContext):
394         (WebCore::GraphicsContext::releaseWindowsContext):
395         * platform/win/TemporaryLinkStubs.cpp:
396         (FrameWin::openURLRequest):
397         (WebCore::ServeSynchronousRequest):
398         (WebCore::CheckIfReloading):
399         (WebCore::IsResponseURLEqualToURL):
400         (WebCore::ResponseMIMEType):
401         (WebCore::ResponseIsMultipart):
402         (WebCore::CacheObjectExpiresTime):
403         (CachedResource::setResponse):
404         (CachedResource::setAllData):
405         * rendering/RenderThemeWin.cpp:
406         (WebCore::doneDrawing):
407         (WebCore::RenderThemeWin::paintButton):
408         (WebCore::RenderThemeWin::paintTextField):
409
410 2006-10-16  David Hyatt  <hyatt@apple.com>
411
412         Fix for bug 9347, positioned elements have the wrong containing block.  This is a change from CSS2 to
413         CSS2.1.  In the absence of any other enclosing positioned elements, the containing block for a positioned
414         element is the initial containing block (our RenderView).
415
416         Reviewed by mjs
417
418         Test cases added to fast/block/positioning for quirks and strict modes.
419
420         * rendering/RenderBlock.cpp:
421         (WebCore::RenderBlock::lowestPosition):
422         (WebCore::RenderBlock::rightmostPosition):
423         (WebCore::RenderBlock::leftmostPosition):
424         * rendering/RenderBox.cpp:
425         (WebCore::RenderBox::containingBlockHeightForPositioned):
426         (WebCore::RenderBox::calcAbsoluteVertical):
427         * rendering/RenderObject.cpp:
428         (WebCore::RenderObject::containingBlock):
429         (WebCore::RenderObject::container):
430
431 2006-10-15  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
432
433         Reviewed by Anders.
434
435         Misc Gdk/Linux build fixes.
436
437         * platform/gdk/BrowserExtensionGdk.h:
438         * platform/gdk/FrameGdk.cpp:
439         (WebCore::FrameGdk::submitForm):
440         (WebCore::FrameGdk::urlSelected):
441         * platform/gdk/FrameGdk.h:
442         * platform/gdk/RenderPopupMenuGdk.cpp:
443         (WebCore::PopupMenu::PopupMenu):
444         (WebCore::PopupMenu::~PopupMenu):
445         (WebCore::PopupMenu::clear):
446         (WebCore::PopupMenu::populate):
447         (WebCore::PopupMenu::show):
448         (WebCore::PopupMenu::hide):
449         (WebCore::PopupMenu::addSeparator):
450         (WebCore::PopupMenu::addGroupLabel):
451         (WebCore::PopupMenu::addOption):
452         * platform/gdk/RenderPopupMenuGdk.h:
453         * platform/gdk/RenderThemeGdk.cpp:
454         * platform/gdk/RenderThemeGdk.h:
455         (WebCore::RenderThemeGdk::RenderThemeGdk):
456         * platform/gdk/TemporaryLinkStubs.cpp:
457         (BrowserExtensionGdk::createNewWindow):
458         (BrowserExtensionGdk::BrowserExtensionGdk):
459         (BrowserExtensionGdk::setTypedIconURL):
460         (BrowserExtensionGdk::setIconURL):
461         (BrowserExtensionGdk::getHistoryLength):
462         (WebCore::CheckIfReloading):
463         (WebCore::CacheObjectExpiresTime):
464         (WebCore::ResponseURL):
465         (WebCore::IsResponseURLEqualToURL):
466         (WebCore::ResponseIsMultipart):
467         (WebCore::ResponseMIMEType):
468         (WebCore::CachedResource::setResponse):
469         (WebCore::CachedResource::setAllData):
470         (FileChooser::disconnectUploadControl):
471         * rendering/RenderTheme.h:
472         * rendering/RenderThemeMac.h:
473
474 2006-10-15  Sam Weinig  <sam.weinig@gmail.com>
475
476         Reviewed by Mitz.
477
478         Fix for http://bugs.webkit.org/show_bug.cgi?id=11294
479         Add getModifierState method to KeyboardEvent
480
481         * bindings/objc/DOMEvents.h:
482         * bindings/objc/DOMEvents.mm:
483         * bindings/objc/PublicDOMInterfaces.h:
484         * dom/KeyboardEvent.cpp:
485         (WebCore::KeyboardEvent::getModifierState):
486         * dom/KeyboardEvent.h:
487         * dom/KeyboardEvent.idl:
488
489 2006-10-15  Nikolas Zimmermann  <zimmermann@kde.org>
490
491         Reviewed and landed by ap.
492
493         Changed PlatformResponse handling for Qt. Don't just store
494         a QString object containing the data but a new PlatformResponseQt struct
495         containing data and url, and store it as pointer. This is compatible
496         to the OS X handling and removes the Qt plaform specific hacks from
497         CachedCSSStyleSheet, CachedResource & loader.
498
499         Add new file LoaderFunctionsQt, similar to LoaderFunctionsMac, and move
500         all methods from TemporaryLinkStubs related to loading in there, and implement
501         some like ServeSynchronousRequest (yay for xslt handling!).
502
503         * CMakeLists.txt:
504         * loader/CachedCSSStyleSheet.cpp:
505         (WebCore::CachedCSSStyleSheet::checkNotify):
506         * loader/CachedResource.h:
507         (WebCore::CachedResource::CachedResource):
508         * loader/loader.cpp:
509         (WebCore::Loader::receivedResponse):
510         * platform/ResourceLoaderClient.h:
511         * platform/ResourceLoaderInternal.h:
512         * platform/qt/FrameQt.cpp:
513         (WebCore::FrameQt::~FrameQt):
514         (WebCore::FrameQt::createEmptyDocument):
515         * platform/qt/FrameQt.h:
516         (WebCore::QtFrame):
517         * platform/qt/FrameQtClient.cpp:
518         (WebCore::FrameQtClientDefault::setFrame):
519         (WebCore::FrameQtClientDefault::openURL):
520         (WebCore::FrameQtClientDefault::loadFinished):
521         (WebCore::FrameQtClientDefault::receivedAllData):
522         * platform/qt/FrameQtClient.h:
523         * platform/qt/LoaderFunctionsQt.cpp: Added.
524         (WebCore::ServeSynchronousRequest):
525         (WebCore::NumberOfPendingOrLoadingRequests):
526         (WebCore::CheckIfReloading):
527         (WebCore::CheckCacheObjectStatus):
528         (WebCore::IsResponseURLEqualToURL):
529         (WebCore::ResponseURL):
530         (WebCore::ResponseMIMEType):
531         (WebCore::ResponseIsMultipart):
532         (WebCore::CacheObjectExpiresTime):
533         (WebCore::CachedResource::setResponse):
534         (WebCore::CachedResource::setAllData):
535         * platform/qt/ResourceLoaderManager.cpp:
536         (WebCore::ResourceLoaderManager::remove):
537         * platform/qt/ResourceLoaderQt.cpp:
538         (WebCore::ResourceLoader::~ResourceLoader):
539         (WebCore::ResourceLoader::start):
540         (WebCore::ResourceLoader::assembleResponseHeaders):
541         (WebCore::ResourceLoader::receivedResponse):
542         * platform/qt/TemporaryLinkStubs.cpp:
543
544 2006-10-14  Rob Buis  <buis@kde.org>
545
546         Reviewed by Mitz.
547
548         http://bugs.webkit.org/show_bug.cgi?id=11217
549         Cleanup svg coding style
550
551         Cleanup coding style in svg basic datastructure classes.
552
553         * ksvg2/svg/SVGAngle.cpp:
554         (WebCore::SVGAngle::valueAsString):
555         (WebCore::SVGAngle::context):
556         (WebCore::SVGAngle::setContext):
557         * ksvg2/svg/SVGAngle.h:
558         * ksvg2/svg/SVGColor.cpp:
559         * ksvg2/svg/SVGColor.h:
560         * ksvg2/svg/SVGElement.cpp:
561         (WebCore::SVGElement::ownerSVGElement):
562         (WebCore::SVGElement::viewportElement):
563         (WebCore::SVGElement::parseMappedAttribute):
564         (WebCore::SVGElement::childShouldCreateRenderer):
565         * ksvg2/svg/SVGElement.h:
566         (WebCore::svg_dynamic_cast):
567         * ksvg2/svg/SVGFitToViewBox.cpp:
568         (WebCore::SVGFitToViewBox::parseViewBox):
569         * ksvg2/svg/SVGFitToViewBox.h:
570         * ksvg2/svg/SVGLangSpace.cpp:
571         (WebCore::SVGLangSpace::parseMappedAttribute):
572         * ksvg2/svg/SVGLangSpace.h:
573         * ksvg2/svg/SVGLength.cpp:
574         (WebCore::SVGLength::SVGLength):
575         (WebCore::SVGLength::setValueAsString):
576         (WebCore::SVGLength::dpi):
577         (WebCore::SVGLength::updateValue):
578         (WebCore::SVGLength::updateValueInSpecifiedUnits):
579         (WebCore::SVGLength::context):
580         (WebCore::SVGLength::setContext):
581         * ksvg2/svg/SVGLength.h:
582         * ksvg2/svg/SVGLengthList.cpp:
583         * ksvg2/svg/SVGLengthList.h:
584         * ksvg2/svg/SVGLocatable.cpp:
585         (WebCore::SVGLocatable::nearestViewportElement):
586         (WebCore::SVGLocatable::farthestViewportElement):
587         (WebCore::SVGLocatable::getBBox):
588         (WebCore::SVGLocatable::getCTM):
589         (WebCore::SVGLocatable::getScreenCTM):
590         * ksvg2/svg/SVGNumberList.cpp:
591         * ksvg2/svg/SVGNumberList.h:
592         * ksvg2/svg/SVGPreserveAspectRatio.cpp:
593         (WebCore::SVGPreserveAspectRatio::SVGPreserveAspectRatio):
594         (WebCore::SVGPreserveAspectRatio::getCTM):
595         * ksvg2/svg/SVGPreserveAspectRatio.h:
596         * ksvg2/svg/SVGStringList.cpp:
597         (WebCore::SVGStringList::reset):
598         * ksvg2/svg/SVGStringList.h:
599         * ksvg2/svg/SVGStylable.cpp:
600         * ksvg2/svg/SVGStylable.h:
601         * ksvg2/svg/SVGTests.cpp:
602         (WebCore::SVGTests::requiredFeatures):
603         (WebCore::SVGTests::requiredExtensions):
604         (WebCore::SVGTests::systemLanguage):
605         (WebCore::SVGTests::isValid):
606         (WebCore::SVGTests::parseMappedAttribute):
607         * ksvg2/svg/SVGTests.h:
608         * ksvg2/svg/SVGTransformable.cpp:
609         (WebCore::SVGTransformable::parseTransformAttribute):
610         * ksvg2/svg/SVGTransformable.h:
611         * ksvg2/svg/SVGURIReference.cpp:
612         (WebCore::SVGURIReference::parseMappedAttribute):
613         * ksvg2/svg/SVGZoomAndPan.cpp:
614         (WebCore::SVGZoomAndPan::parseMappedAttribute):
615         * ksvg2/svg/SVGZoomAndPan.h:
616
617 2006-10-15  Nikolas Zimmermann  <zimmermann@kde.org>
618
619         Reviewed by Oliver.
620
621         Implement some functions in FrameQt / ScrollViewQt.
622
623         Added comments what needs to be done in quite some places,
624         marked some functions as no-ops.
625
626         * CMakeLists.txt:
627         * platform/qt/FrameQt.cpp:
628         (WebCore::FrameQt::FrameQt):
629         (WebCore::FrameQt::runJavaScriptConfirm):
630         (WebCore::FrameQt::locationbarVisible):
631         (WebCore::FrameQt::createFrame):
632         (WebCore::FrameQt::passSubframeEventToSubframe):
633         (WebCore::FrameQt::menubarVisible):
634         (WebCore::FrameQt::personalbarVisible):
635         (WebCore::FrameQt::statusbarVisible):
636         (WebCore::FrameQt::toolbarVisible):
637         (WebCore::FrameQt::markedTextRange):
638         (WebCore::FrameQt::lastEventIsMouseUp):
639         (WebCore::FrameQt::openURLRequest):
640         (WebCore::FrameQt::scheduleClose):
641         (WebCore::FrameQt::unfocusWindow):
642         (WebCore::FrameQt::focusWindow):
643         (WebCore::FrameQt::overrideMediaType):
644         (WebCore::FrameQt::runJavaScriptPrompt):
645         (WebCore::FrameQt::bindingRootObject):
646         (WebCore::FrameQt::addPluginRootObject):
647         (WebCore::FrameQt::registerCommandForUndo):
648         (WebCore::FrameQt::registerCommandForRedo):
649         (WebCore::FrameQt::clearUndoRedoOperations):
650         (WebCore::FrameQt::respondToChangedSelection):
651         (WebCore::FrameQt::respondToChangedContents):
652         (WebCore::FrameQt::shouldChangeSelection):
653         (WebCore::FrameQt::canGoBackOrForward):
654         (WebCore::FrameQt::canPaste):
655         (WebCore::FrameQt::canRedo):
656         (WebCore::FrameQt::canUndo):
657         * platform/qt/FrameQt.h:
658         * platform/qt/FrameQtClient.cpp:
659         (WebCore::FrameQtClientDefault::runJavaScriptAlert):
660         (WebCore::FrameQtClientDefault::runJavaScriptConfirm):
661         (WebCore::FrameQtClientDefault::runJavaScriptPrompt):
662         (WebCore::FrameQtClientDefault::menubarVisible):
663         (WebCore::FrameQtClientDefault::toolbarVisible):
664         (WebCore::FrameQtClientDefault::statusbarVisible):
665         (WebCore::FrameQtClientDefault::personalbarVisible):
666         (WebCore::FrameQtClientDefault::locationbarVisible):
667         * platform/qt/FrameQtClient.h:
668         * platform/qt/ImageSourceQt.cpp:
669         * platform/qt/RenderThemeQt.cpp:
670         * platform/qt/ScrollViewQt.cpp:
671         (WebCore::ScrollView::scrollPointRecursively):
672         * platform/qt/TemporaryLinkStubs.cpp:
673         (WebCore::CachedResource::setResponse):
674         (WebCore::CachedResource::setAllData):
675
676 2006-10-14  David Harrison  <harrison@apple.com>
677
678         Reviewed by Geoff.
679
680         <rdar://problem/4775213> REGRESSION: Can't from tab from last link on the page to URL address field
681         <rdar://problem/4783926> REGRESSION: Typing tab key enters no text
682
683         The problem is that EventTargetNode::defaultEventHandler() calls event->setDefaultHandled() regardless
684         of whether frame->view()->advanceFocus() actually changed the focus.
685
686         Trivial fix is to preventDefault() only if advanceFocus() returns true.
687
688         * No test is possible because DumpRenderTree sets the WebView preference to
689         tab to links, and that preference cannot be changed dynamically after
690         the webview is initialized. Also, the "tab from last link" is not testable
691         because DumpRenderTree uses the WebView for the whole window, so tabs can't
692         shift focus out of the WebView regardless.
693
694         * dom/EventTargetNode.cpp:
695         (WebCore::EventTargetNode::defaultEventHandler):
696
697 2006-10-14  Nikolas Zimmermann  <zimmermann@kde.org>
698
699         Reviewed by Mitz.
700
701         Fix Qt/Linux build & some little fixes:
702
703         - Adapt to Maciej's FrameLoadRequest changes.
704         - Fix response handling - don't try to compare with '0' - for us it's a non-ptr QString object.
705         - Actually call setAllData from loader/loader.cpp (David Carson forgot that in his last commit)
706         - Fix CacheObjectExpiresTime/ResponseIsMultipart signature.
707
708         * loader/CachedCSSStyleSheet.cpp:
709         (WebCore::CachedCSSStyleSheet::checkNotify):
710         * loader/CachedResource.h:
711         (WebCore::CachedResource::CachedResource):
712         * loader/loader.cpp:
713         (WebCore::Loader::receivedAllData):
714         (WebCore::Loader::receivedResponse):
715         * platform/qt/BrowserExtensionQt.cpp:
716         (WebCore::BrowserExtensionQt::createNewWindow):
717         * platform/qt/BrowserExtensionQt.h:
718         * platform/qt/FrameQt.cpp:
719         (WebCore::FrameQt::submitForm):
720         (WebCore::FrameQt::urlSelected):
721         (WebCore::FrameQt::openURLRequest):
722         * platform/qt/FrameQt.h:
723         * platform/qt/GraphicsContextQt.cpp:
724         (WebCore::GraphicsContext::setURLForRect):
725         * platform/qt/TemporaryLinkStubs.cpp:
726         (WebCore::CacheObjectExpiresTime):
727         (WebCore::ResponseIsMultipart):
728         (WebCore::CachedResource::setResponse):
729         (WebCore::CachedResource::setAllData):
730
731 2006-10-14  David Carson  <dacarson@gmail.com>
732
733         Reviewed by Maciej.
734
735         Fix: http://bugs.webkit.org/show_bug.cgi?id=11257
736         Removed Mac platform dependance, changed WebCore functions to
737         use PlatformResponse/PlatformData rather than NSURLResponse/
738         NSData. 
739
740         * loader/CachedCSSStyleSheet.cpp:
741         (WebCore::CachedCSSStyleSheet::checkNotify):
742         * loader/CachedImage.cpp:
743         (WebCore::CachedImage::createImage):
744         * loader/CachedResource.cpp:
745         (WebCore::CachedResource::~CachedResource):
746         * loader/CachedResource.h:
747         (WebCore::CachedResource::CachedResource):
748         (WebCore::CachedResource::response):
749         (WebCore::CachedResource::allData):
750         * loader/LoaderFunctions.h:
751         * loader/loader.cpp:
752         (WebCore::Loader::receivedResponse):
753         * loader/mac/LoaderFunctionsMac.mm:
754         (WebCore::ResponseMIMEType):
755         (WebCore::ResponseIsMultipart):
756         (WebCore::CacheObjectExpiresTime):
757         (WebCore::CachedResource::setResponse):
758         (WebCore::CachedResource::setAllData):
759         * platform/qt/TemporaryLinkStubs.cpp:
760         (WebCore::CacheObjectExpiresTime):
761         (WebCore::ResponseIsMultipart):
762         (WebCore::ResponseMIMEType):
763         (WebCore::CachedResource::setResponse):
764         (WebCore::CachedResource::setAllData):
765         * platform/win/TemporaryLinkStubs.cpp:
766         (WebCore::CacheObjectExpiresTime):
767         (WebCore::ResponseIsMultipart):
768         (WebCore::ResponseMIMEType):
769         (WebCore::CachedResource::setResponse):
770         (WebCore::CachedResource::setAllData):
771
772 2006-10-14  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
773
774         Reviewed by Maciej.
775
776         Fix GDK build by defining FrameGdkClient() constructor as non-virtual.
777         Pure virtual classes require non-pure destructor, who knew.
778
779         Make CURL networking dependent on USE(CURL) instead of PLATFORM(GDK),
780         so that other platforms can also use CURL, if they wish.
781
782         Silence compiler warning about unused variable in SharedTimerLinux.cpp
783
784         * platform/ResourceLoaderInternal.h:
785         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
786         * platform/gdk/FrameGdk.h:
787         (WebCore::FrameGdkClient::~FrameGdkClient):
788         * platform/gdk/ResourceLoaderManager.cpp:
789         (WebCore::ResourceLoaderManager::downloadTimerCallback):
790         * platform/gdk/SharedTimerLinux.cpp:
791         (WebCore::stopSharedTimer):
792
793 2006-10-13  Beth Dakin  <bdakin@apple.com>
794
795         Reviewed by Geoff.
796
797         Build fix from my last check-in. Make hasOutlineAnnotation() non-
798         inline so that we don't have to include Document.h in 
799         RenderObject.h
800         Doing so causes a build failure in WebKit, and it probably isn't a 
801         good idea anyway.
802
803         * rendering/RenderObject.cpp:
804         (WebCore::RenderObject::hasOutlineAnnotation):
805         * rendering/RenderObject.h:
806         (WebCore::RenderObject::hasOutline):
807
808 2006-10-13  Beth Dakin  <bdakin@apple.com>
809
810         Patch written mostly by Ken Kraisler, but also by me.
811
812         Reviewed by Hyatt.
813
814         Fix for http://bugs.webkit.org/show_bug.cgi?id=10216 and <rdar://
815         problem/3391162> PDF created by printing should have live 
816         hyperlinks
817
818         * platform/GraphicsContext.cpp:
819         (WebCore::GraphicsContext::focusRingBoundingRect):
820         * platform/GraphicsContext.h:
821         * platform/cairo/GraphicsContextCairo.cpp:
822         (WebCore::GraphicsContext::setURLForRect):
823         * platform/cg/GraphicsContextCG.cpp:
824         (WebCore::GraphicsContext::setURLForRect): Implement method to add 
825         URL link to PDF document.
826         * rendering/InlineFlowBox.cpp:
827         (WebCore::InlineFlowBox::paint): Ask hasOutline() instead of 
828         querying the outline width
829         * rendering/RenderBlock.cpp:
830         (WebCore::RenderBlock::paintObject): Same as above.
831         * rendering/RenderFlow.cpp:
832         (WebCore::RenderFlow::paintLines): Call the new paintOutline()
833         (WebCore::RenderFlow::paintOutline): Take care of focus ring and 
834         pdf url rects, and outline painting.
835         * rendering/RenderFlow.h:
836         * rendering/RenderObject.cpp:
837         (WebCore::RenderObject::addPDFURLRect): Declaration to apply a PDF 
838         link to a rectanglular region.
839         (WebCore::RenderObject::paintOutline): Take care of pdf rects as 
840         well as focus ring painting.
841         * rendering/RenderObject.h:
842         (WebCore::RenderObject::hasOutlineAnnotation): Returns true is the 
843         element is a link and we are printing.
844         (WebCore::RenderObject::hasOutline): Returns true is the style has 
845         an outline and hasOutlineAnnotation() is true.
846         * rendering/RenderStyle.h:
847         (WebCore::RenderStyle::hasOutline): Returns true if outlineWidth is 
848         greater than 0 and outlineStyle is greater than BHIDDEN.
849
850 2006-10-13  Justin Garcia  <justin.garcia@apple.com>
851
852         Reviewed by ggaren and harrison
853         
854         <rdar://problem/4744008>
855         9A270: Mail crashes when I try to paste large items from Safari
856
857         * editing/ReplaceSelectionCommand.cpp:
858         (WebCore::ReplaceSelectionCommand::removeRedundantStyles):
859         Even though we put nodes in the hash map in pre-order, they don't necessary
860         come out of the iterator that way.  If a node is a redundant style span
861         and one of its pruned ancestors comes off the hash map after it, and that
862         ancestor is a redundant style span or font tag, we will try to remove it
863         even though it has already been removed and we'll crash.
864         The test case added with the fix depends on our hash map implementation
865         because it requires that a particular redundant style span come out of 
866         the iterator before its parent. So, it may eventually not provide 
867         coverage for the fix.
868
869 2006-10-13  Maciej Stachowiak  <mjs@apple.com>
870
871         Reviewed by Darin.
872
873         - split FrameLoadRequest off from ResourceRequest - it's a ResourceRequest plus frame name plus lockHistory bool
874
875         * WebCore.xcodeproj/project.pbxproj:
876         * bindings/js/kjs_window.cpp:
877         (KJS::createNewWindow):
878         (KJS::WindowFunc::callAsFunction):
879         * bridge/BrowserExtension.h:
880         * bridge/mac/BrowserExtensionMac.h:
881         * bridge/mac/BrowserExtensionMac.mm:
882         (WebCore::BrowserExtensionMac::createNewWindow):
883         * bridge/mac/FrameMac.h:
884         * bridge/mac/FrameMac.mm:
885         (WebCore::FrameMac::submitForm):
886         (WebCore::FrameMac::openURLRequest):
887         (WebCore::FrameMac::urlSelected):
888         * bridge/win/BrowserExtensionWin.h:
889         * page/Frame.cpp:
890         (WebCore::Frame::changeLocation):
891         (WebCore::Frame::urlSelected):
892         (WebCore::Frame::requestFrame):
893         (WebCore::Frame::submitForm):
894         * page/Frame.h:
895         * page/FrameLoadRequest.h: Added.
896         (WebCore::FrameLoadRequest::FrameLoadRequest):
897         (WebCore::FrameLoadRequest::lockHistory):
898         (WebCore::FrameLoadRequest::setLockHistory):
899         * page/ResourceRequest.h:
900         (WebCore::ResourceRequest::ResourceRequest):
901
902 2006-10-13  John Sullivan  <sullivan@apple.com>
903
904         Reviewed by Maciej
905
906         * loader/mac/WebFrameLoader.mm:
907         (-[WebFrameLoader loadDocumentLoader:]):
908         Replace ASSERT(!policyDocumentLoader) with code that handles this case. This can
909         happen when loading a page during a decidePolicyForNavigationAction callback.
910
911 2006-10-13  Dave Hyatt  <hyatt@apple.com>
912
913         Transparency layer work.
914
915         Reviewed by aroben
916
917         * platform/GraphicsContext.h:
918         * platform/cg/GraphicsContextCG.cpp:
919         (WebCore::GraphicsContext::beginTransparencyLayer):
920         (WebCore::GraphicsContext::endTransparencyLayer):
921         * platform/cg/GraphicsContextPlatformPrivate.h:
922         (WebCore::GraphicsContextPlatformPrivate::beginTransparencyLayer):
923         (WebCore::GraphicsContextPlatformPrivate::endTransparencyLayer):
924
925 2006-10-13  Rob Buis  <buis@kde.org>
926
927         Reviewed by Mitz.
928
929         http://bugs.webkit.org/show_bug.cgi?id=11217
930         Cleanup svg coding style
931
932         Cleanup coding style in svg paint server classes.
933
934         * ksvg2/svg/SVGGradientElement.cpp:
935         (WebCore::SVGGradientElement::SVGGradientElement):
936         (WebCore::SVGGradientElement::parseMappedAttribute):
937         (WebCore::SVGGradientElement::notifyAttributeChange):
938         (WebCore::SVGGradientElement::canvasResource):
939         (WebCore::SVGGradientElement::rebuildStops):
940         * ksvg2/svg/SVGGradientElement.h:
941         * ksvg2/svg/SVGLinearGradientElement.cpp:
942         (WebCore::SVGLinearGradientElement::SVGLinearGradientElement):
943         (WebCore::SVGLinearGradientElement::parseMappedAttribute):
944         (WebCore::SVGLinearGradientElement::buildGradient):
945         * ksvg2/svg/SVGLinearGradientElement.h:
946         * ksvg2/svg/SVGPatternElement.cpp:
947         (WebCore::SVGPatternElement::SVGPatternElement):
948         (WebCore::SVGPatternElement::parseMappedAttribute):
949         (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
950         (WebCore::SVGPatternElement::drawPatternContentIntoTile):
951         (WebCore::SVGPatternElement::notifyClientsToRepaint):
952         (WebCore::SVGPatternElement::notifyAttributeChange):
953         (WebCore::SVGPatternElement::canvasResource):
954         (WebCore::SVGPatternElement::getCTM):
955         * ksvg2/svg/SVGPatternElement.h:
956         (WebCore::SVGPatternElement::rendererIsNeeded):
957         * ksvg2/svg/SVGRadialGradientElement.cpp:
958         (WebCore::SVGRadialGradientElement::SVGRadialGradientElement):
959         (WebCore::SVGRadialGradientElement::parseMappedAttribute):
960         (WebCore::SVGRadialGradientElement::buildGradient):
961         * ksvg2/svg/SVGRadialGradientElement.h:
962         * ksvg2/svg/SVGStopElement.cpp:
963         (WebCore::SVGStopElement::SVGStopElement):
964         (WebCore::SVGStopElement::parseMappedAttribute):
965         * ksvg2/svg/SVGStopElement.h:
966
967 2006-10-13  Geoffrey Garen  <ggaren@apple.com>
968
969         Reviewed by Darin, John.
970
971         - Merged more frame and iframe code
972         - Fixed a bug where iframes returned incorrect values for renderer-dependent 
973         properties during javascript: loads because they didn't have renderers at 
974         load time
975         
976         PLT insists this is a small performance win. Don't believe its lies.
977
978         * bindings/js/kjs_html.cpp:
979         (KJS::JSHTMLElement::frameGetter): Renamed frameWidth and frameHeight to
980         width and height, for consistency with the rest of the DOM.
981         * dom/ContainerNode.cpp:
982         (WebCore::ContainerNode::queuePostAttachCallback): Added a post-attach callback
983         queue that gets drained after the render tree is fully constructed. Currently,
984         this is only used for frame loading.
985         (WebCore::ContainerNode::attach):
986         * dom/ContainerNode.h:
987         * html/HTMLFrameElement.cpp:
988         (WebCore::HTMLFrameElement::insertedIntoDocument): Removed frame loading from
989         attach() because loading iframes during attach() causes a crash. 
990         Moved frame loading logic into insertedIntoDocument(). That's a more 
991         logical place for it because  document insertion is what 
992         triggers frame loading. Made frame loading a post-attach callback, instead
993         of an immediate action, to fix the incorrect values bug.
994         (WebCore::HTMLFrameElement::attach): Added setWidget call that used to be
995         in HTMLIFrameElement::attach. IFRAME requires this call. FRAME will soon 
996         require this call, once I remove the call from WebKit.
997         (WebCore::HTMLFrameElement::setLocation):
998         (WebCore::HTMLFrameElement::width):
999         (WebCore::HTMLFrameElement::height):
1000         * html/HTMLFrameElement.h: Made openURL non-virtual to avoid the unnecessary
1001         killing of puppies.
1002         * html/HTMLIFrameElement.cpp: Merged code into HTMLFrameElement
1003         (WebCore::HTMLIFrameElement::rendererIsNeeded):
1004         (WebCore::HTMLIFrameElement::createRenderer):
1005         (WebCore::HTMLIFrameElement::insertedIntoDocument):
1006         (WebCore::HTMLIFrameElement::removedFromDocument):
1007         (WebCore::HTMLIFrameElement::attach):
1008         * page/FrameView.h: Removed unused method.
1009
1010 2006-10-13  David Harrison  <harrison@apple.com>
1011
1012         Reviewed by Justin.
1013
1014         <rdar://problem/4746860> Mail crash in WebCore::CSSMutableStyleDeclaration::merge(WebCore::CSSMutableStyleDeclaration*, bool)
1015
1016         Tests added or changed:
1017         * editing/style/style-boundary-005.html: Added. Matches steps from bug.
1018         * editing/execCommand/hilitecolor-expected.txt: Updated (no empty Apple style spans).
1019         * editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Updated (no empty Apple style spans).
1020         * editing/style/remove-underline-in-bold-expected.txt: Updated (no empty Apple style spans).
1021         * editing/style/typing-style-003-expected.txt: Updated (no empty Apple style spans).
1022
1023         * dom/Text.cpp:
1024         (WebCore::Text::splitText):
1025         Comment changes.
1026         
1027         * editing/ApplyStyleCommand.cpp:
1028         (WebCore::isUnstyledStyleSpan):
1029         Renamed from isEmptyStyleSpan.
1030         
1031         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
1032         Rename emptySpans local to unstyledSpans.
1033         
1034         (WebCore::dummySpanAncestorForNode):
1035         New. To locate Apple style span created when splitting a text node.
1036         
1037         (WebCore::ApplyStyleCommand::cleanupUnstyledAppleStyleSpans):
1038         Renamed from cleanUpEmptyStyleSpans. Algorithm changed to scan children
1039         of dummy span's parents, rather than traversing up from start and
1040         end locations. Old algorithm would miss empty spans in the bug case.
1041         
1042         (WebCore::ApplyStyleCommand::applyInlineStyle):
1043         Use dummySpanAncestorForNode() and cleanupUnstyledAppleStyleSpans().
1044         
1045         (WebCore::ApplyStyleCommand::removeCSSStyle):
1046         Renamed isEmptyStyleSpan() to isUnstyledStyleSpan().
1047         
1048         (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
1049         Comment changes.
1050         
1051         * editing/ApplyStyleCommand.h:
1052         Renamed cleanUpEmptyStyleSpans() to cleanupUnstyledAppleStyleSpans().
1053           
1054         * editing/ReplaceSelectionCommand.cpp:
1055         (WebCore::ReplaceSelectionCommand::removeRedundantStyles):
1056         Allow for Apple style span to be unstyled, because old email may have this in the DOM.
1057         Use !node->hasChildNodes() instead of !node->firstChild().
1058         
1059         * editing/SplitTextNodeCommand.cpp:
1060         (WebCore::SplitTextNodeCommand::doApply):
1061         Comment changes.
1062         
1063         * rendering/RenderTreeAsText.cpp:
1064         (WebCore::isEmptyOrUnstyledAppleStyleSpan):
1065         (WebCore::operator<<):
1066         Flag empty or unstyled AppleStyleSpa nbecause we never want to leave them in the DOM
1067
1068 2006-10-13  Nikolas Zimmermann  <zimmermann@kde.org>
1069
1070         Reviewed by Eric.
1071
1072         Fix Qt/Linux build after Adele's popup menu changes.
1073
1074         * CMakeLists.txt:
1075         * platform/qt/FileChooserQt.cpp:
1076         (WebCore::FileChooser::disconnectUploadControl):
1077         * platform/qt/PopupMenuQt.cpp: Added.
1078         (WebCore::PopupMenu::PopupMenu):
1079         (WebCore::PopupMenu::~PopupMenu):
1080         (WebCore::PopupMenu::clear):
1081         (WebCore::PopupMenu::populate):
1082         (WebCore::PopupMenu::show):
1083         (WebCore::PopupMenu::hide):
1084         (WebCore::PopupMenu::addSeparator):
1085         (WebCore::PopupMenu::addGroupLabel):
1086         (WebCore::PopupMenu::addOption):
1087         * platform/qt/RenderPopupMenuQt.cpp: Removed.
1088         * platform/qt/RenderPopupMenuQt.h: Removed.
1089         * platform/qt/RenderThemeQt.cpp:
1090
1091 2006-10-13  Kevin McCullough  <KMcCullough@apple.com>
1092
1093         Reviewed by Darin.
1094
1095         fixed build failure 
1096
1097         * WebCore.xcodeproj/project.pbxproj:
1098         * loader/mac/WebFrameLoader.mm:
1099
1100 2006-10-13  Darin Adler  <darin@apple.com>
1101
1102         Reviewed by Adele.
1103
1104         - converted WebFormState from Objective-C to C++
1105
1106         * WebCore.exp: Added a new symbol, changed one symbol from C to C++.
1107
1108         * WebCore.xcodeproj/project.pbxproj: Made lots of headers "private" instead of "project".
1109         Added UChar.h and FrameLoaderTypes.h.
1110
1111         * loader/FrameLoaderTypes.h: Added. Has enums from WebFrameLoader.h.
1112
1113         * loader/mac/WebFormState.h: Converted class to C++.
1114         * loader/mac/WebFormState.mm: Ditto.
1115
1116         * loader/mac/WebFrameLoader.h:
1117         * loader/mac/WebFrameLoader.mm:
1118         (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
1119         (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]):
1120         (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
1121         (-[WebFrameLoader invalidatePendingPolicyDecisionCallingDefaultAction:]):
1122         (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]):
1123         (-[WebFrameLoader continueAfterNewWindowPolicy:]):
1124         (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]):
1125         (-[WebFrameLoader continueAfterNavigationPolicy:]):
1126         (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
1127         (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
1128         (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
1129         (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
1130         Changed Objective-C WebFormState uses to C++ WebCore::FormState.
1131
1132 2006-10-13  Adele Peterson  <adele@apple.com>
1133
1134         Reviewed by Maciej.
1135
1136         - Fix for <rdar://problem/4768591> REGRESSION: List box selection color should just be a darker version of regular selection color
1137
1138         * rendering/RenderListBox.cpp:
1139         (WebCore::RenderListBox::paintItemForeground):
1140         * rendering/RenderTheme.cpp:
1141         (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
1142         (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
1143         (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
1144         (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
1145         * rendering/RenderThemeMac.h:
1146         * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::activeListBoxSelectionBackgroundColor):
1147
1148 2006-10-13  Rob Buis  <buis@kde.org>
1149
1150         Reviewed by Mitz.
1151
1152         http://bugs.webkit.org/show_bug.cgi?id=11217
1153         Cleanup svg coding style
1154
1155         Cleanup coding style in svg structure classes.
1156
1157         * ksvg2/svg/SVGDefsElement.cpp:
1158         (WebCore::SVGDefsElement::SVGDefsElement):
1159         * ksvg2/svg/SVGDefsElement.h:
1160         * ksvg2/svg/SVGDescElement.cpp:
1161         (WebCore::SVGDescElement::SVGDescElement):
1162         * ksvg2/svg/SVGDescElement.h:
1163         * ksvg2/svg/SVGDocument.cpp:
1164         * ksvg2/svg/SVGDocument.h:
1165         * ksvg2/svg/SVGElementInstance.cpp:
1166         (WebCore::SVGElementInstance::SVGElementInstance):
1167         (WebCore::SVGElementInstance::correspondingElement):
1168         (WebCore::SVGElementInstance::correspondingUseElement):
1169         (WebCore::SVGElementInstance::parentNode):
1170         (WebCore::SVGElementInstance::childNodes):
1171         (WebCore::SVGElementInstance::previousSibling):
1172         (WebCore::SVGElementInstance::nextSibling):
1173         (WebCore::SVGElementInstance::firstChild):
1174         (WebCore::SVGElementInstance::lastChild):
1175         * ksvg2/svg/SVGElementInstance.h:
1176         * ksvg2/svg/SVGElementInstanceList.cpp:
1177         * ksvg2/svg/SVGElementInstanceList.h:
1178         * ksvg2/svg/SVGGElement.cpp:
1179         (WebCore::SVGGElement::SVGGElement):
1180         (WebCore::SVGGElement::parseMappedAttribute):
1181         (WebCore::SVGDummyElement::SVGDummyElement):
1182         * ksvg2/svg/SVGGElement.h:
1183         (WebCore::SVGGElement::rendererIsNeeded):
1184         * ksvg2/svg/SVGImageElement.cpp:
1185         (WebCore::SVGImageElement::createRenderer):
1186         * ksvg2/svg/SVGImageElement.h:
1187         * ksvg2/svg/SVGSVGElement.cpp:
1188         (WebCore::SVGSVGElement::SVGSVGElement):
1189         (WebCore::SVGSVGElement::pixelUnitToMillimeterX):
1190         (WebCore::SVGSVGElement::pixelUnitToMillimeterY):
1191         (WebCore::SVGSVGElement::currentScale):
1192         (WebCore::SVGSVGElement::setCurrentScale):
1193         (WebCore::SVGSVGElement::currentTranslate):
1194         (WebCore::SVGSVGElement::parseMappedAttribute):
1195         (WebCore::SVGSVGElement::suspendRedraw):
1196         (WebCore::SVGSVGElement::unsuspendRedraw):
1197         (WebCore::SVGSVGElement::unsuspendRedrawAll):
1198         (WebCore::SVGSVGElement::forceRedraw):
1199         (WebCore::SVGSVGElement::getIntersectionList):
1200         (WebCore::SVGSVGElement::getEnclosureList):
1201         (WebCore::SVGSVGElement::checkIntersection):
1202         (WebCore::SVGSVGElement::checkEnclosure):
1203         (WebCore::SVGSVGElement::deselectAll):
1204         (WebCore::SVGSVGElement::createSVGLength):
1205         (WebCore::SVGSVGElement::createSVGAngle):
1206         (WebCore::SVGSVGElement::createSVGMatrix):
1207         (WebCore::SVGSVGElement::createSVGTransform):
1208         (WebCore::SVGSVGElement::createSVGTransformFromMatrix):
1209         (WebCore::SVGSVGElement::getCTM):
1210         (WebCore::SVGSVGElement::getScreenCTM):
1211         (WebCore::SVGSVGElement::setCurrentTime):
1212         * ksvg2/svg/SVGSVGElement.h:
1213         (WebCore::SVGSVGElement::rendererIsNeeded):
1214         * ksvg2/svg/SVGSwitchElement.cpp:
1215         (WebCore::SVGSwitchElement::SVGSwitchElement):
1216         (WebCore::SVGSwitchElement::childShouldCreateRenderer):
1217         * ksvg2/svg/SVGSwitchElement.h:
1218         (WebCore::SVGSwitchElement::rendererIsNeeded):
1219         * ksvg2/svg/SVGSymbolElement.cpp:
1220         (WebCore::SVGSymbolElement::SVGSymbolElement):
1221         (WebCore::SVGSymbolElement::parseMappedAttribute):
1222         * ksvg2/svg/SVGSymbolElement.h:
1223         (WebCore::SVGSymbolElement::shouldAttachChild):
1224         * ksvg2/svg/SVGTitleElement.cpp:
1225         (WebCore::SVGTitleElement::SVGTitleElement):
1226         * ksvg2/svg/SVGTitleElement.h:
1227         * ksvg2/svg/SVGUseElement.cpp:
1228         (WebCore::SVGUseElement::parseMappedAttribute):
1229         (WebCore::SVGUseElement::closeRenderer):
1230         * ksvg2/svg/SVGUseElement.h:
1231         (WebCore::SVGUseElement::rendererIsNeeded):
1232
1233 2006-10-12  Adele Peterson  <adele@apple.com>
1234
1235         Reviewed by Anders.
1236
1237         - Fix for http://bugs.webkit.org/show_bug.cgi?id=11172
1238           REGRESSION (NativeListBox): OPTION text paints over the edge of the select element at http://jobs.apple.com/
1239         
1240          Test: fast/forms/listbox-width-change.html
1241
1242         * rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement):
1243           When the options change, call setNeedsLayoutAndMinMaxRecalc.
1244
1245 2006-10-12  Maciej Stachowiak  <mjs@apple.com>
1246
1247         Reviewed by Oliver.
1248
1249         - moved a bunch of WebFrameBridge code down to WebCoreFrameBridge, now that it no longer has any WebKit dependencies
1250
1251         * WebCore.xcodeproj/project.pbxproj:
1252         * bridge/mac/WebCoreFrameBridge.h:
1253         * bridge/mac/WebCoreFrameBridge.mm:
1254         (stringByCollapsingNonPrintingCharacters):
1255         (-[WebCoreFrameBridge setTitle:]):
1256         (-[WebCoreFrameBridge didFirstLayout]):
1257         (-[WebCoreFrameBridge notifyIconChanged:]):
1258         (-[WebCoreFrameBridge originalRequestURL]):
1259         (-[WebCoreFrameBridge isLoadTypeReload]):
1260         (-[WebCoreFrameBridge frameDetached]):
1261         (-[WebCoreFrameBridge tokenizerProcessedData]):
1262         (-[WebCoreFrameBridge receivedData:textEncodingName:]):
1263         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
1264         (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]):
1265         (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
1266         (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
1267         (-[WebCoreFrameBridge reportClientRedirectCancelled:]):
1268         (-[WebCoreFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):
1269         (-[WebCoreFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
1270         (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
1271         (-[WebCoreFrameBridge incomingReferrer]):
1272         (-[WebCoreFrameBridge isReloading]):
1273         (-[WebCoreFrameBridge handledOnloadEvents]):
1274         (-[WebCoreFrameBridge mainResourceURLResponse]):
1275         (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
1276         * loader/mac/LoaderNSURLExtras.h:
1277         * loader/mac/LoaderNSURLRequestExtras.h: Added.
1278         * loader/mac/LoaderNSURLRequestExtras.m: Added.
1279         (isConditionalRequest):
1280         (setHTTPReferrer):
1281         * loader/mac/WebFrameLoader.mm:
1282         * loader/mac/WebSubresourceLoader.mm:
1283
1284 2006-10-12  Adele Peterson  <adele@apple.com>
1285
1286         RS by Geoff.
1287
1288         Renamed menuListIsDetaching to disconnectMenuList, 
1289         uploadControlDetaching to disconnectUploadControl, and fileChooserDetachingSoon to disconnectFileChooser.  
1290         These names match similar methods in WebCore a little better.
1291
1292         * platform/FileChooser.h:
1293         * platform/PopupMenu.h: (WebCore::PopupMenu::disconnectMenuList):
1294         * platform/mac/FileChooserMac.mm: (-[OpenPanelController disconnectFileChooser]):
1295         (WebCore::FileChooser::disconnectUploadControl):
1296         * platform/win/TemporaryLinkStubs.cpp: (FileChooser::disconnectUploadControl):
1297         * rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
1298         * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList):
1299
1300 2006-10-12  Adele Peterson  <adele@apple.com>
1301
1302         Reviewed by Maciej.
1303
1304         WebCore part of fix for <rdar://problem/4450613> need a means to attach user data to any menu that is popuped up in HTML
1305
1306         Added private delegate method for clients that want access to a PopupMenu's NSMenu.
1307
1308         * bridge/mac/FrameMac.h:
1309         * bridge/mac/FrameMac.mm: (WebCore::FrameMac::willPopupMenu):
1310         * bridge/mac/WebCoreFrameBridge.h:
1311
1312         * platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Calls willPopupMenu with the NSMenu about to be popped up.
1313
1314 2006-10-12  Adele Peterson  <adele@apple.com>
1315
1316         Reviewed by Alice.
1317
1318         - Fix for <rdar://problem/4707372> 
1319           After timers fix, crash in -[NSMenu performActionForItemAtIndex:] after moving/detroying active popup menu
1320
1321         * platform/PopupMenu.h: (WebCore::PopupMenu::menuListIsDetaching): Added. Zeros out the pointer to the menu list.
1322         * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList): Calls menuListIsDetaching.
1323         * platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Added a RefPtr to protect the PopupMenu while the NSMenu is up,
1324           in case the RenderMenuList goes away.  Also, checks the pointer to the menu list immediately afterwards.
1325
1326 2006-10-12  Nikolas Zimmermann  <zimmermann@kde.org>
1327
1328         Reviewed by Maciej.
1329
1330         Trying to fix "DRT hangs on certain testcases" like fast/dom/Document/document-reopen.html
1331         document.open(); document.write(..); and NO document.close(). On the Qt platform this
1332         leaves a HTMLDocument which is still in parsing mode (parsing() always returns true).
1333         DRT waits forever, but m_frame->isComplete() is never true due the parsing mode problem.
1334
1335         Hmpf, this took me nine hours to debug today.
1336         Result: Couldn't find the real fix, going for a workaround for now.
1337         
1338         540 minutes, 1 line of code changed after all -> 0,0019 lines per minute.
1339
1340         * platform/qt/FrameQt.cpp:
1341         (WebCore::FrameQt::handledOnloadEvents): Call endIfNotLoading() manually.
1342         * platform/qt/FrameQtClient.cpp:
1343         (WebCore::FrameQtClientDefault::receivedData): Use write() again instead of addData().
1344
1345 2006-10-12  Adam Roben  <aroben@apple.com>
1346
1347         Reviewed by Adele.
1348
1349         Move popup menu code out of rendering/ and into platform/.
1350         RenderPopupMenu becomes PopupMenu, the
1351         RenderPopupMenuMac/RenderPopupMenuWin subclasses and all the associated
1352         virtual methods go away, RenderTheme gets to stop worrying about popup
1353         menus, PopupMenu becomes ref-counted, and everyone becomes happy.
1354
1355         * WebCore.vcproj/WebCore/WebCore.vcproj: Move files within project.
1356         * WebCore.xcodeproj/project.pbxproj: Ditto.
1357         * html/HTMLSelectElement.cpp: Remove unnecessary #include.
1358         * platform/PopupMenu.cpp: Moved from rendering/RenderPopupMenu.cpp.
1359         Also renamed showPopup()/hidePopup() to show()/hide() to disambiguate
1360         from RenderMenuList::showPopup/hidePopup.
1361         (WebCore::PopupMenu::create): New static creation method to hand back a
1362         PassRefPtr<PopupMenu>.
1363         (WebCore::PopupMenu::addItems): This platform-independent method should
1364         be called by PopupMenu::populate when the platform-specific
1365         implementation is ready to receive the menu items. Fixed an ASSERT
1366         while I was at it.
1367         * platform/PopupMenu.h: Moved from rendering/RenderPopupMenu.h. No more
1368         need for virtual methods.
1369         (WebCore::PopupMenu::wasClicked):
1370         (WebCore::PopupMenu::setWasClicked):
1371         (WebCore::PopupMenu::popupHandle):
1372         * platform/mac/PopupMenuMac.mm: Moved from
1373         rendering/RenderPopupMenuMac.mm. Much renaming ensues.
1374         (WebCore::PopupMenu::PopupMenu):
1375         (WebCore::PopupMenu::~PopupMenu):
1376         (WebCore::PopupMenu::clear):
1377         (WebCore::PopupMenu::populate):
1378         (WebCore::PopupMenu::show):
1379         (WebCore::PopupMenu::hide):
1380         (WebCore::PopupMenu::addSeparator):
1381         (WebCore::PopupMenu::addGroupLabel): Since we don't have our own
1382         RenderStyle anymore, just pick up the style from our RenderMenuList.
1383         (WebCore::PopupMenu::addOption): Ditto.
1384         * platform/win/TemporaryLinkStubs.cpp: Rename-fest.
1385         (PopupMenu::PopupMenu):
1386         (PopupMenu::~PopupMenu):
1387         (PopupMenu::clear):
1388         (PopupMenu::populate):
1389         (PopupMenu::show):
1390         (PopupMenu::hide):
1391         (PopupMenu::addSeparator):
1392         (PopupMenu::addGroupLabel):
1393         (PopupMenu::addOption):
1394         * rendering/RenderMenuList.cpp:
1395         (WebCore::RenderMenuList::~RenderMenuList):
1396         (WebCore::RenderMenuList::showPopup): Use nice new simple
1397         PopupMenu::create to make the popup.
1398         (WebCore::RenderMenuList::hidePopup):
1399         * rendering/RenderMenuList.h: Hold a RefPtr<PopupMenu> instead of a
1400         RenderPopupMenu*.
1401         (WebCore::RenderMenuList::popup):
1402         * rendering/RenderPopupMenu.cpp: Removed.
1403         * rendering/RenderPopupMenu.h: Removed.
1404         * rendering/RenderPopupMenuMac.h: Removed.
1405         * rendering/RenderPopupMenuMac.mm: Removed.
1406         * rendering/RenderPopupMenuWin.h: Removed.
1407         * rendering/RenderTheme.cpp: Get rid of createPopupMenu() method.
1408         * rendering/RenderTheme.h: Ditto.
1409         * rendering/RenderThemeMac.h: Ditto.
1410         * rendering/RenderThemeMac.mm: Ditto.
1411         * rendering/RenderThemeWin.cpp: Ditto.
1412         * rendering/RenderThemeWin.h: Ditto.
1413
1414 2006-10-12  Adele Peterson  <adele@apple.com>
1415
1416         Reviewed by Dave Harrison.
1417
1418         - Fixed <rdar://problem/4650813> REGRESSION: typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
1419
1420         * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout):
1421         Make subtree layouts work for textareas as well as text fields.
1422
1423 2006-10-12  Nikolas Zimmermann  <zimmermann@kde.org>
1424
1425         Reviewed by MacDome.
1426
1427         Finally found a way to remove our begin() trickery in FrameQt.
1428         The (probably misnamed) Frame::setEncoding() function automatically
1429         calls Frame::receivedFirstData() which calls being on the working
1430         url, which has been passed to didOpenUrl(). Took me some hours
1431         to figure out that the missing charset logic, forced us to do hacks.
1432
1433         * platform/ResourceLoader.h:
1434         * platform/ResourceLoaderInternal.h:
1435         * platform/qt/FrameQt.cpp:
1436         (WebCore::FrameQt::tokenizerProcessedData):
1437         * platform/qt/FrameQt.h:
1438         * platform/qt/FrameQtClient.cpp:
1439         (WebCore::FrameQtClientDefault::FrameQtClientDefault):
1440         (WebCore::FrameQtClientDefault::openURL):
1441         (WebCore::FrameQtClientDefault::submitForm):
1442         (WebCore::FrameQtClientDefault::receivedData):
1443         (WebCore::FrameQtClientDefault::receivedAllData):
1444         * platform/qt/FrameQtClient.h:
1445         * platform/qt/ResourceLoaderManager.cpp:
1446         (WebCore::ResourceLoaderManager::slotData):
1447         (WebCore::ResourceLoaderManager::slotMimetype):
1448         (WebCore::ResourceLoaderManager::slotResult):
1449         (WebCore::ResourceLoaderManager::remove):
1450         * platform/qt/ResourceLoaderQt.cpp:
1451         (WebCore::ResourceLoader::retrieveCharset):
1452         (WebCore::ResourceLoader::extractCharsetFromHeaders):
1453
1454 2006-10-12  Adam Roben  <aroben@apple.com>
1455
1456         Reviewed by Hyatt.
1457
1458         Bandaid-ing a null-dereference crash until a real fix is made.
1459
1460         * page/FrameView.cpp:
1461         (WebCore::FrameView::windowClipRect):
1462
1463 2006-10-12  Rob Buis  <buis@kde.org>
1464
1465         Reviewed by Mitz.
1466
1467         http://bugs.webkit.org/show_bug.cgi?id=11217
1468         Cleanup svg coding style
1469
1470         Cleanup coding style in svg text classes.
1471
1472         * ksvg2/svg/SVGTRefElement.cpp:
1473         (WebCore::SVGTRefElement::SVGTRefElement):
1474         (WebCore::SVGTRefElement::updateReferencedText):
1475         (WebCore::SVGTRefElement::parseMappedAttribute):
1476         (WebCore::SVGTRefElement::childShouldCreateRenderer):
1477         (WebCore::SVGTRefElement::createRenderer):
1478         * ksvg2/svg/SVGTRefElement.h:
1479         (WebCore::SVGTRefElement::rendererIsNeeded):
1480         * ksvg2/svg/SVGTSpanElement.cpp:
1481         (WebCore::SVGTSpanElement::SVGTSpanElement):
1482         (WebCore::SVGTSpanElement::childShouldCreateRenderer):
1483         (WebCore::SVGTSpanElement::createRenderer):
1484         * ksvg2/svg/SVGTSpanElement.h:
1485         (WebCore::SVGTSpanElement::rendererIsNeeded):
1486         * ksvg2/svg/SVGTextContentElement.cpp:
1487         (WebCore::SVGTextContentElement::SVGTextContentElement):
1488         (WebCore::SVGTextContentElement::parseMappedAttribute):
1489         * ksvg2/svg/SVGTextContentElement.h:
1490         * ksvg2/svg/SVGTextElement.cpp:
1491         (WebCore::SVGTextElement::SVGTextElement):
1492         (WebCore::SVGTextElement::localMatrix):
1493         (WebCore::SVGTextElement::parseMappedAttribute):
1494         (WebCore::SVGTextElement::updateLocalTransform):
1495         (WebCore::SVGTextElement::nearestViewportElement):
1496         (WebCore::SVGTextElement::farthestViewportElement):
1497         (WebCore::SVGTextElement::getScreenCTM):
1498         (WebCore::SVGTextElement::getCTM):
1499         (WebCore::SVGTextElement::createRenderer):
1500         (WebCore::SVGTextElement::childShouldCreateRenderer):
1501         * ksvg2/svg/SVGTextElement.h:
1502         (WebCore::SVGTextElement::getTransformToElement):
1503         (WebCore::SVGTextElement::rendererIsNeeded):
1504         * ksvg2/svg/SVGTextPositioningElement.cpp:
1505         (WebCore::SVGTextPositioningElement::SVGTextPositioningElement):
1506         (WebCore::SVGTextPositioningElement::parseMappedAttribute):
1507         * ksvg2/svg/SVGTextPositioningElement.h:
1508
1509 2006-10-12  Nikolas Zimmermann  <zimmermann@kde.org>
1510
1511         Reviewed by Maciej.
1512
1513         Specialization of alert() for DumpRenderTree - just log the output, don't show any message box.
1514
1515         * platform/qt/FrameQt.cpp:
1516         (WebCore::FrameQt::runJavaScriptAlert): Move runJavaScriptAlert functionality to FrameQtClientDefault.
1517         * platform/qt/FrameQtClient.cpp:
1518         (WebCore::FrameQtClientDefault::runJavaScriptAlert):
1519         * platform/qt/FrameQtClient.h:
1520
1521 2006-10-12  Maciej Stachowiak  <mjs@apple.com>
1522
1523         Reviewed by Eric.
1524
1525         - move m_responseMIMEType out of ResourceRequest, where it doesn't belong
1526
1527         * page/FramePrivate.h: Add m_responseMIMEType
1528         * page/ResourceRequest.h: Remove m_responseMIMEType
1529         * page/Frame.cpp:
1530         (WebCore::Frame::setResponseMIMEType): added
1531         (WebCore::Frame::responseMIMEType): added
1532         (WebCore::Frame::begin): get MIME type from the right place
1533         (WebCore::Frame::write): ditto
1534         * page/Frame.h:
1535         * bindings/js/kjs_window.cpp:
1536         (KJS::createNewWindow): updated to use new Frame methods
1537         (KJS::WindowFunc::callAsFunction): ditto
1538         * bridge/mac/WebCoreFrameBridge.mm:
1539         (-[WebCoreFrameBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): ditto
1540         (-[WebCoreFrameBridge canProvideDocumentSource]): ditto
1541         * loader/PluginDocument.cpp:
1542         (WebCore::PluginTokenizer::createDocumentStructure): ditto
1543
1544 2006-10-12  Maciej Stachowiak  <mjs@apple.com>
1545
1546         Reviewed by Eric.
1547         
1548         <rdar://problem/4774321> REGRESSION: "Can't find the server" error page contains unstyled text and missing image
1549
1550         We really need some way to test loadHTMLString since it keeps breaking!
1551         
1552         * loader/mac/WebFrameLoader.mm:
1553         (-[WebFrameLoader commitProvisionalLoad:]): Set stuff up on the proper data source.
1554
1555 2006-10-12  Nikolas Zimmermann  <zimmermann@kde.org>
1556
1557         Reviewed by Eric.
1558
1559         Fix Qt/Linux build.
1560
1561         * CMakeLists.txt:
1562         * platform/qt/FileChooserQt.cpp:
1563         (WebCore::FileChooser::create):
1564
1565 2006-10-12  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
1566
1567         Reviewed by Maciej.
1568
1569         Update Gdk\Linux build for recent changes, based on Qt code
1570
1571         * platform/gdk/FrameGdk.cpp:
1572         (WebCore::FrameGdkClientDefault::FrameGdkClientDefault):
1573         (WebCore::FrameGdkClientDefault::~FrameGdkClientDefault):
1574         (WebCore::FrameGdkClientDefault::setFrame):
1575         (WebCore::FrameGdkClientDefault::openURL):
1576         (WebCore::FrameGdkClientDefault::submitForm):
1577         (WebCore::FrameGdkClientDefault::receivedResponse):
1578         (WebCore::FrameGdkClientDefault::receivedData):
1579         (WebCore::FrameGdkClientDefault::receivedAllData):
1580         (WebCore::FrameGdk::FrameGdk):
1581         (WebCore::FrameGdk::openURL):
1582         (WebCore::FrameGdk::submitForm):
1583         (WebCore::FrameGdk::urlSelected):
1584         * platform/gdk/FrameGdk.h:
1585         * platform/gdk/TemporaryLinkStubs.cpp:
1586         (FrameGdk::createJavaAppletWidget):
1587         (FileChooser::create):
1588
1589 2006-10-12  Dave Hyatt  <hyatt@apple.com>
1590
1591         Patch to add more clipping retrieval functionality for widgets.
1592        
1593         Reviewed by mjs
1594
1595         * page/Frame.h:
1596         Remove windowResizerRect.  This is in the wrong place.
1597         
1598         * page/FrameView.cpp:
1599         (WebCore::FrameView::windowClipRect):
1600         (WebCore::FrameView::windowClipRectForLayer):
1601         Break out windowClipRect into helper functions that can be called separately (to make
1602         it easier for scrollbars in overflow sections and list boxes to get to an enclosing
1603         layer and get the right clip.
1604         
1605         * page/FrameView.h:
1606         Add the new windowClipRect helper methods.
1607         
1608         * platform/ScrollBar.h:
1609         Add a new interface to ScrollbarClient so that scrollbars can hand back proper
1610         clip rects for themselves depending on how they are used.
1611         
1612         * platform/ScrollView.h:
1613         Stub out methods for talking to a double buffer backing store on Win32.
1614         
1615         * platform/Widget.h:
1616         Add the ability to query for invalidation suppression.
1617         
1618         * rendering/RenderLayer.cpp:
1619         (WebCore::RenderLayer::windowClipRect):
1620         (WebCore::RenderLayer::paintOverflowControls):
1621         (WebCore::RenderLayer::calculateRects):
1622         (WebCore::RenderLayer::childrenClipRect):
1623         (WebCore::RenderLayer::selfClipRect):
1624         * rendering/RenderLayer.h:
1625         Enhance layers so that they can return either their foreground or background
1626         document clip rects.  Make sure a layer scrollbar can return a proper clip.
1627         
1628         * rendering/RenderListBox.cpp:
1629         (WebCore::RenderListBox::windowClipRect):
1630         * rendering/RenderListBox.h:
1631         Make sure a list box scrollbar can return a proper clip.
1632         
1633         * rendering/RenderObject.cpp:
1634         (WebCore::RenderObject::enclosingLayer):
1635         * rendering/RenderObject.h:
1636         Make enclosingLayer const.
1637         
1638 2006-10-11  Darin Adler  <darin@apple.com>
1639
1640         Reviewed by John.
1641
1642         - some changes to prepare for converting more code to C++
1643
1644         * bridge/mac/WebCoreFrameBridge.h: Added import of <Cocoa/Cocoa.h> so this header is
1645         self-sufficient.
1646
1647         * bridge/mac/WebCoreViewFactory.h: Added forward declaration of the NSMenu class.
1648         Needed since the class is used in this header (for some work I have not landed yet).
1649
1650         * loader/mac/LoaderNSURLExtras.h:
1651         * loader/mac/WebFormDataStream.h:
1652         Added extern "C" so this code can be used from C++.
1653
1654         * loader/mac/LoaderNSURLExtras.m:
1655         * loader/mac/WebDataProtocol.mm:
1656         * loader/mac/WebDocumentLoader.mm:
1657         * loader/mac/WebFormDataStream.m:
1658         * loader/mac/WebLoader.mm:
1659         * loader/mac/WebMainResourceLoader.mm:
1660         * loader/mac/WebNetscapePlugInStreamLoader.mm:
1661         * loader/mac/WebPolicyDecider.mm:
1662         * loader/mac/WebSubresourceLoader.mm:
1663         Added missing includes of config.h.
1664
1665 2006-10-11  John Sullivan  <sullivan@apple.com>
1666         
1667         Darin wrote this code; we tested it; I give it the thumbs up.
1668         
1669         - fixed regression from svn revision 16982 that was generating the wrong Obj-C classes
1670
1671         The hash table to look up an element class given a QualifiedName was
1672         not working at all.
1673
1674         * dom/QualifiedName.h:
1675         (WebCore::QualifiedName::impl):
1676         Added. This new accessor method for impl is needed if we want to use
1677         a QualifiedName as a hash table key without doing the kind of specialization
1678         we do for String. Maybe later we can do the String thing.
1679
1680         * bindings/objc/DOM.mm:
1681         (WebCore::addElementClass):
1682         Use QualifiedName.impl instead of the QualifiedName pointer itself.
1683         The QualifiedName pointer is *not* unique so almost nothing would be found
1684         in this hash table!
1685         (WebCore::elementClass):
1686         ditto
1687         
1688 2006-10-11  Adam Roben  <aroben@apple.com>
1689
1690         Rubberstamped by Anders.
1691
1692         Clean up FileChooser::create and Icon::newIconForFile.
1693
1694         * WebCore.xcodeproj/project.pbxproj:
1695         * platform/mac/FileChooserMac.mm:
1696         (WebCore::FileChooser::create):
1697         * platform/mac/IconMac.mm:
1698         (WebCore::Icon::newIconForFile):
1699
1700 2006-10-11  Oliver Hunt  <oliver@apple.com>
1701
1702         Reviewed by Adam.
1703
1704         Fix for http://bugs.webkit.org/show_bug.cgi?id=11251
1705         Corrects canvas tag to not throw JS exception when drawing
1706         zero sized rects, arcs, etc
1707
1708         * html/CanvasRenderingContext2D.cpp:
1709         (WebCore::CanvasRenderingContext2D::arcTo):
1710         (WebCore::CanvasRenderingContext2D::arc):
1711         (WebCore::CanvasRenderingContext2D::rect):
1712         (WebCore::CanvasRenderingContext2D::clearRect):
1713         (WebCore::CanvasRenderingContext2D::fillRect):
1714         (WebCore::CanvasRenderingContext2D::strokeRect):
1715
1716 2006-10-11  Rob Buis  <buis@kde.org>
1717
1718         Reviewed by Mitz.
1719
1720         http://bugs.webkit.org/show_bug.cgi?id=11221
1721         REGRESSION: iExploder crash due to style="cursor: url()"
1722
1723         Take better care of empty cursor lists.
1724
1725         Test: fast/css/invalid-cursor-property-crash.html
1726
1727         * css/cssparser.cpp:
1728         (WebCore::CSSParser::parseValue):
1729
1730 2006-10-11  Adam Roben  <aroben@apple.com>
1731
1732         Fixing Windows for real this time.
1733
1734         * platform/win/TemporaryLinkStubs.cpp:
1735         (FileChooser::create):
1736
1737 2006-10-11  Adam Roben  <aroben@apple.com>
1738
1739         Fix Windows build.
1740
1741         * platform/win/TemporaryLinkStubs.cpp:
1742         (FileChooser::create):
1743
1744 2006-10-11  Antti Koivisto  <koivisto@iki.fi>
1745
1746         Reviewed by Hyatt.
1747         
1748         http://bugs.webkit.org/show_bug.cgi?id=4377
1749         
1750         Respect css visibility semantics for layers too
1751
1752         * rendering/RenderContainer.cpp:
1753         (WebCore::RenderContainer::removeChildNode):
1754         (WebCore::RenderContainer::appendChildNode):
1755         (WebCore::RenderContainer::insertChildNode):
1756         * rendering/RenderLayer.cpp:
1757         (WebCore::RenderLayer::RenderLayer):
1758         (WebCore::RenderLayer::updateLayerPositions):
1759         (WebCore::RenderLayer::setHasVisibleContent):
1760         (WebCore::RenderLayer::dirtyVisibleContentStatus):
1761         (WebCore::RenderLayer::childVisibilityChanged):
1762         (WebCore::RenderLayer::dirtyVisibleDescendantStatus):
1763         (WebCore::RenderLayer::updateVisibilityStatus):
1764         (WebCore::RenderLayer::addChild):
1765         (WebCore::RenderLayer::removeChild):
1766         (WebCore::RenderLayer::updateZOrderLists):
1767         (WebCore::RenderLayer::collectLayers):
1768         * rendering/RenderLayer.h:
1769         (WebCore::RenderLayer::hasVisibleContent):
1770         * rendering/RenderObject.cpp:
1771         (WebCore::RenderObject::setStyle):
1772
1773 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
1774
1775         Reviewed by Oliver.
1776
1777         - added RetainPtr, smart pointer for refcounted ObjC objects and CFTypes
1778
1779         * WebCore.xcodeproj/project.pbxproj:
1780         * platform/cf/RetainPtr.h: Added.
1781         (WTF::):
1782         (WTF::RetainPtr::RetainPtr):
1783         (WTF::RetainPtr::~RetainPtr):
1784         (WTF::RetainPtr::get):
1785         (WTF::RetainPtr::operator*):
1786         (WTF::RetainPtr::operator->):
1787         (WTF::RetainPtr::operator!):
1788         (WTF::RetainPtr::operator UnspecifiedBoolType):
1789         (WTF::::operator):
1790         (WTF::::swap):
1791         (WTF::swap):
1792         (WTF::operator==):
1793         (WTF::operator!=):
1794         (WTF::static_pointer_cast):
1795         (WTF::const_pointer_cast):
1796         (WTF::getPtr):
1797         
1798         - use it in WidgetMac so it gets tested in at least one place
1799         
1800         * platform/mac/WidgetMac.mm:
1801         (WebCore::Widget::Widget):
1802         (WebCore::Widget::~Widget):
1803         (WebCore::Widget::setEnabled):
1804         (WebCore::Widget::isEnabled):
1805         (WebCore::Widget::setCursor):
1806         (WebCore::Widget::getView):
1807         (WebCore::Widget::setView):
1808         (WebCore::Widget::getOuterView):
1809
1810 2006-10-10  Brady Eidson  <beidson@apple.com>
1811
1812         Reviewed by Maciej.
1813
1814         Moved WebFrameLoader from WebFrameBridge into WebCoreFrameBridge
1815
1816         * bridge/mac/WebCoreFrameBridge.h:
1817         * bridge/mac/WebCoreFrameBridge.mm:
1818         (-[WebCoreFrameBridge initMainFrameWithPage:]):
1819         (-[WebCoreFrameBridge initSubframeWithOwnerElement:]):
1820         (-[WebCoreFrameBridge dealloc]):
1821         (-[WebCoreFrameBridge close]):
1822         (-[WebCoreFrameBridge setFrameLoaderClient:]):
1823         (-[WebCoreFrameBridge frameLoader]):
1824         * loader/mac/WebFrameLoader.h:
1825         * loader/mac/WebFrameLoader.mm:
1826         (-[WebFrameLoader initWithFrameBridge:]):
1827         (-[WebFrameLoader setFrameLoaderClient:]):
1828
1829 2006-10-10  Adam Roben  <aroben@apple.com>
1830
1831         Reviewed by Oliver.
1832
1833         Make FileChooser ref-counted.
1834
1835         * platform/FileChooser.h:
1836         * platform/mac/FileChooserMac.mm:
1837         (WebCore::FileChooser::create):
1838         * rendering/RenderFileUploadControl.cpp:
1839         (WebCore::RenderFileUploadControl::RenderFileUploadControl):
1840         (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
1841         * rendering/RenderFileUploadControl.h:
1842
1843 2006-10-10  Sam Weinig  <sam.weinig@gmail.com>
1844
1845         Reviewed by Tim H.
1846
1847         Patch for http://bugs.webkit.org/show_bug.cgi?id=11248
1848         Even More auto-generated Objective-C DOM bindings changes
1849
1850         - Auto-generate DOMSVGPathElement.
1851
1852         - Auto-generate the internal interfaces even for classes that have
1853           custom internal implementations.  Change IDL property from ObjCNoInternal
1854           to ObjCCustomInternalImpl to indicate the change.
1855
1856         - Add SVG classes to DOMNode and DOMEvent internal interfaces.
1857
1858         - Add isSVGZoomEvent() method to Event class to match other Event subclasses
1859           and make DOM binding possible.
1860
1861         - Assorted cleanups.
1862
1863         * DerivedSources.make:
1864         * WebCore.xcodeproj/project.pbxproj:
1865         * bindings/objc/DOM.mm:
1866         (WebCore::addElementClass):
1867         (WebCore::createElementClassMap):
1868         (WebCore::elementClass):
1869         (-[DOMNode description]):
1870         (+[DOMNode _nodeWith:WebCore::]):
1871         (-[DOMNode addEventListener:listener:useCapture:]):
1872         (-[DOMNode removeEventListener:listener:useCapture:]):
1873         (-[DOMElement _NPObject]):
1874         (WebCore::ObjCEventListener::handleEvent):
1875         * bindings/objc/DOMEvents.mm:
1876         (+[DOMEvent _eventWith:WebCore::]):
1877         * bindings/objc/DOMInternal.h:
1878         * bindings/objc/DOMRGBColor.mm:
1879         (-[DOMRGBColor WebCore::]):
1880         * bindings/objc/DOMSVGPathSegInternal.h: Removed.
1881         * bindings/scripts/CodeGeneratorObjC.pm:
1882         * css/CSSRule.idl:
1883         * css/CSSValue.idl:
1884         * css/StyleSheet.idl:
1885         * dom/Event.cpp:
1886         (WebCore::Event::isSVGZoomEvent):
1887         * dom/Event.h:
1888         * dom/Event.idl:
1889         * dom/Node.idl:
1890         * ksvg2/events/SVGZoomEvent.cpp:
1891         (WebCore::SVGZoomEvent::isSVGZoomEvent):
1892         * ksvg2/events/SVGZoomEvent.h:
1893         * ksvg2/svg/SVGAnimatedAngle.idl:
1894         * ksvg2/svg/SVGCircleElement.idl:
1895         * ksvg2/svg/SVGClipPathElement.idl:
1896         * ksvg2/svg/SVGPathElement.idl:
1897         * ksvg2/svg/SVGPathSeg.idl:
1898
1899 2006-10-10  Oliver Hunt  <oliver@apple.com>
1900
1901         rubber stamped by Anders.
1902
1903         More buildbot bustage
1904
1905         * kcanvas/SVGInlineFlowBox.cpp:
1906         (WebCore::placeBoxesVerticallyWithAbsBaseline):
1907
1908 2006-10-10  Oliver Hunt  <oliver@apple.com>
1909
1910         Reviewed by Anders 
1911
1912         Unbreak build bots
1913
1914         * dom/Text.cpp:
1915         * kcanvas/RenderSVGText.cpp:
1916         (WebCore::RenderSVGText::layout):
1917         * kcanvas/SVGInlineFlowBox.cpp:
1918         (WebCore::placePositionedBoxesHorizontally):
1919         (WebCore::placeBoxesVerticallyWithAbsBaseline):
1920
1921 2006-10-10  Oliver Hunt  <oliver@apple.com>
1922
1923         Reviewed by hyatt.
1924
1925         Fixes bugs #6423, #6559, #10380 and #10839 
1926
1927         * WebCore.xcodeproj/project.pbxproj:
1928         * css/svg.css:
1929         * dom/Text.cpp:
1930         (WebCore::Text::createRenderer):
1931         * kcanvas/RenderSVGInline.cpp: Added.
1932         (WebCore::RenderSVGInline::RenderSVGInline):
1933         (WebCore::RenderSVGInline::createInlineBox):
1934         * kcanvas/RenderSVGInline.h: Added.
1935         (WebCore::RenderSVGInline::renderName):
1936         (WebCore::RenderSVGInline::requiresLayer):
1937         * kcanvas/RenderSVGInlineText.cpp: Added.
1938         (WebCore::RenderSVGInlineText::RenderSVGInlineText):
1939         (WebCore::RenderSVGInlineText::absoluteRects):
1940         (WebCore::RenderSVGInlineText::selectionRect):
1941         * kcanvas/RenderSVGInlineText.h: Added.
1942         (WebCore::RenderSVGInlineText::renderName):
1943         (WebCore::RenderSVGInlineText::requiresLayer):
1944         * kcanvas/RenderSVGTSpan.cpp: Added.
1945         (WebCore::RenderSVGTSpan::RenderSVGTSpan):
1946         (WebCore::RenderSVGTSpan::absoluteRects):
1947         * kcanvas/RenderSVGTSpan.h: Added.
1948         (WebCore::RenderSVGTSpan::renderName):
1949         * kcanvas/RenderSVGText.cpp:
1950         (WebCore::RenderSVGText::RenderSVGText):
1951         (WebCore::RenderSVGText::computeAbsoluteRepaintRect):
1952         (WebCore::RenderSVGText::layout):
1953         (WebCore::RenderSVGText::createInlineBox):
1954         (WebCore::RenderSVGText::nodeAtPoint):
1955         (WebCore::RenderSVGText::absoluteRects):
1956         (WebCore::RenderSVGText::paint):
1957         (WebCore::RenderSVGText::relativeBBox):
1958         * kcanvas/RenderSVGText.h:
1959         (WebCore::RenderSVGText::renderName):
1960         * kcanvas/SVGInlineFlowBox.cpp: Added.
1961         (WebCore::SVGInlineFlowBox::paint):
1962         (WebCore::SVGInlineFlowBox::placeBoxesHorizontally):
1963         (WebCore::SVGInlineFlowBox::verticallyAlignBoxes):
1964         (WebCore::paintSVGInlineFlow):
1965         (WebCore::translateBox):
1966         (WebCore::placePositionedBoxesHorizontally):
1967         (WebCore::placeSVGFlowHorizontally):
1968         (WebCore::placeBoxesVerticallyWithAbsBaseline):
1969         (WebCore::placeSVGFlowVertically):
1970         * kcanvas/SVGInlineFlowBox.h: Added.
1971         (WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
1972         * kcanvas/SVGRootInlineBox.cpp: Added.
1973         (WebCore::SVGRootInlineBox::paint):
1974         (WebCore::SVGRootInlineBox::placeBoxesHorizontally):
1975         (WebCore::SVGRootInlineBox::verticallyAlignBoxes):
1976         * kcanvas/SVGRootInlineBox.h: Added.
1977         (WebCore::SVGRootInlineBox::SVGRootInlineBox):
1978         * ksvg2/svg/SVGTRefElement.cpp:
1979         (SVGTRefElement::createRenderer):
1980         * ksvg2/svg/SVGTSpanElement.cpp:
1981         (SVGTSpanElement::createRenderer):
1982         * rendering/InlineFlowBox.h:
1983
1984 2006-10-10  Adam Roben  <aroben@apple.com>
1985
1986         Reviewed by Adele.
1987
1988         Improve popup menu behavior.
1989
1990         * html/HTMLSelectElement.cpp:
1991         (WebCore::HTMLSelectElement::HTMLSelectElement): Cache
1992         m_lastOnChangeIndex so we know when to fire onChange.
1993         (WebCore::HTMLSelectElement::setSelectedIndex): Added parameter to
1994         specify whether we should fire onChange.
1995         (WebCore::HTMLSelectElement::dispatchBlurEvent): Fire onChange on blur.
1996         (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Fire
1997         onChange when using the Enter key to change the selection.
1998         * html/HTMLSelectElement.h:
1999         * rendering/RenderMenuList.cpp:
2000         (WebCore::RenderMenuList::updateFromElement): Extract setText logic
2001         into its own method.
2002         (WebCore::RenderMenuList::setTextFromOption): New method.
2003         (WebCore::RenderMenuList::valueChanged): Let setSelectedIndex call
2004         onChange instead of calling it directly here.
2005         * rendering/RenderMenuList.h:
2006
2007 2006-10-10  Adele Peterson  <adele@apple.com>
2008
2009         Reviewed by Beth. 
2010
2011
2012         - Fix for <rdar://problem/4707489> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active <input type=text>
2013           and <rdar://problem/4707519> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active textarea
2014
2015         Moved autoscroll code to the Frame class
2016
2017         * bridge/mac/FrameMac.h: Moved _mouseDownMayStartDrag and _mouseDownMayStartAutoscroll flags to the frame.
2018         * bridge/mac/FrameMac.mm: Use new getters and setters for drag and autoscroll flags.  Moved autoscroll code to Frame::handleMouseMoveEvent.
2019         (WebCore::FrameMac::FrameMac):
2020         (WebCore::FrameMac::handleMousePressEvent):
2021         (WebCore::FrameMac::eventMayStartDrag):
2022         (WebCore::FrameMac::handleMouseMoveEvent):
2023         (WebCore::FrameMac::mouseDown):
2024
2025         * bridge/mac/WebCoreFrameBridge.h: Removed handleAutoscrollForMouseDragged, which called over the bridge for AppKit to do autoscroll for us.
2026         Now we scroll our views in WebCore.
2027
2028         * page/Frame.cpp:
2029         (WebCore::Frame::handleMousePressEvent): Initialize the mouseDownMayStartAutoscroll flag.
2030         (WebCore::Frame::handleMouseMoveEvent): Now kicks off autoscroll if appropriate.  Moved from FrameMac.
2031         (WebCore::Frame::updateSelectionForMouseDragOverPosition): Factored code out from handleMouseMoveEvent so we can update the selection from autoscroll too.
2032         (WebCore::Frame::mouseDownMayStartAutoscroll): Added.
2033         (WebCore::Frame::setMouseDownMayStartAutoscroll): Added.
2034         (WebCore::Frame::mouseDownMayStartDrag): Added.
2035         (WebCore::Frame::setMouseDownMayStartDrag): Added.
2036         (WebCore::Frame::autoscrollRenderer): Added
2037         (WebCore::Frame::setAutoscrollRenderer): Added.
2038         (WebCore::Frame::handleAutoscroll): Updated to use autoscrollRenderer getter and setter.
2039         (WebCore::Frame::autoscrollTimerFired): ditto.
2040         (WebCore::Frame::stopAutoscrollTimer): ditto. 
2041         * page/Frame.h: Made autoscrollRenderer and stopAutoscrollTimer public, so the renderer being autoscrolled can kill the timer when it dies.
2042
2043         * page/FramePrivate.h:
2044         (WebCore::FramePrivate::FramePrivate): Added mouseDownMayStartDrag and mouseDownMayStartAutoscroll flags.  Moved from FrameMac.
2045
2046         * page/FrameView.cpp: Store the current mouse position in window coordinates.  The callers can convert to their own coordinate space.
2047         (WebCore::FrameView::handleMousePressEvent):
2048         (WebCore::FrameView::handleMouseDoubleClickEvent):
2049         (WebCore::FrameView::handleMouseMoveEvent):
2050         (WebCore::FrameView::handleMouseReleaseEvent):
2051
2052         * rendering/RenderLayer.cpp:
2053         (WebCore::RenderLayer::autoscroll): Rewrote this to scroll recursively, and to scroll based on the mouse position (not the selection).  
2054          We also need to update the selection here, since autoscroll can occur without a mouseMove event, and the selection needs to get reset as we scroll.
2055
2056         * rendering/RenderListBox.cpp:
2057         (WebCore::RenderListBox::autoscroll): Convert the mouse coordinates to the right space.
2058
2059         * rendering/RenderObject.cpp:
2060         (WebCore::RenderObject::shouldAutoscroll): Also return true if the renderer is a root (so we know to autoscroll views too)
2061         (WebCore::RenderObject::destroy): If this renderer is being autoscrolled, stop the frame's autoscroll timer.
2062
2063 2006-10-10  Darin Adler  <darin@apple.com>
2064
2065         Rubber stamped by Maciej.
2066
2067         - convert many of the loader source files to Objective-C++ to prepare
2068           to convert some of them to C++
2069
2070         * WebCore.xcodeproj/project.pbxproj:
2071         * loader/mac/WebDataProtocol.m: Removed.
2072         * loader/mac/WebDocumentLoader.m: Removed.
2073         * loader/mac/WebFormState.m: Removed.
2074         * loader/mac/WebFrameLoader.m: Removed.
2075         * loader/mac/WebLoader.m: Removed.
2076         * loader/mac/WebMainResourceLoader.m: Removed.
2077         * loader/mac/WebNetscapePlugInStreamLoader.m: Removed.
2078         * loader/mac/WebPolicyDecider.m: Removed.
2079         * loader/mac/WebSubresourceLoader.m: Removed.
2080         * loader/mac/WebDataProtocol.mm: Added.
2081         * loader/mac/WebDocumentLoader.mm: Added.
2082         * loader/mac/WebFormState.mm: Added.
2083         * loader/mac/WebFrameLoader.mm: Added.
2084         * loader/mac/WebLoader.mm: Added.
2085         * loader/mac/WebMainResourceLoader.mm: Added.
2086         * loader/mac/WebNetscapePlugInStreamLoader.mm: Added.
2087         * loader/mac/WebPolicyDecider.mm: Added.
2088         * loader/mac/WebSubresourceLoader.mm: Added.
2089
2090 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
2091
2092         Reviewed by Mitz.
2093
2094         - fixed REGRESSION (r16960): crash on navigating to site
2095         http://www.zoominfo.com/Search/CompanyDetail.aspx?CompanyID=62948057&cs=QGDwILZIE
2096         
2097         * loader/mac/WebFrameLoader.m:
2098         (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
2099         Add back a mistakenly removed retain.
2100
2101 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
2102
2103         Not reviewed, build fix.
2104
2105         - fixed release build
2106
2107         * WebCore.xcodeproj/project.pbxproj:
2108
2109 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
2110
2111         Rubber stamped by Eric.
2112
2113         - moved a big honkin' pile of code over from WebKit; made minimal needed changes to compile
2114
2115         * WebCore.exp:
2116         * WebCore.xcodeproj/project.pbxproj:
2117         * loader/mac/LoaderNSURLExtras.m: Added.
2118         * loader/mac/WebDataProtocol.m: Added.
2119         * loader/mac/WebDocumentLoader.m: Added.
2120         * loader/mac/WebFormDataStream.m: Added.
2121         * loader/mac/WebFrameLoader.m: Added.
2122         * loader/mac/WebLoader.m: Added.
2123         (-[NSURLProtocol didReceiveResponse:]):
2124         (-[NSURLProtocol didReceiveData:lengthReceived:allAtOnce:]):
2125         * loader/mac/WebMainResourceLoader.m: Added.
2126         (-[WebMainResourceLoader didReceiveResponse:]):
2127         * loader/mac/WebPolicyDecider.m: Added.
2128         * loader/mac/WebSubresourceLoader.h: Added.
2129         * loader/mac/WebSubresourceLoader.m: Added.
2130
2131 2006-10-10  Maciej Stachowiak  <mjs@apple.com>
2132
2133         Reviewed by Oliver (sort of?)
2134
2135         - WebCore part of moving down NSURL extras
2136
2137         * WebCore.exp:
2138         * platform/mac/WebCoreSystemInterface.h:
2139         * platform/mac/WebCoreSystemInterface.mm:
2140
2141 2006-10-09  Rob Buis  <buis@kde.org>
2142
2143         Reviewed by Mitz.
2144
2145         http://bugs.webkit.org/show_bug.cgi?id=11217
2146         Cleanup svg coding style
2147
2148         Cleanup coding style in svg animation classes.
2149
2150         * ksvg2/svg/SVGAnimateColorElement.cpp:
2151         (WebCore::SVGAnimateColorElement::handleTimerEvent):
2152         * ksvg2/svg/SVGAnimateElement.cpp:
2153         (WebCore::SVGAnimateElement::SVGAnimateElement):
2154         (WebCore::SVGAnimateElement::handleTimerEvent):
2155         * ksvg2/svg/SVGAnimateTransformElement.cpp:
2156         (WebCore::SVGAnimateTransformElement::SVGAnimateTransformElement):
2157         (WebCore::SVGAnimateTransformElement::parseMappedAttribute):
2158         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
2159         (WebCore::SVGAnimateTransformElement::parseTransformValue):
2160         (WebCore::SVGAnimateTransformElement::calculateRotationFromMatrix):
2161         (WebCore::SVGAnimateTransformElement::initialMatrix):
2162         (WebCore::SVGAnimateTransformElement::transformMatrix):
2163         * ksvg2/svg/SVGAnimateTransformElement.h:
2164         * ksvg2/svg/SVGAnimatedPathData.cpp:
2165         * ksvg2/svg/SVGAnimatedPathData.h:
2166         * ksvg2/svg/SVGAnimatedPoints.cpp:
2167         * ksvg2/svg/SVGAnimatedPoints.h:
2168         * ksvg2/svg/SVGAnimationElement.cpp:
2169         (WebCore::SVGAnimationElement::targetElement):
2170
2171 2006-10-09  Maciej Stachowiak  <mjs@apple.com>
2172
2173         Reviewed by Oliver.
2174
2175         - added isMainFrame and frameLoader to WebCoreFrameBridge for ease of future code motion
2176
2177         * bridge/mac/WebCoreFrameBridge.h:
2178         * bridge/mac/WebCoreFrameBridge.mm:
2179         (-[WebCoreFrameBridge isMainFrame]):
2180
2181 2006-10-09  Adam Roben  <aroben@apple.com>
2182
2183         Backing out accidental commit.
2184
2185         * page/Frame.cpp:
2186         (WebCore::Frame::finishedParsing):
2187
2188 2006-10-09  Adam Roben  <aroben@apple.com>
2189
2190         Reviewed by Darin.
2191
2192         Add ASSERTs to RefPtr to make sure we don't ref within a destructor, as
2193         this could cause recursive calls to the destructor. RefPtr now also
2194         inherits from Noncopyable.
2195
2196         * dom/NodeFilter.h:
2197         * dom/Traversal.h:
2198         * page/DOMWindow.h:
2199         * page/Frame.cpp:
2200         (WebCore::Frame::finishedParsing):
2201         * page/Frame.h:
2202         * page/Plugin.h:
2203         * platform/FontFallbackList.h:
2204         * platform/Icon.h:
2205         * platform/Shared.h:
2206         (WebCore::Shared::Shared):
2207         (WebCore::Shared::ref):
2208         (WebCore::Shared::deref):
2209         (WebCore::Shared::hasOneRef):
2210         (WebCore::Shared::refCount):
2211         * platform/StringImpl.h:
2212
2213 2006-10-09  Oliver Hunt <ohunt@apple.com>
2214
2215         Reviewed by Anders.
2216
2217         Correcting ifdef's
2218
2219         * html/CanvasGradient.cpp:
2220         (WebCore::CanvasGradient::CanvasGradient):
2221         (WebCore::CanvasGradient::~CanvasGradient):
2222         (WebCore::CanvasGradient::addColorStop):
2223         * html/CanvasGradient.h:
2224         * html/CanvasPattern.cpp:
2225         (WebCore::CanvasPattern::CanvasPattern):
2226         (WebCore::CanvasPattern::~CanvasPattern):
2227         * html/CanvasPattern.h:
2228         * html/CanvasRenderingContext2D.cpp:
2229         (WebCore::CanvasRenderingContext2D::fill):
2230         (WebCore::CanvasRenderingContext2D::stroke):
2231         (WebCore::CanvasRenderingContext2D::fillRect):
2232         (WebCore::CanvasRenderingContext2D::setShadow):
2233         (WebCore::CanvasRenderingContext2D::applyShadow):
2234         (WebCore::CanvasRenderingContext2D::drawImage):
2235         (WebCore::CanvasRenderingContext2D::createPattern):
2236         (WebCore::CanvasRenderingContext2D::applyStrokePattern):
2237         (WebCore::CanvasRenderingContext2D::applyFillPattern):
2238         * html/CanvasRenderingContext2D.h:
2239         * html/CanvasStyle.cpp:
2240         (WebCore::CanvasStyle::applyStrokeColor):
2241         (WebCore::CanvasStyle::applyFillColor):
2242         * html/HTMLCanvasElement.cpp:
2243         (WebCore::HTMLCanvasElement::paint):
2244         (WebCore::HTMLCanvasElement::createDrawingContext):
2245         * html/HTMLCanvasElement.h:
2246
2247 2006-10-09  Adam Roben  <aroben@apple.com>
2248
2249         Reviewed by Maciej.
2250
2251         Fix a possible recursive destructor call.
2252
2253         * page/Frame.cpp:
2254         (WebCore::Frame::~Frame): Add a FIXME about cleaning up the destructor.
2255         (WebCore::Frame::finishedParsing): Don't create a protector RefPtr if
2256         we're already being destroyed.
2257
2258 2006-10-09  Sam Weinig  <sam.weinig@gmail.com>
2259
2260         Reviewed by Tim H.
2261
2262         Patch for http://bugs.webkit.org/show_bug.cgi?id=11234
2263         Assorted Objective-C bindings changes
2264
2265         - Auto-generate DOMSVGPathSegArcAbs, DOMSVGPathSegArcRel, DOMSVGPathSegClosePath, 
2266           DOMSVGPathSegCurvetoCubicAbs, DOMSVGPathSegCurvetoCubicRel, 
2267           DOMSVGPathSegCurvetoCubicSmoothAbs, DOMSVGPathSegCurvetoCubicSmoothRel, 
2268           DOMSVGPathSegCurvetoQuadraticAbs, DOMSVGPathSegCurvetoQuadraticRel, 
2269           DOMSVGPathSegCurvetoQuadraticSmoothAbs, DOMSVGPathSegCurvetoQuadraticSmoothRel, 
2270           DOMSVGPathSegLinetoAbs, DOMSVGPathSegLinetoHorizontalAbs, 
2271           DOMSVGPathSegLinetoHorizontalRel, DOMSVGPathSegLinetoRel, 
2272           DOMSVGPathSegLinetoVerticalAbs, DOMSVGPathSegLinetoVerticalRel, 
2273           DOMSVGPathSegMovetoAbs, DOMSVGPathSegMovetoRel and DOMSVGSVGElement.
2274
2275         - Auto-generate absoluteImageURL method for DOMHTMLInputElement and
2276           DOMHTMLObjectElement.
2277
2278         - Auto-generate the internal methods for classes with ivars (notably 
2279           DOMNodeIterator and DOMTreeWalker)
2280
2281         - Put more methods in the WebCore namespace and factor out the  
2282           displayString method into DOMInternal.h as done by Darin in his 
2283           patch for http://bugs.webkit.org/show_bug.cgi?id=11219.
2284
2285         * DerivedSources.make:
2286         * WebCore.xcodeproj/project.pbxproj:
2287         * bindings/objc/DOM.mm:
2288         (-[DOMNode _initWithNode:WebCore::]):
2289         (+[DOMNode _nodeWith:WebCore::]):
2290         (-[DOMNode addEventListener:listener:useCapture:]):
2291         (-[DOMNode removeEventListener:listener:useCapture:]):
2292         (-[DOMNode dispatchEvent:]):
2293         (-[DOMElement _imageTIFFRepresentation]):
2294         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
2295         (+[DOMNodeFilter _nodeFilterWith:WebCore::]):
2296         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
2297         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
2298         * bindings/objc/DOMCSS.mm:
2299         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
2300         (+[DOMStyleSheet _styleSheetWith:WebCore::]):
2301         (-[DOMCSSRule _initWithCSSRule:WebCore::]):
2302         (+[DOMCSSRule _CSSRuleWith:WebCore::]):
2303         (-[DOMCSSValue _initWithCSSValue:WebCore::]):
2304         (+[DOMCSSValue _CSSValueWith:WebCore::]):
2305         * bindings/objc/DOMEvents.mm:
2306         (-[DOMEvent _initWithEvent:WebCore::]):
2307         (+[DOMEvent _eventWith:WebCore::]):
2308         * bindings/objc/DOMExtensions.h:
2309         * bindings/objc/DOMHTML.mm:
2310         (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]):
2311         * bindings/objc/DOMInternal.h:
2312         (-[DOMNodeFilter WebCore::]):
2313         * bindings/objc/DOMInternal.mm:
2314         (-[WebScriptObject _init]):
2315         (-[WebScriptObject _initializeScriptDOMNodeImp]):
2316         (WebCore::displayString):
2317         * bindings/objc/DOMObject.mm:
2318         (-[DOMObject dealloc]):
2319         (-[DOMObject finalize]):
2320         * bindings/objc/DOMRGBColor.mm:
2321         (-[DOMRGBColor dealloc]):
2322         (-[DOMRGBColor finalize]):
2323         (-[DOMRGBColor color]):
2324         (-[DOMRGBColor _initWithRGB:WebCore::]):
2325         (+[DOMRGBColor _RGBColorWithRGB:WebCore::]):
2326         * bindings/objc/DOMSVG.h:
2327         * bindings/objc/DOMSVGPathSegInternal.h: Added.
2328         * bindings/objc/DOMSVGPathSegInternal.mm: Added.
2329         (-[DOMSVGPathSeg WebCore::]):
2330         (-[DOMSVGPathSeg _initWithSVGPathSeg:WebCore::]):
2331         (+[DOMSVGPathSeg _SVGPathSegWith:WebCore::]):
2332         * bindings/objc/DOMXPath.mm:
2333         (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
2334         (+[DOMNativeXPathNSResolver _xpathNSResolverWith:WebCore::]):
2335         * bindings/objc/PublicDOMInterfaces.h:
2336         * bindings/scripts/CodeGeneratorObjC.pm:
2337         * dom/NodeIterator.idl:
2338         * dom/TreeWalker.idl:
2339         * html/HTMLInputElement.idl:
2340         * html/HTMLObjectElement.idl:
2341         * ksvg2/svg/SVGDocument.idl:
2342         * ksvg2/svg/SVGElement.idl:
2343         * ksvg2/svg/SVGPathSeg.idl:
2344         * ksvg2/svg/SVGPathSegArcAbs.idl:
2345         * ksvg2/svg/SVGPathSegArcRel.idl:
2346         * ksvg2/svg/SVGPathSegClosePath.idl:
2347         * ksvg2/svg/SVGPathSegCurvetoCubicAbs.idl:
2348         * ksvg2/svg/SVGPathSegCurvetoCubicRel.idl:
2349         * ksvg2/svg/SVGPathSegCurvetoCubicSmoothAbs.idl:
2350         * ksvg2/svg/SVGPathSegCurvetoCubicSmoothRel.idl:
2351         * ksvg2/svg/SVGPathSegCurvetoQuadraticAbs.idl:
2352         * ksvg2/svg/SVGPathSegCurvetoQuadraticRel.idl:
2353         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl:
2354         * ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothRel.idl:
2355         * ksvg2/svg/SVGPathSegLinetoAbs.idl:
2356         * ksvg2/svg/SVGPathSegLinetoHorizontalAbs.idl:
2357         * ksvg2/svg/SVGPathSegLinetoHorizontalRel.idl:
2358         * ksvg2/svg/SVGPathSegLinetoRel.idl:
2359         * ksvg2/svg/SVGPathSegLinetoVerticalAbs.idl:
2360         * ksvg2/svg/SVGPathSegLinetoVerticalRel.idl:
2361         * ksvg2/svg/SVGPathSegMovetoAbs.idl:
2362         * ksvg2/svg/SVGPathSegMovetoRel.idl:
2363
2364 2006-10-09  Don Gibson  <dgibson77@gmail.com>
2365
2366         Unreviewed build fix.
2367
2368         Fix windows build bustage.
2369
2370         * platform/win/TemporaryLinkStubs.cpp:
2371
2372 2006-10-09  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
2373
2374         Reviewed by Geoff.
2375
2376         Fix memory leaks discovered via valgrind. Gdk build fixes.
2377
2378         * Projects/gdk/webcore-gdk.bkl:
2379         * make-generated-sources.sh:
2380         * platform/cairo/ImageCairo.cpp:
2381         (WebCore::Image::draw):
2382         * platform/gdk/FrameGdk.cpp:
2383         (WebCore::FrameGdk::handleGdkEvent):
2384         * platform/gdk/FrameGdk.h:
2385         * platform/gdk/PlatformScrollBar.h:
2386         (WebCore::PlatformScrollbar::horizontalScrollbarHeight):
2387         (WebCore::PlatformScrollbar::verticalScrollbarWidth):
2388
2389 2006-10-09  Nikolas Zimmermann  <zimmermann@kde.org>
2390
2391         Reviewed by Beth.
2392
2393         Fix LayoutTests/fast/css/case-transform.html with Qt - the last crashing layout test.
2394
2395         * platform/qt/GlyphMapQt.cpp: Handle UTF-16 characters properly
2396         (WebCore::GlyphMap::fillPage):
2397
2398 2006-10-09  Nikolas Zimmermann  <zimmermann@kde.org>
2399
2400         Unreviewed build fix.
2401
2402         Fix for Qt/Linux build, based on fixes to the Win32 build in r16928 and r16929.
2403
2404         * platform/qt/FrameQt.cpp:
2405         (WebCore::FrameQt::createJavaAppletWidget):
2406         * platform/qt/FrameQt.h:
2407         * platform/qt/TemporaryLinkStubs.cpp:
2408
2409 2006-10-09  Brady Eidson  <beidson@apple.com>
2410
2411         Reviewed by Maciej
2412
2413         Tiny changes to help reorganize WebFrameLoader code in WebKit
2414
2415         * bridge/mac/WebCoreIconDatabaseBridge.h: Added "createInstance"
2416         * bridge/mac/WebCoreIconDatabaseBridge.mm:
2417         (+[WebCoreIconDatabaseBridge sharedInstance]): Added, uses createInstance from WebKit side
2418
2419 2006-10-09  Adam Roben  <aroben@apple.com>
2420
2421         Reviewed by Adele.
2422
2423         Remove redundant call to Frame::cancelAndClear from ~Frame, since it's
2424         already called frome ~FrameMac.
2425
2426         * page/Frame.cpp:
2427         (WebCore::Frame::~Frame):
2428
2429 2006-10-09  Anders Carlsson  <acarlsson@apple.com>
2430
2431         * bridge/win/FrameWin.h:
2432         Add function declaration.
2433         
2434 2006-10-09  Anders Carlsson  <acarlsson@apple.com>
2435
2436         * platform/win/TemporaryLinkStubs.cpp:
2437         (FrameWin::createJavaAppletWidget):
2438         Try fixing the Win32 build.
2439
2440 2006-10-09  Anders Carlsson  <acarlsson@apple.com>
2441
2442         Reviewed by Adam.
2443
2444         Move applet widget creation to Frame and get rid of JavaAppletWidget.
2445         * WebCore.xcodeproj/project.pbxproj:
2446         * bridge/JavaAppletWidget.h: Removed.
2447         * bridge/mac/FrameMac.h:
2448         * bridge/mac/FrameMac.mm:
2449         (WebCore::FrameMac::createJavaAppletWidget):
2450         * bridge/mac/JavaAppletWidget.mm: Removed.
2451         * page/Frame.h:
2452         * rendering/RenderApplet.cpp:
2453         (WebCore::RenderApplet::createWidgetIfNecessary):
2454
2455 2006-10-09  Mitz Pettel  <mitz@webkit.org>
2456
2457         Reviewed by Darin.
2458
2459         - http://bugs.webkit.org/show_bug.cgi?id=11220
2460           Fix manual test for http://bugs.webkit.org/show_bug.cgi?id=8276
2461
2462         Subversion does not support resource forks and HFS metadata, so
2463         the resources for this test need to be on a disk image.
2464
2465         * manual-tests/plain-text-paste.html: Changed instructions to refer to the disk image.
2466         * manual-tests/resources/plain-text-paste.dmg: Added.
2467         * manual-tests/resources/plain-text-paste/._1.textClipping: Removed.
2468         * manual-tests/resources/plain-text-paste/._2.textClipping: Removed.
2469         * manual-tests/resources/plain-text-paste/._4.txt: Removed.
2470         * manual-tests/resources/plain-text-paste/._5.webloc: Removed.
2471         * manual-tests/resources/plain-text-paste/1.textClipping: Removed.
2472         * manual-tests/resources/plain-text-paste/2.textClipping: Removed.
2473         * manual-tests/resources/plain-text-paste/3.gif: Removed.
2474         * manual-tests/resources/plain-text-paste/4.txt: Removed.
2475         * manual-tests/resources/plain-text-paste/5.webloc: Removed.
2476
2477 2006-10-09  Rob Buis  <buis@kde.org>
2478
2479         Reviewed by Darin.
2480
2481         http://bugs.webkit.org/show_bug.cgi?id=11217
2482         Cleanup svg coding style
2483
2484         Cleanup coding style in filter classes.
2485
2486         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
2487         (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement):
2488         (WebCore::SVGComponentTransferFunctionElement::parseMappedAttribute):
2489         * ksvg2/svg/SVGComponentTransferFunctionElement.h:
2490         * ksvg2/svg/SVGFEBlendElement.cpp:
2491         (WebCore::SVGFEBlendElement::SVGFEBlendElement):
2492         (WebCore::SVGFEBlendElement::parseMappedAttribute):
2493         (WebCore::SVGFEBlendElement::filterEffect):
2494         * ksvg2/svg/SVGFEBlendElement.h:
2495         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
2496         (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement):
2497         (WebCore::SVGFEColorMatrixElement::parseMappedAttribute):
2498         (WebCore::SVGFEColorMatrixElement::filterEffect):
2499         * ksvg2/svg/SVGFEColorMatrixElement.h:
2500         * ksvg2/svg/SVGFECompositeElement.cpp:
2501         (WebCore::SVGFECompositeElement::parseMappedAttribute):
2502         * ksvg2/svg/SVGFECompositeElement.h:
2503         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
2504         (WebCore::SVGFEDisplacementMapElement::stringToChannel):
2505         * ksvg2/svg/SVGFEDisplacementMapElement.h:
2506         * ksvg2/svg/SVGFEFloodElement.cpp:
2507         (WebCore::SVGFEFloodElement::filterEffect):
2508         * ksvg2/svg/SVGFEFuncAElement.cpp:
2509         (WebCore::SVGFEFuncAElement::SVGFEFuncAElement):
2510         * ksvg2/svg/SVGFEFuncBElement.cpp:
2511         (WebCore::SVGFEFuncBElement::SVGFEFuncBElement):
2512         * ksvg2/svg/SVGFEFuncGElement.cpp:
2513         (WebCore::SVGFEFuncGElement::SVGFEFuncGElement):
2514         * ksvg2/svg/SVGFEFuncRElement.cpp:
2515         (WebCore::SVGFEFuncRElement::SVGFEFuncRElement):
2516         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
2517         (WebCore::SVGFEGaussianBlurElement::SVGFEGaussianBlurElement):
2518         (WebCore::SVGFEGaussianBlurElement::parseMappedAttribute):
2519         (WebCore::SVGFEGaussianBlurElement::filterEffect):
2520         * ksvg2/svg/SVGFEGaussianBlurElement.h:
2521         * ksvg2/svg/SVGFELightElement.cpp:
2522         (WebCore::SVGFELightElement::SVGFELightElement):
2523         (WebCore::SVGFELightElement::parseMappedAttribute):
2524         * ksvg2/svg/SVGFELightElement.h:
2525         * ksvg2/svg/SVGFEMergeElement.cpp:
2526         (WebCore::SVGFEMergeElement::SVGFEMergeElement):
2527
2528 2006-10-09  Rob Buis  <buis@kde.org>
2529
2530         Reviewed by olliej.
2531
2532         http://bugs.webkit.org/show_bug.cgi?id=11217
2533         Cleanup svg coding style
2534
2535         Cleanup coding style in SVGPath* classes.
2536
2537         * ksvg2/svg/SVGPathElement.cpp:
2538         (WebCore::SVGPathElement::SVGPathElement):
2539         (WebCore::SVGPathElement::getPointAtLength):
2540         (WebCore::SVGPathElement::createSVGPathSegClosePath):
2541         (WebCore::SVGPathElement::createSVGPathSegMovetoAbs):
2542         (WebCore::SVGPathElement::createSVGPathSegMovetoRel):
2543         (WebCore::SVGPathElement::createSVGPathSegLinetoAbs):
2544         (WebCore::SVGPathElement::createSVGPathSegLinetoRel):
2545         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs):
2546         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel):
2547         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs):
2548         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel):
2549         (WebCore::SVGPathElement::createSVGPathSegArcAbs):
2550         (WebCore::SVGPathElement::createSVGPathSegArcRel):
2551         (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs):
2552         (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel):
2553         (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs):
2554         (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel):
2555         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs):
2556         (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel):
2557         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs):
2558         (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel):
2559         (WebCore::SVGPathElement::svgMoveTo):
2560         (WebCore::SVGPathElement::svgLineTo):
2561         (WebCore::SVGPathElement::svgLineToHorizontal):
2562         (WebCore::SVGPathElement::svgLineToVertical):
2563         (WebCore::SVGPathElement::svgCurveToCubic):
2564         (WebCore::SVGPathElement::svgCurveToCubicSmooth):
2565         (WebCore::SVGPathElement::svgCurveToQuadratic):
2566         (WebCore::SVGPathElement::svgCurveToQuadraticSmooth):
2567         (WebCore::SVGPathElement::svgArcTo):
2568         (WebCore::SVGPathElement::parseMappedAttribute):
2569         (WebCore::SVGPathElement::pathSegList):
2570         (WebCore::SVGPathElement::normalizedPathSegList):
2571         (WebCore::SVGPathElement::animatedPathSegList):
2572         (WebCore::SVGPathElement::animatedNormalizedPathSegList):
2573         (WebCore::SVGPathElement::toPathData):
2574         * ksvg2/svg/SVGPathElement.h:
2575         (WebCore::SVGPathElement::rendererIsNeeded):
2576         * ksvg2/svg/SVGPathSeg.h:
2577         * ksvg2/svg/SVGPathSegArc.cpp:
2578
2579 2006-10-09  Rob Buis  <buis@kde.org>
2580
2581         Reviewed by aroben.
2582
2583         http://bugs.webkit.org/show_bug.cgi?id=11217
2584         Cleanup svg coding style
2585
2586         Cleanup coding style in svg shape classes.
2587
2588         * ksvg2/svg/SVGCircleElement.cpp:
2589         (WebCore::SVGCircleElement::SVGCircleElement):
2590         (WebCore::SVGCircleElement::parseMappedAttribute):
2591         (WebCore::SVGCircleElement::pushAttributeContext):
2592         * ksvg2/svg/SVGCircleElement.h:
2593         (WebCore::SVGCircleElement::rendererIsNeeded):
2594         * ksvg2/svg/SVGEllipseElement.cpp:
2595         * ksvg2/svg/SVGEllipseElement.h:
2596         (WebCore::SVGEllipseElement::rendererIsNeeded):
2597         * ksvg2/svg/SVGLineElement.cpp:
2598         (WebCore::SVGLineElement::parseMappedAttribute):
2599         (WebCore::SVGLineElement::pushAttributeContext):
2600         * ksvg2/svg/SVGLineElement.h:
2601         (WebCore::SVGLineElement::rendererIsNeeded):
2602         * ksvg2/svg/SVGPolyElement.cpp:
2603         (WebCore::SVGPolyElement::SVGPolyElement):
2604         (WebCore::SVGPolyElement::points):
2605         (WebCore::SVGPolyElement::animatedPoints):
2606         (WebCore::SVGPolyElement::parseMappedAttribute):
2607         (WebCore::SVGPolyElement::notifyAttributeChange):
2608         * ksvg2/svg/SVGPolyElement.h:
2609         (WebCore::SVGPolyElement::rendererIsNeeded):
2610         * ksvg2/svg/SVGPolygonElement.cpp:
2611         (WebCore::SVGPolygonElement::SVGPolygonElement):
2612         (WebCore::SVGPolygonElement::toPathData):
2613         * ksvg2/svg/SVGPolygonElement.h:
2614         * ksvg2/svg/SVGPolylineElement.cpp:
2615         (WebCore::SVGPolylineElement::SVGPolylineElement):
2616         (WebCore::SVGPolylineElement::toPathData):
2617         * ksvg2/svg/SVGPolylineElement.h:
2618         * ksvg2/svg/SVGRectElement.cpp:
2619         (WebCore::SVGRectElement::parseMappedAttribute):
2620         (WebCore::SVGRectElement::pushAttributeContext):
2621         * ksvg2/svg/SVGRectElement.h:
2622         (WebCore::SVGRectElement::rendererIsNeeded):
2623
2624 2006-10-08  Darin Adler  <darin@apple.com>
2625
2626         Reviewed by Maciej.
2627
2628         - added a bit more WebCoreSystemInterface
2629
2630             wkGetNSURLResponseCalculatedExpiration
2631             wkGetNSURLResponseLastModifiedDate
2632             wkGetNSURLResponseMustRevalidate
2633
2634         * WebCore.exp: Added the new symbols.
2635         * platform/mac/WebCoreSystemInterface.h: Ditto.
2636         * platform/mac/WebCoreSystemInterface.mm: Ditto.
2637
2638         - quiet down the code generation script
2639
2640         * bindings/scripts/CodeGenerator.pm:
2641
2642 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
2643
2644         Reviewed by Darin.
2645
2646         - more code laundering - add wkSupportsMultipartXMixedReplace
2647
2648         * WebCore.exp:
2649         * platform/mac/WebCoreSystemInterface.h:
2650         * platform/mac/WebCoreSystemInterface.mm:
2651
2652 2006-10-08  Nikolas Zimmermann  <zimmermann@kde.org>
2653
2654         Reviewed by Darin and Oliver.
2655
2656         Fix artefacts when drawing polygons, most noticeable when painting <hr> elements.
2657
2658         * platform/qt/GraphicsContextQt.cpp: Fix wrong operator<< usage.
2659         (WebCore::GraphicsContext::drawConvexPolygon):
2660
2661 2006-10-08  Anders Carlsson  <acarlsson@apple.com>
2662
2663         Reviewed by Darin.
2664
2665         * page/Frame.cpp:
2666         (WebCore::Frame::submitForm):
2667         No need to use latin1() here.
2668
2669 2006-10-08  Nikolas Zimmermann  <zimmermann@kde.org>
2670
2671         Reviewed by Darin.
2672
2673         Kill warnings when generating IDL files on Qt/Linux, as the
2674         SOURCE_ROOT environment variable is not defined (and not needed) for us.
2675
2676         * bindings/scripts/CodeGenerator.pm:
2677
2678 2006-10-08  Maciej Stachowiak  <mjs@apple.com>
2679
2680         Reviewed by Darin.
2681
2682         - split didNotOpenURL: into general and page-cache-specific parts
2683
2684         * bridge/mac/WebCoreFrameBridge.h:
2685         * bridge/mac/WebCoreFrameBridge.mm:
2686         (-[WebCoreFrameBridge didNotOpenURL:]):
2687         (-[WebCoreFrameBridge invalidatePageCache:]):
2688
2689 2006-10-08  Anders Carlsson  <acarlsson@apple.com>
2690
2691         Reviewed by Darin.
2692
2693         * loader/loader.cpp:
2694         Remove DeprecatedStringList.h include.
2695         
2696         * page/Frame.cpp:
2697         (WebCore::Frame::submitForm):
2698         Don't remove "attach" from mailto URLs, we don't do it anywhere else.
2699
2700 2006-10-08  Sam Weinig  <sam.weinig@gmail.com>
2701
2702         Reviewed by Darin.
2703
2704         Patch for http://bugs.webkit.org/show_bug.cgi?id=11215
2705         Yet another round of Objective-C SVG DOM bindings auto-generation
2706
2707         - Auto-generate DOMSVGPatternElement, DOMSVGPointList, DOMSVGPolygonElement, 
2708           DOMSVGPolylineElement, DOMSVGRadialGradientElement, DOMSVGRenderingIntent,
2709           DOMSVGScriptElement, DOMSVGSetElement, DOMSVGStopElement, DOMSVGSwitchElement, 
2710           DOMSVGSymbolElement, DOMSVGTRefElement, DOMSVGTSpanElement, 
2711           DOMSVGTextContentElement, DOMSVGTextElement, DOMSVGTextPositioningElement, 
2712           DOMSVGTitleElement, DOMSVGUnitTypes, DOMSVGUseElement, DOMSVGViewElement, 
2713           DOMSVGZoomAndPan and DOMSVGZoomEvent.
2714
2715         - Auto-generate the implementations of DOMHTMLAppletElement and DOMHTMLEmbedElement
2716           using the new [ConvertFromString] property.
2717
2718         - Add forward declarations for NS* types to auto-generated classes.
2719
2720         * DerivedSources.make:
2721         * WebCore.xcodeproj/project.pbxproj:
2722         * bindings/objc/DOMHTMLAppletElement.mm: Removed.
2723         * bindings/objc/DOMHTMLEmbedElement.mm: Removed.
2724         * bindings/objc/DOMInternal.h:
2725         * bindings/objc/DOMSVG.h:
2726         * bindings/scripts/CodeGeneratorObjC.pm:
2727         * html/HTMLAppletElement.idl:
2728         * html/HTMLEmbedElement.idl:
2729         * ksvg2/svg/SVGPatternElement.idl:
2730         * ksvg2/svg/SVGPolygonElement.idl:
2731         * ksvg2/svg/SVGPolylineElement.idl:
2732         * ksvg2/svg/SVGRadialGradientElement.idl:
2733         * ksvg2/svg/SVGRenderingIntent.idl:
2734         * ksvg2/svg/SVGScriptElement.idl:
2735         * ksvg2/svg/SVGSetElement.idl:
2736         * ksvg2/svg/SVGStopElement.idl:
2737         * ksvg2/svg/SVGSwitchElement.idl:
2738         * ksvg2/svg/SVGSymbolElement.idl:
2739         * ksvg2/svg/SVGTRefElement.idl:
2740         * ksvg2/svg/SVGTSpanElement.idl:
2741         * ksvg2/svg/SVGTextContentElement.idl:
2742         * ksvg2/svg/SVGTextElement.idl:
2743         * ksvg2/svg/SVGTextPositioningElement.idl:
2744         * ksvg2/svg/SVGTitleElement.idl:
2745         * ksvg2/svg/SVGUseElement.idl:
2746         * ksvg2/svg/SVGViewElement.idl:
2747         * ksvg2/svg/SVGZoomEvent.idl:
2748
2749 2006-10-07  Anders Carlsson  <acarlsson@apple.com>
2750
2751         Reviewed by Maciej.
2752
2753         Remove crossDomain, it was unused and is one of the last functions that use DeprecatedStringList.        
2754         * loader/loader.cpp:
2755         (WebCore::Loader::servePendingRequests):
2756         
2757 2006-10-07  Anders Carlsson  <acarlsson@apple.com>
2758
2759         Reviewed by Darin.
2760
2761         Convert a bunch of RefPtr<StringImpl> to String.
2762         
2763         * bridge/mac/FrameMac.h:
2764         * bridge/mac/FrameMac.mm:
2765         (WebCore::FrameMac::didTellBridgeAboutLoad):
2766         (WebCore::FrameMac::haveToldBridgeAboutLoad):
2767         * dom/BeforeUnloadEvent.cpp:
2768         (WebCore::BeforeUnloadEvent::storeResult):
2769         * dom/BeforeUnloadEvent.h:
2770         (WebCore::BeforeUnloadEvent::result):
2771         * dom/Document.cpp:
2772         (WebCore::Document::createEntityReference):
2773         * dom/Entity.cpp:
2774         (WebCore::Entity::Entity):
2775         (WebCore::Entity::nodeName):
2776         (WebCore::Entity::toString):
2777         * dom/Entity.h:
2778         (WebCore::Entity::publicId):
2779         (WebCore::Entity::systemId):
2780         (WebCore::Entity::notationName):
2781         * dom/EntityReference.cpp:
2782         (WebCore::EntityReference::EntityReference):
2783         (WebCore::EntityReference::nodeName):
2784         (WebCore::EntityReference::cloneNode):
2785         (WebCore::EntityReference::toString):
2786         * dom/EntityReference.h:
2787         * dom/KeyboardEvent.cpp:
2788         (WebCore::KeyboardEvent::KeyboardEvent):
2789         (WebCore::KeyboardEvent::initKeyboardEvent):
2790         * dom/KeyboardEvent.h:
2791         (WebCore::KeyboardEvent::keyIdentifier):
2792         * dom/MutationEvent.cpp:
2793         (WebCore::MutationEvent::MutationEvent):
2794         (WebCore::MutationEvent::initMutationEvent):
2795         * dom/MutationEvent.h:
2796         (WebCore::MutationEvent::prevValue):
2797         (WebCore::MutationEvent::newValue):
2798         (WebCore::MutationEvent::attrName):
2799         * dom/Notation.cpp:
2800         (WebCore::Notation::Notation):
2801         (WebCore::Notation::nodeName):
2802         * dom/Notation.h:
2803         (WebCore::Notation::publicId):
2804         (WebCore::Notation::systemId):
2805         * dom/ProcessingInstruction.cpp:
2806         (WebCore::ProcessingInstruction::ProcessingInstruction):
2807         (WebCore::ProcessingInstruction::setData):
2808         (WebCore::ProcessingInstruction::nodeName):
2809         (WebCore::ProcessingInstruction::nodeValue):
2810         (WebCore::ProcessingInstruction::cloneNode):
2811         (WebCore::ProcessingInstruction::checkStyleSheet):
2812         (WebCore::ProcessingInstruction::toString):
2813         * dom/ProcessingInstruction.h:
2814         (WebCore::ProcessingInstruction::target):
2815         (WebCore::ProcessingInstruction::data):
2816         (WebCore::ProcessingInstruction::localHref):
2817
2818 2006-10-07  Sam Weinig  <sam.weinig@gmail.com>
2819
2820         Reviewed by Tim H.
2821
2822         Patch for http://bugs.webkit.org/show_bug.cgi?id=11206
2823         10 more SVG Objective-C auto-generated bindings
2824
2825         - Auto-generate DOMSVGFilterElement, DOMSVGFitToViewBox, 
2826           DOMSVGForeignObjectElement, DOMSVGGElement, DOMSVGGradientElement,
2827           DOMSVGImageElement, DOMSVGLineElement, DOMSVGLinearGradientElement, 
2828           DOMSVGMarkerElement, DOMSVGMaskElement and DOMSVGPaint.
2829
2830         - Auto-generate the text method for DOMRange.
2831
2832         * DerivedSources.make:
2833         * WebCore.xcodeproj/project.pbxproj:
2834         * bindings/objc/DOM.mm:
2835         * bindings/objc/DOMExtensions.h:
2836         * bindings/objc/DOMInternal.h:
2837         * bindings/objc/DOMPrivate.h:
2838         * bindings/objc/DOMRGBColor.mm:
2839         * bindings/objc/DOMSVG.h:
2840         * bindings/objc/PublicDOMInterfaces.h:
2841         * bindings/scripts/CodeGeneratorObjC.pm:
2842         * dom/Range.idl:
2843         * ksvg2/svg/SVGFilterElement.cpp:
2844         * ksvg2/svg/SVGFilterElement.h:
2845         * ksvg2/svg/SVGFilterElement.idl:
2846         * ksvg2/svg/SVGForeignObjectElement.idl:
2847         * ksvg2/svg/SVGGElement.idl:
2848         * ksvg2/svg/SVGGradientElement.idl:
2849         * ksvg2/svg/SVGImageElement.idl:
2850         * ksvg2/svg/SVGLineElement.idl:
2851         * ksvg2/svg/SVGLinearGradientElement.idl:
2852         * ksvg2/svg/SVGMarkerElement.idl:
2853         * ksvg2/svg/SVGMaskElement.idl:
2854         * ksvg2/svg/SVGPaint.idl:
2855
2856 2006-10-07  Sam Weinig  <sam.weinig@gmail.com>
2857
2858         Reviewed by Tim H.
2859
2860         Patch for http://bugs.webkit.org/show_bug.cgi?id=11198
2861         Auto-generate a few more Objective-C DOM interfaces
2862
2863         - Fully auto-generate DOMAbstractView and DOMRange.
2864
2865         - Auto-generate just the interface for DOMRGBColor.
2866
2867         - Add DOMRanges.h as the new top level file for Ranges
2868           module.
2869
2870         - Add DOMRanges.h and DOMXPath.h to DOM.mm
2871
2872         * DerivedSources.make:
2873         * WebCore.xcodeproj/project.pbxproj:
2874         * bindings/objc/DOM.h:
2875         * bindings/objc/DOM.mm:
2876         * bindings/objc/DOMAbstractView.h: Removed.
2877         * bindings/objc/DOMAbstractView.mm: Removed.
2878         * bindings/objc/DOMInternal.h:
2879         * bindings/objc/DOMPrivate.h:
2880         * bindings/objc/DOMRGBColor.h: Removed.
2881         * bindings/objc/DOMRGBColor.mm:
2882         * bindings/objc/DOMRange.h: Removed.
2883         * bindings/objc/DOMRanges.h: Added.
2884         * bindings/objc/PublicDOMInterfaces.h:
2885         * bindings/scripts/CodeGeneratorObjC.pm:
2886         * css/RGBColor.idl:
2887         * dom/Range.idl:
2888         * page/AbstractView.idl: Added.
2889
2890 2006-10-07  Andrew Wellington  <proton@wiretapped.net>
2891
2892         Reviewed by Eric.
2893
2894         Bug 10837: REGRESSION: Yahoo New Charts Crashes WebKit
2895         http://bugzilla.opendarwin.org/show_bug.cgi?id=10837
2896
2897         Return null when there is no frame. This matches Firefox.
2898
2899         * bindings/js/kjs_html.cpp:
2900         (KJS::JSHTMLDocument::getValueProperty):
2901
2902 2006-10-07  David Hyatt  <hyatt@apple.com>
2903
2904         Implement scroll corner painting (a white rect fill) for overflow areas to cover up
2905         scrollbar joins properly.
2906
2907         Refactor painting of scrollbars and resizers into common functions.  Eliminate the
2908         extra 20 bytes per RenderLayer by cutting out m_resizerImage and m_resizerControlRect.
2909
2910         Reviewed by mitz
2911
2912         * page/FrameView.cpp:
2913         (WebCore::selectCursor):
2914         (WebCore::FrameView::handleMouseMoveEvent):
2915         * platform/mac/PlatformScrollBar.h:
2916         (WebCore::PlatformScrollbar::horizontalScrollbarHeight):
2917         (WebCore::PlatformScrollbar::verticalScrollbarWidth):
2918         * rendering/RenderLayer.cpp:
2919         (WebCore::RenderLayer::RenderLayer):
2920         (WebCore::RenderLayer::~RenderLayer):
2921         (WebCore::RenderLayer::updateLayerPositions):
2922         (WebCore::scrollCornerRect):
2923         (WebCore::RenderLayer::positionOverflowControls):
2924         (WebCore::RenderLayer::paintOverflowControls):
2925         (WebCore::RenderLayer::isPointInResizeControl):
2926         (WebCore::RenderLayer::paintLayer):
2927         * rendering/RenderLayer.h:
2928
2929 2006-10-07  Mark Rowe  <bdash@webkit.org>
2930
2931         Reviewed by Mitz.
2932
2933         Linux/Gdk build fixes, primarily consisting of s/ScrollBar/Scrollbar/ and
2934         matching recent ResourceLoader changes.
2935
2936         * platform/gdk/FrameGdk.cpp:
2937         (WebCore::FrameGdk::openURL):
2938         (WebCore::FrameGdk::urlSelected):
2939         * platform/gdk/PlatformScrollBar.h:
2940         * platform/gdk/ResourceLoaderCurl.cpp:
2941         (WebCore::ResourceLoader::start):
2942         * platform/gdk/ScrollViewGdk.cpp:
2943         (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
2944         (WebCore::ScrollView::resizeContents):
2945         (WebCore::ScrollView::scrollBy):
2946         (WebCore::ScrollView::hScrollbarMode):
2947         (WebCore::ScrollView::vScrollbarMode):
2948         (WebCore::ScrollView::suppressScrollbars):
2949         (WebCore::ScrollView::setHScrollbarMode):
2950         (WebCore::ScrollView::setVScrollbarMode):
2951         (WebCore::ScrollView::setScrollbarsMode):
2952         * platform/gdk/TemporaryLinkStubs.cpp:
2953         (FrameView::passMousePressEventToScrollbar):
2954         (Widget::removeFromParent):
2955         (ScrollView::addChild):
2956         (ScrollView::updateScrollbars):
2957         (ScrollView::scrollbarUnderMouse):
2958         (PlatformScrollbar::PlatformScrollbar):
2959         (PlatformScrollbar::~PlatformScrollbar):
2960         (PlatformScrollbar::width):
2961         (PlatformScrollbar::height):
2962         (PlatformScrollbar::setEnabled):
2963         (PlatformScrollbar::paint):
2964         (PlatformScrollbar::updateThumbPosition):
2965         (PlatformScrollbar::updateThumbProportion):
2966         (PlatformScrollbar::setRect):
2967         (Scrollbar::Scrollbar):
2968         (Scrollbar::setSteps):
2969         (Scrollbar::scroll):
2970         (Scrollbar::setValue):
2971         (Scrollbar::setProportion):
2972
2973 2006-10-06  Dave Hyatt  <hyatt@apple.com>
2974
2975         Implement a new method for obtaining accurate clip rectangles that can be used by plugins to properly clip.
2976
2977         * page/FrameView.cpp:
2978         (WebCore::FrameView::windowClipRect):
2979         * page/FrameView.h:
2980         * platform/ScrollView.h:
2981         * platform/Widget.cpp:
2982         (WebCore::Widget::windowClipRect):
2983         * platform/Widget.h:
2984         (WebCore::Widget::geometryChanged):
2985         (WebCore::Widget::handleMouseMoveEvent):
2986         (WebCore::Widget::handleMouseReleaseEvent):
2987         * platform/mac/ScrollViewMac.mm:
2988         (WebCore::ScrollView::addChild):
2989         * rendering/RenderLayer.cpp:
2990         (WebCore::RenderLayer::documentClipRect):
2991         * rendering/RenderLayer.h:
2992
2993 2006-10-06  Steve Falkenburg  <sfalken@apple.com>
2994
2995         Reviewed by Adam.
2996
2997         Add another method we'll need for scrollbar dodging
2998
2999         * platform/ScrollView.h:
3000         * platform/win/TemporaryLinkStubs.cpp:
3001         (ScrollView::resizerOverlapsContent):
3002
3003 2006-10-06  Sam Weinig  <sam.weinig@gmail.com>
3004
3005         Reviewed by Tim H.
3006
3007         Patch for http://bugs.webkit.org/show_bug.cgi?id=11191
3008         Auto-generate the interfaces even for Objective-C DOM 
3009         bindings that need custom implementations
3010
3011         - Fully auto-generate DOMEventTarget, DOMNodeFilter and 
3012           DOMHTMLOptionElement.
3013
3014         - Auto-generate just the interface for DOMHTMLAppletElement,
3015           DOMHTMLEmbedElement, DOMSVGNumber, DOMSVGPoint and DOMSVGRect
3016           using the new IDL property ObjCCustomImplementation.
3017
3018         * DerivedSources.make:
3019         * WebCore.xcodeproj/project.pbxproj:
3020         * bindings/objc/DOMEventTarget.h: Removed.
3021         * bindings/objc/DOMHTMLAppletElement.h: Removed.
3022         * bindings/objc/DOMHTMLEmbedElement.h: Removed.
3023         * bindings/objc/DOMHTMLOptionElement.h: Removed.
3024         * bindings/objc/DOMHTMLOptionElement.mm: Removed.
3025         * bindings/objc/DOMInternal.h:
3026         * bindings/objc/DOMNodeFilter.h: Removed.
3027         * bindings/objc/DOMSVGNumber.h: Removed.
3028         * bindings/objc/DOMSVGPoint.h: Removed.
3029         * bindings/objc/DOMSVGPoint.mm:
3030         (-[DOMSVGPoint matrixTransform:]):
3031         * bindings/objc/DOMSVGRect.h: Removed.
3032         * bindings/objc/PublicDOMInterfaces.h:
3033         * bindings/scripts/CodeGeneratorObjC.pm:
3034         * dom/EventTarget.idl:
3035         * html/HTMLAppletElement.idl:
3036         * html/HTMLEmbedElement.idl:
3037         * html/HTMLOptionElement.idl:
3038         * ksvg2/svg/SVGNumber.idl:
3039         * ksvg2/svg/SVGPoint.idl:
3040         * ksvg2/svg/SVGRect.idl:
3041
3042 2006-10-06  Nikolas Zimmermann  <zimmermann@kde.org>
3043
3044         Reviewed by Tim H.
3045
3046         Make Qt/Linux compile again completly.
3047
3048         * platform/qt/WidgetQt.cpp:
3049         (WebCore::Widget::removeFromParent):
3050
3051 2006-10-06  Nikolas Zimmermann  <zimmermann@kde.org>
3052
3053         Reviewed by Tim H.
3054
3055         Fix Qt/Linux build by adapting the s/ScrollBar/Scrollbar/ patch.
3056
3057         * platform/qt/PlatformScrollBar.h:
3058         * platform/qt/ScrollViewQt.cpp:
3059         (WebCore::ScrollView::hScrollbarMode):
3060         (WebCore::ScrollView::vScrollbarMode):
3061         (WebCore::ScrollView::suppressScrollbars):
3062         (WebCore::ScrollView::setHScrollbarMode):
3063         (WebCore::ScrollView::setVScrollbarMode):
3064         (WebCore::ScrollView::setScrollbarsMode):
3065         (WebCore::ScrollView::scrollbarUnderMouse):
3066         * platform/qt/TemporaryLinkStubs.cpp:
3067         (WebCore::Scrollbar::Scrollbar):
3068         (WebCore::Scrollbar::setSteps):
3069         (WebCore::Scrollbar::scroll):
3070         (WebCore::Scrollbar::setValue):
3071         (WebCore::Scrollbar::setProportion):
3072         (WebCore::PlatformScrollbar::PlatformScrollbar):
3073         (WebCore::PlatformScrollbar::~PlatformScrollbar):
3074         (WebCore::PlatformScrollbar::width):
3075         (WebCore::PlatformScrollbar::height):
3076         (WebCore::PlatformScrollbar::setEnabled):
3077         (WebCore::PlatformScrollbar::paint):
3078         (WebCore::PlatformScrollbar::updateThumbPosition):
3079         (WebCore::PlatformScrollbar::updateThumbProportion):
3080         (WebCore::PlatformScrollbar::setRect):
3081         (FrameView::passMousePressEventToScrollbar):
3082
3083 2006-10-06  Sam Weinig  <sam.weinig@gmail.com>
3084
3085         Reviewed by Tim H.
3086
3087         Patch for http://bugs.webkit.org/show_bug.cgi?id=11177
3088         Another round of Objective-C SVG DOM bindings auto-generation
3089
3090         - Auto-generate DOMSVGAnimatedNumberList, DOMSVGAnimatedRect, 
3091           DOMSVGComponentTransferFunctionElement, DOMSVGFEBlendElement, 
3092           DOMSVGFEColorMatrixElement, DOMSVGFEComponentTransferElement, 
3093           DOMSVGFECompositeElement, DOMSVGFEDiffuseLightingElement,
3094           DOMSVGFEDisplacementMapElement, DOMSVGFEDistantLightElement, 
3095           DOMSVGFEFloodElement, DOMSVGFEFuncAElement, DOMSVGFEFuncBElement, 
3096           DOMSVGFEFuncGElement, DOMSVGFEFuncRElement, DOMSVGFEGaussianBlurElement, 
3097           DOMSVGFEImageElement, DOMSVGFEMergeElement, DOMSVGFEMergeNodeElement, 
3098           DOMSVGFEOffsetElement, DOMSVGFEPointLightElement, 
3099           DOMSVGFESpecularLightingElement, DOMSVGFESpotLightElement, 
3100           DOMSVGFETileElement, DOMSVGFETurbulenceElement, 
3101           DOMSVGFilterPrimitiveStandardAttributes and DOMSVGNumberList. 
3102
3103         - Adds interfaces and implementation stubs for DOMSVGNumber, DOMSVGPoint
3104           and DOMSVGRect.
3105
3106         - IDL clean up.
3107
3108         - Make numOctaves in SVGFETurbulenceElement use a long instead of an int
3109           in it's macro declaration and definition.
3110
3111         * DerivedSources.make:
3112         * WebCore.xcodeproj/project.pbxproj:
3113         * bindings/objc/DOMCSS.mm:
3114         (+[DOMCSSValue _CSSValueWith:WebCore::]):
3115         * bindings/objc/DOMInternal.h:
3116         * bindings/objc/DOMSVG.h:
3117         * bindings/objc/DOMSVGNumber.h: Added.
3118         * bindings/objc/DOMSVGNumber.mm: Added.
3119         (-[DOMSVGNumber dealloc]):
3120         (-[DOMSVGNumber finalize]):
3121         (-[DOMSVGNumber value]):
3122         (-[DOMSVGNumber setValue:]):
3123         (-[DOMSVGNumber _SVGNumber]):
3124         (-[DOMSVGNumber _initWithFloat:]):
3125         (+[DOMSVGNumber _SVGNumberWith:]):
3126         * bindings/objc/DOMSVGPoint.h: Added.
3127         * bindings/objc/DOMSVGPoint.mm: Added.
3128         (-[DOMSVGPoint dealloc]):
3129         (-[DOMSVGPoint finalize]):
3130         (-[DOMSVGPoint x]):
3131         (-[DOMSVGPoint setX:]):
3132         (-[DOMSVGPoint y]):
3133         (-[DOMSVGPoint setY:]):
3134         (-[DOMSVGPoint WebCore::]):
3135         (-[DOMSVGPoint _initWithFloatPoint:WebCore::]):
3136         (+[DOMSVGPoint _SVGPointWith:WebCore::]):
3137         * bindings/objc/DOMSVGRect.h: Added.
3138         * bindings/objc/DOMSVGRect.mm: Added.
3139         (-[DOMSVGRect dealloc]):
3140         (-[DOMSVGRect finalize]):
3141         (-[DOMSVGRect x]):
3142         (-[DOMSVGRect setX:]):
3143         (-[DOMSVGRect y]):
3144         (-[DOMSVGRect setY:]):
3145         (-[DOMSVGRect width]):
3146         (-[DOMSVGRect setWidth:]):
3147         (-[DOMSVGRect height]):
3148         (-[DOMSVGRect setHeight:]):
3149         (-[DOMSVGRect WebCore::]):
3150         (-[DOMSVGRect _initWithFloatRect:WebCore::]):
3151         (+[DOMSVGRect _SVGRectWith:WebCore::]):
3152         * bindings/scripts/CodeGeneratorObjC.pm:
3153         * ksvg2/svg/SVGAnimatedNumberList.idl:
3154         * ksvg2/svg/SVGAnimatedRect.idl:
3155         * ksvg2/svg/SVGComponentTransferFunctionElement.idl:
3156         * ksvg2/svg/SVGCursorElement.idl:
3157         * ksvg2/svg/SVGFEBlendElement.idl:
3158         * ksvg2/svg/SVGFEColorMatrixElement.idl:
3159         * ksvg2/svg/SVGFEComponentTransferElement.idl:
3160         * ksvg2/svg/SVGFECompositeElement.idl:
3161         * ksvg2/svg/SVGFEDiffuseLightingElement.idl:
3162         * ksvg2/svg/SVGFEDisplacementMapElement.idl:
3163         * ksvg2/svg/SVGFEDistantLightElement.idl:
3164         * ksvg2/svg/SVGFEFloodElement.idl:
3165         * ksvg2/svg/SVGFEFuncAElement.idl:
3166         * ksvg2/svg/SVGFEFuncBElement.idl:
3167         * ksvg2/svg/SVGFEFuncGElement.idl:
3168         * ksvg2/svg/SVGFEFuncRElement.idl:
3169         * ksvg2/svg/SVGFEGaussianBlurElement.idl:
3170         * ksvg2/svg/SVGFEImageElement.idl:
3171         * ksvg2/svg/SVGFEMergeElement.idl:
3172         * ksvg2/svg/SVGFEMergeNodeElement.idl:
3173         * ksvg2/svg/SVGFEOffsetElement.idl:
3174         * ksvg2/svg/SVGFEPointLightElement.idl:
3175         * ksvg2/svg/SVGFESpecularLightingElement.idl:
3176         * ksvg2/svg/SVGFESpotLightElement.idl:
3177         * ksvg2/svg/SVGFETileElement.idl:
3178         * ksvg2/svg/SVGFETurbulenceElement.cpp:
3179         * ksvg2/svg/SVGFETurbulenceElement.h:
3180         * ksvg2/svg/SVGFETurbulenceElement.idl:
3181         * ksvg2/svg/SVGNumberList.idl:
3182
3183 2006-10-06  Adam Roben  <aroben@apple.com>
3184
3185         Backing out my previous change.
3186
3187         * WebCore.xcodeproj/project.pbxproj:
3188         * page/FrameView.cpp:
3189         (WebCore::FrameView::adjustViewSize):
3190
3191 2006-10-06  Adam Roben  <aroben@apple.com>
3192
3193         Build fix.
3194
3195         * WebCore.xcodeproj/project.pbxproj:
3196         * page/FrameView.cpp:
3197         (WebCore::FrameView::windowResizerRect):
3198
3199 2006-10-06  Adam Roben  <aroben@apple.com>
3200
3201         Reviewed by Maciej.
3202
3203         More loader tweaks.
3204
3205         * platform/ResourceLoader.h:
3206         * platform/ResourceLoaderInternal.h:
3207         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
3208         * platform/win/TemporaryLinkStubs.cpp:
3209         (WebCore::ResourceLoader::newHTTPRequest):
3210
3211 2006-10-05  Steve Falkenburg  <sfalken@apple.com>
3212
3213         Reviewed by aroben.
3214
3215         Stub out some methods that we'll be able to use to dodge a window resizer.
3216
3217         * bridge/win/FrameWin.h:
3218         * page/Frame.h:
3219         (WebCore::Frame::windowResizerRect):
3220         * page/FrameView.h:
3221         * platform/ScrollView.h:
3222         (WebCore::ScrollView::windowResizerRect):
3223         * platform/Widget.h:
3224         * platform/win/TemporaryLinkStubs.cpp:
3225         (FrameView::windowResizerRect):
3226         (Widget::setParent):
3227         (Widget::parent):
3228         (FrameWin::windowResizerRect):
3229
3230 2006-10-05  Dave Hyatt  <hyatt@apple.com>
3231
3232         Stub out setFrameGeometry.
3233         
3234         * platform/ScrollView.h:
3235
3236 2006-10-05  Adele Peterson  <adele@apple.com>
3237
3238         Reverting autoscroll fix.  I need to rework this a little.
3239
3240         * page/Frame.cpp:
3241         (WebCore::Frame::handleAutoscroll):
3242         (WebCore::Frame::autoscrollTimerFired):
3243         (WebCore::Frame::stopAutoscrollTimer):
3244         * page/Frame.h:
3245         * rendering/RenderLayer.cpp:
3246         (WebCore::RenderLayer::~RenderLayer):
3247         * rendering/RenderListBox.cpp:
3248         (WebCore::RenderListBox::~RenderListBox):
3249
3250 2006-10-05  Alice  <alice.liu@apple.com>
3251
3252         Reviewed by Adam.
3253
3254         Fixed <rdar://problem/4731778>
3255
3256         * editing/CommandByName.cpp:
3257         (WebCore::Frame::Command::):
3258         was calling the wrong enabledFn for arrow selection and navigation
3259
3260 2006-10-05  Adele Peterson  <adele@apple.com>
3261
3262         Reviewed by Maciej.
3263
3264         - Fix for <rdar://problem/4707489> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active <input type="text">
3265           and <rdar://problem/4707519> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active textarea
3266
3267         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer): If the renderer is being autoscrolled, then stop the autoscroll timer.
3268         * rendering/RenderListBox.cpp: (WebCore::RenderListBox::~RenderListBox): ditto.
3269
3270         * page/Frame.cpp: Added getter and setter for the renderer being autoscrolled.
3271         (WebCore::Frame::handleAutoscroll):
3272         (WebCore::Frame::autoscrollTimerFired):
3273         (WebCore::Frame::autoscrollRenderer):
3274         (WebCore::Frame::setAutoscrollRenderer):
3275         (WebCore::Frame::stopAutoscrollTimer):
3276         * page/Frame.h:
3277
3278 2006-10-05  Don Gibson  <dgibson77@gmail.com>
3279
3280         Reviewed by Eric.
3281
3282         Fix win32 build bustage after ggaren's Scrollbar renaming changes.
3283         Properly include PlatformScrollBar.h in WbCore.vcproj.
3284         Clean up WidgetWin.cpp a bit.
3285
3286         * WebCore.vcproj/WebCore/WebCore.vcproj:
3287         * platform/Widget.h:
3288         * platform/win/PlatformScrollBar.h:
3289         * platform/win/ScrollViewWin.cpp:
3290         (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate):
3291         (WebCore::ScrollView::resizeContents):
3292         (WebCore::ScrollView::scrollBy):
3293         (WebCore::ScrollView::hScrollbarMode):
3294         (WebCore::ScrollView::vScrollbarMode):
3295         (WebCore::ScrollView::suppressScrollbars):
3296         (WebCore::ScrollView::setHScrollbarMode):
3297         (WebCore::ScrollView::setVScrollbarMode):
3298         (WebCore::ScrollView::setScrollbarsMode):
3299         (WebCore::ScrollView::updateScrollbars):
3300         * platform/win/TemporaryLinkStubs.cpp:
3301         (FrameView::passMousePressEventToScrollbar):
3302         (Widget::removeFromParent):
3303         (ScrollView::scrollbarUnderMouse):
3304         (PlatformScrollbar::PlatformScrollbar):
3305         (PlatformScrollbar::~PlatformScrollbar):
3306         (PlatformScrollbar::width):
3307         (PlatformScrollbar::height):
3308         (PlatformScrollbar::setEnabled):
3309         (PlatformScrollbar::paint):
3310         (PlatformScrollbar::updateThumbPosition):
3311         (PlatformScrollbar::updateThumbProportion):
3312         (PlatformScrollbar::setRect):
3313         (Scrollbar::Scrollbar):
3314         (Scrollbar::setSteps):
3315         (Scrollbar::scroll):
3316         (Scrollbar::setValue):
3317         (Scrollbar::setProportion):
3318         * platform/win/WidgetWin.cpp:
3319         (WebCore::WidgetPrivate::WidgetPrivate):
3320         (WebCore::Widget::Widget):
3321         (WebCore::Widget::setContainingWindow):
3322         (WebCore::Widget::containingWindow):
3323
3324 2006-10-05  Geoffrey Garen  <ggaren@apple.com>
3325
3326         build fix.
3327         
3328         * WebCore.xcodeproj/project.pbxproj:
3329         * bridge/mac/BrowserExtensionMac.mm:
3330         (WebCore::BrowserExtensionMac::createNewWindow):
3331         * bridge/mac/FrameMac.mm:
3332         (WebCore::FrameMac::createFrame):
3333         * bridge/mac/FrameViewMac.mm:
3334         (WebCore::FrameView::passMousePressEventToScrollbar):
3335         * bridge/mac/WebCoreFrameBridge.mm:
3336         (-[WebCoreFrameBridge installInFrame:]):
3337         * bridge/mac/WebCoreFrameView.h:
3338         * platform/ScrollBar.cpp:
3339         * platform/Widget.h:
3340         * platform/mac/PlatformScrollBar.h:
3341         * platform/mac/PlatformScrollBarMac.mm:
3342         (NSControlSizeForScrollBarControlSize):
3343         (-[WebCoreScrollBar initWithPlatformScrollbar:]):
3344         (-[WebCoreScrollBar detachPlatformScrollbar]):
3345         (-[WebCoreScrollBar scroll:]):
3346         (-[WebCoreScrollBar widget]):
3347         (WebCore::PlatformScrollbar::PlatformScrollbar):
3348         (WebCore::PlatformScrollbar::~PlatformScrollbar):
3349         (WebCore::PlatformScrollbar::updateThumbPosition):
3350         (WebCore::PlatformScrollbar::updateThumbProportion):
3351         (WebCore::PlatformScrollbar::scrollbarHit):
3352         (WebCore::PlatformScrollbar::width):
3353         (WebCore::PlatformScrollbar::height):
3354         (WebCore::PlatformScrollbar::setRect):
3355         (WebCore::PlatformScrollbar::setEnabled):
3356         (WebCore::PlatformScrollbar::paint):
3357         * platform/mac/ScrollViewMac.mm:
3358         (WebCore::ScrollView::setVScrollbarMode):
3359         (WebCore::ScrollView::setHScrollbarMode):
3360         (WebCore::ScrollView::setScrollbarsMode):
3361         (WebCore::ScrollView::vScrollbarMode):
3362         (WebCore::ScrollView::hScrollbarMode):
3363         (WebCore::ScrollView::suppressScrollbars):
3364         (WebCore::ScrollView::scrollbarUnderMouse):
3365         * platform/mac/WidgetMac.mm:
3366         (WebCore::Widget::removeFromParent):
3367         * rendering/RenderLayer.cpp:
3368         (WebCore::RenderLayer::destroyScrollbar):
3369
3370 2006-10-05  Geoffrey Garen  <ggaren@apple.com>
3371
3372         build fix.
3373         
3374         * platform/Widget.h:
3375         * rendering/RenderLayer.cpp:
3376         (WebCore::RenderLayer::destroyScrollbar):
3377
3378 2006-10-06  Mitz Pettel  <mitz@webkit.org>
3379
3380         http://bugs.webkit.org/show_bug.cgi?id=8276
3381         Fix broken manual test added back in r13990.
3382
3383         Add resource forks for test resources.
3384
3385         * manual-tests/resources/plain-text-paste/._1.textClipping: Added.
3386         * manual-tests/resources/plain-text-paste/._2.textClipping: Added.
3387         * manual-tests/resources/plain-text-paste/._4.txt: Added.
3388         * manual-tests/resources/plain-text-paste/._5.webloc: Added.
3389
3390 2006-10-05  David Hyatt  <hyatt@apple.com>
3391
3392         Rename addClip to clip.
3393
3394         Reviewed by darin
3395
3396         * kcanvas/RenderForeignObject.cpp:
3397         (WebCore::RenderForeignObject::paint):
3398         * kcanvas/RenderSVGContainer.cpp:
3399         (WebCore::RenderSVGContainer::paint):
3400         * kcanvas/RenderSVGImage.cpp:
3401         (WebCore::RenderSVGImage::paint):
3402         * platform/GraphicsContext.h:
3403         * platform/cairo/GraphicsContextCairo.cpp:
3404         (WebCore::GraphicsContext::clip):
3405         * platform/cg/GraphicsContextCG.cpp:
3406         (WebCore::GraphicsContext::savePlatformState):
3407         (WebCore::GraphicsContext::restorePlatformState):
3408         (WebCore::GraphicsContext::clip):
3409         (WebCore::GraphicsContext::addRoundedRectClip):
3410         (WebCore::GraphicsContext::addInnerRoundedRectClip):
3411         (WebCore::GraphicsContext::scale):
3412         (WebCore::GraphicsContext::rotate):
3413         (WebCore::GraphicsContext::translate):
3414         (WebCore::GraphicsContext::concatCTM):
3415         * platform/cg/GraphicsContextPlatformPrivate.h:
3416         (WebCore::GraphicsContextPlatformPrivate::save):
3417         (WebCore::GraphicsContextPlatformPrivate::restore):
3418         (WebCore::GraphicsContextPlatformPrivate::clip):
3419         (WebCore::GraphicsContextPlatformPrivate::scale):
3420         (WebCore::GraphicsContextPlatformPrivate::rotate):
3421         (WebCore::GraphicsContextPlatformPrivate::translate):
3422         (WebCore::GraphicsContextPlatformPrivate::concatCTM):
3423         * platform/qt/GraphicsContextQt.cpp:
3424         (WebCore::GraphicsContext::clip):
3425         (WebCore::GraphicsContext::addInnerRoundedRectClip):
3426         (WebCore::GraphicsContext::addRoundedRectClip):
3427         * rendering/InlineFlowBox.cpp:
3428         (WebCore::InlineFlowBox::paintBackground):
3429         (WebCore::InlineFlowBox::paintBackgroundAndBorder):
3430         * rendering/InlineTextBox.cpp:
3431         (WebCore::InlineTextBox::paintSelection):
3432         (WebCore::InlineTextBox::paintTextMatchMarker):
3433         * rendering/RenderBox.cpp:
3434         (WebCore::RenderBox::paintBackgroundExtended):
3435         * rendering/RenderButton.cpp:
3436         (WebCore::RenderButton::paintObject):
3437         * rendering/RenderFileUploadControl.cpp:
3438         (WebCore::RenderFileUploadControl::paintObject):
3439         * rendering/RenderLayer.cpp:
3440         (WebCore::RenderLayer::beginTransparencyLayers):
3441         (WebCore::setClip):
3442         * rendering/RenderListBox.cpp:
3443         (WebCore::RenderListBox::paintObject):
3444         * rendering/RenderMenuList.cpp:
3445         (WebCore::RenderMenuList::paintObject):
3446         * rendering/RenderTableCell.cpp:
3447         (WebCore::RenderTableCell::paintBackgroundsBehindCell):
3448
3449 2006-10-05  Mitz Pettel  <mitz@webkit.org>
3450
3451         Reviewed by Darin.
3452
3453         - http://bugs.webkit.org/show_bug.cgi?id=10386
3454           Delete RenderImageButton.* and remove references from .vcproj and .bkl files
3455
3456         * CMakeLists.txt:
3457         * WebCore.vcproj/WebCore/WebCore.vcproj:
3458         * WebCoreSources.bkl:
3459         * rendering/RenderImageButton.cpp: Removed.
3460         * rendering/RenderImageButton.h: Removed.
3461
3462 2006-10-05  Mitz Pettel  <opendarwin.org@mitzpettel.com>
3463
3464         Reviewed by Darin.
3465
3466         - http://bugs.webkit.org/show_bug.cgi?id=11067
3467           manual-tests/scrollbar-hittest2.html is invalid
3468
3469         * manual-tests/scrollbar-hittest2.html:
3470
3471 2006-10-05  David Carson  <dacarson@gmail.com>
3472
3473         Reviewed by Darin.
3474
3475         http://bugs.webkit.org/show_bug.cgi?id=11152
3476         Adjust the tokenizer chunk size to be smaller for
3477         mobile devices, and also decrease the yield timer
3478         for the tokenizer so that it can resume earlier.
3479
3480         * html/HTMLTokenizer.cpp:
3481         * config.h:
3482
3483 2006-10-05  Adam Roben  <aroben@apple.com>
3484
3485         Removing accidentally-checked-in do-nothing code.
3486
3487         * html/HTMLInputElement.cpp:
3488         (WebCore::HTMLInputElement::defaultEventHandler):
3489
3490 2006-10-05  David Carson  <dacarson@gmail.com>
3491
3492         Reviewed by Mitz.
3493
3494         http://bugs.webkit.org/show_bug.cgi?id=11158
3495         Initialize class variables
3496
3497         * rendering/RenderLayer.cpp:
3498         (WebCore::RenderLayer::RenderLayer):
3499
3500 2006-10-05  Don Gibson  <dgibson77@gmail.com>
3501
3502         Reviewed by Darin, landed by Adam.
3503
3504         http://bugs.webkit.org/show_bug.cgi?id=11176
3505         Fix win32 build, adapt to Maciej's ResourceLoader changes.
3506
3507         * platform/win/ResourceLoaderWin.cpp:
3508         (WebCore::ResourceLoader::start):
3509
3510 2006-10-05  Marvin Decker  <marv.decker@gmail.com>
3511
3512         Reviewed by Darin.
3513
3514         http://bugs.webkit.org/show_bug.cgi?id=10989
3515         Provide a way for embedders to implement BrowserExtensionWin
3516
3517         * WebCore.vcproj/WebCore/WebCore.vcproj:
3518         * bridge/win/BrowserExtensionWin.cpp: Added.
3519         (BrowserExtensionWin::BrowserExtensionWin):
3520         (BrowserExtensionWin::setTypedIconURL):
3521         (BrowserExtensionWin::setIconURL):
3522         (BrowserExtensionWin::getHistoryLength):
3523         (BrowserExtensionWin::canRunModal):
3524         (BrowserExtensionWin::createNewWindow):
3525         (BrowserExtensionWin::canRunModalNow):
3526         (BrowserExtensionWin::runModal):
3527         (BrowserExtensionWin::goBackOrForward):
3528         (BrowserExtensionWin::historyURL):
3529         * bridge/win/BrowserExtensionWin.h:
3530         * bridge/win/FrameWin.cpp:
3531         (WebCore::FrameWin::createNewWindow):
3532         * bridge/win/FrameWin.h:
3533         * platform/win/TemporaryLinkStubs.cpp:
3534
3535 2006-10-05  Geoffrey Garen  <ggaren@apple.com>
3536
3537         Reviewed by Darin.
3538         
3539         Fixed <rdar://problem/4766987>
3540         
3541         - renamed ScrollBar to Scrollbar and scroll bar to scrollbar in every case
3542         except for file names.
3543         
3544         - fixed RenderLayer to properly tear down scrollbars, removing them from
3545         their parents.
3546
3547         * bindings/js/kjs_window.cpp:
3548         (KJS::showModalDialog):
3549         (KJS::setWindowFeature):
3550         (KJS::parseWindowFeatures):
3551         * bridge/BrowserExtension.h:
3552         * dom/Document.cpp:
3553         (WebCore::Document::setInPageCache):
3554         * html/HTMLFrameElement.cpp:
3555         (WebCore::HTMLFrameElement::init):
3556         (WebCore::HTMLFrameElement::parseMappedAttribute):
3557         * html/HTMLFrameElement.h:
3558         (WebCore::HTMLFrameElement::scrollingMode):
3559         * page/Frame.cpp:
3560         (WebCore::Frame::finishedParsing):
3561         (WebCore::Frame::scrollbarsVisible):
3562         * page/FrameView.cpp:
3563         (WebCore::FrameViewPrivate::FrameViewPrivate):
3564         (WebCore::FrameViewPrivate::reset):
3565         (WebCore::FrameView::~FrameView):
3566         (WebCore::FrameView::resetScrollbars):
3567         (WebCore::FrameView::clear):
3568         (WebCore::FrameView::initScrollbars):
3569         (WebCore::FrameView::applyOverflowToViewport):
3570         (WebCore::FrameView::layout):
3571         (WebCore::FrameView::handleMousePressEvent):
3572         (WebCore::selectCursor):
3573         (WebCore::FrameView::handleMouseMoveEvent):
3574         (WebCore::FrameView::setScrollbarsMode):
3575         (WebCore::FrameView::setVScrollbarMode):
3576         (WebCore::FrameView::setHScrollbarMode):
3577         (WebCore::FrameView::restoreScrollbar):
3578         (WebCore::FrameView::dispatchMouseEvent):
3579         (WebCore::FrameView::scrollbarMoved):
3580         * page/FrameView.h:
3581         * page/MouseEventWithHitTestResults.cpp:
3582         (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
3583         * page/MouseEventWithHitTestResults.h:
3584         (WebCore::MouseEventWithHitTestResults::scrollbar):
3585         * platform/ScrollBar.cpp:
3586         (WebCore::Scrollbar::Scrollbar):
3587         (WebCore::Scrollbar::setValue):
3588         (WebCore::Scrollbar::setProportion):
3589         (WebCore::Scrollbar::setSteps):
3590         (WebCore::Scrollbar::scroll):
3591         * platform/ScrollBar.h:
3592         (WebCore::):
3593         (WebCore::ScrollbarClient::~ScrollbarClient):
3594         (WebCore::Scrollbar::~Scrollbar):
3595         (WebCore::Scrollbar::orientation):
3596         (WebCore::Scrollbar::controlSize):
3597         (WebCore::Scrollbar::hasPlatformScrollbars):
3598         (WebCore::Scrollbar::client):
3599         * platform/ScrollBarMode.h:
3600         (WebCore::):
3601         * platform/ScrollView.h:
3602         * rendering/RenderBlock.cpp:
3603         (WebCore::RenderBlock::isPointInScrollbar):
3604         * rendering/RenderLayer.cpp:
3605         (WebCore::RenderLayer::RenderLayer):
3606         (WebCore::RenderLayer::~RenderLayer):
3607         (WebCore::RenderLayer::scrollToOffset):
3608         (WebCore::RenderLayer::horizontaScrollbarWidget):
3609         (WebCore::RenderLayer::verticalScrollbarWidget):
3610         (WebCore::RenderLayer::valueChanged):
3611         (WebCore::RenderLayer::createScrollbar):
3612         (WebCore::RenderLayer::destroyScrollbar):
3613         (WebCore::RenderLayer::setHasHorizontalScrollbar):
3614         (WebCore::RenderLayer::setHasVerticalScrollbar):
3615         (WebCore::RenderLayer::verticalScrollbarWidth):
3616         (WebCore::RenderLayer::horizontalScrollbarHeight):
3617         (WebCore::RenderLayer::updateScrollInfoAfterLayout):
3618         * rendering/RenderLayer.h:
3619         (WebCore::RenderLayer::horizontalScrollbar):
3620         (WebCore::RenderLayer::verticalScrollbar):
3621         * rendering/RenderListBox.cpp:
3622         (WebCore::RenderListBox::~RenderListBox):
3623         (WebCore::RenderListBox::calcMinMaxWidth):
3624         (WebCore::RenderListBox::isPointInScrollbar):
3625         (WebCore::RenderListBox::optionAtPoint):
3626         (WebCore::RenderListBox::valueChanged):
3627         * rendering/RenderListBox.h:
3628         * rendering/RenderObject.h:
3629         (WebCore::RenderObject::NodeInfo::scrollbar):
3630         (WebCore::RenderObject::NodeInfo::setScrollbar):
3631
3632 2006-10-05  Don Gibson  <dgibson77@gmail.com>
3633
3634         Reviewed by Adam.
3635
3636         http://bugs.webkit.org/show_bug.cgi?id=11138
3637         Incorrect mouse event generation on Windows
3638
3639         * platform/win/MouseEventWin.cpp:
3640         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
3641         (1) Set mouse button even for non-click-related messages.
3642         (2) Track clicks correctly for all buttons, not just the left button.
3643
3644 2006-10-05  Nikolas Zimmermann  <zimmermann@kde.org>
3645
3646         Reviewed and landed by ap.
3647
3648         Fix Qt/Linux build, adapt to Eric's quartz changes and to Maciej's ResourceLoader changes.
3649
3650         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
3651         (WebCore::KRenderingPaintServerLinearGradientQt::renderPath):
3652         (WebCore::KRenderingPaintServerLinearGradientQt::setup):
3653         (WebCore::KRenderingPaintServerRadialGradientQt::setup):
3654         (WebCore::KRenderingPaintServerRadialGradientQt::renderPath):
3655         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
3656         (WebCore::KRenderingPaintServerPatternQt::renderPath):
3657         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
3658         (WebCore::KRenderingPaintServerQt::setPenProperties):
3659         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
3660         (WebCore::KRenderingPaintServerSolidQt::setup):
3661         (WebCore::KRenderingPaintServerSolidQt::renderPath):
3662         * kcanvas/device/qt/RenderPathQt.cpp:
3663         (WebCore::getPathStroke):
3664
3665 2006-10-05  Alexey Proskuryakov  <ap@nypop.com>
3666
3667         Reviewed by Darin.
3668
3669         http://bugs.webkit.org/show_bug.cgi?id=11054
3670         REGRESSION: Traditional Chinese encoding in login authentication
3671
3672         1. Treat GB2312 encoding as GBK (its more modern superset), to match other browsers.
3673         2. On the Web, GB2312 is encoded as EUC-CN or HZ, while ICU provides a native encoding
3674         for encoding GB_2312-80 and several others. So, we need to override this behavior, too.
3675
3676         * platform/StreamingTextDecoderICU.cpp:
3677         (WebCore::TextCodecICU::registerEncodingNames):
3678
3679 2006-10-05  Eric Seidel  <eric@eseidel.com>
3680
3681         Reviewed by mjs.
3682
3683         Removed dead code.
3684         Filed http://bugs.webkit.org/show_bug.cgi?id=11167 to for followup on removed FIXMEs
3685
3686         * WebCore.xcodeproj/project.pbxproj:
3687         * ksvg2/ecma/GlobalObject.cpp: Removed.
3688         * ksvg2/ecma/GlobalObject.h: Removed.
3689
3690 2006-10-05  Adam Roben  <aroben@apple.com>
3691
3692         Reviewed by Maciej.
3693
3694         Small ResourceLoaderInternal tweak.
3695
3696         * platform/ResourceLoaderInternal.h:
3697         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
3698
3699 2006-10-05  Eric Seidel  <eric@eseidel.com>
3700
3701         Reviewed by mjs.
3702
3703         More incremental KCanvas cleanup and optimization.
3704         Added SVGRenderStyle::hasFill() and hasStroke() removed more KSVGPainterFactory methods.
3705         Optimized dash array usage to not malloc.
3706         Also removed un-needed KSVGRenderingStyle includes.
3707
3708         * kcanvas/KCanvasTreeDebug.cpp:
3709         (WebCore::operator<<):
3710         * kcanvas/RenderPath.cpp:
3711         (WebCore::RenderPath::nodeAtPoint):
3712         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
3713         (WebCore::RenderPath::strokeBBox):
3714         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
3715         (WebCore::KRenderingPaintServerGradientQuartz::setup):
3716         (WebCore::KRenderingPaintServerGradientQuartz::renderPath):
3717         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
3718         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
3719         (WebCore::KRenderingPaintServerSolidQuartz::setup):
3720         (WebCore::KRenderingPaintServerSolidQuartz::renderPath):
3721         (WebCore::KRenderingPaintServerPatternQuartz::setup):
3722         (WebCore::KRenderingPaintServerPatternQuartz::renderPath):
3723         * kcanvas/device/quartz/QuartzSupport.mm:
3724         (WebCore::applyStrokeStyleToContext):
3725         * ksvg2/css/SVGRenderStyle.h:
3726         (WebCore::SVGRenderStyle::hasStroke):
3727         (WebCore::SVGRenderStyle::hasFill):
3728         * ksvg2/misc/KCanvasRenderingStyle.cpp:
3729         (WebCore::KSVGPainterFactory::fillPaintServer):
3730         (WebCore::KSVGPainterFactory::strokePaintServer):
3731         * ksvg2/misc/KCanvasRenderingStyle.h:
3732
3733 2006-10-05  Maciej Stachowiak  <mjs@apple.com>
3734
3735         Reviewed by Adam.
3736
3737         - changed ResourceLoader to be refcounted
3738
3739         It keeps a ref on itself while loading as well. This makes
3740         for a much saner memory management model than the previous.
3741
3742         * bridge/mac/WebCoreResourceLoaderImp.mm:
3743         (-[WebCoreResourceLoaderImp finishJobAndHandle:]):
3744         * dom/XMLTokenizer.cpp:
3745         (WebCore::openFunc):
3746         * loader/icon/IconLoader.cpp:
3747         (IconLoader::IconLoader):
3748         (IconLoader::~IconLoader):
3749         (IconLoader::startLoading):
3750         (IconLoader::stopLoading):
3751         (IconLoader::receivedData):
3752         * loader/icon/IconLoader.h:
3753         * loader/loader.cpp:
3754         (WebCore::Loader::servePendingRequests):
3755         * platform/ResourceLoader.cpp:
3756         (WebCore::ResourceLoader::create):
3757         (WebCore::ResourceLoader::kill):
3758         * platform/ResourceLoader.h:
3759         * platform/ResourceLoaderInternal.h:
3760         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
3761         * platform/mac/ResourceLoaderMac.mm:
3762         (WebCore::ResourceLoader::start):
3763         * xml/XSLTProcessor.cpp:
3764         (WebCore::docLoaderFunc):
3765         * xml/xmlhttprequest.cpp:
3766         (WebCore::XMLHttpRequest::send):
3767         * xml/xmlhttprequest.h:
3768
3769 2006-10-05  Eric Seidel  <eric@eseidel.com>
3770
3771         Reviewed by mjs.
3772
3773         Improve SVG opacity performance by clipping to the object bbox before starting a new opacity layer.
3774         http://bugs.webkit.org/show_bug.cgi?id=11163
3775         
3776         No SVG performance tests yet.
3777
3778         * kcanvas/RenderForeignObject.cpp:
3779         (WebCore::RenderForeignObject::paint):
3780         * kcanvas/RenderSVGContainer.cpp:
3781         (WebCore::RenderSVGContainer::paint):
3782         * kcanvas/RenderSVGImage.cpp:
3783         (WebCore::RenderSVGImage::paint):
3784         * kcanvas/RenderSVGText.cpp:
3785         (WebCore::RenderSVGText::paint):
3786
3787 2006-10-05  Dave Hyatt  <hyatt@apple.com>
3788
3789         Stub out some stuff for widget focusability.
3790
3791         Reviewed by maciej
3792  
3793         * page/FrameView.cpp:
3794         (WebCore::FrameView::dispatchMouseEvent):
3795         * platform/ScrollView.h:
3796         * platform/Widget.h:
3797
3798 2006-10-05  Adam Roben  <aroben@apple.com>
3799
3800         Reviewed by Maciej and Tim H.
3801
3802         Copy some WebKit frame lifetime logic into WebCore -- just a step
3803         along the path to frame lifetime being handled completely in WebCore.
3804
3805         * bridge/mac/FrameMac.mm:
3806         (WebCore::FrameMac::setView): Move platform-independent parts of this
3807         method into Frame.
3808         * page/Frame.cpp:
3809         (WebCore::Frame::setView): Adding platform-independent parts of
3810         FrameMac::setView
3811         (WebCore::Frame::detachChildren): New method to accomplish what
3812         -[WebFrameBridge _detachChildren] currently does.
3813         (WebCore::Frame::clear): Call detachChildren
3814         * page/Frame.h: Add declaration for detachChildren
3815
3816 2006-10-04  Alice Liu  <alice.liu@apple.com>
3817
3818         Reviewed by Darin.
3819
3820         Fixed <rdar://problem/4758577> REGRESSION: Business and People widgets fails to complete search query
3821
3822         * xml/xmlhttprequest.cpp:
3823         (WebCore::XMLHttpRequest::setRequestHeader):
3824         removed exception set when the request is not open yet
3825
3826 2006-10-04  Anders Carlsson  <acarlsson@apple.com>
3827
3828         Reviewed by John Sullivan.
3829
3830         <rdar://problem/4654328>
3831         Safari Crashes in WebCore::PluginTokenizer::writeRawData If I Try to Open a SWF File With Plug-ins Turned Off
3832         
3833         * loader/PluginDocument.cpp:
3834         (WebCore::PluginTokenizer::writeRawData):
3835         Only send the data to the plug-in if plug-ins are enabled, otherwise just silently eat it.
3836
3837 2006-10-03  Alexey Proskuryakov  <ap@nypop.com>
3838
3839         Reviewed by Tim H.
3840
3841         http://bugs.webkit.org/show_bug.cgi?id=11130
3842         Convert "undefined" to AE missing value
3843
3844         * bridge/mac/WebCoreFrameBridge.mm:
3845         (aeDescFromJSValue): return missing value for UndefinedType.
3846
3847 2006-10-03  Dave Hyatt  <hyatt@apple.com>
3848
3849         Scrolling work.  Eliminate convertTo/FromContainingWindow as cross-platform functions.  Add back in
3850         the windowToContents/contentsToWindow functions.
3851         
3852         Reviewed by anders
3853
3854         * bridge/mac/FrameMac.mm:
3855         (WebCore::FrameMac::eventMayStartDrag):
3856         (WebCore::FrameMac::dragHysteresisExceeded):
3857         (WebCore::FrameMac::mouseDown):
3858         (WebCore::FrameMac::shouldDragAutoNode):
3859         (WebCore::FrameMac::sendContextMenuEvent):
3860         * bridge/mac/FrameViewMac.mm:
3861         (WebCore::FrameView::passMousePressEventToScrollbar):
3862         * bridge/mac/WebCoreFrameBridge.mm:
3863         (-[WebCoreFrameBridge _visiblePositionForPoint:]):
3864         * dom/EventTargetNode.cpp:
3865         (WebCore::EventTargetNode::dispatchMouseEvent):
3866         (WebCore::EventTargetNode::dispatchWheelEvent):
3867         * page/Frame.cpp:
3868         (WebCore::Frame::selectClosestWordFromMouseEvent):
3869         (WebCore::Frame::handleMousePressEventTripleClick):
3870         (WebCore::Frame::handleMousePressEventSingleClick):
3871         (WebCore::Frame::handleMouseMoveEvent):
3872         (WebCore::Frame::handleMouseReleaseEvent):
3873         * page/FrameView.cpp:
3874         (WebCore::FrameView::handleMousePressEvent):
3875         (WebCore::FrameView::handleMouseDoubleClickEvent):
3876         (WebCore::selectCursor):
3877         (WebCore::FrameView::handleMouseMoveEvent):
3878         (WebCore::FrameView::handleMouseReleaseEvent):
3879         (WebCore::FrameView::dispatchDragEvent):
3880         (WebCore::FrameView::prepareMouseEvent):
3881         (WebCore::FrameView::handleWheelEvent):
3882         * page/FrameView.h:
3883         * platform/ScrollBar.cpp:
3884         (WebCore::ScrollBar::setValue):
3885         * platform/ScrollView.h:
3886         * platform/Widget.h:
3887         (WebCore::Widget::scrolled):
3888         * platform/mac/ScrollViewMac.mm:
3889         (WebCore::ScrollView::contentsToWindow):
3890         (WebCore::ScrollView::windowToContents):
3891         (WebCore::ScrollView::scrollbarUnderMouse):
3892         * platform/mac/WidgetMac.mm:
3893         * rendering/RenderLayer.cpp:
3894         (WebCore::RenderLayer::resize):
3895         (WebCore::RenderLayer::positionScrollbars):
3896         * rendering/RenderReplaced.cpp:
3897         (WebCore::RenderReplaced::shouldPaint):
3898         * rendering/RenderView.cpp:
3899         * rendering/RenderView.h:
3900         * rendering/RenderWidget.cpp:
3901         (WebCore::RenderWidget::setWidget):
3902
3903 2006-09-26  David Smith  <catfish.man@gmail.com>
3904
3905         Reviewed by Timothy.
3906
3907         http://bugs.webkit.org/show_bug.cgi?id=3723
3908         Add -scrollDOMRangeToVisible:
3909
3910         No automated tests are possible as this code path isn't reachable from JavaScript.
3911
3912         * bridge/mac/WebCoreFrameBridge.h:
3913         * bridge/mac/WebCoreFrameBridge.mm:
3914         (-[WebCoreFrameBridge scrollDOMRangeToVisible:]):
3915
3916 2006-10-03  Graham Dennis  <graham.dennis@gmail.com>
3917
3918         Reviewed by Timothy.
3919
3920         <http://bugs.webkit.org/show_bug.cgi?id=10338>
3921         When contentEditable, cursor doesn't change to hand
3922         
3923         Allow the behaviour of editable links to be specified by a WebPreference
3924         The preference WebKitEditableLinkBehavior has four options:
3925          - AlwaysLive: Safari 2.0 behaviour
3926          - OnlyLiveWithShiftKey: Firefox/WinIE behaviour (and prior WebKit-ToT behaviour)
3927          - LiveWhenNotFocused: Editable links are live only when their editable block is not
3928              focused, or when the shift key is pressed
3929          - DefaultBehavior: This is the same as OnlyLiveWithShiftKey.
3930          
3931         No layout tests, just a modification of a manual-test as it isn't possible to test
3932         this automatically.
3933
3934         * bridge/mac/WebCoreSettings.h:
3935         * bridge/mac/WebCoreSettings.mm:
3936         (-[WebCoreSettings setEditableLinkBehavior:]):
3937         (-[WebCoreSettings editableLinkBehavior]):
3938         * html/HTMLAnchorElement.cpp:
3939         (WebCore::HTMLAnchorElement::HTMLAnchorElement):
3940         (WebCore::HTMLAnchorElement::defaultEventHandler):
3941         (WebCore::HTMLAnchorElement::setActive):
3942         * html/HTMLAnchorElement.h:
3943         * manual-tests/contenteditable-link.html:
3944         * page/FrameView.cpp:
3945         (WebCore::nodeIsNotBeingEdited):
3946         (WebCore::selectCursor):
3947         * page/Settings.h:
3948         (WebCore::Settings::):
3949         (WebCore::Settings::Settings):
3950         (WebCore::Settings::editableLinkBehavior):
3951         (WebCore::Settings::setEditableLinkBehavior):
3952
3953 2006-10-03  Beth Dakin  <bdakin@apple.com>
3954
3955         Reviewed Darin.
3956
3957         No test cases needed.
3958
3959         Implemented a version of StringImpl::append that takes a UChar* and 
3960         a length.
3961
3962         * platform/StringImpl.cpp:
3963         (WebCore::StringImpl::append):
3964         (WebCore::StringImpl::insert): Call new append instead of making a 
3965         new StringImpl.
3966         * platform/StringImpl.h:
3967
3968 2006-10-03  MorganL  <morganl.webkit@yahoo.com>
3969
3970         Reviewed by Darin.
3971
3972         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11099
3973         HttpSendRequestEx results in ERROR_HTTP_HEADER_NOT_FOUND
3974
3975         * platform/win/ResourceLoaderWin.cpp:
3976         (WebCore::ResourceLoader::onHandleCreated):
3977
3978 2006-10-02  Geoffrey Garen  <ggaren@apple.com>
3979
3980         Feared, loathed, reviewed by Darin.
3981
3982         More frame/iframe merging. Merged IFRAME::willRemove and IFRAME::detach 
3983         into FRAME, plus other cleanup.
3984         
3985         No new behavior, so no new test. Layout tests pass. Basic browsing and
3986         Mail editing seem to work.
3987         
3988         * dom/Node.cpp:
3989         (WebCore::Node::detach): Removed random commented-out code.
3990         * html/HTMLFrameElement.cpp:
3991         (WebCore::HTMLFrameElement::isURLAllowed): 
3992         (1) Removed reference to FrameView, to dissociate frame loading from rendering.
3993         (2) Renamed newURL to completeURL because the difference between newURL
3994         and URLString is that newURL is a KURL that is the complete version of URLString,
3995         not that it is new.
3996         (WebCore::HTMLFrameElement::willRemove): 
3997         (1) Removed close() call and moved close() code into willRemove(), also removing 
3998         close() call from detach(), since willRemove is the well-defined place 
3999         from DOM tear-down, not detach().
4000         (2) Removed manual renderer detach code because the DOM is not responsible
4001         for managing the render tree. I confirmed that this change not
4002         regress <rdar://problem/4132581>.
4003         (3) Removed questionable ASSERT. The ASSERT assumed that iframe elements
4004         lost their content frames after being removed from the DOM. That's our 
4005         current behavior, but it's going to change in future rounds of refactoring.
4006         This also fixes <rdar://problem/4750835>.
4007         (WebCore::HTMLFrameElement::setLocation): Removed wacky manual calls to
4008         attach/detach, because the render tree should not be in charge of deciding
4009         when to load.
4010         * html/HTMLFrameElement.h:
4011         * html/HTMLIFrameElement.cpp:
4012         (WebCore::HTMLIFrameElement::attach): Renamed renderPart to renderPartObject,
4013         because the renderer is a renderPartObject, not a renderPart.
4014         * html/HTMLIFrameElement.h:
4015
4016 2006-10-03  Mark Rowe  <bdash@webkit.org>
4017
4018         Reviewed by Mitz.
4019
4020         http://bugs.webkit.org/show_bug.cgi?id=11137
4021         Bug 11137: GdkLauncher dies with "pure virtual method called" if
4022         window is closed while page still loading
4023
4024         * platform/gdk/FrameGdk.cpp:
4025         (WebCore::FrameGdk::~FrameGdk): Call cancelAndClear to allow virtual
4026         methods to be called before the FrameGdk portion of "this" is torn down.
4027
4028 2006-10-03  Adam Roben  <aroben@apple.com>
4029
4030         Reviewed by Darin.
4031
4032         Handle tab key presses in the DOM.
4033
4034         * dom/EventTargetNode.cpp:
4035         (WebCore::EventTargetNode::defaultEventHandler): Add tab key handling.
4036         * page/FrameView.cpp:
4037         (WebCore::FrameView::advanceFocus): Rename and reimplement
4038         focusNextPrevNode. Now we just call Element::focus().
4039         * page/FrameView.h: Rename focusNextPrevNode to advanceFocus and make
4040         it public.
4041
4042 2006-10-03  Justin Garcia  <justin.garcia@apple.com>
4043
4044         Reviewed by mjs
4045         
4046         <rdar://problem/4760612>
4047         TOT REGRESSION: Repro assertion failure when forwarding draft in Range::compareBoundaryPoints
4048         
4049         No layout test possible, attributedStringFrom:(DOMNode*)...etc isn't available to DRT.
4050         
4051         * dom/Range.cpp:
4052         (WebCore::Range::boundaryPointsValid): compareBoundaryPoints asserts that the incoming 
4053         positions are non-null since most of it's callers would be in a bad state if the positions 
4054         were null.  boundaryPointsValid, which calls compareBoundaryPoints, is an exception.  
4055         Instead of removing the assert I've added nil checks in boundaryPointsValid, to keep it 
4056         from entering compareBoundaryPoints and hitting the assert.
4057
4058 2006-10-03  Adele Peterson  <adele@apple.com>
4059
4060         Reviewed by Geoff.
4061
4062         Make code for turning off new listbox implementation mac-only, since there's no implementation on other platforms.
4063
4064         * html/HTMLSelectElement.cpp:
4065         (WebCore::HTMLSelectElement::recalcStyle):
4066         (WebCore::HTMLSelectElement::isKeyboardFocusable):
4067         (WebCore::HTMLSelectElement::isMouseFocusable):
4068         (WebCore::HTMLSelectElement::createRenderer):
4069         (WebCore::HTMLSelectElement::setRecalcListItems):
4070         (WebCore::HTMLSelectElement::notifyOptionSelected):
4071         (WebCore::HTMLSelectElement::defaultEventHandler):
4072
4073 2006-10-04  Darin Adler  <darin@apple.com>
4074
4075         Reviewed by Geoff.
4076
4077         - fix http://bugs.webkit.org/show_bug.cgi?id=11132
4078           Caret disappears when you're typing
4079
4080         * editing/SelectionController.cpp:
4081         (WebCore::SelectionController::setSelection): Remove unnecessary call to
4082         clearCaretRectIfNeeded. The recomputeCaretRect now takes care of this.
4083         (WebCore::SelectionController::recomputeCaretRect): Explicitly set m_needsLayout
4084         to false so we can get the old caret repaint rect. Later we need to change the
4085         design so getting the rect doesn't have a side effect of causing a layout without
4086         invalidation.
4087
4088 2006-10-03  David Harrison  <harrison@apple.com>
4089
4090         Reviewed by Maciej.
4091
4092         <rdar://problem/4671286> Candidate Window isn't displayed and only first candidate is displayed at typing location.
4093
4094         Updated test:
4095         * fast/text/justified-text-rect.html
4096
4097         * bridge/mac/WebCoreFrameBridge.mm:
4098         (-[WebCoreFrameBridge convertToNSRange:]):
4099         (-[WebCoreFrameBridge convertToDOMRange:]):
4100         Make the selection's root editable element (or the document itself) be
4101         the basis for NSRange conversions. This supports "shadow DOM" like
4102         that for text fields and text areas.
4103         
4104         * editing/CompositeEditCommand.cpp:
4105         (WebCore::CompositeEditCommand::moveParagraphs):
4106         Pass the document element as the scope.
4107         
4108         * editing/TextIterator.cpp:
4109         (WebCore::TextIterator::rangeFromLocationAndLength):
4110         Make the first parameter the scope.
4111         
4112         * editing/TextIterator.h:
4113         Make the first parameter of rangeFromLocationAndLength() the scope.
4114
4115 2006-10-03  Nikolas Zimmermann  <zimmermann@kde.org>
4116
4117         Reviewed by Eric.
4118
4119         Fix Qt/Linux build.
4120
4121         * CMakeLists.txt: Add counter related files.
4122
4123 2006-10-03  Mark Rowe  <bdash@webkit.org>
4124
4125         Reviewed by Eric.
4126
4127         http://bugs.webkit.org/show_bug.cgi?id=10981
4128         Linux/GDK build fixes
4129
4130         Based on a patch by Krzysztof Kowalczyk.
4131
4132         * WebCoreSources.bkl:
4133         * platform/gdk/FrameGdk.cpp:
4134         (WebCore::doScroll):
4135         (WebCore::FrameGdk::handleGdkEvent):
4136         * platform/gdk/PlatformScrollBar.h: Added.
4137         (WebCore::PlatformScrollBar::isWidget):
4138         * platform/gdk/ScrollViewGdk.cpp:
4139         * platform/gdk/TemporaryLinkStubs.cpp:
4140         (FrameView::passMousePressEventToScrollbar):
4141         (FrameView::passMousePressEventToSubframe):
4142         (FrameView::passMouseReleaseEventToSubframe):
4143         (FrameView::passMouseMoveEventToSubframe):
4144         (FrameView::passWheelEventToSubframe):
4145         (Cursor::Cursor):
4146         (Widget::invalidate):
4147         (Widget::invalidateRect):
4148         (ScrollView::wheelEvent):
4149         (ScrollView::convertToContainingWindow):
4150         (ScrollView::convertFromContainingWindow):
4151         (GraphicsContext::clip):
4152         (PlatformScrollBar::PlatformScrollBar):
4153         (PlatformScrollBar::updateThumbPosition):
4154         (PlatformScrollBar::updateThumbProportion):
4155         (ScrollBar::ScrollBar):
4156         (ScrollBar::setProportion):
4157         (WebCore::supportedKeySizes):
4158         (WebCore::signedPublicKeyAndChallengeString):
4159         * platform/gdk/WheelEventGdk.cpp:
4160         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
4161         * platform/gdk/WidgetGdk.cpp:
4162         (WebCore::Widget::convertToContainingWindow):
4163         (WebCore::Widget::convertFromContainingWindow):
4164
4165 2006-10-02  Adam Roben  <aroben@apple.com>
4166
4167         Reviewed by Maciej.
4168
4169         Let Windows determine which mouse button is pressed.
4170
4171         * platform/PlatformMouseEvent.h: Add message parameter to constructor.
4172         * platform/win/MouseEventWin.cpp:
4173         (WebCore::PlatformMouseEvent::PlatformMouseEvent): Use message
4174         parameter to determine which mouse button is pressed.
4175
4176 2006-10-02  Justin Garcia  <justin.garcia@apple.com>
4177
4178         Reviewed by anders
4179         
4180         Build fix
4181         
4182         * editing/SelectionController.cpp:
4183         (WebCore::SelectionController::empty):
4184         * editing/SelectionController.h:
4185
4186 2006-10-02  Justin Garcia  <justin.garcia@apple.com>
4187
4188         Reviewed by john
4189         
4190         <rdar://problem/4755287>
4191         Writely Editor: Crash occurs at WebCore::maxDeepOffset(WebCore::Node const*) when attempting to create a OL/UL following a HR element
4192
4193         * editing/markup.cpp:
4194         (WebCore::createMarkup): Migrate to isBlock (isBlockFlow is true for inline replaced 
4195         elements).  Don't skip blocks that aren't containers (like horizontal rules).
4196
4197 2006-10-03  Darin Adler  <darin@apple.com>
4198
4199         Reviewed by Justin Garcia.
4200
4201         - correct mistaken code that would restart blinking every
4202           time "invalidateSelection" is called even if the caret
4203           has not moved
4204
4205         * editing/SelectionController.h:
4206         * editing/SelectionController.cpp:
4207         (WebCore::SelectionController::setSelection): Update for name change.
4208         (WebCore::SelectionController::recomputeCaretRect): New function.
4209         Computes caret rect and does any necessary invalidation if the rect
4210         changes.
4211         (WebCore::SelectionController::invalidateCaretRect): Renamed from
4212         needsCaretRepaint. Invalidates the caret rect unconditionally. Also
4213         calls recomputeCaretRect as a side effect.
4214
4215         * page/Frame.cpp:
4216         (WebCore::Frame::invalidateSelection): Remove unneeded call to
4217         clearCaretRectIfNeeded.
4218         (WebCore::Frame::clearCaretRectIfNeeded): Updated for name change.
4219         (WebCore::Frame::selectionLayoutChanged): Restructured to use the new
4220         recomputeCaretRect function and not restart blinking if caret has
4221         not changed position.
4222         (WebCore::Frame::caretBlinkTimerFired): Removed some checks that
4223         are not needed since selectionLayoutChanged already checks these.
4224
4225         * page/FramePrivate.h: Removed unused m_blinkCaret.
4226
4227 2006-10-02  Beth Dakin  <bdakin@apple.com>
4228
4229         Reviewed by Adam.
4230
4231         Build fix. Add counters to vcproj.
4232
4233         * WebCore.vcproj/WebCore/WebCore.vcproj:
4234
4235 2006-10-02  Brady Eidson  <beidson@apple.com>
4236
4237         Reviewed by Adele
4238
4239         If the Icon DB schema changes underneath you, the latest ToT can crash and burn when writing
4240         icon data out because we don't correctly check SQL error conditions.
4241
4242         * loader/icon/IconDataCache.cpp:
4243         (WebCore::IconDataCache::writeToDatabase):
4244
4245 2006-10-02  Steve Falkenburg  <sfalken@apple.com>
4246
4247         Reviewed by Hyatt.
4248
4249         Added method to find out whether a layout has occurred.
4250
4251         * page/FrameView.cpp:
4252         (WebCore::FrameView::didFirstLayout):
4253         * page/FrameView.h:
4254
4255 2006-10-02 &nbs