WebCore/ChangeLog

   1 2006-10-05  Nikolas Zimmermann  <zimmermann@kde.org>
   2
   3         Reviewed and landed by ap.
   4
   5         Fix Qt/Linux build, adapt to Eric's quartz changes and to Maciej's ResourceLoader changes.
   6
   7         * kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
   8         (WebCore::KRenderingPaintServerLinearGradientQt::renderPath):
   9         (WebCore::KRenderingPaintServerLinearGradientQt::setup):
  10         (WebCore::KRenderingPaintServerRadialGradientQt::setup):
  11         (WebCore::KRenderingPaintServerRadialGradientQt::renderPath):
  12         * kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
  13         (WebCore::KRenderingPaintServerPatternQt::renderPath):
  14         * kcanvas/device/qt/KRenderingPaintServerQt.cpp:
  15         (WebCore::KRenderingPaintServerQt::setPenProperties):
  16         * kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
  17         (WebCore::KRenderingPaintServerSolidQt::setup):
  18         (WebCore::KRenderingPaintServerSolidQt::renderPath):
  19         * kcanvas/device/qt/RenderPathQt.cpp:
  20         (WebCore::getPathStroke):
  21
  22 2006-10-05  Alexey Proskuryakov  <ap@nypop.com>
  23
  24         Reviewed by Darin.
  25
  26         http://bugs.webkit.org/show_bug.cgi?id=11054
  27         REGRESSION: Traditional Chinese encoding in login authentication
  28
  29         1. Treat GB2312 encoding as GBK (its more modern superset), to match other browsers.
  30         2. On the Web, GB2312 is encoded as EUC-CN or HZ, while ICU provides a native encoding
  31         for encoding GB_2312-80 and several others. So, we need to override this behavior, too.
  32
  33         * platform/StreamingTextDecoderICU.cpp:
  34         (WebCore::TextCodecICU::registerEncodingNames):
  35
  36 2006-10-05  Eric Seidel  <eric@eseidel.com>
  37
  38         Reviewed by mjs.
  39
  40         Removed dead code.
  41         Filed http://bugs.webkit.org/show_bug.cgi?id=11167 to for followup on removed FIXMEs
  42
  43         * WebCore.xcodeproj/project.pbxproj:
  44         * ksvg2/ecma/GlobalObject.cpp: Removed.
  45         * ksvg2/ecma/GlobalObject.h: Removed.
  46
  47 2006-10-05  Adam Roben  <aroben@apple.com>
  48
  49         Reviewed by Maciej.
  50
  51         Small ResourceLoaderInternal tweak.
  52
  53         * platform/ResourceLoaderInternal.h:
  54         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
  55
  56 2006-10-05  Eric Seidel  <eric@eseidel.com>
  57
  58         Reviewed by mjs.
  59
  60         More incremental KCanvas cleanup and optimization.
  61         Added SVGRenderStyle::hasFill() and hasStroke() removed more KSVGPainterFactory methods.
  62         Optimized dash array usage to not malloc.
  63         Also removed un-needed KSVGRenderingStyle includes.
  64
  65         * kcanvas/KCanvasTreeDebug.cpp:
  66         (WebCore::operator<<):
  67         * kcanvas/RenderPath.cpp:
  68         (WebCore::RenderPath::nodeAtPoint):
  69         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
  70         (WebCore::RenderPath::strokeBBox):
  71         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
  72         (WebCore::KRenderingPaintServerGradientQuartz::setup):
  73         (WebCore::KRenderingPaintServerGradientQuartz::renderPath):
  74         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
  75         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
  76         (WebCore::KRenderingPaintServerSolidQuartz::setup):
  77         (WebCore::KRenderingPaintServerSolidQuartz::renderPath):
  78         (WebCore::KRenderingPaintServerPatternQuartz::setup):
  79         (WebCore::KRenderingPaintServerPatternQuartz::renderPath):
  80         * kcanvas/device/quartz/QuartzSupport.mm:
  81         (WebCore::applyStrokeStyleToContext):
  82         * ksvg2/css/SVGRenderStyle.h:
  83         (WebCore::SVGRenderStyle::hasStroke):
  84         (WebCore::SVGRenderStyle::hasFill):
  85         * ksvg2/misc/KCanvasRenderingStyle.cpp:
  86         (WebCore::KSVGPainterFactory::fillPaintServer):
  87         (WebCore::KSVGPainterFactory::strokePaintServer):
  88         * ksvg2/misc/KCanvasRenderingStyle.h:
  89
  90 2006-10-05  Maciej Stachowiak  <mjs@apple.com>
  91
  92         Reviewed by Adam.
  93
  94         - changed ResourceLoader to be refcounted
  95
  96         It keeps a ref on itself while loading as well. This makes
  97         for a much saner memory management model than the previous.
  98
  99         * bridge/mac/WebCoreResourceLoaderImp.mm:
 100         (-[WebCoreResourceLoaderImp finishJobAndHandle:]):
 101         * dom/XMLTokenizer.cpp:
 102         (WebCore::openFunc):
 103         * loader/icon/IconLoader.cpp:
 104         (IconLoader::IconLoader):
 105         (IconLoader::~IconLoader):
 106         (IconLoader::startLoading):
 107         (IconLoader::stopLoading):
 108         (IconLoader::receivedData):
 109         * loader/icon/IconLoader.h:
 110         * loader/loader.cpp:
 111         (WebCore::Loader::servePendingRequests):
 112         * platform/ResourceLoader.cpp:
 113         (WebCore::ResourceLoader::create):
 114         (WebCore::ResourceLoader::kill):
 115         * platform/ResourceLoader.h:
 116         * platform/ResourceLoaderInternal.h:
 117         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
 118         * platform/mac/ResourceLoaderMac.mm:
 119         (WebCore::ResourceLoader::start):
 120         * xml/XSLTProcessor.cpp:
 121         (WebCore::docLoaderFunc):
 122         * xml/xmlhttprequest.cpp:
 123         (WebCore::XMLHttpRequest::send):
 124         * xml/xmlhttprequest.h:
 125
 126 2006-10-05  Eric Seidel  <eric@eseidel.com>
 127
 128         Reviewed by mjs.
 129
 130         Improve SVG opacity performance by clipping to the object bbox before starting a new opacity layer.
 131         http://bugs.webkit.org/show_bug.cgi?id=11163
 132
 133         No SVG performance tests yet.
 134
 135         * kcanvas/RenderForeignObject.cpp:
 136         (WebCore::RenderForeignObject::paint):
 137         * kcanvas/RenderSVGContainer.cpp:
 138         (WebCore::RenderSVGContainer::paint):
 139         * kcanvas/RenderSVGImage.cpp:
 140         (WebCore::RenderSVGImage::paint):
 141         * kcanvas/RenderSVGText.cpp:
 142         (WebCore::RenderSVGText::paint):
 143
 144 2006-10-05  Dave Hyatt  <hyatt@apple.com>
 145
 146         Stub out some stuff for widget focusability.
 147
 148         Reviewed by maciej
 149
 150         * page/FrameView.cpp:
 151         (WebCore::FrameView::dispatchMouseEvent):
 152         * platform/ScrollView.h:
 153         * platform/Widget.h:
 154
 155 2006-10-05  Adam Roben  <aroben@apple.com>
 156
 157         Reviewed by Maciej and Tim H.
 158
 159         Copy some WebKit frame lifetime logic into WebCore -- just a step
 160         along the path to frame lifetime being handled completely in WebCore.
 161
 162         * bridge/mac/FrameMac.mm:
 163         (WebCore::FrameMac::setView): Move platform-independent parts of this
 164         method into Frame.
 165         * page/Frame.cpp:
 166         (WebCore::Frame::setView): Adding platform-independent parts of
 167         FrameMac::setView
 168         (WebCore::Frame::detachChildren): New method to accomplish what
 169         -[WebFrameBridge _detachChildren] currently does.
 170         (WebCore::Frame::clear): Call detachChildren
 171         * page/Frame.h: Add declaration for detachChildren
 172
 173 2006-10-04  Alice Liu  <alice.liu@apple.com>
 174
 175         Reviewed by Darin.
 176
 177         Fixed <rdar://problem/4758577> REGRESSION: Business and People widgets fails to complete search query
 178
 179         * xml/xmlhttprequest.cpp:
 180         (WebCore::XMLHttpRequest::setRequestHeader):
 181         removed exception set when the request is not open yet
 182
 183 2006-10-04  Anders Carlsson  <acarlsson@apple.com>
 184
 185         Reviewed by John Sullivan.
 186
 187         <rdar://problem/4654328>
 188         Safari Crashes in WebCore::PluginTokenizer::writeRawData If I Try to Open a SWF File With Plug-ins Turned Off
 189
 190         * loader/PluginDocument.cpp:
 191         (WebCore::PluginTokenizer::writeRawData):
 192         Only send the data to the plug-in if plug-ins are enabled, otherwise just silently eat it.
 193
 194 2006-10-03  Alexey Proskuryakov  <ap@nypop.com>
 195
 196         Reviewed by Tim H.
 197
 198         http://bugs.webkit.org/show_bug.cgi?id=11130
 199         Convert "undefined" to AE missing value
 200
 201         * bridge/mac/WebCoreFrameBridge.mm:
 202         (aeDescFromJSValue): return missing value for UndefinedType.
 203
 204 2006-10-03  Dave Hyatt  <hyatt@apple.com>
 205
 206         Scrolling work.  Eliminate convertTo/FromContainingWindow as cross-platform functions.  Add back in
 207         the windowToContents/contentsToWindow functions.
 208
 209         Reviewed by anders
 210
 211         * bridge/mac/FrameMac.mm:
 212         (WebCore::FrameMac::eventMayStartDrag):
 213         (WebCore::FrameMac::dragHysteresisExceeded):
 214         (WebCore::FrameMac::mouseDown):
 215         (WebCore::FrameMac::shouldDragAutoNode):
 216         (WebCore::FrameMac::sendContextMenuEvent):
 217         * bridge/mac/FrameViewMac.mm:
 218         (WebCore::FrameView::passMousePressEventToScrollbar):
 219         * bridge/mac/WebCoreFrameBridge.mm:
 220         (-[WebCoreFrameBridge _visiblePositionForPoint:]):
 221         * dom/EventTargetNode.cpp:
 222         (WebCore::EventTargetNode::dispatchMouseEvent):
 223         (WebCore::EventTargetNode::dispatchWheelEvent):
 224         * page/Frame.cpp:
 225         (WebCore::Frame::selectClosestWordFromMouseEvent):
 226         (WebCore::Frame::handleMousePressEventTripleClick):
 227         (WebCore::Frame::handleMousePressEventSingleClick):
 228         (WebCore::Frame::handleMouseMoveEvent):
 229         (WebCore::Frame::handleMouseReleaseEvent):
 230         * page/FrameView.cpp:
 231         (WebCore::FrameView::handleMousePressEvent):
 232         (WebCore::FrameView::handleMouseDoubleClickEvent):
 233         (WebCore::selectCursor):
 234         (WebCore::FrameView::handleMouseMoveEvent):
 235         (WebCore::FrameView::handleMouseReleaseEvent):
 236         (WebCore::FrameView::dispatchDragEvent):
 237         (WebCore::FrameView::prepareMouseEvent):
 238         (WebCore::FrameView::handleWheelEvent):
 239         * page/FrameView.h:
 240         * platform/ScrollBar.cpp:
 241         (WebCore::ScrollBar::setValue):
 242         * platform/ScrollView.h:
 243         * platform/Widget.h:
 244         (WebCore::Widget::scrolled):
 245         * platform/mac/ScrollViewMac.mm:
 246         (WebCore::ScrollView::contentsToWindow):
 247         (WebCore::ScrollView::windowToContents):
 248         (WebCore::ScrollView::scrollbarUnderMouse):
 249         * platform/mac/WidgetMac.mm:
 250         * rendering/RenderLayer.cpp:
 251         (WebCore::RenderLayer::resize):
 252         (WebCore::RenderLayer::positionScrollbars):
 253         * rendering/RenderReplaced.cpp:
 254         (WebCore::RenderReplaced::shouldPaint):
 255         * rendering/RenderView.cpp:
 256         * rendering/RenderView.h:
 257         * rendering/RenderWidget.cpp:
 258         (WebCore::RenderWidget::setWidget):
 259
 260 2006-09-26  David Smith  <catfish.man@gmail.com>
 261
 262         Reviewed by Timothy.
 263
 264         http://bugs.webkit.org/show_bug.cgi?id=3723
 265         Add -scrollDOMRangeToVisible:
 266
 267         No automated tests are possible as this code path isn't reachable from JavaScript.
 268
 269         * bridge/mac/WebCoreFrameBridge.h:
 270         * bridge/mac/WebCoreFrameBridge.mm:
 271         (-[WebCoreFrameBridge scrollDOMRangeToVisible:]):
 272
 273 2006-10-03  Graham Dennis  <graham.dennis@gmail.com>
 274
 275         Reviewed by Timothy.
 276
 277         <http://bugs.webkit.org/show_bug.cgi?id=10338>
 278         When contentEditable, cursor doesn't change to hand
 279
 280         Allow the behaviour of editable links to be specified by a WebPreference
 281         The preference WebKitEditableLinkBehavior has four options:
 282          - AlwaysLive: Safari 2.0 behaviour
 283          - OnlyLiveWithShiftKey: Firefox/WinIE behaviour (and prior WebKit-ToT behaviour)
 284          - LiveWhenNotFocused: Editable links are live only when their editable block is not
 285              focused, or when the shift key is pressed
 286          - DefaultBehavior: This is the same as OnlyLiveWithShiftKey.
 287
 288         No layout tests, just a modification of a manual-test as it isn't possible to test
 289         this automatically.
 290
 291         * bridge/mac/WebCoreSettings.h:
 292         * bridge/mac/WebCoreSettings.mm:
 293         (-[WebCoreSettings setEditableLinkBehavior:]):
 294         (-[WebCoreSettings editableLinkBehavior]):
 295         * html/HTMLAnchorElement.cpp:
 296         (WebCore::HTMLAnchorElement::HTMLAnchorElement):
 297         (WebCore::HTMLAnchorElement::defaultEventHandler):
 298         (WebCore::HTMLAnchorElement::setActive):
 299         * html/HTMLAnchorElement.h:
 300         * manual-tests/contenteditable-link.html:
 301         * page/FrameView.cpp:
 302         (WebCore::nodeIsNotBeingEdited):
 303         (WebCore::selectCursor):
 304         * page/Settings.h:
 305         (WebCore::Settings::):
 306         (WebCore::Settings::Settings):
 307         (WebCore::Settings::editableLinkBehavior):
 308         (WebCore::Settings::setEditableLinkBehavior):
 309
 310 2006-10-03  Beth Dakin  <bdakin@apple.com>
 311
 312         Reviewed Darin.
 313
 314         No test cases needed.
 315
 316         Implemented a version of StringImpl::append that takes a UChar* and
 317         a length.
 318
 319         * platform/StringImpl.cpp:
 320         (WebCore::StringImpl::append):
 321         (WebCore::StringImpl::insert): Call new append instead of making a
 322         new StringImpl.
 323         * platform/StringImpl.h:
 324
 325 2006-10-03  MorganL  <morganl.webkit@yahoo.com>
 326
 327         Reviewed by Darin.
 328
 329         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11099
 330         HttpSendRequestEx results in ERROR_HTTP_HEADER_NOT_FOUND
 331
 332         * platform/win/ResourceLoaderWin.cpp:
 333         (WebCore::ResourceLoader::onHandleCreated):
 334
 335 2006-10-02  Geoffrey Garen  <ggaren@apple.com>
 336
 337         Feared, loathed, reviewed by Darin.
 338
 339         More frame/iframe merging. Merged IFRAME::willRemove and IFRAME::detach
 340         into FRAME, plus other cleanup.
 341
 342         No new behavior, so no new test. Layout tests pass. Basic browsing and
 343         Mail editing seem to work.
 344
 345         * dom/Node.cpp:
 346         (WebCore::Node::detach): Removed random commented-out code.
 347         * html/HTMLFrameElement.cpp:
 348         (WebCore::HTMLFrameElement::isURLAllowed):
 349         (1) Removed reference to FrameView, to dissociate frame loading from rendering.
 350         (2) Renamed newURL to completeURL because the difference between newURL
 351         and URLString is that newURL is a KURL that is the complete version of URLString,
 352         not that it is new.
 353         (WebCore::HTMLFrameElement::willRemove):
 354         (1) Removed close() call and moved close() code into willRemove(), also removing
 355         close() call from detach(), since willRemove is the well-defined place
 356         from DOM tear-down, not detach().
 357         (2) Removed manual renderer detach code because the DOM is not responsible
 358         for managing the render tree. I confirmed that this change not
 359         regress <rdar://problem/4132581>.
 360         (3) Removed questionable ASSERT. The ASSERT assumed that iframe elements
 361         lost their content frames after being removed from the DOM. That's our
 362         current behavior, but it's going to change in future rounds of refactoring.
 363         This also fixes <rdar://problem/4750835>.
 364         (WebCore::HTMLFrameElement::setLocation): Removed wacky manual calls to
 365         attach/detach, because the render tree should not be in charge of deciding
 366         when to load.
 367         * html/HTMLFrameElement.h:
 368         * html/HTMLIFrameElement.cpp:
 369         (WebCore::HTMLIFrameElement::attach): Renamed renderPart to renderPartObject,
 370         because the renderer is a renderPartObject, not a renderPart.
 371         * html/HTMLIFrameElement.h:
 372
 373 2006-10-03  Mark Rowe  <bdash@webkit.org>
 374
 375         Reviewed by Mitz.
 376
 377         http://bugs.webkit.org/show_bug.cgi?id=11137
 378         Bug 11137: GdkLauncher dies with "pure virtual method called" if
 379         window is closed while page still loading
 380
 381         * platform/gdk/FrameGdk.cpp:
 382         (WebCore::FrameGdk::~FrameGdk): Call cancelAndClear to allow virtual
 383         methods to be called before the FrameGdk portion of "this" is torn down.
 384
 385 2006-10-03  Adam Roben  <aroben@apple.com>
 386
 387         Reviewed by Darin.
 388
 389         Handle tab key presses in the DOM.
 390
 391         * dom/EventTargetNode.cpp:
 392         (WebCore::EventTargetNode::defaultEventHandler): Add tab key handling.
 393         * page/FrameView.cpp:
 394         (WebCore::FrameView::advanceFocus): Rename and reimplement
 395         focusNextPrevNode. Now we just call Element::focus().
 396         * page/FrameView.h: Rename focusNextPrevNode to advanceFocus and make
 397         it public.
 398
 399 2006-10-03  Justin Garcia  <justin.garcia@apple.com>
 400
 401         Reviewed by mjs
 402
 403         <rdar://problem/4760612>
 404         TOT REGRESSION: Repro assertion failure when forwarding draft in Range::compareBoundaryPoints
 405
 406         No layout test possible, attributedStringFrom:(DOMNode*)...etc isn't available to DRT.
 407
 408         * dom/Range.cpp:
 409         (WebCore::Range::boundaryPointsValid): compareBoundaryPoints asserts that the incoming
 410         positions are non-null since most of it's callers would be in a bad state if the positions
 411         were null.  boundaryPointsValid, which calls compareBoundaryPoints, is an exception.
 412         Instead of removing the assert I've added nil checks in boundaryPointsValid, to keep it
 413         from entering compareBoundaryPoints and hitting the assert.
 414
 415 2006-10-03  Adele Peterson  <adele@apple.com>
 416
 417         Reviewed by Geoff.
 418
 419         Make code for turning off new listbox implementation mac-only, since there's no implementation on other platforms.
 420
 421         * html/HTMLSelectElement.cpp:
 422         (WebCore::HTMLSelectElement::recalcStyle):
 423         (WebCore::HTMLSelectElement::isKeyboardFocusable):
 424         (WebCore::HTMLSelectElement::isMouseFocusable):
 425         (WebCore::HTMLSelectElement::createRenderer):
 426         (WebCore::HTMLSelectElement::setRecalcListItems):
 427         (WebCore::HTMLSelectElement::notifyOptionSelected):
 428         (WebCore::HTMLSelectElement::defaultEventHandler):
 429
 430 2006-10-04  Darin Adler  <darin@apple.com>
 431
 432         Reviewed by Geoff.
 433
 434         - fix http://bugs.webkit.org/show_bug.cgi?id=11132
 435           Caret disappears when you're typing
 436
 437         * editing/SelectionController.cpp:
 438         (WebCore::SelectionController::setSelection): Remove unnecessary call to
 439         clearCaretRectIfNeeded. The recomputeCaretRect now takes care of this.
 440         (WebCore::SelectionController::recomputeCaretRect): Explicitly set m_needsLayout
 441         to false so we can get the old caret repaint rect. Later we need to change the
 442         design so getting the rect doesn't have a side effect of causing a layout without
 443         invalidation.
 444
 445 2006-10-03  David Harrison  <harrison@apple.com>
 446
 447         Reviewed by Maciej.
 448
 449         <rdar://problem/4671286> Candidate Window isn't displayed and only first candidate is displayed at typing location.
 450
 451         Updated test:
 452         * fast/text/justified-text-rect.html
 453
 454         * bridge/mac/WebCoreFrameBridge.mm:
 455         (-[WebCoreFrameBridge convertToNSRange:]):
 456         (-[WebCoreFrameBridge convertToDOMRange:]):
 457         Make the selection's root editable element (or the document itself) be
 458         the basis for NSRange conversions. This supports "shadow DOM" like
 459         that for text fields and text areas.
 460
 461         * editing/CompositeEditCommand.cpp:
 462         (WebCore::CompositeEditCommand::moveParagraphs):
 463         Pass the document element as the scope.
 464
 465         * editing/TextIterator.cpp:
 466         (WebCore::TextIterator::rangeFromLocationAndLength):
 467         Make the first parameter the scope.
 468
 469         * editing/TextIterator.h:
 470         Make the first parameter of rangeFromLocationAndLength() the scope.
 471
 472 2006-10-03  Nikolas Zimmermann  <zimmermann@kde.org>
 473
 474         Reviewed by Eric.
 475
 476         Fix Qt/Linux build.
 477
 478         * CMakeLists.txt: Add counter related files.
 479
 480 2006-10-03  Mark Rowe  <bdash@webkit.org>
 481
 482         Reviewed by Eric.
 483
 484         http://bugs.webkit.org/show_bug.cgi?id=10981
 485         Linux/GDK build fixes
 486
 487         Based on a patch by Krzysztof Kowalczyk.
 488
 489         * WebCoreSources.bkl:
 490         * platform/gdk/FrameGdk.cpp:
 491         (WebCore::doScroll):
 492         (WebCore::FrameGdk::handleGdkEvent):
 493         * platform/gdk/PlatformScrollBar.h: Added.
 494         (WebCore::PlatformScrollBar::isWidget):
 495         * platform/gdk/ScrollViewGdk.cpp:
 496         * platform/gdk/TemporaryLinkStubs.cpp:
 497         (FrameView::passMousePressEventToScrollbar):
 498         (FrameView::passMousePressEventToSubframe):
 499         (FrameView::passMouseReleaseEventToSubframe):
 500         (FrameView::passMouseMoveEventToSubframe):
 501         (FrameView::passWheelEventToSubframe):
 502         (Cursor::Cursor):
 503         (Widget::invalidate):
 504         (Widget::invalidateRect):
 505         (ScrollView::wheelEvent):
 506         (ScrollView::convertToContainingWindow):
 507         (ScrollView::convertFromContainingWindow):
 508         (GraphicsContext::clip):
 509         (PlatformScrollBar::PlatformScrollBar):
 510         (PlatformScrollBar::updateThumbPosition):
 511         (PlatformScrollBar::updateThumbProportion):
 512         (ScrollBar::ScrollBar):
 513         (ScrollBar::setProportion):
 514         (WebCore::supportedKeySizes):
 515         (WebCore::signedPublicKeyAndChallengeString):
 516         * platform/gdk/WheelEventGdk.cpp:
 517         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
 518         * platform/gdk/WidgetGdk.cpp:
 519         (WebCore::Widget::convertToContainingWindow):
 520         (WebCore::Widget::convertFromContainingWindow):
 521
 522 2006-10-02  Adam Roben  <aroben@apple.com>
 523
 524         Reviewed by Maciej.
 525
 526         Let Windows determine which mouse button is pressed.
 527
 528         * platform/PlatformMouseEvent.h: Add message parameter to constructor.
 529         * platform/win/MouseEventWin.cpp:
 530         (WebCore::PlatformMouseEvent::PlatformMouseEvent): Use message
 531         parameter to determine which mouse button is pressed.
 532
 533 2006-10-02  Justin Garcia  <justin.garcia@apple.com>
 534
 535         Reviewed by anders
 536
 537         Build fix
 538
 539         * editing/SelectionController.cpp:
 540         (WebCore::SelectionController::empty):
 541         * editing/SelectionController.h:
 542
 543 2006-10-02  Justin Garcia  <justin.garcia@apple.com>
 544
 545         Reviewed by john
 546
 547         <rdar://problem/4755287>
 548         Writely Editor: Crash occurs at WebCore::maxDeepOffset(WebCore::Node const*) when attempting to create a OL/UL following a HR element
 549
 550         * editing/markup.cpp:
 551         (WebCore::createMarkup): Migrate to isBlock (isBlockFlow is true for inline replaced
 552         elements).  Don't skip blocks that aren't containers (like horizontal rules).
 553
 554 2006-10-03  Darin Adler  <darin@apple.com>
 555
 556         Reviewed by Justin Garcia.
 557
 558         - correct mistaken code that would restart blinking every
 559           time "invalidateSelection" is called even if the caret
 560           has not moved
 561
 562         * editing/SelectionController.h:
 563         * editing/SelectionController.cpp:
 564         (WebCore::SelectionController::setSelection): Update for name change.
 565         (WebCore::SelectionController::recomputeCaretRect): New function.
 566         Computes caret rect and does any necessary invalidation if the rect
 567         changes.
 568         (WebCore::SelectionController::invalidateCaretRect): Renamed from
 569         needsCaretRepaint. Invalidates the caret rect unconditionally. Also
 570         calls recomputeCaretRect as a side effect.
 571
 572         * page/Frame.cpp:
 573         (WebCore::Frame::invalidateSelection): Remove unneeded call to
 574         clearCaretRectIfNeeded.
 575         (WebCore::Frame::clearCaretRectIfNeeded): Updated for name change.
 576         (WebCore::Frame::selectionLayoutChanged): Restructured to use the new
 577         recomputeCaretRect function and not restart blinking if caret has
 578         not changed position.
 579         (WebCore::Frame::caretBlinkTimerFired): Removed some checks that
 580         are not needed since selectionLayoutChanged already checks these.
 581
 582         * page/FramePrivate.h: Removed unused m_blinkCaret.
 583
 584 2006-10-02  Beth Dakin  <bdakin@apple.com>
 585
 586         Reviewed by Adam.
 587
 588         Build fix. Add counters to vcproj.
 589
 590         * WebCore.vcproj/WebCore/WebCore.vcproj:
 591
 592 2006-10-02  Brady Eidson  <beidson@apple.com>
 593
 594         Reviewed by Adele
 595
 596         If the Icon DB schema changes underneath you, the latest ToT can crash and burn when writing
 597         icon data out because we don't correctly check SQL error conditions.
 598
 599         * loader/icon/IconDataCache.cpp:
 600         (WebCore::IconDataCache::writeToDatabase):
 601
 602 2006-10-02  Steve Falkenburg  <sfalken@apple.com>
 603
 604         Reviewed by Hyatt.
 605
 606         Added method to find out whether a layout has occurred.
 607
 608         * page/FrameView.cpp:
 609         (WebCore::FrameView::didFirstLayout):
 610         * page/FrameView.h:
 611
 612 2006-10-02  Beth Dakin  <bdakin@apple.com>
 613
 614         Reviewed by Darin.
 615
 616         Initial implementation of CSS2 counters. See http://
 617         bugs.webkit.org/show_bug.cgi?id=4980 for more details.
 618
 619         * WebCore.xcodeproj/project.pbxproj:
 620         * css/CSSComputedStyleDeclaration.cpp:
 621         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return
 622         the increment/reset list now that this is implemented.
 623         * css/CSSPrimitiveValue.cpp:
 624         (WebCore::CSSPrimitiveValue::cssText):
 625         * css/Counter.h:
 626         (WebCore::Counter::Counter):
 627         (WebCore::Counter::~Counter):
 628         (WebCore::Counter::identifier):
 629         (WebCore::Counter::listStyle):
 630         (WebCore::Counter::separator):
 631         (WebCore::Counter::listStyleNumber):
 632         (WebCore::Counter::setIdentifier):
 633         (WebCore::Counter::setListStyle):
 634         (WebCore::Counter::setSeparator):
 635         * css/cssparser.cpp:
 636         (WebCore::CSSParser::addProperty): Take care of reset/increment
 637         (WebCore::CSSParser::parseValue):
 638         (WebCore::CSSParser::parseContent): content can now take counters
 639         (WebCore::CSSParser::parseCounterContent): Parse counter() and
 640         counters()
 641         (WebCore::CSSParser::parseCounter): Parse counter-reset and
 642         counter-increment
 643         * css/cssparser.h:
 644         * css/cssstyleselector.cpp:
 645         (WebCore::CSSStyleSelector::matchUARules):
 646         (WebCore::CSSStyleSelector::applyProperty):
 647         * platform/PlatformString.h:
 648         * platform/String.cpp:
 649         (WebCore::String::insert): Implemented a version of insert that
 650         accepts a UChar* and a length.
 651         * platform/StringImpl.cpp:
 652         (WebCore::StringImpl::insert): Same as above.
 653         * platform/StringImpl.h:
 654         * rendering/CounterListItem.h: Added.
 655         * rendering/CounterNode.cpp: Added.
 656         (WebCore::CounterNode::CounterNode):
 657         (WebCore::CounterNode::insertAfter):
 658         (WebCore::CounterNode::removeChild):
 659         (WebCore::CounterNode::remove):
 660         (WebCore::CounterNode::setUsesSeparator):
 661         (WebCore::CounterNode::recountAndGetNext):
 662         (WebCore::CounterNode::recountTree):
 663         (WebCore::CounterNode::setSelfDirty):
 664         (WebCore::CounterNode::setParentDirty):
 665         * rendering/CounterNode.h: Added.
 666         (WebCore::CounterNode::~CounterNode):
 667         (WebCore::CounterNode::parent):
 668         (WebCore::CounterNode::previousSibling):
 669         (WebCore::CounterNode::nextSibling):
 670         (WebCore::CounterNode::firstChild):
 671         (WebCore::CounterNode::lastChild):
 672         (WebCore::CounterNode::value):
 673         (WebCore::CounterNode::setValue):
 674         (WebCore::CounterNode::count):
 675         (WebCore::CounterNode::setCount):
 676         (WebCore::CounterNode::setHasSeparator):
 677         (WebCore::CounterNode::isReset):
 678         (WebCore::CounterNode::hasSeparator):
 679         (WebCore::CounterNode::willNeedLayout):
 680         (WebCore::CounterNode::setWillNeedLayout):
 681         (WebCore::CounterNode::isRoot):
 682         (WebCore::CounterNode::setRenderer):
 683         (WebCore::CounterNode::renderer):
 684         * rendering/CounterResetNode.cpp: Added.
 685         (WebCore::CounterResetNode::CounterResetNode):
 686         (WebCore::CounterResetNode::insertAfter):
 687         (WebCore::CounterResetNode::removeChild):
 688         (WebCore::CounterResetNode::recountAndGetNext):
 689         (WebCore::CounterResetNode::setParentDirty):
 690         (WebCore::CounterResetNode::updateTotal):
 691         * rendering/CounterResetNode.h: Added.
 692         (WebCore::CounterResetNode::firstChild):
 693         (WebCore::CounterResetNode::lastChild):
 694         (WebCore::CounterResetNode::isReset):
 695         (WebCore::CounterResetNode::total):
 696         * rendering/RenderContainer.cpp:
 697         (WebCore::RenderContainer::updatePseudoChildForObject): Account for
 698         counter content.
 699         * rendering/RenderCounter.cpp: Added.
 700         (WebCore::RenderCounter::RenderCounter):
 701         (WebCore::RenderCounter::layout):
 702         (WebCore::toRoman):
 703         (WebCore::toLetterString):
 704         (WebCore::toHebrew):
 705         (WebCore::RenderCounter::convertValueToType):
 706         (WebCore::RenderCounter::calcMinMaxWidth):
 707         * rendering/RenderCounter.h: Added.
 708         (WebCore::RenderCounter::renderName):
 709         (WebCore::RenderCounter::isCounter):
 710         * rendering/RenderObject.cpp:
 711         (WebCore::getRenderObjectsToCounterNodeMaps): Maps RenderObjects to
 712         maps of CounterNodes
 713         (WebCore::RenderObject::RenderObject):
 714         (WebCore::RenderObject::destroy): Destroy the maps.
 715         (WebCore::RenderObject::findCounter): Finds/creates counters.
 716         * rendering/RenderObject.h:
 717         (WebCore::RenderObject::isCounter):
 718         * rendering/RenderStyle.cpp:
 719         (WebCore::StyleVisualData::StyleVisualData):
 720         (WebCore::RenderStyle::arenaDelete):
 721         (WebCore::RenderStyle::RenderStyle):
 722         (WebCore::RenderStyle::diff):
 723         (WebCore::RenderStyle::setContent):
 724         (WebCore::ContentData::clearContent):
 725         (WebCore::RenderStyle::counterDataEquivalent):
 726         (WebCore::hasCounter):
 727         (WebCore::RenderStyle::hasCounterReset):
 728         (WebCore::RenderStyle::hasCounterIncrement):
 729         (WebCore::readCounter):
 730         (WebCore::RenderStyle::counterReset):
 731         (WebCore::RenderStyle::counterIncrement):
 732         * rendering/RenderStyle.h:
 733         (WebCore::StyleVisualData::operator==):
 734         (WebCore::CounterData::CounterData):
 735         (WebCore::CounterData::identifier):
 736         (WebCore::CounterData::listStyle):
 737         (WebCore::CounterData::separator):
 738         (WebCore::ContentData::contentCounter):
 739         (WebCore::ContentData::):
 740         (WebCore::RenderStyle::counterIncrement):
 741         (WebCore::RenderStyle::counterReset):
 742         (WebCore::RenderStyle::setCounterIncrement):
 743         (WebCore::RenderStyle::setCounterReset):
 744         (WebCore::RenderStyle::setCounterResetList):
 745         (WebCore::RenderStyle::setCounterIncrementList):
 746         (WebCore::RenderStyle::counterResetValueList):
 747         (WebCore::RenderStyle::counterIncrementValueList):
 748
 749 2006-10-02  Adele Peterson  <adele@apple.com>
 750
 751         Reviewed by Adam.
 752
 753         - Fix for <rdar://problem/4463841> Switch to use new list box implementation for <select multiple>
 754
 755         There are a few outstanding issues, so I've left the old code in for now.  So you can use the old-style listboxes
 756         by using "-webkit-appearance:none".
 757
 758         * css/html4.css:
 759
 760 2006-10-02  David Harrison  <harrison@apple.com>
 761
 762         Reverted the code part of r16696, my patch for <rdar://problem/4641262>, because the problem was
 763         addressed at a deeper level by r16696, the patch for <http://bugs.webkit.org/show_bug.cgi?id=10842>.
 764         Left the layout test.
 765
 766         * rendering/bidi.cpp:
 767         (WebCore::checkMidpoints):
 768
 769 2006-10-02  Nikolas Zimmermann  <zimmermann@kde.org>
 770
 771         Reviewed by eseidel.  Landed by eseidel.
 772
 773         Fix Qt/Linux build.
 774
 775         * platform/qt/TemporaryLinkStubs.cpp: s/DeprecatedStringList/Vector<String>/
 776         (WebCore::supportedKeySizes):
 777
 778 2006-10-02  Nikolas Zimmermann <zimmermann@kde.org>
 779
 780         Reviewed by eseidel & mjs.  Landed by eseidel.
 781
 782         Fix Qt/Linux build with older gcc 3.3.4.
 783         http://bugs.webkit.org/show_bug.cgi?id=11116
 784
 785         As discussed with Maciej, the GCC_ROOT_NS_HACK
 786         can be completely removed, as well as the friendship
 787         between cacheGlobalObject & the JS* objects.
 788
 789         * bindings/scripts/CodeGeneratorJS.pm: Remove friendship.
 790         * platform/image-decoders/png/pnggccrd.c: Fix comments for gcc3.
 791         (png_read_filter_row_mmx_avg):
 792         * platform/image-decoders/png/pngvcrd.c: Ditto.
 793         (png_mmx_support):
 794         (png_read_filter_row_mmx_avg):
 795
 796 2006-10-01  Maciej Stachowiak  <mjs@apple.com>
 797
 798         Rubber stamped by Alexey.
 799
 800         - reverted fix for http://bugs.webkit.org/show_bug.cgi?id=10893 since it led to layout test crashes
 801
 802         * css/CSSGrammar.y:
 803
 804 2006-10-01  Eric Seidel  <eric@webkit.org>
 805
 806         Reviewed by mjs.
 807
 808         Eliminate a few more hotspots in SVG drawing code.
 809
 810         No test cases were harmed in the making of this patch.  (And SVG has no perf tests.)
 811
 812         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
 813         (WebCore::KRenderingPaintServerSolidQuartz::setup): use a single shared colorspace, avoid a few mallocs
 814         * platform/mac/ColorMac.mm:
 815         (+[WebCoreControlTintObserver WebCore]): store a single shared colorspace instance
 816
 817 2006-10-01  Geoffrey Garen  <ggaren@apple.com>
 818
 819         Reviewed by Maciej.
 820
 821         More frame/iframe merging.
 822
 823         - Removed needWidgetUpdate and related code. needWidgetUpdate is always
 824         false, so this was dead code.
 825         - Removed FIXME about setInViewSourceMode inside openURL(). openURL(), rather
 826         than attach(), is the correct place for setInViewSourceMode, because
 827         openURL() is the function that creates our frame.
 828         - Moved IFRAME insertedIntoDocument() code into FRAME, and removed FRAME
 829         code that did the same thing in other places.
 830         - Made FRAME's attach() method suffuciently generic so that IFRAME could
 831         call up to it, rather than skipping its superclass and calling up directly
 832         to ELEMENT.
 833         - Changed a few IFRAME up-calls to ELEMENT into up-calls to FRAME.
 834         - Replaced ad hoc frame loading code in FRAME::attach() with call to
 835         openURL(), the designated frame loading function.
 836
 837         Layout tests pass. I added a layout test for viewsource mode, since I
 838         broke it in the course of writing this patch.
 839
 840 2006-10-01  Anders Carlsson  <acarlsson@apple.com>
 841
 842         Reviewed by Geoff.
 843
 844         * dom/Document.cpp:
 845         (WebCore::Document::recalcStyleSelector):
 846         * dom/Document.h:
 847         Get rid of availableStyleSheets() and remove DeprecatedStringList.h include.
 848
 849         * dom/Node.h:
 850         Remove DeprecatedStringList class forward declaration.
 851
 852         * editing/markup.cpp:
 853         Include DeprecatedStringList.h here since it's not included by Document.h anymore.
 854
 855         * kcanvas/KCanvasTreeDebug.cpp:
 856         * kcanvas/KCanvasTreeDebug.h:
 857         Remove unused functions.
 858
 859         * loader/loader.cpp:
 860         * page/Frame.cpp:
 861         * page/Frame.h:
 862         * page/FrameView.h:
 863         Fixup DeprecatedStringList.h includes.
 864
 865 2006-09-30  David Harrison  <harrison@apple.com>
 866
 867         Reviewed by John Sullivan.
 868
 869         <rdar://problem/4641262> REGRESSION: Japanese text corrupts on wrapping point
 870
 871         Problem was that the decision to trim was based only on whether the character
 872         is a soft hyphen, which caused pretty much any Japanese character to go.
 873         Changed to decide based on whether the character is ignorable whitespace.
 874
 875         Test:
 876         * fast/text/international/wrap-CJK-001.html
 877
 878         * rendering/bidi.cpp:
 879         (WebCore::isTrimmableChar):
 880         New. Checks whether character is whitespace that can be ignored
 881         according to the text node's style.
 882         trimmed from the end of wrapped line.
 883         (WebCore::checkMidpoints):
 884         Call isTrimmable() rather than checking for char != SOFT_HYPHEN.
 885
 886 2006-10-01  Anders Carlsson  <acarlsson@apple.com>
 887
 888         Reviewed by Mitz Pettel.
 889
 890         Convert the SVG code to use Vector<String> instead of DeprecatedStringList.
 891
 892         * ksvg2/svg/SVGColor.cpp:
 893         (WebCore::SVGColor::setRGBColor):
 894         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
 895         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
 896         (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
 897         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
 898         (WebCore::SVGFEGaussianBlurElement::parseMappedAttribute):
 899         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
 900         (SVGFESpecularLightingElement::parseMappedAttribute):
 901         * ksvg2/svg/SVGFETurbulenceElement.cpp:
 902         (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
 903         * ksvg2/svg/SVGLengthList.cpp:
 904         * ksvg2/svg/SVGNumberList.cpp:
 905         (SVGNumberList::parse):
 906         * ksvg2/svg/SVGNumberList.h:
 907         * ksvg2/svg/SVGPreserveAspectRatio.cpp:
 908         (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
 909         * ksvg2/svg/SVGStringList.cpp:
 910         (WebCore::SVGStringList::reset):
 911         * ksvg2/svg/SVGStringList.h:
 912         * ksvg2/svg/SVGTransformable.cpp:
 913         (SVGTransformable::parseTransformAttribute):
 914
 915 2006-10-01  Nikolas Zimmermann  <zimmermann@kde.org>
 916
 917         Reviewed by Eric, tweaked and landed by ap.
 918
 919         Fix Qt/Linux build.
 920
 921         * CMakeLists.txt:
 922         * platform/qt/PlatformScrollBar.h:
 923         * platform/qt/TemporaryLinkStubs.cpp:
 924         (WebCore::ScrollBar::ScrollBar):
 925         (WebCore::PlatformScrollBar::PlatformScrollBar):
 926         (FrameView::passMousePressEventToSubframe):
 927         (FrameView::passMouseMoveEventToSubframe):
 928         (FrameView::passMouseReleaseEventToSubframe):
 929         (FrameView::passWheelEventToSubframe):
 930         (FrameView::passMousePressEventToScrollbar):
 931         * ksvg2/svg/SVGDocument.h:
 932
 933 2006-10-01  Mitz Pettel  <opendarwin.org@mitzpettel.com>
 934
 935         Reviewed by Darin.
 936
 937         Fix for http://bugs.webkit.org/show_bug.cgi?id=10190
 938         REGRESSION: Repro crash when navigating away from an image document that hasn't finished loading
 939
 940         No test case added (probably requires new DumpRenderTree functionality)
 941
 942         * rendering/RenderImage.cpp:
 943         (WebCore::RenderImage::imageChanged): Added early return if the document is
 944         being destroyed.
 945
 946 2006-10-01  Graham Dennis  <graham.dennis@gmail.com>
 947
 948         Reviewed by Hyatt.
 949
 950         Fix for http://bugs.webkit.org/show_bug.cgi?id=10842
 951         REGRESSION (r15418): contenteditable div truncates rightmost Japanese character
 952
 953         Make sure we only break after a space (and not any other valid line-break) if
 954         the style is -webkit-line-break: after-white-space (e.g. for a contentEditable div).
 955         I also did a logic shuffle at Mitz's request to prevent doing an if on the same expression
 956         twice in quick succession.
 957
 958         * rendering/bidi.cpp:
 959         (WebCore::RenderBlock::findNextLineBreak):
 960
 961 2006-10-01  Alexey Proskuryakov  <ap@nypop.com>
 962
 963         Reviewed by Maciej and Darin.
 964
 965         http://bugs.webkit.org/show_bug.cgi?id=4372
 966         JavaScript document.write page form does not submit in Safari
 967
 968         Test: fast/forms/document-write.html
 969
 970         * page/Frame.cpp:
 971         (WebCore::Frame::submitForm): Don't check for parsing().
 972
 973 2006-10-01  Alexey Proskuryakov  <ap@nypop.com>
 974
 975         Build fix.
 976
 977         * bridge/mac/FrameViewMac.mm: Add missing #imports.
 978
 979 2006-10-01  Dave Hyatt  <hyatt@apple.com>
 980
 981         Refactor the code that passes mouse presses to the Mac scrollbar and make it cross-platform.
 982
 983         Reviewed by mitz
 984
 985         * bridge/mac/FrameMac.mm:
 986         (WebCore::FrameMac::passWidgetMouseDownEventToWidget):
 987         * bridge/mac/FrameViewMac.mm:
 988         (WebCore::FrameView::passMousePressEventToScrollbar):
 989         * page/FrameView.cpp:
 990         (WebCore::FrameView::handleMousePressEvent):
 991         (WebCore::FrameView::setMousePressed):
 992         * page/FrameView.h:
 993         * platform/win/TemporaryLinkStubs.cpp:
 994         (FrameView::passMousePressEventToScrollbar):
 995
 996 2006-09-30  Sam Weinig  <sam.weinig@gmail.com>
 997
 998         Reviewed by Darin.
 999
1000         Patch for http://bugs.webkit.org/show_bug.cgi?id=11102
1001         Add more SVG Objective-C DOM bindings
1002
1003         - Auto-generate Objective-C DOM bindings for DOMSVGAElement,
1004           DOMSVGAnimateColorElement, DOMSVGAnimateElement, DOMSVGAnimateTransformElement,
1005           DOMSVGAnimatedPathData, DOMSVGAnimatedPoints, DOMSVGAnimatedPreserveAspectRatio,
1006           DOMSVGAnimationElement, DOMSVGCircleElement, DOMSVGClipPathElement, DOMSVGColor,
1007           DOMSVGCursorElement, DOMSVGDefsElement, DOMSVGDescElement, DOMSVGDocument,
1008           DOMSVGEllipseElement, DOMSVGPreserveAspectRatio, and DOMSVGURIReference.
1009
1010         * DerivedSources.make:
1011         * WebCore.xcodeproj/project.pbxproj:
1012         * bindings/objc/DOMInternal.h:
1013         * bindings/objc/DOMSVG.h:
1014         * bindings/scripts/CodeGeneratorObjC.pm:
1015         * ksvg2/svg/SVGAElement.idl:
1016         * ksvg2/svg/SVGAnimateColorElement.idl:
1017         * ksvg2/svg/SVGAnimateElement.idl:
1018         * ksvg2/svg/SVGAnimateTransformElement.idl:
1019         * ksvg2/svg/SVGAnimatedPathData.idl:
1020         * ksvg2/svg/SVGAnimatedPoints.idl:
1021         * ksvg2/svg/SVGAnimatedPreserveAspectRatio.idl:
1022         * ksvg2/svg/SVGAnimationElement.idl:
1023         * ksvg2/svg/SVGCircleElement.idl:
1024         * ksvg2/svg/SVGClipPathElement.idl:
1025         * ksvg2/svg/SVGColor.idl:
1026         * ksvg2/svg/SVGCursorElement.idl:
1027         * ksvg2/svg/SVGDefsElement.idl:
1028         * ksvg2/svg/SVGDescElement.idl:
1029         * ksvg2/svg/SVGDocument.idl:
1030         * ksvg2/svg/SVGEllipseElement.idl:
1031         * ksvg2/svg/SVGPointList.idl:
1032         * ksvg2/svg/SVGPreserveAspectRatio.idl:
1033         * ksvg2/svg/SVGRect.idl:
1034         * ksvg2/svg/SVGSVGElement.idl:
1035
1036 2006-09-30  Maciej Stachowiak  <mjs@apple.com>
1037
1038         Reviewed by Adele.
1039
1040         - fix build
1041
1042         * platform/FloatRect.h:
1043         (WebCore::FloatRect::contains): Added; not exactly the same semantic as IntRect containment
1044         but more appropriate for path-type stuff.
1045         * platform/cg/PathCG.cpp:
1046         (WebCore::Path::contains): Don't use enclosingIntRect, just use FloatRect::contains.
1047
1048 2006-09-30  Alexey Proskuryakov  <ap@nypop.com>
1049
1050         Reviewed by Darin.
1051
1052         http://bugs.webkit.org/show_bug.cgi?id=11011
1053         External CSS is parsed as iso-8859-1 even though the main document is utf-8
1054
1055         Test: fast/encoding/css-charset-default.xhtml
1056
1057         * loader/CachedResourceClient.h:
1058         (WebCore::CachedResourceClient::setCSSStyleSheet):
1059         (WebCore::CachedResourceClient::setXSLStyleSheet):
1060         Divided setStyleSheet into setCSSStyleSheet and setXSLStyleSheet. The former
1061         takes an additional charset parameter, to be passed to CSSStyleSheet constructor.
1062
1063         * css/CSSImportRule.cpp:
1064         (WebCore::CSSImportRule::setCSSStyleSheet):
1065         (WebCore::CSSImportRule::insertedIntoParent): Default to parent stylesheet's charset.
1066         * css/CSSImportRule.h:
1067
1068         * css/CSSStyleSheet.cpp:
1069         (WebCore::CSSStyleSheet::CSSStyleSheet):
1070         * css/CSSStyleSheet.h:
1071         Added an m_charset member to be used when loading child stylesheets. Removed an unused m_implicit
1072         member. Changed some String parameters to const String&.
1073
1074         * css/StyleSheet.cpp:
1075         (WebCore::StyleSheet::StyleSheet):
1076         * css/StyleSheet.h:
1077         Changed some String parameters to const String&. Removed an unused (even unimplemented) constructor.
1078
1079         * css/StyleSheetList.cpp:
1080         (WebCore::StyleSheetList::length):
1081         (WebCore::StyleSheetList::item):
1082         * css/StyleSheetList.h:
1083         Special-casing implicit stylesheets seemed to be dead code, removed.
1084
1085         * dom/Document.cpp:
1086         (WebCore::Document::setCSSStyleSheet):
1087         (WebCore::Document::recalcStyleSelector):
1088         * dom/Document.h:
1089         Renamed setStyleSheet() to setCSSStyleSheet().
1090
1091         * dom/ProcessingInstruction.cpp:
1092         (WebCore::ProcessingInstruction::checkStyleSheet): Pass a correct charset to requestCSSStyleSheet().
1093         (WebCore::ProcessingInstruction::setCSSStyleSheet):
1094         (WebCore::ProcessingInstruction::setXSLStyleSheet):
1095         (WebCore::ProcessingInstruction::parseStyleSheet):
1096         * dom/ProcessingInstruction.h:
1097
1098         * html/HTMLLinkElement.cpp:
1099         (WebCore::HTMLLinkElement::process): Default to document encoding if a charset attribute
1100         is not specified.
1101         (WebCore::HTMLLinkElement::setCSSStyleSheet):
1102         * html/HTMLLinkElement.h:
1103
1104         * html/HTMLStyleElement.cpp:
1105         (WebCore::HTMLStyleElement::childrenChanged):
1106         * ksvg2/svg/SVGStyleElement.cpp:
1107         (WebCore::SVGStyleElement::childrenChanged):
1108         Inherit URL and charset from the document.
1109
1110         * loader/Cache.cpp:
1111         (WebCore::Cache::requestCSSStyleSheet):
1112         * loader/Cache.h:
1113         Adjust for setStyleSheet() renaming.
1114
1115         * loader/CachedCSSStyleSheet.h: Removed an unused constructor.
1116         * loader/CachedCSSStyleSheet.cpp:
1117         (WebCore::CachedCSSStyleSheet::ref):
1118         (WebCore::CachedCSSStyleSheet::deref):
1119         (WebCore::CachedCSSStyleSheet::checkNotify):
1120         Pass the encoding to setCSSStyleSheet().
1121
1122         * loader/CachedXSLStyleSheet.cpp:
1123         (WebCore::CachedXSLStyleSheet::ref):
1124         (WebCore::CachedXSLStyleSheet::checkNotify):
1125         * loader/DocLoader.cpp:
1126         (WebCore::DocLoader::requestCSSStyleSheet):
1127         * loader/DocLoader.h:
1128         * page/Frame.cpp:
1129         (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
1130         (WebCore::UserStyleSheetLoader::setCSSStyleSheet):
1131         * xml/XSLImportRule.cpp:
1132         (WebCore::XSLImportRule::setXSLStyleSheet):
1133         (WebCore::XSLImportRule::loadSheet):
1134         * xml/XSLImportRule.h:
1135         Adjust for setStyleSheet() renaming.
1136
1137 2006-09-30  Rob Buis  <buis@kde.org>
1138
1139         Reviewed by eseidel.
1140
1141         http://bugs.webkit.org/show_bug.cgi?id=11096
1142         Hit testing for polylines fails
1143
1144         Fix Path::contains so it handles filled, non-closed paths too.
1145
1146         * platform/cg/PathCG.cpp:
1147         (WebCore::Path::contains):
1148
1149 2006-09-30  Dave Hyatt  <hyatt@apple.com>
1150
1151         Refactor subframe event handling to hide more of the Mac-specific logic from the cross-platform code.
1152         Stub out a capturing API that mimics the way Web browsers capture events and route them to specific
1153         subframes while the mouse is down.
1154
1155         Reviewed by mitzpettel
1156
1157         * bridge/mac/FrameMac.h:
1158         * bridge/mac/FrameMac.mm:
1159         (WebCore::FrameMac::passWidgetMouseDownEventToWidget):
1160         (WebCore::FrameMac::passWheelEventToWidget):
1161         * bridge/mac/FrameViewMac.mm:
1162         (WebCore::FrameView::passMousePressEventToSubframe):
1163         (WebCore::FrameView::passMouseMoveEventToSubframe):
1164         (WebCore::FrameView::passMouseReleaseEventToSubframe):
1165         (WebCore::FrameView::passWheelEventToSubframe):
1166         * page/Frame.cpp:
1167         * page/Frame.h:
1168         * page/FrameView.cpp:
1169         (WebCore::subframeForTargetNode):
1170         (WebCore::FrameView::handleMousePressEvent):
1171         (WebCore::FrameView::handleMouseDoubleClickEvent):
1172         (WebCore::FrameView::handleMouseMoveEvent):
1173         (WebCore::FrameView::handleMouseReleaseEvent):
1174         (WebCore::FrameView::handleWheelEvent):
1175         * page/FrameView.h:
1176         * platform/ScrollBar.h:
1177         (WebCore::ScrollBar::handleMouseMoveEvent):
1178         (WebCore::ScrollBar::handleMouseOutEvent):
1179         * platform/Widget.h:
1180         (WebCore::Widget::handleMouseMoveEvent):
1181         (WebCore::Widget::handleMouseReleaseEvent):
1182         * platform/win/TemporaryLinkStubs.cpp:
1183         (FrameView::passMousePressEventToSubframe):
1184         (FrameView::passMouseMoveEventToSubframe):
1185         (FrameView::passMouseReleaseEventToSubframe):
1186         (FrameView::passWheelEventToSubframe):
1187         (Widget::capturingMouse):
1188         (Widget::setCapturingMouse):
1189         (Widget::capturingTarget):
1190         (Widget::capturingChild):
1191         (Widget::setCapturingChild):
1192         * rendering/RenderView.cpp:
1193         (WebCore::RenderView::paintBoxDecorations):
1194
1195 2006-09-29  MorganL  <morganl.webkit@yahoo.com>
1196
1197         Reviewed by Adele.
1198
1199         Fixes windows bustage:
1200         http://bugs.webkit.org/show_bug.cgi?id=11093
1201
1202         * platform/win/PlatformScrollBar.h:
1203         * platform/win/TemporaryLinkStubs.cpp:
1204         (PlatformScrollBar::PlatformScrollBar):
1205         (ScrollBar::ScrollBar):
1206
1207 2006-09-29  David Hyatt  <hyatt@apple.com>
1208
1209         Eliminate RenderLayer::gScrollBar in favor of caching the scrollbar hit
1210         in RenderObject::NodeInfo (and then propagating that Widget to
1211         MouseEventWithHitTestResults).
1212
1213         This allows RenderListBox and RenderBlock to do the same thing when the
1214         mouse is over the scrollbar.
1215
1216         Also land fix to support font-size: 0.
1217
1218         Reviewed by mjs (scrollbar), eric (font-size)
1219
1220         * dom/Document.cpp:
1221         (WebCore::Document::prepareMouseEvent):
1222         * page/Frame.cpp:
1223         (WebCore::Frame::passWidgetMouseDownEventToWidget):
1224         * page/FrameView.cpp:
1225         (WebCore::selectCursor):
1226         (WebCore::FrameView::handleMouseMoveEvent):
1227         (WebCore::FrameView::dispatchMouseEvent):
1228         * page/MouseEventWithHitTestResults.cpp:
1229         (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
1230         * page/MouseEventWithHitTestResults.h:
1231         (WebCore::MouseEventWithHitTestResults::scrollbar):
1232         * rendering/RenderBlock.cpp:
1233         (WebCore::RenderBlock::isPointInScrollbar):
1234         (WebCore::RenderBlock::nodeAtPoint):
1235         * rendering/RenderBlock.h:
1236         * rendering/RenderLayer.cpp:
1237         (WebCore::RenderLayer::hitTest):
1238         * rendering/RenderLayer.h:
1239         (WebCore::RenderLayer::getHiddenBehavior):
1240         * rendering/RenderListBox.cpp:
1241         (WebCore::RenderListBox::RenderListBox):
1242         (WebCore::RenderListBox::~RenderListBox):
1243         (WebCore::RenderListBox::isPointInScrollbar):
1244         * rendering/RenderListBox.h:
1245         * rendering/RenderObject.h:
1246         (WebCore::RenderObject::NodeInfo::NodeInfo):
1247         (WebCore::RenderObject::NodeInfo::scrollbar):
1248         (WebCore::RenderObject::NodeInfo::setScrollbar):
1249
1250 2006-09-29  MorganL  <morganl.webkit@yahoo.com>
1251
1252         Reviewed by Adele.
1253
1254         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11092
1255
1256         * platform/win/ScrollViewWin.cpp:
1257         (WebCore::ScrollView::convertToContainingWindow):
1258         (WebCore::ScrollView::convertFromContainingWindow):
1259         * platform/win/WidgetWin.cpp:
1260         (WebCore::Widget::convertToContainingWindow):
1261         (WebCore::Widget::convertFromContainingWindow):
1262
1263 2006-09-29  Adele Peterson  <adele@apple.com>
1264
1265         Updated with new argument for PlatformScrollBar.
1266
1267         * platform/win/TemporaryLinkStubs.cpp:
1268         (PlatformScrollBar::PlatformScrollBar):
1269
1270 2006-09-29  Adele Peterson  <adele@apple.com>
1271
1272         Reviewed by Hyatt.
1273
1274         Fixing build bustage with cast to int.
1275
1276         * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::lastSelectedListIndex):
1277
1278 2006-09-29  Adele Peterson  <adele@apple.com>
1279
1280         Fixing accidental include.
1281
1282         * rendering/RenderListBox.cpp:
1283
1284 2006-09-29  Adele Peterson  <adele@apple.com>
1285
1286         Adding RenderListBox files.
1287
1288         * WebCore.vcproj/WebCore/WebCore.vcproj:
1289
1290 2006-09-29  Adele Peterson  <adele@apple.com>
1291
1292         Reviewed by Adam.
1293
1294         Initial implementation of engine-based list box control.
1295
1296         * WebCore.xcodeproj/project.pbxproj: Added RenderListBox.h and RenderListBox.cpp
1297
1298         * bridge/mac/FrameMac.h: Added _mouseDownMayStartAutoscroll.
1299         * bridge/mac/FrameMac.mm: Updated autoscroll code to use renderers instead of layers, so any renderer that implements autoscroll will work.
1300         (WebCore::FrameMac::FrameMac):
1301         (WebCore::FrameMac::handleMousePressEvent):
1302         (WebCore::FrameMac::handleMouseMoveEvent):
1303         (WebCore::FrameMac::mouseDown):
1304
1305         * page/Frame.cpp:
1306         (WebCore::Frame::handleMouseMoveEvent):
1307         (WebCore::Frame::scrollOverflow): Don't scroll list box here- this would cause arrow keys to scroll instead of select.
1308         (WebCore::Frame::handleAutoscroll): Updated to use a renderer instead of a layer when setting up autoscroll.
1309         (WebCore::Frame::autoscrollTimerFired): ditto.
1310         (WebCore::Frame::stopAutoscrollTimer): ditto.
1311         (WebCore::Frame::passWidgetMouseDownEventToWidget): Updated to check for list box's scroll bar.
1312         * page/Frame.h:
1313         * page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Updated to use renderer unstead of layer for autoscroll.
1314
1315         * page/FrameView.cpp: Keep track of current mouse position so this can be used for list box autoscroll.
1316         (WebCore::FrameViewPrivate::reset):
1317         (WebCore::FrameView::currentMousePosition):
1318         (WebCore::FrameView::handleMousePressEvent):
1319         (WebCore::FrameView::handleMouseDoubleClickEvent):
1320         (WebCore::selectCursor):
1321         (WebCore::FrameView::handleMouseMoveEvent):
1322         (WebCore::FrameView::handleMouseReleaseEvent):
1323         * page/FrameView.h:
1324
1325         * platform/ScrollBar.cpp: (WebCore::ScrollBar::ScrollBar): Added controlSize argument.  The list box will use a smaller scroll bar size.
1326         * platform/ScrollBar.h:
1327         (WebCore::):
1328         (WebCore::ScrollBar::controlSize):
1329         * platform/mac/PlatformScrollBar.h:
1330         * platform/mac/PlatformScrollBarMac.mm:
1331         (NSControlSizeForScrollBarControlSize):
1332         (-[WebCoreScrollBar initWithPlatformScrollBar:]):
1333         (WebCore::PlatformScrollBar::PlatformScrollBar):
1334
1335         * rendering/RenderBlock.h:
1336         * rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): Updated to pass regular control size to scrollbar constructor.
1337         * rendering/RenderLayer.h:
1338         * rendering/RenderObject.cpp:
1339         (WebCore::RenderObject::shouldAutoscroll):
1340         (WebCore::RenderObject::autoscroll):
1341         * rendering/RenderObject.h: (WebCore::RenderObject::isListBox):
1342
1343         * css/html4.css: Added properties for new list boxes.
1344
1345         * html/HTMLOptionElement.cpp:
1346         (WebCore::HTMLOptionElement::setSelected): Doesn't allow selection to be changed here if the option is disabled.
1347         (WebCore::HTMLOptionElement::disabled): Added. Checks the parent's disabled status.
1348         * html/HTMLOptionElement.h: Added disabled method.
1349
1350         * html/HTMLSelectElement.cpp: Added appearance switch for new list box implementation.
1351         (WebCore::HTMLSelectElement::recalcStyle):
1352         (WebCore::HTMLSelectElement::lastSelectedListIndex):
1353         (WebCore::HTMLSelectElement::deselectItems):
1354         (WebCore::HTMLSelectElement::setSelectedIndex):
1355         (WebCore::HTMLSelectElement::isKeyboardFocusable):
1356         (WebCore::HTMLSelectElement::isMouseFocusable):
1357         (WebCore::HTMLSelectElement::createRenderer):
1358         (WebCore::HTMLSelectElement::recalcListItems):
1359         (WebCore::HTMLSelectElement::setRecalcListItems):
1360         (WebCore::HTMLSelectElement::reset):
1361         (WebCore::HTMLSelectElement::notifyOptionSelected):
1362         (WebCore::HTMLSelectElement::defaultEventHandler): Added code to select options for list box when clicking and using arrow keys.
1363         (WebCore::HTMLSelectElement::nextSelectableListIndex):
1364         (WebCore::HTMLSelectElement::previousSelectableListIndex):
1365         * html/HTMLSelectElement.h:
1366
1367         * rendering/RenderTheme.cpp: Added support for ListBoxAppearance
1368         (WebCore::RenderTheme::paint):
1369         (WebCore::RenderTheme::paintBorderOnly):
1370         (WebCore::RenderTheme::paintDecorations):
1371         (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
1372         (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
1373         (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
1374         (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
1375         (WebCore::RenderTheme::isControlStyled):
1376         (WebCore::RenderTheme::supportsFocusRing):
1377         * rendering/RenderTheme.h:
1378         * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled):
1379
1380         * rendering/RenderListBox.cpp: Added.
1381         (WebCore::RenderListBox::RenderListBox):
1382         (WebCore::RenderListBox::~RenderListBox):
1383         (WebCore::RenderListBox::setStyle):
1384         (WebCore::RenderListBox::updateFromElement):
1385         (WebCore::RenderListBox::calcMinMaxWidth):
1386         (WebCore::RenderListBox::size):
1387         (WebCore::RenderListBox::numItems):
1388         (WebCore::RenderListBox::calcHeight):
1389         (WebCore::RenderListBox::baselinePosition):
1390         (WebCore::RenderListBox::itemBoundingBoxRect):
1391         (WebCore::RenderListBox::paintObject):
1392         (WebCore::RenderListBox::paintScrollbar):
1393         (WebCore::RenderListBox::paintItemForeground):
1394         (WebCore::RenderListBox::paintItemBackground):
1395         (WebCore::RenderListBox::scrollBarTarget):
1396         (WebCore::RenderListBox::isPointInScrollbar):
1397         (WebCore::RenderListBox::optionAtPoint):
1398         (WebCore::RenderListBox::autoscroll):
1399         (WebCore::RenderListBox::scrollToRevealElementAtListIndex):
1400         (WebCore::RenderListBox::scroll):
1401         (WebCore::RenderListBox::valueChanged):
1402         * rendering/RenderListBox.h: Added.
1403         (WebCore::RenderListBox::isListBox):
1404         (WebCore::RenderListBox::selectionChanged):
1405         (WebCore::RenderListBox::setSelectionChanged):
1406         (WebCore::RenderListBox::canHaveChildren):
1407         (WebCore::RenderListBox::renderName):
1408         (WebCore::RenderListBox::setOptionsChanged):
1409         (WebCore::RenderListBox::shouldAutoscroll):
1410         (WebCore::RenderListBox::listIndexIsVisible):
1411
1412 2006-09-29  Beth Dakin  <bdakin@apple.com>
1413
1414         Reviewed by Darin.
1415
1416         We had a bug where html4.css was ignoring Media Queries. In the end
1417         the problem was that we were trying to send a char* to the
1418         MediaQueryEvaluator constructor that expects a String, but the
1419         char* got interpreted as a bool, the wrong constructor was called,
1420         and the media type was never set.
1421
1422         No test case possible since this only affects html4.css
1423
1424         * css/MediaQueryEvaluator.cpp: New constructor that expects takes a
1425         char*
1426         (WebCore::MediaQueryEvaluator):
1427         * css/MediaQueryEvaluator.h: Same.
1428
1429 2006-09-29  Geoffrey Garen  <ggaren@apple.com>
1430
1431         Reviewed by John, Maciej.
1432
1433         Integrated some frame and iframe code. I'm trying to fix up frame ownership
1434         and loading. Reducing the number of different code paths involved
1435         seemed like a good first step.
1436
1437         As a side effect, I fixed a bug where FRAME elements would report their
1438         src attributes as relative, rather than compelete, URLs. (IFRAME elements
1439         had the correct complete URL behavior.)
1440
1441         * html/HTMLFrameElement.cpp:
1442         (WebCore::HTMLFrameElement::isURLAllowed): Fixed comment typo
1443         (WebCore::HTMLFrameElement::openURL):
1444             (1) Removed checks that requestFrame does for us
1445             (2) Added isURLAllowed check, to have one clear bottleneck for it
1446             (3) Added viewsource check, to have one clear bottleneck for it
1447         (WebCore::HTMLFrameElement::close): Changed to use the common contentFrame()
1448         method, instead of finding our content frame in our own unique way.
1449         (WebCore::HTMLFrameElement::setLocation): Removed isURLAllowed check,
1450         since openURL does this for us now.
1451         (WebCore::HTMLFrameElement::src): Return complete URL instead of relative.
1452         This is what FF does, and it made no sense to have different behaviors
1453         for FRAME and IFRAME elements.
1454         * html/HTMLIFrameElement.cpp:
1455         (WebCore::HTMLIFrameElement::HTMLIFrameElement): Removed duplicate init
1456         code.
1457         * html/HTMLIFrameElement.h: Removed src() and openURL() methods, since
1458         HTMLFrameElement now does everything we need.
1459
1460 2006-09-30  Nikolas Zimmermann  <zimmermann@kde.org>
1461
1462         Reviewed by Hyatt.
1463
1464         Fix Qt/Linux build.
1465
1466         * CMakeLists.txt:
1467         * platform/qt/ScrollViewQt.cpp:
1468         (WebCore::ScrollView::convertToContainingWindow):
1469         (WebCore::ScrollView::convertFromContainingWindow):
1470         * platform/qt/TemporaryLinkStubs.cpp:
1471         (WebCore::signedPublicKeyAndChallengeString):
1472         * platform/qt/WidgetQt.cpp:
1473         (WebCore::Widget::convertToContainingWindow):
1474         (WebCore::Widget::convertFromContainingWindow):
1475
1476 2006-09-29  Sam Weinig  <sam.weinig@gmail.com>
1477
1478         Reviewed by Tim H.
1479
1480         Patch for http://bugs.webkit.org/show_bug.cgi?id=11082
1481         Simplify Internal methods for the auto-generated Objective-C DOM code
1482
1483         - Auto-generate the internal methods for more Objective-C classes.
1484
1485         * WebCore.xcodeproj/project.pbxproj:
1486         * bindings/objc/DOM.mm:
1487         * bindings/objc/DOMCSS.mm:
1488         (-[DOMStyleSheet WebCore::]):
1489         (+[DOMStyleSheet _styleSheetWith:WebCore::]):
1490         (-[DOMCSSRule WebCore::]):
1491         (-[DOMCSSRule _initWithCSSRule:WebCore::]):
1492         (+[DOMCSSRule _CSSRuleWith:WebCore::]):
1493         (-[DOMCSSValue WebCore::]):
1494         (-[DOMCSSValue _initWithCSSValue:WebCore::]):
1495         (+[DOMCSSValue _CSSValueWith:WebCore::]):
1496         * bindings/objc/DOMHTMLAppletElement.mm:
1497         (-[DOMHTMLAppletElement WebCore::]):
1498         (+[DOMHTMLAppletElement _HTMLOptionElementWith:WebCore::]):
1499         * bindings/objc/DOMHTMLEmbedElement.mm:
1500         (-[DOMHTMLEmbedElement WebCore::]):
1501         (+[DOMHTMLEmbedElement _HTMLEmbedElementWith:WebCore::]):
1502         * bindings/objc/DOMInternal.h:
1503         * bindings/objc/DOMInternal.mm:
1504         * bindings/scripts/CodeGeneratorObjC.pm:
1505         * css/CSSCharsetRule.idl:
1506         * css/CSSFontFaceRule.idl:
1507         * css/CSSImportRule.idl:
1508         * css/CSSMediaRule.idl:
1509         * css/CSSPageRule.idl:
1510         * css/CSSPrimitiveValue.idl:
1511         * css/CSSStyleRule.idl:
1512         * css/CSSStyleSheet.idl:
1513         * css/CSSUnknownRule.idl:
1514         * css/CSSValueList.idl:
1515         * dom/KeyboardEvent.idl:
1516         * dom/MouseEvent.idl:
1517         * dom/MutationEvent.idl:
1518         * dom/NodeIterator.idl:
1519         * dom/OverflowEvent.idl:
1520         * dom/UIEvent.idl:
1521         * dom/WheelEvent.idl:
1522
1523 2006-09-29  David Harrison  <harrison@apple.com>
1524
1525         Reviewed by John Sullivan.
1526
1527         <rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
1528         <rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot
1529
1530         Test added
1531         * fast/text/attributed-substring-from-range-001.html
1532
1533         * bridge/mac/FrameMac.mm:
1534         (WebCore::FrameMac::attributedString):
1535         Handle non-zero offsets when start and/or end node is a container. Offset used to be ignored in this case.
1536         Also, add validation of the range.
1537
1538 2006-09-29  Rob Buis  <buis@kde.org>
1539
1540         Reviewed by Maciej.
1541
1542         http://bugs.webkit.org/show_bug.cgi?id=10893
1543         InsertRule can not handle @import statements
1544
1545         Allow @import as part of a css rule.
1546
1547         * css/CSSGrammar.y:
1548
1549 2006-09-28  David Hyatt  <hyatt@apple.com>
1550
1551         Switch over the Mac-specific uses of viewportToContents/contentsToViewport.
1552
1553         * bridge/mac/FrameMac.mm:
1554         (WebCore::FrameMac::eventMayStartDrag):
1555         (WebCore::FrameMac::dragHysteresisExceeded):
1556         (WebCore::FrameMac::mouseDown):
1557         (WebCore::FrameMac::shouldDragAutoNode):
1558         (WebCore::FrameMac::sendContextMenuEvent):
1559         * bridge/mac/WebCoreFrameBridge.mm:
1560         (-[WebCoreFrameBridge _visiblePositionForPoint:]):
1561
1562 2006-09-28  Dave Hyatt  <hyatt@apple.com>
1563
1564         This patch eliminates viewportToContents/contentsToViewport in favor of convertTo/FromContainingWindow.
1565         ScrollView now subclasses these methods to factor in its scrollOffset and to deal with the document
1566         view.
1567
1568         Reviewed by mjs (the convertTo/From changes), (I added the elimination of viewportToContents to
1569         the patch after review, once I realized that these new functions essentially do the same thing.)
1570
1571         * dom/EventTargetNode.cpp:
1572         (WebCore::EventTargetNode::dispatchMouseEvent):
1573         (WebCore::EventTargetNode::dispatchWheelEvent):
1574         * page/Frame.cpp:
1575         (WebCore::Frame::selectClosestWordFromMouseEvent):
1576         (WebCore::Frame::handleMousePressEventTripleClick):
1577         (WebCore::Frame::handleMousePressEventSingleClick):
1578         (WebCore::Frame::handleMouseMoveEvent):
1579         (WebCore::Frame::handleMouseReleaseEvent):
1580         * page/FrameView.cpp:
1581         (WebCore::FrameView::handleMousePressEvent):
1582         (WebCore::selectCursor):
1583         (WebCore::FrameView::dispatchDragEvent):
1584         (WebCore::FrameView::prepareMouseEvent):
1585         (WebCore::FrameView::handleWheelEvent):
1586         * platform/ScrollView.h:
1587         * platform/Widget.cpp:
1588         (WebCore::Widget::convertToContainingWindow):
1589         * platform/Widget.h:
1590         * platform/mac/ScrollViewMac.mm:
1591         (WebCore::ScrollView::convertToContainingWindow):
1592         (WebCore::ScrollView::convertFromContainingWindow):
1593         * platform/mac/WidgetMac.mm:
1594         (WebCore::Widget::convertToContainingWindow):
1595         (WebCore::Widget::convertFromContainingWindow):
1596         * platform/win/ScrollViewWin.cpp:
1597         (WebCore::ScrollView::convertToContainingWindow):
1598         (WebCore::ScrollView::convertFromContainingWindow):
1599         * rendering/RenderLayer.cpp:
1600         (WebCore::RenderLayer::resize):
1601
1602 2006-09-28  Alice Liu  <alice.liu@apple.com>
1603
1604         Build fix by adding missing files for CommandByName
1605
1606         * WebCore.xcodeproj/project.pbxproj:
1607
1608 2006-09-28  Alice Liu  <alice.liu@apple.com>
1609
1610         Adding CommandByName files to the vcproj
1611
1612         * WebCore.vcproj/WebCore/WebCore.vcproj:
1613
1614 2006-09-28  Alice Liu  <alice.liu@apple.com>
1615
1616         Reviewed by Adam Roben.
1617
1618         This patch adds a command class that is attached to the frame so the frame can more easily execute commands such as copy, paste, select, etc.
1619         This patch also exposes some UBRK-related utilities so that they can be used elsewhere.
1620         This patch also changes windows PlatformMouseEvent so that we can detect multiple-click mouse events
1621
1622         * editing/CommandByName.cpp: Added.
1623         Added a command class that hangs off the frame so the frame can call commands more easily.
1624         (WebCore::Frame::commandImp):
1625         (WebCore::Frame::execCopy):
1626         (WebCore::Frame::execCut):
1627         (WebCore::Frame::execDelete):
1628         (WebCore::Frame::execForwardDelete):
1629         (WebCore::Frame::execPaste):
1630         (WebCore::Frame::execMoveLeft):
1631         (WebCore::Frame::execMoveRight):
1632         (WebCore::Frame::execMoveUp):
1633         (WebCore::Frame::execMoveDown):
1634         (WebCore::Frame::execSelectAll):
1635         (WebCore::Frame::execSelectLeft):
1636         (WebCore::Frame::execSelectRight):
1637         (WebCore::Frame::execSelectUp):
1638         (WebCore::Frame::execSelectDown):
1639         (WebCore::Frame::enabled):
1640         (WebCore::Frame::enabledAnySelection):
1641         (WebCore::Frame::enabledAnyEditableSelection):
1642         (WebCore::Frame::enabledPaste):
1643         (WebCore::Frame::enabledAnyRangeSelection):
1644         (WebCore::Frame::enabledAnyEditableRangeSelection):
1645         (WebCore::Frame::createCommandDictionary):
1646         (WebCore::Frame::Command::):
1647         (WebCore:::m_frame):
1648         (WebCore::CommandByName::execCommand):
1649         * editing/CommandByName.h: Added.
1650         * page/Frame.cpp:
1651         Added implementation of accessor for CommandByName member
1652         (WebCore::Frame::command):
1653         * page/Frame.h:
1654         Added accessor for CommandByName member
1655         * page/FramePrivate.h:
1656         Added a CommandByName member
1657         (WebCore::FramePrivate::FramePrivate):
1658         * platform/PlatformMouseEvent.h:
1659         Changed constructor prototype
1660         * platform/StringImpl.cpp:
1661         Exposing getWordBreakIterator to be used elsewhere
1662         (WebCore::getWordBreakIterator):
1663         * platform/StringImpl.h:
1664         Exposing getWordBreakIterator to be used elsewhere
1665         * platform/win/MouseEventWin.cpp:
1666         Changed the PlatformMouseEvent on windows so that we "roll our own" multi-click mouse events instead of relying on the system to tell us, enabling us to detect triple-clicks
1667         (WebCore::PlatformMouseEvent::PlatformMouseEvent):
1668
1669 2006-09-28  Adam Roben  <aroben@apple.com>
1670
1671         Reviewed by Adele.
1672
1673         Remove no-longer-used PopUpButton.
1674
1675         * WebCore.vcproj/WebCore/WebCore.vcproj: Remove PopUpButton.h
1676         * WebCore.xcodeproj/project.pbxproj: Remove PopUpButton.h,
1677         PopUpButtonMac.mm
1678         * platform/PopUpButton.h: Removed.
1679         * platform/mac/PopUpButtonMac.mm: Removed.
1680         * platform/win/TemporaryLinkStubs.cpp: Remove PopUpButton:: methods
1681         * rendering/DeprecatedRenderSelect.cpp: Change #include of
1682         PopUpButton.h to ListBox.h
1683
1684 2006-09-28  Darin Adler  <darin@apple.com>
1685
1686         Reviewed by Alice.
1687
1688         - change that should fix <rdar://problem/4733044> REGRESSION: XML iBench shows
1689           10% perf. regression (copying strings while decoding)
1690
1691         Use Vector<UChar> instead of String when building up the decoded string in
1692         the ICU and Mac decoders. Using String leads to O(n^2) behavior because
1693         String grows the buffer every single time that append is called. Using
1694         Vector::append instead of String::append also avoids constructing a string
1695         each time just to append and a questionable copy that is done inside the
1696         String::append function which also contributed to the slowness.
1697
1698         * platform/PlatformString.h:
1699         * platform/String.cpp: (WebCore::String::adopt): Added. Makes a String from a
1700         Vector<UChar>, adopting the buffer from the vector to avoid copying and memory
1701         allocation.
1702         * platform/StringImpl.h:
1703         * platform/StringImpl.cpp: (WebCore::StringImpl::adopt): Ditto.
1704
1705         * platform/StreamingTextDecoder.h:
1706         * platform/StreamingTextDecoder.cpp: (WebCore::TextCodec::appendOmittingBOM):
1707         Change to use a Vector<UChar> instead of a String, since vectors have better
1708         resizing performance (they store a separate capacity).
1709
1710         * platform/StreamingTextDecoderICU.cpp: (WebCore::TextCodecICU::decode):
1711         * platform/mac/StreamingTextDecoderMac.cpp: (WebCore::TextCodecMac::decode):
1712         Change to use Vector<UChar> instead of String and then create a string at
1713         the end of the process using the new adopt function.
1714
1715 2006-09-28  Sam Weinig  <sam.weinig@gmail.com>
1716
1717         Reviewed by Tim H.
1718
1719         Patch for http://bugs.webkit.org/show_bug.cgi?id=11057
1720         Auto-generate more SVG Objective-C bindings
1721
1722         - Auto-generates DOMSVGAnimatedAngle, DOMSVGAnimatedBoolean,
1723           DOMSVGAnimatedEnumeration, DOMSVGAnimatedInteger, DOMSVGAnimatedLength,
1724           DOMSVGAnimatedLengthList, DOMSVGAnimatedNumber, DOMSVGAnimatedString,
1725           DOMSVGAnimatedTransformList, DOMSVGExternalResourcesRequired,
1726           DOMSVGLangSpace, DOMSVGLocatable, DOMSVGMetadataElement, DOMSVGRectElement,
1727           DOMSVGStringList, DOMSVGStylable, DOMSVGStyleElement, DOMSVGTests,
1728           and DOMSVGTransformable.
1729
1730         - Adds ability to CodeGeneratorObjC.pm to handle interfaces with mulitple
1731           parent interfaces and the SVG animated classes.
1732
1733         - Corrects CodeGenerator.pm to only skip the first parent for the main
1734           interface.
1735
1736         * DerivedSources.make:
1737         * WebCore.xcodeproj/project.pbxproj:
1738         * bindings/objc/DOMInternal.h:
1739         * bindings/objc/DOMSVG.h:
1740         * bindings/scripts/CodeGenerator.pm:
1741         * bindings/scripts/CodeGeneratorObjC.pm:
1742         * ksvg2/svg/SVGAnimatedAngle.idl:
1743         * ksvg2/svg/SVGAnimatedBoolean.idl:
1744         * ksvg2/svg/SVGAnimatedEnumeration.idl:
1745         * ksvg2/svg/SVGAnimatedInteger.idl:
1746         * ksvg2/svg/SVGAnimatedLength.idl:
1747         * ksvg2/svg/SVGAnimatedLengthList.idl:
1748         * ksvg2/svg/SVGAnimatedNumber.idl:
1749         * ksvg2/svg/SVGAnimatedPathData.idl:
1750         * ksvg2/svg/SVGAnimatedString.idl:
1751         * ksvg2/svg/SVGAnimatedTransformList.idl:
1752         * ksvg2/svg/SVGExternalResourcesRequired.idl:
1753         * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.idl:
1754         * ksvg2/svg/SVGFitToViewBox.idl:
1755         * ksvg2/svg/SVGLangSpace.idl:
1756         * ksvg2/svg/SVGLocatable.idl:
1757         * ksvg2/svg/SVGMetadataElement.idl:
1758         * ksvg2/svg/SVGStringList.idl:
1759         * ksvg2/svg/SVGStylable.idl:
1760         * ksvg2/svg/SVGStyleElement.idl:
1761         * ksvg2/svg/SVGTests.idl:
1762         * ksvg2/svg/SVGTransformable.idl:
1763         * ksvg2/svg/SVGURIReference.idl:
1764         * ksvg2/svg/SVGUnitTypes.idl:
1765         * ksvg2/svg/SVGZoomAndPan.idl:
1766
1767 2006-09-28  Brady Eidson  <beidson@apple.com>
1768
1769         Reviewed by Mitz Pettel!!!
1770
1771         Change the error code check for common functions from SQLResultOk to SQLResultDone
1772
1773         * loader/icon/IconDatabase.cpp:
1774         (WebCore::IconDatabase::forgetPageURLQuery):
1775         (WebCore::IconDatabase::setIconIDForPageURLQuery):
1776         (WebCore::IconDatabase::addIconForIconURLQuery):
1777
1778 2006-09-28  Dave Hyatt  <hyatt@apple.com>
1779
1780         Just eliminate MapWindowPoints usage and use the HWND as
1781         the viewport.
1782
1783         * platform/win/MouseEventWin.cpp:
1784         (WebCore::positionForEvent):
1785         * platform/win/ScrollViewWin.cpp:
1786         (WebCore::ScrollView::viewportToContents):
1787         (WebCore::ScrollView::contentsToViewport):
1788
1789 2006-09-27  David Hyatt  <hyatt@apple.com>
1790
1791         Fix for bug 9222, cursor is wrong when mousing over overflow scrollbars in textareas.  Make sure
1792         selectCursor checks for whether or not a scrollbar was hit.  Also stub out a mouseMoved method for
1793         scrollbars to provide hover feedback if needed.
1794
1795         Reviewed by Eric
1796
1797         * page/FrameView.cpp:
1798         (WebCore::selectCursor):
1799         (WebCore::FrameView::handleMouseMoveEvent):
1800         * platform/ScrollBar.h:
1801         (WebCore::ScrollBar::mouseMoved):
1802
1803 2006-09-27  MorganL  <morganl.webkit@yahoo.com>
1804
1805         Reviewed by Maciej and Adam, landed by Adam
1806
1807         Fixes: http://bugs.webkit.org/show_bug.cgi?id=11072
1808         Windows build is busted
1809
1810         * platform/win/TemporaryLinkStubs.cpp:
1811         (ScrollView::paint):
1812         (ScrollView::themeChanged):
1813
1814 2006-09-27  Eric Seidel  <eric@eseidel.com>
1815
1816         Reviewed by mitz.
1817
1818         paths with no fill specified default to black but do not recieve paint-related mouse events
1819         http://bugs.webkit.org/show_bug.cgi?id=11069
1820         The default fill was being applied at the wrong place in the rendering chain, causing this problem.
1821
1822         Test: svg/custom/hover-default-fill.svg
1823
1824         * kcanvas/RenderPath.cpp:
1825         (WebCore::RenderPath::nodeAtPoint): use isFilled and isStroked
1826         * ksvg2/css/SVGRenderStyle.h: use defaultFill() and defaultStroke()
1827         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1828         (WebCore::KSVGPainterFactory::isFilled): remove null check
1829         (WebCore::KSVGPainterFactory::fillPaintServer): remove null check
1830         (WebCore::KSVGPainterFactory::isStroked): remove null check
1831         (WebCore::KSVGPainterFactory::strokePaintServer): remove null check
1832         * ksvg2/svg/SVGPaint.cpp:
1833         (WebCore::SVGPaint::defaultFill): added.
1834         (WebCore::SVGPaint::defaultStroke): added.
1835         * ksvg2/svg/SVGPaint.h:
1836
1837 2006-09-27  Rob Buis  <buis@kde.org>
1838
1839         Reviewed by eseidel.
1840
1841         http://bugs.webkit.org/show_bug.cgi?id=11015
1842         SVG handles em units incorrectly
1843
1844         Calculate viewport coordinates at layout time, since
1845         at this point the font size is known and lengths depending
1846         on font sizes can be calculated correctly.
1847
1848         * kcanvas/RenderSVGContainer.cpp:
1849         (WebCore::RenderSVGContainer::layout):
1850         (WebCore::RenderSVGContainer::viewport):
1851         (WebCore::RenderSVGContainer::calcViewport):
1852         * kcanvas/RenderSVGContainer.h:
1853         * ksvg2/svg/SVGLength.cpp:
1854         (WebCore::SVGLength::updateValue):
1855         * ksvg2/svg/SVGMarkerElement.cpp:
1856         (WebCore::SVGMarkerElement::createRenderer):
1857         * ksvg2/svg/SVGSVGElement.cpp:
1858         (WebCore::SVGSVGElement::createRenderer):
1859         (WebCore::SVGSVGElement::attributeChanged):
1860         * ksvg2/svg/SVGSVGElement.h:
1861
1862 2006-09-27  Eric Seidel  <eric@eseidel.com>
1863
1864         Reviewed by darin.
1865
1866         Change our invalid-fill error behavior to match Opera (and soon Firefox)
1867         http://bugs.webkit.org/show_bug.cgi?id=11017
1868
1869         * ksvg2/misc/KCanvasRenderingStyle.cpp:
1870         (WebCore::KSVGPainterFactory::isFilled):
1871         (WebCore::KSVGPainterFactory::fillPaintServer):
1872         (WebCore::KSVGPainterFactory::isStroked):
1873         (WebCore::KSVGPainterFactory::strokePaintServer):
1874
1875 2006-09-27  Brady Eidson  <beidson@apple.com>
1876
1877         Build fix
1878
1879         * loader/icon/IconDatabase.cpp:
1880         (WebCore::readySQLStatement):
1881
1882 2006-09-27  Brady Eidson  <beidson@apple.com>
1883
1884         Reviewed by Adam
1885
1886         In very specific circumstances, prepared SQLStatements can become invalid without
1887         any warning.  This checks for that state and re-prepares the statement and also
1888         adds more aggressive error-checking everywhere these statements are used.
1889
1890         * loader/icon/IconDatabase.cpp:
1891         (WebCore::readySQLStatement): Check if the statement is expired - reprepare it
1892         (WebCore::IconDatabase::imageDataForIconURLQuery): More thoroughly catch error cases
1893         (WebCore::IconDatabase::timeStampForIconURLQuery): Ditto
1894         (WebCore::IconDatabase::iconURLForPageURLQuery): Ditto
1895         (WebCore::IconDatabase::forgetPageURLQuery): Ditto
1896         (WebCore::IconDatabase::setIconIDForPageURLQuery): Ditto
1897         (WebCore::IconDatabase::getIconIDForIconURLQuery): Ditto
1898         (WebCore::IconDatabase::addIconForIconURLQuery): Ditto
1899         (WebCore::IconDatabase::hasIconForIconURLQuery): Ditto
1900         * loader/icon/SQLStatement.cpp:
1901         (WebCore::SQLStatement::isExpired): Added (accessor to sqlite3_expired())
1902         * loader/icon/SQLStatement.h:
1903
1904 2006-09-26  Darin Adler  <darin@apple.com>
1905
1906         Reviewed by Steve.
1907
1908         - clean up options for font code path
1909
1910         * platform/Font.h:
1911         * platform/Font.cpp:
1912         (WebCore::Font::setCodePath): Added. Replaces boolean version.
1913         (WebCore::Font::canUseGlyphCache): Update to handle "never use complex" case too.
1914
1915         * platform/mac/WebCoreTextRenderer.mm:
1916         (WebCoreSetAlwaysUseATSU): Change to call setCodePath.
1917
1918 2006-09-26  John Sullivan  <sullivan@apple.com>
1919
1920         Reviewed by Darin
1921
1922         * bridge/mac/WebCoreFrameBridge.h:
1923         * bridge/mac/WebCoreFrameBridge.mm:
1924         (-[WebCoreFrameBridge markAllMatchesForText:caseSensitive:limit:]):
1925         Added limit parameter, passed down to Frame
1926
1927         * page/Frame.h:
1928         * page/Frame.cpp:
1929         (WebCore::Frame::markAllMatchesForText):
1930         Added limit parameter. Stop the search if it hits limit.
1931
1932 2006-09-26  Sean Gies  <seangies@apple.com>
1933
1934         Reviewed by Brady Eidson.
1935
1936         * platform/cg/ImageCG.cpp: Removed #if's -- Darin said we don't need these.
1937
1938 2006-09-26  Justin Garcia  <justin.garcia@apple.com>
1939
1940         Reviewed by john
1941
1942         <rdar://problem/4747695>
1943         Gmail Editor: Crash at WebCore::Range::startPosition() when decreasing a indent
1944
1945         * editing/DeleteSelectionCommand.cpp:
1946         (WebCore::DeleteSelectionCommand::initializeStartEnd): Stop expanding
1947         to select special elements that are fully selected after expansion
1948         moves to positions that are visually distinct from the originals.
1949         * editing/InsertListCommand.cpp:
1950         (WebCore::InsertListCommand::doApply): If the content of the list
1951         item will be moved into another list, put it in a list item.
1952
1953 2006-09-26  Geoffrey Garen <ggaren@apple.com>
1954
1955         Reviewed by Darin.
1956
1957         Temporary work-around for frame lifetime issue.
1958
1959         * page/Frame.cpp:
1960         (WebCore::Frame::clear):
1961         (WebCore::Frame::disconnectOwnerElement):
1962
1963 2006-09-26  Sam Weinig  <sam.weinig@gmail.com>
1964
1965         Reviewed by Tim H.
1966
1967         Patch for http://bugs.webkit.org/show_bug.cgi?id=11038
1968         Auto-generate DOMSVGElement for the Objective-C bindings
1969
1970         - Auto-generates DOMSVGElement.
1971
1972         - Make SVGExceptions work like all the other ExceptionCode
1973           extensions (Range, XPath, etc.) by adding SVGExceptionOffset
1974           and SVGExceptionMax.
1975
1976         * DerivedSources.make:
1977         * WebCore.xcodeproj/project.pbxproj:
1978         * bindings/js/kjs_binding.cpp:
1979         (KJS::):
1980         (KJS::setDOMException):
1981         * bindings/objc/DOMInternal.h:
1982         * bindings/objc/DOMInternal.mm:
1983         (raiseDOMException):
1984         * bindings/objc/DOMSVG.h:
1985         * bindings/objc/DOMSVGExecption.h: Added.
1986         * ksvg2/ksvg.h:
1987         * ksvg2/svg/SVGElement.cpp:
1988         (WebCore::SVGElement::setId):
1989         (WebCore::SVGElement::setXmlbase):
1990         * ksvg2/svg/SVGElement.h:
1991         * ksvg2/svg/SVGElement.idl:
1992         * ksvg2/svg/SVGException.h: Added.
1993         (WebCore::):
1994
1995 2006-09-26  Eric Seidel  <eric@eseidel.com>
1996
1997         Reviewed by Tim H.
1998
1999         viewbox parser does not allow <tab> as a delimiter
2000         http://bugs.webkit.org/show_bug.cgi?id=11014
2001
2002         Test: svg/hixie/viewbox/003.xml
2003
2004         * ksvg2/svg/svgpathparser.cpp:
2005         (WebCore::isWhitespace): new function
2006         (WebCore::skipOptionalSpaces):
2007         (WebCore::skipOptionalSpacesOrComma):
2008
2009 2006-09-26  Eric Seidel  <eric@eseidel.com>
2010
2011         Reviewed by Tim H.
2012
2013         SVGDocument::createElement does not create elements in the SVG namespace
2014         http://bugs.webkit.org/show_bug.cgi?id=10932
2015
2016         Test: svg/custom/createelement.svg
2017
2018         * ksvg2/svg/SVGDocument.cpp:
2019         (WebCore::SVGDocument::createElement):
2020         * ksvg2/svg/SVGDocument.h:
2021
2022 2006-09-26  Eric Seidel  <eric@eseidel.com>
2023
2024         Reviewed by Tim H.
2025
2026         RenderPath::nodeAtPoint does not respect stroke width
2027         http://bugs.webkit.org/show_bug.cgi?id=10829
2028
2029         Test: svg/custom/stroke-width-click.svg
2030
2031         * kcanvas/device/quartz/KCanvasItemQuartz.mm:
2032         (WebCore::RenderPath::strokeContains):
2033         * kcanvas/device/quartz/QuartzSupport.h:
2034         * kcanvas/device/quartz/QuartzSupport.mm:
2035
2036 2006-09-26  Eric Seidel  <eric@eseidel.com>
2037
2038         Reviewed by mitz.
2039
2040         Bring animation back to life
2041         http://bugs.webkit.org/show_bug.cgi?id=11021
2042
2043         Register/unregister SVGSVGElements as time containers on insertion/removal.
2044         Replace uses of DeprecatedString with String in SVGAnimationElement
2045         Various whitespace clean-up.
2046
2047         * ksvg2/misc/KSVGTimeScheduler.cpp:
2048         (WebCore::SVGTimer::notifyAll):
2049         * ksvg2/misc/SVGDocumentExtensions.cpp:
2050         (WebCore::SVGDocumentExtensions::startAnimations):
2051         (WebCore::SVGDocumentExtensions::pauseAnimations):
2052         (WebCore::SVGDocumentExtensions::unpauseAnimations):
2053         * ksvg2/svg/SVGAnimateTransformElement.cpp:
2054         (WebCore::SVGAnimateTransformElement::handleTimerEvent):
2055         (WebCore::SVGAnimateTransformElement::parseTransformValue):
2056         * ksvg2/svg/SVGAnimateTransformElement.h:
2057         * ksvg2/svg/SVGAnimationElement.cpp:
2058         (WebCore::SVGAnimationElement::SVGAnimationElement):
2059         (WebCore::SVGAnimationElement::parseMappedAttribute):
2060         (WebCore::SVGAnimationElement::parseClockValue):
2061         (WebCore::SVGAnimationElement::targetAttribute):
2062         (WebCore::SVGAnimationElement::setTargetAttribute):
2063         (WebCore::SVGAnimationElement::attributeName):
2064         * ksvg2/svg/SVGAnimationElement.h:
2065         (WebCore::SVGAnimationElement::rendererIsNeeded):
2066         * ksvg2/svg/SVGSVGElement.cpp:
2067         (WebCore::SVGSVGElement::getScreenCTM):
2068         (WebCore::SVGSVGElement::createRenderer):
2069         (WebCore::SVGSVGElement::insertedIntoDocument): added, calls addTimeContainer(this)
2070         (WebCore::SVGSVGElement::removedFromDocument): added, calls removeTimeContainer(this)
2071         * ksvg2/svg/SVGSVGElement.h:
2072         * ksvg2/svg/SVGSetElement.cpp:
2073         (WebCore::SVGSetElement::handleTimerEvent):
2074         * ksvg2/svg/SVGURIReference.cpp:
2075         (WebCore::SVGURIReference::getTarget):
2076         * ksvg2/svg/SVGURIReference.h:
2077
2078 2006-09-26  Graham Dennis  <graham.dennis@gmail.com>
2079
2080         Reviewed by mitzpettel.
2081
2082         - fix http://bugs.webkit.org/show_bug.cgi?id=11020
2083         No-SVG build broken since r16549
2084
2085         Change #if SVG_SUPPORT to #ifdef SVG_SUPPORT
2086
2087         * css/cssparser.cpp:
2088         (WebCore::CSSParser::parseValue):
2089         * css/cssstyleselector.cpp:
2090         (WebCore::CSSStyleSelector::applyProperty):
2091         * page/FrameView.cpp:
2092         (WebCore::selectCursor):
2093         * platform/qt/GraphicsContextQt.cpp:
2094
2095 2006-09-26  Anders Carlsson  <acarlsson@apple.com>
2096
2097         Reviewed by Maciej.
2098
2099         http://bugs.webkit.org/show_bug.cgi?id=10820
2100         Add StringImpl::toDouble() and remove uses of .deprecatedString().toDouble()
2101
2102         (Originally written by Eric Seidel).
2103
2104         * bindings/js/kjs_window.cpp:
2105         (KJS::floatFeature):
2106         * ksvg2/svg/SVGAngle.cpp:
2107         (SVGAngle::setValueAsString):
2108         * ksvg2/svg/SVGAnimationElement.cpp:
2109         (SVGAnimationElement::parseMappedAttribute):
2110         * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
2111         (SVGComponentTransferFunctionElement::parseMappedAttribute):
2112         * ksvg2/svg/SVGFECompositeElement.cpp:
2113         (WebCore::SVGFECompositeElement::parseMappedAttribute):
2114         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
2115         (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
2116         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
2117         (SVGFEDisplacementMapElement::parseMappedAttribute):
2118         * ksvg2/svg/SVGFELightElement.cpp:
2119         (SVGFELightElement::parseMappedAttribute):
2120         * ksvg2/svg/SVGFEOffsetElement.cpp:
2121         (WebCore::SVGFEOffsetElement::parseMappedAttribute):
2122         * ksvg2/svg/SVGFESpecularLightingElement.cpp:
2123         (SVGFESpecularLightingElement::parseMappedAttribute):
2124         * ksvg2/svg/SVGFETurbulenceElement.cpp:
2125         (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
2126         * ksvg2/svg/SVGStopElement.cpp:
2127         (SVGStopElement::parseMappedAttribute):
2128         * platform/AtomicString.h:
2129         (WebCore::AtomicString::toDouble):
2130         * platform/PlatformString.h:
2131         * platform/String.cpp:
2132         (WebCore::String::toDouble):
2133         * platform/StringImpl.cpp:
2134         (WebCore::StringImpl::toDouble):
2135         * platform/StringImpl.h:
2136         * rendering/DeprecatedSlider.cpp:
2137         (WebCore::DeprecatedSlider::updateFromElement):
2138         * xml/XPathGrammar.y:
2139
2140 2006-09-25  David Harrison  <harrison@apple.com>
2141
2142         Reviewed by Tim Omernick and Tim Hatcher.
2143
2144         <rdar://problem/4717965> Text Field text parameterized attributes should work
2145         <rdar://problem/4712111> Support NSAccessibilityInsertionPointLineNumberAttribute for AXTextArea elements
2146
2147         * bridge/mac/WebCoreAXObject.mm:
2148         (-[WebCoreAXObject accessibilityAttributeValue:]):
2149         Use new line number support to implement NSAccessibilityInsertionPointLineNumberAttribute.
2150
2151         (-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
2152         Cleaned up. Added text field and text area parameterzed attributes.
2153
2154         (-[WebCoreAXObject doAXLineForTextMarker:]):
2155         Fixed to be zero-based and to deal with the first position properly.
2156
2157         (-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
2158         Minor formatting.
2159
2160         (-[WebCoreAXObject textMarkerForIndex:lastIndexOK:]):
2161         (-[WebCoreAXObject indexForTextMarker:]):
2162         (-[WebCoreAXObject textMarkerRangeForRange:]):
2163         (-[WebCoreAXObject rangeForTextMarkerRange:]):
2164         New utility methods.
2165
2166         (-[WebCoreAXObject doAXLineForIndex:]):
2167         (-[WebCoreAXObject doAXRangeForLine:]):
2168         (-[WebCoreAXObject doAXStringForRange:]):
2169         (-[WebCoreAXObject doAXRangeForPosition:]):
2170         (-[WebCoreAXObject doAXRangeForIndex:]):
2171         (-[WebCoreAXObject doAXBoundsForRange:]):
2172         (-[WebCoreAXObject doAXAttributedStringForRange:]):
2173         (-[WebCoreAXObject doAXRTFForRange:]):
2174         (-[WebCoreAXObject doAXStyleRangeForIndex:]):
2175         Implement text field and text area parameterized attributes.
2176
2177         (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
2178         Added text field and text area parameterzed attributes.
2179
2180         * rendering/RenderTextControl.h:
2181         Made indexForVisiblePosition() and visiblePositionForIndex() public.
2182
2183 2006-09-25  Adam Roben  <aroben@apple.com>
2184
2185         Reviewed by Brady.
2186
2187         Build fixes.
2188
2189         * WebCore.vcproj/WebCore/WebCore.vcproj: Fix malformed XML.
2190         * platform/ResourceLoader.h: Store whether a particular job
2191         has received a response within the ResourceLoader object itself, since
2192         it's possible that we will enter the InternetReadFileExA while loop
2193         twice for the same job.
2194         * platform/ResourceLoaderInternal.h: Add private instance variable to
2195         store whether we've received a response.
2196         (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
2197         * platform/win/GraphicsContextWin.cpp: Fix order of preprocessor
2198         directives.
2199         * platform/win/ResourceLoaderWin.cpp:
2200         (WebCore::ResourceLoader::onRequestComplete): Ask the ResourceLoader
2201         whether it has received a response instead of assuming it hasn't.
2202         (WebCore::ResourceLoader::setHasReceivedResponse): Added.
2203         (WebCore::ResourceLoader::hasReceivedResponse): Added.
2204         * platform/win/TemporaryLinkStubs.cpp: Rename setKnobProportion to
2205         setProportion
2206         (ScrollBar::setProportion):
2207
2208 2006-09-25  Brady Eidson  <beidson@apple.com>
2209
2210         Requested by ggaren
2211
2212         Disabled IconDatabase logging by default
2213
2214         * platform/Logging.cpp:
2215         (WebCore::):
2216
2217 2006-09-25  Steve Falkenburg  <sfalken@apple.com>
2218
2219         Build fix
2220
2221         * platform/cf/ResourceLoaderCFNet.cpp:
2222         (WebCore::willCacheResponse):
2223
2224 2006-09-25  Justin Garcia  <justin.garcia@apple.com>
2225
2226         Reviewed by john
2227
2228         <http://bugs.webkit.org/show_bug.cgi?id=11002>
2229         Gmail Editor: Crash at WebCore::SplitElementCommand::doApply() when attempting to indent in a new message
2230
2231         * editing/IndentOutdentCommand.cpp:
2232         (WebCore::IndentOutdentCommand::indentRegion): Special case
2233         an empty root editable element.
2234
2235 2006-09-25  Brady Eidson  <beidson@apple.com>
2236
2237         Reviewed by Steve
2238
2239         Math error in SystemTimeWin
2240
2241         * platform/win/SystemTimeWin.cpp:
2242         (WebCore::currentTime):
2243
2244 2006-09-25  Alexey Proskuryakov  <ap@nypop.com>
2245
2246         Reviewed by Eric.
2247
2248         Whitespace cleanup; rename *job variables to *loader.
2249
2250         * bindings/js/JSXMLHttpRequest.cpp:
2251         (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
2252         (KJS::JSXMLHttpRequestConstructorImp::implementsConstruct):
2253         (KJS::JSXMLHttpRequestConstructorImp::construct):
2254         (KJS::JSXMLHttpRequest::getOwnPropertySlot):
2255         (KJS::JSXMLHttpRequest::getValueProperty):
2256         (KJS::JSXMLHttpRequest::put):
2257         (KJS::JSXMLHttpRequest::putValueProperty):
2258         (KJS::JSXMLHttpRequest::mark):
2259         (KJS::JSXMLHttpRequest::JSXMLHttpRequest):
2260         (KJS::JSXMLHttpRequest::~JSXMLHttpRequest):
2261         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
2262         * bindings/js/JSXMLHttpRequest.h:
2263         (KJS::JSXMLHttpRequest::toBoolean):
2264         * xml/xmlhttprequest.cpp:
2265         (WebCore::XMLHttpRequest::XMLHttpRequest):
2266         (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):
2267         (WebCore::XMLHttpRequest::send):
2268         (WebCore::XMLHttpRequest::abort):
2269         (WebCore::XMLHttpRequest::receivedAllData):
2270         (WebCore::XMLHttpRequest::receivedData):
2271         * xml/xmlhttprequest.h:
2272         (WebCore::):
2273
2274 2006-09-25  Timothy Hatcher  <timothy@apple.com>
2275
2276         Reviewed by Brady.
2277
2278         - Deprecate the rest of the old-style methods that are not generated.
2279         - Add @property syntax to DOMRange.
2280
2281         * WebCore.xcodeproj/project.pbxproj:
2282         * bindings/objc/DOM.mm:
2283         (-[DOMRange setStart:offset:]):
2284         (-[DOMRange setEnd:offset:]):
2285         (-[DOMRange compareBoundaryPoints:sourceRange:]):
2286         (-[DOMRange setStart::]):
2287         (-[DOMRange setEnd::]):
2288         (-[DOMRange compareBoundaryPoints::]):
2289         (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
2290         (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
2291         (-[DOMDocument createNodeIterator::::]):
2292         (-[DOMDocument createTreeWalker::::]):
2293         * bindings/objc/DOMCSS.h:
2294         * bindings/objc/DOMCSS.mm:
2295         (-[DOMDocument getComputedStyle:pseudoElement:]):
2296         (-[DOMDocument getComputedStyle::]):
2297         (-[DOMDocument getMatchedCSSRules:pseudoElement:]):
2298         * bindings/objc/DOMExtensions.h:
2299         * bindings/objc/DOMHTML.h:
2300         * bindings/objc/DOMRange.h:
2301         * bindings/objc/DOMTraversal.h:
2302
2303 2006-09-25  Eric Seidel  <eric@eseidel.com>
2304
2305         Reviewed by mjs.
2306
2307         Outermost <svg> element should clip to viewport
2308         http://bugs.webkit.org/show_bug.cgi?id=11007
2309
2310         Test: svg/custom/viewport-clip.svg
2311
2312         * css/svg.css: change svg:root overflow: from 'visible' to 'hidden'
2313
2314 2006-09-25  Anders Carlsson  <acarlsson@apple.com>
2315
2316         Reviewed by Maciej.
2317
2318         * css/MediaList.cpp:
2319         Remove unused header.
2320
2321         * dom/Document.cpp:
2322         (WebCore::Document::clear):
2323         Use clear instead of iterating through the list of event listeners, removing each one.
2324         (Doing that causes a crash when running the layout tests with GuardMalloc turned on)
2325
2326         * html/HTMLKeygenElement.cpp:
2327         (WebCore::HTMLKeygenElement::HTMLKeygenElement):
2328         (WebCore::HTMLKeygenElement::appendFormData):
2329         Update due to changes in the SSL key generator.
2330
2331         * ksvg2/svg/SVGAngle.cpp:
2332         Remove unused header.
2333
2334         * ksvg2/svg/SVGAnimationElement.cpp:
2335         (SVGAnimationElement::parseMappedAttribute):
2336         Rename methods and pass Strings instead of DeprecatedStrings to
2337         parseSeparatedList.
2338
2339         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
2340         * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
2341         * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
2342         * ksvg2/svg/SVGFEMergeElement.cpp:
2343         * ksvg2/svg/SVGFEOffsetElement.cpp:
2344         Remove unused headers.
2345
2346         * ksvg2/svg/SVGHelper.cpp:
2347         (WebCore::SVGHelper::parseSeparatedList):
2348         * ksvg2/svg/SVGHelper.h:
2349         Rename ParseSeperatedList to parseSeparatedList, make it take a String instead of a
2350         DeprecatedString and have it use Vector<String> instead of DeprecatedStringList.
2351
2352         * ksvg2/svg/SVGLengthList.cpp:
2353         (WebCore::SVGLengthList::parse):
2354         * ksvg2/svg/SVGLengthList.h:
2355         Use Vector<String> instead of DeprecatedStringList.
2356
2357         * loader/Cache.cpp:
2358         (WebCore::Cache::requestImage):
2359         (WebCore::Cache::requestStyleSheet):
2360         (WebCore::Cache::requestScript):
2361         (WebCore::Cache::requestXSLStyleSheet):
2362         (WebCore::Cache::requestXBLDocument):
2363         (WebCore::Cache::remove):
2364         (WebCore::Cache::get):
2365         Use a String as the key in the cache set instead of a RefPtr<StringImpl>.
2366
2367         * loader/DocLoader.cpp:
2368         (WebCore::DocLoader::needReload):
2369         * loader/DocLoader.h:
2370         Use a HashSet instead of DeprecatedStringList.
2371
2372         * page/FrameView.h:
2373         Remove declarations that have no functions.
2374
2375         * platform/SSLKeyGenerator.h:
2376         * platform/mac/SSLKeyGeneratorMac.mm:
2377         (WebCore::supportedKeySizes):
2378         (WebCore::signedPublicKeyAndChallengeString):
2379         Convert to use Vector<String> instead of DeprecatedStringList, and String instead of
2380         DeprecatedString.
2381
2382 2006-09-25  Dave Hyatt  <hyatt@apple.com>
2383
2384         Shunt the RenderTheme world transform adoption between
2385         Cairo and Windows into getWindowsContext and move the method
2386         out of GraphicsContextCairo and into GraphicsContextWin.
2387
2388         * ChangeLog:
2389         * WebCore.vcproj/WebCore/WebCore.vcproj:
2390         * platform/cairo/GraphicsContextCairo.cpp:
2391         * platform/win/GraphicsContextWin.cpp: Added.
2392         (WebCore::GraphicsContext::getWindowsContext):
2393         (WebCore::GraphicsContext::releaseWindowsContext):
2394         * rendering/RenderThemeWin.cpp:
2395         (WebCore::prepareForDrawing):
2396
2397 2006-09-24  Eric Seidel  <eric@eseidel.com>
2398
2399         Reviewed by hyatt.
2400
2401         <svg:a> cannot be styled with a:hover
2402         http://bugs.webkit.org/show_bug.cgi?id=11005
2403
2404         Test: svg/hixie/cascade/002.xml
2405
2406         * css/cssstyleselector.cpp:
2407         (WebCore::checkPseudoState):
2408
2409 2006-09-24  Sam Weinig  <sam.weinig@gmail.com>
2410
2411         Reviewed by Tim H.
2412
2413         Patch for http://bugs.webkit.org/show_bug.cgi?id=10882
2414         SVG needs Obj-C DOM bindings
2415
2416         - Auto-generate the first 8 Objective-C SVG DOM bindings.  The
2417           auto-generated classes are DOMSVGAngle, DOMSVGLength, DOMSVGLengthList,
2418           DOMSVGMatrix, DOMSVGPathSeg, DOMSVGPathSegList, DOMSVGTransform, and
2419           DOMSVGTransformList.
2420
2421         * DerivedSources.make:
2422         * WebCore.xcodeproj/project.pbxproj:
2423         * bindings/objc/DOMInternal.h:
2424         * bindings/objc/DOMSVG.h: Added.
2425         * ksvg2/svg/SVGAngle.idl:
2426         * ksvg2/svg/SVGLength.idl:
2427         * ksvg2/svg/SVGLengthList.idl:
2428         * ksvg2/svg/SVGMatrix.idl:
2429         * ksvg2/svg/SVGPathSeg.idl:
2430         * ksvg2/svg/SVGPathSegList.idl:
2431         * ksvg2/svg/SVGTransform.idl:
2432         * ksvg2/svg/SVGTransformList.idl:
2433
2434 2006-09-24  Rob Buis  <buis@kde.org>
2435
2436         Reviewed by eseidel.
2437
2438         Fix for http://bugs.webkit.org/show_bug.cgi?id=6001
2439         WebKit does not handle fallback custom cursors
2440         Fix for http://bugs.webkit.org/show_bug.cgi?id=6002
2441         WebKit does not properly handle SVG <cursor> element
2442
2443         Add support for svg cursor images. Also make sure hotspot
2444         settings are handled correctly. Add tests for handling of css3
2445         cursor syntax with hotspots in strict and quirks mode. Finally
2446         implement fallback.
2447
2448         * WebCore.xcodeproj/project.pbxproj:
2449         * css/CSSComputedStyleDeclaration.cpp:
2450         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2451         * css/CSSCursorImageValue.cpp: Added.
2452         (WebCore::CSSCursorImageValue::CSSCursorImageValue):
2453         (WebCore::CSSCursorImageValue::~CSSCursorImageValue):
2454         * css/CSSCursorImageValue.h: Added.
2455         (WebCore::CSSCursorImageValue::hotspot):
2456         * css/cssparser.cpp:
2457         (WebCore::CSSParser::parseValue):
2458         * css/cssstyleselector.cpp:
2459         (WebCore::CSSStyleSelector::applyProperty):
2460         * ksvg2/svg/SVGCursorElement.cpp:
2461         * manual-tests/css3-cursor-fallback-quirks.html: Added.
2462         * manual-tests/css3-cursor-fallback-strict.html: Added.
2463         * manual-tests/cursorfallback.xml: Added.
2464         * page/FrameView.cpp:
2465         (WebCore::selectCursor):
2466         * platform/Cursor.h:
2467         * platform/mac/CursorMac.mm:
2468         (WebCore::createCustomCursor):
2469         (WebCore::Cursor::Cursor):
2470         * platform/qt/CursorQt.cpp:
2471         (WebCore::Cursor::Cursor):
2472         * rendering/RenderStyle.cpp:
2473         (WebCore::StyleInheritedData::StyleInheritedData):
2474         (WebCore::StyleInheritedData::operator==):
2475         (WebCore::RenderStyle::diff):
2476         (WebCore::RenderStyle::addCursor):
2477         (WebCore::RenderStyle::addSVGCursor):
2478         (WebCore::RenderStyle::setCursorList):
2479         (WebCore::RenderStyle::clearCursorList):
2480         * rendering/RenderStyle.h:
2481         (WebCore::CursorData::CursorData):
2482         (WebCore::CursorList::operator[]):
2483         (WebCore::CursorList::size):
2484         (WebCore::CursorList::append):
2485         (WebCore::RenderStyle::cursors):
2486
2487 2006-09-24  Sam Weinig  <sam.weinig@gmail.com>
2488
2489         Reviewed by Tim H.
2490
2491         Patch for http://bugs.webkit.org/show_bug.cgi?id=11009
2492         Auto-generate the internal methods interfaces for the Objective-C bindings
2493
2494         - Auto-generate the internal method declarations into their own files
2495           named in the form DOMFooBarInternal.h for class DOMFooBar.
2496
2497         - Remove all use of DOM_cast from code.
2498
2499         - Assorted cleanups.
2500
2501         * WebCore.xcodeproj/project.pbxproj:
2502         * bindings/objc/DOM.mm:
2503         (-[DOMNode _initWithNode:WebCore::]):
2504         (-[DOMNode WebCore::]):
2505         (-[DOMRange dealloc]):
2506         (-[DOMRange finalize]):
2507         (-[DOMRange _initWithRange:WebCore::]):
2508         (-[DOMRange WebCore::]):
2509         (-[DOMNodeFilter _initWithNodeFilter:WebCore::]):
2510         (-[DOMNodeFilter WebCore::]):
2511         (-[DOMNodeFilter dealloc]):
2512         (-[DOMNodeFilter finalize]):
2513         (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]):
2514         (-[DOMNodeIterator WebCore::]):
2515         (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]):
2516         (-[DOMTreeWalker WebCore::]):
2517         * bindings/objc/DOMAbstractView.mm:
2518         (-[DOMAbstractView _initWithAbstractView:WebCore::]):
2519         * bindings/objc/DOMCSS.mm:
2520         (-[DOMStyleSheet _initWithStyleSheet:WebCore::]):
2521         (-[DOMCSSRule _initWithRule:WebCore::]):
2522         (-[DOMCSSValue _initWithValue:WebCore::]):
2523         * bindings/objc/DOMEvents.mm:
2524         (-[DOMEvent _initWithEvent:WebCore::]):
2525         * bindings/objc/DOMHTMLAppletElement.mm:
2526         (-[DOMHTMLAppletElement align]):
2527         (-[DOMHTMLAppletElement setAlign:]):
2528         (-[DOMHTMLAppletElement alt]):
2529         (-[DOMHTMLAppletElement setAlt:]):
2530         (-[DOMHTMLAppletElement archive]):
2531         (-[DOMHTMLAppletElement setArchive:]):
2532         (-[DOMHTMLAppletElement code]):
2533         (-[DOMHTMLAppletElement setCode:]):
2534         (-[DOMHTMLAppletElement codeBase]):
2535         (-[DOMHTMLAppletElement setCodeBase:]):
2536         (-[DOMHTMLAppletElement height]):
2537         (-[DOMHTMLAppletElement setHeight:]):
2538         (-[DOMHTMLAppletElement hspace]):
2539         (-[DOMHTMLAppletElement setHspace:]):
2540         (-[DOMHTMLAppletElement name]):
2541         (-[DOMHTMLAppletElement setName:]):
2542         (-[DOMHTMLAppletElement object]):
2543         (-[DOMHTMLAppletElement setObject:]):
2544         (-[DOMHTMLAppletElement vspace]):
2545         (-[DOMHTMLAppletElement setVspace:]):
2546         (-[DOMHTMLAppletElement width]):
2547         (-[DOMHTMLAppletElement setWidth:]):
2548         * bindings/objc/DOMInternal.h:
2549         (getDOMWrapper):
2550         (addDOMWrapper):
2551         (raiseOnDOMError):
2552         * bindings/objc/DOMXPath.mm:
2553         (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]):
2554         * bindings/scripts/CodeGeneratorObjC.pm:
2555
2556 2006-09-24  Nikolas Zimmermann  <zimmermann@kde.org>
2557
2558         Reviewed by eseidel.
2559
2560         Fix Qt/Linux build after Dave's Scrollbar changes.
2561
2562         * platform/qt/PlatformScrollBar.h: (Somehow this contained the file twice! Removed one instance!)
2563         * platform/qt/TemporaryLinkStubs.cpp:
2564         (WebCore::ScrollBar::setProportion):
2565         (WebCore::PlatformScrollBar::updateThumbPosition):
2566         (WebCore::PlatformScrollBar::updateThumbProportion):
2567
2568 2006-09-24  Nikolas Zimmermann  <zimmermann@kde.org>
2569
2570         Reviewed by eseidel.
2571
2572         Qt/Linux build system changes: enable xpath/xslt by default.
2573         Offer possibility to change all of these using 'ccmake'.
2574
2575         * CMakeLists.txt:
2576
2577 2006-09-24  Dave Hyatt  <hyatt@apple.com>
2578
2579         Cleanup of Scrollbar APIs.  Rename setKnobProportion to setProportion.  Rename setScrollbarValue to updateThumbPosition.
2580         Give setProportion a base class implementation and implement it using the same pattern as setValue/updateThumbPosition (so that
2581         the base calls a protected virtual function, updateThumbProportion, implemented by the derived class to update the actual scrollbar itself).
2582
2583         * platform/ScrollBar.cpp:
2584         (WebCore::ScrollBar::setValue):
2585         (WebCore::ScrollBar::setProportion):
2586         * platform/ScrollBar.h:
2587         (WebCore::ScrollBar::value):
2588         * platform/mac/PlatformScrollBar.h:
2589         * platform/mac/PlatformScrollBarMac.mm:
2590         (WebCore::PlatformScrollBar::updateThumbPosition):
2591         (WebCore::PlatformScrollBar::updateThumbProportion):
2592         * platform/win/PlatformScrollBar.h:
2593         * platform/win/TemporaryLinkStubs.cpp:
2594         (PlatformScrollBar::updateThumbPosition):
2595         (PlatformScrollBar::updateThumbProportion):
2596         * rendering/RenderLayer.cpp:
2597         (WebCore::RenderLayer::updateScrollInfoAfterLayout):
2598
2599 2006-09-23  Alexey Proskuryakov  <ap@nypop.com>
2600
2601         Reviewed by Eric.
2602
2603         http://bugs.webkit.org/show_bug.cgi?id=4872
2604         XMLHttpRequest fails to throw an exception when there is a security violation
2605         (mismatching domains)
2606
2607         Raise an exception if there is a security violation, and also in cases required by
2608         the current draft of XHR specification.
2609
2610         * bindings/js/JSXMLHttpRequest.cpp:
2611         (KJS::JSXMLHttpRequest::getValueProperty): Raise an exception if a DOM method reports one.
2612         (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Raise an exception if a DOM method
2613         reports one, and also if there were too few arguments passed.
2614
2615         * bindings/js/kjs_binding.cpp:
2616         (KJS::setDOMException): Added support for custom XHR exceptions.
2617
2618         * xml/xmlhttprequest.h: Changed state names to match the current spec. Defined an
2619         exception code range for XHR exceptions.
2620
2621         * xml/xmlhttprequest.cpp:
2622         (WebCore::XMLHttpRequest::open): Removed a check for m_aborted that could never succeed.
2623         (WebCore::XMLHttpRequest::send):
2624         (WebCore::XMLHttpRequest::setRequestHeader):
2625         (WebCore::XMLHttpRequest::getStatus):
2626         (WebCore::XMLHttpRequest::getStatusText):
2627         (WebCore::XMLHttpRequest::processSyncLoadResults):
2628         (WebCore::XMLHttpRequest::receivedAllData):
2629         (WebCore::XMLHttpRequest::receivedData):
2630
2631 2006-09-22  Steve Falkenburg  <sfalken@apple.com>
2632
2633         Reviewed by Jeff Jenkins.
2634
2635         Tweak CF types.
2636
2637         * platform/cf/ResourceLoaderCFNet.cpp:
2638         (WebCore::willCacheResponse):
2639
2640 2006-09-22  Justin Garcia  <justin.garcia@apple.com>
2641
2642         Reviewed by darin
2643
2644         <http://bugs.webkit.org/show_bug.cgi?id=8029>
2645         Rename Node::isAncestor and RenderObject::hasAncestor to isDescendantOf
2646
2647         * dom/Document.cpp:
2648         (WebCore::Document::clearSelectionIfNeeded):
2649         * dom/Element.cpp:
2650         (WebCore::Element::contains):
2651         * dom/Node.cpp:
2652         (WebCore::Node::traverseNextNode):
2653         (WebCore::Node::traverseNextSibling):
2654         (WebCore::Node::traversePreviousNodePostOrder):
2655         (WebCore::Node::checkAddChild):
2656         (WebCore::Node::isDescendantOf):
2657         * dom/Node.h:
2658         * dom/NodeIterator.cpp:
2659         (WebCore::NodeIterator::notifyBeforeNodeRemoval):
2660         * editing/ApplyStyleCommand.cpp:
2661         (WebCore::ApplyStyleCommand::applyBlockStyle):
2662         (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
2663         (WebCore::ApplyStyleCommand::applyInlineStyle):
2664         (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode):
2665         * editing/CompositeEditCommand.cpp:
2666         (WebCore::CompositeEditCommand::mergeIdenticalElements):
2667         (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
2668         * editing/DeleteSelectionCommand.cpp:
2669         (WebCore::updatePositionForNodeRemoval):
2670         (WebCore::DeleteSelectionCommand::handleGeneralDelete):
2671         (WebCore::DeleteSelectionCommand::mergeParagraphs):
2672         * editing/FormatBlockCommand.cpp:
2673         (WebCore::FormatBlockCommand::doApply):
2674         * editing/IndentOutdentCommand.cpp:
2675         (WebCore::enclosingListOrBlockquote):
2676         * editing/Selection.cpp:
2677         (WebCore::Selection::validate):
2678         * editing/SelectionController.cpp:
2679         (WebCore::SelectionController::nodeWillBeRemoved):
2680         * editing/TextIterator.cpp:
2681         (WebCore::SimplifiedBackwardsTextIterator::advance):
2682         * editing/VisiblePosition.cpp:
2683         (WebCore::VisiblePosition::next):
2684         (WebCore::VisiblePosition::previous):
2685         (WebCore::VisiblePosition::canonicalPosition):
2686         (WebCore::isFirstVisiblePositionInNode):
2687         (WebCore::isLastVisiblePositionInNode):
2688         * editing/htmlediting.cpp:
2689         (WebCore::firstEditablePositionAfterPositionInRoot):
2690         (WebCore::lastEditablePositionBeforePositionInRoot):
2691         (WebCore::enclosingNodeWithTag):
2692         (WebCore::enclosingList):
2693         (WebCore::enclosingListChild):
2694         * editing/markup.cpp:
2695         (WebCore::createMarkup):
2696
2697 2006-09-22  Timothy Hatcher  <timothy@apple.com>
2698
2699         Reviewed by Darin.
2700
2701         - Added @property syntax to non-generated headers
2702           inside #ifndef BUILDING_ON_TIGER.
2703         - Changed the DOMEventTarget protocol to have have new versions
2704           of addEventListener and removeEventListener with named parameters.
2705           These old style methods can be removed once Mail changes to use
2706           the new methods <rdar://problem/4746649>.
2707
2708         * WebCorePrefix.h: define BUILDING_ON_TIGER when Tiger is the target
2709         * bindings/objc/DOM.mm:
2710         (-[DOMNode addEventListener:listener:useCapture:]):
2711         (-[DOMNode addEventListener:::]): call the new method
2712         (-[DOMNode removeEventListener:listener:useCapture:]):
2713         (-[DOMNode removeEventListener:::]): call the new method
2714         * bindings/objc/DOMAbstractView.h:
2715         * bindings/objc/DOMEventTarget.h:
2716         * bindings/objc/DOMHTMLAppletElement.h:
2717         * bindings/objc/DOMHTMLEmbedElement.h:
2718         * bindings/objc/DOMHTMLOptionElement.h:
2719         * bindings/objc/DOMObject.h:
2720         * bindings/objc/DOMRGBColor.h:
2721
2722 2006-09-22  Nikolas Zimmermann  <zimmermann@kde.org>
2723
2724         Reviewed by Eric.
2725
2726         Fix Qt/Linux build and a really stupid mixup in GraphicsContextQt.
2727
2728         * platform/qt/FrameQt.cpp:
2729         * platform/qt/GraphicsContextQt.cpp:
2730         (WebCore::GraphicsContext::translate): Make it actually translate, not scale! :-)
2731         (WebCore::GraphicsContext::origin):
2732         * platform/qt/PlatformScrollBar.h: Added.
2733         (WebCore::PlatformScrollBar::isWidget):
2734         * platform/qt/WidgetQt.cpp:
2735         (WebCore::Widget::invalidate):
2736         (WebCore::Widget::invalidateRect):
2737
2738 2006-09-22  Dave Hyatt <hyatt@apple.com>
2739
2740         Super-minor tweaks to the systemFont function on Mac.
2741         Set the generic family to None rather than to Serif, and
2742         don't waste time setting the computed size, since that is
2743         set from the specified size over in CSSStyleSelector anyway.
2744
2745         * rendering/RenderThemeMac.mm:
2746         (WebCore::RenderThemeMac::systemFont):
2747
2748 2006-09-22  Timothy Hatcher  <timothy@apple.com>
2749
2750         Reviewed by Brady.
2751
2752         Build fix for Xcode 2.3. Convert GraphicsContext::translate() to
2753         take floats. There was already an implicit conversion to float/double
2754         when calling CGContextTranslateCTM or cairo_translate.
2755
2756         * platform/GraphicsContext.h:
2757         * platform/cairo/GraphicsContextCairo.cpp:
2758         (WebCore::GraphicsContext::translate):
2759         * platform/cg/GraphicsContextCG.cpp:
2760         (WebCore::GraphicsContext::translate):
2761
2762 2006-09-22  Brady Eidson  <beidson@apple.com>
2763
2764         Reviewed by Sfalken
2765
2766         Add redirect and other cleanup to ResourceLoaderWin.cpp
2767         Fixes bug http://bugs.webkit.org/show_bug.cgi?id=10927
2768         Fixes bug http://bugs.webkit.org/show_bug.cgi?id=10744
2769
2770         * WebCore.xcodeproj/project.pbxproj:
2771         * platform/ResourceLoader.h:
2772         * platform/win/ResourceLoaderWin.cpp:
2773         (WebCore::ResourceLoaderWndProc):
2774         (WebCore::initializeOffScreenResourceLoaderWindow):
2775         (WebCore::ResourceLoader::onHandleCreated):
2776         (WebCore::ResourceLoader::onRequestRedirected):
2777         (WebCore::ResourceLoader::onRequestComplete):
2778         (WebCore::transferJobStatusCallback):
2779
2780 2006-09-22  Alexey Proskuryakov  <ap@nypop.com>
2781
2782         Reviewed by Geoff.
2783
2784         http://bugs.webkit.org/show_bug.cgi?id=10803
2785         REGRESSION (r15536-r15544): manual-tests/bugzilla-6821.html failing
2786
2787         * page/FrameView.cpp:
2788         (WebCore::FrameView::hoverTimerFired): Use the current event.
2789
2790 2006-09-22  Nikolas Zimmermann  <zimmermann@kde.org>
2791
2792         Reviewed by Anders.
2793
2794         Fix (last) svg memory leak.
2795
2796         * ksvg2/svg/SVGTransformable.cpp: delete 't' in error case.
2797         (SVGTransformable::parseTransformAttribute):
2798
2799 2006-09-22  Eric Seidel  <eric@eseidel.com>
2800
2801         No review necessary, just removing a dead file.
2802
2803         Remove unused file (added previously by mistake) to make room for real implementation.
2804
2805         * platform/mac/BitmapImageMac.mm: Removed.
2806
2807 2006-09-22  Dave Hyatt <hyatt@apple.com>
2808
2809         Move PlatformScrollBar.h down into the platforms.
2810
2811         Reviewed by andersca
2812
2813         * platform/PlatformScrollBar.h: Removed.
2814         * platform/win/PlatformScrollBar.h: Added.
2815         * platform/mac/PlatformScrollBar.h: Added.
2816
2817 2006-09-22   Dave Hyatt  <hyatt@apple.com>
2818
2819         Add support for invalidation of widgets.  This will be needed for the Win32 widget subsystem (and for
2820         any widget subsystems that don't have any underlying native objects backing the widgets.
2821
2822         Reviewed by anders
2823
2824         * platform/Widget.h:
2825         * platform/mac/WidgetMac.mm:
2826         (WebCore::Widget::invalidate):
2827         (WebCore::Widget::invalidateRect):
2828         * platform/win/TemporaryLinkStubs.cpp:
2829         (Widget::invalidate):
2830         (Widget::invalidateRect):
2831
2832 2006-09-22  Rob Buis  <buis@kd.org>
2833
2834         Reviewed by eseidel.
2835
2836         http://bugs.webkit.org/show_bug.cgi?id=10901
2837         Merge build fixes from unity
2838
2839         * CMakeLists.txt:
2840
2841 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
2842
2843         Reviewed by eseidel.
2844
2845         http://bugs.webkit.org/show_bug.cgi?id=10977
2846         SVGDocument does not expose 'rootElement' property
2847
2848         Enable 'rootElement' property.
2849
2850         * ksvg2/svg/SVGDocument.idl:
2851
2852 2006-09-21  Steve Falkenburg  <sfalken@apple.com>
2853
2854         Tweak includes.
2855
2856         * platform/ResourceLoaderInternal.h:
2857
2858 2006-09-21  Geoffrey Garen  <ggaren@apple.com>
2859
2860         build fixed. band happy.
2861
2862         * platform/cg/GraphicsContextCG.cpp:
2863         (WebCore::GraphicsContext::translate):
2864         * platform/mac/WidgetMac.mm:
2865
2866 2006-09-21  Geoffrey Garen  <ggaren@apple.com>
2867
2868         Reviewed by Maciej.
2869
2870         Some Widget refactoring.
2871
2872         * WebCore.vcproj/WebCore/WebCore.vcproj:
2873         * bridge/mac/FrameMac.mm:
2874         * bridge/win/FrameWin.cpp:
2875         (WebCore::FrameWin::runJavaScriptAlert):
2876         (WebCore::FrameWin::runJavaScriptConfirm):
2877         * bridge/win/PageWin.cpp:
2878         (WebCore::Page::Page):
2879         (WebCore::rootWindowForFrame):
2880         * html/CanvasRenderingContext2D.cpp:
2881         (WebCore::CanvasRenderingContext2D::translate):
2882         * page/FrameView.cpp:
2883         (WebCore::FrameView::isFrameView):
2884         * page/Page.h:
2885         (WebCore::Page::setInstanceHandle):
2886         (WebCore::Page::instanceHandle):
2887         * platform/GraphicsContext.h:
2888         * platform/ScrollView.h:
2889         * platform/Widget.h:
2890         * platform/cairo/GraphicsContextCairo.cpp:
2891         (WebCore::GraphicsContext::translate):
2892         (WebCore::GraphicsContext::origin):
2893         * platform/mac/WidgetMac.mm:
2894         (WebCore::Widget::clearFocus):
2895         * platform/win/ResourceLoaderWin.cpp:
2896         (WebCore::initializeOffScreenResourceLoaderWindow):
2897         * platform/win/ScreenWin.cpp:
2898         (WebCore::monitorInfo):
2899         * platform/win/ScrollViewWin.cpp:
2900         (WebCore::ScrollView::updateContents):
2901         (WebCore::ScrollView::visibleWidth):
2902         (WebCore::ScrollView::visibleHeight):
2903         (WebCore::ScrollView::visibleContentRect):
2904         (WebCore::ScrollView::viewportToContents):
2905         (WebCore::ScrollView::contentsToViewport):
2906         (WebCore::ScrollView::scrollBy):
2907         (WebCore::ScrollView::updateScrollInfo):
2908         (WebCore::ScrollView::updateScrollBars):
2909         * platform/win/SharedTimerWin.cpp:
2910         (WebCore::initializeOffScreenTimerWindow):
2911         * platform/win/TemporaryLinkStubs.cpp:
2912         (FrameView::updateBorder):
2913         (ScrollView::paint):
2914         (GraphicsContext::clip):
2915         * platform/win/WidgetWin.cpp:
2916         (WebCore::Widget::Widget):
2917         (WebCore::Widget::parentWindow):
2918         (WebCore::Widget::setParentWindow):
2919         (WebCore::Widget::frameGeometry):
2920         (WebCore::Widget::hasFocus):
2921         (WebCore::Widget::setFocus):
2922         (WebCore::Widget::show):
2923         (WebCore::Widget::hide):
2924         (WebCore::Widget::setFrameGeometry):
2925
2926 2006-09-22  Anders Carlsson  <acarlsson@apple.com>
2927
2928         Reviewed by Tim H.
2929
2930         * platform/TextEncoding.cpp:
2931         (WebCore::TextEncoding::backslashAsCurrencySymbol):
2932         Add comment clarifying why backslashAsCurrencySymbol is needed.
2933
2934 2006-09-21  Sean Gies  <seangies@apple.com>
2935
2936         Reviewed by Adam Roben.
2937
2938         Add utility functions to get and release HDC from GraphicsContext.
2939
2940         * platform/GraphicsContext.h: Add utilities to get and release HDC.
2941         * platform/cairo/GraphicsContextCairo.cpp: Implement new utilities.
2942         * rendering/RenderThemeWin.cpp: Switch to new utilities.
2943
2944 2006-09-21  Justin Garcia  <justin.garcia@apple.com>
2945
2946         Reviewed by anders
2947
2948         <rdar://problem/4426622>
2949         Plain text paste slow.  Time spent mostly in WebCore::rebalanceWhitespaceInTextNode(...)
2950
2951         * editing/htmlediting.cpp:
2952         (WebCore::rebalanceWhitespaceInTextNode): We no longer need to use a RegExp replace because we
2953         aren't producing complicated sequences here.  Use multiple UChar -> UChar replaces instead for speed.
2954         Got rid of uses of DepricatedString.
2955
2956 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
2957
2958         Reviewed by eseidel.
2959
2960         Don't crash if no IconDatabase is available (ie. on Qt/Gdk)
2961
2962         * page/Frame.cpp:
2963         (WebCore::Frame::endIfNotLoading):
2964
2965 2006-09-21  Nikolas Zimmermann  <zimmermann@kde.org>
2966
2967         Reviewed by eseidel.
2968
2969         Fix Qt/Linux build.
2970
2971         * CMakeLists.txt:
2972         * kcanvas/device/qt/KCanvasClipperQt.h:
2973         * kcanvas/device/qt/KRenderingDeviceQt.cpp:
2974         * platform/qt/FrameQt.cpp:
2975         (WebCore::FrameQt::isLoadTypeReload):
2976         (WebCore::FrameQt::originalRequestURL):
2977         * platform/qt/FrameQt.h:
2978         * platform/qt/GraphicsContextQt.cpp:
2979         (WebCore::GraphicsContext::concatCTM):
2980         * platform/qt/ScrollViewQt.cpp:
2981         (WebCore::ScrollView::wheelEvent):
2982         * platform/qt/TemporaryLinkStubs.cpp:
2983         (WebCore::IconDatabase::setIconURLForPageURL):
2984
2985 2006-09-20  Justin Garcia  <justin.garcia@apple.com>
2986
2987         Reviewed by john
2988
2989         <http://bugs.webkit.org/show_bug.cgi?id=7165>
2990         TinyMCE: Dragging & dropping content always leaves a copy when editing inside a subframe
2991
2992         * editing/MoveSelectionCommand.cpp:
2993         (WebCore::MoveSelectionCommand::MoveSelectionCommand): Set the document
2994         to the position-to-move-to's document, not the fragment's document.  The
2995         fragment's document is the document used to create the fragment and is irrelavant.
2996
2997 === Safari-521.27 ===
2998
2999 2006-09-21  Brady Eidson  <beidson@apple.com>
3000
3001         Reviewed by Anders
3002
3003         When your assumption is "IconDatabase::sharedIconDatabase()" will never fail but it does, you're in trouble
3004         This fixes Spinneret so it won't crash on its first load!
3005
3006         * page/Frame.cpp:
3007         (WebCore::Frame::endIfNotLoading):
3008
3009 2006-09-21  Brady Eidson  <beidson@apple.com>
3010
3011         Build fix
3012
3013         * platform/win/TemporaryLinkStubs.cpp:
3014         (ScrollView::wheelEvent):
3015
3016 2006-09-20  Rob Buis  <buis@kde.org>
3017
3018         Reviewed by eseidel.
3019
3020         http://bugs.webkit.org/show_bug.cgi?id=10946
3021         new marker code draws end-marker in wrong place
3022
3023         Keep track of the start of the subpath so we can handle
3024         closeTo/moveTo correctly.
3025
3026         * kcanvas/RenderPath.cpp:
3027         (WebCore::DrawMarkersData::DrawMarkersData):
3028         (WebCore::updateMarkerDataForElement):
3029
3030 2006-09-21  David Hyatt <hyatt@apple.com>
3031
3032         Wheel scrolling prep for Win32.
3033
3034         WARNING: NO TEST CASES ADDED OR CHANGED
3035
3036         * platform/PlatformWheelEvent.h:
3037         * platform/ScrollBar.h:
3038         * platform/ScrollView.h:
3039         * platform/mac/ScrollViewMac.mm:
3040         (WebCore::ScrollView::wheelEvent):
3041         * rendering/RenderLayer.cpp:
3042
3043 2006-09-20  Timothy Hatcher  <timothy@apple.com>
3044
3045         Reviewed by Hyatt.
3046
3047         Bug 10917: REGRESSION (r16027): iFrame transparency broken
3048         http://bugs.webkit.org/show_bug.cgi?id=10917
3049
3050         Don't paint the base background color if we transparent.
3051
3052         * rendering/RenderBox.cpp:
3053         (WebCore::RenderBox::paintBackgroundExtended):
3054
3055 2006-09-20  Adam Roben  <aroben@apple.com>
3056
3057         Reviewed by andersca.
3058
3059         * platform/FileChooser.h: Remove no-longer-necessary namespace std
3060
3061 2006-09-20  Eric Seidel  <eric@eseidel.com>
3062
3063         Reviewed by beth.
3064
3065         Cleanup style in KCanvas.
3066         Remove extra white-space, unneeded arguments, etc.
3067
3068         * WebCore.xcodeproj/project.pbxproj:
3069         * kcanvas/KCanvasClipper.cpp:
3070         (WebCore::operator<<):
3071         (WebCore::KCanvasClipper::externalRepresentation):
3072         * kcanvas/KCanvasClipper.h:
3073         * kcanvas/KCanvasFilters.cpp:
3074         (WebCore::KCanvasFilter::externalRepresentation):
3075         (WebCore::operator<<):
3076         (WebCore::KCanvasFilterEffect::externalRepresentation):
3077         (WebCore::KCPointLightSource::externalRepresentation):
3078         (WebCore::KCSpotLightSource::externalRepresentation):
3079         (WebCore::KCDistantLightSource::externalRepresentation):
3080         (WebCore::KCanvasFEBlend::externalRepresentation):
3081         (WebCore::KCanvasFEColorMatrix::externalRepresentation):
3082         (WebCore::KCanvasFEComponentTransfer::externalRepresentation):
3083         (WebCore::KCanvasFEComposite::externalRepresentation):
3084         (WebCore::KCanvasFEConvolveMatrix::externalRepresentation):
3085         (WebCore::KCanvasFEDiffuseLighting::externalRepresentation):
3086         (WebCore::KCanvasFEDisplacementMap::externalRepresentation):
3087         (WebCore::KCanvasFEFlood::externalRepresentation):
3088         (WebCore::KCanvasFEGaussianBlur::externalRepresentation):
3089         (WebCore::KCanvasFEImage::externalRepresentation):
3090         (WebCore::KCanvasFEMerge::externalRepresentation):
3091         (WebCore::KCanvasFEMorphology::externalRepresentation):
3092         (WebCore::KCanvasFEOffset::externalRepresentation):
3093         (WebCore::KCanvasFESpecularLighting::externalRepresentation):
3094         (WebCore::KCanvasFETile::externalRepresentation):
3095         (WebCore::KCanvasFETurbulence::externalRepresentation):
3096         * kcanvas/KCanvasFilters.h:
3097         (WebCore::KCanvasFEDiffuseLighting::lightSource):
3098         (WebCore::KCanvasFESpecularLighting::lightSource):
3099         * kcanvas/KCanvasImage.h:
3100         * kcanvas/KCanvasMarker.cpp:
3101         (WebCore::KCanvasMarker::externalRepresentation):
3102         * kcanvas/KCanvasMarker.h:
3103         * kcanvas/KCanvasResource.cpp:
3104         (WebCore::operator<<):
3105         * kcanvas/KCanvasResource.h:
3106         * kcanvas/KCanvasTreeDebug.cpp:
3107         (WebCore::operator<<):
3108         (WebCore::writeIndent):
3109         (WebCore::writeStyle):
3110         (WebCore::write):
3111         (WebCore::writeRenderResources):
3112         * kcanvas/KCanvasTreeDebug.h:
3113         (WebCore::operator<<):
3114         * kcanvas/RenderForeignObject.cpp:
3115         (WebCore::RenderForeignObject::paint):
3116         * kcanvas/RenderPath.cpp:
3117         (WebCore::RenderPath::paint):
3118         (WebCore::drawStartAndMidMarkers):
3119         * kcanvas/RenderSVGContainer.cpp:
3120         (WebCore::RenderSVGContainer::paint):
3121         * kcanvas/RenderSVGImage.cpp:
3122         (WebCore::RenderSVGImage::translateForAttributes):
3123         * kcanvas/RenderSVGImage.h:
3124         * kcanvas/device/KRenderingDevice.cpp:
3125         (WebCore::KRenderingDevice::currentContext):
3126         (WebCore::KRenderingDevice::popContext):
3127         (WebCore::KRenderingDevice::pushContext):
3128         * kcanvas/device/KRenderingDevice.h:
3129         * kcanvas/device/KRenderingFillPainter.h:
3130         * kcanvas/device/KRenderingPaintServer.h:
3131         (WebCore::KRenderingPaintServer::KRenderingPaintServer):
3132         (WebCore::KRenderingPaintServer::activeClient):
3133         (WebCore::KRenderingPaintServer::setActiveClient):
3134         * kcanvas/device/KRenderingPaintServerGradient.cpp:
3135         (WebCore::operator<<):
3136         (WebCore::KRenderingPaintServerGradient::externalRepresentation):
3137         (WebCore::KRenderingPaintServerLinearGradient::externalRepresentation):
3138         (WebCore::KRenderingPaintServerGradient::listener):
3139         (WebCore::KRenderingPaintServerGradient::setListener):
3140         (WebCore::KRenderingPaintServerRadialGradient::externalRepresentation):
3141         * kcanvas/device/KRenderingPaintServerGradient.h:
3142         * kcanvas/device/KRenderingPaintServerPattern.cpp:
3143         (WebCore::KRenderingPaintServerPattern::tile):
3144         (WebCore::KRenderingPaintServerPattern::setTile):
3145         (WebCore::KRenderingPaintServerPattern::listener):
3146         (WebCore::KRenderingPaintServerPattern::setListener):
3147         (WebCore::KRenderingPaintServerPattern::externalRepresentation):
3148         * kcanvas/device/KRenderingPaintServerPattern.h:
3149         * kcanvas/device/KRenderingPaintServerSolid.cpp:
3150         (WebCore::KRenderingPaintServerSolid::externalRepresentation):
3151         * kcanvas/device/KRenderingPaintServerSolid.h:
3152         * kcanvas/device/KRenderingStrokePainter.cpp:
3153         (WebCore::KRenderingStrokePainter::strokeMiterLimit):
3154         (WebCore::KRenderingStrokePainter::setStrokeMiterLimit):
3155         * kcanvas/device/KRenderingStrokePainter.h:
3156         * kcanvas/device/quartz/KCanvasFilterQuartz.h:
3157         * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
3158         (WebCore::KCanvasFilterQuartz::prepareFilter):
3159         * kcanvas/device/quartz/KCanvasItemQuartz.h: Removed.
3160         * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
3161         (WebCore::KCanvasMaskerQuartz::applyMask):
3162         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
3163         (WebCore::KCanvasImageQuartz::init):
3164         * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
3165         (WebCore::KCanvasClipperQuartz::applyClip):
3166         * kcanvas/device/quartz/KRenderingDeviceQuartz.h:
3167         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
3168         (WebCore::KRenderingDeviceQuartz::quartzContext):
3169         (WebCore::KRenderingDeviceQuartz::contextForImage):
3170         (WebCore::KRenderingDeviceQuartz::createPaintServer):
3171         (WebCore::KRenderingDeviceQuartz::createResource):
3172         (WebCore::KRenderingDeviceQuartz::createFilterEffect):
3173         * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
3174         (WebCore::CGShadingRefForLinearGradient):
3175         (WebCore::CGShadingRefForRadialGradient):
3176         (WebCore::KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
3177         (WebCore::KRenderingPaintServerGradientQuartz::teardown):
3178         * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
3179         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
3180         (WebCore::KRenderingPaintServerQuartzHelper::strokePath):
3181         (WebCore::KRenderingPaintServerQuartzHelper::clipToStrokePath):
3182         (WebCore::KRenderingPaintServerQuartzHelper::fillPath):
3183         (WebCore::KRenderingPaintServerQuartzHelper::clipToFillPath):
3184         (WebCore::KRenderingPaintServerSolidQuartz::draw):
3185         (WebCore::KRenderingPaintServerSolidQuartz::setup):
3186         (WebCore::KRenderingPaintServerSolidQuartz::renderPath):
3187         (WebCore::KRenderingPaintServerPatternQuartz::setup):
3188         (WebCore::KRenderingPaintServerPatternQuartz::renderPath):
3189         (WebCore::KRenderingPaintServerPatternQuartz::teardown):
3190         * kcanvas/device/quartz/QuartzSupport.h:
3191         * kcanvas/device/quartz/QuartzSupport.mm:
3192         (WebCore::applyStrokeStyleToContext):
3193
3194 2006-09-20  Anders Carlsson  <acarlsson@apple.com>
3195
3196         Reviewed by Dave Hyatt.
3197
3198         * dom/WheelEvent.cpp:
3199         (WebCore::WheelEvent::WheelEvent):
3200         Use lroundf instead of lround since deltas are floats.
3201
3202 2006-09-20  Julien Palmas  <julien.palmas@gmail.com>
3203
3204         Reviewed by eseidel.  Landed by eseidel.
3205
3206         Test: svg/custom/pattern-y-offset.svg
3207
3208         * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
3209         (WebCore::KRenderingPaintServerPatternQuartz::setup):
3210
3211 2006-09-20  David Hyatt  <hyatt@apple.com>
3212
3213         Add a new wheelEvent method to ScrollView.  Platforms that wish
3214         to handle the wheel event for the scroll view themselves can then
3215         do so there.  (Mac lets the underlying NSScrollView do it for now.)
3216
3217         * page/FrameView.cpp:
3218         (WebCore::FrameView::handleWheelEvent):
3219         * platform/ScrollView.h:
3220         (WebCore::ScrollView::wheelEvent):
3221
3222 2006-09-20  Brady Eidson  <beidson@apple.com>
3223
3224         Reviewed by Tim Omernick
3225
3226         Part of fixing a crash Tim O showed me that I missed in a release build.
3227         WebKit should be able to call through the bridge to WebCore no matter what -
3228         Replace the _iconDB member with calls to IconDatabase::sharedIconDatabase()
3229
3230         * bridge/mac/WebCoreIconDatabaseBridge.h:
3231         * bridge/mac/WebCoreIconDatabaseBridge.mm:
3232         (-[WebCoreIconDatabaseBridge closeSharedDatabase]):
3233         (-[WebCoreIconDatabaseBridge isOpen]):
3234         (-[WebCoreIconDatabaseBridge removeAllIcons]):
3235         (-[WebCoreIconDatabaseBridge _isEmpty]):
3236         (-[WebCoreIconDatabaseBridge isIconExpiredForIconURL:]):
3237         (-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]):
3238         (-[WebCoreIconDatabaseBridge privateBrowsingEnabled]):
3239         (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]):
3240         (-[WebCoreIconDatabaseBridge iconURLForPageURL:]):
3241         (-[WebCoreIconDatabaseBridge defaultIconWithSize:]):
3242         (-[WebCoreIconDatabaseBridge retainIconForURL:]):
3243         (-[WebCoreIconDatabaseBridge releaseIconForURL:]):
3244         (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]):
3245         (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]):
3246         (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]):
3247         (-[WebCoreIconDatabaseBridge _hasEntryForIconURL:]):
3248         (-[WebCoreIconDatabaseBridge _setEnabled:]):
3249         (-[WebCoreIconDatabaseBridge _isEnabled]):
3250
3251 2006-09-20  Anders Carlsson  <acarlsson@apple.com>
3252
3253         Reviewed by Darin.
3254
3255         Add String::split which returns a Vector of Strings and use it instead of
3256         DeprecatedStringList.
3257
3258         * bindings/js/kjs_events.cpp:
3259         (KJS::Clipboard::getValueProperty):
3260         * bindings/js/kjs_window.cpp:
3261         (KJS::parseModalDialogFeatures):
3262         * css/MediaList.cpp:
3263         (WebCore::MediaList::setMediaText):
3264         * dom/Clipboard.h:
3265         * html/HTMLFormElement.cpp:
3266         (WebCore::HTMLFormElement::formData):
3267         * html/HTMLLinkElement.cpp:
3268         (WebCore::HTMLLinkElement::tokenizeRelAttribute):
3269         * platform/PlatformString.h:
3270         * platform/String.cpp:
3271         (WebCore::String::split):
3272         * platform/StringImpl.cpp:
3273         * platform/StringImpl.h:
3274         * platform/mac/ClipboardMac.h:
3275         * platform/mac/ClipboardMac.mm:
3276         (WebCore::ClipboardMac::types):
3277
3278 2006-09-20  Justin Garcia  <justin.garcia@apple.com>
3279
3280         Reviewed by harrison
3281
3282         * css/cssstyleselector.cpp:
3283         (WebCore::CSSStyleSelector::adjustRenderStyle): Don't call
3284         HTMLElement::isContentEditable just to check the Frame's editability, since
3285         it calls updateRenderering, which can get us into infinite recursion.
3286
3287 2006-09-20  Brady Eidson  <beidson@apple.com>
3288
3289         Reviewed by Darin
3290
3291         Cleaned up my last patch alot, and made the WebCore icon database disabled by default
3292
3293         * loader/icon/IconDatabase.cpp:
3294         (WebCore::IconDatabase::IconDatabase): Disabled by default
3295         (WebCore::IconDatabase::removeAllIcons): Respect just isOpen() (disabled database will always be closed)
3296         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ditto
3297         (WebCore::IconDatabase::iconForPageURL): Ditto
3298         (WebCore::IconDatabase::isIconExpiredForIconURL): Ditto
3299         (WebCore::IconDatabase::iconURLForPageURL): Ditto
3300         (WebCore::IconDatabase::retainIconForPageURL): Ditto
3301         (WebCore::IconDatabase::releaseIconForPageURL): Ditto
3302         (WebCore::IconDatabase::setIconDataForIconURL): Ditto
3303         (WebCore::IconDatabase::setIconURLForPageURL): Ditto
3304         (WebCore::IconDatabase::hasEntryForIconURL): Ditto
3305         (WebCore::IconDatabase::setEnabled): Fixed a big bug here!
3306
3307 2006-09-20  Adam Roben  <aroben@apple.com>
3308
3309         Reviewed by Adele.
3310
3311         Fixes http://bugs.webkit.org/show_bug.cgi?id=10935
3312         REGRESSION: file upload control with direction:rtl or text-align:right
3313         draws button on top of filename/icon
3314
3315         * rendering/RenderFileUploadControl.cpp:
3316         (WebCore::RenderFileUploadControl::setStyle): Force text-align to
3317         match direction
3318         (WebCore::RenderFileUploadControl::paintObject): Fix positioning of
3319         the filename and icon in RTL
3320
3321 2006-09-20  Alice Liu  <alice.liu@apple.com>
3322
3323         Reviewed by Adam Roben.
3324
3325         fixed windows build
3326
3327         * dom/WheelEvent.cpp:
3328         (WebCore::WheelEvent::WheelEvent):
3329         changed lrint to lround
3330
3331 2006-09-20  Sam Weinig  <sam.weinig@gmail.com>
3332
3333         Build Fix.  Adds isHorizontal attribute back to WheelEvent
3334         for the Objective-C bindings.  If it is found that isHorizontal
3335         is not used, we should remove it again but also remove it's
3336         declaration from PublicDOMInterfaces.h
3337
3338         * dom/WheelEvent.h:
3339         (WebCore::WheelEvent::isHorizontal):
3340         * dom/WheelEvent.idl:
3341
3342 2006-09-20  David Hyatt  <hyatt@apple.com>
3343
3344         Fix for 10945, WheelEvent should support two dimensions at once, since
3345         MacBooks allow for diagonal scrolling.  Also enhance the PlatformWheelEvent
3346         to allow for diagonal scrolling.
3347
3348         Reviewed by Eric
3349
3350         * dom/EventTargetNode.cpp:
3351         (WebCore::EventTargetNode::dispatchWheelEvent):
3352         * dom/WheelEvent.cpp:
3353         (WebCore::WheelEvent::WheelEvent):
3354         (WebCore::WheelEvent::initWheelEvent):
3355         * dom/WheelEvent.h:
3356         (WebCore::WheelEvent::wheelDelta):
3357         (WebCore::WheelEvent::wheelDeltaX):
3358         (WebCore::WheelEvent::wheelDeltaY):
3359         * dom/WheelEvent.idl:
3360         * page/FrameView.cpp:
3361         (WebCore::FrameView::handleWheelEvent):
3362         * platform/PlatformWheelEvent.h:
3363         (WebCore::PlatformWheelEvent::deltaX):
3364         (WebCore::PlatformWheelEvent::deltaY):
3365         (WebCore::PlatformWheelEvent::normalize):
3366         * platform/mac/WheelEventMac.mm:
3367         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
3368
3369 2006-09-19  Eric Seidel  <eric@eseidel.com>
3370
3371         Reviewed by hyatt.
3372
3373         Split KCanvasResources.* into multiple files (and some other minor spacing changes).
3374
3375         No tests were harmed in the making of this patch.
3376
3377         * WebCore.xcodeproj/project.pbxproj:
3378         * kcanvas/KCanvasClipper.cpp: Added.
3379         (WebCore::operator<<):
3380         * kcanvas/KCanvasClipper.h: Added.
3381         * kcanvas/KCanvasFilters.h:
3382         * kcanvas/KCanvasImage.h:
3383         * kcanvas/KCanvasMarker.cpp: Added.
3384         * kcanvas/KCanvasMarker.h: Added.
3385         * kcanvas/KCanvasMasker.cpp: Added.
3386         (WebCore::KCanvasMasker::KCanvasMasker):
3387         (WebCore::KCanvasMasker::setMask):
3388         (WebCore::KCanvasMasker::externalRepresentation):
3389         (WebCore::getMaskerById):
3390         * kcanvas/KCanvasMasker.h: Added.
3391         * kcanvas/KCanvasResource.cpp: Added.
3392         (WebCore::KCanvasResource::invalidate):
3393         (WebCore::KCanvasResource::externalRepresentation):
3394         (WebCore::getResourceById):
3395         (WebCore::getPaintServerById):
3396         * kcanvas/KCanvasResource.h: Added.
3397         * kcanvas/KCanvasResources.cpp: Removed.
3398         * kcanvas/KCanvasResources.h: Removed.
3399         * kcanvas/RenderPath.cpp:
3400         * kcanvas/RenderSVGContainer.cpp:
3401         * kcanvas/RenderSVGImage.cpp:
3402         * kcanvas/RenderSVGText.cpp:
3403         * kcanvas/device/KRenderingPaintServer.h:
3404         * kcanvas/device/quartz/KCanvasMaskerQuartz.h:
3405         * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
3406         * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
3407         * ksvg2/svg/SVGClipPathElement.h:
3408         * ksvg2/svg/SVGFEColorMatrixElement.cpp:
3409         * ksvg2/svg/SVGFEComponentTransferElement.cpp:
3410         * ksvg2/svg/SVGFECompositeElement.cpp:
3411         * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
3412         * ksvg2/svg/SVGFELightElement.cpp:
3413         * ksvg2/svg/SVGFEOffsetElement.cpp:
3414         * ksvg2/svg/SVGFETurbulenceElement.cpp:
3415         * ksvg2/svg/SVGFilterElement.cpp:
3416         * ksvg2/svg/SVGLinearGradientElement.cpp:
3417         * ksvg2/svg/SVGMarkerElement.h:
3418         * ksvg2/svg/SVGMaskElement.h:
3419
3420 2006-09-19  Brady Eidson <beidson@apple.com>
3421
3422         Reviewed by Sarge Decker
3423
3424         <rdar://problem/4739892> and <rdar://problem/4729797>
3425         - WebCore::IconDatabase needs to have and respect an enabled() flag
3426         - Mail on ToT WebKit crashes in IconDatabase code when mailing a page from Safari
3427
3428         * bridge/mac/WebCoreIconDatabaseBridge.h:
3429         * bridge/mac/WebCoreIconDatabaseBridge.mm:
3430         (-[WebCoreIconDatabaseBridge _setEnabled:]): Added
3431         (-[WebCoreIconDatabaseBridge _isEnabled]): Added
3432         * loader/icon/IconDatabase.cpp:
3433         (WebCore::IconDatabase::IconDatabase):
3434         (WebCore::IconDatabase::open): Don't open if disabled
3435         (WebCore::IconDatabase::removeAllIcons): Ignore if disabled/closed
3436         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ignore if disabled/closed
3437         (WebCore::IconDatabase::iconForPageURL): Default Icon if disabled/closed
3438         (WebCore::IconDatabase::isIconExpiredForIconURL): Default return if disabled/closed
3439         (WebCore::IconDatabase::iconURLForPageURL): Default return if disabled/closed
3440         (WebCore::IconDatabase::retainIconForPageURL): Ignore if disabled/closed
3441         (WebCore::IconDatabase::releaseIconForPageURL): Ignore if disabled/closed
3442         (WebCore::IconDatabase::releaseIconURL):
3443         (WebCore::IconDatabase::setIconDataForIconURL): Ignore if disabled/closed
3444         (WebCore::IconDatabase::setIconURLForPageURL): Ignore if disabled/closed
3445         (WebCore::IconDatabase::hasEntryForIconURL): Default return if disabled/closed
3446         (WebCore::IconDatabase::setEnabled): Added
3447         * loader/icon/IconDatabase.h:
3448         (WebCore::IconDatabase::enabled): Added
3449         * page/Frame.cpp:
3450         (WebCore::Frame::endIfNotLoading): do an IconDatabase::enabled() check before bothering to load the icon
3451         * platform/mac/ResourceLoaderMac.mm: Removed extraneous #include
3452
3453 2006-09-20  David Hyatt  <hyatt@apple.com>
3454
3455         Massage mouse wheel handling so that it is more cross-platform.  Make
3456         all the work happen in handleWheelEvent on the FrameView.
3457
3458         Reviewed by bradee-oh
3459
3460         * bridge/mac/FrameMac.mm:
3461         (WebCore::FrameMac::wheelEvent):
3462         * page/FrameView.cpp:
3463         (WebCore::FrameView::handleWheelEvent):
3464         * platform/PlatformWheelEvent.h:
3465         (WebCore::PlatformWheelEvent::platformDelta):
3466         (WebCore::PlatformWheelEvent::delta):
3467         * platform/mac/WheelEventMac.mm:
3468         (WebCore::platformDeltaForEvent):
3469         (WebCore::PlatformWheelEvent::PlatformWheelEvent):
3470         * rendering/RenderLayer.cpp:
3471         (WebCore::RenderLayer::scroll):
3472         * rendering/RenderObject.cpp:
3473         (WebCore::RenderObject::scroll):
3474
3475 2006-09-19  Eric Seidel  <eric@eseidel.com>
3476
3477         Reviewed by adele.
3478
3479         Improve test output for filters with bounding-box relative sizes.
3480         http://bugs.webkit.org/show_bug.cgi?id=8585
3481
3482         Many test results updated.
3483
3484         * kcanvas/KCanvasFilters.cpp:
3485         (WebCore::KCanvasFilter::externalRepresentation):
3486
3487 2006-09-19  Eric Seidel  <eric@eseidel.com>
3488
3489         Reviewed by adele.
3490
3491         Markers should clip to their viewport.
3492         http://bugs.webkit.org/show_bug.cgi?id=5967
3493
3494         Test: svg/custom/marker-overflow-clip.svg
3495
3496         * kcanvas/KCanvasResources.cpp:
3497         (WebCore::KCanvasMarker::KCanvasMarker):
3498         (WebCore::KCanvasMarker::setMarker):
3499         (WebCore::KCanvasMarker::draw):
3500         * kcanvas/KCanvasResources.h:
3501         (WebCore::KCanvasMasker::mask):
3502         * ksvg2/svg/SVGMarkerElement.cpp:
3503         (WebCore::SVGMarkerElement::SVGMarkerElement):
3504         (WebCore::SVGMarkerElement::parseMappedAttribute):
3505         (WebCore::SVGMarkerElement::canvasResource):
3506         (WebCore::SVGMarkerElement::createRenderer):
3507
3508 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
3509
3510         Reviewed by eseidel
3511
3512         Backing out my recent change.
3513
3514         * css/cssstyleselector.cpp:
3515         (WebCore::CSSStyleSelector::adjustRenderStyle):
3516
3517 2006-09-19  Brady Eidson  <beidson@apple.com>
3518
3519         Reviewed by Kevin McCullough
3520
3521         http://bugs.webkit.org/show_bug.cgi?id=10940
3522         Opening a PDF in a new tab/window creates a documentless-frame
3523         and we deref the document without checking its validity
3524
3525         * page/Frame.cpp:
3526         (WebCore::Frame::iconURL):
3527
3528 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
3529
3530         Reviewed by harrison
3531
3532         <rdar://problem/4735272>
3533         Can not click into link in programmatically editable content
3534
3535         * css/cssstyleselector.cpp:
3536         (WebCore::CSSStyleSelector::adjustRenderStyle): We stopped using
3537         userModify to implement document wide editability.
3538
3539 2006-09-19  MorganL  <morlmor@yahoo.com>
3540
3541         Reviewed by Darin and landed by Brady
3542
3543         Fixes http://bugs.webkit.org/show_bug.cgi?id=10939
3544         Build broken when SVG is not enabled.
3545
3546         * dom/XMLTokenizer.cpp:
3547         (WebCore::XMLTokenizer::startElementNs):
3548
3549 2006-09-19  Justin Garcia  <justin.garcia@apple.com>
3550
3551         Reviewed by harrison
3552
3553         <rdar://problem/4727383> REGRESSION: Pasting plain text with tabs into Blot converts the tabs to single spaces
3554
3555         Pasting plain text results in a match style paste, and the insertion
3556         position is whitespace normal, which clobbers the whitespace:pre on
3557         tab spans.  Skip changes to the whitespace mode when computing a style
3558         change for tab spans or the text nodes inside tab spans.
3559
3560         * editing/ApplyStyleCommand.cpp:
3561         (WebCore::StyleChange::init): Don't change the whitespace mode inside
3562         tab spans.
3563
3564 2006-09-19  David Hyatt  <hyatt@apple.com>
3565
3566         Fix for bug 5298, shape=default not supported for image maps.  Implement
3567         support for it.
3568
3569         Reviewed by timo
3570
3571         * html/HTMLAreaElement.cpp:
3572         (WebCore::HTMLAreaElement::getRegion):
3573         * html/HTMLMapElement.cpp:
3574         (WebCore::HTMLMapElement::mapMouseEvent):
3575
3576 2006-09-19  Adam Roben  <aroben@apple.com>
3577
3578         Reviewed by Adele.
3579
3580         Fixes http://bugs.webkit.org/show_bug.cgi?id=10824
3581         "no file selected" placeholder text missing from file upload control
3582
3583         * WebCore.xcodeproj/project.pbxproj:
3584         * rendering/RenderFileUploadControl.cpp: Remove class
3585         RenderFileUploadInnerFileBox, rename defaultFilenameNumChars to
3586         defaultWidthNumChars
3587         (WebCore::RenderFileUploadControl::RenderFileUploadControl): Call
3588         RenderBlock constructor instead of RenderFlexibleBox,
3589         (WebCore::RenderFileUploadControl::setStyle): Remove references to
3590         m_fileBox.
3591         (WebCore::RenderFileUploadControl::valueChanged): Call repaint()
3592         instead of updateIconAndFileName() (which has been removed)
3593         (WebCore::RenderFileUploadControl::updateFromElement): Remove
3594         references to m_fileBox, don't call updateIconAndFilename()
3595         (WebCore::RenderFileUploadControl::maxFilenameWidth): Calculate width
3596         without using m_fileBox
3597         (WebCore::RenderFileUploadControl::createButtonStyle): Remove
3598         now-unnecessary display:box rule.
3599         (WebCore::RenderFileUploadControl::paintObject): Remove redundant call
3600         to paintingDisabled() now that Icon::paint() does it, and add code to
3601         paint the filename directly.
3602         (WebCore::RenderFileUploadControl::calcMinMaxWidth): Move this method
3603         out of RenderFileUploadInnerFileBox and into RenderFileUploadControl
3604         * rendering/RenderFileUploadControl.h: Make RenderFileUploadControl a
3605         subclass of RenderBlock instead of RenderFlexibleBox, remove
3606         updateIconAndFilename() method, remove m_fileBox instance variable.
3607
3608 2006-09-19  Eric Seidel  <eric@eseidel.com>
3609
3610         Reviewed by hyatt.
3611
3612         Exceptions thrown from <script> tags in XHTML/SVG docs show the wrong line numbers
3613         http://bugs.webkit.org/show_bug.cgi?id=10846
3614
3615         No automated test case possible until http://bugs.webkit.org/show_bug.cgi?id=10905 is resolved.