2009-03-02 Kim Grönholm <kim.gronholm@nomovok.com>
[WebKit-https.git] / WebCore / ChangeLog
1 2009-03-02  Kim Grönholm  <kim.gronholm@nomovok.com>
2
3         Reviewed by Simon Hausmann.
4
5         Improvement to 3d transformations rendering in QtWebKit. QTransform is used
6         instead of QMatrix. This allows perspective transformations since QTransform is
7         a true 3x3 matrix.
8
9         * platform/graphics/qt/GraphicsContextQt.cpp: Use QTransform instead of QMatrix everywhere.
10         (WebCore::GraphicsContext::getCTM):
11         (WebCore::GraphicsContext::restorePlatformState):
12         (WebCore::GraphicsContext::fillPath):
13         (WebCore::GraphicsContext::strokePath):
14         (WebCore::GraphicsContext::fillRect):
15         (WebCore::GraphicsContext::translate):
16         (WebCore::GraphicsContext::rotate):
17         (WebCore::GraphicsContext::scale):
18         (WebCore::GraphicsContext::concatCTM):
19         * platform/graphics/qt/ImageQt.cpp:
20         (WebCore::Image::drawPattern):
21         * platform/graphics/qt/PathQt.cpp:
22         (WebCore::Path::translate):
23         (WebCore::Path::transform):
24         * platform/graphics/qt/PatternQt.cpp:
25         (WebCore::Pattern::createPlatformPattern):
26         * platform/graphics/qt/TransformationMatrixQt.cpp:
27         (WebCore::TransformationMatrix::operator QTransform): Replace the conversion operator
28         to QMatrix with one to QTransform.
29         * platform/graphics/transforms/TransformationMatrix.h:
30         * platform/graphics/qt/FontQt.cpp:
31
32 2009-02-24  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
33
34         Reviewed by Simon Hausmann.
35
36         https://bugs.webkit.org/show_bug.cgi?id=24151
37         Fix Qt/S60 build break
38
39         * platform/FileSystem.h: Create a default case for non-win and non-mac Qt builds
40         * platform/qt/FileSystemQt.cpp: Ditto
41         (WebCore::unloadModule):
42
43 2009-03-03  Mike Belshe  <mike@belshe.com>
44
45         Reviewed by Alexey Proskuryakov.
46
47         https://bugs.webkit.org/show_bug.cgi?id=21939
48         Uninitialized ExceptionCode in DOMWindow::postMessage
49
50         * dom/MessagePort.cpp:
51         (WebCore::MessagePort::postMessage):
52
53 2009-03-03  David Kilzer  <ddkilzer@apple.com>
54
55         <rdar://problem/6581203> WebCore and WebKit should install the same set of headers during installhdrs phase as build phase
56
57         Reviewed by Mark Rowe.
58
59         The fix is to add INSTALLHDRS_COPY_PHASE = YES and
60         INSTALLHDRS_SCRIPT_PHASE = YES to WebCore.xcconfig, then to make
61         sure various build phase scripts work with the installhdrs build
62         phase.
63
64         * Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME
65         based on PLATFORM_NAME to work around the missing definition on
66         Tiger.
67         * Configurations/WebCore.xcconfig: Added
68         JAVASCRIPTCORE_PRIVATE_HEADERS_DIR variable to simplify logic in
69         the "Generate Derived Sources" script.  Added
70         INSTALLHDRS_COPY_PHASE = YES and INSTALLHDRS_SCRIPT_PHASE = YES.
71
72         * WebCore.xcodeproj/project.pbxproj:
73         - Added shell code to prevent running "Check For Global
74           Initializers", "Check For Exit Time Destructors" and "Check
75           For Weak VTables" scripts during the installhdrs build phase.
76         - Made "Generate Derived Sources" work for the installhdrs build
77           phase.  Also simplified setting of CREATE_HASH_TABLE by using
78           JAVASCRIPTCORE_PRIVATE_HEADERS_DIR.
79
80 2009-03-02  Adam Langley  <agl@google.com>
81
82         Reviewed by Darin Fisher.
83
84         Chromium Linux: Switch to using Skia to render widgets.
85
86         In order to sandbox the Chromium renderer on Linux we need to remove
87         the X connection. GTK cannot render without an X connection so, for
88         now, we render widgets ourselves.
89
90         Previously didn't use anti-alias fonts in order to match Windows font
91         rendering exactly. This was helpful when bootstrapping our layout
92         tests. Now, however, we are ready to enable it.
93
94         https://bugs.webkit.org/show_bug.cgi?id=24244
95
96         * platform/chromium/ScrollbarThemeChromium.cpp:
97         (WebCore::ScrollbarThemeChromium::buttonSize):
98         * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
99         (WebCore::ScrollbarThemeChromium::scrollbarThickness):
100         (WebCore::ScrollbarThemeChromium::paintTrackPiece):
101         (WebCore::ScrollbarThemeChromium::paintButton):
102         (WebCore::ScrollbarThemeChromium::paintThumb):
103         * platform/graphics/chromium/FontPlatformDataLinux.cpp:
104         (WebCore::FontPlatformData::setupPaint):
105         * platform/graphics/skia/PlatformContextSkia.cpp:
106         (PlatformContextSkia::PlatformContextSkia):
107         (PlatformContextSkia::~PlatformContextSkia):
108         * platform/graphics/skia/PlatformContextSkia.h:
109         * rendering/RenderThemeChromiumGtk.cpp: Removed.
110         * rendering/RenderThemeChromiumGtk.h: Removed.
111         * rendering/RenderThemeChromiumLinux.cpp: Added.
112         * rendering/RenderThemeChromiumLinux.h: Added.
113
114 2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
115
116         Reviewed by Darin Fisher.
117
118         https://bugs.webkit.org/show_bug.cgi?id=24261
119         Fix return types.
120
121         Test: LayoutTests/dom/svg/level3/xpath/XPathEvaluator_evaluate_TYPE_ERR.svg
122
123         * bindings/v8/V8Binding.h:
124         (WebCore::toInt32): change return type to int
125         (WebCore::toFloat): change return type to float.
126
127 2009-03-03  Anders Carlsson  <andersca@apple.com>
128
129         Reviewed by John Sullivan.
130
131         https://bugs.webkit.org/show_bug.cgi?id=22884
132         <rdar://problem/6449783>
133         modified layout test crashes Safari
134
135         Null check NPStream before dereferencing it.
136         
137         * plugins/PluginView.cpp:
138         (WebCore::PluginView::destroyStream):
139
140 2009-03-03  Eric Carlson  <eric.carlson@apple.com>
141
142         Reviewed by Simon Fraser.
143
144         Fix for <rdar://problem/6641045>
145         Don't call QTKit to get movie properties until movie metadata has been loaded.
146
147         * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
148         (WebCore::MediaPlayerPrivate::metaDataAvailable): defined
149         * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
150         (WebCore::MediaPlayerPrivate::createQTTime): return default if !metaDataAvailable.
151         (WebCore::MediaPlayerPrivate::play): Ditto.
152         (WebCore::MediaPlayerPrivate::pause): Ditto.
153         (WebCore::MediaPlayerPrivate::duration): Ditto.
154         (WebCore::MediaPlayerPrivate::currentTime): Ditto.
155         (WebCore::MediaPlayerPrivate::seek): Ditto.
156         (WebCore::MediaPlayerPrivate::seekTimerFired): Ditto.
157         (WebCore::MediaPlayerPrivate::paused): Ditto.
158         (WebCore::MediaPlayerPrivate::seeking): Ditto.
159         (WebCore::MediaPlayerPrivate::naturalSize): Ditto.
160         (WebCore::MediaPlayerPrivate::hasVideo): Ditto.
161         (WebCore::MediaPlayerPrivate::setVolume): Ditto.
162         (WebCore::MediaPlayerPrivate::setRate): Ditto.
163         (WebCore::MediaPlayerPrivate::dataRate): Ditto.
164         (WebCore::MediaPlayerPrivate::maxTimeLoaded): Ditto.
165         (WebCore::MediaPlayerPrivate::totalBytes): Ditto.
166
167 2009-03-03  Kevin McCullough  <kmccullough@apple.com>
168
169         - Spelling fix.
170
171         * page/Console.cpp:
172         (WebCore::Console::profile):
173
174 2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
175
176         Reviewed by Darin Fisher.
177
178         https://bugs.webkit.org/show_bug.cgi?id=23657
179         Remove Database API callback IDLs from the project. 
180         They were removed in r40633.
181
182         * WebCore.xcodeproj/project.pbxproj: Removed IDL files from the project.
183
184 2009-03-03  Kevin McCullough  <kmccullough@apple.com>
185
186         Reviewed by Oliver Hunt.
187
188         <rdar://problem/6639110> console.profile() doesn't work without a title
189
190         * page/Console.cpp:
191         (WebCore::Console::profile): If there is no title assume this is a user
192         initiated profile and give it the next incremented title name.
193
194 2009-03-03  Timothy Hatcher  <timothy@apple.com>
195
196         Fix a regression that broke dirxml and caused an ASSERT in debug builds. Also simplified
197         the console code and refactored things to have fewer code paths and duplication.
198
199         rdar://problem/6367127
200         https://bugs.webkit.org/show_bug.cgi?id=24329
201
202         Reviewed by Kevin McCullough.
203
204         Test: manual-tests/inspector/console-dir.html
205
206         * bindings/js/JSInspectedObjectWrapper.cpp:
207         (WebCore::JSInspectedObjectWrapper::wrap): Use the lexicalGlobalObject instead of dynamicGlobalObject
208         to fix an ASSERT about using a wrapper from the wrong ExecState.
209         * bindings/js/JSQuarantinedObjectWrapper.cpp:
210         (WebCore::JSQuarantinedObjectWrapper::JSQuarantinedObjectWrapper): Ditto.
211         (WebCore::JSQuarantinedObjectWrapper::allowsUnwrappedAccessFrom): Ditto.
212         * inspector/front-end/Console.js:
213         (WebInspector.Console.prototype._format): Remove the inline argument and add forceObjectFormat.
214         When forceObjectFormat is true, the only formatter used is _formatobject.
215         (WebInspector.Console.prototype._formatvalue): Remove the inline argument.
216         (WebInspector.Console.prototype._formatstring): Ditto.
217         (WebInspector.Console.prototype._formatregexp): Ditto.
218         (WebInspector.Console.prototype._formatarray): Ditto.
219         (WebInspector.Console.prototype._formatnode): Remove the inline argument and make a DOM tree instead of an anchor.
220         (WebInspector.Console.prototype._formatobject): Remove the inline argument and always make a property graph.
221         (WebInspector.Console.prototype._formaterror): Remove the inline argument.
222         (WebInspector.ConsoleMessage): Remove the case for MessageLevel.Node and
223         simplify the case for MessageLevel.Object to use the normal _format code path with the %O formatter.
224         (WebInspector.ConsoleMessage.prototype._format.formatForConsole): Don't pass an additional true argument for inline.
225         (WebInspector.ConsoleMessage.prototype._format.formatAsObjectForConsole): Added. Pass a true argument for forceObjectFormat.
226         (WebInspector.ConsoleMessage.prototype._format): Added support for the %O formatter. Use formatForConsole for all arguments.
227         (WebInspector.ConsoleMessage.prototype.toString): Add the other message levels.
228         * inspector/front-end/inspector.css: Tweak styles to look and work correctly.
229         * inspector/front-end/utilities.js:
230         (Object.type): Return "node" for Node objects.
231         (Object.describe): Handle the "node" type.
232         * page/Console.cpp:
233         (WebCore::printMessageSourceAndLevelPrefix): Fix an assert by adding the other message level types.
234         (WebCore::Console::dirxml): Use the standard log fuction since it prints a DOM tree for nodes by default.
235         * page/Console.h:
236         (WebCore::enum MessageLevel): Removed NodeMessageLevel. Added a FIXME.
237
238 2009-03-03  Scott Violet  <sky@google.com>
239
240         Reviewed by Eric Seidel.
241
242         https://bugs.webkit.org/show_bug.cgi?id=24325
243         Crash on replacing document contents during drop.
244
245         Makes sure a node is in the document during a move before using it.
246
247         Test: fast/events/crash-on-mutate-during-drop.html
248
249         * editing/MoveSelectionCommand.cpp:
250         (WebCore::MoveSelectionCommand::doApply):
251
252 2009-03-03  Jungshik Shin <jshin@chromium.org>
253
254         Reviewed by Eric Seidel.
255
256         https://bugs.webkit.org/show_bug.cgi?id=23028
257         Enable dynamic web font support to Chromium on Windows.
258         Files that were omitted by mistake in the latest patch
259         that was landed.
260
261         * loader/CachedFont.cpp:
262         (WebCore::CachedFont::~CachedFont):
263         (WebCore::CachedFont::ensureCustomFontData):
264         (WebCore::CachedFont::platformDataFromCustomData):
265         (WebCore::CachedFont::allClientsRemoved):
266         * platform/graphics/chromium/FontCustomPlatformData.cpp:
267         (WebCore::EOTStream::EOTStream):
268         (WebCore::createFontCustomPlatformData):
269         * platform/graphics/win/FontCustomPlatformData.cpp:
270         (WebCore::EOTStream::EOTStream):
271         (WebCore::createFontCustomPlatformData):
272
273 2009-03-03  Gustavo Noronha Silva  <gns@gnome.org>
274
275         Reviewed by Alexey Proskuryakov.
276
277         https://bugs.webkit.org/show_bug.cgi?id=16826
278         [Gtk] Implement WebKitDownload
279
280         Make the Soup backend able to handle requests without a frame,
281         since we may have such things now that we support downloads.
282
283         * platform/network/ResourceHandleInternal.h:
284         * platform/network/soup/ResourceHandleSoup.cpp:
285         (WebCore::ResourceHandle::start):
286
287 2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
288
289         Reviewed by Eric Seidel.
290
291         https://bugs.webkit.org/show_bug.cgi?id=24331
292         Add custom V8 bindings for Element, Attr, HTMLFrame, and HTMLIFrame.
293
294         * bindings/v8/custom/V8AttrCustom.cpp: Added.
295         * bindings/v8/custom/V8CustomBinding.cpp: Added.
296         * bindings/v8/custom/V8CustomBinding.h: Added attribute-checking helpers.
297         * bindings/v8/custom/V8ElementCustom.cpp: Added.
298         * bindings/v8/custom/V8HTMLFrameElementCustom.cpp: Added.
299         * bindings/v8/custom/V8HTMLIFrameElementCustom.cpp: Added.
300
301 2009-03-03  Brady Eidson  <beidson@apple.com>
302
303         Reviewed by Darin Adler
304
305         <rdar://problem/6616664> - Quick looks of various file types is broken
306
307         In http://trac.webkit.org/changeset/40553 there was an attempt to prevent NSURLRequest churn
308         for non-HTTP loads when the underlying ResourceRequest changed.  Unfortunately it was a little
309         overzealous as the mainDocumentURL is relevant for all loads, not only HTTP/HTTPS loads.
310
311         Partially reverted behavior to always set the mainDocumentURL in situations when we would've
312         before that patch.
313
314         * loader/FrameLoader.cpp:
315         (WebCore::FrameLoader::addExtraFieldsToRequest):
316
317         * platform/network/ResourceRequestBase.cpp:
318         (WebCore::ResourceRequestBase::setMainDocumentURL):
319
320 2009-03-03  Chris Marrin  <cmarrin@apple.com>
321
322         Reviewed by Simon Fraser.
323
324         https://bugs.webkit.org/show_bug.cgi?id=24256
325
326         Added a WebCoreForceSoftwareAnimation flag.
327
328         * platform/graphics/mac/GraphicsLayerCA.mm:
329         (WebCore::forceSoftwareAnimation):
330         (WebCore::GraphicsLayerCA::setOpacity):
331         (WebCore::GraphicsLayerCA::animateTransform):
332         (WebCore::GraphicsLayerCA::animateFloat):
333
334 2009-03-02  Chris Marrin  <cmarrin@apple.com>
335
336         Reviewed by Sam Weinig.
337
338         https://bugs.webkit.org/show_bug.cgi?id=24257
339
340         Added prototype properties for several classes with constructors that
341         were missing them, including the one mentioned in the bug.
342
343         Test: fast/dom/Window/custom-constructors.html
344
345         * bindings/js/JSAudioConstructor.cpp:
346         (WebCore::JSAudioConstructor::JSAudioConstructor):
347         * bindings/js/JSDOMWindowBase.cpp:
348         (jsDOMWindowBaseWebKitCSSMatrix):
349         * bindings/js/JSImageConstructor.cpp:
350         (WebCore::JSImageConstructor::JSImageConstructor):
351         * bindings/js/JSOptionConstructor.cpp:
352         (WebCore::JSOptionConstructor::JSOptionConstructor):
353         * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
354         (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
355         * bindings/js/JSWebKitCSSMatrixConstructor.h:
356         * bindings/js/JSWebKitPointConstructor.cpp:
357         (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
358         * bindings/js/JSWorkerConstructor.cpp:
359         (WebCore::JSWorkerConstructor::JSWorkerConstructor):
360
361 2009-03-03  Dimitri Glazkov  <dglazkov@chromium.org>
362
363         Reviewed by Darin Fisher.
364
365         https://bugs.webkit.org/show_bug.cgi?id=24321
366         Add V8 bindings headers.
367
368         * bindings/v8/V8Binding.h: Added.
369         * bindings/v8/V8Proxy.h: Added.
370         * bindings/v8/custom/V8CustomBinding.h: Added.
371         * bindings/v8/custom/V8CustomEventListener.h: Added.
372
373 2009-03-03  Jungshik Shin <jshin@chromium.org>
374
375         Reviewed by Eric Seidel.
376
377         https://bugs.webkit.org/show_bug.cgi?id=23803
378         Fix an 'off-by-1' error in ChromiumWin's font fallback.
379
380         * platform/graphics/chromium/FontCacheChromiumWin.cpp:
381         (WebCore::FontCache::getFontDataForCharacters):
382
383 2009-03-03  Jungshik Shin  <jshin@chromium.org>
384
385         Reviewed by Eric Seidel.
386
387         http://bugs.webkit.org/show_bug.cgi?id=23028
388         Enable dynamic web font support to Chromium on Windows: Part 1
389         - Move OpenTypeUtilities.{cpp,h} to platform/graphics/opentype
390           from platform/graphics/win because both Windows port and Chromium Windows
391           port will use them.
392         - Adjust WebCore.vcproj accordingly.
393
394         * WebCore.vcproj/WebCore.vcproj:
395         * platform/graphics/opentype: Added.
396         * platform/graphics/opentype/OpenTypeUtilities.cpp: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.cpp.
397         * platform/graphics/opentype/OpenTypeUtilities.h: Copied from WebCore/platform/graphics/win/OpenTypeUtilities.h.
398         * platform/graphics/win/OpenTypeUtilities.cpp: Removed.
399         * platform/graphics/win/OpenTypeUtilities.h: Removed.
400
401 2009-03-03  Simon Fraser  <simon.fraser@apple.com>
402
403         Reviewed by Dave Hyatt
404
405         https://bugs.webkit.org/show_bug.cgi?id=24312
406         
407         Take 3D transforms into account when hit testing:
408         
409         1. Maintain a bit on each RenderLayer that is set when the layer
410            has 3d descendants, so that we know when to fall into the slow
411            hit testing path.
412            
413         2. Make a ref-counted HitTestingTransformState, which is used to store
414            an accumulated transform, and the hit test point, and hitTestRect
415            in the plane of the ancestor non-3d ('flattening') layer.
416            
417            It's ref-counted so we can heap allocate it (to avoid stack bloat),
418            and avoid copying when hitTestLayer calls itself after applying the transform.
419            
420         3. Add logic to hitTestLayer to depth-test just direct descendants, if any have
421            3D transforms, or to do deep depth-testing when traversing a preserves-3d
422            hierarchy. When hit, layers compute a z-offset from the ancestor flattening
423            layer, which allows for correct depth testing.
424            
425            The existing early-return codepath is unaffected when there are no 3d transforms
426            and no preserve-3d.
427
428         * rendering/RenderLayer.cpp:
429         (WebCore::RenderLayer::RenderLayer):
430         (WebCore::RenderLayer::updateTransform):
431         (WebCore::RenderLayer::dirty3DTransformedDescendantStatus):
432         (WebCore::RenderLayer::update3DTransformedDescendantStatus):
433         (WebCore::RenderLayer::hitTest):
434         (WebCore::computeZOffset):
435         (WebCore::RenderLayer::createLocalTransformState):
436         (WebCore::RenderLayer::hitTestLayer):
437         (WebCore::RenderLayer::hitTestContents):
438         * rendering/RenderLayer.h:
439         (WebCore::RenderLayer::preserves3D):
440         (WebCore::RenderLayer::has3DTransform):
441         (WebCore::RenderLayer::setHas3DTransformedDescendant):
442         (WebCore::RenderLayer::has3DTransformedDescendant):
443         * rendering/RenderLayerBacking.cpp:
444         * rendering/TransformState.cpp:
445         (WebCore::TransformState::flatten):
446         (WebCore::TransformState::mappedPoint):
447         (WebCore::HitTestingTransformState::move):
448         (WebCore::HitTestingTransformState::applyTransform):
449         (WebCore::HitTestingTransformState::flatten):
450         (WebCore::HitTestingTransformState::mappedPoint):
451         (WebCore::HitTestingTransformState::mappedQuad):
452         * rendering/TransformState.h:
453         (WebCore::TransformState::TransformState):
454         (WebCore::HitTestingTransformState::create):
455         (WebCore::HitTestingTransformState::move):
456         (WebCore::HitTestingTransformState::HitTestingTransformState):
457
458 2009-03-03  Brett Wilson  <brettw@chromium.org>
459
460         Fix uninitialized memory reads in the Chromium Windows transparency
461         code that were identified by Purify,
462
463         Reviewed by Darin Fisher.
464
465         * platform/graphics/chromium/TransparencyWin.cpp:
466         (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers):
467         (WebCore::TransparencyWin::initializeNewContext):
468
469 2009-03-03  Simon Fraser  <simon.fraser@apple.com>
470
471         Reviewed by Dave Hyatt
472
473         https://bugs.webkit.org/show_bug.cgi?id=24312
474         
475         Factor the code that compute a transform relative to the container
476         into RenderObject::transformFromContainer().
477         
478         * rendering/RenderBox.cpp:
479         (WebCore::RenderBox::mapLocalToAbsolutePoint):
480         (WebCore::RenderBox::mapAbsoluteToLocalPoint):
481         * rendering/RenderObject.cpp:
482         (WebCore::RenderObject::transformFromContainer):
483         * rendering/RenderObject.h:
484
485 2009-03-03  Simon Fraser  <simon.fraser@apple.com>
486
487         Reviewed by Dave Hyatt
488
489         https://bugs.webkit.org/show_bug.cgi?id=24317
490         
491         Always return |true| from RenderTextControlMultiLine::nodeAtPoint() if
492         the superclass found a node, otherwise we set the innerNode of the
493         HitTestResult, but don't actually report that we found a hit.
494
495         * rendering/RenderTextControlMultiLine.cpp:
496         (WebCore::RenderTextControlMultiLine::nodeAtPoint):
497
498 2009-03-03  Onne Gorter  <onne.gorter@avinity.net>
499
500         Reviewed by Anders Carlsson.
501
502         https://bugs.webkit.org/show_bug.cgi?id=23707
503         resizing plugins does not work, because the plugin never gets informed
504
505         Make gtk plugins resize correctly, by sending them the setwindow event
506         correctly. Also ensure that all plugin eventing is done with correct
507         locking/calling. Mostly copied from mac implementation.
508
509         manual test: manual-tests/gtk/plugin-resize-scroll.html
510
511         * plugins/PluginView.h:
512         * plugins/gtk/PluginViewGtk.cpp:
513         (WebCore::PluginView::dispatchNPEvent):
514         ensure locking/calling for NPEvents
515         (WebCore::PluginView::updatePluginWidget):
516         if something changed, let setNPWindowIfNeeded handle it
517         (WebCore::PluginView::paint):
518         (WebCore::PluginView::handleKeyboardEvent):
519         (WebCore::PluginView::handleMouseEvent):
520         ensure calling conventions
521         (WebCore::PluginView::setNPWindowRect):
522         just pass control to setNPWindowIfNeeded
523         (WebCore::PluginView::setNPWindowIfNeeded):
524         event the plugin correctly of new window
525         (WebCore::PluginView::init):
526         init through the new setup
527
528 2009-03-03  Mike Belshe  <mike@belshe.com>
529
530         Reviewed by Darin Fisher.
531
532         https://bugs.webkit.org/show_bug.cgi?id=24311
533         Make IDL returning DOMObject use [V8Custom]
534
535         * dom/Document.idl:
536         * html/HTMLCanvasElement.idl:
537
538 2009-03-02  Simon Fraser  <simon.fraser@apple.com>
539
540         Reviewed by Adele Peterson
541
542         https://bugs.webkit.org/show_bug.cgi?id=24313
543         
544         If RenderTextControlSingleLine::nodeAtPoint() pokes a node into the
545         HitTestResult, then it had better well return |true|. And m_innerBlock
546         could never have been set as the hit node by the superclass, because
547         the superclass knows nothing about m_innerBlock.
548         
549         Test: fast/forms/input-hit-test-border.html
550
551         * rendering/RenderTextControlSingleLine.cpp:
552         (WebCore::RenderTextControlSingleLine::nodeAtPoint):
553
554 2009-03-02  Sam Weinig  <sam@webkit.org>
555
556         Reviewed by Mark Rowe.
557
558         Enable Geolocation (except on Tiger and Leopard).
559
560         * Configurations/WebCore.xcconfig:
561
562 2009-03-02  Ojan Vafai  <ojan@chromium.org>
563
564         Reviewed by Adele Peterson.
565
566         Fix https://bugs.webkit.org/show_bug.cgi?id=24307
567         Null out m_highlightedNode on hideHighlight().
568         Ran WebCore/manual-tests/inspector/highlight-nodes.html.
569
570         * inspector/InspectorController.cpp:
571         (WebCore::InspectorController::hideHighlight):
572
573 2009-03-02  Sam Weinig  <sam@webkit.org>
574
575         Reviewed by Geoffrey Garen.
576
577         Fix for <rdar://problem/6507404> Add Geolocation support.
578
579         This is not yet turned on for any Mac platform.
580
581         * WebCore.xcodeproj/project.pbxproj:
582         * page/Chrome.cpp:
583         (WebCore::Chrome::shouldAllowGeolocationForFrame):
584         * page/Chrome.h:
585         * page/ChromeClient.h:
586         (WebCore::ChromeClient::shouldAllowGeolocationForFrame):
587         * page/Geolocation.cpp:
588         (WebCore::Geolocation::Geolocation):
589         (WebCore::Geolocation::disconnectFrame): Remove call to setUsingGeolocation as the document
590         will not be alive at this point.
591         (WebCore::Geolocation::getCurrentPosition): Check if the embedding app allows geolocation and
592         return a PERMISSION_DENIED if not.
593         (WebCore::Geolocation::watchPosition): Ditto.
594         (WebCore::Geolocation::shouldAllowGeolocation): Perform request to embedding layer of whether
595         to allow geolocation and cache the result. 
596         * page/Geolocation.h:
597         (WebCore::Geolocation::):
598         * platform/GeolocationService.cpp:
599         * platform/GeolocationService.h:
600         (WebCore::GeolocationService::~GeolocationService):
601         (WebCore::GeolocationService::stopUpdating):
602         * platform/mac/GeolocationServiceMac.h: Added.
603         (WebCore::GeolocationServiceMac::lastPosition):
604         (WebCore::GeolocationServiceMac::lastError):
605         * platform/mac/GeolocationServiceMac.mm: Added.
606         (WebCore::GeolocationService::create):
607         (WebCore::GeolocationServiceMac::GeolocationServiceMac):
608         (WebCore::GeolocationServiceMac::~GeolocationServiceMac):
609         (WebCore::GeolocationServiceMac::startUpdating):
610         (WebCore::GeolocationServiceMac::stopUpdating):
611         (WebCore::GeolocationServiceMac::suspend):
612         (WebCore::GeolocationServiceMac::resume):
613         (WebCore::GeolocationServiceMac::positionChanged):
614         (WebCore::GeolocationServiceMac::errorOccurred):
615         (-[WebCoreCoreLocationObserver initWithCallback:]):
616         (-[WebCoreCoreLocationObserver locationManager:didUpdateToLocation:fromLocation:]):
617         (-[WebCoreCoreLocationObserver locationManager:didFailWithError:]):
618
619 2009-03-02  Kevin Ollivier  <kevino@theolliviers.com>
620
621         Build fixes for wxWidgets Mac trunk build.
622
623         * platform/wx/wxcode/mac/carbon/fontprops.cpp:
624         (wxFontProperties::wxFontProperties):
625         (GetTextExtent):
626         * webcore-wx.bkl:
627
628 2009-03-02  Kevin Ollivier  <kevino@theolliviers.com>
629
630         wxGTK missing header build fix.
631
632         * platform/wx/wxcode/gtk/fontprops.cpp:
633
634 2009-03-02  Dan Bernstein  <mitz@apple.com>
635
636         Reviewed by Adam Roben.
637
638         - fix https://bugs.webkit.org/show_bug.cgi?id=21811
639           REGRESSION: Windows Build Not Selecting Proper Font
640
641         * platform/graphics/win/FontCacheWin.cpp:
642         (WebCore::createGDIFont): Added back code to verify that the created
643         HFONT has the requested face name.
644
645 2009-03-02  Timothy Hatcher  <timothy@apple.com>
646
647         Fixes a regression caused by splitting the input and output of console commands.
648
649         https://bugs.webkit.org/show_bug.cgi?id=24293
650
651         Reviewed by Kevin McCullough.
652
653         * inspector/front-end/Console.js:
654         (WebInspector.Console.prototype.addMessage): Don't treat ConsoleCommandResult as a
655         normal ConsoleMessage when appending. This prevents resetting repeatCounts incorrectly.
656
657 2009-03-02  Timothy Hatcher  <timothy@apple.com>
658
659         Make exception messages and logged Error objects display consistently.
660
661         https://bugs.webkit.org/show_bug.cgi?id=18983
662
663         Reviewed by Adam Roben.
664
665         * English.lproj/localizedStrings.js: Remove a string for line numbers.
666         * inspector/front-end/Console.js:
667         (WebInspector.Console.prototype._enterKeyPressed): Pass the exception
668         boolean to the ConsoleCommandResult constructor and don't pass level.
669         (WebInspector.Console.prototype._formatnode): Fix a className typo.
670         (WebInspector.Console.prototype._formaterror): Add an error-message
671         classed span around the message to show in red and remove the
672         console-message-url class from the link so it doesn't float right.
673         Instead enclose the link in parentheses and use displayNameForURL
674         to shorten the URL in the link.
675         (WebInspector.ConsoleMessage.prototype.toMessageElement): Simplify
676         how line numbers are shown since link underlining a string with
677         parentheses looks bad.
678         (WebInspector.ConsoleCommandResult): Take an exception boolean flag
679         instead of a level and get line and URL based on that flag.
680         * inspector/front-end/inspector.css: Tweaks to the styles.
681
682 2009-03-02  Ojan Vafai  <ojan@chromium.org>
683
684         Reviewed by Adele Peterson.
685
686         Bug 24048: extra windows button padding doesn't apply when there's no appearance
687         <https://bugs.webkit.org/show_bug.cgi?id=24048>
688
689         Replace adjustButtonInnerStyle with buttonInternalPaddingLeft/Right/Top/Bottom.
690
691         No tests added as existing tests already cover this behavior.
692
693         * rendering/RenderButton.cpp:
694         (WebCore::RenderButton::setupInnerStyle):
695         * rendering/RenderTheme.cpp:
696         * rendering/RenderTheme.h:
697         (WebCore::RenderTheme::buttonInternalPaddingLeft):
698         (WebCore::RenderTheme::buttonInternalPaddingRight):
699         (WebCore::RenderTheme::buttonInternalPaddingTop):
700         * rendering/RenderThemeChromiumGtk.cpp:
701         (WebCore::RenderThemeWin::buttonInternalPaddingLeft):
702         (WebCore::RenderThemeWin::buttonInternalPaddingRight):
703         (WebCore::RenderThemeWin::buttonInternalPaddingTop):
704         (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
705         * rendering/RenderThemeChromiumGtk.h:
706         * rendering/RenderThemeChromiumWin.cpp:
707         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingLeft):
708         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingRight):
709         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingTop):
710         (WebCore::RenderThemeChromiumWin::buttonInternalPaddingBottom):
711         * rendering/RenderThemeChromiumWin.h:
712         * rendering/RenderThemeWin.cpp:
713         (WebCore::RenderThemeWin::buttonInternalPaddingLeft):
714         (WebCore::RenderThemeWin::buttonInternalPaddingRight):
715         (WebCore::RenderThemeWin::buttonInternalPaddingTop):
716         (WebCore::RenderThemeWin::buttonInternalPaddingBottom):
717         * rendering/RenderThemeWin.h:
718
719 2009-03-02  Adam Treat  <adam.treat@torchmobile.com>
720
721         Build fix for Qt port.  Remove unnecessary assert.
722
723         * platform/graphics/qt/ImageBufferQt.cpp:
724         (WebCore::ImageBuffer::putImageData):
725
726 2009-03-02  Adam Treat  <adam.treat@torchmobile.com>
727
728         Reviewed by Adam Roben and previously by Eric Seidel and Simon Fraser.
729
730         https://bugs.webkit.org/show_bug.cgi?id=24227
731         Ensure that the checkForSolidColor() optimization is correctly triggered
732         for all cases of drawPattern.  Currently, the optimization was not triggered
733         when the check had not been previously performed via a request for the
734         image's NativeImagePtr.
735
736         Implement the Qt version of the checkForSolidColor() method.  Combined with
737         the bug fix this reduces the time it takes to draw a repeating background
738         of a 1x1 image from ~50msecs to ~0msecs on my machine.
739
740         * platform/graphics/BitmapImage.cpp:
741         (WebCore::BitmapImage::BitmapImage):
742         * platform/graphics/BitmapImage.h:
743         (WebCore::BitmapImage::mayFillWithSolidColor):
744         * platform/graphics/Image.h:
745         (WebCore::Image::mayFillWithSolidColor):
746         * platform/graphics/cairo/ImageCairo.cpp:
747         (WebCore::BitmapImage::BitmapImage):
748         (WebCore::BitmapImage::checkForSolidColor):
749         * platform/graphics/cg/ImageCG.cpp:
750         (WebCore::BitmapImage::BitmapImage):
751         (WebCore::BitmapImage::checkForSolidColor):
752         * platform/graphics/qt/ImageQt.cpp:
753         (WebCore::BitmapImage::checkForSolidColor):
754         * platform/graphics/skia/ImageSkia.cpp:
755         (WebCore::BitmapImage::checkForSolidColor):
756         * platform/graphics/wx/ImageWx.cpp:
757         (WebCore::BitmapImage::checkForSolidColor):
758
759 2009-03-02  Gustavo Noronha Silva  <gns@gnome.org>
760
761         Unreviewed build fix; adding missing files to EXTRA_DIST, so that
762         they show up in the tarball.
763
764         * GNUmakefile.am:
765
766 2009-03-02  Dirk Schulze  <krit@webkit.org>
767
768         Reviewed by Holger Freyther.
769
770         Added putImageData to Qt. Discussed with Ariya Hidayat.
771
772         [Qt] lacks putImageData support in Canvas
773         https://bugs.webkit.org/show_bug.cgi?id=22186
774
775         * platform/graphics/qt/ImageBufferQt.cpp:
776         (WebCore::ImageBuffer::putImageData):
777
778 2009-03-02  Timothy Hatcher  <timothy@apple.com>
779
780         Show exception messages again when evaluating bad expressions in the
781         Web Inspector's console.
782
783         https://bugs.webkit.org/show_bug.cgi?id=19890
784
785         Reviewed by Oliver Hunt.
786
787         * bindings/js/JSQuarantinedObjectWrapper.cpp:
788         (WebCore::JSQuarantinedObjectWrapper::transferExceptionToExecState):
789         Fix the order in which the exception is set and cleared now that the
790         exception is stored in the shared GlobalData, not per ExecState.
791
792 2009-02-28  Timothy Hatcher  <timothy@apple.com>
793
794         Make input in the Web Inspector console print before any output
795         that might be added by the called function.
796
797         https://bugs.webkit.org/show_bug.cgi?id=19931
798
799         Reviewed by Oliver Hunt.
800
801         * inspector/front-end/Console.js:
802         (WebInspector.Console.prototype._enterKeyPressed): Add the command
803         message before evaluating the result. Associate the originating
804         command to the result, so if they are adjacent there is no divider.
805         (WebInspector.ConsoleCommand): No longer take a result.
806         (WebInspector.ConsoleCommand.prototype.toMessageElement): Result
807         code removed since it isn't used now.
808         (WebInspector.ConsoleCommandResult): Subclass ConsoleMessage.
809         (WebInspector.ConsoleCommandResult.prototype.toMessageElement):
810         Call the ConsoleMessage toMessageElement and add a style class.
811         * inspector/front-end/inspector.css: Add a new style class for
812         adjacent results to hide the divider. Also tweak the position of
813         the disclosure triangle for objects to not use the left margin.
814
815 2009-03-01  Chris Fleizach  <cfleizach@apple.com>
816
817         Reviewed by Oliver Hunt.
818
819         Bug 24282: AX Palindrome error when asking for a specific index of the AXChildren array
820         <https://bugs.webkit.org/show_bug.cgi?id=24282>
821
822         When fetching an array of elements with a range, attachment views need to be returned
823         instead of the actual attachment.
824
825         * page/mac/AccessibilityObjectWrapper.mm:
826         (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
827         (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
828
829 2009-03-01  Ojan Vafai  <ojan@chromium.org>
830
831         Reviewed by Eric Seidel.
832
833         Bug 24251: Cleanup: replace positionForCoordinates with positionForPoint
834         <https://bugs.webkit.org/show_bug.cgi?id=24251>
835         
836         Make RenderObject::positionForCoordinate non-virtual and
837         RenderObject::positionForPoint virtual in preparation for
838         removing positionFor* from RenderObject/RenderText.
839
840         * page/Frame.cpp:
841         (WebCore::Frame::visiblePositionForPoint):
842         * rendering/RenderBR.cpp:
843         (WebCore::RenderBR::positionForPoint):
844         * rendering/RenderBR.h:
845         * rendering/RenderBlock.cpp:
846         (WebCore::RenderBlock::positionForPoint):
847         * rendering/RenderBlock.h:
848         * rendering/RenderBox.cpp:
849         (WebCore::RenderBox::positionForPoint):
850         * rendering/RenderBox.h:
851         * rendering/RenderInline.cpp:
852         (WebCore::RenderInline::positionForPoint):
853         * rendering/RenderInline.h:
854         * rendering/RenderObject.cpp:
855         (WebCore::RenderObject::positionForCoordinates):
856         (WebCore::RenderObject::positionForPoint):
857         * rendering/RenderObject.h:
858         * rendering/RenderReplaced.cpp:
859         (WebCore::RenderReplaced::positionForPoint):
860         * rendering/RenderReplaced.h:
861         * rendering/RenderSVGInlineText.cpp:
862         (WebCore::RenderSVGInlineText::positionForPoint):
863         * rendering/RenderSVGInlineText.h:
864         * rendering/RenderText.cpp:
865         (WebCore::RenderText::positionForPoint):
866         * rendering/RenderText.h:
867
868 2009-03-01  Larry Ewing  <lewing@novell.com>
869
870         Reviewed by Alexey Proskuryakov.
871
872         https://bugs.webkit.org/show_bug.cgi?id=24080
873         NPN_GetValue casting to the wrong type and writing outside bounds
874
875         Make sure to cast the value to the correct type so that only
876         memory owned by the value is written to.
877
878         * plugins/gtk/PluginViewGtk.cpp (PluginView::getValueStatic): 
879         * plugins/qt/PluginViewQt.cpp (PluginView::getValueStatic):
880         * plugins/mac/PluginViewMac.cpp (PluginView::getValueStatic): 
881         (PluginView::getValue):
882
883 2009-03-01  Jeremy Moskovich  <jeremy@chromium.org>
884
885         Reviewed by Simon Fraser.
886
887         https://bugs.webkit.org/show_bug.cgi?id=24197 and
888         https://bugs.webkit.org/show_bug.cgi?id=23512
889
890         The Windows version of cgColor() is conditionally compiled using
891         !PLATFORM(MAC) change this to PLATFORM(WIN_OS) so that Chrome
892         can use the OS X version instead of the Windows version.
893
894         Also rename cgColor() -> createCGColor()
895
896         No observable change in behavior, so no test.
897
898         * platform/graphics/Color.h:
899         * platform/graphics/cg/ColorCG.cpp:
900         (WebCore::createCGColor):
901         * platform/graphics/cg/GraphicsContextCG.cpp:
902         (WebCore::GraphicsContext::setPlatformShadow):
903         * platform/graphics/mac/ColorMac.mm:
904         (WebCore::createCGColor):
905         * platform/graphics/mac/GraphicsContextMac.mm:
906         (WebCore::GraphicsContext::drawFocusRing):
907         * platform/graphics/mac/GraphicsLayerCA.mm:
908         (WebCore::setLayerBorderColor):
909         (WebCore::setLayerBackgroundColor):
910         (WebCore::GraphicsLayerCA::setBackgroundColor):
911         * platform/graphics/win/GraphicsContextCGWin.cpp:
912         (WebCore::GraphicsContext::drawFocusRing):
913         * svg/graphics/filters/cg/SVGFEHelpersCg.mm:
914         (WebCore::ciColor):
915
916 2009-03-01  David Levin  <levin@chromium.org>
917
918         Reviewed by Alexey Proskuryakov.
919
920         Bug 24271: XMLHttpRequest needs js bindings for Workers.
921         <https://bugs.webkit.org/show_bug.cgi?id=24271>
922
923         Tests: http/tests/xmlhttprequest/workers/methods-async.html
924                http/tests/xmlhttprequest/workers/methods.html
925
926         * bindings/js/JSWorkerContextBase.cpp:
927         (WebCore::JSWorkerContextBase::getOwnPropertySlot):
928         (jsWorkerContextBaseXMLHttpRequest):
929         (setJSWorkerContextBaseXMLHttpRequest):
930         Expose XMLHttpRequest to Workers.
931
932         * bindings/js/JSWorkerContextBase.h:
933
934         * bindings/js/JSXMLHttpRequestConstructor.cpp:
935         (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
936         (WebCore::constructXMLHttpRequest):
937         (WebCore::JSXMLHttpRequestConstructor::mark):
938         Removed the dependencies on Document.
939
940         * bindings/js/JSXMLHttpRequestConstructor.h:
941         (WebCore::JSXMLHttpRequestConstructor::scriptExecutionContext):
942         * dom/EventException.idl:
943         * dom/EventListener.idl:
944         Chnage to have the NoStaticTables attribute since they are used from XHR.
945
946         * loader/WorkerThreadableLoader.cpp:
947         (WebCore::workerContextDidFinishLoading):
948         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
949         Fixed identifier to be unsigned long.
950
951         * loader/WorkerThreadableLoader.h:
952         * workers/WorkerThread.cpp:
953         (WebCore::WorkerThread::workerThread):
954         Stop active objects when the thread is getting shutdown so that xhr gets properly shutdown.
955
956         * xml/XMLHttpRequestUpload.cpp:
957
958         * xml/XMLHttpRequest.idl:
959         * xml/XMLHttpRequestException.idl:
960         * xml/XMLHttpRequestProgressEvent.idl:
961         * xml/XMLHttpRequestUpload.idl:
962         Chnage to have the NoStaticTables attribute since they are used from XHR.
963
964 2009-03-01  Horia Olaru  <olaru@adobe.com>
965
966         Adding manual debugger test cases for bug.
967
968         https://bugs.webkit.org/show_bug.cgi?id=21073
969
970         Reviewed by Kevin McCullough.
971
972         * manual-tests/inspector/debugger-step-on-do-while-statements.html: Added.
973         * manual-tests/inspector/debugger-step-on-for-in-statements.html: Added.
974         * manual-tests/inspector/debugger-step-on-for-statements.html: Added.
975         * manual-tests/inspector/debugger-step-on-while-statements.html: Added.
976         * manual-tests/inspector/resources/loop-statements.js: Added.
977
978 2009-03-01  Dan Bernstein  <mitz@apple.com>
979
980         Reviewed by Darin Adler.
981
982         - fix <rdar://problem/6634768> Reproducible crash in RenderLayer::updateScrollCornerStyle() using full-page zoom at MobileMe Contacts
983
984         Test: fast/events/scroll-during-zoom-change.html
985
986         * dom/Document.cpp:
987         (WebCore::Document::recalcStyle): Pause scheduled events during style
988         reclaculation. Changes to the zoom property result in scroll events
989         being generated during style recalc, and those events need to be
990         deferred until the render tree is consistent.
991         * page/FrameView.cpp:
992         (WebCore::FrameView::layout): Changed to account for a case in which the
993         post-layout tasks trigger a nested layout, which reactivates the
994         post-layout task timer.
995
996 2009-03-01  Ross Boucher  <rboucher@gmail.com>
997
998         Alphabetically sort scripts in the Script's panel file popup menu.
999
1000         https://bugs.webkit.org/show_bug.cgi?id=23395
1001
1002         Reviewed by Timothy Hatcher.
1003
1004         * inspector/front-end/ScriptsPanel.js:
1005         (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
1006         * inspector/front-end/utilities.js:
1007         (insertionIndexForObjectInListSortedByFunction):
1008         (indexOfObjectInListSortedByFunction):
1009
1010 2009-03-01  Yael Aharon  <yael.aharon@nokia.com>
1011
1012         Pass securityOrigin->host() instead of securityOrigin->domain() to WebInspector
1013         when creating databases, localStorage or sessionStorage. Changing document.domain
1014         should have no affect on databases, localStorage and sessionStorage in Web Inspector.
1015
1016         https://bugs.webkit.org/show_bug.cgi?id=23844
1017
1018         Reviewed by Timothy Hatcher.
1019
1020         * inspector/InspectorController.cpp:
1021         (WebCore::InspectorController::addDOMStorageScriptResource):
1022         (WebCore::InspectorController::didUseDOMStorage):
1023         * storage/Database.cpp:
1024         (WebCore::Database::openDatabase):
1025
1026 2009-03-01  Gustavo Noronha Silva  <gns@gnome.org>
1027
1028         Reviewed by Holger Freyther.
1029
1030         Avoid leaking errors when reporting GIO errors.
1031
1032         * platform/network/soup/ResourceHandleSoup.cpp:
1033         (WebCore::readCallback):
1034         (WebCore::openCallback):
1035         (WebCore::queryInfoCallback):
1036
1037 2009-03-01  Gustavo Noronha Silva  <gns@gnome.org>
1038
1039         Reviewed by Holger Freyther.
1040
1041         Fixes crash when the GIO backend is given the URI for a directory.
1042
1043         * platform/network/soup/ResourceHandleSoup.cpp:
1044         (WebCore::networkErrorForFile):
1045
1046 2009-02-28  Dimitri Glazkov  <dglazkov@chromium.org>
1047
1048         Reviewed by Darin Fisher.
1049
1050         https://bugs.webkit.org/show_bug.cgi?id=24261
1051         Fix V8 custom binding scrubbing error.
1052
1053         Test: fast/dom/TreeWalker/TreeWalker-currentNode.html
1054         Test: traversal/exception-forwarding.html
1055         TesT: traversal/stay-within-root.html
1056
1057         * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
1058         * bindings/v8/custom/V8NodeIteratorCustom.cpp:
1059         (WebCore::toV8): Replace v8::Undefined() return value with v8::Null().
1060         * bindings/v8/custom/V8TreeWalkerCustom.cpp:
1061         (WebCore::toV8): Ditto.
1062
1063 2009-02-28  Dimitri Glazkov  <dglazkov@chromium.org>
1064
1065         Reviewed by Darin Fisher.
1066
1067         https://bugs.webkit.org/show_bug.cgi?id=24261
1068         Fix V8 custom binding scrubbing error.
1069
1070         Test: fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html
1071
1072         * WebCore.xcodeproj/project.pbxproj:
1073         * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
1074         (WebCore::cssPropertyName):  Remove dubious checks, left over from
1075             incomplete conversion of parameter from pointer to pass-by-ref.
1076         (WebCore::NAMED_PROPERTY_GETTER): Initialize parameter.
1077         (WebCore::NAMED_PROPERTY_SETTER): Ditto.
1078
1079 2009-02-28  Xan Lopez  <xan@gnome.org>
1080
1081         Reviewed by Holger Freyther.
1082
1083         https://bugs.webkit.org/show_bug.cgi?id=24263
1084         [GTK] ref ResourceHandle until we are finished with it
1085
1086         Add a ref to the ResourceHandle in startHttp so we can keep it
1087         alive untill all callbacks have been executed, and unref it when
1088         soup tells us it's done with the SoupMessage (in
1089         finishedCallback). Fixes a number of crashes when calling
1090         didReceiveData whould crash because of the handle dying.
1091
1092         * platform/network/soup/ResourceHandleSoup.cpp:
1093         (WebCore::finishedCallback):
1094         (WebCore::ResourceHandle::startHttp):
1095
1096 2009-02-28  Adam Bergkvist <adam.bergkvist@ericsson.com>
1097
1098         Reviewed by Alexey Proskuryakov.
1099
1100         https://bugs.webkit.org/show_bug.cgi?id=24226
1101         [SOUP] HTTP status text is never set
1102
1103         Set HTTP status text to SoupMessage reason_phrase.
1104
1105         * platform/network/soup/ResourceHandleSoup.cpp:
1106         (WebCore::fillResponseFromMessage):
1107
1108 2009-02-28  Dan Bernstein  <mitz@apple.com>
1109
1110         - fix malformed project file
1111
1112         * WebCore.xcodeproj/project.pbxproj:
1113
1114 2009-02-28  Dan Bernstein  <mitz@apple.com>
1115
1116         Reviewed by Oliver Hunt.
1117
1118         - fix https://bugs.webkit.org/show_bug.cgi?id=23848
1119           <rdar://problem/6573250> REGRESSION: Crash when mouse cursor moves over a link on www.opportuno.de
1120
1121         Test: fast/layers/inline-dirty-z-order-lists.html
1122
1123         * rendering/RenderBox.cpp:
1124         (WebCore::RenderBox::styleWillChange): Moved the code that dirties a
1125         layer's and its stacking context's z-order lists when the layer's
1126         z-index or visibility change from here...
1127         * rendering/RenderBoxModelObject.cpp:
1128         (WebCore::RenderBoxModelObject::styleWillChange): ...to here, so that
1129         it will apply to RenderInline too.
1130
1131 2009-02-27  Alexey Proskuryakov  <ap@webkit.org>
1132
1133         Reviewed by David Hyatt.
1134
1135         Don't include TextResourceDecoder.h in Document.h
1136
1137         This undoes inlining of Document::displayStringModifiedByEncoding() to avoid world rebuilds
1138         when TextResourceDecoder.h is modified. Performance impact is expected to be negligible.
1139
1140         * dom/Document.cpp:
1141         (WebCore::Document::displayStringModifiedByEncoding):
1142         (WebCore::Document::displayBufferModifiedByEncoding):
1143         * dom/Document.h:
1144         * WebCore.base.exp:
1145
1146 2009-02-27  Matt Pennig  <pennig@apple.com>
1147
1148         Reviewed by David Hyatt.
1149
1150         Resolves: https://bugs.webkit.org/show_bug.cgi?id=24107
1151         "Fixed elements have 0 as an offsetLeft property"
1152         
1153         Code also brings offsetLeft/Top in full conformance with the spec.
1154         Added two tests, one for fixed-position elements, and one for <html>.
1155         
1156         Tests: fast/dom/Element/fixed-position-offset-parent.html
1157                fast/dom/Element/offsetLeft-offsetTop-html.html
1158
1159         * rendering/RenderBoxModelObject.cpp:
1160         (WebCore::RenderBoxModelObject::offsetLeft):
1161         (WebCore::RenderBoxModelObject::offsetTop):
1162
1163 2009-02-27  Dean Jackson  <dino@apple.com>
1164
1165         Reviewed by Simon Fraser.
1166
1167         renderer()->hasTransform() returns true for elements
1168         with perspective, but no transform, so test for transform
1169         when hit testing. This fixes ASSERT from
1170         https://bugs.webkit.org/show_bug.cgi?id=24252
1171
1172         Test: transforms/no_transform_hit_testing.html
1173
1174         * rendering/RenderLayer.cpp:
1175         (WebCore::RenderLayer::hitTestLayer):
1176
1177 2009-02-27  Dimitri Glazkov  <dglazkov@chromium.org>
1178
1179         Reviewed by Darin Fisher.
1180
1181         Fix scrubbing error -- a reversed condition.
1182
1183         * bindings/v8/ScriptValue.h:
1184         (WebCore::ScriptValue::clear): Change early exit for empty value, not the opposite.
1185
1186 2009-02-27  Jian Li  <jianli@chromium.org>
1187
1188         Reviewed by Alexey Proskuryakov.
1189
1190         Add confirmMessageFromWorkerObject to WorkerObjectProxy.
1191         https://bugs.webkit.org/show_bug.cgi?id=24152
1192
1193         * workers/WorkerMessagingProxy.cpp:
1194         (WebCore::MessageWorkerContextTask::performTask):
1195         (WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
1196         * workers/WorkerMessagingProxy.h:
1197         * workers/WorkerObjectProxy.h:
1198
1199 2009-02-27  Anders Carlsson  <andersca@apple.com>
1200
1201         Reviewed by David Hyatt.
1202
1203         Revert r41295, the fix for https://bugs.webkit.org/show_bug.cgi?id=24227 
1204         because it leads to assertion failures in the Mac port.
1205         
1206         * platform/graphics/BitmapImage.cpp:
1207         (WebCore::BitmapImage::BitmapImage):
1208         * platform/graphics/BitmapImage.h:
1209         (WebCore::BitmapImage::mayFillWithSolidColor):
1210         * platform/graphics/Image.h:
1211         (WebCore::Image::mayFillWithSolidColor):
1212         * platform/graphics/cairo/ImageCairo.cpp:
1213         (WebCore::BitmapImage::BitmapImage):
1214         * platform/graphics/cg/ImageCG.cpp:
1215         (WebCore::BitmapImage::BitmapImage):
1216         (WebCore::BitmapImage::checkForSolidColor):
1217         * platform/graphics/qt/ImageQt.cpp:
1218         (WebCore::BitmapImage::checkForSolidColor):
1219         * platform/graphics/skia/ImageSkia.cpp:
1220         (WebCore::BitmapImage::checkForSolidColor):
1221         * platform/graphics/wx/ImageWx.cpp:
1222         (WebCore::BitmapImage::checkForSolidColor):
1223
1224 2009-02-27  Adam Barth  <abarth@webkit.org>
1225
1226         Reviewed by Eric Seidel.
1227
1228         https://bugs.webkit.org/show_bug.cgi?id=20249
1229
1230         Add a preference to allow universal access from local URLs to mitigate
1231         some attacks.  Some clients still want to allow this access, so we
1232         expose this as a preference.
1233
1234         * WebCore.base.exp:
1235         * dom/Document.cpp:
1236         (WebCore::Document::initSecurityContext):
1237         * page/SecurityOrigin.cpp:
1238         (WebCore::SecurityOrigin::SecurityOrigin):
1239         * page/Settings.cpp:
1240         (WebCore::Settings::Settings):
1241         (WebCore::Settings::setAllowUniversalAccessFromFileUrls):
1242         * page/Settings.h:
1243         (WebCore::Settings::allowUniversalAccessFromFileUrls):
1244
1245 2009-02-27  Adam Treat  <adam.treat@torchmobile.com>
1246
1247         Reviewed by Eric Seidel.
1248
1249         https://bugs.webkit.org/show_bug.cgi?id=24229
1250         If an image has no alpha channel there is no reason to use SourceOver.
1251
1252         * platform/graphics/qt/ImageQt.cpp:
1253         (WebCore::Image::drawPattern):
1254         (WebCore::BitmapImage::draw):
1255
1256 2009-02-27  Adam Treat  <adam.treat@torchmobile.com>
1257
1258         Reviewed by Eric Seidel and Simon Fraser.
1259
1260         https://bugs.webkit.org/show_bug.cgi?id=24227
1261         Ensure that the checkForSolidColor() optimization is correctly triggered
1262         for all cases of drawPattern.  Currently, the optimization was not triggered
1263         when the check had not been previously performed via a request for the
1264         image's NativeImagePtr.
1265
1266         Implement the Qt version of the checkForSolidColor() method.  Combined with
1267         the bug fix this reduces the time it takes to draw a repeating background
1268         of a 1x1 image from ~50msecs to ~0msecs on my machine.
1269
1270         * platform/graphics/BitmapImage.cpp:
1271         (WebCore::BitmapImage::BitmapImage):
1272         * platform/graphics/BitmapImage.h:
1273         (WebCore::BitmapImage::mayFillWithSolidColor):
1274         * platform/graphics/Image.h:
1275         (WebCore::Image::mayFillWithSolidColor):
1276         * platform/graphics/cairo/ImageCairo.cpp:
1277         (WebCore::BitmapImage::BitmapImage):
1278         * platform/graphics/cg/ImageCG.cpp:
1279         (WebCore::BitmapImage::BitmapImage):
1280         (WebCore::BitmapImage::checkForSolidColor):
1281         * platform/graphics/qt/ImageQt.cpp:
1282         (WebCore::BitmapImage::checkForSolidColor):
1283         * platform/graphics/skia/ImageSkia.cpp:
1284         (WebCore::BitmapImage::checkForSolidColor):
1285         * platform/graphics/wx/ImageWx.cpp:
1286         (WebCore::BitmapImage::checkForSolidColor):
1287
1288 2009-02-27  Dirk Schulze  <krit@webkit.org>
1289
1290         Reviewed by Zack Rusin.
1291
1292         Added support for gradients and pattern on Fonts for Qt.
1293
1294         [Qt] gradients and patterns for FontQt
1295         https://bugs.webkit.org/show_bug.cgi?id=24243
1296
1297         * platform/graphics/qt/FontQt.cpp:
1298         (WebCore::Font::drawComplexText):
1299
1300 2009-02-27  Jian Li  <jianli@chromium.org>
1301
1302         Reviewed by Alexey Proskuryakov.
1303
1304         WorkerContextProxy::create in WorkerMessagingProxy.cpp should only be provided for non-Chromium platform.
1305         https://bugs.webkit.org/show_bug.cgi?id=24113
1306
1307         * workers/WorkerMessagingProxy.cpp:
1308
1309 2009-02-27  Yael Aharon  <yael.aharon@nokia.com>
1310
1311         Added a refresh button to storage views.
1312
1313         https://bugs.webkit.org/show_bug.cgi?id=24040
1314
1315         Reviewed by Timothy Hatcher.
1316
1317         * inspector/front-end/DOMStorageItemsView.js:
1318         (WebInspector.DOMStorageItemsView):
1319         (WebInspector.DOMStorageItemsView.prototype.get statusBarItems):
1320         (WebInspector.DOMStorageItemsView.prototype.update):
1321         (WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
1322         * inspector/front-end/DatabaseTableView.js:
1323         (WebInspector.DatabaseTableView):
1324         (WebInspector.DatabaseTableView.prototype.get statusBarItems):
1325         (WebInspector.DatabaseTableView.prototype._refreshButtonClicked):
1326         * inspector/front-end/DatabasesPanel.js:
1327         (WebInspector.DatabasesPanel):
1328         (WebInspector.DatabasesPanel.prototype.get statusBarItems):
1329         (WebInspector.DatabasesPanel.prototype.reset):
1330         (WebInspector.DatabasesPanel.prototype.showDatabase):
1331         (WebInspector.DatabasesPanel.prototype.showDOMStorage):
1332         (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
1333         * inspector/front-end/inspector.css:
1334
1335 2009-02-27  Yael Aharon  <yael.aharon@nokia.com>
1336
1337         Added support for editing/deleting localStorage and sessionStorage items
1338         directly from Web Inspector.
1339
1340         https://bugs.webkit.org/show_bug.cgi?id=23866.
1341
1342         Reviewed by Timothy Hatcher.
1343
1344         * WebCore.vcproj/WebCore.vcproj:
1345         * inspector/front-end/DOMStorageDataGrid.js: Added.
1346         (WebInspector.DOMStorageDataGrid):
1347         (WebInspector.DOMStorageDataGrid.prototype._ondblclick):
1348         (WebInspector.DOMStorageDataGrid.prototype._startEditing):
1349         (WebInspector.DOMStorageDataGrid.prototype._editingCommitted):
1350         (WebInspector.DOMStorageDataGrid.prototype._editingCancelled):
1351         (WebInspector.DOMStorageDataGrid.prototype.deleteSelectedRow):
1352         * inspector/front-end/DOMStorageItemsView.js:
1353         (WebInspector.DOMStorageItemsView):
1354         (WebInspector.DOMStorageItemsView.prototype.get statusBarItems):
1355         (WebInspector.DOMStorageItemsView.prototype.hide):
1356         (WebInspector.DOMStorageItemsView.prototype.update):
1357         (WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):
1358         * inspector/front-end/DatabasesPanel.js:
1359         (WebInspector.DatabasesPanel):
1360         (WebInspector.DatabasesPanel.prototype.get statusBarItems):
1361         (WebInspector.DatabasesPanel.prototype.reset):
1362         (WebInspector.DatabasesPanel.prototype.showDOMStorage):
1363         (WebInspector.DatabasesPanel.prototype.dataGridForDOMStorage):
1364         (WebInspector.DatabasesPanel.prototype._updateSidebarWidth):
1365         * inspector/front-end/WebKit.qrc:
1366         * inspector/front-end/inspector.css:
1367         * inspector/front-end/inspector.html:
1368
1369 2009-02-26  Brett Wilson  <brettw@chromium.org>
1370
1371         Fix Windows transparency for the Chromium port. Implement a helper
1372         class for handling transparency on Windows. It allows semitransparent
1373         ClearType and semitransparent form controls by making new layers in the
1374         background.
1375
1376         It also replaces the "ThemeHelper" which allows better
1377         scaling and transforms on Windows form controls. In addition to the
1378         functionality that the ThemeHelper did, but additionally handles the
1379         antialiasing properly so that the form controls aren't composited on a
1380         white square.
1381
1382         https://bugs.webkit.org/show_bug.cgi?id=24101
1383
1384         Reviewed by Eric Seidel.
1385
1386         * platform/graphics/chromium/FontChromiumWin.cpp:
1387         (WebCore::):
1388         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
1389         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
1390         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
1391         (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::drawGlyphs):
1392         (WebCore::Font::drawGlyphs):
1393         * platform/graphics/chromium/ThemeHelperChromiumWin.cpp:
1394         * platform/graphics/chromium/ThemeHelperChromiumWin.h:
1395         * platform/graphics/chromium/TransparencyWin.cpp: Added.
1396         (WebCore::):
1397         (WebCore::TransparencyWin::OwnedBuffers::OwnedBuffers):
1398         (WebCore::TransparencyWin::OwnedBuffers::destBitmap):
1399         (WebCore::TransparencyWin::OwnedBuffers::referenceBitmap):
1400         (WebCore::TransparencyWin::OwnedBuffers::canHandleSize):
1401         (WebCore::TransparencyWin::TransparencyWin):
1402         (WebCore::TransparencyWin::~TransparencyWin):
1403         (WebCore::TransparencyWin::init):
1404         (WebCore::TransparencyWin::computeLayerSize):
1405         (WebCore::TransparencyWin::setupLayer):
1406         (WebCore::TransparencyWin::setupLayerForNoLayer):
1407         (WebCore::TransparencyWin::setupLayerForOpaqueCompositeLayer):
1408         (WebCore::TransparencyWin::setupLayerForTextComposite):
1409         (WebCore::TransparencyWin::setupLayerForWhiteLayer):
1410         (WebCore::TransparencyWin::setupTransform):
1411         (WebCore::TransparencyWin::setupTransformForKeepTransform):
1412         (WebCore::TransparencyWin::setupTransformForUntransform):
1413         (WebCore::TransparencyWin::setupTransformForScaleTransform):
1414         (WebCore::TransparencyWin::setTextCompositeColor):
1415         (WebCore::TransparencyWin::initializeNewContext):
1416         (WebCore::TransparencyWin::compositeOpaqueComposite):
1417         (WebCore::TransparencyWin::compositeTextComposite):
1418         (WebCore::TransparencyWin::makeLayerOpaque):
1419         * platform/graphics/chromium/TransparencyWin.h: Added.
1420         (WebCore::TransparencyWin::):
1421         (WebCore::TransparencyWin::context):
1422         (WebCore::TransparencyWin::platformContext):
1423         (WebCore::TransparencyWin::drawRect):
1424         * platform/graphics/skia/GraphicsContextSkia.cpp:
1425         (WebCore::GraphicsContext::endTransparencyLayer):
1426         * platform/graphics/skia/ImageSkia.cpp:
1427         (WebCore::paintSkBitmap):
1428         * rendering/RenderThemeChromiumWin.cpp:
1429         (WebCore::):
1430         (WebCore::RenderThemeChromiumWin::paintButton):
1431         (WebCore::RenderThemeChromiumWin::paintMenuList):
1432         (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
1433
1434 2009-02-27  Dimitri Glazkov  <dglazkov@chromium.org>
1435
1436         Reviewed by Eric Seidel.
1437
1438         https://bugs.webkit.org/show_bug.cgi?id=24211
1439         Add ScheduledAction for V8.
1440
1441         * bindings/v8/ScheduledAction.cpp: Added.
1442         (WebCore::ScheduledAction::ScheduledAction):
1443         (WebCore::ScheduledAction::~ScheduledAction):
1444         (WebCore::ScheduledAction::execute):
1445         * bindings/v8/ScheduledAction.h: Added.
1446         (WebCore::ScheduledAction::ScheduledAction):
1447
1448 2009-02-27  Zack Rusin  <zack@kde.org>
1449
1450         Reviewed by Nikolas Zimmermann.
1451
1452         Qt: be more reasonable about scrolled lines
1453
1454         cMouseWheelPixelsPerLineStep is currently a constant set to 13.3. it doesn't
1455         match our metrics meaning that Qt scrolls by ~2 lines by default which is quite
1456         irritating. so lets scroll vertically by the Qt set number of lines * Qt default
1457         single step scroll
1458
1459         * platform/qt/WheelEventQt.cpp:
1460
1461 2009-02-27  Xan Lopez  <xan@gnome.org>
1462
1463         Rubber-stamped by Alexey Proskuryakov.
1464
1465         https://bugs.webkit.org/show_bug.cgi?id=24222
1466         [GTK] Remove checks for old glib versions
1467
1468         libsoup, which is a hard dependency, needs at least glib 2.15.3,
1469         so remove all glib checks for versions older than that.
1470
1471         * platform/gtk/ContextMenuGtk.cpp:
1472         (WebCore::ContextMenu::ContextMenu):
1473         * platform/gtk/ContextMenuItemGtk.cpp:
1474         (WebCore::ContextMenuItem::setSubMenu):
1475         * platform/gtk/PopupMenuGtk.cpp:
1476         (WebCore::PopupMenu::show):
1477         * platform/gtk/WidgetGtk.cpp:
1478         (WebCore::Widget::retainPlatformWidget):
1479         * platform/network/soup/ResourceHandleSoup.cpp:
1480
1481 2009-02-26  Dirk Schulze  <krit@webkit.org>
1482
1483         Reviewed by Oliver Hunt.
1484
1485         Added support for Gradients and Patterns on filled or stroked Fonts
1486         in Cairo. I also added support for globalAlpha on FontCairo.
1487
1488         [CAIRO] SVG/Canvas fonts miss gradients/pattern support
1489         https://bugs.webkit.org/show_bug.cgi?id=18617
1490
1491         * html/CanvasRenderingContext2D.cpp:
1492         (WebCore::CanvasRenderingContext2D::drawTextInternal):
1493         * platform/graphics/cairo/FontCairo.cpp:
1494         (WebCore::Font::drawGlyphs):
1495
1496 2009-02-26  Stephen White  <senorblanco@chromium.org>
1497
1498         Reviewed by Eric Seidel.
1499
1500         https://bugs.webkit.org/show_bug.cgi?id=23957
1501
1502         Fix for SVG gradient and pattern text for Chromium/skia. 
1503         Added accessors for the fill and stroke gradients to
1504         GraphicsContext.  Changed the paintSkiaText function to take a
1505         GraphicsContext, so we can check for gradients/patterns. 
1506         Changed the skiaDrawText function to set the SkPaint shader
1507         correctly, and to scale up the gradient shader matrix to
1508         encompass the entire text string.  Also offset each glyph
1509         separately, rather than transforming the canvas, so that the
1510         gradient/pattern stays fixed relative to the text origin.
1511
1512         * platform/graphics/GraphicsContext.cpp:
1513         (WebCore::GraphicsContext::getFillGradient):
1514         (WebCore::GraphicsContext::getStrokeGradient):
1515         (WebCore::GraphicsContext::getFillPattern):
1516         (WebCore::GraphicsContext::getStrokePattern):
1517         * platform/graphics/GraphicsContext.h:
1518         * platform/graphics/chromium/FontChromiumWin.cpp:
1519         (WebCore::Font::drawGlyphs):
1520         * platform/graphics/chromium/UniscribeHelper.cpp:
1521         (WebCore::UniscribeHelper::draw):
1522         * platform/graphics/skia/SkiaFontWin.cpp:
1523         (WebCore::windowsCanHandleTextDrawing):
1524         (WebCore::skiaDrawText):
1525         (WebCore::paintSkiaText):
1526         * platform/graphics/skia/SkiaFontWin.h:
1527
1528 2009-02-26  Dimitri Glazkov  <dglazkov@chromium.org>
1529
1530         Reviewed by Eric Seidel.
1531
1532         https://bugs.webkit.org/show_bug.cgi?id=24208
1533         Add custom V8 bindings for Navigator, Clipboard, Document, and Node.
1534
1535         * bindings/v8/custom/V8ClipboardCustom.cpp: Added.
1536         (WebCore::ACCESSOR_GETTER):
1537         (WebCore::CALLBACK_FUNC_DECL):
1538         * bindings/v8/custom/V8DocumentCustom.cpp: Added.
1539         (WebCore::CALLBACK_FUNC_DECL):
1540         * bindings/v8/custom/V8NavigatorCustom.cpp: Added.
1541         (WebCore::ACCESSOR_GETTER):
1542         * bindings/v8/custom/V8NodeCustom.cpp: Added.
1543         (WebCore::CALLBACK_FUNC_DECL):
1544
1545 2009-02-26  Gustavo Noronha Silva  <gns@gnome.org>
1546
1547         Unreviewed build fix for building with GNOME Keyring enabled.
1548
1549         * platform/network/soup/webkit-soup-auth-dialog.c:
1550         (show_auth_dialog):
1551
1552 2009-02-26  Xan Lopez  <xan@gnome.org>
1553
1554         Reviewed by Holger Freyther.
1555
1556         https://bugs.webkit.org/show_bug.cgi?id=16947
1557         [GTK] Missing HTTP Auth challenge
1558
1559         Add HTTP authentication dialog with optional GNOME Keyring
1560         storage.
1561
1562         * GNUmakefile.am:
1563         * platform/network/ResourceHandleInternal.h:
1564         (WebCore::ResourceHandleInternal::ResourceHandleInternal):
1565         * platform/network/soup/ResourceHandleSoup.cpp:
1566         (WebCore::currentToplevelCallback):
1567         (WebCore::ResourceHandle::startHttp):
1568         (WebCore::ResourceHandle::start):
1569         * platform/network/soup/webkit-soup-auth-dialog.c: Added.
1570         (webkit_soup_auth_dialog_class_init):
1571         (webkit_soup_auth_dialog_init):
1572         (webkit_soup_auth_dialog_session_feature_init):
1573         (free_authData):
1574         (set_password_callback):
1575         (response_callback):
1576         (show_auth_dialog):
1577         (find_password_callback):
1578         (session_authenticate):
1579         (attach):
1580         * platform/network/soup/webkit-soup-auth-dialog.h: Added.
1581
1582 2009-02-25  Ojan Vafai  <ojan@chromium.org> and Eric Seidel <eric@webkit.org>
1583
1584         Reviewed by Dave Hyatt.
1585
1586         After Ojan's positionForCoordinates fix http://trac.webkit.org/changeset/41191
1587         svg/custom/pointer-events-image.svg and svg/custom/pointer-events-text.svg
1588         started failing because Ojan's new code was now *correctly* calling through to
1589         SVG asking for the closest text offset in the last line box, instead of
1590         just returning the offset at the end of the last line box when clicking below a box.
1591
1592         But!  The SVG code was wrong, in that it returned the character offset of the last
1593         character when you asked for a character offset after the end of the box, instead
1594         it should return the offset *after* the last character.  This patch fixes
1595         that behavior by reordering the last two clauses in svgCharacterHitsPosition.
1596
1597         The SVG positionForCoordinates function is still wrong, and I've added some FIXMEs
1598         to document what's wrong.  I've also cleaned up the code a bit so it's clearer
1599         what it is doing (which also makes more obvious what's wrong with it).
1600
1601         * rendering/RenderSVGInlineText.cpp:
1602         (WebCore::RenderSVGInlineText::positionForCoordinates):
1603         * rendering/SVGInlineTextBox.cpp:
1604         (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::SVGInlineTextBoxClosestCharacterToPositionWalker):
1605         (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::chunkPortionCallback):
1606         (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::offsetOfHitCharacter):
1607         (WebCore::SVGInlineTextBox::closestCharacterToPosition):
1608         (WebCore::SVGInlineTextBox::svgCharacterHitsPosition):
1609
1610 2009-02-26  Darin Fisher  <darin@chromium.org>
1611
1612         Reviewed by Eric Seidel.
1613
1614         Minor cleanup of ChromiumBridge:
1615         Removing unused matchesMIMEType method and s/Javascript/JavaScript/
1616
1617         * platform/chromium/ChromiumBridge.h:
1618         * platform/chromium/MimeTypeRegistryChromium.cpp:
1619         (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
1620         (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
1621         (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
1622
1623 2009-02-26  David Hyatt  <hyatt@apple.com>
1624
1625         Reviewed by Sam Weinig
1626
1627         Fix text-bottom vertical alignment.  It was incorrectly aligning the bottom of the descent instead of including
1628         the line-height below the descent.
1629
1630         Added fast/inline/vertical-align-text-bottom.html
1631
1632         * rendering/RenderBoxModelObject.cpp:
1633         (WebCore::RenderBoxModelObject::verticalPosition):
1634
1635 2009-02-26  Dirk Schulze  <krit@webkit.org>
1636
1637         Reviewed by Eric Seidel.
1638
1639         Make SVG Masking platform independet with the use of ImageBuffer::getImageData(),
1640         ImageBuffer::putImageData() and GraphicsContext::clipToImageBuffer(). Every platform has
1641         just to implement this three methods to support SVG Masking now.
1642  
1643         Make SVG Masking platform aware
1644         https://bugs.webkit.org/show_bug.cgi?id=19243
1645
1646         * GNUmakefile.am:
1647         * WebCore.pro:
1648         * WebCore.vcproj/WebCore.vcproj:
1649         * WebCore.xcodeproj/project.pbxproj:
1650         * svg/graphics/SVGResourceMasker.cpp:
1651         (WebCore::SVGResourceMasker::applyMask):
1652         * svg/graphics/cairo/SVGResourceMaskerCairo.cpp: Removed.
1653         * svg/graphics/cg/SVGResourceMaskerCg.cpp: Removed.
1654         * svg/graphics/cg/SVGResourceMaskerCg.mm: Removed.
1655         * svg/graphics/qt/SVGResourceMaskerQt.cpp: Removed.
1656         * svg/graphics/skia/SVGResourceMaskerSkia.cpp: Removed.
1657
1658 2009-02-26  Yong Li  <yong.li@torchmobile.com>
1659
1660         Reviewed by Darin Adler, Antti Koivisto and Alexey Proskuryakov.
1661
1662         Test: http/tests/misc/slow-preload-cancel.html
1663
1664         https://bugs.webkit.org/show_bug.cgi?id=24133
1665         Clear all pending preloads in the DocLoader object when we decide to
1666         cancel its all requests.
1667
1668         * loader/DocLoader.cpp:
1669         (WebCore::DocLoader::clearPendingPreloads):
1670         * loader/DocLoader.h:
1671         * loader/loader.cpp:
1672         (WebCore::Loader::cancelRequests):
1673
1674 2009-02-26  Dimitri Glazkov  <dglazkov@chromium.org>
1675
1676         Reviewed by Eric Seidel.
1677
1678         https://bugs.webkit.org/show_bug.cgi?id=24182
1679         Add NodeFilter, NodeIterator, and TreeWalker custom V8 bindings.
1680
1681         * bindings/v8/custom/V8NodeFilterCustom.cpp: Added.
1682         (WebCore::CALLBACK_FUNC_DECL):
1683         * bindings/v8/custom/V8NodeIteratorCustom.cpp: Added.
1684         (WebCore::toV8):
1685         (WebCore::CALLBACK_FUNC_DECL):
1686         * bindings/v8/custom/V8TreeWalkerCustom.cpp: Added.
1687         (WebCore::toV8):
1688         (WebCore::CALLBACK_FUNC_DECL):
1689
1690 2009-02-26  Alexey Proskuryakov  <ap@webkit.org>
1691
1692         Reviewed by Darin Adler.
1693
1694         https://bugs.webkit.org/show_bug.cgi?id=23500
1695         KURL::parse() incorrectly compares its result to original string
1696
1697         * platform/KURL.cpp: (WebCore::KURL::parse): Take string length into account.
1698
1699 2009-02-26  Ojan Vafai  <ojan@chromium.org>
1700
1701         Reviewed by Kevin McCullough.
1702
1703         Manual test for inspector node highlighting.
1704
1705         * manual-tests/inspector/highlight-nodes.html: Added.
1706
1707 2009-02-16  Anantanarayanan Iyengar  <ananta@chromium.org>
1708
1709         Reviewed by Darin Fisher.
1710
1711         https://bugs.webkit.org/show_bug.cgi?id=23973
1712         ScrollView::scrollContents can be invoked during view shutdown.  In
1713         this scenario the FrameView::hostWindow method can return NULL, which
1714         indicates that the frame/page is being destroyed. This causes a crash
1715         when we try to dereference a NULL hostWindow pointer.  Fix is to add a
1716         NULL check for this.  
1717
1718         * platform/ScrollView.cpp:
1719         (WebCore::ScrollView::scrollContents):
1720
1721 2009-02-26  Rahul Kuchhal  <kuchhal@chromium.org>
1722
1723         Reviewed by Dave Hyatt.
1724
1725         https://bugs.webkit.org/show_bug.cgi?id=24003
1726         Fix a crash caused by unsafe type conversion.
1727
1728         Test: fast/block/positioning/absolute-in-inline-rtl-4.html
1729
1730         * rendering/RenderBox.cpp:
1731         (WebCore::RenderBox::calcAbsoluteHorizontalValues):
1732
1733 2009-02-26  Ojan Vafai  <ojan@chromium.org>
1734
1735         Reviewed by Adam Roben.
1736
1737         https://bugs.webkit.org/show_bug.cgi?id=24202
1738         Have drawNodeHighlight clip instead of clearing. This makes it work for
1739         both Safari and Chromium since Chromium draws the inspector highlighting
1740         in the same buffer as the page.
1741
1742         * inspector/InspectorController.cpp:
1743         (WebCore::quadToPath):
1744         (WebCore::drawOutlinedQuad):
1745         (WebCore::drawOutlinedQuadWithClip):
1746         (WebCore::drawHighlightForBox):
1747
1748 2009-02-26  David Hyatt  <hyatt@apple.com>
1749
1750         Reviewed by Dan Bernstein & Darin Adler
1751
1752         Make sure the border/padding are properly omitted at the start of an inline that is a continuation.
1753         
1754         Added fast/inline/inline-continuation-borders.html
1755
1756         * rendering/InlineFlowBox.cpp:
1757         (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
1758
1759 2009-02-26  Simon Fraser  <simon.fraser@apple.com>
1760
1761         Build fix, no review.
1762         
1763         Try to fix the wx build after r41218.
1764
1765         * WebCoreSources.bkl:
1766
1767 2009-02-26  Alexey Proskuryakov  <ap@webkit.org>
1768
1769         Reviewed by Darin Adler.
1770
1771         https://bugs.webkit.org/show_bug.cgi?id=19527
1772         ASSERTION FAILED: containerA && containerB
1773
1774         Test: fast/dom/Range/bug-19527.html
1775
1776         * dom/Range.cpp:
1777         (WebCore::Range::isPointInRange):
1778         (WebCore::Range::comparePoint):
1779         Bring the behavior in line with current Firefox, making it impossible for these methods
1780         to pass a null container to compareBoundaryPoints().
1781
1782 2009-02-26  Jonathon Jongsma  <jonathon@quotidian.org>
1783
1784         Reviewed by Holger Freyther.
1785
1786         https://bugs.webkit.org/show_bug.cgi?id=20358
1787
1788         * platform/graphics/gtk/SimpleFontDataGtk.cpp:
1789         (WebCore::SimpleFontData::smallCapsFontData): the small-caps font data
1790         should set the computed size rather than the specified size, otherwise
1791         the caps just get rendered normal size.
1792
1793 2009-02-26  Benjamin Meyer  <benjamin.meyer@torchmobile.com>
1794
1795         Reviewed by George Staikos.
1796
1797         https://bugs.webkit.org/show_bug.cgi?id=24062
1798         QNetworkCookieJar expects the url and not the policy url.  Sending the
1799         policy url will cause QNetworkCookieJar to behave incorrectly.  One
1800         example would be a cookie that does not have a path or domain.
1801         QNetworkCookieJar will use the url it is given to fill in default values.
1802         This allows setting cookies on the url of the main frame from an iFrame
1803         when the cookie should be set on the url of the iFrame.
1804
1805         Originally noticed on http://writer.zoho.com/jsp/home.jsp?serviceurl=/index.do
1806
1807         * platform/qt/CookieJarQt.cpp:
1808         (WebCore::setCookies):
1809
1810 2009-02-26  Charles Wei  <charles.wei@torchmobile.com.cn>
1811
1812         Reviewed by George Staikos.
1813
1814         make WebKit/Qt compile with SVG disabled
1815
1816         * WebCore.pro:
1817         * platform/graphics/qt/FontPlatformDataQt.cpp:
1818
1819 2009-02-25  Gustavo Noronha Silva  <gns@gnome.org>
1820
1821         Unreviewed build fix. Add WebCore/workers to the list of paths
1822         searched by the bindings generator perl script.
1823
1824         * GNUmakefile.am:
1825
1826 2009-02-25  Sam Weinig  <sam@webkit.org>
1827
1828         Reviewed by Geoffrey Garen.
1829
1830         Add canvas to the list of RenderObjects that can mark a page as
1831         visually not empty.
1832
1833         * rendering/RenderHTMLCanvas.cpp:
1834         (WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
1835
1836 2009-02-25  Eric Carlson  <eric.carlson@apple.com>
1837
1838         Reviewed by Dave Hyatt.
1839
1840         * rendering/RenderBox.cpp:
1841         (WebCore::RenderBox::nodeAtPoint): Remove assertion fired when child has layer
1842         as RenderMedia with controls always has a layer.
1843
1844 2009-02-25  Dan Bernstein  <mitz@apple.com>
1845
1846         Reviewed by Simon Fraser.
1847
1848         - fix https://bugs.webkit.org/show_bug.cgi?id=24130
1849           <rdar://problem/6618196> Paint very slow when horizontally resizing
1850
1851         Test: fast/gradients/background-clipped.html
1852
1853         * rendering/RenderBoxModelObject.cpp:
1854         (WebCore::RenderBoxModelObject::paintFillLayerExtended): Intersect the
1855         destination rectangle passed to drawTiledImage() with the dirty
1856         rectangle. This makes it more likely for the destination rect to be
1857         contained in a single tile rect, which results in a faster code path
1858         being taken down the road (just drawing a single tile instead of
1859         tiling).
1860
1861 2009-02-25  Ojan Vafai  <ojan@chromium.org>
1862
1863         Reviewed by Eric Seidel.
1864
1865         Fix test regressions from positionForCoordinates patch.
1866         https://bugs.webkit.org/show_bug.cgi?id=24148
1867
1868         * rendering/RenderBlock.cpp:
1869         (WebCore::positionForPointWithInlineChildren):
1870         Remove ASSERT that placeholder text codepath is hitting.
1871
1872 2009-02-25  Chris Fleizach  <cfleizach@apple.com>
1873
1874         Reviewed by Beth Dakin.
1875
1876         Bug 24143: Crash occurs at WebCore::AccessibilityTable::isTableExposableThroughAccessibility() when applying a link in GMail
1877         https://bugs.webkit.org/show_bug.cgi?id=24143
1878
1879         When an AX object is marked dirty, do not create AX elements while going up the parent chain.
1880         Do not allow AXRenderObjects to remove their own IDs from the cache, all the cache to do that work
1881         Make sure the AXObjectWrapper's have an object before calling them
1882         In AXObjectCache, change get -> getOrCreate. Use get() to only retrieve an element if it exists
1883
1884         Test: platform/mac-snowleopard/accessibility/table-updating.html
1885
1886         * WebCore.base.exp:
1887         * page/AXObjectCache.cpp:
1888         (WebCore::AXObjectCache::~AXObjectCache):
1889         (WebCore::AXObjectCache::get):
1890         (WebCore::AXObjectCache::getOrCreate):
1891         (WebCore::AXObjectCache::removeAXID):
1892         (WebCore::AXObjectCache::handleActiveDescendantChanged):
1893         (WebCore::AXObjectCache::handleAriaRoleChanged):
1894         * page/AXObjectCache.h:
1895         * page/AccessibilityImageMapLink.cpp:
1896         (WebCore::AccessibilityImageMapLink::parentObject):
1897         * page/AccessibilityListBox.cpp:
1898         (WebCore::AccessibilityListBox::listBoxOptionAccessibilityObject):
1899         (WebCore::AccessibilityListBox::doAccessibilityHitTest):
1900         * page/AccessibilityListBoxOption.cpp:
1901         (WebCore::AccessibilityListBoxOption::elementRect):
1902         (WebCore::AccessibilityListBoxOption::parentObject):
1903         * page/AccessibilityObject.cpp:
1904         (WebCore::AccessibilityObject::detach):
1905         (WebCore::AccessibilityObject::parentObjectIfExists):
1906         (WebCore::replacedNodeNeedsCharacter):
1907         (WebCore::AccessibilityObject::accessibilityObjectForPosition):
1908         * page/AccessibilityObject.h:
1909         * page/AccessibilityRenderObject.cpp:
1910         (WebCore::AccessibilityRenderObject::firstChild):
1911         (WebCore::AccessibilityRenderObject::lastChild):
1912         (WebCore::AccessibilityRenderObject::previousSibling):
1913         (WebCore::AccessibilityRenderObject::nextSibling):
1914         (WebCore::AccessibilityRenderObject::parentObjectIfExists):
1915         (WebCore::AccessibilityRenderObject::parentObject):
1916         (WebCore::AccessibilityRenderObject::isAttachment):
1917         (WebCore::AccessibilityRenderObject::headingLevel):
1918         (WebCore::AccessibilityRenderObject::anchorElement):
1919         (WebCore::AccessibilityRenderObject::menuForMenuButton):
1920         (WebCore::AccessibilityRenderObject::menuButtonForMenu):
1921         (WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
1922         (WebCore::AccessibilityRenderObject::internalLinkElement):
1923         (WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
1924         (WebCore::AccessibilityRenderObject::titleUIElement):
1925         (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
1926         (WebCore::AccessibilityRenderObject::accessibilityParentForImageMap):
1927         (WebCore::AccessibilityRenderObject::getDocumentLinks):
1928         (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
1929         (WebCore::AccessibilityRenderObject::focusedUIElement):
1930         (WebCore::AccessibilityRenderObject::activeDescendant):
1931         (WebCore::AccessibilityRenderObject::observableObject):
1932         (WebCore::AccessibilityRenderObject::childrenChanged):
1933         (WebCore::AccessibilityRenderObject::addChildren):
1934         * page/AccessibilityRenderObject.h:
1935         (WebCore::AccessibilityRenderObject::setRenderObject):
1936         * page/AccessibilityTable.cpp:
1937         (WebCore::AccessibilityTable::addChildren):
1938         (WebCore::AccessibilityTable::headerContainer):
1939         (WebCore::AccessibilityTable::cellForColumnAndRow):
1940         * page/AccessibilityTableCell.cpp:
1941         (WebCore::AccessibilityTableCell::isTableCell):
1942         (WebCore::AccessibilityTableCell::titleUIElement):
1943         * page/AccessibilityTableColumn.cpp:
1944         (WebCore::AccessibilityTableColumn::headerObjectForSection):
1945         * page/AccessibilityTableRow.cpp:
1946         (WebCore::AccessibilityTableRow::isTableRow):
1947         * page/gtk/AccessibilityObjectWrapperAtk.cpp:
1948         * page/mac/AXObjectCacheMac.mm:
1949         (WebCore::AXObjectCache::postNotification):
1950         (WebCore::AXObjectCache::postNotificationToElement):
1951         * page/mac/AccessibilityObjectWrapper.mm:
1952         (textMarkerForVisiblePosition):
1953         (AXLinkElementForNode):
1954         (nsStringForReplacedNode):
1955         (-[AccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):
1956         (-[AccessibilityObjectWrapper accessibilityActionNames]):
1957         (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
1958         (-[AccessibilityObjectWrapper accessibilityFocusedUIElement]):
1959         (-[AccessibilityObjectWrapper accessibilityHitTest:]):
1960         (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
1961         (-[AccessibilityObjectWrapper accessibilityIsIgnored]):
1962         (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
1963         (-[AccessibilityObjectWrapper accessibilityPerformPressAction]):
1964         (-[AccessibilityObjectWrapper accessibilityPerformAction:]):
1965         (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
1966         (-[AccessibilityObjectWrapper _accessibilityParentForSubview:]):
1967         (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]):
1968         (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
1969         (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
1970
1971 2009-02-25  Beth Dakin  <bdakin@apple.com>
1972
1973         Reviewed by Geoff Garen.
1974
1975         Re-working of <rdar://problem/6487249> repro crash in 
1976         WebCore::CSSParser::parseFillImage copying entire contents of this 
1977         page
1978         -and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172
1979
1980         Fixes a bunch of layout test failures I caused!
1981
1982         * css/CSSParser.cpp:
1983         (WebCore::CSSParser::parseValue):
1984         (WebCore::CSSParser::parseContent):
1985         (WebCore::CSSParser::parseFillImage):
1986         (WebCore::CSSParser::parseFontFaceSrc):
1987         (WebCore::CSSParser::parseBorderImage):
1988
1989 2009-02-25  Dimitri Glazkov  <dglazkov@chromium.org>
1990
1991         Reviewed by Eric Seidel.
1992
1993         https://bugs.webkit.org/show_bug.cgi?id=24174
1994         Add more V8 custom bindings.
1995
1996         * bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp: Added.
1997         (WebCore::hasCSSPropertyNamePrefix):
1998         (WebCore::cssPropertyName):
1999         (WebCore::NAMED_PROPERTY_GETTER):
2000         (WebCore::NAMED_PROPERTY_SETTER):
2001         * bindings/v8/custom/V8DOMStringListCustom.cpp: Added.
2002         (WebCore::INDEXED_PROPERTY_GETTER):
2003         (WebCore::CALLBACK_FUNC_DECL):
2004         * bindings/v8/custom/V8EventCustom.cpp: Added.
2005         (WebCore::ACCESSOR_SETTER):
2006         (WebCore::ACCESSOR_GETTER):
2007         * bindings/v8/custom/V8HTMLDocumentCustom.cpp: Added.
2008         (WebCore::NAMED_PROPERTY_DELETER):
2009         (WebCore::NAMED_PROPERTY_SETTER):
2010         (WebCore::NAMED_PROPERTY_GETTER):
2011         * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp: Added.
2012         (WebCore::NAMED_PROPERTY_GETTER):
2013         * bindings/v8/custom/V8NamedNodeMapCustom.cpp: Added.
2014         (WebCore::INDEXED_PROPERTY_GETTER):
2015         (WebCore::NAMED_PROPERTY_GETTER):
2016         * bindings/v8/custom/V8NodeListCustom.cpp: Added.
2017         (WebCore::NAMED_PROPERTY_GETTER):
2018         * bindings/v8/custom/V8StyleSheetListCustom.cpp: Added.
2019         (WebCore::NAMED_PROPERTY_GETTER):
2020
2021 2009-02-25  Scott Violet  <sky@google.com>
2022
2023         Reviewed by Dave Hyatt.
2024
2025         https://bugs.webkit.org/show_bug.cgi?id=24171
2026         Provides a RenderTheme method for getting the scroll bar size and
2027         changes RenderListBox to use it. RenderTheme returns a size of regular,
2028         and Mac's override to return small. Changes ScrollbarThemeChromium to
2029         use the scrollbarsize of the scrollbar when getting the size
2030         instead of passing in no-args.
2031
2032         * platform/chromium/ScrollbarThemeChromium.cpp:
2033         (WebCore::ScrollbarThemeChromium::trackRect):
2034         (WebCore::ScrollbarThemeChromium::buttonSize):
2035         * rendering/RenderListBox.cpp:
2036         (WebCore::RenderListBox::createScrollbar):
2037         * rendering/RenderTheme.h:
2038         (WebCore::RenderTheme::scrollbarControlSizeForPart):
2039         * rendering/RenderThemeChromiumMac.h:
2040         (WebCore::RenderThemeChromiumMac::scrollbarControlSizeForPart):
2041         * rendering/RenderThemeMac.h:
2042         (WebCore::RenderThemeMac::scrollbarControlSizeForPart):
2043
2044 2009-02-25  Beth Dakin  <bdakin@apple.com>
2045
2046         Reviewed by Darin Adler.
2047
2048         Fix for <rdar://problem/6487249> repro crash in 
2049         WebCore::CSSParser::parseFillImage copying entire contents of this 
2050         page
2051         -and corresponding: https://bugs.webkit.org/show_bug.cgi?id=24172
2052
2053         * css/CSSParser.cpp:
2054         (WebCore::CSSParser::parseValue): Null-check m_styleSheet
2055
2056 2009-02-25  Adam Treat  <adam.treat@torchmobile.com>
2057
2058         Fix the Qt build.
2059
2060         * WebCore.pro:
2061
2062 2009-02-25  Jan Michael Alonzo  <jmalonzo@webkit.org>
2063
2064         Gtk build fix. Not reviewed.
2065
2066         Add files to the build per r41218.
2067         Rename WebkitPoint.h to WebKitPoint.h in DOMWindow.cpp
2068
2069         * GNUmakefile.am:
2070         * page/DOMWindow.cpp:
2071
2072 2009-02-25  Zan Dobersek  <zandobersek@gmail.com>
2073
2074         Reviewed by Alexey Proskuryakov.
2075
2076         https://bugs.webkit.org/show_bug.cgi?id=24043
2077         When faced with URLs with unsupported protocol on Gtk port,
2078         report the error through an idle function and return true, so
2079         a proper resource handle is created.
2080
2081         * platform/network/soup/ResourceHandleSoup.cpp:
2082         (WebCore::reportUnknownProtocolError):
2083         (WebCore::ResourceHandle::start):
2084
2085 2009-02-25  Steve Falkenburg  <sfalken@apple.com>
2086
2087         Windows build fix.
2088         Use struct to forward declare ResourceRequest.
2089
2090         * history/HistoryItem.h:
2091         * inspector/InspectorController.h:
2092         * loader/DocumentThreadableLoader.h:
2093         * loader/FrameLoaderClient.h:
2094         * loader/MainResourceLoader.h:
2095         * loader/SubresourceLoader.h:
2096         * loader/SubresourceLoaderClient.h:
2097         * loader/ThreadableLoader.h:
2098         * loader/WorkerThreadableLoader.h:
2099         * platform/CrossThreadCopier.h:
2100         * platform/network/ResourceHandle.h:
2101         * platform/network/ResourceHandleClient.h:
2102         * platform/network/ResourceRequestBase.h:
2103         * platform/network/cf/ResourceRequestCFNet.h:
2104         * xml/XMLHttpRequest.h:
2105
2106 2009-02-25  Steve Falkenburg  <sfalken@apple.com>
2107
2108         Partial Windows build fix.
2109         
2110         * DerivedSources.cpp:
2111         * WebCore.vcproj/WebCore.vcproj:
2112
2113 2009-02-25  Dirk Schulze  <krit@webkit.org>
2114
2115         Reviewed by Oliver Hunt.
2116
2117         Ported arcTo to Qt. Qt has no native support for arcTo. This changes
2118         calculate the behavior of arcTo and draws it with lineTo and arc.
2119
2120         [QT] implement Canvas arcTo
2121         https://bugs.webkit.org/show_bug.cgi?id=23873
2122
2123         * platform/graphics/qt/PathQt.cpp:
2124         (WebCore::Path::addArcTo):
2125
2126 2009-02-25  Simon Fraser  <simon.fraser@apple.com>
2127
2128         Reviewed by Dan Bernstein
2129
2130         Remove idl files from Resources, and sort.
2131         
2132         * WebCore.xcodeproj/project.pbxproj:
2133
2134 2009-02-25  Chris Marrin  <cmarrin@apple.com>
2135
2136         Reviewed by Simon Fraser.
2137
2138         https://bugs.webkit.org/show_bug.cgi?id=23943
2139
2140         Added webkitConvertPointFromNodeToPage and webkitConvertPointFromPageToNode on
2141         the window object. Also added WebKitPoint object, which is passed in and out
2142         of these functions.
2143
2144         Test: fast/dom/Window/webkitConvertPoint.html
2145
2146         * DerivedSources.make:
2147         * WebCore.pro:
2148         * WebCore.vcproj/WebCore.vcproj:
2149         * WebCore.xcodeproj/project.pbxproj:
2150         * WebCoreSources.bkl:
2151         * bindings/js/JSDOMWindowBase.cpp:
2152         (jsDOMWindowBaseWebKitPoint):
2153         (setJSDOMWindowBaseWebKitPoint):
2154         * bindings/js/JSWebKitPointConstructor.cpp: Added.
2155         (WebCore::):
2156         (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
2157         (WebCore::constructWebKitPoint):
2158         (WebCore::JSWebKitPointConstructor::getConstructData):
2159         * bindings/js/JSWebKitPointConstructor.h: Added.
2160         (WebCore::JSWebKitPointConstructor::classInfo):
2161         * dom/Node.cpp:
2162         (WebCore::Node::convertToPage):
2163         (WebCore::Node::convertFromPage):
2164         * dom/Node.h:
2165         * page/DOMWindow.cpp:
2166         (WebCore::DOMWindow::webkitConvertPointFromNodeToPage):
2167         (WebCore::DOMWindow::webkitConvertPointFromPageToNode):
2168         * page/DOMWindow.h:
2169         * page/DOMWindow.idl:
2170         * page/WebKitPoint.h: Added.
2171         (WebCore::WebKitPoint::create):
2172         (WebCore::WebKitPoint::x):
2173         (WebCore::WebKitPoint::y):
2174         (WebCore::WebKitPoint::setX):
2175         (WebCore::WebKitPoint::setY):
2176         (WebCore::WebKitPoint::WebKitPoint):
2177         * page/WebKitPoint.idl: Added.
2178
2179 2009-02-25  Jian Li  <jianli@chromium.org>
2180
2181         Reviewed by Alexey Proskuryakov.
2182
2183         Remove "#if ENABLE(WORKERS)" wrap from CrossThreadCopier files.
2184         https://bugs.webkit.org/show_bug.cgi?id=24145
2185
2186         * platform/CrossThreadCopier.cpp:
2187         * platform/CrossThreadCopier.h:
2188
2189 2009-02-25  David Levin  <levin@chromium.org>
2190
2191         Reviewed by Alexey Proskuryakov.
2192
2193         Bug 23688: ThreadableLoader needs a sync implementation for Workers.
2194         <https://bugs.webkit.org/show_bug.cgi?id=23688>
2195
2196         No observable change in behavior, so no test.
2197
2198         * loader/ThreadableLoader.cpp:
2199         (WebCore::ThreadableLoader::loadResourceSynchronously):
2200         * loader/ThreadableLoaderClientWrapper.h:
2201         (WebCore::ThreadableLoaderClientWrapper::clearClient):
2202         (WebCore::ThreadableLoaderClientWrapper::done):
2203         (WebCore::ThreadableLoaderClientWrapper::didFinishLoading):
2204         (WebCore::ThreadableLoaderClientWrapper::didFail):
2205         (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck):
2206         (WebCore::ThreadableLoaderClientWrapper::ThreadableLoaderClientWrapper):
2207         Expose whether the loader is done (based on what callbacks were done).
2208
2209         * loader/WorkerThreadableLoader.cpp:
2210         (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
2211         (WebCore::WorkerThreadableLoader::loadResourceSynchronously):
2212         Each loader is given its own mode so that only its callbacks get through the run loop.
2213
2214         The xhr spec says that the readystatechange events are synchronous, so in the case of a
2215         nested sync xhr no readystatechange events should be fired for the outer xhr.
2216
2217         (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
2218
2219         * loader/WorkerThreadableLoader.h:
2220         (WebCore::WorkerThreadableLoader::create):
2221         (WebCore::WorkerThreadableLoader::done):
2222
2223         * workers/WorkerRunLoop.cpp:
2224         (WebCore::WorkerRunLoop::WorkerRunLoop):
2225         * workers/WorkerRunLoop.h:
2226         (WebCore::WorkerRunLoop::createUniqueId):
2227         Simple method to create a uniqueId on demand with respect to the run loop.
2228
2229         * workers/WorkerThread.h:
2230
2231 2009-02-25  David Levin  <levin@chromium.org>
2232
2233         Reviewed by Alexey Proskuryakov.
2234
2235         Bug 24089: ThreadableLoader::loadResourceSynchronously should do callbacks like the async code.
2236         <https://bugs.webkit.org/show_bug.cgi?id=24089>
2237
2238         Make threadable loader callbacks to happen during the sync load call.
2239
2240         Changes the behavior of sync xhr for insecure redirects in two ways:
2241         + Sends an error event instead of an abort event (which is the same as async xhr's behavior).
2242         + Throws a network exception which is what other browsers do and what the spec
2243         says to do (http://www.w3.org/TR/XMLHttpRequest/).
2244
2245         * loader/DocumentThreadableLoader.cpp:
2246         (WebCore::DocumentThreadableLoader::loadResourceSynchronously):
2247         * loader/DocumentThreadableLoader.h:
2248         * loader/ThreadableLoader.cpp:
2249         (WebCore::ThreadableLoader::loadResourceSynchronously):
2250         * loader/ThreadableLoader.h:
2251         * xml/XMLHttpRequest.cpp:
2252         (WebCore::XMLHttpRequest::XMLHttpRequest):
2253         (WebCore::XMLHttpRequest::loadRequestSynchronously):
2254         (WebCore::XMLHttpRequest::loadRequestAsynchronously):
2255         (WebCore::XMLHttpRequest::didFail):
2256         (WebCore::XMLHttpRequest::didFailRedirectCheck):
2257         * xml/XMLHttpRequest.h:
2258
2259 2009-02-24  Chris Marrin  <cmarrin@apple.com>
2260
2261         Reviewed by David Hyatt.
2262
2263         https://bugs.webkit.org/show_bug.cgi?id=23368
2264
2265         Added logic to correctly hit test accelerated layers.
2266
2267         Tests: animations/animation-hit-test-transform.html
2268                animations/animation-hit-test.html
2269                transitions/transition-hit-test-transform.html
2270                transitions/transition-hit-test.html
2271
2272         * page/animation/KeyframeAnimation.cpp:
2273         (WebCore::KeyframeAnimation::animate):
2274         * rendering/RenderLayer.cpp:
2275         (WebCore::RenderLayer::hitTestLayer):
2276         (WebCore::RenderLayer::updateClipRects):
2277         * rendering/RenderLayerBacking.cpp:
2278         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
2279
2280 2009-02-25  Alexey Proskuryakov  <ap@webkit.org>
2281
2282         Reviewed by Darin Adler.
2283
2284         https://bugs.webkit.org/show_bug.cgi?id=24067
2285         REGRESSION: Crash in WebCore::Document::initSecurityContext
2286
2287         The crash started to happen when we removed a check for frame->document() being null.
2288         However, the original document shouldn't be null here, because it is needed to alias
2289         security origins. So, this patch fixes the crash by correcting security origin behavior.
2290
2291         Test: http/tests/security/aboutBlank/window-open-self-about-blank.html
2292         This tests for not crashing, and for inheriting the domain from the document being replaced.
2293         Preserving the aliasing cannot be tested for automatically, because we'd need a non-trivial
2294         domain to remove a prefix from.
2295
2296         * loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): Create a new document before
2297         clearing the frame, so that Document::initSecurityContext() could access the old one.
2298
2299 2009-02-25  Jay Campan  <jcampan@google.com>
2300
2301         Reviewed by Darin Fisher.
2302
2303         https://bugs.webkit.org/show_bug.cgi?id=24066
2304
2305         Items in drop-downs were not painted correctly.  Makes sure the
2306         PopupListBox invalidates in the coordinates of the window as this is
2307         FramelessScrollView::invalidateRect paints to.
2308
2309         * platform/chromium/PopupMenuChromium.cpp:
2310         (WebCore::PopupListBox::invalidateRow):
2311
2312 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
2313
2314         Reviewed by Anders Carlsson
2315
2316         https://bugs.webkit.org/show_bug.cgi?id=15081
2317         
2318         Make display:none work for applet, emebed and object elements
2319         by calling rendererIsNeeded() on superclasses.
2320
2321         Tests: fast/replaced/applet-display-none.html
2322                fast/replaced/embed-display-none.html
2323                fast/replaced/object-display-none.html
2324
2325         * html/HTMLAppletElement.cpp:
2326         (WebCore::HTMLAppletElement::rendererIsNeeded):
2327         * html/HTMLElement.cpp:
2328         (WebCore::HTMLElement::rendererIsNeeded):
2329         * html/HTMLEmbedElement.cpp:
2330         (WebCore::HTMLEmbedElement::rendererIsNeeded):
2331         * html/HTMLObjectElement.cpp:
2332         (WebCore::HTMLObjectElement::rendererIsNeeded):
2333
2334 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
2335
2336         Reviewed by Dave Hyatt
2337
2338         https://bugs.webkit.org/show_bug.cgi?id=24137
2339         
2340         Fix localToAbsolute() and absoluteToLocal() to map points through 3d transforms,
2341         taking perspective and transform-style: preserve-3d into account.
2342         
2343         In order to support transform-style: preserve-3d, which keeps elements in a
2344         3d space, we have to carry along an accumulated matrix in TransformState.
2345         We also need to apply the perspective from the parent, if any, with the
2346         appropriate origin.
2347
2348         * GNUmakefile.am:
2349         * WebCore.base.exp:
2350         * WebCore.pro:
2351         * WebCore.scons:
2352         * WebCore.vcproj/WebCore.vcproj:
2353         * WebCore.xcodeproj/project.pbxproj:
2354         * WebCoreSources.bkl:
2355         * css/CSSComputedStyleDeclaration.cpp:
2356         (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
2357         * platform/graphics/transforms/TransformationMatrix.cpp:
2358         (WebCore::TransformationMatrix::translate):
2359         (WebCore::TransformationMatrix::translate3d):
2360         (WebCore::TransformationMatrix::translateRight3d):
2361         * platform/graphics/transforms/TransformationMatrix.h:
2362         * rendering/RenderBox.cpp:
2363         (WebCore::RenderBox::mapLocalToAbsolutePoint):
2364         (WebCore::RenderBox::mapAbsoluteToLocalPoint):
2365         * rendering/RenderBox.h:
2366         * rendering/RenderLayer.cpp:
2367         (WebCore::RenderLayer::updateTransform):
2368         (WebCore::RenderLayer::perspectiveTransform):
2369         (WebCore::RenderLayer::perspectiveOrigin):
2370         * rendering/RenderLayer.h:
2371         * rendering/RenderLayerBacking.cpp:
2372         (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
2373         * rendering/RenderLayerCompositor.cpp:
2374         (WebCore::requiresCompositingLayerForTransform):
2375         (WebCore::RenderLayerCompositor::layerHas3DContent):
2376         * rendering/RenderObject.cpp:
2377         (WebCore::RenderObject::localToAbsolute):
2378         (WebCore::RenderObject::absoluteToLocal):
2379         (WebCore::RenderObject::mapLocalToAbsolutePoint):
2380         (WebCore::RenderObject::mapAbsoluteToLocalPoint):
2381         * rendering/RenderObject.h:
2382         * rendering/RenderTableCell.cpp:
2383         (WebCore::RenderTableCell::mapLocalToAbsolutePoint):
2384         (WebCore::RenderTableCell::mapAbsoluteToLocalPoint):
2385         * rendering/RenderTableCell.h:
2386         * rendering/RenderView.cpp:
2387         (WebCore::RenderView::mapLocalToAbsolutePoint):
2388         (WebCore::RenderView::mapAbsoluteToLocalPoint):
2389         * rendering/RenderView.h:
2390         * rendering/TransformState.cpp: Added.
2391         (WebCore::TransformState::move):
2392         (WebCore::TransformState::applyTransform):
2393         (WebCore::TransformState::flatten):
2394         * rendering/TransformState.h: Added.
2395         (WebCore::TransformState::):
2396         (WebCore::TransformState::TransformState):
2397         (WebCore::TransformState::move):
2398         * rendering/style/RenderStyle.h:
2399         (WebCore::InheritedFlags::hasPerspective):
2400
2401 2009-02-24  Sam Weinig  <sam@webkit.org>
2402
2403         Reviewed by David Hyatt.
2404
2405         Fix for https://bugs.webkit.org/show_bug.cgi?id=23990
2406         Regression (r40837): JavaScript image popup doesn't work
2407
2408         Make the getClientRects and getBoundingClientRect methods return rects
2409         relative to the viewport.
2410
2411         Test: fast/dom/getBoundingClientRect-getClientRects-relative-to-viewport.html
2412
2413         * dom/Element.cpp:
2414         (WebCore::Element::getClientRects):
2415         (WebCore::Element::getBoundingClientRect):
2416
2417 2009-02-24  Ojan Vafai  <ojan@chromium.org>
2418
2419         Reviewed by Eric Seidel.
2420
2421         SVG pages don't have a body or an html element! 
2422         Don't return early if there is no body.
2423
2424         * editing/VisiblePosition.cpp:
2425         (WebCore::VisiblePosition::canonicalPosition):
2426
2427 2009-02-23  David Hyatt  <hyatt@apple.com>
2428
2429         Reviewed by Eric Seidel
2430
2431         https://bugs.webkit.org/show_bug.cgi?id=23740, painting order wrong for normal flow elements with overflow: hidden
2432         
2433         This patch reworks the painting of overflow.  There is now the concept of a "self-painting layer."  All
2434         layers are considered to be self-painting except for overflow layers that are normal flow (and that don't have
2435         reflections or masks).
2436         
2437         If an overflow layer is not self-painting, then it ends up painted by its parent just like any other normal flow object.
2438         The only difference is that the clip has to be pushed and popped when painting the object's children.
2439         
2440         The lightweight clipping scheme used for controls has been extended to cover overflow now in this simplified case.  With
2441         the code consolidated into reusable push/pop functions, all of the renderers that use overflow have been patched to
2442         use the new functions.
2443         
2444         Hit testing has also been patched to check the overflow clip rect first before recurring into children.
2445         
2446         Scrollbar paint has been moved into RenderBlock for now, since none of the table objects support scrollbars
2447         yet, and scrollbar hit testing was already there anyway.  Now the two code paths are more symmetrical.
2448         
2449         Masks are now treated like normal flow layers (just like reflections).
2450
2451         A couple of test cases have been added to fast/overflow to test the stacking order. 
2452
2453         * rendering/InlineFlowBox.cpp:
2454         (WebCore::InlineFlowBox::nodeAtPoint):
2455         (WebCore::InlineFlowBox::paint):
2456         * rendering/RenderBlock.cpp:
2457         (WebCore::RenderBlock::repaintOverhangingFloats):
2458         (WebCore::RenderBlock::paint):
2459         (WebCore::RenderBlock::paintChildren):
2460         (WebCore::RenderBlock::paintObject):
2461         (WebCore::RenderBlock::paintFloats):
2462         (WebCore::RenderBlock::insertFloatingObject):
2463         (WebCore::RenderBlock::floatRect):
2464         (WebCore::RenderBlock::lowestPosition):
2465         (WebCore::RenderBlock::rightmostPosition):
2466         (WebCore::RenderBlock::leftmostPosition):
2467         (WebCore::RenderBlock::addOverhangingFloats):
2468         (WebCore::RenderBlock::nodeAtPoint):
2469         (WebCore::RenderBlock::hitTestContents):
2470         * rendering/RenderBox.cpp:
2471         (WebCore::RenderBox::nodeAtPoint):
2472         (WebCore::RenderBox::pushContentsClip):
2473         (WebCore::RenderBox::popContentsClip):
2474         * rendering/RenderBox.h:
2475         (WebCore::RenderBox::paintObject):
2476         * rendering/RenderBoxModelObject.cpp:
2477         (WebCore::RenderBoxModelObject::hasSelfPaintingLayer):
2478         * rendering/RenderBoxModelObject.h:
2479         * rendering/RenderLayer.cpp:
2480         (WebCore::RenderLayer::paintLayer):
2481         (WebCore::RenderLayer::hitTestLayer):
2482         (WebCore::RenderLayer::shouldBeNormalFlowOnly):
2483         (WebCore::RenderLayer::isSelfPaintingLayer):
2484         * rendering/RenderLayer.h:
2485         * rendering/RenderTable.cpp:
2486         (WebCore::RenderTable::paint):
2487         (WebCore::RenderTable::paintObject):
2488         (WebCore::RenderTable::nodeAtPoint):
2489         * rendering/RenderTable.h:
2490         * rendering/RenderTableCell.cpp:
2491         (WebCore::RenderTableCell::paint):
2492         * rendering/RenderTableRow.cpp:
2493         (WebCore::RenderTableRow::nodeAtPoint):
2494         (WebCore::RenderTableRow::paint):
2495         * rendering/RenderTableRow.h:
2496         * rendering/RenderTableSection.cpp:
2497         (WebCore::RenderTableSection::paint):
2498         (WebCore::RenderTableSection::paintObject):
2499         (WebCore::RenderTableSection::nodeAtPoint):
2500         * rendering/RenderTableSection.h:
2501         * rendering/RenderTreeAsText.cpp:
2502         (WebCore::write):
2503         (WebCore::writeLayers):
2504
2505 2009-02-24  David Levin  <levin@chromium.org>
2506
2507         Reviewed by NOBODY (build fix).
2508
2509         Attempted build fix for wx-mac.
2510
2511         * WebCoreSources.bkl:
2512
2513 2009-02-24  David Levin  <levin@chromium.org>
2514
2515         Reviewed by NOBODY (build fix).
2516
2517         Attempted build fixes for qt-linux and wx-mac.
2518
2519         * WebCore.pro:
2520         * webcore-base.bkl:
2521
2522 2009-02-24  Ojan Vafai  <ojan@dhcp-172-31-134-214.sfo.corp.google.com>
2523
2524         Reviewed by Sam Weinig.
2525
2526         Fix null pointer error. If the node is the Document, then ownerDocument() 
2527         returns null, document() does not.
2528
2529         * editing/VisiblePosition.cpp:
2530         (WebCore::VisiblePosition::canonicalPosition):
2531
2532 2009-02-24  Jian Li  <jianli@chromium.org>
2533
2534         Reviewed by NOBODY (attempted build fixes).
2535
2536         Fix build break for Windows and Linux.
2537
2538         * GNUmakefile.am:
2539         * WebCore.vcproj/WebCore.vcproj:
2540
2541 2009-02-24  Dimitri Glazkov  <dglazkov@chromium.org>
2542
2543         Reviewed by Eric Seidel.
2544
2545         https://bugs.webkit.org/show_bug.cgi?id=24131
2546         Fix-up COM/RefCounted dichotomy in Chromium port.
2547
2548         * page/chromium/AccessibilityObjectWrapper.h:
2549         (WebCore::AccessibilityObjectWrapper::AccessibilityObjectWrapper): Added
2550         explicit setting of recount.
2551
2552 2009-02-24  Dimitri Glazkov  <dglazkov@chromium.org>
2553
2554         Reviewed by Eric Seidel.
2555
2556         https://bugs.webkit.org/show_bug.cgi?id=24141
2557         Add clarity to V8 interceptor helper function.
2558
2559         * bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
2560         (WebCore::NAMED_PROPERTY_GETTER): Renamed to notHandledByInterceptor.
2561         (WebCore::NAMED_PROPERTY_SETTER): Ditto.
2562         (WebCore::INDEXED_PROPERTY_GETTER): Ditto.
2563         (WebCore::INDEXED_PROPERTY_SETTER): Ditto.
2564
2565 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
2566
2567         Reviewed by Eric Seidel
2568
2569         Minor numeric cleanup: convert float literals to doubles.
2570         
2571         * platform/graphics/transforms/RotateTransformOperation.cpp:
2572         (WebCore::RotateTransformOperation::blend):
2573
2574 2009-02-24  Mark Mentovai  <mark@chromium.org>
2575
2576         Reviewed by Eric Seidel.
2577
2578         https://bugs.webkit.org/show_bug.cgi?id=24139
2579         Add missing include.
2580
2581         * bindings/v8/ScriptInstance.h:
2582
2583 2009-02-24  Jian Li  <jianli@chromium.org>
2584
2585         Reviewed by Alexey Proskuryakov.
2586
2587         Move worker related files from dom directory to worker directory under WebCore.
2588         https://bugs.webkit.org/show_bug.cgi?id=24123
2589
2590         * DerivedSources.make:
2591         * GNUmakefile.am:
2592         * WebCore.pro:
2593         * WebCore.scons:
2594         * WebCore.vcproj/MigrateIDLAndScripts:
2595         * WebCore.vcproj/WebCore.vcproj:
2596         * WebCore.xcodeproj/project.pbxproj:
2597         * platform/CrossThreadCopier.cpp: Renamed from WebCore/dom/CrossThreadCopier.cpp.
2598         * platform/CrossThreadCopier.h: Renamed from WebCore/dom/CrossThreadCopier.h.
2599         * workers/GenericWorkerTask.h: Renamed from WebCore/dom/GenericWorkerTask.h.
2600         * workers/Worker.cpp: Renamed from WebCore/dom/Worker.cpp.
2601         * workers/Worker.h: Renamed from WebCore/dom/Worker.h.
2602         * workers/Worker.idl: Renamed from WebCore/dom/Worker.idl.
2603         * workers/WorkerContext.cpp: Renamed from WebCore/dom/WorkerContext.cpp.
2604         * workers/WorkerContext.h: Renamed from WebCore/dom/WorkerContext.h.
2605         * workers/WorkerContext.idl: Renamed from WebCore/dom/WorkerContext.idl.
2606         * workers/WorkerContextProxy.h: Renamed from WebCore/dom/WorkerContextProxy.h.
2607         * workers/WorkerLocation.cpp: Renamed from WebCore/dom/WorkerLocation.cpp.
2608         * workers/WorkerLocation.h: Renamed from WebCore/dom/WorkerLocation.h.
2609         * workers/WorkerLocation.idl: Renamed from WebCore/dom/WorkerLocation.idl.
2610         * workers/WorkerMessagingProxy.cpp: Renamed from WebCore/dom/WorkerMessagingProxy.cpp.
2611         * workers/WorkerMessagingProxy.h: Renamed from WebCore/dom/WorkerMessagingProxy.h.
2612         * workers/WorkerObjectProxy.h: Renamed from WebCore/dom/WorkerObjectProxy.h.
2613         * workers/WorkerRunLoop.cpp: Renamed from WebCore/dom/WorkerRunLoop.cpp.
2614         * workers/WorkerRunLoop.h: Renamed from WebCore/dom/WorkerRunLoop.h.
2615         * workers/WorkerThread.cpp: Renamed from WebCore/dom/WorkerThread.cpp.
2616         * workers/WorkerThread.h: Renamed from WebCore/dom/WorkerThread.h.
2617
2618 2009-02-05  Ojan Vafai  <ojan@chromium.org> and Eric Seidel <eric@webkit.org>
2619
2620         Reviewed by Dave Hyatt.
2621
2622         Make cursor positions match IE6/IE7/FF3 when clicking in margins/padding
2623         around divs inside editable regions.
2624         https://bugs.webkit.org/show_bug.cgi?id=23605
2625
2626         Fix clicks outside editable regions from focusing the editable region.
2627         https://bugs.webkit.org/show_bug.cgi?id=23607
2628
2629         Removed editing/selection/contenteditable-click-outside.html as it's
2630         not as useful as our new tests.
2631
2632         Clean up RenderBlock::positionForCoordinates to remove dead code,
2633         duplicate code, and generally make it more readable.
2634
2635         Tests: editing/selection/click-in-margins-inside-editable-div.html
2636                editing/selection/click-in-padding-with-multiple-line-boxes.html
2637                editing/selection/click-outside-editable-div.html
2638
2639         * editing/VisiblePosition.cpp:
2640         (WebCore::VisiblePosition::canonicalPosition):
2641         * rendering/RenderBlock.cpp:
2642         (WebCore::positionForPointRespectingEditingBoundaries):
2643         (WebCore::positionForPointWithInlineChildren):
2644         (WebCore::RenderBlock::positionForCoordinates):
2645         (WebCore::RenderBlock::updateFirstLetter):
2646
2647 2009-02-24  Sam Weinig  <sam@webkit.org>
2648
2649         Reviewed by Geoffrey Garen.
2650
2651         Related to <rdar://problem/6590295>
2652         Allow disabling javascript: urls.
2653
2654         * WebCore.base.exp:
2655         * html/HTMLAnchorElement.cpp:
2656         (WebCore::HTMLAnchorElement::parseMappedAttribute):
2657         * loader/FrameLoader.cpp:
2658         (WebCore::FrameLoader::executeIfJavaScriptURL):
2659         * page/Page.cpp:
2660         (WebCore::Page::Page):
2661         (WebCore::Page::setJavaScriptURLsAreAllowed):
2662         (WebCore::Page::javaScriptURLsAreAllowed):
2663         * page/Page.h:
2664
2665 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
2666
2667         Fix build when ACCELERATED_COMPOSITING is turned on
2668         (overflowList() -> normalFlowList()).
2669     
2670         * rendering/RenderLayerBacking.cpp:
2671         (WebCore::RenderLayerBacking::hasNonCompositingContent):
2672         (WebCore::RenderLayerBacking::paintIntoLayer):
2673         * rendering/RenderLayerCompositor.cpp:
2674         (WebCore::RenderLayerCompositor::calculateCompositedBounds):
2675         (WebCore::RenderLayerCompositor::computeCompositingRequirements):
2676         (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
2677         (WebCore::RenderLayerCompositor::recursiveRepaintLayerRect):
2678         (WebCore::RenderLayerCompositor::layerHas3DContent):
2679
2680 2009-02-24  Simon Fraser  <simon.fraser@apple.com>
2681
2682         Reviewed by Darin Adler
2683         
2684         https://bugs.webkit.org/show_bug.cgi?id=24135
2685         
2686         Round the FloatPoint returned by absoluteToLocal(), rather than
2687         truncating it.
2688
2689         * dom/MouseRelatedEvent.cpp:
2690         (WebCore::MouseRelatedEvent::receivedTarget):
2691
2692 2009-02-24  Beth Dakin  <bdakin@apple.com>
2693
2694         Reviewed by Sam Weinig.
2695
2696         Fix for https://bugs.webkit.org/show_bug.cgi?id=24004 REGRESSION: 
2697         Ordered list item marker misaligned when line height is not 1.2 
2698         -and corresponding <rdar://problem/6602506>
2699
2700         This is a regression from http://trac.webkit.org/changeset/40880 
2701         where createInlineBox was taken off of RenderObject and moved to 
2702         RenderBox. The problem was that the RenderBox version still needs 
2703         to be virtual because there is still an existing implementation in 
2704         RenderListMarker. 
2705
2706         * rendering/RenderBox.h:
2707         * rendering/RenderListMarker.cpp:
2708         (WebCore::RenderListMarker::createInlineBox):
2709         * rendering/RenderListMarker.h:
2710
2711 2009-02-24  Dimitri Glazkov  <dglazkov@chromium.org>
2712
2713         Reviewed by Eric Seidel.
2714
2715         https://bugs.webkit.org/show_bug.cgi?id=24128
2716         Upstream more V8 custom bindings: constructors, XSLTProcessor.
2717
2718         * bindings/v8/custom/V8DOMParserConstructor.cpp: Added.
2719         (WebCore::CALLBACK_FUNC_DECL):
2720         * bindings/v8/custom/V8MessageChannelConstructor.cpp: Added.
2721         (WebCore::CALLBACK_FUNC_DECL):
2722         * bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp: Added.
2723         (WebCore::CALLBACK_FUNC_DECL):
2724         * bindings/v8/custom/V8XMLSerializerConstructor.cpp: Added.
2725         (WebCore::CALLBACK_FUNC_DECL):
2726         * bindings/v8/custom/V8XPathEvaluatorConstructor.cpp: Added.
2727         (WebCore::CALLBACK_FUNC_DECL):
2728         * bindings/v8/custom/V8XSLTProcessorCustom.cpp: Added.
2729         (WebCore::CALLBACK_FUNC_DECL):
2730
2731 2009-02-24  David Levin  <levin@chromium.org>
2732
2733         Reviewed by Alexey Proskuryakov.
2734
2735         Bug 24090: WorkerThreadableLoader needs to be able to post tasks for a mode.
2736         <https://bugs.webkit.org/show_bug.cgi?id=24090>
2737
2738         No observable change in behavior, so no test.
2739
2740         * dom/WorkerMessagingProxy.cpp:
2741         (WebCore::WorkerMessagingProxy::postMessageToWorkerContext):
2742         (WebCore::WorkerMessagingProxy::postTaskToWorkerContext):
2743         Fixed the bug that m_unconfirmedMessageCount was getting incremented for non-message tasks.
2744
2745         (WebCore::WorkerMessagingProxy::postTaskForModeToWorkerContext):
2746
2747         * dom/WorkerMessagingProxy.h:
2748         * loader/ThreadableLoader.cpp:
2749         (WebCore::ThreadableLoader::create):
2750         * loader/WorkerThreadableLoader.cpp:
2751         (WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
2752         (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
2753         (WebCore::WorkerThreadableLoader::MainThreadBridge::didSendData):
2754         (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
2755         (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
2756         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
2757         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
2758         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):
2759         (WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveAuthenticationCancellation):
2760         Changed these methods to post task using a mode.
2761
2762         * loader/WorkerThreadableLoader.h:
2763         (WebCore::WorkerThreadableLoader::create):
2764
2765 2009-02-24  Alexey Proskuryakov  <ap@webkit.org>
2766
2767         Reviewed by Darin Adler.
2768
2769         https://bugs.webkit.org/show_bug.cgi?id=24091
2770         <rdar://problem/6468660> Start of redirect chain ends up as master entry in Application Cache
2771
2772         Test: http/tests/appcache/access-via-redirect.php
2773
2774         * loader/appcache/ApplicationCacheGroup.cpp:
2775         (WebCore::ApplicationCacheGroup::finishedLoadingMainResource): Use the URL we ended up with,
2776         not the original one.
2777
2778 2009-02-24  Jian Li  <jianli@chromium.org>
2779
2780         Reviewed by Alexey Proskuryakov.
2781
2782         Change to include WorkerObjectProxy.h instead of WorkerMessagingProxy.h in WorkerContext.cpp and WorkerScriptController.cpp.
2783         https://bugs.webkit.org/show_bug.cgi?id=24112
2784
2785         * bindings/js/WorkerScriptController.cpp:
2786         * dom/WorkerContext.cpp:
2787
2788 2009-02-23  Antti Koivisto  <antti@apple.com>
2789
2790         Reviewed by Oliver Hunt.
2791
2792         <rdar://problem/6613796> Extended text codecs registered on webview creation
2793
2794         Comparing a text encoding with string "GBK" ended up constructing
2795         TextEncoding("GBK") which in turn initialized all extended
2796         text codecs.
2797
2798         * platform/text/TextCodecICU.cpp:
2799         (WebCore::TextCodecICU::decode):
2800
2801 2009-02-23  Sam Weinig  <sam@webkit.org>
2802
2803         Fix Qt build.
2804
2805         * bridge/qt/qt_runtime.cpp:
2806         (JSC::Bindings::valueRealType):
2807
2808 2009-02-23  Julien Chaffraix  <jchaffraix@webkit.org>
2809
2810         Reviewed by Darin Adler.
2811
2812         Bug 23956: Safari crashes when cloneNode fails (cloning a XML element with an invalid nodeName)
2813
2814         The crash occurred because Document::cloneNode would call Document::createElementNS. Unfortunately
2815         element created with createElement could have a wrong nodeName (createElement sets the string as the
2816         localName without checking for a prefix).
2817
2818         The fix is to call Document::createElement(const QualifiedName&, bool) that will not do any checks on the QualifiedName
2819         and will always succeed.
2820         Also rolled-out the HTMLElement specialisation of clonedNode as it was equivalent to what is done now (added an ASSERT
2821         to ensure that).
2822
2823         Test: fast/dom/cloneNode.html
2824
2825         * dom/Element.cpp:
2826         (WebCore::Element::cloneNode): Call createElement(const QualifiedName&, bool) instead of createElementNS as it will
2827         always return an element.
2828
2829         * html/HTMLElement.cpp:
2830         * html/HTMLElement.h: Removed HTMLElement::clonedNode as it is equivalent to what is now done.
2831
2832 2009-02-23  Dimitri Glazkov  <dglazkov@chromium.org>
2833
2834         Reviewed by Eric Seidel.
2835
2836         https://bugs.webkit.org/show_bug.cgi?id=24109
2837         Upstream V8 Script abstractions, all except ScriptController.
2838
2839         * bindings/v8/ScriptCachedFrameData.h: Added.
2840         (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
2841         (WebCore::ScriptCachedFrameData::~ScriptCachedFrameData):
2842         (WebCore::ScriptCachedFrameData::restore):
2843         (WebCore::ScriptCachedFrameData::clear):
2844         (WebCore::ScriptCachedFrameData::domWindow):
2845         * bindings/v8/ScriptCallFrame.cpp: Added.
2846         (WebCore::ScriptCallFrame::ScriptCallFrame):
2847         (WebCore::ScriptCallFrame::~ScriptCallFrame):
2848         (WebCore::ScriptCallFrame::argumentAt):
2849         * bindings/v8/ScriptCallFrame.h: Added.
2850         (WebCore::ScriptCallFrame::functionName):
2851         (WebCore::ScriptCallFrame::sourceURL):
2852         (WebCore::ScriptCallFrame::lineNumber):
2853         (WebCore::ScriptCallFrame::argumentCount):
2854         * bindings/v8/ScriptCallStack.cpp: Added.
2855         (WebCore::ScriptCallStack::ScriptCallStack):
2856         (WebCore::ScriptCallStack::~ScriptCallStack):
2857         (WebCore::ScriptCallStack::at):
2858         * bindings/v8/ScriptCallStack.h: Added.
2859         (WebCore::ScriptCallStack::size):
2860         * bindings/v8/ScriptInstance.cpp: Added.
2861         (WebCore::V8ScriptInstance::V8ScriptInstance):
2862         (WebCore::V8ScriptInstance::~V8ScriptInstance):
2863         (WebCore::V8ScriptInstance::instance):
2864         (WebCore::V8ScriptInstance::clear):
2865         (WebCore::V8ScriptInstance::set):
2866         * bindings/v8/ScriptInstance.h: Added.
2867         (WebCore::V8ScriptInstance::create):
2868         * bindings/v8/ScriptSourceCode.h: Added.
2869         (WebCore::ScriptSourceCode::ScriptSourceCode):
2870         (WebCore::ScriptSourceCode::isEmpty):
2871         (WebCore::ScriptSourceCode::source):
2872         (WebCore::ScriptSourceCode::url):
2873         (WebCore::ScriptSourceCode::startLine):
2874         * bindings/v8/ScriptState.h: Added.
2875         (WebCore::ScriptState::hadException):
2876         (WebCore::ScriptState::setException):
2877         (WebCore::ScriptState::exception):
2878         * bindings/v8/ScriptString.h: Added.
2879         (WebCore::ScriptString::ScriptString):
2880         (WebCore::ScriptString::operator String):
2881         (WebCore::ScriptString::isNull):
2882         (WebCore::ScriptString::size):
2883         (WebCore::ScriptString::operator=):
2884         (WebCore::ScriptString::operator+=):
2885         * bindings/v8/ScriptValue.cpp: Added.
2886         (WebCore::ScriptValue::getString):
2887         * bindings/v8/ScriptValue.h: Added.
2888         (WebCore::ScriptValue::ScriptValue):
2889         (WebCore::ScriptValue::operator=):
2890         (WebCore::ScriptValue::operator==):
2891         (WebCore::ScriptValue::operator!=):
2892         (WebCore::ScriptValue::isNull):
2893         (WebCore::ScriptValue::isUndefined):
2894         (WebCore::ScriptValue::clear):
2895         (WebCore::ScriptValue::~ScriptValue):
2896         (WebCore::ScriptValue::v8Value):
2897
2898 2009-02-23  Adam Treat  <adam.treat@torchmobile.com>
2899
2900         Reviewed by Timothy Hatcher.
2901
2902         https://bugs.webkit.org/show_bug.cgi?id=24106
2903         The Qt port is crashing on exit because the tear down procedure involves
2904         the WebCore::InspectorController trying to access the JS execution context
2905         for a page that is being deleted.  This patch amends the inspector so
2906         that it does not try and access the execution context of the WebCore::Page
2907         in the midst of deletion.
2908
2909         * inspector/InspectorController.cpp:
2910         (WebCore::InspectorController::inspectedPageDestroyed):
2911         (WebCore::InspectorController::stopUserInitiatedProfiling):
2912
2913 2009-02-23  David Levin  <levin@chromium.org>
2914
2915         Reviewed by Alexey Proskuryakov.
2916
2917         Bug 24088: ThreadableLoaderClient::didFailWillSendRequestCheck isn't wired up completely for workers and could use a better name.
2918         <https://bugs.webkit.org/show_bug.cgi?id=24088>
2919
2920         No observable change in behavior, so no test.
2921
2922         * loader/DocumentThreadableLoader.cpp:
2923         (WebCore::DocumentThreadableLoader::create):
2924         * loader/ThreadableLoaderClient.h:
2925         (WebCore::ThreadableLoaderClient::didFailRedirectCheck):
2926         * loader/ThreadableLoaderClientWrapper.h:
2927         (WebCore::ThreadableLoaderClientWrapper::didFailRedirectCheck):
2928         * loader/WorkerThreadableLoader.cpp:
2929         (WebCore::workerContextDidFailRedirectCheck):
2930         (WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):
2931         * loader/WorkerThreadableLoader.h:
2932         * xml/XMLHttpRequest.cpp:
2933         (WebCore::XMLHttpRequest::didFinishLoading):
2934         * xml/XMLHttpRequest.h:
2935
2936 2009-02-23  David Levin  <levin@chromium.org>
2937
2938         Reviewed by Alexey Proskuryakov.
2939
2940         Bug 24047: Need to simplify nested if's in WorkerRunLoop::runInMode
2941         <https://bugs.webkit.org/show_bug.cgi?id=24047>
2942
2943         Made a nested if inside of WorkerRunLoop::runInMode a lot simpler by
2944         using only MessageQueue::waitForMessageFilteredWithTimeout instead
2945         of three different MessageQueue methods.
2946
2947         No observable change in behavior, so no test.
2948
2949         * dom/WorkerRunLoop.cpp:
2950         (WebCore::ModePredicate::operator()):
2951         Minor clean-up to able to pass a const ref point for ModePredicate into runInMode.
2952         (WebCore::WorkerRunLoop::runInMode):
2953         * dom/WorkerRunLoop.h:
2954
2955 2009-02-23  David Hyatt  <hyatt@apple.com>
2956
2957         In preparation for making layers for multicol objects (so that they can properly split child layers
2958         into multiple columns), rename all of the "overflowOnly" and "overflowList" members and functions
2959         of RenderLayer to use the term "normal flow" instead.
2960
2961         Reviewed by Cameron Zwarich
2962
2963         * rendering/RenderLayer.cpp:
2964         (WebCore::RenderLayer::RenderLayer):
2965         (WebCore::RenderLayer::~RenderLayer):
2966         (WebCore::RenderLayer::setHasVisibleContent):
2967         (WebCore::RenderLayer::enclosingCompositingLayer):
2968         (WebCore::RenderLayer::addChild):
2969         (WebCore::RenderLayer::removeChild):
2970         (WebCore::RenderLayer::paintLayer):
2971         (WebCore::RenderLayer::hitTestLayer):
2972         (WebCore::RenderLayer::dirtyNormalFlowList):
2973         (WebCore::RenderLayer::updateNormalFlowList):
2974         (WebCore::RenderLayer::collectLayers):
2975         (WebCore::RenderLayer::updateLayerListsIfNeeded):
2976         (WebCore::RenderLayer::shouldBeNormalFlowOnly):
2977         (WebCore::RenderLayer::styleChanged):
2978         * rendering/RenderLayer.h:
2979         (WebCore::RenderLayer::isNormalFlowOnly):
2980         (WebCore::RenderLayer::normalFlowList):
2981         * rendering/RenderTreeAsText.cpp:
2982         (WebCore::writeLayers):
2983
2984 2009-02-23  David Hyatt  <hyatt@apple.com>
2985
2986         Fix the stacking order for column rules in multi-column layout.  Column rules should paint as part of the background of an element, just
2987         after all other components of the background have been painted.  This allows negative z-index children to still paint on top of the
2988         column rules (rather than ending up above the background of the box but behind the column rules).
2989
2990         Reviewed by Eric Seidel
2991
2992         Added fast/multicol/column-rules-stacking.html
2993
2994         * rendering/RenderBlock.cpp:
2995         (WebCore::RenderBlock::paintColumnRules):
2996         (WebCore::RenderBlock::paintColumnContents):
2997         (WebCore::RenderBlock::paintObject):
2998         * rendering/RenderBlock.h:
2999
3000 2009-02-23  Adam Treat  <adam.treat@torchmobile.com>
3001
3002         Reviewed by David Hyatt.
3003
3004         No testcases have been added or modified since this patch should not result in
3005         a behavior change for ports that have layout tests enabled.
3006
3007         Currently, the implementation of GraphicsContext::drawLineForText amongst
3008         the various ports differ in that some of them are honoring the context's
3009         strokeStyle when drawing a text-decoration and some of them are not.
3010         For instance, Apple's Mac port *does not* honor the context's strokeStyle(),
3011         but the Cairo implementation does and has an explicit workaround that
3012         sets the strokeStyle() temporarily.
3013
3014         This patch fixes so that all ports are consistent by explicitly making sure
3015         to set the GraphicsContext strokeStyle to SolidStroke whenever
3016         painting the text-decoration of an InlineFlowBox or InlineTextBox as these
3017         should always use a solid stroke.
3018
3019         This patch addresses these bugs:
3020         https://bugs.webkit.org/show_bug.cgi?id=19364
3021         https://bugs.webkit.org/show_bug.cgi?id=15659
3022
3023         * rendering/InlineFlowBox.cpp:
3024         (WebCore::InlineFlowBox::paintTextDecorations):
3025         * rendering/InlineTextBox.cpp:
3026         (WebCore::InlineTextBox::paintDecoration):
3027
3028 2009-02-23  Scott Violet  <sky@google.com>
3029
3030         Reviewed by Eric Seidel.
3031
3032         https://bugs.webkit.org/show_bug.cgi?id=24098
3033         Bugs in ClipboardChromium
3034
3035         Fixes the following bugs in ClipboardChromium:
3036         * It's possible for the extension to be empty, resulting in a bad file
3037           name, for example, 'foo.' or just '.'.
3038         * We weren't restricting the size of the file to MAX_PATH.
3039         * We weren't removing characters that are invalid for file system names.
3040
3041         * platform/chromium/ClipboardChromium.cpp:
3042         (WebCore::writeImageToDataObject):
3043         * platform/chromium/ClipboardChromium.h:
3044         * platform/chromium/ClipboardChromiumLinux.cpp: Added.
3045         (WebCore::ClipboardChromium::validateFileName):
3046         * platform/chromium/ClipboardChromiumMac.cpp: Added.
3047         (WebCore::ClipboardChromium::validateFileName):
3048         * platform/chromium/ClipboardChromiumWin.cpp: Added.
3049         (WebCore::isInvalidFileCharacter):
3050         (WebCore::ClipboardChromium::validateFileName):
3051
3052 2009-02-23  Thiago Macieira  <thiago.macieira@nokia.com>
3053
3054         Reviewed by Simon Hausmann.
3055
3056         Fix the Copyright notices in a few files
3057
3058         * platform/qt/RenderThemeQt.h:
3059
3060 2009-02-23  Xan Lopez  <xan@gnome.org>
3061
3062         Reviewed by Alexey Proskuryakov.
3063
3064         https://bugs.webkit.org/show_bug.cgi?id=22624
3065         [SOUP][GTK] Need API to get SoupSession from WebKit.
3066
3067         Allow to retrieve the Soup session and modify the code to take
3068         into account users changing features on it.
3069
3070         * platform/network/ResourceHandle.h:
3071         * platform/network/soup/CookieJarSoup.cpp:
3072         (WebCore::defaultCookieJar):
3073         (WebCore::setDefaultCookieJar):
3074         * platform/network/soup/CookieJarSoup.h:
3075         * platform/network/soup/ResourceHandleSoup.cpp:
3076         (WebCore::createSoupSession):
3077         (WebCore::ensureSessionIsInitialized):
3078         (WebCore::ResourceHandle::startHttp):
3079         (WebCore::ResourceHandle::cancel):
3080         (WebCore::ResourceHandle::defaultSession):
3081
3082 2009-02-23  Xan Lopez  <xan@gnome.org>
3083
3084         Reviewed by Alexey Proskuryakov.
3085
3086         https://bugs.webkit.org/show_bug.cgi?id=22624
3087         [SOUP][GTK] Need API to get SoupSession from WebKit.
3088
3089         Remove CURL support.
3090
3091         * GNUmakefile.am:
3092
3093 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3094
3095         Reviewed by Mark Rowe.
3096
3097         Test: fast/dom/empty-hash-and-search.html
3098
3099         https://bugs.webkit.org/show_bug.cgi?id=21147
3100         hash property returns incorrect value for links w/o hash
3101
3102         Make hash() and search() behavior for empty and missing parts match IE and Firefox.
3103
3104         * platform/KURL.cpp:
3105         (WebCore::KURL::query): Changed to return query without '?', as it is already done for ref().
3106         (WebCore::KURL::prettyURL): Append the query with the question mark.
3107
3108         * page/Location.cpp:
3109         (WebCore::Location::search): Return an empty string if query is empty or missing.
3110         (WebCore::Location::hash): Return an empty string for empty hashes, not only missing ones.
3111
3112         * dom/WorkerLocation.cpp:
3113         (WebCore::WorkerLocation::search):
3114         (WebCore::WorkerLocation::hash):
3115         Match document.location fixes above.
3116
3117         * html/HTMLAnchorElement.cpp:
3118         (WebCore::HTMLAnchorElement::hash):
3119         (WebCore::HTMLAnchorElement::search):
3120         Return an empty string for empty and missing parts.
3121
3122 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3123
3124         Reviewed by Darin Adler.
3125
3126         https://bugs.webkit.org/show_bug.cgi?id=20184
3127         SELECT with no name generates invalid query string
3128
3129         Test: fast/forms/select-no-name.html
3130
3131         * html/HTMLSelectElement.cpp:
3132         (WebCore::HTMLSelectElement::appendFormData): Added a check for empty name.
3133
3134 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3135
3136         Apply review comments for the previous check-in (forgot to save the file, oops).
3137
3138         * dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren):
3139
3140 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3141
3142         Reviewed by Darin Adler.
3143
3144         https://bugs.webkit.org/show_bug.cgi?id=15707
3145         Crash when manipulating document from within an iframe onload function
3146
3147         Test: fast/dom/onload-open.html
3148
3149         * dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): Protect the container and
3150         the current node, because anything can happen when dispatching events.
3151
3152 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3153
3154         Reviewed by Darin Adler.
3155
3156         https://bugs.webkit.org/show_bug.cgi?id=18970
3157         Numerically named input fields cause document.forms loop problems
3158
3159         Test: fast/forms/numeric-input-name.html
3160
3161         * bindings/scripts/CodeGeneratorJS.pm: Try index getter before name getter, even if the
3162         latter overrides properties.
3163
3164 2009-02-23  Alexey Proskuryakov  <ap@webkit.org>
3165
3166         Reviewed by Sam Weinig.
3167
3168         https://bugs.webkit.org/show_bug.cgi?id=24059
3169         Tokenizer::write() return value is never used
3170
3171         * dom/Tokenizer.h:
3172         * dom/XMLTokenizer.cpp:
3173         (WebCore::XMLTokenizer::write):
3174         * dom/XMLTokenizer.h:
3175         * html/HTMLTokenizer.cpp:
3176         (WebCore::HTMLTokenizer::write):
3177         * html/HTMLTokenizer.h:
3178         * loader/FTPDirectoryDocument.cpp:
3179         (WebCore::FTPDirectoryTokenizer::write):
3180         * loader/ImageDocument.cpp:
3181         (WebCore::ImageTokenizer::write):
3182         * loader/MediaDocument.cpp:
3183         (WebCore::MediaTokenizer::write):
3184         * loader/PluginDocument.cpp:
3185         (WebCore::PluginTokenizer::write):
3186         * loader/TextDocument.cpp:
3187         (WebCore::TextTokenizer::write):
3188         Made write() return void, not bool.
3189
3190 2009-02-20  Geoffrey Garen  <ggaren@apple.com>
3191
3192         Reviewed by Sam Weinig.
3193
3194         Updated for JavaScriptCore changes to timeout checking.
3195
3196         * bindings/js/JSCustomPositionCallback.cpp:
3197         (WebCore::JSCustomPositionCallback::handleEvent):
3198         * bindings/js/JSCustomPositionErrorCallback.cpp:
3199         (WebCore::JSCustomPositionErrorCallback::handleEvent):
3200         * bindings/js/JSCustomSQLStatementCallback.cpp:
3201         (WebCore::JSCustomSQLStatementCallback::handleEvent):
3202         * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
3203         (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
3204         * bindings/js/JSCustomSQLTransactionCallback.cpp:
3205         (WebCore::JSCustomSQLTransactionCallback::handleEvent):
3206         * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
3207         (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
3208         * bindings/js/JSCustomVoidCallback.cpp:
3209         (WebCore::JSCustomVoidCallback::handleEvent):
3210         * bindings/js/JSCustomXPathNSResolver.cpp:
3211         (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
3212         * bindings/js/JSDOMWindowBase.cpp:
3213         (WebCore::JSDOMWindowBase::JSDOMWindowBase):
3214         (WebCore::JSDOMWindowBase::commonJSGlobalData):
3215         * bindings/js/JSEventListener.cpp:
3216         (WebCore::JSAbstractEventListener::handleEvent):
3217         * bindings/js/ScheduledAction.cpp:
3218         (WebCore::ScheduledAction::executeFunctionInContext):
3219         * bindings/js/ScriptController.cpp:
3220         (WebCore::ScriptController::evaluate):
3221         * bindings/js/WorkerScriptController.cpp:
3222         (WebCore::WorkerScriptController::evaluate):
3223         (WebCore::WorkerScriptController::forbidExecution):
3224         * bindings/objc/WebScriptObject.mm:
3225         (-[WebScriptObject callWebScriptMethod:withArguments:]):
3226         (-[WebScriptObject evaluateWebScript:]):
3227         * bridge/NP_jsobject.cpp:
3228         (_NPN_InvokeDefault):
3229         (_NPN_Invoke):
3230         (_NPN_Evaluate):
3231         (_NPN_Construct):
3232         * bridge/jni/jni_jsobject.mm:
3233         (JavaJSObject::call):
3234         (JavaJSObject::eval):
3235
3236 2009-02-21  Hironori Bono  <hbono@chromium.org>
3237
3238         Reviewed by Alexey Proskuryakov.
3239
3240         https://bugs.webkit.org/show_bug.cgi?id=23786
3241         [Chromium] line-break characters in a complex text are treated as zero-width spaces
3242
3243         This change prevents the UniscribeHelper class from treating the line-break characters
3244         as whitespaces.
3245
3246         Tests: fast/text/international/bidi-linebreak-001.html
3247                fast/text/international/bidi-linebreak-002.html
3248                fast/text/international/bidi-linebreak-003.html
3249
3250         * platform/graphics/chromium/UniscribeHelper.cpp:
3251         (WebCore::UniscribeHelper::adjustSpaceAdvances):
3252         Make the UniscribeHelper::adjustSpaceAdvances() function treat all characters in
3253         the treatAsSpace() function (e.g. U+0020, U+000A, U+000D, U+00A0) as whitespaces,
3254         so does when Chromium renders a simple text.
3255
3256 2009-02-20  Julien Chaffraix  <jchaffraix@webkit.org>
3257
3258         Reviewed by Alexey Proskuryakov.
3259
3260         Bug 23940: Use Document::createElement(const QualifiedName&, bool) when creating a known element inside WebCore
3261
3262         Document::createElement(const QualifiedName&, bool) does not check for the prefix as opposed the the one taking an AtomicString
3263         or Document::createElementNS. This is perfectly fine internally because we know the type of element created and the check is
3264         unneeded.
3265
3266         It also removes the use of an ExceptionCode argument which was here only to check that the prefix check was fine. Finally it
3267         enables us to use some generated QualifiedName.
3268
3269         * bindings/js/JSOptionConstructor.cpp:
3270         (WebCore::constructHTMLOptionElement):
3271         * dom/Document.cpp:
3272         (WebCore::Document::setTitle):
3273         * dom/XMLTokenizer.cpp:
3274         (WebCore::createXHTMLParserErrorHeader):
3275         (WebCore::XMLTokenizer::insertErrorMessageBlock):
3276         * editing/CompositeEditCommand.cpp:
3277         (WebCore::createBlockPlaceholderElement):
3278         * editing/htmlediting.cpp:
3279         (WebCore::createTabSpanElement):
3280         * html/HTMLSelectElement.cpp:
3281         (WebCore::HTMLSelectElement::setLength):
3282         * loader/FTPDirectoryDocument.cpp:
3283         (WebCore::FTPDirectoryTokenizer::appendEntry):
3284         (WebCore::FTPDirectoryTokenizer::createTDForFilename):
3285         (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate):
3286         (WebCore::FTPDirectoryTokenizer::createBasicDocument):
3287         * loader/ImageDocument.cpp:
3288         (WebCore::ImageDocument::createDocumentStructure):
3289         * loader/MediaDocument.cpp:
3290         (WebCore::MediaTokenizer::createDocumentStructure):
3291         * loader/PluginDocument.cpp:
3292         (WebCore::PluginTokenizer::createDocumentStructure):
3293         * loader/TextDocument.cpp:
3294         (WebCore::TextTokenizer::write):
3295         * page/Frame.cpp:
3296         (WebCore::Frame::selectionComputedStyle):
3297         (WebCore::Frame::styleForSelectionStart):
3298         Document::createElement(const AtomicString&, ...) to Document::createElement(const QualifiedName&, ...) switch.
3299
3300         * xml/XPathFunctions.cpp:
3301         (WebCore::XPath::FunLang::evaluate): Re-use langAttr instead of creating a new attribute.
3302         * page/DragController.cpp:
3303         (WebCore::documentFragmentFromDragData): Use the HTMLAnchorElement directly to get rid of the static cast.
3304
3305 2009-02-19  Dimitri Glazkov  <dglazkov@chromium.org>
3306
3307         Reviewed by Eric Seidel.
3308
3309         https://bugs.webkit.org/show_bug.cgi?id=24060
3310         Fix up to accommodate for CanvasPixelArray return.
3311
3312         * platform/graphics/skia/ImageBufferSkia.cpp:
3313         (WebCore::ImageBuffer::getImageData): Added an extra data() to call.
3314         (WebCore::ImageBuffer::putImageData): Ditto.
3315
3316 2009-02-20  Eric Carlson  <eric.carlson@apple.com>
3317
3318         Simon Fraser
3319
3320         https://bugs.webkit.org/show_bug.cgi?id=24042
3321         Bug 24042: MediaPlayer should cache plug-in proxy
3322
3323         The changes in https://bugs.webkit.org/show_bug.cgi?id=23917 assume that
3324         MediaPlayer will always have created the private media player object before
3325         the plug-in is instantiated and calls back with the proxy object. This is not
3326         true on all platforms because of threading latency, so MediaPlayer should
3327         cache the plug-in proxy so it can pass it to the media engine at a later time.
3328
3329         * platform/graphics/MediaPlayer.cpp:
3330         (WebCore::NullMediaPlayerPrivate::setPoster): Null media engine implementation of proxy methods.
3331         (WebCore::NullMediaPlayerPrivate::deliverNotification): Ditto.
3332         (WebCore::NullMediaPlayerPrivate::setMediaPlayerProxy): Ditto.
3333         (WebCore::MediaPlayer::MediaPlayer): Initialize m_playerProxy.
3334         (WebCore::MediaPlayer::load): Pass m_playerProxy to newly created engine.
3335         (WebCore::MediaPlayer::setMediaPlayerProxy): Cache m_playerProxy.
3336         * platform/graphics/MediaPlayer.h: Declare m_playerProxy.
3337
3338 2009-02-20  Eric Carlson  <eric.carlson@apple.com>
3339
3340         Simon Fraser.
3341
3342         https://bugs.webkit.org/show_bug.cgi?id=24063
3343         Make it possible for a port to require a user gesture to play/pause an <audio> or <video> element
3344
3345         * html/HTMLMediaElement.cpp:
3346         (WebCore::HTMLMediaElement::HTMLMediaElement):  Rename m_loadRestrictions to m_Restrictions.
3347         Initialize m_internalCall.
3348         (WebCore::HTMLMediaElement::loadTimerFired): Increment m_internalCall around call to load().
3349         (WebCore::HTMLMediaElement::load): Call loadInternal if restrictions check out.
3350         (WebCore::HTMLMediaElement::loadInternal): New, guts of old load()
3351         (WebCore::HTMLMediaElement::setNetworkState): Fix bug introduced in r40943
3352         (WebCore::HTMLMediaElement::play): Call playInternal if restrictions check out.
3353         (WebCore::HTMLMediaElement::playInternal): New, guts of old play()
3354         (WebCore::HTMLMediaElement::pause): Call pauseInternal if restrictions check out.
3355         (WebCore::HTMLMediaElement::pauseInternal): New, guts of old pause()
3356         (WebCore::HTMLMediaElement::togglePlayState): Call playInternal/pauseInternal
3357         (WebCore::HTMLMediaElement::deliverNotification): Remove unnecessary white space.
3358         * html/HTMLMediaElement.h: Rename m_loadRestrictions to m_Restrictions, add m_internalCall,
3359         add RequireUserGestureRateChangeRestriction.
3360
3361 2009-02-20  Darin Fisher  <darin@chromium.org>
3362
3363         Fix build bustage in FileSystemWin.cpp.
3364
3365         Need to return CString() instead of 0 since there are now two CString
3366         constructors that take a pointer type.
3367
3368         * platform/win/FileSystemWin.cpp:
3369         (WebCore::openTemporaryFile):
3370
3371 2009-02-20  Dimitri Glazkov  <dglazkov@chromium.org>
3372
3373         Reviewed by Sam Weinig.
3374
3375         https://bugs.webkit.org/show_bug.cgi?id=23999
3376         Change license headers to accurately reflect code history.
3377
3378         * platform/ContentType.cpp:
3379         * platform/ContentType.h:
3380
3381 2009-02-18  Dimitri Glazkov  <dglazkov@chromium.org>
3382
3383         Reviewed by Antti Koivisto.
3384
3385         https://bugs.webkit.org/show_bug.cgi?id=23999
3386         Split off MIME type parsing into its own class.
3387
3388         * GNUmakefile.am: Added ContentType sources.
3389         * WebCore.pro: Ditto.
3390         * WebCore.scons: Ditto.
3391         * WebCore.vcproj/WebCore.vcproj: Ditto.
3392         * WebCore.xcodeproj/project.pbxproj: Ditto.
3393         * WebCoreSources.bkl: Ditto.
3394         * html/HTMLMediaElement.cpp: Changed to use ContentType.
3395         (WebCore::HTMLMediaElement::selectMediaURL):
3396         * platform/ContentType.cpp: Added.
3397         (WebCore::ContentType::ContentType):
3398         (WebCore::ContentType::parameter):
3399         (WebCore::ContentType::type):
3400         * platform/ContentType.h: Added.
3401         (WebCore::ContentType::raw):
3402         * platform/MIMETypeRegistry.cpp:
3403         * platform/MIMETypeRegistry.h:
3404         * platform/graphics/MediaPlayer.cpp:
3405         (WebCore::MediaPlayer::load):
3406         * rendering/style/ContentData.h: Renamed ContentType to StyleContentType.
3407         * rendering/style/RenderStyleConstants.h: Ditto.
3408         (WebCore::):
3409
3410 2009-02-20  Holger Hans Peter Freyther  <zecke@selfish.org>
3411
3412         Unreviewed build fix.
3413
3414         Use CString() instead of 0.
3415
3416         * platform/gtk/FileSystemGtk.cpp:
3417         (WebCore::openTemporaryFile):
3418         * platform/qt/FileSystemQt.cpp:
3419         (WebCore::openTemporaryFile):
3420
3421 2009-02-20  Gustavo Noronha Silva  <gns@gnome.org>
3422
3423         Reviewed by Holger Freyther.
3424
3425         When dealing with local files, use a path instead of an URI. GFile
3426         has problems decoding URIs with percent signs on them.
3427
3428         * platform/network/soup/ResourceHandleSoup.cpp:
3429         (WebCore::ResourceHandle::startGio):
3430
3431 2009-02-20  Gustavo Noronha Silva  <gns@gnome.org>
3432
3433         Reviewed by Holger Freyther.
3434
3435         Protect the ResourceHandle instance from being destroyed by
3436         didReceiveData inside the GIO readCallback call, so that
3437         cancelling caused by scripts is handled correctly.
3438
3439         * platform/network/soup/ResourceHandleSoup.cpp:
3440         (WebCore::readCallback):
3441
3442 2009-02-20  David Kilzer  <ddkilzer@apple.com>
3443
3444         Make IconDatabaseNone.cpp compile with -Wunused and pass check-for-exit-time-destructors
3445
3446         Reviewed by Sam Weinig.
3447
3448         * loader/icon/IconDatabaseNone.cpp:
3449         (WebCore::IconDatabase::defaultDatabaseFilename): Use DEFINE_STATIC_LOCAL().
3450         (WebCore::IconDatabase::open): Commented out unused parameter.
3451         (WebCore::IconDatabase::setPrivateBrowsingEnabled): Ditto.
3452         (WebCore::IconDatabase::iconForPageURL): Ditto.
3453         (WebCore::IconDatabase::iconURLForPageURL): Ditto.
3454         (WebCore::IconDatabase::defaultIcon): Ditto.
3455         (WebCore::IconDatabase::retainIconForPageURL): Ditto.
3456         (WebCore::IconDatabase::releaseIconForPageURL): Ditto.
3457         (WebCore::IconDatabase::setIconDataForIconURL): Ditto.
3458         (WebCore::IconDatabase::setIconURLForPageURL): Ditto.
3459         (WebCore::IconDatabase::setEnabled): Ditto.
3460         (WebCore::IconDatabase::pageURLMappingCount): Added stub.
3461         (WebCore::IconDatabase::retainedPageURLCount): Ditto.
3462         (WebCore::IconDatabase::iconRecordCount): Ditto.
3463         (WebCore::IconDatabase::iconRecordCountWithData): Ditto.
3464
3465 2009-02-20  David Kilzer  <ddkilzer@apple.com>
3466
3467         Add comment to generated code when shadowing a built-in object
3468
3469         Reviewed by Sam Weinig.
3470
3471         * bindings/scripts/CodeGeneratorJS.pm: Added comment to
3472         generated code output.
3473
3474 2009-02-20  Avi Drissman  <avi@chromium.org>
3475
3476         Reviewed by Eric Seidel.
3477
3478         https://bugs.webkit.org/show_bug.cgi?id=24036
3479         Keyboard events need disambiguation on the Linux platform too.
3480
3481         * platform/chromium/PlatformKeyboardEventChromium.cpp:
3482         (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):
3483
3484 2009-02-19  Darin Fisher  <darin@chromium.org>
3485
3486         Reviewed by Eric Seidel.
3487
3488         https://bugs.webkit.org/show_bug.cgi?id=24046
3489
3490         Several improvements to CString:
3491         1- Make it possible to initialize a CString from a CStringBuffer
3492         2- Make it possible to get a CStringBuffer from a CString
3493         3- Change CStringBuffer::data() to return a const pointer to ward off mutation
3494         4- Remove unused releaseBuffer() methods.
3495         5- Make CStringBuffer::create() private to force consumers to get a CStringBuffer from a CString.
3496
3497         * platform/text/CString.cpp:
3498         (WebCore::CString::init):
3499         (WebCore::CString::mutableData):
3500         (WebCore::CString::newUninitialized):
3501         (WebCore::CString::copyBufferIfNeeded):
3502         * platform/text/CString.h:
3503         (WebCore::CStringBuffer::data):
3504         (WebCore::CStringBuffer::length):
3505         (WebCore::CStringBuffer::create):
3506         (WebCore::CStringBuffer::mutableData):
3507         (WebCore::CString::CString):
3508         (WebCore::CString::buffer):
3509
3510 2009-02-19  Dmitry Titov  <dimich@chromium.org>
3511
3512         Reviewed by Alexey Proskuryakov.
3513
3514         https://bugs.webkit.org/show_bug.cgi?id=24017
3515         Remove some usage of Document in Worker.
3516
3517         * dom/WorkerContext.h:
3518         (WebCore::WorkerContext::userAgent):
3519         * dom/Document.cpp:
3520         (WebCore::Document::userAgent):
3521         * dom/Document.h:
3522         * dom/ScriptExecutionContext.h:
3523         Added virtual ScriptExecutionContext::userAgent(const KURL&).
3524         Document implementation uses FrameLoader::userAgent and
3525         WorkerContext receives the string on creation and stores it in a member.
3526
3527         * dom/Worker.cpp:
3528         (WebCore::Worker::Worker):
3529         (WebCore::Worker::notifyFinished):
3530         * dom/Worker.h:
3531         (WebCore::Worker::create):
3532         Instead of Document the Worker constructor now gets a ScriptExecutionContext.
3533         Start using some methods on SEC (like completeURL() and userAgent()).
3534         For others, explicitly case to Document and add a FIXME.
3535         Remove Worker::document() too.
3536
3537 2009-02-20  Gustavo Noronha Silva  <gns@gnome.org>
3538
3539         Rubber-stamped by Holger Freyther.
3540
3541         Do not set httpStatus to SOUP_STATUS_OK when serving local files
3542         to match other ports' behavior, fixing xmlhttprequest test
3543         regressions.
3544
3545         * platform/network/soup/ResourceHandleSoup.cpp:
3546         (WebCore::queryInfoCallback):
3547
3548 2009-02-19  Dan Bernstein  <mitz@apple.com>
3549
3550         Reviewed by Sam Weinig.
3551
3552         - WebCore part of fixing https://bugs.webkit.org/show_bug.cgi?id=24027
3553           Do not send loader callbacks during CSS styling
3554
3555         Undo the iChat-specific quirk added in
3556         <http://trac.webkit.org/changeset/41071>. Instead, always suspend memory
3557         cache client callbacks during attach() and recalcStyle().
3558
3559         * WebCore.base.exp: Removed
3560         Settings::setNeedsIChatMemoryCacheCallsQuirk().
3561         * dom/ContainerNode.cpp:
3562         (WebCore::ContainerNode::suspendPostAttachCallbacks): Disable memory
3563         cache client callbacks and remember to enable them afterwards if needed.
3564         (WebCore::ContainerNode::resumePostAttachCallbacks): Re-enable memory
3565         cache client callbacks if they were disabled in
3566         suspendPostAttachCallbacks().
3567         (WebCore::ContainerNode::attach): Use suspendPostAttachCallbacks() and
3568         resumePostAttachCallbacks().
3569         * dom/ContainerNode.h: Made suspendPostAttachCallbacks()
3570         and resumePostAttachCallbacks() non-static.
3571         * dom/Document.cpp:
3572         (WebCore::Document::dispatchImageLoadEventsNow): Reverted iChat-specific
3573         workaround.
3574         * page/Settings.cpp: Removed m_needsIChatMemoryCacheCallsQuirk and
3575         related code.
3576         (WebCore::Settings::Settings):
3577         * page/Settings.h:
3578
3579 2009-02-19  Holger Hans Peter Freyther  <zecke@selfish.org>
3580
3581         Unreviewed build fix.
3582
3583         Build fix after r41092. Make the memoryUsage method
3584         public. It will be shadowed by cf/mac and for curl/soup/qt
3585         the implementation from ResourceResponseBase will be used.
3586
3587         * platform/network/ResourceResponseBase.h:
3588         (WebCore::ResourceResponseBase::memoryUsage):
3589
3590 2009-02-19  Beth Dakin  <bdakin@apple.com>
3591
3592         Reviewed by Dave Hyatt.
3593
3594         Fix for <rdar://problem/6077775> Should be able to specify
3595         inactive ::selection color
3596
3597         This patch makes the ::selction pseudo-element work with
3598         the :window-inactive pseudo type. This was, a user can specify a
3599         different ::selection style when a window is inactive.
3600
3601         * css/CSSStyleSelector.cpp:
3602         (WebCore::CSSStyleSelector::SelectorChecker::checkSelector):
3603         (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
3604         * rendering/RenderObject.cpp:
3605         (WebCore::RenderObject::selectionBackgroundColor):
3606         (WebCore::RenderObject::selectionForegroundColor):
3607
3608 2009-02-19  Sam Weinig  <sam@webkit.org>
3609
3610         Reviewed by Beth Dakin.